Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: less verbose debug in _getInterfaceStats .. sampling: less verbose debug in _getInterfaceStats HostStatsThread._getInterfaceStats() needs to compute network tx/rx rate from the sampled data. To help troubleshoot rate miscalculations, a debug log was added, to show on error (rate > 100%) all the samples used for computation. The problem here is that the log iterates over the gathered samples. We want to use SampleWindow in HostStatsThread to reduce code duplication, but SampleWindow doesn't give access to raw samples yet. To move further, we drop this detailed log for the time being. Future patches may want to reintroduce it on top of SampleWindow. Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40424 Reviewed-by: Ido Barkan Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/sampling.py 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Ido Barkan has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 5: Code-Review+1 Okay. -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Francesco Romani has posted comments on this change.
Change subject: sampling: less verbose debug in _getInterfaceStats
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40424/5/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 706: txRate = 100.0 * thisTx / interval / ifrate / Mbps2Bps
Line 707: if txRate > 100 or rxRate > 100:
Line 708: txRate = min(txRate, 100.0)
Line 709: rxRate = min(rxRate, 100.0)
Line 710: self._log.debug('Rate above 100%%.')
> Is it indeed introduced later? Even if so, I am not sure how common is it a
It is not, because Dan explained that this case was discovered (speed link
change), hence this log is no longer relevant.
I kept it anyway as cautionary move.
Line 711: iface = hs1.interfaces[ifid]
Line 712: stats['network'][ifid] = {'name': ifid, 'speed':
str(ifrate),
Line 713: 'rxDropped':
str(iface.rxDropped),
Line 714: 'txDropped':
str(iface.txDropped),
--
To view, visit https://gerrit.ovirt.org/40424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Ido Barkan has posted comments on this change.
Change subject: sampling: less verbose debug in _getInterfaceStats
..
Patch Set 5: Code-Review-1
(1 comment)
-1 for visibility (comments inside)
https://gerrit.ovirt.org/#/c/40424/5/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 706: txRate = 100.0 * thisTx / interval / ifrate / Mbps2Bps
Line 707: if txRate > 100 or rxRate > 100:
Line 708: txRate = min(txRate, 100.0)
Line 709: rxRate = min(rxRate, 100.0)
Line 710: self._log.debug('Rate above 100%%.')
Is it indeed introduced later? Even if so, I am not sure how common is it and
whether this log is even interesting but maybe you can leave some local data
(such as ifid).
Line 711: iface = hs1.interfaces[ifid]
Line 712: stats['network'][ifid] = {'name': ifid, 'speed':
str(ifrate),
Line 713: 'rxDropped':
str(iface.rxDropped),
Line 714: 'txDropped':
str(iface.txDropped),
--
To view, visit https://gerrit.ovirt.org/40424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 5: Verified+1 trivial patch which removes a part of a string. The leftover has no format inside, so little room for bugs. -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 5: rebased -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40424/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 708: if ifid not in hs0.interfaces: Line 709: continue Line 710: ifrate = hs1.interfaces[ifid].speed or 1000 Line 711: Mbps2Bps = (10 ** 6) / 8 Line 712: thisRx = (hs1.interfaces[ifid].rx - hs0.interfaces[ifid].rx) % \ I'd be happy if you add a #REQUIRED_FOR: engine < 3.6 since this whole rxRate/txRate should be deprecated. Line 713: (2 ** 32) Line 714: thisTx = (hs1.interfaces[ifid].tx - hs0.interfaces[ifid].tx) % \ Line 715: (2 ** 32) Line 716: rxRate = 100.0 * thisRx / interval / ifrate / Mbps2Bps -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1643/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18412/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18412/ -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1643/ -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Francesco Romani has uploaded a new change for review.
Change subject: sampling: less verbose debug in _getInterfaceStats
..
sampling: less verbose debug in _getInterfaceStats
HostStatsThread._getInterfaceStats needs, among other
things, to compute network tx/rx rate.
To help troubleshoot rate miscalculation, there is
a debug log which shows all the samples used for
computation.
The problem here is that the log cycles over the
internal samples. We want to use SampleWindow
in HostStatsThread to reduce code duplication,
but SampleWindow doesn't give access to samples yet.
To move further, we drop this detailed log for the time
being. Future patches may want to reintroduce it
on top of (enhanced) SampleWindow.
Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f
Signed-off-by: Francesco Romani
---
M vdsm/virt/sampling.py
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/40424/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index f5640d0..8878120 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -710,13 +710,7 @@
if txRate > 100 or rxRate > 100:
txRate = min(txRate, 100.0)
rxRate = min(rxRate, 100.0)
-self._log.debug('Rate above 100%%. DEBUG: ifid %s interval: '
-'%s thisRx %s thisTx %s samples %s', ifid,
-interval, thisRx, thisTx,
-[(hs.timestamp, hs.interfaces[ifid].rx,
- hs.interfaces[ifid].tx)
- for hs in self._samples if
- ifid in hs.interfaces])
+self._log.debug('Rate above 100%%.')
iface = hs1.interfaces[ifid]
stats['network'][ifid] = {'name': ifid, 'speed': str(ifrate),
'rxDropped': str(iface.rxDropped),
--
To view, visit https://gerrit.ovirt.org/40424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
