Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(4 comments)

https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt
File contrib/refmt:

Line 1: #!/usr/bin/python
> separate patch?
Done
Line 2: 
Line 3: # helper script to prettify Vdsm parameter dumps from the logs.
Line 4: # useful to extract test data.
Line 5: # This tool is intended to make it easier for humans to read


PS3, Line 8: data
> files
Done


PS3, Line 15: dump
> param.out
Done


https://gerrit.ovirt.org/#/c/59258/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS3, Line 4039: needs updating
> Do we want to update here?
we do, will take care of (some of) them still missing.


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59258/3/tests/testlib.py
File tests/testlib.py:

Line 566: raise exception
Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
> separate patch?
yes, better to split this further. Will do in the next upload.
Line 571: test_path = os.path.realpath(__file__)
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(4 comments)

https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt
File contrib/refmt:

Line 1: #!/usr/bin/python
separate patch?
Line 2: 
Line 3: # helper script to prettify Vdsm parameter dumps from the logs.
Line 4: # useful to extract test data.
Line 5: # This tool is intended to make it easier for humans to read


https://gerrit.ovirt.org/#/c/59258/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS3, Line 4039: needs updating
Do we want to update here?


https://gerrit.ovirt.org/#/c/59258/3/tests/testlib.py
File tests/testlib.py:

Line 566: raise exception
Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
separate patch?
Line 571: test_path = os.path.realpath(__file__)
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


https://gerrit.ovirt.org/#/c/59258/3/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:

PS3, Line 450: eval(read_data('vmcreate_args.out'))
I like it


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(2 comments)

need to split the changes to the schema in a series. This patch will fix 
VM.create only.

https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt
File contrib/refmt:

PS3, Line 8: data
files


PS3, Line 15: dump
param.out

for consistency with line 13


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

Data always comes from oVirt Engine Version: 4.0.0.4-1.el7.centos

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3: Code-Review-1

still broken, as per previous patchset

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-07-06 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 2: Code-Review-1

WIP, still broken.

Data comes from oVirt Engine Version: 4.0.0.4-1.el7.centos

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-06-28 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 1: Code-Review-1

add test like https://gerrit.ovirt.org/#/c/59703/

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-06-15 Thread fromani 
Francesco Romani has uploaded a new change for review.

Change subject: schema: use datatype to silence inconsistencies
..

schema: use datatype to silence inconsistencies

Make use of datatype/type annotations to silence
_report_inconsistencies and at least document those
inconsistencies.
We cannot really fix this until we fix the Engine side,
for backward compatibility.

Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Signed-off-by: Francesco Romani 
---
M lib/api/vdsm-api.yml
1 file changed, 72 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/59258/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index b537e8e..a2ae77f 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -3851,7 +3851,8 @@
 description: Enables hyperv specific optimizations for the Guest
 OS
 name: hypervEnable
-type: boolean
+datatype: boolean
+type: string
 added: '3.5'
 
 -   defaultvalue: needs updating
@@ -3867,11 +3868,13 @@
 
 -   description: The amount of memory assigned to the VM in MB
 name: memSize
-type: uint
+datatype: uint
+type: string
 
 -   description: The number of CPUs presented to the VM
 name: smp
-type: uint
+datatype: uint
+type: string
 
 -   defaultvalue: 16
 description: Maximum number of memory slots available This is
@@ -3890,7 +3893,8 @@
 description: Specify if file transfer is enabled. Currently
 relevant for qxl devices only.
 name: fileTransferEnable
-type: boolean
+datatype: boolean
+type: string
 added: '3.6'
 
 -   defaultvalue: pc
@@ -3900,41 +3904,48 @@
 
 -   description: Indicates if KVM hardware acceleration is enabled
 name: kvmEnable
-type: boolean
+datatype: boolean
+type: string
 
 -   description: Indicates if the Transparent Huge Pages feature is
 enabled for this virtual machine
 name: transparentHugePages
-type: boolean
+datatype: boolean
+type: string
 
 -   description: The VM name
 name: vmName
 type: string
 
--   defaultvalue: needs updating
+-   defaultvalue: no-default
 description: The num of iothreads qemu allocates
 name: numOfIoThreads
-type: uint
+datatype: uint
+type: string
 
 -   description: The time difference from host to the VM in seconds
 name: timeOffset
-type: uint
+datatype: uint
+type: string
 
--   defaultvalue: needs updating
+-   defaultvalue: no-default
 description: The port in use for unencrypted display data
 name: displayPort
-type: int
+datatype: int
+type: string
 modified: '3.6'
 
 -   description: The host scheduling priority
 name: nice
-type: int
+datatype: int
+type: string
 
 -   description: The process ID of the underlying qemu process
 name: pid
-type: uint
+datatype: uint
+type: string
 
--   defaultvalue: needs updating
+-   defaultvalue: no-default
 description: Indicates the reason a VM has been paused
 name: pauseCode
 type: string
@@ -3948,30 +3959,34 @@
 
 -   description: Indicates if ACPI is enabled inside the VM
 name: acpiEnable
-type: boolean
+datatype: boolean
+type: string
 
--   defaultvalue: needs updating
+-   defaultvalue: no-default
 description: The port in use for encrypted display data
 name: displaySecurePort
-type: int
+datatype: int
+type: string
 modified: '3.6'
 
--   defaultvalue: needs updating
+-   defaultvalue: no-default
 description: The maximum amount of memory that can be assigned
 to the VM in MB
 name: maxMemSize
-type: uint
+datatype: uint
+type: string
 
 -   description: The IP address of the client connected to the display
 name: clientIp
 type: string
 
--   defaultvalue: needs updating
+-   defaultvalue: 1
 description: Indicates the number of CPU threads per core
 name: smpThreadsPerCore
-type: uint
+datatype: uint
+type: string
 
--   defaultvalue: needs updating
+

Change in vdsm[master]: schema: use datatype to silence inconsistencies

2016-06-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org