Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
Francesco Romani has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 4: Code-Review-1 It is OK for me to fix two brokentests in one patch (the solution's the same after all, and the changes are small), but commit message needs to be updated to reflect that. Once done, change's good for me. -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
Francesco Romani has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40346/2/tests/samplingTests.py File tests/samplingTests.py: Line 180: with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample', Line 181: NumaNodeMemorySampleMock)]): Line 182: with dummy_if() as dummy_name: Line 183: with vlan(self.NEW_VLAN, dummy_name, 999): Line 184: hs = sampling.HostSample(os.getpid()) > well, I guess I initially called HostSample constructor to catch future cas Your approach *is* more correct - we should test public interface, not private one. Problem is that HostSample needs a serious amount a refactoring, so this is impractical due to the huge amount of faking and monkeypatching required. In the end, this will make the test worse. On a positive side, I begun a (low-priority :( ) refactoring of the missing bits of sampling.py, including HostSample and co. Reviews will be appreciated! :) Line 185: self.assertNotIn(self.NEW_VLAN, hs.interfaces) Line 186: Line 187: Line 188: @expandPermutations -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18318/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1548/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18317/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1547/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18318/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1548/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
automat...@ovirt.org has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18317/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
automat...@ovirt.org has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1547/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
Ido Barkan has posted comments on this change.
Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40346/2/tests/samplingTests.py
File tests/samplingTests.py:
Line 149: s1 = sampling.InterfaceSample(lo)
Line 150: s1.operstate = 'x'
Line 151: self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 152:
Line 153: @brokentest("Broken unless libvirtd is running")
this test also needs to be fixed in the same manner.
Line 154: @MonkeyPatch(libvirtconnection, '_read_password', read_password)
Line 155: @ValidateRunningAsRoot
Line 156: def testHostSampleReportsNewInterface(self):
Line 157: hs_before = sampling.HostSample(os.getpid())
Line 176: d
> This looks like a Fake, not a Mock
after handling your other comment, this was thrown away
Line 180: with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample',
Line 181: NumaNodeMemorySampleMock)]):
Line 182: with dummy_if() as dummy_name:
Line 183: with vlan(self.NEW_VLAN, dummy_name, 999):
Line 184: hs = sampling.HostSample(os.getpid())
> HostSample needs a lot of love, and unfortunately is pretty low on everyone
well, I guess I initially called HostSample constructor to catch future cases
(and because that what the application does!) but I feel the pain.
Line 185: self.assertNotIn(self.NEW_VLAN, hs.interfaces)
Line 186:
Line 187:
Line 188: @expandPermutations
--
To view, visit https://gerrit.ovirt.org/40346
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
Dan Kenigsberg has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40346/2/tests/samplingTests.py File tests/samplingTests.py: Line 180: with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample', Line 181: NumaNodeMemorySampleMock)]): Line 182: with dummy_if() as dummy_name: Line 183: with vlan(self.NEW_VLAN, dummy_name, 999): Line 184: hs = sampling.HostSample(os.getpid()) > HostSample needs a lot of love, and unfortunately is pretty low on everyone +1, I think it's a good idea, that would make the mock/fake unnecessary. Line 185: self.assertNotIn(self.NEW_VLAN, hs.interfaces) Line 186: Line 187: Line 188: @expandPermutations -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
Francesco Romani has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: Code-Review-1 (2 comments) -1 for visibility. Proposal inside to hopefully make things easier. https://gerrit.ovirt.org/#/c/40346/2/tests/samplingTests.py File tests/samplingTests.py: Line 176: d This looks like a Fake, not a Mock Line 180: with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample', Line 181: NumaNodeMemorySampleMock)]): Line 182: with dummy_if() as dummy_name: Line 183: with vlan(self.NEW_VLAN, dummy_name, 999): Line 184: hs = sampling.HostSample(os.getpid()) HostSample needs a lot of love, and unfortunately is pretty low on everyone's TODO. What about just calling interfaces = sampling._get_interfaces_and_sample() and avoid HostSample whenever possible? Should be good enough for your needs. Line 185: self.assertNotIn(self.NEW_VLAN, hs.interfaces) Line 186: Line 187: Line 188: @expandPermutations -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1511/ : 0 -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1510/ : 0 -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1511/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 1: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1510/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18280/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18281/ -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
automat...@ovirt.org has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces when...
Ido Barkan has uploaded a new change for review.
Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces when
libvirtd is stopped
..
unbreak testHostSampleHandlesDisappearingVlanInterfaces when
libvirtd is stopped
Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e
Signed-off-by: Ido Barkan
---
M tests/samplingTests.py
1 file changed, 10 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/40346/1
diff --git a/tests/samplingTests.py b/tests/samplingTests.py
index 2624dd7..3d53180 100644
--- a/tests/samplingTests.py
+++ b/tests/samplingTests.py
@@ -163,7 +163,6 @@
interfaces_diff = interfaces_after - interfaces_before
self.assertEqual(interfaces_diff, set([dummy_name]))
-@brokentest("Broken unless libvirtd is running")
@MonkeyPatch(libvirtconnection, '_read_password', read_password)
@ValidateRunningAsRoot
def testHostSampleHandlesDisappearingVlanInterfaces(self):
@@ -174,12 +173,16 @@
ipwrapper.linkDel(self.NEW_VLAN)
return iter(all_links)
-with MonkeyPatchScope(
-[(ipwrapper, 'getLinks', faultyGetLinks)]):
-with dummy_if() as dummy_name:
-with vlan(self.NEW_VLAN, dummy_name, 999):
-hs = sampling.HostSample(os.getpid())
-self.assertNotIn(self.NEW_VLAN, hs.interfaces)
+class NumaNodeMemorySampleMock(object):
+pass
+
+with MonkeyPatchScope([(ipwrapper, 'getLinks', faultyGetLinks)]):
+with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample',
+NumaNodeMemorySampleMock)]):
+with dummy_if() as dummy_name:
+with vlan(self.NEW_VLAN, dummy_name, 999):
+hs = sampling.HostSample(os.getpid())
+self.assertNotIn(self.NEW_VLAN, hs.interfaces)
@expandPermutations
--
To view, visit https://gerrit.ovirt.org/40346
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces when...
automat...@ovirt.org has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces when libvirtd is stopped .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
