Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Francesco Romani has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Nir Soffer has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Shahar Havivi has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Nir Soffer has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40003/4/client/vdsClient.py File client/vdsClient.py: Line 1921: def convertExternalVm(self, args): Line 1922: validateArgTypes(args, [str, str, str, parse_dict, str], Line 1923: requiredArgsNumber=5) Line 1924: uri, username, auth, vminfo, jobid = args Line 1925: passwd = parsePassword(auth) > Instead of adding new confusing parsePassword function, you can use the exi Bug parseArgs except a list not a string - so: d = parseArgs([auth]) password = getAuthFromArgs(d, auth) Line 1926: response = self.s.convertExternalVm(uri, username, passwd, vminfo, Line 1927: jobid) Line 1928: if response['status']['code'] != 0: Line 1929: return response['status']['code'], response['status']['message'] -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Nir Soffer has posted comments on this change.
Change subject: v2v: Add convertExternalVm for XmlRpc
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/40003/4/client/vdsClient.py
File client/vdsClient.py:
Line 173: return getPassword(args['auth'])
Line 174: return default
Line 175:
Line 176:
Line 177: def parsePassword(string):
Having both parsePassword and getPassword is little bit confusing.
Line 178: if string.startswith('auth='):
Line 179: return getPassword(string.split('=')[1])
Line 180: return string
Line 181:
Line 1921: def convertExternalVm(self, args):
Line 1922: validateArgTypes(args, [str, str, str, parse_dict, str],
Line 1923: requiredArgsNumber=5)
Line 1924: uri, username, auth, vminfo, jobid = args
Line 1925: passwd = parsePassword(auth)
Instead of adding new confusing parsePassword function, you can use the
existing infrastructure:
d = parseArgs(auth)
password = getAuthFromArgs(d, auth)
It is very good infrastructure, but we should fix all places parsing auth=, not
add multiple incompatible ways to do the same thing.
Line 1926: response = self.s.convertExternalVm(uri, username, passwd,
vminfo,
Line 1927: jobid)
Line 1928: if response['status']['code'] != 0:
Line 1929: return response['status']['code'],
response['status']['message']
Line 2804: ' uri: uri of external system (vmware etc)',
Line 2805: ' username: login name for given uri',
Line 2806: ' auth: password for given uri, can be: ',
Line 2807: 'plain text password or auth=file:path '
Line 2808: 'or auth=env:name or auth=pass:password',
Should be indented so it aligns with "plain text..."
Line 2809: ' vminfo: Python dictionary, parameter for
import:',
Line 2810: '{"vmName": "name",',
Line 2811: ' "poolId":, "",',
Line 2812: ' "domainId": "",',
Line 2812: ' "domainId": "",',
--
To view, visit https://gerrit.ovirt.org/40003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 4: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18259/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1489/ : 0 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 4: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1489/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 4: -Code-Review -Verified Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18259/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Shahar Havivi has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 3: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18189/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1419/ : 0 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18189/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 3: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1419/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Shahar Havivi has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40003/2/client/vdsClient.py File client/vdsClient.py: Line 1927: def convertExternalVm(self, args): Line 1928: validateArgTypes(args, [str, str, str, parse_dict, str], Line 1929: requiredArgsNumber=5) Line 1930: uri, username, password, properties, job_id = args Line 1931: password = getAuthFromArgs(args, password) > Should be: There is no consistency in the passwords... I will add function that parse regular password or use getAuthFromArgs() Line 1932: response = self.s.convertExternalVm(uri, username, password, Line 1933: properties, job_id) Line 1934: if response['status']['code'] != 0: Line 1935: return response['status']['code'], response['status']['message'] -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Nir Soffer has posted comments on this change.
Change subject: v2v: Add convertExternalVm for XmlRpc
..
Patch Set 2:
(3 comments)
Other documentation issues
https://gerrit.ovirt.org/#/c/40003/2/client/vdsClient.py
File client/vdsClient.py:
Line 2819: ' uri: uri of external system (vmware etc)',
Line 2820: ' username: login name for given uri',
Line 2821: ' auth: password for given uri, can be: ',
Line 2822: 'file:path or auth=env:name or
auth=pass:password',
Line 2823: ' vminfo: string dictionary, parameter for
import:',
"string dictionary" is not clear - should be "Python dictionary" - same name
we use in downloadImage and other places.
Line 2824: '{"vmName": "name",',
Line 2825: ' "poolId":, "",',
Line 2826: ' "domainId": "",',
Line 2826: ' "domainId": "",',
Line 2828: ' "imageId": ""},',
Line 2829: ' {"volumeId": "",',
Line 2830: ' "imageId": ""}]}',
"imageId" should be aligned with "volumeId".
Line 2831: ' jobId:identify the job to report back
via Stats'
Line 2832: )),
Line 2833: }
Line 2834: if _glusterEnabled:
Line 2827: ' "disks": [{"volumeId": "",',
Line 2828: ' "imageId": ""},',
Line 2829: ' {"volumeId": "",',
Line 2830: ' "imageId": ""}]}',
Line 2831: ' jobId:identify the job to report back
via Stats'
rename "Guid" to "UUID" in all the parameters.
There is GUID but not Guid. We use the term UUID in vdsm. GUID is used for
multipath devices, not for uuid4 uuids.
Line 2832: )),
Line 2833: }
Line 2834: if _glusterEnabled:
Line 2835: commands.update(ge.getGlusterCmdDict(serv))
--
To view, visit https://gerrit.ovirt.org/40003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Nir Soffer has posted comments on this change.
Change subject: v2v: Add convertExternalVm for XmlRpc
..
Patch Set 2: Code-Review-1
(4 comments)
Need to fix password handling and and docs, and make names match the schema or
the help.
https://gerrit.ovirt.org/#/c/40003/2/client/vdsClient.py
File client/vdsClient.py:
Line 1926:
Line 1927: def convertExternalVm(self, args):
Line 1928: validateArgTypes(args, [str, str, str, parse_dict, str],
Line 1929: requiredArgsNumber=5)
Line 1930: uri, username, password, properties, job_id = args
- password should be auth (match the help, this raw auth string)
- properties should be vminfo (match the schema)
- job_id should be jobid (match the schema)
Line 1931: password = getAuthFromArgs(args, password)
Line 1932: response = self.s.convertExternalVm(uri, username, password,
Line 1933: properties, job_id)
Line 1934: if response['status']['code'] != 0:
Line 1927: def convertExternalVm(self, args):
Line 1928: validateArgTypes(args, [str, str, str, parse_dict, str],
Line 1929: requiredArgsNumber=5)
Line 1930: uri, username, password, properties, job_id = args
Line 1931: password = getAuthFromArgs(args, password)
Should be:
password = getPassword(auth)
If we like to support also plain password:
if auth.startswith('auth='):
password = getPassword(auth)
else:
password = auth
Not sure that we do want this - need to check what other verb support.
Line 1932: response = self.s.convertExternalVm(uri, username, password,
Line 1933: properties, job_id)
Line 1934: if response['status']['code'] != 0:
Line 1935: return response['status']['code'],
response['status']['message']
Line 1929: requiredArgsNumber=5)
Line 1930: uri, username, password, properties, job_id = args
Line 1931: password = getAuthFromArgs(args, password)
Line 1932: response = self.s.convertExternalVm(uri, username, password,
Line 1933: properties, job_id)
same
Line 1934: if response['status']['code'] != 0:
Line 1935: return response['status']['code'],
response['status']['message']
Line 1936: return 0, 'Job started'
Line 1937:
Line 2818: 'Argumemnts:',
Line 2819: ' uri: uri of external system (vmware etc)',
Line 2820: ' username: login name for given uri',
Line 2821: ' auth: password for given uri, can be: ',
Line 2822: 'file:path or auth=env:name or
auth=pass:password',
Are you sure this is the expected input?
I think it should be:
auth=file:path or auth=env:name or auth=pass:password
Do we want to support plain password also?
Please check other code using this auth mechanism and be consistent.
Line 2823: ' vminfo: string dictionary, parameter for
import:',
Line 2824: '{"vmName": "name",',
Line 2825: ' "poolId":, "",',
Line 2826: ' "domainId": "https://gerrit.ovirt.org/40003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18033/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17862/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18033/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17862/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Francesco Romani has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Shahar Havivi has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18001/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17830/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17830/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18001/ -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: Add convertExternalVm for XmlRpc
..
v2v: Add convertExternalVm for XmlRpc
Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a
Signed-off-by: Shahar Havivi
---
M client/vdsClient.py
1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/40003/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 6a199d5..8ddc45a 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -192,6 +192,13 @@
return ret
+def parse_dict(self, dict_str):
+d = ast.literal_eval(dict_str)
+if type(d) != dict:
+raise ValueError("Invalid option %r" % dict_str)
+return d
+
+
class service:
def __init__(self):
self.useSSL = False
@@ -1917,6 +1924,16 @@
return status['status']['code'], status['status']['message']
+def convertExternalVm(self, args):
+validateArgTypes(args, [str, str, str, parse_dict, str],
+ requiredArgsNumber=5)
+uri, username, password, properties, job_id = args
+password = getAuthFromArgs(args, password)
+response = self.s.convertExternalVm(uri, username, password,
+properties, job_id)
+if response['status']['code'] != 0:
+return response['status']['code'], response['status']['message']
+return 0, 'Job started'
if __name__ == '__main__':
if _glusterEnabled:
@@ -2794,6 +2811,25 @@
' ',
'get VMs from external hypervisor'
)),
+'convertExternalVm': (
+serv.convertExternalVm, (
+'',
+'Import and convert VM from external system',
+'Argumemnts:',
+' uri: uri of external system (vmware etc)',
+' username: login name for given uri',
+' auth: password for given uri, can be: ',
+'file:path or auth=env:name or auth=pass:password',
+' vminfo: string dictionary, parameter for import:',
+'{"vmName": "name",',
+' "poolId":, "",',
+' "domainId": "",',
+' "imageId": ""},',
+' {"volumeId": "",',
+' "imageId": ""}]}',
+' jobId:identify the job to report back via Stats'
+)),
}
if _glusterEnabled:
commands.update(ge.getGlusterCmdDict(serv))
--
To view, visit https://gerrit.ovirt.org/40003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
