Change in vdsm[master]: virt: graphics: enforce spice default mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 5: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: graphics: enforce spice default mode
..


virt: graphics: enforce spice default mode

Libvirt grants one additional protection layer for spice channels,
using the `defaultMode' attribute for the graphics device.
As the name hints, this allows us to select the default mode (secure,
insecure) for SPICE channels, if not explicitely specified.

This patch makes Vdsm use this attribute for improved security,
depending on the 'ssl' config value.

Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/56746
Reviewed-by: Michal Skrivanek 
Reviewed-by: Milan Zamazal 
Reviewed-by: Martin Polednik 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M tests/deviceTests.py
M vdsm/virt/vmdevices/graphics.py
2 files changed, 18 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Michal Skrivanek: Looks good to me, but someone else must approve
  Martin Polednik: Looks good to me, but someone else must approve
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 4: Code-Review+1

I don't think fedora jenkins works ok

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 4:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 4: Verified+1

verified again on live SPICE vm inspecting the xml and connecting to it from 
webadmin (succesfully)

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/56746/3/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 132: if not utils.tobool(self.specParams.get('fileTransferEnable', 
True)):
Line 133: filetransfer = vmxml.Element('filetransfer', enable='no')
Line 134: graphics.appendChild(filetransfer)
Line 135: 
Line 136: # This list could be dropped in 4.1. We should keep only
> might be worth adding that this can be dropped in 4.1 then as there is no r
Done
Line 137: # the default mode, which is both simpler and safer.
Line 138: if (self.device == 'spice' and
Line 139:'spiceSecureChannels' in self.specParams):
Line 140: for chan in self._getSpiceChannels():


-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/56746/3/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 132: if not utils.tobool(self.specParams.get('fileTransferEnable', 
True)):
Line 133: filetransfer = vmxml.Element('filetransfer', enable='no')
Line 134: graphics.appendChild(filetransfer)
Line 135: 
Line 136: if (self.device == 'spice' and
might be worth adding that this can be dropped in 4.1 then as there is no real 
use-case for enumerating channels and making some of them secure and some of 
them not. We can drop the list and keep the defaultMode instead
Line 137:'spiceSecureChannels' in self.specParams):
Line 138: for chan in self._getSpiceChannels():
Line 139: graphics.appendChildWithArgs('channel', name=chan,
Line 140:  mode='secure')


-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 2: Verified+1

verified with tests, running a VM and connecting using SPICE

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/56746/1//COMMIT_MSG
Commit Message:

PS1, Line 9: and
> an
Done


PS1, Line 10:  
> attribute?
Done


PS1, Line 13:  
> '
Done


-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 1: Code-Review+1

(3 comments)

The commit message could be improved a bit, codewise seems fine.

https://gerrit.ovirt.org/#/c/56746/1//COMMIT_MSG
Commit Message:

PS1, Line 9: and
an


PS1, Line 10:  
attribute?


PS1, Line 13:  
'


-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: virt: graphics: enforce spice default mode
..

virt: graphics: enforce spice default mode

Libvirt grants and additional protection layer for spice channels,
using the defaultMode of the graphics device.

This patch makes Vdsm explicitely set this value for improved security,
depending on the 'ssl config value.

Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Backport-To: 3.6
Signed-off-by: Francesco Romani 
---
M tests/deviceTests.py
M vdsm/virt/vmdevices/graphics.py
2 files changed, 16 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/56746/1

diff --git a/tests/deviceTests.py b/tests/deviceTests.py
index 40bba97..cd59dda 100644
--- a/tests/deviceTests.py
+++ b/tests/deviceTests.py
@@ -44,13 +44,15 @@
 
 GRAPHICS_XMLS = [
 """
-
 
 """,
 
 """
-
 
@@ -62,21 +64,24 @@
 """,
 
 """
-
 
 """,
 
 """
-
 
 """,
 
 """
-
 
diff --git a/vdsm/virt/vmdevices/graphics.py b/vdsm/virt/vmdevices/graphics.py
index 935ceca..2a0fe58 100644
--- a/vdsm/virt/vmdevices/graphics.py
+++ b/vdsm/virt/vmdevices/graphics.py
@@ -108,7 +108,12 @@
 graphicsAttrs = {
 'type': self.device,
 'port': self.port,
-'autoport': 'yes'}
+'autoport': 'yes',
+}
+if config.getboolean('vars', 'ssl'):
+graphicsAttrs['defaultMode'] = 'secure'
+# the default, 'any', has automatic fallback to
+# insecure mode, so works with ssl off.
 
 if self.device == 'spice':
 graphicsAttrs['tlsPort'] = self.tlsPort


-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: graphics: enforce spice default mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: graphics: enforce spice default mode
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches