Change in vdsm[master]: vmdevices: move storage methods to storage module
gerrit-hooks has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Jenkins CI RO has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Jenkins CI RO has abandoned this change. Change subject: vmdevices: move storage methods to storage module .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Nir Soffer has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 47: # TODO: use introspection
Line 48: return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT)
Line 49:
Line 50:
Line 51: def spec_list_from_legacy_conf(conf, arch):
> This function extracts *disk specs* from legacy conf. As such, it is very m
I don't want to maintain this here. Please don't make my life harder.
And this must not be at the top of the module.
Line 52: """
Line 53: Returns a list of drive specification dictionaries from legacy
vm.conf
Line 54: """
Line 55: conf_drives = conf.get('drives', [])
Line 73:
Line 74: def _spec_list_from_legacy_direct_paths(conf):
Line 75: """
Line 76: Backward compatibility for qa scripts that specify direct paths.
Line 77: """
> Michal mentions that we have to keep support of legacy devices as long as w
The conversion from legacy format to current format should be handled
elsewhere, ideally in one place - leagacy.py or format.py.
Line 78: legacies = []
Line 79: device_spec = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
Line 80: for index, linux_name in device_spec:
Line 81: path = conf.get(linux_name)
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Dan Kenigsberg has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 47: # TODO: use introspection
Line 48: return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT)
Line 49:
Line 50:
Line 51: def spec_list_from_legacy_conf(conf, arch):
> Nice idea, code will look less cluttered and the legacy stuff will be easie
This function extracts *disk specs* from legacy conf. As such, it is very much
related to storage.
I do not understand your suggestion regarding legacy.py. Could you elaborate?
We could keep a conversion of legacy-to-devices in a single vm.py function, but
I find it nicer to split it per device type.
Line 52: """
Line 53: Returns a list of drive specification dictionaries from legacy
vm.conf
Line 54: """
Line 55: conf_drives = conf.get('drives', [])
Line 73:
Line 74: def _spec_list_from_legacy_direct_paths(conf):
Line 75: """
Line 76: Backward compatibility for qa scripts that specify direct paths.
Line 77: """
> I think it's just noone cared/remembered to review this snipped before.
Michal mentions that we have to keep support of legacy devices as long as we
support clusterLevel=3.0. There may be running VMs with legacy conf, which we
want to accept on migration. :-(
Line 78: legacies = []
Line 79: device_spec = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
Line 80: for index, linux_name in device_spec:
Line 81: path = conf.get(linux_name)
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Francesco Romani has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 47: # TODO: use introspection
Line 48: return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT)
Line 49:
Line 50:
Line 51: def spec_list_from_legacy_conf(conf, arch):
> This is not related to storage. Please add legacy.py module for dealing wit
Nice idea, code will look less cluttered and the legacy stuff will be easier to
remove when time comes.
Line 52: """
Line 53: Returns a list of drive specification dictionaries from legacy
vm.conf
Line 54: """
Line 55: conf_drives = conf.get('drives', [])
Line 73:
Line 74: def _spec_list_from_legacy_direct_paths(conf):
Line 75: """
Line 76: Backward compatibility for qa scripts that specify direct paths.
Line 77: """
> Why wasn't the support removed before? Is it safe to remove or do we keep i
I think it's just noone cared/remembered to review this snipped before.
Line 78: legacies = []
Line 79: device_spec = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
Line 80: for index, linux_name in device_spec:
Line 81: path = conf.get(linux_name)
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Martin Polednik has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 73: Line 74: def _spec_list_from_legacy_direct_paths(conf): Line 75: """ Line 76: Backward compatibility for qa scripts that specify direct paths. Line 77: """ > I don't want to support these qa scripts, only the documented api. Why wasn't the support removed before? Is it safe to remove or do we keep it as legacy? I've only copied the code from vm.py, not added it. Line 78: legacies = [] Line 79: device_spec = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd')) Line 80: for index, linux_name in device_spec: Line 81: path = conf.get(linux_name) -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Nir Soffer has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 47: # TODO: use introspection
Line 48: return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT)
Line 49:
Line 50:
Line 51: def spec_list_from_legacy_conf(conf, arch):
This is not related to storage. Please add legacy.py module for dealing with
leagcy conf format.
Line 52: """
Line 53: Returns a list of drive specification dictionaries from legacy
vm.conf
Line 54: """
Line 55: conf_drives = conf.get('drives', [])
Line 73:
Line 74: def _spec_list_from_legacy_direct_paths(conf):
Line 75: """
Line 76: Backward compatibility for qa scripts that specify direct paths.
Line 77: """
I don't want to support these qa scripts, only the documented api.
Line 78: legacies = []
Line 79: device_spec = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
Line 80: for index, linux_name in device_spec:
Line 81: path = conf.get(linux_name)
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18358/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1588/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1588/ -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18358/ -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Nir Soffer has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/40133/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 45: # TODO: use introspection
Line 46: return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT)
Line 47:
Line 48:
Line 49: def spec_list_from_legacy_conf(conf, arch):
Please move these functions to end of the module.
Line 50: """
Line 51: Returns a list of drive specification dictionaries from legacy
vm.conf
Line 52: """
Line 53: conf_drives = conf.get('drives', [])
Line 68:
Line 69: return conf_drives
Line 70:
Line 71:
Line 72: def __spec_list_from_legacy_direct_paths(conf):
Don't use double underscores, one is enough
Line 73: """
Line 74: Backward compatibility for qa scripts that specify direct paths.
Line 75: """
Line 76: legacies = []
Line 84: 'truesize': 0})
Line 85: return legacies
Line 86:
Line 87:
Line 88: def __spec_list_from_legacy_removable_drives(conf, arch):
Same
Line 89: removables = [{
Line 90: 'type': hwclass.DISK,
Line 91: 'device': 'cdrom',
Line 92: 'iface': DEFAULT_INTERFACE_FOR_ARCH[arch],
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18065/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1294/ : 0 -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 3: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1294/ -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18052/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1281/ : 0 -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18065/ -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 2: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1281/ -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18052/ -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Francesco Romani has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 1: after seeing more examples of how will look like (40135, 40138), most of my doubts just vanished. Nice work. -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Francesco Romani has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 1: I like the concept, but not yet 100% sure. it *is* storage-related code, it *must* be moved away from Vm class (and from vm.py), but not 100% sure this belongs under vmdevices/storage.py, because so far vmdevices/* contains device objects, not device conf/helpers. It could be just matter of declaring that vmdevices/* can contain _also_ conf and helpers, however :) -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Vinzenz Feenstra has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: move storage methods to storage module .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17995/ -- To view, visit https://gerrit.ovirt.org/40133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: move storage methods to storage module
Martin Polednik has uploaded a new change for review.
Change subject: vmdevices: move storage methods to storage module
..
vmdevices: move storage methods to storage module
Some of the methods found in VM class are heavily related to
legacy configuration parsing for storage. These can be safely moved to
storage module, reducing VM class polution and contributing to a better
code.
Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Signed-off-by: Martin Polednik
---
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 66 insertions(+), 62 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/40133/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8dabd9b..901537d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -799,40 +799,6 @@
drv['truesize'] = 0
drv['apparentsize'] = 0
-def __legacyDrives(self):
-"""
-Backward compatibility for qa scripts that specify direct paths.
-"""
-legacies = []
-DEVICE_SPEC = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
-for index, linuxName in DEVICE_SPEC:
-path = self.conf.get(linuxName)
-if path:
-legacies.append({'type': hwclass.DISK,
- 'device': 'disk', 'path': path,
- 'iface': 'ide', 'index': index,
- 'truesize': 0})
-return legacies
-
-def __removableDrives(self):
-removables = [{
-'type': hwclass.DISK,
-'device': 'cdrom',
-'iface': vmdevices.storage.DEFAULT_INTERFACE_FOR_ARCH[self.arch],
-'path': self.conf.get('cdrom', ''),
-'index': 2,
-'truesize': 0}]
-floppyPath = self.conf.get('floppy')
-if floppyPath:
-removables.append({
-'type': hwclass.DISK,
-'device': 'floppy',
-'path': floppyPath,
-'iface': 'fdc',
-'index': 0,
-'truesize': 0})
-return removables
-
def buildConfDevices(self):
"""
Return the "devices" section of this Vm's conf.
@@ -851,7 +817,9 @@
devConf = utils.picklecopy(self.conf['devices'])
except KeyError:
# (very) old Engines do not send device configuration
-devices[hwclass.DISK] = self.getConfDrives()
+devices[hwclass.DISK] = \
+vmdevices.storage.mapping_from_legacy_conf(self.conf,
+ self.arch)
devices[hwclass.NIC] = self.getConfNetworkInterfaces()
devices[hwclass.SOUND] = self.getConfSound()
devices[hwclass.VIDEO] = self.getConfVideo()
@@ -1007,33 +975,6 @@
'nicModel': model, 'network': bridge,
'device': 'bridge'})
return nics
-
-def getConfDrives(self):
-"""
-Normalize drives provided by conf.
-"""
-# FIXME
-# Will be better to change the self.conf but this implies an API change
-# Remove this when the API parameters will be consistent.
-confDrives = self.conf.get('drives', [])
-if not confDrives:
-confDrives.extend(self.__legacyDrives())
-confDrives.extend(self.__removableDrives())
-
-for drv in confDrives:
-drv['type'] = hwclass.DISK
-drv['format'] = drv.get('format') or 'raw'
-drv['propagateErrors'] = drv.get('propagateErrors') or 'off'
-drv['readonly'] = False
-drv['shared'] = False
-# FIXME: For BC we have now two identical keys: iface = if
-# Till the day that conf will not returned as a status anymore.
-drv['iface'] = drv.get('iface') or \
-drv.get(
-'if',
-vmdevices.storage.DEFAULT_INTERFACE_FOR_ARCH[self.arch])
-
-return confDrives
def updateDriveIndex(self, drv):
if not drv['iface'] in self._usedIndices:
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index 19531d8..1b91991 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -27,6 +27,7 @@
from .. import vmxml
from .core import Base
+from . import hwclass
DEFAULT_INTERFACE_FOR_ARCH = {caps.Architecture.X86_64: 'ide',
caps.Architecture.PPC64: 'scsi',
@@ -45,6 +46,68 @@
return (cls.NONE, cls.EXCLUSIVE, cls.SHARED, cls.TRANSIENT)
+def mapping_from_legacy_conf(conf, arch):
+"""
+Returns a list of drive specification dictionaries from legacy vm.conf
+"""
+conf_drives = conf.get('drives', [])
+if not conf_drives:
+conf_drives.extend(__mapping_from_legacy_direct_paths(conf))
+conf_d
