Re: [vpp-dev] cmake is on

[Kingwel Xie]

Many thx!

From: vpp-dev@lists.fd.io  On Behalf Of Damjan Marion via 
Lists.Fd.Io
Sent: Friday, September 07, 2018 4:30 PM
To: Damjan Marion 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] cmake is on


I just did it:

https://gerrit.fd.io/r/#/c/14711/


--
Damjan


On 7 Sep 2018, at 09:25, Damjan Marion via Lists.Fd.Io 
mailto:dmarion=me@lists.fd.io>> wrote:


Dear Kingwei,

That should be easy to fix. Can you just remove it and submit patch, so i can 
merge it?

Thanks,

--
Damjan


On 7 Sep 2018, at 02:39, Kingwel Xie 
mailto:kingwel@ericsson.com>> wrote:

Hi Damijan,

Thanks for the great job done. It is now much faster.

We noticed a difference between using cmake and automake in the latest code:

Vppinfra/qsort.c is included in vppinfra/CMakefile.txt but not in vppinfra.am, 
which creates a situation that cmake image would be linked to the qsort.c but 
automake linked to glibc.

The reason why we noticed is there is a buffer overrun bug in qsort.c that 
causes cli crashed occasionally.

Please comment how to fix. Personally I’d like to remove qsort.c, like before.

Regards,
Kingwel

From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan Marion 
via Lists.Fd.Io
Sent: Sunday, September 02, 2018 8:48 PM
To: vpp-dev mailto:vpp-dev@lists.fd.io>>
Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>
Subject: [vpp-dev] cmake is on


Dear all,

We just switched from autotools to cmake and retired all autotools related 
files in src/.

All verify jobs are ok, and we also tried it on 3 different x86 and 2 different 
ARM Aarch64 machines.

Due to blast radius, i will not be surprised that some small issues pop out, 
but i don't expect anything hard to fix.

Let us know if you hit something...

PS As a part of this change, CentOS 7 build are now using devtoolset-7, so they 
are compiled with gcc-7, which also means images have support for Skylake 
Servers (AVX512).

--
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10420): https://lists.fd.io/g/vpp-dev/message/10420
Mute This Topic: https://lists.fd.io/mt/25155374/675642
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[dmar...@me.com<mailto:dmar...@me.com>]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10421): https://lists.fd.io/g/vpp-dev/message/10421
Mute This Topic: https://lists.fd.io/mt/25155374/675642
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[dmar...@me.com<mailto:dmar...@me.com>]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10449): https://lists.fd.io/g/vpp-dev/message/10449
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[John Lo (loj) via Lists.Fd.Io]

Since qsort.c from vppinfra has the buffer overflow issue, shall we delete this 
file to avoid causing more confusion in the future? -John

From: vpp-dev@lists.fd.io  On Behalf Of Damjan Marion via 
Lists.Fd.Io
Sent: Friday, September 07, 2018 4:30 AM
To: Damjan Marion 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] cmake is on


I just did it:

https://gerrit.fd.io/r/#/c/14711/


--
Damjan


On 7 Sep 2018, at 09:25, Damjan Marion via Lists.Fd.Io 
mailto:dmarion=me@lists.fd.io>> wrote:


Dear Kingwei,

That should be easy to fix. Can you just remove it and submit patch, so i can 
merge it?

Thanks,

--
Damjan


On 7 Sep 2018, at 02:39, Kingwel Xie 
mailto:kingwel@ericsson.com>> wrote:

Hi Damijan,

Thanks for the great job done. It is now much faster.

We noticed a difference between using cmake and automake in the latest code:

Vppinfra/qsort.c is included in vppinfra/CMakefile.txt but not in vppinfra.am, 
which creates a situation that cmake image would be linked to the qsort.c but 
automake linked to glibc.

The reason why we noticed is there is a buffer overrun bug in qsort.c that 
causes cli crashed occasionally.

Please comment how to fix. Personally I’d like to remove qsort.c, like before.

Regards,
Kingwel

From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan Marion 
via Lists.Fd.Io
Sent: Sunday, September 02, 2018 8:48 PM
To: vpp-dev mailto:vpp-dev@lists.fd.io>>
Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>
Subject: [vpp-dev] cmake is on


Dear all,

We just switched from autotools to cmake and retired all autotools related 
files in src/.

All verify jobs are ok, and we also tried it on 3 different x86 and 2 different 
ARM Aarch64 machines.

Due to blast radius, i will not be surprised that some small issues pop out, 
but i don't expect anything hard to fix.

Let us know if you hit something...

PS As a part of this change, CentOS 7 build are now using devtoolset-7, so they 
are compiled with gcc-7, which also means images have support for Skylake 
Servers (AVX512).

--
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10420): https://lists.fd.io/g/vpp-dev/message/10420
Mute This Topic: https://lists.fd.io/mt/25155374/675642
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[dmar...@me.com<mailto:dmar...@me.com>]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10421): https://lists.fd.io/g/vpp-dev/message/10421
Mute This Topic: https://lists.fd.io/mt/25155374/675642
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[dmar...@me.com<mailto:dmar...@me.com>]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10433): https://lists.fd.io/g/vpp-dev/message/10433
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Marco Varlese]

Please, take a look at my patch just pushed...https://gerrit.fd.io/r/#/c/14716/
On Fri, 2018-09-07 at 10:44 +0200, Damjan Marion wrote:
> Folks,
> I'm going to revert this change, as it breaks compilation on non-cavium
> systems.
> That patch wrongly changes default cacheline size for all AArch64 platforms to
> 128 bytes...
> 
> -- 
> Damjan
> 
> 
> 
> > On 6 Sep 2018, at 15:52, Nitin Saxena  wrote:
> > 
> > 
> >   
> > 
> >   
> >   Thanks Marco, Damjan. Adding cpu id fixes the compilationPushed the patch:
> > https://gerrit.fd.io/r/#/c/14701/Thanks,
> > 
> > Nitin
> > 
> > 
> > 
> > 
> > On Thursday 06 September 2018 07:06 PM,
> >   Damjan Marion wrote:
> > 
> > 
> > 
> > >   External Email
> > >   
> > > 
> > > 
> > > 
> > > Dear Nitin,
> > > 
> > > 
> > > 
> > > Yes, it is missing.  I took care only for platforms I have
> > >   access to...
> > > 
> > >   
> > > 
> > >   — 
> > > Damjan
> > >   
> > >   
> > > 
> > > On 6 Sep 2018, at 14:04, Nitin Saxena  > > >
> > > wrote:
> > > 
> > > 
> > > 
> > >   
> > >   
> > > > Hi Damjan,cmake is making Cavium's OCTEONTx build failure.
> > > > Following is the failure
> > > > log
> > > > 
> > > >   In function ‘dpdk_init’:
> > > > 
> > > > /home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3:
> > > > error: static assertion failed: "DPDK RTE CACHE LINE
> > > > SIZE does not match with
> > > > 1< > > > 
> > > >STATIC_ASSERT (RTE_CACHE_LINE_SIZE == 1 <<
> > > > CLIB_LOG2_CACHE_LINE_BYTES,=
> > > > ==I am failing to see translation of
> > > > Autoconf changes
> > > > from commit id: 473f46135c3fd77dad5614215cc279b1164e9a74
> > > > to CMake.Thanks,Nitin
> > > > 
> > > >   
> > > >   On Sunday 02 September 2018
> > > > 06:18 PM, Damjan Marion via Lists.Fd.Io wrote:
> > > > 
> > > >   
> > > >   
> > > > > External Email
> > > > > 
> > > > >   
> > > > > 
> > > > >   
> > > > >   Dear all,
> > > > >   
> > > > > 
> > > > >   
> > > > >   We just switched from autotools to cmake
> > > > > and retired all autotools related files in src/.
> > > > >   
> > > > > 
> > > > >   
> > > > >   All verify jobs are ok, and we also
> > > > > tried it on 3 different x86 and 2 different ARM
> > > > > Aarch64 machines.
> > > > >   
> > > > > 
> > > > >   
> > > > >   Due to blast radius, i will not be
> > > > > surprised that some small issues pop out, but i
> > > > > don't expect anything hard to fix.
> > > > >   
> > > > > 
> > > > >   
> > > > >   Let us know if you hit something...
> > > > >   
> > > > > 
> > > > >   
> > > > >   PS As a part of this change, CentOS 7
> > > > > build are now using devtoolset-7, so they are
> > > > > compiled with gcc-7, which also means images have
> > > > > support for Skylake Servers (AVX512).
> > > > >   
> > > > > 
> > > > > 
> > > > >   
> > > > > -- 
> > > > > 
> > > > > Damjan
> > > > > 
> > > > > 
> > > > > 
> > > > >   
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages
> > > > > sent to this group.
> > > > > View/Reply Online (#10337): 
> > > > > https://lists.fd.io/g/vpp-dev/message/10337Mute This Topic: 
> > > > > https://lists.fd.io/mt/25155374/675748Group Owner: vpp-
> > > > > dev+ow...@lists.fd.ioUnsubscribe: https://lists.fd.io/g/vpp-dev/unsubb
> > > > >   [nsax...@caviumnetworks.com]-=-=-=-=-=-=-=-=-=-=-=-
> > > > > 
> > > > >   
> > > > 
> > > >   
> > > > 
> > > > 
> > > >   
> > > 
> > >   
> > > > -=-=-=-=-=-=-=-=-=-=-=-
> > > > 
> > > >   Links: You receive all messages sent to this group.
> > > > 
> > > >   
> > > > 
> > > >   View/Reply Online (#10407): 
> > > >   

Re: [vpp-dev] cmake is on

[Damjan Marion via Lists.Fd.Io]

Folks,

I'm going to revert this change, as it breaks compilation on non-cavium systems.

That patch wrongly changes default cacheline size for all AArch64 platforms to 
128 bytes...

-- 
Damjan

> On 6 Sep 2018, at 15:52, Nitin Saxena  wrote:
> 
> Thanks Marco, Damjan. Adding cpu id fixes the compilation
> 
> Pushed the patch: https://gerrit.fd.io/r/#/c/14701/ 
> 
> Thanks,
> Nitin
> 
> On Thursday 06 September 2018 07:06 PM, Damjan Marion wrote:
>> External Email
>> 
>> 
>> Dear Nitin,
>> 
>> Yes, it is missing.  I took care only for platforms I have access to...
>> 
>> — 
>> Damjan
>> 
>> On 6 Sep 2018, at 14:04, Nitin Saxena > > wrote:
>> 
>>> Hi Damjan,
>>> 
>>> cmake is making Cavium's OCTEONTx build failure. Following is the failure 
>>> log
>>> 
>>> 
>>> In function ‘dpdk_init’:
>>> /home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3: error: static 
>>> assertion failed: "DPDK RTE CACHE LINE SIZE does not match with 
>>> 1<>>STATIC_ASSERT (RTE_CACHE_LINE_SIZE == 1 << CLIB_LOG2_CACHE_LINE_BYTES,
>>> 
>>> ===
>>> 
>>> I am failing to see translation of Autoconf changes from commit id: 
>>> 473f46135c3fd77dad5614215cc279b1164e9a74 to CMake.
>>> 
>>> Thanks,
>>> 
>>> Nitin
>>> On Sunday 02 September 2018 06:18 PM, Damjan Marion via Lists.Fd.Io wrote:
 External Email
 
 
 Dear all,
 
 We just switched from autotools to cmake and retired all autotools related 
 files in src/.
 
 All verify jobs are ok, and we also tried it on 3 different x86 and 2 
 different ARM Aarch64 machines.
 
 Due to blast radius, i will not be surprised that some small issues pop 
 out, but i don't expect anything hard to fix.
 
 Let us know if you hit something...
 
 PS As a part of this change, CentOS 7 build are now using devtoolset-7, so 
 they are compiled with gcc-7, which also means images have support for 
 Skylake Servers (AVX512).
 
 -- 
 Damjan
 
 
 
 -=-=-=-=-=-=-=-=-=-=-=-
 Links: You receive all messages sent to this group.
 
 View/Reply Online (#10337): https://lists.fd.io/g/vpp-dev/message/10337 
 
 Mute This Topic: https://lists.fd.io/mt/25155374/675748 
 
 Group Owner: vpp-dev+ow...@lists.fd.io 
 Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub 
   [nsax...@caviumnetworks.com 
 ]
 -=-=-=-=-=-=-=-=-=-=-=-
>>> 
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> 
>>> View/Reply Online (#10407): https://lists.fd.io/g/vpp-dev/message/10407 
>>> 
>>> Mute This Topic: https://lists.fd.io/mt/25155374/675642 
>>> 
>>> Group Owner: vpp-dev+ow...@lists.fd.io 
>>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub 
>>>   [dmar...@me.com 
>>> ]
>>> -=-=-=-=-=-=-=-=-=-=-=-
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10424): https://lists.fd.io/g/vpp-dev/message/10424
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Damjan Marion via Lists.Fd.Io]

I just did it:

https://gerrit.fd.io/r/#/c/14711/


-- 
Damjan

> On 7 Sep 2018, at 09:25, Damjan Marion via Lists.Fd.Io 
>  wrote:
> 
> 
> Dear Kingwei,
> 
> That should be easy to fix. Can you just remove it and submit patch, so i can 
> merge it?
> 
> Thanks,
> 
> -- 
> Damjan
> 
>> On 7 Sep 2018, at 02:39, Kingwel Xie > <mailto:kingwel@ericsson.com>> wrote:
>> 
>> Hi Damijan,
>>  
>> Thanks for the great job done. It is now much faster.
>>  
>> We noticed a difference between using cmake and automake in the latest code:
>>  
>> Vppinfra/qsort.c is included in vppinfra/CMakefile.txt but not in 
>> vppinfra.am, which creates a situation that cmake image would be linked to 
>> the qsort.c but automake linked to glibc.
>>  
>> The reason why we noticed is there is a buffer overrun bug in qsort.c that 
>> causes cli crashed occasionally.
>>  
>> Please comment how to fix. Personally I’d like to remove qsort.c, like 
>> before.
>>  
>> Regards,
>> Kingwel 
>>  
>> From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > <mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan Marion via Lists.Fd.Io
>> Sent: Sunday, September 02, 2018 8:48 PM
>> To: vpp-dev mailto:vpp-dev@lists.fd.io>>
>> Cc: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io>
>> Subject: [vpp-dev] cmake is on
>>  
>>  
>> Dear all,
>>  
>> We just switched from autotools to cmake and retired all autotools related 
>> files in src/.
>>  
>> All verify jobs are ok, and we also tried it on 3 different x86 and 2 
>> different ARM Aarch64 machines.
>>  
>> Due to blast radius, i will not be surprised that some small issues pop out, 
>> but i don't expect anything hard to fix.
>>  
>> Let us know if you hit something...
>>  
>> PS As a part of this change, CentOS 7 build are now using devtoolset-7, so 
>> they are compiled with gcc-7, which also means images have support for 
>> Skylake Servers (AVX512).
>>  
>> -- 
>> Damjan
>>  
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> 
>> View/Reply Online (#10420): https://lists.fd.io/g/vpp-dev/message/10420 
>> <https://lists.fd.io/g/vpp-dev/message/10420>
>> Mute This Topic: https://lists.fd.io/mt/25155374/675642 
>> <https://lists.fd.io/mt/25155374/675642>
>> Group Owner: vpp-dev+ow...@lists.fd.io <mailto:vpp-dev+ow...@lists.fd.io>
>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub 
>> <https://lists.fd.io/g/vpp-dev/unsub>  [dmar...@me.com 
>> <mailto:dmar...@me.com>]
>> -=-=-=-=-=-=-=-=-=-=-=-
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#10421): https://lists.fd.io/g/vpp-dev/message/10421
> Mute This Topic: https://lists.fd.io/mt/25155374/675642
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10423): https://lists.fd.io/g/vpp-dev/message/10423
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Damjan Marion via Lists.Fd.Io]

Dear Kingwei,

That should be easy to fix. Can you just remove it and submit patch, so i can 
merge it?

Thanks,

-- 
Damjan

> On 7 Sep 2018, at 02:39, Kingwel Xie  wrote:
> 
> Hi Damijan,
>  
> Thanks for the great job done. It is now much faster.
>  
> We noticed a difference between using cmake and automake in the latest code:
>  
> Vppinfra/qsort.c is included in vppinfra/CMakefile.txt but not in 
> vppinfra.am, which creates a situation that cmake image would be linked to 
> the qsort.c but automake linked to glibc.
>  
> The reason why we noticed is there is a buffer overrun bug in qsort.c that 
> causes cli crashed occasionally.
>  
> Please comment how to fix. Personally I’d like to remove qsort.c, like before.
>  
> Regards,
> Kingwel 
>  
> From: vpp-dev@lists.fd.io  On Behalf Of Damjan Marion 
> via Lists.Fd.Io
> Sent: Sunday, September 02, 2018 8:48 PM
> To: vpp-dev 
> Cc: vpp-dev@lists.fd.io
> Subject: [vpp-dev] cmake is on
>  
>  
> Dear all,
>  
> We just switched from autotools to cmake and retired all autotools related 
> files in src/.
>  
> All verify jobs are ok, and we also tried it on 3 different x86 and 2 
> different ARM Aarch64 machines.
>  
> Due to blast radius, i will not be surprised that some small issues pop out, 
> but i don't expect anything hard to fix.
>  
> Let us know if you hit something...
>  
> PS As a part of this change, CentOS 7 build are now using devtoolset-7, so 
> they are compiled with gcc-7, which also means images have support for 
> Skylake Servers (AVX512).
>  
> -- 
> Damjan
>  
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#10420): https://lists.fd.io/g/vpp-dev/message/10420 
> <https://lists.fd.io/g/vpp-dev/message/10420>
> Mute This Topic: https://lists.fd.io/mt/25155374/675642 
> <https://lists.fd.io/mt/25155374/675642>
> Group Owner: vpp-dev+ow...@lists.fd.io <mailto:vpp-dev+ow...@lists.fd.io>
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub 
> <https://lists.fd.io/g/vpp-dev/unsub>  [dmar...@me.com 
> <mailto:dmar...@me.com>]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10421): https://lists.fd.io/g/vpp-dev/message/10421
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Kingwel Xie]

Hi Damijan,

Thanks for the great job done. It is now much faster.

We noticed a difference between using cmake and automake in the latest code:

Vppinfra/qsort.c is included in vppinfra/CMakefile.txt but not in vppinfra.am, 
which creates a situation that cmake image would be linked to the qsort.c but 
automake linked to glibc.

The reason why we noticed is there is a buffer overrun bug in qsort.c that 
causes cli crashed occasionally.

Please comment how to fix. Personally I'd like to remove qsort.c, like before.

Regards,
Kingwel

From: vpp-dev@lists.fd.io  On Behalf Of Damjan Marion via 
Lists.Fd.Io
Sent: Sunday, September 02, 2018 8:48 PM
To: vpp-dev 
Cc: vpp-dev@lists.fd.io
Subject: [vpp-dev] cmake is on


Dear all,

We just switched from autotools to cmake and retired all autotools related 
files in src/.

All verify jobs are ok, and we also tried it on 3 different x86 and 2 different 
ARM Aarch64 machines.

Due to blast radius, i will not be surprised that some small issues pop out, 
but i don't expect anything hard to fix.

Let us know if you hit something...

PS As a part of this change, CentOS 7 build are now using devtoolset-7, so they 
are compiled with gcc-7, which also means images have support for Skylake 
Servers (AVX512).

--
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10420): https://lists.fd.io/g/vpp-dev/message/10420
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Nitin Saxena]

Thanks Marco, Damjan. Adding cpu id fixes the compilation

Pushed the patch: https://gerrit.fd.io/r/#/c/14701/

Thanks,

Nitin


On Thursday 06 September 2018 07:06 PM, Damjan Marion wrote:


External Email


Dear Nitin,

Yes, it is missing.  I took care only for platforms I have access to...

—
Damjan

On 6 Sep 2018, at 14:04, Nitin Saxena > wrote:



Hi Damjan,

cmake is making Cavium's OCTEONTx build failure. Following is the 
failure log




In function ‘dpdk_init’:
/home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3: error: 
static assertion failed: "DPDK RTE CACHE LINE SIZE does not match 
with 1<
   STATIC_ASSERT (RTE_CACHE_LINE_SIZE == 1 << CLIB_LOG2_CACHE_LINE_BYTES,

===

I am failing to see translation of Autoconf changes from commit id: 
473f46135c3fd77dad5614215cc279b1164e9a74 to CMake.


Thanks,

Nitin

On Sunday 02 September 2018 06:18 PM, Damjan Marion via Lists.Fd.Io 
wrote:


External Email


Dear all,

We just switched from autotools to cmake and retired all autotools 
related files in src/.


All verify jobs are ok, and we also tried it on 3 different x86 and 
2 different ARM Aarch64 machines.


Due to blast radius, i will not be surprised that some small issues 
pop out, but i don't expect anything hard to fix.


Let us know if you hit something...

PS As a part of this change, CentOS 7 build are now using 
devtoolset-7, so they are compiled with gcc-7, which also means 
images have support for Skylake Servers (AVX512).


--
Damjan



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10337):https://lists.fd.io/g/vpp-dev/message/10337
Mute This Topic:https://lists.fd.io/mt/25155374/675748
Group Owner:vpp-dev+ow...@lists.fd.io
Unsubscribe:https://lists.fd.io/g/vpp-dev/unsub   [nsax...@caviumnetworks.com]
-=-=-=-=-=-=-=-=-=-=-=-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10407): 
https://lists.fd.io/g/vpp-dev/message/10407 


Mute This Topic: https://lists.fd.io/mt/25155374/675642
Group Owner: vpp-dev+ow...@lists.fd.io 
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com 
]

-=-=-=-=-=-=-=-=-=-=-=-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10413): https://lists.fd.io/g/vpp-dev/message/10413
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Damjan Marion via Lists.Fd.Io]

Dear Nitin,

Yes, it is missing.  I took care only for platforms I have access to...

— 
Damjan

> On 6 Sep 2018, at 14:04, Nitin Saxena  wrote:
> 
> Hi Damjan,
> 
> cmake is making Cavium's OCTEONTx build failure. Following is the failure log
> 
> 
> 
> In function ‘dpdk_init’:
> /home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3: error: static 
> assertion failed: "DPDK RTE CACHE LINE SIZE does not match with 
> 1 
> ===
> 
> I am failing to see translation of Autoconf changes from commit id: 
> 473f46135c3fd77dad5614215cc279b1164e9a74 to CMake.
> 
> Thanks,
> 
> Nitin
> 
>> On Sunday 02 September 2018 06:18 PM, Damjan Marion via Lists.Fd.Io wrote:
>> External Email
>> 
>> 
>> Dear all,
>> 
>> We just switched from autotools to cmake and retired all autotools related 
>> files in src/.
>> 
>> All verify jobs are ok, and we also tried it on 3 different x86 and 2 
>> different ARM Aarch64 machines.
>> 
>> Due to blast radius, i will not be surprised that some small issues pop out, 
>> but i don't expect anything hard to fix.
>> 
>> Let us know if you hit something...
>> 
>> PS As a part of this change, CentOS 7 build are now using devtoolset-7, so 
>> they are compiled with gcc-7, which also means images have support for 
>> Skylake Servers (AVX512).
>> 
>> -- 
>> Damjan
>> 
>> 
>> 
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> 
>> View/Reply Online (#10337): https://lists.fd.io/g/vpp-dev/message/10337
>> Mute This Topic: https://lists.fd.io/mt/25155374/675748
>> Group Owner: vpp-dev+ow...@lists.fd.io
>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
>> [nsax...@caviumnetworks.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#10407): https://lists.fd.io/g/vpp-dev/message/10407
> Mute This Topic: https://lists.fd.io/mt/25155374/675642
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10412): https://lists.fd.io/g/vpp-dev/message/10412
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Marco Varlese]

Hi Nitin,
On Thu, 2018-09-06 at 18:34 +0530, Nitin Saxena wrote:
> Hi Damjan,
> 
> cmake is making Cavium's OCTEONTx build failure. Following is the
>   failure log
> 
> 
> 
> 
> 
> In function ‘dpdk_init’:
> 
>   /home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3: error:
>   static assertion failed: "DPDK RTE CACHE LINE SIZE does not match
>   with 1< 
>  STATIC_ASSERT (RTE_CACHE_LINE_SIZE == 1 <<
>   CLIB_LOG2_CACHE_LINE_BYTES,

I believe there's a missing CPU_TYPE detection in here "src/cmake/cpu.cmake"I
don't have an OCTEONTX machine to check so if you can provide them (or submit a
patch with those) I think that could fix it...
> ===
> 
> I am failing to see translation of Autoconf changes from commit
>   id: 473f46135c3fd77dad5614215cc279b1164e9a74 to CMake.
> 
> Thanks,
> 
> Nitin
> 
> 
> 
> On Sunday 02 September 2018 06:18 PM,
>   Damjan Marion via Lists.Fd.Io wrote:
> 
> 
> 
> 
> >   
> >   External Email
> >   
> > 
> > 
> > 
> > Dear all,
> > 
> > 
> > 
> > We just switched from autotools to cmake and
> >   retired all autotools related files in src/.
> > 
> > 
> > 
> > All verify jobs are ok, and we also tried it on 3
> >   different x86 and 2 different ARM Aarch64 machines.
> > 
> > 
> > 
> > Due to blast radius, i will not be surprised that
> >   some small issues pop out, but i don't expect anything hard to
> >   fix.
> > 
> > 
> > 
> > Let us know if you hit something...
> > 
> > 
> > 
> > PS As a part of this change, CentOS 7 build are
> >   now using devtoolset-7, so they are compiled with gcc-7, which
> >   also means images have support for Skylake Servers (AVX512).
> > 
> > 
> >   
> > 
> >   -- 
> > 
> >   Damjan
> >   
> >   
> > 
> > 
> >   
> >   
> > 
> >   
> >   
> > 
> >   -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this
> > group.
> > View/Reply Online (#10337): https://lists.fd.io/g/vpp-dev/message/10337Mute
> > This Topic: https://lists.fd.io/mt/25155374/675748Group Owner: vpp-
> > dev+ow...@lists.fd.ioUnsubscribe: https://lists.fd.io/g/vpp-dev/unsubb  [nsa
> > x...@caviumnetworks.com]-=-=-=-=-=-=-=-=-=-=-=-
> > 
> > 
> 
> 
> 
>   
> 
> -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
> View/Reply Online (#10407): https://lists.fd.io/g/vpp-dev/message/10407Mute
> This Topic: https://lists.fd.io/mt/25155374/675056Group Owner: vpp-
> dev+ow...@lists.fd.ioUnsubscribe: https://lists.fd.io/g/vpp-dev/unsubb  [mvarl
> e...@suse.de]-=-=-=-=-=-=-=-=-=-=-=-
-- 
Marco V


SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10408): https://lists.fd.io/g/vpp-dev/message/10408
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Nitin Saxena]

Hi Damjan,

cmake is making Cavium's OCTEONTx build failure. Following is the 
failure log




In function ‘dpdk_init’:
/home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3: error: static 
assertion failed: "DPDK RTE CACHE LINE SIZE does not match with 
1<
   STATIC_ASSERT (RTE_CACHE_LINE_SIZE == 1 << CLIB_LOG2_CACHE_LINE_BYTES,

===

I am failing to see translation of Autoconf changes from commit id: 
473f46135c3fd77dad5614215cc279b1164e9a74 to CMake.


Thanks,

Nitin

On Sunday 02 September 2018 06:18 PM, Damjan Marion via Lists.Fd.Io wrote:


External Email


Dear all,

We just switched from autotools to cmake and retired all autotools 
related files in src/.


All verify jobs are ok, and we also tried it on 3 different x86 and 2 
different ARM Aarch64 machines.


Due to blast radius, i will not be surprised that some small issues 
pop out, but i don't expect anything hard to fix.


Let us know if you hit something...

PS As a part of this change, CentOS 7 build are now using 
devtoolset-7, so they are compiled with gcc-7, which also means images 
have support for Skylake Servers (AVX512).


--
Damjan



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10337): https://lists.fd.io/g/vpp-dev/message/10337
Mute This Topic: https://lists.fd.io/mt/25155374/675748
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [nsax...@caviumnetworks.com]
-=-=-=-=-=-=-=-=-=-=-=-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10407): https://lists.fd.io/g/vpp-dev/message/10407
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Naoyuki Mori]

Hi Damjan,

I've encountered non install-able rpm package was build after this changes.

$ make pkg-rpm
$ sudo rpm -Uvh vpp-*327_g004869d0*rpm
error: Failed dependencies:
    libsvm.so.18.10()(64bit) is needed by vpp-18.10-rc0~327_g004869d0.x86_64

Reason is built shared lib naming format was changed, that prevent from 
including package specified by spec file.
Before, lib are named like
"lib64/libsvm.so. *0.0.0* "
Now, named as
"lib64/libsvm.so. *18.10* "

Patch below works on my environment but not sure whether it's a right way to 
fix this.
diff --git a/extras/rpm/vpp.spec b/extras/rpm/vpp.spec
index 555e9444..fd708f20 100644
--- a/extras/rpm/vpp.spec
+++ b/extras/rpm/vpp.spec
@@ -192,7 +192,7 @@ install -p -m 644 
%{_mu_build_dir}/../src/vpp/conf/80-vpp.conf %{buildroot}/etc/
 mkdir -p -m755 %{buildroot}%{_libdir}
 mkdir -p -m755 %{buildroot}/etc/bash_completion.d
 mkdir -p -m755 %{buildroot}/usr/share/vpp
-for file in $(find %{_mu_build_dir}/%{_vpp_install_dir}/*/lib* -type f -name 
'*.so.*.*.*' -print )
+for file in $(find %{_mu_build_dir}/%{_vpp_install_dir}/*/lib* -type f -name 
'*.so.*.*' -print )
 do
    install -p -m 755 $file %{buildroot}%{_libdir}
 done

Please advice.

Thanks,
Mori
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10382): https://lists.fd.io/g/vpp-dev/message/10382
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] cmake is on

[Yu, Ping]

Thanks Damjan. If cloning a brandnew repo, the build is ok.

Ping

From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan 
Marion via Lists.Fd.Io
Sent: Wednesday, September 5, 2018 1:13 AM
To: Yu, Ping 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] cmake is on


Dear Ping,

Can you please clean up your workspace (git clean -fdx) and then capture full 
log...

Thanks,

--
Damjan


On 4 Sep 2018, at 15:40, Yu, Ping mailto:ping...@intel.com>> 
wrote:

Hi, Damjan,

My Ubuntu environment is good. But in FC27, I got the following issue in debug 
mode.


-- Build files have been written to: 
/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp_debug-native/vpp
 Building vpp in 
/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp_debug-native/vpp 
[507/1184] Building C object vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o
FAILED: vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o
ccache /usr/lib64/ccache/cc -Dvppinfra_EXPORTS 
-I/home/pyu4/git-home/vpp_master/vpp/src -I. -Iinclude -march=corei7 
-mtune=corei7-avx -g -O0 -DCLIB_DEBUG -DFORTIFY_SOURCE=2 -fstack-protector-all 
-fPIC -Werror -fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o -MF 
vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o.d -o 
vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o   -c 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:42:3: error: 
conflicting types for ‘mheap_trace_t’
} mheap_trace_t;
   ^
In file included from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem.h:49:0,
 from /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/vec.h:42,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/format.h:44,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:16:
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mheap_bootstrap.h:147:3: note: 
previous declaration of ‘mheap_trace_t’ was here
} mheap_trace_t;
   ^
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:59:3: error: 
conflicting types for ‘mheap_trace_main_t’
} mheap_trace_main_t;
   ^~
In file included from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem.h:49:0,
 from /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/vec.h:42,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/format.h:44,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:16:
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mheap_bootstrap.h:161:3: note: 
previous declaration of ‘mheap_trace_main_t’ was here
} mheap_trace_main_t;
   ^~
cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ 
[-Werror]
cc1: all warnings being treated as errors
[620/1184] Building C object vnet/CMakeFiles/vnet.dir/dhcp/dhcp_api.c.o
ninja: build stopped: subcommand failed.
make[1]: *** [Makefile:691: vpp-build] Error 1
make[1]: Leaving directory '/home/pyu4/git-home/vpp_master/vpp/build-root'
make: *** [Makefile:342: build] Error 2


the following issue in release mode.

[781/1184] Linking C executable bin/sock_test_server
FAILED: bin/sock_test_server
: && ccache /usr/lib64/ccache/cc -march=corei7 -mtune=corei7-avx -g -O2 
-DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
vcl/CMakeFiles/sock_test_server.dir/sock_test_server.c.o  -o 
bin/sock_test_server  -Wl
,-rpath,/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp-native/vpp/lib 
lib/libvppcom.so.18.10 lib/libvlibmemoryclient.so.18.10 lib/libvlib.so.18.10 
lib/libsvm.so.18.10 lib/libvppinfra.so.18.10 -lm -ldl -
lrt -lpthread && :
lib/libvppcom.so.18.10: undefined reference to `mheap_put'
lib/libvlibmemoryclient.so.18.10: undefined reference to `mheap_get_aligned'
collect2: error: ld returned 1 exit status
[782/1184] Linking C executable bin/test_vcl_listener_client
FAILED: bin/test_vcl_listener_client
: && ccache /usr/lib64/ccache/cc -march=corei7 -mtune=corei7-avx -g -O2 
-DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
vcl/CMakeFiles/test_vcl_listener_client.dir/test_vcl_listener_client.c.o  -o 
bin/test_
vcl_listener_client  
-Wl,-rpath,/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp-native/vpp/lib
 lib/libvppcom.so.18.10 lib/libvlibmemoryclient.so.18.10 lib/libvlib.so.18.10 
lib/libsvm.so.18.10 lib/libvppinfra.so.18.10 -lm -ldl -lrt -lpthread && :
lib/libvppcom.so.18.10: undefined reference to `mheap_put'
lib/libvlibmemoryclient.so.18.10: undefined reference to `mheap_get_aligned'
collect2: error: ld returned 1 exit status



From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> 
[mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan Marion via Lists.Fd.Io
Sent: Sunday, September 2, 2018 8:48 PM
To: vpp-dev mailto:vpp-dev@lists.fd.io>>
Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>
Subject: [vpp-dev] cmake is 

Re: [vpp-dev] cmake is on

[Damjan Marion via Lists.Fd.Io]

Dear Ping,

Can you please clean up your workspace (git clean -fdx) and then capture full 
log...

Thanks,

-- 
Damjan

> On 4 Sep 2018, at 15:40, Yu, Ping  wrote:
> 
> Hi, Damjan,
>  
> My Ubuntu environment is good. But in FC27, I got the following issue in 
> debug mode.
>  
>  
> -- Build files have been written to: 
> /home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp_debug-native/vpp <>
>  Building vpp in 
> /home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp_debug-native/vpp 
> [507/1184] Building C object vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o
> FAILED: vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o
> ccache /usr/lib64/ccache/cc -Dvppinfra_EXPORTS 
> -I/home/pyu4/git-home/vpp_master/vpp/src -I. -Iinclude -march=corei7 
> -mtune=corei7-avx -g -O0 -DCLIB_DEBUG -DFORTIFY_SOURCE=2 
> -fstack-protector-all -fPIC -Werror -fPIC   -Wno-address-of-packed-member 
> -Wall -MD -MT vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o -MF 
> vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o.d -o 
> vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o   -c 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:42:3: error: 
> conflicting types for ‘mheap_trace_t’
> } mheap_trace_t;
>^
> In file included from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem.h:49:0,
>  from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/vec.h:42,
>  from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/format.h:44,
>  from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:16:
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mheap_bootstrap.h:147:3: 
> note: previous declaration of ‘mheap_trace_t’ was here
> } mheap_trace_t;
>^
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:59:3: error: 
> conflicting types for ‘mheap_trace_main_t’
> } mheap_trace_main_t;
>^~
> In file included from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem.h:49:0,
>  from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/vec.h:42,
>  from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/format.h:44,
>  from 
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:16:
> /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mheap_bootstrap.h:161:3: 
> note: previous declaration of ‘mheap_trace_main_t’ was here
> } mheap_trace_main_t;
>^~
> cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ 
> [-Werror]
> cc1: all warnings being treated as errors
> [620/1184] Building C object vnet/CMakeFiles/vnet.dir/dhcp/dhcp_api.c.o
> ninja: build stopped: subcommand failed.
> make[1]: *** [Makefile:691: vpp-build] Error 1
> make[1]: Leaving directory '/home/pyu4/git-home/vpp_master/vpp/build-root'
> make: *** [Makefile:342: build] Error 2
>  
>  
> the following issue in release mode.
>  
> [781/1184] Linking C executable bin/sock_test_server
> FAILED: bin/sock_test_server
> : && ccache /usr/lib64/ccache/cc -march=corei7 -mtune=corei7-avx -g -O2 
> -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
> vcl/CMakeFiles/sock_test_server.dir/sock_test_server.c.o  -o 
> bin/sock_test_server  -Wl
> ,-rpath,/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp-native/vpp/lib
>  lib/libvppcom.so.18.10 lib/libvlibmemoryclient.so.18.10 lib/libvlib.so.18.10 
> lib/libsvm.so.18.10 lib/libvppinfra.so.18.10 -lm -ldl -
> lrt -lpthread && :
> lib/libvppcom.so.18.10: undefined reference to `mheap_put'
> lib/libvlibmemoryclient.so.18.10: undefined reference to `mheap_get_aligned'
> collect2: error: ld returned 1 exit status
> [782/1184] Linking C executable bin/test_vcl_listener_client
> FAILED: bin/test_vcl_listener_client
> : && ccache /usr/lib64/ccache/cc -march=corei7 -mtune=corei7-avx -g -O2 
> -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
> vcl/CMakeFiles/test_vcl_listener_client.dir/test_vcl_listener_client.c.o  -o 
> bin/test_
> vcl_listener_client  
> -Wl,-rpath,/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp-native/vpp/lib
>  lib/libvppcom.so.18.10 lib/libvlibmemoryclient.so.18.10 lib/libvlib.so.18.10 
> lib/libsvm.so.18.10 lib/libvppinfra.so.18.10 -lm -ldl -lrt -lpthread && :
> lib/libvppcom.so.18.10: undefined reference to `mheap_put'
> lib/libvlibmemoryclient.so.18.10: undefined reference to `mheap_get_aligned'
> collect2: error: ld returned 1 exit status
>  
>  
>  
>  <>From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan 
> Marion via Lists.Fd.Io
> Sent

Re: [vpp-dev] cmake is on

[Yu, Ping]

Hi, Damjan,

My Ubuntu environment is good. But in FC27, I got the following issue in debug 
mode.


-- Build files have been written to: 
/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp_debug-native/vpp
 Building vpp in 
/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp_debug-native/vpp 
[507/1184] Building C object vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o
FAILED: vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o
ccache /usr/lib64/ccache/cc -Dvppinfra_EXPORTS 
-I/home/pyu4/git-home/vpp_master/vpp/src -I. -Iinclude -march=corei7 
-mtune=corei7-avx -g -O0 -DCLIB_DEBUG -DFORTIFY_SOURCE=2 -fstack-protector-all 
-fPIC -Werror -fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o -MF 
vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o.d -o 
vppinfra/CMakeFiles/vppinfra.dir/mem_dlmalloc.c.o   -c 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:42:3: error: 
conflicting types for 'mheap_trace_t'
} mheap_trace_t;
   ^
In file included from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem.h:49:0,
 from /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/vec.h:42,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/format.h:44,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:16:
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mheap_bootstrap.h:147:3: note: 
previous declaration of 'mheap_trace_t' was here
} mheap_trace_t;
   ^
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:59:3: error: 
conflicting types for 'mheap_trace_main_t'
} mheap_trace_main_t;
   ^~
In file included from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem.h:49:0,
 from /home/pyu4/git-home/vpp_master/vpp/src/vppinfra/vec.h:42,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/format.h:44,
 from 
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mem_dlmalloc.c:16:
/home/pyu4/git-home/vpp_master/vpp/src/vppinfra/mheap_bootstrap.h:161:3: note: 
previous declaration of 'mheap_trace_main_t' was here
} mheap_trace_main_t;
   ^~
cc1: error: unrecognized command line option '-Wno-address-of-packed-member' 
[-Werror]
cc1: all warnings being treated as errors
[620/1184] Building C object vnet/CMakeFiles/vnet.dir/dhcp/dhcp_api.c.o
ninja: build stopped: subcommand failed.
make[1]: *** [Makefile:691: vpp-build] Error 1
make[1]: Leaving directory '/home/pyu4/git-home/vpp_master/vpp/build-root'
make: *** [Makefile:342: build] Error 2


the following issue in release mode.

[781/1184] Linking C executable bin/sock_test_server
FAILED: bin/sock_test_server
: && ccache /usr/lib64/ccache/cc -march=corei7 -mtune=corei7-avx -g -O2 
-DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
vcl/CMakeFiles/sock_test_server.dir/sock_test_server.c.o  -o 
bin/sock_test_server  -Wl
,-rpath,/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp-native/vpp/lib 
lib/libvppcom.so.18.10 lib/libvlibmemoryclient.so.18.10 lib/libvlib.so.18.10 
lib/libsvm.so.18.10 lib/libvppinfra.so.18.10 -lm -ldl -
lrt -lpthread && :
lib/libvppcom.so.18.10: undefined reference to `mheap_put'
lib/libvlibmemoryclient.so.18.10: undefined reference to `mheap_get_aligned'
collect2: error: ld returned 1 exit status
[782/1184] Linking C executable bin/test_vcl_listener_client
FAILED: bin/test_vcl_listener_client
: && ccache /usr/lib64/ccache/cc -march=corei7 -mtune=corei7-avx -g -O2 
-DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
vcl/CMakeFiles/test_vcl_listener_client.dir/test_vcl_listener_client.c.o  -o 
bin/test_
vcl_listener_client  
-Wl,-rpath,/home/pyu4/git-home/vpp_master/vpp/build-root/build-vpp-native/vpp/lib
 lib/libvppcom.so.18.10 lib/libvlibmemoryclient.so.18.10 lib/libvlib.so.18.10 
lib/libsvm.so.18.10 lib/libvppinfra.so.18.10 -lm -ldl -lrt -lpthread && :
lib/libvppcom.so.18.10: undefined reference to `mheap_put'
lib/libvlibmemoryclient.so.18.10: undefined reference to `mheap_get_aligned'
collect2: error: ld returned 1 exit status



From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan 
Marion via Lists.Fd.Io
Sent: Sunday, September 2, 2018 8:48 PM
To: vpp-dev 
Cc: vpp-dev@lists.fd.io
Subject: [vpp-dev] cmake is on


Dear all,

We just switched from autotools to cmake and retired all autotools related 
files in src/.

All verify jobs are ok, and we also tried it on 3 different x86 and 2 different 
ARM Aarch64 machines.

Due to blast radius, i will not be surprised that some small issues pop out, 
but i don't expect anything hard to fix.

Let us know if you hit something...

PS As a part of this change, CentOS 7 build are now using devtoolset-7, so they 
are compiled with gcc-7, which also means images have support for Skylake 
Servers (AVX512).

--
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Link

[vpp-dev] cmake is on

[Damjan Marion via Lists.Fd.Io]

Dear all,

We just switched from autotools to cmake and retired all autotools related 
files in src/.

All verify jobs are ok, and we also tried it on 3 different x86 and 2 different 
ARM Aarch64 machines.

Due to blast radius, i will not be surprised that some small issues pop out, 
but i don't expect anything hard to fix.

Let us know if you hit something...

PS As a part of this change, CentOS 7 build are now using devtoolset-7, so they 
are compiled with gcc-7, which also means images have support for Skylake 
Servers (AVX512).

-- 
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10337): https://lists.fd.io/g/vpp-dev/message/10337
Mute This Topic: https://lists.fd.io/mt/25155374/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] CMake

[Klement Sekera via Lists.Fd.Io]

Yes, this causes test-debug target to take the old way (not cmake).
This, though, seems a bit counter-intuitive. Shouldn't setting the
value to "no" cause the build process to not use cmake?

On Mon, 2018-08-20 at 12:15 +0200, Damjan Marion wrote:
> > 
> > On 20 Aug 2018, at 11:55, Klement Sekera  wrote:
> > 
> > Hi Damjan,
> > 
> > it seems that the test-debug target is broken with the patch. The
> > build
> > process triggered by test-debug target jumps on the cmake train,
> > but
> > that train doesn't bring in the APIGEN and other stuff (e.g.
> > libvppapiclient.so).
> Does this help?
> diff --git a/Makefile b/Makefile
> index 09a31083..f9fd95ff 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -21,7 +21,7 @@ STARTUP_DIR?=$(PWD)
>  MACHINE=$(shell uname -m)
>  SUDO?=sudo
> 
> -ifeq ($(findstring $(MAKECMDGOALS),verify pkg-deb pkg-rpm test),)
> +ifeq ($(findstring $(MAKECMDGOALS),verify pkg-deb pkg-rpm test test-
> debug),)
>  export vpp_uses_cmake?=yes
>  endif
> 
> > 
> > 
> > I don't see vpp-api mentioned in src/CMakeLists.txt. Should it be
> > mentioned?
> It waits for volunteer to take care for vpp-api :)
> 
> > 
> > 
> > Thanks,
> > Klement
> > 
> > On Sat, 2018-08-18 at 12:38 +0200, Damjan Marion via Lists.Fd.Io
> > wrote:
> > > 
> > > Dear all,
> > > 
> > > Yesterday we merged a patch which introduces CMake build system
> > > in
> > > VPP.
> > > 
> > > https://git.fd.io/vpp/commit/?id=612dd6a9
> > > 
> > > It is initial patch, and additional work is needed, but in
> > > general it
> > > manages to compile VPP binaries significantly faster 
> > > than what we have today with autotools.
> > > 
> > > In addition it brings following benefits which we can leverage in
> > > the
> > > future:
> > >  - use of CPack to generate deb/rpms vs. hardcoded scripts we
> > > have
> > > today
> > >  - much simpler and smaller build definitions specially for
> > > plugins
> > >  - support for different build types (Debug, Release, Release
> > > with
> > > symbols, Coverage, ...)
> > >  - support for external components (i.e. we can likely build dpdk
> > > and
> > > his dependencies)
> > > 
> > > Autotools is still default way to run verify jobs and build
> > > images,
> > > but people can give CMake a try in few ways:
> > > 
> > > Step 0: "apt-get install cmake ninja-build"
> > > 
> > > - "make {build,rebuild,build-release,rebuild-release}" are
> > > already
> > > using cmake as default, old behaviour can be restored by saying
> > > "make
> > > vpp_uses_cmake=no ..."
> > > 
> > > - make -C build-root vpp_uses_cmake=yes PLATFORM=vpp
> > > TAG={vpp|vpp_debug} 
> > > 
> > > - uncommenting "vpp_uses_cmake=yes" in build-
> > > data/platforms/vpp.mk
> > > 
> > > - without ebuild:
> > > mkdir _build
> > > cd _build
> > > cmake [-G Ninja] /path/to/vpp/src
> > > -DCMAKE_BUILD_TYPE={Release|Debug}
> > > (optionally "ccmake ." to change parameters)
> > > {ninja|make}
> > > 
> > > ./bin/vpp unix interactive
> > > 
> > > Building packages (incomplete / work in progress):
> > > $ ninja package
> > > [0/1] Run CPack packaging tool...
> > > CPack: Create package using DEB
> > > CPack: Install projects
> > > CPack: - Install project: vpp
> > > CPack: -   Install component: dev
> > > CPack: -   Install component: plugins
> > > CPack: -   Install component: vpp
> > > CPack: Create package
> > > CPack: - package: /home/damarion/tmp/_build/vpp-dev.deb
> > > generated.
> > > CPack: - package: /home/damarion/tmp/_build/vpp-plugins.deb
> > > generated.
> > > CPack: - package: /home/damarion/tmp/_build/vpp.deb generated.
> > > 
> > > Feedback, issue reports and contributions to get CMake be a full
> > > replacement for autotools are welcome.
> > > 
> > > Thanks,
> > > 
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > 
> > > View/Reply Online (#10209): https://lists.fd.io/g/vpp-dev/message
> > > /102
> > > 09
> > > Mute This Topic: https://lists.fd.io/mt/24665874/675704
> > > Group Owner: vpp-dev+ow...@lists.fd.io
> > > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [ksekera@cisco.
> > > com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10218): https://lists.fd.io/g/vpp-dev/message/10218
Mute This Topic: https://lists.fd.io/mt/24665874/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] CMake

[Damjan Marion via Lists.Fd.Io]

> On 20 Aug 2018, at 11:55, Klement Sekera  wrote:
> 
> Hi Damjan,
> 
> it seems that the test-debug target is broken with the patch. The build
> process triggered by test-debug target jumps on the cmake train, but
> that train doesn't bring in the APIGEN and other stuff (e.g.
> libvppapiclient.so).

Does this help?
diff --git a/Makefile b/Makefile
index 09a31083..f9fd95ff 100644
--- a/Makefile
+++ b/Makefile
@@ -21,7 +21,7 @@ STARTUP_DIR?=$(PWD)
 MACHINE=$(shell uname -m)
 SUDO?=sudo

-ifeq ($(findstring $(MAKECMDGOALS),verify pkg-deb pkg-rpm test),)
+ifeq ($(findstring $(MAKECMDGOALS),verify pkg-deb pkg-rpm test test-debug),)
 export vpp_uses_cmake?=yes
 endif

> 
> I don't see vpp-api mentioned in src/CMakeLists.txt. Should it be
> mentioned?

It waits for volunteer to take care for vpp-api :)

> 
> Thanks,
> Klement
> 
> On Sat, 2018-08-18 at 12:38 +0200, Damjan Marion via Lists.Fd.Io wrote:
>> Dear all,
>> 
>> Yesterday we merged a patch which introduces CMake build system in
>> VPP.
>> 
>> https://git.fd.io/vpp/commit/?id=612dd6a9
>> 
>> It is initial patch, and additional work is needed, but in general it
>> manages to compile VPP binaries significantly faster 
>> than what we have today with autotools.
>> 
>> In addition it brings following benefits which we can leverage in the
>> future:
>>  - use of CPack to generate deb/rpms vs. hardcoded scripts we have
>> today
>>  - much simpler and smaller build definitions specially for plugins
>>  - support for different build types (Debug, Release, Release with
>> symbols, Coverage, ...)
>>  - support for external components (i.e. we can likely build dpdk and
>> his dependencies)
>> 
>> Autotools is still default way to run verify jobs and build images,
>> but people can give CMake a try in few ways:
>> 
>> Step 0: "apt-get install cmake ninja-build"
>> 
>> - "make {build,rebuild,build-release,rebuild-release}" are already
>> using cmake as default, old behaviour can be restored by saying "make
>> vpp_uses_cmake=no ..."
>> 
>> - make -C build-root vpp_uses_cmake=yes PLATFORM=vpp
>> TAG={vpp|vpp_debug} 
>> 
>> - uncommenting "vpp_uses_cmake=yes" in build-data/platforms/vpp.mk
>> 
>> - without ebuild:
>> mkdir _build
>> cd _build
>> cmake [-G Ninja] /path/to/vpp/src -DCMAKE_BUILD_TYPE={Release|Debug}
>> (optionally "ccmake ." to change parameters)
>> {ninja|make}
>> 
>> ./bin/vpp unix interactive
>> 
>> Building packages (incomplete / work in progress):
>> $ ninja package
>> [0/1] Run CPack packaging tool...
>> CPack: Create package using DEB
>> CPack: Install projects
>> CPack: - Install project: vpp
>> CPack: -   Install component: dev
>> CPack: -   Install component: plugins
>> CPack: -   Install component: vpp
>> CPack: Create package
>> CPack: - package: /home/damarion/tmp/_build/vpp-dev.deb generated.
>> CPack: - package: /home/damarion/tmp/_build/vpp-plugins.deb
>> generated.
>> CPack: - package: /home/damarion/tmp/_build/vpp.deb generated.
>> 
>> Feedback, issue reports and contributions to get CMake be a full
>> replacement for autotools are welcome.
>> 
>> Thanks,
>> 
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> 
>> View/Reply Online (#10209): https://lists.fd.io/g/vpp-dev/message/102
>> 09
>> Mute This Topic: https://lists.fd.io/mt/24665874/675704
>> Group Owner: vpp-dev+ow...@lists.fd.io
>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [ksek...@cisco.com]
>> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10217): https://lists.fd.io/g/vpp-dev/message/10217
Mute This Topic: https://lists.fd.io/mt/24665874/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] CMake

[Klement Sekera via Lists.Fd.Io]

Hi Damjan,

it seems that the test-debug target is broken with the patch. The build
process triggered by test-debug target jumps on the cmake train, but
that train doesn't bring in the APIGEN and other stuff (e.g.
libvppapiclient.so).

I don't see vpp-api mentioned in src/CMakeLists.txt. Should it be
mentioned?

Thanks,
Klement

On Sat, 2018-08-18 at 12:38 +0200, Damjan Marion via Lists.Fd.Io wrote:
> Dear all,
> 
> Yesterday we merged a patch which introduces CMake build system in
> VPP.
> 
> https://git.fd.io/vpp/commit/?id=612dd6a9
> 
> It is initial patch, and additional work is needed, but in general it
> manages to compile VPP binaries significantly faster 
> than what we have today with autotools.
> 
> In addition it brings following benefits which we can leverage in the
> future:
>  - use of CPack to generate deb/rpms vs. hardcoded scripts we have
> today
>  - much simpler and smaller build definitions specially for plugins
>  - support for different build types (Debug, Release, Release with
> symbols, Coverage, ...)
>  - support for external components (i.e. we can likely build dpdk and
> his dependencies)
> 
> Autotools is still default way to run verify jobs and build images,
> but people can give CMake a try in few ways:
> 
> Step 0: "apt-get install cmake ninja-build"
> 
> - "make {build,rebuild,build-release,rebuild-release}" are already
> using cmake as default, old behaviour can be restored by saying "make
> vpp_uses_cmake=no ..."
> 
> - make -C build-root vpp_uses_cmake=yes PLATFORM=vpp
> TAG={vpp|vpp_debug} 
> 
> - uncommenting "vpp_uses_cmake=yes" in build-data/platforms/vpp.mk
> 
> - without ebuild:
> mkdir _build
> cd _build
> cmake [-G Ninja] /path/to/vpp/src -DCMAKE_BUILD_TYPE={Release|Debug}
> (optionally "ccmake ." to change parameters)
> {ninja|make}
> 
> ./bin/vpp unix interactive
> 
> Building packages (incomplete / work in progress):
> $ ninja package
> [0/1] Run CPack packaging tool...
> CPack: Create package using DEB
> CPack: Install projects
> CPack: - Install project: vpp
> CPack: -   Install component: dev
> CPack: -   Install component: plugins
> CPack: -   Install component: vpp
> CPack: Create package
> CPack: - package: /home/damarion/tmp/_build/vpp-dev.deb generated.
> CPack: - package: /home/damarion/tmp/_build/vpp-plugins.deb
> generated.
> CPack: - package: /home/damarion/tmp/_build/vpp.deb generated.
> 
> Feedback, issue reports and contributions to get CMake be a full
> replacement for autotools are welcome.
> 
> Thanks,
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#10209): https://lists.fd.io/g/vpp-dev/message/102
> 09
> Mute This Topic: https://lists.fd.io/mt/24665874/675704
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [ksek...@cisco.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10216): https://lists.fd.io/g/vpp-dev/message/10216
Mute This Topic: https://lists.fd.io/mt/24665874/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] CMake

[Damjan Marion via Lists.Fd.Io]

> On 18 Aug 2018, at 17:36, Andrew Pinski  wrote:
> 
> On Sat, Aug 18, 2018 at 3:38 AM Damjan Marion via Lists.Fd.Io
> mailto:dmarion=me@lists.fd.io>> wrote:
>> [snip]
>> Feedback, issue reports and contributions to get CMake be a full replacement 
>> for autotools are welcome.
> 
> I think this is backwards.  CMake is worse than the autotools when it
> comes to build systems maintaince and debugging.

Unless you have some data points, it is just another opinion.
My (another) opinion is that autotools is one of ugliest piece of software
I had to deal with, and it is extremely hard to maintain and debug.
Beside that it is damn slow…

To support my opinion with some data points:
Clean VPP build (with cache cleared)  with make takes 14 seconds, same thing 
with autotools takes 54 seconds.

Please note that we definitely don’t need another autotools vs cmake discussion 
here.
If you are able to show same speed and simplicity with autotools in this 
project, I will be more than happy to take into your patch and re-consider use 
of cmake.

> Can someone explain to me the benifit to cmake over autotools?
> Because I see none.


Speed, much simpler configs, specially for people who just need to add new 
plugin into tree, embedded test and packaging.

— 
Damjan-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10211): https://lists.fd.io/g/vpp-dev/message/10211
Mute This Topic: https://lists.fd.io/mt/24665874/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] CMake

[Andrew Pinski]

On Sat, Aug 18, 2018 at 3:38 AM Damjan Marion via Lists.Fd.Io
 wrote:
>
>
> Dear all,
>
> Yesterday we merged a patch which introduces CMake build system in VPP.
>
> https://git.fd.io/vpp/commit/?id=612dd6a9
>
> It is initial patch, and additional work is needed, but in general it manages 
> to compile VPP binaries significantly faster
> than what we have today with autotools.
>
> In addition it brings following benefits which we can leverage in the future:
>  - use of CPack to generate deb/rpms vs. hardcoded scripts we have today
>  - much simpler and smaller build definitions specially for plugins
>  - support for different build types (Debug, Release, Release with symbols, 
> Coverage, ...)
>  - support for external components (i.e. we can likely build dpdk and his 
> dependencies)
>
> Autotools is still default way to run verify jobs and build images, but 
> people can give CMake a try in few ways:
>
> Step 0: "apt-get install cmake ninja-build"
>
> - "make {build,rebuild,build-release,rebuild-release}" are already using 
> cmake as default, old behaviour can be restored by saying "make 
> vpp_uses_cmake=no ..."
>
> - make -C build-root vpp_uses_cmake=yes PLATFORM=vpp TAG={vpp|vpp_debug}
>
> - uncommenting "vpp_uses_cmake=yes" in build-data/platforms/vpp.mk
>
> - without ebuild:
> mkdir _build
> cd _build
> cmake [-G Ninja] /path/to/vpp/src -DCMAKE_BUILD_TYPE={Release|Debug}
> (optionally "ccmake ." to change parameters)
> {ninja|make}
>
> ./bin/vpp unix interactive
>
> Building packages (incomplete / work in progress):
> $ ninja package
> [0/1] Run CPack packaging tool...
> CPack: Create package using DEB
> CPack: Install projects
> CPack: - Install project: vpp
> CPack: -   Install component: dev
> CPack: -   Install component: plugins
> CPack: -   Install component: vpp
> CPack: Create package
> CPack: - package: /home/damarion/tmp/_build/vpp-dev.deb generated.
> CPack: - package: /home/damarion/tmp/_build/vpp-plugins.deb generated.
> CPack: - package: /home/damarion/tmp/_build/vpp.deb generated.
>
> Feedback, issue reports and contributions to get CMake be a full replacement 
> for autotools are welcome.

I think this is backwards.  CMake is worse than the autotools when it
comes to build systems maintaince and debugging.
Can someone explain to me the benifit to cmake over autotools?
Because I see none.

Thanks,
Andrew Pinski

>
> Thanks,
>
> --
> Damjan
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#10209): https://lists.fd.io/g/vpp-dev/message/10209
> Mute This Topic: https://lists.fd.io/mt/24665874/912176
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [pins...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10210): https://lists.fd.io/g/vpp-dev/message/10210
Mute This Topic: https://lists.fd.io/mt/24665874/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] CMake

[Damjan Marion via Lists.Fd.Io]

Dear all,

Yesterday we merged a patch which introduces CMake build system in VPP.

https://git.fd.io/vpp/commit/?id=612dd6a9

It is initial patch, and additional work is needed, but in general it manages 
to compile VPP binaries significantly faster 
than what we have today with autotools.

In addition it brings following benefits which we can leverage in the future:
 - use of CPack to generate deb/rpms vs. hardcoded scripts we have today
 - much simpler and smaller build definitions specially for plugins
 - support for different build types (Debug, Release, Release with symbols, 
Coverage, ...)
 - support for external components (i.e. we can likely build dpdk and his 
dependencies)

Autotools is still default way to run verify jobs and build images, but people 
can give CMake a try in few ways:

Step 0: "apt-get install cmake ninja-build"

- "make {build,rebuild,build-release,rebuild-release}" are already using cmake 
as default, old behaviour can be restored by saying "make vpp_uses_cmake=no ..."

- make -C build-root vpp_uses_cmake=yes PLATFORM=vpp TAG={vpp|vpp_debug} 

- uncommenting "vpp_uses_cmake=yes" in build-data/platforms/vpp.mk

- without ebuild:
mkdir _build
cd _build
cmake [-G Ninja] /path/to/vpp/src -DCMAKE_BUILD_TYPE={Release|Debug}
(optionally "ccmake ." to change parameters)
{ninja|make}

./bin/vpp unix interactive

Building packages (incomplete / work in progress):
$ ninja package
[0/1] Run CPack packaging tool...
CPack: Create package using DEB
CPack: Install projects
CPack: - Install project: vpp
CPack: -   Install component: dev
CPack: -   Install component: plugins
CPack: -   Install component: vpp
CPack: Create package
CPack: - package: /home/damarion/tmp/_build/vpp-dev.deb generated.
CPack: - package: /home/damarion/tmp/_build/vpp-plugins.deb generated.
CPack: - package: /home/damarion/tmp/_build/vpp.deb generated.

Feedback, issue reports and contributions to get CMake be a full replacement 
for autotools are welcome.

Thanks,

-- 
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10209): https://lists.fd.io/g/vpp-dev/message/10209
Mute This Topic: https://lists.fd.io/mt/24665874/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-