Re: [vpp-dev] Change to Gerrit

2019-11-21 Thread Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io 
> implementing something like [0]

+1, but...

> skip the jobs and set verify label after the codestyle checks if no files 
> were changed

... how do you imagine this being implemented in ci-management?

Currently, the other jobs are triggered by checkstyle_success
Gerrit comment, but how would the new checkstyle check know
when to skip it?

I can imagine having two checkstyle jobs
(one skippable and commenting, one unskippable and not commenting),
but +1 from the latter job would not remove the previous -1 from the former.

Vratko.

From: vpp-dev@lists.fd.io  On Behalf Of Paul Vinciguerra
Sent: Wednesday, November 20, 2019 7:33 PM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] Change to Gerrit

How would the group feel about implementing something like [0], so that changes 
to the commit message don't trigger rebuilds?

To enforce the commit message structure, we could skip the jobs and set verify 
label after the codestyle checks if no files were changed.
Maybe others don't care, but I don't like wasting cpu cycles/developer's time, 
and I weigh that before clarifying a commit message.

[0] 
https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14660): https://lists.fd.io/g/vpp-dev/message/14660
Mute This Topic: https://lists.fd.io/mt/60969892/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Paul Vinciguerra 
Hi Andrew.

That used to be the case, not anymore.  See:
https://gerrit.fd.io/r/c/vpp/+/23521 . Changing just the commit via the UI,
triggers everything.

Paul

On Wed, Nov 20, 2019 at 6:56 PM Andrew 👽 Yourtchenko 
wrote:

> Does this idea keep in mind a corner case of editing the commit message
> over the gerrit UI?
>
> That operation currently doesn’t trigger the rebuilds... (Though i tend to
> use it for a quick edit to recover a checkstyle error, so I would rather
> have it trigger the checkstyle :-)
>
> If these things above do not get worse than today, then +1...
>
>
> --a
>
> On 20 Nov 2019, at 19:32, Paul Vinciguerra 
> wrote:
>
> How would the group feel about implementing something like [0], so that
> changes to the commit message don't trigger rebuilds?
>
> To enforce the commit message structure, we could skip the jobs and set
> verify label after the codestyle checks if no files were changed.
> Maybe others don't care, but I don't like wasting cpu cycles/developer's
> time, and I weigh that before clarifying a commit message.
>
> [0]
> https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#14643): https://lists.fd.io/g/vpp-dev/message/14643
> Mute This Topic: https://lists.fd.io/mt/60969892/675608
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [ayour...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14650): https://lists.fd.io/g/vpp-dev/message/14650
Mute This Topic: https://lists.fd.io/mt/60969892/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Andrew Yourtchenko 
Does this idea keep in mind a corner case of editing the commit message over 
the gerrit UI?

That operation currently doesn’t trigger the rebuilds... (Though i tend to use 
it for a quick edit to recover a checkstyle error, so I would rather have it 
trigger the checkstyle :-)

If these things above do not get worse than today, then +1...


--a

> On 20 Nov 2019, at 19:32, Paul Vinciguerra  wrote:
> 
> How would the group feel about implementing something like [0], so that 
> changes to the commit message don't trigger rebuilds?
> 
> To enforce the commit message structure, we could skip the jobs and set 
> verify label after the codestyle checks if no files were changed.
> Maybe others don't care, but I don't like wasting cpu cycles/developer's 
> time, and I weigh that before clarifying a commit message.
> 
> [0] 
> https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
>  -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#14643): https://lists.fd.io/g/vpp-dev/message/14643
> Mute This Topic: https://lists.fd.io/mt/60969892/675608
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [ayour...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14649): https://lists.fd.io/g/vpp-dev/message/14649
Mute This Topic: https://lists.fd.io/mt/60969892/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Damjan Marion via Lists.Fd.Io 
+1

> On 20 Nov 2019, at 19:32, Paul Vinciguerra  wrote:
> 
> How would the group feel about implementing something like [0], so that 
> changes to the commit message don't trigger rebuilds?
> 
> To enforce the commit message structure, we could skip the jobs and set 
> verify label after the codestyle checks if no files were changed.
> Maybe others don't care, but I don't like wasting cpu cycles/developer's 
> time, and I weigh that before clarifying a commit message.
> 
> [0] 
> https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
>  
> 
>  -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#14643): https://lists.fd.io/g/vpp-dev/message/14643
> Mute This Topic: https://lists.fd.io/mt/60969892/675642
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14648): https://lists.fd.io/g/vpp-dev/message/14648
Mute This Topic: https://lists.fd.io/mt/60969892/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [EXTERNAL] [vpp-dev] Change to Gerrit

2019-11-20 Thread Chris Luke 
+1

From: vpp-dev@lists.fd.io  On Behalf Of Paul Vinciguerra
Sent: Wednesday, November 20, 2019 1:33 PM
To: vpp-dev@lists.fd.io
Subject: [EXTERNAL] [vpp-dev] Change to Gerrit

How would the group feel about implementing something like [0], so that changes 
to the commit message don't trigger rebuilds?

To enforce the commit message structure, we could skip the jobs and set verify 
label after the codestyle checks if no files were changed.
Maybe others don't care, but I don't like wasting cpu cycles/developer's time, 
and I weigh that before clarifying a commit message.

[0] 
https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange<https://urldefense.com/v3/__https:/gerrit-review.googlesource.com/Documentation/config-labels.html*label_copyAllScoresIfNoCodeChange__;Iw!rx_L75ITgOQ!UGlk_0CcZR7E5EtM9SY9bazR9VpjaIMfjpsXsoOpq6iXftO4OIXgYP3NBxmOtPiONQ$>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14646): https://lists.fd.io/g/vpp-dev/message/14646
Mute This Topic: https://lists.fd.io/mt/60971897/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Dave Barach via Lists.Fd.Io 
+1

From: vpp-dev@lists.fd.io  On Behalf Of Paul Vinciguerra
Sent: Wednesday, November 20, 2019 1:33 PM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] Change to Gerrit

How would the group feel about implementing something like [0], so that changes 
to the commit message don't trigger rebuilds?

To enforce the commit message structure, we could skip the jobs and set verify 
label after the codestyle checks if no files were changed.
Maybe others don't care, but I don't like wasting cpu cycles/developer's time, 
and I weigh that before clarifying a commit message.

[0] 
https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14645): https://lists.fd.io/g/vpp-dev/message/14645
Mute This Topic: https://lists.fd.io/mt/60969892/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Florin Coras 
+1 

Florin

> On Nov 20, 2019, at 10:32 AM, Paul Vinciguerra  
> wrote:
> 
> How would the group feel about implementing something like [0], so that 
> changes to the commit message don't trigger rebuilds?
> 
> To enforce the commit message structure, we could skip the jobs and set 
> verify label after the codestyle checks if no files were changed.
> Maybe others don't care, but I don't like wasting cpu cycles/developer's 
> time, and I weigh that before clarifying a commit message.
> 
> [0] 
> https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
>  
> 
>  -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#14643): https://lists.fd.io/g/vpp-dev/message/14643
> Mute This Topic: https://lists.fd.io/mt/60969892/675152
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [fcoras.li...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14644): https://lists.fd.io/g/vpp-dev/message/14644
Mute This Topic: https://lists.fd.io/mt/60969892/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Change to Gerrit

2019-11-20 Thread Paul Vinciguerra 
How would the group feel about implementing something like [0], so that changes 
to the commit message don't trigger rebuilds?

To enforce the commit message structure, we could skip the jobs and set verify 
label after the codestyle checks if no files were changed.
Maybe others don't care, but I don't like wasting cpu cycles/developer's time, 
and I weigh that before clarifying a commit message.

[0] 
https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14643): https://lists.fd.io/g/vpp-dev/message/14643
Mute This Topic: https://lists.fd.io/mt/60969892/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-