[webkit-changes] [92352] trunk

[commit-queue]

Title: [92352] trunk








Revision 92352
Author commit-qu...@webkit.org
Date 2011-08-03 23:35:56 -0700 (Wed, 03 Aug 2011)


Log Message
An element with role=textbox should have settable AXValue unless read-only
https://bugs.webkit.org/show_bug.cgi?id=65664

Patch by Alice Boxhall  on 2011-08-03
Reviewed by Chris Fleizach.

Source/WebCore:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetValueAttribute):
Return true for non-native text field with aria-readonly not set.

LayoutTests:

* accessibility/aria-readonly-expected.txt:
* accessibility/aria-readonly.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/aria-readonly-expected.txt
trunk/LayoutTests/accessibility/aria-readonly.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (92351 => 92352)

--- trunk/LayoutTests/ChangeLog	2011-08-04 06:08:47 UTC (rev 92351)
+++ trunk/LayoutTests/ChangeLog	2011-08-04 06:35:56 UTC (rev 92352)
@@ -1,3 +1,13 @@
+2011-08-03  Alice Boxhall  
+
+An element with role=textbox should have settable AXValue unless read-only
+https://bugs.webkit.org/show_bug.cgi?id=65664
+
+Reviewed by Chris Fleizach.
+
+* accessibility/aria-readonly-expected.txt:
+* accessibility/aria-readonly.html:
+
 2011-08-03  Kentaro Hara  
 
 Implement EventSender.scalePageBy()


Modified: trunk/LayoutTests/accessibility/aria-readonly-expected.txt (92351 => 92352)

--- trunk/LayoutTests/accessibility/aria-readonly-expected.txt	2011-08-04 06:08:47 UTC (rev 92351)
+++ trunk/LayoutTests/accessibility/aria-readonly-expected.txt	2011-08-04 06:35:56 UTC (rev 92352)
@@ -1,15 +1,17 @@
  
-This tests that the aria-readonly attribute works. The first and third text fields should not be writable.
+This tests that the AXValue property is correctly reported for native and non-native text boxes.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS succeeded is false
-PASS succeeded is true
-PASS succeeded is false
-PASS succeeded is true
-PASS succeeded is false
-PASS succeeded is true
+PASS ariaTextBoxIsWritable is true
+PASS ariaReadOnlyAriaTextBoxIsWritable is false
+PASS ariaReadOnlyTextFieldIsWritable is false
+PASS ariaNonReadOnlyTextFieldIsWritable is true
+PASS htmlReadOnlyTextFieldIsWritable is false
+PASS textFieldIsWritable is true
+PASS htmlReadOnlyTextAreaIsWritable is false
+PASS textAreaIsWritable is true
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/accessibility/aria-readonly.html (92351 => 92352)

--- trunk/LayoutTests/accessibility/aria-readonly.html	2011-08-04 06:08:47 UTC (rev 92351)
+++ trunk/LayoutTests/accessibility/aria-readonly.html	2011-08-04 06:35:56 UTC (rev 92352)
@@ -8,46 +8,61 @@
 

[webkit-changes] [92351] trunk/Tools

[abarth]

Title: [92351] trunk/Tools








Revision 92351
Author aba...@webkit.org
Date 2011-08-03 23:08:47 -0700 (Wed, 03 Aug 2011)


Log Message
Use failureInfo more pervasively in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65650

Reviewed by Dimitri Glazkov.

These three variable appears in concert together many places.  This
patch unifies the remaining uses into being failureInfo objects, which
saves some marshalling.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92350 => 92351)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 05:34:55 UTC (rev 92350)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 06:08:47 UTC (rev 92351)
@@ -71,35 +71,35 @@
 });
 }
 
-function showResultsDetail(testName, builderName, failureTypeList)
+function showResultsDetail(failureInfo)
 {
-var failureTypes = failureTypeList.join(' ');
+var failureTypes = failureInfo.failureTypeList.join(' ');
 
 var content = $('.results-detail .content');
 
-if ($('.failure-details', content).attr(config.kBuilderNameAttr) == builderName &&
-$('.failure-details', content).attr(config.kTestNameAttr) == testName &&
+if ($('.failure-details', content).attr(config.kBuilderNameAttr) == failureInfo.builderName &&
+$('.failure-details', content).attr(config.kTestNameAttr) == failureInfo.testName &&
 $('.failure-details', content).attr(config.kFailureTypesAttr) == failureTypes)
 return;
 
 displayOnButterbar('Loading...');
 
-results.fetchResultsURLs(builderName, testName, failureTypeList, function(resultsURLs) {
+results.fetchResultsURLs(failureInfo, function(resultsURLs) {
 var status = $('.results-detail .toolbar .status');
 
 status.empty();
 content.empty();
 
 // FIXME: We should be passing the full list of failing builder names as the fourth argument.
-status.append(ui.failureDetailsStatus(testName, builderName, failureTypes, [builderName]));
+status.append(ui.failureDetailsStatus(failureInfo, [failureInfo.builderName]));
 content.append(ui.failureDetails(resultsURLs));
 
 toggleButton($('.results-detail .actions .next'), g_resultsDetailsIterator.hasNext());
 toggleButton($('.results-detail .actions .previous'), g_resultsDetailsIterator.hasPrevious());
-toggleButton($('.results-detail .actions .rebaseline'), results.canRebaseline(failureTypeList));
+toggleButton($('.results-detail .actions .rebaseline'), results.canRebaseline(failureInfo.failureTypeList));
 
-$('.failure-details', content).attr(config.kBuilderNameAttr, builderName);
-$('.failure-details', content).attr(config.kTestNameAttr, testName);
+$('.failure-details', content).attr(config.kTestNameAttr, failureInfo.testName);
+$('.failure-details', content).attr(config.kBuilderNameAttr, failureInfo.builderName);
 $('.failure-details', content).attr(config.kFailureTypesAttr, failureTypes);
 
 if (!$('.results-detail').is(":visible"))
@@ -197,10 +197,7 @@
 
 function showSelectedFailures()
 {
-var argumentList = selectedFailures().map(function(failureInfo) {
-return [failureInfo.testName, failureInfo.builderName, failureInfo.failureTypeList];
-});
-g_resultsDetailsIterator = new base.CallbackIterator(showResultsDetail, argumentList);
+g_resultsDetailsIterator = new base.CallbackIterator(showResultsDetail, selectedFailures());
 g_resultsDetailsIterator.callNext();
 }
 


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js (92350 => 92351)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js	2011-08-04 05:34:55 UTC (rev 92350)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js	2011-08-04 06:08:47 UTC (rev 92351)
@@ -418,12 +418,12 @@
 return sortedURLs;
 }
 
-results.fet

[webkit-changes] [92350] trunk/Source/WebKit/win

[tkent]

Title: [92350] trunk/Source/WebKit/win








Revision 92350
Author tk...@chromium.org
Date 2011-08-03 22:34:55 -0700 (Wed, 03 Aug 2011)


Log Message
[Windows] Fix build without ENABLE_VIDEO.

* WebView.cpp:
(WebView::enterFullscreenForNode):

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (92349 => 92350)

--- trunk/Source/WebKit/win/ChangeLog	2011-08-04 04:40:11 UTC (rev 92349)
+++ trunk/Source/WebKit/win/ChangeLog	2011-08-04 05:34:55 UTC (rev 92350)
@@ -1,5 +1,12 @@
 2011-08-03  Kent Tamura  
 
+[Windows] Fix build without ENABLE_VIDEO.
+
+* WebView.cpp:
+(WebView::enterFullscreenForNode):
+
+2011-08-03  Kent Tamura  
+
 Fix incorrect checks for HTMLMediaElement
 https://bugs.webkit.org/show_bug.cgi?id=65590
 


Modified: trunk/Source/WebKit/win/WebView.cpp (92349 => 92350)

--- trunk/Source/WebKit/win/WebView.cpp	2011-08-04 04:40:11 UTC (rev 92349)
+++ trunk/Source/WebKit/win/WebView.cpp	2011-08-04 05:34:55 UTC (rev 92350)
@@ -6137,10 +6137,12 @@
 
 void WebView::enterFullscreenForNode(Node* node)
 {
-if (!node->hasTagName(HTMLNames::videoTag) || !node->isElementNode() || !static_cast(node)->isMediaElement())
+if (!node->hasTagName(HTMLNames::videoTag) || !node->isElementNode())
 return;
 
 #if ENABLE(VIDEO)
+if (!static_cast(node)->isMediaElement())
+return;
 HTMLMediaElement* videoElement = static_cast(node);
 
 if (m_fullScreenVideoController) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92349] trunk/Source/WebCore

[macpherson]

Title: [92349] trunk/Source/WebCore








Revision 92349
Author macpher...@chromium.org
Date 2011-08-03 21:40:11 -0700 (Wed, 03 Aug 2011)


Log Message
Clean up value clamping in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65588

Reviewed by Darin Adler.

No new tests / trivial code cleanup only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Replace (unsigned int)primitiveValue->getDoubleValue() with primtiveValue->getValue() for correct clamping.
Replace clampToInteger(primitiveValue->getDoubleValue()) with primitiveValue->getIntValue().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92348 => 92349)

--- trunk/Source/WebCore/ChangeLog	2011-08-04 04:38:32 UTC (rev 92348)
+++ trunk/Source/WebCore/ChangeLog	2011-08-04 04:40:11 UTC (rev 92349)
@@ -1,3 +1,17 @@
+2011-08-03  Luke Macpherson   
+
+Clean up value clamping in CSSStyleSelector.
+https://bugs.webkit.org/show_bug.cgi?id=65588
+
+Reviewed by Darin Adler.
+
+No new tests / trivial code cleanup only.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Replace (unsigned int)primitiveValue->getDoubleValue() with primtiveValue->getValue() for correct clamping.
+Replace clampToInteger(primitiveValue->getDoubleValue()) with primitiveValue->getIntValue().
+
 2011-08-03  Kent Tamura  
 
 Fix incorrect checks for HTMLMediaElement


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (92348 => 92349)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-04 04:38:32 UTC (rev 92348)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-04 04:40:11 UTC (rev 92349)
@@ -4537,13 +4537,13 @@
 HANDLE_INHERIT_AND_INITIAL(boxFlexGroup, BoxFlexGroup)
 if (!primitiveValue || primitiveValue->primitiveType() != CSSPrimitiveValue::CSS_NUMBER)
 return; // Error case.
-m_style->setBoxFlexGroup((unsigned int)(primitiveValue->getDoubleValue()));
+m_style->setBoxFlexGroup(primitiveValue->getValue());
 return;
 case CSSPropertyWebkitBoxOrdinalGroup:
 HANDLE_INHERIT_AND_INITIAL(boxOrdinalGroup, BoxOrdinalGroup)
 if (!primitiveValue || primitiveValue->primitiveType() != CSSPrimitiveValue::CSS_NUMBER)
 return; // Error case.
-m_style->setBoxOrdinalGroup((unsigned int)(primitiveValue->getDoubleValue()));
+m_style->setBoxOrdinalGroup(primitiveValue->getValue());
 return;
 case CSSPropertyBoxSizing:
 HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(boxSizing, BoxSizing);
@@ -4699,7 +4699,7 @@
 return;
 case CSSPropertyWebkitContentOrder:
 HANDLE_INHERIT_AND_INITIAL(regionIndex, RegionIndex);
-m_style->setRegionIndex(clampToInteger(primitiveValue->getDoubleValue()));
+m_style->setRegionIndex(primitiveValue->getIntValue());
 return;
 case CSSPropertyWebkitRegionOverflow:
 HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(regionOverflow, RegionOverflow);
@@ -6449,8 +6449,7 @@
 // This is a quirk that should go away when 3d transforms are finalized.
 double val = firstValue->getDoubleValue();
 ok = val >= 0;
-val = clampToPositiveInteger(val);
-p = Length(static_cast(val), Fixed);
+p = Length(clampToPositiveInteger(val), Fixed);
 }
 
 if (!ok)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92348] trunk/Tools

[abarth]

Title: [92348] trunk/Tools








Revision 92348
Author aba...@webkit.org
Date 2011-08-03 21:38:32 -0700 (Wed, 03 Aug 2011)


Log Message
garden-o-matic should be able to update expecations from the details pane
https://bugs.webkit.org/show_bug.cgi?id=65648

Reviewed by Dimitri Glazkov.

The new button queues up the updates, which get executed all at once.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (92347 => 92348)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-04 04:38:01 UTC (rev 92347)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-04 04:38:32 UTC (rev 92348)
@@ -13,16 +13,13 @@
 Loading...
 
 
-Show Selected Failures
-Rebaseline Selected
-Mark Selected as Expected
-Refresh
+Show Selected FailuresRebaseline SelectedMark Selected as ExpectedRefresh
 
 
 
 
 
-Add to Rebaseline Queue◀▶Close
+Add to Rebaseline QueueMark Failure as Expected◀▶Close
 
 
 


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92347 => 92348)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 04:38:01 UTC (rev 92347)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 04:38:32 UTC (rev 92348)
@@ -61,6 +61,8 @@
 
 function rebaseline(failureInfoList)
 {
+if (!failureInfoList.length)
+return;
 displayOnButterbar('Rebaselining...');
 checkout.rebaseline(failureInfoList, function() {
 dismissButterbar();
@@ -69,12 +71,6 @@
 });
 }
 
-function updateExpectations(failureInfoList)
-{
-displayOnButterbar('Adding expectations...');
-checkout.updateExpectations(failureInfoList, dismissButterbar);
-}
-
 function showResultsDetail(testName, builderName, failureTypeList)
 {
 var failureTypes = failureTypeList.join(' ');
@@ -113,15 +109,6 @@
 });
 }
 
-function executeQueuedRebaselines()
-{
-var failureInfoList = model.takeRebaselineQueue();
-if (!failureInfoList.length)
-return;
-// FIXME: Should we confirm with the use before executing the queue?
-rebaseline(failureInfoList);
-}
-
 function hideResultsDetail()
 {
 $('.results-detail').fadeOut('fast', function() {
@@ -131,7 +118,10 @@
 // but doing so helps the garbage collector free memory.
 g_resultsDetailsIterator = null;
 });
-executeQueuedRebaselines();
+checkout.updateExpectations(model.takeExpectationUpdateQueue(), function() {
+// FIXME: Should we confirm with the use before executing the queue?
+rebaseline(model.takeRebaselineQueue());
+});
 }
 
 function nextResultsDetail()
@@ -147,16 +137,25 @@
 g_resultsDetailsIterator.callPrevious();
 }
 
-function addToRebaselineQueue()
+function failureInfoFromResultsDetail()
 {
 var failureDetails = $('.failure-details', $(this).parents('.results-detail'));
+return {
+'builderName': failureDetails.attr(config.kBuilderNameAttr),
+'testName': failureDetails.attr(config.kTestNameAttr),
+'failureTypeList': failureDetails.attr(config.kFailureTypesAttr).split(' '),
+}
+}
 
-var builderName = failureDetails.attr(config.kBuilderNameAttr);
-var testName = failureDetails.attr(config.kTestNameAttr);
-var failureTypes = failureDetails.attr(config.kFailureTypesAttr);
-var failureTypeList = failureTypes.split(' ');
+function addToRebaselineQueue()
+{
+model.queueForRebaseline(failureInfoFromResultsDetail());
+nextResultsDetail();
+}
 
-model.queueForRebaseline(builderName, testName, failureTypeList);
+function addToExpectationUpdateQueue()
+{
+model.queueForExpectationUpdate(failureInfoFromResultsDetail());
 nextResultsDetail();
 }
 
@@ -193,7 +192,7 @@
 
 function updateExpectationsForSelected()
 {
-updateExpectations(selectedFailures());
+checkout.updateExpectations(selectedFailures(), $.noop);
 }
 
 function showSelectedFailures()
@@ -282,6 +281,7 @@
 $('.results-detail .actions .next').live('click', nextResultsDetail);
 $('.results-detail .actions .previous').live('click', previousResultsDetail);
 $('.results-detail .actions .rebaseline').live('click', addToRebaselineQueu

[webkit-changes] [92347] trunk/Source

[tkent]

Title: [92347] trunk/Source








Revision 92347
Author tk...@chromium.org
Date 2011-08-03 21:38:01 -0700 (Wed, 03 Aug 2011)


Log Message
Fix incorrect checks for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=65590

Reviewed by Dimitri Glazkov.

 and  can be an HTMLElement instance instead of
HTMLMediaElement if MediaPlayer::isAvailable() returns false or
the media feature is disabled at runtime.

Source/WebCore:

* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedIntoTree):
(WebCore::HTMLSourceElement::willRemove):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
* html/shadow/MediaControlElements.cpp:
(WebCore::toParentMediaElement):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaMuteButton):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController _isAnyMoviePlaying]):

Source/WebKit/win:

* WebView.cpp:
(WebView::enterFullscreenForNode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSourceElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.cpp
trunk/Source/WebCore/html/shadow/MediaControlElements.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp
trunk/Source/WebCore/rendering/RenderThemeMac.mm
trunk/Source/WebCore/rendering/RenderThemeWinCE.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebFullScreenController.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92346 => 92347)

--- trunk/Source/WebCore/ChangeLog	2011-08-04 04:16:47 UTC (rev 92346)
+++ trunk/Source/WebCore/ChangeLog	2011-08-04 04:38:01 UTC (rev 92347)
@@ -1,3 +1,33 @@
+2011-08-03  Kent Tamura  
+
+Fix incorrect checks for HTMLMediaElement
+https://bugs.webkit.org/show_bug.cgi?id=65590
+
+Reviewed by Dimitri Glazkov.
+
+ and  can be an HTMLElement instance instead of
+HTMLMediaElement if MediaPlayer::isAvailable() returns false or
+the media feature is disabled at runtime.
+
+* html/HTMLSourceElement.cpp:
+(WebCore::HTMLSourceElement::insertedIntoTree):
+(WebCore::HTMLSourceElement::willRemove):
+* html/HTMLTrackElement.cpp:
+(WebCore::HTMLTrackElement::insertedIntoTree):
+(WebCore::HTMLTrackElement::willRemove):
+* html/shadow/MediaControlElements.cpp:
+(WebCore::toParentMediaElement):
+* page/FrameView.cpp:
+(WebCore::FrameView::updateWidget):
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::paintMediaMuteButton):
+* platform/gtk/RenderThemeGtk.cpp:
+(WebCore::getMediaElementFromRenderObject):
+* rendering/RenderThemeMac.mm:
+(WebCore::RenderThemeMac::paintMediaSliderTrack):
+* rendering/RenderThemeWinCE.cpp:
+(WebCore::mediaElementParent):
+
 2011-08-03  Sailesh Agrawal  
 
 Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible


Modified: trunk/Source/WebCore/html/HTMLSourceElement.cpp (92346 => 92347)

--- trunk/Source/WebCore/html/HTMLSourceElement.cpp	2011-08-04 04:16:47 UTC (rev 92346)
+++ trunk/Source/WebCore/html/HTMLSourceElement.cpp	2011-08-04 04:38:01 UTC (rev 92347)
@@ -57,13 +57,15 @@
 void HTMLSourceElement::insertedIntoTree(bool deep)
 {
 HTMLElement::insertedIntoTree(deep);
-if (parentNode() && (parentNode()->hasTagName(audioTag) || parentNode()->hasTagName(videoTag)))
+Element* parent = parentElement();
+if (parent && parent->isMediaElement())
 static_cast(parentNode())->sourceWasAdded(this);
 }
 
 void HTMLSourceElement::willRemove()
 {
-if (parentNode() && (parentNode()->hasTagName(audioTag) || parentNode()->hasTagName(videoTag)))
+Element* parent = parentElement();
+if (parent && parent->isMediaElement())
 static_cast(parentNode())->sourceWillBeRemoved(this);
 HTMLElement::willRemove();
 }


Modified: trunk/Source/WebCore/html/HTMLTrackElement.cpp (92346 => 92347)

--- trunk/Source/WebCore/html/HTMLTrackElement.cpp	2011-08-04 04:16:47 UTC (rev 92346)
+++ trunk/Source/WebCore/html/HTMLTrackElement.cpp	2011-08-04 04:38:01 UTC (rev 92347)
@@ -57,7 +57,8 @@
 void HTMLTrackElement::insertedIntoTree(bool deep)
 {
 HTMLElement::insertedIntoTree(deep);
-if (parentNode() && (parentNode()->hasTagName(audioTag) || parentNode()->hasTagName(videoTag))) {
+Element* parent = parentElement();
+if (parent && parent->isMediaElement()) {
 // TODO(annacc):
 // static_cast(pare

[webkit-changes] [92346] trunk/Tools

[abarth]

Title: [92346] trunk/Tools








Revision 92346
Author aba...@webkit.org
Date 2011-08-03 21:16:47 -0700 (Wed, 03 Aug 2011)


Log Message
Add UI to garden-o-matic for updating expectations
https://bugs.webkit.org/show_bug.cgi?id=65644

Reviewed by Dimitri Glazkov.

The patch plumbs the UI back to the gardening server, but the gardening
server endpoint is just a stub at this point.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js (92345 => 92346)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-04 03:54:57 UTC (rev 92345)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-04 04:16:47 UTC (rev 92346)
@@ -28,6 +28,13 @@
 });
 };
 
+checkout.updateExpectations = function(failureInfoList, callback)
+{
+$.post('/updateexpectations', JSON.stringify(failureInfoList), function() {
+callback();
+});
+};
+
 checkout.optimizeBaselines = function(testName, callback)
 {
 $.post('/optimizebaselines?' + $.param({
@@ -37,21 +44,21 @@
 });
 };
 
-checkout.rebaseline = function(rebaselineTasks, callback)
+checkout.rebaseline = function(failureInfoList, callback)
 {
-base.callInSequence(function(task, callback) {
-var extensionList = Array.prototype.concat.apply([], task.failureTypeList.map(results.failureTypeToExtensionList));
+base.callInSequence(function(failureInfo, callback) {
+var extensionList = Array.prototype.concat.apply([], failureInfo.failureTypeList.map(results.failureTypeToExtensionList));
 base.callInSequence(function(extension, callback) {
 $.post('/rebaseline?' + $.param({
-'builder': task.builderName,
-'test': task.testName,
+'builder': failureInfo.builderName,
+'test': failureInfo.testName,
 'extension': extension
 }), function() {
 callback();
 });
 }, extensionList, callback);
-}, rebaselineTasks, function() {
-var testNameList = base.uniquifyArray(rebaselineTasks.map(function(task) { return task.testName; }));
+}, failureInfoList, function() {
+var testNameList = base.uniquifyArray(failureInfoList.map(function(failureInfo) { return failureInfo.testName; }));
 base.callInSequence(checkout.optimizeBaselines, testNameList, callback);
 });
 };


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (92345 => 92346)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-04 03:54:57 UTC (rev 92345)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-04 04:16:47 UTC (rev 92346)
@@ -15,6 +15,7 @@
 
 Show Selected Failures
 Rebaseline Selected
+Mark Selected as Expected
 Refresh
 
 


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92345 => 92346)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 03:54:57 UTC (rev 92345)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 04:16:47 UTC (rev 92346)
@@ -59,16 +59,22 @@
 button.attr('disabled', true)
 }
 
-function rebaseline(rebaselineTasks)
+function rebaseline(failureInfoList)
 {
 displayOnButterbar('Rebaselining...');
-checkout.rebaseline(rebaselineTasks, function() {
+checkout.rebaseline(failureInfoList, function() {
 dismissButterbar();
 // FIXME: We should use something like a lightbox rather than alert!
 alert('New results downloaded to your working copy. Please use "webkit-patch land-cowboy" to land the updated baselines.');
 });
 }
 
+function updateExpectations(failureInfoList)
+{
+displayOnButterbar('Adding expectations...');
+

[webkit-changes] [92345] trunk/Source/WebKit2

[jeffm]

Title: [92345] trunk/Source/WebKit2








Revision 92345
Author je...@apple.com
Date 2011-08-03 20:54:57 -0700 (Wed, 03 Aug 2011)


Log Message
Use of AVFoundation should default to off on Windows
https://bugs.webkit.org/show_bug.cgi?id=65660

Reviewed by Darin Adler.

* Shared/WebPreferencesStore.h: Change default value for AVFoundationEnabled to false on Windows, it's still true on other platforms.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92344 => 92345)

--- trunk/Source/WebKit2/ChangeLog	2011-08-04 03:02:54 UTC (rev 92344)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-04 03:54:57 UTC (rev 92345)
@@ -1,3 +1,12 @@
+2011-08-03  Jeff Miller  
+
+Use of AVFoundation should default to off on Windows
+https://bugs.webkit.org/show_bug.cgi?id=65660
+
+Reviewed by Darin Adler.
+
+* Shared/WebPreferencesStore.h: Change default value for AVFoundationEnabled to false on Windows, it's still true on other platforms.
+
 2011-08-03  Mark Rowe  
 
 Bring some order to FeatureDefines.xcconfig to make it easier to follow.


Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (92344 => 92345)

--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2011-08-04 03:02:54 UTC (rev 92344)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2011-08-04 03:54:57 UTC (rev 92345)
@@ -36,6 +36,12 @@
 
 // macro(KeyUpper, KeyLower, TypeNameUpper, TypeName, DefaultValue) 
 
+#if PLATFORM(WIN)
+#define DEFAULT_WEBKIT_AVFOUNDATION_ENABLED false
+#else
+#define DEFAULT_WEBKIT_AVFOUNDATION_ENABLED true
+#endif
+
 #define FOR_EACH_WEBKIT_BOOL_PREFERENCE(macro) \
 macro(_javascript_Enabled, _javascript_Enabled, Bool, bool, true) \
 macro(LoadsImagesAutomatically, loadsImagesAutomatically, Bool, bool, true) \
@@ -74,7 +80,7 @@
 macro(WebSecurityEnabled, webSecurityEnabled, Bool, bool, true) \
 macro(AllowUniversalAccessFromFileURLs, allowUniversalAccessFromFileURLs, Bool, bool, false) \
 macro(AllowFileAccessFromFileURLs, allowFileAccessFromFileURLs, Bool, bool, false) \
-macro(AVFoundationEnabled, isAVFoundationEnabled, Bool, bool, true) \
+macro(AVFoundationEnabled, isAVFoundationEnabled, Bool, bool, DEFAULT_WEBKIT_AVFOUNDATION_ENABLED) \
 macro(Hixie76WebSocketProtocolEnabled, hixie76WebSocketProtocolEnabled, Bool, bool, true) \
 macro(MediaPlaybackRequiresUserGesture, mediaPlaybackRequiresUserGesture, Bool, bool, false) \
 macro(MediaPlaybackAllowsInline, mediaPlaybackAllowsInline, Bool, bool, true) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92344] trunk/Tools

[abarth]

Title: [92344] trunk/Tools








Revision 92344
Author aba...@webkit.org
Date 2011-08-03 20:02:54 -0700 (Wed, 03 Aug 2011)


Log Message
garden-o-matic details view should queue rebaselines for later execution
https://bugs.webkit.org/show_bug.cgi?id=65636

Reviewed by Dimitri Glazkov.

This patch doesn't contain any confirmation UI, but we'll probably want
that at some point.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js (92343 => 92344)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-04 02:35:41 UTC (rev 92343)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-04 03:02:54 UTC (rev 92344)
@@ -37,25 +37,19 @@
 });
 };
 
-checkout.rebaseline = function(builderName, testName, failureTypeList, callback)
+checkout.rebaseline = function(rebaselineTasks, callback)
 {
-var extensionList = Array.prototype.concat.apply([], failureTypeList.map(results.failureTypeToExtensionList));
-
-base.callInSequence(function(extension, callback) {
-$.post('/rebaseline?' + $.param({
-'builder': builderName,
-'test': testName,
-'extension': extension
-}), function() {
-callback();
-});
-}, extensionList, callback);
-};
-
-checkout.rebaselineAll = function(rebaselineTasks, callback)
-{
 base.callInSequence(function(task, callback) {
-checkout.rebaseline(task.builderName, task.testName, task.failureTypeList, callback);
+var extensionList = Array.prototype.concat.apply([], task.failureTypeList.map(results.failureTypeToExtensionList));
+base.callInSequence(function(extension, callback) {
+$.post('/rebaseline?' + $.param({
+'builder': task.builderName,
+'test': task.testName,
+'extension': extension
+}), function() {
+callback();
+});
+}, extensionList, callback);
 }, rebaselineTasks, function() {
 var testNameList = base.uniquifyArray(rebaselineTasks.map(function(task) { return task.testName; }));
 base.callInSequence(checkout.optimizeBaselines, testNameList, callback);


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (92343 => 92344)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-04 02:35:41 UTC (rev 92343)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-04 03:02:54 UTC (rev 92344)
@@ -21,7 +21,7 @@
 
 
 
-Rebaseline◀▶Close
+Add to Rebaseline Queue◀▶Close
 
 
 


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92343 => 92344)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 02:35:41 UTC (rev 92343)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-04 03:02:54 UTC (rev 92344)
@@ -59,6 +59,16 @@
 button.attr('disabled', true)
 }
 
+function rebaseline(rebaselineTasks)
+{
+displayOnButterbar('Rebaselining...');
+checkout.rebaseline(rebaselineTasks, function() {
+dismissButterbar();
+// FIXME: We should use something like a lightbox rather than alert!
+alert('New results downloaded to your working copy. Please use "webkit-patch land-cowboy" to land the updated baselines.');
+});
+}
+
 function showResultsDetail(testName, builderName, failureTypeList)
 {
 var failureTypes = failureTypeList.join(' ');
@@ -97,6 +107,15 @@
 });
 }
 
+function executeQueuedRebaselines()
+{
+var rebaselineQueue = model.takeRebaselineQueue();
+if (!rebaselineQueue.length)
+return;
+// FIXME: Should we confirm with the use before executing the queue?
+rebaseline(rebaselineQueue);
+}
+
 function hideResultsDetail()
 {
 $('.results-detail').fadeOut('fast', function() {
@@ -106,11 +125,15 @@
 // but doing so helps the garbage collector free memory.

[webkit-changes] [92343] trunk/Source/WebCore

[commit-queue]

Title: [92343] trunk/Source/WebCore








Revision 92343
Author commit-qu...@webkit.org
Date 2011-08-03 19:35:41 -0700 (Wed, 03 Aug 2011)


Log Message
Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
https://bugs.webkit.org/show_bug.cgi?id=65659

Patch by Sailesh Agrawal  on 2011-08-03
Reviewed by James Robinson.

ScrollbarOverlayUtilitiesChromiumMac.h couldn't be included from pure c++ code because it used NSInteger. I fixed this by checking for __OBJC__ before using NSInteger.

Currently no pure c++ files are including ScrollbarOverlayUtilitiesChromiumMac.h but this will change in future patches from j...@chromium.org.

* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterControllerStyle):
(wkSetScrollbarPainterControllerStyle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (92342 => 92343)

--- trunk/Source/WebCore/ChangeLog	2011-08-04 02:09:19 UTC (rev 92342)
+++ trunk/Source/WebCore/ChangeLog	2011-08-04 02:35:41 UTC (rev 92343)
@@ -1,3 +1,19 @@
+2011-08-03  Sailesh Agrawal  
+
+Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
+https://bugs.webkit.org/show_bug.cgi?id=65659
+
+Reviewed by James Robinson.
+
+ScrollbarOverlayUtilitiesChromiumMac.h couldn't be included from pure c++ code because it used NSInteger. I fixed this by checking for __OBJC__ before using NSInteger.
+
+Currently no pure c++ files are including ScrollbarOverlayUtilitiesChromiumMac.h but this will change in future patches from j...@chromium.org.
+
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+(wkScrollbarPainterControllerStyle):
+(wkSetScrollbarPainterControllerStyle):
+
 2011-08-03  Luke Macpherson   
 
 Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.


Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h (92342 => 92343)

--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h	2011-08-04 02:09:19 UTC (rev 92342)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h	2011-08-04 02:35:41 UTC (rev 92343)
@@ -35,9 +35,14 @@
 NSScrollerStyleLegacy   = 0,
 NSScrollerStyleOverlay  = 1
 };
+
+#ifdef __OBJC__
 typedef NSInteger NSScrollerStyle;
 #endif
+#endif
 
+typedef uint32 wkScrollerStyle;
+
 #ifdef __OBJC__
 @class NSScrollerImp;
 @class NSScrollerImpPair;
@@ -93,11 +98,11 @@
 void wkDidBeginScrollGesture(WKScrollbarPainterControllerRef);
 void wkDidEndScrollGesture(WKScrollbarPainterControllerRef);
 void wkScrollbarPainterForceFlashScrollers(WKScrollbarPainterControllerRef);
-void wkSetScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef, int newStyle);
+void wkSetScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef, wkScrollerStyle newStyle);
 void wkSetPainterForPainterController(WKScrollbarPainterControllerRef, WKScrollbarPainterRef, bool isHorizontal);
 WKScrollbarPainterRef wkVerticalScrollbarPainterForController(WKScrollbarPainterControllerRef);
 WKScrollbarPainterRef wkHorizontalScrollbarPainterForController(WKScrollbarPainterControllerRef);
-NSScrollerStyle wkScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef);
+wkScrollerStyle wkScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef);
 
 #endif // USE(WK_SCROLLBAR_PAINTER)
 


Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm (92342 => 92343)

--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm	2011-08-04 02:09:19 UTC (rev 92342)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm	2011-08-04 02:35:41 UTC (rev 92343)
@@ -218,7 +218,7 @@
 return [controller horizontalScrollerImp];
 }
 
-NSScrollerStyle wkScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef controller)
+wkScrollerStyle wkScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef controller)
 {
 return [controller scrollerStyle];
 }
@@ -241,7 +241,7 @@
 [controller setVerticalScrollerImp:painter];
 }
 
-void wkSetScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef painter, int newStyle)
+void wkSetScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef painter, wkScrollerStyle newStyle)
 {
 [painter setScrollerStyle:newStyle];
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92342] trunk/Source/WebCore

[macpherson]

Title: [92342] trunk/Source/WebCore








Revision 92342
Author macpher...@chromium.org
Date 2011-08-03 19:09:19 -0700 (Wed, 03 Aug 2011)


Log Message
Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65657

Reviewed by Simon Fraser.

No new tests / refactoring only.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Implement cast from EBoxSizing.
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
Implement cast to EBoxSizing.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to simplify code using cast.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92341 => 92342)

--- trunk/Source/WebCore/ChangeLog	2011-08-04 02:01:31 UTC (rev 92341)
+++ trunk/Source/WebCore/ChangeLog	2011-08-04 02:09:19 UTC (rev 92342)
@@ -1,3 +1,21 @@
+2011-08-03  Luke Macpherson   
+
+Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.
+https://bugs.webkit.org/show_bug.cgi?id=65657
+
+Reviewed by Simon Fraser.
+
+No new tests / refactoring only.
+
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+Implement cast from EBoxSizing.
+(WebCore::CSSPrimitiveValue::operator EBoxSizing):
+Implement cast to EBoxSizing.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use appropriate macro to simplify code using cast.
+
 2011-08-03  Ian Henderson  
 
 Draw rectangular box shadow for elements with border-radius if no corners are visible


Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (92341 => 92342)

--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2011-08-04 02:01:31 UTC (rev 92341)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2011-08-04 02:09:19 UTC (rev 92342)
@@ -597,6 +597,33 @@
 }
 }
 
+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EBoxSizing e)
+: m_type(CSS_IDENT)
+, m_hasCachedCSSText(false)
+{
+switch (e) {
+case BORDER_BOX:
+m_value.ident = CSSValueBorderBox;
+break;
+case CONTENT_BOX:
+m_value.ident = CSSValueContentBox;
+break;
+}
+}
+
+template<> inline CSSPrimitiveValue::operator EBoxSizing() const
+{
+switch (m_value.ident) {
+case CSSValueBorderBox:
+return BORDER_BOX;
+case CSSValueContentBox:
+return CONTENT_BOX;
+default:
+ASSERT_NOT_REACHED();
+return BORDER_BOX;
+}
+}
+
 template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EBoxDirection e)
 : m_type(CSS_IDENT)
 , m_hasCachedCSSText(false)


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (92341 => 92342)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-04 02:01:31 UTC (rev 92341)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-04 02:09:19 UTC (rev 92342)
@@ -4546,13 +4546,7 @@
 m_style->setBoxOrdinalGroup((unsigned int)(primitiveValue->getDoubleValue()));
 return;
 case CSSPropertyBoxSizing:
-HANDLE_INHERIT_AND_INITIAL(boxSizing, BoxSizing)
-if (!primitiveValue)
-return;
-if (primitiveValue->getIdent() == CSSValueContentBox)
-m_style->setBoxSizing(CONTENT_BOX);
-else
-m_style->setBoxSizing(BORDER_BOX);
+HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(boxSizing, BoxSizing);
 return;
 case CSSPropertyWebkitColumnSpan: {
 HANDLE_INHERIT_AND_INITIAL(columnSpan, ColumnSpan)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92341] trunk

[commit-queue]

Title: [92341] trunk








Revision 92341
Author commit-qu...@webkit.org
Date 2011-08-03 19:01:31 -0700 (Wed, 03 Aug 2011)


Log Message
Implement EventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Patch by Kentaro Hara  on 2011-08-03
Reviewed by Darin Fisher.

Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
and then sets a scroll position to (x, y). Enabled the tests that had been waiting
for the implementation of EventSender.scalePageBy(f, x, y).

Source/WebKit/chromium:

Tests: compositing/scaling/tiled-layer-recursion.html
   fast/repaint/scale-page-shrink.html
   fast/dom/Element/scale-page-client-rects.html
   fast/dom/Range/scale-page-client-rects.html
   fast/events/scroll-in-scaled-page-with-overflow-hidden.html
   fast/dom/Element/scale-page-bounding-client-rect.html
   fast/dom/Range/scale-page-bounding-client-rect.html

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scalePage): A wrapper method for scalePage() in WebCore.
* src/WebViewImpl.h:

Tools:

Tests: compositing/scaling/tiled-layer-recursion.html
   fast/repaint/scale-page-shrink.html
   fast/dom/Element/scale-page-client-rects.html
   fast/dom/Range/scale-page-client-rects.html
   fast/events/scroll-in-scaled-page-with-overflow-hidden.html
   fast/dom/Element/scale-page-bounding-client-rect.html
   fast/dom/Range/scale-page-bounding-client-rect.html

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender): Added bindings for scalePageBy().
(EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController): Resets the scale factor to 1.

LayoutTests:

* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
* platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Removed.
* platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Removed.
* platform/chromium/test_expectations.txt: Enabled one test. Enabled two tests for chromium-linux.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/EventSender.cpp
trunk/Tools/DumpRenderTree/chromium/EventSender.h
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp


Added Paths

trunk/LayoutTests/platform/chromium-linux/compositing/scaling/
trunk/LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92340 => 92341)

--- trunk/LayoutTests/ChangeLog	2011-08-04 01:51:07 UTC (rev 92340)
+++ trunk/LayoutTests/ChangeLog	2011-08-04 02:01:31 UTC (rev 92341)
@@ -1,3 +1,25 @@
+2011-08-03  Kentaro Hara  
+
+Implement EventSender.scalePageBy()
+https://bugs.webkit.org/show_bug.cgi?id=58013
+
+Reviewed by Darin Fisher.
+
+Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
+and then sets a scroll position to (x, y). Enabled the tests that had been waiting
+for the implementation of EventSender.scalePageBy(f, x, y).
+
+* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
+* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png: Added.
+* platform/chromium-linux/fast/repaint/scale-

[webkit-changes] [92339] trunk/LayoutTests

[commit-queue]

Title: [92339] trunk/LayoutTests








Revision 92339
Author commit-qu...@webkit.org
Date 2011-08-03 18:44:14 -0700 (Wed, 03 Aug 2011)


Log Message
[Chromium] fast/dom/resource-locations-in-created-html-document.html fails on win32
https://bugs.webkit.org/show_bug.cgi?id=65521

Patch by Noel Gordon  on 2011-08-03
Reviewed by Adam Barth.

file: scheme URI paths on Windows include the disk drive reference (C: for example).
Refer to http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx.

* fast/dom/resource-locations-in-created-html-document.html:
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/resource-locations-in-created-html-document.html
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92338 => 92339)

--- trunk/LayoutTests/ChangeLog	2011-08-04 01:41:29 UTC (rev 92338)
+++ trunk/LayoutTests/ChangeLog	2011-08-04 01:44:14 UTC (rev 92339)
@@ -1,3 +1,16 @@
+2011-08-03  Noel Gordon  
+
+[Chromium] fast/dom/resource-locations-in-created-html-document.html fails on win32
+https://bugs.webkit.org/show_bug.cgi?id=65521
+
+Reviewed by Adam Barth.
+
+file: scheme URI paths on Windows include the disk drive reference (C: for example).
+Refer to http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx.
+
+* fast/dom/resource-locations-in-created-html-document.html:
+* platform/chromium/test_expectations.txt:
+
 2011-08-03  Ryosuke Niwa  
 
 Revert an erroneous rebaseline from r92315.


Modified: trunk/LayoutTests/fast/dom/resource-locations-in-created-html-document.html (92338 => 92339)

--- trunk/LayoutTests/fast/dom/resource-locations-in-created-html-document.html	2011-08-04 01:41:29 UTC (rev 92338)
+++ trunk/LayoutTests/fast/dom/resource-locations-in-created-html-document.html	2011-08-04 01:44:14 UTC (rev 92339)
@@ -10,8 +10,12 @@
 htmlDoc.open();
 htmlDoc.write(' 
-if (htmlDoc.getElementById('theImage').src == 'file:///test')
+var path = htmlDoc.getElementById('theImage').src;
+
+if (path == 'file:///test')
 document.getElementById('result').innerHTML = 'SUCCESS';
+else if (/^file:\/\/\/[C-Z]:\/test$/.test(path))  // MS Windows.
+document.getElementById('result').innerHTML = 'SUCCESS';
 }
 
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92338 => 92339)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-04 01:41:29 UTC (rev 92338)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-04 01:44:14 UTC (rev 92339)
@@ -1041,13 +1041,6 @@
 
 // Post-MERGE failures: these will all need to be fixed one day
 
-// This test assumes we're using unix paths and looks for a file:///test
-// path.  We correctly return file:///C:/test on Windows.  We should fix
-// upstream
-// Expectations for this test changed upstream. We should fix this test, but
-// it doesn't need to block the current release
-BUGCR10325 WIN : fast/dom/resource-locations-in-created-html-document.html = FAIL
-
 // GURL/KURL difference in handling of "http:".
 // New test. We should fix it, but it doesn't need to block the current release
 BUGCR7386 : http/tests/security/postMessage/invalid-origin-throws-exception.html = FAIL






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92338] trunk/LayoutTests

[rniwa]

Title: [92338] trunk/LayoutTests








Revision 92338
Author rn...@webkit.org
Date 2011-08-03 18:41:29 -0700 (Wed, 03 Aug 2011)


Log Message
Revert an erroneous rebaseline from r92315.

* fast/dom/navigator-detached-no-crash-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92337 => 92338)

--- trunk/LayoutTests/ChangeLog	2011-08-04 00:22:21 UTC (rev 92337)
+++ trunk/LayoutTests/ChangeLog	2011-08-04 01:41:29 UTC (rev 92338)
@@ -1,5 +1,11 @@
 2011-08-03  Ryosuke Niwa  
 
+Revert an erroneous rebaseline from r92315.
+
+* fast/dom/navigator-detached-no-crash-expected.txt:
+
+2011-08-03  Ryosuke Niwa  
+
 Chromium Windows and Linux rebaselines after r92330.
 
 * platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.


Modified: trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt (92337 => 92338)

--- trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt	2011-08-04 00:22:21 UTC (rev 92337)
+++ trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt	2011-08-04 01:41:29 UTC (rev 92338)
@@ -13,7 +13,6 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
@@ -30,7 +29,6 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92337] trunk/Source/WebCore

[noam . rosenthal]

Title: [92337] trunk/Source/WebCore








Revision 92337
Author noam.rosent...@nokia.com
Date 2011-08-03 17:22:21 -0700 (Wed, 03 Aug 2011)


Log Message
[Qt][Texmap][REGRESSION] http://webkit.org/blog-files/transform-style.html doesn't show composited content
https://bugs.webkit.org/show_bug.cgi?id=65629

Reviewed by Benjamin Poulain.

Some non-ES2 initialization was wrongfully #ifdefed in CPU(X86) and thus compiled-out.
When put it in the correct #ifdef, composited layers which require an intermediate buffer
work again.

No new tests. Existing opacity tests in LayoutTests/compositing test this.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::bind):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92336 => 92337)

--- trunk/Source/WebCore/ChangeLog	2011-08-04 00:16:43 UTC (rev 92336)
+++ trunk/Source/WebCore/ChangeLog	2011-08-04 00:22:21 UTC (rev 92337)
@@ -1,3 +1,19 @@
+2011-08-03  No'am Rosenthal  
+
+[Qt][Texmap][REGRESSION] http://webkit.org/blog-files/transform-style.html doesn't show composited content
+https://bugs.webkit.org/show_bug.cgi?id=65629
+
+Reviewed by Benjamin Poulain.
+
+Some non-ES2 initialization was wrongfully #ifdefed in CPU(X86) and thus compiled-out.
+When put it in the correct #ifdef, composited layers which require an intermediate buffer
+work again.
+
+No new tests. Existing opacity tests in LayoutTests/compositing test this.
+
+* platform/graphics/opengl/TextureMapperGL.cpp:
+(WebCore::BitmapTextureGL::bind):
+
 2011-08-03  Mark Rowe  
 
 Bring some order to FeatureDefines.xcconfig to make it easier to follow.


Modified: trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp (92336 => 92337)

--- trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp	2011-08-04 00:16:43 UTC (rev 92336)
+++ trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp	2011-08-04 00:22:21 UTC (rev 92337)
@@ -594,7 +594,7 @@
 GL_CMD(glBindRenderbuffer(GL_RENDERBUFFER, 0))
 GL_CMD(glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, id(), 0))
 GL_CMD(glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_STENCIL_ATTACHMENT, GL_RENDERBUFFER, m_rbo))
-#if CPU(X86)
+#ifndef TEXMAP_OPENGL_ES_2
 GL_CMD(glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, m_rbo));
 #endif
 GL_CMD(glClearColor(0, 0, 0, 0))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92336] trunk/LayoutTests

[rniwa]

Title: [92336] trunk/LayoutTests








Revision 92336
Author rn...@webkit.org
Date 2011-08-03 17:16:43 -0700 (Wed, 03 Aug 2011)


Log Message
Chromium Windows and Linux rebaselines after r92330.

* platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92335 => 92336)

--- trunk/LayoutTests/ChangeLog	2011-08-03 23:57:41 UTC (rev 92335)
+++ trunk/LayoutTests/ChangeLog	2011-08-04 00:16:43 UTC (rev 92336)
@@ -1,5 +1,13 @@
 2011-08-03  Ryosuke Niwa  
 
+Chromium Windows and Linux rebaselines after r92330.
+
+* platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.
+* platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Removed.
+* platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
+
+2011-08-03  Ryosuke Niwa  
+
 select-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the element inside itself
 https://bugs.webkit.org/show_bug.cgi?id=26483
 


Deleted: trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt (92335 => 92336)

--- trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt	2011-08-03 23:57:41 UTC (rev 92335)
+++ trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt	2011-08-04 00:16:43 UTC (rev 92336)
@@ -1,10 +0,0 @@
-Tests: 
-Copying and pasting content inside of a PRE tag. This test was created after fixing 3918056.
-Expected Results: 
-The PRE tag and the formatting of the text inside of the PRE should be maintained. Should see this content in the red box below:
-foo
-bar
-foo
-bar
-execCutCommand:   
-execPasteCommand:  foo bar 


Deleted: trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt (92335 => 92336)

--- trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt	2011-08-03 23:57:41 UTC (rev 92335)
+++ trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt	2011-08-04 00:16:43 UTC (rev 92336)
@@ -1,5 +0,0 @@
-This is a layout test for rdar://problem/4370209 "Reproducible crash when pasting over whitespace:pre text". The text below is selected, copied, and pasted over itself. You'll see foo/nbar if successful.
-foo
-bar
-execCopyCommand:  foo bar 
-execPasteCommand:  foo bar 


Deleted: trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt (92335 => 92336)

--- trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt	2011-08-03 23:57:41 UTC (rev 92335)
+++ trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt	2011-08-04 00:16:43 UTC (rev 92336)
@@ -1,49 +0,0 @@
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of P > BODY > HTML > #document to 0 of P > BODY > HTML > #document toDOMRange:range from 0 of #text > B > FONT > P > BODY > HTML > #document to 5 of #text > B > FONT > P > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > B > FONT > P > BODY > HTML > #document to 5 of #text > B > FONT > P > BODY > HTML > #document toDOMRange:range from 0 of P > BODY > HTML > #document to 0 of P > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of P > BODY > HTML > #document to 0 of P > BODY > HTML > #document givenAction:WebViewInsertActionPasted
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 5 of #text > B > FONT > P > SPAN > B > FONT > P > BODY > HTML > #document to 5 of #text > B > FONT > P > SPAN > B > FONT > P > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebVie

[webkit-changes] [92335] branches/chromium/835/Source/WebCore/platform/graphics/chromium/ LayerTilerChromium.cpp

[enne]

Title: [92335] branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp








Revision 92335
Author e...@google.com
Date 2011-08-03 16:57:41 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 92331 - [chromium] Fix issue where switching composited tabs evicts root textures
https://bugs.webkit.org/show_bug.cgi?id=65562

Reviewed by James Robinson.

LayerTilerChromium::protectTileTextures was hard-coding texture sizes
and texture formats. Because this didn't always match textures' actual
sizes and formats, they weren't getting protected during eviction.

* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::protectTileTextures):

TBR=e...@google.com
Review URL: http://codereview.chromium.org/7508041

Modified Paths

branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp (92334 => 92335)

--- branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp	2011-08-03 23:53:54 UTC (rev 92334)
+++ branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp	2011-08-03 23:57:41 UTC (rev 92335)
@@ -254,10 +254,10 @@
 for (int j = top; j <= bottom; ++j) {
 for (int i = left; i <= right; ++i) {
 Tile* tile = tileAt(i, j);
-if (!tile || !tile->texture()->isValid(m_tileSize, GraphicsContext3D::RGBA))
+if (!tile || !tile->texture()->isValid(m_tileSize, m_textureFormat))
 continue;
 
-tile->texture()->reserve(m_tileSize, GraphicsContext3D::RGBA);
+tile->texture()->reserve(m_tileSize, m_textureFormat);
 }
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92334] trunk/Tools

[levin]

Title: [92334] trunk/Tools








Revision 92334
Author le...@chromium.org
Date 2011-08-03 16:53:54 -0700 (Wed, 03 Aug 2011)


Log Message
Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=65652

Reviewed by Adam Barth.

* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (92333 => 92334)

--- trunk/Tools/ChangeLog	2011-08-03 23:51:03 UTC (rev 92333)
+++ trunk/Tools/ChangeLog	2011-08-03 23:53:54 UTC (rev 92334)
@@ -1,3 +1,13 @@
+2011-08-03  David Levin  
+
+Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
+https://bugs.webkit.org/show_bug.cgi?id=65652
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+
 2011-08-03  Filip Pizlo  
 
 Adding Filip Pizlo to committer list.


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (92333 => 92334)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2011-08-03 23:51:03 UTC (rev 92333)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2011-08-03 23:53:54 UTC (rev 92334)
@@ -1601,19 +1601,19 @@
 return
 
 modifiers_and_return_type = function_state.modifiers_and_return_type()
-if filename.find('/chromium/') != -1 and search(r'\bWEBKIT_API\b', modifiers_and_return_type):
+if filename.find('/chromium/') != -1 and search(r'\bWEBKIT_EXPORT\b', modifiers_and_return_type):
 if filename.find('/chromium/public/') == -1:
-error(function_state.function_name_start_position.row, 'readability/webkit_api', 5,
-  'WEBKIT_API should only appear in the chromium public directory.')
+error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
+  'WEBKIT_EXPORT should only appear in the chromium public directory.')
 elif not file_extension == "h":
-error(function_state.function_name_start_position.row, 'readability/webkit_api', 5,
-  'WEBKIT_API should only be used in header files.')
+error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
+  'WEBKIT_EXPORT should only be used in header files.')
 elif not function_state.is_declaration or search(r'\binline\b', modifiers_and_return_type):
-error(function_state.function_name_start_position.row, 'readability/webkit_api', 5,
-  'WEBKIT_API should not be used on a function with a body.')
+error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
+  'WEBKIT_EXPORT should not be used on a function with a body.')
 elif function_state.is_pure:
-error(function_state.function_name_start_position.row, 'readability/webkit_api', 5,
-  'WEBKIT_API should not be used with a pure virtual function.')
+error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
+  'WEBKIT_EXPORT should not be used with a pure virtual function.')
 
 check_function_definition_and_pass_ptr(modifiers_and_return_type, function_state.function_name_start_position.row, 'return', error)
 
@@ -3482,7 +3482,7 @@
 'readability/streams',
 'readability/todo',
 'readability/utf8',
-'readability/webkit_api',
+'readability/webkit_export',
 'runtime/arrays',
 'runtime/bitfields',
 'runtime/casting',


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (92333 => 92334)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2011-08-03 23:51:03 UTC (rev 92333)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2011-08-03 23:53:54 UTC (rev 92334)
@@ -4461,47 +4461,47 @@
  'One space before end of line comments'
  '  [whitespace/comments] [5]')
 
-def test_webkit_api_check(self):
-webkit_api_error_rules = ('-',
-  '+readability/webkit_api')
+def test_webkit_export_check(self):
+webkit_export_error_rules = ('-',
+  '+readability/webkit_export')
 self.assertEquals('',
-  self.perform_lint('WEBKIT_API int foo();\n',
+  self.perform_lint('WEBKIT_EXPORT int foo();\n',
 'WebKit/chromium/public/test.h',
-webkit_api_error_rules))
-self.assertEquals('WEBKIT_API should only be used in header files.  [readability/webkit_api] [5]',
-  self.perform_lint('WEBKIT_API int foo();\n',
+  

[webkit-changes] [92333] trunk/Source

[mrowe]

Title: [92333] trunk/Source








Revision 92333
Author mr...@apple.com
Date 2011-08-03 16:51:03 -0700 (Wed, 03 Aug 2011)


Log Message
Bring some order to FeatureDefines.xcconfig to make it easier to follow.

Reviewed by Sam Weinig.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92332 => 92333)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-03 23:50:50 UTC (rev 92332)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-03 23:51:03 UTC (rev 92333)
@@ -1,5 +1,13 @@
 2011-08-03  Mark Rowe  
 
+Bring some order to FeatureDefines.xcconfig to make it easier to follow.
+
+Reviewed by Sam Weinig.
+
+* Configurations/FeatureDefines.xcconfig:
+
+2011-08-03  Mark Rowe  
+
 Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
 
 Reviewed by Dave Kilzer.


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (92332 => 92333)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2011-08-03 23:50:50 UTC (rev 92332)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2011-08-03 23:51:03 UTC (rev 92333)
@@ -31,98 +31,73 @@
 
 // Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
 
-ENABLE_LINK_PREFETCH = ;
-
-ENABLE_ACCELERATED_2D_CANVAS = ;
-
-ENABLE_WEBGL = ENABLE_WEBGL;
-
-ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
-
-ENABLE_ANIMATION_API = ;
-
 ENABLE_BLOB = $(ENABLE_BLOB_$(REAL_PLATFORM_NAME));
 ENABLE_BLOB_macosx = ENABLE_BLOB;
 
-ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
-
 ENABLE_CLIENT_BASED_GEOLOCATION = $(ENABLE_CLIENT_BASED_GEOLOCATION_$(REAL_PLATFORM_NAME));
 ENABLE_CLIENT_BASED_GEOLOCATION_macosx = ENABLE_CLIENT_BASED_GEOLOCATION;
 
-ENABLE_CSS_REGIONS = ;
-ENABLE_CSS_EXCLUSIONS = ;
-
-ENABLE_DATABASE = ENABLE_DATABASE;
-
 ENABLE_DATALIST = $(ENABLE_DATALIST_$(REAL_PLATFORM_NAME));
 ENABLE_DATALIST_macosx = ENABLE_DATALIST;
 
-ENABLE_DATA_TRANSFER_ITEMS = ;
+ENABLE_FILTERS = $(ENABLE_FILTERS_$(REAL_PLATFORM_NAME));
+ENABLE_FILTERS_macosx = ENABLE_FILTERS;
 
+ENABLE_ICONDATABASE = $(ENABLE_ICONDATABASE_$(REAL_PLATFORM_NAME));
+ENABLE_ICONDATABASE_macosx = ENABLE_ICONDATABASE;
+
+ENABLE_SVG_DOM_OBJC_BINDINGS = $(ENABLE_SVG_DOM_OBJC_BINDINGS_$(REAL_PLATFORM_NAME));
+ENABLE_SVG_DOM_OBJC_BINDINGS_macosx = ENABLE_SVG_DOM_OBJC_BINDINGS;
+
+ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
+ENABLE_ACCELERATED_2D_CANVAS = ;
+ENABLE_ANIMATION_API = ;
+ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
+ENABLE_CSS3_FLEXBOX = ;
+ENABLE_CSS_EXCLUSIONS = ;
+ENABLE_CSS_REGIONS = ;
+ENABLE_DATABASE = ENABLE_DATABASE;
+ENABLE_DATA_TRANSFER_ITEMS = ;
+ENABLE_DETAILS = ENABLE_DETAILS;
 ENABLE_DEVICE_ORIENTATION = ;
 ENABLE_DIRECTORY_UPLOAD = ;
 ENABLE_DOM_STORAGE = ENABLE_DOM_STORAGE;
 ENABLE_EVENTSOURCE = ENABLE_EVENTSOURCE;
-
-ENABLE_FILTERS = $(ENABLE_FILTERS_$(REAL_PLATFORM_NAME));
-ENABLE_FILTERS_macosx = ENABLE_FILTERS;
-
 ENABLE_FILE_SYSTEM = ;
-
-ENABLE_CSS3_FLEXBOX = ;
-
 ENABLE_FULLSCREEN_API = ENABLE_FULLSCREEN_API;
 ENABLE_GEOLOCATION = ENABLE_GEOLOCATION;
-
-ENABLE_ICONDATABASE = $(ENABLE_ICONDATABASE_$(REAL_PLATFORM_NAME));
-ENABLE_ICONDATABASE_macosx = ENABLE_ICONDATABASE;
-
 ENABLE_INDEXED_DATABASE = ;
 ENABLE_INPUT_COLOR = ;
 ENABLE_INPUT_SPEECH = ;
 ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER;
+ENABLE_LINK_PREFETCH = ;
 ENABLE_MATHML = ENABLE_MATHML;
-ENABLE_DETAILS = ENABLE_DETAILS;
+ENABLE_MEDIA_STATISTICS = ;
 ENABLE_METER_TAG = ENABLE_METER_TAG;
 ENABLE_MHTML = ;
 ENABLE_NOTIFICATIONS = ;
 ENABLE_OFFLINE_WEB_APPLICATIONS = ENABLE_OFFLINE_WEB_APPLICATIONS;
 ENABLE_PAGE_VISIBILITY_API = ;
 ENABLE_PROGRESS_TAG = ENABLE_PROGRESS_TAG;
-
 ENABLE_QUOTA = ;
-
 ENABLE_REGISTER_PROTOCOL_HANDLER = ;
-
 ENABLE_SHARED_WORKERS = ENABLE_SHARED_WORKERS;
-
 ENABLE_SVG = ENABLE_SVG;
 ENABLE_SVG_ANIMATION = ENABLE_SVG_ANIMATION;
 ENABLE_SVG_AS_IMAGE = ENABLE_SVG_AS_IMAGE;
-
-ENABLE_SVG_DOM_OBJC_BINDINGS = $(ENABLE_SVG_DOM_OBJC_BINDINGS_$(REAL_PLATFORM_NAME));
-ENABLE_SVG_DOM_OBJC_BINDINGS_macosx = ENABLE_SVG_DOM_OBJC_BINDINGS;
-
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_SVG_FOREIGN_OBJECT = ENABLE_SVG_FOREIGN_OBJECT;
 ENABLE_SVG_USE = ENABLE_SVG_USE;
+ENABLE_TOUCH_ICON_LOADING = ;
 ENABLE_VIDEO = ENABLE_VIDEO;
 ENABLE_VIDEO_TRACK = ;
-
-ENABLE_MEDIA_STATISTICS = ;
-
-ENABLE_TOU

[webkit-changes] [92332] trunk/Source

[mrowe]

Title: [92332] trunk/Source








Revision 92332
Author mr...@apple.com
Date 2011-08-03 16:50:50 -0700 (Wed, 03 Aug 2011)


Log Message
Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings

Reviewed by Dave Kilzer.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92331 => 92332)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-03 23:43:15 UTC (rev 92331)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-03 23:50:50 UTC (rev 92332)
@@ -1,3 +1,11 @@
+2011-08-03  Mark Rowe  
+
+Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
+
+Reviewed by Dave Kilzer.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2011-08-03  Filip Pizlo  
 
 JSC GC heap size improvement breaks build on some platforms due to


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (92331 => 92332)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2011-08-03 23:43:15 UTC (rev 92331)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2011-08-03 23:50:50 UTC (rev 92332)
@@ -33,31 +33,18 @@
 
 ENABLE_LINK_PREFETCH = ;
 
-ENABLE_ACCELERATED_2D_CANVAS = $(ENABLE_ACCELERATED_2D_CANVAS_$(REAL_PLATFORM_NAME));
-ENABLE_ACCELERATED_2D_CANVAS_macosx = $(ENABLE_ACCELERATED_2D_CANVAS_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
-ENABLE_ACCELERATED_2D_CANVAS_macosx_1060 = ;
-ENABLE_ACCELERATED_2D_CANVAS_macosx_1070 = ;
+ENABLE_ACCELERATED_2D_CANVAS = ;
 
-ENABLE_WEBGL = $(ENABLE_WEBGL_$(REAL_PLATFORM_NAME));
-ENABLE_WEBGL_macosx = $(ENABLE_WEBGL_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
-ENABLE_WEBGL_macosx_1060 = ENABLE_WEBGL;
-ENABLE_WEBGL_macosx_1070 = ENABLE_WEBGL;
+ENABLE_WEBGL = ENABLE_WEBGL;
 
-ENABLE_3D_RENDERING = $(ENABLE_3D_RENDERING_$(REAL_PLATFORM_NAME));
-ENABLE_3D_RENDERING_iphoneos = ENABLE_3D_RENDERING;
-ENABLE_3D_RENDERING_iphonesimulator = $(ENABLE_3D_RENDERING_iphoneos);
-ENABLE_3D_RENDERING_macosx = $(ENABLE_3D_RENDERING_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
-ENABLE_3D_RENDERING_macosx_1050 = ENABLE_3D_RENDERING;
-ENABLE_3D_RENDERING_macosx_1060 = ENABLE_3D_RENDERING;
-ENABLE_3D_RENDERING_macosx_1070 = ENABLE_3D_RENDERING;
+ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
 
 ENABLE_ANIMATION_API = ;
 
 ENABLE_BLOB = $(ENABLE_BLOB_$(REAL_PLATFORM_NAME));
 ENABLE_BLOB_macosx = ENABLE_BLOB;
 
-ENABLE_CHANNEL_MESSAGING = $(ENABLE_CHANNEL_MESSAGING_$(REAL_PLATFORM_NAME));
-ENABLE_CHANNEL_MESSAGING_macosx = ENABLE_CHANNEL_MESSAGING;
+ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 
 ENABLE_CLIENT_BASED_GEOLOCATION = $(ENABLE_CLIENT_BASED_GEOLOCATION_$(REAL_PLATFORM_NAME));
 ENABLE_CLIENT_BASED_GEOLOCATION_macosx = ENABLE_CLIENT_BASED_GEOLOCATION;
@@ -82,7 +69,7 @@
 
 ENABLE_FILE_SYSTEM = ;
 
-ENABLE_CSS3_FLEXBOX =;
+ENABLE_CSS3_FLEXBOX = ;
 
 ENABLE_FULLSCREEN_API = ENABLE_FULLSCREEN_API;
 ENABLE_GEOLOCATION = ENABLE_GEOLOCATION;
@@ -107,8 +94,7 @@
 
 ENABLE_REGISTER_PROTOCOL_HANDLER = ;
 
-ENABLE_SHARED_WORKERS = $(ENABLE_SHARED_WORKERS_$(REAL_PLATFORM_NAME));
-ENABLE_SHARED_WORKERS_macosx = ENABLE_SHARED_WORKERS;
+ENABLE_SHARED_WORKERS = ENABLE_SHARED_WORKERS;
 
 ENABLE_SVG = ENABLE_SVG;
 ENABLE_SVG_ANIMATION = ENABLE_SVG_ANIMATION;
@@ -129,13 +115,11 @@
 
 ENABLE_WEB_AUDIO = ;
 
-ENABLE_WEB_SOCKETS = $(ENABLE_WEB_SOCKETS_$(REAL_PLATFORM_NAME));
-ENABLE_WEB_SOCKETS_macosx = ENABLE_WEB_SOCKETS;
+ENABLE_WEB_SOCKETS = ENABLE_WEB_SOCKETS;
 
 ENABLE_WEB_TIMING = ;
 
-ENABLE_WORKERS = $(ENABLE_WORKERS_$(REAL_PLATFORM_NAME));
-ENABLE_WORKERS_macosx = ENABLE_WORKERS;
+ENABLE_WORKERS = ENABLE_WORKERS;
 
 ENABLE_XHTMLMP = ;
 ENABLE_XPATH = ENABLE_XPATH;


Modified: trunk/Source/WebCore/ChangeLog (92331 => 92332)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 23:43:15 UTC (rev 92331)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 23:50:50 UTC (rev 92332)
@@ -1,3 +1,11 @@
+2011-08-03  Mark Rowe  
+
+Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
+
+Reviewed by Dave Kilzer.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2011-08-02  Adrienne Walker  
 
 [chromium] Fix issue where switching composited tabs evicts root textures


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (92331 => 92332)

--- trunk/Source/WebCore/Configurations/FeatureDe

[webkit-changes] [92331] trunk/Source/WebCore

[enne]

Title: [92331] trunk/Source/WebCore








Revision 92331
Author e...@google.com
Date 2011-08-03 16:43:15 -0700 (Wed, 03 Aug 2011)


Log Message
[chromium] Fix issue where switching composited tabs evicts root textures
https://bugs.webkit.org/show_bug.cgi?id=65562

Reviewed by James Robinson.

LayerTilerChromium::protectTileTextures was hard-coding texture sizes
and texture formats. Because this didn't always match textures' actual
sizes and formats, they weren't getting protected during eviction.

* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::protectTileTextures):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92330 => 92331)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 23:42:25 UTC (rev 92330)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 23:43:15 UTC (rev 92331)
@@ -1,3 +1,17 @@
+2011-08-02  Adrienne Walker  
+
+[chromium] Fix issue where switching composited tabs evicts root textures
+https://bugs.webkit.org/show_bug.cgi?id=65562
+
+Reviewed by James Robinson.
+
+LayerTilerChromium::protectTileTextures was hard-coding texture sizes
+and texture formats. Because this didn't always match textures' actual
+sizes and formats, they weren't getting protected during eviction.
+
+* platform/graphics/chromium/LayerTilerChromium.cpp:
+(WebCore::LayerTilerChromium::protectTileTextures):
+
 2011-08-03  Ryosuke Niwa  
 
 select-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the element inside itself


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp (92330 => 92331)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp	2011-08-03 23:42:25 UTC (rev 92330)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp	2011-08-03 23:43:15 UTC (rev 92331)
@@ -242,10 +242,10 @@
 for (int j = top; j <= bottom; ++j) {
 for (int i = left; i <= right; ++i) {
 Tile* tile = tileAt(i, j);
-if (!tile || !tile->texture()->isValid(m_tileSize, GraphicsContext3D::RGBA))
+if (!tile || !tile->texture()->isValid(m_tileSize, m_textureFormat))
 continue;
 
-tile->texture()->reserve(m_tileSize, GraphicsContext3D::RGBA);
+tile->texture()->reserve(m_tileSize, m_textureFormat);
 }
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92330] trunk

[rniwa]

Title: [92330] trunk








Revision 92330
Author rn...@webkit.org
Date 2011-08-03 16:42:25 -0700 (Wed, 03 Aug 2011)


Log Message
select-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the element inside itself
https://bugs.webkit.org/show_bug.cgi?id=26483

Reviewed by Enrica Casucci.

Source/WebCore: 

The bug was caused by WebKit serializing pre, h1, etc... to retain structure and appearance when copying
rich content and pasting did not remove such nodes wrapping the copied contents.

Fixed the bug by extending r81887 and r83322 to remove those elements from where WebKit pastes into.

Test: editing/pasteboard/copy-paste-text-in-h1.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::nodeHasAttributesToPreserve): Extracted from isInlineNodeWithStyle.
(WebCore::isInlineNodeWithStyle): Calls nodeHasAttributesToPreserve.
(WebCore::ReplaceSelectionCommand::doApply): Calls ancestorToRetainStructureAndAppearance.
Remove nodes copied by ancestorToRetainStructureAndAppearance at insertionPos before pasting the fragment.
* editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearance): Takes ShouldIncludeParagraphSeparators.
* editing/markup.h:

LayoutTests: 

* editing/pasteboard/5065605-expected.txt:
* editing/pasteboard/copy-paste-text-in-h1-expected.txt: Added.
* editing/pasteboard/copy-paste-text-in-h1.html: Added.
* editing/pasteboard/display-block-on-spans-expected.txt:
* editing/pasteboard/paste-pre-001-expected.txt:
* editing/pasteboard/paste-pre-002-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/5065605-expected.txt
trunk/LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt
trunk/LayoutTests/editing/pasteboard/paste-pre-001-expected.txt
trunk/LayoutTests/editing/pasteboard/paste-pre-002-expected.txt
trunk/LayoutTests/editing/pasteboard/paste-text-011-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/editing/markup.h


Added Paths

trunk/LayoutTests/editing/pasteboard/copy-paste-text-in-h1-expected.txt
trunk/LayoutTests/editing/pasteboard/copy-paste-text-in-h1.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92329 => 92330)

--- trunk/LayoutTests/ChangeLog	2011-08-03 23:35:03 UTC (rev 92329)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 23:42:25 UTC (rev 92330)
@@ -1,3 +1,18 @@
+2011-08-03  Ryosuke Niwa  
+
+select-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the element inside itself
+https://bugs.webkit.org/show_bug.cgi?id=26483
+
+Reviewed by Enrica Casucci.
+
+* editing/pasteboard/5065605-expected.txt:
+* editing/pasteboard/copy-paste-text-in-h1-expected.txt: Added.
+* editing/pasteboard/copy-paste-text-in-h1.html: Added.
+* editing/pasteboard/display-block-on-spans-expected.txt:
+* editing/pasteboard/paste-pre-001-expected.txt:
+* editing/pasteboard/paste-pre-002-expected.txt:
+* editing/pasteboard/paste-text-011-expected.txt:
+
 2011-08-03  Mark Pilgrim  
 
 Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files


Modified: trunk/LayoutTests/editing/pasteboard/5065605-expected.txt (92329 => 92330)

--- trunk/LayoutTests/editing/pasteboard/5065605-expected.txt	2011-08-03 23:35:03 UTC (rev 92329)
+++ trunk/LayoutTests/editing/pasteboard/5065605-expected.txt	2011-08-03 23:42:25 UTC (rev 92330)
@@ -21,7 +21,7 @@
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 24 of #text > FONT > DIV > SPAN > FONT > DIV > DIV > BODY > HTML > #document to 24 of #text > FONT > DIV > SPAN > FONT > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 24 of #text > FONT > DIV > DIV > BODY > HTML > #document to 24 of #text > FONT > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
@@ -36,19 +36,12 @@
 | class="Apple-style-span"
 | color="#ff"
 | "This text should be red."
+| 
+|   class="Apple-style-span"
+|   color="#ff"
+|   "This text should be red."
 | 
 |   
 | class="Apple-style-span"
 | color="#ff"
-| 
-|   class="Apple-style-span"
-|  

[webkit-changes] [92329] trunk/Source/JavaScriptCore

[fpizlo]

Title: [92329] trunk/Source/_javascript_Core








Revision 92329
Author fpi...@apple.com
Date 2011-08-03 16:35:03 -0700 (Wed, 03 Aug 2011)


Log Message
JSC GC heap size improvement breaks build on some platforms due to
unused parameter
https://bugs.webkit.org/show_bug.cgi?id=65641

Reviewed by Darin Adler.

Fix build on non-x86 platforms, by ensuring that the relevant
parameter always appears to be used even when it isn't.

* heap/Heap.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92328 => 92329)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-03 23:31:50 UTC (rev 92328)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-03 23:35:03 UTC (rev 92329)
@@ -1,3 +1,16 @@
+2011-08-03  Filip Pizlo  
+
+JSC GC heap size improvement breaks build on some platforms due to
+unused parameter
+https://bugs.webkit.org/show_bug.cgi?id=65641
+
+Reviewed by Darin Adler.
+
+Fix build on non-x86 platforms, by ensuring that the relevant
+parameter always appears to be used even when it isn't.
+
+* heap/Heap.cpp:
+
 2011-08-03  Carlos Garcia Campos  
 
 [GTK] Reorganize pkg-config files


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (92328 => 92329)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2011-08-03 23:31:50 UTC (rev 92328)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2011-08-03 23:35:03 UTC (rev 92329)
@@ -42,14 +42,20 @@
 
 namespace { 
 
+static const size_t largeHeapSize = 16 * 1024 * 1024;
+static const size_t smallHeapSize = 512 * 1024;
+
 static size_t heapSizeForHint(HeapSize heapSize)
 {
 #if ENABLE(LARGE_HEAP)
 if (heapSize == LargeHeap)
-return 16 * 1024 * 1024;
+return largeHeapSize;
 ASSERT(heapSize == SmallHeap);
+return smallHeapSize;
+#else
+ASSERT_UNUSED(heapSize, heapSize == LargeHeap || heapSize == SmallHeap);
+return smallHeapSize;
 #endif
-return 512 * 1024;
 }
 
 static inline bool isValidSharedInstanceThreadState()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92328] trunk/Source/WebCore

[commit-queue]

Title: [92328] trunk/Source/WebCore








Revision 92328
Author commit-qu...@webkit.org
Date 2011-08-03 16:31:50 -0700 (Wed, 03 Aug 2011)


Log Message
Remove LegacyDefaultOptionalArguments flag from Console.idl
https://bugs.webkit.org/show_bug.cgi?id=65569

Patch by Mark Pilgrim  on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/Console.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Console.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (92327 => 92328)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 23:20:58 UTC (rev 92327)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 23:31:50 UTC (rev 92328)
@@ -1,5 +1,16 @@
 2011-08-03  Mark Pilgrim  
 
+Remove LegacyDefaultOptionalArguments flag from Console.idl
+https://bugs.webkit.org/show_bug.cgi?id=65569
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* page/Console.idl:
+
+2011-08-03  Mark Pilgrim  
+
 Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
 https://bugs.webkit.org/show_bug.cgi?id=65338
 


Modified: trunk/Source/WebCore/page/Console.idl (92327 => 92328)

--- trunk/Source/WebCore/page/Console.idl	2011-08-03 23:20:58 UTC (rev 92327)
+++ trunk/Source/WebCore/page/Console.idl	2011-08-03 23:31:50 UTC (rev 92328)
@@ -29,7 +29,6 @@
 module window {
 
 interface [
-LegacyDefaultOptionalArguments,
 GenerateIsReachable=ImplFrame,
 OmitConstructor
 ] Console {
@@ -52,7 +51,7 @@
 [Custom] void profileEnd(in DOMString title);
 #endif
 
-void time(in [ConvertUndefinedOrNullToNullString] DOMString title);
+void time(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString title);
 [CustomArgumentHandling] void timeEnd(in [ConvertUndefinedOrNullToNullString] DOMString title);
 [CustomArgumentHandling] void timeStamp();
 [CustomArgumentHandling] void group();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92327] trunk

[commit-queue]

Title: [92327] trunk








Revision 92327
Author commit-qu...@webkit.org
Date 2011-08-03 16:20:58 -0700 (Wed, 03 Aug 2011)


Log Message
Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
https://bugs.webkit.org/show_bug.cgi?id=65338

Patch by Mark Pilgrim  on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

* html/DOMFormData.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAudioElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDivElement.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLFieldSetElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLKeygenElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLOutputElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLVideoElement.idl:
* html/TimeRanges.idl:

LayoutTests:

* fast/files/create-blob-url-crash-expected.txt:
* fast/files/create-blob-url-crash.html:
* fast/files/revoke-blob-url-expected.txt:
* fast/files/revoke-blob-url.html:
* fast/forms/ValidityState-customError-expected.txt:
* fast/forms/ValidityState-customError.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt
trunk/LayoutTests/fast/files/create-blob-url-crash.html
trunk/LayoutTests/fast/files/revoke-blob-url-expected.txt
trunk/LayoutTests/fast/files/revoke-blob-url.html
trunk/LayoutTests/fast/forms/ValidityState-customError-expected.txt
trunk/LayoutTests/fast/forms/ValidityState-customError.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMFormData.idl
trunk/Source/WebCore/html/DOMTokenList.idl
trunk/Source/WebCore/html/DOMURL.idl
trunk/Source/WebCore/html/HTMLAllCollection.idl
trunk/Source/WebCore/html/HTMLAnchorElement.idl
trunk/Source/WebCore/html/HTMLAudioElement.idl
trunk/Source/WebCore/html/HTMLButtonElement.idl
trunk/Source/WebCore/html/HTMLCanvasElement.idl
trunk/Source/WebCore/html/HTMLCollection.idl
trunk/Source/WebCore/html/HTMLDivElement.idl
trunk/Source/WebCore/html/HTMLDocument.idl
trunk/Source/WebCore/html/HTMLElement.idl
trunk/Source/WebCore/html/HTMLFieldSetElement.idl
trunk/Source/WebCore/html/HTMLInputElement.idl
trunk/Source/WebCore/html/HTMLKeygenElement.idl
trunk/Source/WebCore/html/HTMLMediaElement.idl
trunk/Source/WebCore/html/HTMLObjectElement.idl
trunk/Source/WebCore/html/HTMLOptionsCollection.idl
trunk/Source/WebCore/html/HTMLOutputElement.idl
trunk/Source/WebCore/html/HTMLSelectElement.idl
trunk/Source/WebCore/html/HTMLTableElement.idl
trunk/Source/WebCore/html/HTMLTableRowElement.idl
trunk/Source/WebCore/html/HTMLTableSectionElement.idl
trunk/Source/WebCore/html/HTMLTextAreaElement.idl
trunk/Source/WebCore/html/HTMLVideoElement.idl
trunk/Source/WebCore/html/TimeRanges.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (92326 => 92327)

--- trunk/LayoutTests/ChangeLog	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 23:20:58 UTC (rev 92327)
@@ -1,5 +1,19 @@
 2011-08-03  Mark Pilgrim  
 
+Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65338
+
+Reviewed by Adam Barth.
+
+* fast/files/create-blob-url-crash-expected.txt:
+* fast/files/create-blob-url-crash.html:
+* fast/files/revoke-blob-url-expected.txt:
+* fast/files/revoke-blob-url.html:
+* fast/forms/ValidityState-customError-expected.txt:
+* fast/forms/ValidityState-customError.html:
+
+2011-08-03  Mark Pilgrim  
+
 Remove LegacyDefaultOptionalArguments flag from navigator IDL files
 https://bugs.webkit.org/show_bug.cgi?id=65370
 


Modified: trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt (92326 => 92327)

--- trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt	2011-08-03 23:20:58 UTC (rev 92327)
@@ -1,4 +1,4 @@
-Test that createObjectURL with no argument should not cause crash.
-PASS
+Test that createObjectURL with no argument should throw an exception.
+PASS: Not enough arguments
 DONE
 


Modified: trunk/LayoutTests/fast/files/create-blob-url-crash.html (92326 => 92327)

--- trunk/LayoutTests/fast/files/create-blob-url-crash.html	2011-08-03 23:19:41 UTC (rev 92326)
+++ trunk/LayoutTests/fast/files/create-blob-url-crash.html	2011-08-03 23:20:58 UTC (rev 92327)
@@ -9,9 +9,13 @@
 
 function test()
 {
-log("Test that createObjectURL with no argument should not cause crash.");
-var url = ""
-log(url == undefined ? "PASS" : "FAIL");
+log("Test that createObjectURL with no argument should throw an exception.");
+try {
+var url = ""
+log("FAI

[webkit-changes] [92326] trunk/Tools

[fpizlo]

Title: [92326] trunk/Tools








Revision 92326
Author fpi...@apple.com
Date 2011-08-03 16:19:41 -0700 (Wed, 03 Aug 2011)


Log Message
Adding Filip Pizlo to committer list.

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (92325 => 92326)

--- trunk/Tools/ChangeLog	2011-08-03 23:18:42 UTC (rev 92325)
+++ trunk/Tools/ChangeLog	2011-08-03 23:19:41 UTC (rev 92326)
@@ -1,3 +1,11 @@
+2011-08-03  Filip Pizlo  
+
+Adding Filip Pizlo to committer list.
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2011-08-03  Dimitri Glazkov  
 
 Add "optimize-expectations" command to webkit-patch.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (92325 => 92326)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-08-03 23:18:42 UTC (rev 92325)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-08-03 23:19:41 UTC (rev 92326)
@@ -153,6 +153,7 @@
 Committer("Evan Stade", "est...@chromium.org", "estade"),
 Committer("Fady Samuel", "fsam...@chromium.org", "fsamuel"),
 Committer("Feng Qian", "f...@chromium.org"),
+Committer("Filip Pizlo", "fpi...@apple.com"),
 Committer("Fumitoshi Ukai", "u...@chromium.org", "ukai"),
 Committer("Gabor Loki", "l...@webkit.org", "loki04"),
 Committer("Gabor Rapcsanyi", ["rga...@webkit.org", "rga...@inf.u-szeged.hu"], "rgabor"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92325] trunk/Source/WebCore

[jpfau]

Title: [92325] trunk/Source/WebCore








Revision 92325
Author jp...@apple.com
Date 2011-08-03 16:18:42 -0700 (Wed, 03 Aug 2011)


Log Message
Make atomic XML token
https://bugs.webkit.org/show_bug.cgi?id=65639

Reviewed by Adam Barth.

Create a shared AtomicMarkupTokenBase that is shared by AtomicHTMLToken and the new AtomicXMLToken

* html/parser/HTMLToken.h:
(WebCore::HTMLToken::setForceQuirks):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::forceQuirks):
* html/parser/HTMLTokenizer.cpp:
(WebCorenameForAttribute):
(WebCoreusesName):
(WebCoreusesAttributes):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::type):
(WebCore::AtomicMarkupTokenBase::name):
(WebCore::AtomicMarkupTokenBase::setName):
(WebCore::AtomicMarkupTokenBase::selfClosing):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAtributes):
(WebCore::AtomicMarkupTokenBase::characters):
(WebCore::AtomicMarkupTokenBase::comment):
(WebCore::AtomicMarkupTokenBase::publicIdentifier):
(WebCore::AtomicMarkupTokenBase::systemIdentifier):
(WebCoreinitializeAttributes):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
(WebCore::AtomicXMLToken::prefix):
(WebCore::AtomicXMLToken::target):
(WebCore::AtomicXMLToken::data):
(WebCore::AtomicXMLToken::xmlVersion):
(WebCore::AtomicXMLToken::xmlStandalone):
* xml/parser/XMLTokenizer.cpp:
(WebCorenameForAttribute):
(WebCoreusesName):
(WebCoreusesAttributes):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLToken.h
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
trunk/Source/WebCore/xml/parser/MarkupTokenBase.h
trunk/Source/WebCore/xml/parser/XMLToken.h
trunk/Source/WebCore/xml/parser/XMLTokenizer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92324 => 92325)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 23:03:32 UTC (rev 92324)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 23:18:42 UTC (rev 92325)
@@ -1,3 +1,46 @@
+2011-08-03  Jeffrey Pfau  
+
+Make atomic XML token
+https://bugs.webkit.org/show_bug.cgi?id=65639
+
+Reviewed by Adam Barth.
+
+Create a shared AtomicMarkupTokenBase that is shared by AtomicHTMLToken and the new AtomicXMLToken
+
+* html/parser/HTMLToken.h:
+(WebCore::HTMLToken::setForceQuirks):
+(WebCore::AtomicHTMLToken::AtomicHTMLToken):
+(WebCore::AtomicHTMLToken::forceQuirks):
+* html/parser/HTMLTokenizer.cpp:
+(WebCorenameForAttribute):
+(WebCoreusesName):
+(WebCoreusesAttributes):
+* xml/parser/MarkupTokenBase.h:
+(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
+(WebCore::AtomicMarkupTokenBase::type):
+(WebCore::AtomicMarkupTokenBase::name):
+(WebCore::AtomicMarkupTokenBase::setName):
+(WebCore::AtomicMarkupTokenBase::selfClosing):
+(WebCore::AtomicMarkupTokenBase::getAttributeItem):
+(WebCore::AtomicMarkupTokenBase::attributes):
+(WebCore::AtomicMarkupTokenBase::takeAtributes):
+(WebCore::AtomicMarkupTokenBase::characters):
+(WebCore::AtomicMarkupTokenBase::comment):
+(WebCore::AtomicMarkupTokenBase::publicIdentifier):
+(WebCore::AtomicMarkupTokenBase::systemIdentifier):
+(WebCoreinitializeAttributes):
+* xml/parser/XMLToken.h:
+(WebCore::AtomicXMLToken::AtomicXMLToken):
+(WebCore::AtomicXMLToken::prefix):
+(WebCore::AtomicXMLToken::target):
+(WebCore::AtomicXMLToken::data):
+(WebCore::AtomicXMLToken::xmlVersion):
+(WebCore::AtomicXMLToken::xmlStandalone):
+* xml/parser/XMLTokenizer.cpp:
+(WebCorenameForAttribute):
+(WebCoreusesName):
+(WebCoreusesAttributes):
+
 2011-08-03  Mark Pilgrim  
 
 Remove LegacyDefaultOptionalArguments flag from geolocation IDL files


Modified: trunk/Source/WebCore/html/parser/HTMLToken.h (92324 => 92325)

--- trunk/Source/WebCore/html/parser/HTMLToken.h	2011-08-03 23:03:32 UTC (rev 92324)
+++ trunk/Source/WebCore/html/parser/HTMLToken.h	2011-08-03 23:18:42 UTC (rev 92325)
@@ -80,191 +80,25 @@
 ASSERT(m_type == HTMLTokenTypes::DOCTYPE);
 m_doctypeData->m_forceQuirks = true;
 }
-
 };
 
-// FIXME: This class should eventually be named HTMLToken once we move the
-// exiting HTMLToken to be internal to the HTMLTokenizer.
-class AtomicHTMLToken {
+class AtomicHTMLToken : public AtomicMarkupTokenBase {
 WTF_MAKE_NONCOPYABLE(AtomicHTMLToken);
 public:
-AtomicHTMLToken(HTMLToken& token)
-: m_type(token.type())
-{
-switch (m_type) {
-case HTMLTokenTypes::Uninitialized:
-ASSERT_NOT_REACHED();
-break;
-case HTMLTokenTypes::DOCTYPE:
-m_name = AtomicString(token.name().

[webkit-changes] [92324] trunk/Tools

[dglazkov]

Title: [92324] trunk/Tools








Revision 92324
Author dglaz...@chromium.org
Date 2011-08-03 16:03:32 -0700 (Wed, 03 Aug 2011)


Log Message
Add "optimize-expectations" command to webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=65633

For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/__init__.py: Added command.
* Scripts/webkitpy/tool/commands/expectations.py: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py


Added Paths

trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py




Diff

Modified: trunk/Tools/ChangeLog (92323 => 92324)

--- trunk/Tools/ChangeLog	2011-08-03 23:01:45 UTC (rev 92323)
+++ trunk/Tools/ChangeLog	2011-08-03 23:03:32 UTC (rev 92324)
@@ -1,5 +1,17 @@
 2011-08-03  Dimitri Glazkov  
 
+Add "optimize-expectations" command to webkit-patch.
+https://bugs.webkit.org/show_bug.cgi?id=65633
+
+For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/tool/commands/__init__.py: Added command.
+* Scripts/webkitpy/tool/commands/expectations.py: Added.
+
+2011-08-03  Dimitri Glazkov  
+
 Allow multiple bug identifiers in test expectations.
 https://bugs.webkit.org/show_bug.cgi?id=65642
 


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py (92323 => 92324)

--- trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py	2011-08-03 23:01:45 UTC (rev 92323)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/__init__.py	2011-08-03 23:03:32 UTC (rev 92324)
@@ -4,6 +4,7 @@
 from webkitpy.tool.commands.bugsearch import BugSearch
 from webkitpy.tool.commands.download import *
 from webkitpy.tool.commands.earlywarningsystem import *
+from webkitpy.tool.commands.expectations import OptimizeExpectations
 from webkitpy.tool.commands.gardenomatic import GardenOMatic
 from webkitpy.tool.commands.openbugs import OpenBugs
 from webkitpy.tool.commands.prettydiff import PrettyDiff


Added: trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py (0 => 92324)

--- trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py	2011-08-03 23:03:32 UTC (rev 92324)
@@ -0,0 +1,46 @@
+# Copyright (c) 2011 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+from webkitpy.layout_tests.models.test_configuration import TestConfigurationConverter
+from webkitpy.layout_tests.models.test_expectations import TestExpectationParser, TestExpectationSerializer
+from webkitpy.layout_tests.port import factory
+from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand
+
+
+class OptimizeExpectations(AbstractDeclarativeCommand):
+name = "optimize-expectations"
+help_text = "Fixes simple style issues in test_expectations file.  (Currently works only for chromium port.)"
+
+def execute(self, options, args, tool):
+port = factory.get("chromium-win-win7")  # FIXME: This should be selectable.
+expectation_lines = TestExpectationParser.tokenize_list(port.test_expectations())
+parser = TestExpectationParser(port, port.tests(["."]), allow_rebaseline_modifier=False)
+for expectation_line in expectation_lines:
+parser.parse(expectation_line)
+converter = TestConfigurationConverter(port.all_test_configuration

[webkit-changes] [92323] trunk/Source/WebCore

[commit-queue]

Title: [92323] trunk/Source/WebCore








Revision 92323
Author commit-qu...@webkit.org
Date 2011-08-03 16:01:45 -0700 (Wed, 03 Aug 2011)


Log Message
Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
https://bugs.webkit.org/show_bug.cgi?id=65355

Patch by Mark Pilgrim  on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/Geolocation.idl:
* page/PositionCallback.idl:
* page/PositionErrorCallback.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Geolocation.idl
trunk/Source/WebCore/page/PositionCallback.idl
trunk/Source/WebCore/page/PositionErrorCallback.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (92322 => 92323)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 22:59:33 UTC (rev 92322)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 23:01:45 UTC (rev 92323)
@@ -1,5 +1,18 @@
 2011-08-03  Mark Pilgrim  
 
+Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65355
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* page/Geolocation.idl:
+* page/PositionCallback.idl:
+* page/PositionErrorCallback.idl:
+
+2011-08-03  Mark Pilgrim  
+
 Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
 https://bugs.webkit.org/show_bug.cgi?id=65566
 


Modified: trunk/Source/WebCore/page/Geolocation.idl (92322 => 92323)

--- trunk/Source/WebCore/page/Geolocation.idl	2011-08-03 22:59:33 UTC (rev 92322)
+++ trunk/Source/WebCore/page/Geolocation.idl	2011-08-03 23:01:45 UTC (rev 92323)
@@ -27,13 +27,16 @@
 
 interface [
 Conditional=GEOLOCATION, 
-LegacyDefaultOptionalArguments,
 GenerateIsReachable=ImplFrame,
 OmitConstructor
 ] Geolocation {
-[Custom] void getCurrentPosition(in PositionCallback successCallback, in PositionErrorCallback errorCallback, in PositionOptions options);
+[Custom] void getCurrentPosition(in PositionCallback successCallback, 
+ in [Optional=CallWithDefaultValue] PositionErrorCallback errorCallback, 
+ in [Optional=CallWithDefaultValue] PositionOptions options);
 
-[Custom] long watchPosition(in PositionCallback successCallback, in PositionErrorCallback errorCallback, in PositionOptions options);
+[Custom] long watchPosition(in PositionCallback successCallback, 
+in [Optional=CallWithDefaultValue] PositionErrorCallback errorCallback, 
+in [Optional=CallWithDefaultValue] PositionOptions options);
 
 void clearWatch(in long watchId);
 };


Modified: trunk/Source/WebCore/page/PositionCallback.idl (92322 => 92323)

--- trunk/Source/WebCore/page/PositionCallback.idl	2011-08-03 22:59:33 UTC (rev 92322)
+++ trunk/Source/WebCore/page/PositionCallback.idl	2011-08-03 23:01:45 UTC (rev 92323)
@@ -24,7 +24,6 @@
 
 module core {
 interface [
-LegacyDefaultOptionalArguments,
 Conditional=GEOLOCATION,
 Callback=FunctionOnly
 ] PositionCallback {


Modified: trunk/Source/WebCore/page/PositionErrorCallback.idl (92322 => 92323)

--- trunk/Source/WebCore/page/PositionErrorCallback.idl	2011-08-03 22:59:33 UTC (rev 92322)
+++ trunk/Source/WebCore/page/PositionErrorCallback.idl	2011-08-03 23:01:45 UTC (rev 92323)
@@ -25,7 +25,6 @@
 module core {
 interface [
 Conditional=GEOLOCATION,
-LegacyDefaultOptionalArguments,
 Callback=FunctionOnly
 ] PositionErrorCallback {
 boolean handleEvent(in PositionError error);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92321] trunk/Source/WebCore

[commit-queue]

Title: [92321] trunk/Source/WebCore








Revision 92321
Author commit-qu...@webkit.org
Date 2011-08-03 15:50:20 -0700 (Wed, 03 Aug 2011)


Log Message
Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
https://bugs.webkit.org/show_bug.cgi?id=65566

Patch by Mark Pilgrim  on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/DOMSelection.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMSelection.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (92320 => 92321)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 22:47:37 UTC (rev 92320)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 22:50:20 UTC (rev 92321)
@@ -1,5 +1,16 @@
 2011-08-03  Mark Pilgrim  
 
+Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
+https://bugs.webkit.org/show_bug.cgi?id=65566
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* page/DOMSelection.idl:
+
+2011-08-03  Mark Pilgrim  
+
 Remove LegacyDefaultOptionalArguments flag from Location.idl
 https://bugs.webkit.org/show_bug.cgi?id=65565
 


Modified: trunk/Source/WebCore/page/DOMSelection.idl (92320 => 92321)

--- trunk/Source/WebCore/page/DOMSelection.idl	2011-08-03 22:47:37 UTC (rev 92320)
+++ trunk/Source/WebCore/page/DOMSelection.idl	2011-08-03 22:50:20 UTC (rev 92321)
@@ -32,7 +32,6 @@
 // This is based off of Mozilla's Selection interface
 // https://developer.mozilla.org/En/DOM/Selection
 interface [
-LegacyDefaultOptionalArguments,
 GenerateIsReachable=ImplFrame,
 OmitConstructor
 ] DOMSelection {
@@ -44,7 +43,8 @@
 readonly attribute boolean isCollapsed;
 readonly attribute long rangeCount;
 
-void collapse(in Node node, in long index)
+void collapse(in [Optional=CallWithDefaultValue] Node node, 
+  in [Optional=CallWithDefaultValue] long index)
 raises(DOMException);
 void collapseToEnd()
 raises(DOMException);
@@ -52,17 +52,19 @@
 raises(DOMException);
 
 void deleteFromDocument();
-boolean containsNode(in Node node, in boolean allowPartial);
-void selectAllChildren(in Node node)
+boolean containsNode(in [Optional=CallWithDefaultValue] Node node, 
+ in [Optional=CallWithDefaultValue] boolean allowPartial);
+void selectAllChildren(in [Optional=CallWithDefaultValue] Node node)
 raises(DOMException);
 
-void extend(in Node node, in long offset)
+void extend(in [Optional=CallWithDefaultValue] Node node, 
+in [Optional=CallWithDefaultValue] long offset)
 raises(DOMException);
 
-Range getRangeAt(in long index)
+Range getRangeAt(in [Optional=CallWithDefaultValue] long index)
 raises(DOMException);
 void removeAllRanges();
-void addRange(in Range range);
+void addRange(in [Optional=CallWithDefaultValue] Range range);
 
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
 [DontEnum] DOMString toString();
@@ -78,10 +80,16 @@
 // IE's type accessor returns "none", "text" and "control"
 readonly attribute DOMString type;
 
-void modify(in DOMString alter, in DOMString direction, in DOMString granularity);
-void setBaseAndExtent(in Node baseNode, in long baseOffset, in Node extentNode, in long extentOffset)
+void modify(in [Optional=CallWithDefaultValue] DOMString alter, 
+in [Optional=CallWithDefaultValue] DOMString direction, 
+in [Optional=CallWithDefaultValue] DOMString granularity);
+void setBaseAndExtent(in [Optional=CallWithDefaultValue] Node baseNode, 
+  in [Optional=CallWithDefaultValue] long baseOffset, 
+  in [Optional=CallWithDefaultValue] Node extentNode, 
+  in [Optional=CallWithDefaultValue] long extentOffset)
 raises(DOMException);
-void setPosition(in Node node, in long offset)
+void setPosition(in [Optional=CallWithDefaultValue] Node node, 
+ in [Optional=CallWithDefaultValue] long offset)
 raises(DOMException);
 
 // IE extentions






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92320] trunk/Source/WebCore

[commit-queue]

Title: [92320] trunk/Source/WebCore








Revision 92320
Author commit-qu...@webkit.org
Date 2011-08-03 15:47:37 -0700 (Wed, 03 Aug 2011)


Log Message
Remove LegacyDefaultOptionalArguments flag from Location.idl
https://bugs.webkit.org/show_bug.cgi?id=65565

Patch by Mark Pilgrim  on 2011-08-03
Reviewed by Darin Adler.

No new tests, all existing tests pass.

* page/Location.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Location.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (92319 => 92320)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 22:42:46 UTC (rev 92319)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 22:47:37 UTC (rev 92320)
@@ -1,3 +1,14 @@
+2011-08-03  Mark Pilgrim  
+
+Remove LegacyDefaultOptionalArguments flag from Location.idl
+https://bugs.webkit.org/show_bug.cgi?id=65565
+
+Reviewed by Darin Adler.
+
+No new tests, all existing tests pass.
+
+* page/Location.idl:
+
 2011-08-03  Sailesh Agrawal  
 
 Chromium Mac: Fix position of search tickmarks


Modified: trunk/Source/WebCore/page/Location.idl (92319 => 92320)

--- trunk/Source/WebCore/page/Location.idl	2011-08-03 22:42:46 UTC (rev 92319)
+++ trunk/Source/WebCore/page/Location.idl	2011-08-03 22:47:37 UTC (rev 92320)
@@ -29,7 +29,6 @@
 module window {
 
 interface [
-LegacyDefaultOptionalArguments,
 #if defined(V8_BINDING) && V8_BINDING
 CheckDomainSecurity,
 #endif
@@ -47,8 +46,8 @@
  attribute [DoNotCheckDomainSecurityOnSet, CustomSetter, V8DisallowShadowing] DOMString href;
 #endif
 
-[Custom, V8OnInstance] void assign(in DOMString url);
-[Custom, V8OnInstance] void replace(in DOMString url);
+[Custom, V8OnInstance] void assign(in [Optional=CallWithDefaultValue] DOMString url);
+[Custom, V8OnInstance] void replace(in [Optional=CallWithDefaultValue] DOMString url);
 [Custom, V8OnInstance] void reload();
 
 // URI decomposition attributes






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92319] trunk/Source/WebCore

[commit-queue]

Title: [92319] trunk/Source/WebCore








Revision 92319
Author commit-qu...@webkit.org
Date 2011-08-03 15:42:46 -0700 (Wed, 03 Aug 2011)


Log Message
Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575

This change adjusts the position of search tickmarks so that they are correctly centered.

Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

Patch by Sailesh Agrawal  on 2011-08-03
Reviewed by James Robinson.

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (92318 => 92319)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 22:36:35 UTC (rev 92318)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 22:42:46 UTC (rev 92319)
@@ -1,5 +1,19 @@
 2011-08-03  Sailesh Agrawal  
 
+Chromium Mac: Fix position of search tickmarks
+https://bugs.webkit.org/show_bug.cgi?id=65575
+
+This change adjusts the position of search tickmarks so that they are correctly centered.
+
+Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.
+
+Reviewed by James Robinson.
+
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::ScrollbarThemeChromiumMac::paint):
+
+2011-08-03  Sailesh Agrawal  
+
 Chromium Mac: Make sure scrollbars flash when web page loads
 https://bugs.webkit.org/show_bug.cgi?id=65586
 


Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm (92318 => 92319)

--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm	2011-08-03 22:36:35 UTC (rev 92318)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm	2011-08-03 22:42:46 UTC (rev 92319)
@@ -491,9 +491,15 @@
  scrollbar->frameRect());
 
 IntRect tickmarkTrackRect(IntPoint(), trackRect(scrollbar, false).size());
-// Inset by 2 on the left and 3 on the right.
-tickmarkTrackRect.setX(tickmarkTrackRect.x() + 2);
-tickmarkTrackRect.setWidth(tickmarkTrackRect.width() - 3);
+if (tickmarkTrackRect.width() <= 10) {
+// For narrow scrollbars inset by 1 on the left and 3 on the right.
+tickmarkTrackRect.setX(tickmarkTrackRect.x() + 1);
+tickmarkTrackRect.setWidth(tickmarkTrackRect.width() - 4);
+} else {
+// For wide scrollbars inset by 2 on the left and 3 on the right.
+tickmarkTrackRect.setX(tickmarkTrackRect.x() + 2);
+tickmarkTrackRect.setWidth(tickmarkTrackRect.width() - 5);
+}
 paintTickmarks(context, scrollbar, tickmarkTrackRect);
 
 wkScrollbarPainterPaintKnob(scrollbarPainter);
@@ -566,7 +572,7 @@
 tickmarkTrackRect.inflateY(-tickmarkTrackRect.width());
 // Inset by 2 on the left and 3 on the right.
 tickmarkTrackRect.setX(tickmarkTrackRect.x() + 2);
-tickmarkTrackRect.setWidth(tickmarkTrackRect.width() - 3);
+tickmarkTrackRect.setWidth(tickmarkTrackRect.width() - 5);
 paintTickmarks(drawingContext, scrollbar, tickmarkTrackRect);
 
 if (hasThumb(scrollbar)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92318] trunk/Source/WebKit/chromium

[michaeln]

Title: [92318] trunk/Source/WebKit/chromium








Revision 92318
Author micha...@google.com
Date 2011-08-03 15:36:35 -0700 (Wed, 03 Aug 2011)


Log Message
[Chromium] Minor cleanup, remove a deprecated method.
The old WebDatabase::updateDatabaseSize method has been replaced with
updateDatabaseSize, updateSpaceAvailable, and resetSpaceAvailable.
https://bugs.webkit.org/show_bug.cgi?id=65553

Reviewed by Adam Barth.

* public/WebDatabase.h:
* src/WebDatabase.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDatabase.h
trunk/Source/WebKit/chromium/src/WebDatabase.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (92317 => 92318)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-03 22:34:28 UTC (rev 92317)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-03 22:36:35 UTC (rev 92318)
@@ -1,3 +1,15 @@
+2011-08-03  Michael Nordman  
+
+[Chromium] Minor cleanup, remove a deprecated method.
+The old WebDatabase::updateDatabaseSize method has been replaced with 
+updateDatabaseSize, updateSpaceAvailable, and resetSpaceAvailable.
+https://bugs.webkit.org/show_bug.cgi?id=65553
+
+Reviewed by Adam Barth.
+
+* public/WebDatabase.h:
+* src/WebDatabase.cpp:
+
 2011-08-03  Pavel Feldman  
 
 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.


Modified: trunk/Source/WebKit/chromium/public/WebDatabase.h (92317 => 92318)

--- trunk/Source/WebKit/chromium/public/WebDatabase.h	2011-08-03 22:34:28 UTC (rev 92317)
+++ trunk/Source/WebKit/chromium/public/WebDatabase.h	2011-08-03 22:36:35 UTC (rev 92318)
@@ -61,11 +61,6 @@
 WEBKIT_API static void closeDatabaseImmediately(
 const WebString& originIdentifier, const WebString& databaseName);
 
-// DEPRECATED - to be removed soon
-WEBKIT_API static void updateDatabaseSize(
-const WebString& originIdentifier, const WebString& databaseName,
-long long databaseSize, long long spaceAvailable);
-
 #if WEBKIT_IMPLEMENTATION
 WebDatabase(const WebCore::AbstractDatabase*);
 #endif


Modified: trunk/Source/WebKit/chromium/src/WebDatabase.cpp (92317 => 92318)

--- trunk/Source/WebKit/chromium/src/WebDatabase.cpp	2011-08-03 22:34:28 UTC (rev 92317)
+++ trunk/Source/WebKit/chromium/src/WebDatabase.cpp	2011-08-03 22:36:35 UTC (rev 92318)
@@ -113,17 +113,6 @@
 #endif
 }
 
-// FIXME: This is deprecated, delete after rolling DEPs and chrome is using the new methods.
-void WebDatabase::updateDatabaseSize(
-const WebString& originIdentifier, const WebString& databaseName,
-long long databaseSize, long long spaceAvailable)
-{
-#if ENABLE(DATABASE)
-updateDatabaseSize(originIdentifier, databaseName, databaseSize);
-updateSpaceAvailable(originIdentifier, spaceAvailable);
-#endif
-}
-
 void WebDatabase::closeDatabaseImmediately(const WebString& originIdentifier, const WebString& databaseName)
 {
 #if ENABLE(DATABASE)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92317] trunk/Tools

[dglazkov]

Title: [92317] trunk/Tools








Revision 92317
Author dglaz...@chromium.org
Date 2011-08-03 15:34:28 -0700 (Wed, 03 Aug 2011)


Log Message
Allow multiple bug identifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65642

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (92316 => 92317)

--- trunk/Tools/ChangeLog	2011-08-03 22:24:13 UTC (rev 92316)
+++ trunk/Tools/ChangeLog	2011-08-03 22:34:28 UTC (rev 92317)
@@ -1,5 +1,15 @@
 2011-08-03  Dimitri Glazkov  
 
+Allow multiple bug identifiers in test expectations.
+https://bugs.webkit.org/show_bug.cgi?id=65642
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
+* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
+
+2011-08-03  Dimitri Glazkov  
+
 Teach BuilderToPort to distinguish between Release and Debug builders.
 https://bugs.webkit.org/show_bug.cgi?id=65628
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (92316 => 92317)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2011-08-03 22:24:13 UTC (rev 92316)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2011-08-03 22:34:28 UTC (rev 92317)
@@ -132,7 +132,7 @@
 if expectation_line.name is None:
 return '' if expectation_line.comment is None else "//%s" % expectation_line.comment
 
-if expectation_line.parsed_bug_modifier:
+if expectation_line.parsed_bug_modifiers:
 specifiers_list = self._test_configuration_converter.to_specifiers_list(expectation_line.matching_configurations)
 result = []
 for specifiers in specifiers_list:
@@ -152,9 +152,9 @@
 
 def _parsed_modifier_string(self, expectation_line, specifiers):
 result = []
-if expectation_line.parsed_bug_modifier:
-result.append(expectation_line.parsed_bug_modifier)
-result.extend(expectation_line.parsed_modifiers)
+if expectation_line.parsed_bug_modifiers:
+result.extend(sorted(expectation_line.parsed_bug_modifiers))
+result.extend(sorted(expectation_line.parsed_modifiers))
 result.extend(self._test_configuration_converter.specifier_sorter().sort_specifiers(specifiers))
 return ' '.join(result)
 
@@ -215,11 +215,11 @@
 if re.match(self.BUG_MODIFIER_REGEX, modifier):
 expectation_line.errors.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.')
 else:
-expectation_line.parsed_bug_modifier = modifier
+expectation_line.parsed_bug_modifiers.append(modifier)
 else:
 parsed_specifiers.add(modifier)
 
-if not expectation_line.parsed_bug_modifier and not has_wontfix:
+if not expectation_line.parsed_bug_modifiers and not has_wontfix:
 expectation_line.warnings.append('Test lacks BUG modifier.')
 
 if self._allow_rebaseline_modifier and self.REBASELINE_MODIFIER in expectation_line.modifiers:
@@ -344,7 +344,7 @@
 self.path = None
 self.modifiers = []
 self.parsed_modifiers = []
-self.parsed_bug_modifier = None
+self.parsed_bug_modifiers = []
 self.matching_configurations = set()
 self.expectations = []
 self.parsed_expectations = set()
@@ -581,7 +581,7 @@
 
 class BugManager(object):
 """A simple interface for managing bugs from TestExpectationsEditor."""
-def close_bug(self, bug_id, reference_bug_id=None):
+def close_bug(self, bug_ids, reference_bug_ids=None):
 raise NotImplementedError("BugManager.close_bug")
 
 def create_bug(self):
@@ -631,31 +631,31 @@
 if (not expectation_line.is_flaky() or remove_flakes) and expectation_line.matching_configurations & test_config_set:
 expectation_line.matching_configurations = expectation_line.matching_configurations - test_config_set
 if not expectation_line.matching_configurations:
-self._bug_manager.close_bug(expectation_line.parsed_bug_modifier)
+self._bug_manager.close_bug(expectation_line.parsed_bug_modifiers)
 return
 
-def update_expectation(self, test, test_config_set, expectation_set, parsed_bug_modifier=None):
+def update_expectation(self, test, test_config_set, expectation_set, parsed_bug_modifiers=None):
 "

[webkit-changes] [92316] trunk/Source/WebCore

[commit-queue]

Title: [92316] trunk/Source/WebCore








Revision 92316
Author commit-qu...@webkit.org
Date 2011-08-03 15:24:13 -0700 (Wed, 03 Aug 2011)


Log Message
Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586

On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.

Patch by Sailesh Agrawal  on 2011-08-03
Reviewed by James Robinson.

* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (92315 => 92316)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 21:58:44 UTC (rev 92315)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 22:24:13 UTC (rev 92316)
@@ -1,3 +1,15 @@
+2011-08-03  Sailesh Agrawal  
+
+Chromium Mac: Make sure scrollbars flash when web page loads
+https://bugs.webkit.org/show_bug.cgi?id=65586
+
+On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.
+
+Reviewed by James Robinson.
+
+* platform/chromium/ScrollAnimatorChromiumMac.mm:
+(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
+
 2011-08-03  Mark Pilgrim  
 
 Remove LegacyDefaultOptionalArguments flag from navigator IDL files


Modified: trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm (92315 => 92316)

--- trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm	2011-08-03 21:58:44 UTC (rev 92315)
+++ trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm	2011-08-03 22:24:13 UTC (rev 92316)
@@ -1289,7 +1289,10 @@
 
 void ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired(Timer*)
 {
-wkScrollbarPainterForceFlashScrollers(m_scrollbarPainterController.get());
+if (scrollableArea()->shouldSuspendScrollAnimations())
+startScrollbarPaintTimer();
+else
+wkScrollbarPainterForceFlashScrollers(m_scrollbarPainterController.get());
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92315] trunk

[commit-queue]

Title: [92315] trunk








Revision 92315
Author commit-qu...@webkit.org
Date 2011-08-03 14:58:44 -0700 (Wed, 03 Aug 2011)


Log Message
Remove LegacyDefaultOptionalArguments flag from navigator IDL files
https://bugs.webkit.org/show_bug.cgi?id=65370

Patch by Mark Pilgrim  on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

* page/Navigator.idl:
* page/NavigatorUserMediaErrorCallback.idl:
* page/NavigatorUserMediaSuccessCallback.idl:

LayoutTests:

* fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt
trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Navigator.idl
trunk/Source/WebCore/page/NavigatorUserMediaErrorCallback.idl
trunk/Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (92314 => 92315)

--- trunk/LayoutTests/ChangeLog	2011-08-03 21:53:16 UTC (rev 92314)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 21:58:44 UTC (rev 92315)
@@ -1,3 +1,13 @@
+2011-08-03  Mark Pilgrim  
+
+Remove LegacyDefaultOptionalArguments flag from navigator IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65370
+
+Reviewed by Adam Barth.
+
+* fast/dom/navigator-detached-no-crash-expected.txt:
+* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
+
 2011-08-03  Zhenyao Mo  
 
 Unreviewed, fix an error in test_expectations.txt.


Modified: trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt (92314 => 92315)

--- trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt	2011-08-03 21:53:16 UTC (rev 92314)
+++ trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt	2011-08-03 21:58:44 UTC (rev 92315)
@@ -13,6 +13,7 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
+navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
@@ -29,6 +30,7 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
+navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK


Modified: trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt (92314 => 92315)

--- trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt	2011-08-03 21:53:16 UTC (rev 92314)
+++ trunk/LayoutTests/platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt	2011-08-03 21:58:44 UTC (rev 92315)
@@ -13,7 +13,7 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() is OK
+navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
@@ -30,7 +30,7 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() is OK
+navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK


Modified: trunk/Source/WebCore/ChangeLog (92314 => 92315)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 21:53:16 UTC (rev 92314)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 21:58:44 UTC (rev 92315)
@@ -1,3 +1,14 @@
+2011-08-03  Mark Pilgrim  
+
+Remove LegacyDefaultOptionalArguments flag from navigator IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65370
+
+Reviewed by Adam Barth.
+
+* page/Navigator.idl:
+* page/NavigatorUserMediaErrorCallback.idl:
+* page/NavigatorUserMediaSuccessCallback.idl:
+
 2011-08-03  Anders Carlsson  
 
 webarchive/loading/missing-data.html is failing on Mac


Modified: trunk/Source/WebCore/page/Navigator.idl (92314 => 92315)

--- trunk/Source/WebCore/page/Navigator.idl	2011-08-03 21:53:16 UTC (rev 92314)
+++ trunk/Source/WebCore/page/Navigator.idl	2011-08-03 21:58:44 UTC (rev 92315)
@@ -20,7 +20,6 @@
 module window {
 
 interface [
-LegacyDefaultOptionalArguments,
 GenerateIsReachable=ImplFrame,
 OmitConstructor
 ] Navigator {


Modified: trunk/Source/WebCore/page/NavigatorUserMediaErrorCallback.idl (92314 => 92315)

--- trunk/Source/WebCore/page/NavigatorUserMediaErrorCallback.idl	2011-08-03 21:53:16 UTC (rev 92314)
+++ trunk/Source/WebCore/page/NavigatorUserMediaErrorCallback.idl	2011-08-03 21:58:44 UTC (rev 92315)
@@ -24,7 +24,6 @@
 
 module window {
 interface [
-LegacyDefaultOptionalArguments,
 Conditional=MEDIA_STREAM,
 Callback=FunctionOnly
 ] NavigatorUserMediaErrorCallback {


Modified: trunk/Source/

[webkit-changes] [92314] trunk/Source/WebCore

[andersca]

Title: [92314] trunk/Source/WebCore








Revision 92314
Author ander...@apple.com
Date 2011-08-03 14:53:16 -0700 (Wed, 03 Aug 2011)


Log Message
webarchive/loading/missing-data.html is failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=63507

Reviewed by Adam Barth.

When loading a main resource from a web archive, make sure that the working URL is actually
the URL of the resource, and not the URL of the web archive itself.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92313 => 92314)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 21:50:48 UTC (rev 92313)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 21:53:16 UTC (rev 92314)
@@ -1,3 +1,16 @@
+2011-08-03  Anders Carlsson  
+
+webarchive/loading/missing-data.html is failing on Mac
+https://bugs.webkit.org/show_bug.cgi?id=63507
+
+Reviewed by Adam Barth.
+
+When loading a main resource from a web archive, make sure that the working URL is actually
+the URL of the resource, and not the URL of the web archive itself.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::receivedFirstData):
+
 2011-08-03  Mark Pilgrim  
 
 Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (92313 => 92314)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2011-08-03 21:50:48 UTC (rev 92313)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2011-08-03 21:53:16 UTC (rev 92314)
@@ -568,7 +568,10 @@
 {
 KURL workingURL = activeDocumentLoader()->documentURL();
 #if ENABLE(WEB_ARCHIVE) || ENABLE(MHTML)
-if (m_archive)
+// FIXME: The document loader, not the frame loader, should be in charge of loading web archives.
+// Once this is done, we can just make DocumentLoader::documentURL() return the right URL
+// based on whether it has a non-null archive or not.
+if (m_archive && activeDocumentLoader()->parsedArchiveData())
 workingURL = m_archive->mainResource()->url();
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92313] trunk/Source/WebCore

[commit-queue]

Title: [92313] trunk/Source/WebCore








Revision 92313
Author commit-qu...@webkit.org
Date 2011-08-03 14:50:48 -0700 (Wed, 03 Aug 2011)


Log Message
Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=65353

Patch by Mark Pilgrim  on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
* page/DOMWindow.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/page/DOMWindow.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (92312 => 92313)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 21:50:48 UTC (rev 92313)
@@ -1,3 +1,18 @@
+2011-08-03  Mark Pilgrim  
+
+Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl
+https://bugs.webkit.org/show_bug.cgi?id=65353
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateFunctionCallback):
+* page/DOMWindow.idl:
+
 2011-08-03  Jeff Miller  
 
 Fix Chromimum and Qt builds after r92308.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (92312 => 92313)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-08-03 21:50:48 UTC (rev 92313)
@@ -1976,11 +1976,11 @@
 my $numParameters = @{$function->parameters};
 
 my $requiresAllArguments;
-if ($dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
-$requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"};
-} else {
-$requiresAllArguments = "Raise";
+my $requiresAllArgumentsDefault = "";
+if (!$dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
+$requiresAllArgumentsDefault = "Raise";
 }
+$requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"} || $requiresAllArgumentsDefault;
 if ($requiresAllArguments) {
 my $numMandatoryParams = @{$function->parameters};
 foreach my $param (reverse(@{$function->parameters})) {


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (92312 => 92313)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-08-03 21:50:48 UTC (rev 92313)
@@ -1248,11 +1248,11 @@
 my $numParameters = @{$function->parameters};
 
 my $requiresAllArguments;
-if ($dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
-$requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"};
-} else {
-$requiresAllArguments = "Raise";
+my $requiresAllArgumentsDefault = "";
+if (!$dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
+$requiresAllArgumentsDefault = "Raise";
 }
+$requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"} || $requiresAllArgumentsDefault;
 if ($requiresAllArguments) {
 my $numMandatoryParams = @{$function->parameters};
 foreach my $param (reverse(@{$function->parameters})) {


Modified: trunk/Source/WebCore/page/DOMWindow.idl (92312 => 92313)

--- trunk/Source/WebCore/page/DOMWindow.idl	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2011-08-03 21:50:48 UTC (rev 92313)
@@ -26,7 +26,6 @@
 module window {
 
 interface [
-LegacyDefaultOptionalArguments,
 CheckDomainSecurity,
 CustomDefineGetter,
 CustomDefineSetter,
@@ -80,18 +79,18 @@
in [Optional] DOMObject dialogArgs,
in [Optional] DOMString featureArgs);
 
-void alert(in DOMString message);
-boolean confirm(in DOMString message);
-[ConvertNullStringTo=Null] DOMString prompt(in DOMString message,
-in [ConvertUndefinedOrNullToNullString] DOMString defaultValue);
+void alert(in [Optional=CallWithDefaultValue] DOMString message);
+boolean confirm(in [Optional=CallWithDefaultValue] DOMString message);
+[ConvertNullStringTo=Null] DOMString prompt(in [Optional=CallWithDefaultValue] DOMString message,
+  

[webkit-changes] [92312] branches/safari-534.51-branch/Source/WebCore

[lforschler]

Title: [92312] branches/safari-534.51-branch/Source/WebCore








Revision 92312
Author lforsch...@apple.com
Date 2011-08-03 14:22:02 -0700 (Wed, 03 Aug 2011)


Log Message
Merge r91447.

Modified Paths

branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/platform/ScrollableArea.cpp




Diff

Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (92311 => 92312)

--- branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 21:16:57 UTC (rev 92311)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 21:22:02 UTC (rev 92312)
@@ -1,5 +1,16 @@
 2011-08-03  Lucas Forschler  
 
+Merged 91447.
+
+2011-07-20  Ryosuke Niwa  
+
+Fix a Valgrind failure caused by r91435.
+
+* platform/ScrollableArea.cpp:
+(WebCore::ScrollableArea::ScrollableArea):
+
+2011-08-03  Lucas Forschler  
+
 Merged 91438.
 
 2011-07-20  Ryosuke Niwa  


Modified: branches/safari-534.51-branch/Source/WebCore/platform/ScrollableArea.cpp (92311 => 92312)

--- branches/safari-534.51-branch/Source/WebCore/platform/ScrollableArea.cpp	2011-08-03 21:16:57 UTC (rev 92311)
+++ branches/safari-534.51-branch/Source/WebCore/platform/ScrollableArea.cpp	2011-08-03 21:22:02 UTC (rev 92312)
@@ -47,6 +47,7 @@
 , m_inLiveResize(false)
 , m_verticalScrollElasticity(ScrollElasticityNone)
 , m_horizontalScrollElasticity(ScrollElasticityNone)
+, m_scrollbarOverlayStyle(ScrollbarOverlayStyleDefault)
 {
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92311] branches/safari-534.51-branch/Source/WebCore

[lforschler]

Title: [92311] branches/safari-534.51-branch/Source/WebCore








Revision 92311
Author lforsch...@apple.com
Date 2011-08-03 14:16:57 -0700 (Wed, 03 Aug 2011)


Log Message
Merge r91438.

Modified Paths

branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/platform/mac/ScrollViewMac.mm




Diff

Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (92310 => 92311)

--- branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 21:04:14 UTC (rev 92310)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 21:16:57 UTC (rev 92311)
@@ -1,5 +1,16 @@
 2011-08-03  Lucas Forschler  
 
+Merged 91438.
+
+2011-07-20  Ryosuke Niwa  
+
+Build fix after r91435.
+
+* platform/mac/ScrollViewMac.mm:
+(WebCore::ScrollView::platformSetScrollbarOverlayStyle):
+
+2011-08-03  Lucas Forschler  
+
 Merged 91435.
 
 2011-07-20  Tim Horton  


Modified: branches/safari-534.51-branch/Source/WebCore/platform/mac/ScrollViewMac.mm (92310 => 92311)

--- branches/safari-534.51-branch/Source/WebCore/platform/mac/ScrollViewMac.mm	2011-08-03 21:04:14 UTC (rev 92310)
+++ branches/safari-534.51-branch/Source/WebCore/platform/mac/ScrollViewMac.mm	2011-08-03 21:16:57 UTC (rev 92311)
@@ -32,6 +32,7 @@
 #import "Logging.h"
 #import "NotImplemented.h"
 #import "WebCoreFrameView.h"
+#import 
 
 using namespace std;
 
@@ -203,6 +204,7 @@
 return ![platformWidget() window] || ![[platformWidget() window] isVisible];
 }
 
+#if USE(WK_SCROLLBAR_PAINTER)
 static inline NSScrollerKnobStyle toNSScrollerKnobStyle(ScrollbarOverlayStyle style)
 {
 switch (style) {
@@ -214,10 +216,15 @@
 return NSScrollerKnobStyleDefault;
 }
 }
+#endif
 
 void ScrollView::platformSetScrollbarOverlayStyle(ScrollbarOverlayStyle overlayStyle)
 {
+#if USE(WK_SCROLLBAR_PAINTER)
 [scrollView() setScrollerKnobStyle:toNSScrollerKnobStyle(overlayStyle)];
+#else
+UNUSED_PARAM(overlayStyle);
+#endif
 }
 
 void ScrollView::platformSetScrollOrigin(const IntPoint& origin, bool updatePositionAtAll, bool updatePositionSynchronously)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92310] branches/safari-534.51-branch/Source

[lforschler]

Title: [92310] branches/safari-534.51-branch/Source








Revision 92310
Author lforsch...@apple.com
Date 2011-08-03 14:04:14 -0700 (Wed, 03 Aug 2011)


Log Message
Merge r91435.

Modified Paths

branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in
branches/safari-534.51-branch/Source/WebCore/page/Frame.cpp
branches/safari-534.51-branch/Source/WebCore/page/Frame.h
branches/safari-534.51-branch/Source/WebCore/page/FrameView.cpp
branches/safari-534.51-branch/Source/WebCore/page/FrameView.h
branches/safari-534.51-branch/Source/WebCore/platform/ScrollView.cpp
branches/safari-534.51-branch/Source/WebCore/platform/ScrollView.h
branches/safari-534.51-branch/Source/WebCore/platform/ScrollableArea.cpp
branches/safari-534.51-branch/Source/WebCore/platform/ScrollableArea.h
branches/safari-534.51-branch/Source/WebCore/platform/ScrollbarTheme.h
branches/safari-534.51-branch/Source/WebCore/platform/mac/ScrollViewMac.mm
branches/safari-534.51-branch/Source/WebCore/platform/mac/ScrollbarThemeMac.h
branches/safari-534.51-branch/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
branches/safari-534.51-branch/Source/WebCore/rendering/RenderBox.cpp
branches/safari-534.51-branch/Source/WebKit2/ChangeLog
branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp




Diff

Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (92309 => 92310)

--- branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 20:52:32 UTC (rev 92309)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 21:04:14 UTC (rev 92310)
@@ -1,5 +1,53 @@
 2011-08-03  Lucas Forschler  
 
+Merged 91435.
+
+2011-07-20  Tim Horton  
+
+Scrollbar color heuristic needs to be hooked up in WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=64220
+
+
+Reviewed by Darin Adler.
+
+Store the scroller style on ScrollableArea, and recompute it whenever
+the document or body element background color changes or the base background
+color of the scrollview changes. Also, make sure to repaint the scrollbars
+whenever the style changes.
+
+No new tests, since this code is only enabled on future versions of Mac OS X.
+
+* WebCore.exp.in:
+* page/Frame.cpp:
+(WebCore::Frame::getDocumentBackgroundColor):
+* page/Frame.h:
+* page/FrameView.cpp:
+(WebCore::FrameView::recalculateScrollbarOverlayStyle):
+(WebCore::FrameView::setBaseBackgroundColor):
+(WebCore::FrameView::documentBackgroundColor): Renamed.
+* page/FrameView.h:
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::setScrollbarOverlayStyle):
+* platform/ScrollView.h:
+* platform/ScrollableArea.cpp:
+(WebCore::ScrollableArea::setScrollbarOverlayStyle):
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::scrollbarOverlayStyle):
+* platform/ScrollbarTheme.h:
+(WebCore::ScrollbarTheme::updateScrollbarOverlayStyle):
+* platform/mac/ScrollViewMac.mm:
+(WebCore::toNSScrollerKnobStyle):
+(WebCore::ScrollView::platformSetScrollbarOverlayStyle):
+* platform/mac/ScrollbarThemeMac.h:
+* platform/mac/ScrollbarThemeMac.mm:
+(WebCore::toScrollbarPainterKnobStyle):
+(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
+(WebCore::ScrollbarThemeMac::paint):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::styleDidChange):
+
+2011-08-03  Lucas Forschler  
+
 Merged 90705.
 
 2011-07-10  Anders Carlsson  


Modified: branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in (92309 => 92310)

--- branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in	2011-08-03 20:52:32 UTC (rev 92309)
+++ branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in	2011-08-03 21:04:14 UTC (rev 92310)
@@ -1022,7 +1022,6 @@
 __ZN7WebCore9toElementEN3JSC7JSValueE
 __ZNK3JSC8Bindings10RootObject12globalObjectEv
 __ZNK3WTF6String14createCFStringEv
-__ZNK7WebCore5Frame26getDocumentBackgroundColorEv
 __ZNK7WebCore10Credential11hasPasswordEv
 __ZNK7WebCore10Credential11persistenceEv
 __ZNK7WebCore10Credential4userEv
@@ -1311,6 +1310,7 @@
 __ZNK7WebCore9FrameView13paintBehaviorEv
 __ZNK7WebCore9FrameView20isSoftwareRenderableEv
 __ZNK7WebCore9FrameView22windowClipRectForLayerEPKNS_11RenderLayerEb
+__ZNK7WebCore9FrameView23documentBackgroundColorEv
 __ZNK7WebCore9FrameView28isEnclosedInCompositingLayerEv
 __ZNK7WebCore9PageCache10frameCountEv
 __ZNK7WebCore9PageCache21autoreleasedPageCountEv


Modified: branches/safari-534.51-branch/Source/WebCore/page/Frame.cpp (92309 => 92310)

--- branches/safari-534.51-branch/Source/WebCore/page/Frame.cpp	2011-08-03 20:52:32 UTC (rev 92309)
+++ branches/safari-534.51-branch/Source/WebCore/page/Frame.cpp	2011-08-03 21:04:14 UTC (rev 92310)
@@ -504,47 +504,7 @@
 
 return matchLabelsAgainstStri

[webkit-changes] [92309] trunk/Source/WebCore

[jeffm]

Title: [92309] trunk/Source/WebCore








Revision 92309
Author je...@apple.com
Date 2011-08-03 13:52:32 -0700 (Wed, 03 Aug 2011)


Log Message
Fix Chromimum and Qt builds after r92308.

* config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92308 => 92309)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 20:15:53 UTC (rev 92308)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 20:52:32 UTC (rev 92309)
@@ -1,5 +1,11 @@
 2011-08-03  Jeff Miller  
 
+Fix Chromimum and Qt builds after r92308.
+
+* config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt.
+
+2011-08-03  Jeff Miller  
+
 Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
 https://bugs.webkit.org/show_bug.cgi?id=65634
 


Modified: trunk/Source/WebCore/config.h (92308 => 92309)

--- trunk/Source/WebCore/config.h	2011-08-03 20:15:53 UTC (rev 92308)
+++ trunk/Source/WebCore/config.h	2011-08-03 20:52:32 UTC (rev 92309)
@@ -29,7 +29,7 @@
 
 #include 
 
-#if OS(WINDOWS)
+#if OS(WINDOWS) && !PLATFORM(QT) && !PLATFORM(CHROMIUM)
 #include 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92308] trunk/Source/WebCore

[jeffm]

Title: [92308] trunk/Source/WebCore








Revision 92308
Author je...@apple.com
Date 2011-08-03 13:15:53 -0700 (Wed, 03 Aug 2011)


Log Message
Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
https://bugs.webkit.org/show_bug.cgi?id=65634

AVFoundation support on Windows will (eventually) be predicated on the
availability of AVFoundationCF headers and libraries in the WebKit Support
Libraries, so we test for the existence of one of the header files (AVCFBase.h)
to determine whether to AVCF is available.

For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since
it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400).

Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could
include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file
ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this
.cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h.

Reviewed by Adam Roben.

No change in functionality, so new tests.

* DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows.
* config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92307 => 92308)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 20:13:59 UTC (rev 92307)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 20:15:53 UTC (rev 92308)
@@ -1,3 +1,28 @@
+2011-08-03  Jeff Miller  
+
+Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
+https://bugs.webkit.org/show_bug.cgi?id=65634
+
+AVFoundation support on Windows will (eventually) be predicated on the
+availability of AVFoundationCF headers and libraries in the WebKit Support
+Libraries, so we test for the existence of one of the header files (AVCFBase.h)
+to determine whether to AVCF is available.
+
+For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since
+it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400).
+
+Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could
+include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file
+ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this
+.cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h.
+
+Reviewed by Adam Roben.
+
+No change in functionality, so new tests.
+
+* DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows.
+* config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now.
+
 2011-08-03  Tommy Widenflycht  
 
 MediaStream API: Implement PeerConnection and SignalingCallback


Modified: trunk/Source/WebCore/DerivedSources.make (92307 => 92308)

--- trunk/Source/WebCore/DerivedSources.make	2011-08-03 20:13:59 UTC (rev 92307)
+++ trunk/Source/WebCore/DerivedSources.make	2011-08-03 20:15:53 UTC (rev 92308)
@@ -973,3 +973,16 @@
 # 
 
 endif # MACOS
+
+# 
+
+# Header detection
+
+ifeq ($(OS),Windows_NT)
+
+all : WebCoreHeaderDetection.h
+
+WebCoreHeaderDetection.h : DerivedSources.make
+	if [ -f "$(WEBKITLIBRARIESDIR)/include/AVFoundationCF/AVCFBase.h" ]; then echo "#define HAVE_AVCF 1" > $@; else echo > $@; fi
+
+endif # Windows_NT


Modified: trunk/Source/WebCore/config.h (92307 => 92308)

--- trunk/Source/WebCore/config.h	2011-08-03 20:13:59 UTC (rev 92307)
+++ trunk/Source/WebCore/config.h	2011-08-03 20:15:53 UTC (rev 92308)
@@ -29,6 +29,10 @@
 
 #include 
 
+#if OS(WINDOWS)
+#include 
+#endif
+
 /* See note in wtf/Platform.h for more info on EXPORT_MACROS. */
 #if USE(EXPORT_MACROS)
 
@@ -221,3 +225,7 @@
 #define WTF_USE_AVFOUNDATION 1
 #endif
 
+#if PLATFORM(WIN) && HAVE(AVCF)
+/// FIXME: Adopt AVCF media back end on Windows http://webkit.org/b/65400
+#define WTF_USE_AVFOUNDATION 0
+#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92307] trunk/LayoutTests

[zmo]

Title: [92307] trunk/LayoutTests








Revision 92307
Author z...@google.com
Date 2011-08-03 13:13:59 -0700 (Wed, 03 Aug 2011)


Log Message
Unreviewed, fix an error in test_expectations.txt.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92306 => 92307)

--- trunk/LayoutTests/ChangeLog	2011-08-03 19:57:34 UTC (rev 92306)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 20:13:59 UTC (rev 92307)
@@ -1,5 +1,11 @@
 2011-08-03  Zhenyao Mo  
 
+Unreviewed, fix an error in test_expectations.txt.
+
+* platform/chromium/test_expectations.txt:
+
+2011-08-03  Zhenyao Mo  
+
 Unreviewed, skip fast/loader/reload-zero-byte-plugin.html for now, gardener stuff.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92306 => 92307)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 19:57:34 UTC (rev 92306)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 20:13:59 UTC (rev 92307)
@@ -3691,5 +3691,6 @@
 
 BUGWK65462 VISTA : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT
 
-BUGZMO : fast/loader/reload-zero-byte-plugin.html = SKIP
+// Introduced in r92298, which might cause another test crashing.
+BUGZMO SKIP : fast/loader/reload-zero-byte-plugin.html = FAIL
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92306] trunk/LayoutTests

[zmo]

Title: [92306] trunk/LayoutTests








Revision 92306
Author z...@google.com
Date 2011-08-03 12:57:34 -0700 (Wed, 03 Aug 2011)


Log Message
Unreviewed, skip fast/loader/reload-zero-byte-plugin.html for now, gardener stuff.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92305 => 92306)

--- trunk/LayoutTests/ChangeLog	2011-08-03 19:55:43 UTC (rev 92305)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 19:57:34 UTC (rev 92306)
@@ -1,3 +1,9 @@
+2011-08-03  Zhenyao Mo  
+
+Unreviewed, skip fast/loader/reload-zero-byte-plugin.html for now, gardener stuff.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-03  Tommy Widenflycht  
 
 MediaStream API: Implement PeerConnection and SignalingCallback


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92305 => 92306)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 19:55:43 UTC (rev 92305)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 19:57:34 UTC (rev 92306)
@@ -3691,3 +3691,5 @@
 
 BUGWK65462 VISTA : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT
 
+BUGZMO : fast/loader/reload-zero-byte-plugin.html = SKIP
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92305] branches/chromium/835/Source/WebCore/storage

[michaeln]

Title: [92305] branches/chromium/835/Source/WebCore/storage








Revision 92305
Author micha...@google.com
Date 2011-08-03 12:55:43 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 92155 - [Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
https://bugs.webkit.org/show_bug.cgi?id=65486

The WebCore::AbstractDatabase class maintains a global in-memory map of
the version numbers associated with open database files, but that map is
not reliable in a multi-process system like Chrome. So instead of relying
on the cached values in that map, we read the value from the database (and
update the cached value) where possible. There are two edge cases where that's
not possible because the scriptable interface requires synchronous access
to the version: the .version attribute getter and the .openDatabase() method.
In those cases, we have no choice but to use the potentially stale cached value.

Reviewed by Darin Fisher.

No new tests. Existing layout tests cover the version handling functionality.

* storage/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
(WebCore::AbstractDatabase::setCachedVersion):
(WebCore::AbstractDatabase::getActualVersionForTransaction):
* storage/AbstractDatabase.h:
(WebCore::AbstractDatabase::expectedVersion):
* storage/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):
* storage/ChangeVersionWrapper.h:
* storage/Database.cpp:
(WebCore::Database::openDatabase):
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):
* storage/SQLTransaction.h:
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
* storage/SQLTransactionSync.h:


TBR=micha...@google.com
Review URL: http://codereview.chromium.org/7563014

Modified Paths

branches/chromium/835/Source/WebCore/storage/AbstractDatabase.cpp
branches/chromium/835/Source/WebCore/storage/AbstractDatabase.h
branches/chromium/835/Source/WebCore/storage/ChangeVersionWrapper.cpp
branches/chromium/835/Source/WebCore/storage/ChangeVersionWrapper.h
branches/chromium/835/Source/WebCore/storage/Database.cpp
branches/chromium/835/Source/WebCore/storage/DatabaseSync.cpp
branches/chromium/835/Source/WebCore/storage/SQLTransaction.cpp
branches/chromium/835/Source/WebCore/storage/SQLTransaction.h
branches/chromium/835/Source/WebCore/storage/SQLTransactionSync.cpp
branches/chromium/835/Source/WebCore/storage/SQLTransactionSync.h




Diff

Modified: branches/chromium/835/Source/WebCore/storage/AbstractDatabase.cpp (92304 => 92305)

--- branches/chromium/835/Source/WebCore/storage/AbstractDatabase.cpp	2011-08-03 19:54:22 UTC (rev 92304)
+++ branches/chromium/835/Source/WebCore/storage/AbstractDatabase.cpp	2011-08-03 19:55:43 UTC (rev 92305)
@@ -34,6 +34,7 @@
 #include "DatabaseTracker.h"
 #include "Logging.h"
 #include "SQLiteStatement.h"
+#include "SQLiteTransaction.h"
 #include "ScriptExecutionContext.h"
 #include "SecurityOrigin.h"
 #include 
@@ -235,13 +236,16 @@
 
 String AbstractDatabase::version() const
 {
-MutexLocker locker(guidMutex());
-return guidToVersionMap().get(m_guid).threadsafeCopy();
+// Note: In multi-process browsers the cached value may be accurate, but we cannot read the
+// actual version from the database without potentially inducing a deadlock.
+// FIXME: Add an async version getter to the DatabaseAPI.
+return getCachedVersion();
 }
 
-static const int maxSqliteBusyWaitTime = 3;
 bool AbstractDatabase::performOpenAndVerify(bool shouldSetVersionInNewDatabase, ExceptionCode& ec)
 {
+const int maxSqliteBusyWaitTime = 3;
+
 if (!m_sqliteDatabase.open(m_filename, true)) {
 LOG_ERROR("Unable to open database at path %s", m_filename.ascii().data());
 ec = INVALID_STATE_ERR;
@@ -250,8 +254,6 @@
 if (!m_sqliteDatabase.turnOnIncrementalAutoVacuum())
 LOG_ERROR("Unable to turn on incremental auto-vacuum for database %s", m_filename.ascii().data());
 
-ASSERT(m_databaseAuthorizer);
-m_sqliteDatabase.setAuthorizer(m_databaseAuthorizer);
 m_sqliteDatabase.setBusyTimeout(maxSqliteBusyWaitTime);
 
 String currentVersion;
@@ -263,43 +265,68 @@
 // Map null string to empty string (see updateGuidVersionMap()).
 currentVersion = entry->second.isNull() ? String("") : entry->second;
 LOG(StorageAPI

[webkit-changes] [92303] trunk

[kevino]

Title: [92303] trunk








Revision 92303
Author kev...@webkit.org
Date 2011-08-03 12:38:19 -0700 (Wed, 03 Aug 2011)


Log Message
[wx] Unreviewed build fix after gesture recognizer changes.

Modified Paths

trunk/ChangeLog
trunk/wscript




Diff

Modified: trunk/ChangeLog (92302 => 92303)

--- trunk/ChangeLog	2011-08-03 19:36:04 UTC (rev 92302)
+++ trunk/ChangeLog	2011-08-03 19:38:19 UTC (rev 92303)
@@ -1,3 +1,9 @@
+2011-08-03  Kevin Ollivier  
+
+[wx] Unreviewed build fix after gesture recognizer changes.
+
+* wscript:
+
 2011-08-02  Caio Marcelo de Oliveira Filho  
 
 [Qt] [WK2] Expose web view classes to QML


Modified: trunk/wscript (92302 => 92303)

--- trunk/wscript	2011-08-03 19:36:04 UTC (rev 92302)
+++ trunk/wscript	2011-08-03 19:38:19 UTC (rev 92303)
@@ -330,6 +330,9 @@
 # once we move over to the new FPD implementation, remove this.
 excludes.append('FontPlatformData.cpp')
 
+# we don't use gestures currently
+excludes.append('PlatformGestureRecognizer.cpp')
+
 if sys.platform.startswith('darwin'):
 webcore.includes += ' Source/WebKit/mac/WebCoreSupport WebCore/platform/mac'
 webcore.source += ' Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92302] trunk/Source/WebKit2

[caio . oliveira]

Title: [92302] trunk/Source/WebKit2








Revision 92302
Author caio.olive...@openbossa.org
Date 2011-08-03 12:36:04 -0700 (Wed, 03 Aug 2011)


Log Message
[Qt] [WK2] Improve position of context menu for QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65635

Reviewed by Andreas Kling.

Do not assume that the QDesktopWebView takes the entire canvas when
positioning the context menu.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::showContextMenu):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92301 => 92302)

--- trunk/Source/WebKit2/ChangeLog	2011-08-03 19:18:25 UTC (rev 92301)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-03 19:36:04 UTC (rev 92302)
@@ -1,3 +1,16 @@
+2011-08-03  Caio Marcelo de Oliveira Filho  
+
+[Qt] [WK2] Improve position of context menu for QDesktopWebView
+https://bugs.webkit.org/show_bug.cgi?id=65635
+
+Reviewed by Andreas Kling.
+
+Do not assume that the QDesktopWebView takes the entire canvas when
+positioning the context menu.
+
+* UIProcess/API/qt/qdesktopwebview.cpp:
+(QDesktopWebViewPrivate::showContextMenu):
+
 2011-08-03  Anders Carlsson  
 
 Fix API tests.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp (92301 => 92302)

--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp	2011-08-03 19:18:25 UTC (rev 92301)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp	2011-08-03 19:36:04 UTC (rev 92302)
@@ -151,7 +151,8 @@
 activeMenu = menu;
 
 menu->setParent(widget, menu->windowFlags());
-menu->exec(widget->mapToGlobal(menu->pos()));
+QPoint menuPositionInScene = q->mapToScene(menu->pos()).toPoint();
+menu->exec(widget->mapToGlobal(menuPositionInScene));
 // The last function to get out of exec() clear the local copy.
 if (activeMenu == menu)
 activeMenu.clear();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92301] branches/safari-534.51-branch/Source

[lforschler]

Title: [92301] branches/safari-534.51-branch/Source








Revision 92301
Author lforsch...@apple.com
Date 2011-08-03 12:18:25 -0700 (Wed, 03 Aug 2011)


Log Message
Merge r90705.

Modified Paths

branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/platform/mac/CursorMac.mm
branches/safari-534.51-branch/Source/WebKit2/ChangeLog
branches/safari-534.51-branch/Source/WebKit2/Shared/WebCoreArgumentCoders.h




Diff

Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (92300 => 92301)

--- branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 19:09:34 UTC (rev 92300)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-03 19:18:25 UTC (rev 92301)
@@ -1,3 +1,25 @@
+2011-08-03  Lucas Forschler  
+
+Merged 90705.
+
+2011-07-10  Anders Carlsson  
+
+WebKit2 is leaking NSCursors created by leakNamedCursor
+https://bugs.webkit.org/show_bug.cgi?id=64241
+
+
+Reviewed by Oliver Hunt.
+
+* platform/mac/CursorMac.mm:
+(WebCore::createNamedCursor):
+Rename this from leakNamedCursor to createNamedCursor and make it return a
+RetainPtr instead of a raw pointer.
+
+(WebCore::Cursor::ensurePlatformCursor):
+Don't leak cursors here. We still won't deallocate cursors during shutdown (which leakNamedCursor
+was said to prevent) because the cursor singletons are all allocated from the heap and are never destroyed
+anyway.
+
 2011-08-02  Lucas Forschler  
 
 Merged 91616.


Modified: branches/safari-534.51-branch/Source/WebCore/platform/mac/CursorMac.mm (92300 => 92301)

--- branches/safari-534.51-branch/Source/WebCore/platform/mac/CursorMac.mm	2011-08-03 19:09:34 UTC (rev 92300)
+++ branches/safari-534.51-branch/Source/WebCore/platform/mac/CursorMac.mm	2011-08-03 19:18:25 UTC (rev 92301)
@@ -53,21 +53,17 @@
 return 0;
 }
 
-// Leak these cursors intentionally, that way we won't waste time trying to clean them
-// up at process exit time.
-static NSCursor* leakNamedCursor(const char* name, int x, int y)
+static RetainPtr createNamedCursor(const char* name, int x, int y)
 {
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
-NSString* resourceName = [[NSString alloc] initWithUTF8String:name];
-NSImage* cursorImage = [[NSImage alloc] initWithContentsOfFile:
-[[NSBundle bundleForClass:[WebCoreCursorBundle class]]
-pathForResource:resourceName ofType:@"png"]];
-[resourceName release];
-NSCursor* cursor = 0;
+RetainPtr resourceName(AdoptNS, [[NSString alloc] initWithUTF8String:name]);
+RetainPtr cursorImage(AdoptNS, [[NSImage alloc] initWithContentsOfFile:[[NSBundle bundleForClass:[WebCoreCursorBundle class]] pathForResource:resourceName.get() ofType:@"png"]]);
+
+RetainPtr cursor;
+
 if (cursorImage) {
 NSPoint hotSpotPoint = {x, y}; // workaround for 4213314
-cursor = [[NSCursor alloc] initWithImage:cursorImage hotSpot:hotSpotPoint];
-[cursorImage release];
+cursor.adoptNS([[NSCursor alloc] initWithImage:cursorImage.get() hotSpot:hotSpotPoint]);
 }
 return cursor;
 END_BLOCK_OBJC_EXCEPTIONS;
@@ -92,24 +88,24 @@
 #else
 // The pointingHandCursor from NSCursor does not have a shadow on
 // older versions of Mac OS X, so use our own custom cursor.
-m_platformCursor = leakNamedCursor("linkCursor", 6, 1);
+m_platformCursor = createNamedCursor("linkCursor", 6, 1);
 #endif
 break;
 case Cursor::IBeam:
 m_platformCursor = [NSCursor IBeamCursor];
 break;
 case Cursor::Wait:
-m_platformCursor = leakNamedCursor("waitCursor", 7, 7);
+m_platformCursor = createNamedCursor("waitCursor", 7, 7);
 break;
 case Cursor::Help:
-m_platformCursor = leakNamedCursor("helpCursor", 8, 8);
+m_platformCursor = createNamedCursor("helpCursor", 8, 8);
 break;
 case Cursor::Move:
 case Cursor::MiddlePanning:
 #if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
 m_platformCursor = wkCursor("Move");
 #else
-m_platformCursor = leakNamedCursor("moveCursor", 7, 7);
+m_platformCursor = createNamedCursor("moveCursor", 7, 7);
 #endif
 break;
 case Cursor::EastResize:
@@ -117,7 +113,7 @@
 #if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
 m_platformCursor = wkCursor("ResizeEast");
 #else
-m_platformCursor = leakNamedCursor("eastResizeCursor", 14, 7);
+m_platformCursor = createNamedCursor("eastResizeCursor", 14, 7);
 #endif
 break;
 case Cursor::NorthResize:
@@ -125,7 +121,7 @@
 #if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
 m_platformCursor = wkCursor("ResizeNorth");
 #else
-m_platformCursor = leakNamedCursor("northResizeCursor", 7, 1);
+m_platformCursor = createNamedCursor("northResizeCursor", 7, 1);
 #endif
 

[webkit-changes] [92300] trunk/Source

[joepeck]

Title: [92300] trunk/Source








Revision 92300
Author joep...@webkit.org
Date 2011-08-03 12:09:34 -0700 (Wed, 03 Aug 2011)


Log Message
Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
https://bugs.webkit.org/show_bug.cgi?id=65582

Reviewed by Pavel Feldman.

Source/WebCore:

Remove stale code. WebInspector.settings uses localStorage and
handles the "debuggerEnabled" state. So remove the only remaining
usage of load/saveSessionSetting.

* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):

Source/WebKit/cf:

* WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorFrontendClient.h
trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp
trunk/Source/WebCore/inspector/InspectorFrontendHost.h
trunk/Source/WebCore/inspector/InspectorFrontendHost.idl
trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebKit/cf/ChangeLog
trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92299 => 92300)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 19:09:34 UTC (rev 92300)
@@ -1,3 +1,22 @@
+2011-08-03  Joseph Pecoraro  
+
+Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
+https://bugs.webkit.org/show_bug.cgi?id=65582
+
+Reviewed by Pavel Feldman.
+
+Remove stale code. WebInspector.settings uses localStorage and
+handles the "debuggerEnabled" state. So remove the only remaining
+usage of load/saveSessionSetting.
+
+* inspector/InspectorFrontendClient.h:
+* inspector/InspectorFrontendHost.cpp:
+* inspector/InspectorFrontendHost.h:
+* inspector/InspectorFrontendHost.idl:
+* inspector/front-end/InspectorFrontendHostStub.js:
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
+
 2011-08-03  Adam Barth  
 
 Crash in DocumentWriter::endIfNotLoadingMainResource


Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (92299 => 92300)

--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h	2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h	2011-08-03 19:09:34 UTC (rev 92300)
@@ -63,9 +63,6 @@
 virtual void inspectedURLChanged(const String&) = 0;
 
 virtual void sendMessageToBackend(const String&) = 0;
-
-virtual void saveSessionSetting(const String&, const String&) { }
-virtual void loadSessionSetting(const String&, String*) { }
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (92299 => 92300)

--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2011-08-03 19:09:34 UTC (rev 92300)
@@ -228,20 +228,6 @@
 m_client->saveAs(fileName, content);
 }
 
-void InspectorFrontendHost::saveSessionSetting(const String& key, const String& value)
-{
-if (m_client)
-m_client->saveSessionSetting(key, value);
-}
-
-String InspectorFrontendHost::loadSessionSetting(const String& key)
-{
-String value;
-if (m_client)
-m_client->loadSessionSetting(key, &value);
-return value;
-}
-
 void InspectorFrontendHost::sendMessageToBackend(const String& message)
 {
 if (m_client)


Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (92299 => 92300)

--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h	2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h	2011-08-03 19:09:34 UTC (rev 92300)
@@ -75,9 +75,6 @@
 void copyText(const String& text);
 void saveAs(const String& fileName, const String& content);
 
-void saveSessionSetting(const String& key, const String& value);
-String loadSessionSetting(const String& key);
-
 // Called from [Custom] implementations.
 void showContextMenu(Event*, const Vector& items);
 void sendMessageToBackend(const String& message);


Modi

[webkit-changes] [92299] branches/chromium/835/Source/WebCore/page/FrameView.cpp

[enne]

Title: [92299] branches/chromium/835/Source/WebCore/page/FrameView.cpp








Revision 92299
Author e...@google.com
Date 2011-08-03 12:06:48 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 92030 - [chromium] Only force slow scrolling for iframes under --force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=65394

Reviewed by James Robinson.

The previous code introduced by r91591 made composited frames as well
as non-composited subframes go down the slow scrolling path.  Adjust
the check to use ownerElement to test for subframe and use
hasCompositedContent() which is a more correct test for compositing
than isEnclosedInCompositingLayer.

* page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):


TBR=e...@google.com
Review URL: http://codereview.chromium.org/7565014

Modified Paths

branches/chromium/835/Source/WebCore/page/FrameView.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/page/FrameView.cpp (92298 => 92299)

--- branches/chromium/835/Source/WebCore/page/FrameView.cpp	2011-08-03 18:56:37 UTC (rev 92298)
+++ branches/chromium/835/Source/WebCore/page/FrameView.cpp	2011-08-03 19:06:48 UTC (rev 92299)
@@ -1151,7 +1151,7 @@
 #if PLATFORM(CHROMIUM)
 // The chromium compositor does not support scrolling a non-composited frame within a composited page through
 // the fast scrolling path, so force slow scrolling in that case.
-if (!isEnclosedInCompositingLayer() && m_frame->page() && m_frame->page()->mainFrame()->view()->hasCompositedContent())
+if (m_frame->ownerElement() && !hasCompositedContent() && m_frame->page() && m_frame->page()->mainFrame()->view()->hasCompositedContent())
 return true;
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92298] trunk

[abarth]

Title: [92298] trunk








Revision 92298
Author aba...@webkit.org
Date 2011-08-03 11:56:37 -0700 (Wed, 03 Aug 2011)


Log Message
Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581

Reviewed by Nate Chapin.

Source/WebCore:

This function is poorly designed because isLoadingMainResource is a
poor proxy for determing whether to flush/finish the parser.  Really,
we should change how loads complete to match the model in HTML5, but
that's pretty tricky.  In the meantime, this null check fixes the
crash.

I'm sure there's another bug on file about this crash, but we've never
been able to reproduce it.  Thanks to Berend-Jan Wever for the test
case!

Test: fast/loader/reload-zero-byte-plugin.html

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::endIfNotLoadingMainResource):

LayoutTests:

* fast/loader/reload-zero-byte-plugin-expected.txt: Added.
* fast/loader/reload-zero-byte-plugin.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentWriter.cpp


Added Paths

trunk/LayoutTests/fast/loader/reload-zero-byte-plugin-expected.txt
trunk/LayoutTests/fast/loader/reload-zero-byte-plugin.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92297 => 92298)

--- trunk/LayoutTests/ChangeLog	2011-08-03 18:40:24 UTC (rev 92297)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 18:56:37 UTC (rev 92298)
@@ -1,3 +1,13 @@
+2011-08-03  Adam Barth  
+
+Crash in DocumentWriter::endIfNotLoadingMainResource
+https://bugs.webkit.org/show_bug.cgi?id=65581
+
+Reviewed by Nate Chapin.
+
+* fast/loader/reload-zero-byte-plugin-expected.txt: Added.
+* fast/loader/reload-zero-byte-plugin.html: Added.
+
 2011-08-03  Anders Carlsson  
 
 Add a Mac Lion skipped list.


Added: trunk/LayoutTests/fast/loader/reload-zero-byte-plugin-expected.txt (0 => 92298)

--- trunk/LayoutTests/fast/loader/reload-zero-byte-plugin-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/loader/reload-zero-byte-plugin-expected.txt	2011-08-03 18:56:37 UTC (rev 92298)
@@ -0,0 +1 @@
+This test passes if it doesn't crash. To run manually, please disable your popup blocker.


Added: trunk/LayoutTests/fast/loader/reload-zero-byte-plugin.html (0 => 92298)

--- trunk/LayoutTests/fast/loader/reload-zero-byte-plugin.html	(rev 0)
+++ trunk/LayoutTests/fast/loader/reload-zero-byte-plugin.html	2011-08-03 18:56:37 UTC (rev 92298)
@@ -0,0 +1,19 @@
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+layoutTestController.setCanOpenWindows(true);
+layoutTestController.setCloseRemainingWindowsWhenComplete(true);
+}
+
+var win = window.open('data:application/x-webkit-test-netscape,');
+setTimeout(function() {
+win.location.reload();
+setTimeout(function() {
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}, 100);
+}, 100);
+
+This test passes if it doesn't crash. To run manually, please disable your
+popup blocker.


Modified: trunk/Source/WebCore/ChangeLog (92297 => 92298)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 18:40:24 UTC (rev 92297)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 18:56:37 UTC (rev 92298)
@@ -1,3 +1,25 @@
+2011-08-03  Adam Barth  
+
+Crash in DocumentWriter::endIfNotLoadingMainResource
+https://bugs.webkit.org/show_bug.cgi?id=65581
+
+Reviewed by Nate Chapin.
+
+This function is poorly designed because isLoadingMainResource is a
+poor proxy for determing whether to flush/finish the parser.  Really,
+we should change how loads complete to match the model in HTML5, but
+that's pretty tricky.  In the meantime, this null check fixes the
+crash.
+
+I'm sure there's another bug on file about this crash, but we've never
+been able to reproduce it.  Thanks to Berend-Jan Wever for the test
+case!
+
+Test: fast/loader/reload-zero-byte-plugin.html
+
+* loader/DocumentWriter.cpp:
+(WebCore::DocumentWriter::endIfNotLoadingMainResource):
+
 2011-08-03  Anders Carlsson  
 
 WebCore images backing CG patterns should be released on the main thread


Modified: trunk/Source/WebCore/loader/DocumentWriter.cpp (92297 => 92298)

--- trunk/Source/WebCore/loader/DocumentWriter.cpp	2011-08-03 18:40:24 UTC (rev 92297)
+++ trunk/Source/WebCore/loader/DocumentWriter.cpp	2011-08-03 18:56:37 UTC (rev 92298)
@@ -211,6 +211,8 @@
 
 void DocumentWriter::endIfNotLoadingMainResource()
 {
+// FIXME: This isn't really the check we should be doing. We should re-work
+// how we end parsing to match the model in HTML5.
 if (m_frame->loader()->isLoadingMainResource() || !m_frame->page() || !m_frame->document())
 return;
 
@@ -219,6 +221,8 @@
 // so we'll add a protective refcount
 RefPtr protector(m_frame);
 
+if 

[webkit-changes] [92297] branches/chromium/835/Source/WebCore/platform/graphics/skia/ ImageBufferSkia.cpp

[senorblanco]

Title: [92297] branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp








Revision 92297
Author senorbla...@chromium.org
Date 2011-08-03 11:40:24 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 92227 - [Chromium] Remove an unnecessary readback during accelerated 
canvas-to-canvas draws.
https://bugs.webkit.org/show_bug.cgi?id=65560

Reviewed by James Robinson.

No new tests.  (Printing has few tests, sadly.)

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):
Revert most of the changes to this file from
http://trac.webkit.org/changeset/91870, except for the call which makes
the source context current, so that the readPixels() still works.


TBR=senorbla...@chromium.org
Review URL: http://codereview.chromium.org/7465097

Modified Paths

branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (92296 => 92297)

--- branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-08-03 18:38:40 UTC (rev 92296)
+++ branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-08-03 18:40:24 UTC (rev 92297)
@@ -112,12 +112,15 @@
 void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect,
CompositeOperator op, bool useLowQualityScale)
 {
+// Set both graphics contexts current. This looks a little weird, but is
+// necessary since we may be drawing from an accelerated to
+// non-accelerated context (e.g., printing), or vice versa. Note that it
+// only works because the context is actually the same underlying context
+// (or null), since we use one context for accelerated drawing. If that
+// assumption changes, we'll have to revisit this code.
+context->platformContext()->makeGrContextCurrent();
 m_context->platformContext()->makeGrContextCurrent();
-SkDevice* srcDevice = m_context->platformContext()->canvas()->getDevice();
-SkBitmap bitmap = srcDevice->accessBitmap(false);
-SkAutoLockPixels bitmapLock(bitmap);
-context->platformContext()->makeGrContextCurrent();
-RefPtr image = BitmapImageSingleFrameSkia::create(bitmap, context == m_context);
+RefPtr image = BitmapImageSingleFrameSkia::create(*m_data.m_platformContext.bitmap(), context == m_context);
 context->drawImage(image.get(), styleColorSpace, destRect, srcRect, op, useLowQualityScale);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92296] branches/chromium/835/Source/WebCore

[senorblanco]

Title: [92296] branches/chromium/835/Source/WebCore








Revision 92296
Author senorbla...@chromium.org
Date 2011-08-03 11:38:40 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 91870 - Fix for printing with accelerated 
https://bugs.webkit.org/show_bug.cgi?id=62406

Reviewed by James Robinson.

The platform-independent side of this should be covered by existing
tests.  Printing itself in Chrome has few tests, sadly.  :(

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):


TBR=senorbla...@chromium.org
Review URL: http://codereview.chromium.org/7564022

Modified Paths

branches/chromium/835/Source/WebCore/html/HTMLCanvasElement.cpp
branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/html/HTMLCanvasElement.cpp (92295 => 92296)

--- branches/chromium/835/Source/WebCore/html/HTMLCanvasElement.cpp	2011-08-03 18:38:26 UTC (rev 92295)
+++ branches/chromium/835/Source/WebCore/html/HTMLCanvasElement.cpp	2011-08-03 18:38:40 UTC (rev 92296)
@@ -281,7 +281,7 @@
 return;
 
 if (m_context) {
-if (!m_context->paintsIntoCanvasBuffer())
+if (!m_context->paintsIntoCanvasBuffer() && !document()->printing())
 return;
 m_context->paintRenderingResultsToCanvas();
 }


Modified: branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (92295 => 92296)

--- branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-08-03 18:38:26 UTC (rev 92295)
+++ branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-08-03 18:38:40 UTC (rev 92296)
@@ -112,8 +112,12 @@
 void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect,
CompositeOperator op, bool useLowQualityScale)
 {
+m_context->platformContext()->makeGrContextCurrent();
+SkDevice* srcDevice = m_context->platformContext()->canvas()->getDevice();
+SkBitmap bitmap = srcDevice->accessBitmap(false);
+SkAutoLockPixels bitmapLock(bitmap);
 context->platformContext()->makeGrContextCurrent();
-RefPtr image = BitmapImageSingleFrameSkia::create(*m_data.m_platformContext.bitmap(), context == m_context);
+RefPtr image = BitmapImageSingleFrameSkia::create(bitmap, context == m_context);
 context->drawImage(image.get(), styleColorSpace, destRect, srcRect, op, useLowQualityScale);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92295] trunk/Source/WebCore

[andersca]

Title: [92295] trunk/Source/WebCore








Revision 92295
Author ander...@apple.com
Date 2011-08-03 11:38:26 -0700 (Wed, 03 Aug 2011)


Log Message
WebCore images backing CG patterns should be released on the main thread
https://bugs.webkit.org/show_bug.cgi?id=65630

Reviewed by Sam Weinig.

* platform/graphics/cg/PatternCG.cpp:
(WebCore::patternReleaseOnMainThreadCallback):
Deref the image.

(WebCore::patternReleaseCallback):
Call callOnMainThread.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/PatternCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92294 => 92295)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 18:11:12 UTC (rev 92294)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 18:38:26 UTC (rev 92295)
@@ -1,3 +1,17 @@
+2011-08-03  Anders Carlsson  
+
+WebCore images backing CG patterns should be released on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=65630
+
+Reviewed by Sam Weinig.
+
+* platform/graphics/cg/PatternCG.cpp:
+(WebCore::patternReleaseOnMainThreadCallback):
+Deref the image.
+
+(WebCore::patternReleaseCallback):
+Call callOnMainThread.
+
 2011-08-03  Luke Macpherson   
 
 Use appropriate macro for CSSPropertyImageRendering.


Modified: trunk/Source/WebCore/platform/graphics/cg/PatternCG.cpp (92294 => 92295)

--- trunk/Source/WebCore/platform/graphics/cg/PatternCG.cpp	2011-08-03 18:11:12 UTC (rev 92294)
+++ trunk/Source/WebCore/platform/graphics/cg/PatternCG.cpp	2011-08-03 18:38:26 UTC (rev 92295)
@@ -29,8 +29,8 @@
 
 #include "AffineTransform.h"
 #include "GraphicsContext.h"
-
 #include 
+#include 
 
 namespace WebCore {
 
@@ -45,11 +45,16 @@
 CGContextDrawImage(context, rect, platformImage);
 }
 
-static void patternReleaseCallback(void* info)
+static void patternReleaseOnMainThreadCallback(void* info)
 {
 static_cast(info)->deref();
 }
 
+static void patternReleaseCallback(void* info)
+{
+callOnMainThread(patternReleaseOnMainThreadCallback, info);
+}
+
 CGPatternRef Pattern::createPlatformPattern(const AffineTransform& userSpaceTransformation) const
 {
 IntRect tileRect = tileImage()->rect();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92294] trunk/Tools

[dglazkov]

Title: [92294] trunk/Tools








Revision 92294
Author dglaz...@chromium.org
Date 2011-08-03 11:11:12 -0700 (Wed, 03 Aug 2011)


Log Message
Teach BuilderToPort to distinguish between Release and Debug builders.
https://bugs.webkit.org/show_bug.cgi?id=65628

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (92293 => 92294)

--- trunk/Tools/ChangeLog	2011-08-03 17:55:14 UTC (rev 92293)
+++ trunk/Tools/ChangeLog	2011-08-03 18:11:12 UTC (rev 92294)
@@ -1,3 +1,13 @@
+2011-08-03  Dimitri Glazkov  
+
+Teach BuilderToPort to distinguish between Release and Debug builders.
+https://bugs.webkit.org/show_bug.cgi?id=65628
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
+* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
+
 2011-08-03  Caio Marcelo de Oliveira Filho  
 
 [Qt] Fix running qmltests for WK2 in the bot


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (92293 => 92294)

--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-03 17:55:14 UTC (rev 92293)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-03 18:11:12 UTC (rev 92294)
@@ -43,8 +43,18 @@
 from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand
 
 
+class RebaseliningOptions(object):
+
+DEBUG_CONFIGURATION_REGEX = r"[d|D](ebu|b)g"
+
+def __init__(self, builder_name):
+self.configuration = "Debug" if re.search(self.DEBUG_CONFIGURATION_REGEX, builder_name) else "Release"
+self.builder_name = builder_name
+
+
 # FIXME: This logic should be moved to builders.py.
 class BuilderToPort(object):
+
 _builder_name_to_port_name = {
 # These builders are on build.webkit.org.
 r"SnowLeopard": "mac-snowleopard",
@@ -60,8 +70,8 @@
 r"Webkit Win$": "chromium-win-xp",
 r"Webkit Vista": "chromium-win-vista",
 r"Webkit Win7": "chromium-win-win7",
-r"Webkit Win \(dbg\)\(1\)": "chromium-win-win7",  # FIXME: Is this correct?
-r"Webkit Win \(dbg\)\(2\)": "chromium-win-win7",  # FIXME: Is this correct?
+r"Webkit Win \(dbg\)\(1\)": "chromium-win-xp",
+r"Webkit Win \(dbg\)\(2\)": "chromium-win-xp",
 r"Webkit Linux": "chromium-linux-x86_64",
 r"Webkit Linux 32": "chromium-linux-x86",
 r"Webkit Linux \(dbg\)\(1\)": "chromium-linux-x86_64",
@@ -81,7 +91,7 @@
 def port_for_builder(self, builder_name):
 port_name = self._port_name_for_builder_name(builder_name)
 assert(port_name)  # Need to update _builder_name_to_port_name
-port = factory.get(port_name)
+port = factory.get(port_name, RebaseliningOptions(builder_name))
 assert(port)  # Need to update _builder_name_to_port_name
 return port
 


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py (92293 => 92294)

--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py	2011-08-03 17:55:14 UTC (rev 92293)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py	2011-08-03 18:11:12 UTC (rev 92294)
@@ -56,4 +56,8 @@
 def test_port_for_builder(self):
 converter = BuilderToPort()
 port = converter.port_for_builder("Leopard Intel Debug (Tests)")
-self.assertEqual(port.name(), "mac-leopard")
+self.assertEqual(str(port.test_configuration()), "")
+port = converter.port_for_builder("Leopard Intel Release (Tests)")
+self.assertEqual(str(port.test_configuration()), "")
+port = converter.port_for_builder("Webkit Win (dbg)(1)")
+self.assertEqual(str(port.test_configuration()), "")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92292] trunk/Source/WebKit2

[andersca]

Title: [92292] trunk/Source/WebKit2








Revision 92292
Author ander...@apple.com
Date 2011-08-03 10:41:51 -0700 (Wed, 03 Aug 2011)


Log Message
Fix API tests.

Initialize threading before trying to allocate the WebContext.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::create):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92291 => 92292)

--- trunk/Source/WebKit2/ChangeLog	2011-08-03 17:22:50 UTC (rev 92291)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-03 17:41:51 UTC (rev 92292)
@@ -1,3 +1,13 @@
+2011-08-03  Anders Carlsson  
+
+Fix API tests.
+
+Initialize threading before trying to allocate the WebContext.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::sharedProcessContext):
+(WebKit::WebContext::create):
+
 2011-08-03  Pavel Feldman  
 
 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (92291 => 92292)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-08-03 17:22:50 UTC (rev 92291)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-08-03 17:41:51 UTC (rev 92292)
@@ -55,6 +55,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -74,6 +75,7 @@
 
 WebContext* WebContext::sharedProcessContext()
 {
+JSC::initializeThreading();
 WTF::initializeMainThread();
 RunLoop::initializeMainRunLoop();
 static WebContext* context = adoptRef(new WebContext(ProcessModelSharedSecondaryProcess, String())).leakRef();
@@ -89,6 +91,7 @@
 
 PassRefPtr WebContext::create(const String& injectedBundlePath)
 {
+JSC::initializeThreading();
 WTF::initializeMainThread();
 RunLoop::initializeMainRunLoop();
 return adoptRef(new WebContext(ProcessModelSecondaryProcess, injectedBundlePath));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92291] trunk/Source/WebKit/win

[aroben]

Title: [92291] trunk/Source/WebKit/win








Revision 92291
Author aro...@apple.com
Date 2011-08-03 10:22:50 -0700 (Wed, 03 Aug 2011)


Log Message
Windows nightly build fix after r91777

* Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the
interface to maintain binary compatibility with Safari 5.1.

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (92290 => 92291)

--- trunk/Source/WebKit/win/ChangeLog	2011-08-03 17:06:24 UTC (rev 92290)
+++ trunk/Source/WebKit/win/ChangeLog	2011-08-03 17:22:50 UTC (rev 92291)
@@ -1,3 +1,10 @@
+2011-08-03  Adam Roben  
+
+Windows nightly build fix after r91777
+
+* Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the
+interface to maintain binary compatibility with Safari 5.1.
+
 2011-08-03  Pavel Feldman  
 
 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.


Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl (92290 => 92291)

--- trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl	2011-08-03 17:06:24 UTC (rev 92290)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl	2011-08-03 17:22:50 UTC (rev 92291)
@@ -98,9 +98,6 @@
 HRESULT fantasyFontFamily([out, retval] BSTR* family);
 HRESULT setFantasyFontFamily([in] BSTR family);
 
-HRESULT pictographFontFamily([out, retval] BSTR* family);
-HRESULT setPictographFontFamily([in] BSTR family);
-
 HRESULT defaultFontSize([out, retval] int* fontSize);
 HRESULT setDefaultFontSize([in] int fontSize);
 
@@ -202,4 +199,7 @@
 
 HRESULT editingBehavior([out, retval] WebKitEditingBehavior* editingBehavior);
 HRESULT setEditingBehavior([in] WebKitEditingBehavior behavior);
+
+HRESULT pictographFontFamily([out, retval] BSTR* family);
+HRESULT setPictographFontFamily([in] BSTR family);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92290] trunk/LayoutTests

[andersca]

Title: [92290] trunk/LayoutTests








Revision 92290
Author ander...@apple.com
Date 2011-08-03 10:06:24 -0700 (Wed, 03 Aug 2011)


Log Message
Add a Mac Lion skipped list.

* platform/mac-lion: Added.
* platform/mac-lion/Skipped: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac-lion/
trunk/LayoutTests/platform/mac-lion/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (92289 => 92290)

--- trunk/LayoutTests/ChangeLog	2011-08-03 16:48:47 UTC (rev 92289)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 17:06:24 UTC (rev 92290)
@@ -1,3 +1,10 @@
+2011-08-03  Anders Carlsson  
+
+Add a Mac Lion skipped list.
+
+* platform/mac-lion: Added.
+* platform/mac-lion/Skipped: Added.
+
 2011-08-03  Stephen White  
 
 [chromium] Added two compositing tests whose pixel results on the


Added: trunk/LayoutTests/platform/mac-lion/Skipped (0 => 92290)

--- trunk/LayoutTests/platform/mac-lion/Skipped	(rev 0)
+++ trunk/LayoutTests/platform/mac-lion/Skipped	2011-08-03 17:06:24 UTC (rev 92290)
@@ -0,0 +1,15 @@
+# Failing due to minor differences between accelerated canvas and CG
+# 
+canvas/philip/tests/2d.gradient.interpolate.colouralpha.html
+
+# 
+canvas/philip/tests/2d.line.cap.round.html
+
+# 
+canvas/philip/tests/2d.shadow.enable.off.2.html
+
+# 
+canvas/philip/tests/2d.strokeRect.zero.5.html
+
+# Unknown test failures
+canvas/philip/tests/2d.text.draw.baseline.ideographic.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92289] trunk/Source/WebCore

[macpherson]

Title: [92289] trunk/Source/WebCore








Revision 92289
Author macpher...@chromium.org
Date 2011-08-03 09:48:47 -0700 (Wed, 03 Aug 2011)


Log Message
Use appropriate macro for CSSPropertyImageRendering.
https://bugs.webkit.org/show_bug.cgi?id=65594

Reviewed by Simon Fraser.

No new tests / trivial code cleanup only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92288 => 92289)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 16:48:23 UTC (rev 92288)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 16:48:47 UTC (rev 92289)
@@ -1,3 +1,16 @@
+2011-08-03  Luke Macpherson   
+
+Use appropriate macro for CSSPropertyImageRendering.
+https://bugs.webkit.org/show_bug.cgi?id=65594
+
+Reviewed by Simon Fraser.
+
+No new tests / trivial code cleanup only.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.
+
 2011-08-03  Dan Bernstein  
 
 FontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the last font is a custom font


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (92288 => 92289)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-03 16:48:23 UTC (rev 92288)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-03 16:48:47 UTC (rev 92289)
@@ -4425,9 +4425,7 @@
 return;
 }
 case CSSPropertyImageRendering:
-if (!primitiveValue)
-return;
-m_style->setImageRendering(*primitiveValue);
+HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(imageRendering, ImageRendering);
 return;
 case CSSPropertyTextShadow:
 case CSSPropertyBoxShadow:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92288] branches/chromium/835

[vsevik]

Title: [92288] branches/chromium/835








Revision 92288
Author vse...@chromium.org
Date 2011-08-03 09:48:23 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 92167 - Web Inspector: button + "New style rule"
https://bugs.webkit.org/show_bug.cgi?id=65409

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-add-new-rule.html

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

* inspector/styles/styles-add-new-rule-expected.txt: Added.
* inspector/styles/styles-add-new-rule.html: Added.

TBR=pfeld...@chromium.org
BUG=91217
Review URL: http://codereview.chromium.org/7566008

Modified Paths

branches/chromium/835/Source/WebCore/inspector/front-end/StylesSidebarPane.js


Added Paths

branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt
branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule.html




Diff

Copied: branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt (from rev 92167, trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt) (0 => 92288)

--- branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt	(rev 0)
+++ branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt	2011-08-03 16:48:23 UTC (rev 92288)
@@ -0,0 +1,26 @@
+Tests that adding a new rule works after sitching nodes.
+
+Text
+After adding new rule (inspected):
+[expanded] element.style { ()
+font-size: 12px;
+
+ Matched CSS Rules 
+[expanded] #inspected { (via inspector)
+
+[expanded] div { (user agent stylesheet)
+display: block;
+
+
+After adding new rule (other):
+[expanded] element.style { ()
+color: red;
+
+ Matched CSS Rules 
+[expanded] #other { (via inspector)
+
+[expanded] div { (user agent stylesheet)
+display: block;
+
+
+


Copied: branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule.html (from rev 92167, trunk/LayoutTests/inspector/styles/styles-add-new-rule.html) (0 => 92288)

--- branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule.html	(rev 0)
+++ branches/chromium/835/LayoutTests/inspector/styles/styles-add-new-rule.html	2011-08-03 16:48:23 UTC (rev 92288)
@@ -0,0 +1,54 @@
+
+
+
+
+function test()
+{
+WebInspector.showPanel("elements");
+InspectorTest.selectNodeAndWaitForStyles("inspected", step1);
+
+var treeElement;
+
+function step1()
+{
+// Click add new rule
+document.getElementById("add-style-button-test-id").click();
+InspectorTest.selectNodeAndWaitForStyles("other", step2);
+}
+
+function step2() {
+// Click add new rule
+document.getElementById("add-style-button-test-id").click();
+InspectorTest.selectNodeAndWaitForStyles("inspected", step3);
+}
+
+function step3()
+{
+InspectorTest.addResult("After adding new rule (inspected):");
+InspectorTest.dumpSelectedElementStyles(true, false, true);
+InspectorTest.selectNodeAndWaitForStyles("other", step4);
+}
+
+function step4()
+{
+InspectorTest.addResult("After adding new rule (other):");
+InspectorTest.dumpSelectedElementStyles(true, false, true);
+InspectorTest.completeTest();
+}
+}
+
+
+
+
+
+
+Tests that adding a new rule works after sitching nodes.
+
+
+Text
+
+
+
+


Modified: branches/chromium/835/Source/WebCore/inspector/front-end/StylesSidebarPane.js (92287 => 92288)

--- branches/chromium/835/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2011-08-03 16:46:13 UTC (rev 92287)
+++ branches/chromium/835/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2011-08-03 16:48:23 UTC (rev 92288)
@@ -71,6 +71,7 @@
 
 var addButton = document.createElement("button");
 addButton.className = "pane-title-button add";
+addButton.id = "add-style-button-test-id";
 addButton.title = WebInspector.UIString("New Style Rule");
 addButton.addEventListener("click", this._createNewRule.bind(this), false);
 this.titleElement.appendChild(addButton);
@@ -1285,24 +1286,23 @@
 
 editingSelectorCommitted: function(element, newContent, oldContent, context)
 {
-var self = this;
 function successCallback(newRule, doesSelectorAffectSelectedNode)
 {
-var styleRule = { section: self, style: newRule.style, selectorText: newRule.selectorText, sourceURL: newRule.sourceURL, rule: newRule };
-self.makeNormal(styleRule);
+var styleRule = { section: this, style: newRule.style, selectorText: newRule.selectorText, sourceURL: newRule.sourceURL, rule: newRule };
+this.makeNormal(styleRule);
 
 if (!doesSelectorAffectSelectedNode) {
-self.noAffect = true;
-self.element.addStyleClass("no-affect");
+  

[webkit-changes] [92287] trunk/Source/WebCore

[mitz]

Title: [92287] trunk/Source/WebCore








Revision 92287
Author m...@apple.com
Date 2011-08-03 09:46:13 -0700 (Wed, 03 Aug 2011)


Log Message
FontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the last font is a custom font
https://bugs.webkit.org/show_bug.cgi?id=65597

Reviewed by Simon Fraser.

No test added because behavior is unchanged, but this saves a call to getFontData().

* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getFontData): Eliminated early return inside the loop, allowing execution
to continue and familyIndex to be set.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92286 => 92287)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 16:27:35 UTC (rev 92286)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 16:46:13 UTC (rev 92287)
@@ -1,3 +1,16 @@
+2011-08-03  Dan Bernstein  
+
+FontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the last font is a custom font
+https://bugs.webkit.org/show_bug.cgi?id=65597
+
+Reviewed by Simon Fraser.
+
+No test added because behavior is unchanged, but this saves a call to getFontData().
+
+* platform/graphics/FontCache.cpp:
+(WebCore::FontCache::getFontData): Eliminated early return inside the loop, allowing execution
+to continue and familyIndex to be set.
+
 2011-08-03  Ryosuke Niwa  
 
 Add RenderedPosition


Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (92286 => 92287)

--- trunk/Source/WebCore/platform/graphics/FontCache.cpp	2011-08-03 16:27:35 UTC (rev 92286)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp	2011-08-03 16:46:13 UTC (rev 92287)
@@ -394,7 +394,7 @@
 
 const FontData* FontCache::getFontData(const Font& font, int& familyIndex, FontSelector* fontSelector)
 {
-SimpleFontData* result = 0;
+FontData* result = 0;
 
 int startIndex = familyIndex;
 const FontFamily* startFamily = &font.fontDescription().family();
@@ -404,12 +404,11 @@
 while (currFamily && !result) {
 familyIndex++;
 if (currFamily->family().length()) {
-if (fontSelector) {
-FontData* data = "" currFamily->family());
-if (data)
-return data;
-}
-result = getCachedFontData(font.fontDescription(), currFamily->family());
+if (fontSelector)
+result = fontSelector->getFontData(font.fontDescription(), currFamily->family());
+
+if (!result)
+result = getCachedFontData(font.fontDescription(), currFamily->family());
 }
 currFamily = currFamily->next();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92286] trunk/Source/WebCore

[rniwa]

Title: [92286] trunk/Source/WebCore








Revision 92286
Author rn...@webkit.org
Date 2011-08-03 09:27:35 -0700 (Wed, 03 Aug 2011)


Log Message
Add RenderedPosition
https://bugs.webkit.org/show_bug.cgi?id=65221

Reviewed by Hajime Morita.

Add the skeleton for RenderedPosition and use it in rootBoxForLine.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/EditingAllInOne.cpp:
* editing/RenderedPosition.cpp: Added.
(WebCore::RenderedPosition::RenderedPosition):
* editing/RenderedPosition.h: Added.
(WebCore::RenderedPosition::isNull):
(WebCore::RenderedPosition::rootBox):
(WebCore::RenderedPosition::RenderedPosition):
* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::logicalStartPositionForLine):
(WebCore::logicalEndPositionForLine):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/EditingAllInOne.cpp
trunk/Source/WebCore/editing/visible_units.cpp


Added Paths

trunk/Source/WebCore/editing/RenderedPosition.cpp
trunk/Source/WebCore/editing/RenderedPosition.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (92285 => 92286)

--- trunk/Source/WebCore/CMakeLists.txt	2011-08-03 16:15:21 UTC (rev 92285)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-08-03 16:27:35 UTC (rev 92286)
@@ -635,6 +635,7 @@
 editing/RemoveFormatCommand.cpp
 editing/RemoveNodeCommand.cpp
 editing/RemoveNodePreservingChildrenCommand.cpp
+editing/RenderedPosition.cpp
 editing/ReplaceNodeWithSpanCommand.cpp
 editing/ReplaceSelectionCommand.cpp
 editing/SetNodeAttributeCommand.cpp


Modified: trunk/Source/WebCore/ChangeLog (92285 => 92286)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 16:15:21 UTC (rev 92285)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 16:27:35 UTC (rev 92286)
@@ -1,3 +1,31 @@
+2011-08-03  Ryosuke Niwa  
+
+Add RenderedPosition
+https://bugs.webkit.org/show_bug.cgi?id=65221
+
+Reviewed by Hajime Morita.
+
+Add the skeleton for RenderedPosition and use it in rootBoxForLine.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* WebCore.gypi:
+* WebCore.pro:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* editing/EditingAllInOne.cpp:
+* editing/RenderedPosition.cpp: Added.
+(WebCore::RenderedPosition::RenderedPosition):
+* editing/RenderedPosition.h: Added.
+(WebCore::RenderedPosition::isNull):
+(WebCore::RenderedPosition::rootBox):
+(WebCore::RenderedPosition::RenderedPosition):
+* editing/visible_units.cpp:
+(WebCore::startPositionForLine):
+(WebCore::endPositionForLine):
+(WebCore::logicalStartPositionForLine):
+(WebCore::logicalEndPositionForLine):
+
 2011-08-03  Roland Steiner  
 
 [V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement


Modified: trunk/Source/WebCore/GNUmakefile.list.am (92285 => 92286)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-08-03 16:15:21 UTC (rev 92285)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-08-03 16:27:35 UTC (rev 92286)
@@ -1398,6 +1398,8 @@
 	Source/WebCore/editing/RemoveNodeCommand.h \
 	Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp \
 	Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h \
+	Source/WebCore/editing/RenderedPosition.cpp \
+	Source/WebCore/editing/RenderedPosition.h \
 	Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp \
 	Source/WebCore/editing/ReplaceNodeWithSpanCommand.h \
 	Source/WebCore/editing/ReplaceSelectionCommand.cpp \


Modified: trunk/Source/WebCore/WebCore.gypi (92285 => 92286)

--- trunk/Source/WebCore/WebCore.gypi	2011-08-03 16:15:21 UTC (rev 92285)
+++ trunk/Source/WebCore/WebCore.gypi	2011-08-03 16:27:35 UTC (rev 92286)
@@ -2476,6 +2476,8 @@
 'editing/RemoveNodeCommand.h',
 'editing/RemoveNodePreservingChildrenCommand.cpp',
 'editing/RemoveNodePreservingChildrenCommand.h',
+'editing/RenderedPosition.cpp',
+'editing/RenderedPosition.h',
 'editing/ReplaceNodeWithSpanCommand.cpp',
 'editing/ReplaceNodeWithSpanCommand.h',
 'editing/ReplaceSelectionCommand.cpp',


Modified: trunk/Source/WebCore/WebCore.pro (92285 => 92286)

--- trunk/Source/WebCore/WebCore.pro	2011-08-03 16:15:21 UTC (rev 92285)
+++ trunk/Source/WebCore/WebCore.pro	2011-08-03 16:27:35 UTC (rev 92286)
@@ -598,6 +598,7 @@
 editing/RemoveFormatCommand.cpp \
 editing/RemoveNodeCommand.cpp \
 editing/RemoveNodePreservingChildrenCommand.cpp \
+editing/RenderedPosit

[webkit-changes] [92285] trunk/Source/WebCore

[rolandsteiner]

Title: [92285] trunk/Source/WebCore








Revision 92285
Author rolandstei...@chromium.org
Date 2011-08-03 09:15:21 -0700 (Wed, 03 Aug 2011)


Log Message
[V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement
https://bugs.webkit.org/show_bug.cgi?id=65598

Reviewed by Dimitri Glazkov.

Added UNKNOWN_RULE to the switch statement.

No new tests. (No semantic change)

* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92284 => 92285)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 16:11:21 UTC (rev 92284)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 16:15:21 UTC (rev 92285)
@@ -1,3 +1,17 @@
+2011-08-03  Roland Steiner  
+
+[V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement
+https://bugs.webkit.org/show_bug.cgi?id=65598
+
+Reviewed by Dimitri Glazkov.
+
+Added UNKNOWN_RULE to the switch statement.
+
+No new tests. (No semantic change)
+
+* bindings/v8/custom/V8CSSRuleCustom.cpp:
+(WebCore::toV8):
+
 2011-08-03  Pavel Feldman  
 
 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.


Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp (92284 => 92285)

--- trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp	2011-08-03 16:11:21 UTC (rev 92284)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp	2011-08-03 16:15:21 UTC (rev 92285)
@@ -47,6 +47,11 @@
 if (!impl)
 return v8::Null();
 switch (impl->type()) {
+case CSSRule::UNKNOWN_RULE:
+// CSSUnknownRule.idl is explicitly excluded as it doesn't add anything
+// over CSSRule.idl (see WebCore.gyp/WebCore.gyp: 'bindings_idl_files').
+// -> Use the base class wrapper here.
+return V8CSSRule::wrap(impl);
 case CSSRule::STYLE_RULE:
 return toV8(static_cast(impl));
 case CSSRule::CHARSET_RULE:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92284] trunk/Source

[pfeldman]

Title: [92284] trunk/Source








Revision 92284
Author pfeld...@chromium.org
Date 2011-08-03 09:11:21 -0700 (Wed, 03 Aug 2011)


Log Message
Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
https://bugs.webkit.org/show_bug.cgi?id=65510

Reviewed by Yury Semikhatsky.

Source/WebCore:

* WebCore.exp.in:
* WebCore.order:
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawRectHighlight):
* inspector/DOMNodeHighlighter.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::drawHighlight):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.set hovered):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightRect):
(WebInspector.TimelinePanel.prototype._hideRectHighlight):
* inspector/front-end/inspector.js:
(WebInspector.highlightDOMNode):

Source/WebKit/chromium:

* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::paintPageOverlay):

Source/WebKit/gtk:

* webkit/webkitwebview.cpp:
(paintWebView):

Source/WebKit/mac:

* WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView drawRect:]):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFramePrivate::renderRelativeCoords):

Source/WebKit/win:

* WebNodeHighlight.cpp:
(WebNodeHighlight::update):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::drawRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.order
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp
trunk/Source/WebCore/inspector/DOMNodeHighlighter.h
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorController.h
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
trunk/Source/WebCore/inspector/front-end/Popover.js
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/inspector.js
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm
trunk/Source/WebKit/qt/Api/qwebframe.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebNodeHighlight.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92283 => 92284)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 15:49:28 UTC (rev 92283)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 16:11:21 UTC (rev 92284)
@@ -1,5 +1,38 @@
 2011-08-03  Pavel Feldman  
 
+Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
+https://bugs.webkit.org/show_bug.cgi?id=65510
+
+Reviewed by Yury Semikhatsky.
+
+* WebCore.exp.in:
+* WebCore.order:
+* inspector/DOMNodeHighlighter.cpp:
+(WebCore::DOMNodeHighlighter::drawRectHighlight):
+* inspector/DOMNodeHighlighter.h:
+* inspector/Inspector.json:
+* inspector/InspectorController.cpp:
+(WebCore::InspectorController::drawHighlight):
+* inspector/InspectorController.h:
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::highlightRect):
+(WebCore::InspectorDOMAgent::hideHighlight):
+(WebCore::InspectorDOMAgent::drawHighlight):
+* inspector/InspectorDOMAgent.h:
+* inspector/front-end/ResourcesPanel.js:
+(WebInspector.FrameTreeElement.prototype.onselect):
+(WebInspector.FrameTreeElement.prototype.set hovered):
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel):
+(WebInspector.TimelinePanel.prototype._mouseOut):
+(WebInspector.TimelinePanel.prototype._mouseMove):
+(WebInspector.TimelinePanel.prototype._highlightRect):
+(WebInspector.TimelinePanel.prototype._hideRectHighlight):
+* inspector/front-end/inspector.js:
+(WebInspector.highlightDOMNode):
+
+2011-08-03  Pavel Feldman  
+
 Web Inspector: make text in popover selectable + make popover re-appear faster.
 https://bugs.webkit.org/show_bug.cgi?id=65603
 


Modified: trunk/Source/WebCo

[webkit-changes] [92283] trunk/Tools

[caio . oliveira]

Title: [92283] trunk/Tools








Revision 92283
Author caio.olive...@openbossa.org
Date 2011-08-03 08:49:28 -0700 (Wed, 03 Aug 2011)


Log Message
[Qt] Fix running qmltests for WK2 in the bot
https://bugs.webkit.org/show_bug.cgi?id=65621

Reviewed by Csaba Osztrogonác.

The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
but now there's the case for WK2 UIProcess tests as well.

* Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-qtwebkit-tests




Diff

Modified: trunk/Tools/ChangeLog (92282 => 92283)

--- trunk/Tools/ChangeLog	2011-08-03 15:33:37 UTC (rev 92282)
+++ trunk/Tools/ChangeLog	2011-08-03 15:49:28 UTC (rev 92283)
@@ -1,3 +1,15 @@
+2011-08-03  Caio Marcelo de Oliveira Filho  
+
+[Qt] Fix running qmltests for WK2 in the bot
+https://bugs.webkit.org/show_bug.cgi?id=65621
+
+Reviewed by Csaba Osztrogonác.
+
+The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
+but now there's the case for WK2 UIProcess tests as well.
+
+* Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
+
 2011-08-02  Dimitri Glazkov  
 
 Add a way to edit test expectations.


Modified: trunk/Tools/Scripts/run-qtwebkit-tests (92282 => 92283)

--- trunk/Tools/Scripts/run-qtwebkit-tests	2011-08-03 15:33:37 UTC (rev 92282)
+++ trunk/Tools/Scripts/run-qtwebkit-tests	2011-08-03 15:49:28 UTC (rev 92283)
@@ -206,9 +206,12 @@
 self._Pool = Pool
 
 def run(self):
-""" We need to set this system variable in order to load the proper plugin for the qml tests """
-os.putenv("QML_IMPORT_PATH", self._options.path + "../../../imports")
 """ Find && execute && publish results of all test. "All in one" function. """
+# This is needed for Qt finding our QML modules. The current code makes our
+# two existing API tests (WK1 API and WK2 UI process API) work correctly.
+qml_import_path = self._options.path + "../../../imports"
+qml_import_path += ":" + self._options.path + "../../../../../imports"
+os.putenv("QML_IMPORT_PATH", qml_import_path)
 self.debug("Searching executables...")
 tests_executables = self.find_tests_paths(self._options.path)
 self.debug("Found: %s", len(tests_executables))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92282] trunk/Tools

[dglazkov]

Title: [92282] trunk/Tools








Revision 92282
Author dglaz...@chromium.org
Date 2011-08-03 08:33:37 -0700 (Wed, 03 Aug 2011)


Log Message
Add a way to edit test expectations.
https://bugs.webkit.org/show_bug.cgi?id=64922

Implements a TestExpectationsEditor, which provides a standard way to
update and remove test expectations.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
enchilada.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (92281 => 92282)

--- trunk/Tools/ChangeLog	2011-08-03 15:30:26 UTC (rev 92281)
+++ trunk/Tools/ChangeLog	2011-08-03 15:33:37 UTC (rev 92282)
@@ -1,3 +1,18 @@
+2011-08-02  Dimitri Glazkov  
+
+Add a way to edit test expectations.
+https://bugs.webkit.org/show_bug.cgi?id=64922
+
+Implements a TestExpectationsEditor, which provides a standard way to
+update and remove test expectations.
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
+added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
+enchilada.
+* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
+
 2011-08-03  Andreas Kling  
 
 [Qt] MiniBrowser: Unbreak load progress indication.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (92281 => 92282)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2011-08-03 15:30:26 UTC (rev 92281)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2011-08-03 15:33:37 UTC (rev 92282)
@@ -119,7 +119,7 @@
 return 'ParseError(fatal=%s, errors=%s)' % (self.fatal, self.errors)
 
 
-class TestExpectationSerializer:
+class TestExpectationSerializer(object):
 """Provides means of serializing TestExpectationLine instances."""
 def __init__(self, test_configuration_converter):
 self._test_configuration_converter = test_configuration_converter
@@ -139,7 +139,7 @@
 modifiers = self._parsed_modifier_string(expectation_line, specifiers)
 expectations = self._parsed_expectations_string(expectation_line)
 result.append(self._format_result(modifiers, expectation_line.name, expectations, expectation_line.comment))
-return "\n".join(result)
+return "\n".join(result) if result else None
 
 return self._format_result(" ".join(expectation_line.modifiers), expectation_line.name, " ".join(expectation_line.expectations), expectation_line.comment)
 
@@ -166,12 +166,12 @@
 return result
 
 @classmethod
-def list_to_string(cls, expectations, test_configuration_converter):
+def list_to_string(cls, expectation_lines, test_configuration_converter):
 serializer = cls(test_configuration_converter)
-return "\n".join([serializer.to_string(expectation) for expectation in expectations])
+return "\n".join([line for line in [serializer.to_string(expectation_line) for expectation_line in expectation_lines] if line is not None])
 
 
-class TestExpectationParser:
+class TestExpectationParser(object):
 """Provides parsing facilities for lines in the test_expectation.txt file."""
 
 BUG_MODIFIER_PREFIX = 'bug'
@@ -185,7 +185,7 @@
 
 def __init__(self, port, full_test_list, allow_rebaseline_modifier):
 self._port = port
-self._test_configuration_converter = TestConfigurationConverter(port.all_test_configurations(), port.configuration_specifier_macros())
+self._test_configuration_converter = TestConfigurationConverter(set(port.all_test_configurations()), port.configuration_specifier_macros())
 self._full_test_list = full_test_list
 self._allow_rebaseline_modifier = allow_rebaseline_modifier
 
@@ -359,6 +359,9 @@
 def is_invalid(self):
 return self.is_malformed() or len(self.warnings) > 0
 
+def is_flaky(self):
+return len(self.parsed_expectations) > 1
+
 @classmethod
 def create_passing_expectation(cls, test):
 expectation_line = TestExpectationLine()
@@ -370,7 +373,7 @@
 
 
 # FIXME: Refactor API to be a proper CRUD.
-class TestExpectationsModel:
+class TestExpectationsModel(object):
 """Represents relational sto

[webkit-changes] [92281] trunk/LayoutTests

[senorblanco]

Title: [92281] trunk/LayoutTests








Revision 92281
Author senorbla...@chromium.org
Date 2011-08-03 08:30:26 -0700 (Wed, 03 Aug 2011)


Log Message
[chromium] Added two compositing tests whose pixel results on the
Mesa bots are different following
http://trac.webkit.org/changeset/92255.

Unreviewed.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92280 => 92281)

--- trunk/LayoutTests/ChangeLog	2011-08-03 15:09:52 UTC (rev 92280)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 15:30:26 UTC (rev 92281)
@@ -1,3 +1,13 @@
+2011-08-03  Stephen White  
+
+[chromium] Added two compositing tests whose pixel results on the
+Mesa bots are different following
+http://trac.webkit.org/changeset/92255.
+
+Unreviewed.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-03  Philippe Normand  
 
 Unreviewed, GTK baselines for media/media-controls-clone.html.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92280 => 92281)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 15:09:52 UTC (rev 92280)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 15:30:26 UTC (rev 92281)
@@ -2739,7 +2739,8 @@
 BUGWK64942 GPU WIN MAC : platform/chromium/compositing/layout-width-change.html = IMAGE
 BUGWK64942 GPU : platform/chromium/compositing/perpendicular-layer-sorting.html = IMAGE
 BUGWK64942 GPU : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE
-BUGWK64942 GPU MAC : compositing/geometry/horizontal-scroll-composited.html = IMAGE
+BUGWK64942 GPU WIN MAC : compositing/geometry/horizontal-scroll-composited.html = IMAGE
+BUGWK64942 GPU WIN : compositing/iframes/composited-iframe-alignment.html = IMAGE
 
 BUGCR72223 : media/video-frame-accurate-seek.html = IMAGE PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92280] trunk/Source/WebCore

[pfeldman]

Title: [92280] trunk/Source/WebCore








Revision 92280
Author pfeld...@chromium.org
Date 2011-08-03 08:09:52 -0700 (Wed, 03 Aug 2011)


Log Message
Web Inspector: make text in popover selectable + make popover re-appear faster.
https://bugs.webkit.org/show_bug.cgi?id=65603

Reviewed by Yury Semikhatsky.

* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype.setTimeout):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._handleMouseAction):
* inspector/front-end/popover.css:
(.popover .content):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Popover.js
trunk/Source/WebCore/inspector/front-end/popover.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (92279 => 92280)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 14:40:10 UTC (rev 92279)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 15:09:52 UTC (rev 92280)
@@ -1,3 +1,17 @@
+2011-08-03  Pavel Feldman  
+
+Web Inspector: make text in popover selectable + make popover re-appear faster.
+https://bugs.webkit.org/show_bug.cgi?id=65603
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/Popover.js:
+(WebInspector.PopoverHelper.prototype.setTimeout):
+(WebInspector.PopoverHelper.prototype._mouseMove):
+(WebInspector.PopoverHelper.prototype._handleMouseAction):
+* inspector/front-end/popover.css:
+(.popover .content):
+
 2011-08-03  Vsevolod Vlasov  
 
 Web Inspector: Console scroll position should be saved when switching panels.


Modified: trunk/Source/WebCore/inspector/front-end/Popover.js (92279 => 92280)

--- trunk/Source/WebCore/inspector/front-end/Popover.js	2011-08-03 14:40:10 UTC (rev 92279)
+++ trunk/Source/WebCore/inspector/front-end/Popover.js	2011-08-03 15:09:52 UTC (rev 92280)
@@ -171,7 +171,7 @@
 WebInspector.PopoverHelper.prototype = {
 setTimeout: function(timeout)
 {
- this._timeout = timeout;
+this._timeout = timeout;
 },
 
 _mouseDown: function(event)
@@ -186,7 +186,7 @@
 if (this._hoverElement === event.target || (this._hoverElement && this._hoverElement.isAncestor(event.target)))
 return;
 
-// User has 500ms (this._timeout / 2) to reach the popup.
+// User has 250ms (this._timeout / 4) to reach the popup.
 if (this._popup && !this._hidePopupTimer) {
 var self = this;
 function doHide()
@@ -194,7 +194,7 @@
 self._hidePopup();
 delete self._hidePopupTimer;
 }
-this._hidePopupTimer = setTimeout(doHide, this._timeout / 2);
+this._hidePopupTimer = setTimeout(doHide, this._timeout / 4);
 }
 
 this._handleMouseAction(event);
@@ -208,7 +208,7 @@
 if (!this._hoverElement)
 return;
 
-const toolTipDelay = isMouseDown ? 0 : (this._popup ? this._timeout * 0.6 : this._timeout);
+const toolTipDelay = isMouseDown ? 0 : (this._popup ? this._timeout * 0.3 : this._timeout);
 this._hoverTimer = setTimeout(this._mouseHover.bind(this, this._hoverElement), toolTipDelay);
 },
 


Modified: trunk/Source/WebCore/inspector/front-end/popover.css (92279 => 92280)

--- trunk/Source/WebCore/inspector/front-end/popover.css	2011-08-03 14:40:10 UTC (rev 92279)
+++ trunk/Source/WebCore/inspector/front-end/popover.css	2011-08-03 15:09:52 UTC (rev 92280)
@@ -14,6 +14,7 @@
 right: 0;
 pointer-events: auto;
 overflow: auto;
+-webkit-user-select: text;
 }
 
 .popover .arrow {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92279] trunk/LayoutTests

[philn]

Title: [92279] trunk/LayoutTests








Revision 92279
Author ph...@webkit.org
Date 2011-08-03 07:40:10 -0700 (Wed, 03 Aug 2011)


Log Message
Unreviewed, GTK baselines for media/media-controls-clone.html.

* platform/gtk/media/media-controls-clone-expected.png: Added.
* platform/gtk/media/media-controls-clone-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.png
trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92278 => 92279)

--- trunk/LayoutTests/ChangeLog	2011-08-03 14:33:18 UTC (rev 92278)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 14:40:10 UTC (rev 92279)
@@ -1,3 +1,10 @@
+2011-08-03  Philippe Normand  
+
+Unreviewed, GTK baselines for media/media-controls-clone.html.
+
+* platform/gtk/media/media-controls-clone-expected.png: Added.
+* platform/gtk/media/media-controls-clone-expected.txt: Added.
+
 2011-08-03  Kent Tamura  
 
 [Chromium] Remove flaky failures of fast/speech/input-appearance-*.html.


Added: trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.txt (0 => 92279)

--- trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/media/media-controls-clone-expected.txt	2011-08-03 14:40:10 UTC (rev 92279)
@@ -0,0 +1,93 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x324
+  RenderBlock {HTML} at (0,0) size 800x324
+RenderBody {BODY} at (8,8) size 784x308
+  RenderBlock {DIV} at (0,0) size 784x154
+RenderMedia {AUDIO} at (300,130) size 300x20
+  RenderBlock {DIV} at (0,154) size 784x154
+RenderMedia {AUDIO} at (300,130) size 300x20
+layer at (8,8) size 300x150
+  RenderVideo {VIDEO} at (0,0) size 300x150
+layer at (8,162) size 300x150
+  RenderVideo {VIDEO} at (0,0) size 300x150
+layer at (8,8) size 300x150
+  RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
+layer at (8,8) size 300x150 scrollHeight 161
+  RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,0) size 300x150
+RenderButton {INPUT} at (0,130) size 20x20
+RenderDeprecatedFlexibleBox {DIV} at (20,130) size 220x20 [border: (1px solid #FF33) none (1px solid #FF33)]
+  RenderBlock (anonymous) at (1,0) size 65x31
+RenderDeprecatedFlexibleBox {DIV} at (0,1) size 65x30
+  RenderBlock (anonymous) at (5,5) size 55x20
+RenderText {#text} at (0,0) size 55x12
+  text run at (0,0) width 55: "00:00 / 00:00"
+  RenderSlider {INPUT} at (66,0) size 153x20
+RenderDeprecatedFlexibleBox {DIV} at (2,0) size 149x20
+  RenderBlock {DIV} at (0,4) size 137x12
+  RenderBlock {DIV} at (137,4) size 12x12
+RenderButton {INPUT} at (240,130) size 20x20
+RenderButton {INPUT} at (260,130) size 20x20
+RenderButton {INPUT} at (280,130) size 20x20
+layer at (96,142) size 12x12
+  RenderBlock (relative positioned) {DIV} at (0,0) size 12x12
+layer at (308,138) size 300x20
+  RenderBlock (relative positioned) {DIV} at (0,0) size 300x20
+layer at (308,138) size 300x20 scrollHeight 31
+  RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,0) size 300x20
+RenderButton {INPUT} at (0,0) size 20x20
+RenderDeprecatedFlexibleBox {DIV} at (20,0) size 220x20 [border: (1px solid #FF33) none (1px solid #FF33)]
+  RenderBlock (anonymous) at (1,0) size 65x31
+RenderDeprecatedFlexibleBox {DIV} at (0,1) size 65x30
+  RenderBlock (anonymous) at (5,5) size 55x20
+RenderText {#text} at (0,0) size 55x12
+  text run at (0,0) width 55: "00:00 / 00:00"
+  RenderSlider {INPUT} at (66,0) size 153x20
+RenderDeprecatedFlexibleBox {DIV} at (2,0) size 149x20
+  RenderBlock {DIV} at (0,4) size 137x12
+  RenderBlock {DIV} at (137,4) size 12x12
+RenderButton {INPUT} at (240,0) size 20x20
+RenderButton {INPUT} at (260,0) size 20x20
+RenderButton {INPUT} at (280,0) size 20x20
+layer at (396,142) size 12x12
+  RenderBlock (relative positioned) {DIV} at (0,0) size 12x12
+layer at (8,162) size 300x150
+  RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
+layer at (8,162) size 300x150 scrollHeight 161
+  RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,0) size 300x150
+RenderButton {INPUT} at (0,130) size 20x20
+RenderDeprecatedFlexibleBox {DIV} at (20,130) size 220x20 [border: (1px solid #FF33) none (1px solid #FF33)]
+  RenderBlock (anonymous) at (1,0) size 65x31
+RenderDeprecatedFlexible

[webkit-changes] [92278] trunk/Source/WebCore

[vsevik]

Title: [92278] trunk/Source/WebCore








Revision 92278
Author vse...@chromium.org
Date 2011-08-03 07:33:18 -0700 (Wed, 03 Aug 2011)


Log Message
Web Inspector: Console scroll position should be saved when switching panels.
https://bugs.webkit.org/show_bug.cgi?id=65607

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleView.prototype.get scrollLeft):
(WebInspector.ConsoleView.prototype.set scrollLeft):
(WebInspector.ConsoleView.prototype.get scrollTop):
(WebInspector.ConsoleView.prototype.set scrollTop):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype._endStatusBarDragging):
(WebInspector.Drawer.prototype.get scrollLeft):
(WebInspector.Drawer.prototype.set scrollLeft):
(WebInspector.Drawer.prototype.get scrollTop):
(WebInspector.Drawer.prototype.set scrollTop):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/Drawer.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (92277 => 92278)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 14:25:23 UTC (rev 92277)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 14:33:18 UTC (rev 92278)
@@ -1,3 +1,24 @@
+2011-08-03  Vsevolod Vlasov  
+
+Web Inspector: Console scroll position should be saved when switching panels.
+https://bugs.webkit.org/show_bug.cgi?id=65607
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
+(WebInspector.ConsoleView.prototype.get scrollLeft):
+(WebInspector.ConsoleView.prototype.set scrollLeft):
+(WebInspector.ConsoleView.prototype.get scrollTop):
+(WebInspector.ConsoleView.prototype.set scrollTop):
+* inspector/front-end/Drawer.js:
+(WebInspector.Drawer.prototype.show):
+(WebInspector.Drawer.prototype._endStatusBarDragging):
+(WebInspector.Drawer.prototype.get scrollLeft):
+(WebInspector.Drawer.prototype.set scrollLeft):
+(WebInspector.Drawer.prototype.get scrollTop):
+(WebInspector.Drawer.prototype.set scrollTop):
+
 2011-08-03  Philippe Normand  
 
 libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed


Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (92277 => 92278)

--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-08-03 14:25:23 UTC (rev 92277)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-08-03 14:33:18 UTC (rev 92278)
@@ -739,6 +739,26 @@
 {
 // Prevent infinite expansion of cross-referencing arrays.
 return this._format(output, output.subtype && output.subtype === "array");
+},
+
+get scrollLeft()
+{
+return this.messagesElement.scrollLeft;
+},
+
+set scrollLeft(scrollLeft)
+{
+this.messagesElement.scrollLeft = scrollLeft;
+},
+
+get scrollTop()
+{
+return this.messagesElement.scrollTop;
+},
+
+set scrollTop(scrollTop)
+{
+this.messagesElement.scrollTop = scrollTop;
 }
 }
 


Modified: trunk/Source/WebCore/inspector/front-end/Drawer.js (92277 => 92278)

--- trunk/Source/WebCore/inspector/front-end/Drawer.js	2011-08-03 14:25:23 UTC (rev 92277)
+++ trunk/Source/WebCore/inspector/front-end/Drawer.js	2011-08-03 14:33:18 UTC (rev 92278)
@@ -134,6 +134,7 @@
 }
 
 this._currentAnimation = WebInspector.animateStyle(animations, this._animationDuration(), animationFinished.bind(this));
+this.restoreScrollPositions();
 },
 
 hide: function()
@@ -358,6 +359,28 @@
 delete this._statusBarDragOffset;
 
 event.stopPropagation();
+},
+
+get scrollLeft()
+{
+return this.visibleView ? this.visibleView.scrollLeft : 0;
+},
+
+set scrollLeft(scrollLeft)
+{
+if (this.visibleView)
+this.visibleView.scrollLeft = scrollLeft;
+},
+
+get scrollTop()
+{
+return this.visibleView ? this.visibleView.scrollTop : 0;
+},
+
+set scrollTop(scrollTop)
+{
+if (this.visibleView)
+this.visibleView.scrollTop = scrollTop;
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92277] trunk

[caio . oliveira]

Title: [92277] trunk








Revision 92277
Author caio.olive...@openbossa.org
Date 2011-08-03 07:25:23 -0700 (Wed, 03 Aug 2011)


Log Message
[Qt] [WK2] Expose web view classes to QML
https://bugs.webkit.org/show_bug.cgi?id=65339

Reviewed by Benjamin Poulain.

.:

* Source/WebKit.pro: Include QML plugin subdir in the build system for WK2.

Source/WebKit2:

This patch also uses QuickTest from QtDeclarative to provide the basic autotest
infrastructure for the exposed elements.

* UIProcess/API/qt/qmlplugin/plugin.cpp: Added.
(WebKit2QmlPlugin::registerTypes):
* UIProcess/API/qt/qmlplugin/qmldir: Added.
* UIProcess/API/qt/qmlplugin/qmlplugin.pro: Added.
* UIProcess/API/qt/qtouchwebpage.h: Expose load() to QML environment.
* UIProcess/API/qt/qtouchwebview.h: Since QTouchWebPage* doesn't change once set
in the constructor, we mark the page property as CONSTANT. This avoid QML
warnings for not having a NOTIFY signal for the property change.

* UIProcess/API/qt/tests/tests.pro:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Added.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/test1.html: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro: Added.
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Added.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit.pro
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pro


Added Paths

trunk/Source/WebKit2/UIProcess/API/qt/qmlplugin/
trunk/Source/WebKit2/UIProcess/API/qt/qmlplugin/plugin.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qmlplugin/qmldir
trunk/Source/WebKit2/UIProcess/API/qt/qmlplugin/qmlplugin.pro
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/test1.html
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp




Diff

Modified: trunk/ChangeLog (92276 => 92277)

--- trunk/ChangeLog	2011-08-03 13:15:39 UTC (rev 92276)
+++ trunk/ChangeLog	2011-08-03 14:25:23 UTC (rev 92277)
@@ -1,3 +1,12 @@
+2011-08-02  Caio Marcelo de Oliveira Filho  
+
+[Qt] [WK2] Expose web view classes to QML
+https://bugs.webkit.org/show_bug.cgi?id=65339
+
+Reviewed by Benjamin Poulain.
+
+* Source/WebKit.pro: Include QML plugin subdir in the build system for WK2.
+
 2011-08-03  Carlos Garcia Campos  
 
 [GTK] Install web and plugin processes in libexecdir instead of bindir


Modified: trunk/Source/WebKit.pro (92276 => 92277)

--- trunk/Source/WebKit.pro	2011-08-03 13:15:39 UTC (rev 92276)
+++ trunk/Source/WebKit.pro	2011-08-03 14:25:23 UTC (rev 92277)
@@ -23,6 +23,7 @@
 webkit2 {
 exists($$PWD/WebKit2/WebProcess.pro): SUBDIRS += WebKit2/WebProcess.pro
 exists($$PWD/WebKit2/UIProcess/API/qt/tests): SUBDIRS += WebKit2/UIProcess/API/qt/tests
+SUBDIRS += WebKit2/UIProcess/API/qt/qmlplugin
 }
 
 exists($$PWD/WebKit/qt/declarative) {


Modified: trunk/Source/WebKit2/ChangeLog (92276 => 92277)

--- trunk/Source/WebKit2/ChangeLog	2011-08-03 13:15:39 UTC (rev 92276)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-03 14:25:23 UTC (rev 92277)
@@ -1,3 +1,29 @@
+2011-08-02  Caio Marcelo de Oliveira Filho  
+
+[Qt] [WK2] Expose web view classes to QML
+https://bugs.webkit.org/show_bug.cgi?id=65339
+
+Reviewed by Benjamin Poulain.
+
+This patch also uses QuickTest from QtDeclarative to provide the basic autotest
+infrastructure for the exposed elements.
+
+* UIProcess/API/qt/qmlplugin/plugin.cpp: Added.
+(WebKit2QmlPlugin::registerTypes):
+* UIProcess/API/qt/qmlplugin/qmldir: Added.
+* UIProcess/API/qt/qmlplugin/qmlplugin.pro: Added.
+* UIProcess/API/qt/qtouchwebpage.h: Expose load() to QML environment.
+* UIProcess/API/qt/qtouchwebview.h: Since QTouchWebPage* doesn't change once set
+in the constructor, we mark the page property as CONSTANT. This avoid QML
+warnings for not having a NOTIFY signal for the property change.
+
+* UIProcess/API/qt/tests/tests.pro:
+* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Added.
+* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml: Added.
+* UIProcess/API/qt/tests/qmltests/common/test1.html: Added.
+* UIProcess/API/qt/tests/qmltests/qmltests.pro: Added.
+* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

[webkit-changes] [92276] trunk/Tools

[andreas . kling]

Title: [92276] trunk/Tools








Revision 92276
Author andreas.kl...@nokia.com
Date 2011-08-03 06:15:39 -0700 (Wed, 03 Aug 2011)


Log Message
[Qt] MiniBrowser: Unbreak load progress indication.
https://bugs.webkit.org/show_bug.cgi?id=65614

Reviewed by Kenneth Rohde Christiansen.

loadProgress() was renamed to loadProgressChanged().

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::onLoadProgressChanged):
* MiniBrowser/qt/BrowserWindow.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/BrowserWindow.h




Diff

Modified: trunk/Tools/ChangeLog (92275 => 92276)

--- trunk/Tools/ChangeLog	2011-08-03 13:05:46 UTC (rev 92275)
+++ trunk/Tools/ChangeLog	2011-08-03 13:15:39 UTC (rev 92276)
@@ -1,3 +1,17 @@
+2011-08-03  Andreas Kling  
+
+[Qt] MiniBrowser: Unbreak load progress indication.
+https://bugs.webkit.org/show_bug.cgi?id=65614
+
+Reviewed by Kenneth Rohde Christiansen.
+
+loadProgress() was renamed to loadProgressChanged().
+
+* MiniBrowser/qt/BrowserWindow.cpp:
+(BrowserWindow::BrowserWindow):
+(BrowserWindow::onLoadProgressChanged):
+* MiniBrowser/qt/BrowserWindow.h:
+
 2011-08-03  Martin Robinson  
 
 Build fix for WebKit2GTK+.


Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp (92275 => 92276)

--- trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp	2011-08-03 13:05:46 UTC (rev 92275)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp	2011-08-03 13:15:39 UTC (rev 92276)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
+ * Copyright (C) 2010, 2011 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2010 University of Szeged
  *
  * All rights reserved.
@@ -57,7 +57,7 @@
 
 setAttribute(Qt::WA_DeleteOnClose);
 
-connect(webView(), SIGNAL(loadProgress(int)), SLOT(loadProgress(int)));
+connect(webView(), SIGNAL(loadProgressChanged(int)), SLOT(onLoadProgressChanged(int)));
 connect(webView(), SIGNAL(titleChanged(QString)), SLOT(setWindowTitle(QString)));
 connect(webView(), SIGNAL(urlChanged(QUrl)), SLOT(urlChanged(QUrl)));
 
@@ -163,7 +163,7 @@
 m_browser->load(string);
 }
 
-void BrowserWindow::loadProgress(int progress)
+void BrowserWindow::onLoadProgressChanged(int progress)
 {
 QColor backgroundColor = QApplication::palette().color(QPalette::Base);
 QColor progressColor = QColor(120, 180, 240);


Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.h (92275 => 92276)

--- trunk/Tools/MiniBrowser/qt/BrowserWindow.h	2011-08-03 13:05:46 UTC (rev 92275)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.h	2011-08-03 13:15:39 UTC (rev 92276)
@@ -56,7 +56,7 @@
 
 protected slots:
 void changeLocation();
-void loadProgress(int progress);
+void onLoadProgressChanged(int progress);
 void urlChanged(const QUrl&);
 void openFile();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92275] trunk/LayoutTests

[tkent]

Title: [92275] trunk/LayoutTests








Revision 92275
Author tk...@chromium.org
Date 2011-08-03 06:05:46 -0700 (Wed, 03 Aug 2011)


Log Message
[Chromium] Remove flaky failures of fast/speech/input-appearance-*.html.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92274 => 92275)

--- trunk/LayoutTests/ChangeLog	2011-08-03 12:29:47 UTC (rev 92274)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 13:05:46 UTC (rev 92275)
@@ -1,3 +1,9 @@
+2011-08-03  Kent Tamura  
+
+[Chromium] Remove flaky failures of fast/speech/input-appearance-*.html.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-03  Csaba Osztrogonác  
 
 [Qt]REGRESSION(r92254): It made 2 tests timeout


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92274 => 92275)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 12:29:47 UTC (rev 92274)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-03 13:05:46 UTC (rev 92275)
@@ -3369,11 +3369,6 @@
 // Flaky since added by r86478
 BUGCR82881 MAC LINUX XP VISTA : http/tests/appcache/interrupted-update.html = PASS TEXT
 
-// Flaky on Linux
-BUGCR82891 LINUX : fast/speech/input-appearance-numberandspeech.html = TEXT IMAGE+TEXT PASS
-BUGCR82891 LINUX : fast/speech/input-appearance-searchandspeech.html = FAIL PASS
-BUGCR82891 LINUX : fast/speech/input-appearance-speechbutton.html = TEXT IMAGE+TEXT PASS
-
 // Fails on windows - added in r86693
 BUGCR82950 WIN : http/tests/navigation/post-301-response.html = TEXT
 BUGCR82950 WIN : http/tests/navigation/post-302-response.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92274] trunk/Tools

[mrobinson]

Title: [92274] trunk/Tools








Revision 92274
Author mrobin...@webkit.org
Date 2011-08-03 05:29:47 -0700 (Wed, 03 Aug 2011)


Log Message
Build fix for WebKit2GTK+.

* WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
of the library dependencies of the injected bundle.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/GNUmakefile.am




Diff

Modified: trunk/Tools/ChangeLog (92273 => 92274)

--- trunk/Tools/ChangeLog	2011-08-03 12:20:12 UTC (rev 92273)
+++ trunk/Tools/ChangeLog	2011-08-03 12:29:47 UTC (rev 92274)
@@ -1,3 +1,10 @@
+2011-08-03  Martin Robinson  
+
+Build fix for WebKit2GTK+.
+
+* WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
+of the library dependencies of the injected bundle.
+
 2011-08-03  Carlos Garcia Campos  
 
 [GTK] Install web and plugin processes in libexecdir instead of bindir


Modified: trunk/Tools/WebKitTestRunner/GNUmakefile.am (92273 => 92274)

--- trunk/Tools/WebKitTestRunner/GNUmakefile.am	2011-08-03 12:20:12 UTC (rev 92273)
+++ trunk/Tools/WebKitTestRunner/GNUmakefile.am	2011-08-03 12:29:47 UTC (rev 92274)
@@ -79,6 +79,9 @@
 	Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp \
 	Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
 
+Libraries_libTestRunnerInjectedBundle_la_LIBADD = \
+	libWebCoreInternals.la
+
 Libraries_libTestRunnerInjectedBundle_la_LDFLAGS = \
 	-rpath ${shell pwd}/$(top_builddir)/../unix/TestNetscapePlugin/.libs \
 	$(no_undefined) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92273] trunk

[carlosgc]

Title: [92273] trunk








Revision 92273
Author carlo...@webkit.org
Date 2011-08-03 05:20:12 -0700 (Wed, 03 Aug 2011)


Log Message
[GTK] Install web and plugin processes in libexecdir instead of bindir
https://bugs.webkit.org/show_bug.cgi?id=65600

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Initialize libexec_PROGRAMS, only used by
WebKit2 in this moment.

Source/WebKit2:

Launch processes from libexecdir or WEBKIT_EXEC_PATH
environment variable when it's set. This variable will be used by
MiniBrowser and unit tests to find processes without having to
install them.

* GNUmakefile.am:
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):

Tools:

Set WEBKIT_EXEC_PATH environment variable to use web and plugin
process from current directory instead of the intalled ones.

* MiniBrowser/gtk/GNUmakefile.am:
* MiniBrowser/gtk/main.c:
(main):
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/gtk/main.cpp:
(main):

Modified Paths

trunk/ChangeLog
trunk/GNUmakefile.am
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/GNUmakefile.am
trunk/Tools/MiniBrowser/gtk/main.c
trunk/Tools/WebKitTestRunner/GNUmakefile.am
trunk/Tools/WebKitTestRunner/gtk/main.cpp




Diff

Modified: trunk/ChangeLog (92272 => 92273)

--- trunk/ChangeLog	2011-08-03 11:55:26 UTC (rev 92272)
+++ trunk/ChangeLog	2011-08-03 12:20:12 UTC (rev 92273)
@@ -1,5 +1,15 @@
 2011-08-03  Carlos Garcia Campos  
 
+[GTK] Install web and plugin processes in libexecdir instead of bindir
+https://bugs.webkit.org/show_bug.cgi?id=65600
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Initialize libexec_PROGRAMS, only used by
+WebKit2 in this moment.
+
+2011-08-03  Carlos Garcia Campos  
+
 [GTK] Reorganize pkg-config files
 https://bugs.webkit.org/show_bug.cgi?id=65548
 


Modified: trunk/GNUmakefile.am (92272 => 92273)

--- trunk/GNUmakefile.am	2011-08-03 11:55:26 UTC (rev 92272)
+++ trunk/GNUmakefile.am	2011-08-03 12:20:12 UTC (rev 92273)
@@ -45,6 +45,7 @@
 # Libraries and support components
 bin_PROGRAMS :=
 noinst_PROGRAMS :=
+libexec_PROGRAMS :=
 noinst_HEADERS :=
 noinst_LTLIBRARIES :=
 lib_LTLIBRARIES :=


Modified: trunk/Source/WebKit2/ChangeLog (92272 => 92273)

--- trunk/Source/WebKit2/ChangeLog	2011-08-03 11:55:26 UTC (rev 92272)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-03 12:20:12 UTC (rev 92273)
@@ -1,3 +1,19 @@
+2011-08-03  Carlos Garcia Campos  
+
+[GTK] Install web and plugin processes in libexecdir instead of bindir
+https://bugs.webkit.org/show_bug.cgi?id=65600
+
+Reviewed by Martin Robinson.
+
+Launch processes from libexecdir or WEBKIT_EXEC_PATH
+environment variable when it's set. This variable will be used by
+MiniBrowser and unit tests to find processes without having to
+install them.
+
+* GNUmakefile.am:
+* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
+(WebKit::ProcessLauncher::launchProcess):
+
 2011-08-03  Pavel Feldman  
 
 Web Inspector: remove Node parameter from the InspectorClient::highlight


Modified: trunk/Source/WebKit2/GNUmakefile.am (92272 => 92273)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-08-03 11:55:26 UTC (rev 92272)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-08-03 12:20:12 UTC (rev 92273)
@@ -844,6 +844,7 @@
 	-I$(top_builddir)/DerivedSources/WebKit2/include/_javascript_Core \
 	-I$(top_builddir)/DerivedSources/WebKit2/include/WebCore \
 	-I$(top_builddir)/DerivedSources/WebKit2/include/WebKit2 \
+	-DLIBEXECDIR=\""$(libexecdir)"\" \
 	$(webcore_cppflags) \
 	$(webcoregtk_cppflags) \
 	$(_javascript_core_cppflags) \
@@ -960,7 +961,7 @@
 	$(top_builddir)/WebKit2/webkit2gtk-@WEBKITGTK_API_VERSION@.pc
 
 # WebKitWebProcess
-bin_PROGRAMS += \
+libexec_PROGRAMS += \
 	Programs/WebKitWebProcess
 
 Programs_WebKitWebProcess_CPPFLAGS = \
@@ -1037,7 +1038,7 @@
 	$(XT_CFLAGS) \
 	$(ZLIB_LIBS)
 
-bin_PROGRAMS += \
+libexec_PROGRAMS += \
 	Programs/WebKitPluginProcess
 
 Programs_WebKitPluginProcess_CPPFLAGS = \


Modified: trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp (92272 => 92273)

--- trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp	2011-08-03 11:55:26 UTC (rev 92272)
+++ trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp	2011-08-03 12:20:12 UTC (rev 92273)
@@ -76,7 +76,8 @@
 return;
 }
 
-GOwnPtr binaryPath(g_build_filename(applicationDirectoryPath().data(),
+const gchar* execDirectory = g_getenv("WEBKIT_EXEC_PATH");
+GOwnPtr binaryPath(g_build_filename(execDirectory ? execDirectory : LIBEXECDIR,
m_launchOptions.processType == ProcessLauncher::WebProcess ? gWebKitWebProcessName : gWebKitPluginProcessName, NULL));
 GOwnPtr socket(g_strdup_printf("%d", sockets[0]))

[webkit-changes] [92272] trunk/LayoutTests

[ossy]

Title: [92272] trunk/LayoutTests








Revision 92272
Author o...@webkit.org
Date 2011-08-03 04:55:26 -0700 (Wed, 03 Aug 2011)


Log Message
[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

[Qt]REGRESSION(r92224): It made editing/text-iterator/basic-iteration.html timeout
https://bugs.webkit.org/show_bug.cgi?id=65605

* platform/qt/Skipped: Skip failing tests:
 - fast/frames/lots-of-objects.html
 - fast/frames/lots-of-iframes.html
 - editing/text-iterator/basic-iteration.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (92271 => 92272)

--- trunk/LayoutTests/ChangeLog	2011-08-03 11:14:52 UTC (rev 92271)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 11:55:26 UTC (rev 92272)
@@ -1,3 +1,17 @@
+2011-08-03  Csaba Osztrogonác  
+
+[Qt]REGRESSION(r92254): It made 2 tests timeout
+https://bugs.webkit.org/show_bug.cgi?id=65609
+
+[Qt]REGRESSION(r92224): It made editing/text-iterator/basic-iteration.html timeout
+https://bugs.webkit.org/show_bug.cgi?id=65605
+
+
+* platform/qt/Skipped: Skip failing tests:
+ - fast/frames/lots-of-objects.html
+ - fast/frames/lots-of-iframes.html
+ - editing/text-iterator/basic-iteration.html
+
 2011-08-03  Philippe Normand  
 
 Unreviewed, GTK svg rebaseline after r92047.


Modified: trunk/LayoutTests/platform/qt/Skipped (92271 => 92272)

--- trunk/LayoutTests/platform/qt/Skipped	2011-08-03 11:14:52 UTC (rev 92271)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-08-03 11:55:26 UTC (rev 92272)
@@ -2238,3 +2238,12 @@
 # [Qt]Web Inspector: http/tests/inspector/network/network-sidebar-width.html fails
 # https://bugs.webkit.org/show_bug.cgi?id=65526
 http/tests/inspector/network/network-sidebar-width.html
+
+# [Qt]REGRESSION(r92254): It made 2 tests timeout
+# https://bugs.webkit.org/show_bug.cgi?id=65609
+fast/frames/lots-of-objects.html
+fast/frames/lots-of-iframes.html
+
+# [Qt]REGRESSION(r92224): It made editing/text-iterator/basic-iteration.html timeout
+# https://bugs.webkit.org/show_bug.cgi?id=65605
+editing/text-iterator/basic-iteration.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92271] trunk/Source/WebCore

[philn]

Title: [92271] trunk/Source/WebCore








Revision 92271
Author ph...@webkit.org
Date 2011-08-03 04:14:52 -0700 (Wed, 03 Aug 2011)


Log Message
libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=64263

Reviewed by Martin Robinson.

Avoid any operation on not yet started messages and completed messages.

* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::finishedCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceHandleInternal.h
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92270 => 92271)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 10:50:18 UTC (rev 92270)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 11:14:52 UTC (rev 92271)
@@ -1,3 +1,19 @@
+2011-08-03  Philippe Normand  
+
+libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
+https://bugs.webkit.org/show_bug.cgi?id=64263
+
+Reviewed by Martin Robinson.
+
+Avoid any operation on not yet started messages and completed messages.
+
+* platform/network/ResourceHandleInternal.h:
+(WebCore::ResourceHandleInternal::ResourceHandleInternal):
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::finishedCallback):
+(WebCore::startHTTPRequest):
+(WebCore::ResourceHandle::platformSetDefersLoading):
+
 2011-08-03  Jeremy Moskovich  
 
 [Chromium] Fix OOP font loading to work on 10.6.6 and above.


Modified: trunk/Source/WebCore/platform/network/ResourceHandleInternal.h (92270 => 92271)

--- trunk/Source/WebCore/platform/network/ResourceHandleInternal.h	2011-08-03 10:50:18 UTC (rev 92270)
+++ trunk/Source/WebCore/platform/network/ResourceHandleInternal.h	2011-08-03 11:14:52 UTC (rev 92271)
@@ -113,6 +113,8 @@
 #endif
 #if USE(SOUP)
 , m_cancelled(false)
+, m_finished(false)
+, m_finishedHandler(0)
 , m_buffer(0)
 , m_bodySize(0)
 , m_bodyDataSent(0)
@@ -191,6 +193,8 @@
 GRefPtr m_soupMessage;
 ResourceResponse m_response;
 bool m_cancelled;
+bool m_finished;
+gulong m_finishedHandler;
 GRefPtr m_soupRequest;
 GRefPtr m_inputStream;
 GRefPtr m_cancellable;


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (92270 => 92271)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2011-08-03 10:50:18 UTC (rev 92270)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2011-08-03 11:14:52 UTC (rev 92271)
@@ -360,6 +360,14 @@
 client->didReceiveData(handle.get(), chunk->data, chunk->length, -1);
 }
 
+static void finishedCallback(SoupMessage* msg, gpointer data)
+{
+RefPtr handle = static_cast(data);
+if (!handle)
+return;
+handle->getInternal()->m_finished = true;
+}
+
 static void cleanupSoupRequestOperation(ResourceHandle* handle, bool isDestroying = false)
 {
 ResourceHandleInternal* d = handle->getInternal();
@@ -564,6 +572,8 @@
 url.removeFragmentIdentifier();
 request.setURL(url);
 
+d->m_finished = false;
+
 GOwnPtr error;
 d->m_soupRequest = adoptGRef(soup_requester_request(requester, url.string().utf8().data(), &error.outPtr()));
 if (error) {
@@ -589,6 +599,7 @@
 g_signal_connect(soupMessage, "got-headers", G_CALLBACK(gotHeadersCallback), handle);
 g_signal_connect(soupMessage, "wrote-body-data", G_CALLBACK(wroteBodyDataCallback), handle);
 d->m_gotChunkHandler = g_signal_connect(soupMessage, "got-chunk", G_CALLBACK(gotChunkCallback), handle);
+d->m_finishedHandler = g_signal_connect(soupMessage, "finished", G_CALLBACK(finishedCallback), handle);
 
 String firstPartyString = request.firstPartyForCookies().string();
 if (!firstPartyString.isEmpty()) {
@@ -703,8 +714,9 @@
 if (!d->m_soupMessage)
 return;
 
+// Avoid any operation on not yet started messages and completed messages.
 SoupMessage* soupMessage = d->m_soupMessage.get();
-if (soupMessage->status_code != SOUP_STATUS_NONE)
+if (d->m_finished || soupMessage->status_code == SOUP_STATUS_NONE)
 return;
 
 if (defersLoading)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92270] branches/chromium/835

[vsevik]

Title: [92270] branches/chromium/835








Revision 92270
Author vse...@chromium.org
Date 2011-08-03 03:50:18 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 91858 - Web Inspector: Disable cache option should only clear memory cache, not disable it.
https://bugs.webkit.org/show_bug.cgi?id=65184

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/InspectorClient.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:

LayoutTests:

* http/tests/inspector/network/network-disable-cache-memory-expected.txt:
* http/tests/inspector/network/network-disable-cache-memory.html:
* http/tests/inspector/network/resources/random-script.php: Added.

TBR=pfeld...@chromium.org
BUG=90757
Review URL: http://codereview.chromium.org/7563005

Modified Paths

branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory-expected.txt
branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory.html
branches/chromium/835/Source/WebCore/inspector/InspectorClient.h
branches/chromium/835/Source/WebCore/inspector/InspectorResourceAgent.cpp
branches/chromium/835/Source/WebKit/chromium/src/InspectorClientImpl.cpp
branches/chromium/835/Source/WebKit/chromium/src/InspectorClientImpl.h
branches/chromium/835/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
branches/chromium/835/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h


Added Paths

branches/chromium/835/LayoutTests/http/tests/inspector/network/resources/random-script.php




Diff

Modified: branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory-expected.txt (92269 => 92270)

--- branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory-expected.txt	2011-08-03 10:48:22 UTC (rev 92269)
+++ branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory-expected.txt	2011-08-03 10:50:18 UTC (rev 92270)
@@ -1,8 +1,8 @@
-CONSOLE MESSAGE: line 26: First two images loaded.
-CONSOLE MESSAGE: line 36: Done.
+CONSOLE MESSAGE: line 1: Done.
+CONSOLE MESSAGE: line 1: Done.
+CONSOLE MESSAGE: line 1: Done.
 Tests disabling cache from inspector.
 
+Page reloaded.
+Page reloaded.
 
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&cached=1
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&cached=1
-


Modified: branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory.html (92269 => 92270)

--- branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory.html	2011-08-03 10:48:22 UTC (rev 92269)
+++ branches/chromium/835/LayoutTests/http/tests/inspector/network/network-disable-cache-memory.html	2011-08-03 10:50:18 UTC (rev 92270)
@@ -3,83 +3,82 @@
 

[webkit-changes] [92269] trunk/Source

[jeremy]

Title: [92269] trunk/Source








Revision 92269
Author jer...@chromium.org
Date 2011-08-03 03:48:22 -0700 (Wed, 03 Aug 2011)


Log Message
[Chromium] Fix OOP font loading to work on 10.6.6 and above.
https://bugs.webkit.org/show_bug.cgi?id=65543

In 10.6.6 the function used to get the unique ID for an NSFont in the
renderer was changed so it fails in the sandbox (it now tries to access
the on-disk font file). In order to work around this, we get the font
ID from the browser process.

To speed things up, we introduce 2 levels of caching in WebKit. A font
name cache where we can perform a quick lookup without the need for the
font id and a font id cache which we can only lookup in after getting
the unique ID from the browser process.

Reviewed by Kenneth Russell.

No new tests since this is not readily testable.

Source/WebCore:

* platform/chromium/PlatformBridge.h:
* platform/graphics/chromium/CrossProcessFontLoading.h:
* platform/graphics/chromium/CrossProcessFontLoading.mm:
(WebCore::MemoryActivatedFont::create):
(WebCore::MemoryActivatedFont::MemoryActivatedFont):
(WebCore::MemoryActivatedFont::~MemoryActivatedFont):

Source/WebKit/chromium:

* public/mac/WebSandboxSupport.h: Plumb font ID parameter through.
* src/PlatformBridge.cpp:
(WebCore::PlatformBridge::loadFont): ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformBridge.h
trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.h
trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/mac/WebSandboxSupport.h
trunk/Source/WebKit/chromium/src/PlatformBridge.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92268 => 92269)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 10:46:24 UTC (rev 92268)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 10:48:22 UTC (rev 92269)
@@ -1,3 +1,29 @@
+2011-08-03  Jeremy Moskovich  
+
+[Chromium] Fix OOP font loading to work on 10.6.6 and above.
+https://bugs.webkit.org/show_bug.cgi?id=65543
+
+In 10.6.6 the function used to get the unique ID for an NSFont in the 
+renderer was changed so it fails in the sandbox (it now tries to access
+the on-disk font file). In order to work around this, we get the font
+ID from the browser process.
+
+To speed things up, we introduce 2 levels of caching in WebKit. A font
+name cache where we can perform a quick lookup without the need for the
+font id and a font id cache which we can only lookup in after getting
+the unique ID from the browser process.
+
+Reviewed by Kenneth Russell.
+
+No new tests since this is not readily testable.
+
+* platform/chromium/PlatformBridge.h:
+* platform/graphics/chromium/CrossProcessFontLoading.h:
+* platform/graphics/chromium/CrossProcessFontLoading.mm:
+(WebCore::MemoryActivatedFont::create):
+(WebCore::MemoryActivatedFont::MemoryActivatedFont):
+(WebCore::MemoryActivatedFont::~MemoryActivatedFont):
+
 2011-08-03  Hayato Ito  
 
 Make EventDispatchMediator RefCounted.


Modified: trunk/Source/WebCore/platform/chromium/PlatformBridge.h (92268 => 92269)

--- trunk/Source/WebCore/platform/chromium/PlatformBridge.h	2011-08-03 10:46:24 UTC (rev 92268)
+++ trunk/Source/WebCore/platform/chromium/PlatformBridge.h	2011-08-03 10:48:22 UTC (rev 92269)
@@ -151,7 +151,7 @@
 static bool ensureFontLoaded(HFONT);
 #endif
 #if OS(DARWIN)
-static bool loadFont(NSFont* srcFont, ATSFontContainerRef* out);
+static bool loadFont(NSFont* srcFont, ATSFontContainerRef*, uint32_t* fontID);
 #elif OS(UNIX)
 static void getRenderStyleForStrike(const char* family, int sizeAndStyle, FontRenderStyle* result);
 static String getFontFamilyForCharacters(const UChar*, size_t numCharacters, const char* preferredLocale);


Modified: trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.h (92268 => 92269)

--- trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.h	2011-08-03 10:46:24 UTC (rev 92268)
+++ trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.h	2011-08-03 10:48:22 UTC (rev 92269)
@@ -33,6 +33,7 @@
 
 #import 
 #import 
+#import 
 
 typedef struct CGFont* CGFontRef;
 typedef UInt32 ATSFontContainerRef;
@@ -73,7 +74,7 @@
 class MemoryActivatedFont : public RefCounted {
 public:
 // Use to create a new object, see docs on constructor below.
-static PassRefPtr create(ATSFontContainerRef srcFontContainerRef, ATSFontContainerRef container);
+static PassRefPtr create(uint32_t fontID, NSFont*, ATSFontContainerRef);
 ~MemoryActivatedFont();
 
 // Get cached CGFontRef corresponding to the in-memory font.
@@ -87,12 +88,13 @@
 // load in-process.
 // container - a font container corresponding to an identical font that
 // we loaded cross-process.
-MemoryAct

[webkit-changes] [92268] trunk/LayoutTests

[philn]

Title: [92268] trunk/LayoutTests








Revision 92268
Author ph...@webkit.org
Date 2011-08-03 03:46:24 -0700 (Wed, 03 Aug 2011)


Log Message
Unreviewed, GTK svg rebaseline after r92047.

* platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
* platform/gtk/svg/batik/filters/feTile-expected.txt:
* platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
* platform/gtk/svg/batik/text/smallFonts-expected.txt:
* platform/gtk/svg/batik/text/textAnchor-expected.txt:
* platform/gtk/svg/batik/text/textDecoration-expected.txt:
* platform/gtk/svg/batik/text/textEffect-expected.txt:
* platform/gtk/svg/batik/text/textEffect2-expected.txt:
* platform/gtk/svg/batik/text/textEffect3-expected.txt:
* platform/gtk/svg/batik/text/textFeatures-expected.txt:
* platform/gtk/svg/batik/text/textLayout-expected.txt:
* platform/gtk/svg/batik/text/textLayout2-expected.txt:
* platform/gtk/svg/batik/text/textLength-expected.txt:
* platform/gtk/svg/batik/text/textOnPath-expected.txt:
* platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/gtk/svg/batik/text/textPosition-expected.txt:
* platform/gtk/svg/batik/text/textPosition2-expected.txt:
* platform/gtk/svg/batik/text/textProperties-expected.txt:
* platform/gtk/svg/batik/text/textProperties2-expected.txt:
* platform/gtk/svg/batik/text/textStyles-expected.txt:
* platform/gtk/svg/batik/text/verticalText-expected.txt:
* platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/gtk/svg/custom/external-paintserver-reference-expected.txt: Added.
* platform/gtk/svg/custom/linking-base-external-reference-expected.txt: Added.
* platform/gtk/svg/custom/text-linking-expected.txt:
* platform/gtk/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.
* platform/gtk/svg/hixie/error/014-expected.txt:
* platform/gtk/svg/hixie/use/002-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/filters/feTile-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/paints/patternRegionA-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/paints/patternRegions-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/longTextOnPath-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/smallFonts-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textAnchor-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textDecoration-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textEffect-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textEffect2-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textEffect3-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textFeatures-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textLayout-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textLayout2-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textLength-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textOnPath-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textPosition-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textPosition2-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textProperties-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textProperties2-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/textStyles-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/verticalText-expected.txt
trunk/LayoutTests/platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/text-linking-expected.txt
trunk/LayoutTests/platform/gtk/svg/hixie/error/014-expected.txt
trunk/LayoutTests/platform/gtk/svg/hixie/use/002-expected.txt


Added Paths

trunk/LayoutTests/platform/gtk/svg/custom/external-paintserver-reference-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/linking-base-external-reference-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/zero-path-square-cap-rendering2-expected.txt




Diff

Modified: trunk/LayoutTests/C

[webkit-changes] [92267] branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent. cpp

[vsevik]

Title: [92267] branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent.cpp








Revision 92267
Author vse...@chromium.org
Date 2011-08-03 03:18:58 -0700 (Wed, 03 Aug 2011)


Log Message
Merge 91901 - Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::open):


TBR=vse...@chromium.org
BUG=87345
Review URL: http://codereview.chromium.org/7565004

Modified Paths

branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent.cpp (92266 => 92267)

--- branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent.cpp	2011-08-03 10:17:31 UTC (rev 92266)
+++ branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent.cpp	2011-08-03 10:18:58 UTC (rev 92267)
@@ -299,6 +299,8 @@
 
 void InspectorPageAgent::open(ErrorString*, const String& url, const bool* const inNewWindow)
 {
+UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
+
 Frame* mainFrame = m_page->mainFrame();
 Frame* frame;
 if (inNewWindow && *inNewWindow) {
@@ -315,7 +317,6 @@
 } else
 frame = mainFrame;
 
-UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
 // FIXME: Why does one use mainFrame and the other frame?
 frame->loader()->changeLocation(mainFrame->document()->securityOrigin(), frame->document()->completeURL(url), "", false, false);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92266] trunk/Source/WebCore

[hayato]

Title: [92266] trunk/Source/WebCore








Revision 92266
Author hay...@chromium.org
Date 2011-08-03 03:17:31 -0700 (Wed, 03 Aug 2011)


Log Message
Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529

Reviewed by Hajime Morita.

Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.

This is a minor update of r92256, which failed on chromium win builds.

No changes to functionality so no new tests.

* dom/Event.cpp:
(WebCore::EventDispatchMediator::create):
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::create):
* dom/KeyboardEvent.h:
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
* dom/MouseEvent.h:
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
* dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::create):
* dom/WheelEvent.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Event.cpp
trunk/Source/WebCore/dom/Event.h
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
trunk/Source/WebCore/dom/KeyboardEvent.cpp
trunk/Source/WebCore/dom/KeyboardEvent.h
trunk/Source/WebCore/dom/MouseEvent.cpp
trunk/Source/WebCore/dom/MouseEvent.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/WheelEvent.cpp
trunk/Source/WebCore/dom/WheelEvent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92265 => 92266)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 08:28:40 UTC (rev 92265)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 10:17:31 UTC (rev 92266)
@@ -1,3 +1,39 @@
+2011-08-03  Hayato Ito  
+
+Make EventDispatchMediator RefCounted.
+https://bugs.webkit.org/show_bug.cgi?id=65529
+
+Reviewed by Hajime Morita.
+
+Make EventDispatchMediator RefCounted so that it can be enqueued into a
+ScopedEventQueue and called later.
+A necessary change for ScopedEventQueue should be addressed in another patch.
+
+This is a minor update of r92256, which failed on chromium win builds.
+
+No changes to functionality so no new tests.
+
+* dom/Event.cpp:
+(WebCore::EventDispatchMediator::create):
+* dom/Event.h:
+* dom/EventDispatcher.cpp:
+(WebCore::EventDispatcher::dispatchEvent):
+* dom/EventDispatcher.h:
+* dom/KeyboardEvent.cpp:
+(WebCore::KeyboardEventDispatchMediator::create):
+* dom/KeyboardEvent.h:
+* dom/MouseEvent.cpp:
+(WebCore::MouseEventDispatchMediator::create):
+* dom/MouseEvent.h:
+* dom/Node.cpp:
+(WebCore::Node::dispatchEvent):
+(WebCore::Node::dispatchKeyEvent):
+(WebCore::Node::dispatchMouseEvent):
+(WebCore::Node::dispatchWheelEvent):
+* dom/WheelEvent.cpp:
+(WebCore::WheelEventDispatchMediator::create):
+* dom/WheelEvent.h:
+
 2011-08-03  Pavel Feldman  
 
 Web Inspector: remove Node parameter from the InspectorClient::highlight


Modified: trunk/Source/WebCore/dom/Event.cpp (92265 => 92266)

--- trunk/Source/WebCore/dom/Event.cpp	2011-08-03 08:28:40 UTC (rev 92265)
+++ trunk/Source/WebCore/dom/Event.cpp	2011-08-03 10:17:31 UTC (rev 92266)
@@ -289,6 +289,11 @@
 m_underlyingEvent = ue;
 }
 
+PassRefPtr EventDispatchMediator::create(PassRefPtr event)
+{
+return adoptRef(new EventDispatchMediator(event));
+}
+
 EventDispatchMediator::EventDispatchMediator(PassRefPtr event)
 : m_event(event)
 {


Modified: trunk/Source/WebCore/dom/Event.h (92265 => 92266)

--- trunk/Source/WebCore/dom/Event.h	2011-08-03 08:28:40 UTC (rev 92265)
+++ trunk/Source/WebCore/dom/Event.h	2011-08-03 10:17:31 UTC (rev 92266)
@@ -199,14 +199,15 @@
 RefPtr m_underlyingEvent;
 };
 
-class EventDispatchMediator {
+class EventDispatchMediator : public RefCounted {
 public:
-explicit EventDispatchMediator(PassRefPtr);
+static PassRefPtr create(PassRefPtr);
 virtual ~EventDispatchMediator();
 
 virtual bool dispatchEvent(EventDispatcher*) const;
 
 protected:
+explicit EventDispatchMediator(PassRefPtr);
 EventDispatchMediator();
 
 Event* event() const;


Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (92265 => 92266)

--- trunk/Source/WebCore/dom/EventDispatcher.cpp	2011-08-03 08:28:40 UTC (rev 92265)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp	2011-08-03 10:17:31 UTC (rev 92266)
@@ -46,12 +46,12 @@
 
 static HashSet* gNodesDispatchingSimulatedClicks = 0;
 
-bool EventDispatcher::dispatchEvent(Node* node, const EventDispatchMediator& mediator)
+bool EventDispatcher::dispatchEvent(Node* node, PassRefPtr mediator)
 {
 ASSERT(!eventDispatchForbidden());
 
 EventDisp

[webkit-changes] [92265] trunk/Source

[pfeldman]

Title: [92265] trunk/Source








Revision 92265
Author pfeld...@chromium.org
Date 2011-08-03 01:28:40 -0700 (Wed, 03 Aug 2011)


Log Message
Web Inspector: remove Node parameter from the InspectorClient::highlight
https://bugs.webkit.org/show_bug.cgi?id=65549

Patch by Pavel Feldman  on 2011-08-03
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InspectorClient.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlight):
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::highlight):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::highlight):
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::highlight):
* src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::highlight):
* WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::highlight):
* WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/haiku:

* WebCoreSupport/InspectorClientHaiku.cpp:
(WebCore::InspectorClientHaiku::highlight):
* WebCoreSupport/InspectorClientHaiku.h:

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::highlight):
* WebInspector/WebNodeHighlighter.h:
* WebInspector/WebNodeHighlighter.mm:
(-[WebNodeHighlighter highlight]):

Source/WebKit/qt:

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::highlight):
* WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::highlight):
* WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

* WebCoreSupport/InspectorClientWinCE.cpp:
(WebKit::InspectorClientWinCE::highlight):
* WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::highlight):
* WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
* WebProcess/WebCoreSupport/WebInspectorClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.h
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h
trunk/Source/WebKit/haiku/ChangeLog
trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.cpp
trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.h
trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h
trunk/Source/WebKit/wince/ChangeLog
trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp
trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h
trunk/Source/WebKit/wx/ChangeLog
trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp
trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92264 => 92265)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,16 @@
+2011-08-03  Pavel Feldman  
+
+Web Inspector: remove Node parameter from the InspectorClient::highlight
+https://bugs.webkit.org/show_bug.cgi?id=65549
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/InspectorClient.h:
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::highlight):
+* loader/EmptyClients.h:
+(WebCore::EmptyInspectorClient::highlight):
+
 2011-08-03  Antti Koivisto  
 
 https://bugs.webkit.org/show_bug.cgi?id=65599


Modified: trunk/Source/WebCore/inspector/InspectorClient.h (92264 => 92265)

--- trunk/Source

[webkit-changes] [92264] trunk/Source/WebCore

[antti]

Title: [92264] trunk/Source/WebCore








Revision 92264
Author an...@apple.com
Date 2011-08-03 01:20:41 -0700 (Wed, 03 Aug 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=65599
Image loads should trigger didFirstVisuallyNonEmptyLayout more easily

Reviewed by Dan Bernstein.

Tweak the heuristic pixel count so logo-sized images trigger didFirstVisuallyNonEmptyLayout.

* page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92263 => 92264)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 07:43:44 UTC (rev 92263)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 08:20:41 UTC (rev 92264)
@@ -1,3 +1,15 @@
+2011-08-03  Antti Koivisto  
+
+https://bugs.webkit.org/show_bug.cgi?id=65599
+Image loads should trigger didFirstVisuallyNonEmptyLayout more easily
+
+Reviewed by Dan Bernstein.
+
+Tweak the heuristic pixel count so logo-sized images trigger didFirstVisuallyNonEmptyLayout.
+
+* page/FrameView.h:
+(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
+
 2011-08-03  Takashi Toyoshima  
 
 WebSocket: Could not handle zero length text frame.


Modified: trunk/Source/WebCore/page/FrameView.h (92263 => 92264)

--- trunk/Source/WebCore/page/FrameView.h	2011-08-03 07:43:44 UTC (rev 92263)
+++ trunk/Source/WebCore/page/FrameView.h	2011-08-03 08:20:41 UTC (rev 92264)
@@ -474,7 +474,7 @@
 return;
 m_visuallyNonEmptyPixelCount += size.width() * size.height();
 // Use a threshold value to prevent very small amounts of visible content from triggering didFirstVisuallyNonEmptyLayout
-static const unsigned visualPixelThreshold = 256 * 256;
+static const unsigned visualPixelThreshold = 32 * 32;
 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
 setIsVisuallyNonEmpty();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92263] trunk

[carlosgc]

Title: [92263] trunk








Revision 92263
Author carlo...@webkit.org
Date 2011-08-03 00:43:44 -0700 (Wed, 03 Aug 2011)


Log Message
[GTK] Reorganize pkg-config files
https://bugs.webkit.org/show_bug.cgi?id=65548

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Initialize pkgconfigdir and pkgconfig_DATA which
are common to all libraries.
* configure.ac: Update pkg-config files.

Source/_javascript_Core:

* GNUmakefile.am:
* _javascript_coregtk.pc.in: Renamed from Source/WebKit/gtk/_javascript_coregtk.pc.in.

Source/WebKit/gtk:

* GNUmakefile.am: Remove _javascript_core pc file references.

Source/WebKit2:

* GNUmakefile.am: Rename pc file as webkit2gtk.pc.in. WebKit2
depends on gtk3 unconditionally so we don't need to use
WEBKITGTK_PC_NAME.
* webkit2gtk.pc.in: Renamed from Source/WebKit2/gtk/webkit2.pc.in.

Modified Paths

trunk/ChangeLog
trunk/GNUmakefile.am
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.am
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/configure.ac


Added Paths

trunk/Source/_javascript_Core/_javascript_coregtk.pc.in
trunk/Source/WebKit2/webkit2gtk.pc.in


Removed Paths

trunk/Source/WebKit/gtk/_javascript_coregtk.pc.in
trunk/Source/WebKit2/gtk/webkit2.pc.in




Diff

Modified: trunk/ChangeLog (92262 => 92263)

--- trunk/ChangeLog	2011-08-03 07:06:56 UTC (rev 92262)
+++ trunk/ChangeLog	2011-08-03 07:43:44 UTC (rev 92263)
@@ -1,3 +1,14 @@
+2011-08-03  Carlos Garcia Campos  
+
+[GTK] Reorganize pkg-config files
+https://bugs.webkit.org/show_bug.cgi?id=65548
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Initialize pkgconfigdir and pkgconfig_DATA which
+are common to all libraries.
+* configure.ac: Update pkg-config files.
+
 2011-08-02  Varun Jain  
 
 Missing null check in WebViewImpl::selectionRange


Modified: trunk/GNUmakefile.am (92262 => 92263)

--- trunk/GNUmakefile.am	2011-08-03 07:06:56 UTC (rev 92262)
+++ trunk/GNUmakefile.am	2011-08-03 07:43:44 UTC (rev 92263)
@@ -40,6 +40,7 @@
 WebCore := $(srcdir)/Source/WebCore
 WebKit := $(srcdir)/Source/WebKit/gtk
 WebKit2 := $(srcdir)/Source/WebKit2
+pkgconfigdir := $(libdir)/pkgconfig
 
 # Libraries and support components
 bin_PROGRAMS :=
@@ -89,6 +90,7 @@
 CLEANFILES :=
 DISTCLEANFILES :=
 MAINTAINERCLEANFILES :=
+pkgconfig_DATA :=
 
 # We do not care at all about this implicit built-in make rules,
 # disable them to save some build time


Modified: trunk/Source/_javascript_Core/ChangeLog (92262 => 92263)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-03 07:06:56 UTC (rev 92262)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-03 07:43:44 UTC (rev 92263)
@@ -1,3 +1,13 @@
+2011-08-03  Carlos Garcia Campos  
+
+[GTK] Reorganize pkg-config files
+https://bugs.webkit.org/show_bug.cgi?id=65548
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am:
+* _javascript_coregtk.pc.in: Renamed from Source/WebKit/gtk/_javascript_coregtk.pc.in.
+
 2011-08-01  David Levin  
 
 Add asserts to RefCounted to make sure ref/deref happens on the right thread.


Modified: trunk/Source/_javascript_Core/GNUmakefile.am (92262 => 92263)

--- trunk/Source/_javascript_Core/GNUmakefile.am	2011-08-03 07:06:56 UTC (rev 92262)
+++ trunk/Source/_javascript_Core/GNUmakefile.am	2011-08-03 07:43:44 UTC (rev 92263)
@@ -73,6 +73,8 @@
 	$(GLIB_CFLAGS) \
 	$(UNICODE_CFLAGS)
 
+pkgconfig_DATA += Source/_javascript_Core/_javascript_coregtk-@WEBKITGTK_API_VERSION@.pc
+
 Source/_javascript_Core/Lexer.lut.h: $(srcdir)/Source/_javascript_Core/create_hash_table $(srcdir)/Source/_javascript_Core/parser/Keywords.table
 	$(AM_V_GEN)$(PERL) $^ > $@
 
@@ -175,3 +177,6 @@
 	Programs/jsc \
 	Programs/jsc-@WEBKITGTK_API_MAJOR_VERSION@ \
 	Programs/minidom
+
+DISTCLEANFILES += \
+	$(top_builddir)/Source/_javascript_Core/_javascript_coregtk-@WEBKITGTK_API_VERSION@.pc


Copied: trunk/Source/_javascript_Core/_javascript_coregtk.pc.in (from rev 92262, trunk/Source/WebKit/gtk/_javascript_coregtk.pc.in) (0 => 92263)

--- trunk/Source/_javascript_Core/_javascript_coregtk.pc.in	(rev 0)
+++ trunk/Source/_javascript_Core/_javascript_coregtk.pc.in	2011-08-03 07:43:44 UTC (rev 92263)
@@ -0,0 +1,11 @@
+prefix=@prefix@
+exec_prefix=@exec_prefix@
+libdir=@libdir@
+includedir=@includedir@
+
+Name: _javascript_CoreGTK+
+Description: GTK+ version of the _javascript_Core engine
+Version: @VERSION@
+Requires: glib-2.0
+Libs: -L${libdir} -ljavascriptcoregtk-@WEBKITGTK_API_VERSION@
+Cflags: -I${includedir}/webkit-@WEBKITGTK_API_VERSION@


Modified: trunk/Source/WebKit/gtk/ChangeLog (92262 => 92263)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-08-03 07:06:56 UTC (rev 92262)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-08-03 07:43:44 UTC (rev 92263)
@@ -1,3 +1,12 @@
+2011-08-03  Carlos Garcia Campos  
+
+[GTK] Reorganize pkg-config file

[webkit-changes] [92262] trunk

[commit-queue]

Title: [92262] trunk








Revision 92262
Author commit-qu...@webkit.org
Date 2011-08-03 00:06:56 -0700 (Wed, 03 Aug 2011)


Log Message
WebSocket: Could not handle zero length text frame.
https://bugs.webkit.org/show_bug.cgi?id=65592

Patch by Takashi Toyoshima  on 2011-08-03
Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/zero-length-text.html

* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processFrame):

LayoutTests:

* http/tests/websocket/tests/hybi/zero-length-text-expected.txt: Added.
* http/tests/websocket/tests/hybi/zero-length-text.html: Added.
* http/tests/websocket/tests/hybi/zero-length-text_wsh.py: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/websockets/WebSocketChannel.cpp


Added Paths

trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text.html
trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text_wsh.py




Diff

Modified: trunk/LayoutTests/ChangeLog (92261 => 92262)

--- trunk/LayoutTests/ChangeLog	2011-08-03 05:07:51 UTC (rev 92261)
+++ trunk/LayoutTests/ChangeLog	2011-08-03 07:06:56 UTC (rev 92262)
@@ -1,3 +1,14 @@
+2011-08-03  Takashi Toyoshima  
+
+WebSocket: Could not handle zero length text frame.
+https://bugs.webkit.org/show_bug.cgi?id=65592
+
+Reviewed by Kent Tamura.
+
+* http/tests/websocket/tests/hybi/zero-length-text-expected.txt: Added.
+* http/tests/websocket/tests/hybi/zero-length-text.html: Added.
+* http/tests/websocket/tests/hybi/zero-length-text_wsh.py: Added.
+
 2011-08-02  Takashi Toyoshima  
 
 WebSocket: Should be closed by receiving invalid continuation frame.


Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text-expected.txt (0 => 92262)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text-expected.txt	2011-08-03 07:06:56 UTC (rev 92262)
@@ -0,0 +1,17 @@
+Test whether WebSocket handles zero length text frame correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+onopen() was called.
+onmessage() was called. (message = "")
+onmessage() was called. (message = "This first text should be received.")
+onmessage() was called. (message = "")
+onmessage() was called. (message = "This second text should be received, too.")
+onclose() was called.
+PASS closeEvent.wasClean is true
+PASS sequence is 4
+PASS receivedText is expectedText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text.html (0 => 92262)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text.html	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/zero-length-text.html	2011-08-03 07:06:56 UTC (rev 92262)
@@ -0,0 +1,54 @@
+
+
+
+
+
+
+
+
+description("Test whether WebSocket handles zero length text frame correctly.");
+
+window.jsTestIsAsync = true;
+if (window.layoutTestController)
+layoutTestController.overridePreference("WebKitHixie76WebSocketProtocolEnabled", 0);
+
+var ws = new WebSocket("ws://127.0.0.1:8880/websocket/tests/hybi/zero-length-text");
+var closeEvent;
+var sequence = 0;
+var receivedText = "";
+var expectedText = "This first text should be received.This second text should be received, too.";
+
+ws._onopen_ = function()
+{
+debug("onopen() was called.");
+};
+
+ws._onmessage_ = function(event)
+{
+var message = event.data;
+sequence++;
+if (sequence > 4) {
+testFailed("onmessage() was called. (message = \"" + message + "\")");
+} else {
+debug("onmessage() was called. (message = \"" + message + "\")");
+receivedText += message;
+}
+};
+
+ws._onclose_ = function(event)
+{
+debug("onclose() was called.");
+closeEvent = event;
+shouldBeTrue("closeEvent.wasClean");
+shouldBe("sequence", "4");
+shouldBe("receivedText", "expectedText");
+finishJSTest();
+};
+
+var successfullyParsed = true;
+
+