[webkit-changes] [102439] branches/chromium/963/Source/WebCore

[yurys]

Title: [102439] branches/chromium/963/Source/WebCore








Revision 102439
Author yu...@chromium.org
Date 2011-12-09 00:12:50 -0800 (Fri, 09 Dec 2011)


Log Message
Merge 102140 - [Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
https://bugs.webkit.org/show_bug.cgi?id=73892

Reviewed by Pavel Feldman.

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number
* inspector/Inspector.json: removed unused parameter


TBR=pfeld...@chromium.org
Review URL: http://codereview.chromium.org/8872059

Modified Paths

branches/chromium/963/Source/WebCore/ChangeLog
branches/chromium/963/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
branches/chromium/963/Source/WebCore/inspector/Inspector.json




Diff

Modified: branches/chromium/963/Source/WebCore/ChangeLog (102438 => 102439)

--- branches/chromium/963/Source/WebCore/ChangeLog	2011-12-09 07:26:47 UTC (rev 102438)
+++ branches/chromium/963/Source/WebCore/ChangeLog	2011-12-09 08:12:50 UTC (rev 102439)
@@ -1,3 +1,14 @@
+2011-12-06  Yury Semikhatsky  yu...@chromium.org
+
+[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
+https://bugs.webkit.org/show_bug.cgi?id=73892
+
+Reviewed by Pavel Feldman.
+
+* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number
+* inspector/Inspector.json: removed unused parameter
+
 2011-12-07  Dmitry Lomov  dslo...@google.com
 
 https://bugs.webkit.org/show_bug.cgi?id=74038


Modified: branches/chromium/963/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (102438 => 102439)

--- branches/chromium/963/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2011-12-09 07:26:47 UTC (rev 102438)
+++ branches/chromium/963/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2011-12-09 08:12:50 UTC (rev 102439)
@@ -167,7 +167,7 @@
 v8::Localv8::Object result = v8::Object::New();
 result-Set(v8::String::New(lineNumber), v8::Integer::New(lineNumber));
 result-Set(v8::String::New(columnNumber), v8::Integer::New(columnNumber));
-result-Set(v8::String::New(scriptId), function-GetScriptId());
+result-Set(v8::String::New(scriptId), function-GetScriptId()-ToString());
 return result;
 }
 


Modified: branches/chromium/963/Source/WebCore/inspector/Inspector.json (102438 => 102439)

--- branches/chromium/963/Source/WebCore/inspector/Inspector.json	2011-12-09 07:26:47 UTC (rev 102438)
+++ branches/chromium/963/Source/WebCore/inspector/Inspector.json	2011-12-09 08:12:50 UTC (rev 102439)
@@ -296,8 +296,7 @@
 { name: className, type: string, optional: true, description: Object class (constructor) name. Specified for codeobject/code type values only. },
 { name: value, type: any, optional: true, description: Remote object value (in case of primitive values or JSON values if it was requested). },
 { name: description, type: string, optional: true, description: String representation of the object. },
-{ name: objectId, $ref: RemoteObjectId, optional: true, description: Unique object identifier (for non-primitive values). },
-{ name: functionLocation, $ref: Debugger.Location, optional: true, description: Function location within owning script. }
+{ name: objectId, $ref: RemoteObjectId, optional: true, description: Unique object identifier (for non-primitive values). }
 ]
 },
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102440] trunk/Source/WebCore

[yurys]

Title: [102440] trunk/Source/WebCore








Revision 102440
Author yu...@chromium.org
Date 2011-12-09 00:33:02 -0800 (Fri, 09 Dec 2011)


Log Message
Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin peter.ry...@gmail.com on 2011-12-09
Reviewed by NOBODY.

Extends python generator functionality.
Makes constructor in InspectorObject public.

* inspector/CodeGeneratorInspector.py:
* inspector/InspectorValues.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
trunk/Source/WebCore/inspector/InspectorValues.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102439 => 102440)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 08:12:50 UTC (rev 102439)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 08:33:02 UTC (rev 102440)
@@ -1,3 +1,16 @@
+2011-12-09  Peter Rybin  peter.ry...@gmail.com
+
+Web Inspector: [protocol] generate C++ classes for protocol JSON named types
+https://bugs.webkit.org/show_bug.cgi?id=72835
+
+Reviewed by NOBODY.
+
+Extends python generator functionality.
+Makes constructor in InspectorObject public.
+
+* inspector/CodeGeneratorInspector.py:
+* inspector/InspectorValues.h:
+
 2011-12-08  Viatcheslav Ostapenko  ostapenko.viatches...@nokia.com
 
 [Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated.


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (102439 => 102440)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-09 08:12:50 UTC (rev 102439)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-09 08:33:02 UTC (rev 102440)
@@ -104,6 +104,12 @@
 
 class Capitalizer:
 @staticmethod
+def lower_camel_case_to_upper(str):
+if len(str)  0 and str[0].islower():
+str = str[0].upper() + str[1:]
+return str
+
+@staticmethod
 def upper_camel_case_to_lower(str):
 pos = 0
 while pos  len(str) and str[pos].isupper():
@@ -120,6 +126,43 @@
 str = possible_abbreviation.lower() + str[pos:]
 return str
 
+@staticmethod
+def camel_case_to_capitalized_with_underscores(str):
+if len(str) == 0:
+return str
+output = Capitalizer.split_camel_case_(str)
+return _.join(output).upper()
+
+@staticmethod
+def split_camel_case_(str):
+output = []
+pos_being = 0
+pos = 1
+has_oneletter = False
+while pos  len(str):
+if str[pos].isupper():
+output.append(str[pos_being:pos].upper())
+if pos - pos_being == 1:
+has_oneletter = True
+pos_being = pos
+pos += 1
+output.append(str[pos_being:])
+if has_oneletter:
+array_pos = 0
+while array_pos  len(output) - 1:
+if len(output[array_pos]) == 1:
+array_pos_end = array_pos + 1
+while array_pos_end  len(output) and len(output[array_pos_end]) == 1:
+array_pos_end += 1
+if array_pos_end - array_pos  1:
+possible_abbreviation = .join(output[array_pos:array_pos_end])
+if possible_abbreviation.upper() in Capitalizer.ABBREVIATION:
+output[array_pos:array_pos_end] = [possible_abbreviation]
+else:
+array_pos = array_pos_end - 1
+array_pos += 1
+return output
+
 ABBREVIATION = frozenset([XHR, DOM, CSS])
 
 
@@ -186,6 +229,8 @@
 return RawTypes.Int
 elif json_type == number:
 return RawTypes.Number
+elif json_type == any:
+return RawTypes.Any
 else:
 raise Exception(Unknown type: %s % json_type)
 
@@ -201,7 +246,7 @@
 class String(BaseType):
 @classmethod
 def get_c_param_type(cls, param_type, optional):
-if param_type == ParamType.EVENT:
+if param_type == ParamType.EVENT or param_type == ParamType.TYPE_BUILDER_OUTPUT:
 return cls._ref_c_type
 else:
 return cls._plain_c_type
@@ -296,7 +341,7 @@
 class Object(BaseType):
 @classmethod
 def get_c_param_type(cls, param_type, optional):
-if param_type == ParamType.EVENT:
+if param_type == ParamType.EVENT or param_type == ParamType.TYPE_BUILDER_OUTPUT:
 return cls._ref_c_type
 else:
 return cls._plain_c_type
@@ -322,6 +367,35 @@
 _plain_c_type = CParamType(RefPtrInspectorObject)
 _ref_c_type = CParamType(PassRefPtrInspectorObject)
 
+class Any(BaseType):
+@classmethod
+def get_c_param_type(cls, param_type, optional):
+  

[webkit-changes] [102441] trunk/Source/WebCore/ChangeLog

[yurys]

Title: [102441] trunk/Source/WebCore/ChangeLog








Revision 102441
Author yu...@chromium.org
Date 2011-12-09 00:43:35 -0800 (Fri, 09 Dec 2011)


Log Message
Fixed reviewer name in r102432 changelog entry.

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (102440 => 102441)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 08:33:02 UTC (rev 102440)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 08:43:35 UTC (rev 102441)
@@ -3,7 +3,7 @@
 Web Inspector: [protocol] generate C++ classes for protocol JSON named types
 https://bugs.webkit.org/show_bug.cgi?id=72835
 
-Reviewed by NOBODY.
+Reviewed by Yury Semikhatsky.
 
 Extends python generator functionality.
 Makes constructor in InspectorObject public.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102442] trunk/Source/JavaScriptCore

[oliver]

Title: [102442] trunk/Source/_javascript_Core








Revision 102442
Author oli...@apple.com
Date 2011-12-09 00:45:46 -0800 (Fri, 09 Dec 2011)


Log Message
Avoid reloading storage pointer for indexed properties unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=74136

Reviewed by Filip Pizlo.

Add a node to represent loading property storage for indexed properties.
This allows us to reduce code generated for sequential access of arrays,
strings, etc.  This results in up to 5% improvement in code that is
very heavy on indexed reads, such as matrix operations in typed arrays
and 20% faster on microbenchmarks.

Currently this is only supported by GetByVal and other similar indexed reads.

* bytecode/PredictedType.h:
(JSC::isFixedIndexedStorageObjectPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PredictedType.h
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102441 => 102442)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-09 08:43:35 UTC (rev 102441)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-09 08:45:46 UTC (rev 102442)
@@ -1,3 +1,44 @@
+2011-12-09  Oliver Hunt  oli...@apple.com
+
+Avoid reloading storage pointer for indexed properties unnecessarily
+https://bugs.webkit.org/show_bug.cgi?id=74136
+
+Reviewed by Filip Pizlo.
+
+Add a node to represent loading property storage for indexed properties.
+This allows us to reduce code generated for sequential access of arrays,
+strings, etc.  This results in up to 5% improvement in code that is 
+very heavy on indexed reads, such as matrix operations in typed arrays
+and 20% faster on microbenchmarks.
+
+Currently this is only supported by GetByVal and other similar indexed reads.
+
+* bytecode/PredictedType.h:
+(JSC::isFixedIndexedStorageObjectPrediction):
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::handleIntrinsic):
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGNode.h:
+* dfg/DFGPropagator.cpp:
+(JSC::DFG::Propagator::propagateNodePredictions):
+(JSC::DFG::Propagator::fixupNode):
+(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
+(JSC::DFG::Propagator::performNodeCSE):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
+(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
 2011-12-08  Fady Samuel  fsam...@chromium.org
 
 [Chromium] Enable viewport metatag


Modified: trunk/Source/_javascript_Core/bytecode/PredictedType.h (102441 => 102442)

--- trunk/Source/_javascript_Core/bytecode/PredictedType.h	2011-12-09 08:43:35 UTC (rev 102441)
+++ trunk/Source/_javascript_Core/bytecode/PredictedType.h	2011-12-09 08:45:46 UTC (rev 102442)
@@ -60,6 +60,7 @@
 static const PredictedType PredictBoolean   = 0x0002; // It's definitely a Boolean.
 static const PredictedType PredictOther = 0x4000; 

[webkit-changes] [102443] trunk/LayoutTests

[ossy]

Title: [102443] trunk/LayoutTests








Revision 102443
Author o...@webkit.org
Date 2011-12-09 00:53:24 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt] Unreviewed gardening. Add Qt specific expected results.

* platform/qt/animations/cross-fade-background-image-expected.png: Added.
* platform/qt/animations/cross-fade-background-image-expected.txt: Added.
* platform/qt/animations/cross-fade-border-image-source-expected.png: Added.
* platform/qt/animations/cross-fade-border-image-source-expected.txt: Added.
* platform/qt/animations/cross-fade-list-style-image-expected.png: Added.
* platform/qt/animations/cross-fade-list-style-image-expected.txt: Added.
* platform/qt/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
* platform/qt/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/qt/animations/cross-fade-webkit-mask-image-expected.txt: Added.
* platform/qt/transitions/cross-fade-background-image-expected.png: Added.
* platform/qt/transitions/cross-fade-background-image-expected.txt: Added.
* platform/qt/transitions/cross-fade-border-image-expected.png: Added.
* platform/qt/transitions/cross-fade-border-image-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/qt/animations/cross-fade-background-image-expected.png
trunk/LayoutTests/platform/qt/animations/cross-fade-background-image-expected.txt
trunk/LayoutTests/platform/qt/animations/cross-fade-border-image-source-expected.png
trunk/LayoutTests/platform/qt/animations/cross-fade-border-image-source-expected.txt
trunk/LayoutTests/platform/qt/animations/cross-fade-list-style-image-expected.png
trunk/LayoutTests/platform/qt/animations/cross-fade-list-style-image-expected.txt
trunk/LayoutTests/platform/qt/animations/cross-fade-webkit-mask-box-image-expected.png
trunk/LayoutTests/platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt
trunk/LayoutTests/platform/qt/animations/cross-fade-webkit-mask-image-expected.png
trunk/LayoutTests/platform/qt/animations/cross-fade-webkit-mask-image-expected.txt
trunk/LayoutTests/platform/qt/transitions/cross-fade-background-image-expected.png
trunk/LayoutTests/platform/qt/transitions/cross-fade-background-image-expected.txt
trunk/LayoutTests/platform/qt/transitions/cross-fade-border-image-expected.png
trunk/LayoutTests/platform/qt/transitions/cross-fade-border-image-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102442 => 102443)

--- trunk/LayoutTests/ChangeLog	2011-12-09 08:45:46 UTC (rev 102442)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 08:53:24 UTC (rev 102443)
@@ -1,3 +1,22 @@
+2011-12-09  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed gardening. Add Qt specific expected results.
+
+* platform/qt/animations/cross-fade-background-image-expected.png: Added.
+* platform/qt/animations/cross-fade-background-image-expected.txt: Added.
+* platform/qt/animations/cross-fade-border-image-source-expected.png: Added.
+* platform/qt/animations/cross-fade-border-image-source-expected.txt: Added.
+* platform/qt/animations/cross-fade-list-style-image-expected.png: Added.
+* platform/qt/animations/cross-fade-list-style-image-expected.txt: Added.
+* platform/qt/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
+* platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
+* platform/qt/animations/cross-fade-webkit-mask-image-expected.png: Added.
+* platform/qt/animations/cross-fade-webkit-mask-image-expected.txt: Added.
+* platform/qt/transitions/cross-fade-background-image-expected.png: Added.
+* platform/qt/transitions/cross-fade-background-image-expected.txt: Added.
+* platform/qt/transitions/cross-fade-border-image-expected.png: Added.
+* platform/qt/transitions/cross-fade-border-image-expected.txt: Added.
+
 2011-12-08  Kenichi Ishibashi  ba...@chromium.org
 
 Unreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html


Added: trunk/LayoutTests/platform/qt/animations/cross-fade-background-image-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt/animations/cross-fade-background-image-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/qt/animations/cross-fade-background-image-expected.txt (0 => 102443)

--- trunk/LayoutTests/platform/qt/animations/cross-fade-background-image-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt/animations/cross-fade-background-image-expected.txt	2011-12-09 08:53:24 UTC (rev 102443)
@@ -0,0 +1,22 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+

[webkit-changes] [102445] trunk

[ossy]

Title: [102445] trunk








Revision 102445
Author o...@webkit.org
Date 2011-12-09 01:11:26 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
https://bugs.webkit.org/show_bug.cgi?id=73990

Patch by Simon Hausmann simon.hausm...@nokia.com on 2011-12-09
Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.

Fix QtQuick includes after move from QtDeclarative to QtQuick.

Source/WebKit2:

* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/tests.pri: Tests need symbols from QtQuick, so link library.
* UIProcess/API/qt/tests/testwindow.h:
* UIProcess/qt/QtDialogRunner.cpp:
* UIProcess/qt/QtSGTileNode.cpp:
* UIProcess/qt/QtSGTileNode.h:
* UIProcess/qt/QtSGUpdateQueue.cpp:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
* UIProcess/qt/QtWebPageProxy.cpp:
* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

Tools:

* MiniBrowser/qt/BrowserWindow.h:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/testwindow.h
trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp
trunk/Source/WebKit2/UIProcess/qt/QtSGTileNode.cpp
trunk/Source/WebKit2/UIProcess/qt/QtSGTileNode.h
trunk/Source/WebKit2/UIProcess/qt/QtSGUpdateQueue.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.h
trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102444 => 102445)

--- trunk/Source/WebKit2/ChangeLog	2011-12-09 09:02:23 UTC (rev 102444)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-09 09:11:26 UTC (rev 102445)
@@ -1,3 +1,26 @@
+2011-12-09  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Fix compilation with newly separated Qt 5 QtQuick module
+https://bugs.webkit.org/show_bug.cgi?id=73990
+
+Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
+
+Fix QtQuick includes after move from QtDeclarative to QtQuick.
+
+* UIProcess/API/qt/qquickwebpage.cpp:
+* UIProcess/API/qt/qquickwebpage_p.h:
+* UIProcess/API/qt/qquickwebview.cpp:
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/tests/tests.pri: Tests need symbols from QtQuick, so link library.
+* UIProcess/API/qt/tests/testwindow.h:
+* UIProcess/qt/QtDialogRunner.cpp:
+* UIProcess/qt/QtSGTileNode.cpp:
+* UIProcess/qt/QtSGTileNode.h:
+* UIProcess/qt/QtSGUpdateQueue.cpp:
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+* UIProcess/qt/QtWebPageProxy.cpp:
+* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
+
 2011-12-09  Nayan Kumar K  naya...@motorola.com
 
 [WebKit2][gtk] Re-enable running TestWebKitSettings


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp (102444 => 102445)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp	2011-12-09 09:02:23 UTC (rev 102444)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp	2011-12-09 09:11:26 UTC (rev 102445)
@@ -26,10 +26,10 @@
 #include TransformationMatrix.h
 #include qquickwebpage_p_p.h
 #include qquickwebview_p.h
-#include QtCore/QUrl
-#include QtDeclarative/QSGGeometryNode
-#include QtDeclarative/QQuickCanvas
-#include QtDeclarative/QSGMaterial
+#include QUrl
+#include QtQuick/QQuickCanvas
+#include QtQuick/QSGGeometryNode
+#include QtQuick/QSGMaterial
 
 QQuickWebPage::QQuickWebPage(QQuickItem* parent)
 : QQuickItem(parent)


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h (102444 => 102445)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h	2011-12-09 09:02:23 UTC (rev 102444)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h	2011-12-09 09:11:26 UTC (rev 102445)
@@ -24,7 +24,7 @@
 #include qwebkitglobal.h
 
 #include QtCore/QSharedPointer
-#include QtDeclarative/QQuickItem
+#include QtQuick/QQuickItem
 
 class QQuickWebView;
 class QQuickWebPagePrivate;


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (102444 => 102445)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-09 09:02:23 UTC (rev 102444)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-09 09:11:26 UTC (rev 102445)
@@ -32,9 +32,9 @@
 #include qwebpreferences_p_p.h
 
 #include _javascript_Core/InitializeThreading.h
-#include QtDeclarative/QQuickCanvas
-#include QtWidgets/QFileDialog
-#include QtWidgets/QInputDialog
+#include QFileDialog
+#include QInputDialog

[webkit-changes] [102446] trunk/Tools

[haraken]

Title: [102446] trunk/Tools








Revision 102446
Author hara...@chromium.org
Date 2011-12-09 01:15:59 -0800 (Fri, 09 Dec 2011)


Log Message
REGRESSION(r102105): run-bindings-tests should output full diff results
https://bugs.webkit.org/show_bug.cgi?id=74166

Reviewed by Adam Barth.

Since r102105, the output of run-bindings-tests is truncated to 500 characters.
run-bindings-tests should output full diff results.

* Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/bindings/main.py




Diff

Modified: trunk/Tools/ChangeLog (102445 => 102446)

--- trunk/Tools/ChangeLog	2011-12-09 09:11:26 UTC (rev 102445)
+++ trunk/Tools/ChangeLog	2011-12-09 09:15:59 UTC (rev 102446)
@@ -1,3 +1,18 @@
+2011-12-09  Kentaro Hara  hara...@chromium.org
+
+REGRESSION(r102105): run-bindings-tests should output full diff results
+https://bugs.webkit.org/show_bug.cgi?id=74166
+
+Reviewed by Adam Barth.
+
+Since r102105, the output of run-bindings-tests is truncated to 500 characters.
+run-bindings-tests should output full diff results.
+
+* Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
+(BindingsTests.generate_from_idl):
+(BindingsTests.generate_supplemental_dependency):
+(BindingsTests.detect_changes):
+
 2011-12-09  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Fix compilation with newly separated Qt 5 QtQuick module


Modified: trunk/Tools/Scripts/webkitpy/bindings/main.py (102445 => 102446)

--- trunk/Tools/Scripts/webkitpy/bindings/main.py	2011-12-09 09:11:26 UTC (rev 102445)
+++ trunk/Tools/Scripts/webkitpy/bindings/main.py	2011-12-09 09:15:59 UTC (rev 102446)
@@ -58,7 +58,7 @@
 if output:
 print output
 except ScriptError, e:
-print e.message_with_output()
+print e.output
 exit_code = e.exit_code
 return exit_code
 
@@ -84,7 +84,7 @@
 if output:
 print output
 except ScriptError, e:
-print e.message_with_output()
+print e.output
 exit_code = e.exit_code
 os.remove(idl_files_list[1])
 return exit_code
@@ -102,7 +102,7 @@
 try:
 output = self.executive.run_command(cmd)
 except ScriptError, e:
-output = e.message_with_output()
+output = e.output
 exit_code = e.exit_code
 
 if exit_code or output:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102447] trunk

[vsevik]

Title: [102447] trunk








Revision 102447
Author vse...@chromium.org
Date 2011-12-09 01:25:58 -0800 (Fri, 09 Dec 2011)


Log Message
Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects.
https://bugs.webkit.org/show_bug.cgi?id=74084

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/map.html

* inspector/front-end/treeoutline.js:
(TreeOutline):
():
(TreeElement.prototype.collapse):
(TreeElement.prototype.expand):
* inspector/front-end/utilities.js:
():

LayoutTests:

* inspector/map-expected.txt: Added.
* inspector/map.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/treeoutline.js
trunk/Source/WebCore/inspector/front-end/utilities.js


Added Paths

trunk/LayoutTests/inspector/map-expected.txt
trunk/LayoutTests/inspector/map.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102446 => 102447)

--- trunk/LayoutTests/ChangeLog	2011-12-09 09:15:59 UTC (rev 102446)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 09:25:58 UTC (rev 102447)
@@ -1,3 +1,13 @@
+2011-12-08  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects.
+https://bugs.webkit.org/show_bug.cgi?id=74084
+
+Reviewed by Pavel Feldman.
+
+* inspector/map-expected.txt: Added.
+* inspector/map.html: Added.
+
 2011-12-09  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed gardening. Add Qt specific expected results.


Added: trunk/LayoutTests/inspector/map-expected.txt (0 => 102447)

--- trunk/LayoutTests/inspector/map-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/map-expected.txt	2011-12-09 09:25:58 UTC (rev 102447)
@@ -0,0 +1,100 @@
+Tests Map class.
+
+Bug 74084
+Dumping maps:
+  First map:
+key1 : undefined
+key2 : undefined
+  Second map:
+key1 : undefined
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : 2
+key2 : undefined
+  Second map:
+key1 : undefined
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : undefined
+  Second map:
+key1 : undefined
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : undefined
+  Second map:
+key1 : 1
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : undefined
+  Second map:
+key1 : 2
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : 2
+  Second map:
+key1 : 2
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : 2
+  Second map:
+key1 : 2
+key2 : 1
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : undefined
+  Second map:
+key1 : 2
+key2 : 1
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : undefined
+  Second map:
+key1 : 2
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : 1
+key2 : undefined
+  Second map:
+key1 : 2
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : undefined
+key2 : undefined
+  Second map:
+key1 : 2
+key2 : undefined
+
+Dumping maps:
+  First map:
+key1 : undefined
+key2 : undefined
+  Second map:
+key1 : undefined
+key2 : undefined
+
+
Property changes on: trunk/LayoutTests/inspector/map-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/map.html (0 => 102447)

--- trunk/LayoutTests/inspector/map.html	(rev 0)
+++ trunk/LayoutTests/inspector/map.html	2011-12-09 09:25:58 UTC (rev 102447)
@@ -0,0 +1,71 @@
+html
+head
+script src=""
+script type=text/_javascript_
+
+var test = function()
+{
+function dumpMaps(map1, map2, key1, key2)
+{
+InspectorTest.addResult(Dumping maps:);
+InspectorTest.addResult(  First map:);
+InspectorTest.addResult(key1 :  + map1.get(key1));
+InspectorTest.addResult(key2 :  + map1.get(key2));
+InspectorTest.addResult(  Second map:);
+InspectorTest.addResult(key1 :  + map2.get(key1));
+InspectorTest.addResult(key2 :  + map2.get(key2));
+InspectorTest.addResult();
+}
+
+var key1 = {};
+var key2 = {};
+var value1 = 1;
+var value2 = 2;
+var map1 = new Map();
+var map2 = new Map();
+
+dumpMaps(map1, map2, key1, key2);
+
+map1.put(key1, value2);
+dumpMaps(map1, map2, key1, key2);
+
+map1.put(key1, value1);
+dumpMaps(map1, map2, key1, key2);
+
+map2.put(key1, value1);
+dumpMaps(map1, map2, key1, key2);
+
+map2.put(key1, value2);
+dumpMaps(map1, map2, key1, key2);
+
+map1.put(key2, value2);
+dumpMaps(map1, map2, key1, key2);
+
+map2.put(key2, value1);
+dumpMaps(map1, map2, key1, key2);
+
+map1.remove(key2);
+dumpMaps(map1, map2, key1, key2);
+
+map2.remove(key2);
+dumpMaps(map1, map2, key1, key2);
+
+

[webkit-changes] [102449] trunk/LayoutTests

[bashi]

Title: [102449] trunk/LayoutTests








Revision 102449
Author ba...@chromium.org
Date 2011-12-09 02:23:08 -0800 (Fri, 09 Dec 2011)


Log Message
Unreviewed, chromium test expectation update.

Patch by Kenichi Ishibashi ba...@chromium.org on 2011-12-09

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102448 => 102449)

--- trunk/LayoutTests/ChangeLog	2011-12-09 09:40:49 UTC (rev 102448)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 10:23:08 UTC (rev 102449)
@@ -1,3 +1,9 @@
+2011-12-09  Kenichi Ishibashi  ba...@chromium.org
+
+Unreviewed, chromium test expectation update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-08  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102448 => 102449)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-09 09:40:49 UTC (rev 102448)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-09 10:23:08 UTC (rev 102449)
@@ -3799,7 +3799,12 @@
 
 BUGWK74055 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT
 
-BUGWK74157 SNOWLEOPARD : animations/cross-fade-border-image-source.html = IMAGE+TEXT
-BUGWK74157 SNOWLEOPARD LEOPARD : transitions/cross-fade-border-image.html = IMAGE+TEXT
+BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-background-image.html = PASS IMAGE+TEXT
+BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-border-image-source.html = PASS IMAGE+TEXT
+BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-list-style-image.html = PASS IMAGE+TEXT
+BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-webkit-mask-box-image.html = PASS IMAGE+TEXT
+BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-webkit-mask-image.html = PASS IMAGE+TEXT
+BUGWK74157 SNOWLEOPARD LEOPARD  : transitions/cross-fade-background-image.html = PASS IMAGE+TEXT
+BUGWK74157 SNOWLEOPARD LEOPARD  : transitions/cross-fade-border-image.html = PASS IMAGE+TEXT
 
 BUGWK74167 WIN LINUX : fast/replaced/width100percent-textarea.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102450] trunk/Source/WebCore

[vsevik]

Title: [102450] trunk/Source/WebCore








Revision 102450
Author vse...@chromium.org
Date 2011-12-09 03:49:07 -0800 (Fri, 09 Dec 2011)


Log Message
Unreviewed inspector utilities syntax fix.

* inspector/front-end/utilities.js:
():

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/utilities.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (102449 => 102450)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 10:23:08 UTC (rev 102449)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 11:49:07 UTC (rev 102450)
@@ -1,3 +1,10 @@
+2011-12-09  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed inspector utilities syntax fix.
+
+* inspector/front-end/utilities.js:
+():
+
 2011-12-09  Joone Hur  joone@collabora.co.uk, Gustavo Noronha Silva  gustavo.noro...@collabora.co.uk 
 
 [GTK] Initial implementation of Accelerated Compositing using Clutter


Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (102449 => 102450)

--- trunk/Source/WebCore/inspector/front-end/utilities.js	2011-12-09 10:23:08 UTC (rev 102449)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js	2011-12-09 11:49:07 UTC (rev 102450)
@@ -1153,7 +1153,7 @@
 /**
  * @constructor
  */
-Map = function()
+var Map = function()
 {
 this._map = {};
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102451] trunk/Tools

[ossy]

Title: [102451] trunk/Tools








Revision 102451
Author o...@webkit.org
Date 2011-12-09 06:01:34 -0800 (Fri, 09 Dec 2011)


Log Message
Unreviewed. Update unit test after r102412.

* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (102450 => 102451)

--- trunk/Tools/ChangeLog	2011-12-09 11:49:07 UTC (rev 102450)
+++ trunk/Tools/ChangeLog	2011-12-09 14:01:34 UTC (rev 102451)
@@ -1,3 +1,10 @@
+2011-12-09  Csaba Osztrogonác  o...@webkit.org
+
+Unreviewed. Update unit test after r102412.
+
+* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
+(IRCCommandTest.test_whois):
+
 2011-12-09  Kentaro Hara  hara...@chromium.org
 
 REGRESSION(r102105): run-bindings-tests should output full diff results


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py (102450 => 102451)

--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py	2011-12-09 11:49:07 UTC (rev 102450)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py	2011-12-09 14:01:34 UTC (rev 102451)
@@ -58,7 +58,7 @@
   whois.execute(tom, [lopez], None, None))
 self.assertEquals('tom: Vicki Murley vi...@apple.com hasn\'t told me their nick. Boo hoo :-(',
   whois.execute(tom, [vi...@apple.com], None, None))
-self.assertEquals('tom: I\'m not sure who you mean?  eroman, ericu, eric_carlson, or eseidel could be \'Eric\'.',
+self.assertEquals('tom: I\'m not sure who you mean?  epenner, eroman, ericu, eric_carlson, or eseidel could be \'Eric\'.',
   whois.execute(tom, [Eric], None, None))
 self.assertEquals('tom: More than 5 contributors match \'david\', could you be more specific?',
   whois.execute(tom, [david], None, None))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102452] trunk/Tools

[vestbo]

Title: [102452] trunk/Tools








Revision 102452
Author ves...@webkit.org
Date 2011-12-09 06:48:05 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake

The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
this failed when moving files in the source tree, as the .d file would contain
stale dependencies on the old source file location. By keeping the object files
(and hence the depdendency files) in a proper tree structure inside the objects
directory we can prevent this failure.

A side benefit is that we can also have objects with the same name inside the
same project.

Reviewed by Simon Hausmann.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf




Diff

Modified: trunk/Tools/ChangeLog (102451 => 102452)

--- trunk/Tools/ChangeLog	2011-12-09 14:01:34 UTC (rev 102451)
+++ trunk/Tools/ChangeLog	2011-12-09 14:48:05 UTC (rev 102452)
@@ -1,3 +1,20 @@
+2011-12-09  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
+
+The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
+this failed when moving files in the source tree, as the .d file would contain
+stale dependencies on the old source file location. By keeping the object files
+(and hence the depdendency files) in a proper tree structure inside the objects
+directory we can prevent this failure.
+
+A side benefit is that we can also have objects with the same name inside the
+same project.
+
+Reviewed by Simon Hausmann.
+
+* qmake/mkspecs/features/unix/default_pre.prf:
+
 2011-12-09  Csaba Osztrogonác  o...@webkit.org
 
 Unreviewed. Update unit test after r102412.


Modified: trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf (102451 => 102452)

--- trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf	2011-12-09 14:01:34 UTC (rev 102451)
+++ trunk/Tools/qmake/mkspecs/features/unix/default_pre.prf	2011-12-09 14:48:05 UTC (rev 102452)
@@ -9,7 +9,7 @@
 # Assume we use GNU make and a non-ancient GCC (compatible)
 # compiler that supports the -MD option. Relies on changes
 # introduced in Qt 5 to work correctly.
-haveQt(5): CONFIG += GNUmake gcc_MD_depends
+haveQt(5): CONFIG += GNUmake gcc_MD_depends object_parallel_to_source
 
 # Expose if we are building inside Scratchbox
 SBOX_CHECK = $$(_SBOX_DIR)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102453] trunk/Source/WebKit2

[commit-queue]

Title: [102453] trunk/Source/WebKit2








Revision 102453
Author commit-qu...@webkit.org
Date 2011-12-09 07:19:05 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
https://bugs.webkit.org/show_bug.cgi?id=73994

Patch by Michael Brüning michael.brun...@nokia.com on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/html/scroll.html: Corrected html and
added some coloring.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest): Corrected calculation
of expected value.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/html/scroll.html
trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102452 => 102453)

--- trunk/Source/WebKit2/ChangeLog	2011-12-09 14:48:05 UTC (rev 102452)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-09 15:19:05 UTC (rev 102453)
@@ -1,3 +1,16 @@
+2011-12-09  Michael Brüning  michael.brun...@nokia.com
+
+[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
+https://bugs.webkit.org/show_bug.cgi?id=73994
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/API/qt/tests/html/scroll.html: Corrected html and
+added some coloring.
+* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
+(tst_QQuickWebView::scrollRequest): Corrected calculation
+of expected value.
+
 2011-12-09  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Fix compilation with newly separated Qt 5 QtQuick module


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/html/scroll.html (102452 => 102453)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/html/scroll.html	2011-12-09 14:48:05 UTC (rev 102452)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/html/scroll.html	2011-12-09 15:19:05 UTC (rev 102453)
@@ -5,28 +5,26 @@
 window.scrollBy(0,50); // horizontal and vertical scroll increments
 }
 /script 
+style
+body {
+background-color: blue;
+margin: 50 50 50 50;
+}
+div {
+font-color: white;
+background-color: green;
+width: 300;
+height: 1000;
+} 
+/style
+
 head
-pScroll test /p
+titleScroll test /title
 /head
 body _onload_=pageScroll()
-brbr
-pThis is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page This is a test page 

[webkit-changes] [102454] trunk

[caryclark]

Title: [102454] trunk








Revision 102454
Author carycl...@google.com
Date 2011-12-09 08:18:37 -0800 (Fri, 09 Dec 2011)


Log Message
Source/WebKit/chromium: Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118

Reviewed by Adam Barth.

* DEPS:

Tools: layout_test update to accommodate new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(get):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_versions):
(ChromiumMacPortTest.test_graphics_type):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102453 => 102454)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-09 16:18:37 UTC (rev 102454)
@@ -1,3 +1,12 @@
+2011-12-09  Cary Clark  carycl...@google.com
+
+Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac
+https://bugs.webkit.org/show_bug.cgi?id=74118
+
+Reviewed by Adam Barth.
+
+* DEPS:
+
 2011-12-08  Fady Samuel  fsam...@chromium.org
 
 [Chromium] Enable viewport metatag


Modified: trunk/Source/WebKit/chromium/DEPS (102453 => 102454)

--- trunk/Source/WebKit/chromium/DEPS	2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Source/WebKit/chromium/DEPS	2011-12-09 16:18:37 UTC (rev 102454)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '113603',
+  'chromium_rev': '113807',
   'nacl_svn': 'http://src.chromium.org/native_client/trunk',
   'nacl_rev': '7169',
 }


Modified: trunk/Tools/ChangeLog (102453 => 102454)

--- trunk/Tools/ChangeLog	2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/ChangeLog	2011-12-09 16:18:37 UTC (rev 102454)
@@ -1,3 +1,18 @@
+2011-12-09  Cary Clark  carycl...@google.com
+
+layout_test update to accommodate new use_skia=1 default on Chromium-Mac
+https://bugs.webkit.org/show_bug.cgi?id=74118
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+(get):
+* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+(ChromiumMacPort.__init__):
+* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
+(ChromiumMacPortTest.test_versions):
+(ChromiumMacPortTest.test_graphics_type):
+
 2011-12-09  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (102453 => 102454)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py	2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py	2011-12-09 16:18:37 UTC (rev 102454)
@@ -42,7 +42,7 @@
 elif platform.startswith('linux'):
 port_name = 'chromium-gpu-linux'
 elif platform == 'darwin':
-port_name = 'chromium-gpu-cg-mac'
+port_name = 'chromium-gpu-mac'
 else:
 raise NotImplementedError('unsupported platform: %s' % platform)
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py (102453 => 102454)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py	2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py	2011-12-09 16:18:37 UTC (rev 102454)
@@ -112,7 +112,7 @@
 def __init__(self, host, port_name=None, os_version_string=None, **kwargs):
 # We're a little generic here because this code is reused by the
 # 'google-chrome' port as well as the 'mock-' and 'dryrun-' ports.
-port_name = port_name or 'chromium-cg-mac'
+port_name = port_name or 'chromium-mac'
 chromium.ChromiumPort.__init__(self, host, port_name=port_name, **kwargs)
 if port_name.endswith('-mac'):
 self._version = mac.os_version(os_version_string, self.SUPPORTED_OS_VERSIONS)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py (102453 => 102454)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py	2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py	2011-12-09 16:18:37 UTC (rev 102454)
@@ -46,26 +46,26 @@
 self.assertEquals(expected, port.name())
 
 def test_versions(self):
-self.assertTrue(self.make_port().name() in 

[webkit-changes] [102456] trunk/Source/WebCore

[jocelyn . turcotte]

Title: [102456] trunk/Source/WebCore








Revision 102456
Author jocelyn.turco...@nokia.com
Date 2011-12-09 09:38:17 -0800 (Fri, 09 Dec 2011)


Log Message
Inspector: Don't translate the context when rendering the highlights on a tiled layer.
https://bugs.webkit.org/show_bug.cgi?id=74085

Reviewed by Kenneth Rohde Christiansen.

When the frame view is using fixed layouting, the page overlay is the size of the whole
page and the context shouldn't be translated. The visible rect is still used in that
case to display element titles within the visible rect.

Also:
- Rename overlayRect to visibleRect to reduce confusion in this case.
- Remove the superfluous boundingBox check.

* inspector/DOMNodeHighlighter.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102455 => 102456)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 17:35:12 UTC (rev 102455)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 17:38:17 UTC (rev 102456)
@@ -1,3 +1,20 @@
+2011-12-08  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+Inspector: Don't translate the context when rendering the highlights on a tiled layer.
+https://bugs.webkit.org/show_bug.cgi?id=74085
+
+Reviewed by Kenneth Rohde Christiansen.
+
+When the frame view is using fixed layouting, the page overlay is the size of the whole
+page and the context shouldn't be translated. The visible rect is still used in that
+case to display element titles within the visible rect.
+
+Also:
+- Rename overlayRect to visibleRect to reduce confusion in this case.
+- Remove the superfluous boundingBox check.
+
+* inspector/DOMNodeHighlighter.cpp:
+
 2011-12-09  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed inspector utilities syntax fix.


Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (102455 => 102456)

--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-12-09 17:35:12 UTC (rev 102455)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-12-09 17:38:17 UTC (rev 102456)
@@ -221,7 +221,7 @@
 }
 }
 
-void drawElementTitle(GraphicsContext context, Node* node, RenderObject* renderer, const LayoutRect boundingBox, const LayoutRect anchorBox, const FloatRect overlayRect, WebCore::Settings* settings)
+void drawElementTitle(GraphicsContext context, Node* node, RenderObject* renderer, const LayoutRect boundingBox, const LayoutRect anchorBox, const FloatRect visibleRect, WebCore::Settings* settings)
 {
 
 DEFINE_STATIC_LOCAL(Color, backgroundColor, (255, 255, 194));
@@ -292,25 +292,25 @@
 LayoutUnit dx = -borderWidthPx;
 LayoutUnit dy = borderWidthPx;
 
-// If the tip sticks beyond the right of overlayRect, right-align the tip with the said boundary.
-if (titleRect.maxX() + dx  overlayRect.maxX())
-dx = overlayRect.maxX() - titleRect.maxX();
+// If the tip sticks beyond the right of visibleRect, right-align the tip with the said boundary.
+if (titleRect.maxX() + dx  visibleRect.maxX())
+dx = visibleRect.maxX() - titleRect.maxX();
 
-// If the tip sticks beyond the left of overlayRect, left-align the tip with the said boundary.
-if (titleRect.x() + dx  overlayRect.x())
-dx = overlayRect.x() - titleRect.x() - borderWidthPx;
+// If the tip sticks beyond the left of visibleRect, left-align the tip with the said boundary.
+if (titleRect.x() + dx  visibleRect.x())
+dx = visibleRect.x() - titleRect.x() - borderWidthPx;
 
-// If the tip sticks beyond the bottom of overlayRect, show the tip at top of bounding box.
-if (titleRect.maxY() + dy  overlayRect.maxY()) {
+// If the tip sticks beyond the bottom of visibleRect, show the tip at top of bounding box.
+if (titleRect.maxY() + dy  visibleRect.maxY()) {
 dy = anchorBox.y() - titleRect.maxY() - borderWidthPx;
-// If the tip still sticks beyond the bottom of overlayRect, bottom-align the tip with the said boundary.
-if (titleRect.maxY() + dy  overlayRect.maxY())
-dy = overlayRect.maxY() - titleRect.maxY();
+// If the tip still sticks beyond the bottom of visibleRect, bottom-align the tip with the said boundary.
+if (titleRect.maxY() + dy  visibleRect.maxY())
+dy = visibleRect.maxY() - titleRect.maxY();
 }
 
-// If the tip sticks beyond the top of overlayRect, show the tip at top of overlayRect.
-if (titleRect.y() + dy  overlayRect.y())
-dy = overlayRect.y() - titleRect.y() + borderWidthPx;
+// If the tip sticks beyond the top of visibleRect, show the tip at top of visibleRect.
+if (titleRect.y() + dy  visibleRect.y())
+dy = visibleRect.y() - titleRect.y() + borderWidthPx;
 
 titleRect.move(dx, dy);
 
@@ -376,10 +376,10 @@
 LayoutRect titleAnchorBox = boundingBox;
 
 FrameView* view = containingFrame-page()-mainFrame()-view();

[webkit-changes] [102457] trunk/Source/WebKit2

[jocelyn . turcotte]

Title: [102457] trunk/Source/WebKit2








Revision 102457
Author jocelyn.turco...@nokia.com
Date 2011-12-09 09:40:53 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt] Update WebGraphicLayer's child content scale in all child binding method.
https://bugs.webkit.org/show_bug.cgi?id=74101

Reviewed by Noam Rosenthal.

setChildren is currently the only method propagating the parent layer's content
scale to its children. This need to be done for addChild* as well.

This fixes the overlay layer not being rendered with the right scale when created
until the contents scale is modified again.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102456 => 102457)

--- trunk/Source/WebKit2/ChangeLog	2011-12-09 17:38:17 UTC (rev 102456)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-09 17:40:53 UTC (rev 102457)
@@ -1,3 +1,24 @@
+2011-12-08  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+[Qt] Update WebGraphicLayer's child content scale in all child binding method.
+https://bugs.webkit.org/show_bug.cgi?id=74101
+
+Reviewed by Noam Rosenthal.
+
+setChildren is currently the only method propagating the parent layer's content
+scale to its children. This need to be done for addChild* as well.
+
+This fixes the overlay layer not being rendered with the right scale when created
+until the contents scale is modified again.
+
+* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
+(WebCore::WebGraphicsLayer::setChildren):
+(WebCore::WebGraphicsLayer::addChild):
+(WebCore::WebGraphicsLayer::addChildAtIndex):
+(WebCore::WebGraphicsLayer::addChildAbove):
+(WebCore::WebGraphicsLayer::addChildBelow):
+(WebCore::WebGraphicsLayer::replaceChild):
+
 2011-12-09  Michael Brüning  michael.brun...@nokia.com
 
 [Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp (102456 => 102457)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp	2011-12-09 17:38:17 UTC (rev 102456)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp	2011-12-09 17:40:53 UTC (rev 102457)
@@ -117,6 +117,7 @@
 void WebGraphicsLayer::addChild(GraphicsLayer* layer)
 {
 GraphicsLayer::addChild(layer);
+toWebGraphicsLayer(layer)-setContentsScale(m_contentsScale);
 toWebGraphicsLayer(layer)-notifyChange();
 notifyChange();
 }
@@ -124,6 +125,7 @@
 void WebGraphicsLayer::addChildAtIndex(GraphicsLayer* layer, int index)
 {
 GraphicsLayer::addChildAtIndex(layer, index);
+toWebGraphicsLayer(layer)-setContentsScale(m_contentsScale);
 toWebGraphicsLayer(layer)-notifyChange();
 notifyChange();
 }
@@ -131,6 +133,7 @@
 void WebGraphicsLayer::addChildAbove(GraphicsLayer* layer, GraphicsLayer* sibling)
 {
 GraphicsLayer::addChildAbove(layer, sibling);
+toWebGraphicsLayer(layer)-setContentsScale(m_contentsScale);
 toWebGraphicsLayer(layer)-notifyChange();
 notifyChange();
 }
@@ -138,6 +141,7 @@
 void WebGraphicsLayer::addChildBelow(GraphicsLayer* layer, GraphicsLayer* sibling)
 {
 GraphicsLayer::addChildBelow(layer, sibling);
+toWebGraphicsLayer(layer)-setContentsScale(m_contentsScale);
 toWebGraphicsLayer(layer)-notifyChange();
 notifyChange();
 }
@@ -149,6 +153,7 @@
 return false;
 notifyChange();
 toWebGraphicsLayer(oldChild)-notifyChange();
+toWebGraphicsLayer(newChild)-setContentsScale(m_contentsScale);
 toWebGraphicsLayer(newChild)-notifyChange();
 return true;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102458] trunk/LayoutTests

[tony]

Title: [102458] trunk/LayoutTests








Revision 102458
Author t...@chromium.org
Date 2011-12-09 09:52:23 -0800 (Fri, 09 Dec 2011)


Log Message
[chromium] Update test_expectations.txt to match the bots.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102457 => 102458)

--- trunk/LayoutTests/ChangeLog	2011-12-09 17:40:53 UTC (rev 102457)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 17:52:23 UTC (rev 102458)
@@ -1,3 +1,9 @@
+2011-12-09  Tony Chang  t...@chromium.org
+
+[chromium] Update test_expectations.txt to match the bots.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-09  Kenichi Ishibashi  ba...@chromium.org
 
 Unreviewed, chromium test expectation update.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102457 => 102458)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-09 17:40:53 UTC (rev 102457)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-09 17:52:23 UTC (rev 102458)
@@ -3799,12 +3799,12 @@
 
 BUGWK74055 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT
 
-BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-background-image.html = PASS IMAGE+TEXT
-BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-border-image-source.html = PASS IMAGE+TEXT
-BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-list-style-image.html = PASS IMAGE+TEXT
-BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-webkit-mask-box-image.html = PASS IMAGE+TEXT
-BUGWK74157 SNOWLEOPARD LEOPARD  : animations/cross-fade-webkit-mask-image.html = PASS IMAGE+TEXT
-BUGWK74157 SNOWLEOPARD LEOPARD  : transitions/cross-fade-background-image.html = PASS IMAGE+TEXT
-BUGWK74157 SNOWLEOPARD LEOPARD  : transitions/cross-fade-border-image.html = PASS IMAGE+TEXT
+BUGWK74157 MAC : animations/cross-fade-background-image.html = PASS FAIL
+BUGWK74157 MAC : animations/cross-fade-border-image-source.html = PASS FAIL
+BUGWK74157 MAC : animations/cross-fade-list-style-image.html = PASS FAIL
+BUGWK74157 MAC : animations/cross-fade-webkit-mask-box-image.html = PASS FAIL
+BUGWK74157 MAC : animations/cross-fade-webkit-mask-image.html = PASS FAIL
+BUGWK74157 MAC : transitions/cross-fade-background-image.html = PASS FAIL
+BUGWK74157 MAC : transitions/cross-fade-border-image.html = PASS FAIL
 
 BUGWK74167 WIN LINUX : fast/replaced/width100percent-textarea.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102459] trunk/Source/JavaScriptCore

[enne]

Title: [102459] trunk/Source/_javascript_Core








Revision 102459
Author e...@google.com
Date 2011-12-09 10:59:21 -0800 (Fri, 09 Dec 2011)


Log Message
Fix HashMap..., OwnPtr... ::add compilation errors
https://bugs.webkit.org/show_bug.cgi?id=74159

Reviewed by Darin Adler.

Add a constructor to OwnPtr that takes the empty value (nullptr_t)
from HashTraits so that this function can compile.

* wtf/OwnPtr.h:
(WTF::OwnPtr::OwnPtr):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/OwnPtr.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102458 => 102459)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-09 17:52:23 UTC (rev 102458)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-09 18:59:21 UTC (rev 102459)
@@ -1,3 +1,16 @@
+2011-12-09  Adrienne Walker  e...@google.com
+
+Fix HashMap..., OwnPtr... ::add compilation errors
+https://bugs.webkit.org/show_bug.cgi?id=74159
+
+Reviewed by Darin Adler.
+
+Add a constructor to OwnPtr that takes the empty value (nullptr_t)
+from HashTraits so that this function can compile.
+
+* wtf/OwnPtr.h:
+(WTF::OwnPtr::OwnPtr):
+
 2011-12-09  Oliver Hunt  oli...@apple.com
 
 Avoid reloading storage pointer for indexed properties unnecessarily


Modified: trunk/Source/_javascript_Core/wtf/OwnPtr.h (102458 => 102459)

--- trunk/Source/_javascript_Core/wtf/OwnPtr.h	2011-12-09 17:52:23 UTC (rev 102458)
+++ trunk/Source/_javascript_Core/wtf/OwnPtr.h	2011-12-09 18:59:21 UTC (rev 102459)
@@ -41,6 +41,7 @@
 typedef ValueType* PtrType;
 
 OwnPtr() : m_ptr(0) { }
+OwnPtr(std::nullptr_t) : m_ptr(0) { }
 
 // See comment in PassOwnPtr.h for why this takes a const reference.
 templatetypename U OwnPtr(const PassOwnPtrU o);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102460] trunk/Source/WebCore

[andersca]

Title: [102460] trunk/Source/WebCore








Revision 102460
Author ander...@apple.com
Date 2011-12-09 11:34:56 -0800 (Fri, 09 Dec 2011)


Log Message
WebScrollbarPartAnimation should only know about the scrollbar it's animating
https://bugs.webkit.org/show_bug.cgi?id=74192

Reviewed by Sam Weinig.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here
so we don't have to do it in all the call sites.

(-[WebScrollbarPartAnimation startAnimation]):
Update the scrollbar painter.

(-[WebScrollbarPartAnimation setCurrentProgress:]):
Just invalidate the scrollbar we're animating.

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Update call sites to use the new designated initializer.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102459 => 102460)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 18:59:21 UTC (rev 102459)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 19:34:56 UTC (rev 102460)
@@ -1,3 +1,25 @@
+2011-12-09  Anders Carlsson  ander...@apple.com
+
+WebScrollbarPartAnimation should only know about the scrollbar it's animating
+https://bugs.webkit.org/show_bug.cgi?id=74192
+
+Reviewed by Sam Weinig.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
+Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here
+so we don't have to do it in all the call sites.
+
+(-[WebScrollbarPartAnimation startAnimation]):
+Update the scrollbar painter.
+
+(-[WebScrollbarPartAnimation setCurrentProgress:]):
+Just invalidate the scrollbar we're animating.
+
+(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
+Update call sites to use the new designated initializer.
+
 2011-12-08  Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 Inspector: Don't translate the context when rendering the highlights on a tiled layer.


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102459 => 102460)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 18:59:21 UTC (rev 102459)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 19:34:56 UTC (rev 102460)
@@ -274,35 +274,40 @@
 
 @interface WebScrollbarPartAnimation : NSAnimation
 {
-RetainPtrScrollbarPainter _scrollerPainter;
+Scrollbar* _scrollbar;
+RetainPtrScrollbarPainter _scrollbarPainter;
 FeatureToAnimate _featureToAnimate;
-ScrollAnimatorMac* _animator;
 CGFloat _startValue;
 CGFloat _endValue;
 }
-- (id)initWithScrollbarPainter:(ScrollbarPainter)scrollerPainter animate:(FeatureToAnimate)featureToAnimate scrollAnimator:(ScrollAnimatorMac*)scrollAnimator animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration;
+- (id)initWithScrollbar:(Scrollbar*)scrollbar featureToAnimate:(FeatureToAnimate)featureToAnimate animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration;
 @end
 
 @implementation WebScrollbarPartAnimation
 
-- (id)initWithScrollbarPainter:(ScrollbarPainter)scrollerPainter animate:(FeatureToAnimate)featureToAnimate scrollAnimator:(ScrollAnimatorMac*)scrollAnimator animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration
+- (id)initWithScrollbar:(Scrollbar*)scrollbar featureToAnimate:(FeatureToAnimate)featureToAnimate animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration
 {
 self = [super initWithDuration:duration animationCurve:NSAnimationEaseInOut];
 if (!self)
 return nil;
-
-_scrollerPainter = scrollerPainter;
+
+_scrollbar = scrollbar;
 _featureToAnimate = featureToAnimate;
-_animator = scrollAnimator;
 _startValue = startValue;
 _endValue = endValue;
-
-return self;
+
+[self setAnimationBlockingMode:NSAnimationNonblocking];
+
+return self;
 }
 
-- (void)setScrollbarPainter:(ScrollbarPainter)scrollerPainter
+- (void)startAnimation
 {
-_scrollerPainter = scrollerPainter;
+ASSERT(_scrollbar);
+
+_scrollbarPainter = scrollbarPainterForScrollbar(_scrollbar);
+
+[super startAnimation];
 }
 
 - (void)setStartValue:(CGFloat)startValue
@@ -319,8 +324,7 @@
 {
 [super setCurrentProgress:progress];
 
-if (!_animator)
-return;
+

[webkit-changes] [102461] trunk/LayoutTests

[tony]

Title: [102461] trunk/LayoutTests








Revision 102461
Author t...@chromium.org
Date 2011-12-09 11:48:46 -0800 (Fri, 09 Dec 2011)


Log Message
Try to deflake a repaint test on Chromium.  It looks like we're
calling lTC.display() before the inital layout.  Force a layout
before calling lTC.display().

Reviewed by Ojan Vafai.

* fast/replaced/width100percent-textarea.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/replaced/width100percent-textarea.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102460 => 102461)

--- trunk/LayoutTests/ChangeLog	2011-12-09 19:34:56 UTC (rev 102460)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 19:48:46 UTC (rev 102461)
@@ -1,5 +1,15 @@
 2011-12-09  Tony Chang  t...@chromium.org
 
+Try to deflake a repaint test on Chromium.  It looks like we're
+calling lTC.display() before the inital layout.  Force a layout
+before calling lTC.display().
+
+Reviewed by Ojan Vafai.
+
+* fast/replaced/width100percent-textarea.html:
+
+2011-12-09  Tony Chang  t...@chromium.org
+
 [chromium] Update test_expectations.txt to match the bots.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/fast/replaced/width100percent-textarea.html (102460 => 102461)

--- trunk/LayoutTests/fast/replaced/width100percent-textarea.html	2011-12-09 19:34:56 UTC (rev 102460)
+++ trunk/LayoutTests/fast/replaced/width100percent-textarea.html	2011-12-09 19:48:46 UTC (rev 102461)
@@ -6,8 +6,12 @@
 /head
 body
 script
-if (window.layoutTestController)
+if (window.layoutTestController) {
+// Force intial layout.
+document.body.offsetTop;
+
 layoutTestController.display();
+}
 /script
 
 The textareas below should not overlap.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102462] trunk/Source/WebCore

[andersca]

Title: [102462] trunk/Source/WebCore








Revision 102462
Author ander...@apple.com
Date 2011-12-09 12:15:08 -0800 (Fri, 09 Dec 2011)


Log Message
Remove duplicate animation ivars
https://bugs.webkit.org/show_bug.cgi?id=74194

Reviewed by Sam Weinig.

Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate
vertical/horizontal animation objects, so get rid of them.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102461 => 102462)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 19:48:46 UTC (rev 102461)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 20:15:08 UTC (rev 102462)
@@ -1,5 +1,22 @@
 2011-12-09  Anders Carlsson  ander...@apple.com
 
+Remove duplicate animation ivars
+https://bugs.webkit.org/show_bug.cgi?id=74194
+
+Reviewed by Sam Weinig.
+
+Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate
+vertical/horizontal animation objects, so get rid of them.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterDelegate cancelAnimations]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
+(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
+
+2011-12-09  Anders Carlsson  ander...@apple.com
+
 WebScrollbarPartAnimation should only know about the scrollbar it's animating
 https://bugs.webkit.org/show_bug.cgi?id=74192
 


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102461 => 102462)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 19:48:46 UTC (rev 102461)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 20:15:08 UTC (rev 102462)
@@ -361,14 +361,9 @@
 {
 WebCore::Scrollbar* _scrollbar;
 
-RetainPtrWebScrollbarPartAnimation _verticalKnobAnimation;
-RetainPtrWebScrollbarPartAnimation _horizontalKnobAnimation;
-
-RetainPtrWebScrollbarPartAnimation _verticalTrackAnimation;
-RetainPtrWebScrollbarPartAnimation _horizontalTrackAnimation;
-
-RetainPtrWebScrollbarPartAnimation _verticalUIStateTransitionAnimation;
-RetainPtrWebScrollbarPartAnimation _horizontalUIStateTransitionAnimation;
+RetainPtrWebScrollbarPartAnimation _knobAlphaAnimation;
+RetainPtrWebScrollbarPartAnimation _trackAlphaAnimation;
+RetainPtrWebScrollbarPartAnimation _uiStateTransitionAnimation;
 }
 - (id)initWithScrollbar:(WebCore::Scrollbar*)scrollbar;
 - (void)cancelAnimations;
@@ -389,12 +384,9 @@
 - (void)cancelAnimations
 {
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
-[_verticalKnobAnimation.get() stopAnimation];
-[_horizontalKnobAnimation.get() stopAnimation];
-[_verticalTrackAnimation.get() stopAnimation];
-[_horizontalTrackAnimation.get() stopAnimation];
-[_verticalUIStateTransitionAnimation.get() stopAnimation];
-[_horizontalUIStateTransitionAnimation.get() stopAnimation];
+[_knobAlphaAnimation.get() stopAnimation];
+[_trackAlphaAnimation.get() stopAnimation];
+[_uiStateTransitionAnimation.get() stopAnimation];
 END_BLOCK_OBJC_EXCEPTIONS;
 }
 
@@ -491,11 +483,10 @@
 if (!_scrollbar)
 return;
 
+ASSERT(scrollerImp == scrollbarPainterForScrollbar(_scrollbar));
+
 ScrollbarPainter scrollerPainter = (ScrollbarPainter)scrollerImp;
-if ([scrollerImp isHorizontal])
-[self setUpAlphaAnimation:_horizontalKnobAnimation scrollerPainter:scrollerPainter part:WebCore::ThumbPart animateAlphaTo:newKnobAlpha duration:duration];
-else
-[self setUpAlphaAnimation:_verticalKnobAnimation scrollerPainter:scrollerPainter part:WebCore::ThumbPart animateAlphaTo:newKnobAlpha duration:duration];
+[self setUpAlphaAnimation:_knobAlphaAnimation scrollerPainter:scrollerPainter part:WebCore::ThumbPart animateAlphaTo:newKnobAlpha duration:duration];
 }
 
 - (void)scrollerImp:(id)scrollerImp animateTrackAlphaTo:(CGFloat)newTrackAlpha duration:(NSTimeInterval)duration
@@ -503,11 +494,10 @@
 if (!_scrollbar)
 return;
 
+ASSERT(scrollerImp == scrollbarPainterForScrollbar(_scrollbar));
+
 ScrollbarPainter scrollerPainter = (ScrollbarPainter)scrollerImp;
-if ([scrollerImp isHorizontal])
-[self setUpAlphaAnimation:_horizontalTrackAnimation scrollerPainter:scrollerPainter 

[webkit-changes] [102465] trunk/Tools

[tony]

Title: [102465] trunk/Tools








Revision 102465
Author t...@chromium.org
Date 2011-12-09 12:36:45 -0800 (Fri, 09 Dec 2011)


Log Message
Switch the chromium mac bots to using skia test results
https://bugs.webkit.org/show_bug.cgi?id=74201

Reviewed by Ryosuke Niwa.

This is reverting http://trac.webkit.org/changeset/97781 and changing
the name in master.cfg to no longer have cg in the name.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
(RunWebKitTests.start):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (102464 => 102465)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2011-12-09 20:35:43 UTC (rev 102464)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2011-12-09 20:36:45 UTC (rev 102465)
@@ -54,10 +54,10 @@
 
 { name: google-windows-1, platform: chromium-win },
 { name: google-windows-2, platform: chromium-win },
-{ name: google-mac-1, platform: chromium-cg-mac },
-{ name: google-mac-2, platform: chromium-cg-mac },
-{ name: google-mac-3, platform: chromium-cg-mac },
-{ name: google-mac-4, platform: chromium-cg-mac },
+{ name: google-mac-1, platform: chromium-mac },
+{ name: google-mac-2, platform: chromium-mac },
+{ name: google-mac-3, platform: chromium-mac },
+{ name: google-mac-4, platform: chromium-mac },
 { name: google-linux-1, platform: chromium-linux },
 { name: google-linux-2, platform: chromium-linux },
 { name: google-linux-android, platform: chromium-android },
@@ -221,13 +221,13 @@
   slavenames: [google-windows-2]
 },
 {
-  name: Chromium Mac Release, type: Build, builddir: chromium-cg-mac-release,
-  platform: chromium-cg-mac, configuration: release, architectures: [i386],
+  name: Chromium Mac Release, type: Build, builddir: chromium-mac-release,
+  platform: chromium-mac, configuration: release, architectures: [i386],
   slavenames: [google-mac-1, google-mac-3]
 },
 {
-  name: Chromium Mac Release (Tests), type: NewBuildAndTest, builddir: chromium-cg-mac-release-tests,
-  platform: chromium-cg-mac, configuration: release, architectures: [i386],
+  name: Chromium Mac Release (Tests), type: NewBuildAndTest, builddir: chromium-mac-release-tests,
+  platform: chromium-mac, configuration: release, architectures: [i386],
   slavenames: [google-mac-2, google-mac-4]
 },
 {


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (102464 => 102465)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2011-12-09 20:35:43 UTC (rev 102464)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2011-12-09 20:36:45 UTC (rev 102465)
@@ -157,12 +157,9 @@
 haltOnFailure = False
 
 
-def appendCustomBuildFlags(step, platform, fullPlatform=, useFullPlatformForChromiumCGMac=False):
+def appendCustomBuildFlags(step, platform, fullPlatform=):
 if fullPlatform == chromium-android:
 step.setCommand(step.command + ['--chromium-android'])
-elif useFullPlatformForChromiumCGMac and fullPlatform.find('-cg-mac')  0:
-step.setCommand(step.command + ['--platform', fullPlatform])
-# Remove this code once Skia transition is done
 elif platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'):
 step.setCommand(step.command + ['--' + platform])
 
@@ -323,7 +320,7 @@
 
 def start(self):
 platform = self.getProperty('platform')
-appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'), True)
+appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
 if platform == win:
 rootArgument = ['--root=' + os.path.join(WebKitBuild, self.getProperty('configuration'), bin)]
 else:


Modified: trunk/Tools/ChangeLog (102464 => 102465)

--- trunk/Tools/ChangeLog	2011-12-09 20:35:43 UTC (rev 102464)
+++ trunk/Tools/ChangeLog	2011-12-09 20:36:45 UTC (rev 102465)
@@ -1,3 +1,18 @@
+2011-12-09  Tony Chang  t...@chromium.org
+
+Switch the chromium mac bots to using skia test results
+https://bugs.webkit.org/show_bug.cgi?id=74201
+
+Reviewed by Ryosuke Niwa.
+
+This is reverting 

[webkit-changes] [102467] trunk/Source/WebCore

[andersca]

Title: [102467] trunk/Source/WebCore








Revision 102467
Author ander...@apple.com
Date 2011-12-09 13:08:10 -0800 (Fri, 09 Dec 2011)


Log Message
WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74204

Reviewed by Sam Weinig.

It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since
painting has nothing to do with animation.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]):
(-[WebScrollbarPainterControllerDelegate invalidate]):
(-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102466 => 102467)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 20:52:00 UTC (rev 102466)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 21:08:10 UTC (rev 102467)
@@ -1,3 +1,24 @@
+2011-12-09  Anders Carlsson  ander...@apple.com
+
+WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac
+https://bugs.webkit.org/show_bug.cgi?id=74204
+
+Reviewed by Sam Weinig.
+
+It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since
+painting has nothing to do with animation.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]):
+(-[WebScrollbarPainterControllerDelegate invalidate]):
+(-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
+(-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
+(-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
+(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
+(-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
+(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
+(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
+
 2011-12-09  Jarred Nicholls  jar...@sencha.com
 
 [JSC] Allow cached attributes in bindings that declare a custom mark function


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102466 => 102467)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 20:52:00 UTC (rev 102466)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 21:08:10 UTC (rev 102467)
@@ -176,67 +176,67 @@
 
 @interface WebScrollbarPainterControllerDelegate : NSObject
 {
-WebCore::ScrollAnimatorMac* _animator;
+ScrollableArea* _scrollableArea;
 }
-- (id)initWithScrollAnimator:(WebCore::ScrollAnimatorMac*)scrollAnimator;
+- (id)initWithScrollableArea:(ScrollableArea*)scrollableArea;
 @end
 
 @implementation WebScrollbarPainterControllerDelegate
 
-- (id)initWithScrollAnimator:(WebCore::ScrollAnimatorMac*)scrollAnimator
+- (id)initWithScrollableArea:(ScrollableArea*)scrollableArea
 {
 self = [super init];
 if (!self)
 return nil;
 
-_animator = scrollAnimator;
+_scrollableArea = scrollableArea;
 return self;
 }
 
-- (void)scrollAnimatorDestroyed
+- (void)invalidate
 {
-_animator = 0;
+_scrollableArea = 0;
 }
 
 - (NSRect)contentAreaRectForScrollerImpPair:(id)scrollerImpPair
 {
 UNUSED_PARAM(scrollerImpPair);
-if (!_animator)
+if (!_scrollableArea)
 return NSZeroRect;
 
-WebCore::IntSize contentsSize = _animator-scrollableArea()-contentsSize();
+WebCore::IntSize contentsSize = _scrollableArea-contentsSize();
 return NSMakeRect(0, 0, contentsSize.width(), contentsSize.height());
 }
 
 - (BOOL)inLiveResizeForScrollerImpPair:(id)scrollerImpPair
 {
 UNUSED_PARAM(scrollerImpPair);
-if (!_animator)
+if (!_scrollableArea)
 return NO;
 
-return _animator-scrollableArea()-inLiveResize();
+return _scrollableArea-inLiveResize();
 }
 
 - (NSPoint)mouseLocationInContentAreaForScrollerImpPair:(id)scrollerImpPair
 {
 UNUSED_PARAM(scrollerImpPair);
-if (!_animator)
+if (!_scrollableArea)
 return NSZeroPoint;
 
-return _animator-scrollableArea()-currentMousePosition();
+return _scrollableArea-currentMousePosition();
 }
 
 - 

[webkit-changes] [102468] trunk/Source/WebCore

[andersca]

Title: [102468] trunk/Source/WebCore








Revision 102468
Author ander...@apple.com
Date 2011-12-09 13:16:46 -0800 (Fri, 09 Dec 2011)


Log Message
Rename scrollAnimatorDestroyed to invalidate
https://bugs.webkit.org/show_bug.cgi?id=74206

Reviewed by Sam Weinig.

Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is
destroyed, rename it to something more neutral.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollAnimationHelperDelegate invalidate]):
(-[WebScrollbarPartAnimation invalidate]):
(-[WebScrollbarPainterDelegate invalidate]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102467 => 102468)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 21:08:10 UTC (rev 102467)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 21:16:46 UTC (rev 102468)
@@ -1,5 +1,23 @@
 2011-12-09  Anders Carlsson  ander...@apple.com
 
+Rename scrollAnimatorDestroyed to invalidate
+https://bugs.webkit.org/show_bug.cgi?id=74206
+
+Reviewed by Sam Weinig.
+
+Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is
+destroyed, rename it to something more neutral.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollAnimationHelperDelegate invalidate]):
+(-[WebScrollbarPartAnimation invalidate]):
+(-[WebScrollbarPainterDelegate invalidate]):
+(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
+(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
+(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
+
+2011-12-09  Anders Carlsson  ander...@apple.com
+
 WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac
 https://bugs.webkit.org/show_bug.cgi?id=74204
 


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102467 => 102468)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 21:08:10 UTC (rev 102467)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 21:16:46 UTC (rev 102468)
@@ -105,7 +105,7 @@
 return self;
 }
 
-- (void)scrollAnimatorDestroyed
+- (void)invalidate
 {
 _animator = 0;
 }
@@ -350,7 +350,7 @@
 _scrollbar-invalidate();
 }
 
-- (void)scrollAnimatorDestroyed
+- (void)invalidate
 {
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
 [self stopAnimation];
@@ -542,13 +542,13 @@
 UNUSED_PARAM(newOverlayScrollerState);
 }
 
-- (void)scrollAnimatorDestroyed
+- (void)invalidate
 {
 _scrollbar = 0;
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
-[_knobAlphaAnimation.get() scrollAnimatorDestroyed];
-[_trackAlphaAnimation.get() scrollAnimatorDestroyed];
-[_uiStateTransitionAnimation.get() scrollAnimatorDestroyed];
+[_knobAlphaAnimation.get() invalidate];
+[_trackAlphaAnimation.get() invalidate];
+[_uiStateTransitionAnimation.get() invalidate];
 END_BLOCK_OBJC_EXCEPTIONS;
 }
 
@@ -593,9 +593,9 @@
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
 [m_scrollbarPainterControllerDelegate.get() invalidate];
 [m_scrollbarPainterController.get() setDelegate:nil];
-[m_horizontalScrollbarPainterDelegate.get() scrollAnimatorDestroyed];
-[m_verticalScrollbarPainterDelegate.get() scrollAnimatorDestroyed];
-[m_scrollAnimationHelperDelegate.get() scrollAnimatorDestroyed];
+[m_horizontalScrollbarPainterDelegate.get() invalidate];
+[m_verticalScrollbarPainterDelegate.get() invalidate];
+[m_scrollAnimationHelperDelegate.get() invalidate];
 END_BLOCK_OBJC_EXCEPTIONS;
 #endif
 }
@@ -874,7 +874,7 @@
 return;
 
 ASSERT(m_verticalScrollbarPainterDelegate);
-[m_verticalScrollbarPainterDelegate.get() scrollAnimatorDestroyed];
+[m_verticalScrollbarPainterDelegate.get() invalidate];
 m_verticalScrollbarPainterDelegate = nullptr;
 
 [painter setDelegate:nil];
@@ -911,7 +911,7 @@
 return;
 
 ASSERT(m_horizontalScrollbarPainterDelegate);
-[m_horizontalScrollbarPainterDelegate.get() scrollAnimatorDestroyed];
+[m_horizontalScrollbarPainterDelegate.get() invalidate];
 m_horizontalScrollbarPainterDelegate = nullptr;
 
 [painter setDelegate:nil];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102469] trunk/Source/WebCore

[andersca]

Title: [102469] trunk/Source/WebCore








Revision 102469
Author ander...@apple.com
Date 2011-12-09 13:25:08 -0800 (Fri, 09 Dec 2011)


Log Message
Remove NSAnimationContext calls
https://bugs.webkit.org/show_bug.cgi?id=74207

Reviewed by Sam Weinig.

NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration:
are essentially no-ops. Remove them.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102468 => 102469)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 21:16:46 UTC (rev 102468)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 21:25:08 UTC (rev 102469)
@@ -1,5 +1,19 @@
 2011-12-09  Anders Carlsson  ander...@apple.com
 
+Remove NSAnimationContext calls
+https://bugs.webkit.org/show_bug.cgi?id=74207
+
+Reviewed by Sam Weinig.
+
+NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration:
+are essentially no-ops. Remove them.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
+
+2011-12-09  Anders Carlsson  ander...@apple.com
+
 Rename scrollAnimatorDestroyed to invalidate
 https://bugs.webkit.org/show_bug.cgi?id=74206
 


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102468 => 102469)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 21:16:46 UTC (rev 102468)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 21:25:08 UTC (rev 102469)
@@ -470,15 +470,12 @@
 [self scrollAnimator]-setVisibleScrollerThumbRect(IntRect());
 }
 
-[NSAnimationContext beginGrouping];
-[[NSAnimationContext currentContext] setDuration:duration];
 scrollbarPartAnimation.adoptNS([[WebScrollbarPartAnimation alloc] initWithScrollbar:_scrollbar 
featureToAnimate:part == ThumbPart ? ThumbAlpha : TrackAlpha
 animateFrom:part == ThumbPart ? [scrollerPainter knobAlpha] : [scrollerPainter trackAlpha]
   animateTo:newAlpha 
duration:duration]);
 [scrollbarPartAnimation.get() startAnimation];
-[NSAnimationContext endGrouping];
 }
 
 - (void)scrollerImp:(id)scrollerImp animateKnobAlphaTo:(CGFloat)newKnobAlpha duration:(NSTimeInterval)duration
@@ -518,8 +515,6 @@
 // UIStateTransition always animates to 1. In case an animation is in progress this avoids a hard transition.
 [scrollerPainter setUiStateTransitionProgress:1 - [scrollerPainter uiStateTransitionProgress]];
 
-[NSAnimationContext beginGrouping];
-[[NSAnimationContext currentContext] setDuration:duration];
 if (!_uiStateTransitionAnimation)
 _uiStateTransitionAnimation.adoptNS([[WebScrollbarPartAnimation alloc] initWithScrollbar:_scrollbar 
 featureToAnimate:UIStateTransition
@@ -533,7 +528,6 @@
 [_uiStateTransitionAnimation.get() setDuration:duration];
 }
 [_uiStateTransitionAnimation.get() startAnimation];
-[NSAnimationContext endGrouping];
 }
 
 - (void)scrollerImp:(id)scrollerImp overlayScrollerStateChangedTo:(NSUInteger)newOverlayScrollerState






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102470] trunk

[cfleizach]

Title: [102470] trunk








Revision 102470
Author cfleiz...@apple.com
Date 2011-12-09 13:25:50 -0800 (Fri, 09 Dec 2011)


Log Message
WebKit should ignore images with @alt matching only whitespace
https://bugs.webkit.org/show_bug.cgi?id=74189

Reviewed by Darin Adler.

Source/WebCore: 

Test: accessibility/img-alt-tag-only-whitespace.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests: 

* accessibility/img-alt-tag-only-whitespace.html: Added.
* platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp


Added Paths

trunk/LayoutTests/accessibility/img-alt-tag-only-whitespace.html
trunk/LayoutTests/platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102469 => 102470)

--- trunk/LayoutTests/ChangeLog	2011-12-09 21:25:08 UTC (rev 102469)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 21:25:50 UTC (rev 102470)
@@ -1,3 +1,13 @@
+2011-12-09  Chris Fleizach  cfleiz...@apple.com
+
+WebKit should ignore images with @alt matching only whitespace
+https://bugs.webkit.org/show_bug.cgi?id=74189
+
+Reviewed by Darin Adler.
+
+* accessibility/img-alt-tag-only-whitespace.html: Added.
+* platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
+
 2011-12-09  Tony Chang  t...@chromium.org
 
 Try to deflake a repaint test on Chromium.  It looks like we're


Added: trunk/LayoutTests/accessibility/img-alt-tag-only-whitespace.html (0 => 102470)

--- trunk/LayoutTests/accessibility/img-alt-tag-only-whitespace.html	(rev 0)
+++ trunk/LayoutTests/accessibility/img-alt-tag-only-whitespace.html	2011-12-09 21:25:50 UTC (rev 102470)
@@ -0,0 +1,33 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body id=body
+
+div tabindex=0 role=group id=images
+img id=firstimage alt=  src=""
+img alt=	 src=""
+img alt=   Image  src=""
+/div
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that images with alt tags that only have white space are ignored.);
+
+if (window.accessibilityController) {
+
+document.getElementById(images).focus();
+var imagesGroup = accessibilityController.focusedElement;
+shouldBe(imagesGroup.childrenCount, 1);
+console.log(Image description:  + imagesGroup.childAtIndex(0).description);
+}
+
+/script
+
+script src=""
+/body
+/html


Added: trunk/LayoutTests/platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt (0 => 102470)

--- trunk/LayoutTests/platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt	2011-12-09 21:25:50 UTC (rev 102470)
@@ -0,0 +1,14 @@
+CONSOLE MESSAGE: line 26: Image description: AXDescription:Image 
+
+
+
+This tests that images with alt tags that only have white space are ignored.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS imagesGroup.childrenCount is 1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Modified: trunk/Source/WebCore/ChangeLog (102469 => 102470)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 21:25:08 UTC (rev 102469)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 21:25:50 UTC (rev 102470)
@@ -1,3 +1,15 @@
+2011-12-09  Chris Fleizach  cfleiz...@apple.com
+
+WebKit should ignore images with @alt matching only whitespace
+https://bugs.webkit.org/show_bug.cgi?id=74189
+
+Reviewed by Darin Adler.
+
+Test: accessibility/img-alt-tag-only-whitespace.html
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+
 2011-12-09  Anders Carlsson  ander...@apple.com
 
 Remove NSAnimationContext calls


Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (102469 => 102470)

--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-12-09 21:25:08 UTC (rev 102469)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-12-09 21:25:50 UTC (rev 102470)
@@ -1897,7 +1897,7 @@
 Element* elt = static_castElement*(node);
 const AtomicString alt = elt-getAttribute(altAttr);
 // don't ignore an image that has an alt tag
-if (!alt.isEmpty())
+if (!alt.string().containsOnlyWhitespace())
 return false;
 // informal standard is to ignore images with zero-length alt strings
 if (!alt.isNull())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102471] trunk

[eric . carlson]

Title: [102471] trunk








Revision 102471
Author eric.carl...@apple.com
Date 2011-12-09 13:32:02 -0800 (Fri, 09 Dec 2011)


Log Message
JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable
https://bugs.webkit.org/show_bug.cgi?id=72179

Reviewed by Geoff Garen.

Source/WebCore: 

Tests: media/track/text-track-cue-is-reachable.html
   media/track/text-track-is-reachable.html

* GNUmakefile.list.am: Add JSTextTrackCueCustom.cpp and JSTextTrackCustom.cpp.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto
* bindings/js/JSBindingsAllInOne.cpp: Ditto.

* bindings/js/JSTextTrackCueCustom.cpp: Added.
(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrackCueOwner::visitChildren): New.

* bindings/js/JSTextTrackCustom.cpp: Added.
(WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrack::visitChildren): New, mark all cues.
* bindings/js/JSTextTrackCustom.h: Added.
(WebCore::root): New.

* bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackList::visitChildren): New, mark all tracks.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWillBeRemoved): TextTracks::remove now takes a TextTrack*.

* html/LoadableTextTrack.h:
(WebCore::LoadableTextTrack::trackElement): New, return the track.

* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Initialize m_mediaElement.
* html/TextTrack.h:
(WebCore::TextTrack::setMediaElement): New.
(WebCore::TextTrack::mediaElement): Ditto.

* html/TextTrack.idl: Add CustomIsReachable and CustomMarkFunction.

* html/TextTrackCue.idl: Add CustomIsReachable.

* html/track/TextTrackList.cpp:
(TextTrackList::append): Set track's media element.
(TextTrackList::remove): Clear track's media element. Take a raw ptr, not a PassRefPtr.
* html/track/TextTrackList.h:
* html/track/TextTrackList.idl: Add CustomMarkFunction

LayoutTests: 

* media/track/text-track-cue-is-reachable-expected.txt: Added.
* media/track/text-track-cue-is-reachable.html: Added.
* media/track/text-track-is-reachable-expected.txt: Added.
* media/track/text-track-is-reachable.html: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/js/JSTextTrackListCustom.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/LoadableTextTrack.h
trunk/Source/WebCore/html/TextTrack.cpp
trunk/Source/WebCore/html/TextTrack.h
trunk/Source/WebCore/html/TextTrack.idl
trunk/Source/WebCore/html/TextTrackCue.idl
trunk/Source/WebCore/html/track/TextTrackList.cpp
trunk/Source/WebCore/html/track/TextTrackList.h
trunk/Source/WebCore/html/track/TextTrackList.idl


Added Paths

trunk/LayoutTests/media/track/text-track-cue-is-reachable-expected.txt
trunk/LayoutTests/media/track/text-track-cue-is-reachable.html
trunk/LayoutTests/media/track/text-track-is-reachable-expected.txt
trunk/LayoutTests/media/track/text-track-is-reachable.html
trunk/Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp
trunk/Source/WebCore/bindings/js/JSTextTrackCustom.cpp
trunk/Source/WebCore/bindings/js/JSTextTrackCustom.h




Diff

Modified: trunk/LayoutTests/ChangeLog (102470 => 102471)

--- trunk/LayoutTests/ChangeLog	2011-12-09 21:25:50 UTC (rev 102470)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 21:32:02 UTC (rev 102471)
@@ -1,3 +1,16 @@
+2011-12-09  Eric Carlson  eric.carl...@apple.com
+
+JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable
+https://bugs.webkit.org/show_bug.cgi?id=72179
+
+Reviewed by Geoff Garen.
+
+* media/track/text-track-cue-is-reachable-expected.txt: Added.
+* media/track/text-track-cue-is-reachable.html: Added.
+* media/track/text-track-is-reachable-expected.txt: Added.
+* media/track/text-track-is-reachable.html: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-12-09  Chris Fleizach  cfleiz...@apple.com
 
 WebKit should ignore images with @alt matching only whitespace


Added: trunk/LayoutTests/media/track/text-track-cue-is-reachable-expected.txt (0 => 102471)

--- trunk/LayoutTests/media/track/text-track-cue-is-reachable-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/track/text-track-cue-is-reachable-expected.txt	2011-12-09 21:32:02 UTC (rev 102471)
@@ -0,0 +1,16 @@
+Ensure that a TextTrackCue won't be collected if it has a custom property.
+
+** Validate.
+EXPECTED (video.textTracks[0].cues.length == '4') OK
+EXPECTED (video.textTracks[0].cues[1].startTime == '31') OK
+
+** Add a custom property to a cue.

[webkit-changes] [102472] trunk/Source/WebCore

[tony]

Title: [102472] trunk/Source/WebCore








Revision 102472
Author t...@chromium.org
Date 2011-12-09 13:41:58 -0800 (Fri, 09 Dec 2011)


Log Message
Unreviewed, rolling out r102416.
http://trac.webkit.org/changeset/102416
https://bugs.webkit.org/show_bug.cgi?id=73394

Chromium Win clobber builds are failing.

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
* WebCore.gypi:
* bindings/scripts/generate-bindings.pl:
* page/DOMWindow.idl:
* webaudio/DOMWindowWebAudio.idl: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gyp/scripts/action_derivedsourcesallinone.py
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/scripts/generate-bindings.pl
trunk/Source/WebCore/page/DOMWindow.idl


Removed Paths

trunk/Source/WebCore/webaudio/DOMWindowWebAudio.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (102471 => 102472)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 21:32:02 UTC (rev 102471)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 21:41:58 UTC (rev 102472)
@@ -1,3 +1,19 @@
+2011-12-09  Tony Chang  t...@chromium.org
+
+Unreviewed, rolling out r102416.
+http://trac.webkit.org/changeset/102416
+https://bugs.webkit.org/show_bug.cgi?id=73394
+
+Chromium Win clobber builds are failing.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
+(main):
+* WebCore.gypi:
+* bindings/scripts/generate-bindings.pl:
+* page/DOMWindow.idl:
+* webaudio/DOMWindowWebAudio.idl: Removed.
+
 2011-12-09  Eric Carlson  eric.carl...@apple.com
 
 JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (102471 => 102472)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-12-09 21:32:02 UTC (rev 102471)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-12-09 21:41:58 UTC (rev 102472)
@@ -446,48 +446,9 @@
   ]
 },
 {
-  'target_name': 'generate_supplemental_dependency',
-  'type': 'none',
-  'actions': [
- {
-  'action_name': 'generateSupplementalDependency',
-  'variables': {
-# Write sources into a file, so that the action command line won't
-# exceed OS limits.
-'idl_files_list': '|(idl_files_list.tmp @(bindings_idl_files))',
-  },
-  'inputs': [
-'../bindings/scripts/resolve-supplemental.pl',
-'../bindings/scripts/IDLParser.pm',
-'(idl_files_list)',
-'!@(cat (idl_files_list))',
-  ],
-  'outputs': [
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
-  ],
-  'action': [
-'perl',
-'-w',
-'-I../bindings/scripts',
-'../bindings/scripts/resolve-supplemental.pl',
-'--defines',
-'(feature_defines) LANGUAGE_JAVASCRIPT V8_BINDING',
-'--idlFilesList',
-'(idl_files_list)',
-'--supplementalDependencyFile',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
-  ],
-  'message': 'Resolving [Supplemental=XXX] dependencies in all IDL files',
-}
-  ]
-},
-{
   'target_name': 'webcore_bindings_sources',
   'type': 'none',
   'hard_dependency': 1,
-  'dependencies': [
-'generate_supplemental_dependency',
-  ],
   'sources': [
 # bison rule
 '../css/CSSGrammar.y',
@@ -900,9 +861,15 @@
 },
 {
   'action_name': 'derived_sources_all_in_one',
+  'variables': {
+# Write sources into a file, so that the action command line won't
+# exceed OS limites.
+'idls_list_temp_file': '|(idls_list_temp_file.tmp @(bindings_idl_files))',
+  },
   'inputs': [
 'scripts/action_derivedsourcesallinone.py',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
+'(idls_list_temp_file)',
+'!@(cat (idls_list_temp_file))',
   ],
   'outputs': [
 '@(derived_sources_aggregate_files)',
@@ -910,7 +877,7 @@
   'action': [
 'python',
 'scripts/action_derivedsourcesallinone.py',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
+'(idls_list_temp_file)',
 '--',
 '@(derived_sources_aggregate_files)',
   ],
@@ -963,7 +930,6 @@
 '../bindings/scripts/IDLParser.pm',
 '../bindings/scripts/IDLStructure.pm',
 '../bindings/scripts/preprocessor.pm',
-'(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
   ],
   'outputs': [
 # FIXME:  The .cpp file should be in 

[webkit-changes] [102473] trunk

[levin]

Title: [102473] trunk








Revision 102473
Author le...@chromium.org
Date 2011-12-09 14:05:12 -0800 (Fri, 09 Dec 2011)


Log Message
Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.
https://bugs.webkit.org/show_bug.cgi?id=71695

Reviewed by Zoltan Herczeg.

Source/_javascript_Core:

* wtf/MessageQueue.h:
(WTF::MessageQueue::tryGetMessageIgnoringKilled): Added a way to get messages
even after the queue has been killed. This is useful when one wants to
kill a queue but then go through it to run clean up tasks from it.

Source/WebCore:

Overview: Message loops rely on the message queue being killed in order
to exit. r53595 stopped this from happening because killing a message loop
would also stop it from doing database clean up tasks. The database clean up
tasks needed to be tasks due to ordering issues. (They wanted to run after
certain order tasks were run.) This was solved by once again terminating
the message queue but then still runnning clean-up tasks from the killed
message queue.

* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::run): Added the call to run clean-up tasks.
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks): Loop to simply clear out all clean up tasks.
(WebCore::WorkerRunLoop::Task::performTask): Stop non-clean up tasks
from running after the loop has been terminated.
* workers/WorkerRunLoop.h:
(WebCore::WorkerRunLoop::terminated): Just made it const.
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask): Removed
the terminate clause since it was put back in stop.
(WebCore::WorkerThread::stop): Terminate the run loop so
that all loops will exit and clean up tasks will run. Also removed a comment
about nested workers because nested workers are no longer imminent and the
issue mentioned is one of many that should logically be investigated -- behavior correctness
in the face of different orderings of shutdown between the document and each worker --
when implementing them.

LayoutTests:

* http/tests/workers/resources/worker-util.js: Added.
Copied from fast/workers/resources/worker-util.js
* http/tests/xmlhttprequest/workers/abort-exception-assert.html:
Make the test wait for all workers to exit before finishing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/xmlhttprequest/workers/abort-exception-assert.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/MessageQueue.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerRunLoop.cpp
trunk/Source/WebCore/workers/WorkerRunLoop.h
trunk/Source/WebCore/workers/WorkerThread.cpp


Added Paths

trunk/LayoutTests/http/tests/workers/resources/worker-util.js




Diff

Modified: trunk/LayoutTests/ChangeLog (102472 => 102473)

--- trunk/LayoutTests/ChangeLog	2011-12-09 21:41:58 UTC (rev 102472)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 22:05:12 UTC (rev 102473)
@@ -1,3 +1,15 @@
+2011-12-09  David Levin  le...@chromium.org
+
+Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.
+https://bugs.webkit.org/show_bug.cgi?id=71695
+
+Reviewed by Zoltan Herczeg.
+
+* http/tests/workers/resources/worker-util.js: Added.
+Copied from fast/workers/resources/worker-util.js
+* http/tests/xmlhttprequest/workers/abort-exception-assert.html:
+Make the test wait for all workers to exit before finishing.
+
 2011-12-09  Eric Carlson  eric.carl...@apple.com
 
 JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable


Added: trunk/LayoutTests/http/tests/workers/resources/worker-util.js (0 => 102473)

--- trunk/LayoutTests/http/tests/workers/resources/worker-util.js	(rev 0)
+++ trunk/LayoutTests/http/tests/workers/resources/worker-util.js	2011-12-09 22:05:12 UTC (rev 102473)
@@ -0,0 +1,70 @@
+// Useful utilities for worker tests
+
+function log(message)
+{
+document.getElementById(result).innerHTML += message + br;
+}
+
+function gc(forceAlloc)
+{
+if (typeof GCController !== undefined)
+GCController.collect();
+
+if (typeof GCController == undefined || forceAlloc) {
+function gcRec(n) {
+if (n  1)
+return {};
+var temp = {i: ab + i + (i / 10)};
+temp += foo;
+gcRec(n-1);
+}
+for (var i = 0; i  1000; i++)
+gcRec(10)
+}
+}
+
+function waitUntilWorkerThreadsExit(callback)
+{
+waitUntilThreadCountMatches(callback, 0);
+}
+
+function waitUntilThreadCountMatches(callback, count)
+{
+// When running in a browser, just wait for one second then call the callback.
+if (!window.layoutTestController) {
+setTimeout(function() { gc(true); callback(); }, 1000);
+return;
+}
+
+if (layoutTestController.workerThreadCount == count) {
+// Worker threads have exited.
+

[webkit-changes] [102474] trunk/Source/WebCore

[andersca]

Title: [102474] trunk/Source/WebCore








Revision 102474
Author ander...@apple.com
Date 2011-12-09 14:07:08 -0800 (Fri, 09 Dec 2011)


Log Message
Minor cleanup in ScrollAnimatorMac.mm
https://bugs.webkit.org/show_bug.cgi?id=74211

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
No need to get the scrollbar from the scroll animator anymore.

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102473 => 102474)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 22:05:12 UTC (rev 102473)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 22:07:08 UTC (rev 102474)
@@ -1,3 +1,18 @@
+2011-12-09  Anders Carlsson  ander...@apple.com
+
+Minor cleanup in ScrollAnimatorMac.mm
+https://bugs.webkit.org/show_bug.cgi?id=74211
+
+Reviewed by Andreas Kling.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
+No need to get the scrollbar from the scroll animator anymore.
+
+(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
+(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
+Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter.
+
 2011-12-09  David Levin  le...@chromium.org
 
 Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102473 => 102474)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 22:05:12 UTC (rev 102473)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 22:07:08 UTC (rev 102474)
@@ -426,17 +426,9 @@
 if (!_scrollbar)
 return NSZeroPoint;
 
-ScrollbarPainter scrollerPainter = (ScrollbarPainter)scrollerImp;
-Scrollbar* scrollbar;
-if ([scrollerPainter isHorizontal])
-scrollbar = [self scrollAnimator]-scrollableArea()-horizontalScrollbar();
-else 
-scrollbar = [self scrollAnimator]-scrollableArea()-verticalScrollbar();
+ASSERT(scrollerImp == scrollbarPainterForScrollbar(_scrollbar));
 
-if (!scrollbar)
-return NSZeroPoint;
-
-return scrollbar-convertFromContainingView([self scrollAnimator]-scrollableArea()-currentMousePosition());
+return _scrollbar-convertFromContainingView(_scrollbar-scrollableArea()-currentMousePosition());
 }
 
 - (void)setUpAlphaAnimation:(RetainPtrWebScrollbarPartAnimation)scrollbarPartAnimation scrollerPainter:(ScrollbarPainter)scrollerPainter part:(WebCore::ScrollbarPart)part animateAlphaTo:(CGFloat)newAlpha duration:(NSTimeInterval)duration
@@ -448,7 +440,7 @@
 if ([self scrollAnimator]-scrollbarPaintTimerIsActive()  !mustAnimate)
 return;
 
-if ([self scrollAnimator]-scrollableArea()-shouldSuspendScrollAnimations()  !mustAnimate) {
+if (_scrollbar-scrollableArea()-shouldSuspendScrollAnimations()  !mustAnimate) {
 [self scrollAnimator]-startScrollbarPaintTimer();
 return;
 }
@@ -462,7 +454,7 @@
 scrollbarPartAnimation = nil;
 }
 
-if (part == WebCore::ThumbPart  ![scrollerPainter isHorizontal]) {
+if (part == WebCore::ThumbPart  _scrollbar-orientation() == VerticalScrollbar) {
 if (newAlpha == 1) {
 IntRect thumbRect = IntRect([scrollerPainter rectForPart:NSScrollerKnob]);
 [self scrollAnimator]-setVisibleScrollerThumbRect(thumbRect);
@@ -510,20 +502,20 @@
 
 ASSERT(scrollerImp == scrollbarPainterForScrollbar(_scrollbar));
 
-ScrollbarPainter scrollerPainter = (ScrollbarPainter)scrollerImp;
+ScrollbarPainter scrollbarPainter = (ScrollbarPainter)scrollerImp;
 
 // UIStateTransition always animates to 1. In case an animation is in progress this avoids a hard transition.
-[scrollerPainter setUiStateTransitionProgress:1 - [scrollerPainter uiStateTransitionProgress]];
+[scrollbarPainter setUiStateTransitionProgress:1 - [scrollerImp uiStateTransitionProgress]];
 
 if (!_uiStateTransitionAnimation)
 _uiStateTransitionAnimation.adoptNS([[WebScrollbarPartAnimation alloc] initWithScrollbar:_scrollbar 
 featureToAnimate:UIStateTransition
- animateFrom:[scrollerPainter uiStateTransitionProgress]
+  

[webkit-changes] [102475] trunk/Source/JavaScriptCore

[msaboff]

Title: [102475] trunk/Source/_javascript_Core








Revision 102475
Author msab...@apple.com
Date 2011-12-09 14:42:31 -0800 (Fri, 09 Dec 2011)


Log Message
YARR: Multi-character read optimization for 8bit strings
https://bugs.webkit.org/show_bug.cgi?id=74191

Reviewed by Oliver Hunt.

Changed generatePatternCharacterOnce to generate
code for 1 to 4 characters in the 8 bit case.
This is worth 29% improvement on SunSpider regexp-dna test.
It provides no benefit to v8-regexp.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generate): Spelling fix in comment.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102474 => 102475)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-09 22:07:08 UTC (rev 102474)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-09 22:42:31 UTC (rev 102475)
@@ -1,3 +1,19 @@
+2011-12-09  Michael Saboff  msab...@apple.com
+
+YARR: Multi-character read optimization for 8bit strings
+https://bugs.webkit.org/show_bug.cgi?id=74191
+
+Reviewed by Oliver Hunt.
+
+Changed generatePatternCharacterOnce to generate
+code for 1 to 4 characters in the 8 bit case.
+This is worth 29% improvement on SunSpider regexp-dna test.
+It provides no benefit to v8-regexp.
+
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
+(JSC::Yarr::YarrGenerator::generate): Spelling fix in comment.
+
 2011-12-09  David Levin  le...@chromium.org
 
 Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.


Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (102474 => 102475)

--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2011-12-09 22:07:08 UTC (rev 102474)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2011-12-09 22:42:31 UTC (rev 102475)
@@ -655,14 +655,14 @@
 {
 YarrOp op = m_ops[opIndex];
 
+if (op.m_isDeadCode)
+return;
+
 // m_ops always ends with a OpBodyAlternativeEnd or OpMatchFailed
 // node, so there must always be at least one more node.
 ASSERT(opIndex + 1  m_ops.size());
-YarrOp nextOp = m_ops[opIndex + 1];
+YarrOp* nextOp = m_ops[opIndex + 1];
 
-if (op.m_isDeadCode)
-return;
-
 PatternTerm* term = op.m_term;
 UChar ch = term-patternCharacter;
 
@@ -673,47 +673,90 @@
 }
 
 const RegisterID character = regT0;
+int maxCharactersAtOnce = m_charSize == Char8 ? 4 : 2;
+unsigned ignoreCaseMask = 0;
+unsigned currentCharacterMask = m_charSize == Char8 ? 0xff : 0x;
+int allCharacters = ch;
+int numberCharacters;
+int startTermPosition = term-inputPosition;
 
-if (nextOp.m_op == OpTerm) {
-PatternTerm* nextTerm = nextOp.m_term;
-if (nextTerm-type == PatternTerm::TypePatternCharacter
- nextTerm-quantityType == QuantifierFixedCount
- nextTerm-quantityCount == 1
- nextTerm-inputPosition == (term-inputPosition + 1)) {
+// For case-insesitive compares, non-ascii characters that have different
+// upper  lower case representations are converted to a character class.
+ASSERT(!m_pattern.m_ignoreCase || isASCIIAlpha(ch) || (Unicode::toLower(ch) == Unicode::toUpper(ch)));
 
-UChar ch2 = nextTerm-patternCharacter;
+if ((m_pattern.m_ignoreCase)  (isASCIIAlpha(ch)))
+ignoreCaseMask |= 32;
 
-int shiftAmount = m_charSize == Char8 ? 8 : 16;
-int mask = 0;
-int chPair = ch | (ch2  shiftAmount);
+for (numberCharacters = 1; numberCharacters  maxCharactersAtOnce  nextOp-m_op == OpTerm; ++numberCharacters, nextOp = m_ops[opIndex + numberCharacters]) {
+PatternTerm* nextTerm = nextOp-m_term;
+
+if (nextTerm-type != PatternTerm::TypePatternCharacter
+|| nextTerm-quantityType != QuantifierFixedCount
+|| nextTerm-quantityCount != 1
+|| nextTerm-inputPosition != (startTermPosition + numberCharacters))
+break;
 
-// For case-insesitive compares, non-ascii characters that have different
-// upper  lower case representations are converted to a character class.
-ASSERT(!m_pattern.m_ignoreCase || isASCIIAlpha(ch) || (Unicode::toLower(ch) == Unicode::toUpper(ch)));
-if (m_pattern.m_ignoreCase) {
-if (isASCIIAlpha(ch))
-mask |= 32;
-if (isASCIIAlpha(ch2))
-mask |= 32  shiftAmount;
-}
+nextOp-m_isDeadCode = true;
 
-if (m_charSize == Char8) {
-   

[webkit-changes] [102476] trunk/Source/WebCore

[andersca]

Title: [102476] trunk/Source/WebCore








Revision 102476
Author ander...@apple.com
Date 2011-12-09 14:48:01 -0800 (Fri, 09 Dec 2011)


Log Message
Move the is currently drawing into layer flag out into ScrollbarThemeMac
https://bugs.webkit.org/show_bug.cgi?id=74217

Reviewed by Beth Dakin.

There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate layer]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::paint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102475 => 102476)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 22:42:31 UTC (rev 102475)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 22:48:01 UTC (rev 102476)
@@ -1,5 +1,23 @@
 2011-12-09  Anders Carlsson  ander...@apple.com
 
+Move the is currently drawing into layer flag out into ScrollbarThemeMac
+https://bugs.webkit.org/show_bug.cgi?id=74217
+
+Reviewed by Beth Dakin.
+
+There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead.
+
+* platform/mac/ScrollAnimatorMac.h:
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterDelegate layer]):
+(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
+* platform/mac/ScrollbarThemeMac.h:
+* platform/mac/ScrollbarThemeMac.mm:
+(WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer):
+(WebCore::ScrollbarThemeMac::paint):
+
+2011-12-09  Anders Carlsson  ander...@apple.com
+
 Minor cleanup in ScrollAnimatorMac.mm
 https://bugs.webkit.org/show_bug.cgi?id=74211
 


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h (102475 => 102476)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h	2011-12-09 22:42:31 UTC (rev 102475)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h	2011-12-09 22:48:01 UTC (rev 102476)
@@ -82,9 +82,6 @@
 
 void immediateScrollToPointForScrollAnimation(const FloatPoint newPosition);
 
-void setIsDrawingIntoLayer(bool b) { m_drawingIntoLayer = b; }
-bool isDrawingIntoLayer() const { return m_drawingIntoLayer; }
-
 bool haveScrolledSincePageLoad() const { return m_haveScrolledSincePageLoad; }
 
 virtual void setIsActive();
@@ -161,7 +158,6 @@
 TimerScrollAnimatorMac m_snapRubberBandTimer;
 #endif
 
-bool m_drawingIntoLayer;
 bool m_haveScrolledSincePageLoad;
 bool m_needsScrollerStyleUpdate;
 IntRect m_visibleScrollerThumbRect;


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102475 => 102476)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 22:42:31 UTC (rev 102475)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 22:48:01 UTC (rev 102476)
@@ -413,7 +413,7 @@
 if (!_scrollbar)
 return nil;
 
-if (![self scrollAnimator]-isDrawingIntoLayer())
+if (!ScrollbarThemeMac::isCurrentlyDrawingIntoLayer())
 return nil;
 
 // FIXME: This should attempt to return an actual layer.
@@ -558,7 +558,6 @@
 , m_scrollElasticityController(this)
 , m_snapRubberBandTimer(this, ScrollAnimatorMac::snapRubberBandTimerFired)
 #endif
-, m_drawingIntoLayer(false)
 , m_haveScrolledSincePageLoad(false)
 , m_needsScrollerStyleUpdate(false)
 {


Modified: trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h (102475 => 102476)

--- trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h	2011-12-09 22:42:31 UTC (rev 102475)
+++ trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h	2011-12-09 22:48:01 UTC (rev 102476)
@@ -62,6 +62,8 @@
 #if USE(SCROLLBAR_PAINTER)
 void setNewPainterForScrollbar(Scrollbar*, ScrollbarPainter);
 ScrollbarPainter painterForScrollbar(Scrollbar*);
+
+static bool isCurrentlyDrawingIntoLayer();
 #endif
 
 protected:


Modified: trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm (102475 => 102476)

--- trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm	2011-12-09 22:42:31 UTC (rev 102475)
+++ trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm	2011-12-09 22:48:01 UTC (rev 102476)
@@ -36,6 +36,7 @@
 #include Carbon/Carbon.h
 #include wtf/HashMap.h
 #include wtf/StdLibExtras.h
+#include wtf/TemporaryChange.h
 #include wtf/UnusedParam.h
 
 // FIXME: There are repainting problems due to Aqua scroll bar buttons' visual overflow.
@@ -185,6 +186,14 @@
 {
 return scrollbarMap()-get(scrollbar).get();
 }
+
+static bool 

[webkit-changes] [102477] trunk/LayoutTests

[adamk]

Title: [102477] trunk/LayoutTests








Revision 102477
Author ad...@chromium.org
Date 2011-12-09 14:48:16 -0800 (Fri, 09 Dec 2011)


Log Message
[MutationObservers] Add test for deliver-at-end-of-task semantics
https://bugs.webkit.org/show_bug.cgi?id=74190

Reviewed by Ojan Vafai.

The addition of eventSender.scheduleAsynchronousKeyDown in r102424
allows testing the code added in r101842 and http://crrev.com/113010.

Added a test using a contentEditable element and an onblur event
handler that asserts it fires after mutations due to editing have been
delivered.

* fast/mutation/end-of-task-delivery-expected.txt: Added.
* fast/mutation/end-of-task-delivery.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/mutation/end-of-task-delivery-expected.txt
trunk/LayoutTests/fast/mutation/end-of-task-delivery.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102476 => 102477)

--- trunk/LayoutTests/ChangeLog	2011-12-09 22:48:01 UTC (rev 102476)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 22:48:16 UTC (rev 102477)
@@ -1,3 +1,20 @@
+2011-12-09  Adam Klein  ad...@chromium.org
+
+[MutationObservers] Add test for deliver-at-end-of-task semantics
+https://bugs.webkit.org/show_bug.cgi?id=74190
+
+Reviewed by Ojan Vafai.
+
+The addition of eventSender.scheduleAsynchronousKeyDown in r102424
+allows testing the code added in r101842 and http://crrev.com/113010.
+
+Added a test using a contentEditable element and an onblur event
+handler that asserts it fires after mutations due to editing have been
+delivered.
+
+* fast/mutation/end-of-task-delivery-expected.txt: Added.
+* fast/mutation/end-of-task-delivery.html: Added.
+
 2011-12-09  David Levin  le...@chromium.org
 
 Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.


Added: trunk/LayoutTests/fast/mutation/end-of-task-delivery-expected.txt (0 => 102477)

--- trunk/LayoutTests/fast/mutation/end-of-task-delivery-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mutation/end-of-task-delivery-expected.txt	2011-12-09 22:48:16 UTC (rev 102477)
@@ -0,0 +1 @@
+PASSED
Property changes on: trunk/LayoutTests/fast/mutation/end-of-task-delivery-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/mutation/end-of-task-delivery.html (0 => 102477)

--- trunk/LayoutTests/fast/mutation/end-of-task-delivery.html	(rev 0)
+++ trunk/LayoutTests/fast/mutation/end-of-task-delivery.html	2011-12-09 22:48:16 UTC (rev 102477)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+ol contenteditable
+liPress enter
+/ol
+pThen click here/p
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var list = document.querySelector('ol');
+var p = document.querySelector('p');
+var observerRuns = 0;
+var observer = new WebKitMutationObserver(function() { ++observerRuns; });
+observer.observe(list, {childList: true});
+list.addEventListener('blur', function() {
+document.body.innerHTML = observerRuns == 1 ? 'PASSED' : 'FAILED';
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+});
+list.focus();
+if (window.eventSender) {
+eventSender.scheduleAsynchronousKeyDown('\n');
+eventSender.mouseMoveTo(p.offsetLeft + p.offsetWidth / 2, p.offsetTop + p.offsetHeight / 2);
+eventSender.scheduleAsynchronousClick();
+}
+/script
Property changes on: trunk/LayoutTests/fast/mutation/end-of-task-delivery.html
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102478] trunk/Source/WebCore

[andersca]

Title: [102478] trunk/Source/WebCore








Revision 102478
Author ander...@apple.com
Date 2011-12-09 15:21:10 -0800 (Fri, 09 Dec 2011)


Log Message
Fix assertion failure in ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74222

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
This can be called with a nil scrollerImp, just return NSZeroPoint when that happens.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102477 => 102478)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 22:48:16 UTC (rev 102477)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 23:21:10 UTC (rev 102478)
@@ -1,5 +1,16 @@
 2011-12-09  Anders Carlsson  ander...@apple.com
 
+Fix assertion failure in ScrollAnimatorMac
+https://bugs.webkit.org/show_bug.cgi?id=74222
+
+Reviewed by Andreas Kling.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
+This can be called with a nil scrollerImp, just return NSZeroPoint when that happens.
+
+2011-12-09  Anders Carlsson  ander...@apple.com
+
 Move the is currently drawing into layer flag out into ScrollbarThemeMac
 https://bugs.webkit.org/show_bug.cgi?id=74217
 


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102477 => 102478)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 22:48:16 UTC (rev 102477)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-09 23:21:10 UTC (rev 102478)
@@ -229,7 +229,8 @@
 - (NSPoint)scrollerImpPair:(id)scrollerImpPair convertContentPoint:(NSPoint)pointInContentArea toScrollerImp:(id)scrollerImp
 {
 UNUSED_PARAM(scrollerImpPair);
-if (!_scrollableArea)
+
+if (!_scrollableArea || !scrollerImp)
 return NSZeroPoint;
 
 WebCore::Scrollbar* scrollbar = 0;
@@ -244,7 +245,7 @@
 // of the clean-up work in ScrollbarThemeMac::unregisterScrollbar() to avoid this
 // issue.
 if (!scrollbar)
-return WebCore::IntPoint();
+return NSZeroPoint;
 
 ASSERT(scrollerImp == scrollbarPainterForScrollbar(scrollbar));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102481] trunk/Tools

[haraken]

Title: [102481] trunk/Tools








Revision 102481
Author hara...@chromium.org
Date 2011-12-09 15:26:42 -0800 (Fri, 09 Dec 2011)


Log Message
[Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
https://bugs.webkit.org/show_bug.cgi?id=74173

Reviewed by Ryosuke Niwa.

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.

* Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
(fetchBugDescriptionFromURL):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (102480 => 102481)

--- trunk/Tools/ChangeLog	2011-12-09 23:26:38 UTC (rev 102480)
+++ trunk/Tools/ChangeLog	2011-12-09 23:26:42 UTC (rev 102481)
@@ -1,3 +1,17 @@
+2011-12-09  Kentaro Hara  hara...@chromium.org
+
+[Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
+https://bugs.webkit.org/show_bug.cgi?id=74173
+
+Reviewed by Ryosuke Niwa.
+
+The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
+This requires to remove top-level code. This patch is one of the incremental refactorings
+for that.
+
+* Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
+(fetchBugDescriptionFromURL):
+
 2011-12-09  Tony Chang  t...@chromium.org
 
 Switch the chromium mac bots to using skia test results


Modified: trunk/Tools/Scripts/prepare-ChangeLog (102480 => 102481)

--- trunk/Tools/Scripts/prepare-ChangeLog	2011-12-09 23:26:38 UTC (rev 102480)
+++ trunk/Tools/Scripts/prepare-ChangeLog	2011-12-09 23:26:42 UTC (rev 102481)
@@ -67,6 +67,7 @@
 sub changeLogDate($);
 sub changeLogEmailAddressFromArgs($);
 sub changeLogNameFromArgs($);
+sub fetchBugDescriptionFromURL($);
 sub firstDirectoryOrCwd();
 sub diffFromToString();
 sub diffCommand(@);
@@ -256,37 +257,18 @@
 
 print STDERR   Change author: $name $emailAddress.\n;
 
+# Remove trailing parenthesized notes from user name (bit of hack).
+$name =~ s/\(.*?\)\s*$//g;
+
 my $bugURL;
 if ($bugNumber) {
 $bugURL = https://bugs.webkit.org/show_bug.cgi?id=$bugNumber;
 }
 
 if ($bugNumber  !$bugDescription) {
-my $bugXMLURL = $bugURLctype=xml;
-# Perl has no built in XML processing, so we'll fetch and parse with curl and grep
-# Pass --insecure because some cygwin installs have no certs we don't
-# care about validating that bugs.webkit.org is who it says it is here.
-my $descriptionLine = `curl --insecure --silent $bugXMLURL | grep short_desc`;
-if ($descriptionLine !~ /short_desc(.*)\/short_desc/) {
-# Maybe the reason the above did not work is because the curl that is installed doesn't
-# support ssl at all.
-if (`curl --version | grep ^Protocols` !~ /\bhttps\b/) {
-print STDERR   Could not get description for bug $bugNumber.\n;
-print STDERR   It looks like your version of curl does not support ssl.\n;
-print STDERR   If you are using macports, this can be fixed with sudo port install curl +ssl.\n;
-} else {
-print STDERR   Bug $bugNumber has no bug description. Maybe you set wrong bug ID?\n;
-print STDERR   The bug URL: $bugXMLURL\n;
-}
-exit 1;
-}
-$bugDescription = decodeEntities($1);
-print STDERR   Description from bug $bugNumber:\n\$bugDescription\.\n;
+$bugDescription = fetchBugDescriptionFromURL($bugURL);
 }
 
-# Remove trailing parenthesized notes from user name (bit of hack).
-$name =~ s/\(.*?\)\s*$//g;
-
 # Find the change logs.
 my %has_log;
 my %files;
@@ -488,6 +470,33 @@
 return $emailAddressFromArgs || changeLogEmailAddress();
 }
 
+sub fetchBugDescriptionFromURL($)
+{
+my ($bugURL) = @_;
+
+my $bugXMLURL = $bugURLctype=xml;
+# Perl has no built in XML processing, so we'll fetch and parse with curl and grep
+# Pass --insecure because some cygwin installs have no certs we don't
+# care about validating that bugs.webkit.org is who it says it is here.
+my $descriptionLine = `curl --insecure --silent $bugXMLURL | grep short_desc`;
+if ($descriptionLine !~ /short_desc(.*)\/short_desc/) {
+# Maybe the reason the above did not work is because the curl that is installed doesn't
+# support ssl at all.
+if (`curl --version | grep ^Protocols` !~ /\bhttps\b/) {
+print STDERR   Could not get description for bug $bugNumber.\n;
+print STDERR   It looks like your version of curl does not support ssl.\n;
+print STDERR   If you are using macports, this can be fixed with sudo port install curl +ssl.\n;
+} else {
+print STDERR   Bug 

[webkit-changes] [102480] trunk/Source/WebCore

[commit-queue]

Title: [102480] trunk/Source/WebCore








Revision 102480
Author commit-qu...@webkit.org
Date 2011-12-09 15:26:38 -0800 (Fri, 09 Dec 2011)


Log Message
[EFL] Add RefPtrEfl specialization for evas_object.
https://bugs.webkit.org/show_bug.cgi?id=73790

Patch by KwangHyuk Kim hyuki@samsung.com on 2011-12-09
Reviewed by Ryosuke Niwa.

As evas_object is also based on reference count, RefPtr is applied for evas_object.

* PlatformEfl.cmake:
* platform/efl/RefPtrEfl.cpp: Added.
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* platform/efl/RefPtrEfl.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake


Added Paths

trunk/Source/WebCore/platform/efl/RefPtrEfl.cpp
trunk/Source/WebCore/platform/efl/RefPtrEfl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102479 => 102480)

--- trunk/Source/WebCore/ChangeLog	2011-12-09 23:23:23 UTC (rev 102479)
+++ trunk/Source/WebCore/ChangeLog	2011-12-09 23:26:38 UTC (rev 102480)
@@ -1,3 +1,18 @@
+2011-12-09  KwangHyuk Kim  hyuki@samsung.com
+
+[EFL] Add RefPtrEfl specialization for evas_object.
+https://bugs.webkit.org/show_bug.cgi?id=73790
+
+Reviewed by Ryosuke Niwa.
+
+As evas_object is also based on reference count, RefPtr is applied for evas_object.
+
+* PlatformEfl.cmake:
+* platform/efl/RefPtrEfl.cpp: Added.
+(WTF::refIfNotNull):
+(WTF::derefIfNotNull):
+* platform/efl/RefPtrEfl.h: Added.
+
 2011-12-09  Tony Chang  t...@chromium.org
 
 REGRESSION(102234): 2-3% layout regression


Modified: trunk/Source/WebCore/PlatformEfl.cmake (102479 => 102480)

--- trunk/Source/WebCore/PlatformEfl.cmake	2011-12-09 23:23:23 UTC (rev 102479)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2011-12-09 23:26:38 UTC (rev 102480)
@@ -43,6 +43,7 @@
   platform/efl/PlatformTouchPointEfl.cpp
   platform/efl/PlatformWheelEventEfl.cpp
   platform/efl/PopupMenuEfl.cpp
+  platform/efl/RefPtrEfl.cpp
   platform/efl/RenderThemeEfl.cpp
   platform/efl/ScrollViewEfl.cpp
   platform/efl/ScrollbarEfl.cpp


Added: trunk/Source/WebCore/platform/efl/RefPtrEfl.cpp (0 => 102480)

--- trunk/Source/WebCore/platform/efl/RefPtrEfl.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/efl/RefPtrEfl.cpp	2011-12-09 23:26:38 UTC (rev 102480)
@@ -0,0 +1,40 @@
+/*
+ *  Copyright (C) 2011 Samsung Electronics
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Lesser General Public
+ *  License as published by the Free Software Foundation; either
+ *  version 2 of the License, or (at your option) any later version.
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Lesser General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Lesser General Public
+ *  License along with this library; if not, write to the Free Software
+ *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include config.h
+#include RefPtrEfl.h
+
+#include Evas.h
+
+namespace WTF {
+
+template void refIfNotNull(Evas_Object* ptr)
+{
+if (LIKELY(!!ptr))
+evas_object_ref(ptr);
+}
+
+template void derefIfNotNull(Evas_Object* ptr)
+{
+if (LIKELY(!!ptr)) {
+evas_object_unref(ptr);
+evas_object_del(ptr);
+}
+}
+
+}


Added: trunk/Source/WebCore/platform/efl/RefPtrEfl.h (0 => 102480)

--- trunk/Source/WebCore/platform/efl/RefPtrEfl.h	(rev 0)
+++ trunk/Source/WebCore/platform/efl/RefPtrEfl.h	2011-12-09 23:26:38 UTC (rev 102480)
@@ -0,0 +1,34 @@
+/*
+ *  Copyright (C) 2011 Samsung Electronics
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Library General Public
+ *  License as published by the Free Software Foundation; either
+ *  version 2 of the License, or (at your option) any later version.
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Library General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Library General Public License
+ *  along with this library; see the file COPYING.LIB.  If not, write to
+ *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ *  Boston, MA 02110-1301, USA.
+ */
+
+#ifndef RefPtrEfl_h
+#define RefPtrEfl_h
+
+#include RefPtr.h
+
+typedef struct _Evas_Object Evas_Object;
+
+namespace WTF {
+
+template void refIfNotNull(Evas_Object* ptr);
+template void derefIfNotNull(Evas_Object* ptr);
+
+}
+
+#endif // RefPtrEfl_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [102482] trunk

[dpranke]

Title: [102482] trunk








Revision 102482
Author dpra...@chromium.org
Date 2011-12-09 15:39:45 -0800 (Fri, 09 Dec 2011)


Log Message
chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
https://bugs.webkit.org/show_bug.cgi?id=74212

Reviewed by Tony Chang.

The change introduced in r102201 to split the executables out of
WebKit.gyp apparently doesn't work right on Windows, since
WebKit.gyp and Tools.gyp refer to dependent projects by
different relative paths (it appears gyp doesn't normalize the
paths). This change moves Tools.gyp to be in the same directory
as WebKit.gyp (and All.gyp), which should fix this and
conveniently will also solve the problem of how to add Tools.gyp
to the chromium DEPS file.

Source/WebKit/chromium:

* All.gyp:
* Tools.gyp: Renamed from ../../../Tools/Tools.gyp.

Tools:

* Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp

Modified Paths

trunk/Source/WebKit/chromium/All.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Tools/ChangeLog


Added Paths

trunk/Source/WebKit/chromium/Tools.gyp


Removed Paths

trunk/Tools/Tools.gyp




Diff

Modified: trunk/Source/WebKit/chromium/All.gyp (102481 => 102482)

--- trunk/Source/WebKit/chromium/All.gyp	2011-12-09 23:26:42 UTC (rev 102481)
+++ trunk/Source/WebKit/chromium/All.gyp	2011-12-09 23:39:45 UTC (rev 102482)
@@ -41,7 +41,7 @@
 'type': 'none',
 'dependencies': [
 'WebKitUnitTests.gyp:webkit_unit_tests',
-'../../../Tools/Tools.gyp:DumpRenderTree',
+'Tools.gyp:DumpRenderTree',
 ],
 }
 ],


Modified: trunk/Source/WebKit/chromium/ChangeLog (102481 => 102482)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-09 23:26:42 UTC (rev 102481)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-09 23:39:45 UTC (rev 102482)
@@ -1,3 +1,22 @@
+2011-12-09  Dirk Pranke  dpra...@chromium.org
+
+chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
+https://bugs.webkit.org/show_bug.cgi?id=74212
+
+Reviewed by Tony Chang.
+
+The change introduced in r102201 to split the executables out of
+WebKit.gyp apparently doesn't work right on Windows, since
+WebKit.gyp and Tools.gyp refer to dependent projects by
+different relative paths (it appears gyp doesn't normalize the
+paths). This change moves Tools.gyp to be in the same directory
+as WebKit.gyp (and All.gyp), which should fix this and
+conveniently will also solve the problem of how to add Tools.gyp
+to the chromium DEPS file.
+
+* All.gyp:
+* Tools.gyp: Renamed from ../../../Tools/Tools.gyp.
+
 2011-12-09  Cary Clark  carycl...@google.com
 
 Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac


Copied: trunk/Source/WebKit/chromium/Tools.gyp (from rev 102481, trunk/Tools/Tools.gyp) (0 => 102482)

--- trunk/Source/WebKit/chromium/Tools.gyp	(rev 0)
+++ trunk/Source/WebKit/chromium/Tools.gyp	2011-12-09 23:39:45 UTC (rev 102482)
@@ -0,0 +1,391 @@
+#
+# Copyright (C) 2011 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+
+{
+'variables': {
+'tools_dir': '../../../Tools',
+'source_dir': '../..',
+},
+ # FIXME: Remove this conditional check once chromium's
+# build/common.gypi is setting this flag to 0 by default. See
+# https://bugs.webkit.org/show_bug.cgi?id=68463.
+   

[webkit-changes] [102483] trunk

[levin]

Title: [102483] trunk








Revision 102483
Author le...@chromium.org
Date 2011-12-09 15:43:52 -0800 (Fri, 09 Dec 2011)


Log Message
Hash* iterators should allow comparison between const and const versions.
https://bugs.webkit.org/show_bug.cgi?id=73370

Reviewed by Darin Adler.

Source/_javascript_Core:

* wtf/HashTable.h: Add the operators needed to do this.
(WTF::HashTableConstIterator::operator==):
(WTF::HashTableConstIterator::operator!=):
(WTF::HashTableIterator::operator==):
(WTF::HashTableIterator::operator!=):
(WTF::operator==):
(WTF::operator!=):

Tools:

* TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
* TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
(TestWebKitAPI::TEST): Add a test for the new functionality.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/HashTable.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.gypi
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102482 => 102483)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-09 23:39:45 UTC (rev 102482)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-09 23:43:52 UTC (rev 102483)
@@ -1,3 +1,18 @@
+2011-12-09  David Levin  le...@chromium.org
+
+Hash* iterators should allow comparison between const and const versions.
+https://bugs.webkit.org/show_bug.cgi?id=73370
+
+Reviewed by Darin Adler.
+
+* wtf/HashTable.h: Add the operators needed to do this.
+(WTF::HashTableConstIterator::operator==):
+(WTF::HashTableConstIterator::operator!=):
+(WTF::HashTableIterator::operator==):
+(WTF::HashTableIterator::operator!=):
+(WTF::operator==):
+(WTF::operator!=):
+
 2011-12-09  Michael Saboff  msab...@apple.com
 
 YARR: Multi-character read optimization for 8bit strings


Modified: trunk/Source/_javascript_Core/wtf/HashTable.h (102482 => 102483)

--- trunk/Source/_javascript_Core/wtf/HashTable.h	2011-12-09 23:39:45 UTC (rev 102482)
+++ trunk/Source/_javascript_Core/wtf/HashTable.h	2011-12-09 23:43:52 UTC (rev 102483)
@@ -188,6 +188,14 @@
 checkValidity(other);
 return m_position != other.m_position;
 }
+bool operator==(const iterator other) const
+{
+return *this == static_castconst_iterator(other);
+}
+bool operator!=(const iterator other) const
+{
+return *this != static_castconst_iterator(other);
+}
 
 private:
 void checkValidity() const
@@ -253,6 +261,8 @@
 // Comparison.
 bool operator==(const iterator other) const { return m_iterator == other.m_iterator; }
 bool operator!=(const iterator other) const { return m_iterator != other.m_iterator; }
+bool operator==(const const_iterator other) const { return m_iterator == other; }
+bool operator!=(const const_iterator other) const { return m_iterator != other; }
 
 operator const_iterator() const { return m_iterator; }
 
@@ -1202,6 +1212,31 @@
 return a.m_impl != b.m_impl;
 }
 
+// All 4 combinations of ==, != and Const,non const.
+templatetypename T, typename U
+inline bool operator==(const HashTableConstIteratorAdapterT, U a, const HashTableIteratorAdapterT, U b)
+{
+return a.m_impl == b.m_impl;
+}
+
+templatetypename T, typename U
+inline bool operator!=(const HashTableConstIteratorAdapterT, U a, const HashTableIteratorAdapterT, U b)
+{
+return a.m_impl != b.m_impl;
+}
+
+templatetypename T, typename U
+inline bool operator==(const HashTableIteratorAdapterT, U a, const HashTableConstIteratorAdapterT, U b)
+{
+return a.m_impl == b.m_impl;
+}
+
+templatetypename T, typename U
+inline bool operator!=(const HashTableIteratorAdapterT, U a, const HashTableConstIteratorAdapterT, U b)
+{
+return a.m_impl != b.m_impl;
+}
+
 } // namespace WTF
 
 #include HashIterators.h


Modified: trunk/Tools/ChangeLog (102482 => 102483)

--- trunk/Tools/ChangeLog	2011-12-09 23:39:45 UTC (rev 102482)
+++ trunk/Tools/ChangeLog	2011-12-09 23:43:52 UTC (rev 102483)
@@ -1,3 +1,16 @@
+2011-12-09  David Levin  le...@chromium.org
+
+Hash* iterators should allow comparison between const and const versions.
+https://bugs.webkit.org/show_bug.cgi?id=73370
+
+Reviewed by Darin Adler.
+
+* TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
+* TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
+* TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
+

[webkit-changes] [102484] trunk

[weinig]

Title: [102484] trunk








Revision 102484
Author wei...@apple.com
Date 2011-12-09 15:45:49 -0800 (Fri, 09 Dec 2011)


Log Message
Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=74218

Reviewed by Anders Carlsson.

Source/WebKit2: 

Test: WebKit2.WKConnectionTest in TestWebKitAPI

* Shared/WebConnection.cpp:
(WebKit::WebConnection::forwardDidReceiveMessageToClient):
* Shared/WebConnection.h:
Add helper for connection subclasses to dispatch to the client.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::didReceiveMessage):
Handle postMessage messages from the WebProcess.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidFinishLaunching):
Dispatch the notification that a connection to the WebProcess has
been established.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGetApplicationConnection):
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::webConnectionToUIProcess):
* WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::WebProcess::webConnectionToUIProcess):
Add accessor to get the connection to the UIProcess from
the bundle.

* WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::didReceiveMessage):
Handle postMessage messages from the UIProcess.
* WebProcess/WebProcess.h:

Tools: 

Add a test of the WKConnectionRef API.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
(TestWebKitAPI::didCreateConnection):
(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::connectionDidClose):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::WKConnectionTest::WKConnectionTest):
(TestWebKitAPI::WKConnectionTest::initialize):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebConnection.cpp
trunk/Source/WebKit2/Shared/WebConnection.h
trunk/Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
trunk/Source/WebKit2/WebProcess/WebConnectionToUIProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKConnection.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102483 => 102484)

--- trunk/Source/WebKit2/ChangeLog	2011-12-09 23:43:52 UTC (rev 102483)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-09 23:45:49 UTC (rev 102484)
@@ -1,3 +1,41 @@
+2011-12-09  Sam Weinig  s...@webkit.org
+
+Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
+https://bugs.webkit.org/show_bug.cgi?id=74218
+
+Reviewed by Anders Carlsson.
+
+Test: WebKit2.WKConnectionTest in TestWebKitAPI
+
+* Shared/WebConnection.cpp:
+(WebKit::WebConnection::forwardDidReceiveMessageToClient):
+* Shared/WebConnection.h:
+Add helper for connection subclasses to dispatch to the client.
+
+* UIProcess/WebConnectionToWebProcess.cpp:
+(WebKit::WebConnectionToWebProcess::didReceiveMessage):
+Handle postMessage messages from the WebProcess.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::processDidFinishLaunching):
+Dispatch the notification that a connection to the WebProcess has
+been established.
+
+* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+(WKBundleGetApplicationConnection):
+* WebProcess/InjectedBundle/API/c/WKBundle.h:
+* WebProcess/InjectedBundle/InjectedBundle.cpp:
+(WebKit::InjectedBundle::webConnectionToUIProcess):
+* WebProcess/InjectedBundle/InjectedBundle.h:
+(WebKit::WebProcess::webConnectionToUIProcess):
+Add accessor to get the connection to the UIProcess from
+the bundle.
+
+* WebProcess/WebConnectionToUIProcess.cpp:
+(WebKit::WebConnectionToUIProcess::didReceiveMessage):
+Handle postMessage messages from the UIProcess.
+* WebProcess/WebProcess.h:
+
 2011-12-08  Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 [Qt] Update WebGraphicLayer's child content scale in all child binding method.


Modified: trunk/Source/WebKit2/Shared/WebConnection.cpp (102483 => 102484)

--- trunk/Source/WebKit2/Shared/WebConnection.cpp	2011-12-09 23:43:52 UTC (rev 102483)
+++ trunk/Source/WebKit2/Shared/WebConnection.cpp	2011-12-09 23:45:49 UTC (rev 102484)
@@ -37,4 +37,9 @@

[webkit-changes] [102486] trunk

[ojan]

Title: [102486] trunk








Revision 102486
Author o...@chromium.org
Date 2011-12-09 15:50:16 -0800 (Fri, 09 Dec 2011)


Log Message
add css parsing for flex-flow: wrap and wrap-reverse
https://bugs.webkit.org/show_bug.cgi?id=74008

Patch by Tony Chang t...@chromium.org on 2011-12-09
Reviewed by Ojan Vafai.

Source/WebCore:

Also save 2 bits in StyleFlexibleBoxData by changing the size of m_flexFlow (there are only 4 enum values).

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Print the wrap value if it exists.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Parse a second token and put the values into a CSSValueList.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyFlexFlow::applyInheritValue): Does not inherit.
(WebCore::ApplyPropertyFlexFlow::applyInitialValue):
(WebCore::ApplyPropertyFlexFlow::applyValue): Special handler for setting two render style values from one
CSS property.
(WebCore::ApplyPropertyFlexFlow::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexWrap):
(WebCore::InheritedFlags::setFlexWrap):
(WebCore::InheritedFlags::initialFlexWrap):
* rendering/style/RenderStyleConstants.h: EFlexWrap to hold flex wrap values.
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h: 2 bits is enough to hold the 4 flexFlow values.

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js: Test call combinations of flex-flow values.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/css-properties-expected.txt
trunk/LayoutTests/css3/flexbox/script-tests/css-properties.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp
trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.h




Diff

Modified: trunk/LayoutTests/ChangeLog (102485 => 102486)

--- trunk/LayoutTests/ChangeLog	2011-12-09 23:47:42 UTC (rev 102485)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 23:50:16 UTC (rev 102486)
@@ -1,3 +1,13 @@
+2011-12-09  Tony Chang  t...@chromium.org
+
+add css parsing for flex-flow: wrap and wrap-reverse
+https://bugs.webkit.org/show_bug.cgi?id=74008
+
+Reviewed by Ojan Vafai.
+
+* css3/flexbox/css-properties-expected.txt:
+* css3/flexbox/script-tests/css-properties.js: Test call combinations of flex-flow values.
+
 2011-12-09  Adam Klein  ad...@chromium.org
 
 [MutationObservers] Add test for deliver-at-end-of-task semantics


Modified: trunk/LayoutTests/css3/flexbox/css-properties-expected.txt (102485 => 102486)

--- trunk/LayoutTests/css3/flexbox/css-properties-expected.txt	2011-12-09 23:47:42 UTC (rev 102485)
+++ trunk/LayoutTests/css3/flexbox/css-properties-expected.txt	2011-12-09 23:50:16 UTC (rev 102486)
@@ -44,16 +44,52 @@
 PASS flexbox.style.webkitFlexAlign is 
 PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is stretch
 PASS flexbox.style.webkitFlexFlow is 
-PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row nowrap
 PASS flexbox.style.webkitFlexFlow is 
+PASS flexbox.style.webkitFlexFlow is 
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row nowrap
+PASS flexbox.style.webkitFlexFlow is row nowrap
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row nowrap
+PASS flexbox.style.webkitFlexFlow is row wrap
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row wrap
+PASS flexbox.style.webkitFlexFlow is row wrap-reverse
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row wrap-reverse
 PASS flexbox.style.webkitFlexFlow is row
-PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row nowrap
+PASS flexbox.style.webkitFlexFlow is row nowrap
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row nowrap
+PASS flexbox.style.webkitFlexFlow is row wrap
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row wrap
+PASS flexbox.style.webkitFlexFlow is row wrap-reverse
+PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is row wrap-reverse
 PASS flexbox.style.webkitFlexFlow is row-reverse
-PASS 

[webkit-changes] [102487] trunk/Tools

[haraken]

Title: [102487] trunk/Tools








Revision 102487
Author hara...@chromium.org
Date 2011-12-09 15:50:58 -0800 (Fri, 09 Dec 2011)


Log Message
[Refactoring] Reduce top-level code in prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74172

Reviewed by Ryosuke Niwa.

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.

* Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
(generateFunctionLists):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (102486 => 102487)

--- trunk/Tools/ChangeLog	2011-12-09 23:50:16 UTC (rev 102486)
+++ trunk/Tools/ChangeLog	2011-12-09 23:50:58 UTC (rev 102487)
@@ -1,3 +1,17 @@
+2011-12-09  Kentaro Hara  hara...@chromium.org
+
+[Refactoring] Reduce top-level code in prepare-ChangeLog
+https://bugs.webkit.org/show_bug.cgi?id=74172
+
+Reviewed by Ryosuke Niwa.
+
+The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
+This requires to remove top-level code. This patch is one of the incremental refactorings
+for that.
+
+* Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
+(generateFunctionLists):
+
 2011-12-09  Sam Weinig  s...@webkit.org
 
 Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess


Modified: trunk/Tools/Scripts/prepare-ChangeLog (102486 => 102487)

--- trunk/Tools/Scripts/prepare-ChangeLog	2011-12-09 23:50:16 UTC (rev 102486)
+++ trunk/Tools/Scripts/prepare-ChangeLog	2011-12-09 23:50:58 UTC (rev 102487)
@@ -78,6 +78,7 @@
 sub determinePropertyChanges($$$);
 sub pluralizeAndList($$@);
 sub generateFileList(\@\@\%);
+sub generateFunctionLists(\@\%);
 sub isUnmodifiedStatus($);
 sub isModifiedStatus($);
 sub isAddedStatus($);
@@ -160,12 +161,9 @@
 
 # Find the list of modified files
 my @changed_files;
-my $changed_files_string;
-my %changed_line_ranges;
 my %function_lists;
 my @conflict_files;
 
-
 my %supportedTestExtensions = map { $_ = 1 } qw(html shtml svg xml xhtml pl php);
 my @addedRegressionTests = ();
 my $didChangeRegressionTests = 0;
@@ -183,73 +181,8 @@
 exit 1;
 }
 
-if (@changed_files) {
-$changed_files_string = ' . join (' ', @changed_files) . ';
+generateFunctionLists(@changed_files, %function_lists);
 
-# For each file, build a list of modified lines.
-# Use line numbers from the after side of each diff.
-print STDERR   Reviewing diff to determine which lines changed.\n;
-my $file;
-open DIFF, -|, diffCommand(@changed_files) or die The diff failed: $!.\n;
-while (DIFF) {
-$file = makeFilePathRelative($1) if $_ =~ diffHeaderFormat();
-if (defined $file) {
-my ($start, $end) = extractLineRange($_);
-if ($start = 0  $end = 0) {
-push @{$changed_line_ranges{$file}}, [ $start, $end ];
-} elsif (/DO_NOT_COMMIT/) {
-print STDERR WARNING: file $file contains the string DO_NOT_COMMIT, line $.\n;
-}
-}
-}
-close DIFF;
-}
-
-# For each source file, convert line range to function list.
-if (%changed_line_ranges) {
-print STDERR   Extracting affected function names from source files.\n;
-foreach my $file (keys %changed_line_ranges) {
-# Find all the functions in the file.
-open SOURCE, $file or next;
-my @function_ranges = get_function_line_ranges(\*SOURCE, $file);
-close SOURCE;
-
-# Find all the modified functions.
-my @functions;
-my %saw_function;
-my @change_ranges = (@{$changed_line_ranges{$file}}, []);
-my @change_range = (0, 0);
-FUNCTION: foreach my $function_range_ref (@function_ranges) {
-my @function_range = @$function_range_ref;
-
-# Advance to successive change ranges.
-for (;; @change_range = @{shift @change_ranges}) {
-last FUNCTION unless @change_range;
-
-# If past this function, move on to the next one.
-next FUNCTION if $change_range[0]  $function_range[1];
-
-# If an overlap with this function range, record the function name.
-if ($change_range[1] = $function_range[0]
-and $change_range[0] = $function_range[1]) {
-if (!$saw_function{$function_range[2]}) {
-$saw_function{$function_range[2]} = 1;
-push @functions, $function_range[2];
-}
-next FUNCTION;
-}
-}
-}
-
-# Format the list of functions now.
-
-if (@functions) {
-$function_lists{$file} =  if !defined $function_lists{$file};
-   

[webkit-changes] [102488] trunk

[commit-queue]

Title: [102488] trunk








Revision 102488
Author commit-qu...@webkit.org
Date 2011-12-09 15:53:35 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt] Click's count is limited to three continuous clicks.
https://bugs.webkit.org/show_bug.cgi?id=45666

Patch by Hugo Parente Lima hugo.l...@openbossa.org on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Make Qt recognize infinite continuous mouse clicks.
handleMouseDoubleClickEvent merged into handleMousePressEvent.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::timerEvent):
* UIProcess/qt/QtWebPageEventHandler.h:

Tools:

Update m_time at every call to leapForward, so double clicks
event are correctly sent by EventSender.

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::leapForward):

LayoutTests:

Enable fast/events/click-count.html for qt and disable for qt-wk1.

* platform/qt-wk1/Skipped:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt-wk1/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (102487 => 102488)

--- trunk/LayoutTests/ChangeLog	2011-12-09 23:50:58 UTC (rev 102487)
+++ trunk/LayoutTests/ChangeLog	2011-12-09 23:53:35 UTC (rev 102488)
@@ -1,3 +1,15 @@
+2011-12-09  Hugo Parente Lima  hugo.l...@openbossa.org
+
+[Qt] Click's count is limited to three continuous clicks.
+https://bugs.webkit.org/show_bug.cgi?id=45666
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Enable fast/events/click-count.html for qt and disable for qt-wk1.
+
+* platform/qt-wk1/Skipped:
+* platform/qt/Skipped:
+
 2011-12-09  Tony Chang  t...@chromium.org
 
 add css parsing for flex-flow: wrap and wrap-reverse


Modified: trunk/LayoutTests/platform/qt/Skipped (102487 => 102488)

--- trunk/LayoutTests/platform/qt/Skipped	2011-12-09 23:50:58 UTC (rev 102487)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-12-09 23:53:35 UTC (rev 102488)
@@ -1130,7 +1130,6 @@
 fast/encoding/GBK/x-euc-cn.html
 fast/encoding/GBK/x-gbk.html
 fast/events/autoscroll.html
-fast/events/click-count.html
 fast/events/content-changed-during-drop.html
 fast/events/js-keyboard-event-creation.html
 fast/events/keypress-insert-tab.html


Modified: trunk/LayoutTests/platform/qt-wk1/Skipped (102487 => 102488)

--- trunk/LayoutTests/platform/qt-wk1/Skipped	2011-12-09 23:50:58 UTC (rev 102487)
+++ trunk/LayoutTests/platform/qt-wk1/Skipped	2011-12-09 23:53:35 UTC (rev 102488)
@@ -4,6 +4,10 @@
 # https://bugs.webkit.org/show_bug.cgi?id=73366
 fast/events/dont-loose-last-event.html
 
+# This has been fixed only on qt-wk2
+# https://bugs.webkit.org/show_bug.cgi?id=45666
+fast/events/click-count.html
+
 # [Qt] http/tests/misc/drag-over-iframe-invalid-source-crash.html and fast/events/drag-selects-image.html fails with timeout
 # https://bugs.webkit.org/show_bug.cgi?id=73901
 http/tests/misc/drag-over-iframe-invalid-source-crash.html


Modified: trunk/Source/WebKit2/ChangeLog (102487 => 102488)

--- trunk/Source/WebKit2/ChangeLog	2011-12-09 23:50:58 UTC (rev 102487)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-09 23:53:35 UTC (rev 102488)
@@ -1,3 +1,20 @@
+2011-12-09  Hugo Parente Lima  hugo.l...@openbossa.org
+
+[Qt] Click's count is limited to three continuous clicks.
+https://bugs.webkit.org/show_bug.cgi?id=45666
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Make Qt recognize infinite continuous mouse clicks.
+handleMouseDoubleClickEvent merged into handleMousePressEvent.
+
+* UIProcess/qt/QtWebPageEventHandler.cpp:
+(QtWebPageEventHandler::QtWebPageEventHandler):
+(QtWebPageEventHandler::handleEvent):
+(QtWebPageEventHandler::handleMousePressEvent):
+(QtWebPageEventHandler::timerEvent):
+* UIProcess/qt/QtWebPageEventHandler.h:
+
 2011-12-09  Sam Weinig  s...@webkit.org
 
 Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp (102487 => 102488)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2011-12-09 23:50:58 UTC (rev 102487)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2011-12-09 23:53:35 UTC (rev 102488)
@@ -83,6 +83,8 @@
 , m_panGestureRecognizer(this)
 , m_pinchGestureRecognizer(this)
 , m_tapGestureRecognizer(this)
+, m_previousClickButton(Qt::NoButton)
+, m_clickCount(0)
 {
 }
 
@@ -94,36 +96,37 @@
 {
 switch (ev-type()) {
 case 

[webkit-changes] [102489] trunk/Source/JavaScriptCore

[fpizlo]

Title: [102489] trunk/Source/_javascript_Core








Revision 102489
Author fpi...@apple.com
Date 2011-12-09 16:09:55 -0800 (Fri, 09 Dec 2011)


Log Message
DFG's interpretation of rare case profiles should be frequency-based not count-based
https://bugs.webkit.org/show_bug.cgi?id=74170

Reviewed by Geoff Garen.

DFG optimizes for rare cases only when the rare case counter is above some threshold
and it also constitutes a large enough fraction of total function executions. Also
added some minor debug logic.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::executionEntryCount):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGDriver.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/runtime/Heuristics.cpp
trunk/Source/_javascript_Core/runtime/Heuristics.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102488 => 102489)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-09 23:53:35 UTC (rev 102488)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-10 00:09:55 UTC (rev 102489)
@@ -1,3 +1,36 @@
+2011-12-09  Filip Pizlo  fpi...@apple.com
+
+DFG's interpretation of rare case profiles should be frequency-based not count-based
+https://bugs.webkit.org/show_bug.cgi?id=74170
+
+Reviewed by Geoff Garen.
+
+DFG optimizes for rare cases only when the rare case counter is above some threshold
+and it also constitutes a large enough fraction of total function executions. Also
+added some minor debug logic.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::likelyToTakeSlowCase):
+(JSC::CodeBlock::couldTakeSlowCase):
+(JSC::CodeBlock::likelyToTakeSpecialFastCase):
+(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
+(JSC::CodeBlock::likelyToTakeAnySlowCase):
+(JSC::CodeBlock::executionEntryCount):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::makeSafe):
+(JSC::DFG::ByteCodeParser::makeDivSafe):
+(JSC::DFG::ByteCodeParser::handleCall):
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGDriver.cpp:
+(JSC::DFG::compile):
+* jit/JIT.cpp:
+(JSC::JIT::privateCompile):
+* runtime/Heuristics.cpp:
+(JSC::Heuristics::initializeHeuristics):
+* runtime/Heuristics.h:
+
 2011-12-09  Oliver Hunt  oli...@apple.com
 
 PutByValAlias unnecessarily clobbers GetIndexedPropertyStorage


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (102488 => 102489)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-12-09 23:53:35 UTC (rev 102488)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-12-10 00:09:55 UTC (rev 102489)
@@ -1433,6 +1433,9 @@
 #if ENABLE(JIT)
 , m_globalResolveInfos(other.m_globalResolveInfos)
 #endif
+#if ENABLE(VALUE_PROFILER)
+, m_executionEntryCount(0)
+#endif
 , m_jumpTargets(other.m_jumpTargets)
 , m_loopTargets(other.m_loopTargets)
 , m_identifiers(other.m_identifiers)
@@ -1481,6 +1484,9 @@
 , m_codeType(codeType)
 , m_source(sourceProvider)
 , m_sourceOffset(sourceOffset)
+#if ENABLE(VALUE_PROFILER)
+, m_executionEntryCount(0)
+#endif
 , m_symbolTable(symTab)
 , m_alternative(alternative)
 , m_speculativeSuccessCounter(0)
@@ -2235,16 +2241,6 @@
 }
 #endif
 
-#if ENABLE(VALUE_PROFILER)
-void CodeBlock::resetRareCaseProfiles()
-{
-for (unsigned i = 0; i  numberOfRareCaseProfiles(); ++i)
-rareCaseProfile(i)-m_counter = 0;
-for (unsigned i = 0; i  numberOfSpecialFastCaseProfiles(); ++i)
-specialFastCaseProfile(i)-m_counter = 0;
-}
-#endif
-
 #if ENABLE(VERBOSE_VALUE_PROFILE)
 void CodeBlock::dumpValueProfiles()
 {


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (102488 => 102489)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-12-09 23:53:35 UTC (rev 102488)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-12-10 00:09:55 UTC (rev 102489)
@@ -676,12 +676,14 @@
 
 bool likelyToTakeSlowCase(int bytecodeOffset)

[webkit-changes] [102490] trunk

[dpranke]

Title: [102490] trunk








Revision 102490
Author dpra...@chromium.org
Date 2011-12-09 16:41:40 -0800 (Fri, 09 Dec 2011)


Log Message
chromium win build: revert build_webkit_exes_from_webkit_gyp change
https://bugs.webkit.org/show_bug.cgi?id=74225

Source/WebKit/chromium:

Reviewed by Tony Chang.

This change sets build_webkit_exes_from_webkit_gyp back to 1;
the All.gyp solution doesn't work on windows.

* gyp_webkit:

Tools:

This change sets build_webkit_exes_from_webkit_gyp back to 1;
the All.gyp solution doesn't work on windows.

* Scripts/webkitdirs.pm:
(buildChromium):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/gyp_webkit
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102489 => 102490)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 00:09:55 UTC (rev 102489)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 00:41:40 UTC (rev 102490)
@@ -1,5 +1,17 @@
 2011-12-09  Dirk Pranke  dpra...@chromium.org
 
+chromium win build: revert build_webkit_exes_from_webkit_gyp change
+https://bugs.webkit.org/show_bug.cgi?id=74225
+
+Reviewed by Tony Chang.
+
+This change sets build_webkit_exes_from_webkit_gyp back to 1;
+the All.gyp solution doesn't work on windows.
+
+* gyp_webkit:
+
+2011-12-09  Dirk Pranke  dpra...@chromium.org
+
 chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
 https://bugs.webkit.org/show_bug.cgi?id=74212
 


Modified: trunk/Source/WebKit/chromium/gyp_webkit (102489 => 102490)

--- trunk/Source/WebKit/chromium/gyp_webkit	2011-12-10 00:09:55 UTC (rev 102489)
+++ trunk/Source/WebKit/chromium/gyp_webkit	2011-12-10 00:41:40 UTC (rev 102490)
@@ -120,7 +120,7 @@
'-Dv8_use_snapshot=false',
'-Dmsvs_use_common_release=0',
'-Ddisable_nacl=1',
-   '-Dbuild_webkit_exes_from_webkit_gyp=0',
+   '-Dbuild_webkit_exes_from_webkit_gyp=1',
 
# WebKit doesn't use the chromium style checker.
'-Dmake_clang_dir=Source/WebKit/chromium/third_party/llvm-build/Release+Asserts',
@@ -130,7 +130,7 @@
'--depth=./',
 
# gyp file to execute.
-   'All.gyp'])
+   'WebKit.gyp'])
 
   print 'Updating webkit projects from gyp files...'
   sys.stdout.flush()


Modified: trunk/Tools/ChangeLog (102489 => 102490)

--- trunk/Tools/ChangeLog	2011-12-10 00:09:55 UTC (rev 102489)
+++ trunk/Tools/ChangeLog	2011-12-10 00:41:40 UTC (rev 102490)
@@ -1,3 +1,14 @@
+2011-12-09  Dirk Pranke  dpra...@chromium.org
+
+chromium win build: revert build_webkit_exes_from_webkit_gyp change
+https://bugs.webkit.org/show_bug.cgi?id=74225
+
+This change sets build_webkit_exes_from_webkit_gyp back to 1;
+the All.gyp solution doesn't work on windows.
+
+* Scripts/webkitdirs.pm:
+(buildChromium):
+
 2011-12-09  Hugo Parente Lima  hugo.l...@openbossa.org
 
 [Qt] Click's count is limited to three continuous clicks.


Modified: trunk/Tools/Scripts/webkitdirs.pm (102489 => 102490)

--- trunk/Tools/Scripts/webkitdirs.pm	2011-12-10 00:09:55 UTC (rev 102489)
+++ trunk/Tools/Scripts/webkitdirs.pm	2011-12-10 00:41:40 UTC (rev 102490)
@@ -2081,10 +2081,10 @@
 my $result = 1;
 if (isDarwin()  !isChromiumAndroid()  !isChromiumMacMake()) {
 # Mac build - builds the root xcode project.
-$result = buildXCodeProject(Source/WebKit/chromium/All, $clean, -configuration, configuration(), @options);
+$result = buildXCodeProject(Source/WebKit/chromium/WebKit, $clean, -configuration, configuration(), @options);
 } elsif (isCygwin() || isWindows()) {
 # Windows build - builds the root visual studio solution.
-$result = buildChromiumVisualStudioProject(Source/WebKit/chromium/All.sln, $clean);
+$result = buildChromiumVisualStudioProject(Source/WebKit/chromium/WebKit.sln, $clean);
 } elsif (isLinux() || isChromiumAndroid() || isChromiumMacMake) {
 # Linux build - build using make.
 $result = buildChromiumMakefile(all, $clean, @options);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102491] trunk/LayoutTests

[tony]

Title: [102491] trunk/LayoutTests








Revision 102491
Author t...@chromium.org
Date 2011-12-09 16:47:29 -0800 (Fri, 09 Dec 2011)


Log Message
Fix test expectations from r102486: flex-flow returns direction and wrap now.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/chromium/svg/css/getComputedStyle-basic-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
trunk/LayoutTests/platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102490 => 102491)

--- trunk/LayoutTests/ChangeLog	2011-12-10 00:41:40 UTC (rev 102490)
+++ trunk/LayoutTests/ChangeLog	2011-12-10 00:47:29 UTC (rev 102491)
@@ -1,3 +1,17 @@
+2011-12-09  Tony Chang  t...@chromium.org
+
+Fix test expectations from r102486: flex-flow returns direction and wrap now.
+
+* fast/css/getComputedStyle/computed-style-expected.txt:
+* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
+* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
+* platform/chromium/svg/css/getComputedStyle-basic-expected.txt:
+* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* svg/css/getComputedStyle-basic-expected.txt:
+
 2011-12-09  Hugo Parente Lima  hugo.l...@openbossa.org
 
 [Qt] Click's count is limited to three continuous clicks.


Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (102490 => 102491)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2011-12-10 00:41:40 UTC (rev 102490)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2011-12-10 00:47:29 UTC (rev 102491)
@@ -145,7 +145,7 @@
 -webkit-flex-order: 0;
 -webkit-flex-pack: start;
 -webkit-flex-align: stretch;
--webkit-flex-flow: row;
+-webkit-flex-flow: row nowrap;
 -webkit-font-smoothing: auto;
 -webkit-highlight: none;
 -webkit-hyphenate-character: auto;


Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (102490 => 102491)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2011-12-10 00:41:40 UTC (rev 102490)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2011-12-10 00:47:29 UTC (rev 102491)
@@ -144,7 +144,7 @@
 -webkit-flex-order: 0
 -webkit-flex-pack: start
 -webkit-flex-align: stretch
--webkit-flex-flow: row
+-webkit-flex-flow: row nowrap
 -webkit-font-smoothing: auto
 -webkit-highlight: none
 -webkit-hyphenate-character: auto


Modified: trunk/LayoutTests/platform/chromium/svg/css/getComputedStyle-basic-expected.txt (102490 => 102491)

--- trunk/LayoutTests/platform/chromium/svg/css/getComputedStyle-basic-expected.txt	2011-12-10 00:41:40 UTC (rev 102490)
+++ trunk/LayoutTests/platform/chromium/svg/css/getComputedStyle-basic-expected.txt	2011-12-10 00:47:29 UTC (rev 102491)
@@ -288,8 +288,8 @@
 rect: style.getPropertyCSSValue(-webkit-flex-pack) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(-webkit-flex-align) : stretch
 rect: style.getPropertyCSSValue(-webkit-flex-align) : [object CSSPrimitiveValue]
-rect: style.getPropertyValue(-webkit-flex-flow) : row
-rect: style.getPropertyCSSValue(-webkit-flex-flow) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(-webkit-flex-flow) : row nowrap
+rect: 

[webkit-changes] [102493] trunk/Source/WebKit2

[commit-queue]

Title: [102493] trunk/Source/WebKit2








Revision 102493
Author commit-qu...@webkit.org
Date 2011-12-09 17:01:12 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt] Open shared memory files with shm_open.
https://bugs.webkit.org/show_bug.cgi?id=74078

Original patch by Kimmo Kinnunen

Patch by Allan Sandfeld Jensen allan.jen...@nokia.com on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

Open shared memory files with shm_open. This uses mount point that is
intended to host shared memory files. Typically this is /dev/shm.

This fixes crashes when filesystem that hosts QDir::temp() is full.

This is also more well-defined with respect to question whether SHM
writes to temp dir would cause unintended wear if hosted on flash drives.

This also fixes performance problems regarding QDir::temp() and
mkostemp(), both of which appear to be long operations.

* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102492 => 102493)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:01:02 UTC (rev 102492)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 01:01:12 UTC (rev 102493)
@@ -1,3 +1,26 @@
+2011-12-09  Allan Sandfeld Jensen  allan.jen...@nokia.com
+
+[Qt] Open shared memory files with shm_open.
+https://bugs.webkit.org/show_bug.cgi?id=74078
+
+Original patch by Kimmo Kinnunen
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Open shared memory files with shm_open. This uses mount point that is
+intended to host shared memory files. Typically this is /dev/shm.
+
+This fixes crashes when filesystem that hosts QDir::temp() is full.
+
+This is also more well-defined with respect to question whether SHM
+writes to temp dir would cause unintended wear if hosted on flash drives.
+
+This also fixes performance problems regarding QDir::temp() and
+mkostemp(), both of which appear to be long operations.
+
+* Platform/unix/SharedMemoryUnix.cpp:
+(WebKit::SharedMemory::create):
+
 2011-12-09  Hugo Parente Lima  hugo.l...@openbossa.org
 
 [Qt] Click's count is limited to three continuous clicks.


Modified: trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp (102492 => 102493)

--- trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2011-12-10 01:01:02 UTC (rev 102492)
+++ trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2011-12-10 01:01:12 UTC (rev 102493)
@@ -105,8 +105,8 @@
 PassRefPtrSharedMemory SharedMemory::create(size_t size)
 {
 #if PLATFORM(QT)
-QString tempName = QDir::temp().filePath(QLatin1String(qwkshm.XX));
-QByteArray tempNameCSTR = tempName.toLocal8Bit();
+QByteArray tempNameCSTR(/qwkshm.);
+tempNameCSTR += QByteArray::number(qrand(), 36);
 char* tempNameC = tempNameCSTR.data();
 #elif PLATFORM(GTK)
 GOwnPtrgchar tempName(g_build_filename(g_get_tmp_dir(), WK2SharedMemoryXX, NULL));
@@ -114,6 +114,12 @@
 #endif
 
 int fileDescriptor;
+#if PLATFORM(QT)
+while ((fileDescriptor = shm_open(tempNameC, O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR)) == -1) {
+if (errno != EINTR)
+return 0;
+}
+#else
 while ((fileDescriptor = mkstemp(tempNameC)) == -1) {
 if (errno != EINTR)
 return 0;
@@ -125,11 +131,15 @@
 return 0;
 }
 }
-
+#endif
 while (ftruncate(fileDescriptor, size) == -1) {
 if (errno != EINTR) {
 while (close(fileDescriptor) == -1  errno == EINTR) { }
+#if PLATFORM(QT)
+shm_unlink(tempNameC);
+#else
 unlink(tempNameC);
+#endif
 return 0;
 }
 }
@@ -137,11 +147,19 @@
 void* data = "" size, PROT_READ | PROT_WRITE, MAP_SHARED, fileDescriptor, 0);
 if (data == MAP_FAILED) {
 while (close(fileDescriptor) == -1  errno == EINTR) { }
+#if PLATFORM(QT)
+shm_unlink(tempNameC);
+#else
 unlink(tempNameC);
+#endif
 return 0;
 }
 
+#if PLATFORM(QT)
+shm_unlink(tempNameC);
+#else
 unlink(tempNameC);
+#endif
 
 RefPtrSharedMemory instance = adoptRef(new SharedMemory());
 instance-m_data = data;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102492] trunk/Source/WebCore

[commit-queue]

Title: [102492] trunk/Source/WebCore








Revision 102492
Author commit-qu...@webkit.org
Date 2011-12-09 17:01:02 -0800 (Fri, 09 Dec 2011)


Log Message
Small style fix on DragDataBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74171

Patch by Mary Wu mary...@torchmobile.com.cn on 2011-12-09
Reviewed by Rob Buis.

Style fix, no function impact, no new tests.

* platform/blackberry/DragDataBlackBerry.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102491 => 102492)

--- trunk/Source/WebCore/ChangeLog	2011-12-10 00:47:29 UTC (rev 102491)
+++ trunk/Source/WebCore/ChangeLog	2011-12-10 01:01:02 UTC (rev 102492)
@@ -1,3 +1,18 @@
+2011-12-09  Mary Wu  mary...@torchmobile.com.cn
+
+Small style fix on DragDataBlackBerry.cpp
+https://bugs.webkit.org/show_bug.cgi?id=74171
+
+Reviewed by Rob Buis.
+
+Style fix, no function impact, no new tests.
+
+* platform/blackberry/DragDataBlackBerry.cpp:
+(WebCore::DragData::containsURL):
+(WebCore::DragData::asFilenames):
+(WebCore::DragData::asURL):
+(WebCore::DragData::asFragment):
+
 2011-12-09  Tony Chang  t...@chromium.org
 
 add css parsing for flex-flow: wrap and wrap-reverse


Modified: trunk/Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp (102491 => 102492)

--- trunk/Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp	2011-12-10 00:47:29 UTC (rev 102491)
+++ trunk/Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp	2011-12-10 01:01:02 UTC (rev 102492)
@@ -58,15 +58,14 @@
 return false;
 }
 
-bool DragData::containsURL(Frame*, FilenameConversionPolicy filenamePolicy) const
+bool DragData::containsURL(Frame*, FilenameConversionPolicy) const
 {
 notImplemented();
 return false;
 }
 
-void DragData::asFilenames(WTF::VectorString, 0u result) const
+void DragData::asFilenames(VectorString) const
 {
-// FIXME: remove explicit 0 size in result template once this is implemented
 notImplemented();
 }
 
@@ -82,14 +81,13 @@
 return String();
 }
 
-String DragData::asURL(Frame*, FilenameConversionPolicy filenamePolicy, String* title) const
+String DragData::asURL(Frame*, FilenameConversionPolicy, String*) const
 {
 notImplemented();
 return String();
 }
 
-WTF::PassRefPtrDocumentFragment DragData::asFragment(Frame*, PassRefPtrRange context,
-bool allowPlainText, bool chosePlainText) const
+PassRefPtrDocumentFragment DragData::asFragment(Frame*, PassRefPtrRange, bool, bool) const
 {
 notImplemented();
 return 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102494] trunk/Source/WebKit2

[weinig]

Title: [102494] trunk/Source/WebKit2








Revision 102494
Author wei...@apple.com
Date 2011-12-09 17:05:18 -0800 (Fri, 09 Dec 2011)


Log Message
Add WKView implementation for quickLookPreviewItemsAtWindowLocation.
rdar://problem/10472505

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKView.mm:
(-[WKView quickLookPreviewItemsAtWindowLocation:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102493 => 102494)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:01:12 UTC (rev 102493)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 01:05:18 UTC (rev 102494)
@@ -1,3 +1,13 @@
+2011-12-09  Sam Weinig  s...@webkit.org
+
+Add WKView implementation for quickLookPreviewItemsAtWindowLocation.
+rdar://problem/10472505
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView quickLookPreviewItemsAtWindowLocation:]):
+
 2011-12-09  Allan Sandfeld Jensen  allan.jen...@nokia.com
 
 [Qt] Open shared memory files with shm_open.


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (102493 => 102494)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2011-12-10 01:01:12 UTC (rev 102493)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2011-12-10 01:05:18 UTC (rev 102494)
@@ -2098,6 +2098,14 @@
 return NO;
 }
 
+#if !defined(BUILDING_ON_SNOW_LEOPARD)  !defined(BUILDING_ON_LION)
+- (void)quickLookPreviewItemsAtWindowLocation:(NSPoint)location
+{
+NSPoint locationInViewCoordinates = [self convertPoint:location fromView:nil];
+_data-_page-performDictionaryLookupAtLocation(FloatPoint(locationInViewCoordinates.x, locationInViewCoordinates.y));
+}
+#endif
+
 @end
 
 @implementation WKView (Internal)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102495] trunk/Source/WebKit/chromium

[commit-queue]

Title: [102495] trunk/Source/WebKit/chromium








Revision 102495
Author commit-qu...@webkit.org
Date 2011-12-09 17:09:09 -0800 (Fri, 09 Dec 2011)


Log Message
[chromium] add event methods to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=73259

Patch by Karl Koscher super...@chromium.org on 2011-12-09
Reviewed by Darin Fisher.

* public/WebDOMEventListener.h: Use EventTarget instead of Node
* public/WebFrame.h: Add event methods
* src/WebDOMEventListener.cpp: Use EventTarget instead of Node
(WebKit::WebDOMEventListener::createEventListenerWrapper):
(WebKit::WebDOMEventListener::getEventListenerWrapper):
* src/WebDOMEventListenerPrivate.cpp: Use EventTarget instead of Node
(WebKit::WebDOMEventListenerPrivate::createEventListenerWrapper):
(WebKit::WebDOMEventListenerPrivate::getEventListenerWrapper):
* src/WebDOMEventListenerPrivate.h: Use EventTarget instead of Node
(WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addEventListener): register a listener on a WebFrame
(WebKit::WebFrameImpl::removeEventListener): remove a listener on a WebFrame
(WebKit::WebFrameImpl::dispatchEvent): dispatch an event to a WebFrame
* src/WebFrameImpl.h: Add event methods

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDOMEventListener.h
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/src/WebDOMEventListener.cpp
trunk/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.cpp
trunk/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102494 => 102495)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 01:05:18 UTC (rev 102494)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 01:09:09 UTC (rev 102495)
@@ -1,3 +1,26 @@
+2011-12-09  Karl Koscher  super...@chromium.org
+
+[chromium] add event methods to WebFrame
+https://bugs.webkit.org/show_bug.cgi?id=73259
+
+Reviewed by Darin Fisher.
+
+* public/WebDOMEventListener.h: Use EventTarget instead of Node
+* public/WebFrame.h: Add event methods
+* src/WebDOMEventListener.cpp: Use EventTarget instead of Node
+(WebKit::WebDOMEventListener::createEventListenerWrapper):
+(WebKit::WebDOMEventListener::getEventListenerWrapper):
+* src/WebDOMEventListenerPrivate.cpp: Use EventTarget instead of Node
+(WebKit::WebDOMEventListenerPrivate::createEventListenerWrapper):
+(WebKit::WebDOMEventListenerPrivate::getEventListenerWrapper):
+* src/WebDOMEventListenerPrivate.h: Use EventTarget instead of Node
+(WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
+* src/WebFrameImpl.cpp:
+(WebKit::WebFrameImpl::addEventListener): register a listener on a WebFrame
+(WebKit::WebFrameImpl::removeEventListener): remove a listener on a WebFrame
+(WebKit::WebFrameImpl::dispatchEvent): dispatch an event to a WebFrame
+* src/WebFrameImpl.h: Add event methods
+
 2011-12-09  Dirk Pranke  dpra...@chromium.org
 
 chromium win build: revert build_webkit_exes_from_webkit_gyp change


Modified: trunk/Source/WebKit/chromium/public/WebDOMEventListener.h (102494 => 102495)

--- trunk/Source/WebKit/chromium/public/WebDOMEventListener.h	2011-12-10 01:05:18 UTC (rev 102494)
+++ trunk/Source/WebKit/chromium/public/WebDOMEventListener.h	2011-12-10 01:09:09 UTC (rev 102495)
@@ -34,7 +34,7 @@
 #include platform/WebCommon.h
 
 #if WEBKIT_IMPLEMENTATION
-namespace WebCore { class Node; }
+namespace WebCore { class EventTarget; }
 #endif
 
 namespace WebKit {
@@ -55,8 +55,8 @@
 
 #if WEBKIT_IMPLEMENTATION
 void notifyEventListenerDeleted(EventListenerWrapper*);
-EventListenerWrapper* createEventListenerWrapper(const WebString eventType, bool useCapture, WebCore::Node* node);
-EventListenerWrapper* getEventListenerWrapper(const WebString eventType, bool useCapture, WebCore::Node* node);
+EventListenerWrapper* createEventListenerWrapper(const WebString eventType, bool useCapture, WebCore::EventTarget*);
+EventListenerWrapper* getEventListenerWrapper(const WebString eventType, bool useCapture, WebCore::EventTarget*);
 #endif
 
 private:


Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (102494 => 102495)

--- trunk/Source/WebKit/chromium/public/WebFrame.h	2011-12-10 01:05:18 UTC (rev 102494)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h	2011-12-10 01:09:09 UTC (rev 102495)
@@ -550,6 +550,19 @@
 virtual void resetMatchCount() = 0;
 
 
+// Events --
+
+// These functions all work on the WebFrame's DOMWindow. Keep in mind
+// that these events might be generated by web content and not genuine
+// DOM events.
+
+virtual void addEventListener(const 

[webkit-changes] [102496] trunk/Source/WebKit/chromium

[commit-queue]

Title: [102496] trunk/Source/WebKit/chromium








Revision 102496
Author commit-qu...@webkit.org
Date 2011-12-09 17:18:20 -0800 (Fri, 09 Dec 2011)


Log Message
[chromium] add accessors to WebDOMMessageEvent
https://bugs.webkit.org/show_bug.cgi?id=73346

Patch by Karl Koscher super...@chromium.org on 2011-12-09
Reviewed by Darin Fisher.

* public/WebDOMMessageEvent.h:
* src/WebDOMMessageEvent.cpp:
(WebKit::WebDOMMessageEvent::data):
(WebKit::WebDOMMessageEvent::origin):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h
trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102495 => 102496)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 01:09:09 UTC (rev 102495)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 01:18:20 UTC (rev 102496)
@@ -1,5 +1,17 @@
 2011-12-09  Karl Koscher  super...@chromium.org
 
+[chromium] add accessors to WebDOMMessageEvent
+https://bugs.webkit.org/show_bug.cgi?id=73346
+
+Reviewed by Darin Fisher.
+
+* public/WebDOMMessageEvent.h:
+* src/WebDOMMessageEvent.cpp:
+(WebKit::WebDOMMessageEvent::data):
+(WebKit::WebDOMMessageEvent::origin):
+
+2011-12-09  Karl Koscher  super...@chromium.org
+
 [chromium] add event methods to WebFrame
 https://bugs.webkit.org/show_bug.cgi?id=73259
 


Modified: trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h (102495 => 102496)

--- trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h	2011-12-10 01:09:09 UTC (rev 102495)
+++ trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h	2011-12-10 01:18:20 UTC (rev 102496)
@@ -32,6 +32,7 @@
 
 #include WebDOMEvent.h
 #include WebMessagePortChannel.h
+#include platform/WebSerializedScriptValue.h
 
 #if WEBKIT_IMPLEMENTATION
 namespace WebCore { class Event; }
@@ -41,11 +42,13 @@
 
 class WebFrame;
 class WebString;
-class WebSerializedScriptValue;
 
 class WebDOMMessageEvent : public WebDOMEvent {
 public:
 WEBKIT_EXPORT void initMessageEvent(const WebString type, bool canBubble, bool cancelable, const WebSerializedScriptValue messageData, const WebString origin, const WebFrame* sourceFrame, const WebString lastEventId);
+
+WEBKIT_EXPORT WebSerializedScriptValue data() const;
+WEBKIT_EXPORT WebString origin() const;
 };
 
 } // namespace WebKit


Modified: trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp (102495 => 102496)

--- trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp	2011-12-10 01:09:09 UTC (rev 102495)
+++ trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp	2011-12-10 01:18:20 UTC (rev 102496)
@@ -60,4 +60,14 @@
 unwrapMessageEvent()-initMessageEvent(type, canBubble, cancelable, messageData, origin, lastEventId, window, ports.release());
 }
 
+WebSerializedScriptValue WebDOMMessageEvent::data() const
+{
+return WebSerializedScriptValue(constUnwrapMessageEvent()-data());
+}
+
+WebString WebDOMMessageEvent::origin() const
+{
+return WebString(constUnwrapMessageEvent()-origin());
+}
+
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102497] trunk/Source/WebKit2

[mrowe]

Title: [102497] trunk/Source/WebKit2








Revision 102497
Author mr...@apple.com
Date 2011-12-09 17:25:29 -0800 (Fri, 09 Dec 2011)


Log Message
http://webkit.org/b/74061 WebProcess and PluginProcess should inherit environment variables provided in LC_DYLD_ENVIRONMENT of main executable binary.

Reviewed by Darin Adler.

* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: Added.
* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: Added.
(WebKit::DynamicLinkerEnvironmentExtractor::DynamicLinkerEnvironmentExtractor):
(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable): Parse out the name
and value from the environment string and add an entry to our variable map if the variable
is one that dyld would respect in LC_DYLD_ENVIRONMENT.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommand): Look for a LC_DYLD_ENVIRONMENT
load command and extract any environment string that we find within.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommands): Iterate over each
load command in the Mach-O file.
(WebKit::DynamicLinkerEnvironmentExtractor::processSingleArchitecture): Determine whether
the Mach-O file is of the correct architecture, and if so then process the load commands
found within.
(WebKit::DynamicLinkerEnvironmentExtractor::processFatFile): Process each architecture of the
Mach-O file in turn.
(WebKit::DynamicLinkerEnvironmentExtractor::getExtractedEnvironmentVariables): Add our
extracted variables to the passed-in EnvironmentVariables object. We skip adding any
variables that already exist so as to allow variables passed in the environment to override
those that we extract from the executable file.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Extract the environment variables from the
main binary and add them to the launch environment of our subprocess.
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h
trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102496 => 102497)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:18:20 UTC (rev 102496)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 01:25:29 UTC (rev 102497)
@@ -1,3 +1,34 @@
+2011-12-07  Mark Rowe  mr...@apple.com
+
+http://webkit.org/b/74061 WebProcess and PluginProcess should inherit environment
+variables provided in LC_DYLD_ENVIRONMENT of main executable binary.
+
+Reviewed by Darin Adler.
+
+* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: Added.
+* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: Added.
+(WebKit::DynamicLinkerEnvironmentExtractor::DynamicLinkerEnvironmentExtractor):
+(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable): Parse out the name
+and value from the environment string and add an entry to our variable map if the variable
+is one that dyld would respect in LC_DYLD_ENVIRONMENT.
+(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommand): Look for a LC_DYLD_ENVIRONMENT
+load command and extract any environment string that we find within.
+(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommands): Iterate over each
+load command in the Mach-O file.
+(WebKit::DynamicLinkerEnvironmentExtractor::processSingleArchitecture): Determine whether
+the Mach-O file is of the correct architecture, and if so then process the load commands
+found within.
+(WebKit::DynamicLinkerEnvironmentExtractor::processFatFile): Process each architecture of the
+Mach-O file in turn.
+(WebKit::DynamicLinkerEnvironmentExtractor::getExtractedEnvironmentVariables): Add our
+extracted variables to the passed-in EnvironmentVariables object. We skip adding any
+variables that already exist so as to allow variables passed in the environment to override
+those that we extract from the executable file.
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::ProcessLauncher::launchProcess): Extract the environment variables from the
+main binary and add them to the launch environment of our subprocess.
+* WebKit2.xcodeproj/project.pbxproj:
+
 2011-12-09  Sam Weinig  s...@webkit.org
 
 Add WKView implementation for quickLookPreviewItemsAtWindowLocation.


Added: trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h (0 => 102497)

--- trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h	2011-12-10 

[webkit-changes] [102498] trunk

[timothy_horton]

Title: [102498] trunk








Revision 102498
Author timothy_hor...@apple.com
Date 2011-12-09 17:26:36 -0800 (Fri, 09 Dec 2011)


Log Message
background-image transitions trigger between equivalent images
https://bugs.webkit.org/show_bug.cgi?id=74229
rdar://problem/10558627

Reviewed by Darin Adler.
Patch by Simon Fraser.

For animation property wrappers around StyleImage properties,
test the equivalence of the image itself, instead of equality of
the StyleImage pointer.

Test: transitions/equivalent-background-image-no-transition.html

* page/animation/AnimationBase.cpp:
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::StyleImagePropertyWrapper::equals):
(WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
(WebCore::FillLayerStyleImagePropertyWrapper::equals):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):

Add a test ensuring that background-images aren't needlessly transitioned
when they are equivalent.

* transitions/equivalent-background-image-no-transition-expected.txt: Added.
* transitions/equivalent-background-image-no-transition.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/AnimationBase.cpp


Added Paths

trunk/LayoutTests/transitions/equivalent-background-image-no-transition-expected.txt
trunk/LayoutTests/transitions/equivalent-background-image-no-transition.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102497 => 102498)

--- trunk/LayoutTests/ChangeLog	2011-12-10 01:25:29 UTC (rev 102497)
+++ trunk/LayoutTests/ChangeLog	2011-12-10 01:26:36 UTC (rev 102498)
@@ -1,3 +1,17 @@
+2011-12-09  Tim Horton  timothy_hor...@apple.com
+
+background-image transitions trigger between equivalent images
+https://bugs.webkit.org/show_bug.cgi?id=74229
+rdar://problem/10558627
+
+Reviewed by Darin Adler.
+
+Add a test ensuring that background-images aren't needlessly transitioned
+when they are equivalent.
+
+* transitions/equivalent-background-image-no-transition-expected.txt: Added.
+* transitions/equivalent-background-image-no-transition.html: Added.
+
 2011-12-09  Tony Chang  t...@chromium.org
 
 Fix test expectations from r102486: flex-flow returns direction and wrap now.


Added: trunk/LayoutTests/transitions/equivalent-background-image-no-transition-expected.txt (0 => 102498)

--- trunk/LayoutTests/transitions/equivalent-background-image-no-transition-expected.txt	(rev 0)
+++ trunk/LayoutTests/transitions/equivalent-background-image-no-transition-expected.txt	2011-12-10 01:26:36 UTC (rev 102498)
@@ -0,0 +1,2 @@
+This should not fire a background-image transition.
+PASS: no background-image transition


Added: trunk/LayoutTests/transitions/equivalent-background-image-no-transition.html (0 => 102498)

--- trunk/LayoutTests/transitions/equivalent-background-image-no-transition.html	(rev 0)
+++ trunk/LayoutTests/transitions/equivalent-background-image-no-transition.html	2011-12-10 01:26:36 UTC (rev 102498)
@@ -0,0 +1,50 @@
+html
+head
+style
+#foo {
+-webkit-transition: all 0.05s linear, top 0.1s linear;
+position: absolute;
+top: 30px;
+left: 10px;
+width: 300px;
+height: 300px;
+background-image: -webkit-linear-gradient(red, green, blue);
+}
+#foo.trans {
+top: 40px;
+}
+/style
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+/script
+/head
+body
+div id=fooThis should not fire a background-image transition./div
+
+script type=text/_javascript_ charset=utf-8
+
+var finished = false;
+
+document.getElementById('foo').addEventListener('webkitTransitionEnd', function(evt) {
+if(evt.propertyName == background-image  !finished) {
+document.getElementById('result').innerHTML = (FAIL: saw a background-image transition);
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+finished = true;
+} else if(evt.propertyName == top  !finished) {
+document.getElementById('result').innerHTML = (PASS: no background-image transition);
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+});
+
+document.getElementById(foo).className=trans;
+/script
+
+div id=result
+/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (102497 => 102498)

--- trunk/Source/WebCore/ChangeLog	2011-12-10 01:25:29 UTC (rev 102497)
+++ trunk/Source/WebCore/ChangeLog	2011-12-10 01:26:36 UTC (rev 102498)
@@ -1,3 +1,26 @@
+2011-12-09  Tim Horton  timothy_hor...@apple.com
+
+background-image transitions trigger between equivalent images
+ 

[webkit-changes] [102499] trunk/Source/WebKit2

[commit-queue]

Title: [102499] trunk/Source/WebKit2








Revision 102499
Author commit-qu...@webkit.org
Date 2011-12-09 17:28:28 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt][WK2] Unskip API tests
https://bugs.webkit.org/show_bug.cgi?id=74180

Patch by Jesus Sanchez-Palencia jesus.palen...@openbossa.org on 2011-12-09
Reviewed by Tor Arne Vestbø.

Unskip API tests for geolocation and _javascript_ dialogs.

* UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102498 => 102499)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:26:36 UTC (rev 102498)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 01:28:28 UTC (rev 102499)
@@ -1,3 +1,15 @@
+2011-12-09  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
+
+[Qt][WK2] Unskip API tests
+https://bugs.webkit.org/show_bug.cgi?id=74180
+
+Reviewed by Tor Arne Vestbø.
+
+Unskip API tests for geolocation and _javascript_ dialogs.
+
+* UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
+* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
+
 2011-12-07  Mark Rowe  mr...@apple.com
 
 http://webkit.org/b/74061 WebProcess and PluginProcess should inherit environment


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml (102498 => 102499)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml	2011-12-10 01:26:36 UTC (rev 102498)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml	2011-12-10 01:28:28 UTC (rev 102499)
@@ -45,7 +45,6 @@
 }
 
 function test_permissionRequest() {
-skip(Waiting for qtlocation being included in the bot)
 compare(spy.count, 0)
 webView.load(Qt.resolvedUrl(../common/geolocation.html))
 spy.wait()


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml (102498 => 102499)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml	2011-12-10 01:26:36 UTC (rev 102498)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml	2011-12-10 01:28:28 UTC (rev 102499)
@@ -81,7 +81,6 @@
 }
 
 function test_alertWithoutDialog() {
-skip(Setting experimental properties from JS code isn't working)
 webView.experimental.alertDialog = null
 webView.load(Qt.resolvedUrl(../common/alert.html))
 loadSpy.wait()
@@ -98,7 +97,6 @@
 }
 
 function test_confirmWithoutDialog() {
-skip(Setting experimental properties from JS code isn't working)
 webView.experimental.confirmDialog = null
 webView.load(Qt.resolvedUrl(../common/confirm.html))
 loadSpy.wait()
@@ -116,7 +114,6 @@
 }
 
 function test_promptWithoutDialog() {
-skip(Setting experimental properties from JS code isn't working)
 webView.experimental.promptDialog = null
 webView.load(Qt.resolvedUrl(../common/prompt.html))
 loadSpy.wait()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102500] trunk/Source/WebKit/chromium

[jamesr]

Title: [102500] trunk/Source/WebKit/chromium








Revision 102500
Author jam...@google.com
Date 2011-12-09 17:31:15 -0800 (Fri, 09 Dec 2011)


Log Message
[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729

Reviewed by Adam Barth.

These are no longer necessary.

* WebKit.gyp:
* public/WebContentLayer.h: Removed.
* public/WebContentLayerClient.h: Removed.
* public/WebExternalTextureLayer.h: Removed.
* public/WebLayer.h: Removed.
* public/WebLayerClient.h: Removed.
* public/WebLayerTreeView.h: Removed.
* public/WebLayerTreeViewClient.h: Removed.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Removed Paths

trunk/Source/WebKit/chromium/public/WebContentLayer.h
trunk/Source/WebKit/chromium/public/WebContentLayerClient.h
trunk/Source/WebKit/chromium/public/WebExternalTextureLayer.h
trunk/Source/WebKit/chromium/public/WebLayer.h
trunk/Source/WebKit/chromium/public/WebLayerClient.h
trunk/Source/WebKit/chromium/public/WebLayerTreeView.h
trunk/Source/WebKit/chromium/public/WebLayerTreeViewClient.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102499 => 102500)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 01:28:28 UTC (rev 102499)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-10 01:31:15 UTC (rev 102500)
@@ -1,3 +1,21 @@
+2011-12-09  James Robinson  jam...@chromium.org
+
+[chromium] Remove forwarding headers for WebLayer APIs
+https://bugs.webkit.org/show_bug.cgi?id=73729
+
+Reviewed by Adam Barth.
+
+These are no longer necessary.
+
+* WebKit.gyp:
+* public/WebContentLayer.h: Removed.
+* public/WebContentLayerClient.h: Removed.
+* public/WebExternalTextureLayer.h: Removed.
+* public/WebLayer.h: Removed.
+* public/WebLayerClient.h: Removed.
+* public/WebLayerTreeView.h: Removed.
+* public/WebLayerTreeViewClient.h: Removed.
+
 2011-12-09  Karl Koscher  super...@chromium.org
 
 [chromium] add accessors to WebDOMMessageEvent


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (102499 => 102500)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-10 01:28:28 UTC (rev 102499)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-10 01:31:15 UTC (rev 102500)
@@ -113,8 +113,6 @@
 'public/WebCompositorInputHandler.h',
 'public/WebCompositorInputHandlerClient.h',
 'public/WebConsoleMessage.h',
-'public/WebContentLayer.h',
-'public/WebContentLayerClient.h',
 'public/WebContextMenuData.h',
 'public/WebCrossOriginPreflightResultCache.h',
 'public/WebCursorInfo.h',
@@ -142,7 +140,6 @@
 'public/WebExceptionCode.h',
 'public/WebExternalPopupMenu.h',
 'public/WebExternalPopupMenuClient.h',
-'public/WebExternalTextureLayer.h',
 'public/WebFileChooserCompletion.h',
 'public/WebFileChooserParams.h',
 'public/WebFileError.h',
@@ -191,10 +188,6 @@
 'public/WebIntentServiceInfo.h',
 'public/WebKit.h',
 'public/WebLabelElement.h',
-'public/WebLayer.h',
-'public/WebLayerClient.h',
-'public/WebLayerTreeView.h',
-'public/WebLayerTreeViewClient.h',
 'public/WebMediaElement.h',
 'public/WebMediaPlayer.h',
 'public/WebMediaPlayerAction.h',


Deleted: trunk/Source/WebKit/chromium/public/WebContentLayer.h (102499 => 102500)

--- trunk/Source/WebKit/chromium/public/WebContentLayer.h	2011-12-10 01:28:28 UTC (rev 102499)
+++ trunk/Source/WebKit/chromium/public/WebContentLayer.h	2011-12-10 01:31:15 UTC (rev 102500)
@@ -1,26 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1.  Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2.  Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 

[webkit-changes] [102501] trunk

[commit-queue]

Title: [102501] trunk








Revision 102501
Author commit-qu...@webkit.org
Date 2011-12-09 17:39:11 -0800 (Fri, 09 Dec 2011)


Log Message
[FileSystem API] Entry.remove successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69639

Patch by Mark Pilgrim pilg...@chromium.org on 2011-12-09
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/filesystem/simple-required-arguments-remove.html

* fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter

LayoutTests:

* fast/filesystem/resources/simple-required-arguments-remove.js: Added.
(errorCallback):
(successCallback):
* fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
* fast/filesystem/simple-required-arguments-remove.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/Entry.idl


Added Paths

trunk/LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js
trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove-expected.txt
trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102500 => 102501)

--- trunk/LayoutTests/ChangeLog	2011-12-10 01:31:15 UTC (rev 102500)
+++ trunk/LayoutTests/ChangeLog	2011-12-10 01:39:11 UTC (rev 102501)
@@ -1,3 +1,16 @@
+2011-12-09  Mark Pilgrim  pilg...@chromium.org
+
+[FileSystem API] Entry.remove successCallback is required
+https://bugs.webkit.org/show_bug.cgi?id=69639
+
+Reviewed by Adam Barth.
+
+* fast/filesystem/resources/simple-required-arguments-remove.js: Added.
+(errorCallback):
+(successCallback):
+* fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
+* fast/filesystem/simple-required-arguments-remove.html: Added.
+
 2011-12-09  Tim Horton  timothy_hor...@apple.com
 
 background-image transitions trigger between equivalent images


Added: trunk/LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js (0 => 102501)

--- trunk/LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js	(rev 0)
+++ trunk/LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js	2011-12-10 01:39:11 UTC (rev 102501)
@@ -0,0 +1,25 @@
+if (this.importScripts) {
+importScripts('../resources/fs-worker-common.js');
+importScripts('../resources/fs-test-util.js');
+}
+
+description(Entry.remove() required arguments test.);
+
+var fileSystem = null;
+
+function errorCallback(error) {
+debug(Error occured while requesting a TEMPORARY file system: + error.code);
+finishJSTest();
+}
+
+function successCallback(fs) {
+fileSystem = fs;
+debug(Successfully obtained TEMPORARY FileSystem: + fileSystem.name);
+root = evalAndLog(root = fileSystem.root);
+shouldThrow(root.remove());
+finishJSTest();
+}
+
+var jsTestIsAsync = true;
+evalAndLog(webkitRequestFileSystem(TEMPORARY, 100, successCallback, errorCallback););
+var successfullyParsed = true;


Added: trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove-expected.txt (0 => 102501)

--- trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove-expected.txt	2011-12-10 01:39:11 UTC (rev 102501)
@@ -0,0 +1,13 @@
+Entry.remove() required arguments test.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+webkitRequestFileSystem(TEMPORARY, 100, successCallback, errorCallback);
+Successfully obtained TEMPORARY FileSystem:file__0:Temporary
+root = fileSystem.root
+PASS root.remove() threw exception TypeError: Not enough arguments.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove.html (0 => 102501)

--- trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove.html	(rev 0)
+++ trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove.html	2011-12-10 01:39:11 UTC (rev 102501)
@@ -0,0 +1,12 @@
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script src=""
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (102500 => 102501)

--- trunk/Source/WebCore/ChangeLog	2011-12-10 01:31:15 UTC (rev 102500)
+++ trunk/Source/WebCore/ChangeLog	2011-12-10 01:39:11 UTC (rev 102501)
@@ -1,3 +1,14 @@
+2011-12-09  Mark Pilgrim  pilg...@chromium.org
+
+[FileSystem API] Entry.remove successCallback is required
+https://bugs.webkit.org/show_bug.cgi?id=69639
+
+Reviewed by Adam Barth.
+
+Test: fast/filesystem/simple-required-arguments-remove.html
+
+* fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter
+
 2011-12-09  Tim Horton  timothy_hor...@apple.com
 
 

[webkit-changes] [102502] trunk

[commit-queue]

Title: [102502] trunk








Revision 102502
Author commit-qu...@webkit.org
Date 2011-12-09 17:41:36 -0800 (Fri, 09 Dec 2011)


Log Message
[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
https://bugs.webkit.org/show_bug.cgi?id=73826

Patch by Jesus Sanchez-Palencia jesus.palen...@openbossa.org on 2011-12-09
Reviewed by Tor Arne Vestbø.

.:

* Source/qtwebkit-export.map: Adding QWebNavigationRequest

Source/WebKit/qt:

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes): Registering QWebNavigationRequest

Source/WebKit2:

Adding QWebNavigationRequest by moving NavigationRequest out of QtWebPagePolicyClient.

* Target.pri:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebnavigationrequest.cpp: Added.
(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate::~QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::~QWebNavigationRequest):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::url):
(QWebNavigationRequest::button):
(QWebNavigationRequest::modifiers):
(QWebNavigationRequest::action):
* UIProcess/API/qt/qwebnavigationrequest_p.h: Added.
* UIProcess/qt/QtWebPagePolicyClient.cpp:
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(QtWebPagePolicyClient::decidePolicyForResponse):

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/declarative/plugin.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp
trunk/Source/qtwebkit-export.map


Added Paths

trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationrequest.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationrequest_p.h




Diff

Modified: trunk/ChangeLog (102501 => 102502)

--- trunk/ChangeLog	2011-12-10 01:39:11 UTC (rev 102501)
+++ trunk/ChangeLog	2011-12-10 01:41:36 UTC (rev 102502)
@@ -1,3 +1,12 @@
+2011-12-09  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
+
+[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
+https://bugs.webkit.org/show_bug.cgi?id=73826
+
+Reviewed by Tor Arne Vestbø.
+
+* Source/qtwebkit-export.map: Adding QWebNavigationRequest
+
 2011-12-09  Joone Hur  joone@collabora.co.uk
 
 [GTK] Initial implementation of Accelerated Compositing using Clutter


Modified: trunk/Source/WebKit/qt/ChangeLog (102501 => 102502)

--- trunk/Source/WebKit/qt/ChangeLog	2011-12-10 01:39:11 UTC (rev 102501)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-12-10 01:41:36 UTC (rev 102502)
@@ -1,3 +1,13 @@
+2011-12-09  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
+
+[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
+https://bugs.webkit.org/show_bug.cgi?id=73826
+
+Reviewed by Tor Arne Vestbø.
+
+* declarative/plugin.cpp:
+(WebKitQmlPlugin::registerTypes): Registering QWebNavigationRequest
+
 2011-12-08  Pierre Rossi  pierre.ro...@gmail.com
 
 Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.


Modified: trunk/Source/WebKit/qt/declarative/plugin.cpp (102501 => 102502)

--- trunk/Source/WebKit/qt/declarative/plugin.cpp	2011-12-10 01:39:11 UTC (rev 102501)
+++ trunk/Source/WebKit/qt/declarative/plugin.cpp	2011-12-10 01:41:36 UTC (rev 102502)
@@ -25,6 +25,7 @@
 #if defined(HAVE_WEBKIT2)
 #include qquickwebpage_p.h
 #include qquickwebview_p.h
+#include qwebnavigationrequest_p.h
 #include qwebpermissionrequest_p.h
 #include qwebpreferences_p.h
 
@@ -53,6 +54,7 @@
 qmlRegisterUncreatableTypeQQuickWebPage(uri, 3, 0, WebPage, QObject::tr(Cannot create separate instance of WebPage, use WebView));
 qmlRegisterUncreatableTypeQNetworkReply(uri, 3, 0, NetworkReply, QObject::tr(Cannot create separate instance of NetworkReply));
 qmlRegisterUncreatableTypeQWebPermissionRequest(uri, 3, 0, PermissionRequest, QObject::tr(Cannot create separate instance of PermissionRequest));
+qmlRegisterUncreatableTypeQWebNavigationRequest(uri, 3, 0, NavigationRequest, QObject::tr(Cannot create separate instance of NavigationRequest));
 #endif
 }
 };


Modified: trunk/Source/WebKit2/ChangeLog (102501 => 102502)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:39:11 UTC (rev 102501)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 01:41:36 UTC (rev 102502)
@@ -1,5 +1,31 @@
 2011-12-09  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
 
+[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
+https://bugs.webkit.org/show_bug.cgi?id=73826
+
+Reviewed by Tor Arne Vestbø.
+
+Adding QWebNavigationRequest by moving NavigationRequest out of QtWebPagePolicyClient.
+
+* Target.pri:
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/qwebnavigationrequest.cpp: 

[webkit-changes] [102503] trunk/Source/WebCore

[andersca]

Title: [102503] trunk/Source/WebCore








Revision 102503
Author ander...@apple.com
Date 2011-12-09 17:44:06 -0800 (Fri, 09 Dec 2011)


Log Message
Fix Lion release build.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102502 => 102503)

--- trunk/Source/WebCore/ChangeLog	2011-12-10 01:41:36 UTC (rev 102502)
+++ trunk/Source/WebCore/ChangeLog	2011-12-10 01:44:06 UTC (rev 102503)
@@ -1,3 +1,10 @@
+2011-12-09  Anders Carlsson  ander...@apple.com
+
+Fix Lion release build.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
+
 2011-12-09  Mark Pilgrim  pilg...@chromium.org
 
 [FileSystem API] Entry.remove successCallback is required


Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (102502 => 102503)

--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-10 01:41:36 UTC (rev 102502)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm	2011-12-10 01:44:06 UTC (rev 102503)
@@ -427,7 +427,7 @@
 if (!_scrollbar)
 return NSZeroPoint;
 
-ASSERT(scrollerImp == scrollbarPainterForScrollbar(_scrollbar));
+ASSERT_UNUSED(scrollerImp, scrollerImp == scrollbarPainterForScrollbar(_scrollbar));
 
 return _scrollbar-convertFromContainingView(_scrollbar-scrollableArea()-currentMousePosition());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102504] trunk/Source/WebKit2

[mrowe]

Title: [102504] trunk/Source/WebKit2








Revision 102504
Author mr...@apple.com
Date 2011-12-09 17:54:25 -0800 (Fri, 09 Dec 2011)


Log Message
Fix the Snow Leopard build.

Wrap some code that is only applicable to Lion and newer in the appropriate #if's.

* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h
trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm
trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102503 => 102504)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:44:06 UTC (rev 102503)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 01:54:25 UTC (rev 102504)
@@ -1,3 +1,14 @@
+2011-12-09  Mark Rowe  mr...@apple.com
+
+Fix the Snow Leopard build.
+
+Wrap some code that is only applicable to Lion and newer in the appropriate #if's.
+
+* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
+* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::ProcessLauncher::launchProcess):
+
 2011-12-09  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
 
 [Qt] request parameter of QQuickWebView::navigationRequested is not a registered type


Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h (102503 => 102504)

--- trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h	2011-12-10 01:44:06 UTC (rev 102503)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h	2011-12-10 01:54:25 UTC (rev 102504)
@@ -26,6 +26,8 @@
 #ifndef DynamicLinkerEnvironmentExtractor_h
 #define DynamicLinkerEnvironmentExtractor_h
 
+#ifndef BUILDING_ON_SNOW_LEOPARD
+
 #include mach/machine.h
 #include wtf/Noncopyable.h
 #include wtf/RetainPtr.h
@@ -59,4 +61,6 @@
 
 } // namespace WebKit
 
+#endif // BUILDING_ON_SNOW_LEOPARD
+
 #endif // DynamicLinkerEnvironmentExtractor_h


Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm (102503 => 102504)

--- trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm	2011-12-10 01:44:06 UTC (rev 102503)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm	2011-12-10 01:54:25 UTC (rev 102504)
@@ -23,6 +23,8 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+#ifndef BUILDING_ON_SNOW_LEOPARD
+
 #include config.h
 #include DynamicLinkerEnvironmentExtractor.h
 
@@ -198,3 +200,5 @@
 }
 
 } // namespace WebKit
+
+#endif // BUILDING_ON_SNOW_LEOPARD


Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm (102503 => 102504)

--- trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2011-12-10 01:44:06 UTC (rev 102503)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2011-12-10 01:54:25 UTC (rev 102504)
@@ -137,8 +137,10 @@
 
 EnvironmentVariables environmentVariables;
 
+#ifndef BUILDING_ON_SNOW_LEOPARD
 DynamicLinkerEnvironmentExtractor environmentExtractor([[NSBundle mainBundle] executablePath], architecture);
 environmentExtractor.getExtractedEnvironmentVariables(environmentVariables);
+#endif
 
 // To make engineering builds work, if the path is outside of /System set up
 // DYLD_FRAMEWORK_PATH to pick up other frameworks, but don't do it for the






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102505] trunk/Source/JavaScriptCore

[commit-queue]

Title: [102505] trunk/Source/_javascript_Core








Revision 102505
Author commit-qu...@webkit.org
Date 2011-12-09 17:57:24 -0800 (Fri, 09 Dec 2011)


Log Message
Remove unnecessary file DissasemblerARM.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=74184

Patch by Konrad Piascik kpias...@rim.com on 2011-12-09
Reviewed by Daniel Bates.

* PlatformBlackBerry.cmake:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/PlatformBlackBerry.cmake




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102504 => 102505)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-10 01:54:25 UTC (rev 102504)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-10 01:57:24 UTC (rev 102505)
@@ -1,3 +1,12 @@
+2011-12-09  Konrad Piascik  kpias...@rim.com
+
+Remove unnecessary file DissasemblerARM.cpp from build system
+https://bugs.webkit.org/show_bug.cgi?id=74184
+
+Reviewed by Daniel Bates.
+
+* PlatformBlackBerry.cmake:
+
 2011-12-09  Filip Pizlo  fpi...@apple.com
 
 DFG's interpretation of rare case profiles should be frequency-based not count-based


Modified: trunk/Source/_javascript_Core/PlatformBlackBerry.cmake (102504 => 102505)

--- trunk/Source/_javascript_Core/PlatformBlackBerry.cmake	2011-12-10 01:54:25 UTC (rev 102504)
+++ trunk/Source/_javascript_Core/PlatformBlackBerry.cmake	2011-12-10 01:57:24 UTC (rev 102505)
@@ -2,8 +2,4 @@
 ${BLACKBERRY_THIRD_PARTY_DIR}/icu
 )
 
-LIST(APPEND _javascript_Core_SOURCES
-DisassemblerARM.cpp
-)
-
 INSTALL(FILES wtf/Forward.h DESTINATION usr/include/browser/webkit/wtf)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102506] trunk/LayoutTests

[commit-queue]

Title: [102506] trunk/LayoutTests








Revision 102506
Author commit-qu...@webkit.org
Date 2011-12-09 17:59:34 -0800 (Fri, 09 Dec 2011)


Log Message
[Gtk] Unskip two passing Shadow DOM tests
https://bugs.webkit.org/show_bug.cgi?id=74186

Patch by Zan Dobersek zandober...@gmail.com on 2011-12-09
Reviewed by Martin Robinson.

Unskip two passing tests after bug #59571 was fixed.

* platform/gtk/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (102505 => 102506)

--- trunk/LayoutTests/ChangeLog	2011-12-10 01:57:24 UTC (rev 102505)
+++ trunk/LayoutTests/ChangeLog	2011-12-10 01:59:34 UTC (rev 102506)
@@ -1,3 +1,14 @@
+2011-12-09  Zan Dobersek  zandober...@gmail.com
+
+[Gtk] Unskip two passing Shadow DOM tests
+https://bugs.webkit.org/show_bug.cgi?id=74186
+
+Reviewed by Martin Robinson.
+
+Unskip two passing tests after bug #59571 was fixed.
+
+* platform/gtk/Skipped:
+
 2011-12-09  Mark Pilgrim  pilg...@chromium.org
 
 [FileSystem API] Entry.remove successCallback is required


Modified: trunk/LayoutTests/platform/gtk/Skipped (102505 => 102506)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-12-10 01:57:24 UTC (rev 102505)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-12-10 01:59:34 UTC (rev 102506)
@@ -1305,10 +1305,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=59391
 editing/text-iterator/findString.html
 
-# Unskip when https://bugs.webkit.org/show_bug.cgi?id=59571 is fixed
-fast/dom/shadow/gc-shadow.html
-fast/dom/shadow/no-renderers-for-light-children.html
-
 # Skipping newly added tests while I'm finding out what is wrong.
 # https://bugs.webkit.org/show_bug.cgi?id=59706
 http/tests/inspector/resource-tree/resource-tree-document-url.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102507] trunk/Source/WebKit2

[mrowe]

Title: [102507] trunk/Source/WebKit2








Revision 102507
Author mr...@apple.com
Date 2011-12-09 18:06:25 -0800 (Fri, 09 Dec 2011)


Log Message
Fix the Snow Leopard build some more.

Move the #if to a location where it will do some good.

* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102506 => 102507)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:59:34 UTC (rev 102506)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 02:06:25 UTC (rev 102507)
@@ -1,5 +1,13 @@
 2011-12-09  Mark Rowe  mr...@apple.com
 
+Fix the Snow Leopard build some more.
+
+Move the #if to a location where it will do some good.
+
+* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
+
+2011-12-09  Mark Rowe  mr...@apple.com
+
 Fix the Snow Leopard build.
 
 Wrap some code that is only applicable to Lion and newer in the appropriate #if's.


Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm (102506 => 102507)

--- trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm	2011-12-10 01:59:34 UTC (rev 102506)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm	2011-12-10 02:06:25 UTC (rev 102507)
@@ -23,11 +23,11 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef BUILDING_ON_SNOW_LEOPARD
-
 #include config.h
 #include DynamicLinkerEnvironmentExtractor.h
 
+#ifndef BUILDING_ON_SNOW_LEOPARD
+
 #include EnvironmentVariables.h
 #include mach-o/loader.h
 #include mach-o/swap.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102508] trunk/Source/JavaScriptCore

[levin]

Title: [102508] trunk/Source/_javascript_Core








Revision 102508
Author le...@chromium.org
Date 2011-12-09 18:13:02 -0800 (Fri, 09 Dec 2011)


Log Message
REGRESSION(r101863-r102042): Assertion hit: m_verifier.isSafeToUse() in RefCountedBase::ref in FunctionCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=73886

Reviewed by Darin Adler.

* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable): Added deprecatedTurnOffVerifier for
another _javascript_Object, since _javascript_Core objects allow use on multiple threads.
Bug 58091 is about changing these deprecated calls to something else but that something
else will still need to be in all of these places.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/SymbolTable.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102507 => 102508)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-10 02:06:25 UTC (rev 102507)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-10 02:13:02 UTC (rev 102508)
@@ -1,3 +1,16 @@
+2011-12-09  David Levin  le...@chromium.org
+
+REGRESSION(r101863-r102042): Assertion hit: m_verifier.isSafeToUse() in RefCountedBase::ref in FunctionCodeBlock
+https://bugs.webkit.org/show_bug.cgi?id=73886
+
+Reviewed by Darin Adler.
+
+* runtime/SymbolTable.h:
+(JSC::SharedSymbolTable::SharedSymbolTable): Added deprecatedTurnOffVerifier for
+another _javascript_Object, since _javascript_Core objects allow use on multiple threads.
+Bug 58091 is about changing these deprecated calls to something else but that something
+else will still need to be in all of these places.
+
 2011-12-09  Konrad Piascik  kpias...@rim.com
 
 Remove unnecessary file DissasemblerARM.cpp from build system


Modified: trunk/Source/_javascript_Core/runtime/SymbolTable.h (102507 => 102508)

--- trunk/Source/_javascript_Core/runtime/SymbolTable.h	2011-12-10 02:06:25 UTC (rev 102507)
+++ trunk/Source/_javascript_Core/runtime/SymbolTable.h	2011-12-10 02:13:02 UTC (rev 102508)
@@ -125,7 +125,7 @@
 public:
 static PassRefPtrSharedSymbolTable create() { return adoptRef(new SharedSymbolTable); }
 private:
-SharedSymbolTable() { }
+SharedSymbolTable() { deprecatedTurnOffVerifier(); }
 };
 
 } // namespace JSC






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102509] trunk

[fpizlo]

Title: [102509] trunk








Revision 102509
Author fpi...@apple.com
Date 2011-12-09 18:15:39 -0800 (Fri, 09 Dec 2011)


Log Message
DFG ArithMul power-of-two case does not check for overflow
https://bugs.webkit.org/show_bug.cgi?id=74230

Source/_javascript_Core: 

Reviewed by Gavin Barraclough.

Disabled power-of-2 peephole optimization for multiplication, because it was wrong,
and any attempt to fix it would likely introduce code bloat and register pressure.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMul):

LayoutTests: 

Reviewed by Gavin Barraclough.

* fast/js/dfg-multiply-expected.txt: Added.
* fast/js/dfg-multiply.html: Added.
* fast/js/script-tests/dfg-multiply.js: Added.
(doMultiplyConstant2):
(doMultiplyConstant3):
(doMultiplyConstant4):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp


Added Paths

trunk/LayoutTests/fast/js/dfg-multiply-expected.txt
trunk/LayoutTests/fast/js/dfg-multiply.html
trunk/LayoutTests/fast/js/script-tests/dfg-multiply.js




Diff

Modified: trunk/LayoutTests/ChangeLog (102508 => 102509)

--- trunk/LayoutTests/ChangeLog	2011-12-10 02:13:02 UTC (rev 102508)
+++ trunk/LayoutTests/ChangeLog	2011-12-10 02:15:39 UTC (rev 102509)
@@ -1,3 +1,17 @@
+2011-12-09  Filip Pizlo  fpi...@apple.com
+
+DFG ArithMul power-of-two case does not check for overflow
+https://bugs.webkit.org/show_bug.cgi?id=74230
+
+Reviewed by Gavin Barraclough.
+
+* fast/js/dfg-multiply-expected.txt: Added.
+* fast/js/dfg-multiply.html: Added.
+* fast/js/script-tests/dfg-multiply.js: Added.
+(doMultiplyConstant2):
+(doMultiplyConstant3):
+(doMultiplyConstant4):
+
 2011-12-09  Zan Dobersek  zandober...@gmail.com
 
 [Gtk] Unskip two passing Shadow DOM tests


Added: trunk/LayoutTests/fast/js/dfg-multiply-expected.txt (0 => 102509)

--- trunk/LayoutTests/fast/js/dfg-multiply-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/dfg-multiply-expected.txt	2011-12-10 02:15:39 UTC (rev 102509)
@@ -0,0 +1,1029 @@
+This tests that the DFG can multiply numbers correctly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS doMultiplyConstant4(1) is 4
+PASS doMultiplyConstant4(2) is 8
+PASS doMultiplyConstant4(4) is 16
+PASS doMultiplyConstant2(1) is 2
+PASS doMultiplyConstant2(2) is 4
+PASS doMultiplyConstant2(4) is 8
+PASS doMultiplyConstant3(1) is 3
+PASS doMultiplyConstant3(2) is 6
+PASS doMultiplyConstant3(4) is 12
+PASS 

[webkit-changes] [102510] trunk/LayoutTests

[levin]

Title: [102510] trunk/LayoutTests








Revision 102510
Author le...@chromium.org
Date 2011-12-09 18:26:41 -0800 (Fri, 09 Dec 2011)


Log Message
REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619

Reviewed by Alexey Proskuryakov.

* platform/mac/Skipped: Unskip various worker tests as they should work
now that bug 71695 is fixed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (102509 => 102510)

--- trunk/LayoutTests/ChangeLog	2011-12-10 02:15:39 UTC (rev 102509)
+++ trunk/LayoutTests/ChangeLog	2011-12-10 02:26:41 UTC (rev 102510)
@@ -1,3 +1,13 @@
+2011-12-09  David Levin  le...@chromium.org
+
+REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
+https://bugs.webkit.org/show_bug.cgi?id=70619
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac/Skipped: Unskip various worker tests as they should work
+now that bug 71695 is fixed.
+
 2011-12-09  Filip Pizlo  fpi...@apple.com
 
 DFG ArithMul power-of-two case does not check for overflow


Modified: trunk/LayoutTests/platform/mac/Skipped (102509 => 102510)

--- trunk/LayoutTests/platform/mac/Skipped	2011-12-10 02:15:39 UTC (rev 102509)
+++ trunk/LayoutTests/platform/mac/Skipped	2011-12-10 02:26:41 UTC (rev 102510)
@@ -288,15 +288,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=45575
 fast/files/workers
 
-# These worker tests are failing all the time
-# https://bugs.webkit.org/show_bug.cgi?id=70619
-fast/workers/shared-worker-lifecycle.html
-fast/workers/shared-worker-frame-lifecycle.html
-fast/workers/storage/interrupt-database.html
-fast/workers/worker-close-more.html
-fast/workers/dedicated-worker-lifecycle.html
-fast/workers/worker-lifecycle.html
-
 # viewport meta tag support
 fast/viewport
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102511] trunk

[commit-queue]

Title: [102511] trunk








Revision 102511
Author commit-qu...@webkit.org
Date 2011-12-09 18:29:51 -0800 (Fri, 09 Dec 2011)


Log Message
NameNodeListCache should be invalidated when name attribute changes/modified.
https://bugs.webkit.org/show_bug.cgi?id=70810

Patch by Arko Saha a...@motorola.com on 2011-12-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/getelementsbyname-invalidation-cache.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseMappedAttribute):
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::parseMappedAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseMappedAttribute):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::parseMappedAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::parseMappedAttribute):

LayoutTests:

* fast/dom/getelementsbyname-invalidation-cache-expected.txt: Added.
* fast/dom/getelementsbyname-invalidation-cache.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/html/HTMLAppletElement.cpp
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/html/HTMLFrameElementBase.cpp
trunk/Source/WebCore/html/HTMLIFrameElement.cpp
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLMapElement.cpp
trunk/Source/WebCore/html/HTMLMetaElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/HTMLParamElement.cpp


Added Paths

trunk/LayoutTests/fast/dom/getelementsbyname-invalidation-cache-expected.txt
trunk/LayoutTests/fast/dom/getelementsbyname-invalidation-cache.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102510 => 102511)

--- trunk/LayoutTests/ChangeLog	2011-12-10 02:26:41 UTC (rev 102510)
+++ trunk/LayoutTests/ChangeLog	2011-12-10 02:29:51 UTC (rev 102511)
@@ -1,3 +1,13 @@
+2011-12-09   Arko Saha  a...@motorola.com
+
+NameNodeListCache should be invalidated when name attribute changes/modified.
+https://bugs.webkit.org/show_bug.cgi?id=70810
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/getelementsbyname-invalidation-cache-expected.txt: Added.
+* fast/dom/getelementsbyname-invalidation-cache.html: Added.
+
 2011-12-09  David Levin  le...@chromium.org
 
 REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)


Added: trunk/LayoutTests/fast/dom/getelementsbyname-invalidation-cache-expected.txt (0 => 102511)

--- trunk/LayoutTests/fast/dom/getelementsbyname-invalidation-cache-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/getelementsbyname-invalidation-cache-expected.txt	2011-12-10 02:29:51 UTC (rev 102511)
@@ -0,0 +1,42 @@
+This test case ensures that nameNodeListCache should be invalidate when name attribute changes.
+
+PASS createTwoElements('a'); document.getElementsByName('fullname').length is 2
+PASS document.querySelector('a').setAttribute('name', 'changed-name'); document.getElementsByName('fullname').length is 1
+
+PASS createTwoElements('applet'); document.getElementsByName('fullname').length is 2
+PASS document.querySelector('applet').setAttribute('name', 'changed-name'); document.getElementsByName('fullname').length is 1
+
+PASS createTwoElements('embed'); document.getElementsByName('fullname').length is 2
+PASS document.querySelector('embed').setAttribute('name', 'changed-name'); document.getElementsByName('fullname').length is 1
+
+PASS createTwoElements('section'); document.getElementsByName('fullname').length is 2
+PASS document.querySelector('section').setAttribute('name', 'changed-name'); document.getElementsByName('fullname').length is 1
+
+PASS createTwoElements('frame'); document.getElementsByName('fullname').length is 2
+PASS document.querySelector('frame').setAttribute('name', 'changed-name'); document.getElementsByName('fullname').length is 1
+
+PASS createTwoElements('form'); document.getElementsByName('fullname').length is 2
+PASS document.querySelector('form').setAttribute('name', 'changed-name'); document.getElementsByName('fullname').length is 1
+
+PASS createTwoElements('iframe'); document.getElementsByName('fullname').length is 2
+PASS document.querySelector('iframe').setAttribute('name', 'changed-name'); 

[webkit-changes] [102512] trunk/Source/WebCore

[commit-queue]

Title: [102512] trunk/Source/WebCore








Revision 102512
Author commit-qu...@webkit.org
Date 2011-12-09 18:35:35 -0800 (Fri, 09 Dec 2011)


Log Message
[chromium] Prevent ASSERT in legitimate out-of-memory case.
https://bugs.webkit.org/show_bug.cgi?id=74215

Patch by Eric Penner epen...@google.com on 2011-12-09
Reviewed by James Robinson.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102511 => 102512)

--- trunk/Source/WebCore/ChangeLog	2011-12-10 02:29:51 UTC (rev 102511)
+++ trunk/Source/WebCore/ChangeLog	2011-12-10 02:35:35 UTC (rev 102512)
@@ -1,3 +1,13 @@
+2011-12-09  Eric Penner  epen...@google.com
+
+[chromium] Prevent ASSERT in legitimate out-of-memory case.
+https://bugs.webkit.org/show_bug.cgi?id=74215
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::updateCompositorResources):
+
 2011-12-09   Arko Saha  a...@motorola.com
 
 NameNodeListCache should be invalidated when name attribute changes/modified.


Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (102511 => 102512)

--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp	2011-12-10 02:29:51 UTC (rev 102511)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp	2011-12-10 02:35:35 UTC (rev 102512)
@@ -176,7 +176,7 @@
 {
 // If this assert is hit, it means that paintContentsIfDirty hasn't been
 // called on this layer. Any layer that is updated should be painted first.
-ASSERT(m_tiler);
+ASSERT(m_skipsDraw || m_tiler);
 
 // Painting could cause compositing to get turned off, which may cause the tiler to become invalidated mid-update.
 if (m_skipsDraw || m_requestedUpdateRect.isEmpty() || !m_tiler || !m_tiler-numTiles())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102513] branches/safari-534.53-branch/Source/WebKit2

[lforschler]

Title: [102513] branches/safari-534.53-branch/Source/WebKit2








Revision 102513
Author lforsch...@apple.com
Date 2011-12-09 18:42:06 -0800 (Fri, 09 Dec 2011)


Log Message
Merge 98588.

Modified Paths

branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h




Diff

Modified: branches/safari-534.53-branch/Source/WebKit2/ChangeLog (102512 => 102513)

--- branches/safari-534.53-branch/Source/WebKit2/ChangeLog	2011-12-10 02:35:35 UTC (rev 102512)
+++ branches/safari-534.53-branch/Source/WebKit2/ChangeLog	2011-12-10 02:42:06 UTC (rev 102513)
@@ -1,3 +1,27 @@
+2011-12-09  Lucas Forschler  lforsch...@apple.com
+
+Merge 98588
+
+2011-10-27  Adam Roben  aro...@apple.com
+
+Add WKBundlePageGetBackingScaleFactor
+
+Fixes http://webkit.org/b/71025 rdar://problem/10355037 REGRESSION (r97191): Clients
+can't reliably determine the scale factor of snapshots returned via
+WKBundlePageCreateSnapshot* API
+
+Reviewed by Sam Weinig.
+
+* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+(WKBundlePageGetBackingScaleFactor):
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+Added. Calls through to WebPage::deviceScaleFactor.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::deviceScaleFactor):
+* WebProcess/WebPage/WebPage.h:
+Added. Calls through to Page::deviceScaleFactor.
+
 2011-12-08  Lucas Forschler  lforsch...@apple.com
 
 Merge 101719


Modified: branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (102512 => 102513)

--- branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp	2011-12-10 02:35:35 UTC (rev 102512)
+++ branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp	2011-12-10 02:42:06 UTC (rev 102513)
@@ -255,6 +255,11 @@
 return toAPI(webImage.release().leakRef());
 }
 
+double WKBundlePageGetBackingScaleFactor(WKBundlePageRef pageRef)
+{
+return toImpl(pageRef)-deviceScaleFactor();
+}
+
 #if defined(ENABLE_INSPECTOR)  ENABLE_INSPECTOR
 WKBundleInspectorRef WKBundlePageGetInspector(WKBundlePageRef pageRef)
 {


Modified: branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h (102512 => 102513)

--- branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h	2011-12-10 02:35:35 UTC (rev 102512)
+++ branches/safari-534.53-branch/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h	2011-12-10 02:42:06 UTC (rev 102513)
@@ -320,6 +320,8 @@
 WK_EXPORT WKImageRef WKBundlePageCreateSnapshotInDocumentCoordinates(WKBundlePageRef page, WKRect rect, WKImageOptions options);
 WK_EXPORT WKImageRef WKBundlePageCreateScaledSnapshotInDocumentCoordinates(WKBundlePageRef page, WKRect rect, double scaleFactor, WKImageOptions options);
 
+WK_EXPORT double WKBundlePageGetBackingScaleFactor(WKBundlePageRef page);
+
 #if defined(ENABLE_INSPECTOR)  ENABLE_INSPECTOR
 WK_EXPORT WKBundleInspectorRef WKBundlePageGetInspector(WKBundlePageRef page);
 #endif


Modified: branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (102512 => 102513)

--- branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-12-10 02:35:35 UTC (rev 102512)
+++ branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-12-10 02:42:06 UTC (rev 102513)
@@ -803,6 +803,11 @@
 }
 }
 
+float WebPage::deviceScaleFactor() const
+{
+return m_page-deviceScaleFactor();
+}
+
 void WebPage::setUseFixedLayout(bool fixed)
 {
 Frame* frame = m_mainFrame-coreFrame();


Modified: branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h (102512 => 102513)

--- branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h	2011-12-10 02:35:35 UTC (rev 102512)
+++ branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h	2011-12-10 02:42:06 UTC (rev 102513)
@@ -400,6 +400,7 @@
 void runModal();
 
 void setDeviceScaleFactor(float);
+float deviceScaleFactor() const;
 
 void setMemoryCacheMessagesEnabled(bool);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102515] trunk/Source/WebCore

[commit-queue]

Title: [102515] trunk/Source/WebCore








Revision 102515
Author commit-qu...@webkit.org
Date 2011-12-09 19:03:29 -0800 (Fri, 09 Dec 2011)


Log Message
Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74197

The bufferedData() was removed in r95120.

Patch by Jacky Jiang zhaji...@rim.com on 2011-12-09
Reviewed by Rob Buis.

Trivial fix, so no new tests.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102514 => 102515)

--- trunk/Source/WebCore/ChangeLog	2011-12-10 02:46:12 UTC (rev 102514)
+++ trunk/Source/WebCore/ChangeLog	2011-12-10 03:03:29 UTC (rev 102515)
@@ -1,3 +1,16 @@
+2011-12-09  Jacky Jiang  zhaji...@rim.com
+
+Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp
+https://bugs.webkit.org/show_bug.cgi?id=74197
+
+The bufferedData() was removed in r95120.
+
+Reviewed by Rob Buis.
+
+Trivial fix, so no new tests.
+
+* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
+
 2011-12-09  Eric Penner  epen...@google.com
 
 [chromium] Prevent ASSERT in legitimate out-of-memory case.


Modified: trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp (102514 => 102515)

--- trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp	2011-12-10 02:46:12 UTC (rev 102514)
+++ trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp	2011-12-10 03:03:29 UTC (rev 102515)
@@ -119,12 +119,6 @@
 return NetworkManager::instance()-startJob(playerId, this, *frame, d-m_defersLoading);
 }
 
-bool ResourceHandle::supportsBufferedData()
-{
-notImplemented();
-return false;
-}
-
 void ResourceHandle::pauseLoad(bool pause)
 {
 if (NetworkManager::instance())
@@ -187,10 +181,4 @@
 response = syncLoader.resourceResponse();
 }
 
-PassRefPtrSharedBuffer ResourceHandle::bufferedData()
-{
-notImplemented();
-return 0;
-}
-
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102516] tags/Safari-534.53.8/

[lforschler]

Title: [102516] tags/Safari-534.53.8/








Revision 102516
Author lforsch...@apple.com
Date 2011-12-09 21:18:40 -0800 (Fri, 09 Dec 2011)


Log Message
New tag.

Added Paths

tags/Safari-534.53.8/




Diff

Property changes: tags/Safari-534.53.8



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102517] trunk/Source/WebCore

[benjamin]

Title: [102517] trunk/Source/WebCore








Revision 102517
Author benja...@webkit.org
Date 2011-12-09 21:34:02 -0800 (Fri, 09 Dec 2011)


Log Message
Add the FileSystem functions of iOS
https://bugs.webkit.org/show_bug.cgi?id=74164

Patch by Benjamin Poulain bpoul...@apple.com on 2011-12-09
Reviewed by David Kilzer.

Two functions are needed on iOS for temporary files and directories.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/FileSystemIOS.h: Added.
* platform/ios/FileSystemIOS.mm: Added.
(WebCore::createTemporaryDirectory):
(WebCore::createTemporaryFile):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/platform/ios/FileSystemIOS.h
trunk/Source/WebCore/platform/ios/FileSystemIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102516 => 102517)

--- trunk/Source/WebCore/ChangeLog	2011-12-10 05:18:40 UTC (rev 102516)
+++ trunk/Source/WebCore/ChangeLog	2011-12-10 05:34:02 UTC (rev 102517)
@@ -1,3 +1,19 @@
+2011-12-09  Benjamin Poulain  bpoul...@apple.com
+
+Add the FileSystem functions of iOS
+https://bugs.webkit.org/show_bug.cgi?id=74164
+
+Reviewed by David Kilzer.
+
+Two functions are needed on iOS for temporary files and directories.
+
+* WebCore.exp.in:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/ios/FileSystemIOS.h: Added.
+* platform/ios/FileSystemIOS.mm: Added.
+(WebCore::createTemporaryDirectory):
+(WebCore::createTemporaryFile):
+
 2011-12-09  Jacky Jiang  zhaji...@rim.com
 
 Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp


Modified: trunk/Source/WebCore/WebCore.exp.in (102516 => 102517)

--- trunk/Source/WebCore/WebCore.exp.in	2011-12-10 05:18:40 UTC (rev 102516)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-12-10 05:34:02 UTC (rev 102517)
@@ -1560,6 +1560,10 @@
 _wkGetMacOSXVersionString
 #endif
 
+#if PLATFORM(IOS)
+__ZN7WebCore24createTemporaryDirectoryEP8NSString
+#endif
+
 _wkUnregisterUniqueIdForElement
 _wkAccessibilityHandleFocusChanged
 _wkGetAXTextMarkerTypeID


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (102516 => 102517)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-10 05:18:40 UTC (rev 102516)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-10 05:34:02 UTC (rev 102517)
@@ -680,6 +680,8 @@
 		265541391489811C000DFC5D /* KeyEventCodesIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = 265541371489811C000DFC5D /* KeyEventCodesIOS.h */; };
 		2655413A1489811C000DFC5D /* KeyEventIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 265541381489811C000DFC5D /* KeyEventIOS.mm */; };
 		265541521489B233000DFC5D /* CursorIOS.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2655414B1489AA2B000DFC5D /* CursorIOS.cpp */; };
+		26C17A3E1491D2D400D12BA2 /* FileSystemIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = 26C17A3C1491D2D400D12BA2 /* FileSystemIOS.h */; };
+		26C17A3F1491D2D400D12BA2 /* FileSystemIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 26C17A3D1491D2D400D12BA2 /* FileSystemIOS.mm */; };
 		26E98A10130A9FCA008EB7B2 /* TextCodecASCIIFastPath.h in Headers */ = {isa = PBXBuildFile; fileRef = 26E98A0F130A9FCA008EB7B2 /* TextCodecASCIIFastPath.h */; };
 		26F40D4A14904A6300CA67C4 /* EventLoopIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 26F40D4914904A6300CA67C4 /* EventLoopIOS.mm */; };
 		2917B5611473496C0052C9D0 /* LayerFlushScheduler.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2917B55E1473496C0052C9D0 /* LayerFlushScheduler.cpp */; };
@@ -7791,6 +7793,8 @@
 		265541371489811C000DFC5D /* KeyEventCodesIOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = KeyEventCodesIOS.h; path = ios/KeyEventCodesIOS.h; sourceTree = group; };
 		265541381489811C000DFC5D /* KeyEventIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = KeyEventIOS.mm; path = ios/KeyEventIOS.mm; sourceTree = group; };
 		2655414B1489AA2B000DFC5D /* CursorIOS.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = CursorIOS.cpp; path = ios/CursorIOS.cpp; sourceTree = group; };
+		26C17A3C1491D2D400D12BA2 /* FileSystemIOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FileSystemIOS.h; path = ios/FileSystemIOS.h; sourceTree = group; };
+		26C17A3D1491D2D400D12BA2 /* FileSystemIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = FileSystemIOS.mm; path = ios/FileSystemIOS.mm; sourceTree = group; };
 		26E98A0F130A9FCA008EB7B2 /* TextCodecASCIIFastPath.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextCodecASCIIFastPath.h; sourceTree = group; };
 		26F40D4914904A6300CA67C4 /* 

[webkit-changes] [102518] branches/safari-534.53-branch/Source

[lforschler]

Title: [102518] branches/safari-534.53-branch/Source








Revision 102518
Author lforsch...@apple.com
Date 2011-12-09 21:47:05 -0800 (Fri, 09 Dec 2011)


Log Message
Versioning.

Modified Paths

branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig (102517 => 102518)

--- branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-12-10 05:34:02 UTC (rev 102517)
+++ branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-12-10 05:47:05 UTC (rev 102518)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (102517 => 102518)

--- branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-12-10 05:34:02 UTC (rev 102517)
+++ branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-12-10 05:47:05 UTC (rev 102518)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig (102517 => 102518)

--- branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig	2011-12-10 05:34:02 UTC (rev 102517)
+++ branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig	2011-12-10 05:47:05 UTC (rev 102518)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig (102517 => 102518)

--- branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-12-10 05:34:02 UTC (rev 102517)
+++ branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-12-10 05:47:05 UTC (rev 102518)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig (102517 => 102518)

--- branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-12-10 05:34:02 UTC (rev 102517)
+++ branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-12-10 05:47:05 UTC (rev 102518)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes