[webkit-changes] [103144] trunk/Source/JavaScriptCore
Title: [103144] trunk/Source/_javascript_Core
Revision 103144
Author benja...@webkit.org
Date 2011-12-16 22:35:29 -0800 (Fri, 16 Dec 2011)
Log Message
Remove the duplicated code from ASCIICType.h
https://bugs.webkit.org/show_bug.cgi?id=74771
Patch by Benjamin Poulain on 2011-12-16
Reviewed by Andreas Kling.
The functions were sharing similar code and were defined for the various input types.
Use templates instead to avoid code duplication.
* wtf/ASCIICType.h:
(WTF::isASCII):
(WTF::isASCIIAlpha):
(WTF::isASCIIAlphanumeric):
(WTF::isASCIIDigit):
(WTF::isASCIIHexDigit):
(WTF::isASCIILower):
(WTF::isASCIIOctalDigit):
(WTF::isASCIIPrintable):
(WTF::isASCIISpace):
(WTF::isASCIIUpper):
(WTF::toASCIILower):
(WTF::toASCIIUpper):
(WTF::toASCIIHexValue):
(WTF::lowerNibbleToASCIIHexDigit):
(WTF::upperNibbleToASCIIHexDigit):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/ASCIICType.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (103143 => 103144)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-17 05:53:42 UTC (rev 103143)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-17 06:35:29 UTC (rev 103144)
@@ -1,3 +1,30 @@
+2011-12-16 Benjamin Poulain
+
+Remove the duplicated code from ASCIICType.h
+https://bugs.webkit.org/show_bug.cgi?id=74771
+
+Reviewed by Andreas Kling.
+
+The functions were sharing similar code and were defined for the various input types.
+Use templates instead to avoid code duplication.
+
+* wtf/ASCIICType.h:
+(WTF::isASCII):
+(WTF::isASCIIAlpha):
+(WTF::isASCIIAlphanumeric):
+(WTF::isASCIIDigit):
+(WTF::isASCIIHexDigit):
+(WTF::isASCIILower):
+(WTF::isASCIIOctalDigit):
+(WTF::isASCIIPrintable):
+(WTF::isASCIISpace):
+(WTF::isASCIIUpper):
+(WTF::toASCIILower):
+(WTF::toASCIIUpper):
+(WTF::toASCIIHexValue):
+(WTF::lowerNibbleToASCIIHexDigit):
+(WTF::upperNibbleToASCIIHexDigit):
+
2011-12-16 Gavin Barraclough
Reverted r103120, this breaks v8 on ARMv7 DFG.
Modified: trunk/Source/_javascript_Core/wtf/ASCIICType.h (103143 => 103144)
--- trunk/Source/_javascript_Core/wtf/ASCIICType.h 2011-12-17 05:53:42 UTC (rev 103143)
+++ trunk/Source/_javascript_Core/wtf/ASCIICType.h 2011-12-17 06:35:29 UTC (rev 103144)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2007, 2008, 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -43,129 +43,105 @@
namespace WTF {
-inline bool isASCII(char c) { return !(c & ~0x7F); }
-inline bool isASCII(unsigned short c) { return !(c & ~0x7F); }
-#if !COMPILER(MSVC) || defined(_NATIVE_WCHAR_T_DEFINED)
-inline bool isASCII(wchar_t c) { return !(c & ~0x7F); }
-#endif
-inline bool isASCII(int c) { return !(c & ~0x7F); }
-inline bool isASCII(unsigned c) { return !(c & ~0x7F); }
+template inline bool isASCII(CharType c)
+{
+return !(c & ~0x7F);
+}
-inline bool isASCIIAlpha(char c) { return (c | 0x20) >= 'a' && (c | 0x20) <= 'z'; }
-inline bool isASCIIAlpha(unsigned short c) { return (c | 0x20) >= 'a' && (c | 0x20) <= 'z'; }
-#if !COMPILER(MSVC) || defined(_NATIVE_WCHAR_T_DEFINED)
-inline bool isASCIIAlpha(wchar_t c) { return (c | 0x20) >= 'a' && (c | 0x20) <= 'z'; }
-#endif
-inline bool isASCIIAlpha(int c) { return (c | 0x20) >= 'a' && (c | 0x20) <= 'z'; }
-inline bool isASCIIAlpha(unsigned c) { return (c | 0x20) >= 'a' && (c | 0x20) <= 'z'; }
+template inline bool isASCIIAlpha(CharType c)
+{
+return (c | 0x20) >= 'a' && (c | 0x20) <= 'z';
+}
-inline bool isASCIIAlphanumeric(char c) { return (c >= '0' && c <= '9') || ((c | 0x20) >= 'a' && (c | 0x20) <= 'z'); }
-inline bool isASCIIAlphanumeric(unsigned short c) { return (c >= '0' && c <= '9') || ((c | 0x20) >= 'a' && (c | 0x20) <= 'z'); }
-#if !COMPILER(MSVC) || defined(_NATIVE_WCHAR_T_DEFINED)
-inline bool isASCIIAlphanumeric(wchar_t c) { return (c >= '0' && c <= '9') || ((c | 0x20) >= 'a' && (c | 0x20) <= 'z'); }
-#endif
-inline bool isASCIIAlphanumeric(int c) { return (c >= '0' && c <= '9') || ((c | 0x20) >= 'a' && (c | 0x20) <= 'z'); }
-inline bool isASCIIAlphanumeric(unsigned c) { return (c >= '0' && c <= '9') || ((c | 0x20) >= 'a' && (c | 0x20) <= 'z'); }
+template inline bool isASCIIAlphanumeric(CharType c)
+{
+return (c >= '0' && c <= '9') || ((c | 0x20) >= 'a' && (c | 0x20) <= 'z');
+}
-inline bool isASCIIDigit(char c) { return (c >= '0') & (c <= '9'); }
-inline bool isASCIIDigit(unsigned short c) { return (c >= '0') & (c <= '9'); }
-#if !COMPILER(MSVC) || defined(_NATIVE_WCHAR_T_DEFINED)
-inline bool isASCIIDigit(wchar_t c) { return (c >= '0') & (c <= '9'); }
-#endif
-inline bool
[webkit-changes] [103143] trunk/Source/WebCore
Title: [103143] trunk/Source/WebCore Revision 103143 Author benja...@webkit.org Date 2011-12-16 21:53:42 -0800 (Fri, 16 Dec 2011) Log Message FEComposite does not build when you disable filters on ARMv7 https://bugs.webkit.org/show_bug.cgi?id=74772 Patch by Benjamin Poulain on 2011-12-16 Reviewed by David Kilzer. Add the missing ENABLE(FILTERS). * platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: * platform/graphics/filters/arm/FECompositeArithmeticNEON.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h Diff Modified: trunk/Source/WebCore/ChangeLog (103142 => 103143) --- trunk/Source/WebCore/ChangeLog 2011-12-17 04:50:01 UTC (rev 103142) +++ trunk/Source/WebCore/ChangeLog 2011-12-17 05:53:42 UTC (rev 103143) @@ -1,3 +1,15 @@ +2011-12-16 Benjamin Poulain + +FEComposite does not build when you disable filters on ARMv7 +https://bugs.webkit.org/show_bug.cgi?id=74772 + +Reviewed by David Kilzer. + +Add the missing ENABLE(FILTERS). + +* platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: +* platform/graphics/filters/arm/FECompositeArithmeticNEON.h: + 2011-12-16 Ryosuke Niwa Mac build fix after r103104. Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp (103142 => 103143) --- trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp 2011-12-17 04:50:01 UTC (rev 103142) +++ trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp 2011-12-17 05:53:42 UTC (rev 103143) @@ -25,6 +25,8 @@ */ #include "config.h" + +#if ENABLE(FILTERS) #include "FECompositeArithmeticNEON.h" #if CPU(ARM_NEON) && COMPILER(GCC) @@ -148,3 +150,6 @@ } // namespace WebCore #endif // CPU(ARM_NEON) && COMPILER(GCC) + +#endif // ENABLE(FILTERS) + Modified: trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h (103142 => 103143) --- trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h 2011-12-17 04:50:01 UTC (rev 103142) +++ trunk/Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h 2011-12-17 05:53:42 UTC (rev 103143) @@ -29,6 +29,7 @@ #include +#if ENABLE(FILTERS) #if CPU(ARM_NEON) && COMPILER(GCC) #include "FEComposite.h" @@ -47,5 +48,6 @@ } // namespace WebCore #endif // CPU(ARM_NEON) && COMPILER(GCC) +#endif // ENABLE(FILTERS) #endif // FECompositeArithmeticNEON_h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103142] trunk/Source/JavaScriptCore
Title: [103142] trunk/Source/_javascript_Core
Revision 103142
Author mr...@apple.com
Date 2011-12-16 20:50:01 -0800 (Fri, 16 Dec 2011)
Log Message
Roll out r103139 because it breaks the build.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (103141 => 103142)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-17 04:44:04 UTC (rev 103141)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-17 04:50:01 UTC (rev 103142)
@@ -1,14 +1,3 @@
-2011-12-16 Rafael Brandao
-
-Remove unused variable after r74747 (buildfix)
-https://bugs.webkit.org/show_bug.cgi?id=74767
-
-Reviewed by Darin Adler.
-
-* dfg/DFGSpeculativeJIT.cpp:
-(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
-(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
-
2011-12-16 Gavin Barraclough
Reverted r103120, this breaks v8 on ARMv7 DFG.
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (103141 => 103142)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-12-17 04:44:04 UTC (rev 103141)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-12-17 04:50:01 UTC (rev 103142)
@@ -1553,6 +1553,7 @@
if (!isByteArrayPrediction(m_state.forNode(baseIndex).m_type))
speculationCheck(BadType, JSValueSource::unboxedCell(base), baseIndex, m_jit.branchPtr(MacroAssembler::NotEqual, MacroAssembler::Address(base, JSCell::classInfoOffset()), MacroAssembler::TrustedImmPtr(&JSByteArray::s_info)));
GPRTemporary value;
+GPRReg valueGPR;
if (at(valueIndex).isConstant()) {
JSValue jsValue = valueOfJSConstant(valueIndex);
@@ -1571,6 +1572,7 @@
GPRReg scratchReg = scratch.gpr();
m_jit.move(Imm32((int)d), scratchReg);
value.adopt(scratch);
+valueGPR = scratchReg;
} else if (!at(valueIndex).shouldNotSpeculateInteger()) {
SpeculateIntegerOperand valueOp(this, valueIndex);
GPRTemporary scratch(this);
@@ -1585,6 +1587,7 @@
clamped.link(&m_jit);
inBounds.link(&m_jit);
value.adopt(scratch);
+valueGPR = scratchReg;
} else {
SpeculateDoubleOperand valueOp(this, valueIndex);
GPRTemporary result(this);
@@ -1593,6 +1596,7 @@
GPRReg gpr = result.gpr();
compileClampDoubleToByte(m_jit, gpr, fpr, floatScratch.fpr());
value.adopt(result);
+valueGPR = gpr;
}
ASSERT_UNUSED(valueGPR, valueGPR != property);
ASSERT(valueGPR != base);
@@ -1706,6 +1710,7 @@
if (speculationRequirements != NoTypedArrayTypeSpecCheck)
speculationCheck(BadType, JSValueSource::unboxedCell(base), baseIndex, m_jit.branchPtr(MacroAssembler::NotEqual, MacroAssembler::Address(base, JSCell::classInfoOffset()), MacroAssembler::TrustedImmPtr(descriptor.m_classInfo)));
GPRTemporary value;
+GPRReg valueGPR;
if (at(valueIndex).isConstant()) {
JSValue jsValue = valueOfJSConstant(valueIndex);
@@ -1719,12 +1724,14 @@
GPRReg scratchReg = scratch.gpr();
m_jit.move(Imm32((int)d), scratchReg);
value.adopt(scratch);
+valueGPR = scratchReg;
} else if (!at(valueIndex).shouldNotSpeculateInteger()) {
SpeculateIntegerOperand valueOp(this, valueIndex);
GPRTemporary scratch(this);
GPRReg scratchReg = scratch.gpr();
m_jit.move(valueOp.gpr(), scratchReg);
value.adopt(scratch);
+valueGPR = scratchReg;
} else {
SpeculateDoubleOperand valueOp(this, valueIndex);
GPRTemporary result(this);
@@ -1741,6 +1748,7 @@
m_jit.truncateDoubleToUint32(fpr, gpr);
fixed.link(&m_jit);
value.adopt(result);
+valueGPR = gpr;
}
ASSERT_UNUSED(valueGPR, valueGPR != property);
ASSERT(valueGPR != base);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103141] trunk/Source/WebCore
Title: [103141] trunk/Source/WebCore
Revision 103141
Author rn...@webkit.org
Date 2011-12-16 20:44:04 -0800 (Fri, 16 Dec 2011)
Log Message
Mac build fix after r103104.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (103140 => 103141)
--- trunk/Source/WebCore/ChangeLog 2011-12-17 04:36:34 UTC (rev 103140)
+++ trunk/Source/WebCore/ChangeLog 2011-12-17 04:44:04 UTC (rev 103141)
@@ -1,3 +1,9 @@
+2011-12-16 Ryosuke Niwa
+
+Mac build fix after r103104.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2011-12-16 Adam Klein
Consolidate before-advice regarding attribute modification into a single method
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (103140 => 103141)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-12-17 04:36:34 UTC (rev 103140)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-12-17 04:44:04 UTC (rev 103141)
@@ -3015,14 +3015,14 @@
93309DDA099E64920056E581 /* BreakBlockquoteCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309D8B099E64910056E581 /* BreakBlockquoteCommand.cpp */; };
93309DDB099E64920056E581 /* BreakBlockquoteCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D8C099E64910056E581 /* BreakBlockquoteCommand.h */; };
93309DDC099E64920056E581 /* CompositeEditCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309D8D099E64910056E581 /* CompositeEditCommand.cpp */; };
- 93309DDD099E64920056E581 /* CompositeEditCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D8E099E64910056E581 /* CompositeEditCommand.h */; };
+ 93309DDD099E64920056E581 /* CompositeEditCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D8E099E64910056E581 /* CompositeEditCommand.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309DDE099E64920056E581 /* DeleteFromTextNodeCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309D8F099E64910056E581 /* DeleteFromTextNodeCommand.cpp */; };
93309DDF099E64920056E581 /* DeleteFromTextNodeCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D90099E64910056E581 /* DeleteFromTextNodeCommand.h */; };
93309DE0099E64920056E581 /* DeleteSelectionCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309D91099E64910056E581 /* DeleteSelectionCommand.cpp */; };
93309DE1099E64920056E581 /* DeleteSelectionCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D92099E64910056E581 /* DeleteSelectionCommand.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309DE2099E64920056E581 /* EditAction.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D93099E64910056E581 /* EditAction.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309DE3099E64920056E581 /* EditCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309D94099E64910056E581 /* EditCommand.cpp */; };
- 93309DE4099E64920056E581 /* EditCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D95099E64910056E581 /* EditCommand.h */; };
+ 93309DE4099E64920056E581 /* EditCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D95099E64910056E581 /* EditCommand.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309DE5099E64920056E581 /* HTMLInterchange.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309D96099E64910056E581 /* HTMLInterchange.cpp */; };
93309DE6099E64920056E581 /* HTMLInterchange.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309D97099E64910056E581 /* HTMLInterchange.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309DE7099E64920056E581 /* htmlediting.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309D98099E64910056E581 /* htmlediting.cpp */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103140] trunk/Source/WebCore
Title: [103140] trunk/Source/WebCore
Revision 103140
Author ad...@chromium.org
Date 2011-12-16 20:36:34 -0800 (Fri, 16 Dec 2011)
Log Message
Consolidate before-advice regarding attribute modification into a single method
https://bugs.webkit.org/show_bug.cgi?id=74752
Reviewed by Ryosuke Niwa.
Adds a willModifyAttribute method to Element, meant to be called
before an attribute on that Element is added/removed/changed.
Replace most calls to Element::updateId and all calls to
Element::enqueueAttributesMutationRecordIfRequested with calls to
willModifyAttribute. Moreover, enqueueAttributesMutation... can now
be private since its only caller is willModifyAttribute.
The only remaining direct calls to updateId are in cases the entire
NamedNodeMap is being replaced. These are implementation details of
WebCore that shouldn't be exposed via MutationObservers.
No new tests, no expected change in behavior.
* dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged): Besides the above change, use a
StringBuilder to build up value, and only do String -> AtomicString
conversion once.
* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
* dom/Element.h:
(WebCore::Element::willModifyAttribute):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/NamedNodeMap.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (103139 => 103140)
--- trunk/Source/WebCore/ChangeLog 2011-12-17 03:46:17 UTC (rev 103139)
+++ trunk/Source/WebCore/ChangeLog 2011-12-17 04:36:34 UTC (rev 103140)
@@ -1,3 +1,37 @@
+2011-12-16 Adam Klein
+
+Consolidate before-advice regarding attribute modification into a single method
+https://bugs.webkit.org/show_bug.cgi?id=74752
+
+Reviewed by Ryosuke Niwa.
+
+Adds a willModifyAttribute method to Element, meant to be called
+before an attribute on that Element is added/removed/changed.
+
+Replace most calls to Element::updateId and all calls to
+Element::enqueueAttributesMutationRecordIfRequested with calls to
+willModifyAttribute. Moreover, enqueueAttributesMutation... can now
+be private since its only caller is willModifyAttribute.
+
+The only remaining direct calls to updateId are in cases the entire
+NamedNodeMap is being replaced. These are implementation details of
+WebCore that shouldn't be exposed via MutationObservers.
+
+No new tests, no expected change in behavior.
+
+* dom/Attr.cpp:
+(WebCore::Attr::setValue):
+(WebCore::Attr::childrenChanged): Besides the above change, use a
+StringBuilder to build up value, and only do String -> AtomicString
+conversion once.
+* dom/Element.cpp:
+(WebCore::Element::setAttributeInternal):
+* dom/Element.h:
+(WebCore::Element::willModifyAttribute):
+* dom/NamedNodeMap.cpp:
+(WebCore::NamedNodeMap::setNamedItem):
+(WebCore::NamedNodeMap::removeNamedItem):
+
2011-12-16 James Robinson
[chromium] CCLayerDelegate and WebLayerClient do not need notifySyncRequired
Modified: trunk/Source/WebCore/dom/Attr.cpp (103139 => 103140)
--- trunk/Source/WebCore/dom/Attr.cpp 2011-12-17 03:46:17 UTC (rev 103139)
+++ trunk/Source/WebCore/dom/Attr.cpp 2011-12-17 04:36:34 UTC (rev 103140)
@@ -29,6 +29,8 @@
#include "ScopedEventQueue.h"
#include "Text.h"
#include "XMLNSNames.h"
+#include
+#include
namespace WebCore {
@@ -132,14 +134,9 @@
void Attr::setValue(const AtomicString& value, ExceptionCode&)
{
-#if ENABLE(MUTATION_OBSERVERS)
if (m_element)
-m_element->enqueueAttributesMutationRecordIfRequested(m_attribute->name(), m_attribute->value());
-#endif
+m_element->willModifyAttribute(m_attribute->name(), m_attribute->value(), value);
-if (m_element && m_element->isIdAttributeName(m_attribute->name()))
-m_element->updateId(m_element->getIdAttribute(), value);
-
setValue(value);
if (m_element)
@@ -175,27 +172,23 @@
if (m_ignoreChildrenChanged > 0)
return;
-#if ENABLE(MUTATION_OBSERVERS)
-if (m_element)
-m_element->enqueueAttributesMutationRecordIfRequested(m_attribute->name(), m_attribute->value());
-#endif
-
Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
invalidateNodeListsCacheAfterAttributeChanged(m_attribute->name());
// FIXME: We should include entity references in the value
-String val = "";
+StringBuilder valueBuilder;
for (Node *n = firstChild(); n; n = n->nextSibling()) {
if (n->isTextNode())
-val += static_cast(n)->data();
+valueBuilder.append(static_cast(n)->data());
}
-if (m_element && m_element->
[webkit-changes] [103139] trunk/Source/JavaScriptCore
Title: [103139] trunk/Source/_javascript_Core
Revision 103139
Author commit-qu...@webkit.org
Date 2011-12-16 19:46:17 -0800 (Fri, 16 Dec 2011)
Log Message
Remove unused variable after r74747 (buildfix)
https://bugs.webkit.org/show_bug.cgi?id=74767
Patch by Rafael Brandao on 2011-12-16
Reviewed by Darin Adler.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (103138 => 103139)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-17 02:40:35 UTC (rev 103138)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-17 03:46:17 UTC (rev 103139)
@@ -1,3 +1,14 @@
+2011-12-16 Rafael Brandao
+
+Remove unused variable after r74747 (buildfix)
+https://bugs.webkit.org/show_bug.cgi?id=74767
+
+Reviewed by Darin Adler.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
+(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
+
2011-12-16 Gavin Barraclough
Reverted r103120, this breaks v8 on ARMv7 DFG.
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (103138 => 103139)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-12-17 02:40:35 UTC (rev 103138)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-12-17 03:46:17 UTC (rev 103139)
@@ -1553,7 +1553,6 @@
if (!isByteArrayPrediction(m_state.forNode(baseIndex).m_type))
speculationCheck(BadType, JSValueSource::unboxedCell(base), baseIndex, m_jit.branchPtr(MacroAssembler::NotEqual, MacroAssembler::Address(base, JSCell::classInfoOffset()), MacroAssembler::TrustedImmPtr(&JSByteArray::s_info)));
GPRTemporary value;
-GPRReg valueGPR;
if (at(valueIndex).isConstant()) {
JSValue jsValue = valueOfJSConstant(valueIndex);
@@ -1572,7 +1571,6 @@
GPRReg scratchReg = scratch.gpr();
m_jit.move(Imm32((int)d), scratchReg);
value.adopt(scratch);
-valueGPR = scratchReg;
} else if (!at(valueIndex).shouldNotSpeculateInteger()) {
SpeculateIntegerOperand valueOp(this, valueIndex);
GPRTemporary scratch(this);
@@ -1587,7 +1585,6 @@
clamped.link(&m_jit);
inBounds.link(&m_jit);
value.adopt(scratch);
-valueGPR = scratchReg;
} else {
SpeculateDoubleOperand valueOp(this, valueIndex);
GPRTemporary result(this);
@@ -1596,7 +1593,6 @@
GPRReg gpr = result.gpr();
compileClampDoubleToByte(m_jit, gpr, fpr, floatScratch.fpr());
value.adopt(result);
-valueGPR = gpr;
}
ASSERT_UNUSED(valueGPR, valueGPR != property);
ASSERT(valueGPR != base);
@@ -1710,7 +1706,6 @@
if (speculationRequirements != NoTypedArrayTypeSpecCheck)
speculationCheck(BadType, JSValueSource::unboxedCell(base), baseIndex, m_jit.branchPtr(MacroAssembler::NotEqual, MacroAssembler::Address(base, JSCell::classInfoOffset()), MacroAssembler::TrustedImmPtr(descriptor.m_classInfo)));
GPRTemporary value;
-GPRReg valueGPR;
if (at(valueIndex).isConstant()) {
JSValue jsValue = valueOfJSConstant(valueIndex);
@@ -1724,14 +1719,12 @@
GPRReg scratchReg = scratch.gpr();
m_jit.move(Imm32((int)d), scratchReg);
value.adopt(scratch);
-valueGPR = scratchReg;
} else if (!at(valueIndex).shouldNotSpeculateInteger()) {
SpeculateIntegerOperand valueOp(this, valueIndex);
GPRTemporary scratch(this);
GPRReg scratchReg = scratch.gpr();
m_jit.move(valueOp.gpr(), scratchReg);
value.adopt(scratch);
-valueGPR = scratchReg;
} else {
SpeculateDoubleOperand valueOp(this, valueIndex);
GPRTemporary result(this);
@@ -1748,7 +1741,6 @@
m_jit.truncateDoubleToUint32(fpr, gpr);
fixed.link(&m_jit);
value.adopt(result);
-valueGPR = gpr;
}
ASSERT_UNUSED(valueGPR, valueGPR != property);
ASSERT(valueGPR != base);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103137] trunk/LayoutTests
Title: [103137] trunk/LayoutTests Revision 103137 Author commit-qu...@webkit.org Date 2011-12-16 18:37:43 -0800 (Fri, 16 Dec 2011) Log Message Layout Test media/controls-right-click-on-timebar.html is flaky - Crash on LEOPARD CG DEBUG ffmpeg_video_decoder.cc has been reworked extensively since the reported crashes and the test is 0% flaky now. https://bugs.webkit.org/show_bug.cgi?id=68747 Patch by Ami Fischman on 2011-12-16 Reviewed by Eric Carlson. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103136 => 103137) --- trunk/LayoutTests/ChangeLog 2011-12-17 02:16:41 UTC (rev 103136) +++ trunk/LayoutTests/ChangeLog 2011-12-17 02:37:43 UTC (rev 103137) @@ -1,3 +1,14 @@ +2011-12-16 Ami Fischman + +Layout Test media/controls-right-click-on-timebar.html is flaky - Crash on LEOPARD CG DEBUG +ffmpeg_video_decoder.cc has been reworked extensively since the reported crashes +and the test is 0% flaky now. +https://bugs.webkit.org/show_bug.cgi?id=68747 + +Reviewed by Eric Carlson. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Tony Chang [chromium] 2 repaint test failures on mac Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103136 => 103137) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-17 02:16:41 UTC (rev 103136) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-17 02:37:43 UTC (rev 103137) @@ -3703,8 +3703,6 @@ // main bots too, although not as flaky for some reason. BUGABARTH WIN LINUX : svg/custom/svg-fonts-word-spacing.html = PASS FAIL -BUGWK68747 : media/controls-right-click-on-timebar.html = TIMEOUT PASS - BUGCR97657 MAC CPU-CG : media/audio-repaint.html = TIMEOUT IMAGE PASS BUGWK68970 MAC CPU-CG : fast/multicol/float-paginate-empty-lines.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103134] trunk/Source/WebCore
Title: [103134] trunk/Source/WebCore
Revision 103134
Author ad...@chromium.org
Date 2011-12-16 18:04:31 -0800 (Fri, 16 Dec 2011)
Log Message
Fix typo in MarkupTokenBase: rename takeAtributes to takeAttributes
https://bugs.webkit.org/show_bug.cgi?id=74766
Reviewed by Darin Adler.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::takeAttributes):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/xml/parser/MarkupTokenBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (103133 => 103134)
--- trunk/Source/WebCore/ChangeLog 2011-12-17 01:19:36 UTC (rev 103133)
+++ trunk/Source/WebCore/ChangeLog 2011-12-17 02:04:31 UTC (rev 103134)
@@ -1,3 +1,20 @@
+2011-12-16 Adam Klein
+
+Fix typo in MarkupTokenBase: rename takeAtributes to takeAttributes
+https://bugs.webkit.org/show_bug.cgi?id=74766
+
+Reviewed by Darin Adler.
+
+* html/parser/HTMLConstructionSite.cpp:
+(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
+(WebCore::HTMLConstructionSite::insertScriptElement):
+(WebCore::HTMLConstructionSite::createElement):
+(WebCore::HTMLConstructionSite::createHTMLElement):
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
+* xml/parser/MarkupTokenBase.h:
+(WebCore::AtomicMarkupTokenBase::takeAttributes):
+
2011-12-16 Adam Barth
doesn't parse correctly
Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (103133 => 103134)
--- trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2011-12-17 01:19:36 UTC (rev 103133)
+++ trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2011-12-17 02:04:31 UTC (rev 103134)
@@ -188,7 +188,7 @@
void HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML(AtomicHTMLToken& token)
{
RefPtr element = HTMLHtmlElement::create(m_document);
-element->setAttributeMap(token.takeAtributes(), m_fragmentScriptingPermission);
+element->setAttributeMap(token.takeAttributes(), m_fragmentScriptingPermission);
m_openElements.pushHTMLHtmlElement(attach(m_attachmentRoot, element.get()));
element->insertedByParser();
dispatchDocumentElementAvailableIfNeeded();
@@ -324,7 +324,7 @@
{
RefPtr element = HTMLScriptElement::create(scriptTag, currentNode()->document(), true);
if (m_fragmentScriptingPermission == FragmentScriptingAllowed)
-element->setAttributeMap(token.takeAtributes(), m_fragmentScriptingPermission);
+element->setAttributeMap(token.takeAttributes(), m_fragmentScriptingPermission);
m_openElements.push(attachToCurrent(element.release()));
}
@@ -382,7 +382,7 @@
{
QualifiedName tagName(nullAtom, token.name(), namespaceURI);
RefPtr element = currentNode()->document()->createElement(tagName, true);
-element->setAttributeMap(token.takeAtributes(), m_fragmentScriptingPermission);
+element->setAttributeMap(token.takeAttributes(), m_fragmentScriptingPermission);
return element.release();
}
@@ -393,7 +393,7 @@
// have to pass the current form element. We should rework form association
// to occur after construction to allow better code sharing here.
RefPtr element = HTMLElementFactory::createHTMLElement(tagName, currentNode()->document(), form(), true);
-element->setAttributeMap(token.takeAtributes(), m_fragmentScriptingPermission);
+element->setAttributeMap(token.takeAttributes(), m_fragmentScriptingPermission);
ASSERT(element->isHTMLElement());
return element.release();
}
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (103133 => 103134)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-12-17 01:19:36 UTC (rev 103133)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-12-17 02:04:31 UTC (rev 103134)
@@ -557,7 +557,7 @@
PassRefPtr HTMLTreeBuilder::attributesForIsindexInput(AtomicHTMLToken& token)
{
-RefPtr attributes = token.takeAtributes();
+RefPtr attributes = token.takeAttributes();
if (!attributes)
attributes = NamedNodeMap::create();
else {
Modified: trunk/Source/WebCore/xml/parser/MarkupTokenBase.h (103133 => 103134)
--- trunk/Source/WebCore/xml/parser/MarkupTokenBase.h 2011-12-17 01:19:36 UTC (rev 103133)
+++ trunk/Source/WebCore/xml/parser/MarkupTokenBase.h 2011-12-17 02:04:31 UTC (rev 103134)
@@ -452,7 +452,7 @@
return m_attributes.get();
}
-PassRefPtr takeAtributes()
+PassRefPtr ta
[webkit-changes] [103133] trunk
Title: [103133] trunk
Revision 103133
Author aba...@webkit.org
Date 2011-12-16 17:19:36 -0800 (Fri, 16 Dec 2011)
Log Message
doesn't parse correctly
https://bugs.webkit.org/show_bug.cgi?id=74760
Reviewed by Eric Seidel.
Source/WebCore:
The start tag shouldn't be quite as aggressive in closing open
tags. I'm not sure whether this was a change in the spec or a
mistranscription, but this patch causes us to match the spec. I've
checked the other optionTag checks, and they all seem to be correct.
* html/parser/HTMLTreeBuilder.cpp:
LayoutTests:
Show test progression.
* html5lib/runner-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/runner-expected.txt
trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (103132 => 103133)
--- trunk/LayoutTests/ChangeLog 2011-12-17 01:03:36 UTC (rev 103132)
+++ trunk/LayoutTests/ChangeLog 2011-12-17 01:19:36 UTC (rev 103133)
@@ -1,3 +1,14 @@
+2011-12-16 Adam Barth
+
+ doesn't parse correctly
+https://bugs.webkit.org/show_bug.cgi?id=74760
+
+Reviewed by Eric Seidel.
+
+Show test progression.
+
+* html5lib/runner-expected.txt:
+
2011-12-16 Brady Eidson
and https://bugs.webkit.org/show_bug.cgi?id=74533
Modified: trunk/LayoutTests/html5lib/runner-expected.txt (103132 => 103133)
--- trunk/LayoutTests/html5lib/runner-expected.txt 2011-12-17 01:03:36 UTC (rev 103132)
+++ trunk/LayoutTests/html5lib/runner-expected.txt 2011-12-17 01:19:36 UTC (rev 103133)
@@ -158,25 +158,8 @@
resources/tests19.dat: PASS
-resources/tests20.dat:
-31
+resources/tests20.dat: PASS
-Test 31 of 39 in resources/tests20.dat failed. Input:
-
-Got:
-|
-|
-|
-|
-|
-|
-Expected:
-|
-|
-|
-|
-|
-|
resources/tests21.dat: PASS
resources/tests22.dat:
Modified: trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt (103132 => 103133)
--- trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt 2011-12-17 01:03:36 UTC (rev 103132)
+++ trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt 2011-12-17 01:19:36 UTC (rev 103133)
@@ -158,25 +158,8 @@
resources/tests19.dat: PASS
-resources/tests20.dat:
-31
+resources/tests20.dat: PASS
-Test 31 of 39 in resources/tests20.dat failed. Input:
-
-Got:
-|
-|
-|
-|
-|
-|
-Expected:
-|
-|
-|
-|
-|
-|
resources/tests21.dat: PASS
resources/tests22.dat:
Modified: trunk/Source/WebCore/ChangeLog (103132 => 103133)
--- trunk/Source/WebCore/ChangeLog 2011-12-17 01:03:36 UTC (rev 103132)
+++ trunk/Source/WebCore/ChangeLog 2011-12-17 01:19:36 UTC (rev 103133)
@@ -1,3 +1,17 @@
+2011-12-16 Adam Barth
+
+ doesn't parse correctly
+https://bugs.webkit.org/show_bug.cgi?id=74760
+
+Reviewed by Eric Seidel.
+
+The start tag shouldn't be quite as aggressive in closing open
+ tags. I'm not sure whether this was a change in the spec or a
+mistranscription, but this patch causes us to match the spec. I've
+checked the other optionTag checks, and they all seem to be correct.
+
+* html/parser/HTMLTreeBuilder.cpp:
+
2011-12-16 Rafael Weinstein
[MutationObservers] Remove platform-dependent code in Document.cpp resulting from Mutation Event histogram collection
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (103132 => 103133)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-12-17 01:03:36 UTC (rev 103132)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-12-17 01:19:36 UTC (rev 103133)
@@ -995,7 +995,7 @@
return;
}
if (token.name() == optgroupTag || token.name() == optionTag) {
-if (m_tree.openElements()->inScope(optionTag.localName())) {
+if (m_tree.currentNode()->hasTagName(optionTag)) {
AtomicHTMLToken endOption(HTMLTokenTypes::EndTag, optionTag.localName());
processEndTag(endOption);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103132] trunk/Source/WebKit2
Title: [103132] trunk/Source/WebKit2
Revision 103132
Author ander...@apple.com
Date 2011-12-16 17:03:36 -0800 (Fri, 16 Dec 2011)
Log Message
Convert more WorkItems over to WTF::Functions
https://bugs.webkit.org/show_bug.cgi?id=74770
Reviewed by Andreas Kling.
* Platform/WorkQueue.cpp:
(WorkQueue::dispatchAfterDelay):
* Platform/WorkQueue.h:
* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
* UIProcess/Launcher/ThreadLauncher.cpp:
(WebKit::ThreadLauncher::launchThread):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::derefPluginView):
(WebKit::PluginView::unprotectPluginFromDestruction):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/WorkItem.h
trunk/Source/WebKit2/Platform/WorkQueue.cpp
trunk/Source/WebKit2/Platform/WorkQueue.h
trunk/Source/WebKit2/Shared/ChildProcess.cpp
trunk/Source/WebKit2/UIProcess/Launcher/ThreadLauncher.cpp
trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (103131 => 103132)
--- trunk/Source/WebKit2/ChangeLog 2011-12-17 00:58:33 UTC (rev 103131)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-17 01:03:36 UTC (rev 103132)
@@ -1,3 +1,25 @@
+2011-12-16 Anders Carlsson
+
+Convert more WorkItems over to WTF::Functions
+https://bugs.webkit.org/show_bug.cgi?id=74770
+
+Reviewed by Andreas Kling.
+
+* Platform/WorkQueue.cpp:
+(WorkQueue::dispatchAfterDelay):
+* Platform/WorkQueue.h:
+* Shared/ChildProcess.cpp:
+(WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
+* UIProcess/Launcher/ThreadLauncher.cpp:
+(WebKit::ThreadLauncher::launchThread):
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::ProcessLauncher::launchProcess):
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::pluginThreadAsyncCall):
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::derefPluginView):
+(WebKit::PluginView::unprotectPluginFromDestruction):
+
2011-12-16 Mark Hahnenberg
Windows test fix
Modified: trunk/Source/WebKit2/Platform/WorkItem.h (103131 => 103132)
--- trunk/Source/WebKit2/Platform/WorkItem.h 2011-12-17 00:58:33 UTC (rev 103131)
+++ trunk/Source/WebKit2/Platform/WorkItem.h 2011-12-17 01:03:36 UTC (rev 103132)
@@ -42,9 +42,6 @@
static PassOwnPtr create(void (*)());
-template
-static PassOwnPtr createDeref(C*);
-
static PassOwnPtr create(const Function&);
virtual ~WorkItem() { }
@@ -190,30 +187,6 @@
return adoptPtr(static_cast(new FunctionWorkItem0(function)));
}
-template
-class DerefWorkItem : private WorkItem {
-// We only allow WorkItem to create this.
-friend class WorkItem;
-
-explicit DerefWorkItem(C* ptr)
-: m_ptr(ptr)
-{
-}
-
-virtual void execute()
-{
-m_ptr->deref();
-}
-
-C* m_ptr;
-};
-
-template
-PassOwnPtr WorkItem::createDeref(C* ptr)
-{
-return adoptPtr(static_cast(new DerefWorkItem(ptr)));
-}
-
// FunctionWorkItem is a temporary class. WorkItem should just be replaced by WTF::Function everywhere.
class FunctionWorkItem : private WorkItem {
// We only allow WorkItem to create this.
Modified: trunk/Source/WebKit2/Platform/WorkQueue.cpp (103131 => 103132)
--- trunk/Source/WebKit2/Platform/WorkQueue.cpp 2011-12-17 00:58:33 UTC (rev 103131)
+++ trunk/Source/WebKit2/Platform/WorkQueue.cpp 2011-12-17 01:03:36 UTC (rev 103132)
@@ -45,6 +45,11 @@
scheduleWork(WorkItem::create(function));
}
+void WorkQueue::dispatchAfterDelay(const Function& function, double delay)
+{
+scheduleWorkAfterDelay(WorkItem::create(function), delay);
+}
+
void WorkQueue::invalidate()
{
{
Modified: trunk/Source/WebKit2/Platform/WorkQueue.h (103131 => 103132)
--- trunk/Source/WebKit2/Platform/WorkQueue.h 2011-12-17 00:58:33 UTC (rev 103131)
+++ trunk/Source/WebKit2/Platform/WorkQueue.h 2011-12-17 01:03:36 UTC (rev 103132)
@@ -68,6 +68,9 @@
// Will dispatch the given function to run as soon as possible.
void dispatch(const Function&);
+// Will dispatch the given function after the given delay (in seconds).
+void dispatchAfterDelay(const Function&, double delay);
+
// FIXME: Get rid of WorkItem everywhere.
// Will schedule the given work item to run as soon as possible.
Modified: trunk/Source/WebKit2/Shared/ChildProcess.cpp (103131 => 103132)
--- trunk/Source/WebKit2/Shared/ChildProcess.cpp 2011-12-17 00:58:33 UTC (rev 103131)
+++ trunk/Source/WebKit2/Shared/ChildProcess.cpp 2011-12-17 01:03:36 UTC (rev 103132)
@@ -93,8 +93,8 @@
// If the
[webkit-changes] [103131] trunk/Source/WebCore
Title: [103131] trunk/Source/WebCore Revision 103131 Author commit-qu...@webkit.org Date 2011-12-16 16:58:33 -0800 (Fri, 16 Dec 2011) Log Message [MutationObservers] Remove platform-dependent code in Document.cpp resulting from Mutation Event histogram collection https://bugs.webkit.org/show_bug.cgi?id=73026 Patch by Rafael Weinstein on 2011-12-16 Reviewed by Ryosuke Niwa. This patch adds platform/HistogramSupport which has an empty implementation for all ports except Chromium. No tests need. This patch is just a refactor. * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * dom/Document.cpp: (WebCore::histogramMutationEventUsage): (WebCore::Document::~Document): * platform/HistogramSupport.h: Added. (WebCore::HistogramSupport::histogramEnumeration): * platform/chromium/HistogramSupportChromium.cpp: Added. (WebCore::HistogramSupport::histogramEnumeration): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/Document.cpp Added Paths trunk/Source/WebCore/platform/HistogramSupport.cpp trunk/Source/WebCore/platform/HistogramSupport.h trunk/Source/WebCore/platform/chromium/HistogramSupportChromium.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (103130 => 103131) --- trunk/Source/WebCore/CMakeLists.txt 2011-12-17 00:32:40 UTC (rev 103130) +++ trunk/Source/WebCore/CMakeLists.txt 2011-12-17 00:58:33 UTC (rev 103131) @@ -1046,6 +1046,7 @@ platform/FileSystem.cpp platform/ClockGeneric.cpp platform/GeolocationService.cpp +platform/HistogramSupport.cpp platform/KURL.cpp platform/KillRingNone.cpp platform/Language.cpp Modified: trunk/Source/WebCore/ChangeLog (103130 => 103131) --- trunk/Source/WebCore/ChangeLog 2011-12-17 00:32:40 UTC (rev 103130) +++ trunk/Source/WebCore/ChangeLog 2011-12-17 00:58:33 UTC (rev 103131) @@ -1,3 +1,27 @@ +2011-12-16 Rafael Weinstein + +[MutationObservers] Remove platform-dependent code in Document.cpp resulting from Mutation Event histogram collection +https://bugs.webkit.org/show_bug.cgi?id=73026 + +Reviewed by Ryosuke Niwa. + +This patch adds platform/HistogramSupport which has an empty implementation for all ports +except Chromium. + +No tests need. This patch is just a refactor. + +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.xcodeproj/project.pbxproj: +* dom/Document.cpp: +(WebCore::histogramMutationEventUsage): +(WebCore::Document::~Document): +* platform/HistogramSupport.h: Added. +(WebCore::HistogramSupport::histogramEnumeration): +* platform/chromium/HistogramSupportChromium.cpp: Added. +(WebCore::HistogramSupport::histogramEnumeration): + 2011-12-16 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=74533 Modified: trunk/Source/WebCore/GNUmakefile.list.am (103130 => 103131) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-12-17 00:32:40 UTC (rev 103130) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-12-17 00:58:33 UTC (rev 103131) @@ -2510,6 +2510,8 @@ Source/WebCore/platform/GeolocationService.cpp \ Source/WebCore/platform/GeolocationService.h \ Source/WebCore/platform/HashTools.h \ + Source/WebCore/platform/HistogramSupport.cop \ + Source/WebCore/platform/HistogramSupport.h \ Source/WebCore/platform/graphics/BitmapImage.cpp \ Source/WebCore/platform/graphics/BitmapImage.h \ Source/WebCore/platform/graphics/Color.cpp \ Modified: trunk/Source/WebCore/Target.pri (103130 => 103131) --- trunk/Source/WebCore/Target.pri 2011-12-17 00:32:40 UTC (rev 103130) +++ trunk/Source/WebCore/Target.pri 2011-12-17 00:58:33 UTC (rev 103131) @@ -1031,6 +1031,7 @@ platform/FileStream.cpp \ platform/FileSystem.cpp \ platform/GeolocationService.cpp \ +platform/HistogramSupport.cpp \ platform/image-decoders/qt/ImageFrameQt.cpp \ platform/graphics/FontDescription.cpp \ platform/graphics/FontFallbackList.cpp \ @@ -2073,6 +2074,7 @@ platform/FileStreamClient.h \ platform/FileSystem.h \ platform/GeolocationService.h \ +platform/HistogramSupport.h \ platform/image-decoders/ImageDecoder.h \ platform/mock/DeviceOrientationClientMock.h \ platform/mock/GeolocationClientMock.cpp \ Modified: trunk/Source/WebCore/WebCore.gypi (103130 => 103131) --- trunk/Source/WebCore/WebCore.gypi 2011-12-17 00:32:40 UTC (rev 103130) +++ trunk/Source/WebCore/WebCore.gypi 2011-12-17 00:58:33 UTC (rev 103131) @@ -682,6 +682,7 @@ 'platform/FileStreamClient.h', 'platform/FileSystem.h', 'platform/HostWindow.h', +'platform/HistogramSupport.h',
[webkit-changes] [103130] trunk
Title: [103130] trunk Revision 103130 Author beid...@apple.com Date 2011-12-16 16:32:40 -0800 (Fri, 16 Dec 2011) Log Message and https://bugs.webkit.org/show_bug.cgi?id=74533 REGRESSION(r102619): Reproducible crash closing window with video + poster image inside an object element Reviewed by Darin Adler. Source/WebCore: Test: media/crash-closing-page-with-media-as-plugin-fallback.html At some point documentWillBecomeInactive() was overloaded to not only notify elements they were going in to the page cache but also do some other work that was necessary during Document teardown. This crash occurs because we're notifying elements they're going in to the page cache at document teardown, so this patch breaks that work back out in to a separate function. * dom/Document.cpp: (WebCore::Document::detach): Remove obsolete comment. (WebCore::Document::documentWillBecomeInactive): Handle only accelerated compositing cleanup. (WebCore::Document::documentWillSuspendForPageCache): Call documentWillBecomeInactive before notifying elements of suspension. (WebCore::Document::documentDidResumeFromPageCache): (WebCore::Document::registerForPageCacheSuspensionCallbacks): (WebCore::Document::unregisterForPageCacheSuspensionCallbacks): * dom/Document.h: * history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): Call the renamed documentDidResumeFromPageCache. (WebCore::CachedFrame::CachedFrame): Call documentWillSuspendForPageCache instead of documentDidBecomeInactive. * loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Call the renamed documentDidResumeFromPageCache. * dom/Element.h: (WebCore::Element::documentWillSuspendForPageCache): Renamed from documentWillBecomeInactive() (WebCore::Element::documentDidResumeFromPageCache): Renamed from documentDidBecomeActive() Change to the renamed registration and callbacks functions in the handful of classes that use them: * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::documentDidResumeFromPageCache): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): * html/HTMLFormElement.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsSuspensionCallback): (WebCore::HTMLInputElement::registerForSuspensionCallbackIfNeeded): (WebCore::HTMLInputElement::unregisterForSuspensionCallbackIfNeeded): (WebCore::HTMLInputElement::documentDidResumeFromPageCache): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument): * html/HTMLInputElement.h: * html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::createRenderer): (WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): (WebCore::HTMLPlugInImageElement::didMoveToNewOwnerDocument): (WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache): (WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache): * html/HTMLPlugInImageElement.h: * svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::~SVGSVGElement): (WebCore::SVGSVGElement::willMoveToNewOwnerDocument): (WebCore::SVGSVGElement::didMoveToNewOwnerDocument): (WebCore::SVGSVGElement::documentWillSuspendForPageCache): (WebCore::SVGSVGElement::documentDidResumeFromPageCache): * svg/SVGSVGElement.h: LayoutTests: * media/crash-closing-page-with-media-as-plugin-fallback-expected.txt: Added. * media/crash-closing-page-with-media-as-plugin-fallback.html: Added. * media/resources/video-with-poster-as-object-fallback.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/history/CachedFrame.cpp trunk/Source/WebCore/html/HTMLFormElement.cpp trunk/Source/WebCore/html/HTMLFormElement.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp trunk/Source/WebCore/html/HTMLPlugInImageElement.h trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/svg/SVGSVGElement.cpp trunk/Source/WebCore/svg/SVGSVGElement.h Added Paths trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback-expected.txt trunk/LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html trunk/LayoutTests/media/resources/video-with-poster-as-object-fallback.html Diff Modified: trunk/LayoutTests/ChangeLog (103129 => 103130) --- trunk/LayoutTests/ChangeLog 2011-12-17 00:27:33 UTC (rev 103129) +++ trunk/LayoutTests/ChangeLog 2011-12-17 00:32:40 UTC (rev 103130) @@ -1,3 +1,14 @@ +2011-12-16 Brady Eidson + + an
[webkit-changes] [103129] trunk/Source
Title: [103129] trunk/Source Revision 103129 Author commit-qu...@webkit.org Date 2011-12-16 16:27:33 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Need to prepaint tiles in TiledLayerChromium https://bugs.webkit.org/show_bug.cgi?id=72686 Patch by Eric Penner on 2011-12-16 Reviewed by James Robinson. Source/WebCore: Tests: TiledLayerChromiumTest (idlePaintOutOfMemory, pushIdlePaintTiles) * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::idlePaintContentsIfDirty): added idle paint function * platform/graphics/chromium/ContentLayerChromium.h: ditto * platform/graphics/chromium/LayerChromium.h: ditto (WebCore::LayerChromium::idlePaintContentsIfDirty): ditto * platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::protectTexture): removed assert for protecting a texture twice * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::TiledLayerChromium::TiledLayerChromium): (WebCore::TiledLayerChromium::cleanupResources): (WebCore::TiledLayerChromium::updateCompositorResources): refactoring to use tile indices (WebCore::TiledLayerChromium::prepareToUpdateTiles): refactored common code and made idle/visible versions (WebCore::TiledLayerChromium::prepareToUpdate): ditto (WebCore::TiledLayerChromium::prepareToUpdateIdle): ditto (WebCore::TiledLayerChromium::needsIdlePaint): (WebCore::TiledLayerChromium::idlePaintRect): * platform/graphics/chromium/TiledLayerChromium.h: * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::compositeAndReadback): set flag to avoid idle paint durring composite and readback (WebCore::CCLayerTreeHost::updateLayers): added idle flag parameter (WebCore::CCLayerTreeHost::paintContentsIfDirty): ditto (WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface): ditto (WebCore::CCLayerTreeHost::paintLayerContents): chooses idle or visible paint * platform/graphics/chromium/cc/CCLayerTreeHost.h: Source/WebKit/chromium: * tests/CCLayerTreeHostTest.cpp: (WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsCount): (WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount): (WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty): (WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking): (WTF::CCLayerTreeHostTestOpacityChange::afterTest): * tests/TiledLayerChromiumTest.cpp: (WTF::FakeTiledLayerChromium::prepareToUpdateIdle): (WTF::FakeTiledLayerChromium::needsIdlePaint): (WTF::TEST): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp trunk/Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (103128 => 103129) --- trunk/Source/WebCore/ChangeLog 2011-12-17 00:18:52 UTC (rev 103128) +++ trunk/Source/WebCore/ChangeLog 2011-12-17 00:27:33 UTC (rev 103129) @@ -1,3 +1,38 @@ +2011-12-16 Eric Penner + +[chromium] Need to prepaint tiles in TiledLayerChromium +https://bugs.webkit.org/show_bug.cgi?id=72686 + +Reviewed by James Robinson. + +Tests: TiledLayerChromiumTest (idlePaintOutOfMemory, pushIdlePaintTiles) + +* platform/graphics/chromium/ContentLayerChromium.cpp: +(WebCore::ContentLayerChromium::idlePaintContentsIfDirty): added idle paint function +* platform/graphics/chromium/ContentLayerChromium.h: ditto +* platform/graphics/chromium/LayerChromium.h: ditto +(WebCore::LayerChromium::idlePaintContentsIfDirty): ditto +* platform/graphics/chromium/TextureManager.cpp: +(WebCore::TextureManager::protectTexture): removed assert for protecting a texture twice +* platform/graphics/chromium/TiledLayerChromium.cpp: +(WebCore::TiledLayerChromium::TiledLayerChromium): +(WebCore::TiledLayerChromium::cleanupResources): +(WebCore::TiledLayerChromium::updateCompositorResources): refactoring to use tile indices +(WebCore::TiledLayerChromium::prepareToUpdateTiles): refactored common code and made idle/visible versions +(WebCore::TiledLayerChromium::prepareToUpdate): ditto +(WebCore::TiledLayerChromium::prepareToUpdateIdle): ditto +(WebCore::TiledLayerChromium::needsIdlePaint): +(WebCore::TiledLayerChromium::idlePaintRect): +* platform/graphics/
[webkit-changes] [103126] trunk/Tools
Title: [103126] trunk/Tools
Revision 103126
Author d...@apple.com
Date 2011-12-16 16:07:23 -0800 (Fri, 16 Dec 2011)
Log Message
Move webkit-bug-importer to Contributor. It won't
autocomplete as an Account.
See https://bugs.webkit.org/show_bug.cgi?id=74739
for some discussion.
Unreviewed.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (103125 => 103126)
--- trunk/Tools/ChangeLog 2011-12-17 00:01:22 UTC (rev 103125)
+++ trunk/Tools/ChangeLog 2011-12-17 00:07:23 UTC (rev 103126)
@@ -1,5 +1,16 @@
2011-12-16 Dean Jackson
+Move webkit-bug-importer to Contributor. It won't
+autocomplete as an Account.
+See https://bugs.webkit.org/show_bug.cgi?id=74739
+for some discussion.
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/committers.py:
+
+2011-12-16 Dean Jackson
+
Add webkit-bug-impor...@group.apple.com to accounts
so that it autocompletes in bugzilla.
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (103125 => 103126)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-12-17 00:01:22 UTC (rev 103125)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-12-17 00:07:23 UTC (rev 103126)
@@ -96,11 +96,10 @@
Account("Chromium Compositor Bugs", ["cc-b...@google.com"], ""),
Account("David Levin", ["levin+thread...@chromium.org"], ""),
Account("David Levin", ["levin+watchl...@chromium.org"], ""),
-Account("Radar WebKit Bug Importer", ["webkit-bug-impor...@group.apple.com"], "radar"),
]
-# This is a list of people who are neither committers nor reviewers, but get
+# This is a list of people (or bots) who are neither committers nor reviewers, but get
# frequently CC'ed by others on Bugzilla bugs, so their names should be
# supported by autocomplete. No review needed to add to the list.
@@ -138,6 +137,7 @@
Contributor("Oliver Varga", ["voli...@inf.u-szeged.hu", "varga.oli...@stud.u-szeged.hu"], "TwistO"),
Contributor("Peter Gal", "galpe...@inf.u-szeged.hu", "elecro"),
Contributor("Peter Linss", "peter.li...@hp.com", "plinss"),
+Contributor("Radar WebKit Bug Importer", ["webkit-bug-impor...@group.apple.com"], "radar"),
Contributor("Shawn Singh", "shawnsi...@chromium.org", "shawnsingh"),
Contributor("Tab Atkins", ["tabatk...@google.com", "jackalm...@gmail.com"], "tabatkins"),
Contributor("Tamas Czene", ["tcz...@inf.u-szeged.hu", "czene.ta...@stud.u-szeged.hu"], "tczene"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103124] trunk/Source/WebKit/chromium
Title: [103124] trunk/Source/WebKit/chromium
Revision 103124
Author jam...@google.com
Date 2011-12-16 16:01:15 -0800 (Fri, 16 Dec 2011)
Log Message
[chromium] Remove WebCString's dependency on WebCore
https://bugs.webkit.org/show_bug.cgi?id=74761
Reviewed by Darin Fisher.
Remove WebCString::fromUTF16(), which are never called, and implement WebCString::utf16() using WTF instead of
WebCore/platform/text/TextEncoding.
* public/platform/WebCString.h:
* src/WebCString.cpp:
(WebKit::WebCString::utf16):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebCString.h
trunk/Source/WebKit/chromium/src/WebCString.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (103123 => 103124)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 23:59:01 UTC (rev 103123)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-17 00:01:15 UTC (rev 103124)
@@ -1,3 +1,17 @@
+2011-12-16 James Robinson
+
+[chromium] Remove WebCString's dependency on WebCore
+https://bugs.webkit.org/show_bug.cgi?id=74761
+
+Reviewed by Darin Fisher.
+
+Remove WebCString::fromUTF16(), which are never called, and implement WebCString::utf16() using WTF instead of
+WebCore/platform/text/TextEncoding.
+
+* public/platform/WebCString.h:
+* src/WebCString.cpp:
+(WebKit::WebCString::utf16):
+
2011-12-16 Ryosuke Niwa
Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
Modified: trunk/Source/WebKit/chromium/public/platform/WebCString.h (103123 => 103124)
--- trunk/Source/WebKit/chromium/public/platform/WebCString.h 2011-12-16 23:59:01 UTC (rev 103123)
+++ trunk/Source/WebKit/chromium/public/platform/WebCString.h 2011-12-17 00:01:15 UTC (rev 103124)
@@ -89,9 +89,6 @@
WEBKIT_EXPORT WebString utf16() const;
-WEBKIT_EXPORT static WebCString fromUTF16(const WebUChar* data, size_t length);
-WEBKIT_EXPORT static WebCString fromUTF16(const WebUChar* data);
-
#if WEBKIT_IMPLEMENTATION
WebCString(const WTF::CString&);
WebCString& operator=(const WTF::CString&);
@@ -113,12 +110,6 @@
size_t len = length();
return len ? std::string(data(), len) : std::string();
}
-
-template
-static WebCString fromUTF16(const UTF16String& s)
-{
-return fromUTF16(s.data(), s.length());
-}
#endif
private:
Modified: trunk/Source/WebKit/chromium/src/WebCString.cpp (103123 => 103124)
--- trunk/Source/WebKit/chromium/src/WebCString.cpp 2011-12-16 23:59:01 UTC (rev 103123)
+++ trunk/Source/WebKit/chromium/src/WebCString.cpp 2011-12-17 00:01:15 UTC (rev 103124)
@@ -31,7 +31,6 @@
#include "config.h"
#include "platform/WebCString.h"
-#include "TextEncoding.h"
#include "platform/WebString.h"
#include
@@ -91,23 +90,9 @@
WebString WebCString::utf16() const
{
-return WebCore::UTF8Encoding().decode(data(), length());
+return WebString::fromUTF8(data(), length());
}
-WebCString WebCString::fromUTF16(const WebUChar* data, size_t length)
-{
-return WebCore::UTF8Encoding().encode(
-data, length, WebCore::QuestionMarksForUnencodables);
-}
-
-WebCString WebCString::fromUTF16(const WebUChar* data)
-{
-size_t len = 0;
-while (data[len] != WebUChar(0))
-len++;
-return fromUTF16(data, len);
-}
-
WebCString::WebCString(const WTF::CString& s)
: m_private(static_cast(s.buffer()))
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103123] trunk/LayoutTests
Title: [103123] trunk/LayoutTests Revision 103123 Author e...@google.com Date 2011-12-16 15:59:01 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Mark CG failures for editing tests from r103073 https://bugs.webkit.org/show_bug.cgi?id=74726 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103122 => 103123) --- trunk/LayoutTests/ChangeLog 2011-12-16 23:45:29 UTC (rev 103122) +++ trunk/LayoutTests/ChangeLog 2011-12-16 23:59:01 UTC (rev 103123) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] Mark CG failures for editing tests from r103073 +https://bugs.webkit.org/show_bug.cgi?id=74726 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Ryosuke Niwa invalidateNodeListsCacheAfterAttributeChanged has too many callers Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103122 => 103123) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 23:45:29 UTC (rev 103122) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 23:59:01 UTC (rev 103123) @@ -4037,6 +4037,12 @@ BUGWK74688 : fast/css/bidi-override-in-anonymous-block.html = TEXT +BUGWK74726 CPU-CG : fast/forms/input-text-scroll-left-on-blur.html = IMAGE +BUGWK74726 LEOPARD CPU-CG : editing/input/caret-at-the-edge-of-contenteditable.html = IMAGE +BUGWK74726 LEOPARD CPU-CG : editing/input/caret-at-the-edge-of-input.html = IMAGE +BUGWK74726 LEOPARD CPU-CG : editing/input/reveal-caret-of-multiline-contenteditable.html = IMAGE +BUGWK74726 LEOPARD CPU-CG : editing/input/reveal-caret-of-multiline-input.html = IMAGE + BUGWK74731 : compositing/reflections/reflection-positioning2.html = PASS IMAGE BUGWK74746 : fast/filesystem/workers/file-from-file-entry-sync.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103122] trunk/Source/WebCore
Title: [103122] trunk/Source/WebCore
Revision 103122
Author kl...@webkit.org
Date 2011-12-16 15:45:29 -0800 (Fri, 16 Dec 2011)
Log Message
Unreviewed debug build fix after r103115.
* dom/Document.cpp:
(WebCore::Document::cachedCollection):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (103121 => 103122)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 23:43:40 UTC (rev 103121)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 23:45:29 UTC (rev 103122)
@@ -1,3 +1,10 @@
+2011-12-16 Andreas Kling
+
+Unreviewed debug build fix after r103115.
+
+* dom/Document.cpp:
+(WebCore::Document::cachedCollection):
+
2011-12-16 Mark Hahnenberg
Windows test fix
Modified: trunk/Source/WebCore/dom/Document.cpp (103121 => 103122)
--- trunk/Source/WebCore/dom/Document.cpp 2011-12-16 23:43:40 UTC (rev 103121)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-12-16 23:45:29 UTC (rev 103122)
@@ -4192,7 +4192,7 @@
const RefPtr& Document::cachedCollection(CollectionType type)
{
-ASSERT(type < NumUnnamedDocumentCachedTypes);
+ASSERT(static_cast(type) < NumUnnamedDocumentCachedTypes);
if (!m_collections[type])
m_collections[type] = HTMLCollection::createForCachingOnDocument(this, type);
return m_collections[type];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103121] trunk/Source
Title: [103121] trunk/Source
Revision 103121
Author mhahnenb...@apple.com
Date 2011-12-16 15:43:40 -0800 (Fri, 16 Dec 2011)
Log Message
Windows test fix
Source/WebCore:
No new tests.
Unreviewed test fix. All Windows tests were crashing when objects who were pointing to
static data members across DLL boundaries were getting garbage in their pointers.
* WebCore.exp.in:
* bindings/js/JSDOMWrapper.cpp:
* bindings/js/JSDOMWrapper.h:
Source/WebKit2:
Unreviewed test fix. All Windows tests were crashing when objects who were pointing to
static data members across DLL boundaries were getting garbage in their pointers.
* win/WebKit2.def:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/bindings/js/JSDOMWrapper.cpp
trunk/Source/WebCore/bindings/js/JSDOMWrapper.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
Diff
Modified: trunk/Source/WebCore/ChangeLog (103120 => 103121)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 23:43:40 UTC (rev 103121)
@@ -1,3 +1,16 @@
+2011-12-16 Mark Hahnenberg
+
+Windows test fix
+
+No new tests.
+
+Unreviewed test fix. All Windows tests were crashing when objects who were pointing to
+static data members across DLL boundaries were getting garbage in their pointers.
+
+* WebCore.exp.in:
+* bindings/js/JSDOMWrapper.cpp:
+* bindings/js/JSDOMWrapper.h:
+
2011-12-16 Ryosuke Niwa
Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
Modified: trunk/Source/WebCore/WebCore.exp.in (103120 => 103121)
--- trunk/Source/WebCore/WebCore.exp.in 2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-12-16 23:43:40 UTC (rev 103121)
@@ -261,7 +261,6 @@
__ZN7WebCore12IconDatabase5closeEv
__ZN7WebCore12IconDatabase9setClientEPNS_18IconDatabaseClientE
__ZN7WebCore12IconDatabaseC1Ev
-__ZN7WebCore12JSDOMWrapper6s_infoE
__ZN7WebCore12PopupMenuMacC1EPNS_15PopupMenuClientE
__ZN7WebCore12PrintContext12pagePropertyEPNS_5FrameEPKci
__ZN7WebCore12PrintContext13numberOfPagesEPNS_5FrameERKNS_9FloatSizeE
Modified: trunk/Source/WebCore/bindings/js/JSDOMWrapper.cpp (103120 => 103121)
--- trunk/Source/WebCore/bindings/js/JSDOMWrapper.cpp 2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/bindings/js/JSDOMWrapper.cpp 2011-12-16 23:43:40 UTC (rev 103121)
@@ -34,6 +34,4 @@
ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSDOMWrapper);
-const ClassInfo JSDOMWrapper::s_info = { "JSDOMWrapper", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSDOMWrapper) };
-
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/js/JSDOMWrapper.h (103120 => 103121)
--- trunk/Source/WebCore/bindings/js/JSDOMWrapper.h 2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/bindings/js/JSDOMWrapper.h 2011-12-16 23:43:40 UTC (rev 103121)
@@ -42,13 +42,6 @@
return globalObject()->scriptExecutionContext();
}
-static const JSC::ClassInfo s_info;
-
-static JSC::Structure* createStructure(JSC::JSGlobalData& globalData, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)
-{
-return JSC::Structure::create(globalData, globalObject, prototype, JSC::TypeInfo(JSC::ObjectType, StructureFlags), &s_info);
-}
-
protected:
explicit JSDOMWrapper(JSC::Structure* structure, JSC::JSGlobalObject* globalObject)
: JSNonFinalObject(globalObject->globalData(), structure)
Modified: trunk/Source/WebKit2/ChangeLog (103120 => 103121)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 23:43:40 UTC (rev 103121)
@@ -1,3 +1,12 @@
+2011-12-16 Mark Hahnenberg
+
+Windows test fix
+
+Unreviewed test fix. All Windows tests were crashing when objects who were pointing to
+static data members across DLL boundaries were getting garbage in their pointers.
+
+* win/WebKit2.def:
+
2011-12-16 Ryosuke Niwa
Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
Modified: trunk/Source/WebKit2/win/WebKit2.def (103120 => 103121)
--- trunk/Source/WebKit2/win/WebKit2.def 2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebKit2/win/WebKit2.def 2011-12-16 23:43:40 UTC (rev 103121)
@@ -168,7 +168,6 @@
?paintControlTints@FrameView@WebCore@@AAEXXZ
?rangeFromLocationAndLength@TextIterator@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@PAVElement@2@HH_N@Z
?removeShadowRoot@Element@WebCore@@QAEXXZ
-?s_info@JSDOMWrapper@WebCore@@2UClassInfo@JSC@@B
?scriptExecutionContext@JSDOMGlobalObject@WebCore@@QBEPAVScriptExecutionContext@2@XZ
?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z
?setShouldLayoutFixedElementsRelativeToFrame@FrameView@WebCore@@QAEX_N@Z
___
webkit-changes mail
[webkit-changes] [103119] trunk/Source
Title: [103119] trunk/Source Revision 103119 Author rn...@webkit.org Date 2011-12-16 15:34:39 -0800 (Fri, 16 Dec 2011) Log Message Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step https://bugs.webkit.org/show_bug.cgi?id=74748 Reviewed by Eric Seidel. Source/WebCore: Renamed registerCommandForUndo and registerCommandForRedo to registerUndoStep and registerRedoStep respectively. * editing/Editor.cpp: (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing): * loader/EmptyClients.h: (WebCore::EmptyEditorClient::registerUndoStep): (WebCore::EmptyEditorClient::registerRedoStep): * page/EditorClient.h: Source/WebKit/chromium: * src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::registerUndoStep): (WebKit::EditorClientImpl::registerRedoStep): * src/EditorClientImpl.h: Source/WebKit/efl: * WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerUndoStep): (WebCore::EditorClientEfl::registerRedoStep): * WebCoreSupport/EditorClientEfl.h: Source/WebKit/gtk: * WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::registerUndoStep): (WebKit::EditorClient::registerRedoStep): * WebCoreSupport/EditorClientGtk.h: Source/WebKit/mac: * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::registerUndoOrRedoStep): (WebEditorClient::registerUndoStep): (WebEditorClient::registerRedoStep): Source/WebKit/qt: * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::registerUndoStep): (WebCore::EditorClientQt::registerRedoStep): * WebCoreSupport/EditorClientQt.h: Source/WebKit/win: * WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::registerUndoStep): (WebEditorClient::registerRedoStep): * WebCoreSupport/WebEditorClient.h: Source/WebKit/wince: * WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::registerUndoStep): (WebKit::EditorClientWinCE::registerRedoStep): * WebCoreSupport/EditorClientWinCE.h: Source/WebKit/wx: * WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::registerUndoStep): (WebCore::EditorClientWx::registerRedoStep): * WebKitSupport/EditorClientWx.h: Source/WebKit2: * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::registerUndoStep): (WebKit::WebEditorClient::registerRedoStep): * WebProcess/WebCoreSupport/WebEditorClient.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebCore/loader/EmptyClients.h trunk/Source/WebCore/page/EditorClient.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp trunk/Source/WebKit/chromium/src/EditorClientImpl.h trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h trunk/Source/WebKit/wince/ChangeLog trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h trunk/Source/WebKit/wx/ChangeLog trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.cpp trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h Diff Modified: trunk/Source/WebCore/ChangeLog (103118 => 103119) --- trunk/Source/WebCore/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119) @@ -1,3 +1,22 @@ +2011-12-16 Ryosuke Niwa + +Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step +https://bugs.webkit.org/show_bug.cgi?id=74748 + +Reviewed by Eric Seidel. + +Renamed registerCommandForUndo and registerCommandForRedo to +registerUndoStep and registerRedoStep respectively. + +* editing/Editor.cpp: +(WebCore::Editor::appliedEditing): +(WebCore::Editor::unappliedEditing): +(WebCore::Editor::reappliedEditing): +* loader/EmptyClients.h: +(WebCore::EmptyEditorClient::registerUndoStep): +(WebCore::EmptyEditorClient::registerRedoStep): +* page/EditorClient.h: + 2011-12-16 Tim Horton Canvas should respect backing store scale ratio when used as drawImage() source Modified: trunk/Source/WebCore/editing/Editor.cpp (103118 => 103119)
[webkit-changes] [103118] trunk/Source/WebCore
Title: [103118] trunk/Source/WebCore
Revision 103118
Author timothy_hor...@apple.com
Date 2011-12-16 15:29:12 -0800 (Fri, 16 Dec 2011)
Log Message
Canvas should respect backing store scale ratio when used as drawImage() source
https://bugs.webkit.org/show_bug.cgi?id=74758
Reviewed by Simon Fraser.
Interpret the source rectangle passed into drawImage() when using a Canvas source in the source Canvas coordinate space,
instead of in the backing store coordinate space, without changing the behavior of drawImage(canvas, x, y).
No new tests.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertDeviceToLogical):
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.h
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (103117 => 103118)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 23:26:31 UTC (rev 103117)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
@@ -1,3 +1,22 @@
+2011-12-16 Tim Horton
+
+Canvas should respect backing store scale ratio when used as drawImage() source
+https://bugs.webkit.org/show_bug.cgi?id=74758
+
+
+Reviewed by Simon Fraser.
+
+Interpret the source rectangle passed into drawImage() when using a Canvas source in the source Canvas coordinate space,
+instead of in the backing store coordinate space, without changing the behavior of drawImage(canvas, x, y).
+
+No new tests.
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::convertDeviceToLogical):
+* html/HTMLCanvasElement.h:
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::drawImage):
+
2011-12-16 Anders Carlsson
Subpixel antialiasing not working in tiled mode
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (103117 => 103118)
--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2011-12-16 23:26:31 UTC (rev 103117)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2011-12-16 23:29:12 UTC (rev 103118)
@@ -402,6 +402,13 @@
return FloatSize(width, height);
}
+FloatSize HTMLCanvasElement::convertDeviceToLogical(const FloatSize& deviceSize) const
+{
+float width = ceilf(deviceSize.width() / m_deviceScaleFactor);
+float height = ceilf(deviceSize.height() / m_deviceScaleFactor);
+return FloatSize(width, height);
+}
+
SecurityOrigin* HTMLCanvasElement::securityOrigin() const
{
return document()->securityOrigin();
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.h (103117 => 103118)
--- trunk/Source/WebCore/html/HTMLCanvasElement.h 2011-12-16 23:26:31 UTC (rev 103117)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.h 2011-12-16 23:29:12 UTC (rev 103118)
@@ -115,6 +115,8 @@
FloatRect convertLogicalToDevice(const FloatRect&) const;
FloatSize convertLogicalToDevice(const FloatSize&) const;
+FloatSize convertDeviceToLogical(const FloatSize&) const;
+
SecurityOrigin* securityOrigin() const;
void setOriginTainted() { m_originClean = false; }
bool originClean() const { return m_originClean; }
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (103117 => 103118)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2011-12-16 23:26:31 UTC (rev 103117)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2011-12-16 23:29:12 UTC (rev 103118)
@@ -1361,7 +1361,15 @@
ec = TYPE_MISMATCH_ERR;
return;
}
-drawImage(canvas, x, y, canvas->width(), canvas->height(), ec);
+
+// In order to emulate drawing the result of toDataURL() into the canvas, we
+// need to deflate the size of the source rectangle by the source canvas's
+// backing store scale factor.
+// See https://www.w3.org/Bugs/Public/show_bug.cgi?id=15041 for motivation.
+
+FloatSize logicalSize = canvas->convertDeviceToLogical(canvas->size());
+
+drawImage(canvas, 0, 0, logicalSize.width(), logicalSize.height(), x, y, canvas->width(), canvas->height(), ec);
}
void CanvasRenderingContext2D::drawImage(HTMLCanvasElement* canvas,
@@ -1430,18 +1438,21 @@
sourceCanvas->makeRenderingResultsAvailable();
#endif
+// drawImageBuffer's srcRect is in buffer pixels (backing store pixels, in our case), dstRect is in canvas pixels.
+FloatRect bufferSrcRect(sourceCanvas->convertLogicalToDevice(srcRect));
+
if (rectContainsCanvas(dstRect)) {
-c->drawImageBuffer(buffer, ColorSpaceDeviceRGB, dstRect, srcRect, state().m_globalComposite);
+c->drawImageBuffer(buffer, ColorSpaceDeviceRGB, dstRect, bufferSrcRect, state().m_globalComposite);
didDrawEntireCanvas();
} else if (isFullCanvasCompositeMode(state().m_globalComposite)) {
-
[webkit-changes] [103117] trunk/Source/WebCore
Title: [103117] trunk/Source/WebCore
Revision 103117
Author ander...@apple.com
Date 2011-12-16 15:26:31 -0800 (Fri, 16 Dec 2011)
Log Message
Subpixel antialiasing not working in tiled mode
https://bugs.webkit.org/show_bug.cgi?id=74759
Reviewed by Simon Fraser.
Call setContentsOpaque(true) on the main frame render view layer so subpixel aa will be used
when drawing text into that layer.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (103116 => 103117)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 23:15:10 UTC (rev 103116)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 23:26:31 UTC (rev 103117)
@@ -1,3 +1,16 @@
+2011-12-16 Anders Carlsson
+
+Subpixel antialiasing not working in tiled mode
+https://bugs.webkit.org/show_bug.cgi?id=74759
+
+Reviewed by Simon Fraser.
+
+Call setContentsOpaque(true) on the main frame render view layer so subpixel aa will be used
+when drawing text into that layer.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
+
2011-12-16 Ryosuke Niwa
invalidateNodeListsCacheAfterAttributeChanged has too many callers
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (103116 => 103117)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-12-16 23:15:10 UTC (rev 103116)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-12-16 23:26:31 UTC (rev 103117)
@@ -139,8 +139,10 @@
#endif
m_graphicsLayer = createGraphicsLayer(layerName);
-if (m_isMainFrameRenderViewLayer)
+if (m_isMainFrameRenderViewLayer) {
+m_graphicsLayer->setContentsOpaque(true);
m_graphicsLayer->setAppliesPageScale();
+}
updateLayerOpacity(renderer()->style());
updateLayerTransform(renderer()->style());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103116] trunk
Title: [103116] trunk Revision 103116 Author rn...@webkit.org Date 2011-12-16 15:15:10 -0800 (Fri, 16 Dec 2011) Log Message invalidateNodeListsCacheAfterAttributeChanged has too many callers https://bugs.webkit.org/show_bug.cgi?id=74692 Reviewed by Sam Weinig. Source/WebCore: Call invalidateNodeListsCacheAfterAttributeChanged in Element::updateAfterAttributeChanged instead of parsedMappedAttribute of various elements. Also make invalidateNodeListsCacheAfterAttributeChanged take the qualified name of the changed attribute so that we can exit early when the changed attribute isn't one of attributes we care. In addition, added a missing call to invalidateNodeListsCacheAfterAttributeChanged in Attr::setValue. Test: fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html * dom/Attr.cpp: (WebCore::Attr::childrenChanged): * dom/Element.cpp: (WebCore::Element::updateAfterAttributeChanged): * dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::addAttribute): (WebCore::NamedNodeMap::removeAttribute): * dom/Node.cpp: (WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): * dom/Node.h: * dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute): * html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): * html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::parseMappedAttribute): * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): * html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute): * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): * html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::parseMappedAttribute): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): * html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::parseMappedAttribute): LayoutTests: Add a regression test for setting Attr's value. WebKit should invalidate the cache as needed. * fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt: Added. * fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Attr.cpp trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/NamedNodeMap.cpp trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/dom/StyledElement.cpp trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/html/HTMLAppletElement.cpp trunk/Source/WebCore/html/HTMLElement.cpp trunk/Source/WebCore/html/HTMLEmbedElement.cpp trunk/Source/WebCore/html/HTMLFormElement.cpp trunk/Source/WebCore/html/HTMLFrameElementBase.cpp trunk/Source/WebCore/html/HTMLIFrameElement.cpp trunk/Source/WebCore/html/HTMLImageElement.cpp trunk/Source/WebCore/html/HTMLMapElement.cpp trunk/Source/WebCore/html/HTMLMetaElement.cpp trunk/Source/WebCore/html/HTMLObjectElement.cpp trunk/Source/WebCore/html/HTMLParamElement.cpp Added Paths trunk/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt trunk/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html Diff Modified: trunk/LayoutTests/ChangeLog (103115 => 103116) --- trunk/LayoutTests/ChangeLog 2011-12-16 23:11:11 UTC (rev 103115) +++ trunk/LayoutTests/ChangeLog 2011-12-16 23:15:10 UTC (rev 103116) @@ -1,3 +1,15 @@ +2011-12-16 Ryosuke Niwa + +invalidateNodeListsCacheAfterAttributeChanged has too many callers +https://bugs.webkit.org/show_bug.cgi?id=74692 + +Reviewed by Sam Weinig. + +Add a regression test for setting Attr's value. WebKit should invalidate the cache as needed. + +* fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt: Added. +* fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html: Added. + 2011-12-16 Andreas Kling Cache and reuse HTMLCollections exposed by Document. Added: trunk/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt (0 => 103116) --- trunk/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt 2011-12-16 23:15:10 UTC (rev 103116) @@ -0,0 +1,12 @@ +This tests setting the value of an attribute node after caching childNodes of the attribute node. +The cache should be cleared and childNodes[0].data should return the new value. +You should see PASS below: + +PASS nameAttrNode.childNodes.length is 1 +PASS nameAttrNode.childNodes[0] is oldValue +PASS nameAttrNode.childNodes[0].data is "oldName" + +PASS nameAttrNode.value = 'newName'; nameAttrNode
[webkit-changes] [103115] trunk
Title: [103115] trunk Revision 103115 Author kl...@webkit.org Date 2011-12-16 15:11:11 -0800 (Fri, 16 Dec 2011) Log Message Cache and reuse HTMLCollections exposed by Document. Reviewed by Antti Koivisto. Source/WebCore: Let Document cache the various HTMLCollection objects it exposes. This is a behavior change in two ways: 1) The lifetime of returned collections is now tied to the lifetime of the Document. This matches the behavior of Firefox and Opera. 2) The cached collections returned by document are now exactly equal to those returned by subsequent calls to the same getters. This reduces memory consumption by ~800 kB (on 64-bit) when loading the full HTML5 spec. document.links was called 34001 times, yielding 34001 separate HTMLCollections, and now we only need 1. The document.all collection retains the old behavior, as caching it will be a bit more complicated. To avoid a reference cycle between Document and HTMLCollection, collections that are cached on Document do not retained their base node pointer (controlled by a m_baseIsRetained flag.) Tests: fast/dom/document-collection-idempotence.html fast/dom/gc-9.html * dom/Document.cpp: (WebCore::Document::detach): (WebCore::Document::cachedCollection): (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::plugins): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): * dom/Document.h: * html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::createForCachingOnDocument): (WebCore::HTMLCollection::~HTMLCollection): (WebCore::HTMLCollection::itemAfter): * html/HTMLCollection.h: (WebCore::HTMLCollection::base): LayoutTests: Added a test to verify that collections returned by document (excluding .all) are equal to the collections returned by subsequent calls to the same getters. Also update fast/dom/gc-9.html to cover the new lifetime behavior of HTMLCollection objects returned by document. * fast/dom/document-collection-idempotence-expected.txt: Added. * fast/dom/document-collection-idempotence.html: Added. * fast/dom/gc-9-expected.txt: * fast/dom/gc-9.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/gc-9-expected.txt trunk/LayoutTests/fast/dom/gc-9.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/html/HTMLCollection.cpp trunk/Source/WebCore/html/HTMLCollection.h Added Paths trunk/LayoutTests/fast/dom/document-collection-idempotence-expected.txt trunk/LayoutTests/fast/dom/document-collection-idempotence.html Diff Modified: trunk/LayoutTests/ChangeLog (103114 => 103115) --- trunk/LayoutTests/ChangeLog 2011-12-16 23:05:23 UTC (rev 103114) +++ trunk/LayoutTests/ChangeLog 2011-12-16 23:11:11 UTC (rev 103115) @@ -1,3 +1,21 @@ +2011-12-16 Andreas Kling + +Cache and reuse HTMLCollections exposed by Document. + + +Reviewed by Antti Koivisto. + +Added a test to verify that collections returned by document (excluding .all) +are equal to the collections returned by subsequent calls to the same getters. + +Also update fast/dom/gc-9.html to cover the new lifetime behavior of +HTMLCollection objects returned by document. + +* fast/dom/document-collection-idempotence-expected.txt: Added. +* fast/dom/document-collection-idempotence.html: Added. +* fast/dom/gc-9-expected.txt: +* fast/dom/gc-9.html: + 2011-12-16 Adrienne Walker [chromium] Mark more worker regressions from r103095 Added: trunk/LayoutTests/fast/dom/document-collection-idempotence-expected.txt (0 => 103115) --- trunk/LayoutTests/fast/dom/document-collection-idempotence-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/document-collection-idempotence-expected.txt 2011-12-16 23:11:11 UTC (rev 103115) @@ -0,0 +1,18 @@ +This test verifies that the HTMLCollection getters on document (excluding .all) returns the same object when called repeatedly. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS document.all === document.all is false +PASS document.images === document.images is true +PASS document.embeds === document.embeds is true +PASS document.plugins === document.plugins is true +PASS document.applets === document.applets is true +PASS document.links === document.links is true +PASS document.forms === document.forms is true +PASS document.anchors === document.anchors is true +PASS document.scripts === document.scripts is true +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/dom/document-collection-idempotence.html (0 => 103115) --- trunk/LayoutTests/fast/dom/document-collection-idempotence.html (rev 0) +++ trunk/LayoutTests/fast/dom/docu
[webkit-changes] [103114] trunk/Source
Title: [103114] trunk/Source Revision 103114 Author ander...@apple.com Date 2011-12-16 15:05:23 -0800 (Fri, 16 Dec 2011) Log Message Add a pretty dumb tile cache to WebTileCacheLayer https://bugs.webkit.org/show_bug.cgi?id=74753 Reviewed by Simon Fraser. Source/WebCore: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::requiresTiledLayer): If a layer is a tile cache layer, we never want to swap it out for a tiled layer. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Assert that we don't have a tile cache layer. * platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::PlatformCALayer): If we have a tile cache layer, add its tile container to the list of custom sublayers. * platform/graphics/ca/mac/TileCache.h: Added. (WebCore::TileCache::tileContainerLayer): Return the tile container layer. * platform/graphics/ca/mac/TileCache.mm: Added. (WebCore::TileCache::tileCacheLayerBoundsChanged): Resize the tile grid if necessary. (WebCore::TileCache::setNeedsDisplayInRect): Invalidate the necessary tiles. (WebCore::TileCache::drawLayer): Set up the transform and draw the layer. (WebCore::TileCache::getTileRangeForRect): Given a rect, return the range of tiles that it covers. (WebCore::TileCache::numTilesForGridSize): Given a size, return how many tiles are needed to completely cover it. (WebCore::TileCache::resizeTileGrid): Create new tile layers if needed, or reuse already existing ones. (WebCore::TileCache::tileLayerAtPosition): Given a position in the grid, return the tile layer. (WebCore::TileCache::createTileLayer): Create a WebTileLayer and set it up. * platform/graphics/ca/mac/WebTileCacheLayer.h: * platform/graphics/ca/mac/WebTileCacheLayer.mm: (-[WebTileCacheLayer setBounds:]): (-[WebTileCacheLayer setNeedsDisplayInRect:]): (-[WebTileCacheLayer tileContainerLayer]): Call down to the tile cache object. * platform/graphics/ca/mac/WebTileLayer.h: Added. * platform/graphics/ca/mac/WebTileLayer.mm: Added. (-[WebTileLayer drawInContext:]): Ask the tile cache to draw the given layer. (-[WebTileLayer setTileCache:WebCore::]): Source/WebKit2: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::flushLayers): Always do a layout here, to prevent an ASSERT(!needsLayout()) when painting. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm trunk/Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h trunk/Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Added Paths trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.h trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm trunk/Source/WebCore/platform/graphics/ca/mac/WebTileLayer.h trunk/Source/WebCore/platform/graphics/ca/mac/WebTileLayer.mm Diff Modified: trunk/Source/WebCore/ChangeLog (103113 => 103114) --- trunk/Source/WebCore/ChangeLog 2011-12-16 22:54:29 UTC (rev 103113) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 23:05:23 UTC (rev 103114) @@ -1,3 +1,66 @@ +2011-12-16 Anders Carlsson + +Add a pretty dumb tile cache to WebTileCacheLayer +https://bugs.webkit.org/show_bug.cgi?id=74753 + +Reviewed by Simon Fraser. + +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/ca/GraphicsLayerCA.cpp: +(WebCore::GraphicsLayerCA::requiresTiledLayer): +If a layer is a tile cache layer, we never want to swap it out for a tiled layer. + +(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): +Assert that we don't have a tile cache layer. + +* platform/graphics/ca/mac/PlatformCALayerMac.mm: +(PlatformCALayer::PlatformCALayer): +If we have a tile cache layer, add its tile container to the list of custom sublayers. + +* platform/graphics/ca/mac/TileCache.h: Added. +(WebCore::TileCache::tileContainerLayer): +Return the tile container layer. + +* platform/graphics/ca/mac/TileCache.mm: Added. +(WebCore::TileCache::tileCacheLayerBoundsChanged): +Resize the tile grid if necessary. + +(WebCore::TileCache::setNeedsDisplayInRect): +Invalidate the necessary tiles. + +(WebCore::TileCache::drawLayer): +Set up the transform and draw the layer. + +(WebCore::TileCache::getTileRangeForRect): +Given a rect, return the range of tiles that it covers. + +(WebCore::TileCache::numTilesForGridSize): +Given a size, return how many tiles are needed to completely cover it. + +(WebCore::TileCache::resizeTileGrid): +Create new tile layers if needed, or reuse already existing ones. + +(WebCore::TileCache::tileLay
[webkit-changes] [103113] trunk/LayoutTests
Title: [103113] trunk/LayoutTests Revision 103113 Author e...@google.com Date 2011-12-16 14:54:29 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Mark more worker regressions from r103095 https://bugs.webkit.org/show_bug.cgi?id=74746 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103112 => 103113) --- trunk/LayoutTests/ChangeLog 2011-12-16 22:46:17 UTC (rev 103112) +++ trunk/LayoutTests/ChangeLog 2011-12-16 22:54:29 UTC (rev 103113) @@ -1,5 +1,14 @@ 2011-12-16 Adrienne Walker +[chromium] Mark more worker regressions from r103095 +https://bugs.webkit.org/show_bug.cgi?id=74746 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-12-16 Adrienne Walker + [chromium] Mark many SVG tests on Mac failing after r103091 https://bugs.webkit.org/show_bug.cgi?id=53378 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103112 => 103113) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:46:17 UTC (rev 103112) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:54:29 UTC (rev 103113) @@ -4040,3 +4040,5 @@ BUGWK74731 : compositing/reflections/reflection-positioning2.html = PASS IMAGE BUGWK74746 : fast/filesystem/workers/file-from-file-entry-sync.html = PASS CRASH +BUGWK74746 WIN : http/tests/xmlhttprequest/workers/methods.html = FAIL +BUGWK74746 WIN : http/tests/xmlhttprequest/workers/methods-async.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103111] trunk/LayoutTests
Title: [103111] trunk/LayoutTests Revision 103111 Author e...@google.com Date 2011-12-16 14:38:01 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Mark many SVG tests on Mac failing after r103091 https://bugs.webkit.org/show_bug.cgi?id=53378 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103110 => 103111) --- trunk/LayoutTests/ChangeLog 2011-12-16 22:30:49 UTC (rev 103110) +++ trunk/LayoutTests/ChangeLog 2011-12-16 22:38:01 UTC (rev 103111) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] Mark many SVG tests on Mac failing after r103091 +https://bugs.webkit.org/show_bug.cgi?id=53378 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Adam Barth doesn't parse correctly Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103110 => 103111) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:30:49 UTC (rev 103110) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:38:01 UTC (rev 103111) @@ -878,17 +878,27 @@ // (wrong baseline was committed). No idea about when it really started to fail. BUGCR52692 LINUX WIN : svg/W3C-SVG-1.1/animate-elem-80-t.svg = IMAGE+TEXT -// Windows needs rebaselining after 53378 patch. -BUGWK53378 WIN : svg/W3C-SVG-1.1/filters-example-01-b.svg = IMAGE +// Windows and Mac need rebaselining after 53378 patch. +BUGWK53378 WIN MAC : svg/W3C-SVG-1.1/filters-example-01-b.svg = IMAGE // This is a duplicate of BUGCR99500 below. //BUGWK53378 WIN : svg/batik/text/textProperties.svg = IMAGE -BUGWK53378 WIN : svg/clip-path/clip-in-mask.svg = IMAGE +BUGWK53378 MAC : svg/batik/text/textProperties.svg = IMAGE +BUGWK53378 WIN MAC : svg/clip-path/clip-in-mask.svg = IMAGE BUGWK53378 WIN : svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg = IMAGE+TEXT +BUGWK53378 MAC : svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg = IMAGE BUGWK53378 WIN : svg/clip-path/deep-nested-clip-in-mask-panning.svg = IMAGE+TEXT +BUGWK53378 MAC : svg/clip-path/deep-nested-clip-in-mask-panning.svg = IMAGE BUGWK53378 WIN : svg/clip-path/deep-nested-clip-in-mask.svg = IMAGE+TEXT -BUGWK53378 WIN : svg/clip-path/nested-clip-in-mask-image-based-clipping.svg = IMAGE -BUGWK53378 WIN : svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg = IMAGE -BUGWK53378 WIN : svg/clip-path/nested-clip-in-mask-path-based-clipping.svg = IMAGE +BUGWK53378 MAC : svg/clip-path/deep-nested-clip-in-mask.svg = IMAGE +BUGWK53378 WIN MAC : svg/clip-path/nested-clip-in-mask-image-based-clipping.svg = IMAGE +BUGWK53378 WIN MAC : svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg = IMAGE +BUGWK53378 WIN MAC : svg/clip-path/nested-clip-in-mask-path-based-clipping.svg = IMAGE +BUGWK53378 MAC : svg/batik/masking/maskRegions.svg = IMAGE +BUGWK53378 MAC : svg/clip-path/clip-path-childs-clipped.svg = IMAGE +BUGWK53378 MAC : svg/clip-path/clip-path-pixelation.svg = IMAGE +BUGWK53378 MAC : svg/custom/grayscale-gradient-mask.svg = IMAGE +BUGWK53378 MAC : svg/custom/absolute-sized-content-with-resources.xhtml = IMAGE +BUGWK53378 MAC : svg/zoom/page/zoom-mask-with-percentages.svg = IMAGE // Since r89233. May need a new baseline. // NOTE that this revision was rolled out, but it isn't clear whether we should remove these ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103110] trunk/Source/WebKit/mac
Title: [103110] trunk/Source/WebKit/mac Revision 103110 Author simon.fra...@apple.com Date 2011-12-16 14:30:49 -0800 (Fri, 16 Dec 2011) Log Message Fix a #elsif fumble in my earlier commit. * WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebHTMLView.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (103109 => 103110) --- trunk/Source/WebKit/mac/ChangeLog 2011-12-16 22:29:02 UTC (rev 103109) +++ trunk/Source/WebKit/mac/ChangeLog 2011-12-16 22:30:49 UTC (rev 103110) @@ -1,3 +1,10 @@ +2011-12-16 Simon Fraser + +Fix a #elsif fumble in my earlier commit. + +* WebView/WebHTMLView.mm: +(-[WebHTMLView attachRootLayer:]): + 2011-12-16 Ryosuke Niwa Only EditCommandComposition should implement unapply and reapply Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (103109 => 103110) --- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2011-12-16 22:29:02 UTC (rev 103109) +++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2011-12-16 22:30:49 UTC (rev 103110) @@ -5498,7 +5498,7 @@ #ifdef BUILDING_ON_LEOPARD [viewLayer setSublayerTransform:CATransform3DMakeScale(1, -1, 1)]; // setGeometryFlipped: doesn't exist on Leopard. [self _updateLayerHostingViewPosition]; -#elsif (BUILDING_ON_SNOW_LEOPARD || BUILDING_ON_LION) +#elif (defined(BUILDING_ON_SNOW_LEOPARD) || defined(BUILDING_ON_LION)) // Do geometry flipping here, which flips all the compositing layers so they are top-down. [viewLayer setGeometryFlipped:YES]; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103109] trunk
Title: [103109] trunk Revision 103109 Author aba...@webkit.org Date 2011-12-16 14:29:02 -0800 (Fri, 16 Dec 2011) Log Message doesn't parse correctly https://bugs.webkit.org/show_bug.cgi?id=74745 Reviewed by Eric Seidel. Source/WebCore: We were missing one place the spec tells us to set this bool. Tests: html5lib/runner.html * html/parser/HTMLTreeBuilder.cpp: LayoutTests: Show test progression. * html5lib/runner-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/html5lib/runner-expected.txt trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp Diff Modified: trunk/LayoutTests/ChangeLog (103108 => 103109) --- trunk/LayoutTests/ChangeLog 2011-12-16 22:28:38 UTC (rev 103108) +++ trunk/LayoutTests/ChangeLog 2011-12-16 22:29:02 UTC (rev 103109) @@ -1,3 +1,14 @@ +2011-12-16 Adam Barth + + doesn't parse correctly +https://bugs.webkit.org/show_bug.cgi?id=74745 + +Reviewed by Eric Seidel. + +Show test progression. + +* html5lib/runner-expected.txt: + 2011-12-16 Tony Chang Unreviewed, updating chromium expectations. Modified: trunk/LayoutTests/html5lib/runner-expected.txt (103108 => 103109) --- trunk/LayoutTests/html5lib/runner-expected.txt 2011-12-16 22:28:38 UTC (rev 103108) +++ trunk/LayoutTests/html5lib/runner-expected.txt 2011-12-16 22:29:02 UTC (rev 103109) @@ -156,22 +156,8 @@ resources/tests18.dat: PASS -resources/tests19.dat: -81 +resources/tests19.dat: PASS -Test 81 of 104 in resources/tests19.dat failed. Input: - -Got: -| -| -| -| -Expected: -| -| -| -| -| resources/tests20.dat: 31 Modified: trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt (103108 => 103109) --- trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt 2011-12-16 22:28:38 UTC (rev 103108) +++ trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt 2011-12-16 22:29:02 UTC (rev 103109) @@ -126,28 +126,8 @@ resources/tests2.dat: PASS -resources/tests3.dat: -12 +resources/tests3.dat: PASS -Test 12 of 24 in resources/tests3.dat failed. Input: - A -Got: -| -| -| -| -| -| " - -A" -Expected: -| -| -| -| -| -| " -A" resources/tests4.dat: PASS resources/tests5.dat: PASS @@ -176,22 +156,8 @@ resources/tests18.dat: PASS -resources/tests19.dat: -81 +resources/tests19.dat: PASS -Test 81 of 104 in resources/tests19.dat failed. Input: - -Got: -| -| -| -| -Expected: -| -| -| -| -| resources/tests20.dat: 31 Modified: trunk/Source/WebCore/ChangeLog (103108 => 103109) --- trunk/Source/WebCore/ChangeLog 2011-12-16 22:28:38 UTC (rev 103108) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 22:29:02 UTC (rev 103109) @@ -1,3 +1,16 @@ +2011-12-16 Adam Barth + + doesn't parse correctly +https://bugs.webkit.org/show_bug.cgi?id=74745 + +Reviewed by Eric Seidel. + +We were missing one place the spec tells us to set this bool. + +Tests: html5lib/runner.html + +* html/parser/HTMLTreeBuilder.cpp: + 2011-12-16 Jarred Nicholls Support HTML documents in XHR.responseXML Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (103108 => 103109) --- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-12-16 22:28:38 UTC (rev 103108) +++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-12-16 22:29:02 UTC (rev 103109) @@ -765,6 +765,7 @@ ASSERT(isParsingFragment()); return; } +m_framesetOk = false; m_tree.insertHTMLBodyStartTagInBody(token); return; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103108] trunk/Source/JavaScriptCore
Title: [103108] trunk/Source/_javascript_Core
Revision 103108
Author dba...@webkit.org
Date 2011-12-16 14:28:38 -0800 (Fri, 16 Dec 2011)
Log Message
Include BlackBerryPlatformLog.h instead of BlackBerryPlatformMisc.h
Rubber-stamped by Antonio Gomes.
BlackBerry::Platform::logV() is declared in BlackBerryPlatformLog.h. That is, it isn't
declared in BlackBerryPlatformMisc.h. Hence, we should include BlackBerryPlatformLog.h
instead of BlackBerryPlatformMisc.h.
* wtf/Assertions.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Assertions.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (103107 => 103108)
--- trunk/Source/_javascript_Core/ChangeLog 2011-12-16 22:24:33 UTC (rev 103107)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-12-16 22:28:38 UTC (rev 103108)
@@ -1,3 +1,15 @@
+2011-12-16 Daniel Bates
+
+Include BlackBerryPlatformLog.h instead of BlackBerryPlatformMisc.h
+
+Rubber-stamped by Antonio Gomes.
+
+BlackBerry::Platform::logV() is declared in BlackBerryPlatformLog.h. That is, it isn't
+declared in BlackBerryPlatformMisc.h. Hence, we should include BlackBerryPlatformLog.h
+instead of BlackBerryPlatformMisc.h.
+
+* wtf/Assertions.cpp:
+
2011-12-16 Mark Hahnenberg
De-virtualize destructors
Modified: trunk/Source/_javascript_Core/wtf/Assertions.cpp (103107 => 103108)
--- trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-12-16 22:24:33 UTC (rev 103107)
+++ trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-12-16 22:28:38 UTC (rev 103108)
@@ -56,7 +56,7 @@
#endif
#if PLATFORM(BLACKBERRY)
-#include
+#include
#endif
extern "C" {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103107] trunk/LayoutTests
Title: [103107] trunk/LayoutTests Revision 103107 Author t...@chromium.org Date 2011-12-16 14:24:33 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, updating chromium expectations. * platform/chromium/test_expectations.txt: fast/replaced/embed-display-none.html has been passing and fast/replaced/width100percent-textarea.html is flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103106 => 103107) --- trunk/LayoutTests/ChangeLog 2011-12-16 22:16:41 UTC (rev 103106) +++ trunk/LayoutTests/ChangeLog 2011-12-16 22:24:33 UTC (rev 103107) @@ -1,3 +1,10 @@ +2011-12-16 Tony Chang + +Unreviewed, updating chromium expectations. + +* platform/chromium/test_expectations.txt: fast/replaced/embed-display-none.html has been +passing and fast/replaced/width100percent-textarea.html is flaky. + 2011-12-16 Jarred Nicholls Support HTML documents in XHR.responseXML Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103106 => 103107) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:16:41 UTC (rev 103106) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:24:33 UTC (rev 103107) @@ -2339,7 +2339,6 @@ BUGCR54330 MAC : fast/forms/number/input-spinbutton-capturing.html = PASS TEXT BUGCR54331 MAC : fast/forms/number/input-number-events.html = PASS TEXT -BUGCR54333 LINUX WIN : fast/replaced/embed-display-none.html = PASS TIMEOUT // WebKit r67068 BUGWK45450 LINUX WIN : svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr.html = IMAGE @@ -4009,9 +4008,8 @@ BUGWK74157 LEOPARD : animations/cross-fade-webkit-mask-box-image.html = IMAGE+TEXT IMAGE BUGWK74157 LEOPARD : animations/cross-fade-webkit-mask-image.html = IMAGE+TEXT IMAGE +BUGWK74167 WIN LINUX : fast/replaced/width100percent-textarea.html = IMAGE PASS -BUGWK74167 WIN LINUX : fast/replaced/width100percent-textarea.html = IMAGE - BUGWK74317 LINUX : transitions/cross-fade-border-image.html = PASS CRASH BUGWK74357 SKIP : plugins/netscape-plugin-page-cache-works.html = TEXT TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103105] trunk/LayoutTests
Title: [103105] trunk/LayoutTests Revision 103105 Author e...@google.com Date 2011-12-16 14:09:38 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Mark file-from-file-entry-sync as crash after r103095 https://bugs.webkit.org/show_bug.cgi?id=74746 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103104 => 103105) --- trunk/LayoutTests/ChangeLog 2011-12-16 22:04:58 UTC (rev 103104) +++ trunk/LayoutTests/ChangeLog 2011-12-16 22:09:38 UTC (rev 103105) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] Mark file-from-file-entry-sync as crash after r103095 +https://bugs.webkit.org/show_bug.cgi?id=74746 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Adam Barth A doesn't parse correctly Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103104 => 103105) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:04:58 UTC (rev 103104) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 22:09:38 UTC (rev 103105) @@ -4030,3 +4030,5 @@ BUGWK74688 : fast/css/bidi-override-in-anonymous-block.html = TEXT BUGWK74731 : compositing/reflections/reflection-positioning2.html = PASS IMAGE + +BUGWK74746 : fast/filesystem/workers/file-from-file-entry-sync.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103103] trunk/Source/WebCore
Title: [103103] trunk/Source/WebCore
Revision 103103
Author simon.fra...@apple.com
Date 2011-12-16 13:49:33 -0800 (Fri, 16 Dec 2011)
Log Message
Allow a PlatformCALayer to own its own sublayers
https://bugs.webkit.org/show_bug.cgi?id=74744
Reviewed by Anders Carlsson.
GraphicsLayerCA rebuilds the sublayer list of CALayers, which would
blow away any custom layers that a PlatformCALayer wants to maintain
as children.
Make it possible for a PlatformLayerCA to indicate that it wants
a specific list of sublayers to be maintained as the first layers
in the child list.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateSublayerList):
* platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::customSublayers):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::PlatformCALayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (103102 => 103103)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 21:44:45 UTC (rev 103102)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 21:49:33 UTC (rev 103103)
@@ -1,3 +1,25 @@
+2011-12-16 Simon Fraser
+
+Allow a PlatformCALayer to own its own sublayers
+https://bugs.webkit.org/show_bug.cgi?id=74744
+
+Reviewed by Anders Carlsson.
+
+GraphicsLayerCA rebuilds the sublayer list of CALayers, which would
+blow away any custom layers that a PlatformCALayer wants to maintain
+as children.
+
+Make it possible for a PlatformLayerCA to indicate that it wants
+a specific list of sublayers to be maintained as the first layers
+in the child list.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::updateSublayerList):
+* platform/graphics/ca/PlatformCALayer.h:
+(WebCore::PlatformCALayer::customSublayers):
+* platform/graphics/ca/mac/PlatformCALayerMac.mm:
+(PlatformCALayer::PlatformCALayer):
+
2011-12-16 Adam Barth
A doesn't parse correctly
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (103102 => 103103)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-12-16 21:44:45 UTC (rev 103102)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-12-16 21:49:33 UTC (rev 103103)
@@ -1018,6 +1018,9 @@
PlatformCALayerList newSublayers;
const Vector& childLayers = children();
+if (const PlatformCALayerList* customSublayers = m_layer->customSublayers())
+newSublayers.appendRange(customSublayers->begin(), customSublayers->end());
+
if (m_structuralLayer || m_contentsLayer || childLayers.size() > 0) {
if (m_structuralLayer) {
// Add the replica layer first.
Modified: trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h (103102 => 103103)
--- trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2011-12-16 21:44:45 UTC (rev 103102)
+++ trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2011-12-16 21:49:33 UTC (rev 103103)
@@ -81,6 +81,9 @@
PlatformCALayer* rootLayer() const;
+// A list of sublayers that GraphicsLayerCA should maintain as the first sublayers.
+const PlatformCALayerList* customSublayers() const { return m_customSublayers.get(); }
+
static bool isValueFunctionSupported();
PlatformCALayerClient* owner() const { return m_owner; }
@@ -214,6 +217,7 @@
PlatformCALayerClient* m_owner;
LayerType m_layerType;
+OwnPtr m_customSublayers;
#if PLATFORM(MAC) || PLATFORM(WIN)
RetainPtr m_layer;
#endif
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm (103102 => 103103)
--- trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm 2011-12-16 21:44:45 UTC (rev 103102)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm 2011-12-16 21:49:33 UTC (rev 103103)
@@ -216,6 +216,13 @@
[tiledLayer setContentsGravity:@"bottomLeft"];
}
+if (m_layerType == LayerTypeTileCacheLayer) {
+// FIXME: hook this up to the tile cache.
+//m_customSublayers = adoptPtr(new PlatformCALayerList(1));
+//CALayer* tileCacheTileContainerLayer = [static_cast(m_layer.get()) tileContainerLayer];
+//m_customSublayers->append(PlatformCALayer::create(tileCacheTileContainerLayer, 0));
+}
+
END_BLOCK_OBJC_EXCEPTIONS
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103102] trunk
Title: [103102] trunk
Revision 103102
Author aba...@webkit.org
Date 2011-12-16 13:44:45 -0800 (Fri, 16 Dec 2011)
Log Message
A doesn't parse correctly
https://bugs.webkit.org/show_bug.cgi?id=74658
Reviewed by Darin Adler.
Source/WebCore:
Previously, we handled skipping newlines after in the tokenizer,
which isn't how the spec handles them. Instead, the spec skips them in
the tree builder. This isn't usually observable, except in the case of
an HTML entity. In that case, the tokenzier sees '&' (because the
entity hasn't been decoded yet), but the tree builder sees '\n' (the
decoded entity). This patch fixes the bug by more closely aligning our
implementation with the spec.
Test: html5lib/runner.html
* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::nextToken):
* html/parser/HTMLTokenizer.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipAtMostOneLeadingNewline):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
* html/parser/HTMLTreeBuilder.h:
* xml/parser/MarkupTokenizerBase.h:
LayoutTests:
Shows test progression.
* html5lib/runner-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/textarea-newline-expected.txt
trunk/LayoutTests/fast/forms/textarea-newline.html
trunk/LayoutTests/html5lib/runner-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
trunk/Source/WebCore/html/parser/HTMLTokenizer.h
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h
trunk/Source/WebCore/html/parser/TextDocumentParser.cpp
trunk/Source/WebCore/xml/parser/MarkupTokenizerBase.h
Diff
Modified: trunk/LayoutTests/ChangeLog (103101 => 103102)
--- trunk/LayoutTests/ChangeLog 2011-12-16 21:33:59 UTC (rev 103101)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 21:44:45 UTC (rev 103102)
@@ -1,3 +1,14 @@
+2011-12-16 Adam Barth
+
+
A doesn't parse correctly
+https://bugs.webkit.org/show_bug.cgi?id=74658
+
+Reviewed by Darin Adler.
+
+Shows test progression.
+
+* html5lib/runner-expected.txt:
+
2011-12-16 Adrienne Walker
[chromium] Further suppress media/video-transformed.html failures
Modified: trunk/LayoutTests/fast/forms/textarea-newline-expected.txt (103101 => 103102)
--- trunk/LayoutTests/fast/forms/textarea-newline-expected.txt 2011-12-16 21:33:59 UTC (rev 103101)
+++ trunk/LayoutTests/fast/forms/textarea-newline-expected.txt 2011-12-16 21:44:45 UTC (rev 103102)
@@ -3,8 +3,8 @@
PASS document.getElementById("no-line-feed").value is "Madoka"
PASS document.getElementById("one-line-feed").value is "Sayaka"
PASS document.getElementById("two-line-feeds").value is "\nMami"
-PASS document.getElementById("one-line-feed-escaped-char-and-one-line-feed").value is "\n\nKyoko"
-PASS document.getElementById("two-line-feed-escaped-chars").value is "\n\nHomura"
+PASS document.getElementById("one-line-feed-escaped-char-and-one-line-feed").value is "\nKyoko"
+PASS document.getElementById("two-line-feed-escaped-chars").value is "\nHomura"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/forms/textarea-newline.html (103101 => 103102)
--- trunk/LayoutTests/fast/forms/textarea-newline.html 2011-12-16 21:33:59 UTC (rev 103101)
+++ trunk/LayoutTests/fast/forms/textarea-newline.html 2011-12-16 21:44:45 UTC (rev 103102)
@@ -31,9 +31,9 @@
shouldBe('document.getElementById("two-line-feeds").value', '"\\nMami"');
-shouldBe('document.getElementById("one-line-feed-escaped-char-and-one-line-feed").value', '"\\n\\nKyoko"');
+shouldBe('document.getElementById("one-line-feed-escaped-char-and-one-line-feed").value', '"\\nKyoko"');
-shouldBe('document.getElementById("two-line-feed-escaped-chars").value', '"\\n\\nHomura"');
+shouldBe('document.getElementById("two-line-feed-escaped-chars").value', '"\\nHomura"');
[webkit-changes] [103101] trunk/LayoutTests
Title: [103101] trunk/LayoutTests Revision 103101 Author e...@google.com Date 2011-12-16 13:33:59 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Further suppress media/video-transformed.html failures https://bugs.webkit.org/show_bug.cgi?id=73905 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103100 => 103101) --- trunk/LayoutTests/ChangeLog 2011-12-16 21:27:06 UTC (rev 103100) +++ trunk/LayoutTests/ChangeLog 2011-12-16 21:33:59 UTC (rev 103101) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] Further suppress media/video-transformed.html failures +https://bugs.webkit.org/show_bug.cgi?id=73905 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Joshua Bell IndexedDB: Implement IDBObjectStore.count() and IDBIndex.count() Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103100 => 103101) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 21:27:06 UTC (rev 103100) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 21:33:59 UTC (rev 103101) @@ -3976,7 +3976,7 @@ // Need rebaseline on Linux and Win GPU BUGWK73905 GPU LINUX : media/video-layer-crash.html = IMAGE+TEXT -BUGWK73905 GPU : media/video-transformed.html = IMAGE +BUGWK73905 GPU GPU-CG : media/video-transformed.html = IMAGE BUGWK73905 GPU LINUX : media/video-zoom-controls.html = IMAGE BUGWK73905 GPU WIN : media/video-layer-crash.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103099] trunk/LayoutTests
Title: [103099] trunk/LayoutTests Revision 103099 Author e...@google.com Date 2011-12-16 13:18:00 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Fix duplicate layout test expectation https://bugs.webkit.org/show_bug.cgi?id=53378 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103098 => 103099) --- trunk/LayoutTests/ChangeLog 2011-12-16 21:03:05 UTC (rev 103098) +++ trunk/LayoutTests/ChangeLog 2011-12-16 21:18:00 UTC (rev 103099) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] Fix duplicate layout test expectation +https://bugs.webkit.org/show_bug.cgi?id=53378 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Yael Aharon Audio file in video element has a size of 0x0 . Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103098 => 103099) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 21:03:05 UTC (rev 103098) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 21:18:00 UTC (rev 103099) @@ -880,7 +880,8 @@ // Windows needs rebaselining after 53378 patch. BUGWK53378 WIN : svg/W3C-SVG-1.1/filters-example-01-b.svg = IMAGE -BUGWK53378 WIN : svg/batik/text/textProperties.svg = IMAGE +// This is a duplicate of BUGCR99500 below. +//BUGWK53378 WIN : svg/batik/text/textProperties.svg = IMAGE BUGWK53378 WIN : svg/clip-path/clip-in-mask.svg = IMAGE BUGWK53378 WIN : svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg = IMAGE+TEXT BUGWK53378 WIN : svg/clip-path/deep-nested-clip-in-mask-panning.svg = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103098] trunk
Title: [103098] trunk Revision 103098 Author yael.aha...@nokia.com Date 2011-12-16 13:03:05 -0800 (Fri, 16 Dec 2011) Log Message Audio file in video element has a size of 0x0 . https://bugs.webkit.org/show_bug.cgi?id=74738 Reviewed by Kenneth Rohde Christiansen. Source/WebCore: When the source of a video element has audio only, the intrinsic size of the video should not be 0x0. Instead, it should be the same as as no media was loaded. No new tests. An existing test is covering this case and was modified to reflect this change. * rendering/RenderVideo.cpp: (WebCore::RenderVideo::calculateIntrinsicSize): LayoutTests: Changed the expected result to reflect this change. * media/audio-only-video-intrinsic-size-expected.txt: * media/audio-only-video-intrinsic-size.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt trunk/LayoutTests/media/audio-only-video-intrinsic-size.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderVideo.cpp Diff Modified: trunk/LayoutTests/ChangeLog (103097 => 103098) --- trunk/LayoutTests/ChangeLog 2011-12-16 20:55:10 UTC (rev 103097) +++ trunk/LayoutTests/ChangeLog 2011-12-16 21:03:05 UTC (rev 103098) @@ -1,3 +1,15 @@ +2011-12-16 Yael Aharon + +Audio file in video element has a size of 0x0 . +https://bugs.webkit.org/show_bug.cgi?id=74738 + +Reviewed by Kenneth Rohde Christiansen. + +Changed the expected result to reflect this change. + +* media/audio-only-video-intrinsic-size-expected.txt: +* media/audio-only-video-intrinsic-size.html: + 2011-12-16 Alexis Menard getComputedStyle for border-width is not implemented. Modified: trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt (103097 => 103098) --- trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt 2011-12-16 20:55:10 UTC (rev 103097) +++ trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt 2011-12-16 21:03:05 UTC (rev 103098) @@ -1,5 +1,5 @@ -This tests the intrinsic size of a video element is the default 300×150 before metadata is loaded, and 0×0 after metadata is loaded for an audio-only file. +This tests the intrinsic size of a video element is the default 300×150 before metadata is loaded, and also after metadata is loaded for an audio-only file. Initial dimensions: 300×150 -Dimensions after metadata loaded: 0×0 +Dimensions after metadata loaded: 300×150 Modified: trunk/LayoutTests/media/audio-only-video-intrinsic-size.html (103097 => 103098) --- trunk/LayoutTests/media/audio-only-video-intrinsic-size.html 2011-12-16 20:55:10 UTC (rev 103097) +++ trunk/LayoutTests/media/audio-only-video-intrinsic-size.html 2011-12-16 21:03:05 UTC (rev 103098) @@ -1,7 +1,7 @@ This tests the intrinsic size of a video element is the default 300×150 before metadata is -loaded, and 0×0 after metadata is loaded for an audio-only file. +loaded, and also after metadata is loaded for an audio-only file.
[webkit-changes] [103097] trunk/Source/WebKit2
Title: [103097] trunk/Source/WebKit2
Revision 103097
Author commit-qu...@webkit.org
Date 2011-12-16 12:55:10 -0800 (Fri, 16 Dec 2011)
Log Message
[Qt] Eliminate dependency to QUndoStack
https://bugs.webkit.org/show_bug.cgi?id=74691
Patch by Simon Hausmann on 2011-12-16
Reviewed by Kenneth Rohde Christiansen.
Replaced the QUndoStack with two vectors. When calling unapply()
on the edit command proxy, it will automatically re-register itself
in the redo stack.
* UIProcess/qt/QtWebUndoController.cpp:
(QtWebUndoController::registerEditCommand):
(QtWebUndoController::clearAllEditCommands):
(QtWebUndoController::canUndoRedo):
(QtWebUndoController::executeUndoRedo):
* UIProcess/qt/QtWebUndoController.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebUndoController.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebUndoController.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (103096 => 103097)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 20:50:31 UTC (rev 103096)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 20:55:10 UTC (rev 103097)
@@ -1,3 +1,21 @@
+2011-12-16 Simon Hausmann
+
+[Qt] Eliminate dependency to QUndoStack
+https://bugs.webkit.org/show_bug.cgi?id=74691
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Replaced the QUndoStack with two vectors. When calling unapply()
+on the edit command proxy, it will automatically re-register itself
+in the redo stack.
+
+* UIProcess/qt/QtWebUndoController.cpp:
+(QtWebUndoController::registerEditCommand):
+(QtWebUndoController::clearAllEditCommands):
+(QtWebUndoController::canUndoRedo):
+(QtWebUndoController::executeUndoRedo):
+* UIProcess/qt/QtWebUndoController.h:
+
2011-12-16 Rafael Brandao
[Qt][WK2] Move webView.page into experimental
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebUndoController.cpp (103096 => 103097)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebUndoController.cpp 2011-12-16 20:50:31 UTC (rev 103096)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebUndoController.cpp 2011-12-16 20:55:10 UTC (rev 103097)
@@ -21,96 +21,43 @@
#include "config.h"
#include "QtWebUndoController.h"
-#include "WebEditCommandProxy.h"
#include
#include
using namespace WebKit;
-class QtWebUndoCommand : public QUndoCommand {
-public:
-QtWebUndoCommand(PassRefPtr, QUndoCommand* parent = 0);
-~QtWebUndoCommand();
-
-void redo();
-void undo();
-
-bool inUndoRedo() const { return m_inUndoRedo; };
-
-private:
-RefPtr m_command;
-bool m_first;
-bool m_inUndoRedo;
-};
-
-QtWebUndoCommand::QtWebUndoCommand(PassRefPtr command, QUndoCommand* parent)
-: QUndoCommand(parent)
-, m_command(command)
-, m_first(true)
-, m_inUndoRedo(false)
-{
-}
-
-QtWebUndoCommand::~QtWebUndoCommand()
-{
-}
-
-void QtWebUndoCommand::redo()
-{
-m_inUndoRedo = true;
-
-// Ignore the first redo called from QUndoStack::push().
-if (m_first) {
-m_first = false;
-m_inUndoRedo = false;
-return;
-}
-if (m_command)
-m_command->reapply();
-
-m_inUndoRedo = false;
-}
-
-void QtWebUndoCommand::undo()
-{
-m_inUndoRedo = true;
-
-if (m_command)
-m_command->unapply();
-
-m_inUndoRedo = false;
-}
-
-QtWebUndoController::QtWebUndoController()
-{
-}
-
void QtWebUndoController::registerEditCommand(PassRefPtr command, WebPageProxy::UndoOrRedo undoOrRedo)
{
-if (undoOrRedo == WebPageProxy::Undo) {
-const QtWebUndoCommand* webUndoCommand = static_cast(m_undoStack.command(m_undoStack.index()));
-if (webUndoCommand && webUndoCommand->inUndoRedo())
-return;
-m_undoStack.push(new QtWebUndoCommand(command));
-}
+if (undoOrRedo == WebPageProxy::Undo)
+m_undoStack.append(command);
+else
+m_redoStack.append(command);
}
void QtWebUndoController::clearAllEditCommands()
{
m_undoStack.clear();
+m_redoStack.clear();
}
bool QtWebUndoController::canUndoRedo(WebPageProxy::UndoOrRedo undoOrRedo)
{
if (undoOrRedo == WebPageProxy::Undo)
-return m_undoStack.canUndo();
-return m_undoStack.canRedo();
+return !m_undoStack.isEmpty();
+else
+return !m_redoStack.isEmpty();
}
void QtWebUndoController::executeUndoRedo(WebPageProxy::UndoOrRedo undoOrRedo)
{
-if (undoOrRedo == WebPageProxy::Undo)
-m_undoStack.undo();
-else
-m_undoStack.redo();
+RefPtr command;
+if (undoOrRedo == WebPageProxy::Undo) {
+command = m_undoStack.last();
+m_undoStack.removeLast();
+command->unapply();
+} else {
+command = m_redoStack.last();
+m_redoStack.removeLast();
+command->reapply();
+}
}
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebUndoController.h (103096 => 103097)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebUndoController.h 2011-12-16 20:50:31 UTC (rev 103096)
[webkit-changes] [103096] trunk
Title: [103096] trunk
Revision 103096
Author alexis.men...@openbossa.org
Date 2011-12-16 12:50:31 -0800 (Fri, 16 Dec 2011)
Log Message
getComputedStyle for border-width is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=74635
Reviewed by Tony Chang.
Source/WebCore:
Implement getComputedStyle for border-width.
Test: fast/css/getComputedStyle/getComputedStyle-border-width.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Implement a test to cover getComputedStyle for border-width.
* fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-width.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Added Paths
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width.html
Diff
Modified: trunk/LayoutTests/ChangeLog (103095 => 103096)
--- trunk/LayoutTests/ChangeLog 2011-12-16 20:41:51 UTC (rev 103095)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 20:50:31 UTC (rev 103096)
@@ -1,3 +1,15 @@
+2011-12-16 Alexis Menard
+
+getComputedStyle for border-width is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=74635
+
+Reviewed by Tony Chang.
+
+Implement a test to cover getComputedStyle for border-width.
+
+* fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-border-width.html: Added.
+
2011-12-16 Dmitry Lomov
https://bugs.webkit.org/show_bug.cgi?id=74657
Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt (0 => 103096)
--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt 2011-12-16 20:50:31 UTC (rev 103096)
@@ -0,0 +1,49 @@
+Test to make sure border-width property returns CSSValueList properly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS computedStyle.getPropertyValue('border-width') is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 10
+PASS computedStyle.getPropertyCSSValue('border-width').item(1).getFloatValue(CSSPrimitiveValue.CSS_PX) is 5
+PASS computedStyle.getPropertyCSSValue('border-width').item(2).getFloatValue(CSSPrimitiveValue.CSS_PX) is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(3).getFloatValue(CSSPrimitiveValue.CSS_PX) is 3
+PASS computedStyle.getPropertyValue('border-width') is '320px 160px 64px 80px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '320px 160px 64px 80px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 320
+PASS computedStyle.getPropertyCSSValue('border-width').item(1).getFloatValue(CSSPrimitiveValue.CSS_PX) is 160
+PASS computedStyle.getPropertyCSSValue('border-width').item(2).getFloatValue(CSSPrimitiveValue.CSS_PX) is 64
+PASS computedStyle.getPropertyCSSValue('border-width').item(3).getFloatValue(CSSPrimitiveValue.CSS_PX) is 80
+PASS computedStyle.getPropertyValue('border-width') is '10px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '10px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 10
+PASS computedStyle.getPropertyCSSValue('border-width').item(1).getFloatValue(CSSPrimitiveValue.CSS_PX) is 0
+PASS computedStyle.getPropertyCSSValue('border-width').item(2).getFloatValue(CSSPrimitiveValue.CSS_PX) is 0
+PASS computedStyle.getPropertyCSSValue('border-width').item(3).getFloatValue(CSSPrimitiveValue.CSS_PX) is 0
+PASS computedStyle.getPropertyValue('border-width') is '0px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '0px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(0)
[webkit-changes] [103095] trunk/LayoutTests
Title: [103095] trunk/LayoutTests Revision 103095 Author dslo...@google.com Date 2011-12-16 12:41:51 -0800 (Fri, 16 Dec 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=74657 [Chromium] Re-enable all layout tests for dedicated workers. Reviewed by David Levin. * fast/filesystem/workers/file-writer-gc-blob-expected.txt: Renamed from LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html. * fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Renamed from LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.html. * http/tests/filesystem/resources/fs-worker-common.js: * platform/chromium/http/tests/filesystem/workers/resolve-url-expected.txt: webkitRequestFileSystem is available in chromium DRT. * platform/chromium/http/tests/filesystem/workers/resolve-url-sync-expected.txt: webkitRequestFileSystem is available in chromium DRT. * platform/chromium/http/tests/workers/worker-importScripts-expected.txt: Exception message texts differ. * platform/chromium/http/tests/workers/worker-importScriptsOnError-expected.txt: Exception message texts differ. * platform/chromium/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Minor message text differences. * platform/chromium/http/tests/xmlhttprequest/workers/methods-expected.txt: Minor message text differnces. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/filesystem/resources/fs-worker-common.js trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.txt trunk/LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.txt trunk/LayoutTests/platform/chromium/http/tests/filesystem/ trunk/LayoutTests/platform/chromium/http/tests/filesystem/workers/ trunk/LayoutTests/platform/chromium/http/tests/filesystem/workers/resolve-url-expected.txt trunk/LayoutTests/platform/chromium/http/tests/filesystem/workers/resolve-url-sync-expected.txt trunk/LayoutTests/platform/chromium/http/tests/workers/ trunk/LayoutTests/platform/chromium/http/tests/workers/worker-importScripts-expected.txt trunk/LayoutTests/platform/chromium/http/tests/workers/worker-importScriptsOnError-expected.txt trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/workers/ trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/workers/methods-async-expected.txt trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/workers/methods-expected.txt Removed Paths trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html trunk/LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.html Diff Modified: trunk/LayoutTests/ChangeLog (103094 => 103095) --- trunk/LayoutTests/ChangeLog 2011-12-16 20:41:15 UTC (rev 103094) +++ trunk/LayoutTests/ChangeLog 2011-12-16 20:41:51 UTC (rev 103095) @@ -1,3 +1,21 @@ +2011-12-16 Dmitry Lomov + +https://bugs.webkit.org/show_bug.cgi?id=74657 +[Chromium] Re-enable all layout tests for dedicated workers. + +Reviewed by David Levin. + +* fast/filesystem/workers/file-writer-gc-blob-expected.txt: Renamed from LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html. +* fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Renamed from LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.html. +* http/tests/filesystem/resources/fs-worker-common.js: +* platform/chromium/http/tests/filesystem/workers/resolve-url-expected.txt: webkitRequestFileSystem is available in chromium DRT. +* platform/chromium/http/tests/filesystem/workers/resolve-url-sync-expected.txt: webkitRequestFileSystem is available in chromium DRT. +* platform/chromium/http/tests/workers/worker-importScripts-expected.txt: Exception message texts differ. +* platform/chromium/http/tests/workers/worker-importScriptsOnError-expected.txt: Exception message texts differ. +* platform/chromium/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Minor message text differences. +* platform/chromium/http/tests/xmlhttprequest/workers/methods-expected.txt: Minor message text differnces. +* platform/chromium/test_expectations.txt: + 2011-12-16 Adrienne Walker [chromium] media/event-attributes.html is flaky on all platforms Deleted: trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html (103094 => 103095) --- trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html 2011-12-16 20:41:15 UTC (rev 103094) +++ trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html 2011-12-16 20:41:51 UTC (rev 103095) @@ -1,11 +0,0 @@ -[Worker] Test that a blob won't get garbage-collected while being written out by a FileWriter. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -Sta
[webkit-changes] [103094] trunk/Source/WebKit/mac
Title: [103094] trunk/Source/WebKit/mac Revision 103094 Author simon.fra...@apple.com Date 2011-12-16 12:41:15 -0800 (Fri, 16 Dec 2011) Log Message Avoid calling -setGeometryFlipped ourselves on the layer hosting view's layer Reviewed by Sam Weinig. Now that we're using a flipped view to host the compositing layers, we should not set geometryFlipped on the root layer ourselves. * WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebHTMLView.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (103093 => 103094) --- trunk/Source/WebKit/mac/ChangeLog 2011-12-16 20:41:09 UTC (rev 103093) +++ trunk/Source/WebKit/mac/ChangeLog 2011-12-16 20:41:15 UTC (rev 103094) @@ -1,3 +1,15 @@ +2011-12-16 Simon Fraser + + Avoid calling -setGeometryFlipped ourselves on the layer hosting view's layer + +Reviewed by Sam Weinig. + +Now that we're using a flipped view to host the compositing layers, +we should not set geometryFlipped on the root layer ourselves. + +* WebView/WebHTMLView.mm: +(-[WebHTMLView attachRootLayer:]): + 2011-12-16 Mark Hahnenberg De-virtualize destructors Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (103093 => 103094) --- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2011-12-16 20:41:09 UTC (rev 103093) +++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2011-12-16 20:41:15 UTC (rev 103094) @@ -5498,7 +5498,7 @@ #ifdef BUILDING_ON_LEOPARD [viewLayer setSublayerTransform:CATransform3DMakeScale(1, -1, 1)]; // setGeometryFlipped: doesn't exist on Leopard. [self _updateLayerHostingViewPosition]; -#else +#elsif (BUILDING_ON_SNOW_LEOPARD || BUILDING_ON_LION) // Do geometry flipping here, which flips all the compositing layers so they are top-down. [viewLayer setGeometryFlipped:YES]; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103093] trunk/Source/WebKit2
Title: [103093] trunk/Source/WebKit2
Revision 103093
Author commit-qu...@webkit.org
Date 2011-12-16 12:41:09 -0800 (Fri, 16 Dec 2011)
Log Message
[Qt][WK2] Move webView.page into experimental
https://bugs.webkit.org/show_bug.cgi?id=74406
Patch by Rafael Brandao on 2011-12-16
Reviewed by Simon Hausmann.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::page):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::accessPage):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (103092 => 103093)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 20:24:02 UTC (rev 103092)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 20:41:09 UTC (rev 103093)
@@ -1,3 +1,16 @@
+2011-12-16 Rafael Brandao
+
+[Qt][WK2] Move webView.page into experimental
+https://bugs.webkit.org/show_bug.cgi?id=74406
+
+Reviewed by Simon Hausmann.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewExperimental::page):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
+(tst_QQuickWebView::accessPage):
+
2011-12-16 Mark Hahnenberg
De-virtualize destructors
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (103092 => 103093)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2011-12-16 20:24:02 UTC (rev 103092)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2011-12-16 20:41:09 UTC (rev 103093)
@@ -670,6 +670,11 @@
return m_viewportInfo;
}
+QQuickWebPage* QQuickWebViewExperimental::page()
+{
+return q_ptr->page();
+}
+
QQuickWebView::QQuickWebView(QQuickItem* parent)
: QQuickItem(parent)
, d_ptr(new QQuickWebViewPrivate(this))
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (103092 => 103093)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h 2011-12-16 20:24:02 UTC (rev 103092)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h 2011-12-16 20:41:09 UTC (rev 103093)
@@ -58,7 +58,6 @@
Q_PROPERTY(bool canGoForward READ canGoForward NOTIFY navigationStateChanged FINAL)
Q_PROPERTY(bool loading READ loading NOTIFY navigationStateChanged FINAL)
Q_PROPERTY(bool canReload READ canReload NOTIFY navigationStateChanged FINAL)
-Q_PROPERTY(QQuickWebPage* page READ page CONSTANT FINAL)
Q_ENUMS(NavigationRequestAction)
Q_ENUMS(ErrorType)
@@ -166,6 +165,7 @@
class QWEBKIT_EXPORT QQuickWebViewExperimental : public QObject {
Q_OBJECT
+Q_PROPERTY(QQuickWebPage* page READ page CONSTANT FINAL)
Q_PROPERTY(QWebNavigationHistory* navigationHistory READ navigationHistory CONSTANT FINAL)
Q_PROPERTY(QDeclarativeComponent* alertDialog READ alertDialog WRITE setAlertDialog NOTIFY alertDialogChanged)
Q_PROPERTY(QDeclarativeComponent* confirmDialog READ confirmDialog WRITE setConfirmDialog NOTIFY confirmDialogChanged)
@@ -193,6 +193,7 @@
QWebPreferences* preferences() const;
bool useTraditionalDesktopBehaviour() const;
QWebNavigationHistory* navigationHistory() const;
+QQuickWebPage* page();
public Q_SLOTS:
void setUseTraditionalDesktopBehaviour(bool enable);
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp (103092 => 103093)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp 2011-12-16 20:24:02 UTC (rev 103092)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp 2011-12-16 20:41:09 UTC (rev 103093)
@@ -82,7 +82,7 @@
{
QQuickWebPage* const pageDirectAccess = webView()->page();
-QVariant pagePropertyValue = webView()->property("page");
+QVariant pagePropertyValue = webView()->experimental()->property("page");
QQuickWebPage* const pagePropertyAccess = pagePropertyValue.value();
QCOMPARE(pagePropertyAccess, pageDirectAccess);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103092] trunk/LayoutTests
Title: [103092] trunk/LayoutTests Revision 103092 Author e...@google.com Date 2011-12-16 12:24:02 -0800 (Fri, 16 Dec 2011) Log Message [chromium] media/event-attributes.html is flaky on all platforms https://bugs.webkit.org/show_bug.cgi?id=73692 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103091 => 103092) --- trunk/LayoutTests/ChangeLog 2011-12-16 20:20:34 UTC (rev 103091) +++ trunk/LayoutTests/ChangeLog 2011-12-16 20:24:02 UTC (rev 103092) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] media/event-attributes.html is flaky on all platforms +https://bugs.webkit.org/show_bug.cgi?id=73692 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Branimir Lambov [chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103091 => 103092) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 20:20:34 UTC (rev 103091) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 20:24:02 UTC (rev 103092) @@ -3958,7 +3958,7 @@ BUGWK73681 : http/tests/appcache/video.html = TIMEOUT PASS -BUGWK73692 WIN LEOPARD : media/event-attributes.html = TEXT PASS +BUGWK73692 : media/event-attributes.html = TEXT PASS BUGWK73766 : css3/unicode-bidi-isolate-aharon-failing.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103090] trunk/Tools
Title: [103090] trunk/Tools
Revision 103090
Author d...@apple.com
Date 2011-12-16 12:17:54 -0800 (Fri, 16 Dec 2011)
Log Message
Add webkit-bug-impor...@group.apple.com to accounts
so that it autocompletes in bugzilla.
Unreviewed.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (103089 => 103090)
--- trunk/Tools/ChangeLog 2011-12-16 20:04:01 UTC (rev 103089)
+++ trunk/Tools/ChangeLog 2011-12-16 20:17:54 UTC (rev 103090)
@@ -1,3 +1,12 @@
+2011-12-16 Dean Jackson
+
+Add webkit-bug-impor...@group.apple.com to accounts
+so that it autocompletes in bugzilla.
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2011-12-16 Philippe Normand
Unreviewed, skipping 3 failing GTK API tests.
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (103089 => 103090)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-12-16 20:04:01 UTC (rev 103089)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-12-16 20:17:54 UTC (rev 103090)
@@ -96,6 +96,7 @@
Account("Chromium Compositor Bugs", ["cc-b...@google.com"], ""),
Account("David Levin", ["levin+thread...@chromium.org"], ""),
Account("David Levin", ["levin+watchl...@chromium.org"], ""),
+Account("Radar WebKit Bug Importer", ["webkit-bug-impor...@group.apple.com"], "radar"),
]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103089] trunk/Source/WebKit/chromium
Title: [103089] trunk/Source/WebKit/chromium
Revision 103089
Author e...@google.com
Date 2011-12-16 12:04:01 -0800 (Fri, 16 Dec 2011)
Log Message
[chromium] Disable compositor CCLayerTreeHostTestsetNeedsCommit1 test
https://bugs.webkit.org/show_bug.cgi?id=74623
Unreviewed gardening.
This has been failing (timeout) intermittently on Mac.
* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (103088 => 103089)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 19:39:15 UTC (rev 103088)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 20:04:01 UTC (rev 103089)
@@ -1,3 +1,15 @@
+2011-12-16 Adrienne Walker
+
+[chromium] Disable compositor CCLayerTreeHostTestsetNeedsCommit1 test
+https://bugs.webkit.org/show_bug.cgi?id=74623
+
+Unreviewed gardening.
+
+This has been failing (timeout) intermittently on Mac.
+
+* tests/CCLayerTreeHostTest.cpp:
+(WTF::TEST_F):
+
2011-12-16 Dana Jansens
[chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame.
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (103088 => 103089)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2011-12-16 19:39:15 UTC (rev 103088)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2011-12-16 20:04:01 UTC (rev 103089)
@@ -604,7 +604,7 @@
int m_numDraws;
};
-TEST_F(CCLayerTreeHostTestSetNeedsCommit1, runMultiThread)
+TEST_F(CCLayerTreeHostTestSetNeedsCommit1, DISABLED_runMultiThread)
{
runTestThreaded();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103088] trunk/LayoutTests
Title: [103088] trunk/LayoutTests Revision 103088 Author e...@google.com Date 2011-12-16 11:39:15 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Expand flakiness suppression for 2d.text.draw.fontface.notinpage https://bugs.webkit.org/show_bug.cgi?id=66908 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103087 => 103088) --- trunk/LayoutTests/ChangeLog 2011-12-16 19:30:31 UTC (rev 103087) +++ trunk/LayoutTests/ChangeLog 2011-12-16 19:39:15 UTC (rev 103088) @@ -1,5 +1,14 @@ 2011-12-16 Adrienne Walker +[chromium] Expand flakiness suppression for 2d.text.draw.fontface.notinpage +https://bugs.webkit.org/show_bug.cgi?id=66908 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-12-16 Adrienne Walker + [chromium] Mark compositing/reflections/reflection-positioning2.html as flaky https://bugs.webkit.org/show_bug.cgi?id=74731 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103087 => 103088) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 19:30:31 UTC (rev 103087) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 19:39:15 UTC (rev 103088) @@ -3557,8 +3557,7 @@ BUGWK66900 LINUX DEBUG : fast/writing-mode/japanese-rl-text-with-broken-font.html = PASS IMAGE+TEXT BUGWK66900 SNOWLEOPARD CPU-CG : fast/writing-mode/japanese-rl-text-with-broken-font.html = PASS IMAGE+TEXT -BUGWK66908 WIN LINUX GPU DEBUG : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT -BUGWK66908 LEOPARD GPU : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT +BUGWK66908 GPU : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT BUGWK66908 : fast/css/font-face-woff.html = PASS IMAGE+TEXT BUGWK66908 : svg/custom/svg-fonts-fallback.xhtml = PASS IMAGE+TEXT IMAGE BUGWK66908 WIN SNOWLEOPARD : fast/css/font-face-multiple-faces.html = PASS IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103087] trunk/LayoutTests
Title: [103087] trunk/LayoutTests Revision 103087 Author e...@google.com Date 2011-12-16 11:30:31 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Mark compositing/reflections/reflection-positioning2.html as flaky https://bugs.webkit.org/show_bug.cgi?id=74731 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103086 => 103087) --- trunk/LayoutTests/ChangeLog 2011-12-16 19:24:28 UTC (rev 103086) +++ trunk/LayoutTests/ChangeLog 2011-12-16 19:30:31 UTC (rev 103087) @@ -1,5 +1,14 @@ 2011-12-16 Adrienne Walker +[chromium] Mark compositing/reflections/reflection-positioning2.html as flaky +https://bugs.webkit.org/show_bug.cgi?id=74731 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + +2011-12-16 Adrienne Walker + [chromium] Mark several http tests as failing, due to DRT weirdness. https://bugs.webkit.org/show_bug.cgi?id=74694 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103086 => 103087) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 19:24:28 UTC (rev 103086) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 19:30:31 UTC (rev 103087) @@ -4018,3 +4018,5 @@ BUGWK74634 WIN : compositing/absolute-position-changed-with-composited-parent-layer.html = IMAGE BUGWK74688 : fast/css/bidi-override-in-anonymous-block.html = TEXT + +BUGWK74731 : compositing/reflections/reflection-positioning2.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103086] trunk/Source/WebKit/chromium
Title: [103086] trunk/Source/WebKit/chromium
Revision 103086
Author commit-qu...@webkit.org
Date 2011-12-16 11:24:28 -0800 (Fri, 16 Dec 2011)
Log Message
[chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame.
https://bugs.webkit.org/show_bug.cgi?id=74722
Patch by Dana Jansens on 2011-12-16
Reviewed by Darin Fisher.
* public/WebMediaPlayerClient.h:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::WebMediaPlayerClientImpl):
* src/WebMediaPlayerClientImpl.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (103085 => 103086)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 19:09:35 UTC (rev 103085)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 19:24:28 UTC (rev 103086)
@@ -1,3 +1,18 @@
+2011-12-16 Dana Jansens
+
+[chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame.
+https://bugs.webkit.org/show_bug.cgi?id=74722
+
+Reviewed by Darin Fisher.
+
+* public/WebMediaPlayerClient.h:
+* src/WebMediaPlayerClientImpl.cpp:
+(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
+(WebKit::WebMediaPlayerClientImpl::setOpaque):
+(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
+(WebKit::WebMediaPlayerClientImpl::WebMediaPlayerClientImpl):
+* src/WebMediaPlayerClientImpl.h:
+
2011-12-15 Stephen White
Enable CSS_FILTERS in Chromium.
Modified: trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h (103085 => 103086)
--- trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h 2011-12-16 19:09:35 UTC (rev 103085)
+++ trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h 2011-12-16 19:24:28 UTC (rev 103086)
@@ -49,6 +49,7 @@
virtual void durationChanged() = 0;
virtual void rateChanged() = 0;
virtual void sizeChanged() = 0;
+virtual void setOpaque(bool) = 0;
virtual void sawUnsupportedTracks() = 0;
virtual float volume() const = 0;
virtual void playbackStateChanged() = 0;
Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp (103085 => 103086)
--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp 2011-12-16 19:09:35 UTC (rev 103085)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp 2011-12-16 19:24:28 UTC (rev 103086)
@@ -62,29 +62,6 @@
return adoptPtr(webFrame->client()->createMediaPlayer(webFrame, client));
}
-static bool isVideoFrameFormatOpaque(WebVideoFrame::Format format)
-{
-switch (format) {
-case WebVideoFrame::FormatInvalid:
-case WebVideoFrame::FormatEmpty:
-case WebVideoFrame::FormatRGBA:
-case WebVideoFrame::FormatNativeTexture:
-return false;
-case WebVideoFrame::FormatRGB555:
-case WebVideoFrame::FormatRGB565:
-case WebVideoFrame::FormatRGB24:
-case WebVideoFrame::FormatRGB32:
-case WebVideoFrame::FormatYV12:
-case WebVideoFrame::FormatYV16:
-case WebVideoFrame::FormatNV12:
-case WebVideoFrame::FormatASCII:
-case WebVideoFrame::FormatI420:
-return true;
-}
-ASSERT_NOT_REACHED();
-return false;
-}
-
bool WebMediaPlayerClientImpl::m_isEnabled = false;
bool WebMediaPlayerClientImpl::isEnabled()
@@ -142,8 +119,10 @@
ASSERT(m_mediaPlayer);
m_mediaPlayer->readyStateChanged();
#if USE(ACCELERATED_COMPOSITING)
-if (hasVideo() && supportsAcceleratedRendering() && !m_videoLayer)
+if (hasVideo() && supportsAcceleratedRendering() && !m_videoLayer) {
m_videoLayer = VideoLayerChromium::create(0, this);
+m_videoLayer->setOpaque(m_opaque);
+}
#endif
}
@@ -193,6 +172,15 @@
m_mediaPlayer->sizeChanged();
}
+void WebMediaPlayerClientImpl::setOpaque(bool opaque)
+{
+#if USE(ACCELERATED_COMPOSITING)
+m_opaque = opaque;
+if (m_videoLayer)
+m_videoLayer->setOpaque(m_opaque);
+#endif
+}
+
void WebMediaPlayerClientImpl::sawUnsupportedTracks()
{
ASSERT(m_mediaPlayer);
@@ -600,8 +588,6 @@
WebVideoFrame* webkitVideoFrame = m_webMediaPlayer->getCurrentFrame();
if (webkitVideoFrame)
m_currentVideoFrame = adoptPtr(new VideoFrameChromiumImpl(webkitVideoFrame));
-if (m_videoLayer)
-m_videoLayer->setOpaque(webkitVideoFrame && isVideoFrameFormatOpaque(webkitVideoFrame->format()));
}
return m_currentVideoFrame.get();
}
@@ -680,6 +666,7 @@
#if USE(ACCELERATED_COMPOSITING)
, m_videoLayer(0)
, m_supportsAcceleratedCompositing(false)
+, m_opaque(f
[webkit-changes] [103085] trunk/LayoutTests
Title: [103085] trunk/LayoutTests
Revision 103085
Author mnaga...@chromium.org
Date 2011-12-16 11:09:35 -0800 (Fri, 16 Dec 2011)
Log Message
[Gtk] Add platform-specific test results after r103073
* platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt: Added.
* platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt
trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt
trunk/LayoutTests/platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt
trunk/LayoutTests/platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (103084 => 103085)
--- trunk/LayoutTests/ChangeLog 2011-12-16 19:08:09 UTC (rev 103084)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 19:09:35 UTC (rev 103085)
@@ -9,6 +9,15 @@
2011-12-16 Mikhail Naganov
+[Gtk] Add platform-specific test results after r103073
+
+* platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
+* platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt: Added.
+* platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
+* platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
+
+2011-12-16 Mikhail Naganov
+
Rebaseline and add expectations after r103073
[chromium] https://bugs.webkit.org/show_bug.cgi?id=74726
Added: trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt (0 => 103085)
--- trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt 2011-12-16 19:09:35 UTC (rev 103085)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x72
+ RenderBlock {HTML} at (0,0) size 800x72
+RenderBody {BODY} at (8,8) size 784x56
+ RenderBlock {DIV} at (0,0) size 784x36
+RenderText {#text} at (0,0) size 762x35
+ text run at (0,0) width 762: "When the caret reaches the edge of the input box or content editable div, on the next input if must jump to the center of"
+ text run at (0,18) width 73: "the control."
+layer at (8,44) size 82x20 clip at (9,45) size 80x18 scrollX 41 scrollWidth 337
+ RenderBlock {DIV} at (0,36) size 82x20 [border: (1px solid #00)]
+RenderText {#text} at (1,1) size 336x17
+ text run at (1,1) width 336: "012345678901012345678901234567890123456789"
+caret: position 12 of child 0 {#text} of child 5 {DIV} of body
Added: trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt (0 => 103085)
--- trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt 2011-12-16 19:09:35 UTC (rev 103085)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x62
+ RenderBlock {HTML} at (0,0) size 800x62
+RenderBody {BODY} at (8,8) size 784x46
+ RenderBlock {DIV} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 692x17
+ text run at (0,0) width 692: "When the caret reaches the edge of the input box, on the next input if must jump to the center of the control."
+ RenderBlock (anonymous) at (0,18) size 784x28
+RenderTextControl {INPUT} at (2,2) size 103x24 [bgcolor=#FF] [border: (2px inset #00)]
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+layer at (13,31) size 97x18 scrollX 51 scrollWidth 376
+ RenderBlock {DIV} at (3,3) size 97x18
+RenderText {#text} at (1,0) size 374x17
+ text run at (1,0) width 374: "012345678901012345678901234567890123456789"
+caret: position 12 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 3 {INPUT} of body
Added: trunk/LayoutTests/platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt (0 => 103085)
--- trunk/LayoutTests/platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt 2011-12-16 19:09:35 UTC (rev 103085)
@@ -0,0 +1,104 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x216
+ RenderBlock {HTML} at (0,0) size 800x2
[webkit-changes] [103084] trunk/LayoutTests
Title: [103084] trunk/LayoutTests Revision 103084 Author e...@google.com Date 2011-12-16 11:08:09 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Mark several http tests as failing, due to DRT weirdness. https://bugs.webkit.org/show_bug.cgi?id=74694 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103083 => 103084) --- trunk/LayoutTests/ChangeLog 2011-12-16 19:06:44 UTC (rev 103083) +++ trunk/LayoutTests/ChangeLog 2011-12-16 19:08:09 UTC (rev 103084) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] Mark several http tests as failing, due to DRT weirdness. +https://bugs.webkit.org/show_bug.cgi?id=74694 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Mikhail Naganov Rebaseline and add expectations after r103073 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103083 => 103084) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 19:06:44 UTC (rev 103083) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 19:08:09 UTC (rev 103084) @@ -3505,8 +3505,9 @@ BUGWK65453 MAC : fast/css/outline-auto-empty-rects.html = IMAGE -BUGWK65462 VISTA LINUX : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT TEXT -BUGWK74694 LINUX : http/tests/cache/history-only-cached-subresource-loads.html = PASS TIMEOUT TEXT +BUGWK65462 VISTA : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT TEXT +BUGWK74694 LINUX : http/tests/cache/history-only-cached-subresource-loads.html = MISSING FAIL +BUGWK74694 LINUX : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = MISSING FAIL BUGWK67915 LINUX WIN : fast/borders/borderRadiusDashed06.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103082] trunk/Source/WebCore
Title: [103082] trunk/Source/WebCore
Revision 103082
Author a...@apple.com
Date 2011-12-16 10:59:40 -0800 (Fri, 16 Dec 2011)
Log Message
Poor XPath performance when evaluating an _expression_ that returns a lot of nodes
https://bugs.webkit.org/show_bug.cgi?id=74665
Reviewed by Darin Adler.
No change in funcitonality. Well covered by existing tests (ran them with zero cutoff to
execute the new code path).
Our sorting function is optimized for small node sets in large documents, and this is the
opposite of it. Added another one that traverses the whole document, adding nodes from the
node set to sorted list. That doesn't grow with the number of nodes nearly as fast.
Cutoff amount chosen for the document referenced in bug - this is roughly where the algorithms
have the same performance on it.
* xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::sort):
(WebCore::XPath::findRootNode):
(WebCore::XPath::NodeSet::traversalSort):
* xml/XPathNodeSet.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XPathNodeSet.cpp
trunk/Source/WebCore/xml/XPathNodeSet.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (103081 => 103082)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 18:43:57 UTC (rev 103081)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 18:59:40 UTC (rev 103082)
@@ -1,3 +1,27 @@
+2011-12-15 Alexey Proskuryakov
+
+Poor XPath performance when evaluating an _expression_ that returns a lot of nodes
+https://bugs.webkit.org/show_bug.cgi?id=74665
+
+
+Reviewed by Darin Adler.
+
+No change in funcitonality. Well covered by existing tests (ran them with zero cutoff to
+execute the new code path).
+
+Our sorting function is optimized for small node sets in large documents, and this is the
+opposite of it. Added another one that traverses the whole document, adding nodes from the
+node set to sorted list. That doesn't grow with the number of nodes nearly as fast.
+
+Cutoff amount chosen for the document referenced in bug - this is roughly where the algorithms
+have the same performance on it.
+
+* xml/XPathNodeSet.cpp:
+(WebCore::XPath::NodeSet::sort):
+(WebCore::XPath::findRootNode):
+(WebCore::XPath::NodeSet::traversalSort):
+* xml/XPathNodeSet.h:
+
2011-12-15 Antti Koivisto
https://bugs.webkit.org/show_bug.cgi?id=74677
Modified: trunk/Source/WebCore/xml/XPathNodeSet.cpp (103081 => 103082)
--- trunk/Source/WebCore/xml/XPathNodeSet.cpp 2011-12-16 18:43:57 UTC (rev 103081)
+++ trunk/Source/WebCore/xml/XPathNodeSet.cpp 2011-12-16 18:59:40 UTC (rev 103082)
@@ -33,6 +33,10 @@
namespace WebCore {
namespace XPath {
+// When a node set is large, sorting it by traversing the whole document is better (we can
+// assume that we aren't dealing with documents that we cannot even traverse in reasonable time).
+const unsigned traversalSortCutoff = 1;
+
static inline Node* parentWithDepth(unsigned depth, const Vector& parents)
{
ASSERT(parents.size() >= depth + 1);
@@ -140,7 +144,12 @@
const_cast(m_isSorted) = true;
return;
}
-
+
+if (nodeCount > traversalSortCutoff) {
+traversalSort();
+return;
+}
+
bool containsAttributeNodes = false;
Vector > parentMatrix(nodeCount);
@@ -164,9 +173,62 @@
for (unsigned i = 0; i < nodeCount; ++i)
sortedNodes.append(parentMatrix[i][0]);
-const_cast >& >(m_nodes).swap(sortedNodes);
+const_cast >&>(m_nodes).swap(sortedNodes);
}
+static Node* findRootNode(Node* node)
+{
+if (node->isAttributeNode())
+node = static_cast(node)->ownerElement();
+if (node->inDocument())
+node = node->document();
+else {
+while (Node* parent = node->parentNode())
+node = parent;
+}
+return node;
+}
+
+void NodeSet::traversalSort() const
+{
+HashSet nodes;
+bool containsAttributeNodes = false;
+
+unsigned nodeCount = m_nodes.size();
+ASSERT(nodeCount > 1);
+for (unsigned i = 0; i < nodeCount; ++i) {
+Node* node = m_nodes[i].get();
+nodes.add(node);
+if (node->isAttributeNode())
+containsAttributeNodes = true;
+}
+
+Vector > sortedNodes;
+sortedNodes.reserveInitialCapacity(nodeCount);
+
+for (Node* n = findRootNode(m_nodes.first().get()); n; n = n->traverseNextNode()) {
+if (nodes.contains(n))
+sortedNodes.append(n);
+
+if (!containsAttributeNodes || !n->isElementNode())
+continue;
+
+NamedNodeMap* attributes = toElement(n)->attributes(true /* read-only */);
+if (!attributes)
+continue;
+
+unsigned attributeCount = attributes->length();
+for (unsigned i = 0; i < attributeCount; ++i) {
+Att
[webkit-changes] [103080] trunk/Source/WebCore
Title: [103080] trunk/Source/WebCore
Revision 103080
Author an...@apple.com
Date 2011-12-16 10:39:47 -0800 (Fri, 16 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=74677
Count ResourceLoadScheduler suspends/resumes
Reviewed by Andreas Kling.
Using boolean is not robust when there are multiple clients calling suspendPendingRequests/resumePendingRequests.
Increment and decrement suspend count instead of just setting/unsetting a boolean.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::suspendPendingRequests):
(WebCore::ResourceLoadScheduler::resumePendingRequests):
* loader/ResourceLoadScheduler.h:
(WebCore::ResourceLoadScheduler::isSuspendingPendingRequests):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoadScheduler.cpp
trunk/Source/WebCore/loader/ResourceLoadScheduler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (103079 => 103080)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 18:27:13 UTC (rev 103079)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 18:39:47 UTC (rev 103080)
@@ -1,3 +1,22 @@
+2011-12-15 Antti Koivisto
+
+https://bugs.webkit.org/show_bug.cgi?id=74677
+Count ResourceLoadScheduler suspends/resumes
+
+Reviewed by Andreas Kling.
+
+Using boolean is not robust when there are multiple clients calling suspendPendingRequests/resumePendingRequests.
+
+Increment and decrement suspend count instead of just setting/unsetting a boolean.
+
+* loader/ResourceLoadScheduler.cpp:
+(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
+(WebCore::ResourceLoadScheduler::servePendingRequests):
+(WebCore::ResourceLoadScheduler::suspendPendingRequests):
+(WebCore::ResourceLoadScheduler::resumePendingRequests):
+* loader/ResourceLoadScheduler.h:
+(WebCore::ResourceLoadScheduler::isSuspendingPendingRequests):
+
2011-12-16 Adam Klein
Improve performance of ChildListMutationScope when no MutationObservers are present
Modified: trunk/Source/WebCore/loader/ResourceLoadScheduler.cpp (103079 => 103080)
--- trunk/Source/WebCore/loader/ResourceLoadScheduler.cpp 2011-12-16 18:27:13 UTC (rev 103079)
+++ trunk/Source/WebCore/loader/ResourceLoadScheduler.cpp 2011-12-16 18:39:47 UTC (rev 103080)
@@ -77,7 +77,7 @@
ResourceLoadScheduler::ResourceLoadScheduler()
: m_nonHTTPProtocolHost(new HostInformation(String(), maxRequestsInFlightForNonHTTPProtocols))
, m_requestTimer(this, &ResourceLoadScheduler::requestTimerFired)
-, m_isSuspendingPendingRequests(false)
+, m_suspendPendingRequestsCount(0)
, m_isSerialLoadingEnabled(false)
{
#if REQUEST_MANAGEMENT_ENABLED
@@ -162,8 +162,8 @@
void ResourceLoadScheduler::servePendingRequests(ResourceLoadPriority minimumPriority)
{
-LOG(ResourceLoading, "ResourceLoadScheduler::servePendingRequests. m_isSuspendingPendingRequests=%d", m_isSuspendingPendingRequests);
-if (m_isSuspendingPendingRequests)
+LOG(ResourceLoading, "ResourceLoadScheduler::servePendingRequests. m_suspendPendingRequestsCount=%d", m_suspendPendingRequestsCount);
+if (isSuspendingPendingRequests())
return;
m_requestTimer.stop();
@@ -213,14 +213,15 @@
void ResourceLoadScheduler::suspendPendingRequests()
{
-ASSERT(!m_isSuspendingPendingRequests);
-m_isSuspendingPendingRequests = true;
+++m_suspendPendingRequestsCount;
}
void ResourceLoadScheduler::resumePendingRequests()
{
-ASSERT(m_isSuspendingPendingRequests);
-m_isSuspendingPendingRequests = false;
+ASSERT(m_suspendPendingRequestsCount);
+--m_suspendPendingRequestsCount;
+if (m_suspendPendingRequestsCount)
+return;
if (!m_hosts.isEmpty() || m_nonHTTPProtocolHost->hasRequests())
scheduleServePendingRequests();
}
Modified: trunk/Source/WebCore/loader/ResourceLoadScheduler.h (103079 => 103080)
--- trunk/Source/WebCore/loader/ResourceLoadScheduler.h 2011-12-16 18:27:13 UTC (rev 103079)
+++ trunk/Source/WebCore/loader/ResourceLoadScheduler.h 2011-12-16 18:39:47 UTC (rev 103080)
@@ -58,6 +58,7 @@
void crossOriginRedirectReceived(ResourceLoader*, const KURL& redirectURL);
void servePendingRequests(ResourceLoadPriority minimumPriority = ResourceLoadPriorityVeryLow);
+bool isSuspendingPendingRequests() const { return !!m_suspendPendingRequestsCount; }
void suspendPendingRequests();
void resumePendingRequests();
@@ -110,7 +111,7 @@
Timer m_requestTimer;
-bool m_isSuspendingPendingRequests;
+unsigned m_suspendPendingRequestsCount;
bool m_isSerialLoadingEnabled;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103079] trunk/Source/WebCore
Title: [103079] trunk/Source/WebCore Revision 103079 Author ad...@chromium.org Date 2011-12-16 10:27:13 -0800 (Fri, 16 Dec 2011) Log Message Improve performance of ChildListMutationScope when no MutationObservers are present https://bugs.webkit.org/show_bug.cgi?id=74671 Reviewed by Ojan Vafai. Inline ChildListMutationScope's methods (including constructor and destructor), and provide a fast-fail case when no mutation observers are present. The code reorganization necessary for the above also removed the anonymous namespace in ChildListMutationScope.cpp, making both helper classes private inner classes of ChildListMutationScope. No new tests, refactoring only. * dom/ChildListMutationScope.cpp: (WebCore::ChildListMutationScope::MutationAccumulator::MutationAccumulator): (WebCore::ChildListMutationScope::MutationAccumulator::~MutationAccumulator): (WebCore::ChildListMutationScope::MutationAccumulator::isAddedNodeInOrder): (WebCore::ChildListMutationScope::MutationAccumulator::childAdded): (WebCore::ChildListMutationScope::MutationAccumulator::isRemovedNodeInOrder): (WebCore::ChildListMutationScope::MutationAccumulator::willRemoveChild): (WebCore::ChildListMutationScope::MutationAccumulator::enqueueMutationRecord): (WebCore::ChildListMutationScope::MutationAccumulator::clear): (WebCore::ChildListMutationScope::MutationAccumulator::isEmpty): (WebCore::ChildListMutationScope::MutationAccumulationRouter::MutationAccumulationRouter): (WebCore::ChildListMutationScope::MutationAccumulationRouter::~MutationAccumulationRouter): (WebCore::ChildListMutationScope::MutationAccumulationRouter::initialize): (WebCore::ChildListMutationScope::MutationAccumulationRouter::instance): (WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded): (WebCore::ChildListMutationScope::MutationAccumulationRouter::willRemoveChild): (WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel): (WebCore::ChildListMutationScope::MutationAccumulationRouter::decrementScopingLevel): * dom/ChildListMutationScope.h: (WebCore::ChildListMutationScope::ChildListMutationScope): (WebCore::ChildListMutationScope::~ChildListMutationScope): (WebCore::ChildListMutationScope::childAdded): (WebCore::ChildListMutationScope::willRemoveChild): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ChildListMutationScope.cpp trunk/Source/WebCore/dom/ChildListMutationScope.h Diff Modified: trunk/Source/WebCore/ChangeLog (103078 => 103079) --- trunk/Source/WebCore/ChangeLog 2011-12-16 18:07:29 UTC (rev 103078) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 18:27:13 UTC (rev 103079) @@ -1,3 +1,44 @@ +2011-12-16 Adam Klein + +Improve performance of ChildListMutationScope when no MutationObservers are present +https://bugs.webkit.org/show_bug.cgi?id=74671 + +Reviewed by Ojan Vafai. + +Inline ChildListMutationScope's methods (including constructor and +destructor), and provide a fast-fail case when no mutation observers +are present. + +The code reorganization necessary for the above also removed the +anonymous namespace in ChildListMutationScope.cpp, making both helper +classes private inner classes of ChildListMutationScope. + +No new tests, refactoring only. + +* dom/ChildListMutationScope.cpp: +(WebCore::ChildListMutationScope::MutationAccumulator::MutationAccumulator): +(WebCore::ChildListMutationScope::MutationAccumulator::~MutationAccumulator): +(WebCore::ChildListMutationScope::MutationAccumulator::isAddedNodeInOrder): +(WebCore::ChildListMutationScope::MutationAccumulator::childAdded): +(WebCore::ChildListMutationScope::MutationAccumulator::isRemovedNodeInOrder): +(WebCore::ChildListMutationScope::MutationAccumulator::willRemoveChild): +(WebCore::ChildListMutationScope::MutationAccumulator::enqueueMutationRecord): +(WebCore::ChildListMutationScope::MutationAccumulator::clear): +(WebCore::ChildListMutationScope::MutationAccumulator::isEmpty): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::MutationAccumulationRouter): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::~MutationAccumulationRouter): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::initialize): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::instance): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::willRemoveChild): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel): +(WebCore::ChildListMutationScope::MutationAccumulationRouter::decrementScopingLevel): +* dom/ChildListMutationScope.h: +(WebCore::ChildListMutationScope::ChildListMutationScope): +(WebCore::ChildListMutationScope::~ChildListMutatio
[webkit-changes] [103078] trunk/LayoutTests
Title: [103078] trunk/LayoutTests Revision 103078 Author e...@google.com Date 2011-12-16 10:07:29 -0800 (Fri, 16 Dec 2011) Log Message [chromium] Mark fast/forms/input-text-scroll-left-on-blur.html as failing https://bugs.webkit.org/show_bug.cgi?id=74726 Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103077 => 103078) --- trunk/LayoutTests/ChangeLog 2011-12-16 18:04:15 UTC (rev 103077) +++ trunk/LayoutTests/ChangeLog 2011-12-16 18:07:29 UTC (rev 103078) @@ -1,3 +1,12 @@ +2011-12-16 Adrienne Walker + +[chromium] Mark fast/forms/input-text-scroll-left-on-blur.html as failing +https://bugs.webkit.org/show_bug.cgi?id=74726 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Philippe Normand Unreviewed, GTK rebaseline of 2 fat/forms tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103077 => 103078) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 18:04:15 UTC (rev 103077) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 18:07:29 UTC (rev 103078) @@ -1713,7 +1713,7 @@ BUGCR10055 MAC : fast/events/updateLayoutForHitTest.html = FAIL // New tests from WebKit Merge 42609:42671 -BUGCR10760 LINUX : fast/forms/input-text-scroll-left-on-blur.html = FAIL +//BUGCR10760 LINUX : fast/forms/input-text-scroll-left-on-blur.html = FAIL BUGCR10760 LINUX : fast/inline/25277-2.html = FAIL BUGCR10760 LINUX : fast/inline/25277.html = FAIL BUGCR10760 LINUX : svg/custom/marker-child-changes.svg = PASS FAIL @@ -4027,3 +4027,6 @@ BUGMNAGANOV : editing/input/reveal-contenteditable-on-paste-vertically.html = FAIL BUGMNAGANOV : editing/input/reveal-edit-on-input-vertically.html = FAIL BUGMNAGANOV : editing/input/reveal-edit-on-paste-vertically.html = FAIL + +// When removing this, please reenable the Linux suppression above. +BUGWK74726 : fast/forms/input-text-scroll-left-on-blur.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103077] trunk/LayoutTests
Title: [103077] trunk/LayoutTests
Revision 103077
Author ph...@webkit.org
Date 2011-12-16 10:04:15 -0800 (Fri, 16 Dec 2011)
Log Message
Unreviewed, GTK rebaseline of 2 fat/forms tests.
* platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/plaintext-mode-2-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (103076 => 103077)
--- trunk/LayoutTests/ChangeLog 2011-12-16 18:01:09 UTC (rev 103076)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 18:04:15 UTC (rev 103077)
@@ -1,3 +1,10 @@
+2011-12-16 Philippe Normand
+
+Unreviewed, GTK rebaseline of 2 fat/forms tests.
+
+* platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
+* platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
+
2011-12-16 Dean Jackson
Filters need to affect visual overflow
Modified: trunk/LayoutTests/platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt (103076 => 103077)
--- trunk/LayoutTests/platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt 2011-12-16 18:01:09 UTC (rev 103076)
+++ trunk/LayoutTests/platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt 2011-12-16 18:04:15 UTC (rev 103077)
@@ -24,7 +24,7 @@
RenderBlock {DIV} at (3,3) size 187x18
RenderText {#text} at (-217,0) size 404x17
text run at (-217,0) width 403: "this text field has a lot of text in it so that it needs to scroll"
-layer at (415,13) size 187x18 scrollX 217 scrollWidth 406
+layer at (415,13) size 187x18 scrollX 219 scrollWidth 406
RenderBlock {DIV} at (3,3) size 187x18
RenderText {#text} at (1,0) size 404x17
text run at (1,0) width 404: "this text field has a lot of text in it so that it needs to scroll"
Modified: trunk/LayoutTests/platform/gtk/fast/forms/plaintext-mode-2-expected.txt (103076 => 103077)
--- trunk/LayoutTests/platform/gtk/fast/forms/plaintext-mode-2-expected.txt 2011-12-16 18:01:09 UTC (rev 103076)
+++ trunk/LayoutTests/platform/gtk/fast/forms/plaintext-mode-2-expected.txt 2011-12-16 18:04:15 UTC (rev 103077)
@@ -34,7 +34,7 @@
RenderListMarker at (-20,0) size 16x17: "2"
RenderText {#text} at (0,0) size 331x17
text run at (0,0) width 331: "Success: document.execCommand(\"Paste\") == true"
-layer at (11,13) size 594x18 scrollX 25 scrollWidth 621
+layer at (11,13) size 594x18 scrollX 27 scrollWidth 621
RenderBlock {DIV} at (3,3) size 594x18
RenderText {#text} at (1,0) size 619x17
text run at (1,0) width 619: "This styled text, and link will be pasted into the textfield. All richness should be stripped."
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103075] trunk/LayoutTests
Title: [103075] trunk/LayoutTests Revision 103075 Author ph...@webkit.org Date 2011-12-16 09:52:04 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, skipping some svg tests still failing on GTK 64-bit after r103071. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (103074 => 103075) --- trunk/LayoutTests/ChangeLog 2011-12-16 17:28:27 UTC (rev 103074) +++ trunk/LayoutTests/ChangeLog 2011-12-16 17:52:04 UTC (rev 103075) @@ -1,3 +1,9 @@ +2011-12-16 Philippe Normand + +Unreviewed, skipping some svg tests still failing on GTK 64-bit after r103071. + +* platform/gtk/Skipped: + 2011-12-16 Alexis Menard , Jakub Wieczorek Add support for . Modified: trunk/LayoutTests/platform/gtk/Skipped (103074 => 103075) --- trunk/LayoutTests/platform/gtk/Skipped 2011-12-16 17:28:27 UTC (rev 103074) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-12-16 17:52:04 UTC (rev 103075) @@ -1455,6 +1455,7 @@ # 1 pixel difference between 64-bits and 32-bits # Some of these also present rounding issues and xx.00 vs xx. +# https://bugs.webkit.org/show_bug.cgi?id=62204 svg/as-image/img-preserveAspectRatio-support-1.html svg/batik/text/smallFonts.svg svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg @@ -1469,6 +1470,7 @@ svg/custom/use-on-symbol-inside-pattern.svg svg/filters/feColorMatrix-saturate.svg svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html +svg/W3C-SVG-1.1/animate-elem-40-t.svg svg/W3C-SVG-1.1/extend-namespace-01-f.svg svg/W3C-SVG-1.1/metadata-example-01-b.svg svg/W3C-SVG-1.1/paths-data-03-f.svg @@ -1487,6 +1489,11 @@ svg/W3C-SVG-1.1-SE/types-dom-04-b.svg svg/W3C-SVG-1.1-SE/types-dom-07-f.svg +# Floating point inconsistencies between 32-bit and 64-bit bots +svg/css/composite-shadow-example.html +svg/css/composite-shadow-with-opacity.html +svg/css/stars-with-shadow.html + # https://bugs.webkit.org/show_bug.cgi?id=73409 fast/forms/placeholder-set-attribute.html fast/forms/search-placeholder-value-changed.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103072] trunk/Source/WebCore
Title: [103072] trunk/Source/WebCore Revision 103072 Author rn...@webkit.org Date 2011-12-16 08:53:49 -0800 (Fri, 16 Dec 2011) Log Message Touch RenderStyle in an attempt to fix linking errors on Chromium Windows bots. * rendering/style/RenderStyle.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/style/RenderStyle.h Diff Modified: trunk/Source/WebCore/ChangeLog (103071 => 103072) --- trunk/Source/WebCore/ChangeLog 2011-12-16 16:51:46 UTC (rev 103071) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 16:53:49 UTC (rev 103072) @@ -1,3 +1,9 @@ +2011-12-16 Ryosuke Niwa + +Touch RenderStyle in an attempt to fix linking errors on Chromium Windows bots. + +* rendering/style/RenderStyle.h: + 2011-12-14 Nat Duca [chromium] DelayBasedTimeSource should not change its timebase on late ticks Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (103071 => 103072) --- trunk/Source/WebCore/rendering/style/RenderStyle.h 2011-12-16 16:51:46 UTC (rev 103071) +++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2011-12-16 16:53:49 UTC (rev 103072) @@ -205,7 +205,7 @@ unsigned char _white_space : 3; // EWhiteSpace unsigned char _box_direction : 1; // EBoxDirection (CSS3 box_direction property, flexible box layout module) // 34 bits - + // non CSS2 inherited unsigned char m_rtlOrdering : 1; // Order unsigned char m_printColorAdjust : PrintColorAdjustBits; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103071] trunk/LayoutTests
Title: [103071] trunk/LayoutTests Revision 103071 Author ph...@webkit.org Date 2011-12-16 08:51:46 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, GTK rebaseline of some svg tests. Also unskipping the ones I got passing on my 32-bit Release build. Let's see how the bots cope with those. * platform/gtk/Skipped: * platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: * platform/gtk/svg/batik/masking/maskRegions-expected.txt: * platform/gtk/svg/custom/embedding-external-svgs-expected.txt: * platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt: * platform/gtk/svg/custom/marker-strokeWidth-changes-expected.txt: Added. * platform/gtk/svg/dom/css-transforms-expected.txt: * platform/gtk/svg/filters/feColorMatrix-values-expected.txt: * platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: * platform/gtk/svg/wicd/test-scalable-background-image1-expected.txt: Added. * platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: * platform/gtk/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt trunk/LayoutTests/platform/gtk/svg/batik/masking/maskRegions-expected.txt trunk/LayoutTests/platform/gtk/svg/custom/embedding-external-svgs-expected.txt trunk/LayoutTests/platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt trunk/LayoutTests/platform/gtk/svg/dom/css-transforms-expected.txt trunk/LayoutTests/platform/gtk/svg/filters/feColorMatrix-values-expected.txt trunk/LayoutTests/platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt Added Paths trunk/LayoutTests/platform/gtk/svg/custom/marker-strokeWidth-changes-expected.txt trunk/LayoutTests/platform/gtk/svg/wicd/test-scalable-background-image1-expected.txt trunk/LayoutTests/platform/gtk/svg/zoom/text/zoom-hixie-mixed-009-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (103070 => 103071) --- trunk/LayoutTests/ChangeLog 2011-12-16 16:31:34 UTC (rev 103070) +++ trunk/LayoutTests/ChangeLog 2011-12-16 16:51:46 UTC (rev 103071) @@ -1,3 +1,22 @@ +2011-12-15 Philippe Normand + +Unreviewed, GTK rebaseline of some svg tests. Also unskipping the +ones I got passing on my 32-bit Release build. Let's see how the +bots cope with those. + +* platform/gtk/Skipped: +* platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: +* platform/gtk/svg/batik/masking/maskRegions-expected.txt: +* platform/gtk/svg/custom/embedding-external-svgs-expected.txt: +* platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt: +* platform/gtk/svg/custom/marker-strokeWidth-changes-expected.txt: Added. +* platform/gtk/svg/dom/css-transforms-expected.txt: +* platform/gtk/svg/filters/feColorMatrix-values-expected.txt: +* platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: +* platform/gtk/svg/wicd/test-scalable-background-image1-expected.txt: Added. +* platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: +* platform/gtk/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added. + 2011-12-16 Sheriff Bot Unreviewed, rolling out r103062. Modified: trunk/LayoutTests/platform/gtk/Skipped (103070 => 103071) --- trunk/LayoutTests/platform/gtk/Skipped 2011-12-16 16:31:34 UTC (rev 103070) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-12-16 16:51:46 UTC (rev 103071) @@ -68,10 +68,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=60055 media/video-volume-slider.html -# Timing out in all the GTK bots since r87605 -# https://bugs.webkit.org/show_bug.cgi?id=61919 -svg/wicd/test-scalable-background-image1.xhtml - ### # TESTS CRASHING ### @@ -639,18 +635,6 @@ # Tests failing security/set-form-autocomplete-attribute.html -# Tests in svg/ directory -# Tests failing -svg/filters/feColorMatrix-values.svg - -# This test needs to be looked at: runs on other platforms, -# may fail here due to debug output limitations. -# https://bugs.webkit.org/show_bug.cgi?id=25645 -svg/custom/pattern-excessive-malloc.svg - -# https://bugs.webkit.org/show_bug.cgi?id=49065 -svg/animations/animate-path-nested-transforms.html - # Tests that failed because we don't have an eventSender implementation http/tests/plugins/plugin-document-has-focus.html @@ -877,18 +861,9 @@ http/tests/loading/preload-append-scan.php # SVG tests that seem to produce incorrect output -svg/custom/marker-strokeWidth-changes.svg svg/zoom/text/zoom-hixie-mixed-009.xml -svg/filters/shadow-on-rect-with-filter.svg svg/custom/mask-excessive-malloc.svg -# There seem to be some b
[webkit-changes] [103070] trunk/Source
Title: [103070] trunk/Source
Revision 103070
Author nd...@chromium.org
Date 2011-12-16 08:31:34 -0800 (Fri, 16 Dec 2011)
Log Message
[chromium] DelayBasedTimeSource should not change its timebase on late ticks
https://bugs.webkit.org/show_bug.cgi?id=74573
The original DelayBasedTimeSource was designed to shift its timebase
to the tick time when a tick came back "late." The rationale was that it is
better to just "start fresh" after a stutter. After profiling this,
this time-rebasing just destabilizes frame rate anytime the thread gets
loaded. This patch keeps the timebase stationary, leading to vastly
smoother framerates when the message loop is under load.
Reviewed by James Robinson.
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::updateState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp
trunk/Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (103069 => 103070)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 14:58:49 UTC (rev 103069)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 16:31:34 UTC (rev 103070)
@@ -1,3 +1,20 @@
+2011-12-14 Nat Duca
+
+[chromium] DelayBasedTimeSource should not change its timebase on late ticks
+https://bugs.webkit.org/show_bug.cgi?id=74573
+
+The original DelayBasedTimeSource was designed to shift its timebase
+to the tick time when a tick came back "late." The rationale was that it is
+better to just "start fresh" after a stutter. After profiling this,
+this time-rebasing just destabilizes frame rate anytime the thread gets
+loaded. This patch keeps the timebase stationary, leading to vastly
+smoother framerates when the message loop is under load.
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
+(WebCore::CCDelayBasedTimeSource::updateState):
+
2011-12-16 Sheriff Bot
Unreviewed, rolling out r103062.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp (103069 => 103070)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp 2011-12-16 14:58:49 UTC (rev 103069)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp 2011-12-16 16:31:34 UTC (rev 103070)
@@ -29,6 +29,7 @@
#include "cc/CCThread.h"
#include "cc/CCThreadTask.h"
#include
+#include
namespace WebCore {
@@ -121,11 +122,8 @@
// now=18 tickTarget=16.667 newTarget=33.333 --> tick(), postDelayedTask(floor(33.333-18)) --> postDelayedTask(15)
// This brings us back to 18+15 = 33, which was where we would have been if the task hadn't been late.
//
-// For the really late delay, we fire a tick immediately reset the timebase from the current tim. E.g.:
-// now=37 tickTarget=16.667 newTarget=53.6667 --> tick(), postDelayedTask(floor(53.667-37)) --> postDelayedTask(16)
-//
-// Here we realize we're more than a tick late. We adjust newTarget to be 16.667 from now, and post a task off that new
-// target.
+// For the really late delay, we we move to the next logical tick. The timebase is not reset.
+// now=37 tickTarget=16.667 newTarget=50.000 --> tick(), postDelayedTask(floor(50.000-37)) --> postDelayedTask(13)
void CCDelayBasedTimeSource::updateState()
{
if (m_state == STATE_INACTIVE)
@@ -138,18 +136,19 @@
m_state = STATE_ACTIVE;
}
-const double maxLateBeforeResettingTimebase = 5.0;
+int numIntervalsElapsed = static_cast(floor((now - m_tickTarget) / m_intervalMs));
+double lastEffectiveTick = m_tickTarget + m_intervalMs * numIntervalsElapsed;
+double newTickTarget = lastEffectiveTick + m_intervalMs;
-double newTickTarget = 0;
-double amountLate = now - m_tickTarget;
-if (amountLate <= maxLateBeforeResettingTimebase)
-newTickTarget = m_tickTarget + m_intervalMs;
-else
-newTickTarget = now + m_intervalMs;
+long long delay = static_cast(newTickTarget - now);
+if (!delay) {
+newTickTarget = newTickTarget + m_intervalMs;
+delay = static_cast(newTickTarget - now);
+}
// Post another task *before* the tick and update state
ASSERT(newTickTarget > now);
-postTickTask(static_cast(newTickTarget - now));
+postTickTask(delay);
m_tickTarget = newTickTarget;
// Fire the tick
Modified: trunk/Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp (103069 => 103070)
--- trunk/Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp 2011-12-16 14:58:49 UTC (rev 103069)
+++ trunk/Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp 2011-12-16 16:31:34 UTC (rev 103070)
@@ -92,6 +92,112 @@
EXPECT_FALSE(thread.hasPendingTask());
}
+// At 60Hz, when the tick returns at exactly the requested next time, make sure
+// a 16
[webkit-changes] [103069] trunk/Tools
Title: [103069] trunk/Tools Revision 103069 Author ph...@webkit.org Date 2011-12-16 06:58:49 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, skipping 3 failing GTK API tests. * Scripts/run-gtk-tests: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (103068 => 103069) --- trunk/Tools/ChangeLog 2011-12-16 14:46:20 UTC (rev 103068) +++ trunk/Tools/ChangeLog 2011-12-16 14:58:49 UTC (rev 103069) @@ -1,5 +1,11 @@ 2011-12-16 Philippe Normand +Unreviewed, skipping 3 failing GTK API tests. + +* Scripts/run-gtk-tests: + +2011-12-16 Philippe Normand + Unreviewed, GTK API tests build fix attempt. * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT. Modified: trunk/Tools/Scripts/run-gtk-tests (103068 => 103069) --- trunk/Tools/Scripts/run-gtk-tests 2011-12-16 14:46:20 UTC (rev 103068) +++ trunk/Tools/Scripts/run-gtk-tests 2011-12-16 14:58:49 UTC (rev 103069) @@ -24,7 +24,8 @@ class TestRunner: TEST_DIRS = [ "unittests", "WebKit2APITests" ] -SKIPPED = [ ] +# FIXME: https://bugs.webkit.org/show_bug.cgi?id=74717 +SKIPPED = [ "unittests/testdownload", "unittests/testwebview", "unittests/testwebresource"] def __init__(self): self._executive = Executive() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103068] trunk/Source/WebKit2
Title: [103068] trunk/Source/WebKit2
Revision 103068
Author carlo...@webkit.org
Date 2011-12-16 06:46:20 -0800 (Fri, 16 Dec 2011)
Log Message
[GTK] Use bit field for bool members of WebKitWindowPropertiesPrivate
https://bugs.webkit.org/show_bug.cgi?id=74713
Reviewed by Gustavo Noronha Silva.
Most of the members are bools, so it reduces the memory footprint.
* UIProcess/API/gtk/WebKitWindowProperties.cpp:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (103067 => 103068)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 14:41:41 UTC (rev 103067)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 14:46:20 UTC (rev 103068)
@@ -1,5 +1,16 @@
2011-12-16 Carlos Garcia Campos
+[GTK] Use bit field for bool members of WebKitWindowPropertiesPrivate
+https://bugs.webkit.org/show_bug.cgi?id=74713
+
+Reviewed by Gustavo Noronha Silva.
+
+Most of the members are bools, so it reduces the memory footprint.
+
+* UIProcess/API/gtk/WebKitWindowProperties.cpp:
+
+2011-12-16 Carlos Garcia Campos
+
[GTK] Window frame should be 0x0 when the toplevel window is not visible
https://bugs.webkit.org/show_bug.cgi?id=74709
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.cpp (103067 => 103068)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.cpp 2011-12-16 14:41:41 UTC (rev 103067)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.cpp 2011-12-16 14:46:20 UTC (rev 103068)
@@ -112,14 +112,14 @@
struct _WebKitWindowPropertiesPrivate {
GdkRectangle geometry;
-bool toolbarVisible;
-bool statusbarVisible;
-bool scrollbarsVisible;
-bool menubarVisible;
-bool locationbarVisible;
+bool toolbarVisible : 1;
+bool statusbarVisible : 1;
+bool scrollbarsVisible : 1;
+bool menubarVisible : 1;
+bool locationbarVisible : 1;
-bool resizable;
-bool fullscreen;
+bool resizable : 1;
+bool fullscreen : 1;
};
static void webkitWindowPropertiesFinalize(GObject* object)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103067] trunk/Source/WebKit2
Title: [103067] trunk/Source/WebKit2
Revision 103067
Author carlo...@webkit.org
Date 2011-12-16 06:41:41 -0800 (Fri, 16 Dec 2011)
Log Message
[GTK] Window frame should be 0x0 when the toplevel window is not visible
https://bugs.webkit.org/show_bug.cgi?id=74709
Reviewed by Gustavo Noronha Silva.
* UIProcess/API/gtk/WebKitUIClient.cpp:
(getWindowFrame): Check also whether the toplevel is visible
before getting its size and position.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (103066 => 103067)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 14:19:49 UTC (rev 103066)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 14:41:41 UTC (rev 103067)
@@ -1,3 +1,14 @@
+2011-12-16 Carlos Garcia Campos
+
+[GTK] Window frame should be 0x0 when the toplevel window is not visible
+https://bugs.webkit.org/show_bug.cgi?id=74709
+
+Reviewed by Gustavo Noronha Silva.
+
+* UIProcess/API/gtk/WebKitUIClient.cpp:
+(getWindowFrame): Check also whether the toplevel is visible
+before getting its size and position.
+
2011-12-16 Michael Bruning
[qt][wk2] Viewport info panel shows wrong current scale
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp (103066 => 103067)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp 2011-12-16 14:19:49 UTC (rev 103066)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp 2011-12-16 14:41:41 UTC (rev 103067)
@@ -112,7 +112,7 @@
{
GdkRectangle geometry = { 0, 0, 0, 0 };
GtkWidget* window = gtk_widget_get_toplevel(toImpl(page)->viewWidget());
-if (gtk_widget_is_toplevel(window)) {
+if (gtk_widget_is_toplevel(window) && gtk_widget_get_visible(window)) {
gtk_window_get_position(GTK_WINDOW(window), &geometry.x, &geometry.y);
gtk_window_get_size(GTK_WINDOW(window), &geometry.width, &geometry.height);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103066] trunk/Tools
Title: [103066] trunk/Tools
Revision 103066
Author ph...@webkit.org
Date 2011-12-16 06:19:49 -0800 (Fri, 16 Dec 2011)
Log Message
Unreviewed, GTK API tests build fix attempt.
* Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
Diff
Modified: trunk/Tools/ChangeLog (103065 => 103066)
--- trunk/Tools/ChangeLog 2011-12-16 14:17:11 UTC (rev 103065)
+++ trunk/Tools/ChangeLog 2011-12-16 14:19:49 UTC (rev 103066)
@@ -1,5 +1,11 @@
2011-12-16 Philippe Normand
+Unreviewed, GTK API tests build fix attempt.
+
+* Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
+
+2011-12-16 Philippe Normand
+
Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
* Scripts/run-gtk-tests:
Modified: trunk/Tools/Scripts/run-gtk-tests (103065 => 103066)
--- trunk/Tools/Scripts/run-gtk-tests 2011-12-16 14:17:11 UTC (rev 103065)
+++ trunk/Tools/Scripts/run-gtk-tests 2011-12-16 14:19:49 UTC (rev 103066)
@@ -68,7 +68,7 @@
return 1
test_env = os.environ
-test_env["DISPLAY"] = ":31"
+test_env["DISPLAY"] = ":55"
exit_status = [0]
def _error_handler(error):
@@ -89,7 +89,7 @@
if __name__ == "__main__":
try:
-xvfb = Executive().popen(["Xvfb", ":31", "-screen", "0", "800x600x24", "-nolisten", "tcp"],
+xvfb = Executive().popen(["Xvfb", ":55", "-screen", "0", "800x600x24", "-nolisten", "tcp"],
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
except:
sys.stderr.write("Failed to run Xvfb\n")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103065] trunk
Title: [103065] trunk Revision 103065 Author commit-qu...@webkit.org Date 2011-12-16 06:17:11 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, rolling out r103062. http://trac.webkit.org/changeset/103062 https://bugs.webkit.org/show_bug.cgi?id=74715 It broke many tests (Requested by Ossy on #webkit). Patch by Sheriff Bot on 2011-12-16 Source/WebCore: * html/HTMLAttributeNames.in: * html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::HTMLOListElement): (WebCore::HTMLOListElement::parseMappedAttribute): * html/HTMLOListElement.h: (WebCore::HTMLOListElement::start): * html/HTMLOListElement.idl: * rendering/RenderListItem.cpp: (WebCore::previousListItem): (WebCore::RenderListItem::calcValue): (WebCore::RenderListItem::explicitValueChanged): (WebCore::RenderListItem::updateListMarkerNumbers): * rendering/RenderListItem.h: LayoutTests: * fast/lists/ol-reversed-dynamic-expected.txt: Removed. * fast/lists/ol-reversed-dynamic-simple-expected.txt: Removed. * fast/lists/ol-reversed-dynamic-simple.html: Removed. * fast/lists/ol-reversed-dynamic.html: Removed. * fast/lists/ol-reversed-nested-items-expected.txt: Removed. * fast/lists/ol-reversed-nested-items.html: Removed. * fast/lists/ol-reversed-nested-list-expected.txt: Removed. * fast/lists/ol-reversed-nested-list.html: Removed. * fast/lists/ol-reversed-simple-expected.txt: Removed. * fast/lists/ol-reversed-simple.html: Removed. * fast/lists/ol-reversed-simple.xhtml: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLAttributeNames.in trunk/Source/WebCore/html/HTMLOListElement.cpp trunk/Source/WebCore/html/HTMLOListElement.h trunk/Source/WebCore/html/HTMLOListElement.idl trunk/Source/WebCore/rendering/RenderListItem.cpp trunk/Source/WebCore/rendering/RenderListItem.h Removed Paths trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple.html trunk/LayoutTests/fast/lists/ol-reversed-dynamic.html trunk/LayoutTests/fast/lists/ol-reversed-nested-items-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-nested-items.html trunk/LayoutTests/fast/lists/ol-reversed-nested-list-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-nested-list.html trunk/LayoutTests/fast/lists/ol-reversed-simple-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-simple.html trunk/LayoutTests/fast/lists/ol-reversed-simple.xhtml Diff Modified: trunk/LayoutTests/ChangeLog (103064 => 103065) --- trunk/LayoutTests/ChangeLog 2011-12-16 14:14:36 UTC (rev 103064) +++ trunk/LayoutTests/ChangeLog 2011-12-16 14:17:11 UTC (rev 103065) @@ -1,3 +1,23 @@ +2011-12-16 Sheriff Bot + +Unreviewed, rolling out r103062. +http://trac.webkit.org/changeset/103062 +https://bugs.webkit.org/show_bug.cgi?id=74715 + +It broke many tests (Requested by Ossy on #webkit). + +* fast/lists/ol-reversed-dynamic-expected.txt: Removed. +* fast/lists/ol-reversed-dynamic-simple-expected.txt: Removed. +* fast/lists/ol-reversed-dynamic-simple.html: Removed. +* fast/lists/ol-reversed-dynamic.html: Removed. +* fast/lists/ol-reversed-nested-items-expected.txt: Removed. +* fast/lists/ol-reversed-nested-items.html: Removed. +* fast/lists/ol-reversed-nested-list-expected.txt: Removed. +* fast/lists/ol-reversed-nested-list.html: Removed. +* fast/lists/ol-reversed-simple-expected.txt: Removed. +* fast/lists/ol-reversed-simple.html: Removed. +* fast/lists/ol-reversed-simple.xhtml: Removed. + 2011-12-16 Philippe Normand Unreviewed, GTK test_expectations update. Deleted: trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt (103064 => 103065) --- trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt 2011-12-16 14:14:36 UTC (rev 103064) +++ trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt 2011-12-16 14:17:11 UTC (rev 103065) @@ -1,40 +0,0 @@ -This tests that changing the value of an item updates markers accordingly. - -10 Ten -9 Nine -8 Eight -7 Seven -6 Six - -This tests that resetting the value of an item updates markers accordingly. - -5 Five -4 Four -3 Three -2 Two -1 One - -This tests that changing the start value of the list updates markers accordingly. - -20 Twenty -19 Nineteen -18 Eighteen -17 Seventeen -16 Sixteen - -This tests that removing the custom start value of the list updates markers accordingly. - -5 Five -4 Four -3 Three -2 Two -1 One - -This tests that changing the custom start value from 1 to "" works. - -5 Five -4 Four -3 Three -2 Two -1 One - Deleted: trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple-expected.txt (103064 => 103065) --- trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple-expected.txt 2011-12-16 14:14:36 UTC (rev 103064) +++ trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple-expected.txt 2011-12-16 14:1
[webkit-changes] [103064] trunk/LayoutTests
Title: [103064] trunk/LayoutTests Revision 103064 Author ph...@webkit.org Date 2011-12-16 06:14:36 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, GTK test_expectations update. * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103063 => 103064) --- trunk/LayoutTests/ChangeLog 2011-12-16 13:59:01 UTC (rev 103063) +++ trunk/LayoutTests/ChangeLog 2011-12-16 14:14:36 UTC (rev 103064) @@ -4,6 +4,12 @@ * platform/gtk/test_expectations.txt: +2011-12-16 Philippe Normand + +Unreviewed, GTK test_expectations update. + +* platform/gtk/test_expectations.txt: + 2011-12-16 Alexis Menard , Jakub Wieczorek Add support for . Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (103063 => 103064) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2011-12-16 13:59:01 UTC (rev 103063) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2011-12-16 14:14:36 UTC (rev 103064) @@ -79,7 +79,7 @@ BUGWK72698 : media/audio-garbage-collect.html = PASS TEXT -BUGWK72694 : fast/canvas/canvas-lineWidth.html = PASS TEXT +BUGWK72694 : fast/canvas/canvas-lineWidth.html = PASS TIMEOUT TEXT BUGWK73772 : fast/table/multiple-captions-display.xhtml = PASS TEXT BUGWK74279 : fullscreen/full-screen-iframe-legacy.html = PASS TEXT @@ -91,7 +91,6 @@ BUGWK74493 : platform/gtk/accessibility/unknown-roles-not-exposed.html = PASS TEXT BUGWK74710 : editing/pasteboard/paste-text-013.html = PASS TEXT -BUGWK74712 : fast/canvas/canvas-lineWidth.html = PASS TIMEOUT TEXT // End of Flaky tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103063] trunk/LayoutTests
Title: [103063] trunk/LayoutTests Revision 103063 Author ph...@webkit.org Date 2011-12-16 05:59:01 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, GTK test_expectations update. * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103062 => 103063) --- trunk/LayoutTests/ChangeLog 2011-12-16 13:43:37 UTC (rev 103062) +++ trunk/LayoutTests/ChangeLog 2011-12-16 13:59:01 UTC (rev 103063) @@ -1,3 +1,9 @@ +2011-12-16 Philippe Normand + +Unreviewed, GTK test_expectations update. + +* platform/gtk/test_expectations.txt: + 2011-12-16 Alexis Menard , Jakub Wieczorek Add support for . Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (103062 => 103063) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2011-12-16 13:43:37 UTC (rev 103062) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2011-12-16 13:59:01 UTC (rev 103063) @@ -90,6 +90,9 @@ BUGWK74493 : platform/gtk/accessibility/unknown-roles-not-exposed.html = PASS TEXT +BUGWK74710 : editing/pasteboard/paste-text-013.html = PASS TEXT +BUGWK74712 : fast/canvas/canvas-lineWidth.html = PASS TIMEOUT TEXT + // End of Flaky tests BUGWK73766 : css3/unicode-bidi-isolate-aharon-failing.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103062] trunk
Title: [103062] trunk Revision 103062 Author alexis.men...@openbossa.org Date 2011-12-16 05:43:37 -0800 (Fri, 16 Dec 2011) Log Message Add support for . https://bugs.webkit.org/show_bug.cgi?id=36724 The reversed attribute makes an ordered list appear with marker values decreasing from n, where n is the number of items. See: http://www.whatwg.org/specs/web-apps/current-work/#attr-ol-reversed Patch by Alexis Menard , Jakub Wieczorek on 2011-12-16 Reviewed by Darin Adler. Source/WebCore: Tests: fast/lists/ol-reversed-dynamic-simple.html fast/lists/ol-reversed-dynamic.html fast/lists/ol-reversed-nested-items.html fast/lists/ol-reversed-nested-list.html fast/lists/ol-reversed-simple.html * html/HTMLAttributeNames.in: * html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::HTMLOListElement): (WebCore::HTMLOListElement::parseMappedAttribute): (WebCore::HTMLOListElement::updateItemValues): (WebCore::HTMLOListElement::recalculateItemCount): * html/HTMLOListElement.h: (WebCore::HTMLOListElement::start): (WebCore::HTMLOListElement::isReversed): (WebCore::HTMLOListElement::itemCountChanged): (WebCore::HTMLOListElement::itemCount): * html/HTMLOListElement.idl: * rendering/RenderListItem.cpp: (WebCore::RenderListItem::nextListItem): (WebCore::previousListItem): (WebCore::RenderListItem::calcValue): (WebCore::RenderListItem::explicitValueChanged): (WebCore::previousOrNextItem): (WebCore::RenderListItem::updateListMarkerNumbers): * rendering/RenderListItem.h: LayoutTests: * fast/lists/ol-reversed-dynamic-expected.txt: Added. * fast/lists/ol-reversed-dynamic-simple-expected.txt: Added. * fast/lists/ol-reversed-dynamic-simple.html: Added. * fast/lists/ol-reversed-dynamic.html: Added. * fast/lists/ol-reversed-nested-items-expected.txt: Added. * fast/lists/ol-reversed-nested-items.html: Added. * fast/lists/ol-reversed-nested-list-expected.txt: Added. * fast/lists/ol-reversed-nested-list.html: Added. * fast/lists/ol-reversed-simple-expected.txt: Added. * fast/lists/ol-reversed-simple.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLAttributeNames.in trunk/Source/WebCore/html/HTMLOListElement.cpp trunk/Source/WebCore/html/HTMLOListElement.h trunk/Source/WebCore/html/HTMLOListElement.idl trunk/Source/WebCore/rendering/RenderListItem.cpp trunk/Source/WebCore/rendering/RenderListItem.h Added Paths trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple.html trunk/LayoutTests/fast/lists/ol-reversed-dynamic.html trunk/LayoutTests/fast/lists/ol-reversed-nested-items-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-nested-items.html trunk/LayoutTests/fast/lists/ol-reversed-nested-list-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-nested-list.html trunk/LayoutTests/fast/lists/ol-reversed-simple-expected.txt trunk/LayoutTests/fast/lists/ol-reversed-simple.html trunk/LayoutTests/fast/lists/ol-reversed-simple.xhtml Diff Modified: trunk/LayoutTests/ChangeLog (103061 => 103062) --- trunk/LayoutTests/ChangeLog 2011-12-16 13:39:27 UTC (rev 103061) +++ trunk/LayoutTests/ChangeLog 2011-12-16 13:43:37 UTC (rev 103062) @@ -1,3 +1,25 @@ +2011-12-16 Alexis Menard , Jakub Wieczorek + +Add support for . +https://bugs.webkit.org/show_bug.cgi?id=36724 + +The reversed attribute makes an ordered list appear with marker values +decreasing from n, where n is the number of items. +See: http://www.whatwg.org/specs/web-apps/current-work/#attr-ol-reversed + +Reviewed by Darin Adler. + +* fast/lists/ol-reversed-dynamic-expected.txt: Added. +* fast/lists/ol-reversed-dynamic-simple-expected.txt: Added. +* fast/lists/ol-reversed-dynamic-simple.html: Added. +* fast/lists/ol-reversed-dynamic.html: Added. +* fast/lists/ol-reversed-nested-items-expected.txt: Added. +* fast/lists/ol-reversed-nested-items.html: Added. +* fast/lists/ol-reversed-nested-list-expected.txt: Added. +* fast/lists/ol-reversed-nested-list.html: Added. +* fast/lists/ol-reversed-simple-expected.txt: Added. +* fast/lists/ol-reversed-simple.html: Added. + 2011-12-16 Hajime Morrita Unreviewed, test_expectations.txt update. Added: trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt (0 => 103062) --- trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt (rev 0) +++ trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt 2011-12-16 13:43:37 UTC (rev 103062) @@ -0,0 +1,40 @@ +This tests that changing the value of an item updates markers accordingly. + +10 Ten +9 Nine +8 Eight +7 Seven +6 Six + +This tests that resetting the value of an item updates markers accordingly. + +5 Five +4 Four +3 Three +2 Two +1 One + +This tests that changing the s
[webkit-changes] [103061] trunk/Tools
Title: [103061] trunk/Tools Revision 103061 Author ph...@webkit.org Date 2011-12-16 05:39:27 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, unskipping GTK testdownload. Should pass on the bot now. * Scripts/run-gtk-tests: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (103060 => 103061) --- trunk/Tools/ChangeLog 2011-12-16 13:35:55 UTC (rev 103060) +++ trunk/Tools/ChangeLog 2011-12-16 13:39:27 UTC (rev 103061) @@ -1,3 +1,9 @@ +2011-12-16 Philippe Normand + +Unreviewed, unskipping GTK testdownload. Should pass on the bot now. + +* Scripts/run-gtk-tests: + 2011-12-16 Simon Hausmann [Qt] Fix the build for newer Qt5 Modified: trunk/Tools/Scripts/run-gtk-tests (103060 => 103061) --- trunk/Tools/Scripts/run-gtk-tests 2011-12-16 13:35:55 UTC (rev 103060) +++ trunk/Tools/Scripts/run-gtk-tests 2011-12-16 13:39:27 UTC (rev 103061) @@ -24,7 +24,7 @@ class TestRunner: TEST_DIRS = [ "unittests", "WebKit2APITests" ] -SKIPPED = [ "unittests/testdownload" ] +SKIPPED = [ ] def __init__(self): self._executive = Executive() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103060] trunk/Tools
Title: [103060] trunk/Tools
Revision 103060
Author o...@webkit.org
Date 2011-12-16 05:35:55 -0800 (Fri, 16 Dec 2011)
Log Message
[Qt] Fix the build for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=74703
Patch by Simon Hausmann on 2011-12-16
Reviewed by Csaba Osztrogonác.
* QtTestBrowser/launcherwindow.h: Add missing forward declaration.
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
* WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
(WTR::EventSenderProxy::sendTouchEvent):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::sendTouchEvent): Ditto.
(MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp
trunk/Tools/QtTestBrowser/launcherwindow.h
trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp
Diff
Modified: trunk/Tools/ChangeLog (103059 => 103060)
--- trunk/Tools/ChangeLog 2011-12-16 13:04:50 UTC (rev 103059)
+++ trunk/Tools/ChangeLog 2011-12-16 13:35:55 UTC (rev 103060)
@@ -1,3 +1,19 @@
+2011-12-16 Simon Hausmann
+
+[Qt] Fix the build for newer Qt5
+https://bugs.webkit.org/show_bug.cgi?id=74703
+
+Reviewed by Csaba Osztrogonác.
+
+* QtTestBrowser/launcherwindow.h: Add missing forward declaration.
+* DumpRenderTree/qt/EventSenderQt.cpp:
+(EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
+* WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
+(WTR::EventSenderProxy::sendTouchEvent):
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::sendTouchEvent): Ditto.
+(MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
+
2011-12-16 Tor Arne Vestbø
[Qt] Detect and force clean build when feature defines are added
Modified: trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp (103059 => 103060)
--- trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp 2011-12-16 13:04:50 UTC (rev 103059)
+++ trunk/Tools/DumpRenderTree/qt/EventSenderQt.cpp 2011-12-16 13:35:55 UTC (rev 103060)
@@ -480,7 +480,18 @@
void EventSender::sendTouchEvent(QEvent::Type type)
{
+#if QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
+static QTouchDevice* device = 0;
+if (!device) {
+device = new QTouchDevice;
+device->setType(QTouchDevice::TouchScreen);
+QWindowSystemInterface::registerTouchDevice(device);
+}
+
+QTouchEvent event(type, device, m_touchModifiers);
+#else
QTouchEvent event(type, QTouchEvent::TouchScreen, m_touchModifiers);
+#endif
event.setTouchPoints(m_touchPoints);
sendEvent(m_page, &event);
QList::Iterator it = m_touchPoints.begin();
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (103059 => 103060)
--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2011-12-16 13:04:50 UTC (rev 103059)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2011-12-16 13:35:55 UTC (rev 103060)
@@ -111,7 +111,6 @@
QWindowSystemInterface::TouchPoint touchPoint;
touchPoint.area = QRectF(mouseEvent->globalPos(), QSizeF(1, 1));
touchPoint.pressure = 1;
-touchPoint.isPrimary = false;
switch (mouseEvent->type()) {
case QEvent::MouseButtonPress:
@@ -142,7 +141,7 @@
// Update current touch-point
if (m_touchPoints.isEmpty())
-touchPoint.isPrimary = true;
+touchPoint.flags |= QTouchEvent::TouchPoint::Primary;
m_touchPoints.insert(touchPoint.id, touchPoint);
// Update states for all other touch-points
@@ -159,8 +158,15 @@
void MiniBrowserApplication::sendTouchEvent(BrowserWindow* browserWindow)
{
+static QTouchDevice* device = 0;
+if (!device) {
+device = new QTouchDevice;
+device->setType(QTouchDevice::TouchScreen);
+QWindowSystemInterface::registerTouchDevice(device);
+}
+
m_pendingFakeTouchEventCount++;
-QWindowSystemInterface::handleTouchEvent(browserWindow, QEvent::None, QTouchEvent::TouchScreen, m_touchPoints.values());
+QWindowSystemInterface::handleTouchEvent(browserWindow, QEvent::None, device, m_touchPoints.values());
if (!m_windowOptions.useTraditionalDesktopBehavior())
browserWindow->updateVisualMockTouchPoints(m_touchPoints.values());
Modified: trunk/Tools/QtTestBrowser/launcherwindow.h (103059 => 103060)
--- trunk/Tools/QtTestBrowser/launcherwindow.h 2011-12-16 13:04:50 UTC (rev 103059)
+++ trunk/Tools/QtTestBrowser/launcherwindow.h 2011-12-16 13:35:55 UTC (rev 103060)
@@ -64,6 +64,7 @@
#include "webview.h"
class QPropertyAnimation;
+class QLineEdit;
class WindowOptions {
public:
Modified: trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp (103059 => 103060)
--- trunk/Tools/W
[webkit-changes] [103059] trunk/Source
Title: [103059] trunk/Source
Revision 103059
Author senorbla...@chromium.org
Date 2011-12-16 05:04:50 -0800 (Fri, 16 Dec 2011)
Log Message
Enable CSS_FILTERS in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=74334
Reviewed by Chris Marrin.
Source/WebCore:
Covered by css3/filters (when enabled).
* platform/graphics/filters/FilterOperation.h:
(WebCore::PassthroughFilterOperation::PassthroughFilterOperation):
Since wingdi.h #define's PASSTHROUGH, #undef it after the includes.
Source/WebKit/chromium:
* features.gypi:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
Diff
Modified: trunk/Source/WebCore/ChangeLog (103058 => 103059)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 12:41:10 UTC (rev 103058)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 13:04:50 UTC (rev 103059)
@@ -1,3 +1,16 @@
+2011-12-15 Stephen White
+
+Enable CSS_FILTERS in Chromium.
+https://bugs.webkit.org/show_bug.cgi?id=74334
+
+Reviewed by Chris Marrin.
+
+Covered by css3/filters (when enabled).
+
+* platform/graphics/filters/FilterOperation.h:
+(WebCore::PassthroughFilterOperation::PassthroughFilterOperation):
+Since wingdi.h #define's PASSTHROUGH, #undef it after the includes.
+
2011-12-16 Patrick Gansterer
Unreviewed WinCE build fix after r102979.
Modified: trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h (103058 => 103059)
--- trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2011-12-16 12:41:10 UTC (rev 103058)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2011-12-16 13:04:50 UTC (rev 103059)
@@ -35,6 +35,11 @@
#include
#include
+// Annoyingly, wingdi.h #defines this.
+#ifdef PASSTHROUGH
+#undef PASSTHROUGH
+#endif
+
namespace WebCore {
// CSS Filters
Modified: trunk/Source/WebKit/chromium/ChangeLog (103058 => 103059)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 12:41:10 UTC (rev 103058)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 13:04:50 UTC (rev 103059)
@@ -1,3 +1,12 @@
+2011-12-15 Stephen White
+
+Enable CSS_FILTERS in Chromium.
+https://bugs.webkit.org/show_bug.cgi?id=74334
+
+Reviewed by Chris Marrin.
+
+* features.gypi:
+
2011-12-15 Yongjun Zhang
PODIntervalTree takes 1.7MB memory on www.nytimes.com.
Modified: trunk/Source/WebKit/chromium/features.gypi (103058 => 103059)
--- trunk/Source/WebKit/chromium/features.gypi 2011-12-16 12:41:10 UTC (rev 103058)
+++ trunk/Source/WebKit/chromium/features.gypi 2011-12-16 13:04:50 UTC (rev 103059)
@@ -37,6 +37,7 @@
'ENABLE_BLOB_SLICE=1',
'ENABLE_CHANNEL_MESSAGING=1',
'ENABLE_CLIENT_BASED_GEOLOCATION=1',
+ 'ENABLE_CSS_FILTERS=1',
'ENABLE_DASHBOARD_SUPPORT=0',
'ENABLE_DATA_TRANSFER_ITEMS=1',
'ENABLE_DETAILS=1',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103058] trunk/Tools
Title: [103058] trunk/Tools
Revision 103058
Author ves...@webkit.org
Date 2011-12-16 04:41:10 -0800 (Fri, 16 Dec 2011)
Log Message
[Qt] Detect and force clean build when feature defines are added
Reviewed by Ossy.
https://bugs.webkit.org/show_bug.cgi?id=74689
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (103057 => 103058)
--- trunk/Tools/ChangeLog 2011-12-16 12:22:09 UTC (rev 103057)
+++ trunk/Tools/ChangeLog 2011-12-16 12:41:10 UTC (rev 103058)
@@ -1,3 +1,13 @@
+2011-12-16 Tor Arne Vestbø
+
+[Qt] Detect and force clean build when feature defines are added
+
+Reviewed by Ossy.
+
+https://bugs.webkit.org/show_bug.cgi?id=74689
+
+* Scripts/webkitdirs.pm:
+
2011-12-16 Kentaro Hara
[Refactoring] Remove all global variables from prepare-ChangeLog
Modified: trunk/Tools/Scripts/webkitdirs.pm (103057 => 103058)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-12-16 12:22:09 UTC (rev 103057)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-12-16 12:41:10 UTC (rev 103058)
@@ -1905,46 +1905,55 @@
my $needsCleanBuild = 0;
+my $pathToDefinesCache = File::Spec->catfile($dir, ".webkit.config");
+my $pathToOldDefinesFile = File::Spec->catfile($dir, "defaults.txt");
+
# Ease transition to new build layout
-my $pathToOldDefinesFile = File::Spec->catfile($dir, "defaults.txt");
if (-e $pathToOldDefinesFile) {
print "Old build layout detected";
$needsCleanBuild = 1;
-}
+} elsif (-e $pathToDefinesCache && open(DEFAULTS, $pathToDefinesCache)) {
+my %previousDefines;
+while () {
+if ($_ =~ m/(\S+?)=(\S+?)/gi) {
+$previousDefines{$1} = $2;
+}
+}
+close (DEFAULTS);
-my $pathToDefinesCache = File::Spec->catfile($dir, ".webkit.config");
-if ($needsCleanBuild || (-e $pathToDefinesCache && open(DEFAULTS, $pathToDefinesCache))) {
-if (!$needsCleanBuild) {
-while () {
-if ($_ =~ m/(\S+?)=(\S+?)/gi) {
-if (! exists $defines{$1}) {
-print "Feature $1 was removed";
-$needsCleanBuild = 1;
-last;
-}
+my @uniqueDefineNames = keys %{ +{ map { $_, 1 } (keys %defines, keys %previousDefines) } };
+foreach my $define (@uniqueDefineNames) {
+if (! exists $previousDefines{$define}) {
+print "Feature $define added";
+$needsCleanBuild = 1;
+last;
+}
-if ($defines{$1} != $2) {
-print "Feature $1 has changed ($2 -> $defines{$1})";
-$needsCleanBuild = 1;
-last;
-}
-}
+if (! exists $defines{$define}) {
+print "Feature $define removed";
+$needsCleanBuild = 1;
+last;
}
-close (DEFAULTS);
-}
-if ($needsCleanBuild) {
-print ", clean build needed!\n";
-# FIXME: This STDIN/STDOUT check does not work on the bots. Disable until it does.
-# if (! -t STDIN || ( &promptUser("Would you like to clean the build directory?", "yes") eq "yes")) {
-chdir $originalCwd;
-File::Path::rmtree($dir);
-File::Path::mkpath($dir);
-chdir $dir or die "Failed to cd into " . $dir . "\n";
-#}
+if ($defines{$define} != $previousDefines{$define}) {
+print "Feature $define changed ($previousDefines{$define} -> $defines{$define})";
+$needsCleanBuild = 1;
+last;
+}
}
}
+if ($needsCleanBuild) {
+print ", clean build needed!\n";
+# FIXME: This STDIN/STDOUT check does not work on the bots. Disable until it does.
+# if (! -t STDIN || ( &promptUser("Would you like to clean the build directory?", "yes") eq "yes")) {
+chdir $originalCwd;
+File::Path::rmtree($dir);
+File::Path::mkpath($dir);
+chdir $dir or die "Failed to cd into " . $dir . "\n";
+#}
+}
+
open(DEFAULTS, ">$pathToDefinesCache");
print DEFAULTS "# These defines were set when building WebKit last time\n";
foreach my $key (sort keys %defines) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103057] trunk/LayoutTests
Title: [103057] trunk/LayoutTests Revision 103057 Author morr...@google.com Date 2011-12-16 04:22:09 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, test_expectations.txt update. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103056 => 103057) --- trunk/LayoutTests/ChangeLog 2011-12-16 12:19:27 UTC (rev 103056) +++ trunk/LayoutTests/ChangeLog 2011-12-16 12:22:09 UTC (rev 103057) @@ -1,3 +1,9 @@ +2011-12-16 Hajime Morrita + +Unreviewed, test_expectations.txt update. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Hajime Morrita Unreviewed, test_expectations.txt update. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103056 => 103057) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 12:19:27 UTC (rev 103056) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 12:22:09 UTC (rev 103057) @@ -3965,7 +3965,7 @@ // Need rebaseline on Linux and Win GPU BUGWK73905 GPU LINUX : media/video-layer-crash.html = IMAGE+TEXT -BUGWK73905 GPU LINUX : media/video-transformed.html = IMAGE +BUGWK73905 GPU : media/video-transformed.html = IMAGE BUGWK73905 GPU LINUX : media/video-zoom-controls.html = IMAGE BUGWK73905 GPU WIN : media/video-layer-crash.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103056] trunk/Source/WebCore
Title: [103056] trunk/Source/WebCore
Revision 103056
Author par...@webkit.org
Date 2011-12-16 04:19:27 -0800 (Fri, 16 Dec 2011)
Log Message
Unreviewed WinCE build fix after r102979.
Make everHadLayout() public accessible as it was before the change.
* rendering/RenderObject.h:
(WebCore::RenderObject::everHadLayout):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (103055 => 103056)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 11:28:17 UTC (rev 103055)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 12:19:27 UTC (rev 103056)
@@ -1,3 +1,12 @@
+2011-12-16 Patrick Gansterer
+
+Unreviewed WinCE build fix after r102979.
+
+Make everHadLayout() public accessible as it was before the change.
+
+* rendering/RenderObject.h:
+(WebCore::RenderObject::everHadLayout):
+
2011-12-15 Hans Wennborg
IndexedDB: Don't prefetch values from key cursors
Modified: trunk/Source/WebCore/rendering/RenderObject.h (103055 => 103056)
--- trunk/Source/WebCore/rendering/RenderObject.h 2011-12-16 11:28:17 UTC (rev 103055)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2011-12-16 12:19:27 UTC (rev 103056)
@@ -371,6 +371,7 @@
bool hasCounterNodeMap() const { return m_bitfields.hasCounterNodeMap(); }
void setHasCounterNodeMap(bool hasCounterNodeMap) { m_bitfields.setHasCounterNodeMap(hasCounterNodeMap); }
+bool everHadLayout() const { return m_bitfields.everHadLayout(); }
bool childrenInline() const { return m_bitfields.childrenInline(); }
void setChildrenInline(bool b) { m_bitfields.setChildrenInline(b); }
@@ -852,8 +853,6 @@
}
protected:
-bool everHadLayout() const { return m_bitfields.everHadLayout(); }
-
// Overrides should call the superclass at the end
virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle);
// Overrides should call the superclass at the start
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103055] trunk/LayoutTests
Title: [103055] trunk/LayoutTests Revision 103055 Author morr...@google.com Date 2011-12-16 03:28:17 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed, test_expectations.txt update. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103054 => 103055) --- trunk/LayoutTests/ChangeLog 2011-12-16 11:27:36 UTC (rev 103054) +++ trunk/LayoutTests/ChangeLog 2011-12-16 11:28:17 UTC (rev 103055) @@ -1,3 +1,9 @@ +2011-12-16 Hajime Morrita + +Unreviewed, test_expectations.txt update. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Hajime Morrita Unreviewed, rolling out r103044. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103054 => 103055) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 11:27:36 UTC (rev 103054) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 11:28:17 UTC (rev 103055) @@ -3505,8 +3505,8 @@ BUGWK65453 MAC : fast/css/outline-auto-empty-rects.html = IMAGE -BUGWK65462 VISTA LINUX : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT -BUGWK74694 LINUX : http/tests/cache/history-only-cached-subresource-loads.html = PASS TIMEOUT +BUGWK65462 VISTA LINUX : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT TEXT +BUGWK74694 LINUX : http/tests/cache/history-only-cached-subresource-loads.html = PASS TIMEOUT TEXT BUGWK67915 LINUX WIN : fast/borders/borderRadiusDashed06.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103054] trunk/Source/WebKit2
Title: [103054] trunk/Source/WebKit2
Revision 103054
Author commit-qu...@webkit.org
Date 2011-12-16 03:27:36 -0800 (Fri, 16 Dec 2011)
Log Message
[qt][wk2] Viewport info panel shows wrong current scale
https://bugs.webkit.org/show_bug.cgi?id=74613
Patch by Michael Bruning on 2011-12-16
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::currentScale): Added division by devicePixelRatio. Also
added emission of currenScaleUpdated signal when the viewport constraints
have been updated.
(QWebViewportInfo::didUpdateViewportConstraints):
* UIProcess/API/qt/qwebviewportinfo_p.h: Changed return type of
currentScale to QVariant as it depends on the viewport interaction engine
now.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary): Changed
to use currentCSSScale for getting the current css scale.
(WebKit::QtViewportInteractionEngine::currentCSSScale): Added.
* UIProcess/qt/QtViewportInteractionEngine.h: Added method currentCSSScale.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (103053 => 103054)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 11:10:24 UTC (rev 103053)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 11:27:36 UTC (rev 103054)
@@ -1,3 +1,24 @@
+2011-12-16 Michael Bruning
+
+[qt][wk2] Viewport info panel shows wrong current scale
+https://bugs.webkit.org/show_bug.cgi?id=74613
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/API/qt/qwebviewportinfo.cpp:
+(QWebViewportInfo::currentScale): Added division by devicePixelRatio. Also
+added emission of currenScaleUpdated signal when the viewport constraints
+have been updated.
+(QWebViewportInfo::didUpdateViewportConstraints):
+* UIProcess/API/qt/qwebviewportinfo_p.h: Changed return type of
+currentScale to QVariant as it depends on the viewport interaction engine
+now.
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary): Changed
+to use currentCSSScale for getting the current css scale.
+(WebKit::QtViewportInteractionEngine::currentCSSScale): Added.
+* UIProcess/qt/QtViewportInteractionEngine.h: Added method currentCSSScale.
+
2011-12-15 Martin Robinson
Fix 'make dist' in preparation for the GTK+ release.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp (103053 => 103054)
--- trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp 2011-12-16 11:10:24 UTC (rev 103053)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp 2011-12-16 11:27:36 UTC (rev 103054)
@@ -41,9 +41,12 @@
return QSize(m_webViewPrivate->pageView->width(), m_webViewPrivate->pageView->height());
}
-qreal QWebViewportInfo::currentScale() const
+QVariant QWebViewportInfo::currentScale() const
{
-return m_webViewPrivate->pageView->scale();
+if (!m_webViewPrivate->interactionEngine)
+return QVariant();
+
+return m_webViewPrivate->interactionEngine->currentCSSScale();
}
QVariant QWebViewportInfo::devicePixelRatio() const
@@ -107,4 +110,5 @@
void QWebViewportInfo::didUpdateViewportConstraints()
{
emit viewportConstraintsUpdated();
+emit currentScaleUpdated();
}
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h (103053 => 103054)
--- trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h 2011-12-16 11:10:24 UTC (rev 103053)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h 2011-12-16 11:27:36 UTC (rev 103054)
@@ -37,7 +37,7 @@
class QWEBKIT_EXPORT QWebViewportInfo : public QObject {
Q_OBJECT
Q_PROPERTY(QSize contentsSize READ contentsSize NOTIFY contentsSizeUpdated)
-Q_PROPERTY(qreal currentScale READ currentScale NOTIFY currentScaleUpdated)
+Q_PROPERTY(QVariant currentScale READ currentScale NOTIFY currentScaleUpdated)
Q_PROPERTY(QVariant devicePixelRatio READ devicePixelRatio NOTIFY viewportConstraintsUpdated)
Q_PROPERTY(QVariant initialScale READ initialScale NOTIFY viewportConstraintsUpdated)
Q_PROPERTY(QVariant isScalable READ isScalable NOTIFY viewportConstraintsUpdated)
@@ -55,7 +55,7 @@
virtual ~QWebViewportInfo();
QSize contentsSize() const;
-qreal currentScale() const;
+QVariant currentScale() const;
QVariant devicePixelRatio() const;
QVariant initialScale() const;
QVariant isScalable() const;
Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (103053 => 103054)
--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cp
[webkit-changes] [103053] trunk/LayoutTests
Title: [103053] trunk/LayoutTests
Revision 103053
Author morr...@google.com
Date 2011-12-16 03:10:24 -0800 (Fri, 16 Dec 2011)
Log Message
Unreviewed, rolling out r103044.
http://trac.webkit.org/changeset/103044
https://bugs.webkit.org/show_bug.cgi?id=72940
Added test doesn't pass on Mac SL and Mac Chromium
* editing/spelling/spellcheck-async-mutation-expected.txt: Removed.
* editing/spelling/spellcheck-async-mutation.html: Removed.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac-leopard/Skipped
trunk/LayoutTests/platform/qt/Skipped
Removed Paths
trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt
trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (103052 => 103053)
--- trunk/LayoutTests/ChangeLog 2011-12-16 10:51:22 UTC (rev 103052)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 11:10:24 UTC (rev 103053)
@@ -1,3 +1,17 @@
+2011-12-16 Hajime Morrita
+
+Unreviewed, rolling out r103044.
+http://trac.webkit.org/changeset/103044
+https://bugs.webkit.org/show_bug.cgi?id=72940
+
+Added test doesn't pass on Mac SL and Mac Chromium
+
+* editing/spelling/spellcheck-async-mutation-expected.txt: Removed.
+* editing/spelling/spellcheck-async-mutation.html: Removed.
+* platform/gtk/Skipped:
+* platform/mac-leopard/Skipped:
+* platform/qt/Skipped:
+
2011-12-16 Yosifumi Inoue
[Forms] The "maxlength" attribute on "textarea" tag miscounts hard newlines
Deleted: trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt (103052 => 103053)
--- trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt 2011-12-16 10:51:22 UTC (rev 103052)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt 2011-12-16 11:10:24 UTC (rev 103053)
@@ -1,45 +0,0 @@
-Test for asynchronous spellchecking in case DOM mutation happens. This test checks crash won't happen if DOM mutations happened.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
-Test Start: 1
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 2
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 3
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 4
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 5
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 6
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 7
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 8
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-
-Test Start: 9
-PASS requestId is >= lastRequestId + 1
-PASS Request has been processed.
-zz zz zz
-
Deleted: trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html (103052 => 103053)
--- trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html 2011-12-16 10:51:22 UTC (rev 103052)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html 2011-12-16 11:10:24 UTC (rev 103053)
@@ -1,243 +0,0 @@
-
-
-
-
-.editing {
-border: 2px solid red;
-padding: 6px;
-font-size: 18px;
-}
-
-
-
-
-
-
-zz zz zz
-
-
-
-
-
-
-description(
-"Test for asynchronous spellchecking in case DOM mutation happens. " +
-"This test checks crash won't happen if DOM mutations happened."
-);
-
-if (window.layoutTestController) {
-layoutTestController.dumpAsText();
-layoutTestController.setAsynchronousSpellCheckingEnabled(true);
-layoutTestController.waitUntilDone();
-}
-
-if (window.internals)
-internals.setUnifiedTextCheckingEnabled(document, true);
-
-var sourceIds = ['source'];
-var destElems = ['textarea', 'input', 'contenteditable'];
-var tweaks = ['delete', 'move', 'mutate'];
-
-var testData = [];
-for (var i = 0; i < sourceIds.length; ++i) {
-for (var j = 0; j < destElems.length; ++j) {
-for (var k = 0; k < tweaks.length; ++k) {
-testData.push({
-sourceId: sourceIds[i],
-destElem: destElems[j],
-tweak: tweaks[k]
-});
-}
-}
-}
-
-var sel = window.getSelection();
-
-function removeAllChildren(elem) {
-while (elem.firstChild)
-elem.removeChild(elem.firstChild);
-}
-
-var testNo = 0;
-function doTestIfAny() {
-// Clean up first.
-removeAllChildren(document.getElementById('container'));
-removeAllChildren(document.getElementById('move-target'));
-
-var next = testData.shift();
-if (next)
-return window.setTimeout(function(){ doTest(++testNo, next); }, 0);
-
[webkit-changes] [103052] trunk/Source/WebCore
Title: [103052] trunk/Source/WebCore Revision 103052 Author h...@chromium.org Date 2011-12-16 02:51:22 -0800 (Fri, 16 Dec 2011) Log Message IndexedDB: Don't prefetch values from key cursors https://bugs.webkit.org/show_bug.cgi?id=74604 Reviewed by Tony Chang. Since index key cursors don't have values, prefetching should not try to retrieve them. Doing so trips an ASSERT in debug builds. This will be tested Chromium-side. * storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::prefetchContinueInternal): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (103051 => 103052) --- trunk/Source/WebCore/ChangeLog 2011-12-16 10:48:05 UTC (rev 103051) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 10:51:22 UTC (rev 103052) @@ -1,3 +1,18 @@ +2011-12-15 Hans Wennborg + +IndexedDB: Don't prefetch values from key cursors +https://bugs.webkit.org/show_bug.cgi?id=74604 + +Reviewed by Tony Chang. + +Since index key cursors don't have values, prefetching should not try +to retrieve them. Doing so trips an ASSERT in debug builds. + +This will be tested Chromium-side. + +* storage/IDBCursorBackendImpl.cpp: +(WebCore::IDBCursorBackendImpl::prefetchContinueInternal): + 2011-12-16 Yosifumi Inoue [Forms] The "maxlength" attribute on "textarea" tag miscounts hard newlines Modified: trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp (103051 => 103052) --- trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp 2011-12-16 10:48:05 UTC (rev 103051) +++ trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp 2011-12-16 10:51:22 UTC (rev 103052) @@ -149,11 +149,16 @@ foundKeys.append(cursor->m_cursor->key()); foundPrimaryKeys.append(cursor->m_cursor->primaryKey()); -foundValues.append(SerializedScriptValue::createFromWire(cursor->m_cursor->value())); +if (cursor->m_cursorType != IDBCursorBackendInterface::IndexKeyCursor) +foundValues.append(SerializedScriptValue::createFromWire(cursor->m_cursor->value())); +else +foundValues.append(SerializedScriptValue::create()); + sizeEstimate += cursor->m_cursor->key()->sizeEstimate(); sizeEstimate += cursor->m_cursor->primaryKey()->sizeEstimate(); -sizeEstimate += cursor->m_cursor->value().length() * sizeof(UChar); +if (cursor->m_cursorType != IDBCursorBackendInterface::IndexKeyCursor) +sizeEstimate += cursor->m_cursor->value().length() * sizeof(UChar); if (sizeEstimate > kMaxSizeEstimate) break; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103051] trunk
Title: [103051] trunk
Revision 103051
Author commit-qu...@webkit.org
Date 2011-12-16 02:48:05 -0800 (Fri, 16 Dec 2011)
Log Message
[Forms] The "maxlength" attribute on "textarea" tag miscounts hard newlines
https://bugs.webkit.org/show_bug.cgi?id=74686
Patch by Yosifumi Inoue on 2011-12-16
Reviewed by Kent Tamura.
Source/WebCore:
This patch counts LF in textarea value as two for LF to CRLF conversion on submission.
No new tests. Existing tests cover all changes.
* html/HTMLTextAreaElement.cpp:
(WebCore::computeLengthForSubmission): Count LF as 2 for CR LF conversion on submission.
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent): Use computeLengthForSubmission instead of numGraphemeClusters.
(WebCore::HTMLTextAreaElement::tooLong): Use computeLengthForSubmission instead of numGraphemeClusters.
LayoutTests:
* fast/forms/script-tests/textarea-maxlength.js: Doubles maxlength for counting LF as two chars.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/script-tests/textarea-maxlength.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (103050 => 103051)
--- trunk/LayoutTests/ChangeLog 2011-12-16 10:44:04 UTC (rev 103050)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 10:48:05 UTC (rev 103051)
@@ -1,3 +1,12 @@
+2011-12-16 Yosifumi Inoue
+
+[Forms] The "maxlength" attribute on "textarea" tag miscounts hard newlines
+https://bugs.webkit.org/show_bug.cgi?id=74686
+
+Reviewed by Kent Tamura.
+
+* fast/forms/script-tests/textarea-maxlength.js: Doubles maxlength for counting LF as two chars.
+
2011-12-16 Hajime Morrita
Unreviewed, rolling out r103045.
Modified: trunk/LayoutTests/fast/forms/script-tests/textarea-maxlength.js (103050 => 103051)
--- trunk/LayoutTests/fast/forms/script-tests/textarea-maxlength.js 2011-12-16 10:44:04 UTC (rev 103050)
+++ trunk/LayoutTests/fast/forms/script-tests/textarea-maxlength.js 2011-12-16 10:48:05 UTC (rev 103051)
@@ -82,7 +82,7 @@
shouldBe('textArea.value', '"abcde"');
// A linebreak is 1 character.
-createFocusedTextAreaWithMaxLength(3);
+createFocusedTextAreaWithMaxLength(4);
document.execCommand('insertText', false, 'A');
document.execCommand('insertLineBreak');
document.execCommand('insertText', false, 'B');
@@ -95,7 +95,7 @@
shouldBe('textArea.value', '"a\\n\\n"');
// Confirms correct count for open consecutive linebreaks inputs.
-createFocusedTextAreaWithMaxLength(3);
+createFocusedTextAreaWithMaxLength(6);
document.execCommand('insertLineBreak');
document.execCommand('insertLineBreak');
document.execCommand('insertLineBreak');
Modified: trunk/Source/WebCore/ChangeLog (103050 => 103051)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 10:44:04 UTC (rev 103050)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 10:48:05 UTC (rev 103051)
@@ -1,3 +1,19 @@
+2011-12-16 Yosifumi Inoue
+
+[Forms] The "maxlength" attribute on "textarea" tag miscounts hard newlines
+https://bugs.webkit.org/show_bug.cgi?id=74686
+
+Reviewed by Kent Tamura.
+
+This patch counts LF in textarea value as two for LF to CRLF conversion on submission.
+
+No new tests. Existing tests cover all changes.
+
+* html/HTMLTextAreaElement.cpp:
+(WebCore::computeLengthForSubmission): Count LF as 2 for CR LF conversion on submission.
+(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent): Use computeLengthForSubmission instead of numGraphemeClusters.
+(WebCore::HTMLTextAreaElement::tooLong): Use computeLengthForSubmission instead of numGraphemeClusters.
+
2011-12-16 Hajime Morrita
Unreviewed, rolling out r103045.
Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (103050 => 103051)
--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2011-12-16 10:44:04 UTC (rev 103050)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2011-12-16 10:48:05 UTC (rev 103051)
@@ -50,6 +50,19 @@
static const int defaultRows = 2;
static const int defaultCols = 20;
+// On submission, LF characters are converted into CRLF.
+// This function returns number of characters considering this.
+static unsigned computeLengthForSubmission(const String& text)
+{
+unsigned count = numGraphemeClusters(text);
+unsigned length = text.length();
+for (unsigned i = 0; i < length; i++) {
+if (text[i] == '\n')
+count++;
+}
+return count;
+}
+
HTMLTextAreaElement::HTMLTextAreaElement(const QualifiedName& tagName, Document* document, HTMLFormElement* form)
: HTMLTextFormControlElement(tagName, document, form)
, m_rows(defaultRows)
@@ -244,13 +257,13 @@
return;
unsigned unsignedMaxLength = static_cast(signedMaxLength);
-unsigned currentLength = numGraphemeClusters(innerTextValue());
+unsigned currentLength = computeLengthForSubmission(innerTextValue());
// selectionLength repr
[webkit-changes] [103050] trunk
Title: [103050] trunk
Revision 103050
Author morr...@google.com
Date 2011-12-16 02:44:04 -0800 (Fri, 16 Dec 2011)
Log Message
Unreviewed, rolling out r103045.
http://trac.webkit.org/changeset/103045
https://bugs.webkit.org/show_bug.cgi?id=74590
Breaks select-script-onchange.html on Chromium Windows
Source/WebCore:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::typeAheadFind):
LayoutTests:
* fast/events/onchange-select-popup-expected.txt:
* fast/forms/select/menulist-type-ahead-find-expected.txt: Removed.
* fast/forms/select/menulist-type-ahead-find.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSelectElement.cpp
Removed Paths
trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt
trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html
Diff
Modified: trunk/LayoutTests/ChangeLog (103049 => 103050)
--- trunk/LayoutTests/ChangeLog 2011-12-16 10:36:11 UTC (rev 103049)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 10:44:04 UTC (rev 103050)
@@ -1,3 +1,15 @@
+2011-12-16 Hajime Morrita
+
+Unreviewed, rolling out r103045.
+http://trac.webkit.org/changeset/103045
+https://bugs.webkit.org/show_bug.cgi?id=74590
+
+Breaks select-script-onchange.html on Chromium Windows
+
+* fast/events/onchange-select-popup-expected.txt:
+* fast/forms/select/menulist-type-ahead-find-expected.txt: Removed.
+* fast/forms/select/menulist-type-ahead-find.html: Removed.
+
2011-12-16 Csaba Osztrogonác
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt (103049 => 103050)
--- trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt 2011-12-16 10:36:11 UTC (rev 103049)
+++ trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt 2011-12-16 10:44:04 UTC (rev 103050)
@@ -6,6 +6,4 @@
blur event fired.
-PASS: change event fired.
-
Deleted: trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt (103049 => 103050)
--- trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt 2011-12-16 10:36:11 UTC (rev 103049)
+++ trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt 2011-12-16 10:44:04 UTC (rev 103050)
@@ -1,8 +0,0 @@
-WebKit Bug 74590
-
-Verify type ahead selection fires onchange event.
-Set focus to select element
-Type "c"
-You see "cherry" in select element and "PASS" below select element.
-
-PASS
Deleted: trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html (103049 => 103050)
--- trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html 2011-12-16 10:36:11 UTC (rev 103049)
+++ trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html 2011-12-16 10:44:04 UTC (rev 103050)
@@ -1,39 +0,0 @@
-
-
-
-function recordIt()
-{
- document.getElementById("res").innerText = "PASS";
-}
-
-function testIt(ch, expected)
-{
-document.getElementById("sel").focus();
-eventSender.keyDown(ch);
-}
-
-function test()
-{
-if (!window.layoutTestController)
-return;
-
-layoutTestController.dumpAsText();
-testIt("c", "cherry");
-}
-
-
-
-WebKit Bug
-Set focus to select element
-Type "c"
-You see "cherry" in select element and "PASS" below select element.
-
-
-apple
-banana
-cherry
-
-
-
Modified: trunk/Source/WebCore/ChangeLog (103049 => 103050)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 10:36:11 UTC (rev 103049)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 10:44:04 UTC (rev 103050)
@@ -1,3 +1,14 @@
+2011-12-16 Hajime Morrita
+
+Unreviewed, rolling out r103045.
+http://trac.webkit.org/changeset/103045
+https://bugs.webkit.org/show_bug.cgi?id=74590
+
+Breaks select-script-onchange.html on Chromium Windows
+
+* html/HTMLSelectElement.cpp:
+(WebCore::HTMLSelectElement::typeAheadFind):
+
2011-12-16 Carlos Garcia Campos
Unreviewed. Fix make distcheck.
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (103049 => 103050)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-12-16 10:36:11 UTC (rev 103049)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-12-16 10:44:04 UTC (rev 103050)
@@ -1441,7 +1441,7 @@
// Fold the option string and check if its prefix is equal to the folded prefix.
String text = toHTMLOptionElement(element)->textIndentedToRespectGroupLabel();
if (stripLeadingWhiteSpace(text).foldCase().startsWith(prefixWithCaseFolded)) {
-selectOption(listToOptionIndex(index), DeselectOtherOptions | DispatchChangeEvent | UserDriven);
+selectOption(listToOptionIndex(index), DeselectOtherOptions | UserDriven);
if (!usesMenuList())
listBoxOnChange();
___
webkit-changes mailing l
[webkit-changes] [103049] trunk/LayoutTests
Title: [103049] trunk/LayoutTests
Revision 103049
Author o...@webkit.org
Date 2011-12-16 02:36:11 -0800 (Fri, 16 Dec 2011)
Log Message
[Qt] Unreviewed gardening.
* platform/qt/Skipped: Skip a failing test (regression) to paint the bot green.
* platform/qt/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
* platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt
Added Paths
trunk/LayoutTests/platform/qt/fast/css/bidi-override-in-anonymous-block-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (103048 => 103049)
--- trunk/LayoutTests/ChangeLog 2011-12-16 10:16:54 UTC (rev 103048)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 10:36:11 UTC (rev 103049)
@@ -1,3 +1,11 @@
+2011-12-16 Csaba Osztrogonác
+
+[Qt] Unreviewed gardening.
+
+* platform/qt/Skipped: Skip a failing test (regression) to paint the bot green.
+* platform/qt/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
+* platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:
+
2011-12-16 Yosifumi Inoue
[Forms] Selection change by type-ahead doesn't fire 'change' event
Modified: trunk/LayoutTests/platform/qt/Skipped (103048 => 103049)
--- trunk/LayoutTests/platform/qt/Skipped 2011-12-16 10:16:54 UTC (rev 103048)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-12-16 10:36:11 UTC (rev 103049)
@@ -2532,3 +2532,7 @@
# [Qt][GTK] The html5lib/runner.html test is start to fail after r102626
# https://bugs.webkit.org/show_bug.cgi?id=74411
html5lib/runner.html
+
+# [Qt] REGRESSION(103045): It made fast/forms/select-script-onchange.html fail
+# https://bugs.webkit.org/show_bug.cgi?id=74700
+fast/forms/select-script-onchange.html
Added: trunk/LayoutTests/platform/qt/fast/css/bidi-override-in-anonymous-block-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/css/bidi-override-in-anonymous-block-expected.png
___
Added: svn:mime-type
Modified: trunk/LayoutTests/platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt (103048 => 103049)
--- trunk/LayoutTests/platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt 2011-12-16 10:16:54 UTC (rev 103048)
+++ trunk/LayoutTests/platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt 2011-12-16 10:36:11 UTC (rev 103049)
@@ -113,49 +113,49 @@
text run at (0,0) width 31: "ruby"
RenderBlock {DIV} at (0,950) size 768x34 [border: (1px solid #00)]
RenderRuby (inline) {RUBY} at (0,0) size 26x21
- RenderRubyRun (anonymous) at (178,12) size 26x21
+ RenderRubyRun (anonymous) at (200,12) size 26x21
RenderRubyText {RT} at (0,-11) size 26x11
RenderText {#text} at (8,0) size 10x11
text run at (8,0) width 10: "def"
RenderRubyBase (anonymous) at (0,0) size 26x21
RenderText {#text} at (0,0) size 26x21
text run at (0,0) width 26 RTL override: "abc"
-RenderText {#text} at (173,12) size 4x21
- text run at (173,12) width 4 RTL: " "
+RenderText {#text} at (195,12) size 4x21
+ text run at (195,12) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 26x21
- RenderRubyRun (anonymous) at (146,12) size 26x21
+ RenderRubyRun (anonymous) at (168,12) size 26x21
RenderRubyText {RT} at (0,-11) size 26x11
RenderText {#text} at (8,0) size 10x11
text run at (8,0) width 10 RTL override: "def"
RenderRubyBase (anonymous) at (0,0) size 26x21
RenderText {#text} at (0,0) size 26x21
text run at (0,0) width 26 RTL override: "abc"
-RenderText {#text} at (141,12) size 4x21
- text run at (141,12) width 4 RTL: " "
+RenderText {#text} at (163,12) size 4x21
+ text run at (163,12) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 26x21
- RenderRubyRun (anonymous) at (114,12) size 26x21
+ RenderRubyRun (anonymous) at (136,12) size 26x21
RenderRubyBase (anonymous) at (0,0) size 26x21
RenderText {#text} at (0,0) size 26x21
text run at (0,0) width 26 RTL override: "abc"
-RenderText {#text} at (109,12) size 4x21
- text run at (109,12) width 4 RTL: " "
+RenderText {#text} at (131,12) size 4x21
+ text run at (131,12) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 10x21
- RenderRubyRun (anonymous) at (98,31) size 10x0
+ RenderRubyRun (anonymous) at (120,31) size 10x0
RenderRubyText {RT} at (0,-11) size 10x11
RenderText {#text} at (0,0) size 10x11
[webkit-changes] [103048] trunk
Title: [103048] trunk Revision 103048 Author carlo...@webkit.org Date 2011-12-16 02:16:54 -0800 (Fri, 16 Dec 2011) Log Message [GTK] Update NEWS and configure.ac for 1.7.3 release https://bugs.webkit.org/show_bug.cgi?id=74699 Reviewed by Philippe Normand. .: * configure.ac: Bumped version number. Source/WebKit/gtk: * NEWS: Added release notes for 1.7.3. Modified Paths trunk/ChangeLog trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/NEWS trunk/configure.ac Diff Modified: trunk/ChangeLog (103047 => 103048) --- trunk/ChangeLog 2011-12-16 10:05:08 UTC (rev 103047) +++ trunk/ChangeLog 2011-12-16 10:16:54 UTC (rev 103048) @@ -1,3 +1,12 @@ +2011-12-16 Carlos Garcia Campos + +[GTK] Update NEWS and configure.ac for 1.7.3 release +https://bugs.webkit.org/show_bug.cgi?id=74699 + +Reviewed by Philippe Normand. + +* configure.ac: Bumped version number. + 2011-12-15 Raphael Kubo da Costa [CMake] Remove ENABLE_DATAGRID from the buildsystem. Modified: trunk/Source/WebKit/gtk/ChangeLog (103047 => 103048) --- trunk/Source/WebKit/gtk/ChangeLog 2011-12-16 10:05:08 UTC (rev 103047) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-12-16 10:16:54 UTC (rev 103048) @@ -1,3 +1,12 @@ +2011-12-16 Carlos Garcia Campos + +[GTK] Update NEWS and configure.ac for 1.7.3 release +https://bugs.webkit.org/show_bug.cgi?id=74699 + +Reviewed by Philippe Normand. + +* NEWS: Added release notes for 1.7.3. + 2011-12-14 Jing Zhao Opening two popup menus by dispatchEvent() makes problems. Modified: trunk/Source/WebKit/gtk/NEWS (103047 => 103048) --- trunk/Source/WebKit/gtk/NEWS 2011-12-16 10:05:08 UTC (rev 103047) +++ trunk/Source/WebKit/gtk/NEWS 2011-12-16 10:16:54 UTC (rev 103048) @@ -1,4 +1,33 @@ = +WebKitGTK+ 1.7.3 += + +What's new in WebKitGTK+ 1.7.3? + + - WebGL is now enabled by default. + - Initial support for accelerated compositing has been added. + - Add fullscreen setting to WebKit2 GTK+ API. + - Fix regression of Push buttons that didn't expose their displayed +text/name to accessibility toolkit. + - Initial UI client implementation for WebKit2 GTK+ API. + - Implement HTML5 History APIs. + - Implement cookies management in WebKit2. + - Fix a crash when a download fails. + - Add support for _javascript_ dialogs in WebKit2 GTK+ API. + - Add 'enable-dns-prefetching' setting to WebKit2 GTK+ API. + - Initial support for WebAudio data playback. + - Add enable-webaudio setting. + - Links are now focused with Tab by default in WebKit2. + - Fix HTML5 Youtube video fullscreen button. + - Improve description of WebSocket errors. + - Add WebKitWindowProperties to WebKit2 GTK+ API. + - Fullscreen controller support for the new WebKit Fullscreen API. + - Add WebKitURIResponse to WebKit2 GTK+ API. + - Fix random crash in pages containing plugins. + - Fix loading of custom fonts in some web sites like surlybikes.com +or boingboing.net. + += WebKitGTK+ 1.7.2 = Modified: trunk/configure.ac (103047 => 103048) --- trunk/configure.ac 2011-12-16 10:05:08 UTC (rev 103047) +++ trunk/configure.ac 2011-12-16 10:16:54 UTC (rev 103048) @@ -2,14 +2,14 @@ m4_define([webkit_major_version], [1]) m4_define([webkit_minor_version], [7]) -m4_define([webkit_micro_version], [2]) +m4_define([webkit_micro_version], [3]) # This is the version we'll be using as part of our User-Agent string # e.g., AppleWebKit/$(webkit_user_agent_version) ... # # Sourced from Source/WebCore/Configurations/Version.xcconfig m4_define([webkit_user_agent_major_version], [535]) -m4_define([webkit_user_agent_minor_version], [10]) +m4_define([webkit_user_agent_minor_version], [14]) AC_INIT([WebKit],[webkit_major_version.webkit_minor_version.webkit_micro_version],[http://bugs.webkit.org/]) @@ -35,7 +35,7 @@ dnl # Libtool library version, not to confuse with API version dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -LIBWEBKITGTK_VERSION=11:2:11 +LIBWEBKITGTK_VERSION=11:3:11 AC_SUBST([LIBWEBKITGTK_VERSION]) AM_INIT_AUTOMAKE([foreign subdir-objects dist-xz no-dist-gzip tar-ustar]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103047] trunk/Source/WebCore
Title: [103047] trunk/Source/WebCore Revision 103047 Author carlo...@webkit.org Date 2011-12-16 02:05:08 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed. Fix make distcheck. * GNUmakefile.list.am: Add missing header file. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/WebCore/ChangeLog (103046 => 103047) --- trunk/Source/WebCore/ChangeLog 2011-12-16 09:21:02 UTC (rev 103046) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 10:05:08 UTC (rev 103047) @@ -1,3 +1,9 @@ +2011-12-16 Carlos Garcia Campos + +Unreviewed. Fix make distcheck. + +* GNUmakefile.list.am: Add missing header file. + 2011-12-16 Yosifumi Inoue [Forms] Selection change by type-ahead doesn't fire 'change' event Modified: trunk/Source/WebCore/GNUmakefile.list.am (103046 => 103047) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-12-16 09:21:02 UTC (rev 103046) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-12-16 10:05:08 UTC (rev 103047) @@ -2886,6 +2886,7 @@ Source/WebCore/platform/PlatformScreen.h \ Source/WebCore/platform/PlatformWheelEvent.h \ Source/WebCore/platform/PODArena.h \ + Source/WebCore/platform/PODFreeListArena.h \ Source/WebCore/platform/PODInterval.h \ Source/WebCore/platform/PODIntervalTree.h \ Source/WebCore/platform/PODRedBlackTree.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103046] trunk/Tools
Title: [103046] trunk/Tools
Revision 103046
Author hara...@chromium.org
Date 2011-12-16 01:21:02 -0800 (Fri, 16 Dec 2011)
Log Message
[Refactoring] Remove all global variables from prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74681
Reviewed by Ryosuke Niwa.
We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
manner. This bug is one of the incremental refactorings to remove all top-level
code and global variables from prepare-ChangeLog. In this patch,
we make the following global variables be used only through parameter passing.
This patch removes all global variables from prepare-ChangeLog.
- $mergeBase
- $gitCommit
- $gitIndex
* Scripts/prepare-ChangeLog:
(generateFunctionLists):
(changeLogNameFromArgs):
(changeLogEmailAddressFromArgs):
(generateNewChangeLogs):
(printDiff):
(diffFromToString):
(diffCommand):
(statusCommand):
(createPatchCommand):
(generateFileList):
(isConflictStatus):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/prepare-ChangeLog
Diff
Modified: trunk/Tools/ChangeLog (103045 => 103046)
--- trunk/Tools/ChangeLog 2011-12-16 09:08:00 UTC (rev 103045)
+++ trunk/Tools/ChangeLog 2011-12-16 09:21:02 UTC (rev 103046)
@@ -1,3 +1,32 @@
+2011-12-16 Kentaro Hara
+
+[Refactoring] Remove all global variables from prepare-ChangeLog
+https://bugs.webkit.org/show_bug.cgi?id=74681
+
+Reviewed by Ryosuke Niwa.
+
+We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
+manner. This bug is one of the incremental refactorings to remove all top-level
+code and global variables from prepare-ChangeLog. In this patch,
+we make the following global variables be used only through parameter passing.
+This patch removes all global variables from prepare-ChangeLog.
+- $mergeBase
+- $gitCommit
+- $gitIndex
+
+* Scripts/prepare-ChangeLog:
+(generateFunctionLists):
+(changeLogNameFromArgs):
+(changeLogEmailAddressFromArgs):
+(generateNewChangeLogs):
+(printDiff):
+(diffFromToString):
+(diffCommand):
+(statusCommand):
+(createPatchCommand):
+(generateFileList):
+(isConflictStatus):
+
2011-12-15 Philippe Normand
[GTK] Rounding errors on 32-bit machines causes tests to fail
Modified: trunk/Tools/Scripts/prepare-ChangeLog (103045 => 103046)
--- trunk/Tools/Scripts/prepare-ChangeLog 2011-12-16 09:08:00 UTC (rev 103045)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2011-12-16 09:21:02 UTC (rev 103046)
@@ -65,29 +65,29 @@
use VCSUtils;
sub changeLogDate($);
-sub changeLogEmailAddressFromArgs($);
-sub changeLogNameFromArgs($);
+sub changeLogEmailAddressFromArgs($$);
+sub changeLogNameFromArgs($$);
sub fetchBugDescriptionFromURL($$);
sub findChangeLogs($);
sub getLatestChangeLogs($);
sub resolveConflictedChangeLogs($);
-sub generateNewChangeLogs($$);
-sub printDiff($);
+sub generateNewChangeLogs($$$);
+sub printDiff();
sub openChangeLogs($);
-sub diffFromToString();
-sub diffCommand(@);
-sub statusCommand(@);
-sub createPatchCommand($);
+sub diffFromToString($$$);
+sub diffCommand();
+sub statusCommand();
+sub createPatchCommand();
sub diffHeaderFormat();
sub findOriginalFileFromSvn($);
sub determinePropertyChanges($$$);
sub pluralizeAndList($$@);
-sub generateFileList(\%);
-sub generateFunctionLists($$);
+sub generateFileList(\%$$$);
+sub generateFunctionLists($);
sub isUnmodifiedStatus($);
sub isModifiedStatus($);
sub isAddedStatus($);
-sub isConflictStatus($);
+sub isConflictStatus($$$);
sub statusDescription();
sub propertyChangeDescription($);
sub extractLineRange($);
@@ -171,7 +171,7 @@
my %paths = processPaths(@ARGV);
# Find the list of modified files
-my ($changedFiles, $conflictFiles, $functionLists, $addedRegressionTests) = generateFileList(%paths);
+my ($changedFiles, $conflictFiles, $functionLists, $addedRegressionTests) = generateFileList(%paths, $gitCommit, $gitIndex, $mergeBase);
if (!@$changedFiles && !@$conflictFiles && !keys %$functionLists) {
print STDERR " No changes found.\n";
@@ -184,11 +184,11 @@
exit 1;
}
-generateFunctionLists($changedFiles, $functionLists);
+generateFunctionLists($changedFiles, $functionLists, $gitCommit, $gitIndex, $mergeBase);
# Get some parameters for the ChangeLog we are about to write.
-$name = changeLogNameFromArgs($name);
-$emailAddress = changeLogEmailAddressFromArgs($emailAddress);
+$name = changeLogNameFromArgs($name, $gitCommit);
+$emailAddress = changeLogEmailAddressFromArgs($emailAddress, $gitCommit);
print STDERR " Change author: $name <$emailAddress>.\n";
@@ -213,7 +213,7 @@
resolveConflictedChangeLogs($changeLogs);
}
-generateNewChangeLogs($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $bugDescription, $name, $emailAddress, $
[webkit-changes] [103045] trunk
Title: [103045] trunk
Revision 103045
Author commit-qu...@webkit.org
Date 2011-12-16 01:08:00 -0800 (Fri, 16 Dec 2011)
Log Message
[Forms] Selection change by type-ahead doesn't fire 'change' event
https://bugs.webkit.org/show_bug.cgi?id=74590
Patch by Yosifumi Inoue on 2011-12-16
Reviewed by Kent Tamura.
Source/WebCore:
Fire onchange even for type ahead selection.
Test: fast/forms/select/menulist-type-ahead-find.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::typeAheadFind): Add DispatchChangeEvent when
calling selectOption method.
LayoutTests:
* fast/events/onchange-select-popup.html: Add "PASS: change event fired." for type ahread test.
* fast/forms/select/menulist-type-ahead-find-expected.txt: Added.
* fast/forms/select/menulist-type-ahead-find.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSelectElement.cpp
Added Paths
trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt
trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html
Diff
Modified: trunk/LayoutTests/ChangeLog (103044 => 103045)
--- trunk/LayoutTests/ChangeLog 2011-12-16 09:04:50 UTC (rev 103044)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 09:08:00 UTC (rev 103045)
@@ -1,3 +1,14 @@
+2011-12-16 Yosifumi Inoue
+
+[Forms] Selection change by type-ahead doesn't fire 'change' event
+https://bugs.webkit.org/show_bug.cgi?id=74590
+
+Reviewed by Kent Tamura.
+
+* fast/events/onchange-select-popup.html: Add "PASS: change event fired." for type ahread test.
+* fast/forms/select/menulist-type-ahead-find-expected.txt: Added.
+* fast/forms/select/menulist-type-ahead-find.html: Added.
+
2011-12-16 Shinya Kawanaka
A test that mutation happens when asynchronous spell checking is in process.
Modified: trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt (103044 => 103045)
--- trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt 2011-12-16 09:04:50 UTC (rev 103044)
+++ trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt 2011-12-16 09:08:00 UTC (rev 103045)
@@ -6,4 +6,6 @@
blur event fired.
+PASS: change event fired.
+
Added: trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt (0 => 103045)
--- trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt 2011-12-16 09:08:00 UTC (rev 103045)
@@ -0,0 +1,8 @@
+WebKit Bug 74590
+
+Verify type ahead selection fires onchange event.
+Set focus to select element
+Type "c"
+You see "cherry" in select element and "PASS" below select element.
+
+PASS
Added: trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html (0 => 103045)
--- trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html (rev 0)
+++ trunk/LayoutTests/fast/forms/select/menulist-type-ahead-find.html 2011-12-16 09:08:00 UTC (rev 103045)
@@ -0,0 +1,39 @@
+
+
+
+function recordIt()
+{
+ document.getElementById("res").innerText = "PASS";
+}
+
+function testIt(ch, expected)
+{
+document.getElementById("sel").focus();
+eventSender.keyDown(ch);
+}
+
+function test()
+{
+if (!window.layoutTestController)
+return;
+
+layoutTestController.dumpAsText();
+testIt("c", "cherry");
+}
+
+
+
+WebKit Bug
+Set focus to select element
+Type "c"
+You see "cherry" in select element and "PASS" below select element.
+
+
+apple
+banana
+cherry
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (103044 => 103045)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 09:04:50 UTC (rev 103044)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 09:08:00 UTC (rev 103045)
@@ -1,3 +1,18 @@
+2011-12-16 Yosifumi Inoue
+
+[Forms] Selection change by type-ahead doesn't fire 'change' event
+https://bugs.webkit.org/show_bug.cgi?id=74590
+
+Reviewed by Kent Tamura.
+
+Fire onchange even for type ahead selection.
+
+Test: fast/forms/select/menulist-type-ahead-find.html
+
+* html/HTMLSelectElement.cpp:
+(WebCore::HTMLSelectElement::typeAheadFind): Add DispatchChangeEvent when
+calling selectOption method.
+
2011-12-16 Andreas Kling
Don't call Document::body() twice in the same function.
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (103044 => 103045)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-12-16 09:04:50 UTC (rev 103044)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-12-16 09:08:00 UTC (rev 103045)
@@ -1441,7 +1441,7 @@
// Fold the option string and check if its prefix is equal to the folded prefix.
String text = toHTMLOptionElement(element)->textIndentedToRespectGroupLabel();
if (stripLeadingWhiteSpace(text).foldCas
[webkit-changes] [103044] trunk/LayoutTests
Title: [103044] trunk/LayoutTests
Revision 103044
Author commit-qu...@webkit.org
Date 2011-12-16 01:04:50 -0800 (Fri, 16 Dec 2011)
Log Message
A test that mutation happens when asynchronous spell checking is in process.
https://bugs.webkit.org/show_bug.cgi?id=72940
Patch by Shinya Kawanaka on 2011-12-16
Reviewed by Hajime Morita.
Added a test that mutation happens when spellchecking.
This test confirms crash won't happen, and how markers are used.
* editing/spelling/spellcheck-async-mutation-expected.txt: Added.
* editing/spelling/spellcheck-async-mutation.html: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac-leopard/Skipped
trunk/LayoutTests/platform/qt/Skipped
Added Paths
trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt
trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (103043 => 103044)
--- trunk/LayoutTests/ChangeLog 2011-12-16 08:51:18 UTC (rev 103043)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 09:04:50 UTC (rev 103044)
@@ -1,3 +1,19 @@
+2011-12-16 Shinya Kawanaka
+
+A test that mutation happens when asynchronous spell checking is in process.
+https://bugs.webkit.org/show_bug.cgi?id=72940
+
+Reviewed by Hajime Morita.
+
+Added a test that mutation happens when spellchecking.
+This test confirms crash won't happen, and how markers are used.
+
+* editing/spelling/spellcheck-async-mutation-expected.txt: Added.
+* editing/spelling/spellcheck-async-mutation.html: Added.
+* platform/gtk/Skipped:
+* platform/mac-leopard/Skipped:
+* platform/qt/Skipped:
+
2011-12-16 Hajime Morrita
Marking some as fail.
Added: trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt (0 => 103044)
--- trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt 2011-12-16 09:04:50 UTC (rev 103044)
@@ -0,0 +1,45 @@
+Test for asynchronous spellchecking in case DOM mutation happens. This test checks crash won't happen if DOM mutations happened.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+Test Start: 1
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 2
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 3
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 4
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 5
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 6
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 7
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 8
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+
+Test Start: 9
+PASS requestId is >= lastRequestId + 1
+PASS Request has been processed.
+zz zz zz
+
Added: trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html (0 => 103044)
--- trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html (rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html 2011-12-16 09:04:50 UTC (rev 103044)
@@ -0,0 +1,243 @@
+
+
+
+
+.editing {
+border: 2px solid red;
+padding: 6px;
+font-size: 18px;
+}
+
+
+
+
+
+
+zz zz zz
+
+
+
+
+
+
+description(
+"Test for asynchronous spellchecking in case DOM mutation happens. " +
+"This test checks crash won't happen if DOM mutations happened."
+);
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.setAsynchronousSpellCheckingEnabled(true);
+layoutTestController.waitUntilDone();
+}
+
+if (window.internals)
+internals.setUnifiedTextCheckingEnabled(document, true);
+
+var sourceIds = ['source'];
+var destElems = ['textarea', 'input', 'contenteditable'];
+var tweaks = ['delete', 'move', 'mutate'];
+
+var testData = [];
+for (var i = 0; i < sourceIds.length; ++i) {
+for (var j = 0; j < destElems.length; ++j) {
+for (var k = 0; k < tweaks.length; ++k) {
+testData.push({
+sourceId: sourceIds[i],
+destElem: destElems[j],
+tweak: tweaks[k]
+});
+}
+}
+}
+
+var sel = window.getSelection();
+
+function removeAllChildren(elem) {
+while (elem.firstChild)
+elem.removeChild(elem.firstChild);
+}
+
+var testNo = 0;
+function doTestIfAny() {
+// Clean up first.
+removeAllChildren(document.getElementById('container'));
+removeAllChildren(d
[webkit-changes] [103043] trunk/Source/WebCore
Title: [103043] trunk/Source/WebCore
Revision 103043
Author kl...@webkit.org
Date 2011-12-16 00:51:18 -0800 (Fri, 16 Dec 2011)
Log Message
Don't call Document::body() twice in the same function.
Reviewed by Dan Bernstein.
Document::body() is O(n), so we should avoid calling it multiple
times unnecessarily.
* dom/Document.cpp:
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (103042 => 103043)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 08:49:53 UTC (rev 103042)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 08:51:18 UTC (rev 103043)
@@ -1,3 +1,16 @@
+2011-12-16 Andreas Kling
+
+Don't call Document::body() twice in the same function.
+
+
+Reviewed by Dan Bernstein.
+
+Document::body() is O(n), so we should avoid calling it multiple
+times unnecessarily.
+
+* dom/Document.cpp:
+(WebCore::Document::updateLayoutIgnorePendingStylesheets):
+
2011-12-16 Daniel Sievers
[Chromium] Add trace events for decoding and drawing images.
Modified: trunk/Source/WebCore/dom/Document.cpp (103042 => 103043)
--- trunk/Source/WebCore/dom/Document.cpp 2011-12-16 08:49:53 UTC (rev 103042)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-12-16 08:51:18 UTC (rev 103043)
@@ -1675,7 +1675,8 @@
// moment. If it were more refined, we might be able to do something better.)
// It's worth noting though that this entire method is a hack, since what we really want to do is
// suspend JS instead of doing a layout with inaccurate information.
-if (body() && !body()->renderer() && m_pendingSheetLayout == NoLayoutWithPendingSheets) {
+HTMLElement* bodyElement = body();
+if (bodyElement && !bodyElement->renderer() && m_pendingSheetLayout == NoLayoutWithPendingSheets) {
m_pendingSheetLayout = DidLayoutWithPendingSheets;
styleSelectorChanged(RecalcStyleImmediately);
} else if (m_hasNodesWithPlaceholderStyle)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103042] trunk/LayoutTests
Title: [103042] trunk/LayoutTests Revision 103042 Author morr...@google.com Date 2011-12-16 00:49:53 -0800 (Fri, 16 Dec 2011) Log Message Marking some as fail. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103041 => 103042) --- trunk/LayoutTests/ChangeLog 2011-12-16 08:35:07 UTC (rev 103041) +++ trunk/LayoutTests/ChangeLog 2011-12-16 08:49:53 UTC (rev 103042) @@ -1,3 +1,9 @@ +2011-12-16 Hajime Morrita + +Marking some as fail. + +* platform/chromium/test_expectations.txt: + 2011-12-16 Hajime Morrita Unreviewed expectations update. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103041 => 103042) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 08:35:07 UTC (rev 103041) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-16 08:49:53 UTC (rev 103042) @@ -3505,7 +3505,8 @@ BUGWK65453 MAC : fast/css/outline-auto-empty-rects.html = IMAGE -BUGWK65462 VISTA : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT +BUGWK65462 VISTA LINUX : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT +BUGWK74694 LINUX : http/tests/cache/history-only-cached-subresource-loads.html = PASS TIMEOUT BUGWK67915 LINUX WIN : fast/borders/borderRadiusDashed06.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103041] trunk/Source/WebCore
Title: [103041] trunk/Source/WebCore
Revision 103041
Author commit-qu...@webkit.org
Date 2011-12-16 00:35:07 -0800 (Fri, 16 Dec 2011)
Log Message
[Chromium] Add trace events for decoding and drawing images.
https://bugs.webkit.org/show_bug.cgi?id=74547
Patch by Daniel Sievers on 2011-12-16
Reviewed by James Robinson.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::resizedBitmap):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::decode):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::decode):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
trunk/Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp
trunk/Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp
trunk/Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp
trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
trunk/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp
trunk/Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (103040 => 103041)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 08:28:21 UTC (rev 103040)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 08:35:07 UTC (rev 103041)
@@ -1,3 +1,29 @@
+2011-12-16 Daniel Sievers
+
+[Chromium] Add trace events for decoding and drawing images.
+https://bugs.webkit.org/show_bug.cgi?id=74547
+
+Reviewed by James Robinson.
+
+* platform/graphics/skia/ImageSkia.cpp:
+(WebCore::drawResampledBitmap):
+(WebCore::paintSkBitmap):
+(WebCore::Image::drawPattern):
+* platform/graphics/skia/NativeImageSkia.cpp:
+(WebCore::NativeImageSkia::resizedBitmap):
+* platform/image-decoders/bmp/BMPImageDecoder.cpp:
+(WebCore::BMPImageDecoder::decode):
+* platform/image-decoders/gif/GIFImageDecoder.cpp:
+(WebCore::GIFImageDecoder::decode):
+* platform/image-decoders/ico/ICOImageDecoder.cpp:
+(WebCore::ICOImageDecoder::decode):
+* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+(WebCore::JPEGImageDecoder::decode):
+* platform/image-decoders/png/PNGImageDecoder.cpp:
+(WebCore::PNGImageDecoder::decode):
+* platform/image-decoders/webp/WEBPImageDecoder.cpp:
+(WebCore::WEBPImageDecoder::decode):
+
2011-12-15 Martin Robinson
Fix 'make dist' in preparation for the GTK+ release.
Modified: trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp (103040 => 103041)
--- trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp 2011-12-16 08:28:21 UTC (rev 103040)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp 2011-12-16 08:35:07 UTC (rev 103041)
@@ -50,6 +50,10 @@
#include "skia/ext/image_operations.h"
#include "skia/ext/platform_canvas.h"
+#if PLATFORM(CHROMIUM)
+#include "TraceEvent.h"
+#endif
+
namespace WebCore {
// Used by computeResamplingMode to tell how bitmaps should be resampled.
@@ -166,6 +170,9 @@
// scaling or translation.
static void drawResampledBitmap(SkCanvas& canvas, SkPaint& paint, const NativeImageSkia& bitmap, const SkIRect& srcIRect, const SkRect& destRect)
{
+#if PLATFORM(CHROMIUM)
+TRACE_EVENT("drawResampledBitmap", &canvas, 0);
+#endif
// Apply forward transform to destRect to estimate required size of
// re-sampled bitmap, and use only in calls required to resize, or that
// check for the required size.
@@ -212,6 +219,9 @@
static void paintSkBitmap(PlatformContextSkia* platformContext, const NativeImageSkia& bitmap, const SkIRect& srcRect, const SkRect& destRect, const SkXfermode::Mode& compOp)
{
+#if PLATFORM(CHROMIUM)
+TRACE_EVENT("paintSkBitmap", platformContext, 0);
+#endif
SkPaint paint;
paint.setXfermodeMode(compOp);
paint.setFilterBitmap(true);
@@ -296,6 +306,9 @@
CompositeOperator compositeOp,
const FloatRect& destRect)
{
+#if PLATFORM(CHROMIUM)
+TRACE_EVENT("Image::drawPattern", this, 0);
+#endif
FloatRect normSrcRect = normalizeRect(floatSrcRect);
if (destRect.isEmpty() || normSrcRect.isEmpty())
return; // nothing to draw
Modified: trunk/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp (103040 => 103041)
--- trunk/Source/WebCore/platform/graphics/skia/N
[webkit-changes] [103040] trunk/Tools
Title: [103040] trunk/Tools
Revision 103040
Author ph...@webkit.org
Date 2011-12-16 00:28:21 -0800 (Fri, 16 Dec 2011)
Log Message
[GTK] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=72254
Initial patch by van...@gmail.com.
Reviewed by Martin Robinson.
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Pass additional
CXXFLAGS to autogen in an attempt to harmonize floating point
values between 32-bit and 64-bit architectures.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (103039 => 103040)
--- trunk/Tools/ChangeLog 2011-12-16 08:27:17 UTC (rev 103039)
+++ trunk/Tools/ChangeLog 2011-12-16 08:28:21 UTC (rev 103040)
@@ -1,3 +1,16 @@
+2011-12-15 Philippe Normand
+
+[GTK] Rounding errors on 32-bit machines causes tests to fail
+https://bugs.webkit.org/show_bug.cgi?id=72254
+
+Initial patch by van...@gmail.com.
+Reviewed by Martin Robinson.
+
+* Scripts/webkitdirs.pm:
+(runAutogenForAutotoolsProjectIfNecessary): Pass additional
+CXXFLAGS to autogen in an attempt to harmonize floating point
+values between 32-bit and 64-bit architectures.
+
2011-12-16 Martin Robinson
[GTK] Make distcheck fails during the install
Modified: trunk/Tools/Scripts/webkitdirs.pm (103039 => 103040)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-12-16 08:27:17 UTC (rev 103039)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-12-16 08:28:21 UTC (rev 103040)
@@ -1621,6 +1621,14 @@
# Long argument lists cause bizarre slowdowns in libtool.
my $relSourceDir = File::Spec->abs2rel($sourceDir) || ".";
+# Compiler options to keep floating point values consistent
+# between 32-bit and 64-bit architectures. The options are also
+# used on Chromium build.
+determineArchitecture();
+if ($architecture ne "x86_64") {
+$ENV{'CXXFLAGS'} = "-march=pentium4 -msse2 -mfpmath=sse";
+}
+
# Prefix the command with jhbuild run.
unshift(@buildArgs, "$relSourceDir/autogen.sh");
unshift(@buildArgs, "$sourceDir/Tools/gtk/run-with-jhbuild");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103039] trunk/LayoutTests
Title: [103039] trunk/LayoutTests Revision 103039 Author morr...@google.com Date 2011-12-16 00:27:17 -0800 (Fri, 16 Dec 2011) Log Message Unreviewed expectations update. * fast/ruby/ruby-remove-no-base-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/ruby/ruby-remove-no-base-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (103038 => 103039) --- trunk/LayoutTests/ChangeLog 2011-12-16 08:18:33 UTC (rev 103038) +++ trunk/LayoutTests/ChangeLog 2011-12-16 08:27:17 UTC (rev 103039) @@ -1,3 +1,9 @@ +2011-12-16 Hajime Morrita + +Unreviewed expectations update. + +* fast/ruby/ruby-remove-no-base-expected.txt: + 2011-12-16 Philippe Normand Unreviewed, GTK rebaseline and test_expectations update. Modified: trunk/LayoutTests/fast/ruby/ruby-remove-no-base-expected.txt (103038 => 103039) --- trunk/LayoutTests/fast/ruby/ruby-remove-no-base-expected.txt 2011-12-16 08:18:33 UTC (rev 103038) +++ trunk/LayoutTests/fast/ruby/ruby-remove-no-base-expected.txt 2011-12-16 08:27:17 UTC (rev 103039) @@ -1,2 +1 @@ PASS - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103038] trunk/Tools
Title: [103038] trunk/Tools Revision 103038 Author mrobin...@webkit.org Date 2011-12-16 00:18:33 -0800 (Fri, 16 Dec 2011) Log Message [GTK] Make distcheck fails during the install https://bugs.webkit.org/show_bug.cgi?id=74274 No review, since this is a build fix. * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc step. BUILT_SOURCES includes forwarding header generation for WebKit2, which always runs. This means that the gtkdoc step was always running when make was invoked. Generating gtkdoc during 'make install' was triggering a race condition with the library file. Later we can fix generate-forwarding-headers and unbreak 'make docs,' but this bandaid is sufficient to let us release. Modified Paths trunk/Tools/ChangeLog trunk/Tools/GNUmakefile.am Diff Modified: trunk/Tools/ChangeLog (103037 => 103038) --- trunk/Tools/ChangeLog 2011-12-16 08:18:24 UTC (rev 103037) +++ trunk/Tools/ChangeLog 2011-12-16 08:18:33 UTC (rev 103038) @@ -1,3 +1,17 @@ +2011-12-16 Martin Robinson + +[GTK] Make distcheck fails during the install +https://bugs.webkit.org/show_bug.cgi?id=74274 + +No review, since this is a build fix. + +* GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc +step. BUILT_SOURCES includes forwarding header generation for WebKit2, which +always runs. This means that the gtkdoc step was always running when make was +invoked. Generating gtkdoc during 'make install' was triggering a race condition +with the library file. Later we can fix generate-forwarding-headers and unbreak +'make docs,' but this bandaid is sufficient to let us release. + 2011-12-15 Eric Seidel NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process) Modified: trunk/Tools/GNUmakefile.am (103037 => 103038) --- trunk/Tools/GNUmakefile.am 2011-12-16 08:18:24 UTC (rev 103037) +++ trunk/Tools/GNUmakefile.am 2011-12-16 08:18:33 UTC (rev 103038) @@ -242,7 +242,6 @@ if ENABLE_WEBKIT2 docs-build.stamp: \ - $(BUILT_SOURCES) \ Source/WebKit/gtk/docs/webkitenvironment.xml \ Source/WebKit/gtk/docs/webkitgtk-docs.sgml \ Source/WebKit/gtk/docs/webkitgtk-sections.txt \ @@ -254,7 +253,6 @@ @touch docs-build.stamp else docs-build.stamp: \ - $(BUILT_SOURCES) \ libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la \ Source/WebKit/gtk/docs/webkitenvironment.xml \ Source/WebKit/gtk/docs/webkitgtk-docs.sgml \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103037] trunk/LayoutTests
Title: [103037] trunk/LayoutTests
Revision 103037
Author ph...@webkit.org
Date 2011-12-16 00:18:24 -0800 (Fri, 16 Dec 2011)
Log Message
Unreviewed, GTK rebaseline and test_expectations update.
* platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/gtk/fast/ruby/ruby-remove-no-base-expected.txt: Added.
* platform/gtk/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt
trunk/LayoutTests/platform/gtk/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/gtk/fast/ruby/ruby-remove-no-base-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (103036 => 103037)
--- trunk/LayoutTests/ChangeLog 2011-12-16 08:10:27 UTC (rev 103036)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 08:18:24 UTC (rev 103037)
@@ -1,3 +1,11 @@
+2011-12-16 Philippe Normand
+
+Unreviewed, GTK rebaseline and test_expectations update.
+
+* platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
+* platform/gtk/fast/ruby/ruby-remove-no-base-expected.txt: Added.
+* platform/gtk/test_expectations.txt:
+
2011-12-16 Ryosuke Niwa
Qt rebaselines for window properties.
Modified: trunk/LayoutTests/platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt (103036 => 103037)
--- trunk/LayoutTests/platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt 2011-12-16 08:10:27 UTC (rev 103036)
+++ trunk/LayoutTests/platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt 2011-12-16 08:18:24 UTC (rev 103037)
@@ -113,49 +113,49 @@
text run at (0,0) width 30: "ruby"
RenderBlock {DIV} at (0,866) size 768x29 [border: (1px solid #00)]
RenderRuby (inline) {RUBY} at (0,0) size 23x17
- RenderRubyRun (anonymous) at (164,10) size 23x18
+ RenderRubyRun (anonymous) at (184,10) size 23x18
RenderRubyText {RT} at (0,-9) size 23x9
RenderText {#text} at (6,0) size 11x9
text run at (6,0) width 11: "def"
RenderRubyBase (anonymous) at (0,0) size 23x18
RenderText {#text} at (0,0) size 23x17
text run at (0,0) width 23 RTL override: "abc"
-RenderText {#text} at (159,10) size 4x17
- text run at (159,10) width 4 RTL: " "
+RenderText {#text} at (179,10) size 4x17
+ text run at (179,10) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 23x17
- RenderRubyRun (anonymous) at (135,10) size 23x18
+ RenderRubyRun (anonymous) at (155,10) size 23x18
RenderRubyText {RT} at (0,-9) size 23x9
RenderText {#text} at (6,0) size 11x9
text run at (6,0) width 11 RTL override: "def"
RenderRubyBase (anonymous) at (0,0) size 23x18
RenderText {#text} at (0,0) size 23x17
text run at (0,0) width 23 RTL override: "abc"
-RenderText {#text} at (130,10) size 4x17
- text run at (130,10) width 4 RTL: " "
+RenderText {#text} at (150,10) size 4x17
+ text run at (150,10) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 23x17
- RenderRubyRun (anonymous) at (106,10) size 23x18
+ RenderRubyRun (anonymous) at (126,10) size 23x18
RenderRubyBase (anonymous) at (0,0) size 23x18
RenderText {#text} at (0,0) size 23x17
text run at (0,0) width 23 RTL override: "abc"
-RenderText {#text} at (101,10) size 4x17
- text run at (101,10) width 4 RTL: " "
+RenderText {#text} at (121,10) size 4x17
+ text run at (121,10) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 11x17
- RenderRubyRun (anonymous) at (89,26) size 11x0
+ RenderRubyRun (anonymous) at (109,26) size 11x0
RenderRubyText {RT} at (0,-9) size 11x9
RenderText {#text} at (0,0) size 11x9
text run at (0,0) width 11: "def"
-RenderText {#text} at (84,10) size 4x17
- text run at (84,10) width 4 RTL: " "
+RenderText {#text} at (104,10) size 4x17
+ text run at (104,10) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 23x17
- RenderRubyRun (anonymous) at (60,10) size 23x18
+ RenderRubyRun (anonymous) at (80,10) size 23x18
RenderRubyBase (anonymous) at (0,0) size 23x18
RenderInline {RB} at (0,0) size 23x17
RenderText {#text} at (0,0) size 23x17
text run at (0,0) width 23 RTL override: "abc"
-RenderText {#text} at (55,10) size 4x17
- text run at (55,10) width 4 RTL: " "
+RenderText {#text} at (75,10) size 4x17
+ text run at (75,10) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 23x17
- RenderRubyRun (anonymous) at (31,10) size 23
[webkit-changes] [103036] trunk/LayoutTests
Title: [103036] trunk/LayoutTests Revision 103036 Author rn...@webkit.org Date 2011-12-16 00:10:27 -0800 (Fri, 16 Dec 2011) Log Message Qt rebaselines for window properties. * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (103035 => 103036) --- trunk/LayoutTests/ChangeLog 2011-12-16 08:04:09 UTC (rev 103035) +++ trunk/LayoutTests/ChangeLog 2011-12-16 08:10:27 UTC (rev 103036) @@ -1,5 +1,12 @@ 2011-12-16 Ryosuke Niwa +Qt rebaselines for window properties. + +* platform/qt/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: + +2011-12-16 Ryosuke Niwa + Mac rebaseline after r102918. * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (103035 => 103036) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-12-16 08:04:09 UTC (rev 103035) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-12-16 08:10:27 UTC (rev 103036) @@ -2359,9 +2359,12 @@ window.constructor.prototype.setTimeout [function] window.constructor.prototype.showModalDialog [function] window.constructor.prototype.stop [function] +window.constructor.prototype.webkitCancelAnimationFrame [function] +window.constructor.prototype.webkitCancelRequestAnimationFrame [function] window.constructor.prototype.webkitConvertPointFromNodeToPage [function] window.constructor.prototype.webkitConvertPointFromPageToNode [function] window.constructor.prototype.webkitPostMessage [function] +window.constructor.prototype.webkitRequestAnimationFrame [function] window.crypto [object Crypto] window.crypto.getRandomValues [function] window.decodeURI [function] @@ -2558,6 +2561,8 @@ window.typeStringNullAware [function] window.undefined [undefined] window.unescape [function] +window.webkitCancelAnimationFrame [function] +window.webkitCancelRequestAnimationFrame [function] window.webkitConvertPointFromNodeToPage [function] window.webkitConvertPointFromPageToNode [function] window.webkitNotifications [object NotificationCenter] @@ -2566,6 +2571,7 @@ window.webkitNotifications.createNotification [function] window.webkitNotifications.requestPermission [function] window.webkitPostMessage [function] +window.webkitRequestAnimationFrame [function] window.window [printed above as window] window.getSelection() [object DOMSelection] window.getSelection().addRange [function] Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (103035 => 103036) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-12-16 08:04:09 UTC (rev 103035) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-12-16 08:10:27 UTC (rev 103036) @@ -551,9 +551,12 @@ PASS Object.getOwnPropertyDescriptor(window, 'toLocaleString') is undefined. PASS Object.getOwnPropertyDescriptor(window, 'toString') is undefined. PASS Object.getOwnPropertyDescriptor(window, 'valueOf') is undefined. +PASS Object.getOwnPropertyDescriptor(window, 'webkitCancelAnimationFrame') is undefined. +PASS Object.getOwnPropertyDescriptor(window, 'webkitCancelRequestAnimationFrame') is undefined. PASS Object.getOwnPropertyDescriptor(window, 'webkitConvertPointFromNodeToPage') is undefined. PASS Object.getOwnPropertyDescriptor(window, 'webkitConvertPointFromPageToNode') is undefined. PASS Object.getOwnPropertyDescriptor(window, 'webkitPostMessage') is undefined. +PASS Object.getOwnPropertyDescriptor(window, 'webkitRequestAnimationFrame') is undefined. PASS successfullyParsed is true TEST COMPLETE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103035] trunk/LayoutTests
Title: [103035] trunk/LayoutTests Revision 103035 Author rn...@webkit.org Date 2011-12-16 00:04:09 -0800 (Fri, 16 Dec 2011) Log Message Mac rebaseline after r102918. * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (103034 => 103035) --- trunk/LayoutTests/ChangeLog 2011-12-16 07:59:47 UTC (rev 103034) +++ trunk/LayoutTests/ChangeLog 2011-12-16 08:04:09 UTC (rev 103035) @@ -1,3 +1,9 @@ +2011-12-16 Ryosuke Niwa + +Mac rebaseline after r102918. + +* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: + 2011-12-15 Hajime Morrita Unreviewed expectations update. Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt (103034 => 103035) --- trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt 2011-12-16 07:59:47 UTC (rev 103034) +++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt 2011-12-16 08:04:09 UTC (rev 103035) @@ -495,6 +495,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeUndefined') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldEvaluateTo') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldHaveHadError') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldNotBe') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'status') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'statusbar') is 'object' ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103034] trunk/Source
Title: [103034] trunk/Source Revision 103034 Author mrobin...@webkit.org Date 2011-12-15 23:59:47 -0800 (Thu, 15 Dec 2011) Log Message Fix 'make dist' in preparation for the GTK+ release. Source/_javascript_Core: * GNUmakefile.list.am: Add missing header. Source/WebCore: * GNUmakefile.list.am: Add missing header. Source/WebKit2: * GNUmakefile.am: Add missing header. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am Diff Modified: trunk/Source/_javascript_Core/ChangeLog (103033 => 103034) --- trunk/Source/_javascript_Core/ChangeLog 2011-12-16 07:55:16 UTC (rev 103033) +++ trunk/Source/_javascript_Core/ChangeLog 2011-12-16 07:59:47 UTC (rev 103034) @@ -1,3 +1,9 @@ +2011-12-15 Martin Robinson + +Fix 'make dist' in preparation for the GTK+ release. + +* GNUmakefile.list.am: Add missing header. + 2011-12-15 Sam Weinig _javascript_Core uses obsolete 'cpy' mnemonic in ARM assembly Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (103033 => 103034) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-12-16 07:55:16 UTC (rev 103033) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-12-16 07:59:47 UTC (rev 103034) @@ -381,6 +381,7 @@ Source/_javascript_Core/runtime/JSFunction.h \ Source/_javascript_Core/runtime/JSBoundFunction.cpp \ Source/_javascript_Core/runtime/JSBoundFunction.h \ + Source/_javascript_Core/runtime/JSExportMacros.h \ Source/_javascript_Core/runtime/JSGlobalData.cpp \ Source/_javascript_Core/runtime/JSGlobalData.h \ Source/_javascript_Core/runtime/JSGlobalObject.cpp \ @@ -530,6 +531,7 @@ Source/_javascript_Core/wtf/Deque.h \ Source/_javascript_Core/wtf/DisallowCType.h \ Source/_javascript_Core/wtf/DoublyLinkedList.h \ + Source/_javascript_Core/wtf/ExportMacros.h \ Source/_javascript_Core/wtf/dtoa.cpp \ Source/_javascript_Core/wtf/dtoa.h \ Source/_javascript_Core/wtf/dtoa/bignum-dtoa.cc \ Modified: trunk/Source/WebCore/ChangeLog (103033 => 103034) --- trunk/Source/WebCore/ChangeLog 2011-12-16 07:55:16 UTC (rev 103033) +++ trunk/Source/WebCore/ChangeLog 2011-12-16 07:59:47 UTC (rev 103034) @@ -1,3 +1,9 @@ +2011-12-15 Martin Robinson + +Fix 'make dist' in preparation for the GTK+ release. + +* GNUmakefile.list.am: Add missing header. + 2011-12-15 Rafael Ávila de Espíndola Don't create empty files on error. Modified: trunk/Source/WebCore/GNUmakefile.list.am (103033 => 103034) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-12-16 07:55:16 UTC (rev 103033) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-12-16 07:59:47 UTC (rev 103034) @@ -2879,6 +2879,7 @@ Source/WebCore/platform/network/soup/SoupURIUtils.h \ Source/WebCore/platform/NotImplemented.h \ Source/WebCore/platform/Pasteboard.h \ + Source/WebCore/platform/PlatformExportMacros.h \ Source/WebCore/platform/PlatformKeyboardEvent.h \ Source/WebCore/platform/PlatformMenuDescription.h \ Source/WebCore/platform/PlatformMouseEvent.h \ Modified: trunk/Source/WebKit2/ChangeLog (103033 => 103034) --- trunk/Source/WebKit2/ChangeLog 2011-12-16 07:55:16 UTC (rev 103033) +++ trunk/Source/WebKit2/ChangeLog 2011-12-16 07:59:47 UTC (rev 103034) @@ -1,3 +1,9 @@ +2011-12-15 Martin Robinson + +Fix 'make dist' in preparation for the GTK+ release. + +* GNUmakefile.am: Add missing header. + 2011-12-15 Anders Carlsson Add support for accelerated compositing to the tiled Core Animation drawing area Modified: trunk/Source/WebKit2/GNUmakefile.am (103033 => 103034) --- trunk/Source/WebKit2/GNUmakefile.am 2011-12-16 07:55:16 UTC (rev 103033) +++ trunk/Source/WebKit2/GNUmakefile.am 2011-12-16 07:59:47 UTC (rev 103034) @@ -470,6 +470,9 @@ Source/WebKit2/UIProcess/API/C/WKFrame.h \ Source/WebKit2/UIProcess/API/C/WKFramePolicyListener.cpp \ Source/WebKit2/UIProcess/API/C/WKFramePolicyListener.h \ + Source/WebKit2/UIProcess/API/C/WKGeolocationManager.h \ + Source/WebKit2/UIProcess/API/C/WKGeolocationPermissionRequest.h \ + Source/WebKit2/UIProcess/API/C/WKGeolocationPosition.h \ Source/WebKit2/UIProcess/API/C/WKGrammarDetail.cpp \ Source/WebKit2/UIProcess/API/C/WKGrammarDetail.h \ Source/WebKit2/UIProcess/API/C/WKHitTestResult.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
