[webkit-changes] [105968] trunk
Title: [105968] trunk
Revision 105968
Author commit-qu...@webkit.org
Date 2012-01-26 00:06:16 -0800 (Thu, 26 Jan 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.
As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
only checkbox input type should respect the indeterminate state.
Removed the support for indeterminate state for radio input types.
Source/WebCore:
Patch by Joe Thomas joetho...@motorola.com on 2012-01-26
Reviewed by Eric Seidel.
Modified the existing test cases.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setIndeterminate): Indeterminate state is supported only for checkbox input type.
LayoutTests:
Modified the existing test cases.
Patch by Joe Thomas joetho...@motorola.com on 2012-01-26
Reviewed by Eric Seidel.
* fast/forms/indeterminate-radio.html:
* fast/forms/radio-checkbox-restore-indeterminate.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/indeterminate-radio.html
trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (105967 => 105968)
--- trunk/LayoutTests/ChangeLog 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 08:06:16 UTC (rev 105968)
@@ -1,3 +1,19 @@
+2012-01-26 Joe Thomas joetho...@motorola.com
+
+https://bugs.webkit.org/show_bug.cgi?id=76995.
+WebKit fails IETC :indeterminate and input type=radio test.
+
+As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
+only checkbox input type should respect the indeterminate state.
+Removed the support for indeterminate state for radio input types.
+
+Modified the existing test cases.
+
+Reviewed by Eric Seidel.
+
+* fast/forms/indeterminate-radio.html:
+* fast/forms/radio-checkbox-restore-indeterminate.html:
+
2012-01-25 Levi Weintraub le...@chromium.org
Layout Test fast/js/dfg-uint32array-overflow-values.html is slow on Chromium Debug bots
Modified: trunk/LayoutTests/fast/forms/indeterminate-radio.html (105967 => 105968)
--- trunk/LayoutTests/fast/forms/indeterminate-radio.html 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/LayoutTests/fast/forms/indeterminate-radio.html 2012-01-26 08:06:16 UTC (rev 105968)
@@ -5,11 +5,11 @@
style type=text/css
div
{
-color: red;
+color: green;
}
input:indeterminate + #test
{
-color: green;
+color: red;
}
/style
/head
Modified: trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html (105967 => 105968)
--- trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html 2012-01-26 08:06:16 UTC (rev 105968)
@@ -67,8 +67,8 @@
log('Click unselected all radio buttons: FAIL');
log('brChecking whether default-prevented click clobbered indeterminate state:')
-log('On checked radio button: ' + (radio3.indeterminate ? 'PASS' : 'FAIL'));
-log('On unchecked radio button: ' + (radio4.indeterminate ? 'PASS' : 'FAIL'));
+log('On checked radio button: ' + (!radio3.indeterminate ? 'PASS' : 'FAIL'));
+log('On unchecked radio button: ' + (!radio4.indeterminate ? 'PASS' : 'FAIL'));
log('On checked checkbox: ' + (check1.indeterminate ? 'PASS' : 'FAIL'));
log('On unchecked checkbox: ' + (check2.indeterminate ? 'PASS' : 'FAIL'));
Modified: trunk/Source/WebCore/ChangeLog (105967 => 105968)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 07:50:33 UTC (rev 105967)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 08:06:16 UTC (rev 105968)
@@ -1,3 +1,19 @@
+2012-01-26 Joe Thomas joetho...@motorola.com
+
+https://bugs.webkit.org/show_bug.cgi?id=76995.
+WebKit fails IETC :indeterminate and input type=radio test.
+
+As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
+only checkbox input type should respect the indeterminate state.
+Removed the support for indeterminate state for radio input types.
+
+Reviewed by Eric Seidel.
+
+Modified the existing test cases.
+
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::setIndeterminate): Indeterminate state is supported only for checkbox input type.
+
2012-01-25 Daniel Cheng dch...@chromium.org
[chromium] Fix ClipboardChromium::validateFilename to actually operate on extensions
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (105967 => 105968)
---
[webkit-changes] [105969] trunk/Source/WebCore
Title: [105969] trunk/Source/WebCore
Revision 105969
Author vse...@chromium.org
Date 2012-01-26 00:16:01 -0800 (Thu, 26 Jan 2012)
Log Message
Web Inspector: Improve user experience of advanced search panel closing.
https://bugs.webkit.org/show_bug.cgi?id=76983
Reviewed by Pavel Feldman.
Added close button to search panel.
Esc now closes the panel even when search filed has focus.
* English.lproj/localizedStrings.js:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype.close):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype._onKeyDown):
(WebInspector.SearchView.prototype._closeButtonPressed):
* inspector/front-end/inspector.css:
(.search-view .search-panel):
(.search-view .search-panel button.search-close-button):
* inspector/front-end/inspector.js:
(WebInspector._escPressed):
(WebInspector.closeDrawerView):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (105968 => 105969)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 08:06:16 UTC (rev 105968)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 08:16:01 UTC (rev 105969)
@@ -1,3 +1,26 @@
+2012-01-24 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Improve user experience of advanced search panel closing.
+https://bugs.webkit.org/show_bug.cgi?id=76983
+
+Reviewed by Pavel Feldman.
+
+Added close button to search panel.
+Esc now closes the panel even when search filed has focus.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/AdvancedSearchController.js:
+(WebInspector.AdvancedSearchController.prototype.close):
+(WebInspector.SearchView):
+(WebInspector.SearchView.prototype._onKeyDown):
+(WebInspector.SearchView.prototype._closeButtonPressed):
+* inspector/front-end/inspector.css:
+(.search-view .search-panel):
+(.search-view .search-panel button.search-close-button):
+* inspector/front-end/inspector.js:
+(WebInspector._escPressed):
+(WebInspector.closeDrawerView):
+
2012-01-26 Joe Thomas joetho...@motorola.com
https://bugs.webkit.org/show_bug.cgi?id=76995.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js (105968 => 105969)
--- trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2012-01-26 08:06:16 UTC (rev 105968)
+++ trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2012-01-26 08:16:01 UTC (rev 105969)
@@ -83,7 +83,13 @@
else
WebInspector.showViewInDrawer(this._searchView);
},
-
+
+close: function()
+{
+this.stopSearch();
+WebInspector.closeDrawerView();
+},
+
/**
* @param {number} searchId
* @param {Object} searchResult
@@ -193,6 +199,11 @@
this._regexCheckbox.addStyleClass(search-config-checkbox);
this._regexLabel.appendChild(document.createTextNode(WebInspector.UIString(Regular _expression_)));
+this._searchDoneButton = this._searchPanelElement.createChild(button);
+this._searchDoneButton.textContent = WebInspector.UIString(Close);
+this._searchDoneButton.addStyleClass(search-close-button);
+this._searchDoneButton.addEventListener(click, this._closeButtonPressed.bind(this));
+
this._searchStatusBarElement = document.createElement(div);
this._searchStatusBarElement.className = search-status-bar-item;
this._searchMessageElement = this._searchStatusBarElement.createChild(div);
@@ -359,8 +370,16 @@
*/
_onKeyDown: function(event)
{
-if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Enter.code)
+switch (event.keyCode) {
+case WebInspector.KeyboardShortcut.Keys.Enter.code:
this._onAction();
+break;
+case WebInspector.KeyboardShortcut.Keys.Esc.code:
+this._controller.close();
+event.stopPropagation();
+event.preventDefault();
+break;
+}
},
_save: function()
@@ -376,7 +395,12 @@
this._ignoreCaseCheckbox.checked = searchConfig.ignoreCase;
this._regexCheckbox.checked = searchConfig.isRegex;
},
-
+
+_closeButtonPressed: function()
+{
+this._controller.close();
+},
+
_searchStopButtonPressed: function()
{
this._controller.stopSearch();
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (105968 => 105969)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-01-26 08:06:16 UTC (rev 105968)
+++
[webkit-changes] [105970] trunk/Source/JavaScriptCore
Title: [105970] trunk/Source/_javascript_Core Revision 105970 Author aes...@apple.com Date 2012-01-26 00:17:47 -0800 (Thu, 26 Jan 2012) Log Message REGRESSION (r10): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types https://bugs.webkit.org/show_bug.cgi?id=77073 Reviewed by Ryosuke Niwa. r10 changed PLATFORM(WIN) to OS(WIN), but WTF_OS_WIN isn't defined. This should have been changed to OS(WINDOWS). This causes the preprocessor to strip out Win32 data type overrides for deleteOwnedPtr, causing allocations made by Win32 to be deleted by fastmalloc. * wtf/OwnPtrCommon.h: (WTF): Use OS(WINDOWS) instead of OS(WIN). Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/OwnPtrCommon.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (105969 => 105970) --- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 08:16:01 UTC (rev 105969) +++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 08:17:47 UTC (rev 105970) @@ -1,3 +1,18 @@ +2012-01-26 Andy Estes aes...@apple.com + +REGRESSION (r10): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types +https://bugs.webkit.org/show_bug.cgi?id=77073 + +Reviewed by Ryosuke Niwa. + +r10 changed PLATFORM(WIN) to OS(WIN), but WTF_OS_WIN isn't defined. +This should have been changed to OS(WINDOWS). This causes the +preprocessor to strip out Win32 data type overrides for deleteOwnedPtr, +causing allocations made by Win32 to be deleted by fastmalloc. + +* wtf/OwnPtrCommon.h: +(WTF): Use OS(WINDOWS) instead of OS(WIN). + 2012-01-25 Mark Rowe mr...@apple.com Attempted Mac build fix after r105939. Modified: trunk/Source/_javascript_Core/wtf/OwnPtrCommon.h (105969 => 105970) --- trunk/Source/_javascript_Core/wtf/OwnPtrCommon.h 2012-01-26 08:16:01 UTC (rev 105969) +++ trunk/Source/_javascript_Core/wtf/OwnPtrCommon.h 2012-01-26 08:17:47 UTC (rev 105970) @@ -28,7 +28,7 @@ #ifndef WTF_OwnPtrCommon_h #define WTF_OwnPtrCommon_h -#if OS(WIN) +#if OS(WINDOWS) typedef struct HBITMAP__* HBITMAP; typedef struct HBRUSH__* HBRUSH; typedef struct HDC__* HDC; @@ -54,7 +54,7 @@ delete ptr; } -#if OS(WIN) +#if OS(WINDOWS) void deleteOwnedPtr(HBITMAP); void deleteOwnedPtr(HBRUSH); void deleteOwnedPtr(HDC); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105971] trunk
Title: [105971] trunk Revision 105971 Author rn...@webkit.org Date 2012-01-26 00:28:57 -0800 (Thu, 26 Jan 2012) Log Message Port Mozilla's Graph Server https://bugs.webkit.org/show_bug.cgi?id=76312 Reviewed by Adam Barth. Add the app engine backend for the Mozilla's graph server used on perf-webkit.appspot.com. To deploy webkit-perf.appspot.com, you also need to pull index.html, embed.html, graph.html, jq, js (except config.js), and css (except title.png) from https://github.com/mozilla/graphs. * Websites/perf-webkit.appspot.com: Added. * Websites/perf-webkit.appspot.com/app.yaml: Added. * Websites/perf-webkit.appspot.com/create_handler.py: Added. (CreateHandler): (CreateHandler.post): (CreateHandler._createBuilder): (CreateHandler._createBuilder.execute): (CreateHandler._createBranch): (CreateHandler._createBranch.execute): (CreateHandler._createPlatform): (CreateHandler._createPlatform.execute): * Websites/perf-webkit.appspot.com/dashboard_handler.py: Added. (DashboardHandler): (DashboardHandler.get): * Websites/perf-webkit.appspot.com/index.yaml: Added. * Websites/perf-webkit.appspot.com/main.py: Added. (main): * Websites/perf-webkit.appspot.com/manifest_handler.py: Added. (ManifestHandler): (ManifestHandler.get): * Websites/perf-webkit.appspot.com/models.py: Added. (NumericIdHolder): (NumericIdHolder.whose): (createInTransactionWithNumericIdHolder): (modelFromNumericId): (Branch): (Platform): (Builder): (Builder.authenticate): (Builder.hashedPassword): (Build): (Test): (TestResult): (ReportLog): * Websites/perf-webkit.appspot.com/report_handler.py: Added. (ReportHandler): (ReportHandler.post): (ReportHandler._modelByKeyNameInBodyOrError): (ReportHandler._integerInBody): (ReportHandler._timestampInBody): (ReportHandler._output): (ReportHandler._resultsAreValid): (ReportHandler._createBuildIfPossible): (ReportHandler._createBuildIfPossible.execute): (ReportHandler._addTestIfNeeded): (ReportHandler._addTestIfNeeded.execute): * Websites/perf-webkit.appspot.com/runs_handler.py: Added. (RunsHandler): (RunsHandler.get): * Websites/perf-webkit.appspot.com/static: Added. * Websites/perf-webkit.appspot.com/static/create-models.html: Added. * Websites/perf-webkit.appspot.com/static/manual-submit.html: Added. Modified Paths trunk/ChangeLog Added Paths trunk/Websites/webkit-perf.appspot.com/ trunk/Websites/webkit-perf.appspot.com/app.yaml trunk/Websites/webkit-perf.appspot.com/create_handler.py trunk/Websites/webkit-perf.appspot.com/dashboard_handler.py trunk/Websites/webkit-perf.appspot.com/index.yaml trunk/Websites/webkit-perf.appspot.com/js/ trunk/Websites/webkit-perf.appspot.com/js/config.js trunk/Websites/webkit-perf.appspot.com/main.py trunk/Websites/webkit-perf.appspot.com/manifest_handler.py trunk/Websites/webkit-perf.appspot.com/models.py trunk/Websites/webkit-perf.appspot.com/report_handler.py trunk/Websites/webkit-perf.appspot.com/runs_handler.py trunk/Websites/webkit-perf.appspot.com/static/ trunk/Websites/webkit-perf.appspot.com/static/create-models.html trunk/Websites/webkit-perf.appspot.com/static/manual-submit.html Diff Modified: trunk/ChangeLog (105970 => 105971) --- trunk/ChangeLog 2012-01-26 08:17:47 UTC (rev 105970) +++ trunk/ChangeLog 2012-01-26 08:28:57 UTC (rev 105971) @@ -1,3 +1,68 @@ +2012-01-24 Ryosuke Niwa rn...@webkit.org + +Port Mozilla's Graph Server +https://bugs.webkit.org/show_bug.cgi?id=76312 + +Reviewed by Adam Barth. + +Add the app engine backend for the Mozilla's graph server used on perf-webkit.appspot.com. + +To deploy webkit-perf.appspot.com, you also need to pull index.html, embed.html, graph.html, jq, +js (except config.js), and css (except title.png) from https://github.com/mozilla/graphs. + +* Websites/perf-webkit.appspot.com: Added. +* Websites/perf-webkit.appspot.com/app.yaml: Added. +* Websites/perf-webkit.appspot.com/create_handler.py: Added. +(CreateHandler): +(CreateHandler.post): +(CreateHandler._createBuilder): +(CreateHandler._createBuilder.execute): +(CreateHandler._createBranch): +(CreateHandler._createBranch.execute): +(CreateHandler._createPlatform): +(CreateHandler._createPlatform.execute): +* Websites/perf-webkit.appspot.com/dashboard_handler.py: Added. +(DashboardHandler): +(DashboardHandler.get): +* Websites/perf-webkit.appspot.com/index.yaml: Added. +* Websites/perf-webkit.appspot.com/main.py: Added. +(main): +* Websites/perf-webkit.appspot.com/manifest_handler.py: Added. +(ManifestHandler): +(ManifestHandler.get): +* Websites/perf-webkit.appspot.com/models.py: Added. +(NumericIdHolder): +(NumericIdHolder.whose): +(createInTransactionWithNumericIdHolder): +(modelFromNumericId): +(Branch): +(Platform): +(Builder): +(Builder.authenticate): +
[webkit-changes] [105972] branches/safari-534.54-branch/Source
Title: [105972] branches/safari-534.54-branch/Source
Revision 105972
Author mr...@apple.com
Date 2012-01-26 00:55:54 -0800 (Thu, 26 Jan 2012)
Log Message
Merge r105942.
Modified Paths
branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Base.xcconfig
branches/safari-534.54-branch/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
branches/safari-534.54-branch/Source/WebCore/ChangeLog
branches/safari-534.54-branch/Source/WebCore/Configurations/WebCore.xcconfig
branches/safari-534.54-branch/Source/WebKit/mac/ChangeLog
branches/safari-534.54-branch/Source/WebKit/mac/Configurations/WebKit.xcconfig
branches/safari-534.54-branch/Source/WebKit2/ChangeLog
branches/safari-534.54-branch/Source/WebKit2/Configurations/BaseTarget.xcconfig
branches/safari-534.54-branch/Source/WebKit2/Configurations/PluginProcess.xcconfig
branches/safari-534.54-branch/Source/WebKit2/Configurations/WebKit2.xcconfig
branches/safari-534.54-branch/Source/WebKit2/Configurations/WebProcess.xcconfig
Diff
Modified: branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog (105971 => 105972)
--- branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog 2012-01-26 08:28:57 UTC (rev 105971)
+++ branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog 2012-01-26 08:55:54 UTC (rev 105972)
@@ -1,3 +1,22 @@
+2012-01-25 Mark Rowe mr...@apple.com
+
+Merge r105942.
+
+2012-01-25 Mark Rowe mr...@apple.com
+
+Build in to an alternate location when USE_STAGING_INSTALL_PATH is set.
+
+rdar://problem/10609417 Adopt USE_STAGING_INSTALL_PATH
+
+Reviewed by David Kilzer.
+
+* Configurations/Base.xcconfig: Define NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR, which contains
+the path where _javascript_Core is normally installed. Update _javascript_CORE_FRAMEWORKS_DIR
+to point to the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.
+* Configurations/_javascript_Core.xcconfig: Always set the framework's install name based on
+the normal framework location. This prevents an incorrect install name from being used when
+installing in to the staged frameworks directory.
+
2011-01-25 Lucas Forschler lforsch...@apple.com
Merge 105894
Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Base.xcconfig (105971 => 105972)
--- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2012-01-26 08:28:57 UTC (rev 105971)
+++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Base.xcconfig 2012-01-26 08:55:54 UTC (rev 105972)
@@ -77,12 +77,19 @@
TARGET_MAC_OS_X_VERSION_MAJOR = $(MAC_OS_X_VERSION_MAJOR);
+NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR_$(REAL_PLATFORM_NAME));
+NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR_iphoneos = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR_iphonesimulator = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR_iphoneos);
+NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR_macosx = $(SYSTEM_LIBRARY_DIR)/Frameworks;
_javascript_CORE_FRAMEWORKS_DIR = $(_javascript_CORE_FRAMEWORKS_DIR_$(REAL_PLATFORM_NAME));
-_javascript_CORE_FRAMEWORKS_DIR_iphoneos = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+_javascript_CORE_FRAMEWORKS_DIR_iphoneos = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR_iphoneos);
_javascript_CORE_FRAMEWORKS_DIR_iphonesimulator = $(_javascript_CORE_FRAMEWORKS_DIR_iphoneos);
-_javascript_CORE_FRAMEWORKS_DIR_macosx = $(SYSTEM_LIBRARY_DIR)/Frameworks;
+_javascript_CORE_FRAMEWORKS_DIR_macosx = $(_javascript_CORE_FRAMEWORKS_DIR_macosx_USE_STAGING_INSTALL_PATH_$(USE_STAGING_INSTALL_PATH));
+_javascript_CORE_FRAMEWORKS_DIR_macosx_USE_STAGING_INSTALL_PATH_ = $(_javascript_CORE_FRAMEWORKS_DIR_macosx_USE_STAGING_INSTALL_PATH_NO);
+_javascript_CORE_FRAMEWORKS_DIR_macosx_USE_STAGING_INSTALL_PATH_NO = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR);
+_javascript_CORE_FRAMEWORKS_DIR_macosx_USE_STAGING_INSTALL_PATH_YES = $(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari;
// DEBUG_DEFINES, GCC_OPTIMIZATION_LEVEL, STRIP_INSTALLED_PRODUCT and DEAD_CODE_STRIPPING vary between the debug and normal variants.
// We set up the values for each variant here, and have the Debug configuration in the Xcode project use the _debug variant.
Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (105971 => 105972)
--- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2012-01-26 08:28:57 UTC (rev 105971)
+++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2012-01-26 08:55:54 UTC (rev 105972)
@@ -46,6 +46,7 @@
HEADER_SEARCH_PATHS = ${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core $(HEADER_SEARCH_PATHS);
INFOPLIST_FILE = Info.plist;
INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR);
[webkit-changes] [105973] trunk/LayoutTests
Title: [105973] trunk/LayoutTests Revision 105973 Author o...@webkit.org Date 2012-01-26 00:56:21 -0800 (Thu, 26 Jan 2012) Log Message [Qt] Unreviewed gardening after r105917. * platform/qt/Skipped: * platform/qt/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (105972 => 105973) --- trunk/LayoutTests/ChangeLog 2012-01-26 08:55:54 UTC (rev 105972) +++ trunk/LayoutTests/ChangeLog 2012-01-26 08:56:21 UTC (rev 105973) @@ -1,3 +1,10 @@ +2012-01-26 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening after r105917. + +* platform/qt/Skipped: +* platform/qt/test_expectations.txt: + 2012-01-26 Joe Thomas joetho...@motorola.com https://bugs.webkit.org/show_bug.cgi?id=76995. Modified: trunk/LayoutTests/platform/qt/Skipped (105972 => 105973) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-26 08:55:54 UTC (rev 105972) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-26 08:56:21 UTC (rev 105973) @@ -223,6 +223,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=68610 fast/dom/MicroData +# ENABLE(SHADOW_DOM) is disabled +# https://bugs.webkit.org/show_bug.cgi?id=76439 +fast/dom/shadow/content-element-api.html +fast/dom/shadow/content-element-outside-shadow.html + # === # # Feature not yet supported.# # === # Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (105972 => 105973) --- trunk/LayoutTests/platform/qt/test_expectations.txt 2012-01-26 08:55:54 UTC (rev 105972) +++ trunk/LayoutTests/platform/qt/test_expectations.txt 2012-01-26 08:56:21 UTC (rev 105973) @@ -4,10 +4,6 @@ BUGWK64526 DEBUG: svg/animations/svgtransform-animation-1.html = CRASH PASS -// Needs ENABLE_SHADOW_DOM -BUGWK76439 DEBUG : fast/dom/shadow/content-element-api.html = TEXT -BUGWK76439 DEBUG : fast/dom/shadow/content-element-outside-shadow.html = TEXT - // Slow tests // FIXME: File bugs. BUG_QT_SLOW SLOW DEBUG: editing/selection/empty-cell-right-click.html = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105974] trunk/Tools
Title: [105974] trunk/Tools
Revision 105974
Author rga...@webkit.org
Date 2012-01-26 01:01:21 -0800 (Thu, 26 Jan 2012)
Log Message
[GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=76138
Reviewed by Martin Robinson.
* Scripts/webkitdirs.pm:
(isCrossCompilation):
(buildAutotoolsProject):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (105973 => 105974)
--- trunk/Tools/ChangeLog 2012-01-26 08:56:21 UTC (rev 105973)
+++ trunk/Tools/ChangeLog 2012-01-26 09:01:21 UTC (rev 105974)
@@ -1,3 +1,14 @@
+2012-01-26 Gabor Rapcsanyi rga...@webkit.org
+
+[GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
+https://bugs.webkit.org/show_bug.cgi?id=76138
+
+Reviewed by Martin Robinson.
+
+* Scripts/webkitdirs.pm:
+(isCrossCompilation):
+(buildAutotoolsProject):
+
2012-01-25 Adam Barth aba...@webkit.org
Kentaro is a reviewer now. Yay!
Modified: trunk/Tools/Scripts/webkitdirs.pm (105973 => 105974)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-01-26 08:56:21 UTC (rev 105973)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-01-26 09:01:21 UTC (rev 105974)
@@ -1232,6 +1232,19 @@
return $Config{archname} =~ /^arm-/;
}
+sub isCrossCompilation()
+{
+ my $compiler = $ENV{'CC'};
+ if ($compiler =~ /gcc/) {
+ my $compiler_options = `$compiler -v 21`;
+ my @host = $compiler_options =~ m/--host=(.*?)\s/;
+ my @target = $compiler_options =~ m/--target=(.*?)\s/;
+
+ return ($host[0] ne $target[0] ne $host[0] ne $target[0]);
+ }
+ return 0;
+}
+
sub isAppleWebKit()
{
return !(isQt() or isGtk() or isWx() or isChromium() or isEfl() or isWinCE() or isBlackBerry());
@@ -1907,7 +1920,7 @@
chdir .. or die;
-if ($project eq 'WebKit') {
+if ($project eq 'WebKit' !isCrossCompilation()) {
my @docGenerationOptions = ($runWithJhbuild, $gtkScriptsPath/generate-gtkdoc, --skip-html);
if ($debug) {
push(@docGenerationOptions, --debug);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105975] trunk/Source
Title: [105975] trunk/Source Revision 105975 Author zimmerm...@webkit.org Date 2012-01-26 01:09:35 -0800 (Thu, 26 Jan 2012) Log Message 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Try to fix Qt/Win build by building OwnPtrWin.cpp into the WTF library. * WTF.pro: 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Try to fix Gtk build - JSShadowRoot.cpp can't be found, fix by looking for it in the derived sources. * GNUmakefile.list.am: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/WTF.pro trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/WTF/ChangeLog (105974 => 105975) --- trunk/Source/WTF/ChangeLog 2012-01-26 09:01:21 UTC (rev 105974) +++ trunk/Source/WTF/ChangeLog 2012-01-26 09:09:35 UTC (rev 105975) @@ -1,3 +1,9 @@ +2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com + +Not reviewed. Try to fix Qt/Win build by building OwnPtrWin.cpp into the WTF library. + +* WTF.pro: + 2012-01-19 Joi Sigurdsson j...@chromium.org Enable use of precompiled headers in Chromium port on Windows. Modified: trunk/Source/WTF/WTF.pro (105974 => 105975) --- trunk/Source/WTF/WTF.pro 2012-01-26 09:01:21 UTC (rev 105974) +++ trunk/Source/WTF/WTF.pro 2012-01-26 09:09:35 UTC (rev 105975) @@ -220,6 +220,7 @@ ThreadingPthreads.cpp win*|wince*: SOURCES += \ +win/OwnPtrWin.cpp \ OSAllocatorWin.cpp \ ThreadSpecificWin.cpp \ ThreadingWin.cpp Modified: trunk/Source/WebCore/ChangeLog (105974 => 105975) --- trunk/Source/WebCore/ChangeLog 2012-01-26 09:01:21 UTC (rev 105974) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 09:09:35 UTC (rev 105975) @@ -1,3 +1,9 @@ +2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com + +Not reviewed. Try to fix Gtk build - JSShadowRoot.cpp can't be found, fix by looking for it in the derived sources. + +* GNUmakefile.list.am: + 2012-01-24 Vsevolod Vlasov vse...@chromium.org Web Inspector: Improve user experience of advanced search panel closing. Modified: trunk/Source/WebCore/GNUmakefile.list.am (105974 => 105975) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-01-26 09:01:21 UTC (rev 105974) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-01-26 09:09:35 UTC (rev 105975) @@ -467,6 +467,8 @@ DerivedSources/WebCore/JSScriptProfile.h \ DerivedSources/WebCore/JSScriptProfileNode.cpp \ DerivedSources/WebCore/JSScriptProfileNode.h \ + DerivedSources/WebCore/JSShadowRoot.cpp \ + DerivedSources/WebCore/JSShadowRoot.h \ DerivedSources/WebCore/JSSharedWorkerContext.cpp \ DerivedSources/WebCore/JSSharedWorkerContext.h \ DerivedSources/WebCore/JSSharedWorker.cpp \ @@ -1156,8 +1158,6 @@ Source/WebCore/bindings/js/JSSVGLengthCustom.cpp \ Source/WebCore/bindings/js/JSSVGPathSegCustom.cpp \ Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp \ - Source/WebCore/bindings/js/JSShadowRoot.h \ - Source/WebCore/bindings/js/JSShadowRoot.cpp \ Source/WebCore/bindings/js/JSSharedWorkerCustom.cpp \ Source/WebCore/bindings/js/JSStorageCustom.cpp \ Source/WebCore/bindings/js/JSStorageCustom.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105976] trunk/WebKitLibraries
Title: [105976] trunk/WebKitLibraries Revision 105976 Author zimmerm...@webkit.org Date 2012-01-26 01:28:11 -0800 (Thu, 26 Jan 2012) Log Message 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Fix win build, by disabling ENABLE_SHADOW_DOM by default. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: Modified Paths trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops Diff Modified: trunk/WebKitLibraries/ChangeLog (105975 => 105976) --- trunk/WebKitLibraries/ChangeLog 2012-01-26 09:09:35 UTC (rev 105975) +++ trunk/WebKitLibraries/ChangeLog 2012-01-26 09:28:11 UTC (rev 105976) @@ -1,3 +1,10 @@ +2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com + +Not reviewed. Fix win build, by disabling ENABLE_SHADOW_DOM by default. + +* win/tools/vsprops/FeatureDefines.vsprops: +* win/tools/vsprops/FeatureDefinesCairo.vsprops: + 2012-01-25 Hajime Morita morr...@google.com ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom Modified: trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops (105975 => 105976) --- trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops 2012-01-26 09:09:35 UTC (rev 105975) +++ trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops 2012-01-26 09:28:11 UTC (rev 105976) @@ -238,7 +238,7 @@ / UserMacro Name=ENABLE_SHADOW_DOM - Value=ENABLE_SHADOW_DOM + Value= PerformEnvironmentSet=true / UserMacro Modified: trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops (105975 => 105976) --- trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops 2012-01-26 09:09:35 UTC (rev 105975) +++ trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops 2012-01-26 09:28:11 UTC (rev 105976) @@ -233,7 +233,7 @@ / UserMacro Name=ENABLE_SHADOW_DOM - Value=ENABLE_SHADOW_DOM + Value= PerformEnvironmentSet=true / UserMacro ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105979] trunk/Tools
Title: [105979] trunk/Tools Revision 105979 Author commit-qu...@webkit.org Date 2012-01-26 01:51:20 -0800 (Thu, 26 Jan 2012) Log Message Unreviewed, rolling out r105935 and r105954. http://trac.webkit.org/changeset/105935 http://trac.webkit.org/changeset/105954 https://bugs.webkit.org/show_bug.cgi?id=77080 test-webkitpy is still broken (Requested by abarth on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-26 * Scripts/test-webkitpy: * Scripts/webkitpy/common/system/executive_unittest.py: (never_ending_command): (ExecutiveTest.test_run_command_args_type): (ExecutiveTest.test_run_command_with_unicode): (ExecutiveTest.test_running_pids): * Scripts/webkitpy/common/system/fileutils.py: (make_stdout_binary): * Scripts/webkitpy/test/cat.py: (command_arguments): (main): * Scripts/webkitpy/test/cat_unittest.py: (CatTest): (CatTest.assert_cat): (CatTest.test_basic): (CatTest.test_no_newline): (CatTest.test_unicode): (CatTest.test_as_command): * Scripts/webkitpy/test/echo.py: (command_arguments): (main): * Scripts/webkitpy/test/echo_unittest.py: (EchoTest): (EchoTest.test_basic): (EchoTest.test_no_newline): (EchoTest.test_unicode): (EchoTest.test_argument_order): (EchoTest.test_empty_arguments): (EchoTest.test_no_arguments): (EchoTest.test_as_command): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/test-webkitpy trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py trunk/Tools/Scripts/webkitpy/common/system/fileutils.py trunk/Tools/Scripts/webkitpy/test/cat.py trunk/Tools/Scripts/webkitpy/test/cat_unittest.py trunk/Tools/Scripts/webkitpy/test/echo.py trunk/Tools/Scripts/webkitpy/test/echo_unittest.py Diff Modified: trunk/Tools/ChangeLog (105978 => 105979) --- trunk/Tools/ChangeLog 2012-01-26 09:50:47 UTC (rev 105978) +++ trunk/Tools/ChangeLog 2012-01-26 09:51:20 UTC (rev 105979) @@ -1,3 +1,44 @@ +2012-01-26 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r105935 and r105954. +http://trac.webkit.org/changeset/105935 +http://trac.webkit.org/changeset/105954 +https://bugs.webkit.org/show_bug.cgi?id=77080 + +test-webkitpy is still broken (Requested by abarth on +#webkit). + +* Scripts/test-webkitpy: +* Scripts/webkitpy/common/system/executive_unittest.py: +(never_ending_command): +(ExecutiveTest.test_run_command_args_type): +(ExecutiveTest.test_run_command_with_unicode): +(ExecutiveTest.test_running_pids): +* Scripts/webkitpy/common/system/fileutils.py: +(make_stdout_binary): +* Scripts/webkitpy/test/cat.py: +(command_arguments): +(main): +* Scripts/webkitpy/test/cat_unittest.py: +(CatTest): +(CatTest.assert_cat): +(CatTest.test_basic): +(CatTest.test_no_newline): +(CatTest.test_unicode): +(CatTest.test_as_command): +* Scripts/webkitpy/test/echo.py: +(command_arguments): +(main): +* Scripts/webkitpy/test/echo_unittest.py: +(EchoTest): +(EchoTest.test_basic): +(EchoTest.test_no_newline): +(EchoTest.test_unicode): +(EchoTest.test_argument_order): +(EchoTest.test_empty_arguments): +(EchoTest.test_no_arguments): +(EchoTest.test_as_command): + 2012-01-26 Gabor Rapcsanyi rga...@webkit.org [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc Modified: trunk/Tools/Scripts/test-webkitpy (105978 => 105979) --- trunk/Tools/Scripts/test-webkitpy 2012-01-26 09:50:47 UTC (rev 105978) +++ trunk/Tools/Scripts/test-webkitpy 2012-01-26 09:51:20 UTC (rev 105979) @@ -42,7 +42,7 @@ if __name__ == __main__: -webkit_root = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__ +webkit_root = os.path.dirname(os.path.dirname(os.path.dirname(__file__))) # FIXME: We should probably test each package separately to avoid naming conflicts. dirs = [ Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py (105978 => 105979) --- trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-01-26 09:50:47 UTC (rev 105978) +++ trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-01-26 09:51:20 UTC (rev 105979) @@ -35,6 +35,7 @@ from webkitpy.common.system.executive import Executive, ScriptError from webkitpy.common.system.filesystem_mock import MockFileSystem +from webkitpy.test import cat, echo class ScriptErrorTest(unittest.TestCase): @@ -63,27 +64,8 @@ return ['yes'] -def command_line(cmd, *args): -return [sys.executable, __file__, '--' + cmd] + list(args) - - -def script_dir(): -return os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__) - - class ExecutiveTest(unittest.TestCase): -def setUp(self): -# We need this so that we can launch 'python executive_unittests.py' directly
[webkit-changes] [105978] trunk
Title: [105978] trunk Revision 105978 Author zimmerm...@webkit.org Date 2012-01-26 01:50:47 -0800 (Thu, 26 Jan 2012) Log Message crash in WebCore::RenderSVGContainer::paint https://bugs.webkit.org/show_bug.cgi?id=69714 Reviewed by Dirk Schulze. Source/WebCore: When RenderSVGResourceClipper draws its children to a mask, it requires some special constraints: - fill-opacity/stroke-opacity/opacity forced to 1 - masker/filter resources shouldn't be applied to the children - fill must be set to the initial fill paint server for all children (solid black) - stroke must be set to the initial stroke paint server for all children (none) This was achieved before by mutating the style of the children, which made them need a relayout. SVGImageBufferTools:renderSubtreeToImageBuffer thus needed to layout the children, if needed, before painting. This can be completly avoided, when changing RenderSVGResourceClipper to avoid style mutations. Introduce a new PaintBehaviorRenderingSVGMask, and set the current FrameViews paintBehaviour to this state, before painting the subtree. This way we can detect that we're rendering a clip mask, without having to mutate the style of the children and without having to relayout. We can now ASSERT(!item-needsLayout()) in renderSubtreeToImageBuffer. Tests: svg/clip-path/clip-path-tspan-and-stroke.svg svg/custom/layout-loop.svg * rendering/PaintPhase.h: * rendering/svg/RenderSVGResource.cpp: (WebCore::requestPaintingResource): * rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::removeAllClientsFromCache): (WebCore::RenderSVGResourceClipper::removeClientFromCache): (WebCore::RenderSVGResourceClipper::applyClippingToContext): (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): * rendering/svg/RenderSVGResourceClipper.h: * rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource): (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): * rendering/svg/RenderSVGResourceMasker.h: * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::createTileImage): * rendering/svg/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::applyResource): * rendering/svg/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer): * rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintSelectionBackground): (WebCore::SVGInlineTextBox::paint): * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent): LayoutTests: Added a new test covering the clipper specific demands when rendering its children to a mask. (fill/stroke-opacity=1, opacity=1, don't apply masker/filter to children) All cases are covered by existing tests, I'm adding a new combination of tspan within a text, that tries to apply a stroke paint server, which is supposed to be ignored. * platform/chromium/test_expectations.txt: * platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added. * platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added. * svg/clip-path/clip-path-tspan-and-stroke.svg: Added. * svg/custom/layout-loop-expected.txt: Added. * svg/custom/layout-loop.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/PaintPhase.h trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.h trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.h trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp Added Paths trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt trunk/LayoutTests/svg/clip-path/clip-path-tspan-and-stroke.svg trunk/LayoutTests/svg/custom/layout-loop-expected.txt trunk/LayoutTests/svg/custom/layout-loop.svg Diff Modified: trunk/LayoutTests/ChangeLog (105977 => 105978) --- trunk/LayoutTests/ChangeLog 2012-01-26 09:40:26 UTC (rev 105977) +++ trunk/LayoutTests/ChangeLog 2012-01-26 09:50:47 UTC (rev 105978) @@ -1,5 +1,25 @@ 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com +crash in WebCore::RenderSVGContainer::paint +https://bugs.webkit.org/show_bug.cgi?id=69714 + +Reviewed by Dirk Schulze. + +Added a new test covering the clipper specific demands when rendering its children to a mask. +
[webkit-changes] [105980] trunk
Title: [105980] trunk
Revision 105980
Author tk...@chromium.org
Date 2012-01-26 02:07:12 -0800 (Thu, 26 Jan 2012)
Log Message
Unreviewed, rolling out r105968.
http://trac.webkit.org/changeset/105968
https://bugs.webkit.org/show_bug.cgi?id=76995
Incorrect behavior change
Source/WebCore:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setIndeterminate):
LayoutTests:
* fast/forms/indeterminate-radio.html:
* fast/forms/radio-checkbox-restore-indeterminate.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/indeterminate-radio.html
trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (105979 => 105980)
--- trunk/LayoutTests/ChangeLog 2012-01-26 09:51:20 UTC (rev 105979)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 10:07:12 UTC (rev 105980)
@@ -1,3 +1,14 @@
+2012-01-26 Kent Tamura tk...@chromium.org
+
+Unreviewed, rolling out r105968.
+http://trac.webkit.org/changeset/105968
+https://bugs.webkit.org/show_bug.cgi?id=76995
+
+Incorrect behavior change
+
+* fast/forms/indeterminate-radio.html:
+* fast/forms/radio-checkbox-restore-indeterminate.html:
+
2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
crash in WebCore::RenderSVGContainer::paint
Modified: trunk/LayoutTests/fast/forms/indeterminate-radio.html (105979 => 105980)
--- trunk/LayoutTests/fast/forms/indeterminate-radio.html 2012-01-26 09:51:20 UTC (rev 105979)
+++ trunk/LayoutTests/fast/forms/indeterminate-radio.html 2012-01-26 10:07:12 UTC (rev 105980)
@@ -5,11 +5,11 @@
style type=text/css
div
{
-color: green;
+color: red;
}
input:indeterminate + #test
{
-color: red;
+color: green;
}
/style
/head
Modified: trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html (105979 => 105980)
--- trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html 2012-01-26 09:51:20 UTC (rev 105979)
+++ trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html 2012-01-26 10:07:12 UTC (rev 105980)
@@ -67,8 +67,8 @@
log('Click unselected all radio buttons: FAIL');
log('brChecking whether default-prevented click clobbered indeterminate state:')
-log('On checked radio button: ' + (!radio3.indeterminate ? 'PASS' : 'FAIL'));
-log('On unchecked radio button: ' + (!radio4.indeterminate ? 'PASS' : 'FAIL'));
+log('On checked radio button: ' + (radio3.indeterminate ? 'PASS' : 'FAIL'));
+log('On unchecked radio button: ' + (radio4.indeterminate ? 'PASS' : 'FAIL'));
log('On checked checkbox: ' + (check1.indeterminate ? 'PASS' : 'FAIL'));
log('On unchecked checkbox: ' + (check2.indeterminate ? 'PASS' : 'FAIL'));
Modified: trunk/Source/WebCore/ChangeLog (105979 => 105980)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 09:51:20 UTC (rev 105979)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 10:07:12 UTC (rev 105980)
@@ -1,3 +1,14 @@
+2012-01-26 Kent Tamura tk...@chromium.org
+
+Unreviewed, rolling out r105968.
+http://trac.webkit.org/changeset/105968
+https://bugs.webkit.org/show_bug.cgi?id=76995
+
+Incorrect behavior change
+
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::setIndeterminate):
+
2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
crash in WebCore::RenderSVGContainer::paint
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (105979 => 105980)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-01-26 09:51:20 UTC (rev 105979)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-01-26 10:07:12 UTC (rev 105980)
@@ -946,7 +946,7 @@
void HTMLInputElement::setIndeterminate(bool newValue)
{
-if (!isCheckbox() || indeterminate() == newValue)
+if (!m_inputType-isCheckable() || indeterminate() == newValue)
return;
m_isIndeterminate = newValue;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105981] trunk/Tools
Title: [105981] trunk/Tools
Revision 105981
Author kbal...@webkit.org
Date 2012-01-26 02:10:22 -0800 (Thu, 26 Jan 2012)
Log Message
[NRWT] Support --ignore-metrics
https://bugs.webkit.org/show_bug.cgi?id=76278
Reviewed by Tony Chang.
Port the feature from ORWT.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_compare_test):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput):
(DriverOutput.strip_metrics):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverOutputTest):
(DriverOutputTest.test_strip_metrics):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Diff
Modified: trunk/Tools/ChangeLog (105980 => 105981)
--- trunk/Tools/ChangeLog 2012-01-26 10:07:12 UTC (rev 105980)
+++ trunk/Tools/ChangeLog 2012-01-26 10:10:22 UTC (rev 105981)
@@ -1,3 +1,24 @@
+2012-01-26 Balazs Kelemen kbal...@webkit.org
+
+[NRWT] Support --ignore-metrics
+https://bugs.webkit.org/show_bug.cgi?id=76278
+
+Reviewed by Tony Chang.
+
+Port the feature from ORWT.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+(SingleTestRunner._run_compare_test):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(DriverOutput):
+(DriverOutput.strip_metrics):
+* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
+(DriverOutputTest):
+(DriverOutputTest.test_strip_metrics):
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(_set_up_derived_options):
+(parse_args):
+
2012-01-26 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r105935 and r105954.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (105980 => 105981)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-01-26 10:07:12 UTC (rev 105980)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-01-26 10:10:22 UTC (rev 105981)
@@ -104,6 +104,11 @@
def _run_compare_test(self):
driver_output = self._driver.run_test(self._driver_input())
expected_driver_output = self._expected_driver_output()
+
+if self._options.ignore_metrics:
+expected_driver_output.strip_metrics()
+driver_output.strip_metrics()
+
test_result = self._compare_output(driver_output, expected_driver_output)
if self._options.new_test_results:
self._add_missing_baselines(test_result, driver_output)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (105980 => 105981)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-01-26 10:07:12 UTC (rev 105980)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-01-26 10:10:22 UTC (rev 105981)
@@ -26,6 +26,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import re
import shlex
from webkitpy.common.system import path
@@ -40,8 +41,26 @@
class DriverOutput(object):
-Groups information about a output from driver for easy passing of data.
+Groups information about a output from driver for easy passing
+and post-processing of data.
+strip_patterns = []
+strip_patterns.append((re.compile('at \(-?[0-9]+,-?[0-9]+\) *'), ''))
+strip_patterns.append((re.compile('size -?[0-9]+x-?[0-9]+ *'), ''))
+strip_patterns.append((re.compile('text run width -?[0-9]+: '), ''))
+strip_patterns.append((re.compile('text run width -?[0-9]+ [a-zA-Z ]+: '), ''))
+strip_patterns.append((re.compile('RenderButton {BUTTON} .*'), 'RenderButton {BUTTON}'))
+strip_patterns.append((re.compile('RenderImage {INPUT} .*'), 'RenderImage {INPUT}'))
+strip_patterns.append((re.compile('RenderBlock {INPUT} .*'), 'RenderBlock {INPUT}'))
+strip_patterns.append((re.compile('RenderTextControl {INPUT} .*'), 'RenderTextControl {INPUT}'))
+strip_patterns.append((re.compile('\([0-9]+px'), 'px'))
+strip_patterns.append((re.compile(' * *\n + *'), ' '))
+strip_patterns.append((re.compile(' +$'), ''))
+strip_patterns.append((re.compile('- '), '-'))
+strip_patterns.append((re.compile('\s+\n'), '\n'))
+strip_patterns.append((re.compile('scrollWidth [0-9]+'), 'scrollWidth'))
+strip_patterns.append((re.compile('scrollHeight [0-9]+'), 'scrollHeight'))
+
def __init__(self, text, image, image_hash, audio, crash=False,
test_time=0, timeout=False, error='', crashed_process_name=None):
# FIXME: Args could be renamed to better
[webkit-changes] [105982] trunk/Source/JavaScriptCore
Title: [105982] trunk/Source/_javascript_Core
Revision 105982
Author commit-qu...@webkit.org
Date 2012-01-26 02:22:25 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309
Patch by Roland Takacs takacs.rol...@stud.u-szeged.hu on 2012-01-26
Reviewed by Zoltan Herczeg.
These changes made the parallel gc feature available for Qt port.
The implementation of registerGCThread and isMainThreadOrGCThread
is moved from MainThreadMac.mm to the common MainThread.cpp to make
them available for other platforms.
Measurement results:
V8 speed-up: 1.071x as fast [From: 746.1ms To: 696.4ms ]
WindScorpion speed-up: 1.082x as fast [From: 3490.4ms To: 3226.7ms]
V8 Splay speed-up: 1.158x as fast [From: 145.8ms To: 125.9ms ]
Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.
* wtf/MainThread.cpp:
(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
* wtf/Platform.h:
* wtf/mac/MainThreadMac.mm:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/MainThread.cpp
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (105981 => 105982)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 10:10:22 UTC (rev 105981)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 10:22:25 UTC (rev 105982)
@@ -1,3 +1,29 @@
+2012-01-26 Roland Takacs takacs.rol...@stud.u-szeged.hu
+
+[Qt] GC should be parallel on Qt platform
+https://bugs.webkit.org/show_bug.cgi?id=73309
+
+Reviewed by Zoltan Herczeg.
+
+These changes made the parallel gc feature available for Qt port.
+The implementation of registerGCThread and isMainThreadOrGCThread
+is moved from MainThreadMac.mm to the common MainThread.cpp to make
+them available for other platforms.
+
+Measurement results:
+V8 speed-up: 1.071x as fast [From: 746.1ms To: 696.4ms ]
+WindScorpion speed-up: 1.082x as fast [From: 3490.4ms To: 3226.7ms]
+V8 Splay speed-up: 1.158x as fast [From: 145.8ms To: 125.9ms ]
+
+Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.
+
+* wtf/MainThread.cpp:
+(WTF):
+(WTF::registerGCThread):
+(WTF::isMainThreadOrGCThread):
+* wtf/Platform.h:
+* wtf/mac/MainThreadMac.mm:
+
2012-01-26 Andy Estes aes...@apple.com
REGRESSION (r10): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types
Modified: trunk/Source/_javascript_Core/wtf/MainThread.cpp (105981 => 105982)
--- trunk/Source/_javascript_Core/wtf/MainThread.cpp 2012-01-26 10:10:22 UTC (rev 105981)
+++ trunk/Source/_javascript_Core/wtf/MainThread.cpp 2012-01-26 10:22:25 UTC (rev 105982)
@@ -34,6 +34,7 @@
#include Functional.h
#include StdLibExtras.h
#include Threading.h
+#include wtf/ThreadSpecific.h
#if PLATFORM(CHROMIUM)
#error Chromium uses a different main thread implementation
@@ -249,4 +250,33 @@
}
#endif
+#if ENABLE(PARALLEL_GC)
+static ThreadSpecificbool* isGCThread;
+
+void registerGCThread()
+{
+if (!isGCThread) {
+// This happens if we're running in a process that doesn't care about
+// MainThread.
+return;
+}
+
+**isGCThread = true;
+}
+
+bool isMainThreadOrGCThread()
+{
+if (isGCThread-isSet() **isGCThread)
+return true;
+
+return isMainThread();
+}
+#elif PLATFORM(MAC)
+// This is necessary because _javascript_Core.exp doesn't support preprocessor macros.
+bool isMainThreadOrGCThread()
+{
+return isMainThread();
+}
+#endif
+
} // namespace WTF
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (105981 => 105982)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2012-01-26 10:10:22 UTC (rev 105981)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2012-01-26 10:22:25 UTC (rev 105982)
@@ -1120,7 +1120,7 @@
#define ENABLE_COMPARE_AND_SWAP 1
#endif
-#if !defined(ENABLE_PARALLEL_GC) (PLATFORM(MAC) || PLATFORM(IOS)) ENABLE(COMPARE_AND_SWAP)
+#if !defined(ENABLE_PARALLEL_GC) (PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT)) ENABLE(COMPARE_AND_SWAP)
#define ENABLE_PARALLEL_GC 1
#endif
Modified: trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm (105981 => 105982)
--- trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm 2012-01-26 10:10:22 UTC (rev 105981)
+++ trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm 2012-01-26 10:22:25 UTC (rev 105982)
@@ -145,31 +145,4 @@
return pthread_equal(pthread_self(), mainThreadPthread);
}
-#if ENABLE(PARALLEL_GC)
-void registerGCThread()
-{
-if (!isGCThread) {
-// This happens if we're running in a process that doesn't care about
-// MainThread.
-return;
-}
-
-**isGCThread = true;
-}
-
-bool isMainThreadOrGCThread()
-{
-if (isGCThread-isSet() **isGCThread)
[webkit-changes] [105983] trunk/Source/WebCore
Title: [105983] trunk/Source/WebCore
Revision 105983
Author zimmerm...@webkit.org
Date 2012-01-26 02:26:13 -0800 (Thu, 26 Jan 2012)
Log Message
2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Fix release builds after r105978.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintSelectionBackground): Remove unused variable.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (105982 => 105983)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 10:22:25 UTC (rev 105982)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 10:26:13 UTC (rev 105983)
@@ -1,3 +1,10 @@
+2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
+
+Not reviewed. Fix release builds after r105978.
+
+* rendering/svg/SVGInlineTextBox.cpp:
+(WebCore::SVGInlineTextBox::paintSelectionBackground): Remove unused variable.
+
2012-01-26 Kent Tamura tk...@chromium.org
Unreviewed, rolling out r105968.
Modified: trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (105982 => 105983)
--- trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 10:22:25 UTC (rev 105982)
+++ trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 10:26:13 UTC (rev 105983)
@@ -195,9 +195,6 @@
RenderStyle* style = parentRenderer-style();
ASSERT(style);
-const SVGRenderStyle* svgStyle = style-svgStyle();
-ASSERT(svgStyle);
-
RenderStyle* selectionStyle = style;
if (hasSelection) {
selectionStyle = parentRenderer-getCachedPseudoStyle(SELECTION);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105984] trunk/Source/WebCore
Title: [105984] trunk/Source/WebCore
Revision 105984
Author vse...@chromium.org
Date 2012-01-26 02:29:09 -0800 (Thu, 26 Jan 2012)
Log Message
Unreviewed inspector closure compilation fix.
* inspector/front-end/externs.js:
(WebInspector.closeDrawerView):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/externs.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (105983 => 105984)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 10:26:13 UTC (rev 105983)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 10:29:09 UTC (rev 105984)
@@ -1,3 +1,10 @@
+2012-01-26 Vsevolod Vlasov vse...@chromium.org
+
+Unreviewed inspector closure compilation fix.
+
+* inspector/front-end/externs.js:
+(WebInspector.closeDrawerView):
+
2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Fix release builds after r105978.
Modified: trunk/Source/WebCore/inspector/front-end/externs.js (105983 => 105984)
--- trunk/Source/WebCore/inspector/front-end/externs.js 2012-01-26 10:26:13 UTC (rev 105983)
+++ trunk/Source/WebCore/inspector/front-end/externs.js 2012-01-26 10:29:09 UTC (rev 105984)
@@ -102,6 +102,7 @@
*/
WebInspector.showViewInDrawer = function(view) {}
+WebInspector.closeDrawerView = function() {}
/**
* @param {string=} messageLevel
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105985] trunk/Source/WebCore
Title: [105985] trunk/Source/WebCore Revision 105985 Author zimmerm...@webkit.org Date 2012-01-26 02:41:52 -0800 (Thu, 26 Jan 2012) Log Message 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Fix non-AllInOne builds after r105978. * rendering/svg/RenderSVGResource.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (105984 => 105985) --- trunk/Source/WebCore/ChangeLog 2012-01-26 10:29:09 UTC (rev 105984) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 10:41:52 UTC (rev 105985) @@ -1,3 +1,9 @@ +2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com + +Not reviewed. Fix non-AllInOne builds after r105978. + +* rendering/svg/RenderSVGResource.cpp: + 2012-01-26 Vsevolod Vlasov vse...@chromium.org Unreviewed inspector closure compilation fix. Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp (105984 => 105985) --- trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2012-01-26 10:29:09 UTC (rev 105984) +++ trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2012-01-26 10:41:52 UTC (rev 105985) @@ -25,6 +25,8 @@ #if ENABLE(SVG) #include RenderSVGResource.h +#include Frame.h +#include FrameView.h #include RenderSVGResourceContainer.h #include RenderSVGResourceFilter.h #include RenderSVGResourceSolidColor.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105986] trunk/Source/WebCore
Title: [105986] trunk/Source/WebCore Revision 105986 Author zimmerm...@webkit.org Date 2012-01-26 03:08:26 -0800 (Thu, 26 Jan 2012) Log Message 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Fix Qt build after r105978. * rendering/svg/RenderSVGResourceClipper.cpp: Add missing Frame/FrameView includes. * rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto. * rendering/svg/SVGInlineTextBox.cpp: Ditto. * rendering/svg/SVGRenderSupport.cpp: Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (105985 => 105986) --- trunk/Source/WebCore/ChangeLog 2012-01-26 10:41:52 UTC (rev 105985) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 11:08:26 UTC (rev 105986) @@ -1,5 +1,14 @@ 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com +Not reviewed. Fix Qt build after r105978. + +* rendering/svg/RenderSVGResourceClipper.cpp: Add missing Frame/FrameView includes. +* rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto. +* rendering/svg/SVGInlineTextBox.cpp: Ditto. +* rendering/svg/SVGRenderSupport.cpp: Ditto. + +2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com + Not reviewed. Fix non-AllInOne builds after r105978. * rendering/svg/RenderSVGResource.cpp: Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp (105985 => 105986) --- trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2012-01-26 10:41:52 UTC (rev 105985) +++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2012-01-26 11:08:26 UTC (rev 105986) @@ -27,6 +27,8 @@ #include AffineTransform.h #include FloatRect.h +#include Frame.h +#include FrameView.h #include GraphicsContext.h #include HitTestRequest.h #include HitTestResult.h Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp (105985 => 105986) --- trunk/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp 2012-01-26 10:41:52 UTC (rev 105985) +++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp 2012-01-26 11:08:26 UTC (rev 105986) @@ -22,6 +22,8 @@ #if ENABLE(SVG) #include RenderSVGResourceSolidColor.h +#include Frame.h +#include FrameView.h #include GraphicsContext.h #include RenderSVGShape.h #include RenderStyle.h Modified: trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (105985 => 105986) --- trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 10:41:52 UTC (rev 105985) +++ trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 11:08:26 UTC (rev 105986) @@ -25,6 +25,8 @@ #if ENABLE(SVG) #include FloatConversion.h #include FontCache.h +#include Frame.h +#include FrameView.h #include GraphicsContext.h #include HitTestResult.h #include InlineFlowBox.h Modified: trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp (105985 => 105986) --- trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2012-01-26 10:41:52 UTC (rev 105985) +++ trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2012-01-26 11:08:26 UTC (rev 105986) @@ -27,6 +27,7 @@ #if ENABLE(SVG) #include SVGRenderSupport.h +#include Frame.h #include FrameView.h #include ImageBuffer.h #include NodeRenderStyle.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105987] trunk/Source/JavaScriptCore
Title: [105987] trunk/Source/_javascript_Core
Revision 105987
Author zimmerm...@webkit.org
Date 2012-01-26 03:58:40 -0800 (Thu, 26 Jan 2012)
Log Message
Unreviewed, rolling out r105982.
http://trac.webkit.org/changeset/105982
https://bugs.webkit.org/show_bug.cgi?id=77090
breaks the world (Requested by WildFox on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-26
* wtf/MainThread.cpp:
(WTF):
* wtf/Platform.h:
* wtf/mac/MainThreadMac.mm:
(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/MainThread.cpp
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (105986 => 105987)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 11:08:26 UTC (rev 105986)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 11:58:40 UTC (rev 105987)
@@ -1,3 +1,19 @@
+2012-01-26 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r105982.
+http://trac.webkit.org/changeset/105982
+https://bugs.webkit.org/show_bug.cgi?id=77090
+
+breaks the world (Requested by WildFox on #webkit).
+
+* wtf/MainThread.cpp:
+(WTF):
+* wtf/Platform.h:
+* wtf/mac/MainThreadMac.mm:
+(WTF):
+(WTF::registerGCThread):
+(WTF::isMainThreadOrGCThread):
+
2012-01-26 Roland Takacs takacs.rol...@stud.u-szeged.hu
[Qt] GC should be parallel on Qt platform
Modified: trunk/Source/_javascript_Core/wtf/MainThread.cpp (105986 => 105987)
--- trunk/Source/_javascript_Core/wtf/MainThread.cpp 2012-01-26 11:08:26 UTC (rev 105986)
+++ trunk/Source/_javascript_Core/wtf/MainThread.cpp 2012-01-26 11:58:40 UTC (rev 105987)
@@ -34,7 +34,6 @@
#include Functional.h
#include StdLibExtras.h
#include Threading.h
-#include wtf/ThreadSpecific.h
#if PLATFORM(CHROMIUM)
#error Chromium uses a different main thread implementation
@@ -250,33 +249,4 @@
}
#endif
-#if ENABLE(PARALLEL_GC)
-static ThreadSpecificbool* isGCThread;
-
-void registerGCThread()
-{
-if (!isGCThread) {
-// This happens if we're running in a process that doesn't care about
-// MainThread.
-return;
-}
-
-**isGCThread = true;
-}
-
-bool isMainThreadOrGCThread()
-{
-if (isGCThread-isSet() **isGCThread)
-return true;
-
-return isMainThread();
-}
-#elif PLATFORM(MAC)
-// This is necessary because _javascript_Core.exp doesn't support preprocessor macros.
-bool isMainThreadOrGCThread()
-{
-return isMainThread();
-}
-#endif
-
} // namespace WTF
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (105986 => 105987)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2012-01-26 11:08:26 UTC (rev 105986)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2012-01-26 11:58:40 UTC (rev 105987)
@@ -1120,7 +1120,7 @@
#define ENABLE_COMPARE_AND_SWAP 1
#endif
-#if !defined(ENABLE_PARALLEL_GC) (PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT)) ENABLE(COMPARE_AND_SWAP)
+#if !defined(ENABLE_PARALLEL_GC) (PLATFORM(MAC) || PLATFORM(IOS)) ENABLE(COMPARE_AND_SWAP)
#define ENABLE_PARALLEL_GC 1
#endif
Modified: trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm (105986 => 105987)
--- trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm 2012-01-26 11:08:26 UTC (rev 105986)
+++ trunk/Source/_javascript_Core/wtf/mac/MainThreadMac.mm 2012-01-26 11:58:40 UTC (rev 105987)
@@ -145,4 +145,31 @@
return pthread_equal(pthread_self(), mainThreadPthread);
}
+#if ENABLE(PARALLEL_GC)
+void registerGCThread()
+{
+if (!isGCThread) {
+// This happens if we're running in a process that doesn't care about
+// MainThread.
+return;
+}
+
+**isGCThread = true;
+}
+
+bool isMainThreadOrGCThread()
+{
+if (isGCThread-isSet() **isGCThread)
+return true;
+
+return isMainThread();
+}
+#else
+// This is necessary because _javascript_Core.exp doesn't support preprocessor macros.
+bool isMainThreadOrGCThread()
+{
+return isMainThread();
+}
+#endif
+
} // namespace WTF
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105988] trunk
Title: [105988] trunk Revision 105988 Author commit-qu...@webkit.org Date 2012-01-26 04:16:25 -0800 (Thu, 26 Jan 2012) Log Message [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission https://bugs.webkit.org/show_bug.cgi?id=42545 Patch by Nándor Huszka huszka.nan...@stud.u-szeged.hu on 2012-01-26 Reviewed by Zoltan Herczeg. Source/WebCore: No need for new tests, there is no behavior change. Added a line to file which copies the forwarding headers. * WebCore.vcproj/copyForwardingHeaders.cmd: Source/WebKit2: Implement the setGeolocationPermission method. * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetGeolocationPermission): * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setGeoLocationPermission): (WebKit): * WebProcess/InjectedBundle/InjectedBundle.h: (InjectedBundle): Tools: Implement the setGeolocationPermission method. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setGeolocationPermission): (WTR): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: (LayoutTestController): LayoutTests: Unskip a test which does not fail now and move tests to the appropriate label. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h Diff Modified: trunk/LayoutTests/ChangeLog (105987 => 105988) --- trunk/LayoutTests/ChangeLog 2012-01-26 11:58:40 UTC (rev 105987) +++ trunk/LayoutTests/ChangeLog 2012-01-26 12:16:25 UTC (rev 105988) @@ -1,3 +1,14 @@ +2012-01-26 Nándor Huszka huszka.nan...@stud.u-szeged.hu + +[WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission +https://bugs.webkit.org/show_bug.cgi?id=42545 + +Reviewed by Zoltan Herczeg. + +Unskip a test which does not fail now and move tests to the appropriate label. + +* platform/wk2/Skipped: + 2012-01-26 Kent Tamura tk...@chromium.org Unreviewed, rolling out r105968. Modified: trunk/LayoutTests/platform/wk2/Skipped (105987 => 105988) --- trunk/LayoutTests/platform/wk2/Skipped 2012-01-26 11:58:40 UTC (rev 105987) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-01-26 12:16:25 UTC (rev 105988) @@ -535,9 +535,9 @@ platform/mac/fast/loader/file-url-mimetypes-3.html platform/mac/fast/loader/file-url-mimetypes.html -# WebKitTestRunner needs layoutTestController.setGeolocationPermission -# https://bugs.webkit.org/show_bug.cgi?id=42545 -fast/dom/Geolocation/argument-types.html +# WebKitTestRunner needs layoutTestController.setMockGeolocationPosition +# and layoutTestController.setMockGeolocationError +# https://bugs.webkit.org/show_bug.cgi?id=59201 fast/dom/Geolocation/callback-exception.html fast/dom/Geolocation/callback-to-deleted-context.html fast/dom/Geolocation/callback-to-remote-context.html @@ -553,7 +553,6 @@ fast/dom/Geolocation/error.html fast/dom/Geolocation/maximum-age.html fast/dom/Geolocation/multiple-requests.html -fast/dom/Geolocation/notimer-after-unload.html fast/dom/Geolocation/permission-denied-already-clear-watch.html fast/dom/Geolocation/permission-denied-already-error.html fast/dom/Geolocation/permission-denied-already-success.html @@ -563,20 +562,14 @@ fast/dom/Geolocation/reentrant-error.html fast/dom/Geolocation/reentrant-permission-denied.html fast/dom/Geolocation/reentrant-success.html -fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html fast/dom/Geolocation/success.html fast/dom/Geolocation/timeout.html +fast/dom/Geolocation/timeout-clear-watch.html +fast/dom/Geolocation/timeout-zero.html fast/dom/Geolocation/timestamp.html fast/dom/Geolocation/watch.html fast/dom/Geolocation/window-close-crash.html -# WebKitTestRunner needs layoutTestController.setMockGeolocationPosition -# and layoutTestController.setMockGeolocationError -# https://bugs.webkit.org/show_bug.cgi?id=59201 -fast/dom/Geolocation/timeout-clear-watch.html -fast/dom/Geolocation/timeout-zero.html - - # WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate # https://bugs.webkit.org/show_bug.cgi?id=42546 fast/loader/_javascript_-url-hierarchical-execution.html @@ -1303,7 +1296,9 @@ # Sporadically fails in WebKit2 for unknown reasons.
[webkit-changes] [105989] trunk/LayoutTests
Title: [105989] trunk/LayoutTests
Revision 105989
Author ant...@chromium.org
Date 2012-01-26 04:17:39 -0800 (Thu, 26 Jan 2012)
Log Message
Unreviewed rebaseline after http://trac.webkit.org/changeset/105977.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
* platform/chromium/svg/W3C-SVG-1.1-SE: Added.
* platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
* platform/chromium/svg/stroke: Added.
* platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
* platform/gtk/svg/stroke: Removed.
* platform/gtk/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
* platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
* svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
* svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/
trunk/LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt
trunk/LayoutTests/platform/chromium/svg/stroke/
trunk/LayoutTests/platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png
trunk/LayoutTests/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt
trunk/LayoutTests/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png
trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt
trunk/LayoutTests/platform/gtk/svg/stroke/
trunk/LayoutTests/platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (105988 => 105989)
--- trunk/LayoutTests/ChangeLog 2012-01-26 12:16:25 UTC (rev 105988)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 12:17:39 UTC (rev 105989)
@@ -1,3 +1,23 @@
+2012-01-26 Anton Muhin ant...@chromium.org
+
+Unreviewed rebaseline after http://trac.webkit.org/changeset/105977.
+
+* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
+* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
+* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
+* platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Removed.
+* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
+* platform/chromium/svg/W3C-SVG-1.1-SE: Added.
+* platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
+* platform/chromium/svg/stroke: Added.
+* platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
+* platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
+* platform/gtk/svg/stroke: Removed.
+* platform/gtk/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
+* platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
+* svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
+* svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
+
2012-01-26 Nándor Huszka huszka.nan...@stud.u-szeged.hu
[WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
Added: trunk/LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt (0 => 105989)
--- trunk/LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt 2012-01-26 12:17:39 UTC (rev 105989)
@@ -0,0 +1,17 @@
+layer at (0,0) size 480x360
+ RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+ RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (148,48) size 196x96
+ RenderSVGPath {path} at (0,0) size 0x0
[webkit-changes] [105990] trunk/Source/WebKit2
Title: [105990] trunk/Source/WebKit2 Revision 105990 Author commit-qu...@webkit.org Date 2012-01-26 04:18:59 -0800 (Thu, 26 Jan 2012) Log Message [Qt] Fixed build when using force_static_libs_as_shared https://bugs.webkit.org/attachment.cgi?bugid=77082 Patch by Thiago Marcos P. Santos tmpsan...@gmail.com on 2012-01-26 Reviewed by Simon Hausmann. * Target.pri: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Target.pri Diff Modified: trunk/Source/WebKit2/ChangeLog (105989 => 105990) --- trunk/Source/WebKit2/ChangeLog 2012-01-26 12:17:39 UTC (rev 105989) +++ trunk/Source/WebKit2/ChangeLog 2012-01-26 12:18:59 UTC (rev 105990) @@ -1,3 +1,12 @@ +2012-01-26 Thiago Marcos P. Santos tmpsan...@gmail.com + +[Qt] Fixed build when using force_static_libs_as_shared +https://bugs.webkit.org/attachment.cgi?bugid=77082 + +Reviewed by Simon Hausmann. + +* Target.pri: + 2012-01-26 Nándor Huszka huszka.nan...@stud.u-szeged.hu [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission Modified: trunk/Source/WebKit2/Target.pri (105989 => 105990) --- trunk/Source/WebKit2/Target.pri 2012-01-26 12:17:39 UTC (rev 105989) +++ trunk/Source/WebKit2/Target.pri 2012-01-26 12:18:59 UTC (rev 105990) @@ -12,7 +12,7 @@ include(WebKit2.pri) WEBKIT += wtf _javascript_core webcore -QT += declarative widgets +QT += declarative quick widgets CONFIG += staticlib ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105991] trunk/Source/WebKit2
Title: [105991] trunk/Source/WebKit2
Revision 105991
Author zeno.albis...@nokia.com
Date 2012-01-26 04:28:03 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt][WK2] Use QVariant for payload data in application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=77007
Make application schemes use QVariant for payload data.
This allows passing QByteArrays as well as simple String data.
Remove unneeded http header parts that were exposed in
QQuickNetworkReply.
Add ByteArrayTestData class to allow injecting QByteArray
data into an application scheme handler for testing.
Reviewed by Simon Hausmann.
* Shared/qt/QtNetworkReplyData.cpp:
(WebKit::QtNetworkReplyData::QtNetworkReplyData):
(WebKit::QtNetworkReplyData::encode):
(WebKit::QtNetworkReplyData::decode):
* Shared/qt/QtNetworkReplyData.h:
* UIProcess/API/qt/qquicknetworkreply.cpp:
(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):
* UIProcess/API/qt/qquicknetworkreply_p.h:
* UIProcess/API/qt/tests/bytearraytestdata.cpp: Added.
(ByteArrayTestData::ByteArrayTestData):
(ByteArrayTestData::latin1Data):
(ByteArrayTestData::utf8Data):
* UIProcess/API/qt/tests/bytearraytestdata.h: Added.
* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
* UIProcess/API/qt/tests/tests.pri:
* WebProcess/qt/QtNetworkReply.cpp:
(WebKit::QtNetworkReply::setReplyData):
* WebProcess/qt/QtNetworkReply.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/qt/QtNetworkReplyData.cpp
trunk/Source/WebKit2/Shared/qt/QtNetworkReplyData.h
trunk/Source/WebKit2/UIProcess/API/qt/qquicknetworkreply.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquicknetworkreply_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp
trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri
trunk/Source/WebKit2/WebProcess/qt/QtNetworkReply.cpp
trunk/Source/WebKit2/WebProcess/qt/QtNetworkReply.h
Added Paths
trunk/Source/WebKit2/UIProcess/API/qt/tests/bytearraytestdata.cpp
trunk/Source/WebKit2/UIProcess/API/qt/tests/bytearraytestdata.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (105990 => 105991)
--- trunk/Source/WebKit2/ChangeLog 2012-01-26 12:18:59 UTC (rev 105990)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-26 12:28:03 UTC (rev 105991)
@@ -1,3 +1,43 @@
+2012-01-26 Zeno Albisser z...@webkit.org
+
+[Qt][WK2] Use QVariant for payload data in application URL schemes.
+https://bugs.webkit.org/show_bug.cgi?id=77007
+
+Make application schemes use QVariant for payload data.
+This allows passing QByteArrays as well as simple String data.
+
+Remove unneeded http header parts that were exposed in
+QQuickNetworkReply.
+
+Add ByteArrayTestData class to allow injecting QByteArray
+data into an application scheme handler for testing.
+
+Reviewed by Simon Hausmann.
+
+* Shared/qt/QtNetworkReplyData.cpp:
+(WebKit::QtNetworkReplyData::QtNetworkReplyData):
+(WebKit::QtNetworkReplyData::encode):
+(WebKit::QtNetworkReplyData::decode):
+* Shared/qt/QtNetworkReplyData.h:
+* UIProcess/API/qt/qquicknetworkreply.cpp:
+(QQuickNetworkReply::QQuickNetworkReply):
+(QQuickNetworkReply::data):
+(QQuickNetworkReply::setData):
+(QQuickNetworkReply::send):
+* UIProcess/API/qt/qquicknetworkreply_p.h:
+* UIProcess/API/qt/tests/bytearraytestdata.cpp: Added.
+(ByteArrayTestData::ByteArrayTestData):
+(ByteArrayTestData::latin1Data):
+(ByteArrayTestData::utf8Data):
+* UIProcess/API/qt/tests/bytearraytestdata.h: Added.
+* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
+* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
+(main):
+* UIProcess/API/qt/tests/tests.pri:
+* WebProcess/qt/QtNetworkReply.cpp:
+(WebKit::QtNetworkReply::setReplyData):
+* WebProcess/qt/QtNetworkReply.h:
+
2012-01-26 Thiago Marcos P. Santos tmpsan...@gmail.com
[Qt] Fixed build when using force_static_libs_as_shared
Modified: trunk/Source/WebKit2/Shared/qt/QtNetworkReplyData.cpp (105990 => 105991)
--- trunk/Source/WebKit2/Shared/qt/QtNetworkReplyData.cpp 2012-01-26 12:18:59 UTC (rev 105990)
+++ trunk/Source/WebKit2/Shared/qt/QtNetworkReplyData.cpp 2012-01-26 12:28:03 UTC (rev 105991)
@@ -39,21 +39,13 @@
QtNetworkReplyData::QtNetworkReplyData()
: m_contentLength(0)
-, m_lastModified(0)
{ }
void QtNetworkReplyData::encode(CoreIPC::ArgumentEncoder* encoder) const
{
encoder-encode(m_urlString);
-encoder-encodeEnum(m_operation);
-encoder-encode(m_contentDisposition);
encoder-encode(m_contentType);
encoder-encodeUInt64(m_contentLength);
-encoder-encode(m_location);
-
[webkit-changes] [105992] trunk/LayoutTests
Title: [105992] trunk/LayoutTests
Revision 105992
Author zimmerm...@webkit.org
Date 2012-01-26 04:42:06 -0800 (Thu, 26 Jan 2012)
Log Message
svg/webarchive tests are flakey under guard malloc
https://bugs.webkit.org/show_bug.cgi?id=77092
Reviewed by Zoltan Herczeg.
Fix flakey tests, by moving the script that dumps the test as webarchive, after the actual content.
* svg/webarchive/svg-cursor-subresources-expected.webarchive:
* svg/webarchive/svg-cursor-subresources.svg:
* svg/webarchive/svg-feimage-subresources-expected.webarchive:
* svg/webarchive/svg-feimage-subresources.svg:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/webarchive/svg-cursor-subresources-expected.webarchive
trunk/LayoutTests/svg/webarchive/svg-cursor-subresources.svg
trunk/LayoutTests/svg/webarchive/svg-feimage-subresources-expected.webarchive
trunk/LayoutTests/svg/webarchive/svg-feimage-subresources.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (105991 => 105992)
--- trunk/LayoutTests/ChangeLog 2012-01-26 12:28:03 UTC (rev 105991)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 12:42:06 UTC (rev 105992)
@@ -1,3 +1,17 @@
+2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
+
+svg/webarchive tests are flakey under guard malloc
+https://bugs.webkit.org/show_bug.cgi?id=77092
+
+Reviewed by Zoltan Herczeg.
+
+Fix flakey tests, by moving the script that dumps the test as webarchive, after the actual content.
+
+* svg/webarchive/svg-cursor-subresources-expected.webarchive:
+* svg/webarchive/svg-cursor-subresources.svg:
+* svg/webarchive/svg-feimage-subresources-expected.webarchive:
+* svg/webarchive/svg-feimage-subresources.svg:
+
2012-01-26 Anton Muhin ant...@chromium.org
Unreviewed rebaseline after http://trac.webkit.org/changeset/105977.
Modified: trunk/LayoutTests/svg/webarchive/svg-cursor-subresources-expected.webarchive (105991 => 105992)
--- trunk/LayoutTests/svg/webarchive/svg-cursor-subresources-expected.webarchive 2012-01-26 12:28:03 UTC (rev 105991)
+++ trunk/LayoutTests/svg/webarchive/svg-cursor-subresources-expected.webarchive 2012-01-26 12:42:06 UTC (rev 105992)
@@ -6,14 +6,20 @@
dict
keyWebResourceData/key
stringlt;svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlinkgt;
- lt;scriptgt;
-if (window.layoutTestController)
-layoutTestController.dumpDOMAsWebArchive();
- lt;/scriptgt;
lt;cursor id=mycursor xlink:href=""
lt;rect style=cursor: url(#mycursor) width=100 height=100 fill=white stroke=blue/gt;
lt;text x=10 y=130gt;Hover over the rect, you should see a (large) custom cursorlt;/textgt;
+ lt;scriptgt;
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+
+setTimeout(function() {
+layoutTestController.dumpDOMAsWebArchive();
+layoutTestController.notifyDone();
+}, 0);
+}
+ lt;/scriptgt;
lt;/svggt;/string
keyWebResourceFrameName/key
string/string
Modified: trunk/LayoutTests/svg/webarchive/svg-cursor-subresources.svg (105991 => 105992)
--- trunk/LayoutTests/svg/webarchive/svg-cursor-subresources.svg 2012-01-26 12:28:03 UTC (rev 105991)
+++ trunk/LayoutTests/svg/webarchive/svg-cursor-subresources.svg 2012-01-26 12:42:06 UTC (rev 105992)
@@ -1,10 +1,16 @@
svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
- script
-if (window.layoutTestController)
-layoutTestController.dumpDOMAsWebArchive();
- /script
cursor id=mycursor xlink:href="" /
rect style=cursor: url(#mycursor) width=100 height=100 fill=white stroke=blue /
text x=10 y=130Hover over the rect, you should see a (large) custom cursor/text
+ script
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+
+setTimeout(function() {
+layoutTestController.dumpDOMAsWebArchive();
+layoutTestController.notifyDone();
+}, 0);
+}
+ /script
/svg
Modified: trunk/LayoutTests/svg/webarchive/svg-feimage-subresources-expected.webarchive (105991 => 105992)
--- trunk/LayoutTests/svg/webarchive/svg-feimage-subresources-expected.webarchive 2012-01-26 12:28:03 UTC (rev 105991)
+++ trunk/LayoutTests/svg/webarchive/svg-feimage-subresources-expected.webarchive 2012-01-26 12:42:06 UTC (rev 105992)
@@ -6,14 +6,20 @@
dict
keyWebResourceData/key
stringlt;svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlinkgt;
- lt;scriptgt;
-if (window.layoutTestController)
-layoutTestController.dumpDOMAsWebArchive();
- lt;/scriptgt;
lt;filter id=MyFiltergt;
lt;feImage xlink:href=""
lt;/filtergt;
lt;rect id=rect width=100 height=100 fill=red filter=url(#MyFilter)/gt;
+ lt;scriptgt;
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+
+setTimeout(function() {
+layoutTestController.dumpDOMAsWebArchive();
+
[webkit-changes] [105993] trunk/Source/JavaScriptCore
Title: [105993] trunk/Source/_javascript_Core
Revision 105993
Author o...@webkit.org
Date 2012-01-26 04:46:03 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt][Win] Speculative buildfix after r105970.
* _javascript_Core.pri: Link lgdi for DeleteObject() and DeleteDC().
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.pri
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (105992 => 105993)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 12:42:06 UTC (rev 105992)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 12:46:03 UTC (rev 105993)
@@ -1,3 +1,9 @@
+2012-01-26 Csaba Osztrogonác o...@webkit.org
+
+[Qt][Win] Speculative buildfix after r105970.
+
+* _javascript_Core.pri: Link lgdi for DeleteObject() and DeleteDC().
+
2012-01-26 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r105982.
Modified: trunk/Source/_javascript_Core/_javascript_Core.pri (105992 => 105993)
--- trunk/Source/_javascript_Core/_javascript_Core.pri 2012-01-26 12:42:06 UTC (rev 105992)
+++ trunk/Source/_javascript_Core/_javascript_Core.pri 2012-01-26 12:46:03 UTC (rev 105993)
@@ -31,6 +31,7 @@
win32-* {
DEFINES += _HAS_TR1=0
LIBS += -lwinmm
+LIBS += -lgdi32
win32-g++* {
LIBS += -lpthreadGC2
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105994] trunk/Source/WebCore
Title: [105994] trunk/Source/WebCore Revision 105994 Author zimmerm...@webkit.org Date 2012-01-26 04:58:00 -0800 (Thu, 26 Jan 2012) Log Message 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Fix mac build after r105988. * WebCore.exp.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (105993 => 105994) --- trunk/Source/WebCore/ChangeLog 2012-01-26 12:46:03 UTC (rev 105993) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 12:58:00 UTC (rev 105994) @@ -1,3 +1,9 @@ +2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com + +Not reviewed. Fix mac build after r105988. + +* WebCore.exp.in: + 2012-01-26 Nándor Huszka huszka.nan...@stud.u-szeged.hu [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission Modified: trunk/Source/WebCore/WebCore.exp.in (105993 => 105994) --- trunk/Source/WebCore/WebCore.exp.in 2012-01-26 12:46:03 UTC (rev 105993) +++ trunk/Source/WebCore/WebCore.exp.in 2012-01-26 12:58:00 UTC (rev 105994) @@ -607,6 +607,7 @@ __ZN7WebCore20makeRGBA32FromFloatsE __ZN7WebCore20protocolIsJavaScriptERKN3WTF6StringE __ZN7WebCore21BackForwardController11itemAtIndexEi +__ZN7WebCore21GeolocationClientMock13setPermissionEb __ZN7WebCore21MemoryPressureHandler7installEv __ZN7WebCore21PlatformKeyboardEvent24disambiguateKeyDownEventENS_13PlatformEvent4TypeEb __ZN7WebCore21ResourceLoadScheduler20servePendingRequestsENS_20ResourceLoadPriorityE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105995] trunk/Source
Title: [105995] trunk/Source
Revision 105995
Author o...@webkit.org
Date 2012-01-26 05:43:26 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt][Win] One more speculative buildfix after r105970.
Source/_javascript_Core:
* _javascript_Core.pri:
Source/WTF:
* WTF.pri:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.pri
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pri
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (105994 => 105995)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 12:58:00 UTC (rev 105994)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 13:43:26 UTC (rev 105995)
@@ -1,5 +1,11 @@
2012-01-26 Csaba Osztrogonác o...@webkit.org
+[Qt][Win] One more speculative buildfix after r105970.
+
+* _javascript_Core.pri:
+
+2012-01-26 Csaba Osztrogonác o...@webkit.org
+
[Qt][Win] Speculative buildfix after r105970.
* _javascript_Core.pri: Link lgdi for DeleteObject() and DeleteDC().
Modified: trunk/Source/_javascript_Core/_javascript_Core.pri (105994 => 105995)
--- trunk/Source/_javascript_Core/_javascript_Core.pri 2012-01-26 12:58:00 UTC (rev 105994)
+++ trunk/Source/_javascript_Core/_javascript_Core.pri 2012-01-26 13:43:26 UTC (rev 105995)
@@ -31,7 +31,6 @@
win32-* {
DEFINES += _HAS_TR1=0
LIBS += -lwinmm
-LIBS += -lgdi32
win32-g++* {
LIBS += -lpthreadGC2
Modified: trunk/Source/WTF/ChangeLog (105994 => 105995)
--- trunk/Source/WTF/ChangeLog 2012-01-26 12:58:00 UTC (rev 105994)
+++ trunk/Source/WTF/ChangeLog 2012-01-26 13:43:26 UTC (rev 105995)
@@ -1,3 +1,9 @@
+2012-01-26 Csaba Osztrogonác o...@webkit.org
+
+[Qt][Win] One more speculative buildfix after r105970.
+
+* WTF.pri:
+
2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Try to fix Qt/Win build by building OwnPtrWin.cpp into the WTF library.
Modified: trunk/Source/WTF/WTF.pri (105994 => 105995)
--- trunk/Source/WTF/WTF.pri 2012-01-26 12:58:00 UTC (rev 105994)
+++ trunk/Source/WTF/WTF.pri 2012-01-26 13:43:26 UTC (rev 105995)
@@ -40,4 +40,7 @@
}
}
-win32-*: LIBS += -lwinmm
+win32-* {
+LIBS += -lwinmm
+LIBS += -lgdi32
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105996] trunk/Source/WebKit/efl
Title: [105996] trunk/Source/WebKit/efl
Revision 105996
Author commit-qu...@webkit.org
Date 2012-01-26 05:53:13 -0800 (Thu, 26 Jan 2012)
Log Message
[EFL] Added missing NETSCAPE_PLUGIN_API macro.
https://bugs.webkit.org/show_bug.cgi?id=77093
Patch by Tomasz Morawski t.moraw...@samsung.com on 2012-01-26
Reviewed by Andreas Kling.
The ewk_view_js_window_object_clear function should be inside ENABLE(NETSCAPE_PLUGIN_API) macro.
* ewk/ewk_view.cpp:
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (105995 => 105996)
--- trunk/Source/WebKit/efl/ChangeLog 2012-01-26 13:43:26 UTC (rev 105995)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-01-26 13:53:13 UTC (rev 105996)
@@ -1,3 +1,14 @@
+2012-01-26 Tomasz Morawski t.moraw...@samsung.com
+
+[EFL] Added missing NETSCAPE_PLUGIN_API macro.
+https://bugs.webkit.org/show_bug.cgi?id=77093
+
+Reviewed by Andreas Kling.
+
+The ewk_view_js_window_object_clear function should be inside ENABLE(NETSCAPE_PLUGIN_API) macro.
+
+* ewk/ewk_view.cpp:
+
2012-01-17 Gyuyoung Kim gyuyoung@samsung.com
[EFL] Use static const insted of #define macro.
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (105995 => 105996)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-01-26 13:43:26 UTC (rev 105995)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-01-26 13:53:13 UTC (rev 105996)
@@ -3534,6 +3534,7 @@
evas_object_smart_callback_call(ewkView, download,request, download);
}
+#if ENABLE(NETSCAPE_PLUGIN_API)
/**
* @internal
* Reports the JS window object was cleared.
@@ -3545,6 +3546,7 @@
{
evas_object_smart_callback_call(ewkView, js,windowobject,clear, frame);
}
+#endif
/**
* @internal
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105997] trunk
Title: [105997] trunk Revision 105997 Author commit-qu...@webkit.org Date 2012-01-26 06:07:36 -0800 (Thu, 26 Jan 2012) Log Message [Qt] Use ICU if available https://bugs.webkit.org/show_bug.cgi?id=76821 Patch by Jesus Sanchez-Palencia jesus.palen...@openbossa.org on 2012-01-26 Reviewed by Simon Hausmann. Source/WebCore: Adding correct sources to a Qt 5 based build. No new tests, it's just a build dependency change. * Target.pri: Source/WTF: Adding libicu dependencies for a Qt5 based build. * WTF.pri: Tools: Adding unicode defines for a Qt 5 based build. * qmake/mkspecs/features/features.prf: LayoutTests: Unskipping ICU related tests for Qt 5 and skipping for Qt 4. * platform/qt-4.8/Skipped: * platform/qt-arm/Skipped: * platform/qt-wk2/Skipped: * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-4.8/Skipped trunk/LayoutTests/platform/qt-arm/Skipped trunk/LayoutTests/platform/qt-wk2/Skipped trunk/Source/WTF/ChangeLog trunk/Source/WTF/WTF.pri trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri trunk/Tools/ChangeLog trunk/Tools/qmake/mkspecs/features/features.prf Diff Modified: trunk/LayoutTests/ChangeLog (105996 => 105997) --- trunk/LayoutTests/ChangeLog 2012-01-26 13:53:13 UTC (rev 105996) +++ trunk/LayoutTests/ChangeLog 2012-01-26 14:07:36 UTC (rev 105997) @@ -1,3 +1,18 @@ +2012-01-26 Jesus Sanchez-Palencia jesus.palen...@openbossa.org + +[Qt] Use ICU if available +https://bugs.webkit.org/show_bug.cgi?id=76821 + +Reviewed by Simon Hausmann. + +Unskipping ICU related tests for Qt 5 and skipping for +Qt 4. + +* platform/qt-4.8/Skipped: +* platform/qt-arm/Skipped: +* platform/qt-wk2/Skipped: +* platform/qt/Skipped: + 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com svg/webarchive tests are flakey under guard malloc Modified: trunk/LayoutTests/platform/qt/Skipped (105996 => 105997) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-26 13:53:13 UTC (rev 105996) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-26 14:07:36 UTC (rev 105997) @@ -670,10 +670,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=62821 editing/selection/move-vertically-with-paddings-borders.html -# [Qt] editing/selection/collapse-selection-in-bidi.html fails -# https://bugs.webkit.org/show_bug.cgi?id=66431 -editing/selection/collapse-selection-in-bidi.html - # editing/selection/select-bidi-run.html fails on Qt # https://bugs.webkit.org/show_bug.cgi?id=68854 editing/selection/select-bidi-run.html @@ -684,13 +680,8 @@ # REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and modify-up-on-rtl-wrapping-text.html fail on all but Mac platform # https://bugs.webkit.org/show_bug.cgi?id=50204 -editing/selection/click-left-of-rtl-wrapping-text.html editing/selection/modify-up-on-rtl-wrapping-text.html -# REGRESSION(r74971): [Qt] /editing/selection/caret-bidi-first-and-last-letters.html fails -# https://bugs.webkit.org/show_bug.cgi?id=51884 -editing/selection/caret-bidi-first-and-last-letters.html - # [Qt]REGRESSION(r78846): editing/selection/mixed-editability-10.html # https://bugs.webkit.org/show_bug.cgi?id=54725 editing/selection/mixed-editability-10.html @@ -703,10 +694,6 @@ editing/selection/move-by-word-visually-single-space-one-element.html editing/selection/move-by-word-visually-inline-block-positioned-element.html -# [Qt] editing/selection/caret-at-bidi-boundary.html fails -# https://bugs.webkit.org/show_bug.cgi?id=66514 -editing/selection/caret-at-bidi-boundary.html - # = # # Failing editing/spelling tests # = # @@ -780,26 +767,8 @@ sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html -sputnik/Unicode/Unicode_500/S7.6_A3.1.html -sputnik/Unicode/Unicode_500/S7.6_A3.2.html -sputnik/Unicode/Unicode_500/S7.6_A5.3_T1.html -sputnik/Unicode/Unicode_500/S7.6_A5.3_T2.html -sputnik/Unicode/Unicode_510/S15.5.4.16_A1.html -sputnik/Unicode/Unicode_510/S15.5.4.18_A1.html -sputnik/Unicode/Unicode_510/S7.6_A1.1_T1.html -sputnik/Unicode/Unicode_510/S7.6_A1.1_T2.html -sputnik/Unicode/Unicode_510/S7.6_A1.1_T4.html -sputnik/Unicode/Unicode_510/S7.6_A2.2_T1.html -sputnik/Unicode/Unicode_510/S7.6_A2.2_T2.html -sputnik/Unicode/Unicode_510/S7.6_A2.3.html sputnik/Unicode/Unicode_510/S7.6_A3.1.html sputnik/Unicode/Unicode_510/S7.6_A3.2.html -sputnik/Unicode/Unicode_510/S7.6_A5.2_T1.html -sputnik/Unicode/Unicode_510/S7.6_A5.2_T2.html -sputnik/Unicode/Unicode_510/S7.6_A5.2_T4.html -sputnik/Unicode/Unicode_510/S7.6_A5.2_T7.html -sputnik/Unicode/Unicode_510/S7.6_A5.2_T8.html
[webkit-changes] [105998] trunk/LayoutTests
Title: [105998] trunk/LayoutTests Revision 105998 Author ant...@chromium.org Date 2012-01-26 06:14:40 -0800 (Thu, 26 Jan 2012) Log Message Another unreviewed rebaseline. * platform/chromium-mac-snowleopard/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/clip-path/clip-path-tspan-and-stroke-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (105997 => 105998) --- trunk/LayoutTests/ChangeLog 2012-01-26 14:07:36 UTC (rev 105997) +++ trunk/LayoutTests/ChangeLog 2012-01-26 14:14:40 UTC (rev 105998) @@ -1,3 +1,9 @@ +2012-01-26 Anton Muhin ant...@chromium.org + +Another unreviewed rebaseline. + +* platform/chromium-mac-snowleopard/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added. + 2012-01-26 Jesus Sanchez-Palencia jesus.palen...@openbossa.org [Qt] Use ICU if available Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/clip-path/clip-path-tspan-and-stroke-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/clip-path/clip-path-tspan-and-stroke-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105999] trunk/Source/WebCore
Title: [105999] trunk/Source/WebCore
Revision 105999
Author kl...@webkit.org
Date 2012-01-26 06:56:34 -0800 (Thu, 26 Jan 2012)
Log Message
Make elements that don't have attributes smaller.
http://webkit.org/b/76876
Reviewed by Antti Koivisto.
Move the inline style declaration from StyledElement to NamedNodeMap, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.
This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at http://whatwg.org/c.
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
(WebCore::NamedNodeMap::createInlineStyleDecl):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::inlineStyleDecl):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::addSubresourceAttributeURLs):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/NamedNodeMap.cpp
trunk/Source/WebCore/dom/NamedNodeMap.h
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/dom/StyledElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (105998 => 105999)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 14:14:40 UTC (rev 105998)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 14:56:34 UTC (rev 105999)
@@ -1,3 +1,31 @@
+2012-01-23 Andreas Kling awesomekl...@apple.com
+
+Make elements that don't have attributes smaller.
+http://webkit.org/b/76876
+
+Reviewed by Antti Koivisto.
+
+Move the inline style declaration from StyledElement to NamedNodeMap, since having
+an inline style declaration also implies having a style attribute on the element.
+This saves one CPU word per element that has no attributes.
+
+This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
+HTML5 spec at http://whatwg.org/c.
+
+* dom/NamedNodeMap.cpp:
+(WebCore::NamedNodeMap::ensureInlineStyleDecl):
+(WebCore::NamedNodeMap::destroyInlineStyleDecl):
+(WebCore::NamedNodeMap::createInlineStyleDecl):
+* dom/NamedNodeMap.h:
+(WebCore::NamedNodeMap::inlineStyleDecl):
+* dom/StyledElement.cpp:
+(WebCore::StyledElement::updateStyleAttribute):
+(WebCore::StyledElement::addSubresourceAttributeURLs):
+* dom/StyledElement.h:
+(WebCore::StyledElement::inlineStyleDecl):
+(WebCore::StyledElement::ensureInlineStyleDecl):
+(WebCore::StyledElement::destroyInlineStyleDecl):
+
2012-01-26 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
[Qt] Use ICU if available
Modified: trunk/Source/WebCore/dom/NamedNodeMap.cpp (105998 => 105999)
--- trunk/Source/WebCore/dom/NamedNodeMap.cpp 2012-01-26 14:14:40 UTC (rev 105998)
+++ trunk/Source/WebCore/dom/NamedNodeMap.cpp 2012-01-26 14:56:34 UTC (rev 105999)
@@ -27,9 +27,9 @@
#include Attr.h
#include Document.h
-#include Element.h
#include ExceptionCode.h
#include HTMLNames.h
+#include StyledElement.h
namespace WebCore {
@@ -330,4 +330,27 @@
return true;
}
+CSSMutableStyleDeclaration* NamedNodeMap::ensureInlineStyleDecl()
+{
+if (!m_inlineStyleDecl)
+createInlineStyleDecl();
+return m_inlineStyleDecl.get();
+}
+
+void NamedNodeMap::destroyInlineStyleDecl()
+{
+if (!m_inlineStyleDecl)
+return;
+m_inlineStyleDecl-clearParentElement();
+m_inlineStyleDecl = 0;
+}
+
+void NamedNodeMap::createInlineStyleDecl()
+{
+ASSERT(!m_inlineStyleDecl);
+ASSERT(m_element-isStyledElement());
+m_inlineStyleDecl = CSSMutableStyleDeclaration::createInline(static_castStyledElement*(m_element));
+m_inlineStyleDecl-setStrictParsing(m_element-isHTMLElement() !m_element-document()-inQuirksMode());
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/NamedNodeMap.h (105998 => 105999)
--- trunk/Source/WebCore/dom/NamedNodeMap.h 2012-01-26 14:14:40 UTC (rev 105998)
+++ trunk/Source/WebCore/dom/NamedNodeMap.h 2012-01-26 14:56:34 UTC (rev 105999)
@@ -102,6 +102,10 @@
size_t mappedAttributeCount() const;
+CSSMutableStyleDeclaration* inlineStyleDecl() const { return m_inlineStyleDecl.get(); }
+CSSMutableStyleDeclaration* ensureInlineStyleDecl();
+void destroyInlineStyleDecl();
+
private:
NamedNodeMap(Element* element)
: m_element(element)
@@ -116,11 +120,16 @@
void setAttributes(const NamedNodeMap);
void clearAttributes();
void replaceAttribute(size_t index, PassRefPtrAttribute);
+void createInlineStyleDecl();
+// FIXME: NamedNodeMap should be broken up into two classes, one containing data
+//for elements with attributes, and one for exposure to the DOM.
+//
[webkit-changes] [106000] trunk/Source/WebKit2
Title: [106000] trunk/Source/WebKit2
Revision 106000
Author carlo...@webkit.org
Date 2012-01-26 07:03:50 -0800 (Thu, 26 Jan 2012)
Log Message
[GTK][WK2] Primary clipboard should be updated with the current selection in X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=77097
Reviewed by Martin Robinson.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection): Call
setSelectionPrimaryClipboardIfNeeded() to update primary clipboard
in X11 platforms.
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::collapseSelection): Callback called when clearing
clipboard contents.
(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):
Updaye primary clipboard with the current selection.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (105999 => 106000)
--- trunk/Source/WebKit2/ChangeLog 2012-01-26 14:56:34 UTC (rev 105999)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-26 15:03:50 UTC (rev 106000)
@@ -1,3 +1,21 @@
+2012-01-26 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK][WK2] Primary clipboard should be updated with the current selection in X11 platforms
+https://bugs.webkit.org/show_bug.cgi?id=77097
+
+Reviewed by Martin Robinson.
+
+* WebProcess/WebCoreSupport/WebEditorClient.cpp:
+(WebKit::WebEditorClient::respondToChangedSelection): Call
+setSelectionPrimaryClipboardIfNeeded() to update primary clipboard
+in X11 platforms.
+* WebProcess/WebCoreSupport/WebEditorClient.h:
+* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
+(WebKit::collapseSelection): Callback called when clearing
+clipboard contents.
+(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):
+Updaye primary clipboard with the current selection.
+
2012-01-26 Zeno Albisser z...@webkit.org
[Qt][WK2] Use QVariant for payload data in application URL schemes.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (105999 => 106000)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2012-01-26 14:56:34 UTC (rev 105999)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2012-01-26 15:03:50 UTC (rev 106000)
@@ -195,9 +195,11 @@
unsigned start;
unsigned end;
m_page-send(Messages::WebPageProxy::DidChangeCompositionSelection(frame-editor()-getCompositionSelection(start, end)));
+#elif PLATFORM(GTK)
+setSelectionPrimaryClipboardIfNeeded(frame);
#endif
}
-
+
void WebEditorClient::didEndEditing()
{
DEFINE_STATIC_LOCAL(String, WebViewDidEndEditingNotification, (WebViewDidEndEditingNotification));
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h (105999 => 106000)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2012-01-26 14:56:34 UTC (rev 105999)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2012-01-26 15:03:50 UTC (rev 106000)
@@ -121,6 +121,7 @@
#if PLATFORM(GTK)
bool executePendingEditorCommands(WebCore::Frame*, VectorWTF::String, bool) OVERRIDE;
void getEditorCommandsForKeyEvent(const WebCore::KeyboardEvent*, VectorWTF::String) OVERRIDE;
+void setSelectionPrimaryClipboardIfNeeded(WebCore::Frame*) OVERRIDE;
#endif
TextCheckerClient* textChecker() OVERRIDE { return this; }
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp (105999 => 106000)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp 2012-01-26 14:56:34 UTC (rev 105999)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp 2012-01-26 15:03:50 UTC (rev 106000)
@@ -25,7 +25,9 @@
#include WebPage.h
#include WebPageProxyMessages.h
#include WebProcess.h
+#include WebCore/DataObjectGtk.h
#include WebCore/KeyboardEvent.h
+#include WebCore/PasteboardHelper.h
#include WebCore/NotImplemented.h
using namespace WebCore;
@@ -127,4 +129,38 @@
notImplemented();
}
+#if PLATFORM(X11)
+static Frame* frameSettingClipboard;
+static void collapseSelection(GtkClipboard* clipboard, Frame* frame)
+{
+if (frameSettingClipboard frameSettingClipboard == frame)
+return;
+
+// Collapse the selection without clearing it.
+ASSERT(frame);
+frame-selection()-setBase(frame-selection()-extent(), frame-selection()-affinity());
}
+#endif
+
+void WebEditorClient::setSelectionPrimaryClipboardIfNeeded(Frame* frame)
+{
+#if PLATFORM(X11)
+GtkClipboard* clipboard = PasteboardHelper::defaultPasteboardHelper()-getPrimarySelectionClipboard(frame);
+DataObjectGtk* dataObject =
[webkit-changes] [106001] trunk
Title: [106001] trunk
Revision 106001
Author zimmerm...@webkit.org
Date 2012-01-26 07:04:55 -0800 (Thu, 26 Jan 2012)
Log Message
SVG + object tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=77099
Reviewed by Andreas Kling.
Source/WebCore:
Bug 76447 changed the way RenderSVGRoot figures out its size. Previously RenderSVGRoot directly called out to the
ownerRenderer (RenderEmbeddedObject) to compute its replaced size when embedded through eg. object element,
which was quite hacky. It now relies on the ownerRenderers availableLogicalWidth/Height to be correctly set,
which requires that the ownerRenderer is always laid out before the RenderSVGRoot and not the other way round.
This is the source of current flakiness bugs.
In trunk FrameView contains several special hacks, to layout the ownerRenderers view, after the RenderSVGRoots view
finished layout. This worked without flakiness as RenderSVGRoot used to directly call computeReplacedLogicalWidth/Height
on the ownerRenderer, which is now gone. Fortunately we can keep the new design, and can remove all hacks out of
RenderSVGRoot/FrameView, if we can guarantee that the ownerRenderer FrameView is laid out before the RenderSVGRoot FrameView.
This is a much less error-prone approach as the previous one. This lets us run nrwt --tolerance 0 -p svg -g again,
without 100% reproducable failing svg/wicd tests. (There's still one unrelated error, before guard malloc mode passes fully).
Test: svg/wicd/sizing-flakiness.html (Adjusted version of the rightsizing test, made to fail with trunk w/o this patch.)
* page/FrameView.cpp: Remove m_inLayoutParentView.
(WebCore::FrameView::FrameView): Remove no longer needed m_inLayoutParentView.
(WebCore::FrameView::forceLayoutParentViewIfNeeded): Simplify, no need to call updateWidgetPositions anymore, nor to clear/query flags in RenderSVGRoot.
(WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() before laying out the embedded document, to guarantee the correct order.
* page/FrameView.h:
(FrameView): Remove m_inLayoutParentView.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot): Remove m_needsSizeNegotiationWithHostDocument.
(WebCore::resolveLengthAttributeForSVG): Remove outcommented code, that went in by accident.
(WebCore::RenderSVGRoot::layout): Remove m_needsSizeNegotiationWithHostDocument handling which is now incorrect and no longer needed.
* rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot): Remove m_needsSizeNegotiationWithHostDocument + accessors.
LayoutTests:
Introduce a testcase that fails reproducibly w/o needed guard malloc, if we ever regress object sizing again.
* platform/mac/svg/wicd/sizing-flakiness-expected.png:
* platform/mac/svg/wicd/sizing-flakiness-expected.txt:
* svg/wicd/sizing-flakiness.html: Adjusted version of the rightsizing test, made to fail with trunk w/o this patch.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h
Added Paths
trunk/LayoutTests/platform/mac/svg/wicd/sizing-flakiness-expected.png
trunk/LayoutTests/platform/mac/svg/wicd/sizing-flakiness-expected.txt
trunk/LayoutTests/svg/wicd/sizing-flakiness.html
Diff
Modified: trunk/LayoutTests/ChangeLog (106000 => 106001)
--- trunk/LayoutTests/ChangeLog 2012-01-26 15:03:50 UTC (rev 106000)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 15:04:55 UTC (rev 106001)
@@ -1,3 +1,16 @@
+2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
+
+SVG + object tests are flakey
+https://bugs.webkit.org/show_bug.cgi?id=77099
+
+Reviewed by Andreas Kling.
+
+Introduce a testcase that fails reproducibly w/o needed guard malloc, if we ever regress object sizing again.
+
+* platform/mac/svg/wicd/sizing-flakiness-expected.png:
+* platform/mac/svg/wicd/sizing-flakiness-expected.txt:
+* svg/wicd/sizing-flakiness.html: Adjusted version of the rightsizing test, made to fail with trunk w/o this patch.
+
2012-01-26 Anton Muhin ant...@chromium.org
Another unreviewed rebaseline.
Added: trunk/LayoutTests/platform/mac/svg/wicd/sizing-flakiness-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/svg/wicd/sizing-flakiness-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/svg/wicd/sizing-flakiness-expected.txt (0 => 106001)
--- trunk/LayoutTests/platform/mac/svg/wicd/sizing-flakiness-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/svg/wicd/sizing-flakiness-expected.txt 2012-01-26 15:04:55 UTC (rev 106001)
@@ -0,0 +1,19 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x410
+ RenderBlock {HTML} at (0,0) size 800x410
+RenderBody {BODY}
[webkit-changes] [106002] trunk/LayoutTests
Title: [106002] trunk/LayoutTests Revision 106002 Author kbal...@webkit.org Date 2012-01-26 07:20:29 -0800 (Thu, 26 Jan 2012) Log Message [Qt][WK2] Still failing tests after moving to ICU https://bugs.webkit.org/show_bug.cgi?id=77102 Unreviewed gardening. * platform/qt-wk2/Skipped: Skip failing tests for now. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (106001 => 106002) --- trunk/LayoutTests/ChangeLog 2012-01-26 15:04:55 UTC (rev 106001) +++ trunk/LayoutTests/ChangeLog 2012-01-26 15:20:29 UTC (rev 106002) @@ -1,3 +1,12 @@ +2012-01-26 Balazs Kelemen kbal...@webkit.org + +[Qt][WK2] Still failing tests after moving to ICU +https://bugs.webkit.org/show_bug.cgi?id=77102 + +Unreviewed gardening. + +* platform/qt-wk2/Skipped: Skip failing tests for now. + 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com SVG + object tests are flakey Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (106001 => 106002) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-26 15:04:55 UTC (rev 106001) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-26 15:20:29 UTC (rev 106002) @@ -519,3 +519,15 @@ # [Qt][WK2] scrollbars/scroll-rtl-or-bt-layer.html fails # https://bugs.webkit.org/show_bug.cgi?id=76986 scrollbars/scroll-rtl-or-bt-layer.html + +# [Qt][WK2] Still failing tests after moving to ICU +# https://bugs.webkit.org/show_bug.cgi?id=77102 +css1/text_properties/text_transform.html +editing/execCommand/findString-diacriticals.html +editing/selection/caret-at-bidi-boundary.html +editing/selection/caret-bidi-first-and-last-letters.html +editing/selection/regional-indicators.html +fast/text/find-kana.html +fast/text/find-russian.html +fast/text/find-soft-hyphen.html +svg/as-background-image/background-image-preserveaspectRatio-support.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106003] trunk/Tools
Title: [106003] trunk/Tools
Revision 106003
Author commit-qu...@webkit.org
Date 2012-01-26 07:28:29 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt] The Qt MiniBrowser crashes when given multiple URL's
https://bugs.webkit.org/show_bug.cgi?id=77009
Patch by Alexander Færøy alexander.fae...@nokia.com on 2012-01-26
Reviewed by Simon Hausmann.
This patch fixes a crash in BrowserWindow::newWindow() where a
BrowserWindow-object is constructed with a 0 pointer as the
WindowOptions parameter which leads to a crash.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):
* MiniBrowser/qt/BrowserWindow.h:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/BrowserWindow.h
Diff
Modified: trunk/Tools/ChangeLog (106002 => 106003)
--- trunk/Tools/ChangeLog 2012-01-26 15:20:29 UTC (rev 106002)
+++ trunk/Tools/ChangeLog 2012-01-26 15:28:29 UTC (rev 106003)
@@ -1,3 +1,19 @@
+2012-01-26 Alexander Færøy alexander.fae...@nokia.com
+
+[Qt] The Qt MiniBrowser crashes when given multiple URL's
+https://bugs.webkit.org/show_bug.cgi?id=77009
+
+Reviewed by Simon Hausmann.
+
+This patch fixes a crash in BrowserWindow::newWindow() where a
+BrowserWindow-object is constructed with a 0 pointer as the
+WindowOptions parameter which leads to a crash.
+
+* MiniBrowser/qt/BrowserWindow.cpp:
+(BrowserWindow::BrowserWindow):
+(BrowserWindow::newWindow):
+* MiniBrowser/qt/BrowserWindow.h:
+
2012-01-26 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
[Qt] Use ICU if available
Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp (106002 => 106003)
--- trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2012-01-26 15:20:29 UTC (rev 106002)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp 2012-01-26 15:28:29 UTC (rev 106003)
@@ -37,6 +37,7 @@
#include QPointF
BrowserWindow::BrowserWindow(WindowOptions* options)
+: m_windowOptions(options)
{
setWindowTitle(MiniBrowser);
setWindowFlags(Qt::Window | Qt::WindowTitleHint | Qt::WindowMinMaxButtonsHint | Qt::WindowCloseButtonHint);
@@ -88,7 +89,7 @@
BrowserWindow* BrowserWindow::newWindow(const QString url)
{
-BrowserWindow* window = new BrowserWindow();
+BrowserWindow* window = new BrowserWindow(m_windowOptions);
window-load(url);
return window;
}
Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.h (106002 => 106003)
--- trunk/Tools/MiniBrowser/qt/BrowserWindow.h 2012-01-26 15:20:29 UTC (rev 106002)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.h 2012-01-26 15:28:29 UTC (rev 106003)
@@ -39,7 +39,7 @@
Q_OBJECT
public:
-BrowserWindow(WindowOptions* = 0);
+BrowserWindow(WindowOptions*);
~BrowserWindow();
void load(const QString url);
void reload();
@@ -56,6 +56,7 @@
private:
void updateUserAgentList();
+WindowOptions* m_windowOptions;
QStringList m_userAgentList;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106004] trunk/Tools
Title: [106004] trunk/Tools
Revision 106004
Author commit-qu...@webkit.org
Date 2012-01-26 08:07:53 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=77100
Patch by Alexander Færøy alexander.fae...@nokia.com on 2012-01-26
Reviewed by Simon Hausmann.
This patch makes the MiniBrowser read multiple URL's from the command
line such that there will be one browser window opened for each URL.
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp
Diff
Modified: trunk/Tools/ChangeLog (106003 => 106004)
--- trunk/Tools/ChangeLog 2012-01-26 15:28:29 UTC (rev 106003)
+++ trunk/Tools/ChangeLog 2012-01-26 16:07:53 UTC (rev 106004)
@@ -1,5 +1,18 @@
2012-01-26 Alexander Færøy alexander.fae...@nokia.com
+[Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=77100
+
+Reviewed by Simon Hausmann.
+
+This patch makes the MiniBrowser read multiple URL's from the command
+line such that there will be one browser window opened for each URL.
+
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::handleUserOptions):
+
+2012-01-26 Alexander Færøy alexander.fae...@nokia.com
+
[Qt] The Qt MiniBrowser crashes when given multiple URL's
https://bugs.webkit.org/show_bug.cgi?id=77009
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (106003 => 106004)
--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-01-26 15:28:29 UTC (rev 106003)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-01-26 16:07:53 UTC (rev 106004)
@@ -250,8 +250,9 @@
m_robotTimeoutSeconds = takeOptionValue(args, --robot-timeout).toInt();
m_robotExtraTimeSeconds = takeOptionValue(args, --robot-extra-time).toInt();
} else {
-int urlArg = args.indexOf(QRegExp(^[^-].*));
-if (urlArg != -1)
+int urlArg;
+
+while ((urlArg = args.indexOf(QRegExp(^[^-].*))) != -1)
m_urls += args.takeAt(urlArg);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106005] trunk
Title: [106005] trunk Revision 106005 Author caio.olive...@openbossa.org Date 2012-01-26 09:10:28 -0800 (Thu, 26 Jan 2012) Log Message Implement overridePreference for boolean preferences in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=77033 Reviewed by Alexey Proskuryakov. Source/WebKit2: Implement a way to WebKitTestRunner override preferences for the pages loaded. Follows the same approach taken by overrideXSSAuditorEnabledForTestRunner() from r66551, but generalizing to many preferences. Preferences are stored in the UI process using WebPreferencesStore, and when there's a change, this data is sent to Web process, triggering WebPage::preferencesDidChange(), which take a WebPreferencesStore and apply it's data to the WebCore::Settings object. The overridePreference() is executed on the Web process, and set the preferences without communicating to the UI process. The overriden preferences are stored in a static map and WebPreferencesStore query this map before returning the values of each preference. This static map is used only on the Web process. To clear the overrides we need to clear the map. Since WTR only sets preferences when resetting the page, we hook the clearing at WebPage::preferencesDidChange(). A WKPreferences private function was exposed to WTR force the update, in case there's no effective change at UI process (all the properties remains the same). This clearing could be improved by creating a proper message instead of hooking at WebPage::preferencesDidChange(). * Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::decode): (WebKit::WebPreferencesStore::overrideBoolValueForKey): (WebKit::WebPreferencesStore::removeTestRunnerOverrides): (WebKit::WebPreferencesStore::getBoolValueForKey): * Shared/WebPreferencesStore.h: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesResetTestRunnerOverrides): * UIProcess/API/C/WKPreferencesPrivate.h: * UIProcess/WebPreferences.h: (WebKit::WebPreferences::forceUpdate): * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleOverrideBoolPreferenceForTestRunner): * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): (WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner): * WebProcess/InjectedBundle/InjectedBundle.h: Tools: For now overridePreference supports boolean values. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled): (WTR::LayoutTestController::overridePreference): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Reset the overrides explicitly and properly disable the use of PageCache when resetting the state. Tests that use PageCache can now enable it via overridePreference. LayoutTests: * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPreferencesStore.cpp trunk/Source/WebKit2/Shared/WebPreferencesStore.h trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h trunk/Source/WebKit2/UIProcess/WebPreferences.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h trunk/Tools/WebKitTestRunner/TestController.cpp Diff Modified: trunk/LayoutTests/ChangeLog (106004 => 106005) --- trunk/LayoutTests/ChangeLog 2012-01-26 16:07:53 UTC (rev 106004) +++ trunk/LayoutTests/ChangeLog 2012-01-26 17:10:28 UTC (rev 106005) @@ -1,3 +1,12 @@ +2012-01-26 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org + +Implement overridePreference for boolean preferences in WebKitTestRunner +https://bugs.webkit.org/show_bug.cgi?id=77033 + +Reviewed by Alexey Proskuryakov. + +* platform/wk2/Skipped: + 2012-01-26 Balazs Kelemen kbal...@webkit.org [Qt][WK2] Still failing tests after moving to ICU Modified: trunk/LayoutTests/platform/wk2/Skipped (106004 => 106005) --- trunk/LayoutTests/platform/wk2/Skipped 2012-01-26 16:07:53 UTC (rev 106004) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-01-26 17:10:28 UTC (rev 106005) @@ -192,7 +192,6 @@ css3/filters/custom-filter.html fast/canvas/webgl/framebuffer-object-attachment.html fast/canvas/webgl/gl-vertex-attrib-zero-issues.html -fast/events/pagehide-timeout.html
[webkit-changes] [106006] trunk/LayoutTests
Title: [106006] trunk/LayoutTests Revision 106006 Author le...@chromium.org Date 2012-01-26 09:42:49 -0800 (Thu, 26 Jan 2012) Log Message Adding platform expectations after r105978. Unreviewed gardening. * platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png: Added. * platform/chromium-mac-snowleopard/svg/wicd/sizing-flakiness-expected.png: Added. * platform/chromium-win/svg/wicd/sizing-flakiness-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/wicd/sizing-flakiness-expected.png trunk/LayoutTests/platform/chromium-win/svg/wicd/sizing-flakiness-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (106005 => 106006) --- trunk/LayoutTests/ChangeLog 2012-01-26 17:10:28 UTC (rev 106005) +++ trunk/LayoutTests/ChangeLog 2012-01-26 17:42:49 UTC (rev 106006) @@ -1,3 +1,13 @@ +2012-01-26 Levi Weintraub le...@chromium.org + +Adding platform expectations after r105978. + +Unreviewed gardening. + +* platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png: Added. +* platform/chromium-mac-snowleopard/svg/wicd/sizing-flakiness-expected.png: Added. +* platform/chromium-win/svg/wicd/sizing-flakiness-expected.png: Added. + 2012-01-26 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org Implement overridePreference for boolean preferences in WebKitTestRunner Added: trunk/LayoutTests/platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/wicd/sizing-flakiness-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/wicd/sizing-flakiness-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/svg/wicd/sizing-flakiness-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/svg/wicd/sizing-flakiness-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106007] trunk/LayoutTests
Title: [106007] trunk/LayoutTests Revision 106007 Author le...@chromium.org Date 2012-01-26 09:52:50 -0800 (Thu, 26 Jan 2012) Log Message Layout Test accessibility/loading-iframe-sends-notification.html occasionally exceeds the Chromium Windows callstack https://bugs.webkit.org/show_bug.cgi?id=77110 Unreviewed gardening. Marking accessibility/loading-iframe-sends-notification.html as flaky on the Chromium Windows Debug bot. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106006 => 106007) --- trunk/LayoutTests/ChangeLog 2012-01-26 17:42:49 UTC (rev 106006) +++ trunk/LayoutTests/ChangeLog 2012-01-26 17:52:50 UTC (rev 106007) @@ -1,5 +1,15 @@ 2012-01-26 Levi Weintraub le...@chromium.org +Layout Test accessibility/loading-iframe-sends-notification.html occasionally exceeds the Chromium Windows callstack +https://bugs.webkit.org/show_bug.cgi?id=77110 + +Unreviewed gardening. Marking accessibility/loading-iframe-sends-notification.html as flaky on the Chromium +Windows Debug bot. + +* platform/chromium/test_expectations.txt: + +2012-01-26 Levi Weintraub le...@chromium.org + Adding platform expectations after r105978. Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106006 => 106007) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 17:42:49 UTC (rev 106006) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 17:52:50 UTC (rev 106007) @@ -3686,6 +3686,7 @@ BUGWK72990 WIN : accessibility/loading-iframe-updates-axtree.html = PASS TIMEOUT BUGWK72761 : accessibility/anonymous-render-block-in-continuation-causes-crash.html = PASS TIMEOUT +BUGWK77110 WIN DEBUG : accessibility/loading-iframe-sends-notification.html = PASS TEXT BUGWK72904 XP : http/tests/media/video-served-as-text.html = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106008] trunk/Source/WebKit2
Title: [106008] trunk/Source/WebKit2
Revision 106008
Author caio.olive...@openbossa.org
Date 2012-01-26 09:54:08 -0800 (Thu, 26 Jan 2012)
Log Message
WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
https://bugs.webkit.org/show_bug.cgi?id=77109
Reviewed by Andreas Kling.
Fix build for Clang.
* Shared/WebPreferencesStore.cpp:
(WebKit):
(WebKit::boolTestRunnerOverridesMap):
(WebKit::WebPreferencesStore::overrideBoolValueForKey):
(WebKit::WebPreferencesStore::removeTestRunnerOverrides):
(WebKit::WebPreferencesStore::getBoolValueForKey):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (106007 => 106008)
--- trunk/Source/WebKit2/ChangeLog 2012-01-26 17:52:50 UTC (rev 106007)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-26 17:54:08 UTC (rev 106008)
@@ -1,5 +1,21 @@
2012-01-26 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
+WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
+https://bugs.webkit.org/show_bug.cgi?id=77109
+
+Reviewed by Andreas Kling.
+
+Fix build for Clang.
+
+* Shared/WebPreferencesStore.cpp:
+(WebKit):
+(WebKit::boolTestRunnerOverridesMap):
+(WebKit::WebPreferencesStore::overrideBoolValueForKey):
+(WebKit::WebPreferencesStore::removeTestRunnerOverrides):
+(WebKit::WebPreferencesStore::getBoolValueForKey):
+
+2012-01-26 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
+
Implement overridePreference for boolean preferences in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77033
Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.cpp (106007 => 106008)
--- trunk/Source/WebKit2/Shared/WebPreferencesStore.cpp 2012-01-26 17:52:50 UTC (rev 106007)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.cpp 2012-01-26 17:54:08 UTC (rev 106008)
@@ -47,8 +47,13 @@
} // namespace WebPreferencesKey
+typedef HashMapString, bool BoolOverridesMap;
-static HashMapString, bool boolTestRunnerOverridesMap;
+static BoolOverridesMap boolTestRunnerOverridesMap()
+{
+DEFINE_STATIC_LOCAL(BoolOverridesMap, map, ());
+return map;
+}
WebPreferencesStore::WebPreferencesStore()
{
@@ -77,12 +82,12 @@
void WebPreferencesStore::overrideBoolValueForKey(const String key, bool value)
{
-boolTestRunnerOverridesMap.set(key, value);
+boolTestRunnerOverridesMap().set(key, value);
}
void WebPreferencesStore::removeTestRunnerOverrides()
{
-boolTestRunnerOverridesMap.clear();
+boolTestRunnerOverridesMap().clear();
}
@@ -180,8 +185,8 @@
bool WebPreferencesStore::getBoolValueForKey(const String key) const
{
// FIXME: Extend overriding to other key types used from LayoutTestController.
-HashMapString, bool::const_iterator it = boolTestRunnerOverridesMap.find(key);
-if (it != boolTestRunnerOverridesMap.end())
+BoolOverridesMap::const_iterator it = boolTestRunnerOverridesMap().find(key);
+if (it != boolTestRunnerOverridesMap().end())
return it-second;
return valueForKey(m_boolValues, key);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106009] branches/chromium/963
Title: [106009] branches/chromium/963
Revision 106009
Author infe...@chromium.org
Date 2012-01-26 10:41:54 -0800 (Thu, 26 Jan 2012)
Log Message
Merge 105978 - crash in WebCore::RenderSVGContainer::paint
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9235065
Modified Paths
branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt
branches/chromium/963/Source/WebCore/rendering/PaintPhase.h
branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp
branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceClipper.h
branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceMasker.h
branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp
branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp
branches/chromium/963/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp
branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
branches/chromium/963/Source/WebCore/rendering/svg/SVGRenderSupport.cpp
Added Paths
branches/chromium/963/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png
branches/chromium/963/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt
branches/chromium/963/LayoutTests/svg/clip-path/clip-path-tspan-and-stroke.svg
branches/chromium/963/LayoutTests/svg/custom/layout-loop-expected.txt
branches/chromium/963/LayoutTests/svg/custom/layout-loop.svg
Diff
Modified: branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt (106008 => 106009)
--- branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 17:54:08 UTC (rev 106008)
+++ branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 18:41:54 UTC (rev 106009)
@@ -4073,6 +4073,9 @@
BUGWK76800 : svg/filters/feImage-reference-invalidation.svg = IMAGE
BUGWK76800 : svg/filters/feImage-reference-svg-primitive.svg = IMAGE
+// Just needs a rebaseline.
+BUGWK69714 : svg/clip-path/clip-path-tspan-and-stroke.svg = IMAGE+TEXT
+
// Change error (misspelling) underlines from Windows look to Mac look.
BUG_CARYCLARK MAC : editing/deleting/delete-3928305-fix.html = IMAGE
BUG_CARYCLARK MAC : editing/deleting/delete-3959464-fix.html = IMAGE
Copied: branches/chromium/963/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png (from rev 105978, trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png)
(Binary files differ)
Copied: branches/chromium/963/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt (from rev 105978, trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt) (0 => 106009)
--- branches/chromium/963/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt (rev 0)
+++ branches/chromium/963/LayoutTests/platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt 2012-01-26 18:41:54 UTC (rev 106009)
@@ -0,0 +1,12 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderSVGRoot {svg} at (40,88) size 191x92
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+ RenderSVGResourceClipper {clipPath} [id=clip] [clipPathUnits=userSpaceOnUse]
+RenderSVGText {text} at (40,88) size 191x92 contains 1 chunk(s)
+ RenderSVGTSpan {tspan} at (0,0) size 191x92
+RenderSVGInlineText {#text} at (0,0) size 191x92
+ chunk 1 text run 1 at (40.00,160.00) startOffset 0 endOffset 4 width 191.00: CLIP
+RenderSVGRect {rect} at (40,88) size 191x92 [fill={[type=SOLID] [color=#008000]}] [x=40.00] [y=40.00] [width=300.00] [height=300.00]
+ [clipPath=clip] RenderSVGResourceClipper {clipPath} at (40,88) size 191x92
Copied: branches/chromium/963/LayoutTests/svg/clip-path/clip-path-tspan-and-stroke.svg (from rev 105978, trunk/LayoutTests/svg/clip-path/clip-path-tspan-and-stroke.svg) (0 => 106009)
--- branches/chromium/963/LayoutTests/svg/clip-path/clip-path-tspan-and-stroke.svg (rev 0)
+++ branches/chromium/963/LayoutTests/svg/clip-path/clip-path-tspan-and-stroke.svg 2012-01-26 18:41:54 UTC (rev 106009)
@@ -0,0 +1,9 @@
+svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+defs
+clipPath id=clip
+!-- fill and stroke properties should be ignored --
+text x=40 y=160 font-size=80 font-weight=boldtspan stroke=red fill=noneCLIP/tspan/text
+/clipPath
+/defs
+rect x=40 y=40 height=300 width=300 style=fill:green;clip-path:url(#clip);/
+/svg
Copied: branches/chromium/963/LayoutTests/svg/custom/layout-loop-expected.txt (from rev 105978, trunk/LayoutTests/svg/custom/layout-loop-expected.txt) (0 => 106009)
---
[webkit-changes] [106010] branches/chromium/963/Source/WebCore/rendering/svg/ SVGInlineTextBox.cpp
Title: [106010] branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
Revision 106010
Author infe...@chromium.org
Date 2012-01-26 10:42:50 -0800 (Thu, 26 Jan 2012)
Log Message
Merge 105983 - 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9288069
Modified Paths
branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
Diff
Modified: branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (106009 => 106010)
--- branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 18:41:54 UTC (rev 106009)
+++ branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 18:42:50 UTC (rev 106010)
@@ -195,9 +195,6 @@
RenderStyle* style = parentRenderer-style();
ASSERT(style);
-const SVGRenderStyle* svgStyle = style-svgStyle();
-ASSERT(svgStyle);
-
RenderStyle* selectionStyle = style;
if (hasSelection) {
selectionStyle = parentRenderer-getCachedPseudoStyle(SELECTION);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106011] trunk/Source/WebCore
Title: [106011] trunk/Source/WebCore Revision 106011 Author vse...@chromium.org Date 2012-01-26 10:45:10 -0800 (Thu, 26 Jan 2012) Log Message Web Inspector: Scripts panel editor container should be based on UISourceCode objects, not SourceFrames. https://bugs.webkit.org/show_bug.cgi?id=77098 Reviewed by Pavel Feldman. * inspector/front-end/ScriptsNavigator.js: * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited): (WebInspector.ScriptsPanel.prototype.get visibleView): (WebInspector.ScriptsPanel.prototype.viewForFile): (WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced): (WebInspector.EditorContainer): (WebInspector.EditorContainer.prototype.get visibleView): (WebInspector.EditorContainer.prototype.showFile): (WebInspector.EditorContainer.prototype.setFileIsDirty): (WebInspector.EditorContainer.prototype.replaceFiles): (WebInspector.EditorContainer.prototype.reset): (WebInspector.EditorContainerDelegate): (WebInspector.EditorContainerDelegate.prototype.viewForFile): (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes): (WebInspector.ScriptsPanel.SingleFileEditorContainer): (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get visibleView): (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showFile): (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setFileIsDirty): (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceFiles): (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset): * inspector/front-end/TabbedEditorContainer.js: (WebInspector.TabbedEditorContainer): (WebInspector.TabbedEditorContainer.prototype.get visibleView): (WebInspector.TabbedEditorContainer.prototype._titleForFile): (WebInspector.TabbedEditorContainer.prototype._tooltipForFile): (WebInspector.TabbedEditorContainer.prototype._appendFileTab): (WebInspector.TabbedEditorContainer.prototype._tabClosed): (WebInspector.TabbedEditorContainer.prototype._tabSelected): (WebInspector.TabbedEditorContainer.prototype.replaceFiles.get if): (WebInspector.TabbedEditorContainer.prototype.replaceFiles): (WebInspector.TabbedEditorContainer.prototype.setFileIsDirty.get if): (WebInspector.TabbedEditorContainer.prototype.setFileIsDirty): (WebInspector.TabbedEditorContainer.prototype.reset): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js Diff Modified: trunk/Source/WebCore/ChangeLog (106010 => 106011) --- trunk/Source/WebCore/ChangeLog 2012-01-26 18:42:50 UTC (rev 106010) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 18:45:10 UTC (rev 106011) @@ -1,3 +1,45 @@ +2012-01-26 Vsevolod Vlasov vse...@chromium.org + +Web Inspector: Scripts panel editor container should be based on UISourceCode objects, not SourceFrames. +https://bugs.webkit.org/show_bug.cgi?id=77098 + +Reviewed by Pavel Feldman. + +* inspector/front-end/ScriptsNavigator.js: +* inspector/front-end/ScriptsPanel.js: +(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited): +(WebInspector.ScriptsPanel.prototype.get visibleView): +(WebInspector.ScriptsPanel.prototype.viewForFile): +(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced): +(WebInspector.EditorContainer): +(WebInspector.EditorContainer.prototype.get visibleView): +(WebInspector.EditorContainer.prototype.showFile): +(WebInspector.EditorContainer.prototype.setFileIsDirty): +(WebInspector.EditorContainer.prototype.replaceFiles): +(WebInspector.EditorContainer.prototype.reset): +(WebInspector.EditorContainerDelegate): +(WebInspector.EditorContainerDelegate.prototype.viewForFile): +(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes): +(WebInspector.ScriptsPanel.SingleFileEditorContainer): +(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get visibleView): +(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showFile): +(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setFileIsDirty): +(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceFiles): +(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset): +* inspector/front-end/TabbedEditorContainer.js: +(WebInspector.TabbedEditorContainer): +(WebInspector.TabbedEditorContainer.prototype.get visibleView): +(WebInspector.TabbedEditorContainer.prototype._titleForFile): +(WebInspector.TabbedEditorContainer.prototype._tooltipForFile): +(WebInspector.TabbedEditorContainer.prototype._appendFileTab): +(WebInspector.TabbedEditorContainer.prototype._tabClosed): +
[webkit-changes] [106012] trunk/Source/WebKit2
Title: [106012] trunk/Source/WebKit2
Revision 106012
Author abe...@webkit.org
Date 2012-01-26 10:46:55 -0800 (Thu, 26 Jan 2012)
Log Message
ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
https://bugs.webkit.org/show_bug.cgi?id=77117
Reviewed by Tor Arne Vestbø.
The PageOverlay does only get uninstalled after the fade-out animation finishes,
so do not assert on !m_overlay after the uninstallPageOverlay call.
* WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::hideHighlight):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (106011 => 106012)
--- trunk/Source/WebKit2/ChangeLog 2012-01-26 18:45:10 UTC (rev 106011)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-26 18:46:55 UTC (rev 106012)
@@ -1,3 +1,16 @@
+2012-01-26 Andras Becsi andras.be...@nokia.com
+
+ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
+https://bugs.webkit.org/show_bug.cgi?id=77117
+
+Reviewed by Tor Arne Vestbø.
+
+The PageOverlay does only get uninstalled after the fade-out animation finishes,
+so do not assert on !m_overlay after the uninstallPageOverlay call.
+
+* WebProcess/WebPage/TapHighlightController.cpp:
+(WebKit::TapHighlightController::hideHighlight):
+
2012-01-26 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
Modified: trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp (106011 => 106012)
--- trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp 2012-01-26 18:45:10 UTC (rev 106011)
+++ trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp 2012-01-26 18:46:55 UTC (rev 106012)
@@ -70,7 +70,6 @@
{
if (m_overlay)
m_webPage-uninstallPageOverlay(m_overlay, /* fadeout */ true);
-ASSERT(!m_overlay);
}
void TapHighlightController::pageOverlayDestroyed(PageOverlay*)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106013] tags/Safari-534.54.10/
Title: [106013] tags/Safari-534.54.10/ Revision 106013 Author mr...@apple.com Date 2012-01-26 10:51:25 -0800 (Thu, 26 Jan 2012) Log Message New tag. Added Paths tags/Safari-534.54.10/ Diff Property changes: tags/Safari-534.54.10 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106014] branches/safari-534.54-branch/Source
Title: [106014] branches/safari-534.54-branch/Source Revision 106014 Author mr...@apple.com Date 2012-01-26 10:52:06 -0800 (Thu, 26 Jan 2012) Log Message Versioning. Modified Paths branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (106013 => 106014) --- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-26 18:51:25 UTC (rev 106013) +++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-26 18:52:06 UTC (rev 106014) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 10; +TINY_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (106013 => 106014) --- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-26 18:51:25 UTC (rev 106013) +++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-26 18:52:06 UTC (rev 106014) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 10; +TINY_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (106013 => 106014) --- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-01-26 18:51:25 UTC (rev 106013) +++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-01-26 18:52:06 UTC (rev 106014) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 10; +TINY_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (106013 => 106014) --- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-26 18:51:25 UTC (rev 106013) +++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-26 18:52:06 UTC (rev 106014) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 10; +TINY_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (106013 => 106014) --- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-01-26 18:51:25 UTC (rev 106013) +++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-01-26 18:52:06 UTC (rev 106014) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 10; +TINY_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106015] trunk/Source/WebCore
Title: [106015] trunk/Source/WebCore Revision 106015 Author kl...@webkit.org Date 2012-01-26 11:02:27 -0800 (Thu, 26 Jan 2012) Log Message Refactor application of additional style attributes for table elements. http://webkit.org/b/77095 Reviewed by Darin Adler. The primary purpose of this change is to reduce usage of CSSMappedAttributeDeclaration. Instead of using the mapped attribute decl table for additional table style, just use regular CSSMutableStyleDeclarations. We cache them all globally, except for the style that's shared between a table's cells. That one is cached per-table since it depends on the table's border and padding. * dom/CSSMappedAttributeDeclaration.cpp: (WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration): * dom/MappedAttributeEntry.h: Remove the concept of persistent CSSMappedAttributeDeclarations. The hunk in ~CSSMappedAttributeDeclaration was wildly wrong since it would leave stale pointers in the decl table, but unreachable since we always leaked one ref to those decls. * dom/StyledElement.h: (WebCore::StyledElement::additionalAttributeStyle): * html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyle): * html/HTMLTableCellElement.h: (HTMLTableCellElement): * html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyle): * html/HTMLTableColElement.h: (HTMLTableColElement): * html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::leakBorderStyle): (WebCore::HTMLTableElement::additionalAttributeStyle): (WebCore::HTMLTableElement::createSharedCellStyle): (WebCore::HTMLTableElement::additionalCellStyle): (WebCore::leakGroupBorderStyle): (WebCore::HTMLTableElement::additionalGroupStyle): * html/HTMLTableElement.h: (HTMLTableElement): * html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyle): * html/HTMLTableSectionElement.h: (HTMLTableSectionElement): Instead of collecting additional style decls into a vector, switch over to a PassRefPtrCSSMutableStyleDeclaration additionalAttributeStyle(). All style declarations that can be reused for all elements are cached at the return sites, leaving only the shared table cell style which we cache on HTMLTableElement. Also removed the canHaveAdditionalAttributeStyleDecls() virtual since the default additionalAttributeStyle() will just return 0. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchAllRules): Updated for the new additional style conventions. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/dom/CSSMappedAttributeDeclaration.cpp trunk/Source/WebCore/dom/MappedAttributeEntry.h trunk/Source/WebCore/dom/StyledElement.h trunk/Source/WebCore/html/HTMLTableCellElement.cpp trunk/Source/WebCore/html/HTMLTableCellElement.h trunk/Source/WebCore/html/HTMLTableColElement.cpp trunk/Source/WebCore/html/HTMLTableColElement.h trunk/Source/WebCore/html/HTMLTableElement.cpp trunk/Source/WebCore/html/HTMLTableElement.h trunk/Source/WebCore/html/HTMLTableSectionElement.cpp trunk/Source/WebCore/html/HTMLTableSectionElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (106014 => 106015) --- trunk/Source/WebCore/ChangeLog 2012-01-26 18:52:06 UTC (rev 106014) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 19:02:27 UTC (rev 106015) @@ -1,3 +1,61 @@ +2012-01-26 Andreas Kling awesomekl...@apple.com + +Refactor application of additional style attributes for table elements. +http://webkit.org/b/77095 + +Reviewed by Darin Adler. + +The primary purpose of this change is to reduce usage of CSSMappedAttributeDeclaration. +Instead of using the mapped attribute decl table for additional table style, just use +regular CSSMutableStyleDeclarations. We cache them all globally, except for the style +that's shared between a table's cells. That one is cached per-table since it depends +on the table's border and padding. + +* dom/CSSMappedAttributeDeclaration.cpp: +(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration): +* dom/MappedAttributeEntry.h: + +Remove the concept of persistent CSSMappedAttributeDeclarations. The hunk in +~CSSMappedAttributeDeclaration was wildly wrong since it would leave stale pointers +in the decl table, but unreachable since we always leaked one ref to those decls. + +* dom/StyledElement.h: +(WebCore::StyledElement::additionalAttributeStyle): +* html/HTMLTableCellElement.cpp: +(WebCore::HTMLTableCellElement::additionalAttributeStyle): +* html/HTMLTableCellElement.h: +(HTMLTableCellElement): +* html/HTMLTableColElement.cpp: +(WebCore::HTMLTableColElement::additionalAttributeStyle): +* html/HTMLTableColElement.h: +(HTMLTableColElement): +*
[webkit-changes] [106016] trunk/Source/WebCore
Title: [106016] trunk/Source/WebCore
Revision 106016
Author commit-qu...@webkit.org
Date 2012-01-26 11:18:18 -0800 (Thu, 26 Jan 2012)
Log Message
REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796
Patch by Stephen Chenney schen...@chromium.org on 2012-01-26
Reviewed by Nikolas Zimmermann.
It turns out that the CG problem is a design decision. The bounding code
returns CGRectNull for cases where a bound is ill-defined, rather than the
empty bound as expected.
I'm also removing the workaround for isEmpty to get correct zero length paths.
It is no longer necessary.
Tested by existing layout tests.
* platform/graphics/cg/PathCG.cpp: Removed path empty and path bound testing classes.
(WebCore::Path::boundingRect): Added check for CGRectNull
(WebCore::Path::fastBoundingRect): Added check for CGRectNull
(WebCore::Path::strokeBoundingRect): Added check for CGRectNull
(WebCore::Path::isEmpty): Reverted to former behavior, just using CGPathIsEmpty.
(WebCore::Path::hasCurrentPoint): Reverted to former behavior, using isEmpty.
(WebCore::Path::transform): Reverted to former behavior, using isEmpty.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106015 => 106016)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 19:02:27 UTC (rev 106015)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 19:18:18 UTC (rev 106016)
@@ -1,3 +1,27 @@
+2012-01-26 Stephen Chenney schen...@chromium.org
+
+REGRESSION (r91125): Polyline tool in google docs is broken
+https://bugs.webkit.org/show_bug.cgi?id=65796
+
+Reviewed by Nikolas Zimmermann.
+
+It turns out that the CG problem is a design decision. The bounding code
+returns CGRectNull for cases where a bound is ill-defined, rather than the
+empty bound as expected.
+
+I'm also removing the workaround for isEmpty to get correct zero length paths.
+It is no longer necessary.
+
+Tested by existing layout tests.
+
+* platform/graphics/cg/PathCG.cpp: Removed path empty and path bound testing classes.
+(WebCore::Path::boundingRect): Added check for CGRectNull
+(WebCore::Path::fastBoundingRect): Added check for CGRectNull
+(WebCore::Path::strokeBoundingRect): Added check for CGRectNull
+(WebCore::Path::isEmpty): Reverted to former behavior, just using CGPathIsEmpty.
+(WebCore::Path::hasCurrentPoint): Reverted to former behavior, using isEmpty.
+(WebCore::Path::transform): Reverted to former behavior, using isEmpty.
+
2012-01-26 Andreas Kling awesomekl...@apple.com
Refactor application of additional style attributes for table elements.
Modified: trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp (106015 => 106016)
--- trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2012-01-26 19:02:27 UTC (rev 106015)
+++ trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2012-01-26 19:18:18 UTC (rev 106016)
@@ -41,59 +41,6 @@
namespace WebCore {
-// A class to provide an isEmpty test that considers a one-element path with only a MoveTo element
-// to be empty. This behavior is consistent with other platforms in WebKit, and is needed to prevent
-// incorrect (according to the spec) linecap stroking for zero length paths in SVG.
-class PathIsEmptyOrSingleMoveTester {
-public:
-PathIsEmptyOrSingleMoveTester() : m_moveCount(0) { }
-
-bool isEmpty() const
-{
-return m_moveCount = 1;
-}
-
-static void testPathElement(void* info, const CGPathElement* element)
-{
-PathIsEmptyOrSingleMoveTester* tester = static_castPathIsEmptyOrSingleMoveTester*(info);
-if (element-type == kCGPathElementMoveToPoint)
-++tester-m_moveCount;
-else {
-// Any non move element implies a non-empty path; set the count to 2 to force
-// isEmpty to return false.
-tester-m_moveCount = 2;
-}
-}
-
-private:
-// Any non-move-to element, or more than one move-to element, will make the count = 2.
-unsigned m_moveCount;
-};
-
-// Paths with only move-to elements do not draw under any circumstances, so their bound should
-// be empty. Currently, CoreGraphics returns non-empty bounds for such paths. Radar 10450621
-// tracks this. This class reports paths that have only move-to elements, allowing the
-// bounding box code to work around the CoreGraphics problem.
-class PathHasOnlyMoveToTester {
-public:
-PathHasOnlyMoveToTester() : m_hasSeenOnlyMoveTo(true) { }
-
-bool hasOnlyMoveTo() const
-{
-return m_hasSeenOnlyMoveTo;
-}
-
-static void testPathElement(void* info, const CGPathElement* element)
-{
-PathHasOnlyMoveToTester* tester = static_castPathHasOnlyMoveToTester*(info);
-if (tester-m_hasSeenOnlyMoveTo element-type != kCGPathElementMoveToPoint)
-
[webkit-changes] [106017] trunk/LayoutTests
Title: [106017] trunk/LayoutTests
Revision 106017
Author commit-qu...@webkit.org
Date 2012-01-26 11:20:27 -0800 (Thu, 26 Jan 2012)
Log Message
[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017
Unreviewed Chromium expectations update.
Patch by Stephen Chenney schen...@chromium.org on 2012-01-26
* platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/chromium/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt
trunk/LayoutTests/platform/chromium/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (106016 => 106017)
--- trunk/LayoutTests/ChangeLog 2012-01-26 19:18:18 UTC (rev 106016)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 19:20:27 UTC (rev 106017)
@@ -1,3 +1,14 @@
+2012-01-26 Stephen Chenney schen...@chromium.org
+
+[Chromium]: rebaseline after r105878
+https://bugs.webkit.org/show_bug.cgi?id=77017
+
+Unreviewed Chromium expectations update.
+
+* platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
+* platform/chromium/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2012-01-26 Levi Weintraub le...@chromium.org
Layout Test accessibility/loading-iframe-sends-notification.html occasionally exceeds the Chromium Windows callstack
Added: trunk/LayoutTests/platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt (0 => 106017)
--- trunk/LayoutTests/platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt 2012-01-26 19:20:27 UTC (rev 106017)
@@ -0,0 +1,111 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderSVGRoot {svg} at (0,0) size 600x150
+RenderSVGContainer {g} at (0,0) size 600x150
+ RenderSVGRect {rect} at (0,0) size 600x150 [fill={[type=SOLID] [color=#808080]}] [x=0.00] [y=0.00] [width=600.00] [height=150.00]
+ RenderSVGContainer {g} at (5,55) size 40x90
+RenderSVGPath {circle} at (5,55) size 40x40 [fill={[type=SOLID] [color=#008000]}] [cx=25.00] [cy=75.00] [r=20.00]
+RenderSVGRect {rect} at (5,105) size 40x40 [fill={[type=SOLID] [color=#008000]}] [x=5.00] [y=105.00] [width=40.00] [height=40.00]
+RenderSVGPath {path} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#FF] [stroke width=40.00]}] [fill={[type=SOLID] [color=#00]}] [data="" 25 25]
+RenderSVGPath {path} at (0,0) size 0x0 [transform={m=((1.00,0.00)(0.00,1.00)) t=(25.00,75.00)}] [stroke={[type=SOLID] [color=#FF] [stroke width=40.00] [line cap=ROUND]}] [fill={[type=SOLID] [color=#00]}] [data="" 0 0]
+RenderSVGPath {path} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#FF] [stroke width=40.00] [line cap=SQUARE]}] [fill={[type=SOLID] [color=#00]}] [data="" 25 125]
+ RenderSVGContainer {g} at (55,55) size 40x90 [transform={m=((1.00,0.00)(0.00,1.00)) t=(50.00,0.00)}]
+RenderSVGContainer {use} at (55,55) size 40x90
+ RenderSVGContainer {g} at (55,55) size 40x90
+RenderSVGContainer {g} at (55,55) size 40x90
+ RenderSVGPath {circle} at (55,55) size 40x40 [fill={[type=SOLID] [color=#FF]}] [cx=25.00] [cy=75.00] [r=20.00]
+ RenderSVGRect {rect} at (55,105) size 40x40 [fill={[type=SOLID] [color=#FF]}] [x=5.00] [y=105.00] [width=40.00] [height=40.00]
+RenderSVGPath {path} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#FF] [stroke width=40.00]}] [fill={[type=SOLID] [color=#00]}] [data="" 25 25 Z]
+RenderSVGPath {path} at (55,55) size 40x40 [transform={m=((1.00,0.00)(0.00,1.00)) t=(25.00,75.00)}] [stroke={[type=SOLID] [color=#008000] [stroke width=40.00] [line cap=ROUND]}] [fill={[type=SOLID] [color=#00]}] [data="" 0 0 Z]
+RenderSVGPath {path} at (55,105) size 40x40 [stroke={[type=SOLID] [color=#008000] [stroke width=40.00] [line cap=SQUARE]}] [fill={[type=SOLID] [color=#00]}] [data="" 25 125 Z]
+ RenderSVGContainer {g} at (105,55) size 40x90 [transform={m=((1.00,0.00)(0.00,1.00)) t=(100.00,0.00)}]
+RenderSVGContainer {use} at (105,55) size 40x90
+ RenderSVGContainer {g} at (105,55) size 40x90
+RenderSVGContainer {g} at (105,55) size 40x90
+ RenderSVGPath {circle} at (105,55) size 40x40 [fill={[type=SOLID] [color=#FF]}] [cx=25.00] [cy=75.00] [r=20.00]
+ RenderSVGRect {rect} at (105,105) size 40x40 [fill={[type=SOLID]
[webkit-changes] [106018] trunk/Source/WebCore
Title: [106018] trunk/Source/WebCore
Revision 106018
Author dch...@chromium.org
Date 2012-01-26 11:23:42 -0800 (Thu, 26 Jan 2012)
Log Message
Revert code changes from r105800
https://bugs.webkit.org/show_bug.cgi?id=77071
The strings are already lowercased in EventHandler.cpp:findDropZone() so there's
no need to call lower() again.
Reviewed by Tony Chang.
Covered by existing tests.
* dom/Clipboard.cpp:
(WebCore::Clipboard::hasDropZoneType):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Clipboard.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106017 => 106018)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 19:20:27 UTC (rev 106017)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 19:23:42 UTC (rev 106018)
@@ -1,3 +1,18 @@
+2012-01-26 Daniel Cheng dch...@chromium.org
+
+Revert code changes from r105800
+https://bugs.webkit.org/show_bug.cgi?id=77071
+
+The strings are already lowercased in EventHandler.cpp:findDropZone() so there's
+no need to call lower() again.
+
+Reviewed by Tony Chang.
+
+Covered by existing tests.
+
+* dom/Clipboard.cpp:
+(WebCore::Clipboard::hasDropZoneType):
+
2012-01-26 Stephen Chenney schen...@chromium.org
REGRESSION (r91125): Polyline tool in google docs is broken
Modified: trunk/Source/WebCore/dom/Clipboard.cpp (106017 => 106018)
--- trunk/Source/WebCore/dom/Clipboard.cpp 2012-01-26 19:20:27 UTC (rev 106017)
+++ trunk/Source/WebCore/dom/Clipboard.cpp 2012-01-26 19:23:42 UTC (rev 106018)
@@ -211,10 +211,10 @@
bool Clipboard::hasDropZoneType(const String keyword)
{
if (keyword.startsWith(file:))
-return hasFileOfType(keyword.substring(5).lower());
+return hasFileOfType(keyword.substring(5));
if (keyword.startsWith(string:))
-return hasStringOfType(keyword.substring(7).lower());
+return hasStringOfType(keyword.substring(7));
return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106019] trunk/Source/JavaScriptCore
Title: [106019] trunk/Source/_javascript_Core
Revision 106019
Author msab...@apple.com
Date 2012-01-26 11:23:50 -0800 (Thu, 26 Jan 2012)
Log Message
Dromaeo tests usage of StringImpl find routines cause 8-16 bit conversions
https://bugs.webkit.org/show_bug.cgi?id=76645
Reviewed by Geoffrey Garen.
* wtf/text/StringImpl.cpp:
(WTF::equalIgnoringCase): New LChar version.
(WTF::findInner): New helper function.
(WTF::StringImpl::find): Added 8 bit path.
(WTF::reverseFindInner): New helper funciton.
(WTF::StringImpl::reverseFind): Added 8 bit path.
(WTF::StringImpl::reverseFindIgnoringCase): Added 8 bit path.
* wtf/text/StringImpl.h:
(WTF):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp
trunk/Source/_javascript_Core/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106018 => 106019)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 19:23:42 UTC (rev 106018)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 19:23:50 UTC (rev 106019)
@@ -1,3 +1,20 @@
+2012-01-26 Michael Saboff msab...@apple.com
+
+Dromaeo tests usage of StringImpl find routines cause 8-16 bit conversions
+https://bugs.webkit.org/show_bug.cgi?id=76645
+
+Reviewed by Geoffrey Garen.
+
+* wtf/text/StringImpl.cpp:
+(WTF::equalIgnoringCase): New LChar version.
+(WTF::findInner): New helper function.
+(WTF::StringImpl::find): Added 8 bit path.
+(WTF::reverseFindInner): New helper funciton.
+(WTF::StringImpl::reverseFind): Added 8 bit path.
+(WTF::StringImpl::reverseFindIgnoringCase): Added 8 bit path.
+* wtf/text/StringImpl.h:
+(WTF):
+
2012-01-26 Csaba Osztrogonác o...@webkit.org
[Qt][Win] One more speculative buildfix after r105970.
Modified: trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp (106018 => 106019)
--- trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp 2012-01-26 19:23:42 UTC (rev 106018)
+++ trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp 2012-01-26 19:23:50 UTC (rev 106019)
@@ -715,6 +715,16 @@
return charactersToFloat(characters16(), m_length, ok, didReadNumber);
}
+bool equalIgnoringCase(const LChar* a, const LChar* b, unsigned length)
+{
+while (length--) {
+LChar bc = *b++;
+if (foldCase(*a++) != foldCase(bc))
+return false;
+}
+return true;
+}
+
bool equalIgnoringCase(const UChar* a, const LChar* b, unsigned length)
{
while (length--) {
@@ -849,6 +859,35 @@
return index + i;
}
+template typename CharType
+ALWAYS_INLINE static size_t findInner(const CharType* searchCharacters, const CharType* matchCharacters, unsigned index, unsigned searchLength, unsigned matchLength)
+{
+// Optimization: keep a running hash of the strings,
+// only call memcmp if the hashes match.
+
+// delta is the number of additional times to test; delta == 0 means test only once.
+unsigned delta = searchLength - matchLength;
+
+unsigned searchHash = 0;
+unsigned matchHash = 0;
+
+for (unsigned i = 0; i matchLength; ++i) {
+searchHash += searchCharacters[i];
+matchHash += matchCharacters[i];
+}
+
+unsigned i = 0;
+// keep looping until we match
+while (searchHash != matchHash || memcmp(searchCharacters + i, matchCharacters, matchLength * sizeof(CharType))) {
+if (i == delta)
+return notFound;
+searchHash += searchCharacters[i + matchLength];
+searchHash -= searchCharacters[i];
+++i;
+}
+return index + i;
+}
+
size_t StringImpl::find(StringImpl* matchString, unsigned index)
{
// Check for null or empty string to match against
@@ -871,31 +910,12 @@
unsigned searchLength = length() - index;
if (matchLength searchLength)
return notFound;
-// delta is the number of additional times to test; delta == 0 means test only once.
-unsigned delta = searchLength - matchLength;
-const UChar* searchCharacters = characters() + index;
-const UChar* matchCharacters = matchString-characters();
+if (is8Bit() matchString-is8Bit())
+return findInner(characters8() + index, matchString-characters8(), index, searchLength, matchLength);
-// Optimization 2: keep a running hash of the strings,
-// only call memcmp if the hashes match.
-unsigned searchHash = 0;
-unsigned matchHash = 0;
-for (unsigned i = 0; i matchLength; ++i) {
-searchHash += searchCharacters[i];
-matchHash += matchCharacters[i];
-}
+return findInner(characters() + index, matchString-characters(), index, searchLength, matchLength);
-unsigned i = 0;
-// keep looping until we match
-while (searchHash != matchHash || memcmp(searchCharacters + i, matchCharacters, matchLength * sizeof(UChar))) {
-if (i == delta)
-return notFound;
-searchHash +=
[webkit-changes] [106020] trunk/Source/JavaScriptCore
Title: [106020] trunk/Source/_javascript_Core Revision 106020 Author msab...@apple.com Date 2012-01-26 11:26:15 -0800 (Thu, 26 Jan 2012) Log Message String::latin1() should take advantage of 8 bit strings https://bugs.webkit.org/show_bug.cgi?id=76646 Reviewed by Geoffrey Garen. * wtf/text/WTFString.cpp: (WTF::String::latin1): For 8 bit strings, use existing buffer without conversion. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/text/WTFString.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (106019 => 106020) --- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 19:23:50 UTC (rev 106019) +++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 19:26:15 UTC (rev 106020) @@ -1,5 +1,16 @@ 2012-01-26 Michael Saboff msab...@apple.com +String::latin1() should take advantage of 8 bit strings +https://bugs.webkit.org/show_bug.cgi?id=76646 + +Reviewed by Geoffrey Garen. + +* wtf/text/WTFString.cpp: +(WTF::String::latin1): For 8 bit strings, use existing buffer +without conversion. + +2012-01-26 Michael Saboff msab...@apple.com + Dromaeo tests usage of StringImpl find routines cause 8-16 bit conversions https://bugs.webkit.org/show_bug.cgi?id=76645 Modified: trunk/Source/_javascript_Core/wtf/text/WTFString.cpp (106019 => 106020) --- trunk/Source/_javascript_Core/wtf/text/WTFString.cpp 2012-01-26 19:23:50 UTC (rev 106019) +++ trunk/Source/_javascript_Core/wtf/text/WTFString.cpp 2012-01-26 19:26:15 UTC (rev 106020) @@ -687,6 +687,13 @@ // preserved, characters outside of this range are converted to '?'. unsigned length = this-length(); + +if (!length) +return CString(, 0); + +if (is8Bit()) +return CString(reinterpret_castconst char*(this-characters8()), length); + const UChar* characters = this-characters(); char* characterBuffer; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106021] trunk/Source
Title: [106021] trunk/Source
Revision 106021
Author ander...@apple.com
Date 2012-01-26 11:28:38 -0800 (Thu, 26 Jan 2012)
Log Message
WebWheelEvent::Phase and PlatformWheelEvent::Phase declarations should match AppKit
https://bugs.webkit.org/show_bug.cgi?id=77123
Reviewed by Beth Dakin.
Source/WebCore:
* platform/PlatformWheelEvent.h:
():
* platform/mac/PlatformEventFactoryMac.mm:
(WebCore::phaseForEvent):
Source/WebKit2:
* Shared/WebEvent.h:
():
* Shared/mac/WebEventFactory.mm:
(WebKit::phaseForEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformWheelEvent.h
trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebEvent.h
trunk/Source/WebKit2/Shared/mac/WebEventFactory.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106020 => 106021)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 19:26:15 UTC (rev 106020)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 19:28:38 UTC (rev 106021)
@@ -1,3 +1,15 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+WebWheelEvent::Phase and PlatformWheelEvent::Phase declarations should match AppKit
+https://bugs.webkit.org/show_bug.cgi?id=77123
+
+Reviewed by Beth Dakin.
+
+* platform/PlatformWheelEvent.h:
+():
+* platform/mac/PlatformEventFactoryMac.mm:
+(WebCore::phaseForEvent):
+
2012-01-26 Daniel Cheng dch...@chromium.org
Revert code changes from r105800
Modified: trunk/Source/WebCore/platform/PlatformWheelEvent.h (106020 => 106021)
--- trunk/Source/WebCore/platform/PlatformWheelEvent.h 2012-01-26 19:26:15 UTC (rev 106020)
+++ trunk/Source/WebCore/platform/PlatformWheelEvent.h 2012-01-26 19:28:38 UTC (rev 106021)
@@ -77,11 +77,12 @@
#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) OS(DARWIN))
enum PlatformWheelEventPhase {
PlatformWheelEventPhaseNone= 0,
-PlatformWheelEventPhaseBegan = 1 1,
-PlatformWheelEventPhaseStationary = 1 2,
-PlatformWheelEventPhaseChanged = 1 3,
-PlatformWheelEventPhaseEnded = 1 4,
-PlatformWheelEventPhaseCancelled = 1 5,
+PlatformWheelEventPhaseBegan = 1 0,
+PlatformWheelEventPhaseStationary = 1 1,
+PlatformWheelEventPhaseChanged = 1 2,
+PlatformWheelEventPhaseEnded = 1 3,
+PlatformWheelEventPhaseCancelled = 1 4,
+PlatformWheelEventPhaseMayBegin= 1 5,
};
#endif
Modified: trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm (106020 => 106021)
--- trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm 2012-01-26 19:26:15 UTC (rev 106020)
+++ trunk/Source/WebCore/platform/mac/PlatformEventFactoryMac.mm 2012-01-26 19:28:38 UTC (rev 106021)
@@ -201,6 +201,11 @@
phase |= PlatformWheelEventPhaseEnded;
if ([event phase] NSEventPhaseCancelled)
phase |= PlatformWheelEventPhaseCancelled;
+#if !defined(BUILDING_ON_LION)
+if ([event momentumPhase] NSEventPhaseMayBegin)
+phase |= PlatformWheelEventPhaseMayBegin;
+#endif
+
return static_castPlatformWheelEventPhase(phase);
#else
UNUSED_PARAM(event);
Modified: trunk/Source/WebKit2/ChangeLog (106020 => 106021)
--- trunk/Source/WebKit2/ChangeLog 2012-01-26 19:26:15 UTC (rev 106020)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-26 19:28:38 UTC (rev 106021)
@@ -1,3 +1,15 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+WebWheelEvent::Phase and PlatformWheelEvent::Phase declarations should match AppKit
+https://bugs.webkit.org/show_bug.cgi?id=77123
+
+Reviewed by Beth Dakin.
+
+* Shared/WebEvent.h:
+():
+* Shared/mac/WebEventFactory.mm:
+(WebKit::phaseForEvent):
+
2012-01-26 Andras Becsi andras.be...@nokia.com
ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
Modified: trunk/Source/WebKit2/Shared/WebEvent.h (106020 => 106021)
--- trunk/Source/WebKit2/Shared/WebEvent.h 2012-01-26 19:26:15 UTC (rev 106020)
+++ trunk/Source/WebKit2/Shared/WebEvent.h 2012-01-26 19:28:38 UTC (rev 106021)
@@ -166,11 +166,12 @@
#if PLATFORM(MAC)
enum Phase {
PhaseNone= 0,
-PhaseBegan = 1 1,
-PhaseStationary = 1 2,
-PhaseChanged = 1 3,
-PhaseEnded = 1 4,
-PhaseCancelled = 1 5,
+PhaseBegan = 1 0,
+PhaseStationary = 1 1,
+PhaseChanged = 1 2,
+PhaseEnded = 1 3,
+PhaseCancelled = 1 4,
+PhaseMayBegin= 1 5,
};
#endif
Modified: trunk/Source/WebKit2/Shared/mac/WebEventFactory.mm (106020 => 106021)
--- trunk/Source/WebKit2/Shared/mac/WebEventFactory.mm 2012-01-26 19:26:15 UTC (rev 106020)
+++ trunk/Source/WebKit2/Shared/mac/WebEventFactory.mm 2012-01-26 19:28:38 UTC (rev 106021)
@@ -200,6 +200,11 @@
phase |= WebWheelEvent::PhaseEnded;
if ([event phase]
[webkit-changes] [106022] trunk/Source/WebKit2
Title: [106022] trunk/Source/WebKit2
Revision 106022
Author abe...@webkit.org
Date 2012-01-26 11:47:53 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt][WK2] Add the componentComplete method to WebView
https://bugs.webkit.org/show_bug.cgi?id=77111
Reviewed by Kenneth Rohde Christiansen.
Move the touch/desktop initialization to componentComplete.
Also return valid default values in the viewport info functions
if the interaction engine is not yet initialized because the
viewport info component could finish initialization earlier
than the WebView, which results in QML warnings during MiniBrowser
startup.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (106021 => 106022)
--- trunk/Source/WebKit2/ChangeLog 2012-01-26 19:28:38 UTC (rev 106021)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-26 19:47:53 UTC (rev 106022)
@@ -1,3 +1,31 @@
+2012-01-26 Andras Becsi andras.be...@nokia.com
+
+[Qt][WK2] Add the componentComplete method to WebView
+https://bugs.webkit.org/show_bug.cgi?id=77111
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Move the touch/desktop initialization to componentComplete.
+Also return valid default values in the viewport info functions
+if the interaction engine is not yet initialized because the
+viewport info component could finish initialization earlier
+than the WebView, which results in QML warnings during MiniBrowser
+startup.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
+(QQuickWebView::geometryChanged):
+(QQuickWebView::componentComplete):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/qwebviewportinfo.cpp:
+(QWebViewportInfo::currentScale):
+(QWebViewportInfo::devicePixelRatio):
+(QWebViewportInfo::initialScale):
+(QWebViewportInfo::minimumScale):
+(QWebViewportInfo::maximumScale):
+(QWebViewportInfo::isScalable):
+(QWebViewportInfo::layoutSize):
+
2012-01-26 Anders Carlsson ander...@apple.com
WebWheelEvent::Phase and PlatformWheelEvent::Phase declarations should match AppKit
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (106021 => 106022)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-26 19:28:38 UTC (rev 106021)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-01-26 19:47:53 UTC (rev 106022)
@@ -550,16 +550,8 @@
void QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour(bool enable)
{
-Q_Q(QQuickWebView);
-
-// Do not guard, testing for the same value, as we call this from the constructor.
-
webPageProxy-setUseFixedLayout(!enable);
pageView-setUsesTraditionalDesktopBehaviour(enable);
-if (enable)
-initializeDesktop(q);
-else
-initializeTouch(q);
}
void QQuickWebViewPrivate::setViewInAttachedProperties(QObject* object)
@@ -1054,14 +1046,26 @@
{
Q_D(QQuickWebView);
QQuickItem::geometryChanged(newGeometry, oldGeometry);
-if (newGeometry.size() != oldGeometry.size()) {
-if (d-pageView-usesTraditionalDesktopBehaviour())
-d-updateDesktopViewportSize();
-else
-d-updateTouchViewportSize();
-}
+
+if (newGeometry.isEmpty() || newGeometry.size() == oldGeometry.size())
+return;
+
+if (d-pageView-usesTraditionalDesktopBehaviour())
+d-updateDesktopViewportSize();
+else
+d-updateTouchViewportSize();
}
+void QQuickWebView::componentComplete()
+{
+Q_D(QQuickWebView);
+QQuickItem::componentComplete();
+if (d-pageView-usesTraditionalDesktopBehaviour())
+d-initializeDesktop(this);
+else
+d-initializeTouch(this);
+}
+
void QQuickWebView::keyPressEvent(QKeyEvent* event)
{
this-event(event);
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (106021 => 106022)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h 2012-01-26 19:28:38 UTC (rev 106021)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h 2012-01-26 19:47:53 UTC (rev 106022)
@@ -135,7 +135,7 @@
protected:
virtual void geometryChanged(const QRectF, const QRectF);
-
+virtual void componentComplete();
[webkit-changes] [106023] trunk/LayoutTests
Title: [106023] trunk/LayoutTests Revision 106023 Author caio.olive...@openbossa.org Date 2012-01-26 11:56:43 -0800 (Thu, 26 Jan 2012) Log Message [Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache https://bugs.webkit.org/show_bug.cgi?id=73999 Reviewed by Kenneth Rohde Christiansen. Those tests were failing because PageCache was enabled for WTR and they depend on it being disable: they rely on onload being called after navigating back to a page. WTR should run without PageCache enabled. This was fixed in r106005, so we can unskip these now. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (106022 => 106023) --- trunk/LayoutTests/ChangeLog 2012-01-26 19:47:53 UTC (rev 106022) +++ trunk/LayoutTests/ChangeLog 2012-01-26 19:56:43 UTC (rev 106023) @@ -1,3 +1,18 @@ +2012-01-26 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org + +[Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache +https://bugs.webkit.org/show_bug.cgi?id=73999 + +Reviewed by Kenneth Rohde Christiansen. + +Those tests were failing because PageCache was enabled for WTR and they depend on +it being disable: they rely on onload being called after navigating back to a page. + +WTR should run without PageCache enabled. This was fixed in r106005, so we can +unskip these now. + +* platform/qt-wk2/Skipped: + 2012-01-26 Stephen Chenney schen...@chromium.org [Chromium]: rebaseline after r105878 Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (106022 => 106023) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-26 19:47:53 UTC (rev 106022) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-26 19:56:43 UTC (rev 106023) @@ -368,17 +368,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=73917 fast/forms/access-key-for-all-elements.html -# [Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache -# https://bugs.webkit.org/show_bug.cgi?id=73999 -fast/forms/state-restore-radio-group.html -fast/forms/state-restore-to-non-autocomplete-form.html -fast/forms/state-restore-to-non-edited-controls.html -fast/forms/state-save-of-detached-control.html -fast/history/history-back-initial-vs-final-url.html -http/tests/history/back-to-post.php -http/tests/navigation/post-frames-goback1.html -http/tests/navigation/postredirect-frames-goback1.html - # [Qt][WK2] css3/unicode-bidi-isolate-aharon-failing.html fails # https://bugs.webkit.org/show_bug.cgi?id=74505 css3/unicode-bidi-isolate-aharon-failing.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106025] trunk/Source/WebCore
Title: [106025] trunk/Source/WebCore
Revision 106025
Author benja...@webkit.org
Date 2012-01-26 12:09:40 -0800 (Thu, 26 Jan 2012)
Log Message
Using strncmp() for comparing scheme and port numbers is inefficient
https://bugs.webkit.org/show_bug.cgi?id=75821
Reviewed by Darin Adler.
Replace the equal() function comparing 2 arbitrary strings by a template
comparing the string to an array, character by character.
This is only used for small strings: the schemes and the ports.
* platform/KURL.cpp:
(WebCore::equal):
(WebCore::isDefaultPortForScheme):
(WebCore::isNonFileHierarchicalScheme):
(WebCore::isCanonicalHostnameLowercaseForScheme):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/KURL.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106024 => 106025)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 20:02:54 UTC (rev 106024)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 20:09:40 UTC (rev 106025)
@@ -1,3 +1,21 @@
+2012-01-26 Benjamin Poulain benja...@webkit.org
+
+Using strncmp() for comparing scheme and port numbers is inefficient
+https://bugs.webkit.org/show_bug.cgi?id=75821
+
+Reviewed by Darin Adler.
+
+Replace the equal() function comparing 2 arbitrary strings by a template
+comparing the string to an array, character by character.
+
+This is only used for small strings: the schemes and the ports.
+
+* platform/KURL.cpp:
+(WebCore::equal):
+(WebCore::isDefaultPortForScheme):
+(WebCore::isNonFileHierarchicalScheme):
+(WebCore::isCanonicalHostnameLowercaseForScheme):
+
2012-01-26 Anders Carlsson ander...@apple.com
WebWheelEvent::Phase and PlatformWheelEvent::Phase declarations should match AppKit
Modified: trunk/Source/WebCore/platform/KURL.cpp (106024 => 106025)
--- trunk/Source/WebCore/platform/KURL.cpp 2012-01-26 20:02:54 UTC (rev 106024)
+++ trunk/Source/WebCore/platform/KURL.cpp 2012-01-26 20:09:40 UTC (rev 106025)
@@ -68,6 +68,18 @@
#if !USE(GOOGLEURL)
+static const char wsScheme[] = {'w', 's'};
+static const char ftpScheme[] = {'f', 't', 'p'};
+static const char ftpPort[] = {'2', '1'};
+static const char wssScheme[] = {'w', 's', 's'};
+static const char fileScheme[] = {'f', 'i', 'l', 'e'};
+static const char httpScheme[] = {'h', 't', 't', 'p'};
+static const char httpPort[] = {'8', '0'};
+static const char httpsScheme[] = {'h', 't', 't', 'p', 's'};
+static const char httpsPort[] = {'4', '4', '3'};
+static const char gopherScheme[] = {'g', 'o', 'p', 'h', 'e', 'r'};
+static const char gopherPort[] = {'7', '0'};
+
static inline bool isLetterMatchIgnoringCase(char character, char lowercaseLetter)
{
ASSERT(isASCIILower(lowercaseLetter));
@@ -1050,15 +1062,22 @@
parse(buffer.data(), string);
}
-// FIXME: (lenA != lenB) is never true in the way this function is used.
-// FIXME: This is only used for short string, we should replace equal() by a recursive template comparing the strings without loop.
-static inline bool equal(const char* a, size_t lenA, const char* b, size_t lenB)
+templatesize_t length
+static inline bool equal(const char* a, const char (b)[length])
{
-if (lenA != lenB)
-return false;
-return !strncmp(a, b, lenA);
+for (size_t i = 0; i length; ++i) {
+if (a[i] != b[i])
+return false;
+}
+return true;
}
+templatesize_t lengthB
+static inline bool equal(const char* stringA, size_t lengthA, const char (stringB)[lengthB])
+{
+return lengthA == lengthB equal(stringA, stringB);
+}
+
// List of default schemes is taken from google-url:
// http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_stdurl.cc#120
static inline bool isDefaultPortForScheme(const char* port, size_t portLength, const char* scheme, size_t schemeLength)
@@ -1067,19 +1086,19 @@
// the code was moved from google-url, but may be removed later.
switch (schemeLength) {
case 2:
-return equal(ws, 2, scheme, schemeLength) equal(80, 2, port, portLength);
+return equal(scheme, wsScheme) equal(port, portLength, httpPort);
case 3:
-if (equal(ftp, 3, scheme, schemeLength))
-return equal(21, 2, port, portLength);
-if (equal(wss, 3, scheme, schemeLength))
-return equal(443, 3, port, portLength);
+if (equal(scheme, ftpScheme))
+return equal(port, portLength, ftpPort);
+if (equal(scheme, wssScheme))
+return equal(port, portLength, httpsPort);
break;
case 4:
-return equal(http, 4, scheme, schemeLength) equal(80, 2, port, portLength);
+return equal(scheme, httpScheme) equal(port, portLength, httpPort);
case 5:
-return equal(https, 5, scheme, schemeLength) equal(443, 3, port, portLength);
+return equal(scheme, httpsScheme) equal(port, portLength, httpsPort);
case 6:
-return equal(gopher, 6, scheme, schemeLength)
[webkit-changes] [106026] trunk/Source/WebCore
Title: [106026] trunk/Source/WebCore
Revision 106026
Author ander...@apple.com
Date 2012-01-26 12:13:39 -0800 (Thu, 26 Jan 2012)
Log Message
Use PlatformWheelEvent::phase() to determine if a scroll gesture begins or ends
https://bugs.webkit.org/show_bug.cgi?id=77127
Reviewed by Beth Dakin.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
Remove handleGestureEvent.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Look at the event phase to determine when to call didBeginGesture and didEndGesture.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106025 => 106026)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 20:09:40 UTC (rev 106025)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 20:13:39 UTC (rev 106026)
@@ -1,3 +1,18 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+Use PlatformWheelEvent::phase() to determine if a scroll gesture begins or ends
+https://bugs.webkit.org/show_bug.cgi?id=77127
+
+Reviewed by Beth Dakin.
+
+* platform/mac/ScrollAnimatorMac.h:
+(ScrollAnimatorMac):
+Remove handleGestureEvent.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+Look at the event phase to determine when to call didBeginGesture and didEndGesture.
+
2012-01-26 Benjamin Poulain benja...@webkit.org
Using strncmp() for comparing scheme and port numbers is inefficient
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h (106025 => 106026)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 20:09:40 UTC (rev 106025)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 20:13:39 UTC (rev 106026)
@@ -84,10 +84,7 @@
#if ENABLE(RUBBER_BANDING)
virtual bool handleWheelEvent(const PlatformWheelEvent) OVERRIDE;
-#if ENABLE(GESTURE_EVENTS)
-virtual void handleGestureEvent(const PlatformGestureEvent);
#endif
-#endif
virtual void cancelAnimations();
virtual void setIsActive();
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106025 => 106026)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 20:09:40 UTC (rev 106025)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 20:13:39 UTC (rev 106026)
@@ -950,15 +950,15 @@
}
}
-return m_scrollElasticityController.handleWheelEvent(wheelEvent);
-}
-
-void ScrollAnimatorMac::handleGestureEvent(const PlatformGestureEvent gestureEvent)
-{
-if (gestureEvent.type() == PlatformEvent::GestureScrollBegin)
+if (wheelEvent.phase() == PlatformWheelEventPhaseBegan) {
+// We don't return after this because we still want the scroll elasticity controller to handle the wheel event.
beginScrollGesture();
-else if (gestureEvent.type() == PlatformEvent::GestureScrollEnd)
+} else if (wheelEvent.phase() == PlatformWheelEventPhaseEnded) {
endScrollGesture();
+return true;
+}
+
+return m_scrollElasticityController.handleWheelEvent(wheelEvent);
}
bool ScrollAnimatorMac::pinnedInDirection(float deltaX, float deltaY)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106027] trunk/LayoutTests
Title: [106027] trunk/LayoutTests Revision 106027 Author je...@webkit.org Date 2012-01-26 12:15:50 -0800 (Thu, 26 Jan 2012) Log Message Updating skipped tests after r105997. Unreviewed gardening. * platform/qt-4.8/Skipped: * platform/qt-5.0/Skipped: * platform/qt-wk2/Skipped: * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-4.8/Skipped trunk/LayoutTests/platform/qt-5.0/Skipped trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (106026 => 106027) --- trunk/LayoutTests/ChangeLog 2012-01-26 20:13:39 UTC (rev 106026) +++ trunk/LayoutTests/ChangeLog 2012-01-26 20:15:50 UTC (rev 106027) @@ -1,3 +1,14 @@ +2012-01-26 Jesus Sanchez-Palencia jesus.palen...@openbossa.org + +Updating skipped tests after r105997. + +Unreviewed gardening. + +* platform/qt-4.8/Skipped: +* platform/qt-5.0/Skipped: +* platform/qt-wk2/Skipped: +* platform/qt/Skipped: + 2012-01-26 Kelly Norton knor...@google.com [chromium] Unreviewed, rebaseline after http://trac.webkit.org/changeset/105613. Modified: trunk/LayoutTests/platform/qt/Skipped (106026 => 106027) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-26 20:13:39 UTC (rev 106026) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-26 20:15:50 UTC (rev 106027) @@ -203,7 +203,6 @@ # Hyphenation is not implemented yet. fast/text/hyphenate-character.html fast/text/hyphens.html -fast/text/soft-hyphen-4.html # https://bugs.webkit.org/show_bug.cgi?id=43332 inspector/debugger/dom-breakpoints.html @@ -374,7 +373,6 @@ editing/pasteboard/drag-drop-dead-frame.html editing/pasteboard/drag-drop-input-textarea.html editing/pasteboard/drag-drop-input-in-svg.svg -editing/pasteboard/drag-drop-iframe-refresh-crash.html editing/pasteboard/drag-drop-modifies-page.html editing/pasteboard/drag-drop-url-text.html editing/pasteboard/drop-file-svg.html @@ -389,7 +387,6 @@ editing/pasteboard/subframe-dragndrop-1.html editing/pasteboard/get-data-text-plain-drop.html editing/pasteboard/drop-text-events.html -editing/pasteboard/drop-text-events-sideeffect.html editing/pasteboard/drag-and-drop-image-contenteditable.html editing/pasteboard/drag-and-drop-inputimage-contenteditable.html editing/pasteboard/drag-and-drop-objectimage-contenteditable.html @@ -609,8 +606,6 @@ # = # # -- fail with --platform mac --ignore-metrics -editing/deleting/delete-block-table.html -editing/deleting/delete-ligature-001.html editing/deleting/delete-tab-001.html editing/deleting/delete-tab-002.html editing/deleting/delete-tab-003.html @@ -674,10 +669,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=68854 editing/selection/select-bidi-run.html -# [Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails -# https://bugs.webkit.org/show_bug.cgi?id=49127 -editing/selection/after-line-break.html - # REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and modify-up-on-rtl-wrapping-text.html fail on all but Mac platform # https://bugs.webkit.org/show_bug.cgi?id=50204 editing/selection/modify-up-on-rtl-wrapping-text.html @@ -1499,10 +1490,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=35973 fast/multicol/hit-test-above-or-below.html -# Not sure why this is failing on Qt. -# https://bugs.webkit.org/show_bug.cgi?id=37697 -fast/url/host.html - # -- fail with --platform mac --ignore-metrics fast/box-sizing/percentage-height.html fast/dom/focus-contenteditable.html @@ -1595,7 +1582,6 @@ fast/loader/text-document-wrapping.html fast/overflow/005.html fast/repaint/inline-outline-repaint.html -fast/text/find-case-folding.html fast/text/large-text-composed-char.html fast/text/basic/014.html fast/text/international/cjk-segmentation.html @@ -1853,7 +1839,6 @@ fast/text/international/bold-bengali.html fast/text/international/hebrew-vowels.html fast/text/international/plane2.html -fast/text/international/unicode-bidi-plaintext.html fast/text/international/vertical-text-glyph-test.html fast/text/international/vertical-text-metrics-test.html fast/writing-mode/japanese-ruby-horizontal-bt.html @@ -1875,13 +1860,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=41452 fast/dom/beforeload/remove-video-in-beforeload-listener.html -# [Qt] fast/text/bidi-explicit-embedding-past-end.html fails -# https://bugs.webkit.org/show_bug.cgi?id=41241 -fast/text/bidi-explicit-embedding-past-end.html - -# https://bugs.webkit.org/show_bug.cgi?id=45194 -fast/text/decomposed-after-stacked-diacritics.html - # [Qt] fast/text/emphasis-overlap.html fails # https://bugs.webkit.org/show_bug.cgi?id=51324 fast/text/emphasis-overlap.html @@ -2287,11 +2265,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=58741 fast/text/zero-width-characters-complex-script.html -# [Qt]fast/url/idna tests fail -#
[webkit-changes] [106028] trunk
Title: [106028] trunk
Revision 106028
Author commit-qu...@webkit.org
Date 2012-01-26 12:19:05 -0800 (Thu, 26 Jan 2012)
Log Message
[Qt][WK2] fast/loader tests failed after r94178
https://bugs.webkit.org/show_bug.cgi?id=67388
Patch by Luciano Wolf luciano.w...@openbossa.org on 2012-01-26
Reviewed by Simon Hausmann.
Tools:
Applying the same fix used for Qt-WebKit1 from bug #67254 -
[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67254
Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
derived from the running location of DumpRenderTree binary.
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
(WTR::LayoutTestController::pathToLocalResource):
LayoutTests:
Removing the following tests from skipped list:
fast/loader/local-CSS-from-local.html
fast/loader/local-_javascript_-from-local.html
fast/loader/local-image-from-local.html
* platform/qt-wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk2/Skipped
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (106027 => 106028)
--- trunk/LayoutTests/ChangeLog 2012-01-26 20:15:50 UTC (rev 106027)
+++ trunk/LayoutTests/ChangeLog 2012-01-26 20:19:05 UTC (rev 106028)
@@ -1,3 +1,17 @@
+2012-01-26 Luciano Wolf luciano.w...@openbossa.org
+
+[Qt][WK2] fast/loader tests failed after r94178
+https://bugs.webkit.org/show_bug.cgi?id=67388
+
+Reviewed by Simon Hausmann.
+
+Removing the following tests from skipped list:
+fast/loader/local-CSS-from-local.html
+fast/loader/local-_javascript_-from-local.html
+fast/loader/local-image-from-local.html
+
+* platform/qt-wk2/Skipped:
+
2012-01-26 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
Updating skipped tests after r105997.
Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (106027 => 106028)
--- trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-26 20:15:50 UTC (rev 106027)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-26 20:19:05 UTC (rev 106028)
@@ -250,12 +250,6 @@
# new failing tests
fast/events/mouseover-button.html
-# Tests failed after r94178
-# https://bugs.webkit.org/show_bug.cgi?id=67388
-fast/loader/local-CSS-from-local.html
-fast/loader/local-_javascript_-from-local.html
-fast/loader/local-image-from-local.html
-
# Missing layoutTestController.dumpResourceResponseMIMETypes()
# https://bugs.webkit.org/show_bug.cgi?id=67392
fast/preloader/document-write-noscript.html
Modified: trunk/Tools/ChangeLog (106027 => 106028)
--- trunk/Tools/ChangeLog 2012-01-26 20:15:50 UTC (rev 106027)
+++ trunk/Tools/ChangeLog 2012-01-26 20:19:05 UTC (rev 106028)
@@ -1,3 +1,19 @@
+2012-01-26 Luciano Wolf luciano.w...@openbossa.org
+
+[Qt][WK2] fast/loader tests failed after r94178
+https://bugs.webkit.org/show_bug.cgi?id=67388
+
+Reviewed by Simon Hausmann.
+
+Applying the same fix used for Qt-WebKit1 from bug #67254 -
+[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
+https://bugs.webkit.org/show_bug.cgi?id=67254
+Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
+derived from the running location of DumpRenderTree binary.
+
+* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
+(WTR::LayoutTestController::pathToLocalResource):
+
2012-01-26 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
Implement overridePreference for boolean preferences in WebKitTestRunner
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp (106027 => 106028)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp 2012-01-26 20:15:50 UTC (rev 106027)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp 2012-01-26 20:19:05 UTC (rev 106028)
@@ -29,6 +29,7 @@
#include ActivateFonts.h
#include InjectedBundle.h
+#include QCoreApplication
#include QDir
#include QFontDatabase
#include QObject
@@ -88,8 +89,21 @@
JSRetainPtrJSStringRef LayoutTestController::pathToLocalResource(JSStringRef url)
{
-QString path = QDir::toNativeSeparators(QString(reinterpret_castconst QChar*(JSStringGetCharactersPtr(url)), JSStringGetLength(url)));
-return JSStringCreateWithCharacters(reinterpret_castconst JSChar*(path.constData()), path.length());
+QString localTmpUrl(QStringLiteral(file:///tmp/LayoutTests));
+QString givenUrl(reinterpret_castconst QChar*(JSStringGetCharactersPtr(url)), JSStringGetLength(url));
+
+// Translate a request for /tmp/LayoutTests to the repository LayoutTests directory.
+// Do not rely on a symlink to be created via the test runner, which will not work on Windows.
+if
[webkit-changes] [106029] trunk/Source/WebCore
Title: [106029] trunk/Source/WebCore
Revision 106029
Author vange...@chromium.org
Date 2012-01-26 12:30:40 -0800 (Thu, 26 Jan 2012)
Log Message
Signal to skia to force A8 text from LCD output, but only when we have to disable LCD because we're in a layer
https://bugs.webkit.org/show_bug.cgi?id=76547
Patch by Mike Reed r...@google.com on 2012-01-26
Reviewed by Stephen White.
Existing tests should confirm nothing is broken. Antialiased text
is disabled in layouttests, so they should be unaffected by the
difference in antialiasing quality.
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::setupPaintForFont):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106028 => 106029)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 20:19:05 UTC (rev 106028)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 20:30:40 UTC (rev 106029)
@@ -1,3 +1,18 @@
+2012-01-26 Mike Reed r...@google.com
+
+Signal to skia to force A8 text from LCD output, but only when we have to disable LCD because we're in a layer
+https://bugs.webkit.org/show_bug.cgi?id=76547
+
+Reviewed by Stephen White.
+
+Existing tests should confirm nothing is broken. Antialiased text
+is disabled in layouttests, so they should be unaffected by the
+difference in antialiasing quality.
+
+* platform/graphics/skia/SkiaFontWin.cpp:
+(WebCore::setupPaintForFont):
+
+
2012-01-26 Anders Carlsson ander...@apple.com
Use PlatformWheelEvent::phase() to determine if a scroll gesture begins or ends
Modified: trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp (106028 => 106029)
--- trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2012-01-26 20:19:05 UTC (rev 106028)
+++ trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2012-01-26 20:30:40 UTC (rev 106029)
@@ -205,12 +205,24 @@
textFlags = getDefaultGDITextFlags();
// do this check after our switch on lfQuality
-if (disableTextLCD(pcs))
+if (disableTextLCD(pcs)) {
textFlags = ~SkPaint::kLCDRenderText_Flag;
+// If we *just* clear our request for LCD, then GDI seems to
+// sometimes give us AA text, and sometimes give us BW text. Since the
+// original intent was LCD, we want to force AA (rather than BW), so we
+// add a special bit to tell Skia to do its best to avoid the BW: by
+// drawing LCD offscreen and downsampling that to AA.
+textFlags |= SkPaint::kGenA8FromLCD_Flag;
+}
+static const uint32_t textFlagsMask = SkPaint::kAntiAlias_Flag |
+ SkPaint::kLCDRenderText_Flag |
+ SkPaint::kGenA8FromLCD_Flag;
+
// now copy in just the text flags
+SkASSERT(!(textFlags ~textFlagsMask));
uint32_t flags = paint-getFlags();
-flags = ~(SkPaint::kAntiAlias_Flag | SkPaint::kLCDRenderText_Flag);
+flags = ~textFlagsMask;
flags |= textFlags;
paint-setFlags(flags);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106031] trunk/Source/WebCore
Title: [106031] trunk/Source/WebCore
Revision 106031
Author ander...@apple.com
Date 2012-01-26 12:46:15 -0800 (Thu, 26 Jan 2012)
Log Message
Simplify checking for whether we should rubberband or not when at the edge
https://bugs.webkit.org/show_bug.cgi?id=77131
Reviewed by Beth Dakin.
We only need to check once if we're pinned at either edge whether we should rubber-band
or not. Do this when the wheel event phase is PlatformWheelEventPhaseBegan. This lets us
remove a bunch of code that would keep track of the current horizontal scroll direction.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106030 => 106031)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 20:39:06 UTC (rev 106030)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 20:46:15 UTC (rev 106031)
@@ -1,3 +1,21 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+Simplify checking for whether we should rubberband or not when at the edge
+https://bugs.webkit.org/show_bug.cgi?id=77131
+
+Reviewed by Beth Dakin.
+
+We only need to check once if we're pinned at either edge whether we should rubber-band
+or not. Do this when the wheel event phase is PlatformWheelEventPhaseBegan. This lets us
+remove a bunch of code that would keep track of the current horizontal scroll direction.
+
+* platform/mac/ScrollAnimatorMac.h:
+(ScrollAnimatorMac):
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+(WebCore::ScrollAnimatorMac::beginScrollGesture):
+
2012-01-26 Eli Fidler efid...@rim.com
[JSC] Inspector instrumentation for _javascript_ calls.
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h (106030 => 106031)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 20:39:06 UTC (rev 106030)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 20:46:15 UTC (rev 106031)
@@ -138,11 +138,6 @@
ScrollElasticityController m_scrollElasticityController;
TimerScrollAnimatorMac m_snapRubberBandTimer;
-
-bool m_scrollerInitiallyPinnedOnLeft;
-bool m_scrollerInitiallyPinnedOnRight;
-int m_cumulativeHorizontalScroll;
-bool m_didCumulativeHorizontalScrollEverSwitchToOppositeDirectionOfPin;
#endif
bool m_haveScrolledSincePageLoad;
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106030 => 106031)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 20:39:06 UTC (rev 106030)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 20:46:15 UTC (rev 106031)
@@ -553,10 +553,6 @@
#if ENABLE(RUBBER_BANDING)
, m_scrollElasticityController(this)
, m_snapRubberBandTimer(this, ScrollAnimatorMac::snapRubberBandTimerFired)
-, m_scrollerInitiallyPinnedOnLeft(false)
-, m_scrollerInitiallyPinnedOnRight(false)
-, m_cumulativeHorizontalScroll(0)
-, m_didCumulativeHorizontalScrollEverSwitchToOppositeDirectionOfPin(false)
#endif
, m_haveScrolledSincePageLoad(false)
, m_needsScrollerStyleUpdate(false)
@@ -920,39 +916,20 @@
} else {
if (!allowsHorizontalStretching())
return ScrollAnimator::handleWheelEvent(wheelEvent);
-
-if (m_scrollableArea-horizontalScrollbar()) {
-// If there is a scrollbar, we aggregate the wheel events to get an
-// overall trend of the scroll. If the direction of the scroll is ever
-// in the opposite direction of the pin location, then we switch the
-// boolean, and rubber band. That is, if we were pinned to the left,
-// and we ended up scrolling to the right, we rubber band.
-m_cumulativeHorizontalScroll += wheelEvent.deltaX();
-if (m_scrollerInitiallyPinnedOnLeft m_cumulativeHorizontalScroll 0)
-m_didCumulativeHorizontalScrollEverSwitchToOppositeDirectionOfPin = true;
-if (m_scrollerInitiallyPinnedOnRight m_cumulativeHorizontalScroll 0)
-m_didCumulativeHorizontalScrollEverSwitchToOppositeDirectionOfPin = true;
-}
-
-// After a gesture begins, we go through:
-// 1+ PlatformWheelEventPhaseNone
-// 0+ PlatformWheelEventPhaseChanged
-// 1 PlatformWheelEventPhaseEnded if there was at least one changed event
-if (wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone !m_didCumulativeHorizontalScrollEverSwitchToOppositeDirectionOfPin) {
-if
[webkit-changes] [106032] trunk/Source/WebCore
Title: [106032] trunk/Source/WebCore
Revision 106032
Author ander...@apple.com
Date 2012-01-26 12:56:17 -0800 (Thu, 26 Jan 2012)
Log Message
No need to set m_haveScrolledSincePageLoad in beginScrollGesture
https://bugs.webkit.org/show_bug.cgi?id=77132
Reviewed by Andreas Kling.
m_haveScrolledSincePageLoad is already set to true in handleWheelEvent so we don't need
to set it to true again.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::beginScrollGesture):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106031 => 106032)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 20:46:15 UTC (rev 106031)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 20:56:17 UTC (rev 106032)
@@ -1,5 +1,18 @@
2012-01-26 Anders Carlsson ander...@apple.com
+No need to set m_haveScrolledSincePageLoad in beginScrollGesture
+https://bugs.webkit.org/show_bug.cgi?id=77132
+
+Reviewed by Andreas Kling.
+
+m_haveScrolledSincePageLoad is already set to true in handleWheelEvent so we don't need
+to set it to true again.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::beginScrollGesture):
+
+2012-01-26 Anders Carlsson ander...@apple.com
+
Simplify checking for whether we should rubberband or not when at the edge
https://bugs.webkit.org/show_bug.cgi?id=77131
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106031 => 106032)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 20:46:15 UTC (rev 106031)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 20:56:17 UTC (rev 106032)
@@ -1065,8 +1065,6 @@
{
didBeginScrollGesture();
-m_haveScrolledSincePageLoad = true;
-
m_scrollElasticityController.beginScrollGesture();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106033] trunk/Source/WebCore
Title: [106033] trunk/Source/WebCore
Revision 106033
Author ander...@apple.com
Date 2012-01-26 13:08:45 -0800 (Thu, 26 Jan 2012)
Log Message
Inline beginScrollGesture/endScrollGesture in handleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=77133
Reviewed by Andreas Kling.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106032 => 106033)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 20:56:17 UTC (rev 106032)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 21:08:45 UTC (rev 106033)
@@ -1,5 +1,17 @@
2012-01-26 Anders Carlsson ander...@apple.com
+Inline beginScrollGesture/endScrollGesture in handleWheelEvent
+https://bugs.webkit.org/show_bug.cgi?id=77133
+
+Reviewed by Andreas Kling.
+
+* platform/mac/ScrollAnimatorMac.h:
+(ScrollAnimatorMac):
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+
+2012-01-26 Anders Carlsson ander...@apple.com
+
No need to set m_haveScrolledSincePageLoad in beginScrollGesture
https://bugs.webkit.org/show_bug.cgi?id=77132
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h (106032 => 106033)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 20:56:17 UTC (rev 106032)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 21:08:45 UTC (rev 106033)
@@ -133,8 +133,6 @@
bool pinnedInDirection(float deltaX, float deltaY);
void snapRubberBandTimerFired(TimerScrollAnimatorMac*);
-void beginScrollGesture();
-void endScrollGesture();
ScrollElasticityController m_scrollElasticityController;
TimerScrollAnimatorMac m_snapRubberBandTimer;
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106032 => 106033)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 20:56:17 UTC (rev 106032)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 21:08:45 UTC (rev 106033)
@@ -927,11 +927,11 @@
isScrollingRightAndShouldNotRubberBand(wheelEvent, m_scrollableArea))
return false;
-// We don't return after this because we still want the scroll elasticity controller to handle the wheel event.
-beginScrollGesture();
-
+didBeginScrollGesture();
+m_scrollElasticityController.beginScrollGesture();
} else if (wheelEvent.phase() == PlatformWheelEventPhaseEnded) {
-endScrollGesture();
+didEndScrollGesture();
+m_scrollElasticityController.endScrollGesture();
return true;
}
@@ -1061,20 +1061,6 @@
m_snapRubberBandTimer.stop();
}
-void ScrollAnimatorMac::beginScrollGesture()
-{
-didBeginScrollGesture();
-
-m_scrollElasticityController.beginScrollGesture();
-}
-
-void ScrollAnimatorMac::endScrollGesture()
-{
-didEndScrollGesture();
-
-m_scrollElasticityController.endScrollGesture();
-}
-
void ScrollAnimatorMac::snapRubberBandTimerFired(TimerScrollAnimatorMac*)
{
m_scrollElasticityController.snapRubberBandTimerFired();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106034] trunk/Source/WebKit/chromium
Title: [106034] trunk/Source/WebKit/chromium
Revision 106034
Author commit-qu...@webkit.org
Date 2012-01-26 13:17:34 -0800 (Thu, 26 Jan 2012)
Log Message
Roll chromium_rev to 119248
https://bugs.webkit.org/show_bug.cgi?id=77124
Patch by John Bates jba...@google.com on 2012-01-26
Reviewed by James Robinson.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106033 => 106034)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-26 21:08:45 UTC (rev 106033)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-26 21:17:34 UTC (rev 106034)
@@ -1,3 +1,12 @@
+2012-01-26 John Bates jba...@google.com
+
+Roll chromium_rev to 119248
+https://bugs.webkit.org/show_bug.cgi?id=77124
+
+Reviewed by James Robinson.
+
+* DEPS:
+
2012-01-25 Greg Billock gbill...@google.com
Add IntentRequest include for FrameLoaderClientImpl.
Modified: trunk/Source/WebKit/chromium/DEPS (106033 => 106034)
--- trunk/Source/WebKit/chromium/DEPS 2012-01-26 21:08:45 UTC (rev 106033)
+++ trunk/Source/WebKit/chromium/DEPS 2012-01-26 21:17:34 UTC (rev 106034)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '118722'
+ 'chromium_rev': '119248'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106035] trunk/Tools
Title: [106035] trunk/Tools Revision 106035 Author o...@chromium.org Date 2012-01-26 13:26:06 -0800 (Thu, 26 Jan 2012) Log Message Only store the SVN revision in the summarized results if we're on a builder https://bugs.webkit.org/show_bug.cgi?id=76976 Reviewed by Dirk Pranke. This shaves another ~130ms off the single test run-webkit-tests runtime. * Scripts/webkitpy/layout_tests/controllers/manager.py: (summarize_results): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ResultSummaryTest.get_result): (ResultSummaryTest): (ResultSummaryTest.get_result_summary): (ResultSummaryTest.get_unexpected_results): (ResultSummaryTest.test_no_svn_revision): (ResultSummaryTest.test_svn_revision): * Scripts/webkitpy/layout_tests/port/base.py: (Port.use_trac_links_in_results_html): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py Diff Modified: trunk/Tools/ChangeLog (106034 => 106035) --- trunk/Tools/ChangeLog 2012-01-26 21:17:34 UTC (rev 106034) +++ trunk/Tools/ChangeLog 2012-01-26 21:26:06 UTC (rev 106035) @@ -1,3 +1,24 @@ +2012-01-25 Ojan Vafai o...@chromium.org + +Only store the SVN revision in the summarized results if we're on a builder +https://bugs.webkit.org/show_bug.cgi?id=76976 + +Reviewed by Dirk Pranke. + +This shaves another ~130ms off the single test run-webkit-tests runtime. + +* Scripts/webkitpy/layout_tests/controllers/manager.py: +(summarize_results): +* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: +(ResultSummaryTest.get_result): +(ResultSummaryTest): +(ResultSummaryTest.get_result_summary): +(ResultSummaryTest.get_unexpected_results): +(ResultSummaryTest.test_no_svn_revision): +(ResultSummaryTest.test_svn_revision): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.use_trac_links_in_results_html): + 2012-01-26 Luciano Wolf luciano.w...@openbossa.org [Qt][WK2] fast/loader tests failed after r94178 Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (106034 => 106035) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-01-26 21:17:34 UTC (rev 106034) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-01-26 21:26:06 UTC (rev 106035) @@ -102,6 +102,11 @@ return test_dict +def use_trac_links_in_results_html(port_obj): +# We only use trac links on the buildbots. +# Use existence of builder_name as a proxy for knowing we're on a bot. +return port_obj.get_option(builder_name) + # FIXME: This should be on the Manager class (since that's the only caller) # or split off from Manager onto another helper class, but should not be a free function. # Most likely this should be made into its own class, and this super-long function @@ -228,7 +233,10 @@ results['has_wdiff'] = port_obj.wdiff_available() results['has_pretty_patch'] = port_obj.pretty_patch_available() try: -results['revision'] = port_obj.host.scm().head_svn_revision() +# We only use the svn revision for using trac links in the results.html file, +# Don't do this by default since it takes 100ms. +if use_trac_links_in_results_html(port_obj): +results['revision'] = port_obj.host.scm().head_svn_revision() except Exception, e: _log.warn(Failed to determine svn revision for checkout (cwd: %s, webkit_base: %s), leaving 'revision' key blank in full_results.json.\n%s % (port_obj._filesystem.getcwd(), port_obj.path_from_webkit_base(), e)) # Handle cases where we're running outside of version control. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py (106034 => 106035) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py 2012-01-26 21:17:34 UTC (rev 106034) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py 2012-01-26 21:26:06 UTC (rev 106035) @@ -42,8 +42,12 @@ from webkitpy import layout_tests from webkitpy.layout_tests import run_webkit_tests +from webkitpy.layout_tests.controllers import manager from webkitpy.layout_tests.controllers.manager import interpret_test_failures, Manager, natural_sort_key, test_key, TestRunInterruptedException, TestShard +from webkitpy.layout_tests.models import result_summary +from webkitpy.layout_tests.models import test_expectations from webkitpy.layout_tests.models import test_failures +from webkitpy.layout_tests.models import test_results from webkitpy.layout_tests.models.result_summary import ResultSummary from webkitpy.layout_tests.models.test_expectations import TestExpectations from webkitpy.layout_tests.models.test_results import TestResult @@ -370,6 +374,56 @@ self.assertTrue(test_dict['is_mismatch_reftest'])
[webkit-changes] [106036] trunk
Title: [106036] trunk Revision 106036 Author infe...@chromium.org Date 2012-01-26 13:35:44 -0800 (Thu, 26 Jan 2012) Log Message Crash in SVGSVGElement::currentViewBoxRect. https://bugs.webkit.org/show_bug.cgi?id=77121 Reviewed by Nikolas Zimmermann. Source/WebCore: Symbols shouldn't be rendered. Revert the ASSERT from r105513 into a hard check. Test: svg/custom/symbol-viewport-element-crash.svg * svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport): LayoutTests: * svg/custom/symbol-viewport-element-crash-expected.txt: Added. * svg/custom/symbol-viewport-element-crash.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGLengthContext.cpp Added Paths trunk/LayoutTests/svg/custom/symbol-viewport-element-crash-expected.txt trunk/LayoutTests/svg/custom/symbol-viewport-element-crash.svg Diff Modified: trunk/LayoutTests/ChangeLog (106035 => 106036) --- trunk/LayoutTests/ChangeLog 2012-01-26 21:26:06 UTC (rev 106035) +++ trunk/LayoutTests/ChangeLog 2012-01-26 21:35:44 UTC (rev 106036) @@ -1,3 +1,13 @@ +2012-01-26 Abhishek Arya infe...@chromium.org + +Crash in SVGSVGElement::currentViewBoxRect. +https://bugs.webkit.org/show_bug.cgi?id=77121 + +Reviewed by Nikolas Zimmermann. + +* svg/custom/symbol-viewport-element-crash-expected.txt: Added. +* svg/custom/symbol-viewport-element-crash.svg: Added. + 2012-01-26 Eli Fidler efid...@rim.com [JSC] Inspector instrumentation for _javascript_ calls. Added: trunk/LayoutTests/svg/custom/symbol-viewport-element-crash-expected.txt (0 => 106036) --- trunk/LayoutTests/svg/custom/symbol-viewport-element-crash-expected.txt (rev 0) +++ trunk/LayoutTests/svg/custom/symbol-viewport-element-crash-expected.txt 2012-01-26 21:35:44 UTC (rev 106036) @@ -0,0 +1 @@ +This test passes if it did not crash Added: trunk/LayoutTests/svg/custom/symbol-viewport-element-crash.svg (0 => 106036) --- trunk/LayoutTests/svg/custom/symbol-viewport-element-crash.svg (rev 0) +++ trunk/LayoutTests/svg/custom/symbol-viewport-element-crash.svg 2012-01-26 21:35:44 UTC (rev 106036) @@ -0,0 +1,14 @@ +svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink + use +symbol + rect +animate attributeName=width to=0%/animate + /rect +/symbol + /use + script +if (window.layoutTestController) +layoutTestController.dumpAsText(); + /script + text x=10px y=100pxThis test passes if it did not crash/text +/svg \ No newline at end of file Property changes on: trunk/LayoutTests/svg/custom/symbol-viewport-element-crash.svg ___ Added: svn:executable Modified: trunk/Source/WebCore/ChangeLog (106035 => 106036) --- trunk/Source/WebCore/ChangeLog 2012-01-26 21:26:06 UTC (rev 106035) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 21:35:44 UTC (rev 106036) @@ -1,3 +1,18 @@ +2012-01-26 Abhishek Arya infe...@chromium.org + +Crash in SVGSVGElement::currentViewBoxRect. +https://bugs.webkit.org/show_bug.cgi?id=77121 + +Reviewed by Nikolas Zimmermann. + +Symbols shouldn't be rendered. Revert the ASSERT +from r105513 into a hard check. + +Test: svg/custom/symbol-viewport-element-crash.svg + +* svg/SVGLengthContext.cpp: +(WebCore::SVGLengthContext::determineViewport): + 2012-01-26 Anders Carlsson ander...@apple.com Inline beginScrollGesture/endScrollGesture in handleWheelEvent Modified: trunk/Source/WebCore/svg/SVGLengthContext.cpp (106035 => 106036) --- trunk/Source/WebCore/svg/SVGLengthContext.cpp 2012-01-26 21:26:06 UTC (rev 106035) +++ trunk/Source/WebCore/svg/SVGLengthContext.cpp 2012-01-26 21:35:44 UTC (rev 106036) @@ -282,10 +282,9 @@ // Take size from nearest viewport element. SVGElement* viewportElement = m_context-viewportElement(); -if (!viewportElement) +if (!viewportElement || !viewportElement-isSVG()) return false; -ASSERT(viewportElement-isSVG()); const SVGSVGElement* svg = static_castconst SVGSVGElement*(viewportElement); FloatSize viewportSize = svg-currentViewBoxRect().size(); if (viewportSize.isEmpty()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106037] trunk/Source/WebCore
Title: [106037] trunk/Source/WebCore
Revision 106037
Author ander...@apple.com
Date 2012-01-26 13:38:19 -0800 (Thu, 26 Jan 2012)
Log Message
Get rid of ScrollElasticityController::endScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=77134
Reviewed by Adam Roben.
Just make ScrollElasticityController::handleWheelEvent call snapRubberBand if the wheel
event phase is PlatformWheelEventPhaseEnded.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
* platform/mac/ScrollElasticityController.h:
(ScrollElasticityController):
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::handleWheelEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
trunk/Source/WebCore/platform/mac/ScrollElasticityController.h
trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106036 => 106037)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 21:35:44 UTC (rev 106036)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 21:38:19 UTC (rev 106037)
@@ -1,3 +1,20 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+Get rid of ScrollElasticityController::endScrollGesture()
+https://bugs.webkit.org/show_bug.cgi?id=77134
+
+Reviewed by Adam Roben.
+
+Just make ScrollElasticityController::handleWheelEvent call snapRubberBand if the wheel
+event phase is PlatformWheelEventPhaseEnded.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+* platform/mac/ScrollElasticityController.h:
+(ScrollElasticityController):
+* platform/mac/ScrollElasticityController.mm:
+(WebCore::ScrollElasticityController::handleWheelEvent):
+
2012-01-26 Abhishek Arya infe...@chromium.org
Crash in SVGSVGElement::currentViewBoxRect.
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106036 => 106037)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 21:35:44 UTC (rev 106036)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 21:38:19 UTC (rev 106037)
@@ -929,11 +929,8 @@
didBeginScrollGesture();
m_scrollElasticityController.beginScrollGesture();
-} else if (wheelEvent.phase() == PlatformWheelEventPhaseEnded) {
+} else if (wheelEvent.phase() == PlatformWheelEventPhaseEnded)
didEndScrollGesture();
-m_scrollElasticityController.endScrollGesture();
-return true;
-}
return m_scrollElasticityController.handleWheelEvent(wheelEvent);
}
Modified: trunk/Source/WebCore/platform/mac/ScrollElasticityController.h (106036 => 106037)
--- trunk/Source/WebCore/platform/mac/ScrollElasticityController.h 2012-01-26 21:35:44 UTC (rev 106036)
+++ trunk/Source/WebCore/platform/mac/ScrollElasticityController.h 2012-01-26 21:38:19 UTC (rev 106037)
@@ -64,7 +64,6 @@
explicit ScrollElasticityController(ScrollElasticityControllerClient*);
void beginScrollGesture();
-void endScrollGesture();
bool handleWheelEvent(const PlatformWheelEvent);
void snapRubberBandTimerFired();
Modified: trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm (106036 => 106037)
--- trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm 2012-01-26 21:35:44 UTC (rev 106036)
+++ trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm 2012-01-26 21:38:19 UTC (rev 106037)
@@ -132,11 +132,6 @@
stopSnapRubberbandTimer();
}
-void ScrollElasticityController::endScrollGesture()
-{
-snapRubberBand();
-}
-
bool ScrollElasticityController::handleWheelEvent(const PlatformWheelEvent wheelEvent)
{
bool isMomentumScrollEvent = (wheelEvent.momentumPhase() != PlatformWheelEventPhaseNone);
@@ -148,6 +143,11 @@
return false;
}
+if (wheelEvent.phase() == PlatformWheelEventPhaseEnded) {
+snapRubberBand();
+return true;
+}
+
float deltaX = m_overflowScrollDelta.width();
float deltaY = m_overflowScrollDelta.height();
@@ -175,10 +175,10 @@
isHorizontallyStretched = stretchAmount.width();
isVerticallyStretched = stretchAmount.height();
-PlatformWheelEventPhase phase = wheelEvent.momentumPhase();
+PlatformWheelEventPhase momentumPhase = wheelEvent.momentumPhase();
// If we are starting momentum scrolling then do some setup.
-if (!m_momentumScrollInProgress (phase == PlatformWheelEventPhaseBegan || phase == PlatformWheelEventPhaseChanged))
+if (!m_momentumScrollInProgress (momentumPhase == PlatformWheelEventPhaseBegan || momentumPhase == PlatformWheelEventPhaseChanged))
m_momentumScrollInProgress = true;
CFTimeInterval timeDelta = wheelEvent.timestamp() - m_lastMomentumScrollTimestamp;
@@ -279,7 +279,7 @@
}
}
-if (m_momentumScrollInProgress phase == PlatformWheelEventPhaseEnded) {
+if
[webkit-changes] [106038] trunk/Tools
Title: [106038] trunk/Tools Revision 106038 Author o...@chromium.org Date 2012-01-26 13:46:36 -0800 (Thu, 26 Jan 2012) Log Message Parsing test_expecations.txt + Skipped lists takes too long https://bugs.webkit.org/show_bug.cgi?id=77059 Reviewed by Dirk Pranke. This saves ~100ms on the Apple Mac port. -memoize a bunch of path methods. -Avoid doing multiple disk accesses per line. -Parse the skipped list directly instead of turning it into a test_expecations.txt formatting string and parsing that. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser): (TestExpectationParser.parse_skipped_tests): (TestExpectationParser._parse_line): (TestExpectationParser._collect_matching_tests): (TestExpectations.__init__): (TestExpectations._add_skipped_tests): * Scripts/webkitpy/layout_tests/port/base.py: (Port): (Port.test_isfile): (Port.normalize_test_name): (Port.layout_tests_dir): (Port.abspath_for_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py Diff Modified: trunk/Tools/ChangeLog (106037 => 106038) --- trunk/Tools/ChangeLog 2012-01-26 21:38:19 UTC (rev 106037) +++ trunk/Tools/ChangeLog 2012-01-26 21:46:36 UTC (rev 106038) @@ -1,5 +1,32 @@ 2012-01-25 Ojan Vafai o...@chromium.org +Parsing test_expecations.txt + Skipped lists takes too long +https://bugs.webkit.org/show_bug.cgi?id=77059 + +Reviewed by Dirk Pranke. + +This saves ~100ms on the Apple Mac port. +-memoize a bunch of path methods. +-Avoid doing multiple disk accesses per line. +-Parse the skipped list directly instead of turning it into a test_expecations.txt +formatting string and parsing that. + +* Scripts/webkitpy/layout_tests/models/test_expectations.py: +(TestExpectationParser): +(TestExpectationParser.parse_skipped_tests): +(TestExpectationParser._parse_line): +(TestExpectationParser._collect_matching_tests): +(TestExpectations.__init__): +(TestExpectations._add_skipped_tests): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port): +(Port.test_isfile): +(Port.normalize_test_name): +(Port.layout_tests_dir): +(Port.abspath_for_test): + +2012-01-25 Ojan Vafai o...@chromium.org + Only store the SVN revision in the summarized results if we're on a builder https://bugs.webkit.org/show_bug.cgi?id=76976 Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (106037 => 106038) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-01-26 21:38:19 UTC (rev 106037) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-01-26 21:46:36 UTC (rev 106038) @@ -187,6 +187,7 @@ BUG_MODIFIER_PREFIX = 'bug' BUG_MODIFIER_REGEX = 'bug\d+' REBASELINE_MODIFIER = 'rebaseline' +FAIL_EXPECTATION = 'fail' SKIP_MODIFIER = 'skip' SLOW_MODIFIER = 'slow' WONTFIX_MODIFIER = 'wontfix' @@ -205,15 +206,30 @@ self._parse_line(expectation_line) return expectations +def expectation_for_skipped_test(self, test_name): +expectation_line = TestExpectationLine() +expectation_line.original_string = test_name +expectation_line.modifiers = [TestExpectationParser.SKIP_MODIFIER] +expectation_line.name = test_name +expectation_line.expectations = [TestExpectationParser.FAIL_EXPECTATION] +self._parse_line(expectation_line) +return expectation_line + def _parse_line(self, expectation_line): if not expectation_line.name: return self._check_modifiers_against_expectations(expectation_line) -if self._check_path_does_not_exist(expectation_line): + +expectation_line.is_file = self._port.test_isfile(expectation_line.name) +if not expectation_line.is_file and self._check_path_does_not_exist(expectation_line): return -expectation_line.path = self._port.normalize_test_name(expectation_line.name) +if expectation_line.is_file: +expectation_line.path = expectation_line.name +else: +expectation_line.path = self._port.normalize_test_name(expectation_line.name) + self._collect_matching_tests(expectation_line) self._parse_modifiers(expectation_line) @@ -285,7 +301,7 @@ expectation_line.matching_tests = [expectation_line.path] return -if self._port.test_isdir(expectation_line.path): +if not expectation_line.is_file: # this is a test category, return all the tests of the category. expectation_line.matching_tests = [test for test in self._full_test_list if test.startswith(expectation_line.path)] return @@ -702,7 +718,6 @@ self._model =
[webkit-changes] [106039] trunk/Source/WebCore
Title: [106039] trunk/Source/WebCore
Revision 106039
Author ander...@apple.com
Date 2012-01-26 14:10:53 -0800 (Thu, 26 Jan 2012)
Log Message
Get rid of ScrollElasticityController::beginScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=77138
Reviewed by Adam Roben.
ScrollElasticityController::handleWheelEvent now checks if the wheel event phase is
PlatformWheelEventPhaseBegan and sets up the gesture state if it is.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
* platform/mac/ScrollElasticityController.h:
(ScrollElasticityController):
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::handleWheelEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
trunk/Source/WebCore/platform/mac/ScrollElasticityController.h
trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106038 => 106039)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 21:46:36 UTC (rev 106038)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 22:10:53 UTC (rev 106039)
@@ -1,5 +1,22 @@
2012-01-26 Anders Carlsson ander...@apple.com
+Get rid of ScrollElasticityController::beginScrollGesture()
+https://bugs.webkit.org/show_bug.cgi?id=77138
+
+Reviewed by Adam Roben.
+
+ScrollElasticityController::handleWheelEvent now checks if the wheel event phase is
+PlatformWheelEventPhaseBegan and sets up the gesture state if it is.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+* platform/mac/ScrollElasticityController.h:
+(ScrollElasticityController):
+* platform/mac/ScrollElasticityController.mm:
+(WebCore::ScrollElasticityController::handleWheelEvent):
+
+2012-01-26 Anders Carlsson ander...@apple.com
+
Get rid of ScrollElasticityController::endScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=77134
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106038 => 106039)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 21:46:36 UTC (rev 106038)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 22:10:53 UTC (rev 106039)
@@ -928,7 +928,6 @@
return false;
didBeginScrollGesture();
-m_scrollElasticityController.beginScrollGesture();
} else if (wheelEvent.phase() == PlatformWheelEventPhaseEnded)
didEndScrollGesture();
Modified: trunk/Source/WebCore/platform/mac/ScrollElasticityController.h (106038 => 106039)
--- trunk/Source/WebCore/platform/mac/ScrollElasticityController.h 2012-01-26 21:46:36 UTC (rev 106038)
+++ trunk/Source/WebCore/platform/mac/ScrollElasticityController.h 2012-01-26 22:10:53 UTC (rev 106039)
@@ -63,8 +63,6 @@
public:
explicit ScrollElasticityController(ScrollElasticityControllerClient*);
-void beginScrollGesture();
-
bool handleWheelEvent(const PlatformWheelEvent);
void snapRubberBandTimerFired();
Modified: trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm (106038 => 106039)
--- trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm 2012-01-26 21:46:36 UTC (rev 106038)
+++ trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm 2012-01-26 22:10:53 UTC (rev 106039)
@@ -115,23 +115,6 @@
{
}
-void ScrollElasticityController::beginScrollGesture()
-{
-m_inScrollGesture = true;
-m_momentumScrollInProgress = false;
-m_ignoreMomentumScrolls = false;
-m_lastMomentumScrollTimestamp = 0;
-m_momentumVelocity = FloatSize();
-
-IntSize stretchAmount = m_client-stretchAmount();
-m_stretchScrollForce.setWidth(reboundDeltaForElasticDelta(stretchAmount.width()));
-m_stretchScrollForce.setHeight(reboundDeltaForElasticDelta(stretchAmount.height()));
-
-m_overflowScrollDelta = FloatSize();
-
-stopSnapRubberbandTimer();
-}
-
bool ScrollElasticityController::handleWheelEvent(const PlatformWheelEvent wheelEvent)
{
bool isMomentumScrollEvent = (wheelEvent.momentumPhase() != PlatformWheelEventPhaseNone);
@@ -143,6 +126,23 @@
return false;
}
+if (wheelEvent.phase() == PlatformWheelEventPhaseBegan) {
+m_inScrollGesture = true;
+m_momentumScrollInProgress = false;
+m_ignoreMomentumScrolls = false;
+m_lastMomentumScrollTimestamp = 0;
+m_momentumVelocity = FloatSize();
+
+IntSize stretchAmount = m_client-stretchAmount();
+m_stretchScrollForce.setWidth(reboundDeltaForElasticDelta(stretchAmount.width()));
+m_stretchScrollForce.setHeight(reboundDeltaForElasticDelta(stretchAmount.height()));
+m_overflowScrollDelta = FloatSize();
+
+stopSnapRubberbandTimer();
+
+return true;
+}
+
if (wheelEvent.phase() == PlatformWheelEventPhaseEnded) {
snapRubberBand();
return true;
[webkit-changes] [106040] trunk/LayoutTests
Title: [106040] trunk/LayoutTests Revision 106040 Author commit-qu...@webkit.org Date 2012-01-26 14:10:59 -0800 (Thu, 26 Jan 2012) Log Message Unreviewed, rolling out r106027. http://trac.webkit.org/changeset/106027 https://bugs.webkit.org/show_bug.cgi?id=77139 It messed up Qt5 buildbots. (Requested by jeez_ on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-26 * platform/qt-4.8/Skipped: * platform/qt-5.0/Skipped: * platform/qt-wk2/Skipped: * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-4.8/Skipped trunk/LayoutTests/platform/qt-5.0/Skipped trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (106039 => 106040) --- trunk/LayoutTests/ChangeLog 2012-01-26 22:10:53 UTC (rev 106039) +++ trunk/LayoutTests/ChangeLog 2012-01-26 22:10:59 UTC (rev 106040) @@ -1,3 +1,16 @@ +2012-01-26 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r106027. +http://trac.webkit.org/changeset/106027 +https://bugs.webkit.org/show_bug.cgi?id=77139 + +It messed up Qt5 buildbots. (Requested by jeez_ on #webkit). + +* platform/qt-4.8/Skipped: +* platform/qt-5.0/Skipped: +* platform/qt-wk2/Skipped: +* platform/qt/Skipped: + 2012-01-26 Abhishek Arya infe...@chromium.org Crash in SVGSVGElement::currentViewBoxRect. Modified: trunk/LayoutTests/platform/qt/Skipped (106039 => 106040) --- trunk/LayoutTests/platform/qt/Skipped 2012-01-26 22:10:53 UTC (rev 106039) +++ trunk/LayoutTests/platform/qt/Skipped 2012-01-26 22:10:59 UTC (rev 106040) @@ -203,6 +203,7 @@ # Hyphenation is not implemented yet. fast/text/hyphenate-character.html fast/text/hyphens.html +fast/text/soft-hyphen-4.html # https://bugs.webkit.org/show_bug.cgi?id=43332 inspector/debugger/dom-breakpoints.html @@ -373,6 +374,7 @@ editing/pasteboard/drag-drop-dead-frame.html editing/pasteboard/drag-drop-input-textarea.html editing/pasteboard/drag-drop-input-in-svg.svg +editing/pasteboard/drag-drop-iframe-refresh-crash.html editing/pasteboard/drag-drop-modifies-page.html editing/pasteboard/drag-drop-url-text.html editing/pasteboard/drop-file-svg.html @@ -387,6 +389,7 @@ editing/pasteboard/subframe-dragndrop-1.html editing/pasteboard/get-data-text-plain-drop.html editing/pasteboard/drop-text-events.html +editing/pasteboard/drop-text-events-sideeffect.html editing/pasteboard/drag-and-drop-image-contenteditable.html editing/pasteboard/drag-and-drop-inputimage-contenteditable.html editing/pasteboard/drag-and-drop-objectimage-contenteditable.html @@ -606,6 +609,8 @@ # = # # -- fail with --platform mac --ignore-metrics +editing/deleting/delete-block-table.html +editing/deleting/delete-ligature-001.html editing/deleting/delete-tab-001.html editing/deleting/delete-tab-002.html editing/deleting/delete-tab-003.html @@ -669,6 +674,10 @@ # https://bugs.webkit.org/show_bug.cgi?id=68854 editing/selection/select-bidi-run.html +# [Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails +# https://bugs.webkit.org/show_bug.cgi?id=49127 +editing/selection/after-line-break.html + # REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and modify-up-on-rtl-wrapping-text.html fail on all but Mac platform # https://bugs.webkit.org/show_bug.cgi?id=50204 editing/selection/modify-up-on-rtl-wrapping-text.html @@ -1490,6 +1499,10 @@ # https://bugs.webkit.org/show_bug.cgi?id=35973 fast/multicol/hit-test-above-or-below.html +# Not sure why this is failing on Qt. +# https://bugs.webkit.org/show_bug.cgi?id=37697 +fast/url/host.html + # -- fail with --platform mac --ignore-metrics fast/box-sizing/percentage-height.html fast/dom/focus-contenteditable.html @@ -1582,6 +1595,7 @@ fast/loader/text-document-wrapping.html fast/overflow/005.html fast/repaint/inline-outline-repaint.html +fast/text/find-case-folding.html fast/text/large-text-composed-char.html fast/text/basic/014.html fast/text/international/cjk-segmentation.html @@ -1839,6 +1853,7 @@ fast/text/international/bold-bengali.html fast/text/international/hebrew-vowels.html fast/text/international/plane2.html +fast/text/international/unicode-bidi-plaintext.html fast/text/international/vertical-text-glyph-test.html fast/text/international/vertical-text-metrics-test.html fast/writing-mode/japanese-ruby-horizontal-bt.html @@ -1860,6 +1875,13 @@ # https://bugs.webkit.org/show_bug.cgi?id=41452 fast/dom/beforeload/remove-video-in-beforeload-listener.html +# [Qt] fast/text/bidi-explicit-embedding-past-end.html fails +# https://bugs.webkit.org/show_bug.cgi?id=41241 +fast/text/bidi-explicit-embedding-past-end.html + +# https://bugs.webkit.org/show_bug.cgi?id=45194 +fast/text/decomposed-after-stacked-diacritics.html + # [Qt] fast/text/emphasis-overlap.html
[webkit-changes] [106041] branches/chromium/963/Source/WebCore/rendering/svg
Title: [106041] branches/chromium/963/Source/WebCore/rendering/svg Revision 106041 Author infe...@chromium.org Date 2012-01-26 14:18:26 -0800 (Thu, 26 Jan 2012) Log Message Merge 105986 - 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com Needed to fix windows builds. BUG=99615 Review URL: https://chromiumcodereview.appspot.com/9235073 Modified Paths branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp branches/chromium/963/Source/WebCore/rendering/svg/SVGRenderSupport.cpp Diff Modified: branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp (106040 => 106041) --- branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2012-01-26 22:10:59 UTC (rev 106040) +++ branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2012-01-26 22:18:26 UTC (rev 106041) @@ -27,6 +27,8 @@ #include AffineTransform.h #include FloatRect.h +#include Frame.h +#include FrameView.h #include GraphicsContext.h #include HitTestRequest.h #include HitTestResult.h Modified: branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp (106040 => 106041) --- branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp 2012-01-26 22:10:59 UTC (rev 106040) +++ branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp 2012-01-26 22:18:26 UTC (rev 106041) @@ -22,6 +22,8 @@ #if ENABLE(SVG) #include RenderSVGResourceSolidColor.h +#include Frame.h +#include FrameView.h #include GraphicsContext.h #include RenderSVGShape.h #include RenderStyle.h Modified: branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (106040 => 106041) --- branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 22:10:59 UTC (rev 106040) +++ branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2012-01-26 22:18:26 UTC (rev 106041) @@ -25,6 +25,8 @@ #if ENABLE(SVG) #include FloatConversion.h #include FontCache.h +#include Frame.h +#include FrameView.h #include GraphicsContext.h #include HitTestResult.h #include InlineFlowBox.h Modified: branches/chromium/963/Source/WebCore/rendering/svg/SVGRenderSupport.cpp (106040 => 106041) --- branches/chromium/963/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2012-01-26 22:10:59 UTC (rev 106040) +++ branches/chromium/963/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2012-01-26 22:18:26 UTC (rev 106041) @@ -27,6 +27,7 @@ #if ENABLE(SVG) #include SVGRenderSupport.h +#include Frame.h #include FrameView.h #include ImageBuffer.h #include NodeRenderStyle.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106042] branches/chromium/963/Source/WebCore/rendering/svg/ RenderSVGResource.cpp
Title: [106042] branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp Revision 106042 Author infe...@chromium.org Date 2012-01-26 14:21:18 -0800 (Thu, 26 Jan 2012) Log Message Merge 105985 - 2012-01-26 Nikolas Zimmermann nzimmerm...@rim.com BUG=99615 Review URL: https://chromiumcodereview.appspot.com/9288080 Modified Paths branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp Diff Modified: branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp (106041 => 106042) --- branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2012-01-26 22:18:26 UTC (rev 106041) +++ branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2012-01-26 22:21:18 UTC (rev 106042) @@ -25,6 +25,8 @@ #if ENABLE(SVG) #include RenderSVGResource.h +#include Frame.h +#include FrameView.h #include RenderSVGResourceContainer.h #include RenderSVGResourceSolidColor.h #include SVGResources.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106044] trunk/Source/WebKit/chromium
Title: [106044] trunk/Source/WebKit/chromium
Revision 106044
Author jam...@google.com
Date 2012-01-26 14:26:23 -0800 (Thu, 26 Jan 2012)
Log Message
[chromium] Add enter/exitRunLoop to WebThread API
https://bugs.webkit.org/show_bug.cgi?id=76012
Reviewed by Darin Fisher.
This adds those two APIs to WebKit::WebThread and converts CCLayerTreeHostTest over to use these APIs instead
of webkit_support. The immediate motivation is that we can't use webkit_support in webkit_unit_tests in the
component build.
* WebKit.gyp:
* public/platform/WebThread.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::TimeoutTask::run):
(WTF::CCLayerTreeHostTest::BeginTask::BeginTask):
(WTF::CCLayerTreeHostTest::BeginTask::~BeginTask):
(WTF::CCLayerTreeHostTest::BeginTask::run):
(WTF::CCLayerTreeHostTest::runTest):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/platform/WebThread.h
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106043 => 106044)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-26 22:24:10 UTC (rev 106043)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-26 22:26:23 UTC (rev 106044)
@@ -1,3 +1,24 @@
+2012-01-10 James Robinson jam...@chromium.org
+
+[chromium] Add enter/exitRunLoop to WebThread API
+https://bugs.webkit.org/show_bug.cgi?id=76012
+
+Reviewed by Darin Fisher.
+
+This adds those two APIs to WebKit::WebThread and converts CCLayerTreeHostTest over to use these APIs instead
+of webkit_support. The immediate motivation is that we can't use webkit_support in webkit_unit_tests in the
+component build.
+
+* WebKit.gyp:
+* public/platform/WebThread.h:
+* tests/CCLayerTreeHostTest.cpp:
+(WTF::CCLayerTreeHostTest::onEndTest):
+(WTF::CCLayerTreeHostTest::TimeoutTask::run):
+(WTF::CCLayerTreeHostTest::BeginTask::BeginTask):
+(WTF::CCLayerTreeHostTest::BeginTask::~BeginTask):
+(WTF::CCLayerTreeHostTest::BeginTask::run):
+(WTF::CCLayerTreeHostTest::runTest):
+
2012-01-26 John Bates jba...@google.com
Roll chromium_rev to 119248
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (106043 => 106044)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-26 22:24:10 UTC (rev 106043)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-26 22:26:23 UTC (rev 106044)
@@ -736,7 +736,6 @@
# These tests depend on webkit_support and
# functions defined only in !WEBKIT_IMPLEMENTATION.
'tests/AssociatedURLLoaderTest.cpp',
-'tests/CCLayerTreeHostTest.cpp',
'tests/FrameTestHelpers.cpp',
'tests/PopupMenuTest.cpp',
'tests/RenderTableCellTest.cpp',
Modified: trunk/Source/WebKit/chromium/public/platform/WebThread.h (106043 => 106044)
--- trunk/Source/WebKit/chromium/public/platform/WebThread.h 2012-01-26 22:24:10 UTC (rev 106043)
+++ trunk/Source/WebKit/chromium/public/platform/WebThread.h 2012-01-26 22:26:23 UTC (rev 106044)
@@ -51,9 +51,19 @@
virtual void postTask(Task*) = 0;
virtual void postDelayedTask(Task*, long long delayMs) = 0;
+
virtual void addTaskObserver(TaskObserver*) { }
virtual void removeTaskObserver(TaskObserver*) { }
+// enterRunLoop() processes tasks posted to this WebThread. This call does not return until some task calls exitRunLoop().
+// WebThread does not support nesting, meaning that once the run loop is entered for a given WebThread it is not valid to
+// call enterRunLoop() again.
+virtual void enterRunLoop() = 0;
+
+// exitRunLoop() runs tasks until there are no tasks available to run, then returns control to the caller of enterRunLoop().
+// Must be called when the WebThread is running.
+virtual void exitRunLoop() = 0;
+
virtual ~WebThread() { }
};
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (106043 => 106044)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-01-26 22:24:10 UTC (rev 106043)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-01-26 22:26:23 UTC (rev 106044)
@@ -42,7 +42,6 @@
#include platform/WebThread.h
#include gmock/gmock.h
#include gtest/gtest.h
-#include webkit/support/webkit_support.h
#include wtf/MainThread.h
#include wtf/PassRefPtr.h
#include wtf/Vector.h
@@ -298,16 +297,10 @@
void doBeginTest();
-static void onBeginTest(void* self)
-{
-static_castCCLayerTreeHostTest*(self)-doBeginTest();
-}
-
static void onEndTest(void* self)
{
ASSERT(isMainThread());
-webkit_support::QuitMessageLoop();
-
[webkit-changes] [106045] trunk/Source/WebCore
Title: [106045] trunk/Source/WebCore Revision 106045 Author commit-qu...@webkit.org Date 2012-01-26 14:26:42 -0800 (Thu, 26 Jan 2012) Log Message Fix include path in gyp file for V8InternalSettings.h https://bugs.webkit.org/show_bug.cgi?id=77128 Patch by Scott Graham scot...@chomium.org on 2012-01-26 Reviewed by Kent Tamura. * WebCore.gyp/WebCore.gyp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp Diff Modified: trunk/Source/WebCore/ChangeLog (106044 => 106045) --- trunk/Source/WebCore/ChangeLog 2012-01-26 22:26:23 UTC (rev 106044) +++ trunk/Source/WebCore/ChangeLog 2012-01-26 22:26:42 UTC (rev 106045) @@ -1,3 +1,12 @@ +2012-01-26 Scott Graham scot...@chomium.org + +Fix include path in gyp file for V8InternalSettings.h +https://bugs.webkit.org/show_bug.cgi?id=77128 + +Reviewed by Kent Tamura. + +* WebCore.gyp/WebCore.gyp: + 2012-01-26 James Robinson jam...@chromium.org We shouldn't synchronously update styles on all documents after running script Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (106044 => 106045) --- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-01-26 22:26:23 UTC (rev 106044) +++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-01-26 22:26:42 UTC (rev 106045) @@ -2037,7 +2037,7 @@ '(SHARED_INTERMEDIATE_DIR)/webcore/bindings/V8Internals.cpp', '(SHARED_INTERMEDIATE_DIR)/webkit/bindings/V8Internals.h', '(SHARED_INTERMEDIATE_DIR)/webcore/bindings/V8InternalSettings.cpp', -'(SHARED_INTERMEDIATE_DIR)/webkit/bindings/V8InternalsSettings.h', +'(SHARED_INTERMEDIATE_DIR)/webkit/bindings/V8InternalSettings.h', ], 'sources/': [ ['exclude', 'testing/js'], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106046] trunk/Source/WebCore
Title: [106046] trunk/Source/WebCore
Revision 106046
Author ander...@apple.com
Date 2012-01-26 14:33:49 -0800 (Thu, 26 Jan 2012)
Log Message
Simplify checking of whether we should rubberband horizontally
https://bugs.webkit.org/show_bug.cgi?id=77141
Reviewed by Adam Roben.
Have a single check for horizontal rubber-banding in both directions. This is in preparation
for moving this code into ScrollElasticityController.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::shouldRubberBandInHorizontalDirection):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106045 => 106046)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 22:26:42 UTC (rev 106045)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 22:33:49 UTC (rev 106046)
@@ -1,3 +1,17 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+Simplify checking of whether we should rubberband horizontally
+https://bugs.webkit.org/show_bug.cgi?id=77141
+
+Reviewed by Adam Roben.
+
+Have a single check for horizontal rubber-banding in both directions. This is in preparation
+for moving this code into ScrollElasticityController.
+
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::shouldRubberBandInHorizontalDirection):
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+
2012-01-26 Scott Graham scot...@chomium.org
Fix include path in gyp file for V8InternalSettings.h
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106045 => 106046)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 22:26:42 UTC (rev 106045)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 22:33:49 UTC (rev 106046)
@@ -889,14 +889,14 @@
#if ENABLE(RUBBER_BANDING)
-static inline bool isScrollingLeftAndShouldNotRubberBand(const PlatformWheelEvent wheelEvent, ScrollableArea* scrollableArea)
+static bool shouldRubberBandInHorizontalDirection(const PlatformWheelEvent wheelEvent, ScrollableArea* scrollableArea)
{
-return wheelEvent.deltaX() 0 !scrollableArea-shouldRubberBandInDirection(ScrollLeft);
-}
+if (wheelEvent.deltaX() 0)
+return scrollableArea-shouldRubberBandInDirection(ScrollLeft);
+if (wheelEvent.deltaX() 0)
+return scrollableArea-shouldRubberBandInDirection(ScrollRight);
-static inline bool isScrollingRightAndShouldNotRubberBand(const PlatformWheelEvent wheelEvent, ScrollableArea* scrollableArea)
-{
-return wheelEvent.deltaX() 0 !scrollableArea-shouldRubberBandInDirection(ScrollRight);
+return true;
}
bool ScrollAnimatorMac::handleWheelEvent(const PlatformWheelEvent wheelEvent)
@@ -919,14 +919,10 @@
}
if (wheelEvent.phase() == PlatformWheelEventPhaseBegan) {
-if (m_scrollableArea-isHorizontalScrollerPinnedToMinimumPosition()
-isScrollingLeftAndShouldNotRubberBand(wheelEvent, m_scrollableArea))
+if (pinnedInDirection(-wheelEvent.deltaX(), 0)
+!shouldRubberBandInHorizontalDirection(wheelEvent, m_scrollableArea))
return false;
-if (m_scrollableArea-isHorizontalScrollerPinnedToMaximumPosition()
-isScrollingRightAndShouldNotRubberBand(wheelEvent, m_scrollableArea))
-return false;
-
didBeginScrollGesture();
} else if (wheelEvent.phase() == PlatformWheelEventPhaseEnded)
didEndScrollGesture();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106047] trunk/LayoutTests
Title: [106047] trunk/LayoutTests Revision 106047 Author le...@chromium.org Date 2012-01-26 14:33:58 -0800 (Thu, 26 Jan 2012) Log Message Layout Test fast/workers/storage/interrupt-database.html is a flaky crasher on Debug Chromium Bots https://bugs.webkit.org/show_bug.cgi?id=77136 Unreviewed gardening. Marking fast/workers/storage/interrupt-database.html as a flaky crasher on debug Chromium bots. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106046 => 106047) --- trunk/LayoutTests/ChangeLog 2012-01-26 22:33:49 UTC (rev 106046) +++ trunk/LayoutTests/ChangeLog 2012-01-26 22:33:58 UTC (rev 106047) @@ -1,3 +1,13 @@ +2012-01-26 Levi Weintraub le...@chromium.org + +Layout Test fast/workers/storage/interrupt-database.html is a flaky crasher on Debug Chromium Bots +https://bugs.webkit.org/show_bug.cgi?id=77136 + +Unreviewed gardening. Marking fast/workers/storage/interrupt-database.html as a flaky +crasher on debug Chromium bots. + +* platform/chromium/test_expectations.txt: + 2012-01-26 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r106027. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106046 => 106047) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 22:33:49 UTC (rev 106046) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 22:33:58 UTC (rev 106047) @@ -3756,6 +3756,7 @@ BUGWK75048 DEBUG : fast/workers/storage/use-same-database-in-page-and-workers.html = CRASH TIMEOUT BUGWK75111 RELEASE : fast/workers/storage/use-same-database-in-page-and-workers.html = PASS TIMEOUT +BUGWK77136 DEBUG : fast/workers/storage/interrupt-database.html = PASS CRASH BUGWK75896 MAC DEBUG : css3/calc/block-mask-overlay-image-outset.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106048] trunk/Source/WebCore
Title: [106048] trunk/Source/WebCore
Revision 106048
Author jam...@google.com
Date 2012-01-26 14:46:53 -0800 (Thu, 26 Jan 2012)
Log Message
[chromium] Remove setLayerTreeHost nonsense on lost context
https://bugs.webkit.org/show_bug.cgi?id=76675
Reviewed by Kenneth Russell.
This code isn't needed any more. On a lost context event, we drop all TextureManager-managed textures through
the proxy and no layer types need special lost context handling.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106047 => 106048)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 22:33:58 UTC (rev 106047)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 22:46:53 UTC (rev 106048)
@@ -1,3 +1,16 @@
+2012-01-19 James Robinson jam...@chromium.org
+
+[chromium] Remove setLayerTreeHost nonsense on lost context
+https://bugs.webkit.org/show_bug.cgi?id=76675
+
+Reviewed by Kenneth Russell.
+
+This code isn't needed any more. On a lost context event, we drop all TextureManager-managed textures through
+the proxy and no layer types need special lost context handling.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
+
2012-01-26 Anders Carlsson ander...@apple.com
Simplify checking of whether we should rubberband horizontally
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (106047 => 106048)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-01-26 22:33:58 UTC (rev 106047)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-01-26 22:46:53 UTC (rev 106048)
@@ -185,10 +185,6 @@
void CCLayerTreeHost::didRecreateGraphicsContext(bool success)
{
-if (m_rootLayer) {
-m_rootLayer-setLayerTreeHost(0);
-m_rootLayer-setLayerTreeHost(this);
-}
m_client-didRecreateGraphicsContext(success);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106049] trunk/Source/JavaScriptCore
Title: [106049] trunk/Source/_javascript_Core
Revision 106049
Author pva...@webkit.org
Date 2012-01-26 14:55:26 -0800 (Thu, 26 Jan 2012)
Log Message
Fix build when VERBOSE_SPECULATION_FAILURE is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=77104
Reviewed by Filip Pizlo.
* dfg/DFGOperations.cpp:
():
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106048 => 106049)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-26 22:46:53 UTC (rev 106048)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-26 22:55:26 UTC (rev 106049)
@@ -1,3 +1,13 @@
+2012-01-26 Peter Varga pva...@webkit.org
+
+Fix build when VERBOSE_SPECULATION_FAILURE is enabled in DFG
+https://bugs.webkit.org/show_bug.cgi?id=77104
+
+Reviewed by Filip Pizlo.
+
+* dfg/DFGOperations.cpp:
+():
+
2012-01-26 Michael Saboff msab...@apple.com
String::latin1() should take advantage of 8 bit strings
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (106048 => 106049)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-01-26 22:46:53 UTC (rev 106048)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-01-26 22:55:26 UTC (rev 106049)
@@ -1009,7 +1009,7 @@
}
#if DFG_ENABLE(VERBOSE_SPECULATION_FAILURE)
-void DFG_OPERATION debugOperationPrintSpeculationFailure(ExecState*, void* debugInfoRaw)
+void DFG_OPERATION debugOperationPrintSpeculationFailure(ExecState* exec, void* debugInfoRaw)
{
JSGlobalData* globalData = exec-globalData();
NativeCallFrameTracer tracer(globalData, exec);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106050] trunk/Tools
Title: [106050] trunk/Tools Revision 106050 Author commit-qu...@webkit.org Date 2012-01-26 14:58:21 -0800 (Thu, 26 Jan 2012) Log Message Unreviewed, rolling out r106038. http://trac.webkit.org/changeset/106038 https://bugs.webkit.org/show_bug.cgi?id=77142 Caused a bunch of skipped tests to not be skipped. (Requested by ojan on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-01-26 * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser): (TestExpectationParser.parse): (TestExpectationParser._parse_line): (TestExpectationParser._collect_matching_tests): (TestExpectations.__init__): (TestExpectations._add_skipped_tests): * Scripts/webkitpy/layout_tests/port/base.py: (Port.test_dirs): (Port.normalize_test_name): (Port.update_baseline): (Port.layout_tests_dir): (Port.relative_perf_test_filename): (Port.abspath_for_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py Diff Modified: trunk/Tools/ChangeLog (106049 => 106050) --- trunk/Tools/ChangeLog 2012-01-26 22:55:26 UTC (rev 106049) +++ trunk/Tools/ChangeLog 2012-01-26 22:58:21 UTC (rev 106050) @@ -1,3 +1,27 @@ +2012-01-26 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r106038. +http://trac.webkit.org/changeset/106038 +https://bugs.webkit.org/show_bug.cgi?id=77142 + +Caused a bunch of skipped tests to not be skipped. (Requested +by ojan on #webkit). + +* Scripts/webkitpy/layout_tests/models/test_expectations.py: +(TestExpectationParser): +(TestExpectationParser.parse): +(TestExpectationParser._parse_line): +(TestExpectationParser._collect_matching_tests): +(TestExpectations.__init__): +(TestExpectations._add_skipped_tests): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.test_dirs): +(Port.normalize_test_name): +(Port.update_baseline): +(Port.layout_tests_dir): +(Port.relative_perf_test_filename): +(Port.abspath_for_test): + 2012-01-25 Ojan Vafai o...@chromium.org Parsing test_expecations.txt + Skipped lists takes too long Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (106049 => 106050) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-01-26 22:55:26 UTC (rev 106049) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-01-26 22:58:21 UTC (rev 106050) @@ -187,7 +187,6 @@ BUG_MODIFIER_PREFIX = 'bug' BUG_MODIFIER_REGEX = 'bug\d+' REBASELINE_MODIFIER = 'rebaseline' -FAIL_EXPECTATION = 'fail' SKIP_MODIFIER = 'skip' SLOW_MODIFIER = 'slow' WONTFIX_MODIFIER = 'wontfix' @@ -206,30 +205,15 @@ self._parse_line(expectation_line) return expectations -def expectation_for_skipped_test(self, test_name): -expectation_line = TestExpectationLine() -expectation_line.original_string = test_name -expectation_line.modifiers = [TestExpectationParser.SKIP_MODIFIER] -expectation_line.name = test_name -expectation_line.expectations = [TestExpectationParser.FAIL_EXPECTATION] -self._parse_line(expectation_line) -return expectation_line - def _parse_line(self, expectation_line): if not expectation_line.name: return self._check_modifiers_against_expectations(expectation_line) - -expectation_line.is_file = self._port.test_isfile(expectation_line.name) -if not expectation_line.is_file and self._check_path_does_not_exist(expectation_line): +if self._check_path_does_not_exist(expectation_line): return -if expectation_line.is_file: -expectation_line.path = expectation_line.name -else: -expectation_line.path = self._port.normalize_test_name(expectation_line.name) - +expectation_line.path = self._port.normalize_test_name(expectation_line.name) self._collect_matching_tests(expectation_line) self._parse_modifiers(expectation_line) @@ -301,7 +285,7 @@ expectation_line.matching_tests = [expectation_line.path] return -if not expectation_line.is_file: +if self._port.test_isdir(expectation_line.path): # this is a test category, return all the tests of the category. expectation_line.matching_tests = [test for test in self._full_test_list if test.startswith(expectation_line.path)] return @@ -718,6 +702,7 @@ self._model = TestExpectationsModel() self._parser = TestExpectationParser(port, tests, is_lint_mode) self._port = port +self._test_configuration_converter = TestConfigurationConverter(port.all_test_configurations(), port.configuration_specifier_macros())
[webkit-changes] [106051] trunk/Source/WebCore
Title: [106051] trunk/Source/WebCore
Revision 106051
Author ander...@apple.com
Date 2012-01-26 15:06:01 -0800 (Thu, 26 Jan 2012)
Log Message
Move horizontal rubber-band checks to ScrollElasticityController::handleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=77147
Reviewed by Adam Roben.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Always call ScrollElasticityController::handleWheelEvent, and only call didBeginScrollGesture and
didEndScrollGesture if the event was actually handled.
(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):
Implement this.
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::handleWheelEvent):
Check if we should rubber-band and return false if we shouldn't.
(WebCore::ScrollElasticityController::shouldRubberBandInHorizontalDirection):
Ask the client if we should rubber-band.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
trunk/Source/WebCore/platform/mac/ScrollElasticityController.h
trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (106050 => 106051)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 22:58:21 UTC (rev 106050)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 23:06:01 UTC (rev 106051)
@@ -1,3 +1,28 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+Move horizontal rubber-band checks to ScrollElasticityController::handleWheelEvent
+https://bugs.webkit.org/show_bug.cgi?id=77147
+
+Reviewed by Adam Roben.
+
+* platform/mac/ScrollAnimatorMac.h:
+(ScrollAnimatorMac):
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+Always call ScrollElasticityController::handleWheelEvent, and only call didBeginScrollGesture and
+didEndScrollGesture if the event was actually handled.
+
+(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):
+Implement this.
+
+* platform/mac/ScrollElasticityController.h:
+* platform/mac/ScrollElasticityController.mm:
+(WebCore::ScrollElasticityController::handleWheelEvent):
+Check if we should rubber-band and return false if we shouldn't.
+
+(WebCore::ScrollElasticityController::shouldRubberBandInHorizontalDirection):
+Ask the client if we should rubber-band.
+
2012-01-19 James Robinson jam...@chromium.org
[chromium] Remove setLayerTreeHost nonsense on lost context
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h (106050 => 106051)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 22:58:21 UTC (rev 106050)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h 2012-01-26 23:06:01 UTC (rev 106051)
@@ -125,6 +125,7 @@
virtual bool pinnedInDirection(const FloatSize) OVERRIDE;
virtual bool canScrollHorizontally() OVERRIDE;
virtual bool canScrollVertically() OVERRIDE;
+virtual bool shouldRubberBandInDirection(ScrollDirection) OVERRIDE;
virtual WebCore::IntPoint absoluteScrollPosition() OVERRIDE;
virtual void immediateScrollByWithoutContentEdgeConstraints(const FloatSize) OVERRIDE;
virtual void immediateScrollBy(const FloatSize) OVERRIDE;
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106050 => 106051)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 22:58:21 UTC (rev 106050)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-26 23:06:01 UTC (rev 106051)
@@ -888,17 +888,6 @@
}
#if ENABLE(RUBBER_BANDING)
-
-static bool shouldRubberBandInHorizontalDirection(const PlatformWheelEvent wheelEvent, ScrollableArea* scrollableArea)
-{
-if (wheelEvent.deltaX() 0)
-return scrollableArea-shouldRubberBandInDirection(ScrollLeft);
-if (wheelEvent.deltaX() 0)
-return scrollableArea-shouldRubberBandInDirection(ScrollRight);
-
-return true;
-}
-
bool ScrollAnimatorMac::handleWheelEvent(const PlatformWheelEvent wheelEvent)
{
m_haveScrolledSincePageLoad = true;
@@ -918,16 +907,16 @@
return ScrollAnimator::handleWheelEvent(wheelEvent);
}
-if (wheelEvent.phase() == PlatformWheelEventPhaseBegan) {
-if (pinnedInDirection(-wheelEvent.deltaX(), 0)
-!shouldRubberBandInHorizontalDirection(wheelEvent, m_scrollableArea))
-return false;
+bool didHandleEvent = m_scrollElasticityController.handleWheelEvent(wheelEvent);
-didBeginScrollGesture();
-} else if (wheelEvent.phase() == PlatformWheelEventPhaseEnded)
-didEndScrollGesture();
+if (didHandleEvent) {
+if (wheelEvent.phase() == PlatformWheelEventPhaseBegan)
+didBeginScrollGesture();
+else if
[webkit-changes] [106052] trunk/Source/WebCore
Title: [106052] trunk/Source/WebCore
Revision 106052
Author al...@chromium.org
Date 2012-01-26 15:13:44 -0800 (Thu, 26 Jan 2012)
Log Message
[chromium] Remove dead and unnecessary code related to LayerChromium::cleanupResources
https://bugs.webkit.org/show_bug.cgi?id=77137
Reviewed by James Robinson.
No new test needed. Only removing dead code.
* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::layerTreeHost):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106051 => 106052)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 23:06:01 UTC (rev 106051)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 23:13:44 UTC (rev 106052)
@@ -1,3 +1,18 @@
+2012-01-26 Alok Priyadarshi al...@chromium.org
+
+[chromium] Remove dead and unnecessary code related to LayerChromium::cleanupResources
+https://bugs.webkit.org/show_bug.cgi?id=77137
+
+Reviewed by James Robinson.
+
+No new test needed. Only removing dead code.
+
+* platform/graphics/chromium/LayerChromium.cpp:
+* platform/graphics/chromium/LayerChromium.h:
+(WebCore::LayerChromium::layerTreeHost):
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::setLayerTreeHost):
+
2012-01-26 Anders Carlsson ander...@apple.com
Move horizontal rubber-band checks to ScrollElasticityController::handleWheelEvent
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (106051 => 106052)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2012-01-26 23:06:01 UTC (rev 106051)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2012-01-26 23:13:44 UTC (rev 106052)
@@ -94,19 +94,6 @@
{
}
-void LayerChromium::cleanupResourcesRecursive()
-{
-for (size_t i = 0; i children().size(); ++i)
-children()[i]-cleanupResourcesRecursive();
-
-if (maskLayer())
-maskLayer()-cleanupResourcesRecursive();
-if (replicaLayer())
-replicaLayer()-cleanupResourcesRecursive();
-
-cleanupResources();
-}
-
void LayerChromium::setIsNonCompositedContent(bool isNonCompositedContent)
{
m_isNonCompositedContent = isNonCompositedContent;
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (106051 => 106052)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2012-01-26 23:06:01 UTC (rev 106051)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2012-01-26 23:13:44 UTC (rev 106052)
@@ -196,7 +196,6 @@
virtual void contentChanged() { }
CCLayerTreeHost* layerTreeHost() const { return m_layerTreeHost.get(); }
-void cleanupResourcesRecursive();
protected:
LayerChromium();
Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (106051 => 106052)
--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-01-26 23:06:01 UTC (rev 106051)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-01-26 23:13:44 UTC (rev 106052)
@@ -178,9 +178,6 @@
if (host == layerTreeHost())
return;
-if (layerTreeHost())
-cleanupResources();
-
LayerChromium::setLayerTreeHost(host);
if (!host)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106053] trunk/LayoutTests
Title: [106053] trunk/LayoutTests Revision 106053 Author le...@chromium.org Date 2012-01-26 15:25:39 -0800 (Thu, 26 Jan 2012) Log Message compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win https://bugs.webkit.org/show_bug.cgi?id=77151 Unreviewed gardening. Marking the above 2 tests as flaky on Chromium Windows until I can root cause the change. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106052 => 106053) --- trunk/LayoutTests/ChangeLog 2012-01-26 23:13:44 UTC (rev 106052) +++ trunk/LayoutTests/ChangeLog 2012-01-26 23:25:39 UTC (rev 106053) @@ -1,5 +1,15 @@ 2012-01-26 Levi Weintraub le...@chromium.org +compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win +https://bugs.webkit.org/show_bug.cgi?id=77151 + +Unreviewed gardening. Marking the above 2 tests as flaky on Chromium Windows until +I can root cause the change. + +* platform/chromium/test_expectations.txt: + +2012-01-26 Levi Weintraub le...@chromium.org + Layout Test fast/workers/storage/interrupt-database.html is a flaky crasher on Debug Chromium Bots https://bugs.webkit.org/show_bug.cgi?id=77136 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106052 => 106053) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 23:13:44 UTC (rev 106052) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 23:25:39 UTC (rev 106053) @@ -4016,3 +4016,6 @@ BUGWK77047 WIN DEBUG : http/tests/workers/terminate-during-sync-operation.html = PASS TIMEOUT BUGWK77061 XP DEBUG : svg/custom/object-sizing-explicit-width.xhtml = PASS IMAGE+TEXT +BUGWK77151 WIN : compositing/shadows/shadow-drawing.html = IMAGE +BUGWK77151 WIN : svg/css/group-with-shadow.svg = IMAGE + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106054] trunk/Tools
Title: [106054] trunk/Tools
Revision 106054
Author commit-qu...@webkit.org
Date 2012-01-26 15:29:16 -0800 (Thu, 26 Jan 2012)
Log Message
Support a suffix on ChangeLog filenames based on a configuration file
https://bugs.webkit.org/show_bug.cgi?id=76956
Patch by Benjamin Poulain bpoul...@apple.com on 2012-01-26
Reviewed by Kentaro Hara.
Modify the tools used to generate, edit and resolve ChangeLogs to support
the addition of a suffix to the ChangeLog filename.
This patch makes it easier to support alternate ChangeLog files in branches.
* Scripts/VCSUtils.pm:
(changeLogSuffix):
(changeLogFileName):
* Scripts/commit-log-editor:
* Scripts/prepare-ChangeLog:
(getLatestChangeLogs):
(generateNewChangeLogs):
(generateFileList):
* Scripts/resolve-ChangeLogs:
(findChangeLog):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
trunk/Tools/Scripts/commit-log-editor
trunk/Tools/Scripts/prepare-ChangeLog
trunk/Tools/Scripts/resolve-ChangeLogs
Diff
Modified: trunk/Tools/ChangeLog (106053 => 106054)
--- trunk/Tools/ChangeLog 2012-01-26 23:25:39 UTC (rev 106053)
+++ trunk/Tools/ChangeLog 2012-01-26 23:29:16 UTC (rev 106054)
@@ -1,3 +1,26 @@
+2012-01-26 Benjamin Poulain bpoul...@apple.com
+
+Support a suffix on ChangeLog filenames based on a configuration file
+https://bugs.webkit.org/show_bug.cgi?id=76956
+
+Reviewed by Kentaro Hara.
+
+Modify the tools used to generate, edit and resolve ChangeLogs to support
+the addition of a suffix to the ChangeLog filename.
+
+This patch makes it easier to support alternate ChangeLog files in branches.
+
+* Scripts/VCSUtils.pm:
+(changeLogSuffix):
+(changeLogFileName):
+* Scripts/commit-log-editor:
+* Scripts/prepare-ChangeLog:
+(getLatestChangeLogs):
+(generateNewChangeLogs):
+(generateFileList):
+* Scripts/resolve-ChangeLogs:
+(findChangeLog):
+
2012-01-26 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r106038.
Modified: trunk/Tools/Scripts/VCSUtils.pm (106053 => 106054)
--- trunk/Tools/Scripts/VCSUtils.pm 2012-01-26 23:25:39 UTC (rev 106053)
+++ trunk/Tools/Scripts/VCSUtils.pm 2012-01-26 23:29:16 UTC (rev 106054)
@@ -49,6 +49,7 @@
callSilently
canonicalizePath
changeLogEmailAddress
+changeLogFileName
changeLogName
chdirReturningRelativePath
decodeGitBinaryChunk
@@ -1759,6 +1760,23 @@
return $result;
}
+sub changeLogSuffix()
+{
+my $rootPath = determineVCSRoot();
+my $changeLogSuffixFile = File::Spec-catfile($rootPath, .changeLogSuffix);
+return if ! -e $changeLogSuffixFile;
+open FILE, $changeLogSuffixFile or die Could not open $changeLogSuffixFile: $!;
+my $changeLogSuffix = FILE;
+chomp $changeLogSuffix;
+close FILE;
+return $changeLogSuffix;
+}
+
+sub changeLogFileName()
+{
+return ChangeLog . changeLogSuffix()
+}
+
sub changeLogNameError($)
{
my ($message) = @_;
Modified: trunk/Tools/Scripts/commit-log-editor (106053 => 106054)
--- trunk/Tools/Scripts/commit-log-editor 2012-01-26 23:25:39 UTC (rev 106053)
+++ trunk/Tools/Scripts/commit-log-editor 2012-01-26 23:29:16 UTC (rev 106054)
@@ -148,8 +148,8 @@
# (without the log comment info). We don't need it.
}
$existingLog = isGit() !(/^#/ || /^\s*$/) unless $existingLog;
-
-push @changeLogs, makeFilePathRelative($1) if $inChangesToBeCommitted (/^(?:M|A)(.*ChangeLog)\r?\n?$/ || /^#\t(?:modified|new file): (.*ChangeLog)$/) !/-ChangeLog$/;
+my $changeLogFileName = changeLogFileName();
+push @changeLogs, makeFilePathRelative($1) if $inChangesToBeCommitted (/^(?:M|A)(.*$changeLogFileName)\r?\n?$/ || /^#\t(?:modified|new file): (.*$changeLogFileName)$/) !/-$changeLogFileName$/;
}
close LOG;
Modified: trunk/Tools/Scripts/prepare-ChangeLog (106053 => 106054)
--- trunk/Tools/Scripts/prepare-ChangeLog 2012-01-26 23:25:39 UTC (rev 106053)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2012-01-26 23:29:16 UTC (rev 106054)
@@ -420,7 +420,7 @@
my @changeLogs = ();
foreach my $prefix (@$prefixes) {
-push @changeLogs, File::Spec-catfile($prefix || ., ChangeLog);
+push @changeLogs, File::Spec-catfile($prefix || ., changeLogFileName());
}
return \@changeLogs;
}
@@ -459,7 +459,7 @@
my @old_change_log;
if ($writeChangeLogs) {
-my $changeLogPath = File::Spec-catfile($prefix || ., ChangeLog);
+my $changeLogPath = File::Spec-catfile($prefix || ., changeLogFileName());
print STDERR Editing the ${changeLogPath} file.\n;
open OLD_CHANGE_LOG, ${changeLogPath} or die Could not open ${changeLogPath} file: $!.\n;
# It's less efficient to read the whole thing into memory than it would be
@@ -1728,11 +1728,11 @@
!scalar(grep(/^resources$/i,
[webkit-changes] [106056] trunk/LayoutTests
Title: [106056] trunk/LayoutTests Revision 106056 Author le...@chromium.org Date 2012-01-26 15:48:11 -0800 (Thu, 26 Jan 2012) Log Message compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win https://bugs.webkit.org/show_bug.cgi?id=77151 Unreviewed gardening. Rebaselining expectations for the above tests on Chromium-Windows and re-enabling them. * platform/chromium-win-vista/compositing/shadows: Added. * platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added. * platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Added. * platform/chromium-win-xp/compositing/shadows: Added. * platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png: Added. * platform/chromium-win-xp/svg/css: Removed. * platform/chromium-win/compositing/shadows/shadow-drawing-expected.png: * platform/chromium-win/svg/css/group-with-shadow-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/compositing/shadows/shadow-drawing-expected.png trunk/LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.png Added Paths trunk/LayoutTests/platform/chromium-win-vista/compositing/shadows/ trunk/LayoutTests/platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png trunk/LayoutTests/platform/chromium-win-vista/svg/css/group-with-shadow-expected.png trunk/LayoutTests/platform/chromium-win-xp/compositing/shadows/ trunk/LayoutTests/platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png Removed Paths trunk/LayoutTests/platform/chromium-win-xp/svg/css/ Diff Modified: trunk/LayoutTests/ChangeLog (106055 => 106056) --- trunk/LayoutTests/ChangeLog 2012-01-26 23:44:21 UTC (rev 106055) +++ trunk/LayoutTests/ChangeLog 2012-01-26 23:48:11 UTC (rev 106056) @@ -3,6 +3,23 @@ compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win https://bugs.webkit.org/show_bug.cgi?id=77151 +Unreviewed gardening. Rebaselining expectations for the above tests on Chromium-Windows and re-enabling them. + +* platform/chromium-win-vista/compositing/shadows: Added. +* platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added. +* platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Added. +* platform/chromium-win-xp/compositing/shadows: Added. +* platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png: Added. +* platform/chromium-win-xp/svg/css: Removed. +* platform/chromium-win/compositing/shadows/shadow-drawing-expected.png: +* platform/chromium-win/svg/css/group-with-shadow-expected.png: +* platform/chromium/test_expectations.txt: + +2012-01-26 Levi Weintraub le...@chromium.org + +compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win +https://bugs.webkit.org/show_bug.cgi?id=77151 + Unreviewed gardening. Marking the above 2 tests as flaky on Chromium Windows until I can root cause the change. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106055 => 106056) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 23:44:21 UTC (rev 106055) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-26 23:48:11 UTC (rev 106056) @@ -4016,6 +4016,3 @@ BUGWK77047 WIN DEBUG : http/tests/workers/terminate-during-sync-operation.html = PASS TIMEOUT BUGWK77061 XP DEBUG : svg/custom/object-sizing-explicit-width.xhtml = PASS IMAGE+TEXT -BUGWK77151 WIN : compositing/shadows/shadow-drawing.html = IMAGE -BUGWK77151 WIN : svg/css/group-with-shadow.svg = IMAGE - Modified: trunk/LayoutTests/platform/chromium-win/compositing/shadows/shadow-drawing-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win-vista/svg/css/group-with-shadow-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win-vista/svg/css/group-with-shadow-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png (Binary files differ) Property changes on:
[webkit-changes] [106057] trunk/Source
Title: [106057] trunk/Source
Revision 106057
Author c...@chromium.org
Date 2012-01-26 15:50:31 -0800 (Thu, 26 Jan 2012)
Log Message
Source/WebCore: Add a scheme registry for CORS requests. Allow simple CORS requests to be made to registered schemes.
https://bugs.webkit.org/show_bug.cgi?id=77041
Reviewed by Alexey Proskuryakov.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
* platform/SchemeRegistry.cpp:
(WebCore::CORSEnabledSchemes):
(WebCore):
(WebCore::SchemeRegistry::registerCORSEnabledScheme):
(WebCore::SchemeRegistry::isCORSEnabledScheme):
* platform/SchemeRegistry.h:
(SchemeRegistry):
Source/WebKit/chromium: Add API to register schemes which can be sent simple CORS requests.
https://bugs.webkit.org/show_bug.cgi?id=77041
Reviewed by Alexey Proskuryakov.
* public/WebSecurityPolicy.h:
(WebSecurityPolicy):
* src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::registerCORSEnabledScheme):
(WebKit):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/platform/SchemeRegistry.cpp
trunk/Source/WebCore/platform/SchemeRegistry.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSecurityPolicy.h
trunk/Source/WebKit/chromium/src/WebSecurityPolicy.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106056 => 106057)
--- trunk/Source/WebCore/ChangeLog 2012-01-26 23:48:11 UTC (rev 106056)
+++ trunk/Source/WebCore/ChangeLog 2012-01-26 23:50:31 UTC (rev 106057)
@@ -1,3 +1,20 @@
+2012-01-25 Cris Neckar c...@chromium.org
+
+Add a scheme registry for CORS requests. Allow simple CORS requests to be made to registered schemes.
+https://bugs.webkit.org/show_bug.cgi?id=77041
+
+Reviewed by Alexey Proskuryakov.
+
+* loader/DocumentThreadableLoader.cpp:
+(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
+* platform/SchemeRegistry.cpp:
+(WebCore::CORSEnabledSchemes):
+(WebCore):
+(WebCore::SchemeRegistry::registerCORSEnabledScheme):
+(WebCore::SchemeRegistry::isCORSEnabledScheme):
+* platform/SchemeRegistry.h:
+(SchemeRegistry):
+
2012-01-26 Noel Gordon noel.gor...@gmail.com
File extension for webp files is .webp
Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp (106056 => 106057)
--- trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2012-01-26 23:48:11 UTC (rev 106056)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2012-01-26 23:50:31 UTC (rev 106057)
@@ -41,6 +41,7 @@
#include FrameLoader.h
#include ResourceError.h
#include ResourceRequest.h
+#include SchemeRegistry.h
#include SecurityOrigin.h
#include ThreadableLoaderClient.h
#include wtf/Assertions.h
@@ -115,9 +116,8 @@
ASSERT(m_options.preflightPolicy != ForcePreflight);
ASSERT(m_options.preflightPolicy == PreventPreflight || isSimpleCrossOriginAccessRequest(request.httpMethod(), request.httpHeaderFields()));
-// Cross-origin requests are only defined for HTTP. We would catch this when checking response headers later, but there is no reason to send a request that's guaranteed to be denied.
-// FIXME: Consider allowing simple CORS requests to non-HTTP URLs.
-if (!request.url().protocolInHTTPFamily()) {
+// Cross-origin requests are only allowed for HTTP and registered schemes. We would catch this when checking response headers later, but there is no reason to send a request that's guaranteed to be denied.
+if (!SchemeRegistry::shouldTreatURLSchemeAsCORSEnabled(request.url().protocol())) {
m_client-didFail(ResourceError(errorDomainWebKitInternal, 0, request.url().string(), Cross origin requests are only supported for HTTP.));
return;
}
Modified: trunk/Source/WebCore/platform/SchemeRegistry.cpp (106056 => 106057)
--- trunk/Source/WebCore/platform/SchemeRegistry.cpp 2012-01-26 23:48:11 UTC (rev 106056)
+++ trunk/Source/WebCore/platform/SchemeRegistry.cpp 2012-01-26 23:50:31 UTC (rev 106057)
@@ -25,6 +25,7 @@
*/
#include config.h
#include SchemeRegistry.h
+#include wtf/MainThread.h
namespace WebCore {
@@ -152,6 +153,19 @@
return schemesAllowingDatabaseAccessInPrivateBrowsing;
}
+static URLSchemesMap CORSEnabledSchemes()
+{
+ASSERT(isMainThread());
+DEFINE_STATIC_LOCAL(URLSchemesMap, CORSEnabledSchemes, ());
+
+if (CORSEnabledSchemes.isEmpty()) {
+CORSEnabledSchemes.add(http);
+CORSEnabledSchemes.add(https);
+}
+
+return CORSEnabledSchemes;
+}
+
bool SchemeRegistry::shouldTreatURLSchemeAsLocal(const String scheme)
{
if (scheme.isEmpty())
@@ -273,4 +287,16 @@
return schemesAllowingDatabaseAccessInPrivateBrowsing().contains(scheme);
}
+void SchemeRegistry::registerURLSchemeAsCORSEnabled(const String scheme)
+{
+CORSEnabledSchemes().add(scheme);
+}
+
+bool
[webkit-changes] [106058] trunk/Tools
Title: [106058] trunk/Tools Revision 106058 Author o...@chromium.org Date 2012-01-26 16:03:23 -0800 (Thu, 26 Jan 2012) Log Message run-webkit-tests calls nm when it doesn't need to https://bugs.webkit.org/show_bug.cgi?id=77143 Reviewed by Dirk Pranke. If we are not running any test that can be skipped by checking the DRT feature list or looking at the list of symbols, avoid calling out to DRT or calling nm. This saves ~700ms on my Mac Pro. In cases where you still have to call out to nm it's only a couple ms slower. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.__init__): * Scripts/webkitpy/layout_tests/port/base.py: (Port.skipped_tests): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._should_check_for_missing_features): (WebKitPort): (WebKitPort._should_check_for_missing_symbols): (WebKitPort._skipped_tests_for_unsupported_features): (WebKitPort.skipped_layout_tests): (WebKitPort.skipped_tests): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitPortTest.test_skipped_directories_for_symbols): (test_skipped_directories_for_features): (test_skipped_directories_for_features_no_matching_tests_in_test_list): (test_skipped_layout_tests): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py Diff Modified: trunk/Tools/ChangeLog (106057 => 106058) --- trunk/Tools/ChangeLog 2012-01-26 23:50:31 UTC (rev 106057) +++ trunk/Tools/ChangeLog 2012-01-27 00:03:23 UTC (rev 106058) @@ -1,3 +1,34 @@ +2012-01-26 Ojan Vafai o...@chromium.org + +run-webkit-tests calls nm when it doesn't need to +https://bugs.webkit.org/show_bug.cgi?id=77143 + +Reviewed by Dirk Pranke. + +If we are not running any test that can be skipped by checking +the DRT feature list or looking at the list of symbols, avoid calling +out to DRT or calling nm. + +This saves ~700ms on my Mac Pro. In cases where you still have to call out +to nm it's only a couple ms slower. + +* Scripts/webkitpy/layout_tests/models/test_expectations.py: +(TestExpectations.__init__): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.skipped_tests): +* Scripts/webkitpy/layout_tests/port/webkit.py: +(WebKitPort._should_check_for_missing_features): +(WebKitPort): +(WebKitPort._should_check_for_missing_symbols): +(WebKitPort._skipped_tests_for_unsupported_features): +(WebKitPort.skipped_layout_tests): +(WebKitPort.skipped_tests): +* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: +(WebKitPortTest.test_skipped_directories_for_symbols): +(test_skipped_directories_for_features): +(test_skipped_directories_for_features_no_matching_tests_in_test_list): +(test_skipped_layout_tests): + 2012-01-26 Benjamin Poulain bpoul...@apple.com Support a suffix on ChangeLog filenames based on a configuration file Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (106057 => 106058) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-01-26 23:50:31 UTC (rev 106057) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-01-27 00:03:23 UTC (rev 106058) @@ -707,7 +707,7 @@ self._expectations = self._parser.parse(expectations) self._add_expectations(self._expectations, overrides_allowed=False) -self._add_skipped_tests(port.skipped_tests()) +self._add_skipped_tests(port.skipped_tests(tests)) if overrides: overrides_expectations = self._parser.parse(overrides) Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (106057 => 106058) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-01-26 23:50:31 UTC (rev 106057) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-01-27 00:03:23 UTC (rev 106058) @@ -600,7 +600,7 @@ def skipped_perf_tests(self): return self._expectations_from_skipped_files([self.perf_tests_dir()]) -def skipped_tests(self): +def skipped_tests(self, test_list): return [] def skips_layout_test(self, test_name): Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (106057 => 106058) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-01-26 23:50:31 UTC (rev 106057) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-01-27 00:03:23 UTC (rev 106058) @@ -32,6 +32,7 @@ WebKit implementations of the Port interface. import base64 +import itertools import logging import operator import os @@ -305,20 +306,34 @@ MHTMLArchive: [mhtml], } -def _skipped_tests_for_unsupported_features(self):
[webkit-changes] [106059] trunk/Source/WebCore
Title: [106059] trunk/Source/WebCore
Revision 106059
Author jsb...@chromium.org
Date 2012-01-26 16:07:11 -0800 (Thu, 26 Jan 2012)
Log Message
IndexedDB: WebCore::IDBKey objects are leaked
https://bugs.webkit.org/show_bug.cgi?id=77114
Reviewed by Tony Chang.
Fixing memory leaks, no new tests.
* storage/IDBKey.h:
(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createArray):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBKey.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (106058 => 106059)
--- trunk/Source/WebCore/ChangeLog 2012-01-27 00:03:23 UTC (rev 106058)
+++ trunk/Source/WebCore/ChangeLog 2012-01-27 00:07:11 UTC (rev 106059)
@@ -1,3 +1,19 @@
+2012-01-26 Joshua Bell jsb...@chromium.org
+
+IndexedDB: WebCore::IDBKey objects are leaked
+https://bugs.webkit.org/show_bug.cgi?id=77114
+
+Reviewed by Tony Chang.
+
+Fixing memory leaks, no new tests.
+
+* storage/IDBKey.h:
+(WebCore::IDBKey::createInvalid):
+(WebCore::IDBKey::createNumber):
+(WebCore::IDBKey::createString):
+(WebCore::IDBKey::createDate):
+(WebCore::IDBKey::createArray):
+
2012-01-25 Cris Neckar c...@chromium.org
Add a scheme registry for CORS requests. Allow simple CORS requests to be made to registered schemes.
Modified: trunk/Source/WebCore/storage/IDBKey.h (106058 => 106059)
--- trunk/Source/WebCore/storage/IDBKey.h 2012-01-27 00:03:23 UTC (rev 106058)
+++ trunk/Source/WebCore/storage/IDBKey.h 2012-01-27 00:07:11 UTC (rev 106059)
@@ -41,14 +41,14 @@
static PassRefPtrIDBKey createInvalid()
{
-RefPtrIDBKey idbKey(new IDBKey());
+RefPtrIDBKey idbKey = adoptRef(new IDBKey());
idbKey-m_type = InvalidType;
return idbKey.release();
}
static PassRefPtrIDBKey createNumber(double number)
{
-RefPtrIDBKey idbKey(new IDBKey());
+RefPtrIDBKey idbKey = adoptRef(new IDBKey());
idbKey-m_type = NumberType;
idbKey-m_number = number;
idbKey-m_sizeEstimate += sizeof(double);
@@ -57,7 +57,7 @@
static PassRefPtrIDBKey createString(const String string)
{
-RefPtrIDBKey idbKey(new IDBKey());
+RefPtrIDBKey idbKey = adoptRef(new IDBKey());
idbKey-m_type = StringType;
idbKey-m_string = string;
idbKey-m_sizeEstimate += string.length() * sizeof(UChar);
@@ -66,7 +66,7 @@
static PassRefPtrIDBKey createDate(double date)
{
-RefPtrIDBKey idbKey(new IDBKey());
+RefPtrIDBKey idbKey = adoptRef(new IDBKey());
idbKey-m_type = DateType;
idbKey-m_date = date;
idbKey-m_sizeEstimate += sizeof(double);
@@ -75,7 +75,7 @@
static PassRefPtrIDBKey createArray(const KeyArray array)
{
-RefPtrIDBKey idbKey(new IDBKey());
+RefPtrIDBKey idbKey = adoptRef(new IDBKey());
idbKey-m_type = ArrayType;
idbKey-m_array = array;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106060] trunk/Tools
Title: [106060] trunk/Tools Revision 106060 Author dpra...@chromium.org Date 2012-01-26 16:16:24 -0800 (Thu, 26 Jan 2012) Log Message webkitpy: re-land cleanup of test scaffolding https://bugs.webkit.org/show_bug.cgi?id=77153 Reviewed by Eric Seidel. This is an attempt to reland the change in bug 76973 / r105935. My earlier attempt to manipulate PYTHONPATH seems to only work some of the time, for reasons that elude me. Directly adding Tools/Scripts to sys.path from inside the test script appears to work (more?) reliably. Also, it seemed like the files didn't actually get deleted the last time; I don't know why. * Scripts/test-webkitpy: * Scripts/webkitpy/common/system/executive_unittest.py: (command_line): (ExecutiveTest): (ExecutiveTest.test_run_command_args_type): (ExecutiveTest.test_run_command_with_unicode): (ExecutiveTest.test_running_pids): (main): * Scripts/webkitpy/common/system/fileutils.py: Removed. * Scripts/webkitpy/test/cat.py: Removed. * Scripts/webkitpy/test/cat_unittest.py: Removed. * Scripts/webkitpy/test/echo.py: Removed. * Scripts/webkitpy/test/echo_unittest.py: Removed. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/test-webkitpy trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py Removed Paths trunk/Tools/Scripts/webkitpy/common/system/fileutils.py trunk/Tools/Scripts/webkitpy/test/cat.py trunk/Tools/Scripts/webkitpy/test/cat_unittest.py trunk/Tools/Scripts/webkitpy/test/echo.py trunk/Tools/Scripts/webkitpy/test/echo_unittest.py Diff Modified: trunk/Tools/ChangeLog (106059 => 106060) --- trunk/Tools/ChangeLog 2012-01-27 00:07:11 UTC (rev 106059) +++ trunk/Tools/ChangeLog 2012-01-27 00:16:24 UTC (rev 106060) @@ -1,3 +1,33 @@ +2012-01-26 Dirk Pranke dpra...@chromium.org + +webkitpy: re-land cleanup of test scaffolding +https://bugs.webkit.org/show_bug.cgi?id=77153 + +Reviewed by Eric Seidel. + +This is an attempt to reland the change in bug 76973 / +r105935. My earlier attempt to manipulate PYTHONPATH +seems to only work some of the time, for reasons that +elude me. Directly adding Tools/Scripts to sys.path from +inside the test script appears to work (more?) reliably. + +Also, it seemed like the files didn't actually get deleted +the last time; I don't know why. + +* Scripts/test-webkitpy: +* Scripts/webkitpy/common/system/executive_unittest.py: +(command_line): +(ExecutiveTest): +(ExecutiveTest.test_run_command_args_type): +(ExecutiveTest.test_run_command_with_unicode): +(ExecutiveTest.test_running_pids): +(main): +* Scripts/webkitpy/common/system/fileutils.py: Removed. +* Scripts/webkitpy/test/cat.py: Removed. +* Scripts/webkitpy/test/cat_unittest.py: Removed. +* Scripts/webkitpy/test/echo.py: Removed. +* Scripts/webkitpy/test/echo_unittest.py: Removed. + 2012-01-26 Ojan Vafai o...@chromium.org run-webkit-tests calls nm when it doesn't need to Modified: trunk/Tools/Scripts/test-webkitpy (106059 => 106060) --- trunk/Tools/Scripts/test-webkitpy 2012-01-27 00:07:11 UTC (rev 106059) +++ trunk/Tools/Scripts/test-webkitpy 2012-01-27 00:16:24 UTC (rev 106060) @@ -42,7 +42,7 @@ if __name__ == __main__: -webkit_root = os.path.dirname(os.path.dirname(os.path.dirname(__file__))) +webkit_root = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__ # FIXME: We should probably test each package separately to avoid naming conflicts. dirs = [ Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py (106059 => 106060) --- trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-01-27 00:07:11 UTC (rev 106059) +++ trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-01-27 00:16:24 UTC (rev 106060) @@ -33,9 +33,14 @@ import sys import unittest +# Since we execute this script directly as part of the unit tests, we need to ensure +# that Tools/Scripts is in sys.path for the next imports to work correctly. +script_dir = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__) +if script_dir not in sys.path: +sys.path.append(script_dir) + from webkitpy.common.system.executive import Executive, ScriptError from webkitpy.common.system.filesystem_mock import MockFileSystem -from webkitpy.test import cat, echo class ScriptErrorTest(unittest.TestCase): @@ -64,8 +69,11 @@ return ['yes'] +def command_line(cmd, *args): +return [sys.executable, __file__, '--' + cmd] + list(args) + + class ExecutiveTest(unittest.TestCase): - def assert_interpreter_for_content(self, intepreter, content): fs = MockFileSystem() file_path = None @@ -102,8 +110,8 @@ executive = Executive() self.assertRaises(AssertionError, executive.run_command, echo)
[webkit-changes] [106061] trunk/Source/WebCore
Title: [106061] trunk/Source/WebCore
Revision 106061
Author ander...@apple.com
Date 2012-01-26 16:31:29 -0800 (Thu, 26 Jan 2012)
Log Message
We don't need to always repaint overlay scrollbars if they're in layers
https://bugs.webkit.org/show_bug.cgi?id=77159
Reviewed by Beth Dakin.
If a scrollable area has overlay scrollbars we'll always invalidate both scrollbars, regardless of
whether both scroll offsets actually change since they're translucent and we want to draw the new page
contents underneath.
However, if the scrollbars are painted into GraphicsLayers they'll be composited by the GPU, and so we don't
need to repaint them unless the corresponding scroll offset actually changes (which is handled in Scrollbar::updateThumb).
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollableArea.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106060 => 106061)
--- trunk/Source/WebCore/ChangeLog 2012-01-27 00:16:24 UTC (rev 106060)
+++ trunk/Source/WebCore/ChangeLog 2012-01-27 00:31:29 UTC (rev 106061)
@@ -1,3 +1,20 @@
+2012-01-26 Anders Carlsson ander...@apple.com
+
+We don't need to always repaint overlay scrollbars if they're in layers
+https://bugs.webkit.org/show_bug.cgi?id=77159
+
+Reviewed by Beth Dakin.
+
+If a scrollable area has overlay scrollbars we'll always invalidate both scrollbars, regardless of
+whether both scroll offsets actually change since they're translucent and we want to draw the new page
+contents underneath.
+
+However, if the scrollbars are painted into GraphicsLayers they'll be composited by the GPU, and so we don't
+need to repaint them unless the corresponding scroll offset actually changes (which is handled in Scrollbar::updateThumb).
+
+* platform/ScrollableArea.cpp:
+(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
+
2012-01-26 Joshua Bell jsb...@chromium.org
IndexedDB: WebCore::IDBKey objects are leaked
Modified: trunk/Source/WebCore/platform/ScrollableArea.cpp (106060 => 106061)
--- trunk/Source/WebCore/platform/ScrollableArea.cpp 2012-01-27 00:16:24 UTC (rev 106060)
+++ trunk/Source/WebCore/platform/ScrollableArea.cpp 2012-01-27 00:31:29 UTC (rev 106061)
@@ -181,7 +181,7 @@
// Tell the scrollbars to update their thumb postions.
if (Scrollbar* horizontalScrollbar = this-horizontalScrollbar()) {
horizontalScrollbar-offsetDidChange();
-if (horizontalScrollbar-isOverlayScrollbar()) {
+if (horizontalScrollbar-isOverlayScrollbar() !hasLayerForHorizontalScrollbar()) {
if (!verticalScrollbar)
horizontalScrollbar-invalidate();
else {
@@ -195,7 +195,7 @@
}
if (verticalScrollbar) {
verticalScrollbar-offsetDidChange();
-if (verticalScrollbar-isOverlayScrollbar())
+if (verticalScrollbar-isOverlayScrollbar() !hasLayerForVerticalScrollbar())
verticalScrollbar-invalidate();
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106062] trunk/Tools
Title: [106062] trunk/Tools
Revision 106062
Author rn...@webkit.org
Date 2012-01-26 16:37:27 -0800 (Thu, 26 Jan 2012)
Log Message
run-perf-test should include relative file paths in test names
https://bugs.webkit.org/show_bug.cgi?id=77144
Reviewed by Adam Birth.
Include all directory names in the test name separated by /.
e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._process_parser_test_result):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (106061 => 106062)
--- trunk/Tools/ChangeLog 2012-01-27 00:31:29 UTC (rev 106061)
+++ trunk/Tools/ChangeLog 2012-01-27 00:37:27 UTC (rev 106062)
@@ -1,3 +1,20 @@
+2012-01-26 Ryosuke Niwa rn...@webkit.org
+
+run-perf-test should include relative file paths in test names
+https://bugs.webkit.org/show_bug.cgi?id=77144
+
+Reviewed by Adam Birth.
+
+Include all directory names in the test name separated by /.
+e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
+
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner):
+(PerfTestsRunner._process_parser_test_result):
+* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+(test_run_test_set_with_json_output):
+(test_run_test_set_with_json_source):
+
2012-01-26 Dirk Pranke dpra...@chromium.org
webkitpy: re-land cleanup of test scaffolding
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (106061 => 106062)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-01-27 00:31:29 UTC (rev 106061)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-01-27 00:37:27 UTC (rev 106062)
@@ -249,7 +249,7 @@
_lines_to_ignore_in_parser_result = [
re.compile(r'^Running \d+ times$'),
re.compile(r'^Ignoring warm-up '),
-re.compile(r'^\d+$'),
+re.compile(r'^\d+(.\d+)?$'),
]
def _should_ignore_line_in_parser_test_result(self, line):
@@ -281,7 +281,7 @@
if test_failed or set(keys) != set(results.keys()):
return True
-self._results[test_name] = results
+self._results[filesystem.join(category, test_name).replace('\\', '/')] = results
self._buildbot_output.write('RESULT %s: %s= %s ms\n' % (category, test_name, results['avg']))
self._buildbot_output.write(', '.join(['%s= %s ms' % (key, results[key]) for key in keys[1:]]) + '\n')
return False
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (106061 => 106062)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-01-27 00:31:29 UTC (rev 106061)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-01-27 00:37:27 UTC (rev 106062)
@@ -189,7 +189,7 @@
self.assertEqual(json.loads(runner._host.filesystem.files['/mock-checkout/output.json']), {
timestamp: 123456789, results:
-{event-target-wrapper: {max: 1510, avg: 1489.05, median: 1487, min: 1471, stdev: 14.46},
+{Bindings/event-target-wrapper: {max: 1510, avg: 1489.05, median: 1487, min: 1471, stdev: 14.46},
group_name:test_name: 42},
revision: 1234})
@@ -209,7 +209,7 @@
self.assertEqual(json.loads(runner._host.filesystem.files['/mock-checkout/output.json']), {
timestamp: 123456789, results:
-{event-target-wrapper: {max: 1510, avg: 1489.05, median: 1487, min: 1471, stdev: 14.46},
+{Bindings/event-target-wrapper: {max: 1510, avg: 1489.05, median: 1487, min: 1471, stdev: 14.46},
group_name:test_name: 42},
revision: 1234,
key: value})
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106063] trunk/Source/WebKit/chromium
Title: [106063] trunk/Source/WebKit/chromium Revision 106063 Author commit-qu...@webkit.org Date 2012-01-26 16:42:49 -0800 (Thu, 26 Jan 2012) Log Message Add GestureTapDown and GestureDoubleTap gesture types to WebGestureEvent. https://bugs.webkit.org/show_bug.cgi?id=77140 Patch by Sadrul Habib Chowdhury sad...@chromium.org on 2012-01-26 Reviewed by Darin Fisher. * public/WebInputEvent.h: (): * src/WebInputEventConversion.cpp: (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): * src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::handleInputEvent): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebInputEvent.h trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp trunk/Source/WebKit/chromium/src/WebViewImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (106062 => 106063) --- trunk/Source/WebKit/chromium/ChangeLog 2012-01-27 00:37:27 UTC (rev 106062) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-27 00:42:49 UTC (rev 106063) @@ -1,3 +1,19 @@ +2012-01-26 Sadrul Habib Chowdhury sad...@chromium.org + +Add GestureTapDown and GestureDoubleTap gesture types to WebGestureEvent. +https://bugs.webkit.org/show_bug.cgi?id=77140 + +Reviewed by Darin Fisher. + +* public/WebInputEvent.h: +(): +* src/WebInputEventConversion.cpp: +(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): +* src/WebPopupMenuImpl.cpp: +(WebKit::WebPopupMenuImpl::handleInputEvent): +* src/WebViewImpl.cpp: +(WebKit::WebViewImpl::handleInputEvent): + 2012-01-25 Cris Neckar c...@chromium.org Add API to register schemes which can be sent simple CORS requests. Modified: trunk/Source/WebKit/chromium/public/WebInputEvent.h (106062 => 106063) --- trunk/Source/WebKit/chromium/public/WebInputEvent.h 2012-01-27 00:37:27 UTC (rev 106062) +++ trunk/Source/WebKit/chromium/public/WebInputEvent.h 2012-01-27 00:42:49 UTC (rev 106063) @@ -107,6 +107,8 @@ GestureFlingStart, GestureFlingCancel, GestureTap, +GestureTapDown, +GestureDoubleTap, // WebTouchEvent TouchStart, Modified: trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp (106062 => 106063) --- trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp 2012-01-27 00:37:27 UTC (rev 106062) +++ trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp 2012-01-27 00:42:49 UTC (rev 106063) @@ -149,6 +149,12 @@ case WebInputEvent::GestureTap: m_type = PlatformEvent::GestureTap; break; +case WebInputEvent::GestureTapDown: +m_type = PlatformEvent::GestureTapDown; +break; +case WebInputEvent::GestureDoubleTap: +m_type = PlatformEvent::GestureDoubleTap; +break; default: ASSERT_NOT_REACHED(); } Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp (106062 => 106063) --- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2012-01-27 00:37:27 UTC (rev 106062) +++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2012-01-27 00:42:49 UTC (rev 106063) @@ -278,6 +278,8 @@ case WebInputEvent::GestureFlingStart: case WebInputEvent::GestureFlingCancel: case WebInputEvent::GestureTap: +case WebInputEvent::GestureTapDown: +case WebInputEvent::GestureDoubleTap: return GestureEvent(*static_castconst WebGestureEvent*(inputEvent)); case WebInputEvent::Undefined: Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (106062 => 106063) --- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-27 00:37:27 UTC (rev 106062) +++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-27 00:42:49 UTC (rev 106063) @@ -1413,6 +1413,8 @@ case WebInputEvent::GestureFlingStart: case WebInputEvent::GestureFlingCancel: case WebInputEvent::GestureTap: +case WebInputEvent::GestureTapDown: +case WebInputEvent::GestureDoubleTap: handled = gestureEvent(*static_castconst WebGestureEvent*(inputEvent)); break; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106064] trunk/Source/WebCore
Title: [106064] trunk/Source/WebCore
Revision 106064
Author c...@chromium.org
Date 2012-01-26 16:54:30 -0800 (Thu, 26 Jan 2012)
Log Message
The registration of schemes is currently racey as they are not registered from the main thread.
Getting rid of the assert that ensures that we are registering from the main thread until we can fix this.
Thank you ap@webkit for helping us identify this.
https://bugs.webkit.org/show_bug.cgi?id=77160
Reviewed by Adam Barth.
* platform/SchemeRegistry.cpp:
(WebCore::CORSEnabledSchemes):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/SchemeRegistry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106063 => 106064)
--- trunk/Source/WebCore/ChangeLog 2012-01-27 00:42:49 UTC (rev 106063)
+++ trunk/Source/WebCore/ChangeLog 2012-01-27 00:54:30 UTC (rev 106064)
@@ -1,3 +1,17 @@
+2012-01-26 Cris Neckar c...@chromium.org
+
+The registration of schemes is currently racey as they are not registered from the main thread.
+Getting rid of the assert that ensures that we are registering from the main thread until we can fix this.
+
+Thank you ap@webkit for helping us identify this.
+
+https://bugs.webkit.org/show_bug.cgi?id=77160
+
+Reviewed by Adam Barth.
+
+* platform/SchemeRegistry.cpp:
+(WebCore::CORSEnabledSchemes):
+
2012-01-26 Anders Carlsson ander...@apple.com
We don't need to always repaint overlay scrollbars if they're in layers
Modified: trunk/Source/WebCore/platform/SchemeRegistry.cpp (106063 => 106064)
--- trunk/Source/WebCore/platform/SchemeRegistry.cpp 2012-01-27 00:42:49 UTC (rev 106063)
+++ trunk/Source/WebCore/platform/SchemeRegistry.cpp 2012-01-27 00:54:30 UTC (rev 106064)
@@ -155,7 +155,7 @@
static URLSchemesMap CORSEnabledSchemes()
{
-ASSERT(isMainThread());
+// FIXME: http://bugs.webkit.org/show_bug.cgi?id=77160
DEFINE_STATIC_LOCAL(URLSchemesMap, CORSEnabledSchemes, ());
if (CORSEnabledSchemes.isEmpty()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106065] trunk/LayoutTests
Title: [106065] trunk/LayoutTests Revision 106065 Author commit-qu...@webkit.org Date 2012-01-26 17:08:15 -0800 (Thu, 26 Jan 2012) Log Message [Chromium]: svg/W3C-SVG-1.1/text-text-03-b.svg is marked as flakey, when it isn't https://bugs.webkit.org/show_bug.cgi?id=77157 Unreviewed Chromium expectations update to remove a no-longer-flakey test. Patch by Stephen Chenney schen...@chromium.org on 2012-01-26 * platform/chromium/test_expectations.txt: Removed svg/W3C-SVG-1.1/text-text-03-b.svg Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (106064 => 106065) --- trunk/LayoutTests/ChangeLog 2012-01-27 00:54:30 UTC (rev 106064) +++ trunk/LayoutTests/ChangeLog 2012-01-27 01:08:15 UTC (rev 106065) @@ -1,3 +1,12 @@ +2012-01-26 Stephen Chenney schen...@chromium.org + +[Chromium]: svg/W3C-SVG-1.1/text-text-03-b.svg is marked as flakey, when it isn't +https://bugs.webkit.org/show_bug.cgi?id=77157 + +Unreviewed Chromium expectations update to remove a no-longer-flakey test. + +* platform/chromium/test_expectations.txt: Removed svg/W3C-SVG-1.1/text-text-03-b.svg + 2012-01-26 Levi Weintraub le...@chromium.org compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106064 => 106065) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-27 00:54:30 UTC (rev 106064) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-27 01:08:15 UTC (rev 106065) @@ -2765,8 +2765,6 @@ BUGWK56060 LINUX : fast/images/favicon-as-image.html = IMAGE+TEXT -BUGCR75632 LINUX : svg/W3C-SVG-1.1/text-text-03-b.svg = PASS CRASH - // Test changed in Wk r80743, throws an exception rather than returning 'true' BUGCR75740 : fast/js/regexp-test-null-string.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106066] trunk/Tools
Title: [106066] trunk/Tools Revision 106066 Author o...@chromium.org Date 2012-01-26 17:14:06 -0800 (Thu, 26 Jan 2012) Log Message Remove builder name so http://trac.webkit.org/changeset/106035 actually works. https://bugs.webkit.org/show_bug.cgi?id=77164 Reviewed by Dirk Pranke. http://trac.webkit.org/changeset/106035 depends on builder_name being falsey by default. There's other code that requires it to be iterable by default. So, make it be the empty string. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py Diff Modified: trunk/Tools/ChangeLog (106065 => 106066) --- trunk/Tools/ChangeLog 2012-01-27 01:08:15 UTC (rev 106065) +++ trunk/Tools/ChangeLog 2012-01-27 01:14:06 UTC (rev 106066) @@ -1,3 +1,17 @@ +2012-01-26 Ojan Vafai o...@chromium.org + +Remove builder name so http://trac.webkit.org/changeset/106035 actually works. +https://bugs.webkit.org/show_bug.cgi?id=77164 + +Reviewed by Dirk Pranke. + +http://trac.webkit.org/changeset/106035 depends on builder_name being +falsey by default. There's other code that requires it to be iterable +by default. So, make it be the empty string. + +* Scripts/webkitpy/layout_tests/run_webkit_tests.py: +(parse_args): + 2012-01-26 Ryosuke Niwa rn...@webkit.org run-perf-test should include relative file paths in test names Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (106065 => 106066) --- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-01-27 01:08:15 UTC (rev 106065) +++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-01-27 01:14:06 UTC (rev 106066) @@ -435,7 +435,7 @@ # FIXME: Move these into json_results_generator.py results_json_options = [ optparse.make_option(--master-name, help=The name of the buildbot master.), -optparse.make_option(--builder-name, default=DUMMY_BUILDER_NAME, +optparse.make_option(--builder-name, default=, help=(The name of the builder shown on the waterfall running this script e.g. WebKit.)), optparse.make_option(--build-name, default=DUMMY_BUILD_NAME, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106068] branches/safari-534.54-branch/Source/WebKit2
Title: [106068] branches/safari-534.54-branch/Source/WebKit2 Revision 106068 Author mr...@apple.com Date 2012-01-26 17:30:24 -0800 (Thu, 26 Jan 2012) Log Message Merge r102497. Modified Paths branches/safari-534.54-branch/Source/WebKit2/ChangeLog branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm branches/safari-534.54-branch/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Added Paths branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm Diff Modified: branches/safari-534.54-branch/Source/WebKit2/ChangeLog (106067 => 106068) --- branches/safari-534.54-branch/Source/WebKit2/ChangeLog 2012-01-27 01:15:16 UTC (rev 106067) +++ branches/safari-534.54-branch/Source/WebKit2/ChangeLog 2012-01-27 01:30:24 UTC (rev 106068) @@ -1,3 +1,38 @@ +2012-01-26 Mark Rowe mr...@apple.com + +Merge r102497. + +2011-12-07 Mark Rowe mr...@apple.com + +http://webkit.org/b/74061 WebProcess and PluginProcess should inherit environment +variables provided in LC_DYLD_ENVIRONMENT of main executable binary. + +Reviewed by Darin Adler. + +* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: Added. +* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: Added. +(WebKit::DynamicLinkerEnvironmentExtractor::DynamicLinkerEnvironmentExtractor): +(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable): Parse out the name +and value from the environment string and add an entry to our variable map if the variable +is one that dyld would respect in LC_DYLD_ENVIRONMENT. +(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommand): Look for a LC_DYLD_ENVIRONMENT +load command and extract any environment string that we find within. +(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommands): Iterate over each +load command in the Mach-O file. +(WebKit::DynamicLinkerEnvironmentExtractor::processSingleArchitecture): Determine whether +the Mach-O file is of the correct architecture, and if so then process the load commands +found within. +(WebKit::DynamicLinkerEnvironmentExtractor::processFatFile): Process each architecture of the +Mach-O file in turn. +(WebKit::DynamicLinkerEnvironmentExtractor::getExtractedEnvironmentVariables): Add our +extracted variables to the passed-in EnvironmentVariables object. We skip adding any +variables that already exist so as to allow variables passed in the environment to override +those that we extract from the executable file. +* UIProcess/Launcher/mac/ProcessLauncherMac.mm: +(WebKit::ProcessLauncher::launchProcess): Extract the environment variables from the +main binary and add them to the launch environment of our subprocess. +* WebKit2.xcodeproj/project.pbxproj: + 2012-01-25 Mark Rowe mr...@apple.com Merge r105942. Added: branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h (0 => 106068) --- branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h (rev 0) +++ branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h 2012-01-27 01:30:24 UTC (rev 106068) @@ -0,0 +1,62 @@ +/* + * Copyright (C) 2011 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef
[webkit-changes] [106070] branches/safari-534.54-branch/Source/WebKit2
Title: [106070] branches/safari-534.54-branch/Source/WebKit2 Revision 106070 Author mr...@apple.com Date 2012-01-26 17:30:33 -0800 (Thu, 26 Jan 2012) Log Message Merge r102507. Modified Paths branches/safari-534.54-branch/Source/WebKit2/ChangeLog branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm Diff Modified: branches/safari-534.54-branch/Source/WebKit2/ChangeLog (106069 => 106070) --- branches/safari-534.54-branch/Source/WebKit2/ChangeLog 2012-01-27 01:30:29 UTC (rev 106069) +++ branches/safari-534.54-branch/Source/WebKit2/ChangeLog 2012-01-27 01:30:33 UTC (rev 106070) @@ -1,5 +1,17 @@ 2012-01-26 Mark Rowe mr...@apple.com +Merge r102507. + +2011-12-09 Mark Rowe mr...@apple.com + +Fix the Snow Leopard build some more. + +Move the #if to a location where it will do some good. + +* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: + +2012-01-26 Mark Rowe mr...@apple.com + Merge r102504. 2011-12-09 Mark Rowe mr...@apple.com Modified: branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm (106069 => 106070) --- branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm 2012-01-27 01:30:29 UTC (rev 106069) +++ branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm 2012-01-27 01:30:33 UTC (rev 106070) @@ -23,11 +23,11 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ -#ifndef BUILDING_ON_SNOW_LEOPARD - #include config.h #include DynamicLinkerEnvironmentExtractor.h +#ifndef BUILDING_ON_SNOW_LEOPARD + #include EnvironmentVariables.h #include mach-o/loader.h #include mach-o/swap.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106069] branches/safari-534.54-branch/Source/WebKit2
Title: [106069] branches/safari-534.54-branch/Source/WebKit2 Revision 106069 Author mr...@apple.com Date 2012-01-26 17:30:29 -0800 (Thu, 26 Jan 2012) Log Message Merge r102504. Modified Paths branches/safari-534.54-branch/Source/WebKit2/ChangeLog branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm Diff Modified: branches/safari-534.54-branch/Source/WebKit2/ChangeLog (106068 => 106069) --- branches/safari-534.54-branch/Source/WebKit2/ChangeLog 2012-01-27 01:30:24 UTC (rev 106068) +++ branches/safari-534.54-branch/Source/WebKit2/ChangeLog 2012-01-27 01:30:29 UTC (rev 106069) @@ -1,5 +1,20 @@ 2012-01-26 Mark Rowe mr...@apple.com +Merge r102504. + +2011-12-09 Mark Rowe mr...@apple.com + +Fix the Snow Leopard build. + +Wrap some code that is only applicable to Lion and newer in the appropriate #if's. + +* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: +* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: +* UIProcess/Launcher/mac/ProcessLauncherMac.mm: +(WebKit::ProcessLauncher::launchProcess): + +2012-01-26 Mark Rowe mr...@apple.com + Merge r102497. 2011-12-07 Mark Rowe mr...@apple.com Modified: branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h (106068 => 106069) --- branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h 2012-01-27 01:30:24 UTC (rev 106068) +++ branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h 2012-01-27 01:30:29 UTC (rev 106069) @@ -26,6 +26,8 @@ #ifndef DynamicLinkerEnvironmentExtractor_h #define DynamicLinkerEnvironmentExtractor_h +#ifndef BUILDING_ON_SNOW_LEOPARD + #include mach/machine.h #include wtf/Noncopyable.h #include wtf/RetainPtr.h @@ -59,4 +61,6 @@ } // namespace WebKit +#endif // BUILDING_ON_SNOW_LEOPARD + #endif // DynamicLinkerEnvironmentExtractor_h Modified: branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm (106068 => 106069) --- branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm 2012-01-27 01:30:24 UTC (rev 106068) +++ branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm 2012-01-27 01:30:29 UTC (rev 106069) @@ -23,6 +23,8 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ +#ifndef BUILDING_ON_SNOW_LEOPARD + #include config.h #include DynamicLinkerEnvironmentExtractor.h @@ -198,3 +200,5 @@ } } // namespace WebKit + +#endif // BUILDING_ON_SNOW_LEOPARD Modified: branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm (106068 => 106069) --- branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2012-01-27 01:30:24 UTC (rev 106068) +++ branches/safari-534.54-branch/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2012-01-27 01:30:29 UTC (rev 106069) @@ -137,8 +137,10 @@ EnvironmentVariables environmentVariables; +#ifndef BUILDING_ON_SNOW_LEOPARD DynamicLinkerEnvironmentExtractor environmentExtractor([[NSBundle mainBundle] executablePath], architecture); environmentExtractor.getExtractedEnvironmentVariables(environmentVariables); +#endif // To make engineering builds work, if the path is outside of /System set up // DYLD_FRAMEWORK_PATH to pick up other frameworks, but don't do it for the ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106071] branches/safari-534.54-branch/Source/JavaScriptCore
Title: [106071] branches/safari-534.54-branch/Source/_javascript_Core
Revision 106071
Author mhahnenb...@apple.com
Date 2012-01-26 17:35:52 -0800 (Thu, 26 Jan 2012)
Log Message
2012-01-26 Mark Hahnenberg mhahnenb...@apple.com
Hang in parallel GC caused by incorrect GCC asm codegen
Reviewed by Filip Pizlo.
rdar://problem/10742649
* wtf/Atomics.h:
(WTF::weakCompareAndSwap): Mark the argument volatile to force GCC to do the right thing.
Modified Paths
branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h
Diff
Modified: branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog (106070 => 106071)
--- branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog 2012-01-27 01:30:33 UTC (rev 106070)
+++ branches/safari-534.54-branch/Source/_javascript_Core/ChangeLog 2012-01-27 01:35:52 UTC (rev 106071)
@@ -1,3 +1,13 @@
+2012-01-26 Mark Hahnenberg mhahnenb...@apple.com
+
+Hang in parallel GC caused by incorrect GCC asm codegen
+Reviewed by Filip Pizlo.
+
+rdar://problem/10742649
+
+* wtf/Atomics.h:
+(WTF::weakCompareAndSwap): Mark the argument volatile to force GCC to do the right thing.
+
2012-01-25 Mark Rowe mr...@apple.com
Merge r105942.
Modified: branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h (106070 => 106071)
--- branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h 2012-01-27 01:30:33 UTC (rev 106070)
+++ branches/safari-534.54-branch/Source/_javascript_Core/wtf/Atomics.h 2012-01-27 01:35:52 UTC (rev 106071)
@@ -118,7 +118,7 @@
#endif
-inline bool weakCompareAndSwap(unsigned* location, unsigned expected, unsigned newValue)
+inline bool weakCompareAndSwap(volatile unsigned* location, unsigned expected, unsigned newValue)
{
#if ENABLE(COMPARE_AND_SWAP)
bool result;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106072] trunk
Title: [106072] trunk
Revision 106072
Author aba...@webkit.org
Date 2012-01-26 17:55:36 -0800 (Thu, 26 Jan 2012)
Log Message
NULL ptr in WebCore::ContainerNode::parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=76258
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/parser/nested-fragment-parser-crash.html
We always need a parent element to attach to. In crazy cases, we can
have elements in the stack of open elements that are already detached
from the DOM. In those cases, they don't have a parent, so we aren't
able to enforce the maximum DOM depth. (Fortunately, they're not
attached to the DOM anymore so we don't need to enforce the maximum DOM
depth!)
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::fosterParent):
LayoutTests:
This crazy test case causes the parser to do all manner of crazy
things, which is good times for testing.
* fast/parser/nested-fragment-parser-crash-expected.txt: Added.
* fast/parser/nested-fragment-parser-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp
Added Paths
trunk/LayoutTests/fast/parser/nested-fragment-parser-crash-expected.txt
trunk/LayoutTests/fast/parser/nested-fragment-parser-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (106071 => 106072)
--- trunk/LayoutTests/ChangeLog 2012-01-27 01:35:52 UTC (rev 106071)
+++ trunk/LayoutTests/ChangeLog 2012-01-27 01:55:36 UTC (rev 106072)
@@ -1,3 +1,16 @@
+2012-01-26 Adam Barth aba...@webkit.org
+
+NULL ptr in WebCore::ContainerNode::parserAddChild
+https://bugs.webkit.org/show_bug.cgi?id=76258
+
+Reviewed by Eric Seidel.
+
+This crazy test case causes the parser to do all manner of crazy
+things, which is good times for testing.
+
+* fast/parser/nested-fragment-parser-crash-expected.txt: Added.
+* fast/parser/nested-fragment-parser-crash.html: Added.
+
2012-01-25 Filip Pizlo fpi...@apple.com
All DFG helpers that may call out to arbitrary JS code must know where they
Added: trunk/LayoutTests/fast/parser/nested-fragment-parser-crash-expected.txt (0 => 106072)
--- trunk/LayoutTests/fast/parser/nested-fragment-parser-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/parser/nested-fragment-parser-crash-expected.txt 2012-01-27 01:55:36 UTC (rev 106072)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 19: Uncaught RangeError: Maximum call stack size exceeded.
+x
+x This test passes if it doesn't crash.
Added: trunk/LayoutTests/fast/parser/nested-fragment-parser-crash.html (0 => 106072)
--- trunk/LayoutTests/fast/parser/nested-fragment-parser-crash.html (rev 0)
+++ trunk/LayoutTests/fast/parser/nested-fragment-parser-crash.html 2012-01-27 01:55:36 UTC (rev 106072)
@@ -0,0 +1,22 @@
+xh4strikex
+This test passes if it doesn't crash.
+script
+ if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+ var counter = 0;
+ window._onload_=function(){
+document.execCommand(SelectAll);
+document.designMode=on;
+document.execCommand(Indent);
+document.execCommand(InsertOrderedList, false);
+ };
+ function handler() {
+// This constant is somewhat magic. It's the smallest constant such that
+// we'll exceed the maxium call stack size.
+if (++counter = 34)
+ document.removeEventListener(DOMSubtreeModified, handler, false);
+document.execCommand(outdent, false);
+ };
+ document.addEventListener(DOMSubtreeModified, handler, false);
+/script
Modified: trunk/Source/WebCore/ChangeLog (106071 => 106072)
--- trunk/Source/WebCore/ChangeLog 2012-01-27 01:35:52 UTC (rev 106071)
+++ trunk/Source/WebCore/ChangeLog 2012-01-27 01:55:36 UTC (rev 106072)
@@ -1,3 +1,23 @@
+2012-01-26 Adam Barth aba...@webkit.org
+
+NULL ptr in WebCore::ContainerNode::parserAddChild
+https://bugs.webkit.org/show_bug.cgi?id=76258
+
+Reviewed by Eric Seidel.
+
+Test: fast/parser/nested-fragment-parser-crash.html
+
+We always need a parent element to attach to. In crazy cases, we can
+have elements in the stack of open elements that are already detached
+from the DOM. In those cases, they don't have a parent, so we aren't
+able to enforce the maximum DOM depth. (Fortunately, they're not
+attached to the DOM anymore so we don't need to enforce the maximum DOM
+depth!)
+
+* html/parser/HTMLConstructionSite.cpp:
+(WebCore::HTMLConstructionSite::attachLater):
+(WebCore::HTMLConstructionSite::fosterParent):
+
2012-01-26 Cris Neckar c...@chromium.org
The registration of schemes is currently racey as they are not registered from the main thread.
Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (106071 => 106072)
---
[webkit-changes] [106073] trunk/Source/WebCore
Title: [106073] trunk/Source/WebCore Revision 106073 Author ander...@apple.com Date 2012-01-26 18:01:47 -0800 (Thu, 26 Jan 2012) Log Message Scrollbars disappear when switching from legacy to overlay scrollbars https://bugs.webkit.org/show_bug.cgi?id=77166 Reviewed by Dan Bernstein. * platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarStyleChanged): Call positionScrollbarLayers to make sure that the new scrollbar layers are positioned correctly. * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::updateScrollerStyle): Call ScrollbarThemeMac::setNewPainterForScrollbar after making the call to the scrollbar painter controller to set the horizontal or vertical imp, since setting the imp will reset the knob style. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ScrollView.cpp trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (106072 => 106073) --- trunk/Source/WebCore/ChangeLog 2012-01-27 01:55:36 UTC (rev 106072) +++ trunk/Source/WebCore/ChangeLog 2012-01-27 02:01:47 UTC (rev 106073) @@ -1,3 +1,19 @@ +2012-01-26 Anders Carlsson ander...@apple.com + +Scrollbars disappear when switching from legacy to overlay scrollbars +https://bugs.webkit.org/show_bug.cgi?id=77166 + +Reviewed by Dan Bernstein. + +* platform/ScrollView.cpp: +(WebCore::ScrollView::scrollbarStyleChanged): +Call positionScrollbarLayers to make sure that the new scrollbar layers are positioned correctly. + +* platform/mac/ScrollAnimatorMac.mm: +(WebCore::ScrollAnimatorMac::updateScrollerStyle): +Call ScrollbarThemeMac::setNewPainterForScrollbar after making the call to the scrollbar painter controller +to set the horizontal or vertical imp, since setting the imp will reset the knob style. + 2012-01-26 Adam Barth aba...@webkit.org NULL ptr in WebCore::ContainerNode::parserAddChild Modified: trunk/Source/WebCore/platform/ScrollView.cpp (106072 => 106073) --- trunk/Source/WebCore/platform/ScrollView.cpp 2012-01-27 01:55:36 UTC (rev 106072) +++ trunk/Source/WebCore/platform/ScrollView.cpp 2012-01-27 02:01:47 UTC (rev 106073) @@ -991,6 +991,7 @@ contentsResized(); updateScrollbars(scrollOffset()); +positionScrollbarLayers(); } void ScrollView::updateScrollCorner() Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (106072 => 106073) --- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-27 01:55:36 UTC (rev 106072) +++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-01-27 02:01:47 UTC (rev 106073) @@ -1090,8 +1090,8 @@ controlSize:(NSControlSize)verticalScrollbar-controlSize() horizontal:NO replacingScrollerImp:oldVerticalPainter]; +[m_scrollbarPainterController.get() setVerticalScrollerImp:newVerticalPainter]; macTheme-setNewPainterForScrollbar(verticalScrollbar, newVerticalPainter); -[m_scrollbarPainterController.get() setVerticalScrollerImp:newVerticalPainter]; // The different scrollbar styles have different thicknesses, so we must re-set the // frameRect to the new thickness, and the re-layout below will ensure the position @@ -1108,8 +1108,8 @@ controlSize:(NSControlSize)horizontalScrollbar-controlSize() horizontal:YES replacingScrollerImp:oldHorizontalPainter]; +[m_scrollbarPainterController.get() setHorizontalScrollerImp:newHorizontalPainter]; macTheme-setNewPainterForScrollbar(horizontalScrollbar, newHorizontalPainter); -[m_scrollbarPainterController.get() setHorizontalScrollerImp:newHorizontalPainter]; // The different scrollbar styles have different thicknesses, so we must re-set the // frameRect to the new thickness, and the re-layout below will ensure the position ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
