[webkit-changes] [107044] trunk/Source/WebKit2

[philn]

Title: [107044] trunk/Source/WebKit2








Revision 107044
Author ph...@webkit.org
Date 2012-02-08 00:05:05 -0800 (Wed, 08 Feb 2012)


Log Message
[GTK][WK2] enable-webaudio WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77959

Reviewed by Martin Robinson.

Add a new WebKitGTK WebSetting to enable/disable WebAudio at
runtime.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (107043 => 107044)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 07:21:31 UTC (rev 107043)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 08:05:05 UTC (rev 107044)
@@ -1,3 +1,23 @@
+2012-02-08  Philippe Normand  pnorm...@igalia.com
+
+[GTK][WK2] enable-webaudio WebSetting
+https://bugs.webkit.org/show_bug.cgi?id=77959
+
+Reviewed by Martin Robinson.
+
+Add a new WebKitGTK WebSetting to enable/disable WebAudio at
+runtime.
+
+* UIProcess/API/gtk/WebKitSettings.cpp:
+(webKitSettingsSetProperty):
+(webKitSettingsGetProperty):
+(webkit_settings_class_init):
+(webkit_settings_get_enable_webaudio):
+(webkit_settings_set_enable_webaudio):
+* UIProcess/API/gtk/WebKitSettings.h:
+* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
+(testWebKitSettings):
+
 2012-02-07  Martin Robinson  mrobin...@igalia.com
 
 [GTK] [WK2] Add WebKitResponsePolicyDecision


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (107043 => 107044)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2012-02-08 07:21:31 UTC (rev 107043)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2012-02-08 08:05:05 UTC (rev 107044)
@@ -101,7 +101,8 @@
 PROP_ENABLE_DNS_PREFETCHING,
 PROP_ENABLE_CARET_BROWSING,
 PROP_ENABLE_FULLSCREEN,
-PROP_PRINT_BACKGROUNDS
+PROP_PRINT_BACKGROUNDS,
+PROP_ENABLE_WEBAUDIO
 };
 
 static void webKitSettingsSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec)
@@ -202,6 +203,9 @@
 case PROP_PRINT_BACKGROUNDS:
 webkit_settings_set_print_backgrounds(settings, g_value_get_boolean(value));
 break;
+case PROP_ENABLE_WEBAUDIO:
+webkit_settings_set_enable_webaudio(settings, g_value_get_boolean(value));
+break;
 default:
 G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec);
 break;
@@ -306,6 +310,9 @@
 case PROP_PRINT_BACKGROUNDS:
 g_value_set_boolean(value, webkit_settings_get_print_backgrounds(settings));
 break;
+case PROP_ENABLE_WEBAUDIO:
+g_value_set_boolean(value, webkit_settings_get_enable_webaudio(settings));
+break;
 default:
 G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec);
 break;
@@ -768,6 +775,25 @@
  TRUE,
  readWriteConstructParamFlags));
 
+/**
+ * WebKitSettings:enable-webaudio:
+ *
+ *
+ * Enable or disable support for WebAudio on pages. WebAudio is an
+ * experimental proposal for allowing web pages to generate Audio
+ * WAVE data from _javascript_. The standard is currently a
+ * work-in-progress by the W3C Audio Working Group.
+ *
+ * See also https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
+ */
+g_object_class_install_property(gObjectClass,
+PROP_ENABLE_WEBAUDIO,
+g_param_spec_boolean(enable-webaudio,
+ _(Enable WebAudio),
+ _(Whether WebAudio content should be handled),
+ FALSE,
+ readWriteConstructParamFlags));
+
 g_type_class_add_private(klass, sizeof(WebKitSettingsPrivate));
 }
 
@@ -1955,3 +1981,38 @@
 WKPreferencesSetShouldPrintBackgrounds(priv-preferences.get(), printBackgrounds);
 g_object_notify(G_OBJECT(settings), print-backgrounds);
 }
+
+/**
+ * webkit_settings_get_enable_webaudio:
+ * @settings: a #WebKitSettings
+ *
+ * Get the #WebKitSettings:enable-webaudio property.
+ *
+ * Returns: %TRUE If webaudio support is enabled or %FALSE otherwise.
+ */
+gboolean 

[webkit-changes] [107045] trunk/Source/WebCore

[haraken]

Title: [107045] trunk/Source/WebCore








Revision 107045
Author hara...@chromium.org
Date 2012-02-08 00:05:56 -0800 (Wed, 08 Feb 2012)


Log Message
Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
https://bugs.webkit.org/show_bug.cgi?id=78081

Reviewed by Adam Barth.

[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
This patch renames it to [JSCustomPushEventHandlerScope]

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* dom/Node.idl:
* html/HTMLElement.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/dom/Node.idl
trunk/Source/WebCore/html/HTMLElement.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (107044 => 107045)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 08:05:05 UTC (rev 107044)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 08:05:56 UTC (rev 107045)
@@ -1,3 +1,20 @@
+2012-02-08  Kentaro Hara  hara...@chromium.org
+
+Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
+https://bugs.webkit.org/show_bug.cgi?id=78081
+
+Reviewed by Adam Barth.
+
+[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
+This patch renames it to [JSCustomPushEventHandlerScope]
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+* dom/Node.idl:
+* html/HTMLElement.idl:
+
 2012-02-06  Kentaro Hara  hara...@chromium.org
 
 Add JS prefix to JSC-specific IDLs


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (107044 => 107045)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-08 08:05:05 UTC (rev 107044)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-08 08:05:56 UTC (rev 107045)
@@ -813,7 +813,7 @@
 push(@headerContent, }\n\n);
 
 # Custom pushEventHandlerScope function
-push(@headerContent, JSC::ScopeChainNode* pushEventHandlerScope(JSC::ExecState*, JSC::ScopeChainNode*) const;\n\n) if $dataNode-extendedAttributes-{CustomPushEventHandlerScope};
+push(@headerContent, JSC::ScopeChainNode* pushEventHandlerScope(JSC::ExecState*, JSC::ScopeChainNode*) const;\n\n) if $dataNode-extendedAttributes-{JSCustomPushEventHandlerScope};
 
 # Custom call functions
 push(@headerContent, static JSC::CallType getCallData(JSC::JSCell*, JSC::CallData);\n\n) if $dataNode-extendedAttributes-{CustomCall};


Modified: trunk/Source/WebCore/dom/Node.idl (107044 => 107045)

--- trunk/Source/WebCore/dom/Node.idl	2012-02-08 08:05:05 UTC (rev 107044)
+++ trunk/Source/WebCore/dom/Node.idl	2012-02-08 08:05:56 UTC (rev 107045)
@@ -23,7 +23,7 @@
 interface [
 CustomHeader,
 JSCustomMarkFunction,
-CustomPushEventHandlerScope,
+JSCustomPushEventHandlerScope,
 JSCustomIsReachable,
 JSCustomFinalize,
 JSCustomToJS,


Modified: trunk/Source/WebCore/html/HTMLElement.idl (107044 => 107045)

--- trunk/Source/WebCore/html/HTMLElement.idl	2012-02-08 08:05:05 UTC (rev 107044)
+++ trunk/Source/WebCore/html/HTMLElement.idl	2012-02-08 08:05:56 UTC (rev 107045)
@@ -22,7 +22,7 @@
 
 interface [
 JSGenerateToNativeObject,
-CustomPushEventHandlerScope
+JSCustomPushEventHandlerScope
 ] HTMLElement : Element {
  // iht.com relies on id returning the empty string when no id is present. 
  // Other browsers do this as well. So we don't convert null to JS null.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107046] trunk

[haraken]

Title: [107046] trunk








Revision 107046
Author hara...@chromium.org
Date 2012-02-08 00:13:58 -0800 (Wed, 08 Feb 2012)


Log Message
Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971

Reviewed by Adam Barth.

Source/WebCore:

[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].

Test: http/tests/security/cross-frame-access-frameelement.html

* page/DOMWindow.idl:

LayoutTests:

The added test checks if frameElement is accessible from the same or cross origin iframe.

* http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
* http/tests/security/cross-frame-access-frameelement.html: Added.
* http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/http/tests/security/cross-frame-access-put-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.idl


Added Paths

trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement-expected.txt
trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement.html
trunk/LayoutTests/http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107045 => 107046)

--- trunk/LayoutTests/ChangeLog	2012-02-08 08:05:56 UTC (rev 107045)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 08:13:58 UTC (rev 107046)
@@ -1,3 +1,17 @@
+2012-02-08  Kentaro Hara  hara...@chromium.org
+
+Replace [CheckNodeSecurity] with [CheckAccessToNode]
+https://bugs.webkit.org/show_bug.cgi?id=77971
+
+Reviewed by Adam Barth.
+
+The added test checks if frameElement is accessible from the same or cross origin iframe.
+
+* http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
+* http/tests/security/cross-frame-access-frameelement.html: Added.
+* http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
+* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
+
 2012-02-07  Robert Kroeger  rjkro...@chromium.org
 
 [chromium] Remove unnecessary Chromium gesture recognizer tests.


Added: trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement-expected.txt (0 => 107046)

--- trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement-expected.txt	2012-02-08 08:13:58 UTC (rev 107046)
@@ -0,0 +1,15 @@
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-frameelement.html from frame with URL http://127.0.0.1:8080/security/resources/cross-frame-access-frameelement-from-iframe.html. Domains, protocols and ports must match.
+
+This test checks if frameElement is accessible from the same or cross origin iframe.
+
+ 
+
+
+Frame: '!--framePath //!--frame0'
+
+[object HTMLIFrameElement]
+
+
+Frame: '!--framePath //!--frame1'
+
+undefined


Added: trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement.html (0 => 107046)

--- trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/cross-frame-access-frameelement.html	2012-02-08 08:13:58 UTC (rev 107046)
@@ -0,0 +1,15 @@
+html
+head
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.dumpChildFramesAsText();
+}
+/script
+/head
+body
+pThis test checks if frameElement is accessible from the same or cross origin iframe./p
+iframe src=""
+iframe src=""
+/body
+/html


Added: trunk/LayoutTests/http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html (0 => 107046)

--- trunk/LayoutTests/http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html	2012-02-08 08:13:58 UTC (rev 107046)
@@ -0,0 +1,7 @@
+body
+div id=console/div
+script src=""
+script
+log(eval(window.frameElement));
+/script
+/body


Modified: trunk/LayoutTests/platform/chromium/http/tests/security/cross-frame-access-put-expected.txt (107045 => 107046)

--- trunk/LayoutTests/platform/chromium/http/tests/security/cross-frame-access-put-expected.txt	2012-02-08 08:05:56 UTC (rev 107045)
+++ trunk/LayoutTests/platform/chromium/http/tests/security/cross-frame-access-put-expected.txt	2012-02-08 08:13:58 UTC (rev 107046)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL 

[webkit-changes] [107047] trunk/LayoutTests

[dmazzoni]

Title: [107047] trunk/LayoutTests








Revision 107047
Author dmazz...@google.com
Date 2012-02-08 00:29:22 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed, updating expectations to SKIP test that times out or crashes on most platforms.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107046 => 107047)

--- trunk/LayoutTests/ChangeLog	2012-02-08 08:13:58 UTC (rev 107046)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 08:29:22 UTC (rev 107047)
@@ -1,3 +1,10 @@
+2012-02-08  Dominic Mazzoni  dmazz...@google.com
+
+Unreviewed, skipping test that times out or crashes on most platforms.
+https://bugs.webkit.org/show_bug.cgi?id=73912
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-08  Kentaro Hara  hara...@chromium.org
 
 Replace [CheckNodeSecurity] with [CheckAccessToNode]


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107046 => 107047)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 08:13:58 UTC (rev 107046)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 08:29:22 UTC (rev 107047)
@@ -1075,8 +1075,8 @@
 BUGCR10322 SKIP : accessibility/transformed-element.html = TEXT
 BUGCR10322 SKIP : accessibility/visible-elements.html = TEXT
 
-BUGWK73912 WIN LINUX SNOWLEOPARD : accessibility/aria-checkbox-text.html = TIMEOUT PASS
-BUGWK73912 LEOPARD : accessibility/aria-checkbox-text.html = CRASH PASS
+BUGWK73912 SKIP : accessibility/aria-checkbox-text.html = TIMEOUT PASS
+
 BUGWK73912 LEOPARD : accessibility/aria-checkbox-sends-notification.html = CRASH TEXT PASS
 BUGWK73912 SNOWLEOPARD : accessibility/aria-checkbox-sends-notification.html = TEXT PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107048] trunk/LayoutTests

[podivilov]

Title: [107048] trunk/LayoutTests








Revision 107048
Author podivi...@chromium.org
Date 2012-02-08 00:37:01 -0800 (Wed, 08 Feb 2012)


Log Message
2012-02-08  Pavel Podivilov  podivi...@chromium.org

Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107047 => 107048)

--- trunk/LayoutTests/ChangeLog	2012-02-08 08:29:22 UTC (rev 107047)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 08:37:01 UTC (rev 107048)
@@ -1,3 +1,9 @@
+2012-02-08  Pavel Podivilov  podivi...@chromium.org
+
+Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-08  Dominic Mazzoni  dmazz...@google.com
 
 Unreviewed, skipping test that times out or crashes on most platforms.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107047 => 107048)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 08:29:22 UTC (rev 107047)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 08:37:01 UTC (rev 107048)
@@ -3951,7 +3951,6 @@
 BUGWK77310 : fast/js/navigator-language.html = PASS TEXT
 
 BUGWK77314 WIN MAC : fast/events/touch/send-oncancel-event.html = PASS TEXT
-BUGWK77315 WIN MAC : fast/events/touch/touch-gesture-scroll.html = PASS TEXT
 BUGWK77324 WIN MAC DEBUG SLOW : fast/js/dfg-int32array.html = PASS
 
 BUGWK77397 : plugins/crash-restoring-plugin-page-from-page-cache.html = TIMEOUT TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107049] trunk/LayoutTests

[zimmermann]

Title: [107049] trunk/LayoutTests








Revision 107049
Author zimmerm...@webkit.org
Date 2012-02-08 00:47:02 -0800 (Wed, 08 Feb 2012)


Log Message
2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com

Not reviewed. Add missing results for a new SVG test.

* platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac/svg/custom/use-disappears-after-style-update-expected.png
trunk/LayoutTests/platform/mac/svg/custom/use-disappears-after-style-update-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107048 => 107049)

--- trunk/LayoutTests/ChangeLog	2012-02-08 08:37:01 UTC (rev 107048)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 08:47:02 UTC (rev 107049)
@@ -1,3 +1,10 @@
+2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
+
+Not reviewed. Add missing results for a new SVG test.
+
+* platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
+* platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+
 2012-02-08  Pavel Podivilov  podivi...@chromium.org
 
 Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.


Added: trunk/LayoutTests/platform/mac/svg/custom/use-disappears-after-style-update-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/mac/svg/custom/use-disappears-after-style-update-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/mac/svg/custom/use-disappears-after-style-update-expected.txt (0 => 107049)

--- trunk/LayoutTests/platform/mac/svg/custom/use-disappears-after-style-update-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/svg/custom/use-disappears-after-style-update-expected.txt	2012-02-08 08:47:02 UTC (rev 107049)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 300x400
+  RenderSVGRoot {svg} at (10,10) size 76x36
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+  RenderSVGResourceFilter {filter} [id=simple] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feOffset dx=0.00 dy=0.00]
+  [SourceGraphic]
+  RenderSVGRect {rect} at (0,10) size 30x30 [fill={[type=SOLID] [color=#008000]}] [x=0.00] [y=10.00] [width=30.00] [height=30.00]
+RenderSVGContainer {g} at (10,10) size 76x36
+  RenderSVGContainer {use} at (10,10) size 30x30
+RenderSVGContainer {g} at (10,10) size 30x30 [transform={m=((1.00,0.00)(0.00,1.00)) t=(10.00,0.00)}]
+  RenderSVGRect {rect} at (10,10) size 30x30 [fill={[type=SOLID] [color=#008000]}] [x=0.00] [y=10.00] [width=30.00] [height=30.00]
+  RenderSVGContainer {use} at (50,10) size 36x36
+[filter=simple] RenderSVGResourceFilter {filter} at (50,10) size 36x36
+RenderSVGContainer {g} at (50,10) size 30x30 [transform={m=((1.00,0.00)(0.00,1.00)) t=(50.00,0.00)}]
+  RenderSVGRect {rect} at (50,10) size 30x30 [fill={[type=SOLID] [color=#008000]}] [x=0.00] [y=10.00] [width=30.00] [height=30.00]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107050] trunk

[commit-queue]

Title: [107050] trunk








Revision 107050
Author commit-qu...@webkit.org
Date 2012-02-08 00:57:08 -0800 (Wed, 08 Feb 2012)


Log Message
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka shin...@google.com on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/html/HTMLDetailsElement.cpp
trunk/Source/WebCore/html/HTMLKeygenElement.cpp
trunk/Source/WebCore/html/HTMLMeterElement.cpp
trunk/Source/WebCore/html/HTMLProgressElement.cpp
trunk/Source/WebCore/html/HTMLSummaryElement.cpp
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (107049 => 107050)

--- trunk/LayoutTests/ChangeLog	2012-02-08 08:47:02 UTC (rev 107049)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 08:57:08 UTC (rev 107050)
@@ -1,3 +1,29 @@
+2012-02-08  Shinya Kawanaka  shin...@google.com
+
+Stop calling Element::ensureShadowRoot() if it is used in construction phase.
+https://bugs.webkit.org/show_bug.cgi?id=77929
+
+Reviewed by Hajime Morita.
+
+ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
+So we want to remove Element::ensureShadowRoot().
+This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.
+
+No new tests, no change in behavior.
+
+* html/HTMLDetailsElement.cpp:
+(WebCore::HTMLDetailsElement::createShadowSubtree):
+* html/HTMLKeygenElement.cpp:
+(WebCore::HTMLKeygenElement::HTMLKeygenElement):
+* html/HTMLMeterElement.cpp:
+(WebCore::HTMLMeterElement::createShadowSubtree):
+* html/HTMLProgressElement.cpp:
+(WebCore::HTMLProgressElement::createShadowSubtree):
+* html/HTMLSummaryElement.cpp:
+(WebCore::HTMLSummaryElement::createShadowSubtree):
+* html/HTMLTextAreaElement.cpp:
+(WebCore::HTMLTextAreaElement::createShadowSubtree):
+
 2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Not reviewed. Add missing results for a new SVG test.


Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (107049 => 107050)

--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2012-02-08 08:47:02 UTC (rev 107049)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2012-02-08 08:57:08 UTC (rev 107050)
@@ -109,8 +109,10 @@
 void HTMLDetailsElement::createShadowSubtree()
 {
 ASSERT(!shadowRoot());
-ensureShadowRoot()-appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
-ensureShadowRoot()-appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
+
+RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
+root-appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
+root-appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
 }
 
 Element* HTMLDetailsElement::findMainSummary() const


Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (107049 => 107050)

--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp	2012-02-08 08:47:02 UTC (rev 107049)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp	2012-02-08 08:57:08 UTC (rev 107050)
@@ -85,7 +85,9 @@
 option-appendChild(Text::create(document, keys[i]), ec);
 }
 
-ensureShadowRoot()-appendChild(select, ec);
+ASSERT(!shadowRoot());
+RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
+root-appendChild(select, ec);
 }
 
 PassRefPtrHTMLKeygenElement HTMLKeygenElement::create(const QualifiedName tagName, Document* document, HTMLFormElement* form)


Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (107049 => 107050)

--- trunk/Source/WebCore/html/HTMLMeterElement.cpp	2012-02-08 08:47:02 UTC (rev 107049)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp	2012-02-08 08:57:08 UTC (rev 107050)
@@ -234,11 +234,15 @@
 
 void HTMLMeterElement::createShadowSubtree()
 {
+ASSERT(!shadowRoot());
+
 RefPtrMeterBarElement bar = MeterBarElement::create(document());
 m_value = MeterValueElement::create(document());
 ExceptionCode ec = 

[webkit-changes] [107051] trunk/Source/WebCore

[haraken]

Title: [107051] trunk/Source/WebCore








Revision 107051
Author hara...@chromium.org
Date 2012-02-08 00:57:50 -0800 (Wed, 08 Feb 2012)


Log Message
Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
https://bugs.webkit.org/show_bug.cgi?id=77963

Reviewed by Adam Barth.

This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
* bindings/scripts/test/TestInterface.idl:
* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl
trunk/Source/WebCore/css/CSSStyleDeclaration.idl
trunk/Source/WebCore/dom/DOMStringMap.idl
trunk/Source/WebCore/html/HTMLAppletElement.idl
trunk/Source/WebCore/html/HTMLEmbedElement.idl
trunk/Source/WebCore/html/HTMLObjectElement.idl
trunk/Source/WebCore/page/History.idl
trunk/Source/WebCore/page/Location.idl
trunk/Source/WebCore/storage/Storage.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (107050 => 107051)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 08:57:50 UTC (rev 107051)
@@ -1,5 +1,34 @@
 2012-02-08  Kentaro Hara  hara...@chromium.org
 
+Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
+https://bugs.webkit.org/show_bug.cgi?id=77963
+
+Reviewed by Adam Barth.
+
+This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
+for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeaderNamedAndIndexedPropertyAccessors):
+(GenerateImplementationIndexer):
+(GenerateImplementationNamedPropertyGetter):
+* bindings/scripts/test/TestInterface.idl:
+* css/CSSStyleDeclaration.idl:
+* dom/DOMStringMap.idl:
+* html/HTMLAppletElement.idl:
+* html/HTMLEmbedElement.idl:
+* html/HTMLObjectElement.idl:
+* page/History.idl:
+* page/Location.idl:
+* storage/Storage.idl:
+
+2012-02-08  Kentaro Hara  hara...@chromium.org
+
 Replace [CheckNodeSecurity] with [CheckAccessToNode]
 https://bugs.webkit.org/show_bug.cgi?id=77971
 


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (107050 => 107051)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-08 08:57:50 UTC (rev 107051)
@@ -751,7 +751,7 @@
 
 $headerTrailingIncludes{${className}Custom.h} = 1 if $dataNode-extendedAttributes-{CustomHeader};
 
-$implIncludes{${className}Custom.h} = 1 if !$dataNode-extendedAttributes-{CustomHeader}  ($dataNode-extendedAttributes-{CustomPutFunction} || $dataNode-extendedAttributes-{DelegatingPutFunction});
+$implIncludes{${className}Custom.h} = 1 if !$dataNode-extendedAttributes-{CustomHeader}  ($dataNode-extendedAttributes-{CustomPutFunction} || $dataNode-extendedAttributes-{CustomNamedSetter});
 
 my $hasGetter = $numAttributes  0
  || !$dataNode-extendedAttributes-{OmitConstructor}
@@ -782,14 +782,14 @@
 
 my $hasSetter = $hasReadWriteProperties
  || $dataNode-extendedAttributes-{CustomPutFunction}
- || $dataNode-extendedAttributes-{DelegatingPutFunction}
+ || $dataNode-extendedAttributes-{CustomNamedSetter}
  || $dataNode-extendedAttributes-{CustomIndexedSetter};
 
 # Getters
 if ($hasSetter) {
 push(@headerContent, static void put(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier propertyName, JSC::JSValue, JSC::PutPropertySlot);\n);
 push(@headerContent, static void putByIndex(JSC::JSCell*, JSC::ExecState*, unsigned propertyName, JSC::JSValue);\n) if $dataNode-extendedAttributes-{CustomIndexedSetter};
-push(@headerContent, bool putDelegate(JSC::ExecState*, const JSC::Identifier, JSC::JSValue, JSC::PutPropertySlot);\n) if $dataNode-extendedAttributes-{DelegatingPutFunction};
+push(@headerContent, bool putDelegate(JSC::ExecState*, const JSC::Identifier, 

[webkit-changes] [107052] trunk/LayoutTests

[ossy]

Title: [107052] trunk/LayoutTests








Revision 107052
Author o...@webkit.org
Date 2012-02-08 01:17:27 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed gardening after r106982.
Skip a new test because of missing AuthenticationChallenges support.

* platform/qt/Skipped:
* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (107051 => 107052)

--- trunk/LayoutTests/ChangeLog	2012-02-08 08:57:50 UTC (rev 107051)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 09:17:27 UTC (rev 107052)
@@ -1,3 +1,11 @@
+2012-02-08  Csaba Osztrogonác  o...@webkit.org
+
+Unreviewed gardening after r106982.
+Skip a new test because of missing AuthenticationChallenges support.
+
+* platform/qt/Skipped:
+* platform/wk2/Skipped:
+
 2012-02-08  Shinya Kawanaka  shin...@google.com
 
 Stop calling Element::ensureShadowRoot() if it is used in construction phase.


Modified: trunk/LayoutTests/platform/qt/Skipped (107051 => 107052)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-08 08:57:50 UTC (rev 107051)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-08 09:17:27 UTC (rev 107052)
@@ -443,6 +443,7 @@
 http/tests/misc/favicon-as-image.html
 
 # No authentication challenge handling
+http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
 http/tests/loading/basic-credentials-sent-automatically.html
 http/tests/loading/basic-auth-resend-wrong-credentials.html
 http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html


Modified: trunk/LayoutTests/platform/wk2/Skipped (107051 => 107052)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-02-08 08:57:50 UTC (rev 107051)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-02-08 09:17:27 UTC (rev 107052)
@@ -887,6 +887,7 @@
 http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
 http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html
+http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
 http/tests/loading/basic-auth-resend-wrong-credentials.html
 http/tests/loading/basic-credentials-sent-automatically.html
 http/tests/security/401-logout/401-logout.php






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107053] trunk/Tools

[rniwa]

Title: [107053] trunk/Tools








Revision 107053
Author rn...@webkit.org
Date 2012-02-08 01:51:14 -0800 (Wed, 08 Feb 2012)


Log Message
run-perf-tests doesn't recognize paths that start with PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=78012

Reviewed by Adam Barth.

Use resolve paths using filesystem.relpath before passing it to find_files.find.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests):
(test_collect_tests.add_file):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (107052 => 107053)

--- trunk/Tools/ChangeLog	2012-02-08 09:17:27 UTC (rev 107052)
+++ trunk/Tools/ChangeLog	2012-02-08 09:51:14 UTC (rev 107053)
@@ -1,3 +1,19 @@
+2012-02-07  Ryosuke Niwa  rn...@webkit.org
+
+run-perf-tests doesn't recognize paths that start with PerformanceTests
+https://bugs.webkit.org/show_bug.cgi?id=78012
+
+Reviewed by Adam Barth.
+
+Use resolve paths using filesystem.relpath before passing it to find_files.find.
+
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner):
+(PerfTestsRunner._collect_tests):
+* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+(test_collect_tests):
+(test_collect_tests.add_file):
+
 2012-02-07  Justin Novosad  ju...@chromium.org
 
 [Chromium] add option for 2d canvas defered rendering to DumpRenderTree


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (107052 => 107053)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2012-02-08 09:17:27 UTC (rev 107052)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py	2012-02-08 09:51:14 UTC (rev 107053)
@@ -46,7 +46,6 @@
 
 
 class PerfTestsRunner(object):
-_perf_tests_base_dir = 'PerformanceTests'
 _test_directories_for_chromium_style_tests = ['inspector']
 _default_branch = 'webkit-trunk'
 _EXIT_CODE_BAD_BUILD = -1
@@ -107,8 +106,15 @@
 def _is_test_file(filesystem, dirname, filename):
 return filename.endswith('.html')
 
+paths = []
+for arg in self._args:
+paths.append(arg)
+relpath = self._host.filesystem.relpath(arg, self._base_path)
+if relpath:
+paths.append(relpath)
+
 skipped_directories = set(['.svn', 'resources'])
-tests = find_files.find(self._host.filesystem, self._base_path, self._args, skipped_directories, _is_test_file)
+tests = find_files.find(self._host.filesystem, self._base_path, paths, skipped_directories, _is_test_file)
 return [test for test in tests if not self._port.skips_perf_test(self._port.relative_perf_test_filename(test))]
 
 def run(self):


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (107052 => 107053)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-02-08 09:17:27 UTC (rev 107052)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-02-08 09:51:14 UTC (rev 107053)
@@ -307,6 +307,19 @@
 tests = runner._collect_tests()
 self.assertEqual(len(tests), 1)
 
+def test_collect_tests(self):
+runner = self.create_runner(args=['PerformanceTests/test1.html', 'test2.html'])
+
+def add_file(filename):
+runner._host.filesystem.files[runner._host.filesystem.join(runner._base_path, filename)] = 'some content'
+
+add_file('test1.html')
+add_file('test2.html')
+add_file('test3.html')
+runner._host.filesystem.chdir(runner._port.webkit_base())
+tests = [runner._port.relative_perf_test_filename(test) for test in runner._collect_tests()]
+self.assertEqual(sorted(tests), ['test1.html', 'test2.html'])
+
 def test_collect_tests_with_skipped_list(self):
 runner = self.create_runner()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107054] trunk/Source/WebCore

[tommyw]

Title: [107054] trunk/Source/WebCore








Revision 107054
Author tom...@google.com
Date 2012-02-08 01:52:17 -0800 (Wed, 08 Feb 2012)


Log Message
MediaStream API: Adding the onstatechange callback to PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=77954

When readyState changes a callback should be triggered.

Reviewed by Adam Barth.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

* dom/EventNames.h:
(WebCore):
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::changeReadyState):
* mediastream/PeerConnection.h:
(PeerConnection):
(WebCore::PeerConnection::didChangeState):
* mediastream/PeerConnection.idl:
* platform/mediastream/PeerConnectionHandlerClient.h:
(PeerConnectionHandlerClient):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventNames.h
trunk/Source/WebCore/mediastream/PeerConnection.cpp
trunk/Source/WebCore/mediastream/PeerConnection.h
trunk/Source/WebCore/mediastream/PeerConnection.idl
trunk/Source/WebCore/platform/mediastream/PeerConnectionHandlerClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107053 => 107054)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 09:51:14 UTC (rev 107053)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 09:52:17 UTC (rev 107054)
@@ -1,3 +1,25 @@
+2012-02-08  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Adding the onstatechange callback to PeerConnection
+https://bugs.webkit.org/show_bug.cgi?id=77954
+
+When readyState changes a callback should be triggered.
+
+Reviewed by Adam Barth.
+
+Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
+
+* dom/EventNames.h:
+(WebCore):
+* mediastream/PeerConnection.cpp:
+(WebCore::PeerConnection::changeReadyState):
+* mediastream/PeerConnection.h:
+(PeerConnection):
+(WebCore::PeerConnection::didChangeState):
+* mediastream/PeerConnection.idl:
+* platform/mediastream/PeerConnectionHandlerClient.h:
+(PeerConnectionHandlerClient):
+
 2012-02-08  Kentaro Hara  hara...@chromium.org
 
 Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL


Modified: trunk/Source/WebCore/dom/EventNames.h (107053 => 107054)

--- trunk/Source/WebCore/dom/EventNames.h	2012-02-08 09:51:14 UTC (rev 107053)
+++ trunk/Source/WebCore/dom/EventNames.h	2012-02-08 09:52:17 UTC (rev 107054)
@@ -194,6 +194,7 @@
 macro(connecting) \
 macro(addstream) \
 macro(removestream) \
+macro(statechange) \
 \
 macro(show) \
 \


Modified: trunk/Source/WebCore/mediastream/PeerConnection.cpp (107053 => 107054)

--- trunk/Source/WebCore/mediastream/PeerConnection.cpp	2012-02-08 09:51:14 UTC (rev 107053)
+++ trunk/Source/WebCore/mediastream/PeerConnection.cpp	2012-02-08 09:52:17 UTC (rev 107054)
@@ -367,6 +367,8 @@
 case CLOSED:
 break;
 }
+
+dispatchEvent(Event::create(eventNames().statechangeEvent, false, false));
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/mediastream/PeerConnection.h (107053 => 107054)

--- trunk/Source/WebCore/mediastream/PeerConnection.h	2012-02-08 09:51:14 UTC (rev 107053)
+++ trunk/Source/WebCore/mediastream/PeerConnection.h	2012-02-08 09:52:17 UTC (rev 107054)
@@ -58,14 +58,6 @@
 
 void processSignalingMessage(const String message, ExceptionCode);
 
-// Name and values of the enum must match the corressponding constants in the .idl file.
-enum ReadyState {
-NEW = 0,
-NEGOTIATING = 1,
-ACTIVE = 2,
-CLOSED = 3
-};
-
 ReadyState readyState() const;
 
 void send(const String text, ExceptionCode);
@@ -78,6 +70,7 @@
 DEFINE_ATTRIBUTE_EVENT_LISTENER(connecting);
 DEFINE_ATTRIBUTE_EVENT_LISTENER(open);
 DEFINE_ATTRIBUTE_EVENT_LISTENER(message);
+DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);
 DEFINE_ATTRIBUTE_EVENT_LISTENER(addstream);
 DEFINE_ATTRIBUTE_EVENT_LISTENER(removestream);
 
@@ -87,6 +80,7 @@
 virtual void didReceiveDataStreamMessage(const char* data, size_t length);
 virtual void didAddRemoteStream(PassRefPtrMediaStreamDescriptor);
 virtual void didRemoveRemoteStream(MediaStreamDescriptor*);
+virtual void didChangeState(ReadyState state) { changeReadyState(state); }
 
 // EventTarget
 virtual const AtomicString interfaceName() const;


Modified: trunk/Source/WebCore/mediastream/PeerConnection.idl (107053 => 107054)

--- trunk/Source/WebCore/mediastream/PeerConnection.idl	2012-02-08 09:51:14 UTC (rev 107053)
+++ trunk/Source/WebCore/mediastream/PeerConnection.idl	2012-02-08 09:52:17 UTC (rev 107054)
@@ -58,6 +58,7 @@
 attribute EventListener onconnecting;
 attribute EventListener onopen;
 attribute EventListener onmessage;
+attribute EventListener onstatechange;
 attribute EventListener onaddstream;
 attribute EventListener onremovestream;
 

[webkit-changes] [107055] trunk

[apavlov]

Title: [107055] trunk








Revision 107055
Author apav...@chromium.org
Date 2012-02-08 02:00:52 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/lazy-computed-style.html

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._refreshComputedStyleSection):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
* inspector/elements/elements-panel-styles.html:
* inspector/styles/css-live-edit.html:
* inspector/styles/lazy-computed-style-expected.txt: Added.
* inspector/styles/lazy-computed-style.html: Added.
* inspector/styles/styles-computed-trace.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/elements-test.js
trunk/LayoutTests/inspector/elements/elements-panel-styles.html
trunk/LayoutTests/inspector/styles/css-live-edit.html
trunk/LayoutTests/inspector/styles/styles-computed-trace.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js


Added Paths

trunk/LayoutTests/inspector/styles/lazy-computed-style-expected.txt
trunk/LayoutTests/inspector/styles/lazy-computed-style.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107054 => 107055)

--- trunk/LayoutTests/ChangeLog	2012-02-08 09:52:17 UTC (rev 107054)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 10:00:52 UTC (rev 107055)
@@ -1,3 +1,19 @@
+2012-02-07  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
+https://bugs.webkit.org/show_bug.cgi?id=77865
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/elements-test.js:
+(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback):
+(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
+* inspector/elements/elements-panel-styles.html:
+* inspector/styles/css-live-edit.html:
+* inspector/styles/lazy-computed-style-expected.txt: Added.
+* inspector/styles/lazy-computed-style.html: Added.
+* inspector/styles/styles-computed-trace.html:
+
 2012-02-08  Csaba Osztrogonác  o...@webkit.org
 
 Unreviewed gardening after r106982.


Modified: trunk/LayoutTests/http/tests/inspector/elements-test.js (107054 => 107055)

--- trunk/LayoutTests/http/tests/inspector/elements-test.js	2012-02-08 09:52:17 UTC (rev 107054)
+++ trunk/LayoutTests/http/tests/inspector/elements-test.js	2012-02-08 10:00:52 UTC (rev 107055)
@@ -105,6 +105,19 @@
 }
 }
 
+InspectorTest.selectNodeAndWaitForStylesWithComputed = function(idValue, callback)
+{
+callback = InspectorTest.safeWrap(callback);
+
+function stylesCallback(targetNode)
+{
+InspectorTest.addSniffer(WebInspector.SidebarPane.prototype, expand, callback);
+WebInspector.panels.elements.sidebarPanes.computedStyle.expand();
+}
+
+InspectorTest.selectNodeAndWaitForStyles(idValue, stylesCallback);
+}
+
 InspectorTest.dumpSelectedElementStyles = function(excludeComputed, excludeMatched, omitLonghands)
 {
 function extractText(element)


Modified: trunk/LayoutTests/inspector/elements/elements-panel-styles.html (107054 => 107055)

--- trunk/LayoutTests/inspector/elements/elements-panel-styles.html	2012-02-08 09:52:17 UTC (rev 107054)
+++ trunk/LayoutTests/inspector/elements/elements-panel-styles.html	2012-02-08 10:00:52 UTC (rev 107055)
@@ -8,7 +8,7 @@
 
 function test()
 {
-InspectorTest.selectNodeAndWaitForStyles(foo, step1);
+InspectorTest.selectNodeAndWaitForStylesWithComputed(foo, step1);
 
 function step1()
 {


Modified: trunk/LayoutTests/inspector/styles/css-live-edit.html (107054 => 107055)

--- trunk/LayoutTests/inspector/styles/css-live-edit.html	2012-02-08 09:52:17 UTC (rev 107054)
+++ trunk/LayoutTests/inspector/styles/css-live-edit.html	2012-02-08 10:00:52 UTC (rev 107055)
@@ -25,7 +25,7 @@
 
 function didEditResource()
 {
-InspectorTest.selectNodeAndWaitForStyles(foo, didSelectElement);
+InspectorTest.selectNodeAndWaitForStylesWithComputed(foo, didSelectElement);
 }
 
 function didSelectElement()


Added: trunk/LayoutTests/inspector/styles/lazy-computed-style-expected.txt (0 => 107055)

--- trunk/LayoutTests/inspector/styles/lazy-computed-style-expected.txt	(rev 0)
+++ 

[webkit-changes] [107056] trunk/Source/WebCore

[apavlov]

Title: [107056] trunk/Source/WebCore








Revision 107056
Author apav...@chromium.org
Date 2012-02-08 02:11:31 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
https://bugs.webkit.org/show_bug.cgi?id=78090

Reviewed by Vsevolod Vlasov.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107055 => 107056)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 10:00:52 UTC (rev 107055)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 10:11:31 UTC (rev 107056)
@@ -1,3 +1,13 @@
+2012-02-08  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
+https://bugs.webkit.org/show_bug.cgi?id=78090
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage):
+
 2012-02-07  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness


Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (107055 => 107056)

--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2012-02-08 10:00:52 UTC (rev 107055)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2012-02-08 10:11:31 UTC (rev 107056)
@@ -640,7 +640,8 @@
 void InspectorDOMAgent::updateTouchEventEmulationInPage(bool enabled)
 {
 m_state-setBoolean(DOMAgentState::touchEventEmulationEnabled, enabled);
-m_pageAgent-mainFrame()-settings()-setTouchEventEmulationEnabled(enabled);
+if (m_pageAgent-mainFrame()  m_pageAgent-mainFrame()-settings())
+m_pageAgent-mainFrame()-settings()-setTouchEventEmulationEnabled(enabled);
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107058] trunk

[commit-queue]

Title: [107058] trunk








Revision 107058
Author commit-qu...@webkit.org
Date 2012-02-08 02:39:13 -0800 (Wed, 08 Feb 2012)


Log Message
Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035

Patch by Pablo Flouret pab...@motorola.com on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-object-types.html
   fast/loader/stateobjects/state-attribute-only-one-deserialization.html

* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::state):
(WebCore):
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
(WebCore):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* page/History.cpp:
(WebCore::History::History):
(WebCore::History::state):
(WebCore):
(WebCore::History::stateInternal):
(WebCore::History::stateChanged):
* page/History.h:
(History):
* page/History.idl:

LayoutTests:

* fast/dom/Window/window-appendages-cleared-expected.txt:
* fast/loader/stateobjects/state-attribute-object-types-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-object-types.html: Added.
* fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt: Added.
* fast/loader/stateobjects/state-attribute-only-one-deserialization.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSHistoryCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp
trunk/Source/WebCore/page/History.cpp
trunk/Source/WebCore/page/History.h
trunk/Source/WebCore/page/History.idl


Added Paths

trunk/LayoutTests/fast/loader/stateobjects/state-attribute-object-types-expected.txt
trunk/LayoutTests/fast/loader/stateobjects/state-attribute-object-types.html
trunk/LayoutTests/fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt
trunk/LayoutTests/fast/loader/stateobjects/state-attribute-only-one-deserialization.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107057 => 107058)

--- trunk/LayoutTests/ChangeLog	2012-02-08 10:21:49 UTC (rev 107057)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 10:39:13 UTC (rev 107058)
@@ -1,3 +1,16 @@
+2012-02-08  Pablo Flouret  pab...@motorola.com
+
+Add state attribute to history's dom interface.
+https://bugs.webkit.org/show_bug.cgi?id=76035
+
+Reviewed by Kentaro Hara.
+
+* fast/dom/Window/window-appendages-cleared-expected.txt:
+* fast/loader/stateobjects/state-attribute-object-types-expected.txt: Added.
+* fast/loader/stateobjects/state-attribute-object-types.html: Added.
+* fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt: Added.
+* fast/loader/stateobjects/state-attribute-only-one-deserialization.html: Added.
+
 2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
 
 SVGLoad event fires too early


Modified: trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt (107057 => 107058)

--- trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt	2012-02-08 10:21:49 UTC (rev 107057)
+++ trunk/LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt	2012-02-08 10:39:13 UTC (rev 107058)
@@ -4,6 +4,7 @@
 PASS history.length == LEFTOVER is false
 PASS history.pushState == LEFTOVER is false
 PASS history.replaceState == LEFTOVER is false
+PASS history.state == LEFTOVER is false
 PASS location.assign == LEFTOVER is false
 PASS location.hash == LEFTOVER is false
 PASS location.host == LEFTOVER is false


Added: trunk/LayoutTests/fast/loader/stateobjects/state-attribute-object-types-expected.txt (0 => 107058)

--- trunk/LayoutTests/fast/loader/stateobjects/state-attribute-object-types-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/loader/stateobjects/state-attribute-object-types-expected.txt	2012-02-08 10:39:13 UTC (rev 107058)
@@ -0,0 +1,25 @@
+This test calls pushState with state objects of all the different object types supported by the HTML5 internal structured cloning algorithm and makes sure the state attribute returns the expected objects.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS history.state is defined.
+
+history.state should initially be null.
+PASS history.state is null
+
+PASS history.state is undefined.
+PASS history.state is null
+PASS history.state is false
+PASS history.state is true
+PASS history.state is 42
+PASS history.state is String
+PASS +history.state is +(new Date(0))
+PASS history.state == '/foo/gi' is true
+PASS history.state == '' is true
+PASS history.state == '[object Object]' is true
+PASS history.state == '[object ImageData]' is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: 

[webkit-changes] [107059] trunk

[ossy]

Title: [107059] trunk








Revision 107059
Author o...@webkit.org
Date 2012-02-08 02:42:55 -0800 (Wed, 08 Feb 2012)


Log Message
[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=77995

Patch by Nikolas Zimmermann nzimmerm...@rim.com on 2012-02-08
Reviewed by Csaba Osztrogonác.

Source/WebCore:

>From the stack traces it's obvious that SVGImageChromeClient tried to invalidate the root view,
while its SVGImage was being destructed, due to an updateStyleIfNeeded() call, coming
from frameDetached(). There's no point in redrawing there, so we should just stop it.

Covered by existing tests on the Qt but, unfortunately I couldn't reproduce it on Mac.

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndRootView): Stop invalidating if m_page is 0.
(WebCore::SVGImage::~SVGImage): Clear m_page, so that SVGImageChromeClient knows we're destructing.
* svg/graphics/SVGImage.h:

LayoutTests:

* platform/qt/Skipped: Unskip previously skipped tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/graphics/SVGImage.cpp
trunk/Source/WebCore/svg/graphics/SVGImage.h




Diff

Modified: trunk/LayoutTests/ChangeLog (107058 => 107059)

--- trunk/LayoutTests/ChangeLog	2012-02-08 10:39:13 UTC (rev 107058)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 10:42:55 UTC (rev 107059)
@@ -1,3 +1,12 @@
+2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
+
+[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
+https://bugs.webkit.org/show_bug.cgi?id=77995
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/qt/Skipped: Unskip previously skipped tests.
+
 2012-02-08  Pablo Flouret  pab...@motorola.com
 
 Add state attribute to history's dom interface.


Modified: trunk/LayoutTests/platform/qt/Skipped (107058 => 107059)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-08 10:39:13 UTC (rev 107058)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-08 10:42:55 UTC (rev 107059)
@@ -2538,8 +2538,3 @@
 # [Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes.html fail in debug mode
 # https://bugs.webkit.org/show_bug.cgi?id=78026
 svg/as-object/nested-embedded-svg-size-changes.html
-
-# [Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
-# https://bugs.webkit.org/show_bug.cgi?id=77995
-svg/zoom/page/zoom-background-images.html
-svg/zoom/page/zoom-coords-viewattr-01-b.svg


Modified: trunk/Source/WebCore/ChangeLog (107058 => 107059)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 10:39:13 UTC (rev 107058)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 10:42:55 UTC (rev 107059)
@@ -1,3 +1,21 @@
+2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
+
+[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
+https://bugs.webkit.org/show_bug.cgi?id=77995
+
+Reviewed by Csaba Osztrogonác.
+
+From the stack traces it's obvious that SVGImageChromeClient tried to invalidate the root view,
+while its SVGImage was being destructed, due to an updateStyleIfNeeded() call, coming
+from frameDetached(). There's no point in redrawing there, so we should just stop it.
+
+Covered by existing tests on the Qt but, unfortunately I couldn't reproduce it on Mac.
+
+* svg/graphics/SVGImage.cpp:
+(WebCore::SVGImageChromeClient::invalidateContentsAndRootView): Stop invalidating if m_page is 0.
+(WebCore::SVGImage::~SVGImage): Clear m_page, so that SVGImageChromeClient knows we're destructing.
+* svg/graphics/SVGImage.h:
+
 2012-02-08  Pablo Flouret  pab...@motorola.com
 
 Add state attribute to history's dom interface.


Modified: trunk/Source/WebCore/svg/graphics/SVGImage.cpp (107058 => 107059)

--- trunk/Source/WebCore/svg/graphics/SVGImage.cpp	2012-02-08 10:39:13 UTC (rev 107058)
+++ trunk/Source/WebCore/svg/graphics/SVGImage.cpp	2012-02-08 10:42:55 UTC (rev 107059)
@@ -75,7 +75,8 @@
 
 virtual void invalidateContentsAndRootView(const IntRect r, bool)
 {
-if (m_image  m_image-imageObserver())
+// If m_image-m_page is null, we're being destructed, don't fire changedInRect() in that case.
+if (m_image  m_image-imageObserver()  m_image-m_page)
 m_image-imageObserver()-changedInRect(m_image, r);
 }
 
@@ -90,12 +91,9 @@
 SVGImage::~SVGImage()
 {
 if (m_page) {
-m_page-mainFrame()-loader()-frameDetached(); // Break both the loader and view references to the frame
-
-// Clear explicitly because we want to delete the page before the ChromeClient.
-// FIXME: I believe that's already guaranteed by C++ object destruction rules,
-// so this may matter only for the assertion below.
-m_page.clear();
+// Store m_page in a 

[webkit-changes] [107060] trunk/Source/WebCore

[morrita]

Title: [107060] trunk/Source/WebCore








Revision 107060
Author morr...@google.com
Date 2012-02-08 02:55:20 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed, rolling out r107050.
http://trac.webkit.org/changeset/107050
https://bugs.webkit.org/show_bug.cgi?id=78094

May crash editing tests (Requested by morrita on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-08

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDetailsElement.cpp
trunk/Source/WebCore/html/HTMLKeygenElement.cpp
trunk/Source/WebCore/html/HTMLMeterElement.cpp
trunk/Source/WebCore/html/HTMLProgressElement.cpp
trunk/Source/WebCore/html/HTMLSummaryElement.cpp
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107059 => 107060)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 10:42:55 UTC (rev 107059)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 10:55:20 UTC (rev 107060)
@@ -1,3 +1,24 @@
+2012-02-08  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r107050.
+http://trac.webkit.org/changeset/107050
+https://bugs.webkit.org/show_bug.cgi?id=78094
+
+May crash editing tests (Requested by morrita on #webkit).
+
+* html/HTMLDetailsElement.cpp:
+(WebCore::HTMLDetailsElement::createShadowSubtree):
+* html/HTMLKeygenElement.cpp:
+(WebCore::HTMLKeygenElement::HTMLKeygenElement):
+* html/HTMLMeterElement.cpp:
+(WebCore::HTMLMeterElement::createShadowSubtree):
+* html/HTMLProgressElement.cpp:
+(WebCore::HTMLProgressElement::createShadowSubtree):
+* html/HTMLSummaryElement.cpp:
+(WebCore::HTMLSummaryElement::createShadowSubtree):
+* html/HTMLTextAreaElement.cpp:
+(WebCore::HTMLTextAreaElement::createShadowSubtree):
+
 2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
 
 [Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1


Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (107059 => 107060)

--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2012-02-08 10:42:55 UTC (rev 107059)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2012-02-08 10:55:20 UTC (rev 107060)
@@ -109,10 +109,8 @@
 void HTMLDetailsElement::createShadowSubtree()
 {
 ASSERT(!shadowRoot());
-
-RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-root-appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
-root-appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
+ensureShadowRoot()-appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
+ensureShadowRoot()-appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
 }
 
 Element* HTMLDetailsElement::findMainSummary() const


Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (107059 => 107060)

--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp	2012-02-08 10:42:55 UTC (rev 107059)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp	2012-02-08 10:55:20 UTC (rev 107060)
@@ -85,9 +85,7 @@
 option-appendChild(Text::create(document, keys[i]), ec);
 }
 
-ASSERT(!shadowRoot());
-RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-root-appendChild(select, ec);
+ensureShadowRoot()-appendChild(select, ec);
 }
 
 PassRefPtrHTMLKeygenElement HTMLKeygenElement::create(const QualifiedName tagName, Document* document, HTMLFormElement* form)


Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (107059 => 107060)

--- trunk/Source/WebCore/html/HTMLMeterElement.cpp	2012-02-08 10:42:55 UTC (rev 107059)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp	2012-02-08 10:55:20 UTC (rev 107060)
@@ -234,15 +234,11 @@
 
 void HTMLMeterElement::createShadowSubtree()
 {
-ASSERT(!shadowRoot());
-
 RefPtrMeterBarElement bar = MeterBarElement::create(document());
 m_value = MeterValueElement::create(document());
 ExceptionCode ec = 0;
 bar-appendChild(m_value, ec);
-
-RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-root-appendChild(bar, ec);
+ensureShadowRoot()-appendChild(bar, ec);
 }
 
 } // namespace


Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (107059 => 107060)

--- trunk/Source/WebCore/html/HTMLProgressElement.cpp	2012-02-08 10:42:55 UTC (rev 107059)
+++ 

[webkit-changes] [107061] trunk/Source/WebCore

[kling]

Title: [107061] trunk/Source/WebCore








Revision 107061
Author kl...@webkit.org
Date 2012-02-08 03:03:52 -0800 (Wed, 08 Feb 2012)


Log Message
StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
http://webkit.org/b/78068

Rubber-stamped by Ryosuke Niwa.

Turns out that setProperty() with a CSSProperty has quite different behavior from
the other setProperty() methods. We should probably clean that up (separately.)
For now, simply call setNeedsStyleRecalc() manually in the addCSS* functions that
use setProperty(CSSProperty).

* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/StyledElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107060 => 107061)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 10:55:20 UTC (rev 107060)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 11:03:52 UTC (rev 107061)
@@ -1,3 +1,19 @@
+2012-02-08  Andreas Kling  awesomekl...@apple.com
+
+StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
+http://webkit.org/b/78068
+
+Rubber-stamped by Ryosuke Niwa.
+
+Turns out that setProperty() with a CSSProperty has quite different behavior from
+the other setProperty() methods. We should probably clean that up (separately.)
+For now, simply call setNeedsStyleRecalc() manually in the addCSS* functions that
+use setProperty(CSSProperty).
+
+* dom/StyledElement.cpp:
+(WebCore::StyledElement::addCSSProperty):
+(WebCore::StyledElement::addCSSImageProperty):
+
 2012-02-08  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r107050.


Modified: trunk/Source/WebCore/dom/StyledElement.cpp (107060 => 107061)

--- trunk/Source/WebCore/dom/StyledElement.cpp	2012-02-08 10:55:20 UTC (rev 107060)
+++ trunk/Source/WebCore/dom/StyledElement.cpp	2012-02-08 11:03:52 UTC (rev 107061)
@@ -146,11 +146,13 @@
 void StyledElement::addCSSProperty(int propertyID, int identifier)
 {
 ensureAttributeStyle()-setProperty(CSSProperty(propertyID, document()-cssValuePool()-createIdentifierValue(identifier)));
+setNeedsStyleRecalc();
 }
 
 void StyledElement::addCSSImageProperty(int id, const String url)
 {
 ensureAttributeStyle()-setProperty(CSSProperty(id, CSSImageValue::create(url)));
+setNeedsStyleRecalc();
 }
 
 void StyledElement::addCSSLength(int id, const String value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107062] trunk

[apavlov]

Title: [107062] trunk








Revision 107062
Author apav...@chromium.org
Date 2012-02-08 03:13:03 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: Touch event emulation fails for iframes
https://bugs.webkit.org/show_bug.cgi?id=77987

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/events/touch/emulated-touch-iframe.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

* fast/events/touch/emulated-touch-iframe-expected.txt: Added.
* fast/events/touch/emulated-touch-iframe.html: Added.
* fast/events/touch/resources/emulated-touch-iframe2.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp


Added Paths

trunk/LayoutTests/fast/events/touch/emulated-touch-iframe-expected.txt
trunk/LayoutTests/fast/events/touch/emulated-touch-iframe.html
trunk/LayoutTests/fast/events/touch/resources/emulated-touch-iframe2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107061 => 107062)

--- trunk/LayoutTests/ChangeLog	2012-02-08 11:03:52 UTC (rev 107061)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 11:13:03 UTC (rev 107062)
@@ -1,3 +1,14 @@
+2012-02-08  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: Touch event emulation fails for iframes
+https://bugs.webkit.org/show_bug.cgi?id=77987
+
+Reviewed by Pavel Feldman.
+
+* fast/events/touch/emulated-touch-iframe-expected.txt: Added.
+* fast/events/touch/emulated-touch-iframe.html: Added.
+* fast/events/touch/resources/emulated-touch-iframe2.html: Added.
+
 2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
 
 [Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1


Added: trunk/LayoutTests/fast/events/touch/emulated-touch-iframe-expected.txt (0 => 107062)

--- trunk/LayoutTests/fast/events/touch/emulated-touch-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/emulated-touch-iframe-expected.txt	2012-02-08 11:13:03 UTC (rev 107062)
@@ -0,0 +1,5 @@
+
+Test touchend events are emulated in iframes correctly.
+
+Final touchend (test will time out if broken)
+


Added: trunk/LayoutTests/fast/events/touch/emulated-touch-iframe.html (0 => 107062)

--- trunk/LayoutTests/fast/events/touch/emulated-touch-iframe.html	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/emulated-touch-iframe.html	2012-02-08 11:13:03 UTC (rev 107062)
@@ -0,0 +1,38 @@
+html
+script src=""
+body
+iframe style=position:absolute; top:100px; left:100px; src=""
+pTest touchend events are emulated in iframes correctly./p
+div id=console/div
+script type=text/_javascript_
+
+var eventCount = 0;
+var EXPECTED_EVENT_COUNT = 2;
+
+function testComplete()
+{
+if (++eventCount === EXPECTED_EVENT_COUNT) {
+debug(Final touchend (test will time out if broken));
+window.layoutTestController.notifyDone();
+}
+}
+
+function runTest() {
+if (window.eventSender  window.internals  window.internals.settings) {
+window.eventSender.dragMode = false;
+window.internals.settings.setTouchEventEmulationEnabled(true);
+
+eventSender.mouseMoveTo(110, 110);
+eventSender.mouseDown(0);
+eventSender.mouseMoveTo(120, 130);
+eventSender.mouseUp(0);
+} else
+   debug('This test requires DRT.');
+}
+
+if (window.layoutTestController)
+window.layoutTestController.waitUntilDone();
+
+/script
+/body
+/html


Added: trunk/LayoutTests/fast/events/touch/resources/emulated-touch-iframe2.html (0 => 107062)

--- trunk/LayoutTests/fast/events/touch/resources/emulated-touch-iframe2.html	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/resources/emulated-touch-iframe2.html	2012-02-08 11:13:03 UTC (rev 107062)
@@ -0,0 +1,9 @@
+html
+body _onload_=parent.runTest()
+div id='mydiv' style='width:100px;height:100px;position:absolute;top:0px; left:0px; background-color:blue;'/div
+script type='text/_javascript_'
+var myDiv = document.getElementById('mydiv');
+myDiv.addEventListener('touchend', function() { parent.testComplete(); }, false);
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (107061 => 107062)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 11:03:52 UTC (rev 107061)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 11:13:03 UTC (rev 107062)
@@ -1,3 +1,15 @@
+2012-02-08  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: Touch event emulation fails for iframes
+https://bugs.webkit.org/show_bug.cgi?id=77987
+
+Reviewed by Pavel Feldman.
+
+Test: fast/events/touch/emulated-touch-iframe.html
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleMouseReleaseEvent):
+
 2012-02-08  Andreas Kling  awesomekl...@apple.com
 
 StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.


Modified: trunk/Source/WebCore/page/EventHandler.cpp (107061 => 107062)

--- 

[webkit-changes] [107063] trunk/LayoutTests

[haraken]

Title: [107063] trunk/LayoutTests








Revision 107063
Author hara...@chromium.org
Date 2012-02-08 03:15:40 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
The test needs rebaselining.

* platform/gtk/Skipped:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (107062 => 107063)

--- trunk/LayoutTests/ChangeLog	2012-02-08 11:13:03 UTC (rev 107062)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 11:15:40 UTC (rev 107063)
@@ -1,3 +1,11 @@
+2012-02-08  Kentaro Hara  hara...@chromium.org
+
+Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
+The test needs rebaselining.
+
+* platform/gtk/Skipped:
+* platform/qt/Skipped:
+
 2012-02-08  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: Touch event emulation fails for iframes


Modified: trunk/LayoutTests/platform/gtk/Skipped (107062 => 107063)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-02-08 11:13:03 UTC (rev 107062)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-02-08 11:15:40 UTC (rev 107063)
@@ -1516,6 +1516,10 @@
 tables/mozilla/bugs/bug14929.html
 tables/mozilla/bugs/bug2947.html
 
+# Needs rebaselining
+# https://bugs.webkit.org/show_bug.cgi?id=77971
+http/tests/security/cross-frame-access-put.html
+
 # https://bugs.webkit.org/show_bug.cgi?id=74276
 fast/events/dont-loose-last-event.html
 


Modified: trunk/LayoutTests/platform/qt/Skipped (107062 => 107063)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-08 11:13:03 UTC (rev 107062)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-08 11:15:40 UTC (rev 107063)
@@ -558,6 +558,10 @@
 # https://bugs.webkit.org/show_bug.cgi?id=72491
 http/tests/misc/onload-remove-iframe-crash-2.html
 
+# Needs rebaselining
+# https://bugs.webkit.org/show_bug.cgi?id=77971
+http/tests/security/cross-frame-access-put.html
+
 # === #
 #   Failing xmlhttprequest tests  #
 # === #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107064] trunk/Tools

[rniwa]

Title: [107064] trunk/Tools








Revision 107064
Author rn...@webkit.org
Date 2012-02-08 03:40:09 -0800 (Wed, 08 Feb 2012)


Log Message
Revert a part of the change in r106687 as a build fix.

Since Chromium port doesn't checkout the entire WebKit trunk,
we can't run svn info on webkit_base.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py




Diff

Modified: trunk/Tools/ChangeLog (107063 => 107064)

--- trunk/Tools/ChangeLog	2012-02-08 11:15:40 UTC (rev 107063)
+++ trunk/Tools/ChangeLog	2012-02-08 11:40:09 UTC (rev 107064)
@@ -1,3 +1,13 @@
+2012-02-08  Ryosuke Niwa  rn...@webkit.org
+
+Revert a part of the change in r106687 as a build fix.
+
+Since Chromium port doesn't checkout the entire WebKit trunk,
+we can't run svn info on webkit_base.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.repository_paths):
+
 2012-02-07  Ryosuke Niwa  rn...@webkit.org
 
 run-perf-tests doesn't recognize paths that start with PerformanceTests


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (107063 => 107064)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-02-08 11:15:40 UTC (rev 107063)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-02-08 11:40:09 UTC (rev 107064)
@@ -900,9 +900,12 @@
 def repository_paths(self):
 Returns a list of (repository_name, repository_path) tuples of its depending code base.
 By default it returns a list that only contains a ('webkit', webkitRepossitoryPath) tuple.
-return [('webkit', self.webkit_base())]
 
+# We use LayoutTest directory here because webkit_base isn't a part webkit repository in Chromium port
+# where turnk isn't checked out as a whole.
+return [('webkit', self.layout_tests_dir())]
 
+
 _WDIFF_DEL = '##WDIFF_DEL##'
 _WDIFF_ADD = '##WDIFF_ADD##'
 _WDIFF_END = '##WDIFF_END##'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107065] trunk/Source/WebCore

[commit-queue]

Title: [107065] trunk/Source/WebCore








Revision 107065
Author commit-qu...@webkit.org
Date 2012-02-08 03:53:13 -0800 (Wed, 08 Feb 2012)


Log Message
[EFL] Using string method instead of char* operation in the platformLanguage().
https://bugs.webkit.org/show_bug.cgi?id=78077

Patch by Kihong Kwon kihong.k...@samsung.com on 2012-02-08
Reviewed by Andreas Kling.

No new tests. Just fix a bug of platformLanguage function.

* platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage):
Change char* operation to string operation.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/LanguageEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107064 => 107065)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 11:40:09 UTC (rev 107064)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 11:53:13 UTC (rev 107065)
@@ -1,3 +1,16 @@
+2012-02-08  Kihong Kwon  kihong.k...@samsung.com
+
+[EFL] Using string method instead of char* operation in the platformLanguage().
+https://bugs.webkit.org/show_bug.cgi?id=78077
+
+Reviewed by Andreas Kling.
+
+No new tests. Just fix a bug of platformLanguage function.
+
+* platform/efl/LanguageEfl.cpp:
+(WebCore::platformLanguage):
+Change char* operation to string operation.
+
 2012-02-08  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: Touch event emulation fails for iframes


Modified: trunk/Source/WebCore/platform/efl/LanguageEfl.cpp (107064 => 107065)

--- trunk/Source/WebCore/platform/efl/LanguageEfl.cpp	2012-02-08 11:40:09 UTC (rev 107064)
+++ trunk/Source/WebCore/platform/efl/LanguageEfl.cpp	2012-02-08 11:53:13 UTC (rev 107065)
@@ -42,13 +42,8 @@
 
 if (!localeDefault)
 return String(c);
- 
-char* ptr = strchr(localeDefault, '_');
 
-if (ptr)
-*ptr = '-';
-  
-return String(localeDefault);
+return String(localeDefault).replace('_', '-');
 }
 
 VectorString platformUserPreferredLanguages()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107066] trunk/LayoutTests

[ossy]

Title: [107066] trunk/LayoutTests








Revision 107066
Author o...@webkit.org
Date 2012-02-08 04:02:42 -0800 (Wed, 08 Feb 2012)


Log Message
[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.

* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107065 => 107066)

--- trunk/LayoutTests/ChangeLog	2012-02-08 11:53:13 UTC (rev 107065)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:02:42 UTC (rev 107066)
@@ -1,3 +1,10 @@
+2012-02-08  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.
+
+* platform/qt/Skipped:
+* platform/qt/fast/dom/Window/window-properties-expected.txt:
+
 2012-02-08  Kentaro Hara  hara...@chromium.org
 
 Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.


Modified: trunk/LayoutTests/platform/qt/Skipped (107065 => 107066)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-08 11:53:13 UTC (rev 107065)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-08 12:02:42 UTC (rev 107066)
@@ -2526,15 +2526,6 @@
 # new test introduced in http://trac.webkit.org/changeset/106072 - need more investigation
 fast/parser/nested-fragment-parser-crash.html
 
-# REGRESSION(r106554): It made 4 tests assert
-# Hovered node gets stuck on touch events
-# https://bugs.webkit.org/show_bug.cgi?id=77620
-fast/events/touch/basic-multi-touch-events.html
-fast/events/touch/touch-target.html
-fast/events/touch/touch-before-pressing-spin-button.html
-fast/events/touch/touch-coords-in-zoom-and-scroll.html
-fast/events/touch/touch-inside-iframe.html
-
 # new test introduced in http://trac.webkit.org/changeset/106642 failes on Qt Release
 # https://bugs.webkit.org/show_bug.cgi?id=77729
 fast/events/touch/emulate-touch-events.html 
@@ -2542,3 +2533,11 @@
 # [Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes.html fail in debug mode
 # https://bugs.webkit.org/show_bug.cgi?id=78026
 svg/as-object/nested-embedded-svg-size-changes.html
+
+# [Qt] fast/text/international/inline-plaintext-is-isolated.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=78092
+fast/text/international/inline-plaintext-is-isolated.html
+
+# Synthetic bold is illegible under some scaling transforms
+# https://bugs.webkit.org/show_bug.cgi?id=78044
+fast/text/synthetic-bold-transformed.html


Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (107065 => 107066)

--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt	2012-02-08 11:53:13 UTC (rev 107065)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt	2012-02-08 12:02:42 UTC (rev 107066)
@@ -2396,7 +2396,7 @@
 window.find [function]
 window.flushLog [function]
 window.focus [function]
-window.frameElement [null]
+window.frameElement [undefined]
 window.frames [printed above as window]
 window.getComputedStyle [function]
 window.getMatchedCSSRules [function]
@@ -2408,6 +2408,7 @@
 window.history.length [number]
 window.history.pushState [function]
 window.history.replaceState [function]
+window.history.state [null]
 window.innerHeight [number]
 window.innerWidth [number]
 window.isFinite [function]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107068] trunk/Source/WebKit2

[yael . aharon]

Title: [107068] trunk/Source/WebKit2








Revision 107068
Author yael.aha...@nokia.com
Date 2012-02-08 04:13:50 -0800 (Wed, 08 Feb 2012)


Log Message
[WK2] Text notifications should have an iconURL
https://bugs.webkit.org/show_bug.cgi?id=77968

Reviewed by Simon Hausmann.

Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
Add an iconURL to WebNotification and add a public API to access it.

* UIProcess/API/C/WKNotification.cpp:
(WKNotificationCopyiconURL):
* UIProcess/API/C/WKNotification.h:
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
(WebKit::WebNotification::iconURL):
(WebNotification):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (107067 => 107068)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 12:12:31 UTC (rev 107067)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 12:13:50 UTC (rev 107068)
@@ -1,3 +1,34 @@
+2012-02-08  Yael Aharon  yael.aha...@nokia.com
+
+[WK2] Text notifications should have an iconURL
+https://bugs.webkit.org/show_bug.cgi?id=77968
+
+Reviewed by Simon Hausmann.
+
+Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
+Add an iconURL to WebNotification and add a public API to access it.
+   
+* UIProcess/API/C/WKNotification.cpp:
+(WKNotificationCopyiconURL):
+* UIProcess/API/C/WKNotification.h:
+* UIProcess/Notifications/WebNotification.cpp:
+(WebKit::WebNotification::WebNotification):
+* UIProcess/Notifications/WebNotification.h:
+(WebKit::WebNotification::create):
+(WebKit::WebNotification::iconURL):
+(WebNotification):
+* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
+(WebKit::WebNotificationManagerProxy::show):
+* UIProcess/Notifications/WebNotificationManagerProxy.h:
+(WebNotificationManagerProxy):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::showNotification):
+* UIProcess/WebPageProxy.h:
+(WebPageProxy):
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/Notifications/WebNotificationManager.cpp:
+(WebKit::WebNotificationManager::show):
+
 2012-02-08  Philippe Normand  pnorm...@igalia.com
 
 [GTK][WK2] enable-webaudio WebSetting


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp (107067 => 107068)

--- trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp	2012-02-08 12:12:31 UTC (rev 107067)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp	2012-02-08 12:13:50 UTC (rev 107068)
@@ -47,6 +47,11 @@
 return toCopiedAPI(toImpl(notification)-body());
 }
 
+WKStringRef WKNotificationCopyIconURL(WKNotificationRef notification)
+{
+return toCopiedAPI(toImpl(notification)-iconURL());
+}
+
 WKSecurityOriginRef WKNotificationGetSecurityOrigin(WKNotificationRef notification)
 {
 return toAPI(toImpl(notification)-origin());


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h (107067 => 107068)

--- trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h	2012-02-08 12:12:31 UTC (rev 107067)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h	2012-02-08 12:13:50 UTC (rev 107068)
@@ -36,6 +36,7 @@
 
 WK_EXPORT WKStringRef WKNotificationCopyTitle(WKNotificationRef notification);
 WK_EXPORT WKStringRef WKNotificationCopyBody(WKNotificationRef notification);
+WK_EXPORT WKStringRef WKNotificationCopyIconURL(WKNotificationRef notification);
 WK_EXPORT WKSecurityOriginRef WKNotificationGetSecurityOrigin(WKNotificationRef notification);
 WK_EXPORT uint64_t WKNotificationGetID(WKNotificationRef notification);
 


Modified: trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.cpp (107067 => 107068)

--- 

[webkit-changes] [107069] trunk/LayoutTests

[haraken]

Title: [107069] trunk/LayoutTests








Revision 107069
Author hara...@chromium.org
Date 2012-02-08 04:18:40 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed. Rebaselined the test that has been failing since r107046.

* http/tests/security/cross-frame-access-put-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107068 => 107069)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:13:50 UTC (rev 107068)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:18:40 UTC (rev 107069)
@@ -1,3 +1,9 @@
+2012-02-08  Kentaro Hara  hara...@chromium.org
+
+Unreviewed. Rebaselined the test that has been failing since r107046.
+
+* http/tests/security/cross-frame-access-put-expected.txt:
+
 2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
 
 feImage doesn't invalidate when its target SVG element is animated


Modified: trunk/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt (107068 => 107069)

--- trunk/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt	2012-02-08 12:13:50 UTC (rev 107068)
+++ trunk/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt	2012-02-08 12:18:40 UTC (rev 107069)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
+
 CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.
 
 CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.
@@ -473,7 +475,9 @@
 ALERT: PASS: window.document should be '[object HTMLDocument]' and is.
 ALERT: PASS: window.embeds should be 'undefined' and is.
 ALERT: PASS: window.event should be 'undefined' and is.
-ALERT: PASS: window.frameElement should be '[object HTMLIFrameElement]' and is.
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
+
+ALERT: PASS: window.frameElement should be 'undefined' and is.
 ALERT: PASS: window.frames should be '[object DOMWindow]' and is.
 ALERT: PASS: window.history should be '[object History]' and is.
 ALERT: PASS: window.images should be 'undefined' and is.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107070] trunk/Source/WebKit2

[mahesh . kulkarni]

Title: [107070] trunk/Source/WebKit2








Revision 107070
Author mahesh.kulka...@nokia.com
Date 2012-02-08 04:24:50 -0800 (Wed, 08 Feb 2012)


Log Message
[Qt] Build broken if qt missing openssl
https://bugs.webkit.org/show_bug.cgi?id=77894

Reviewed by Chang Shu.

Build fix. No new test content.

* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::onSslErrors):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/qt/QtNetworkAccessManager.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (107069 => 107070)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 12:18:40 UTC (rev 107069)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 12:24:50 UTC (rev 107070)
@@ -1,3 +1,15 @@
+2012-02-08  Mahesh Kulkarni  mahesh.kulka...@nokia.com
+
+[Qt] Build broken if qt missing openssl
+https://bugs.webkit.org/show_bug.cgi?id=77894
+
+Reviewed by Chang Shu.
+
+Build fix. No new test content. 
+
+* WebProcess/qt/QtNetworkAccessManager.cpp:
+(WebKit::QtNetworkAccessManager::onSslErrors):
+
 2012-02-08  Yael Aharon  yael.aha...@nokia.com
 
 [WK2] Text notifications should have an iconURL


Modified: trunk/Source/WebKit2/WebProcess/qt/QtNetworkAccessManager.cpp (107069 => 107070)

--- trunk/Source/WebKit2/WebProcess/qt/QtNetworkAccessManager.cpp	2012-02-08 12:18:40 UTC (rev 107069)
+++ trunk/Source/WebKit2/WebProcess/qt/QtNetworkAccessManager.cpp	2012-02-08 12:24:50 UTC (rev 107070)
@@ -111,8 +111,14 @@
 if (webPage-sendSync(
 Messages::WebPageProxy::CertificateVerificationRequest(hostname),
 Messages::WebPageProxy::CertificateVerificationRequest::Reply(ignoreErrors))) {
-if (ignoreErrors)
+if (ignoreErrors) {
+#ifndef QT_NO_OPENSSL
 reply-ignoreSslErrors(qSslErrors);
+#else
+Q_UNUSED(qSslErrors);
+reply-ignoreSslErrors();
+#endif
+}
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107071] trunk/LayoutTests

[zimmermann]

Title: [107071] trunk/LayoutTests








Revision 107071
Author zimmerm...@webkit.org
Date 2012-02-08 04:31:11 -0800 (Wed, 08 Feb 2012)


Log Message
qt fixes

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/getTransformToElement-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/text-ctm-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/text-hit-test-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107070 => 107071)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:24:50 UTC (rev 107070)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:31:11 UTC (rev 107071)
@@ -1,3 +1,14 @@
+2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
+
+Not reviewed. Rebaseline Qt/SVG results.
+
+* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
+* platform/qt/svg/custom/getTransformToElement-expected.txt:
+* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
+* platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
+* platform/qt/svg/custom/text-ctm-expected.txt:
+* platform/qt/svg/custom/text-hit-test-expected.txt:
+
 2012-02-08  Kentaro Hara  hara...@chromium.org
 
 Unreviewed. Rebaselined the test that has been failing since r107046.


Modified: trunk/LayoutTests/platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt (107070 => 107071)

--- trunk/LayoutTests/platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt	2012-02-08 12:24:50 UTC (rev 107070)
+++ trunk/LayoutTests/platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt	2012-02-08 12:31:11 UTC (rev 107071)
@@ -4,4 +4,4 @@
   RenderSVGRoot {svg} at (40,8) size 108x42
 RenderSVGText {text} at (20,4) size 54x21 contains 1 chunk(s)
   RenderSVGInlineText {#text} at (0,0) size 54x21
-chunk 1 text run 1 at (20.00,20.00) startOffset 0 endOffset 6 width 53.50: Passed
+chunk 1 text run 1 at (20.00,20.00) startOffset 0 endOffset 6 width 54.00: Passed


Modified: trunk/LayoutTests/platform/qt/svg/custom/getTransformToElement-expected.txt (107070 => 107071)

--- trunk/LayoutTests/platform/qt/svg/custom/getTransformToElement-expected.txt	2012-02-08 12:24:50 UTC (rev 107070)
+++ trunk/LayoutTests/platform/qt/svg/custom/getTransformToElement-expected.txt	2012-02-08 12:31:11 UTC (rev 107071)
@@ -3,9 +3,9 @@
 layer at (0,0) size 800x600
   RenderSVGRoot {svg} at (20,55) size 101x158
 RenderSVGContainer {g} at (0,0) size 0x0 [transform={m=((0.00,0.00)(0.00,0.00)) t=(0.00,0.00)}]
-RenderSVGContainer {g} at (20,55) size 50x20 [transform={m=((1.00,0.00)(0.00,1.00)) t=(15.00,15.00)}]
-  RenderSVGText {text} at (50,120) size 100x40 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 100x40
-  chunk 1 text run 1 at (50.00,150.00) startOffset 0 endOffset 6 width 100.00: Passed
+RenderSVGContainer {g} at (20,55) size 51x20 [transform={m=((1.00,0.00)(0.00,1.00)) t=(15.00,15.00)}]
+  RenderSVGText {text} at (50,121) size 101x38 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 101x38
+  chunk 1 text run 1 at (50.00,150.00) startOffset 0 endOffset 6 width 101.00: Passed
 RenderSVGContainer {g} at (49,141) size 72x72 [transform={m=((0.71,0.71)(-0.71,0.71)) t=(0.00,0.00)}]
   RenderSVGRect {rect} at (49,141) size 72x72 [transform={m=((1.00,0.00)(0.00,1.00)) t=(100.00,0.00)}] [x=50.00] [y=50.00] [width=70.00] [height=30.00]


Modified: trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt (107070 => 107071)

--- trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt	2012-02-08 12:24:50 UTC (rev 107070)
+++ trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt	2012-02-08 12:31:11 UTC (rev 107071)
@@ -63,49 +63,49 @@
   RenderSVGText {text} at (0,101) size 101x21 contains 1 chunk(s)
 RenderSVGInlineText {#text} at (0,0) size 101x21
   chunk 1 text run 1 at (0.00,117.00) startOffset 0 endOffset 14 width 101.00: visiblePainted
-  RenderSVGText {text} at (50,39) size 11x26 contains 1 chunk(s)
+  RenderSVGText {text} at (50,38) size 11x26 contains 1 chunk(s)
 RenderSVGInlineText {#text} at (0,0) size 11x26
   chunk 1 text run 1 at (50.00,58.50) startOffset 0 endOffset 1 width 11.00: #
   RenderSVGText {text} at (105,91) size 33x21 contains 1 chunk(s)
 RenderSVGInlineText {#text} at (0,0) size 33x21
   chunk 1 text run 1 at (105.00,107.00) startOffset 0 endOffset 4 width 33.00: miss
-  RenderSVGText {text} at (78,39) size 11x26 contains 1 chunk(s)
+  RenderSVGText {text} at (78,38) size 11x26 contains 

[webkit-changes] [107072] trunk

[commit-queue]

Title: [107072] trunk








Revision 107072
Author commit-qu...@webkit.org
Date 2012-02-08 04:34:24 -0800 (Wed, 08 Feb 2012)


Log Message
CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.
https://bugs.webkit.org/show_bug.cgi?id=69993

Patch by Antaryami Pandia antaryami.pan...@motorola.com on 2012-02-08
Reviewed by Simon Fraser.

Source/WebCore:

The issue was that for overflow:scroll, currently webkit always places the horizontal
and vertical scrollbar. But Since the listbox renderer handles its scrolling,
we should not set scrollbar for list-box.

Tests: fast/css/getComputedStyle/computed-style-select-overflow.html
   fast/forms/select-overflow-scroll-inherited.html
   fast/forms/select-overflow-scroll.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

LayoutTests:

* fast/css/getComputedStyle/computed-style-select-overflow-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-select-overflow.html: Added.
* fast/forms/select-overflow-scroll-inherited.html: Added.
* fast/forms/select-overflow-scroll.html: Added.
* platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow.html
trunk/LayoutTests/fast/forms/select-overflow-scroll-inherited.html
trunk/LayoutTests/fast/forms/select-overflow-scroll.html
trunk/LayoutTests/platform/gtk/fast/forms/select-overflow-scroll-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107071 => 107072)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:31:11 UTC (rev 107071)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:34:24 UTC (rev 107072)
@@ -1,3 +1,17 @@
+2012-02-08  Antaryami Pandia  antaryami.pan...@motorola.com
+
+CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.
+https://bugs.webkit.org/show_bug.cgi?id=69993
+
+Reviewed by Simon Fraser.
+
+* fast/css/getComputedStyle/computed-style-select-overflow-expected.txt: Added.
+* fast/css/getComputedStyle/computed-style-select-overflow.html: Added.
+* fast/forms/select-overflow-scroll-inherited.html: Added.
+* fast/forms/select-overflow-scroll.html: Added.
+* platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Added.
+* platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
+
 2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Not reviewed. Rebaseline Qt/SVG results.


Added: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow-expected.txt (0 => 107072)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow-expected.txt	2012-02-08 12:34:24 UTC (rev 107072)
@@ -0,0 +1,10 @@
+Test computed style for the overflow property of select element
+
+PASS computedOverflowStyle('scroll', 'overflow-x') is 'scroll'
+PASS computedOverflowStyle('scroll', 'overflow-y') is 'scroll'
+PASS computedInheritedOverflowStyle('inherit', 'overflow-x') is 'scroll'
+PASS computedInheritedOverflowStyle('inherit', 'overflow-y') is 'scroll'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow.html (0 => 107072)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow.html	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow.html	2012-02-08 12:34:24 UTC (rev 107072)
@@ -0,0 +1,57 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+link rel=stylesheet href=""
+script src=""
+/head
+body
+pTest computed style for the overflow property of select element/p
+div id=console/div
+
+div id=test
+select id=wut name=wut size=8
+option value=1One/option
+option value=2Two/option
+option value=3Three/option
+option value=4Four/option
+option value=5Five/option
+option value=6Six/option
+option value=7Seven/option
+option value=8Eight/option
+option value=9Nine/option
+option value=10Ten/option
+/select
+/div
+
+script
+
+
+function computedOverflowStyle(overflowStyle, property) {
+var selectElement = document.getElementById(wut);
+selectElement.style.overflow = overflowStyle;
+return window.getComputedStyle(selectElement).getPropertyValue(property);
+}
+

[webkit-changes] [107073] trunk/LayoutTests

[zimmermann]

Title: [107073] trunk/LayoutTests








Revision 107073
Author zimmerm...@webkit.org
Date 2012-02-08 04:37:31 -0800 (Wed, 08 Feb 2012)


Log Message
2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com

Not reviewed. Rebaseline Gtk/SVG results.

* platform/gtk/svg/carto.net/scrollbar-expected.txt:
* platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/carto.net/scrollbar-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107072 => 107073)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:34:24 UTC (rev 107072)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:37:31 UTC (rev 107073)
@@ -1,3 +1,10 @@
+2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
+
+Not reviewed. Rebaseline Gtk/SVG results.
+
+* platform/gtk/svg/carto.net/scrollbar-expected.txt:
+* platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:
+
 2012-02-08  Antaryami Pandia  antaryami.pan...@motorola.com
 
 CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.


Modified: trunk/LayoutTests/platform/gtk/svg/carto.net/scrollbar-expected.txt (107072 => 107073)

--- trunk/LayoutTests/platform/gtk/svg/carto.net/scrollbar-expected.txt	2012-02-08 12:34:24 UTC (rev 107072)
+++ trunk/LayoutTests/platform/gtk/svg/carto.net/scrollbar-expected.txt	2012-02-08 12:37:31 UTC (rev 107073)
@@ -84,15 +84,15 @@
 RenderSVGRect {rect} at (39,483) size 89x17 [fill={[type=SOLID] [color=#FF]}] [x=49.00] [y=579.00] [width=110.00] [height=20.00]
 RenderSVGRect {rect} at (40,484) size 89x17 [fill={[type=SOLID] [color=#696969]}] [x=51.00] [y=581.00] [width=110.00] [height=20.00]
 RenderSVGRect {rect} at (40,484) size 88x16 [fill={[type=SOLID] [color=#DCDCDC]}] [x=50.00] [y=580.00] [width=110.00] [height=20.00]
-RenderSVGText {text} at (65,584) size 79x14 contains 1 chunk(s)
-  RenderSVGTSpan {tspan} at (0,0) size 79x14
-RenderSVGInlineText {#text} at (0,0) size 79x14
-  chunk 1 (middle anchor) text run 1 at (65.75,595.40) startOffset 0 endOffset 14 width 78.50: Hide Scrollbar
+RenderSVGText {text} at (67,584) size 76x14 contains 1 chunk(s)
+  RenderSVGTSpan {tspan} at (0,0) size 76x14
+RenderSVGInlineText {#text} at (0,0) size 76x14
+  chunk 1 (middle anchor) text run 1 at (67.32,595.40) startOffset 0 endOffset 14 width 75.36: Hide Scrollbar
   RenderSVGContainer {g} at (135,483) size 90x18
 RenderSVGRect {rect} at (135,483) size 89x17 [fill={[type=SOLID] [color=#FF]}] [x=169.00] [y=579.00] [width=110.00] [height=20.00]
 RenderSVGRect {rect} at (136,484) size 89x17 [fill={[type=SOLID] [color=#696969]}] [x=171.00] [y=581.00] [width=110.00] [height=20.00]
 RenderSVGRect {rect} at (136,484) size 88x16 [fill={[type=SOLID] [color=#DCDCDC]}] [x=170.00] [y=580.00] [width=110.00] [height=20.00]
-RenderSVGText {text} at (175,584) size 100x14 contains 1 chunk(s)
-  RenderSVGTSpan {tspan} at (0,0) size 100x14
-RenderSVGInlineText {#text} at (0,0) size 100x14
-  chunk 1 (middle anchor) text run 1 at (175.33,595.40) startOffset 0 endOffset 16 width 99.34: Remove Scrollbar
+RenderSVGText {text} at (177,584) size 96x14 contains 1 chunk(s)
+  RenderSVGTSpan {tspan} at (0,0) size 96x14
+RenderSVGInlineText {#text} at (0,0) size 96x14
+  chunk 1 (middle anchor) text run 1 at (177.32,595.40) startOffset 0 endOffset 16 width 95.37: Remove Scrollbar


Modified: trunk/LayoutTests/platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt (107072 => 107073)

--- trunk/LayoutTests/platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt	2012-02-08 12:34:24 UTC (rev 107072)
+++ trunk/LayoutTests/platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt	2012-02-08 12:37:31 UTC (rev 107073)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 20: Error: Problem parsing points=undefined
+CONSOLE MESSAGE: line 1: Error: Problem parsing points=undefined
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107074] trunk/LayoutTests

[ossy]

Title: [107074] trunk/LayoutTests








Revision 107074
Author o...@webkit.org
Date 2012-02-08 04:38:46 -0800 (Wed, 08 Feb 2012)


Log Message
[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.

* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/qt/svg/custom/getTransformToElement-expected.png:
* platform/qt/svg/custom/getTransformToElement-expected.txt:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/qt/svg/custom/polyline-setattribute-points-null-expected.png:
* platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
* platform/qt/svg/custom/text-ctm-expected.png:
* platform/qt/svg/custom/text-ctm-expected.txt:
* platform/qt/svg/custom/text-hit-test-expected.png:
* platform/qt/svg/custom/text-hit-test-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png
trunk/LayoutTests/platform/qt/svg/custom/getTransformToElement-expected.png
trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.png
trunk/LayoutTests/platform/qt/svg/custom/polyline-setattribute-points-null-expected.png
trunk/LayoutTests/platform/qt/svg/custom/text-ctm-expected.png
trunk/LayoutTests/platform/qt/svg/custom/text-hit-test-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (107073 => 107074)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:37:31 UTC (rev 107073)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:38:46 UTC (rev 107074)
@@ -1,3 +1,20 @@
+2012-02-08  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.
+
+* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
+* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
+* platform/qt/svg/custom/getTransformToElement-expected.png:
+* platform/qt/svg/custom/getTransformToElement-expected.txt:
+* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
+* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
+* platform/qt/svg/custom/polyline-setattribute-points-null-expected.png:
+* platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
+* platform/qt/svg/custom/text-ctm-expected.png:
+* platform/qt/svg/custom/text-ctm-expected.txt:
+* platform/qt/svg/custom/text-hit-test-expected.png:
+* platform/qt/svg/custom/text-hit-test-expected.txt:
+
 2012-02-08  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Not reviewed. Rebaseline Gtk/SVG results.


Modified: trunk/LayoutTests/platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt/svg/custom/getTransformToElement-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt/svg/custom/pointer-events-text-css-transform-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt/svg/custom/polyline-setattribute-points-null-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt/svg/custom/text-ctm-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt/svg/custom/text-hit-test-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107075] trunk/LayoutTests

[ossy]

Title: [107075] trunk/LayoutTests








Revision 107075
Author o...@webkit.org
Date 2012-02-08 04:48:11 -0800 (Wed, 08 Feb 2012)


Log Message
[Qt] New http/tests/security/ introduced r107046 fail
https://bugs.webkit.org/show_bug.cgi?id=78093

Unskip these tests and rebaselines for Qt and GTK.

Patch by Ádám Kallai kallai.a...@stud.u-szeged.hu on 2012-02-08
Reviewed by Csaba Osztrogonác.

* platform/gtk/Skipped:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
* platform/qt/Skipped:
* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/gtk/http/tests/security/cross-frame-access-put-expected.txt
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/http/tests/security/cross-frame-access-put-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107074 => 107075)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:38:46 UTC (rev 107074)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:48:11 UTC (rev 107075)
@@ -1,3 +1,17 @@
+2012-02-08  Ádám Kallai  kallai.a...@stud.u-szeged.hu
+
+[Qt] New http/tests/security/ introduced r107046 fail
+https://bugs.webkit.org/show_bug.cgi?id=78093
+
+Unskip these tests and rebaselines for Qt and GTK.
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/gtk/Skipped:
+* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
+* platform/qt/Skipped:
+* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
+
 2012-02-08  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed gardening after r107057. Update Qt specific expected results.


Modified: trunk/LayoutTests/platform/gtk/Skipped (107074 => 107075)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-02-08 12:38:46 UTC (rev 107074)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-02-08 12:48:11 UTC (rev 107075)
@@ -1516,10 +1516,6 @@
 tables/mozilla/bugs/bug14929.html
 tables/mozilla/bugs/bug2947.html
 
-# Needs rebaselining
-# https://bugs.webkit.org/show_bug.cgi?id=77971
-http/tests/security/cross-frame-access-put.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=74276
 fast/events/dont-loose-last-event.html
 


Modified: trunk/LayoutTests/platform/gtk/http/tests/security/cross-frame-access-put-expected.txt (107074 => 107075)

--- trunk/LayoutTests/platform/gtk/http/tests/security/cross-frame-access-put-expected.txt	2012-02-08 12:38:46 UTC (rev 107074)
+++ trunk/LayoutTests/platform/gtk/http/tests/security/cross-frame-access-put-expected.txt	2012-02-08 12:48:11 UTC (rev 107075)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
+
 CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.
 
 CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.
@@ -473,7 +475,9 @@
 ALERT: PASS: window.document should be '[object HTMLDocument]' and is.
 ALERT: PASS: window.embeds should be 'undefined' and is.
 ALERT: PASS: window.event should be 'undefined' and is.
-ALERT: PASS: window.frameElement should be '[object HTMLIFrameElement]' and is.
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
+
+ALERT: PASS: window.frameElement should be 'undefined' and is.
 ALERT: PASS: window.frames should be '[object DOMWindow]' and is.
 ALERT: PASS: window.history should be '[object History]' and is.
 ALERT: PASS: window.images should be 'undefined' and is.


Modified: trunk/LayoutTests/platform/qt/Skipped (107074 => 107075)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-08 12:38:46 UTC (rev 107074)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-08 12:48:11 UTC (rev 107075)
@@ -558,9 +558,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=72491
 http/tests/misc/onload-remove-iframe-crash-2.html
 
-# Needs rebaselining
-# https://bugs.webkit.org/show_bug.cgi?id=77971
-http/tests/security/cross-frame-access-put.html
 
 # === #
 #   Failing xmlhttprequest tests  #


Modified: 

[webkit-changes] [107076] trunk/Source/WebCore

[apavlov]

Title: [107076] trunk/Source/WebCore








Revision 107076
Author apav...@chromium.org
Date 2012-02-08 04:58:19 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: Avoid an avalanche of class attribute modifications in WatchExpressionsSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=78102

Reviewed by Vsevolod Vlasov.

* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (107075 => 107076)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 12:48:11 UTC (rev 107075)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 12:58:19 UTC (rev 107076)
@@ -1,3 +1,13 @@
+2012-02-08  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: Avoid an avalanche of class attribute modifications in WatchExpressionsSidebarPane
+https://bugs.webkit.org/show_bug.cgi?id=78102
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/WatchExpressionsSidebarPane.js:
+(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
+
 2012-02-08  Antaryami Pandia  antaryami.pan...@motorola.com
 
 CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.


Modified: trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js (107075 => 107076)

--- trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js	2012-02-08 12:48:11 UTC (rev 107075)
+++ trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js	2012-02-08 12:58:19 UTC (rev 107076)
@@ -277,20 +277,24 @@
 
 _updateHoveredElement: function(pageY)
 {
-if (this._hoveredElement)
-this._hoveredElement.removeStyleClass(hovered);
-
-this._hoveredElement = this.propertiesElement.firstChild;
+var candidateElement = this.propertiesElement.firstChild;
 while (true) {
-var next = this._hoveredElement.nextSibling;
-while(next  !next.clientHeight)
+var next = candidateElement.nextSibling;
+while (next  !next.clientHeight)
 next = next.nextSibling;
 if (!next || next.totalOffsetTop()  pageY)
 break;
-this._hoveredElement = next;
+candidateElement = next;
 }
-this._hoveredElement.addStyleClass(hovered);
 
+if (this._hoveredElement !== candidateElement) {
+if (this._hoveredElement)
+this._hoveredElement.removeStyleClass(hovered);
+if (candidateElement)
+candidateElement.addStyleClass(hovered);
+this._hoveredElement = candidateElement;
+}
+
 this._lastMouseMovePageY = pageY;
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107077] trunk/LayoutTests

[philn]

Title: [107077] trunk/LayoutTests








Revision 107077
Author ph...@webkit.org
Date 2012-02-08 04:59:38 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed, GTK rebaseline and skipping 2 new failing tests.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107076 => 107077)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:58:19 UTC (rev 107076)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 12:59:38 UTC (rev 107077)
@@ -1,3 +1,10 @@
+2012-02-08  Philippe Normand  pnorm...@igalia.com
+
+Unreviewed, GTK rebaseline and skipping 2 new failing tests.
+
+* platform/gtk/Skipped:
+* platform/gtk/fast/dom/Window/window-properties-expected.txt:
+
 2012-02-08  Ádám Kallai  kallai.a...@stud.u-szeged.hu
 
 [Qt] New http/tests/security/ introduced r107046 fail


Modified: trunk/LayoutTests/platform/gtk/Skipped (107076 => 107077)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-02-08 12:58:19 UTC (rev 107076)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-02-08 12:59:38 UTC (rev 107077)
@@ -662,6 +662,7 @@
 # No authentication challenge handling
 # https://bugs.webkit.org/show_bug.cgi?id=51104
 http/tests/loading/basic-credentials-sent-automatically.html
+http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
 http/tests/cache/subresource-fragment-identifier.html
 http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
 http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
@@ -1625,3 +1626,7 @@
 
 # https://bugs.webkit.org/show_bug.cgi?id=77633
 fast/forms/listbox-clear-restore.html
+
+# Synthetic bold is illegible under some scaling transforms
+# https://bugs.webkit.org/show_bug.cgi?id=78044
+fast/text/synthetic-bold-transformed.html


Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (107076 => 107077)

--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt	2012-02-08 12:58:19 UTC (rev 107076)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt	2012-02-08 12:59:38 UTC (rev 107077)
@@ -2453,7 +2453,7 @@
 window.find [function]
 window.flushLog [function]
 window.focus [function]
-window.frameElement [null]
+window.frameElement [undefined]
 window.frames [printed above as window]
 window.getComputedStyle [function]
 window.getMatchedCSSRules [function]
@@ -2465,6 +2465,7 @@
 window.history.length [number]
 window.history.pushState [function]
 window.history.replaceState [function]
+window.history.state [null]
 window.innerHeight [number]
 window.innerWidth [number]
 window.isFinite [function]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107078] trunk/LayoutTests

[podivilov]

Title: [107078] trunk/LayoutTests








Revision 107078
Author podivi...@chromium.org
Date 2012-02-08 05:00:54 -0800 (Wed, 08 Feb 2012)


Log Message
2012-02-08  Pavel Podivilov  podivi...@chromium.org

Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium.
https://bugs.webkit.org/show_bug.cgi?id=78084

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107077 => 107078)

--- trunk/LayoutTests/ChangeLog	2012-02-08 12:59:38 UTC (rev 107077)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 13:00:54 UTC (rev 107078)
@@ -1,3 +1,10 @@
+2012-02-08  Pavel Podivilov  podivi...@chromium.org
+
+Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium.
+https://bugs.webkit.org/show_bug.cgi?id=78084
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-08  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, GTK rebaseline and skipping 2 new failing tests.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107077 => 107078)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 12:59:38 UTC (rev 107077)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 13:00:54 UTC (rev 107078)
@@ -4065,3 +4065,5 @@
 
 BUGWK78038 DEBUG : compositing/iframes/invisible-nested-iframe-show.html = PASS CRASH
 BUGWK78038 DEBUG : compositing/iframes/layout-on-compositing-change.html = PASS CRASH
+
+BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107079] trunk/Source/WebCore

[apavlov]

Title: [107079] trunk/Source/WebCore








Revision 107079
Author apav...@chromium.org
Date 2012-02-08 05:22:33 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: Add changes for Spectrum colorpicker
https://bugs.webkit.org/show_bug.cgi?id=75454

Patch by Brian Grinstead briangrinst...@gmail.com on 2012-02-01
Reviewed by Pavel Feldman.

* inspector/front-end/Color.js:
(WebInspector.Color.fromRGB):
* inspector/front-end/utilities.js:
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
():

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Color.js
trunk/Source/WebCore/inspector/front-end/utilities.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (107078 => 107079)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 13:00:54 UTC (rev 107078)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 13:22:33 UTC (rev 107079)
@@ -1,3 +1,19 @@
+2012-02-01  Brian Grinstead  briangrinst...@gmail.com
+
+Web Inspector: Add changes for Spectrum colorpicker
+https://bugs.webkit.org/show_bug.cgi?id=75454
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/Color.js:
+(WebInspector.Color.fromRGB):
+* inspector/front-end/utilities.js:
+(Element.prototype.totalOffsetLeft):
+(Element.prototype.totalOffsetTop):
+(Element.prototype.totalOffset):
+(Element.prototype.scrollOffset):
+():
+
 2012-02-08  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: Avoid an avalanche of class attribute modifications in WatchExpressionsSidebarPane


Modified: trunk/Source/WebCore/inspector/front-end/Color.js (107078 => 107079)

--- trunk/Source/WebCore/inspector/front-end/Color.js	2012-02-08 13:00:54 UTC (rev 107078)
+++ trunk/Source/WebCore/inspector/front-end/Color.js	2012-02-08 13:22:33 UTC (rev 107079)
@@ -44,6 +44,11 @@
 return new WebInspector.Color(rgba( + r + , + g + , + b + , + (typeof a === undefined ? 1 : a) + ));
 }
 
+WebInspector.Color.fromRGB = function(r, g, b)
+{
+return new WebInspector.Color(rgb( + r + , + g + , + b + ));
+}
+
 WebInspector.Color.prototype = {
 /**
  * @return {string}


Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (107078 => 107079)

--- trunk/Source/WebCore/inspector/front-end/utilities.js	2012-02-08 13:00:54 UTC (rev 107078)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js	2012-02-08 13:22:33 UTC (rev 107079)
@@ -256,14 +256,7 @@
  */
 Element.prototype.totalOffsetLeft = function()
 {
-var total = 0;
-for (var element = this; element; element = element.offsetParent) {
-total += element.offsetLeft 
-if (this !== element)
-total += element.clientLeft - element.scrollLeft;
-}
-
-return total;
+return this.totalOffset().left;
 }
 
 /**
@@ -271,16 +264,38 @@
  */
 Element.prototype.totalOffsetTop = function()
 {
-var total = 0;
+return this.totalOffset().top;
+
+}
+
+Element.prototype.totalOffset = function()
+{
+var totalLeft = 0;
+var totalTop = 0;
+
 for (var element = this; element; element = element.offsetParent) {
-total += element.offsetTop 
-if (this !== element)
-total += element.clientTop - element.scrollTop;
+totalLeft += element.offsetLeft;
+totalTop += element.offsetTop;
+if (this !== element) {
+totalLeft += element.clientLeft - element.scrollLeft;
+totalTop += element.clientTop - element.scrollTop;
+}
 }
-
-return total;
+
+return { left: totalLeft, top: totalTop };
 }
 
+Element.prototype.scrollOffset = function()
+{
+var curLeft = 0;
+var curTop = 0;
+for (var element = this; element; element = element.scrollParent) {
+curLeft += element.scrollLeft;
+curTop += element.scrollTop;
+}
+return { left: curLeft, top: curTop };
+}
+
 /**
  * @constructor
  * @param {number=} x
@@ -901,6 +916,11 @@
 return event.keyCode !== 229  event.keyIdentifier === Enter;
 }
 
+function stopPropagation(e)
+{
+e.stopPropagation();
+}
+
 /**
  * @param {Element} element
  * @param {number} offset






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107080] trunk/LayoutTests

[podivilov]

Title: [107080] trunk/LayoutTests








Revision 107080
Author podivi...@chromium.org
Date 2012-02-08 06:02:21 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed, update chromium svg expectations after r107067.

* platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-property-change-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-target-style-change-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-property-change-expected.png
trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-style-change-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (107079 => 107080)

--- trunk/LayoutTests/ChangeLog	2012-02-08 13:22:33 UTC (rev 107079)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 14:02:21 UTC (rev 107080)
@@ -1,5 +1,31 @@
 2012-02-08  Pavel Podivilov  podivi...@chromium.org
 
+Unreviewed, update chromium svg expectations after r107067.
+
+* 

[webkit-changes] [107081] trunk/LayoutTests

[podivilov]

Title: [107081] trunk/LayoutTests








Revision 107081
Author podivi...@chromium.org
Date 2012-02-08 06:06:04 -0800 (Wed, 08 Feb 2012)


Log Message
2012-02-08  Pavel Podivilov  podivi...@chromium.org

Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107080 => 107081)

--- trunk/LayoutTests/ChangeLog	2012-02-08 14:02:21 UTC (rev 107080)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 14:06:04 UTC (rev 107081)
@@ -1,5 +1,11 @@
 2012-02-08  Pavel Podivilov  podivi...@chromium.org
 
+Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE.
+
+* platform/chromium/test_expectations.txt:
+
+2012-02-08  Pavel Podivilov  podivi...@chromium.org
+
 Unreviewed, update chromium svg expectations after r107067.
 
 * platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107080 => 107081)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 14:02:21 UTC (rev 107080)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 14:06:04 UTC (rev 107081)
@@ -4046,7 +4046,7 @@
 BUGWK78084 : svg/custom/SVGPoint-matrixTransform.svg = IMAGE+TEXT
 BUGWK78084 : svg/custom/getTransformToElement.svg = IMAGE+TEXT
 BUGWK78084 : svg/custom/polyline-setattribute-points-null.svg = IMAGE+TEXT
-BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE+TEXT
+BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE+TEXT IMAGE
 BUGWK78084 : svg/custom/text-ctm.svg = IMAGE+TEXT
 BUGWK78084 : svg/custom/text-hit-test.svg = IMAGE+TEXT
 
@@ -4065,5 +4065,3 @@
 
 BUGWK78038 DEBUG : compositing/iframes/invisible-nested-iframe-show.html = PASS CRASH
 BUGWK78038 DEBUG : compositing/iframes/layout-on-compositing-change.html = PASS CRASH
-
-BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107082] trunk

[commit-queue]

Title: [107082] trunk








Revision 107082
Author commit-qu...@webkit.org
Date 2012-02-08 06:39:18 -0800 (Wed, 08 Feb 2012)


Log Message
Migrate createObjectURL  revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar kaust...@motorola.com on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Move createObjectURL  revokeObjectURL from DOMURL implementation to
static methods as per specs - http://www.w3.org/TR/FileAPI/#creating-revoking

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
* html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
* html/DOMURL.idl:
* html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
* page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
* page/DOMWindow.h: ditto.
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL  revokeObjectURL are static functions.

* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: GTK Rebaseline.
* platform/gtk/fast/js/global-constructors-expected.txt: ditto.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Qt Rebaseline.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: ditto.
* platform/qt/fast/js/global-constructors-expected.txt: ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/html/DOMURL.cpp
trunk/Source/WebCore/html/DOMURL.h
trunk/Source/WebCore/html/DOMURL.idl
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h
trunk/Source/WebCore/page/DOMWindow.idl
trunk/Source/WebCore/workers/WorkerContext.cpp
trunk/Source/WebCore/workers/WorkerContext.h
trunk/Source/WebCore/workers/WorkerContext.idl


Added Paths

trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt
trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html
trunk/Source/WebCore/html/PublicURLManager.h




Diff

Modified: trunk/LayoutTests/ChangeLog (107081 => 107082)

--- trunk/LayoutTests/ChangeLog	2012-02-08 14:06:04 UTC (rev 107081)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 14:39:18 UTC (rev 107082)
@@ -1,3 +1,20 @@
+2012-02-08  Kaustubh Atrawalkar  kaust...@motorola.com
+
+Migrate createObjectURL  revokeObjectURL to static (Class) methods.
+https://bugs.webkit.org/show_bug.cgi?id=74386
+
+Reviewed by Kentaro Hara.
+
+Added test to check if createObjectURL  revokeObjectURL are static functions.
+
+* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
+* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
+* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: GTK Rebaseline.
+* platform/gtk/fast/js/global-constructors-expected.txt: ditto.
+* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Qt Rebaseline.
+* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: ditto.
+* platform/qt/fast/js/global-constructors-expected.txt: ditto.
+
 2012-02-08  Pavel Podivilov  podivi...@chromium.org
 
 Unreviewed, 

[webkit-changes] [107083] trunk/Source/WebCore

[pfeldman]

Title: [107083] trunk/Source/WebCore








Revision 107083
Author pfeld...@chromium.org
Date 2012-02-08 06:49:26 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: do not clear entire tree map upon last element deletion.
https://bugs.webkit.org/show_bug.cgi?id=78112

Reviewed by Yury Semikhatsky.

* inspector/front-end/treeoutline.js:
(TreeOutline.prototype._forgetChildrenRecursive):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/treeoutline.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (107082 => 107083)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 14:39:18 UTC (rev 107082)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 14:49:26 UTC (rev 107083)
@@ -1,3 +1,13 @@
+2012-02-08  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: do not clear entire tree map upon last element deletion.
+https://bugs.webkit.org/show_bug.cgi?id=78112
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/treeoutline.js:
+(TreeOutline.prototype._forgetChildrenRecursive):
+
 2012-02-08  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Migrate createObjectURL  revokeObjectURL to static (Class) methods.


Modified: trunk/Source/WebCore/inspector/front-end/treeoutline.js (107082 => 107083)

--- trunk/Source/WebCore/inspector/front-end/treeoutline.js	2012-02-08 14:39:18 UTC (rev 107082)
+++ trunk/Source/WebCore/inspector/front-end/treeoutline.js	2012-02-08 14:49:26 UTC (rev 107083)
@@ -237,7 +237,7 @@
 var child = parentElement.children[0];
 while (child) {
 this._forgetTreeElement(child);
-child = child.traverseNextTreeElement(false, this, true);
+child = child.traverseNextTreeElement(false, parentElement, true);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107084] trunk/LayoutTests

[podivilov]

Title: [107084] trunk/LayoutTests








Revision 107084
Author podivi...@chromium.org
Date 2012-02-08 06:57:37 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.

* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107083 => 107084)

--- trunk/LayoutTests/ChangeLog	2012-02-08 14:49:26 UTC (rev 107083)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 14:57:37 UTC (rev 107084)
@@ -1,3 +1,20 @@
+2012-02-08  Pavel Podivilov  podivi...@chromium.org
+
+Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.
+
+* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added.
+* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added.
+* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
+* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
+* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added.
+* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
+* platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added.
+* platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added.
+* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
+* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
+
 2012-02-08  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Migrate createObjectURL  revokeObjectURL to static (Class) methods.


Added: trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt (0 => 107084)

--- trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt	2012-02-08 14:57:37 UTC (rev 107084)
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 

[webkit-changes] [107085] trunk/Source/WebKit/qt

[commit-queue]

Title: [107085] trunk/Source/WebKit/qt








Revision 107085
Author commit-qu...@webkit.org
Date 2012-02-08 07:11:37 -0800 (Wed, 08 Feb 2012)


Log Message
Remote web inspector reentrancy fixes
https://bugs.webkit.org/show_bug.cgi?id=77022

Patch by Leo Franchi lfran...@kde.org on 2012-02-08
Reviewed by Joseph Pecoraro.

* WebCoreSupport/InspectorServerQt.cpp:
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (107084 => 107085)

--- trunk/Source/WebKit/qt/ChangeLog	2012-02-08 14:57:37 UTC (rev 107084)
+++ trunk/Source/WebKit/qt/ChangeLog	2012-02-08 15:11:37 UTC (rev 107085)
@@ -1,3 +1,14 @@
+2012-02-08  Leo Franchi  lfran...@kde.org
+
+Remote web inspector reentrancy fixes
+https://bugs.webkit.org/show_bug.cgi?id=77022
+
+Reviewed by Joseph Pecoraro.
+
+* WebCoreSupport/InspectorServerQt.cpp:
+(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
+(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
+
 2012-02-06  Caio Marcelo de Oliveira Filho  caio.olive...@openbossa.org
 
 Provide more attribute methods in Element


Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp (107084 => 107085)

--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp	2012-02-08 14:57:37 UTC (rev 107084)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp	2012-02-08 15:11:37 UTC (rev 107085)
@@ -209,7 +209,7 @@
 // switch to websocket-style WebSocketService messaging
 if (m_tcpConnection) {
 m_tcpConnection-disconnect(SIGNAL(readyRead()));
-connect(m_tcpConnection, SIGNAL(readyRead()), SLOT(webSocketReadyRead()));
+connect(m_tcpConnection, SIGNAL(readyRead()), SLOT(webSocketReadyRead()), Qt::QueuedConnection);
 
 QByteArray key3 = m_tcpConnection-read(8);
 
@@ -357,6 +357,10 @@
 
 QByteArray payload = m_data.mid(1, length);
 
+// Remove this WebSocket message from m_data (payload, start-of-frame byte, end-of-frame byte).
+// Truncate data before delivering message in case of re-entrancy.
+m_data = m_data.mid(length + 2);
+
 #if ENABLE(INSPECTOR)
 if (m_inspectorClient) {
   InspectorController* inspectorController = m_inspectorClient-m_inspectedWebPage-d-page-inspectorController();
@@ -364,8 +368,6 @@
 }
 #endif
 
-// Remove this WebSocket message from m_data (payload, start-of-frame byte, end-of-frame byte).
-m_data = m_data.mid(length + 2);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107086] trunk/Source

[mario]

Title: [107086] trunk/Source








Revision 107086
Author ma...@webkit.org
Date 2012-02-08 07:38:19 -0800 (Wed, 08 Feb 2012)


Log Message
[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=73431

Reviewed by Chris Fleizach.

Source/WebCore:

Don't replace item's markers with the objectReplacementCharacter
character, as they will be treated in an special way later on.

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Don't append the objectReplacementCharacter
character for list item's markers.

Source/WebKit/gtk:

Updated unit test to check text wrapping accross different lines
inside list items with bullet markers.

* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Updated test.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testatk.c




Diff

Modified: trunk/Source/WebCore/ChangeLog (107085 => 107086)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 15:11:37 UTC (rev 107085)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 15:38:19 UTC (rev 107086)
@@ -1,3 +1,17 @@
+2012-02-08  Mario Sanchez Prada  msanc...@igalia.com
+
+[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
+https://bugs.webkit.org/show_bug.cgi?id=73431
+
+Reviewed by Chris Fleizach.
+
+Don't replace item's markers with the objectReplacementCharacter
+character, as they will be treated in an special way later on.
+
+* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
+(textForRenderer): Don't append the objectReplacementCharacter
+character for list item's markers.
+
 2012-02-08  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: do not clear entire tree map upon last element deletion.


Modified: trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp (107085 => 107086)

--- trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp	2012-02-08 15:11:37 UTC (rev 107085)
+++ trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp	2012-02-08 15:38:19 UTC (rev 107086)
@@ -77,7 +77,9 @@
 if (object-isText())
 renderText = toRenderText(object);
 else {
-if (object-isReplaced())
+// List item's markers will be treated in an special way
+// later on this function, so ignore them here.
+if (object-isReplaced()  !renderer-isListItem())
 g_string_append_unichar(resultText, objectReplacementCharacter);
 
 // We need to check children, if any, to consider when


Modified: trunk/Source/WebKit/gtk/ChangeLog (107085 => 107086)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-02-08 15:11:37 UTC (rev 107085)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-02-08 15:38:19 UTC (rev 107086)
@@ -1,3 +1,16 @@
+2012-02-08  Mario Sanchez Prada  msanc...@igalia.com
+
+[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
+https://bugs.webkit.org/show_bug.cgi?id=73431
+
+Reviewed by Chris Fleizach.
+
+Updated unit test to check text wrapping accross different lines
+inside list items with bullet markers.
+
+* tests/testatk.c:
+(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Updated test.
+
 2012-02-06  Martin Robinson  mrobin...@igalia.com and Nayan Kumar K  naya...@motorola.com
 
 [GTK] Add TextureMapperGL implementation


Modified: trunk/Source/WebKit/gtk/tests/testatk.c (107085 => 107086)

--- trunk/Source/WebKit/gtk/tests/testatk.c	2012-02-08 15:11:37 UTC (rev 107085)
+++ trunk/Source/WebKit/gtk/tests/testatk.c	2012-02-08 15:38:19 UTC (rev 107086)
@@ -35,7 +35,7 @@
 
 static const char* contentsWithPreformattedText = htmlbodypre\n\t\n\tfirst line\n\tsecond line\n/pre/body/html;
 
-static const char* contentsWithSpecialChars = htmlbodyplaquo;nbsp;This is a paragraph with ldquo;specialrdquo; characters inside.nbsp;raquo;/p/body/html;
+static const char* contentsWithSpecialChars = htmlbodyplaquo;nbsp;This is a paragraph with ldquo;specialrdquo; characters inside.nbsp;raquo;/pulli style='max-width:100px;'List item with some text that wraps across different lines./li/ul/body/html;
 
 static const char* contentsInTextarea = htmlbodytextarea cols='80'This is a test. This is the second sentence. And this the third./textarea/body/html;
 
@@ -810,23 +810,44 @@
 /* Get to the inner AtkText object. */
 AtkObject* object = getWebAreaObject(webView);
 g_assert(object);
-object = atk_object_ref_accessible_child(object, 0);
-g_assert(object);
 
-AtkText* textObject = ATK_TEXT(object);
-g_assert(ATK_IS_TEXT(textObject));
+AtkObject* paragraph = atk_object_ref_accessible_child(object, 0);
+

[webkit-changes] [107087] trunk/Source/WebKit2

[carlosgc]

Title: [107087] trunk/Source/WebKit2








Revision 107087
Author carlo...@webkit.org
Date 2012-02-08 07:48:51 -0800 (Wed, 08 Feb 2012)


Log Message
[GTK] Fix WebKitWebView::decide-policy API documentation
https://bugs.webkit.org/show_bug.cgi?id=78101

Reviewed by Martin Robinson.

- It refers to WebKitPolicyClient instead of WebKitWebView
- Trailing ':' is missing
- References @decision as WebKitNavigationPolicyDecision instead
of WebKitPolicyDecision

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (107086 => 107087)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 15:38:19 UTC (rev 107086)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 15:48:51 UTC (rev 107087)
@@ -1,3 +1,18 @@
+2012-02-08  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Fix WebKitWebView::decide-policy API documentation
+https://bugs.webkit.org/show_bug.cgi?id=78101
+
+Reviewed by Martin Robinson.
+
+- It refers to WebKitPolicyClient instead of WebKitWebView
+- Trailing ':' is missing
+- References @decision as WebKitNavigationPolicyDecision instead
+of WebKitPolicyDecision
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_class_init):
+
 2012-02-08  Mahesh Kulkarni  mahesh.kulka...@nokia.com
 
 [Qt] Build broken if qt missing openssl


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (107086 => 107087)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2012-02-08 15:38:19 UTC (rev 107086)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2012-02-08 15:48:51 UTC (rev 107087)
@@ -554,9 +554,9 @@
  G_TYPE_STRING, G_TYPE_STRING, G_TYPE_POINTER);
 
 /**
- * WebKitPolicyClient::decide-policy
+ * WebKitWebView::decide-policy:
  * @web_view: the #WebKitWebView on which the signal is emitted
- * @decision: the #WebKitNavigationPolicyDecision
+ * @decision: the #WebKitPolicyDecision
  * @decision_type: a #WebKitPolicyDecisionType denoting the type of @decision
  *
  * This signal is emitted when WebKit is requesting the client to decide a policy






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107088] trunk/Tools

[carlosgc]

Title: [107088] trunk/Tools








Revision 107088
Author carlo...@webkit.org
Date 2012-02-08 07:51:08 -0800 (Wed, 08 Feb 2012)


Log Message
[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78099

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): Check whether it's a link clicked with the
middle mouse button and load the request in a new window.
(browserWindowConstructed): Connect to
WebKitWebView::decide-policy signal.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (107087 => 107088)

--- trunk/Tools/ChangeLog	2012-02-08 15:48:51 UTC (rev 107087)
+++ trunk/Tools/ChangeLog	2012-02-08 15:51:08 UTC (rev 107088)
@@ -1,3 +1,16 @@
+2012-02-08  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=78099
+
+Reviewed by Martin Robinson.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(webViewDecidePolicy): Check whether it's a link clicked with the
+middle mouse button and load the request in a new window.
+(browserWindowConstructed): Connect to
+WebKitWebView::decide-policy signal.
+
 2012-02-08  Ryosuke Niwa  rn...@webkit.org
 
 Revert a part of the change in r106687 as a build fix.


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (107087 => 107088)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2012-02-08 15:48:51 UTC (rev 107087)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2012-02-08 15:51:08 UTC (rev 107088)
@@ -235,6 +235,26 @@
 return FALSE;
 }
 
+static gboolean webViewDecidePolicy(WebKitWebView *webView, WebKitPolicyDecision *decision, WebKitPolicyDecisionType decisionType, BrowserWindow *window)
+{
+if (decisionType != WEBKIT_POLICY_DECISION_TYPE_NAVIGATION_ACTION)
+return FALSE;
+
+WebKitNavigationPolicyDecision *navigationDecision = WEBKIT_NAVIGATION_POLICY_DECISION(decision);
+if (webkit_navigation_policy_decision_get_navigation_type(navigationDecision) != WEBKIT_NAVIGATION_TYPE_LINK_CLICKED
+|| webkit_navigation_policy_decision_get_mouse_button(navigationDecision) != 2)
+return FALSE;
+
+WebKitWebView *newWebView = WEBKIT_WEB_VIEW(webkit_web_view_new_with_context(webkit_web_view_get_context(webView)));
+webkit_web_view_set_settings(newWebView, webkit_web_view_get_settings(webView));
+GtkWidget *newWindow = browser_window_new(newWebView);
+webkit_web_view_load_request(newWebView, webkit_navigation_policy_decision_get_request(navigationDecision));
+gtk_widget_show(newWindow);
+
+webkit_policy_decision_ignore(decision);
+return TRUE;
+}
+
 static void browserWindowFinalize(GObject *gObject)
 {
 G_OBJECT_CLASS(browser_window_parent_class)-finalize(gObject);
@@ -333,6 +353,7 @@
 g_signal_connect(window-webView, notify::title, G_CALLBACK(webViewTitleChanged), window);
 g_signal_connect(window-webView, create, G_CALLBACK(webViewCreate), window);
 g_signal_connect(window-webView, load-failed, G_CALLBACK(webViewLoadFailed), window);
+g_signal_connect(window-webView, decide-policy, G_CALLBACK(webViewDecidePolicy), window);
 
 WebKitBackForwardList *backForwadlist = webkit_web_view_get_back_forward_list(window-webView);
 g_signal_connect(backForwadlist, changed, G_CALLBACK(backForwadlistChanged), window);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107089] trunk/Source/WebCore

[yurys]

Title: [107089] trunk/Source/WebCore








Revision 107089
Author yu...@chromium.org
Date 2012-02-08 07:51:53 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes
https://bugs.webkit.org/show_bug.cgi?id=77972

When object popover is shown the object under cursor is resolved and its
wrapper is put into 'popover' object wrapper group. The group is discarded
when the popover closes.

Reviewed by Pavel Feldman.

* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
* bindings/js/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):
* bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._resolveObjectForPopover):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
(WebInspector._javascript_SourceFrame.prototype._onHidePopover):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp
trunk/Source/WebCore/bindings/js/ScriptProfiler.h
trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp
trunk/Source/WebCore/bindings/v8/ScriptProfiler.h
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp
trunk/Source/WebCore/inspector/InspectorProfilerAgent.h
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (107088 => 107089)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 15:51:08 UTC (rev 107088)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 15:51:53 UTC (rev 107089)
@@ -1,3 +1,43 @@
+2012-02-07  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes
+https://bugs.webkit.org/show_bug.cgi?id=77972
+
+When object popover is shown the object under cursor is resolved and its
+wrapper is put into 'popover' object wrapper group. The group is discarded
+when the popover closes.
+
+Reviewed by Pavel Feldman.
+
+* bindings/js/ScriptProfiler.cpp:
+(WebCore::ScriptProfiler::objectByHeapObjectId):
+* bindings/js/ScriptProfiler.h:
+(WebCore):
+(ScriptProfiler):
+* bindings/v8/ScriptProfiler.cpp:
+(WebCore::ScriptProfiler::objectByHeapObjectId):
+(WebCore):
+* bindings/v8/ScriptProfiler.h:
+(WebCore):
+(ScriptProfiler):
+* inspector/Inspector.json:
+* inspector/InspectorProfilerAgent.cpp:
+(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
+* inspector/InspectorProfilerAgent.h:
+(InspectorProfilerAgent):
+* inspector/front-end/DetailedHeapshotGridNodes.js:
+(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
+* inspector/front-end/DetailedHeapshotView.js:
+(WebInspector.DetailedHeapshotView.prototype._resolveObjectForPopover):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame):
+(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
+(WebInspector._javascript_SourceFrame.prototype._onHidePopover):
+* inspector/front-end/ObjectPopoverHelper.js:
+(WebInspector.ObjectPopoverHelper):
+(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
+(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):
+
 2012-02-08  Mario Sanchez Prada  msanc...@igalia.com
 
 [Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps


Modified: trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp (107088 => 107089)

--- trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp	2012-02-08 15:51:08 UTC (rev 107088)
+++ trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp	2012-02-08 15:51:53 UTC (rev 107089)
@@ -31,8 +31,8 @@
 #include ScriptProfiler.h
 
 #include GCController.h
-#include 

[webkit-changes] [107090] trunk

[commit-queue]

Title: [107090] trunk








Revision 107090
Author commit-qu...@webkit.org
Date 2012-02-08 08:02:31 -0800 (Wed, 08 Feb 2012)


Log Message
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning michael.brun...@nokia.com on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Set default cacheModel for Qt platform to
CacheModelPrimaryWebBrowser.

LayoutTests:

* platform/qt-wk2/Skipped: Unskip tests skipped for regression from r106920.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (107089 => 107090)

--- trunk/LayoutTests/ChangeLog	2012-02-08 15:51:53 UTC (rev 107089)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 16:02:31 UTC (rev 107090)
@@ -1,3 +1,12 @@
+2012-02-08  Michael Brüning  michael.brun...@nokia.com
+
+[Qt][WK2] Compute and set cache capacities using the current CacheModel
+https://bugs.webkit.org/show_bug.cgi?id=73918
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* platform/qt-wk2/Skipped: Unskip tests skipped for regression from r106920.
+
 2012-02-08  Pavel Podivilov  podivi...@chromium.org
 
 Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.


Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (107089 => 107090)

--- trunk/LayoutTests/platform/qt-wk2/Skipped	2012-02-08 15:51:53 UTC (rev 107089)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped	2012-02-08 16:02:31 UTC (rev 107090)
@@ -422,16 +422,3 @@
 fast/history/form-submit-in-frame-via-onclick.html
 fast/history/form-submit-in-frame.html
 http/tests/loading/state-object-security-exception.html
-
-# REGRESSION(r106920) - https://bugs.webkit.org/show_bug.cgi?id=73918
-canvas/philip/tests/2d.pattern.modify.image1.html
-fast/events/pagehide-timeout.html
-fast/events/pageshow-pagehide-on-back-cached-with-frames.html
-fast/events/pageshow-pagehide-on-back-cached.html
-fast/harness/page-cache-crash-on-data-urls.html
-fast/harness/use-page-cache.html
-http/tests/cache/post-redirect-get.php
-http/tests/security/xhr-cors-redirect.html
-http/tests/xmlhttprequest/access-control-and-redirects.html
-http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html
-svg/animations/animate-color-fill-from-by.html


Modified: trunk/Source/WebKit2/ChangeLog (107089 => 107090)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 15:51:53 UTC (rev 107089)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 16:02:31 UTC (rev 107090)
@@ -1,3 +1,14 @@
+2012-02-08  Michael Brüning  michael.brun...@nokia.com
+
+[Qt][WK2] Compute and set cache capacities using the current CacheModel
+https://bugs.webkit.org/show_bug.cgi?id=73918
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::WebContext): Set default cacheModel for Qt platform to
+CacheModelPrimaryWebBrowser.
+
 2012-02-08  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Fix WebKitWebView::decide-policy API documentation


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (107089 => 107090)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2012-02-08 15:51:53 UTC (rev 107089)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2012-02-08 16:02:31 UTC (rev 107090)
@@ -122,7 +122,11 @@
 , m_visitedLinkProvider(this)
 , m_alwaysUsesComplexTextCodePath(false)
 , m_shouldUseFontSmoothing(true)
+#if PLATFORM(QT)
+, m_cacheModel(CacheModelPrimaryWebBrowser)
+#else
 , m_cacheModel(CacheModelDocumentViewer)
+#endif
 , m_memorySamplerEnabled(false)
 , m_memorySamplerInterval(1400.0)
 , m_applicationCacheManagerProxy(WebApplicationCacheManagerProxy::create(this))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107091] trunk/Source/WebCore

[commit-queue]

Title: [107091] trunk/Source/WebCore








Revision 107091
Author commit-qu...@webkit.org
Date 2012-02-08 08:17:20 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation
https://bugs.webkit.org/show_bug.cgi?id=77967

Patch by Peter Rybin peter.ry...@gmail.com on 2012-02-08
Reviewed by Yury Semikhatsky.

Condition for RefPtr-based types added. This is more-or-less a hack
and it's should be redone together with the switch to type-safe API.

* inspector/CodeGeneratorInspector.py:
(Generator.process_command):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (107090 => 107091)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 16:02:31 UTC (rev 107090)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 16:17:20 UTC (rev 107091)
@@ -1,3 +1,16 @@
+2012-02-08  Peter Rybin  peter.ry...@gmail.com
+
+Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation
+https://bugs.webkit.org/show_bug.cgi?id=77967
+
+Reviewed by Yury Semikhatsky.
+
+Condition for RefPtr-based types added. This is more-or-less a hack
+and it's should be redone together with the switch to type-safe API.
+
+* inspector/CodeGeneratorInspector.py:
+(Generator.process_command):
+
 2012-02-07  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (107090 => 107091)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-02-08 16:02:31 UTC (rev 107090)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-02-08 16:17:20 UTC (rev 107091)
@@ -2682,8 +2682,9 @@
 param = , %sout_%s % (raw_type.get_output_pass_model().get_argument_prefix(), json_return_name)
 cook = result-set%s(\%s\, out_%s);\n % (setter_type, json_return_name, json_return_name)
 if optional:
-# FIXME: support optional properly. Probably an additional output parameter should be in each case.
-if var_type.get_text() == bool:
+# FIXME: support optional properly. Probably an additional output parameter should be in each case.
+# FIXME: refactor this condition; it's a hack now.
+if var_type.get_text() == bool or var_type.get_text().startswith(RefPtr):
 cook = (if (out_%s)\n % json_return_name) + cook
 else:
 cook = // FIXME: support optional here.\n + cook






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107092] trunk/Source/WebKit2

[carlosgc]

Title: [107092] trunk/Source/WebKit2








Revision 107092
Author carlo...@webkit.org
Date 2012-02-08 08:31:14 -0800 (Wed, 08 Feb 2012)


Log Message
[GTK] Fix a crash when WebKitWebView is created without a WebContext
https://bugs.webkit.org/show_bug.cgi?id=78104

Reviewed by Philippe Normand.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty): Make sure WebKitWebView:web-context
property is initialized to the default web context when a web
context is not passed to g_object_new().
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewDefaultContext): Check that a web view created with
g_object_new has the default context.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (107091 => 107092)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 16:17:20 UTC (rev 107091)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 16:31:14 UTC (rev 107092)
@@ -1,3 +1,18 @@
+2012-02-08  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Fix a crash when WebKitWebView is created without a WebContext
+https://bugs.webkit.org/show_bug.cgi?id=78104
+
+Reviewed by Philippe Normand.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewSetProperty): Make sure WebKitWebView:web-context
+property is initialized to the default web context when a web
+context is not passed to g_object_new().
+* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+(testWebViewDefaultContext): Check that a web view created with
+g_object_new has the default context.
+
 2012-02-08  Michael Brüning  michael.brun...@nokia.com
 
 [Qt][WK2] Compute and set cache capacities using the current CacheModel


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (107091 => 107092)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2012-02-08 16:17:20 UTC (rev 107091)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2012-02-08 16:31:14 UTC (rev 107092)
@@ -180,9 +180,11 @@
 WebKitWebView* webView = WEBKIT_WEB_VIEW(object);
 
 switch (propId) {
-case PROP_WEB_CONTEXT:
-webView-priv-context = WEBKIT_WEB_CONTEXT(g_value_get_object(value));
+case PROP_WEB_CONTEXT: {
+gpointer webContext = g_value_get_object(value);
+webView-priv-context = webContext ? WEBKIT_WEB_CONTEXT(webContext) : webkit_web_context_get_default();
 break;
+}
 case PROP_ZOOM_LEVEL:
 webkit_web_view_set_zoom_level(webView, g_value_get_double(value));
 break;


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp (107091 => 107092)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2012-02-08 16:17:20 UTC (rev 107091)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2012-02-08 16:31:14 UTC (rev 107092)
@@ -26,6 +26,10 @@
 static void testWebViewDefaultContext(WebViewTest* test, gconstpointer)
 {
 g_assert(webkit_web_view_get_context(test-m_webView) == webkit_web_context_get_default());
+
+// Check that a web view created with g_object_new has the default context.
+GRefPtrWebKitWebView webView = WEBKIT_WEB_VIEW(g_object_new(WEBKIT_TYPE_WEB_VIEW, NULL));
+g_assert(webkit_web_view_get_context(webView.get()) == webkit_web_context_get_default());
 }
 
 static void testWebViewCustomCharset(WebViewTest* test, gconstpointer)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107093] trunk

[pfeldman]

Title: [107093] trunk








Revision 107093
Author pfeld...@chromium.org
Date 2012-02-08 08:42:23 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
https://bugs.webkit.org/show_bug.cgi?id=78116

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._unbind):

LayoutTests:

* inspector/elements/insert-node-expected.txt:
* inspector/elements/insert-node.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/elements/insert-node-expected.txt
trunk/LayoutTests/inspector/elements/insert-node.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMAgent.js




Diff

Modified: trunk/LayoutTests/ChangeLog (107092 => 107093)

--- trunk/LayoutTests/ChangeLog	2012-02-08 16:31:14 UTC (rev 107092)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 16:42:23 UTC (rev 107093)
@@ -1,3 +1,13 @@
+2012-02-08  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
+https://bugs.webkit.org/show_bug.cgi?id=78116
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/elements/insert-node-expected.txt:
+* inspector/elements/insert-node.html:
+
 2012-02-08  Michael Brüning  michael.brun...@nokia.com
 
 [Qt][WK2] Compute and set cache capacities using the current CacheModel


Modified: trunk/LayoutTests/inspector/elements/insert-node-expected.txt (107092 => 107093)

--- trunk/LayoutTests/inspector/elements/insert-node-expected.txt	2012-02-08 16:31:14 UTC (rev 107092)
+++ trunk/LayoutTests/inspector/elements/insert-node-expected.txt	2012-02-08 16:42:23 UTC (rev 107093)
@@ -39,3 +39,16 @@
   div id=child-after/div
   /div
 
+Running: testAppendWithText
+ Appended with text=
+- div id=container
+  div id=child-before/div
+  div id=child1/div
+  div id=child-middle/div
+  div id=child2/div
+  div id=child3/div
+  div id=child-after/div
+  div style=display: none;  id=child-with-textText/div
+  /div
+Success: child text is bound
+


Modified: trunk/LayoutTests/inspector/elements/insert-node.html (107092 => 107093)

--- trunk/LayoutTests/inspector/elements/insert-node.html	2012-02-08 16:31:14 UTC (rev 107092)
+++ trunk/LayoutTests/inspector/elements/insert-node.html	2012-02-08 16:42:23 UTC (rev 107093)
@@ -29,6 +29,16 @@
 container.appendChild(child);
 }
 
+function appendChildWithText()
+{
+var container = document.getElementById(container);
+var child = document.createElement(div);
+child.style.display = none;
+child.innerText = Text;
+child.setAttribute(id, child-with-text);
+container.appendChild(child);
+}
+
 function test()
 {
 var containerNode;
@@ -69,7 +79,8 @@
 InspectorTest.evaluateInPage(insertNode(), callback);
 },
 
-function testAppend(next) {
+function testAppend(next)
+{
 function callback()
 {
 InspectorTest.addResult( Appended =);
@@ -77,6 +88,22 @@
 next();
 }
 InspectorTest.evaluateInPage(appendChild(), callback);
+},
+
+function testAppendWithText(next)
+{
+function callback()
+{
+InspectorTest.addResult( Appended with text=);
+InspectorTest.dumpElementsTree(containerNode);
+var newNode = InspectorTest.expandedNodeWithId(child-with-text);
+if (WebInspector.domAgent.nodeForId(newNode.firstChild.id))
+InspectorTest.addResult(Success: child text is bound);
+else
+InspectorTest.addResult(Failed: child text is not bound);
+next();
+}
+InspectorTest.evaluateInPage(appendChildWithText(), callback);
 }
 ]);
 }


Modified: trunk/Source/WebCore/ChangeLog (107092 => 107093)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 16:31:14 UTC (rev 107092)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 16:42:23 UTC (rev 107093)
@@ -1,3 +1,19 @@
+2012-02-08  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
+https://bugs.webkit.org/show_bug.cgi?id=78116
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DOMAgent.js:
+(WebInspector.DOMNode):
+(WebInspector.DOMDocument):
+(WebInspector.DOMAgent.prototype._setDocument):
+(WebInspector.DOMAgent.prototype._setDetachedRoot):
+

[webkit-changes] [107094] trunk

[commit-queue]

Title: [107094] trunk








Revision 107094
Author commit-qu...@webkit.org
Date 2012-02-08 08:57:45 -0800 (Wed, 08 Feb 2012)


Log Message
Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
https://bugs.webkit.org/show_bug.cgi?id=78007

This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191

There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.

Patch by Alexei Svitkine asvitk...@chromium.org on 2012-02-08
Reviewed by James Robinson.

Source/WebKit/chromium:

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):

LayoutTests:

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png
trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png
trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png
trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png
trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png
trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw.html
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se.html
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw.html
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-e-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-n-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-ne-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-nw-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-s-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-se-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-sw-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/overhang-w-expected.png
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (107093 => 107094)

--- trunk/LayoutTests/ChangeLog	2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 16:57:45 UTC (rev 107094)
@@ -1,3 +1,18 @@
+2012-02-08  Alexei Svitkine  asvitk...@chromium.org
+
+Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
+https://bugs.webkit.org/show_bug.cgi?id=78007
+
+This got broken by: http://trac.webkit.org/changeset/105470
+And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
+
+There is still three tests that fail from the set, but the cause for these is different,
+which I'm still investigating.
+
+Reviewed by James Robinson.
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-08  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.


Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html (107093 => 107094)

--- trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html	2012-02-08 16:42:23 UTC (rev 107093)
+++ 

[webkit-changes] [107096] trunk/LayoutTests

[mitz]

Title: [107096] trunk/LayoutTests








Revision 107096
Author m...@apple.com
Date 2012-02-08 09:05:08 -0800 (Wed, 08 Feb 2012)


Log Message
Moved a Mac-specific test to platform/mac.

* fast/text/synthetic-bold-transformed-expected.html: Removed.
* fast/text/synthetic-bold-transformed.html: Removed.
* platform/mac/fast/text/synthetic-bold-transformed-expected.html: Copied from fast/text/synthetic-bold-transformed-expected.html.
* platform/mac/fast/text/synthetic-bold-transformed.html: Copied from fast/text/synthetic-bold-transformed.html.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed-expected.html
trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed.html


Removed Paths

trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html
trunk/LayoutTests/fast/text/synthetic-bold-transformed.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107095 => 107096)

--- trunk/LayoutTests/ChangeLog	2012-02-08 17:01:35 UTC (rev 107095)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 17:05:08 UTC (rev 107096)
@@ -1,3 +1,12 @@
+2012-02-08  Dan Bernstein  m...@apple.com
+
+Moved a Mac-specific test to platform/mac.
+
+* fast/text/synthetic-bold-transformed-expected.html: Removed.
+* fast/text/synthetic-bold-transformed.html: Removed.
+* platform/mac/fast/text/synthetic-bold-transformed-expected.html: Copied from fast/text/synthetic-bold-transformed-expected.html.
+* platform/mac/fast/text/synthetic-bold-transformed.html: Copied from fast/text/synthetic-bold-transformed.html.
+
 2012-02-08  Alexei Svitkine  asvitk...@chromium.org
 
 Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.


Deleted: trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html (107095 => 107096)

--- trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html	2012-02-08 17:01:35 UTC (rev 107095)
+++ trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html	2012-02-08 17:05:08 UTC (rev 107096)
@@ -1,4 +0,0 @@
-div style=position: relative;
-div style=-webkit-transform-origin: 0 0; -webkit-transform: scale(8); font-family: STSong;|/div
-div style=position: absolute; top: 0; -webkit-transform-origin: 0 0; -webkit-transform: translatex(1px) scale(8); font-family: STSong;|/div
-/div


Deleted: trunk/LayoutTests/fast/text/synthetic-bold-transformed.html (107095 => 107096)

--- trunk/LayoutTests/fast/text/synthetic-bold-transformed.html	2012-02-08 17:01:35 UTC (rev 107095)
+++ trunk/LayoutTests/fast/text/synthetic-bold-transformed.html	2012-02-08 17:05:08 UTC (rev 107096)
@@ -1 +0,0 @@
-div style=-webkit-transform-origin: 0 0; -webkit-transform: scale(8); font-family: STSong; font-weight: bold;|/div


Copied: trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed-expected.html (from rev 107095, trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html) (0 => 107096)

--- trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed-expected.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed-expected.html	2012-02-08 17:05:08 UTC (rev 107096)
@@ -0,0 +1,4 @@
+div style=position: relative;
+div style=-webkit-transform-origin: 0 0; -webkit-transform: scale(8); font-family: STSong;|/div
+div style=position: absolute; top: 0; -webkit-transform-origin: 0 0; -webkit-transform: translatex(1px) scale(8); font-family: STSong;|/div
+/div


Copied: trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed.html (from rev 107095, trunk/LayoutTests/fast/text/synthetic-bold-transformed.html) (0 => 107096)

--- trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/text/synthetic-bold-transformed.html	2012-02-08 17:05:08 UTC (rev 107096)
@@ -0,0 +1 @@
+div style=-webkit-transform-origin: 0 0; -webkit-transform: scale(8); font-family: STSong; font-weight: bold;|/div






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107097] trunk/Source/WebCore

[caryclark]

Title: [107097] trunk/Source/WebCore








Revision 107097
Author carycl...@google.com
Date 2012-02-08 09:15:42 -0800 (Wed, 08 Feb 2012)


Log Message
[Skia Mac] Make misspelling underline dots unclipped
https://bugs.webkit.org/show_bug.cgi?id=78117
http://code.google.com/p/chromium/issues/detail?id=113154

Reviewed by Stephen White.

No new tests. Existing layout tests cover this.

As is done on the CoreGraphics Mac platform, adjust the
underline width to remove partial dots, not including the
trailing transparent pixel column.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107096 => 107097)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 17:05:08 UTC (rev 107096)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 17:15:42 UTC (rev 107097)
@@ -1,3 +1,20 @@
+2012-02-08  Cary Clark  carycl...@google.com
+
+[Skia Mac] Make misspelling underline dots unclipped
+https://bugs.webkit.org/show_bug.cgi?id=78117
+http://code.google.com/p/chromium/issues/detail?id=113154
+
+Reviewed by Stephen White.
+
+No new tests. Existing layout tests cover this.
+
+As is done on the CoreGraphics Mac platform, adjust the
+underline width to remove partial dots, not including the
+trailing transparent pixel column.
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::GraphicsContext::drawLineForTextChecking):
+
 2012-02-08  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.


Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (107096 => 107097)

--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2012-02-08 17:05:08 UTC (rev 107096)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2012-02-08 17:15:42 UTC (rev 107097)
@@ -721,6 +721,11 @@
 SkScalar originX = WebCoreFloatToSkScalar(pt.x());
 #if PLATFORM(CHROMIUM)  OS(DARWIN)
 SkScalar originY = WebCoreFloatToSkScalar(pt.y());
+// Make sure to draw only complete dots.
+int rowPixels = misspellBitmap-width();
+float widthMod = fmodf(width, rowPixels);
+if (rowPixels - widthMod  1)
+width -= widthMod;
 #else
 // Offset it vertically by 1 so that there's some space under the text.
 SkScalar originY = WebCoreFloatToSkScalar(pt.y()) + 1;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107098] trunk/Tools

[commit-queue]

Title: [107098] trunk/Tools








Revision 107098
Author commit-qu...@webkit.org
Date 2012-02-08 09:31:44 -0800 (Wed, 08 Feb 2012)


Log Message
[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118

Patch by Gustavo Noronha Silva g...@gnome.org on 2012-02-08
Reviewed by Martin Robinson.

* gtk/common.py:
(get_build_path): also try the current directory as a valid build
dir, which makes non-standard build directories such as build-2.0
and build-3.0 work

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/common.py




Diff

Modified: trunk/Tools/ChangeLog (107097 => 107098)

--- trunk/Tools/ChangeLog	2012-02-08 17:15:42 UTC (rev 107097)
+++ trunk/Tools/ChangeLog	2012-02-08 17:31:44 UTC (rev 107098)
@@ -1,3 +1,15 @@
+2012-02-08  Gustavo Noronha Silva  g...@gnome.org
+
+[GTK] Fails to build docs with non-standard build directories
+https://bugs.webkit.org/show_bug.cgi?id=78118
+
+Reviewed by Martin Robinson.
+
+* gtk/common.py:
+(get_build_path): also try the current directory as a valid build
+dir, which makes non-standard build directories such as build-2.0
+and build-3.0 work
+
 2012-02-08  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Open links in a new window when clicking with the middle button in MiniBrowser


Modified: trunk/Tools/gtk/common.py (107097 => 107098)

--- trunk/Tools/gtk/common.py	2012-02-08 17:15:42 UTC (rev 107097)
+++ trunk/Tools/gtk/common.py	2012-02-08 17:31:44 UTC (rev 107098)
@@ -64,6 +64,10 @@
 if is_valid_build_directory(build_dir):
 return build_dir
 
+build_dir = os.getcwd()
+if is_valid_build_directory(build_dir):
+return build_dir
+
 print 'Could not determine build directory.'
 sys.exit(1)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107099] trunk

[hyatt]

Title: [107099] trunk








Revision 107099
Author hy...@apple.com
Date 2012-02-08 09:34:22 -0800 (Wed, 08 Feb 2012)


Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78122

Add support for the contains value for line-grid-snap. This value centers the line box in between the
text-top and text-bottom of the minimum number of grid lines that enclose the line box. This is useful for
centering headers in a line grid.

Reviewed by Adam Roben.

Added a new test in fast/line-grid.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineGridSnapAdjustment):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78122

Add a new test that shows the contains value in action.

Reviewed by Adam Roben.

* fast/line-grid/line-grid-contains-value.html: Added.
* platform/mac/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RootInlineBox.cpp


Added Paths

trunk/LayoutTests/fast/line-grid/line-grid-contains-value.html
trunk/LayoutTests/platform/mac/fast/line-grid/line-grid-contains-value-expected.png
trunk/LayoutTests/platform/mac/fast/line-grid/line-grid-contains-value-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107098 => 107099)

--- trunk/LayoutTests/ChangeLog	2012-02-08 17:31:44 UTC (rev 107098)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 17:34:22 UTC (rev 107099)
@@ -1,3 +1,15 @@
+2012-02-08  David Hyatt  hy...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=78122
+
+Add a new test that shows the contains value in action.
+
+Reviewed by Adam Roben.
+
+* fast/line-grid/line-grid-contains-value.html: Added.
+* platform/mac/fast/line-grid/line-grid-contains-value-expected.png: Added.
+* platform/mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
+
 2012-02-08  Dan Bernstein  m...@apple.com
 
 Moved a Mac-specific test to platform/mac.


Added: trunk/LayoutTests/fast/line-grid/line-grid-contains-value.html (0 => 107099)

--- trunk/LayoutTests/fast/line-grid/line-grid-contains-value.html	(rev 0)
+++ trunk/LayoutTests/fast/line-grid/line-grid-contains-value.html	2012-02-08 17:34:22 UTC (rev 107099)
@@ -0,0 +1,36 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+style
+.grid { -webkit-line-grid: simple; -webkit-line-grid-snap: baseline; 
+font-size:36px; position:absolute;
+padding:10px; }
+/style
+/head
+body
+div style=left:10px; top:10px; width:600px class=grid
+div style=-webkit-line-grid-snap:contain;font-size:48px
+This header should be centered in the grid lines.
+/div
+div style=font-size:12px
+This text should snapbr
+to a 36px font-size grid.br
+There should be lots of spacing between these lines.
+
+/div
+/div
+
+div style=left:10px; top:10px; z-index:-1; width:600px class=grid
+div style=font-family:'Ahem'; color:lime
+xbr
+xbr
+xbr
+xbr
+xbr
+xbr
+xbr
+/div
+/div
+
+/body
+/html


Added: trunk/LayoutTests/platform/mac/fast/line-grid/line-grid-contains-value-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/mac/fast/line-grid/line-grid-contains-value-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/mac/fast/line-grid/line-grid-contains-value-expected.txt (0 => 107099)

--- trunk/LayoutTests/platform/mac/fast/line-grid/line-grid-contains-value-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/line-grid/line-grid-contains-value-expected.txt	2012-02-08 17:34:22 UTC (rev 107099)
@@ -0,0 +1,45 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600 layerType: background only
+layer at (10,10) size 620x305
+  RenderBlock (positioned) zI: -1 {DIV} at (10,10) size 620x305
+RenderBlock {DIV} at (10,10) size 600x285 [color=#00FF00]
+  RenderText {#text} at (0,3) size 612x36
+text run at (0,3) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,44) size 612x36
+text run at (0,44) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,85) size 612x36
+text run at (0,85) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,126) size 612x36
+text run at (0,126) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,167) size 612x36
+text run at (0,167) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,208) size 612x36
+text run at (0,208) width 612: 

[webkit-changes] [107100] trunk

[antti]

Title: [107100] trunk








Revision 107100
Author an...@apple.com
Date 2012-02-08 09:35:44 -0800 (Wed, 08 Feb 2012)


Log Message
REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
https://bugs.webkit.org/show_bug.cgi?id=78080

Source/WebKit/mac: 

Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

* WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):

Tools: 

Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

Add API test.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebFrame.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/mac/TypingStyleCrash.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (107099 => 107100)

--- trunk/Source/WebKit/mac/ChangeLog	2012-02-08 17:34:22 UTC (rev 107099)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-02-08 17:35:44 UTC (rev 107100)
@@ -1,3 +1,13 @@
+2012-02-07  Antti Koivisto  an...@apple.com
+
+REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
+https://bugs.webkit.org/show_bug.cgi?id=78080
+
+Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
+
+* WebView/WebFrame.mm:
+(-[WebFrame _typingStyle]):
+
 2012-02-07  Tony Chang  t...@chromium.org
 
 merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in


Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (107099 => 107100)

--- trunk/Source/WebKit/mac/WebView/WebFrame.mm	2012-02-08 17:34:22 UTC (rev 107099)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm	2012-02-08 17:35:44 UTC (rev 107100)
@@ -791,10 +791,10 @@
 {
 if (!_private-coreFrame)
 return nil;
-RefPtrCSSStyleDeclaration typingStyle = _private-coreFrame-selection()-copyTypingStyle()-ensureCSSStyleDeclaration();
+RefPtrStylePropertySet typingStyle = _private-coreFrame-selection()-copyTypingStyle();
 if (!typingStyle)
 return nil;
-return kit(typingStyle.get());
+return kit(typingStyle-ensureCSSStyleDeclaration());
 }
 
 - (void)_setTypingStyle:(DOMCSSStyleDeclaration *)style withUndoAction:(EditAction)undoAction


Modified: trunk/Tools/ChangeLog (107099 => 107100)

--- trunk/Tools/ChangeLog	2012-02-08 17:34:22 UTC (rev 107099)
+++ trunk/Tools/ChangeLog	2012-02-08 17:35:44 UTC (rev 107100)
@@ -1,3 +1,17 @@
+2012-02-08  Antti Koivisto  an...@apple.com
+
+REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
+https://bugs.webkit.org/show_bug.cgi?id=78080
+
+Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
+
+Add API test.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
+(TestWebKitAPI):
+(TestWebKitAPI::TEST):
+
 2012-02-08  Gustavo Noronha Silva  g...@gnome.org
 
 [GTK] Fails to build docs with non-standard build directories


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (107099 => 107100)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2012-02-08 17:34:22 UTC (rev 107099)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2012-02-08 17:35:44 UTC (rev 107100)
@@ -117,6 +117,7 @@
 		C0C5D3BE14598B6F00A802A6 /* GetBackingScaleFactor.mm in Sources */ = {isa = PBXBuildFile; fileRef = C0C5D3BC14598B6F00A802A6 /* GetBackingScaleFactor.mm */; };
 		C0C5D3C61459912900A802A6 /* GetBackingScaleFactor_Bundle.mm in Sources */ = {isa = PBXBuildFile; fileRef = C0C5D3BD14598B6F00A802A6 /* GetBackingScaleFactor_Bundle.mm */; };
 		C507E8A714C6545B005D6B3B /* InspectorBar.mm in Sources */ = {isa = PBXBuildFile; fileRef = C507E8A614C6545B005D6B3B /* InspectorBar.mm */; };
+		E490296814E2E3A4002BEDD1 /* TypingStyleCrash.mm in Sources */ = {isa = PBXBuildFile; fileRef = E490296714E2E3A4002BEDD1 /* TypingStyleCrash.mm */; };
 		F3FC3EE313678B7300126A65 /* libgtest.a in Frameworks */ = {isa = PBXBuildFile; fileRef = F3FC3EE213678B7300126A65 /* libgtest.a */; };
 		F6F3F29113342FEB00A6BF19 /* CookieManager.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F6F3F29013342FEB00A6BF19 /* CookieManager.cpp */; };
 		F6F314241AD4004F1729 /* PrivateBrowsingPushStateNoHistoryCallback.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F6F214241AD4004F1729 /* PrivateBrowsingPushStateNoHistoryCallback.cpp */; };
@@ -296,6 +297,7 @@
 		C0C5D3BC14598B6F00A802A6 /* GetBackingScaleFactor.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = GetBackingScaleFactor.mm; sourceTree = group; };
 		C0C5D3BD14598B6F00A802A6 /* GetBackingScaleFactor_Bundle.mm */ = {isa = PBXFileReference; fileEncoding = 4; 

[webkit-changes] [107101] trunk/Source

[ossy]

Title: [107101] trunk/Source








Revision 107101
Author o...@webkit.org
Date 2012-02-08 09:56:22 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed, rolling out r106920, r106924, r106933, r106939,
and r107090.
http://trac.webkit.org/changeset/106920
http://trac.webkit.org/changeset/106924
http://trac.webkit.org/changeset/106933
http://trac.webkit.org/changeset/106939
http://trac.webkit.org/changeset/107090
https://bugs.webkit.org/show_bug.cgi?id=78124

Something is completely wrong this change (Requested by
Ossy_gardener on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-08

Source/WebCore:

* platform/FileSystem.h:
(WebCore):
* platform/qt/FileSystemQt.cpp:

Source/WebKit2:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FileSystem.h
trunk/Source/WebCore/platform/qt/FileSystemQt.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp
trunk/Source/WebKit2/WebProcess/qt/WebProcessQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107100 => 107101)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 17:35:44 UTC (rev 107100)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 17:56:22 UTC (rev 107101)
@@ -1,3 +1,21 @@
+2012-02-08  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r106920, r106924, r106933, r106939,
+and r107090.
+http://trac.webkit.org/changeset/106920
+http://trac.webkit.org/changeset/106924
+http://trac.webkit.org/changeset/106933
+http://trac.webkit.org/changeset/106939
+http://trac.webkit.org/changeset/107090
+https://bugs.webkit.org/show_bug.cgi?id=78124
+
+Something is completely wrong this change (Requested by
+Ossy_gardener on #webkit).
+
+* platform/FileSystem.h:
+(WebCore):
+* platform/qt/FileSystemQt.cpp:
+
 2012-02-08  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=78122


Modified: trunk/Source/WebCore/platform/FileSystem.h (107100 => 107101)

--- trunk/Source/WebCore/platform/FileSystem.h	2012-02-08 17:35:44 UTC (rev 107100)
+++ trunk/Source/WebCore/platform/FileSystem.h	2012-02-08 17:56:22 UTC (rev 107101)
@@ -198,8 +198,6 @@
 String filenameToString(const char*);
 String filenameForDisplay(const String);
 CString applicationDirectoryPath();
-#endif
-#if PLATFORM(GTK) || PLATFORM(QT)
 uint64_t getVolumeFreeSizeForPath(const char*);
 #endif
 


Modified: trunk/Source/WebCore/platform/qt/FileSystemQt.cpp (107100 => 107101)

--- trunk/Source/WebCore/platform/qt/FileSystemQt.cpp	2012-02-08 17:35:44 UTC (rev 107100)
+++ trunk/Source/WebCore/platform/qt/FileSystemQt.cpp	2012-02-08 17:56:22 UTC (rev 107101)
@@ -39,9 +39,6 @@
 #include QFile
 #include QFileInfo
 #include QTemporaryFile
-#if !defined(Q_OS_WIN)
-#include sys/statvfs.h
-#endif
 #include wtf/text/CString.h
 
 namespace WebCore {
@@ -193,23 +190,6 @@
 return -1;
 }
 
-uint64_t getVolumeFreeSizeForPath(const char* path)
-{
-#if defined(Q_OS_WIN)
-ULARGE_INTEGER freeBytesToCaller;
-BOOL result = GetDiskFreeSpaceExW((LPCWSTR)path, freeBytesToCaller, 0, 0);
-if (!result)
-return 0;
-return static_castuint64_t(freeBytesToCaller.QuadPart);
-#else
-struct statvfs volumeInfo;
-if (statvfs(path, volumeInfo))
-return 0;
-
-return static_castuint64_t(volumeInfo.f_bavail) * static_castuint64_t(volumeInfo.f_frsize);
-#endif
-}
-
 int writeToFile(PlatformFileHandle handle, const char* data, int length)
 {
 if (handle  handle-exists()  handle-isWritable())


Modified: trunk/Source/WebKit2/ChangeLog (107100 => 107101)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 17:35:44 UTC (rev 107100)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 17:56:22 UTC (rev 107101)
@@ -1,3 +1,31 @@
+2012-02-08  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r106920, r106924, r106933, r106939,
+and r107090.
+http://trac.webkit.org/changeset/106920
+http://trac.webkit.org/changeset/106924
+http://trac.webkit.org/changeset/106933
+http://trac.webkit.org/changeset/106939
+http://trac.webkit.org/changeset/107090
+https://bugs.webkit.org/show_bug.cgi?id=78124
+
+Something is completely wrong this change (Requested by
+

[webkit-changes] [107102] trunk/Source/WebCore

[andersca]

Title: [107102] trunk/Source/WebCore








Revision 107102
Author ander...@apple.com
Date 2012-02-08 10:00:00 -0800 (Wed, 08 Feb 2012)


Log Message
Fix assertion in svg/dom/SVGStyledElement-pendingResource-crash.html
https://bugs.webkit.org/show_bug.cgi?id=78126

Reviewed by Dan Bernstein.

This broke in r106977 when I tried to change an early return into an ASSERT,
so let's bring back the early return.

* page/FrameView.cpp:
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107101 => 107102)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 17:56:22 UTC (rev 107101)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 18:00:00 UTC (rev 107102)
@@ -1,3 +1,16 @@
+2012-02-08  Anders Carlsson  ander...@apple.com
+
+Fix assertion in svg/dom/SVGStyledElement-pendingResource-crash.html
+https://bugs.webkit.org/show_bug.cgi?id=78126
+
+Reviewed by Dan Bernstein.
+
+This broke in r106977 when I tried to change an early return into an ASSERT,
+so let's bring back the early return.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
+
 2012-02-08  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r106920, r106924, r106933, r106939,


Modified: trunk/Source/WebCore/page/FrameView.cpp (107101 => 107102)

--- trunk/Source/WebCore/page/FrameView.cpp	2012-02-08 17:56:22 UTC (rev 107101)
+++ trunk/Source/WebCore/page/FrameView.cpp	2012-02-08 18:00:00 UTC (rev 107102)
@@ -2606,7 +2606,9 @@
 for (HashSetScrollableArea*::const_iterator it = m_scrollableAreas-begin(), end = m_scrollableAreas-end(); it != end; ++it) {
 ScrollableArea* scrollableArea = *it;
 
-ASSERT(scrollableArea-isOnActivePage());
+if (!scrollableArea-isOnActivePage())
+continue;
+
 scrollableArea-contentAreaWillPaint();
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107103] trunk/LayoutTests

[jchaffraix]

Title: [107103] trunk/LayoutTests








Revision 107103
Author jchaffr...@webkit.org
Date 2012-02-08 10:27:10 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed morning gardening.

* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Added.
Rebaselined this file (font difference).

* platform/chromium/test_expectations.txt: Marked one test as SLOW on Window.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107102 => 107103)

--- trunk/LayoutTests/ChangeLog	2012-02-08 18:00:00 UTC (rev 107102)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 18:27:10 UTC (rev 107103)
@@ -1,3 +1,13 @@
+2012-02-08  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed morning gardening.
+
+* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png: Added.
+* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Added.
+Rebaselined this file (font difference).
+
+* platform/chromium/test_expectations.txt: Marked one test as SLOW on Window.
+
 2012-02-08  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=78122


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107102 => 107103)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 18:00:00 UTC (rev 107102)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 18:27:10 UTC (rev 107103)
@@ -53,6 +53,8 @@
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-ondownloading-resource-404.html = FAIL
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-onprogress.html = FAIL
 
+BUGWK77523 WIN RELEASE SLOW : media/media-fragments/TC0080-TC0089.html = PASS
+
 // -
 // TEMPORARILY SKIPPED TESTS
 // -


Added: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt (0 => 107103)

--- trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt	2012-02-08 18:27:10 UTC (rev 107103)
@@ -0,0 +1,45 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600 layerType: background only
+layer at (10,10) size 620x318
+  RenderBlock (positioned) zI: -1 {DIV} at (10,10) size 620x318
+RenderBlock {DIV} at (10,10) size 600x298 [color=#00FF00]
+  RenderText {#text} at (0,4) size 612x36
+text run at (0,4) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,47) size 612x36
+text run at (0,47) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,90) size 612x36
+text run at (0,90) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,133) size 612x36
+text run at (0,133) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,176) size 612x36
+text run at (0,176) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,219) size 612x36
+text run at (0,219) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+  RenderText {#text} at (0,262) size 612x36
+text run at (0,262) width 612: x
+  RenderBR {BR} at (0,0) size 0x0
+layer at (0,0) size 800x600 layerType: foreground only
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+layer at (10,10) size 620x315
+  RenderBlock (positioned) {DIV} at (10,10) size 620x315
+RenderBlock {DIV} at (10,10) size 600x157
+  RenderText {#text} at (0,15) size 587x141
+text run at (0,15) width 587: This header should be centered
+text run at (0,101) width 303: in the grid lines.
+RenderBlock {DIV} at (10,167) size 600x138
+  RenderText {#text} at (0,36) size 104x15
+text run at (0,36) width 104: This text should snap
+  RenderBR {BR} at (104,48) size 0x0
+  RenderText {#text} at (0,79) size 115x15
+

[webkit-changes] [107104] trunk/LayoutTests

[ossy]

Title: [107104] trunk/LayoutTests








Revision 107104
Author o...@webkit.org
Date 2012-02-08 10:29:48 -0800 (Wed, 08 Feb 2012)


Log Message
[Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=78128

* platform/qt/Skipped: Skip it until fix.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (107103 => 107104)

--- trunk/LayoutTests/ChangeLog	2012-02-08 18:27:10 UTC (rev 107103)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 18:29:48 UTC (rev 107104)
@@ -1,3 +1,10 @@
+2012-02-08  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
+https://bugs.webkit.org/show_bug.cgi?id=78128
+
+* platform/qt/Skipped: Skip it until fix.
+
 2012-02-08  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed morning gardening.


Modified: trunk/LayoutTests/platform/qt/Skipped (107103 => 107104)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-08 18:27:10 UTC (rev 107103)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-08 18:29:48 UTC (rev 107104)
@@ -1383,6 +1383,10 @@
 svg/hittest/zero-length-round-cap-path.xhtml
 svg/hittest/zero-length-square-cap-path.xhtml
 
+# [Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
+# https://bugs.webkit.org/show_bug.cgi?id=78128
+svg/zoom/page/zoom-coords-viewattr-01-b.svg
+
 # = #
 # Failing CSS Tests
 # = #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107105] trunk

[commit-queue]

Title: [107105] trunk








Revision 107105
Author commit-qu...@webkit.org
Date 2012-02-08 10:35:50 -0800 (Wed, 08 Feb 2012)


Log Message
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Patch by Rob Buis rb...@rim.com on 2012-02-08
Reviewed by Antonio Gomes.

Source/WebKit:

Add abstract interface for our DumpRenderTree solution.

* blackberry/Api/DumpRenderTreeClient.h: Added.

Tools:

Add implementation for our DumpRenderTree solution.

* DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Tools/ChangeLog


Added Paths

trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h
trunk/Tools/DumpRenderTree/blackberry/
trunk/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (107104 => 107105)

--- trunk/Source/WebKit/ChangeLog	2012-02-08 18:29:48 UTC (rev 107104)
+++ trunk/Source/WebKit/ChangeLog	2012-02-08 18:35:50 UTC (rev 107105)
@@ -1,3 +1,14 @@
+2012-02-08  Rob Buis  rb...@rim.com
+
+[BlackBerry] Upstream DumpRenderTreeBlackBerry
+https://bugs.webkit.org/show_bug.cgi?id=78042
+
+Reviewed by Antonio Gomes.
+
+Add abstract interface for our DumpRenderTree solution.
+
+* blackberry/Api/DumpRenderTreeClient.h: Added.
+
 2012-02-08  Nima Ghanavatian  nghanavat...@rim.com
 
 Initial upstreaming of input handling for BlackBerry port


Added: trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h (0 => 107105)

--- trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h	(rev 0)
+++ trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h	2012-02-08 18:35:50 UTC (rev 107105)
@@ -0,0 +1,89 @@
+/*
+ * Copyright (C) 2009, 2010, 2011 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#ifndef DumpRenderTreeClient_h
+#define DumpRenderTreeClient_h
+
+#include BlackBerryGlobal.h
+
+#include PlatformString.h
+#include _javascript_Core/JSObjectRef.h
+
+namespace WebCore {
+class Frame;
+class DOMWrapperWorld;
+class NavigationAction;
+class Node;
+class Range;
+class ResourceRequest;
+class ResourceResponse;
+class SecurityOrigin;
+}
+
+namespace BlackBerry {
+namespace WebKit {
+class WebPage;
+
+class BLACKBERRY_EXPORT DumpRenderTreeClient {
+public:
+virtual void runTests() = 0;
+
+// FrameLoaderClient delegates
+virtual void didStartProvisionalLoadForFrame(WebCore::Frame*) = 0;
+virtual void didReceiveResponseForFrame(WebCore::Frame*, const WebCore::ResourceResponse) = 0;
+virtual void didCommitLoadForFrame(WebCore::Frame*) = 0;
+virtual void didFailProvisionalLoadForFrame(WebCore::Frame*) = 0;
+virtual void didFailLoadForFrame(WebCore::Frame*) = 0;
+virtual void didFinishLoadForFrame(WebCore::Frame*) = 0;
+virtual void didFinishDocumentLoadForFrame(WebCore::Frame*) = 0;
+virtual void didClearWindowObjectInWorld(WebCore::DOMWrapperWorld*, JSGlobalContextRef, JSObjectRef windowObject) = 0;
+virtual void didReceiveTitleForFrame(const WTF::String title, WebCore::Frame*) = 0;
+virtual void didDecidePolicyForNavigationAction(const WebCore::NavigationAction, const WebCore::ResourceRequest) = 0;
+virtual void didDispatchWillPerformClientRedirect() = 0;
+virtual void didHandleOnloadEventsForFrame(WebCore::Frame*) = 0;
+
+// ChromeClient delegates
+virtual void addMessageToConsole(const WTF::String message, unsigned int lineNumber, const WTF::String sourceID) = 0;
+virtual void runJavaScriptAlert(const WTF::String message) = 0;
+virtual bool runJavaScriptConfirm(const WTF::String message) = 0;
+virtual WTF::String runJavaScriptPrompt(const WTF::String message, const WTF::String defaultValue) = 0;
+virtual bool runBeforeUnloadConfirmPanel(const WTF::String message) = 0;
+virtual void setStatusText(const WTF::String) = 0;
+virtual void exceededDatabaseQuota(WebCore::SecurityOrigin*, const WTF::String name) = 0;
+virtual bool allowsOpeningWindow() = 0;
+virtual void windowCreated(WebPage*) = 0;
+
+// EditorClient delegates
+

[webkit-changes] [107106] trunk/Source/WebCore

[loislo]

Title: [107106] trunk/Source/WebCore








Revision 107106
Author loi...@chromium.org
Date 2012-02-08 10:49:55 -0800 (Wed, 08 Feb 2012)


Log Message
Web Inspector: heap snapshot: implement Distance column in Object's retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=78113

Retaining path list was replaced with Retaining tree some time ago.
But it was not so useful when we want to track the retaining path from an object to a DOM Window node.

Drive by fix: sort doesn't work in retaining tree panel.
Drive by fix: save/load child nodes doesn't work for the retaining tree panel.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotRetainerEdge.prototype.set retainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.set edgeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _node):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _edge):
(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeFieldName):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndEdge):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid td.distanceToWindow-column):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js
trunk/Source/WebCore/inspector/front-end/heapProfiler.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (107105 => 107106)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 18:35:50 UTC (rev 107105)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 18:49:55 UTC (rev 107106)
@@ -1,3 +1,47 @@
+2012-02-08  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: heap snapshot: implement Distance column in Object's retaining tree.
+https://bugs.webkit.org/show_bug.cgi?id=78113
+
+Retaining path list was replaced with Retaining tree some time ago.
+But it was not so useful when we want to track the retaining path from an object to a DOM Window node.
+
+Drive by fix: sort doesn't work in retaining tree panel.
+Drive by fix: save/load child nodes doesn't work for the retaining tree panel.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DetailedHeapshotGridNodes.js:
+(WebInspector.HeapSnapshotObjectNode):
+(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity): save/load children fix
+(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode): save/load children fix
+(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
+(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
+* inspector/front-end/DetailedHeapshotView.js:
+(WebInspector.HeapSnapshotContainmentDataGrid):
+(WebInspector.HeapSnapshotRetainmentDataGrid):
+(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshotRetainerEdge.prototype.set retainerIndex):
+(WebInspector.HeapSnapshotRetainerEdge.prototype.set edgeIndex):
+(WebInspector.HeapSnapshotRetainerEdge.prototype.get _node):
+(WebInspector.HeapSnapshotRetainerEdge.prototype.get _edge):
+(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
+(WebInspector.HeapSnapshot.prototype._init):
+(WebInspector.HeapSnapshot.prototype._buildRetainers):
+(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
+(WebInspector.HeapSnapshot.prototype._bfs):
+

[webkit-changes] [107109] trunk/LayoutTests

[jchaffraix]

Title: [107109] trunk/LayoutTests








Revision 107109
Author jchaffr...@webkit.org
Date 2012-02-08 11:26:29 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt: Added.
More rebaseline of those (I pulled the trigger too early).

* platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png:
* platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png:
* platform/chromium/rubberbanding/custom-scrollbars-se-expected.png:
* platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png:
Update the expected files. I don't know how we ended up with a blue color when the html specifies
an orange.

* platform/chromium/test_expectations.txt:
Mark a test as timing out as it has been raising an exception on the bots fairly regularly.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png
trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/fast/line-grid/line-grid-contains-value-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png
trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png
trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107108 => 107109)

--- trunk/LayoutTests/ChangeLog	2012-02-08 19:19:03 UTC (rev 107108)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 19:26:29 UTC (rev 107109)
@@ -1,3 +1,24 @@
+2012-02-08  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
+* platform/chromium-mac-leopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
+* platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png: Added.
+* platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt: Added.
+More rebaseline of those (I pulled the trigger too early).
+
+* platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png:
+* platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png:
+* platform/chromium/rubberbanding/custom-scrollbars-se-expected.png:
+* platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png:
+Update the expected files. I don't know how we ended up with a blue color when the html specifies
+an orange.
+
+* platform/chromium/test_expectations.txt:
+Mark a test as timing out as it has been raising an exception on the bots fairly regularly.
+
 2012-02-08  Dirk Schulze  k...@webkit.org
 
 viewBox on nested SVG causes wrong content size for relative values


Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107108 => 107109)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 19:19:03 UTC (rev 107108)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 19:26:29 UTC (rev 107109)
@@ -3995,7 +3995,6 @@
 BUGWK77736 : svg/as-object/embedded-svg-size-changes.html = IMAGE
 BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html = IMAGE+TEXT
 BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html = IMAGE+TEXT
-BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
 BUGWK77736 : svg/carto.net/tabgroup.svg = IMAGE+TEXT
 BUGWK77736 MAC LINUX : svg/carto.net/window.svg = IMAGE+TEXT
 

[webkit-changes] [107108] trunk

[krit]

Title: [107108] trunk








Revision 107108
Author k...@webkit.org
Date 2012-02-08 11:19:03 -0800 (Wed, 08 Feb 2012)


Log Message
viewBox on nested SVG causes wrong content size for relative values
https://bugs.webkit.org/show_bug.cgi?id=69459

Reviewed by Nikolas.

Source/WebCore: 

In the past we just checked the change of the viewport size of the root SVG element. If the size changed, all childs
with relative length values needed a relayout. We did not consider that we might have other viewports in the document.
Childs with relative lengths had a strange zooming, if just the viewport size of an inner SVG element changed.

With this patch we check if the size of the nearest viewport changes. Is this the case, childs with relative lengths
need a relayout.

Test: inner-svg-change-viewBox.svg

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
* rendering/svg/RenderSVGContainer.h:
(RenderSVGContainer):
(WebCore::RenderSVGContainer::determineIfLayoutSizeChanged): Check if we need layout and have relative length values.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout): Remove resetting 'viewport size changed' flag for code operability. No influence on the layout.
* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): Add a flag that indicates that the viewport size changes.
(WebCore::RenderSVGViewportContainer::determineIfLayoutSizeChanged): The flag gets set during the layout phase of the SVG element if the size changes.
(WebCore):
* rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::isLayoutSizeChanged): Added getter to get flag status.
(RenderSVGViewportContainer):
(WebCore::toRenderSVGViewportContainer): Added casting function for constant RenderObjects.
(WebCore):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::layoutSizeOfNearestViewportChanged): Search the nearest viewport and check if the size changed.
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren): Don't check the roots viewport for size changes, but the nearest viewport.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged): Added viewBoxAttr to the list of attributes that cause relayout.

LayoutTests: 

Test relayout of content of inner SVG on change of relative length values.

* svg/repaint/inner-svg-change-viewBox-expected.png: Added.
* svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
* svg/repaint/inner-svg-change-viewBox.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h
trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp
trunk/Source/WebCore/svg/SVGSVGElement.cpp


Added Paths

trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox-expected.png
trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox-expected.txt
trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (107107 => 107108)

--- trunk/LayoutTests/ChangeLog	2012-02-08 19:13:56 UTC (rev 107107)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 19:19:03 UTC (rev 107108)
@@ -1,3 +1,16 @@
+2012-02-08  Dirk Schulze  k...@webkit.org
+
+viewBox on nested SVG causes wrong content size for relative values
+https://bugs.webkit.org/show_bug.cgi?id=69459
+
+Reviewed by Nikolas.
+
+Test relayout of content of inner SVG on change of relative length values.
+
+* svg/repaint/inner-svg-change-viewBox-expected.png: Added.
+* svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
+* svg/repaint/inner-svg-change-viewBox.svg: Added.
+
 2012-02-08  Gregg Tavares  g...@chromium.org
 
 Implement new WEBGL compressed texture extensions


Added: trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox-expected.txt (0 => 107108)

--- trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/repaint/inner-svg-change-viewBox-expected.txt	2012-02-08 19:19:03 UTC (rev 107108)
@@ -0,0 +1,6 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 200x200
+  RenderSVGRoot {svg} at (0,0) size 100x100
+RenderSVGViewportContainer {svg} at (0,0) size 100x100
+  RenderSVGRect {rect} at (0,0) size 100x100 [fill={[type=SOLID] [color=#008000]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]


Added: 

[webkit-changes] [107110] trunk/Source/Platform

[jamesr]

Title: [107110] trunk/Source/Platform








Revision 107110
Author jam...@google.com
Date 2012-02-08 11:29:59 -0800 (Wed, 08 Feb 2012)


Log Message
r107042 caused compile breakages on chromium try bots
https://bugs.webkit.org/show_bug.cgi?id=78125

Reviewed by Adam Barth.

Replace the copy script with a copies GYP action since the MSVS generator tracks dependencies on a per-file
basis.

* Platform.gyp/Platform.gyp:
* Platform.gyp/copy_webcore_headers.py: Removed.

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gyp/Platform.gyp


Removed Paths

trunk/Source/Platform/Platform.gyp/copy_webcore_headers.py




Diff

Modified: trunk/Source/Platform/ChangeLog (107109 => 107110)

--- trunk/Source/Platform/ChangeLog	2012-02-08 19:26:29 UTC (rev 107109)
+++ trunk/Source/Platform/ChangeLog	2012-02-08 19:29:59 UTC (rev 107110)
@@ -1,3 +1,16 @@
+2012-02-08  James Robinson  jam...@chromium.org
+
+r107042 caused compile breakages on chromium try bots
+https://bugs.webkit.org/show_bug.cgi?id=78125
+
+Reviewed by Adam Barth.
+
+Replace the copy script with a copies GYP action since the MSVS generator tracks dependencies on a per-file
+basis.
+
+* Platform.gyp/Platform.gyp:
+* Platform.gyp/copy_webcore_headers.py: Removed.
+
 2012-02-07  James Robinson  jam...@chromium.org
 
 [chromium] Move geometry headers in Platform API to Platform directory


Modified: trunk/Source/Platform/Platform.gyp/Platform.gyp (107109 => 107110)

--- trunk/Source/Platform/Platform.gyp/Platform.gyp	2012-02-08 19:26:29 UTC (rev 107109)
+++ trunk/Source/Platform/Platform.gyp/Platform.gyp	2012-02-08 19:29:59 UTC (rev 107110)
@@ -86,22 +86,12 @@
 ],
 }],
 ],
-'actions': [
+'copies': [
 {
-'action_name': 'platform_api_copy_webcore_headers',
-'inputs': [
+'destination': '(output_dir)',
+'files': [
 '@(webcore_headers)'
-],
-'outputs': [
-'(output_dir)/IntPoint.h' # Just have to depend on any one copied header
-],
-'action': [
-'python',
-'copy_webcore_headers.py',
-'(SHARED_INTERMEDIATE_DIR)/webcore_headers',
-'@(webcore_headers)'
-],
-'message': 'Copying WebCore headers needed by Platform API'
+]
 }
 ]
 }


Deleted: trunk/Source/Platform/Platform.gyp/copy_webcore_headers.py (107109 => 107110)

--- trunk/Source/Platform/Platform.gyp/copy_webcore_headers.py	2012-02-08 19:26:29 UTC (rev 107109)
+++ trunk/Source/Platform/Platform.gyp/copy_webcore_headers.py	2012-02-08 19:29:59 UTC (rev 107110)
@@ -1,49 +0,0 @@
-#!/usr/bin/env python
-# Copyright (c) 2012 Google Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1.  Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# 2.  Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
-# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
-# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-A helper script for copying WebCore/platform headers into a location the WebKit Platform API headers can include
-
-import errno
-import os
-import shutil
-import sys
-
-
-def CopyHeaders(dest_dir, headers):
-try:
-os.makedirs(dest_dir)
-except OSError, e:
-if e.errno != errno.EEXIST:
-raise
-for header in headers:
-dest_filename = dest_dir + os.sep + header.split('/')[-1]
-shutil.copyfile(header, dest_filename)
-
-
-def Main(argv):
-dest_dir = argv[1]
-headers = argv[2:]
-CopyHeaders(dest_dir, headers)
-
-if __name__ == '__main__':
-

[webkit-changes] [107113] trunk/Tools

[commit-queue]

Title: [107113] trunk/Tools








Revision 107113
Author commit-qu...@webkit.org
Date 2012-02-08 11:59:33 -0800 (Wed, 08 Feb 2012)


Log Message
nrwt: make --skip-pixel-test-if-no-baseline option
https://bugs.webkit.org/show_bug.cgi?id=70484

Patch by Fehér Zsolt fehe...@inf.u-szeged.hu on 2012-02-08
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__):
(SingleTestRunner._should_fetch_expected_checksum):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.__init__):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.cmd_line):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_pixel_test_if_no_baseline_option):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
(TestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
* WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::setSkipPixelTestOption):
(TestInvocation):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_input.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
trunk/Tools/WebKitTestRunner/TestInvocation.h




Diff

Modified: trunk/Tools/ChangeLog (107112 => 107113)

--- trunk/Tools/ChangeLog	2012-02-08 19:58:35 UTC (rev 107112)
+++ trunk/Tools/ChangeLog	2012-02-08 19:59:33 UTC (rev 107113)
@@ -1,3 +1,37 @@
+2012-02-08  Fehér Zsolt  fehe...@inf.u-szeged.hu
+
+nrwt: make --skip-pixel-test-if-no-baseline option
+https://bugs.webkit.org/show_bug.cgi?id=70484
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+(SingleTestRunner.__init__):
+(SingleTestRunner._should_fetch_expected_checksum):
+* Scripts/webkitpy/layout_tests/controllers/worker.py:
+(Worker.handle_test_list):
+* Scripts/webkitpy/layout_tests/models/test_input.py:
+(TestInput.__init__):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.cmd_line):
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(_set_up_derived_options):
+(parse_args):
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+(MainTest.test_skip_pixel_test_if_no_baseline_option):
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::TestController):
+(WTR::TestController::initialize):
+(WTR::TestController::runTest):
+* WebKitTestRunner/TestController.h:
+(TestController):
+* WebKitTestRunner/TestInvocation.cpp:
+(WTR::TestInvocation::TestInvocation):
+(WTR::TestInvocation::setIsPixelTest):
+* WebKitTestRunner/TestInvocation.h:
+(WTR::TestInvocation::setSkipPixelTestOption):
+(TestInvocation):
+
 2012-02-08  Rob Buis  rb...@rim.com
 
 [BlackBerry] Upstream DumpRenderTreeBlackBerry


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (107112 => 107113)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-02-08 19:58:35 UTC (rev 107112)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2012-02-08 19:59:33 UTC (rev 107113)
@@ -55,6 +55,7 @@
 self._timeout = test_input.timeout
 self._worker_name = worker_name
 self._test_name = test_input.test_name
+self._should_run_pixel_test = test_input.should_run_pixel_test
 
 self._is_reftest = False
 self._reference_files = port.reference_files(self._test_name)
@@ -77,6 +78,8 @@
  self._port.expected_audio(self._test_name))
 
 def _should_fetch_expected_checksum(self):
+if not self._should_run_pixel_test:
+return False
 return (self._options.pixel_tests and
 not (self._options.new_baseline or self._options.reset_results))
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py (107112 => 107113)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py	2012-02-08 19:58:35 UTC (rev 107112)
+++ 

[webkit-changes] [107111] trunk/Source/WebKit/chromium

[commit-queue]

Title: [107111] trunk/Source/WebKit/chromium








Revision 107111
Author commit-qu...@webkit.org
Date 2012-02-08 11:44:55 -0800 (Wed, 08 Feb 2012)


Log Message
[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
https://bugs.webkit.org/show_bug.cgi?id=78130

Patch by Nico Weber nicolaswe...@gmx.de on 2012-02-08
Reviewed by Tony Chang.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (107110 => 107111)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 19:29:59 UTC (rev 107110)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 19:44:55 UTC (rev 107111)
@@ -1,3 +1,12 @@
+2012-02-08  Nico Weber  nicolaswe...@gmx.de
+
+[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
+https://bugs.webkit.org/show_bug.cgi?id=78130
+
+Reviewed by Tony Chang.
+
+* WebKit.gyp:
+
 2012-02-08  Alexei Svitkine  asvitk...@chromium.org
 
 Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (107110 => 107111)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-02-08 19:29:59 UTC (rev 107110)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-02-08 19:44:55 UTC (rev 107111)
@@ -762,6 +762,9 @@
 # and we pull in the test files into the webkit target in the
 # shared build.
 'cflags!': ['-Wglobal-constructors'],
+'xcode_settings': {
+  'WARNING_CFLAGS!': ['-Wglobal-constructors'],
+},
 }],
 ],
 'msvs_settings': {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107115] trunk/Source/WebKit/chromium

[commit-queue]

Title: [107115] trunk/Source/WebKit/chromium








Revision 107115
Author commit-qu...@webkit.org
Date 2012-02-08 12:16:21 -0800 (Wed, 08 Feb 2012)


Log Message
[Chromium] Don't add selection from password fields to context menu.
https://bugs.webkit.org/show_bug.cgi?id=77733

Patch by Bernhard Bauer bau...@google.com on 2012-02-08
Reviewed by Adam Barth.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (107114 => 107115)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 20:11:28 UTC (rev 107114)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 20:16:21 UTC (rev 107115)
@@ -1,3 +1,13 @@
+2012-02-08  Bernhard Bauer  bau...@google.com
+
+[Chromium] Don't add selection from password fields to context menu.
+https://bugs.webkit.org/show_bug.cgi?id=77733
+
+Reviewed by Adam Barth.
+
+* src/ContextMenuClientImpl.cpp:
+(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+
 2012-02-08  Nico Weber  nicolaswe...@gmx.de
 
 [chromium] Let -Wglobal-constructors hack in shared build metastasize to mac


Modified: trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp (107114 => 107115)

--- trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp	2012-02-08 20:11:28 UTC (rev 107114)
+++ trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp	2012-02-08 20:16:21 UTC (rev 107115)
@@ -259,8 +259,10 @@
 data.frameHistoryItem = WebHistoryItem(historyItem);
 }
 
-if (r.isSelected())
-data.selectedText = selectedFrame-editor()-selectedText().stripWhiteSpace();
+if (r.isSelected()) {
+if (!r.innerNonSharedNode()-hasTagName(HTMLNames::inputTag) || !static_castHTMLInputElement*(r.innerNonSharedNode())-isPasswordField())
+data.selectedText = selectedFrame-editor()-selectedText().stripWhiteSpace();
+}
 
 if (r.isContentEditable()) {
 data.isEditable = true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107116] branches/chromium/1025

[kbr]

Title: [107116] branches/chromium/1025








Revision 107116
Author k...@google.com
Date 2012-02-08 12:17:20 -0800 (Wed, 08 Feb 2012)


Log Message
Merge 106888 - WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu yongsheng@intel.com on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

TBR=commit-qu...@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9359020

Modified Paths

branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt
branches/chromium/1025/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp




Diff

Modified: branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt (107115 => 107116)

--- branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 20:16:21 UTC (rev 107115)
+++ branches/chromium/1025/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 20:17:20 UTC (rev 107116)
@@ -3827,8 +3827,6 @@
 
 BUGWK76580 : media/media-document-audio-repaint.html = IMAGE PASS
 
-BUGWK76562 : fast/canvas/webgl/drawingbuffer-test.html = TEXT
-
 // This test is passing, but it doesn't seem possible to add GPU+Leopard specific baselines.
 BUGJAMESR LEOPARD GPU : fast/canvas/quadraticCurveTo.xml = IMAGE
 


Modified: branches/chromium/1025/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp (107115 => 107116)

--- branches/chromium/1025/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp	2012-02-08 20:16:21 UTC (rev 107115)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp	2012-02-08 20:17:20 UTC (rev 107116)
@@ -49,6 +49,7 @@
 static int s_maximumResourceUsePixels = 0;
 #endif
 static int s_currentResourceUsePixels = 0;
+static const float s_resourceAdjustedRatio = 0.5;
 
 PassRefPtrDrawingBuffer DrawingBuffer::create(GraphicsContext3D* context, const IntSize size, bool separateBackingTexture)
 {
@@ -236,19 +237,28 @@
 }
 
 int pixelDelta = newSize.width() * newSize.height();
-if (!m_size.isEmpty())
-pixelDelta -= m_size.width() * m_size.height();
-
-if (s_maximumResourceUsePixels  (s_currentResourceUsePixels + pixelDelta)  s_maximumResourceUsePixels) {
-clear();
-return false;
+int oldSize = 0;
+if (!m_size.isEmpty()) {
+oldSize = m_size.width() * m_size.height();
+pixelDelta -= oldSize;
 }
-s_currentResourceUsePixels += pixelDelta;
 
+IntSize adjustedSize = newSize;
+if (s_maximumResourceUsePixels) {
+while ((s_currentResourceUsePixels + pixelDelta)  s_maximumResourceUsePixels) {
+adjustedSize.scale(s_resourceAdjustedRatio);
+if (adjustedSize.isEmpty()) {
+clear();
+return false;
+}
+pixelDelta = adjustedSize.width() * adjustedSize.height();
+pixelDelta -= oldSize;
+}
+ }
+
 const GraphicsContext3D::Attributes attributes = m_context-getContextAttributes();
 
-if (newSize != m_size) {
-m_size = newSize;
+if (adjustedSize != m_size) {
 
 unsigned internalColorFormat, colorFormat, internalRenderbufferFormat;
 if (attributes.alpha) {
@@ -262,46 +272,56 @@
 }
 
 
-// resize multisample FBO
-if (multisample()) {
-int maxSampleCount = 0;
-
-m_context-getIntegerv(Extensions3D::MAX_SAMPLES, maxSampleCount);
-int sampleCount = std::min(4, maxSampleCount);
+do {
+m_size = adjustedSize;
+// resize multisample FBO
+if (multisample()) {
+int maxSampleCount = 0;
 
-m_context-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_multisampleFBO);
+m_context-getIntegerv(Extensions3D::MAX_SAMPLES, maxSampleCount);
+int sampleCount = std::min(4, maxSampleCount);
 
-m_context-bindRenderbuffer(GraphicsContext3D::RENDERBUFFER, m_multisampleColorBuffer);
-m_context-getExtensions()-renderbufferStorageMultisample(GraphicsContext3D::RENDERBUFFER, sampleCount, internalRenderbufferFormat, m_size.width(), m_size.height());
-m_context-framebufferRenderbuffer(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::COLOR_ATTACHMENT0, GraphicsContext3D::RENDERBUFFER, m_multisampleColorBuffer);
-resizeDepthStencil(sampleCount);
-if (m_context-checkFramebufferStatus(GraphicsContext3D::FRAMEBUFFER) != GraphicsContext3D::FRAMEBUFFER_COMPLETE) {
-// Cleanup
-clear();
-return false;
+m_context-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_multisampleFBO);
+
+m_context-bindRenderbuffer(GraphicsContext3D::RENDERBUFFER, 

[webkit-changes] [107112] trunk

[ojan]

Title: [107112] trunk








Revision 107112
Author o...@chromium.org
Date 2012-02-08 11:58:35 -0800 (Wed, 08 Feb 2012)


Log Message
Floated flexboxes render as regular RenderBlocks
https://bugs.webkit.org/show_bug.cgi?id=77909

Reviewed by Eric Seidel.

Source/WebCore:

Add grid/flexbox cases to adjusting the display of floated/positioned
elements. Also, move this logic into a switch statement. This makes
the code more readable and gives compile warnings when new display types
are added that aren't handled here.

Test: css3/flexbox/floated-flexbox.html

* css/CSSStyleSelector.cpp:
(WebCore::adjustDisplay):
(WebCore):
(WebCore::CSSStyleSelector::adjustRenderStyle):

LayoutTests:

* css3/flexbox/floated-flexbox-expected.txt: Added.
* css3/flexbox/floated-flexbox.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp


Added Paths

trunk/LayoutTests/css3/flexbox/floated-flexbox-expected.txt
trunk/LayoutTests/css3/flexbox/floated-flexbox.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107111 => 107112)

--- trunk/LayoutTests/ChangeLog	2012-02-08 19:44:55 UTC (rev 107111)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 19:58:35 UTC (rev 107112)
@@ -1,3 +1,13 @@
+2012-02-07  Ojan Vafai  o...@chromium.org
+
+Floated flexboxes render as regular RenderBlocks
+https://bugs.webkit.org/show_bug.cgi?id=77909
+
+Reviewed by Eric Seidel.
+
+* css3/flexbox/floated-flexbox-expected.txt: Added.
+* css3/flexbox/floated-flexbox.html: Added.
+
 2012-02-08  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening.


Added: trunk/LayoutTests/css3/flexbox/floated-flexbox-expected.txt (0 => 107112)

--- trunk/LayoutTests/css3/flexbox/floated-flexbox-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/floated-flexbox-expected.txt	2012-02-08 19:58:35 UTC (rev 107112)
@@ -0,0 +1,7 @@
+FAIL:
+Expected 130 for width, but got 110. 
+
+div data-expected-width=130 data-expected-height=30 class=flexbox
+div style=background-color:pink; width: 20px; height: 20px;/div
+div style=background-color:red; width: 100px; height: 20px;/div
+/div
Property changes on: trunk/LayoutTests/css3/flexbox/floated-flexbox-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/css3/flexbox/floated-flexbox.html (0 => 107112)

--- trunk/LayoutTests/css3/flexbox/floated-flexbox.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/floated-flexbox.html	2012-02-08 19:58:35 UTC (rev 107112)
@@ -0,0 +1,30 @@
+!DOCTYPE html
+html
+style
+.flexbox {
+display: -webkit-flexbox;
+background-color: #aaa;
+border: 5px solid blue;
+float:left;
+}
+.flexbox :nth-child(1) {
+background-color: blue;
+}
+.flexbox :nth-child(2) {
+background-color: green;
+}
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+script src=""
+body _onload_=checkFlexBoxen()
+
+div data-expected-width=130 data-expected-height=30 class=flexbox
+div style=background-color:pink; width: 20px; height: 20px;/div
+div style=background-color:red; width: 100px; height: 20px;/div
+/div
+
+/body
+/html
Property changes on: trunk/LayoutTests/css3/flexbox/floated-flexbox.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (107111 => 107112)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 19:44:55 UTC (rev 107111)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 19:58:35 UTC (rev 107112)
@@ -1,3 +1,22 @@
+2012-02-07  Ojan Vafai  o...@chromium.org
+
+Floated flexboxes render as regular RenderBlocks
+https://bugs.webkit.org/show_bug.cgi?id=77909
+
+Reviewed by Eric Seidel.
+
+Add grid/flexbox cases to adjusting the display of floated/positioned
+elements. Also, move this logic into a switch statement. This makes
+the code more readable and gives compile warnings when new display types
+are added that aren't handled here.
+
+Test: css3/flexbox/floated-flexbox.html
+
+* css/CSSStyleSelector.cpp:
+(WebCore::adjustDisplay):
+(WebCore):
+(WebCore::CSSStyleSelector::adjustRenderStyle):
+
 2012-02-08  Dirk Schulze  k...@webkit.org
 
 viewBox on nested SVG causes wrong content size for relative values


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (107111 => 107112)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-02-08 19:44:55 UTC (rev 107111)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-02-08 19:58:35 UTC (rev 107112)
@@ -1727,6 +1727,55 @@
 }
 }
 
+static EDisplay equivalentBlockDisplay(EDisplay display, bool isFloating, bool strictParsing)
+{
+switch (display) {
+case BLOCK:
+case TABLE:
+case BOX:
+case FLEXBOX:
+#if ENABLE(CSS_GRID_LAYOUT)
+ 

[webkit-changes] [107114] trunk/LayoutTests

[caryclark]

Title: [107114] trunk/LayoutTests








Revision 107114
Author carycl...@google.com
Date 2012-02-08 12:11:28 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed rebaselines for vertical text tests.
See https://bugs.webkit.org/show_bug.cgi?id=78120

* platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
[...]
* platform/chromium-mac-snowleopard/fast/writing-mode/vertical-font-fallback-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/dynamic/text-combine-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/fallback-orientation-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-text-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-text-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/vertical-baseline-alignment-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/dynamic/text-combine-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/international/
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/border-vertical-lr-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/broken-ideographic-font-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/japanese-lr-text-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-text-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png

[webkit-changes] [107117] trunk/Source/WebKit/chromium

[commit-queue]

Title: [107117] trunk/Source/WebKit/chromium








Revision 107117
Author commit-qu...@webkit.org
Date 2012-02-08 12:17:40 -0800 (Wed, 08 Feb 2012)


Log Message
[chromium] Make dependency on Accelerate.framework explicit.
https://bugs.webkit.org/show_bug.cgi?id=78131

It's used by platform/audio/mac/FFTFrameMac.cpp. The explicit
dependency is needed to build a libwebkit.dylib.

Patch by Nico Weber nicolaswe...@gmx.de on 2012-02-08
Reviewed by Tony Chang.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (107116 => 107117)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 20:17:20 UTC (rev 107116)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 20:17:40 UTC (rev 107117)
@@ -1,3 +1,15 @@
+2012-02-08  Nico Weber  nicolaswe...@gmx.de
+
+[chromium] Make dependency on Accelerate.framework explicit.
+https://bugs.webkit.org/show_bug.cgi?id=78131
+
+It's used by platform/audio/mac/FFTFrameMac.cpp. The explicit
+dependency is needed to build a libwebkit.dylib.
+
+Reviewed by Tony Chang.
+
+* WebKit.gyp:
+
 2012-02-08  Bernhard Bauer  bau...@google.com
 
 [Chromium] Don't add selection from password fields to context menu.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (107116 => 107117)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-02-08 20:17:20 UTC (rev 107116)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-02-08 20:17:40 UTC (rev 107117)
@@ -858,6 +858,7 @@
 ['OS==mac', {
 'link_settings': {
 'libraries': [
+'$(SDKROOT)/System/Library/Frameworks/Accelerate.framework',
 '$(SDKROOT)/System/Library/Frameworks/OpenGL.framework',
 ],
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107118] trunk

[aestes]

Title: [107118] trunk








Revision 107118
Author aes...@apple.com
Date 2012-02-08 12:20:41 -0800 (Wed, 08 Feb 2012)


Log Message
REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize
https://bugs.webkit.org/show_bug.cgi?id=77167

Reviewed by Eric Seidel.

Source/WebCore:

Test: plugins/layout-in-beforeload-listener-affects-plugin-loading.html

r102983 made FrameView::updateWidgets() check if the DOM node actually
needs a widget update before calling updateWidget(). Due to historical
reasons, however, updateWidget() can be legitimately called twice: once
at attach time for non-Netscape plug-ins and once at layout time for
Netscape plug-ins.

If the widget represents a Netscape plug-in, but updateWidget() is
called for the CreateOnlyNonNetscapePlugins case after the DOM node was
marked as needing an update, updateWidget() will clear the update flag
and prevent a second call to updateWidget() at layout time for the
CreateAnyWidgetType case.

As much as I loathe adding to the code duplication between
HTMLEmbedElement::updateWidget() and HTMLObjectElement::updateWidget(),
the simplest solution seems to be marking the DOM node as needing
update in the case where we are calling updateWidget() for the
CreateOnlyNonNetscapePlugins case and we know we will be loading a
Netscape plug-in.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Call
setNeedsWidgetUpdate(true) if pluginCreationOption is
CreateOnlyNonNetscapePlugins but we will load a Netscape plug-in.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Ditto.
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent): Remove an
invalid assertion that prevents the layout test from running in a Debug
configuration.

LayoutTests:

* plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt: Added.
* plugins/layout-in-beforeload-listener-affects-plugin-loading.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/HTMLPlugInElement.cpp


Added Paths

trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt
trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107117 => 107118)

--- trunk/LayoutTests/ChangeLog	2012-02-08 20:17:40 UTC (rev 107117)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 20:20:41 UTC (rev 107118)
@@ -1,3 +1,13 @@
+2012-02-07  Andy Estes  aes...@apple.com
+
+REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize
+https://bugs.webkit.org/show_bug.cgi?id=77167
+
+Reviewed by Eric Seidel.
+
+* plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt: Added.
+* plugins/layout-in-beforeload-listener-affects-plugin-loading.html: Added.
+
 2012-02-08  Cary Clark  carycl...@google.com
 
 Unreviewed rebaselines for vertical text tests.


Added: trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt (0 => 107118)

--- trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt	(rev 0)
+++ trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt	2012-02-08 20:20:41 UTC (rev 107118)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: line 27: PASS
+ 


Added: trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading.html (0 => 107118)

--- trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading.html	(rev 0)
+++ trunk/LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading.html	2012-02-08 20:20:41 UTC (rev 107118)
@@ -0,0 +1,42 @@
+!DOCTYPE html
+html
+head
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+window._beforeloadReceivedForEmbed = false;
+
+document.addEventListener(beforeload, function(event) {
+if (document.getElementsByTagName(object)[0] == event.target) {
+// trigger a layout
+event.target.offsetWidth;
+return;
+}
+
+_beforeloadReceivedForEmbed = document.getElementsByTagName(embed)[0] == event.target;
+}, true);
+
+function test() {
+// The embed should load as a post-layout task that executes in
+// the current run loop iteration. Queue a task to check if the
+// embed's beforeload event fired.
+window.setTimeout(function() {
+console.log(_beforeloadReceivedForEmbed ? PASS : FAIL);
+if 

[webkit-changes] [107122] trunk/LayoutTests

[eae]

Title: [107122] trunk/LayoutTests








Revision 107122
Author e...@chromium.org
Date 2012-02-08 12:42:19 -0800 (Wed, 08 Feb 2012)


Log Message
Update pixel table test expectations for mac to match new DRT scrollbars
https://bugs.webkit.org/show_bug.cgi?id=76938

Rubber stamped by Eric Seidel.

* platform/mac/tables/mozilla/bugs/bug101674-expected.png:
* platform/mac/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug113235-3-expected.png:
* platform/mac/tables/mozilla/bugs/bug11944-expected.png:
* platform/mac/tables/mozilla/bugs/bug120364-expected.png:
* platform/mac/tables/mozilla/bugs/bug131020-expected.png:
* platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
* platform/mac/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug22019-expected.png:
* platform/mac/tables/mozilla/bugs/bug23151-expected.png:
* platform/mac/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug29314-expected.png:
* platform/mac/tables/mozilla/bugs/bug32205-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug38916-expected.png:
* platform/mac/tables/mozilla/bugs/bug43039-expected.png:
* platform/mac/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug44505-expected.png:
* platform/mac/tables/mozilla/bugs/bug46480-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug46480-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug50695-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug56405-expected.png:
* platform/mac/tables/mozilla/bugs/bug67915-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug73321-expected.png:
* platform/mac/tables/mozilla/bugs/bug92143-expected.png:
* platform/mac/tables/mozilla/bugs/bug96334-expected.png:
* platform/mac/tables/mozilla/bugs/bug96343-expected.png:
* platform/mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_height-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_height-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
* platform/mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/columns-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/standards1-expected.png:
* platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug101674-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug10296-1-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-1-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug11944-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug120364-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug131020-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.png
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug137388-2-expected.png

[webkit-changes] [107119] trunk/Source/WebCore

[andersca]

Title: [107119] trunk/Source/WebCore








Revision 107119
Author ander...@apple.com
Date 2012-02-08 12:24:57 -0800 (Wed, 08 Feb 2012)


Log Message
Add a content shadow layer to the render layer compositor
https://bugs.webkit.org/show_bug.cgi?id=78133
rdar://problem/10797742

Reviewed by Beth Dakin.

Have the render layer compositor optionally create a content shadow layer,
and add a ScrollbarTheme::setUpContentShadowLayer member function that subclasses
can use to set content shadow properties.

* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
Set the layer properties once, and set the shadow path on every call, since we know that this
function will be called every time the size of the content shadow layer changes.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Reposition the content shadow layer, and call ScrollbarTheme::setUpContentShadowLayer if the size changes.

(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
Add new helper function.

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Create a content shadow layer if needed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollbarTheme.h
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107118 => 107119)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 20:20:41 UTC (rev 107118)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 20:24:57 UTC (rev 107119)
@@ -1,3 +1,30 @@
+2012-02-08  Anders Carlsson  ander...@apple.com
+
+Add a content shadow layer to the render layer compositor
+https://bugs.webkit.org/show_bug.cgi?id=78133
+rdar://problem/10797742
+
+Reviewed by Beth Dakin.
+
+Have the render layer compositor optionally create a content shadow layer,
+and add a ScrollbarTheme::setUpContentShadowLayer member function that subclasses
+can use to set content shadow properties.
+
+* platform/mac/ScrollbarThemeMac.mm:
+(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
+Set the layer properties once, and set the shadow path on every call, since we know that this
+function will be called every time the size of the content shadow layer changes.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateRootLayerPosition):
+Reposition the content shadow layer, and call ScrollbarTheme::setUpContentShadowLayer if the size changes.
+
+(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
+Add new helper function.
+
+(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
+Create a content shadow layer if needed.
+
 2012-02-07  Andy Estes  aes...@apple.com
 
 REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize


Modified: trunk/Source/WebCore/platform/ScrollbarTheme.h (107118 => 107119)

--- trunk/Source/WebCore/platform/ScrollbarTheme.h	2012-02-08 20:20:41 UTC (rev 107118)
+++ trunk/Source/WebCore/platform/ScrollbarTheme.h	2012-02-08 20:24:57 UTC (rev 107119)
@@ -90,6 +90,7 @@
 
 #if USE(ACCELERATED_COMPOSITING)  ENABLE(RUBBER_BANDING)
 virtual void setUpOverhangAreasLayerContents(GraphicsLayer*) { }
+virtual void setUpContentShadowLayer(GraphicsLayer*) { }
 #endif
 
 virtual bool shouldCenterOnThumb(Scrollbar*, const PlatformMouseEvent) { return false; }


Modified: trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h (107118 => 107119)

--- trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h	2012-02-08 20:20:41 UTC (rev 107118)
+++ trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h	2012-02-08 20:24:57 UTC (rev 107119)
@@ -83,6 +83,7 @@
 
 #if !PLATFORM(CHROMIUM)  USE(ACCELERATED_COMPOSITING)  ENABLE(RUBBER_BANDING)
 virtual void setUpOverhangAreasLayerContents(GraphicsLayer*) OVERRIDE;
+virtual void setUpContentShadowLayer(GraphicsLayer*) OVERRIDE;
 #endif
 };
 


Modified: trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm (107118 => 107119)

--- trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm	2012-02-08 20:20:41 UTC (rev 107118)
+++ trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm	2012-02-08 20:24:57 UTC (rev 107119)
@@ -624,6 +624,27 @@
 graphicsLayer-platformLayer().backgroundColor = cachedLinenBackgroundColor;
 }
 
+void ScrollbarThemeMac::setUpContentShadowLayer(GraphicsLayer* graphicsLayer)
+{
+// We operate on the CALayer directly here, since GraphicsLayer doesn't have the concept
+// of shadows, and we know that WebCore won't touch this layer.
+CALayer *contentShadowLayer = graphicsLayer-platformLayer();
+
+static const CGFloat shadowOpacity = 0.66;
+static const CGFloat shadowRadius = 

[webkit-changes] [107120] trunk

[commit-queue]

Title: [107120] trunk








Revision 107120
Author commit-qu...@webkit.org
Date 2012-02-08 12:35:06 -0800 (Wed, 08 Feb 2012)


Log Message
[chromium] Disable root layer clears on release builds.
https://bugs.webkit.org/show_bug.cgi?id=77478

Patch by Jonathan Backer bac...@chromium.org on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):

LayoutTests:

* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
* platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png
trunk/LayoutTests/platform/chromium-gpu-linux/media/video-zoom-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/direct-image-compositing-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/masks/masked-ancestor-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/masks/multiple-masks-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png
trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h




Diff

Modified: trunk/LayoutTests/ChangeLog (107119 => 107120)

--- trunk/LayoutTests/ChangeLog	2012-02-08 20:24:57 UTC (rev 107119)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 20:35:06 UTC (rev 107120)
@@ -1,3 +1,22 @@
+2012-02-08  Jonathan Backer  bac...@chromium.org
+
+[chromium] Disable root layer clears on release builds.
+https://bugs.webkit.org/show_bug.cgi?id=77478
+
+Reviewed by James Robinson.
+
+* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
+* platform/chromium-gpu-linux/media/video-zoom-expected.png:
+* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
+* platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
+* platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
+* platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png:
+* platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
+* platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
+* platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
+* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
+* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
+
 2012-02-07  Andy Estes  aes...@apple.com
 
 REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize


Modified: trunk/LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-gpu-linux/media/video-zoom-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-linux/compositing/direct-image-compositing-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png

(Binary files differ)


Modified: 

[webkit-changes] [107121] trunk/Source/WebCore

[jamesr]

Title: [107121] trunk/Source/WebCore








Revision 107121
Author jam...@google.com
Date 2012-02-08 12:39:37 -0800 (Wed, 08 Feb 2012)


Log Message
Make WebGL context current early to check validity
https://bugs.webkit.org/show_bug.cgi?id=78141

Patch by Antoine Labour pi...@chromium.org on 2012-02-08
Reviewed by James Robinson.

Covered by existing tests

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107120 => 107121)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 20:35:06 UTC (rev 107120)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 20:39:37 UTC (rev 107121)
@@ -1,3 +1,16 @@
+2012-02-08  Antoine Labour  pi...@chromium.org
+
+Make WebGL context current early to check validity
+https://bugs.webkit.org/show_bug.cgi?id=78141
+
+Reviewed by James Robinson.
+
+Covered by existing tests
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore):
+(WebCore::WebGLRenderingContext::create):
+
 2012-02-08  Jonathan Backer  bac...@chromium.org
 
 [chromium] Disable root layer clears on release builds.


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (107120 => 107121)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2012-02-08 20:35:06 UTC (rev 107120)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2012-02-08 20:39:37 UTC (rev 107121)
@@ -405,7 +405,7 @@
 
 RefPtrGraphicsContext3D context(GraphicsContext3D::create(attributes, hostWindow));
 
-if (!context) {
+if (!context || !context-makeContextCurrent()) {
 canvas-dispatchEvent(WebGLContextEvent::create(eventNames().webglcontextcreationerrorEvent, false, true, Could not create a WebGL context.));
 return nullptr;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107123] trunk/Source/WebCore

[inferno]

Title: [107123] trunk/Source/WebCore








Revision 107123
Author infe...@chromium.org
Date 2012-02-08 12:53:54 -0800 (Wed, 08 Feb 2012)


Log Message
Crash in Node::normalize.
https://bugs.webkit.org/show_bug.cgi?id=78135

Reviewed by Ryosuke Niwa.

No new tests. Original testcase does not reduce to manageable
extent.

* dom/Node.cpp:
(WebCore::Node::normalize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107122 => 107123)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 20:42:19 UTC (rev 107122)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 20:53:54 UTC (rev 107123)
@@ -1,3 +1,16 @@
+2012-02-08  Abhishek Arya  infe...@chromium.org
+
+Crash in Node::normalize.
+https://bugs.webkit.org/show_bug.cgi?id=78135
+
+Reviewed by Ryosuke Niwa.
+
+No new tests. Original testcase does not reduce to manageable
+extent.
+
+* dom/Node.cpp:
+(WebCore::Node::normalize):
+
 2012-02-08  Antoine Labour  pi...@chromium.org
 
 Make WebGL context current early to check validity


Modified: trunk/Source/WebCore/dom/Node.cpp (107122 => 107123)

--- trunk/Source/WebCore/dom/Node.cpp	2012-02-08 20:42:19 UTC (rev 107122)
+++ trunk/Source/WebCore/dom/Node.cpp	2012-02-08 20:53:54 UTC (rev 107123)
@@ -632,7 +632,7 @@
 continue;
 }
 
-Text* text = static_castText*(node.get());
+RefPtrText text = static_castText*(node.get());
 
 // Remove empty text nodes.
 if (!text-length()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107124] trunk/Tools

[dpranke]

Title: [107124] trunk/Tools








Revision 107124
Author dpra...@chromium.org
Date 2012-02-08 13:02:53 -0800 (Wed, 08 Feb 2012)


Log Message
check-webkit-style failing with Path does not exist.
https://bugs.webkit.org/show_bug.cgi?id=77873

Reviewed by Ojan Vafai.

This change fixes the way the style checker determines which
Port class to use for a given test_expectations.txt path; the
previous version used a heuristic that didn't really work in the
first place.

* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path):
(TestExpectationsChecker.__init__):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.test_determine_port_from_expectations_path):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (107123 => 107124)

--- trunk/Tools/ChangeLog	2012-02-08 20:53:54 UTC (rev 107123)
+++ trunk/Tools/ChangeLog	2012-02-08 21:02:53 UTC (rev 107124)
@@ -1,3 +1,22 @@
+2012-02-08  Dirk Pranke  dpra...@chromium.org
+
+check-webkit-style failing with Path does not exist.
+https://bugs.webkit.org/show_bug.cgi?id=77873
+
+Reviewed by Ojan Vafai.
+
+This change fixes the way the style checker determines which
+Port class to use for a given test_expectations.txt path; the
+previous version used a heuristic that didn't really work in the
+first place.
+
+* Scripts/webkitpy/style/checkers/test_expectations.py:
+(TestExpectationsChecker._determine_port_from_expectations_path):
+(TestExpectationsChecker.__init__):
+* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
+(TestExpectationsTestCase._expect_port_for_expectations_path):
+(TestExpectationsTestCase.test_determine_port_from_expectations_path):
+
 2012-02-08  Fehér Zsolt  fehe...@inf.u-szeged.hu
 
 nrwt: make --skip-pixel-test-if-no-baseline option


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py (107123 => 107124)

--- trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py	2012-02-08 20:53:54 UTC (rev 107123)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations.py	2012-02-08 21:02:53 UTC (rev 107124)
@@ -47,18 +47,15 @@
 
 categories = set(['test/expectations'])
 
-def _determine_port_from_exepectations_path(self, host, expectations_path):
-try:
-port_name = expectations_path.split(host.filesystem.sep)[-2]
-if not port_name:
-return None
+def _determine_port_from_expectations_path(self, host, expectations_path):
+# Pass a configuration to avoid calling default_configuration() when initializing the port (takes 0.5 seconds on a Mac Pro!).
+options = DummyOptions(configuration='Release')
+for port_name in host.port_factory.all_port_names():
+port = host.port_factory.get(port_name, options=options)
+if port.path_to_test_expectations_file().replace(port.path_from_webkit_base() + host.filesystem.sep, '') == expectations_path:
+return port
+return None
 
-# Pass a configuration to avoid calling default_configuration() when initializing the port (takes 0.5 seconds on a Mac Pro!).
-return host.port_factory.get(port_name, options=DummyOptions(configuration=Release))
-except Exception, e:
-_log.warn(Exception while getting port for path %s % expectations_path)
-return None
-
 def __init__(self, file_path, handle_style_error, host=None):
 self._file_path = file_path
 self._handle_style_error = handle_style_error
@@ -70,15 +67,8 @@
 host = host or Host()
 host._initialize_scm()
 
-# Determining the port of this expectations.
-self._port_obj = self._determine_port_from_exepectations_path(host, file_path)
-# Using 'test' port when we couldn't determine the port for this
-# expectations.
-if not self._port_obj:
-_log.warn(Could not determine the port for %s. 
-  Using 'test' port, but platform-specific expectations 
-  will fail the check. % self._file_path)
-self._port_obj = host.port_factory.get('test')
+self._port_obj = self._determine_port_from_expectations_path(host, file_path)
+
 # Suppress error messages of test_expectations module since they will be reported later.
 log = logging.getLogger(webkitpy.layout_tests.layout_package.test_expectations)
 log.setLevel(logging.CRITICAL)
@@ -112,8 +102,12 @@
 def check(self, lines):
 overrides = self._port_obj.test_expectations_overrides()
 expectations = 

[webkit-changes] [107125] trunk/Source/WebKit/chromium

[commit-queue]

Title: [107125] trunk/Source/WebKit/chromium








Revision 107125
Author commit-qu...@webkit.org
Date 2012-02-08 13:12:58 -0800 (Wed, 08 Feb 2012)


Log Message
Add support for pinch gesture processing in the MT compositor.
https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Sadrul Habib Chowdhury sad...@chromium.org on 2012-02-08
Reviewed by James Robinson.

* public/WebInputEvent.h:
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
* tests/WebCompositorInputHandlerImplTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebInputEvent.h
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.h
trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (107124 => 107125)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 21:02:53 UTC (rev 107124)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-08 21:12:58 UTC (rev 107125)
@@ -1,3 +1,24 @@
+2012-02-08  Sadrul Habib Chowdhury  sad...@chromium.org
+
+Add support for pinch gesture processing in the MT compositor.
+https://bugs.webkit.org/show_bug.cgi?id=77804
+
+Reviewed by James Robinson.
+
+* public/WebInputEvent.h:
+* src/WebCompositorInputHandlerImpl.cpp:
+(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
+(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
+* src/WebCompositorInputHandlerImpl.h:
+(WebCompositorInputHandlerImpl):
+* src/WebInputEventConversion.cpp:
+(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
+* src/WebPopupMenuImpl.cpp:
+(WebKit::WebPopupMenuImpl::handleInputEvent):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::handleInputEvent):
+* tests/WebCompositorInputHandlerImplTest.cpp:
+
 2012-02-08  Nico Weber  nicolaswe...@gmx.de
 
 [chromium] Make dependency on Accelerate.framework explicit.


Modified: trunk/Source/WebKit/chromium/public/WebInputEvent.h (107124 => 107125)

--- trunk/Source/WebKit/chromium/public/WebInputEvent.h	2012-02-08 21:02:53 UTC (rev 107124)
+++ trunk/Source/WebKit/chromium/public/WebInputEvent.h	2012-02-08 21:12:58 UTC (rev 107125)
@@ -109,6 +109,9 @@
 GestureTap,
 GestureTapDown,
 GestureDoubleTap,
+GesturePinchBegin,
+GesturePinchEnd,
+GesturePinchUpdate,
 
 // WebTouchEvent
 TouchStart,
@@ -351,6 +354,8 @@
 int y;
 int globalX;
 int globalY;
+
+// NOTE: |deltaX| and |deltaY| represents the amount to scroll for Scroll gesture events. For Pinch gesture events, |deltaX| represents the scaling/magnification factor.
 float deltaX;
 float deltaY;
 


Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (107124 => 107125)

--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-02-08 21:02:53 UTC (rev 107124)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-02-08 21:12:58 UTC (rev 107125)
@@ -83,6 +83,7 @@
 , m_inputHandlerClient(inputHandlerClient)
 #ifndef NDEBUG
 , m_expectScrollUpdateEnd(false)
+, m_expectPinchUpdateEnd(false)
 #endif
 , m_scrollStarted(false)
 {
@@ -173,6 +174,28 @@
 m_scrollStarted = false;
 return;
 }
+} else if (event.type == WebInputEvent::GesturePinchBegin) {
+ASSERT(!m_expectPinchUpdateEnd);
+#ifndef NDEBUG
+m_expectPinchUpdateEnd = true;
+#endif
+m_inputHandlerClient-pinchGestureBegin();
+m_client-didHandleInputEvent();
+return;
+} else if (event.type == WebInputEvent::GesturePinchEnd) {
+ASSERT(m_expectPinchUpdateEnd);
+#ifndef NDEBUG
+m_expectPinchUpdateEnd = false;
+#endif
+m_inputHandlerClient-pinchGestureEnd();
+m_client-didHandleInputEvent();
+return;
+} else if (event.type == WebInputEvent::GesturePinchUpdate) {
+ASSERT(m_expectPinchUpdateEnd);
+const WebGestureEvent gestureEvent = *static_castconst WebGestureEvent*(event);
+m_inputHandlerClient-pinchGestureUpdate(gestureEvent.deltaX, IntPoint(gestureEvent.x, gestureEvent.y));
+m_client-didHandleInputEvent();
+return;
 }
 

[webkit-changes] [107126] trunk/Source/JavaScriptCore

[oliver]

Title: [107126] trunk/Source/_javascript_Core








Revision 107126
Author oli...@apple.com
Date 2012-02-08 13:22:49 -0800 (Wed, 08 Feb 2012)


Log Message
updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
https://bugs.webkit.org/show_bug.cgi?id=78145

Reviewed by Gavin Barraclough.

Fix the updateTopCallFrame helper to store additional information
that becomes necessary when we are trying to provide more stack
frame information.

* interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForBaselineJIT):
(ExecState):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/CallFrame.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITInlineMethods.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (107125 => 107126)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-08 21:12:58 UTC (rev 107125)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-08 21:22:49 UTC (rev 107126)
@@ -1,3 +1,30 @@
+2012-02-08  Oliver Hunt  oli...@apple.com
+
+updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
+https://bugs.webkit.org/show_bug.cgi?id=78145
+
+Reviewed by Gavin Barraclough.
+
+Fix the updateTopCallFrame helper to store additional information
+that becomes necessary when we are trying to provide more stack
+frame information.
+
+* interpreter/CallFrame.h:
+(JSC::ExecState::bytecodeOffsetForBaselineJIT):
+(ExecState):
+* jit/JIT.cpp:
+(JSC::JIT::privateCompile):
+* jit/JIT.h:
+(JSC::JIT::compileGetByIdProto):
+(JSC::JIT::compileGetByIdSelfList):
+(JSC::JIT::compileGetByIdProtoList):
+(JSC::JIT::compileGetByIdChainList):
+(JSC::JIT::compileGetByIdChain):
+(JSC::JIT::compilePutByIdTransition):
+(JIT):
+* jit/JITInlineMethods.h:
+(JSC::JIT::updateTopCallFrame):
+
 2012-02-07  Robert Kroeger  rjkro...@chromium.org
 
 [chromium] Remove the enable marcro for the no longer necessary Chromium


Modified: trunk/Source/_javascript_Core/interpreter/CallFrame.h (107125 => 107126)

--- trunk/Source/_javascript_Core/interpreter/CallFrame.h	2012-02-08 21:12:58 UTC (rev 107125)
+++ trunk/Source/_javascript_Core/interpreter/CallFrame.h	2012-02-08 21:22:49 UTC (rev 107126)
@@ -106,6 +106,8 @@
 ReturnAddressPtr returnPC() const { return ReturnAddressPtr(this[RegisterFile::ReturnPC].vPC()); }
 #endif
 AbstractPC abstractReturnPC(JSGlobalData globalData) { return AbstractPC(globalData, this); }
+unsigned bytecodeOffsetForBaselineJIT() { return this[RegisterFile::ArgumentCount].tag(); }
+
 #if ENABLE(DFG_JIT)
 InlineCallFrame* inlineCallFrame() const { return this[RegisterFile::ReturnPC].asInlineCallFrame(); }
 unsigned codeOriginIndexForDFGWithInlining() const { return this[RegisterFile::ArgumentCount].tag(); }


Modified: trunk/Source/_javascript_Core/jit/JIT.cpp (107125 => 107126)

--- trunk/Source/_javascript_Core/jit/JIT.cpp	2012-02-08 21:12:58 UTC (rev 107125)
+++ trunk/Source/_javascript_Core/jit/JIT.cpp	2012-02-08 21:22:49 UTC (rev 107126)
@@ -606,7 +606,11 @@
 load32(payloadFor(RegisterFile::ArgumentCount), regT1);
 branch32(AboveOrEqual, regT1, TrustedImm32(m_codeBlock-m_numParameters)).linkTo(beginLabel, this);
 
+m_bytecodeOffset = 0;
 JITStubCall(this, m_codeBlock-m_isConstructor ? cti_op_construct_arityCheck : cti_op_call_arityCheck).call(callFrameRegister);
+#if !ASSERT_DISABLED
+m_bytecodeOffset = (unsigned)-1; // Reset this, in order to guard its use with ASSERTs.
+#endif
 
 jump(beginLabel);
 }


Modified: trunk/Source/_javascript_Core/jit/JIT.h (107125 => 107126)

--- trunk/Source/_javascript_Core/jit/JIT.h	2012-02-08 21:12:58 UTC (rev 107125)
+++ trunk/Source/_javascript_Core/jit/JIT.h	2012-02-08 21:22:49 UTC (rev 107126)
@@ -207,34 +207,40 @@
 static void compileGetByIdProto(JSGlobalData* globalData, CallFrame* callFrame, CodeBlock* codeBlock, StructureStubInfo* stubInfo, Structure* structure, Structure* prototypeStructure, const Identifier ident, const PropertySlot slot, size_t cachedOffset, ReturnAddressPtr returnAddress)
 {
 JIT jit(globalData, codeBlock);
+jit.m_bytecodeOffset = stubInfo-bytecodeIndex;
 jit.privateCompileGetByIdProto(stubInfo, structure, prototypeStructure, ident, slot, cachedOffset, returnAddress, callFrame);
 }
 
 static void 

[webkit-changes] [107127] trunk/Source/WebCore

[jamesr]

Title: [107127] trunk/Source/WebCore








Revision 107127
Author jam...@google.com
Date 2012-02-08 13:32:54 -0800 (Wed, 08 Feb 2012)


Log Message
[chromium] Check that we can make the SharedGraphicsContext3D current before returning
https://bugs.webkit.org/show_bug.cgi?id=78142

Reviewed by Stephen White.

If we can't make the context current, we can't use it.

* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107126 => 107127)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 21:22:49 UTC (rev 107126)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 21:32:54 UTC (rev 107127)
@@ -1,3 +1,15 @@
+2012-02-08  James Robinson  jam...@chromium.org
+
+[chromium] Check that we can make the SharedGraphicsContext3D current before returning
+https://bugs.webkit.org/show_bug.cgi?id=78142
+
+Reviewed by Stephen White.
+
+If we can't make the context current, we can't use it.
+
+* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+(WebCore::SharedGraphicsContext3D::get):
+
 2012-02-08  Abhishek Arya  infe...@chromium.org
 
 Crash in Node::normalize.


Modified: trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp (107126 => 107127)

--- trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp	2012-02-08 21:22:49 UTC (rev 107126)
+++ trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp	2012-02-08 21:32:54 UTC (rev 107127)
@@ -39,6 +39,8 @@
 attributes.canRecoverFromContextLoss = false; // Canvas contexts can not handle lost contexts.
 attributes.shareResources = true;
 static GraphicsContext3D* context = GraphicsContext3D::create(attributes, 0).leakRef();
+if (context  !context-makeContextCurrent())
+context = 0;
 return context;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107128] trunk/Source/JavaScriptCore

[oliver]

Title: [107128] trunk/Source/_javascript_Core








Revision 107128
Author oli...@apple.com
Date 2012-02-08 13:35:34 -0800 (Wed, 08 Feb 2012)


Log Message
Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147

Reviewed by Gavin Barraclough.

Debugging is easier if we always ensure that we have a non-null
inferred name.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Executable.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (107127 => 107128)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-08 21:32:54 UTC (rev 107127)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-08 21:35:34 UTC (rev 107128)
@@ -1,5 +1,18 @@
 2012-02-08  Oliver Hunt  oli...@apple.com
 
+Fix issue encountered while debugging stacktraces
+https://bugs.webkit.org/show_bug.cgi?id=78147
+
+Reviewed by Gavin Barraclough.
+
+Debugging is easier if we always ensure that we have a non-null
+inferred name.
+
+* runtime/Executable.cpp:
+(JSC::FunctionExecutable::FunctionExecutable):
+
+2012-02-08  Oliver Hunt  oli...@apple.com
+
 updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
 https://bugs.webkit.org/show_bug.cgi?id=78145
 


Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (107127 => 107128)

--- trunk/Source/_javascript_Core/runtime/Executable.cpp	2012-02-08 21:32:54 UTC (rev 107127)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp	2012-02-08 21:35:34 UTC (rev 107128)
@@ -137,7 +137,7 @@
 , m_forceUsesArguments(forceUsesArguments)
 , m_parameters(parameters)
 , m_name(name)
-, m_inferredName(inferredName)
+, m_inferredName(inferredName.isNull() ? exec-globalData().propertyNames-emptyIdentifier : inferredName)
 , m_symbolTable(0)
 {
 }
@@ -148,7 +148,7 @@
 , m_forceUsesArguments(forceUsesArguments)
 , m_parameters(parameters)
 , m_name(name)
-, m_inferredName(inferredName)
+, m_inferredName(inferredName.isNull() ? exec-globalData().propertyNames-emptyIdentifier : inferredName)
 , m_symbolTable(0)
 {
 }


Modified: trunk/Source/_javascript_Core/runtime/JSFunction.cpp (107127 => 107128)

--- trunk/Source/_javascript_Core/runtime/JSFunction.cpp	2012-02-08 21:32:54 UTC (rev 107127)
+++ trunk/Source/_javascript_Core/runtime/JSFunction.cpp	2012-02-08 21:35:34 UTC (rev 107128)
@@ -370,7 +370,7 @@
 return function-calculatedDisplayName(callFrame);
 if (InternalFunction* function = jsDynamicCastInternalFunction*(object))
 return function-calculatedDisplayName(callFrame);
-return UString();
+return callFrame-globalData().propertyNames-emptyIdentifier.ustring();
 }
 
 } // namespace JSC






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107129] trunk/Tools

[rwlbuis]

Title: [107129] trunk/Tools








Revision 107129
Author rwlb...@webkit.org
Date 2012-02-08 13:37:31 -0800 (Wed, 08 Feb 2012)


Log Message
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Reviewed by Antonio Gomes.

Upstream more parts of our DRT implementation.

* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/EventSender.cpp: Added.
* DumpRenderTree/blackberry/EventSender.h: Added.
* DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp
trunk/Tools/DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp
trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp
trunk/Tools/DumpRenderTree/blackberry/EventSender.h
trunk/Tools/DumpRenderTree/blackberry/GCControllerBlackBerry.cpp
trunk/Tools/DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp




Diff

Modified: trunk/Tools/ChangeLog (107128 => 107129)

--- trunk/Tools/ChangeLog	2012-02-08 21:35:34 UTC (rev 107128)
+++ trunk/Tools/ChangeLog	2012-02-08 21:37:31 UTC (rev 107129)
@@ -1,3 +1,19 @@
+2012-02-08  Rob Buis  rb...@rim.com
+
+[BlackBerry] Upstream DumpRenderTreeBlackBerry
+https://bugs.webkit.org/show_bug.cgi?id=78042
+
+Reviewed by Antonio Gomes.
+
+Upstream more parts of our DRT implementation.
+
+* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
+* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
+* DumpRenderTree/blackberry/EventSender.cpp: Added.
+* DumpRenderTree/blackberry/EventSender.h: Added.
+* DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
+* DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
+
 2012-02-08  Dirk Pranke  dpra...@chromium.org
 
 check-webkit-style failing with Path does not exist.


Added: trunk/Tools/DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp (0 => 107129)

--- trunk/Tools/DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp	(rev 0)
+++ trunk/Tools/DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp	2012-02-08 21:37:31 UTC (rev 107129)
@@ -0,0 +1,80 @@
+/*
+ * Copyright (C) 2010, 2012 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include config.h
+#include AccessibilityController.h
+
+#include AccessibilityUIElement.h
+#include NotImplemented.h
+
+AccessibilityController::AccessibilityController()
+{
+}
+
+AccessibilityController::~AccessibilityController()
+{
+}
+
+AccessibilityUIElement AccessibilityController::focusedElement()
+{
+notImplemented();
+return 0;
+}
+
+AccessibilityUIElement AccessibilityController::rootElement()
+{
+notImplemented();
+return 0;
+}
+
+void AccessibilityController::setLogFocusEvents(bool)
+{
+notImplemented();
+}
+
+void AccessibilityController::setLogScrollingStartEvents(bool)
+{
+notImplemented();
+}
+
+void AccessibilityController::setLogValueChangeEvents(bool)
+{
+notImplemented();
+}
+
+AccessibilityUIElement AccessibilityController::elementAtPoint(int, int)
+{
+notImplemented();
+return 0;
+}
+
+void AccessibilityController::setLogAccessibilityEvents(bool)
+{
+notImplemented();
+}
+
+void AccessibilityController::addNotificationListener(PlatformUIElement, JSObjectRef)
+{
+notImplemented();
+}
+
+void AccessibilityController::notificationReceived(PlatformUIElement, const std::string)
+{
+notImplemented();
+}
+


Added: trunk/Tools/DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp (0 => 107129)

--- trunk/Tools/DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp	(rev 0)
+++ trunk/Tools/DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp	2012-02-08 21:37:31 UTC (rev 107129)
@@ -0,0 +1,612 @@
+/*
+ * Copyright (C) 2010, 2012 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it 

[webkit-changes] [107130] trunk/Source

[shawnsingh]

Title: [107130] trunk/Source








Revision 107130
Author shawnsi...@chromium.org
Date 2012-02-08 13:41:47 -0800 (Wed, 08 Feb 2012)


Log Message
[chromium] Remove incorrect early exit in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76924

Reviewed by James Robinson.

Source/WebCore:

New unit test added to CCDamageTrackerTest.cpp

This patch does three things: (1) adds unit test that demonstrates
that early exiting in CCDamageTracker is wrong, (2) removes the
early exit and cleans up the surrounding code, and (3) re-names
several functions in CCDamageTracker so that state updating is
implied by the name, and not just a bad side-effect of the functions.

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
(WebCore::CCDamageTracker::trackDamageFromSurfaceMask):
(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):
* platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):

Source/WebKit/chromium:

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107129 => 107130)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 21:37:31 UTC (rev 107129)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 21:41:47 UTC (rev 107130)
@@ -1,3 +1,28 @@
+2012-02-08  Shawn Singh  shawnsi...@chromium.org
+
+[chromium] Remove incorrect early exit in CCDamageTracker
+https://bugs.webkit.org/show_bug.cgi?id=76924
+
+Reviewed by James Robinson.
+
+New unit test added to CCDamageTrackerTest.cpp
+
+This patch does three things: (1) adds unit test that demonstrates
+that early exiting in CCDamageTracker is wrong, (2) removes the
+early exit and cleans up the surrounding code, and (3) re-names
+several functions in CCDamageTracker so that state updating is
+implied by the name, and not just a bad side-effect of the functions.
+
+* platform/graphics/chromium/cc/CCDamageTracker.cpp:
+(WebCore::CCDamageTracker::updateDamageTrackingState):
+(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
+(WebCore::CCDamageTracker::trackDamageFromSurfaceMask):
+(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):
+* platform/graphics/chromium/cc/CCDamageTracker.h:
+(CCDamageTracker):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
+
 2012-02-08  James Robinson  jam...@chromium.org
 
 [chromium] Check that we can make the SharedGraphicsContext3D current before returning


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp (107129 => 107130)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp	2012-02-08 21:37:31 UTC (rev 107129)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp	2012-02-08 21:41:47 UTC (rev 107130)
@@ -56,13 +56,13 @@
 {
 }
 
-void CCDamageTracker::updateDamageRectForNextFrame(const VectorRefPtrCCLayerImpl  layerList, int targetSurfaceLayerID, CCLayerImpl* targetSurfaceMaskLayer)
+void CCDamageTracker::updateDamageTrackingState(const VectorRefPtrCCLayerImpl  layerList, int targetSurfaceLayerID, CCLayerImpl* targetSurfaceMaskLayer)
 {
 //
-// This function computes the damage rect of a target surface. The damage
-// rect is the region of the surface that may have changed and needs to be redrawn.
-// This can be used to scissor what is actually drawn, to save GPU computation and
-// bandwidth.
+// This function computes the damage rect of a target surface, and updates the state
+// that is used to correctly track damage across frames. The damage rect is the region
+// of the surface that may have changed and needs to be redrawn. This can be used to
+// scissor what is actually drawn, to save GPU computation and bandwidth.
 //
 // The surface's damage rect is computed as the union of all possible changes that
 // have happened to the surface since the last frame was drawn. This includes:
@@ -121,23 +121,23 @@
 // damage tracker is ready for the next frame.
 //
 
+// These functions cannot be bypassed with early-exits, even if we know what the
+// damage will be for this frame, because we need to update the damage tracker state
+// to correctly track the 

[webkit-changes] [107131] trunk/Source/JavaScriptCore

[oliver]

Title: [107131] trunk/Source/_javascript_Core








Revision 107131
Author oli...@apple.com
Date 2012-02-08 13:46:42 -0800 (Wed, 08 Feb 2012)


Log Message
Whoops, fix the build.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Executable.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (107130 => 107131)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-08 21:41:47 UTC (rev 107130)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-08 21:46:42 UTC (rev 107131)
@@ -1,5 +1,12 @@
 2012-02-08  Oliver Hunt  oli...@apple.com
 
+Whoops, fix the build.
+
+* runtime/Executable.cpp:
+(JSC::FunctionExecutable::FunctionExecutable):
+
+2012-02-08  Oliver Hunt  oli...@apple.com
+
 Fix issue encountered while debugging stacktraces
 https://bugs.webkit.org/show_bug.cgi?id=78147
 


Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (107130 => 107131)

--- trunk/Source/_javascript_Core/runtime/Executable.cpp	2012-02-08 21:41:47 UTC (rev 107130)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp	2012-02-08 21:46:42 UTC (rev 107131)
@@ -137,7 +137,7 @@
 , m_forceUsesArguments(forceUsesArguments)
 , m_parameters(parameters)
 , m_name(name)
-, m_inferredName(inferredName.isNull() ? exec-globalData().propertyNames-emptyIdentifier : inferredName)
+, m_inferredName(inferredName.isNull() ? globalData.propertyNames-emptyIdentifier : inferredName)
 , m_symbolTable(0)
 {
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107132] trunk/LayoutTests

[jamesr]

Title: [107132] trunk/LayoutTests








Revision 107132
Author jam...@google.com
Date 2012-02-08 13:47:51 -0800 (Wed, 08 Feb 2012)


Log Message
[chromium] Add a layout test for losing the compositor context with a video playing
https://bugs.webkit.org/show_bug.cgi?id=78060

Reviewed by Eric Carlson.

Adds a test to prevent regressions with video playback when we lose the compositor context. This test loads up a
video, forces a frame to be displayed, simulates a lost context, then finishes the test (which causes another
frame to be displayed).

Prior to r106610 this test times out in debug and crashes in ASAN.

* platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
* platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Added.
* platform/chromium/compositing/lost-compositor-context-with-video.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.png
trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.txt
trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107131 => 107132)

--- trunk/LayoutTests/ChangeLog	2012-02-08 21:46:42 UTC (rev 107131)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 21:47:51 UTC (rev 107132)
@@ -1,3 +1,20 @@
+2012-02-08  James Robinson  jam...@chromium.org
+
+[chromium] Add a layout test for losing the compositor context with a video playing
+https://bugs.webkit.org/show_bug.cgi?id=78060
+
+Reviewed by Eric Carlson.
+
+Adds a test to prevent regressions with video playback when we lose the compositor context. This test loads up a
+video, forces a frame to be displayed, simulates a lost context, then finishes the test (which causes another
+frame to be displayed).
+
+Prior to r106610 this test times out in debug and crashes in ASAN.
+
+* platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
+* platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Added.
+* platform/chromium/compositing/lost-compositor-context-with-video.html: Added.
+
 2012-02-08  Emil A Eklund  e...@chromium.org
 
 Update pixel table test expectations for mac to match new DRT scrollbars


Added: trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.txt (0 => 107132)

--- trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.txt	2012-02-08 21:47:51 UTC (rev 107132)
@@ -0,0 +1 @@
+
Property changes on: trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video.html (0 => 107132)

--- trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video.html	2012-02-08 21:47:51 UTC (rev 107132)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+!-- This test passes if it doesn't crash or timeout --
+html
+head
+script src=""
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText(true);  // This is only useful as a pixel test.
+layoutTestController.waitUntilDone();
+}
+
+function test() {
+var v = document.querySelector('video');
+v.addEventListener(seeked, function() {
+if (window.layoutTestController) {
+layoutTestController.display();
+layoutTestController.loseCompositorContext(1);
+layoutTestController.display();
+layoutTestController.notifyDone();
+}
+}, false);
+v.currentTime = 0;
+}
+/script
+body _onload_=setSrcByTagName('video', findMediaFile('video', '../../../media/content/test-25fps'));
+video _oncanplaythrough_=test();/video
+/body
+/html
Property changes on: trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video.html
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107133] branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp

[leviw]

Title: [107133] branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp








Revision 107133
Author le...@chromium.org
Date 2012-02-08 14:17:43 -0800 (Wed, 08 Feb 2012)


Log Message
Prevent painting rects that snap to zero width or height.

Modified Paths

branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp (107132 => 107133)

--- branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp	2012-02-08 21:47:51 UTC (rev 107132)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp	2012-02-08 22:17:43 UTC (rev 107133)
@@ -295,7 +295,8 @@
 
 bool RenderView::shouldRepaint(const LayoutRect r) const
 {
-if (printing() || r.width() == 0 || r.height() == 0)
+IntRect repaintRect = pixelSnappedIntRect(r);
+if (printing() || repaintRect.width() == 0 || repaintRect.height() == 0)
 return false;
 
 if (!m_frameView)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107134] trunk/LayoutTests

[jchaffraix]

Title: [107134] trunk/LayoutTests








Revision 107134
Author jchaffr...@webkit.org
Date 2012-02-08 14:38:24 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
Add those 2 new baselines.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (107133 => 107134)

--- trunk/LayoutTests/ChangeLog	2012-02-08 22:17:43 UTC (rev 107133)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 22:38:24 UTC (rev 107134)
@@ -1,3 +1,11 @@
+2012-02-08  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
+* platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
+Add those 2 new baselines.
+
 2012-02-08  James Robinson  jam...@chromium.org
 
 [chromium] Add a layout test for losing the compositor context with a video playing


Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107135] trunk/Source/WebCore

[commit-queue]

Title: [107135] trunk/Source/WebCore








Revision 107135
Author commit-qu...@webkit.org
Date 2012-02-08 14:44:00 -0800 (Wed, 08 Feb 2012)


Log Message
Dispatch updateViewportArguments(), when Document is finished
restoring from page cache.

https://bugs.webkit.org/show_bug.cgi?id=77943

Patch by Zalan Bujtas zbuj...@gmail.com on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Move updateViewportArguments() call from setPageInCache() to
documentDidResumeFromPageCache() to ensure, that the Document is
fully resumed from the page cache and attached to the mainframe,
when the viewport arguments are updated.

No tests. No change in behaviour.

* dom/Document.cpp:
(WebCore::Document::setInPageCache):
(WebCore::Document::documentDidResumeFromPageCache):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107134 => 107135)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 22:38:24 UTC (rev 107134)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 22:44:00 UTC (rev 107135)
@@ -1,3 +1,23 @@
+2012-02-08  Zalan Bujtas  zbuj...@gmail.com
+
+Dispatch updateViewportArguments(), when Document is finished
+restoring from page cache.
+
+https://bugs.webkit.org/show_bug.cgi?id=77943
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Move updateViewportArguments() call from setPageInCache() to
+documentDidResumeFromPageCache() to ensure, that the Document is
+fully resumed from the page cache and attached to the mainframe,
+when the viewport arguments are updated.
+
+No tests. No change in behaviour.
+
+* dom/Document.cpp:
+(WebCore::Document::setInPageCache):
+(WebCore::Document::documentDidResumeFromPageCache):
+
 2012-02-08  Shawn Singh  shawnsi...@chromium.org
 
 [chromium] Remove incorrect early exit in CCDamageTracker


Modified: trunk/Source/WebCore/dom/Document.cpp (107134 => 107135)

--- trunk/Source/WebCore/dom/Document.cpp	2012-02-08 22:38:24 UTC (rev 107134)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-02-08 22:44:00 UTC (rev 107135)
@@ -4085,8 +4085,6 @@
 setRenderer(m_savedRenderer);
 m_savedRenderer = 0;
 
-updateViewportArguments();
-
 if (childNeedsStyleRecalc())
 scheduleStyleRecalc();
 }
@@ -4127,6 +4125,8 @@
 
 ASSERT(m_frame);
 m_frame-loader()-client()-dispatchDidBecomeFrameset(isFrameSet());
+
+updateViewportArguments();
 }
 
 void Document::registerForPageCacheSuspensionCallbacks(Element* e)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107136] trunk/Tools

[abarth]

Title: [107136] trunk/Tools








Revision 107136
Author aba...@webkit.org
Date 2012-02-08 15:08:24 -0800 (Wed, 08 Feb 2012)


Log Message
Stop importing with_statement from the mysterious future
https://bugs.webkit.org/show_bug.cgi?id=78156

Reviewed by Eric Seidel.

The future is now!  (Well, at least 2008, when Python 2.6 was released,
is no longer the __future__.)

* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/common/net/file_uploader.py:
* Scripts/webkitpy/common/newstringio_unittest.py:
* Scripts/webkitpy/common/system/autoinstall.py:
* Scripts/webkitpy/common/system/crashlogs.py:
* Scripts/webkitpy/common/system/fileset.py:
* Scripts/webkitpy/common/system/filesystem.py:
* Scripts/webkitpy/common/system/filesystem_unittest.py:
* Scripts/webkitpy/common/system/path.py:
* Scripts/webkitpy/common/thread/threadedmessagequeue.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/port/base.py:
(of):
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
* Scripts/webkitpy/style/filereader_unittest.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
* Scripts/webkitpy/tool/commands/analyzechangelog.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:
* Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py
trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py
trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
trunk/Tools/Scripts/webkitpy/common/net/credentials_unittest.py
trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py
trunk/Tools/Scripts/webkitpy/common/newstringio_unittest.py
trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py
trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py
trunk/Tools/Scripts/webkitpy/common/system/fileset.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py
trunk/Tools/Scripts/webkitpy/common/system/path.py
trunk/Tools/Scripts/webkitpy/common/thread/threadedmessagequeue.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
trunk/Tools/Scripts/webkitpy/style/filereader_unittest.py
trunk/Tools/Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py
trunk/Tools/Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py
trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py
trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (107135 => 107136)

--- trunk/Tools/ChangeLog	2012-02-08 22:44:00 UTC (rev 107135)
+++ trunk/Tools/ChangeLog	2012-02-08 23:08:24 UTC (rev 107136)
@@ -1,3 +1,40 @@
+2012-02-08  Adam Barth  aba...@webkit.org
+
+Stop importing with_statement from the mysterious future
+https://bugs.webkit.org/show_bug.cgi?id=78156
+
+Reviewed by Eric Seidel.
+
+The future is now!  (Well, at least 2008, when Python 2.6 was released,
+is no longer the __future__.)
+
+* Scripts/webkitpy/common/checkout/changelog_unittest.py:
+* Scripts/webkitpy/common/checkout/checkout_unittest.py:
+* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
+* Scripts/webkitpy/common/net/credentials_unittest.py:
+* Scripts/webkitpy/common/net/file_uploader.py:
+* Scripts/webkitpy/common/newstringio_unittest.py:
+* Scripts/webkitpy/common/system/autoinstall.py:
+* Scripts/webkitpy/common/system/crashlogs.py:
+* Scripts/webkitpy/common/system/fileset.py:
+* Scripts/webkitpy/common/system/filesystem.py:
+* Scripts/webkitpy/common/system/filesystem_unittest.py:
+* Scripts/webkitpy/common/system/path.py:
+* Scripts/webkitpy/common/thread/threadedmessagequeue.py:
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+* Scripts/webkitpy/layout_tests/port/base.py:
+(of):
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+* Scripts/webkitpy/layout_tests/port/test.py:
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+* 

[webkit-changes] [107137] trunk/Source/WebCore

[haraken]

Title: [107137] trunk/Source/WebCore








Revision 107137
Author hara...@chromium.org
Date 2012-02-08 15:14:46 -0800 (Wed, 08 Feb 2012)


Log Message
Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
https://bugs.webkit.org/show_bug.cgi?id=78089

Reviewed by Adam Barth.

This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
should have custom header or not will depend on _javascript_ bindings.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* dom/Node.idl:
* html/canvas/CanvasPixelArray.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/dom/Node.idl
trunk/Source/WebCore/html/canvas/CanvasPixelArray.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (107136 => 107137)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 23:08:24 UTC (rev 107136)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 23:14:46 UTC (rev 107137)
@@ -1,3 +1,23 @@
+2012-02-08  Kentaro Hara  hara...@chromium.org
+
+Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
+https://bugs.webkit.org/show_bug.cgi?id=78089
+
+Reviewed by Adam Barth.
+
+This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
+does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
+is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
+Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
+should have custom header or not will depend on _javascript_ bindings.
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+* dom/Node.idl:
+* html/canvas/CanvasPixelArray.idl:
+
 2012-02-08  Zalan Bujtas  zbuj...@gmail.com
 
 Dispatch updateViewportArguments(), when Document is finished


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (107136 => 107137)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-08 23:08:24 UTC (rev 107136)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-08 23:14:46 UTC (rev 107137)
@@ -749,9 +749,9 @@
 # Prototype
 push(@headerContent, static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);\n) unless ($dataNode-extendedAttributes-{ExtendsDOMGlobalObject});
 
-$headerTrailingIncludes{${className}Custom.h} = 1 if $dataNode-extendedAttributes-{CustomHeader};
+$headerTrailingIncludes{${className}Custom.h} = 1 if $dataNode-extendedAttributes-{JSCustomHeader};
 
-$implIncludes{${className}Custom.h} = 1 if !$dataNode-extendedAttributes-{CustomHeader}  ($dataNode-extendedAttributes-{CustomPutFunction} || $dataNode-extendedAttributes-{CustomNamedSetter});
+$implIncludes{${className}Custom.h} = 1 if !$dataNode-extendedAttributes-{JSCustomHeader}  ($dataNode-extendedAttributes-{CustomPutFunction} || $dataNode-extendedAttributes-{CustomNamedSetter});
 
 my $hasGetter = $numAttributes  0
  || !$dataNode-extendedAttributes-{OmitConstructor}


Modified: trunk/Source/WebCore/dom/Node.idl (107136 => 107137)

--- trunk/Source/WebCore/dom/Node.idl	2012-02-08 23:08:24 UTC (rev 107136)
+++ trunk/Source/WebCore/dom/Node.idl	2012-02-08 23:14:46 UTC (rev 107137)
@@ -21,7 +21,7 @@
 module core {
 
 interface [
-CustomHeader,
+JSCustomHeader,
 JSCustomMarkFunction,
 JSCustomPushEventHandlerScope,
 JSCustomIsReachable,


Modified: trunk/Source/WebCore/html/canvas/CanvasPixelArray.idl (107136 => 107137)

--- trunk/Source/WebCore/html/canvas/CanvasPixelArray.idl	2012-02-08 23:08:24 UTC (rev 107136)
+++ trunk/Source/WebCore/html/canvas/CanvasPixelArray.idl	2012-02-08 23:14:46 UTC (rev 107137)
@@ -30,7 +30,6 @@
 #if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT || defined(V8_BINDING)  V8_BINDING
 interface [
 OmitConstructor,
-CustomHeader,
 HasNumericIndexGetter,
 CustomIndexedSetter
 ] CanvasPixelArray {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107138] trunk/Tools

[kov]

Title: [107138] trunk/Tools








Revision 107138
Author k...@webkit.org
Date 2012-02-08 15:20:31 -0800 (Wed, 08 Feb 2012)


Log Message
[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118

* gtk/common.py:
(get_build_path): add comment to document changes done in r107098,
as requested by the reviewer and forgotten by me.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/common.py




Diff

Modified: trunk/Tools/ChangeLog (107137 => 107138)

--- trunk/Tools/ChangeLog	2012-02-08 23:14:46 UTC (rev 107137)
+++ trunk/Tools/ChangeLog	2012-02-08 23:20:31 UTC (rev 107138)
@@ -1,3 +1,12 @@
+2012-02-08  Gustavo Noronha Silva  g...@gnome.org
+
+[GTK] Fails to build docs with non-standard build directories
+https://bugs.webkit.org/show_bug.cgi?id=78118
+
+* gtk/common.py:
+(get_build_path): add comment to document changes done in r107098,
+as requested by the reviewer and forgotten by me.
+
 2012-02-08  Adam Barth  aba...@webkit.org
 
 Stop importing with_statement from the mysterious future


Modified: trunk/Tools/gtk/common.py (107137 => 107138)

--- trunk/Tools/gtk/common.py	2012-02-08 23:14:46 UTC (rev 107137)
+++ trunk/Tools/gtk/common.py	2012-02-08 23:20:31 UTC (rev 107138)
@@ -64,6 +64,11 @@
 if is_valid_build_directory(build_dir):
 return build_dir
 
+# Debian and Ubuntu build both flavours of the library (with gtk2
+# and with gtk3); they use directories build-2.0 and build-3.0 for
+# that, which is not handled by the above cases; we check that the
+# directory where we are called from is a valid build directory,
+# which should handle pretty much all other non-standard cases.
 build_dir = os.getcwd()
 if is_valid_build_directory(build_dir):
 return build_dir






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107139] trunk/Tools

[abarth]

Title: [107139] trunk/Tools








Revision 107139
Author aba...@webkit.org
Date 2012-02-08 15:26:32 -0800 (Wed, 08 Feb 2012)


Log Message
webkitpy still imports simplejson
https://bugs.webkit.org/show_bug.cgi?id=78161

Reviewed by Eric Seidel.

We no longer support Python 2.5, so we can rely upon Python's built-in
JSON package.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/resultsjsonparser.py:
* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
* Scripts/webkitpy/style/checkers/jsonchecker.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
trunk/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py
trunk/Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py
trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py




Diff

Modified: trunk/Tools/ChangeLog (107138 => 107139)

--- trunk/Tools/ChangeLog	2012-02-08 23:20:31 UTC (rev 107138)
+++ trunk/Tools/ChangeLog	2012-02-08 23:26:32 UTC (rev 107139)
@@ -1,3 +1,25 @@
+2012-02-08  Adam Barth  aba...@webkit.org
+
+webkitpy still imports simplejson
+https://bugs.webkit.org/show_bug.cgi?id=78161
+
+Reviewed by Eric Seidel.
+
+We no longer support Python 2.5, so we can rely upon Python's built-in
+JSON package.
+
+* Scripts/webkitpy/common/net/buildbot/buildbot.py:
+* Scripts/webkitpy/common/net/resultsjsonparser.py:
+* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
+* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
+* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
+* Scripts/webkitpy/layout_tests/models/test_expectations.py:
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+* Scripts/webkitpy/style/checkers/jsonchecker.py:
+* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
+* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
+* Scripts/webkitpy/tool/servers/reflectionhandler.py:
+
 2012-02-08  Gustavo Noronha Silva  g...@gnome.org
 
 [GTK] Fails to build docs with non-standard build directories


Modified: trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py (107138 => 107139)

--- trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py	2012-02-08 23:20:31 UTC (rev 107138)
+++ trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py	2012-02-08 23:26:32 UTC (rev 107139)
@@ -25,15 +25,8 @@
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-#
-# WebKit's Python module for interacting with WebKit's buildbot
 
-try:
-import json
-except ImportError:
-# python 2.5 compatibility
-import webkitpy.thirdparty.simplejson as json
-
+import json
 import operator
 import re
 import urllib


Modified: trunk/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py (107138 => 107139)

--- trunk/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py	2012-02-08 23:20:31 UTC (rev 107138)
+++ trunk/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py	2012-02-08 23:26:32 UTC (rev 107139)
@@ -27,11 +27,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 
-try:
-import json
-except ImportError:
-# python 2.5 compatibility
-import webkitpy.thirdparty.simplejson as json
+import json
 
 from webkitpy.common.memoized import memoized
 from webkitpy.common.system.deprecated_logging import log


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py (107138 => 107139)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py	2012-02-08 23:20:31 UTC (rev 107138)
+++ 

[webkit-changes] [107140] trunk/LayoutTests

[jchaffraix]

Title: [107140] trunk/LayoutTests








Revision 107140
Author jchaffr...@webkit.org
Date 2012-02-08 15:34:09 -0800 (Wed, 08 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
Updated this baseline. It looks like an opacity difference of 1 that we could't really explain.

* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120364-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug22019-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug23151-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56405-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
* platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Removed.
Rebaselined those tests on snowleopard as we started taking up the new snow-leopard baselines from r107122.

* platform/chromium/test_expectations.txt:
Mark compositing/iframes/scrolling-iframe.html as flaky as seen on a snow-leopard or windows (debug) bot near you.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120364-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug22019-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug23151-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56405-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_nowrap-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium/tables/mozilla/bugs/bug56405-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107139 => 107140)

--- trunk/LayoutTests/ChangeLog	2012-02-08 23:26:32 UTC (rev 107139)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 23:34:09 UTC (rev 107140)
@@ -2,6 +2,27 @@
 
 Unreviewed gardening.
 
+* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
+Updated this baseline. It looks like an opacity difference of 1 that we could't really explain.
+
+* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120364-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug22019-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug23151-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56405-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
+* platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Removed.
+Rebaselined those tests on snowleopard as we started taking up the new snow-leopard baselines from r107122.
+
+* platform/chromium/test_expectations.txt:
+Mark compositing/iframes/scrolling-iframe.html as flaky as seen on a snow-leopard or windows (debug) bot near you.
+
+2012-02-08  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
 * platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
 * platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
 Add those 2 new baselines.


Deleted: trunk/LayoutTests/platform/chromium/tables/mozilla/bugs/bug56405-expected.txt (107139 => 107140)

--- trunk/LayoutTests/platform/chromium/tables/mozilla/bugs/bug56405-expected.txt	2012-02-08 23:26:32 UTC (rev 107139)
+++ trunk/LayoutTests/platform/chromium/tables/mozilla/bugs/bug56405-expected.txt	2012-02-08 23:34:09 UTC (rev 107140)
@@ -1,15 +0,0 @@
-layer at (0,0) size 785x1136
-  RenderView at (0,0) size 785x600

[webkit-changes] [107141] trunk/Tools

[abarth]

Title: [107141] trunk/Tools








Revision 107141
Author aba...@webkit.org
Date 2012-02-08 15:35:29 -0800 (Wed, 08 Feb 2012)


Log Message
Remove simplejson because it's no longer used by webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78164

Reviewed by Eric Seidel.

All the importers of this code were removed in a previous patch.

* Scripts/webkitpy/thirdparty/simplejson: Removed.
* Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
* Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
* Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
* Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.

Modified Paths

trunk/Tools/ChangeLog


Removed Paths

trunk/Tools/Scripts/webkitpy/thirdparty/simplejson/




Diff

Modified: trunk/Tools/ChangeLog (107140 => 107141)

--- trunk/Tools/ChangeLog	2012-02-08 23:34:09 UTC (rev 107140)
+++ trunk/Tools/ChangeLog	2012-02-08 23:35:29 UTC (rev 107141)
@@ -1,5 +1,26 @@
 2012-02-08  Adam Barth  aba...@webkit.org
 
+Remove simplejson because it's no longer used by webkitpy
+https://bugs.webkit.org/show_bug.cgi?id=78164
+
+Reviewed by Eric Seidel.
+
+All the importers of this code were removed in a previous patch.
+
+* Scripts/webkitpy/thirdparty/simplejson: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
+* Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
+
+2012-02-08  Adam Barth  aba...@webkit.org
+
 webkitpy still imports simplejson
 https://bugs.webkit.org/show_bug.cgi?id=78161
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107144] trunk/Tools

[rniwa]

Title: [107144] trunk/Tools








Revision 107144
Author rn...@webkit.org
Date 2012-02-08 15:57:48 -0800 (Wed, 08 Feb 2012)


Log Message
Build fix attempt after r107053.

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (107143 => 107144)

--- trunk/Tools/ChangeLog	2012-02-08 23:48:18 UTC (rev 107143)
+++ trunk/Tools/ChangeLog	2012-02-08 23:57:48 UTC (rev 107144)
@@ -1,3 +1,10 @@
+2012-02-08  Ryosuke Niwa  rn...@webkit.org
+
+Build fix attempt after r107053.
+
+* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+(test_collect_tests):
+
 2012-02-08  Adam Barth  aba...@webkit.org
 
 Remove simplejson because it's no longer used by webkitpy


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (107143 => 107144)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-02-08 23:48:18 UTC (rev 107143)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py	2012-02-08 23:57:48 UTC (rev 107144)
@@ -316,7 +316,7 @@
 add_file('test1.html')
 add_file('test2.html')
 add_file('test3.html')
-runner._host.filesystem.chdir(runner._port.webkit_base())
+runner._host.filesystem.chdir(runner._port.perf_tests_dir()[:runner._port.perf_tests_dir().rfind(runner._host.filesystem.sep)])
 tests = [runner._port.relative_perf_test_filename(test) for test in runner._collect_tests()]
 self.assertEqual(sorted(tests), ['test1.html', 'test2.html'])
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107145] trunk/Tools

[abarth]

Title: [107145] trunk/Tools








Revision 107145
Author aba...@webkit.org
Date 2012-02-08 15:59:04 -0800 (Wed, 08 Feb 2012)


Log Message
Remove the ospath compat shim from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78170

Reviewed by Eric Seidel.

We no longer need this compat shim now that we don't support Python 2.5.

* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.relpath):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.relpath):
* Scripts/webkitpy/common/system/ospath.py: Removed.
* Scripts/webkitpy/common/system/ospath_unittest.py: Removed.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py
trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py


Removed Paths

trunk/Tools/Scripts/webkitpy/common/system/ospath.py
trunk/Tools/Scripts/webkitpy/common/system/ospath_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (107144 => 107145)

--- trunk/Tools/ChangeLog	2012-02-08 23:57:48 UTC (rev 107144)
+++ trunk/Tools/ChangeLog	2012-02-08 23:59:04 UTC (rev 107145)
@@ -1,3 +1,21 @@
+2012-02-08  Adam Barth  aba...@webkit.org
+
+Remove the ospath compat shim from webkitpy
+https://bugs.webkit.org/show_bug.cgi?id=78170
+
+Reviewed by Eric Seidel.
+
+We no longer need this compat shim now that we don't support Python 2.5.
+
+* Scripts/webkitpy/common/checkout/scm/git.py:
+* Scripts/webkitpy/common/checkout/scm/svn.py:
+* Scripts/webkitpy/common/system/filesystem.py:
+(FileSystem.relpath):
+* Scripts/webkitpy/common/system/filesystem_mock.py:
+(MockFileSystem.relpath):
+* Scripts/webkitpy/common/system/ospath.py: Removed.
+* Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
+
 2012-02-08  Ryosuke Niwa  rn...@webkit.org
 
 Build fix attempt after r107053.


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py (107144 => 107145)

--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py	2012-02-08 23:57:48 UTC (rev 107144)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py	2012-02-08 23:59:04 UTC (rev 107145)
@@ -34,7 +34,6 @@
 from webkitpy.common.memoized import memoized
 from webkitpy.common.system.deprecated_logging import log
 from webkitpy.common.system.executive import Executive, ScriptError
-from webkitpy.common.system import ospath
 
 from .commitmessage import CommitMessage
 from .scm import AuthenticationError, SCM, commit_error_handler


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py (107144 => 107145)

--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py	2012-02-08 23:57:48 UTC (rev 107144)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py	2012-02-08 23:59:04 UTC (rev 107145)
@@ -36,7 +36,6 @@
 from webkitpy.common.memoized import memoized
 from webkitpy.common.system.deprecated_logging import log
 from webkitpy.common.system.executive import Executive, ScriptError
-from webkitpy.common.system import ospath
 
 from .scm import AuthenticationError, SCM, commit_error_handler
 


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem.py (107144 => 107145)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem.py	2012-02-08 23:57:48 UTC (rev 107144)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem.py	2012-02-08 23:59:04 UTC (rev 107145)
@@ -39,8 +39,6 @@
 import tempfile
 import time
 
-from webkitpy.common.system import ospath
-
 class FileSystem(object):
 FileSystem interface for webkitpy.
 
@@ -227,7 +225,7 @@
 return hashlib.sha1(contents).hexdigest()
 
 def relpath(self, path, start='.'):
-return ospath.relpath(path, start)
+return os.path.relpath(path, start)
 
 class _WindowsError(exceptions.OSError):
 Fake exception for Linux and Mac.


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (107144 => 107145)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2012-02-08 23:57:48 UTC (rev 107144)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2012-02-08 23:59:04 UTC (rev 107145)
@@ -33,7 +33,6 @@
 import re
 
 from webkitpy.common.system import path
-from webkitpy.common.system import ospath
 
 
 class MockFileSystem(object):
@@ -303,8 +302,34 @@
 return hashlib.sha1(contents).hexdigest()
 
 def relpath(self, path, start='.'):
-return ospath.relpath(path, start, self.abspath, self.sep)
+# Since os.path.relpath() calls os.path.normpath()
+# (see http://docs.python.org/library/os.path.html#os.path.abspath )
+# it also removes trailing slashes and converts forward and backward
+# slashes to the preferred slash os.sep.
+start = self.abspath(start)
+path 

[webkit-changes] [107146] trunk/Source/WebCore

[leo . yang]

Title: [107146] trunk/Source/WebCore








Revision 107146
Author leo.y...@torchmobile.com.cn
Date 2012-02-08 16:04:09 -0800 (Wed, 08 Feb 2012)


Log Message
REGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78088

Reviewed by Antonio Gomes.

WebCore::getDOMObjectWrapper was changed to WebCore::wrap in r84194.
Adapt to this change in JSEntryCustom.cpp and JSEntrySyncCustom.cpp.

Build fix, no new tests.

* bindings/js/JSEntryCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEntrySyncCustom.cpp:
(WebCore::toJS):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSEntryCustom.cpp
trunk/Source/WebCore/bindings/js/JSEntrySyncCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107145 => 107146)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 23:59:04 UTC (rev 107145)
+++ trunk/Source/WebCore/ChangeLog	2012-02-09 00:04:09 UTC (rev 107146)
@@ -1,3 +1,20 @@
+2012-02-08  Leo Yang  leo.y...@torchmobile.com.cn
+
+REGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM
+https://bugs.webkit.org/show_bug.cgi?id=78088
+
+Reviewed by Antonio Gomes.
+
+WebCore::getDOMObjectWrapper was changed to WebCore::wrap in r84194.
+Adapt to this change in JSEntryCustom.cpp and JSEntrySyncCustom.cpp.
+
+Build fix, no new tests.
+
+* bindings/js/JSEntryCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSEntrySyncCustom.cpp:
+(WebCore::toJS):
+
 2012-02-08  Dana Jansens  dan...@chromium.org
 
 [Chromium] Fix opaque tracking for box shadows and non-composited child elements


Modified: trunk/Source/WebCore/bindings/js/JSEntryCustom.cpp (107145 => 107146)

--- trunk/Source/WebCore/bindings/js/JSEntryCustom.cpp	2012-02-08 23:59:04 UTC (rev 107145)
+++ trunk/Source/WebCore/bindings/js/JSEntryCustom.cpp	2012-02-09 00:04:09 UTC (rev 107146)
@@ -50,10 +50,10 @@
 return jsNull();
 
 if (entry-isFile())
-return getDOMObjectWrapperJSFileEntry(exec, globalObject, static_castFileEntry*(entry));
+return wrapJSFileEntry(exec, globalObject, static_castFileEntry*(entry));
 
 ASSERT(entry-isDirectory());
-return getDOMObjectWrapperJSDirectoryEntry(exec, globalObject, static_castDirectoryEntry*(entry));
+return wrapJSDirectoryEntry(exec, globalObject, static_castDirectoryEntry*(entry));
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/bindings/js/JSEntrySyncCustom.cpp (107145 => 107146)

--- trunk/Source/WebCore/bindings/js/JSEntrySyncCustom.cpp	2012-02-08 23:59:04 UTC (rev 107145)
+++ trunk/Source/WebCore/bindings/js/JSEntrySyncCustom.cpp	2012-02-09 00:04:09 UTC (rev 107146)
@@ -50,10 +50,10 @@
 return jsNull();
 
 if (entry-isFile())
-return getDOMObjectWrapperJSFileEntrySync(exec, globalObject, static_castFileEntrySync*(entry));
+return wrapJSFileEntrySync(exec, globalObject, static_castFileEntrySync*(entry));
 
 ASSERT(entry-isDirectory());
-return getDOMObjectWrapperJSDirectoryEntrySync(exec, globalObject, static_castDirectoryEntrySync*(entry));
+return wrapJSDirectoryEntrySync(exec, globalObject, static_castDirectoryEntrySync*(entry));
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107147] trunk/Tools

[abarth]

Title: [107147] trunk/Tools








Revision 107147
Author aba...@webkit.org
Date 2012-02-08 16:10:04 -0800 (Wed, 08 Feb 2012)


Log Message
Don't re-implement ZipFile.extractall
https://bugs.webkit.org/show_bug.cgi?id=78173

Reviewed by Eric Seidel.

We can use ZipFile.extractall now that we don't support Python 2.5.

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._extract_targz):
(AutoInstaller._unzip):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py




Diff

Modified: trunk/Tools/ChangeLog (107146 => 107147)

--- trunk/Tools/ChangeLog	2012-02-09 00:04:09 UTC (rev 107146)
+++ trunk/Tools/ChangeLog	2012-02-09 00:10:04 UTC (rev 107147)
@@ -1,5 +1,18 @@
 2012-02-08  Adam Barth  aba...@webkit.org
 
+Don't re-implement ZipFile.extractall
+https://bugs.webkit.org/show_bug.cgi?id=78173
+
+Reviewed by Eric Seidel.
+
+We can use ZipFile.extractall now that we don't support Python 2.5.
+
+* Scripts/webkitpy/common/system/autoinstall.py:
+(AutoInstaller._extract_targz):
+(AutoInstaller._unzip):
+
+2012-02-08  Adam Barth  aba...@webkit.org
+
 Remove the ospath compat shim from webkitpy
 https://bugs.webkit.org/show_bug.cgi?id=78170
 


Modified: trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py (107146 => 107147)

--- trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py	2012-02-09 00:04:09 UTC (rev 107146)
+++ trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py	2012-02-09 00:10:04 UTC (rev 107147)
@@ -259,43 +259,6 @@
 
 return target_path
 
-# This is a replacement for ZipFile.extractall(), which is
-# available in Python 2.6 but not in earlier versions.
-def _extract_all(self, zip_file, target_dir):
-self._log_transfer(Extracting zip file..., zip_file, target_dir)
-
-# This is helpful for debugging purposes.
-_log.debug(Listing zip file contents...)
-for name in zip_file.namelist():
-_log.debug('* %s' % name)
-
-for name in zip_file.namelist():
-path = os.path.join(target_dir, name)
-self._log_transfer(Extracting..., name, path)
-
-if not os.path.basename(path):
-# Then the path ends in a slash, so it is a directory.
-self._create_directory(path)
-continue
-# Otherwise, it is a file.
-
-try:
-# We open this file w/o encoding, as we're reading/writing
-# the raw byte-stream from the zip file.
-outfile = open(path, 'wb')
-except IOError, err:
-# Not all zip files seem to list the directories explicitly,
-# so try again after creating the containing directory.
-_log.debug(Got IOError: retrying after creating directory...)
-dir = os.path.dirname(path)
-self._create_directory(dir)
-outfile = open(path, 'wb')
-
-try:
-outfile.write(zip_file.read(name))
-finally:
-outfile.close()
-
 def _unzip(self, path, scratch_dir):
 # zipfile.extractall() extracts to a path without the
 # trailing .zip.
@@ -313,7 +276,7 @@
 raise Exception(message)
 
 try:
-self._extract_all(zip_file, scratch_dir)
+zip_file.extractall(scratch_dir)
 finally:
 zip_file.close()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107148] trunk/Source/WebCore

[haraken]

Title: [107148] trunk/Source/WebCore








Revision 107148
Author hara...@chromium.org
Date 2012-02-08 16:21:20 -0800 (Wed, 08 Feb 2012)


Log Message
Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
it to [ObjCImplementedAsUnsignedLong]
https://bugs.webkit.org/show_bug.cgi?id=78100

Reviewed by Eric Seidel.

Now [ConvertToString] is used by ObjC's HTMLElement.size only.
This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec
says HTMLInputElement.size should be unsigned long.
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
trunk/Source/WebCore/html/HTMLInputElement.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (107147 => 107148)

--- trunk/Source/WebCore/ChangeLog	2012-02-09 00:10:04 UTC (rev 107147)
+++ trunk/Source/WebCore/ChangeLog	2012-02-09 00:21:20 UTC (rev 107148)
@@ -1,3 +1,25 @@
+2012-02-08  Kentaro Hara  hara...@chromium.org
+
+Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
+it to [ObjCImplementedAsUnsignedLong]
+https://bugs.webkit.org/show_bug.cgi?id=78100
+
+Reviewed by Eric Seidel.
+
+Now [ConvertToString] is used by ObjC's HTMLElement.size only.
+This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
+and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorCPP.pm:
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorObjC.pm:
+(GenerateImplementation):
+* html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec
+says HTMLInputElement.size should be unsigned long.
+(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)
+
 2012-02-08  Leo Yang  leo.y...@torchmobile.com.cn
 
 REGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm (107147 => 107148)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm	2012-02-09 00:10:04 UTC (rev 107147)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm	2012-02-09 00:21:20 UTC (rev 107148)
@@ -748,11 +748,6 @@
 my $argName = new . ucfirst($attributeName);
 my $arg = GetCPPTypeGetter($argName, $idlType);
 
-# The definition of ConvertToString is flipped for the setter
-if ($attribute-signature-extendedAttributes-{ConvertToString}) {
-$arg = WTF::String($arg).toInt();
-}
-
 my $attributeType = GetCPPType($attribute-signature-type, 1);
 push(@implContent, void $className\:\:$setterName($attributeType $argName)\n);
 push(@implContent, {\n);


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (107147 => 107148)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm	2012-02-09 00:10:04 UTC (rev 107147)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm	2012-02-09 00:21:20 UTC (rev 107148)
@@ -1257,7 +1257,7 @@
 }
 }
 $implIncludes{DOMPrivate.h} = 1;
-} elsif ($attribute-signature-extendedAttributes-{ConvertToString}) {
+} elsif ($attribute-signature-extendedAttributes-{ObjCImplementedAsUnsignedLong}) {
 $getterContentHead = WTF::String::number( . $getterContentHead;
 $getterContentTail .= );
 } elsif ($idlType eq Date) {
@@ -1384,8 +1384,8 @@
 my $argName = new . ucfirst($attributeInterfaceName);
 my $arg = GetObjCTypeGetter($argName, $idlType);
 
-# The definition of ConvertToString is flipped for the setter
-if ($attribute-signature-extendedAttributes-{ConvertToString}) {
+# The definition of ObjCImplementedAsUnsignedLong is flipped for the setter
+if ($attribute-signature-extendedAttributes-{ObjCImplementedAsUnsignedLong}) {
 $arg = WTF::String($arg).toInt();
 }
 


Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (107147 => 107148)

--- trunk/Source/WebCore/html/HTMLInputElement.idl	2012-02-09 00:10:04 UTC (rev 107147)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl	2012-02-09 00:21:20 UTC (rev 107148)
@@ -50,10 +50,9 @@
 attribute [Reflect] boolean 

[webkit-changes] [107149] trunk/Source/WebCore

[adamk]

Title: [107149] trunk/Source/WebCore








Revision 107149
Author ad...@chromium.org
Date 2012-02-08 16:24:07 -0800 (Wed, 08 Feb 2012)


Log Message
Simplify and correct mutation delivery timing for JSC
https://bugs.webkit.org/show_bug.cgi?id=78172

Reviewed by Adam Barth.

Instead of keeping a static recursion counter in JSMainThreadExecState,
simply wait for a state change from non-null ExecState to null ExecState.
Because s_mainThreadState is initially null, this equivalent to
waiting for s_recursionLevel to rewind to zero.

This also properly handles the usage of JSMainThreadNullState (and
does not do mutation delivery), since that class is only used by
non-JS bindings. Now fast/mutation/end-of-task-delivery.html properly
fails, whereas it was passing before due to usage of the ObjC DOM API
from DumpRenderTree.

* bindings/js/JSMainThreadExecState.cpp:
(WebCore):
* bindings/js/JSMainThreadExecState.h: Added a comment explaining the purpose of JSMainThreadNullState.
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSMainThreadExecState.cpp
trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107148 => 107149)

--- trunk/Source/WebCore/ChangeLog	2012-02-09 00:21:20 UTC (rev 107148)
+++ trunk/Source/WebCore/ChangeLog	2012-02-09 00:24:07 UTC (rev 107149)
@@ -1,3 +1,29 @@
+2012-02-08  Adam Klein  ad...@chromium.org
+
+Simplify and correct mutation delivery timing for JSC
+https://bugs.webkit.org/show_bug.cgi?id=78172
+
+Reviewed by Adam Barth.
+
+Instead of keeping a static recursion counter in JSMainThreadExecState,
+simply wait for a state change from non-null ExecState to null ExecState.
+Because s_mainThreadState is initially null, this equivalent to
+waiting for s_recursionLevel to rewind to zero.
+
+This also properly handles the usage of JSMainThreadNullState (and
+does not do mutation delivery), since that class is only used by
+non-JS bindings. Now fast/mutation/end-of-task-delivery.html properly
+fails, whereas it was passing before due to usage of the ObjC DOM API
+from DumpRenderTree.
+
+* bindings/js/JSMainThreadExecState.cpp:
+(WebCore):
+* bindings/js/JSMainThreadExecState.h: Added a comment explaining the purpose of JSMainThreadNullState.
+(WebCore::JSMainThreadExecState::JSMainThreadExecState):
+(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
+(JSMainThreadExecState):
+(WebCore):
+
 2012-02-08  Kentaro Hara  hara...@chromium.org
 
 Remove [ConvertToString] from CodeGeneratorCPP.pm and rename


Modified: trunk/Source/WebCore/bindings/js/JSMainThreadExecState.cpp (107148 => 107149)

--- trunk/Source/WebCore/bindings/js/JSMainThreadExecState.cpp	2012-02-09 00:21:20 UTC (rev 107148)
+++ trunk/Source/WebCore/bindings/js/JSMainThreadExecState.cpp	2012-02-09 00:24:07 UTC (rev 107149)
@@ -32,8 +32,6 @@
 JSC::ExecState* JSMainThreadExecState::s_mainThreadState = 0;
 
 #if ENABLE(MUTATION_OBSERVERS)
-int JSMainThreadExecState::s_recursionLevel = 0;
-
 void JSMainThreadExecState::didLeaveScriptContext()
 {
 WebKitMutationObserver::deliverAllMutations();


Modified: trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h (107148 => 107149)

--- trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h	2012-02-09 00:21:20 UTC (rev 107148)
+++ trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h	2012-02-09 00:24:07 UTC (rev 107149)
@@ -91,21 +91,20 @@
 {
 ASSERT(isMainThread());
 s_mainThreadState = exec;
-
-#if ENABLE(MUTATION_OBSERVERS)
-ASSERT(s_recursionLevel = 0);
-++s_recursionLevel;
-#endif
 };
 
 ~JSMainThreadExecState()
 {
 ASSERT(isMainThread());
+
+#if ENABLE(MUTATION_OBSERVERS)
+bool didExitJavaScript = s_mainThreadState  !m_previousState;
+#endif
+
 s_mainThreadState = m_previousState;
 
 #if ENABLE(MUTATION_OBSERVERS)
-ASSERT(s_recursionLevel  0);
-if (!--s_recursionLevel)
+if (didExitJavaScript)
 didLeaveScriptContext();
 #endif
 }
@@ -116,11 +115,11 @@
 
 #if ENABLE(MUTATION_OBSERVERS)
 static void didLeaveScriptContext();
-static int s_recursionLevel;
 #endif
 };
 
 // Null state prevents origin security checks.
+// Used by non-_javascript_ bindings (ObjC, GObject).
 class JSMainThreadNullState : private JSMainThreadExecState {
 public:
 explicit JSMainThreadNullState() : JSMainThreadExecState(0) {};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes