[webkit-changes] [108963] trunk/Source/WebKit/blackberry
Title: [108963] trunk/Source/WebKit/blackberry
Revision 108963
Author leo.y...@torchmobile.com.cn
Date 2012-02-27 00:27:54 -0800 (Mon, 27 Feb 2012)
Log Message
[BlackBerry] Upstream accelerated compositing helper class
https://bugs.webkit.org/show_bug.cgi?id=78448
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
* WebKitSupport/FrameLayers.cpp: Added.
* WebKitSupport/FrameLayers.h: Added.
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
Added Paths
trunk/Source/WebKit/blackberry/WebKitSupport/FrameLayers.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/FrameLayers.h
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (108962 => 108963)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-02-27 07:50:54 UTC (rev 108962)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-02-27 08:27:54 UTC (rev 108963)
@@ -1,3 +1,15 @@
+2012-02-27 Leo Yang leo.y...@torchmobile.com.cn
+
+[BlackBerry] Upstream accelerated compositing helper class
+https://bugs.webkit.org/show_bug.cgi?id=78448
+
+Reviewed by Antonio Gomes.
+
+Initial upstream, no new tests.
+
+* WebKitSupport/FrameLayers.cpp: Added.
+* WebKitSupport/FrameLayers.h: Added.
+
2012-02-26 Hajime Morrita morr...@chromium.org
Move ChromeClient::showContextMenu() to ContextMenuClient
Added: trunk/Source/WebKit/blackberry/WebKitSupport/FrameLayers.cpp (0 => 108963)
--- trunk/Source/WebKit/blackberry/WebKitSupport/FrameLayers.cpp (rev 0)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/FrameLayers.cpp 2012-02-27 08:27:54 UTC (rev 108963)
@@ -0,0 +1,125 @@
+/*
+ * Copyright (C) 2010, 2011, 2012 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include config.h
+
+#if USE(ACCELERATED_COMPOSITING)
+#include FrameLayers.h
+
+#include Frame.h
+#include FrameView.h
+#include LayerWebKitThread.h
+#include Page.h
+#include RenderPart.h
+#include WebPage_p.h
+#include wtf/Assertions.h
+
+using namespace WebCore;
+
+namespace BlackBerry {
+namespace WebKit {
+
+static FloatSize frameLayerAbsoluteOffset(Frame* frame)
+{
+ASSERT(frame);
+
+if (!frame-view() || !frame-page() || !frame-page()-mainFrame() || !frame-page()-mainFrame()-view())
+return FloatSize();
+
+IntPoint offset = frame-page()-mainFrame()-view()-windowToContents(frame-view()-contentsToWindow(IntPoint::zero()));
+return FloatSize(offset.x(), offset.y());
+}
+
+FrameLayers::FrameLayers(WebPagePrivate* page)
+: m_pagePrivate(page)
+, m_rootGraphicsLayer()
+, m_rootLayer(0)
+{
+}
+
+FrameLayers::~FrameLayers()
+{
+m_frameLayers.clear();
+}
+
+bool FrameLayers::containsLayerForFrame(Frame* frame)
+{
+ASSERT(frame);
+return m_frameLayers.contains(frame);
+}
+
+void FrameLayers::addLayer(Frame* frame, LayerWebKitThread* layer)
+{
+// If we have main frame layer we don't accept other layers.
+// This should not happen actually.
+ASSERT(frame != m_pagePrivate-m_mainFrame || !isRootLayerMainFrameLayer());
+if (frame == m_pagePrivate-m_mainFrame isRootLayerMainFrameLayer())
+return;
+
+ASSERT(frame layer !m_frameLayers.contains(frame));
+
+m_frameLayers.add(frame, layer);
+
+calculateRootLayer();
+if (!m_rootLayer) {
+ASSERT(!m_rootGraphicsLayer);
+m_rootGraphicsLayer = GraphicsLayer::create(0);
+m_rootLayer = m_rootGraphicsLayer-platformLayer();
+}
+
+if (m_rootLayer != layer)
+m_rootLayer-addSublayer(layer);
+}
+
+void FrameLayers::removeLayerByFrame(Frame* frame)
+{
+ASSERT(frame);
+FrameLayerMap::iterator it = m_frameLayers.find(frame);
+if (it != m_frameLayers.end()) {
+LayerWebKitThread* layer = it-second;
+if (layer-superlayer())
+layer-removeFromSuperlayer();
+m_frameLayers.remove(it);
+calculateRootLayer();
+}
+}
+
+void FrameLayers::commitOnWebKitThread(double scale)
+{
+ASSERT(m_rootLayer);
+if (!isRootLayerMainFrameLayer()) {
+for (FrameLayerMap::iterator it = m_frameLayers.begin(); it != m_frameLayers.end(); ++it)
+it-second-setAbsoluteOffset(frameLayerAbsoluteOffset(it-first));
+}
+
[webkit-changes] [108964] trunk/LayoutTests
Title: [108964] trunk/LayoutTests Revision 108964 Author o...@webkit.org Date 2012-02-27 00:40:13 -0800 (Mon, 27 Feb 2012) Log Message [Qt] Unreviewed gardening, skip the following crashing svg test. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (108963 => 108964) --- trunk/LayoutTests/ChangeLog 2012-02-27 08:27:54 UTC (rev 108963) +++ trunk/LayoutTests/ChangeLog 2012-02-27 08:40:13 UTC (rev 108964) @@ -1,3 +1,9 @@ +2012-02-27 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening, skip the following crashing svg test. + +* platform/qt/Skipped: + 2012-02-26 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening, skip new failing and crashing tests to paint the bots green. Modified: trunk/LayoutTests/platform/qt/Skipped (108963 => 108964) --- trunk/LayoutTests/platform/qt/Skipped 2012-02-27 08:27:54 UTC (rev 108963) +++ trunk/LayoutTests/platform/qt/Skipped 2012-02-27 08:40:13 UTC (rev 108964) @@ -1426,6 +1426,7 @@ # [Qt] svg/zoom/page/zoom-svg-float-border-padding.xml crashes # https://bugs.webkit.org/show_bug.cgi?id=79631 svg/zoom/page/zoom-svg-float-border-padding.xml +svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml # = # # Failing CSS Tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108966] trunk/Source/WebCore
Title: [108966] trunk/Source/WebCore
Revision 108966
Author pfeld...@chromium.org
Date 2012-02-27 00:51:14 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518
Patch by Dan Beam db...@chromium.org on 2012-02-27
Reviewed by Pavel Feldman.
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TabbedPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (108965 => 108966)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 08:42:23 UTC (rev 108965)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 08:51:14 UTC (rev 108966)
@@ -1,3 +1,14 @@
+2012-02-27 Dan Beam db...@chromium.org
+
+Web Inspector: Close TabbedPanes on middle click of tab handle
+https://bugs.webkit.org/show_bug.cgi?id=79518
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TabbedPane.js:
+(WebInspector.TabbedPaneTab.prototype._createTabElement):
+(WebInspector.TabbedPaneTab.prototype._tabClicked):
+
2012-02-26 Yury Semikhatsky yu...@chromium.org
Web Inspector: crash in fake workers
Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (108965 => 108966)
--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-02-27 08:42:23 UTC (rev 108965)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-02-27 08:51:14 UTC (rev 108966)
@@ -596,9 +596,7 @@
tabElement.addStyleClass(measuring);
else {
this._tabElement = tabElement;
-tabElement.addEventListener(click, this._tabSelected.bind(this), false);
-if (this._closeable)
-closeButtonSpan.addEventListener(click, this._tabClosed.bind(this), false);
+tabElement.addEventListener(click, this._tabClicked.bind(this), false);
}
return tabElement;
@@ -612,13 +610,14 @@
this._measureElement.removeChild(measuringTabElement);
},
-_tabSelected: function()
+/**
+ * @param {Event} event
+ */
+_tabClicked: function(event)
{
-this._tabbedPane.selectTab(this.id, true);
-},
-
-_tabClosed: function()
-{
-this._tabbedPane.closeTab(this.id, true);
+if (this._closeable (event.button === 1 || event.target.hasStyleClass(tabbed-pane-header-tab-close-button)))
+this._tabbedPane.closeTab(this.id, true);
+else
+this._tabbedPane.selectTab(this.id, true);
}
-}
\ No newline at end of file
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108967] trunk/Source/WebCore
Title: [108967] trunk/Source/WebCore
Revision 108967
Author yu...@chromium.org
Date 2012-02-27 01:00:40 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: counter graphs should resize after console showing
https://bugs.webkit.org/show_bug.cgi?id=79640
Invoke Panel.doResize after showing drawer.
Reviewed by Pavel Feldman.
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Drawer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (108966 => 108967)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 08:51:14 UTC (rev 108966)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 09:00:40 UTC (rev 108967)
@@ -1,3 +1,16 @@
+2012-02-27 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: counter graphs should resize after console showing
+https://bugs.webkit.org/show_bug.cgi?id=79640
+
+Invoke Panel.doResize after showing drawer.
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/Drawer.js:
+(WebInspector.Drawer.prototype.show.animationFinished):
+(WebInspector.Drawer.prototype.show):
+
2012-02-27 Dan Beam db...@chromium.org
Web Inspector: Close TabbedPanes on middle click of tab handle
Modified: trunk/Source/WebCore/inspector/front-end/Drawer.js (108966 => 108967)
--- trunk/Source/WebCore/inspector/front-end/Drawer.js 2012-02-27 08:51:14 UTC (rev 108966)
+++ trunk/Source/WebCore/inspector/front-end/Drawer.js 2012-02-27 09:00:40 UTC (rev 108967)
@@ -123,7 +123,7 @@
function animationFinished()
{
-WebInspector.inspectorView.currentPanel().statusBarResized();
+WebInspector.inspectorView.currentPanel().doResize();
if (this._view this._view.afterShow)
this._view.afterShow();
delete this._currentAnimation;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108968] trunk/LayoutTests
Title: [108968] trunk/LayoutTests Revision 108968 Author ba...@chromium.org Date 2012-02-27 01:08:25 -0800 (Mon, 27 Feb 2012) Log Message [Chromium] Unreviewed test expectations update. https://bugs.webkit.org/show_bug.cgi?id=79642 Following tests time out: - accessibility/aria-describedby-on-input.html - fast/loader/subresource-willSendRequest-null.html - http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html - media/video-playbackrate.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (108967 => 108968) --- trunk/LayoutTests/ChangeLog 2012-02-27 09:00:40 UTC (rev 108967) +++ trunk/LayoutTests/ChangeLog 2012-02-27 09:08:25 UTC (rev 108968) @@ -1,3 +1,16 @@ +2012-02-27 Kenichi Ishibashi ba...@chromium.org + +[Chromium] Unreviewed test expectations update. +https://bugs.webkit.org/show_bug.cgi?id=79642 + +Following tests time out: +- accessibility/aria-describedby-on-input.html +- fast/loader/subresource-willSendRequest-null.html +- http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html +- media/video-playbackrate.html + +* platform/chromium/test_expectations.txt: + 2012-02-27 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening, skip the following crashing svg test. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (108967 => 108968) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 09:00:40 UTC (rev 108967) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 09:08:25 UTC (rev 108968) @@ -2379,7 +2379,7 @@ BUGCR65012 LINUX : fast/dom/HTMLHeadElement/head-check.html = PASS CRASH -BUGWK70878 LINUX : http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html = PASS TIMEOUT +BUGWK70878 : http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html = PASS TIMEOUT BUGWK73538 WIN : http/tests/xmlhttprequest/chunked-progress-event-expectedLength.html = TEXT // Flaky failures @@ -4226,3 +4226,7 @@ BUGWK79613 WIN : svg/carto.net/scrollbar.svg = TEXT BUGWK79613 WIN : svg/carto.net/selectionlist.svg = TEXT + +BUGWK79642 : accessibility/aria-describedby-on-input.html = TIMEOUT +BUGWK79642 : fast/loader/subresource-willSendRequest-null.html = TIMEOUT +BUGWK79642 : media/video-playbackrate.html = TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108969] trunk/LayoutTests
Title: [108969] trunk/LayoutTests Revision 108969 Author ba...@chromium.org Date 2012-02-27 01:16:40 -0800 (Mon, 27 Feb 2012) Log Message [Chromium] Unreviewed test expectaion update. * platform/chromium/test_expectations.txt: Changed expectation for http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (108968 => 108969) --- trunk/LayoutTests/ChangeLog 2012-02-27 09:08:25 UTC (rev 108968) +++ trunk/LayoutTests/ChangeLog 2012-02-27 09:16:40 UTC (rev 108969) @@ -1,5 +1,11 @@ 2012-02-27 Kenichi Ishibashi ba...@chromium.org +[Chromium] Unreviewed test expectaion update. + +* platform/chromium/test_expectations.txt: Changed expectation for http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html. + +2012-02-27 Kenichi Ishibashi ba...@chromium.org + [Chromium] Unreviewed test expectations update. https://bugs.webkit.org/show_bug.cgi?id=79642 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (108968 => 108969) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 09:08:25 UTC (rev 108968) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 09:16:40 UTC (rev 108969) @@ -1183,7 +1183,7 @@ BUGCR30536 : http/tests/misc/favicon-as-image.html = FAIL // Has failed for Chromium since it was first checked in. (Lighttpd related?) -BUGCR10323 WIN : http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html = FAIL +BUGCR10323 WIN : http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html = TEXT TIMEOUT // Post-MERGE failures: these will all need to be fixed one day ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108972] trunk/Source/WebCore
Title: [108972] trunk/Source/WebCore
Revision 108972
Author ca...@chromium.org
Date 2012-02-27 01:44:02 -0800 (Mon, 27 Feb 2012)
Log Message
Use built-in bind in ExtensionAPI.js
Web Inspector: [Extensions API] get rid of custom bind() in favor of built-in
https://bugs.webkit.org/show_bug.cgi?id=79570
Reviewed by Pavel Feldman.
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(injectedExtensionAPI):
(injectedExtensionAPI.Panels.prototype.create):
(injectedExtensionAPI.AuditResultImpl):
(injectedExtensionAPI.ExtensionServerClient):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (108971 => 108972)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 09:27:18 UTC (rev 108971)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 09:44:02 UTC (rev 108972)
@@ -1,3 +1,19 @@
+2012-02-27 Andrey Kosyakov ca...@chromium.org
+
+Use built-in bind in ExtensionAPI.js
+
+Web Inspector: [Extensions API] get rid of custom bind() in favor of built-in
+https://bugs.webkit.org/show_bug.cgi?id=79570
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ExtensionAPI.js:
+(injectedExtensionAPI.EventSinkImpl.prototype.addListener):
+(injectedExtensionAPI):
+(injectedExtensionAPI.Panels.prototype.create):
+(injectedExtensionAPI.AuditResultImpl):
+(injectedExtensionAPI.ExtensionServerClient):
+
2012-02-21 Pavel Podivilov podivi...@chromium.org
Web Inspector: get rid of RawSourceCode.sourceMapping getter.
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js (108971 => 108972)
--- trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2012-02-27 09:27:18 UTC (rev 108971)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2012-02-27 09:44:02 UTC (rev 108972)
@@ -125,7 +125,7 @@
if (this._listeners.length === 0)
extensionServer.sendRequest({ command: commands.Subscribe, type: this._type });
this._listeners.push(callback);
-extensionServer.registerHandler(notify- + this._type, bind(this._dispatch, this));
+extensionServer.registerHandler(notify- + this._type, this._dispatch.bind(this));
},
removeListener: function(callback)
@@ -279,7 +279,7 @@
return panels[name];
}
for (var panel in panels)
-this.__defineGetter__(panel, bind(panelGetter, null, panel));
+this.__defineGetter__(panel, panelGetter.bind(null, panel));
}
Panels.prototype = {
@@ -293,7 +293,7 @@
icon: icon,
page: page
};
-extensionServer.sendRequest(request, callback bind(callback, this, new ExtensionPanel(id)));
+extensionServer.sendRequest(request, callback callback.bind(this, new ExtensionPanel(id)));
},
setOpenResourceHandler: function(callback)
@@ -495,9 +495,9 @@
{
this._id = id;
-this.createURL = bind(this._nodeFactory, null, url);
-this.createSnippet = bind(this._nodeFactory, null, snippet);
-this.createText = bind(this._nodeFactory, null, text);
+this.createURL = this._nodeFactory.bind(null, url);
+this.createSnippet = this._nodeFactory.bind(null, snippet);
+this.createText = this._nodeFactory.bind(null, text);
}
AuditResultImpl.prototype = {
@@ -677,11 +677,11 @@
this._lastRequestId = 0;
this._lastObjectId = 0;
-this.registerHandler(callback, bind(this._onCallback, this));
+this.registerHandler(callback, this._onCallback.bind(this));
var channel = new MessageChannel();
this._port = channel.port1;
-this._port.addEventListener(message, bind(this._onMessage, this), false);
+this._port.addEventListener(message, this._onMessage.bind(this), false);
this._port.start();
top.postMessage(registerExtension, [ channel.port2 ], *);
@@ -740,15 +740,6 @@
}
}
-/**
- * @param {...*} vararg
- */
-function bind(func, thisObject, vararg)
-{
-var args = Array.prototype.slice.call(arguments, 2);
-return function() { return func.apply(thisObject, args.concat(Array.prototype.slice.call(arguments, 0))); };
-}
-
function populateInterfaceClass(interface, implementation)
{
for (var member in implementation) {
@@ -761,9 +752,9 @@
if (!descriptor)
continue;
if (typeof descriptor.value === function)
-interface[member] = bind(descriptor.value, implementation);
+interface[member] = descriptor.value.bind(implementation);
else if (typeof descriptor.get === function)
-interface.__defineGetter__(member, bind(descriptor.get, implementation));
+interface.__defineGetter__(member, descriptor.get.bind(implementation));
else
Object.defineProperty(interface, member, descriptor);
}
___
webkit-changes
[webkit-changes] [108973] trunk/LayoutTests
Title: [108973] trunk/LayoutTests Revision 108973 Author ba...@chromium.org Date 2012-02-27 02:01:36 -0800 (Mon, 27 Feb 2012) Log Message [Chromium] Unreviewed test expectations update. Following tests are flaky: - compositing/reflections/reflection-ordering.html - compositing/reflections/reflection-positioning.html - compositing/reflections/nested-reflection-transformed.html - compositing/reflections/nested-reflection-transformed2.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (108972 => 108973) --- trunk/LayoutTests/ChangeLog 2012-02-27 09:44:02 UTC (rev 108972) +++ trunk/LayoutTests/ChangeLog 2012-02-27 10:01:36 UTC (rev 108973) @@ -1,3 +1,15 @@ +2012-02-27 Kenichi Ishibashi ba...@chromium.org + +[Chromium] Unreviewed test expectations update. + +Following tests are flaky: +- compositing/reflections/reflection-ordering.html +- compositing/reflections/reflection-positioning.html +- compositing/reflections/nested-reflection-transformed.html +- compositing/reflections/nested-reflection-transformed2.html + +* platform/chromium/test_expectations.txt: + 2012-02-21 Pavel Podivilov podivi...@chromium.org Web Inspector: get rid of RawSourceCode.sourceMapping getter. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (108972 => 108973) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 09:44:02 UTC (rev 108972) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 10:01:36 UTC (rev 108973) @@ -2535,12 +2535,13 @@ BUGWK47949 LINUX WIN : compositing/reflections/reflection-opacity.html = IMAGE+TEXT // The following are flaky on Mac 10.6; occasionally the layers fail to show up. BUGWK47949 MAC : compositing/reflections/nested-reflection.html = IMAGE PASS -BUGWK47949 MAC : compositing/reflections/nested-reflection-transformed.html = IMAGE PASS +BUGWK47949 WIN MAC : compositing/reflections/nested-reflection-transformed.html = IMAGE PASS BUGWK47949 MAC : compositing/reflections/reflection-opacity.html = IMAGE PASS -BUGWK47949 MAC : compositing/reflections/reflection-positioning.html = IMAGE PASS -BUGWK74949 MAC : compositing/reflections/nested-reflection-transformed2.html = IMAGE PASS +BUGWK47949 : compositing/reflections/reflection-positioning.html = IMAGE PASS +BUGWK74949 WIN MAC : compositing/reflections/nested-reflection-transformed2.html = IMAGE PASS BUGWK47949 MAC : compositing/reflections/nested-reflection-transition.html = IMAGE PASS BUGWK47949 MAC : compositing/reflections/nested-reflection-size-change.html = IMAGE PASS +BUGWK79647 WIN MAC : compositing/reflections/reflection-ordering.html = IMAGE PASS // Flaky because these are a poorly written tests. Need dino's new animation API BUGWK54306 : compositing/reflections/animation-inside-reflection.html = PASS IMAGE IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108974] trunk/Tools
Title: [108974] trunk/Tools Revision 108974 Author commit-qu...@webkit.org Date 2012-02-27 02:06:06 -0800 (Mon, 27 Feb 2012) Log Message Add a ChromiumGpuAndroid port. https://bugs.webkit.org/show_bug.cgi?id=79628 Patch by Hao Zheng zheng...@chromium.org on 2012-02-27 Reviewed by Adam Barth. Android does have a gpu port, so revert r107697. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: (ChromiumGpuAndroidPort): (ChromiumGpuAndroidPort.__init__): (ChromiumGpuAndroidPort.baseline_search_path): (ChromiumGpuAndroidPort.default_child_processes): (ChromiumGpuAndroidPort.tests): * Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py Diff Modified: trunk/Tools/ChangeLog (108973 => 108974) --- trunk/Tools/ChangeLog 2012-02-27 10:01:36 UTC (rev 108973) +++ trunk/Tools/ChangeLog 2012-02-27 10:06:06 UTC (rev 108974) @@ -1,3 +1,23 @@ +2012-02-27 Hao Zheng zheng...@chromium.org + +Add a ChromiumGpuAndroid port. +https://bugs.webkit.org/show_bug.cgi?id=79628 + +Reviewed by Adam Barth. + +Android does have a gpu port, so revert r107697. + +* Scripts/webkitpy/layout_tests/port/chromium_android.py: +(ChromiumAndroidPort.__init__): +* Scripts/webkitpy/layout_tests/port/chromium_gpu.py: +(ChromiumGpuAndroidPort): +(ChromiumGpuAndroidPort.__init__): +(ChromiumGpuAndroidPort.baseline_search_path): +(ChromiumGpuAndroidPort.default_child_processes): +(ChromiumGpuAndroidPort.tests): +* Scripts/webkitpy/layout_tests/port/factory.py: +(PortFactory): + 2012-02-25 Gyuyoung Kim gyuyoung@samsung.com Change Build bot with BuildAndTest bot for EFL port. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (108973 => 108974) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-02-27 10:01:36 UTC (rev 108973) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-02-27 10:06:06 UTC (rev 108974) @@ -141,12 +141,6 @@ def __init__(self, host, port_name, **kwargs): chromium.ChromiumPort.__init__(self, host, port_name, **kwargs) -# The chromium-android port always uses the GPU code path, so we set -# these options here, almost as if this was the chromium-gpu-android -# port. -self._options.accelerated_2d_canvas = True -self._options.accelerated_video = True - self._operating_system = 'android' self._version = 'icecreamsandwich' # FIXME: we may support other architectures in the future. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (108973 => 108974) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2012-02-27 10:01:36 UTC (rev 108973) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2012-02-27 10:06:06 UTC (rev 108974) @@ -26,6 +26,7 @@ import sys +import chromium_android import chromium_linux import chromium_mac import chromium_win @@ -70,6 +71,29 @@ return paths +class ChromiumGpuAndroidPort(chromium_android.ChromiumAndroidPort): +port_name = 'chromium-gpu-android' + +def __init__(self, host, port_name, **kwargs): +chromium_android.ChromiumAndroidPort.__init__(self, host, port_name, **kwargs) +_set_gpu_options(self) +# Always enable hardware gpu, as Android platform doesn't support Mesa. +self._options.enable_hardware_gpu = True + +def baseline_search_path(self): +# Mimic the Linux - Win expectations fallback in the ordinary Chromium port. +return (map(self._webkit_baseline_path, ['chromium-gpu-android', 'chromium-gpu-linux', + 'chromium-gpu-win', 'chromium-gpu']) + +chromium_android.ChromiumAndroidPort.baseline_search_path(self)) + +def default_child_processes(self): +return 1 + +def tests(self, paths): +paths = paths or _default_tests_paths(self) +return chromium_android.ChromiumAndroidPort.tests(self, paths) + + class ChromiumGpuLinuxPort(chromium_linux.ChromiumLinuxPort): port_name = 'chromium-gpu-linux' Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py (108973 => 108974) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py 2012-02-27 10:01:36 UTC (rev 108973) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py 2012-02-27 10:06:06 UTC (rev 108974) @@ -43,6 +43,7 @@ class PortFactory(object): PORT_CLASSES = ( 'chromium_android.ChromiumAndroidPort', +'chromium_gpu.ChromiumGpuAndroidPort',
[webkit-changes] [108975] trunk/Source/WebCore
Title: [108975] trunk/Source/WebCore Revision 108975 Author kei...@webkit.org Date 2012-02-27 02:21:06 -0800 (Mon, 27 Feb 2012) Log Message Add missing include to ColorInputType.cpp https://bugs.webkit.org/show_bug.cgi?id=79632 Reviewed by Kent Tamura. * html/ColorInputType.cpp: Include ShadowTree.h Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/ColorInputType.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (108974 => 108975) --- trunk/Source/WebCore/ChangeLog 2012-02-27 10:06:06 UTC (rev 108974) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 10:21:06 UTC (rev 108975) @@ -1,3 +1,12 @@ +2012-02-27 Keishi Hattori kei...@webkit.org + +Add missing include to ColorInputType.cpp +https://bugs.webkit.org/show_bug.cgi?id=79632 + +Reviewed by Kent Tamura. + +* html/ColorInputType.cpp: Include ShadowTree.h + 2012-02-27 Andrey Kosyakov ca...@chromium.org Use built-in bind in ExtensionAPI.js Modified: trunk/Source/WebCore/html/ColorInputType.cpp (108974 => 108975) --- trunk/Source/WebCore/html/ColorInputType.cpp 2012-02-27 10:06:06 UTC (rev 108974) +++ trunk/Source/WebCore/html/ColorInputType.cpp 2012-02-27 10:21:06 UTC (rev 108975) @@ -39,6 +39,7 @@ #include MouseEvent.h #include ScriptController.h #include ShadowRoot.h +#include ShadowTree.h #include wtf/PassOwnPtr.h #include wtf/text/WTFString.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108976] trunk/Source/WebCore
Title: [108976] trunk/Source/WebCore
Revision 108976
Author kei...@webkit.org
Date 2012-02-27 02:23:24 -0800 (Mon, 27 Feb 2012)
Log Message
Color input type should be clickable through keyboard
https://bugs.webkit.org/show_bug.cgi?id=79629
Reviewed by Kent Tamura.
Introduced BaseClickableWithKeyInputType that represents an input type
that can be clicked by pressing space/return keys.
ColorInputType, FileInputType directly inherit it because it doesn't
want the other methods(like appendFormData) in BaseButtonInputType.
* CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp
* GNUmakefile.list.am: Added BaseClickableWithKeyInputType.{cpp,h}
* Target.pri: Added BaseClickableWithKeyInputType.{cpp,h}
* WebCore.gypi: Added BaseClickableWithKeyInputType.{cpp,h}
* WebCore.vcproj/WebCore.vcproj: Added BaseClickableWithKeyInputType.{cpp,h}
* WebCore.xcodeproj/project.pbxproj: Added BaseClickableWithKeyInputType.{cpp,h}
* html/BaseButtonInputType.cpp:
* html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType): Inherits BaseClickableWithKeyInputType now.
(BaseButtonInputType):
* html/BaseCheckableInputType.cpp: Changed comment.
* html/BaseClickableWithKeyInputType.cpp:
(WebCore):
(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeypressEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::accessKeyAction): Moved from BaseButtonInputType
* html/BaseClickableWithKeyInputType.h:
(WebCore):
(BaseClickableWithKeyInputType): Input type that can be clicked by pressing space/return keys.
(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):
* html/ColorInputType.h:
(WebCore::ColorInputType::ColorInputType): Inherits BaseClickableWithKeyInputType now.
* html/FileInputType.cpp:
(WebCore::FileInputType::FileInputType):
* html/FileInputType.h:
(FileInputType): Inherits BaseClickableWithKeyInputType now.
* html/RangeInputType.cpp: Changed comment.
(WebCore):
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/BaseButtonInputType.cpp
trunk/Source/WebCore/html/BaseButtonInputType.h
trunk/Source/WebCore/html/BaseCheckableInputType.cpp
trunk/Source/WebCore/html/ColorInputType.h
trunk/Source/WebCore/html/FileInputType.cpp
trunk/Source/WebCore/html/FileInputType.h
trunk/Source/WebCore/html/RangeInputType.cpp
Added Paths
trunk/Source/WebCore/html/BaseClickableWithKeyInputType.cpp
trunk/Source/WebCore/html/BaseClickableWithKeyInputType.h
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (108975 => 108976)
--- trunk/Source/WebCore/CMakeLists.txt 2012-02-27 10:21:06 UTC (rev 108975)
+++ trunk/Source/WebCore/CMakeLists.txt 2012-02-27 10:23:24 UTC (rev 108976)
@@ -720,6 +720,7 @@
html/BaseButtonInputType.cpp
html/BaseCheckableInputType.cpp
+html/BaseClickableWithKeyInputType.cpp
html/BaseDateAndTimeInputType.cpp
html/BaseTextInputType.cpp
html/ButtonInputType.cpp
Modified: trunk/Source/WebCore/ChangeLog (108975 => 108976)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 10:21:06 UTC (rev 108975)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 10:23:24 UTC (rev 108976)
@@ -1,5 +1,47 @@
2012-02-27 Keishi Hattori kei...@webkit.org
+Color input type should be clickable through keyboard
+https://bugs.webkit.org/show_bug.cgi?id=79629
+
+Reviewed by Kent Tamura.
+
+Introduced BaseClickableWithKeyInputType that represents an input type
+that can be clicked by pressing space/return keys.
+ColorInputType, FileInputType directly inherit it because it doesn't
+want the other methods(like appendFormData) in BaseButtonInputType.
+
+* CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp
+* GNUmakefile.list.am: Added BaseClickableWithKeyInputType.{cpp,h}
+* Target.pri: Added BaseClickableWithKeyInputType.{cpp,h}
+* WebCore.gypi: Added BaseClickableWithKeyInputType.{cpp,h}
+* WebCore.vcproj/WebCore.vcproj: Added BaseClickableWithKeyInputType.{cpp,h}
+* WebCore.xcodeproj/project.pbxproj: Added BaseClickableWithKeyInputType.{cpp,h}
+* html/BaseButtonInputType.cpp:
+* html/BaseButtonInputType.h:
+(WebCore::BaseButtonInputType::BaseButtonInputType): Inherits BaseClickableWithKeyInputType now.
+(BaseButtonInputType):
+* html/BaseCheckableInputType.cpp: Changed comment.
+* html/BaseClickableWithKeyInputType.cpp:
+(WebCore):
+(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent): Moved from BaseButtonInputType
+
[webkit-changes] [108977] trunk/LayoutTests
Title: [108977] trunk/LayoutTests Revision 108977 Author o...@webkit.org Date 2012-02-27 02:27:46 -0800 (Mon, 27 Feb 2012) Log Message [Qt] Unreviewed gardening, try to skip previous tests to avoid crashes. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (108976 => 108977) --- trunk/LayoutTests/ChangeLog 2012-02-27 10:23:24 UTC (rev 108976) +++ trunk/LayoutTests/ChangeLog 2012-02-27 10:27:46 UTC (rev 108977) @@ -1,3 +1,9 @@ +2012-02-27 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening, try to skip previous tests to avoid crashes. + +* platform/qt/Skipped: + 2012-02-27 Kenichi Ishibashi ba...@chromium.org [Chromium] Unreviewed test expectations update. Modified: trunk/LayoutTests/platform/qt/Skipped (108976 => 108977) --- trunk/LayoutTests/platform/qt/Skipped 2012-02-27 10:23:24 UTC (rev 108976) +++ trunk/LayoutTests/platform/qt/Skipped 2012-02-27 10:27:46 UTC (rev 108977) @@ -1425,6 +1425,8 @@ # [Qt] svg/zoom/page/zoom-svg-float-border-padding.xml crashes # https://bugs.webkit.org/show_bug.cgi?id=79631 +svg/zoom/page/zoom-svg-as-object.html +svg/zoom/page/zoom-svg-as-relative-image.html svg/zoom/page/zoom-svg-float-border-padding.xml svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108978] trunk/LayoutTests
Title: [108978] trunk/LayoutTests Revision 108978 Author ba...@chromium.org Date 2012-02-27 02:42:50 -0800 (Mon, 27 Feb 2012) Log Message [Chromium] Unreviewed test expectations update. Following tests are flaky: - compositing/reflections/remove-add-reflection.html - compositing/reflections/nested-reflection-transition.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (108977 => 108978) --- trunk/LayoutTests/ChangeLog 2012-02-27 10:27:46 UTC (rev 108977) +++ trunk/LayoutTests/ChangeLog 2012-02-27 10:42:50 UTC (rev 108978) @@ -1,3 +1,13 @@ +2012-02-27 Kenichi Ishibashi ba...@chromium.org + +[Chromium] Unreviewed test expectations update. + +Following tests are flaky: +- compositing/reflections/remove-add-reflection.html +- compositing/reflections/nested-reflection-transition.html + +* platform/chromium/test_expectations.txt: + 2012-02-27 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening, try to skip previous tests to avoid crashes. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (108977 => 108978) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 10:27:46 UTC (rev 108977) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 10:42:50 UTC (rev 108978) @@ -2539,9 +2539,10 @@ BUGWK47949 MAC : compositing/reflections/reflection-opacity.html = IMAGE PASS BUGWK47949 : compositing/reflections/reflection-positioning.html = IMAGE PASS BUGWK74949 WIN MAC : compositing/reflections/nested-reflection-transformed2.html = IMAGE PASS -BUGWK47949 MAC : compositing/reflections/nested-reflection-transition.html = IMAGE PASS +BUGWK47949 : compositing/reflections/nested-reflection-transition.html = IMAGE PASS BUGWK47949 MAC : compositing/reflections/nested-reflection-size-change.html = IMAGE PASS BUGWK79647 WIN MAC : compositing/reflections/reflection-ordering.html = IMAGE PASS +BUGWK79647 WIN LINUX : compositing/reflections/remove-add-reflection.html = IMAGE PASS // Flaky because these are a poorly written tests. Need dino's new animation API BUGWK54306 : compositing/reflections/animation-inside-reflection.html = PASS IMAGE IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108979] trunk/LayoutTests
Title: [108979] trunk/LayoutTests Revision 108979 Author o...@webkit.org Date 2012-02-27 03:05:12 -0800 (Mon, 27 Feb 2012) Log Message Unreviewed gardening. * platform/qt-5.0-wk1/Skipped: Skip a new timeouting test. * platform/qt-5.0-wk2/Skipped: Skip a new _crashing_ test. * platform/wk2/Skipped: Unskip non-existning tests, rename entries as real files renamed before. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0-wk1/Skipped trunk/LayoutTests/platform/qt-5.0-wk2/Skipped trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (108978 => 108979) --- trunk/LayoutTests/ChangeLog 2012-02-27 10:42:50 UTC (rev 108978) +++ trunk/LayoutTests/ChangeLog 2012-02-27 11:05:12 UTC (rev 108979) @@ -1,3 +1,11 @@ +2012-02-27 Csaba Osztrogonác o...@webkit.org + +Unreviewed gardening. + +* platform/qt-5.0-wk1/Skipped: Skip a new timeouting test. +* platform/qt-5.0-wk2/Skipped: Skip a new _crashing_ test. +* platform/wk2/Skipped: Unskip non-existning tests, rename entries as real files renamed before. + 2012-02-27 Kenichi Ishibashi ba...@chromium.org [Chromium] Unreviewed test expectations update. Modified: trunk/LayoutTests/platform/qt-5.0-wk1/Skipped (108978 => 108979) --- trunk/LayoutTests/platform/qt-5.0-wk1/Skipped 2012-02-27 10:42:50 UTC (rev 108978) +++ trunk/LayoutTests/platform/qt-5.0-wk1/Skipped 2012-02-27 11:05:12 UTC (rev 108979) @@ -12,3 +12,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=73901 http/tests/misc/drag-over-iframe-invalid-source-crash.html fast/events/drag-selects-image.html + +# [Qt] http/tests/incremental/slow-utf8-text.pl times out with Qt5-WK1 +# https://bugs.webkit.org/show_bug.cgi?id=79655 +http/tests/incremental/slow-utf8-text.pl Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (108978 => 108979) --- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-02-27 10:42:50 UTC (rev 108978) +++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-02-27 11:05:12 UTC (rev 108979) @@ -352,7 +352,6 @@ fast/replaced/no-focus-ring-object.html fast/text/whitespace/028.html http/tests/cache/history-only-cached-subresource-loads.html -http/tests/workers/interrupt-database-sync-open-crash.html security/autocomplete-cleared-on-back.html # Crashing test on qt-wk2 after unskipping qt-5.0/Skipped tests, need more investigation editing/execCommand/align-in-span.html @@ -428,3 +427,7 @@ fast/history/form-submit-in-frame-via-onclick.html fast/history/form-submit-in-frame.html http/tests/loading/state-object-security-exception.html + +# [Qt][WK2] fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html crashes regularly +# https://bugs.webkit.org/show_bug.cgi?id=79656 +fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html Modified: trunk/LayoutTests/platform/wk2/Skipped (108978 => 108979) --- trunk/LayoutTests/platform/wk2/Skipped 2012-02-27 10:42:50 UTC (rev 108978) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-02-27 11:05:12 UTC (rev 108979) @@ -193,7 +193,6 @@ # WebKit2 needs layoutTestController.overridePreference # https://bugs.webkit.org/show_bug.cgi?id=42197 -css3/filters/custom-filter.html fast/canvas/webgl/framebuffer-object-attachment.html fast/canvas/webgl/gl-vertex-attrib-zero-issues.html fast/canvas/webgl/gl-getshadersource.html @@ -372,7 +371,6 @@ http/tests/security/mixedContent/insecure-image-in-main-frame.html http/tests/security/mixedContent/insecure-plugin-in-iframe.html http/tests/security/mixedContent/insecure-script-in-iframe.html -http/tests/security/mixedContent/insecure-video-in-iframe.html http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html @@ -532,12 +530,12 @@ # https://bugs.webkit.org/show_bug.cgi?id=42547 fast/canvas/canvas-gradient-addStop-error.html http/tests/xmlhttprequest/default-content-type-dashboard.html -http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html +http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html platform/mac/fast/events/pointer-events-dashboard.html -svg/custom/embedded-svg-disallowed-in-dashboard.xml -svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html -svg/custom/manually-parsed-svg-disallowed-in-dashboard.html -svg/custom/svg-disallowed-in-dashboard-object.html +svg/custom/embedded-svg-allowed-in-dashboard.xml +svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html +svg/custom/manually-parsed-svg-allowed-in-dashboard.html +svg/custom/svg-allowed-in-dashboard-object.html # WebKitTestRunner needs layoutTestController.queueReload # https://bugs.webkit.org/show_bug.cgi?id=42672 @@ -722,7 +720,6 @@ http/tests/loading/basic.html http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
[webkit-changes] [108980] trunk
Title: [108980] trunk
Revision 108980
Author morr...@google.com
Date 2012-02-27 03:13:44 -0800 (Mon, 27 Feb 2012)
Log Message
Source/WebCore: Removing ul, li inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=79630
Reviewed by Ryosuke Niwa.
This problem was caused by the inconsistent detach order of DOM tree where
Element::detach() called ContainerNode::detach() before shadow tree is detached.
This resulted the renderer of the element being destroyed even if its children,
each of which came from an element in the shadow tree, are alive.
In principle, child renderers should be destroyed before its parent.
This change aligns the detach order with the attach order. The shadow tree is
now deatched before parent's ContainerNode::detach() is called.
Test: fast/dom/shadow/shadow-ul-li.html
* dom/Element.cpp:
(WebCore::Element::detach):
LayoutTests: Removing ul, li inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=72440
Reviewed by Ryosuke Niwa.
* fast/dom/shadow/shadow-ul-li-expected.txt: Added.
* fast/dom/shadow/shadow-ul-li.html: Added.
* fast/dom/shadow/shadow-ul-li.html:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
Added Paths
trunk/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-ul-li.html
Diff
Modified: trunk/LayoutTests/ChangeLog (108979 => 108980)
--- trunk/LayoutTests/ChangeLog 2012-02-27 11:05:12 UTC (rev 108979)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 11:13:44 UTC (rev 108980)
@@ -1,3 +1,18 @@
+2012-02-27 MORITA Hajime morr...@google.com
+
+Removing ul, li inside shadow DOM triggers assertion in updateListMarkerNumbers
+https://bugs.webkit.org/show_bug.cgi?id=72440
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/shadow/shadow-ul-li-expected.txt: Added.
+* fast/dom/shadow/shadow-ul-li.html: Added.
+* fast/dom/shadow/shadow-ul-li.html:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+* platform/wk2/Skipped:
+
2012-02-27 Csaba Osztrogonác o...@webkit.org
Unreviewed gardening.
Added: trunk/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt (0 => 108980)
--- trunk/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt 2012-02-27 11:13:44 UTC (rev 108980)
@@ -0,0 +1 @@
+PASS unless crash.
Added: trunk/LayoutTests/fast/dom/shadow/shadow-ul-li.html (0 => 108980)
--- trunk/LayoutTests/fast/dom/shadow/shadow-ul-li.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-ul-li.html 2012-02-27 11:13:44 UTC (rev 108980)
@@ -0,0 +1,26 @@
+!DOCTYPE html
+html
+head
+script
+function test()
+{
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var host = document.createElement('div');
+document.body.appendChild(host);
+var shadow = new WebKitShadowRoot(host);
+
+var ul = document.createElement('ul');
+var li = document.createElement('li');
+ul.appendChild(li);
+shadow.appendChild(ul);
+document.body.offsetLeft;
+
+document.body.innerHTML = 'PASS unless crash.';
+}
+/script
+/head
+body _onload_=test()
+/body
+/html
Modified: trunk/LayoutTests/platform/mac/Skipped (108979 => 108980)
--- trunk/LayoutTests/platform/mac/Skipped 2012-02-27 11:05:12 UTC (rev 108979)
+++ trunk/LayoutTests/platform/mac/Skipped 2012-02-27 11:13:44 UTC (rev 108980)
@@ -429,6 +429,7 @@
fast/dom/shadow/shadow-disable.html
fast/dom/shadow/shadow-root-attached.html
fast/dom/shadow/shadow-root-new.html
+fast/dom/shadow/shadow-ul-li.html
# JSC does not support setIsolatedWorldSecurityOrigin (http://webkit.org/b/61540)
http/tests/security/isolatedWorld/cross-origin-xhr.html
Modified: trunk/LayoutTests/platform/qt/Skipped (108979 => 108980)
--- trunk/LayoutTests/platform/qt/Skipped 2012-02-27 11:05:12 UTC (rev 108979)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-02-27 11:13:44 UTC (rev 108980)
@@ -167,6 +167,7 @@
fast/dom/shadow/shadow-on-image.html
fast/dom/shadow/shadow-root-attached.html
fast/dom/shadow/shadow-root-new.html
+fast/dom/shadow/shadow-ul-li.html
# CSS Regions support not yet enabled. http://webkit.org/b/57312
fast/regions
Modified: trunk/LayoutTests/platform/win/Skipped (108979 => 108980)
--- trunk/LayoutTests/platform/win/Skipped 2012-02-27 11:05:12 UTC (rev 108979)
+++ trunk/LayoutTests/platform/win/Skipped 2012-02-27 11:13:44 UTC (rev 108980)
@@ -1458,6 +1458,7 @@
fast/dom/shadow/shadow-disable.html
[webkit-changes] [108981] trunk
Title: [108981] trunk
Revision 108981
Author ves...@webkit.org
Date 2012-02-27 03:30:29 -0800 (Mon, 27 Feb 2012)
Log Message
[Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
Reviewed by Kenneth Rohde Christiansen.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.pri
trunk/Source/WebCore/platform/MIMETypeRegistry.cpp
trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h
trunk/Source/WebCore/platform/image-decoders/qt/ImageFrameQt.cpp
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf
Diff
Modified: trunk/Source/WebCore/ChangeLog (108980 => 108981)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 11:13:44 UTC (rev 108980)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 11:30:29 UTC (rev 108981)
@@ -1,3 +1,21 @@
+2012-02-27 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
+
+Reviewed by Kenneth Rohde Christiansen..
+
+* Target.pri:
+* WebCore.pri:
+* platform/MIMETypeRegistry.cpp:
+(WebCore::initializeSupportedImageMIMETypes):
+(WebCore::initializeSupportedImageMIMETypesForEncoding):
+* platform/image-decoders/ImageDecoder.h:
+(WebCore::ImageFrame::getAddr):
+(ImageFrame):
+* platform/image-decoders/qt/ImageFrameQt.cpp:
+(WebCore):
+(WebCore::ImageFrame::asNewNativeImage):
+
2012-02-27 MORITA Hajime morr...@google.com
Removing ul, li inside shadow DOM triggers assertion in updateListMarkerNumbers
Modified: trunk/Source/WebCore/Target.pri (108980 => 108981)
--- trunk/Source/WebCore/Target.pri 2012-02-27 11:13:44 UTC (rev 108980)
+++ trunk/Source/WebCore/Target.pri 2012-02-27 11:30:29 UTC (rev 108981)
@@ -3941,7 +3941,7 @@
page/PageSerializer.cpp
}
-contains(DEFINES, ENABLE_QT_IMAGE_DECODER=1) {
+contains(DEFINES, WTF_USE_QT_IMAGE_DECODER=1) {
HEADERS += platform/graphics/qt/ImageDecoderQt.h
SOURCES += platform/graphics/qt/ImageDecoderQt.cpp
} else {
Modified: trunk/Source/WebCore/WebCore.pri (108980 => 108981)
--- trunk/Source/WebCore/WebCore.pri 2012-02-27 11:13:44 UTC (rev 108980)
+++ trunk/Source/WebCore/WebCore.pri 2012-02-27 11:30:29 UTC (rev 108981)
@@ -204,7 +204,7 @@
LIBS += -lsqlite3
}
-contains(DEFINES, ENABLE_QT_IMAGE_DECODER=0) {
+contains(DEFINES, WTF_USE_QT_IMAGE_DECODER=0) {
INCLUDEPATH += \
$$SOURCE_DIR/platform/image-decoders/bmp \
$$SOURCE_DIR/platform/image-decoders/gif \
Modified: trunk/Source/WebCore/platform/MIMETypeRegistry.cpp (108980 => 108981)
--- trunk/Source/WebCore/platform/MIMETypeRegistry.cpp 2012-02-27 11:13:44 UTC (rev 108980)
+++ trunk/Source/WebCore/platform/MIMETypeRegistry.cpp 2012-02-27 11:30:29 UTC (rev 108981)
@@ -39,7 +39,7 @@
#include ApplicationServices/ApplicationServices.h
#include wtf/RetainPtr.h
#endif
-#if PLATFORM(QT) ENABLE(QT_IMAGE_DECODER)
+#if PLATFORM(QT) USE(QT_IMAGE_DECODER)
#include qimagereader.h
#include qimagewriter.h
#endif
@@ -229,7 +229,7 @@
supportedImageMIMETypes-remove(application/pdf);
supportedImageMIMETypes-remove(application/postscript);
-#elif PLATFORM(QT) ENABLE(QT_IMAGE_DECODER)
+#elif PLATFORM(QT) USE(QT_IMAGE_DECODER)
QListQByteArray formats = QImageReader::supportedImageFormats();
for (size_t i = 0; i static_castsize_t(formats.size()); ++i) {
#if ENABLE(SVG)
@@ -289,7 +289,7 @@
supportedImageMIMETypesForEncoding-add(image/jpeg);
supportedImageMIMETypesForEncoding-add(image/gif);
#endif
-#elif PLATFORM(QT) ENABLE(QT_IMAGE_DECODER)
+#elif PLATFORM(QT) USE(QT_IMAGE_DECODER)
QListQByteArray formats = QImageWriter::supportedImageFormats();
for (int i = 0; i formats.size(); ++i) {
String mimeType = MIMETypeRegistry::getMIMETypeForExtension(formats.at(i).constData());
Modified: trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h (108980 => 108981)
--- trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h 2012-02-27 11:13:44 UTC (rev 108980)
+++ trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h 2012-02-27 11:30:29 UTC (rev 108981)
@@ -64,7 +64,7 @@
DisposeOverwritePrevious // Clear frame to previous framebuffer
// contents
};
-#if USE(SKIA) || (PLATFORM(QT) ENABLE(QT_IMAGE_DECODER))
+#if USE(SKIA) || (PLATFORM(QT) USE(QT_IMAGE_DECODER))
typedef uint32_t PixelData;
#else
typedef unsigned PixelData;
@@ -140,7 +140,7 @@
{
#if USE(SKIA)
return m_bitmap.bitmap().getAddr32(x, y);
-#elif PLATFORM(QT) ENABLE(QT_IMAGE_DECODER)
+#elif PLATFORM(QT) USE(QT_IMAGE_DECODER)
m_image = m_pixmap.toImage();
m_pixmap = QPixmap();
return reinterpret_cast_ptrQRgb*(m_image.scanLine(y)) + x;
@@ -149,7 +149,7 @@
#endif
}
-#if PLATFORM(QT)
[webkit-changes] [108982] trunk/Source/WebCore
Title: [108982] trunk/Source/WebCore Revision 108982 Author ves...@webkit.org Date 2012-02-27 03:38:34 -0800 (Mon, 27 Feb 2012) Log Message [Qt] Remove page/PageSupplement.h from WebCore's Target.pri The file itself was removed in r108958. Reviewed by Kenneth Rohde Christiansen. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri Diff Modified: trunk/Source/WebCore/ChangeLog (108981 => 108982) --- trunk/Source/WebCore/ChangeLog 2012-02-27 11:30:29 UTC (rev 108981) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 11:38:34 UTC (rev 108982) @@ -1,5 +1,15 @@ 2012-02-27 Tor Arne Vestbø tor.arne.ves...@nokia.com +[Qt] Remove page/PageSupplement.h from WebCore's Target.pri + +The file itself was removed in r108958. + +Reviewed by Kenneth Rohde Christiansen. + +* Target.pri: + +2012-02-27 Tor Arne Vestbø tor.arne.ves...@nokia.com + [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder Reviewed by Kenneth Rohde Christiansen.. Modified: trunk/Source/WebCore/Target.pri (108981 => 108982) --- trunk/Source/WebCore/Target.pri 2012-02-27 11:30:29 UTC (rev 108981) +++ trunk/Source/WebCore/Target.pri 2012-02-27 11:38:34 UTC (rev 108982) @@ -2086,7 +2086,6 @@ page/PageGroup.h \ page/PageGroupLoadDeferrer.h \ page/Page.h \ -page/PageSupplement.h \ page/PageVisibilityState.h \ page/PrintContext.h \ page/Screen.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108983] trunk/Source/WebCore
Title: [108983] trunk/Source/WebCore
Revision 108983
Author loi...@chromium.org
Date 2012-02-27 03:56:14 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: [chromium] Profiles - Tooltip with object/property types stays on screen when another tab selected
https://bugs.webkit.org/show_bug.cgi?id=79654
Reviewed by Yury Semikhatsky.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.willHide):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (108982 => 108983)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 11:38:34 UTC (rev 108982)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 11:56:14 UTC (rev 108983)
@@ -1,3 +1,13 @@
+2012-02-27 Ilya Tikhonovsky loi...@chromium.org
+
+Web Inspector: [chromium] Profiles - Tooltip with object/property types stays on screen when another tab selected
+https://bugs.webkit.org/show_bug.cgi?id=79654
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DetailedHeapshotView.js:
+(WebInspector.DetailedHeapshotView.prototype.willHide):
+
2012-02-27 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Remove page/PageSupplement.h from WebCore's Target.pri
Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (108982 => 108983)
--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2012-02-27 11:38:34 UTC (rev 108982)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2012-02-27 11:56:14 UTC (rev 108983)
@@ -623,6 +623,8 @@
{
this._currentSearchResultIndex = -1;
this._popoverHelper.hidePopover();
+if (this.helpPopover.visible)
+this.helpPopover.hide();
},
onResize: function()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108984] trunk/Source/WebCore
Title: [108984] trunk/Source/WebCore Revision 108984 Author par...@webkit.org Date 2012-02-27 04:04:38 -0800 (Mon, 27 Feb 2012) Log Message [CMake] Build fix after r108709. * CMakeLists.txt: Move DOMWindowSVG.idl to the other IDL files. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/CMakeLists.txt (108983 => 108984) --- trunk/Source/WebCore/CMakeLists.txt 2012-02-27 11:56:14 UTC (rev 108983) +++ trunk/Source/WebCore/CMakeLists.txt 2012-02-27 12:04:38 UTC (rev 108984) @@ -1721,7 +1721,6 @@ rendering/svg/SVGTextMetricsBuilder.cpp rendering/svg/SVGTextQuery.cpp svg/ColorDistance.cpp -svg/DOMWindowSVG.idl svg/SVGAElement.cpp svg/SVGAltGlyphDefElement.cpp svg/SVGAltGlyphElement.cpp @@ -1889,6 +1888,7 @@ # For now, we explicitly demarcate the SVG IDL files so that the BlackBerry port can skip them # during DOM binding generation. See https://bugs.webkit.org/show_bug.cgi?id=72773. SET(SVG_IDL_FILES +svg/DOMWindowSVG.idl svg/SVGAElement.idl svg/SVGAltGlyphDefElement.idl svg/SVGAltGlyphElement.idl Modified: trunk/Source/WebCore/ChangeLog (108983 => 108984) --- trunk/Source/WebCore/ChangeLog 2012-02-27 11:56:14 UTC (rev 108983) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 12:04:38 UTC (rev 108984) @@ -1,3 +1,9 @@ +2012-02-27 Patrick Gansterer par...@webkit.org + +[CMake] Build fix after r108709. + +* CMakeLists.txt: Move DOMWindowSVG.idl to the other IDL files. + 2012-02-27 Ilya Tikhonovsky loi...@chromium.org Web Inspector: [chromium] Profiles - Tooltip with object/property types stays on screen when another tab selected ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108985] trunk
Title: [108985] trunk Revision 108985 Author carlo...@webkit.org Date 2012-02-27 04:28:43 -0800 (Mon, 27 Feb 2012) Log Message Unreviewed. Fix make distcheck. Source/_javascript_Core: * GNUmakefile.list.am: Add missing files. Source/WebCore: * GNUmakefile.am: Add missing files. * GNUmakefile.list.am: Ditto. Tools: * GNUmakefile.am: Fix typo. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.list.am trunk/Tools/ChangeLog trunk/Tools/GNUmakefile.am Diff Modified: trunk/Source/_javascript_Core/ChangeLog (108984 => 108985) --- trunk/Source/_javascript_Core/ChangeLog 2012-02-27 12:04:38 UTC (rev 108984) +++ trunk/Source/_javascript_Core/ChangeLog 2012-02-27 12:28:43 UTC (rev 108985) @@ -1,3 +1,9 @@ +2012-02-27 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix make distcheck. + +* GNUmakefile.list.am: Add missing files. + 2012-02-26 Hajime Morrita morr...@chromium.org Move ChromeClient::showContextMenu() to ContextMenuClient Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (108984 => 108985) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-02-27 12:04:38 UTC (rev 108984) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-02-27 12:28:43 UTC (rev 108985) @@ -328,6 +328,10 @@ Source/_javascript_Core/jit/ThunkGenerators.cpp \ Source/_javascript_Core/jit/ThunkGenerators.h \ Source/_javascript_Core/llint/LLIntData.h \ + Source/_javascript_Core/llint/LLIntEntrypoints.cpp \ + Source/_javascript_Core/llint/LLIntEntrypoints.h \ + Source/_javascript_Core/llint/LowLevelInterpreter.cpp \ + Source/_javascript_Core/llint/LowLevelInterpreter.h \ Source/_javascript_Core/os-win32/stdbool.h \ Source/_javascript_Core/os-win32/stdint.h \ Source/_javascript_Core/parser/ASTBuilder.h \ @@ -833,4 +837,5 @@ Source/_javascript_Core/API/tests/minidom.c Programs_jsc_@WEBKITGTK_API_MAJOR_VERSION@_SOURCES = \ + Source/_javascript_Core/JSCTypedArrayStubs.h \ Source/_javascript_Core/jsc.cpp Modified: trunk/Source/WebCore/ChangeLog (108984 => 108985) --- trunk/Source/WebCore/ChangeLog 2012-02-27 12:04:38 UTC (rev 108984) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 12:28:43 UTC (rev 108985) @@ -1,3 +1,10 @@ +2012-02-27 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix make distcheck. + +* GNUmakefile.am: Add missing files. +* GNUmakefile.list.am: Ditto. + 2012-02-27 Patrick Gansterer par...@webkit.org [CMake] Build fix after r108709. Modified: trunk/Source/WebCore/GNUmakefile.am (108984 => 108985) --- trunk/Source/WebCore/GNUmakefile.am 2012-02-27 12:04:38 UTC (rev 108984) +++ trunk/Source/WebCore/GNUmakefile.am 2012-02-27 12:28:43 UTC (rev 108985) @@ -901,6 +901,7 @@ $(XT_CFLAGS) EXTRA_DIST += \ + $(shell ls $(srcdir)/Source/WebCore/Modules/geolocation/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/Modules/mediastream/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/Modules/websockets/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/css/*.idl) \ @@ -926,6 +927,7 @@ Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm \ Source/WebCore/bindings/scripts/CodeGeneratorJS.pm \ Source/WebCore/bindings/scripts/CodeGenerator.pm \ + Source/WebCore/bindings/scripts/IDLAttributes.txt \ Source/WebCore/bindings/scripts/IDLParser.pm \ Source/WebCore/bindings/scripts/IDLStructure.pm \ Source/WebCore/bindings/scripts/InFilesCompiler.pm \ Modified: trunk/Source/WebCore/GNUmakefile.list.am (108984 => 108985) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-02-27 12:04:38 UTC (rev 108984) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-02-27 12:28:43 UTC (rev 108985) @@ -2814,6 +2814,8 @@ Source/WebCore/page/scrolling/ScrollingCoordinator.cpp \ Source/WebCore/page/scrolling/ScrollingCoordinator.h \ Source/WebCore/page/scrolling/ScrollingCoordinatorNone.cpp \ + Source/WebCore/page/scrolling/ScrollingTreeState.cpp \ + Source/WebCore/page/scrolling/ScrollingTreeState.h \ Source/WebCore/page/SecurityOrigin.cpp \ Source/WebCore/page/SecurityOrigin.h \ Source/WebCore/page/SecurityOriginHash.h \ @@ -3155,6 +3157,8 @@ Source/WebCore/platform/KURL.cpp \ Source/WebCore/platform/KURL.h \ Source/WebCore/platform/KURLHash.h \ + Source/WebCore/platform/KURLWTFURL.cpp \ + Source/WebCore/platform/KURLWTFURLImpl.h \ Source/WebCore/platform/Language.cpp \ Source/WebCore/platform/Language.h \ Source/WebCore/platform/LengthBox.h \ Modified: trunk/Tools/ChangeLog (108984 => 108985) --- trunk/Tools/ChangeLog 2012-02-27 12:04:38 UTC (rev 108984) +++ trunk/Tools/ChangeLog 2012-02-27 12:28:43 UTC (rev 108985) @@ -1,3 +1,9 @@ +2012-02-27 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix make distcheck. + +* GNUmakefile.am: Fix typo. + 2012-02-27 Tor Arne Vestbø tor.arne.ves...@nokia.com
[webkit-changes] [108986] trunk/LayoutTests
Title: [108986] trunk/LayoutTests Revision 108986 Author o...@webkit.org Date 2012-02-27 05:14:35 -0800 (Mon, 27 Feb 2012) Log Message [Qt][WK2] Skip one more crashing test. * platform/qt-5.0-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (108985 => 108986) --- trunk/LayoutTests/ChangeLog 2012-02-27 12:28:43 UTC (rev 108985) +++ trunk/LayoutTests/ChangeLog 2012-02-27 13:14:35 UTC (rev 108986) @@ -1,3 +1,9 @@ +2012-02-27 Csaba Osztrogonác o...@webkit.org + +[Qt][WK2] Skip one more crashing test. + +* platform/qt-5.0-wk2/Skipped: + 2012-02-27 MORITA Hajime morr...@google.com Removing ul, li inside shadow DOM triggers assertion in updateListMarkerNumbers Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (108985 => 108986) --- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-02-27 12:28:43 UTC (rev 108985) +++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-02-27 13:14:35 UTC (rev 108986) @@ -431,3 +431,4 @@ # [Qt][WK2] fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html crashes regularly # https://bugs.webkit.org/show_bug.cgi?id=79656 fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html +fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108987] trunk/Source/WebCore
Title: [108987] trunk/Source/WebCore Revision 108987 Author yu...@chromium.org Date 2012-02-27 05:47:26 -0800 (Mon, 27 Feb 2012) Log Message Web Inspector: repaint counter graphs when timeline splitter moves https://bugs.webkit.org/show_bug.cgi?id=79644 Immediately refresh timeline panel on splitter move. Reviewed by Pavel Feldman. * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._splitterDragging): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/TimelinePanel.js Diff Modified: trunk/Source/WebCore/ChangeLog (108986 => 108987) --- trunk/Source/WebCore/ChangeLog 2012-02-27 13:14:35 UTC (rev 108986) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 13:47:26 UTC (rev 108987) @@ -1,3 +1,15 @@ +2012-02-27 Yury Semikhatsky yu...@chromium.org + +Web Inspector: repaint counter graphs when timeline splitter moves +https://bugs.webkit.org/show_bug.cgi?id=79644 + +Immediately refresh timeline panel on splitter move. + +Reviewed by Pavel Feldman. + +* inspector/front-end/TimelinePanel.js: +(WebInspector.TimelinePanel.prototype._splitterDragging): + 2012-02-27 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Fix make distcheck. Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (108986 => 108987) --- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-02-27 13:14:35 UTC (rev 108986) +++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-02-27 13:47:26 UTC (rev 108987) @@ -154,6 +154,7 @@ var top = event.pageY + this._dragOffset this._setSplitterPosition(top); event.preventDefault(); +this._refresh(); }, /** ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108989] trunk/Source/WebCore
Title: [108989] trunk/Source/WebCore
Revision 108989
Author yu...@chromium.org
Date 2012-02-27 06:56:52 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: reveal corresponding timeline record when user clicks on memory graph
https://bugs.webkit.org/show_bug.cgi?id=79669
When user clicks on DOM counter graph corresponding timeline record is
revealed in timelime grid and all its ancestors are expanded.
Reviewed by Pavel Feldman.
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onClick):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.HeapGraph.prototype._clear):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.revealRecordAt.recordFinder):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.forAllRecords):
(WebInspector.TimelinePanel.FormattedRecord.prototype.containsTime):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/MemoryStatistics.js
trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (108988 => 108989)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 14:43:34 UTC (rev 108988)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 14:56:52 UTC (rev 108989)
@@ -1,3 +1,26 @@
+2012-02-27 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: reveal corresponding timeline record when user clicks on memory graph
+https://bugs.webkit.org/show_bug.cgi?id=79669
+
+When user clicks on DOM counter graph corresponding timeline record is
+revealed in timelime grid and all its ancestors are expanded.
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/MemoryStatistics.js:
+(WebInspector.MemoryStatistics.prototype._onClick):
+* inspector/front-end/TimelineOverviewPane.js:
+(WebInspector.TimelineOverviewPane.prototype.update):
+(WebInspector.HeapGraph.prototype.update):
+(WebInspector.HeapGraph.prototype._clear):
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel.prototype.revealRecordAt.recordFinder):
+(WebInspector.TimelinePanel.prototype.revealRecordAt):
+(WebInspector.TimelinePanel.prototype._refreshRecords):
+(WebInspector.TimelinePanel.forAllRecords):
+(WebInspector.TimelinePanel.FormattedRecord.prototype.containsTime):
+
2012-02-27 Ilya Tikhonovsky loi...@chromium.org
Unreviewed single line fix for r108983.
Modified: trunk/Source/WebCore/inspector/front-end/MemoryStatistics.js (108988 => 108989)
--- trunk/Source/WebCore/inspector/front-end/MemoryStatistics.js 2012-02-27 14:43:34 UTC (rev 108988)
+++ trunk/Source/WebCore/inspector/front-end/MemoryStatistics.js 2012-02-27 14:56:52 UTC (rev 108989)
@@ -52,9 +52,10 @@
this._canvas.id = memory-counters-graph;
this._lastMarkerXPosition = 0;
-this._canvasContainer.addEventListener(mouseover, this._onMouseOver.bind(this), true);
-this._canvasContainer.addEventListener(mousemove, this._onMouseMove.bind(this), true);
-this._canvasContainer.addEventListener(mouseout, this._onMouseOut.bind(this), true);
+this._canvas.addEventListener(mouseover, this._onMouseOver.bind(this), true);
+this._canvas.addEventListener(mousemove, this._onMouseMove.bind(this), true);
+this._canvas.addEventListener(mouseout, this._onMouseOut.bind(this), true);
+this._canvas.addEventListener(click, this._onClick.bind(this), true);
// Populate sidebar
this._memorySplitView.sidebarElement.createChild(div, sidebar-tree sidebar-tree-section).textContent = WebInspector.UIString(COUNTERS);
@@ -278,6 +279,14 @@
this._maxTime = end;
},
+_onClick: function(event)
+{
+var x = event.x - event.target.offsetParent.offsetLeft
+var i = this._recordIndexAt(x);
+var counter = this._counters[i];
+this._timelinePanel.revealRecordAt(counter.time / 1000);
+},
+
_onMouseOut: function(event)
{
delete this._markerXPosition;
Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (108988 => 108989)
--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-02-27 14:43:34 UTC (rev 108988)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-02-27 14:56:52 UTC (rev 108989)
@@ -161,25 +161,6 @@
this._categoryGraphs[category.name].dimmed = category.hidden;
},
-_forAllRecords: function(recordsArray, callback)
-{
-if (!recordsArray)
-return;
-var stack = [{array: recordsArray, index: 0}];
-while (stack.length) {
-var entry = stack[stack.length - 1];
-var records =
[webkit-changes] [108990] trunk/Source/WebCore
Title: [108990] trunk/Source/WebCore
Revision 108990
Author ca...@chromium.org
Date 2012-02-27 07:05:01 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: [refactoring] remove dependencies from TimelinePanel from most of FormattedRecord
https://bugs.webkit.org/show_bug.cgi?id=79665
Reviewed by Pavel Feldman.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyScriptLocation):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (108989 => 108990)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 14:56:52 UTC (rev 108989)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 15:05:01 UTC (rev 108990)
@@ -1,3 +1,22 @@
+2012-02-27 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: [refactoring] remove dependencies from TimelinePanel from most of FormattedRecord
+https://bugs.webkit.org/show_bug.cgi?id=79665
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
+(WebInspector.TimelinePanel.FormattedRecord):
+(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
+(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
+(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
+(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
+(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyTopCallFrame):
+(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyScriptLocation):
+(WebInspector.TimelinePanel.PopupContentHelper):
+(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
+
2012-02-27 Yury Semikhatsky yu...@chromium.org
Web Inspector: reveal corresponding timeline record when user clicks on memory graph
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (108989 => 108990)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-02-27 14:56:52 UTC (rev 108989)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-02-27 15:05:01 UTC (rev 108990)
@@ -179,19 +179,6 @@
this._memoryStatistics.setTopPosition(top);
},
-_linkifyLocation: function(url, lineNumber, columnNumber)
-{
-// FIXME(62725): stack trace line/column numbers are one-based.
-lineNumber = lineNumber ? lineNumber - 1 : lineNumber;
-columnNumber = columnNumber ? columnNumber - 1 : 0;
-return this._linkifier.linkifyLocation(url, lineNumber, columnNumber, timeline-details);
-},
-
-_linkifyCallFrame: function(callFrame)
-{
-return this._linkifyLocation(callFrame.url, callFrame.lineNumber, callFrame.columnNumber);
-},
-
get calculator()
{
return this._calculator;
@@ -561,7 +548,7 @@
}
}
-var formattedRecord = new WebInspector.TimelinePanel.FormattedRecord(record, parentRecord, this, scriptDetails);
+var formattedRecord = new WebInspector.TimelinePanel.FormattedRecord(record, parentRecord, this, this._linkifier, scriptDetails);
if (record.type === recordTypes.MarkDOMContent || record.type === recordTypes.MarkLoad) {
this._timeStampRecords.push(formattedRecord);
@@ -1213,9 +1200,9 @@
/**
* @constructor
*/
-WebInspector.TimelinePanel.FormattedRecord = function(record, parentRecord, panel, scriptDetails)
+WebInspector.TimelinePanel.FormattedRecord = function(record, parentRecord, panel, linkifier, scriptDetails)
{
-this._panel = panel;
+this._linkifier = linkifier;
var recordTypes = WebInspector.TimelineAgent.RecordType;
var style = panel._recordStyles[record.type];
this.parent = parentRecord;
@@ -1316,7 +1303,7 @@
_generatePopupContent: function(calculator, categories)
{
-var contentHelper = new WebInspector.TimelinePanel.PopupContentHelper(this.title, this._panel);
+var contentHelper = new WebInspector.TimelinePanel.PopupContentHelper(this.title);
if (this._children this._children.length) {
contentHelper._appendTextRow(WebInspector.UIString(Self Time), Number.secondsToString(this._selfTime,
[webkit-changes] [108991] trunk/Source/WebKit/efl
Title: [108991] trunk/Source/WebKit/efl
Revision 108991
Author commit-qu...@webkit.org
Date 2012-02-27 07:07:23 -0800 (Mon, 27 Feb 2012)
Log Message
[EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
https://bugs.webkit.org/show_bug.cgi?id=79031
Patch by JungJik Lee jungjik@samsung.com on 2012-02-27
Reviewed by Zoltan Herczeg.
- Get the pixel data when the cairo surface is created.
- evas_object_image_data_get increases the reference count and returns the image buffer pointer.
evas_object_image_data_set decreases the reference count and when the ref count become zero,
the function releases the cached image inside evas engine.
We should make a pair between evas_object_image_data_set/get to return evas resource.
* ewk/ewk_tiled_backing_store.h:
(_Ewk_Tile):
* ewk/ewk_tiled_model.cpp:
(tile_account):
(ewk_tile_new):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_render_cb):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h
trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp
trunk/Source/WebKit/efl/ewk/ewk_view_tiled.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (108990 => 108991)
--- trunk/Source/WebKit/efl/ChangeLog 2012-02-27 15:05:01 UTC (rev 108990)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-02-27 15:07:23 UTC (rev 108991)
@@ -1,3 +1,24 @@
+2012-02-27 JungJik Lee jungjik@samsung.com
+
+[EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
+https://bugs.webkit.org/show_bug.cgi?id=79031
+
+Reviewed by Zoltan Herczeg.
+
+- Get the pixel data when the cairo surface is created.
+- evas_object_image_data_get increases the reference count and returns the image buffer pointer.
+evas_object_image_data_set decreases the reference count and when the ref count become zero,
+the function releases the cached image inside evas engine.
+We should make a pair between evas_object_image_data_set/get to return evas resource.
+
+* ewk/ewk_tiled_backing_store.h:
+(_Ewk_Tile):
+* ewk/ewk_tiled_model.cpp:
+(tile_account):
+(ewk_tile_new):
+* ewk/ewk_view_tiled.cpp:
+(_ewk_view_tiled_render_cb):
+
2012-02-26 Hajime Morrita morr...@chromium.org
Move ChromeClient::showContextMenu() to ContextMenuClient
Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h (108990 => 108991)
--- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h 2012-02-27 15:05:01 UTC (rev 108990)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h 2012-02-27 15:07:23 UTC (rev 108991)
@@ -77,7 +77,6 @@
*/
int visible; /** visibility counter of this tile */
Evas_Object *image; /** Evas Image, the tile to be rendered */
-uint8_t *pixels;
};
#include ewk_tiled_matrix.h
Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp (108990 => 108991)
--- trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp 2012-02-27 15:05:01 UTC (rev 108990)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp 2012-02-27 15:07:23 UTC (rev 108991)
@@ -221,7 +221,6 @@
evas_object_image_size_set(tile-image, tile-width, tile-height);
evas_object_image_colorspace_set(tile-image, tile-cspace);
-tile-pixels = static_castuint8_t*(evas_object_image_data_get(tile-image, true));
_ewk_tile_account_allocated(tile);
return tile;
Modified: trunk/Source/WebKit/efl/ewk/ewk_view_tiled.cpp (108990 => 108991)
--- trunk/Source/WebKit/efl/ewk/ewk_view_tiled.cpp 2012-02-27 15:05:01 UTC (rev 108990)
+++ trunk/Source/WebKit/efl/ewk/ewk_view_tiled.cpp 2012-02-27 15:07:23 UTC (rev 108991)
@@ -49,7 +49,12 @@
return false;
}
-RefPtrcairo_surface_t surface = adoptRef(cairo_image_surface_create_for_data(tile-pixels, format, tile-width, tile-height, stride));
+uint8_t* pixels = static_castuint8_t*(evas_object_image_data_get(tile-image, true));
+if (!pixels) {
+ERR(fail to get the pixel data from the image object);
+return false;
+}
+RefPtrcairo_surface_t surface = adoptRef(cairo_image_surface_create_for_data(pixels, format, tile-width, tile-height, stride));
cairo_status_t status = cairo_surface_status(surface.get());
if (status != CAIRO_STATUS_SUCCESS) {
ERR(failed to create cairo surface: %s, cairo_status_to_string(status));
@@ -65,7 +70,9 @@
cairo_translate(cairo.get(), -tile-x, -tile-y);
-return ewk_view_paint_contents(priv, cairo.get(), rect);
+bool result = ewk_view_paint_contents(priv, cairo.get(), rect);
+evas_object_image_data_set(tile-image, pixels);
+return result;
}
static void* _ewk_view_tiled_updates_process_pre(void* data, Evas_Object* ewkView)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [108992] trunk/LayoutTests
Title: [108992] trunk/LayoutTests
Revision 108992
Author pfeld...@chromium.org
Date 2012-02-27 07:13:12 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: drop protocol-level tests
https://bugs.webkit.org/show_bug.cgi?id=79671
Reviewed by Vsevolod Vlasov.
* inspector/protocol/console-agent-expected.txt: Removed.
* inspector/protocol/console-agent.html: Removed.
* inspector/protocol/runtime-agent-expected.txt: Removed.
* inspector/protocol/runtime-agent.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/inspector/protocol/console-agent-expected.txt
trunk/LayoutTests/inspector/protocol/console-agent.html
trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt
trunk/LayoutTests/inspector/protocol/runtime-agent.html
Diff
Modified: trunk/LayoutTests/ChangeLog (108991 => 108992)
--- trunk/LayoutTests/ChangeLog 2012-02-27 15:07:23 UTC (rev 108991)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 15:13:12 UTC (rev 108992)
@@ -1,3 +1,15 @@
+2012-02-27 Pavel Feldman pfeld...@google.com
+
+Web Inspector: drop protocol-level tests
+https://bugs.webkit.org/show_bug.cgi?id=79671
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/protocol/console-agent-expected.txt: Removed.
+* inspector/protocol/console-agent.html: Removed.
+* inspector/protocol/runtime-agent-expected.txt: Removed.
+* inspector/protocol/runtime-agent.html: Removed.
+
2012-02-27 Csaba Osztrogonác o...@webkit.org
[Qt][WK2] Skip one more crashing test.
Deleted: trunk/LayoutTests/inspector/protocol/console-agent-expected.txt (108991 => 108992)
--- trunk/LayoutTests/inspector/protocol/console-agent-expected.txt 2012-02-27 15:07:23 UTC (rev 108991)
+++ trunk/LayoutTests/inspector/protocol/console-agent-expected.txt 2012-02-27 15:13:12 UTC (rev 108992)
@@ -1,202 +0,0 @@
-CONSOLE MESSAGE: line 1: test
-CONSOLE MESSAGE: line 1: test
-Protocol stability test. It is dumping request/response pairs of ConsoleAgent functions.
-
-ConsoleAgent.disable()
-
-request:
-{
-method : Console.disable
-id : number
-}
-
-response:
-{
-result : {
-}
-id : number
-}
-
-ConsoleAgent.enable()
-
-request:
-{
-method : Console.enable
-id : number
-}
-
-response:
-{
-result : {
-}
-id : number
-}
-
-RuntimeAgent.evaluate(console.info('test'); console.info('test'),test-group,false)
-
-request:
-{
-method : Runtime.evaluate
-params : {
-_expression_ : console.info('test'); console.info('test')
-objectGroup : test-group
-includeCommandLineAPI : false
-}
-id : number
-}
-
-event ConsoleAgent.messageAdded
-{
-method : Console.messageAdded
-params : {
-message : {
-source : console-api
-level : log
-text : test
-type : log
-line : 1
-url :
-repeatCount : 1
-parameters : [
-{
-type : string
-value : test
-}
-]
-stackTrace : object
-}
-}
-}
-
-event ConsoleAgent.messageRepeatCountUpdated
-{
-method : Console.messageRepeatCountUpdated
-params : {
-count : 2
-}
-}
-
-response:
-{
-result : {
-result : {
-type : undefined
-}
-}
-id : number
-}
-
-ConsoleAgent.clearMessages()
-
-request:
-{
-method : Console.clearMessages
-id : number
-}
-
-event ConsoleAgent.messagesCleared
-{
-method : Console.messagesCleared
-}
-
-response:
-{
-result : {
-}
-id : number
-}
-
-ConsoleAgent.setMonitoringXHREnabled(true)
-
-request:
-{
-method : Console.setMonitoringXHREnabled
-params : {
-enabled : true
-}
-id : number
-}
-
-response:
-{
-result : {
-}
-id : number
-}
-
-ConsoleAgent.setMonitoringXHREnabled(false)
-
-request:
-{
-method : Console.setMonitoringXHREnabled
-params : {
-enabled : false
-}
-id : number
-}
-
-response:
-{
-result : {
-}
-id : number
-}
-
-ConsoleAgent.addInspectedNode(number)
-
-request:
-{
-method : Console.addInspectedNode
-params : {
-nodeId : 1
-}
-id : number
-}
-
-response:
-{
-result : {
-}
-id : number
-}
-
-ConsoleAgent.addInspectedHeapObject(number)
-
-request:
-{
-method : Console.addInspectedHeapObject
-params : {
-heapObjectId : 1
-}
-id : number
-}
-
[webkit-changes] [108993] trunk
Title: [108993] trunk Revision 108993 Author pfeld...@chromium.org Date 2012-02-27 07:22:31 -0800 (Mon, 27 Feb 2012) Log Message Source/WebCore: [Shadow]: Expose one ShadowRoot in the Elements panel (under experiment flag) https://bugs.webkit.org/show_bug.cgi?id=78202 Reviewed by Yury Semikhatsky. * dom/ShadowTree.cpp: (WebCore::ShadowTree::pushShadowRoot): (WebCore::ShadowTree::popShadowRoot): * inspector/Inspector.json: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::assertEditableNode): (WebCore::InspectorDOMAgent::assertEditableElement): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::setAttributeValue): (WebCore::InspectorDOMAgent::setAttributesAsText): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setNodeValue): (WebCore::InspectorDOMAgent::moveTo): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didPushShadowRoot): (WebCore): (WebCore::InspectorDOMAgent::willPopShadowRoot): * inspector/InspectorDOMAgent.h: (WebCore): (InspectorDOMAgent): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didPushShadowRootImpl): (WebCore): (WebCore::InspectorInstrumentation::willPopShadowRootImpl): * inspector/InspectorInstrumentation.h: (WebCore): (InspectorInstrumentation): (WebCore::InspectorInstrumentation::didPushShadowRoot): (WebCore::InspectorInstrumentation::willPopShadowRoot): * inspector/PageConsoleAgent.cpp: (WebCore::PageConsoleAgent::addInspectedNode): * inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype.hasChildNodes): (WebInspector.DOMNode.prototype.isInShadowTree): (WebInspector.DOMNode.prototype._insertChild): (WebInspector.DOMNode.prototype._setChildrenPayload): (WebInspector.DOMDocument): (WebInspector.DOMAgent.prototype._setDetachedRoot): (WebInspector.DOMAgent.prototype._shadowRootPopped): (WebInspector.DOMDispatcher.prototype.childNodeRemoved): (WebInspector.DOMDispatcher.prototype.shadowRootPushed): (WebInspector.DOMDispatcher.prototype.shadowRootPopped): * inspector/front-end/ElementsTreeOutline.js: * inspector/front-end/MemoryStatistics.js: * inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings): * inspector/front-end/inspector.css: (.webkit-html-tag.shadow, .webkit-html-fragment.shadow): LayoutTests: [Shadow]: Expose one ShadowRoot in the Elements panel https://bugs.webkit.org/show_bug.cgi?id=78202 Reviewed by Yury Semikhatsky. * inspector/console/console-dirxml-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/console/console-dirxml-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ShadowTree.cpp trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp trunk/Source/WebCore/inspector/InspectorDOMAgent.h trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp trunk/Source/WebCore/inspector/InspectorInstrumentation.h trunk/Source/WebCore/inspector/PageConsoleAgent.cpp trunk/Source/WebCore/inspector/front-end/DOMAgent.js trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js trunk/Source/WebCore/inspector/front-end/MemoryStatistics.js trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebCore/inspector/front-end/inspector.css Diff Modified: trunk/LayoutTests/ChangeLog (108992 => 108993) --- trunk/LayoutTests/ChangeLog 2012-02-27 15:13:12 UTC (rev 108992) +++ trunk/LayoutTests/ChangeLog 2012-02-27 15:22:31 UTC (rev 108993) @@ -1,5 +1,14 @@ 2012-02-27 Pavel Feldman pfeld...@google.com +[Shadow]: Expose one ShadowRoot in the Elements panel +https://bugs.webkit.org/show_bug.cgi?id=78202 + +Reviewed by Yury Semikhatsky. + +* inspector/console/console-dirxml-expected.txt: + +2012-02-27 Pavel Feldman pfeld...@google.com + Web Inspector: drop protocol-level tests https://bugs.webkit.org/show_bug.cgi?id=79671 Modified: trunk/LayoutTests/inspector/console/console-dirxml-expected.txt (108992 => 108993) --- trunk/LayoutTests/inspector/console/console-dirxml-expected.txt 2012-02-27 15:13:12 UTC (rev 108992) +++ trunk/LayoutTests/inspector/console/console-dirxml-expected.txt 2012-02-27 15:22:31 UTC (rev 108993) @@ -5,7 +5,7 @@ Tests that console logging dumps proper messages. console-dirxml.html:12#document -console-dirxml.html:13Document Fragment +console-dirxml.html:13#document-fragment console-dirxml.html:14p/p console-dirxml.html:15[p/p] Modified: trunk/Source/WebCore/ChangeLog (108992 => 108993) --- trunk/Source/WebCore/ChangeLog 2012-02-27 15:13:12 UTC (rev 108992) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 15:22:31 UTC (rev 108993) @@ -1,3 +1,63 @@ +2012-02-27 Pavel Feldman pfeld...@google.com + +[Shadow]: Expose one ShadowRoot in the Elements panel (under
[webkit-changes] [108994] trunk/LayoutTests
Title: [108994] trunk/LayoutTests Revision 108994 Author loi...@chromium.org Date 2012-02-27 07:49:04 -0800 (Mon, 27 Feb 2012) Log Message Unreviewed fix for lint error after r108992. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (108993 => 108994) --- trunk/LayoutTests/ChangeLog 2012-02-27 15:22:31 UTC (rev 108993) +++ trunk/LayoutTests/ChangeLog 2012-02-27 15:49:04 UTC (rev 108994) @@ -1,3 +1,9 @@ +2012-02-27 Ilya Tikhonovsky loi...@chromium.org + +Unreviewed fix for lint error after r108992. + +* platform/chromium/test_expectations.txt: + 2012-02-27 Pavel Feldman pfeld...@google.com [Shadow]: Expose one ShadowRoot in the Elements panel Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (108993 => 108994) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 15:22:31 UTC (rev 108993) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 15:49:04 UTC (rev 108994) @@ -3604,9 +3604,6 @@ BUGWK76511 MAC : compositing/overflow/scroll-ancestor-update.html = IMAGE BUGWK76511 WIN LINUX : compositing/overflow/scroll-ancestor-update.html = IMAGE+TEXT -// Seems flaky - it depends on property dumping of JS internal fields in a specific order, which doesn't seem stable. -BUGCR110537 : inspector/protocol/runtime-agent.html = PASS TEXT TIMEOUT - BUGWK76727 : fast/multicol/span/span-as-immediate-child-property-removal.html = IMAGE+TEXT TEXT BUGWK76727 : fast/multicol/span/span-as-immediate-columns-child-removal.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108995] trunk
Title: [108995] trunk
Revision 108995
Author apav...@chromium.org
Date 2012-02-27 08:36:53 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: [Styles] Allow adding CSS properties anywhere in the style declaration, not only at the end
https://bugs.webkit.org/show_bug.cgi?id=79662
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setValue):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._applyUserInput):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):
LayoutTests:
* inspector/styles/styles-add-blank-property-expected.txt:
* inspector/styles/styles-add-blank-property.html:
* inspector/styles/styles-formatting.html:
* inspector/styles/styles-history.html:
* inspector/styles/undo-add-property-expected.txt:
* inspector/styles/undo-add-property.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/styles/styles-add-blank-property-expected.txt
trunk/LayoutTests/inspector/styles/styles-add-blank-property.html
trunk/LayoutTests/inspector/styles/styles-formatting.html
trunk/LayoutTests/inspector/styles/styles-history.html
trunk/LayoutTests/inspector/styles/undo-add-property-expected.txt
trunk/LayoutTests/inspector/styles/undo-add-property.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js
trunk/Source/WebCore/inspector/front-end/MetricsSidebarPane.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Diff
Modified: trunk/LayoutTests/ChangeLog (108994 => 108995)
--- trunk/LayoutTests/ChangeLog 2012-02-27 15:49:04 UTC (rev 108994)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 16:36:53 UTC (rev 108995)
@@ -1,3 +1,17 @@
+2012-02-27 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [Styles] Allow adding CSS properties anywhere in the style declaration, not only at the end
+https://bugs.webkit.org/show_bug.cgi?id=79662
+
+Reviewed by Pavel Feldman.
+
+* inspector/styles/styles-add-blank-property-expected.txt:
+* inspector/styles/styles-add-blank-property.html:
+* inspector/styles/styles-formatting.html:
+* inspector/styles/styles-history.html:
+* inspector/styles/undo-add-property-expected.txt:
+* inspector/styles/undo-add-property.html:
+
2012-02-27 Ilya Tikhonovsky loi...@chromium.org
Unreviewed fix for lint error after r108992.
Modified: trunk/LayoutTests/inspector/styles/styles-add-blank-property-expected.txt (108994 => 108995)
--- trunk/LayoutTests/inspector/styles/styles-add-blank-property-expected.txt 2012-02-27 15:49:04 UTC (rev 108994)
+++ trunk/LayoutTests/inspector/styles/styles-add-blank-property-expected.txt 2012-02-27 16:36:53 UTC (rev 108995)
@@ -12,11 +12,25 @@
display: block;
-After append:
+After insertion at index 0:
[expanded]
element.style { ()
+margin-left: 3px;
font-size: 12px;
+
+ Matched CSS Rules
+[expanded]
+div { (user agent stylesheet)
+display: block;
+
+
+After appending and changing a 'compound' property:
+[expanded]
+element.style { ()
margin-left: 3px;
+font-size: 12px;
+color: red;
+font-weight: bold;
Matched CSS Rules
[expanded]
@@ -24,11 +38,12 @@
display: block;
-After append and change of a 'compound' property:
+After insertion at index 2:
[expanded]
element.style { ()
+margin-left: 3px;
font-size: 12px;
-margin-left: 3px;
+/-- overloaded --/ third-property: third-value;
color: red;
font-weight: bold;
Modified: trunk/LayoutTests/inspector/styles/styles-add-blank-property.html (108994 => 108995)
--- trunk/LayoutTests/inspector/styles/styles-add-blank-property.html 2012-02-27 15:49:04 UTC (rev 108994)
+++ trunk/LayoutTests/inspector/styles/styles-add-blank-property.html 2012-02-27 16:36:53 UTC (rev 108995)
@@ -7,12 +7,12 @@
function test()
{
WebInspector.showPanel(elements);
-InspectorTest.selectNodeAndWaitForStyles(inspected, step1);
+InspectorTest.selectNodeAndWaitForStyles(inspected, addAndIncrementFirstProperty);
var treeElement;
var section;
-function step1()
+function addAndIncrementFirstProperty()
{
InspectorTest.addResult(Before append:);
InspectorTest.dumpSelectedElementStyles(true);
@@ -20,7 +20,7 @@
section.expand();
// Create and increment.
-treeElement =
[webkit-changes] [108996] trunk/Source/WebKit/gtk
Title: [108996] trunk/Source/WebKit/gtk Revision 108996 Author k...@webkit.org Date 2012-02-27 08:54:29 -0800 (Mon, 27 Feb 2012) Log Message Build fix for building with GTK+ 2.x. Patch by Vincent Untz vu...@gnome.org and Gustavo Noronha Silva g...@gnome.org on 2012-02-27 * tests/testwebview.c: Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/tests/testwebview.c Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (108995 => 108996) --- trunk/Source/WebKit/gtk/ChangeLog 2012-02-27 16:36:53 UTC (rev 108995) +++ trunk/Source/WebKit/gtk/ChangeLog 2012-02-27 16:54:29 UTC (rev 108996) @@ -1,3 +1,9 @@ +2012-02-27 Vincent Untz vu...@gnome.org and Gustavo Noronha Silva g...@gnome.org + +Build fix for building with GTK+ 2.x. + +* tests/testwebview.c: + 2012-02-26 Hajime Morrita morr...@chromium.org Move ChromeClient::showContextMenu() to ContextMenuClient Modified: trunk/Source/WebKit/gtk/tests/testwebview.c (108995 => 108996) --- trunk/Source/WebKit/gtk/tests/testwebview.c 2012-02-27 16:36:53 UTC (rev 108995) +++ trunk/Source/WebKit/gtk/tests/testwebview.c 2012-02-27 16:54:29 UTC (rev 108996) @@ -27,6 +27,8 @@ #include glib.h #include glib/gstdio.h +#include gdk/gdk.h +#include gdk/gdkkeysyms.h #include gtk/gtk.h #include webkit/webkit.h @@ -389,7 +391,12 @@ GtkWidget *window = gtk_offscreen_window_new(); GtkWidget *webView = webkit_web_view_new(); GtkWidget *entry = gtk_entry_new(); + +#ifdef GTK_API_VERSION_2 +GtkWidget *box = gtk_hbox_new(FALSE, 0); +#else GtkWidget *box = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0); +#endif gtk_container_add(GTK_CONTAINER(box), webView); gtk_container_add(GTK_CONTAINER(box), entry); @@ -424,8 +431,10 @@ pressEvent-key.window = window; g_object_ref(pressEvent-key.window); +#ifndef GTK_API_VERSION_2 GdkDeviceManager* manager = gdk_display_get_device_manager(gdk_window_get_display(window)); gdk_event_set_device(pressEvent, gdk_device_manager_get_client_pointer(manager)); +#endif // When synthesizing an event, an invalid hardware_keycode value // can cause it to be badly processed by Gtk+. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108998] releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Title: [108998] releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk Revision 108998 Author k...@webkit.org Date 2012-02-27 09:01:53 -0800 (Mon, 27 Feb 2012) Log Message Patch from Vincent Untz vu...@gnome.org to fix gtk2 build Modified Paths releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/tests/testwebview.c Diff Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog (108997 => 108998) --- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-02-27 16:58:09 UTC (rev 108997) +++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-02-27 17:01:53 UTC (rev 108998) @@ -1,3 +1,9 @@ +2012-02-27 Vincent Untz vu...@gnome.org + +Build fix for building with GTK+ 2.x. + +* tests/testwebview.c: + 2012-02-22 Martin Robinson mrobin...@igalia.com Update the NEWS file in preparation for the 1.7.90 release. Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/tests/testwebview.c (108997 => 108998) --- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/tests/testwebview.c 2012-02-27 16:58:09 UTC (rev 108997) +++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/tests/testwebview.c 2012-02-27 17:01:53 UTC (rev 108998) @@ -389,7 +389,12 @@ GtkWidget *window = gtk_offscreen_window_new(); GtkWidget *webView = webkit_web_view_new(); GtkWidget *entry = gtk_entry_new(); + +#ifdef GTK_API_VERSION_2 +GtkWidget *box = gtk_hbox_new(FALSE, 0); +#else GtkWidget *box = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0); +#endif gtk_container_add(GTK_CONTAINER(box), webView); gtk_container_add(GTK_CONTAINER(box), entry); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108999] trunk
Title: [108999] trunk
Revision 108999
Author msab...@apple.com
Date 2012-02-27 09:22:29 -0800 (Mon, 27 Feb 2012)
Log Message
Error check regexp min quantifier
https://bugs.webkit.org/show_bug.cgi?id=70648
Reviewed by Gavin Barraclough.
Source/_javascript_Core:
Added checking for min or only quantifier being UINT_MAX.
When encountered this becomes a SyntaxError during parsing.
* yarr/YarrParser.h:
(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parse):
(Parser):
LayoutTests:
New test added to check for newly generated SyntaxError.
* fast/regex/overflow-expected.txt:
* fast/regex/script-tests/overflow.js:
(quantifyMaxInt):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regex/overflow-expected.txt
trunk/LayoutTests/fast/regex/script-tests/overflow.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrParser.h
Diff
Modified: trunk/LayoutTests/ChangeLog (108998 => 108999)
--- trunk/LayoutTests/ChangeLog 2012-02-27 17:01:53 UTC (rev 108998)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 17:22:29 UTC (rev 108999)
@@ -1,3 +1,16 @@
+2012-02-27 Michael Saboff msab...@apple.com
+
+Error check regexp min quantifier
+https://bugs.webkit.org/show_bug.cgi?id=70648
+
+Reviewed by Gavin Barraclough.
+
+New test added to check for newly generated SyntaxError.
+
+* fast/regex/overflow-expected.txt:
+* fast/regex/script-tests/overflow.js:
+(quantifyMaxInt):
+
2012-02-27 Pavel Feldman pfeld...@google.com
Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
Modified: trunk/LayoutTests/fast/regex/overflow-expected.txt (108998 => 108999)
--- trunk/LayoutTests/fast/regex/overflow-expected.txt 2012-02-27 17:01:53 UTC (rev 108998)
+++ trunk/LayoutTests/fast/regex/overflow-expected.txt 2012-02-27 17:22:29 UTC (rev 108999)
@@ -5,7 +5,8 @@
PASS regexp1.exec('') is null
PASS regexp2.exec('') is null
-PASS regexp2.exec(s3) is null
+PASS regexp3.exec(s3) is null
+PASS function f() { /[^a$]{4294967295}/ } threw exception SyntaxError: Invalid regular _expression_: number too large in {} quantifier.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/regex/script-tests/overflow.js (108998 => 108999)
--- trunk/LayoutTests/fast/regex/script-tests/overflow.js 2012-02-27 17:01:53 UTC (rev 108998)
+++ trunk/LayoutTests/fast/regex/script-tests/overflow.js 2012-02-27 17:22:29 UTC (rev 108999)
@@ -8,4 +8,6 @@
var s3 = {6}u4a64YfQP{C}u88c4u5772Qu8693{4294967167}u85f2u7f3fs((uf202){4})u5bc6u1947;
var regexp3 = new RegExp(s3, );
-shouldBe(regexp2.exec(s3), 'null');
+shouldBe(regexp3.exec(s3), 'null');
+
+shouldThrow(function f() { /[^a$]{4294967295}/ }, 'SyntaxError: Invalid regular _expression_: number too large in {} quantifier');
Modified: trunk/Source/_javascript_Core/ChangeLog (108998 => 108999)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-27 17:01:53 UTC (rev 108998)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-27 17:22:29 UTC (rev 108999)
@@ -1,3 +1,18 @@
+2012-02-27 Michael Saboff msab...@apple.com
+
+Error check regexp min quantifier
+https://bugs.webkit.org/show_bug.cgi?id=70648
+
+Reviewed by Gavin Barraclough.
+
+Added checking for min or only quantifier being UINT_MAX.
+When encountered this becomes a SyntaxError during parsing.
+
+* yarr/YarrParser.h:
+(JSC::Yarr::Parser::parseQuantifier):
+(JSC::Yarr::Parser::parse):
+(Parser):
+
2012-02-27 Carlos Garcia Campos cgar...@igalia.com
Unreviewed. Fix make distcheck.
Modified: trunk/Source/_javascript_Core/yarr/YarrParser.h (108998 => 108999)
--- trunk/Source/_javascript_Core/yarr/YarrParser.h 2012-02-27 17:01:53 UTC (rev 108998)
+++ trunk/Source/_javascript_Core/yarr/YarrParser.h 2012-02-27 17:22:29 UTC (rev 108999)
@@ -54,6 +54,7 @@
PatternTooLarge,
QuantifierOutOfOrder,
QuantifierWithoutAtom,
+QuantifierTooLarge,
MissingParentheses,
ParenthesesUnmatched,
ParenthesesTypeInvalid,
@@ -546,6 +547,11 @@
ASSERT(!m_err);
ASSERT(min = max);
+if (min == UINT_MAX) {
+m_err = QuantifierTooLarge;
+return;
+}
+
if (lastTokenWasAnAtom)
m_delegate.quantifyAtom(min, max, !tryConsume('?'));
else
@@ -685,6 +691,7 @@
REGEXP_ERROR_PREFIX regular _expression_ too large,
REGEXP_ERROR_PREFIX numbers out of order in {} quantifier,
REGEXP_ERROR_PREFIX nothing to repeat,
+REGEXP_ERROR_PREFIX number too large in {} quantifier,
REGEXP_ERROR_PREFIX missing ),
REGEXP_ERROR_PREFIX unmatched parentheses,
REGEXP_ERROR_PREFIX unrecognized character after (?,
@@ -696,7 +703,6 @@
return errorMessages[m_err];
}
-
// Misc helper
[webkit-changes] [109000] trunk/Source/WebCore
Title: [109000] trunk/Source/WebCore
Revision 109000
Author pfeld...@chromium.org
Date 2012-02-27 09:34:37 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: Ctrl+K should not zoom in
https://bugs.webkit.org/show_bug.cgi?id=79676
Reviewed by Vsevolod Vlasov.
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (108999 => 109000)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 17:22:29 UTC (rev 108999)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 17:34:37 UTC (rev 109000)
@@ -1,5 +1,15 @@
2012-02-27 Pavel Feldman pfeld...@google.com
+Web Inspector: Ctrl+K should not zoom in
+https://bugs.webkit.org/show_bug.cgi?id=79676
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/inspector.js:
+(WebInspector.documentKeyDown):
+
+2012-02-27 Pavel Feldman pfeld...@google.com
+
Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
https://bugs.webkit.org/show_bug.cgi?id=79675
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (108999 => 109000)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2012-02-27 17:22:29 UTC (rev 108999)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2012-02-27 17:34:37 UTC (rev 109000)
@@ -722,19 +722,24 @@
event.preventDefault();
}
break;
-case U+004B: // +
+}
+
+switch (event.keyCode) {
+case 107: // +
+case 187: // +
if (hasCtrlOrMeta !InspectorFrontendHost.isStub) {
WebInspector._zoomIn();
event.preventDefault();
}
break;
-case U+004D: // -
+case 109: // -
+case 189: // -
if (hasCtrlOrMeta !InspectorFrontendHost.isStub) {
WebInspector._zoomOut();
event.preventDefault();
}
break;
-case U+0030: // 0
+case 48: // 0
if (hasCtrlOrMeta !InspectorFrontendHost.isStub) {
WebInspector._resetZoom();
event.preventDefault();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109001] trunk/LayoutTests
Title: [109001] trunk/LayoutTests Revision 109001 Author e...@google.com Date 2012-02-27 09:42:51 -0800 (Mon, 27 Feb 2012) Log Message [chromium] Unreviewed gardening, mark getPutImageDataPair as slow https://bugs.webkit.org/show_bug.cgi?id=79679 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109000 => 109001) --- trunk/LayoutTests/ChangeLog 2012-02-27 17:34:37 UTC (rev 109000) +++ trunk/LayoutTests/ChangeLog 2012-02-27 17:42:51 UTC (rev 109001) @@ -1,3 +1,10 @@ +2012-02-27 Adrienne Walker e...@google.com + +[chromium] Unreviewed gardening, mark getPutImageDataPair as slow +https://bugs.webkit.org/show_bug.cgi?id=79679 + +* platform/chromium/test_expectations.txt: + 2012-02-27 Michael Saboff msab...@apple.com Error check regexp min quantifier Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109000 => 109001) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 17:34:37 UTC (rev 109000) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 17:42:51 UTC (rev 109001) @@ -60,6 +60,8 @@ BUGWK77523 WIN SLOW : media/media-fragments/TC0050-TC0059.html = PASS BUGWK77523 WIN RELEASE SLOW : media/media-fragments/TC0080-TC0089.html = PASS +BUGWK79679 DEBUG GPU SLOW : fast/canvas/getPutImageDataPairTest.html = PASS + // - // TEMPORARILY SKIPPED TESTS // - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109002] trunk/Source
Title: [109002] trunk/Source Revision 109002 Author timo...@apple.com Date 2012-02-27 09:51:06 -0800 (Mon, 27 Feb 2012) Log Message Add WKInspector API to know when the Web Inspector is the frontmost window. https://webkit.org/b/79649 Reviewed by John Sullivan. Source/WebCore: Updated for WebKit2 string changes. * English.lproj/Localizable.strings: Updated. Source/WebKit2: Also makes the Safari Develop menu items work when the Web Inspector is frontmost. * UIProcess/API/C/WKInspector.cpp: (WKInspectorIsFront): Added. Call WebInspectorProxy::isFront. * UIProcess/API/C/WKInspector.h: * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::isFront): Added. Call platformIsFront. * UIProcess/WebInspectorProxy.h: * UIProcess/efl/WebInspectorEfl.cpp: (WebKit::WebInspectorProxy::platformIsFront): Added stub. * UIProcess/gtk/WebInspectorGtk.cpp: (WebKit::WebInspectorProxy::platformIsFront): Added stub. * UIProcess/mac/WebInspectorProxyMac.mm: (-[WKWebInspectorProxyObjCAdapter showWebInspector:]): Added. Makes the Develop menu items in Safari work when the Web Inspector window is front. (-[WKWebInspectorProxyObjCAdapter showErrorConsole:]): Added. Ditto. (-[WKWebInspectorProxyObjCAdapter showResources:]): Added. Ditto. (-[WKWebInspectorProxyObjCAdapter viewSource:]): Added. Ditto. (-[WKWebInspectorProxyObjCAdapter toggleDebuggingJavaScript:]): Added. Ditto. (-[WKWebInspectorProxyObjCAdapter toggleProfilingJavaScript:]): Added. Ditto. (-[WKWebInspectorProxyObjCAdapter validateUserInterfaceItem:]): Added. Update the menu item titles. (WebKit::WebInspectorProxy::platformIsFront): Added. Return if visible and the window is main. * UIProcess/qt/WebInspectorProxyQt.cpp: (WebKit::WebInspectorProxy::platformIsFront): Added stub. * UIProcess/win/WebInspectorProxyWin.cpp: (WebKit::WebInspectorProxy::platformIsFront): Added stub. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/Localizable.strings trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp trunk/Source/WebKit2/UIProcess/API/C/WKInspector.h trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp trunk/Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm trunk/Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (109001 => 109002) --- trunk/Source/WebCore/ChangeLog 2012-02-27 17:42:51 UTC (rev 109001) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 17:51:06 UTC (rev 109002) @@ -1,3 +1,13 @@ +2012-02-27 Timothy Hatcher timo...@apple.com + +Updated for WebKit2 string changes. + +https://webkit.org/b/79649 + +Reviewed by John Sullivan. + +* English.lproj/Localizable.strings: Updated. + 2012-02-27 Pavel Feldman pfeld...@google.com Web Inspector: Ctrl+K should not zoom in Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (109001 => 109002) --- trunk/Source/WebCore/English.lproj/Localizable.strings 2012-02-27 17:42:51 UTC (rev 109001) +++ trunk/Source/WebCore/English.lproj/Localizable.strings 2012-02-27 17:51:06 UTC (rev 109002) @@ -100,9 +100,6 @@ / * C o p y I m a g e c o n t e x t m e n u i t e m * / C o p y I m a g e = C o p y I m a g e ; - / * C o p y I m a g e A d d r e s s m e n u i t e m * / - C o p y I m a g e A d d r e s s = C o p y I m a g e A d d r e s s ; - / * C o p y L i n k c o n t e x t m e n u i t e m * / C o p y L i n k = C o p y L i n k ; @@ -163,6 +160,9 @@ / * m e n u i t e m t i t l e * / H i d e S u b s t i t u t i o n s = H i d e S u b s t i t u t i o n s ; + / * t i t l e f o r H i d e W e b I n s p e c t o r m e n u i t e m * / + H i d e W e b I n s p e c t o r = H i d e W e b I n s p e c t o r ; + / * T h e d e f a u l t , d e f a u l t c h a r a c t e r e n c o d i n g * / I S O - 8 8 5 9 - 1 = I S O - 8 8 5 9 - 1 ; Modified: trunk/Source/WebKit2/ChangeLog (109001 => 109002) --- trunk/Source/WebKit2/ChangeLog 2012-02-27 17:42:51 UTC (rev 109001) +++ trunk/Source/WebKit2/ChangeLog 2012-02-27 17:51:06 UTC (rev 109002) @@ -1,3 +1,38 @@ +2012-02-27 Timothy Hatcher timo...@apple.com + +Add WKInspector API to know when the Web Inspector is the frontmost window. + +Also makes the Safari Develop menu items work when the Web Inspector is frontmost. + +https://webkit.org/b/79649 + +Reviewed by John Sullivan. + +* UIProcess/API/C/WKInspector.cpp: +(WKInspectorIsFront): Added. Call WebInspectorProxy::isFront. +* UIProcess/API/C/WKInspector.h: +* UIProcess/WebInspectorProxy.cpp: +
[webkit-changes] [109003] trunk/Source/WebCore
Title: [109003] trunk/Source/WebCore
Revision 109003
Author commit-qu...@webkit.org
Date 2012-02-27 09:57:55 -0800 (Mon, 27 Feb 2012)
Log Message
Stop recomputing SVG path data twice during layout
https://bugs.webkit.org/show_bug.cgi?id=79672
Patch by Philip Rogers p...@google.com on 2012-02-27
Reviewed by Nikolas Zimmermann.
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109002 => 109003)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 17:51:06 UTC (rev 109002)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 17:57:55 UTC (rev 109003)
@@ -1,3 +1,13 @@
+2012-02-27 Philip Rogers p...@google.com
+
+Stop recomputing SVG path data twice during layout
+https://bugs.webkit.org/show_bug.cgi?id=79672
+
+Reviewed by Nikolas Zimmermann.
+
+* rendering/svg/RenderSVGShape.cpp:
+(WebCore::RenderSVGShape::layout):
+
2012-02-27 Timothy Hatcher timo...@apple.com
Updated for WebKit2 string changes.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp (109002 => 109003)
--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-02-27 17:51:06 UTC (rev 109002)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-02-27 17:57:55 UTC (rev 109003)
@@ -168,7 +168,7 @@
bool updateCachedBoundariesInParents = false;
bool needsShapeUpdate = m_needsShapeUpdate;
-if (needsShapeUpdate) {
+if (needsShapeUpdate || m_needsBoundariesUpdate) {
setIsPaintingFallback(false);
m_path.clear();
createShape();
@@ -182,13 +182,6 @@
updateCachedBoundariesInParents = true;
}
-if (m_needsBoundariesUpdate) {
-setIsPaintingFallback(false);
-m_path.clear();
-createShape();
-updateCachedBoundariesInParents = true;
-}
-
// Invalidate all resources of this client if our layout changed.
if (everHadLayout() selfNeedsLayout()) {
SVGResourcesCache::clientLayoutChanged(this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109004] trunk
Title: [109004] trunk Revision 109004 Author m...@apple.com Date 2012-02-27 10:00:23 -0800 (Mon, 27 Feb 2012) Log Message Source/WebKit2: rdar://problem/9557598 REGRESSION (WebKit2): Non-activating links sometimes don’t work https://bugs.webkit.org/show_bug.cgi?id=79607 Reviewed by Adele Peterson. Test: TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm This was caused by not mapping the mouse event coordinates from window coordinates to document coordinates. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::performDictionaryLookupAtLocation): Convert the point to main frame coordinates when performing the hit test. (WebKit::WebPage::shouldDelayWindowOrderingEvent): Convert the point to the main or focused frame coordinates when perfomring the hit test. (WebKit::WebPage::acceptsFirstMouse): Ditto. Tools: Added a test for rdar://problem/9557598 REGRESSION (WebKit2): Non-activating links sometimes don’t work https://bugs.webkit.org/show_bug.cgi?id=79607 Reviewed by Adele Peterson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files. * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added. (TestWebKitAPI::AcceptsFirstMouse::url): (TestWebKitAPI::AcceptsFirstMouse::didLoadURL): (TestWebKitAPI::AcceptsFirstMouse::runTest): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths trunk/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm trunk/Tools/TestWebKitAPI/Tests/mac/acceptsFirstMouse.html Diff Modified: trunk/Source/WebKit2/ChangeLog (109003 => 109004) --- trunk/Source/WebKit2/ChangeLog 2012-02-27 17:57:55 UTC (rev 109003) +++ trunk/Source/WebKit2/ChangeLog 2012-02-27 18:00:23 UTC (rev 109004) @@ -1,3 +1,22 @@ +2012-02-27 Dan Bernstein m...@apple.com + +rdar://problem/9557598 REGRESSION (WebKit2): Non-activating links sometimes don’t work +https://bugs.webkit.org/show_bug.cgi?id=79607 + +Reviewed by Adele Peterson. + +Test: TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm + +This was caused by not mapping the mouse event coordinates from window coordinates to +document coordinates. + +* WebProcess/WebPage/mac/WebPageMac.mm: +(WebKit::WebPage::performDictionaryLookupAtLocation): Convert the point to main frame +coordinates when performing the hit test. +(WebKit::WebPage::shouldDelayWindowOrderingEvent): Convert the point to the main or focused +frame coordinates when perfomring the hit test. +(WebKit::WebPage::acceptsFirstMouse): Ditto. + 2012-02-27 Timothy Hatcher timo...@apple.com Add WKInspector API to know when the Web Inspector is the frontmost window. Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (109003 => 109004) --- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2012-02-27 17:57:55 UTC (rev 109003) +++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2012-02-27 18:00:23 UTC (rev 109004) @@ -440,7 +440,7 @@ // Find the frame the point is over. IntPoint point = roundedIntPoint(floatPoint); -HitTestResult result = frame-eventHandler()-hitTestResultAtPoint(point, false); +HitTestResult result = frame-eventHandler()-hitTestResultAtPoint(frame-view()-windowToContents(point), false); frame = result.innerNonSharedNode() ? result.innerNonSharedNode()-document()-frame() : m_page-focusController()-focusedOrMainFrame(); IntPoint translatedPoint = frame-view()-windowToContents(point); @@ -687,7 +687,7 @@ if (!frame) return; -HitTestResult hitResult = frame-eventHandler()-hitTestResultAtPoint(event.position(), true); +HitTestResult hitResult = frame-eventHandler()-hitTestResultAtPoint(frame-view()-windowToContents(event.position()), true); if (hitResult.isSelected()) result = frame-eventHandler()-eventMayStartDrag(platform(event)); } @@ -699,7 +699,7 @@ if (!frame) return; -HitTestResult hitResult = frame-eventHandler()-hitTestResultAtPoint(event.position(), true); +HitTestResult hitResult = frame-eventHandler()-hitTestResultAtPoint(frame-view()-windowToContents(event.position()), true); frame-eventHandler()-setActivationEventNumber(eventNumber); if (hitResult.isSelected()) result = frame-eventHandler()-eventMayStartDrag(platform(event)); Modified: trunk/Tools/ChangeLog (109003 => 109004) --- trunk/Tools/ChangeLog 2012-02-27 17:57:55 UTC (rev 109003) +++ trunk/Tools/ChangeLog 2012-02-27 18:00:23 UTC (rev 109004) @@ -1,3 +1,18 @@ +2012-02-27 Dan Bernstein m...@apple.com + +Added a test for rdar://problem/9557598 REGRESSION (WebKit2): Non-activating links sometimes don’t work +https://bugs.webkit.org/show_bug.cgi?id=79607 + +Reviewed by Adele
[webkit-changes] [109005] trunk/Source/WebCore
Title: [109005] trunk/Source/WebCore Revision 109005 Author ph...@webkit.org Date 2012-02-27 10:04:18 -0800 (Mon, 27 Feb 2012) Log Message [GStreamer] 0.11 support in MediaPlayerPrivateGStreamer https://bugs.webkit.org/show_bug.cgi?id=77089 Reviewed by Martin Robinson. Basic port to GStreamer 0.11 APIs. This patch excludes the video painting changes and the GStreamerGWorld changes which are handled in two other patches (bugs 77087 and 77088). * GNUmakefile.list.am: Add GStreamerVersioning files to the build. * Source/WebCore/PlatformEfl.cmake: Ditto. * Source/WebCore/Target.pri: Ditto. * platform/graphics/gstreamer/GRefPtrGStreamer.cpp: (WTF::GstElement): (WTF::GstPad): (WTF::GstPadTemplate): (WTF::GstTask): * platform/graphics/gstreamer/GStreamerVersioning.cpp: Added. (webkit_gst_object_ref_sink): (webkit_gst_element_get_pad_caps): * platform/graphics/gstreamer/GStreamerVersioning.h: Added. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::isAvailable): (WebCore::MediaPlayerPrivateGStreamer::duration): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/Target.pri trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Added Paths trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h Diff Modified: trunk/Source/WebCore/ChangeLog (109004 => 109005) --- trunk/Source/WebCore/ChangeLog 2012-02-27 18:00:23 UTC (rev 109004) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 18:04:18 UTC (rev 109005) @@ -1,3 +1,31 @@ +2012-02-27 Philippe Normand pnorm...@igalia.com + +[GStreamer] 0.11 support in MediaPlayerPrivateGStreamer +https://bugs.webkit.org/show_bug.cgi?id=77089 + +Reviewed by Martin Robinson. + +Basic port to GStreamer 0.11 APIs. This patch excludes the video +painting changes and the GStreamerGWorld changes which are handled +in two other patches (bugs 77087 and 77088). + +* GNUmakefile.list.am: Add GStreamerVersioning files to the build. +* Source/WebCore/PlatformEfl.cmake: Ditto. +* Source/WebCore/Target.pri: Ditto. +* platform/graphics/gstreamer/GRefPtrGStreamer.cpp: +(WTF::GstElement): +(WTF::GstPad): +(WTF::GstPadTemplate): +(WTF::GstTask): +* platform/graphics/gstreamer/GStreamerVersioning.cpp: Added. +(webkit_gst_object_ref_sink): +(webkit_gst_element_get_pad_caps): +* platform/graphics/gstreamer/GStreamerVersioning.h: Added. +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: +(WebCore::MediaPlayerPrivateGStreamer::isAvailable): +(WebCore::MediaPlayerPrivateGStreamer::duration): +(WebCore::MediaPlayerPrivateGStreamer::naturalSize): + 2012-02-27 Philip Rogers p...@google.com Stop recomputing SVG path data twice during layout Modified: trunk/Source/WebCore/GNUmakefile.list.am (109004 => 109005) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-02-27 18:00:23 UTC (rev 109004) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-02-27 18:04:18 UTC (rev 109005) @@ -4530,6 +4530,8 @@ Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h \ Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp \ Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h \ + Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp \ + Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h \ Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp \ Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h \ Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp \ Modified: trunk/Source/WebCore/PlatformEfl.cmake (109004 => 109005) --- trunk/Source/WebCore/PlatformEfl.cmake 2012-02-27 18:00:23 UTC (rev 109004) +++ trunk/Source/WebCore/PlatformEfl.cmake 2012-02-27 18:04:18 UTC (rev 109005) @@ -188,6 +188,7 @@ LIST(APPEND WebCore_SOURCES platform/graphics/gstreamer/GRefPtrGStreamer.cpp platform/graphics/gstreamer/GStreamerGWorld.cpp +platform/graphics/gstreamer/GStreamerVersioning.cpp platform/graphics/gstreamer/ImageGStreamerCairo.cpp platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp Modified: trunk/Source/WebCore/Target.pri (109004 => 109005) --- trunk/Source/WebCore/Target.pri 2012-02-27 18:00:23 UTC (rev 109004) +++ trunk/Source/WebCore/Target.pri 2012-02-27 18:04:18 UTC (rev 109005) @@ -3231,6 +3231,7 @@ HEADERS += \ platform/graphics/gstreamer/GRefPtrGStreamer.h \
[webkit-changes] [109006] trunk/Source/WebCore
Title: [109006] trunk/Source/WebCore
Revision 109006
Author vse...@chromium.org
Date 2012-02-27 10:15:43 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: Scripts navigator overlay should not consume mouse actions.
https://bugs.webkit.org/show_bug.cgi?id=79674
Reviewed by Pavel Feldman.
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.registerShortcut):
(WebInspector.Panel.prototype.unregisterShortcut):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):
* inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype._containingElementFocused):
(WebInspector.SidebarOverlay.prototype.position):
(WebInspector.SidebarOverlay.prototype.hide):
(WebInspector.SidebarOverlay.prototype._setWidth):
* inspector/front-end/dialog.css:
(.go-to-line-dialog button:active):
* inspector/front-end/scriptsPanel.css:
(#scripts-editor-view .sidebar-overlay):
* inspector/front-end/splitView.css:
(.split-view-resizer):
(.sidebar-overlay):
(.sidebar-overlay-resizer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Panel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/SidebarOverlay.js
trunk/Source/WebCore/inspector/front-end/dialog.css
trunk/Source/WebCore/inspector/front-end/scriptsPanel.css
trunk/Source/WebCore/inspector/front-end/splitView.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (109005 => 109006)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 18:04:18 UTC (rev 109005)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 18:15:43 UTC (rev 109006)
@@ -1,3 +1,37 @@
+2012-02-27 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Scripts navigator overlay should not consume mouse actions.
+https://bugs.webkit.org/show_bug.cgi?id=79674
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/Panel.js:
+(WebInspector.Panel.prototype.registerShortcut):
+(WebInspector.Panel.prototype.unregisterShortcut):
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._editorClosed):
+(WebInspector.ScriptsPanel.prototype._editorSelected):
+(WebInspector.ScriptsPanel.prototype._fileSelected):
+(WebInspector.ScriptsPanel.prototype._escDownWhileNavigatorOverlayOpen):
+(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
+(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
+(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):
+* inspector/front-end/SidebarOverlay.js:
+(WebInspector.SidebarOverlay):
+(WebInspector.SidebarOverlay.prototype.show):
+(WebInspector.SidebarOverlay.prototype._containingElementFocused):
+(WebInspector.SidebarOverlay.prototype.position):
+(WebInspector.SidebarOverlay.prototype.hide):
+(WebInspector.SidebarOverlay.prototype._setWidth):
+* inspector/front-end/dialog.css:
+(.go-to-line-dialog button:active):
+* inspector/front-end/scriptsPanel.css:
+(#scripts-editor-view .sidebar-overlay):
+* inspector/front-end/splitView.css:
+(.split-view-resizer):
+(.sidebar-overlay):
+(.sidebar-overlay-resizer):
+
2012-02-27 Philippe Normand pnorm...@igalia.com
[GStreamer] 0.11 support in MediaPlayerPrivateGStreamer
Modified: trunk/Source/WebCore/inspector/front-end/Panel.js (109005 => 109006)
--- trunk/Source/WebCore/inspector/front-end/Panel.js 2012-02-27 18:04:18 UTC (rev 109005)
+++ trunk/Source/WebCore/inspector/front-end/Panel.js 2012-02-27 18:15:43 UTC (rev 109006)
@@ -212,6 +212,11 @@
registerShortcut: function(key, handler)
{
this._shortcuts[key] = handler;
+},
+
+unregisterShortcut: function(key)
+{
+delete this._shortcuts[key];
}
}
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (109005 => 109006)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-02-27 18:04:18 UTC (rev 109005)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-02-27 18:15:43 UTC (rev 109006)
@@ -67,6 +67,7 @@
const minimalViewsContainerWidthPercent = 50;
this.editorView = new WebInspector.SplitView(WebInspector.SplitView.SidebarPosition.Left, scriptsPanelNavigatorSidebarWidth, initialNavigatorWidth);
this.editorView.element.id = scripts-editor-view;
+this.editorView.element.tabIndex = 0;
[webkit-changes] [109007] trunk/Source/JavaScriptCore
Title: [109007] trunk/Source/_javascript_Core Revision 109007 Author barraclo...@apple.com Date 2012-02-27 10:26:23 -0800 (Mon, 27 Feb 2012) Log Message Implement support for op_negate and op_bitnot in the DFG JIT https://bugs.webkit.org/show_bug.cgi?id=79617 Reviewed by Sam Weinig. Remove op_bitnop - this is redundant, ~x === x^-1. This is a fractional (1%) progression. Remove not32(X) from the MacroAssemblers - make this an optimization to add32(-1, X). Remove CanReuse from the result type - this was unused. Remove op_bitnot. * assembler/MacroAssemblerARM.h: (MacroAssemblerARM): (JSC::MacroAssemblerARM::xor32): * assembler/MacroAssemblerARMv7.h: (MacroAssemblerARMv7): (JSC::MacroAssemblerARMv7::xor32): * assembler/MacroAssemblerMIPS.h: (MacroAssemblerMIPS): (JSC::MacroAssemblerMIPS::xor32): * assembler/MacroAssemblerSH4.h: (MacroAssemblerSH4): (JSC::MacroAssemblerSH4::xor32): * assembler/MacroAssemblerX86Common.h: (MacroAssemblerX86Common): (JSC::MacroAssemblerX86Common::xor32): * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): * bytecode/Opcode.h: (JSC): (JSC::padOpcodeName): * bytecompiler/NodesCodegen.cpp: (JSC): (JSC::BitwiseNotNode::emitBytecode): * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): * jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): * jit/JIT.h: (JIT): * jit/JITArithmetic32_64.cpp: (JSC): * jit/JITOpcodes.cpp: (JSC): * jit/JITStubs.cpp: (JSC): * jit/JITStubs.h: * llint/LLIntSlowPaths.cpp: (LLInt): * llint/LLIntSlowPaths.h: (LLInt): * llint/LowLevelInterpreter32_64.asm: * parser/NodeConstructors.h: (JSC::NegateNode::NegateNode): (JSC::BitwiseNotNode::BitwiseNotNode): (JSC::MultNode::MultNode): (JSC::DivNode::DivNode): (JSC::ModNode::ModNode): (JSC::SubNode::SubNode): (JSC::UnsignedRightShiftNode::UnsignedRightShiftNode): * parser/Nodes.h: (BitwiseNotNode): (JSC::BitwiseNotNode::expr): (JSC): * parser/ResultType.h: (ResultType): (JSC::ResultType::numberTypeIsInt32): (JSC::ResultType::stringOrNumberType): (JSC::ResultType::forAdd): (JSC::ResultType::forBitOp): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/Opcode.h trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/jit/JIT.cpp trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp trunk/Source/_javascript_Core/jit/JITOpcodes.cpp trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/jit/JITStubs.h trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp trunk/Source/_javascript_Core/llint/LLIntSlowPaths.h trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm trunk/Source/_javascript_Core/parser/NodeConstructors.h trunk/Source/_javascript_Core/parser/Nodes.h trunk/Source/_javascript_Core/parser/ResultType.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (109006 => 109007) --- trunk/Source/_javascript_Core/ChangeLog 2012-02-27 18:15:43 UTC (rev 109006) +++ trunk/Source/_javascript_Core/ChangeLog 2012-02-27 18:26:23 UTC (rev 109007) @@ -1,3 +1,78 @@ +2012-02-27 Gavin Barraclough barraclo...@apple.com + +Implement support for op_negate and op_bitnot in the DFG JIT +https://bugs.webkit.org/show_bug.cgi?id=79617 + +Reviewed by Sam Weinig. + +Remove op_bitnop - this is redundant, ~x === x^-1. +This is a fractional (1%) progression. + +Remove not32(X) from the MacroAssemblers - make this an optimization to add32(-1, X). +Remove CanReuse from the result type - this was unused. +Remove op_bitnot. + +* assembler/MacroAssemblerARM.h: +(MacroAssemblerARM): +(JSC::MacroAssemblerARM::xor32): +* assembler/MacroAssemblerARMv7.h: +(MacroAssemblerARMv7): +(JSC::MacroAssemblerARMv7::xor32): +* assembler/MacroAssemblerMIPS.h: +(MacroAssemblerMIPS): +(JSC::MacroAssemblerMIPS::xor32): +* assembler/MacroAssemblerSH4.h: +(MacroAssemblerSH4): +(JSC::MacroAssemblerSH4::xor32): +* assembler/MacroAssemblerX86Common.h: +(MacroAssemblerX86Common): +(JSC::MacroAssemblerX86Common::xor32): +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::dump): +* bytecode/Opcode.h: +(JSC): +(JSC::padOpcodeName): +* bytecompiler/NodesCodegen.cpp: +(JSC): +(JSC::BitwiseNotNode::emitBytecode): +* interpreter/Interpreter.cpp: +(JSC::Interpreter::privateExecute): +*
[webkit-changes] [109008] trunk
Title: [109008] trunk
Revision 109008
Author barraclo...@apple.com
Date 2012-02-27 10:29:04 -0800 (Mon, 27 Feb 2012)
Log Message
RegExp lastIndex should behave as a regular property
https://bugs.webkit.org/show_bug.cgi?id=79446
Reviewed by Sam Weinig.
lastIndex should be a regular data descriptor, with the attributes configurable:false,
enumerable:false, writable:true. As such, it should be possible to reconfigure writable
as false. If the lastIndex property is reconfigured to be read-only, we should respect
this correctly.
Source/_javascript_Core:
* runtime/CommonIdentifiers.h:
- Removed some unused identifiers, added lastIndex.
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertySlot):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getOwnPropertyDescriptor):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::deleteProperty):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getOwnPropertyNames):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getPropertyNames):
- lastIndex is no longer a static value, provided specific handling.
(JSC::reject):
- helper function for defineOwnProperty.
(JSC::RegExpObject::defineOwnProperty):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::put):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::match):
- Pass setLastIndex an ExecState, so it can throw if read-only.
* runtime/RegExpObject.h:
(JSC::RegExpObject::setLastIndex):
- Pass setLastIndex an ExecState, so it can throw if read-only.
(RegExpObjectData):
- Added lastIndexIsWritable.
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
- Pass setLastIndex an ExecState, so it can throw if read-only.
LayoutTests:
* fast/regex/lastIndex-expected.txt: Added.
* fast/regex/lastIndex.html: Added.
* fast/regex/script-tests/lastIndex.js: Added.
- Added test cases for correct handling of lastIndex.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/CommonIdentifiers.h
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.h
trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp
Added Paths
trunk/LayoutTests/fast/regex/lastIndex-expected.txt
trunk/LayoutTests/fast/regex/lastIndex.html
trunk/LayoutTests/fast/regex/script-tests/lastIndex.js
Diff
Modified: trunk/LayoutTests/ChangeLog (109007 => 109008)
--- trunk/LayoutTests/ChangeLog 2012-02-27 18:26:23 UTC (rev 109007)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 18:29:04 UTC (rev 109008)
@@ -1,3 +1,20 @@
+2012-02-27 Gavin Barraclough barraclo...@apple.com
+
+RegExp lastIndex should behave as a regular property
+https://bugs.webkit.org/show_bug.cgi?id=79446
+
+Reviewed by Sam Weinig.
+
+lastIndex should be a regular data descriptor, with the attributes configurable:false,
+enumerable:false, writable:true. As such, it should be possible to reconfigure writable
+as false. If the lastIndex property is reconfigured to be read-only, we should respect
+this correctly.
+
+* fast/regex/lastIndex-expected.txt: Added.
+* fast/regex/lastIndex.html: Added.
+* fast/regex/script-tests/lastIndex.js: Added.
+- Added test cases for correct handling of lastIndex.
+
2012-02-27 Adrienne Walker e...@google.com
[chromium] Unreviewed gardening, mark getPutImageDataPair as slow
Added: trunk/LayoutTests/fast/regex/lastIndex-expected.txt (0 => 109008)
--- trunk/LayoutTests/fast/regex/lastIndex-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/regex/lastIndex-expected.txt 2012-02-27 18:29:04 UTC (rev 109008)
@@ -0,0 +1,30 @@
+This page tests that a RegExp object's lastIndex behaves like a regular property.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS delete /x/.lastIndex is false
+PASS 'use strict'; delete /x/.lastIndex threw exception TypeError: Unable to delete property..
+PASS 'lastIndex' in /x/ is true
+PASS for (property in /x/) if (property === 'lastIndex') throw false; true is true
+PASS var re = /x/; re.lastIndex = re; re.lastIndex === re is true
+PASS Object.defineProperty(/x/, {get:function(){}}) threw exception TypeError: Property description must be an object..
+PASS Object.defineProperty(/x/, 'lastIndex', {enumerable:true}); true threw exception TypeError: Attempting to change enumerable attribute of unconfigurable property..
+PASS Object.defineProperty(/x/, 'lastIndex', {enumerable:false}); true is true
+PASS Object.defineProperty(/x/, 'lastIndex', {configurable:true}); true threw exception TypeError: Attempting to change configurable attribute of unconfigurable
[webkit-changes] [109010] branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
Title: [109010] branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
Revision 109010
Author le...@chromium.org
Date 2012-02-27 11:26:24 -0800 (Mon, 27 Feb 2012)
Log Message
Properly using pixel snapping to determing RenderLayer size on Layered Inlines.
Modified Paths
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp (109009 => 109010)
--- branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp 2012-02-27 19:14:28 UTC (rev 109009)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp 2012-02-27 19:26:24 UTC (rev 109010)
@@ -741,7 +741,7 @@
if (renderer()-isRenderInline()) {
RenderInline* inlineFlow = toRenderInline(renderer());
LayoutRect lineBox = inlineFlow-linesBoundingBox();
-setSize(expandedIntSize(lineBox.size()));
+setSize(pixelSnappedIntSize(lineBox.size(), lineBox.location()));
inlineBoundingBoxOffset = toSize(lineBox.location());
localPoint += inlineBoundingBoxOffset;
} else if (RenderBox* box = renderBox()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109011] trunk
Title: [109011] trunk
Revision 109011
Author commit-qu...@webkit.org
Date 2012-02-27 11:48:09 -0800 (Mon, 27 Feb 2012)
Log Message
Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=78713
Patch by Ken Buchanan ke...@chromium.org on 2012-02-27
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/css/positioned-in-relative-position-inline-crash.html
Patch originally by Robin Cao.
This is a regression. r104183 changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous block itself. We should
change markContainingBlocksForLayout() to match the change in containingBlock().
* rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
LayoutTests:
Test case originally by Robin Cao. This exercises the crashing
condition in bug 78713.
* fast/css/positioned-in-relative-position-inline-crash-expected.txt: Added.
* fast/css/positioned-in-relative-position-inline-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Added Paths
trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash-expected.txt
trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109010 => 109011)
--- trunk/LayoutTests/ChangeLog 2012-02-27 19:26:24 UTC (rev 109010)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 19:48:09 UTC (rev 109011)
@@ -1,3 +1,16 @@
+2012-02-27 Ken Buchanan ke...@chromium.org
+
+Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
+https://bugs.webkit.org/show_bug.cgi?id=78713
+
+Reviewed by David Hyatt.
+
+Test case originally by Robin Cao. This exercises the crashing
+condition in bug 78713.
+
+* fast/css/positioned-in-relative-position-inline-crash-expected.txt: Added.
+* fast/css/positioned-in-relative-position-inline-crash.html: Added.
+
2012-02-27 Pavel Feldman pfeld...@google.com
Web Inspector: move record formatting into the timeline presentation model.
Added: trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash-expected.txt (0 => 109011)
--- trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash-expected.txt 2012-02-27 19:48:09 UTC (rev 109011)
@@ -0,0 +1,3 @@
+PASS, if no exception or crash in debug
+div1
+2
Property changes on: trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash-expected.txt
___
Added: svn:executable
Added: trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash.html (0 => 109011)
--- trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash.html 2012-02-27 19:48:09 UTC (rev 109011)
@@ -0,0 +1,37 @@
+html
+style type=text/css
+.inlineContainer {
+ position: relative;
+ display: inline;
+}
+#positioned {
+ position: absolute;
+ top: 100px;
+}
+/style
+script type=text/_javascript_
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+}
+
+function dumpTest() {
+if (window.layoutTestController) {
+layoutTestController.notifyDone();
+}
+}
+function runTest() {
+document.getElementById('positioned').innerHTML = '2';
+document.getElementById('positioned').style.color = 'red';
+setTimeout('dumpTest()', 10);
+}
+setTimeout('runTest()', 0);
+/script
+body
+PASS, if no exception or crash in debug
+ div class='inlineContainer'
+divdiv1/div
+div id='positioned'div2/div
+ /div
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (109010 => 109011)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 19:26:24 UTC (rev 109010)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 19:48:09 UTC (rev 109011)
@@ -1,3 +1,21 @@
+2012-02-27 Ken Buchanan ke...@chromium.org
+
+Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
+https://bugs.webkit.org/show_bug.cgi?id=78713
+
+Reviewed by David Hyatt.
+
+Test: fast/css/positioned-in-relative-position-inline-crash.html
+
+Patch originally by Robin Cao.
+
+This is a regression. r104183 changes containingBlock() so that it returns the container
+of an anonymous block for positioned objects, not the anonymous block itself. We should
+change markContainingBlocksForLayout() to match the change in containingBlock().
+
+* rendering/RenderObject.cpp:
+
[webkit-changes] [109013] trunk/Source/WebKit/blackberry
Title: [109013] trunk/Source/WebKit/blackberry
Revision 109013
Author commit-qu...@webkit.org
Date 2012-02-27 12:03:09 -0800 (Mon, 27 Feb 2012)
Log Message
[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608
Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not apply padding to a
direction that would cause the selection to shrink when performing the
handle direction detection.
Patch by Ed Baker edba...@rim.com on 2012-02-27
Reviewed by Antonio Gomes.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::clamp):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
* WebKitSupport/SelectionHandler.h:
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (109012 => 109013)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-02-27 19:58:09 UTC (rev 109012)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-02-27 20:03:09 UTC (rev 109013)
@@ -1,3 +1,26 @@
+2012-02-27 Ed Baker edba...@rim.com
+
+[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
+https://bugs.webkit.org/show_bug.cgi?id=78608
+
+Ensure that when selection handles leave the content bounding box that
+the handle not being dragged remains fixed. Do not apply padding to a
+direction that would cause the selection to shrink when performing the
+handle direction detection.
+
+Reviewed by Antonio Gomes.
+
+* WebKitSupport/DOMSupport.cpp:
+(BlackBerry::WebKit::DOMSupport::convertPointToFrame):
+* WebKitSupport/DOMSupport.h:
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::clamp):
+(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
+(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
+(BlackBerry::WebKit::SelectionHandler::setSelection):
+(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
+* WebKitSupport/SelectionHandler.h:
+
2012-02-27 Leo Yang leo.y...@torchmobile.com.cn
[BlackBerry] Upstream accelerated compositing helper class
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (109012 => 109013)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-02-27 19:58:09 UTC (rev 109012)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-02-27 20:03:09 UTC (rev 109013)
@@ -336,7 +336,7 @@
return false;
}
-IntPoint convertPointToFrame(const Frame* sourceFrame, const Frame* targetFrame, const IntPoint point)
+IntPoint convertPointToFrame(const Frame* sourceFrame, const Frame* targetFrame, const IntPoint point, const bool clampToTargetFrame)
{
ASSERT(sourceFrame targetFrame);
if (sourceFrame == targetFrame)
@@ -347,6 +347,7 @@
Frame* targetFrameParent = targetFrame-tree()-parent();
IntRect targetFrameRect = targetFrame-view()-frameRect();
+IntPoint targetPoint = point;
// Convert the target frame rect to source window content coordinates. This is only required
// if the parent frame is not the source. If the parent is the source, subframeRect
@@ -355,11 +356,14 @@
targetFrameRect = sourceFrame-view()-windowToContents(targetFrameParent-view()-contentsToWindow(targetFrameRect));
// Requested point is outside of target frame, return InvalidPoint.
-if (!targetFrameRect.contains(point))
+if (clampToTargetFrame !targetFrameRect.contains(targetPoint))
+targetPoint = IntPoint(targetPoint.x() targetFrameRect.x() ? targetFrameRect.x() : std::min(targetPoint.x(), targetFrameRect.maxX()),
+targetPoint.y() targetFrameRect.y() ? targetFrameRect.y() : std::min(targetPoint.y(), targetFrameRect.maxY()));
+else if (!targetFrameRect.contains(targetPoint))
return InvalidPoint;
// Adjust the points to be relative to the target.
-return targetFrame-view()-windowToContents(sourceFrame-view()-contentsToWindow(point));
+return targetFrame-view()-windowToContents(sourceFrame-view()-contentsToWindow(targetPoint));
}
VisibleSelection visibleSelectionForClosestActualWordStart(const VisibleSelection
[webkit-changes] [109014] trunk
Title: [109014] trunk
Revision 109014
Author o...@chromium.org
Date 2012-02-27 12:33:27 -0800 (Mon, 27 Feb 2012)
Log Message
implement display: -webkit-inline-flexbox
https://bugs.webkit.org/show_bug.cgi?id=2
Reviewed by David Hyatt.
Source/WebCore:
Tests: css3/flexbox/inline-flexbox-expected.html
css3/flexbox/inline-flexbox.html
* rendering/style/RenderStyle.h:
-Add INLINE_FLEXBOX to the list of replaced display types.
-Restructure the isDisplayInline methods to avoid code duplication.
LayoutTests:
* css3/flexbox/inline-flexbox-expected.html: Added.
* css3/flexbox/inline-flexbox.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.h
Added Paths
trunk/LayoutTests/css3/flexbox/inline-flexbox-expected.html
trunk/LayoutTests/css3/flexbox/inline-flexbox.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109013 => 109014)
--- trunk/LayoutTests/ChangeLog 2012-02-27 20:03:09 UTC (rev 109013)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 20:33:27 UTC (rev 109014)
@@ -1,3 +1,13 @@
+2012-02-27 Ojan Vafai o...@chromium.org
+
+implement display: -webkit-inline-flexbox
+https://bugs.webkit.org/show_bug.cgi?id=2
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/inline-flexbox-expected.html: Added.
+* css3/flexbox/inline-flexbox.html: Added.
+
2012-02-27 Ken Buchanan ke...@chromium.org
Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
Added: trunk/LayoutTests/css3/flexbox/inline-flexbox-expected.html (0 => 109014)
--- trunk/LayoutTests/css3/flexbox/inline-flexbox-expected.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/inline-flexbox-expected.html 2012-02-27 20:33:27 UTC (rev 109014)
@@ -0,0 +1,4 @@
+!DOCTYPE html
+spanfoo/span
+spanflex item 1/spanspanflex item 2/span
+spanbaz/span
\ No newline at end of file
Added: trunk/LayoutTests/css3/flexbox/inline-flexbox.html (0 => 109014)
--- trunk/LayoutTests/css3/flexbox/inline-flexbox.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/inline-flexbox.html 2012-02-27 20:33:27 UTC (rev 109014)
@@ -0,0 +1,7 @@
+!DOCTYPE html
+spanfoo/span
+div style=display:-webkit-inline-flexbox
+divflex item 1/div
+divflex item 2/div
+/div
+spanbaz/span
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (109013 => 109014)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 20:03:09 UTC (rev 109013)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 20:33:27 UTC (rev 109014)
@@ -1,3 +1,17 @@
+2012-02-27 Ojan Vafai o...@chromium.org
+
+implement display: -webkit-inline-flexbox
+https://bugs.webkit.org/show_bug.cgi?id=2
+
+Reviewed by David Hyatt.
+
+Tests: css3/flexbox/inline-flexbox-expected.html
+ css3/flexbox/inline-flexbox.html
+
+* rendering/style/RenderStyle.h:
+-Add INLINE_FLEXBOX to the list of replaced display types.
+-Restructure the isDisplayInline methods to avoid code duplication.
+
2012-02-27 Ken Buchanan ke...@chromium.org
Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (109013 => 109014)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2012-02-27 20:03:09 UTC (rev 109013)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2012-02-27 20:33:27 UTC (rev 109014)
@@ -1450,22 +1450,10 @@
StyleDifference diff(const RenderStyle*, unsigned changedContextSensitiveProperties) const;
-bool isDisplayReplacedType() const
-{
-return display() == INLINE_BLOCK || display() == INLINE_BOX || display() == INLINE_TABLE;
-}
+bool isDisplayReplacedType() const { return isDisplayReplacedType(display()); }
+bool isDisplayInlineType() const { return isDisplayInlineType(display()); }
+bool isOriginalDisplayInlineType() const { return isDisplayInlineType(originalDisplay()); }
-bool isDisplayInlineType() const
-{
-return display() == INLINE || isDisplayReplacedType();
-}
-
-bool isOriginalDisplayInlineType() const
-{
-return originalDisplay() == INLINE || originalDisplay() == INLINE_BLOCK
-|| originalDisplay() == INLINE_BOX || originalDisplay() == INLINE_TABLE;
-}
-
void setWritingMode(WritingMode v) { inherited_flags.m_writingMode = v; }
// To tell if this style matched attribute selectors. This makes it impossible to share.
@@ -1715,6 +1703,12 @@
return isHorizontalWritingMode() ? getImageVerticalOutsets(image, logicalTop, logicalBottom) : getImageHorizontalOutsets(image, logicalTop, logicalBottom);
}
+bool isDisplayReplacedType(EDisplay display) const
+{
+return display == INLINE_BLOCK || display == INLINE_BOX || display == INLINE_FLEXBOX || display == INLINE_TABLE;
+}
+
[webkit-changes] [109017] trunk/Tools
Title: [109017] trunk/Tools
Revision 109017
Author wangxian...@chromium.org
Date 2012-02-27 13:03:16 -0800 (Mon, 27 Feb 2012)
Log Message
Chromium-Android layout test script: the adb shell prompt is not always '# '
https://bugs.webkit.org/show_bug.cgi?id=79506
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._read_prompt):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
Diff
Modified: trunk/Tools/ChangeLog (109016 => 109017)
--- trunk/Tools/ChangeLog 2012-02-27 20:43:47 UTC (rev 109016)
+++ trunk/Tools/ChangeLog 2012-02-27 21:03:16 UTC (rev 109017)
@@ -1,3 +1,14 @@
+2012-02-27 Xianzhu Wang wangxian...@chromium.org
+
+Chromium-Android layout test script: the adb shell prompt is not always '# '
+https://bugs.webkit.org/show_bug.cgi?id=79506
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver._start):
+(ChromiumAndroidDriver._read_prompt):
+
2012-02-27 Dan Bernstein m...@apple.com
Added a test for rdar://problem/9557598 REGRESSION (WebKit2): Non-activating links sometimes don’t work
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (109016 => 109017)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-02-27 20:43:47 UTC (rev 109016)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-02-27 21:03:16 UTC (rev 109017)
@@ -425,9 +425,8 @@
_log.debug('Starting adb shell for DumpRenderTree: ' + ' '.join(shell_cmd))
executive = self._port.host.executive
self._proc = executive.Popen(shell_cmd, stdin=executive.PIPE, stdout=executive.PIPE, stderr=executive.STDOUT, close_fds=True)
-# Read back the shell prompt ('# ') to ensure adb shell ready.
-prompt = self._proc.stdout.read(2)
-assert(prompt == '# ')
+# Read back the shell prompt to ensure adb shell ready.
+self._read_prompt()
# Some tests rely on this to produce proper number format etc.,
# e.g. fast/speech/input-appearance-numberandspeech.html.
self._write_command_and_read_line(export LC_CTYPE='en_US'\n)
@@ -520,3 +519,14 @@
# (which causes Shell to output a message), and dumps the stack strace.
# We use the Shell output as a crash hint.
return line is not None and line.find('[1] + Stopped (signal)') = 0
+
+def _read_prompt(self):
+last_char = ''
+while True:
+current_char = self._proc.stdout.read(1)
+if current_char == ' ':
+if last_char == '#':
+return
+if last_char == '$':
+raise AssertionError('Adbd is not running as root')
+last_char = current
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109018] trunk/LayoutTests
Title: [109018] trunk/LayoutTests
Revision 109018
Author commit-qu...@webkit.org
Date 2012-02-27 13:10:52 -0800 (Mon, 27 Feb 2012)
Log Message
Cleanup Gesture requirement when exiting video-play-require-user-gesture test
https://bugs.webkit.org/show_bug.cgi?id=79690
Patch by Min Qin qin...@google.com on 2012-02-27
Reviewed by Philippe Normand.
* media/video-play-require-user-gesture.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-play-require-user-gesture.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109017 => 109018)
--- trunk/LayoutTests/ChangeLog 2012-02-27 21:03:16 UTC (rev 109017)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 21:10:52 UTC (rev 109018)
@@ -1,3 +1,12 @@
+2012-02-27 Min Qin qin...@google.com
+
+Cleanup Gesture requirement when exiting video-play-require-user-gesture test
+https://bugs.webkit.org/show_bug.cgi?id=79690
+
+Reviewed by Philippe Normand.
+
+* media/video-play-require-user-gesture.html:
+
2012-02-27 Mihnea Ovidenie mih...@adobe.com
[CSSRegions]-webkit-flow-into initial value should be none instead of auto
Modified: trunk/LayoutTests/media/video-play-require-user-gesture.html (109017 => 109018)
--- trunk/LayoutTests/media/video-play-require-user-gesture.html 2012-02-27 21:03:16 UTC (rev 109017)
+++ trunk/LayoutTests/media/video-play-require-user-gesture.html 2012-02-27 21:10:52 UTC (rev 109018)
@@ -9,6 +9,11 @@
if (window.internals)
window.internals.setMediaPlaybackRequiresUserGesture(document, true);
+function cleanGestureRequirement() {
+if (window.internals)
+window.internals.setMediaPlaybackRequiresUserGesture(document, false);
+}
+
function click()
{
if (window.eventSender) {
@@ -16,6 +21,7 @@
try {
playCoords = mediaControlsButtonCoordinates(video, play-button);
} catch (exception) {
+cleanGestureRequirement();
failTest(exception.description);
return;
}
@@ -32,6 +38,7 @@
function playing()
{
if (userGestureInitiated == 0) {
+cleanGestureRequirement();
failTest(Should not play without user gesture.);
} else {
run(video.pause());
@@ -47,8 +54,10 @@
try {
run(video.webkitEnterFullScreen());
} catch(ex) {
+cleanGestureRequirement();
failTest(video.webkitEnterFullScreen() still requires user gesture.);
}
+cleanGestureRequirement();
endTest();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109019] trunk/Source/WebKit/blackberry
Title: [109019] trunk/Source/WebKit/blackberry
Revision 109019
Author commit-qu...@webkit.org
Date 2012-02-27 13:22:19 -0800 (Mon, 27 Feb 2012)
Log Message
[BlackBerry] Selection handling should be entirely directional
https://bugs.webkit.org/show_bug.cgi?id=79692
Patch by Mike Fenton mifen...@rim.com on 2012-02-27
Reviewed by Antonio Gomes.
Make all VisibleSelections directional.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (109018 => 109019)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-02-27 21:10:52 UTC (rev 109018)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-02-27 21:22:19 UTC (rev 109019)
@@ -1,3 +1,16 @@
+2012-02-27 Mike Fenton mifen...@rim.com
+
+[BlackBerry] Selection handling should be entirely directional
+https://bugs.webkit.org/show_bug.cgi?id=79692
+
+Reviewed by Antonio Gomes.
+
+Make all VisibleSelections directional.
+
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
+(BlackBerry::WebKit::SelectionHandler::setSelection):
+
2012-02-27 Ed Baker edba...@rim.com
[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (109018 => 109019)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-02-27 21:10:52 UTC (rev 109018)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-02-27 21:22:19 UTC (rev 109019)
@@ -393,13 +393,13 @@
character = extendSelectionToFieldBoundary(true /* isStartHandle */, relativeStart, newSelection);
if (character) {
// Invert the selection so that the cursor point is at the beginning.
-controller-setSelection(VisibleSelection(controller-selection().end(), controller-selection().start()));
+controller-setSelection(VisibleSelection(controller-selection().end(), controller-selection().start(), true /* isDirectional */));
}
} else if (endIsOutsideOfField) {
character = extendSelectionToFieldBoundary(false /* isStartHandle */, relativeEnd, newSelection);
if (character) {
// Reset the selection so that the end is the edit point.
-controller-setSelection(VisibleSelection(controller-selection().start(), controller-selection().end()));
+controller-setSelection(VisibleSelection(controller-selection().start(), controller-selection().end(), true /* isDirectional */));
}
}
@@ -445,7 +445,7 @@
// We need the selection to be ordered base then extent.
if (!controller-selection().isBaseFirst())
-controller-setSelection(VisibleSelection(controller-selection().start(), controller-selection().end()));
+controller-setSelection(VisibleSelection(controller-selection().start(), controller-selection().end(), true /* isDirectional */));
if (startIsValid) {
relativeStart = DOMSupport::convertPointToFrame(m_webPage-mainFrame(), focusedFrame, start);
@@ -467,6 +467,8 @@
newSelection.setWithoutValidation(controller-selection().start(), newSelection.extent());
}
+newSelection.setIsDirectional(true);
+
if (m_webPage-m_inputHandler-isInputMode()) {
if (updateOrHandleInputSelection(newSelection, relativeStart, relativeEnd))
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109020] trunk/Source/WebCore
Title: [109020] trunk/Source/WebCore
Revision 109020
Author e...@google.com
Date 2012-02-27 13:24:13 -0800 (Mon, 27 Feb 2012)
Log Message
[chromium] Unreviewed speculative Chromium win build fix.
mdelaney's http://trac.webkit.org/changeset/109016 changed the
interface on ImageBuffer, but didn't update TransparencyWin.
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109019 => 109020)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 21:22:19 UTC (rev 109019)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 21:24:13 UTC (rev 109020)
@@ -1,3 +1,13 @@
+2012-02-27 Adrienne Walker e...@google.com
+
+[chromium] Unreviewed speculative Chromium win build fix.
+
+mdelaney's http://trac.webkit.org/changeset/109016 changed the
+interface on ImageBuffer, but didn't update TransparencyWin.
+
+* platform/graphics/chromium/TransparencyWin.cpp:
+(WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
+
2012-02-27 Matthew Delaney mdela...@apple.com
Add ImageBuffer support for having a hi-res backing store. This allows
Modified: trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.cpp (109019 => 109020)
--- trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.cpp 2012-02-27 21:22:19 UTC (rev 109019)
+++ trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.cpp 2012-02-27 21:24:13 UTC (rev 109020)
@@ -127,7 +127,7 @@
// Returns whether the current layer will fix a buffer of the given size.
bool canHandleSize(const IntSize size) const
{
-return m_destBitmap-size().width() = size.width() m_destBitmap-size().height() = size.height();
+return m_destBitmap-internalSize().width() = size.width() m_destBitmap-internalSize().height() = size.height();
}
private:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109021] trunk
Title: [109021] trunk
Revision 109021
Author oli...@apple.com
Date 2012-02-27 13:33:06 -0800 (Mon, 27 Feb 2012)
Log Message
REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=79693
Reviewed by Filip Pizlo.
Source/_javascript_Core:
Alas we can't provide the stack trace as an array, as despite everyone wanting
an array, everyone arbitrarily creates the array by calling split on the stack
trace. To create the array we would have provided them in the first place.
This changes the exception's stack property to a \n separated string. To get the
old array just do exception.stack.split(\n).
* runtime/Error.cpp:
(JSC::addErrorInfo):
LayoutTests:
Update test case to handle Error.stack being a string rather than an array.
* fast/js/script-tests/stack-trace.js:
(printStack):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/script-tests/stack-trace.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Error.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (109020 => 109021)
--- trunk/LayoutTests/ChangeLog 2012-02-27 21:24:13 UTC (rev 109020)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 21:33:06 UTC (rev 109021)
@@ -1,3 +1,15 @@
+2012-02-27 Oliver Hunt oli...@apple.com
+
+REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
+https://bugs.webkit.org/show_bug.cgi?id=79693
+
+Reviewed by Filip Pizlo.
+
+Update test case to handle Error.stack being a string rather than an array.
+
+* fast/js/script-tests/stack-trace.js:
+(printStack):
+
2012-02-27 Min Qin qin...@google.com
Cleanup Gesture requirement when exiting video-play-require-user-gesture test
Modified: trunk/LayoutTests/fast/js/script-tests/stack-trace.js (109020 => 109021)
--- trunk/LayoutTests/fast/js/script-tests/stack-trace.js 2012-02-27 21:24:13 UTC (rev 109020)
+++ trunk/LayoutTests/fast/js/script-tests/stack-trace.js 2012-02-27 21:33:06 UTC (rev 109021)
@@ -9,6 +9,7 @@
function printStack(stackTrace) {
debug(-- Stack Trace:)
+stackTrace = stackTrace.split(\n);
var length = Math.min(stackTrace.length, 100);
for (var i = 0; i length; i++) {
var indexOfAt = stackTrace[i].indexOf('@')
@@ -21,7 +22,6 @@
}
debug('');
}
-
function hostThrower() { Element.prototype.appendChild.call({ }, [{ }]); }
function callbacker(f) { [0].map(f); }
function outer(errorName) { inner(errorName); }
Modified: trunk/Source/_javascript_Core/ChangeLog (109020 => 109021)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-27 21:24:13 UTC (rev 109020)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-27 21:33:06 UTC (rev 109021)
@@ -1,3 +1,20 @@
+2012-02-27 Oliver Hunt oli...@apple.com
+
+REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
+https://bugs.webkit.org/show_bug.cgi?id=79693
+
+Reviewed by Filip Pizlo.
+
+Alas we can't provide the stack trace as an array, as despite everyone wanting
+an array, everyone arbitrarily creates the array by calling split on the stack
+trace. To create the array we would have provided them in the first place.
+
+This changes the exception's stack property to a \n separated string. To get the
+old array just do exception.stack.split(\n).
+
+* runtime/Error.cpp:
+(JSC::addErrorInfo):
+
2012-02-27 Gavin Barraclough barraclo...@apple.com
RegExp lastIndex should behave as a regular property
Modified: trunk/Source/_javascript_Core/runtime/Error.cpp (109020 => 109021)
--- trunk/Source/_javascript_Core/runtime/Error.cpp 2012-02-27 21:24:13 UTC (rev 109020)
+++ trunk/Source/_javascript_Core/runtime/Error.cpp 2012-02-27 21:33:06 UTC (rev 109021)
@@ -35,6 +35,7 @@
#include JSString.h
#include NativeErrorConstructor.h
#include SourceCode.h
+#include StringBuilder.h
namespace JSC {
@@ -132,20 +133,14 @@
globalObject = globalData-dynamicGlobalObject;
else
globalObject = error-globalObject();
-// We use the tryCreateUninitialized creation mechanism and related initialization
-// functions as they're the only mechanism we currently have that will guarantee we
-// don't call setters on the prototype. Technically it's faster than the alternative,
-// but the numerous allocations that take place in this loop makes that last bit
-// somewhat moot.
-JSArray* stackTraceArray = JSArray::tryCreateUninitialized(*globalData, globalObject-arrayStructure(), stackTrace.size());
-if (!stackTraceArray)
-return error;
+StringBuilder builder;
for (unsigned i = 0; i stackTrace.size(); i++) {
-UString stackLevel = stackTrace[i].toString(globalObject-globalExec());
-stackTraceArray-initializeIndex(*globalData, i, jsString(globalData,
[webkit-changes] [109022] trunk/Source
Title: [109022] trunk/Source
Revision 109022
Author enr...@apple.com
Date 2012-02-27 14:03:41 -0800 (Mon, 27 Feb 2012)
Log Message
WebKit2: implement platform strategy to access Pasteboard in the UI process.
https://bugs.webkit.org/show_bug.cgi?id=79253
rdar://problem/9971876
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests. No behavior change.
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::bufferForType): There is no need
to create a SharedBuffer object if there is no NSData in the pasteboard
for the given pasteboard type.
Source/WebKit2:
* UIProcess/WebContext.h:
* UIProcess/WebContext.messages.in: Added messages to access NSPasteboard
in the UI process.
* UIProcess/mac/WebContextMac.mm: Added methods corresponding to the
new messages.
(WebKit::WebContext::getPasteboardTypes):
(WebKit::WebContext::getPasteboardPathnamesForType):
(WebKit::WebContext::getPasteboardStringForType):
(WebKit::WebContext::getPasteboardBufferForType):
(WebKit::WebContext::pasteboardCopy):
(WebKit::WebContext::getPasteboardChangeCount):
(WebKit::WebContext::getPasteboardUniqueName):
(WebKit::WebContext::getPasteboardColor):
(WebKit::WebContext::setPasteboardTypes):
(WebKit::WebContext::setPasteboardPathnamesForType):
(WebKit::WebContext::setPasteboardStringForType):
(WebKit::WebContext::setPasteboardBufferForType):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: New implementation of the PasteboardStrategy using message exchange
with the UI process.
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/PlatformPasteboardMac.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/WebContext.messages.in
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109021 => 109022)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 21:33:06 UTC (rev 109021)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 22:03:41 UTC (rev 109022)
@@ -1,3 +1,18 @@
+2012-02-27 Enrica Casucci enr...@apple.com
+
+WebKit2: implement platform strategy to access Pasteboard in the UI process.
+https://bugs.webkit.org/show_bug.cgi?id=79253
+rdar://problem/9971876
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests. No behavior change.
+
+* platform/mac/PlatformPasteboardMac.mm:
+(WebCore::PlatformPasteboard::bufferForType): There is no need
+to create a SharedBuffer object if there is no NSData in the pasteboard
+for the given pasteboard type.
+
2012-02-27 Adrienne Walker e...@google.com
[chromium] Unreviewed speculative Chromium win build fix.
Modified: trunk/Source/WebCore/platform/mac/PlatformPasteboardMac.mm (109021 => 109022)
--- trunk/Source/WebCore/platform/mac/PlatformPasteboardMac.mm 2012-02-27 21:33:06 UTC (rev 109021)
+++ trunk/Source/WebCore/platform/mac/PlatformPasteboardMac.mm 2012-02-27 22:03:41 UTC (rev 109022)
@@ -45,7 +45,10 @@
PassRefPtrSharedBuffer PlatformPasteboard::bufferForType(const String pasteboardType)
{
-return SharedBuffer::wrapNSData([[[m_pasteboard.get() dataForType:pasteboardType] copy] autorelease]);
+NSData *data = "" dataForType:pasteboardType];
+if (!data)
+return 0;
+return SharedBuffer::wrapNSData([[data copy] autorelease]);
}
void PlatformPasteboard::getPathnamesForType(VectorString pathnames, const String pasteboardType)
Modified: trunk/Source/WebKit2/ChangeLog (109021 => 109022)
--- trunk/Source/WebKit2/ChangeLog 2012-02-27 21:33:06 UTC (rev 109021)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-27 22:03:41 UTC (rev 109022)
@@ -1,3 +1,43 @@
+2012-02-27 Enrica Casucci enr...@apple.com
+
+WebKit2: implement platform strategy to access Pasteboard in the UI process.
+https://bugs.webkit.org/show_bug.cgi?id=79253
+rdar://problem/9971876
+
+Reviewed by Alexey Proskuryakov.
+
+* UIProcess/WebContext.h:
+* UIProcess/WebContext.messages.in: Added messages to access NSPasteboard
+in the UI process.
+* UIProcess/mac/WebContextMac.mm: Added methods corresponding to the
+new messages.
+(WebKit::WebContext::getPasteboardTypes):
+(WebKit::WebContext::getPasteboardPathnamesForType):
+
[webkit-changes] [109023] trunk
Title: [109023] trunk
Revision 109023
Author crog...@google.com
Date 2012-02-27 14:15:11 -0800 (Mon, 27 Feb 2012)
Log Message
Implement static compression curve parameters for DynamicsCompressorNode
https://bugs.webkit.org/show_bug.cgi?id=78937
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/dynamicscompressor-basic.html
* platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::setParameterValue):
(WebCore):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::process):
* platform/audio/DynamicsCompressor.h:
* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::kneeCurve):
(WebCore::DynamicsCompressorKernel::saturate):
(WebCore::DynamicsCompressorKernel::slopeAt):
(WebCore::DynamicsCompressorKernel::kAtSlope):
(WebCore::DynamicsCompressorKernel::updateStaticCurveParameters):
(WebCore::DynamicsCompressorKernel::process):
* platform/audio/DynamicsCompressorKernel.h:
(DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::meteringGain):
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
* webaudio/DynamicsCompressorNode.h:
(WebCore):
(WebCore::DynamicsCompressorNode::create):
(DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::threshold):
(WebCore::DynamicsCompressorNode::knee):
(WebCore::DynamicsCompressorNode::ratio):
(WebCore::DynamicsCompressorNode::reduction):
* webaudio/DynamicsCompressorNode.idl:
LayoutTests:
* webaudio/dynamicscompressor-basic-expected.txt: Added.
* webaudio/dynamicscompressor-basic.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/DynamicsCompressor.cpp
trunk/Source/WebCore/platform/audio/DynamicsCompressor.h
trunk/Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp
trunk/Source/WebCore/platform/audio/DynamicsCompressorKernel.h
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.cpp
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.h
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.idl
Added Paths
trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt
trunk/LayoutTests/webaudio/dynamicscompressor-basic.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109022 => 109023)
--- trunk/LayoutTests/ChangeLog 2012-02-27 22:03:41 UTC (rev 109022)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 22:15:11 UTC (rev 109023)
@@ -1,3 +1,13 @@
+2012-02-27 Chris Rogers crog...@google.com
+
+Implement static compression curve parameters for DynamicsCompressorNode
+https://bugs.webkit.org/show_bug.cgi?id=78937
+
+Reviewed by Kenneth Russell.
+
+* webaudio/dynamicscompressor-basic-expected.txt: Added.
+* webaudio/dynamicscompressor-basic.html: Added.
+
2012-02-27 Oliver Hunt oli...@apple.com
REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
Added: trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt (0 => 109023)
--- trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt (rev 0)
+++ trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt 2012-02-27 22:15:11 UTC (rev 109023)
@@ -0,0 +1,11 @@
+Basic tests for DynamicsCompressorNode API.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+PASS threshold attribute has correct default value.
+PASS knee attribute has correct default value.
+PASS ratio attribute has correct default value.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/webaudio/dynamicscompressor-basic.html (0 => 109023)
--- trunk/LayoutTests/webaudio/dynamicscompressor-basic.html (rev 0)
+++ trunk/LayoutTests/webaudio/dynamicscompressor-basic.html 2012-02-27 22:15:11 UTC (rev 109023)
@@ -0,0 +1,59 @@
+!DOCTYPE html
+
+html
+head
+script src=""
+script type=text/_javascript_ src=""
+/head
+
+body
+div id=description/div
+div id=console/div
+
+script
+description(Basic tests for DynamicsCompressorNode API.);
+
+var context;
+var compressor;
+
+function runTest() {
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+window.jsTestIsAsync = true;
+
+context = new webkitAudioContext();
+compressor = context.createDynamicsCompressor();
+
+try {
+if (compressor.threshold.value == -24)
+testPassed(threshold attribute has correct default value.);
+else
+testFailed(threshold attribute has incorrect default value.);
+
+if (compressor.knee.value == 30)
+testPassed(knee attribute has correct default value.);
+else
+testFailed(knee attribute has incorrect default
[webkit-changes] [109024] trunk/LayoutTests
Title: [109024] trunk/LayoutTests Revision 109024 Author e...@google.com Date 2012-02-27 14:19:12 -0800 (Mon, 27 Feb 2012) Log Message [chromium] Unreviewed gardening, mark two fast/regex tests as failing * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109023 => 109024) --- trunk/LayoutTests/ChangeLog 2012-02-27 22:15:11 UTC (rev 109023) +++ trunk/LayoutTests/ChangeLog 2012-02-27 22:19:12 UTC (rev 109024) @@ -1,3 +1,9 @@ +2012-02-27 Adrienne Walker e...@google.com + +[chromium] Unreviewed gardening, mark two fast/regex tests as failing + +* platform/chromium/test_expectations.txt: + 2012-02-27 Chris Rogers crog...@google.com Implement static compression curve parameters for DynamicsCompressorNode Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109023 => 109024) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 22:15:11 UTC (rev 109023) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 22:19:12 UTC (rev 109024) @@ -4231,3 +4231,6 @@ BUGWK79642 : accessibility/aria-describedby-on-input.html = TIMEOUT BUGWK79642 : fast/loader/subresource-willSendRequest-null.html = TIMEOUT BUGWK79642 : media/video-playbackrate.html = TIMEOUT + +BUGWK79702 : fast/regex/lastIndex.html = TEXT +BUGWK79703 : fast/regex/overflow.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109025] branches/subpixellayout/Source
Title: [109025] branches/subpixellayout/Source
Revision 109025
Author e...@chromium.org
Date 2012-02-27 14:19:27 -0800 (Mon, 27 Feb 2012)
Log Message
Fix a IntRect/LayoutRect usage to avoid unnecessary type conversions on branch.
Modified Paths
branches/subpixellayout/Source/WebCore/dom/Document.cpp
branches/subpixellayout/Source/WebCore/dom/Element.cpp
branches/subpixellayout/Source/WebCore/dom/Element.h
branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp
branches/subpixellayout/Source/WebCore/rendering/HitTestResult.h
branches/subpixellayout/Source/WebKit/chromium/src/WebElement.cpp
branches/subpixellayout/Source/WebKit/chromium/src/WebPluginContainerImpl.h
branches/subpixellayout/Source/WebKit/chromium/src/WebViewImpl.cpp
branches/subpixellayout/Source/WebKit/mac/WebView/WebHTMLView.mm
branches/subpixellayout/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/dom/Document.cpp (109024 => 109025)
--- branches/subpixellayout/Source/WebCore/dom/Document.cpp 2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/dom/Document.cpp 2012-02-27 22:19:27 UTC (rev 109025)
@@ -1210,7 +1210,7 @@
// When ignoreClipping is false, this method returns null for coordinates outside of the viewport.
if (ignoreClipping)
type |= HitTestRequest::IgnoreClipping;
-else if (!frameView-visibleContentRect().intersects(enclosingIntRect(HitTestResult::rectForPoint(point, topPadding, rightPadding, bottomPadding, leftPadding
+else if (!frameView-visibleContentRect().intersects(HitTestResult::rectForPoint(point, topPadding, rightPadding, bottomPadding, leftPadding)))
return 0;
HitTestRequest request(type);
Modified: branches/subpixellayout/Source/WebCore/dom/Element.cpp (109024 => 109025)
--- branches/subpixellayout/Source/WebCore/dom/Element.cpp 2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/dom/Element.cpp 2012-02-27 22:19:27 UTC (rev 109025)
@@ -459,13 +459,13 @@
return 0;
}
-LayoutRect Element::boundsInRootViewSpace()
+IntRect Element::boundsInRootViewSpace()
{
document()-updateLayoutIgnorePendingStylesheets();
FrameView* view = document()-view();
if (!view)
-return LayoutRect();
+return IntRect();
VectorFloatQuad quads;
#if ENABLE(SVG)
@@ -484,13 +484,13 @@
}
if (quads.isEmpty())
-return LayoutRect();
+return IntRect();
-LayoutRect result = quads[0].enclosingBoundingBox();
+IntRect result = quads[0].enclosingBoundingBox();
for (size_t i = 1; i quads.size(); ++i)
result.unite(quads[i].enclosingBoundingBox());
-result = view-contentsToRootView(enclosingIntRect(result));
+result = view-contentsToRootView(result);
return result;
}
Modified: branches/subpixellayout/Source/WebCore/dom/Element.h (109024 => 109025)
--- branches/subpixellayout/Source/WebCore/dom/Element.h 2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/dom/Element.h 2012-02-27 22:19:27 UTC (rev 109025)
@@ -184,7 +184,7 @@
virtual int scrollWidth();
virtual int scrollHeight();
-LayoutRect boundsInRootViewSpace();
+IntRect boundsInRootViewSpace();
PassRefPtrClientRectList getClientRects();
PassRefPtrClientRect getBoundingClientRect();
Modified: branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp (109024 => 109025)
--- branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp 2012-02-27 22:19:12 UTC (rev 109024)
+++ branches/subpixellayout/Source/WebCore/rendering/HitTestResult.cpp 2012-02-27 22:19:27 UTC (rev 109025)
@@ -589,7 +589,7 @@
mutableRectBasedTestResult().add(currInline-node()-shadowAncestorNode());
}
}
-return !rect.contains(enclosingIntRect(rectForPoint(pointInContainer)));
+return !rect.contains(rectForPoint(pointInContainer));
}
bool HitTestResult::addNodeToRectBasedTestResult(Node* node, const LayoutPoint pointInContainer, const FloatRect rect)
@@ -643,16 +643,16 @@
}
}
-LayoutRect HitTestResult::rectForPoint(const LayoutPoint point, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding)
+IntRect HitTestResult::rectForPoint(const LayoutPoint point, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding)
{
-LayoutPoint actualPoint(point);
-actualPoint -= LayoutSize(leftPadding, topPadding);
+IntPoint actualPoint(roundedIntPoint(point));
+actualPoint -= IntSize(leftPadding, topPadding);
IntSize actualPadding(leftPadding + rightPadding, topPadding + bottomPadding);
// As IntRect is left inclusive and right exclusive (seeing IntRect::contains(x, y)), adding 1.
actualPadding += IntSize(1, 1);
-return LayoutRect(actualPoint, actualPadding);
+return IntRect(actualPoint,
[webkit-changes] [109026] trunk/Source/WebCore
Title: [109026] trunk/Source/WebCore Revision 109026 Author ad...@chromium.org Date 2012-02-27 14:53:25 -0800 (Mon, 27 Feb 2012) Log Message Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate https://bugs.webkit.org/show_bug.cgi?id=79697 Reviewed by Ryosuke Niwa. insertedIntoTree/removedFromTree are only used by subclasses of ContainerNode. Moreover, attempting to make use of these notifications in a non-container Node would currently not work, because Node::removedFromDocument/insertedIntoDocument do not dispatch to these methods. Rather than adding useless calls to an always-empty virtual method, this patch moves these methods to ContainerNode. Meanwhile, childrenChanged moves to ContainerNode for an obvious reason: non-container Nodes have no children to change. No new tests, refactoring only. * dom/Attr.cpp: (WebCore::Attr::childrenChanged): Remove call to now-nonexistent Node::childrenChanged. * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): Check that the removed child is a container node before notifying it of removal. (WebCore::ContainerNode::parserRemoveChild): ditto. (WebCore::ContainerNode::insertedIntoTree): Remove call to now-nonexistent Node::insertedIntoTree. (WebCore::ContainerNode::removedFromTree): Remove call to now-nonexistent Node::removedFromTree. (WebCore::ContainerNode::childrenChanged): Remove call to now-nonexistent Node::childrenChanged. (WebCore::notifyChildInserted): Check that the inserted child is a container node before notifying it of insertion. * dom/ContainerNode.h: (ContainerNode): Migrate comments from Node.h, point back at it for more notification methods. * dom/Node.h: (Node): Move methods, update comments to point at ContainerNode.h. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Attr.cpp trunk/Source/WebCore/dom/ContainerNode.cpp trunk/Source/WebCore/dom/ContainerNode.h trunk/Source/WebCore/dom/Node.h Diff Modified: trunk/Source/WebCore/ChangeLog (109025 => 109026) --- trunk/Source/WebCore/ChangeLog 2012-02-27 22:19:27 UTC (rev 109025) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 22:53:25 UTC (rev 109026) @@ -1,3 +1,36 @@ +2012-02-27 Adam Klein ad...@chromium.org + +Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate +https://bugs.webkit.org/show_bug.cgi?id=79697 + +Reviewed by Ryosuke Niwa. + +insertedIntoTree/removedFromTree are only used by subclasses of +ContainerNode. Moreover, attempting to make use of these notifications +in a non-container Node would currently not work, because +Node::removedFromDocument/insertedIntoDocument do not dispatch to these methods. +Rather than adding useless calls to an always-empty virtual method, +this patch moves these methods to ContainerNode. + +Meanwhile, childrenChanged moves to ContainerNode for an obvious reason: +non-container Nodes have no children to change. + +No new tests, refactoring only. + +* dom/Attr.cpp: +(WebCore::Attr::childrenChanged): Remove call to now-nonexistent Node::childrenChanged. +* dom/ContainerNode.cpp: +(WebCore::ContainerNode::removeChild): Check that the removed child is a container node before notifying it of removal. +(WebCore::ContainerNode::parserRemoveChild): ditto. +(WebCore::ContainerNode::insertedIntoTree): Remove call to now-nonexistent Node::insertedIntoTree. +(WebCore::ContainerNode::removedFromTree): Remove call to now-nonexistent Node::removedFromTree. +(WebCore::ContainerNode::childrenChanged): Remove call to now-nonexistent Node::childrenChanged. +(WebCore::notifyChildInserted): Check that the inserted child is a container node before notifying it of insertion. +* dom/ContainerNode.h: +(ContainerNode): Migrate comments from Node.h, point back at it for more notification methods. +* dom/Node.h: +(Node): Move methods, update comments to point at ContainerNode.h. + 2012-02-27 Chris Rogers crog...@google.com Implement static compression curve parameters for DynamicsCompressorNode Modified: trunk/Source/WebCore/dom/Attr.cpp (109025 => 109026) --- trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:19:27 UTC (rev 109025) +++ trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:53:25 UTC (rev 109026) @@ -172,8 +172,6 @@ if (m_ignoreChildrenChanged 0) return; -Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta); - invalidateNodeListsCacheAfterAttributeChanged(m_attribute-name()); // FIXME: We should include entity references in the value Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (109025 => 109026) --- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-27 22:19:27 UTC (rev 109025) +++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-27 22:53:25 UTC (rev 109026)
[webkit-changes] [109027] branches/subpixellayout/Source
Title: [109027] branches/subpixellayout/Source
Revision 109027
Author le...@chromium.org
Date 2012-02-27 14:59:10 -0800 (Mon, 27 Feb 2012)
Log Message
Build fix for Mac. Converting linesBoundingBox and borderBoundingBox, and ShadowData to integers. Removing a whitespace change to bring patch size down. Removing an extraneous printf.
Modified Paths
branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/subpixellayout/Source/WebCore/dom/ClientRect.h
branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp
branches/subpixellayout/Source/WebCore/page/animation/AnimationBase.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBox.h
branches/subpixellayout/Source/WebCore/rendering/RenderBoxModelObject.h
branches/subpixellayout/Source/WebCore/rendering/RenderInline.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderInline.h
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderObject.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderText.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderText.h
branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp
branches/subpixellayout/Source/WebCore/rendering/style/RenderStyle.cpp
branches/subpixellayout/Source/WebCore/rendering/style/ShadowData.cpp
branches/subpixellayout/Source/WebCore/rendering/style/ShadowData.h
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGInlineText.h
branches/subpixellayout/Source/WebKit/mac/WebView/WebRenderNode.mm
Diff
Modified: branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj (109026 => 109027)
--- branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-02-27 22:53:25 UTC (rev 109026)
+++ branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-02-27 22:59:10 UTC (rev 109027)
@@ -5014,6 +5014,7 @@
B8DBDB4C130B0F8A00F5CDB1 /* SetSelectionCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = B8DBDB48130B0F8A00F5CDB1 /* SetSelectionCommand.h */; };
B8DBDB4D130B0F8A00F5CDB1 /* SpellingCorrectionCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B8DBDB49130B0F8A00F5CDB1 /* SpellingCorrectionCommand.cpp */; };
B8DBDB4E130B0F8A00F5CDB1 /* SpellingCorrectionCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = B8DBDB4A130B0F8A00F5CDB1 /* SpellingCorrectionCommand.h */; };
+ BAB1C06A14FC3679004233FC /* FractionalLayoutPoint.h in Headers */ = {isa = PBXBuildFile; fileRef = 144FCE5414EC79E7000D17A3 /* FractionalLayoutPoint.h */; settings = {ATTRIBUTES = (Private, ); }; };
BACF290113B2A0D500781F90 /* LayoutTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = BACF290013B2A0D500781F90 /* LayoutTypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
BC00F0040E0A185500FD04E3 /* DOMFile.h in Headers */ = {isa = PBXBuildFile; fileRef = BC00EFFE0E0A185500FD04E3 /* DOMFile.h */; };
BC00F0050E0A185500FD04E3 /* DOMFile.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC00EFFF0E0A185500FD04E3 /* DOMFile.mm */; };
@@ -22369,6 +22370,7 @@
656D373A0ADBA5DE00A4554D /* FormState.h in Headers */,
41885B9311B6FDA6003383BB /* FormSubmission.h in Headers */,
935C476D09AC4D6300A6AAB4 /* FoundationExtras.h in Headers */,
+BAB1C06A14FC3679004233FC /* FractionalLayoutPoint.h in Headers */,
144FCFE114EF2509000D17A3 /* FractionalLayoutRect.h in Headers */,
144FCE5D14EC79E7000D17A3 /* FractionalLayoutSize.h in Headers */,
144FCE5214EC79BC000D17A3 /* FractionalLayoutUnit.h in Headers */,
Modified: branches/subpixellayout/Source/WebCore/dom/ClientRect.h (109026 => 109027)
--- branches/subpixellayout/Source/WebCore/dom/ClientRect.h 2012-02-27 22:53:25 UTC (rev 109026)
+++ branches/subpixellayout/Source/WebCore/dom/ClientRect.h 2012-02-27 22:59:10 UTC (rev 109027)
@@ -34,7 +34,7 @@
namespace WebCore {
-class IntRect;
+class IntRect;
class ClientRect : public RefCountedClientRect {
public:
Modified: branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp (109026 => 109027)
--- branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp 2012-02-27 22:53:25 UTC (rev 109026)
+++ branches/subpixellayout/Source/WebCore/editing/DeleteButtonController.cpp 2012-02-27 22:59:10 UTC (rev 109027)
@@ -92,7 +92,7 @@
return false;
RenderBox* box = toRenderBox(renderer);
-LayoutRect borderBoundingBox = box-borderBoundingBox();
+IntRect borderBoundingBox = box-borderBoundingBox();
if (borderBoundingBox.width() minimumWidth || borderBoundingBox.height() minimumHeight)
return false;
Modified: branches/subpixellayout/Source/WebCore/page/animation/AnimationBase.cpp (109026 => 109027)
--- branches/subpixellayout/Source/WebCore/page/animation/AnimationBase.cpp 2012-02-27 22:53:25 UTC (rev 109026)
+++
[webkit-changes] [109028] trunk/Source/WebCore
Title: [109028] trunk/Source/WebCore
Revision 109028
Author jchaffr...@webkit.org
Date 2012-02-27 15:09:34 -0800 (Mon, 27 Feb 2012)
Log Message
Avoid doing 2 hash lookups if we override RenderBox's logical width / height
https://bugs.webkit.org/show_bug.cgi?id=79591
Reviewed by Antonio Gomes.
Refactoring only.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clearOverrideSize):
Instead of doing one hash lookup as part of hasOverride{Height|Width}, let's
just directly call HashMap::remove that will do the lookup instead.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109027 => 109028)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 22:59:10 UTC (rev 109027)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 23:09:34 UTC (rev 109028)
@@ -1,3 +1,17 @@
+2012-02-27 Julien Chaffraix jchaffr...@webkit.org
+
+Avoid doing 2 hash lookups if we override RenderBox's logical width / height
+https://bugs.webkit.org/show_bug.cgi?id=79591
+
+Reviewed by Antonio Gomes.
+
+Refactoring only.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::clearOverrideSize):
+Instead of doing one hash lookup as part of hasOverride{Height|Width}, let's
+just directly call HashMap::remove that will do the lookup instead.
+
2012-02-27 Adam Klein ad...@chromium.org
Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (109027 => 109028)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2012-02-27 22:59:10 UTC (rev 109027)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2012-02-27 23:09:34 UTC (rev 109028)
@@ -795,9 +795,9 @@
void RenderBox::clearOverrideSize()
{
-if (hasOverrideHeight())
+if (gOverrideHeightMap)
gOverrideHeightMap-remove(this);
-if (hasOverrideWidth())
+if (gOverrideWidthMap)
gOverrideWidthMap-remove(this);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
Re: [webkit-changes] [109026] trunk/Source/WebCore
This broke release builds: On 2012-02-27, at 14:53, ad...@chromium.org wrote: Modified: trunk/Source/WebCore/dom/Attr.cpp (109025 = 109026) --- trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:19:27 UTC (rev 109025) +++ trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:53:25 UTC (rev 109026) @@ -172,8 +172,6 @@ if (m_ignoreChildrenChanged 0) return; -Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta); - invalidateNodeListsCacheAfterAttributeChanged(m_attribute-name()); // FIXME: We should include entity references in the value http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Build%29/builds/39282/steps/compile-webkit/logs/stdio Please fix ASAP. - Mark ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109029] trunk/Source/WebCore
Title: [109029] trunk/Source/WebCore
Revision 109029
Author hara...@chromium.org
Date 2012-02-27 15:22:32 -0800 (Mon, 27 Feb 2012)
Log Message
Remove [ConstructorParameters] from IDL files that have [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=79643
Reviewed by Adam Barth.
This patch removes [ConstructorParameters] from IDL files that have [Constructor],
since CodeGeneratorJS.pm can automatically detect the number of constructor
arguments by the [Constructor(...)] signature.
Test: fast/js/constructor-length.html
* Modules/mediastream/PeerConnection.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* css/WebKitCSSMatrix.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/css/WebKitCSSMatrix.idl
trunk/Source/WebCore/page/EventSource.idl
trunk/Source/WebCore/workers/SharedWorker.idl
trunk/Source/WebCore/workers/Worker.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (109028 => 109029)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 23:22:32 UTC (rev 109029)
@@ -1,3 +1,24 @@
+2012-02-27 Kentaro Hara hara...@chromium.org
+
+Remove [ConstructorParameters] from IDL files that have [Constructor]
+https://bugs.webkit.org/show_bug.cgi?id=79643
+
+Reviewed by Adam Barth.
+
+This patch removes [ConstructorParameters] from IDL files that have [Constructor],
+since CodeGeneratorJS.pm can automatically detect the number of constructor
+arguments by the [Constructor(...)] signature.
+
+Test: fast/js/constructor-length.html
+
+* Modules/mediastream/PeerConnection.idl:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateConstructorDefinition):
+* css/WebKitCSSMatrix.idl:
+* page/EventSource.idl:
+* workers/SharedWorker.idl:
+* workers/Worker.idl:
+
2012-02-27 Julien Chaffraix jchaffr...@webkit.org
Avoid doing 2 hash lookups if we override RenderBox's logical width / height
Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl (109028 => 109029)
--- trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl 2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl 2012-02-27 23:22:32 UTC (rev 109029)
@@ -27,7 +27,6 @@
interface [
Conditional=MEDIA_STREAM,
ActiveDOMObject,
-ConstructorParameters=2,
Constructor(in DOMString serverConfiguration, in [Callback] SignalingCallback signalingCallback),
CallWith=ScriptExecutionContext,
JSCustomConstructor,
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (109028 => 109029)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-27 23:22:32 UTC (rev 109029)
@@ -3368,7 +3368,7 @@
if (!defined $numberOfConstructorParameters) {
if (IsConstructorTemplate($dataNode, Event)) {
$numberOfConstructorParameters = 2;
-} elsif ($dataNode-extendedAttributes-{Constructor} and !$dataNode-extendedAttributes-{CustomConstructor} and !$dataNode-extendedAttributes-{JSCustomConstructor}) {
+} elsif ($dataNode-extendedAttributes-{Constructor}) {
$numberOfConstructorParameters = @{$dataNode-constructor-parameters};
}
}
Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (109028 => 109029)
--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2012-02-27 23:22:32 UTC (rev 109029)
@@ -27,7 +27,6 @@
// Introduced in DOM Level ?:
interface [
-ConstructorParameters=1,
Constructor(in [Optional=DefaultIsNullString] DOMString cssValue),
ConstructorRaisesException,
] WebKitCSSMatrix {
Modified: trunk/Source/WebCore/page/EventSource.idl (109028 => 109029)
--- trunk/Source/WebCore/page/EventSource.idl 2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/page/EventSource.idl 2012-02-27 23:22:32 UTC (rev 109029)
@@ -33,7 +33,6 @@
interface [
ActiveDOMObject,
-ConstructorParameters=1,
Constructor(in DOMString scriptUrl),
CallWith=ScriptExecutionContext,
ConstructorRaisesException,
Modified: trunk/Source/WebCore/workers/SharedWorker.idl (109028 => 109029)
--- trunk/Source/WebCore/workers/SharedWorker.idl 2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/workers/SharedWorker.idl 2012-02-27 23:22:32 UTC (rev 109029)
@@ -35,7 +35,6 @@
Conditional=SHARED_WORKERS,
ActiveDOMObject,
JSCustomConstructor,
-
[webkit-changes] [109030] trunk/Source/WebCore
Title: [109030] trunk/Source/WebCore
Revision 109030
Author sulli...@apple.com
Date 2012-02-27 15:32:01 -0800 (Mon, 27 Feb 2012)
Log Message
Build fix (on Lion at least).
* dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
Removed names of unused parameters.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/ContainerNode.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109029 => 109030)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 23:22:32 UTC (rev 109029)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 23:32:01 UTC (rev 109030)
@@ -1,3 +1,15 @@
+2012-02-27 John Sullivan sulli...@apple.com
+
+Build fix (on Lion at least).
+
+* dom/Attr.cpp:
+(WebCore::Attr::childrenChanged):
+Removed names of unused parameters.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::childrenChanged):
+Ditto.
+
2012-02-27 Kentaro Hara hara...@chromium.org
Remove [ConstructorParameters] from IDL files that have [Constructor]
Modified: trunk/Source/WebCore/dom/Attr.cpp (109029 => 109030)
--- trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 23:22:32 UTC (rev 109029)
+++ trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 23:32:01 UTC (rev 109030)
@@ -167,7 +167,7 @@
}
}
-void Attr::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
+void Attr::childrenChanged(bool, Node*, Node*, int)
{
if (m_ignoreChildrenChanged 0)
return;
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (109029 => 109030)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-27 23:22:32 UTC (rev 109029)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-27 23:32:01 UTC (rev 109030)
@@ -828,7 +828,7 @@
}
}
-void ContainerNode::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
+void ContainerNode::childrenChanged(bool changedByParser, Node*, Node*, int childCountDelta)
{
if (!changedByParser childCountDelta)
document()-updateRangesAfterChildrenChanged(this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
Re: [webkit-changes] [109026] trunk/Source/WebCore
Thanks to sullivan for the fix. Sorry for the breakage. On Mon, Feb 27, 2012 at 3:20 PM, Mark Rowe mr...@apple.com wrote: This broke release builds: On 2012-02-27, at 14:53, ad...@chromium.org wrote: Modified: trunk/Source/WebCore/dom/Attr.cpp (109025 = 109026) --- trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:19:27 UTC (rev 109025) +++ trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:53:25 UTC (rev 109026)@@ -172,8 +172,6 @@ if (m_ignoreChildrenChanged 0) return; - Node::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta); - invalidateNodeListsCacheAfterAttributeChanged(m_attribute-name()); // FIXME: We should include entity references in the value http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Build%29/builds/39282/steps/compile-webkit/logs/stdio Please fix ASAP. - Mark ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109031] trunk/Source/WebCore
Title: [109031] trunk/Source/WebCore Revision 109031 Author k...@profusion.mobi Date 2012-02-27 15:40:12 -0800 (Mon, 27 Feb 2012) Log Message [BlackBerry][EFL] Provide dummy RunLoop implementations. https://bugs.webkit.org/show_bug.cgi?id=79398 Reviewed by Antonio Gomes. r108067 fixed the EFL build by not building RunLoop.cpp on EFL and BlackBerry, as both platforms lack an implementation that provides the missing methods for the RunLoop class. However, RunLoop.cpp is a generic file which should not be included directly in PlatformWinCE.cmake (plus it helps in converting the AppleWin port to CMake). Fix this by providing a dummy implementation of the missing RunLoop methods for both EFL and BlackBerry. * CMakeLists.txt: * PlatformBlackBerry.cmake: * PlatformEfl.cmake: * PlatformWinCE.cmake: * platform/blackberry/RunLoopBlackBerry.cpp: Added. (WebCore): (WebCore::RunLoop::RunLoop): (WebCore::RunLoop::~RunLoop): (WebCore::RunLoop::wakeUp): * platform/efl/RunLoopEfl.cpp: Added. (WebCore): (WebCore::RunLoop::RunLoop): (WebCore::RunLoop::~RunLoop): (WebCore::RunLoop::wakeUp): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformBlackBerry.cmake trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/PlatformWinCE.cmake Added Paths trunk/Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (109030 => 109031) --- trunk/Source/WebCore/CMakeLists.txt 2012-02-27 23:32:01 UTC (rev 109030) +++ trunk/Source/WebCore/CMakeLists.txt 2012-02-27 23:40:12 UTC (rev 109031) @@ -1094,6 +1094,7 @@ platform/MIMETypeRegistry.cpp platform/MemoryPressureHandler.cpp platform/PlatformEvent.cpp +platform/RunLoop.cpp platform/RuntimeApplicationChecks.cpp platform/ScrollAnimator.cpp platform/ScrollableArea.cpp Modified: trunk/Source/WebCore/ChangeLog (109030 => 109031) --- trunk/Source/WebCore/ChangeLog 2012-02-27 23:32:01 UTC (rev 109030) +++ trunk/Source/WebCore/ChangeLog 2012-02-27 23:40:12 UTC (rev 109031) @@ -1,3 +1,36 @@ +2012-02-23 Raphael Kubo da Costa k...@profusion.mobi + +[BlackBerry][EFL] Provide dummy RunLoop implementations. +https://bugs.webkit.org/show_bug.cgi?id=79398 + +Reviewed by Antonio Gomes. + +r108067 fixed the EFL build by not building RunLoop.cpp on EFL and +BlackBerry, as both platforms lack an implementation that provides the +missing methods for the RunLoop class. + +However, RunLoop.cpp is a generic file which should not be included +directly in PlatformWinCE.cmake (plus it helps in converting the +AppleWin port to CMake). + +Fix this by providing a dummy implementation of the missing RunLoop +methods for both EFL and BlackBerry. + +* CMakeLists.txt: +* PlatformBlackBerry.cmake: +* PlatformEfl.cmake: +* PlatformWinCE.cmake: +* platform/blackberry/RunLoopBlackBerry.cpp: Added. +(WebCore): +(WebCore::RunLoop::RunLoop): +(WebCore::RunLoop::~RunLoop): +(WebCore::RunLoop::wakeUp): +* platform/efl/RunLoopEfl.cpp: Added. +(WebCore): +(WebCore::RunLoop::RunLoop): +(WebCore::RunLoop::~RunLoop): +(WebCore::RunLoop::wakeUp): + 2012-02-27 John Sullivan sulli...@apple.com Build fix (on Lion at least). Modified: trunk/Source/WebCore/PlatformBlackBerry.cmake (109030 => 109031) --- trunk/Source/WebCore/PlatformBlackBerry.cmake 2012-02-27 23:32:01 UTC (rev 109030) +++ trunk/Source/WebCore/PlatformBlackBerry.cmake 2012-02-27 23:40:12 UTC (rev 109031) @@ -153,6 +153,7 @@ platform/blackberry/PlatformTouchPointBlackBerry.cpp platform/blackberry/PopupMenuBlackBerry.cpp platform/blackberry/RenderThemeBlackBerry.cpp +platform/blackberry/RunLoopBlackBerry.cpp platform/blackberry/SSLKeyGeneratorBlackBerry.cpp platform/blackberry/ScrollbarThemeBlackBerry.cpp platform/blackberry/SearchPopupMenuBlackBerry.cpp Modified: trunk/Source/WebCore/PlatformEfl.cmake (109030 => 109031) --- trunk/Source/WebCore/PlatformEfl.cmake 2012-02-27 23:32:01 UTC (rev 109030) +++ trunk/Source/WebCore/PlatformEfl.cmake 2012-02-27 23:40:12 UTC (rev 109031) @@ -47,6 +47,7 @@ platform/efl/PopupMenuEfl.cpp platform/efl/RefPtrEfl.cpp platform/efl/RenderThemeEfl.cpp + platform/efl/RunLoopEfl.cpp platform/efl/ScrollViewEfl.cpp platform/efl/ScrollbarEfl.cpp platform/efl/ScrollbarThemeEfl.cpp Modified: trunk/Source/WebCore/PlatformWinCE.cmake (109030 => 109031) --- trunk/Source/WebCore/PlatformWinCE.cmake 2012-02-27 23:32:01 UTC (rev 109030) +++ trunk/Source/WebCore/PlatformWinCE.cmake 2012-02-27 23:40:12 UTC (rev 109031) @@ -32,7 +32,6 @@ platform/Cursor.cpp platform/LocalizedStrings.cpp platform/PlatformStrategies.cpp -platform/RunLoop.cpp
[webkit-changes] [109032] trunk/LayoutTests
Title: [109032] trunk/LayoutTests Revision 109032 Author e...@google.com Date 2012-02-27 15:40:52 -0800 (Mon, 27 Feb 2012) Log Message [chromium] Unreviewed gardening, mark many svg tests as flaky crashers https://bugs.webkit.org/show_bug.cgi?id=79707 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109031 => 109032) --- trunk/LayoutTests/ChangeLog 2012-02-27 23:40:12 UTC (rev 109031) +++ trunk/LayoutTests/ChangeLog 2012-02-27 23:40:52 UTC (rev 109032) @@ -1,5 +1,12 @@ 2012-02-27 Adrienne Walker e...@google.com +[chromium] Unreviewed gardening, mark many svg tests as flaky crashers +https://bugs.webkit.org/show_bug.cgi?id=79707 + +* platform/chromium/test_expectations.txt: + +2012-02-27 Adrienne Walker e...@google.com + [chromium] Unreviewed gardening, mark two fast/regex tests as failing * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109031 => 109032) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 23:40:12 UTC (rev 109031) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-27 23:40:52 UTC (rev 109032) @@ -2944,7 +2944,8 @@ // Appears to be a configuration error in the Mac 10.6 deps // Has been going on for at least a few weeks (as of 20/5/2011) BUGCR83426 MAC : svg/as-border-image/svg-as-border-image-2.html = PASS IMAGE -BUGCR83426 MAC : svg/as-border-image/svg-as-border-image.html = PASS IMAGE +// Commented out because bug 79707 also specifies CRASH +// BUGCR83426 MAC : svg/as-border-image/svg-as-border-image.html = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-specular-01-f.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-turb-01-f.svg = PASS IMAGE BUGCR83426 MAC : svg/W3C-SVG-1.1/filters-turb-02-f.svg = PASS IMAGE @@ -3450,7 +3451,8 @@ BUGWK77110 WIN DEBUG : accessibility/loading-iframe-sends-notification.html = PASS TEXT BUGWK73494 : svg/text/non-bmp-positioning-lists.svg = IMAGE+TEXT IMAGE -BUGWK73494 : svg/as-image/svg-non-integer-scaled-image.html = IMAGE PASS +// This happens on all platforms, but bug79707 specifies CRASH for MAC as well +BUGWK73494 WIN LINUX : svg/as-image/svg-non-integer-scaled-image.html = IMAGE PASS BUGWK73872 LINUX : svg/custom/linking-uri-01-b.svg = PASS TIMEOUT @@ -4214,7 +4216,9 @@ BUGWK79454 : svg/text/text-viewbox-rescale.html = IMAGE // Flaky for DEBUG since r108585 -BUGWK79455 DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS IMAGE+TEXT +// This happens on all platforms, but bug79707 specifies CRASH for MAC as well +// BUGWK79455 DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS IMAGE+TEXT +BUGWK79455 DEBUG WIN LINUX : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS IMAGE+TEXT // Flaky for DEBUG BUGWK79456 DEBUG : svg/repaint/image-with-clip-path.svg = PASS IMAGE @@ -4234,3 +4238,17 @@ BUGWK79702 : fast/regex/lastIndex.html = TEXT BUGWK79703 : fast/regex/overflow.html = TEXT + +// All MAC flaky crashers. Additional expectations come from preexisting bugs. +BUGWK79707 MAC : svg/as-background-image/background-image-preserveaspectRatio-support.html = PASS CRASH +BUGWK79707 MAC : svg/as-background-image/same-image-two-instances-background-image.html = PASS CRASH +BUGWK79707 MAC : svg/as-border-image/svg-as-border-image.html = PASS CRASH IMAGE +BUGWK79707 MAC : svg/as-image/drag-svg-as-image.html = PASS CRASH +BUGWK79707 MAC : svg/as-image/svg-as-relative-image-with-explicit-size.html = PASS CRASH +BUGWK79707 MAC : svg/as-image/svg-non-integer-scaled-image.html = PASS CRASH IMAGE +BUGWK79707 MAC : svg/clip-path/clip-path-nonzero-evenodd.svg = PASS CRASH +BUGWK79707 MAC : svg/custom/feDisplacementMap-01.svg = PASS CRASH +BUGWK79707 MAC : svg/custom/font-face-name-without-name-attr.svg = PASS CRASH +BUGWK79707 MAC RELEASE : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH +BUGWK79707 MAC DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH IMAGE+TEXT +BUGWK79707 MAC : svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109033] branches/chromium/1025/Source
Title: [109033] branches/chromium/1025/Source
Revision 109033
Author jam...@google.com
Date 2012-02-27 15:48:52 -0800 (Mon, 27 Feb 2012)
Log Message
Disable occlusion tracking and draw culling for Chromium m18
https://bugs.webkit.org/show_bug.cgi?id=79429
BUG=115957
Modified Paths
branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp
branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp
branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp
Diff
Modified: branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp (109032 => 109033)
--- branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp 2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp 2012-02-27 23:48:52 UTC (rev 109033)
@@ -91,7 +91,6 @@
PlatformCanvas::Painter::TextOption textOption =
borderTexels ? PlatformCanvas::Painter::GrayscaleText : PlatformCanvas::Painter::SubpixelText;
PlatformCanvas::Painter canvasPainter(m_canvas, textOption);
-canvasPainter.skiaContext()-setTrackOpaqueRegion(!layerIsOpaque);
paintContents(*canvasPainter.context(), contentRect, contentsScale);
if (!layerIsOpaque)
Modified: branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp (109032 => 109033)
--- branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp 2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp 2012-02-27 23:48:52 UTC (rev 109033)
@@ -54,7 +54,6 @@
SkCanvas* canvas = m_picture.beginRecording(contentRect.width(), contentRect.height());
PlatformContextSkia platformContext(canvas);
platformContext.setDeferred(true);
-platformContext.setTrackOpaqueRegion(!m_layerIsOpaque);
GraphicsContext graphicsContext(platformContext);
paintContents(graphicsContext, contentRect, contentsScale);
m_picture.endRecording();
Modified: branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (109032 => 109033)
--- branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-02-27 23:48:52 UTC (rev 109033)
@@ -264,8 +264,6 @@
CCRenderPassList passes;
calculateRenderPasses(passes);
-optimizeRenderPasses(passes);
-
m_layerRenderer-beginDrawingFrame();
for (size_t i = 0; i passes.size(); ++i)
m_layerRenderer-drawRenderPass(passes[i].get());
Modified: branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (109032 => 109033)
--- branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2012-02-27 23:48:52 UTC (rev 109033)
@@ -522,6 +522,16 @@
runTest(true);\
}
+#define DISABLED_SINGLE_AND_MULTI_THREAD_TEST_F(TEST_FIXTURE_NAME) \
+TEST_F(TEST_FIXTURE_NAME, DISABLED_runSingleThread)\
+{ \
+runTest(false);\
+} \
+TEST_F(TEST_FIXTURE_NAME, DISABLED_runMultiThread) \
+{ \
+runTest(true); \
+}
+
SINGLE_AND_MULTI_THREAD_TEST_F(CCLayerTreeHostTestShortlived1)
// Shortlived layerTreeHosts shouldn't die with a commit in flight.
Modified: branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp (109032 => 109033)
--- branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp 2012-02-27 23:40:52 UTC (rev 109032)
+++ branches/chromium/1025/Source/WebKit/chromium/tests/LayerTextureUpdaterTest.cpp 2012-02-27 23:48:52 UTC (rev 109033)
@@ -85,7 +85,7 @@
EXPECT_EQ(a.y(), b.y()); \
EXPECT_EQ(a.maxY(), b.maxY());
-TEST(LayerTextureUpdaterTest, testOpaqueRectPresentAfterOpaquePaint)
+TEST(LayerTextureUpdaterTest, DISABLED_testOpaqueRectPresentAfterOpaquePaint)
{
PaintFillOpaque fillOpaque;
RefPtrLayerTextureUpdater updater;
@@ -111,7 +111,7 @@
EXPECT_EQ_RECT(IntRect(0, 0, 400, 400), opaqueRect);
}
[webkit-changes] [109034] trunk/Source/JavaScriptCore
Title: [109034] trunk/Source/_javascript_Core
Revision 109034
Author mahesh.kulka...@nokia.com
Date 2012-02-27 15:56:09 -0800 (Mon, 27 Feb 2012)
Log Message
2012-02-27 Mahesh Kulkarni mahesh.kulka...@nokia.com
Unreviewed. Build fix for linux-bot (qt) after r109021.
* runtime/Error.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Error.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (109033 => 109034)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-27 23:48:52 UTC (rev 109033)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-27 23:56:09 UTC (rev 109034)
@@ -1,3 +1,9 @@
+2012-02-27 Mahesh Kulkarni mahesh.kulka...@nokia.com
+
+Unreviewed. Build fix for linux-bot (qt) after r109021.
+
+* runtime/Error.cpp:
+
2012-02-27 Oliver Hunt oli...@apple.com
REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
Modified: trunk/Source/_javascript_Core/runtime/Error.cpp (109033 => 109034)
--- trunk/Source/_javascript_Core/runtime/Error.cpp 2012-02-27 23:48:52 UTC (rev 109033)
+++ trunk/Source/_javascript_Core/runtime/Error.cpp 2012-02-27 23:56:09 UTC (rev 109034)
@@ -35,8 +35,9 @@
#include JSString.h
#include NativeErrorConstructor.h
#include SourceCode.h
-#include StringBuilder.h
+#include wtf/text/StringBuilder.h
+
namespace JSC {
static const char* linePropertyName = line;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109035] trunk
Title: [109035] trunk
Revision 109035
Author hara...@chromium.org
Date 2012-02-27 15:59:55 -0800 (Mon, 27 Feb 2012)
Log Message
[JSC] Add [ConstructorParameters=] to all custom constructors
https://bugs.webkit.org/show_bug.cgi?id=78221
Reviewed by Adam Barth.
Source/WebCore:
This patch adds [ConstructorParameters=X] to IDL files that have
custom constructors, where X is the maximum number of arguments
of the constructor. [ConstructorParameters=X] is needed for custom
constructors, because custom constructors do not have a signature
in IDL files and thus CodeGeneratorJS.pm cannot know the number of
constructor arguments.
Test: fast/js/constructor-length.html
* dom/WebKitMutationObserver.idl:
* html/DOMFormData.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* webaudio/AudioContext.idl:
* bindings/scripts/test/TestTypedArray.idl:
* bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests results.
(WebCore::JSFloat64ArrayConstructor::finishCreation):
LayoutTests:
The added tests check the length property of the custom constructors.
* fast/js/constructor-length.html:
* platform/mac/fast/js/constructor-length-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/constructor-length.html
trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp
trunk/Source/WebCore/bindings/scripts/test/TestTypedArray.idl
trunk/Source/WebCore/dom/WebKitMutationObserver.idl
trunk/Source/WebCore/html/DOMFormData.idl
trunk/Source/WebCore/html/canvas/ArrayBuffer.idl
trunk/Source/WebCore/html/canvas/DataView.idl
trunk/Source/WebCore/html/canvas/Float32Array.idl
trunk/Source/WebCore/html/canvas/Float64Array.idl
trunk/Source/WebCore/html/canvas/Int16Array.idl
trunk/Source/WebCore/html/canvas/Int32Array.idl
trunk/Source/WebCore/html/canvas/Int8Array.idl
trunk/Source/WebCore/html/canvas/Uint16Array.idl
trunk/Source/WebCore/html/canvas/Uint32Array.idl
trunk/Source/WebCore/html/canvas/Uint8Array.idl
trunk/Source/WebCore/html/canvas/Uint8ClampedArray.idl
trunk/Source/WebCore/webaudio/AudioContext.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (109034 => 109035)
--- trunk/LayoutTests/ChangeLog 2012-02-27 23:56:09 UTC (rev 109034)
+++ trunk/LayoutTests/ChangeLog 2012-02-27 23:59:55 UTC (rev 109035)
@@ -1,3 +1,15 @@
+2012-02-27 Kentaro Hara hara...@chromium.org
+
+[JSC] Add [ConstructorParameters=] to all custom constructors
+https://bugs.webkit.org/show_bug.cgi?id=78221
+
+Reviewed by Adam Barth.
+
+The added tests check the length property of the custom constructors.
+
+* fast/js/constructor-length.html:
+* platform/mac/fast/js/constructor-length-expected.txt:
+
2012-02-27 Adrienne Walker e...@google.com
[chromium] Unreviewed gardening, mark many svg tests as flaky crashers
Modified: trunk/LayoutTests/fast/js/constructor-length.html (109034 => 109035)
--- trunk/LayoutTests/fast/js/constructor-length.html 2012-02-27 23:56:09 UTC (rev 109034)
+++ trunk/LayoutTests/fast/js/constructor-length.html 2012-02-27 23:59:55 UTC (rev 109035)
@@ -7,17 +7,26 @@
script
description(This tests the length property of constructors.);
+shouldBe('ArrayBuffer.length', '1');
+shouldBe('AudioContext.length', '0');
shouldBe('BeforeLoadEvent.length', '2');
shouldBe('CloseEvent.length', '2');
shouldBe('CustomEvent.length', '2');
+shouldBe('DOMFormData.length', '0');
shouldBe('DOMParser.length', '0');
shouldBe('DOMURL.length', '0');
+shouldBe('DataView.length', '3');
shouldBe('ErrorEvent.length', '2');
shouldBe('Event.length', '2');
shouldBe('EventSource.length', '1');
+shouldBe('Float32Array.length', '1');
+shouldBe('Float64Array.length', '1');
shouldBe('FileReader.length', '0');
shouldBe('FileReaderSync.length', '0');
shouldBe('HashChangeEvent.length', '2');
+shouldBe('Int16Array.length', '1');
+shouldBe('Int32Array.length', '1');
+shouldBe('Int8Array.length', '1');
shouldBe('Intent.length', '3');
shouldBe('MediaController.length', '0');
shouldBe('MediaStream.length', '2');
@@ -33,11 +42,18 @@
shouldBe('StorageEvent.length', '2');
shouldBe('TextTrackCue.length', '6');
shouldBe('TrackEvent.length', '2');
+shouldBe('Uint16Array.length', '1');
+shouldBe('Uint32Array.length', '1');
+shouldBe('Uint8Array.length', '1');
+shouldBe('Uint8ClampedArray.length', '1');
shouldBe('WebGLContextEvent.length', '2');
shouldBe('WebKitAnimationEvent.length', '2');
shouldBe('WebKitBlobBuilder.length', '0');
shouldBe('WebKitCSSMatrix.length', '1');
+shouldBe('WebKitMutationObserver.length', '1');
+shouldBe('WebKitPoint.length',
[webkit-changes] [109036] trunk/Source/WebCore
Title: [109036] trunk/Source/WebCore Revision 109036 Author hara...@chromium.org Date 2012-02-27 16:07:01 -0800 (Mon, 27 Feb 2012) Log Message Rename resolve-supplemental.pl to preprocess-idls.pl https://bugs.webkit.org/show_bug.cgi?id=79660 Reviewed by Adam Barth. Due to r108322, resolve-supplemental.pl not only resolves supplemental dependencies but also runs IDL attribute checker. For clarification, this patch renames resolve-supplemental.pl to preprocess-idls.pl. No tests. Confirm that all builds pass. * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.am: * UseJSC.cmake: * UseV8.cmake: * WebCore.gyp/WebCore.gyp: * WebCore.vcproj/MigrateScripts: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/scripts/preprocess-idls.pl: Renamed from Source/WebCore/bindings/scripts/resolve-supplemental.pl. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/DerivedSources.pri trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/UseJSC.cmake trunk/Source/WebCore/UseV8.cmake trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/WebCore.vcproj/MigrateScripts trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj Added Paths trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl Removed Paths trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl Diff Modified: trunk/Source/WebCore/ChangeLog (109035 => 109036) --- trunk/Source/WebCore/ChangeLog 2012-02-27 23:59:55 UTC (rev 109035) +++ trunk/Source/WebCore/ChangeLog 2012-02-28 00:07:01 UTC (rev 109036) @@ -1,5 +1,29 @@ 2012-02-27 Kentaro Hara hara...@chromium.org +Rename resolve-supplemental.pl to preprocess-idls.pl +https://bugs.webkit.org/show_bug.cgi?id=79660 + +Reviewed by Adam Barth. + +Due to r108322, resolve-supplemental.pl not only resolves supplemental +dependencies but also runs IDL attribute checker. For clarification, +this patch renames resolve-supplemental.pl to preprocess-idls.pl. + +No tests. Confirm that all builds pass. + +* DerivedSources.make: +* DerivedSources.pri: +* GNUmakefile.am: +* UseJSC.cmake: +* UseV8.cmake: +* WebCore.gyp/WebCore.gyp: +* WebCore.vcproj/MigrateScripts: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* bindings/scripts/preprocess-idls.pl: Renamed from Source/WebCore/bindings/scripts/resolve-supplemental.pl. + +2012-02-27 Kentaro Hara hara...@chromium.org + [JSC] Add [ConstructorParameters=] to all custom constructors https://bugs.webkit.org/show_bug.cgi?id=78221 Modified: trunk/Source/WebCore/DerivedSources.make (109035 => 109036) --- trunk/Source/WebCore/DerivedSources.make 2012-02-27 23:59:55 UTC (rev 109035) +++ trunk/Source/WebCore/DerivedSources.make 2012-02-28 00:07:01 UTC (rev 109036) @@ -893,13 +893,13 @@ bindings/scripts/generate-bindings.pl \ bindings/scripts/preprocessor.pm -RESOLVE_SUPPLEMENTAL_SCRIPTS = \ +PREPROCESS_IDLS_SCRIPTS = \ bindings/scripts/IDLParser.pm \ -bindings/scripts/resolve-supplemental.pl +bindings/scripts/preprocess-idls.pl generator_script = perl $(addprefix -I $(WebCore)/, $(sort $(dir $(1 $(WebCore)/bindings/scripts/generate-bindings.pl -resolve_supplemental_script = perl $(addprefix -I $(WebCore)/, $(sort $(dir $(1 $(WebCore)/bindings/scripts/resolve-supplemental.pl +preprocess_idls_script = perl $(addprefix -I $(WebCore)/, $(sort $(dir $(1 $(WebCore)/bindings/scripts/preprocess-idls.pl # JS bindings generator @@ -927,9 +927,9 @@ space := space += -$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(RESOLVE_SUPPLEMENTAL_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS) $(IDL_ATTRIBUTES_FILE) +$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(PREPROCESS_IDLS_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS) $(IDL_ATTRIBUTES_FILE) printf $(subst $(space),,$(patsubst %,%\n,$(BINDING_IDLS) $(ADDITIONAL_IDLS))) $(IDL_FILES_TMP) - $(call resolve_supplemental_script, $(RESOLVE_SUPPLEMENTAL_SCRIPTS)) --defines $(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE) + $(call preprocess_idls_script, $(PREPROCESS_IDLS_SCRIPTS)) --defines $(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE) rm -f $(IDL_FILES_TMP) JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(SUPPLEMENTAL_DEPENDENCY_FILE) Modified: trunk/Source/WebCore/DerivedSources.pri (109035 => 109036) --- trunk/Source/WebCore/DerivedSources.pri 2012-02-27 23:59:55 UTC (rev 109035) +++ trunk/Source/WebCore/DerivedSources.pri 2012-02-28 00:07:01 UTC (rev 109036) @@ -665,23 +665,23 @@ # GENERATOR 0: Resolve [Supplemental]
[webkit-changes] [109037] trunk/Source/WebCore/ChangeLog
Title: [109037] trunk/Source/WebCore/ChangeLog Revision 109037 Author morr...@google.com Date 2012-02-27 16:17:18 -0800 (Mon, 27 Feb 2012) Log Message Unreviewed, fixed wrong bug URL on the ChangeLog. Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/ChangeLog (109036 => 109037) --- trunk/Source/WebCore/ChangeLog 2012-02-28 00:07:01 UTC (rev 109036) +++ trunk/Source/WebCore/ChangeLog 2012-02-28 00:17:18 UTC (rev 109037) @@ -728,7 +728,7 @@ 2012-02-27 MORITA Hajime morr...@google.com Removing ul, li inside shadow DOM triggers assertion in updateListMarkerNumbers -https://bugs.webkit.org/show_bug.cgi?id=79630 +https://bugs.webkit.org/show_bug.cgi?id=72440 Reviewed by Ryosuke Niwa. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109038] trunk/Source/JavaScriptCore
Title: [109038] trunk/Source/_javascript_Core Revision 109038 Author barraclo...@apple.com Date 2012-02-27 16:31:28 -0800 (Mon, 27 Feb 2012) Log Message Implement support for op_negate and op_bitnot in the DFG JIT https://bugs.webkit.org/show_bug.cgi?id=79617 Reviewed by Filip Pizlo. Add an ArithNegate op to the DFG JIT, to implement op_negate. This patch also adds support for op_negate to the JSVALUE64 baseline JIT (JSVALUE32_64 already had this), so that we can profile the slowpath usage. This is a 2.5%-3% Sunspider progression and a 1% win on Kraken. * assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::sub_S): - Added sub_S from immediate. (ARMv7Assembler): (JSC::ARMv7Assembler::vneg): - Added double negate. * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::negateDouble): - Added double negate. (MacroAssemblerARMv7): (JSC::MacroAssemblerARMv7::branchNeg32): - Added. * assembler/MacroAssemblerX86.h: (MacroAssemblerX86): - moved loadDouble, absDouble to common. * assembler/MacroAssemblerX86Common.h: (MacroAssemblerX86Common): (JSC::MacroAssemblerX86Common::absDouble): - implementation can be shared. (JSC::MacroAssemblerX86Common::negateDouble): - Added. (JSC::MacroAssemblerX86Common::loadDouble): - allow absDouble to have a common implementation. * assembler/MacroAssemblerX86_64.h: (MacroAssemblerX86_64): - moved loadDouble, absDouble to common. * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::execute): - support ArithNegate. * dfg/DFGArithNodeFlagsInferencePhase.cpp: (JSC::DFG::ArithNodeFlagsInferencePhase::propagate): - support ArithNegate. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::makeSafe): - support ArithNegate. (JSC::DFG::ByteCodeParser::parseBlock): - support op_negate. * dfg/DFGCSEPhase.cpp: (JSC::DFG::CSEPhase::performNodeCSE): - support ArithNegate. * dfg/DFGCapabilities.h: (JSC::DFG::canCompileOpcode): - support op_negate. * dfg/DFGGraph.h: (JSC::DFG::Graph::negateShouldSpeculateInteger): - support ArithNegate. * dfg/DFGNode.h: (JSC::DFG::Node::hasArithNodeFlags): - support ArithNegate. * dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate): - support ArithNegate. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileArithNegate): - support ArithNegate. * dfg/DFGSpeculativeJIT.h: (SpeculativeJIT): - support ArithNegate. * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): - support ArithNegate. * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): - support ArithNegate. * jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): - Add support for op_negate in JSVALUE64. * jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate): - Add support for op_negate in JSVALUE64. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp trunk/Source/_javascript_Core/dfg/DFGArithNodeFlagsInferencePhase.cpp trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp trunk/Source/_javascript_Core/dfg/DFGCapabilities.h trunk/Source/_javascript_Core/dfg/DFGGraph.h trunk/Source/_javascript_Core/dfg/DFGNode.h trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/jit/JIT.cpp trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/jit/JITArithmetic.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (109037 => 109038) --- trunk/Source/_javascript_Core/ChangeLog 2012-02-28 00:17:18 UTC (rev 109037) +++ trunk/Source/_javascript_Core/ChangeLog 2012-02-28 00:31:28 UTC (rev 109038) @@ -1,3 +1,90 @@ +2012-02-27 Gavin Barraclough barraclo...@apple.com + +Implement support for op_negate and op_bitnot in the DFG JIT +https://bugs.webkit.org/show_bug.cgi?id=79617 + +Reviewed by Filip Pizlo. + +Add an ArithNegate op to the DFG JIT, to implement op_negate. + +This patch also adds support for op_negate to the JSVALUE64 baseline JIT +(JSVALUE32_64 already had this), so that we can profile the slowpath usage. + +This is a 2.5%-3% Sunspider progression and a 1% win on Kraken. + +* assembler/ARMv7Assembler.h: +(JSC::ARMv7Assembler::sub_S): +- Added sub_S from immediate. +
[webkit-changes] [109039] trunk
Title: [109039] trunk Revision 109039 Author commit-qu...@webkit.org Date 2012-02-27 16:36:14 -0800 (Mon, 27 Feb 2012) Log Message [EFL] Support mutation observers https://bugs.webkit.org/show_bug.cgi?id=79603 Patch by ChangSeok Oh shivami...@gmail.com on 2012-02-27 Reviewed by Eric Seidel. .: Added a build-option for the mutation observers feature. * Source/cmake/OptionsEfl.cmake: * Source/cmakeconfig.h.cmake: LayoutTests: Rebased skipped tests regarding the mutation observers feature. * platform/efl/Skipped: Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/Source/cmake/OptionsEfl.cmake trunk/Source/cmakeconfig.h.cmake Diff Modified: trunk/ChangeLog (109038 => 109039) --- trunk/ChangeLog 2012-02-28 00:31:28 UTC (rev 109038) +++ trunk/ChangeLog 2012-02-28 00:36:14 UTC (rev 109039) @@ -1,3 +1,15 @@ +2012-02-27 ChangSeok Oh shivami...@gmail.com + +[EFL] Support mutation observers +https://bugs.webkit.org/show_bug.cgi?id=79603 + +Reviewed by Eric Seidel. + +Added a build-option for the mutation observers feature. + +* Source/cmake/OptionsEfl.cmake: +* Source/cmakeconfig.h.cmake: + 2012-02-26 Shinya Kawanaka shin...@chromium.org Rename ShadowRootList to ShadowTree. Modified: trunk/LayoutTests/ChangeLog (109038 => 109039) --- trunk/LayoutTests/ChangeLog 2012-02-28 00:31:28 UTC (rev 109038) +++ trunk/LayoutTests/ChangeLog 2012-02-28 00:36:14 UTC (rev 109039) @@ -1,3 +1,14 @@ +2012-02-27 ChangSeok Oh shivami...@gmail.com + +[EFL] Support mutation observers +https://bugs.webkit.org/show_bug.cgi?id=79603 + +Reviewed by Eric Seidel. + +Rebased skipped tests regarding the mutation observers feature. + +* platform/efl/Skipped: + 2012-02-27 Kentaro Hara hara...@chromium.org [JSC] Add [ConstructorParameters=] to all custom constructors Modified: trunk/LayoutTests/platform/efl/Skipped (109038 => 109039) --- trunk/LayoutTests/platform/efl/Skipped 2012-02-28 00:31:28 UTC (rev 109038) +++ trunk/LayoutTests/platform/efl/Skipped 2012-02-28 00:36:14 UTC (rev 109039) @@ -1065,7 +1065,7 @@ fast/filesystem http/tests/filesystem http/tests/security/filesystem-iframe-from-remote.html -fast/mutation/end-of-task-delivery.html +fast/mutation/filesystem-callback-delivery.html # The EFL port has no support for Geolocation fast/dom/Geolocation @@ -1248,7 +1248,12 @@ # Fails because MutationObservers are not notified at end-of-task # https://bugs.webkit.org/show_bug.cgi?id=78290 fast/mutation/end-of-task-delivery.html +fast/mutation/inline-event-listener.html +# Fails because of the security policy of the user agent? +# http://webkit.org/b/79604 +fast/mutation/database-callback-delivery.html + # # Tests which are expected to fail # @@ -2212,17 +2217,6 @@ fast/mediastream/peerconnection-argument-types.html fast/mediastream/peerconnection-eventlistener-optional-argument.html fast/mediastream/peerconnection-removestream.html -fast/mutation/callback-second-argument.html -fast/mutation/cross-document.html -fast/mutation/database-callback-delivery.html -fast/mutation/filesystem-callback-delivery.html -fast/mutation/inline-event-listener.html -fast/mutation/mutation-observer-constructor.html -fast/mutation/observe-attributes.html -fast/mutation/observe-characterdata.html -fast/mutation/observe-childList.html -fast/mutation/observe-exceptions.html -fast/mutation/observe-subtree.html fast/multicol fast/overflow/overflow-float-stacking.html fast/overflow/overflow-stacking.html Modified: trunk/Source/cmake/OptionsEfl.cmake (109038 => 109039) --- trunk/Source/cmake/OptionsEfl.cmake 2012-02-28 00:31:28 UTC (rev 109038) +++ trunk/Source/cmake/OptionsEfl.cmake 2012-02-28 00:36:14 UTC (rev 109039) @@ -82,6 +82,7 @@ WEBKIT_FEATURE(ENABLE_MATHML Enable MathML DEFAULT ON) WEBKIT_FEATURE(ENABLE_METER_TAG Enable Meter tag DEFAULT ON) WEBKIT_FEATURE(ENABLE_MICRODATA Enable HTML5 microdata support DEFAULT OFF) +WEBKIT_FEATURE(ENABLE_MUTATION_OBSERVERS Enable HTML5 mutation observers support DEFAULT ON) WEBKIT_FEATURE(ENABLE_NETSCAPE_PLUGIN_API Enable Netscape plugin API DEFAULT OFF) WEBKIT_FEATURE(ENABLE_NOTIFICATIONS Enable notifications DEFAULT OFF) WEBKIT_FEATURE(ENABLE_ORIENTATION_EVENTS Enable orientation events DEFAULT OFF) Modified: trunk/Source/cmakeconfig.h.cmake (109038 => 109039) --- trunk/Source/cmakeconfig.h.cmake 2012-02-28 00:31:28 UTC (rev 109038) +++ trunk/Source/cmakeconfig.h.cmake 2012-02-28 00:36:14 UTC (rev 109039) @@ -27,6 +27,7 @@ #cmakedefine01 ENABLE_MATHML #cmakedefine01 ENABLE_METER_TAG #cmakedefine01 ENABLE_MICRODATA +#cmakedefine01 ENABLE_MUTATION_OBSERVERS #cmakedefine01 ENABLE_NETSCAPE_PLUGIN_API #cmakedefine01 ENABLE_NOTIFICATIONS #cmakedefine01 ENABLE_ORIENTATION_EVENTS ___
[webkit-changes] [109040] trunk/Source/JavaScriptCore
Title: [109040] trunk/Source/_javascript_Core
Revision 109040
Author fpi...@apple.com
Date 2012-02-27 16:37:58 -0800 (Mon, 27 Feb 2012)
Log Message
Old JIT's style of JSVALUE64 strict equality is subtly wrong
https://bugs.webkit.org/show_bug.cgi?id=79700
Reviewed by Oliver Hunt.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::comparePtr):
(MacroAssemblerX86_64):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
* jit/JITOpcodes.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (109039 => 109040)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-28 00:37:58 UTC (rev 109040)
@@ -1,3 +1,26 @@
+2012-02-27 Filip Pizlo fpi...@apple.com
+
+Old JIT's style of JSVALUE64 strict equality is subtly wrong
+https://bugs.webkit.org/show_bug.cgi?id=79700
+
+Reviewed by Oliver Hunt.
+
+* assembler/MacroAssemblerX86_64.h:
+(JSC::MacroAssemblerX86_64::comparePtr):
+(MacroAssemblerX86_64):
+* dfg/DFGOperations.cpp:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
+(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
+* jit/JITOpcodes.cpp:
+(JSC::JIT::compileOpStrictEq):
+(JSC::JIT::emitSlow_op_stricteq):
+(JSC::JIT::emitSlow_op_nstricteq):
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION):
+
2012-02-27 Gavin Barraclough barraclo...@apple.com
Implement support for op_negate and op_bitnot in the DFG JIT
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h (109039 => 109040)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h 2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h 2012-02-28 00:37:58 UTC (rev 109040)
@@ -334,6 +334,13 @@
m_assembler.movzbl_rr(dest, dest);
}
+void comparePtr(RelationalCondition cond, RegisterID left, RegisterID right, RegisterID dest)
+{
+m_assembler.cmpq_rr(right, left);
+m_assembler.setCC_r(x86Condition(cond), dest);
+m_assembler.movzbl_rr(dest, dest);
+}
+
Jump branchAdd32(ResultCondition cond, TrustedImm32 src, AbsoluteAddress dest)
{
move(TrustedImmPtr(dest.m_ptr), scratchRegister);
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (109039 => 109040)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-02-28 00:37:58 UTC (rev 109040)
@@ -736,8 +736,14 @@
{
JSGlobalData* globalData = exec-globalData();
NativeCallFrameTracer tracer(globalData, exec);
+
+JSValue src1 = JSValue::decode(encodedOp1);
+JSValue src2 = JSValue::decode(encodedOp2);
-return JSValue::strictEqual(exec, JSValue::decode(encodedOp1), JSValue::decode(encodedOp2));
+ASSERT((src1.isCell() src2.isCell())
+ || src1.isDouble() || src2.isDouble());
+
+return JSValue::strictEqual(exec, src1, src2);
}
static void* handleHostCall(ExecState* execCallee, JSValue callee, CodeSpecializationKind kind)
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (109039 => 109040)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2012-02-28 00:36:14 UTC (rev 109039)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2012-02-28 00:37:58 UTC (rev 109040)
@@ -383,9 +383,6 @@
bool SpeculativeJIT::nonSpeculativeStrictEq(Node node, bool invert)
{
-if (!invert (isKnownNumeric(node.child1().index()) || isKnownNumeric(node.child2().index(
-return nonSpeculativeCompare(node, MacroAssembler::Equal, operationCompareStrictEq);
-
NodeIndex branchNodeIndex = detectPeepHoleBranch();
if (branchNodeIndex != NoNode) {
ASSERT(node.adjustedRefCount() == 1);
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (109039 => 109040)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2012-02-28
[webkit-changes] [109041] trunk
Title: [109041] trunk
Revision 109041
Author commit-qu...@webkit.org
Date 2012-02-27 16:48:53 -0800 (Mon, 27 Feb 2012)
Log Message
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527
Patch by Greg Billock gbill...@google.com on 2012-02-27
Reviewed by Adam Barth.
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):
LayoutTests:
* webintents/resources/web-intents-testing.js: Added.
* webintents/web-intents-failure-expected.txt: Added.
* webintents/web-intents-failure.html: Added.
* webintents/web-intents-invoke-expected.txt: Added.
* webintents/web-intents-invoke.html: Added.
* webintents/web-intents-reply-expected.txt: Added.
* webintents/web-intents-reply.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webintents/web-intents-reload.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Added Paths
trunk/LayoutTests/webintents/resources/web-intents-testing.js
trunk/LayoutTests/webintents/web-intents-failure-expected.txt
trunk/LayoutTests/webintents/web-intents-failure.html
trunk/LayoutTests/webintents/web-intents-invoke-expected.txt
trunk/LayoutTests/webintents/web-intents-invoke.html
trunk/LayoutTests/webintents/web-intents-reply-expected.txt
trunk/LayoutTests/webintents/web-intents-reply.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109040 => 109041)
--- trunk/LayoutTests/ChangeLog 2012-02-28 00:37:58 UTC (rev 109040)
+++ trunk/LayoutTests/ChangeLog 2012-02-28 00:48:53 UTC (rev 109041)
@@ -1,3 +1,18 @@
+2012-02-27 Greg Billock gbill...@google.com
+
+Add more tests for web intents
+https://bugs.webkit.org/show_bug.cgi?id=79527
+
+Reviewed by Adam Barth.
+
+* webintents/resources/web-intents-testing.js: Added.
+* webintents/web-intents-failure-expected.txt: Added.
+* webintents/web-intents-failure.html: Added.
+* webintents/web-intents-invoke-expected.txt: Added.
+* webintents/web-intents-invoke.html: Added.
+* webintents/web-intents-reply-expected.txt: Added.
+* webintents/web-intents-reply.html: Added.
+
2012-02-27 ChangSeok Oh shivami...@gmail.com
[EFL] Support mutation observers
Added: trunk/LayoutTests/webintents/resources/web-intents-testing.js (0 => 109041)
--- trunk/LayoutTests/webintents/resources/web-intents-testing.js (rev 0)
+++ trunk/LayoutTests/webintents/resources/web-intents-testing.js 2012-02-28 00:48:53 UTC (rev 109041)
@@ -0,0 +1,40 @@
+// Callback function to be used for a successful web intent call.
+function onSuccess(data) {
+ debug(* got reply: + data);
+
+ if (window.layoutTestController) {
+window.layoutTestController.notifyDone();
+ }
+}
+
+// Callback function to be used for a failed web intent call.
+function onFailure(data) {
+ debug(* got failure: + data);
+
+ if (window.layoutTestController) {
+window.layoutTestController.notifyDone();
+ }
+}
+
+// Launch a web intent call with callbacks.
+function startIntentWithCallbacks() {
+ navigator.startActivity(new Intent(action1, mime/type1, test), onSuccess, onFailure);
+ debug(* sent intent);
+
+ if (window.layoutTestController) {
+window.layoutTestController.waitUntilDone();
+ } else {
+alert('This test needs to run in DRT');
+ }
+}
+
+// This button press simulator sets the user gesture indicator that an intent
+// requires to start.
+function simulateButtonPress() {
+ var button = document.getElementById(button);
+ if (eventSender) {
+eventSender.mouseMoveTo(button.getBoundingClientRect().left + 2, button.getBoundingClientRect().top + 12);
+eventSender.mouseDown();
+eventSender.mouseUp();
+ }
+}
Added: trunk/LayoutTests/webintents/web-intents-failure-expected.txt (0 => 109041)
--- trunk/LayoutTests/webintents/web-intents-failure-expected.txt (rev 0)
+++ trunk/LayoutTests/webintents/web-intents-failure-expected.txt 2012-02-28 00:48:53 UTC (rev 109041)
@@ -0,0 +1,7 @@
+Received Web Intent: action="" type=mime/type1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+* sent intent
+* got failure: ERROR
+
Added: trunk/LayoutTests/webintents/web-intents-failure.html (0 => 109041)
--- trunk/LayoutTests/webintents/web-intents-failure.html (rev 0)
+++ trunk/LayoutTests/webintents/web-intents-failure.html 2012-02-28 00:48:53 UTC (rev 109041)
@@ -0,0 +1,20 @@
+html
+ head
+script src=""
+script src=""
+script
+ function buttonClicked() {
+startIntentWithCallbacks();
+
+if (window.layoutTestController) {
+
[webkit-changes] [109042] trunk/Source/WebCore
Title: [109042] trunk/Source/WebCore
Revision 109042
Author jchaffr...@webkit.org
Date 2012-02-27 17:05:10 -0800 (Mon, 27 Feb 2012)
Log Message
Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject
https://bugs.webkit.org/show_bug.cgi?id=79580
Reviewed by Eric Seidel.
Refactoring only.
* rendering/RenderTableSection.h:
(CellSpan):
(WebCore::CellSpan::CellSpan):
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
Added this class to hold the span information.
(WebCore::RenderTableSection::fullTableRowSpan):
(WebCore::RenderTableSection::fullTableColumnSpan):
Those functions return the span corresponding to the full table.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
Those functions compute the rows / columns impacted by a |damageRect|. On the slow painting path, they
return the full table span.
(WebCore::RenderTableSection::paintObject):
Updated this function to call the new ones. Also we now inflate the local rectangle with the outlineSize.
This wasn't done previously and we had to manually patch some size comparison to account for the outline.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderTableSection.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109041 => 109042)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 00:48:53 UTC (rev 109041)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 01:05:10 UTC (rev 109042)
@@ -1,3 +1,33 @@
+2012-02-27 Julien Chaffraix jchaffr...@webkit.org
+
+Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject
+https://bugs.webkit.org/show_bug.cgi?id=79580
+
+Reviewed by Eric Seidel.
+
+Refactoring only.
+
+* rendering/RenderTableSection.h:
+(CellSpan):
+(WebCore::CellSpan::CellSpan):
+(WebCore::CellSpan::start):
+(WebCore::CellSpan::end):
+Added this class to hold the span information.
+
+(WebCore::RenderTableSection::fullTableRowSpan):
+(WebCore::RenderTableSection::fullTableColumnSpan):
+Those functions return the span corresponding to the full table.
+
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::dirtiedRows):
+(WebCore::RenderTableSection::dirtiedColumns):
+Those functions compute the rows / columns impacted by a |damageRect|. On the slow painting path, they
+return the full table span.
+
+(WebCore::RenderTableSection::paintObject):
+Updated this function to call the new ones. Also we now inflate the local rectangle with the outlineSize.
+This wasn't done previously and we had to manually patch some size comparison to account for the outline.
+
2012-02-27 Kentaro Hara hara...@chromium.org
Rename resolve-supplemental.pl to preprocess-idls.pl
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (109041 => 109042)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-02-28 00:48:53 UTC (rev 109041)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-02-28 01:05:10 UTC (rev 109042)
@@ -993,18 +993,64 @@
cell-paint(paintInfo, cellPoint);
}
+CellSpan RenderTableSection::dirtiedRows(const LayoutRect damageRect) const
+{
+if (m_forceSlowPaintPathWithOverflowingCell)
+return fullTableRowSpan();
+
+LayoutUnit before = style()-isHorizontalWritingMode() ? damageRect.y() : damageRect.x();
+
+// binary search to find a row
+unsigned startRow = std::lower_bound(m_rowPos.begin(), m_rowPos.end(), before) - m_rowPos.begin();
+
+// The binary search above gives us the first row with
+// a y position = the top of the paint rect. Thus, the previous
+// may need to be repainted as well.
+if (startRow == m_rowPos.size() || (startRow 0 (m_rowPos[startRow] before)))
+--startRow;
+
+LayoutUnit after = (style()-isHorizontalWritingMode() ? damageRect.maxY() : damageRect.maxX());
+unsigned endRow = std::lower_bound(m_rowPos.begin(), m_rowPos.end(), after) - m_rowPos.begin();
+if (endRow == m_rowPos.size())
+--endRow;
+
+if (!endRow m_rowPos[0] - table()-outerBorderBefore() = after)
+++endRow;
+
+return CellSpan(startRow, endRow);
+}
+
+
+CellSpan RenderTableSection::dirtiedColumns(const LayoutRect damageRect) const
+{
+if (m_forceSlowPaintPathWithOverflowingCell)
+return fullTableColumnSpan();
+
+// FIXME: Implement RTL.
+if (!style()-isLeftToRightDirection())
+return fullTableColumnSpan();
+
+LayoutUnit start = style()-isHorizontalWritingMode() ? damageRect.x() : damageRect.y();
+Vectorint columnPos = table()-columnPositions();
+unsigned startCol = std::lower_bound(columnPos.begin(), columnPos.end(), start) - columnPos.begin();
+if ((startCol ==
[webkit-changes] [109043] trunk/Source/WebKit/chromium
Title: [109043] trunk/Source/WebKit/chromium
Revision 109043
Author e...@google.com
Date 2012-02-27 17:05:27 -0800 (Mon, 27 Feb 2012)
Log Message
[chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=79718
* tests/TransparencyWinTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (109042 => 109043)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-28 01:05:10 UTC (rev 109042)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-28 01:05:27 UTC (rev 109043)
@@ -1,3 +1,10 @@
+2012-02-27 Adrienne Walker e...@google.com
+
+[chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
+https://bugs.webkit.org/show_bug.cgi?id=79718
+
+* tests/TransparencyWinTest.cpp:
+
2012-02-26 Hajime Morrita morr...@chromium.org
Move ChromeClient::showContextMenu() to ContextMenuClient
Modified: trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp (109042 => 109043)
--- trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp 2012-02-28 01:05:10 UTC (rev 109042)
+++ trunk/Source/WebKit/chromium/tests/TransparencyWinTest.cpp 2012-02-28 01:05:27 UTC (rev 109043)
@@ -98,7 +98,7 @@
return out;
}
-TEST(TransparencyWin, NoLayer)
+TEST(TransparencyWin, DISABLED_NoLayer)
{
OwnPtrImageBuffer src(ImageBuffer::create(IntSize(17, 16), ColorSpaceDeviceRGB));
@@ -137,7 +137,7 @@
src-context()-restore();
}
-TEST(TransparencyWin, WhiteLayer)
+TEST(TransparencyWin, DISABLED_WhiteLayer)
{
OwnPtrImageBuffer src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));
@@ -189,7 +189,7 @@
src-context()-restore();
}
-TEST(TransparencyWin, TextComposite)
+TEST(TransparencyWin, DISABLED_TextComposite)
{
OwnPtrImageBuffer src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));
@@ -208,7 +208,7 @@
}
}
-TEST(TransparencyWin, OpaqueCompositeLayer)
+TEST(TransparencyWin, DISABLED_OpaqueCompositeLayer)
{
OwnPtrImageBuffer src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));
@@ -277,7 +277,7 @@
src-context()-restore();
}
-TEST(TransparencyWin, WhiteLayerPixelTest)
+TEST(TransparencyWin, DISABLED_WhiteLayerPixelTest)
{
// Make a total transparent buffer, and draw the white layer inset by 1 px.
OwnPtrImageBuffer src(ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109044] branches/chromium/1025
Title: [109044] branches/chromium/1025
Revision 109044
Author ba...@chromium.org
Date 2012-02-27 17:10:26 -0800 (Mon, 27 Feb 2012)
Log Message
Merge 108724 - Don't clear IntentRequest callback pointers on stop()
This causes re-entry into ScriptExecutionContext when
the ActiveDOMCallback objects get deleted, which crashes.
Instead, just de-activate the object and wait for
context destruction to clean up.
Test crashes consistently without fix and passes with fix.
Added some test infrastructure to support this test.
https://bugs.webkit.org/show_bug.cgi?id=78638
Patch by Greg Billock gbill...@google.com on 2012-02-23
Reviewed by Adam Barth.
* Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::stop):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):
* Modules/intents/IntentRequest.h:
(IntentRequest):
TBR=gbill...@google.com
Review URL: https://chromiumcodereview.appspot.com/9479030
Modified Paths
branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp
branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.h
branches/chromium/1025/Tools/DumpRenderTree/chromium/WebViewHost.cpp
branches/chromium/1025/Tools/DumpRenderTree/chromium/WebViewHost.h
Added Paths
branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt
branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html
Diff
Copied: branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt (from rev 108724, trunk/LayoutTests/webintents/web-intents-reload-expected.txt) (0 => 109044)
--- branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt (rev 0)
+++ branches/chromium/1025/LayoutTests/webintents/web-intents-reload-expected.txt 2012-02-28 01:10:26 UTC (rev 109044)
@@ -0,0 +1,10 @@
+Received Web Intent: action="" type=type
+* loaded
+* sent mouseup
+* loaded replacement page
+
+
+
+Frame: 'frame'
+
+PASS
Copied: branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html (from rev 108724, trunk/LayoutTests/webintents/web-intents-reload.html) (0 => 109044)
--- branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html (rev 0)
+++ branches/chromium/1025/LayoutTests/webintents/web-intents-reload.html 2012-02-28 01:10:26 UTC (rev 109044)
@@ -0,0 +1,49 @@
+html
+ head
+script src=""
+script
+ var latch = true;
+
+ function buttonClicked() {
+frames[0].startIntent();
+ }
+
+ function frameloaded() {
+if (latch) {
+ latch = false;
+ startTest();
+ return;
+}
+
+debug(* loaded replacement page);
+
+if (window.layoutTestController) {
+ window.layoutTestController.notifyDone();
+}
+ }
+
+ function startTest() {
+if (window.layoutTestController) {
+ window.layoutTestController.waitUntilDone();
+ window.layoutTestController.dumpChildFramesAsText();
+}
+
+debug(* loaded);
+
+// We must simulate a button press with eventSender because intents
+// require a user gesture.
+var button = document.getElementById(button);
+if (eventSender) {
+ eventSender.mouseMoveTo(button.getBoundingClientRect().left + 2, button.getBoundingClientRect().top + 12);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+ debug(* sent mouseup);
+}
+ }
+/script
+ /head
+body
+input type=button id=button value=Start Web Intent _onmouseup_=buttonClicked()
+iframe id=frame _onload_=frameloaded() src=""
+/body
+/html
Modified: branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp (109043 => 109044)
--- branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp 2012-02-28 01:05:27 UTC (rev 109043)
+++ branches/chromium/1025/Source/WebCore/Modules/intents/IntentRequest.cpp 2012-02-28 01:10:26 UTC (rev 109044)
@@ -52,24 +52,26 @@
, m_intent(intent)
, m_successCallback(successCallback)
, m_errorCallback(errorCallback)
+, m_stopped(false)
{
}
void IntentRequest::contextDestroyed()
{
ContextDestructionObserver::contextDestroyed();
-m_successCallback.clear();
-m_errorCallback.clear();
+m_stopped = true;
}
void IntentRequest::stop()
{
-m_successCallback.clear();
-m_errorCallback.clear();
+m_stopped = true;
}
void IntentRequest::postResult(SerializedScriptValue* data)
{
+if (m_stopped)
+return;
+
// Callback could lead to deletion of this.
RefPtrIntentRequest protector(this);
@@ -84,6 +86,9 @@
void IntentRequest::postFailure(SerializedScriptValue* data)
{
+if (m_stopped)
+return;
+
// Callback could lead to deletion of this.
RefPtrIntentRequest protector(this);
Modified:
[webkit-changes] [109045] trunk/LayoutTests
Title: [109045] trunk/LayoutTests
Revision 109045
Author dba...@webkit.org
Date 2012-02-27 17:12:37 -0800 (Mon, 27 Feb 2012)
Log Message
Add test case for ::selection:window-inactive
https://bugs.webkit.org/show_bug.cgi?id=79623
Reviewed by Beth Dakin.
Add reftest to ensure that we don't regress inactive selection color.
For completeness, support for inactive selection color was added in
http://trac.webkit.org/changeset/41094 (rdar://problem/605).
* fast/selectors/selection-window-inactive-expected.html: Added.
* fast/selectors/selection-window-inactive.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html
trunk/LayoutTests/fast/selectors/selection-window-inactive.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109044 => 109045)
--- trunk/LayoutTests/ChangeLog 2012-02-28 01:10:26 UTC (rev 109044)
+++ trunk/LayoutTests/ChangeLog 2012-02-28 01:12:37 UTC (rev 109045)
@@ -1,3 +1,18 @@
+2012-02-27 Daniel Bates dba...@webkit.org
+
+Add test case for ::selection:window-inactive
+https://bugs.webkit.org/show_bug.cgi?id=79623
+
+Reviewed by Beth Dakin.
+
+Add reftest to ensure that we don't regress inactive selection color.
+
+For completeness, support for inactive selection color was added in
+http://trac.webkit.org/changeset/41094 (rdar://problem/605).
+
+* fast/selectors/selection-window-inactive-expected.html: Added.
+* fast/selectors/selection-window-inactive.html: Added.
+
2012-02-27 Greg Billock gbill...@google.com
Add more tests for web intents
Added: trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html (0 => 109045)
--- trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html (rev 0)
+++ trunk/LayoutTests/fast/selectors/selection-window-inactive-expected.html 2012-02-28 01:12:37 UTC (rev 109045)
@@ -0,0 +1,8 @@
+!DOCTYPE html
+style
+span {
+background-color: rgba(63, 128, 33, 0.95);
+color: black;
+}
+/style
+spanAny textual selection in this sentence should have a green background when the window is inactive./span
Added: trunk/LayoutTests/fast/selectors/selection-window-inactive.html (0 => 109045)
--- trunk/LayoutTests/fast/selectors/selection-window-inactive.html (rev 0)
+++ trunk/LayoutTests/fast/selectors/selection-window-inactive.html 2012-02-28 01:12:37 UTC (rev 109045)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+style
+::selection {
+background-color: blue;
+color: yellow;
+}
+::selection:window-inactive {
+background-color: rgba(63, 128, 33, 0.95); /* green; alpha 1 so that we don't blend the background color with white. */
+color: black;
+}
+/style
+spanAny textual selection in this sentence should have a green background when the window is inactive./span
+script
+var span = document.querySelector(span);
+window.getSelection().setBaseAndExtent(span, 0, span, 1);
+if (window.layoutTestController)
+layoutTestController.setWindowIsKey(false);
+/script
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109046] trunk/LayoutTests
Title: [109046] trunk/LayoutTests Revision 109046 Author e...@google.com Date 2012-02-27 17:16:55 -0800 (Mon, 27 Feb 2012) Log Message [chromium] Unreviewed gardening, mark more svg tests as flaky crashers https://bugs.webkit.org/show_bug.cgi?id=79707 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109045 => 109046) --- trunk/LayoutTests/ChangeLog 2012-02-28 01:12:37 UTC (rev 109045) +++ trunk/LayoutTests/ChangeLog 2012-02-28 01:16:55 UTC (rev 109046) @@ -1,3 +1,10 @@ +2012-02-27 Adrienne Walker e...@google.com + +[chromium] Unreviewed gardening, mark more svg tests as flaky crashers +https://bugs.webkit.org/show_bug.cgi?id=79707 + +* platform/chromium/test_expectations.txt: + 2012-02-27 Daniel Bates dba...@webkit.org Add test case for ::selection:window-inactive Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109045 => 109046) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-28 01:12:37 UTC (rev 109045) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-28 01:16:55 UTC (rev 109046) @@ -1032,7 +1032,8 @@ // or change the test upstream to specify explicitly what font to use. // The mask part of this test is totally wrong. BUGCR3244 LEOPARD LINUX WIN : svg/as-background-image/svg-as-background-6.html = FAIL -BUGWK54322 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = TIMEOUT IMAGE +// Commented out because of BUGWK79707 below +//BUGWK54322 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = TIMEOUT IMAGE // Our gradients are wrong here. BUGCR19559 LINUX WIN : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = FAIL @@ -3383,7 +3384,8 @@ BUGWK71211 GPU LINUX DEBUG : fast/canvas/shadow-offset-3.html = PASS CRASH -BUGWK71673 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT +// Commented out because of BUGWK79707 below +//BUGWK71673 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT BUGWK71673 WIN LINUX : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = PASS IMAGE IMAGE+TEXT BUGWK71278 SLOW WIN : fast/events/dispatch-message-string-data.html = PASS @@ -3477,7 +3479,8 @@ BUGWK73643 WIN MAC : svg/filters/filter-placement-issue.svg = IMAGE //BUGWK73643 WIN MAC : svg/filters/filterRes.svg = IMAGE BUGWK73643 WIN MAC : svg/filters/filterRes2.svg = IMAGE -BUGWK73643 WIN MAC : svg/as-background-image/svg-as-background-2.html = IMAGE +// This also occurs on MAC, but is merged with BUGWK79707 below +BUGWK73643 WIN : svg/as-background-image/svg-as-background-2.html = IMAGE BUGWK73692 : media/event-attributes.html = TEXT PASS @@ -4252,3 +4255,8 @@ BUGWK79707 MAC RELEASE : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH BUGWK79707 MAC DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH IMAGE+TEXT BUGWK79707 MAC : svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html = PASS CRASH +BUGWK79707 MAC : svg/zoom/page/zoom-zoom-coords.xhtml = PASS CRASH +BUGWK79707 MAC : svg/as-background-image/svg-as-background-2.html = PASS IMAGE CRASH +BUGWK79707 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = PASS TIMEOUT IMAGE CRASH +BUGWK79707 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT CRASH +BUGWK79707 MAC : svg/custom/font-face-not-in-document.svg = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109047] branches/chromium/1025
Title: [109047] branches/chromium/1025 Revision 109047 Author rn...@webkit.org Date 2012-02-27 17:19:47 -0800 (Mon, 27 Feb 2012) Log Message Merge 108111 - REGRESSION: empty span creates renders with non-zero height https://bugs.webkit.org/show_bug.cgi?id=76465 Reviewed by David Hyatt. Source/WebCore: Tests: fast/css/empty-span.html fast/css/non-empty-span.html Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some other content in the line. So only create line boxes for such elements on lines that are not empty. This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line. It also fixes cases where lines with content that had a leading empty inline element weren't respecting the vertical alignment or font-height of the empty inline. * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty. (WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size will need a linebox if the rest of the line is not empty. (WebCore): (WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox. (WebCore::requiresLineBox): (WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark the line non-empty - otherwise hold off. LayoutTests: * fast/css/empty-span-expected.html: Added. * fast/css/empty-span.html: Added. * fast/css/non-empty-span.html: Added. * platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN. * platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added. * platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added. TBR=rob...@webkit.org Review URL: https://chromiumcodereview.appspot.com/9478022 Modified Paths branches/chromium/1025/Source/WebCore/rendering/RenderBlockLineLayout.cpp Added Paths branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html branches/chromium/1025/LayoutTests/fast/css/empty-span.html branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt Diff Copied: branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html (from rev 108111, trunk/LayoutTests/fast/css/empty-span-expected.html) (0 => 109047) --- branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html (rev 0) +++ branches/chromium/1025/LayoutTests/fast/css/empty-span-expected.html 2012-02-28 01:19:47 UTC (rev 109047) @@ -0,0 +1,15 @@ +!DOCTYPE html +html + head/head + body +divBefore empty span/div +span/span +divAfter empty span/div +divBefore empty span/div +span/span +divAfter empty span/div +divBefore empty span/div +span/span +divAfter empty span/div + /body +/html \ No newline at end of file Copied: branches/chromium/1025/LayoutTests/fast/css/empty-span.html (from rev 108111, trunk/LayoutTests/fast/css/empty-span.html) (0 => 109047) --- branches/chromium/1025/LayoutTests/fast/css/empty-span.html (rev 0) +++ branches/chromium/1025/LayoutTests/fast/css/empty-span.html 2012-02-28 01:19:47 UTC (rev 109047) @@ -0,0 +1,17 @@ +!DOCTYPE html +html + head/head + body +!-- https://bugs.webkit.org/show_bug.cgi?id=76465 +There should be no extra space between any of the lines. -- +divBefore empty span/div +span style=line-height:5.24;/span +divAfter empty span/div +divBefore empty span/div +span style=font-size:100px;/span +divAfter empty span/div +divBefore empty span/div +span style=vertical-align:100px;/span +divAfter empty span/div + /body +/html \ No newline at end of file Copied: branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html (from rev 108111, trunk/LayoutTests/fast/css/non-empty-span.html) (0 => 109047) --- branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html (rev 0) +++ branches/chromium/1025/LayoutTests/fast/css/non-empty-span.html 2012-02-28 01:19:47 UTC (rev 109047) @@ -0,0 +1,17 @@ +!DOCTYPE html +html + head/head + body +!-- https://bugs.webkit.org/show_bug.cgi?id=76465 +There should be 100px space between the 'before' and 'after' lines (disregarding the 'X'). -- +divBefore empty span/div +span style=line-height:100px;/spanX +divAfter empty span/div +divBefore empty span/div +span style=font-size:100px;/spanX +divAfter empty span/div +divBefore empty span/div +span style=vertical-align:100px;/spanX +divAfter empty span/div + /body +/html \ No newline at end of file Copied: branches/chromium/1025/LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png (from rev 108111,
[webkit-changes] [109048] trunk/LayoutTests
Title: [109048] trunk/LayoutTests Revision 109048 Author e...@google.com Date 2012-02-27 17:24:32 -0800 (Mon, 27 Feb 2012) Log Message [chromium] Unreviewed gardening, mark another svg test as flaky crasher https://bugs.webkit.org/show_bug.cgi?id=79707 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109047 => 109048) --- trunk/LayoutTests/ChangeLog 2012-02-28 01:19:47 UTC (rev 109047) +++ trunk/LayoutTests/ChangeLog 2012-02-28 01:24:32 UTC (rev 109048) @@ -1,5 +1,12 @@ 2012-02-27 Adrienne Walker e...@google.com +[chromium] Unreviewed gardening, mark another svg test as flaky crasher +https://bugs.webkit.org/show_bug.cgi?id=79707 + +* platform/chromium/test_expectations.txt: + +2012-02-27 Adrienne Walker e...@google.com + [chromium] Unreviewed gardening, mark more svg tests as flaky crashers https://bugs.webkit.org/show_bug.cgi?id=79707 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109047 => 109048) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-28 01:19:47 UTC (rev 109047) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-28 01:24:32 UTC (rev 109048) @@ -4260,3 +4260,4 @@ BUGWK79707 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = PASS TIMEOUT IMAGE CRASH BUGWK79707 MAC : svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html = TEXT IMAGE IMAGE+TEXT CRASH BUGWK79707 MAC : svg/custom/font-face-not-in-document.svg = PASS CRASH +BUGWK79707 MAC : svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109049] trunk/Tools
Title: [109049] trunk/Tools
Revision 109049
Author wangxian...@chromium.org
Date 2012-02-27 17:30:06 -0800 (Mon, 27 Feb 2012)
Log Message
Undefined variable 'current' when running chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=79696
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._read_prompt):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
Diff
Modified: trunk/Tools/ChangeLog (109048 => 109049)
--- trunk/Tools/ChangeLog 2012-02-28 01:24:32 UTC (rev 109048)
+++ trunk/Tools/ChangeLog 2012-02-28 01:30:06 UTC (rev 109049)
@@ -1,3 +1,13 @@
+2012-02-27 Xianzhu Wang wangxian...@chromium.org
+
+Undefined variable 'current' when running chromium_android.py
+https://bugs.webkit.org/show_bug.cgi?id=79696
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver._read_prompt):
+
2012-02-27 Greg Billock gbill...@google.com
Add more tests for web intents
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (109048 => 109049)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-02-28 01:24:32 UTC (rev 109048)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-02-28 01:30:06 UTC (rev 109049)
@@ -529,4 +529,4 @@
return
if last_char == '$':
raise AssertionError('Adbd is not running as root')
-last_char = current
+last_char = current_char
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109050] trunk/Tools
Title: [109050] trunk/Tools
Revision 109050
Author rn...@webkit.org
Date 2012-02-27 17:32:09 -0800 (Mon, 27 Feb 2012)
Log Message
Add Windows and Linux Chromium perf bots
https://bugs.webkit.org/show_bug.cgi?id=79418
Reviewed by Tony Chang.
Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
the dedicated perf bot slave (uses the same hardware).
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (109049 => 109050)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-02-28 01:30:06 UTC (rev 109049)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-02-28 01:32:09 UTC (rev 109050)
@@ -55,12 +55,15 @@
{ name: google-windows-1, platform: chromium-win },
{ name: google-windows-2, platform: chromium-win },
+{ name: google-windows-perf, platform: chromium-win },
{ name: google-mac-1, platform: chromium-mac },
{ name: google-mac-2, platform: chromium-mac },
{ name: google-mac-3, platform: chromium-mac },
{ name: google-mac-4, platform: chromium-mac },
+{ name: google-mac-perf, platform: chromium-mac },
{ name: google-linux-1, platform: chromium-linux },
{ name: google-linux-2, platform: chromium-linux },
+{ name: google-linux-perf, platform: chromium-linux },
{ name: google-linux-android, platform: chromium-android },
{ name: google-linux-flexbox, platform: chromium-linux },
@@ -232,6 +235,11 @@
slavenames: [google-windows-2]
},
{
+ name: Chromium Win Release (Perf), type: BuildAndPerfTest, builddir: chromium-win-perf-tests,
+ platform: chromium-win, configuration: release, architectures: [i386],
+ slavenames: [google-windows-perf]
+},
+{
name: Chromium Mac Release, type: Build, builddir: chromium-mac-release,
platform: chromium-mac, configuration: release, architectures: [i386],
slavenames: [google-mac-1, google-mac-3]
@@ -239,9 +247,14 @@
{
name: Chromium Mac Release (Tests), type: NewBuildAndTest, builddir: chromium-mac-release-tests,
platform: chromium-mac, configuration: release, architectures: [i386],
- slavenames: [google-mac-2]
+ slavenames: [google-mac-2, google-mac-4]
},
{
+ name: Chromium Mac Release (Perf), type: BuildAndPerfTest, builddir: chromium-mac-perf-tests,
+ platform: chromium-mac, configuration: release, architectures: [i386],
+ slavenames: [google-mac-perf]
+},
+{
name: Chromium Linux Release, type: Build, builddir: chromium-linux-release,
platform: chromium-linux, configuration: release, architectures: [i386],
slavenames: [google-linux-1]
@@ -252,6 +265,11 @@
slavenames: [google-linux-2]
},
{
+ name: Chromium Linux Release (Perf), type: BuildAndPerfTest, builddir: chromium-linux-perf-tests,
+ platform: chromium-linx, configuration: release, architectures: [i386],
+ slavenames: [google-linx-perf]
+},
+{
name: Chromium Linux Release (Grid Layout), type: NewBuildAndTest, builddir: chromium-linux-flexbox,
platform: chromium-linux, configuration: release, architectures: [i386],
slavenames: [google-linux-flexbox]
@@ -262,11 +280,6 @@
slavenames: [google-linux-android]
},
{
- name: Chromium Mac Release (Perf), type: BuildAndPerfTest, builddir: chromium-mac-perf-tests,
- platform: chromium-mac, configuration: release, architectures: [i386],
- slavenames: [google-mac-4]
-},
-{
name: WinCairo Release, type: BuildAndTest, builddir: win-cairo-release,
platform: wincairo, configuration: release, architectures: [i386],
slavenames: [wincairo-1]
@@ -288,10 +301,11 @@
Qt Linux Release, Qt Linux Release minimal, Qt
[webkit-changes] [109052] trunk/Source/WebCore
Title: [109052] trunk/Source/WebCore Revision 109052 Author aba...@webkit.org Date 2012-02-27 17:36:25 -0800 (Mon, 27 Feb 2012) Log Message Repair license blocks for files created during modularization https://bugs.webkit.org/show_bug.cgi?id=79721 Reviewed by Eric Seidel. We failed to copy the license blocks correctly when moving code into these files. This patch restores the correct license blocks. * Modules/geolocation/NavigatorGeolocation.cpp: * Modules/geolocation/NavigatorGeolocation.h: * Modules/mediastream/NavigatorMediaStream.cpp: * Modules/mediastream/NavigatorMediaStream.h: * bindings/js/JSDOMWindowWebAudioCustom.cpp: * bindings/js/JSDOMWindowWebSocketCustom.cpp: * storage/DOMWindowSQLDatabase.cpp: * storage/DOMWindowSQLDatabase.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.h trunk/Source/WebCore/Modules/mediastream/NavigatorMediaStream.cpp trunk/Source/WebCore/Modules/mediastream/NavigatorMediaStream.h trunk/Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp trunk/Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp trunk/Source/WebCore/storage/DOMWindowSQLDatabase.cpp trunk/Source/WebCore/storage/DOMWindowSQLDatabase.h Diff Modified: trunk/Source/WebCore/ChangeLog (109051 => 109052) --- trunk/Source/WebCore/ChangeLog 2012-02-28 01:34:18 UTC (rev 109051) +++ trunk/Source/WebCore/ChangeLog 2012-02-28 01:36:25 UTC (rev 109052) @@ -1,3 +1,22 @@ +2012-02-27 Adam Barth aba...@webkit.org + +Repair license blocks for files created during modularization +https://bugs.webkit.org/show_bug.cgi?id=79721 + +Reviewed by Eric Seidel. + +We failed to copy the license blocks correctly when moving code into +these files. This patch restores the correct license blocks. + +* Modules/geolocation/NavigatorGeolocation.cpp: +* Modules/geolocation/NavigatorGeolocation.h: +* Modules/mediastream/NavigatorMediaStream.cpp: +* Modules/mediastream/NavigatorMediaStream.h: +* bindings/js/JSDOMWindowWebAudioCustom.cpp: +* bindings/js/JSDOMWindowWebSocketCustom.cpp: +* storage/DOMWindowSQLDatabase.cpp: +* storage/DOMWindowSQLDatabase.h: + 2012-02-27 Julien Chaffraix jchaffr...@webkit.org Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject Modified: trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp (109051 => 109052) --- trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp 2012-02-28 01:34:18 UTC (rev 109051) +++ trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp 2012-02-28 01:36:25 UTC (rev 109052) @@ -1,26 +1,23 @@ /* - * Copyright (C) 2012, Google Inc. All rights reserved. + * Copyright (C) 2000 Harri Porten (por...@kde.org) + * Copyright (c) 2000 Daniel Molkentin (molken...@kde.org) + * Copyright (c) 2000 Stefan Schimanski (schi...@kde.org) + * Copyright (C) 2003, 2004, 2005, 2006 Apple Computer, Inc. + * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. * - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in the - *documentation and/or other materials provided with the distribution. + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. * - * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR - * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER - * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
[webkit-changes] [109053] trunk/Tools
Title: [109053] trunk/Tools Revision 109053 Author rn...@webkit.org Date 2012-02-27 17:47:58 -0800 (Mon, 27 Feb 2012) Log Message Touch the master.cfg to force a reconfig. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildAndTestLeaksFactory): (NewBuildAndTestFactory): Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (109052 => 109053) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-02-28 01:36:25 UTC (rev 109052) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-02-28 01:47:58 UTC (rev 109053) @@ -765,9 +765,11 @@ TestClass = RunWebKitLeakTests ExtractTestResultsClass = ExtractTestResultsAndLeaks + class NewBuildAndTestFactory(BuildAndTestFactory): TestClass = NewRunWebKitTests + class TestWebKit2Factory(TestFactory): TestClass = RunWebKit2Tests Modified: trunk/Tools/ChangeLog (109052 => 109053) --- trunk/Tools/ChangeLog 2012-02-28 01:36:25 UTC (rev 109052) +++ trunk/Tools/ChangeLog 2012-02-28 01:47:58 UTC (rev 109053) @@ -1,3 +1,11 @@ +2012-02-27 Ryosuke Niwa rn...@webkit.org + +Touch the master.cfg to force a reconfig. + +* BuildSlaveSupport/build.webkit.org-config/master.cfg: +(BuildAndTestLeaksFactory): +(NewBuildAndTestFactory): + 2012-02-27 Jacky Jiang zhaji...@rim.com [BlackBerry] Upstream BlackBerry API web page related files ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109054] trunk
Title: [109054] trunk
Revision 109054
Author ad...@chromium.org
Date 2012-02-27 17:51:32 -0800 (Mon, 27 Feb 2012)
Log Message
Always notify subtree of removal in ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=79316
Reviewed by Ryosuke Niwa.
Source/WebCore:
In the inDocument case, Node::removedFromDocument is called.
In the out-of-document case, call ContainerNode::removedFromTree to ensure,
e.g., form-associated elements are properly disconnected.
Test: fast/forms/form-associated-element-removal.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
LayoutTests:
* fast/forms/form-associated-element-removal-expected.txt: Added.
* fast/forms/form-associated-element-removal.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
Added Paths
trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt
trunk/LayoutTests/fast/forms/form-associated-element-removal.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109053 => 109054)
--- trunk/LayoutTests/ChangeLog 2012-02-28 01:47:58 UTC (rev 109053)
+++ trunk/LayoutTests/ChangeLog 2012-02-28 01:51:32 UTC (rev 109054)
@@ -1,3 +1,13 @@
+2012-02-27 Adam Klein ad...@chromium.org
+
+Always notify subtree of removal in ContainerNode::removeChildren
+https://bugs.webkit.org/show_bug.cgi?id=79316
+
+Reviewed by Ryosuke Niwa.
+
+* fast/forms/form-associated-element-removal-expected.txt: Added.
+* fast/forms/form-associated-element-removal.html: Added.
+
2012-02-27 Adrienne Walker e...@google.com
[chromium] Unreviewed gardening, mark another svg test as flaky crasher
Added: trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt (0 => 109054)
--- trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/form-associated-element-removal-expected.txt 2012-02-28 01:51:32 UTC (rev 109054)
@@ -0,0 +1,11 @@
+Removing all children of a form should disassociate any form controls in that subtree
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS input.form is null
+PASS form.elements.length is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/form-associated-element-removal.html (0 => 109054)
--- trunk/LayoutTests/fast/forms/form-associated-element-removal.html (rev 0)
+++ trunk/LayoutTests/fast/forms/form-associated-element-removal.html 2012-02-28 01:51:32 UTC (rev 109054)
@@ -0,0 +1,12 @@
+!DOCTYPE html
+script src=""
+script
+description(Removing all children of a form should disassociate any form controls in that subtree);
+var form = document.createElement('form');
+var input = document.createElement('input');
+form.appendChild(input);
+form.innerHTML = '';
+shouldBeNull(input.form);
+shouldBe(form.elements.length, 0);
+/script
+script src=""
Modified: trunk/Source/WebCore/ChangeLog (109053 => 109054)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 01:47:58 UTC (rev 109053)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 01:51:32 UTC (rev 109054)
@@ -1,3 +1,19 @@
+2012-02-27 Adam Klein ad...@chromium.org
+
+Always notify subtree of removal in ContainerNode::removeChildren
+https://bugs.webkit.org/show_bug.cgi?id=79316
+
+Reviewed by Ryosuke Niwa.
+
+In the inDocument case, Node::removedFromDocument is called.
+In the out-of-document case, call ContainerNode::removedFromTree to ensure,
+e.g., form-associated elements are properly disconnected.
+
+Test: fast/forms/form-associated-element-removal.html
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::removeChildren):
+
2012-02-27 Adam Barth aba...@webkit.org
Repair license blocks for files created during modularization
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (109053 => 109054)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-28 01:47:58 UTC (rev 109053)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-28 01:51:32 UTC (rev 109054)
@@ -582,9 +582,8 @@
Node* removedChild = removedChildren[i].get();
if (removedChild-inDocument())
removedChild-removedFromDocument();
-// removeChild() calls removedFromTree(true) if the child was not in the
-// document. There is no explanation for this discrepancy between removeChild()
-// and its optimized version removeChildren().
+else if (removedChild-isContainerNode())
+toContainerNode(removedChild)-removedFromTree(true);
}
dispatchSubtreeModifiedEvent();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109055] trunk
Title: [109055] trunk Revision 109055 Author beid...@apple.com Date 2012-02-27 17:59:09 -0800 (Mon, 27 Feb 2012) Log Message rdar://problem/10924993 and https://bugs.webkit.org/show_bug.cgi?id=79725 a ping doesn't work in WebKit2 Reviewed by Alexey Proskuryakov. Source/WebKit2: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Push the WK2 a ping setting to WebCore::Settings. LayoutTests: * platform/wk2/Skipped: Unskip some tests that now pass. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/LayoutTests/ChangeLog (109054 => 109055) --- trunk/LayoutTests/ChangeLog 2012-02-28 01:51:32 UTC (rev 109054) +++ trunk/LayoutTests/ChangeLog 2012-02-28 01:59:09 UTC (rev 109055) @@ -1,3 +1,12 @@ +2012-02-27 Brady Eidson beid...@apple.com + +rdar://problem/10924993 and https://bugs.webkit.org/show_bug.cgi?id=79725 +a ping doesn't work in WebKit2 + +Reviewed by Alexey Proskuryakov. + +* platform/wk2/Skipped: Unskip some tests that now pass. + 2012-02-27 Adam Klein ad...@chromium.org Always notify subtree of removal in ContainerNode::removeChildren Modified: trunk/LayoutTests/platform/wk2/Skipped (109054 => 109055) --- trunk/LayoutTests/platform/wk2/Skipped 2012-02-28 01:51:32 UTC (rev 109054) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-02-28 01:59:09 UTC (rev 109055) @@ -203,7 +203,6 @@ fast/canvas/webgl/uniform-array-length-overflow.html fast/overflow/horizontal-scroll-after-back.html http/tests/navigation/go-back-to-error-page.html -http/tests/navigation/ping-cookie.html plugins/application-plugin-plugins-disabled.html fast/canvas/webgl/canvas-zero-size.html fast/canvas/webgl/context-lost-restored.html @@ -302,10 +301,7 @@ # LayoutTestController::applicationCacheDiskUsageForOrigin isn't implemented - https://bugs.webkit.org/show_bug.cgi?id=57127 http/tests/appcache/origin-usage.html http/tests/canvas/webgl/origin-clean-conformance.html -http/tests/inspector/network/ping.html http/tests/navigation/ping-cross-origin-from-https.html -http/tests/navigation/ping-cross-origin.html -http/tests/navigation/ping-same-origin.html http/tests/security/webgl-remote-read-remote-image-allowed.html http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html Modified: trunk/Source/WebKit2/ChangeLog (109054 => 109055) --- trunk/Source/WebKit2/ChangeLog 2012-02-28 01:51:32 UTC (rev 109054) +++ trunk/Source/WebKit2/ChangeLog 2012-02-28 01:59:09 UTC (rev 109055) @@ -1,3 +1,13 @@ +2012-02-27 Brady Eidson beid...@apple.com + +rdar://problem/10924993 and https://bugs.webkit.org/show_bug.cgi?id=79725 +a ping doesn't work in WebKit2 + +Reviewed by Alexey Proskuryakov. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::updatePreferences): Push the WK2 a ping setting to WebCore::Settings. + 2012-02-27 Enrica Casucci enr...@apple.com WebKit2: implement platform strategy to access Pasteboard in the UI process. Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (109054 => 109055) --- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-02-28 01:51:32 UTC (rev 109054) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-02-28 01:59:09 UTC (rev 109055) @@ -1893,6 +1893,7 @@ settings-setMediaPlaybackRequiresUserGesture(store.getBoolValueForKey(WebPreferencesKey::mediaPlaybackRequiresUserGestureKey())); settings-setMediaPlaybackAllowsInline(store.getBoolValueForKey(WebPreferencesKey::mediaPlaybackAllowsInlineKey())); settings-setMockScrollbarsEnabled(store.getBoolValueForKey(WebPreferencesKey::mockScrollbarsEnabledKey())); +settings-setHyperlinkAuditingEnabled(store.getBoolValueForKey(WebPreferencesKey::hyperlinkAuditingEnabledKey())); // rdar://problem/10697417: It is necessary to force compositing when accelerate drawing // is enabled on Mac so that scrollbars are always in their own layers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109056] trunk/Tools
Title: [109056] trunk/Tools
Revision 109056
Author dpra...@chromium.org
Date 2012-02-27 18:05:13 -0800 (Mon, 27 Feb 2012)
Log Message
nrwt: log multiline stderr/crash output properly
https://bugs.webkit.org/show_bug.cgi?id=79722
Reviewed by Adam Barth.
This cleans up some nits in the log output to make things
slightly easier to read (every line gets timestamped, etc.).
Also tweaks the log message for pixel hash mismatches.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
(SingleTestRunner._compare_image):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
Diff
Modified: trunk/Tools/ChangeLog (109055 => 109056)
--- trunk/Tools/ChangeLog 2012-02-28 01:59:09 UTC (rev 109055)
+++ trunk/Tools/ChangeLog 2012-02-28 02:05:13 UTC (rev 109056)
@@ -1,3 +1,19 @@
+2012-02-27 Dirk Pranke dpra...@chromium.org
+
+nrwt: log multiline stderr/crash output properly
+https://bugs.webkit.org/show_bug.cgi?id=79722
+
+Reviewed by Adam Barth.
+
+This cleans up some nits in the log output to make things
+slightly easier to read (every line gets timestamped, etc.).
+
+Also tweaks the log message for pixel hash mismatches.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+(SingleTestRunner._handle_error):
+(SingleTestRunner._compare_image):
+
2012-02-27 Ryosuke Niwa rn...@webkit.org
Touch the master.cfg to force a reconfig.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (109055 => 109056)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-02-28 01:59:09 UTC (rev 109055)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-02-28 02:05:13 UTC (rev 109056)
@@ -198,11 +198,14 @@
if driver_output.crash:
failures.append(test_failures.FailureCrash(bool(reference_filename)))
-_log.debug(%s Stacktrace for %s:\n%s % (self._worker_name, testname,
- driver_output.error))
+if driver_output.error:
+_log.debug(%s %s crashed, stack trace: % (self._worker_name, testname))
+else:
+_log.debug(%s %s crashed, no stack trace % (self._worker_name, testname))
elif driver_output.error:
-_log.debug(%s %s output stderr lines:\n%s % (self._worker_name, testname,
- driver_output.error))
+_log.debug(%s %s output stderr lines: % (self._worker_name, testname))
+for line in driver_output.error.splitlines():
+_log.debug( %s % line)
return failures
def _compare_output(self, driver_output, expected_driver_output):
@@ -266,7 +269,7 @@
failures.append(test_failures.FailureImageHashMismatch(diff_result[1]))
else:
# See https://bugs.webkit.org/show_bug.cgi?id=69444 for why this isn't a full failure.
-_log.warning('%s - pixel hash failed (but pixel test still passes)' % self._test_name)
+_log.warning(' %s - pixel hash failed (but pixel test still passes)' % self._test_name)
return failures
def _run_reftest(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109057] trunk
Title: [109057] trunk Revision 109057 Author rn...@webkit.org Date 2012-02-27 18:14:37 -0800 (Mon, 27 Feb 2012) Log Message Extract the logic to merge tests from MergeTestsHandler and add unit tests https://bugs.webkit.org/show_bug.cgi?id=79602 Reviewed by Hajime Morita. Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler, and moved MergeTestsHandler into admin_handlers.py where it belongs. Added new backend model-manipulator to execute tasks to merge tests. Also revive the inadvertently removed manual submission form on the admin page. * Websites/webkit-perf.appspot.com/admin_handlers.py: (AdminDashboardHandler.get_tests): (MergeTestsHandler): (MergeTestsHandler.post): * Websites/webkit-perf.appspot.com/app.yaml: * Websites/webkit-perf.appspot.com/backends.yaml: Added. * Websites/webkit-perf.appspot.com/css/admin.css: * Websites/webkit-perf.appspot.com/js/admin.js: * Websites/webkit-perf.appspot.com/main.py: * Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed. * Websites/webkit-perf.appspot.com/models.py: (Test): (Test.merge): (TestResult.replace_to_change_test_name): * Websites/webkit-perf.appspot.com/models_unittest.py: (DataStoreTestsBase.assertOnlyInstance): (DataStoreTestsBase): (DataStoreTestsBase.assertOnlyInstances): (DataStoreTestsBase.assertEqualUnorderedModelList): (DataStoreTestsBase.assertEqualUnorderedList): (_create_build): (TestModelTests.test_merge): (TestResultTests): (TestResultTests.test_get_or_insert_value): (TestResultTests.test_get_or_insert_stat_value): (TestResultTests.test_replace_to_change_test_name): (TestResultTests.test_replace_to_change_test_name_with_stat_value): (TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result): Modified Paths trunk/ChangeLog trunk/Websites/webkit-perf.appspot.com/admin_handlers.py trunk/Websites/webkit-perf.appspot.com/app.yaml trunk/Websites/webkit-perf.appspot.com/css/admin.css trunk/Websites/webkit-perf.appspot.com/js/admin.js trunk/Websites/webkit-perf.appspot.com/main.py trunk/Websites/webkit-perf.appspot.com/models.py trunk/Websites/webkit-perf.appspot.com/models_unittest.py Added Paths trunk/Websites/webkit-perf.appspot.com/backends.yaml Removed Paths trunk/Websites/webkit-perf.appspot.com/merge_tests_handler.py Diff Modified: trunk/ChangeLog (109056 => 109057) --- trunk/ChangeLog 2012-02-28 02:05:13 UTC (rev 109056) +++ trunk/ChangeLog 2012-02-28 02:14:37 UTC (rev 109057) @@ -1,3 +1,46 @@ +2012-02-27 Ryosuke Niwa rn...@webkit.org + +Extract the logic to merge tests from MergeTestsHandler and add unit tests +https://bugs.webkit.org/show_bug.cgi?id=79602 + +Reviewed by Hajime Morita. + +Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler, +and moved MergeTestsHandler into admin_handlers.py where it belongs. + +Added new backend model-manipulator to execute tasks to merge tests. + +Also revive the inadvertently removed manual submission form on the admin page. + +* Websites/webkit-perf.appspot.com/admin_handlers.py: +(AdminDashboardHandler.get_tests): +(MergeTestsHandler): +(MergeTestsHandler.post): +* Websites/webkit-perf.appspot.com/app.yaml: +* Websites/webkit-perf.appspot.com/backends.yaml: Added. +* Websites/webkit-perf.appspot.com/css/admin.css: +* Websites/webkit-perf.appspot.com/js/admin.js: +* Websites/webkit-perf.appspot.com/main.py: +* Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed. +* Websites/webkit-perf.appspot.com/models.py: +(Test): +(Test.merge): +(TestResult.replace_to_change_test_name): +* Websites/webkit-perf.appspot.com/models_unittest.py: +(DataStoreTestsBase.assertOnlyInstance): +(DataStoreTestsBase): +(DataStoreTestsBase.assertOnlyInstances): +(DataStoreTestsBase.assertEqualUnorderedModelList): +(DataStoreTestsBase.assertEqualUnorderedList): +(_create_build): +(TestModelTests.test_merge): +(TestResultTests): +(TestResultTests.test_get_or_insert_value): +(TestResultTests.test_get_or_insert_stat_value): +(TestResultTests.test_replace_to_change_test_name): +(TestResultTests.test_replace_to_change_test_name_with_stat_value): +(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result): + 2012-02-27 ChangSeok Oh shivami...@gmail.com [EFL] Support mutation observers Modified: trunk/Websites/webkit-perf.appspot.com/admin_handlers.py (109056 => 109057) --- trunk/Websites/webkit-perf.appspot.com/admin_handlers.py 2012-02-28 02:05:13 UTC (rev 109056) +++ trunk/Websites/webkit-perf.appspot.com/admin_handlers.py 2012-02-28 02:14:37 UTC (rev 109057) @@ -30,10 +30,14 @@ import webapp2 import json +from google.appengine.api import taskqueue from
[webkit-changes] [109058] trunk
Title: [109058] trunk
Revision 109058
Author ad...@chromium.org
Date 2012-02-27 18:34:20 -0800 (Mon, 27 Feb 2012)
Log Message
[MutationObservers] Clear pending mutation records on disconnect()
https://bugs.webkit.org/show_bug.cgi?id=78639
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/mutation/disconnect-cancel-pending.html
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::disconnect): Clear pending records.
(WebCore::WebKitMutationObserver::deliver): Avoid calling the callback if no records are pending delivery.
LayoutTests:
* fast/mutation/disconnect-cancel-pending-expected.txt: Added.
* fast/mutation/disconnect-cancel-pending.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp
Added Paths
trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt
trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109057 => 109058)
--- trunk/LayoutTests/ChangeLog 2012-02-28 02:14:37 UTC (rev 109057)
+++ trunk/LayoutTests/ChangeLog 2012-02-28 02:34:20 UTC (rev 109058)
@@ -1,3 +1,13 @@
+2012-02-27 Adam Klein ad...@chromium.org
+
+[MutationObservers] Clear pending mutation records on disconnect()
+https://bugs.webkit.org/show_bug.cgi?id=78639
+
+Reviewed by Ojan Vafai.
+
+* fast/mutation/disconnect-cancel-pending-expected.txt: Added.
+* fast/mutation/disconnect-cancel-pending.html: Added.
+
2012-02-27 Brady Eidson beid...@apple.com
rdar://problem/10924993 and https://bugs.webkit.org/show_bug.cgi?id=79725
Added: trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt (0 => 109058)
--- trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/mutation/disconnect-cancel-pending-expected.txt 2012-02-28 02:34:20 UTC (rev 109058)
@@ -0,0 +1,14 @@
+Test that WebKitMutationObserver.disconnect cancels pending delivery
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Disconnecting should cancel any pending delivery...
+PASS mutations is null
+...and re-observing should not see any of the previously-generated records.
+PASS mutations.length is 1
+PASS mutations[0].attributeName is bar
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html (0 => 109058)
--- trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html (rev 0)
+++ trunk/LayoutTests/fast/mutation/disconnect-cancel-pending.html 2012-02-28 02:34:20 UTC (rev 109058)
@@ -0,0 +1,45 @@
+!DOCTYPE html
+script src=""
+script
+description('Test that WebKitMutationObserver.disconnect cancels pending delivery');
+
+window.jsTestIsAsync = true;
+var mutations;
+var observer;
+
+function start() {
+mutations = null;
+div = document.createElement('div');
+
+observer = new WebKitMutationObserver(function(m) {
+mutations = m;
+});
+
+observer.observe(div, { attributes: true });
+div.setAttribute('foo', 'bar');
+observer.disconnect();
+setTimeout(next, 0);
+}
+
+function next() {
+debug('Disconnecting should cancel any pending delivery...');
+shouldBeNull('mutations');
+observer.observe(div, { attributes: true });
+div.setAttribute('bar', 'baz');
+setTimeout(finish, 0);
+}
+
+function finish() {
+debug('...and re-observing should not see any of the previously-generated records.');
+shouldBe('mutations.length', '1');
+shouldBe('mutations[0].attributeName', 'bar');
+finishJSTest();
+}
+
+if (!window.WebKitMutationObserver)
+testFailed('This test requires ENABLE(MUTATION_OBSERVERS)');
+else
+start();
+
+/script
+script src=""
Modified: trunk/Source/WebCore/ChangeLog (109057 => 109058)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 02:14:37 UTC (rev 109057)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 02:34:20 UTC (rev 109058)
@@ -1,5 +1,18 @@
2012-02-27 Adam Klein ad...@chromium.org
+[MutationObservers] Clear pending mutation records on disconnect()
+https://bugs.webkit.org/show_bug.cgi?id=78639
+
+Reviewed by Ojan Vafai.
+
+Test: fast/mutation/disconnect-cancel-pending.html
+
+* dom/WebKitMutationObserver.cpp:
+(WebCore::WebKitMutationObserver::disconnect): Clear pending records.
+(WebCore::WebKitMutationObserver::deliver): Avoid calling the callback if no records are pending delivery.
+
+2012-02-27 Adam Klein ad...@chromium.org
+
Always notify subtree of removal in ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=79316
Modified: trunk/Source/WebCore/dom/WebKitMutationObserver.cpp (109057 => 109058)
--- trunk/Source/WebCore/dom/WebKitMutationObserver.cpp 2012-02-28 02:14:37 UTC (rev 109057)
+++
[webkit-changes] [109059] trunk/Source/JavaScriptCore
Title: [109059] trunk/Source/_javascript_Core
Revision 109059
Author oli...@apple.com
Date 2012-02-27 18:35:29 -0800 (Mon, 27 Feb 2012)
Log Message
sputnik/Unicode/Unicode_500/S7.2_A1.6_T1.html crashes in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=79728
Reviewed by Gavin Barraclough.
When initialising a chained get instruction we may end up in a state where
the instruction stream says we have a scopechain, but it has not yet been set
(eg. if allocating the StructureChain itself is what leads to the GC). We could
re-order the allocation, but it occurs in a couple of places, so it seems less
fragile simply to null check the scopechain slot before we actually visit the slot.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitStructures):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (109058 => 109059)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-28 02:34:20 UTC (rev 109058)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-28 02:35:29 UTC (rev 109059)
@@ -1,3 +1,19 @@
+2012-02-27 Oliver Hunt oli...@apple.com
+
+sputnik/Unicode/Unicode_500/S7.2_A1.6_T1.html crashes in the interpreter
+https://bugs.webkit.org/show_bug.cgi?id=79728
+
+Reviewed by Gavin Barraclough.
+
+When initialising a chained get instruction we may end up in a state where
+the instruction stream says we have a scopechain, but it has not yet been set
+(eg. if allocating the StructureChain itself is what leads to the GC). We could
+re-order the allocation, but it occurs in a couple of places, so it seems less
+fragile simply to null check the scopechain slot before we actually visit the slot.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::visitStructures):
+
2012-02-27 Filip Pizlo fpi...@apple.com
Old JIT's style of JSVALUE64 strict equality is subtly wrong
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (109058 => 109059)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-02-28 02:34:20 UTC (rev 109058)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-02-28 02:35:29 UTC (rev 109059)
@@ -1581,13 +1581,15 @@
}
if (vPC[0].u.opcode == interpreter-getOpcode(op_get_by_id_chain) || vPC[0].u.opcode == interpreter-getOpcode(op_get_by_id_getter_chain) || vPC[0].u.opcode == interpreter-getOpcode(op_get_by_id_custom_chain)) {
visitor.append(vPC[4].u.structure);
-visitor.append(vPC[5].u.structureChain);
+if (vPC[5].u.structureChain)
+visitor.append(vPC[5].u.structureChain);
return;
}
if (vPC[0].u.opcode == interpreter-getOpcode(op_put_by_id_transition)) {
visitor.append(vPC[4].u.structure);
visitor.append(vPC[5].u.structure);
-visitor.append(vPC[6].u.structureChain);
+if (vPC[6].u.structureChain)
+visitor.append(vPC[6].u.structureChain);
return;
}
if (vPC[0].u.opcode == interpreter-getOpcode(op_put_by_id) vPC[4].u.structure) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109060] trunk
Title: [109060] trunk Revision 109060 Author shawnsi...@chromium.org Date 2012-02-27 18:36:59 -0800 (Mon, 27 Feb 2012) Log Message RenderLayer ClipRect not accounting for transforms https://bugs.webkit.org/show_bug.cgi?id=76486 Reviewed by Simon Fraser. Source/WebCore: Test: compositing/layer-creation/overlap-transformed-and-clipped.html This patch changes calculateClipRects() so that the clipRect offset is allowed to be converted across layers with transforms. This is necessary because the RenderLayerCompositor needs clipRects in document space, rather than with respect to some local clipping layer. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): * rendering/RenderObject.cpp: (WebCore::RenderObject::localToContainerPoint): (WebCore): * rendering/RenderObject.h: (RenderObject): LayoutTests: * compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added. * compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added. * compositing/layer-creation/overlap-transformed-and-clipped.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h Added Paths trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped.html Diff Modified: trunk/LayoutTests/ChangeLog (109059 => 109060) --- trunk/LayoutTests/ChangeLog 2012-02-28 02:35:29 UTC (rev 109059) +++ trunk/LayoutTests/ChangeLog 2012-02-28 02:36:59 UTC (rev 109060) @@ -1,3 +1,14 @@ +2012-02-27 Shawn Singh shawnsi...@chromium.org + +RenderLayer ClipRect not accounting for transforms +https://bugs.webkit.org/show_bug.cgi?id=76486 + +Reviewed by Simon Fraser. + +* compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added. +* compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added. +* compositing/layer-creation/overlap-transformed-and-clipped.html: Added. + 2012-02-27 Adam Klein ad...@chromium.org [MutationObservers] Clear pending mutation records on disconnect() Added: trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png (0 => 109060) --- trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png (rev 0) +++ trunk/LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.png 2012-02-28 02:36:59 UTC (rev 109060) @@ -0,0 +1,4 @@ +\x89PNG + + +IHDR X \x9Av\x82p )tEXtchecksum 38db6661a8f7b1efa64f4cb51638e167Krjk \x81IDATx\x9C\xED\xD91\x84@ A\x96\x8F#^n\xD2 /\xEA\xA2\xEA\x938hy\xCD\xCC \xBCκ\xD7\xEE \xFC\x98\xCB \xFC\xE3\xDC= \xF8 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90Y33\xBBG \xDF\xE0 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90
[webkit-changes] [109062] trunk
Title: [109062] trunk
Revision 109062
Author commit-qu...@webkit.org
Date 2012-02-27 19:09:41 -0800 (Mon, 27 Feb 2012)
Log Message
Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
incorrect source and destination rect used.
https://bugs.webkit.org/show_bug.cgi?id=79566
Source/WebCore:
Pass dstRect and bufferSrcRect to
CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination
and source rect, respectively.
Patch by Huang Dongsung luxte...@company100.net on 2012-02-27
Reviewed by Daniel Bates.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
LayoutTests:
I amended canvas-composite-canvas to cover this bug, and I also amended
canvas-composite-image because I changed
LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
However, the change of canvas-composite-image is reasonable because
drawImage(HTMLImageElement) will be able to have a similar bug.
Patch by Huang Dongsung luxte...@company100.net on 2012-02-27
Reviewed by Daniel Bates.
* fast/canvas/canvas-composite-canvas.html:
* fast/canvas/canvas-composite-image.html:
* fast/canvas/resources/canvas-composite-image-common.js:
(setupContext):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html
trunk/LayoutTests/fast/canvas/canvas-composite-image.html
trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (109061 => 109062)
--- trunk/LayoutTests/ChangeLog 2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/ChangeLog 2012-02-28 03:09:41 UTC (rev 109062)
@@ -1,3 +1,22 @@
+2012-02-27 Huang Dongsung luxte...@company100.net
+
+Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
+incorrect source and destination rect used.
+https://bugs.webkit.org/show_bug.cgi?id=79566
+
+I amended canvas-composite-canvas to cover this bug, and I also amended
+canvas-composite-image because I changed
+LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
+However, the change of canvas-composite-image is reasonable because
+drawImage(HTMLImageElement) will be able to have a similar bug.
+
+Reviewed by Daniel Bates.
+
+* fast/canvas/canvas-composite-canvas.html:
+* fast/canvas/canvas-composite-image.html:
+* fast/canvas/resources/canvas-composite-image-common.js:
+(setupContext):
+
2012-02-27 Shawn Singh shawnsi...@chromium.org
RenderLayer ClipRect not accounting for transforms
Modified: trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html (109061 => 109062)
--- trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html 2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/fast/canvas/canvas-composite-canvas.html 2012-02-28 03:09:41 UTC (rev 109062)
@@ -9,7 +9,7 @@
if (alpha)
context.globalAlpha = 0.5;
var sourceElement = document.getElementById('source-canvas');
-context.drawImage(sourceElement, 0, 0);
+context.drawImage(sourceElement, 10, 10);
}
function setupTest() {
Modified: trunk/LayoutTests/fast/canvas/canvas-composite-image.html (109061 => 109062)
--- trunk/LayoutTests/fast/canvas/canvas-composite-image.html 2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/fast/canvas/canvas-composite-image.html 2012-02-28 03:09:41 UTC (rev 109062)
@@ -9,7 +9,7 @@
if (alpha)
context.globalAlpha = 0.5;
var imageElement = document.getElementById('image');
-context.drawImage(imageElement, 0, 0);
+context.drawImage(imageElement, 10, 10);
}
function setupTest() {}
Modified: trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js (109061 => 109062)
--- trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js 2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/LayoutTests/fast/canvas/resources/canvas-composite-image-common.js 2012-02-28 03:09:41 UTC (rev 109062)
@@ -284,6 +284,7 @@
context.translate(40, -10);
context.scale(0.4, 0.6);
context.rotate(Math.PI / 8);
+ context.translate(-10, -10);
}
function addOutput(element, style, innerHTML) {
Modified: trunk/Source/WebCore/ChangeLog (109061 => 109062)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 03:01:11 UTC (rev 109061)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 03:09:41 UTC (rev 109062)
@@ -1,3 +1,18 @@
+2012-02-27 Huang Dongsung luxte...@company100.net
+
+Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
+incorrect source and destination rect used.
+https://bugs.webkit.org/show_bug.cgi?id=79566
+
+Pass dstRect and bufferSrcRect to
+CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for
[webkit-changes] [109064] trunk/Source
Title: [109064] trunk/Source
Revision 109064
Author k...@chromium.org
Date 2012-02-27 19:31:02 -0800 (Mon, 27 Feb 2012)
Log Message
[chromium] Plumb extensionGroup into didCreateScriptContext().
https://bugs.webkit.org/show_bug.cgi?id=79072
Reviewed by Darin Fisher.
Source/WebCore:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
Source/WebKit/chromium:
* public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109063 => 109064)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 03:31:02 UTC (rev 109064)
@@ -1,3 +1,19 @@
+2012-02-27 James Kozianski k...@chromium.org
+
+[chromium] Plumb extensionGroup into didCreateScriptContext().
+https://bugs.webkit.org/show_bug.cgi?id=79072
+
+Reviewed by Darin Fisher.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::initContextIfNeeded):
+* bindings/v8/V8IsolatedContext.cpp:
+(WebCore::V8IsolatedContext::V8IsolatedContext):
+* loader/EmptyClients.h:
+(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
+* loader/FrameLoaderClient.h:
+(FrameLoaderClient):
+
2012-02-27 Huang Dongsung luxte...@company100.net
Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (109063 => 109064)
--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-02-28 03:31:02 UTC (rev 109064)
@@ -339,7 +339,7 @@
setSecurityToken();
-m_frame-loader()-client()-didCreateScriptContext(m_context, 0);
+m_frame-loader()-client()-didCreateScriptContext(m_context, 0, 0);
// FIXME: This is wrong. We should actually do this for the proper world once
// we do isolated worlds the WebCore way.
Modified: trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp (109063 => 109064)
--- trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp 2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp 2012-02-28 03:31:02 UTC (rev 109064)
@@ -75,7 +75,7 @@
//changes.
m_context-get()-UseDefaultSecurityToken();
-m_frame-loader()-client()-didCreateScriptContext(context(), m_world-id());
+m_frame-loader()-client()-didCreateScriptContext(context(), extensionGroup, m_world-id());
}
void V8IsolatedContext::destroy()
Modified: trunk/Source/WebCore/loader/EmptyClients.h (109063 => 109064)
--- trunk/Source/WebCore/loader/EmptyClients.h 2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2012-02-28 03:31:02 UTC (rev 109064)
@@ -394,7 +394,7 @@
virtual void registerForIconNotification(bool) { }
#if USE(V8)
-virtual void didCreateScriptContext(v8::Handlev8::Context, int worldId) { }
+virtual void didCreateScriptContext(v8::Handlev8::Context, int extensionGroup, int worldId) { }
virtual void willReleaseScriptContext(v8::Handlev8::Context, int worldId) { }
virtual bool allowScriptExtension(const String extensionName, int extensionGroup, int worldId) { return false; }
#endif
Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (109063 => 109064)
--- trunk/Source/WebCore/loader/FrameLoaderClient.h 2012-02-28 03:29:26 UTC (rev 109063)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h 2012-02-28 03:31:02 UTC (rev 109064)
@@ -280,7 +280,7 @@
virtual void didPerformFirstNavigation() const = 0; // Navigation here means a transition from one page to another that ends up in the back/forward list.
#if USE(V8)
-virtual void didCreateScriptContext(v8::Handlev8::Context, int worldId) = 0;
+virtual void didCreateScriptContext(v8::Handlev8::Context, int extensionGroup, int worldId) = 0;
virtual void willReleaseScriptContext(v8::Handlev8::Context, int worldId) = 0;
virtual bool allowScriptExtension(const String extensionName, int
[webkit-changes] [109066] trunk/Tools
Title: [109066] trunk/Tools
Revision 109066
Author commit-qu...@webkit.org
Date 2012-02-27 19:52:02 -0800 (Mon, 27 Feb 2012)
Log Message
[chromium] Remove media tests from ChromiumGpu configurations
https://bugs.webkit.org/show_bug.cgi?id=79720
Patch by James Robinson jam...@chromium.org on 2012-02-27
Reviewed by Adam Barth.
We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
composited playback path via tests in the compositing/ directory.
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(_default_tests_paths):
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (109065 => 109066)
--- trunk/Tools/ChangeLog 2012-02-28 03:44:33 UTC (rev 109065)
+++ trunk/Tools/ChangeLog 2012-02-28 03:52:02 UTC (rev 109066)
@@ -1,3 +1,19 @@
+2012-02-27 James Robinson jam...@chromium.org
+
+[chromium] Remove media tests from ChromiumGpu configurations
+https://bugs.webkit.org/show_bug.cgi?id=79720
+
+Reviewed by Adam Barth.
+
+We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
+composited playback path via tests in the compositing/ directory.
+
+* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+(_default_tests_paths):
+* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+(ChromiumGpuTest.test_default_tests_paths):
+(ChromiumGpuTest.test_test_files):
+
2012-02-27 Dirk Pranke dpra...@chromium.org
nrwt: log multiline stderr/crash output properly
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (109065 => 109066)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2012-02-28 03:44:33 UTC (rev 109065)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2012-02-28 03:52:02 UTC (rev 109066)
@@ -50,27 +50,9 @@
def _default_tests_paths(port):
-paths = []
-if port.name() != 'chromium-gpu-mac-leopard':
-# Only run tests requiring accelerated compositing on platforms that
-# support it.
-# FIXME: we should add the above paths here as well but let's test
-# the waters with media first.
-paths += ['media']
+return ['fast/canvas', 'canvas/philip']
-paths += ['fast/canvas', 'canvas/philip']
-if not paths:
-# FIXME: This is a hack until we can turn off the webkit_gpu
-# tests on the bots. If paths is empty, port.tests()
-# finds *everything*. However, we have to return something,
-# or NRWT thinks there's something wrong. So, we return a single
-# short directory. See https://bugs.webkit.org/show_bug.cgi?id=72498.
-paths = ['fast/html']
-
-return paths
-
-
class ChromiumGpuAndroidPort(chromium_android.ChromiumAndroidPort):
port_name = 'chromium-gpu-android'
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py (109065 => 109066)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py 2012-02-28 03:44:33 UTC (rev 109065)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py 2012-02-28 03:52:02 UTC (rev 109066)
@@ -109,8 +109,7 @@
def test_paths(port_name):
return chromium_gpu._default_tests_paths(PortFactory(MockSystemHost()).get(port_name))
-self.assertEqual(test_paths('chromium-gpu-linux'), ['media', 'fast/canvas', 'canvas/philip'])
-self.assertEqual(test_paths('chromium-gpu-mac-leopard'), ['fast/canvas', 'canvas/philip'])
+self.assertEqual(test_paths('chromium-gpu-linux'), ['fast/canvas', 'canvas/philip'])
def test_test_files(self):
host = MockSystemHost()
@@ -118,7 +117,6 @@
'/mock-checkout/LayoutTests/canvas/philip/test.html': '',
'/mock-checkout/LayoutTests/fast/canvas/test.html': '',
'/mock-checkout/LayoutTests/fast/html/test.html': '',
-'/mock-checkout/LayoutTests/media/test.html': '',
'/mock-checkout/LayoutTests/foo/bar.html': '',
}
host.filesystem = MockFileSystem(files)
@@ -126,8 +124,7 @@
def test_paths(port_name):
return PortFactory(host).get(port_name).tests([])
-self.assertEqual(test_paths('chromium-gpu-linux'), set(['canvas/philip/test.html', 'fast/canvas/test.html', 'media/test.html']))
-self.assertEqual(test_paths('chromium-gpu-mac-leopard'), set(['canvas/philip/test.html', 'fast/canvas/test.html']))
+self.assertEqual(test_paths('chromium-gpu-linux'), set(['canvas/philip/test.html', 'fast/canvas/test.html']))
if __name__ ==
[webkit-changes] [109067] trunk/Source/WebCore
Title: [109067] trunk/Source/WebCore
Revision 109067
Author commit-qu...@webkit.org
Date 2012-02-27 20:17:32 -0800 (Mon, 27 Feb 2012)
Log Message
[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=79622
For ease of maintainability, this patch reorders attributes and methods declaration
matching with specification.
Patch by Yoshifumi Inoue yo...@chromium.org on 2012-02-27
Reviewed by Adam Barth.
No new tests. No behavior change.
* html/HTMLInputElement.idl: Reorder and remove obsolete comments.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (109066 => 109067)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 03:52:02 UTC (rev 109066)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 04:17:32 UTC (rev 109067)
@@ -1,3 +1,17 @@
+2012-02-27 Yoshifumi Inoue yo...@chromium.org
+
+[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
+https://bugs.webkit.org/show_bug.cgi?id=79622
+
+For ease of maintainability, this patch reorders attributes and methods declaration
+matching with specification.
+
+Reviewed by Adam Barth.
+
+No new tests. No behavior change.
+
+* html/HTMLInputElement.idl: Reorder and remove obsolete comments.
+
2012-02-27 Luke Macpherson macpher...@chromium.org
Sort CSSStyleSelector property handler constructors by CSS property name.
Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (109066 => 109067)
--- trunk/Source/WebCore/html/HTMLInputElement.idl 2012-02-28 03:52:02 UTC (rev 109066)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl 2012-02-28 04:17:32 UTC (rev 109067)
@@ -21,36 +21,33 @@
module html {
interface HTMLInputElement : HTMLElement {
-attribute [TreatNullAs=NullString] DOMString defaultValue;
+attribute [Reflect] DOMString accept;
+attribute [Reflect] DOMString alt;
+attribute [Reflect] DOMString autocomplete;
+attribute [Reflect] boolean autofocus;
attribute [Reflect=checked] boolean defaultChecked;
+attribute boolean checked;
attribute [Reflect] DOMString dirName;
+attribute [Reflect] boolean disabled;
readonly attribute HTMLFormElement form;
+readonly attribute FileList files;
attribute [Reflect, URL] DOMString formAction;
attribute [TreatNullAs=NullString] DOMString formEnctype;
attribute [TreatNullAs=NullString] DOMString formMethod;
attribute [Reflect] boolean formNoValidate;
attribute [Reflect] DOMString formTarget;
-readonly attribute ValidityState validity;
-attribute [Reflect] DOMString accept;
-attribute [Reflect] DOMString align;
-attribute [Reflect] DOMString alt;
-attribute boolean checked;
-attribute [Reflect] boolean disabled;
-attribute [Reflect] boolean autofocus;
-attribute [Reflect] DOMString autocomplete;
+attribute boolean indeterminate;
readonly attribute [Conditional=DATALIST] HTMLElement list;
attribute [Reflect] DOMString max;
attribute long maxLength setter raises(DOMException);
attribute [Reflect] DOMString min;
attribute [Reflect] boolean multiple;
-attribute [Conditional=DIRECTORY_UPLOAD, Reflect] boolean webkitdirectory;
attribute [Reflect] DOMString name;
attribute [Reflect] DOMString pattern;
attribute [Reflect] DOMString placeholder;
attribute [Reflect] boolean readOnly;
attribute [Reflect] boolean required;
#if defined(LANGUAGE_OBJECTIVE_C) LANGUAGE_OBJECTIVE_C
-attribute [Reflect] DOMString accessKey;
attribute [ObjCImplementedAsUnsignedLong] DOMString size; // DOM level 2 changed this to a long, but ObjC API is a string
#else
attribute unsigned long size; // Changed string - long - unsigned long
@@ -58,39 +55,28 @@
attribute [Reflect, URL] DOMString src;
attribute [Reflect] DOMString step;
attribute [TreatNullAs=NullString] DOMString type; // readonly dropped as part of DOM level 2
-attribute [Reflect] DOMString useMap;
+attribute [TreatNullAs=NullString] DOMString defaultValue;
attribute [TreatNullAs=NullString] DOMString value;
#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
attribute Date valueAsDate setter raises(DOMException);
#endif
attribute double valueAsNumber setter raises(DOMException);
-readonly attribute [Conditional=DATALIST] HTMLOptionElement selectedOption;
-attribute [Reflect] boolean incremental;
void stepUp(in [Optional] long n) raises(DOMException);
void stepDown(in [Optional] long n) raises(DOMException);
readonly attribute boolean willValidate;
+readonly attribute
[webkit-changes] [109068] trunk/Source/WebCore
Title: [109068] trunk/Source/WebCore
Revision 109068
Author aba...@webkit.org
Date 2012-02-27 20:41:18 -0800 (Mon, 27 Feb 2012)
Log Message
EventFactory.in should be named EventNames.in
https://bugs.webkit.org/show_bug.cgi?id=79727
Reviewed by Kentaro Hara.
Originally EventFactory.in was just used to generate EventFactory.cpp,
but now we're able to generate a bunch of other Event-related code from
this in file.
In writing some documentation about how to use these mechanisms, the
name EventFactory.in didn't seem like the right name. This patch
renames EventFactory.in to EventNames.in, which more accurately
describes the role of this file (and matches the naming convention of
HTMLTagNames.in).
* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
(main):
* WebCore.xcodeproj/project.pbxproj:
* dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
* dom/EventFactory.in: Removed.
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gyp/scripts/action_makenames.py
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebCore/dom/EventNames.in
Removed Paths
trunk/Source/WebCore/dom/EventFactory.in
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (109067 => 109068)
--- trunk/Source/WebCore/CMakeLists.txt 2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/CMakeLists.txt 2012-02-28 04:41:18 UTC (rev 109068)
@@ -2448,7 +2448,7 @@
LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/HTMLNames.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/HTMLElementFactory.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/JSHTMLElementWrapperFactory.cpp)
-GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventFactory.in EventFactory.cpp)
+GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventNames.in EventFactory.cpp)
LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/EventFactory.cpp)
Modified: trunk/Source/WebCore/ChangeLog (109067 => 109068)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 04:41:18 UTC (rev 109068)
@@ -1,3 +1,31 @@
+2012-02-27 Adam Barth aba...@webkit.org
+
+EventFactory.in should be named EventNames.in
+https://bugs.webkit.org/show_bug.cgi?id=79727
+
+Reviewed by Kentaro Hara.
+
+Originally EventFactory.in was just used to generate EventFactory.cpp,
+but now we're able to generate a bunch of other Event-related code from
+this in file.
+
+In writing some documentation about how to use these mechanisms, the
+name EventFactory.in didn't seem like the right name. This patch
+renames EventFactory.in to EventNames.in, which more accurately
+describes the role of this file (and matches the naming convention of
+HTMLTagNames.in).
+
+* CMakeLists.txt:
+* DerivedSources.make:
+* DerivedSources.pri:
+* GNUmakefile.am:
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gyp/scripts/action_makenames.py:
+(main):
+* WebCore.xcodeproj/project.pbxproj:
+* dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
+* dom/EventFactory.in: Removed.
+
2012-02-27 Yoshifumi Inoue yo...@chromium.org
[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
Modified: trunk/Source/WebCore/DerivedSources.make (109067 => 109068)
--- trunk/Source/WebCore/DerivedSources.make 2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/DerivedSources.make 2012-02-28 04:41:18 UTC (rev 109068)
@@ -866,8 +866,8 @@
# Register event constructors and targets
-EventFactory.cpp EventHeaders.h EventInterfaces.h : dom/make_event_factory.pl dom/EventFactory.in
- perl -I $(WebCore)/bindings/scripts $ --input $(WebCore)/dom/EventFactory.in
+EventFactory.cpp EventHeaders.h EventInterfaces.h : dom/make_event_factory.pl dom/EventNames.in
+ perl -I $(WebCore)/bindings/scripts $ --input $(WebCore)/dom/EventNames.in
EventTargetHeaders.h EventTargetInterfaces.h : dom/make_event_factory.pl dom/EventTargetFactory.in
perl -I $(WebCore)/bindings/scripts $ --input $(WebCore)/dom/EventTargetFactory.in
Modified: trunk/Source/WebCore/DerivedSources.pri (109067 => 109068)
--- trunk/Source/WebCore/DerivedSources.pri 2012-02-28 04:17:32 UTC (rev 109067)
+++ trunk/Source/WebCore/DerivedSources.pri 2012-02-28 04:41:18 UTC (rev 109068)
@@ -43,7 +43,7 @@
HTML_ENTITIES = $$PWD/html/parser/HTMLEntityNames.in
-EVENT_FACTORY = $$PWD/dom/EventFactory.in
+EVENTS_NAMES = $$PWD/dom/EventNames.in
EVENT_TARGET_FACTORY = $$PWD/dom/EventTargetFactory.in
@@ -815,10 +815,10 @@
# GENERATOR 5-E:
[webkit-changes] [109069] trunk
Title: [109069] trunk
Revision 109069
Author ba...@chromium.org
Date 2012-02-27 20:50:08 -0800 (Mon, 27 Feb 2012)
Log Message
Unreviewed, rolling out r109041.
http://trac.webkit.org/changeset/109041
https://bugs.webkit.org/show_bug.cgi?id=79741
Broke Chromium Win build (Requested by bashi on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-27
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:
LayoutTests:
* webintents/resources/web-intents-testing.js: Removed.
* webintents/web-intents-failure-expected.txt: Removed.
* webintents/web-intents-failure.html: Removed.
* webintents/web-intents-invoke-expected.txt: Removed.
* webintents/web-intents-invoke.html: Removed.
* webintents/web-intents-reload.html:
* webintents/web-intents-reply-expected.txt: Removed.
* webintents/web-intents-reply.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webintents/web-intents-reload.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Removed Paths
trunk/LayoutTests/webintents/resources/web-intents-testing.js
trunk/LayoutTests/webintents/web-intents-failure-expected.txt
trunk/LayoutTests/webintents/web-intents-failure.html
trunk/LayoutTests/webintents/web-intents-invoke-expected.txt
trunk/LayoutTests/webintents/web-intents-invoke.html
trunk/LayoutTests/webintents/web-intents-reply-expected.txt
trunk/LayoutTests/webintents/web-intents-reply.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109068 => 109069)
--- trunk/LayoutTests/ChangeLog 2012-02-28 04:41:18 UTC (rev 109068)
+++ trunk/LayoutTests/ChangeLog 2012-02-28 04:50:08 UTC (rev 109069)
@@ -1,3 +1,20 @@
+2012-02-27 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r109041.
+http://trac.webkit.org/changeset/109041
+https://bugs.webkit.org/show_bug.cgi?id=79741
+
+Broke Chromium Win build (Requested by bashi on #webkit).
+
+* webintents/resources/web-intents-testing.js: Removed.
+* webintents/web-intents-failure-expected.txt: Removed.
+* webintents/web-intents-failure.html: Removed.
+* webintents/web-intents-invoke-expected.txt: Removed.
+* webintents/web-intents-invoke.html: Removed.
+* webintents/web-intents-reload.html:
+* webintents/web-intents-reply-expected.txt: Removed.
+* webintents/web-intents-reply.html: Removed.
+
2012-02-27 Huang Dongsung luxte...@company100.net
Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
Deleted: trunk/LayoutTests/webintents/resources/web-intents-testing.js (109068 => 109069)
--- trunk/LayoutTests/webintents/resources/web-intents-testing.js 2012-02-28 04:41:18 UTC (rev 109068)
+++ trunk/LayoutTests/webintents/resources/web-intents-testing.js 2012-02-28 04:50:08 UTC (rev 109069)
@@ -1,40 +0,0 @@
-// Callback function to be used for a successful web intent call.
-function onSuccess(data) {
- debug(* got reply: + data);
-
- if (window.layoutTestController) {
-window.layoutTestController.notifyDone();
- }
-}
-
-// Callback function to be used for a failed web intent call.
-function onFailure(data) {
- debug(* got failure: + data);
-
- if (window.layoutTestController) {
-window.layoutTestController.notifyDone();
- }
-}
-
-// Launch a web intent call with callbacks.
-function startIntentWithCallbacks() {
- navigator.startActivity(new Intent(action1, mime/type1, test), onSuccess, onFailure);
- debug(* sent intent);
-
- if (window.layoutTestController) {
-window.layoutTestController.waitUntilDone();
- } else {
-alert('This test needs to run in DRT');
- }
-}
-
-// This button press simulator sets the user gesture indicator that an intent
-// requires to start.
-function simulateButtonPress() {
- var button = document.getElementById(button);
- if (eventSender) {
-eventSender.mouseMoveTo(button.getBoundingClientRect().left + 2, button.getBoundingClientRect().top + 12);
-eventSender.mouseDown();
-eventSender.mouseUp();
- }
-}
Deleted: trunk/LayoutTests/webintents/web-intents-failure-expected.txt (109068 => 109069)
--- trunk/LayoutTests/webintents/web-intents-failure-expected.txt 2012-02-28 04:41:18 UTC (rev 109068)
+++ trunk/LayoutTests/webintents/web-intents-failure-expected.txt 2012-02-28 04:50:08 UTC (rev 109069)
@@ -1,7 +0,0 @@
-Received Web Intent: action="" type=mime/type1
-PASS successfullyParsed is true
-
-TEST COMPLETE
-* sent intent
-* got failure: ERROR
-
Deleted: trunk/LayoutTests/webintents/web-intents-failure.html (109068 => 109069)
--- trunk/LayoutTests/webintents/web-intents-failure.html 2012-02-28 04:41:18 UTC (rev 109068)
+++
[webkit-changes] [109070] trunk/Source/WebKit/chromium
Title: [109070] trunk/Source/WebKit/chromium
Revision 109070
Author kin...@chromium.org
Date 2012-02-27 20:59:50 -0800 (Mon, 27 Feb 2012)
Log Message
[chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
https://bugs.webkit.org/show_bug.cgi?id=79394
Reviewed by Darin Fisher.
* public/platform/WebFileSystem.h:
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (109069 => 109070)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-28 04:50:08 UTC (rev 109069)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-28 04:59:50 UTC (rev 109070)
@@ -1,3 +1,13 @@
+2012-02-27 Kinuko Yasuda kin...@chromium.org
+
+[chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
+https://bugs.webkit.org/show_bug.cgi?id=79394
+
+Reviewed by Darin Fisher.
+
+* public/platform/WebFileSystem.h:
+(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.
+
2012-02-27 James Kozianski k...@chromium.org
[chromium] Plumb extensionGroup into didCreateScriptContext().
Modified: trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h (109069 => 109070)
--- trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h 2012-02-28 04:50:08 UTC (rev 109069)
+++ trunk/Source/WebKit/chromium/public/platform/WebFileSystem.h 2012-02-28 04:59:50 UTC (rev 109070)
@@ -71,6 +71,7 @@
virtual void removeRecursively(const WebURL path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
// Retrieves the metadata information of the file or directory at the given |path|.
+// This may not always return the local platform path in remote filesystem cases.
// WebFileSystemCallbacks::didReadMetadata() must be called with a valid metadata when the retrieval is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
virtual void readMetadata(const WebURL path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
@@ -114,6 +115,15 @@
// This is a fast, synchronous call, and should not stat the filesystem.
virtual WebFileWriter* createFileWriter(const WebURL path, WebFileWriterClient*) { WEBKIT_ASSERT_NOT_REACHED(); return 0; }
+// Creates a snapshot file for a given file specified by |path| and registers the file with the |blobURL|. It returns the metadata of the created snapshot file.
+// The returned metadata should include a local platform path to the snapshot image.
+// In local filesystem cases the backend may simply return the metadata of the file itself (as well as readMetadata does), while in remote filesystem case the backend may download the file into a temporary snapshot file and return the metadata of the temporary file.
+// The returned metadata is used to create a File object for the |path|.
+// The snapshot file is supposed to be deleted when the last reference to the |blobURL| is dropped.
+// WebFileSystemCallbacks::didReadMetadata() with the metadata of the snapshot file must be called when the operation is completed successfully.
+// WebFileSystemCallbacks::didFail() must be called otherwise.
+virtual void createSnapshotFileAndReadMetadata(const WebURL blobURL, const WebURL path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }
+
protected:
virtual ~WebFileSystem() { }
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109071] trunk/Source/WebCore
Title: [109071] trunk/Source/WebCore
Revision 109071
Author ba...@chromium.org
Date 2012-02-27 21:16:51 -0800 (Mon, 27 Feb 2012)
Log Message
[Chromium] Unreviewed gardening, fix compile error after r109043
* platform/graphics/chromium/TransparencyWin.h:
(TransparencyWin):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109070 => 109071)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 04:59:50 UTC (rev 109070)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 05:16:51 UTC (rev 109071)
@@ -1,3 +1,10 @@
+2012-02-27 Kenichi Ishibashi ba...@chromium.org
+
+[Chromium] Unreviewed gardening, fix compile error after r109043
+
+* platform/graphics/chromium/TransparencyWin.h:
+(TransparencyWin):
+
2012-02-27 Adam Barth aba...@webkit.org
EventFactory.in should be named EventNames.in
Modified: trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h (109070 => 109071)
--- trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h 2012-02-28 04:59:50 UTC (rev 109070)
+++ trunk/Source/WebCore/platform/graphics/chromium/TransparencyWin.h 2012-02-28 05:16:51 UTC (rev 109071)
@@ -156,10 +156,10 @@
const IntRect drawRect() { return m_drawRect; }
private:
-friend TransparencyWin_NoLayer_Test;
-friend TransparencyWin_WhiteLayer_Test;
-friend TransparencyWin_TextComposite_Test;
-friend TransparencyWin_OpaqueCompositeLayer_Test;
+friend TransparencyWin_DISABLED_NoLayer_Test;
+friend TransparencyWin_DISABLED_WhiteLayer_Test;
+friend TransparencyWin_DISABLED_TextComposite_Test;
+friend TransparencyWin_DISABLED_OpaqueCompositeLayer_Test;
class OwnedBuffers;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109073] trunk
Title: [109073] trunk
Revision 109073
Author e...@chromium.org
Date 2012-02-27 21:42:45 -0800 (Mon, 27 Feb 2012)
Log Message
Printed font-size should not be dependant on zoom level
https://bugs.webkit.org/show_bug.cgi?id=79717
Reviewed by Adam Barth.
Ignore full page zoom level when printing a document.
Source/WebCore:
Test: printing/zoomed-document.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
LayoutTests:
* printing/zoomed-document-expected.txt: Added.
* printing/zoomed-document.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Added Paths
trunk/LayoutTests/printing/zoomed-document-expected.txt
trunk/LayoutTests/printing/zoomed-document.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109072 => 109073)
--- trunk/LayoutTests/ChangeLog 2012-02-28 05:29:54 UTC (rev 109072)
+++ trunk/LayoutTests/ChangeLog 2012-02-28 05:42:45 UTC (rev 109073)
@@ -1,3 +1,15 @@
+2012-02-27 Emil A Eklund e...@chromium.org
+
+Printed font-size should not be dependant on zoom level
+https://bugs.webkit.org/show_bug.cgi?id=79717
+
+Reviewed by Adam Barth.
+
+Ignore full page zoom level when printing a document.
+
+* printing/zoomed-document-expected.txt: Added.
+* printing/zoomed-document.html: Added.
+
2012-02-27 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r109041.
Added: trunk/LayoutTests/printing/zoomed-document-expected.txt (0 => 109073)
--- trunk/LayoutTests/printing/zoomed-document-expected.txt (rev 0)
+++ trunk/LayoutTests/printing/zoomed-document-expected.txt 2012-02-28 05:42:45 UTC (rev 109073)
@@ -0,0 +1 @@
+PASS Document zoom should not apply when printing.
Added: trunk/LayoutTests/printing/zoomed-document.html (0 => 109073)
--- trunk/LayoutTests/printing/zoomed-document.html (rev 0)
+++ trunk/LayoutTests/printing/zoomed-document.html 2012-02-28 05:42:45 UTC (rev 109073)
@@ -0,0 +1,27 @@
+html
+body
+pre id=console
+test
+/pre
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+
+var msg = 'Document zoom should not apply when printing.';
+var pass = true;
+
+for (var i = 0; i 10; i++) {
+var numberOfPages = layoutTestController.numberOfPages(100, 30);
+if (numberOfPages != 1) {
+pass = false;
+msg += 'Got ' + numberOfPages + ' pages, expected 1.\n';
+}
+eventSender.zoomPageIn();
+}
+
+msg = (pass ? 'PASS' : 'FAIL') + ' ' + msg;
+document.querySelector('#console').textContent = msg;
+}
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (109072 => 109073)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 05:29:54 UTC (rev 109072)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 05:42:45 UTC (rev 109073)
@@ -1,3 +1,17 @@
+2012-02-27 Emil A Eklund e...@chromium.org
+
+Printed font-size should not be dependant on zoom level
+https://bugs.webkit.org/show_bug.cgi?id=79717
+
+Reviewed by Adam Barth.
+
+Ignore full page zoom level when printing a document.
+
+Test: printing/zoomed-document.html
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+
2012-02-27 Kenichi Ishibashi ba...@chromium.org
[Chromium] Unreviewed gardening, further compile fixes for
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (109072 => 109073)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-02-28 05:29:54 UTC (rev 109072)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-02-28 05:42:45 UTC (rev 109073)
@@ -1436,7 +1436,7 @@
RefPtrRenderStyle documentStyle = RenderStyle::create();
documentStyle-setDisplay(BLOCK);
documentStyle-setRTLOrdering(document-visuallyOrdered() ? VisualOrder : LogicalOrder);
-documentStyle-setZoom(frame ? frame-pageZoomFactor() : 1);
+documentStyle-setZoom(frame !document-printing() ? frame-pageZoomFactor() : 1);
documentStyle-setPageScaleTransform(frame ? frame-frameScaleFactor() : 1);
documentStyle-setUserModify(document-inDesignMode() ? READ_WRITE : READ_ONLY);
documentStyle-setLocale(document-contentLanguage());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109074] trunk/Source/WebCore
Title: [109074] trunk/Source/WebCore
Revision 109074
Author leo.y...@torchmobile.com.cn
Date 2012-02-27 21:49:02 -0800 (Mon, 27 Feb 2012)
Log Message
[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntRect.h
https://bugs.webkit.org/show_bug.cgi?id=79732
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::IntRect and BlackBerry::Platform::IntRect.
The porting can't be built yet, no new tests.
* platform/graphics/IntRect.h:
(Platform):
(IntRect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/IntRect.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109073 => 109074)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 05:42:45 UTC (rev 109073)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 05:49:02 UTC (rev 109074)
@@ -1,3 +1,18 @@
+2012-02-27 Leo Yang leo.y...@torchmobile.com.cn
+
+[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntRect.h
+https://bugs.webkit.org/show_bug.cgi?id=79732
+
+Reviewed by Antonio Gomes.
+
+Add conversion convenience between WebCore::IntRect and BlackBerry::Platform::IntRect.
+
+The porting can't be built yet, no new tests.
+
+* platform/graphics/IntRect.h:
+(Platform):
+(IntRect):
+
2012-02-27 Emil A Eklund e...@chromium.org
Printed font-size should not be dependant on zoom level
Modified: trunk/Source/WebCore/platform/graphics/IntRect.h (109073 => 109074)
--- trunk/Source/WebCore/platform/graphics/IntRect.h 2012-02-28 05:42:45 UTC (rev 109073)
+++ trunk/Source/WebCore/platform/graphics/IntRect.h 2012-02-28 05:49:02 UTC (rev 109074)
@@ -53,6 +53,12 @@
#endif
#elif PLATFORM(EFL)
typedef struct _Eina_Rectangle Eina_Rectangle;
+#elif PLATFORM(BLACKBERRY)
+namespace BlackBerry {
+namespace Platform {
+class IntRect;
+}
+}
#endif
#if USE(CAIRO)
@@ -214,6 +220,11 @@
operator NSRect() const;
#endif
+#if PLATFORM(BLACKBERRY)
+IntRect(const BlackBerry::Platform::IntRect);
+operator BlackBerry::Platform::IntRect() const;
+#endif
+
private:
IntPoint m_location;
IntSize m_size;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
