[webkit-changes] [115167] trunk/Source/WebCore
Title: [115167] trunk/Source/WebCore Revision 115167 Author yu...@chromium.org Date 2012-04-24 23:37:02 -0700 (Tue, 24 Apr 2012) Log Message 2012-04-24 Yury Semikhatsky yu...@chromium.org Unreviewed. Revert part of the change r115063 which commented out real worker creation. It was commited by mistake. * inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotWorker): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js Diff Modified: trunk/Source/WebCore/ChangeLog (115166 => 115167) --- trunk/Source/WebCore/ChangeLog 2012-04-25 05:52:46 UTC (rev 115166) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 06:37:02 UTC (rev 115167) @@ -1,3 +1,11 @@ +2012-04-24 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Revert part of the change r115063 which commented out +real worker creation. It was commited by mistake. + +* inspector/front-end/HeapSnapshotProxy.js: +(WebInspector.HeapSnapshotWorker): + 2012-04-24 Jon Lee jon...@apple.com New Notification constructor do not take into account security origin permissions Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js (115166 => 115167) --- trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js 2012-04-25 05:52:46 UTC (rev 115166) +++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js 2012-04-25 06:37:02 UTC (rev 115167) @@ -124,7 +124,7 @@ this._callbacks = []; this._previousCallbacks = []; // There is no support for workers in Chromium DRT. -this._worker = /* typeof InspectorTest === undefined ? new WebInspector.HeapSnapshotRealWorker() :*/ new WebInspector.HeapSnapshotFakeWorker(); +this._worker = typeof InspectorTest === undefined ? new WebInspector.HeapSnapshotRealWorker() : new WebInspector.HeapSnapshotFakeWorker(); this._worker.addEventListener(message, this._messageReceived, this); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115168] trunk/LayoutTests
Title: [115168] trunk/LayoutTests
Revision 115168
Author ph...@webkit.org
Date 2012-04-24 23:52:37 -0700 (Tue, 24 Apr 2012)
Log Message
Unreviewed, GTK svg rebaseline after r115085.
* platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* platform/gtk/svg/carto.net/button-expected.txt:
* platform/gtk/svg/carto.net/colourpicker-expected.txt:
* platform/gtk/svg/carto.net/slider-expected.txt:
* platform/gtk/svg/carto.net/window-expected.txt:
* platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
* platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/gtk/svg/custom/use-clipped-hit-expected.txt:
* platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
* platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/gtk/svg/custom/use-on-symbol-expected.txt:
* platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
* platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/gtk/svg/custom/use-setAttribute-crash-expected.txt:
* platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt
trunk/LayoutTests/platform/gtk/svg/carto.net/button-expected.txt
trunk/LayoutTests/platform/gtk/svg/carto.net/colourpicker-expected.txt
trunk/LayoutTests/platform/gtk/svg/carto.net/slider-expected.txt
trunk/LayoutTests/platform/gtk/svg/carto.net/window-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/embedding-external-svgs-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-clipped-hit-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-modify-target-symbol-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-on-symbol-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-setAttribute-crash-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/use-symbol-overflow-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (115167 => 115168)
--- trunk/LayoutTests/ChangeLog 2012-04-25 06:37:02 UTC (rev 115167)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 06:52:37 UTC (rev 115168)
@@ -1,3 +1,25 @@
+2012-04-24 Philippe Normand pnorm...@igalia.com
+
+Unreviewed, GTK svg rebaseline after r115085.
+
+* platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
+* platform/gtk/svg/carto.net/button-expected.txt:
+* platform/gtk/svg/carto.net/colourpicker-expected.txt:
+* platform/gtk/svg/carto.net/slider-expected.txt:
+* platform/gtk/svg/carto.net/window-expected.txt:
+* platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
+* platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
+* platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
+* platform/gtk/svg/custom/use-clipped-hit-expected.txt:
+* platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
+* platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
+* platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
+* platform/gtk/svg/custom/use-on-symbol-expected.txt:
+* platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
+* platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
+* platform/gtk/svg/custom/use-setAttribute-crash-expected.txt:
+* platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
+
2012-04-24 Kulanthaivel Palanichamy kulanthai...@codeaurora.org
getMatchedCSSRules() should return null when the second argument is an unrecognized pseudo-element name
Modified: trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt (115167 => 115168)
--- trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt 2012-04-25 06:37:02 UTC (rev 115167)
+++ trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt 2012-04-25 06:52:37 UTC (rev 115168)
@@ -3,6 +3,15 @@
layer at (0,0) size 480x360
RenderSVGRoot {svg} at (0,0) size 480x360
RenderSVGContainer {g} at (0,0) size 480x300
+ RenderSVGHiddenContainer {symbol} at (0,0) size 0x0
+RenderSVGImage {image} at (0,0) size 480x360
+
[webkit-changes] [115169] trunk/LayoutTests
Title: [115169] trunk/LayoutTests Revision 115169 Author yu...@chromium.org Date 2012-04-25 00:00:56 -0700 (Wed, 25 Apr 2012) Log Message Unreviewed. Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html on Win and Win Cairo in addition to Mac and Qt(JSC doesn't support heap profiling and the test doesn't make sense there). * platform/win/Skipped: * platform/wincairo/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wincairo/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (115168 => 115169) --- trunk/LayoutTests/ChangeLog 2012-04-25 06:52:37 UTC (rev 115168) +++ trunk/LayoutTests/ChangeLog 2012-04-25 07:00:56 UTC (rev 115169) @@ -1,3 +1,12 @@ +2012-04-24 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html +on Win and Win Cairo in addition to Mac and Qt(JSC doesn't support heap profiling and +the test doesn't make sense there). + +* platform/win/Skipped: +* platform/wincairo/Skipped: + 2012-04-24 Philippe Normand pnorm...@igalia.com Unreviewed, GTK svg rebaseline after r115085. Modified: trunk/LayoutTests/platform/win/Skipped (115168 => 115169) --- trunk/LayoutTests/platform/win/Skipped 2012-04-25 06:52:37 UTC (rev 115168) +++ trunk/LayoutTests/platform/win/Skipped 2012-04-25 07:00:56 UTC (rev 115169) @@ -1257,6 +1257,7 @@ # JSC doesn't support heap profiling # https://bugs.webkit.org/show_bug.cgi?id=50485 inspector/profiler/heap-snapshot-inspect-dom-wrapper.html +inspector/profiler/heap-snapshot-comparison-dom-groups-change.html # https://bugs.webkit.org/show_bug.cgi?id=40300 inspector/debugger/live-edit.html Modified: trunk/LayoutTests/platform/wincairo/Skipped (115168 => 115169) --- trunk/LayoutTests/platform/wincairo/Skipped 2012-04-25 06:52:37 UTC (rev 115168) +++ trunk/LayoutTests/platform/wincairo/Skipped 2012-04-25 07:00:56 UTC (rev 115169) @@ -1769,6 +1769,7 @@ # JSC doesn't support heap profiling # https://bugs.webkit.org/show_bug.cgi?id=50485 inspector/profiler/heap-snapshot-inspect-dom-wrapper.html +inspector/profiler/heap-snapshot-comparison-dom-groups-change.html # https://bugs.webkit.org/show_bug.cgi?id=40300 inspector/debugger/live-edit.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115170] trunk/LayoutTests
Title: [115170] trunk/LayoutTests
Revision 115170
Author o...@webkit.org
Date 2012-04-25 00:02:01 -0700 (Wed, 25 Apr 2012)
Log Message
[Qt] Unreviewed morning gardening after r115085.
* platform/qt/Skipped: Unskip a non-existing test.
* platform/qt/svg/custom/embedding-external-svgs-expected.txt:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
* platform/qt/svg/custom/use-clipped-hit-expected.txt:
* platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
* platform/qt/svg/custom/use-symbol-overflow-expected.txt:
* platform/wk2/Skipped: Unskip a non-existing test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/svg/custom/embedding-external-svgs-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/use-clipped-hit-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/use-modify-target-symbol-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/use-setAttribute-crash-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/use-symbol-overflow-expected.txt
trunk/LayoutTests/platform/wk2/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (115169 => 115170)
--- trunk/LayoutTests/ChangeLog 2012-04-25 07:00:56 UTC (rev 115169)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 07:02:01 UTC (rev 115170)
@@ -1,3 +1,18 @@
+2012-04-24 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Unreviewed morning gardening after r115085.
+
+* platform/qt/Skipped: Unskip a non-existing test.
+* platform/qt/svg/custom/embedding-external-svgs-expected.txt:
+* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
+* platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
+* platform/qt/svg/custom/use-clipped-hit-expected.txt:
+* platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
+* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
+* platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
+* platform/qt/svg/custom/use-symbol-overflow-expected.txt:
+* platform/wk2/Skipped: Unskip a non-existing test.
+
2012-04-24 Yury Semikhatsky yu...@chromium.org
Unreviewed. Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
Modified: trunk/LayoutTests/platform/qt/Skipped (115169 => 115170)
--- trunk/LayoutTests/platform/qt/Skipped 2012-04-25 07:00:56 UTC (rev 115169)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-04-25 07:02:01 UTC (rev 115170)
@@ -1107,9 +1107,6 @@
fast/canvas/2d.backingStorePixelRatio.html
fast/canvas/2d.imageDataHD.html
-# window.resizeTo() does not trigger a relayout in our DumpRenderTree
-fast/media/media-query-list-08.html
-
# This requires didClearWindowObjectForFrameInIsolatedWorld foo in FrameLoaderClient
http/tests/security/isolatedWorld/didClearWindowObject.html
# This needs more investigation
Modified: trunk/LayoutTests/platform/qt/svg/custom/embedding-external-svgs-expected.txt (115169 => 115170)
--- trunk/LayoutTests/platform/qt/svg/custom/embedding-external-svgs-expected.txt 2012-04-25 07:00:56 UTC (rev 115169)
+++ trunk/LayoutTests/platform/qt/svg/custom/embedding-external-svgs-expected.txt 2012-04-25 07:02:01 UTC (rev 115170)
@@ -11,6 +11,8 @@
RenderView at (0,0) size 40x40
layer at (0,0) size 40x40
RenderSVGRoot {svg} at (0,0) size 40x40
+ RenderSVGHiddenContainer {symbol} at (0,0) size 0x0
+RenderSVGPath {polygon} at (17,0) size 6x12 [fill={[type=SOLID] [color=#00]}] [points=22 0 28 0 23 15 23 15]
RenderSVGContainer {g} at (0,0) size 40x40
RenderSVGContainer {use} at (17,0) size 6x12
RenderSVGViewportContainer {svg} at (17,0) size 6x12
@@ -63,6 +65,8 @@
RenderView at (0,0) size 40x40
layer at (0,0) size 40x40
RenderSVGRoot {svg} at (0,0) size 40x40
+ RenderSVGHiddenContainer {symbol} at (0,0) size 0x0
+RenderSVGPath {polygon} at (17,0) size 6x12 [fill={[type=SOLID] [color=#00]}] [points=22 0 28 0 23 15 23 15]
RenderSVGContainer {g} at (0,0) size 40x40
RenderSVGContainer {use} at (17,0) size 6x12
RenderSVGViewportContainer {svg} at (17,0) size 6x12
Modified: trunk/LayoutTests/platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt (115169 => 115170)
---
[webkit-changes] [115171] trunk/LayoutTests
Title: [115171] trunk/LayoutTests
Revision 115171
Author o...@webkit.org
Date 2012-04-25 00:08:18 -0700 (Wed, 25 Apr 2012)
Log Message
[Qt] Unreviewed morning gardening after r115091.
* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png
trunk/LayoutTests/platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (115170 => 115171)
--- trunk/LayoutTests/ChangeLog 2012-04-25 07:02:01 UTC (rev 115170)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 07:08:18 UTC (rev 115171)
@@ -1,3 +1,10 @@
+2012-04-25 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Unreviewed morning gardening after r115091.
+
+* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
+* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
+
2012-04-24 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed morning gardening after r115085.
Modified: trunk/LayoutTests/platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt (115170 => 115171)
--- trunk/LayoutTests/platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt 2012-04-25 07:02:01 UTC (rev 115170)
+++ trunk/LayoutTests/platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt 2012-04-25 07:08:18 UTC (rev 115171)
@@ -4,48 +4,48 @@
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x576
RenderBlock {CENTER} at (0,0) size 784x182
-RenderTable {TABLE} at (334,0) size 115x92 [border: none]
- RenderTableSection {THEAD} at (0,0) size 114x23
-RenderTableRow {TR} at (0,0) size 114x23
- RenderTableCell {TD} at (0,0) size 37x23 [border: none none none (1px solid #808080)] [r=0 c=0 rs=1 cs=1]
-RenderText {#text} at (2,1) size 32x21
- text run at (2,1) width 32: EST
- RenderTableCell {TD} at (37,0) size 34x23 [border: none none none (1px solid #808080)] [r=0 c=1 rs=1 cs=1]
+RenderTable {TABLE} at (335,0) size 113x92
+ RenderTableSection {THEAD} at (0,0) size 113x23
+RenderTableRow {TR} at (0,0) size 113x23
+ RenderTableCell {TD} at (0,0) size 36x23 [r=0 c=0 rs=1 cs=1]
+RenderText {#text} at (1,1) size 32x21
+ text run at (1,1) width 32: EST
+ RenderTableCell {TD} at (36,0) size 34x23 [border: none none none (1px solid #808080)] [r=0 c=1 rs=1 cs=1]
RenderText {#text} at (2,1) size 31x21
text run at (2,1) width 31: 1am
- RenderTableCell {TD} at (71,0) size 43x23 [border: none none none (1px solid #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (70,0) size 43x23 [border: none none none (1px solid #808080)] [r=0 c=2 rs=1 cs=1]
RenderText {#text} at (2,1) size 31x21
text run at (2,1) width 31: 8pm
- RenderTableSection {TBODY} at (0,23) size 114x46
-RenderTableRow {TR} at (0,0) size 114x23
- RenderTableCell {TD} at (0,0) size 37x23 [border: none none none (1px solid #808080)] [r=0 c=0 rs=1 cs=1]
-RenderText {#text} at (2,1) size 33x21
- text run at (2,1) width 33: CST
- RenderTableCell {TD} at (37,0) size 34x23 [border: none none none (1px solid #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderTableSection {TBODY} at (0,23) size 113x46
+RenderTableRow {TR} at (0,0) size 113x23
+ RenderTableCell {TD} at (0,0) size 36x23 [r=0 c=0 rs=1 cs=1]
+RenderText {#text} at (1,1) size 33x21
+ text run at (1,1) width 33: CST
+ RenderTableCell {TD} at (36,0) size 34x23 [border: none none none (1px solid #808080)] [r=0 c=1 rs=1 cs=1]
RenderText {#text} at (2,1) size 31x21
text run at (2,1) width 31: 2am
- RenderTableCell {TD} at (71,0) size 43x23 [border: none none none (1px solid #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (70,0) size 43x23 [border: none none none (1px solid #808080)] [r=0 c=2 rs=1 cs=1]
RenderText {#text} at (2,1) size 31x21
text run at (2,1) width 31: 9pm
-RenderTableRow {TR} at (0,23) size 114x23
- RenderTableCell {TD} at (0,23) size 37x23 [border: none none none (1px solid #808080)] [r=1 c=0 rs=1 cs=1]
-
[webkit-changes] [115172] trunk
Title: [115172] trunk
Revision 115172
Author wangxian...@chromium.org
Date 2012-04-25 00:11:21 -0700 (Wed, 25 Apr 2012)
Log Message
Source/WebCore: Web Inspector: Incorrect highlight position of inspected element in a scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755
Reviewed by Pavel Feldman.
Test: inspector/elements/highlight-node-scroll.html
* inspector/DOMNodeHighlighter.cpp: Ensures the highlight position is in page coordinates.
LayoutTests: Web Inspector: REGRESSION: Incorrect highlight position of inspected element in scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755
Reviewed by Pavel Feldman.
* http/tests/inspector/elements-test.js: Extracted common function dumpInspectorHighlightRects() into here with a small bug fixed (x and y inversed).
* inspector/elements/highlight-node-scaled-expected.txt: Corrected the wrong inversed x and y.
* inspector/elements/highlight-node-scaled.html: Extracted out dumpInspectorHighlightRects().
* inspector/elements/highlight-node-scroll-expected.txt: Added. Expectation of the new test case.
* inspector/elements/highlight-node-scroll.html: Added. The new test case.
* inspector/elements/highlight-node.html: Extracted out dumpInspectorHighlightRects(). Expectation not changed because the x and y happened to be the same in the original expectation.
* inspector/elements/highlight-svg-root.html: Ditto.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/elements-test.js
trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt
trunk/LayoutTests/inspector/elements/highlight-node-scaled.html
trunk/LayoutTests/inspector/elements/highlight-node.html
trunk/LayoutTests/inspector/elements/highlight-svg-root.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp
Added Paths
trunk/LayoutTests/inspector/elements/highlight-node-scroll-expected.txt
trunk/LayoutTests/inspector/elements/highlight-node-scroll.html
Diff
Modified: trunk/LayoutTests/ChangeLog (115171 => 115172)
--- trunk/LayoutTests/ChangeLog 2012-04-25 07:08:18 UTC (rev 115171)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 07:11:21 UTC (rev 115172)
@@ -1,3 +1,18 @@
+2012-04-25 Xianzhu Wang wangxian...@chromium.org
+
+Web Inspector: REGRESSION: Incorrect highlight position of inspected element in scrolled page
+https://bugs.webkit.org/show_bug.cgi?id=84755
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/elements-test.js: Extracted common function dumpInspectorHighlightRects() into here with a small bug fixed (x and y inversed).
+* inspector/elements/highlight-node-scaled-expected.txt: Corrected the wrong inversed x and y.
+* inspector/elements/highlight-node-scaled.html: Extracted out dumpInspectorHighlightRects().
+* inspector/elements/highlight-node-scroll-expected.txt: Added. Expectation of the new test case.
+* inspector/elements/highlight-node-scroll.html: Added. The new test case.
+* inspector/elements/highlight-node.html: Extracted out dumpInspectorHighlightRects(). Expectation not changed because the x and y happened to be the same in the original expectation.
+* inspector/elements/highlight-svg-root.html: Ditto.
+
2012-04-25 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed morning gardening after r115091.
Modified: trunk/LayoutTests/http/tests/inspector/elements-test.js (115171 => 115172)
--- trunk/LayoutTests/http/tests/inspector/elements-test.js 2012-04-25 07:08:18 UTC (rev 115171)
+++ trunk/LayoutTests/http/tests/inspector/elements-test.js 2012-04-25 07:11:21 UTC (rev 115172)
@@ -434,3 +434,15 @@
}
};
+
+function dumpInspectorHighlightRects()
+{
+var rectNames = [margin, border, padding, content];
+var rects = window.internals.inspectorHighlightRects(document);
+for (var i = 0; i rects.length; i++)
+{
+var rectName = (i rectNames.length ? rectNames[i] : untitled);
+var rect = rects.item(i);
+output(rectName + rect is + rect.width + x + rect.height + at ( + rect.left + , + rect.top + ));
+}
+}
Modified: trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt (115171 => 115172)
--- trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt 2012-04-25 07:08:18 UTC (rev 115171)
+++ trunk/LayoutTests/inspector/elements/highlight-node-scaled-expected.txt 2012-04-25 07:11:21 UTC (rev 115172)
@@ -1,6 +1,6 @@
-margin rect is 166 x 188 at (154, 192)
-border rect is 138 x 160 at (168, 206)
-padding rect is 118 x 140 at (178, 216)
-content rect is 66 x 88 at (204, 242)
+margin rect is 166 x 188 at (192, 154)
+border rect is 138 x 160 at (206, 168)
+padding rect is 118 x 140 at (216, 178)
+content rect is 66 x 88 at (242, 204)
Modified: trunk/LayoutTests/inspector/elements/highlight-node-scaled.html (115171 => 115172)
--- trunk/LayoutTests/inspector/elements/highlight-node-scaled.html 2012-04-25 07:08:18
[webkit-changes] [115173] trunk/Tools
Title: [115173] trunk/Tools
Revision 115173
Author commit-qu...@webkit.org
Date 2012-04-25 00:39:19 -0700 (Wed, 25 Apr 2012)
Log Message
[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
https://bugs.webkit.org/show_bug.cgi?id=84709
Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-04-25
Reviewed by Eric Seidel.
Not all the settings that can be changed by layout testcases through a JS API were
reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(defaultEditingBehavior): returns editing behavior depending on current platform.
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Diff
Modified: trunk/Tools/ChangeLog (115172 => 115173)
--- trunk/Tools/ChangeLog 2012-04-25 07:11:21 UTC (rev 115172)
+++ trunk/Tools/ChangeLog 2012-04-25 07:39:19 UTC (rev 115173)
@@ -1,3 +1,17 @@
+2012-04-25 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
+
+[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
+https://bugs.webkit.org/show_bug.cgi?id=84709
+
+Reviewed by Eric Seidel.
+
+Not all the settings that can be changed by layout testcases through a JS API were
+reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
+
+* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+(defaultEditingBehavior): returns editing behavior depending on current platform.
+(DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
+
2012-04-24 Dirk Pranke dpra...@chromium.org
nrwt: add ASAN handling to chromium crash logs
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (115172 => 115173)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-04-25 07:11:21 UTC (rev 115172)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-04-25 07:39:19 UTC (rev 115173)
@@ -168,6 +168,21 @@
return m_mainView;
}
+static inline const char* defaultEditingBehavior()
+{
+return
+#if OS(DARWIN)
+mac;
+#elif OS(WINDOWS)
+win;
+#elif OS(UNIX)
+unix;
+#else
+// Fallback
+mac;
+#endif
+}
+
void DumpRenderTreeChrome::resetDefaultsToConsistentValues()
{
VectorEvas_Object*::iterator it = m_extraViews.begin();
@@ -202,6 +217,10 @@
ewk_view_setting_scripts_can_open_windows_set(mainView(), EINA_TRUE);
ewk_view_setting_scripts_can_close_windows_set(mainView(), EINA_TRUE);
ewk_view_setting_auto_load_images_set(mainView(), EINA_TRUE);
+ewk_view_setting_user_stylesheet_set(mainView(), 0);
+ewk_view_setting_enable_xss_auditor_set(browser-mainView(), EINA_TRUE);
+ewk_view_setting_enable_developer_extras_set(browser-mainView(), EINA_FALSE);
+ewk_view_setting_minimum_timer_interval_set(browser-mainView(), 0.010); // 10 milliseconds (DOMTimer::s_minDefaultTimerInterval)
ewk_view_zoom_set(mainView(), 1.0, 0, 0);
ewk_view_scale_set(mainView(), 1.0, 0, 0);
@@ -215,6 +234,10 @@
DumpRenderTreeSupportEfl::clearOpener(mainFrame());
DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled(mainView(), true);
DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled(mainView(), true);
+DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled(mainView(), false);
+DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled(mainView(), false);
+DumpRenderTreeSupportEfl::setDefersLoading(mainView(), false);
+DumpRenderTreeSupportEfl::setEditingBehavior(mainView(), defaultEditingBehavior());
}
// Smart Callbacks
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115174] trunk/Source/WebCore
Title: [115174] trunk/Source/WebCore
Revision 115174
Author commit-qu...@webkit.org
Date 2012-04-25 00:55:46 -0700 (Wed, 25 Apr 2012)
Log Message
No audio from MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=84669
MediaElementAudioSourceNode needs custom propagatesSilence() to
return false to indicate the node never propagates silence.
Patch by Raymond Toy r...@google.com on 2012-04-25
Reviewed by Chris Rogers.
* Modules/webaudio/MediaElementAudioSourceNode.h:
(MediaElementAudioSourceNode): Add propagatesSilence().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115173 => 115174)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 07:39:19 UTC (rev 115173)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 07:55:46 UTC (rev 115174)
@@ -1,3 +1,16 @@
+2012-04-25 Raymond Toy r...@google.com
+
+No audio from MediaElementAudioSourceNode
+https://bugs.webkit.org/show_bug.cgi?id=84669
+
+MediaElementAudioSourceNode needs custom propagatesSilence() to
+return false to indicate the node never propagates silence.
+
+Reviewed by Chris Rogers.
+
+* Modules/webaudio/MediaElementAudioSourceNode.h:
+(MediaElementAudioSourceNode): Add propagatesSilence().
+
2012-04-25 Xianzhu Wang wangxian...@chromium.org
Web Inspector: Incorrect highlight position of inspected element in a scrolled page
Modified: trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h (115173 => 115174)
--- trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h 2012-04-25 07:39:19 UTC (rev 115173)
+++ trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h 2012-04-25 07:55:46 UTC (rev 115174)
@@ -60,6 +60,9 @@
private:
MediaElementAudioSourceNode(AudioContext*, HTMLMediaElement*);
+// As an audio source, we will never propagate silence.
+virtual bool propagatesSilence() const OVERRIDE { return false; }
+
RefPtrHTMLMediaElement m_mediaElement;
Mutex m_processLock;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115175] trunk/LayoutTests
Title: [115175] trunk/LayoutTests Revision 115175 Author zimmerm...@webkit.org Date 2012-04-25 00:56:24 -0700 (Wed, 25 Apr 2012) Log Message 2012-04-25 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Update pixel test baseline on Lion. All color space changes when painting images. I noticed that svg/custom/focus-ring.svg is flakey, the result may be off by two 1px changes. * platform/mac/svg/as-background-image/svg-as-background-4-expected.png: * platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png: * platform/mac/svg/carto.net/window-expected.png: * platform/mac/svg/custom/createImageElement-expected.png: * platform/mac/svg/custom/createImageElement2-expected.png: * platform/mac/svg/custom/deep-dynamic-updates-expected.png: * platform/mac/svg/custom/focus-ring-expected.png: * platform/mac/svg/custom/image-parent-translation-expected.png: * platform/mac/svg/custom/image-small-width-height-expected.png: * platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.png: * platform/mac/svg/custom/image-with-transform-clip-filter-expected.png: * platform/mac/svg/custom/js-update-image-and-display-expected.png: * platform/mac/svg/custom/js-update-image-and-display2-expected.png: * platform/mac/svg/custom/js-update-image-and-display3-expected.png: * platform/mac/svg/custom/js-update-image-expected.png: * platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: * platform/mac/svg/custom/pointer-events-image-expected.png: * platform/mac/svg/custom/text-image-opacity-expected.png: * platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png: * platform/mac/svg/wicd/test-rightsizing-b-expected.png: * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/svg/as-background-image/svg-as-background-4-expected.png trunk/LayoutTests/platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png trunk/LayoutTests/platform/mac/svg/carto.net/window-expected.png trunk/LayoutTests/platform/mac/svg/custom/createImageElement-expected.png trunk/LayoutTests/platform/mac/svg/custom/createImageElement2-expected.png trunk/LayoutTests/platform/mac/svg/custom/deep-dynamic-updates-expected.png trunk/LayoutTests/platform/mac/svg/custom/focus-ring-expected.png trunk/LayoutTests/platform/mac/svg/custom/image-parent-translation-expected.png trunk/LayoutTests/platform/mac/svg/custom/image-small-width-height-expected.png trunk/LayoutTests/platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.png trunk/LayoutTests/platform/mac/svg/custom/image-with-transform-clip-filter-expected.png trunk/LayoutTests/platform/mac/svg/custom/js-update-image-and-display-expected.png trunk/LayoutTests/platform/mac/svg/custom/js-update-image-and-display2-expected.png trunk/LayoutTests/platform/mac/svg/custom/js-update-image-and-display3-expected.png trunk/LayoutTests/platform/mac/svg/custom/js-update-image-expected.png trunk/LayoutTests/platform/mac/svg/custom/pointer-events-image-css-transform-expected.png trunk/LayoutTests/platform/mac/svg/custom/pointer-events-image-expected.png trunk/LayoutTests/platform/mac/svg/custom/text-image-opacity-expected.png trunk/LayoutTests/platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png
[webkit-changes] [115176] trunk/LayoutTests
Title: [115176] trunk/LayoutTests Revision 115176 Author ser...@webkit.org Date 2012-04-25 01:09:40 -0700 (Wed, 25 Apr 2012) Log Message Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots. * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115175 => 115176) --- trunk/LayoutTests/ChangeLog 2012-04-25 07:56:24 UTC (rev 115175) +++ trunk/LayoutTests/ChangeLog 2012-04-25 08:09:40 UTC (rev 115176) @@ -1,3 +1,9 @@ +2012-04-25 Sergio Villar Senin svil...@igalia.com + +Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots. + +* platform/gtk/test_expectations.txt: + 2012-04-25 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Update pixel test baseline on Lion. All color space changes when painting images. Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (115175 => 115176) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-25 07:56:24 UTC (rev 115175) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-25 08:09:40 UTC (rev 115176) @@ -512,16 +512,6 @@ // // Tests timing out // - -BUGWK33445 : http/tests/incremental/split-hex-entities.pl = TIMEOUT - -BUGWK33026 : http/tests/xmlhttprequest/simple-cross-origin-progress-events.html = TIMEOUT - -// Times out only on 32-Bits Release -BUGWKGTK : http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html = TIMEOUT -BUGWKGTK : http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html = TIMEOUT -BUGWKGTK : http/tests/xmlhttprequest/redirect-cross-origin-sync.html = TIMEOUT - BUGWK46644 : fast/text/large-text-composed-char-dos.html = TIMEOUT BUGWKGTK SKIP : http/tests/multipart/invalid-image-data-standalone.html = TIMEOUT @@ -670,7 +660,6 @@ // This port doesn't support v8 i18n extension. BUGWKGTK : fast/js/i18n-bindings-locale.html = FAIL -BUGWKGTK : http/tests/appcache/crash-when-navigating-away-then-back.html = FAIL BUGWKGTK : http/tests/appcache/fallback.html = FAIL BUGWKGTK : http/tests/appcache/origin-quota.html = FAIL BUGWKGTK : http/tests/appcache/origin-quota-continued-download.html = FAIL @@ -687,15 +676,11 @@ // Needed to cover the fix for rdar://problem/6727495 BUGRDAR6727495 : http/tests/loading/deleted-host-in-resource-load-delegate-callback.html = FAIL BUGRDAR6727495 : http/tests/loading/gmail-assert-on-load.html = FAIL -BUGRDAR6727495 : http/tests/loading/redirect-with-no-location-crash.html = FAIL BUGRDAR6727495 : http/tests/loading/text-content-type-with-binary-extension.html = FAIL BUGWKGTK : http/tests/media/video-play-stall-seek.html = FAIL BUGWKGTK : http/tests/media/video-play-stall.html = FAIL -// QuickTime reference movie not supported. -BUGWKGTK : http/tests/media/video-cross-site.html = FAIL - BUGWKGTK : http/tests/misc/acid3.html = FAIL BUGWKGTK : http/tests/misc/link-rel-prefetch-and-subresource.html = FAIL BUGWKGTK : http/tests/misc/policy-delegate-called-twice.html = FAIL @@ -722,10 +707,8 @@ BUGWKGTK : http/tests/xmlhttprequest/abort-should-cancel-load.html = FAIL BUGWKGTK : http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html = FAIL BUGWKGTK : http/tests/xmlhttprequest/logout.html = FAIL -BUGWKGTK : http/tests/xmlhttprequest/xmlhttprequest-contenttype-empty.html = FAIL // We don't seem to support neither of these for now -BUGWKGTK : http/tests/xmlhttprequest/cross-origin-authorization.html = FAIL BUGWKGTK : http/tests/xmlhttprequest/cross-origin-cookie-storage.html = FAIL BUGWKGTK : http/tests/xmlhttprequest/cross-origin-no-authorization.html = FAIL @@ -745,10 +728,7 @@ // Missing resource load callback ability in DRT BUGWK27905 : http/tests/loading/redirect-methods.html = FAIL -BUGWK27905 : http/tests/misc/favicon-loads-with-images-disabled.html = FAIL -BUGWK28668 : http/tests/appcache/auth.html = FAIL - // New test infrastructure required -- need isolated worlds BUGWK31508 : http/tests/security/isolatedWorld = FAIL BUGWK31508 : storage/open-database-creation-callback-isolated-world.html = FAIL @@ -772,7 +752,6 @@ // No authentication challenge handling BUGWK51104 : http/tests/loading/basic-credentials-sent-automatically.html = FAIL BUGWK51104 : http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html = FAIL -BUGWK51104 : http/tests/cache/subresource-fragment-identifier.html = FAIL BUGWK51104 : http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html = FAIL BUGWK51104 : http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html = FAIL BUGWK51104 :
[webkit-changes] [115177] trunk/Source/WebCore
Title: [115177] trunk/Source/WebCore
Revision 115177
Author kl...@webkit.org
Date 2012-04-25 01:18:52 -0700 (Wed, 25 Apr 2012)
Log Message
Shrink RenderText by 8 bytes on 64-bit.
http://webkit.org/b/84828
Reviewed by Maciej Stachowiak.
Reorder the members so that the bits in RenderText falls into the padding at
the end of RenderObject on 64-bit. Updated the compile-time size assertion to
account for the new object structure.
This shrinks RenderText from 104 to 96 bytes on 64-bit release builds.
* rendering/RenderText.cpp:
(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):
* rendering/RenderText.h:
(RenderText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderText.cpp
trunk/Source/WebCore/rendering/RenderText.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115176 => 115177)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 08:09:40 UTC (rev 115176)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 08:18:52 UTC (rev 115177)
@@ -1,3 +1,22 @@
+2012-04-25 Andreas Kling kl...@webkit.org
+
+Shrink RenderText by 8 bytes on 64-bit.
+http://webkit.org/b/84828
+
+Reviewed by Maciej Stachowiak.
+
+Reorder the members so that the bits in RenderText falls into the padding at
+the end of RenderObject on 64-bit. Updated the compile-time size assertion to
+account for the new object structure.
+
+This shrinks RenderText from 104 to 96 bytes on 64-bit release builds.
+
+* rendering/RenderText.cpp:
+(SameSizeAsRenderText):
+(WebCore::RenderText::RenderText):
+* rendering/RenderText.h:
+(RenderText):
+
2012-04-25 Raymond Toy r...@google.com
No audio from MediaElementAudioSourceNode
Modified: trunk/Source/WebCore/rendering/RenderText.cpp (115176 => 115177)
--- trunk/Source/WebCore/rendering/RenderText.cpp 2012-04-25 08:09:40 UTC (rev 115176)
+++ trunk/Source/WebCore/rendering/RenderText.cpp 2012-04-25 08:18:52 UTC (rev 115177)
@@ -54,10 +54,10 @@
namespace WebCore {
class SameSizeAsRenderText : public RenderObject {
+uint32_t bitfields : 16;
float widths[4];
String text;
void* pointers[2];
-uint32_t bitfields : 16;
};
COMPILE_ASSERT(sizeof(RenderText) == sizeof(SameSizeAsRenderText), RenderText_should_stay_small);
@@ -135,6 +135,11 @@
RenderText::RenderText(Node* node, PassRefPtrStringImpl str)
: RenderObject(node)
+ , m_hasTab(false)
+ , m_linesDirty(false)
+ , m_containsReversedText(false)
+ , m_knownToHaveNoOverflowAndNoFallbackFonts(false)
+ , m_needsTranscoding(false)
, m_minWidth(-1)
, m_maxWidth(-1)
, m_beginMinWidth(0)
@@ -142,16 +147,11 @@
, m_text(str)
, m_firstTextBox(0)
, m_lastTextBox(0)
- , m_hasTab(false)
- , m_linesDirty(false)
- , m_containsReversedText(false)
- , m_isAllASCII(m_text.containsOnlyASCII())
- , m_canUseSimpleFontCodePath(computeCanUseSimpleFontCodePath())
- , m_knownToHaveNoOverflowAndNoFallbackFonts(false)
- , m_needsTranscoding(false)
{
ASSERT(m_text);
+m_isAllASCII = m_text.containsOnlyASCII();
+m_canUseSimpleFontCodePath = computeCanUseSimpleFontCodePath();
setIsText();
view()-frameView()-incrementVisuallyNonEmptyCharacterCount(m_text.length());
Modified: trunk/Source/WebCore/rendering/RenderText.h (115176 => 115177)
--- trunk/Source/WebCore/rendering/RenderText.h 2012-04-25 08:09:40 UTC (rev 115176)
+++ trunk/Source/WebCore/rendering/RenderText.h 2012-04-25 08:18:52 UTC (rev 115177)
@@ -168,16 +168,7 @@
void secureText(UChar mask);
-float m_minWidth; // here to minimize padding in 64-bit.
-float m_maxWidth;
-float m_beginMinWidth;
-float m_endMinWidth;
-
-String m_text;
-
-InlineTextBox* m_firstTextBox;
-InlineTextBox* m_lastTextBox;
-
+// We put the bitfield first to minimize padding on 64-bit.
bool m_hasBreakableChar : 1; // Whether or not we can be broken into multiple lines.
bool m_hasBreak : 1; // Whether or not we have a hard break (e.g., pre with '\n').
bool m_hasTab : 1; // Whether or not we have a variable width tab character (e.g., pre with '\t').
@@ -192,6 +183,16 @@
bool m_canUseSimpleFontCodePath : 1;
mutable bool m_knownToHaveNoOverflowAndNoFallbackFonts : 1;
bool m_needsTranscoding : 1;
+
+float m_minWidth;
+float m_maxWidth;
+float m_beginMinWidth;
+float m_endMinWidth;
+
+String m_text;
+
+InlineTextBox* m_firstTextBox;
+InlineTextBox* m_lastTextBox;
};
inline RenderText* toRenderText(RenderObject* object)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115179] trunk/LayoutTests
Title: [115179] trunk/LayoutTests Revision 115179 Author mnaga...@chromium.org Date 2012-04-25 03:34:52 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update Unmark html5lib/runner.html -- changes that broke it were reverted in r115149. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115178 => 115179) --- trunk/LayoutTests/ChangeLog 2012-04-25 10:05:06 UTC (rev 115178) +++ trunk/LayoutTests/ChangeLog 2012-04-25 10:34:52 UTC (rev 115179) @@ -1,3 +1,11 @@ +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update + +Unmark html5lib/runner.html -- changes that broke it were reverted in r115149. + +* platform/chromium/test_expectations.txt: + 2012-04-25 Sergio Villar Senin svil...@igalia.com Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115178 => 115179) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 10:05:06 UTC (rev 115178) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 10:34:52 UTC (rev 115179) @@ -3737,7 +3737,6 @@ BUGWK83978 WIN MAC: tables/mozilla_expected_failures/collapsing_borders/bug41262-5.html = IMAGE+TEXT BUGWK84802 : fast/js/random-array-gc-stress.html = FAIL TIMEOUT -BUGWK84806 : html5lib/runner.html = TEXT BUGWK84810 LINUX WIN : svg/carto.net/window.svg = IMAGE+TEXT BUGWK84810 MAC : svg/carto.net/window.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115180] trunk/LayoutTests
Title: [115180] trunk/LayoutTests Revision 115180 Author mnaga...@chromium.org Date 2012-04-25 03:40:51 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update https://bugs.webkit.org/show_bug.cgi?id=84813 Mark these tests as failing only on Mac and Windows: css3/filters/custom/custom-filter-shader-cache.html css3/filters/custom/effect-custom-combined-missing.html css3/filters/custom/effect-custom.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115179 => 115180) --- trunk/LayoutTests/ChangeLog 2012-04-25 10:34:52 UTC (rev 115179) +++ trunk/LayoutTests/ChangeLog 2012-04-25 10:40:51 UTC (rev 115180) @@ -1,7 +1,20 @@ 2012-04-25 Mikhail Naganov mnaga...@chromium.org [Chromium] Unreviewed test expectations update +https://bugs.webkit.org/show_bug.cgi?id=84813 +Mark these tests as failing only on Mac and Windows: + +css3/filters/custom/custom-filter-shader-cache.html +css3/filters/custom/effect-custom-combined-missing.html +css3/filters/custom/effect-custom.html + +* platform/chromium/test_expectations.txt: + +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update + Unmark html5lib/runner.html -- changes that broke it were reverted in r115149. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115179 => 115180) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 10:34:52 UTC (rev 115179) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 10:40:51 UTC (rev 115180) @@ -3741,7 +3741,7 @@ BUGWK84810 MAC : svg/carto.net/window.svg = IMAGE // Suppress the errors at the moment, rebaseline coming soon. -BUGWK84813 : css3/filters/custom/custom-filter-shader-cache.html = IMAGE -BUGWK84813 : css3/filters/custom/effect-custom-combined-missing.html = IMAGE +BUGWK84813 MAC WIN : css3/filters/custom/custom-filter-shader-cache.html = IMAGE +BUGWK84813 MAC WIN : css3/filters/custom/effect-custom-combined-missing.html = IMAGE BUGWK84813 : css3/filters/custom/effect-custom-parameters.html = IMAGE -BUGWK84813 : css3/filters/custom/effect-custom.html = IMAGE +BUGWK84813 MAC WIN : css3/filters/custom/effect-custom.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115181] trunk/LayoutTests
Title: [115181] trunk/LayoutTests Revision 115181 Author mnaga...@chromium.org Date 2012-04-25 03:44:33 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update Unmark these tests as failing on Windows: fast/repaint/moving-shadow-on-container.html fast/repaint/moving-shadow-on-path.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115180 => 115181) --- trunk/LayoutTests/ChangeLog 2012-04-25 10:40:51 UTC (rev 115180) +++ trunk/LayoutTests/ChangeLog 2012-04-25 10:44:33 UTC (rev 115181) @@ -1,6 +1,16 @@ 2012-04-25 Mikhail Naganov mnaga...@chromium.org [Chromium] Unreviewed test expectations update + +Unmark these tests as failing on Windows: +fast/repaint/moving-shadow-on-container.html +fast/repaint/moving-shadow-on-path.html + +* platform/chromium/test_expectations.txt: + +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update https://bugs.webkit.org/show_bug.cgi?id=84813 Mark these tests as failing only on Mac and Windows: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115180 => 115181) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 10:40:51 UTC (rev 115180) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 10:44:33 UTC (rev 115181) @@ -3364,8 +3364,6 @@ BUGWK81145 LION : fast/events/scrollbar-double-click.html = TEXT BUGYANGGUO MAC : fast/repaint/moving-shadow-on-container.html = TEXT -BUGYANGGUO WIN : fast/repaint/moving-shadow-on-container.html = TEXT -BUGYANGGUO WIN : fast/repaint/moving-shadow-on-path.html = TEXT BUGWK77368 WIN : css3/flexbox/child-overflow.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115182] trunk/Tools
Title: [115182] trunk/Tools
Revision 115182
Author commit-qu...@webkit.org
Date 2012-04-25 04:01:42 -0700 (Wed, 25 Apr 2012)
Log Message
[BlackBerry] Run tests in '/http/tests/local' with local URI
https://bugs.webkit.org/show_bug.cgi?id=84820
Patch by Xiaobo Wang xbw...@torchmobile.com.cn on 2012-04-25
Reviewed by Nikolas Zimmermann.
Currently we run all tests under folder /http/tests/ as HTTP
tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
'http/tests/local' are run with local path (like '/developer/LayoutTests
/http/tests/local/absolute-url-strip-whitespace.html').
With this patch we can keep the same behaviour as other portings.
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp
Diff
Modified: trunk/Tools/ChangeLog (115181 => 115182)
--- trunk/Tools/ChangeLog 2012-04-25 10:44:33 UTC (rev 115181)
+++ trunk/Tools/ChangeLog 2012-04-25 11:01:42 UTC (rev 115182)
@@ -1,3 +1,19 @@
+2012-04-25 Xiaobo Wang xbw...@torchmobile.com.cn
+
+[BlackBerry] Run tests in '/http/tests/local' with local URI
+https://bugs.webkit.org/show_bug.cgi?id=84820
+
+Reviewed by Nikolas Zimmermann.
+
+Currently we run all tests under folder /http/tests/ as HTTP
+tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
+'http/tests/local' are run with local path (like '/developer/LayoutTests
+/http/tests/local/absolute-url-strip-whitespace.html').
+With this patch we can keep the same behaviour as other portings.
+
+* DumpRenderTree/blackberry/DumpRenderTree.cpp:
+(BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
+
2012-04-25 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
Modified: trunk/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp (115181 => 115182)
--- trunk/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp 2012-04-25 10:44:33 UTC (rev 115181)
+++ trunk/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp 2012-04-25 11:01:42 UTC (rev 115182)
@@ -77,6 +77,7 @@
// FIXME: Assuming LayoutTests has been copied to /developer/LayoutTests/
static const char* const kSDCLayoutTestsURI = file:///developer/LayoutTests/;
static const char* httpTestSyntax = http/tests/;
+static const char* localTestSyntax = local/;
static const char* httpPrefixURL = http://127.0.0.1:8000/;
using namespace std;
@@ -340,7 +341,10 @@
{
if (test.length() strlen(httpTestSyntax))
return false;
-return test.lower().substring(0, strlen(httpTestSyntax)) == httpTestSyntax;
+WTF::String testLower = test.lower();
+int lenHttpTestSyntax = strlen(httpTestSyntax);
+return testLower.substring(0, lenHttpTestSyntax) == httpTestSyntax
+ testLower.substring(lenHttpTestSyntax, strlen(localTestSyntax)) != localTestSyntax;
}
void DumpRenderTree::getTestsToRun()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115183] trunk/LayoutTests
Title: [115183] trunk/LayoutTests Revision 115183 Author mnaga...@chromium.org Date 2012-04-25 04:17:44 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update Remove expectation for a passing test: fast/dom/error-to-string-stack-overflow.html Add an expectation for a passing test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115182 => 115183) --- trunk/LayoutTests/ChangeLog 2012-04-25 11:01:42 UTC (rev 115182) +++ trunk/LayoutTests/ChangeLog 2012-04-25 11:17:44 UTC (rev 115183) @@ -2,6 +2,18 @@ [Chromium] Unreviewed test expectations update +Remove expectation for a passing test: +fast/dom/error-to-string-stack-overflow.html + +Add an expectation for a passing test: +fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html + +* platform/chromium/test_expectations.txt: + +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update + Unmark these tests as failing on Windows: fast/repaint/moving-shadow-on-container.html fast/repaint/moving-shadow-on-path.html Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115182 => 115183) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 11:01:42 UTC (rev 115182) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 11:17:44 UTC (rev 115183) @@ -2139,6 +2139,7 @@ BUGWK45652 : fast/viewport/viewport-127.html = MISSING BUGWK45652 : fast/viewport/viewport-128.html = TIMEOUT TEXT BUGWK45652 : fast/viewport/viewport-129.html = TIMEOUT MISSING TEXT +BUGWK45652 : fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html = PASS BUGWK45737 BUGCR100056 DEBUG : fast/frames/frame-limit.html = TIMEOUT @@ -3613,8 +3614,6 @@ // important. BUG_OJAN SKIP : fast/js/global-constructors.html = FAIL -BUGWK82993 LINUX : fast/dom/error-to-string-stack-overflow.html = TEXT - // This should only be a layer change. BUGWK82129 : fast/box-shadow/shadow-buffer-partial.html = TEXT BUGWK82129 MAC : fast/block/lineboxcontain/block-font.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115184] trunk
Title: [115184] trunk
Revision 115184
Author commit-qu...@webkit.org
Date 2012-04-25 04:36:22 -0700 (Wed, 25 Apr 2012)
Log Message
Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
https://bugs.webkit.org/show_bug.cgi?id=81913
Patch by Philippe Normand pnorm...@igalia.com on 2012-04-25
Reviewed by Tor Arne Vestbø.
Source/WTF:
* WTF.pri: GStreamer build support implies GLib support, as it's
done in WebCore.pri.
Tools:
* qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
and gstreamer-plugins-base = 0.10.30 just like the GTK port
does. 0.10.27 is unfortunately not recent enough to get the media
player working reliably.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf
Diff
Modified: trunk/Source/WTF/ChangeLog (115183 => 115184)
--- trunk/Source/WTF/ChangeLog 2012-04-25 11:17:44 UTC (rev 115183)
+++ trunk/Source/WTF/ChangeLog 2012-04-25 11:36:22 UTC (rev 115184)
@@ -1,3 +1,13 @@
+2012-04-25 Philippe Normand pnorm...@igalia.com
+
+Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
+https://bugs.webkit.org/show_bug.cgi?id=81913
+
+Reviewed by Tor Arne Vestbø.
+
+* WTF.pri: GStreamer build support implies GLib support, as it's
+done in WebCore.pri.
+
2012-04-24 Benjamin Poulain bpoul...@apple.com
Generalize the single character optimization of r114072
Modified: trunk/Source/WTF/WTF.pri (115183 => 115184)
--- trunk/Source/WTF/WTF.pri 2012-04-25 11:17:44 UTC (rev 115183)
+++ trunk/Source/WTF/WTF.pri 2012-04-25 11:36:22 UTC (rev 115184)
@@ -41,11 +41,9 @@
QT += v8-private declarative
}
-linux-*:!contains(DEFINES, USE_QTMULTIMEDIA=1) {
-!contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 gstreamer-0.10): {
-DEFINES += ENABLE_GLIB_SUPPORT=1
-PKGCONFIG += glib-2.0 gio-2.0
-}
+linux-*:contains(DEFINES, WTF_USE_GSTREAMER=1) {
+DEFINES += ENABLE_GLIB_SUPPORT=1
+PKGCONFIG += glib-2.0 gio-2.0
}
win32-* {
Modified: trunk/Tools/ChangeLog (115183 => 115184)
--- trunk/Tools/ChangeLog 2012-04-25 11:17:44 UTC (rev 115183)
+++ trunk/Tools/ChangeLog 2012-04-25 11:36:22 UTC (rev 115184)
@@ -1,3 +1,16 @@
+2012-04-25 Philippe Normand pnorm...@igalia.com
+
+Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
+https://bugs.webkit.org/show_bug.cgi?id=81913
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
+and gstreamer-plugins-base = 0.10.30 just like the GTK port
+does. 0.10.27 is unfortunately not recent enough to get the media
+player working reliably.
+
+
2012-04-25 Xiaobo Wang xbw...@torchmobile.com.cn
[BlackBerry] Run tests in '/http/tests/local' with local URI
Modified: trunk/Tools/qmake/mkspecs/features/features.prf (115183 => 115184)
--- trunk/Tools/qmake/mkspecs/features/features.prf 2012-04-25 11:17:44 UTC (rev 115183)
+++ trunk/Tools/qmake/mkspecs/features/features.prf 2012-04-25 11:36:22 UTC (rev 115184)
@@ -219,7 +219,7 @@
DEFINES += WTF_USE_QTKIT=1
DEFINES -= WTF_USE_QTKIT=0
} else: linux-*:!contains(DEFINES, USE_QTMULTIMEDIA=1) {
-!contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 gstreamer-0.10): {
+!contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 \'gstreamer-0.10 = 0.10.30\' \'gstreamer-plugins-base-0.10 = 0.10.30\'): {
DEFINES -= ENABLE_VIDEO=0
DEFINES += ENABLE_VIDEO=1
DEFINES += WTF_USE_GSTREAMER=1
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115185] trunk/LayoutTests
Title: [115185] trunk/LayoutTests Revision 115185 Author mnaga...@chromium.org Date 2012-04-25 04:46:23 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update Unmark the following CSS pseudo-class tests: fast/css/empty-pseudo-class.html fast/css/first-child-pseudo-class.html fast/css/first-of-type-pseudo-class.html fast/css/last-child-pseudo-class.html fast/css/last-of-type-pseudo-class.html fast/css/only-child-pseudo-class.html fast/css/only-of-type-pseudo-class.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115184 => 115185) --- trunk/LayoutTests/ChangeLog 2012-04-25 11:36:22 UTC (rev 115184) +++ trunk/LayoutTests/ChangeLog 2012-04-25 11:46:23 UTC (rev 115185) @@ -2,6 +2,22 @@ [Chromium] Unreviewed test expectations update +Unmark the following CSS pseudo-class tests: + +fast/css/empty-pseudo-class.html +fast/css/first-child-pseudo-class.html +fast/css/first-of-type-pseudo-class.html +fast/css/last-child-pseudo-class.html +fast/css/last-of-type-pseudo-class.html +fast/css/only-child-pseudo-class.html +fast/css/only-of-type-pseudo-class.html + +* platform/chromium/test_expectations.txt: + +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update + Remove expectation for a passing test: fast/dom/error-to-string-stack-overflow.html Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115184 => 115185) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 11:36:22 UTC (rev 115184) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 11:46:23 UTC (rev 115185) @@ -2516,8 +2516,6 @@ BUGCR76610 WIN DEBUG : canvas/philip/tests/2d.text.draw.align.center.html = PASS TEXT BUGCR76610 MAC WIN DEBUG : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.center.html = PASS TEXT -BUGCR76716 LINUX WIN DEBUG : fast/css/first-child-pseudo-class.html = PASS TEXT - // New in WebKit r81404. Text orientation is wrong and emphasis marks are wrong. BUGCR76616 LINUX WIN : fast/text/emphasis-combined-text.html = IMAGE+TEXT BUGCR76616 LEOPARD : fast/text/emphasis-combined-text.html = IMAGE @@ -2588,7 +2586,6 @@ BUGCR780807 : http/tests/misc/webtiming-origins.html = PASS TEXT BUGCR78835 : plugins/npp-set-window-called-during-destruction.html = TEXT -BUGCR78996 LINUX WIN DEBUG : fast/css/first-of-type-pseudo-class.html = PASS TEXT // http://trac.webkit.org/changeset/83411/ merged some frame tests into one. // The merged test is flaky on Chromium since then. BUGCR78998 DEBUG : fast/frames/frame-element-name.html = PASS TEXT @@ -2611,8 +2608,6 @@ // Flaky, perhaps Skia related. BUGCR79851 LINUX : fast/table/frame-and-rules.html = PASS TEXT -BUGCR79855 LINUX WIN DEBUG : fast/css/only-child-pseudo-class.html = PASS TEXT - BUGCR79857 DEBUG : fast/events/popup-blocking-timers.html = PASS TEXT BUGCR79859 LINUX DEBUG : fast/css/create_element_align.xhtml = PASS TIMEOUT @@ -2624,7 +2619,6 @@ BUGWK58924 MAC : plugins/mouse-click-iframe-to-plugin.html = PASS TIMEOUT BUGWK60099 DEBUG : fast/dom/Attr/access-after-element-destruction.html = PASS CRASH -BUGWK60096 LINUX WIN DEBUG : fast/css/last-child-pseudo-class.html = PASS TEXT BUGWK60097 DEBUG : fast/dom/HTMLLinkElement/link-and-subresource-test.html = PASS TEXT // Looks like some uninitialized memory at the bottom. @@ -2649,7 +2643,6 @@ BUGDPRANKE WIN DEBUG : http/tests/misc/empty-file-formdata.html = PASS TIMEOUT BUGDPRANKE WIN DEBUG : http/tests/xmlhttprequest/access-control-preflight-headers-async.html = PASS TIMEOUT -BUGDPRANKE LINUX WIN DEBUG : fast/css/only-of-type-pseudo-class.html = PASS TEXT // Introduced in r84443 BUGWK59063 : fast/images/animated-gif-restored-from-bfcache.html = TEXT @@ -2693,9 +2686,6 @@ BUGDPRANKE DEBUG : http/tests/misc/window-dot-stop.html = PASS TEXT -// flakiness on the deps bots (noted r~83476) -BUGWK60105 LINUX WIN DEBUG : fast/css/empty-pseudo-class.html = PASS TEXT - // New test added in r85303. BUG_HCLAM : compositing/masks/layer-mask-placement.html = IMAGE @@ -2842,8 +2832,6 @@ BUGCR88230 VISTA : fast/dom/dom-parse-serialize-display.html = PASS TIMEOUT -BUGCR88311 LINUX WIN DEBUG : fast/css/last-of-type-pseudo-class.html = PASS TEXT - // Started around WebKit r90233:r90242 BUGWK64000 DEBUG : fast/events/click-focus-anchor.html = PASS TEXT @@ -2954,26 +2942,6 @@ BUGWK68437 LEOPARD : platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat.html = IMAGE BUGWK68437 LEOPARD : platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender.html = IMAGE -// These should fall under BUGWK68270, but they were
[webkit-changes] [115186] trunk/LayoutTests
Title: [115186] trunk/LayoutTests Revision 115186 Author mnaga...@chromium.org Date 2012-04-25 04:54:46 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update https://bugs.webkit.org/show_bug.cgi?id=84847 Mark inspector/timeline/timeline-start-time.html as flaky on Windows. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115185 => 115186) --- trunk/LayoutTests/ChangeLog 2012-04-25 11:46:23 UTC (rev 115185) +++ trunk/LayoutTests/ChangeLog 2012-04-25 11:54:46 UTC (rev 115186) @@ -1,7 +1,16 @@ 2012-04-25 Mikhail Naganov mnaga...@chromium.org [Chromium] Unreviewed test expectations update +https://bugs.webkit.org/show_bug.cgi?id=84847 +Mark inspector/timeline/timeline-start-time.html as flaky on Windows. + +* platform/chromium/test_expectations.txt: + +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update + Unmark the following CSS pseudo-class tests: fast/css/empty-pseudo-class.html Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115185 => 115186) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 11:46:23 UTC (rev 115185) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 11:54:46 UTC (rev 115186) @@ -3710,3 +3710,5 @@ BUGWK84813 MAC WIN : css3/filters/custom/effect-custom-combined-missing.html = IMAGE BUGWK84813 : css3/filters/custom/effect-custom-parameters.html = IMAGE BUGWK84813 MAC WIN : css3/filters/custom/effect-custom.html = IMAGE + +BUGWK84847 WIN : inspector/timeline/timeline-start-time.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115189] trunk
Title: [115189] trunk
Revision 115189
Author yu...@chromium.org
Date 2012-04-25 05:32:01 -0700 (Wed, 25 Apr 2012)
Log Message
Web Inspector: use composite node provider for diff nodes in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=84849
Inroduced HeapSnapshotDiffNodesProvider which is basically a composite provider
combining providers for added and deleted nodes. This allowed to remove custom
implementation of HeapSnapshotGridNode.prototype.populateChildren.
Source/WebCore:
Reviewed by Pavel Feldman.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByNodeField): moved index assignment to sortByComparator
so that it is done only once.
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByComparator):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNodesProvider):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.dispose):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.isEmpty):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveDeletedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveAddedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind.afterSort):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode._createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html:
* inspector/profiler/heap-snapshot-comparison-show-all.html:
* inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
trunk/LayoutTests/inspector/profiler/heap-snapshot-comparison-show-all.html
trunk/LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js
Diff
Modified: trunk/LayoutTests/ChangeLog (115188 => 115189)
--- trunk/LayoutTests/ChangeLog 2012-04-25 12:25:13 UTC (rev 115188)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 12:32:01 UTC (rev 115189)
@@ -1,3 +1,18 @@
+2012-04-25 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: use composite node provider for diff nodes in heap profiler
+https://bugs.webkit.org/show_bug.cgi?id=84849
+
+Inroduced HeapSnapshotDiffNodesProvider which is basically a composite provider
+combining providers for added and deleted nodes. This allowed to remove custom
+implementation of HeapSnapshotGridNode.prototype.populateChildren.
+
+ Reviewed by Pavel Feldman.
+
+* inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html:
+* inspector/profiler/heap-snapshot-comparison-show-all.html:
+* inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html:
+
2012-04-25 Szilard Ledan szle...@inf.u-szeged.hu
[Qt] Gardening. Skipped a failing test.
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html (115188 => 115189)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html 2012-04-25 12:25:13 UTC (rev 115188)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html 2012-04-25 12:32:01 UTC (rev 115189)
@@ -38,19 +38,10 @@
{
var buttonsNode = InspectorTest.findButtonsNode(row);
InspectorTest.assertEquals(true, !!buttonsNode, no buttons node found!);
-InspectorTest.clickShowMoreButton(showAll, buttonsNode, step3);
+InspectorTest.clickShowMoreButton(showAll, buttonsNode, step4);
}
}
-function step3()
-{
-var row = InspectorTest.findRow(object, B);
-InspectorTest.assertEquals(true,
[webkit-changes] [115190] trunk/LayoutTests
Title: [115190] trunk/LayoutTests Revision 115190 Author mnaga...@chromium.org Date 2012-04-25 06:15:06 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update https://bugs.webkit.org/show_bug.cgi?id=84854 Mark the following tests as flaky on Linux 32-bit: svg/batik/text/textOnPath.svg svg/batik/text/verticalTextOnPath.svg * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115189 => 115190) --- trunk/LayoutTests/ChangeLog 2012-04-25 12:32:01 UTC (rev 115189) +++ trunk/LayoutTests/ChangeLog 2012-04-25 13:15:06 UTC (rev 115190) @@ -1,3 +1,15 @@ +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update +https://bugs.webkit.org/show_bug.cgi?id=84854 + +Mark the following tests as flaky on Linux 32-bit: + +svg/batik/text/textOnPath.svg +svg/batik/text/verticalTextOnPath.svg + +* platform/chromium/test_expectations.txt: + 2012-04-25 Yury Semikhatsky yu...@chromium.org Web Inspector: use composite node provider for diff nodes in heap profiler Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115189 => 115190) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 12:32:01 UTC (rev 115189) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 13:15:06 UTC (rev 115190) @@ -3715,3 +3715,6 @@ BUGWK84813 MAC WIN : css3/filters/custom/effect-custom.html = IMAGE BUGWK84847 WIN : inspector/timeline/timeline-start-time.html = TEXT PASS + +BUGWK84854 LINUX X86 : svg/batik/text/textOnPath.svg = IMAGE PASS +BUGWK84854 LINUX X86 : svg/batik/text/verticalTextOnPath.svg = IMAGE PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115191] trunk
Title: [115191] trunk Revision 115191 Author ves...@webkit.org Date 2012-04-25 06:29:00 -0700 (Wed, 25 Apr 2012) Log Message [Qt] Make the web view's url property follow the active url https://bugs.webkit.org/show_bug.cgi?id=77554 The url property of the webview now reflects the 'active' url of the page, which maps to either the currently loading url, in the case of an ongoing load, or the result of a load, even when the load failed. In practice this means that setting the url though QML, or navigating to a new url in the page by e.g clicking, will both instantly change the url-property of the webview to the target url. This differs from earlier behavior, where we would update the url when the load committed. An optional argument is added to loadHtml(), to allow setting the unreachable url when providing replacement content for failed loads. A slight change in the activeUrl() implementation is also done, where we now favour the url of an pending API request, even when we don't have a mainframe yet. Finally, the location bar in the minibrowser is updated to behave a bit more like normal browsers in terms of when the url will change and how active focus is handled. Reviewed by Simon Hausmann. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h trunk/Source/WebKit2/UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView.pro trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageLoadClient.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageLoadClient.h trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp Added Paths trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/link.html trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/redirect.html Diff Modified: trunk/Source/WebKit2/ChangeLog (115190 => 115191) --- trunk/Source/WebKit2/ChangeLog 2012-04-25 13:15:06 UTC (rev 115190) +++ trunk/Source/WebKit2/ChangeLog 2012-04-25 13:29:00 UTC (rev 115191) @@ -1,3 +1,58 @@ +2012-04-18 Tor Arne Vestbø tor.arne.ves...@nokia.com + +[Qt] Make the web view's url property follow the active url + +https://bugs.webkit.org/show_bug.cgi?id=77554 + +The url property of the webview now reflects the 'active' url of the +page, which maps to either the currently loading url, in the case of +an ongoing load, or the result of a load, even when the load failed. + +In practice this means that setting the url though QML, or navigating +to a new url in the page by e.g clicking, will both instantly change +the url-property of the webview to the target url. This differs from +earlier behavior, where we would update the url when the load +committed. + +An optional argument is added to loadHtml(), to allow setting +the unreachable url when providing replacement content for failed +loads. + +A slight change in the activeUrl() implementation is also done, +where we now favour the url of an pending API request, even when +we don't have a mainframe yet. + +Finally, the location bar in the minibrowser is updated to behave +a bit more like normal browsers in terms of when the url will change +and how active focus is handled. + +Reviewed by Simon Hausmann. + +* UIProcess/API/qt/qquickwebview.cpp: +(QQuickWebViewPrivate::onComponentComplete): +(QQuickWebView::reload): +(QQuickWebView::url): +(QQuickWebView::setUrl): +(QQuickWebView::loadHtml): +* UIProcess/API/qt/qquickwebview_p.h: +* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: +* UIProcess/API/qt/tests/qmltests/WebView.pro: +* UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: +* UIProcess/API/qt/tests/qmltests/common/link.html: Added. +* UIProcess/API/qt/tests/qmltests/common/redirect.html: Added. +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::activeURL): +* UIProcess/qt/QtWebPageLoadClient.cpp: +(QtWebPageLoadClient::QtWebPageLoadClient): +(QtWebPageLoadClient::didStartProvisionalLoadForFrame): +(QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoadForFrame): +(QtWebPageLoadClient::didCommitLoadForFrame): +(QtWebPageLoadClient::dispatchLoadFailed): +(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame): +(QtWebPageLoadClient::didFailLoadWithErrorForFrame): +* UIProcess/qt/QtWebPageLoadClient.h: +
[webkit-changes] [115193] trunk
Title: [115193] trunk
Revision 115193
Author commit-qu...@webkit.org
Date 2012-04-25 06:32:19 -0700 (Wed, 25 Apr 2012)
Log Message
[Qt] Zoom back can overscroll document edges.
https://bugs.webkit.org/show_bug.cgi?id=84851
Patch by Allan Sandfeld Jensen allan.jen...@nokia.com on 2012-04-25
Reviewed by Kenneth Rohde Christiansen.
.:
Manual test for overscroll on zoom-back. Needs to be manual since we do not yet
have automatic testing for this type of UI-side behaviour.
* ManualTests/qt/double-tap-overscroll.html: Added.
Source/WebKit2:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
Added Paths
trunk/ManualTests/qt/double-tap-overscroll.html
Diff
Modified: trunk/ChangeLog (115192 => 115193)
--- trunk/ChangeLog 2012-04-25 13:31:15 UTC (rev 115192)
+++ trunk/ChangeLog 2012-04-25 13:32:19 UTC (rev 115193)
@@ -1,3 +1,15 @@
+2012-04-25 Allan Sandfeld Jensen allan.jen...@nokia.com
+
+[Qt] Zoom back can overscroll document edges.
+https://bugs.webkit.org/show_bug.cgi?id=84851
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Manual test for overscroll on zoom-back. Needs to be manual since we do not yet
+have automatic testing for this type of UI-side behaviour.
+
+* ManualTests/qt/double-tap-overscroll.html: Added.
+
2012-04-24 Yael Aharon yael.aha...@nokia.com
Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2
Added: trunk/ManualTests/qt/double-tap-overscroll.html (0 => 115193)
--- trunk/ManualTests/qt/double-tap-overscroll.html (rev 0)
+++ trunk/ManualTests/qt/double-tap-overscroll.html 2012-04-25 13:32:19 UTC (rev 115193)
@@ -0,0 +1,4 @@
+html
+div style='width:200; height:200; background-color:red;'/div
+pDouble tap the red box twice. The test passes if the viewport remains within document borders.
+/html
\ No newline at end of file
Modified: trunk/Source/WebKit2/ChangeLog (115192 => 115193)
--- trunk/Source/WebKit2/ChangeLog 2012-04-25 13:31:15 UTC (rev 115192)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-25 13:32:19 UTC (rev 115193)
@@ -1,3 +1,13 @@
+2012-04-25 Allan Sandfeld Jensen allan.jen...@nokia.com
+
+[Qt] Zoom back can overscroll document edges.
+https://bugs.webkit.org/show_bug.cgi?id=84851
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
+
2012-04-18 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Make the web view's url property follow the active url
Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (115192 => 115193)
--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2012-04-25 13:31:15 UTC (rev 115192)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp 2012-04-25 13:32:19 UTC (rev 115193)
@@ -415,8 +415,11 @@
case ZoomBack: {
ScaleStackItem lastScale = m_scaleStack.takeLast();
endItemScale = lastScale.scale;
+// Recalculate endPosition and bound it according to new scale.
endPosition.setY(hotspot.y() * endItemScale - viewportHotspot.y());
endPosition.setX(lastScale.xPosition);
+endPosRange = computePosRangeForItemAtScale(endItemScale);
+endPosition = boundPosition(endPosRange.topLeft(), endPosition, endPosRange.bottomRight());
endVisibleContentRect = QRectF(endPosition / endItemScale, viewportRect.size() / endItemScale);
break;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115194] trunk
Title: [115194] trunk Revision 115194 Author pfeld...@chromium.org Date 2012-04-25 06:34:06 -0700 (Wed, 25 Apr 2012) Log Message Source/WebCore: Web Inspector: extract Linkifier from DebuggerPresentationModel. https://bugs.webkit.org/show_bug.cgi?id=84855 Reviewed by Yury Semikhatsky. There is nothing Linkifier needs from the model, extracting as a top-level class. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/compile-front-end.py: * inspector/front-end/ConsoleMessage.js: * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): * inspector/front-end/DebuggerPresentationModel.js: * inspector/front-end/EventListenersSidebarPane.js: * inspector/front-end/Linkifier.js: Added. (WebInspector.LinkifierFormatter): (WebInspector.LinkifierFormatter.prototype.formatLiveAnchor): (WebInspector.Linkifier): (WebInspector.Linkifier.prototype.linkifyLocation): (WebInspector.Linkifier.prototype.linkifyRawLocation): (WebInspector.Linkifier.prototype.reset): (WebInspector.Linkifier.prototype._updateAnchor): (WebInspector.Linkifier.DefaultFormatter): (WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor): * inspector/front-end/NetworkPanel.js: * inspector/front-end/ObjectPopoverHelper.js: (WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.): (WebInspector.ObjectPopoverHelper.prototype._showObjectPopover): * inspector/front-end/ProfileView.js: * inspector/front-end/ScriptsSearchScope.js: (WebInspector.ScriptsSearchResultsPane): * inspector/front-end/TimelinePresentationModel.js: (WebInspector.TimelinePresentationModel): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: Source/WebKit2: [Qt] Make the web view's url property follow the active url https://bugs.webkit.org/show_bug.cgi?id=77554 The url property of the webview now reflects the 'active' url of the page, which maps to either the currently loading url, in the case of an ongoing load, or the result of a load, even when the load failed. In practice this means that setting the url though QML, or navigating to a new url in the page by e.g clicking, will both instantly change the url-property of the webview to the target url. This differs from earlier behavior, where we would update the url when the load committed. An optional argument is added to loadHtml(), to allow setting the unreachable url when providing replacement content for failed loads. A slight change in the activeUrl() implementation is also done, where we now favour the url of an pending API request, even when we don't have a mainframe yet. Finally, the location bar in the minibrowser is updated to behave a bit more like normal browsers in terms of when the url will change and how active focus is handled. Patch by Tor Arne Vestbø tor.arne.ves...@nokia.com on 2012-04-18 Reviewed by Simon Hausmann. * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewPrivate::onComponentComplete): (QQuickWebView::reload): (QQuickWebView::url): (QQuickWebView::setUrl): (QQuickWebView::loadHtml): * UIProcess/API/qt/qquickwebview_p.h: * UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: * UIProcess/API/qt/tests/qmltests/WebView.pro: * UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: * UIProcess/API/qt/tests/qmltests/common/link.html: Added. * UIProcess/API/qt/tests/qmltests/common/redirect.html: Added. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::activeURL): * UIProcess/qt/QtWebPageLoadClient.cpp: (QtWebPageLoadClient::QtWebPageLoadClient): (QtWebPageLoadClient::didStartProvisionalLoadForFrame): (QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoadForFrame): (QtWebPageLoadClient::didCommitLoadForFrame): (QtWebPageLoadClient::dispatchLoadFailed): (QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame): (QtWebPageLoadClient::didFailLoadWithErrorForFrame): * UIProcess/qt/QtWebPageLoadClient.h: (QtWebPageLoadClient): LayoutTests: Web Inspector: extract Linkifier from DebuggerPresentationModel. https://bugs.webkit.org/show_bug.cgi?id=84855 Reviewed by Yury Semikhatsky. * inspector/debugger/linkifier.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/debugger/linkifier.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/compile-front-end.py trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js trunk/Source/WebCore/inspector/front-end/ConsoleView.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/EventListenersSidebarPane.js trunk/Source/WebCore/inspector/front-end/NetworkPanel.js trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js trunk/Source/WebCore/inspector/front-end/ProfileView.js trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc
[webkit-changes] [115195] trunk/Source/WebCore
Title: [115195] trunk/Source/WebCore
Revision 115195
Author pfeld...@chromium.org
Date 2012-04-25 06:36:58 -0700 (Wed, 25 Apr 2012)
Log Message
Not reviewed: follow up to r115194, removed debug output.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (115194 => 115195)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 13:34:06 UTC (rev 115194)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 13:36:58 UTC (rev 115195)
@@ -1,3 +1,10 @@
+2012-04-25 'Pavel Feldman' pfeld...@chromium.org
+
+Not reviewed: follow up to r115194, removed debug output.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
+
2012-04-25 Pavel Feldman pfeld...@chromium.org
Web Inspector: extract Linkifier from DebuggerPresentationModel.
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (115194 => 115195)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-04-25 13:34:06 UTC (rev 115194)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-04-25 13:36:58 UTC (rev 115195)
@@ -107,9 +107,6 @@
var script = /** @type {WebInspector.Script} */ event.data;
this._scriptMapping.addScript(script);
this._addPendingConsoleMessagesToScript(script);
-
-window.myParseds = window.myParseds || [];
-window.myParseds.push(script.sourceURL);
},
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115196] trunk/Source/WebCore
Title: [115196] trunk/Source/WebCore
Revision 115196
Author fmal...@chromium.org
Date 2012-04-25 06:45:14 -0700 (Wed, 25 Apr 2012)
Log Message
[Coverity] Uninitialized fields in RenderSVGShape constructors
https://bugs.webkit.org/show_bug.cgi?id=84749
Reviewed by Darin Adler.
Removing unused RenderSVGShape constructor and field.
No new tests - no behavior change.
* rendering/svg/RenderSVGShape.cpp:
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGShape.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115195 => 115196)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 13:36:58 UTC (rev 115195)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 13:45:14 UTC (rev 115196)
@@ -1,3 +1,18 @@
+2012-04-25 Florin Malita fmal...@chromium.org
+
+[Coverity] Uninitialized fields in RenderSVGShape constructors
+https://bugs.webkit.org/show_bug.cgi?id=84749
+
+Reviewed by Darin Adler.
+
+Removing unused RenderSVGShape constructor and field.
+
+No new tests - no behavior change.
+
+* rendering/svg/RenderSVGShape.cpp:
+* rendering/svg/RenderSVGShape.h:
+(RenderSVGShape):
+
2012-04-25 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: follow up to r115194, removed debug output.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp (115195 => 115196)
--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-04-25 13:36:58 UTC (rev 115195)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-04-25 13:45:14 UTC (rev 115196)
@@ -62,13 +62,6 @@
{
}
-RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node, Path* path, bool isFillFallback)
-: RenderSVGModelObject(node)
-, m_path(adoptPtr(path))
-, m_fillFallback(isFillFallback)
-{
-}
-
RenderSVGShape::~RenderSVGShape()
{
}
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.h (115195 => 115196)
--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.h 2012-04-25 13:36:58 UTC (rev 115195)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.h 2012-04-25 13:45:14 UTC (rev 115196)
@@ -144,7 +144,6 @@
bool m_needsShapeUpdate : 1;
bool m_needsTransformUpdate : 1;
bool m_fillFallback : 1;
-bool m_strokeContainsFallBack : 1;
};
inline RenderSVGShape* toRenderSVGShape(RenderObject* object)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115198] trunk/Source/WebCore
Title: [115198] trunk/Source/WebCore
Revision 115198
Author eric.carl...@apple.com
Date 2012-04-25 06:57:20 -0700 (Wed, 25 Apr 2012)
Log Message
Not reviewed, fix Windows build after r115165.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Initialize logging variable.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115197 => 115198)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 13:48:55 UTC (rev 115197)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 13:57:20 UTC (rev 115198)
@@ -1,3 +1,10 @@
+2012-04-25 Eric Carlson eric.carl...@apple.com
+
+Not reviewed, fix Windows build after r115165.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateCompositingLayers): Initialize logging variable.
+
2012-04-25 Florin Malita fmal...@chromium.org
[Coverity] Uninitialized fields in RenderSVGShape constructors
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (115197 => 115198)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-04-25 13:48:55 UTC (rev 115197)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-04-25 13:57:20 UTC (rev 115198)
@@ -369,7 +369,7 @@
m_reevaluateCompositingAfterLayout = false;
#if !LOG_DISABLED
-double startTime;
+double startTime = 0;
if (compositingLogEnabled()) {
++m_rootLayerUpdateCount;
startTime = currentTime();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115200] trunk/Source
Title: [115200] trunk/Source
Revision 115200
Author gav...@chromium.org
Date 2012-04-25 07:02:08 -0700 (Wed, 25 Apr 2012)
Log Message
Move WebReferrerPolicy.h from WebKit to Platform
https://bugs.webkit.org/show_bug.cgi?id=84539
Reviewed by Adam Barth.
Source/Platform:
* Platform.gypi:
* chromium/public/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
(WebKit):
Source/WebKit/chromium:
* WebKit.gyp:
* public/WebContextMenuData.h:
* public/WebFrame.h:
* public/WebReferrerPolicy.h:
* public/WebSecurityPolicy.h:
* public/platform/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
* src/AssertMatchingEnums.cpp:
Modified Paths
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebContextMenuData.h
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebReferrerPolicy.h
trunk/Source/WebKit/chromium/public/WebSecurityPolicy.h
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
Added Paths
trunk/Source/Platform/chromium/public/WebReferrerPolicy.h
trunk/Source/WebKit/chromium/public/platform/WebReferrerPolicy.h
Diff
Modified: trunk/Source/Platform/ChangeLog (115199 => 115200)
--- trunk/Source/Platform/ChangeLog 2012-04-25 13:59:20 UTC (rev 115199)
+++ trunk/Source/Platform/ChangeLog 2012-04-25 14:02:08 UTC (rev 115200)
@@ -1,3 +1,14 @@
+2012-04-25 Gavin Peters gav...@chromium.org
+
+Move WebReferrerPolicy.h from WebKit to Platform
+https://bugs.webkit.org/show_bug.cgi?id=84539
+
+Reviewed by Adam Barth.
+
+* Platform.gypi:
+* chromium/public/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
+(WebKit):
+
2012-04-24 Yuzhu Shen yzs...@chromium.org
[chromium] Add a description field in WebURLError and show failure description in the inspector network tab.
Modified: trunk/Source/Platform/Platform.gypi (115199 => 115200)
--- trunk/Source/Platform/Platform.gypi 2012-04-25 13:59:20 UTC (rev 115199)
+++ trunk/Source/Platform/Platform.gypi 2012-04-25 14:02:08 UTC (rev 115200)
@@ -75,6 +75,7 @@
'chromium/public/WebPrivateOwnPtr.h',
'chromium/public/WebPrivatePtr.h',
'chromium/public/WebRect.h',
+'chromium/public/WebReferrerPolicy.h',
'chromium/public/WebSessionDescriptionDescriptor.h',
'chromium/public/WebSize.h',
'chromium/public/WebSocketStreamError.h',
Copied: trunk/Source/Platform/chromium/public/WebReferrerPolicy.h (from rev 115199, trunk/Source/WebKit/chromium/public/WebReferrerPolicy.h) (0 => 115200)
--- trunk/Source/Platform/chromium/public/WebReferrerPolicy.h (rev 0)
+++ trunk/Source/Platform/chromium/public/WebReferrerPolicy.h 2012-04-25 14:02:08 UTC (rev 115200)
@@ -0,0 +1,45 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebReferrerPolicy_h
+#define WebReferrerPolicy_h
+
+namespace WebKit {
+
+enum WebReferrerPolicy {
+WebReferrerPolicyAlways,
+WebReferrerPolicyDefault,
+WebReferrerPolicyNever,
+WebReferrerPolicyOrigin,
+};
+
+} // namespace WebKit
+
+#endif
Modified: trunk/Source/WebKit/chromium/ChangeLog (115199 => 115200)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-25 13:59:20 UTC (rev
[webkit-changes] [115201] trunk
Title: [115201] trunk Revision 115201 Author pierre.ro...@gmail.com Date 2012-04-25 07:04:52 -0700 (Wed, 25 Apr 2012) Log Message [SVG] Nothing should be stroked when the stroke-width is 0 https://bugs.webkit.org/show_bug.cgi?id=83568 Reviewed by Nikolas Zimmermann. Source/WebCore: The spec states that A zero value causes no stroke to be painted. We should avoid calling functions that could incorrectly paint something in that case. Test: svg/custom/path-zero-strokewidth.svg * rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasVisibleStroke): * rendering/svg/RenderSVGEllipse.cpp: (WebCore::RenderSVGEllipse::strokeShape): Check if the stroke should be visible before painting. * rendering/svg/RenderSVGRect.cpp: (WebCore::RenderSVGRect::strokeShape): Ditto. * rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::strokeShape): Ditto. (WebCore::RenderSVGShape::strokePath): Ditto. * rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint): Dont call paintText for zero-width stroke. (WebCore::SVGInlineTextBox::paintDecoration): Ditto. LayoutTests: * platform/chromium/test_expectations.txt: mark affected tests for rebaseline. * platform/qt/Skipped: Unskip svg/custom/path-zero-strokewidth.svg Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/qt/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/style/SVGRenderStyle.h trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRect.cpp trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp Diff Modified: trunk/LayoutTests/ChangeLog (115200 => 115201) --- trunk/LayoutTests/ChangeLog 2012-04-25 14:02:08 UTC (rev 115200) +++ trunk/LayoutTests/ChangeLog 2012-04-25 14:04:52 UTC (rev 115201) @@ -1,3 +1,13 @@ +2012-04-25 Pierre Rossi pierre.ro...@gmail.com + +[SVG] Nothing should be stroked when the stroke-width is 0 +https://bugs.webkit.org/show_bug.cgi?id=83568 + +Reviewed by Nikolas Zimmermann. + +* platform/chromium/test_expectations.txt: mark affected tests for rebaseline. +* platform/qt/Skipped: Unskip svg/custom/path-zero-strokewidth.svg + 2012-04-25 Philippe Normand pnorm...@igalia.com Unreviewed, GTK test_expectations update. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115200 => 115201) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 14:02:08 UTC (rev 115200) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 14:04:52 UTC (rev 115201) @@ -3718,3 +3718,7 @@ BUGWK84854 LINUX X86 : svg/batik/text/textOnPath.svg = IMAGE PASS BUGWK84854 LINUX X86 : svg/batik/text/verticalTextOnPath.svg = IMAGE PASS + +// Requires rebaseline after bug 83978 +BUGWK83568 : svg/custom/path-zero-strokewidth.svg = IMAGE +BUGWK83568 : svg/custom/js-update-style.svg = IMAGE Modified: trunk/LayoutTests/platform/qt/Skipped (115200 => 115201) --- trunk/LayoutTests/platform/qt/Skipped 2012-04-25 14:02:08 UTC (rev 115200) +++ trunk/LayoutTests/platform/qt/Skipped 2012-04-25 14:04:52 UTC (rev 115201) @@ -2196,7 +2196,6 @@ fast/writing-mode/vertical-baseline-alignment.html fast/writing-mode/vertical-font-fallback.html svg/css/shadow-changes.svg -svg/custom/path-zero-strokewidth.svg svg/custom/use-invalid-pattern.svg svg/text/bidi-embedded-direction.svg svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg Modified: trunk/Source/WebCore/ChangeLog (115200 => 115201) --- trunk/Source/WebCore/ChangeLog 2012-04-25 14:02:08 UTC (rev 115200) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 14:04:52 UTC (rev 115201) @@ -1,3 +1,29 @@ +2012-04-25 Pierre Rossi pierre.ro...@gmail.com + +[SVG] Nothing should be stroked when the stroke-width is 0 +https://bugs.webkit.org/show_bug.cgi?id=83568 + +Reviewed by Nikolas Zimmermann. + +The spec states that A zero value causes no stroke to be painted. +We should avoid calling functions that could incorrectly paint something +in that case. + +Test: svg/custom/path-zero-strokewidth.svg + +* rendering/style/SVGRenderStyle.h: +(WebCore::SVGRenderStyle::hasVisibleStroke): +* rendering/svg/RenderSVGEllipse.cpp: +(WebCore::RenderSVGEllipse::strokeShape): Check if the stroke should be visible before painting. +* rendering/svg/RenderSVGRect.cpp: +(WebCore::RenderSVGRect::strokeShape): Ditto. +* rendering/svg/RenderSVGShape.cpp: +(WebCore::RenderSVGShape::strokeShape): Ditto. +(WebCore::RenderSVGShape::strokePath): Ditto. +* rendering/svg/SVGInlineTextBox.cpp: +(WebCore::SVGInlineTextBox::paint): Dont call paintText for zero-width stroke. +(WebCore::SVGInlineTextBox::paintDecoration): Ditto. + 2012-04-25 Alexis Menard
[webkit-changes] [115202] trunk/Source
Title: [115202] trunk/Source
Revision 115202
Author commit-qu...@webkit.org
Date 2012-04-25 07:16:29 -0700 (Wed, 25 Apr 2012)
Log Message
[chromium] Animations waiting for a synchronized start time should never be marked finished.
https://bugs.webkit.org/show_bug.cgi?id=84519
Patch by Ian Vollick voll...@chromium.org on 2012-04-25
Reviewed by James Robinson.
Source/WebCore:
Tested in CCLayerAnimationControllerTest.AnimationsWaitingForStartTimeDoNotFinishIfTheyWaitLongerToStartThanTheirDuration
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115201 => 115202)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 14:04:52 UTC (rev 115201)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 14:16:29 UTC (rev 115202)
@@ -1,3 +1,15 @@
+2012-04-25 Ian Vollick voll...@chromium.org
+
+[chromium] Animations waiting for a synchronized start time should never be marked finished.
+https://bugs.webkit.org/show_bug.cgi?id=84519
+
+Reviewed by James Robinson.
+
+Tested in CCLayerAnimationControllerTest.AnimationsWaitingForStartTimeDoNotFinishIfTheyWaitLongerToStartThanTheirDuration
+
+* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
+(WebCore::CCLayerAnimationController::tickAnimations):
+
2012-04-25 Pierre Rossi pierre.ro...@gmail.com
[SVG] Nothing should be stroked when the stroke-width is 0
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp (115201 => 115202)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp 2012-04-25 14:04:52 UTC (rev 115201)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp 2012-04-25 14:16:29 UTC (rev 115202)
@@ -410,7 +410,7 @@
case CCActiveAnimation::Transform: {
const CCTransformAnimationCurve* transformAnimationCurve = m_activeAnimations[i]-curve()-toTransformAnimationCurve();
const TransformationMatrix matrix = transformAnimationCurve-getValue(trimmed, m_client-bounds());
-if (m_activeAnimations[i]-isFinishedAt(monotonicTime))
+if (m_activeAnimations[i]-isFinishedAt(monotonicTime) !m_activeAnimations[i]-needsSynchronizedStartTime())
m_activeAnimations[i]-setRunState(CCActiveAnimation::Finished, monotonicTime);
m_client-setTransformFromAnimation(matrix);
@@ -420,7 +420,7 @@
case CCActiveAnimation::Opacity: {
const CCFloatAnimationCurve* floatAnimationCurve = m_activeAnimations[i]-curve()-toFloatAnimationCurve();
const float opacity = floatAnimationCurve-getValue(trimmed);
-if (m_activeAnimations[i]-isFinishedAt(monotonicTime))
+if (m_activeAnimations[i]-isFinishedAt(monotonicTime) !m_activeAnimations[i]-needsSynchronizedStartTime())
m_activeAnimations[i]-setRunState(CCActiveAnimation::Finished, monotonicTime);
m_client-setOpacityFromAnimation(opacity);
Modified: trunk/Source/WebKit/chromium/ChangeLog (115201 => 115202)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-25 14:04:52 UTC (rev 115201)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-25 14:16:29 UTC (rev 115202)
@@ -1,3 +1,14 @@
+2012-04-25 Ian Vollick voll...@chromium.org
+
+[chromium] Animations waiting for a synchronized start time should never be marked finished.
+https://bugs.webkit.org/show_bug.cgi?id=84519
+
+Reviewed by James Robinson.
+
+* tests/CCLayerAnimationControllerTest.cpp:
+(WebKitTests::TEST):
+(WebKitTests):
+
2012-04-25 Gavin Peters gav...@chromium.org
Move WebReferrerPolicy.h from WebKit to Platform
Modified: trunk/Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp (115201 => 115202)
--- trunk/Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp 2012-04-25 14:04:52 UTC (rev 115201)
+++ trunk/Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp 2012-04-25 14:16:29 UTC (rev 115202)
@@ -217,6 +217,36 @@
EXPECT_FALSE(controller-hasActiveAnimation());
}
+// Tests animations that are waiting for a synchronized start time do not finish.
+TEST(CCLayerAnimationControllerTest, AnimationsWaitingForStartTimeDoNotFinishIfTheyWaitLongerToStartThanTheirDuration)
+{
+OwnPtrCCAnimationEventsVector events(adoptPtr(new CCAnimationEventsVector));
+FakeLayerAnimationControllerClient dummy;
+
[webkit-changes] [115204] trunk/LayoutTests
Title: [115204] trunk/LayoutTests
Revision 115204
Author o...@webkit.org
Date 2012-04-25 07:35:34 -0700 (Wed, 25 Apr 2012)
Log Message
[Qt] Unreviewed gardening. Rebaseline after r115187.
Patch by Ádám Kallai ka...@inf.u-szeged.hu on 2012-04-25
* platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png
trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (115203 => 115204)
--- trunk/LayoutTests/ChangeLog 2012-04-25 14:28:07 UTC (rev 115203)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 14:35:34 UTC (rev 115204)
@@ -1,3 +1,10 @@
+2012-04-25 Ádám Kallai ka...@inf.u-szeged.hu
+
+[Qt] Unreviewed gardening. Rebaseline after r115187.
+
+* platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
+* platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
+
2012-04-25 Pierre Rossi pierre.ro...@gmail.com
[SVG] Nothing should be stroked when the stroke-width is 0
Modified: trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt (115203 => 115204)
--- trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt 2012-04-25 14:28:07 UTC (rev 115203)
+++ trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt 2012-04-25 14:35:34 UTC (rev 115204)
@@ -19,8 +19,7 @@
RenderSVGHiddenContainer {g} at (0,0) size 0x0
RenderSVGEllipse {circle} at (236,11) size 68x68 [stroke={[type=SOLID] [color=#00] [stroke width=5.00]}] [fill={[type=SOLID] [color=#00]}] [cx=180.00] [cy=30.00] [r=20.00]
RenderSVGEllipse {circle} at (236,116) size 68x68 [stroke={[type=SOLID] [color=#00] [stroke width=5.00]}] [fill={[type=SOLID] [color=#00]}] [cx=180.00] [cy=100.00] [r=20.00]
- RenderSVGContainer {g} at (311,11) size 68x68
-RenderSVGEllipse {circle} at (311,11) size 68x68 [stroke={[type=SOLID] [color=#00] [stroke width=5.00]}] [fill={[type=SOLID] [color=#00]}] [cx=230.00] [cy=30.00] [r=20.00]
+ RenderSVGContainer {g} at (0,0) size 0x0
RenderSVGContainer {g} at (311,116) size 68x68
RenderSVGEllipse {circle} at (311,116) size 68x68 [stroke={[type=SOLID] [color=#00] [stroke width=5.00]}] [fill={[type=SOLID] [color=#00]}] [cx=230.00] [cy=100.00] [r=20.00]
RenderSVGText {text} at (385,24) size 51x21 contains 1 chunk(s)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115205] trunk/Source
Title: [115205] trunk/Source
Revision 115205
Author yu...@chromium.org
Date 2012-04-25 07:39:36 -0700 (Wed, 25 Apr 2012)
Log Message
Web Inspector: move HeapSnapshotLoader into a separate file
https://bugs.webkit.org/show_bug.cgi?id=84860
Extracted HeapSnapshotLoader into its own file.
Reviewed by Pavel Feldman.
Source/WebCore:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/HeapSnapshot.js:
* inspector/front-end/HeapSnapshotLoader.js: Added.
(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):
(WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
(WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
Source/WebKit/chromium:
* WebKit.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/inspector/compile-front-end.py
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotWorker.js
trunk/Source/WebCore/inspector/front-end/WebKit.qrc
trunk/Source/WebCore/inspector/front-end/inspector.html
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
Added Paths
trunk/Source/WebCore/inspector/front-end/HeapSnapshotLoader.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (115204 => 115205)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 14:35:34 UTC (rev 115204)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 14:39:36 UTC (rev 115205)
@@ -1,3 +1,26 @@
+2012-04-25 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: move HeapSnapshotLoader into a separate file
+https://bugs.webkit.org/show_bug.cgi?id=84860
+
+Extracted HeapSnapshotLoader into its own file.
+
+Reviewed by Pavel Feldman.
+
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* inspector/compile-front-end.py:
+* inspector/front-end/HeapSnapshot.js:
+* inspector/front-end/HeapSnapshotLoader.js: Added.
+(WebInspector.HeapSnapshotLoader):
+(WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
+(WebInspector.HeapSnapshotLoader.prototype.finishLoading):
+(WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
+(WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
+(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
+* inspector/front-end/WebKit.qrc:
+* inspector/front-end/inspector.html:
+
2012-04-25 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: inspector frontend tests fix.
Modified: trunk/Source/WebCore/WebCore.gypi (115204 => 115205)
--- trunk/Source/WebCore/WebCore.gypi 2012-04-25 14:35:34 UTC (rev 115204)
+++ trunk/Source/WebCore/WebCore.gypi 2012-04-25 14:39:36 UTC (rev 115205)
@@ -6350,6 +6350,7 @@
'inspector/front-end/HeapSnapshot.js',
'inspector/front-end/HeapSnapshotDataGrids.js',
'inspector/front-end/HeapSnapshotGridNodes.js',
+'inspector/front-end/HeapSnapshotLoader.js',
'inspector/front-end/HeapSnapshotProxy.js',
'inspector/front-end/HeapSnapshotView.js',
'inspector/front-end/HeapSnapshotWorker.js',
Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (115204 => 115205)
--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2012-04-25 14:35:34 UTC (rev 115204)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2012-04-25 14:39:36 UTC (rev 115205)
@@ -74033,6 +74033,10 @@
/File
File
+ RelativePath=..\inspector\front-end\HeapSnapshotLoader.js
+
+/File
+File
RelativePath=..\inspector\front-end\HeapSnapshotProxy.js
/File
Modified: trunk/Source/WebCore/inspector/compile-front-end.py (115204 => 115205)
--- trunk/Source/WebCore/inspector/compile-front-end.py 2012-04-25 14:35:34 UTC (rev 115204)
+++ trunk/Source/WebCore/inspector/compile-front-end.py 2012-04-25 14:39:36 UTC (rev 115205)
@@ -292,6 +292,7 @@
HeapSnapshot.js,
HeapSnapshotDataGrids.js,
HeapSnapshotGridNodes.js,
+HeapSnapshotLoader.js,
HeapSnapshotProxy.js,
HeapSnapshotView.js,
HeapSnapshotWorker.js,
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (115204 => 115205)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-04-25 14:35:34 UTC (rev 115204)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-04-25 14:39:36 UTC (rev 115205)
@@ -60,206 +60,6 @@
/**
* @constructor
*/
-WebInspector.HeapSnapshotLoader = function()
-{
-this._json = ;
-this._state = find-snapshot-info;
-
[webkit-changes] [115206] trunk/Source
Title: [115206] trunk/Source
Revision 115206
Author gav...@chromium.org
Date 2012-04-25 07:42:24 -0700 (Wed, 25 Apr 2012)
Log Message
[Chromium] Fix some conditional compilation logic in Platform
https://bugs.webkit.org/show_bug.cgi?id=83798
Reviewed by Darin Fisher.
Source/Platform:
* chromium/public/WebURLError.h:
(WebURLError):
* chromium/public/WebURLRequest.h:
(WebURLRequest):
* chromium/public/WebURLResponse.h:
(WebURLResponse):
Source/WebKit/chromium:
* tests/WebFrameTest.cpp:
(WebKit::TestReloadDoesntRedirectWebFrameClient::cancelledError):
Modified Paths
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebURLError.h
trunk/Source/Platform/chromium/public/WebURLRequest.h
trunk/Source/Platform/chromium/public/WebURLResponse.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp
Diff
Modified: trunk/Source/Platform/ChangeLog (115205 => 115206)
--- trunk/Source/Platform/ChangeLog 2012-04-25 14:39:36 UTC (rev 115205)
+++ trunk/Source/Platform/ChangeLog 2012-04-25 14:42:24 UTC (rev 115206)
@@ -1,5 +1,19 @@
2012-04-25 Gavin Peters gav...@chromium.org
+[Chromium] Fix some conditional compilation logic in Platform
+https://bugs.webkit.org/show_bug.cgi?id=83798
+
+Reviewed by Darin Fisher.
+
+* chromium/public/WebURLError.h:
+(WebURLError):
+* chromium/public/WebURLRequest.h:
+(WebURLRequest):
+* chromium/public/WebURLResponse.h:
+(WebURLResponse):
+
+2012-04-25 Gavin Peters gav...@chromium.org
+
Move WebReferrerPolicy.h from WebKit to Platform
https://bugs.webkit.org/show_bug.cgi?id=84539
Modified: trunk/Source/Platform/chromium/public/WebURLError.h (115205 => 115206)
--- trunk/Source/Platform/chromium/public/WebURLError.h 2012-04-25 14:39:36 UTC (rev 115205)
+++ trunk/Source/Platform/chromium/public/WebURLError.h 2012-04-25 14:42:24 UTC (rev 115206)
@@ -34,7 +34,7 @@
#include WebString.h
#include WebURL.h
-#if defined(WEBKIT_IMPLEMENTATION)
+#if WEBKIT_IMPLEMENTATION
namespace WebCore { class ResourceError; }
#endif
@@ -64,7 +64,7 @@
WebURLError() : reason(0), isCancellation(false) { }
-#if defined(WEBKIT_IMPLEMENTATION)
+#if WEBKIT_IMPLEMENTATION
WebURLError(const WebCore::ResourceError);
WebURLError operator=(const WebCore::ResourceError);
operator WebCore::ResourceError() const;
Modified: trunk/Source/Platform/chromium/public/WebURLRequest.h (115205 => 115206)
--- trunk/Source/Platform/chromium/public/WebURLRequest.h 2012-04-25 14:39:36 UTC (rev 115205)
+++ trunk/Source/Platform/chromium/public/WebURLRequest.h 2012-04-25 14:42:24 UTC (rev 115206)
@@ -34,7 +34,7 @@
#include WebCommon.h
#include WebHTTPBody.h
-#if defined(WEBKIT_IMPLEMENTATION)
+#if WEBKIT_IMPLEMENTATION
namespace WebCore { class ResourceRequest; }
#endif
@@ -182,7 +182,7 @@
WEBKIT_EXPORT ExtraData* extraData() const;
WEBKIT_EXPORT void setExtraData(ExtraData*);
-#if defined(WEBKIT_IMPLEMENTATION)
+#if WEBKIT_IMPLEMENTATION
WebCore::ResourceRequest toMutableResourceRequest();
const WebCore::ResourceRequest toResourceRequest() const;
#endif
Modified: trunk/Source/Platform/chromium/public/WebURLResponse.h (115205 => 115206)
--- trunk/Source/Platform/chromium/public/WebURLResponse.h 2012-04-25 14:39:36 UTC (rev 115205)
+++ trunk/Source/Platform/chromium/public/WebURLResponse.h 2012-04-25 14:42:24 UTC (rev 115206)
@@ -34,7 +34,7 @@
#include WebCommon.h
#include WebPrivateOwnPtr.h
-#if defined(WEBKIT_IMPLEMENTATION)
+#if WEBKIT_IMPLEMENTATION
namespace WebCore { class ResourceResponse; }
#endif
@@ -133,7 +133,7 @@
WEBKIT_EXPORT WebCString securityInfo() const;
WEBKIT_EXPORT void setSecurityInfo(const WebCString);
-#if defined(WEBKIT_IMPLEMENTATION)
+#if WEBKIT_IMPLEMENTATION
WebCore::ResourceResponse toMutableResourceResponse();
const WebCore::ResourceResponse toResourceResponse() const;
#endif
Modified: trunk/Source/WebKit/chromium/ChangeLog (115205 => 115206)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-25 14:39:36 UTC (rev 115205)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-25 14:42:24 UTC (rev 115206)
@@ -1,3 +1,13 @@
+2012-04-25 Gavin Peters gav...@chromium.org
+
+[Chromium] Fix some conditional compilation logic in Platform
+https://bugs.webkit.org/show_bug.cgi?id=83798
+
+Reviewed by Darin Fisher.
+
+* tests/WebFrameTest.cpp:
+(WebKit::TestReloadDoesntRedirectWebFrameClient::cancelledError):
+
2012-04-25 Yury Semikhatsky yu...@chromium.org
Web Inspector: move HeapSnapshotLoader into a separate file
Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (115205 => 115206)
--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-04-25 14:39:36 UTC (rev 115205)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-04-25 14:42:24 UTC (rev 115206)
@@ -273,7 +273,12 @@
[webkit-changes] [115207] trunk/Source/WebCore
Title: [115207] trunk/Source/WebCore Revision 115207 Author commit-qu...@webkit.org Date 2012-04-25 07:52:06 -0700 (Wed, 25 Apr 2012) Log Message [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium https://bugs.webkit.org/show_bug.cgi?id=84542 Patch by Li Yin li@intel.com on 2012-04-25 Reviewed by David Levin. In chromium platform, the default value of m_targetType is ResourceRequest::TargetIsWorker it isn't necessary to call worker-m_scriptLoader-setTargetType(ResourceRequest::TargetIsWorker) again in Worker.cpp In chromium platform, the m_targettype value determines the priority of resource loaded. No new tests because this patch just deletes a repeated code, it can reduce code workload and can't impact any feature. If the target type isn't set correctly, the following test maybe fail because of timeout in the chromium. fast/workers/storage/multiple-transactions-on-different-handles.html fast/workers/storage/multiple-transactions-on-different-handles-sync.html fast/workers/storage/interrupt-database.html * workers/Worker.cpp: (WebCore::Worker::create): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/Worker.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115206 => 115207) --- trunk/Source/WebCore/ChangeLog 2012-04-25 14:42:24 UTC (rev 115206) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 14:52:06 UTC (rev 115207) @@ -1,3 +1,24 @@ +2012-04-25 Li Yin li@intel.com + +[chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium +https://bugs.webkit.org/show_bug.cgi?id=84542 + +Reviewed by David Levin. + +In chromium platform, the default value of m_targetType is ResourceRequest::TargetIsWorker +it isn't necessary to call +worker-m_scriptLoader-setTargetType(ResourceRequest::TargetIsWorker) again in Worker.cpp +In chromium platform, the m_targettype value determines the priority of resource loaded. + +No new tests because this patch just deletes a repeated code, it can reduce code workload and can't impact any feature. +If the target type isn't set correctly, the following test maybe fail because of timeout in the chromium. +fast/workers/storage/multiple-transactions-on-different-handles.html +fast/workers/storage/multiple-transactions-on-different-handles-sync.html +fast/workers/storage/interrupt-database.html + +* workers/Worker.cpp: +(WebCore::Worker::create): + 2012-04-25 Yury Semikhatsky yu...@chromium.org Web Inspector: move HeapSnapshotLoader into a separate file Modified: trunk/Source/WebCore/workers/Worker.cpp (115206 => 115207) --- trunk/Source/WebCore/workers/Worker.cpp 2012-04-25 14:42:24 UTC (rev 115206) +++ trunk/Source/WebCore/workers/Worker.cpp 2012-04-25 14:52:06 UTC (rev 115207) @@ -70,7 +70,7 @@ worker-setPendingActivity(worker.get()); worker-m_scriptLoader = WorkerScriptLoader::create(); -#if PLATFORM(CHROMIUM) || PLATFORM(BLACKBERRY) +#if PLATFORM(BLACKBERRY) worker-m_scriptLoader-setTargetType(ResourceRequest::TargetIsWorker); #endif worker-m_scriptLoader-loadAsynchronously(context, scriptURL, DenyCrossOriginRequests, worker.get()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115208] trunk/LayoutTests
Title: [115208] trunk/LayoutTests
Revision 115208
Author mhahnenb...@apple.com
Date 2012-04-25 08:10:40 -0700 (Wed, 25 Apr 2012)
Log Message
fast/js/random-array-gc-stress times out in debug mode
https://bugs.webkit.org/show_bug.cgi?id=84821
Reviewed by Darin Adler.
* fast/js/script-tests/random-array-gc-stress.js: Reduce number of iterations so
that the test can complete without timing out. Also remove the gc() function because
a gc() function is already provided in resources/js-test-pre.js.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js
Diff
Modified: trunk/LayoutTests/ChangeLog (115207 => 115208)
--- trunk/LayoutTests/ChangeLog 2012-04-25 14:52:06 UTC (rev 115207)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 15:10:40 UTC (rev 115208)
@@ -1,3 +1,14 @@
+2012-04-25 Mark Hahnenberg mhahnenb...@apple.com
+
+fast/js/random-array-gc-stress times out in debug mode
+https://bugs.webkit.org/show_bug.cgi?id=84821
+
+Reviewed by Darin Adler.
+
+* fast/js/script-tests/random-array-gc-stress.js: Reduce number of iterations so
+that the test can complete without timing out. Also remove the gc() function because
+a gc() function is already provided in resources/js-test-pre.js.
+
2012-04-25 Ádám Kallai ka...@inf.u-szeged.hu
[Qt] Unreviewed gardening. Rebaseline after r115187.
Modified: trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js (115207 => 115208)
--- trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js 2012-04-25 14:52:06 UTC (rev 115207)
+++ trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js 2012-04-25 15:10:40 UTC (rev 115208)
@@ -2,15 +2,6 @@
'Tests to randomly modify an object graph of arrays to make sure the GC handles them properly now that it allocates both the JSArray and the ArrayStorage. To pass we need to not crash.'
);
-function gc()
-{
-if (this.GCController)
-GCController.collect();
-else
-for (var i = 0; i 1; ++i) // Allocate a sufficient number of objects to force a GC.
-({});
-}
-
var global = [];
var getRandomIndex = function(length) {
@@ -47,7 +38,7 @@
};
var runs = 0;
-while (runs 40) {
+while (runs 30) {
test();
runs += 1;
global = [];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115211] trunk/LayoutTests
Title: [115211] trunk/LayoutTests Revision 115211 Author mnaga...@chromium.org Date 2012-04-25 08:24:31 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update https://bugs.webkit.org/show_bug.cgi?id=82300 Unmark compositing/images/direct-pdf-image.html as failing on Mac 10.6 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115210 => 115211) --- trunk/LayoutTests/ChangeLog 2012-04-25 15:22:12 UTC (rev 115210) +++ trunk/LayoutTests/ChangeLog 2012-04-25 15:24:31 UTC (rev 115211) @@ -1,3 +1,12 @@ +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update +https://bugs.webkit.org/show_bug.cgi?id=82300 + +Unmark compositing/images/direct-pdf-image.html as failing on Mac 10.6 + +* platform/chromium/test_expectations.txt: + 2012-04-25 Milian Wolff milian.wo...@kdab.com [Qt] add LayoutTestController::setPrinting support to Qt unit tests Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115210 => 115211) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 15:22:12 UTC (rev 115210) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 15:24:31 UTC (rev 115211) @@ -3545,8 +3545,6 @@ BUGWK82297 SNOWLEOPARD : fast/events/platform-wheelevent-paging-y-in-scrolling-page.html = TEXT PASS BUGWK82297 SNOWLEOPARD : fast/events/scrollbar-double-click.html = TEXT PASS -BUGWK82300 SNOWLEOPARD : compositing/images/direct-pdf-image.html = IMAGE - // this test appears to consistently fail during the main run but usually passes on a retry. BUGWK82404 : plugins/netscape-dom-access-and-reload.html = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115212] trunk/Source/WebCore
Title: [115212] trunk/Source/WebCore
Revision 115212
Author commit-qu...@webkit.org
Date 2012-04-25 08:29:36 -0700 (Wed, 25 Apr 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=84875
make-css-file-arrays.pl now only take css files, make it also take js files,
as for html popups we also need load js files.
Reviewed by Antonio Gomes.
* css/make-css-file-arrays.pl:
Patch by Crystal Zhang haizh...@rim.com on 2012-04-25
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/make-css-file-arrays.pl
Diff
Modified: trunk/Source/WebCore/ChangeLog (115211 => 115212)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 15:24:31 UTC (rev 115211)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 15:29:36 UTC (rev 115212)
@@ -1,3 +1,13 @@
+2012-04-25 Crystal Zhang haizh...@rim.com
+https://bugs.webkit.org/show_bug.cgi?id=84875
+
+make-css-file-arrays.pl now only take css files, make it also take js files,
+as for html popups we also need load js files.
+
+Reviewed by Antonio Gomes.
+
+* css/make-css-file-arrays.pl:
+
2012-04-25 Li Yin li@intel.com
[chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium
Modified: trunk/Source/WebCore/css/make-css-file-arrays.pl (115211 => 115212)
--- trunk/Source/WebCore/css/make-css-file-arrays.pl 2012-04-25 15:24:31 UTC (rev 115211)
+++ trunk/Source/WebCore/css/make-css-file-arrays.pl 2012-04-25 15:29:36 UTC (rev 115212)
@@ -41,7 +41,7 @@
print OUT namespace WebCore {\n;
for my $in (@ARGV) {
-$in =~ /(\w+)\.css$/ or die;
+$in =~ /(\w+)\.css$/ or $in =~ /(\w+)\.js$/ or die;
my $name = $1;
# Slurp in the CSS file.
@@ -72,8 +72,13 @@
# Write out a C array of the characters.
my $length = length $text;
-print HEADER extern const char ${name}UserAgentStyleSheet[${length}];\n;
-print OUT extern const char ${name}UserAgentStyleSheet[${length}] = {\n;
+if ($in =~ /(\w+)\.css$/) {
+print HEADER extern const char ${name}UserAgentStyleSheet[${length}];\n;
+print OUT extern const char ${name}UserAgentStyleSheet[${length}] = {\n;
+} else {
+print HEADER extern const char ${name}_javascript_[${length}];\n;
+print OUT extern const char ${name}_javascript_[${length}] = {\n;
+}
my $i = 0;
while ($i $length) {
print OUT ;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115214] trunk/LayoutTests
Title: [115214] trunk/LayoutTests Revision 115214 Author mnaga...@chromium.org Date 2012-04-25 08:37:20 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] Unreviewed test expectations update https://bugs.webkit.org/show_bug.cgi?id=84427 Unmark platform/chromium/editing/spelling/delete-misspelled-word.html as flaky. The test has been fixed in r114866. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115213 => 115214) --- trunk/LayoutTests/ChangeLog 2012-04-25 15:36:22 UTC (rev 115213) +++ trunk/LayoutTests/ChangeLog 2012-04-25 15:37:20 UTC (rev 115214) @@ -1,3 +1,13 @@ +2012-04-25 Mikhail Naganov mnaga...@chromium.org + +[Chromium] Unreviewed test expectations update +https://bugs.webkit.org/show_bug.cgi?id=84427 + +Unmark platform/chromium/editing/spelling/delete-misspelled-word.html as flaky. +The test has been fixed in r114866. + +* platform/chromium/test_expectations.txt: + 2012-04-25 Ádám Kallai ka...@inf.u-szeged.hu [Qt] Unreviewed gardening. Skip a flaky test. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115213 => 115214) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 15:36:22 UTC (rev 115213) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 15:37:20 UTC (rev 115214) @@ -3647,9 +3647,6 @@ BUGWK84125 DEBUG : http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html = CRASH BUGWK84125 DEBUG : http/tests/websocket/tests/hixie76/workers/worker-simple.html = CRASH -BUGWK84427 LINUX DEBUG : platform/chromium/editing/spelling/delete-misspelled-word.html = TIMEOUT -BUGWK84427 MAC WIN DEBUG : platform/chromium/editing/spelling/delete-misspelled-word.html = PASS TIMEOUT - BUGWK84432 WIN : fast/filesystem/op-restricted-names.html = TEXT BUGWK84432 WIN : fast/filesystem/op-restricted-unicode.html = TEXT BUGWK84432 WIN : fast/filesystem/read-directory.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115217] trunk/Source/JavaScriptCore
Title: [115217] trunk/Source/_javascript_Core
Revision 115217
Author msab...@apple.com
Date 2012-04-25 09:11:29 -0700 (Wed, 25 Apr 2012)
Log Message
Closure in try {} with catch captures all locals from the enclosing function
https://bugs.webkit.org/show_bug.cgi?id=84804
Reviewed by Oliver Hunt.
Changed the capturing of local variables from capturing when eval is used,
within a with or within a catch to be just when an eval is used.
Renamed the function returning that we should capture from
getCapturedVariables() to usesEval(), since that what it noew returns.
Needed to fix the with code to only range check when the activation
has actually been torn off. Added m_isTornOff to JSActivation to
track this.
* parser/Parser.h:
(JSC::Scope::usesEval):
(JSC::Scope::getCapturedVariables):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
* runtime/JSActivation.h:
(JSActivation):
(JSC::JSActivation::tearOff):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/runtime/JSActivation.cpp
trunk/Source/_javascript_Core/runtime/JSActivation.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (115216 => 115217)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-25 15:51:45 UTC (rev 115216)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-25 16:11:29 UTC (rev 115217)
@@ -1,3 +1,29 @@
+2012-04-25 Michael Saboff msab...@apple.com
+
+Closure in try {} with catch captures all locals from the enclosing function
+https://bugs.webkit.org/show_bug.cgi?id=84804
+
+Reviewed by Oliver Hunt.
+
+Changed the capturing of local variables from capturing when eval is used,
+within a with or within a catch to be just when an eval is used.
+Renamed the function returning that we should capture from
+getCapturedVariables() to usesEval(), since that what it noew returns.
+Needed to fix the with code to only range check when the activation
+has actually been torn off. Added m_isTornOff to JSActivation to
+track this.
+
+* parser/Parser.h:
+(JSC::Scope::usesEval):
+(JSC::Scope::getCapturedVariables):
+* runtime/JSActivation.cpp:
+(JSC::JSActivation::JSActivation):
+(JSC::JSActivation::symbolTableGet):
+(JSC::JSActivation::symbolTablePut):
+* runtime/JSActivation.h:
+(JSActivation):
+(JSC::JSActivation::tearOff):
+
2012-04-24 Mark Hahnenberg mhahnenb...@apple.com
GC Activity Callback timer should be based on how much has been allocated since the last collection
Modified: trunk/Source/_javascript_Core/parser/Parser.h (115216 => 115217)
--- trunk/Source/_javascript_Core/parser/Parser.h 2012-04-25 15:51:45 UTC (rev 115216)
+++ trunk/Source/_javascript_Core/parser/Parser.h 2012-04-25 16:11:29 UTC (rev 115217)
@@ -162,7 +162,7 @@
ALWAYS_INLINE ScopeFlags usesFlags() const { return m_scopeFlags AllScopeUsesFlags; }
ALWAYS_INLINE void setFlags(ScopeFlags scopeFlags) { m_scopeFlags |= scopeFlags; }
-ALWAYS_INLINE bool needsFullActivation() const { return m_scopeFlags (UsesEvalFlag | UsesWithFlag | UsesCatchFlag); }
+ALWAYS_INLINE bool usesEval() const { return m_scopeFlags UsesEvalFlag; }
ALWAYS_INLINE bool strictMode() const { return m_scopeFlags StrictModeFlag; }
ALWAYS_INLINE bool shadowsArguments() const { return m_scopeFlags ShadowsArgumentsFlag; }
ALWAYS_INLINE bool isFunction() const { return m_scopeFlags FunctionModeFlag; }
@@ -269,7 +269,7 @@
void getCapturedVariables(IdentifierSet capturedVariables)
{
-if (needsFullActivation()) {
+if (usesEval()) {
capturedVariables.swap(m_declaredVariables);
return;
}
Modified: trunk/Source/_javascript_Core/runtime/JSActivation.cpp (115216 => 115217)
--- trunk/Source/_javascript_Core/runtime/JSActivation.cpp 2012-04-25 15:51:45 UTC (rev 115216)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.cpp 2012-04-25 16:11:29 UTC (rev 115217)
@@ -45,6 +45,7 @@
: Base(callFrame-globalData(), callFrame-globalData().activationStructure.get(), functionExecutable-symbolTable(), callFrame-registers())
, m_numCapturedArgs(max(callFrame-argumentCount(), functionExecutable-parameterCount()))
, m_numCapturedVars(functionExecutable-capturedVariableCount())
+, m_isTornOff(false)
, m_requiresDynamicChecks(functionExecutable-usesEval() !functionExecutable-isStrictMode())
, m_argumentsRegister(functionExecutable-generatedBytecode().argumentsRegister())
{
@@ -94,7 +95,7 @@
SymbolTableEntry entry = symbolTable().inlineGet(propertyName.impl());
if (entry.isNull())
return false;
-if (entry.getIndex() = m_numCapturedVars)
+if (m_isTornOff entry.getIndex() = m_numCapturedVars)
return false;
[webkit-changes] [115218] trunk/Tools
Title: [115218] trunk/Tools Revision 115218 Author commit-qu...@webkit.org Date 2012-04-25 09:12:07 -0700 (Wed, 25 Apr 2012) Log Message [EFL] [DRT] Reset text zoom factor before running a test https://bugs.webkit.org/show_bug.cgi?id=84861 Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-04-25 Reviewed by Antonio Gomes. This fix eliminates most of the current flakiness on EFL build bots, although some CSS tests will now need rebasiling. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Diff Modified: trunk/Tools/ChangeLog (115217 => 115218) --- trunk/Tools/ChangeLog 2012-04-25 16:11:29 UTC (rev 115217) +++ trunk/Tools/ChangeLog 2012-04-25 16:12:07 UTC (rev 115218) @@ -1,3 +1,16 @@ +2012-04-25 Thiago Marcos P. Santos thiago.san...@intel.com + +[EFL] [DRT] Reset text zoom factor before running a test +https://bugs.webkit.org/show_bug.cgi?id=84861 + +Reviewed by Antonio Gomes. + +This fix eliminates most of the current flakiness on EFL build +bots, although some CSS tests will now need rebasiling. + +* DumpRenderTree/efl/DumpRenderTreeChrome.cpp: +(DumpRenderTreeChrome::resetDefaultsToConsistentValues): + 2012-04-25 Milian Wolff milian.wo...@kdab.com [Qt] add LayoutTestController::setPrinting support to Qt unit tests Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (115217 => 115218) --- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-04-25 16:11:29 UTC (rev 115217) +++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-04-25 16:12:07 UTC (rev 115218) @@ -224,6 +224,7 @@ ewk_view_zoom_set(mainView(), 1.0, 0, 0); ewk_view_scale_set(mainView(), 1.0, 0, 0); +ewk_view_text_zoom_set(mainView(), 1.0); ewk_history_clear(ewk_view_history_get(mainView())); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115219] trunk/Source
Title: [115219] trunk/Source
Revision 115219
Author pilg...@chromium.org
Date 2012-04-25 09:16:15 -0700 (Wed, 25 Apr 2012)
Log Message
[Chromium] Call actualMemoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84837
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalErrorInV8):
* bindings/v8/V8GCController.cpp:
(WebCore):
* platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore):
* platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
* platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8GCController.cpp
trunk/Source/WebCore/platform/MemoryUsageSupport.cpp
trunk/Source/WebCore/platform/MemoryUsageSupport.h
trunk/Source/WebCore/platform/chromium/MemoryUsageSupportChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115218 => 115219)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 16:12:07 UTC (rev 115218)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 16:16:15 UTC (rev 115219)
@@ -1,3 +1,27 @@
+2012-04-25 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] Call actualMemoryUsageMB directly
+https://bugs.webkit.org/show_bug.cgi?id=84837
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::reportFatalErrorInV8):
+* bindings/v8/V8GCController.cpp:
+(WebCore):
+* platform/MemoryUsageSupport.cpp:
+(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
+(WebCore):
+* platform/MemoryUsageSupport.h:
+(MemoryUsageSupport):
+* platform/chromium/MemoryUsageSupportChromium.cpp:
+(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
+(WebCore):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
2012-04-25 Alexis Menard alexis.men...@openbossa.org
Rename CSSStyleSelector files to StyleResolver.
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (115218 => 115219)
--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-04-25 16:12:07 UTC (rev 115218)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-04-25 16:16:15 UTC (rev 115219)
@@ -36,6 +36,7 @@
#include DocumentLoader.h
#include Frame.h
#include FrameLoaderClient.h
+#include MemoryUsageSupport.h
#include Page.h
#include PageGroup.h
#include RuntimeEnabledFeatures.h
@@ -94,7 +95,7 @@
// FIXME: clean up V8Proxy and disable _javascript_.
int memoryUsageMB = -1;
#if PLATFORM(CHROMIUM)
-memoryUsageMB = PlatformSupport::actualMemoryUsageMB();
+memoryUsageMB = MemoryUsageSupport::actualMemoryUsageMB();
#endif
printf(V8 error: %s (%s). Current memory usage: %d MB\n, message, location, memoryUsageMB);
handleFatalErrorInV8();
Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (115218 => 115219)
--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2012-04-25 16:12:07 UTC (rev 115218)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2012-04-25 16:16:15 UTC (rev 115219)
@@ -478,7 +478,7 @@
int getActualMemoryUsageInMB()
{
#if PLATFORM(CHROMIUM)
-return PlatformSupport::actualMemoryUsageMB();
+return MemoryUsageSupport::actualMemoryUsageMB();
#else
return 0;
#endif
Modified: trunk/Source/WebCore/platform/MemoryUsageSupport.cpp (115218 => 115219)
--- trunk/Source/WebCore/platform/MemoryUsageSupport.cpp 2012-04-25 16:12:07 UTC (rev 115218)
+++ trunk/Source/WebCore/platform/MemoryUsageSupport.cpp 2012-04-25 16:16:15 UTC (rev 115219)
@@ -38,4 +38,9 @@
return 0;
}
+int MemoryUsageSupport::actualMemoryUsageMB()
+{
+return 0;
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/MemoryUsageSupport.h (115218 => 115219)
--- trunk/Source/WebCore/platform/MemoryUsageSupport.h 2012-04-25 16:12:07 UTC (rev 115218)
+++ trunk/Source/WebCore/platform/MemoryUsageSupport.h 2012-04-25 16:16:15 UTC (rev 115219)
@@ -38,6 +38,10 @@
// Returns the current space allocated for the pagefile, in MB.
// That is committed size for Windows and virtual memory size for POSIX.
static int memoryUsageMB();
+
+// Same as above, but always returns actual value, without any
+// caches.
+static int actualMemoryUsageMB();
};
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/chromium/MemoryUsageSupportChromium.cpp (115218 => 115219)
---
[webkit-changes] [115220] trunk/Source/WebCore
Title: [115220] trunk/Source/WebCore Revision 115220 Author eric.carl...@apple.com Date 2012-04-25 09:28:02 -0700 (Wed, 25 Apr 2012) Log Message Not reviewed, attempt to fix Windows build after r115215. * css/CSSAllInOne.cpp: Don't try to include CSSStyleSelector.cpp. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSAllInOne.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115219 => 115220) --- trunk/Source/WebCore/ChangeLog 2012-04-25 16:16:15 UTC (rev 115219) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 16:28:02 UTC (rev 115220) @@ -1,3 +1,9 @@ +2012-04-25 Eric Carlson eric.carl...@apple.com + +Not reviewed, attempt to fix Windows build after r115215. + +* css/CSSAllInOne.cpp: Don't try to include CSSStyleSelector.cpp. + 2012-04-25 Mark Pilgrim pilg...@chromium.org [Chromium] Call actualMemoryUsageMB directly Modified: trunk/Source/WebCore/css/CSSAllInOne.cpp (115219 => 115220) --- trunk/Source/WebCore/css/CSSAllInOne.cpp 2012-04-25 16:16:15 UTC (rev 115219) +++ trunk/Source/WebCore/css/CSSAllInOne.cpp 2012-04-25 16:28:02 UTC (rev 115220) @@ -59,7 +59,6 @@ #include CSSSelectorList.cpp #include CSSStyleDeclaration.cpp #include CSSStyleRule.cpp -#include CSSStyleSelector.cpp #include CSSStyleSheet.cpp #include CSSTimingFunctionValue.cpp #include CSSUnicodeRangeValue.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115221] trunk/Source/WebCore
Title: [115221] trunk/Source/WebCore Revision 115221 Author alexis.men...@openbossa.org Date 2012-04-25 09:46:59 -0700 (Wed, 25 Apr 2012) Log Message Not reviewed, fix Windows build after r115215. * css/CSSAllInOne.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSAllInOne.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115220 => 115221) --- trunk/Source/WebCore/ChangeLog 2012-04-25 16:28:02 UTC (rev 115220) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 16:46:59 UTC (rev 115221) @@ -1,3 +1,9 @@ +2012-04-25 Alexis Menard alexis.men...@openbossa.org + +Not reviewed, fix Windows build after r115215. + +* css/CSSAllInOne.cpp: + 2012-04-25 Eric Carlson eric.carl...@apple.com Not reviewed, attempt to fix Windows build after r115215. Modified: trunk/Source/WebCore/css/CSSAllInOne.cpp (115220 => 115221) --- trunk/Source/WebCore/css/CSSAllInOne.cpp 2012-04-25 16:28:02 UTC (rev 115220) +++ trunk/Source/WebCore/css/CSSAllInOne.cpp 2012-04-25 16:46:59 UTC (rev 115221) @@ -56,6 +56,7 @@ #include CSSRule.cpp #include CSSRuleList.cpp #include CSSSegmentedFontFace.cpp +#include CSSSelector.cpp #include CSSSelectorList.cpp #include CSSStyleDeclaration.cpp #include CSSStyleRule.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115222] trunk
Title: [115222] trunk
Revision 115222
Author commit-qu...@webkit.org
Date 2012-04-25 10:04:04 -0700 (Wed, 25 Apr 2012)
Log Message
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880
Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-04-25
Reviewed by Antonio Gomes.
Tools:
Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):
LayoutTests:
Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.
* platform/efl/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (115221 => 115222)
--- trunk/LayoutTests/ChangeLog 2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 17:04:04 UTC (rev 115222)
@@ -1,3 +1,15 @@
+2012-04-25 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com
+
+[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
+https://bugs.webkit.org/show_bug.cgi?id=83880
+
+Reviewed by Antonio Gomes.
+
+Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
+and removeOriginAccessWhitelistEntry implementation.
+
+* platform/efl/Skipped:
+
2012-04-25 Thiago Marcos P. Santos thiago.san...@intel.com
[EFL] Remove duplicated test expectations
Modified: trunk/LayoutTests/platform/efl/Skipped (115221 => 115222)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-25 17:04:04 UTC (rev 115222)
@@ -2119,7 +2119,6 @@
http/tests/security/cross-origin-xsl-redirect-BLOCKED.html
http/tests/security/drag-drop-same-unique-origin.html
http/tests/security/frameNavigation/not-opener.html
-http/tests/security/local-image-from-remote-whitelisted.html
http/tests/security/local-user-CSS-from-remote.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
@@ -2156,11 +2155,6 @@
http/tests/xmlhttprequest/cross-origin-no-authorization.html
http/tests/xmlhttprequest/failed-auth.html
http/tests/xmlhttprequest/logout.html
-http/tests/xmlhttprequest/origin-whitelisting-all.html
-http/tests/xmlhttprequest/origin-whitelisting-exact-match.html
-http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html
-http/tests/xmlhttprequest/origin-whitelisting-removal.html
-http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
http/tests/xmlhttprequest/remember-bad-password.html
http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
http/tests/xmlviewer/extensions-api.html
Modified: trunk/Tools/ChangeLog (115221 => 115222)
--- trunk/Tools/ChangeLog 2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/Tools/ChangeLog 2012-04-25 17:04:04 UTC (rev 115222)
@@ -1,3 +1,18 @@
+2012-04-25 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com
+
+[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
+https://bugs.webkit.org/show_bug.cgi?id=83880
+
+Reviewed by Antonio Gomes.
+
+Add missing implementation addOriginAccessWhitelistEntry and
+removeOriginAccessWhitelistEntry to EFL's LayoutTestController
+in order to unskip tests which rely on this.
+
+* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+(LayoutTestController::addOriginAccessWhitelistEntry):
+(LayoutTestController::removeOriginAccessWhitelistEntry):
+
2012-04-25 Thiago Marcos P. Santos thiago.san...@intel.com
[EFL] [DRT] Reset text zoom factor before running a test
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (115221 => 115222)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-25 17:04:04 UTC (rev 115222)
@@ -223,14 +223,22 @@
notImplemented();
}
-void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef, JSStringRef, JSStringRef, bool)
+void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef protocol, JSStringRef host, bool includeSubdomains)
{
-notImplemented();
+WebCore::KURL kurl;
+kurl.setProtocol(String(protocol-characters(), protocol-length()));
+
[webkit-changes] [115223] trunk
Title: [115223] trunk
Revision 115223
Author jap...@chromium.org
Date 2012-04-25 10:12:20 -0700 (Wed, 25 Apr 2012)
Log Message
Source/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
https://bugs.webkit.org/show_bug.cgi?id=83918
Reviewed by Alexey Proskuryakov.
Test: http/tests/xmlhttprequest/cancel-during-failure-crash.html
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFail): Set m_calledDidFinishLoad when calling
didFailToLoad() to prevent it from getting called twice if we cancel
re-entrantly.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83918.
Reviewed by Alexey Proskuryakov.
* http/tests/cache/cancel-during-failure-crash-expected.txt: Added.
* http/tests/cache/cancel-during-failure-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/ResourceLoader.h
Added Paths
trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash-expected.txt
trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (115222 => 115223)
--- trunk/LayoutTests/ChangeLog 2012-04-25 17:04:04 UTC (rev 115222)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 17:12:20 UTC (rev 115223)
@@ -1,3 +1,12 @@
+2012-04-25 Nate Chapin jap...@chromium.org
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=83918.
+
+Reviewed by Alexey Proskuryakov.
+
+* http/tests/cache/cancel-during-failure-crash-expected.txt: Added.
+* http/tests/cache/cancel-during-failure-crash.html: Added.
+
2012-04-25 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
Added: trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash-expected.txt (0 => 115223)
--- trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash-expected.txt 2012-04-25 17:12:20 UTC (rev 115223)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash.html (0 => 115223)
--- trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash.html (rev 0)
+++ trunk/LayoutTests/http/tests/cache/cancel-during-failure-crash.html 2012-04-25 17:12:20 UTC (rev 115223)
@@ -0,0 +1,22 @@
+html
+body
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var img = new Image();
+img._onerror_ = function() {
+// cancel resource load within didFail()
+window.stop();
+document.body.appendChild(document.createTextNode(PASS));
+layoutTestController.notifyDone();
+}
+
+// Port 7 will likely refuse the connection, causing a didFail()
+// from the network stack.
+img.src = ""
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (115222 => 115223)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 17:04:04 UTC (rev 115222)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 17:12:20 UTC (rev 115223)
@@ -1,3 +1,17 @@
+2012-04-25 Nate Chapin jap...@chromium.org
+
+REGRESSION (r100311): YummySoup app crashes when trying to print
+https://bugs.webkit.org/show_bug.cgi?id=83918
+
+Reviewed by Alexey Proskuryakov.
+
+Test: http/tests/xmlhttprequest/cancel-during-failure-crash.html
+
+* loader/ResourceLoader.cpp:
+(WebCore::ResourceLoader::didFail): Set m_calledDidFinishLoad when calling
+ didFailToLoad() to prevent it from getting called twice if we cancel
+ re-entrantly.
+
2012-04-25 Alexis Menard alexis.men...@openbossa.org
Not reviewed, fix Windows build after r115215.
Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (115222 => 115223)
--- trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-04-25 17:04:04 UTC (rev 115222)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-04-25 17:12:20 UTC (rev 115223)
@@ -60,7 +60,7 @@
, m_reachedTerminalState(false)
, m_calledWillCancel(false)
, m_cancelled(false)
-, m_calledDidFinishLoad(false)
+, m_notifiedLoadComplete(false)
, m_defersLoading(frame-page()-defersLoading())
, m_options(options)
{
@@ -304,9 +304,9 @@
return;
ASSERT(!m_reachedTerminalState);
-if (m_calledDidFinishLoad)
+if (m_notifiedLoadComplete)
return;
-m_calledDidFinishLoad = true;
+m_notifiedLoadComplete = true;
if (m_options.sendLoadCallbacks == SendCallbacks)
frameLoader()-notifier()-didFinishLoad(this, finishTime);
}
@@ -324,8 +324,11 @@
if (FormData* data = ""
data-removeGeneratedFilesIfNeeded();
-if (m_options.sendLoadCallbacks == SendCallbacks !m_calledDidFinishLoad)
-
[webkit-changes] [115224] tags/Safari-536.8.1/
Title: [115224] tags/Safari-536.8.1/ Revision 115224 Author lforsch...@apple.com Date 2012-04-25 10:13:49 -0700 (Wed, 25 Apr 2012) Log Message New Tag. Added Paths tags/Safari-536.8.1/ Diff Property changes: tags/Safari-536.8.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115225] tags/Safari-536.8.1/Source
Title: [115225] tags/Safari-536.8.1/Source Revision 115225 Author lforsch...@apple.com Date 2012-04-25 10:16:03 -0700 (Wed, 25 Apr 2012) Log Message Versioning. Modified Paths tags/Safari-536.8.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-536.8.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-536.8.1/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-536.8.1/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-536.8.1/Source/_javascript_Core/Configurations/Version.xcconfig (115224 => 115225) --- tags/Safari-536.8.1/Source/_javascript_Core/Configurations/Version.xcconfig 2012-04-25 17:13:49 UTC (rev 115224) +++ tags/Safari-536.8.1/Source/_javascript_Core/Configurations/Version.xcconfig 2012-04-25 17:16:03 UTC (rev 115225) @@ -23,8 +23,8 @@ MAJOR_VERSION = 536; MINOR_VERSION = 8; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-536.8.1/Source/WebCore/Configurations/Version.xcconfig (115224 => 115225) --- tags/Safari-536.8.1/Source/WebCore/Configurations/Version.xcconfig 2012-04-25 17:13:49 UTC (rev 115224) +++ tags/Safari-536.8.1/Source/WebCore/Configurations/Version.xcconfig 2012-04-25 17:16:03 UTC (rev 115225) @@ -23,8 +23,8 @@ MAJOR_VERSION = 536; MINOR_VERSION = 8; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-536.8.1/Source/WebKit/mac/Configurations/Version.xcconfig (115224 => 115225) --- tags/Safari-536.8.1/Source/WebKit/mac/Configurations/Version.xcconfig 2012-04-25 17:13:49 UTC (rev 115224) +++ tags/Safari-536.8.1/Source/WebKit/mac/Configurations/Version.xcconfig 2012-04-25 17:16:03 UTC (rev 115225) @@ -23,8 +23,8 @@ MAJOR_VERSION = 536; MINOR_VERSION = 8; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-536.8.1/Source/WebKit2/Configurations/Version.xcconfig (115224 => 115225) --- tags/Safari-536.8.1/Source/WebKit2/Configurations/Version.xcconfig 2012-04-25 17:13:49 UTC (rev 115224) +++ tags/Safari-536.8.1/Source/WebKit2/Configurations/Version.xcconfig 2012-04-25 17:16:03 UTC (rev 115225) @@ -23,8 +23,8 @@ MAJOR_VERSION = 536; MINOR_VERSION = 8; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115226] trunk/Source
Title: [115226] trunk/Source
Revision 115226
Author commit-qu...@webkit.org
Date 2012-04-25 10:32:24 -0700 (Wed, 25 Apr 2012)
Log Message
[chromium] Do not clobber synchronized start times.
https://bugs.webkit.org/show_bug.cgi?id=84605
Patch by Ian Vollick voll...@chromium.org on 2012-04-25
Reviewed by James Robinson.
Source/WebCore:
Tested in CCLayerAnimationControllerTest.doNotClobberStartTimes
(WebCore):
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::hasSetStartTime):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
Source/WebKit/chromium:
* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests):
(WebKitTests::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115225 => 115226)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 17:16:03 UTC (rev 115225)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 17:32:24 UTC (rev 115226)
@@ -1,3 +1,20 @@
+2012-04-25 Ian Vollick voll...@chromium.org
+
+[chromium] Do not clobber synchronized start times.
+https://bugs.webkit.org/show_bug.cgi?id=84605
+
+Reviewed by James Robinson.
+
+Tested in CCLayerAnimationControllerTest.doNotClobberStartTimes
+
+(WebCore):
+* platform/graphics/chromium/cc/CCActiveAnimation.h:
+(CCActiveAnimation):
+(WebCore::CCActiveAnimation::hasSetStartTime):
+* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
+(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
+(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
+
2012-04-25 Nate Chapin jap...@chromium.org
REGRESSION (r100311): YummySoup app crashes when trying to print
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h (115225 => 115226)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h 2012-04-25 17:16:03 UTC (rev 115225)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h 2012-04-25 17:32:24 UTC (rev 115226)
@@ -82,6 +82,7 @@
double startTime() const { return m_startTime; }
void setStartTime(double startTime) { m_startTime = startTime; }
+bool hasSetStartTime() const { return m_startTime; }
bool isFinishedAt(double time) const;
bool isFinished() const { return m_runState == Finished || m_runState == Aborted; }
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp (115225 => 115226)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp 2012-04-25 17:16:03 UTC (rev 115225)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp 2012-04-25 17:32:24 UTC (rev 115226)
@@ -277,7 +277,8 @@
for (size_t i = 0; i m_activeAnimations.size(); ++i) {
if (m_activeAnimations[i]-runState() == CCActiveAnimation::WaitingForNextTick) {
m_activeAnimations[i]-setRunState(CCActiveAnimation::Running, monotonicTime);
-m_activeAnimations[i]-setStartTime(monotonicTime);
+if (!m_activeAnimations[i]-hasSetStartTime())
+m_activeAnimations[i]-setStartTime(monotonicTime);
if (events)
events-append(CCAnimationStartedEvent(m_client-id(), m_activeAnimations[i]-group(), m_activeAnimations[i]-targetProperty(), monotonicTime));
}
@@ -326,13 +327,15 @@
// If the intersection is null, then we are free to start the animations in the group.
if (nullIntersection) {
m_activeAnimations[i]-setRunState(CCActiveAnimation::Running, monotonicTime);
-m_activeAnimations[i]-setStartTime(monotonicTime);
+if (!m_activeAnimations[i]-hasSetStartTime())
+m_activeAnimations[i]-setStartTime(monotonicTime);
if (events)
events-append(CCAnimationStartedEvent(m_client-id(), m_activeAnimations[i]-group(), m_activeAnimations[i]-targetProperty(), monotonicTime));
for (size_t j = i + 1; j m_activeAnimations.size(); ++j) {
if (m_activeAnimations[i]-group() == m_activeAnimations[j]-group()) {
m_activeAnimations[j]-setRunState(CCActiveAnimation::Running, monotonicTime);
-m_activeAnimations[j]-setStartTime(monotonicTime);
+if (!m_activeAnimations[j]-hasSetStartTime())
+
[webkit-changes] [115227] trunk
Title: [115227] trunk Revision 115227 Author rn...@webkit.org Date 2012-04-25 10:44:29 -0700 (Wed, 25 Apr 2012) Log Message REGRESSION(r112177): listStyleType CSS property gets converted into listStyle https://bugs.webkit.org/show_bug.cgi?id=83026 Reviewed by Darin Adler. Source/WebCore: Fixed the bug by not using shorthand notations when some values are missing. However, we still want to return a value when shorthand border property is explicitly requested so extract borderPropertyValue with a flag to support both behaviors. * css/StylePropertySet.cpp: (WebCore::borderPropertyValue): Extracted from getPropertyValue. (WebCore::StylePropertySet::getPropertyValue): (WebCore::StylePropertySet::get4Values): Don't return values when priority don't match. (WebCore::StylePropertySet::getShorthandValue): (WebCore::StylePropertySet::getCommonValue): Don't return null string for initial values to disambiguate missing values and initial in getPropertyValue. Also check propriety. (WebCore::StylePropertySet::asText): Support emitting border-width, border-style, and border-color when border doesn't work but the former properties do. LayoutTests: Added test cases to cssText-shorthand.html and rebaselined some tests. * fast/css/cssText-shorthand-expected.txt: * fast/css/cssText-shorthand.html: Added more test cases. * fast/css/remove-shorthand-expected.txt: Correctly adds both border-width and border-style when border-color is missing. * printing/page-rule-css-text-expected.txt: Correctly uses border-width instead of border. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt trunk/LayoutTests/fast/css/cssText-shorthand.html trunk/LayoutTests/fast/css/remove-shorthand-expected.txt trunk/LayoutTests/printing/page-rule-css-text-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StylePropertySet.cpp trunk/Source/WebCore/css/StylePropertySet.h Diff Modified: trunk/LayoutTests/ChangeLog (115226 => 115227) --- trunk/LayoutTests/ChangeLog 2012-04-25 17:32:24 UTC (rev 115226) +++ trunk/LayoutTests/ChangeLog 2012-04-25 17:44:29 UTC (rev 115227) @@ -1,3 +1,18 @@ +2012-04-24 Ryosuke Niwa rn...@webkit.org + +REGRESSION(r112177): listStyleType CSS property gets converted into listStyle +https://bugs.webkit.org/show_bug.cgi?id=83026 + +Reviewed by Darin Adler. + +Added test cases to cssText-shorthand.html and rebaselined some tests. + +* fast/css/cssText-shorthand-expected.txt: +* fast/css/cssText-shorthand.html: Added more test cases. +* fast/css/remove-shorthand-expected.txt: Correctly adds both border-width and border-style +when border-color is missing. +* printing/page-rule-css-text-expected.txt: Correctly uses border-width instead of border. + 2012-04-25 Nate Chapin jap...@chromium.org Test for https://bugs.webkit.org/show_bug.cgi?id=83918. Modified: trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt (115226 => 115227) --- trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt 2012-04-25 17:32:24 UTC (rev 115226) +++ trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt 2012-04-25 17:44:29 UTC (rev 115227) @@ -8,18 +8,21 @@ PASS normalizeCssText(element.style.cssText) is border: 1px red PASS normalizeCssText(element.style.cssText) is border: red PASS normalizeCssText(element.style.cssText) is border: 1px -PASS normalizeCssText(element.style.cssText) is border-bottom-width: 3px; border-left-width: 4px; border-right-width: 2px; border-top-width: 1px -PASS normalizeCssText(element.style.cssText) is border-bottom-width: 1px; border-left-width: 1px; border-right-width: 1px; border-top-width: 2px +PASS normalizeCssText(element.style.cssText) is border-width: 1px 2px 3px 4px +PASS normalizeCssText(element.style.cssText) is border-width: 2px 1px 1px PASS normalizeCssText(element.style.cssText) is border-bottom-width: 1px; border-left-width: 1px; border-right-width: 1px; border-top-width: 1px !important -PASS normalizeCssText(element.style.cssText) is border-bottom-width: 1px; border-left-width: 1px; border-right-width: 1px; border-top-color: red; border-top-width: 1px +PASS normalizeCssText(element.style.cssText) is border-top-color: red; border-width: 1px PASS normalizeCssText(element.style.cssText) is border: dotted +PASS normalizeCssText(element.style.cssText) is border-width: 1px PASS normalizeCssText(element.style.cssText) is border-spacing: 1px 2px PASS normalizeCssText(element.style.cssText) is font-family: sans-serif; font-size: 3em; font-style: italic; font-weight: bold; line-height: 2em PASS normalizeCssText(element.style.cssText) is list-style: circle inside PASS normalizeCssText(element.style.cssText) is margin: 1px 2px 3px 4px PASS normalizeCssText(element.style.cssText) is outline: blue dotted 2px FAIL normalizeCssText(element.style.cssText) should be overflow: scroll hidden. Was overflow-x: scroll; overflow-y:
[webkit-changes] [115228] trunk/Source/WebCore
Title: [115228] trunk/Source/WebCore Revision 115228 Author hara...@chromium.org Date 2012-04-25 10:58:19 -0700 (Wed, 25 Apr 2012) Log Message [V8] Make the Isolate* parameter non-optional in setDOMException() https://bugs.webkit.org/show_bug.cgi?id=84736 Reviewed by Nate Chapin. Now all setDOMException() callers pass Isolate* to setDOMException(). This patch makes the Isolate* parameter non-optional. No tests. No change in behavior. * bindings/v8/V8Proxy.h: (V8Proxy): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/V8Proxy.h Diff Modified: trunk/Source/WebCore/ChangeLog (115227 => 115228) --- trunk/Source/WebCore/ChangeLog 2012-04-25 17:44:29 UTC (rev 115227) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 17:58:19 UTC (rev 115228) @@ -1,3 +1,18 @@ +2012-04-25 Kentaro Hara hara...@chromium.org + +[V8] Make the Isolate* parameter non-optional in setDOMException() +https://bugs.webkit.org/show_bug.cgi?id=84736 + +Reviewed by Nate Chapin. + +Now all setDOMException() callers pass Isolate* to setDOMException(). +This patch makes the Isolate* parameter non-optional. + +No tests. No change in behavior. + +* bindings/v8/V8Proxy.h: +(V8Proxy): + 2012-04-24 Ryosuke Niwa rn...@webkit.org REGRESSION(r112177): listStyleType CSS property gets converted into listStyle Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.h (115227 => 115228) --- trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-04-25 17:44:29 UTC (rev 115227) +++ trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-04-25 17:58:19 UTC (rev 115228) @@ -235,7 +235,7 @@ // If the exception code is different from zero, a DOM exception is // schedule to be thrown. -static void setDOMException(int exceptionCode, v8::Isolate* = 0); +static void setDOMException(int exceptionCode, v8::Isolate*); // Schedule an error object to be thrown. static v8::Handlev8::Value throwError(ErrorType, const char* message, v8::Isolate* = 0); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115229] trunk/Source/WebCore
Title: [115229] trunk/Source/WebCore
Revision 115229
Author hara...@chromium.org
Date 2012-04-25 11:07:34 -0700 (Wed, 25 Apr 2012)
Log Message
[V8] Add m_isolate to SerializedScriptValue::Writer
and SerializedScriptValue::Reader
https://bugs.webkit.org/show_bug.cgi?id=84739
Reviewed by Nate Chapin.
This is the second step to pass Isolate around
in SerializedScriptValue. This patch adds m_isolate to
SerializedScriptValue::Writer and SerializedScriptValue::Reader,
so that they can use the isolate around. The fix is safe since
Writer and Reader are guaranteed to be used by one Isolate.
No tests. No change in behavior.
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115228 => 115229)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 17:58:19 UTC (rev 115228)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 18:07:34 UTC (rev 115229)
@@ -1,5 +1,32 @@
2012-04-25 Kentaro Hara hara...@chromium.org
+[V8] Add m_isolate to SerializedScriptValue::Writer
+and SerializedScriptValue::Reader
+https://bugs.webkit.org/show_bug.cgi?id=84739
+
+Reviewed by Nate Chapin.
+
+This is the second step to pass Isolate around
+in SerializedScriptValue. This patch adds m_isolate to
+SerializedScriptValue::Writer and SerializedScriptValue::Reader,
+so that they can use the isolate around. The fix is safe since
+Writer and Reader are guaranteed to be used by one Isolate.
+
+No tests. No change in behavior.
+
+* bindings/v8/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::create):
+(WebCore::SerializedScriptValue::nullValue):
+(WebCore::SerializedScriptValue::undefinedValue):
+(WebCore::SerializedScriptValue::booleanValue):
+(WebCore::SerializedScriptValue::numberValue):
+(WebCore::SerializedScriptValue::SerializedScriptValue):
+(WebCore::SerializedScriptValue::deserialize):
+* bindings/v8/SerializedScriptValue.h:
+(SerializedScriptValue):
+
+2012-04-25 Kentaro Hara hara...@chromium.org
+
[V8] Make the Isolate* parameter non-optional in setDOMException()
https://bugs.webkit.org/show_bug.cgi?id=84736
Modified: trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp (115228 => 115229)
--- trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp 2012-04-25 17:58:19 UTC (rev 115228)
+++ trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp 2012-04-25 18:07:34 UTC (rev 115229)
@@ -274,8 +274,9 @@
class Writer {
WTF_MAKE_NONCOPYABLE(Writer);
public:
-Writer()
+Writer(v8::Isolate* isolate)
: m_position(0)
+, m_isolate(isolate)
{
}
@@ -591,6 +592,7 @@
VectorBufferValueType m_buffer;
unsigned m_position;
+v8::Isolate* m_isolate;
};
class Serializer {
@@ -1222,11 +1224,12 @@
// restoring information about saved objects of composite types.
class Reader {
public:
-Reader(const uint8_t* buffer, int length)
+Reader(const uint8_t* buffer, int length, v8::Isolate* isolate)
: m_buffer(buffer)
, m_length(length)
, m_position(0)
, m_version(0)
+, m_isolate(isolate)
{
ASSERT(length = 0);
}
@@ -1802,6 +1805,7 @@
const unsigned m_length;
unsigned m_position;
uint32_t m_version;
+v8::Isolate* m_isolate;
};
@@ -2081,7 +2085,7 @@
PassRefPtrSerializedScriptValue SerializedScriptValue::create(const String data, v8::Isolate* isolate)
{
-Writer writer;
+Writer writer(isolate);
writer.writeWebCoreString(data);
String wireData = StringImpl::adopt(writer.data());
return adoptRef(new SerializedScriptValue(wireData));
@@ -2092,13 +2096,13 @@
return adoptRef(new SerializedScriptValue());
}
-SerializedScriptValue* SerializedScriptValue::nullValue()
+SerializedScriptValue* SerializedScriptValue::nullValue(v8::Isolate* isolate)
{
// FIXME: This is not thread-safe. Move caching to callers.
// https://bugs.webkit.org/show_bug.cgi?id=70833
DEFINE_STATIC_LOCAL(RefPtrSerializedScriptValue, nullValue, (0));
if (!nullValue) {
-Writer writer;
+Writer writer(isolate);
writer.writeNull();
String wireData = StringImpl::adopt(writer.data());
nullValue = adoptRef(new SerializedScriptValue(wireData));
@@ -2108,7 +2112,7
[webkit-changes] [115230] trunk
Title: [115230] trunk
Revision 115230
Author commit-qu...@webkit.org
Date 2012-04-25 11:12:07 -0700 (Wed, 25 Apr 2012)
Log Message
Unreviewed, rolling out r115222.
http://trac.webkit.org/changeset/115222
https://bugs.webkit.org/show_bug.cgi?id=84874
Caused test regressions on the EFL build (Requested by rakuco
on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-04-25
Tools:
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):
LayoutTests:
* platform/efl/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (115229 => 115230)
--- trunk/LayoutTests/ChangeLog 2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 18:12:07 UTC (rev 115230)
@@ -1,3 +1,14 @@
+2012-04-25 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r115222.
+http://trac.webkit.org/changeset/115222
+https://bugs.webkit.org/show_bug.cgi?id=84874
+
+Caused test regressions on the EFL build (Requested by rakuco
+on #webkit).
+
+* platform/efl/Skipped:
+
2012-04-24 Ryosuke Niwa rn...@webkit.org
REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
Modified: trunk/LayoutTests/platform/efl/Skipped (115229 => 115230)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-25 18:12:07 UTC (rev 115230)
@@ -2119,6 +2119,7 @@
http/tests/security/cross-origin-xsl-redirect-BLOCKED.html
http/tests/security/drag-drop-same-unique-origin.html
http/tests/security/frameNavigation/not-opener.html
+http/tests/security/local-image-from-remote-whitelisted.html
http/tests/security/local-user-CSS-from-remote.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
@@ -2155,6 +2156,11 @@
http/tests/xmlhttprequest/cross-origin-no-authorization.html
http/tests/xmlhttprequest/failed-auth.html
http/tests/xmlhttprequest/logout.html
+http/tests/xmlhttprequest/origin-whitelisting-all.html
+http/tests/xmlhttprequest/origin-whitelisting-exact-match.html
+http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html
+http/tests/xmlhttprequest/origin-whitelisting-removal.html
+http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
http/tests/xmlhttprequest/remember-bad-password.html
http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
http/tests/xmlviewer/extensions-api.html
Modified: trunk/Tools/ChangeLog (115229 => 115230)
--- trunk/Tools/ChangeLog 2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/Tools/ChangeLog 2012-04-25 18:12:07 UTC (rev 115230)
@@ -1,3 +1,16 @@
+2012-04-25 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r115222.
+http://trac.webkit.org/changeset/115222
+https://bugs.webkit.org/show_bug.cgi?id=84874
+
+Caused test regressions on the EFL build (Requested by rakuco
+on #webkit).
+
+* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+(LayoutTestController::addOriginAccessWhitelistEntry):
+(LayoutTestController::removeOriginAccessWhitelistEntry):
+
2012-04-25 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (115229 => 115230)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-25 18:12:07 UTC (rev 115230)
@@ -223,22 +223,14 @@
notImplemented();
}
-void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef protocol, JSStringRef host, bool includeSubdomains)
+void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef, JSStringRef, JSStringRef, bool)
{
-WebCore::KURL kurl;
-kurl.setProtocol(String(protocol-characters(), protocol-length()));
-kurl.setHost(String(host-characters(), host-length()));
-
-ewk_security_policy_whitelist_origin_add(sourceOrigin-ustring().utf8().data(), kurl.string().utf8().data(), includeSubdomains);
+notImplemented();
}
-void LayoutTestController::removeOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef protocol, JSStringRef host, bool includeSubdomains)
+void LayoutTestController::removeOriginAccessWhitelistEntry(JSStringRef, JSStringRef, JSStringRef, bool)
{
-WebCore::KURL kurl;
-kurl.setProtocol(String(protocol-characters(), protocol-length()));
-kurl.setHost(String(host-characters(), host-length()));
-
[webkit-changes] [115231] trunk/Source/WebCore
Title: [115231] trunk/Source/WebCore Revision 115231 Author hara...@chromium.org Date 2012-04-25 11:14:12 -0700 (Wed, 25 Apr 2012) Log Message [V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm https://bugs.webkit.org/show_bug.cgi?id=84753 Reviewed by Nate Chapin. The objective is to pass Isolate around in V8 bindings. This patch passes Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm. Tests: bindings/scripts/test/TestObj.idl bindings/scripts/test/TestSerializedScriptValueInterface.idl * bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrSetter): (GenerateParametersCheck): (JSValueToNative): * bindings/scripts/test/V8/V8TestObj.cpp: Updated run-bindings-tests results. (WebCore::TestObjV8Internal::intSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::longSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter): (WebCore::TestObjV8Internal::serializedValueCallback): * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter): (WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter): (WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback): (WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback): (WebCore::V8TestSerializedScriptValueInterface::constructorCallback): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115230 => 115231) --- trunk/Source/WebCore/ChangeLog 2012-04-25 18:12:07 UTC (rev 115230) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 18:14:12 UTC (rev 115231) @@ -1,5 +1,46 @@ 2012-04-25 Kentaro Hara hara...@chromium.org +[V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm +https://bugs.webkit.org/show_bug.cgi?id=84753 + +Reviewed by Nate Chapin. + +The objective is to pass Isolate around in V8 bindings. +This patch passes Isolate to SerializedScriptValue::create() +in CodeGeneratorV8.pm. + +Tests: bindings/scripts/test/TestObj.idl + bindings/scripts/test/TestSerializedScriptValueInterface.idl + +* bindings/scripts/CodeGeneratorV8.pm: +(GenerateNormalAttrSetter): +(GenerateParametersCheck): +(JSValueToNative): + +* bindings/scripts/test/V8/V8TestObj.cpp: Updated run-bindings-tests results. +(WebCore::TestObjV8Internal::intSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::longSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter): +(WebCore::TestObjV8Internal::serializedValueCallback): +* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: +(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter): +(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter): +(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback): +(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback): +(WebCore::V8TestSerializedScriptValueInterface::constructorCallback): + +2012-04-25 Kentaro Hara hara...@chromium.org + [V8] Add m_isolate to SerializedScriptValue::Writer and SerializedScriptValue::Reader
[webkit-changes] [115232] trunk/LayoutTests
Title: [115232] trunk/LayoutTests Revision 115232 Author hc...@chromium.org Date 2012-04-25 11:21:16 -0700 (Wed, 25 Apr 2012) Log Message Unreviewed test expectations update. https://bugs.webkit.org/show_bug.cgi?id=84877 Mark a failing test after changes in r115227. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115231 => 115232) --- trunk/LayoutTests/ChangeLog 2012-04-25 18:14:12 UTC (rev 115231) +++ trunk/LayoutTests/ChangeLog 2012-04-25 18:21:16 UTC (rev 115232) @@ -1,3 +1,12 @@ +2012-04-25 Alpha Lam hc...@chromium.org + +Unreviewed test expectations update. +https://bugs.webkit.org/show_bug.cgi?id=84877 + +Mark a failing test after changes in r115227. + +* platform/chromium/test_expectations.txt: + 2012-04-25 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r115222. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115231 => 115232) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 18:14:12 UTC (rev 115231) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 18:21:16 UTC (rev 115232) @@ -3714,3 +3714,5 @@ // Requires rebaseline after bug 83978 BUGWK83568 : svg/custom/path-zero-strokewidth.svg = IMAGE BUGWK83568 : svg/custom/js-update-style.svg = IMAGE + +BUGWK84877 : fast/css/getPropertyValue-border.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115233] trunk/Source/WebCore
Title: [115233] trunk/Source/WebCore
Revision 115233
Author hara...@chromium.org
Date 2012-04-25 11:38:48 -0700 (Wed, 25 Apr 2012)
Log Message
[V8] Pass Isolate to SerializedScriptValue::create() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=84757
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to SerializedScriptValue::create()
in custom bindings.
No tests. No change in behavior.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115232 => 115233)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 18:38:48 UTC (rev 115233)
@@ -1,5 +1,30 @@
2012-04-25 Kentaro Hara hara...@chromium.org
+[V8] Pass Isolate to SerializedScriptValue::create() in custom bindings
+https://bugs.webkit.org/show_bug.cgi?id=84757
+
+Reviewed by Nate Chapin.
+
+The objective is to pass Isolate around in V8 bindings.
+This patch passes Isolate to SerializedScriptValue::create()
+in custom bindings.
+
+No tests. No change in behavior.
+
+* bindings/v8/custom/V8DOMWindowCustom.cpp:
+(WebCore::handlePostMessageCallback):
+* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
+(WebCore::handlePostMessageCallback):
+* bindings/v8/custom/V8HistoryCustom.cpp:
+(WebCore::V8History::pushStateCallback):
+(WebCore::V8History::replaceStateCallback):
+* bindings/v8/custom/V8MessagePortCustom.cpp:
+(WebCore::handlePostMessageCallback):
+* bindings/v8/custom/V8WorkerCustom.cpp:
+(WebCore::handlePostMessageCallback):
+
+2012-04-25 Kentaro Hara hara...@chromium.org
+
[V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84753
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -336,7 +336,8 @@
SerializedScriptValue::create(args[0],
portArray,
extendedTransfer ? arrayBufferArray : 0,
- didThrow);
+ didThrow,
+ args.GetIsolate());
if (didThrow)
return v8::Undefined();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -57,7 +57,8 @@
SerializedScriptValue::create(args[0],
ports,
extendedTransfer ? arrayBuffers : 0,
- didThrow);
+ didThrow,
+ args.GetIsolate());
if (didThrow)
return v8::Undefined();
ExceptionCode ec = 0;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -62,7 +62,7 @@
v8::Handlev8::Value V8History::pushStateCallback(const v8::Arguments args)
{
bool didThrow = false;
-RefPtrSerializedScriptValue historyState = SerializedScriptValue::create(args[0], 0, 0, didThrow);
+RefPtrSerializedScriptValue historyState = SerializedScriptValue::create(args[0], 0, 0, didThrow, args.GetIsolate());
if (didThrow)
return v8::Undefined();
@@ -87,7 +87,7 @@
v8::Handlev8::Value V8History::replaceStateCallback(const v8::Arguments
[webkit-changes] [115234] trunk/Source/WebCore
Title: [115234] trunk/Source/WebCore Revision 115234 Author hara...@chromium.org Date 2012-04-25 11:57:29 -0700 (Wed, 25 Apr 2012) Log Message [V8] Pass Isolate to SerializedScriptValue::deserialize() https://bugs.webkit.org/show_bug.cgi?id=84758 Reviewed by Nate Chapin. The objective is to pass Isolate around. This patch passes Isolate to SerializedScriptValue::deserialize(). No tests. No change in behavior. * bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::stateAccessorGetter): * bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::dataAccessorGetter): * bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::stateAccessorGetter): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115233 => 115234) --- trunk/Source/WebCore/ChangeLog 2012-04-25 18:38:48 UTC (rev 115233) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 18:57:29 UTC (rev 115234) @@ -1,5 +1,26 @@ 2012-04-25 Kentaro Hara hara...@chromium.org +[V8] Pass Isolate to SerializedScriptValue::deserialize() +https://bugs.webkit.org/show_bug.cgi?id=84758 + +Reviewed by Nate Chapin. + +The objective is to pass Isolate around. This patch passes +Isolate to SerializedScriptValue::deserialize(). + +No tests. No change in behavior. + +* bindings/v8/custom/V8HistoryCustom.cpp: +(WebCore::V8History::stateAccessorGetter): +* bindings/v8/custom/V8IDBAnyCustom.cpp: +(WebCore::toV8): +* bindings/v8/custom/V8MessageEventCustom.cpp: +(WebCore::V8MessageEvent::dataAccessorGetter): +* bindings/v8/custom/V8PopStateEventCustom.cpp: +(WebCore::V8PopStateEvent::stateAccessorGetter): + +2012-04-25 Kentaro Hara hara...@chromium.org + [V8] Pass Isolate to SerializedScriptValue::create() in custom bindings https://bugs.webkit.org/show_bug.cgi?id=84757 Modified: trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp (115233 => 115234) --- trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233) +++ trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-04-25 18:57:29 UTC (rev 115234) @@ -53,7 +53,7 @@ return value; SerializedScriptValue* serialized = history-state(); -value = serialized ? serialized-deserialize() : v8::Handlev8::Value(v8::Null()); +value = serialized ? serialized-deserialize(0, info.GetIsolate()) : v8::Handlev8::Value(v8::Null()); info.Holder()-SetHiddenValue(V8HiddenPropertyName::state(), value); return value; Modified: trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp (115233 => 115234) --- trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233) +++ trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp 2012-04-25 18:57:29 UTC (rev 115234) @@ -73,7 +73,7 @@ case IDBAny::IDBTransactionType: return toV8(impl-idbTransaction()); case IDBAny::SerializedScriptValueType: -return impl-serializedScriptValue()-deserialize(); +return impl-serializedScriptValue()-deserialize(0, isolate); } ASSERT_NOT_REACHED(); Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp (115233 => 115234) --- trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233) +++ trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp 2012-04-25 18:57:29 UTC (rev 115234) @@ -61,7 +61,7 @@ case MessageEvent::DataTypeSerializedScriptValue: if (SerializedScriptValue* serializedValue = event-dataAsSerializedScriptValue()) -result = serializedValue-deserialize(event-ports()); +result = serializedValue-deserialize(event-ports(), info.GetIsolate()); else result = v8::Null(); break; Modified: trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp (115233 => 115234) --- trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233) +++ trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp 2012-04-25 18:57:29 UTC (rev 115234) @@ -79,10 +79,10 @@ if (!result.IsEmpty()) return cacheState(info.Holder(), result); } -result = event-serializedState()-deserialize(); +result = event-serializedState()-deserialize(0, info.GetIsolate()); v8History-SetHiddenValue(V8HiddenPropertyName::state(), result); } else -result = event-serializedState()-deserialize(); +result =
[webkit-changes] [115236] trunk
Title: [115236] trunk
Revision 115236
Author jap...@chromium.org
Date 2012-04-25 12:31:42 -0700 (Wed, 25 Apr 2012)
Log Message
Source/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
https://bugs.webkit.org/show_bug.cgi?id=83632
Reviewed by Eric Seidel.
Test: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83632.
Reviewed by Eric Seidel.
* http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
Added Paths
trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt
trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (115235 => 115236)
--- trunk/LayoutTests/ChangeLog 2012-04-25 19:26:50 UTC (rev 115235)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 19:31:42 UTC (rev 115236)
@@ -1,3 +1,12 @@
+2012-04-25 Nate Chapin jap...@chromium.org
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=83632.
+
+Reviewed by Eric Seidel.
+
+* http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
+* http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.
+
2012-04-25 Andrew Scherkus scher...@chromium.org
Rebaseline Chromium media layout tests due to r114957.
Added: trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt (0 => 115236)
--- trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt 2012-04-25 19:31:42 UTC (rev 115236)
@@ -0,0 +1,7 @@
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/access-control-basic-denied.cgi. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/access-control-basic-denied.cgi. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/access-control-basic-denied.cgi. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/access-control-basic-denied.cgi. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/access-control-basic-denied.cgi. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/access-control-basic-denied.cgi. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+PASS
Added: trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html (0 => 115236)
--- trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html (rev 0)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html 2012-04-25 19:31:42 UTC (rev 115236)
@@ -0,0 +1,37 @@
+base href=""
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var requestCount = 0;
+
+function preflightRequest() {
+var xhr = new XMLHttpRequest();
+xhr._onsuccess_ = function() { finish(FAIL); }
+xhr._onerror_ = function() {
+if (requestCount == 5) {
+finish(PASS);
+return;
+}
+requestCount++;
+// This hack of showing and hiding the inspector greatly increases the likelihood
+// that references to the CachedResource underlying the XHR get cleaned out.
+if (window.layoutTestController) {
+layoutTestController.showWebInspector();
+layoutTestController.closeWebInspector();
+}
+preflightRequest();
+}
+xhr.open(GET, xmlhttprequest/resources/access-control-basic-denied.cgi);
+xhr.send();
+}
+
+function finish(result) {
+document.body.appendChild(document.createTextNode(result));
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+/script
+body _onload_=preflightRequest()/body
Modified:
[webkit-changes] [115237] trunk
Title: [115237] trunk Revision 115237 Author fpi...@apple.com Date 2012-04-25 12:53:28 -0700 (Wed, 25 Apr 2012) Log Message http://bellard.org/jslinux/ triggers an assertion failure in the DFG JIT https://bugs.webkit.org/show_bug.cgi?id=84815 rdar://problem/11319514 Source/_javascript_Core: Reviewed by Gavin Barraclough. * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::forwardSpeculationCheck): LayoutTests: Rubber stamped by Gavin Barraclough. * fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt: Added. * fast/js/dfg-uint32-to-number-on-captured-variable.html: Added. * fast/js/jsc-test-list: * fast/js/script-tests/dfg-uint32-to-number-on-captured-variable.js: Added. (foo): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/js/jsc-test-list trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h Added Paths trunk/LayoutTests/fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt trunk/LayoutTests/fast/js/dfg-uint32-to-number-on-captured-variable.html trunk/LayoutTests/fast/js/script-tests/dfg-uint32-to-number-on-captured-variable.js Diff Modified: trunk/LayoutTests/ChangeLog (115236 => 115237) --- trunk/LayoutTests/ChangeLog 2012-04-25 19:31:42 UTC (rev 115236) +++ trunk/LayoutTests/ChangeLog 2012-04-25 19:53:28 UTC (rev 115237) @@ -1,3 +1,17 @@ +2012-04-25 Filip Pizlo fpi...@apple.com + +http://bellard.org/jslinux/ triggers an assertion failure in the DFG JIT +https://bugs.webkit.org/show_bug.cgi?id=84815 +rdar://problem/11319514 + +Rubber stamped by Gavin Barraclough. + +* fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt: Added. +* fast/js/dfg-uint32-to-number-on-captured-variable.html: Added. +* fast/js/jsc-test-list: +* fast/js/script-tests/dfg-uint32-to-number-on-captured-variable.js: Added. +(foo): + 2012-04-25 Nate Chapin jap...@chromium.org Test for https://bugs.webkit.org/show_bug.cgi?id=83632. Added: trunk/LayoutTests/fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt (0 => 115237) --- trunk/LayoutTests/fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt (rev 0) +++ trunk/LayoutTests/fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt 2012-04-25 19:53:28 UTC (rev 115237) @@ -0,0 +1,109 @@ +Tests that storing the result of a uint32 to number conversion into a captured variable does not crash the compiler. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS foo(0)() is 0 +PASS foo(1)() is 1 +PASS foo(2)() is 2 +PASS foo(3)() is 3 +PASS foo(4)() is 4 +PASS foo(5)() is 5 +PASS foo(6)() is 6 +PASS foo(7)() is 7 +PASS foo(8)() is 8 +PASS foo(9)() is 9 +PASS foo(10)() is 10 +PASS foo(11)() is 11 +PASS foo(12)() is 12 +PASS foo(13)() is 13 +PASS foo(14)() is 14 +PASS foo(15)() is 15 +PASS foo(16)() is 16 +PASS foo(17)() is 17 +PASS foo(18)() is 18 +PASS foo(19)() is 19 +PASS foo(20)() is 20 +PASS foo(21)() is 21 +PASS foo(22)() is 22 +PASS foo(23)() is 23 +PASS foo(24)() is 24 +PASS foo(25)() is 25 +PASS foo(26)() is 26 +PASS foo(27)() is 27 +PASS foo(28)() is 28 +PASS foo(29)() is 29 +PASS foo(30)() is 30 +PASS foo(31)() is 31 +PASS foo(32)() is 32 +PASS foo(33)() is 33 +PASS foo(34)() is 34 +PASS foo(35)() is 35 +PASS foo(36)() is 36 +PASS foo(37)() is 37 +PASS foo(38)() is 38 +PASS foo(39)() is 39 +PASS foo(40)() is 40 +PASS foo(41)() is 41 +PASS foo(42)() is 42 +PASS foo(43)() is 43 +PASS foo(44)() is 44 +PASS foo(45)() is 45 +PASS foo(46)() is 46 +PASS foo(47)() is 47 +PASS foo(48)() is 48 +PASS foo(49)() is 49 +PASS foo(50)() is 50 +PASS foo(51)() is 51 +PASS foo(52)() is 52 +PASS foo(53)() is 53 +PASS foo(54)() is 54 +PASS foo(55)() is 55 +PASS foo(56)() is 56 +PASS foo(57)() is 57 +PASS foo(58)() is 58 +PASS foo(59)() is 59 +PASS foo(60)() is 60 +PASS foo(61)() is 61 +PASS foo(62)() is 62 +PASS foo(63)() is 63 +PASS foo(64)() is 64 +PASS foo(65)() is 65 +PASS foo(66)() is 66 +PASS foo(67)() is 67 +PASS foo(68)() is 68 +PASS foo(69)() is 69 +PASS foo(70)() is 70 +PASS foo(71)() is 71 +PASS foo(72)() is 72 +PASS foo(73)() is 73 +PASS foo(74)() is 74 +PASS foo(75)() is 75 +PASS foo(76)() is 76 +PASS foo(77)() is 77 +PASS foo(78)() is 78 +PASS foo(79)() is 79 +PASS foo(80)() is 80 +PASS foo(81)() is 81 +PASS foo(82)() is 82 +PASS foo(83)() is 83 +PASS foo(84)() is 84 +PASS foo(85)() is 85 +PASS foo(86)() is 86 +PASS foo(87)() is 87 +PASS foo(88)() is 88 +PASS foo(89)() is 89 +PASS foo(90)() is 90 +PASS foo(91)() is 91 +PASS foo(92)() is 92 +PASS foo(93)() is 93 +PASS foo(94)() is 94 +PASS foo(95)() is 95 +PASS foo(96)() is 96 +PASS foo(97)() is 97 +PASS foo(98)() is 98 +PASS foo(99)() is 99 +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/js/dfg-uint32-to-number-on-captured-variable.html (0 => 115237) ---
[webkit-changes] [115241] trunk/Source/WebCore
Title: [115241] trunk/Source/WebCore
Revision 115241
Author kl...@webkit.org
Date 2012-04-25 13:40:38 -0700 (Wed, 25 Apr 2012)
Log Message
Remove unused Attribute constructor.
Semi-knowingly rubber-stamped by Antti Koivisto.
* dom/Attribute.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attribute.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115240 => 115241)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 20:34:26 UTC (rev 115240)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 20:40:38 UTC (rev 115241)
@@ -1,3 +1,11 @@
+2012-04-25 Andreas Kling kl...@webkit.org
+
+Remove unused Attribute constructor.
+
+Semi-knowingly rubber-stamped by Antti Koivisto.
+
+* dom/Attribute.h:
+
2012-04-25 Nate Chapin jap...@chromium.org
Crash in CachedRawResource::didAddClient() due to missing protector.
Modified: trunk/Source/WebCore/dom/Attribute.h (115240 => 115241)
--- trunk/Source/WebCore/dom/Attribute.h 2012-04-25 20:34:26 UTC (rev 115240)
+++ trunk/Source/WebCore/dom/Attribute.h 2012-04-25 20:40:38 UTC (rev 115241)
@@ -34,11 +34,6 @@
// The actual Attr with its value as a Text child is allocated only if needed.
class Attribute {
public:
-Attribute()
-: m_name(nullAtom, nullAtom, nullAtom)
-{
-}
-
Attribute(const QualifiedName name, const AtomicString value)
: m_name(name)
, m_value(value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115242] trunk/Source
Title: [115242] trunk/Source
Revision 115242
Author enr...@apple.com
Date 2012-04-25 13:59:28 -0700 (Wed, 25 Apr 2012)
Log Message
Source/WebCore: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
rdar://problem/11155407
In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.
Reviewed by Alexey Proskuryakov.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag): Reset m_mouseDownMayStartDrag to false to
avoid attempting to start another drag.
Source/WebKit2: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
rdar://problem/11155407
In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.
The fix for the problem is in WebCore and we can now remove the guard on _setDragImage.
Reviewed by Alexey Proskuryakov.
* UIProcess/API/mac/WKView.mm:
(-[WKView mouseDown:]):
(-[WKView _setDragImage:at:linkDrag:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (115241 => 115242)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 20:40:38 UTC (rev 115241)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 20:59:28 UTC (rev 115242)
@@ -1,3 +1,20 @@
+2012-04-25 Enrica Casucci enr...@apple.com
+
+REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
+https://bugs.webkit.org/show_bug.cgi?id=84878
+rdar://problem/11155407
+
+In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
+of the communication between the UI process and the WebProcess.
+We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
+gets changed which affects the promised file types.
+
+Reviewed by Alexey Proskuryakov.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleDrag): Reset m_mouseDownMayStartDrag to false to
+avoid attempting to start another drag.
+
2012-04-25 Andreas Kling kl...@webkit.org
Remove unused Attribute constructor.
Modified: trunk/Source/WebCore/page/EventHandler.cpp (115241 => 115242)
--- trunk/Source/WebCore/page/EventHandler.cpp 2012-04-25 20:40:38 UTC (rev 115241)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2012-04-25 20:59:28 UTC (rev 115242)
@@ -3149,7 +3149,14 @@
Page* page = m_frame-page();
DragController* dragController = page ? page-dragController() : 0;
bool startedDrag = dragController dragController-startDrag(m_frame, dragState(), srcOp, event.event(), m_mouseDownPos);
-if (!startedDrag dragState().shouldDispatchEvents()) {
+// In WebKit2 we could reenter this code and start another drag.
+// On OS X this causes problems with the ownership of the pasteboard
+// and the promised types.
+if (startedDrag) {
+m_mouseDownMayStartDrag = false;
+return true;
+}
+if (dragState().shouldDispatchEvents()) {
// Drag was canned at the last minute - we owe m_dragSrc a DRAGEND event
dispatchDragSrcEvent(eventNames().dragendEvent, event.event());
m_mouseDownMayStartDrag = false;
Modified: trunk/Source/WebKit2/ChangeLog (115241 => 115242)
--- trunk/Source/WebKit2/ChangeLog 2012-04-25 20:40:38 UTC (rev 115241)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-25 20:59:28 UTC (rev 115242)
@@ -1,3 +1,21 @@
+2012-04-25 Enrica Casucci enr...@apple.com
+
+REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
+https://bugs.webkit.org/show_bug.cgi?id=84878
+rdar://problem/11155407
+
+In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
+of the communication between the UI process and the WebProcess.
+We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
+gets changed which affects the promised file types.
+The fix for the problem is in WebCore and we can now remove the guard on _setDragImage.
+
+Reviewed by Alexey Proskuryakov.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView mouseDown:]):
+(-[WKView
[webkit-changes] [115243] trunk/Source
Title: [115243] trunk/Source Revision 115243 Author commit-qu...@webkit.org Date 2012-04-25 14:13:33 -0700 (Wed, 25 Apr 2012) Log Message [chromium] Add support for animation finished events. https://bugs.webkit.org/show_bug.cgi?id=84454 Patch by Ian Vollick voll...@chromium.org on 2012-04-25 Reviewed by James Robinson. Source/WebCore: Tested in CCLayerTreeHostTestAnimationFinishedEvents * platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::willBeDestroyed): (WebCore::GraphicsLayerChromium::notifyAnimationFinished): (WebCore): * platform/graphics/chromium/GraphicsLayerChromium.h: * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::notifyAnimationStarted): (WebCore::LayerChromium::notifyAnimationFinished): (WebCore): * platform/graphics/chromium/LayerChromium.h: (WebCore): (LayerChromium): * platform/graphics/chromium/cc/CCAnimationEvents.h: (WebCore::CCAnimationEvent::CCAnimationEvent): (CCAnimationEvent): (WebCore): * platform/graphics/chromium/cc/CCLayerAnimationController.cpp: (WebCore::CCLayerAnimationController::animate): (WebCore::CCLayerAnimationController::notifyAnimationStarted): (WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick): (WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime): (WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability): (WebCore::CCLayerAnimationController::purgeFinishedAnimations): * platform/graphics/chromium/cc/CCLayerAnimationController.h: (CCLayerAnimationController): * platform/graphics/chromium/cc/CCLayerAnimationDelegate.h: (CCLayerAnimationDelegate): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::setAnimationEventsRecursive): Source/WebKit/chromium: * tests/CCLayerAnimationControllerTest.cpp: (WebKitTests::TEST): * tests/CCLayerTreeHostTest.cpp: (WTF::TestHooks::notifyAnimationFinished): (WTF::TEST_F): (WTF): (CCLayerTreeHostTestAnimationFinishedEvents): (WTF::CCLayerTreeHostTestAnimationFinishedEvents::CCLayerTreeHostTestAnimationFinishedEvents): (WTF::CCLayerTreeHostTestAnimationFinishedEvents::beginTest): (WTF::CCLayerTreeHostTestAnimationFinishedEvents::notifyAnimationFinished): (WTF::CCLayerTreeHostTestAnimationFinishedEvents::afterTest): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCAnimationEvents.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationDelegate.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115242 => 115243) --- trunk/Source/WebCore/ChangeLog 2012-04-25 20:59:28 UTC (rev 115242) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 21:13:33 UTC (rev 115243) @@ -1,3 +1,42 @@ +2012-04-25 Ian Vollick voll...@chromium.org + +[chromium] Add support for animation finished events. +https://bugs.webkit.org/show_bug.cgi?id=84454 + +Reviewed by James Robinson. + +Tested in CCLayerTreeHostTestAnimationFinishedEvents + +* platform/graphics/chromium/GraphicsLayerChromium.cpp: +(WebCore::GraphicsLayerChromium::willBeDestroyed): +(WebCore::GraphicsLayerChromium::notifyAnimationFinished): +(WebCore): +* platform/graphics/chromium/GraphicsLayerChromium.h: +* platform/graphics/chromium/LayerChromium.cpp: +(WebCore::LayerChromium::notifyAnimationStarted): +(WebCore::LayerChromium::notifyAnimationFinished): +(WebCore): +* platform/graphics/chromium/LayerChromium.h: +(WebCore): +(LayerChromium): +* platform/graphics/chromium/cc/CCAnimationEvents.h: +(WebCore::CCAnimationEvent::CCAnimationEvent): +(CCAnimationEvent): +(WebCore): +* platform/graphics/chromium/cc/CCLayerAnimationController.cpp: +(WebCore::CCLayerAnimationController::animate): +(WebCore::CCLayerAnimationController::notifyAnimationStarted): +(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick): +(WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime): +(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability): +(WebCore::CCLayerAnimationController::purgeFinishedAnimations): +*
[webkit-changes] [115244] trunk/Source/WebCore
Title: [115244] trunk/Source/WebCore
Revision 115244
Author rn...@webkit.org
Date 2012-04-25 14:15:39 -0700 (Wed, 25 Apr 2012)
Log Message
Build fix after r115227. Return null string when the string builder is empty
to match the old behavior.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::borderPropertyValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StylePropertySet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115243 => 115244)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 21:13:33 UTC (rev 115243)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 21:15:39 UTC (rev 115244)
@@ -1,3 +1,11 @@
+2012-04-25 Ryosuke Niwa rn...@webkit.org
+
+Build fix after r115227. Return null string when the string builder is empty
+to match the old behavior.
+
+* css/StylePropertySet.cpp:
+(WebCore::StylePropertySet::borderPropertyValue):
+
2012-04-25 Ian Vollick voll...@chromium.org
[chromium] Add support for animation finished events.
Modified: trunk/Source/WebCore/css/StylePropertySet.cpp (115243 => 115244)
--- trunk/Source/WebCore/css/StylePropertySet.cpp 2012-04-25 21:13:33 UTC (rev 115243)
+++ trunk/Source/WebCore/css/StylePropertySet.cpp 2012-04-25 21:15:39 UTC (rev 115244)
@@ -441,10 +441,10 @@
if (value == initial)
continue;
if (!result.isEmpty())
-result.append( );
+result.append(' ');
result.append(value);
}
-return result.toString();
+return result.isEmpty() ? String() : result.toString();
}
PassRefPtrCSSValue StylePropertySet::getPropertyCSSValue(CSSPropertyID propertyID) const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115245] trunk/Source/WebKit/blackberry
Title: [115245] trunk/Source/WebKit/blackberry
Revision 115245
Author commit-qu...@webkit.org
Date 2012-04-25 14:22:53 -0700 (Wed, 25 Apr 2012)
Log Message
[BlackBerry] Possible JS re-entrancy caused by UI events.
https://bugs.webkit.org/show_bug.cgi?id=84862
Patch by Yong Li y...@rim.com on 2012-04-25
Reviewed by Antonio Gomes.
1. block UI events when running in nested event loop
2. defer some tasks we still want to perform when it is safe to do,
with cached data.
3. deferred task can be cancelled by clearing the flag. duplicate tasks
is not a problem because they share same flag and data.
4. move deferred manual script from FrameLoaderClientBlackBerry to WebPagePrivate
and make it a deferred task
* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
(BlackBerry::WebKit::WebPagePrivate::willDeferLoading):
(BlackBerry::WebKit::WebPagePrivate::didResumeLoading):
(BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPage::setInputSelection):
(BlackBerry::WebKit::WebPage::popupListClosed):
(BlackBerry::WebKit::WebPage::setDateTimeInput):
(BlackBerry::WebKit::WebPage::setColorInput):
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPage::touchEventCancel):
(BlackBerry::WebKit::WebPage::touchEventCancelAndClearFocusedNode):
(BlackBerry::WebKit::WebPage::keyEvent):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::setComposingText):
(BlackBerry::WebKit::WebPage::commitText):
(BlackBerry::WebKit::WebPage::selectionCancelled):
(BlackBerry::WebKit::WebPage::cutSelectedText):
(BlackBerry::WebKit::WebPage::insertText):
(BlackBerry::WebKit::WebPage::clearCurrentInputField):
(BlackBerry::WebKit::WebPage::cut):
(BlackBerry::WebKit::WebPage::paste):
(BlackBerry::WebKit::WebPage::setSelection):
(BlackBerry::WebKit::WebPage::setCaretPosition):
(BlackBerry::WebKit::WebPage::selectAtPoint):
(BlackBerry::WebKit::WebPage::setFocused):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
(DeferredTaskBase):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::perform):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::DeferredTaskBase):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::~FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::willDeferLoading):
(WebCore::FrameLoaderClientBlackBerry::didResumeLoading):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
* WebKitSupport/InputHandler.h:
(InputHandler):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.h
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (115244 => 115245)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-04-25 21:15:39 UTC (rev 115244)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-04-25 21:22:53 UTC (rev 115245)
@@ -289,6 +289,21 @@
d-m_userViewportArguments = ViewportArguments();
}
+template bool WebPagePrivate::* isActive
+class DeferredTask: public WebPagePrivate::DeferredTaskBase {
+public:
+static void finishOrCancel(WebPagePrivate* webPagePrivate)
+{
+webPagePrivate-*isActive = false;
+}
+protected:
+DeferredTask(WebPagePrivate* webPagePrivate)
+: DeferredTaskBase(webPagePrivate, isActive)
+{
+}
+typedef DeferredTaskisActive DeferredTaskType;
+};
+
WebPagePrivate::WebPagePrivate(WebPage* webPage, WebPageClient* client, const IntRect rect)
: m_webPage(webPage)
, m_client(client)
@@ -356,6 +371,7 @@
, m_fullscreenVideoNode(0)
, m_hasInRegionScrollableAreas(false)
, m_updateDelegatedOverlaysDispatched(false)
+, m_deferredTasksTimer(this, WebPagePrivate::deferredTasksTimerFired)
{
static bool isInitialized = false;
if (!isInitialized) {
@@ -527,9 +543,24 @@
#endif
}
+class DeferredTaskLoadManualScript: public DeferredTaskWebPagePrivate::m_wouldSetFocused {
+public:
+explicit DeferredTaskLoadManualScript(WebPagePrivate* webPagePrivate, const KURL url)
+: DeferredTaskType(webPagePrivate)
+{
+
[webkit-changes] [115246] trunk/Source/WebCore
Title: [115246] trunk/Source/WebCore
Revision 115246
Author hc...@chromium.org
Date 2012-04-25 14:30:52 -0700 (Wed, 25 Apr 2012)
Log Message
Unreviewed build fix.
Build fix for compilation failure due to r115243.
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115245 => 115246)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 21:22:53 UTC (rev 115245)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 21:30:52 UTC (rev 115246)
@@ -1,3 +1,12 @@
+2012-04-25 Alpha Lam hc...@chromium.org
+
+Unreviewed build fix.
+
+Build fix for compilation failure due to r115243.
+
+* platform/graphics/chromium/LayerChromium.h:
+(WebCore):
+
2012-04-25 Ryosuke Niwa rn...@webkit.org
Build fix after r115227. Return null string when the string builder is empty
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (115245 => 115246)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2012-04-25 21:22:53 UTC (rev 115245)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2012-04-25 21:30:52 UTC (rev 115246)
@@ -56,7 +56,7 @@
namespace WebCore {
-class CCAnimationEvent;
+struct CCAnimationEvent;
class CCLayerAnimationDelegate;
class CCLayerImpl;
class CCLayerTreeHost;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115247] trunk/LayoutTests
Title: [115247] trunk/LayoutTests Revision 115247 Author hc...@chromium.org Date 2012-04-25 14:36:42 -0700 (Wed, 25 Apr 2012) Log Message Unreviewed test expectations update. https://bugs.webkit.org/show_bug.cgi?id=84890 Rebaseline chromium-mac test expectation for media/audio-repaint.html after r115235. * platform/chromium-mac-snowleopard/media/audio-repaint-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-snowleopard/media/audio-repaint-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (115246 => 115247) --- trunk/LayoutTests/ChangeLog 2012-04-25 21:30:52 UTC (rev 115246) +++ trunk/LayoutTests/ChangeLog 2012-04-25 21:36:42 UTC (rev 115247) @@ -1,3 +1,12 @@ +2012-04-25 Alpha Lam hc...@chromium.org + +Unreviewed test expectations update. +https://bugs.webkit.org/show_bug.cgi?id=84890 + +Rebaseline chromium-mac test expectation for media/audio-repaint.html after r115235. + +* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png: + 2012-04-25 Stephen Chenney schen...@chromium.org Rebaseline chromium test results after bug 72796 is fixed Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/media/audio-repaint-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115249] trunk/Source/WebCore
Title: [115249] trunk/Source/WebCore
Revision 115249
Author ad...@chromium.org
Date 2012-04-25 15:33:10 -0700 (Wed, 25 Apr 2012)
Log Message
Fix uninitialized variable warnings in PasteboardMac.mm after 115145
https://bugs.webkit.org/show_bug.cgi?id=84879
Reviewed by Enrica Casucci.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
(WebCore::Pasteboard::writeSelectionForTypes): ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/PasteboardMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (115248 => 115249)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 22:12:49 UTC (rev 115248)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 22:33:10 UTC (rev 115249)
@@ -1,3 +1,14 @@
+2012-04-25 Adam Klein ad...@chromium.org
+
+Fix uninitialized variable warnings in PasteboardMac.mm after 115145
+https://bugs.webkit.org/show_bug.cgi?id=84879
+
+Reviewed by Enrica Casucci.
+
+* platform/mac/PasteboardMac.mm:
+(WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
+(WebCore::Pasteboard::writeSelectionForTypes): ditto.
+
2012-04-25 Kenneth Russell k...@google.com
Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
Modified: trunk/Source/WebCore/platform/mac/PasteboardMac.mm (115248 => 115249)
--- trunk/Source/WebCore/platform/mac/PasteboardMac.mm 2012-04-25 22:12:49 UTC (rev 115248)
+++ trunk/Source/WebCore/platform/mac/PasteboardMac.mm 2012-04-25 22:33:10 UTC (rev 115249)
@@ -156,7 +156,7 @@
if (enclosingAnchor comparePositions(firstPositionInOrBeforeNode(range-startPosition().anchorNode()), range-startPosition()) = 0)
range-setStart(enclosingAnchor, 0, ec);
-NSAttributedString* attributedString;
+NSAttributedString* attributedString = nil;
RetainPtrWebHTMLConverter converter(AdoptNS, [[WebHTMLConverter alloc] initWithDOMRange:kit(range.get())]);
if (converter)
attributedString = [converter.get() attributedString];
@@ -176,7 +176,7 @@
void Pasteboard::writeSelectionForTypes(const VectorString pasteboardTypes, bool canSmartCopyOrDelete, Frame* frame)
{
-NSAttributedString* attributedString;
+NSAttributedString* attributedString = nil;
RetainPtrWebHTMLConverter converter(AdoptNS, [[WebHTMLConverter alloc] initWithDOMRange:kit(frame-editor()-selectedRange().get())]);
if (converter)
attributedString = [converter.get() attributedString];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115251] trunk/LayoutTests
Title: [115251] trunk/LayoutTests Revision 115251 Author dglaz...@chromium.org Date 2012-04-25 15:52:41 -0700 (Wed, 25 Apr 2012) Log Message [Chromium[ Remove a flaky expectation for a test that's been consistently passing. * platform/chromium/test_expectations.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115250 => 115251) --- trunk/LayoutTests/ChangeLog 2012-04-25 22:42:47 UTC (rev 115250) +++ trunk/LayoutTests/ChangeLog 2012-04-25 22:52:41 UTC (rev 115251) @@ -1,3 +1,9 @@ +2012-04-25 Dimitri Glazkov dglaz...@chromium.org + +[Chromium[ Remove a flaky expectation for a test that's been consistently passing. + +* platform/chromium/test_expectations.txt: Removed. + 2012-04-25 Alpha Lam hc...@chromium.org Unreviewed test expectations update. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (115250 => 115251) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 22:42:47 UTC (rev 115250) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-25 22:52:41 UTC (rev 115251) @@ -1432,11 +1432,6 @@ // This test sometimes fails indefinitely, other times it takes 1-2 seconds. BUGCR14009 WIN : http/tests/misc/dns-prefetch-control.html = PASS TIMEOUT -// MERGE 38389:38450 -// Form submit causes invalid page reload/navigation when action is a named -// anchor -BUGCR10357 : fast/dom/cssTarget-crash.html = PASS TIMEOUT - BUGCR10361 WIN : http/tests/misc/single-character-pi-stylesheet.xhtml = FAIL // Windows is missing the green box. Started to pass in roll to WebKit r50313 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115252] trunk/Source/JavaScriptCore
Title: [115252] trunk/Source/_javascript_Core
Revision 115252
Author oli...@apple.com
Date 2012-04-25 15:58:08 -0700 (Wed, 25 Apr 2012)
Log Message
Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898
Reviewed by Filip Pizlo.
I recently added an assertion to the Interpreter to catch incorrect
updates of topCallFrame. This caused a bunch of sites (including biolab
disaster) to crash as we were not correctly handling callee registers
of inlined functions, leading to a mismatch.
I could not actually make this trigger directly, although it does trigger
already on some of the GTK and QT bots.
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (115251 => 115252)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-25 22:52:41 UTC (rev 115251)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-25 22:58:08 UTC (rev 115252)
@@ -1,3 +1,21 @@
+2012-04-25 Oliver Hunt oli...@apple.com
+
+Biolab disaster crashes on ToT
+https://bugs.webkit.org/show_bug.cgi?id=84898
+
+Reviewed by Filip Pizlo.
+
+I recently added an assertion to the Interpreter to catch incorrect
+updates of topCallFrame. This caused a bunch of sites (including biolab
+disaster) to crash as we were not correctly handling callee registers
+of inlined functions, leading to a mismatch.
+
+I could not actually make this trigger directly, although it does trigger
+already on some of the GTK and QT bots.
+
+* dfg/DFGVirtualRegisterAllocationPhase.cpp:
+(JSC::DFG::VirtualRegisterAllocationPhase::run):
+
2012-04-25 Kenneth Russell k...@google.com
Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
Modified: trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp (115251 => 115252)
--- trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp 2012-04-25 22:52:41 UTC (rev 115251)
+++ trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp 2012-04-25 22:58:08 UTC (rev 115252)
@@ -109,6 +109,14 @@
// for the function (and checked for on entry). Since we perform a new and
// different allocation of temporaries, more registers may now be required.
unsigned calleeRegisters = scoreBoard.highWatermark() + m_graph.m_parameterSlots;
+size_t inlineCallFrameCount = codeBlock()-inlineCallFrames().size();
+for (size_t i = 0; i inlineCallFrameCount; i++) {
+InlineCallFrame inlineCallFrame = codeBlock()-inlineCallFrames()[i];
+CodeBlock* codeBlock = jsCastFunctionExecutable*(inlineCallFrame.executable.get())-baselineCodeBlockFor(inlineCallFrame.isCall ? CodeForCall : CodeForConstruct);
+unsigned requiredCalleeRegisters = inlineCallFrame.stackOffset + codeBlock-m_numCalleeRegisters;
+if (requiredCalleeRegisters calleeRegisters)
+calleeRegisters = requiredCalleeRegisters;
+}
if ((unsigned)codeBlock()-m_numCalleeRegisters calleeRegisters)
codeBlock()-m_numCalleeRegisters = calleeRegisters;
#if DFG_ENABLE(DEBUG_VERBOSE)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115253] trunk/Source/JavaScriptCore
Title: [115253] trunk/Source/_javascript_Core
Revision 115253
Author oli...@apple.com
Date 2012-04-25 16:01:08 -0700 (Wed, 25 Apr 2012)
Log Message
Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898
Reviewed by Filip Pizlo.
Whoops, committed without saving reviewer requested change.
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (115252 => 115253)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-25 22:58:08 UTC (rev 115252)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-25 23:01:08 UTC (rev 115253)
@@ -5,6 +5,18 @@
Reviewed by Filip Pizlo.
+Whoops, committed without saving reviewer requested change.
+
+* dfg/DFGVirtualRegisterAllocationPhase.cpp:
+(JSC::DFG::VirtualRegisterAllocationPhase::run):
+
+2012-04-25 Oliver Hunt oli...@apple.com
+
+Biolab disaster crashes on ToT
+https://bugs.webkit.org/show_bug.cgi?id=84898
+
+Reviewed by Filip Pizlo.
+
I recently added an assertion to the Interpreter to catch incorrect
updates of topCallFrame. This caused a bunch of sites (including biolab
disaster) to crash as we were not correctly handling callee registers
Modified: trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp (115252 => 115253)
--- trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp 2012-04-25 22:58:08 UTC (rev 115252)
+++ trunk/Source/_javascript_Core/dfg/DFGVirtualRegisterAllocationPhase.cpp 2012-04-25 23:01:08 UTC (rev 115253)
@@ -112,7 +112,7 @@
size_t inlineCallFrameCount = codeBlock()-inlineCallFrames().size();
for (size_t i = 0; i inlineCallFrameCount; i++) {
InlineCallFrame inlineCallFrame = codeBlock()-inlineCallFrames()[i];
-CodeBlock* codeBlock = jsCastFunctionExecutable*(inlineCallFrame.executable.get())-baselineCodeBlockFor(inlineCallFrame.isCall ? CodeForCall : CodeForConstruct);
+CodeBlock* codeBlock = baselineCodeBlockForInlineCallFrame(inlineCallFrame);
unsigned requiredCalleeRegisters = inlineCallFrame.stackOffset + codeBlock-m_numCalleeRegisters;
if (requiredCalleeRegisters calleeRegisters)
calleeRegisters = requiredCalleeRegisters;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115254] trunk/Source/WTF
Title: [115254] trunk/Source/WTF Revision 115254 Author rak...@webkit.org Date 2012-04-25 16:02:18 -0700 (Wed, 25 Apr 2012) Log Message Include sys/param.h, needed for sysctl() on OpenBSD/NetBSD https://bugs.webkit.org/show_bug.cgi?id=82585 Patch by Landry Breuil lan...@openbsd.org on 2012-04-25 Reviewed by Zoltan Herczeg. * wtf/NumberOfCores.cpp: include sys/param.h on the BSDs Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/NumberOfCores.cpp Diff Modified: trunk/Source/WTF/ChangeLog (115253 => 115254) --- trunk/Source/WTF/ChangeLog 2012-04-25 23:01:08 UTC (rev 115253) +++ trunk/Source/WTF/ChangeLog 2012-04-25 23:02:18 UTC (rev 115254) @@ -1,3 +1,12 @@ +2012-04-25 Landry Breuil lan...@openbsd.org + +Include sys/param.h, needed for sysctl() on OpenBSD/NetBSD +https://bugs.webkit.org/show_bug.cgi?id=82585 + +Reviewed by Zoltan Herczeg. + +* wtf/NumberOfCores.cpp: include sys/param.h on the BSDs + 2012-04-25 Kenneth Russell k...@google.com Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced Modified: trunk/Source/WTF/wtf/NumberOfCores.cpp (115253 => 115254) --- trunk/Source/WTF/wtf/NumberOfCores.cpp 2012-04-25 23:01:08 UTC (rev 115253) +++ trunk/Source/WTF/wtf/NumberOfCores.cpp 2012-04-25 23:02:18 UTC (rev 115254) @@ -27,6 +27,7 @@ #include NumberOfCores.h #if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD) || OS(FREEBSD) +#include sys/param.h // sys/types.h must come before sys/sysctl.h because the latter uses // data types defined in the former. See sysctl(3) and style(9). #include sys/types.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115255] trunk
Title: [115255] trunk Revision 115255 Author commit-qu...@webkit.org Date 2012-04-25 16:05:29 -0700 (Wed, 25 Apr 2012) Log Message IndexedDB: support openCursor(IDBKey) https://bugs.webkit.org/show_bug.cgi?id=84652 Patch by Alec Flett alecfl...@chromium.org on 2012-04-25 Reviewed by Ojan Vafai. Source/WebCore: Add signatures for openCursor/openKeyCursor(IDBKey). Test: storage/indexeddb/opencursor-key.html * Modules/indexeddb/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore): (WebCore::IDBIndex::openKeyCursor): * Modules/indexeddb/IDBIndex.h: (WebCore::IDBIndex::openCursor): (IDBIndex): (WebCore::IDBIndex::openKeyCursor): * Modules/indexeddb/IDBIndex.idl: * Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor): (WebCore): * Modules/indexeddb/IDBObjectStore.h: (WebCore::IDBObjectStore::openCursor): (IDBObjectStore): * Modules/indexeddb/IDBObjectStore.idl: LayoutTests: Augment existing tests, and add new tests to support IDBKey parameter to openCursor/openKeyCursor. Note that this removes a test that was previously using dictionary-style parameters, which have been temporarily broken due to IDL limitations. * storage/indexeddb/cursor-delete-expected.txt: * storage/indexeddb/open-cursor-expected.txt: * storage/indexeddb/opencursor-key-expected.txt: Added. * storage/indexeddb/opencursor-key.html: Added. * storage/indexeddb/resources/cursor-delete.js: (openCursor): * storage/indexeddb/resources/open-cursor.js: (emptyCursorWithKeySuccess): (openEmptyCursorWithKey): (cursorWithKeySuccess): (openCursorWithKey): (emptyCursorSuccess): (openEmptyCursor): (cursorSuccess): * storage/indexeddb/resources/opencursor-key.js: Added. (test): (openSuccess): (createAndPopulateObjectStore): (createIndexes): (testAll): (testObjectStore.request.onsuccess): (testObjectStore): (testIndex.request.onsuccess): (testIndex): (testIndexWithKey.request.onsuccess): (testIndexWithKey): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/indexeddb/cursor-delete-expected.txt trunk/LayoutTests/storage/indexeddb/open-cursor-expected.txt trunk/LayoutTests/storage/indexeddb/resources/cursor-delete.js trunk/LayoutTests/storage/indexeddb/resources/open-cursor.js trunk/LayoutTests/storage/indexeddb/resources/shared.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp trunk/Source/WebCore/Modules/indexeddb/IDBIndex.h trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.h trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl Added Paths trunk/LayoutTests/storage/indexeddb/opencursor-key-expected.txt trunk/LayoutTests/storage/indexeddb/opencursor-key.html trunk/LayoutTests/storage/indexeddb/resources/opencursor-key.js Diff Modified: trunk/LayoutTests/ChangeLog (115254 => 115255) --- trunk/LayoutTests/ChangeLog 2012-04-25 23:02:18 UTC (rev 115254) +++ trunk/LayoutTests/ChangeLog 2012-04-25 23:05:29 UTC (rev 115255) @@ -1,3 +1,42 @@ +2012-04-25 Alec Flett alecfl...@chromium.org + +IndexedDB: support openCursor(IDBKey) +https://bugs.webkit.org/show_bug.cgi?id=84652 + +Reviewed by Ojan Vafai. + +Augment existing tests, and add new tests to support +IDBKey parameter to openCursor/openKeyCursor. Note that this removes +a test that was previously using dictionary-style parameters, +which have been temporarily broken due to IDL limitations. + +* storage/indexeddb/cursor-delete-expected.txt: +* storage/indexeddb/open-cursor-expected.txt: +* storage/indexeddb/opencursor-key-expected.txt: Added. +* storage/indexeddb/opencursor-key.html: Added. +* storage/indexeddb/resources/cursor-delete.js: +(openCursor): +* storage/indexeddb/resources/open-cursor.js: +(emptyCursorWithKeySuccess): +(openEmptyCursorWithKey): +(cursorWithKeySuccess): +(openCursorWithKey): +(emptyCursorSuccess): +(openEmptyCursor): +(cursorSuccess): +* storage/indexeddb/resources/opencursor-key.js: Added. +(test): +(openSuccess): +(createAndPopulateObjectStore): +(createIndexes): +(testAll): +(testObjectStore.request.onsuccess): +(testObjectStore): +(testIndex.request.onsuccess): +(testIndex): +(testIndexWithKey.request.onsuccess): +(testIndexWithKey): + 2012-04-25 Dimitri Glazkov dglaz...@chromium.org [Chromium[ Remove a flaky expectation for a test that's been consistently passing. Modified: trunk/LayoutTests/storage/indexeddb/cursor-delete-expected.txt (115254 => 115255) --- trunk/LayoutTests/storage/indexeddb/cursor-delete-expected.txt 2012-04-25 23:02:18 UTC (rev 115254) +++ trunk/LayoutTests/storage/indexeddb/cursor-delete-expected.txt 2012-04-25 23:05:29 UTC (rev 115255) @@ -19,7 +19,7 @@
[webkit-changes] [115256] trunk/Source/WebCore
Title: [115256] trunk/Source/WebCore Revision 115256 Author an...@apple.com Date 2012-04-25 16:07:54 -0700 (Wed, 25 Apr 2012) Log Message Try to fix build with STYLE_SCOPED enabled. Not reviewed. * css/StyleResolver.cpp: (WebCore::StyleResolver::determineScope): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleResolver.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115255 => 115256) --- trunk/Source/WebCore/ChangeLog 2012-04-25 23:05:29 UTC (rev 115255) +++ trunk/Source/WebCore/ChangeLog 2012-04-25 23:07:54 UTC (rev 115256) @@ -1,3 +1,12 @@ +2012-04-25 Antti Koivisto an...@apple.com + +Try to fix build with STYLE_SCOPED enabled. + +Not reviewed. + +* css/StyleResolver.cpp: +(WebCore::StyleResolver::determineScope): + 2012-04-25 Alec Flett alecfl...@chromium.org IndexedDB: support openCursor(IDBKey) @@ -31,7 +40,7 @@ Remove owner node pointer from StyleSheetInternal https://bugs.webkit.org/show_bug.cgi?id=84882 -Reviewed by Andread Kling. +Reviewed by Andreas Kling. To make sharing between multiple nodes possible StyleSheetInternal should not have a Node pointer. Modified: trunk/Source/WebCore/css/StyleResolver.cpp (115255 => 115256) --- trunk/Source/WebCore/css/StyleResolver.cpp 2012-04-25 23:05:29 UTC (rev 115255) +++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-04-25 23:07:54 UTC (rev 115256) @@ -474,7 +474,7 @@ if (!RuntimeEnabledFeatures::styleScopedEnabled()) return 0; -Node* ownerNode = sheet-findStyleSheetOwnerNode(); +Node* ownerNode = sheet-singleOwnerNode(); if (!ownerNode || !ownerNode-isHTMLElement() || !ownerNode-hasTagName(HTMLNames::styleTag)) return 0; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115257] trunk/Tools
Title: [115257] trunk/Tools Revision 115257 Author infe...@chromium.org Date 2012-04-25 16:30:39 -0700 (Wed, 25 Apr 2012) Log Message Mark myself as a reviewer. https://bugs.webkit.org/show_bug.cgi?id=84902 Reviewed by Dimitri Glazkov. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (115256 => 115257) --- trunk/Tools/ChangeLog 2012-04-25 23:07:54 UTC (rev 115256) +++ trunk/Tools/ChangeLog 2012-04-25 23:30:39 UTC (rev 115257) @@ -1,3 +1,12 @@ +2012-04-25 Abhishek Arya infe...@chromium.org + +Mark myself as a reviewer. +https://bugs.webkit.org/show_bug.cgi?id=84902 + +Reviewed by Dimitri Glazkov. + +* Scripts/webkitpy/common/config/committers.py: + 2012-04-25 Kristóf Kosztyó kkris...@inf.u-szeged.hu [Qt][NRWT] Run each DRT in it's own xvfb Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (115256 => 115257) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-04-25 23:07:54 UTC (rev 115256) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-04-25 23:30:39 UTC (rev 115257) @@ -165,7 +165,6 @@ committers_unable_to_review = [ Committer(Aaron Boodman, a...@chromium.org, aboodman), -Committer(Abhishek Arya, infe...@chromium.org, inferno-sec), Committer(Adam Klein, ad...@chromium.org, aklein), Committer(Adam Langley, a...@chromium.org, agl), Committer(Ademar de Souza Reis Jr, [ademar.r...@gmail.com, ade...@webkit.org], ademar), @@ -386,6 +385,7 @@ reviewers_list = [ +Reviewer(Abhishek Arya, infe...@chromium.org, inferno-sec), Reviewer(Ada Chan, adac...@apple.com, chanada), Reviewer(Adam Barth, aba...@webkit.org, abarth), Reviewer(Adam Roben, [aro...@webkit.org, aro...@apple.com], aroben), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115258] trunk/Tools
Title: [115258] trunk/Tools Revision 115258 Author jsb...@chromium.org Date 2012-04-25 16:39:26 -0700 (Wed, 25 Apr 2012) Log Message Unreviewed: Adding Alec Flett as a contributor (non-committer). * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (115257 => 115258) --- trunk/Tools/ChangeLog 2012-04-25 23:30:39 UTC (rev 115257) +++ trunk/Tools/ChangeLog 2012-04-25 23:39:26 UTC (rev 115258) @@ -1,3 +1,9 @@ +2012-04-25 Joshua Bell jsb...@chromium.org + +Unreviewed: Adding Alec Flett as a contributor (non-committer). + +* Scripts/webkitpy/common/config/committers.py: + 2012-04-25 Abhishek Arya infe...@chromium.org Mark myself as a reviewer. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (115257 => 115258) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-04-25 23:30:39 UTC (rev 115257) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-04-25 23:39:26 UTC (rev 115258) @@ -110,6 +110,7 @@ Contributor(Adam Kallai, ka...@inf.u-szeged.hu, 'kadam'), Contributor(Aharon Lanin, aha...@google.com), Contributor(Alan Stearns, stea...@adobe.com, 'astearns'), +Contributor(Alec Flett, [alecfl...@chromium.org, alecfl...@google.com], alecf), Contributor(Alexandre Elias, ael...@chromium.org), Contributor(Alexey Marinichev, [amarinic...@chromium.org, amarinic...@google.com], amarinichev), Contributor(Allan Sandfeld Jensen, [allan.jen...@nokia.com, k...@carewolf.com, sandf...@kde.org], carewolf), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115259] branches/subpixellayout/Source/WebCore/platform/graphics/ FractionalLayoutRect.cpp
Title: [115259] branches/subpixellayout/Source/WebCore/platform/graphics/FractionalLayoutRect.cpp
Revision 115259
Author e...@chromium.org
Date 2012-04-25 16:51:06 -0700 (Wed, 25 Apr 2012)
Log Message
Fix enclosingFractionalLayoutRect for 1/1 on branch.
Modified Paths
branches/subpixellayout/Source/WebCore/platform/graphics/FractionalLayoutRect.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/platform/graphics/FractionalLayoutRect.cpp (115258 => 115259)
--- branches/subpixellayout/Source/WebCore/platform/graphics/FractionalLayoutRect.cpp 2012-04-25 23:39:26 UTC (rev 115258)
+++ branches/subpixellayout/Source/WebCore/platform/graphics/FractionalLayoutRect.cpp 2012-04-25 23:51:06 UTC (rev 115259)
@@ -139,9 +139,13 @@
FractionalLayoutRect enclosingFractionalLayoutRect(const FloatRect rect)
{
+#if ENABLE(SUBPIXEL_LAYOUT)
return FractionalLayoutRect(rect.x(), rect.y(),
rect.maxX() - rect.x() + FractionalLayoutUnit::epsilon(),
rect.maxY() - rect.y() + FractionalLayoutUnit::epsilon());
+#else
+return enclosingIntRect(rect);
+#endif
}
IntRect pixelSnappedIntRect(const FractionalLayoutRect rect)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115260] trunk
Title: [115260] trunk
Revision 115260
Author commit-qu...@webkit.org
Date 2012-04-25 16:52:12 -0700 (Wed, 25 Apr 2012)
Log Message
IndexedDB: cursor does not correctly iterate over keys added and removed during iteration
https://bugs.webkit.org/show_bug.cgi?id=84467
Patch by Douglas Stockwell dstockw...@chromium.org on 2012-04-25
Reviewed by Ojan Vafai.
Source/WebCore:
Ensure that the iterator over the tree of cached adds/removes always points at
the current key, or if the db iterator is current, the next key:
- When refreshing the tree iterator after a mutation, always seek unless the
tree iterator is current.
- When handing conflicts and delete markers, only advance the tree iterator as
far as the db iterator.
Remove the expensive (and now redundant) logic that issued a get() to check
whether an item had been deleted.
Test: storage/indexeddb/cursor-added-bug.html
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
* platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
LayoutTests:
New test for keys added in reverse order during cursor iteration.
* storage/indexeddb/cursor-added-bug-expected.txt: Added.
* storage/indexeddb/cursor-added-bug.html: Added.
* storage/indexeddb/resources/cursor-added-bug.js: Added.
(test):
(openSuccess):
(setVersionSuccess):
(openCursor):
(cursorSuccess):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp
trunk/Source/WebCore/platform/leveldb/LevelDBTransaction.h
Added Paths
trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html
trunk/LayoutTests/storage/indexeddb/resources/cursor-added-bug.js
Diff
Modified: trunk/LayoutTests/ChangeLog (115259 => 115260)
--- trunk/LayoutTests/ChangeLog 2012-04-25 23:51:06 UTC (rev 115259)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 23:52:12 UTC (rev 115260)
@@ -1,3 +1,21 @@
+2012-04-25 Douglas Stockwell dstockw...@chromium.org
+
+IndexedDB: cursor does not correctly iterate over keys added and removed during iteration
+https://bugs.webkit.org/show_bug.cgi?id=84467
+
+Reviewed by Ojan Vafai.
+
+New test for keys added in reverse order during cursor iteration.
+
+* storage/indexeddb/cursor-added-bug-expected.txt: Added.
+* storage/indexeddb/cursor-added-bug.html: Added.
+* storage/indexeddb/resources/cursor-added-bug.js: Added.
+(test):
+(openSuccess):
+(setVersionSuccess):
+(openCursor):
+(cursorSuccess):
+
2012-04-25 Alec Flett alecfl...@chromium.org
IndexedDB: support openCursor(IDBKey)
Added: trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt (0 => 115260)
--- trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt 2012-04-25 23:52:12 UTC (rev 115260)
@@ -0,0 +1,39 @@
+Test IndexedDB cursor iterates correctly over values added during iteration.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.open('cursor-delete')
+db = event.target.result
+db.setVersion('new version')
+trans = event.target.result
+PASS trans !== null is true
+Deleted all object stores.
+objectStore = db.createObjectStore('test')
+objectStore.add(1, 1)
+objectStore.add(2, 2)
+objectStore.add(3, 3)
+trans = db.transaction(['test'], IDBTransaction.READ_WRITE)
+trans.objectStore('test').openCursor()
+PASS event.target.result.key is 1
+trans.objectStore('test').add(6, 6)
+event.target.result.continue()
+PASS event.target.result.key is 2
+trans.objectStore('test').add(5, 5)
+event.target.result.continue()
+PASS event.target.result.key is 3
+trans.objectStore('test').add(4, 4)
+event.target.result.continue()
+PASS event.target.result.key is 4
+event.target.result.continue()
+PASS event.target.result.key is 5
+event.target.result.continue()
+PASS event.target.result.key is 6
+event.target.result.continue()
+PASS counter is 6
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html (0 => 115260)
--- trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html 2012-04-25 23:52:12 UTC (rev 115260)
@@ -0,0 +1,10 @@
+html
+head
+script src=""
+script src=""
+/head
+body
+script src=""
+script src=""
+/body
+/html
Added: trunk/LayoutTests/storage/indexeddb/resources/cursor-added-bug.js (0 => 115260)
---
[webkit-changes] [115261] branches/subpixellayout/LayoutTests/css2.1
Title: [115261] branches/subpixellayout/LayoutTests/css2.1
Revision 115261
Author le...@chromium.org
Date 2012-04-25 17:00:10 -0700 (Wed, 25 Apr 2012)
Log Message
Adding a tiny fraction to the css values of these tests to make up for lost Float precision when calculating margins when Lengths are floats.
Modified Paths
branches/subpixellayout/LayoutTests/css2.1/t0803-c5501-mrgn-t-00-b-a.html
branches/subpixellayout/LayoutTests/css2.1/t0803-c5503-mrgn-b-00-b-a.html
Diff
Modified: branches/subpixellayout/LayoutTests/css2.1/t0803-c5501-mrgn-t-00-b-a.html (115260 => 115261)
--- branches/subpixellayout/LayoutTests/css2.1/t0803-c5501-mrgn-t-00-b-a.html 2012-04-25 23:52:12 UTC (rev 115260)
+++ branches/subpixellayout/LayoutTests/css2.1/t0803-c5501-mrgn-t-00-b-a.html 2012-04-26 00:00:10 UTC (rev 115261)
@@ -5,7 +5,7 @@
style type=text/css
.test { font: 10px/1 Ahem; width: 10em; border: solid black; padding: 0; background: yellow; color: orange; }
.zero {background-color: teal; margin-top: 0;}
- .one {margin-top: 5.29166mm; background-color: aqua;}
+ .one {margin-top: 5.29167mm; background-color: aqua;}
.two {margin-top: 20px; background-color: blue;}
.three {margin-top: 2em; background-color: aqua;}
.four {margin-top: 20%; background-color: teal;}
Modified: branches/subpixellayout/LayoutTests/css2.1/t0803-c5503-mrgn-b-00-b-a.html (115260 => 115261)
--- branches/subpixellayout/LayoutTests/css2.1/t0803-c5503-mrgn-b-00-b-a.html 2012-04-25 23:52:12 UTC (rev 115260)
+++ branches/subpixellayout/LayoutTests/css2.1/t0803-c5503-mrgn-b-00-b-a.html 2012-04-26 00:00:10 UTC (rev 115261)
@@ -5,7 +5,7 @@
style type=text/css
.test { font: 10px/1 Ahem; width: 10em; border: solid black; padding: 0; background: yellow; color: orange; }
.zero {background-color: teal; margin-bottom: 0;}
- .one {margin-bottom: 5.29166mm; background-color: aqua;}
+ .one {margin-bottom: 5.29167mm; background-color: aqua;}
.two {margin-bottom: 20px; background-color: blue;}
.three {margin-bottom: 2em; background-color: aqua;}
.four {margin-bottom: 20%; background-color: teal;}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115262] trunk/Source/WebKit/chromium
Title: [115262] trunk/Source/WebKit/chromium Revision 115262 Author jsb...@chromium.org Date 2012-04-25 17:07:34 -0700 (Wed, 25 Apr 2012) Log Message [Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API https://bugs.webkit.org/show_bug.cgi?id=84631 Reviewed by James Robinson. WebIDBKeyPath was previously a utility class for parsing key paths into components, but the API exposed key paths only as nullable strings. To support array-type keypaths, WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods are retained but will be cleaned up after all callers have been updated, tracked as the bug: http://webkit.org/b/84207 * public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch. * public/WebIDBIndex.h: (WebKit::WebIDBIndex::keyPath): Calls keyPathString if not overridden. (WebKit::WebIDBIndex::keyPathString): Comment change. * public/WebIDBKeyPath.h: (WebKit::WebIDBKeyPath::create): Overload added for creating array-type key paths. (WebKit::WebIDBKeyPath::array): Accessor for array-type key paths. (WebKit::WebIDBKeyPath::operator const WebString ): Temporary, for compatibility. * public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::keyPath): Calls keyPathString if not overridden. (WebKit::WebIDBObjectStore::keyPathString): Comment change. (WebKit::WebIDBObjectStore::createIndex): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch. * public/platform/WebKitPlatformSupport.h: (WebKitPlatformSupport): WebIDBKeyPath overloads for these methods added, delegate to WebString version until implementers are updated. (WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath): (WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue): * src/IDBIndexBackendProxy.cpp: (WebKit::IDBIndexBackendProxy::keyPath): Returns the string version until WebCore is updated. * src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::keyPath): Returns the string version until WebCore is updated. * src/WebIDBDatabaseImpl.h: (WebIDBDatabaseImpl): Add createObjectStore overload for WebIDBKeyPath type, delegates to WebString version until callers are updated. * src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::keyPath): Implements the new WebIDBKeyPath return type. (WebKit): * src/WebIDBIndexImpl.h: (WebIDBIndexImpl): Implements the new WebIDBKeyPath return type. * src/WebIDBKeyPath.cpp: (WebKit::WebIDBKeyPath::create): Support null key path types. (WebKit::WebIDBKeyPath::createNull): New API. (WebKit): (WebKit::WebIDBKeyPath::isValid): New API. (WebKit::WebIDBKeyPath::type): New API. (WebKit::WebIDBKeyPath::string): New API (value accessor). (WebKit::WebIDBKeyPath::WebIDBKeyPath): (WebKit::WebIDBKeyPath::assign): This API will be removed. (WebKit::WebIDBKeyPath::operator const WTF::VectorWTF::String, 0): Ensure it is non-null - only used in copy constructor which guards against this. * src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::keyPath): Implement the new WebIDBKeyPath return type. (WebKit): * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): Add createIndex overload for WebIDBKeyPath type, delegates to WebString version until callers are updated. Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebIDBDatabase.h trunk/Source/WebKit/chromium/public/WebIDBIndex.h trunk/Source/WebKit/chromium/public/WebIDBKeyPath.h trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h trunk/Source/WebKit/chromium/src/IDBIndexBackendProxy.cpp trunk/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.cpp trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.h trunk/Source/WebKit/chromium/src/WebIDBKeyPath.cpp trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (115261 => 115262) --- trunk/Source/WebKit/chromium/ChangeLog 2012-04-26 00:00:10 UTC (rev 115261) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-26 00:07:34 UTC (rev 115262) @@ -1,3 +1,60 @@ +2012-04-25 Joshua Bell jsb...@chromium.org + +[Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API +https://bugs.webkit.org/show_bug.cgi?id=84631 + +Reviewed by James Robinson. + +WebIDBKeyPath was previously a utility class for parsing key paths into components, +but the API exposed key paths only as nullable strings. To support array-type keypaths, +WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods +are retained but will be cleaned up after all callers have been updated, tracked as +the bug:
[webkit-changes] [115265] trunk/LayoutTests
Title: [115265] trunk/LayoutTests
Revision 115265
Author ach...@adobe.com
Date 2012-04-25 17:29:41 -0700 (Wed, 25 Apr 2012)
Log Message
[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing
https://bugs.webkit.org/show_bug.cgi?id=84067
Reviewed by Ryosuke Niwa.
All the CSS filters/shaders script tests expected to have a document.styleSheets.item(0) that they could change.
The script-tests add a link that references a CSS file from a different parent folder, so the script
has no access to the actual rules anymore. Updated all the tests to use createElement(style)
and get the styleSheet by using el.sheet instead of assuming that there's one style already created.
* css3/filters/script-tests/custom-filter-property-computed-style.js:
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
(testInvalidFilterRule):
* css3/filters/script-tests/effect-custom-disabled.js:
(testInvalidFilterRule):
* css3/filters/script-tests/filter-property-computed-style.js:
(testComputedFilterRule):
* css3/filters/script-tests/filter-property-parsing-invalid.js:
(testInvalidFilterRule):
* css3/filters/script-tests/filter-property-parsing.js:
(testFilterRule):
* css3/filters/script-tests/filter-property.js:
* platform/chromium/test_expectations.txt: Removed reference to this bug.
* platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed. This is not necessary anymore.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/filters/script-tests/custom-filter-property-computed-style.js
trunk/LayoutTests/css3/filters/script-tests/custom-filter-property-parsing-invalid.js
trunk/LayoutTests/css3/filters/script-tests/effect-custom-disabled.js
trunk/LayoutTests/css3/filters/script-tests/filter-property-computed-style.js
trunk/LayoutTests/css3/filters/script-tests/filter-property-parsing-invalid.js
trunk/LayoutTests/css3/filters/script-tests/filter-property-parsing.js
trunk/LayoutTests/css3/filters/script-tests/filter-property.js
trunk/LayoutTests/platform/chromium/test_expectations.txt
Removed Paths
trunk/LayoutTests/platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (115264 => 115265)
--- trunk/LayoutTests/ChangeLog 2012-04-26 00:28:47 UTC (rev 115264)
+++ trunk/LayoutTests/ChangeLog 2012-04-26 00:29:41 UTC (rev 115265)
@@ -1,5 +1,32 @@
2012-04-25 Alexandru Chiculita ach...@adobe.com
+[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=84067
+
+Reviewed by Ryosuke Niwa.
+
+All the CSS filters/shaders script tests expected to have a document.styleSheets.item(0) that they could change.
+The script-tests add a link that references a CSS file from a different parent folder, so the script
+has no access to the actual rules anymore. Updated all the tests to use createElement(style)
+and get the styleSheet by using el.sheet instead of assuming that there's one style already created.
+
+* css3/filters/script-tests/custom-filter-property-computed-style.js:
+* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
+(testInvalidFilterRule):
+* css3/filters/script-tests/effect-custom-disabled.js:
+(testInvalidFilterRule):
+* css3/filters/script-tests/filter-property-computed-style.js:
+(testComputedFilterRule):
+* css3/filters/script-tests/filter-property-parsing-invalid.js:
+(testInvalidFilterRule):
+* css3/filters/script-tests/filter-property-parsing.js:
+(testFilterRule):
+* css3/filters/script-tests/filter-property.js:
+* platform/chromium/test_expectations.txt: Removed reference to this bug.
+* platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed. This is not necessary anymore.
+
+2012-04-25 Alexandru Chiculita ach...@adobe.com
+
CSS Shaders: Use u_texture instead of s_texture. It was updated in the spec
https://bugs.webkit.org/show_bug.cgi?id=82618
Modified: trunk/LayoutTests/css3/filters/script-tests/custom-filter-property-computed-style.js (115264 => 115265)
--- trunk/LayoutTests/css3/filters/script-tests/custom-filter-property-computed-style.js 2012-04-26 00:28:47 UTC (rev 115264)
+++ trunk/LayoutTests/css3/filters/script-tests/custom-filter-property-computed-style.js 2012-04-26 00:29:41 UTC (rev 115265)
@@ -34,13 +34,15 @@
// These have to be global for the test helpers to see them.
var stylesheet, cssRule, declaration, filterRule, subRule;
+var styleElement = document.createElement(style);
+document.head.appendChild(styleElement);
+stylesheet = styleElement.sheet;
function testFilterRule(description, rule, expectedValue, expectedTypes, expectedTexts)
{
debug();
debug(description + : +
[webkit-changes] [115266] trunk/Source/WebKit2
Title: [115266] trunk/Source/WebKit2
Revision 115266
Author bda...@apple.com
Date 2012-04-25 17:46:26 -0700 (Wed, 25 Apr 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor 1
-and corresponding-
rdar://problem/11312064
Reviewed by Darin Adler.
BackingStoreMac paints into a Bitmap instead of a CGLayer when there is no
containing window. That bitmap is used for the initial paint when a background tab
first comes to he foreground, so it needs to be HiDPI-aware.
paintBitmapContext() now takes a scale factor that it passes along to paintImage
rather than hardcoding a scale factor of 1 for paintImage.
* Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext):
* Platform/cg/CGUtilities.h:
(WebKit):
When these functions fall into the bitmap case, they need to adopt the device
scale factor, which means they need to scale in size by the scale factor, and also
scale their context.
* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp
trunk/Source/WebKit2/Platform/cg/CGUtilities.h
trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (115265 => 115266)
--- trunk/Source/WebKit2/ChangeLog 2012-04-26 00:29:41 UTC (rev 115265)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-26 00:46:26 UTC (rev 115266)
@@ -1,3 +1,31 @@
+2012-04-25 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=84909
+Background tabs are fuzzy until repaint when deviceScaleFactor 1
+-and corresponding-
+rdar://problem/11312064
+
+Reviewed by Darin Adler.
+
+BackingStoreMac paints into a Bitmap instead of a CGLayer when there is no
+containing window. That bitmap is used for the initial paint when a background tab
+first comes to he foreground, so it needs to be HiDPI-aware.
+
+paintBitmapContext() now takes a scale factor that it passes along to paintImage
+rather than hardcoding a scale factor of 1 for paintImage.
+* Platform/cg/CGUtilities.cpp:
+(WebKit::paintBitmapContext):
+* Platform/cg/CGUtilities.h:
+(WebKit):
+
+When these functions fall into the bitmap case, they need to adopt the device
+scale factor, which means they need to scale in size by the scale factor, and also
+scale their context.
+* UIProcess/mac/BackingStoreMac.mm:
+(WebKit::BackingStore::resetScrolledRect):
+(WebKit::BackingStore::paint):
+(WebKit::BackingStore::backingStoreContext):
+
2012-04-25 Enrica Casucci enr...@apple.com
REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
Modified: trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp (115265 => 115266)
--- trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp 2012-04-26 00:29:41 UTC (rev 115265)
+++ trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp 2012-04-26 00:46:26 UTC (rev 115266)
@@ -48,10 +48,10 @@
CGContextRestoreGState(context);
}
-void paintBitmapContext(CGContextRef context, CGContextRef bitmapContext, CGPoint destination, CGRect source)
+void paintBitmapContext(CGContextRef context, CGContextRef bitmapContext, CGPoint destination, CGRect source, CGFloat scaleFactor)
{
RetainPtrCGImageRef image(AdoptCF, CGBitmapContextCreateImage(bitmapContext));
-paintImage(context, image.get(), 1, destination, source);
+paintImage(context, image.get(), scaleFactor, destination, source);
}
} // namespace WebKit
Modified: trunk/Source/WebKit2/Platform/cg/CGUtilities.h (115265 => 115266)
--- trunk/Source/WebKit2/Platform/cg/CGUtilities.h 2012-04-26 00:29:41 UTC (rev 115265)
+++ trunk/Source/WebKit2/Platform/cg/CGUtilities.h 2012-04-26 00:46:26 UTC (rev 115266)
@@ -29,7 +29,7 @@
namespace WebKit {
void paintImage(CGContextRef, CGImageRef, CGFloat scaleFactor, CGPoint destination, CGRect source);
-void paintBitmapContext(CGContextRef, CGContextRef bitmapContext, CGPoint destination, CGRect source);
+void paintBitmapContext(CGContextRef, CGContextRef bitmapContext, CGPoint destination, CGRect source, CGFloat scaleFactor);
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm (115265 => 115266)
--- trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm 2012-04-26 00:29:41 UTC (rev 115265)
+++ trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm 2012-04-26 00:46:26 UTC (rev 115266)
@@ -97,16 +97,21 @@
return;
}
+IntSize scaledSize = m_scrolledRect.size();
+scaledSize.scale(m_deviceScaleFactor);
+
RetainPtrCGColorSpaceRef colorSpace(AdoptCF, CGColorSpaceCreateDeviceRGB());
-RetainPtrCGContextRef context(AdoptCF, CGBitmapContextCreate(0,
[webkit-changes] [115267] trunk/Source/WebCore
Title: [115267] trunk/Source/WebCore
Revision 115267
Author tk...@chromium.org
Date 2012-04-25 18:03:08 -0700 (Wed, 25 Apr 2012)
Log Message
Unreviewed. Sort Xcode project file.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (115266 => 115267)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 00:46:26 UTC (rev 115266)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 01:03:08 UTC (rev 115267)
@@ -1,3 +1,9 @@
+2012-04-25 Kent Tamura tk...@chromium.org
+
+Unreviewed. Sort Xcode project file.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2012-04-25 Greg Billock gbill...@google.com
Implement object-literal constructor for the Intent object.
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (115266 => 115267)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-04-26 00:46:26 UTC (rev 115266)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-04-26 01:03:08 UTC (rev 115267)
@@ -13914,6 +13914,7 @@
46D4F2460AF97E810035385A /* cellCursor.png */,
46D4F2470AF97E810035385A /* contextMenuCursor.png */,
4614A1FD0B23A8D600446E1C /* copyCursor.png */,
+E1C2F244153398CE0083F974 /* DefaultFonts.plist.in */,
93153BDD141959F400FCF5BE /* deleteButton.png */,
93153BCC1417FBBF00FCF5BE /* deletebut...@2x.png */,
93153BDF14195A2800FCF5BE /* deleteButtonPressed.png */,
@@ -13947,7 +13948,6 @@
85136C980AED665900F90A3D /* westResizeCursor.png */,
1AB1AE780C051FDE00139F4F /* zoomInCursor.png */,
1AB1AE790C051FDE00139F4F /* zoomOutCursor.png */,
-E1C2F244153398CE0083F974 /* DefaultFonts.plist.in */,
);
path = Resources;
sourceTree = group;
@@ -14196,9 +14196,9 @@
children = (
1AF62EE314DA22A70041556C /* ScrollingCoordinatorMac.mm */,
1AF62F2314DAFE910041556C /* ScrollingThreadMac.mm */,
+1A35862A152522540022A659 /* ScrollingTreeMac.mm */,
1AAADDE714DC8DF800AF64B3 /* ScrollingTreeNodeMac.h */,
1AAADDE614DC8DF800AF64B3 /* ScrollingTreeNodeMac.mm */,
-1A35862A152522540022A659 /* ScrollingTreeMac.mm */,
1AAADDD814DC74EC00AF64B3 /* ScrollingTreeStateMac.mm */,
);
path = mac;
@@ -14672,9 +14672,6 @@
49484FAE102CF01E00187DD3 /* canvas */ = {
isa = PBXGroup;
children = (
-A08CF153152B77B3009C5775 /* WebGLShaderPrecisionFormat.cpp */,
-A07D3359152B633E001B6393 /* WebGLShaderPrecisionFormat.idl */,
-A07D3357152B632D001B6393 /* WebGLShaderPrecisionFormat.h */,
49EECDCC10503C2300099FAB /* ArrayBuffer.idl */,
49EECDC910503C2300099FAB /* ArrayBufferView.idl */,
6E4E91A710F7FB3100A2779C /* CanvasContextAttributes.cpp */,
@@ -14766,6 +14763,9 @@
49C7B9C21042D32F0009D447 /* WebGLShader.cpp */,
49C7B9C31042D32F0009D447 /* WebGLShader.h */,
49C7B9C41042D32F0009D447 /* WebGLShader.idl */,
+A08CF153152B77B3009C5775 /* WebGLShaderPrecisionFormat.cpp */,
+A07D3357152B632D001B6393 /* WebGLShaderPrecisionFormat.h */,
+A07D3359152B633E001B6393 /* WebGLShaderPrecisionFormat.idl */,
01D3CF8014BD0A3000FE9970 /* WebGLSharedObject.cpp */,
01D3CF8114BD0A3000FE9970 /* WebGLSharedObject.h */,
49C7B9C51042D32F0009D447 /* WebGLTexture.cpp */,
@@ -15084,8 +15084,8 @@
E41EA0391198374900710BC5 /* CSSValueKeywords.cpp */,
6565814709D13043000E61D7 /* CSSValueKeywords.gperf */,
6565814809D13043000E61D7 /* CSSValueKeywords.h */,
+E19582301536099C00B60875 /* DefaultFonts.plist */,
9B3A8871145632F9003AE8F5 /* DOMDOMSettableTokenList.h */,
-E19582301536099C00B60875 /* DefaultFonts.plist */,
9766504E144FBFFE00F6BB51 /* EventFactory.cpp */,
970B72A5145008EB00F00A37 /* EventHeaders.h */,
970B7289144FFAC600F00A37 /* EventInterfaces.h */,
@@ -16750,9 +16750,9 @@
93309DC0099E64910056E581 /* SetNodeAttributeCommand.cpp */,
93309DC1099E64910056E581 /* SetNodeAttributeCommand.h */,
B8DBDB47130B0F8A00F5CDB1 /* SetSelectionCommand.cpp */,
+B8DBDB48130B0F8A00F5CDB1 /* SetSelectionCommand.h */,
C5A1EA79152BC486004D00B6 /* SimplifyMarkupCommand.cpp */,
C5A1EA7A152BC486004D00B6 /* SimplifyMarkupCommand.h */,
-B8DBDB48130B0F8A00F5CDB1 /* SetSelectionCommand.h */,
4B6FA6F30C39E48C00087011 /* SmartReplace.cpp */,
4B6FA6F20C39E48C00087011 /* SmartReplace.h */,
4B6FA6F60C39E4A100087011 /* SmartReplaceCF.cpp */,
@@ -19371,6 +19371,8 @@
B2A10B910B3818BD00099AA4 /* ImageBuffer.h */,
22BD9F7D1353625C009BD102 /* ImageBufferData.h */,
BC7F44A70B9E324E00A9D081 /* ImageObserver.h */,
+A8748D7412CC3F89001FBA41 /* ImageOrientation.cpp */,
+A8748D6612CC3763001FBA41 /* ImageOrientation.h */,
49291E4A134172C800E753DE /* ImageRenderingMode.h */,
B27535430B053814002CE64F /* ImageSource.h */,
B27535440B053814002CE64F /* IntPoint.h */,
@@ -19416,8 +19418,6 @@
[webkit-changes] [115268] trunk/Tools
Title: [115268] trunk/Tools
Revision 115268
Author dpra...@chromium.org
Date 2012-04-25 18:03:53 -0700 (Wed, 25 Apr 2012)
Log Message
[chromium] change DRT's DRT output to match the other ports
https://bugs.webkit.org/show_bug.cgi?id=84904
Reviewed by Kent Tamura.
Since we run Chromium's DRT in --test-shell mode, the
non-test-shell output has never been really beaten on to make
sure it's right. This fixes a few issues and will be tested
with upcoming NRWT changes that'll land in a separate patch.
In particular we should never output framing text like \n
or #EOF outside of something outside of TestEventPrinter,
and we weren't handling audio output properly at all.
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter):
(TestShellPrinter):
(DRTPrinter::handleTextFooter):
(DRTPrinter::handleAudioFooter):
(DRTPrinter::handleTestFooter):
(TestShellPrinter::handleAudioFooter):
* DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::dump):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestEventPrinter.cpp
trunk/Tools/DumpRenderTree/chromium/TestEventPrinter.h
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
Diff
Modified: trunk/Tools/ChangeLog (115267 => 115268)
--- trunk/Tools/ChangeLog 2012-04-26 01:03:08 UTC (rev 115267)
+++ trunk/Tools/ChangeLog 2012-04-26 01:03:53 UTC (rev 115268)
@@ -1,3 +1,31 @@
+2012-04-25 Dirk Pranke dpra...@chromium.org
+
+[chromium] change DRT's DRT output to match the other ports
+https://bugs.webkit.org/show_bug.cgi?id=84904
+
+Reviewed by Kent Tamura.
+
+Since we run Chromium's DRT in --test-shell mode, the
+non-test-shell output has never been really beaten on to make
+sure it's right. This fixes a few issues and will be tested
+with upcoming NRWT changes that'll land in a separate patch.
+In particular we should never output framing text like \n
+or #EOF outside of something outside of TestEventPrinter,
+and we weren't handling audio output properly at all.
+
+* DumpRenderTree/chromium/TestEventPrinter.cpp:
+(DRTPrinter):
+(TestShellPrinter):
+(DRTPrinter::handleTextFooter):
+(DRTPrinter::handleAudioFooter):
+(DRTPrinter::handleTestFooter):
+(TestShellPrinter::handleAudioFooter):
+* DumpRenderTree/chromium/TestEventPrinter.h:
+(TestEventPrinter):
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::TestShell):
+(TestShell::dump):
+
2012-04-25 Joshua Bell jsb...@chromium.org
Unreviewed: Adding Alec Flett as a contributor (non-committer).
Modified: trunk/Tools/DumpRenderTree/chromium/TestEventPrinter.cpp (115267 => 115268)
--- trunk/Tools/DumpRenderTree/chromium/TestEventPrinter.cpp 2012-04-26 01:03:08 UTC (rev 115267)
+++ trunk/Tools/DumpRenderTree/chromium/TestEventPrinter.cpp 2012-04-26 01:03:53 UTC (rev 115268)
@@ -43,6 +43,7 @@
void handleTextHeader() const;
void handleTextFooter() const;
void handleAudioHeader() const;
+void handleAudioFooter() const;
void handleImage(const char* actualHash, const char* expectedHash, const unsigned char* imageData, size_t imageSize, const char* fileName) const;
void handleImageFooter() const;
void handleTestFooter(bool dumpedAnything) const;
@@ -56,6 +57,7 @@
void handleTextHeader() const;
void handleTextFooter() const;
void handleAudioHeader() const;
+void handleAudioFooter() const;
void handleImage(const char* actualHash, const char* expectedHash, const unsigned char* imageData, size_t imageSize, const char* fileName) const;
void handleImageFooter() const;
void handleTestFooter(bool dumpedAnything) const;
@@ -95,6 +97,7 @@
void DRTPrinter::handleTextFooter() const
{
printf(#EOF\n);
+fprintf(stderr, #EOF\n);
}
void DRTPrinter::handleAudioHeader() const
@@ -102,6 +105,12 @@
printf(Content-Type: audio/wav\n);
}
+void DRTPrinter::handleAudioFooter() const
+{
+printf(#EOF\n);
+fprintf(stderr, #EOF\n);
+}
+
void DRTPrinter::handleImage(const char* actualHash, const char* expectedHash, const unsigned char* imageData, size_t imageSize, const char*) const
{
ASSERT(actualHash);
@@ -119,15 +128,11 @@
}
}
-void DRTPrinter::handleImageFooter() const
+void DRTPrinter::handleTestFooter(bool) const
{
printf(#EOF\n);
}
-void DRTPrinter::handleTestFooter(bool) const
-{
-}
-
//
void TestShellPrinter::handleTestHeader(const char* url) const
@@ -153,6 +158,11 @@
printf(Content-Type: audio/wav\n);
}
+void TestShellPrinter::handleAudioFooter() const
+{
+printf(\n);
+}
+
void TestShellPrinter::handleImage(const char* actualHash, const char*, const unsigned char* imageData, size_t imageSize, const char* fileName) const
{
[webkit-changes] [115269] trunk/Source/WebCore
Title: [115269] trunk/Source/WebCore
Revision 115269
Author benja...@webkit.org
Date 2012-04-25 18:06:24 -0700 (Wed, 25 Apr 2012)
Log Message
Move convertJSMethodNameToObjc() to be a utility function of ObjcClass
https://bugs.webkit.org/show_bug.cgi?id=84915
Patch by Benjamin Poulain bpoul...@apple.com on 2012-04-25
Reviewed by Darin Adler.
The function convertJSMethodNameToObjc() is only useful for ObjcClass::methodsNamed().
This patch moves the function from objc_utility.mm to be a static function in objc_class.mm.
It aims at simplifying the code for future changes of ObjcClass.
* bridge/objc/objc_class.mm:
(Bindings):
(JSC::Bindings::convertJSMethodNameToObjc):
* bridge/objc/objc_utility.h:
* bridge/objc/objc_utility.mm:
(Bindings):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/objc/objc_class.mm
trunk/Source/WebCore/bridge/objc/objc_utility.h
trunk/Source/WebCore/bridge/objc/objc_utility.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (115268 => 115269)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 01:03:53 UTC (rev 115268)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 01:06:24 UTC (rev 115269)
@@ -1,3 +1,22 @@
+2012-04-25 Benjamin Poulain bpoul...@apple.com
+
+Move convertJSMethodNameToObjc() to be a utility function of ObjcClass
+https://bugs.webkit.org/show_bug.cgi?id=84915
+
+Reviewed by Darin Adler.
+
+The function convertJSMethodNameToObjc() is only useful for ObjcClass::methodsNamed().
+
+This patch moves the function from objc_utility.mm to be a static function in objc_class.mm.
+It aims at simplifying the code for future changes of ObjcClass.
+
+* bridge/objc/objc_class.mm:
+(Bindings):
+(JSC::Bindings::convertJSMethodNameToObjc):
+* bridge/objc/objc_utility.h:
+* bridge/objc/objc_utility.mm:
+(Bindings):
+
2012-04-25 Kent Tamura tk...@chromium.org
Unreviewed. Sort Xcode project file.
Modified: trunk/Source/WebCore/bridge/objc/objc_class.mm (115268 => 115269)
--- trunk/Source/WebCore/bridge/objc/objc_class.mm 2012-04-26 01:03:53 UTC (rev 115268)
+++ trunk/Source/WebCore/bridge/objc/objc_class.mm 2012-04-26 01:06:24 UTC (rev 115269)
@@ -66,6 +66,56 @@
return aClass;
}
+/*
+By default, a _javascript_ method name is produced by concatenating the
+components of an ObjectiveC method name, replacing ':' with '_', and
+escaping '_' and '$' with a leading '$', such that '_' becomes $_ and
+'$' becomes $$. For example:
+
+ObjectiveC name Default _javascript_ name
+moveTo::moveTo__
+moveTo_ moveTo$_
+moveTo$_moveTo$$$_
+
+This function performs the inverse of that operation.
+
+@result Fills 'buffer' with the ObjectiveC method name that corresponds to 'JSName'.
+Returns true for success, false for failure. (Failure occurs when 'buffer'
+is not big enough to hold the result.)
+*/
+static bool convertJSMethodNameToObjc(const char *JSName, char *buffer, size_t bufferSize)
+{
+ASSERT(JSName buffer);
+
+const char *sp = JSName; // source pointer
+char *dp = buffer; // destination pointer
+
+char *end = buffer + bufferSize;
+while (dp end) {
+if (*sp == '$') {
+++sp;
+*dp = *sp;
+} else if (*sp == '_')
+*dp = ':';
+else
+*dp = *sp;
+
+// If a future coder puts funny ++ operators above, we might write off the end
+// of the buffer in the middle of this loop. Let's make sure to check for that.
+ASSERT(dp end);
+
+if (*sp == 0) { // We finished converting JSName
+ASSERT(strlen(JSName) bufferSize);
+return true;
+}
+
+++sp;
+++dp;
+}
+
+return false; // We ran out of buffer before converting JSName
+}
+
MethodList ObjcClass::methodsNamed(const Identifier identifier, Instance*) const
{
MethodList methodList;
Modified: trunk/Source/WebCore/bridge/objc/objc_utility.h (115268 => 115269)
--- trunk/Source/WebCore/bridge/objc/objc_utility.h 2012-04-26 01:03:53 UTC (rev 115268)
+++ trunk/Source/WebCore/bridge/objc/objc_utility.h 2012-04-26 01:06:24 UTC (rev 115269)
@@ -74,8 +74,6 @@
JSValue convertObjcValueToValue(ExecState*, void* buffer, ObjcValueType, RootObject*);
ObjcValueType objcValueTypeForType(const char *type);
-bool convertJSMethodNameToObjc(const char *JSName, char *buffer, size_t bufferSize);
-
JSObject *throwError(ExecState *, NSString *message);
} // namespace Bindings
Modified: trunk/Source/WebCore/bridge/objc/objc_utility.mm (115268 => 115269)
--- trunk/Source/WebCore/bridge/objc/objc_utility.mm 2012-04-26 01:03:53 UTC (rev 115268)
+++ trunk/Source/WebCore/bridge/objc/objc_utility.mm 2012-04-26 01:06:24 UTC (rev 115269)
@@ -66,57 +66,7 @@
namespace Bindings {
/*
-By default, a _javascript_
[webkit-changes] [115270] trunk/Source/WebKit2
Title: [115270] trunk/Source/WebKit2
Revision 115270
Author bda...@apple.com
Date 2012-04-25 18:07:35 -0700 (Wed, 25 Apr 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor 1
-and corresponding-
rdar://problem/11312064
Rubber-stamped by Darin Adler.
Re-order the parameters of paintBitmapContext to match paintImage.
* Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext):
* Platform/cg/CGUtilities.h:
(WebKit):
* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp
trunk/Source/WebKit2/Platform/cg/CGUtilities.h
trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (115269 => 115270)
--- trunk/Source/WebKit2/ChangeLog 2012-04-26 01:06:24 UTC (rev 115269)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-26 01:07:35 UTC (rev 115270)
@@ -5,6 +5,25 @@
-and corresponding-
rdar://problem/11312064
+Rubber-stamped by Darin Adler.
+
+Re-order the parameters of paintBitmapContext to match paintImage.
+* Platform/cg/CGUtilities.cpp:
+(WebKit::paintBitmapContext):
+* Platform/cg/CGUtilities.h:
+(WebKit):
+* UIProcess/mac/BackingStoreMac.mm:
+(WebKit::BackingStore::resetScrolledRect):
+(WebKit::BackingStore::paint):
+(WebKit::BackingStore::backingStoreContext):
+
+2012-04-25 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=84909
+Background tabs are fuzzy until repaint when deviceScaleFactor 1
+-and corresponding-
+rdar://problem/11312064
+
Reviewed by Darin Adler.
BackingStoreMac paints into a Bitmap instead of a CGLayer when there is no
Modified: trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp (115269 => 115270)
--- trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp 2012-04-26 01:06:24 UTC (rev 115269)
+++ trunk/Source/WebKit2/Platform/cg/CGUtilities.cpp 2012-04-26 01:07:35 UTC (rev 115270)
@@ -48,7 +48,7 @@
CGContextRestoreGState(context);
}
-void paintBitmapContext(CGContextRef context, CGContextRef bitmapContext, CGPoint destination, CGRect source, CGFloat scaleFactor)
+void paintBitmapContext(CGContextRef context, CGContextRef bitmapContext, CGFloat scaleFactor, CGPoint destination, CGRect source)
{
RetainPtrCGImageRef image(AdoptCF, CGBitmapContextCreateImage(bitmapContext));
paintImage(context, image.get(), scaleFactor, destination, source);
Modified: trunk/Source/WebKit2/Platform/cg/CGUtilities.h (115269 => 115270)
--- trunk/Source/WebKit2/Platform/cg/CGUtilities.h 2012-04-26 01:06:24 UTC (rev 115269)
+++ trunk/Source/WebKit2/Platform/cg/CGUtilities.h 2012-04-26 01:07:35 UTC (rev 115270)
@@ -29,7 +29,7 @@
namespace WebKit {
void paintImage(CGContextRef, CGImageRef, CGFloat scaleFactor, CGPoint destination, CGRect source);
-void paintBitmapContext(CGContextRef, CGContextRef bitmapContext, CGPoint destination, CGRect source, CGFloat scaleFactor);
+void paintBitmapContext(CGContextRef, CGContextRef bitmapContext, CGFloat scaleFactor, CGPoint destination, CGRect source);
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm (115269 => 115270)
--- trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm 2012-04-26 01:06:24 UTC (rev 115269)
+++ trunk/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm 2012-04-26 01:07:35 UTC (rev 115270)
@@ -111,7 +111,7 @@
paint(context.get(), m_scrolledRect);
IntRect sourceRect(IntPoint(), m_scrolledRect.size());
-paintBitmapContext(backingStoreContext(), context.get(), m_scrolledRect.location(), sourceRect, m_deviceScaleFactor);
+paintBitmapContext(backingStoreContext(), context.get(), m_deviceScaleFactor, m_scrolledRect.location(), sourceRect);
m_scrolledRect = IntRect();
m_scrolledRectOffset = IntSize();
@@ -137,7 +137,7 @@
source = part;
source.origin.x += offset.width();
source.origin.y += offset.height();
-paintBitmapContext(context, m_bitmapContext.get(), part.location(), source, m_deviceScaleFactor);
+paintBitmapContext(context, m_bitmapContext.get(), m_deviceScaleFactor, part.location(), source);
});
}
@@ -159,7 +159,7 @@
if (m_bitmapContext) {
// Paint the contents of the bitmap into the layer context.
-paintBitmapContext(layerContext, m_bitmapContext.get(), CGPointZero, CGRectMake(0, 0, m_size.width(), m_size.height()), m_deviceScaleFactor);
+paintBitmapContext(layerContext, m_bitmapContext.get(), m_deviceScaleFactor, CGPointZero, CGRectMake(0, 0, m_size.width(), m_size.height()));
m_bitmapContext = nullptr;
}
[webkit-changes] [115271] trunk/Source/WebKit/mac
Title: [115271] trunk/Source/WebKit/mac Revision 115271 Author bda...@apple.com Date 2012-04-25 18:11:42 -0700 (Wed, 25 Apr 2012) Log Message https://bugs.webkit.org/show_bug.cgi?id=84913 WebKit 1: Initialize deviceScaleFactor on creation of the WebView -and corresponding- rdar://problem/11322716 Reviewed by Darin Adler. Before this patch, we weren't setting the deviceScaleFactor until viewDidMoveToWindow which is quite late for background tabs. setHostWindow will happen early on though. For applications that don't use host windows, also set it from _initWithFrame. * WebView/WebView.mm: (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): (-[WebView setHostWindow:]): (-[WebView _deviceScaleFactor]): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (115270 => 115271) --- trunk/Source/WebKit/mac/ChangeLog 2012-04-26 01:07:35 UTC (rev 115270) +++ trunk/Source/WebKit/mac/ChangeLog 2012-04-26 01:11:42 UTC (rev 115271) @@ -1,3 +1,21 @@ +2012-04-25 Beth Dakin bda...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=84913 +WebKit 1: Initialize deviceScaleFactor on creation of the WebView +-and corresponding- +rdar://problem/11322716 + +Reviewed by Darin Adler. + +Before this patch, we weren't setting the deviceScaleFactor until +viewDidMoveToWindow which is quite late for background tabs. setHostWindow will +happen early on though. For applications that don't use host windows, also set it +from _initWithFrame. +* WebView/WebView.mm: +(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): +(-[WebView setHostWindow:]): +(-[WebView _deviceScaleFactor]): + 2012-04-24 Alexis Menard alexis.men...@openbossa.org Replace occurences of style selector from variables and methods names by style resolver. Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (115270 => 115271) --- trunk/Source/WebKit/mac/WebView/WebView.mm 2012-04-26 01:07:35 UTC (rev 115270) +++ trunk/Source/WebKit/mac/WebView/WebView.mm 2012-04-26 01:11:42 UTC (rev 115271) @@ -846,6 +846,7 @@ _private = [[WebViewPrivate alloc] init]; [self _commonInitializationWithFrameName:frameName groupName:groupName]; [self setMaintainsBackForwardList: YES]; +_private-page-setDeviceScaleFactor([self _deviceScaleFactor]); return self; } @@ -3964,6 +3965,7 @@ _private-hostWindow = [hostWindow retain]; for (Frame* frame = coreFrame; frame; frame = frame-tree()-traverseNext(coreFrame)) [[[kit(frame) frameView] documentView] viewDidMoveToHostWindow]; +_private-page-setDeviceScaleFactor([self _deviceScaleFactor]); } - (NSWindow *)hostWindow @@ -5664,13 +5666,18 @@ return _private-customDeviceScaleFactor; NSWindow *window = [self window]; +NSWindow *hostWindow = [self hostWindow]; #if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) if (window) return [window backingScaleFactor]; +if (hostWindow) +return [hostWindow backingScaleFactor]; return [[NSScreen mainScreen] backingScaleFactor]; #else if (window) return [window userSpaceScaleFactor]; +if (hostWindow) +return [hostWindow userSpaceScaleFactor]; return [[NSScreen mainScreen] userSpaceScaleFactor]; #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115272] trunk/Source/WTF
Title: [115272] trunk/Source/WTF
Revision 115272
Author da...@apple.com
Date 2012-04-25 18:13:06 -0700 (Wed, 25 Apr 2012)
Log Message
Iterating a HashMapString, X involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524
Reviewed by Antti Koivisto.
* wtf/HashMap.h: Added a struct template, HashMapValueTraits, that derives from
PairHashTraits, adds an isEmptyValue function that looks only at the key, not
the mapped value, in the hash table value, and uses the isHashTraitsEmptyValue
function template to check if the key is empty.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashMap.h
Diff
Modified: trunk/Source/WTF/ChangeLog (115271 => 115272)
--- trunk/Source/WTF/ChangeLog 2012-04-26 01:11:42 UTC (rev 115271)
+++ trunk/Source/WTF/ChangeLog 2012-04-26 01:13:06 UTC (rev 115272)
@@ -1,3 +1,15 @@
+2012-04-25 Darin Adler da...@apple.com
+
+Iterating a HashMapString, X involves a string equality comparison to check for the empty value
+https://bugs.webkit.org/show_bug.cgi?id=84524
+
+Reviewed by Antti Koivisto.
+
+* wtf/HashMap.h: Added a struct template, HashMapValueTraits, that derives from
+PairHashTraits, adds an isEmptyValue function that looks only at the key, not
+the mapped value, in the hash table value, and uses the isHashTraitsEmptyValue
+function template to check if the key is empty.
+
2012-04-25 Landry Breuil lan...@openbsd.org
Include sys/param.h, needed for sysctl() on OpenBSD/NetBSD
Modified: trunk/Source/WTF/wtf/HashMap.h (115271 => 115272)
--- trunk/Source/WTF/wtf/HashMap.h 2012-04-26 01:11:42 UTC (rev 115271)
+++ trunk/Source/WTF/wtf/HashMap.h 2012-04-26 01:13:06 UTC (rev 115272)
@@ -25,6 +25,7 @@
namespace WTF {
+templatetypename KeyTraits, typename MappedTraits struct HashMapValueTraits;
templatetypename PairType struct PairFirstExtractor;
templatetypename T struct ReferenceTypeMaker {
@@ -41,7 +42,7 @@
private:
typedef KeyTraitsArg KeyTraits;
typedef MappedTraitsArg MappedTraits;
-typedef PairHashTraitsKeyTraits, MappedTraits ValueTraits;
+typedef HashMapValueTraitsKeyTraits, MappedTraits ValueTraits;
public:
typedef typename KeyTraits::TraitType KeyType;
@@ -203,6 +204,14 @@
HashTableType m_impl;
};
+templatetypename KeyTraits, typename MappedTraits struct HashMapValueTraits : PairHashTraitsKeyTraits, MappedTraits {
+static const bool hasIsEmptyValueFunction = true;
+static bool isEmptyValue(const typename PairHashTraitsKeyTraits, MappedTraits::TraitType value)
+{
+return isHashTraitsEmptyValueKeyTraits(value.first);
+}
+};
+
templatetypename PairType struct PairFirstExtractor {
static const typename PairType::first_type extract(const PairType p) { return p.first; }
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115273] trunk/LayoutTests
Title: [115273] trunk/LayoutTests
Revision 115273
Author dglaz...@chromium.org
Date 2012-04-25 18:16:38 -0700 (Wed, 25 Apr 2012)
Log Message
Remove unnecessary timeouts (and closures) from content-element-in-* tests.
https://bugs.webkit.org/show_bug.cgi?id=84896
These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.
Reviewed by Ojan Vafai.
* fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
* fast/dom/shadow/content-element-in-meter-element.html: Ditto.
* fast/dom/shadow/content-element-in-progress-element.html: Ditto.
* fast/dom/shadow/content-element-in-select-element.html: Ditto.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/shadow/content-element-in-media-element.html
trunk/LayoutTests/fast/dom/shadow/content-element-in-meter-element.html
trunk/LayoutTests/fast/dom/shadow/content-element-in-progress-element.html
trunk/LayoutTests/fast/dom/shadow/content-element-in-select-element.html
Diff
Modified: trunk/LayoutTests/ChangeLog (115272 => 115273)
--- trunk/LayoutTests/ChangeLog 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/ChangeLog 2012-04-26 01:16:38 UTC (rev 115273)
@@ -1,3 +1,17 @@
+2012-04-25 Dimitri Glazkov dglaz...@chromium.org
+
+Remove unnecessary timeouts (and closures) from content-element-in-* tests.
+https://bugs.webkit.org/show_bug.cgi?id=84896
+
+These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.
+
+Reviewed by Ojan Vafai.
+
+* fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
+* fast/dom/shadow/content-element-in-meter-element.html: Ditto.
+* fast/dom/shadow/content-element-in-progress-element.html: Ditto.
+* fast/dom/shadow/content-element-in-select-element.html: Ditto.
+
2012-04-25 Alexandru Chiculita ach...@adobe.com
[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-in-media-element.html (115272 => 115273)
--- trunk/LayoutTests/fast/dom/shadow/content-element-in-media-element.html 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-in-media-element.html 2012-04-26 01:16:38 UTC (rev 115273)
@@ -29,17 +29,12 @@
var sr = new WebKitShadowRoot(div);
-var f = (function(sr, callIfDone) {
-return function() {
-var video = document.createElement('video');
-var content = document.createElement('content');
-video.appendChild(content);
-sr.appendChild(video);
-callIfDone();
-};
-})(sr, callIfDone);
-
-setTimeout(f, 0);
+var video = document.createElement('video');
+var content = document.createElement('content');
+video.appendChild(content);
+sr.appendChild(video);
+document.body.offsetWidth; // force style recalc.
+callIfDone();
});
/script
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-in-meter-element.html (115272 => 115273)
--- trunk/LayoutTests/fast/dom/shadow/content-element-in-meter-element.html 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-in-meter-element.html 2012-04-26 01:16:38 UTC (rev 115273)
@@ -29,17 +29,12 @@
var sr = new WebKitShadowRoot(div);
-var f = (function(sr, callIfDone) {
-return function() {
-var meter = document.createElement('meter');
-var content = document.createElement('content');
-meter.appendChild(content);
-sr.appendChild(meter);
-callIfDone();
-};
-})(sr, callIfDone);
-
-setTimeout(f, 0);
+var meter = document.createElement('meter');
+var content = document.createElement('content');
+meter.appendChild(content);
+sr.appendChild(meter);
+document.body.offsetWidth; // force style recalc.
+callIfDone();
});
/script
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-in-progress-element.html (115272 => 115273)
--- trunk/LayoutTests/fast/dom/shadow/content-element-in-progress-element.html 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-in-progress-element.html 2012-04-26 01:16:38 UTC (rev 115273)
@@ -29,17 +29,12 @@
var sr = new WebKitShadowRoot(div);
-var f = (function(sr, callIfDone) {
-return function() {
-var progress = document.createElement('progress');
-var content = document.createElement('content');
-progress.appendChild(content);
-sr.appendChild(progress);
-callIfDone();
-};
-})(sr, callIfDone);
-
-setTimeout(f, 0);
+var progress =
[webkit-changes] [115274] trunk/Source/WebCore
Title: [115274] trunk/Source/WebCore Revision 115274 Author simon...@chromium.org Date 2012-04-25 18:17:36 -0700 (Wed, 25 Apr 2012) Log Message [Web Timing] Add a vendor-prefixed Performance Timeline API https://bugs.webkit.org/show_bug.cgi?id=80350 As described here: http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html The API is there and should be correct, but it isn't particularly useful, because nothing is populated. Upcoming changes will add Navigation Timing and Resource Timing. Reviewed by Tony Gentilcore. No new tests. Functionality is disabled on all platforms. * CMakeLists.txt: Added PerformanceEntry* files. * DerivedSources.pri: Ditto. * GNUmakefile.list.am: Ditto. * WebCore.gypi: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * page/Performance.cpp: (WebCore::Performance::webkitGetEntries): Added. (WebCore::Performance::webkitGetEntriesByType): Added. (WebCore::Performance::webkitGetEntriesByName): Added. * page/Performance.h: (Performance): * page/Performance.idl: * page/PerformanceEntry.cpp: Added. (WebCore): (WebCore::PerformanceEntry::PerformanceEntry): (WebCore::PerformanceEntry::name): (WebCore::PerformanceEntry::entryType): (WebCore::PerformanceEntry::startTime): (WebCore::PerformanceEntry::duration): * page/PerformanceEntry.h: Added. (WebCore): (PerformanceEntry): * page/PerformanceEntry.idl: Added. * page/PerformanceEntryList.cpp: Added. (WebCore): (WebCore::PerformanceEntryList::PerformanceEntryList): (WebCore::PerformanceEntryList::~PerformanceEntryList): (WebCore::PerformanceEntryList::length): (WebCore::PerformanceEntryList::item): (WebCore::PerformanceEntryList::append): * page/PerformanceEntryList.h: Added. (WebCore): (PerformanceEntryList): (WebCore::PerformanceEntryList::create): * page/PerformanceEntryList.idl: Added. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.pri trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/Performance.cpp trunk/Source/WebCore/page/Performance.h trunk/Source/WebCore/page/Performance.idl Added Paths trunk/Source/WebCore/page/PerformanceEntry.cpp trunk/Source/WebCore/page/PerformanceEntry.h trunk/Source/WebCore/page/PerformanceEntry.idl trunk/Source/WebCore/page/PerformanceEntryList.cpp trunk/Source/WebCore/page/PerformanceEntryList.h trunk/Source/WebCore/page/PerformanceEntryList.idl Diff Modified: trunk/Source/WebCore/CMakeLists.txt (115273 => 115274) --- trunk/Source/WebCore/CMakeLists.txt 2012-04-26 01:16:38 UTC (rev 115273) +++ trunk/Source/WebCore/CMakeLists.txt 2012-04-26 01:17:36 UTC (rev 115274) @@ -374,6 +374,8 @@ page/MemoryInfo.idl page/Navigator.idl page/Performance.idl +page/PerformanceEntry.idl +page/PerformanceEntryList.idl page/PerformanceNavigation.idl page/PerformanceTiming.idl page/Screen.idl @@ -1056,6 +1058,8 @@ page/PageSerializer.cpp page/PageVisibilityState.cpp page/Performance.cpp +page/PerformanceEntry.cpp +page/PerformanceEntryList.cpp page/PerformanceNavigation.cpp page/PerformanceTiming.cpp page/PrintContext.cpp Modified: trunk/Source/WebCore/ChangeLog (115273 => 115274) --- trunk/Source/WebCore/ChangeLog 2012-04-26 01:16:38 UTC (rev 115273) +++ trunk/Source/WebCore/ChangeLog 2012-04-26 01:17:36 UTC (rev 115274) @@ -1,3 +1,55 @@ +2012-04-25 James Simonsen simon...@chromium.org + +[Web Timing] Add a vendor-prefixed Performance Timeline API +https://bugs.webkit.org/show_bug.cgi?id=80350 + +As described here: http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html + +The API is there and should be correct, but it isn't particularly useful, +because nothing is populated. Upcoming changes will add Navigation Timing +and Resource Timing. + +Reviewed by Tony Gentilcore. + +No new tests. Functionality is disabled on all platforms. + +* CMakeLists.txt: Added PerformanceEntry* files. +* DerivedSources.pri: Ditto. +* GNUmakefile.list.am: Ditto. +* WebCore.gypi: Ditto. +* WebCore.vcproj/WebCore.vcproj: Ditto. +* WebCore.xcodeproj/project.pbxproj: Ditto. +* page/Performance.cpp: +(WebCore::Performance::webkitGetEntries): Added. +(WebCore::Performance::webkitGetEntriesByType): Added. +(WebCore::Performance::webkitGetEntriesByName): Added. +* page/Performance.h: +(Performance): +* page/Performance.idl: +* page/PerformanceEntry.cpp: Added. +(WebCore): +(WebCore::PerformanceEntry::PerformanceEntry): +(WebCore::PerformanceEntry::name): +(WebCore::PerformanceEntry::entryType):
[webkit-changes] [115275] trunk
Title: [115275] trunk
Revision 115275
Author hc...@chromium.org
Date 2012-04-25 18:18:31 -0700 (Wed, 25 Apr 2012)
Log Message
Unreviewed, rolling out r115260.
http://trac.webkit.org/changeset/115260
https://bugs.webkit.org/show_bug.cgi?id=84467
r115260 is crashing a list of IndexDB tests, revert.
Source/WebCore:
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
* platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
* platform/leveldb/LevelDBTransaction.h:
(TransactionIterator):
LayoutTests:
* storage/indexeddb/cursor-added-bug-expected.txt: Removed.
* storage/indexeddb/cursor-added-bug.html: Removed.
* storage/indexeddb/resources/cursor-added-bug.js: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp
trunk/Source/WebCore/platform/leveldb/LevelDBTransaction.h
Removed Paths
trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html
trunk/LayoutTests/storage/indexeddb/resources/cursor-added-bug.js
Diff
Modified: trunk/LayoutTests/ChangeLog (115274 => 115275)
--- trunk/LayoutTests/ChangeLog 2012-04-26 01:17:36 UTC (rev 115274)
+++ trunk/LayoutTests/ChangeLog 2012-04-26 01:18:31 UTC (rev 115275)
@@ -1,3 +1,15 @@
+2012-04-25 Alpha Lam hc...@chromium.org
+
+Unreviewed, rolling out r115260.
+http://trac.webkit.org/changeset/115260
+https://bugs.webkit.org/show_bug.cgi?id=84467
+
+r115260 is crashing a list of IndexDB tests, revert.
+
+* storage/indexeddb/cursor-added-bug-expected.txt: Removed.
+* storage/indexeddb/cursor-added-bug.html: Removed.
+* storage/indexeddb/resources/cursor-added-bug.js: Removed.
+
2012-04-25 Dimitri Glazkov dglaz...@chromium.org
Remove unnecessary timeouts (and closures) from content-element-in-* tests.
Deleted: trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt (115274 => 115275)
--- trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt 2012-04-26 01:17:36 UTC (rev 115274)
+++ trunk/LayoutTests/storage/indexeddb/cursor-added-bug-expected.txt 2012-04-26 01:18:31 UTC (rev 115275)
@@ -1,39 +0,0 @@
-Test IndexedDB cursor iterates correctly over values added during iteration.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
-
-indexedDB.open('cursor-delete')
-db = event.target.result
-db.setVersion('new version')
-trans = event.target.result
-PASS trans !== null is true
-Deleted all object stores.
-objectStore = db.createObjectStore('test')
-objectStore.add(1, 1)
-objectStore.add(2, 2)
-objectStore.add(3, 3)
-trans = db.transaction(['test'], IDBTransaction.READ_WRITE)
-trans.objectStore('test').openCursor()
-PASS event.target.result.key is 1
-trans.objectStore('test').add(6, 6)
-event.target.result.continue()
-PASS event.target.result.key is 2
-trans.objectStore('test').add(5, 5)
-event.target.result.continue()
-PASS event.target.result.key is 3
-trans.objectStore('test').add(4, 4)
-event.target.result.continue()
-PASS event.target.result.key is 4
-event.target.result.continue()
-PASS event.target.result.key is 5
-event.target.result.continue()
-PASS event.target.result.key is 6
-event.target.result.continue()
-PASS counter is 6
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html (115274 => 115275)
--- trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html 2012-04-26 01:17:36 UTC (rev 115274)
+++ trunk/LayoutTests/storage/indexeddb/cursor-added-bug.html 2012-04-26 01:18:31 UTC (rev 115275)
@@ -1,10 +0,0 @@
-html
-head
-script src=""
-script src=""
-/head
-body
-script src=""
-script src=""
-/body
-/html
Deleted: trunk/LayoutTests/storage/indexeddb/resources/cursor-added-bug.js (115274 => 115275)
--- trunk/LayoutTests/storage/indexeddb/resources/cursor-added-bug.js 2012-04-26 01:17:36 UTC (rev 115274)
+++ trunk/LayoutTests/storage/indexeddb/resources/cursor-added-bug.js 2012-04-26 01:18:31 UTC (rev 115275)
@@ -1,74 +0,0 @@
-if (this.importScripts) {
-importScripts('../../../fast/js/resources/js-test-pre.js');
-importScripts('shared.js');
-}
-
-description(Test IndexedDB cursor iterates correctly over values added during iteration.);
-
-test();
-
-function test()
-{
-removeVendorPrefixes();
-request = evalAndLog(indexedDB.open('cursor-delete'));
-request._onsuccess_ = openSuccess;
-request._onerror_ = unexpectedErrorCallback;
-}
-
-function openSuccess()
-{
-var db = evalAndLog(db = event.target.result);
-
-request = evalAndLog(db.setVersion('new
[webkit-changes] [115276] trunk
Title: [115276] trunk
Revision 115276
Author tk...@chromium.org
Date 2012-04-25 18:26:05 -0700 (Wed, 25 Apr 2012)
Log Message
Calendar Picker: Resize to minimal size to fit the content
https://bugs.webkit.org/show_bug.cgi?id=84826
Reviewed by Hajime Morita.
.:
* ManualTests/forms/calendar-picker.html:
Sync with the size specified in CalendarPickerElement.cpp.
Source/WebCore:
Using fixed-size popup isn't nice. The calender picker popup size should
be minimal.
The minimal size depends on font settings, localized labels, and
localized formats. So we put visible objects on a transparent element,
calculate minimal size, resize the popup, then show the objects.
* Resources/calendarPicker.css:
(body): Don't use purple. It was for debugging purpose.
The body is visible for a short period becuse we use transparent element.
(#main):
- Add nowrap to avoid text wrapping.
- Add wider width to avoid wrapping.
- Add opacity to hide incomplete layout.
(.year-month-upper): Don't set flexible box yet.
(.month-selector-box): Fix incorrect display value.
(.days-area):
Don't set table-layout:fixed and width:100% in order that it has the
minimal width.
* Resources/calendarPicker.js:
(initialize): Make a new functio to resize.
(fixWindowSize):
Compute the required width from the right edge of the next year button,
the maximum cell width, and so on. Then, set CSS properties to have
correct layout.
(YearMonthController.prototype.attachTo):
Set min-width property for a long year-month string.
(YearMonthController.prototype._showPopup):
Center the _monthPopup vertically.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):
Specify small size for the initial size. It's better than showing a
large window then shrink the size.
* page/PagePopupClient.h:
(PagePopupClient): Remove a false comment. We should support resize*().
Modified Paths
trunk/ChangeLog
trunk/ManualTests/forms/calendar-picker.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Resources/calendarPicker.css
trunk/Source/WebCore/Resources/calendarPicker.js
trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp
trunk/Source/WebCore/page/PagePopupClient.h
Diff
Modified: trunk/ChangeLog (115275 => 115276)
--- trunk/ChangeLog 2012-04-26 01:18:31 UTC (rev 115275)
+++ trunk/ChangeLog 2012-04-26 01:26:05 UTC (rev 115276)
@@ -1,3 +1,13 @@
+2012-04-24 Kent Tamura tk...@chromium.org
+
+Calendar Picker: Resize to minimal size to fit the content
+https://bugs.webkit.org/show_bug.cgi?id=84826
+
+Reviewed by Hajime Morita.
+
+* ManualTests/forms/calendar-picker.html:
+Sync with the size specified in CalendarPickerElement.cpp.
+
2012-04-25 Allan Sandfeld Jensen allan.jen...@nokia.com
[Qt] Zoom back can overscroll document edges.
Modified: trunk/ManualTests/forms/calendar-picker.html (115275 => 115276)
--- trunk/ManualTests/forms/calendar-picker.html 2012-04-26 01:18:31 UTC (rev 115275)
+++ trunk/ManualTests/forms/calendar-picker.html 2012-04-26 01:26:05 UTC (rev 115276)
@@ -9,8 +9,8 @@
}
iframe {
z-index: 2147483647;
-width: 290px;
-height: 256px;
+width: 100px;
+height: 100px;
border: 0;
overflow: hidden;
}
Modified: trunk/Source/WebCore/ChangeLog (115275 => 115276)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 01:18:31 UTC (rev 115275)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 01:26:05 UTC (rev 115276)
@@ -1,3 +1,54 @@
+2012-04-24 Kent Tamura tk...@chromium.org
+
+Calendar Picker: Resize to minimal size to fit the content
+https://bugs.webkit.org/show_bug.cgi?id=84826
+
+Reviewed by Hajime Morita.
+
+Using fixed-size popup isn't nice. The calender picker popup size should
+be minimal.
+
+The minimal size depends on font settings, localized labels, and
+localized formats. So we put visible objects on a transparent element,
+calculate minimal size, resize the popup, then show the objects.
+
+* Resources/calendarPicker.css:
+(body): Don't use purple. It was for debugging purpose.
+The body is visible for a short period becuse we use transparent element.
+(#main):
+ - Add nowrap to avoid text wrapping.
+ - Add wider width to avoid wrapping.
+ - Add opacity to hide incomplete layout.
+(.year-month-upper): Don't set flexible box yet.
+(.month-selector-box): Fix incorrect display value.
+(.days-area):
+Don't set table-layout:fixed and width:100% in order that it has the
+minimal width.
+
+* Resources/calendarPicker.js:
+(initialize): Make a new functio to resize.
+(fixWindowSize):
+Compute the required width from the right edge of the next year button,
+the maximum cell width, and so on. Then, set CSS properties to have
+correct layout.
+(YearMonthController.prototype.attachTo):
+Set min-width
[webkit-changes] [115277] branches/chromium/1084/Source/WebCore/css
Title: [115277] branches/chromium/1084/Source/WebCore/css
Revision 115277
Author mikelawt...@chromium.org
Date 2012-04-25 18:26:09 -0700 (Wed, 25 Apr 2012)
Log Message
Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
NOTE: CSSParser.cpp:3663 modified as this patch depends on another one that
was not merged to this branch.
Patch by David Barr davidb...@chromium.org on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
TBR=commit-qu...@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10225019
Modified Paths
branches/chromium/1084/Source/WebCore/css/CSSParser.cpp
branches/chromium/1084/Source/WebCore/css/StylePropertySet.cpp
Diff
Modified: branches/chromium/1084/Source/WebCore/css/CSSParser.cpp (115276 => 115277)
--- branches/chromium/1084/Source/WebCore/css/CSSParser.cpp 2012-04-26 01:26:05 UTC (rev 115276)
+++ branches/chromium/1084/Source/WebCore/css/CSSParser.cpp 2012-04-26 01:26:09 UTC (rev 115277)
@@ -3660,6 +3660,7 @@
}
return false;
}
+value3 = cssValuePool()-createImplicitInitialValue();
return true;
}
Modified: branches/chromium/1084/Source/WebCore/css/StylePropertySet.cpp (115276 => 115277)
--- branches/chromium/1084/Source/WebCore/css/StylePropertySet.cpp 2012-04-26 01:26:05 UTC (rev 115276)
+++ branches/chromium/1084/Source/WebCore/css/StylePropertySet.cpp 2012-04-26 01:26:09 UTC (rev 115277)
@@ -382,12 +382,13 @@
for (unsigned i = 0; i longhand.length(); ++i) {
if (!isPropertyImplicit(longhand.properties()[i])) {
RefPtrCSSValue value = getPropertyCSSValue(longhand.properties()[i]);
-// FIXME: provide default value if !value or value is initial value
-if (value !value-isInitialValue()) {
-if (!res.isNull())
-res += ;
-res += value-cssText();
-}
+if (value value-isInitialValue())
+continue;
+if (!value)
+return String();
+if (!res.isNull())
+res += ;
+res += value-cssText();
}
}
return res;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115278] trunk/Source
Title: [115278] trunk/Source Revision 115278 Author e...@google.com Date 2012-04-25 18:48:08 -0700 (Wed, 25 Apr 2012) Log Message [chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches https://bugs.webkit.org/show_bug.cgi?id=84812 Reviewed by James Robinson. Source/WebCore: Because some layers lock/unlock resources, it needs to be guaranteed that if willDraw is called on a layer then didDraw will also be called on that layer before another willDraw or before layer destruction. Add asserts to make sure that this is the case. willDraw is called via CCLayerTreeHostImpl::prepareToDraw - calculateRenderPasses. didDraw was previously called in CCLayerTreeHostImpl::drawLayers. Sometimes drawLayers was being skipped by the caller of these functions based on what prepareToDraw returned (causing didDraw to not be called). Fix this by having an explicit step to call didDraw on all layers. This new didDrawAllLayers function must be called if and only if prepareToDraw is called. Tested by existing tests via new asserts in CCLayerImpl. * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::~CCLayerImpl): (WebCore::CCLayerImpl::willDraw): (WebCore): (WebCore::CCLayerImpl::didDraw): * platform/graphics/chromium/cc/CCLayerImpl.h: (CCLayerImpl): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::didDrawAllLayers): (WebCore): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: (CCLayerTreeHostImpl): * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: (WebCore::CCScrollbarLayerImpl::willDraw): (WebCore::CCScrollbarLayerImpl::didDraw): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::doComposite): * platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: (WebCore::CCTextureLayerImpl::willDraw): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal): * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::willDraw): (WebCore::CCVideoLayerImpl::didDraw): Source/WebKit/chromium: Update all tests to call CCLayerTreeHostImpl::didDrawAllLayers if they call CCLayerTreeHostImpl::prepareToDraw. * tests/CCLayerTreeHostImplTest.cpp: (WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame): (WebKitTests::TEST_F): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCTextureLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (115277 => 115278) --- trunk/Source/WebCore/ChangeLog 2012-04-26 01:26:09 UTC (rev 115277) +++ trunk/Source/WebCore/ChangeLog 2012-04-26 01:48:08 UTC (rev 115278) @@ -1,3 +1,52 @@ +2012-04-25 Adrienne Walker e...@google.com + +[chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches +https://bugs.webkit.org/show_bug.cgi?id=84812 + +Reviewed by James Robinson. + +Because some layers lock/unlock resources, it needs to be guaranteed +that if willDraw is called on a layer then didDraw will also be called +on that layer before another willDraw or before layer destruction. Add +asserts to make sure that this is the case. + +willDraw is called via CCLayerTreeHostImpl::prepareToDraw - +calculateRenderPasses. didDraw was previously called in +CCLayerTreeHostImpl::drawLayers. Sometimes drawLayers was being +skipped by the caller of these functions based on what prepareToDraw +returned (causing didDraw to not be called). Fix this by having an +explicit step to call didDraw on all layers. This new didDrawAllLayers +function must be called if and only if prepareToDraw is called. + +Tested by existing tests via new asserts in CCLayerImpl. + +* platform/graphics/chromium/cc/CCLayerImpl.cpp: +(WebCore::CCLayerImpl::CCLayerImpl): +(WebCore::CCLayerImpl::~CCLayerImpl): +(WebCore::CCLayerImpl::willDraw): +(WebCore): +(WebCore::CCLayerImpl::didDraw): +* platform/graphics/chromium/cc/CCLayerImpl.h: +(CCLayerImpl): +* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: +(WebCore::CCLayerTreeHostImpl::drawLayers):
[webkit-changes] [115279] trunk/Source/WebKit/chromium
Title: [115279] trunk/Source/WebKit/chromium
Revision 115279
Author hc...@chromium.org
Date 2012-04-25 18:56:00 -0700 (Wed, 25 Apr 2012)
Log Message
Unreviewed, rolling out r115262.
http://trac.webkit.org/changeset/115262
https://bugs.webkit.org/show_bug.cgi?id=84631
r115262 is causing link error in WebKit Win Builder (dbg)
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
* public/WebIDBKeyPath.h:
(WebKit):
(WebIDBKeyPath):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
(WebKit::WebIDBObjectStore::createIndex):
* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
* src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::keyPath):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::keyPath):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBIndexImpl.cpp:
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
* src/WebIDBKeyPath.cpp:
(WebKit::WebIDBKeyPath::create):
(WebKit::WebIDBKeyPath::assign):
(WebKit::WebIDBKeyPath::operator const WTF::VectorWTF::String, 0):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
(WebKit::WebIDBObjectStoreImpl::createIndex):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBDatabase.h
trunk/Source/WebKit/chromium/public/WebIDBIndex.h
trunk/Source/WebKit/chromium/public/WebIDBKeyPath.h
trunk/Source/WebKit/chromium/public/WebIDBObjectStore.h
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/IDBIndexBackendProxy.cpp
trunk/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp
trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h
trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.h
trunk/Source/WebKit/chromium/src/WebIDBKeyPath.cpp
trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (115278 => 115279)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-26 01:48:08 UTC (rev 115278)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-26 01:56:00 UTC (rev 115279)
@@ -1,3 +1,44 @@
+2012-04-25 Alpha Lam hc...@chromium.org
+
+Unreviewed, rolling out r115262.
+http://trac.webkit.org/changeset/115262
+https://bugs.webkit.org/show_bug.cgi?id=84631
+
+r115262 is causing link error in WebKit Win Builder (dbg)
+
+* public/WebIDBDatabase.h:
+(WebKit::WebIDBDatabase::createObjectStore):
+* public/WebIDBIndex.h:
+(WebKit::WebIDBIndex::keyPath):
+(WebKit::WebIDBIndex::keyPathString):
+* public/WebIDBKeyPath.h:
+(WebKit):
+(WebIDBKeyPath):
+* public/WebIDBObjectStore.h:
+(WebKit::WebIDBObjectStore::keyPath):
+(WebKit::WebIDBObjectStore::keyPathString):
+(WebKit::WebIDBObjectStore::createIndex):
+* public/platform/WebKitPlatformSupport.h:
+(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
+(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
+* src/IDBIndexBackendProxy.cpp:
+(WebKit::IDBIndexBackendProxy::keyPath):
+* src/IDBObjectStoreBackendProxy.cpp:
+(WebKit::IDBObjectStoreBackendProxy::keyPath):
+* src/WebIDBDatabaseImpl.h:
+(WebIDBDatabaseImpl):
+* src/WebIDBIndexImpl.cpp:
+* src/WebIDBIndexImpl.h:
+(WebIDBIndexImpl):
+* src/WebIDBKeyPath.cpp:
+(WebKit::WebIDBKeyPath::create):
+(WebKit::WebIDBKeyPath::assign):
+(WebKit::WebIDBKeyPath::operator const WTF::VectorWTF::String, 0):
+* src/WebIDBObjectStoreImpl.cpp:
+* src/WebIDBObjectStoreImpl.h:
+(WebIDBObjectStoreImpl):
+(WebKit::WebIDBObjectStoreImpl::createIndex):
+
2012-04-24 Adrienne Walker e...@google.com
[chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
Modified: trunk/Source/WebKit/chromium/public/WebIDBDatabase.h (115278 => 115279)
--- trunk/Source/WebKit/chromium/public/WebIDBDatabase.h 2012-04-26 01:48:08 UTC (rev 115278)
+++ trunk/Source/WebKit/chromium/public/WebIDBDatabase.h 2012-04-26 01:56:00 UTC (rev 115279)
@@ -28,7 +28,6 @@
#include WebDOMStringList.h
#include WebExceptionCode.h
-#include WebIDBKeyPath.h
#include platform/WebCommon.h
namespace WebKit {
@@ -59,14 +58,8 @@
WEBKIT_ASSERT_NOT_REACHED();
return WebDOMStringList();
}
-// FIXME: Remove WebString keyPath overload once callers are updated.
-// http://webkit.org/b/84207
-virtual WebIDBObjectStore*
[webkit-changes] [115281] trunk/Source/WebCore
Title: [115281] trunk/Source/WebCore
Revision 115281
Author e...@google.com
Date 2012-04-25 19:06:41 -0700 (Wed, 25 Apr 2012)
Log Message
[chromium] Hold video provider lock from willDraw to didDraw
https://bugs.webkit.org/show_bug.cgi?id=84805
Reviewed by James Robinson.
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115280 => 115281)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 02:02:41 UTC (rev 115280)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 02:06:41 UTC (rev 115281)
@@ -1,3 +1,18 @@
+2012-04-24 Adrienne Walker e...@google.com
+
+[chromium] Hold video provider lock from willDraw to didDraw
+https://bugs.webkit.org/show_bug.cgi?id=84805
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
+(WebCore::CCVideoLayerImpl::willDraw):
+(WebCore):
+(WebCore::CCVideoLayerImpl::willDrawInternal):
+(WebCore::CCVideoLayerImpl::appendQuads):
+(WebCore::CCVideoLayerImpl::didDraw):
+* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
+
2012-04-25 Adrienne Walker e...@google.com
[chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp (115280 => 115281)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp 2012-04-26 02:02:41 UTC (rev 115280)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp 2012-04-26 02:06:41 UTC (rev 115281)
@@ -123,8 +123,25 @@
ASSERT(CCProxy::isImplThread());
CCLayerImpl::willDraw(layerRenderer);
-MutexLocker locker(m_providerMutex);
+// Explicitly lock and unlock the provider mutex so it can be held from
+// willDraw to didDraw. Since the compositor thread is in the middle of
+// drawing, the layer will not be destroyed before didDraw is called.
+// Therefore, the only thing that will prevent this lock from being released
+// is the GPU process locking it. As the GPU process can't cause the
+// destruction of the provider (calling stopUsingProvider), holding this
+// lock should not cause a deadlock.
+m_providerMutex.lock();
+willDrawInternal(layerRenderer);
+
+if (!m_frame)
+m_providerMutex.unlock();
+}
+
+void CCVideoLayerImpl::willDrawInternal(LayerRendererChromium* layerRenderer)
+{
+ASSERT(CCProxy::isImplThread());
+
if (!m_provider) {
m_frame = 0;
return;
@@ -151,6 +168,8 @@
void CCVideoLayerImpl::appendQuads(CCQuadCuller quadList, const CCSharedQuadState* sharedQuadState, bool)
{
+ASSERT(CCProxy::isImplThread());
+
if (!m_frame)
return;
@@ -168,15 +187,15 @@
ASSERT(CCProxy::isImplThread());
CCLayerImpl::didDraw();
-MutexLocker locker(m_providerMutex);
-
-if (!m_provider || !m_frame)
+if (!m_frame)
return;
for (unsigned plane = 0; plane m_frame-planes(); ++plane)
m_textures[plane].m_texture-unreserve();
m_provider-putCurrentFrame(m_frame);
m_frame = 0;
+
+m_providerMutex.unlock();
}
static int videoFrameDimension(int originalDimension, unsigned plane, int format)
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.h (115280 => 115281)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.h 2012-04-26 02:02:41 UTC (rev 115280)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.h 2012-04-26 02:06:41 UTC (rev 115281)
@@ -90,9 +90,11 @@
static IntSize computeVisibleSize(const WebKit::WebVideoFrame, unsigned plane);
virtual const char* layerTypeAsString() const OVERRIDE { return VideoLayer; }
+void willDrawInternal(LayerRendererChromium*);
bool reserveTextures(const WebKit::WebVideoFrame, GC3Denum format, LayerRendererChromium*);
-Mutex m_providerMutex; // Guards m_provider below.
+// Guards the destruction of m_provider and the frame that it provides
+Mutex m_providerMutex;
WebKit::WebVideoFrameProvider* m_provider;
Texture m_textures[MaxPlanes];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115284] trunk/Source/WebCore
Title: [115284] trunk/Source/WebCore
Revision 115284
Author commit-qu...@webkit.org
Date 2012-04-25 21:03:27 -0700 (Wed, 25 Apr 2012)
Log Message
[BlackBerry] Authenticated proxy isn't working.
https://bugs.webkit.org/show_bug.cgi?id=84579
Patch by Jason Liu jason@torchmobile.com.cn on 2012-04-25
Reviewed by Antonio Gomes.
We should try to get username and password from WiFi advanced configuration first
when 407 is received.
No new tests. This is covered by existing http tests when proxy's username and password
are configured for WiFi.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115283 => 115284)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 02:26:05 UTC (rev 115283)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 04:03:27 UTC (rev 115284)
@@ -1,3 +1,19 @@
+2012-04-25 Jason Liu jason@torchmobile.com.cn
+
+[BlackBerry] Authenticated proxy isn't working.
+https://bugs.webkit.org/show_bug.cgi?id=84579
+
+Reviewed by Antonio Gomes.
+
+We should try to get username and password from WiFi advanced configuration first
+when 407 is received.
+
+No new tests. This is covered by existing http tests when proxy's username and password
+are configured for WiFi.
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::sendRequestWithCredentials):
+
2012-04-25 Alec Flett alecfl...@chromium.org
IndexedDB: implement cursor.advance()
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (115283 => 115284)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-04-26 02:26:05 UTC (rev 115283)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-04-26 04:03:27 UTC (rev 115284)
@@ -855,19 +855,26 @@
if (!m_frame || !m_frame-loader() || !m_frame-loader()-client())
return false;
-// Before asking the user for credentials, we check if the URL contains that.
-if (!m_handle-getInternal()-m_user.isEmpty() !m_handle-getInternal()-m_pass.isEmpty()) {
-username = m_handle-getInternal()-m_user.utf8().data();
-password = m_handle-getInternal()-m_pass.utf8().data();
+if (type == ProtectionSpaceProxyHTTP) {
+username = BlackBerry::Platform::Client::get()-getProxyUsername().c_str();
+password = BlackBerry::Platform::Client::get()-getProxyPassword().c_str();
+}
-// Prevent them from been used again if they are wrong.
-// If they are correct, they will the put into CredentialStorage.
-m_handle-getInternal()-m_user = ;
-m_handle-getInternal()-m_pass = ;
-} else {
-Credential inputCredential = m_frame-page()-chrome()-client()-platformPageClient()-authenticationChallenge(newURL, protectionSpace);
-username = inputCredential.user();
-password = inputCredential.password();
+if (username.isEmpty() || password.isEmpty()) {
+// Before asking the user for credentials, we check if the URL contains that.
+if (!m_handle-getInternal()-m_user.isEmpty() !m_handle-getInternal()-m_pass.isEmpty()) {
+username = m_handle-getInternal()-m_user.utf8().data();
+password = m_handle-getInternal()-m_pass.utf8().data();
+
+// Prevent them from been used again if they are wrong.
+// If they are correct, they will the put into CredentialStorage.
+m_handle-getInternal()-m_user = ;
+m_handle-getInternal()-m_pass = ;
+} else {
+Credential inputCredential = m_frame-page()-chrome()-client()-platformPageClient()-authenticationChallenge(newURL, protectionSpace);
+username = inputCredential.user();
+password = inputCredential.password();
+}
}
if (username.isEmpty() password.isEmpty())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115283] trunk/LayoutTests
Title: [115283] trunk/LayoutTests Revision 115283 Author commit-qu...@webkit.org Date 2012-04-25 19:26:05 -0700 (Wed, 25 Apr 2012) Log Message Rebaseline *.png pixel test files after bug 84649 fix https://bugs.webkit.org/show_bug.cgi?id=84905 Patch by David Barton dbar...@mathscribe.com on 2012-04-25 Reviewed by Beth Dakin. * platform/mac/mathml/presentation/fenced-expected.png: * platform/mac/mathml/presentation/fenced-mi-expected.png: * platform/mac/mathml/presentation/mo-expected.png: * platform/mac/mathml/presentation/mo-stretch-expected.png: * platform/mac/mathml/presentation/over-expected.png: * platform/mac/mathml/presentation/row-alignment-expected.png: * platform/mac/mathml/presentation/row-expected.png: * platform/mac/mathml/presentation/sub-expected.png: * platform/mac/mathml/presentation/subsup-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/mathml/presentation/fenced-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/fenced-mi-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/mo-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/mo-stretch-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/over-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/sub-expected.png trunk/LayoutTests/platform/mac/mathml/presentation/subsup-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (115282 => 115283) --- trunk/LayoutTests/ChangeLog 2012-04-26 02:23:34 UTC (rev 115282) +++ trunk/LayoutTests/ChangeLog 2012-04-26 02:26:05 UTC (rev 115283) @@ -1,3 +1,20 @@ +2012-04-25 David Barton dbar...@mathscribe.com + +Rebaseline *.png pixel test files after bug 84649 fix +https://bugs.webkit.org/show_bug.cgi?id=84905 + +Reviewed by Beth Dakin. + +* platform/mac/mathml/presentation/fenced-expected.png: +* platform/mac/mathml/presentation/fenced-mi-expected.png: +* platform/mac/mathml/presentation/mo-expected.png: +* platform/mac/mathml/presentation/mo-stretch-expected.png: +* platform/mac/mathml/presentation/over-expected.png: +* platform/mac/mathml/presentation/row-alignment-expected.png: +* platform/mac/mathml/presentation/row-expected.png: +* platform/mac/mathml/presentation/sub-expected.png: +* platform/mac/mathml/presentation/subsup-expected.png: + 2012-04-25 Alec Flett alecfl...@chromium.org IndexedDB: implement cursor.advance() Modified: trunk/LayoutTests/platform/mac/mathml/presentation/fenced-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/fenced-mi-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/mo-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/mo-stretch-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/over-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/sub-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/mathml/presentation/subsup-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115285] trunk/Source
Title: [115285] trunk/Source
Revision 115285
Author commit-qu...@webkit.org
Date 2012-04-25 21:50:28 -0700 (Wed, 25 Apr 2012)
Log Message
[chromium] REGRESSION(112286) Compositor initialization blocks for program compilation / linking
https://bugs.webkit.org/show_bug.cgi?id=84822
Patch by James Robinson jam...@chromium.org on 2012-04-25
Reviewed by Adrienne Walker.
Source/WebCore:
r112286 introduced a subtle regression in the chromium compositor startup sequence - by querying the texture
copy program's uniform location at the end of LayerRendererChromium::initialize(), the compositor's thread was
blocked until the service side compiled _all_ eagerly initialized shaders. The intent of the way the compositor
programs are created is that a set of commonly-used programs are sent to the service side, but no blocking calls
are made until after we go through the first paint (with the hope that the service side will complete the
compilation by then).
Fixed by moving program initialization (which also grabs uniform locations) until the first actual use of the
copier. It may be worth deferring the program initialization completely if it's not used very often.
Added unit test in LayerRendererChromiumTests to make sure LRC initialization does not make any
synchronous calls (like getUniformLocation()).
* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
Source/WebKit/chromium:
Add a test that makes sure we don't make blocking calls during LayerRendererChromium initialization.
* tests/LayerRendererChromiumTest.cpp:
(ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::finish):
(ForbidSynchronousCallContext::getActiveAttrib):
(ForbidSynchronousCallContext::getActiveUniform):
(ForbidSynchronousCallContext::getAttachedShaders):
(ForbidSynchronousCallContext::getAttribLocation):
(ForbidSynchronousCallContext::getBooleanv):
(ForbidSynchronousCallContext::getBufferParameteriv):
(ForbidSynchronousCallContext::getContextAttributes):
(ForbidSynchronousCallContext::getError):
(ForbidSynchronousCallContext::getFloatv):
(ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
(TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/ProgramBinding.h
trunk/Source/WebCore/platform/graphics/chromium/TextureCopier.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (115284 => 115285)
--- trunk/Source/WebCore/ChangeLog 2012-04-26 04:03:27 UTC (rev 115284)
+++ trunk/Source/WebCore/ChangeLog 2012-04-26 04:50:28 UTC (rev 115285)
@@ -1,3 +1,27 @@
+2012-04-25 James Robinson jam...@chromium.org
+
+[chromium] REGRESSION(112286) Compositor initialization blocks for program compilation / linking
+https://bugs.webkit.org/show_bug.cgi?id=84822
+
+Reviewed by Adrienne Walker.
+
+r112286 introduced a subtle regression in the chromium compositor startup sequence - by querying the texture
+copy program's uniform location at the end of LayerRendererChromium::initialize(), the compositor's thread was
+blocked until the service side compiled _all_ eagerly initialized shaders. The intent of the way the compositor
+programs are created is that a set of commonly-used programs are sent to the service side, but no blocking calls
+are made until after we go through the first paint (with the hope that the service side will complete the
+compilation by then).
+
+Fixed by moving program initialization (which also grabs uniform locations) until the first actual use of the
+copier. It may be worth deferring the program initialization completely if it's not used very often.
+
+Added unit test in LayerRendererChromiumTests to make sure LRC initialization does not make any
+synchronous calls (like getUniformLocation()).
+
+* platform/graphics/chromium/TextureCopier.cpp:
+(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
+(WebCore::AcceleratedTextureCopier::copyTexture):
+
2012-04-25 Jason Liu jason@torchmobile.com.cn
[BlackBerry] Authenticated proxy isn't working.
Modified: trunk/Source/WebCore/platform/graphics/chromium/ProgramBinding.h (115284 => 115285)
--- trunk/Source/WebCore/platform/graphics/chromium/ProgramBinding.h 2012-04-26 04:03:27 UTC (rev 115284)
+++ trunk/Source/WebCore/platform/graphics/chromium/ProgramBinding.h 2012-04-26 04:50:28 UTC (rev 115285)
@@ -43,7 +43,7 @@
void init(GraphicsContext3D*, const String vertexShader, const String fragmentShader);
void cleanup(GraphicsContext3D*);
-unsigned program() const { return m_program; }
+unsigned program() const { ASSERT(m_initialized); return m_program; }
bool
[webkit-changes] [115286] trunk/Tools
Title: [115286] trunk/Tools
Revision 115286
Author o...@webkit.org
Date 2012-04-25 21:57:07 -0700 (Wed, 25 Apr 2012)
Log Message
Unreviewed, rolling out r115240.
http://trac.webkit.org/changeset/115240
https://bugs.webkit.org/show_bug.cgi?id=84928
It broke everything (Requested by Ossy_HOME on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-04-25
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver):
(GtkDriver._start):
(GtkDriver._start.x_filter):
(GtkDriver.stop):
(GtkPort._driver_class):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py
Removed Paths
trunk/Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver.py
Diff
Modified: trunk/Tools/ChangeLog (115285 => 115286)
--- trunk/Tools/ChangeLog 2012-04-26 04:50:28 UTC (rev 115285)
+++ trunk/Tools/ChangeLog 2012-04-26 04:57:07 UTC (rev 115286)
@@ -1,3 +1,21 @@
+2012-04-25 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r115240.
+http://trac.webkit.org/changeset/115240
+https://bugs.webkit.org/show_bug.cgi?id=84928
+
+It broke everything (Requested by Ossy_HOME on #webkit).
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+(GtkDriver):
+(GtkDriver._start):
+(GtkDriver._start.x_filter):
+(GtkDriver.stop):
+(GtkPort._driver_class):
+* Scripts/webkitpy/layout_tests/port/qt.py:
+(QtPort._build_driver):
+* Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
+
2012-04-25 Dirk Pranke dpra...@chromium.org
[chromium] change DRT's DRT output to match the other ports
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (115285 => 115286)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-04-26 04:50:28 UTC (rev 115285)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-04-26 04:57:07 UTC (rev 115286)
@@ -32,12 +32,49 @@
import subprocess
from webkitpy.layout_tests.models.test_configuration import TestConfiguration
-from webkitpy.layout_tests.port.webkit import WebKitPort
-from webkitpy.layout_tests.port.xvfbdriver import XvfbDriver
+from webkitpy.layout_tests.port.server_process import ServerProcess
+from webkitpy.layout_tests.port.webkit import WebKitDriver, WebKitPort
+from webkitpy.common.system.executive import Executive
_log = logging.getLogger(__name__)
+class GtkDriver(WebKitDriver):
+def _start(self, pixel_tests, per_test_args):
+
+# Collect the number of X servers running already and make
+# sure our Xvfb process doesn't clash with any of them.
+def x_filter(process_name):
+return process_name.find(Xorg) -1
+
+running_displays = len(Executive().running_pids(x_filter))
+
+# Use even displays for pixel tests and odd ones otherwise. When pixel tests are disabled,
+# DriverProxy creates two drivers, one for normal and the other for ref tests. Both have
+# the same worker number, so this prevents them from using the same Xvfb instance.
+display_id = self._worker_number * 2 + running_displays
+if self._port.get_option('pixel_tests'):
+display_id += 1
+run_xvfb = [Xvfb, :%d % (display_id), -screen, 0, 800x600x24, -nolisten, tcp]
+with open(os.devnull, 'w') as devnull:
+self._xvfb_process = subprocess.Popen(run_xvfb, stderr=devnull)
+server_name = self._port.driver_name()
+environment = self._port.setup_environ_for_server(server_name)
+# We must do this here because the DISPLAY number depends on _worker_number
+environment['DISPLAY'] = :%d % (display_id)
+self._crashed_process_name = None
+self._crashed_pid = None
+self._server_process = ServerProcess(self._port, server_name, self.cmd_line(pixel_tests, per_test_args), environment)
+
+def stop(self):
+WebKitDriver.stop(self)
+if getattr(self, '_xvfb_process', None):
+# FIXME: This should use Executive.kill_process
+os.kill(self._xvfb_process.pid, signal.SIGTERM)
+self._xvfb_process.wait()
+self._xvfb_process = None
+
+
class GtkPort(WebKitPort):
port_name = gtk
@@ -45,7 +82,7 @@
return --gtk
def _driver_class(self):
-return XvfbDriver
+return GtkDriver
def _unload_pulseaudio_module(self):
# Unload pulseaudio's module-stream-restore, since it remembers
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (115285 => 115286)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-04-26 04:50:28 UTC (rev 115285)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-04-26 04:57:07 UTC (rev 115286)
@@ -38,8 +38,8 @@
from
[webkit-changes] [115287] trunk/LayoutTests
Title: [115287] trunk/LayoutTests
Revision 115287
Author mhahnenb...@apple.com
Date 2012-04-25 22:07:31 -0700 (Wed, 25 Apr 2012)
Log Message
fast/js/random-array-gc-stress times out in debug mode
https://bugs.webkit.org/show_bug.cgi?id=84821
Reviewed by Geoffrey Garen.
* fast/js/script-tests/random-array-gc-stress.js: Trying a lower number of iterations
to make the slow bots happy.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js
Diff
Modified: trunk/LayoutTests/ChangeLog (115286 => 115287)
--- trunk/LayoutTests/ChangeLog 2012-04-26 04:57:07 UTC (rev 115286)
+++ trunk/LayoutTests/ChangeLog 2012-04-26 05:07:31 UTC (rev 115287)
@@ -1,3 +1,13 @@
+2012-04-25 Mark Hahnenberg mhahnenb...@apple.com
+
+fast/js/random-array-gc-stress times out in debug mode
+https://bugs.webkit.org/show_bug.cgi?id=84821
+
+Reviewed by Geoffrey Garen.
+
+* fast/js/script-tests/random-array-gc-stress.js: Trying a lower number of iterations
+to make the slow bots happy.
+
2012-04-25 David Barton dbar...@mathscribe.com
Rebaseline *.png pixel test files after bug 84649 fix
Modified: trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js (115286 => 115287)
--- trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js 2012-04-26 04:57:07 UTC (rev 115286)
+++ trunk/LayoutTests/fast/js/script-tests/random-array-gc-stress.js 2012-04-26 05:07:31 UTC (rev 115287)
@@ -38,7 +38,7 @@
};
var runs = 0;
-while (runs 30) {
+while (runs 20) {
test();
runs += 1;
global = [];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115288] trunk/Source
Title: [115288] trunk/Source Revision 115288 Author mhahnenb...@apple.com Date 2012-04-25 22:08:06 -0700 (Wed, 25 Apr 2012) Log Message WebCore shouldn't call collectAllGarbage directly https://bugs.webkit.org/show_bug.cgi?id=84897 Reviewed by Geoffrey Garen. Source/_javascript_Core: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Exported symbol for reportAbanondedObjectGraph so WebCore can use it. * heap/Heap.h: Ditto. Source/WebCore: No new tests. Currently, GCController calls Heap::collectAllGarbage directly, which leads to an overload of collections as the timer in GCController and the timer in GCActivityCallback compete for collection time and fire independently. As a result, we end up doing almost 600 full collections during an in-browser run of SunSpider, or 20 full collections on a single load of TechCrunch. We can do better by preventing WebCore from calling collectAllGarbage directly and instead going through Heap::reportAbandonedObjectGraph, since that is what WebCore is trying to do--notify the Heap that a lot of garbage may have just been generated when we left a page. * WebCore.exp.in: * bindings/js/GCController.cpp: Removed all timer stuff. (WebCore::GCController::GCController): (WebCore::GCController::garbageCollectSoon): Changed to call Heap::reportAbandonedObjectGraph. (WebCore::GCController::garbageCollectNow): Changed to still directly call collectAllGarbage. We will deprecate this function soon hopefully. * bindings/js/GCController.h: Removed timer stuff. (GCController): * bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::collectGarbage): Changed to call garbageCollectSoon. Source/WebKit2: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::didClose): Changed to call garbageCollectSoon. This is the function that causes us to do so much collection on page navigation. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/heap/Heap.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/bindings/js/GCController.cpp trunk/Source/WebCore/bindings/js/GCController.h trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebProcess.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (115287 => 115288) --- trunk/Source/_javascript_Core/ChangeLog 2012-04-26 05:07:31 UTC (rev 115287) +++ trunk/Source/_javascript_Core/ChangeLog 2012-04-26 05:08:06 UTC (rev 115288) @@ -1,3 +1,14 @@ +2012-04-25 Mark Hahnenberg mhahnenb...@apple.com + +WebCore shouldn't call collectAllGarbage directly +https://bugs.webkit.org/show_bug.cgi?id=84897 + +Reviewed by Geoffrey Garen. + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Exported symbol +for reportAbanondedObjectGraph so WebCore can use it. +* heap/Heap.h: Ditto. + 2012-04-25 Oliver Hunt oli...@apple.com Biolab disaster crashes on ToT Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (115287 => 115288) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2012-04-26 05:07:31 UTC (rev 115287) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2012-04-26 05:08:06 UTC (rev 115288) @@ -280,6 +280,7 @@ ?releaseDecommitted@OSAllocator@WTF@@SAXPAXI@Z ?releaseExecutableMemory@JSGlobalData@JSC@@QAEXXZ ?removeBlock@MarkedAllocator@JSC@@QAEXPAVMarkedBlock@2@@Z +?reportAbandonedObjectGraph@Heap@JSC@@QAEXXZ ?reportExtraMemoryCostSlowCase@Heap@JSC@@AAEXI@Z ?reserveAndCommit@OSAllocator@WTF@@SAPAXIW4Usage@12@_N11@Z ?reserveCapacity@StringBuilder@WTF@@QAEXI@Z Modified: trunk/Source/_javascript_Core/heap/Heap.h (115287 => 115288) --- trunk/Source/_javascript_Core/heap/Heap.h 2012-04-26 05:07:31 UTC (rev 115287) +++ trunk/Source/_javascript_Core/heap/Heap.h 2012-04-26 05:08:06 UTC (rev 115288) @@ -119,7 +119,7 @@ void collect(SweepToggle); void reportExtraMemoryCost(size_t cost); -void reportAbandonedObjectGraph(); +JS_EXPORT_PRIVATE void reportAbandonedObjectGraph(); JS_EXPORT_PRIVATE void protect(JSValue); JS_EXPORT_PRIVATE bool unprotect(JSValue); // True when the protect count drops to 0. Modified: trunk/Source/WebCore/ChangeLog (115287 => 115288) --- trunk/Source/WebCore/ChangeLog 2012-04-26 05:07:31 UTC (rev 115287) +++ trunk/Source/WebCore/ChangeLog 2012-04-26 05:08:06 UTC (rev 115288) @@ -1,3 +1,34 @@ +2012-04-25 Mark Hahnenberg mhahnenb...@apple.com + +WebCore shouldn't call collectAllGarbage directly +https://bugs.webkit.org/show_bug.cgi?id=84897 + +Reviewed by Geoffrey Garen. + +No new tests. + +Currently, GCController calls
