[webkit-changes] [125651] trunk/Tools
Title: [125651] trunk/Tools
Revision 125651
Author rn...@webkit.org
Date 2012-08-14 23:28:00 -0700 (Tue, 14 Aug 2012)
Log Message
Build fix after r125516. Revert the erroneous rename since we need to keep exposing
layoutTestController in Chromium port as explained r124785.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
Diff
Modified: trunk/Tools/ChangeLog (125650 => 125651)
--- trunk/Tools/ChangeLog 2012-08-15 06:25:36 UTC (rev 125650)
+++ trunk/Tools/ChangeLog 2012-08-15 06:28:00 UTC (rev 125651)
@@ -1,3 +1,11 @@
+2012-08-14 Ryosuke Niwa
+
+Build fix after r125516. Revert the erroneous rename since we need to keep exposing
+layoutTestController in Chromium port as explained r124785.
+
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::bindJSObjectsToWindow):
+
2012-08-14 Dan Bernstein
fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (125650 => 125651)
--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2012-08-15 06:25:36 UTC (rev 125650)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2012-08-15 06:28:00 UTC (rev 125651)
@@ -726,7 +726,7 @@
WebTestingSupport::injectInternalsObject(frame);
m_testInterfaces->bindTo(frame);
m_testRunner->bindToJavascript(frame, WebString::fromUTF8("testRunner"));
-m_testRunner->bindToJavascript(frame, WebString::fromUTF8("testRunner"));
+m_testRunner->bindToJavascript(frame, WebString::fromUTF8("layoutTestController"));
}
WebViewHost* TestShell::createNewWindow(const WebKit::WebURL& url)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125650] trunk/Source/WebCore
Title: [125650] trunk/Source/WebCore
Revision 125650
Author commit-qu...@webkit.org
Date 2012-08-14 23:25:36 -0700 (Tue, 14 Aug 2012)
Log Message
Web Inspector: CodeMirrorTextEditor doesn't clear execution line
https://bugs.webkit.org/show_bug.cgi?id=94069
Patch by Jan Keromnes on 2012-08-14
Reviewed by Pavel Feldman.
Make CodeMirrorTextEditor use line handles instead of numbers, remove
typeof == "number" checks.
* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (125649 => 125650)
--- trunk/Source/WebCore/ChangeLog 2012-08-15 05:53:18 UTC (rev 125649)
+++ trunk/Source/WebCore/ChangeLog 2012-08-15 06:25:36 UTC (rev 125650)
@@ -1,3 +1,18 @@
+2012-08-14 Jan Keromnes
+
+Web Inspector: CodeMirrorTextEditor doesn't clear execution line
+https://bugs.webkit.org/show_bug.cgi?id=94069
+
+Reviewed by Pavel Feldman.
+
+Make CodeMirrorTextEditor use line handles instead of numbers, remove
+typeof == "number" checks.
+
+* inspector/front-end/CodeMirrorTextEditor.js:
+(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
+(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
+(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):
+
2012-08-14 Yuta Kitamura
Unreviewed. Fix Chromium-Android builds.
Modified: trunk/Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js (125649 => 125650)
--- trunk/Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js 2012-08-15 05:53:18 UTC (rev 125649)
+++ trunk/Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js 2012-08-15 06:25:36 UTC (rev 125650)
@@ -150,7 +150,7 @@
clearExecutionLine: function()
{
-if (typeof this._executionLine == "number")
+if (this._executionLine)
this._codeMirror.setLineClass(this._executionLine, null, null);
delete this._executionLine;
},
@@ -188,8 +188,8 @@
highlightLine: function(lineNumber)
{
this.clearLineHighlight();
-this._codeMirror.setLineClass(lineNumber, null, "cm-highlight");
-this._highlightedLine = lineNumber;
+this._highlightedLine = this._codeMirror.getLineHandle(lineNumber);
+this._codeMirror.setLineClass(this._highlightedLine, null, "cm-highlight");
this._clearHighlightTimeout = setTimeout(this.clearLineHighlight.bind(this), 2000);
},
@@ -199,7 +199,7 @@
clearTimeout(this._clearHighlightTimeout);
delete this._clearHighlightTimeout;
-if (typeof this._highlightedLine == "number")
+if (this._highlightedLine)
this._codeMirror.setLineClass(this._highlightedLine, null, null);
delete this._highlightedLine;
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125649] trunk/Source/WebCore
Title: [125649] trunk/Source/WebCore
Revision 125649
Author yu...@chromium.org
Date 2012-08-14 22:53:18 -0700 (Tue, 14 Aug 2012)
Log Message
Unreviewed. Fix Chromium-Android builds.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::TimeInputType):
Declare the function as a constructor.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/TimeInputType.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (125648 => 125649)
--- trunk/Source/WebCore/ChangeLog 2012-08-15 05:20:45 UTC (rev 125648)
+++ trunk/Source/WebCore/ChangeLog 2012-08-15 05:53:18 UTC (rev 125649)
@@ -1,3 +1,11 @@
+2012-08-14 Yuta Kitamura
+
+Unreviewed. Fix Chromium-Android builds.
+
+* html/TimeInputType.cpp:
+(WebCore::TimeInputType::TimeInputType):
+Declare the function as a constructor.
+
2012-08-14 Sukolsak Sakshuwong
Text selection in text area in auto scroll mode goes wrong.
Modified: trunk/Source/WebCore/html/TimeInputType.cpp (125648 => 125649)
--- trunk/Source/WebCore/html/TimeInputType.cpp 2012-08-15 05:20:45 UTC (rev 125648)
+++ trunk/Source/WebCore/html/TimeInputType.cpp 2012-08-15 05:53:18 UTC (rev 125649)
@@ -278,7 +278,7 @@
}
}
#else
-TimeInputType(HTMLInputElement* element)
+TimeInputType::TimeInputType(HTMLInputElement* element)
: BaseDateAndTimeInputType(element)
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125648] trunk
Title: [125648] trunk
Revision 125648
Author commit-qu...@webkit.org
Date 2012-08-14 22:20:45 -0700 (Tue, 14 Aug 2012)
Log Message
Text selection in text area in auto scroll mode goes wrong.
https://bugs.webkit.org/show_bug.cgi?id=74346
Patch by Sukolsak Sakshuwong on 2012-08-14
Reviewed by Ojan Vafai.
Source/WebCore:
WebKit triggers autoscroll in text area when the user drags the cursor from inside
the text area to the outside. When that happens, it gets the local cursor position
relative to the node under the cursor from hit-testing, converts it to
the absolute position, and then converts it to the local position relative to the
text area. However, the hit-testing method of text area did not take scrolling
offset into account. This caused it to give an incorrect value of the local cursor
position. Make the hit-testing take scrolling offset into account.
Test: fast/events/autoscroll-in-textarea.html
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::createRenderer):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore):
* rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
LayoutTests:
* fast/events/autoscroll-in-textarea-expected.txt: Added.
* fast/events/autoscroll-in-textarea.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp
trunk/Source/WebCore/rendering/RenderTextControl.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h
Added Paths
trunk/LayoutTests/fast/events/autoscroll-in-textarea-expected.txt
trunk/LayoutTests/fast/events/autoscroll-in-textarea.html
Diff
Modified: trunk/LayoutTests/ChangeLog (125647 => 125648)
--- trunk/LayoutTests/ChangeLog 2012-08-15 05:07:00 UTC (rev 125647)
+++ trunk/LayoutTests/ChangeLog 2012-08-15 05:20:45 UTC (rev 125648)
@@ -1,3 +1,13 @@
+2012-08-14 Sukolsak Sakshuwong
+
+Text selection in text area in auto scroll mode goes wrong.
+https://bugs.webkit.org/show_bug.cgi?id=74346
+
+Reviewed by Ojan Vafai.
+
+* fast/events/autoscroll-in-textarea-expected.txt: Added.
+* fast/events/autoscroll-in-textarea.html: Added.
+
2012-08-14 Yuta Kitamura
[Chromium] Unreviewed. Remove obsolete test expectations, and mark
Added: trunk/LayoutTests/fast/events/autoscroll-in-textarea-expected.txt (0 => 125648)
--- trunk/LayoutTests/fast/events/autoscroll-in-textarea-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/autoscroll-in-textarea-expected.txt 2012-08-15 05:20:45 UTC (rev 125648)
@@ -0,0 +1,7 @@
+
+
+
+
+This tests autoscroll in text area correctly shows selection highlight. To manually test, scroll the text area down to the end. Slowly drag up your mouse starting from the line closest to the upper edge of the text area. Once the contents of the text area get scrolled a little, the selection should not jump down to the end.
+
+PASSED the selection did not jump down.
Added: trunk/LayoutTests/fast/events/autoscroll-in-textarea.html (0 => 125648)
--- trunk/LayoutTests/fast/events/autoscroll-in-textarea.html (rev 0)
+++ trunk/LayoutTests/fast/events/autoscroll-in-textarea.html 2012-08-15 05:20:45 UTC (rev 125648)
@@ -0,0 +1,67 @@
+
+
+
+
+#textarea {
+font-size: 18px;
+width: 400px;
+margin: 0;
+padding: 0;
+}
+
+
+
+
+
+a
+b
+c
+d
+e
+f
+g
+h
+i
+j
+k
+l
+m
+n
+o
+p
+
+This tests autoscroll in text area correctly shows selection highlight.
+To manually test, scroll the text area down to the end.
+Slowly drag up your mouse starting from the line closest to the upper edge of the text area.
+Once the contents of the text area get scrolled a little,
+the selection should not jump down to the end.
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+// The text area displays 6 lines of text. We scroll down to the end
+// and start dragging the cursor up from the first line that appears (the k line).
+// Therefore, the selection should contain the letter k.
+var textarea = document.getElementById("textarea");
+textarea.scrollTop = textarea.scrollHeight;
+if (window.eventSender) {
+var x = textarea.offsetLeft + textarea.offsetWidth / 2;
+var y = textarea.offsetTop + 1;
+eventSender.dragMode = false;
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseDown();
+eventSender.mouseMoveTo(x, 0);
+eventSender.mouseUp();
+
+var log = document.getElementById("log");
+var selectedText = window.getSelection().toString();
+if (selectedText.indexOf("k") != -1)
+log.innerText = "PASSED the selection did not jump down.";
+else
+log.innerText = "FAILED the selection jumped down.";
+
[webkit-changes] [125647] trunk/LayoutTests
Title: [125647] trunk/LayoutTests Revision 125647 Author yu...@chromium.org Date 2012-08-14 22:07:00 -0700 (Tue, 14 Aug 2012) Log Message [Chromium] Unreviewed. Remove obsolete test expectations, and mark slow tests as such. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (125646 => 125647) --- trunk/LayoutTests/ChangeLog 2012-08-15 04:27:23 UTC (rev 125646) +++ trunk/LayoutTests/ChangeLog 2012-08-15 05:07:00 UTC (rev 125647) @@ -1,3 +1,10 @@ +2012-08-14 Yuta Kitamura + +[Chromium] Unreviewed. Remove obsolete test expectations, and mark +slow tests as such. + +* platform/chromium/TestExpectations: + 2012-08-10 Kinuko Yasuda FileWriter fails with assertion when trying to write empty Blob Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125646 => 125647) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-15 04:27:23 UTC (rev 125646) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-15 05:07:00 UTC (rev 125647) @@ -66,6 +66,8 @@ BUGCR24182 SLOW SNOWLEOPARD DEBUG : svg/dom/baseVal-animVal-crash.html = PASS BUGCR24182 SLOW MAC : storage/indexeddb/factory-basics.html = PASS BUGCR24182 SLOW DEBUG : css3/flexbox/position-absolute-child.html = PASS +BUGCR24182 SLOW WIN MAC DEBUG : fast/events/tabindex-focus-blur-all.html = PASS +BUGCR24182 SLOW WIN SNOWLEOPARD DEBUG : fast/frames/invalid.html = PASS // These tests started being slow when we switched to DRT. BUGWK90488 SLOW LINUX WIN DEBUG : inspector = PASS @@ -2701,16 +2703,9 @@ BUGWK72039 LINUX ANDROID RELEASE : fast/forms/formaction-attribute.html = MISSING PASS BUGWK78620 LINUX ANDROID DEBUG SLOW : fast/forms/formaction-attribute.html = PASS TEXT -BUGWK70988 SNOWLEOPARD : fast/forms/submit-to-blank-multiple-times.html = PASS TEXT -BUGWK70988 SNOWLEOPARD : fast/overflow/003.xml = PASS TEXT -BUGWK70988 SNOWLEOPARD : fast/preloader/noscript.html = PASS TEXT +BUGWK70988 SNOWLEOPARD DEBUG : fast/forms/submit-to-blank-multiple-times.html = PASS TEXT +BUGWK70988 SNOWLEOPARD DEBUG : fast/overflow/003.xml = PASS TEXT -BUGWK70988 SNOWLEOPARD : fast/css/css-selector-deeply-nested.html = PASS TIMEOUT -BUGWK70988 SNOWLEOPARD : fast/events/tabindex-focus-blur-all.html = PASS TIMEOUT -BUGWK70988 SNOWLEOPARD : fast/frames/invalid.html = PASS TIMEOUT -BUGWK70988 SNOWLEOPARD : fast/parser/residual-style-dom.html = PASS TIMEOUT -BUGWK70988 SNOWLEOPARD : fast/text/khmer-crash.html = PASS TIMEOUT -BUGWK70988 SNOWLEOPARD : http/tests/navigation/navigation-interrupted-by-fragment.html = PASS TIMEOUT BUGWK70988 SNOWLEOPARD : jquery/traversing.html = PASS TIMEOUT // BUGWK70988 MAC DEBUG SLOW : fast/frames/calculate-fixed.html = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125645] branches/chromium/1229/Source/WebCore/html
Title: [125645] branches/chromium/1229/Source/WebCore/html
Revision 125645
Author ann...@chromium.org
Date 2012-08-14 21:22:23 -0700 (Tue, 14 Aug 2012)
Log Message
Revert 124798 - MediaSource should use it's own list of source URLs
https://bugs.webkit.org/show_bug.cgi?id=93285
Reviewed by Eric Carlson.
r124780 added MediaSource objects to PublicURLManager's streamURLs list,
piggy-backing on MEDIA_STREAM. This patch creates a sourceURLs list so
that MediaSource can stand on its own.
Test: builds on Andriod even when MEDIA_STREAM is disabled.
* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* html/PublicURLManager.h:
(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs):
TBR=ann...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836255
Modified Paths
branches/chromium/1229/Source/WebCore/html/DOMURL.cpp
branches/chromium/1229/Source/WebCore/html/PublicURLManager.h
Diff
Modified: branches/chromium/1229/Source/WebCore/html/DOMURL.cpp (125644 => 125645)
--- branches/chromium/1229/Source/WebCore/html/DOMURL.cpp 2012-08-15 04:02:17 UTC (rev 125644)
+++ branches/chromium/1229/Source/WebCore/html/DOMURL.cpp 2012-08-15 04:22:23 UTC (rev 125645)
@@ -68,7 +68,7 @@
return String();
MediaSourceRegistry::registry().registerMediaSourceURL(publicURL, source);
-scriptExecutionContext->publicURLManager().sourceURLs().add(publicURL.string());
+scriptExecutionContext->publicURLManager().streamURLs().add(publicURL.string());
return publicURL.string();
}
Modified: branches/chromium/1229/Source/WebCore/html/PublicURLManager.h (125644 => 125645)
--- branches/chromium/1229/Source/WebCore/html/PublicURLManager.h 2012-08-15 04:02:17 UTC (rev 125644)
+++ branches/chromium/1229/Source/WebCore/html/PublicURLManager.h 2012-08-15 04:22:23 UTC (rev 125645)
@@ -37,11 +37,6 @@
#include "MediaStreamRegistry.h"
#endif
-#if ENABLE(MEDIA_SOURCE)
-#include "MediaSource.h"
-#include "MediaSourceRegistry.h"
-#endif
-
namespace WebCore {
class ScriptExecutionContext;
@@ -61,29 +56,18 @@
for (HashSet::iterator iter = m_streamURLs.begin(); iter != streamURLsEnd; ++iter)
MediaStreamRegistry::registry().unregisterMediaStreamURL(KURL(ParsedURLString, *iter));
#endif
-#if ENABLE(MEDIA_SOURCE)
-HashSet::iterator sourceURLsEnd = m_sourceURLs.end();
-for (HashSet::iterator iter = m_sourceURLs.begin(); iter != sourceURLsEnd; ++iter)
-MediaSourceRegistry::registry().unregisterMediaSourceURL(KURL(ParsedURLString, *iter));
-#endif
}
HashSet& blobURLs() { return m_blobURLs; }
#if ENABLE(MEDIA_STREAM)
HashSet& streamURLs() { return m_streamURLs; }
#endif
-#if ENABLE(MEDIA_SOURCE)
-HashSet& sourceURLs() { return m_sourceURLs; }
-#endif
private:
HashSet m_blobURLs;
#if ENABLE(MEDIA_STREAM)
HashSet m_streamURLs;
#endif
-#if ENABLE(MEDIA_SOURCE)
-HashSet m_sourceURLs;
-#endif
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125644] trunk/Source/WebCore
Title: [125644] trunk/Source/WebCore Revision 125644 Author shin...@chromium.org Date 2012-08-14 21:02:17 -0700 (Tue, 14 Aug 2012) Log Message [Refactoring] RenderMenuList and RenderListBox should have a method to return HTMLSelectElement. https://bugs.webkit.org/show_bug.cgi?id=94061 Reviewed by Kent Tamura. This is a preparation patch for Bug 91487. Since RenderMenuList::node() and RenderListBox::node() will not return HTMLSelectElement to fix Bug 91487, it would be good to have a method to HTMLSelectElement. No new tests, no change in behavior. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::selectElement): (WebCore): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::scrollToRevealSelection): (WebCore::RenderListBox::size): (WebCore::RenderListBox::numItems): (WebCore::RenderListBox::addFocusRingRects): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::panScroll): (WebCore::RenderListBox::autoscroll): (WebCore::RenderListBox::stopAutoscroll): (WebCore::RenderListBox::valueChanged): (WebCore::RenderListBox::nodeAtPoint): * rendering/RenderListBox.h: (WebCore): (RenderListBox): * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::selectElement): (WebCore): (WebCore::RenderMenuList::updateOptionsWidth): (WebCore::RenderMenuList::updateFromElement): (WebCore::RenderMenuList::setTextFromOption): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::valueChanged): (WebCore::RenderMenuList::listBoxSelectItem): (WebCore::RenderMenuList::multiple): (WebCore::RenderMenuList::didSetSelectedIndex): (WebCore::RenderMenuList::didUpdateActiveOption): (WebCore::RenderMenuList::itemText): (WebCore::RenderMenuList::itemAccessibilityText): (WebCore::RenderMenuList::itemToolTip): (WebCore::RenderMenuList::itemIsEnabled): (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::itemBackgroundColor): (WebCore::RenderMenuList::listSize): (WebCore::RenderMenuList::selectedIndex): (WebCore::RenderMenuList::itemIsSeparator): (WebCore::RenderMenuList::itemIsLabel): (WebCore::RenderMenuList::itemIsSelected): (WebCore::RenderMenuList::setTextFromItem): * rendering/RenderMenuList.h: (WebCore): (RenderMenuList): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderListBox.cpp trunk/Source/WebCore/rendering/RenderListBox.h trunk/Source/WebCore/rendering/RenderMenuList.cpp trunk/Source/WebCore/rendering/RenderMenuList.h Diff Modified: trunk/Source/WebCore/ChangeLog (125643 => 125644) --- trunk/Source/WebCore/ChangeLog 2012-08-15 04:00:39 UTC (rev 125643) +++ trunk/Source/WebCore/ChangeLog 2012-08-15 04:02:17 UTC (rev 125644) @@ -1,3 +1,61 @@ +2012-08-14 Shinya Kawanaka + +[Refactoring] RenderMenuList and RenderListBox should have a method to return HTMLSelectElement. +https://bugs.webkit.org/show_bug.cgi?id=94061 + +Reviewed by Kent Tamura. + +This is a preparation patch for Bug 91487. Since RenderMenuList::node() and RenderListBox::node() +will not return HTMLSelectElement to fix Bug 91487, it would be good to have a method to HTMLSelectElement. + +No new tests, no change in behavior. + +* rendering/RenderListBox.cpp: +(WebCore::RenderListBox::selectElement): +(WebCore): +(WebCore::RenderListBox::updateFromElement): +(WebCore::RenderListBox::scrollToRevealSelection): +(WebCore::RenderListBox::size): +(WebCore::RenderListBox::numItems): +(WebCore::RenderListBox::addFocusRingRects): +(WebCore::RenderListBox::paintItemForeground): +(WebCore::RenderListBox::paintItemBackground): +(WebCore::RenderListBox::panScroll): +(WebCore::RenderListBox::autoscroll): +(WebCore::RenderListBox::stopAutoscroll): +(WebCore::RenderListBox::valueChanged): +(WebCore::RenderListBox::nodeAtPoint): +* rendering/RenderListBox.h: +(WebCore): +(RenderListBox): +* rendering/RenderMenuList.cpp: +(WebCore::RenderMenuList::selectElement): +(WebCore): +(WebCore::RenderMenuList::updateOptionsWidth): +(WebCore::RenderMenuList::updateFromElement): +(WebCore::RenderMenuList::setTextFromOption): +(WebCore::RenderMenuList::showPopup): +(WebCore::RenderMenuList::valueChanged): +(WebCore::RenderMenuList::listBoxSelectItem): +(WebCore::RenderMenuList::multiple): +(WebCore::RenderMenuList::didSetSelectedIndex): +(WebCore::RenderMenuList::didUpdateActiveOption): +(WebCore::RenderMenuList::itemText): +(WebCore::RenderMenuList::itemAccessibilityText): +(WebCore::RenderMenuList::itemToolTip): +(WebCore::RenderMenuList::itemIsEnabled): +(WebCore::RenderMenuList::itemStyle): +(WebCore::RenderMenuList::itemBackgroundColor): +(WebCore::RenderMenuList::listSize): +(WebCor
[webkit-changes] [125643] trunk
Title: [125643] trunk Revision 125643 Author kin...@chromium.org Date 2012-08-14 21:00:39 -0700 (Tue, 14 Aug 2012) Log Message FileWriter fails with assertion when trying to write empty Blob https://bugs.webkit.org/show_bug.cgi?id=93694 Reviewed by Kent Tamura. if the given data size is zero (i.e. m_bytesToWrite is zero) the assertion 'bytes + m_bytesWritten > 0' should not be tested. Source/WebCore: Tests: fast/filesystem/file-writer-empty-blob.html fast/filesystem/workers/file-writer-empty-blob.html * Modules/filesystem/FileWriter.cpp: (WebCore::FileWriter::didWrite): LayoutTests: * fast/filesystem/file-writer-empty-blob-expected.txt: Added. * fast/filesystem/file-writer-empty-blob.html: Added. * fast/filesystem/resources/file-writer-empty-blob.js: Added. * fast/filesystem/workers/file-writer-empty-blob-expected.txt: Added. * fast/filesystem/workers/file-writer-empty-blob.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/filesystem/FileWriter.cpp Added Paths trunk/LayoutTests/fast/filesystem/file-writer-empty-blob-expected.txt trunk/LayoutTests/fast/filesystem/file-writer-empty-blob.html trunk/LayoutTests/fast/filesystem/resources/file-writer-empty-blob.js trunk/LayoutTests/fast/filesystem/workers/file-writer-empty-blob-expected.txt trunk/LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html Diff Modified: trunk/LayoutTests/ChangeLog (125642 => 125643) --- trunk/LayoutTests/ChangeLog 2012-08-15 03:45:05 UTC (rev 125642) +++ trunk/LayoutTests/ChangeLog 2012-08-15 04:00:39 UTC (rev 125643) @@ -1,3 +1,18 @@ +2012-08-10 Kinuko Yasuda + +FileWriter fails with assertion when trying to write empty Blob +https://bugs.webkit.org/show_bug.cgi?id=93694 + +Reviewed by Kent Tamura. + +if the given data size is zero (i.e. m_bytesToWrite is zero) the assertion 'bytes + m_bytesWritten > 0' should not be tested. + +* fast/filesystem/file-writer-empty-blob-expected.txt: Added. +* fast/filesystem/file-writer-empty-blob.html: Added. +* fast/filesystem/resources/file-writer-empty-blob.js: Added. +* fast/filesystem/workers/file-writer-empty-blob-expected.txt: Added. +* fast/filesystem/workers/file-writer-empty-blob.html: Added. + 2012-08-14 Yuta Kitamura [Chromium] Unreviewed, another gardening. Add one slow test. Added: trunk/LayoutTests/fast/filesystem/file-writer-empty-blob-expected.txt (0 => 125643) --- trunk/LayoutTests/fast/filesystem/file-writer-empty-blob-expected.txt (rev 0) +++ trunk/LayoutTests/fast/filesystem/file-writer-empty-blob-expected.txt 2012-08-15 04:00:39 UTC (rev 125643) @@ -0,0 +1,10 @@ +Test that FileWriter works without crash when trying to write an empty blob. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + +starting test +PASS Successfully wrote blob. +PASS successfullyParsed is true + +TEST COMPLETE + Property changes on: trunk/LayoutTests/fast/filesystem/file-writer-empty-blob-expected.txt ___ Added: svn:eol-style Added: trunk/LayoutTests/fast/filesystem/file-writer-empty-blob.html (0 => 125643) --- trunk/LayoutTests/fast/filesystem/file-writer-empty-blob.html (rev 0) +++ trunk/LayoutTests/fast/filesystem/file-writer-empty-blob.html 2012-08-15 04:00:39 UTC (rev 125643) @@ -0,0 +1,15 @@ + + + +File Writer with empty Blob + + + + +