[webkit-changes] [127701] trunk/Source/WebCore
Title: [127701] trunk/Source/WebCore
Revision 127701
Author commit-qu...@webkit.org
Date 2012-09-06 00:16:52 -0700 (Thu, 06 Sep 2012)
Log Message
[V8] V8HTMLDocument has two out-of-style function names
https://bugs.webkit.org/show_bug.cgi?id=95893
Patch by Adam Barth on 2012-09-06
Reviewed by Kentaro Hara.
Just a simple style cleanup.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
(WebCore::V8HTMLDocument::getNamedProperty):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127700 => 127701)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 06:48:50 UTC (rev 127700)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 07:16:52 UTC (rev 127701)
@@ -1,3 +1,22 @@
+2012-09-06 Adam Barth
+
+[V8] V8HTMLDocument has two out-of-style function names
+https://bugs.webkit.org/show_bug.cgi?id=95893
+
+Reviewed by Kentaro Hara.
+
+Just a simple style cleanup.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeader):
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::getter):
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::instantiateV8Object):
+* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+(WebCore::V8HTMLDocument::wrapInShadowObject):
+(WebCore::V8HTMLDocument::getNamedProperty):
+
2012-09-05 Andrei Poenaru
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (127700 => 127701)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-09-06 06:48:50 UTC (rev 127700)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-09-06 07:16:52 UTC (rev 127701)
@@ -401,8 +401,8 @@
if ($implClassName eq "HTMLDocument") {
push(@headerContent, <- static v8::Local WrapInShadowObject(v8::Local wrapper, Node* impl);
- static v8::Handle GetNamedProperty(HTMLDocument* htmlDocument, const AtomicString& key, v8::Isolate*);
+ static v8::Local wrapInShadowObject(v8::Local wrapper, Node* impl);
+ static v8::Handle getNamedProperty(HTMLDocument* htmlDocument, const AtomicString& key, v8::Isolate*);
END
}
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (127700 => 127701)
--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-09-06 06:48:50 UTC (rev 127700)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-09-06 07:16:52 UTC (rev 127701)
@@ -488,7 +488,7 @@
AtomicString name = toWebCoreAtomicString(property);
HTMLDocument* htmlDocument = V8HTMLDocument::toNative(info.Holder());
ASSERT(htmlDocument);
-v8::Handle result = V8HTMLDocument::GetNamedProperty(htmlDocument, name, info.GetIsolate());
+v8::Handle result = V8HTMLDocument::getNamedProperty(htmlDocument, name, info.GetIsolate());
if (!result.IsEmpty())
return result;
v8::Handle prototype = info.Holder()->GetPrototype();
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (127700 => 127701)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-09-06 06:48:50 UTC (rev 127700)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-09-06 07:16:52 UTC (rev 127701)
@@ -197,7 +197,7 @@
// Avoid setting the DOM wrapper for failed allocations.
setDOMWrapper(instance, type, impl);
if (type == &V8HTMLDocument::info)
-instance = V8HTMLDocument::WrapInShadowObject(instance, static_cast(impl));
+instance = V8HTMLDocument::wrapInShadowObject(instance, static_cast(impl));
}
return instance;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp (127700 => 127701)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2012-09-06 06:48:50 UTC (rev 127700)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2012-09-06 07:16:52 UTC (rev 127701)
@@ -52,7 +52,7 @@
namespace WebCore {
-v8::Local V8HTMLDocument::WrapInShadowObject(v8::Local wrapper, Node* impl)
+v8::Local V8HTMLDocument::wrapInShadowObject(v8::Local wrapper, Node* impl)
{
DEFINE_STATIC_LOCAL(v8::Persistent, shadowTemplate, ());
if (shadowTemplate.IsEmpty()) {
@@ -80,7 +80,7 @@
return shadow;
}
-v8::Handle V8HTMLDocument::GetNamedProperty(HTMLDocument* htmlDocument, const AtomicString& key, v8::Isolate* isolate)
+v8::Handle V8HTMLDocument::getNamedProperty(HTMLDocument* htmlDocument, const AtomicString& key, v8::Isolate* isolate)
{
if (!h
[webkit-changes] [127702] trunk/Source/WTF
Title: [127702] trunk/Source/WTF
Revision 127702
Author aba...@webkit.org
Date 2012-09-06 00:21:03 -0700 (Thu, 06 Sep 2012)
Log Message
Remove WTF::String::operator+=
https://bugs.webkit.org/show_bug.cgi?id=95797
Patch by Adam Barth on 2012-09-06
Reviewed by Sam Weinig.
This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.
* wtf/Platform.h
* wtf/text/WTFString.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WTF/wtf/text/WTFString.h
Diff
Modified: trunk/Source/WTF/ChangeLog (127701 => 127702)
--- trunk/Source/WTF/ChangeLog 2012-09-06 07:16:52 UTC (rev 127701)
+++ trunk/Source/WTF/ChangeLog 2012-09-06 07:21:03 UTC (rev 127702)
@@ -1,3 +1,18 @@
+2012-09-06 Adam Barth
+
+Remove WTF::String::operator+=
+https://bugs.webkit.org/show_bug.cgi?id=95797
+
+Reviewed by Sam Weinig.
+
+This patch encloses WTF::String::operator+= in an ifdef so that we can
+gradually remove it from the various port-specific files. The ifdef
+lets us whitelist use of operator+= in individual files during the
+transition.
+
+* wtf/Platform.h
+* wtf/text/WTFString.h:
+
2012-09-05 Gabor Rapcsanyi
DFG JIT doesn't work properly on ARM hardfp
Modified: trunk/Source/WTF/wtf/Platform.h (127701 => 127702)
--- trunk/Source/WTF/wtf/Platform.h 2012-09-06 07:16:52 UTC (rev 127701)
+++ trunk/Source/WTF/wtf/Platform.h 2012-09-06 07:21:03 UTC (rev 127702)
@@ -1185,6 +1185,10 @@
#define WTF_USE_ZLIB 1
#endif
+#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN)
+#define WTF_DEPRECATED_STRING_OPERATORS
+#endif
+
#if PLATFORM(QT)
#include
#if defined(QT_OPENGL_ES_2) && !defined(WTF_USE_OPENGL_ES_2)
Modified: trunk/Source/WTF/wtf/text/WTFString.h (127701 => 127702)
--- trunk/Source/WTF/wtf/text/WTFString.h 2012-09-06 07:16:52 UTC (rev 127701)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2012-09-06 07:21:03 UTC (rev 127702)
@@ -466,7 +466,9 @@
QDataStream& operator>>(QDataStream& stream, String& str);
#endif
+#ifdef WTF_DEPRECATED_STRING_OPERATORS
inline String& operator+=(String& a, const String& b) { a.append(b); return a; }
+#endif
inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); }
inline bool operator==(const String& a, const LChar* b) { return equal(a.impl(), b); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127704] trunk
Title: [127704] trunk
Revision 127704
Author aba...@webkit.org
Date 2012-09-06 00:35:43 -0700 (Thu, 06 Sep 2012)
Log Message
Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
https://bugs.webkit.org/show_bug.cgi?id=91110
Reviewed by Tony Chang.
Source/WebKit/chromium:
Prior to this patch, we were ignoring the user-scalable property of
viewport meta tags. This patch enforces the user-scalable property by
claming the minimum-scale and maximum-scale values, effectively
preventing user scaling. This approach isn't perfect, as discussed in
https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
over the status quo.
This approach is also used by EFL, GTK, and Qt.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
LayoutTests:
Test that the scale limits are clamped when user-scalable is set to no.
* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt: Added.
* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: Added.
* fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt: Added.
* fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
Added Paths
trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt
trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html
trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt
trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127703 => 127704)
--- trunk/LayoutTests/ChangeLog 2012-09-06 07:28:59 UTC (rev 127703)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 07:35:43 UTC (rev 127704)
@@ -1,3 +1,17 @@
+2012-09-06 Adam Barth
+
+Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
+https://bugs.webkit.org/show_bug.cgi?id=91110
+
+Reviewed by Tony Chang.
+
+Test that the scale limits are clamped when user-scalable is set to no.
+
+* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt: Added.
+* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: Added.
+* fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt: Added.
+* fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: Added.
+
2012-09-06 Sheriff Bot
Unreviewed, rolling out r127700.
Added: trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt (0 => 127704)
--- trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt 2012-09-06 07:35:43 UTC (rev 127704)
@@ -0,0 +1,2 @@
+ALERT: PASS
+
Added: trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html (0 => 127704)
--- trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html (rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html 2012-09-06 07:35:43 UTC (rev 127704)
@@ -0,0 +1,16 @@
+
+
+
+function test() {
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+var viewportConfiguation = internals.configurationForViewport(document, 1, 320, 480, 320, 352);
+if (/userScalable true/.test(viewportConfiguation))
+alert("PASS");
+else
+alert("FAIL: " + viewportConfiguation);
+}
+}
+
+
+
Added: trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt (0 => 127704)
--- trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt 2012-09-06 07:35:43 UTC (rev 127704)
@@ -0,0 +1,2 @@
+ALERT: PASS
+
Added: trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html (0 => 127704)
--- trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html (rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html 2012-09-06 07:35:43 UTC (rev 127704)
@@ -0,0 +1,16 @@
+
+
+
+function test() {
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+var viewportConfiguation = internals.configura
[webkit-changes] [127705] trunk
Title: [127705] trunk Revision 127705 Author vse...@chromium.org Date 2012-09-06 00:40:56 -0700 (Thu, 06 Sep 2012) Log Message Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation. https://bugs.webkit.org/show_bug.cgi?id=95752 Reviewed by Alexander Pavlov. Source/WebCore: NetworkUISourceCodeProvider does not receive ResourceAdded event until resource is finished anymore. StylesSourceMapping now listens for workspace event instead of being called directly by NetworkUISourceCodeProvider. StylesSourceMapping is now created from inspector.js. ProjectDidReset event introduced instead of setTimeout hacks in mappings. * inspector/front-end/NetworkUISourceCodeProvider.js: (WebInspector.NetworkUISourceCodeProvider): (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded): (WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset): (WebInspector.NetworkUISourceCodeProvider.prototype._projectDidReset): * inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._onRequestFinished): * inspector/front-end/ScriptSnippetModel.js: (WebInspector.ScriptSnippetModel): (WebInspector.ScriptSnippetModel.prototype._projectWillReset): (WebInspector.ScriptSnippetModel.prototype._projectDidReset): * inspector/front-end/StylesSourceMapping.js: (WebInspector.StylesSourceMapping): (WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace): (WebInspector.StylesSourceMapping.prototype._addUISourceCode): (WebInspector.StylesSourceMapping.prototype._reset): * inspector/front-end/Workspace.js: (WebInspector.WorkspaceController.prototype._mainFrameNavigated): (WebInspector.Project.prototype.reset): * inspector/front-end/inspector.js: LayoutTests: * http/tests/inspector/network/network-request-revision-content-expected.txt: * http/tests/inspector/network/network-request-revision-content.html: * inspector/console/console-uncaught-exception-expected.txt: * inspector/debugger/network-uisourcecode-provider-expected.txt: * inspector/debugger/network-uisourcecode-provider.html: * inspector/debugger/script-snippet-model.html: * inspector/debugger/scripts-panel.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html trunk/LayoutTests/inspector/console/console-uncaught-exception-expected.txt trunk/LayoutTests/inspector/debugger/network-uisourcecode-provider-expected.txt trunk/LayoutTests/inspector/debugger/network-uisourcecode-provider.html trunk/LayoutTests/inspector/debugger/script-snippet-model.html trunk/LayoutTests/inspector/debugger/scripts-panel.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js trunk/Source/WebCore/inspector/front-end/StylesSourceMapping.js trunk/Source/WebCore/inspector/front-end/Workspace.js trunk/Source/WebCore/inspector/front-end/inspector.js Diff Modified: trunk/LayoutTests/ChangeLog (127704 => 127705) --- trunk/LayoutTests/ChangeLog 2012-09-06 07:35:43 UTC (rev 127704) +++ trunk/LayoutTests/ChangeLog 2012-09-06 07:40:56 UTC (rev 127705) @@ -1,3 +1,18 @@ +2012-09-04 Vsevolod Vlasov + +Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation. +https://bugs.webkit.org/show_bug.cgi?id=95752 + +Reviewed by Alexander Pavlov. + +* http/tests/inspector/network/network-request-revision-content-expected.txt: +* http/tests/inspector/network/network-request-revision-content.html: +* inspector/console/console-uncaught-exception-expected.txt: +* inspector/debugger/network-uisourcecode-provider-expected.txt: +* inspector/debugger/network-uisourcecode-provider.html: +* inspector/debugger/script-snippet-model.html: +* inspector/debugger/scripts-panel.html: + 2012-09-06 Adam Barth Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly. Modified: trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt (127704 => 127705) --- trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt 2012-09-06 07:35:43 UTC (rev 127704) +++ trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt 2012-09-06 07:40:56 UTC (rev 127705) @@ -1,6 +1,6 @@ Tests how revision requests content if original content was not loaded yet. Bug 63631 -http://127.0.0.1:8000/inspector/network/resource/style.css +http://127.0.0.1:8000/inspector/network/resources/style.css Modified: trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html (127704 => 12770
[webkit-changes] [127706] trunk/Source/WebCore
Title: [127706] trunk/Source/WebCore
Revision 127706
Author aba...@webkit.org
Date 2012-09-06 00:47:08 -0700 (Thu, 06 Sep 2012)
Log Message
More fixes for String::operator+=() in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=95888
Patch by Patrick Gansterer on 2012-09-06
Reviewed by Adam Barth.
Use StringBuilder to concatenate strings instead of operator+=().
* dom/Element.cpp:
(WebCore::Element::formatForDebugger):
* dom/Node.cpp:
(WebCore::appendAttributeDesc):
(WebCore::Node::showNode):
(WebCore::traverseTreeAndMark):
(WebCore::Node::formatForDebugger):
* dom/Position.cpp:
(WebCore::Position::formatForDebugger):
* dom/Range.cpp:
(WebCore):
(WebCore::Range::formatForDebugger):
* dom/Text.cpp:
(WebCore::Text::formatForDebugger):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::formatForDebugger):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/dom/Range.cpp
trunk/Source/WebCore/dom/Text.cpp
trunk/Source/WebCore/editing/VisibleSelection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127705 => 127706)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 07:40:56 UTC (rev 127705)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 07:47:08 UTC (rev 127706)
@@ -1,3 +1,29 @@
+2012-09-06 Patrick Gansterer
+
+More fixes for String::operator+=() in Debug mode
+https://bugs.webkit.org/show_bug.cgi?id=95888
+
+Reviewed by Adam Barth.
+
+Use StringBuilder to concatenate strings instead of operator+=().
+
+* dom/Element.cpp:
+(WebCore::Element::formatForDebugger):
+* dom/Node.cpp:
+(WebCore::appendAttributeDesc):
+(WebCore::Node::showNode):
+(WebCore::traverseTreeAndMark):
+(WebCore::Node::formatForDebugger):
+* dom/Position.cpp:
+(WebCore::Position::formatForDebugger):
+* dom/Range.cpp:
+(WebCore):
+(WebCore::Range::formatForDebugger):
+* dom/Text.cpp:
+(WebCore::Text::formatForDebugger):
+* editing/VisibleSelection.cpp:
+(WebCore::VisibleSelection::formatForDebugger):
+
2012-09-04 Vsevolod Vlasov
Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation.
Modified: trunk/Source/WebCore/dom/Element.cpp (127705 => 127706)
--- trunk/Source/WebCore/dom/Element.cpp 2012-09-06 07:40:56 UTC (rev 127705)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-09-06 07:47:08 UTC (rev 127706)
@@ -1397,31 +1397,28 @@
#ifndef NDEBUG
void Element::formatForDebugger(char* buffer, unsigned length) const
{
-String result;
+StringBuilder result;
String s;
-
-s = nodeName();
-if (s.length() > 0) {
-result += s;
-}
-
+
+result.append(nodeName());
+
s = getIdAttribute();
if (s.length() > 0) {
if (result.length() > 0)
-result += "; ";
-result += "id=";
-result += s;
+result.appendLiteral("; ");
+result.appendLiteral("id=");
+result.append(s);
}
-
+
s = getAttribute(classAttr);
if (s.length() > 0) {
if (result.length() > 0)
-result += "; ";
-result += "class=";
-result += s;
+result.appendLiteral("; ");
+result.appendLiteral("class=");
+result.append(s);
}
-
-strncpy(buffer, result.utf8().data(), length - 1);
+
+strncpy(buffer, result.toString().utf8().data(), length - 1);
}
#endif
Modified: trunk/Source/WebCore/dom/Node.cpp (127705 => 127706)
--- trunk/Source/WebCore/dom/Node.cpp 2012-09-06 07:40:56 UTC (rev 127705)
+++ trunk/Source/WebCore/dom/Node.cpp 2012-09-06 07:47:08 UTC (rev 127706)
@@ -2097,15 +2097,17 @@
#ifndef NDEBUG
-static void appendAttributeDesc(const Node* node, String& string, const QualifiedName& name, const char* attrDesc)
+static void appendAttributeDesc(const Node* node, StringBuilder& stringBuilder, const QualifiedName& name, const char* attrDesc)
{
-if (node->isElementNode()) {
-String attr = static_cast(node)->getAttribute(name);
-if (!attr.isEmpty()) {
-string += attrDesc;
-string += attr;
-}
-}
+if (!node->isElementNode())
+return;
+
+String attr = static_cast(node)->getAttribute(name);
+if (attr.isEmpty())
+return;
+
+stringBuilder.append(attrDesc);
+stringBuilder.append(attr);
}
void Node::showNode(const char* prefix) const
@@ -2118,10 +2120,10 @@
value.replace('\n', "\\n");
fprintf(stderr, "%s%s\t%p \"%s\"\n", prefix, nodeName().utf8().data(), this, value.utf8().data());
} else {
-String attrs = "";
+StringBuilder attrs;
appendAttributeDesc(this, attrs, classAttr, " CLASS=");
appendAttributeDesc(this, attrs, styleAttr, " STYLE=");
-fprintf(stderr, "%s%s\t%
[webkit-changes] [127707] trunk/Source/JavaScriptCore
Title: [127707] trunk/Source/_javascript_Core Revision 127707 Author par...@webkit.org Date 2012-09-06 01:33:45 -0700 (Thu, 06 Sep 2012) Log Message Build fix for Interpreter after r127698. * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/interpreter/Interpreter.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (127706 => 127707) --- trunk/Source/_javascript_Core/ChangeLog 2012-09-06 07:47:08 UTC (rev 127706) +++ trunk/Source/_javascript_Core/ChangeLog 2012-09-06 08:33:45 UTC (rev 127707) @@ -1,3 +1,10 @@ +2012-09-06 Patrick Gansterer + +Build fix for Interpreter after r127698. + +* interpreter/Interpreter.cpp: +(JSC::Interpreter::privateExecute): + 2012-09-05 Geoffrey Garen Named functions should not allocate scope objects for their names Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (127706 => 127707) --- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2012-09-06 07:47:08 UTC (rev 127706) +++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2012-09-06 08:33:45 UTC (rev 127707) @@ -4259,7 +4259,7 @@ int shouldCheck = vPC[3].u.operand; ASSERT(codeBlock->codeType() != FunctionCode || !codeBlock->needsFullScopeChain() || callFrame->r(codeBlock->activationRegister()).jsValue()); if (!shouldCheck || !callFrame->r(dst).jsValue()) -callFrame->uncheckedR(dst) = JSValue(codeBlock->functionDecl(func)->make(callFrame, callFrame->scope())); +callFrame->uncheckedR(dst) = JSValue(JSFunction::create(callFrame, codeBlock->functionDecl(func), callFrame->scope())); vPC += OPCODE_LENGTH(op_new_func); NEXT_INSTRUCTION(); @@ -4277,7 +4277,7 @@ ASSERT(codeBlock->codeType() != FunctionCode || !codeBlock->needsFullScopeChain() || callFrame->r(codeBlock->activationRegister()).jsValue()); FunctionExecutable* function = codeBlock->functionExpr(funcIndex); -JSFunction* func = function->make(callFrame, callFrame->scope()); +JSFunction* func = JSFunction::create(callFrame, function, callFrame->scope()); callFrame->uncheckedR(dst) = JSValue(func); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127708] trunk/Source/WebCore
Title: [127708] trunk/Source/WebCore
Revision 127708
Author par...@webkit.org
Date 2012-09-06 01:56:16 -0700 (Thu, 06 Sep 2012)
Log Message
Remove String::operator+=() from plugin code
https://bugs.webkit.org/show_bug.cgi?id=95896
Reviewed by Adam Barth.
Use operator+() to concatenate strings instead of operator+=().
* plugins/PluginView.cpp:
(WebCore::parseRFC822HeaderFields):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/PluginView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127707 => 127708)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 08:33:45 UTC (rev 127707)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 08:56:16 UTC (rev 127708)
@@ -1,5 +1,17 @@
2012-09-06 Patrick Gansterer
+Remove String::operator+=() from plugin code
+https://bugs.webkit.org/show_bug.cgi?id=95896
+
+Reviewed by Adam Barth.
+
+Use operator+() to concatenate strings instead of operator+=().
+
+* plugins/PluginView.cpp:
+(WebCore::parseRFC822HeaderFields):
+
+2012-09-06 Patrick Gansterer
+
More fixes for String::operator+=() in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=95888
Modified: trunk/Source/WebCore/plugins/PluginView.cpp (127707 => 127708)
--- trunk/Source/WebCore/plugins/PluginView.cpp 2012-09-06 08:33:45 UTC (rev 127707)
+++ trunk/Source/WebCore/plugins/PluginView.cpp 2012-09-06 08:56:16 UTC (rev 127708)
@@ -1133,12 +1133,8 @@
value = String(colon, eol - colon);
String oldValue = headerFields.get(lastKey);
-if (!oldValue.isNull()) {
-String tmp = oldValue;
-tmp += ", ";
-tmp += value;
-value = tmp;
-}
+if (!oldValue.isNull())
+value = oldValue + ", " + value;
headerFields.set(lastKey, value);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127710] trunk
Title: [127710] trunk Revision 127710 Author commit-qu...@webkit.org Date 2012-09-06 02:17:10 -0700 (Thu, 06 Sep 2012) Log Message Three XSLTProcessor functions don't need to be [Custom] https://bugs.webkit.org/show_bug.cgi?id=95899 Patch by Adam Barth on 2012-09-06 Reviewed by Kentaro Hara. Source/WebCore: These functions are marked [Custom] because they predate our improvements to [Optional]. Now that we have [Optional=DefaultIsUndefined], we can autogenerate these functions. There is a (slight!) difference in behavior. Now, in the case of a type error, we return null instead of undefined. This change is unlikely to cause compatibility problems because the vast majority of folks will pass the correct arguments, and, in the few cases where folks pass the wrong argument types, null and undefined will likely work similarly (e.g., they're both falsy and throw when you try to access properties). * bindings/js/JSXSLTProcessorCustom.cpp: * bindings/v8/custom/V8XSLTProcessorCustom.cpp: * xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToDocument): (WebCore::XSLTProcessor::transformToFragment): * xml/XSLTProcessor.h: (WebCore::XSLTProcessor::importStylesheet): * xml/XSLTProcessor.idl: LayoutTests: Update results to show that we return null rather than undefined on a type error. * fast/xsl/transform-xhr-doc-expected.txt: * fast/xsl/xslt-processor-expected.txt: * platform/chromium/fast/xsl/transform-xhr-doc-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/xsl/transform-xhr-doc-expected.txt trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt trunk/LayoutTests/platform/chromium/fast/xsl/transform-xhr-doc-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp trunk/Source/WebCore/xml/XSLTProcessor.cpp trunk/Source/WebCore/xml/XSLTProcessor.h trunk/Source/WebCore/xml/XSLTProcessor.idl Diff Modified: trunk/LayoutTests/ChangeLog (127709 => 127710) --- trunk/LayoutTests/ChangeLog 2012-09-06 09:02:09 UTC (rev 127709) +++ trunk/LayoutTests/ChangeLog 2012-09-06 09:17:10 UTC (rev 127710) @@ -1,3 +1,17 @@ +2012-09-06 Adam Barth + +Three XSLTProcessor functions don't need to be [Custom] +https://bugs.webkit.org/show_bug.cgi?id=95899 + +Reviewed by Kentaro Hara. + +Update results to show that we return null rather than undefined on a +type error. + +* fast/xsl/transform-xhr-doc-expected.txt: +* fast/xsl/xslt-processor-expected.txt: +* platform/chromium/fast/xsl/transform-xhr-doc-expected.txt: + 2012-09-06 Kristóf Kosztyó [Qt] Unreviewed gardening. Skip the failing tests. Modified: trunk/LayoutTests/fast/xsl/transform-xhr-doc-expected.txt (127709 => 127710) --- trunk/LayoutTests/fast/xsl/transform-xhr-doc-expected.txt 2012-09-06 09:02:09 UTC (rev 127709) +++ trunk/LayoutTests/fast/xsl/transform-xhr-doc-expected.txt 2012-09-06 09:17:10 UTC (rev 127710) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 20: TypeError: 'undefined' is not an object (evaluating 'doc.documentElement') +CONSOLE MESSAGE: line 20: TypeError: 'null' is not an object (evaluating 'doc.documentElement') Test for bug 10313: xsl:import doesn't work in stylesheets loaded via XMLHttpRequest. It's nice that this hasn't crashed, but the XSL transformation has failed. Modified: trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt (127709 => 127710) --- trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt 2012-09-06 09:02:09 UTC (rev 127709) +++ trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt 2012-09-06 09:17:10 UTC (rev 127710) @@ -56,11 +56,11 @@ 2.0 DOMDocumentFragment transformToFragment(in DOMNode source, in DOMDocument output): 2.1 fragment with undefined source: -Failure (expected exception, instead got result: "undefined") +Failure (expected exception, instead got result: "null") 2.2 fragment with undefined output document: Success 2.3 use non-DOMDocument output parameter: -Failure (expected exception, instead got result: "undefined") +Failure (expected exception, instead got result: "null") 2.4 transform to same fragment twice: Success 2.5 transformed fragment containing only text: @@ -71,7 +71,7 @@ 3.0 DOMDocument transformToDocument(in DOMNode source): 3.1 use non-DOMDocument output parameter: -Failure (expected exception, instead got result: "undefined") +Failure (expected exception, instead got result: "null") 3.2 transform twice: Success Modified: trunk/LayoutTests/platform/chromium/fast/xsl/transform-xhr-doc-expected.txt (127709 => 127710) --- trunk/LayoutTests/platform/chromium/fast/xsl/transform-xhr-doc-expected.txt 2012-09-06 09:02:09 UTC (rev 127709) +++ trunk/LayoutTests/platform/chromium/fast/xsl/transform-xhr-doc-expected.txt 2012-09-06 09:17:10 UTC (rev 127710) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 20: Unc
[webkit-changes] [127711] trunk/Source/WebKit/chromium
Title: [127711] trunk/Source/WebKit/chromium Revision 127711 Author commit-qu...@webkit.org Date 2012-09-06 02:19:18 -0700 (Thu, 06 Sep 2012) Log Message Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents https://bugs.webkit.org/show_bug.cgi?id=94142 Patch by Raymes Khoury on 2012-09-06 Reviewed by Tony Chang. Previously we distinguished between left/right Shift/Ctrl/Alt in WebInputEvents by using the location-specific virtual keycodes (e.g. VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events always returns the non-locational version (e.g. VK_SHIFT). Furthermore, KeyboardEvent also returns non-locational keycodes and separates the location information which matches the behavior described in the DOM3 spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We should be consistent with this in our representation of key events. This patch changes WebInputEvents so they always store the non-locational keycode and location information is stored in modifiers. Since this only changes internal representation, no new tests are added. This patch also ensures that when KeyboardEvents are converted back to WebInputEvents location information is preserved (which was not happening before). This is important so that key location information is passed on to plugins. A unittest is added for this. * WebKit.gypi: * public/WebInputEvent.h: (WebKeyboardEvent): * src/WebInputEvent.cpp: (WebKit): (WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation): (WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode): * src/WebInputEventConversion.cpp: (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): * src/android/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::keyboardEvent): * src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::keyboardEvent): * src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::keyboardEvent): * src/win/WebInputEventFactory.cpp: (WebKit::getLocationModifier): (WebKit::WebInputEventFactory::keyboardEvent): * tests/WebInputEventConversionTest.cpp: Added. Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gypi trunk/Source/WebKit/chromium/public/WebInputEvent.h trunk/Source/WebKit/chromium/src/WebInputEvent.cpp trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp trunk/Source/WebKit/chromium/src/android/WebInputEventFactory.cpp trunk/Source/WebKit/chromium/src/gtk/WebInputEventFactory.cpp trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm trunk/Source/WebKit/chromium/src/win/WebInputEventFactory.cpp Added Paths trunk/Source/WebKit/chromium/tests/WebInputEventConversionTest.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (127710 => 127711) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:17:10 UTC (rev 127710) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:19:18 UTC (rev 127711) @@ -1,3 +1,50 @@ +2012-09-06 Raymes Khoury + +Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents +https://bugs.webkit.org/show_bug.cgi?id=94142 + +Reviewed by Tony Chang. + +Previously we distinguished between left/right Shift/Ctrl/Alt in +WebInputEvents by using the location-specific virtual keycodes (e.g. +VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events +always returns the non-locational version (e.g. VK_SHIFT). +Furthermore, KeyboardEvent also returns +non-locational keycodes and separates the location information which +matches the behavior described in the DOM3 +spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We +should be consistent with this in our representation of key events. +This patch changes WebInputEvents so they always store the +non-locational keycode and location information is stored in +modifiers. Since this only changes internal representation, no new +tests are added. + +This patch also ensures that when KeyboardEvents are converted back to +WebInputEvents location information is preserved (which was not +happening before). This is important so that key location information +is passed on to plugins. A unittest is added for this. + +* WebKit.gypi: +* public/WebInputEvent.h: +(WebKeyboardEvent): +* src/WebInputEvent.cpp: +(WebKit): +(WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation): +(WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode): +* src/WebInputEventConversion.cpp: +(WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): +(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): +* src/android/WebInputEventFactory.cpp: +(WebKit::WebInputEventFactory::keyboardEvent):
[webkit-changes] [127712] trunk/Source/WebCore
Title: [127712] trunk/Source/WebCore
Revision 127712
Author commit-qu...@webkit.org
Date 2012-09-06 02:38:25 -0700 (Thu, 06 Sep 2012)
Log Message
XMLHttpRequest.open does not need custom bindings
https://bugs.webkit.org/show_bug.cgi?id=95903
Patch by Adam Barth on 2012-09-06
Reviewed by Kentaro Hara.
There doesn't appear to be any reason that XMLHttpRequest.open needs
custom bindings now that [Optional] works the way XMLHttpRequest
expects.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore):
(WebCore::XMLHttpRequest::internalOpen):
* xml/XMLHttpRequest.h:
(XMLHttpRequest):
* xml/XMLHttpRequest.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (127711 => 127712)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 09:19:18 UTC (rev 127711)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 09:38:25 UTC (rev 127712)
@@ -1,5 +1,27 @@
2012-09-06 Adam Barth
+XMLHttpRequest.open does not need custom bindings
+https://bugs.webkit.org/show_bug.cgi?id=95903
+
+Reviewed by Kentaro Hara.
+
+There doesn't appear to be any reason that XMLHttpRequest.open needs
+custom bindings now that [Optional] works the way XMLHttpRequest
+expects.
+
+* bindings/js/JSXMLHttpRequestCustom.cpp:
+(WebCore):
+* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::open):
+(WebCore):
+(WebCore::XMLHttpRequest::internalOpen):
+* xml/XMLHttpRequest.h:
+(XMLHttpRequest):
+* xml/XMLHttpRequest.idl:
+
+2012-09-06 Adam Barth
+
Three XSLTProcessor functions don't need to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=95899
Modified: trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp (127711 => 127712)
--- trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2012-09-06 09:19:18 UTC (rev 127711)
+++ trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2012-09-06 09:38:25 UTC (rev 127712)
@@ -79,35 +79,7 @@
}
// Custom functions
-JSValue JSXMLHttpRequest::open(ExecState* exec)
-{
-if (exec->argumentCount() < 2)
-return throwError(exec, createNotEnoughArgumentsError(exec));
-const KURL& url = ""
-String method = exec->argument(0).toString(exec)->value(exec);
-
-ExceptionCode ec = 0;
-if (exec->argumentCount() >= 3) {
-bool async = exec->argument(2).toBoolean(exec);
-
-if (exec->argumentCount() >= 4 && !exec->argument(3).isUndefined()) {
-String user = valueToStringWithNullCheck(exec, exec->argument(3));
-
-if (exec->argumentCount() >= 5 && !exec->argument(4).isUndefined()) {
-String password = valueToStringWithNullCheck(exec, exec->argument(4));
-impl()->open(method, url, async, user, password, ec);
-} else
-impl()->open(method, url, async, user, ec);
-} else
-impl()->open(method, url, async, ec);
-} else
-impl()->open(method, url, ec);
-
-setDOMException(exec, ec);
-return jsUndefined();
-}
-
JSValue JSXMLHttpRequest::send(ExecState* exec)
{
InspectorInstrumentation::willSendXMLHttpRequest(impl()->scriptExecutionContext(), impl()->url());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (127711 => 127712)
--- trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp 2012-09-06 09:19:18 UTC (rev 127711)
+++ trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp 2012-09-06 09:38:25 UTC (rev 127712)
@@ -101,52 +101,6 @@
return v8::Undefined();
}
-v8::Handle V8XMLHttpRequest::openCallback(const v8::Arguments& args)
-{
-INC_STATS("DOM.XMLHttpRequest.open()");
-// Four cases:
-// open(method, url)
-// open(method, url, async)
-// open(method, url, async, user)
-// open(method, url, async, user, passwd)
-
-if (args.Length() < 2)
-return throwNotEnoughArgumentsError(args.GetIsolate());
-
-XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toNative(args.Holder());
-
-String method = toWebCoreString(args[0]);
-String urlstring = toWebCoreString(args[1]);
-ScriptExecutionContext* context = getScriptExecutionContext();
-if (!context)
-return v8::Undefined();
-
-KURL url = ""
-
-ExceptionCode ec = 0;
-
-if (args.Length() >= 3) {
-bool async = args[2]->BooleanValue();
-
-if (args.Length() >= 4 && !args[3]->IsUndefined()) {
-String user = toWebCoreStringWithNullCheck(
[webkit-changes] [127714] trunk/Source/WebKit/chromium
Title: [127714] trunk/Source/WebKit/chromium Revision 127714 Author pe...@chromium.org Date 2012-09-06 02:46:42 -0700 (Thu, 06 Sep 2012) Log Message [Chromium] Chromium Mac build fix after revision r127711 https://bugs.webkit.org/show_bug.cgi?id=95958 Unreviewed build fix. This is a clear typo in the source file, so changing the function to call locationModifiersFromWindowsKeyCode instead. * src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::keyboardEvent): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (127713 => 127714) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:42:09 UTC (rev 127713) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:46:42 UTC (rev 127714) @@ -1,3 +1,16 @@ +2012-09-06 Peter Beverloo + +[Chromium] Chromium Mac build fix after revision r127711 +https://bugs.webkit.org/show_bug.cgi?id=95958 + +Unreviewed build fix. + +This is a clear typo in the source file, so changing the function to +call locationModifiersFromWindowsKeyCode instead. + +* src/mac/WebInputEventFactory.mm: +(WebKit::WebInputEventFactory::keyboardEvent): + 2012-09-06 Raymes Khoury Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents Modified: trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm (127713 => 127714) --- trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm 2012-09-06 09:42:09 UTC (rev 127713) +++ trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm 2012-09-06 09:46:42 UTC (rev 127714) @@ -608,7 +608,7 @@ int windowsKeyCode = windowsKeyCodeForKeyEvent(event); result.windowsKeyCode = WebKeyboardEvent::windowsKeyCodeWithoutLocation(windowsKeyCode); -result.modifiers |= WebKeyboardEvent::locationModifiersFromKeyCode(windowsKeyCode); +result.modifiers |= WebKeyboardEvent::locationModifiersFromWindowsKeyCode(windowsKeyCode); result.nativeKeyCode = [event keyCode]; NSString* textStr = textFromEvent(event); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127715] trunk/Source
Title: [127715] trunk/Source
Revision 127715
Author dan...@chromium.org
Date 2012-09-06 02:48:42 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Add a copy() method to CCRenderPass
https://bugs.webkit.org/show_bug.cgi?id=95485
Reviewed by Adrienne Walker.
Source/WebCore:
This method allows the ubercomp layer to make a clone of its delegated
RenderPasses to insert into the current frame.
Tests: CCRenderPassTest.copyShouldBeIdenticalExceptIdAndQuads
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::copy):
(WebCore):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
Source/WebKit/chromium:
* WebKit.gypi:
* tests/CCRenderPassTest.cpp: Added.
(CCTestRenderPass):
(CCTestRenderPass::quadList):
(CCTestRenderPass::sharedQuadStateList):
(CCRenderPassSize):
(TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
Added Paths
trunk/Source/WebKit/chromium/tests/CCRenderPassTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127714 => 127715)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 09:46:42 UTC (rev 127714)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 09:48:42 UTC (rev 127715)
@@ -1,3 +1,21 @@
+2012-09-06 Dana Jansens
+
+[chromium] Add a copy() method to CCRenderPass
+https://bugs.webkit.org/show_bug.cgi?id=95485
+
+Reviewed by Adrienne Walker.
+
+This method allows the ubercomp layer to make a clone of its delegated
+RenderPasses to insert into the current frame.
+
+Tests: CCRenderPassTest.copyShouldBeIdenticalExceptIdAndQuads
+
+* platform/graphics/chromium/cc/CCRenderPass.cpp:
+(WebCore::CCRenderPass::copy):
+(WebCore):
+* platform/graphics/chromium/cc/CCRenderPass.h:
+(CCRenderPass):
+
2012-09-06 Adam Barth
XMLHttpRequest.open does not need custom bindings
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp (127714 => 127715)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp 2012-09-06 09:46:42 UTC (rev 127714)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp 2012-09-06 09:48:42 UTC (rev 127715)
@@ -53,6 +53,19 @@
ASSERT(id > 0);
}
+PassOwnPtr CCRenderPass::copy(int newId) const
+{
+ASSERT(newId != m_id);
+
+OwnPtr copyPass(create(newId, m_outputRect, m_transformToRootTarget));
+copyPass->setDamageRect(m_damageRect);
+copyPass->setHasTransparentBackground(m_hasTransparentBackground);
+copyPass->setHasOcclusionFromOutsideTargetSurface(m_hasOcclusionFromOutsideTargetSurface);
+copyPass->setFilters(m_filters);
+copyPass->setBackgroundFilters(m_backgroundFilters);
+return copyPass.release();
+}
+
void CCRenderPass::appendQuadsForLayer(CCLayerImpl* layer, CCOcclusionTrackerImpl* occlusionTracker, CCAppendQuadsData& appendQuadsData)
{
const bool forSurface = false;
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.h (127714 => 127715)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.h 2012-09-06 09:46:42 UTC (rev 127714)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.h 2012-09-06 09:48:42 UTC (rev 127715)
@@ -62,6 +62,9 @@
public:
static PassOwnPtr create(int id, IntRect outputRect, const WebKit::WebTransformationMatrix& transformToRootTarget);
+// A shallow copy of the render pass, which does not include its quads.
+PassOwnPtr copy(int newId) const;
+
void appendQuadsForLayer(CCLayerImpl*, CCOcclusionTrackerImpl*, CCAppendQuadsData&);
void appendQuadsForRenderSurfaceLayer(CCLayerImpl*, const CCRenderPass* contributingRenderPass, CCOcclusionTrackerImpl*, CCAppendQuadsData&);
void appendQuadsToFillScreen(CCLayerImpl* rootLayer, SkColor screenBackgroundColor, const CCOcclusionTrackerImpl&);
Modified: trunk/Source/WebKit/chromium/ChangeLog (127714 => 127715)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:46:42 UTC (rev 127714)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:48:42 UTC (rev 127715)
@@ -1,3 +1,18 @@
+2012-09-06 Dana Jansens
+
+[chromium] Add a copy() method to CCRenderPass
+https://bugs.webkit.org/show_bug.cgi?id=95485
+
+Reviewed by Adrienne Walker.
+
+* WebKit.gypi:
+* tests/CCRenderPassTest.cpp: Added.
+(CCTestRenderPass):
+(CCTestRenderPass::quadList):
+(CCTestRenderPass::sharedQuadStateList):
+(CCRenderPassSize):
+(TEST):
+
2012-09-06 Peter Beverloo
[Chromium] Chromium Mac build fix after revision r127711
Modified: trunk/Source/WebKit/chromium/WebKit.gypi (127714 => 127715)
--- trunk/Source/WebKit/chromium/WebKit.gypi 2012-09-06 09:46:42 UTC (rev 127714)
+++ trunk/Source/WebKit/chromi
[webkit-changes] [127716] trunk/Source/WebCore
Title: [127716] trunk/Source/WebCore
Revision 127716
Author commit-qu...@webkit.org
Date 2012-09-06 02:52:27 -0700 (Thu, 06 Sep 2012)
Log Message
[BlackBerry] Removing String operator += uses in Cookie Files
https://bugs.webkit.org/show_bug.cgi?id=95884
Patch by Otto Derek Cheung on 2012-09-06
Reviewed by Rob Buis.
Replacing all usages of String operator += in the Cookie code because it is being deprecated.
String concats are now done using + or StringBuilder.
PR 203054
Tested using Browser Test Cookie suite on browsertest01.rim.net/networking/cookies.
* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
(WebCore::CookieDatabaseBackingStore::invokeOpen):
(WebCore::CookieDatabaseBackingStore::invokeRemoveAll):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp
trunk/Source/WebCore/platform/blackberry/CookieManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127715 => 127716)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 09:48:42 UTC (rev 127715)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 09:52:27 UTC (rev 127716)
@@ -1,3 +1,24 @@
+2012-09-06 Otto Derek Cheung
+
+[BlackBerry] Removing String operator += uses in Cookie Files
+https://bugs.webkit.org/show_bug.cgi?id=95884
+
+Reviewed by Rob Buis.
+
+Replacing all usages of String operator += in the Cookie code because it is being deprecated.
+String concats are now done using + or StringBuilder.
+
+PR 203054
+
+Tested using Browser Test Cookie suite on browsertest01.rim.net/networking/cookies.
+
+* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
+(WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
+(WebCore::CookieDatabaseBackingStore::invokeOpen):
+(WebCore::CookieDatabaseBackingStore::invokeRemoveAll):
+* platform/blackberry/CookieManager.cpp:
+(WebCore::CookieManager::getRawCookies):
+
2012-09-06 Dana Jansens
[chromium] Add a copy() method to CCRenderPass
Modified: trunk/Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp (127715 => 127716)
--- trunk/Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp 2012-09-06 09:48:42 UTC (rev 127715)
+++ trunk/Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp 2012-09-06 09:52:27 UTC (rev 127716)
@@ -138,23 +138,25 @@
commands.append(renameQuery);
// Recreate the cookie table using the new database and primary key fields
-String createTableQuery("CREATE TABLE ");
-createTableQuery += m_tableName;
-createTableQuery += " (" + databaseFields + ", " + primaryKeyFields + ");";
-commands.append(createTableQuery);
+StringBuilder createTableQuery;
+createTableQuery.append("CREATE TABLE ");
+createTableQuery.append(m_tableName);
+createTableQuery.append(" (" + databaseFields + ", " + primaryKeyFields + ");");
+commands.append(createTableQuery.toString());
// Copy the old data into the new table. If a column does not exists,
// we have to put a '' in the select statement to make the number of columns
// equal in the insert statement.
-String migrationQuery("INSERT OR REPLACE INTO ");
-migrationQuery += m_tableName;
-migrationQuery += " SELECT *";
+StringBuilder migrationQuery;
+migrationQuery.append("INSERT OR REPLACE INTO ");
+migrationQuery.append(m_tableName);
+migrationQuery.append(" SELECT *");
if (!creationTimeExists)
-migrationQuery += ",''";
+migrationQuery.append(",''");
if (!protocolExists)
-migrationQuery += ",''";
-migrationQuery += " FROM Backup_" + m_tableName;
-commands.append(migrationQuery);
+migrationQuery.append(",''");
+migrationQuery.append(" FROM Backup_" + m_tableName);
+commands.append(migrationQuery.toString());
// The new columns will be blank, set the new values.
if (!creationTimeExists) {
@@ -224,46 +226,50 @@
upgradeTableIfNeeded(databaseFields, primaryKeyFields);
// Create table if not exsist in case that the upgradeTableIfNeeded() failed accidentally.
-String createTableQuery("CREATE TABLE IF NOT EXISTS ");
-createTableQuery += m_tableName;
+StringBuilder createTableQuery;
+createTableQuery.append("CREATE TABLE IF NOT EXISTS ");
+createTableQuery.append(m_tableName);
// This table schema is compliant with Mozilla's.
-createTableQuery += " (" + databaseFields + ", " + primaryKeyFields+");";
+createTableQuery.append(" (" + databaseFields + ", " + primaryKeyFields+");");
m_db.setBusyTimeout(1000);
-if (!m_d
[webkit-changes] [127717] trunk/Source/WebKit/chromium
Title: [127717] trunk/Source/WebKit/chromium
Revision 127717
Author pe...@chromium.org
Date 2012-09-06 02:54:50 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127716 => 127717)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:52:27 UTC (rev 127716)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:54:50 UTC (rev 127717)
@@ -1,3 +1,9 @@
+2012-09-06 Peter Beverloo
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-06 Dana Jansens
[chromium] Add a copy() method to CCRenderPass
Modified: trunk/Source/WebKit/chromium/DEPS (127716 => 127717)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-06 09:52:27 UTC (rev 127716)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-06 09:54:50 UTC (rev 127717)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '154695'
+ 'chromium_rev': '155144'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127718] trunk/Source/WebCore
Title: [127718] trunk/Source/WebCore Revision 127718 Author commit-qu...@webkit.org Date 2012-09-06 03:05:48 -0700 (Thu, 06 Sep 2012) Log Message Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive https://bugs.webkit.org/show_bug.cgi?id=95519 Patch by Elliott Sprehn on 2012-09-06 Reviewed by Adam Barth. Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive. This is useful for keeping callbacks attached to wrappers without keeping strong references to v8::Objects in the C++ side which can result in leaks when cycles are created. No new tests needed, this will be used to fix MutationObservers which will have tests. * WebCore.gypi: * bindings/v8/V8DependentRetained.h: Added. (WebCore): (V8DependentRetained): (WebCore::V8DependentRetained::V8DependentRetained): (WebCore::V8DependentRetained::~V8DependentRetained): (WebCore::V8DependentRetained::get): Gets the v8::Object value. (WebCore::V8DependentRetained::isEmpty): Checks if the value is still alive. (WebCore::V8DependentRetained::createPropertyName): (WebCore::V8DependentRetained::ownerWeakCallback): Clear the value when the owner is released. (WebCore::V8DependentRetained::valueWeakCallback): (WebCore::V8DependentRetained::release): * bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::hiddenReferenceName): Modified to allow creating hidden String or Symbol names. * bindings/v8/V8HiddenPropertyName.h: (V8HiddenPropertyName): * bindings/v8/V8PerIsolateData.cpp: (WebCore::V8PerIsolateData::V8PerIsolateData): * bindings/v8/V8PerIsolateData.h: (WebCore::V8PerIsolateData::nextDependentRetainedId): Returns the next available hidden property index. (V8PerIsolateData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h trunk/Source/WebCore/bindings/v8/V8PerIsolateData.cpp trunk/Source/WebCore/bindings/v8/V8PerIsolateData.h Added Paths trunk/Source/WebCore/bindings/v8/V8DependentRetained.h Diff Modified: trunk/Source/WebCore/ChangeLog (127717 => 127718) --- trunk/Source/WebCore/ChangeLog 2012-09-06 09:54:50 UTC (rev 127717) +++ trunk/Source/WebCore/ChangeLog 2012-09-06 10:05:48 UTC (rev 127718) @@ -1,3 +1,39 @@ +2012-09-06 Elliott Sprehn + +Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive +https://bugs.webkit.org/show_bug.cgi?id=95519 + +Reviewed by Adam Barth. + +Add new V8DependentRetained that allows keeping a v8::Object alive as long as another +v8::Object is alive. This is useful for keeping callbacks attached to wrappers without +keeping strong references to v8::Objects in the C++ side which can result in leaks +when cycles are created. + +No new tests needed, this will be used to fix MutationObservers which will have tests. + +* WebCore.gypi: +* bindings/v8/V8DependentRetained.h: Added. +(WebCore): +(V8DependentRetained): +(WebCore::V8DependentRetained::V8DependentRetained): +(WebCore::V8DependentRetained::~V8DependentRetained): +(WebCore::V8DependentRetained::get): Gets the v8::Object value. +(WebCore::V8DependentRetained::isEmpty): Checks if the value is still alive. +(WebCore::V8DependentRetained::createPropertyName): +(WebCore::V8DependentRetained::ownerWeakCallback): Clear the value when the owner is released. +(WebCore::V8DependentRetained::valueWeakCallback): +(WebCore::V8DependentRetained::release): +* bindings/v8/V8HiddenPropertyName.cpp: +(WebCore::V8HiddenPropertyName::hiddenReferenceName): Modified to allow creating hidden String or Symbol names. +* bindings/v8/V8HiddenPropertyName.h: +(V8HiddenPropertyName): +* bindings/v8/V8PerIsolateData.cpp: +(WebCore::V8PerIsolateData::V8PerIsolateData): +* bindings/v8/V8PerIsolateData.h: +(WebCore::V8PerIsolateData::nextDependentRetainedId): Returns the next available hidden property index. +(V8PerIsolateData): + 2012-09-06 Otto Derek Cheung [BlackBerry] Removing String operator += uses in Cookie Files Modified: trunk/Source/WebCore/WebCore.gypi (127717 => 127718) --- trunk/Source/WebCore/WebCore.gypi 2012-09-06 09:54:50 UTC (rev 127717) +++ trunk/Source/WebCore/WebCore.gypi 2012-09-06 10:05:48 UTC (rev 127718) @@ -2280,6 +2280,7 @@ 'bindings/v8/V8Callback.h', 'bindings/v8/V8Collection.cpp', 'bindings/v8/V8Collection.h', +'bindings/v8/V8DependentRetained.h', 'bindings/v8/V8DOMConfiguration.cpp', 'bindings/v8/V8DOMConfiguration.h', 'bindings/v8/V8DOMMap.cpp', Added: trunk/Source/WebCore/bindings/v8/V8DependentRetained.h (0 =>
[webkit-changes] [127719] trunk/Source/JavaScriptCore
Title: [127719] trunk/Source/_javascript_Core
Revision 127719
Author commit-qu...@webkit.org
Date 2012-09-06 03:13:14 -0700 (Thu, 06 Sep 2012)
Log Message
Renamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in
which inadvertantly allows the ASM llint to use the baseline JIT when
useRegExpJIT() is true.
https://bugs.webkit.org/show_bug.cgi?id=95918.
Patch by Mark Lam on 2012-09-06
Reviewed by Geoffrey Garen.
* runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):
(JSGlobalData):
* runtime/Options.cpp:
(JSC::Options::initialize):
* runtime/Options.h:
(JSC):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/Options.cpp
trunk/Source/_javascript_Core/runtime/Options.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127718 => 127719)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-06 10:05:48 UTC (rev 127718)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-06 10:13:14 UTC (rev 127719)
@@ -1,3 +1,24 @@
+2012-09-06 Mark Lam
+
+Renamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in
+which inadvertantly allows the ASM llint to use the baseline JIT when
+useRegExpJIT() is true.
+https://bugs.webkit.org/show_bug.cgi?id=95918.
+
+Reviewed by Geoffrey Garen.
+
+* runtime/JSGlobalData.cpp:
+(JSC::enableAssembler):
+(JSC::JSGlobalData::JSGlobalData):
+* runtime/JSGlobalData.h:
+(JSC::JSGlobalData::canUseJIT):
+(JSC::JSGlobalData::canUseRegExpJIT):
+(JSGlobalData):
+* runtime/Options.cpp:
+(JSC::Options::initialize):
+* runtime/Options.h:
+(JSC):
+
2012-09-06 Patrick Gansterer
Build fix for Interpreter after r127698.
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp (127718 => 127719)
--- trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp 2012-09-06 10:05:48 UTC (rev 127718)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp 2012-09-06 10:13:14 UTC (rev 127719)
@@ -100,7 +100,7 @@
#if ENABLE(ASSEMBLER) && (ENABLE(CLASSIC_INTERPRETER) || ENABLE(LLINT))
static bool enableAssembler(ExecutableAllocator& executableAllocator)
{
-if (!executableAllocator.isValid() || (!Options::useJIT() && !Options::useYarrJIT()))
+if (!executableAllocator.isValid() || (!Options::useJIT() && !Options::useRegExpJIT()))
return false;
#if USE(CF)
@@ -182,6 +182,8 @@
, m_newStringsSinceLastHashConst(0)
#if ENABLE(ASSEMBLER) && (ENABLE(CLASSIC_INTERPRETER) || ENABLE(LLINT))
, m_canUseAssembler(enableAssembler(executableAllocator))
+, m_canUseJIT(m_canUseAssembler && Options::useJIT())
+, m_canUseRegExpJIT(m_canUseAssembler && Options::useRegExpJIT())
#endif
#if ENABLE(GC_VALIDATION)
, m_initializingObjectClass(0)
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.h (127718 => 127719)
--- trunk/Source/_javascript_Core/runtime/JSGlobalData.h 2012-09-06 10:05:48 UTC (rev 127718)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.h 2012-09-06 10:13:14 UTC (rev 127719)
@@ -284,7 +284,7 @@
#elif !ENABLE(CLASSIC_INTERPRETER) && !ENABLE(LLINT)
bool canUseJIT() { return true; } // jit only
#else
-bool canUseJIT() { return m_canUseAssembler; }
+bool canUseJIT() { return m_canUseJIT; }
#endif
#if !ENABLE(YARR_JIT)
@@ -292,7 +292,7 @@
#elif !ENABLE(CLASSIC_INTERPRETER) && !ENABLE(LLINT)
bool canUseRegExpJIT() { return true; } // jit only
#else
-bool canUseRegExpJIT() { return m_canUseAssembler; }
+bool canUseRegExpJIT() { return m_canUseRegExpJIT; }
#endif
PrivateName m_inheritorIDKey;
@@ -441,6 +441,8 @@
void createNativeThunk();
#if ENABLE(ASSEMBLER) && (ENABLE(CLASSIC_INTERPRETER) || ENABLE(LLINT))
bool m_canUseAssembler;
+bool m_canUseJIT;
+bool m_canUseRegExpJIT;
#endif
#if ENABLE(GC_VALIDATION)
const ClassInfo* m_initializingObjectClass;
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (127718 => 127719)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2012-09-06 10:05:48 UTC (rev 127718)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2012-09-06 10:13:14 UTC (rev 127719)
@@ -143,7 +143,7 @@
useDFGJIT() = false;
#endif
#if !ENABLE(YARR_JIT)
-useYarrJIT() = false;
+useRegExpJIT() = false;
#endif
// Do range checks where needed and make corrections to the options:
Modified: trunk/Source/_javascript_Core/runtime/Options.h (127718 => 127719)
--- trunk/Source/_javascript_Core/runtime/Options.h 2012-09-06 10:05:48 UTC (rev 127718)
+++ trunk/Source/_javascript_Core/runtime/Options.h 2012-09-06 10:13:14 UTC (rev 127719)
@
[webkit-changes] [127721] trunk/Source/WebKit/chromium
Title: [127721] trunk/Source/WebKit/chromium Revision 127721 Author ba...@chromium.org Date 2012-09-06 03:40:26 -0700 (Thu, 06 Sep 2012) Log Message [Chromium] Win build fix attempt after r127715 * tests/CCRenderPassTest.cpp: (WebCore::TEST): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/CCRenderPassTest.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (127720 => 127721) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 10:36:37 UTC (rev 127720) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 10:40:26 UTC (rev 127721) @@ -1,3 +1,10 @@ +2012-09-06 Kenichi Ishibashi + +[Chromium] Win build fix attempt after r127715 + +* tests/CCRenderPassTest.cpp: +(WebCore::TEST): + 2012-09-06 Peter Beverloo Unreviewed. Rolled DEPS. Modified: trunk/Source/WebKit/chromium/tests/CCRenderPassTest.cpp (127720 => 127721) --- trunk/Source/WebKit/chromium/tests/CCRenderPassTest.cpp 2012-09-06 10:36:37 UTC (rev 127720) +++ trunk/Source/WebKit/chromium/tests/CCRenderPassTest.cpp 2012-09-06 10:40:26 UTC (rev 127721) @@ -74,8 +74,8 @@ WebFilterOperations filters; WebFilterOperations backgroundFilters; -filters.append(WebFilterOperation::createGrayscaleFilter(0.2)); -backgroundFilters.append(WebFilterOperation::createInvertFilter(0.2)); +filters.append(WebFilterOperation::createGrayscaleFilter(0.2f)); +backgroundFilters.append(WebFilterOperation::createInvertFilter(0.2f)); pass->setDamageRect(damageRect); pass->setHasTransparentBackground(hasTransparentBackground); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127722] trunk/LayoutTests
Title: [127722] trunk/LayoutTests Revision 127722 Author dominik.rottsc...@intel.com Date 2012-09-06 03:47:18 -0700 (Thu, 06 Sep 2012) Log Message [EFL] Gardening after r127620, r127698 and r127704 https://bugs.webkit.org/show_bug.cgi?id=95963 Unreviewed gardening. Following tests were added to TestExpectations: compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620. fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698. fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704. fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704. Patch by Mikhail Pozdnyakov on 2012-09-06 * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127721 => 127722) --- trunk/LayoutTests/ChangeLog 2012-09-06 10:40:26 UTC (rev 127721) +++ trunk/LayoutTests/ChangeLog 2012-09-06 10:47:18 UTC (rev 127722) @@ -1,3 +1,18 @@ +2012-09-06 Mikhail Pozdnyakov + +[EFL] Gardening after r127620, r127698 and r127704 +https://bugs.webkit.org/show_bug.cgi?id=95963 + +Unreviewed gardening. + +Following tests were added to TestExpectations: +compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620. +fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698. +fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704. +fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704. + +* platform/efl/TestExpectations: + 2012-09-06 Adam Barth Three XSLTProcessor functions don't need to be [Custom] Modified: trunk/LayoutTests/platform/efl/TestExpectations (127721 => 127722) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-06 10:40:26 UTC (rev 127721) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-06 10:47:18 UTC (rev 127722) @@ -468,6 +468,7 @@ BUGWK82294 : compositing/overflow/content-loses-scrollbars.html = TEXT BUGWK82294 SKIP : compositing/overflow/nested-scrolling.html = MISSING BUGWK82294 : compositing/overflow/overflow-auto-with-touch.html = TEXT +BUGWK82294 : compositing/overflow/overflow-auto-with-touch-toggle.html = TEXT BUGWK82294 SKIP : compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html = MISSING BUGWK82294 : compositing/overflow/overflow-overlay-with-touch.html = TEXT BUGWK82294 : compositing/overflow/overflow-scrollbar-layers.html = TEXT @@ -1099,3 +1100,10 @@ BUGWK95840 : http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html = TEXT BUGWK95840 : http/tests/security/cross-origin-plugin-private-browsing-toggled.html = TEXT BUGWK95840 : http/tests/security/cross-origin-plugin.html = TEXT + +// Fails after r127698. +BUGWK95944 : fast/dom/HTMLScriptElement/script-reexecution.html = TEXT + +// Fail after r127704. +BUGWK95952 : fast/viewport/viewport-limits-adjusted-for-no-user-scale.html = TEXT +BUGWK95952 : fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127723] trunk/Source/WebCore
Title: [127723] trunk/Source/WebCore
Revision 127723
Author commit-qu...@webkit.org
Date 2012-09-06 03:47:42 -0700 (Thu, 06 Sep 2012)
Log Message
[EFL] Keep placeholder text visible until first input from user.
https://bugs.webkit.org/show_bug.cgi?id=95851
Patch by Kangil Han on 2012-09-06
Reviewed by Gyuyoung Kim.
Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Therefore, this patch enabled it.
* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127722 => 127723)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 10:47:18 UTC (rev 127722)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 10:47:42 UTC (rev 127723)
@@ -1,3 +1,16 @@
+2012-09-06 Kangil Han
+
+[EFL] Keep placeholder text visible until first input from user.
+https://bugs.webkit.org/show_bug.cgi?id=95851
+
+Reviewed by Gyuyoung Kim.
+
+Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
+Therefore, this patch enabled it.
+
+* platform/efl/RenderThemeEfl.h:
+(WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):
+
2012-09-06 Elliott Sprehn
Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.h (127722 => 127723)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.h 2012-09-06 10:47:18 UTC (rev 127722)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.h 2012-09-06 10:47:42 UTC (rev 127723)
@@ -205,6 +205,7 @@
virtual bool paintMediaVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaCurrentTime(RenderObject*, const PaintInfo&, const IntRect&);
#endif
+virtual bool shouldShowPlaceholderWhenFocused() const OVERRIDE { return true; }
void setThemePath(const String&);
String themePath() { return m_themePath; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127724] trunk
Title: [127724] trunk
Revision 127724
Author hausm...@webkit.org
Date 2012-09-06 03:55:43 -0700 (Thu, 06 Sep 2012)
Log Message
[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
https://bugs.webkit.org/show_bug.cgi?id=95965
Reviewed by Tor Arne Vestbø.
.:
Add ANGLE as separate static library to the build and dependencies.
* Source/api.pri:
* WebKit.pro:
Source/ThirdParty/ANGLE:
Add build rules to build ANGLE as a static library for the Qt port.
* ANGLE.pri: Added.
* ANGLE.pro: Added.
* DerivedSources.pri: Added.
* Target.pri: Added.
Source/WebCore:
Moved all ANGLE build rules from here to Source/Thirty/ANGLE and
instead depend on the new library with a simple WEBKIT += ANGLE.
* DerivedSources.pri:
* Target.pri:
* platform/graphics/ANGLEWebKitBridge.h: Simplify the include statement
for the internal shader compiler API, aligned with the other platforms.
Source/WebKit:
Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).
* WebKit1.pro:
Source/WebKit2:
Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).
* Target.pri:
Tools:
Add ANGLE as a static library module to the Qt WebKit build system.
* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/modules/angle.prf: Added.
Modified Paths
trunk/ChangeLog
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit1.pro
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
trunk/WebKit.pro
Added Paths
trunk/Source/ThirdParty/ANGLE/ANGLE.pri
trunk/Source/ThirdParty/ANGLE/ANGLE.pro
trunk/Source/ThirdParty/ANGLE/DerivedSources.pri
trunk/Source/ThirdParty/ANGLE/Target.pri
trunk/Tools/qmake/mkspecs/modules/angle.prf
Diff
Modified: trunk/ChangeLog (127723 => 127724)
--- trunk/ChangeLog 2012-09-06 10:47:42 UTC (rev 127723)
+++ trunk/ChangeLog 2012-09-06 10:55:43 UTC (rev 127724)
@@ -1,3 +1,15 @@
+2012-09-06 Simon Hausmann
+
+[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
+https://bugs.webkit.org/show_bug.cgi?id=95965
+
+Reviewed by Tor Arne Vestbø.
+
+Add ANGLE as separate static library to the build and dependencies.
+
+* Source/api.pri:
+* WebKit.pro:
+
2012-09-05 George Staikos
[BlackBerry] Match th ebuild flags from the platform library
Added: trunk/Source/ThirdParty/ANGLE/ANGLE.pri (0 => 127724)
--- trunk/Source/ThirdParty/ANGLE/ANGLE.pri (rev 0)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.pri 2012-09-06 10:55:43 UTC (rev 127724)
@@ -0,0 +1,12 @@
+# ---
+# This file contains shared rules used both when building ANGLE
+# itself, and by targets that use ANGLE.
+#
+# See 'Tools/qmake/README' for an overview of the build system
+# ---
+
+SOURCE_DIR = $${ROOT_WEBKIT_DIR}/Source/ThirdParty/ANGLE
+
+INCLUDEPATH += \
+$$SOURCE_DIR/include/GLSLANG
+
Added: trunk/Source/ThirdParty/ANGLE/ANGLE.pro (0 => 127724)
--- trunk/Source/ThirdParty/ANGLE/ANGLE.pro (rev 0)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.pro 2012-09-06 10:55:43 UTC (rev 127724)
@@ -0,0 +1,14 @@
+# ---
+# Main project file for ANGLE
+#
+# See 'Tools/qmake/README' for an overview of the build system
+# ---
+
+TEMPLATE = subdirs
+
+derived_sources.file = DerivedSources.pri
+target.file = Target.pri
+
+SUBDIRS += derived_sources target
+
+addStrictSubdirOrderBetween(derived_sources, target)
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (127723 => 127724)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-09-06 10:47:42 UTC (rev 127723)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-09-06 10:55:43 UTC (rev 127724)
@@ -1,3 +1,17 @@
+2012-09-06 Simon Hausmann
+
+[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
+https://bugs.webkit.org/show_bug.cgi?id=95965
+
+Reviewed by Tor Arne Vestbø.
+
+Add build rules to build ANGLE as a static library for the Qt port.
+
+* ANGLE.pri: Added.
+* ANGLE.pro: Added.
+* DerivedSources.pri: Added.
+* Target.pri: Added.
+
2012-08-24 Joshua Netterfield
[CSS Shaders] [ANGLE] RenameFunction::RenameFunction may store references to temporary string
Added: trunk/Source/ThirdParty/ANGLE/DerivedSources.pri (0 => 127724)
--- trunk/Source/ThirdParty/ANGLE/DerivedSources.pri (rev 0)
+++ trunk/Sourc
[webkit-changes] [127725] trunk/Source/WebKit2/Target.pri
Title: [127725] trunk/Source/WebKit2/Target.pri
Revision 127725
Author hausm...@webkit.org
Date 2012-09-06 03:59:50 -0700 (Thu, 06 Sep 2012)
Log Message
Small typo I forgot to land as part of r127724
Modified Paths
trunk/Source/WebKit2/Target.pri
Diff
Modified: trunk/Source/WebKit2/Target.pri (127724 => 127725)
--- trunk/Source/WebKit2/Target.pri 2012-09-06 10:55:43 UTC (rev 127724)
+++ trunk/Source/WebKit2/Target.pri 2012-09-06 10:59:50 UTC (rev 127725)
@@ -889,7 +889,7 @@
contains(DEFINES, ENABLE_GEOLOCATION=1): QT += location
-contains(DEFINES, WTF_USE_3D_GRAPHICS=1): WEBKIT += ANGLE
+contains(DEFINES, WTF_USE_3D_GRAPHICS=1): WEBKIT += angle
plugin_backend_xlib {
DEFINES += XP_UNIX
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127726] trunk
Title: [127726] trunk Revision 127726 Author hausm...@webkit.org Date 2012-09-06 04:02:11 -0700 (Thu, 06 Sep 2012) Log Message [Qt] Various small Windows / MSVC build fixes https://bugs.webkit.org/show_bug.cgi?id=95934 Reviewed by Kenneth Rohde Christiansen. Source/WebKit2: * Shared/LayerTreeContext.h: Include stdint.h due to the use of uint32_t as layer id. * UIProcess/API/qt/qquickwebview_p.h: (WebKit): Fix struct vs. class forward declaration mismatch, causing linking errors. * UIProcess/API/qt/tests/bytearraytestdata.h: Remove export macro from internal test class that is not used anymore. Using the export macro from a DLL when the code in question is not part of the DLL results in the export macro expanding to dllimport, giving incorrect linkage for the unit test. * WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt): Removed explicit call to srandom(), which is not available on Windows. The call appears to be unnecessary in the light of the WTF::initializeThreading() call below, which in turn calls WTF::initializeRandomNumberGenerator(), which does the same thing already (and isn't needed on Windows, as per comment in wtf/RandomNumberSeed.h) Source/WTF: For the Qt build on Windows, do not enable WTF_USE_UNIX_DOMAIN_SOCKETS for WebKit2 IPC. * wtf/Platform.h: Tools: setFocus takes a boolean as argument: Don't try to implicitly convert an enum to a boolean, MSVC doesn't like that. The intent here is to enable focus, so just pass true. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::focus): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/LayerTreeContext.h trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h trunk/Source/WebKit2/UIProcess/API/qt/tests/bytearraytestdata.h trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp Diff Modified: trunk/Source/WTF/ChangeLog (127725 => 127726) --- trunk/Source/WTF/ChangeLog 2012-09-06 10:59:50 UTC (rev 127725) +++ trunk/Source/WTF/ChangeLog 2012-09-06 11:02:11 UTC (rev 127726) @@ -1,3 +1,15 @@ +2012-09-06 Simon Hausmann + +[Qt] Various small Windows / MSVC build fixes +https://bugs.webkit.org/show_bug.cgi?id=95934 + +Reviewed by Kenneth Rohde Christiansen. + +For the Qt build on Windows, do not enable WTF_USE_UNIX_DOMAIN_SOCKETS for +WebKit2 IPC. + +* wtf/Platform.h: + 2012-09-06 Adam Barth Remove WTF::String::operator+= Modified: trunk/Source/WTF/wtf/Platform.h (127725 => 127726) --- trunk/Source/WTF/wtf/Platform.h 2012-09-06 10:59:50 UTC (rev 127725) +++ trunk/Source/WTF/wtf/Platform.h 2012-09-06 11:02:11 UTC (rev 127726) @@ -1123,7 +1123,7 @@ #define WTF_USE_EXPORT_MACROS_FOR_TESTING 1 #endif -#if (PLATFORM(QT) && !OS(DARWIN)) || PLATFORM(GTK) || PLATFORM(EFL) +#if (PLATFORM(QT) && !OS(DARWIN) && !OS(WINDOWS)) || PLATFORM(GTK) || PLATFORM(EFL) #define WTF_USE_UNIX_DOMAIN_SOCKETS 1 #endif Modified: trunk/Source/WebKit2/ChangeLog (127725 => 127726) --- trunk/Source/WebKit2/ChangeLog 2012-09-06 10:59:50 UTC (rev 127725) +++ trunk/Source/WebKit2/ChangeLog 2012-09-06 11:02:11 UTC (rev 127726) @@ -1,5 +1,25 @@ 2012-09-06 Simon Hausmann +[Qt] Various small Windows / MSVC build fixes +https://bugs.webkit.org/show_bug.cgi?id=95934 + +Reviewed by Kenneth Rohde Christiansen. + +* Shared/LayerTreeContext.h: Include stdint.h due to the use of uint32_t as layer id. +* UIProcess/API/qt/qquickwebview_p.h: +(WebKit): Fix struct vs. class forward declaration mismatch, causing linking errors. +* UIProcess/API/qt/tests/bytearraytestdata.h: Remove export macro from internal test class +that is not used anymore. Using the export macro from a DLL when the code in question is not +part of the DLL results in the export macro expanding to dllimport, giving incorrect linkage +for the unit test. +* WebProcess/qt/WebProcessMainQt.cpp: +(WebKit::WebProcessMainQt): Removed explicit call to srandom(), which is not available on Windows. +The call appears to be unnecessary in the light of the WTF::initializeThreading() call below, which +in turn calls WTF::initializeRandomNumberGenerator(), which does the same thing already (and isn't +needed on Windows, as per comment in wtf/RandomNumberSeed.h) + +2012-09-06 Simon Hausmann + [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2 https://bugs.webkit.org/show_bug.cgi?id=95965 Modified: trunk/Source/WebKit2/Shared/LayerTreeContext.h (127725 => 127726) --- trunk/Source/WebKit2/Shared/LayerTreeContext.h 2012-09-06 10:59:50 UTC (rev 127725) +++ trunk/Source/WebKit2/Shared/LayerTreeContext.h 2012-09-06 11:02:11 UTC (rev 127726) @@ -26,6 +26,8 @@ #ifndef LayerTreeContext_h #define LayerTreeCont
[webkit-changes] [127727] trunk
Title: [127727] trunk Revision 127727 Author kei...@webkit.org Date 2012-09-06 04:05:27 -0700 (Thu, 06 Sep 2012) Log Message Refactor CalendarPicker to not use global variables. https://bugs.webkit.org/show_bug.cgi?id=95830 Reviewed by Kent Tamura. Source/WebCore: Introduce CalendarPicker so we can have multiple Pickers in one page popup in the future. No new tests. No behavior change. * Resources/pagepopups/calendarPicker.js: (initialize): (resetMain): (openCalendarPicker): (CalendarPicker): (CalendarPicker.prototype._layout): (CalendarPicker.prototype.handleToday): (CalendarPicker.prototype.handleClear): (CalendarPicker.prototype.fixWindowSize): (CalendarPicker.prototype._layoutButtons): (YearMonthController): (YearMonthController.prototype.attachTo): (YearMonthController.prototype._redraw): (YearMonthController.prototype._handleYearMonthChange): (YearMonthController.prototype.moveRelatively): (DaysTable): (DaysTable.prototype.attachTo): (CalendarPicker.prototype.stepMismatch): (CalendarPicker.prototype.outOfRange): (CalendarPicker.prototype.isValidDate): (DaysTable.prototype._renderMonth): (DaysTable.prototype._navigateToMonth): (DaysTable.prototype._maybeSetPreviousMonth): (DaysTable.prototype._maybeSetNextMonth): (DaysTable.prototype._handleDayClick): (DaysTable.prototype._handleKey): (CalendarPicker.prototype._handleBodyKeyDown): * Resources/pagepopups/colorSuggestionPicker.js: (ColorPicker): (ColorPicker.prototype._layout): (ColorPicker.prototype._handleKeyDown): (ColorPicker.prototype._handleSwatchClick): * Resources/pagepopups/pickerCommon.js: (Picker): (Picker.prototype.submitValue): (Picker.prototype.handleCancel): (Picker.prototype.chooseOtherColor): LayoutTests: * fast/forms/date/calendar-picker-appearance-pre-100.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/date/calendar-picker-appearance-pre-100.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js trunk/Source/WebCore/Resources/pagepopups/colorSuggestionPicker.js trunk/Source/WebCore/Resources/pagepopups/pickerCommon.js Diff Modified: trunk/LayoutTests/ChangeLog (127726 => 127727) --- trunk/LayoutTests/ChangeLog 2012-09-06 11:02:11 UTC (rev 127726) +++ trunk/LayoutTests/ChangeLog 2012-09-06 11:05:27 UTC (rev 127727) @@ -1,3 +1,12 @@ +2012-09-06 Keishi Hattori + +Refactor CalendarPicker to not use global variables. +https://bugs.webkit.org/show_bug.cgi?id=95830 + +Reviewed by Kent Tamura. + +* fast/forms/date/calendar-picker-appearance-pre-100.html: + 2012-09-06 Mikhail Pozdnyakov [EFL] Gardening after r127620, r127698 and r127704 Modified: trunk/LayoutTests/fast/forms/date/calendar-picker-appearance-pre-100.html (127726 => 127727) --- trunk/LayoutTests/fast/forms/date/calendar-picker-appearance-pre-100.html 2012-09-06 11:02:11 UTC (rev 127726) +++ trunk/LayoutTests/fast/forms/date/calendar-picker-appearance-pre-100.html 2012-09-06 11:05:27 UTC (rev 127727) @@ -8,16 +8,17 @@
[webkit-changes] [127728] trunk/LayoutTests
Title: [127728] trunk/LayoutTests Revision 127728 Author o...@webkit.org Date 2012-09-06 04:22:36 -0700 (Thu, 06 Sep 2012) Log Message [Qt] Unreviewed gardening, skip one more failing test, because we like regressions in the trunk. :) * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127727 => 127728) --- trunk/LayoutTests/ChangeLog 2012-09-06 11:05:27 UTC (rev 127727) +++ trunk/LayoutTests/ChangeLog 2012-09-06 11:22:36 UTC (rev 127728) @@ -1,3 +1,10 @@ +2012-09-06 Csaba Osztrogonác + +[Qt] Unreviewed gardening, skip one more failing test, +because we like regressions in the trunk. :) + +* platform/qt/Skipped: + 2012-09-06 Keishi Hattori Refactor CalendarPicker to not use global variables. Modified: trunk/LayoutTests/platform/qt/Skipped (127727 => 127728) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-06 11:05:27 UTC (rev 127727) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-06 11:22:36 UTC (rev 127728) @@ -2802,3 +2802,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=95952 fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fast/viewport/viewport-limits-adjusted-for-no-user-scale.html + +# REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms +# https://bugs.webkit.org/show_bug.cgi?id=95972 +http/tests/xmlhttprequest/basic-auth.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127729] trunk/Tools
Title: [127729] trunk/Tools
Revision 127729
Author commit-qu...@webkit.org
Date 2012-09-06 04:44:12 -0700 (Thu, 06 Sep 2012)
Log Message
[EFL] Sanitize URLs in EWebLauncher / Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95849
Patch by Christophe Dumez on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.
Sanitize URLs passed by the user as program
argument or typed in the URL bar in order to
be more tolerant.
* EWebLauncher/CMakeLists.txt:
* EWebLauncher/main.c:
(main):
* EWebLauncher/url_bar.c:
(_url_bar_url_get_with_protocol):
(on_urlbar_key_down):
* EWebLauncher/url_utils.c: Added.
(has_scheme):
(url_from_user_input): Add utility function to construct a
URL from user input.
* EWebLauncher/url_utils.h: Added.
* MiniBrowser/efl/CMakeLists.txt:
* MiniBrowser/efl/main.c:
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/EWebLauncher/CMakeLists.txt
trunk/Tools/EWebLauncher/main.c
trunk/Tools/EWebLauncher/url_bar.c
trunk/Tools/MiniBrowser/efl/CMakeLists.txt
trunk/Tools/MiniBrowser/efl/main.c
Added Paths
trunk/Tools/EWebLauncher/url_utils.c
trunk/Tools/EWebLauncher/url_utils.h
Diff
Modified: trunk/Tools/ChangeLog (127728 => 127729)
--- trunk/Tools/ChangeLog 2012-09-06 11:22:36 UTC (rev 127728)
+++ trunk/Tools/ChangeLog 2012-09-06 11:44:12 UTC (rev 127729)
@@ -1,3 +1,29 @@
+2012-09-06 Christophe Dumez
+
+[EFL] Sanitize URLs in EWebLauncher / Minibrowser
+https://bugs.webkit.org/show_bug.cgi?id=95849
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Sanitize URLs passed by the user as program
+argument or typed in the URL bar in order to
+be more tolerant.
+
+* EWebLauncher/CMakeLists.txt:
+* EWebLauncher/main.c:
+(main):
+* EWebLauncher/url_bar.c:
+(_url_bar_url_get_with_protocol):
+(on_urlbar_key_down):
+* EWebLauncher/url_utils.c: Added.
+(has_scheme):
+(url_from_user_input): Add utility function to construct a
+URL from user input.
+* EWebLauncher/url_utils.h: Added.
+* MiniBrowser/efl/CMakeLists.txt:
+* MiniBrowser/efl/main.c:
+(main):
+
2012-09-06 Simon Hausmann
[Qt] Various small Windows / MSVC build fixes
Modified: trunk/Tools/EWebLauncher/CMakeLists.txt (127728 => 127729)
--- trunk/Tools/EWebLauncher/CMakeLists.txt 2012-09-06 11:22:36 UTC (rev 127728)
+++ trunk/Tools/EWebLauncher/CMakeLists.txt 2012-09-06 11:44:12 UTC (rev 127729)
@@ -1,5 +1,6 @@
SET(EWebLauncher_SOURCES
${TOOLS_DIR}/EWebLauncher/url_bar.c
+${TOOLS_DIR}/EWebLauncher/url_utils.c
${TOOLS_DIR}/EWebLauncher/main.c
)
Modified: trunk/Tools/EWebLauncher/main.c (127728 => 127729)
--- trunk/Tools/EWebLauncher/main.c 2012-09-06 11:22:36 UTC (rev 127728)
+++ trunk/Tools/EWebLauncher/main.c 2012-09-06 11:44:12 UTC (rev 127729)
@@ -31,6 +31,7 @@
#include "EWebKit.h"
#include "url_bar.h"
+#include "url_utils.h"
#include
#include
#include
@@ -814,7 +815,6 @@
const char *default_url = "http://www.google.com/";
Eina_Rectangle geometry = {0, 0, 0, 0};
-char *url = ""
char *userAgent = NULL;
const char *tmp;
const char *proxyUri;
@@ -869,11 +869,6 @@
if (quitOption)
return quit(EINA_TRUE, NULL);
-if (args < argc)
-url = ""
-else
-url = "" default_url;
-
themePath = findThemePath(theme);
if (!themePath)
return quit(EINA_FALSE, "ERROR: could not find theme.\n");
@@ -893,7 +888,13 @@
if (proxyUri)
ewk_network_proxy_uri_set(proxyUri);
-browserCreate(url, themePath, userAgent, geometry, engine, backingStore, isFlattening, isFullscreen, path);
+if (args < argc) {
+char *url = ""
+browserCreate(url, themePath, userAgent, geometry, engine, backingStore, isFlattening, isFullscreen, path);
+free(url);
+} else
+browserCreate(default_url, themePath, userAgent, geometry, engine, backingStore, isFlattening, isFullscreen, path);
+
ecore_event_handler_add(ECORE_EVENT_SIGNAL_EXIT, main_signal_exit, &windows);
ecore_main_loop_begin();
Modified: trunk/Tools/EWebLauncher/url_bar.c (127728 => 127729)
--- trunk/Tools/EWebLauncher/url_bar.c 2012-09-06 11:22:36 UTC (rev 127728)
+++ trunk/Tools/EWebLauncher/url_bar.c 2012-09-06 11:44:12 UTC (rev 127729)
@@ -24,23 +24,19 @@
*/
#include "url_bar.h"
+#include "url_utils.h"
#include
#include
-#include
#define PADDING_SIZE 5
-static const char *
+static char *
_url_bar_url_get_with_protocol(Url_Bar *urlBar)
{
const char *url = "" "url.text");
-if (ecore_file_exists(url))
-return eina_stringshare_printf("file://%s", url);
-if (!strstr(url, "://"))
-return eina_stringshare_printf("http://%s", url);
-return eina_stringshare_add(url);
+return url_from_user_input(url);
}
static void
@@ -52,10 +48,10 @@
if (!ev->key || strcmp(ev->key, "Return"))
return;
-c
[webkit-changes] [127730] trunk/LayoutTests
Title: [127730] trunk/LayoutTests Revision 127730 Author mikelawt...@chromium.org Date 2012-09-06 05:21:00 -0700 (Thu, 06 Sep 2012) Log Message Rewrite zooming test to no longer output pixel numbers https://bugs.webkit.org/show_bug.cgi?id=95922 Reviewed by Dan Bernstein. The original version of this test output pixel sizes, which had different results on different ports. The test has been rewritten to suppress the pixel size output. * css3/calc/zoom-with-em-expected.txt: * css3/calc/zoom-with-em.html: * platform/chromium/css3/calc/zoom-with-em-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt trunk/LayoutTests/css3/calc/zoom-with-em.html Removed Paths trunk/LayoutTests/platform/chromium/css3/calc/zoom-with-em-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127729 => 127730) --- trunk/LayoutTests/ChangeLog 2012-09-06 11:44:12 UTC (rev 127729) +++ trunk/LayoutTests/ChangeLog 2012-09-06 12:21:00 UTC (rev 127730) @@ -1,3 +1,17 @@ +2012-09-06 Mike Lawther + +Rewrite zooming test to no longer output pixel numbers +https://bugs.webkit.org/show_bug.cgi?id=95922 + +Reviewed by Dan Bernstein. + +The original version of this test output pixel sizes, which had different results on +different ports. The test has been rewritten to suppress the pixel size output. + +* css3/calc/zoom-with-em-expected.txt: +* css3/calc/zoom-with-em.html: +* platform/chromium/css3/calc/zoom-with-em-expected.txt: Removed. + 2012-09-06 Csaba Osztrogonác [Qt] Unreviewed gardening, skip one more failing test, Modified: trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt (127729 => 127730) --- trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt 2012-09-06 11:44:12 UTC (rev 127729) +++ trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt 2012-09-06 12:21:00 UTC (rev 127730) @@ -1,18 +1,8 @@ Tests that zooming a calc _expression_ containing 'em' units works correctly -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". +On success, you will see no "FAIL" messages, followed by "TEST COMPLETE". -PASS 308 is 308 -PASS 309 is 309 -PASS 310 is 310 -PASS 310 is 310 -PASS 310 is 310 -PASS 310 is 310 -PASS 310 is 310 -PASS 310 is 310 -PASS 310 is 310 -PASS 310 is 310 PASS successfullyParsed is true TEST COMPLETE Modified: trunk/LayoutTests/css3/calc/zoom-with-em.html (127729 => 127730) --- trunk/LayoutTests/css3/calc/zoom-with-em.html 2012-09-06 11:44:12 UTC (rev 127729) +++ trunk/LayoutTests/css3/calc/zoom-with-em.html 2012-09-06 12:21:00 UTC (rev 127730) @@ -8,7 +8,7 @@- description("Tests that zooming a calc _expression_ containing 'em' units works correctly");+ descriptionQuiet("Tests that zooming a calc _expression_ containing 'em' units works correctly"); zoomLevels = [0.67, 0.75, 0.9, 1, 1.1, 1.25, 1.5, 1.75, 2, 1]; calc = document.getElementById("calc"); nocalc = document.getElementById("nocalc"); @@ -16,7 +16,7 @@ var zoom = zoomLevels[z]; document.body.style.zoom = zoom;-shouldEvaluateTo(calc.offsetWidth + "", nocalc.offsetWidth + "");+shouldBe(calc.offsetWidth + "", nocalc.offsetWidth + "", true); }
[webkit-changes] [127731] trunk/Source/WebKit2
Title: [127731] trunk/Source/WebKit2
Revision 127731
Author commit-qu...@webkit.org
Date 2012-09-06 05:29:19 -0700 (Thu, 06 Sep 2012)
Log Message
[CMake] Add notifications path to the WebKit2/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=95843
Patch by Kihong Kwon on 2012-09-06
Reviewed by Laszlo Gombos.
Add WebCore/Modules/Notifications to the WebKit2_INCLUDE_DIRECTORIES of WebKit2/CMakeLists.txt.
There are some build errors when ENABLE_NOTIFICATIONS feature is enabled.
* CMakeLists.txt:
Modified Paths
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
Diff
Modified: trunk/Source/WebKit2/CMakeLists.txt (127730 => 127731)
--- trunk/Source/WebKit2/CMakeLists.txt 2012-09-06 12:21:00 UTC (rev 127730)
+++ trunk/Source/WebKit2/CMakeLists.txt 2012-09-06 12:29:19 UTC (rev 127731)
@@ -48,6 +48,7 @@
"${WEBCORE_DIR}/Modules/battery"
"${WEBCORE_DIR}/Modules/intents"
"${WEBCORE_DIR}/Modules/networkinfo"
+"${WEBCORE_DIR}/Modules/notifications"
"${WEBCORE_DIR}/Modules/vibration"
"${WEBCORE_DIR}/accessibility"
"${WEBCORE_DIR}/bindings/js"
Modified: trunk/Source/WebKit2/ChangeLog (127730 => 127731)
--- trunk/Source/WebKit2/ChangeLog 2012-09-06 12:21:00 UTC (rev 127730)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-06 12:29:19 UTC (rev 127731)
@@ -1,3 +1,15 @@
+2012-09-06 Kihong Kwon
+
+[CMake] Add notifications path to the WebKit2/CMakeLists.txt
+https://bugs.webkit.org/show_bug.cgi?id=95843
+
+Reviewed by Laszlo Gombos.
+
+Add WebCore/Modules/Notifications to the WebKit2_INCLUDE_DIRECTORIES of WebKit2/CMakeLists.txt.
+There are some build errors when ENABLE_NOTIFICATIONS feature is enabled.
+
+* CMakeLists.txt:
+
2012-09-06 Simon Hausmann
[Qt] Various small Windows / MSVC build fixes
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127732] trunk/Source
Title: [127732] trunk/Source
Revision 127732
Author par...@webkit.org
Date 2012-09-06 05:54:43 -0700 (Thu, 06 Sep 2012)
Log Message
Remove String::operator+=() from windows platform code
https://bugs.webkit.org/show_bug.cgi?id=95904
Reviewed by Benjamin Poulain.
Use StringBuilder and operator+() to concatenate strings instead of operator+=().
Source/WebCore:
* platform/win/ClipboardWin.cpp:
(WebCore::filesystemPathFromUrlOrTitle):
Source/WebKit/win:
* AccessibleBase.cpp:
(AccessibleBase::get_accKeyboardShortcut):
* WebDownload.cpp:
(WebDownload::bundlePathForTargetPath):
* WebView.cpp:
(imeCompositionArgumentNames):
Source/WebKit2:
* UIProcess/win/WebView.cpp:
(WebKit::imeCompositionArgumentNames):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/ClipboardWin.cpp
trunk/Source/WebKit/win/AccessibleBase.cpp
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebDownload.cpp
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/win/WebView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127731 => 127732)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 12:29:19 UTC (rev 127731)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 12:54:43 UTC (rev 127732)
@@ -1,3 +1,15 @@
+2012-09-06 Patrick Gansterer
+
+Remove String::operator+=() from windows platform code
+https://bugs.webkit.org/show_bug.cgi?id=95904
+
+Reviewed by Benjamin Poulain.
+
+Use StringBuilder and operator+() to concatenate strings instead of operator+=().
+
+* platform/win/ClipboardWin.cpp:
+(WebCore::filesystemPathFromUrlOrTitle):
+
2012-09-06 Keishi Hattori
Refactor CalendarPicker to not use global variables.
Modified: trunk/Source/WebCore/platform/win/ClipboardWin.cpp (127731 => 127732)
--- trunk/Source/WebCore/platform/win/ClipboardWin.cpp 2012-09-06 12:29:19 UTC (rev 127731)
+++ trunk/Source/WebCore/platform/win/ClipboardWin.cpp 2012-09-06 12:54:43 UTC (rev 127732)
@@ -147,9 +147,7 @@
return String(static_cast(fsPathBuffer));
}
-String result(static_cast(fsPathBuffer));
-result += String(extension);
-return result;
+return makeString(static_cast(fsPathBuffer), extension);
#endif
}
Modified: trunk/Source/WebKit/win/AccessibleBase.cpp (127731 => 127732)
--- trunk/Source/WebKit/win/AccessibleBase.cpp 2012-09-06 12:29:19 UTC (rev 127731)
+++ trunk/Source/WebKit/win/AccessibleBase.cpp 2012-09-06 12:54:43 UTC (rev 127732)
@@ -362,18 +362,20 @@
static String accessKeyModifiers;
if (accessKeyModifiers.isNull()) {
+StringBuilder accessKeyModifiersBuilder;
unsigned modifiers = EventHandler::accessKeyModifiers();
// Follow the same order as Mozilla MSAA implementation:
// Ctrl+Alt+Shift+Meta+key. MSDN states that keyboard shortcut strings
// should not be localized and defines the separator as "+".
if (modifiers & PlatformEvent::CtrlKey)
-accessKeyModifiers += "Ctrl+";
+accessKeyModifiersBuilder.appendLiteral("Ctrl+");
if (modifiers & PlatformEvent::AltKey)
-accessKeyModifiers += "Alt+";
+accessKeyModifiersBuilder.appendLiteral("Alt+");
if (modifiers & PlatformEvent::ShiftKey)
-accessKeyModifiers += "Shift+";
+accessKeyModifiersBuilder.appendLiteral("Shift+");
if (modifiers & PlatformEvent::MetaKey)
-accessKeyModifiers += "Win+";
+accessKeyModifiersBuilder.appendLiteral("Win+");
+accessKeyModifiers = accessKeyModifiersBuilder.toString();
}
*shortcut = BString(String(accessKeyModifiers + accessKey)).release();
return S_OK;
Modified: trunk/Source/WebKit/win/ChangeLog (127731 => 127732)
--- trunk/Source/WebKit/win/ChangeLog 2012-09-06 12:29:19 UTC (rev 127731)
+++ trunk/Source/WebKit/win/ChangeLog 2012-09-06 12:54:43 UTC (rev 127732)
@@ -1,3 +1,19 @@
+2012-09-06 Patrick Gansterer
+
+Remove String::operator+=() from windows platform code
+https://bugs.webkit.org/show_bug.cgi?id=95904
+
+Reviewed by Benjamin Poulain.
+
+Use StringBuilder and operator+() to concatenate strings instead of operator+=().
+
+* AccessibleBase.cpp:
+(AccessibleBase::get_accKeyboardShortcut):
+* WebDownload.cpp:
+(WebDownload::bundlePathForTargetPath):
+* WebView.cpp:
+(imeCompositionArgumentNames):
+
2012-09-05 Kaustubh Atrawalkar
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
Modified: trunk/Source/WebKit/win/WebDownload.cpp (127731 => 127732)
--- trunk/Source/WebKit/win/WebDownload.cpp 2012-09-06 12:29:19 UTC (rev 127731)
+++ trunk/Source/WebKit/win/WebDownload.cpp 2012-09-06 12:54:43 UTC (rev 127732)
@@ -148,7 +148,7 @@
if (bundle[bundle.length()-1] == '/')
bundle.truncate(1);
-bundle += DownloadBundle::fileExten
[webkit-changes] [127733] trunk
Title: [127733] trunk
Revision 127733
Author commit-qu...@webkit.org
Date 2012-09-06 06:05:38 -0700 (Thu, 06 Sep 2012)
Log Message
[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
https://bugs.webkit.org/show_bug.cgi?id=95943
Patch by Christophe Dumez on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
in EFL WK2.
* WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
LayoutTests:
Unskip several test cases that are passing now that EFL WK2
has a proper implementation for
WebPage::performDefaultBehaviorForKeyEvent().
* platform/efl-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (127732 => 127733)
--- trunk/LayoutTests/ChangeLog 2012-09-06 12:54:43 UTC (rev 127732)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 13:05:38 UTC (rev 127733)
@@ -1,3 +1,16 @@
+2012-09-06 Christophe Dumez
+
+[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
+https://bugs.webkit.org/show_bug.cgi?id=95943
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskip several test cases that are passing now that EFL WK2
+has a proper implementation for
+WebPage::performDefaultBehaviorForKeyEvent().
+
+* platform/efl-wk2/TestExpectations:
+
2012-09-06 Mike Lawther
Rewrite zooming test to no longer output pixel numbers
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (127732 => 127733)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 12:54:43 UTC (rev 127732)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 13:05:38 UTC (rev 127733)
@@ -222,13 +222,10 @@
BUGWKEFL : editing/execCommand/delete-selection-has-style.html = TEXT
BUGWKEFL : editing/execCommand/format-block-multiple-paragraphs-in-pre.html = TEXT
BUGWKEFL : editing/input/emacs-ctrl-o.html = TEXT
-BUGWKEFL : editing/input/page-up-down-scrolls.html = TEXT
BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT
BUGWKEFL : fast/css/bidi-override-in-anonymous-block.html = TEXT
BUGWKEFL : fast/css/relative-positioned-block-crash.html = TEXT
BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT
-BUGWKEFL : fast/events/node-event-anchor-lock.html = TEXT
-BUGWKEFL : fast/events/scroll-after-click-on-tab-index.html = TEXT
BUGWKEFL : fast/forms/autocomplete-off-with-default-value-does-not-clear.html = TEXT
BUGWKEFL : fast/forms/legend-access-key.html = TEXT
BUGWKEFL : fast/forms/listbox-deselect-scroll.html = TEXT
@@ -238,7 +235,6 @@
BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT
BUGWKEFL : fast/forms/validation-message-in-relative-body.html = TEXT
BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT
-BUGWKEFL : fast/repaint/fixed-move-after-keyboard-scroll.html = TEXT
BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT
BUGWKEFL : fast/replaced/no-focus-ring-object.html = TEXT
BUGWKEFL : fast/viewport/viewport-128.html = TEXT
Modified: trunk/Source/WebKit2/ChangeLog (127732 => 127733)
--- trunk/Source/WebKit2/ChangeLog 2012-09-06 12:54:43 UTC (rev 127732)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-06 13:05:38 UTC (rev 127733)
@@ -1,3 +1,16 @@
+2012-09-06 Christophe Dumez
+
+[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
+https://bugs.webkit.org/show_bug.cgi?id=95943
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
+in EFL WK2.
+
+* WebProcess/WebPage/efl/WebPageEfl.cpp:
+(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
+
2012-09-06 Patrick Gansterer
Remove String::operator+=() from windows platform code
Modified: trunk/Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp (127732 => 127733)
--- trunk/Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp 2012-09-06 12:54:43 UTC (rev 127732)
+++ trunk/Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp 2012-09-06 13:05:38 UTC (rev 127733)
@@ -62,8 +62,48 @@
bool WebPage::performDefaultBehaviorForKeyEvent(const WebKeyboardEvent& keyboardEvent)
{
-notImplemented();
-return false;
+if (keyboardEvent.type() != WebEvent::KeyDown && keyboardEvent.type() != WebEvent::RawKeyDown)
+return false;
+
+switch (keyboardEvent.windowsVirtualKeyCode()) {
+case VK_BACK:
+if (keyboardEvent.shiftKey())
+m_page->goForward();
+else
+m_page->goBack();
+break;
+case VK_SPACE:
+scroll(m_page.get(), keyboardEvent.shiftKey() ? ScrollUp : ScrollDown, ScrollByPage);
+break;
+case VK_LEFT:
+
[webkit-changes] [127734] trunk/Tools
Title: [127734] trunk/Tools Revision 127734 Author kbal...@webkit.org Date 2012-09-06 06:21:14 -0700 (Thu, 06 Sep 2012) Log Message [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver https://bugs.webkit.org/show_bug.cgi?id=95710 Reviewed by Dirk Pranke. The stdout / stderr output can be None so make sure we won't raise an exception in this case. * Scripts/webkitpy/layout_tests/port/driver.py: (Driver.run_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py Diff Modified: trunk/Tools/ChangeLog (127733 => 127734) --- trunk/Tools/ChangeLog 2012-09-06 13:05:38 UTC (rev 127733) +++ trunk/Tools/ChangeLog 2012-09-06 13:21:14 UTC (rev 127734) @@ -1,3 +1,16 @@ +2012-09-06 Balazs Kelemen + +[nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver +https://bugs.webkit.org/show_bug.cgi?id=95710 + +Reviewed by Dirk Pranke. + +The stdout / stderr output can be None so make sure +we won't raise an exception in this case. + +* Scripts/webkitpy/layout_tests/port/driver.py: +(Driver.run_test): + 2012-09-06 Christophe Dumez [EFL] Sanitize URLs in EWebLauncher / Minibrowser Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (127733 => 127734) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-09-06 13:05:38 UTC (rev 127733) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-09-06 13:21:14 UTC (rev 127734) @@ -169,8 +169,10 @@ # We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output. # In the timeout case, we kill the hung process as well. out, err = self._server_process.stop(self._port.driver_stop_timeout() if stop_when_done else 0.0) -text += out -self.error_from_test += err +if out: +text += out +if err: +self.error_from_test += err self._server_process = None crash_log = None ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127735] trunk/LayoutTests
Title: [127735] trunk/LayoutTests Revision 127735 Author commit-qu...@webkit.org Date 2012-09-06 06:23:37 -0700 (Thu, 06 Sep 2012) Log Message [EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html https://bugs.webkit.org/show_bug.cgi?id=95970 Unreviewed EFL gardening. Update WK2-EFL TestExpectations to add bug number for: fast/events/tab-focus-link-in-canvas.html Patch by Christophe Dumez on 2012-09-06 * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127734 => 127735) --- trunk/LayoutTests/ChangeLog 2012-09-06 13:21:14 UTC (rev 127734) +++ trunk/LayoutTests/ChangeLog 2012-09-06 13:23:37 UTC (rev 127735) @@ -1,5 +1,17 @@ 2012-09-06 Christophe Dumez +[EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html +https://bugs.webkit.org/show_bug.cgi?id=95970 + +Unreviewed EFL gardening. + +Update WK2-EFL TestExpectations to add bug number for: +fast/events/tab-focus-link-in-canvas.html + +* platform/efl-wk2/TestExpectations: + +2012-09-06 Christophe Dumez + [EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent() https://bugs.webkit.org/show_bug.cgi?id=95943 Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (127734 => 127735) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 13:21:14 UTC (rev 127734) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 13:23:37 UTC (rev 127735) @@ -169,7 +169,8 @@ BUGWKEFL : fast/events/touch/touch-target-limited.html = TEXT BUGWKEFL : fast/events/touch/touch-target.html = TEXT -BUGWKEFL : fast/events/tab-focus-link-in-canvas.html = TEXT +// WebKit2 can't use TAB key to navigate on webpage links +BUGWK95329 : fast/events/tab-focus-link-in-canvas.html = TEXT // WebKitTestRunner needs an implementation for testRunner.setViewModeMediaFeature BUGWKEFL : fast/media/media-query-list-02.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127737] trunk
Title: [127737] trunk
Revision 127737
Author commit-qu...@webkit.org
Date 2012-09-06 07:00:33 -0700 (Thu, 06 Sep 2012)
Log Message
CSS 3 'overflow-wrap' property implementation
https://bugs.webkit.org/show_bug.cgi?id=94475
Patch by Mikhail Pozdnyakov on 2012-09-06
Reviewed by Ojan Vafai.
Source/WebCore:
Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
The specification declares that 'word-wrap' as a shorthand
for the 'overflow-wrap' property. So what was basically done
is declaring of new 'overflow-wrap' property and renaming
of the internal data structures from 'WordWrap' to 'OverflowWrap'.
Both 'overflow-wrap' and 'word-wrap' properties share the same
handlers and thus have the same behaviour.
Test: fast/text/overflow-wrap.html
* WebCore.order: Rename exported setWordWrap to setOverflowWrap.
* css/CSSComputedStyleDeclaration.cpp: Add CSSPropertyOverflowWrap to computedProperties.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp: Validation for the 'overflow-wrap' property.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): CSSPropertyOverflowWrap is inherited.
* css/CSSPropertyNames.in: Declare new 'overflow-wrap' property.
* css/StyleBuilder.cpp: Assign property handler (same as for 'word-wrap').
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Renaming.
* rendering/RenderTextControl.cpp: Ditto.
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControlSingleLine.cpp: Ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
* rendering/style/RenderStyle.cpp: Ditto.
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h: Ditto.
* rendering/style/RenderStyleConstants.h: Ditto.
* rendering/style/StyleRareInheritedData.cpp: Ditto.
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h: Ditto.
(StyleRareInheritedData):
LayoutTests:
Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
New ref-test is added to check the simularity
in behaviour of 'overflow-wrap' and 'word-wrap' properties.
* fast/text/overflow-wrap-expected.html: Added.
* fast/text/overflow-wrap.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.order
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSProperty.cpp
trunk/Source/WebCore/css/CSSPropertyNames.in
trunk/Source/WebCore/css/StyleBuilder.cpp
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/rendering/RenderTextControl.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp
trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h
Added Paths
trunk/LayoutTests/fast/text/overflow-wrap-expected.html
trunk/LayoutTests/fast/text/overflow-wrap.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127736 => 127737)
--- trunk/LayoutTests/ChangeLog 2012-09-06 13:41:21 UTC (rev 127736)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 14:00:33 UTC (rev 127737)
@@ -1,3 +1,18 @@
+2012-09-06 Mikhail Pozdnyakov
+
+CSS 3 'overflow-wrap' property implementation
+https://bugs.webkit.org/show_bug.cgi?id=94475
+
+Reviewed by Ojan Vafai.
+
+Added 'overflow-wrap' property implementation according to
+http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
+New ref-test is added to check the simularity
+in behaviour of 'overflow-wrap' and 'word-wrap' properties.
+
+* fast/text/overflow-wrap-expected.html: Added.
+* fast/text/overflow-wrap.html: Added.
+
2012-09-06 Christophe Dumez
[EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html
Added: trunk/LayoutTests/fast/text/overflow-wrap-expected.html (0 => 127737)
--- trunk/LayoutTests/fast/text/overflow-wrap-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/overflow-wrap-expected.html 2012-09-06 14:00:33 UTC (rev 127737)
@@ -0,0 +1,33 @@
+
+
+
+CSS Test: 'overflow-wrap' property is identical to 'text-wrap' property.
+
+
+
+function test()
+{
+var propertyName = "
[webkit-changes] [127738] trunk/Source
Title: [127738] trunk/Source
Revision 127738
Author loi...@chromium.org
Date 2012-09-06 07:25:47 -0700 (Thu, 06 Sep 2012)
Log Message
Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
https://bugs.webkit.org/show_bug.cgi?id=95957
Reviewed by Yury Semikhatsky.
Source/WebCore:
Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each type of memory will be counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.
* dom/MemoryInstrumentation.cpp:
(WebCore):
* dom/MemoryInstrumentation.h:
(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):
* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::countObjectSize):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
Source/WebKit/chromium:
Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each memory type is counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.
* tests/MemoryInstrumentationTest.cpp:
(WebCore::InstrumentedUndefined::InstrumentedUndefined):
(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::InstrumentedDOM::InstrumentedDOM):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(InstrumentedDOM):
(WebCore::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MemoryInstrumentation.cpp
trunk/Source/WebCore/dom/MemoryInstrumentation.h
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp
trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp
trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
trunk/Source/WebCore/loader/cache/CachedResourceHandle.cpp
trunk/Source/WebCore/platform/SharedBuffer.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127737 => 127738)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 14:00:33 UTC (rev 127737)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 14:25:47 UTC (rev 127738)
@@ -1,3 +1,38 @@
+2012-09-06 Ilya Tikhonovsky
+
+Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
+https://bugs.webkit.org/show_bug.cgi?id=95957
+
+Reviewed by Yury Semikhatsky.
+
+Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
+instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
+At a later stage, when each type of memory will be counted in MemoryInstrumentation
+we will build the blocks hierarchy for the front-end automatically.
+
+* dom/MemoryInstrumentation.cpp:
+(WebCore):
+* dom/MemoryInstrumentation.h:
+(GenericMemoryTypes):
+(WebCore::MemoryInstrumentation::addRootObject):
+(WebCore::MemoryObjectInfo::reportObjectInfo):
+(WebCoreMemoryTypes):
+* inspector/InspectorMemoryAgent.cpp:
+(MemoryBlockName):
+(WebCore):
+* inspector/MemoryInstrumentationImpl.cpp:
+(WebCore::MemoryInstrumentationImpl::countObjectSize):
+* inspector/front-end/NativeMemorySnapshotView.js:
+(WebInspector.MemoryBlockViewProperties._initialize):
+* loader/cache/CachedRawResource.cpp:
+(WebCore::CachedRawResource::reportMemoryUsage):
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::reportMemoryUsage):
+* loader/cache/CachedResourceHandle.cpp:
+(WebCore::CachedResourceHandleBase::reportMemoryUsage):
+* platform/SharedBuffer.cpp:
+(WebCore::SharedBuffer::reportMemoryUsage):
+
2012-09-06 Mikhail Pozdnyakov
CSS 3 'overflow-wrap' property implementation
Modified: trunk/Source/WebCore/dom/MemoryInstrumentation.cpp (127737 => 127738)
--- trunk/Source/WebCore/dom/MemoryInstrumentation.cpp 2012-09-06 14:00:33 UTC (rev 127737)
+++ trunk/Source/WebCore/dom/MemoryInstrumentation.cpp 2012-09-06 14:25:47 UTC (rev 127738)
@@ -37,22 +37,26 @@
namespace WebCore {
-Mem
[webkit-changes] [127739] trunk
Title: [127739] trunk Revision 127739 Author commit-qu...@webkit.org Date 2012-09-06 07:36:04 -0700 (Thu, 06 Sep 2012) Log Message [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac https://bugs.webkit.org/show_bug.cgi?id=95973 Patch by Christophe Dumez on 2012-09-06 Reviewed by Kenneth Rohde Christiansen. Tools: Correctly map "addSelectionKey" to "Control" modifier in WKTR's EventSender on other OSes than Mac OS X, instead of mapping it to the "Meta" modifier. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::parseModifier): LayoutTests: Unskip several test cases that are passing on WebKit2 now that "addSelectionKey" is properly mapped to "Control" modifier on other OSes than Mac OS X, in WKTR's EventSender. * platform/efl-wk2/TestExpectations: * platform/gtk-wk2/Skipped: * platform/win-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations trunk/LayoutTests/platform/gtk-wk2/Skipped trunk/LayoutTests/platform/win-wk2/Skipped trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp Diff Modified: trunk/LayoutTests/ChangeLog (127738 => 127739) --- trunk/LayoutTests/ChangeLog 2012-09-06 14:25:47 UTC (rev 127738) +++ trunk/LayoutTests/ChangeLog 2012-09-06 14:36:04 UTC (rev 127739) @@ -1,3 +1,19 @@ +2012-09-06 Christophe Dumez + +[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac +https://bugs.webkit.org/show_bug.cgi?id=95973 + +Reviewed by Kenneth Rohde Christiansen. + +Unskip several test cases that are passing on WebKit2 +now that "addSelectionKey" is properly mapped to +"Control" modifier on other OSes than Mac OS X, in +WKTR's EventSender. + +* platform/efl-wk2/TestExpectations: +* platform/gtk-wk2/Skipped: +* platform/win-wk2/Skipped: + 2012-09-06 Mikhail Pozdnyakov CSS 3 'overflow-wrap' property implementation Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (127738 => 127739) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 14:25:47 UTC (rev 127738) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 14:36:04 UTC (rev 127739) @@ -229,10 +229,7 @@ BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT BUGWKEFL : fast/forms/autocomplete-off-with-default-value-does-not-clear.html = TEXT BUGWKEFL : fast/forms/legend-access-key.html = TEXT -BUGWKEFL : fast/forms/listbox-deselect-scroll.html = TEXT -BUGWKEFL : fast/forms/listbox-selection.html = TEXT BUGWKEFL : fast/forms/plaintext-mode-1.html = TEXT -BUGWKEFL : fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html = TEXT BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT BUGWKEFL : fast/forms/validation-message-in-relative-body.html = TEXT BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (127738 => 127739) --- trunk/LayoutTests/platform/gtk-wk2/Skipped 2012-09-06 14:25:47 UTC (rev 127738) +++ trunk/LayoutTests/platform/gtk-wk2/Skipped 2012-09-06 14:36:04 UTC (rev 127739) @@ -79,7 +79,6 @@ fast/forms/implicit-submission.html fast/forms/select-type-ahead-non-latin.html fast/forms/listbox-typeahead-cyrillic.html -fast/forms/listbox-selection.html fast/forms/listbox-typeahead-greek.html fast/forms/legend-access-key.html http/tests/xmlhttprequest/workers/abort-exception-assert.html @@ -216,7 +215,6 @@ svg/custom/mouse-move-on-svg-container.xhtml svg/custom/mouse-move-on-svg-root-standalone.svg svg/custom/mouse-move-on-svg-root.xhtml -fast/forms/listbox-deselect-scroll.html # WebKit2 needs layoutTestController.setSmartInsertDeleteEnabled editing/selection/doubleclick-beside-cr-span.html Modified: trunk/LayoutTests/platform/win-wk2/Skipped (127738 => 127739) --- trunk/LayoutTests/platform/win-wk2/Skipped 2012-09-06 14:25:47 UTC (rev 127738) +++ trunk/LayoutTests/platform/win-wk2/Skipped 2012-09-06 14:36:04 UTC (rev 127739) @@ -284,9 +284,7 @@ fast/forms/input-text-scroll-left-on-blur.html fast/forms/input-type-change-in-onfocus-keyboard.html fast/forms/legend-access-key.html -fast/forms/listbox-deselect-scroll.html fast/forms/listbox-onchange.html -fast/forms/listbox-selection.html fast/forms/listbox-typeahead-cyrillic.html fast/forms/listbox-typeahead-empty.html fast/forms/listbox-typeahead-greek.html Modified: trunk/Tools/ChangeLog (127738 => 127739) --- trunk/Tools/ChangeLog 2012-09-06 14:25:47 UTC (rev 127738) +++ trunk/Tools/ChangeLog 2012-09-06 14:36:04 UTC (rev 127739) @@ -1,3 +1,17 @@ +2012-09-06 Christophe Dumez + +[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac +https://bugs.webkit.org/show_bug.cgi?id=95973 + +Reviewed by Kenneth Rohde Christiansen. + +Correctly map "addSelectionKey" to "Contro
[webkit-changes] [127740] trunk/Source/WebKit/efl
Title: [127740] trunk/Source/WebKit/efl
Revision 127740
Author commit-qu...@webkit.org
Date 2012-09-06 07:38:30 -0700 (Thu, 06 Sep 2012)
Log Message
[EFL] Remove unnecessary logic in ewk_frame_source_get.
https://bugs.webkit.org/show_bug.cgi?id=95828
Patch by Kangil Han on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.
Removed unnecessary logic that checks if tag exists in document.
WebKit automatically fill out tags if they are not existed.
* ewk/ewk_frame.cpp:
(ewk_frame_source_get):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (127739 => 127740)
--- trunk/Source/WebKit/efl/ChangeLog 2012-09-06 14:36:04 UTC (rev 127739)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-09-06 14:38:30 UTC (rev 127740)
@@ -1,3 +1,16 @@
+2012-09-06 Kangil Han
+
+[EFL] Remove unnecessary logic in ewk_frame_source_get.
+https://bugs.webkit.org/show_bug.cgi?id=95828
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Removed unnecessary logic that checks if tag exists in document.
+WebKit automatically fill out tags if they are not existed.
+
+* ewk/ewk_frame.cpp:
+(ewk_frame_source_get):
+
2012-09-05 Kangil Han
[EFL] Remove '+=' usage in String
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (127739 => 127740)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2012-09-06 14:36:04 UTC (rev 127739)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2012-09-06 14:38:30 UTC (rev 127740)
@@ -1659,15 +1659,6 @@
}
}
-// Try to get and tags if tag was not found.
-if (builder.isEmpty()) {
-if (smartData->frame->document()->head())
-builder.append(smartData->frame->document()->head()->outerHTML());
-
-if (smartData->frame->document()->body())
-builder.append(smartData->frame->document()->body()->outerHTML());
-}
-
CString utf8String = builder.toString().utf8();
size_t sourceLength = utf8String.length();
*frameSource = static_cast(malloc(sourceLength + 1));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127741] trunk/Source/WebKit/chromium
Title: [127741] trunk/Source/WebKit/chromium
Revision 127741
Author loi...@chromium.org
Date 2012-09-06 08:04:46 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed Web Inspector: test fix.
* tests/MemoryInstrumentationTest.cpp:
(StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::reportMemoryUsage):
(WebCore):
(WebCore::TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127740 => 127741)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 14:38:30 UTC (rev 127740)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 15:04:46 UTC (rev 127741)
@@ -1,5 +1,16 @@
2012-09-06 Ilya Tikhonovsky
+Unreviewed Web Inspector: test fix.
+
+* tests/MemoryInstrumentationTest.cpp:
+(StringOwnerInstrumented):
+(WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
+(WebCore::StringOwnerInstrumented::reportMemoryUsage):
+(WebCore):
+(WebCore::TEST):
+
+2012-09-06 Ilya Tikhonovsky
+
Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
https://bugs.webkit.org/show_bug.cgi?id=95957
Modified: trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp (127740 => 127741)
--- trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp 2012-09-06 14:38:30 UTC (rev 127740)
+++ trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp 2012-09-06 15:04:46 UTC (rev 127741)
@@ -227,32 +227,26 @@
EXPECT_EQ(2, visitedObjects.size());
}
-TEST(MemoryInstrumentationTest, visitStrings)
-{
+class StringOwnerInstrumented {
+public:
+StringOwnerInstrumented() : m_name("string") { }
+void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
-VisitedObjects visitedObjects;
-MemoryInstrumentationImpl impl(visitedObjects);
-String string("string");
-impl.addRootObject(string);
-EXPECT_EQ(string.impl()->sizeInBytes(), impl.reportedSizeForAllTypes());
-EXPECT_EQ(2, visitedObjects.size());
+MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);
+info.addInstrumentedMember(m_name);
}
-{
-VisitedObjects visitedObjects;
-MemoryInstrumentationImpl impl(visitedObjects);
-String string("string");
-impl.addRootObject(&string);
-EXPECT_EQ(string.impl()->sizeInBytes() + sizeof(String), impl.reportedSizeForAllTypes());
-EXPECT_EQ(2, visitedObjects.size());
-}
-{
-VisitedObjects visitedObjects;
-MemoryInstrumentationImpl impl(visitedObjects);
-AtomicString string("string");
-impl.addRootObject(&string);
-EXPECT_EQ(string.impl()->sizeInBytes() + sizeof(AtomicString), impl.reportedSizeForAllTypes());
-EXPECT_EQ(2, visitedObjects.size());
-}
+
+String m_name;
+};
+
+TEST(MemoryInstrumentationTest, visitStrings)
+{
+VisitedObjects visitedObjects;
+MemoryInstrumentationImpl impl(visitedObjects);
+StringOwnerInstrumented stringOwnerInstrumented;
+impl.addRootObject(stringOwnerInstrumented);
+EXPECT_EQ(stringOwnerInstrumented.m_name.impl()->sizeInBytes(), impl.reportedSizeForAllTypes());
+EXPECT_EQ(2, visitedObjects.size());
}
} // namespace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127742] trunk/Tools
Title: [127742] trunk/Tools
Revision 127742
Author commit-qu...@webkit.org
Date 2012-09-06 08:31:02 -0700 (Thu, 06 Sep 2012)
Log Message
[Qt] Fix build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=95200
Patch by Simon Hausmann on 2012-09-06
Reviewed by Tor Arne Vestbø.
The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
10.7 and newer.
* qmake/mkspecs/features/features.prf:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf
Diff
Modified: trunk/Tools/ChangeLog (127741 => 127742)
--- trunk/Tools/ChangeLog 2012-09-06 15:04:46 UTC (rev 127741)
+++ trunk/Tools/ChangeLog 2012-09-06 15:31:02 UTC (rev 127742)
@@ -1,3 +1,15 @@
+2012-09-06 Simon Hausmann
+
+[Qt] Fix build on Mac OS X 10.6
+https://bugs.webkit.org/show_bug.cgi?id=95200
+
+Reviewed by Tor Arne Vestbø.
+
+The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
+10.7 and newer.
+
+* qmake/mkspecs/features/features.prf:
+
2012-09-06 Christophe Dumez
[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
Modified: trunk/Tools/qmake/mkspecs/features/features.prf (127741 => 127742)
--- trunk/Tools/qmake/mkspecs/features/features.prf 2012-09-06 15:04:46 UTC (rev 127741)
+++ trunk/Tools/qmake/mkspecs/features/features.prf 2012-09-06 15:31:02 UTC (rev 127742)
@@ -149,8 +149,13 @@
# HTML5 Media Support
!contains(DEFINES, ENABLE_VIDEO=.) {
mac:!contains(DEFINES, USE_QTMULTIMEDIA=1) {
-DEFINES += ENABLE_VIDEO=1
-DEFINES += WTF_USE_QTKIT=1
+DARWIN_VERSION = $$split(QMAKE_HOST.version, ".")
+DARWIN_MAJOR_VERSION = $$first(DARWIN_VERSION)
+# QTKIT support requires 10.7 or newer
+greaterThan(DARWIN_MAJOR_VERSION, 10) {
+DEFINES += ENABLE_VIDEO=1
+DEFINES += WTF_USE_QTKIT=1
+}
} else: linux-*:!contains(DEFINES, USE_QTMULTIMEDIA=1) {
!contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 \'gstreamer-0.10 >= 0.10.30\' \'gstreamer-plugins-base-0.10 >= 0.10.30\'): {
DEFINES += ENABLE_VIDEO=1
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127743] trunk/LayoutTests
Title: [127743] trunk/LayoutTests
Revision 127743
Author loi...@chromium.org
Date 2012-09-06 08:40:09 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed rebaseline for Web Inspector NMI test. It was broken at r127738.
* inspector/profiler/memory-instrumentation-cached-images-expected.txt:
* inspector/profiler/memory-instrumentation-cached-images.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images-expected.txt
trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127742 => 127743)
--- trunk/LayoutTests/ChangeLog 2012-09-06 15:31:02 UTC (rev 127742)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 15:40:09 UTC (rev 127743)
@@ -1,3 +1,10 @@
+2012-09-06 Ilya Tikhonovsky
+
+Unreviewed rebaseline for Web Inspector NMI test. It was broken at r127738.
+
+* inspector/profiler/memory-instrumentation-cached-images-expected.txt:
+* inspector/profiler/memory-instrumentation-cached-images.html:
+
2012-09-06 Christophe Dumez
[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
Modified: trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images-expected.txt (127742 => 127743)
--- trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images-expected.txt 2012-09-06 15:31:02 UTC (rev 127742)
+++ trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images-expected.txt 2012-09-06 15:40:09 UTC (rev 127743)
@@ -2,5 +2,5 @@
didReceiveMemorySnapshot
-PASS: CachedImages size is OK.
+PASS: MemoryCache.Image size is OK.
Modified: trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images.html (127742 => 127743)
--- trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images.html 2012-09-06 15:31:02 UTC (rev 127742)
+++ trunk/LayoutTests/inspector/profiler/memory-instrumentation-cached-images.html 2012-09-06 15:40:09 UTC (rev 127743)
@@ -48,12 +48,12 @@
function didReceiveMemorySnapshot(error, memoryBlock)
{
InspectorTest.addResult("didReceiveMemorySnapshot");
-var imagesSize = memoryBlockSize(["ProcessPrivateMemory", "MemoryCache", "CachedImages"], memoryBlock);
+var imagesSize = memoryBlockSize(["ProcessPrivateMemory", "MemoryCache", "MemoryCache.Image"], memoryBlock);
var jpegDecodedSizeExpected = 2000;
if (imagesSize > jpegDecodedSizeExpected)
-InspectorTest.addResult("PASS: CachedImages size is OK.");
+InspectorTest.addResult("PASS: MemoryCache.Image size is OK.");
else
-InspectorTest.addResult("FAIL: CachedImages size is too small.");
+InspectorTest.addResult("FAIL: MemoryCache.Image size is too small.");
InspectorTest.completeTest();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127744] trunk/LayoutTests
Title: [127744] trunk/LayoutTests Revision 127744 Author commit-qu...@webkit.org Date 2012-09-06 08:42:18 -0700 (Thu, 06 Sep 2012) Log Message [EFL] Gardening after r127728, r127534 https://bugs.webkit.org/show_bug.cgi?id=95975 Unreviewed gardening. Following tests were added to TestExpectations: http/tests/xmlhttprequest/basic-auth.html fails after r127728. fast/innerHTML/innerHTML-iframe.html fails after r127534. Patch by Mikhail Pozdnyakov on 2012-09-06 * platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Removed. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Removed Paths trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127743 => 127744) --- trunk/LayoutTests/ChangeLog 2012-09-06 15:40:09 UTC (rev 127743) +++ trunk/LayoutTests/ChangeLog 2012-09-06 15:42:18 UTC (rev 127744) @@ -1,3 +1,17 @@ +2012-09-06 Mikhail Pozdnyakov + +[EFL] Gardening after r127728, r127534 +https://bugs.webkit.org/show_bug.cgi?id=95975 + +Unreviewed gardening. + +Following tests were added to TestExpectations: +http/tests/xmlhttprequest/basic-auth.html fails after r127728. +fast/innerHTML/innerHTML-iframe.html fails after r127534. + +* platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Removed. +* platform/efl/TestExpectations: + 2012-09-06 Ilya Tikhonovsky Unreviewed rebaseline for Web Inspector NMI test. It was broken at r127738. Modified: trunk/LayoutTests/platform/efl/TestExpectations (127743 => 127744) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-06 15:40:09 UTC (rev 127743) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-06 15:42:18 UTC (rev 127744) @@ -1107,3 +1107,9 @@ // Fail after r127704. BUGWK95952 : fast/viewport/viewport-limits-adjusted-for-no-user-scale.html = TEXT BUGWK95952 : fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html = TEXT + +// Fails after r127534. +BUGWK95813 : fast/innerHTML/innerHTML-iframe.html = TEXT + +// Fails after r127728. +BUGWK95972 : http/tests/xmlhttprequest/basic-auth.html = TEXT Deleted: trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt (127743 => 127744) --- trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt 2012-09-06 15:40:09 UTC (rev 127743) +++ trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt 2012-09-06 15:42:18 UTC (rev 127744) @@ -1 +0,0 @@ -PASS: body and iframe cleared without crashing. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127745] trunk/Source/WebKit2
Title: [127745] trunk/Source/WebKit2 Revision 127745 Author kbal...@webkit.org Date 2012-09-06 08:54:53 -0700 (Thu, 06 Sep 2012) Log Message [WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPopupMenuProxy https://bugs.webkit.org/show_bug.cgi?id=95862 Reviewed by Simon Hausmann. Bail out early if the PageClient does not create a PopupMenuProxy for us. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenu): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (127744 => 127745) --- trunk/Source/WebKit2/ChangeLog 2012-09-06 15:42:18 UTC (rev 127744) +++ trunk/Source/WebKit2/ChangeLog 2012-09-06 15:54:53 UTC (rev 127745) @@ -1,3 +1,15 @@ +2012-09-06 Balazs Kelemen + +[WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPopupMenuProxy +https://bugs.webkit.org/show_bug.cgi?id=95862 + +Reviewed by Simon Hausmann. + +Bail out early if the PageClient does not create a PopupMenuProxy for us. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::showPopupMenu): + 2012-09-06 Christophe Dumez [EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent() Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (127744 => 127745) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-09-06 15:42:18 UTC (rev 127744) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-09-06 15:54:53 UTC (rev 127745) @@ -2911,6 +2911,9 @@ m_activePopupMenu = m_pageClient->createPopupMenuProxy(this); +if (!m_activePopupMenu) +return; + // Since showPopupMenu() can spin a nested run loop we need to turn off the responsiveness timer. m_process->responsivenessTimer()->stop(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127746] trunk/Source/WebCore
Title: [127746] trunk/Source/WebCore
Revision 127746
Author commit-qu...@webkit.org
Date 2012-09-06 09:00:09 -0700 (Thu, 06 Sep 2012)
Log Message
Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
https://bugs.webkit.org/show_bug.cgi?id=95731
Patch by Eugene Klyuchnikov on 2012-09-06
Reviewed by Yury Semikhatsky.
Now scrolling is sluggish on large datasets.
Performance degrades, because each refresh causes DFS on all recorded items.
Solution: caching/invalidation of DFS (filtering) results.
Also fixed "truncate selected record range on mode change" glitch.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
Add flag for cache invalidation.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.invalidateFilteredRecords):
Added.
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
Caching/using cached results.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (127745 => 127746)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 15:54:53 UTC (rev 127745)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 16:00:09 UTC (rev 127746)
@@ -1,3 +1,26 @@
+2012-09-06 Eugene Klyuchnikov
+
+Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
+https://bugs.webkit.org/show_bug.cgi?id=95731
+
+Reviewed by Yury Semikhatsky.
+
+Now scrolling is sluggish on large datasets.
+Performance degrades, because each refresh causes DFS on all recorded items.
+Solution: caching/invalidation of DFS (filtering) results.
+
+Also fixed "truncate selected record range on mode change" glitch.
+
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel):
+(WebInspector.TimelinePanel.prototype._scheduleRefresh):
+Add flag for cache invalidation.
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.prototype.invalidateFilteredRecords):
+Added.
+(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
+Caching/using cached results.
+
2012-09-06 Ilya Tikhonovsky
Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (127745 => 127746)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-09-06 15:54:53 UTC (rev 127745)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-09-06 16:00:09 UTC (rev 127746)
@@ -50,7 +50,7 @@
this._glueRecordsSetting = WebInspector.settings.createSetting("timelineGlueRecords", true);
this._overviewPane = new WebInspector.TimelineOverviewPane(this._model);
-this._overviewPane.addEventListener(WebInspector.TimelineOverviewPane.Events.WindowChanged, this._scheduleRefresh.bind(this, false));
+this._overviewPane.addEventListener(WebInspector.TimelineOverviewPane.Events.WindowChanged, this._invalidateAndScheduleRefresh.bind(this, false));
this._overviewPane.addEventListener(WebInspector.TimelineOverviewPane.Events.ModeChanged, this._overviewModeChanged, this);
this._overviewPane.show(this.element);
@@ -284,7 +284,7 @@
_onCategoryCheckboxClicked: function(category, event)
{
category.hidden = !event.target.checked;
-this._scheduleRefresh(true);
+this._invalidateAndScheduleRefresh(true);
},
/**
@@ -530,7 +530,7 @@
this._showShortEvents = this.toggleFilterButton.toggled;
this._overviewPane.setShowShortEvents(this._showShortEvents);
this.toggleFilterButton.element.title = this._showShortEvents ? this._hideShortRecordsTitleText : this._showShortRecordsTitleText;
-this._scheduleRefresh(true);
+this._invalidateAndScheduleRefresh(true);
},
_garbageCollectButtonClicked: function()
@@ -550,16 +550,17 @@
_repopulateRecords: function()
{
this._resetPanel();
+this._automaticallySizeWindow = false;
var records = this._model.records;
for (var i = 0; i < records.length; ++i)
this._innerAddRecordToTimeline(records[i], this._rootRecord());
-this._scheduleRefresh(false);
+this._invalidateAndScheduleRefresh(false);
},
_onTimelineEventRecorded: function(event)
{
if (this._innerAddRecordToTimeline(event.data, this._rootRecord()))
-this._scheduleRefresh(false);
+this._invalidateAndScheduleRefresh(false);
},
_innerAddRecordToTimeline: function(record, parentRecord)
@@ -621,7 +622,7 @@
_onRecordsCleared: function()
{
this._resetPa
[webkit-changes] [127747] trunk/Source/ThirdParty/ANGLE
Title: [127747] trunk/Source/ThirdParty/ANGLE Revision 127747 Author abe...@webkit.org Date 2012-09-06 09:25:36 -0700 (Thu, 06 Sep 2012) Log Message [ANGLE] Fix the build with gcc 4.7 https://bugs.webkit.org/show_bug.cgi?id=95989 Reviewed by Csaba Osztrogonác. The build fails because of a bogus warning about the auto-generated pplval variable. Unfortunately the warning is called -Wuninitialized in gcc 4.6 and -Wmaybe-uninitialized in gcc 4.7 thus we also need to ignore unknown pragmas not to break the build with compilers that do not recognize these options. * src/compiler/preprocessor/new/ExpressionParser.y: Modified Paths trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.y Diff Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (127746 => 127747) --- trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-09-06 16:00:09 UTC (rev 127746) +++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-09-06 16:25:36 UTC (rev 127747) @@ -1,3 +1,18 @@ +2012-09-06 Andras Becsi + +[ANGLE] Fix the build with gcc 4.7 +https://bugs.webkit.org/show_bug.cgi?id=95989 + +Reviewed by Csaba Osztrogonác. + +The build fails because of a bogus warning about the auto-generated +pplval variable. Unfortunately the warning is called -Wuninitialized +in gcc 4.6 and -Wmaybe-uninitialized in gcc 4.7 thus we also need to +ignore unknown pragmas not to break the build with compilers that do +not recognize these options. + +* src/compiler/preprocessor/new/ExpressionParser.y: + 2012-09-06 Simon Hausmann [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2 Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.y (127746 => 127747) --- trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.y 2012-09-06 16:00:09 UTC (rev 127746) +++ trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.y 2012-09-06 16:25:36 UTC (rev 127747) @@ -21,8 +21,13 @@ // This file is auto-generated by generate_parser.sh. DO NOT EDIT! #if defined(__GNUC__) +// Toggle the warning for -Wpragmas to ensure we do not break the build +// with earlier compiler versions because of unknown pragma options. +#pragma GCC diagnostic ignored "-Wpragmas" // Triggered by the auto-generated pplval variable. #pragma GCC diagnostic ignored "-Wuninitialized" +#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" +#pragma GCC diagnostic warning "-Wpragmas" #elif defined(_MSC_VER) #pragma warning(disable: 4065 4701) #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127748] trunk/Source/WebCore
Title: [127748] trunk/Source/WebCore
Revision 127748
Author kei...@webkit.org
Date 2012-09-06 09:41:23 -0700 (Thu, 06 Sep 2012)
Log Message
Use native function bind in page popups
https://bugs.webkit.org/show_bug.cgi?id=95976
Reviewed by Kent Tamura.
We should be using Function.prototype.bind instead of our own bind implementation.
No new tests. No behavior change.
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._attachLeftButtonsTo):
(YearMonthController.prototype._attachRightButtonsTo):
(DaysTable.prototype.attachTo):
* Resources/pagepopups/colorSuggestionPicker.js:
(ColorPicker):
(ColorPicker.prototype._layout):
* Resources/pagepopups/pickerCommon.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js
trunk/Source/WebCore/Resources/pagepopups/colorSuggestionPicker.js
trunk/Source/WebCore/Resources/pagepopups/pickerCommon.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (127747 => 127748)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 16:25:36 UTC (rev 127747)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 16:41:23 UTC (rev 127748)
@@ -1,3 +1,26 @@
+2012-09-06 Keishi Hattori
+
+Use native function bind in page popups
+https://bugs.webkit.org/show_bug.cgi?id=95976
+
+Reviewed by Kent Tamura.
+
+We should be using Function.prototype.bind instead of our own bind implementation.
+
+No new tests. No behavior change.
+
+* Resources/pagepopups/calendarPicker.js:
+(CalendarPicker):
+(CalendarPicker.prototype._layoutButtons):
+(YearMonthController.prototype.attachTo):
+(YearMonthController.prototype._attachLeftButtonsTo):
+(YearMonthController.prototype._attachRightButtonsTo):
+(DaysTable.prototype.attachTo):
+* Resources/pagepopups/colorSuggestionPicker.js:
+(ColorPicker):
+(ColorPicker.prototype._layout):
+* Resources/pagepopups/pickerCommon.js:
+
2012-09-06 Eugene Klyuchnikov
Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
Modified: trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js (127747 => 127748)
--- trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js 2012-09-06 16:25:36 UTC (rev 127747)
+++ trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js 2012-09-06 16:41:23 UTC (rev 127748)
@@ -313,7 +313,7 @@
initialDate = this.maximumDate;
this.daysTable.selectDate(initialDate);
this.fixWindowSize();
-document.body.addEventListener("keydown", bind(this._handleBodyKeyDown, this), false);
+document.body.addEventListener("keydown", this._handleBodyKeyDown.bind(this), false);
}
CalendarPicker.prototype = Object.create(Picker.prototype);
@@ -379,14 +379,14 @@
this.today = createElement("input", ClassNames.TodayButton);
this.today.type = "button";
this.today.value = this._config.todayLabel;
-this.today.addEventListener("click", bind(this.handleToday, this), false);
+this.today.addEventListener("click", this.handleToday.bind(this), false);
container.appendChild(this.today);
this.clear = null;
if (!this._config.required) {
this.clear = createElement("input", ClassNames.ClearButton);
this.clear.type = "button";
this.clear.value = this._config.clearLabel;
-this.clear.addEventListener("click", bind(this.handleClear, this), false);
+this.clear.addEventListener("click", this.handleClear.bind(this), false);
container.appendChild(this.clear);
}
this._element.appendChild(container);
@@ -427,23 +427,23 @@
innerContainer.appendChild(box);
// We can't use popup in PagePopup.
this._monthPopup = createElement("div", ClassNames.MonthSelectorPopup);
-this._monthPopup.addEventListener("click", bind(this._handleYearMonthChange, this), false);
-this._monthPopup.addEventListener("keydown", bind(this._handleMonthPopupKey, this), false);
-this._monthPopup.addEventListener("mousemove", bind(this._handleMouseMove, this), false);
+this._monthPopup.addEventListener("click", this._handleYearMonthChange.bind(this), false);
+this._monthPopup.addEventListener("keydown", this._handleMonthPopupKey.bind(this), false);
+this._monthPopup.addEventListener("mousemove", this._handleMouseMove.bind(this), false);
this._updateSelectionOnMouseMove = true;
this._monthPopup.tabIndex = 0;
this._monthPopupContents = createElement("div", ClassNames.MonthSelectorPopupContents);
this._monthPopup.appendChild(this._monthPopupContents);
box.appendChild(this._monthPopup);
this._month = createElement("div", ClassNames.MonthSelector);
-this._month.addEventListener("click", bind(this._showPopup, this), false);
+this._month.addEventListener("click", this._showPopup.bin
[webkit-changes] [127749] trunk/Source/WebKit/gtk
Title: [127749] trunk/Source/WebKit/gtk
Revision 127749
Author carlo...@webkit.org
Date 2012-09-06 09:49:30 -0700 (Thu, 06 Sep 2012)
Log Message
[GTK] Add API to get/set the security policy of a given URI scheme
https://bugs.webkit.org/show_bug.cgi?id=95549
Reviewed by Martin Robinson.
Add WebKitSecurityPolicy enum with flags that represent the
security policy of a URI scheme. Add methods to get and set the
security policy flags for a given URI scheme.
* docs/webkitgtk-sections.txt: Add new symbols.
* tests/testglobals.c:
(test_globals_security_policy):
(main):
* webkit/webkitglobals.cpp:
(webkit_set_security_policy_for_uri_scheme):
(webkit_get_security_policy_for_uri_scheme):
* webkit/webkitglobals.h:
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt
trunk/Source/WebKit/gtk/tests/testglobals.c
trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp
trunk/Source/WebKit/gtk/webkit/webkitglobals.h
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (127748 => 127749)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-09-06 16:41:23 UTC (rev 127748)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-09-06 16:49:30 UTC (rev 127749)
@@ -1,3 +1,23 @@
+2012-09-06 Carlos Garcia Campos
+
+[GTK] Add API to get/set the security policy of a given URI scheme
+https://bugs.webkit.org/show_bug.cgi?id=95549
+
+Reviewed by Martin Robinson.
+
+Add WebKitSecurityPolicy enum with flags that represent the
+security policy of a URI scheme. Add methods to get and set the
+security policy flags for a given URI scheme.
+
+* docs/webkitgtk-sections.txt: Add new symbols.
+* tests/testglobals.c:
+(test_globals_security_policy):
+(main):
+* webkit/webkitglobals.cpp:
+(webkit_set_security_policy_for_uri_scheme):
+(webkit_get_security_policy_for_uri_scheme):
+* webkit/webkitglobals.h:
+
2012-09-05 Kaustubh Atrawalkar
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
Modified: trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt (127748 => 127749)
--- trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt 2012-09-06 16:41:23 UTC (rev 127748)
+++ trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt 2012-09-06 16:49:30 UTC (rev 127749)
@@ -536,6 +536,10 @@
WebKitContextMenuAction
webkit_context_menu_item_get_action
+
+WebKitSecurityPolicy
+webkit_set_security_policy_for_uri_scheme
+webkit_get_security_policy_for_uri_scheme
WEBKITGTK_API_VERSION
Modified: trunk/Source/WebKit/gtk/tests/testglobals.c (127748 => 127749)
--- trunk/Source/WebKit/gtk/tests/testglobals.c 2012-09-06 16:41:23 UTC (rev 127748)
+++ trunk/Source/WebKit/gtk/tests/testglobals.c 2012-09-06 16:49:30 UTC (rev 127749)
@@ -45,6 +45,58 @@
g_assert(soup_session_get_feature(session, WEBKIT_TYPE_SOUP_AUTH_DIALOG) == NULL);
}
+static void test_globals_security_policy()
+{
+// Check default policy for well known schemes.
+WebKitSecurityPolicy policy = webkit_get_security_policy_for_uri_scheme("http");
+guint mask = WEBKIT_SECURITY_POLICY_CORS_ENABLED;
+g_assert_cmpuint(policy & mask, ==, mask);
+
+policy = webkit_get_security_policy_for_uri_scheme("https");
+mask = WEBKIT_SECURITY_POLICY_SECURE | WEBKIT_SECURITY_POLICY_CORS_ENABLED;
+g_assert_cmpuint(policy & mask, ==, mask);
+
+policy = webkit_get_security_policy_for_uri_scheme("file");
+mask = WEBKIT_SECURITY_POLICY_LOCAL;
+g_assert_cmpuint(policy & mask, ==, mask);
+
+policy = webkit_get_security_policy_for_uri_scheme("data");
+mask = WEBKIT_SECURITY_POLICY_NO_ACCESS_TO_OTHER_SCHEME | WEBKIT_SECURITY_POLICY_SECURE;
+g_assert_cmpuint(policy & mask, ==, mask);
+
+policy = webkit_get_security_policy_for_uri_scheme("about");
+mask = WEBKIT_SECURITY_POLICY_NO_ACCESS_TO_OTHER_SCHEME | WEBKIT_SECURITY_POLICY_SECURE | WEBKIT_SECURITY_POLICY_EMPTY_DOCUMENT;
+g_assert_cmpuint(policy & mask, ==, mask);
+
+// Custom scheme.
+policy = webkit_get_security_policy_for_uri_scheme("foo");
+g_assert(!policy);
+
+policy |= WEBKIT_SECURITY_POLICY_LOCAL;
+webkit_set_security_policy_for_uri_scheme("foo", policy);
+g_assert_cmpuint(webkit_get_security_policy_for_uri_scheme("foo"), ==, policy);
+
+policy |= WEBKIT_SECURITY_POLICY_NO_ACCESS_TO_OTHER_SCHEME;
+webkit_set_security_policy_for_uri_scheme("foo", policy);
+g_assert_cmpuint(webkit_get_security_policy_for_uri_scheme("foo"), ==, policy);
+
+policy |= WEBKIT_SECURITY_POLICY_DISPLAY_ISOLATED;
+webkit_set_security_policy_for_uri_scheme("foo", policy);
+g_assert_cmpuint(webkit_get_security_policy_for_uri_scheme("foo"), ==, policy);
+
+policy |= WEBKIT_SECURITY_POLICY_SECURE;
+webkit_set_security_policy_for_uri_scheme("foo", policy);
+g_assert_cmpuint(webkit_get_security_policy_for_uri_scheme("foo"), ==, policy);
+
+policy |= WEBKIT_SECURITY_POLICY_CORS_ENABL
[webkit-changes] [127750] trunk/Source/WebKit2
Title: [127750] trunk/Source/WebKit2
Revision 127750
Author carlo...@webkit.org
Date 2012-09-06 09:53:41 -0700 (Thu, 06 Sep 2012)
Log Message
[GTK] [WK2] Crash when navigating between pages
https://bugs.webkit.org/show_bug.cgi?id=95949
Reviewed by Martin Robinson.
Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.
* UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
(didInitiateLoadForResource):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted):
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (127749 => 127750)
--- trunk/Source/WebKit2/ChangeLog 2012-09-06 16:49:30 UTC (rev 127749)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-06 16:53:41 UTC (rev 127750)
@@ -1,3 +1,22 @@
+2012-09-06 Carlos Garcia Campos
+
+[GTK] [WK2] Crash when navigating between pages
+https://bugs.webkit.org/show_bug.cgi?id=95949
+
+Reviewed by Martin Robinson.
+
+Do not trust isMainResource parameter in
+webkitWebViewResourceLoadStarted(), because it's always true for
+all subresources of pages loaded from the history cache. We can
+simply assume that the first resource loaded for the main frame
+is the main web view resource.
+
+* UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
+(didInitiateLoadForResource):
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewResourceLoadStarted):
+* UIProcess/API/gtk/WebKitWebViewPrivate.h:
+
2012-09-06 Balazs Kelemen
[WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPopupMenuProxy
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp (127749 => 127750)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp 2012-09-06 16:49:30 UTC (rev 127749)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp 2012-09-06 16:53:41 UTC (rev 127750)
@@ -38,7 +38,7 @@
static void didInitiateLoadForResource(WKPageRef, WKFrameRef wkFrame, uint64_t resourceIdentifier, WKURLRequestRef wkRequest, bool pageIsProvisionallyLoading, const void* clientInfo)
{
GRefPtr request = adoptGRef(webkitURIRequestCreateForResourceRequest(toImpl(wkRequest)->resourceRequest()));
-webkitWebViewResourceLoadStarted(WEBKIT_WEB_VIEW(clientInfo), wkFrame, resourceIdentifier, request.get(), pageIsProvisionallyLoading);
+webkitWebViewResourceLoadStarted(WEBKIT_WEB_VIEW(clientInfo), wkFrame, resourceIdentifier, request.get());
}
static void didSendRequestForResource(WKPageRef, WKFrameRef, uint64_t resourceIdentifier, WKURLRequestRef wkRequest, WKURLResponseRef wkRedirectResponse, const void* clientInfo)
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (127749 => 127750)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-09-06 16:49:30 UTC (rev 127749)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-09-06 16:53:41 UTC (rev 127750)
@@ -1311,11 +1311,12 @@
g_signal_connect(priv->mainResource.get(), "notify::response", G_CALLBACK(mainResourceResponseChangedCallback), webView);
}
-void webkitWebViewResourceLoadStarted(WebKitWebView* webView, WKFrameRef wkFrame, uint64_t resourceIdentifier, WebKitURIRequest* request, bool isMainResource)
+void webkitWebViewResourceLoadStarted(WebKitWebView* webView, WKFrameRef wkFrame, uint64_t resourceIdentifier, WebKitURIRequest* request)
{
WebKitWebViewPrivate* priv = webView->priv;
+bool isMainResource = WKFrameIsMainFrame(wkFrame) && !priv->mainResource;
WebKitWebResource* resource = webkitWebResourceCreate(wkFrame, request, isMainResource);
-if (WKFrameIsMainFrame(wkFrame) && (isMainResource || !priv->mainResource)) {
+if (isMainResource) {
priv->mainResource = resource;
waitForMainResourceResponseIfWaitingForResource(webView);
}
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h (127749 => 127750)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h 2012-09-06 16:49:30 UTC (rev 127749)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h 2012-09-06 16:53:41 UTC (rev 127750)
@@ -47,7 +47,7 @@
void webkitWebViewMakePolicyDecision(WebKitWebView*, WebKitPolicyDecisionType, WebKitPolicyDecision*);
void webkitWebViewMouseTargetChanged(WebKitWebView*, WKHitTestResultRef, unsigned modifiers);
void webkitWebViewPrintFrame(WebKitWebView*, WKFrameRef);
-void webkitWebViewResourceLoadStarted(WebKitWebView*, WKFra
[webkit-changes] [127751] trunk
Title: [127751] trunk
Revision 127751
Author m...@apple.com
Date 2012-09-06 10:11:32 -0700 (Thu, 06 Sep 2012)
Log Message
REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
https://bugs.webkit.org/show_bug.cgi?id=95972
Source/WebCore:
Reverted r127712, because it was based on the false premise that “[Optional] works the way
XMLHttpRequest expects”.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore):
* xml/XMLHttpRequest.h:
(XMLHttpRequest):
* xml/XMLHttpRequest.idl:
LayoutTests:
Removed the failing test from the skipped list.
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (127750 => 127751)
--- trunk/LayoutTests/ChangeLog 2012-09-06 16:53:41 UTC (rev 127750)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 17:11:32 UTC (rev 127751)
@@ -1,3 +1,12 @@
+2012-09-06 Dan Bernstein
+
+REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
+https://bugs.webkit.org/show_bug.cgi?id=95972
+
+Removed the failing test from the skipped list.
+
+* platform/qt/Skipped:
+
2012-09-06 Mikhail Pozdnyakov
[EFL] Gardening after r127728, r127534
Modified: trunk/LayoutTests/platform/qt/Skipped (127750 => 127751)
--- trunk/LayoutTests/platform/qt/Skipped 2012-09-06 16:53:41 UTC (rev 127750)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-09-06 17:11:32 UTC (rev 127751)
@@ -2802,7 +2802,3 @@
# https://bugs.webkit.org/show_bug.cgi?id=95952
fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html
-
-# REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
-# https://bugs.webkit.org/show_bug.cgi?id=95972
-http/tests/xmlhttprequest/basic-auth.html
Modified: trunk/Source/WebCore/ChangeLog (127750 => 127751)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 16:53:41 UTC (rev 127750)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 17:11:32 UTC (rev 127751)
@@ -1,3 +1,23 @@
+2012-09-06 Dan Bernstein
+
+REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
+https://bugs.webkit.org/show_bug.cgi?id=95972
+
+Reverted r127712, because it was based on the false premise that “[Optional] works the way
+XMLHttpRequest expects”.
+
+* bindings/js/JSXMLHttpRequestCustom.cpp:
+(WebCore::JSXMLHttpRequest::open):
+* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+(WebCore::V8XMLHttpRequest::openCallback):
+(WebCore):
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::open):
+(WebCore):
+* xml/XMLHttpRequest.h:
+(XMLHttpRequest):
+* xml/XMLHttpRequest.idl:
+
2012-09-06 Keishi Hattori
Use native function bind in page popups
Modified: trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp (127750 => 127751)
--- trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2012-09-06 16:53:41 UTC (rev 127750)
+++ trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2012-09-06 17:11:32 UTC (rev 127751)
@@ -79,7 +79,35 @@
}
// Custom functions
+JSValue JSXMLHttpRequest::open(ExecState* exec)
+{
+if (exec->argumentCount() < 2)
+return throwError(exec, createNotEnoughArgumentsError(exec));
+const KURL& url = ""
+String method = exec->argument(0).toString(exec)->value(exec);
+
+ExceptionCode ec = 0;
+if (exec->argumentCount() >= 3) {
+bool async = exec->argument(2).toBoolean(exec);
+
+if (exec->argumentCount() >= 4 && !exec->argument(3).isUndefined()) {
+String user = valueToStringWithNullCheck(exec, exec->argument(3));
+
+if (exec->argumentCount() >= 5 && !exec->argument(4).isUndefined()) {
+String password = valueToStringWithNullCheck(exec, exec->argument(4));
+impl()->open(method, url, async, user, password, ec);
+} else
+impl()->open(method, url, async, user, ec);
+} else
+impl()->open(method, url, async, ec);
+} else
+impl()->open(method, url, ec);
+
+setDOMException(exec, ec);
+return jsUndefined();
+}
+
JSValue JSXMLHttpRequest::send(ExecState* exec)
{
InspectorInstrumentation::willSendXMLHttpRequest(impl()->scriptExecutionContext(), impl()->url());
Modified: trunk/Sour
[webkit-changes] [127752] trunk/Source
Title: [127752] trunk/Source
Revision 127752
Author commit-qu...@webkit.org
Date 2012-09-06 10:13:48 -0700 (Thu, 06 Sep 2012)
Log Message
Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
https://bugs.webkit.org/show_bug.cgi?id=95780
Patch by Nikhil Bhargava on 2012-09-06
Reviewed by Eric Seidel.
Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
and Clipboard. There is a minor compile-time performance boost.
* Modules/mediastream/MediaStreamEvent.h:
* dom/Event.cpp:
* dom/Event.h:
(WebCore):
* dom/EventDispatchMediator.cpp:
* dom/EventListenerMap.cpp:
* dom/MouseRelatedEvent.h:
* dom/UIEvent.cpp:
* html/FormAssociatedElement.h:
(WebCore):
* inspector/TimelineRecordFactory.cpp:
* platform/graphics/FontPlatformData.h:
* rendering/RenderLineBoxList.h:
* rendering/style/RenderStyle.h:
(WebCore):
* svg/SVGAnimatedType.h:
* svg/SVGExternalResourcesRequired.cpp:
* svg/SVGExternalResourcesRequired.h:
(WebCore):
* svg/SVGURIReference.h:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h
trunk/Source/WebCore/dom/Event.cpp
trunk/Source/WebCore/dom/Event.h
trunk/Source/WebCore/dom/EventDispatchMediator.cpp
trunk/Source/WebCore/dom/EventListenerMap.cpp
trunk/Source/WebCore/dom/MouseRelatedEvent.h
trunk/Source/WebCore/dom/UIEvent.cpp
trunk/Source/WebCore/html/FormAssociatedElement.h
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/platform/graphics/FontPlatformData.h
trunk/Source/WebCore/rendering/RenderLineBoxList.h
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/svg/SVGAnimatedType.h
trunk/Source/WebCore/svg/SVGExternalResourcesRequired.cpp
trunk/Source/WebCore/svg/SVGExternalResourcesRequired.h
trunk/Source/WebCore/svg/SVGURIReference.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h
trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127751 => 127752)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 17:13:48 UTC (rev 127752)
@@ -1,3 +1,35 @@
+2012-09-06 Nikhil Bhargava
+
+Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
+https://bugs.webkit.org/show_bug.cgi?id=95780
+
+Reviewed by Eric Seidel.
+
+Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
+and Clipboard. There is a minor compile-time performance boost.
+
+* Modules/mediastream/MediaStreamEvent.h:
+* dom/Event.cpp:
+* dom/Event.h:
+(WebCore):
+* dom/EventDispatchMediator.cpp:
+* dom/EventListenerMap.cpp:
+* dom/MouseRelatedEvent.h:
+* dom/UIEvent.cpp:
+* html/FormAssociatedElement.h:
+(WebCore):
+* inspector/TimelineRecordFactory.cpp:
+* platform/graphics/FontPlatformData.h:
+* rendering/RenderLineBoxList.h:
+* rendering/style/RenderStyle.h:
+(WebCore):
+* svg/SVGAnimatedType.h:
+* svg/SVGExternalResourcesRequired.cpp:
+* svg/SVGExternalResourcesRequired.h:
+(WebCore):
+* svg/SVGURIReference.h:
+(WebCore):
+
2012-09-06 Dan Bernstein
REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp (127751 => 127752)
--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -43,6 +43,7 @@
#include "IDBTracing.h"
#include "IDBTransactionBackendImpl.h"
#include "ScriptExecutionContext.h"
+#include
namespace WebCore {
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h (127751 => 127752)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h 2012-09-06 17:13:48 UTC (rev 127752)
@@ -28,6 +28,7 @@
#if ENABLE(MEDIA_STREAM)
#include "Event.h"
+#include "MediaStream.h"
#include
namespace WebCore {
Modified: trunk/Source/WebCore/dom/Event.cpp (127751 => 127752)
--- trunk/Source/WebCore/dom/Event.cpp 2012-09-06 17:11:32 UTC (rev 127751)
+++ trunk/Source/WebCore/dom/Event.cpp 2012-09-06 17:13:48 UTC (rev 127752)
@@ -26,6 +26,7 @@
#include "EventDispatcher.h"
#include "EventNames.h"
#include "EventTarget.h"
+#include "MemoryInstrumentation.h"
#include "UserGestureIndicator.h"
#include
#include
Modified: trunk/Source/WebCore/dom/Event.h (127751 => 127752)
--- trunk/Source/WebCore/dom/Event.h 2012-09-06 17:11:32 UTC (rev 127751)
+++ tru
[webkit-changes] [127753] trunk/Source/WebKit2
Title: [127753] trunk/Source/WebKit2
Revision 127753
Author msab...@apple.com
Date 2012-09-06 10:14:32 -0700 (Thu, 06 Sep 2012)
Log Message
WebKit2 IPC always sends strings using 16 bit data format
https://bugs.webkit.org/show_bug.cgi?id=95811
Reviewed by Benjamin Poulain.
Changed string encoding to pass an 8bit flag and then send either 8 or 16 bit
character data.
* Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPCencode):
(CoreIPC::decodeStringText): New templatized string creation and decoder method.
(CoreIPCdecode):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/ArgumentCoders.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (127752 => 127753)
--- trunk/Source/WebKit2/ChangeLog 2012-09-06 17:13:48 UTC (rev 127752)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-06 17:14:32 UTC (rev 127753)
@@ -1,3 +1,18 @@
+2012-09-06 Michael Saboff
+
+WebKit2 IPC always sends strings using 16 bit data format
+https://bugs.webkit.org/show_bug.cgi?id=95811
+
+Reviewed by Benjamin Poulain.
+
+Changed string encoding to pass an 8bit flag and then send either 8 or 16 bit
+character data.
+
+* Platform/CoreIPC/ArgumentCoders.cpp:
+(CoreIPCencode):
+(CoreIPC::decodeStringText): New templatized string creation and decoder method.
+(CoreIPCdecode):
+
2012-09-06 Carlos Garcia Campos
[GTK] [WK2] Crash when navigating between pages
Modified: trunk/Source/WebKit2/Platform/CoreIPC/ArgumentCoders.cpp (127752 => 127753)
--- trunk/Source/WebKit2/Platform/CoreIPC/ArgumentCoders.cpp 2012-09-06 17:13:48 UTC (rev 127752)
+++ trunk/Source/WebKit2/Platform/CoreIPC/ArgumentCoders.cpp 2012-09-06 17:14:32 UTC (rev 127753)
@@ -97,9 +97,32 @@
uint32_t length = string.length();
encoder->encode(length);
-encoder->encodeFixedLengthData(reinterpret_cast(string.characters()), length * sizeof(UChar), __alignof(UChar));
+bool is8Bit = string.is8Bit();
+encoder->encodeBool(is8Bit);
+if (is8Bit)
+encoder->encodeFixedLengthData(reinterpret_cast(string.characters8()), length * sizeof(LChar), __alignof(LChar));
+else
+encoder->encodeFixedLengthData(reinterpret_cast(string.characters16()), length * sizeof(UChar), __alignof(UChar));
}
+template
+static inline bool decodeStringText(ArgumentDecoder* decoder, uint32_t length, String& result)
+{
+// Before allocating the string, make sure that the decoder buffer is big enough.
+if (!decoder->bufferIsLargeEnoughToContain(length)) {
+decoder->markInvalid();
+return false;
+}
+
+CharacterType* buffer;
+String string = String::createUninitialized(length, buffer);
+if (!decoder->decodeFixedLengthData(reinterpret_cast(buffer), length * sizeof(CharacterType), __alignof(CharacterType)))
+return false;
+
+result = string;
+return true;
+}
+
bool ArgumentCoder::decode(ArgumentDecoder* decoder, String& result)
{
uint32_t length;
@@ -112,19 +135,14 @@
return true;
}
-// Before allocating the string, make sure that the decoder buffer is big enough.
-if (!decoder->bufferIsLargeEnoughToContain(length)) {
-decoder->markInvalid();
+bool is8Bit;
+
+if (!decoder->decodeBool(is8Bit))
return false;
-}
-
-UChar* buffer;
-String string = String::createUninitialized(length, buffer);
-if (!decoder->decodeFixedLengthData(reinterpret_cast(buffer), length * sizeof(UChar), __alignof(UChar)))
-return false;
-
-result = string;
-return true;
+
+if (is8Bit)
+return decodeStringText(decoder, length, result);
+return decodeStringText(decoder, length, result);
}
} // namespace CoreIPC
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127754] trunk/Source/WebKit2
Title: [127754] trunk/Source/WebKit2 Revision 127754 Author a...@apple.com Date 2012-09-06 10:16:17 -0700 (Thu, 06 Sep 2012) Log Message [WK2] Annotate multi-process FIXMEs with bug numbers https://bugs.webkit.org/show_bug.cgi?id=95916 Reviewed by Eric Carlson. * UIProcess/WebContext.cpp: (WebKit::WebContext::setProcessModel): Ensure that plug-in process is enabled. Comments in WebPluginSiteDataManager said that it's required for multi-process. (WebKit::WebContext::createNewWebProcess): Added a bug number. (WebKit::WebContext::disconnectProcess): Ditto. (WebKit::WebContext::createWebPage): Ditto. (WebKit::WebContext::download): Ditto. (WebKit::WebContext::getWebCoreStatistics): Ditto. * UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData): Removed FIXMEs - some ports haven't switched to plugin process yet, but that doesn't stop others from having a multi-process model. Added an ASSERT to document this requirement (in addition to the check in WebContext). * UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel): (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): (WebKit::DownloadProxy::startTransfer): * UIProcess/WebApplicationCacheManagerProxy.cpp: (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries): * UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy): * UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): (WebKit::WebDatabaseManagerProxy::deleteAllDatabases): (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin): * UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): (WebKit::WebIconDatabase::didFinishURLImport): * UIProcess/WebKeyValueStorageManagerProxy.cpp: (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries): * UIProcess/WebMediaCacheManagerProxy.cpp: (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): * UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin): (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Added bug numbers. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/Downloads/DownloadProxy.cpp trunk/Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.cpp trunk/Source/WebKit2/UIProcess/WebApplicationCacheManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebDatabaseManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebIconDatabase.cpp trunk/Source/WebKit2/UIProcess/WebKeyValueStorageManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebResourceCacheManagerProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (127753 => 127754) --- trunk/Source/WebKit2/ChangeLog 2012-09-06 17:14:32 UTC (rev 127753) +++ trunk/Source/WebKit2/ChangeLog 2012-09-06 17:16:17 UTC (rev 127754) @@ -1,3 +1,59 @@ +2012-09-05 Alexey Proskuryakov + +[WK2] Annotate multi-process FIXMEs with bug numbers +https://bugs.webkit.org/show_bug.cgi?id=95916 + +Reviewed by Eric Carlson. + +* UIProcess/WebContext.cpp: +(WebKit::WebContext::setProcessModel): Ensure that plug-in process is enabled. +Comments in WebPluginSiteDataManager said that it's required for multi-process. +(WebKit::WebContext::createNewWebProcess): Added a bug number. +(WebKit::WebContext::disconnectProcess): Ditto. +(WebKit::WebContext::createWebPage): Ditto. +(WebKit::WebContext::download): Ditto. +(WebKit::WebContext::getWebCoreStatistics): Ditto. + +* UIProcess/Plugins/WebPluginSiteDataManager.cpp: +(WebKit::WebPluginSiteDataManager::getSitesWithData): +(WebKit::WebPluginSiteDataManager::clearSiteData): +Removed FIXMEs - some ports haven't switched to plugin
[webkit-changes] [127755] trunk/LayoutTests
Title: [127755] trunk/LayoutTests
Revision 127755
Author commit-qu...@webkit.org
Date 2012-09-06 10:26:07 -0700 (Thu, 06 Sep 2012)
Log Message
gradient-with-scaled-ancestor.html is not calling setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=95847
Patch by Alex Sakhartchouk on 2012-09-06
Reviewed by Beth Dakin.
Setting the device scale factor in the layout test and updating expectations until we can rebase
* fast/hidpi/gradient-with-scaled-ancestor.html:
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/hidpi/gradient-with-scaled-ancestor.html
trunk/LayoutTests/platform/chromium/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (127754 => 127755)
--- trunk/LayoutTests/ChangeLog 2012-09-06 17:16:17 UTC (rev 127754)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 17:26:07 UTC (rev 127755)
@@ -1,3 +1,15 @@
+2012-09-06 Alex Sakhartchouk
+
+gradient-with-scaled-ancestor.html is not calling setDeviceScaleFactor
+https://bugs.webkit.org/show_bug.cgi?id=95847
+
+Reviewed by Beth Dakin.
+
+Setting the device scale factor in the layout test and updating expectations until we can rebase
+
+* fast/hidpi/gradient-with-scaled-ancestor.html:
+* platform/chromium/TestExpectations:
+
2012-09-06 Dan Bernstein
REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
Modified: trunk/LayoutTests/fast/hidpi/gradient-with-scaled-ancestor.html (127754 => 127755)
--- trunk/LayoutTests/fast/hidpi/gradient-with-scaled-ancestor.html 2012-09-06 17:16:17 UTC (rev 127754)
+++ trunk/LayoutTests/fast/hidpi/gradient-with-scaled-ancestor.html 2012-09-06 17:26:07 UTC (rev 127755)
@@ -1,3 +1,22 @@
-
-
-
+
+
+
+function startTest() {
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.setBackingScaleFactor(2, finishTest);
+}
+}
+
+function finishTest() {
+setTimeout(function() { testRunner.notifyDone(); }, 0);
+}
+
+
+
+
+
+
+
+
+
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127754 => 127755)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-06 17:16:17 UTC (rev 127754)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-06 17:26:07 UTC (rev 127755)
@@ -2645,6 +2645,8 @@
BUGWK94935 WIN ANDROID MAC : fast/hidpi/image-set-out-of-order.html = IMAGE
BUGWK94935 WIN ANDROID MAC : fast/hidpi/resize-corner-hidpi.html = IMAGE
+BUGWK95847 LINUX WIN ANDROID MAC : fast/hidpi/gradient-with-scaled-ancestor.html = IMAGE
+
// Flaky tests from ~r97647
BUGWK70298 MAC : fast/table/border-collapsing/cached-69296.html = IMAGE
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127756] trunk/Source
Title: [127756] trunk/Source
Revision 127756
Author dan...@chromium.org
Date 2012-09-06 10:29:05 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Add a customized copy() method to CCRenderPassDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=95871
Reviewed by Adrienne Walker.
Source/WebCore:
CCRenderPassDrawQuad is special because a copied quad will need to
point to a different RenderPass id, since new ids are given to copied
RenderPasses. Add a custom copy() method to CCRenderPassDrawQuad that
takes as input the new RenderPass id that should appear in the copied
quad.
Test: CCDrawQuad.copyRenderPassDrawQuad
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::copy):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::copy):
(WebCore):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
Source/WebKit/chromium:
* tests/CCDrawQuadTest.cpp:
(WebCore):
(WebCore::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCDrawQuadTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127755 => 127756)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 17:26:07 UTC (rev 127755)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 17:29:05 UTC (rev 127756)
@@ -1,3 +1,26 @@
+2012-09-06 Dana Jansens
+
+[chromium] Add a customized copy() method to CCRenderPassDrawQuad
+https://bugs.webkit.org/show_bug.cgi?id=95871
+
+Reviewed by Adrienne Walker.
+
+CCRenderPassDrawQuad is special because a copied quad will need to
+point to a different RenderPass id, since new ids are given to copied
+RenderPasses. Add a custom copy() method to CCRenderPassDrawQuad that
+takes as input the new RenderPass id that should appear in the copied
+quad.
+
+Test: CCDrawQuad.copyRenderPassDrawQuad
+
+* platform/graphics/chromium/cc/CCDrawQuad.cpp:
+(WebCore::CCDrawQuad::copy):
+* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
+(WebCore::CCRenderPassDrawQuad::copy):
+(WebCore):
+* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
+(CCRenderPassDrawQuad):
+
2012-09-06 Nikhil Bhargava
Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp (127755 => 127756)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp 2012-09-06 17:26:07 UTC (rev 127755)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp 2012-09-06 17:29:05 UTC (rev 127756)
@@ -99,6 +99,9 @@
PassOwnPtr CCDrawQuad::copy(const CCSharedQuadState* copiedSharedQuadState) const
{
+// RenderPass quads have their own copy() method.
+ASSERT(material() != RenderPass);
+
unsigned bytes = size();
ASSERT(bytes);
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp (127755 => 127756)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp 2012-09-06 17:26:07 UTC (rev 127755)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp 2012-09-06 17:29:05 UTC (rev 127756)
@@ -54,4 +54,17 @@
return static_cast(quad);
}
+PassOwnPtr CCRenderPassDrawQuad::copy(const CCSharedQuadState* copiedSharedQuadState, int copiedRenderPassId) const
+{
+unsigned bytes = size();
+ASSERT(bytes);
+
+OwnPtr copyQuad(adoptPtr(reinterpret_cast(new char[bytes])));
+memcpy(copyQuad.get(), this, bytes);
+copyQuad->setSharedQuadState(copiedSharedQuadState);
+copyQuad->m_renderPassId = copiedRenderPassId;
+
+return copyQuad.release();
}
+
+}
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.h (127755 => 127756)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.h 2012-09-06 17:26:07 UTC (rev 127755)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.h 2012-09-06 17:29:05 UTC (rev 127756)
@@ -51,6 +51,8 @@
float maskTexCoordOffsetX() const { return m_maskTexCoordOffsetX; }
float maskTexCoordOffsetY() const { return m_maskTexCoordOffsetY; }
+PassOwnPtr copy(const CCSharedQuadState* copiedSharedQuadState, int copiedRenderPassId) const;
+
private:
CCRenderPassDrawQuad(const CCSharedQuadState*, const IntRect&, int renderPassId, bool isReplica, CCResourceProvider::ResourceId maskResourceId, const IntRect& contentsChangedSinceLastFrame, float maskTexCoordScaleX, float maskTexCoordScaleY, float maskTexCoordOffsetX, float maskTexCoordOffsetY);
Modified: trunk/Source/WebKit/chromium/ChangeLog (127755 => 127756)
--- trunk/Source/
[webkit-changes] [127758] trunk/Source/WebCore
Title: [127758] trunk/Source/WebCore
Revision 127758
Author commit-qu...@webkit.org
Date 2012-09-06 10:44:59 -0700 (Thu, 06 Sep 2012)
Log Message
[CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
https://bugs.webkit.org/show_bug.cgi?id=95891
Patch by Max Vujovic on 2012-09-06
Reviewed by Dean Jackson.
Now we unbind the vertex attributes after a custom filter is applied.
Before this patch, Chromium's GPU process would sometimes print the following error message:
"ERROR:gles2_cmd_decoder.cc(5142)] 002CA47B: GL ERROR :GL_INVALID_OPERATION :
glDrawElements: attempt to render with no buffer attached to enabled attribute 2"
This would happen in the following situation:
1) There are two FECustomFilters on the page.
2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The
detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached
FECustomFilter.
3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound.
4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer
attached to the a_triangleCoord attribute.
No new tests. We can't create an automated test for this because it only reproduces using
Chromium's GPU process. DRT does not use Chromium's GPU process.
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::applyShader):
Unbind the vertex attributes after the drawElements call.
(WebCore::FECustomFilter::unbindVertexAttribute):
(WebCore):
(WebCore::FECustomFilter::unbindVertexAttributes):
Unbind all of the attributes that we bound earlier.
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp
trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127757 => 127758)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 17:36:48 UTC (rev 127757)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 17:44:59 UTC (rev 127758)
@@ -1,3 +1,38 @@
+2012-09-06 Max Vujovic
+
+[CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
+https://bugs.webkit.org/show_bug.cgi?id=95891
+
+Reviewed by Dean Jackson.
+
+Now we unbind the vertex attributes after a custom filter is applied.
+
+Before this patch, Chromium's GPU process would sometimes print the following error message:
+"ERROR:gles2_cmd_decoder.cc(5142)] 002CA47B: GL ERROR :GL_INVALID_OPERATION :
+glDrawElements: attempt to render with no buffer attached to enabled attribute 2"
+
+This would happen in the following situation:
+1) There are two FECustomFilters on the page.
+2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The
+ detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached
+ FECustomFilter.
+3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound.
+4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer
+ attached to the a_triangleCoord attribute.
+
+No new tests. We can't create an automated test for this because it only reproduces using
+Chromium's GPU process. DRT does not use Chromium's GPU process.
+
+* platform/graphics/filters/FECustomFilter.cpp:
+(WebCore::FECustomFilter::applyShader):
+Unbind the vertex attributes after the drawElements call.
+(WebCore::FECustomFilter::unbindVertexAttribute):
+(WebCore):
+(WebCore::FECustomFilter::unbindVertexAttributes):
+Unbind all of the attributes that we bound earlier.
+* platform/graphics/filters/FECustomFilter.h:
+(FECustomFilter):
+
2012-09-05 Sam Weinig
Part 2 of removing PlatformString.h, remove PlatformString.h
Modified: trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp (127757 => 127758)
--- trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp 2012-09-06 17:36:48 UTC (rev 127757)
+++ trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp 2012-09-06 17:44:59 UTC (rev 127758)
@@ -187,6 +187,8 @@
m_context->drawElements(GraphicsContext3D::TRIANGLES, m_mesh->indicesCount(), GraphicsContext3D::UNSIGNED_SHORT, 0);
+unbindVertexAttributes();
+
ASSERT(static_cast(newContextSize.width() * newContextSize.height() * 4) == dstPixelArray->length());
m_context->readPixels(0, 0, newContextSize.width(), newContextSize.height(), GraphicsContext3D::RGBA, GraphicsContext3D::UNSIGNED_BYTE, dstPixelArray->data());
@@ -253,6 +255,12 @@
}
}
+void FECustomFilter::unbindVertexAttribute(int attributeLocation)
+{
+if (attributeLocation != -1)
+m_context->disableVertexAttribArray(attrib
[webkit-changes] [127759] releases/WebKitGTK/webkit-1.10/Source/WebKit2
Title: [127759] releases/WebKitGTK/webkit-1.10/Source/WebKit2
Revision 127759
Author carlo...@webkit.org
Date 2012-09-06 10:52:17 -0700 (Thu, 06 Sep 2012)
Log Message
Merge r127750 - [GTK] [WK2] Crash when navigating between pages
https://bugs.webkit.org/show_bug.cgi?id=95949
Reviewed by Martin Robinson.
Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.
* UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
(didInitiateLoadForResource):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted):
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
Modified Paths
releases/WebKitGTK/webkit-1.10/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp
releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h
Diff
Modified: releases/WebKitGTK/webkit-1.10/Source/WebKit2/ChangeLog (127758 => 127759)
--- releases/WebKitGTK/webkit-1.10/Source/WebKit2/ChangeLog 2012-09-06 17:44:59 UTC (rev 127758)
+++ releases/WebKitGTK/webkit-1.10/Source/WebKit2/ChangeLog 2012-09-06 17:52:17 UTC (rev 127759)
@@ -1,3 +1,22 @@
+2012-09-06 Carlos Garcia Campos
+
+[GTK] [WK2] Crash when navigating between pages
+https://bugs.webkit.org/show_bug.cgi?id=95949
+
+Reviewed by Martin Robinson.
+
+Do not trust isMainResource parameter in
+webkitWebViewResourceLoadStarted(), because it's always true for
+all subresources of pages loaded from the history cache. We can
+simply assume that the first resource loaded for the main frame
+is the main web view resource.
+
+* UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
+(didInitiateLoadForResource):
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewResourceLoadStarted):
+* UIProcess/API/gtk/WebKitWebViewPrivate.h:
+
2012-08-29 José Dapena Paz
[Gtk] Process Gtk 3.4 smooth scroll events properly.
Modified: releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp (127758 => 127759)
--- releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp 2012-09-06 17:44:59 UTC (rev 127758)
+++ releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitResourceLoadClient.cpp 2012-09-06 17:52:17 UTC (rev 127759)
@@ -38,7 +38,7 @@
static void didInitiateLoadForResource(WKPageRef, WKFrameRef wkFrame, uint64_t resourceIdentifier, WKURLRequestRef wkRequest, bool pageIsProvisionallyLoading, const void* clientInfo)
{
GRefPtr request = adoptGRef(webkitURIRequestCreateForResourceRequest(toImpl(wkRequest)->resourceRequest()));
-webkitWebViewResourceLoadStarted(WEBKIT_WEB_VIEW(clientInfo), wkFrame, resourceIdentifier, request.get(), pageIsProvisionallyLoading);
+webkitWebViewResourceLoadStarted(WEBKIT_WEB_VIEW(clientInfo), wkFrame, resourceIdentifier, request.get());
}
static void didSendRequestForResource(WKPageRef, WKFrameRef, uint64_t resourceIdentifier, WKURLRequestRef wkRequest, WKURLResponseRef wkRedirectResponse, const void* clientInfo)
Modified: releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (127758 => 127759)
--- releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-09-06 17:44:59 UTC (rev 127758)
+++ releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-09-06 17:52:17 UTC (rev 127759)
@@ -1311,11 +1311,12 @@
g_signal_connect(priv->mainResource.get(), "notify::response", G_CALLBACK(mainResourceResponseChangedCallback), webView);
}
-void webkitWebViewResourceLoadStarted(WebKitWebView* webView, WKFrameRef wkFrame, uint64_t resourceIdentifier, WebKitURIRequest* request, bool isMainResource)
+void webkitWebViewResourceLoadStarted(WebKitWebView* webView, WKFrameRef wkFrame, uint64_t resourceIdentifier, WebKitURIRequest* request)
{
WebKitWebViewPrivate* priv = webView->priv;
+bool isMainResource = WKFrameIsMainFrame(wkFrame) && !priv->mainResource;
WebKitWebResource* resource = webkitWebResourceCreate(wkFrame, request, isMainResource);
-if (WKFrameIsMainFrame(wkFrame) && (isMainResource || !priv->mainResource)) {
+if (isMainResource) {
priv->mainResource = resource;
waitForMainResourceResponseIfWaitingForResource(webView);
}
Modified: releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h (127758 => 127759)
--- releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h 2012-09-06 17:44:59 UTC (rev 127758)
+++ releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gt
[webkit-changes] [127760] trunk
Title: [127760] trunk Revision 127760 Author zandober...@gmail.com Date 2012-09-06 10:58:42 -0700 (Thu, 06 Sep 2012) Log Message [Gtk] Remove configuration options for features that are not supported by the Gtk port https://bugs.webkit.org/show_bug.cgi?id=87664 Reviewed by Martin Robinson. .: Remove configuration options for features that are completely unsupported by the GTK port. They only bloat the configure.ac file. They should be re-added when the feature becomes supported and introduces an external dependency that the users might want to avoid. * configure.ac: Source/WebCore: Remove addition of macros to feature_defines for features that are completely unsupported by the Gtk port. They're not required anymore since the accompanying configuration flags are also being removed. No new tests - no new functionality. * GNUmakefile.am: * bindings/gobject/GNUmakefile.am: Modified Paths trunk/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/bindings/gobject/GNUmakefile.am trunk/configure.ac Diff Modified: trunk/ChangeLog (127759 => 127760) --- trunk/ChangeLog 2012-09-06 17:52:17 UTC (rev 127759) +++ trunk/ChangeLog 2012-09-06 17:58:42 UTC (rev 127760) @@ -1,3 +1,16 @@ +2012-09-06 Zan Dobersek + +[Gtk] Remove configuration options for features that are not supported by the Gtk port +https://bugs.webkit.org/show_bug.cgi?id=87664 + +Reviewed by Martin Robinson. + +Remove configuration options for features that are completely unsupported by the GTK port. +They only bloat the configure.ac file. They should be re-added when the feature becomes +supported and introduces an external dependency that the users might want to avoid. + +* configure.ac: + 2012-09-06 Simon Hausmann [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2 Modified: trunk/Source/WebCore/ChangeLog (127759 => 127760) --- trunk/Source/WebCore/ChangeLog 2012-09-06 17:52:17 UTC (rev 127759) +++ trunk/Source/WebCore/ChangeLog 2012-09-06 17:58:42 UTC (rev 127760) @@ -1,3 +1,19 @@ +2012-09-06 Zan Dobersek + +[Gtk] Remove configuration options for features that are not supported by the Gtk port +https://bugs.webkit.org/show_bug.cgi?id=87664 + +Reviewed by Martin Robinson. + +Remove addition of macros to feature_defines for features that are completely +unsupported by the Gtk port. They're not required anymore since the accompanying +configuration flags are also being removed. + +No new tests - no new functionality. + +* GNUmakefile.am: +* bindings/gobject/GNUmakefile.am: + 2012-09-06 Max Vujovic [CSS Shaders] Vertex attributes should be unbound after a custom filter is applied Modified: trunk/Source/WebCore/GNUmakefile.am (127759 => 127760) --- trunk/Source/WebCore/GNUmakefile.am 2012-09-06 17:52:17 UTC (rev 127759) +++ trunk/Source/WebCore/GNUmakefile.am 2012-09-06 17:58:42 UTC (rev 127760) @@ -129,15 +129,6 @@ endif # END ENABLE_CHANNEL_MESSAGING # --- -# Fast Mobile Scrolling -# --- -if ENABLE_FAST_MOBILE_SCROLLING -feature_defines_overrides += ENABLE_FAST_MOBILE_SCROLLING=1 -else -feature_defines_overrides += ENABLE_FAST_MOBILE_SCROLLING=0 -endif # END ENABLE_FAST_MOBILE_SCROLLING - -# --- # FreeType font backend # --- if USE_FREETYPE @@ -164,15 +155,6 @@ endif # END TARGET_WIN32 # -# HTML Details Element -# -if ENABLE_DETAILS_ELEMENT -feature_defines_overrides += ENABLE_DETAILS_ELEMENT=1 -else -feature_defines_overrides += ENABLE_DETAILS_ELEMENT=0 -endif # END ENABLE_DETAILS_ELEMENT - -# # HTML Meter Element # if ENABLE_METER_ELEMENT @@ -218,33 +200,6 @@ endif # END ENABLE_SQL_DATABASE # -# HTML5 datalist Support -# -if ENABLE_DATALIST_ELEMENT -feature_defines_overrides += ENABLE_DATALIST_ELEMENT=1 -else -feature_defines_overrides += ENABLE_DATALIST_ELEMENT=0 -endif # END ENABLE_DATALIST_ELEMENT - -# -# HTML5 data transfer items support -# -if ENABLE_DATA_TRANSFER_ITEMS -feature_defines_overrides += ENABLE_DATA_TRANSFER_ITEMS=1 -else -feature_defines_overrides += ENABLE_DATA_TRANSFER_ITEMS=0 -endif # END ENABLE_DATA_TRANSFER_ITEMS - -# -# HTML5
[webkit-changes] [127761] trunk/Source/WTF
Title: [127761] trunk/Source/WTF
Revision 127761
Author par...@webkit.org
Date 2012-09-06 11:06:02 -0700 (Thu, 06 Sep 2012)
Log Message
Fix export macros in IntegerToStringConversion.h
https://bugs.webkit.org/show_bug.cgi?id=95900
Reviewed by Benjamin Poulain.
The WTF_EXPORT_STRING_API must be used only for symbols which are compiled
on windows in "non-WTF" binaries too. Since this isn't valid for the
IntegerToStringConversion function replace it with WTF_EXPORT_PRIVATE.
* wtf/text/IntegerToStringConversion.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/IntegerToStringConversion.h
Diff
Modified: trunk/Source/WTF/ChangeLog (127760 => 127761)
--- trunk/Source/WTF/ChangeLog 2012-09-06 17:58:42 UTC (rev 127760)
+++ trunk/Source/WTF/ChangeLog 2012-09-06 18:06:02 UTC (rev 127761)
@@ -1,3 +1,16 @@
+2012-09-06 Patrick Gansterer
+
+Fix export macros in IntegerToStringConversion.h
+https://bugs.webkit.org/show_bug.cgi?id=95900
+
+Reviewed by Benjamin Poulain.
+
+The WTF_EXPORT_STRING_API must be used only for symbols which are compiled
+on windows in "non-WTF" binaries too. Since this isn't valid for the
+IntegerToStringConversion function replace it with WTF_EXPORT_PRIVATE.
+
+* wtf/text/IntegerToStringConversion.h:
+
2012-09-06 Simon Hausmann
[Qt] Various small Windows / MSVC build fixes
Modified: trunk/Source/WTF/wtf/text/IntegerToStringConversion.h (127760 => 127761)
--- trunk/Source/WTF/wtf/text/IntegerToStringConversion.h 2012-09-06 17:58:42 UTC (rev 127760)
+++ trunk/Source/WTF/wtf/text/IntegerToStringConversion.h 2012-09-06 18:06:02 UTC (rev 127761)
@@ -24,13 +24,15 @@
#include "StringImpl.h"
namespace WTF {
-WTF_EXPORT_STRING_API PassRefPtr numberToStringImpl(int);
-WTF_EXPORT_STRING_API PassRefPtr numberToStringImpl(long);
-WTF_EXPORT_STRING_API PassRefPtr numberToStringImpl(long long);
-WTF_EXPORT_STRING_API PassRefPtr numberToStringImpl(unsigned);
-WTF_EXPORT_STRING_API PassRefPtr numberToStringImpl(unsigned long);
-WTF_EXPORT_STRING_API PassRefPtr numberToStringImpl(unsigned long long);
-}
+WTF_EXPORT_PRIVATE PassRefPtr numberToStringImpl(int);
+WTF_EXPORT_PRIVATE PassRefPtr numberToStringImpl(long);
+WTF_EXPORT_PRIVATE PassRefPtr numberToStringImpl(long long);
+WTF_EXPORT_PRIVATE PassRefPtr numberToStringImpl(unsigned);
+WTF_EXPORT_PRIVATE PassRefPtr numberToStringImpl(unsigned long);
+WTF_EXPORT_PRIVATE PassRefPtr numberToStringImpl(unsigned long long);
+
+} // namespace WTF
+
#endif // IntegerToStringConversion_h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127762] trunk/Source/WebCore
Title: [127762] trunk/Source/WebCore
Revision 127762
Author jam...@google.com
Date 2012-09-06 11:13:21 -0700 (Thu, 06 Sep 2012)
Log Message
SharedGraphicsContext3D shouldn't depend on CCProxy
https://bugs.webkit.org/show_bug.cgi?id=95921
Reviewed by Adrienne Walker.
This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
code in WTF to do that.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127761 => 127762)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 18:06:02 UTC (rev 127761)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 18:13:21 UTC (rev 127762)
@@ -1,3 +1,18 @@
+2012-09-05 James Robinson
+
+SharedGraphicsContext3D shouldn't depend on CCProxy
+https://bugs.webkit.org/show_bug.cgi?id=95921
+
+Reviewed by Adrienne Walker.
+
+This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
+code in WTF to do that.
+
+* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+(WebCore::SharedGraphicsContext3D::getForImplThread):
+(WebCore::SharedGraphicsContext3D::haveForImplThread):
+(WebCore::SharedGraphicsContext3D::createForImplThread):
+
2012-09-06 Zan Dobersek
[Gtk] Remove configuration options for features that are not supported by the Gtk port
Modified: trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp (127761 => 127762)
--- trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp 2012-09-06 18:06:02 UTC (rev 127761)
+++ trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp 2012-09-06 18:13:21 UTC (rev 127762)
@@ -28,8 +28,8 @@
#include "SharedGraphicsContext3D.h"
-#include "CCProxy.h"
#include "Extensions3D.h"
+#include
namespace WebCore {
@@ -89,19 +89,19 @@
PassRefPtr SharedGraphicsContext3D::getForImplThread()
{
-ASSERT(CCProxy::isImplThread());
+ASSERT(!isMainThread());
return getOrCreateContextForImplThread(Get);
}
bool SharedGraphicsContext3D::haveForImplThread()
{
-ASSERT(CCProxy::isMainThread());
+ASSERT(isMainThread());
return getOrCreateContextForImplThread(Get);
}
bool SharedGraphicsContext3D::createForImplThread()
{
-ASSERT(CCProxy::isMainThread());
+ASSERT(isMainThread());
return getOrCreateContextForImplThread(Create);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127763] trunk/LayoutTests
Title: [127763] trunk/LayoutTests Revision 127763 Author zandober...@gmail.com Date 2012-09-06 11:16:31 -0700 (Thu, 06 Sep 2012) Log Message Unreviewed GTK gardening. Generating required platform-specific baselines after r127608. Adding failure expectations for regressions introduced in r127698 and r127704. Fixing and removing duplicate expectations to get the file to pass linting. * platform/gtk/TestExpectations: * platform/gtk/css3/masking: Added. * platform/gtk/css3/masking/clip-path-circle-expected.png: Added. * platform/gtk/css3/masking/clip-path-circle-expected.txt: Added. * platform/gtk/css3/masking/clip-path-circle-filter-expected.png: Added. * platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Added. * platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Added. * platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Added. * platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added. * platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added. * platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.png: Added. * platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added. * platform/gtk/css3/masking/clip-path-ellipse-expected.png: Added. * platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Added. * platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.png: Added. * platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Added. * platform/gtk/css3/masking/clip-path-polygon-expected.png: Added. * platform/gtk/css3/masking/clip-path-polygon-expected.txt: Added. * platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.png: Added. * platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Added. * platform/gtk/css3/masking/clip-path-rectangle-expected.png: Added. * platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Added Paths trunk/LayoutTests/platform/gtk/css3/masking/ trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-filter-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-filter-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-overflow-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-ellipse-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-ellipse-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-polygon-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-polygon-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt trunk/LayoutTests/platform/gtk/css3/masking/clip-path-rectangle-expected.png trunk/LayoutTests/platform/gtk/css3/masking/clip-path-rectangle-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127762 => 127763) --- trunk/LayoutTests/ChangeLog 2012-09-06 18:13:21 UTC (rev 127762) +++ trunk/LayoutTests/ChangeLog 2012-09-06 18:16:31 UTC (rev 127763) @@ -1,3 +1,36 @@ +2012-09-06 Zan Dobersek + +Unreviewed GTK gardening. + +Generating required platform-specific baselines after r127608. + +Adding failure expectations for regressions introduced in r127698 and r127704. + +Fixing and removing duplicate expectations to get the file to pass linting. + +* platform/gtk/TestExpectations: +* platform/gtk/css3/masking: Added. +* platform/gtk/css3/masking/clip-path-circle-expected.png: Added. +* platform/gtk/css3/masking/clip-path-circle-expected.txt: Added. +* platform/gtk/css3/masking/clip-path-circle-filter-expected.png: Added. +* platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Added. +* platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Added. +* platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Added. +* platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added. +* platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: A
[webkit-changes] [127764] trunk/Source/WebCore
Title: [127764] trunk/Source/WebCore Revision 127764 Author zandober...@gmail.com Date 2012-09-06 11:40:19 -0700 (Thu, 06 Sep 2012) Log Message Unreviewed GTK build fix. CSS Compositing is not currently supported on the GTK port, so the feature define should default to 0. * GNUmakefile.features.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.features.am Diff Modified: trunk/Source/WebCore/ChangeLog (127763 => 127764) --- trunk/Source/WebCore/ChangeLog 2012-09-06 18:16:31 UTC (rev 127763) +++ trunk/Source/WebCore/ChangeLog 2012-09-06 18:40:19 UTC (rev 127764) @@ -1,3 +1,12 @@ +2012-09-06 Zan Dobersek + +Unreviewed GTK build fix. + +CSS Compositing is not currently supported on the GTK port, so +the feature define should default to 0. + +* GNUmakefile.features.am: + 2012-09-05 James Robinson SharedGraphicsContext3D shouldn't depend on CCProxy Modified: trunk/Source/WebCore/GNUmakefile.features.am (127763 => 127764) --- trunk/Source/WebCore/GNUmakefile.features.am 2012-09-06 18:16:31 UTC (rev 127763) +++ trunk/Source/WebCore/GNUmakefile.features.am 2012-09-06 18:40:19 UTC (rev 127764) @@ -7,7 +7,7 @@ ENABLE_CHANNEL_MESSAGING=1 \ ENABLE_CSP_NEXT=0 \ ENABLE_CSS_BOX_DECORATION_BREAK=1 \ - ENABLE_CSS_COMPOSITING=1 \ + ENABLE_CSS_COMPOSITING=0 \ ENABLE_CSS_EXCLUSIONS=1 \ ENABLE_CSS_FILTERS=0 \ ENABLE_CSS_HIERARCHIES=0 \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127765] trunk/Source/WebCore
Title: [127765] trunk/Source/WebCore
Revision 127765
Author wei...@apple.com
Date 2012-09-06 11:43:12 -0700 (Thu, 06 Sep 2012)
Log Message
Fix one of the Qt builds.
* dom/TransformSource.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/TransformSource.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127764 => 127765)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 18:40:19 UTC (rev 127764)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 18:43:12 UTC (rev 127765)
@@ -1,3 +1,9 @@
+2012-09-06 Sam Weinig
+
+Fix one of the Qt builds.
+
+* dom/TransformSource.h:
+
2012-09-06 Zan Dobersek
Unreviewed GTK build fix.
Modified: trunk/Source/WebCore/dom/TransformSource.h (127764 => 127765)
--- trunk/Source/WebCore/dom/TransformSource.h 2012-09-06 18:40:19 UTC (rev 127764)
+++ trunk/Source/WebCore/dom/TransformSource.h 2012-09-06 18:43:12 UTC (rev 127765)
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127767] trunk/Source
Title: [127767] trunk/Source
Revision 127767
Author rjkro...@chromium.org
Date 2012-09-06 11:54:37 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Enable different fling behaviour for touchscreen and touchpad
https://bugs.webkit.org/show_bug.cgi?id=95756
Reviewed by James Robinson.
Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
events by their originating device and pass this flag to a factory that produces
different device specific fling curves based on the value of the flag.
Source/WebCore:
Covered by existing layout and unit tests.
* platform/chromium/support/PlatformGestureCurveFactory.cpp: Modified factory
entry point for constructing fling curve for different devices.
(WebKit::PlatformGestureCurveFactory::createCurve):
* platform/chromium/support/PlatformGestureCurveFactory.h:
(PlatformGestureCurveFactory):
Source/WebKit/chromium:
* public/WebActiveWheelFlingParameters.h:
(WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):
* public/WebInputEvent.h: Added source device flag to WebGestureEvent.
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to
obtain device-appropriate fling curve.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
fling curve.
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/support/PlatformGestureCurveFactory.cpp
trunk/Source/WebCore/platform/chromium/support/PlatformGestureCurveFactory.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebActiveWheelFlingParameters.h
trunk/Source/WebKit/chromium/public/WebInputEvent.h
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127766 => 127767)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 18:50:55 UTC (rev 127766)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 18:54:37 UTC (rev 127767)
@@ -1,3 +1,22 @@
+2012-09-06 Robert Kroeger
+
+[chromium] Enable different fling behaviour for touchscreen and touchpad
+https://bugs.webkit.org/show_bug.cgi?id=95756
+
+Reviewed by James Robinson.
+
+Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
+events by their originating device and pass this flag to a factory that produces
+different device specific fling curves based on the value of the flag.
+
+Covered by existing layout and unit tests.
+
+* platform/chromium/support/PlatformGestureCurveFactory.cpp: Modified factory
+entry point for constructing fling curve for different devices.
+(WebKit::PlatformGestureCurveFactory::createCurve):
+* platform/chromium/support/PlatformGestureCurveFactory.h:
+(PlatformGestureCurveFactory):
+
2012-09-06 Tommy Widenflycht
MediaStream API: Add the local and remote description functionality to RTCPeerConnection
Modified: trunk/Source/WebCore/platform/chromium/support/PlatformGestureCurveFactory.cpp (127766 => 127767)
--- trunk/Source/WebCore/platform/chromium/support/PlatformGestureCurveFactory.cpp 2012-09-06 18:50:55 UTC (rev 127766)
+++ trunk/Source/WebCore/platform/chromium/support/PlatformGestureCurveFactory.cpp 2012-09-06 18:54:37 UTC (rev 127767)
@@ -24,12 +24,14 @@
*/
#include "config.h"
+
#include "PlatformGestureCurveFactory.h"
#include "FloatPoint.h"
#include "IntRect.h"
#include "TouchpadFlingPlatformGestureCurve.h"
#include "WebFlingAnimatorToGestureCurveAdapter.h"
+#include "WebInputEvent.h"
namespace WebKit {
@@ -39,15 +41,20 @@
return &factory;
}
-PassOwnPtr PlatformGestureCurveFactory::createCurve(const WebCore::FloatPoint& point, const WebCore::IntRect& range)
+PassOwnPtr PlatformGestureCurveFactory::createCurve(int deviceSource, const WebCore::FloatPoint& point, WebCore::IntPoint cumulativeScroll)
{
OwnPtr flingAnimator = m_mockFlingAnimator.release();
if (!flingAnimator)
flingAnimator = adoptPtr(Platform::current()->createFlingAnimator());
-if (!flingAnimator)
-return WebCore::TouchpadFlingPlatformGestureCurve::create(point);
-return WebFlingAnimatorToGestureCurveAdapter::create(point, range, flingAnimator.release());
+if (flingAnimator)
+return WebFlingAnimatorToGestureCurveAdapter::create(point, WebCore::IntRect(), flingAnimator.release());
+
+// FIXME: Add a touch-screen sourced specific curve.
+if (deviceSource == WebGestureEvent::Touchscreen)
+return WebCore::TouchpadFlingPlatformGestureCurve::create(point, cumulativeScroll);
+
+return WebCore::TouchpadFlingPlatformGestureCurve::create(point, cumulativeScroll);
}
void PlatformGestureCurveFactory:
[webkit-changes] [127768] trunk/LayoutTests
Title: [127768] trunk/LayoutTests Revision 127768 Author roger_f...@apple.com Date 2012-09-06 12:02:20 -0700 (Thu, 06 Sep 2012) Log Message Unreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecution.html https://bugs.webkit.org/show_bug.cgi?id=95944 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127767 => 127768) --- trunk/LayoutTests/ChangeLog 2012-09-06 18:54:37 UTC (rev 127767) +++ trunk/LayoutTests/ChangeLog 2012-09-06 19:02:20 UTC (rev 127768) @@ -1,3 +1,10 @@ +2012-09-06 Roger Fong + +Unreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecution.html +https://bugs.webkit.org/show_bug.cgi?id=95944 + +* platform/win/Skipped: + 2012-09-06 Tommy Widenflycht MediaStream API: Add the local and remote description functionality to RTCPeerConnection Modified: trunk/LayoutTests/platform/win/Skipped (127767 => 127768) --- trunk/LayoutTests/platform/win/Skipped 2012-09-06 18:54:37 UTC (rev 127767) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-06 19:02:20 UTC (rev 127768) @@ -2214,3 +2214,6 @@ media/video-src-change.html media/video-timeupdate-reverse-play.html media/W3C/video/src/src_removal_does_not_trigger_loadstart.html + +# https://bugs.webkit.org/show_bug.cgi?id=95944 +fast/dom/HTMLScriptElement/script-reexecution.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127769] trunk
Title: [127769] trunk
Revision 127769
Author dbar...@mathscribe.com
Date 2012-09-06 12:04:55 -0700 (Thu, 06 Sep 2012)
Log Message
mathml.css: Add more { white-space: nowrap } declarations
https://bugs.webkit.org/show_bug.cgi?id=95404
Reviewed by Eric Seidel.
mathml.css declared { white-space: nowrap } for mrow, mfenced, msqrt. It is also needed
for other tags such as msub, msup, msubsup.
Added a test to mathml/presentation/sup.xhtml, and a regression test to roots.xhtml.
Source/WebCore:
* css/mathml.css:
(mo, mrow, mfenced, mfrac, msub, msup, msubsup, munder, mover, munderover, msqrt, mroot):
LayoutTests:
* mathml/presentation/roots.xhtml:
* mathml/presentation/sup.xhtml:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/sup-expected.png:
* platform/mac/mathml/presentation/sup-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/mathml/presentation/roots.xhtml
trunk/LayoutTests/mathml/presentation/sup.xhtml
trunk/LayoutTests/platform/mac/mathml/presentation/roots-expected.png
trunk/LayoutTests/platform/mac/mathml/presentation/roots-expected.txt
trunk/LayoutTests/platform/mac/mathml/presentation/sup-expected.png
trunk/LayoutTests/platform/mac/mathml/presentation/sup-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mathml.css
Diff
Modified: trunk/LayoutTests/ChangeLog (127768 => 127769)
--- trunk/LayoutTests/ChangeLog 2012-09-06 19:02:20 UTC (rev 127768)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 19:04:55 UTC (rev 127769)
@@ -1,3 +1,22 @@
+2012-09-06 David Barton
+
+mathml.css: Add more { white-space: nowrap } declarations
+https://bugs.webkit.org/show_bug.cgi?id=95404
+
+Reviewed by Eric Seidel.
+
+mathml.css declared { white-space: nowrap } for mrow, mfenced, msqrt. It is also needed
+for other tags such as msub, msup, msubsup.
+
+Added a test to mathml/presentation/sup.xhtml, and a regression test to roots.xhtml.
+
+* mathml/presentation/roots.xhtml:
+* mathml/presentation/sup.xhtml:
+* platform/mac/mathml/presentation/roots-expected.png:
+* platform/mac/mathml/presentation/roots-expected.txt:
+* platform/mac/mathml/presentation/sup-expected.png:
+* platform/mac/mathml/presentation/sup-expected.txt:
+
2012-09-06 Roger Fong
Unreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecution.html
Modified: trunk/LayoutTests/mathml/presentation/roots.xhtml (127768 => 127769)
--- trunk/LayoutTests/mathml/presentation/roots.xhtml 2012-09-06 19:02:20 UTC (rev 127768)
+++ trunk/LayoutTests/mathml/presentation/roots.xhtml 2012-09-06 19:04:55 UTC (rev 127769)
@@ -2,6 +2,9 @@
Roots
+ body {
+ overflow: hidden;
+ }
@@ -168,5 +171,15 @@
+
+Don't wrap this wide line with an implicit mrow:
+
+
+ x
+ y
+
+
+
+
\ No newline at end of file
Modified: trunk/LayoutTests/mathml/presentation/sup.xhtml (127768 => 127769)
--- trunk/LayoutTests/mathml/presentation/sup.xhtml 2012-09-06 19:02:20 UTC (rev 127768)
+++ trunk/LayoutTests/mathml/presentation/sup.xhtml 2012-09-06 19:04:55 UTC (rev 127769)
@@ -1,6 +1,11 @@
Superscripts
+
+ body {
+ overflow: hidden;
+ }
+
superscript:
@@ -8,5 +13,16 @@
x2
+
+For -
+ mathml.css: Add more { white-space: nowrap } declarations:
+
+
+ x
+ y
+
+
+
+
Modified: trunk/LayoutTests/platform/mac/mathml/presentation/roots-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/mathml/presentation/roots-expected.txt (127768 => 127769)
--- trunk/LayoutTests/platform/mac/mathml/presentation/roots-expected.txt 2012-09-06 19:02:20 UTC (rev 127768)
+++ trunk/LayoutTests/platform/mac/mathml/presentation/roots-expected.txt 2012-09-06 19:04:55 UTC (rev 127769)
@@ -1,8 +1,8 @@
-layer at (0,0) size 800x600
+layer at (0,0) size 836x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x496
- RenderBlock {html} at (0,0) size 800x496
-RenderBody {body} at (8,16) size 784x464
+layer at (0,0) size 800x548
+ RenderBlock {html} at (0,0) size 800x548
+RenderBody {body} at (8,16) size 784x516
RenderBlock {p} at (0,0) size 784x18
RenderText {#text} at (0,0) size 177x18
text run at (0,0) width 177: "square root (should be red): "
@@ -181,6 +181,20 @@
text run at (0,34) width 110: "Imbricated roots: "
RenderMathMLMath {math} at (110,0) size 295x70 [padding: 0 1 0 1]
RenderText {#text} at (0,0) size 0x0
+ RenderBlock {p} at (0,480) size 784x36
+RenderText {#text} at (0,0) size 306x18
+ text run at (0,0) width 306: "Don't wrap this wide line with an implicit mrow:"
+RenderBR {br} at (306,0) size 0x18
+RenderMathMLMath {math} at (0,21) size 828x15 [padding: 0 1 0 1]
+ RenderMathMLSq
[webkit-changes] [127770] trunk/LayoutTests
Title: [127770] trunk/LayoutTests
Revision 127770
Author roger_f...@apple.com
Date 2012-09-06 12:16:02 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed. Skipping failing test: fast/forms/number/number-interactive-validation-required.html
Interactive form validation is not enabled on Windows. It's fine to skip this test.
* platform/win/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (127769 => 127770)
--- trunk/LayoutTests/ChangeLog 2012-09-06 19:04:55 UTC (rev 127769)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 19:16:02 UTC (rev 127770)
@@ -1,3 +1,10 @@
+2012-09-06 Roger Fong
+
+Unreviewed. Skipping failing test: fast/forms/number/number-interactive-validation-required.html
+Interactive form validation is not enabled on Windows. It's fine to skip this test.
+
+* platform/win/Skipped:
+
2012-09-06 David Barton
mathml.css: Add more { white-space: nowrap } declarations
Modified: trunk/LayoutTests/platform/win/Skipped (127769 => 127770)
--- trunk/LayoutTests/platform/win/Skipped 2012-09-06 19:04:55 UTC (rev 127769)
+++ trunk/LayoutTests/platform/win/Skipped 2012-09-06 19:16:02 UTC (rev 127770)
@@ -2217,3 +2217,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=95944
fast/dom/HTMLScriptElement/script-reexecution.html
+
+# Interactive form validation not enabled on Windows
+fast/forms/number/number-interactive-validation-required.html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127771] trunk/Source/WebCore
Title: [127771] trunk/Source/WebCore
Revision 127771
Author zandober...@gmail.com
Date 2012-09-06 12:20:48 -0700 (Thu, 06 Sep 2012)
Log Message
Another unreviewed GTK build fix.
The ENABLE_DATALIST_ELEMENT should default to 0, as it did in stable
release versions before r127760. The feature define can be switched
on later, when its stability is determined and the test results are
rebaselined.
* GNUmakefile.features.am:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.features.am
Diff
Modified: trunk/Source/WebCore/ChangeLog (127770 => 127771)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 19:16:02 UTC (rev 127770)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 19:20:48 UTC (rev 127771)
@@ -1,3 +1,14 @@
+2012-09-06 Zan Dobersek
+
+Another unreviewed GTK build fix.
+
+The ENABLE_DATALIST_ELEMENT should default to 0, as it did in stable
+release versions before r127760. The feature define can be switched
+on later, when its stability is determined and the test results are
+rebaselined.
+
+* GNUmakefile.features.am:
+
2012-09-06 David Barton
mathml.css: Add more { white-space: nowrap } declarations
Modified: trunk/Source/WebCore/GNUmakefile.features.am (127770 => 127771)
--- trunk/Source/WebCore/GNUmakefile.features.am 2012-09-06 19:16:02 UTC (rev 127770)
+++ trunk/Source/WebCore/GNUmakefile.features.am 2012-09-06 19:20:48 UTC (rev 127771)
@@ -18,7 +18,7 @@
ENABLE_CSS_VARIABLES=0 \
ENABLE_CUSTOM_SCHEME_HANDLER=0 \
ENABLE_DASHBOARD_SUPPORT=0 \
- ENABLE_DATALIST_ELEMENT=1 \
+ ENABLE_DATALIST_ELEMENT=0 \
ENABLE_DATA_TRANSFER_ITEMS=0 \
ENABLE_DETAILS_ELEMENT=1 \
ENABLE_DEVICE_ORIENTATION=0 \
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127772] trunk/Source/WebKit/blackberry
Title: [127772] trunk/Source/WebKit/blackberry Revision 127772 Author toniki...@webkit.org Date 2012-09-06 12:22:23 -0700 (Thu, 06 Sep 2012) Log Message [BlackBerry] Allow overscroll to composited scroll layers https://bugs.webkit.org/show_bug.cgi?id=95998 PR #195305 Reviewed by Rob Buis. Patch by Antonio Gomes Internally reviewed by Gen Mak. No need to reset the overscroll limit factor at creation to 0. It is already 0 by default, and later on the client sets the appropriated value. * WebKitSupport/InRegionScrollableArea.cpp: (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): Modified Paths trunk/Source/WebKit/blackberry/ChangeLog trunk/Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp Diff Modified: trunk/Source/WebKit/blackberry/ChangeLog (127771 => 127772) --- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-06 19:20:48 UTC (rev 127771) +++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-06 19:22:23 UTC (rev 127772) @@ -1,3 +1,19 @@ +2012-09-06 Antonio Gomes + +[BlackBerry] Allow overscroll to composited scroll layers +https://bugs.webkit.org/show_bug.cgi?id=95998 +PR #195305 + +Reviewed by Rob Buis. +Internally reviewed by Gen Mak. + +No need to reset the overscroll limit factor at creation to 0. +It is already 0 by default, and later on the client sets the +appropriated value. + +* WebKitSupport/InRegionScrollableArea.cpp: +(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): + 2012-09-05 Sam Weinig Part 2 of removing PlatformString.h, remove PlatformString.h Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp (127771 => 127772) --- trunk/Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp 2012-09-06 19:20:48 UTC (rev 127771) +++ trunk/Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp 2012-09-06 19:22:23 UTC (rev 127772) @@ -75,7 +75,6 @@ m_scrollsHorizontally = view->contentsWidth() > view->visibleWidth(); m_scrollsVertically = view->contentsHeight() > view->visibleHeight(); -m_overscrollLimitFactor = 0.0; // FIXME eventually support overscroll m_camouflagedCompositedScrollableLayer = reinterpret_cast(m_layer->enclosingElement()); // FIXME: Needs composited layer for inner frames. m_cachedNonCompositedScrollableNode = m_layer->enclosingElement(); @@ -105,8 +104,6 @@ m_cachedNonCompositedScrollableNode = m_layer->enclosingElement(); ASSERT(!m_cachedCompositedScrollableLayer); } - -m_overscrollLimitFactor = 0.0; } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127774] trunk/Source/JavaScriptCore
Title: [127774] trunk/Source/_javascript_Core Revision 127774 Author gga...@apple.com Date 2012-09-06 12:45:35 -0700 (Thu, 06 Sep 2012) Log Message Rolled out because it broke fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html Named functions should not allocate scope objects for their names https://bugs.webkit.org/show_bug.cgi?id=95659 Reviewed by Oliver Hunt. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/dfg/DFGOperations.cpp trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp trunk/Source/_javascript_Core/parser/Parser.cpp trunk/Source/_javascript_Core/parser/Parser.h trunk/Source/_javascript_Core/runtime/Executable.cpp trunk/Source/_javascript_Core/runtime/Executable.h trunk/Source/_javascript_Core/runtime/JSNameScope.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (127773 => 127774) --- trunk/Source/_javascript_Core/ChangeLog 2012-09-06 19:29:40 UTC (rev 127773) +++ trunk/Source/_javascript_Core/ChangeLog 2012-09-06 19:45:35 UTC (rev 127774) @@ -1,3 +1,13 @@ +2012-09-05 Geoffrey Garen + +Rolled out because it broke +fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html + +Named functions should not allocate scope objects for their names +https://bugs.webkit.org/show_bug.cgi?id=95659 + +Reviewed by Oliver Hunt. + 2012-09-06 Mark Lam Renamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in @@ -26,97 +36,6 @@ * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): -2012-09-05 Geoffrey Garen - -Named functions should not allocate scope objects for their names -https://bugs.webkit.org/show_bug.cgi?id=95659 - -Reviewed by Oliver Hunt. - -In most cases, we can merge a function _expression_'s name into its symbol -table. This reduces memory footprint per closure from three objects -(function + activation + name scope) to two (function + activation), -speeds up closure allocation, and speeds up recursive calls. - -In the case of a named function _expression_ that contains a non-strict -eval, the rules are so bat-poop crazy that I don't know how to model -them without an extra object. Since functions now default to not having -such an object, this case needs to allocate the object on function -entry. - -Therefore, this patch makes the slow case a bit slower so the fast case -can be faster and more memory-efficient. (Note that the slow case already -allocates an activation on entry, and until recently also allocated a -scope chain node on entry, so adding one allocation on entry shouldn't -break the bank.) - -* bytecode/CodeBlock.cpp: -(JSC::CodeBlock::CodeBlock): Caught a missed initializer. No behavior change. - -* bytecompiler/BytecodeGenerator.cpp: -(JSC::BytecodeGenerator::BytecodeGenerator): Put the callee in static scope -during compilation so it doesn't need to be in dynamic scope at runtime. - -(JSC::BytecodeGenerator::resolveCallee): -(JSC::BytecodeGenerator::addCallee): Helper functions for either statically -resolving the callee or adding a dynamic scope that will resolve to it, -depending on whether you're in the fast path. - -We move the callee into a var location if it's captured because activations -prefer to have contiguous ranges of captured variables. - -* bytecompiler/BytecodeGenerator.h: -(JSC::BytecodeGenerator::registerFor): -(BytecodeGenerator): - -* dfg/DFGOperations.cpp: -* interpreter/Interpreter.cpp: -(JSC::Interpreter::privateExecute): -* jit/JITStubs.cpp: -(JSC::DEFINE_STUB_FUNCTION): -* llint/LLIntSlowPaths.cpp: -(JSC::LLInt::LLINT_SLOW_PATH_DECL): This is the point of the patch: remove -one allocation in the case of a named function _expression_. - -* parser/Parser.cpp: -(JSCParser): -* parser/Parser.h: -(JSC::Scope::declareCallee): -(Scope): -(Parser): -(JSC::parse): -* runtime/Executable.cpp: -(JSC::EvalExecutable::compileInternal): -(JSC::ProgramExecutable::checkSyntax): -(JSC::ProgramExecutable::compileInternal): -(JSC::FunctionExecutable::produceCodeBlockFor): -(JSC::FunctionExecutable::fromGlobalCode): Pipe the callee's name through -the parser so we get accurate information on whether the callee was captured. - -(JSC::FunctionExecutable::Functio
[webkit-changes] [127775] trunk/Tools
Title: [127775] trunk/Tools
Revision 127775
Author benja...@webkit.org
Date 2012-09-06 12:50:18 -0700 (Thu, 06 Sep 2012)
Log Message
Fix WTF.Lrint on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=96003
Patch by Fady Samuel on 2012-09-06
Reviewed by Benjamin Poulain.
Fixed failing WTF.Lrint test on 32-bit platforms.
* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp
Diff
Modified: trunk/Tools/ChangeLog (127774 => 127775)
--- trunk/Tools/ChangeLog 2012-09-06 19:45:35 UTC (rev 127774)
+++ trunk/Tools/ChangeLog 2012-09-06 19:50:18 UTC (rev 127775)
@@ -1,3 +1,15 @@
+2012-09-06 Fady Samuel
+
+Fix WTF.Lrint on 32-bit platforms
+https://bugs.webkit.org/show_bug.cgi?id=96003
+
+Reviewed by Benjamin Poulain.
+
+Fixed failing WTF.Lrint test on 32-bit platforms.
+
+* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
+(TestWebKitAPI::TEST):
+
2012-09-06 Tommy Widenflycht
MediaStream API: Add the local and remote description functionality to RTCPeerConnection
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp (127774 => 127775)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp 2012-09-06 19:45:35 UTC (rev 127774)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp 2012-09-06 19:50:18 UTC (rev 127775)
@@ -40,12 +40,14 @@
EXPECT_EQ(lrint(1.7), 2);
EXPECT_EQ(lrint(0), 0);
EXPECT_EQ(lrint(-0), 0);
-// Largest double number with 0.5 precision and one halfway rounding case below.
-EXPECT_EQ(lrint(pow(2.0, 52) - 0.5), pow(2.0, 52));
-EXPECT_EQ(lrint(pow(2.0, 52) - 1.5), pow(2.0, 52) - 2);
-// Smallest double number with 0.5 precision and one halfway rounding case above.
-EXPECT_EQ(lrint(-pow(2.0, 52) + 0.5), -pow(2.0, 52));
-EXPECT_EQ(lrint(-pow(2.0, 52) + 1.5), -pow(2.0, 52) + 2);
+if (sizeof(long int) == 8) {
+// Largest double number with 0.5 precision and one halfway rounding case below.
+EXPECT_EQ(lrint(pow(2.0, 52) - 0.5), pow(2.0, 52));
+EXPECT_EQ(lrint(pow(2.0, 52) - 1.5), pow(2.0, 52) - 2);
+// Smallest double number with 0.5 precision and one halfway rounding case above.
+EXPECT_EQ(lrint(-pow(2.0, 52) + 0.5), -pow(2.0, 52));
+EXPECT_EQ(lrint(-pow(2.0, 52) + 1.5), -pow(2.0, 52) + 2);
+}
}
} // namespace TestWebKitAPI
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127776] trunk/Source/WebKit/chromium
Title: [127776] trunk/Source/WebKit/chromium Revision 127776 Author commit-qu...@webkit.org Date 2012-09-06 12:52:07 -0700 (Thu, 06 Sep 2012) Log Message [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret https://bugs.webkit.org/show_bug.cgi?id=93998 Patch by Iain Merrick on 2012-09-06 Reviewed by Adam Barth. These provide the same functionality selectRange(WebPoint, WebPoint), with finer-grained control needed on the Android platform. By passing allowCollapsedSelection=false, we can ensure the selection stays at least one character wide. I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by calling the new methods. The existing test passes, and I've added new tests for the new methods. * public/WebFrame.h: (WebFrame): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectRange): (WebKit): (WebKit::WebFrameImpl::moveSelectionStart): (WebKit::WebFrameImpl::moveSelectionEnd): (WebKit::WebFrameImpl::moveCaret): * src/WebFrameImpl.h: (WebFrameImpl): * tests/WebFrameTest.cpp: * tests/data/text_selection.html: Added. Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebFrame.h trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp trunk/Source/WebKit/chromium/src/WebFrameImpl.h trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp Added Paths trunk/Source/WebKit/chromium/tests/data/text_selection.html Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (127775 => 127776) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 19:50:18 UTC (rev 127775) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 19:52:07 UTC (rev 127776) @@ -1,3 +1,32 @@ +2012-09-06 Iain Merrick + +[chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret +https://bugs.webkit.org/show_bug.cgi?id=93998 + +Reviewed by Adam Barth. + +These provide the same functionality selectRange(WebPoint, WebPoint), +with finer-grained control needed on the Android platform. By passing +allowCollapsedSelection=false, we can ensure the selection stays at +least one character wide. + +I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by +calling the new methods. The existing test passes, and I've added new +tests for the new methods. + +* public/WebFrame.h: +(WebFrame): +* src/WebFrameImpl.cpp: +(WebKit::WebFrameImpl::selectRange): +(WebKit): +(WebKit::WebFrameImpl::moveSelectionStart): +(WebKit::WebFrameImpl::moveSelectionEnd): +(WebKit::WebFrameImpl::moveCaret): +* src/WebFrameImpl.h: +(WebFrameImpl): +* tests/WebFrameTest.cpp: +* tests/data/text_selection.html: Added. + 2012-09-06 Robert Kroeger [chromium] Enable different fling behaviour for touchscreen and touchpad Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (127775 => 127776) --- trunk/Source/WebKit/chromium/public/WebFrame.h 2012-09-06 19:50:18 UTC (rev 127775) +++ trunk/Source/WebKit/chromium/public/WebFrame.h 2012-09-06 19:52:07 UTC (rev 127776) @@ -472,11 +472,30 @@ // there is ranged selection. virtual bool selectWordAroundCaret() = 0; +// DEPRECATED: Use moveSelectionStart / moveSelectionEnd / moveCaret +// This method is intended for touch-based UIs, but it's missing some +// functionality needed on Android, like preventing collapsed selections. virtual void selectRange(const WebPoint& start, const WebPoint& end) = 0; virtual void selectRange(const WebRange&) = 0; +// The methods below are for adjusting the start and/or end of the current +// selection by direct manipulation on a touch-based UI. To enter selection +// mode in the first place, call selectRange() or send a fake mouse event. +// Moves the start of the current selection, keeping the end fixed. +// Returns true on success, false if there is no selection to modify. +virtual bool moveSelectionStart(const WebPoint&, bool allowCollapsedSelection) = 0; + +// Moves the end of the current selection, keeping the start fixed. +// Returns true on success, false if there is no selection to modify. +virtual bool moveSelectionEnd(const WebPoint&, bool allowCollapsedSelection) = 0; + +// Move both endpoints of the current selection to the given position. +// The caret will remain pinned inside the current editable region. +// Returns true on success, false if there is no selection or if we're not editing. +virtual bool moveCaret(const WebPoint&) = 0; + // Printing // Reformats the WebFrame for printing. WebPrintParams specifies the printable Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (127775 => 127776) --- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-06 19:50:18 UTC (rev 127775) +++ trunk/Source/WebKit/chromium/src/Web
[webkit-changes] [127777] trunk/LayoutTests
Title: [12] trunk/LayoutTests Revision 12 Author gga...@apple.com Date 2012-09-06 12:53:01 -0700 (Thu, 06 Sep 2012) Log Message Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html because I rolled out the patch that broke it. * platform/qt/Skipped: * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127776 => 12) --- trunk/LayoutTests/ChangeLog 2012-09-06 19:52:07 UTC (rev 127776) +++ trunk/LayoutTests/ChangeLog 2012-09-06 19:53:01 UTC (rev 12) @@ -1,3 +1,11 @@ +2012-09-06 Geoffrey Garen + +Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html +because I rolled out the patch that broke it. + +* platform/qt/Skipped: +* platform/win/Skipped: + 2012-09-06 Alex Sakhartchouk [chromium] Need to rebaseline chromium tests after hidpi changes Modified: trunk/LayoutTests/platform/qt/Skipped (127776 => 12) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-06 19:52:07 UTC (rev 127776) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-06 19:53:01 UTC (rev 12) @@ -2794,10 +2794,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=95827 fast/innerHTML/innerHTML-iframe.html -# REGRESSION(r127698): It made fast/dom/HTMLScriptElement/script-reexecution.html fail -# https://bugs.webkit.org/show_bug.cgi?id=95944 -fast/dom/HTMLScriptElement/script-reexecution.html - # New tests introduced in r127704 fail # https://bugs.webkit.org/show_bug.cgi?id=95952 fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html Modified: trunk/LayoutTests/platform/win/Skipped (127776 => 12) --- trunk/LayoutTests/platform/win/Skipped 2012-09-06 19:52:07 UTC (rev 127776) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-06 19:53:01 UTC (rev 12) @@ -2215,8 +2215,5 @@ media/video-timeupdate-reverse-play.html media/W3C/video/src/src_removal_does_not_trigger_loadstart.html -# https://bugs.webkit.org/show_bug.cgi?id=95944 -fast/dom/HTMLScriptElement/script-reexecution.html - # Interactive form validation not enabled on Windows fast/forms/number/number-interactive-validation-required.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127779] trunk
Title: [127779] trunk
Revision 127779
Author ann...@chromium.org
Date 2012-09-06 13:06:00 -0700 (Thu, 06 Sep 2012)
Log Message
ASSERT reached when TextTrack.mode is set to DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=94651
Reviewed by Eric Carlson.
This patch ensures that cues that have already been added to the
cueTree in HTMLMediaElement, are not added again.
Source/WebCore:
Test: media/track/track-mode-disabled-crash.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackAddCue): Do not add the cue if it already
exists in m_cueTree.
LayoutTests:
* media/track/track-mode-disabled-crash-expected.txt: Added.
* media/track/track-mode-disabled-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/media/track/track-mode-disabled-crash-expected.txt
trunk/LayoutTests/media/track/track-mode-disabled-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127778 => 127779)
--- trunk/LayoutTests/ChangeLog 2012-09-06 19:54:14 UTC (rev 127778)
+++ trunk/LayoutTests/ChangeLog 2012-09-06 20:06:00 UTC (rev 127779)
@@ -1,3 +1,16 @@
+2012-09-06 Anna Cavender
+
+ASSERT reached when TextTrack.mode is set to DISABLED.
+https://bugs.webkit.org/show_bug.cgi?id=94651
+
+Reviewed by Eric Carlson.
+
+This patch ensures that cues that have already been added to the
+cueTree in HTMLMediaElement, are not added again.
+
+* media/track/track-mode-disabled-crash-expected.txt: Added.
+* media/track/track-mode-disabled-crash.html: Added.
+
2012-09-06 Geoffrey Garen
Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
Added: trunk/LayoutTests/media/track/track-mode-disabled-crash-expected.txt (0 => 127779)
--- trunk/LayoutTests/media/track/track-mode-disabled-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/media/track/track-mode-disabled-crash-expected.txt 2012-09-06 20:06:00 UTC (rev 127779)
@@ -0,0 +1,13 @@
+Tests that cues are properly removed from the active cue list when their track changes mode to disabled.
+
+EVENT(canplaythrough)
+** Set the mode of the text track to showing. **
+** Seek to a time with a caption. **
+EVENT(seeked)
+** Set the mode of the text track to hidden, then showing again. **
+** Set the mode of the text track to disabled. **
+
+No crash. PASS.
+
+END OF TEST
+
Added: trunk/LayoutTests/media/track/track-mode-disabled-crash.html (0 => 127779)
--- trunk/LayoutTests/media/track/track-mode-disabled-crash.html (rev 0)
+++ trunk/LayoutTests/media/track/track-mode-disabled-crash.html 2012-09-06 20:06:00 UTC (rev 127779)
@@ -0,0 +1,53 @@
+
+
+
+
+
+
+var testTrack;
+
+function seeked()
+{
+consoleWrite("** Set the mode of the text track to hidden, then showing again. **");
+testTrack.track.mode = "hidden";
+testTrack.track.mode = "showing";
+
+consoleWrite("** Set the mode of the text track to disabled. **");
+testTrack.track.mode = "disabled";
+
+consoleWrite("");
+consoleWrite("No crash. PASS.");
+consoleWrite("");
+
+endTest();
+}
+
+function startTest()
+{
+consoleWrite("** Set the mode of the text track to showing. **");
+testTrack.track.mode = "showing";
+consoleWrite("** Seek to a time with a caption. **");
+video.currentTime = 1.5;
+}
+
+function loaded()
+{
+findMediaElement();
+testTrack = document.querySelector('track');
+
+video.src = "" '../content/counting');
+waitForEvent('seeked', seeked);
+waitForEvent('canplaythrough', startTest);
+}
+
+
+
+
+
+
+
+ Tests that cues are properly removed from the active cue list when their track changes mode to disabled.
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (127778 => 127779)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 19:54:14 UTC (rev 127778)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 20:06:00 UTC (rev 127779)
@@ -1,3 +1,19 @@
+2012-09-06 Anna Cavender
+
+ASSERT reached when TextTrack.mode is set to DISABLED.
+https://bugs.webkit.org/show_bug.cgi?id=94651
+
+Reviewed by Eric Carlson.
+
+This patch ensures that cues that have already been added to the
+cueTree in HTMLMediaElement, are not added again.
+
+Test: media/track/track-mode-disabled-crash.html
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::textTrackAddCue): Do not add the cue if it already
[webkit-changes] [127781] trunk/Source/WebKit/chromium
Title: [127781] trunk/Source/WebKit/chromium
Revision 127781
Author jam...@google.com
Date 2012-09-06 13:55:13 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Put chromium implementations of WTF symbols in separate static library
https://bugs.webkit.org/show_bug.cgi?id=95933
Reviewed by Adam Barth.
A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
component build is a DLL. This moves these files into a static library that webkit depends on so targets can
statically link in wtf and these support files without depending directly on webkit.
* WebKit.gyp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127780 => 127781)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 20:19:40 UTC (rev 127780)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 20:55:13 UTC (rev 127781)
@@ -1,3 +1,17 @@
+2012-09-06 James Robinson
+
+[chromium] Put chromium implementations of WTF symbols in separate static library
+https://bugs.webkit.org/show_bug.cgi?id=95933
+
+Reviewed by Adam Barth.
+
+A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
+implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
+component build is a DLL. This moves these files into a static library that webkit depends on so targets can
+statically link in wtf and these support files without depending directly on webkit.
+
+* WebKit.gyp:
+
2012-09-06 Iain Merrick
[chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (127780 => 127781)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-09-06 20:19:40 UTC (rev 127780)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-09-06 20:55:13 UTC (rev 127781)
@@ -71,13 +71,14 @@
'type': 'static_library',
'variables': { 'enable_wexit_time_destructors': 1, },
'dependencies': [
+'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
'../../WebCore/WebCore.gyp/WebCore.gyp:webcore',
-'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
'<(chromium_src_dir)/skia/skia.gyp:skia',
+'<(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_glsl',
'<(chromium_src_dir)/third_party/icu/icu.gyp:icuuc',
'<(chromium_src_dir)/third_party/npapi/npapi.gyp:npapi',
-'<(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_glsl',
'<(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
+'webkit_wtf_support',
],
'export_dependent_settings': [
'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
@@ -362,9 +363,6 @@
'src/DateTimeChooserImpl.h',
'src/ChromeClientImpl.cpp',
'src/ChromeClientImpl.h',
-'src/ChromiumCurrentTime.cpp',
-'src/ChromiumOSRandomSource.cpp',
-'src/ChromiumThreading.cpp',
'src/ColorChooserUIController.cpp',
'src/ColorChooserUIController.h',
'src/CompositionUnderlineBuilder.h',
@@ -865,6 +863,29 @@
],
},
{
+'target_name': 'webkit_wtf_support',
+'type': 'static_library',
+'dependencies': [
+'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
+'../../WTF/WTF.gyp/WTF.gyp:wtf',
+],
+'defines': [
+'WEBKIT_IMPLEMENTATION=1',
+],
+'sources': [
+'src/ChromiumCurrentTime.cpp',
+'src/ChromiumOSRandomSource.cpp',
+'src/ChromiumThreading.cpp',
+],
+'conditions': [
+['component=="shared_library"', {
+'defines': [
+'WEBKIT_DLL',
+],
+}],
+],
+},
+{
'target_name': 'inspector_resources',
'type': 'none',
'dependencies': [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127782] trunk/Source/WebKit/blackberry
Title: [127782] trunk/Source/WebKit/blackberry
Revision 127782
Author commit-qu...@webkit.org
Date 2012-09-06 14:00:43 -0700 (Thu, 06 Sep 2012)
Log Message
Add data-blackberry-webworks-context attribute and set the custom context when
getting context.
https://bugs.webkit.org/show_bug.cgi?id=95993
Patch by Genevieve Mak on 2012-09-06
Reviewed by Antonio Gomes.
PR #193726
Reviewed Internally by Mike Fenton.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- Check for custom WebWorks context and add it if there.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::webWorksContext):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
- Add a method that checks a given element for the data-webworks-context
attribute and returns its value if present.
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (127781 => 127782)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-09-06 20:55:13 UTC (rev 127781)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-09-06 21:00:43 UTC (rev 127782)
@@ -2417,6 +2417,13 @@
if (node->isElementNode()) {
Element* element = static_cast(node->shadowAncestorNode());
+
+String webWorksContext(DOMSupport::webWorksContext(element));
+if (!webWorksContext.stripWhiteSpace().isEmpty()) {
+context.setFlag(Platform::WebContext::IsWebWorksContext);
+context.setWebWorksContext(webWorksContext.utf8().data());
+}
+
if (DOMSupport::isTextBasedContentEditableElement(element)) {
if (!canStartSelection) {
// Input fields host node is by spec non-editable unless the field itself has content editable enabled.
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127781 => 127782)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-06 20:55:13 UTC (rev 127781)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-06 21:00:43 UTC (rev 127782)
@@ -1,3 +1,24 @@
+2012-09-06 Genevieve Mak
+
+Add data-blackberry-webworks-context attribute and set the custom context when
+getting context.
+https://bugs.webkit.org/show_bug.cgi?id=95993
+
+Reviewed by Antonio Gomes.
+
+PR #193726
+Reviewed Internally by Mike Fenton.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::webContext):
+- Check for custom WebWorks context and add it if there.
+* WebKitSupport/DOMSupport.cpp:
+(BlackBerry::WebKit::DOMSupport::webWorksContext):
+(DOMSupport):
+* WebKitSupport/DOMSupport.h:
+- Add a method that checks a given element for the data-webworks-context
+ attribute and returns its value if present.
+
2012-09-06 Antonio Gomes
[BlackBerry] Allow overscroll to composited scroll layers
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (127781 => 127782)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-09-06 20:55:13 UTC (rev 127781)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-09-06 21:00:43 UTC (rev 127782)
@@ -116,6 +116,18 @@
return elementText;
}
+WTF::String webWorksContext(const WebCore::Element* element)
+{
+if (!element)
+return WTF::String();
+
+DEFINE_STATIC_LOCAL(QualifiedName, webworksContextAttr, (nullAtom, "data-blackberry-webworks-context", nullAtom));
+if (element->fastHasAttribute(webworksContextAttr))
+return element->fastGetAttribute(webworksContextAttr);
+
+return WTF::String();
+}
+
bool isElementTypePlugin(const Element* element)
{
if (!element)
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h (127781 => 127782)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h 2012-09-06 20:55:13 UTC (rev 127781)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h 2012-09-06 21:00:43 UTC (rev 127782)
@@ -63,6 +63,7 @@
AttributeState elementSupportsSpellCheck(const WebCore::Element*);
WTF::String inputElementText(WebCore::Element*);
+WTF::String webWorksContext(const WebCore::Element*);
WebCore::HTMLTextFormControlElement* toTextControlElement(WebCore::Node*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127783] trunk/Source/WebCore
Title: [127783] trunk/Source/WebCore
Revision 127783
Author simon.fra...@apple.com
Date 2012-09-06 14:04:34 -0700 (Thu, 06 Sep 2012)
Log Message
Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017
Reviewed by James Robinson.
FrameView already has a HashSet of RenderObjects whose position
is affected by the viewport rect; this contains fixed and sticky-postion
objects. RenderView::setFixedPositionedObjectsNeedLayout() was using
the RenderView's list of postioned objects, but this omitted sticky-position
objects whose container was not the RenderView. So it's simpler to use
FrameView's set of fixed/sticky objects.
Changed the terminology from "fixed" to "viewport-constrained" for this set
of objects.
* page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
* page/FrameView.h:
(WebCore::FrameView::viewportConstrainedObjects):
(WebCore::FrameView::hasViewportConstrainedObjects):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderView.cpp:
* rendering/RenderView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127782 => 127783)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 21:00:43 UTC (rev 127782)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 21:04:34 UTC (rev 127783)
@@ -1,3 +1,41 @@
+2012-09-06 Simon Fraser
+
+Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
+https://bugs.webkit.org/show_bug.cgi?id=96017
+
+Reviewed by James Robinson.
+
+FrameView already has a HashSet of RenderObjects whose position
+is affected by the viewport rect; this contains fixed and sticky-postion
+objects. RenderView::setFixedPositionedObjectsNeedLayout() was using
+the RenderView's list of postioned objects, but this omitted sticky-position
+objects whose container was not the RenderView. So it's simpler to use
+FrameView's set of fixed/sticky objects.
+
+Changed the terminology from "fixed" to "viewport-constrained" for this set
+of objects.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::useSlowRepaints):
+(WebCore::FrameView::addViewportConstrainedObject):
+(WebCore::FrameView::removeViewportConstrainedObject):
+(WebCore::FrameView::scrollContentsFastPath):
+(WebCore::FrameView::setFixedVisibleContentRect):
+(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
+(WebCore::FrameView::repaintFixedElementsAfterScrolling):
+(WebCore::FrameView::updateFixedElementsAfterScrolling):
+* page/FrameView.h:
+(WebCore::FrameView::viewportConstrainedObjects):
+(WebCore::FrameView::hasViewportConstrainedObjects):
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
+(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::willBeDestroyed):
+(WebCore::RenderBoxModelObject::styleDidChange):
+* rendering/RenderView.cpp:
+* rendering/RenderView.h:
+
2012-09-06 Andrei Poenaru
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
Modified: trunk/Source/WebCore/page/FrameView.cpp (127782 => 127783)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-09-06 21:00:43 UTC (rev 127782)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-09-06 21:04:34 UTC (rev 127783)
@@ -1336,7 +1336,7 @@
bool FrameView::useSlowRepaints(bool considerOverlap) const
{
-bool mustBeSlow = m_slowRepaintObjectCount > 0 || (platformWidget() && hasFixedObjects());
+bool mustBeSlow = m_slowRepaintObjectCount > 0 || (platformWidget() && hasViewportConstrainedObjects());
// FIXME: WidgetMac.mm makes the assumption that useSlowRepaints ==
// m_contentIsOpaque, so don't take the fast path for composited layers
@@ -1421,13 +1421,13 @@
}
}
[webkit-changes] [127784] trunk/Source/WebKit/chromium
Title: [127784] trunk/Source/WebKit/chromium
Revision 127784
Author e...@google.com
Date 2012-09-06 14:23:48 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=95994
Reviewed by James Robinson.
This compositor test shouldn't depend on code outside the compositor.
* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::FakeWebScrollbar::create):
(FakeWebScrollbar):
(WebCore::TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127783 => 127784)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 21:04:34 UTC (rev 127783)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 21:23:48 UTC (rev 127784)
@@ -1,3 +1,17 @@
+2012-09-06 Adrienne Walker
+
+[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
+https://bugs.webkit.org/show_bug.cgi?id=95994
+
+Reviewed by James Robinson.
+
+This compositor test shouldn't depend on code outside the compositor.
+
+* tests/ScrollbarLayerChromiumTest.cpp:
+(WebCore::FakeWebScrollbar::create):
+(FakeWebScrollbar):
+(WebCore::TEST):
+
2012-09-06 James Robinson
[chromium] Put chromium implementations of WTF symbols in separate static library
Modified: trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp (127783 => 127784)
--- trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp 2012-09-06 21:04:34 UTC (rev 127783)
+++ trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp 2012-09-06 21:23:48 UTC (rev 127784)
@@ -30,8 +30,6 @@
#include "CCScrollbarLayerImpl.h"
#include "CCSingleThreadProxy.h"
#include "FakeWebScrollbarThemeGeometry.h"
-#include "Scrollbar.h"
-#include "Settings.h"
#include "TreeSynchronizer.h"
#include "WebScrollbarImpl.h"
#include
@@ -43,68 +41,37 @@
namespace {
-class MockScrollbar : public Scrollbar {
+class FakeWebScrollbar : public WebKit::WebScrollbar {
public:
-virtual int x() const { return 0; }
-virtual int y() const { return 0; }
-virtual int width() const { return 0; }
-virtual int height() const { return 0; }
-virtual IntSize size() const { return IntSize(); }
-virtual IntPoint location() const { return IntPoint(); }
+static PassOwnPtr create() { return adoptPtr(new FakeWebScrollbar()); }
-virtual ScrollView* parent() const { return 0; }
-virtual ScrollView* root() const { return 0; }
-
-virtual void setFrameRect(const IntRect&) { }
-virtual IntRect frameRect() const { return IntRect(); }
-
-virtual void invalidate() { }
-virtual void invalidateRect(const IntRect&) { }
-
-virtual ScrollbarOverlayStyle scrollbarOverlayStyle() const { return ScrollbarOverlayStyleDefault; }
-virtual void getTickmarks(Vector&) const { }
-virtual bool isScrollableAreaActive() const { return false; }
-virtual bool isScrollViewScrollbar() const { return false; }
-
-virtual IntPoint convertFromContainingWindow(const IntPoint& windowPoint) { return windowPoint; }
-
-virtual bool isCustomScrollbar() const { return false; }
-virtual ScrollbarOrientation orientation() const { return HorizontalScrollbar; }
-
-virtual int value() const { return 0; }
-virtual float currentPos() const { return 0; }
-virtual int visibleSize() const { return 1; }
-virtual int totalSize() const { return 1; }
-virtual int maximum() const { return 0; }
-virtual ScrollbarControlSize controlSize() const { return RegularScrollbar; }
-
-virtual int lineStep() const { return 0; }
-virtual int pageStep() const { return 0; }
-
-virtual ScrollbarPart pressedPart() const { return NoPart; }
-virtual ScrollbarPart hoveredPart() const { return NoPart; }
-
-virtual void styleChanged() { }
-
-virtual bool enabled() const { return false; }
-virtual void setEnabled(bool) { }
-
-virtual bool isOverlayScrollbar() const { return false; }
-
-MockScrollbar() : Scrollbar(0, HorizontalScrollbar, RegularScrollbar) { }
-virtual ~MockScrollbar() { }
+// WebScrollbar implementation
+virtual bool isOverlay() const OVERRIDE { return false; }
+virtual int value() const OVERRIDE { return 0; }
+virtual WebKit::WebPoint location() const OVERRIDE { return WebKit::WebPoint(); }
+virtual WebKit::WebSize size() const OVERRIDE { return WebKit::WebSize(); }
+virtual bool enabled() const OVERRIDE { return true; }
+virtual int maximum() const OVERRIDE { return 0; }
+virtual int totalSize() const OVERRIDE { return 0; }
+virtual bool isScrollViewScrollbar() const OVERRIDE { return false; }
+virtual bool isScrollableAreaActive() const OVERRIDE { return true; }
+virtual void getTickmarks(WebKit::WebVector&) const OVERRIDE { }
+virtual ScrollbarCon
[webkit-changes] [127785] trunk/LayoutTests
Title: [127785] trunk/LayoutTests Revision 127785 Author commit-qu...@webkit.org Date 2012-09-06 14:24:51 -0700 (Thu, 06 Sep 2012) Log Message [EFL][WK2] Classify several test cases in TestExpectations https://bugs.webkit.org/show_bug.cgi?id=95947 Unreviewed EFL gardening. Update TestExpectations to classify a few test case failures as being caused by lack on undo/redo stack implementation in EFL WK2. Patch by Christophe Dumez on 2012-09-06 * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127784 => 127785) --- trunk/LayoutTests/ChangeLog 2012-09-06 21:23:48 UTC (rev 127784) +++ trunk/LayoutTests/ChangeLog 2012-09-06 21:24:51 UTC (rev 127785) @@ -1,3 +1,16 @@ +2012-09-06 Christophe Dumez + +[EFL][WK2] Classify several test cases in TestExpectations +https://bugs.webkit.org/show_bug.cgi?id=95947 + +Unreviewed EFL gardening. + +Update TestExpectations to classify a few test case failures +as being caused by lack on undo/redo stack implementation +in EFL WK2. + +* platform/efl-wk2/TestExpectations: + 2012-09-06 Andrei Poenaru Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (127784 => 127785) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 21:23:48 UTC (rev 127784) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-06 21:24:51 UTC (rev 127785) @@ -219,17 +219,19 @@ BUGWK84589 : http/tests/security/cross-frame-access-call.html = TEXT PASS BUGWK94194 : http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html = TEXT PASS +// Missing undo-redo support +BUGWK92504 : editing/execCommand/delete-selection-has-style.html = TEXT +BUGWK92504 : editing/execCommand/format-block-multiple-paragraphs-in-pre.html = TEXT +BUGWK92504 : fast/css/relative-positioned-block-crash.html = TEXT +BUGWK92504 : fast/forms/plaintext-mode-1.html = TEXT + // Unclassified failures -BUGWKEFL : editing/execCommand/delete-selection-has-style.html = TEXT -BUGWKEFL : editing/execCommand/format-block-multiple-paragraphs-in-pre.html = TEXT BUGWKEFL : editing/input/emacs-ctrl-o.html = TEXT BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT BUGWKEFL : fast/css/bidi-override-in-anonymous-block.html = TEXT -BUGWKEFL : fast/css/relative-positioned-block-crash.html = TEXT BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT BUGWKEFL : fast/forms/autocomplete-off-with-default-value-does-not-clear.html = TEXT BUGWKEFL : fast/forms/legend-access-key.html = TEXT -BUGWKEFL : fast/forms/plaintext-mode-1.html = TEXT BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT BUGWKEFL : fast/forms/validation-message-in-relative-body.html = TEXT BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127786] trunk/Source/WebCore
Title: [127786] trunk/Source/WebCore Revision 127786 Author kenn...@webkit.org Date 2012-09-06 14:41:34 -0700 (Thu, 06 Sep 2012) Log Message [EFL] Fuzzy load the Edje theme for HTML forms https://bugs.webkit.org/show_bug.cgi?id=95832 Reviewed by Antonio Gomes. Change the theme so that it is first loaded when actually used. This also fixed the case that it was impossible to change theme a second time. Tested by current tests. API unit test coming in separate patch. * platform/efl/RenderThemeEfl.cpp: (WebCore): Add some convenience macros. (WebCore::applyColorCallback): Use just one callback from the edje theme, which just calls setColorFromThemeClass. (WebCore::fillColorsFromEdjeClass): Add convenience method for receiving colors from Edje and storing them in Color's. (WebCore::RenderThemeEfl::setColorFromThemeClass): Set the class Color variabled with the values from the theme color class. (WebCore::RenderThemeEfl::setThemePath): Don't apply the theme immediately. (WebCore::RenderThemeEfl::loadTheme): Load the new theme and free the current one. If it fails, it will continue using the old one, if exists. (WebCore::RenderThemeEfl::adjustSizeConstraints): (WebCore::RenderThemeEfl::themePartCacheEntryReset): (WebCore::RenderThemeEfl::cacheThemePartNew): (WebCore::RenderThemeEfl::paintThemePart): (WebCore::RenderThemeEfl::applyPartDescriptionsFrom): (WebCore::RenderThemeEfl::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeEfl::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeEfl::platformActiveSelectionForegroundColor): (WebCore::RenderThemeEfl::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeEfl::platformFocusRingColor): Ensure the theme is loaded. (WebCore::RenderThemeEfl::adjustCheckboxStyle): (WebCore::RenderThemeEfl::adjustRadioStyle): (WebCore::RenderThemeEfl::emitMediaButtonSignal): Ensure the theme is loaded. * platform/efl/RenderThemeEfl.h: (RenderThemeEfl): (WebCore::RenderThemeEfl::loadThemeIfNeeded): Remove unneeded methods and add a method for loading a theme in the case it is not loaded yet. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp trunk/Source/WebCore/platform/efl/RenderThemeEfl.h Diff Modified: trunk/Source/WebCore/ChangeLog (127785 => 127786) --- trunk/Source/WebCore/ChangeLog 2012-09-06 21:24:51 UTC (rev 127785) +++ trunk/Source/WebCore/ChangeLog 2012-09-06 21:41:34 UTC (rev 127786) @@ -1,3 +1,71 @@ +2012-09-06 Kenneth Rohde Christiansen + +[EFL] Fuzzy load the Edje theme for HTML forms +https://bugs.webkit.org/show_bug.cgi?id=95832 + +Reviewed by Antonio Gomes. + +Change the theme so that it is first loaded when actually used. +This also fixed the case that it was impossible to change theme +a second time. + +Tested by current tests. API unit test coming in separate patch. + +* platform/efl/RenderThemeEfl.cpp: +(WebCore): + +Add some convenience macros. + + (WebCore::applyColorCallback): + +Use just one callback from the edje theme, which just calls +setColorFromThemeClass. + +(WebCore::fillColorsFromEdjeClass): + +Add convenience method for receiving colors from Edje and +storing them in Color's. + +(WebCore::RenderThemeEfl::setColorFromThemeClass): + +Set the class Color variabled with the values from the theme +color class. + +(WebCore::RenderThemeEfl::setThemePath): + +Don't apply the theme immediately. + +(WebCore::RenderThemeEfl::loadTheme): + +Load the new theme and free the current one. If it fails, +it will continue using the old one, if exists. + +(WebCore::RenderThemeEfl::adjustSizeConstraints): +(WebCore::RenderThemeEfl::themePartCacheEntryReset): +(WebCore::RenderThemeEfl::cacheThemePartNew): +(WebCore::RenderThemeEfl::paintThemePart): +(WebCore::RenderThemeEfl::applyPartDescriptionsFrom): +(WebCore::RenderThemeEfl::platformActiveSelectionBackgroundColor): +(WebCore::RenderThemeEfl::platformInactiveSelectionBackgroundColor): +(WebCore::RenderThemeEfl::platformActiveSelectionForegroundColor): +(WebCore::RenderThemeEfl::platformInactiveSelectionForegroundColor): +(WebCore::RenderThemeEfl::platformFocusRingColor): + +Ensure the theme is loaded. + +(WebCore::RenderThemeEfl::adjustCheckboxStyle): +(WebCore::RenderThemeEfl::adjustRadioStyle): +(WebCore::RenderThemeEfl::emitMediaButtonSignal): + +Ensure the theme is loaded. + +* platform/efl/RenderThemeEfl.h: +(RenderThemeEfl): +(WebCore::RenderThemeEfl::loadThemeIfNeeded): + +Remove unneeded methods and add a method for loading a theme +
[webkit-changes] [127787] trunk/Source/WebCore
Title: [127787] trunk/Source/WebCore
Revision 127787
Author jam...@google.com
Date 2012-09-06 14:44:59 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Split platform geometry types into separate static target
https://bugs.webkit.org/show_bug.cgi?id=96021
Reviewed by Tony Chang.
This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
This library is relatively standalone and useful to statically link against in other contexts.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
Diff
Modified: trunk/Source/WebCore/ChangeLog (127786 => 127787)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 21:41:34 UTC (rev 127786)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 21:44:59 UTC (rev 127787)
@@ -1,3 +1,16 @@
+2012-09-06 James Robinson
+
+[chromium] Split platform geometry types into separate static target
+https://bugs.webkit.org/show_bug.cgi?id=96021
+
+Reviewed by Tony Chang.
+
+This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
+This library is relatively standalone and useful to statically link against in other contexts.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+
2012-09-06 Kenneth Rohde Christiansen
[EFL] Fuzzy load the Edje theme for HTML forms
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127786 => 127787)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-06 21:41:34 UTC (rev 127786)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-06 21:44:59 UTC (rev 127787)
@@ -1900,6 +1900,19 @@
],
},
{
+ 'target_name': 'webcore_platform_geometry',
+ 'type': 'static_library',
+ 'dependencies': [
+'webcore_prerequisites',
+ ],
+ 'defines': [
+'WEBKIT_IMPLEMENTATION=1',
+ ],
+ 'sources': [
+'<@(webcore_platform_geometry_files)',
+ ],
+},
+{
'target_name': 'webcore_chromium_compositor',
'type': 'static_library',
'dependencies': [
@@ -2130,6 +2143,7 @@
'webcore_dom',
'webcore_html',
'webcore_platform',
+'webcore_platform_geometry',
'webcore_remaining',
'webcore_rendering',
# Exported.
Modified: trunk/Source/WebCore/WebCore.gypi (127786 => 127787)
--- trunk/Source/WebCore/WebCore.gypi 2012-09-06 21:41:34 UTC (rev 127786)
+++ trunk/Source/WebCore/WebCore.gypi 2012-09-06 21:44:59 UTC (rev 127787)
@@ -4735,11 +4735,6 @@
'platform/graphics/CrossfadeGeneratedImage.cpp',
'platform/graphics/CrossfadeGeneratedImage.h',
'platform/graphics/Extensions3D.h',
-'platform/graphics/FloatPoint.cpp',
-'platform/graphics/FloatPoint3D.cpp',
-'platform/graphics/FloatQuad.cpp',
-'platform/graphics/FloatRect.cpp',
-'platform/graphics/FloatSize.cpp',
'platform/graphics/Font.cpp',
'platform/graphics/FontCache.cpp',
'platform/graphics/FontData.cpp',
@@ -4751,7 +4746,6 @@
'platform/graphics/FontPlatformData.cpp',
'platform/graphics/FontPlatformData.h',
'platform/graphics/FractionalLayoutBoxExtent.cpp',
-'platform/graphics/FractionalLayoutRect.cpp',
'platform/graphics/GeneratorGeneratedImage.cpp',
'platform/graphics/GeneratedImage.cpp',
'platform/graphics/GeneratedImage.h',
@@ -4769,7 +4763,6 @@
'platform/graphics/ImageBuffer.cpp',
'platform/graphics/ImageOrientation.cpp',
'platform/graphics/ImageSource.cpp',
-'platform/graphics/IntRect.cpp',
'platform/graphics/MediaPlayer.cpp',
'platform/graphics/MediaPlayerPrivate.h',
'platform/graphics/NativeImagePtr.h' ,
@@ -4777,7 +4770,6 @@
'platform/graphics/PathTraversalState.cpp',
'platform/graphics/PathTraversalState.h',
'platform/graphics/Pattern.cpp',
-'platform/graphics/Region.cpp',
'platform/graphics/RoundedRect.cpp',
'platform/graphics/SegmentedFontData.cpp',
'platform/graphics/SegmentedFontData.h',
@@ -5011,8 +5003,6 @@
'platform/graphics/gpu/SharedGraphicsContext3D.h',
'platform/graphics/gpu/Texture.cpp',
'platform/graphics/gpu/Texture.h',
-'platform/graphics/gpu/TilingData.cpp',
-'platform/graphics/gpu/TilingData.h',
'platform/graphics/gpu/mac/DrawingBufferMac.mm',
'platform/graphics/gpu/qt/DrawingBufferQt.cpp',
'platform/graphics/gstreamer/GRefPtrGStreamer.cpp',
@@ -5201,7 +5191,6 @@
'platform/graphics/texmap/TextureMapperPlatformLayer.h',
'platform/graphi
[webkit-changes] [127788] trunk/LayoutTests
Title: [127788] trunk/LayoutTests Revision 127788 Author al...@chromium.org Date 2012-09-06 15:07:34 -0700 (Thu, 06 Sep 2012) Log Message [chromium] Remove failures for acceletared-drawing tests. Unreviewed. Update chromium TestExpectations to remove failures for accelerated-painting. They were fixed in r127294. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127787 => 127788) --- trunk/LayoutTests/ChangeLog 2012-09-06 21:44:59 UTC (rev 127787) +++ trunk/LayoutTests/ChangeLog 2012-09-06 22:07:34 UTC (rev 127788) @@ -1,3 +1,14 @@ +2012-09-06 Alok Priyadarshi + +[chromium] Remove failures for acceletared-drawing tests. + +Unreviewed. + +Update chromium TestExpectations to remove failures for accelerated-painting. +They were fixed in r127294. + +* platform/chromium/TestExpectations: + 2012-09-06 Christophe Dumez [EFL][WK2] Classify several test cases in TestExpectations Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127787 => 127788) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-06 21:44:59 UTC (rev 127787) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-06 22:07:34 UTC (rev 127788) @@ -2693,10 +2693,6 @@ BUGWK73514 WIN : platform/chromium/compositing/lost-compositor-context-permanently.html = PASS TIMEOUT -// Flaky/crashing -BUGWK92660 : platform/chromium/compositing/accelerated-drawing/svg-filters.html = CRASH PASS -BUGWK92660 : platform/chromium/compositing/accelerated-drawing/alpha.html = CRASH PASS - BUGWK73766 : css3/unicode-bidi-isolate-aharon-failing.html = IMAGE BUGWK78544 LINUX ANDROID : fast/text/international/danda-space.html = PASS IMAGE IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127789] trunk/Source
Title: [127789] trunk/Source Revision 127789 Author commit-qu...@webkit.org Date 2012-09-06 15:23:29 -0700 (Thu, 06 Sep 2012) Log Message [Chromium] Remove contentsScale and related logic from GraphicsLayerChromium. https://bugs.webkit.org/show_bug.cgi?id=95094 Patch by Jeff Timanus on 2012-09-06 Reviewed by Adrienne Walker. Source/Platform: In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of contentsScale behaviour. * chromium/public/WebContentLayer.h: (WebContentLayer): Export setBoundsContainPageScale() family of routines. Source/WebCore: In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of contentsScale behaviour. Testing covered by existing compositor layout and unit tests. * platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setAppliesPageScale): (WebCore::GraphicsLayer::appliesPageScale): These routines are now virtual, so that they can push the notification to setDisregardsContentsScale in LayerChromium. * platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setSize): (WebCore::GraphicsLayerChromium::setTransform): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore): (WebCore::GraphicsLayerChromium::setAppliesPageScale): (WebCore::GraphicsLayerChromium::appliesPageScale): Now forwards the appliesPageScaleStatus to the owned layer. * platform/graphics/chromium/GraphicsLayerChromium.h: (GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::contentsLayer): * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::setContentsScale): (WebCore): (WebCore::LayerChromium::setBoundsContainPageScale): setAppliesPageScale is renamed to setBoundsContainPageScale in LayerChromium. * platform/graphics/chromium/LayerChromium.h: (LayerChromium): (WebCore::LayerChromium::boundsContainPageScale): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore): (WebCore::setScale): (WebCore::updateLayerScale): (WebCore::CCLayerTreeHost::updateLayers): The contents scale of a layer is now applied in this routine. Source/WebKit/chromium: In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of contentsScale behaviour. This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium. * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): Inform the layer associated with the NCCH that it is to disregard the page scale factor. Also remove now unused m_deviceScaleFactor and associated routines. (WebKit::NonCompositedContentHost::setViewport): * src/NonCompositedContentHost.h: (NonCompositedContentHost): * src/WebContentLayerImpl.cpp: (WebKit::WebContentLayerImpl::setBoundsContainPageScale): (WebKit): (WebKit::WebContentLayerImpl::boundsContainPageScale): * src/WebContentLayerImpl.h: (WebContentLayerImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::updateLayerTreeViewport): * tests/CCLayerTreeHostTest.cpp: (NoScaleContentLayerChromium): (WebKitTests::NoScaleContentLayerChromium::create): (WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium): (WebKitTests): (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers): Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the scale on the draw transforms remain identity. * tests/GraphicsLayerChromiumTest.cpp: (WebKit): Remove now obsolete unit-test. Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/chromium/public/WebContentLayer.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsLayer.h trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp trunk/Source/WebKit/chromium/src/NonCompositedContentHost.h trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp trunk/Source/WebKit/chromium/src/WebContentLayerImpl.h trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTe
[webkit-changes] [127790] trunk/Source/WebKit/chromium
Title: [127790] trunk/Source/WebKit/chromium
Revision 127790
Author e...@google.com
Date 2012-09-06 15:48:43 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96002
Reviewed by James Robinson.
This is a compositor unit test, so it shouldn't reference things
outside of the compositor like GraphicsContext. The
OpaqueRectTrackingContentLayerDelegateTest already tests opaque
tracking right at the time of paint. This test is about verifying that
transformed canvases work properly, so can just fake the opaque rect
coming back from the paint.
* tests/ContentLayerChromiumTest.cpp:
(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/ContentLayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127789 => 127790)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 22:23:29 UTC (rev 127789)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 22:48:43 UTC (rev 127790)
@@ -1,3 +1,21 @@
+2012-09-06 Adrienne Walker
+
+[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
+https://bugs.webkit.org/show_bug.cgi?id=96002
+
+Reviewed by James Robinson.
+
+This is a compositor unit test, so it shouldn't reference things
+outside of the compositor like GraphicsContext. The
+OpaqueRectTrackingContentLayerDelegateTest already tests opaque
+tracking right at the time of paint. This test is about verifying that
+transformed canvases work properly, so can just fake the opaque rect
+coming back from the paint.
+
+* tests/ContentLayerChromiumTest.cpp:
+(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
+(WebKit::TEST):
+
2012-09-06 Jeff Timanus
[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
Modified: trunk/Source/WebKit/chromium/tests/ContentLayerChromiumTest.cpp (127789 => 127790)
--- trunk/Source/WebKit/chromium/tests/ContentLayerChromiumTest.cpp 2012-09-06 22:23:29 UTC (rev 127789)
+++ trunk/Source/WebKit/chromium/tests/ContentLayerChromiumTest.cpp 2012-09-06 22:48:43 UTC (rev 127790)
@@ -30,8 +30,6 @@
#include "CCGeometryTestUtils.h"
#include "CCRenderingStats.h"
#include "ContentLayerChromiumClient.h"
-#include "GraphicsContext.h"
-#include "OpaqueRectTrackingContentLayerDelegate.h"
#include "skia/ext/platform_canvas.h"
#include
#include
@@ -44,49 +42,20 @@
namespace {
-class OpaqueRectDrawingGraphicsContextPainter : public GraphicsContextPainter {
-public:
-explicit OpaqueRectDrawingGraphicsContextPainter(const IntRect& opaqueRect, const IntRect& contentRect)
-: m_opaqueRect(opaqueRect)
-, m_contentRect(contentRect)
-{
-}
-
-virtual ~OpaqueRectDrawingGraphicsContextPainter()
-{
-}
-
-virtual void paint(GraphicsContext& context, const IntRect& clip) OVERRIDE
-{
-Color alpha(0, 0, 0, 0);
-context.fillRect(m_contentRect, alpha, ColorSpaceDeviceRGB);
-
-Color white(255, 255, 255, 255);
-context.fillRect(m_opaqueRect, white, ColorSpaceDeviceRGB);
-}
-
-private:
-IntRect m_opaqueRect;
-IntRect m_contentRect;
-};
-
class MockContentLayerChromiumClient : public ContentLayerChromiumClient {
public:
-explicit MockContentLayerChromiumClient(OpaqueRectTrackingContentLayerDelegate* client)
-: m_client(client)
+explicit MockContentLayerChromiumClient(IntRect opaqueLayerRect)
+: m_opaqueLayerRect(opaqueLayerRect)
{
}
-virtual void paintContents(SkCanvas* canvas, const IntRect& clip, FloatRect& opaque) OVERRIDE
+virtual void paintContents(SkCanvas*, const IntRect&, FloatRect& opaque) OVERRIDE
{
-WebFloatRect resultingOpaqueRect(opaque.x(), opaque.y(), opaque.width(), opaque.height());
-WebRect webClipRect(clip.x(), clip.y(), clip.width(), clip.height());
-m_client->paintContents(canvas, webClipRect, resultingOpaqueRect);
-opaque = FloatRect(resultingOpaqueRect.x, resultingOpaqueRect.y, resultingOpaqueRect.width, resultingOpaqueRect.height);
+opaque = FloatRect(m_opaqueLayerRect);
}
private:
-OpaqueRectTrackingContentLayerDelegate* m_client;
+IntRect m_opaqueLayerRect;
};
TEST(ContentLayerChromiumTest, ContentLayerPainterWithDeviceScale)
@@ -97,9 +66,7 @@
IntRect opaqueRectInContentSpace = opaqueRectInLayerSpace;
opaqueRectInContentSpace.scale(contentsScale);
OwnPtr canvas = adoptPtr(skia::CreateBitmapCanvas(contentRect.width(), contentRect.height(), false));
-OpaqueRectDrawingGraphicsContextPainter painter(opaqueRectInLayerSpace, contentRect);
-OpaqueRectTrackingContentLayerDelegate opaqueRectTrackingContentLayerDelegate(&painter);
-MockContentLaye
[webkit-changes] [127791] trunk/Source
Title: [127791] trunk/Source
Revision 127791
Author commit-qu...@webkit.org
Date 2012-09-06 16:14:08 -0700 (Thu, 06 Sep 2012)
Log Message
IndexedDB: make IDBKeyPath's string and array constructors explicit
https://bugs.webkit.org/show_bug.cgi?id=96004
Patch by Alec Flett on 2012-09-06
Reviewed by Tony Chang.
Source/WebCore:
Making these explicit to avoid accidental implicit conversions.
No new tests, existing tests cover correctness.
* Modules/indexeddb/IDBKeyPath.h:
(IDBKeyPath):
Source/WebKit/chromium:
Fix test to use explicit constructor for IDBKeyPath.
* tests/IDBDatabaseBackendTest.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127790 => 127791)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 23:14:08 UTC (rev 127791)
@@ -1,3 +1,17 @@
+2012-09-06 Alec Flett
+
+IndexedDB: make IDBKeyPath's string and array constructors explicit
+https://bugs.webkit.org/show_bug.cgi?id=96004
+
+Reviewed by Tony Chang.
+
+Making these explicit to avoid accidental implicit conversions.
+
+No new tests, existing tests cover correctness.
+
+* Modules/indexeddb/IDBKeyPath.h:
+(IDBKeyPath):
+
2012-09-06 Jeff Timanus
[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h (127790 => 127791)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h 2012-09-06 23:14:08 UTC (rev 127791)
@@ -45,8 +45,8 @@
class IDBKeyPath {
public:
IDBKeyPath() : m_type(NullType) { }
-IDBKeyPath(const String&);
-IDBKeyPath(const Vector& array);
+explicit IDBKeyPath(const String&);
+explicit IDBKeyPath(const Vector& array);
enum Type {
NullType = 0,
Modified: trunk/Source/WebKit/chromium/ChangeLog (127790 => 127791)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 23:14:08 UTC (rev 127791)
@@ -1,3 +1,14 @@
+2012-09-06 Alec Flett
+
+IndexedDB: make IDBKeyPath's string and array constructors explicit
+https://bugs.webkit.org/show_bug.cgi?id=96004
+
+Reviewed by Tony Chang.
+
+Fix test to use explicit constructor for IDBKeyPath.
+
+* tests/IDBDatabaseBackendTest.cpp:
+
2012-09-06 Adrienne Walker
[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
Modified: trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp (127790 => 127791)
--- trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp 2012-09-06 22:48:43 UTC (rev 127790)
+++ trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp 2012-09-06 23:14:08 UTC (rev 127791)
@@ -57,12 +57,12 @@
EXPECT_GT(backingStore->refCount(), 1);
const bool autoIncrement = false;
-RefPtr store = IDBObjectStoreBackendImpl::create(db.get(), "store", String("keyPath"), autoIncrement);
+RefPtr store = IDBObjectStoreBackendImpl::create(db.get(), "store", IDBKeyPath("keyPath"), autoIncrement);
EXPECT_GT(backingStore->refCount(), 1);
const bool unique = false;
const bool multiEntry = false;
-RefPtr index = IDBIndexBackendImpl::create(db.get(), store.get(), "index", String("keyPath"), unique, multiEntry);
+RefPtr index = IDBIndexBackendImpl::create(db.get(), store.get(), "index", IDBKeyPath("keyPath"), unique, multiEntry);
EXPECT_GT(backingStore->refCount(), 1);
db.clear();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127792] trunk/Source/WebKit/chromium
Title: [127792] trunk/Source/WebKit/chromium
Revision 127792
Author jam...@google.com
Date 2012-09-06 16:16:14 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot on 2012-09-06
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127791 => 127792)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 23:14:08 UTC (rev 127791)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 23:16:14 UTC (rev 127792)
@@ -1,3 +1,9 @@
+2012-09-06 Sheriff Bot
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-06 Alec Flett
IndexedDB: make IDBKeyPath's string and array constructors explicit
Modified: trunk/Source/WebKit/chromium/DEPS (127791 => 127792)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-06 23:14:08 UTC (rev 127791)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-06 23:16:14 UTC (rev 127792)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '155144'
+ 'chromium_rev': '155215'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127793] trunk/Tools
Title: [127793] trunk/Tools
Revision 127793
Author commit-qu...@webkit.org
Date 2012-09-06 16:17:05 -0700 (Thu, 06 Sep 2012)
Log Message
[EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
https://bugs.webkit.org/show_bug.cgi?id=95995
Patch by Christophe Dumez on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.
Provide proper implementation for PlatformWebView::windowFrame()
in EFL's WebKitTestRunner.
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::windowFrame):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
Diff
Modified: trunk/Tools/ChangeLog (127792 => 127793)
--- trunk/Tools/ChangeLog 2012-09-06 23:16:14 UTC (rev 127792)
+++ trunk/Tools/ChangeLog 2012-09-06 23:17:05 UTC (rev 127793)
@@ -1,3 +1,16 @@
+2012-09-06 Christophe Dumez
+
+[EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
+https://bugs.webkit.org/show_bug.cgi?id=95995
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Provide proper implementation for PlatformWebView::windowFrame()
+in EFL's WebKitTestRunner.
+
+* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
+(WTR::PlatformWebView::windowFrame):
+
2012-09-06 Fady Samuel
Fix WTF.Lrint on 32-bit platforms
Modified: trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp (127792 => 127793)
--- trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2012-09-06 23:16:14 UTC (rev 127792)
+++ trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2012-09-06 23:17:05 UTC (rev 127793)
@@ -76,7 +76,10 @@
WKRect PlatformWebView::windowFrame()
{
-return WKRectMake(0, 0, 0, 0);
+Evas_Coord x, y, width, height;
+evas_object_geometry_get(m_view, &x, &y, &width, &height);
+
+return WKRectMake(x, y, width, height);
}
void PlatformWebView::setWindowFrame(WKRect frame)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127795] trunk/Source/WebCore
Title: [127795] trunk/Source/WebCore Revision 127795 Author simon.fra...@apple.com Date 2012-09-06 16:21:09 -0700 (Thu, 06 Sep 2012) Log Message Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling https://bugs.webkit.org/show_bug.cgi?id=96026 Reviewed by James Robinson. Lay some groundwork for threaded scrolling with fixed position and sticky position objects, by packaging up logic related to how to reposition fixed and sticky things on viewport changes into "constraints" classes. ScrollingConstraints contains a 'ViewportConstraints' base class that is subclassed for sticky position. These classes store data about the constraints that govern the position of an object outside of the render tree, and know how to compute a new position when the viewport changes using only data in the class. This patch changes RenderBoxModelObject to use the StickyPositionViewportConstraints class for computing stick offsets at layout time. In the future, we'll have the scrolling tree store copies of the constraint data for threaded scrolling. * CMakeLists.txt: Add ScrollingConstraints.* to the build. * GNUmakefile.list.am: Ditto * Target.pri: Ditto * WebCore.gypi: Ditto * WebCore.vcproj/WebCore.vcproj: Ditto * WebCore.xcodeproj/project.pbxproj: Ditto * page/scrolling/ScrollingConstraints.cpp: Added. (WebCore::StickyPositionViewportConstraints::computeStickyOffset): (WebCore::StickyPositionViewportConstraints::layerPositionForViewportRect): * page/scrolling/ScrollingConstraints.h: Added. (WebCore::ViewportConstraints::ViewportConstraints): (WebCore::ViewportConstraints::~ViewportConstraints): (WebCore::ViewportConstraints::anchorEdges): (WebCore::ViewportConstraints::hasAnchorEdge): (WebCore::ViewportConstraints::addAnchorEdge): (WebCore::ViewportConstraints::alignmentOffset): (WebCore::ViewportConstraints::setAlignmentOffset): (StickyPositionViewportConstraints): (WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints): (WebCore::StickyPositionViewportConstraints::stickyOffsetAtLastLayout): (WebCore::StickyPositionViewportConstraints::setStickyOffsetAtLastLayout): (WebCore::StickyPositionViewportConstraints::layerPositionAtLastLayout): (WebCore::StickyPositionViewportConstraints::setLayerPositionAtLastLayout): (WebCore::StickyPositionViewportConstraints::leftOffset): (WebCore::StickyPositionViewportConstraints::rightOffset): (WebCore::StickyPositionViewportConstraints::topOffset): (WebCore::StickyPositionViewportConstraints::bottomOffset): (WebCore::StickyPositionViewportConstraints::setLeftOffset): (WebCore::StickyPositionViewportConstraints::setRightOffset): (WebCore::StickyPositionViewportConstraints::setTopOffset): (WebCore::StickyPositionViewportConstraints::setBottomOffset): (WebCore::StickyPositionViewportConstraints::setAbsoluteContainingBlockRect): (WebCore::StickyPositionViewportConstraints::setAbsoluteStickyBoxRect): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::computeStickyPositionConstraints): Fill out data in the supplied StickyPositionViewportConstraints instance. (WebCore::RenderBoxModelObject::stickyPositionOffset): Create a StickyPositionViewportConstraints object on the stack and use it to compute the sticky offset. * rendering/RenderBoxModelObject.h: (RenderBoxModelObject): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.h Added Paths trunk/Source/WebCore/page/scrolling/ScrollingConstraints.cpp trunk/Source/WebCore/page/scrolling/ScrollingConstraints.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (127794 => 127795) --- trunk/Source/WebCore/CMakeLists.txt 2012-09-06 23:17:48 UTC (rev 127794) +++ trunk/Source/WebCore/CMakeLists.txt 2012-09-06 23:21:09 UTC (rev 127795) @@ -1731,6 +1731,7 @@ page/animation/ImplicitAnimation.cpp page/animation/KeyframeAnimation.cpp +page/scrolling/ScrollingConstraints.cpp page/scrolling/ScrollingCoordinator.cpp page/scrolling/ScrollingCoordinatorNone.cpp Modified: trunk/Source/WebCore/ChangeLog (127794 => 127795) --- trunk/Source/WebCore/ChangeLog 2012-09-06 23:17:48 UTC (rev 127794) +++ trunk/Source/WebCore/ChangeLog 2012-09-06 23:21:09 UTC (rev 127795) @@ -1,3 +1,66 @@ +2012-09-06 Simon Fraser + +Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling +https://bugs.webkit.org/show_bug.cgi?id=96026 + +Reviewed by James Robinson. + +Lay some groundwork for threaded scrolling with fixed position and sticky +position objects, by packaging up logic related
[webkit-changes] [127796] trunk/Source/Platform
Title: [127796] trunk/Source/Platform
Revision 127796
Author jam...@google.com
Date 2012-09-06 16:21:22 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=96025
Reviewed by Adrienne Walker.
* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):
Modified Paths
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebTransformationMatrix.h
Diff
Modified: trunk/Source/Platform/ChangeLog (127795 => 127796)
--- trunk/Source/Platform/ChangeLog 2012-09-06 23:21:09 UTC (rev 127795)
+++ trunk/Source/Platform/ChangeLog 2012-09-06 23:21:22 UTC (rev 127796)
@@ -1,5 +1,15 @@
2012-09-06 James Robinson
+[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
+https://bugs.webkit.org/show_bug.cgi?id=96025
+
+Reviewed by Adrienne Walker.
+
+* chromium/public/WebTransformationMatrix.h:
+(WebTransformationMatrix):
+
+2012-09-06 James Robinson
+
[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
https://bugs.webkit.org/show_bug.cgi?id=96007
Modified: trunk/Source/Platform/chromium/public/WebTransformationMatrix.h (127795 => 127796)
--- trunk/Source/Platform/chromium/public/WebTransformationMatrix.h 2012-09-06 23:21:09 UTC (rev 127795)
+++ trunk/Source/Platform/chromium/public/WebTransformationMatrix.h 2012-09-06 23:21:22 UTC (rev 127796)
@@ -45,93 +45,93 @@
class WebTransformationMatrix {
public:
-WebTransformationMatrix();
-WebTransformationMatrix(double a, double b, double c, double d, double e, double f);
-WebTransformationMatrix(double m11, double m12, double m13, double m14,
-double m21, double m22, double m23, double m24,
-double m31, double m32, double m33, double m34,
-double m41, double m42, double m43, double m44);
-WebTransformationMatrix(const WebTransformationMatrix&);
+WEBKIT_EXPORT WebTransformationMatrix();
+WEBKIT_EXPORT WebTransformationMatrix(double a, double b, double c, double d, double e, double f);
+WEBKIT_EXPORT WebTransformationMatrix(double m11, double m12, double m13, double m14,
+ double m21, double m22, double m23, double m24,
+ double m31, double m32, double m33, double m34,
+ double m41, double m42, double m43, double m44);
+WEBKIT_EXPORT WebTransformationMatrix(const WebTransformationMatrix&);
~WebTransformationMatrix() { }
// Operations that return a separate matrix and do not modify this one.
-WebTransformationMatrix inverse() const;
-WebTransformationMatrix to2dTransform() const;
+WEBKIT_EXPORT WebTransformationMatrix inverse() const;
+WEBKIT_EXPORT WebTransformationMatrix to2dTransform() const;
-WebTransformationMatrix& operator=(const WebTransformationMatrix&);
-bool operator==(const WebTransformationMatrix&) const;
-WebTransformationMatrix operator*(const WebTransformationMatrix&) const;
+WEBKIT_EXPORT WebTransformationMatrix& operator=(const WebTransformationMatrix&);
+WEBKIT_EXPORT bool operator==(const WebTransformationMatrix&) const;
+WEBKIT_EXPORT WebTransformationMatrix operator*(const WebTransformationMatrix&) const;
// Operations that modify this matrix
-void multiply(const WebTransformationMatrix&);
-void makeIdentity();
-void translate(double tx, double ty);
-void translate3d(double tx, double ty, double tz);
-void translateRight3d(double tx, double ty, double tz);
-void scale(double s);
-void scaleNonUniform(double sx, double sy);
-void scale3d(double sx, double sy, double sz);
-void rotate(double angle);
-void rotate3d(double rx, double ry, double rz);
-void rotate3d(double x, double y, double z, double angle);
-void skewX(double angle);
-void skewY(double angle);
-void applyPerspective(double p);
-void blend(const WebTransformationMatrix& from, double progress);
+WEBKIT_EXPORT void multiply(const WebTransformationMatrix&);
+WEBKIT_EXPORT void makeIdentity();
+WEBKIT_EXPORT void translate(double tx, double ty);
+WEBKIT_EXPORT void translate3d(double tx, double ty, double tz);
+WEBKIT_EXPORT void translateRight3d(double tx, double ty, double tz);
+WEBKIT_EXPORT void scale(double s);
+WEBKIT_EXPORT void scaleNonUniform(double sx, double sy);
+WEBKIT_EXPORT void scale3d(double sx, double sy, double sz);
+WEBKIT_EXPORT void rotate(double angle);
+WEBKIT_EXPORT void rotate3d(double rx, double ry, double rz);
+WEBKIT_EXPORT void rotate3d(double x, double y, double z, double angle);
+WEBKIT_EXPORT void skewX(double angle);
+WEBKIT_EXPORT void skewY(do
[webkit-changes] [127798] trunk/LayoutTests
Title: [127798] trunk/LayoutTests Revision 127798 Author aba...@webkit.org Date 2012-09-06 16:40:56 -0700 (Thu, 06 Sep 2012) Log Message New tests introduced in r127704 fail https://bugs.webkit.org/show_bug.cgi?id=95952 Reviewed by Dan Bernstein. Use the testRunner rather than layoutTestController because layoutTestControler doesn't exist anymore. * fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: * fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127797 => 127798) --- trunk/LayoutTests/ChangeLog 2012-09-06 23:23:50 UTC (rev 127797) +++ trunk/LayoutTests/ChangeLog 2012-09-06 23:40:56 UTC (rev 127798) @@ -1,3 +1,16 @@ +2012-09-06 Adam Barth + +New tests introduced in r127704 fail +https://bugs.webkit.org/show_bug.cgi?id=95952 + +Reviewed by Dan Bernstein. + +Use the testRunner rather than layoutTestController because +layoutTestControler doesn't exist anymore. + +* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: +* fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: + 2012-09-06 Alok Priyadarshi [chromium] Remove failures for acceletared-drawing tests. Modified: trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html (127797 => 127798) --- trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html 2012-09-06 23:23:50 UTC (rev 127797) +++ trunk/LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html 2012-09-06 23:40:56 UTC (rev 127798) @@ -2,8 +2,8 @@
[webkit-changes] [127799] trunk/Source/WTF
Title: [127799] trunk/Source/WTF
Revision 127799
Author msab...@apple.com
Date 2012-09-06 16:41:29 -0700 (Thu, 06 Sep 2012)
Log Message
ENH: Add Logging to StringImpl to track String Types
https://bugs.webkit.org/show_bug.cgi?id=95807
Reviewed by Benjamin Poulain.
Added StringsStats class that keeps track of the number of strings, number of 8 and 16 bit
strings as well as the number of 8 bit strings up converted to 16 bits. The number of characrters
for each type is also accumulated. These statistics are output via DataLog every 5000
calls to StringImpl destructor. The 5000 can be adjusted via s_printStringStatsFrequency.
This StringStats code is disabled by default and enabled by defining STRING_STATS in
wtf/text/StringImpl.h.
* wtf/text/StringImpl.cpp:
(WTF::StringStats::removeString):
(WTF::StringStats::printStats):
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::getData16SlowCase):
* wtf/text/StringImpl.h:
(WTF::StringStats::add8BitString):
(StringStats):
(WTF::StringStats::add16BitString):
(WTF::StringStats::addUpconvertedString):
(WTF::StringImpl::StringImpl):
(StringImpl):
(WTF::StringImpl::isSubString):
(WTF::StringImpl::stringStats):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.cpp
trunk/Source/WTF/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/WTF/ChangeLog (127798 => 127799)
--- trunk/Source/WTF/ChangeLog 2012-09-06 23:40:56 UTC (rev 127798)
+++ trunk/Source/WTF/ChangeLog 2012-09-06 23:41:29 UTC (rev 127799)
@@ -1,3 +1,32 @@
+2012-09-06 Michael Saboff
+
+ENH: Add Logging to StringImpl to track String Types
+https://bugs.webkit.org/show_bug.cgi?id=95807
+
+Reviewed by Benjamin Poulain.
+
+Added StringsStats class that keeps track of the number of strings, number of 8 and 16 bit
+strings as well as the number of 8 bit strings up converted to 16 bits. The number of characrters
+for each type is also accumulated. These statistics are output via DataLog every 5000
+calls to StringImpl destructor. The 5000 can be adjusted via s_printStringStatsFrequency.
+This StringStats code is disabled by default and enabled by defining STRING_STATS in
+wtf/text/StringImpl.h.
+
+* wtf/text/StringImpl.cpp:
+(WTF::StringStats::removeString):
+(WTF::StringStats::printStats):
+(WTF::StringImpl::~StringImpl):
+(WTF::StringImpl::getData16SlowCase):
+* wtf/text/StringImpl.h:
+(WTF::StringStats::add8BitString):
+(StringStats):
+(WTF::StringStats::add16BitString):
+(WTF::StringStats::addUpconvertedString):
+(WTF::StringImpl::StringImpl):
+(StringImpl):
+(WTF::StringImpl::isSubString):
+(WTF::StringImpl::stringStats):
+
2012-09-06 Patrick Gansterer
Fix export macros in IntegerToStringConversion.h
Modified: trunk/Source/WTF/wtf/text/StringImpl.cpp (127798 => 127799)
--- trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-09-06 23:40:56 UTC (rev 127798)
+++ trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-09-06 23:41:29 UTC (rev 127799)
@@ -32,6 +32,9 @@
#include
#include
+#ifdef STRING_STATS
+#include
+#endif
using namespace std;
@@ -41,10 +44,69 @@
COMPILE_ASSERT(sizeof(StringImpl) == 2 * sizeof(int) + 3 * sizeof(void*), StringImpl_should_stay_small);
+#ifdef STRING_STATS
+StringStats StringImpl::m_stringStats;
+
+static unsigned StringStats::s_stringRemovesTillPrintStats = StringStats::s_printStringStatsFrequency;
+
+void StringStats::removeString(StringImpl* string)
+{
+unsigned length = string->length();
+bool isSubString = string->isSubString();
+
+--m_totalNumberStrings;
+
+if (string->has16BitShadow()) {
+--m_numberUpconvertedStrings;
+if (!isSubString)
+m_totalUpconvertedData -= length;
+}
+
+if (string->is8Bit()) {
+--m_number8BitStrings;
+if (!isSubString)
+m_total8BitData -= length;
+} else {
+--m_number16BitStrings;
+if (!isSubString)
+m_total16BitData -= length;
+}
+
+if (!--s_stringRemovesTillPrintStats) {
+s_stringRemovesTillPrintStats = s_printStringStatsFrequency;
+printStats();
+}
+}
+
+void StringStats::printStats()
+{
+dataLog("String stats for process id %d:\n", getpid());
+
+unsigned long long totalNumberCharacters = m_total8BitData + m_total16BitData;
+double percent8Bit = m_totalNumberStrings ? ((double)m_number8BitStrings * 100) / (double)m_totalNumberStrings : 0.0;
+double average8bitLength = m_number8BitStrings ? (double)m_total8BitData / (double)m_number8BitStrings : 0.0;
+dataLog("%8u (%5.2f%%) 8 bit%12llu chars %12llu bytes avg length %6.1f\n", m_number8BitStrings, percent8Bit, m_total8BitData, m_total8BitData, average8bitLength);
+
+double percent16Bit = m_totalNumberStrings ? ((double)m_number16BitStrings * 100) / (double)m_totalNumberStrings : 0.0;
+d
[webkit-changes] [127800] trunk/Source
Title: [127800] trunk/Source
Revision 127800
Author jam...@google.com
Date 2012-09-06 16:50:59 -0700 (Thu, 06 Sep 2012)
Log Message
[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
https://bugs.webkit.org/show_bug.cgi?id=96024
Reviewed by Adam Barth.
When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
We don't need to link anything in to WebKit.dll.
Source/WebCore:
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
* WebKit.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/WebKit.gypi
Diff
Modified: trunk/Source/WebCore/ChangeLog (127799 => 127800)
--- trunk/Source/WebCore/ChangeLog 2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebCore/ChangeLog 2012-09-06 23:50:59 UTC (rev 127800)
@@ -1,3 +1,15 @@
+2012-09-06 James Robinson
+
+[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
+https://bugs.webkit.org/show_bug.cgi?id=96024
+
+Reviewed by Adam Barth.
+
+When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
+We don't need to link anything in to WebKit.dll.
+
+* WebCore.gyp/WebCore.gyp:
+
2012-09-06 Simon Fraser
Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127799 => 127800)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-06 23:50:59 UTC (rev 127800)
@@ -46,8 +46,6 @@
# binary and increasing the speed of gdb.
'enable_svg%': 1,
-# If set to 1, links against the cc library from the chromium repository
-# instead of the compositor implementation files in platform/graphics/chromium
'use_libcc_for_compositor%': 0,
'enable_wexit_time_destructors': 1,
@@ -2214,12 +2212,8 @@
'webcore_svg',
],
}],
-['use_libcc_for_compositor==1', {
+['use_libcc_for_compositor==0', {
'dependencies': [
-'<(chromium_src_dir)/cc/cc.gyp:cc'
- ],
-}, { # use_libcc_for_compositor==0
- 'dependencies': [
'webcore_chromium_compositor'
],
}]
Modified: trunk/Source/WebKit/chromium/ChangeLog (127799 => 127800)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 23:50:59 UTC (rev 127800)
@@ -1,5 +1,17 @@
2012-09-06 James Robinson
+[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
+https://bugs.webkit.org/show_bug.cgi?id=96024
+
+Reviewed by Adam Barth.
+
+When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
+We don't need to link anything in to WebKit.dll.
+
+* WebKit.gyp:
+
+2012-09-06 James Robinson
+
[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
https://bugs.webkit.org/show_bug.cgi?id=96007
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (127799 => 127800)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-09-06 23:50:59 UTC (rev 127800)
@@ -54,7 +54,7 @@
# stored as is. Otherwise, a concatenated file is stored.
'debug_devtools%': 0,
-# If set to 1, links against the compositor bindings from the chromium repository
+# If set to 1, uses the compositor bindings provided by PlatformSupport
# instead of the compositor-implementation binding files in WebKit/chromium/src.
'use_libcc_for_compositor%': 0,
@@ -838,9 +838,6 @@
},
}],
['use_libcc_for_compositor==1', {
-'dependencies': [
-'<(chromium_src_dir)/webkit/compositor_bindings/compositor_bindings.gyp:webkit_compositor_bindings',
-],
'sources!': [
'../../WebCore/platform/chromium/support/CCThreadImpl.cpp',
'../../WebCore/platform/chromium/support/CCThreadImpl.h',
Modified: trunk/Source/WebKit/chromium/WebKit.gypi (127799 => 127800)
--- trunk/Source/WebKit/chromium/WebKit.gypi 2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebKit/chromium/WebKit.gypi 2012-09-06 23:50:59 UTC (rev 127800)
@@ -101,8 +101,8 @@
'tests/TreeTestHelpers.h',
'tests/URLTestHelpers.cpp',
'tests/URLTestHelpers.h',
+'tests/WebCompositorInitializer.h',
'tests/WebComp
[webkit-changes] [127801] trunk/Source/WebCore
Title: [127801] trunk/Source/WebCore Revision 127801 Author msab...@apple.com Date 2012-09-06 16:52:46 -0700 (Thu, 06 Sep 2012) Log Message Add 8 bit string data path to TextRun https://bugs.webkit.org/show_bug.cgi?id=95812 Reviewed by Dan Bernstein. Added 8 bit string path to TextRun. Refactored TextRun::data() and ::characters into 8 and 16 bit versions. Made corresponding changes to users of TextRun. For efl, gtk, qt and win platform specific code using TextRun, only the methods have been renamed and the creation of 8 bit TextRuns has been disabled via compilation flags. Someone knowledgeable in those platforms will need to make corresponding changes to enable 8 bit processing of TextRuns. No changes to functionality - behavior covered by existing tests. * platform/graphics/Font.cpp: (WebCore::normalizeSpacesInternal): (WebCore::Font::normalizeSpaces): (WebCore::Font:normalizeSpaces): (WebCore::Font::codePath): (WebCore::Font::expansionOpportunityCount): * platform/graphics/Font.h: (WebCore::Font::characterRangeCodePath): (WebCore::Font::normalizeSpaces): * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText): * platform/graphics/TextRun.cpp: (ExpectedTextRunSize): * platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::subRun): (WebCore::TextRun::operator[]): (WebCore::TextRun::data8): (WebCore::TextRun::data16): (WebCore::TextRun::characters8): (WebCore::TextRun::characters16): (WebCore::TextRun::is8Bit): (WebCore::TextRun::setText): (WebCore::TextRun::setCharactersLength): * platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): * platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: (WebCore::HarfBuzzShaperBase::setNormalizedBuffer): * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: (WebCore::HarfBuzzShaper::HarfBuzzShaper): * platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::collectComplexTextRuns): (WebCore::ComplexTextController::adjustGlyphsAndAdvances): * platform/graphics/pango/FontPango.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText): * platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText): * platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): (WebCore::UniscribeController::shapeAndPlaceItem): * rendering/RenderText.cpp: (WebCore::RenderText::computeCanUseSimpleFontCodePath): * rendering/svg/SVGTextMetrics.cpp: (WebCore::SVGTextMetrics::SVGTextMetrics): * rendering/svg/SVGTextMetricsBuilder.cpp: (WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder): (WebCore::SVGTextMetricsBuilder::measureTextRenderer): * svg/SVGFontData.cpp: (WebCore::SVGFontData::applySVGGlyphSelection): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Font.cpp trunk/Source/WebCore/platform/graphics/Font.h trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp trunk/Source/WebCore/platform/graphics/TextRun.cpp trunk/Source/WebCore/platform/graphics/TextRun.h trunk/Source/WebCore/platform/graphics/WidthIterator.cpp trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp trunk/Source/WebCore/platform/graphics/pango/FontPango.cpp trunk/Source/WebCore/platform/graphics/qt/FontQt.cpp trunk/Source/WebCore/platform/graphics/win/UniscribeController.cpp trunk/Source/WebCore/rendering/RenderText.cpp trunk/Source/WebCore/rendering/svg/SVGTextMetrics.cpp trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp trunk/Source/WebCore/svg/SVGFontData.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (127800 => 127801) --- trunk/Source/WebCore/ChangeLog 2012-09-06 23:50:59 UTC (rev 127800) +++ trunk/Source/WebCore/ChangeLog 2012-09-06 23:52:46 UTC (rev 127801) @@ -1,3 +1,77 @@ +2012-09-06 Michael Saboff + +Add 8 bit string data path to TextRun +https://bugs.webkit.org/show_bug.cgi?id=95812 + +Reviewed by Dan Bernstein. + +Added 8 bit string path to TextRun. Refactored TextRun::data() and ::characters into +8 and 16 bit versions. Made corresponding changes to users of TextRun. +For efl, gtk, qt and win platform specific code using TextRun, only the methods have +been renamed and the creation of 8 bit TextRuns has been disabled via compilation +flags. Someone knowledgeable in those platforms will need to make corresponding changes +to enable 8 bit processing of TextRuns. + +No changes to functionality - behavior covered by existing tes
[webkit-changes] [127802] trunk/Source
Title: [127802] trunk/Source Revision 127802 Author commit-qu...@webkit.org Date 2012-09-06 16:54:49 -0700 (Thu, 06 Sep 2012) Log Message [Qt] Deprecate String += operator https://bugs.webkit.org/show_bug.cgi?id=95895 Patch by Lauro Neto on 2012-09-06 Reviewed by Benjamin Poulain. Source/WebCore: Replaced String +=() with append. * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraMediaControlsStyleSheet): Source/WTF: Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard. * wtf/Platform.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp Diff Modified: trunk/Source/WTF/ChangeLog (127801 => 127802) --- trunk/Source/WTF/ChangeLog 2012-09-06 23:52:46 UTC (rev 127801) +++ trunk/Source/WTF/ChangeLog 2012-09-06 23:54:49 UTC (rev 127802) @@ -1,3 +1,14 @@ +2012-09-06 Lauro Neto + +[Qt] Deprecate String += operator +https://bugs.webkit.org/show_bug.cgi?id=95895 + +Reviewed by Benjamin Poulain. + +Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard. + +* wtf/Platform.h: + 2012-09-06 Michael Saboff ENH: Add Logging to StringImpl to track String Types Modified: trunk/Source/WTF/wtf/Platform.h (127801 => 127802) --- trunk/Source/WTF/wtf/Platform.h 2012-09-06 23:52:46 UTC (rev 127801) +++ trunk/Source/WTF/wtf/Platform.h 2012-09-06 23:54:49 UTC (rev 127802) @@ -1185,7 +1185,7 @@ #define WTF_USE_ZLIB 1 #endif -#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN) +#if PLATFORM(GTK) || PLATFORM(WIN) #define WTF_DEPRECATED_STRING_OPERATORS #endif Modified: trunk/Source/WebCore/ChangeLog (127801 => 127802) --- trunk/Source/WebCore/ChangeLog 2012-09-06 23:52:46 UTC (rev 127801) +++ trunk/Source/WebCore/ChangeLog 2012-09-06 23:54:49 UTC (rev 127802) @@ -1,3 +1,15 @@ +2012-09-06 Lauro Neto + +[Qt] Deprecate String += operator +https://bugs.webkit.org/show_bug.cgi?id=95895 + +Reviewed by Benjamin Poulain. + +Replaced String +=() with append. + +* platform/qt/RenderThemeQt.cpp: +(WebCore::RenderThemeQt::extraMediaControlsStyleSheet): + 2012-09-06 Michael Saboff Add 8 bit string data path to TextRun Modified: trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp (127801 => 127802) --- trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp 2012-09-06 23:52:46 UTC (rev 127801) +++ trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp 2012-09-06 23:54:49 UTC (rev 127802) @@ -539,7 +539,7 @@ String result = String(mediaControlsQtUserAgentStyleSheet, sizeof(mediaControlsQtUserAgentStyleSheet)); if (m_page && m_page->chrome()->requiresFullscreenForVideoPlayback()) -result += String(mediaControlsQtFullscreenUserAgentStyleSheet, sizeof(mediaControlsQtFullscreenUserAgentStyleSheet)); +result.append(String(mediaControlsQtFullscreenUserAgentStyleSheet, sizeof(mediaControlsQtFullscreenUserAgentStyleSheet))); return result; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127803] trunk/LayoutTests
Title: [127803] trunk/LayoutTests Revision 127803 Author t...@chromium.org Date 2012-09-06 17:21:17 -0700 (Thu, 06 Sep 2012) Log Message Chromium Linux EWS bots and CQ bots are flaky https://bugs.webkit.org/show_bug.cgi?id=96041 Reviewed by Adam Barth. Skip platform/chromium-linux/compositing/gestures tests on the Chromium Linux EWS and CQ bots. By marking them as flaky, they won't be run (the bots use --skip-failing-tests which causes them to skip these tests). These will still run on the waterfall bots. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127802 => 127803) --- trunk/LayoutTests/ChangeLog 2012-09-06 23:54:49 UTC (rev 127802) +++ trunk/LayoutTests/ChangeLog 2012-09-07 00:21:17 UTC (rev 127803) @@ -1,3 +1,17 @@ +2012-09-06 Tony Chang + +Chromium Linux EWS bots and CQ bots are flaky +https://bugs.webkit.org/show_bug.cgi?id=96041 + +Reviewed by Adam Barth. + +Skip platform/chromium-linux/compositing/gestures tests on the +Chromium Linux EWS and CQ bots. By marking them as flaky, they won't +be run (the bots use --skip-failing-tests which causes them to skip +these tests). These will still run on the waterfall bots. + +* platform/chromium/TestExpectations: + 2012-09-06 Adam Barth New tests introduced in r127704 fail Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127802 => 127803) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-06 23:54:49 UTC (rev 127802) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-07 00:21:17 UTC (rev 127803) @@ -3594,3 +3594,5 @@ BUGWK95799 MAC : touchadjustment/iframe-boundary.html = TEXT BUGWK95813 : fast/innerHTML/innerHTML-iframe.html = TEXT PASS + +BUGWK96041 LINUX : platform/chromium-linux/compositing/gestures = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127804] trunk/LayoutTests
Title: [127804] trunk/LayoutTests
Revision 127804
Author commit-qu...@webkit.org
Date 2012-09-06 17:36:29 -0700 (Thu, 06 Sep 2012)
Log Message
[EFL] 2 mathml tests need rebaseline after r127769
https://bugs.webkit.org/show_bug.cgi?id=96009
Unreviewed EFL gardening.
Update baselines for 2 mathml test cases needed after
r127769.
Patch by Christophe Dumez on 2012-09-06
* platform/efl/mathml/presentation/roots-expected.png:
* platform/efl/mathml/presentation/roots-expected.txt:
* platform/efl/mathml/presentation/sup-expected.png:
* platform/efl/mathml/presentation/sup-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/mathml/presentation/roots-expected.png
trunk/LayoutTests/platform/efl/mathml/presentation/roots-expected.txt
trunk/LayoutTests/platform/efl/mathml/presentation/sup-expected.png
trunk/LayoutTests/platform/efl/mathml/presentation/sup-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (127803 => 127804)
--- trunk/LayoutTests/ChangeLog 2012-09-07 00:21:17 UTC (rev 127803)
+++ trunk/LayoutTests/ChangeLog 2012-09-07 00:36:29 UTC (rev 127804)
@@ -1,3 +1,18 @@
+2012-09-06 Christophe Dumez
+
+[EFL] 2 mathml tests need rebaseline after r127769
+https://bugs.webkit.org/show_bug.cgi?id=96009
+
+Unreviewed EFL gardening.
+
+Update baselines for 2 mathml test cases needed after
+r127769.
+
+* platform/efl/mathml/presentation/roots-expected.png:
+* platform/efl/mathml/presentation/roots-expected.txt:
+* platform/efl/mathml/presentation/sup-expected.png:
+* platform/efl/mathml/presentation/sup-expected.txt:
+
2012-09-06 Tony Chang
Chromium Linux EWS bots and CQ bots are flaky
Modified: trunk/LayoutTests/platform/efl/mathml/presentation/roots-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/mathml/presentation/roots-expected.txt (127803 => 127804)
--- trunk/LayoutTests/platform/efl/mathml/presentation/roots-expected.txt 2012-09-07 00:21:17 UTC (rev 127803)
+++ trunk/LayoutTests/platform/efl/mathml/presentation/roots-expected.txt 2012-09-07 00:36:29 UTC (rev 127804)
@@ -1,8 +1,8 @@
-layer at (0,0) size 800x600
+layer at (0,0) size 836x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x492
- RenderBlock {html} at (0,0) size 800x492
-RenderBody {body} at (8,16) size 784x460
+layer at (0,0) size 800x545
+ RenderBlock {html} at (0,0) size 800x545
+RenderBody {body} at (8,16) size 784x513
RenderBlock {p} at (0,0) size 784x18
RenderText {#text} at (0,0) size 177x19
text run at (0,0) width 177: "square root (should be red): "
@@ -181,6 +181,20 @@
text run at (0,33) width 110: "Imbricated roots: "
RenderMathMLMath {math} at (110,0) size 295x70 [padding: 0 1 0 1]
RenderText {#text} at (0,0) size 0x0
+ RenderBlock {p} at (0,476) size 784x37
+RenderText {#text} at (0,0) size 306x19
+ text run at (0,0) width 306: "Don't wrap this wide line with an implicit mrow:"
+RenderBR {br} at (306,0) size 0x19
+RenderMathMLMath {math} at (0,22) size 828x15 [padding: 0 1 0 1]
+ RenderMathMLSquareRoot {msqrt} at (1,0) size 826x15 [intrinsic padding: 3 0 0 12]
+RenderMathMLRow (anonymous) at (12,3) size 814x12
+ RenderInline {mi} at (0,0) size 407x25
+RenderText {#text} at (0,-9) size 7x25
+ text run at (0,-9) width 7: "x"
+ RenderInline {mi} at (0,0) size 407x25
+RenderText {#text} at (407,-9) size 7x25
+ text run at (407,-9) width 7: "y"
+RenderText {#text} at (0,0) size 0x0
layer at (182,169) size 20x19
RenderMathMLRoot {mroot} at (1,0) size 20x19 [intrinsic padding: 7 0 0 12]
RenderMathMLRow (anonymous) at (12,7) size 8x12
Modified: trunk/LayoutTests/platform/efl/mathml/presentation/sup-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/mathml/presentation/sup-expected.txt (127803 => 127804)
--- trunk/LayoutTests/platform/efl/mathml/presentation/sup-expected.txt 2012-09-07 00:21:17 UTC (rev 127803)
+++ trunk/LayoutTests/platform/efl/mathml/presentation/sup-expected.txt 2012-09-07 00:36:29 UTC (rev 127804)
@@ -1,8 +1,8 @@
-layer at (0,0) size 800x600
+layer at (0,0) size 822x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x50
- RenderBlock {html} at (0,0) size 800x50
-RenderBody {body} at (8,16) size 784x18
+layer at (0,0) size 800x102
+ RenderBlock {html} at (0,0) size 800x102
+RenderBody {body} at (8,16) size 784x70
RenderBlock {p} at (0,0) size 784x18
RenderText {#text} at (0,0) size 76x19
text run at (0,0) width 76: "superscript: "
@@ -16,3 +16,23 @@
RenderText {#text} at (7,-4) size 6x19
text run at (7,-4) width 6: "2"
RenderText {#text} at (0,0) size 0x0
+ RenderBlock {p} at (
[webkit-changes] [127805] trunk/Source/WTF
Title: [127805] trunk/Source/WTF
Revision 127805
Author msab...@apple.com
Date 2012-09-06 17:43:42 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed fix to r127799.
https://bugs.webkit.org/show_bug.cgi?id=95807
Unreviewed fix.
Removed extraneous "static". This code is hidden behind STRING_STATS define and
therefore is not enabled by default.
* wtf/text/StringImpl.cpp:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (127804 => 127805)
--- trunk/Source/WTF/ChangeLog 2012-09-07 00:36:29 UTC (rev 127804)
+++ trunk/Source/WTF/ChangeLog 2012-09-07 00:43:42 UTC (rev 127805)
@@ -1,3 +1,15 @@
+2012-09-06 Michael Saboff
+
+Unreviewed fix to r127799.
+https://bugs.webkit.org/show_bug.cgi?id=95807
+
+Unreviewed fix.
+
+Removed extraneous "static". This code is hidden behind STRING_STATS define and
+therefore is not enabled by default.
+
+* wtf/text/StringImpl.cpp:
+
2012-09-06 Lauro Neto
[Qt] Deprecate String += operator
Modified: trunk/Source/WTF/wtf/text/StringImpl.cpp (127804 => 127805)
--- trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-09-07 00:36:29 UTC (rev 127804)
+++ trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-09-07 00:43:42 UTC (rev 127805)
@@ -47,7 +47,7 @@
#ifdef STRING_STATS
StringStats StringImpl::m_stringStats;
-static unsigned StringStats::s_stringRemovesTillPrintStats = StringStats::s_printStringStatsFrequency;
+unsigned StringStats::s_stringRemovesTillPrintStats = StringStats::s_printStringStatsFrequency;
void StringStats::removeString(StringImpl* string)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127807] trunk/LayoutTests
Title: [127807] trunk/LayoutTests Revision 127807 Author commit-qu...@webkit.org Date 2012-09-06 18:16:46 -0700 (Thu, 06 Sep 2012) Log Message [Qt] Unskip two encoding tests that pass now https://bugs.webkit.org/show_bug.cgi?id=96013 Patch by Simon Hausmann on 2012-09-06 Reviewed by Kenneth Rohde Christiansen. The result for frame-default-enc was incorrect and we succeed in producing the existing cross-platform result. The other test passes just fine. * platform/qt/Skipped: * platform/qt/fast/encoding/frame-default-enc-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Removed Paths trunk/LayoutTests/platform/qt/fast/encoding/frame-default-enc-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127806 => 127807) --- trunk/LayoutTests/ChangeLog 2012-09-07 00:57:27 UTC (rev 127806) +++ trunk/LayoutTests/ChangeLog 2012-09-07 01:16:46 UTC (rev 127807) @@ -1,3 +1,17 @@ +2012-09-06 Simon Hausmann + +[Qt] Unskip two encoding tests that pass now +https://bugs.webkit.org/show_bug.cgi?id=96013 + +Reviewed by Kenneth Rohde Christiansen. + +The result for frame-default-enc was incorrect and we succeed in +producing the existing cross-platform result. The other test passes +just fine. + +* platform/qt/Skipped: +* platform/qt/fast/encoding/frame-default-enc-expected.txt: Removed. + 2012-09-06 Christophe Dumez [EFL] 2 mathml tests need rebaseline after r127769 Modified: trunk/LayoutTests/platform/qt/Skipped (127806 => 127807) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-07 00:57:27 UTC (rev 127806) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-07 01:16:46 UTC (rev 127807) @@ -1739,8 +1739,6 @@ fast/forms/textarea-metrics.html fast/history/window-open.html fast/dom/Range/range-expand.html -fast/encoding/frame-default-enc.html -fast/encoding/invalid-xml.html fast/events/attempt-scroll-with-no-scrollbars.html fast/events/key-events-in-input-button.html fast/forms/radio/input-radio-checked-tab.html Deleted: trunk/LayoutTests/platform/qt/fast/encoding/frame-default-enc-expected.txt (127806 => 127807) --- trunk/LayoutTests/platform/qt/fast/encoding/frame-default-enc-expected.txt 2012-09-07 00:57:27 UTC (rev 127806) +++ trunk/LayoutTests/platform/qt/fast/encoding/frame-default-enc-expected.txt 2012-09-07 01:16:46 UTC (rev 127807) @@ -1,12 +0,0 @@ - - - -Frame: '-->' - - - - -Frame: '-->' - -ISO-8859-1 -The above line should be your browser's default encoding, and not x-mac-cyrillic. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127808] trunk/LayoutTests
Title: [127808] trunk/LayoutTests
Revision 127808
Author timothy_hor...@apple.com
Date 2012-09-06 18:29:12 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed, revert part of http://trac.webkit.org/changeset/127698
which accidentally didn't get reverted in
http://trac.webkit.org/changeset/127774.
* inspector/debugger/debugger-expand-scope-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (127807 => 127808)
--- trunk/LayoutTests/ChangeLog 2012-09-07 01:16:46 UTC (rev 127807)
+++ trunk/LayoutTests/ChangeLog 2012-09-07 01:29:12 UTC (rev 127808)
@@ -1,3 +1,11 @@
+2012-09-06 Tim Horton
+
+Unreviewed, revert part of http://trac.webkit.org/changeset/127698
+which accidentally didn't get reverted in
+http://trac.webkit.org/changeset/127774.
+
+* inspector/debugger/debugger-expand-scope-expected.txt:
+
2012-09-06 Simon Hausmann
[Qt] Unskip two encoding tests that pass now
Modified: trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt (127807 => 127808)
--- trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt 2012-09-07 01:16:46 UTC (rev 127807)
+++ trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt 2012-09-07 01:29:12 UTC (rev 127808)
@@ -19,8 +19,6 @@
arguments: Arguments[1]
makeClosureLocalVar: "local.TextParam"
n: "TextParam"
-WindowWith Block
-makeClosure: function makeClosure(n) {
WindowGlobal
Script execution resumed.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127809] trunk/Source
Title: [127809] trunk/Source
Revision 127809
Author msab...@apple.com
Date 2012-09-06 18:29:12 -0700 (Thu, 06 Sep 2012)
Log Message
16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
https://bugs.webkit.org/show_bug.cgi?id=95810
Reviewed by Benjamin Poulain.
Source/_javascript_Core:
Added 8 bit path that copies the contents of an 8 bit fiber to the 16 bit buffer
when resolving a 16 bit rope.
* runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeSlowCase):
Source/WTF:
New copy routine that takes an 8 bit source and a 16 bit destination. Used when copying
the contents of an 8 bit fiber to the 16 bit buffer when resolving a 16 bit rope.
* wtf/text/StringImpl.h:
(WTF::StringImpl::copyChars):
(StringImpl):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSString.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127808 => 127809)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-07 01:29:12 UTC (rev 127808)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-07 01:29:12 UTC (rev 127809)
@@ -1,3 +1,16 @@
+2012-09-06 Michael Saboff
+
+16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
+https://bugs.webkit.org/show_bug.cgi?id=95810
+
+Reviewed by Benjamin Poulain.
+
+Added 8 bit path that copies the contents of an 8 bit fiber to the 16 bit buffer
+when resolving a 16 bit rope.
+
+* runtime/JSString.cpp:
+(JSC::JSRopeString::resolveRopeSlowCase):
+
2012-09-06 Gavin Barraclough
JS test suite puts incorrect limitations on Function.toString()
Modified: trunk/Source/_javascript_Core/runtime/JSString.cpp (127808 => 127809)
--- trunk/Source/_javascript_Core/runtime/JSString.cpp 2012-09-07 01:29:12 UTC (rev 127808)
+++ trunk/Source/_javascript_Core/runtime/JSString.cpp 2012-09-07 01:29:12 UTC (rev 127809)
@@ -130,7 +130,10 @@
for (size_t i = 0; i < s_maxInternalRopeLength && m_fibers[i]; ++i) {
StringImpl* string = m_fibers[i]->m_value.impl();
unsigned length = string->length();
-StringImpl::copyChars(position, string->characters(), length);
+if (string->is8Bit())
+StringImpl::copyChars(position, string->characters8(), length);
+else
+StringImpl::copyChars(position, string->characters16(), length);
position += length;
m_fibers[i].clear();
}
@@ -202,7 +205,10 @@
StringImpl* string = static_cast(currentFiber->m_value.impl());
unsigned length = string->length();
position -= length;
-StringImpl::copyChars(position, string->characters(), length);
+if (string->is8Bit())
+StringImpl::copyChars(position, string->characters8(), length);
+else
+StringImpl::copyChars(position, string->characters16(), length);
}
ASSERT(buffer == position);
Modified: trunk/Source/WTF/ChangeLog (127808 => 127809)
--- trunk/Source/WTF/ChangeLog 2012-09-07 01:29:12 UTC (rev 127808)
+++ trunk/Source/WTF/ChangeLog 2012-09-07 01:29:12 UTC (rev 127809)
@@ -1,5 +1,19 @@
2012-09-06 Michael Saboff
+16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
+https://bugs.webkit.org/show_bug.cgi?id=95810
+
+Reviewed by Benjamin Poulain.
+
+New copy routine that takes an 8 bit source and a 16 bit destination. Used when copying
+the contents of an 8 bit fiber to the 16 bit buffer when resolving a 16 bit rope.
+
+* wtf/text/StringImpl.h:
+(WTF::StringImpl::copyChars):
+(StringImpl):
+
+2012-09-06 Michael Saboff
+
Unreviewed fix to r127799.
https://bugs.webkit.org/show_bug.cgi?id=95807
Modified: trunk/Source/WTF/wtf/text/StringImpl.h (127808 => 127809)
--- trunk/Source/WTF/wtf/text/StringImpl.h 2012-09-07 01:29:12 UTC (rev 127808)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2012-09-07 01:29:12 UTC (rev 127809)
@@ -611,6 +611,12 @@
memcpy(destination, source, numCharacters * sizeof(T));
}
+ALWAYS_INLINE static void copyChars(UChar* destination, const LChar* source, unsigned numCharacters)
+{
+for (unsigned i = 0; i < numCharacters; ++i)
+destination[i] = source[i];
+}
+
// Some string features, like refcounting and the atomicity flag, are not
// thread-safe. We achieve thread safety by isolation, giving each thread
// its own copy of the string.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127811] trunk/Source/WebCore
Title: [127811] trunk/Source/WebCore
Revision 127811
Author morr...@google.com
Date 2012-09-06 19:25:36 -0700 (Thu, 06 Sep 2012)
Log Message
[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
https://bugs.webkit.org/show_bug.cgi?id=95831
Reviewed by Dimitri Glazkov.
Originally, the availability of author shadows was decided by ShadowRoot class.
This change moves that responsibility to each Element subclasses to make future
author shadow support improvement local to each replaced elements, rather than
touching ShadowRoot.cpp for reach.
No new tests. Should have no behavioral change.
* dom/Element.h:
* dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot):
* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
* svg/SVGElement.h:
(SVGElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/svg/SVGElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127810 => 127811)
--- trunk/Source/WebCore/ChangeLog 2012-09-07 01:42:53 UTC (rev 127810)
+++ trunk/Source/WebCore/ChangeLog 2012-09-07 02:25:36 UTC (rev 127811)
@@ -1,3 +1,25 @@
+2012-09-06 MORITA Hajime
+
+[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
+https://bugs.webkit.org/show_bug.cgi?id=95831
+
+Reviewed by Dimitri Glazkov.
+
+Originally, the availability of author shadows was decided by ShadowRoot class.
+This change moves that responsibility to each Element subclasses to make future
+author shadow support improvement local to each replaced elements, rather than
+touching ShadowRoot.cpp for reach.
+
+No new tests. Should have no behavioral change.
+
+* dom/Element.h:
+* dom/ShadowRoot.cpp:
+(WebCore::allowsAuthorShadowRoot):
+* html/HTMLTextFormControlElement.h:
+(HTMLTextFormControlElement):
+* svg/SVGElement.h:
+(SVGElement):
+
2012-09-06 Adam Barth
[V8] Weave creationContext through toV8 and related functions
Modified: trunk/Source/WebCore/dom/Element.h (127810 => 127811)
--- trunk/Source/WebCore/dom/Element.h 2012-09-07 01:42:53 UTC (rev 127810)
+++ trunk/Source/WebCore/dom/Element.h 2012-09-07 02:25:36 UTC (rev 127811)
@@ -275,6 +275,7 @@
ElementShadow* shadow() const;
ElementShadow* ensureShadow();
virtual void willAddAuthorShadowRoot() { }
+virtual bool areAuthorShadowsAllowed() const { return true; }
ShadowRoot* userAgentShadowRoot() const;
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (127810 => 127811)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-09-07 01:42:53 UTC (rev 127810)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-09-07 02:25:36 UTC (rev 127811)
@@ -82,23 +82,7 @@
if (RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled())
return true;
#endif
-
-// FIXME: The elements in Shadow DOM of an input element assumes that they have renderer if the input
-// element has a renderer. However, this does not hold until input elemnet is AuthorShadowDOM-ready.
-// So we would like to prohibit having a AuthorShadowDOM for a while. The same thing happens to
-// textarea element also.
-// https://bugs.webkit.org/show_bug.cgi?id=92608
-if (isHTMLInputElement(element))
-return false;
-
-// FIXME: We disable multiple shadow subtrees for SVG for while, because there will be problems to support it.
-// https://bugs.webkit.org/show_bug.cgi?id=78205
-// Especially SVG TREF recreates shadow root dynamically.
-// https://bugs.webkit.org/show_bug.cgi?id=77938
-if (element->isSVGElement())
-return false;
-
-return true;
+return element->areAuthorShadowsAllowed();
}
PassRefPtr ShadowRoot::create(Element* element, ExceptionCode& ec)
Modified: trunk/Source/WebCore/html/HTMLInputElement.h (127810 => 127811)
--- trunk/Source/WebCore/html/HTMLInputElement.h 2012-09-07 01:42:53 UTC (rev 127810)
+++ trunk/Source/WebCore/html/HTMLInputElement.h 2012-09-07 02:25:36 UTC (rev 127811)
@@ -290,6 +290,9 @@
HTMLInputElement(const QualifiedName&, Document*, HTMLFormElement*, bool createdByParser);
void createShadowSubtree();
virtual void defaultEventHandler(Event*);
+// FIXME: Author shadows should be allowed
+// https://bugs.webkit.org/show_bug.cgi?id=92608
+virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
private:
enum AutoCompleteSetting { Uninitialized, On, Off };
Modified: trunk/Source/WebCore/svg/SVGElement.h (127810 => 127811)
--- trunk/Source/WebCore/svg/SVGElement.h 2012-09-07 01:42:53 UTC (rev 127810)
+++ trunk/Source/WebCore/svg/SVGElement.h 2012-09-07 02:25:36 UTC (rev 127811)
@@ -136,6 +136,10 @@
void reportAttributeParsingError(SVGParsingError, const Attribute&);
+//
[webkit-changes] [127812] trunk/Source/WebCore
Title: [127812] trunk/Source/WebCore
Revision 127812
Author t...@chromium.org
Date 2012-09-06 19:43:17 -0700 (Thu, 06 Sep 2012)
Log Message
Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const
https://bugs.webkit.org/show_bug.cgi?id=95907
Reviewed by Ojan Vafai.
This is refactoring to make RenderBox::computeLogicalWidth const. Make some methods that
get called by computeLogicalWidth const. We path in a struct that we populate with values.
No new tests, this is just a refactoring.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion): Make a LogicalExtentComputedValues to
hold results.
(WebCore::RenderBox::computePositionedLogicalWidth): Make const.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Change output to use LogicalExtentComputedValues
instead of 4 separate params.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Make const.
* rendering/RenderBox.h:
(RenderBox): Add const and change out params to LogicalExtentComputedValues.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Make a LogicalExtentComputedValues to
hold results.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderTable.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127811 => 127812)
--- trunk/Source/WebCore/ChangeLog 2012-09-07 02:25:36 UTC (rev 127811)
+++ trunk/Source/WebCore/ChangeLog 2012-09-07 02:43:17 UTC (rev 127812)
@@ -1,3 +1,28 @@
+2012-09-06 Tony Chang
+
+Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const
+https://bugs.webkit.org/show_bug.cgi?id=95907
+
+Reviewed by Ojan Vafai.
+
+This is refactoring to make RenderBox::computeLogicalWidth const. Make some methods that
+get called by computeLogicalWidth const. We path in a struct that we populate with values.
+
+No new tests, this is just a refactoring.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeLogicalWidthInRegion): Make a LogicalExtentComputedValues to
+hold results.
+(WebCore::RenderBox::computePositionedLogicalWidth): Make const.
+(WebCore::RenderBox::computePositionedLogicalWidthUsing): Change output to use LogicalExtentComputedValues
+instead of 4 separate params.
+(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Make const.
+* rendering/RenderBox.h:
+(RenderBox): Add const and change out params to LogicalExtentComputedValues.
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::computeLogicalWidth): Make a LogicalExtentComputedValues to
+hold results.
+
2012-09-06 MORITA Hajime
[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (127811 => 127812)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2012-09-07 02:25:36 UTC (rev 127811)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2012-09-07 02:43:17 UTC (rev 127812)
@@ -1625,7 +1625,12 @@
if (isOutOfFlowPositioned()) {
// FIXME: This calculation is not patched for block-flow yet.
// https://bugs.webkit.org/show_bug.cgi?id=46500
-computePositionedLogicalWidth(region, offsetFromLogicalTopOfFirstPage);
+LogicalExtentComputedValues computedValues;
+computePositionedLogicalWidth(computedValues, region, offsetFromLogicalTopOfFirstPage);
+setLogicalWidth(computedValues.m_extent);
+setLogicalLeft(computedValues.m_position);
+setMarginStart(computedValues.m_margins.m_start);
+setMarginEnd(computedValues.m_margins.m_end);
return;
}
@@ -2540,10 +2545,10 @@
}
}
-void RenderBox::computePositionedLogicalWidth(RenderRegion* region, LayoutUnit offsetFromLogicalTopOfFirstPage)
+void RenderBox::computePositionedLogicalWidth(LogicalExtentComputedValues& computedValues, RenderRegion* region, LayoutUnit offsetFromLogicalTopOfFirstPage) const
{
if (isReplaced()) {
-computePositionedLogicalWidthReplaced(); // FIXME: Patch for regions when we add replaced element support.
+computePositionedLogicalWidthReplaced(computedValues); // FIXME: Patch for regions when we add replaced element support.
return;
}
@@ -2578,8 +2583,6 @@
const LayoutUnit bordersPlusPadding = borderAndPaddingLogicalWidth();
const Length marginLogicalLeft = isHorizontal ? style()->marginLeft() : style()->marginTop();
const Length marginLogicalRight = isHorizontal ? style()->marginRight() : style()->marginBottom();
-LayoutUnit& marginLogicalLeftAlias = m_marginBox.mutableLogicalLeft(style()->writingMode());
-LayoutUnit& marginLogicalRightAlias = m_marginBox.mutableLogicalRight(style()->writingMode());
Length logicalLeftLength = style()->logicalLeft();
[webkit-changes] [127813] trunk/LayoutTests
Title: [127813] trunk/LayoutTests Revision 127813 Author commit-qu...@webkit.org Date 2012-09-06 19:45:23 -0700 (Thu, 06 Sep 2012) Log Message fast/table/empty-row-crash.html and fast/table/inline-form-assert.html should be dumpAsText tests https://bugs.webkit.org/show_bug.cgi?id=95613 Patch by Pravin D on 2012-09-06 Reviewed by Julien Chaffraix. Modified the test cases empty-row-crash.html and inline-form-assert.html to dumpAsText tests. As the testcases check for crash/assert and not for the correctness of content layout or painting they can be safely modified to dumpAsText tests. * fast/table/empty-row-crash-expected.txt: Added. New expected file. * fast/table/empty-row-crash.html: Added a short description about the testcase. * fast/table/inline-form-assert-expected.txt: Added. New expected file. * fast/table/inline-form-assert.html: * platform/chromium-linux/fast/table/empty-row-crash-expected.png: Removed. * platform/chromium-linux/fast/table/inline-form-assert-expected.png: Removed. * platform/chromium-mac-snowleopard/fast/table/empty-row-crash-expected.png: Removed. * platform/chromium-mac-snowleopard/fast/table/inline-form-assert-expected.png: Removed. * platform/chromium-mac/fast/table/empty-row-crash-expected.png: Removed. * platform/chromium-mac/fast/table/inline-form-assert-expected.png: Removed. * platform/chromium-win/fast/table/empty-row-crash-expected.png: Removed. * platform/chromium-win/fast/table/empty-row-crash-expected.txt: Removed. * platform/chromium-win/fast/table/inline-form-assert-expected.png: Removed. * platform/chromium-win/fast/table/inline-form-assert-expected.txt: Removed. * platform/efl/fast/table/empty-row-crash-expected.png: Removed. * platform/efl/fast/table/empty-row-crash-expected.txt: Removed. * platform/efl/fast/table/inline-form-assert-expected.png: Removed. * platform/efl/fast/table/inline-form-assert-expected.txt: Removed. * platform/gtk/fast/table/empty-row-crash-expected.png: Removed. * platform/gtk/fast/table/empty-row-crash-expected.txt: Removed. * platform/gtk/fast/table/inline-form-assert-expected.png: Removed. * platform/gtk/fast/table/inline-form-assert-expected.txt: Removed. * platform/mac/fast/table/empty-row-crash-expected.png: Removed. * platform/mac/fast/table/empty-row-crash-expected.txt: Removed. * platform/mac/fast/table/inline-form-assert-expected.png: Removed. * platform/mac/fast/table/inline-form-assert-expected.txt: Removed. * platform/qt/fast/table/empty-row-crash-expected.png: Removed. * platform/qt/fast/table/empty-row-crash-expected.txt: Removed. * platform/qt/fast/table/inline-form-assert-expected.png: Removed. * platform/qt/fast/table/inline-form-assert-expected.txt: Removed. Removed obsolete baselines. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/table/empty-row-crash.html trunk/LayoutTests/fast/table/inline-form-assert.html Added Paths trunk/LayoutTests/fast/table/empty-row-crash-expected.txt trunk/LayoutTests/fast/table/inline-form-assert-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/chromium-linux/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/chromium-mac/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/chromium-mac/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/chromium-win/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/chromium-win/fast/table/empty-row-crash-expected.txt trunk/LayoutTests/platform/chromium-win/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/chromium-win/fast/table/inline-form-assert-expected.txt trunk/LayoutTests/platform/efl/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/efl/fast/table/empty-row-crash-expected.txt trunk/LayoutTests/platform/efl/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/efl/fast/table/inline-form-assert-expected.txt trunk/LayoutTests/platform/gtk/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/gtk/fast/table/empty-row-crash-expected.txt trunk/LayoutTests/platform/gtk/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/gtk/fast/table/inline-form-assert-expected.txt trunk/LayoutTests/platform/mac/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/mac/fast/table/empty-row-crash-expected.txt trunk/LayoutTests/platform/mac/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/mac/fast/table/inline-form-assert-expected.txt trunk/LayoutTests/platform/qt/fast/table/empty-row-crash-expected.png trunk/LayoutTests/platform/qt/fast/table/empty-row-crash-expected.txt trunk/LayoutTests/platform/qt/fast/table/inline-form-assert-expected.png trunk/LayoutTests/platform/qt/fas
[webkit-changes] [127814] trunk/LayoutTests
Title: [127814] trunk/LayoutTests
Revision 127814
Author commit-qu...@webkit.org
Date 2012-09-06 20:17:29 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed, rolling out r127808.
http://trac.webkit.org/changeset/127808
https://bugs.webkit.org/show_bug.cgi?id=96057
geoff rolled back in his change, but not this part (Requested
by thorton on #webkit).
Patch by Sheriff Bot on 2012-09-06
* inspector/debugger/debugger-expand-scope-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (127813 => 127814)
--- trunk/LayoutTests/ChangeLog 2012-09-07 02:45:23 UTC (rev 127813)
+++ trunk/LayoutTests/ChangeLog 2012-09-07 03:17:29 UTC (rev 127814)
@@ -1,3 +1,14 @@
+2012-09-06 Sheriff Bot
+
+Unreviewed, rolling out r127808.
+http://trac.webkit.org/changeset/127808
+https://bugs.webkit.org/show_bug.cgi?id=96057
+
+geoff rolled back in his change, but not this part (Requested
+by thorton on #webkit).
+
+* inspector/debugger/debugger-expand-scope-expected.txt:
+
2012-09-06 Pravin D
fast/table/empty-row-crash.html and fast/table/inline-form-assert.html should be dumpAsText tests
Modified: trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt (127813 => 127814)
--- trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt 2012-09-07 02:45:23 UTC (rev 127813)
+++ trunk/LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt 2012-09-07 03:17:29 UTC (rev 127814)
@@ -19,6 +19,8 @@
arguments: Arguments[1]
makeClosureLocalVar: "local.TextParam"
n: "TextParam"
+WindowWith Block
+makeClosure: function makeClosure(n) {
WindowGlobal
Script execution resumed.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
