[webkit-changes] [128265] trunk/Source/JavaScriptCore
Title: [128265] trunk/Source/_javascript_Core
Revision 128265
Author gga...@apple.com
Date 2012-09-11 23:14:56 -0700 (Tue, 11 Sep 2012)
Log Message
Don't allocate a backing store just for a function's name
https://bugs.webkit.org/show_bug.cgi?id=96468
Reviewed by Oliver Hunt.
Treat function.name like function.length etc., and use a custom getter.
This saves space in closures.
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName):
* debugger/DebuggerCallFrame.h:
(DebuggerCallFrame): Updated for interface change.
* runtime/Executable.h:
(JSC::JSFunction::JSFunction): Do a little inlining.
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation): Gone now. That's the point of the patch.
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::nameGetter):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty): Added custom accessors for .name
just like .length and others.
* runtime/JSFunction.h:
(JSC::JSFunction::create):
(JSFunction): Updated for interface changes.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp
trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h
trunk/Source/_javascript_Core/runtime/Executable.h
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (128264 => 128265)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-12 05:52:21 UTC (rev 128264)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-12 06:14:56 UTC (rev 128265)
@@ -1,3 +1,39 @@
+2012-09-11 Geoffrey Garen gga...@apple.com
+
+Don't allocate a backing store just for a function's name
+https://bugs.webkit.org/show_bug.cgi?id=96468
+
+Reviewed by Oliver Hunt.
+
+Treat function.name like function.length etc., and use a custom getter.
+This saves space in closures.
+
+* debugger/DebuggerCallFrame.cpp:
+(JSC::DebuggerCallFrame::functionName):
+* debugger/DebuggerCallFrame.h:
+(DebuggerCallFrame): Updated for interface change.
+
+* runtime/Executable.h:
+(JSC::JSFunction::JSFunction): Do a little inlining.
+
+* runtime/JSFunction.cpp:
+(JSC::JSFunction::finishCreation): Gone now. That's the point of the patch.
+
+(JSC::JSFunction::name):
+(JSC::JSFunction::displayName):
+(JSC::JSFunction::nameGetter):
+(JSC::JSFunction::getOwnPropertySlot):
+(JSC::JSFunction::getOwnPropertyDescriptor):
+(JSC::JSFunction::getOwnPropertyNames):
+(JSC::JSFunction::put):
+(JSC::JSFunction::deleteProperty):
+(JSC::JSFunction::defineOwnProperty): Added custom accessors for .name
+just like .length and others.
+
+* runtime/JSFunction.h:
+(JSC::JSFunction::create):
+(JSFunction): Updated for interface changes.
+
2012-09-11 Mark Hahnenberg mhahnenb...@apple.com
IncrementalSweeper should not sweep/free Zapped blocks
Modified: trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp (128264 => 128265)
--- trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp 2012-09-12 05:52:21 UTC (rev 128264)
+++ trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp 2012-09-12 06:14:56 UTC (rev 128265)
@@ -36,18 +36,18 @@
namespace JSC {
-const String* DebuggerCallFrame::functionName() const
+String DebuggerCallFrame::functionName() const
{
if (!m_callFrame-codeBlock())
-return 0;
+return String();
if (!m_callFrame-callee())
-return 0;
+return String();
JSObject* function = m_callFrame-callee();
if (!function || !function-inherits(JSFunction::s_info))
-return 0;
-return jsCastJSFunction*(function)-name(m_callFrame);
+return String();
+return jsCastJSFunction*(function)-name(m_callFrame);
}
String DebuggerCallFrame::calculatedFunctionName() const
Modified: trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h (128264 => 128265)
--- trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h 2012-09-12 05:52:21 UTC (rev 128264)
+++ trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h 2012-09-12 06:14:56 UTC (rev 128265)
@@ -51,7 +51,7 @@
CallFrame* callFrame() const { return m_callFrame; }
JSGlobalObject* dynamicGlobalObject() const { return m_callFrame-dynamicGlobalObject(); }
JSScope* scope() const { return m_callFrame-scope(); }
-JS_EXPORT_PRIVATE const String* functionName() const;
+JS_EXPORT_PRIVATE String functionName() const;
JS_EXPORT_PRIVATE String calculatedFunctionName() const;
JS_EXPORT_PRIVATE Type type() const;
JS_EXPORT_PRIVATE JSObject*
[webkit-changes] [128266] trunk/Source/JavaScriptCore
Title: [128266] trunk/Source/_javascript_Core Revision 128266 Author gga...@apple.com Date 2012-09-11 23:27:26 -0700 (Tue, 11 Sep 2012) Log Message 2012-09-11 Geoffrey Garen gga...@apple.com First step to fixing the Windows build: Remove old symbols. * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def Diff Modified: trunk/Source/_javascript_Core/ChangeLog (128265 => 128266) --- trunk/Source/_javascript_Core/ChangeLog 2012-09-12 06:14:56 UTC (rev 128265) +++ trunk/Source/_javascript_Core/ChangeLog 2012-09-12 06:27:26 UTC (rev 128266) @@ -1,5 +1,11 @@ 2012-09-11 Geoffrey Garen gga...@apple.com +First step to fixing the Windows build: Remove old symbols. + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: + +2012-09-11 Geoffrey Garen gga...@apple.com + Don't allocate a backing store just for a function's name https://bugs.webkit.org/show_bug.cgi?id=96468 Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (128265 => 128266) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2012-09-12 06:14:56 UTC (rev 128265) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2012-09-12 06:27:26 UTC (rev 128266) @@ -163,7 +163,6 @@ ?detachThread@WTF@@YAXI@Z ?didTimeOut@TimeoutChecker@JSC@@QAE_NPAVExecState@2@@Z ?deleteAllCompiledCode@Heap@JSC@@QAEXXZ -?displayName@JSFunction@JSC@@QAE?BVString@WTF@@PAVExecState@2@@Z ?dtoa@WTF@@YAXQADNAA_NAAHAAI@Z ?dumpAllOptions@Options@JSC@@SAXPAU_iobuf@@@Z ?dumpCallFrame@Interpreter@JSC@@QAEXPAVExecState@2@@Z @@ -253,7 +252,6 @@ ?monotonicallyIncreasingTime@WTF@@YANXZ ?monthFromDayInYear@WTF@@YAHH_N@Z ?msToYear@WTF@@YAHN@Z -?name@JSFunction@JSC@@QAEABVString@WTF@@PAVExecState@2@@Z ?neuter@ArrayBufferView@WTF@@MAEXXZ ?newUninitialized@CString@WTF@@SA?AV12@IAAPAD@Z ?notifyWriteSlow@SymbolTableEntry@JSC@@AAEXXZ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128267] trunk/Source/WebKit/mac
Title: [128267] trunk/Source/WebKit/mac Revision 128267 Author gga...@apple.com Date 2012-09-11 23:40:09 -0700 (Tue, 11 Sep 2012) Log Message Mac build fix: Commit a file I forgot. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame functionName]): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebScriptDebugDelegate.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (128266 => 128267) --- trunk/Source/WebKit/mac/ChangeLog 2012-09-12 06:27:26 UTC (rev 128266) +++ trunk/Source/WebKit/mac/ChangeLog 2012-09-12 06:40:09 UTC (rev 128267) @@ -1,3 +1,10 @@ +2012-09-11 Geoffrey Garen gga...@apple.com + +Mac build fix: Commit a file I forgot. + +* WebView/WebScriptDebugDelegate.mm: +(-[WebScriptCallFrame functionName]): + 2012-09-11 Michael Saboff msab...@apple.com Build fixed for http://trac.webkit.org/changeset/128243 Modified: trunk/Source/WebKit/mac/WebView/WebScriptDebugDelegate.mm (128266 => 128267) --- trunk/Source/WebKit/mac/WebView/WebScriptDebugDelegate.mm 2012-09-12 06:27:26 UTC (rev 128266) +++ trunk/Source/WebKit/mac/WebView/WebScriptDebugDelegate.mm 2012-09-12 06:40:09 UTC (rev 128267) @@ -203,8 +203,8 @@ if (!_private-debuggerCallFrame) return nil; -const String* functionName = _private-debuggerCallFrame-functionName(); -return functionName ? nsStringNilIfEmpty(*functionName) : nil; +String functionName = _private-debuggerCallFrame-functionName(); +return nsStringNilIfEmpty(functionName); } // Returns the pending exception for this frame (nil if none). ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128269] trunk/Source
Title: [128269] trunk/Source
Revision 128269
Author ael...@chromium.org
Date 2012-09-12 00:02:02 -0700 (Wed, 12 Sep 2012)
Log Message
[chromium] Flip Y and swizzle inside compositeAndReadback implementation
https://bugs.webkit.org/show_bug.cgi?id=96458
Reviewed by James Robinson.
Currently, compositeAndReadback API assumes a GL-style texture
and is converted to the normal software format in WebViewImpl.
For the software implementation, this API would result in two
redundant conversions. This patch makes the conversion inside
CCRendererGL instead. I rolled my own for loop as I didn't find the
appropriate function within raw Skia.
No new tests (covered by existing layout tests).
Source/WebCore:
* platform/graphics/chromium/cc/CCRendererGL.cpp:
(WebCore::CCRendererGL::getFramebufferPixels):
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRendererGL.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (128268 => 128269)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 06:46:24 UTC (rev 128268)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 07:02:02 UTC (rev 128269)
@@ -1,3 +1,22 @@
+2012-09-12 Alexandre Elias ael...@chromium.org
+
+[chromium] Flip Y and swizzle inside compositeAndReadback implementation
+https://bugs.webkit.org/show_bug.cgi?id=96458
+
+Reviewed by James Robinson.
+
+Currently, compositeAndReadback API assumes a GL-style texture
+and is converted to the normal software format in WebViewImpl.
+For the software implementation, this API would result in two
+redundant conversions. This patch makes the conversion inside
+CCRendererGL instead. I rolled my own for loop as I didn't find the
+appropriate function within raw Skia.
+
+No new tests (covered by existing layout tests).
+
+* platform/graphics/chromium/cc/CCRendererGL.cpp:
+(WebCore::CCRendererGL::getFramebufferPixels):
+
2012-09-11 Ryuan Choi ryuan.c...@samsung.com
[CMAKE] Supply feature defines to CodeGeneratorTestRunner.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCRendererGL.cpp (128268 => 128269)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCRendererGL.cpp 2012-09-12 06:46:24 UTC (rev 128268)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCRendererGL.cpp 2012-09-12 07:02:02 UTC (rev 128269)
@@ -1160,7 +1160,7 @@
GLC(m_context, m_context-texParameteri(GraphicsContext3D::TEXTURE_2D, GraphicsContext3D::TEXTURE_WRAP_S, GraphicsContext3D::CLAMP_TO_EDGE));
GLC(m_context, m_context-texParameteri(GraphicsContext3D::TEXTURE_2D, GraphicsContext3D::TEXTURE_WRAP_T, GraphicsContext3D::CLAMP_TO_EDGE));
// Copy the contents of the current (IOSurface-backed) framebuffer into a temporary texture.
-GLC(m_context, m_context-copyTexImage2D(GraphicsContext3D::TEXTURE_2D, 0, GraphicsContext3D::RGBA, 0, 0, rect.maxX(), rect.maxY(), 0));
+GLC(m_context, m_context-copyTexImage2D(GraphicsContext3D::TEXTURE_2D, 0, GraphicsContext3D::RGBA, 0, 0, viewportSize().width(), viewportSize().height(), 0));
temporaryFBO = m_context-createFramebuffer();
// Attach this texture to an FBO, and perform the readback from that FBO.
GLC(m_context, m_context-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, temporaryFBO));
@@ -1169,9 +1169,26 @@
ASSERT(m_context-checkFramebufferStatus(GraphicsContext3D::FRAMEBUFFER) == GraphicsContext3D::FRAMEBUFFER_COMPLETE);
}
-GLC(m_context, m_context-readPixels(rect.x(), rect.y(), rect.width(), rect.height(),
- GraphicsContext3D::RGBA, GraphicsContext3D::UNSIGNED_BYTE, pixels));
+OwnPtruint8_t srcPixels = adoptPtr(new uint8_t[rect.width() * rect.height() * 4]);
+GLC(m_context, m_context-readPixels(rect.x(), viewportSize().height() - rect.maxY(), rect.width(), rect.height(),
+ GraphicsContext3D::RGBA, GraphicsContext3D::UNSIGNED_BYTE, srcPixels.get()));
+uint8_t* destPixels = static_castuint8_t*(pixels);
+size_t rowBytes = rect.width() * 4;
+int numRows = rect.height();
+size_t totalBytes = numRows * rowBytes;
+for (size_t destY = 0; destY totalBytes; destY += rowBytes) {
+// Flip Y axis.
+size_t srcY = totalBytes - destY - rowBytes;
+// Swizzle BGRA - RGBA.
+for (size_t x = 0; x rowBytes; x += 4) {
+destPixels[destY + (x+0)] = srcPixels.get()[srcY + (x+2)];
+destPixels[destY + (x+1)] = srcPixels.get()[srcY + (x+1)];
+destPixels[destY + (x+2)] = srcPixels.get()[srcY + (x+0)];
+destPixels[destY + (x+3)] = srcPixels.get()[srcY + (x+3)];
+}
+}
+
if (doWorkaround) {
[webkit-changes] [128270] trunk/LayoutTests
Title: [128270] trunk/LayoutTests
Revision 128270
Author joc...@chromium.org
Date 2012-09-12 00:29:52 -0700 (Wed, 12 Sep 2012)
Log Message
Change fast/events/popup-blocking-timers.html to generate a user action for each popup
https://bugs.webkit.org/show_bug.cgi?id=96475
Reviewed by Adam Barth.
The chromium port only allows one user gesture gated action per user
gesture.
* fast/events/popup-blocking-timers-expected.txt:
* fast/events/popup-blocking-timers.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt
trunk/LayoutTests/fast/events/popup-blocking-timers.html
Diff
Modified: trunk/LayoutTests/ChangeLog (128269 => 128270)
--- trunk/LayoutTests/ChangeLog 2012-09-12 07:02:02 UTC (rev 128269)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 07:29:52 UTC (rev 128270)
@@ -1,3 +1,16 @@
+2012-09-12 Jochen Eisinger joc...@chromium.org
+
+Change fast/events/popup-blocking-timers.html to generate a user action for each popup
+https://bugs.webkit.org/show_bug.cgi?id=96475
+
+Reviewed by Adam Barth.
+
+The chromium port only allows one user gesture gated action per user
+gesture.
+
+* fast/events/popup-blocking-timers-expected.txt:
+* fast/events/popup-blocking-timers.html:
+
2012-09-11 Kent Tamura tk...@chromium.org
[Chromium] Test expectation update
Modified: trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt (128269 => 128270)
--- trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt 2012-09-12 07:02:02 UTC (rev 128269)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt 2012-09-12 07:29:52 UTC (rev 128270)
@@ -1,4 +1,4 @@
-Click Here
+Click Here (6 times)
Test calling window.open() directly. A popup should be allowed.
PASS newWindow is non-null.
Test calling window.open() with a 0 ms delay. A popup should be allowed.
Modified: trunk/LayoutTests/fast/events/popup-blocking-timers.html (128269 => 128270)
--- trunk/LayoutTests/fast/events/popup-blocking-timers.html 2012-09-12 07:02:02 UTC (rev 128269)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers.html 2012-09-12 07:29:52 UTC (rev 128270)
@@ -4,6 +4,7 @@
var newWindow;
var intervalId;
var firstIntervalExecution = true;
+var clickNumber = 0;
if (window.testRunner) {
testRunner.dumpAsText();
@@ -13,57 +14,59 @@
}
function clickHandler() {
-newWindow = window.open(about:blank);
-self.focus();
-debug(Test calling window.open() directly. A popup should be allowed.);
-shouldBeNonNull(newWindow);
-
-setTimeout(function() {
+clickNumber++;
+if (clickNumber == 1) {
newWindow = window.open(about:blank);
self.focus();
-debug(Test calling window.open() with a 0 ms delay. A popup should be allowed.)
+debug(Test calling window.open() directly. A popup should be allowed.);
shouldBeNonNull(newWindow);
-}, 0);
-
-setTimeout(function() {
-newWindow = window.open(about:blank);
-self.focus();
-debug(Test calling window.open() with a 1000 ms delay. A popup should be allowed.)
-shouldBeNonNull(newWindow);
-}, 1000);
-
-setTimeout(function() {
-newWindow = window.open(about:blank);
-self.focus();
-debug(Test calling window.open() with a 1001 ms delay. A popup should not be allowed.)
-shouldBeUndefined(newWindow);
-
-if (window.testRunner)
-testRunner.notifyDone();
-}, 1001);
-
-intervalId = setInterval(function() {
-debug(Test calling window.open() in a 100 ms interval. A popup should only be allowed on the first execution of the interval.);
-newWindow = window.open(about:blank);
-self.focus();
-if (firstIntervalExecution) {
+} else if (clickNumber == 2) {
+setTimeout(function() {
+newWindow = window.open(about:blank);
+self.focus();
+debug(Test calling window.open() with a 0 ms delay. A popup should be allowed.)
shouldBeNonNull(newWindow);
-firstIntervalExecution = false;
-} else {
-shouldBeUndefined(newWindow);
-clearInterval(intervalId);
-}
-}, 100);
-
-setTimeout(function() {
+}, 0);
+} else if (clickNumber == 3) {
+intervalId = setInterval(function() {
+
[webkit-changes] [128271] trunk/Source/WebKit2
Title: [128271] trunk/Source/WebKit2
Revision 128271
Author da...@apple.com
Date 2012-09-12 00:35:58 -0700 (Wed, 12 Sep 2012)
Log Message
Make NetscapePlugin::m_timers use HashMapOwnPtr instead of deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=96469
Reviewed by Dan Bernstein.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::scheduleTimer): Call release rather than leakPtr when
entering a timer into the map.
(WebKit::NetscapePlugin::unscheduleTimer): Take an existing timer from the map
with the take function rather than the roundabout code needed before.
(WebKit::NetscapePlugin::destroy): Remove now-unneeded call to deleteAllValues.
* WebProcess/Plugins/Netscape/NetscapePlugin.h: Change the value type for
TimerMap to OwnPtrTimer rather than Timer*.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (128270 => 128271)
--- trunk/Source/WebKit2/ChangeLog 2012-09-12 07:29:52 UTC (rev 128270)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-12 07:35:58 UTC (rev 128271)
@@ -1,3 +1,19 @@
+2012-09-12 Darin Adler da...@apple.com
+
+Make NetscapePlugin::m_timers use HashMapOwnPtr instead of deleteAllValues
+https://bugs.webkit.org/show_bug.cgi?id=96469
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::scheduleTimer): Call release rather than leakPtr when
+entering a timer into the map.
+(WebKit::NetscapePlugin::unscheduleTimer): Take an existing timer from the map
+with the take function rather than the roundabout code needed before.
+(WebKit::NetscapePlugin::destroy): Remove now-unneeded call to deleteAllValues.
+* WebProcess/Plugins/Netscape/NetscapePlugin.h: Change the value type for
+TimerMap to OwnPtrTimer rather than Timer*.
+
2012-09-11 Anders Carlsson ander...@apple.com
Accelerated compositing should always be forced when using the tiled drawing area
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (128270 => 128271)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2012-09-12 07:29:52 UTC (rev 128270)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2012-09-12 07:35:58 UTC (rev 128271)
@@ -375,21 +375,15 @@
// FIXME: Based on the plug-in visibility, figure out if we should throttle the timer, or if we should start it at all.
timer-start();
-m_timers.set(timerID, timer.leakPtr());
+m_timers.set(timerID, timer.release());
return timerID;
}
void NetscapePlugin::unscheduleTimer(unsigned timerID)
{
-TimerMap::iterator it = m_timers.find(timerID);
-if (it == m_timers.end())
-return;
-
-OwnPtrTimer timer = adoptPtr(it-second);
-m_timers.remove(it);
-
-timer-stop();
+if (OwnPtrTimer timer = m_timers.take(timerID))
+timer-stop();
}
double NetscapePlugin::contentsScaleFactor()
@@ -687,7 +681,6 @@
platformDestroy();
-deleteAllValues(m_timers);
m_timers.clear();
}
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (128270 => 128271)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2012-09-12 07:29:52 UTC (rev 128270)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2012-09-12 07:35:58 UTC (rev 128271)
@@ -308,7 +308,7 @@
WebCore::RunLoop::TimerTimer m_timer;
};
-typedef HashMapunsigned, Timer* TimerMap;
+typedef HashMapunsigned, OwnPtrTimer TimerMap;
TimerMap m_timers;
unsigned m_nextTimerID;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128272] trunk/Tools
Title: [128272] trunk/Tools Revision 128272 Author commit-qu...@webkit.org Date 2012-09-12 00:39:51 -0700 (Wed, 12 Sep 2012) Log Message [WK2][WTR] Some of TestRunner special options are not reset before testing https://bugs.webkit.org/show_bug.cgi?id=96384 Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-09-12 Reviewed by Kenneth Rohde Christiansen. Now values of the following special options are reset: void setAcceptsEditing(in boolean value); void setCloseRemainingWindowsWhenComplete(in boolean value); void setXSSAuditorEnabled(in boolean value); void setAllowFileAccessFromFileURLs(in boolean value); void setPluginsEnabled(in boolean value); void setPopupBlockingEnabled(in boolean value); * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp Diff Modified: trunk/Tools/ChangeLog (128271 => 128272) --- trunk/Tools/ChangeLog 2012-09-12 07:35:58 UTC (rev 128271) +++ trunk/Tools/ChangeLog 2012-09-12 07:39:51 UTC (rev 128272) @@ -1,3 +1,21 @@ +2012-09-12 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com + +[WK2][WTR] Some of TestRunner special options are not reset before testing +https://bugs.webkit.org/show_bug.cgi?id=96384 + +Reviewed by Kenneth Rohde Christiansen. + +Now values of the following special options are reset: +void setAcceptsEditing(in boolean value); +void setCloseRemainingWindowsWhenComplete(in boolean value); +void setXSSAuditorEnabled(in boolean value); +void setAllowFileAccessFromFileURLs(in boolean value); +void setPluginsEnabled(in boolean value); +void setPopupBlockingEnabled(in boolean value); + +* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: +(WTR::InjectedBundle::beginTesting): + 2012-09-11 Ryuan Choi ryuan.c...@samsung.com [CMAKE] Supply feature defines to CodeGeneratorTestRunner. Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (128271 => 128272) --- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2012-09-12 07:35:58 UTC (rev 128271) +++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2012-09-12 07:39:51 UTC (rev 128272) @@ -242,11 +242,17 @@ WKBundleSetMinimumLogicalFontSize(m_bundle, m_pageGroup, 9); WKBundleSetMinimumTimerInterval(m_bundle, m_pageGroup, 0.010); // 10 milliseconds (DOMTimer::s_minDefaultTimerInterval) WKBundleSetSpatialNavigationEnabled(m_bundle, m_pageGroup, false); +WKBundleSetAllowFileAccessFromFileURLs(m_bundle, m_pageGroup, true); +WKBundleSetPluginsEnabled(m_bundle, m_pageGroup, true); +WKBundleSetPopupBlockingEnabled(m_bundle, m_pageGroup, false); WKBundleRemoveAllUserContent(m_bundle, m_pageGroup); m_testRunner-setShouldDumpFrameLoadCallbacks(booleanForKey(settings, DumpFrameLoadDelegates)); m_testRunner-setUserStyleSheetEnabled(false); +m_testRunner-setXSSAuditorEnabled(false); +m_testRunner-setCloseRemainingWindowsWhenComplete(false); +m_testRunner-setAcceptsEditing(true); page()-prepare(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128273] trunk
Title: [128273] trunk
Revision 128273
Author joc...@chromium.org
Date 2012-09-12 00:53:59 -0700 (Wed, 12 Sep 2012)
Log Message
Source/WebKit/chromium: [chromium] consumable user gesture count off for input events
https://bugs.webkit.org/show_bug.cgi?id=96373
Reviewed by Adam Barth.
Don't create a UserGestureIndicator in the chromium layer, as it will
already be created by webcore's event handler. Creating multiple
UserGestureIndicator objects for the same object would allow to execute
multiple user-gesture-gated actions per user gesture such as opening a
new window.
* public/WebInputEvent.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
Tools: [chromium] Consume a user gesture when creating a new view.
https://bugs.webkit.org/show_bug.cgi?id=96373
Reviewed by Adam Barth.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
LayoutTests: [chromium] Only allow one user-gesture gated action per user action.
https://bugs.webkit.org/show_bug.cgi?id=96373
Reviewed by Adam Barth.
* platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt: Added.
* platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebInputEvent.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
Added Paths
trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt
trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html
Diff
Modified: trunk/LayoutTests/ChangeLog (128272 => 128273)
--- trunk/LayoutTests/ChangeLog 2012-09-12 07:39:51 UTC (rev 128272)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 07:53:59 UTC (rev 128273)
@@ -1,5 +1,15 @@
2012-09-12 Jochen Eisinger joc...@chromium.org
+[chromium] Only allow one user-gesture gated action per user action.
+https://bugs.webkit.org/show_bug.cgi?id=96373
+
+Reviewed by Adam Barth.
+
+* platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt: Added.
+* platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html: Added.
+
+2012-09-12 Jochen Eisinger joc...@chromium.org
+
Change fast/events/popup-blocking-timers.html to generate a user action for each popup
https://bugs.webkit.org/show_bug.cgi?id=96475
Added: trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt (0 => 128273)
--- trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt 2012-09-12 07:53:59 UTC (rev 128273)
@@ -0,0 +1,4 @@
+Test that only a single popup is allowed in response to a single user action. The test passes if only one popup is created.
+
+Click Here
+PASSED
Added: trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html (0 => 128273)
--- trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html 2012-09-12 07:53:59 UTC (rev 128273)
@@ -0,0 +1,41 @@
+!DOCTYPE html
+html
+body
+p
+Test that only a single popup is allowed in response to a single
+user action. The test passes if only one popup is created.
+/p
+button id=button _onclick_=popup()Click Here/button
+div id=console/div
+script
+function popup() {
+window.open(about:blank, window1);
+window.open(about:blank, window2);
+if (window.testRunner) {
+if (testRunner.windowCount() == windowCount + 1)
+document.getElementById(console).innerText = PASSED;
+else
+document.getElementById(console).innerText = FAILED;
+testRunner.notifyDone();
+}
+}
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.setCanOpenWindows();
+testRunner.setPopupBlockingEnabled(true);
+testRunner.setCloseRemainingWindowsWhenComplete(true);
+testRunner.waitUntilDone();
+windowCount = testRunner.windowCount();
+
+var button = document.getElementById(button);
+
+if (window.eventSender) {
+eventSender.mouseMoveTo(button.offsetLeft + button.offsetWidth / 2, button.offsetTop + button.offsetHeight / 2);
+eventSender.mouseDown();
+eventSender.mouseUp();
+
[webkit-changes] [128274] trunk/Source/WebCore
Title: [128274] trunk/Source/WebCore
Revision 128274
Author kenn...@webkit.org
Date 2012-09-12 00:55:48 -0700 (Wed, 12 Sep 2012)
Log Message
[EFL] Clean up the RenderTheme Edje caching
https://bugs.webkit.org/show_bug.cgi?id=96016
Reviewed by Gyuyoung Kim.
Refactor the Edje parts caching to be easier to understand and use
proper C++ constructs.
* platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::toEdjeGroup):
Converts the enum to the given edje group name.
(WebCore::setSourceGroupForEdjeObject):
Basically a wrapper around evas_object_file_set, but handles
errors, which was done slightly differently all over.
(WebCore::RenderThemeEfl::ThemePartCacheEntry::ThemePartCacheEntry):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::~ThemePartCacheEntry):
(WebCore::createCairoSurfaceFor):
(WebCore::isFormElementTooLargeToDisplay):
Methods used when creating ThemePartCacheEntry'es.
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
New methods for creating and reusing an cache entry. If you do
not supply a new size, the original size will be used, and it is
thus more effective.
(WebCore::RenderThemeEfl::getThemePartFromCache):
New method for requesting a theme part. If it doesn't exist
it will additinally be loaded and added to the cache.
(WebCore::RenderThemeEfl::flushThemePartCache):
Remove the entire cache and free the assets.
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::themePath):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::~RenderThemeEfl):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(ThemePartCacheEntry):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebCore/platform/efl/RenderThemeEfl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128273 => 128274)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 07:53:59 UTC (rev 128273)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 07:55:48 UTC (rev 128274)
@@ -1,3 +1,58 @@
+2012-09-12 Kenneth Rohde Christiansen kenn...@webkit.org
+
+[EFL] Clean up the RenderTheme Edje caching
+https://bugs.webkit.org/show_bug.cgi?id=96016
+
+Reviewed by Gyuyoung Kim.
+
+Refactor the Edje parts caching to be easier to understand and use
+proper C++ constructs.
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore):
+(WebCore::toEdjeGroup):
+
+Converts the enum to the given edje group name.
+
+(WebCore::setSourceGroupForEdjeObject):
+
+Basically a wrapper around evas_object_file_set, but handles
+errors, which was done slightly differently all over.
+
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::ThemePartCacheEntry):
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::~ThemePartCacheEntry):
+
+(WebCore::createCairoSurfaceFor):
+(WebCore::isFormElementTooLargeToDisplay):
+
+Methods used when creating ThemePartCacheEntry'es.
+
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
+
+New methods for creating and reusing an cache entry. If you do
+not supply a new size, the original size will be used, and it is
+thus more effective.
+
+(WebCore::RenderThemeEfl::getThemePartFromCache):
+
+New method for requesting a theme part. If it doesn't exist
+it will additinally be loaded and added to the cache.
+
+(WebCore::RenderThemeEfl::flushThemePartCache):
+
+Remove the entire cache and free the assets.
+
+(WebCore::RenderThemeEfl::paintThemePart):
+(WebCore::RenderThemeEfl::themePath):
+(WebCore::RenderThemeEfl::loadTheme):
+(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
+(WebCore::RenderThemeEfl::~RenderThemeEfl):
+(WebCore::RenderThemeEfl::emitMediaButtonSignal):
+* platform/efl/RenderThemeEfl.h:
+(RenderThemeEfl):
+(ThemePartCacheEntry):
+
2012-09-12 Alexandre Elias ael...@chromium.org
[chromium] Flip Y and swizzle inside compositeAndReadback implementation
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (128273 => 128274)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-09-12 07:53:59 UTC (rev 128273)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-09-12 07:55:48 UTC (rev 128274)
@@ -84,12 +84,67 @@
#define _ASSERT_ON_RELEASE_RETURN_VAL(o, val, fmt, ...) \
do { if (!o) { EINA_LOG_CRIT(fmt, ## __VA_ARGS__); ASSERT(o); return val; } } while (0)
+
+static const char* toEdjeGroup(FormType type)
+{
+static const char* groups[] = {
+#define W(n) webkit/widget/n
+W(button),
+W(radio),
[webkit-changes] [128278] trunk
Title: [128278] trunk
Revision 128278
Author commit-qu...@webkit.org
Date 2012-09-12 02:10:06 -0700 (Wed, 12 Sep 2012)
Log Message
[WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
https://bugs.webkit.org/show_bug.cgi?id=96388
Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Added WKBundleGetWorkerThreadCount() function to Injected Bundle private API.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGetWorkerThreadCount):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::workerThreadCount): Returns count of worker threads.
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Tools:
Exported TestRunner.workerThreadCount as readonly attribute.
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
(WTR::TestRunner::workerThreadCount): Returns count of worker threads.
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method.
(TestRunner):
LayoutTests:
Unskipped corresponding tests.
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
Diff
Modified: trunk/LayoutTests/ChangeLog (128277 => 128278)
--- trunk/LayoutTests/ChangeLog 2012-09-12 08:54:00 UTC (rev 128277)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 09:10:06 UTC (rev 128278)
@@ -1,3 +1,14 @@
+2012-09-12 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
+
+[WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
+https://bugs.webkit.org/show_bug.cgi?id=96388
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskipped corresponding tests.
+
+* platform/wk2/Skipped:
+
2012-09-12 Jochen Eisinger joc...@chromium.org
[chromium] Only allow one user-gesture gated action per user action.
Modified: trunk/LayoutTests/platform/wk2/Skipped (128277 => 128278)
--- trunk/LayoutTests/platform/wk2/Skipped 2012-09-12 08:54:00 UTC (rev 128277)
+++ trunk/LayoutTests/platform/wk2/Skipped 2012-09-12 09:10:06 UTC (rev 128278)
@@ -673,13 +673,6 @@
# WebKitTestRunner should dump text/plain content as text
http/tests/incremental/slow-utf8-text.pl
-# WebKitTestRunner needs layoutTestController.workerThreadCount
-fast/workers/dedicated-worker-lifecycle.html
-fast/workers/shared-worker-frame-lifecycle.html
-fast/workers/shared-worker-lifecycle.html
-fast/workers/worker-lifecycle.html
-fast/workers/worker-close-more.html
-
# WebKitTestRunner needs layoutTestController.callShouldCloseOnWebView
fast/events/onbeforeunload-focused-iframe.html
Modified: trunk/Source/WebKit2/ChangeLog (128277 => 128278)
--- trunk/Source/WebKit2/ChangeLog 2012-09-12 08:54:00 UTC (rev 128277)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-12 09:10:06 UTC (rev 128278)
@@ -1,3 +1,21 @@
+2012-09-12 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
+
+[WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
+https://bugs.webkit.org/show_bug.cgi?id=96388
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Added WKBundleGetWorkerThreadCount() function to Injected Bundle private API.
+
+* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+(WKBundleGetWorkerThreadCount):
+* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+* WebProcess/InjectedBundle/InjectedBundle.cpp:
+(WebKit::InjectedBundle::workerThreadCount): Returns count of worker threads.
+(WebKit):
+* WebProcess/InjectedBundle/InjectedBundle.h:
+(InjectedBundle):
+
2012-09-12 Darin Adler da...@apple.com
Make NetscapePlugin::m_timers use HashMapOwnPtr instead of deleteAllValues
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (128277 => 128278)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-12 08:54:00 UTC (rev 128277)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-12 09:10:06 UTC (rev 128278)
@@ -286,6 +286,12 @@
toImpl(bundleRef)-setPageVisibilityState(toImpl(pageRef), state, isInitialState);
}
+size_t WKBundleGetWorkerThreadCount(WKBundleRef)
+{
+// Actually do not need argument here, keeping it however for consistency.
+return InjectedBundle::workerThreadCount();
+}
+
void
[webkit-changes] [128279] trunk/Source
Title: [128279] trunk/Source
Revision 128279
Author loi...@chromium.org
Date 2012-09-12 02:13:23 -0700 (Wed, 12 Sep 2012)
Log Message
Web Inspector: NMI move String* instrumentation to wtf.
https://bugs.webkit.org/show_bug.cgi?id=96405
Reviewed by Yury Semikhatsky.
This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
Source/WebCore:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::countObjectSize):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
Source/WebKit/chromium:
Tested by webkit_unit_tests.
* tests/MemoryInstrumentationTest.cpp:
(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::TEST):
Source/WTF:
Tested by webkit_unit_tests.
* wtf/MemoryInstrumentation.h:
(WebCore):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
* wtf/text/AtomicString.h:
(AtomicString):
(WTF::AtomicString::reportMemoryUsage):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::reportMemoryUsage):
* wtf/text/WTFString.h:
(String):
(WTF::String::reportMemoryUsage):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryInstrumentation.h
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.cpp
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.h
trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp
trunk/Source/WebCore/platform/SharedBuffer.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (128278 => 128279)
--- trunk/Source/WTF/ChangeLog 2012-09-12 09:10:06 UTC (rev 128278)
+++ trunk/Source/WTF/ChangeLog 2012-09-12 09:13:23 UTC (rev 128279)
@@ -1,3 +1,29 @@
+2012-09-12 Ilya Tikhonovsky loi...@chromium.org
+
+Web Inspector: NMI move String* instrumentation to wtf.
+https://bugs.webkit.org/show_bug.cgi?id=96405
+
+Reviewed by Yury Semikhatsky.
+
+This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
+
+Tested by webkit_unit_tests.
+
+* wtf/MemoryInstrumentation.h:
+(WebCore):
+(WebCore::MemoryInstrumentation::addRootObject):
+(WebCore::MemoryObjectInfo::reportObjectInfo):
+(WebCore::MemoryClassInfo::MemoryClassInfo):
+* wtf/text/AtomicString.h:
+(AtomicString):
+(WTF::AtomicString::reportMemoryUsage):
+* wtf/text/StringImpl.h:
+(StringImpl):
+(WTF::StringImpl::reportMemoryUsage):
+* wtf/text/WTFString.h:
+(String):
+(WTF::String::reportMemoryUsage):
+
2012-09-11 Michael Saboff msab...@apple.com
Build fixed for http://trac.webkit.org/changeset/128243
Modified: trunk/Source/WTF/wtf/MemoryInstrumentation.h (128278 => 128279)
--- trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 09:10:06 UTC (rev 128278)
+++ trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 09:13:23 UTC (rev 128279)
@@ -43,11 +43,6 @@
typedef const char* MemoryObjectType;
-class GenericMemoryTypes {
-public:
-static MemoryObjectType Undefined;
-};
-
enum MemoryOwningType {
byPointer,
byReference
@@ -65,7 +60,7 @@
template typename T void addRootObject(const T t)
{
-addInstrumentedObject(t, GenericMemoryTypes::Undefined);
+addInstrumentedObject(t, 0);
processDeferredInstrumentedPointers();
}
@@ -184,7 +179,7 @@
{
if (!m_objectSize) {
m_objectSize = actualSize ? actualSize : sizeof(T);
-if (objectType != GenericMemoryTypes::Undefined)
+if (!objectType)
m_objectType = objectType;
}
}
@@ -197,7 +192,7 @@
class MemoryClassInfo {
public:
templatetypename T
-MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = GenericMemoryTypes::Undefined, size_t actualSize = 0)
+MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = 0, size_t actualSize = 0)
: m_memoryObjectInfo(memoryObjectInfo)
, m_memoryInstrumentation(memoryObjectInfo-memoryInstrumentation())
{
Modified: trunk/Source/WTF/wtf/text/AtomicString.h (128278 => 128279)
--- trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 09:10:06 UTC (rev 128278)
+++ trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 09:13:23 UTC (rev 128279)
@@ -154,6 +154,14 @@
#ifndef NDEBUG
void show() const;
#endif
+
+
[webkit-changes] [128281] trunk/Source/WebCore
Title: [128281] trunk/Source/WebCore
Revision 128281
Author ca...@chromium.org
Date 2012-09-12 02:32:39 -0700 (Wed, 12 Sep 2012)
Log Message
Web Inspector: Implement search and filtering on Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=95445
Patch by Eugene Klyuchnikov eustas@gmail.com on 2012-09-12
Reviewed by Yury Semikhatsky.
Implemented textual search/filtering on Timeline panel.
Fixed revealRecordAt - now it scans all records in window,
now only visible ones.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineWindowFilter):
Extracted from TimelineOverviewPane class.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
Used DFS to scan records.
(WebInspector.TimelinePanel.prototype._revealRecord):
Extracted common code.
(WebInspector.TimelineSearchFilter):
Implemented search and filtration.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (128280 => 128281)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 09:17:25 UTC (rev 128280)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 09:32:39 UTC (rev 128281)
@@ -1,3 +1,26 @@
+2012-09-12 Eugene Klyuchnikov eustas@gmail.com
+
+Web Inspector: Implement search and filtering on Timeline panel
+https://bugs.webkit.org/show_bug.cgi?id=95445
+
+Reviewed by Yury Semikhatsky.
+
+Implemented textual search/filtering on Timeline panel.
+Fixed revealRecordAt - now it scans all records in window,
+now only visible ones.
+
+* inspector/front-end/TimelineOverviewPane.js:
+(WebInspector.TimelineWindowFilter):
+Extracted from TimelineOverviewPane class.
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel):
+(WebInspector.TimelinePanel.prototype.revealRecordAt):
+Used DFS to scan records.
+(WebInspector.TimelinePanel.prototype._revealRecord):
+Extracted common code.
+(WebInspector.TimelineSearchFilter):
+Implemented search and filtration.
+
2012-09-12 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI move String* instrumentation to wtf.
Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (128280 => 128281)
--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-09-12 09:17:25 UTC (rev 128280)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-09-12 09:32:39 UTC (rev 128281)
@@ -31,7 +31,6 @@
/**
* @constructor
* @extends {WebInspector.View}
- * @implements {WebInspector.TimelinePresentationModel.Filter}
* @param {WebInspector.TimelineModel} model
*/
WebInspector.TimelineOverviewPane = function(model)
@@ -274,14 +273,6 @@
this._update();
},
-/**
- * @param {WebInspector.TimelinePresentationModel.Record} record
- */
-accept: function(record)
-{
-return record.lastChildEndTime = this._windowStartTime record.startTime = this._windowEndTime;
-},
-
windowStartTime: function()
{
return this._windowStartTime || this._model.minimumRecordTime();
@@ -1232,3 +1223,24 @@
}
WebInspector.TimelineFrameOverview.prototype.__proto__ = WebInspector.View.prototype;
+
+/**
+ * @param {WebInspector.TimelineOverviewPane} pane
+ * @constructor
+ * @implements {WebInspector.TimelinePresentationModel.Filter}
+ */
+WebInspector.TimelineWindowFilter = function(pane)
+{
+this._pane = pane;
+}
+
+WebInspector.TimelineWindowFilter.prototype = {
+/**
+ * @param {!WebInspector.TimelinePresentationModel.Record} record
+ * @return {boolean}
+ */
+accept: function(record)
+{
+return record.lastChildEndTime = this._pane._windowStartTime record.startTime = this._pane._windowEndTime;
+}
+}
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (128280 => 128281)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-09-12 09:17:25 UTC (rev 128280)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-09-12 09:32:39 UTC (rev 128281)
@@ -145,9 +145,9 @@
this._allRecordsCount = 0;
-this._presentationModel.addFilter(this._overviewPane);
+this._presentationModel.addFilter(new WebInspector.TimelineWindowFilter(this._overviewPane));
this._presentationModel.addFilter(new WebInspector.TimelineCategoryFilter());
-this._presentationModel.addFilter(new WebInspector.TimelineIsLongFilter(this));
+this._presentationModel.addFilter(new WebInspector.TimelineIsLongFilter(this));
}
// Define row height, should be in sync with styles for timeline graphs.
@@ -671,6 +671,7 @@
[webkit-changes] [128282] trunk/Source/WebKit/qt
Title: [128282] trunk/Source/WebKit/qt Revision 128282 Author abe...@webkit.org Date 2012-09-12 02:38:58 -0700 (Wed, 12 Sep 2012) Log Message [Qt] Add module identifier directive to the qmldir files https://bugs.webkit.org/show_bug.cgi?id=96406 Reviewed by Simon Hausmann. Qt5 QML modules need to be identified. Type registrations are only permitted into the namespace identified in the qmldir file's module identifier directive. Additionally this also facilitates the protection against external registrations. This patch suppresses a warning when importing the QtWebKit module. * declarative/experimental/qmldir: * declarative/qmldir: Modified Paths trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/declarative/experimental/qmldir trunk/Source/WebKit/qt/declarative/qmldir Diff Modified: trunk/Source/WebKit/qt/ChangeLog (128281 => 128282) --- trunk/Source/WebKit/qt/ChangeLog 2012-09-12 09:32:39 UTC (rev 128281) +++ trunk/Source/WebKit/qt/ChangeLog 2012-09-12 09:38:58 UTC (rev 128282) @@ -1,3 +1,18 @@ +2012-09-12 Andras Becsi andras.be...@nokia.com + +[Qt] Add module identifier directive to the qmldir files +https://bugs.webkit.org/show_bug.cgi?id=96406 + +Reviewed by Simon Hausmann. + +Qt5 QML modules need to be identified. Type registrations are only permitted +into the namespace identified in the qmldir file's module identifier directive. +Additionally this also facilitates the protection against external registrations. +This patch suppresses a warning when importing the QtWebKit module. + +* declarative/experimental/qmldir: +* declarative/qmldir: + 2012-09-11 Marcelo Lira marcelo.l...@openbossa.org Restore original value of mock scrollbars enabled in InternalSettings Modified: trunk/Source/WebKit/qt/declarative/experimental/qmldir (128281 => 128282) --- trunk/Source/WebKit/qt/declarative/experimental/qmldir 2012-09-12 09:32:39 UTC (rev 128281) +++ trunk/Source/WebKit/qt/declarative/experimental/qmldir 2012-09-12 09:38:58 UTC (rev 128282) @@ -1 +1,2 @@ +module QtWebKit.experimental plugin qmlwebkitexperimentalplugin Modified: trunk/Source/WebKit/qt/declarative/qmldir (128281 => 128282) --- trunk/Source/WebKit/qt/declarative/qmldir 2012-09-12 09:32:39 UTC (rev 128281) +++ trunk/Source/WebKit/qt/declarative/qmldir 2012-09-12 09:38:58 UTC (rev 128282) @@ -1 +1,2 @@ +module QtWebKit plugin qmlwebkitplugin ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128283] trunk/Source
Title: [128283] trunk/Source
Revision 128283
Author yu...@chromium.org
Date 2012-09-12 02:45:04 -0700 (Wed, 12 Sep 2012)
Log Message
Web Inspector: Persistent handle referenced from ScriptWrappable is double counted
https://bugs.webkit.org/show_bug.cgi?id=96483
Reviewed by Alexander Pavlov.
Source/WebCore:
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage): the handle is a part of an
array where all such handles are allocated and should not be counted here
second time. In order to make the clang plugin that validate memory instrumentation
happy we report it here as weak pointer (no-op).
Source/WTF:
* wtf/MemoryInstrumentation.h:
(WebCore::MemoryClassInfo::addWeakPointer): this method is expected to be
used on fields that are pointers to objects which are parts of bigger memory
blocks (field of another object, element in an array, object allocated in a
memory arena etc.). We don't want to count such objects' memory separately
from their owners but in order to be able to validates the memory instrumentation
with clang plugin we need to make sure all fields in instrumented objects
are reported.
(MemoryClassInfo):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryInstrumentation.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptWrappable.h
Diff
Modified: trunk/Source/WTF/ChangeLog (128282 => 128283)
--- trunk/Source/WTF/ChangeLog 2012-09-12 09:38:58 UTC (rev 128282)
+++ trunk/Source/WTF/ChangeLog 2012-09-12 09:45:04 UTC (rev 128283)
@@ -1,3 +1,20 @@
+2012-09-12 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: Persistent handle referenced from ScriptWrappable is double counted
+https://bugs.webkit.org/show_bug.cgi?id=96483
+
+Reviewed by Alexander Pavlov.
+
+* wtf/MemoryInstrumentation.h:
+(WebCore::MemoryClassInfo::addWeakPointer): this method is expected to be
+used on fields that are pointers to objects which are parts of bigger memory
+blocks (field of another object, element in an array, object allocated in a
+memory arena etc.). We don't want to count such objects' memory separately
+from their owners but in order to be able to validates the memory instrumentation
+with clang plugin we need to make sure all fields in instrumented objects
+are reported.
+(MemoryClassInfo):
+
2012-09-12 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI move String* instrumentation to wtf.
Modified: trunk/Source/WTF/wtf/MemoryInstrumentation.h (128282 => 128283)
--- trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 09:38:58 UTC (rev 128282)
+++ trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 09:45:04 UTC (rev 128283)
@@ -217,6 +217,8 @@
templatetypename VectorType void addVectorPtr(const VectorType* const vector) { m_memoryInstrumentation-addVector(*vector, m_objectType, false); }
void addRawBuffer(const void* const buffer, size_t size) { m_memoryInstrumentation-addRawBuffer(buffer, m_objectType, size); }
+void addWeakPointer(void*) { }
+
private:
MemoryObjectInfo* m_memoryObjectInfo;
MemoryInstrumentation* m_memoryInstrumentation;
Modified: trunk/Source/WebCore/ChangeLog (128282 => 128283)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 09:38:58 UTC (rev 128282)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 09:45:04 UTC (rev 128283)
@@ -1,3 +1,16 @@
+2012-09-12 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: Persistent handle referenced from ScriptWrappable is double counted
+https://bugs.webkit.org/show_bug.cgi?id=96483
+
+Reviewed by Alexander Pavlov.
+
+* bindings/v8/ScriptWrappable.h:
+(WebCore::ScriptWrappable::reportMemoryUsage): the handle is a part of an
+array where all such handles are allocated and should not be counted here
+second time. In order to make the clang plugin that validate memory instrumentation
+happy we report it here as weak pointer (no-op).
+
2012-09-12 Eugene Klyuchnikov eustas@gmail.com
Web Inspector: Implement search and filtering on Timeline panel
Modified: trunk/Source/WebCore/bindings/v8/ScriptWrappable.h (128282 => 128283)
--- trunk/Source/WebCore/bindings/v8/ScriptWrappable.h 2012-09-12 09:38:58 UTC (rev 128282)
+++ trunk/Source/WebCore/bindings/v8/ScriptWrappable.h 2012-09-12 09:45:04 UTC (rev 128283)
@@ -56,7 +56,7 @@
void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);
-info.addMember(m_wrapper);
+info.addWeakPointer(m_wrapper);
}
private:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128284] trunk/Source
Title: [128284] trunk/Source
Revision 128284
Author commit-qu...@webkit.org
Date 2012-09-12 02:46:32 -0700 (Wed, 12 Sep 2012)
Log Message
Unreviewed, rolling out r128279.
http://trac.webkit.org/changeset/128279
https://bugs.webkit.org/show_bug.cgi?id=96487
Snow Leopard compilation broken (Requested by yurys on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-12
Source/WebCore:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
(WebCore::String):
(WebCore::StringImpl):
(WebCore::AtomicString):
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::countObjectSize):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
Source/WebKit/chromium:
* tests/MemoryInstrumentationTest.cpp:
(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::TEST):
Source/WTF:
* wtf/MemoryInstrumentation.h:
(GenericMemoryTypes):
(WebCore):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
* wtf/text/AtomicString.h:
(AtomicString):
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryInstrumentation.h
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.cpp
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.h
trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp
trunk/Source/WebCore/platform/SharedBuffer.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (128283 => 128284)
--- trunk/Source/WTF/ChangeLog 2012-09-12 09:45:04 UTC (rev 128283)
+++ trunk/Source/WTF/ChangeLog 2012-09-12 09:46:32 UTC (rev 128284)
@@ -1,3 +1,23 @@
+2012-09-12 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r128279.
+http://trac.webkit.org/changeset/128279
+https://bugs.webkit.org/show_bug.cgi?id=96487
+
+Snow Leopard compilation broken (Requested by yurys on
+#webkit).
+
+* wtf/MemoryInstrumentation.h:
+(GenericMemoryTypes):
+(WebCore):
+(WebCore::MemoryInstrumentation::addRootObject):
+(WebCore::MemoryObjectInfo::reportObjectInfo):
+(WebCore::MemoryClassInfo::MemoryClassInfo):
+* wtf/text/AtomicString.h:
+(AtomicString):
+* wtf/text/StringImpl.h:
+* wtf/text/WTFString.h:
+
2012-09-12 Yury Semikhatsky yu...@chromium.org
Web Inspector: Persistent handle referenced from ScriptWrappable is double counted
Modified: trunk/Source/WTF/wtf/MemoryInstrumentation.h (128283 => 128284)
--- trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 09:45:04 UTC (rev 128283)
+++ trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 09:46:32 UTC (rev 128284)
@@ -43,6 +43,11 @@
typedef const char* MemoryObjectType;
+class GenericMemoryTypes {
+public:
+static MemoryObjectType Undefined;
+};
+
enum MemoryOwningType {
byPointer,
byReference
@@ -60,7 +65,7 @@
template typename T void addRootObject(const T t)
{
-addInstrumentedObject(t, 0);
+addInstrumentedObject(t, GenericMemoryTypes::Undefined);
processDeferredInstrumentedPointers();
}
@@ -179,7 +184,7 @@
{
if (!m_objectSize) {
m_objectSize = actualSize ? actualSize : sizeof(T);
-if (!objectType)
+if (objectType != GenericMemoryTypes::Undefined)
m_objectType = objectType;
}
}
@@ -192,7 +197,7 @@
class MemoryClassInfo {
public:
templatetypename T
-MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = 0, size_t actualSize = 0)
+MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = GenericMemoryTypes::Undefined, size_t actualSize = 0)
: m_memoryObjectInfo(memoryObjectInfo)
, m_memoryInstrumentation(memoryObjectInfo-memoryInstrumentation())
{
Modified: trunk/Source/WTF/wtf/text/AtomicString.h (128283 => 128284)
--- trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 09:45:04 UTC (rev 128283)
+++ trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 09:46:32 UTC (rev 128284)
@@ -154,14 +154,6 @@
#ifndef NDEBUG
void show() const;
#endif
-
-templatetypename MemoryObjectInfo
-void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
-{
-typename MemoryObjectInfo::ClassInfo info(memoryObjectInfo, this);
-info.addInstrumentedMember(m_string);
-}
-
private:
// The explicit constructors with AtomicString::ConstructFromLiteral must be used for literals.
AtomicString(ASCIILiteral);
Modified:
[webkit-changes] [128285] trunk/Source/WebCore
Title: [128285] trunk/Source/WebCore
Revision 128285
Author vse...@chromium.org
Date 2012-09-12 02:57:42 -0700 (Wed, 12 Sep 2012)
Log Message
Web Inspector: XMLHttpRequest instrumentation methods used by timeline should have better names.
https://bugs.webkit.org/show_bug.cgi?id=96486
Reviewed by Alexander Pavlov.
Renamed instrumentation methods.
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEventImpl):
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEventImpl):
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEventImpl):
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEventImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEvent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorTimelineAgent::didDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorTimelineAgent::willDispatchXHRLoadEvent):
(WebCore::InspectorTimelineAgent::didDispatchXHRLoadEvent):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (128284 => 128285)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 09:46:32 UTC (rev 128284)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 09:57:42 UTC (rev 128285)
@@ -1,3 +1,34 @@
+2012-09-12 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: XMLHttpRequest instrumentation methods used by timeline should have better names.
+https://bugs.webkit.org/show_bug.cgi?id=96486
+
+Reviewed by Alexander Pavlov.
+
+Renamed instrumentation methods.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore):
+(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEventImpl):
+(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEventImpl):
+(WebCore::InspectorInstrumentation::willDispatchXHRLoadEventImpl):
+(WebCore::InspectorInstrumentation::didDispatchXHRLoadEventImpl):
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEvent):
+(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEvent):
+(WebCore::InspectorInstrumentation::willDispatchXHRLoadEvent):
+(WebCore::InspectorInstrumentation::didDispatchXHRLoadEvent):
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::willDispatchXHRReadyStateChangeEvent):
+(WebCore::InspectorTimelineAgent::didDispatchXHRReadyStateChangeEvent):
+(WebCore::InspectorTimelineAgent::willDispatchXHRLoadEvent):
+(WebCore::InspectorTimelineAgent::didDispatchXHRLoadEvent):
+* inspector/InspectorTimelineAgent.h:
+(InspectorTimelineAgent):
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::callReadyStateChangeListener):
+
2012-09-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r128279.
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (128284 => 128285)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-09-12 09:46:32 UTC (rev 128284)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-09-12 09:57:42 UTC (rev 128285)
@@ -319,21 +319,21 @@
timelineAgent-didCallFunction();
}
-InspectorInstrumentationCookie InspectorInstrumentation::willChangeXHRReadyStateImpl(InstrumentingAgents* instrumentingAgents, XMLHttpRequest* request, ScriptExecutionContext* context)
+InspectorInstrumentationCookie InspectorInstrumentation::willDispatchXHRReadyStateChangeEventImpl(InstrumentingAgents* instrumentingAgents, XMLHttpRequest* request, ScriptExecutionContext* context)
{
int timelineAgentId = 0;
InspectorTimelineAgent* timelineAgent = instrumentingAgents-inspectorTimelineAgent();
if (timelineAgent request-hasEventListeners(eventNames().readystatechangeEvent)) {
-timelineAgent-willChangeXHRReadyState(request-url().string(), request-readyState(), frameForScriptExecutionContext(context));
+timelineAgent-willDispatchXHRReadyStateChangeEvent(request-url().string(), request-readyState(),
[webkit-changes] [128286] releases/WebKitGTK/webkit-1.10/Source/WebCore
Title: [128286] releases/WebKitGTK/webkit-1.10/Source/WebCore Revision 128286 Author carlo...@webkit.org Date 2012-09-12 02:58:42 -0700 (Wed, 12 Sep 2012) Log Message Merge r128074 - [GTK][a11y] editing/pasteboard/paste-blockquote-into-blockquote-4.html crashes https://bugs.webkit.org/show_bug.cgi?id=96199 Patch by Joanmarie Diggs jdi...@igalia.com on 2012-09-10 Reviewed by Martin Robinson. Added sanity check to correct erroneous assumption that there will always be a child object. No new tests as the bug crashes two existing Layout Tests which should no longer crash as a result of this fix. * accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Modified Paths releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp Diff Modified: releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog (128285 => 128286) --- releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 09:57:42 UTC (rev 128285) +++ releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 09:58:42 UTC (rev 128286) @@ -1,3 +1,19 @@ +2012-09-10 Joanmarie Diggs jdi...@igalia.com + +[GTK][a11y] editing/pasteboard/paste-blockquote-into-blockquote-4.html crashes +https://bugs.webkit.org/show_bug.cgi?id=96199 + +Reviewed by Martin Robinson. + +Added sanity check to correct erroneous assumption that there will +always be a child object. + +No new tests as the bug crashes two existing Layout Tests which should +no longer crash as a result of this fix. + +* accessibility/gtk/AccessibilityObjectAtk.cpp: +(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): + 2012-08-24 Sergio Villar Senin svil...@igalia.com [GTK] Purge unused favicons from IconDatabase after 30 days Modified: releases/WebKitGTK/webkit-1.10/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp (128285 => 128286) --- releases/WebKitGTK/webkit-1.10/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp 2012-09-12 09:57:42 UTC (rev 128285) +++ releases/WebKitGTK/webkit-1.10/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp 2012-09-12 09:58:42 UTC (rev 128286) @@ -89,7 +89,7 @@ return DefaultBehavior; child = child-firstChild(); -if (child-isLink() || !child-firstAnonymousBlockChild()) +if (child (child-isLink() || !child-firstAnonymousBlockChild())) return IncludeObject; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128287] trunk/Source/WebCore
Title: [128287] trunk/Source/WebCore
Revision 128287
Author commit-qu...@webkit.org
Date 2012-09-12 03:15:53 -0700 (Wed, 12 Sep 2012)
Log Message
Web Inspector: InspectorBackend.loadFromJSONIfNeeded should take the JSON url as argument
https://bugs.webkit.org/show_bug.cgi?id=96472
Patch by Vivek Galatage vivekgalat...@gmail.com on 2012-09-12
Reviewed by Yury Semikhatsky.
The method loadFromJSONIfNeeded need to take the jsonUrl as argument
as this will be called from the Inspector Protocol Test Harness
residing in a different location.
No new tests as code refactoring done.
* inspector/front-end/InspectorBackend.js:
(InspectorBackendClass.prototype.loadFromJSONIfNeeded):
* inspector/front-end/inspector.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/InspectorBackend.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (128286 => 128287)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 09:58:42 UTC (rev 128286)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 10:15:53 UTC (rev 128287)
@@ -1,3 +1,20 @@
+2012-09-12 Vivek Galatage vivekgalat...@gmail.com
+
+Web Inspector: InspectorBackend.loadFromJSONIfNeeded should take the JSON url as argument
+https://bugs.webkit.org/show_bug.cgi?id=96472
+
+Reviewed by Yury Semikhatsky.
+
+The method loadFromJSONIfNeeded need to take the jsonUrl as argument
+as this will be called from the Inspector Protocol Test Harness
+residing in a different location.
+
+No new tests as code refactoring done.
+
+* inspector/front-end/InspectorBackend.js:
+(InspectorBackendClass.prototype.loadFromJSONIfNeeded):
+* inspector/front-end/inspector.js:
+
2012-09-12 Vsevolod Vlasov vse...@chromium.org
Web Inspector: XMLHttpRequest instrumentation methods used by timeline should have better names.
Modified: trunk/Source/WebCore/inspector/front-end/InspectorBackend.js (128286 => 128287)
--- trunk/Source/WebCore/inspector/front-end/InspectorBackend.js 2012-09-12 09:58:42 UTC (rev 128286)
+++ trunk/Source/WebCore/inspector/front-end/InspectorBackend.js 2012-09-12 10:15:53 UTC (rev 128287)
@@ -256,13 +256,13 @@
}
},
-loadFromJSONIfNeeded: function()
+loadFromJSONIfNeeded: function(jsonUrl)
{
if (this._initialized)
return;
var xhr = new XMLHttpRequest();
-xhr.open(GET, ../Inspector.json, false);
+xhr.open(GET, jsonUrl, false);
xhr.send(null);
var schema = JSON.parse(xhr.responseText);
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (128286 => 128287)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2012-09-12 09:58:42 UTC (rev 128286)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2012-09-12 10:15:53 UTC (rev 128287)
@@ -406,7 +406,7 @@
WebInspector.loaded = function()
{
-InspectorBackend.loadFromJSONIfNeeded();
+InspectorBackend.loadFromJSONIfNeeded(../Inspector.json);
if (WebInspector.WorkerManager.isDedicatedWorkerFrontend()) {
// Do not create socket for the worker front-end.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128288] trunk/LayoutTests
Title: [128288] trunk/LayoutTests Revision 128288 Author o...@webkit.org Date 2012-09-12 03:17:00 -0700 (Wed, 12 Sep 2012) Log Message [Qt][WK2] Unreviewed gardening, skip a new failing test to paint the bot green. * platform/qt-5.0-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (128287 => 128288) --- trunk/LayoutTests/ChangeLog 2012-09-12 10:15:53 UTC (rev 128287) +++ trunk/LayoutTests/ChangeLog 2012-09-12 10:17:00 UTC (rev 128288) @@ -1,3 +1,9 @@ +2012-09-12 Csaba Osztrogonác o...@webkit.org + +[Qt][WK2] Unreviewed gardening, skip a new failing test to paint the bot green. + +* platform/qt-5.0-wk2/Skipped: + 2012-09-12 Christophe Dumez christophe.du...@intel.com [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (128287 => 128288) --- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-09-12 10:15:53 UTC (rev 128287) +++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-09-12 10:17:00 UTC (rev 128288) @@ -501,3 +501,7 @@ # [Qt][WK2] fast/spatial-navigation/snav-media-elements.html timeouts # https://bugs.webkit.org/show_bug.cgi?id=96397 fast/spatial-navigation/snav-media-elements.html + +# [Qt][WK2] REGRESSION(r128270): It made fast/events/popup-blocking-timers.html flakey +# https://bugs.webkit.org/show_bug.cgi?id=96480 +fast/events/popup-blocking-timers.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128289] trunk/Source/WebKit2
Title: [128289] trunk/Source/WebKit2
Revision 128289
Author commit-qu...@webkit.org
Date 2012-09-12 03:20:00 -0700 (Wed, 12 Sep 2012)
Log Message
[EFL][WK2] WorkQueue::dispatchAfterDelay() doesn't work properly.
https://bugs.webkit.org/show_bug.cgi?id=91179
Patch by Byungwoo Lee bw80@samsung.com on 2012-09-12
Reviewed by Gyuyoung Kim.
When UI Process is crashed and WebProcess's ecore main loop is very
busy or lockup also, watchdocCallback() function in the
ChildProcess.cpp doesn't triggered. And this is because of that
WorkQueue::dispatchAfterDelay() function uses ecore timer for getting
timer event.
For removing the dependency between the dispatchAfterDelay() and ecore
main loop, new timer event mechanism is added to WorkQueue main loop.
* Platform/WorkQueue.h:
(TimerWorkItem):
(WorkQueue::TimerWorkItem::dispatch):
(WorkQueue::TimerWorkItem::expireTime):
(WorkQueue::TimerWorkItem::expired):
(WorkQueue):
* Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::TimerWorkItem::create):
(WorkQueue::TimerWorkItem::TimerWorkItem):
(WorkQueue::performFileDescriptorWork):
(WorkQueue::getCurrentTime):
(WorkQueue::getNextTimeOut):
(WorkQueue::performTimerWork):
(WorkQueue::workQueueThread):
(WorkQueue::dispatchAfterDelay):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/WorkQueue.h
trunk/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (128288 => 128289)
--- trunk/Source/WebKit2/ChangeLog 2012-09-12 10:17:00 UTC (rev 128288)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-12 10:20:00 UTC (rev 128289)
@@ -1,3 +1,35 @@
+2012-09-12 Byungwoo Lee bw80@samsung.com
+
+[EFL][WK2] WorkQueue::dispatchAfterDelay() doesn't work properly.
+https://bugs.webkit.org/show_bug.cgi?id=91179
+
+Reviewed by Gyuyoung Kim.
+
+When UI Process is crashed and WebProcess's ecore main loop is very
+busy or lockup also, watchdocCallback() function in the
+ChildProcess.cpp doesn't triggered. And this is because of that
+WorkQueue::dispatchAfterDelay() function uses ecore timer for getting
+timer event.
+
+For removing the dependency between the dispatchAfterDelay() and ecore
+main loop, new timer event mechanism is added to WorkQueue main loop.
+
+* Platform/WorkQueue.h:
+(TimerWorkItem):
+(WorkQueue::TimerWorkItem::dispatch):
+(WorkQueue::TimerWorkItem::expireTime):
+(WorkQueue::TimerWorkItem::expired):
+(WorkQueue):
+* Platform/efl/WorkQueueEfl.cpp:
+(WorkQueue::TimerWorkItem::create):
+(WorkQueue::TimerWorkItem::TimerWorkItem):
+(WorkQueue::performFileDescriptorWork):
+(WorkQueue::getCurrentTime):
+(WorkQueue::getNextTimeOut):
+(WorkQueue::performTimerWork):
+(WorkQueue::workQueueThread):
+(WorkQueue::dispatchAfterDelay):
+
2012-09-12 Christophe Dumez christophe.du...@intel.com
[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
Modified: trunk/Source/WebKit2/Platform/WorkQueue.h (128288 => 128289)
--- trunk/Source/WebKit2/Platform/WorkQueue.h 2012-09-12 10:17:00 UTC (rev 128288)
+++ trunk/Source/WebKit2/Platform/WorkQueue.h 2012-09-12 10:20:00 UTC (rev 128289)
@@ -187,6 +187,21 @@
HashMapint, VectorEventSource* m_eventSources;
typedef HashMapint, VectorEventSource* ::iterator EventSourceIterator;
#elif PLATFORM(EFL)
+class TimerWorkItem {
+public:
+static PassOwnPtrTimerWorkItem create(Functionvoid(), double expireTime);
+void dispatch() { m_function(); }
+double expireTime() const { return m_expireTime; }
+bool expired(double currentTime) const { return currentTime = m_expireTime; }
+
+protected:
+TimerWorkItem(Functionvoid(), double expireTime);
+
+private:
+Functionvoid() m_function;
+double m_expireTime;
+};
+
fd_set m_fileDescriptorSet;
int m_maxFileDescriptor;
int m_readFromPipeDescriptor;
@@ -199,13 +214,17 @@
int m_socketDescriptor;
Functionvoid() m_socketEventHandler;
-HashMapint, OwnPtrEcore_Timer m_timers;
+VectorOwnPtrTimerWorkItem m_timerWorkItems;
+Mutex m_timerWorkItemsLock;
void sendMessageToThread(const char*);
static void* workQueueThread(WorkQueue*);
void performWork();
void performFileDescriptorWork();
-static bool timerFired(void*);
+static double getCurrentTime();
+struct timeval* getNextTimeOut();
+void performTimerWork();
+void insertTimerWorkItem(PassOwnPtrTimerWorkItem);
#endif
};
Modified: trunk/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp (128288 => 128289)
--- trunk/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp 2012-09-12 10:17:00 UTC (rev 128288)
+++ trunk/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp 2012-09-12 10:20:00 UTC (rev 128289)
@@ -20,34 +20,29 @@
#include config.h
#include WorkQueue.h
+#include
[webkit-changes] [128290] trunk/Source/WebCore
Title: [128290] trunk/Source/WebCore Revision 128290 Author o...@webkit.org Date 2012-09-12 04:34:34 -0700 (Wed, 12 Sep 2012) Log Message Build with ENABLE_REQUEST_ANIMATION_FRAME=0 is broken https://bugs.webkit.org/show_bug.cgi?id=96491 Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-09-12 Reviewed by Csaba Osztrogonác. In the IDL file, don't just check for the define, also check if it's set to 1 before enabling the RAF APIs. It's done like this with all the other feature defines in IDL files. * page/DOMWindow.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/DOMWindow.idl Diff Modified: trunk/Source/WebCore/ChangeLog (128289 => 128290) --- trunk/Source/WebCore/ChangeLog 2012-09-12 10:20:00 UTC (rev 128289) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 11:34:34 UTC (rev 128290) @@ -1,3 +1,15 @@ +2012-09-12 Simon Hausmann simon.hausm...@nokia.com + +Build with ENABLE_REQUEST_ANIMATION_FRAME=0 is broken +https://bugs.webkit.org/show_bug.cgi?id=96491 + +Reviewed by Csaba Osztrogonác. + +In the IDL file, don't just check for the define, also check if it's set to 1 before enabling the +RAF APIs. It's done like this with all the other feature defines in IDL files. + +* page/DOMWindow.idl: + 2012-09-12 Vivek Galatage vivekgalat...@gmail.com Web Inspector: InspectorBackend.loadFromJSONIfNeeded should take the JSON url as argument Modified: trunk/Source/WebCore/page/DOMWindow.idl (128289 => 128290) --- trunk/Source/WebCore/page/DOMWindow.idl 2012-09-12 10:20:00 UTC (rev 128289) +++ trunk/Source/WebCore/page/DOMWindow.idl 2012-09-12 11:34:34 UTC (rev 128290) @@ -211,7 +211,7 @@ // [Custom] long setInterval(in DOMString code, in long timeout); void clearInterval(in [Optional=DefaultIsUndefined] long handle); -#if defined(ENABLE_REQUEST_ANIMATION_FRAME) +#if defined(ENABLE_REQUEST_ANIMATION_FRAME) ENABLE_REQUEST_ANIMATION_FRAME // WebKit animation extensions, being standardized in the WebPerf WG long webkitRequestAnimationFrame(in [Callback] RequestAnimationFrameCallback callback); void webkitCancelAnimationFrame(in long id); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128292] trunk/Tools
Title: [128292] trunk/Tools
Revision 128292
Author kenn...@webkit.org
Date 2012-09-12 04:52:24 -0700 (Wed, 12 Sep 2012)
Log Message
[EFL] Make DumpRenderTree smarter at finding the fonts
http://webkit.org/b/96281
Reviewed by Gyuyoung Kim.
Respect WEBKITOUTPUTDIR and expand the font dir from it.
Use CString consistently.
* DumpRenderTree/efl/FontManagement.cpp:
(buildPath):
(getCoreFontFiles):
(addFontDirectory):
(addFontFiles):
(getCustomBuildDir):
(getPlatformFontsPath):
(addFontsToEnvironment):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/FontManagement.cpp
Diff
Modified: trunk/Tools/ChangeLog (128291 => 128292)
--- trunk/Tools/ChangeLog 2012-09-12 11:36:15 UTC (rev 128291)
+++ trunk/Tools/ChangeLog 2012-09-12 11:52:24 UTC (rev 128292)
@@ -1,3 +1,22 @@
+2012-09-12 Kenneth Rohde Christiansen kenn...@webkit.org
+
+[EFL] Make DumpRenderTree smarter at finding the fonts
+http://webkit.org/b/96281
+
+Reviewed by Gyuyoung Kim.
+
+Respect WEBKITOUTPUTDIR and expand the font dir from it.
+Use CString consistently.
+
+* DumpRenderTree/efl/FontManagement.cpp:
+(buildPath):
+(getCoreFontFiles):
+(addFontDirectory):
+(addFontFiles):
+(getCustomBuildDir):
+(getPlatformFontsPath):
+(addFontsToEnvironment):
+
2012-09-12 Christophe Dumez christophe.du...@intel.com
[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
Modified: trunk/Tools/DumpRenderTree/efl/FontManagement.cpp (128291 => 128292)
--- trunk/Tools/DumpRenderTree/efl/FontManagement.cpp 2012-09-12 11:36:15 UTC (rev 128291)
+++ trunk/Tools/DumpRenderTree/efl/FontManagement.cpp 2012-09-12 11:52:24 UTC (rev 128292)
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2011 ProFUSION Embedded Systems
* Copyright (C) 2011 Samsung Electronics
+ * Copyright (C) 2012 Intel Corporation. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -31,49 +32,88 @@
#include fontconfig/fontconfig.h
#include wtf/Vector.h
#include wtf/text/CString.h
-#include wtf/text/WTFString.h
+#include wtf/text/StringBuilder.h
-static VectorString getFontFiles()
+static CString buildPath(const char* base, const char* first, ...)
{
-VectorString fontFilePaths;
+va_list ap;
+StringBuilder result;
+result.append(base);
+if (const char* current = first) {
+va_start(ap, first);
+do {
+result.append('/');
+result.append(current);
+} while ((current = va_arg(ap, const char*)));
+va_end(ap);
+}
+
+return result.toString().utf8();
+}
+
+static VectorCString getCoreFontFiles()
+{
+VectorCString fontFilePaths;
+
// Ahem is used by many layout tests.
-fontFilePaths.append(String(FONTS_CONF_DIR /AHEM.TTF));
+fontFilePaths.append(CString(FONTS_CONF_DIR /AHEM.TTF));
// A font with no valid Fontconfig encoding to test https://bugs.webkit.org/show_bug.cgi?id=47452
-fontFilePaths.append(String(FONTS_CONF_DIR /FontWithNoValidEncoding.fon));
+fontFilePaths.append(CString(FONTS_CONF_DIR /FontWithNoValidEncoding.fon));
for (int i = 1; i = 9; i++) {
-char fontPath[PATH_MAX];
-snprintf(fontPath, PATH_MAX - 1,
- FONTS_CONF_DIR /../../fonts/WebKitWeightWatcher%i00.ttf, i);
-
-fontFilePaths.append(String(fontPath));
+char fontPath[EINA_PATH_MAX];
+snprintf(fontPath, EINA_PATH_MAX - 1, FONTS_CONF_DIR /../../fonts/WebKitWeightWatcher%i00.ttf, i);
+fontFilePaths.append(CString(fontPath));
}
return fontFilePaths;
}
-static bool addFontDirectory(const CString fontDirectory, FcConfig* config)
+static void addFontDirectory(const CString fontDirectory, FcConfig* config)
{
-const char* path = fontDirectory.data();
+const char* fontPath = fontDirectory.data();
+if (!fontPath || !FcConfigAppFontAddDir(config, reinterpret_castconst FcChar8*(fontPath)))
+fprintf(stderr, Could not add font directory %s!\n, fontPath);
+}
-if (!ecore_file_is_dir(path)
-|| !FcConfigAppFontAddDir(config, reinterpret_castconst FcChar8*(path))) {
-fprintf(stderr, Could not add font directory %s!\n, path);
-return false;
+static void addFontFiles(const VectorCString fontFiles, FcConfig* config)
+{
+VectorCString::const_iterator it, end = fontFiles.end();
+for (it = fontFiles.begin(); it != end; ++it) {
+const char* filePath = (*it).data();
+if (!FcConfigAppFontAddFile(config, reinterpret_castconst FcChar8*(filePath)))
+fprintf(stderr, Could not load font at %s!\n, filePath);
}
-return true;
}
-static void addFontFiles(const VectorString fontFiles, FcConfig* config)
+static CString getCustomBuildDir()
{
-for (VectorString::const_iterator it =
[webkit-changes] [128294] trunk/Source/WebCore
Title: [128294] trunk/Source/WebCore
Revision 128294
Author commit-qu...@webkit.org
Date 2012-09-12 05:10:20 -0700 (Wed, 12 Sep 2012)
Log Message
[Qt] Build on X11 with GraphicsSurface but without NPAPI is broken
https://bugs.webkit.org/show_bug.cgi?id=96495
Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.
When enabling NPAPI we link against XRender on X11. The other component that needs Xrender
is GraphicsSurface. So when building without NPAPI we need to make sure that we link in Xrender.
This patch cleans up the GraphicsSurface related linkage required on Mac OS X and X11 by wrapping
it in use?(graphics_surface) instead of 3D_GRAPHICS. It is not neccesary to perform the have?(XCOMPOSITE)
check anymore because it's already done in features.prf before enabling use_graphics_surface in the
first place.
* WebCore.pri:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri
Diff
Modified: trunk/Source/WebCore/ChangeLog (128293 => 128294)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 12:07:24 UTC (rev 128293)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 12:10:20 UTC (rev 128294)
@@ -1,3 +1,20 @@
+2012-09-12 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Build on X11 with GraphicsSurface but without NPAPI is broken
+https://bugs.webkit.org/show_bug.cgi?id=96495
+
+Reviewed by Kenneth Rohde Christiansen.
+
+When enabling NPAPI we link against XRender on X11. The other component that needs Xrender
+is GraphicsSurface. So when building without NPAPI we need to make sure that we link in Xrender.
+
+This patch cleans up the GraphicsSurface related linkage required on Mac OS X and X11 by wrapping
+it in use?(graphics_surface) instead of 3D_GRAPHICS. It is not neccesary to perform the have?(XCOMPOSITE)
+check anymore because it's already done in features.prf before enabling use_graphics_surface in the
+first place.
+
+* WebCore.pri:
+
2012-09-12 Andrei Poenaru poen...@adobe.com
Web Inspector: Protocol Extension: Add regionLayoutUpdate event
Modified: trunk/Source/WebCore/WebCore.pri (128293 => 128294)
--- trunk/Source/WebCore/WebCore.pri 2012-09-12 12:07:24 UTC (rev 128293)
+++ trunk/Source/WebCore/WebCore.pri 2012-09-12 12:10:20 UTC (rev 128294)
@@ -197,8 +197,11 @@
use?(3D_GRAPHICS) {
contains(QT_CONFIG, opengles2):!win32: LIBS += -lEGL
+}
+
+use?(graphics_surface) {
mac: LIBS += -framework IOSurface -framework CoreFoundation
-linux-*:have?(XCOMPOSITE): LIBS += -lXcomposite
+linux-*: LIBS += -lXcomposite -lXrender
}
!system-sqlite:exists( $${SQLITE3SRCDIR}/sqlite3.c ) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128295] trunk/Tools
Title: [128295] trunk/Tools
Revision 128295
Author commit-qu...@webkit.org
Date 2012-09-12 05:13:50 -0700 (Wed, 12 Sep 2012)
Log Message
[Qt] Make it possible to build with make release and make debug on Windows
https://bugs.webkit.org/show_bug.cgi?id=96488
Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-09-12
Reviewed by Tor Arne Vestbø.
A make debug is passed through recursively and currently it aborts at Makefile.DerivedSources
because there are no such targets. We want the generated sources to be independent from release
or debug build configurations, so it is sufficient to provide fake debug and release targets that
redirect to the same general-purpose target (first) of creating the derived sources.
* qmake/mkspecs/features/default_post.prf:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/Tools/ChangeLog (128294 => 128295)
--- trunk/Tools/ChangeLog 2012-09-12 12:10:20 UTC (rev 128294)
+++ trunk/Tools/ChangeLog 2012-09-12 12:13:50 UTC (rev 128295)
@@ -1,3 +1,17 @@
+2012-09-12 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Make it possible to build with make release and make debug on Windows
+https://bugs.webkit.org/show_bug.cgi?id=96488
+
+Reviewed by Tor Arne Vestbø.
+
+A make debug is passed through recursively and currently it aborts at Makefile.DerivedSources
+because there are no such targets. We want the generated sources to be independent from release
+or debug build configurations, so it is sufficient to provide fake debug and release targets that
+redirect to the same general-purpose target (first) of creating the derived sources.
+
+* qmake/mkspecs/features/default_post.prf:
+
2012-09-12 Kenneth Rohde Christiansen kenn...@webkit.org
[EFL] Make DumpRenderTree smarter at finding the fonts
Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (128294 => 128295)
--- trunk/Tools/qmake/mkspecs/features/default_post.prf 2012-09-12 12:10:20 UTC (rev 128294)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2012-09-12 12:13:50 UTC (rev 128295)
@@ -68,6 +68,13 @@
CONFIG -= debug_and_release
+fake_debug.target = debug
+fake_debug.depends = first
+QMAKE_EXTRA_TARGETS += fake_debug
+fake_release.target = release
+fake_release.depends = first
+QMAKE_EXTRA_TARGETS += fake_release
+
for(generator, GENERATORS) {
eval($${generator}.CONFIG = target_predeps no_link)
eval($${generator}.dependency_type = TYPE_C)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128296] trunk
Title: [128296] trunk Revision 128296 Author loi...@chromium.org Date 2012-09-12 05:15:32 -0700 (Wed, 12 Sep 2012) Log Message Unreviewed, rolling out r128280. http://trac.webkit.org/changeset/128280 https://bugs.webkit.org/show_bug.cgi?id=96498 it broke compilation on windows debug bot (Requested by loislo on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-12 Source/WebKit2: * Shared/APIClientTraits.cpp: (WebKit): * Shared/APIClientTraits.h: * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetApplicationCacheOriginQuota): * WebProcess/InjectedBundle/API/c/WKBundlePage.h: * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: * WebProcess/InjectedBundle/InjectedBundle.h: (InjectedBundle): * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: (WebKit): (InjectedBundlePageUIClient): * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): Tools: * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: (InjectedBundlePage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::TestRunner): * WebKitTestRunner/InjectedBundle/TestRunner.h: (TestRunner): LayoutTests: * platform/efl-wk1/TestExpectations: * platform/efl/Skipped: * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/efl-wk1/TestExpectations trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/APIClientTraits.cpp trunk/Source/WebKit2/Shared/APIClientTraits.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Diff Modified: trunk/LayoutTests/ChangeLog (128295 => 128296) --- trunk/LayoutTests/ChangeLog 2012-09-12 12:13:50 UTC (rev 128295) +++ trunk/LayoutTests/ChangeLog 2012-09-12 12:15:32 UTC (rev 128296) @@ -1,3 +1,16 @@ +2012-09-12 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r128280. +http://trac.webkit.org/changeset/128280 +https://bugs.webkit.org/show_bug.cgi?id=96498 + +it broke compilation on windows debug bot (Requested by loislo +on #webkit). + +* platform/efl-wk1/TestExpectations: +* platform/efl/Skipped: +* platform/wk2/Skipped: + 2012-09-12 Andrei Poenaru poen...@adobe.com Web Inspector: Protocol Extension: Add regionLayoutUpdate event Modified: trunk/LayoutTests/platform/efl/Skipped (128295 => 128296) --- trunk/LayoutTests/platform/efl/Skipped 2012-09-12 12:13:50 UTC (rev 128295) +++ trunk/LayoutTests/platform/efl/Skipped 2012-09-12 12:15:32 UTC (rev 128296) @@ -103,6 +103,12 @@ # Fallback resource wasn't used for a redirect to a resource with another origin http/tests/appcache/fallback.html +# EFL's LayoutTestController does not implement applicationCacheDiskUsageForOrigin +http/tests/appcache/origin-usage.html + +# EFL's LayoutTestController does not implement originsWithApplicationCache +http/tests/appcache/origins-with-appcache.html + # EFL's LayoutTestController does not implement shadowPseudoId media/video-controls-transformed.html media/video-controls-visible-audio-only.html Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (128295 => 128296) --- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-09-12 12:13:50 UTC (rev 128295) +++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-09-12 12:15:32 UTC (rev 128296) @@ -47,12 +47,6 @@ // Custom font loading delaying text drawing on Canvas BUGWK87355 : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = TEXT -// EFL's TestRunner does not implement applicationCacheDiskUsageForOrigin -BUGWK86460 : http/tests/appcache/origin-usage.html = TEXT - -// EFL's TestRunner does not implement originsWithApplicationCache -BUGWK86498 : http/tests/appcache/origins-with-appcache.html = TEXT - // Missing
[webkit-changes] [128297] trunk/Tools
Title: [128297] trunk/Tools Revision 128297 Author commit-qu...@webkit.org Date 2012-09-12 05:32:29 -0700 (Wed, 12 Sep 2012) Log Message [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0 https://bugs.webkit.org/show_bug.cgi?id=96494 Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-09-12 Reviewed by Tor Arne Vestbø. WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the plugin process feature if we don't have NPAPI. * qmake/mkspecs/features/features.prf: Modified Paths trunk/Tools/ChangeLog trunk/Tools/qmake/mkspecs/features/features.prf Diff Modified: trunk/Tools/ChangeLog (128296 => 128297) --- trunk/Tools/ChangeLog 2012-09-12 12:15:32 UTC (rev 128296) +++ trunk/Tools/ChangeLog 2012-09-12 12:32:29 UTC (rev 128297) @@ -1,3 +1,15 @@ +2012-09-12 Simon Hausmann simon.hausm...@nokia.com + +[Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0 +https://bugs.webkit.org/show_bug.cgi?id=96494 + +Reviewed by Tor Arne Vestbø. + +WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the +plugin process feature if we don't have NPAPI. + +* qmake/mkspecs/features/features.prf: + 2012-09-12 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r128280. Modified: trunk/Tools/qmake/mkspecs/features/features.prf (128296 => 128297) --- trunk/Tools/qmake/mkspecs/features/features.prf 2012-09-12 12:15:32 UTC (rev 128296) +++ trunk/Tools/qmake/mkspecs/features/features.prf 2012-09-12 12:32:29 UTC (rev 128297) @@ -149,5 +149,8 @@ # Fullscreen API relies on WebKit2 !build?(webkit2): WEBKIT_CONFIG -= fullscreen_api +# WK2's plugin process code requires NPAPI +!enable?(netscape_plugin_api): WEBKIT_CONFIG -= plugin_process + export(WEBKIT_CONFIG) } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128298] trunk/Source/WebCore
Title: [128298] trunk/Source/WebCore Revision 128298 Author ph...@webkit.org Date 2012-09-12 05:33:23 -0700 (Wed, 12 Sep 2012) Log Message [GStreamer] Audio device not closed after playing sound https://bugs.webkit.org/show_bug.cgi?id=89122 Reviewed by Martin Robinson. Set the GStreamer pipeline to NULL instead of PAUSED on EOS. This allows the audio-sink to release its connection to the audio device. This is done only if the Media element is not looping. To make the MediaPlayerPrivate layer aware of that information the MediaPlayerClient interface was updated with a new method mediaPlayerIsLooping, implemented by the HTMLMediaElement. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerIsLooping): Implementation of MediaPlayerClient::mediaPlayerLoop, proxies to ::loop(); * html/HTMLMediaElement.h: (HTMLMediaElement): * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerIsLooping): New method allowing the MediaPlayer and its backend to know if a playback loop is requested by the client. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::playbackPosition): Report seek time or media duration if EOS was reached. These early returns are needed because the position query doesn't work on a NULL pipeline. (WebCore::MediaPlayerPrivateGStreamer::changePipelineState): Refactored to use an early return. (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Reset the seeking flag. (WebCore::MediaPlayerPrivateGStreamer::play): reset m_isEndReached. (WebCore::MediaPlayerPrivateGStreamer::pause): Don't pause on EOS. (WebCore::MediaPlayerPrivateGStreamer::seek): Refactor, call currentTime() after we're sure playbin is valid and no error occured. (WebCore::MediaPlayerPrivateGStreamer::paused): Fake paused state on EOS. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/platform/graphics/MediaPlayer.h trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (128297 => 128298) --- trunk/Source/WebCore/ChangeLog 2012-09-12 12:32:29 UTC (rev 128297) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 12:33:23 UTC (rev 128298) @@ -1,3 +1,43 @@ +2012-08-20 Philippe Normand pnorm...@igalia.com + +[GStreamer] Audio device not closed after playing sound +https://bugs.webkit.org/show_bug.cgi?id=89122 + +Reviewed by Martin Robinson. + +Set the GStreamer pipeline to NULL instead of PAUSED on EOS. This +allows the audio-sink to release its connection to the audio +device. This is done only if the Media element is not +looping. To make the MediaPlayerPrivate layer aware of that +information the MediaPlayerClient interface was updated with a new +method mediaPlayerIsLooping, implemented by the HTMLMediaElement. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::mediaPlayerIsLooping): Implementation of +MediaPlayerClient::mediaPlayerLoop, proxies to ::loop(); +* html/HTMLMediaElement.h: +(HTMLMediaElement): +* platform/graphics/MediaPlayer.h: +(WebCore::MediaPlayerClient::mediaPlayerIsLooping): New method allowing +the MediaPlayer and its backend to know if a playback loop is +requested by the client. +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: +(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): +(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): Report +seek time or media duration if EOS was reached. These early +returns are needed because the position query doesn't work on a +NULL pipeline. +(WebCore::MediaPlayerPrivateGStreamer::changePipelineState): +Refactored to use an early return. +(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Reset the +seeking flag. +(WebCore::MediaPlayerPrivateGStreamer::play): reset m_isEndReached. +(WebCore::MediaPlayerPrivateGStreamer::pause): Don't pause on EOS. +(WebCore::MediaPlayerPrivateGStreamer::seek): Refactor, call +currentTime() after we're sure playbin is valid and no error occured. +(WebCore::MediaPlayerPrivateGStreamer::paused): Fake paused state +on EOS. + 2012-09-12 Simon Hausmann simon.hausm...@nokia.com [Qt] Build on X11 with GraphicsSurface but without NPAPI is broken Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (128297 => 128298) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-09-12 12:32:29 UTC (rev 128297) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-09-12 12:33:23 UTC (rev 128298) @@ -4477,6 +4477,11 @@ return paused(); } +bool
[webkit-changes] [128300] trunk/Source
Title: [128300] trunk/Source
Revision 128300
Author loi...@chromium.org
Date 2012-09-12 05:50:10 -0700 (Wed, 12 Sep 2012)
Log Message
Web Inspector: NMI move String* instrumentation to wtf.
https://bugs.webkit.org/show_bug.cgi?id=96405
Reviewed by Yury Semikhatsky.
This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
Source/WebCore:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
Source/WebKit/chromium:
Tested by webkit_unit_tests.
* tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):
Source/WTF:
Tested by webkit_unit_tests.
* wtf/text/AtomicString.h:
(AtomicString):
(WTF::AtomicString::reportMemoryUsage):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::reportMemoryUsage):
* wtf/text/WTFString.h:
(String):
(WTF::String::reportMemoryUsage):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryInstrumentation.h
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.cpp
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.h
trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp
trunk/Source/WebCore/platform/SharedBuffer.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (128299 => 128300)
--- trunk/Source/WTF/ChangeLog 2012-09-12 12:43:40 UTC (rev 128299)
+++ trunk/Source/WTF/ChangeLog 2012-09-12 12:50:10 UTC (rev 128300)
@@ -1,3 +1,24 @@
+2012-09-12 Ilya Tikhonovsky loi...@chromium.org
+
+Web Inspector: NMI move String* instrumentation to wtf.
+https://bugs.webkit.org/show_bug.cgi?id=96405
+
+Reviewed by Yury Semikhatsky.
+
+This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
+
+Tested by webkit_unit_tests.
+
+* wtf/text/AtomicString.h:
+(AtomicString):
+(WTF::AtomicString::reportMemoryUsage):
+* wtf/text/StringImpl.h:
+(StringImpl):
+(WTF::StringImpl::reportMemoryUsage):
+* wtf/text/WTFString.h:
+(String):
+(WTF::String::reportMemoryUsage):
+
2012-09-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r128279.
Modified: trunk/Source/WTF/wtf/MemoryInstrumentation.h (128299 => 128300)
--- trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 12:43:40 UTC (rev 128299)
+++ trunk/Source/WTF/wtf/MemoryInstrumentation.h 2012-09-12 12:50:10 UTC (rev 128300)
@@ -43,11 +43,6 @@
typedef const char* MemoryObjectType;
-class GenericMemoryTypes {
-public:
-static MemoryObjectType Undefined;
-};
-
enum MemoryOwningType {
byPointer,
byReference
@@ -65,7 +60,7 @@
template typename T void addRootObject(const T t)
{
-addInstrumentedObject(t, GenericMemoryTypes::Undefined);
+addInstrumentedObject(t, 0);
processDeferredInstrumentedPointers();
}
@@ -184,7 +179,7 @@
{
if (!m_objectSize) {
m_objectSize = actualSize ? actualSize : sizeof(T);
-if (objectType != GenericMemoryTypes::Undefined)
+if (objectType)
m_objectType = objectType;
}
}
@@ -197,7 +192,7 @@
class MemoryClassInfo {
public:
templatetypename T
-MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = GenericMemoryTypes::Undefined, size_t actualSize = 0)
+MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = 0, size_t actualSize = 0)
: m_memoryObjectInfo(memoryObjectInfo)
, m_memoryInstrumentation(memoryObjectInfo-memoryInstrumentation())
{
Modified: trunk/Source/WTF/wtf/text/AtomicString.h (128299 => 128300)
--- trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 12:43:40 UTC (rev 128299)
+++ trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 12:50:10 UTC (rev 128300)
@@ -154,6 +154,14 @@
#ifndef NDEBUG
void show() const;
#endif
+
+templatetypename MemoryObjectInfo
+void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
+{
+typename MemoryObjectInfo::ClassInfo info(memoryObjectInfo, this);
+info.addInstrumentedMember(m_string);
+}
+
private:
// The explicit constructors with AtomicString::ConstructFromLiteral must be used for literals.
AtomicString(ASCIILiteral);
Modified: trunk/Source/WTF/wtf/text/StringImpl.h (128299 => 128300)
--- trunk/Source/WTF/wtf/text/StringImpl.h 2012-09-12 12:43:40 UTC (rev 128299)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2012-09-12 12:50:10 UTC (rev 128300)
@@ -714,6 +714,28 @@
#ifdef STRING_STATS
ALWAYS_INLINE static StringStats stringStats() { return m_stringStats; }
#endif
+
+
[webkit-changes] [128301] trunk/Source/WebCore
Title: [128301] trunk/Source/WebCore
Revision 128301
Author loi...@chromium.org
Date 2012-09-12 06:16:31 -0700 (Wed, 12 Sep 2012)
Log Message
Unreviewed. Touch two files for fixing broken compile dependency on Apple Windows Debug bot.
* css/StyleResolver.cpp:
* loader/FrameLoader.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (128300 => 128301)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 12:50:10 UTC (rev 128300)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 13:16:31 UTC (rev 128301)
@@ -1,6 +1,13 @@
2012-09-12 Ilya Tikhonovsky loi...@chromium.org
+Unreviewed. Touch two files for fixing broken compile dependency on Apple Windows Debug bot.
+* css/StyleResolver.cpp:
+* loader/FrameLoader.cpp:
+
+2012-09-12 Ilya Tikhonovsky loi...@chromium.org
+
+
Web Inspector: NMI move String* instrumentation to wtf.
https://bugs.webkit.org/show_bug.cgi?id=96405
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (128300 => 128301)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-09-12 12:50:10 UTC (rev 128300)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-09-12 13:16:31 UTC (rev 128301)
@@ -168,6 +168,7 @@
#define FIXED_POSITION_CREATES_STACKING_CONTEXT 1
#endif
+
using namespace std;
namespace WebCore {
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (128300 => 128301)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2012-09-12 12:50:10 UTC (rev 128300)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2012-09-12 13:16:31 UTC (rev 128301)
@@ -124,6 +124,7 @@
#include Archive.h
#endif
+
namespace WebCore {
using namespace HTMLNames;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128302] trunk
Title: [128302] trunk
Revision 128302
Author zandober...@gmail.com
Date 2012-09-12 06:17:15 -0700 (Wed, 12 Sep 2012)
Log Message
Unreviewed, rolling out r128221.
http://trac.webkit.org/changeset/128221
https://bugs.webkit.org/show_bug.cgi?id=96504
The rollout was incorrect. (Requested by zdobersek on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-12
Source/WebCore:
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):
LayoutTests:
* http/tests/misc/non-utf8-header-name-expected.txt: Added.
* http/tests/misc/non-utf8-header-name.php: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp
Added Paths
trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt
trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php
Diff
Modified: trunk/LayoutTests/ChangeLog (128301 => 128302)
--- trunk/LayoutTests/ChangeLog 2012-09-12 13:16:31 UTC (rev 128301)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 13:17:15 UTC (rev 128302)
@@ -1,5 +1,17 @@
2012-09-12 Sheriff Bot webkit.review@gmail.com
+Unreviewed, rolling out r128221.
+http://trac.webkit.org/changeset/128221
+https://bugs.webkit.org/show_bug.cgi?id=96504
+
+The rollout was incorrect. (Requested by zdobersek on
+#webkit).
+
+* http/tests/misc/non-utf8-header-name-expected.txt: Added.
+* http/tests/misc/non-utf8-header-name.php: Added.
+
+2012-09-12 Sheriff Bot webkit.review@gmail.com
+
Unreviewed, rolling out r128280.
http://trac.webkit.org/changeset/128280
https://bugs.webkit.org/show_bug.cgi?id=96498
Added: trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (0 => 128302)
--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt 2012-09-12 13:17:15 UTC (rev 128302)
@@ -0,0 +1 @@
+Test for bug 96284: Non UTF-8 HTTP headers do not cause a crash.
Added: trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php (0 => 128302)
--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php (rev 0)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php 2012-09-12 13:17:15 UTC (rev 128302)
@@ -0,0 +1,9 @@
+?php
+header('HTTP/1.1 200 OK');
+header('\xC3: text/html');
+echo 'script';
+echo ' if (window.testRunner)';
+echo ' testRunner.dumpAsText();';
+echo '/script';
+echo 'pTest for a href="" 96284/a: Non UTF-8 HTTP headers do not cause a crash./p';
+?
Modified: trunk/Source/WebCore/ChangeLog (128301 => 128302)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 13:16:31 UTC (rev 128301)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 13:17:15 UTC (rev 128302)
@@ -1,3 +1,15 @@
+2012-09-12 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r128221.
+http://trac.webkit.org/changeset/128221
+https://bugs.webkit.org/show_bug.cgi?id=96504
+
+The rollout was incorrect. (Requested by zdobersek on
+#webkit).
+
+* platform/network/soup/ResourceResponseSoup.cpp:
+(WebCore::ResourceResponse::updateFromSoupMessage):
+
2012-09-12 Ilya Tikhonovsky loi...@chromium.org
Unreviewed. Touch two files for fixing broken compile dependency on Apple Windows Debug bot.
Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (128301 => 128302)
--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2012-09-12 13:16:31 UTC (rev 128301)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2012-09-12 13:17:15 UTC (rev 128302)
@@ -69,7 +69,7 @@
soup_message_headers_iter_init(headersIter, soupMessage-response_headers);
while (soup_message_headers_iter_next(headersIter, headerName, headerValue))
-m_httpHeaderFields.set(String::fromUTF8(headerName),
+m_httpHeaderFields.set(String::fromUTF8WithLatin1Fallback(headerName, strlen(headerName)),
String::fromUTF8WithLatin1Fallback(headerValue, strlen(headerValue)));
m_soupFlags = soup_message_get_flags(soupMessage);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128303] trunk/Source/WebCore
Title: [128303] trunk/Source/WebCore
Revision 128303
Author par...@webkit.org
Date 2012-09-12 06:51:02 -0700 (Wed, 12 Sep 2012)
Log Message
Remove last call to numberToString() from WebCore code
https://bugs.webkit.org/show_bug.cgi?id=96484
Reviewed by Kentaro Hara.
Replace WTF::numberToString() with String::numberToStringECMAScript() to remove duplicated
code. Using the new function allows us to improve and/or remove numberToString() without
changing all caller sides later. Also remove an unneeded strlen() in the touched code.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setNamedHiddenReference):
* bindings/v8/V8DependentRetained.h:
(WebCore::V8DependentRetained::createPropertyName):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::hiddenReferenceName):
* bindings/v8/V8HiddenPropertyName.h:
(V8HiddenPropertyName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
trunk/Source/WebCore/bindings/v8/V8DependentRetained.h
trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp
trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128302 => 128303)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 13:17:15 UTC (rev 128302)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 13:51:02 UTC (rev 128303)
@@ -1,3 +1,23 @@
+2012-09-12 Patrick Gansterer par...@webkit.org
+
+Remove last call to numberToString() from WebCore code
+https://bugs.webkit.org/show_bug.cgi?id=96484
+
+Reviewed by Kentaro Hara.
+
+Replace WTF::numberToString() with String::numberToStringECMAScript() to remove duplicated
+code. Using the new function allows us to improve and/or remove numberToString() without
+changing all caller sides later. Also remove an unneeded strlen() in the touched code.
+
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::setNamedHiddenReference):
+* bindings/v8/V8DependentRetained.h:
+(WebCore::V8DependentRetained::createPropertyName):
+* bindings/v8/V8HiddenPropertyName.cpp:
+(WebCore::V8HiddenPropertyName::hiddenReferenceName):
+* bindings/v8/V8HiddenPropertyName.h:
+(V8HiddenPropertyName):
+
2012-09-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r128221.
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (128302 => 128303)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-09-12 13:17:15 UTC (rev 128302)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-09-12 13:51:02 UTC (rev 128303)
@@ -118,7 +118,8 @@
void V8DOMWrapper::setNamedHiddenReference(v8::Handlev8::Object parent, const char* name, v8::Handlev8::Value child)
{
-parent-SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name), child);
+ASSERT(name);
+parent-SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);
}
WrapperTypeInfo* V8DOMWrapper::domWrapperType(v8::Handlev8::Object object)
Modified: trunk/Source/WebCore/bindings/v8/V8DependentRetained.h (128302 => 128303)
--- trunk/Source/WebCore/bindings/v8/V8DependentRetained.h 2012-09-12 13:17:15 UTC (rev 128302)
+++ trunk/Source/WebCore/bindings/v8/V8DependentRetained.h 2012-09-12 13:51:02 UTC (rev 128303)
@@ -76,13 +76,10 @@
private:
static v8::Handlev8::String createPropertyName()
{
-static const char* prefix = V8DependentRetained;
-NumberToStringBuffer buffer;
-Vectorchar, 64 name;
-const char* id = numberToString(V8PerIsolateData::current()-nextDependentRetainedId(), buffer);
-name.append(prefix, sizeof(prefix) - 1);
-name.append(id, strlen(id) + 1);
-return V8HiddenPropertyName::hiddenReferenceName(name.data(), NewString);
+StringBuilder name;
+name.appendLiteral(V8DependentRetained);
+name.append(String::numberToStringECMAScript(V8PerIsolateData::current()-nextDependentRetainedId()));
+return V8HiddenPropertyName::hiddenReferenceName(reinterpret_castconst char*(name.characters8()), name.length(), NewString);
}
static void ownerWeakCallback(v8::Persistentv8::Value object, void* parameter)
Modified: trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp (128302 => 128303)
--- trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp 2012-09-12 13:17:15 UTC (rev 128302)
+++ trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp 2012-09-12 13:51:02 UTC (rev 128303)
@@ -55,12 +55,12 @@
V8_HIDDEN_PROPERTIES(V8_DEFINE_HIDDEN_PROPERTY);
-v8::Handlev8::String V8HiddenPropertyName::hiddenReferenceName(const char* name, V8HiddenPropertyCreationType type)
+v8::Handlev8::String V8HiddenPropertyName::hiddenReferenceName(const char* name, unsigned length, V8HiddenPropertyCreationType type)
{
-ASSERT(name strlen(name));
+ASSERT(length);
Vectorchar, 64 prefixedName;
[webkit-changes] [128304] trunk/Tools
Title: [128304] trunk/Tools
Revision 128304
Author ves...@webkit.org
Date 2012-09-12 07:10:42 -0700 (Wed, 12 Sep 2012)
Log Message
[Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
By hard-coding the names of the targets we defined we ended up just
redefining the previous target when using addStrictSubdirOrderBetween
more than once in a single project file.
We now embed the two base targets into the target names.
Reviewed by Simon Hausmann.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/functions.prf
Diff
Modified: trunk/Tools/ChangeLog (128303 => 128304)
--- trunk/Tools/ChangeLog 2012-09-12 13:51:02 UTC (rev 128303)
+++ trunk/Tools/ChangeLog 2012-09-12 14:10:42 UTC (rev 128304)
@@ -1,3 +1,17 @@
+2012-09-12 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
+
+By hard-coding the names of the targets we defined we ended up just
+redefining the previous target when using addStrictSubdirOrderBetween
+more than once in a single project file.
+
+We now embed the two base targets into the target names.
+
+Reviewed by Simon Hausmann.
+
+* qmake/mkspecs/features/functions.prf:
+
2012-09-12 Philippe Liard pli...@google.com
Depend on {base,net} GYP targets rather than {base,net}_java.
Modified: trunk/Tools/qmake/mkspecs/features/functions.prf (128303 => 128304)
--- trunk/Tools/qmake/mkspecs/features/functions.prf 2012-09-12 13:51:02 UTC (rev 128303)
+++ trunk/Tools/qmake/mkspecs/features/functions.prf 2012-09-12 14:10:42 UTC (rev 128304)
@@ -142,18 +142,18 @@
# with the qmake-run of the -qmake_all target, and we end up with a race
# and potentially half-written makefiles. The custom target depends explicitly
# on -qmake_all, to ensure that we have a makefile, and then calls make.
-derived_make_for_qmake.target = $${first_base_target}-make_for_qmake
-derived_make_for_qmake.depends = $${first_base_target}-qmake_all
-derived_make_for_qmake.commands = $(MAKE) -f $$eval($${firstSubdir}.makefile)
-QMAKE_EXTRA_TARGETS += derived_make_for_qmake
+derived_make_for_qmake = $${first_base_target}-make_for_qmake
+eval($${derived_make_for_qmake}.depends = $${first_base_target}-qmake_all)
+eval($${derived_make_for_qmake}.commands = $(MAKE) -f $$eval($${firstSubdir}.makefile))
+QMAKE_EXTRA_TARGETS += $${derived_make_for_qmake}
# This target ensures that running make qmake_all will force both qmake and make
# to be run on the derived sources before running qmake on the target, so that
# qmake can pick up the right dependencies for the target based on the derived
# sources that were generated.
-target_make_qmake.target = $${second_base_target}-qmake_all
-target_make_qmake.depends = $${derived_make_for_qmake.target}
-QMAKE_EXTRA_TARGETS += target_make_qmake
+target_make_qmake = $${second_base_target}-qmake_all
+eval($${target_make_qmake}.depends = $${derived_make_for_qmake})
+QMAKE_EXTRA_TARGETS += $${target_make_qmake}
# Make things work even if qmake -r is used.
CONFIG += dont_recurse
@@ -161,13 +161,10 @@
export(SUBDIRS)
export(NO_RECURSIVE_QMAKE_SUBDIRS)
export(CONFIG)
-export(target_make_qmake.target)
-export(target_make_qmake.depends)
-export(derived_make_for_qmake.target)
-export(derived_make_for_qmake.depends)
-export(derived_make_for_qmake.commands)
-export(target_make.target)
-export(target_make.depends)
+export($${target_make_qmake}.target)
+export($${target_make_qmake}.depends)
+export($${derived_make_for_qmake}.depends)
+export($${derived_make_for_qmake}.commands)
export(QMAKE_EXTRA_TARGETS)
return(true)
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128305] trunk/Tools
Title: [128305] trunk/Tools
Revision 128305
Author ves...@webkit.org
Date 2012-09-12 07:11:01 -0700 (Wed, 12 Sep 2012)
Log Message
[Qt] Update build-jsc after r128174
Reviewed by Ossy.
* Scripts/build-jsc:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc
Diff
Modified: trunk/Tools/ChangeLog (128304 => 128305)
--- trunk/Tools/ChangeLog 2012-09-12 14:10:42 UTC (rev 128304)
+++ trunk/Tools/ChangeLog 2012-09-12 14:11:01 UTC (rev 128305)
@@ -1,5 +1,13 @@
2012-09-12 Tor Arne Vestbø tor.arne.ves...@nokia.com
+[Qt] Update build-jsc after r128174
+
+Reviewed by Ossy.
+
+* Scripts/build-jsc:
+
+2012-09-12 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
[Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
By hard-coding the names of the targets we defined we ended up just
Modified: trunk/Tools/Scripts/build-jsc (128304 => 128305)
--- trunk/Tools/Scripts/build-jsc 2012-09-12 14:10:42 UTC (rev 128304)
+++ trunk/Tools/Scripts/build-jsc 2012-09-12 14:11:01 UTC (rev 128305)
@@ -66,7 +66,7 @@
my @projects = (WTF, _javascript_Core);
# Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS if it is needed
push @ARGV, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'}) if ($ENV{'BUILD_WEBKIT_ARGS'});
-push @ARGV, --qmakearg=CONFIG+=no_webkit2 if checkForArgumentAndRemoveFromARGV(--no-webkit2);
+push @ARGV, WEBKIT_CONFIG-=build_webkit2 if checkForArgumentAndRemoveFromARGV(--no-webkit2);
my $result = buildQMakeProjects(\@projects, 0, @ARGV);
exit exitStatus($result);
} elsif (cmakeBasedPortName()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128306] trunk/LayoutTests
Title: [128306] trunk/LayoutTests Revision 128306 Author allan.jen...@nokia.com Date 2012-09-12 07:14:54 -0700 (Wed, 12 Sep 2012) Log Message Unreviewed gardening. These tests should have been unskipped when fixed. https://bugs.webkit.org/show_bug.cgi?id=93246 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (128305 => 128306) --- trunk/LayoutTests/ChangeLog 2012-09-12 14:11:01 UTC (rev 128305) +++ trunk/LayoutTests/ChangeLog 2012-09-12 14:14:54 UTC (rev 128306) @@ -1,3 +1,10 @@ +2012-09-12 Allan Sandfeld Jensen allan.jen...@nokia.com + +Unreviewed gardening. These tests should have been unskipped when fixed. +https://bugs.webkit.org/show_bug.cgi?id=93246 + +* platform/qt/Skipped: + 2012-09-12 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r128221. Modified: trunk/LayoutTests/platform/qt/Skipped (128305 => 128306) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-12 14:11:01 UTC (rev 128305) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-12 14:14:54 UTC (rev 128306) @@ -2738,11 +2738,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=92914 touchadjustment/touch-links-longpress.html -# New tests introduced in r124555 asserts on 32 bit platforms -# https://bugs.webkit.org/show_bug.cgi?id=93246 -fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html -fast/js/dfg-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html - # [Qt][GTK] REGRESSION(r125251): It made svg/custom/use-instanceRoot-as-event-target.xhtml assert and flakey # https://bugs.webkit.org/show_bug.cgi?id=93812 svg/custom/use-instanceRoot-as-event-target.xhtml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128307] trunk
Title: [128307] trunk Revision 128307 Author commit-qu...@webkit.org Date 2012-09-12 07:26:31 -0700 (Wed, 12 Sep 2012) Log Message [Qt] Drastically shorten length of commandline needed for JS bindings generator https://bugs.webkit.org/show_bug.cgi?id=96266 Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-09-12 Reviewed by Tor Arne Vestbø. The generate-bindings script supports the SOURCE_ROOT environment variable for IDL include file lookups, which allows specifying relative include search directories. * DerivedSources.pri: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.pri trunk/Tools/qmake/mkspecs/features/functions.prf Diff Modified: trunk/Source/WebCore/ChangeLog (128306 => 128307) --- trunk/Source/WebCore/ChangeLog 2012-09-12 14:14:54 UTC (rev 128306) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 14:26:31 UTC (rev 128307) @@ -1,3 +1,15 @@ +2012-09-12 Simon Hausmann simon.hausm...@nokia.com + +[Qt] Drastically shorten length of commandline needed for JS bindings generator +https://bugs.webkit.org/show_bug.cgi?id=96266 + +Reviewed by Tor Arne Vestbø. + +The generate-bindings script supports the SOURCE_ROOT environment variable for IDL include file +lookups, which allows specifying relative include search directories. + +* DerivedSources.pri: + 2012-09-12 Patrick Gansterer par...@webkit.org Remove last call to numberToString() from WebCore code Modified: trunk/Source/WebCore/DerivedSources.pri (128306 => 128307) --- trunk/Source/WebCore/DerivedSources.pri 2012-09-12 14:14:54 UTC (rev 128306) +++ trunk/Source/WebCore/DerivedSources.pri 2012-09-12 14:26:31 UTC (rev 128307) @@ -721,35 +721,35 @@ # GENERATOR 1: Generate .h and .cpp from IDLs generateBindings.input = IDL_BINDINGS generateBindings.script = $$PWD/bindings/scripts/generate-bindings.pl -generateBindings.commands = perl -I$$PWD/bindings/scripts $$generateBindings.script \ +generateBindings.commands = $$setEnvironmentVariable(SOURCE_ROOT, $$toSystemPath($$PWD)) perl -I$$PWD/bindings/scripts $$generateBindings.script \ --defines \$$_javascript_FeatureDefines()\ \ --generator JS \ ---include $$PWD/Modules/filesystem \ ---include $$PWD/Modules/geolocation \ ---include $$PWD/Modules/indexeddb \ ---include $$PWD/Modules/mediasource \ ---include $$PWD/Modules/notifications \ ---include $$PWD/Modules/quota \ ---include $$PWD/Modules/webaudio \ ---include $$PWD/Modules/webdatabase \ ---include $$PWD/Modules/websockets \ ---include $$PWD/css \ ---include $$PWD/dom \ ---include $$PWD/editing \ ---include $$PWD/fileapi \ ---include $$PWD/html \ ---include $$PWD/html/canvas \ ---include $$PWD/html/shadow \ ---include $$PWD/html/track \ ---include $$PWD/inspector \ ---include $$PWD/loader/appcache \ ---include $$PWD/page \ ---include $$PWD/plugins \ ---include $$PWD/storage \ ---include $$PWD/svg \ ---include $$PWD/testing \ ---include $$PWD/workers \ ---include $$PWD/xml \ +--include Modules/filesystem \ +--include Modules/geolocation \ +--include Modules/indexeddb \ +--include Modules/mediasource \ +--include Modules/notifications \ +--include Modules/quota \ +--include Modules/webaudio \ +--include Modules/webdatabase \ +--include Modules/websockets \ +--include css \ +--include dom \ +--include editing \ +--include fileapi \ +--include html \ +--include html/canvas \ +--include html/shadow \ +--include html/track \ +--include inspector \ +--include loader/appcache \ +--include page \ +--include plugins \ +--include storage \ +
[webkit-changes] [128308] trunk
Title: [128308] trunk
Revision 128308
Author commit-qu...@webkit.org
Date 2012-09-12 07:35:03 -0700 (Wed, 12 Sep 2012)
Log Message
[Qt] Build on Windows requires bison/flex in PATH
https://bugs.webkit.org/show_bug.cgi?id=96358
Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-09-12
Reviewed by Tor Arne Vestbø.
Source/ThirdParty/ANGLE:
Use MAKEFILE_NOOP_COMMAND instead of the \n\t trick to generate a dummy command. Otherwise
the PATH prepend trick will break because it generates a command line along the lines of
(set PATH=...) with just that trailing ampersand pair.
* DerivedSources.pri:
Tools:
The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
and Linux that is rarely a problem given how easily available the tools are. On Windows however
a separate installation of various GNU tools is required as the operating system doesn't come with
them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
the gnuwin32 directory of the qt5.git top-level repository.
This patch tries to detect the presence of those tools and prepends them to the PATH if found.
This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
updated with the new tool.
* Scripts/webkitdirs.pm:
(checkRequiredSystemConfig):
* qmake/mkspecs/features/default_post.prf:
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/DerivedSources.pri
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (128307 => 128308)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-09-12 14:26:31 UTC (rev 128307)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-09-12 14:35:03 UTC (rev 128308)
@@ -1,3 +1,16 @@
+2012-09-12 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Build on Windows requires bison/flex in PATH
+https://bugs.webkit.org/show_bug.cgi?id=96358
+
+Reviewed by Tor Arne Vestbø.
+
+Use MAKEFILE_NOOP_COMMAND instead of the \n\t trick to generate a dummy command. Otherwise
+the PATH prepend trick will break because it generates a command line along the lines of
+(set PATH=...) with just that trailing ampersand pair.
+
+* DerivedSources.pri:
+
2012-09-10 Dean Jackson d...@apple.com
[Apple] Install plist for Apple Open Source build system
Modified: trunk/Source/ThirdParty/ANGLE/DerivedSources.pri (128307 => 128308)
--- trunk/Source/ThirdParty/ANGLE/DerivedSources.pri 2012-09-12 14:26:31 UTC (rev 128307)
+++ trunk/Source/ThirdParty/ANGLE/DerivedSources.pri 2012-09-12 14:35:03 UTC (rev 128308)
@@ -31,7 +31,7 @@
GENERATORS += anglebison_decl
anglebison_impl.input = ANGLE_BISON_SOURCES
-anglebison_impl.commands = $$escape_expand(\\n)
+anglebison_impl.commands = $$MAKEFILE_NOOP_COMMAND
anglebison_impl.depends = $$GENERATED_SOURCES_DESTDIR/${QMAKE_FILE_BASE}_tab.h
anglebison_impl.output = ${QMAKE_FILE_BASE}_tab.cpp
GENERATORS += anglebison_impl
Modified: trunk/Tools/ChangeLog (128307 => 128308)
--- trunk/Tools/ChangeLog 2012-09-12 14:26:31 UTC (rev 128307)
+++ trunk/Tools/ChangeLog 2012-09-12 14:35:03 UTC (rev 128308)
@@ -1,3 +1,27 @@
+2012-09-12 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Build on Windows requires bison/flex in PATH
+https://bugs.webkit.org/show_bug.cgi?id=96358
+
+Reviewed by Tor Arne Vestbø.
+
+The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
+and Linux that is rarely a problem given how easily available the tools are. On Windows however
+a separate installation of various GNU tools is required as the operating system doesn't come with
+them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
+the gnuwin32 directory of the qt5.git top-level repository.
+
+This patch tries to detect the presence of those tools and prepends them to the PATH if found.
+
+This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
+PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
+as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
+updated with the new tool.
+
+* Scripts/webkitdirs.pm:
+(checkRequiredSystemConfig):
+* qmake/mkspecs/features/default_post.prf:
+
2012-09-12 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Update build-jsc after r128174
Modified: trunk/Tools/Scripts/webkitdirs.pm (128307 => 128308)
---
[webkit-changes] [128309] trunk
Title: [128309] trunk
Revision 128309
Author fmal...@chromium.org
Date 2012-09-12 07:36:26 -0700 (Wed, 12 Sep 2012)
Log Message
getScreenCTM returns different values depending on zoom
https://bugs.webkit.org/show_bug.cgi?id=96361
Reviewed by Dirk Schulze.
Source/WebCore:
SVGSVGElement::localCoordinateSpaceTransform() needs to adjust for the
zoom level (which is already factored into CSS coordinates) at the
SVG/HTML boundary.
Test: svg/zoom/page/zoom-get-screen-ctm.html
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
LayoutTests:
* svg/zoom/page/zoom-get-screen-ctm-expected.txt: Added.
* svg/zoom/page/zoom-get-screen-ctm.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGSVGElement.cpp
Added Paths
trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt
trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html
Diff
Modified: trunk/LayoutTests/ChangeLog (128308 => 128309)
--- trunk/LayoutTests/ChangeLog 2012-09-12 14:35:03 UTC (rev 128308)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 14:36:26 UTC (rev 128309)
@@ -1,3 +1,13 @@
+2012-09-12 Florin Malita fmal...@chromium.org
+
+getScreenCTM returns different values depending on zoom
+https://bugs.webkit.org/show_bug.cgi?id=96361
+
+Reviewed by Dirk Schulze.
+
+* svg/zoom/page/zoom-get-screen-ctm-expected.txt: Added.
+* svg/zoom/page/zoom-get-screen-ctm.html: Added.
+
2012-09-12 Allan Sandfeld Jensen allan.jen...@nokia.com
Unreviewed gardening. These tests should have been unskipped when fixed.
Added: trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt (0 => 128309)
--- trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt 2012-09-12 14:36:26 UTC (rev 128309)
@@ -0,0 +1,14 @@
+This test checks getScreenCTM() on zoomed pages.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS CTM1 is 1, 0, 0, 1, 0, 100
+PASS CTM2 is 1, 0, 0, 1, 100, 200
+PASS CTM3 is 1, 0, 0, 1, 200, 300
+PASS CTM4 is 1, 0, 0, 1, 300, 400
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html (0 => 128309)
--- trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html (rev 0)
+++ trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html 2012-09-12 14:36:26 UTC (rev 128309)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+html
+body style=margin: 0px; padding: 0px; _onload_=runRepaintTest()
+ div style=width: 100px; height: 100px;/div
+ svg id=svg1 xmlns=http://www.w3.org/2000/svg width=400 height=400
+rect width=100 height=100 fill=green/
+svg id=svg2 x=100 y=100 width=300 height=300
+ rect width=100 height=100 fill=green/
+ svg id=svg3 x=100 y=100 width=200 height=200
+rect width=100 height=100 fill=green/
+svg id=svg4 x=100 y=100 width=100 height=100
+ rect width=100 height=100 fill=green/
+/svg
+ /svg
+/svg
+ /svg
+
+script
+ var zoomCount = 2;
+
+ if (window.testRunner) {
+testRunner.waitUntilDone();
+window.postZoomCallback = executeTest;
+ }
+
+ function ctmToString(ctm) {
+return [ ctm.a, ctm.b, ctm.c, ctm.d, ctm.e, ctm.f ].join(', ');
+ }
+
+ function executeTest() {
+CTM1 = ctmToString(document.getElementById('svg1').getScreenCTM());
+CTM2 = ctmToString(document.getElementById('svg2').getScreenCTM());
+CTM3 = ctmToString(document.getElementById('svg3').getScreenCTM());
+CTM4 = ctmToString(document.getElementById('svg4').getScreenCTM());
+
+description(This test checks getScreenCTM() on zoomed pages.);
+
+shouldBeEqualToString('CTM1', '1, 0, 0, 1, 0, 100');
+shouldBeEqualToString('CTM2', '1, 0, 0, 1, 100, 200');
+shouldBeEqualToString('CTM3', '1, 0, 0, 1, 200, 300');
+shouldBeEqualToString('CTM4', '1, 0, 0, 1, 300, 400');
+debug('');
+ }
+
+/script
+script src=""
+script src=""
+script src=""
+
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (128308 => 128309)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 14:35:03 UTC (rev 128308)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 14:36:26 UTC (rev 128309)
@@ -1,3 +1,19 @@
+2012-09-12 Florin Malita fmal...@chromium.org
+
+getScreenCTM returns different values depending on zoom
+https://bugs.webkit.org/show_bug.cgi?id=96361
+
+Reviewed by Dirk Schulze.
+
+SVGSVGElement::localCoordinateSpaceTransform() needs to adjust for the
+zoom level (which is already factored into CSS coordinates) at the
+SVG/HTML boundary.
+
+Test: svg/zoom/page/zoom-get-screen-ctm.html
+
+* svg/SVGSVGElement.cpp:
+(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
+
2012-09-12 Simon Hausmann simon.hausm...@nokia.com
[Qt]
[webkit-changes] [128310] trunk/LayoutTests
Title: [128310] trunk/LayoutTests Revision 128310 Author zandober...@gmail.com Date 2012-09-12 08:04:00 -0700 (Wed, 12 Sep 2012) Log Message Unreviewed GTK gardening. Adding baseline for an accessibility test introduced in r128227. Adding a text mismatch failure expectation for fast/events/popup-blocking-timers.html that started failing after the test was refactored in r128270. * platform/gtk/TestExpectations: * platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Added Paths trunk/LayoutTests/platform/gtk/accessibility/img-fallsback-to-title-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (128309 => 128310) --- trunk/LayoutTests/ChangeLog 2012-09-12 14:36:26 UTC (rev 128309) +++ trunk/LayoutTests/ChangeLog 2012-09-12 15:04:00 UTC (rev 128310) @@ -1,3 +1,15 @@ +2012-09-12 Zan Dobersek zandober...@gmail.com + +Unreviewed GTK gardening. + +Adding baseline for an accessibility test introduced in r128227. + +Adding a text mismatch failure expectation for fast/events/popup-blocking-timers.html +that started failing after the test was refactored in r128270. + +* platform/gtk/TestExpectations: +* platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Added. + 2012-09-12 Florin Malita fmal...@chromium.org getScreenCTM returns different values depending on zoom Modified: trunk/LayoutTests/platform/gtk/TestExpectations (128309 => 128310) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-12 14:36:26 UTC (rev 128309) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-12 15:04:00 UTC (rev 128310) @@ -1310,6 +1310,8 @@ BUGWK96226 : fast/spatial-navigation/snav-fully-aligned-vertically.html = TEXT BUGWK96226 : fast/spatial-navigation/snav-imagemap-overlapped-areas.html = TEXT +BUGWK96517 : fast/events/popup-blocking-timers.html = TEXT + // // End of Tests failing // Added: trunk/LayoutTests/platform/gtk/accessibility/img-fallsback-to-title-expected.txt (0 => 128310) --- trunk/LayoutTests/platform/gtk/accessibility/img-fallsback-to-title-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/accessibility/img-fallsback-to-title-expected.txt 2012-09-12 15:04:00 UTC (rev 128310) @@ -0,0 +1,25 @@ + +test +test +This tests that images will fallback to using the title attribute if no other descriptive text is present. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +Image1 description: AXDescription: test1 +Image1 help: AXHelp: + +Image2 description: AXDescription: test2 +Image2 help: AXHelp: test2 + +Image3 description: AXDescription: test3 +Image3 help: AXHelp: + +Image4 description: AXDescription: alt +Image4 help: AXHelp: test4 + +PASS imagesGroup.childAtIndex(0).childrenCount is 2 +PASS successfullyParsed is true + +TEST COMPLETE + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128311] trunk/Source/WebCore
Title: [128311] trunk/Source/WebCore
Revision 128311
Author kenn...@webkit.org
Date 2012-09-12 08:08:07 -0700 (Wed, 12 Sep 2012)
Log Message
[EFL] Avoid manual memory management in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=96501
Reviewed by Simon Hausmann.
Use OwnPtr as it works for Evas_Object and Evas_Ecore objects.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::ThemePartCacheEntry):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::~ThemePartCacheEntry):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setColorFromThemeClass):
(WebCore::RenderThemeEfl::themePath):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::~RenderThemeEfl):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::canvas):
(WebCore::RenderThemeEfl::edje):
(RenderThemeEfl):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::canvas):
(WebCore::RenderThemeEfl::ThemePartCacheEntry::edje):
(ThemePartCacheEntry):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebCore/platform/efl/RenderThemeEfl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128310 => 128311)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 15:04:00 UTC (rev 128310)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 15:08:07 UTC (rev 128311)
@@ -1,3 +1,33 @@
+2012-09-12 Kenneth Rohde Christiansen kenn...@webkit.org
+
+[EFL] Avoid manual memory management in RenderThemeEfl
+https://bugs.webkit.org/show_bug.cgi?id=96501
+
+Reviewed by Simon Hausmann.
+
+Use OwnPtr as it works for Evas_Object and Evas_Ecore objects.
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::ThemePartCacheEntry):
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::~ThemePartCacheEntry):
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
+(WebCore::RenderThemeEfl::paintThemePart):
+(WebCore::RenderThemeEfl::setColorFromThemeClass):
+(WebCore::RenderThemeEfl::themePath):
+(WebCore::RenderThemeEfl::loadTheme):
+(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
+(WebCore::RenderThemeEfl::RenderThemeEfl):
+(WebCore::RenderThemeEfl::~RenderThemeEfl):
+(WebCore::RenderThemeEfl::emitMediaButtonSignal):
+* platform/efl/RenderThemeEfl.h:
+(WebCore::RenderThemeEfl::canvas):
+(WebCore::RenderThemeEfl::edje):
+(RenderThemeEfl):
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::canvas):
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::edje):
+(ThemePartCacheEntry):
+
2012-09-12 Florin Malita fmal...@chromium.org
getScreenCTM returns different values depending on zoom
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (128310 => 128311)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-09-12 15:04:00 UTC (rev 128310)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-09-12 15:08:07 UTC (rev 128311)
@@ -163,7 +163,7 @@
}
RenderThemeEfl::ThemePartCacheEntry::ThemePartCacheEntry()
-: ee(0), o(0), surface(0)
+: surface(0)
{
}
@@ -171,10 +171,6 @@
{
if (surface)
cairo_surface_destroy(surface);
-if (o)
-evas_object_del(o);
-if (ee)
-ecore_evas_free(ee);
}
static cairo_surface_t* createCairoSurfaceFor(Ecore_Evas* ee)
@@ -219,27 +215,27 @@
OwnPtrThemePartCacheEntry* entry = adoptPtr(new ThemePartCacheEntry);
-entry-ee = ecore_evas_buffer_new(size.width(), size.height());
-if (!entry-ee) {
+entry-m_canvas = adoptPtr(ecore_evas_buffer_new(size.width(), size.height()));
+if (!entry-canvas()) {
EINA_LOG_ERR(ecore_evas_buffer_new(%d, %d) failed., size.width(), size.height());
return 0;
}
// By default EFL creates buffers without alpha.
-ecore_evas_alpha_set(entry-ee, EINA_TRUE);
+ecore_evas_alpha_set(entry-canvas(), EINA_TRUE);
-entry-o = edje_object_add(ecore_evas_get(entry-ee));
-ASSERT(entry-o);
+entry-m_edje = adoptPtr(edje_object_add(ecore_evas_get(entry-canvas(;
+ASSERT(entry-edje());
-if (!setSourceGroupForEdjeObject(entry-o, themePath, toEdjeGroup(type)))
+if (!setSourceGroupForEdjeObject(entry-edje(), themePath, toEdjeGroup(type)))
return 0;
-entry-surface = createCairoSurfaceFor(entry-ee);
+entry-surface = createCairoSurfaceFor(entry-canvas());
if (!entry-surface)
return 0;
-evas_object_resize(entry-o, size.width(), size.height());
-evas_object_show(entry-o);
+
[webkit-changes] [128312] trunk/Source/WebCore
Title: [128312] trunk/Source/WebCore
Revision 128312
Author commit-qu...@webkit.org
Date 2012-09-12 08:21:46 -0700 (Wed, 12 Sep 2012)
Log Message
[BlackBerry] Use own instance of CertMgrWrapper in BlackBerry CredentialBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=96457
Internal PR: 205769
Internally reviewed by George Staikos, Jonathan Dong.
Patch by Lianghui Chen liac...@rim.com on 2012-09-12
Reviewed by George Staikos.
CertMgrWrapper in BlackBerry platform layer has been changed from
singleton to normal class, every user of it need to create its own
instance now.
No new tests for platform specific interface change.
* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::certMgrWrapper):
(WebCore):
* platform/network/blackberry/CredentialBackingStore.h:
(Platform):
(CredentialBackingStore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp
trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128311 => 128312)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 15:08:07 UTC (rev 128311)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 15:21:46 UTC (rev 128312)
@@ -1,3 +1,30 @@
+2012-09-12 Lianghui Chen liac...@rim.com
+
+[BlackBerry] Use own instance of CertMgrWrapper in BlackBerry CredentialBackingStore.
+https://bugs.webkit.org/show_bug.cgi?id=96457
+Internal PR: 205769
+
+Internally reviewed by George Staikos, Jonathan Dong.
+Reviewed by George Staikos.
+
+CertMgrWrapper in BlackBerry platform layer has been changed from
+singleton to normal class, every user of it need to create its own
+instance now.
+
+No new tests for platform specific interface change.
+
+* platform/network/blackberry/CredentialBackingStore.cpp:
+(WebCore::CredentialBackingStore::CredentialBackingStore):
+(WebCore::CredentialBackingStore::~CredentialBackingStore):
+(WebCore::CredentialBackingStore::addLogin):
+(WebCore::CredentialBackingStore::updateLogin):
+(WebCore::CredentialBackingStore::getLogin):
+(WebCore::CredentialBackingStore::certMgrWrapper):
+(WebCore):
+* platform/network/blackberry/CredentialBackingStore.h:
+(Platform):
+(CredentialBackingStore):
+
2012-09-12 Kenneth Rohde Christiansen kenn...@webkit.org
[EFL] Avoid manual memory management in RenderThemeEfl
Modified: trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp (128311 => 128312)
--- trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp 2012-09-12 15:08:07 UTC (rev 128311)
+++ trunk/Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp 2012-09-12 15:21:46 UTC (rev 128312)
@@ -69,12 +69,14 @@
, m_hasNeverRememberStatement(0)
, m_getNeverRememberStatement(0)
, m_removeNeverRememberStatement(0)
-, m_usingCertManager(BlackBerry::Platform::CertMgrWrapper::instance()-isReady())
+, m_certMgrWrapper(0)
{
}
CredentialBackingStore::~CredentialBackingStore()
{
+delete m_certMgrWrapper;
+m_certMgrWrapper = 0;
delete m_addLoginStatement;
m_addLoginStatement = 0;
delete m_updateLoginStatement;
@@ -184,17 +186,17 @@
m_addLoginStatement-bindText(5, protectionSpace.realm());
m_addLoginStatement-bindInt(6, static_castint(protectionSpace.authenticationScheme()));
m_addLoginStatement-bindText(7, credential.user());
-m_addLoginStatement-bindBlob(8, m_usingCertManager ? : encryptedString(credential.password()));
+m_addLoginStatement-bindBlob(8, certMgrWrapper()-isReady() ? : encryptedString(credential.password()));
int result = m_addLoginStatement-step();
m_addLoginStatement-reset();
HANDLE_SQL_EXEC_FAILURE(result != SQLResultDone, false,
Failed to add login info into table logins - %i, result);
-if (!m_usingCertManager)
+if (!certMgrWrapper()-isReady())
return true;
unsigned hash = hashCredentialInfo(url.string(), protectionSpace, credential.user());
-return BlackBerry::Platform::CertMgrWrapper::instance()-savePassword(hash, encryptedString(credential.password()).latin1().data());
+return certMgrWrapper()-savePassword(hash, encryptedString(credential.password()).latin1().data());
}
bool CredentialBackingStore::updateLogin(const KURL url, const ProtectionSpace protectionSpace, const Credential credential)
@@ -206,7 +208,7 @@
return false;
m_updateLoginStatement-bindText(1, credential.user());
-m_updateLoginStatement-bindBlob(2,
[webkit-changes] [128314] trunk/LayoutTests
Title: [128314] trunk/LayoutTests Revision 128314 Author ad...@chromium.org Date 2012-09-12 08:34:37 -0700 (Wed, 12 Sep 2012) Log Message Mark new test fast/filesystem/workers/detached-frame-crash.html as flakily crashing in cr-win cr-linux debug builds. Unreviewed gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (128313 => 128314) --- trunk/LayoutTests/ChangeLog 2012-09-12 15:32:48 UTC (rev 128313) +++ trunk/LayoutTests/ChangeLog 2012-09-12 15:34:37 UTC (rev 128314) @@ -1,3 +1,12 @@ +2012-09-12 Adam Klein ad...@chromium.org + +Mark new test fast/filesystem/workers/detached-frame-crash.html +as flakily crashing in cr-win cr-linux debug builds. + +Unreviewed gardening. + +* platform/chromium/TestExpectations: + 2012-09-12 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128313 => 128314) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 15:32:48 UTC (rev 128313) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 15:34:37 UTC (rev 128314) @@ -3620,4 +3620,6 @@ BUGWK96227 SKIP : fast/js/function-dot-arguments-identity.html = TEXT +BUGWK96524 WIN LINUX DEBUG : fast/filesystem/workers/detached-frame-crash.html = PASS CRASH + BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128315] trunk/Source
Title: [128315] trunk/Source
Revision 128315
Author commit-qu...@webkit.org
Date 2012-09-12 08:36:45 -0700 (Wed, 12 Sep 2012)
Log Message
[Qt] Segmentation fault when closing QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=95003
Patch by Roland Takacs rtak...@inf.u-szeged.hu on 2012-09-12
Reviewed by Simon Hausmann.
Source/WebCore:
Defined a new QObject* variable.
If WebKit1 is used, it points to the QGLWidget that was
created in 'createPlatformGraphicsContext3DFromWidget'.
If WebKit2 is used, it points to the QWindow that was
created in GraphicsContext3DPrivate's constructor.
It is neccessary for deallocating them.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
* platform/qt/QWebPageClient.h:
(QWebPageClient):
Source/WebKit/qt:
Defined a new QObject* variable that points to the QGLWidget that was created
in 'createPlatformGraphicsContext3DFromWidget'.
It is neccessary for deallocating it.
* WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):
* WebCoreSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp
trunk/Source/WebCore/platform/qt/QWebPageClient.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128314 => 128315)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 15:34:37 UTC (rev 128314)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 15:36:45 UTC (rev 128315)
@@ -1,3 +1,24 @@
+2012-09-12 Roland Takacs rtak...@inf.u-szeged.hu
+
+[Qt] Segmentation fault when closing QtTestBrowser
+https://bugs.webkit.org/show_bug.cgi?id=95003
+
+Reviewed by Simon Hausmann.
+
+Defined a new QObject* variable.
+If WebKit1 is used, it points to the QGLWidget that was
+created in 'createPlatformGraphicsContext3DFromWidget'.
+If WebKit2 is used, it points to the QWindow that was
+created in GraphicsContext3DPrivate's constructor.
+It is neccessary for deallocating them.
+
+* platform/graphics/qt/GraphicsContext3DQt.cpp:
+(GraphicsContext3DPrivate):
+(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
+(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
+* platform/qt/QWebPageClient.h:
+(QWebPageClient):
+
2012-09-12 Ryuan Choi ryuan.c...@samsung.com
[EFL] Fix build break when netscape-plugin-api is enebled after r126971
Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (128314 => 128315)
--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp 2012-09-12 15:34:37 UTC (rev 128314)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp 2012-09-12 15:36:45 UTC (rev 128315)
@@ -84,6 +84,7 @@
HostWindow* m_hostWindow;
PlatformGraphicsSurface3D m_surface;
PlatformGraphicsContext3D m_platformContext;
+QObject* m_surfaceOwner;
#if USE(GRAPHICS_SURFACE)
GraphicsSurface::Flags m_surfaceFlags;
RefPtrGraphicsSurface m_graphicsSurface;
@@ -111,11 +112,12 @@
, m_hostWindow(hostWindow)
, m_surface(0)
, m_platformContext(0)
+, m_surfaceOwner(0)
{
if (m_hostWindow m_hostWindow-platformPageClient()) {
// This is the WebKit1 code path.
QWebPageClient* webPageClient = m_hostWindow-platformPageClient();
-webPageClient-createPlatformGraphicsContext3D(m_platformContext, m_surface);
+webPageClient-createPlatformGraphicsContext3D(m_platformContext, m_surface, m_surfaceOwner);
if (!m_surface)
return;
@@ -137,6 +139,7 @@
window-setGeometry(-10, -10, 1, 1);
window-create();
m_surface = window;
+m_surfaceOwner = window;
m_platformContext = new QOpenGLContext(window);
if (!m_platformContext-create())
@@ -208,12 +211,8 @@
GraphicsContext3DPrivate::~GraphicsContext3DPrivate()
{
-if (m_hostWindow) {
-delete m_surface;
-m_surface = 0;
-// Platform context is assumed to be owned by surface.
-m_platformContext = 0;
-}
+delete m_surfaceOwner;
+m_surfaceOwner = 0;
}
static inline quint32 swapBgrToRgb(quint32 pixel)
Modified: trunk/Source/WebCore/platform/qt/QWebPageClient.h (128314 => 128315)
--- trunk/Source/WebCore/platform/qt/QWebPageClient.h 2012-09-12 15:34:37 UTC (rev 128314)
+++ trunk/Source/WebCore/platform/qt/QWebPageClient.h 2012-09-12 15:36:45 UTC (rev 128315)
@@ -108,7 +108,8 @@
#if USE(3D_GRAPHICS)
virtual void
[webkit-changes] [128316] trunk/Source/WebCore
Title: [128316] trunk/Source/WebCore Revision 128316 Author pilg...@chromium.org Date 2012-09-12 08:44:18 -0700 (Wed, 12 Sep 2012) Log Message [Chromium] Remove unused getProcessMemorySize from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=96520 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * platform/chromium/PlatformSupport.h: (PlatformSupport): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/PlatformSupport.h Diff Modified: trunk/Source/WebCore/ChangeLog (128315 => 128316) --- trunk/Source/WebCore/ChangeLog 2012-09-12 15:36:45 UTC (rev 128315) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 15:44:18 UTC (rev 128316) @@ -1,3 +1,15 @@ +2012-09-12 Mark Pilgrim pilg...@chromium.org + +[Chromium] Remove unused getProcessMemorySize from PlatformSupport +https://bugs.webkit.org/show_bug.cgi?id=96520 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* platform/chromium/PlatformSupport.h: +(PlatformSupport): + 2012-09-12 Roland Takacs rtak...@inf.u-szeged.hu [Qt] Segmentation fault when closing QtTestBrowser Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (128315 => 128316) --- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-12 15:36:45 UTC (rev 128315) +++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-12 15:44:18 UTC (rev 128316) @@ -134,10 +134,6 @@ static IntRect screenRect(Widget*); static IntRect screenAvailableRect(Widget*); -// Returns private and shared usage, in bytes. Private bytes is the amount of -// memory currently allocated to this process that cannot be shared. Returns -// false on platform specific error conditions. -static bool getProcessMemorySize(size_t* privateBytes, size_t* sharedBytes); // Theming #if OS(WINDOWS) static void paintButton( ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128319] releases/WebKitGTK/webkit-1.10/Source/WebCore
Title: [128319] releases/WebKitGTK/webkit-1.10/Source/WebCore Revision 128319 Author carlo...@webkit.org Date 2012-09-12 09:02:10 -0700 (Wed, 12 Sep 2012) Log Message Merge r126441 - Replace access ot HTMLMediaElement from MediaPlayerPrivateBlackBerry with methods in MediaPlayerClient - updated with notes from initial reviews. https://bugs.webkit.org/show_bug.cgi?id=84291 Reviewed by Eric Carlson. Code standard compliance - no functional change, so no new tests required. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerExitFullscreen): (WebCore): (WebCore::HTMLMediaElement::mediaPlayerIsVideo): (WebCore::HTMLMediaElement::mediaPlayerContentBoxRect): (WebCore::HTMLMediaElement::mediaPlayerSetSize): (WebCore::HTMLMediaElement::mediaPlayerPause): (WebCore::HTMLMediaElement::mediaPlayerPlay): (WebCore::HTMLMediaElement::mediaPlayerIsPaused): (WebCore::HTMLMediaElement::mediaPlayerHostWindow): (WebCore::HTMLMediaElement::mediaPlayerWindowClipRect): * html/HTMLMediaElement.h: (HTMLMediaElement): * platform/graphics/MediaPlayer.h: (WebCore): (WebCore::MediaPlayerClient::mediaPlayerExitFullscreen): (WebCore::MediaPlayerClient::mediaPlayerIsVideo): (WebCore::MediaPlayerClient::mediaPlayerContentBoxRect): (WebCore::MediaPlayerClient::mediaPlayerSetSize): (WebCore::MediaPlayerClient::mediaPlayerPause): (WebCore::MediaPlayerClient::mediaPlayerPlay): (WebCore::MediaPlayerClient::mediaPlayerIsPaused): (WebCore::MediaPlayerClient::mediaPlayerHostWindow): (WebCore::MediaPlayerClient::mediaPlayerWindowClipRect): * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::resizeSourceDimensions): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::onPauseStateChanged): (WebCore::MediaPlayerPrivate::onPlayNotified): (WebCore::MediaPlayerPrivate::onPauseNotified): (WebCore::MediaPlayerPrivate::onAuthenticationNeeded): (WebCore::MediaPlayerPrivate::showErrorDialog): (WebCore::MediaPlayerPrivate::platformWindow): (WebCore::MediaPlayerPrivate::isElementPaused): (WebCore::MediaPlayerPrivate::isTabVisible): * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h: (MediaPlayerPrivate): Patch by John Griggs jgri...@rim.com on 2012-08-23 Modified Paths releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebCore/html/HTMLMediaElement.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/html/HTMLMediaElement.h releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/graphics/MediaPlayer.h releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h Diff Modified: releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog (128318 => 128319) --- releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 15:49:52 UTC (rev 128318) +++ releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 16:02:10 UTC (rev 128319) @@ -1,3 +1,52 @@ +2012-08-23 John Griggs jgri...@rim.com + +Replace access ot HTMLMediaElement from MediaPlayerPrivateBlackBerry with methods in MediaPlayerClient - updated with notes from initial reviews. https://bugs.webkit.org/show_bug.cgi?id=84291 + +Reviewed by Eric Carlson. + +Code standard compliance - no functional change, so no new tests required. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::mediaPlayerExitFullscreen): +(WebCore): +(WebCore::HTMLMediaElement::mediaPlayerIsVideo): +(WebCore::HTMLMediaElement::mediaPlayerContentBoxRect): +(WebCore::HTMLMediaElement::mediaPlayerSetSize): +(WebCore::HTMLMediaElement::mediaPlayerPause): +(WebCore::HTMLMediaElement::mediaPlayerPlay): +(WebCore::HTMLMediaElement::mediaPlayerIsPaused): +(WebCore::HTMLMediaElement::mediaPlayerHostWindow): +(WebCore::HTMLMediaElement::mediaPlayerWindowClipRect): +* html/HTMLMediaElement.h: +(HTMLMediaElement): +* platform/graphics/MediaPlayer.h: +(WebCore): +(WebCore::MediaPlayerClient::mediaPlayerExitFullscreen): +(WebCore::MediaPlayerClient::mediaPlayerIsVideo): +(WebCore::MediaPlayerClient::mediaPlayerContentBoxRect): +
[webkit-changes] [128320] releases/WebKitGTK/webkit-1.10/Source/WebCore
Title: [128320] releases/WebKitGTK/webkit-1.10/Source/WebCore Revision 128320 Author carlo...@webkit.org Date 2012-09-12 09:03:22 -0700 (Wed, 12 Sep 2012) Log Message Merge r128298 - [GStreamer] Audio device not closed after playing sound https://bugs.webkit.org/show_bug.cgi?id=89122 Reviewed by Martin Robinson. Set the GStreamer pipeline to NULL instead of PAUSED on EOS. This allows the audio-sink to release its connection to the audio device. This is done only if the Media element is not looping. To make the MediaPlayerPrivate layer aware of that information the MediaPlayerClient interface was updated with a new method mediaPlayerIsLooping, implemented by the HTMLMediaElement. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerIsLooping): Implementation of MediaPlayerClient::mediaPlayerLoop, proxies to ::loop(); * html/HTMLMediaElement.h: (HTMLMediaElement): * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerIsLooping): New method allowing the MediaPlayer and its backend to know if a playback loop is requested by the client. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::playbackPosition): Report seek time or media duration if EOS was reached. These early returns are needed because the position query doesn't work on a NULL pipeline. (WebCore::MediaPlayerPrivateGStreamer::changePipelineState): Refactored to use an early return. (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Reset the seeking flag. (WebCore::MediaPlayerPrivateGStreamer::play): reset m_isEndReached. (WebCore::MediaPlayerPrivateGStreamer::pause): Don't pause on EOS. (WebCore::MediaPlayerPrivateGStreamer::seek): Refactor, call currentTime() after we're sure playbin is valid and no error occured. (WebCore::MediaPlayerPrivateGStreamer::paused): Fake paused state on EOS. Modified Paths releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebCore/html/HTMLMediaElement.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/html/HTMLMediaElement.h releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/graphics/MediaPlayer.h releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Diff Modified: releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog (128319 => 128320) --- releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 16:02:10 UTC (rev 128319) +++ releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 16:03:22 UTC (rev 128320) @@ -1,3 +1,43 @@ +2012-08-20 Philippe Normand pnorm...@igalia.com + +[GStreamer] Audio device not closed after playing sound +https://bugs.webkit.org/show_bug.cgi?id=89122 + +Reviewed by Martin Robinson. + +Set the GStreamer pipeline to NULL instead of PAUSED on EOS. This +allows the audio-sink to release its connection to the audio +device. This is done only if the Media element is not +looping. To make the MediaPlayerPrivate layer aware of that +information the MediaPlayerClient interface was updated with a new +method mediaPlayerIsLooping, implemented by the HTMLMediaElement. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::mediaPlayerIsLooping): Implementation of +MediaPlayerClient::mediaPlayerLoop, proxies to ::loop(); +* html/HTMLMediaElement.h: +(HTMLMediaElement): +* platform/graphics/MediaPlayer.h: +(WebCore::MediaPlayerClient::mediaPlayerIsLooping): New method allowing +the MediaPlayer and its backend to know if a playback loop is +requested by the client. +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: +(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): +(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): Report +seek time or media duration if EOS was reached. These early +returns are needed because the position query doesn't work on a +NULL pipeline. +(WebCore::MediaPlayerPrivateGStreamer::changePipelineState): +Refactored to use an early return. +(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Reset the +seeking flag. +(WebCore::MediaPlayerPrivateGStreamer::play): reset m_isEndReached. +(WebCore::MediaPlayerPrivateGStreamer::pause): Don't pause on EOS. +(WebCore::MediaPlayerPrivateGStreamer::seek): Refactor, call +currentTime() after we're sure playbin is valid and no error occured. +(WebCore::MediaPlayerPrivateGStreamer::paused): Fake paused state +on EOS. + 2012-08-23 John Griggs jgri...@rim.com Replace access ot HTMLMediaElement from MediaPlayerPrivateBlackBerry with methods in MediaPlayerClient - updated with notes from initial reviews.
[webkit-changes] [128321] trunk/Tools
Title: [128321] trunk/Tools
Revision 128321
Author zandober...@gmail.com
Date 2012-09-12 09:06:55 -0700 (Wed, 12 Sep 2012)
Log Message
Flakiness dashboard doesn't recognize new Chromium Android test builder
https://bugs.webkit.org/show_bug.cgi?id=96523
Reviewed by Ojan Vafai.
Properly return 'ANDROID' as the Chromium platform for Android builders.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(chromiumPlatform):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js
Diff
Modified: trunk/Tools/ChangeLog (128320 => 128321)
--- trunk/Tools/ChangeLog 2012-09-12 16:03:22 UTC (rev 128320)
+++ trunk/Tools/ChangeLog 2012-09-12 16:06:55 UTC (rev 128321)
@@ -1,3 +1,17 @@
+2012-09-12 Zan Dobersek zandober...@gmail.com
+
+Flakiness dashboard doesn't recognize new Chromium Android test builder
+https://bugs.webkit.org/show_bug.cgi?id=96523
+
+Reviewed by Ojan Vafai.
+
+Properly return 'ANDROID' as the Chromium platform for Android builders.
+
+* TestResultServer/static-dashboards/flakiness_dashboard.js:
+(chromiumPlatform):
+* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+(test):
+
2012-09-12 Simon Hausmann simon.hausm...@nokia.com
[Qt] Build on Windows requires bison/flex in PATH
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (128320 => 128321)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-09-12 16:03:22 UTC (rev 128320)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-09-12 16:06:55 UTC (rev 128321)
@@ -40,7 +40,7 @@
// FIXME: These platform names should probably be changed to match the directories in LayoutTests/platform
// instead of matching the values we use in the TestExpectations file.
-var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX', 'EFL'];
+var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'ANDROID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX', 'EFL'];
var PLATFORM_UNIONS = {
'MAC': ['SNOWLEOPARD', 'LION'],
'WIN': ['XP', 'WIN7'],
@@ -285,6 +285,8 @@
return 'XP';
if (stringContains(builderNameUpperCase, 'LINUX'))
return 'LUCID';
+if (stringContains(builderNameUpperCase, 'ANDROID'))
+return 'ANDROID';
// The interactive bot is XP, but doesn't have an OS in it's name.
if (stringContains(builderNameUpperCase, 'INTERACTIVE'))
return 'XP';
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (128320 => 128321)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-09-12 16:03:22 UTC (rev 128320)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-09-12 16:06:55 UTC (rev 128321)
@@ -190,7 +190,7 @@
equal(realModifiers('BUGFOO'), '');
});
-test('allTestsWithSamePlatformAndBuildType', 13, function() {
+test('allTestsWithSamePlatformAndBuildType', 14, function() {
// FIXME: test that allTestsWithSamePlatformAndBuildType actually returns the right set of tests.
for (var i = 0; i PLATFORMS.length; i++)
ok(g_allTestsByPlatformAndBuildType[PLATFORMS[i]]);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128322] trunk/Source/WebCore
Title: [128322] trunk/Source/WebCore Revision 128322 Author pilg...@chromium.org Date 2012-09-12 09:11:28 -0700 (Wed, 12 Sep 2012) Log Message [Chromium] Remove unused allowScriptDespiteSettings function from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=96526 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * platform/chromium/PlatformSupport.h: (PlatformSupport): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/PlatformSupport.h Diff Modified: trunk/Source/WebCore/ChangeLog (128321 => 128322) --- trunk/Source/WebCore/ChangeLog 2012-09-12 16:06:55 UTC (rev 128321) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 16:11:28 UTC (rev 128322) @@ -1,3 +1,15 @@ +2012-09-12 Mark Pilgrim pilg...@chromium.org + +[Chromium] Remove unused allowScriptDespiteSettings function from PlatformSupport +https://bugs.webkit.org/show_bug.cgi?id=96526 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* platform/chromium/PlatformSupport.h: +(PlatformSupport): + 2012-09-12 Dominic Mazzoni dmazz...@google.com AX: Refactor most AccessibilityRenderObject code into AccessibilityNodeObject Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (128321 => 128322) --- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-12 16:06:55 UTC (rev 128321) +++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-12 16:11:28 UTC (rev 128322) @@ -118,7 +118,6 @@ // _javascript_ - static void notifyJSOutOfMemory(Frame*); -static bool allowScriptDespiteSettings(const KURL documentURL); // Plugin - static bool plugins(bool refresh, VectorPluginInfo*); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128323] trunk
Title: [128323] trunk
Revision 128323
Author morr...@google.com
Date 2012-09-12 09:16:14 -0700 (Wed, 12 Sep 2012)
Log Message
[Shadow DOM] Unpolished elements should reject author shadows
https://bugs.webkit.org/show_bug.cgi?id=96404
Reviewed by Dimitri Glazkov.
Source/WebCore:
Gave areAuthorShadowsAllowed() overrides for these replaced elements
which aren't author shadow ready.
No new tests. Covered by existing tests.
* html/HTMLCanvasElement.h: Did areAuthorShadowsAllowed() overrride.
* html/HTMLFieldSetElement.h: Did areAuthorShadowsAllowed() overrride.
* html/HTMLFrameElementBase.h: Did areAuthorShadowsAllowed() overrride.
* html/HTMLMediaElement.h: Did areAuthorShadowsAllowed() overrride.
* html/HTMLPlugInElement.h: Did areAuthorShadowsAllowed() overrride.
* html/HTMLSelectElement.h: Did areAuthorShadowsAllowed() overrride.
LayoutTests:
- Added setAuthorShadowDOMForAnyElementEnabled() calls to make tests works.
- UPdated shadow-disable.html to capture the disabled elements.
* fast/dom/shadow/shadow-disable-expected.txt:
* fast/dom/shadow/shadow-disable.html:
* fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html:
* fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html:
* fast/dom/shadow/shadowdom-for-media.html:
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-disable.html
trunk/LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html
trunk/LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html
trunk/LayoutTests/fast/dom/shadow/shadowdom-for-media.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.h
trunk/Source/WebCore/html/HTMLFieldSetElement.h
trunk/Source/WebCore/html/HTMLFrameElementBase.h
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLPlugInElement.h
trunk/Source/WebCore/html/HTMLSelectElement.h
Diff
Modified: trunk/LayoutTests/ChangeLog (128322 => 128323)
--- trunk/LayoutTests/ChangeLog 2012-09-12 16:11:28 UTC (rev 128322)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 16:16:14 UTC (rev 128323)
@@ -1,3 +1,20 @@
+2012-09-12 MORITA Hajime morr...@google.com
+
+[Shadow DOM] Unpolished elements should reject author shadows
+https://bugs.webkit.org/show_bug.cgi?id=96404
+
+Reviewed by Dimitri Glazkov.
+
+- Added setAuthorShadowDOMForAnyElementEnabled() calls to make tests works.
+- UPdated shadow-disable.html to capture the disabled elements.
+
+* fast/dom/shadow/shadow-disable-expected.txt:
+* fast/dom/shadow/shadow-disable.html:
+* fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html:
+* fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html:
+* fast/dom/shadow/shadowdom-for-media.html:
+* platform/chromium/TestExpectations:
+
2012-09-12 Dominic Mazzoni dmazz...@google.com
AX: Refactor most AccessibilityRenderObject code into AccessibilityNodeObject
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt (128322 => 128323)
--- trunk/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt 2012-09-12 16:11:28 UTC (rev 128322)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt 2012-09-12 16:16:14 UTC (rev 128323)
@@ -11,18 +11,18 @@
PASS new WebKitShadowRoot(element) is not null
SECTION
PASS new WebKitShadowRoot(element) is not null
-AUDIO
-PASS new WebKitShadowRoot(element) is not null
-VIDEO
-PASS new WebKitShadowRoot(element) is not null
-SELECT
-PASS new WebKitShadowRoot(element) is not null
TEXTAREA
PASS new WebKitShadowRoot(element) is not null
INPUT
PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
tref
PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
+AUDIO
+PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
+VIDEO
+PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
+SELECT
+PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-disable.html (128322 => 128323)
--- trunk/LayoutTests/fast/dom/shadow/shadow-disable.html 2012-09-12 16:11:28 UTC (rev 128322)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-disable.html 2012-09-12 16:16:14 UTC (rev 128323)
@@ -24,15 +24,15 @@
document.createElement('span'),
document.createElement('a'),
document.createElement('section'),
-document.createElement('audio'),
-document.createElement('video'),
-document.createElement('select'),
document.createElement('textarea')
];
var elementsToFail = [
document.createElement('input'),
-
[webkit-changes] [128324] trunk/Tools
Title: [128324] trunk/Tools Revision 128324 Author joc...@chromium.org Date 2012-09-12 09:25:34 -0700 (Wed, 12 Sep 2012) Log Message [chromium] remove deprecated and unused sets import from chromium_android driver https://bugs.webkit.org/show_bug.cgi?id=96485 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/chromium_android.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py Diff Modified: trunk/Tools/ChangeLog (128323 => 128324) --- trunk/Tools/ChangeLog 2012-09-12 16:16:14 UTC (rev 128323) +++ trunk/Tools/ChangeLog 2012-09-12 16:25:34 UTC (rev 128324) @@ -1,3 +1,12 @@ +2012-09-12 Jochen Eisinger joc...@chromium.org + +[chromium] remove deprecated and unused sets import from chromium_android driver +https://bugs.webkit.org/show_bug.cgi?id=96485 + +Reviewed by Dirk Pranke. + +* Scripts/webkitpy/layout_tests/port/chromium_android.py: + 2012-09-12 Zan Dobersek zandober...@gmail.com Flakiness dashboard doesn't recognize new Chromium Android test builder Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (128323 => 128324) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-12 16:16:14 UTC (rev 128323) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-12 16:25:34 UTC (rev 128324) @@ -31,7 +31,6 @@ import logging import os import re -import sets import subprocess import threading import time ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128325] trunk
Title: [128325] trunk
Revision 128325
Author commit-qu...@webkit.org
Date 2012-09-12 09:30:04 -0700 (Wed, 12 Sep 2012)
Log Message
[CSSRegions]Use RefPtr's instead of weak references on DOMNamedFlowCollection
https://bugs.webkit.org/show_bug.cgi?id=95311
Patch by Andrei Onea o...@adobe.com on 2012-09-12
Reviewed by Andreas Kling.
Source/WebCore:
Currently, DOMNamedFlowCollection holds a collection of raw pointers to WebKitNamedFlow.
This causes a crash when there is a JS instance of a NamedFlowCollection snapshot taken
before the NamedFlow is deleted, since the memory previously occupied by the NamedFlow
can be accessed. Because of this, we need to use RefPtr's for the snapshot, so that such
dangling references extend the lifetime of the NamedFlow objects.
Test: fast/regions/webkit-named-flow-collection-crash.html
* dom/DOMNamedFlowCollection.cpp:
(WebCore::DOMNamedFlowCollection::DOMNamedFlowCollection):
(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):
(WebCore):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashFunctions::hash):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashFunctions::equal):
(DOMNamedFlowCollection::DOMNamedFlowHashFunctions):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashTranslator::hash):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowHashTranslator::equal):
Create new internal ListHashSet for RefPtrWebKitNamedFlow.
* dom/DOMNamedFlowCollection.h:
(WebCore::DOMNamedFlowCollection::create):
(DOMNamedFlowCollection):
* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::createCSSOMSnapshot):
(WebCore):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::hash):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::equal):
(NamedFlowCollection::NamedFlowHashFunctions):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::hash):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::equal):
Move back the definitions for NamedFlowHashFunctions and NamedFlowHashTranslator
to the .cpp file.
* dom/NamedFlowCollection.h:
(NamedFlowCollection):
LayoutTests:
Added test for crash which occurs when there is a raw pointer to a NamedFlow
(in a NamedFlowCollection) which has been freed.
* fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
* fast/regions/webkit-named-flow-collection-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMNamedFlowCollection.cpp
trunk/Source/WebCore/dom/DOMNamedFlowCollection.h
trunk/Source/WebCore/dom/NamedFlowCollection.cpp
trunk/Source/WebCore/dom/NamedFlowCollection.h
Added Paths
trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash-expected.txt
trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (128324 => 128325)
--- trunk/LayoutTests/ChangeLog 2012-09-12 16:25:34 UTC (rev 128324)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 16:30:04 UTC (rev 128325)
@@ -1,3 +1,16 @@
+2012-09-12 Andrei Onea o...@adobe.com
+
+[CSSRegions]Use RefPtr's instead of weak references on DOMNamedFlowCollection
+https://bugs.webkit.org/show_bug.cgi?id=95311
+
+Reviewed by Andreas Kling.
+
+Added test for crash which occurs when there is a raw pointer to a NamedFlow
+(in a NamedFlowCollection) which has been freed.
+
+* fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
+* fast/regions/webkit-named-flow-collection-crash.html: Added.
+
2012-09-12 MORITA Hajime morr...@google.com
[Shadow DOM] Unpolished elements should reject author shadows
Added: trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash-expected.txt (0 => 128325)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash-expected.txt 2012-09-12 16:30:04 UTC (rev 128325)
@@ -0,0 +1,4 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS
Added: trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash.html (0 => 128325)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash.html (rev 0)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-collection-crash.html 2012-09-12 16:30:04 UTC (rev 128325)
@@ -0,0 +1,31 @@
+!doctype html
+html
+head
+style
+#content { -webkit-flow-into: flow; }
+#container { -webkit-flow-from: flow; width: 100px; height: 100px;}
+/style
+/head
+script src=""
+body
+div id=content/div
+div id=container/div
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+var namedFlowCollection = document.webkitGetNamedFlows();
+document.body.removeChild(document.getElementById(content));
+document.body.removeChild(document.getElementById(container));
+
+//
[webkit-changes] [128326] trunk
Title: [128326] trunk Revision 128326 Author commit-qu...@webkit.org Date 2012-09-12 09:38:16 -0700 (Wed, 12 Sep 2012) Log Message [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks https://bugs.webkit.org/show_bug.cgi?id=96374 Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-12 Reviewed by Kenneth Rohde Christiansen. Source/WebKit2: Add Bundle C API to reset the application cache quota for a given origin. Add new reachedApplicationCacheOriginQuota callback to WKBundlePageUIClient which is called from WebChromeClient::reachedApplicationCacheOriginQuota(). Those are needed by WebKitTestRunner to dump information about the application cache callbacks if instructed to. * Shared/APIClientTraits.cpp: (WebKit): * Shared/APIClientTraits.h: * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetApplicationCacheOriginQuota): (WKBundleResetApplicationCacheOriginQuota): * WebProcess/InjectedBundle/API/c/WKBundlePage.h: * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::resetApplicationCacheOriginQuota): (WebKit): * WebProcess/InjectedBundle/InjectedBundle.h: (InjectedBundle): * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota): (WebKit): * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: (WebKit): (InjectedBundlePageUIClient): * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): * win/WebKit2.def: * win/WebKit2CFLite.def: Tools: Implement support for dumpApplicationCacheDelegateCallbacks and disallowIncreaseForApplicationCacheQuota in WebKitTestRunner and properly dump the information expected by the tests. If the application cache quota is reached for a given security origin, WebKitTestRunner will reset the quota to its default value, unless intructed not to via disallowIncreaseForApplicationCacheQuota(). * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): (WTR): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: (InjectedBundlePage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::TestRunner): (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota): (WTR): * WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks): (TestRunner): (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota): (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks): LayoutTests: Unskip test cases that are passing now that WebKitTestRunner implements dumpApplicationCacheDelegateCallbacks and disallowIncreaseForApplicationCacheQuota. * platform/efl-wk1/TestExpectations: * platform/efl/Skipped: * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/efl-wk1/TestExpectations trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/APIClientTraits.cpp trunk/Source/WebKit2/Shared/APIClientTraits.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Diff Modified: trunk/LayoutTests/ChangeLog (128325 => 128326) --- trunk/LayoutTests/ChangeLog 2012-09-12 16:30:04 UTC (rev 128325) +++ trunk/LayoutTests/ChangeLog 2012-09-12 16:38:16 UTC (rev 128326) @@ -1,3 +1,18 @@ +2012-09-12 Christophe Dumez christophe.du...@intel.com + +[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks +https://bugs.webkit.org/show_bug.cgi?id=96374 + +Reviewed by Kenneth Rohde Christiansen. + +Unskip test cases that are passing now that WebKitTestRunner +implements dumpApplicationCacheDelegateCallbacks and +disallowIncreaseForApplicationCacheQuota. + +* platform/efl-wk1/TestExpectations: +*
[webkit-changes] [128327] trunk/Tools
Title: [128327] trunk/Tools
Revision 128327
Author commit-qu...@webkit.org
Date 2012-09-12 09:41:58 -0700 (Wed, 12 Sep 2012)
Log Message
[EFL] [WK2] Memory leaks in TestControllerEfl
https://bugs.webkit.org/show_bug.cgi?id=96525
Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.
Fix memory leaks in EFL's TestRunner code by adopting an allocation
of WKString created with WKStringCreateWithUTF8CString().
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp
Diff
Modified: trunk/Tools/ChangeLog (128326 => 128327)
--- trunk/Tools/ChangeLog 2012-09-12 16:38:16 UTC (rev 128326)
+++ trunk/Tools/ChangeLog 2012-09-12 16:41:58 UTC (rev 128327)
@@ -1,3 +1,17 @@
+2012-09-12 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com
+
+[EFL] [WK2] Memory leaks in TestControllerEfl
+https://bugs.webkit.org/show_bug.cgi?id=96525
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Fix memory leaks in EFL's TestRunner code by adopting an allocation
+of WKString created with WKStringCreateWithUTF8CString().
+
+* WebKitTestRunner/efl/TestControllerEfl.cpp:
+(WTR::TestController::initializeInjectedBundlePath):
+(WTR::TestController::initializeTestPluginDirectory):
+
2012-09-12 Christophe Dumez christophe.du...@intel.com
[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
Modified: trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp (128326 => 128327)
--- trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2012-09-12 16:38:16 UTC (rev 128326)
+++ trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2012-09-12 16:41:58 UTC (rev 128327)
@@ -85,13 +85,13 @@
void TestController::initializeInjectedBundlePath()
{
const char* bundlePath = getEnvironmentVariableOrExit(TEST_RUNNER_INJECTED_BUNDLE_FILENAME);
-m_injectedBundlePath = WKStringCreateWithUTF8CString(bundlePath);
+m_injectedBundlePath.adopt(WKStringCreateWithUTF8CString(bundlePath));
}
void TestController::initializeTestPluginDirectory()
{
const char* pluginPath = getEnvironmentVariableOrExit(TEST_RUNNER_PLUGIN_PATH);
-m_testPluginDirectory = WKStringCreateWithUTF8CString(pluginPath);
+m_testPluginDirectory.adopt(WKStringCreateWithUTF8CString(pluginPath));
}
void TestController::platformInitializeContext()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128328] trunk/Tools
Title: [128328] trunk/Tools
Revision 128328
Author hausm...@webkit.org
Date 2012-09-12 09:43:17 -0700 (Wed, 12 Sep 2012)
Log Message
Unreviewed trivial build fix for Qt/Windows
As pointed out by Kevin, we should inject the set PATH=... statement
to add the GnuWin32 directory only if that directory actually exists.
* qmake/mkspecs/features/default_post.prf:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/Tools/ChangeLog (128327 => 128328)
--- trunk/Tools/ChangeLog 2012-09-12 16:41:58 UTC (rev 128327)
+++ trunk/Tools/ChangeLog 2012-09-12 16:43:17 UTC (rev 128328)
@@ -1,3 +1,12 @@
+2012-09-12 Simon Hausmann simon.hausm...@nokia.com
+
+Unreviewed trivial build fix for Qt/Windows after bug #96358.
+
+As pointed out by Kevin, we should inject the set PATH=... statement
+to add the GnuWin32 directory only if that directory actually exists.
+
+* qmake/mkspecs/features/default_post.prf:
+
2012-09-12 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com
[EFL] [WK2] Memory leaks in TestControllerEfl
Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (128327 => 128328)
--- trunk/Tools/qmake/mkspecs/features/default_post.prf 2012-09-12 16:41:58 UTC (rev 128327)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2012-09-12 16:43:17 UTC (rev 128328)
@@ -80,9 +80,9 @@
# Qt5's top-level repository, so let's add that to the PATH if we can
# find it.
win32 {
-GNUTOOLS=$$[QT_HOST_DATA]/../gnuwin32/bin
-exists($$GNUTOOLS/gperf.exe) {
-GNUTOOLS = (set $$escape_expand(\\\)PATH=$$toSystemPath($$GNUTOOLS);%PATH%$$escape_expand(\\\))
+GNUTOOLS_DIR=$$[QT_HOST_DATA]/../gnuwin32/bin
+exists($$GNUTOOLS_DIR/gperf.exe) {
+GNUTOOLS = (set $$escape_expand(\\\)PATH=$$toSystemPath($$GNUTOOLS_DIR);%PATH%$$escape_expand(\\\))
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128329] trunk/Source/WebCore
Title: [128329] trunk/Source/WebCore
Revision 128329
Author dglaz...@chromium.org
Date 2012-09-12 09:50:33 -0700 (Wed, 12 Sep 2012)
Log Message
Remove transient state regarding uknown pseudoelements from SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=96425
Reviewed by Eric Seidel.
The fact that an unknown pseudoelement was found when checking selector was stored as extra state on SelectorChecker. That's bad,
because this state is at odds with the lifecycle of the instance and had to be explicitly reset prior to each checking. To address
this, I made checkSelector report the value as its result (by-ref parameter, actually).
No new tests, refactoring only. Covered by existing tests.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::SelectorChecker): Removed the now-unneded state initialization.
(WebCore::SelectorChecker::checkSelector): Changed to take extra parameter.
(WebCore):
(WebCore::SelectorChecker::checkOneSelector): Ditto.
* css/SelectorChecker.h:
(SelectorChecker): Changed decls accordingly.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver): Added state to StyleResolver.
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use own state, rather than StyleChecker's state.
* css/StyleResolver.h:
(StyleResolver): Moved state here from StyleChecker.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorChecker.h
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/StyleResolver.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128328 => 128329)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 16:43:17 UTC (rev 128328)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 16:50:33 UTC (rev 128329)
@@ -1,3 +1,29 @@
+2012-09-12 Dimitri Glazkov dglaz...@chromium.org
+
+Remove transient state regarding uknown pseudoelements from SelectorChecker.
+https://bugs.webkit.org/show_bug.cgi?id=96425
+
+Reviewed by Eric Seidel.
+
+The fact that an unknown pseudoelement was found when checking selector was stored as extra state on SelectorChecker. That's bad,
+because this state is at odds with the lifecycle of the instance and had to be explicitly reset prior to each checking. To address
+this, I made checkSelector report the value as its result (by-ref parameter, actually).
+
+No new tests, refactoring only. Covered by existing tests.
+
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::SelectorChecker): Removed the now-unneded state initialization.
+(WebCore::SelectorChecker::checkSelector): Changed to take extra parameter.
+(WebCore):
+(WebCore::SelectorChecker::checkOneSelector): Ditto.
+* css/SelectorChecker.h:
+(SelectorChecker): Changed decls accordingly.
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::StyleResolver): Added state to StyleResolver.
+(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use own state, rather than StyleChecker's state.
+* css/StyleResolver.h:
+(StyleResolver): Moved state here from StyleChecker.
+
2012-09-12 Andrei Onea o...@adobe.com
[CSSRegions]Use RefPtr's instead of weak references on DOMNamedFlowCollection
Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (128328 => 128329)
--- trunk/Source/WebCore/css/SelectorChecker.cpp 2012-09-12 16:43:17 UTC (rev 128328)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2012-09-12 16:50:33 UTC (rev 128329)
@@ -71,7 +71,6 @@
, m_documentIsHTML(document-isHTMLDocument())
, m_mode(ResolvingStyle)
, m_pseudoStyle(NOPSEUDO)
-, m_hasUnknownPseudoElements(false)
{
}
@@ -268,7 +267,8 @@
}
PseudoId dynamicPseudo = NOPSEUDO;
-return checkSelector(SelectorCheckingContext(sel, element, SelectorChecker::VisitedMatchDisabled), dynamicPseudo) == SelectorMatches;
+bool hasUnknownPseudoElements = false;
+return checkSelector(SelectorCheckingContext(sel, element, SelectorChecker::VisitedMatchDisabled), dynamicPseudo, hasUnknownPseudoElements) == SelectorMatches;
}
namespace {
@@ -439,10 +439,10 @@
// * SelectorFailsLocally - the selector fails for the element e
// * SelectorFailsAllSiblings - the selector fails for e and any sibling of e
// * SelectorFailsCompletely - the selector fails for e and any sibling or ancestor of e
-SelectorChecker::SelectorMatch SelectorChecker::checkSelector(const SelectorCheckingContext context, PseudoId dynamicPseudo) const
+SelectorChecker::SelectorMatch SelectorChecker::checkSelector(const SelectorCheckingContext context, PseudoId dynamicPseudo, bool hasUnknownPseudoElements) const
{
// first selector has to match
-if (!checkOneSelector(context, dynamicPseudo))
+if (!checkOneSelector(context, dynamicPseudo, hasUnknownPseudoElements))
return SelectorFailsLocally;
// The rest of the selectors has to match
@@
[webkit-changes] [128330] releases/WebKitGTK/webkit-1.10
Title: [128330] releases/WebKitGTK/webkit-1.10
Revision 128330
Author carlo...@webkit.org
Date 2012-09-12 09:51:43 -0700 (Wed, 12 Sep 2012)
Log Message
Merge r128195 - [GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=96284
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Non UTF-8 characters sent as part of a HTTP header name were
causing crashes as String::fromUTF8() was returning NULL for
them. Use String::fromUTF8WithLatin1Fallback() instead.
Test: http/tests/misc/non-utf8-header-name.php
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):
LayoutTests:
Added a new test to make sure that WebKitGtk+ does not crash when
a non-UTF8 character is sent as part of a HTTP header name.
* http/tests/misc/non-utf8-header-name-expected.txt: Added.
* http/tests/misc/non-utf8-header-name.php: Added.
Modified Paths
releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp
Added Paths
releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt
releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name.php
Diff
Modified: releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog (128329 => 128330)
--- releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog 2012-09-12 16:50:33 UTC (rev 128329)
+++ releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog 2012-09-12 16:51:43 UTC (rev 128330)
@@ -1,3 +1,16 @@
+2012-09-11 Sergio Villar Senin svil...@igalia.com
+
+[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+https://bugs.webkit.org/show_bug.cgi?id=96284
+
+Reviewed by Gustavo Noronha Silva.
+
+Added a new test to make sure that WebKitGtk+ does not crash when
+a non-UTF8 character is sent as part of a HTTP header name.
+
+* http/tests/misc/non-utf8-header-name-expected.txt: Added.
+* http/tests/misc/non-utf8-header-name.php: Added.
+
2012-09-04 Mario Sanchez Prada msanc...@igalia.com
[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
Added: releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (0 => 128330)
--- releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt 2012-09-12 16:51:43 UTC (rev 128330)
@@ -0,0 +1 @@
+Test for bug 96284: Non UTF-8 HTTP headers do not cause a crash.
Added: releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name.php (0 => 128330)
--- releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name.php (rev 0)
+++ releases/WebKitGTK/webkit-1.10/LayoutTests/http/tests/misc/non-utf8-header-name.php 2012-09-12 16:51:43 UTC (rev 128330)
@@ -0,0 +1,9 @@
+?php
+header('HTTP/1.1 200 OK');
+header('\xC3: text/html');
+echo 'script';
+echo ' if (window.testRunner)';
+echo ' testRunner.dumpAsText();';
+echo '/script';
+echo 'pTest for a href="" 96284/a: Non UTF-8 HTTP headers do not cause a crash./p';
+?
Modified: releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog (128329 => 128330)
--- releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 16:50:33 UTC (rev 128329)
+++ releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog 2012-09-12 16:51:43 UTC (rev 128330)
@@ -1,3 +1,19 @@
+2012-09-11 Sergio Villar Senin svil...@igalia.com
+
+[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+https://bugs.webkit.org/show_bug.cgi?id=96284
+
+Reviewed by Gustavo Noronha Silva.
+
+Non UTF-8 characters sent as part of a HTTP header name were
+causing crashes as String::fromUTF8() was returning NULL for
+them. Use String::fromUTF8WithLatin1Fallback() instead.
+
+Test: http/tests/misc/non-utf8-header-name.php
+
+* platform/network/soup/ResourceResponseSoup.cpp:
+(WebCore::ResourceResponse::updateFromSoupMessage):
+
2012-08-20 Philippe Normand pnorm...@igalia.com
[GStreamer] Audio device not closed after playing sound
Modified: releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (128329 => 128330)
--- releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2012-09-12 16:50:33 UTC (rev 128329)
+++ releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2012-09-12 16:51:43 UTC (rev 128330)
@@ -69,7 +69,7 @@
soup_message_headers_iter_init(headersIter, soupMessage-response_headers);
while (soup_message_headers_iter_next(headersIter, headerName, headerValue))
-
[webkit-changes] [128331] trunk/Source/WebCore
Title: [128331] trunk/Source/WebCore
Revision 128331
Author morr...@google.com
Date 2012-09-12 09:54:55 -0700 (Wed, 12 Sep 2012)
Log Message
[Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be replaced with a node flag.
https://bugs.webkit.org/show_bug.cgi?id=96450
Reviewed by Dimitri Glazkov.
This change gets rid of NodeRareData::m_numberOfScopedHTMLStyleChildren
by replacing it with a Node flag called HasScopedHTMLStyleChildFlag.
Instead of tracking the number of certain node, this chagne compute the number
when necessary.
Now we no longer need to hit rareData() for each hasScopedHTMLStyleChild() call.
Note that because such a re-counting occurs only when the scoped style elements
leave the tree, the performance impact is negligible.
No new tests. Covered by existing tests.
* dom/Node.cpp:
(WebCore):
* dom/Node.h:
(WebCore::Node::hasScopedHTMLStyleChild):
(WebCore::Node::setHasScopedHTMLStyleChild):
(Node):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::isRegisteredAsScoped):
(WebCore):
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
(WebCore::Node::numberOfScopedHTMLStyleChildren):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
* html/HTMLStyleElement.h:
(HTMLStyleElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/html/HTMLStyleElement.cpp
trunk/Source/WebCore/html/HTMLStyleElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128330 => 128331)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 16:51:43 UTC (rev 128330)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 16:54:55 UTC (rev 128331)
@@ -1,3 +1,40 @@
+2012-09-11 MORITA Hajime morr...@google.com
+
+[Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be replaced with a node flag.
+https://bugs.webkit.org/show_bug.cgi?id=96450
+
+Reviewed by Dimitri Glazkov.
+
+This change gets rid of NodeRareData::m_numberOfScopedHTMLStyleChildren
+by replacing it with a Node flag called HasScopedHTMLStyleChildFlag.
+Instead of tracking the number of certain node, this chagne compute the number
+when necessary.
+
+Now we no longer need to hit rareData() for each hasScopedHTMLStyleChild() call.
+Note that because such a re-counting occurs only when the scoped style elements
+leave the tree, the performance impact is negligible.
+
+No new tests. Covered by existing tests.
+
+* dom/Node.cpp:
+(WebCore):
+* dom/Node.h:
+(WebCore::Node::hasScopedHTMLStyleChild):
+(WebCore::Node::setHasScopedHTMLStyleChild):
+(Node):
+* dom/NodeRareData.h:
+(WebCore::NodeRareData::NodeRareData):
+(NodeRareData):
+* html/HTMLStyleElement.cpp:
+(WebCore::HTMLStyleElement::isRegisteredAsScoped):
+(WebCore):
+(WebCore::Node::registerScopedHTMLStyleChild):
+(WebCore::Node::unregisterScopedHTMLStyleChild):
+(WebCore::Node::numberOfScopedHTMLStyleChildren):
+(WebCore::HTMLStyleElement::unregisterWithScopingNode):
+* html/HTMLStyleElement.h:
+(HTMLStyleElement):
+
2012-09-12 Dimitri Glazkov dglaz...@chromium.org
Remove transient state regarding uknown pseudoelements from SelectorChecker.
Modified: trunk/Source/WebCore/dom/Node.cpp (128330 => 128331)
--- trunk/Source/WebCore/dom/Node.cpp 2012-09-12 16:51:43 UTC (rev 128330)
+++ trunk/Source/WebCore/dom/Node.cpp 2012-09-12 16:54:55 UTC (rev 128331)
@@ -2535,40 +2535,6 @@
}
#endif // ENABLE(MUTATION_OBSERVERS)
-#if ENABLE(STYLE_SCOPED)
-bool Node::hasScopedHTMLStyleChild() const
-{
-return hasRareData() rareData()-hasScopedHTMLStyleChild();
-}
-
-size_t Node::numberOfScopedHTMLStyleChildren() const
-{
-return hasRareData() ? rareData()-numberOfScopedHTMLStyleChildren() : 0;
-}
-
-void Node::registerScopedHTMLStyleChild()
-{
-ensureRareData()-registerScopedHTMLStyleChild();
-}
-
-void Node::unregisterScopedHTMLStyleChild()
-{
-ASSERT(hasRareData());
-if (hasRareData())
-rareData()-unregisterScopedHTMLStyleChild();
-}
-#else
-bool Node::hasScopedHTMLStyleChild() const
-{
-return 0;
-}
-
-size_t Node::numberOfScopedHTMLStyleChildren() const
-{
-return 0;
-}
-#endif
-
void Node::handleLocalEvents(Event* event)
{
if (!hasRareData() || !rareData()-eventTargetData())
Modified: trunk/Source/WebCore/dom/Node.h (128330 => 128331)
--- trunk/Source/WebCore/dom/Node.h 2012-09-12 16:51:43 UTC (rev 128330)
+++ trunk/Source/WebCore/dom/Node.h 2012-09-12 16:54:55 UTC (rev 128331)
@@ -349,6 +349,9 @@
void setHasAttrList() { setFlag(HasAttrListFlag); }
void clearHasAttrList() { clearFlag(HasAttrListFlag); }
+bool
[webkit-changes] [128332] trunk/Source/WebCore
Title: [128332] trunk/Source/WebCore Revision 128332 Author dmazz...@google.com Date 2012-09-12 09:57:16 -0700 (Wed, 12 Sep 2012) Log Message Assert hit in is multiSelectable() https://bugs.webkit.org/show_bug.cgi?id=96530 Reviewed by Chris Fleizach. Fix crash if element isn't a select element. This bug slipped through in a refactoring change (bug 96323). Covered by existing tests. * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::isMultiSelectable): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (128331 => 128332) --- trunk/Source/WebCore/ChangeLog 2012-09-12 16:54:55 UTC (rev 128331) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 16:57:16 UTC (rev 128332) @@ -1,3 +1,18 @@ +2012-09-12 Dominic Mazzoni dmazz...@google.com + +Assert hit in is multiSelectable() +https://bugs.webkit.org/show_bug.cgi?id=96530 + +Reviewed by Chris Fleizach. + +Fix crash if element isn't a select element. + +This bug slipped through in a refactoring change (bug 96323). +Covered by existing tests. + +* accessibility/AccessibilityNodeObject.cpp: +(WebCore::AccessibilityNodeObject::isMultiSelectable): + 2012-09-11 MORITA Hajime morr...@google.com [Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be replaced with a node flag. Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (128331 => 128332) --- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2012-09-12 16:54:55 UTC (rev 128331) +++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2012-09-12 16:57:16 UTC (rev 128332) @@ -622,7 +622,7 @@ if (equalIgnoringCase(ariaMultiSelectable, false)) return false; -return node() toHTMLSelectElement(node())-multiple(); +return node() node()-hasTagName(selectTag) toHTMLSelectElement(node())-multiple(); } bool AccessibilityNodeObject::isReadOnly() const ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128333] trunk/Tools
Title: [128333] trunk/Tools Revision 128333 Author commit-qu...@webkit.org Date 2012-09-12 10:20:04 -0700 (Wed, 12 Sep 2012) Log Message Fix Qt/Windows build with Python3 https://bugs.webkit.org/show_bug.cgi?id=96473 Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-09-12 Reviewed by Csaba Osztrogonác. In Python 3 print is a real function, so we must use parentheses around the function parameters. This is backwards compatible with Python 2. * Scripts/generate-win32-export-forwards: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/generate-win32-export-forwards Diff Modified: trunk/Tools/ChangeLog (128332 => 128333) --- trunk/Tools/ChangeLog 2012-09-12 16:57:16 UTC (rev 128332) +++ trunk/Tools/ChangeLog 2012-09-12 17:20:04 UTC (rev 128333) @@ -1,5 +1,17 @@ 2012-09-12 Simon Hausmann simon.hausm...@nokia.com +Fix Qt/Windows build with Python3 +https://bugs.webkit.org/show_bug.cgi?id=96473 + +Reviewed by Csaba Osztrogonác. + +In Python 3 print is a real function, so we must use parentheses around +the function parameters. This is backwards compatible with Python 2. + +* Scripts/generate-win32-export-forwards: + +2012-09-12 Simon Hausmann simon.hausm...@nokia.com + Unreviewed trivial build fix for Qt/Windows after bug #96358. As pointed out by Kevin, we should inject the set PATH=... statement Modified: trunk/Tools/Scripts/generate-win32-export-forwards (128332 => 128333) --- trunk/Tools/Scripts/generate-win32-export-forwards 2012-09-12 16:57:16 UTC (rev 128332) +++ trunk/Tools/Scripts/generate-win32-export-forwards 2012-09-12 17:20:04 UTC (rev 128333) @@ -45,7 +45,7 @@ if match: symbols.add(match.group(symbol)) -print Forwarding %s symbols from %s % (len(symbols), .join(libraries)) +print(Forwarding %s symbols from %s % (len(symbols), .join(libraries))) exportFile = open(outputFileName, w) for symbol in symbols: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128334] trunk
Title: [128334] trunk Revision 128334 Author commit-qu...@webkit.org Date 2012-09-12 10:23:06 -0700 (Wed, 12 Sep 2012) Log Message [CSS Shaders] Remove direct texture access via u_texture https://bugs.webkit.org/show_bug.cgi?id=93871 Patch by Max Vujovic mvujo...@adobe.com on 2012-09-12 Reviewed by Dean Jackson. Source/WebCore: Remove the author-accessible u_texture sampler, which referenced the DOM element texture. Additionally, reject shaders with author-defined sampler uniforms. When we implement texture parameters, we will allow shaders whose samplers are bound to valid textures. We must not allow OpenGL to give unbound samplers a default value of 0 because that references the DOM element texture, which should be inaccessible to the author's shader code. Test: css3/filters/custom/custom-filter-no-element-texture-access.html * platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::getValidationResultValue): Add a file-static function to easily query the integer values that ANGLE exposes about the last validation result. The new getUniforms method and the existing validateShaderSource method now both use getValidationResultValue. (WebCore): (WebCore::ANGLEWebKitBridge::validateShaderSource): Use the new getValidationResultValue function instead of ANGLE's ShGetInfo function. (WebCore::ANGLEWebKitBridge::getUniforms): Add a new public method to ANGLEWebKitBridge which gets the info about all of the uniforms in the last validated vertex shader or fragment shader. Uniform info includes name, type, and size. * platform/graphics/ANGLEWebKitBridge.h: (ANGLEShaderSymbol): (WebCore::ANGLEShaderSymbol::isSampler): Returns true if the symbol's data type is a GLSL sampler (e.g. sampler2D, samplerCube). (WebCore): (ANGLEWebKitBridge): * platform/graphics/filters/CustomFilterCompiledProgram.cpp: (WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram): Take in an additional programType constructor parameter. (WebCore::CustomFilterCompiledProgram::initializeParameterLocations): Remove the author-accessible DOM element texture sampler u_texture. Only find the location of the internal DOM element texture sampler css_u_texture if the author is using the CSS mix function. * platform/graphics/filters/CustomFilterCompiledProgram.h: * platform/graphics/filters/CustomFilterProgramInfo.h: (CustomFilterProgramInfo): (WebCore::CustomFilterProgramInfo::programType): Add the new CustomFilterProgramType enum. In CustomFilterProgramInfo, we plan to replace mixSettings.enabled with a programType. See: https://bugs.webkit.org/show_bug.cgi?id=96448 * platform/graphics/filters/CustomFilterValidatedProgram.cpp: Reject all shaders that have sampler uniforms defined. (WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram): (WebCore::CustomFilterValidatedProgram::compiledProgram): * platform/graphics/filters/FECustomFilter.cpp: (WebCore::FECustomFilter::bindProgramAndBuffers): Add an assert to verify that the DOM element texture is bound only if the author is using the CSS mix function. LayoutTests: Add tests to verify that the u_texture sampler is no longer accessible to author shader code because it was removed. These tests also verify that shaders with unbound samplers do not execute. Add tests to verify that the internal css_u_texture sampler is not accessible to author shader code. These tests check that this is true whether or not the author is using the CSS mix function and whether or not the author attempts to define css_u_texture is his or her shader. * css3/filters/custom/custom-filter-no-element-texture-access-expected.html: Added. * css3/filters/custom/custom-filter-no-element-texture-access.html: Added. * css3/filters/resources/sample-defined-css-u-texture-mix.fs: Added. * css3/filters/resources/sample-defined-css-u-texture.fs: Added. * css3/filters/resources/sample-u-texture-mix.fs: Added. * css3/filters/resources/sample-u-texture.fs: Added. * css3/filters/resources/sample-undefined-css-u-texture-mix.fs: Added. * css3/filters/resources/sample-undefined-css-u-texture.fs: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h trunk/Source/WebCore/platform/graphics/filters/CustomFilterCompiledProgram.cpp trunk/Source/WebCore/platform/graphics/filters/CustomFilterCompiledProgram.h trunk/Source/WebCore/platform/graphics/filters/CustomFilterProgramInfo.h trunk/Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp Added Paths trunk/LayoutTests/css3/filters/custom/custom-filter-no-element-texture-access-expected.html trunk/LayoutTests/css3/filters/custom/custom-filter-no-element-texture-access.html trunk/LayoutTests/css3/filters/resources/sample-defined-css-u-texture-mix.fs
[webkit-changes] [128336] trunk/LayoutTests
Title: [128336] trunk/LayoutTests
Revision 128336
Author commit-qu...@webkit.org
Date 2012-09-12 10:32:37 -0700 (Wed, 12 Sep 2012)
Log Message
[CSS Exclusions] Test incremental layout
https://bugs.webkit.org/show_bug.cgi?id=91879
Patch by Bear Travis betra...@adobe.com on 2012-09-12
Reviewed by Julien Chaffraix.
Adding tests to make sure that text and shape can be set dynamically, and that
content will still layout while respecting shape-inside.
* fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-dynamic-shape.html: Added.
* fast/exclusions/shape-inside/shape-inside-dynamic-text-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-dynamic-text.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html
trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape.html
trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-text-expected.html
trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-text.html
Diff
Modified: trunk/LayoutTests/ChangeLog (128335 => 128336)
--- trunk/LayoutTests/ChangeLog 2012-09-12 17:25:27 UTC (rev 128335)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 17:32:37 UTC (rev 128336)
@@ -1,3 +1,18 @@
+2012-09-12 Bear Travis betra...@adobe.com
+
+[CSS Exclusions] Test incremental layout
+https://bugs.webkit.org/show_bug.cgi?id=91879
+
+Reviewed by Julien Chaffraix.
+
+Adding tests to make sure that text and shape can be set dynamically, and that
+content will still layout while respecting shape-inside.
+
+* fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html: Added.
+* fast/exclusions/shape-inside/shape-inside-dynamic-shape.html: Added.
+* fast/exclusions/shape-inside/shape-inside-dynamic-text-expected.html: Added.
+* fast/exclusions/shape-inside/shape-inside-dynamic-text.html: Added.
+
2012-09-12 Max Vujovic mvujo...@adobe.com
[CSS Shaders] Remove direct texture access via u_texture
Added: trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html (0 => 128336)
--- trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html (rev 0)
+++ trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html 2012-09-12 17:32:37 UTC (rev 128336)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+head
+style
+#shape-inside {
+padding: 10px;
+width: 180px;
+height: 180px;
+position: relative;
+}
+#border {
+position: absolute;
+top: 8px;
+left: 8px;
+width: 180px;
+height: 180px;
+border: 2px solid blue;
+}
+/style
+/head
+body
+div id=shape-inside
+div id=border/div
+This text should be contained by the blue square.
+/div
+Test that setting a shape through _javascript_ causes layout using the new shape.
+/body
+/html
Added: trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape.html (0 => 128336)
--- trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape.html (rev 0)
+++ trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape.html 2012-09-12 17:32:37 UTC (rev 128336)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+html
+head
+script
+if (window.internals)
+window.internals.settings.setCSSExclusionsEnabled(true);
+window._onload_ = function() {
+var elem = document.getElementById(shape-inside);
+elem.setAttribute(style, -webkit-shape-inside: rectangle(10px, 10px, 180px, 180px););
+};
+/script
+style
+#shape-inside {
+width: 200px;
+height: 200px;
+position: relative;
+}
+#border {
+position: absolute;
+top: 8px;
+left: 8px;
+width: 180px;
+height: 180px;
+border: 2px solid blue;
+}
+/style
+/head
+body
+div id=shape-inside
+div id=border/div
+This text should be contained by the blue square.
+/div
+Test that setting a shape through _javascript_ causes layout using the new shape.
+/body
+/html
Added: trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-text-expected.html (0 => 128336)
--- trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-text-expected.html (rev 0)
+++ trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-text-expected.html 2012-09-12 17:32:37 UTC (rev 128336)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+head
+style
+#shape-inside {
+padding: 10px;
+width: 180px;
+height: 180px;
+position: relative;
+}
+#border {
+position: absolute;
+top: 8px;
+left: 8px;
+width: 180px;
[webkit-changes] [128337] trunk/Source/WebCore
Title: [128337] trunk/Source/WebCore Revision 128337 Author pilg...@chromium.org Date 2012-09-12 10:39:09 -0700 (Wed, 12 Sep 2012) Log Message [Chromium] Remove unused notifyFormStateChanged function in PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=96527 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * platform/chromium/PlatformSupport.h: (PlatformSupport): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/PlatformSupport.h Diff Modified: trunk/Source/WebCore/ChangeLog (128336 => 128337) --- trunk/Source/WebCore/ChangeLog 2012-09-12 17:32:37 UTC (rev 128336) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 17:39:09 UTC (rev 128337) @@ -1,3 +1,15 @@ +2012-09-12 Mark Pilgrim pilg...@chromium.org + +[Chromium] Remove unused notifyFormStateChanged function in PlatformSupport +https://bugs.webkit.org/show_bug.cgi?id=96527 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* platform/chromium/PlatformSupport.h: +(PlatformSupport): + 2012-09-12 Mihnea Ovidenie mih...@adobe.com [CSSRegions]Shrink RenderFlowThread size by using bit flags Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (128336 => 128337) --- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-12 17:32:37 UTC (rev 128336) +++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-12 17:39:09 UTC (rev 128337) @@ -110,9 +110,6 @@ static void getFontFamilyForCharacters(const UChar*, size_t numCharacters, const char* preferredLocale, FontFamily*); #endif -// Forms -- -static void notifyFormStateChanged(const Document*); - // IndexedDB -- static PassRefPtrIDBFactoryBackendInterface idbFactory(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128338] trunk
Title: [128338] trunk Revision 128338 Author commit-qu...@webkit.org Date 2012-09-12 10:42:23 -0700 (Wed, 12 Sep 2012) Log Message [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache https://bugs.webkit.org/show_bug.cgi?id=96496 Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-12 Reviewed by Kenneth Rohde Christiansen. Source/WebKit2: Add Bundle C API to retrieve security origins with an application cache. This is needed by WebKitTestRunner to support originsWithApplicationCache. * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleCopyOriginsWithApplicationCache): * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::originsWithApplicationCache): (WebKit): * WebProcess/InjectedBundle/InjectedBundle.h: (InjectedBundle): Tools: Add implementation for originsWithApplicationCache to WebKitTestRunner. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::stringArrayToJS): (WTR): (WTR::TestRunner::originsWithApplicationCache): * WebKitTestRunner/InjectedBundle/TestRunner.h: (TestRunner): LayoutTests: Unskip http/tests/appcache/origins-with-appcache.html now that WebKitTestRunner implements originsWithApplicationCache. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Diff Modified: trunk/LayoutTests/ChangeLog (128337 => 128338) --- trunk/LayoutTests/ChangeLog 2012-09-12 17:39:09 UTC (rev 128337) +++ trunk/LayoutTests/ChangeLog 2012-09-12 17:42:23 UTC (rev 128338) @@ -1,3 +1,15 @@ +2012-09-12 Christophe Dumez christophe.du...@intel.com + +[WK2][WKTR] TestRunner needs to implement originsWithApplicationCache +https://bugs.webkit.org/show_bug.cgi?id=96496 + +Reviewed by Kenneth Rohde Christiansen. + +Unskip http/tests/appcache/origins-with-appcache.html now that +WebKitTestRunner implements originsWithApplicationCache. + +* platform/wk2/Skipped: + 2012-09-12 Bear Travis betra...@adobe.com [CSS Exclusions] Test incremental layout Modified: trunk/LayoutTests/platform/wk2/Skipped (128337 => 128338) --- trunk/LayoutTests/platform/wk2/Skipped 2012-09-12 17:39:09 UTC (rev 128337) +++ trunk/LayoutTests/platform/wk2/Skipped 2012-09-12 17:42:23 UTC (rev 128338) @@ -202,9 +202,6 @@ fast/images/animated-gif-restored-from-bfcache.html fast/text/zero-font-size.html -# WTR needs an implementation of originsWithApplicationCache -http/tests/appcache/origins-with-appcache.html - # WebKitTestRunner needs to support layoutTestController.dumpDOMAsWebArchive # https://bugs.webkit.org/show_bug.cgi?id=42324 http/tests/webarchive/cross-origin-stylesheet-crash.html Modified: trunk/Source/WebKit2/ChangeLog (128337 => 128338) --- trunk/Source/WebKit2/ChangeLog 2012-09-12 17:39:09 UTC (rev 128337) +++ trunk/Source/WebKit2/ChangeLog 2012-09-12 17:42:23 UTC (rev 128338) @@ -1,5 +1,25 @@ 2012-09-12 Christophe Dumez christophe.du...@intel.com +[WK2][WKTR] TestRunner needs to implement originsWithApplicationCache +https://bugs.webkit.org/show_bug.cgi?id=96496 + +Reviewed by Kenneth Rohde Christiansen. + +Add Bundle C API to retrieve security origins with +an application cache. This is needed by WebKitTestRunner +to support originsWithApplicationCache. + +* WebProcess/InjectedBundle/API/c/WKBundle.cpp: +(WKBundleCopyOriginsWithApplicationCache): +* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: +* WebProcess/InjectedBundle/InjectedBundle.cpp: +(WebKit::InjectedBundle::originsWithApplicationCache): +(WebKit): +* WebProcess/InjectedBundle/InjectedBundle.h: +(InjectedBundle): + +2012-09-12 Christophe Dumez christophe.du...@intel.com + [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks https://bugs.webkit.org/show_bug.cgi?id=96374 Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (128337 => 128338) --- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-12 17:39:09 UTC (rev 128337) +++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-12 17:42:23 UTC (rev 128338) @@ -25,11 +25,12 @@ #include config.h #include WKBundle.h -#include WKBundlePrivate.h +#include ImmutableArray.h #include
[webkit-changes] [128339] trunk/Source/WTF
Title: [128339] trunk/Source/WTF
Revision 128339
Author msab...@apple.com
Date 2012-09-12 10:46:45 -0700 (Wed, 12 Sep 2012)
Log Message
Build fixed for http://trac.webkit.org/changeset/128243
Unreviewed build fix.
Change UnicodeString::extract for gcc based on ICU fix described in
http://bugs.icu-project.org/trac/ticket/8197.
* icu/unicode/unistr.h:
(UnicodeString::extract):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/icu/unicode/unistr.h
Diff
Modified: trunk/Source/WTF/ChangeLog (128338 => 128339)
--- trunk/Source/WTF/ChangeLog 2012-09-12 17:42:23 UTC (rev 128338)
+++ trunk/Source/WTF/ChangeLog 2012-09-12 17:46:45 UTC (rev 128339)
@@ -1,3 +1,15 @@
+2012-09-12 Michael Saboff msab...@apple.com
+
+Build fixed for http://trac.webkit.org/changeset/128243
+
+Unreviewed build fix.
+
+Change UnicodeString::extract for gcc based on ICU fix described in
+http://bugs.icu-project.org/trac/ticket/8197.
+
+* icu/unicode/unistr.h:
+(UnicodeString::extract):
+
2012-09-12 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI move String* instrumentation to wtf.
Modified: trunk/Source/WTF/icu/unicode/unistr.h (128338 => 128339)
--- trunk/Source/WTF/icu/unicode/unistr.h 2012-09-12 17:42:23 UTC (rev 128338)
+++ trunk/Source/WTF/icu/unicode/unistr.h 2012-09-12 17:46:45 UTC (rev 128339)
@@ -4086,15 +4086,14 @@
{
// This dstSize value will be checked explicitly
-#if defined(__GNUC__)
- // Ticket #7039: Clip length to the maximum valid length to the end of addressable memory given the starting address
- // This is only an issue when using GCC and certain optimizations are turned on.
- return extract(start, _length, dst, dst!=0 ? ((dst = (char*)((size_t)-1) - UINT32_MAX) ? (((char*)UINT32_MAX) - dst) : UINT32_MAX) : 0, codepage);
-#else
+ // Removed #if defined(__GNUC__) per ICU defect http://bugs.icu-project.org/trac/ticket/8197
return extract(start, _length, dst, dst!=0 ? 0x : 0, codepage);
-#endif
}
-
+extract(int32_t start,
+int32_t startLength,
+char *target,
+uint32_t targetLength,
+const char *codepage)
#endif
inline void
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128340] trunk/Source/WTF
Title: [128340] trunk/Source/WTF Revision 128340 Author msab...@apple.com Date 2012-09-12 11:11:16 -0700 (Wed, 12 Sep 2012) Log Message Build fixed for http://trac.webkit.org/changeset/128243 Unreviewed build fix. Removed temporarily added function signature. * icu/unicode/unistr.h: (UnicodeString::extract): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/icu/unicode/unistr.h Diff Modified: trunk/Source/WTF/ChangeLog (128339 => 128340) --- trunk/Source/WTF/ChangeLog 2012-09-12 17:46:45 UTC (rev 128339) +++ trunk/Source/WTF/ChangeLog 2012-09-12 18:11:16 UTC (rev 128340) @@ -4,6 +4,17 @@ Unreviewed build fix. +Removed temporarily added function signature. + +* icu/unicode/unistr.h: +(UnicodeString::extract): + +2012-09-12 Michael Saboff msab...@apple.com + +Build fixed for http://trac.webkit.org/changeset/128243 + +Unreviewed build fix. + Change UnicodeString::extract for gcc based on ICU fix described in http://bugs.icu-project.org/trac/ticket/8197. Modified: trunk/Source/WTF/icu/unicode/unistr.h (128339 => 128340) --- trunk/Source/WTF/icu/unicode/unistr.h 2012-09-12 17:46:45 UTC (rev 128339) +++ trunk/Source/WTF/icu/unicode/unistr.h 2012-09-12 18:11:16 UTC (rev 128340) @@ -4089,11 +4089,6 @@ // Removed #if defined(__GNUC__) per ICU defect http://bugs.icu-project.org/trac/ticket/8197 return extract(start, _length, dst, dst!=0 ? 0x : 0, codepage); } -extract(int32_t start, -int32_t startLength, -char *target, -uint32_t targetLength, -const char *codepage) #endif inline void ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128341] trunk/Source/WebCore
Title: [128341] trunk/Source/WebCore
Revision 128341
Author mifen...@rim.com
Date 2012-09-12 11:23:10 -0700 (Wed, 12 Sep 2012)
Log Message
[BlackBerry] Add custom messages for input type validation.
https://bugs.webkit.org/show_bug.cgi?id=96533
Reviewed by Antonio Gomes.
PR 179148.
Add validation messages for Email, MultipleEmail and Url.
Reviewed Internally by Nima Ghanavatian.
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::validationMessageTypeMismatchForEmailText):
(WebCore::validationMessageTypeMismatchForMultipleEmailText):
(WebCore::validationMessageTypeMismatchForURLText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (128340 => 128341)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 18:11:16 UTC (rev 128340)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 18:23:10 UTC (rev 128341)
@@ -1,3 +1,21 @@
+2012-09-12 Mike Fenton mifen...@rim.com
+
+[BlackBerry] Add custom messages for input type validation.
+https://bugs.webkit.org/show_bug.cgi?id=96533
+
+Reviewed by Antonio Gomes.
+
+PR 179148.
+
+Add validation messages for Email, MultipleEmail and Url.
+
+Reviewed Internally by Nima Ghanavatian.
+
+* platform/blackberry/LocalizedStringsBlackBerry.cpp:
+(WebCore::validationMessageTypeMismatchForEmailText):
+(WebCore::validationMessageTypeMismatchForMultipleEmailText):
+(WebCore::validationMessageTypeMismatchForURLText):
+
2012-09-12 Mark Pilgrim pilg...@chromium.org
[Chromium] Remove unused notifyFormStateChanged function in PlatformSupport
Modified: trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp (128340 => 128341)
--- trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp 2012-09-12 18:11:16 UTC (rev 128340)
+++ trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp 2012-09-12 18:23:10 UTC (rev 128341)
@@ -481,17 +481,17 @@
String validationMessageTypeMismatchForEmailText()
{
-return validationMessageTypeMismatchText();
+return String::fromUTF8(s_resource.getString(BlackBerry::Platform::VALIDATION_TYPE_MISMATCH_EMAIL));
}
String validationMessageTypeMismatchForMultipleEmailText()
{
-return validationMessageTypeMismatchText();
+return String::fromUTF8(s_resource.getString(BlackBerry::Platform::VALIDATION_TYPE_MISMATCH_MULTIPLE_EMAIL));
}
String validationMessageTypeMismatchForURLText()
{
-return validationMessageTypeMismatchText();
+return String::fromUTF8(s_resource.getString(BlackBerry::Platform::VALIDATION_TYPE_MISMATCH_URL));
}
String validationMessageValueMissingText()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128342] trunk/LayoutTests
Title: [128342] trunk/LayoutTests Revision 128342 Author zandober...@gmail.com Date 2012-09-12 11:23:44 -0700 (Wed, 12 Sep 2012) Log Message Unreviewed GTK gardening. Adding crash or other failure expectations for plenty of accessibility tests as required after r128318. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (128341 => 128342) --- trunk/LayoutTests/ChangeLog 2012-09-12 18:23:10 UTC (rev 128341) +++ trunk/LayoutTests/ChangeLog 2012-09-12 18:23:44 UTC (rev 128342) @@ -1,3 +1,12 @@ +2012-09-12 Zan Dobersek zandober...@gmail.com + +Unreviewed GTK gardening. + +Adding crash or other failure expectations for plenty of accessibility +tests as required after r128318. + +* platform/gtk/TestExpectations: + 2012-09-12 Christophe Dumez christophe.du...@intel.com [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache Modified: trunk/LayoutTests/platform/gtk/TestExpectations (128341 => 128342) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-12 18:23:10 UTC (rev 128341) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-12 18:23:44 UTC (rev 128342) @@ -469,6 +469,17 @@ BUGWK94458 DEBUG : http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html = CRASH TEXT BUGWK94458 DEBUG : fast/events/message-port-context-destroyed.html = CRASH PASS +BUGWK96534 DEBUG : accessibility/aria-checkbox-checked.html = CRASH +BUGWK96534 DEBUG : accessibility/aria-combobox.html = CRASH +BUGWK96534 DEBUG : accessibility/aria-controls-with-tabs.html = CRASH +BUGWK96534 DEBUG : accessibility/aria-disabled.html = CRASH +BUGWK96534 DEBUG : accessibility/canvas-fallback-content-2.html = CRASH +BUGWK96534 DEBUG : accessibility/canvas-accessibilitynodeobject.html = CRASH +BUGWK96534 DEBUG : accessibility/disabled-controls-not-focusable.html = CRASH +BUGWK96534 DEBUG : accessibility/removed-anonymous-block-child-causes-crash.html = CRASH +BUGWK96534 DEBUG : accessibility/table-with-empty-thead-causes-crash.html = CRASH +BUGWK96534 DEBUG : platform/gtk/accessibility/caret-browsing-text-focus.html = CRASH + // // End of Crashing tests // @@ -1261,7 +1272,7 @@ // Failing after r123379 on EFL and GTK. BUGWK92063 : fast/css/sticky/parsing-position-sticky.html = TEXT -BUGWK92100 : accessibility/canvas-accessibilitynodeobject.html = TEXT +BUGWK92100 RELEASE : accessibility/canvas-accessibilitynodeobject.html = TEXT // These tests depend on subpixel layout. BUGWK92352 : css3/flexbox/flex-rounding.html = TEXT @@ -1312,6 +1323,9 @@ BUGWK96517 : fast/events/popup-blocking-timers.html = TEXT +BUGWK96534 RELEASE : accessibility/canvas-fallback-content-2.html = TEXT +BUGWK96534 RELEASE : platform/gtk/accessibility/caret-browsing-text-focus.html = TEXT + // // End of Tests failing // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128343] trunk/Tools
Title: [128343] trunk/Tools Revision 128343 Author ad...@chromium.org Date 2012-09-12 11:24:39 -0700 (Wed, 12 Sep 2012) Log Message [chromium] Add content_browsertests to the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=96535 Reviewed by Ojan Vafai. * TestResultServer/static-dashboards/dashboard_base.js: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js Diff Modified: trunk/Tools/ChangeLog (128342 => 128343) --- trunk/Tools/ChangeLog 2012-09-12 18:23:44 UTC (rev 128342) +++ trunk/Tools/ChangeLog 2012-09-12 18:24:39 UTC (rev 128343) @@ -1,3 +1,12 @@ +2012-09-12 Adam Klein ad...@chromium.org + +[chromium] Add content_browsertests to the flakiness dashboard +https://bugs.webkit.org/show_bug.cgi?id=96535 + +Reviewed by Ojan Vafai. + +* TestResultServer/static-dashboards/dashboard_base.js: + 2012-09-12 Christophe Dumez christophe.du...@intel.com [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (128342 => 128343) --- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-09-12 18:23:44 UTC (rev 128342) +++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-09-12 18:24:39 UTC (rev 128343) @@ -119,6 +119,7 @@ 'browser_tests', 'cacheinvalidation_unittests', 'compositor_unittests', +'content_browsertests', 'content_unittests', 'courgette_unittests', 'crypto_unittests', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128344] trunk/Source
Title: [128344] trunk/Source Revision 128344 Author commit-qu...@webkit.org Date 2012-09-12 11:49:25 -0700 (Wed, 12 Sep 2012) Log Message [chromium] Evict textures through the texture manager instead of the resource provider https://bugs.webkit.org/show_bug.cgi?id=96463 Patch by Christopher Cameron ccame...@chromium.org on 2012-09-12 Reviewed by James Robinson. Source/WebCore: When deleting contents textures' resources on the impl thread, do the deletion through the CCPrioritizedTextureManager instead of the CCResourceProvider. This requires traversing the backings list on the impl thread while the main thread is running, so remove the one remaining traversal of the backings list by the main thread. This traversal happens when unlinking textures that were evicted by the impl thread, so explicitly send the list of evicted backings from the impl thread to the main thread. Unify all resource deletion paths in the CCPrioritizedTextureManager. Always perform the sequence of eviction (deleting the GL resource) and then destruction of evicted backings (deleting the objects). Also, use the same function (evictBackingsToReduceMemory) to reduce memory consumption both during commit and when done by the impl thread in response to a request by the GPU memory manager. Note that destroying only some of the resources at a time during texture eviction (as opposed all resources) is still not supported because the texture upload queues cannot be only-partially invalidated yet. Updated tests to take this behavior into account. * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::reduceContentsTexturesMemoryOnImplThread): (WebCore): (WebCore::CCLayerTreeHost::getEvictedContentTexturesBackings): (WebCore::CCLayerTreeHost::unlinkEvictedContentTexturesBackings): (WebCore::CCLayerTreeHost::deleteEvictedContentTexturesBackings): * platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::releaseContentsTextures): (WebCore::CCLayerTreeHostImpl::setContentsTexturesPurged): (WebCore): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: (CCLayerTreeHostImplClient): (CCLayerTreeHostImpl): * platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp: (WebCore::CCPrioritizedTextureManager::~CCPrioritizedTextureManager): (WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded): (WebCore::CCPrioritizedTextureManager::evictBackingsToReduceMemory): (WebCore::CCPrioritizedTextureManager::reduceMemory): (WebCore::CCPrioritizedTextureManager::clearAllMemory): (WebCore::CCPrioritizedTextureManager::reduceMemoryOnImplThread): (WebCore::CCPrioritizedTextureManager::getEvictedBackings): (WebCore::CCPrioritizedTextureManager::unlinkEvictedBackings): (WebCore): (WebCore::CCPrioritizedTextureManager::deleteEvictedBackings): (WebCore::CCPrioritizedTextureManager::evictBackingResource): * platform/graphics/chromium/cc/CCPrioritizedTextureManager.h: (CCPrioritizedTextureManager): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::releaseContentsTexturesOnImplThread): (WebCore): (WebCore::CCSingleThreadProxy::commitAndComposite): * platform/graphics/chromium/cc/CCSingleThreadProxy.h: * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::releaseContentsTexturesOnImplThread): (WebCore): (WebCore::CCThreadProxy::scheduledActionBeginFrame): (WebCore::CCThreadProxy::beginFrame): (WebCore::CCThreadProxy::beginFrameCompleteOnImplThread): (WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread): (WebCore::CCThreadProxy::recreateContextOnImplThread): * platform/graphics/chromium/cc/CCThreadProxy.h: (BeginFrameAndCommitState): (CCThreadProxy): Source/WebKit/chromium: Update layer tree host impl test to include the extra interface functions added to CCLayerTreeHostImplClient. * tests/CCLayerTreeHostImplTest.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (128343 => 128344) --- trunk/Source/WebCore/ChangeLog 2012-09-12 18:24:39 UTC (rev 128343) +++
[webkit-changes] [128345] trunk/Source/WebCore
Title: [128345] trunk/Source/WebCore
Revision 128345
Author msab...@apple.com
Date 2012-09-12 12:02:39 -0700 (Wed, 12 Sep 2012)
Log Message
Build fixed for http://trac.webkit.org/changeset/128243
Unreviewed build fix.
Change UnicodeString::extract for gcc based on ICU fix described in
http://bugs.icu-project.org/trac/ticket/8197.
* icu/unicode/unistr.h:
(UnicodeString::extract):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/icu/unicode/unistr.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128344 => 128345)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 18:49:25 UTC (rev 128344)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 19:02:39 UTC (rev 128345)
@@ -1,3 +1,15 @@
+2012-09-12 Michael Saboff msab...@apple.com
+
+Build fixed for http://trac.webkit.org/changeset/128243
+
+Unreviewed build fix.
+
+Change UnicodeString::extract for gcc based on ICU fix described in
+http://bugs.icu-project.org/trac/ticket/8197.
+
+* icu/unicode/unistr.h:
+(UnicodeString::extract):
+
2012-09-12 Christopher Cameron ccame...@chromium.org
[chromium] Evict textures through the texture manager instead of the resource provider
Modified: trunk/Source/WebCore/icu/unicode/unistr.h (128344 => 128345)
--- trunk/Source/WebCore/icu/unicode/unistr.h 2012-09-12 18:49:25 UTC (rev 128344)
+++ trunk/Source/WebCore/icu/unicode/unistr.h 2012-09-12 19:02:39 UTC (rev 128345)
@@ -4086,15 +4086,9 @@
{
// This dstSize value will be checked explicitly
-#if defined(__GNUC__)
- // Ticket #7039: Clip length to the maximum valid length to the end of addressable memory given the starting address
- // This is only an issue when using GCC and certain optimizations are turned on.
- return extract(start, _length, dst, dst!=0 ? ((dst = (char*)((size_t)-1) - UINT32_MAX) ? (((char*)UINT32_MAX) - dst) : UINT32_MAX) : 0, codepage);
-#else
+ // Removed #if defined(__GNUC__) per ICU defect http://bugs.icu-project.org/trac/ticket/8197
return extract(start, _length, dst, dst!=0 ? 0x : 0, codepage);
-#endif
}
-
#endif
inline void
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128346] trunk
Title: [128346] trunk Revision 128346 Author le...@chromium.org Date 2012-09-12 12:17:03 -0700 (Wed, 12 Sep 2012) Log Message Inline repainting can be off-by-one with sub-pixel enabled https://bugs.webkit.org/show_bug.cgi?id=95882 Reviewed by Eric Seidel. Source/WebCore: With sub-pixel layout enabled, context accumulated from containing renderers is used to properly pixel snap. Selection repaint rects are stored outside the affected renderers, and are handed to the embedder without the context to correctly determine the snapped values. This can result in repaint areas smaller than what's needed. This could be fixed three ways: - by changing selection repaint rects to an IntRect and pixel snapping the values before storing them outside the render tree. This is the narrowest solution. - by adapting layout to store pixel snapping hints along with the size/location of the renderer. This is the best possible solution, as it would help solve a lot of pixel snapping issues and reduce complexity of handling. I eventually intend on implementing this. - by reverting repaintUsingContainer to IntRects and using pixel snapping when possible, and enclosingIntRect where we lack context. This implements the last solution, as it's the least invasive, but can potentially fix numerous sub-pixel repaint issues. Test: fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloats): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollTo): (WebCore::RenderLayer::repaintIncludingNonCompositingDescendants): * rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): * rendering/RenderObject.h: (RenderObject): * rendering/RenderSelectionInfo.h: (WebCore::RenderSelectionInfo::repaint): (WebCore::RenderBlockSelectionInfo::repaint): LayoutTests: Test that we properly repaint selection gaps inside tables with sub-pixel offsets. * fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added. * fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added. * platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added. * platform/chromium/TestExpectations: * platform/mac-lion/Skipped: * platform/mac-snowleopard/Skipped: * platform/mac-wk2/Skipped: * platform/mac/Skipped: * platform/qt-4.8/Skipped: * platform/qt/Skipped: * platform/win-wk2/Skipped: * platform/win-xp/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/mac-lion/Skipped trunk/LayoutTests/platform/mac-snowleopard/Skipped trunk/LayoutTests/platform/mac-wk2/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-4.8/Skipped trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/win-wk2/Skipped trunk/LayoutTests/platform/win-xp/Skipped trunk/LayoutTests/platform/wincairo/Skipped trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderSelectionInfo.h Added Paths trunk/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt trunk/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html trunk/LayoutTests/platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (128345 => 128346) --- trunk/LayoutTests/ChangeLog 2012-09-12 19:02:39 UTC (rev 128345) +++ trunk/LayoutTests/ChangeLog 2012-09-12 19:17:03 UTC (rev 128346) @@ -1,3 +1,28 @@ +2012-09-12 Levi Weintraub le...@chromium.org + +Inline repainting can be off-by-one with sub-pixel enabled +https://bugs.webkit.org/show_bug.cgi?id=95882 + +Reviewed by Eric Seidel. + +Test that we properly repaint selection gaps inside tables with sub-pixel offsets. + +* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added. +* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added. +* platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added. +* platform/chromium/TestExpectations: +* platform/mac-lion/Skipped: +* platform/mac-snowleopard/Skipped: +* platform/mac-wk2/Skipped: +* platform/mac/Skipped: +* platform/qt-4.8/Skipped: +* platform/qt/Skipped: +*
[webkit-changes] [128347] trunk
Title: [128347] trunk Revision 128347 Author commit-qu...@webkit.org Date 2012-09-12 12:21:41 -0700 (Wed, 12 Sep 2012) Log Message Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING https://bugs.webkit.org/show_bug.cgi?id=96251 Patch by Sami Kyostila skyos...@google.com on 2012-09-12 Reviewed by Simon Fraser. Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe the feature it controls. .: * Source/cmakeconfig.h.cmake: Source/WebCore: No tests because of no change in runtime behavior. * css/CSSComputedStyleDeclaration.cpp: (WebCore): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): (WebCore::isKeywordPropertyID): (WebCore::CSSParser::parseValue): * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): * css/CSSPropertyNames.in: * css/CSSValueKeywords.in: * css/StyleResolver.cpp: (WebCore::StyleResolver::collectMatchingRulesForList): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::usesCompositedScrolling): * rendering/style/RenderStyle.h: * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): * rendering/style/StyleRareInheritedData.h: (StyleRareInheritedData): Source/WebKit/blackberry: * WebCoreSupport/AboutDataEnableFeatures.in: Source/WebKit/chromium: * features.gypi: LayoutTests: * platform/chromium/TestExpectations: Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSProperty.cpp trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/css/StyleResolver.cpp trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h trunk/Source/WebKit/blackberry/ChangeLog trunk/Source/WebKit/blackberry/WebCoreSupport/AboutDataEnableFeatures.in trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi trunk/Source/cmakeconfig.h.cmake Diff Modified: trunk/ChangeLog (128346 => 128347) --- trunk/ChangeLog 2012-09-12 19:17:03 UTC (rev 128346) +++ trunk/ChangeLog 2012-09-12 19:21:41 UTC (rev 128347) @@ -1,3 +1,15 @@ +2012-09-12 Sami Kyostila skyos...@google.com + +Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING +https://bugs.webkit.org/show_bug.cgi?id=96251 + +Reviewed by Simon Fraser. + +Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe +the feature it controls. + +* Source/cmakeconfig.h.cmake: + 2012-09-11 Ryuan Choi ryuan.c...@samsung.com [CMAKE] Supply feature defines to CodeGeneratorTestRunner. Modified: trunk/LayoutTests/ChangeLog (128346 => 128347) --- trunk/LayoutTests/ChangeLog 2012-09-12 19:17:03 UTC (rev 128346) +++ trunk/LayoutTests/ChangeLog 2012-09-12 19:21:41 UTC (rev 128347) @@ -1,3 +1,15 @@ +2012-09-12 Sami Kyostila skyos...@google.com + +Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING +https://bugs.webkit.org/show_bug.cgi?id=96251 + +Reviewed by Simon Fraser. + +Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe +the feature it controls. + +* platform/chromium/TestExpectations: + 2012-09-12 Levi Weintraub le...@chromium.org Inline repainting can be off-by-one with sub-pixel enabled Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128346 => 128347) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 19:17:03 UTC (rev 128346) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 19:21:41 UTC (rev 128347) @@ -3450,7 +3450,7 @@ BUGWK94261 DEBUG : http/tests/inspector/indexeddb/resources-panel.html = PASS CRASH TIMEOUT -// ENABLE_OVERFLOW_SCROLLING is not currently enabled in Chromium. +// ENABLE_ACCELERATED_OVERFLOW_SCROLLING is not currently enabled in Chromium. BUGWK94353 : compositing/overflow/scrolling-content-clip-to-viewport.html = TEXT BUGWK94353 : compositing/overflow/textarea-scroll-touch.html = TEXT // Failing on Linux (Content Shell) only now Modified: trunk/Source/WebCore/ChangeLog (128346 => 128347) --- trunk/Source/WebCore/ChangeLog 2012-09-12 19:17:03 UTC (rev 128346) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 19:21:41 UTC (rev 128347) @@ -1,3 +1,37 @@ +2012-09-12 Sami Kyostila skyos...@google.com + +Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING +https://bugs.webkit.org/show_bug.cgi?id=96251 + +Reviewed by Simon Fraser. + +Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
[webkit-changes] [128348] trunk
Title: [128348] trunk Revision 128348 Author commit-qu...@webkit.org Date 2012-09-12 12:23:37 -0700 (Wed, 12 Sep 2012) Log Message [chromium] Add a virtual test suite for fast/hidpi https://bugs.webkit.org/show_bug.cgi?id=90192 Patch by Alex Sakhartchouk ale...@chromium.org on 2012-09-12 Reviewed by Dirk Pranke. Tools: Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result on the hardware accelerated path as the software path. * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.virtual_test_suites): LayoutTests: Making sure the new virtual tests have matching expectations to non-gpu ones * platform/chromium/TestExpectations: * platform/chromium/virtual/gpu/fast/hidpi/README.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py Added Paths trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/ trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/README.txt Diff Modified: trunk/LayoutTests/ChangeLog (128347 => 128348) --- trunk/LayoutTests/ChangeLog 2012-09-12 19:21:41 UTC (rev 128347) +++ trunk/LayoutTests/ChangeLog 2012-09-12 19:23:37 UTC (rev 128348) @@ -1,3 +1,15 @@ +2012-09-12 Alex Sakhartchouk ale...@chromium.org + +[chromium] Add a virtual test suite for fast/hidpi +https://bugs.webkit.org/show_bug.cgi?id=90192 + +Reviewed by Dirk Pranke. + +Making sure the new virtual tests have matching expectations to non-gpu ones + +* platform/chromium/TestExpectations: +* platform/chromium/virtual/gpu/fast/hidpi/README.txt: Added. + 2012-09-12 Sami Kyostila skyos...@google.com Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128347 => 128348) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 19:21:41 UTC (rev 128347) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 19:23:37 UTC (rev 128348) @@ -2653,6 +2653,8 @@ // Swidth DRT to high DPI output mode, which temporarily breaks IMAGE BUGCR146756 LINUX WIN ANDROID MAC : fast/hidpi/broken-image-icon-hidpi.html = IMAGE BUGCR146756 LINUX WIN ANDROID MAC : fast/hidpi/broken-image-with-size-hidpi.html = IMAGE +BUGCR146756 LINUX WIN ANDROID MAC : platform/chromium/virtual/gpu/fast/hidpi/broken-image-icon-hidpi.html = IMAGE +BUGCR146756 LINUX WIN ANDROID MAC : platform/chromium/virtual/gpu/fast/hidpi/broken-image-with-size-hidpi.html = IMAGE // Flaky tests from ~r97647 BUGWK70298 MAC : fast/table/border-collapsing/cached-69296.html = IMAGE @@ -3618,6 +3620,7 @@ BUGWK95813 : fast/innerHTML/innerHTML-iframe.html = TEXT PASS BUGWK96441 WIN DEBUG : fast/hidpi/gradient-with-scaled-ancestor.html = IMAGE +BUGWK96441 : platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor.html = IMAGE BUGWK96041 LINUX : http/tests/cache/cancel-during-revalidation-succeeded.html = PASS TEXT Added: trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/README.txt (0 => 128348) --- trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/README.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/README.txt 2012-09-12 19:23:37 UTC (rev 128348) @@ -0,0 +1,2 @@ +# This suite runs the tests in LayoutTests/fast/hidpi with --force-compositing-mode +# See the virtual_test_suites() method in Tools/Scripts/webkitpy/layout_tests/port/chromium.py. Modified: trunk/Tools/ChangeLog (128347 => 128348) --- trunk/Tools/ChangeLog 2012-09-12 19:21:41 UTC (rev 128347) +++ trunk/Tools/ChangeLog 2012-09-12 19:23:37 UTC (rev 128348) @@ -1,3 +1,18 @@ +2012-09-12 Alex Sakhartchouk ale...@chromium.org + +[chromium] Add a virtual test suite for fast/hidpi +https://bugs.webkit.org/show_bug.cgi?id=90192 + +Reviewed by Dirk Pranke. + +Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result +on the hardware accelerated path as the software path. + +* DumpRenderTree/chromium/WebPreferences.cpp: +(WebPreferences::applyTo): +* Scripts/webkitpy/layout_tests/port/chromium.py: +(ChromiumPort.virtual_test_suites): + 2012-09-12 Adam Klein ad...@chromium.org [chromium] Add content_browsertests to the flakiness dashboard Modified: trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp (128347 => 128348) --- trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp 2012-09-12 19:21:41 UTC (rev 128347) +++ trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp 2012-09-12 19:23:37 UTC (rev 128348) @@ -226,6 +226,7 @@ settings-setAcceleratedPaintingEnabled(acceleratedPaintingEnabled);
[webkit-changes] [128349] trunk/Tools
Title: [128349] trunk/Tools
Revision 128349
Author commit-qu...@webkit.org
Date 2012-09-12 12:25:52 -0700 (Wed, 12 Sep 2012)
Log Message
Regression(r128338): Broke Windows build
https://bugs.webkit.org/show_bug.cgi?id=96537
Unreviewed build fix.
Fix Apple-Win build by allocating array dynamically
since its size is not constant.
Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-12
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::stringArrayToJS):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
Diff
Modified: trunk/Tools/ChangeLog (128348 => 128349)
--- trunk/Tools/ChangeLog 2012-09-12 19:23:37 UTC (rev 128348)
+++ trunk/Tools/ChangeLog 2012-09-12 19:25:52 UTC (rev 128349)
@@ -1,3 +1,16 @@
+2012-09-12 Christophe Dumez christophe.du...@intel.com
+
+Regression(r128338): Broke Windows build
+https://bugs.webkit.org/show_bug.cgi?id=96537
+
+Unreviewed build fix.
+
+Fix Apple-Win build by allocating array dynamically
+since its size is not constant.
+
+* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+(WTR::stringArrayToJS):
+
2012-09-12 Alex Sakhartchouk ale...@chromium.org
[chromium] Add a virtual test suite for fast/hidpi
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (128348 => 128349)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2012-09-12 19:23:37 UTC (rev 128348)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2012-09-12 19:25:52 UTC (rev 128349)
@@ -46,6 +46,8 @@
#include WebKit2/WebKit2_C.h
#include wtf/CurrentTime.h
#include wtf/HashMap.h
+#include wtf/OwnArrayPtr.h
+#include wtf/PassOwnArrayPtr.h
#include wtf/text/StringBuilder.h
#if ENABLE(WEB_INTENTS)
@@ -334,14 +336,14 @@
{
const size_t count = WKArrayGetSize(strings);
-JSValueRef jsStringsArray[count];
+OwnArrayPtrJSValueRef jsStringsArray = adoptArrayPtr(new JSValueRef[count]);
for (size_t i = 0; i count; ++i) {
WKStringRef stringRef = static_castWKStringRef(WKArrayGetItemAtIndex(strings, i));
JSRetainPtrJSStringRef stringJS = toJS(stringRef);
jsStringsArray[i] = JSValueMakeString(context, stringJS.get());
}
-return JSObjectMakeArray(context, count, jsStringsArray, 0);
+return JSObjectMakeArray(context, count, jsStringsArray.get(), 0);
}
JSValueRef TestRunner::originsWithApplicationCache()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128351] trunk/Source/WebKit/chromium
Title: [128351] trunk/Source/WebKit/chromium
Revision 128351
Author leandrogra...@chromium.org
Date 2012-09-12 13:02:25 -0700 (Wed, 12 Sep 2012)
Log Message
[Chromium] Fix cases where find-in-page doesn't send a final update
https://bugs.webkit.org/show_bug.cgi?id=96402
Fix some issues in the WebKit implementation that prevented to send a final
reportFindInPageMatchCount message. Also, fix a buggy reset of the active match
when calling the stopFinding method.
Reviewed by Adam Barth.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::cancelPendingScopingEffort):
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
(WebKit::WebFrameImpl::shouldScopeMatches):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128350 => 128351)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 19:41:46 UTC (rev 128350)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 20:02:25 UTC (rev 128351)
@@ -1,3 +1,20 @@
+2012-09-12 Leandro Gracia Gil leandrogra...@chromium.org
+
+[Chromium] Fix cases where find-in-page doesn't send a final update
+https://bugs.webkit.org/show_bug.cgi?id=96402
+
+Fix some issues in the WebKit implementation that prevented to send a final
+reportFindInPageMatchCount message. Also, fix a buggy reset of the active match
+when calling the stopFinding method.
+
+Reviewed by Adam Barth.
+
+* src/WebFrameImpl.cpp:
+(WebKit::WebFrameImpl::scopeStringMatches):
+(WebKit::WebFrameImpl::cancelPendingScopingEffort):
+(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
+(WebKit::WebFrameImpl::shouldScopeMatches):
+
2012-09-12 Sami Kyostila skyos...@google.com
Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (128350 => 128351)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 19:41:46 UTC (rev 128350)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 20:02:25 UTC (rev 128351)
@@ -1779,8 +1779,10 @@
const WebFindOptions options,
bool reset)
{
-if (!shouldScopeMatches(searchText))
+if (!shouldScopeMatches(searchText)) {
+increaseMatchCount(0, identifier);
return;
+}
WebFrameImpl* mainFrameImpl = viewImpl()-mainFrameImpl();
@@ -1957,6 +1959,14 @@
deleteAllValues(m_deferredScopingWork);
m_deferredScopingWork.clear();
+// Clear the active match, for two reasons:
+// We just finished the find 'session' and we don't want future (potentially
+// unrelated) find 'sessions' operations to start at the same place.
+// The WebFrameImpl could get reused and the m_activeMatch could end up pointing
+// to a document that is no longer valid. Keeping an invalid reference around
+// is just asking for trouble.
+m_activeMatch = 0;
+
m_activeMatchIndexInCurrentFrame = -1;
}
@@ -2522,14 +2532,6 @@
// a link focused, which is weird).
frame()-selection()-setSelection(m_activeMatch.get());
frame()-document()-setFocusedNode(0);
-
-// Finally clear the active match, for two reasons:
-// We just finished the find 'session' and we don't want future (potentially
-// unrelated) find 'sessions' operations to start at the same place.
-// The WebFrameImpl could get reused and the m_activeMatch could end up pointing
-// to a document that is no longer valid. Keeping an invalid reference around
-// is just asking for trouble.
-m_activeMatch = 0;
}
}
@@ -2612,9 +2614,9 @@
bool WebFrameImpl::shouldScopeMatches(const String searchText)
{
-// Don't scope if we can't find a frame or a view or if the frame is not visible.
+// Don't scope if we can't find a frame or a view.
// The user may have closed the tab/application, so abort.
-if (!frame() || !frame()-view() || !hasVisibleContent())
+if (!frame() || !frame()-view())
return false;
ASSERT(frame()-document() frame()-view());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128352] trunk/Source/WebKit2
Title: [128352] trunk/Source/WebKit2
Revision 128352
Author a...@apple.com
Date 2012-09-12 13:05:36 -0700 (Wed, 12 Sep 2012)
Log Message
rdar://problem/12275537 REGRESSION(r127384): Non-existent directories are no longer created for sandbox paths
https://bugs.webkit.org/show_bug.cgi?id=96442
Reviewed by Darin Adler.
* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
Added a function for read-write configuration directories. It matches
appendReadwriteSandboxDirectory() function behavior from WebProcessMac.mm.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Use the new function for directories that need to be created if they don't exist.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/SandboxExtension.h
trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (128351 => 128352)
--- trunk/Source/WebKit2/ChangeLog 2012-09-12 20:02:25 UTC (rev 128351)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-12 20:05:36 UTC (rev 128352)
@@ -1,3 +1,23 @@
+2012-09-11 Alexey Proskuryakov a...@apple.com
+
+rdar://problem/12275537 REGRESSION(r127384): Non-existent directories are no longer created for sandbox paths
+https://bugs.webkit.org/show_bug.cgi?id=96442
+
+Reviewed by Darin Adler.
+
+* Shared/SandboxExtension.h:
+(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
+* Shared/mac/SandboxExtensionMac.mm:
+(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
+Added a function for read-write configuration directories. It matches
+appendReadwriteSandboxDirectory() function behavior from WebProcessMac.mm.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::createNewWebProcess):
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::WebContext::platformInitializeWebProcess):
+Use the new function for directories that need to be created if they don't exist.
+
2012-09-12 Christophe Dumez christophe.du...@intel.com
[WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
Modified: trunk/Source/WebKit2/Shared/SandboxExtension.h (128351 => 128352)
--- trunk/Source/WebKit2/Shared/SandboxExtension.h 2012-09-12 20:02:25 UTC (rev 128351)
+++ trunk/Source/WebKit2/Shared/SandboxExtension.h 2012-09-12 20:05:36 UTC (rev 128352)
@@ -92,6 +92,7 @@
static PassRefPtrSandboxExtension create(const Handle);
static void createHandle(const String path, Type type, Handle);
+static void createHandleForReadWriteDirectory(const String path, Handle); // Will attempt to create the directory.
static String createHandleForTemporaryFile(const String prefix, Type type, Handle);
~SandboxExtension();
@@ -124,7 +125,8 @@
inline void SandboxExtension::HandleArray::encode(CoreIPC::ArgumentEncoder*) const { }
inline bool SandboxExtension::HandleArray::decode(CoreIPC::ArgumentDecoder*, HandleArray) { return true; }
inline PassRefPtrSandboxExtension SandboxExtension::create(const Handle) { return 0; }
-inline void SandboxExtension::createHandle(const String path, Type type, Handle) { }
+inline void SandboxExtension::createHandle(const String, Type, Handle) { }
+inline void SandboxExtension::createHandleForReadWriteDirectory(const String, Handle) { }
inline String SandboxExtension::createHandleForTemporaryFile(const String prefix, Type type, Handle) {return String();}
inline SandboxExtension::~SandboxExtension() { }
inline bool SandboxExtension::invalidate() { return true; }
Modified: trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm (128351 => 128352)
--- trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm 2012-09-12 20:02:25 UTC (rev 128351)
+++ trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm 2012-09-12 20:05:36 UTC (rev 128352)
@@ -219,7 +219,20 @@
CString standardizedPath = resolveSymlinksInPath([[(NSString *)path stringByStandardizingPath] fileSystemRepresentation]);
handle.m_sandboxExtension = WKSandboxExtensionCreate(standardizedPath.data(), wkSandboxExtensionType(type));
}
-
+
+void SandboxExtension::createHandleForReadWriteDirectory(const String path, SandboxExtension::Handle handle)
+{
+NSError *error = nil;
+NSString *nsPath = path;
+
+if (![[NSFileManager defaultManager] createDirectoryAtPath:nsPath withIntermediateDirectories:YES attributes:nil error:error]) {
+NSLog(@could not create \%@\, error %@, nsPath, error);
+return;
+}
+
+
[webkit-changes] [128354] trunk/LayoutTests
Title: [128354] trunk/LayoutTests Revision 128354 Author ad...@chromium.org Date 2012-09-12 13:33:32 -0700 (Wed, 12 Sep 2012) Log Message Unreviewed gardening. Mark some new hidpi tests as failing after r128348. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (128353 => 128354) --- trunk/LayoutTests/ChangeLog 2012-09-12 20:13:47 UTC (rev 128353) +++ trunk/LayoutTests/ChangeLog 2012-09-12 20:33:32 UTC (rev 128354) @@ -1,3 +1,11 @@ +2012-09-12 Adam Klein ad...@chromium.org + +Unreviewed gardening. + +Mark some new hidpi tests as failing after r128348. + +* platform/chromium/TestExpectations: + 2012-09-12 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r128318 and r128332. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128353 => 128354) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 20:13:47 UTC (rev 128353) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 20:33:32 UTC (rev 128354) @@ -3628,4 +3628,7 @@ BUGWK96524 WIN LINUX DEBUG : fast/filesystem/workers/detached-frame-crash.html = PASS CRASH +BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html = IMAGE +BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html = IMAGE + BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128355] trunk/LayoutTests
Title: [128355] trunk/LayoutTests Revision 128355 Author ad...@chromium.org Date 2012-09-12 13:35:34 -0700 (Wed, 12 Sep 2012) Log Message Unreviewed gardening. Mark seek-to-end-after-duration-change.html as flaky. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (128354 => 128355) --- trunk/LayoutTests/ChangeLog 2012-09-12 20:33:32 UTC (rev 128354) +++ trunk/LayoutTests/ChangeLog 2012-09-12 20:35:34 UTC (rev 128355) @@ -2,6 +2,14 @@ Unreviewed gardening. +Mark seek-to-end-after-duration-change.html as flaky. + +* platform/chromium/TestExpectations: + +2012-09-12 Adam Klein ad...@chromium.org + +Unreviewed gardening. + Mark some new hidpi tests as failing after r128348. * platform/chromium/TestExpectations: Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128354 => 128355) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 20:33:32 UTC (rev 128354) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 20:35:34 UTC (rev 128355) @@ -3631,4 +3631,6 @@ BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html = IMAGE BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html = IMAGE +BUGWK96550 : http/tests/media/media-source/seek-to-end-after-duration-change.html = PASS TIMEOUT + BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128356] trunk/LayoutTests
Title: [128356] trunk/LayoutTests Revision 128356 Author le...@chromium.org Date 2012-09-12 13:40:06 -0700 (Wed, 12 Sep 2012) Log Message Unreviewed gardening. Updated test expectations following r128346. * platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png: * platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png Property Changed trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (128355 => 128356) --- trunk/LayoutTests/ChangeLog 2012-09-12 20:35:34 UTC (rev 128355) +++ trunk/LayoutTests/ChangeLog 2012-09-12 20:40:06 UTC (rev 128356) @@ -1,3 +1,10 @@ +2012-09-12 Levi Weintraub le...@chromium.org + +Unreviewed gardening. Updated test expectations following r128346. + +* platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png: +* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: + 2012-09-12 Adam Klein ad...@chromium.org Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png ___ Modified: svn:mime-type + image/png ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128357] trunk/LayoutTests
Title: [128357] trunk/LayoutTests Revision 128357 Author ad...@chromium.org Date 2012-09-12 13:57:25 -0700 (Wed, 12 Sep 2012) Log Message Widen CRASH expectations for fast/replaced/border-radius-clip.html Unreviewed gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (128356 => 128357) --- trunk/LayoutTests/ChangeLog 2012-09-12 20:40:06 UTC (rev 128356) +++ trunk/LayoutTests/ChangeLog 2012-09-12 20:57:25 UTC (rev 128357) @@ -1,3 +1,11 @@ +2012-09-12 Adam Klein ad...@chromium.org + +Widen CRASH expectations for fast/replaced/border-radius-clip.html + +Unreviewed gardening. + +* platform/chromium/TestExpectations: + 2012-09-12 Levi Weintraub le...@chromium.org Unreviewed gardening. Updated test expectations following r128346. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128356 => 128357) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 20:40:06 UTC (rev 128356) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 20:57:25 UTC (rev 128357) @@ -2403,8 +2403,7 @@ BUGWK60097 DEBUG : fast/dom/HTMLLinkElement/link-and-subresource-test.html = PASS TEXT // Looks like some uninitialized memory at the bottom. -BUGWK60103 LINUX ANDROID DEBUG : fast/replaced/border-radius-clip.html = IMAGE CRASH -BUGWK60103 LINUX ANDROID RELEASE : fast/replaced/border-radius-clip.html = IMAGE +BUGWK60103 LINUX ANDROID : fast/replaced/border-radius-clip.html = IMAGE CRASH BUGWK60103 WIN : fast/replaced/border-radius-clip.html = IMAGE BUGWK60103 MAC : fast/replaced/border-radius-clip.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128358] trunk/Source/WebKit/chromium
Title: [128358] trunk/Source/WebKit/chromium
Revision 128358
Author e...@google.com
Date 2012-09-12 14:04:13 -0700 (Wed, 12 Sep 2012)
Log Message
[chromium] Fix search tickmarks not disappearing when compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=96536
Reviewed by James Robinson.
view-invalidateRect() on the root frame just invalidates the
contents, since WebViewImpl doesn't know anything about scrollbar
layers. This causes an InvalidateAll to not actually invalidate the
scrollbars.
To fix this, make WebFrameImpl explicitly invalidate the
scrollbars when required.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::invalidateArea):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128357 => 128358)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 20:57:25 UTC (rev 128357)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 21:04:13 UTC (rev 128358)
@@ -1,3 +1,21 @@
+2012-09-12 Adrienne Walker e...@google.com
+
+[chromium] Fix search tickmarks not disappearing when compositing is enabled
+https://bugs.webkit.org/show_bug.cgi?id=96536
+
+Reviewed by James Robinson.
+
+view-invalidateRect() on the root frame just invalidates the
+contents, since WebViewImpl doesn't know anything about scrollbar
+layers. This causes an InvalidateAll to not actually invalidate the
+scrollbars.
+
+To fix this, make WebFrameImpl explicitly invalidate the
+scrollbars when required.
+
+* src/WebFrameImpl.cpp:
+(WebKit::WebFrameImpl::invalidateArea):
+
2012-09-12 Leandro Gracia Gil leandrogra...@chromium.org
[Chromium] Fix cases where find-in-page doesn't send a final update
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (128357 => 128358)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 20:57:25 UTC (rev 128357)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 21:04:13 UTC (rev 128358)
@@ -2573,13 +2573,13 @@
contentArea.move(-frameRect.x(), -frameRect.y());
view-invalidateRect(contentArea);
}
+}
-if ((area InvalidateScrollbar) == InvalidateScrollbar) {
-// Invalidate the vertical scroll bar region for the view.
-Scrollbar* scrollbar = view-verticalScrollbar();
-if (scrollbar)
-scrollbar-invalidate();
-}
+if ((area InvalidateScrollbar) == InvalidateScrollbar) {
+// Invalidate the vertical scroll bar region for the view.
+Scrollbar* scrollbar = view-verticalScrollbar();
+if (scrollbar)
+scrollbar-invalidate();
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128359] trunk/LayoutTests
Title: [128359] trunk/LayoutTests Revision 128359 Author e...@webkit.org Date 2012-09-12 14:21:06 -0700 (Wed, 12 Sep 2012) Log Message Sync html5lib tests with latest sources (and sort the tests alphabetically in runner.html) https://bugs.webkit.org/show_bug.cgi?id=96544 Reviewed by Adam Barth. * html5lib/resources/adoption01.dat: * html5lib/resources/domjs-unsafe.dat: Added. * html5lib/resources/scripted/ark.dat: Added. * html5lib/runner.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/html5lib/resources/adoption01.dat trunk/LayoutTests/html5lib/runner-expected.txt trunk/LayoutTests/html5lib/runner.html Added Paths trunk/LayoutTests/html5lib/resources/domjs-unsafe.dat trunk/LayoutTests/html5lib/resources/scripted/ark.dat Diff Modified: trunk/LayoutTests/ChangeLog (128358 => 128359) --- trunk/LayoutTests/ChangeLog 2012-09-12 21:04:13 UTC (rev 128358) +++ trunk/LayoutTests/ChangeLog 2012-09-12 21:21:06 UTC (rev 128359) @@ -1,3 +1,15 @@ +2012-09-12 Eric Seidel e...@webkit.org + +Sync html5lib tests with latest sources (and sort the tests alphabetically in runner.html) +https://bugs.webkit.org/show_bug.cgi?id=96544 + +Reviewed by Adam Barth. + +* html5lib/resources/adoption01.dat: +* html5lib/resources/domjs-unsafe.dat: Added. +* html5lib/resources/scripted/ark.dat: Added. +* html5lib/runner.html: + 2012-09-12 Adam Klein ad...@chromium.org Widen CRASH expectations for fast/replaced/border-radius-clip.html Modified: trunk/LayoutTests/html5lib/resources/adoption01.dat (128358 => 128359) --- trunk/LayoutTests/html5lib/resources/adoption01.dat 2012-09-12 21:04:13 UTC (rev 128358) +++ trunk/LayoutTests/html5lib/resources/adoption01.dat 2012-09-12 21:21:06 UTC (rev 128359) @@ -192,3 +192,84 @@ | svg svg | svg tr | svg input + +#data +divabdivdivdivdivdivdivdivdivdivdiv/a +#errors +#document +| html +| head +| body +| div +| a +| b +| b +| div +| a +| div +| a +| div +| a +| div +| a +| div +| a +| div +| a +| div +| a +| div +| a +| div +| div + +#data +divabuicodediv/a +#errors +#document +| html +| head +| body +| div +| a +| b +| u +| i +| code +| u +| i +| code +| div +| a + +#data +x/b/b/b/by +#errors +#document +| html +| head +| body +| b +| b +| b +| b +| x +| y + +#data +ppx +#errors +#document +| html +| head +| body +| p +| b +| b +| b +| b +| p +| b +| b +| b +| x Added: trunk/LayoutTests/html5lib/resources/domjs-unsafe.dat (0 => 128359) --- trunk/LayoutTests/html5lib/resources/domjs-unsafe.dat (rev 0) +++ trunk/LayoutTests/html5lib/resources/domjs-unsafe.dat 2012-09-12 21:21:06 UTC (rev 128359) @@ -0,0 +1,503 @@ +#data +svg![CDATA[foo +bar]] +#errors +#document +| html +| head +| body +| svg svg +| foo +bar + +#data +svg![CDATA[foo +bar]] +#errors +#document +| html +| head +| body +| svg svg +| foo +bar + +#data +svg![CDATA[foo +bar]] +#errors +#document +| html +| head +| body +| svg svg +| foo +bar + +#data +scripta=' '/script +#errors +#document +| html +| head +| script +| a='�' +| body + +#data +script type=data!-- /script +#errors +#document +| html +| head +| script +| type=data +| !--� +| body + +#data +script type=data!--foo /script +#errors +#document +| html +| head +| script +| type=data +| !--foo� +| body + +#data +script type=data!-- foo- /script +#errors +#document +| html +| head +| script +| type=data +| !-- foo-� +| body + +#data +script type=data!-- foo-- /script +#errors +#document +| html +| head +| script +| type=data +| !-- foo--� +| body + +#data +script type=data!-- foo- +#errors +#document +| html +| head +| script +| type=data +| !-- foo- +| body + +#data +script type=data!-- foo-/script +#errors +#document +| html +| head +| script +| type=data +| !-- foo- +| body + +#data +script type=data!-- foo-S +#errors +#document +| html +| head +| script +| type=data +| !-- foo-S +| body + +#data +script type=data!-- foo-/SCRIPT +#errors +#document +| html +| head +| script +| type=data +| !-- foo- +| body + +#data +script type=data!--p/script +#errors +#document +| html +| head +| script +| type=data +| !--p +|
[webkit-changes] [128360] trunk/LayoutTests
Title: [128360] trunk/LayoutTests Revision 128360 Author le...@chromium.org Date 2012-09-12 14:33:54 -0700 (Wed, 12 Sep 2012) Log Message More unreviewed gardening after r128346. * platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png: * platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png trunk/LayoutTests/platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (128359 => 128360) --- trunk/LayoutTests/ChangeLog 2012-09-12 21:21:06 UTC (rev 128359) +++ trunk/LayoutTests/ChangeLog 2012-09-12 21:33:54 UTC (rev 128360) @@ -1,3 +1,10 @@ +2012-09-12 Levi Weintraub le...@chromium.org + +More unreviewed gardening after r128346. + +* platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png: +* platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: + 2012-09-12 Eric Seidel e...@webkit.org Sync html5lib tests with latest sources (and sort the tests alphabetically in runner.html) Modified: trunk/LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128361] trunk/Source/WebCore
Title: [128361] trunk/Source/WebCore
Revision 128361
Author commit-qu...@webkit.org
Date 2012-09-12 14:36:48 -0700 (Wed, 12 Sep 2012)
Log Message
[V8] V8DOMWrapper::constructorForType is unnecessary now that we can get V8PerContextData from the v8::Context
https://bugs.webkit.org/show_bug.cgi?id=96556
Patch by Adam Barth aba...@chromium.org on 2012-09-12
Reviewed by Eric Seidel.
These functions no longer serve a purpose now that we can get the
V8PerContextData directly from the context. Previously we had to find
the Frame in order to find the per-context data.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorGetter):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
* bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::from):
* bindings/v8/V8PerContextData.h:
(V8PerContextData):
- Changed this function to accept an arbitrary context rather than
requiring the caller to use the current context.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h
trunk/Source/WebCore/bindings/v8/V8PerContextData.cpp
trunk/Source/WebCore/bindings/v8/V8PerContextData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128360 => 128361)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 21:33:54 UTC (rev 128360)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 21:36:48 UTC (rev 128361)
@@ -1,3 +1,29 @@
+2012-09-12 Adam Barth aba...@chromium.org
+
+[V8] V8DOMWrapper::constructorForType is unnecessary now that we can get V8PerContextData from the v8::Context
+https://bugs.webkit.org/show_bug.cgi?id=96556
+
+Reviewed by Eric Seidel.
+
+These functions no longer serve a purpose now that we can get the
+V8PerContextData directly from the context. Previously we had to find
+the Frame in order to find the per-context data.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateConstructorGetter):
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::installDOMWindow):
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::instantiateV8Object):
+* bindings/v8/V8DOMWrapper.h:
+(V8DOMWrapper):
+* bindings/v8/V8PerContextData.cpp:
+(WebCore::V8PerContextData::from):
+* bindings/v8/V8PerContextData.h:
+(V8PerContextData):
+- Changed this function to accept an arbitrary context rather than
+ requiring the caller to use the current context.
+
2012-09-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r128318 and r128332.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (128360 => 128361)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-09-12 21:33:54 UTC (rev 128360)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-09-12 21:36:48 UTC (rev 128361)
@@ -804,25 +804,10 @@
INC_STATS(\DOM.$implClassName.constructors._get\);
v8::Handlev8::Value data = ""
ASSERT(data-IsExternal() || data-IsNumber());
-WrapperTypeInfo* type = WrapperTypeInfo::unwrap(data);
-END
-
-if ($implClassName eq DOMWindow) {
-push(@implContentDecls, END);
-// Get the proxy corresponding to the DOMWindow if possible to
-// make sure that the constructor function is constructed in the
-// context of the DOMWindow and not in the context of the caller.
-return V8DOMWrapper::constructorForType(type, V8DOMWindow::toNative(info.Holder()));
-END
-} elsif ($dataNode-extendedAttributes-{IsWorkerContext}) {
-push(@implContentDecls, END);
-return V8DOMWrapper::constructorForType(type, V8WorkerContext::toNative(info.Holder()));
-END
-} else {
-push(@implContentDecls, return v8Undefined(););
-}
-
-push(@implContentDecls, END);
+V8PerContextData* perContextData = V8PerContextData::from(info.Holder()-CreationContext());
+if (!perContextData)
+return v8Undefined();
+return perContextData-constructorForType(WrapperTypeInfo::unwrap(data));
}
END
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (128360 => 128361)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-09-12 21:33:54 UTC (rev 128360)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-09-12 21:36:48 UTC (rev 128361)
@@ -1039,8 +1039,11 @@
INC_STATS(DOM.TestObj.constructors._get);
v8::Handlev8::Value data = ""
ASSERT(data-IsExternal() || data-IsNumber());
-WrapperTypeInfo* type = WrapperTypeInfo::unwrap(data);
-return v8Undefined();}
[webkit-changes] [128362] trunk/Tools
Title: [128362] trunk/Tools
Revision 128362
Author dpra...@chromium.org
Date 2012-09-12 14:37:35 -0700 (Wed, 12 Sep 2012)
Log Message
webkitdirs: fix uname version handling for cygwin
https://bugs.webkit.org/show_bug.cgi?id=96436
Reviewed by Jon Honeycutt.
Newer versions of cygwin embed an additional version string
inside parentheses, so you get 1.7.16(0.249/5/3) instead of 1.7.16.
Update the code to handle that.
* Scripts/webkitdirs.pm:
(setupAppleWinEnv):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (128361 => 128362)
--- trunk/Tools/ChangeLog 2012-09-12 21:36:48 UTC (rev 128361)
+++ trunk/Tools/ChangeLog 2012-09-12 21:37:35 UTC (rev 128362)
@@ -1,3 +1,17 @@
+2012-09-12 Dirk Pranke dpra...@chromium.org
+
+webkitdirs: fix uname version handling for cygwin
+https://bugs.webkit.org/show_bug.cgi?id=96436
+
+Reviewed by Jon Honeycutt.
+
+Newer versions of cygwin embed an additional version string
+inside parentheses, so you get 1.7.16(0.249/5/3) instead of 1.7.16.
+Update the code to handle that.
+
+* Scripts/webkitdirs.pm:
+(setupAppleWinEnv):
+
2012-09-12 Christophe Dumez christophe.du...@intel.com
Regression(r128338): Broke Windows build
Modified: trunk/Tools/Scripts/webkitdirs.pm (128361 => 128362)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-09-12 21:36:48 UTC (rev 128361)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-09-12 21:37:35 UTC (rev 128362)
@@ -1600,9 +1600,9 @@
# FIXME: We should remove this explicit version check for cygwin once we stop supporting Cygwin 1.7.9 or older versions.
# https://bugs.webkit.org/show_bug.cgi?id=85791
-my $currentCygwinVersion = version-parse(`uname -r`);
-my $firstCygwinVersionWithoutTTYSupport = version-parse(1.7.10);
-if ($currentCygwinVersion $firstCygwinVersionWithoutTTYSupport) {
+my $uname_version = (POSIX::uname())[2];
+$uname_version =~ s/\(.*\)//; # Remove the trailing cygwin version, if any.
+if (version-parse($uname_version) version-parse(1.7.10)) {
# Setting the environment variable 'CYGWIN' to 'tty' makes cygwin enable extra support (i.e., termios)
# for UNIX-like ttys in the Windows console
$variablesToSet{CYGWIN} = tty unless $ENV{CYGWIN};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128363] trunk/Source
Title: [128363] trunk/Source
Revision 128363
Author msab...@apple.com
Date 2012-09-12 14:40:26 -0700 (Wed, 12 Sep 2012)
Log Message
Element::classAttributeChanged should use characters8/16 to find first non-whitespace
https://bugs.webkit.org/show_bug.cgi?id=96446
Reviewed by Benjamin Poulain.
Source/WebCore:
Made two new static templated methods to handle 8 or 16 bit class names.
No functional change, so no new tests.
* dom/Element.cpp:
(WebCore::classStringHasClassName):
(WebCore::Element::classAttributeChanged):
Source/WTF:
Added bit size related string accessors to AtomicString to support change.
* wtf/text/AtomicString.h:
(AtomicString):
(WTF::AtomicString::is8Bit):
(WTF::AtomicString::characters8):
(WTF::AtomicString::characters16):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (128362 => 128363)
--- trunk/Source/WTF/ChangeLog 2012-09-12 21:37:35 UTC (rev 128362)
+++ trunk/Source/WTF/ChangeLog 2012-09-12 21:40:26 UTC (rev 128363)
@@ -1,3 +1,18 @@
+2012-09-11 Michael Saboff msab...@apple.com
+
+Element::classAttributeChanged should use characters8/16 to find first non-whitespace
+https://bugs.webkit.org/show_bug.cgi?id=96446
+
+Reviewed by Benjamin Poulain.
+
+Added bit size related string accessors to AtomicString to support change.
+
+* wtf/text/AtomicString.h:
+(AtomicString):
+(WTF::AtomicString::is8Bit):
+(WTF::AtomicString::characters8):
+(WTF::AtomicString::characters16):
+
2012-09-12 Michael Saboff msab...@apple.com
Build fixed for http://trac.webkit.org/changeset/128243
Modified: trunk/Source/WTF/wtf/text/AtomicString.h (128362 => 128363)
--- trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 21:37:35 UTC (rev 128362)
+++ trunk/Source/WTF/wtf/text/AtomicString.h 2012-09-12 21:40:26 UTC (rev 128363)
@@ -86,8 +86,11 @@
const String string() const { return m_string; };
AtomicStringImpl* impl() const { return static_castAtomicStringImpl *(m_string.impl()); }
-
+
+bool is8Bit() const { return m_string.is8Bit(); }
const UChar* characters() const { return m_string.characters(); }
+const LChar* characters8() const { return m_string.characters8(); }
+const UChar* characters16() const { return m_string.characters16(); }
unsigned length() const { return m_string.length(); }
UChar operator[](unsigned int i) const { return m_string[i]; }
Modified: trunk/Source/WebCore/ChangeLog (128362 => 128363)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 21:37:35 UTC (rev 128362)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 21:40:26 UTC (rev 128363)
@@ -1,3 +1,18 @@
+2012-09-12 Michael Saboff msab...@apple.com
+
+Element::classAttributeChanged should use characters8/16 to find first non-whitespace
+https://bugs.webkit.org/show_bug.cgi?id=96446
+
+Reviewed by Benjamin Poulain.
+
+Made two new static templated methods to handle 8 or 16 bit class names.
+
+No functional change, so no new tests.
+
+* dom/Element.cpp:
+(WebCore::classStringHasClassName):
+(WebCore::Element::classAttributeChanged):
+
2012-09-12 Adam Barth aba...@chromium.org
[V8] V8DOMWrapper::constructorForType is unnecessary now that we can get V8PerContextData from the v8::Context
Modified: trunk/Source/WebCore/dom/Element.cpp (128362 => 128363)
--- trunk/Source/WebCore/dom/Element.cpp 2012-09-12 21:37:35 UTC (rev 128362)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-09-12 21:40:26 UTC (rev 128363)
@@ -755,17 +755,36 @@
classAttributeChanged(attribute.value());
}
-void Element::classAttributeChanged(const AtomicString newClassString)
+template typename CharacterType
+static inline bool classStringHasClassName(const CharacterType* characters, unsigned length)
{
-const UChar* characters = newClassString.characters();
-unsigned length = newClassString.length();
-unsigned i;
-for (i = 0; i length; ++i) {
+ASSERT(length 0);
+
+unsigned i = 0;
+do {
if (isNotHTMLSpace(characters[i]))
break;
-}
-bool hasClass = i length;
-if (hasClass) {
+++i;
+} while (i length);
+
+return i length;
+}
+
+static inline bool classStringHasClassName(const AtomicString newClassString)
+{
+unsigned length = newClassString.length();
+
+if (!length)
+return false;
+
+if (newClassString.is8Bit())
+return classStringHasClassName(newClassString.characters8(), length);
+return classStringHasClassName(newClassString.characters16(), length);
+}
+
+void Element::classAttributeChanged(const AtomicString newClassString)
+{
+if (classStringHasClassName(newClassString)) {
const bool shouldFoldCase = document()-inQuirksMode();
[webkit-changes] [128364] trunk/Tools
Title: [128364] trunk/Tools Revision 128364 Author kenn...@webkit.org Date 2012-09-12 14:49:09 -0700 (Wed, 12 Sep 2012) Log Message Respect WEBKITOUTPUTDIR when running EFL tests https://bugs.webkit.org/show_bug.cgi?id=96528 Reviewed by Dirk Pranke. Expose user set WEBKITOUTPUTDIR to the web process. * Scripts/webkitpy/layout_tests/port/driver.py: (Driver._start): Add WEBKITOUTPUTDIR to the environment of the web process and its potential jhbuild wrapper. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py Diff Modified: trunk/Tools/ChangeLog (128363 => 128364) --- trunk/Tools/ChangeLog 2012-09-12 21:40:26 UTC (rev 128363) +++ trunk/Tools/ChangeLog 2012-09-12 21:49:09 UTC (rev 128364) @@ -1,3 +1,16 @@ +2012-09-12 Kenneth Rohde Christiansen kenn...@webkit.org + +Respect WEBKITOUTPUTDIR when running EFL tests +https://bugs.webkit.org/show_bug.cgi?id=96528 + +Reviewed by Dirk Pranke. + +Expose user set WEBKITOUTPUTDIR to the web process. + +* Scripts/webkitpy/layout_tests/port/driver.py: +(Driver._start): Add WEBKITOUTPUTDIR to the environment +of the web process and its potential jhbuild wrapper. + 2012-09-12 Dirk Pranke dpra...@chromium.org webkitdirs: fix uname version handling for cygwin Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (128363 => 128364) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-09-12 21:40:26 UTC (rev 128363) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-09-12 21:49:09 UTC (rev 128364) @@ -33,6 +33,7 @@ import shlex import sys import time +import os from webkitpy.common.system import path @@ -276,6 +277,8 @@ # FIXME: We're assuming that WebKitTestRunner checks this DumpRenderTree-named environment variable. environment['DUMPRENDERTREE_TEMP'] = str(self._driver_tempdir) environment['LOCAL_RESOURCE_ROOT'] = self._port.layout_tests_dir() +if 'WEBKITOUTPUTDIR' in os.environ: +environment['WEBKITOUTPUTDIR'] = os.environ['WEBKITOUTPUTDIR'] self._crashed_process_name = None self._crashed_pid = None self._server_process = self._port._server_process_constructor(self._port, server_name, self.cmd_line(pixel_tests, per_test_args), environment) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128365] trunk/LayoutTests
Title: [128365] trunk/LayoutTests Revision 128365 Author sle...@apple.com Date 2012-09-12 14:58:48 -0700 (Wed, 12 Sep 2012) Log Message fast/events/dispatch-message-string-data.html fails on mac wk2 https://bugs.webkit.org/show_bug.cgi?id=96552 Unreviewed. Add to TestExpectations. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (128364 => 128365) --- trunk/LayoutTests/ChangeLog 2012-09-12 21:49:09 UTC (rev 128364) +++ trunk/LayoutTests/ChangeLog 2012-09-12 21:58:48 UTC (rev 128365) @@ -1,3 +1,14 @@ +2012-09-12 Stephanie Lewis sle...@apple.com + +fast/events/dispatch-message-string-data.html fails on mac wk2 +https://bugs.webkit.org/show_bug.cgi?id=96552 + +Unreviewed. + +Add to TestExpectations. + +* platform/mac-wk2/TestExpectations: + 2012-09-12 Levi Weintraub le...@chromium.org More unreviewed gardening after r128346. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (128364 => 128365) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-09-12 21:49:09 UTC (rev 128364) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2012-09-12 21:58:48 UTC (rev 128365) @@ -4,3 +4,5 @@ // All spatial navigation tests fail on Mac WK2 BUGWK96438 SKIP : fast/spatial-navigation = PASS +BUGWK96652 : fast/events/dispatch-message-string-data.html = TEXT + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128366] trunk/LayoutTests
Title: [128366] trunk/LayoutTests Revision 128366 Author o...@chromium.org Date 2012-09-12 15:12:25 -0700 (Wed, 12 Sep 2012) Log Message Update some stale expectations. * platform/chromium/TestExpectations: Update to match what the bots are actually seeing. * platform/gtk/TestExpectations: Remove tests that no longer exist. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (128365 => 128366) --- trunk/LayoutTests/ChangeLog 2012-09-12 21:58:48 UTC (rev 128365) +++ trunk/LayoutTests/ChangeLog 2012-09-12 22:12:25 UTC (rev 128366) @@ -1,3 +1,11 @@ +2012-09-12 Ojan Vafai o...@chromium.org + +Update some stale expectations. +* platform/chromium/TestExpectations: +Update to match what the bots are actually seeing. +* platform/gtk/TestExpectations: +Remove tests that no longer exist. + 2012-09-12 Stephanie Lewis sle...@apple.com fast/events/dispatch-message-string-data.html fails on mac wk2 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128365 => 128366) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 21:58:48 UTC (rev 128365) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-12 22:12:25 UTC (rev 128366) @@ -2072,8 +2072,6 @@ // Vertical text needs to be implemented in platforms other than OS X. BUGCR65877 ANDROID : fast/writing-mode/border-vertical-lr.html = IMAGE+TEXT -BUGCR65877 LINUX ANDROID MAC : fast/writing-mode/japanese-lr-selection.html = IMAGE+TEXT IMAGE -BUGCR65877 LINUX ANDROID MAC : fast/writing-mode/japanese-rl-selection.html = IMAGE+TEXT IMAGE BUGCR65877 : fast/writing-mode/japanese-ruby-vertical-lr.html = PASS IMAGE+TEXT BUGCR65877 : fast/writing-mode/japanese-ruby-vertical-rl.html = PASS IMAGE+TEXT BUGCR65877 LINUX ANDROID : fast/writing-mode/japanese-ruby-horizontal-bt.html = PASS IMAGE+TEXT @@ -2083,7 +2081,7 @@ BUGCR65877 ANDROID : fast/writing-mode/Kusa-Makura-background-canvas.html = IMAGE+TEXT BUGCR65877 WIN : fast/text/international/text-combine-image-test.html = IMAGE+TEXT BUGWK53451 LINUX ANDROID : fast/text/international/text-combine-image-test.html = IMAGE+TEXT -BUGWK94410 LINUX ANDROID WIN : fast/writing-mode/vertical-baseline-alignment.html = IMAGE +BUGWK94410 WIN : fast/writing-mode/vertical-baseline-alignment.html = IMAGE // New test, introduced by http://trac.webkit.org/changeset/70813 with only platform/mac baselines. BUGWK61161 LINUX ANDROID WIN : fast/writing-mode/border-image-horizontal-bt.html = IMAGE+TEXT Modified: trunk/LayoutTests/platform/gtk/TestExpectations (128365 => 128366) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-12 21:58:48 UTC (rev 128365) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-12 22:12:25 UTC (rev 128366) @@ -473,7 +473,6 @@ BUGWK96534 DEBUG : accessibility/aria-combobox.html = CRASH BUGWK96534 DEBUG : accessibility/aria-controls-with-tabs.html = CRASH BUGWK96534 DEBUG : accessibility/aria-disabled.html = CRASH -BUGWK96534 DEBUG : accessibility/canvas-fallback-content-2.html = CRASH BUGWK96534 DEBUG : accessibility/canvas-accessibilitynodeobject.html = CRASH BUGWK96534 DEBUG : accessibility/disabled-controls-not-focusable.html = CRASH BUGWK96534 DEBUG : accessibility/removed-anonymous-block-child-causes-crash.html = CRASH @@ -1323,7 +1322,6 @@ BUGWK96517 : fast/events/popup-blocking-timers.html = TEXT -BUGWK96534 RELEASE : accessibility/canvas-fallback-content-2.html = TEXT BUGWK96534 RELEASE : platform/gtk/accessibility/caret-browsing-text-focus.html = TEXT // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128367] trunk/Tools
Title: [128367] trunk/Tools
Revision 128367
Author commit-qu...@webkit.org
Date 2012-09-12 15:13:44 -0700 (Wed, 12 Sep 2012)
Log Message
[GTK] We attempt to rebase documentation even if it's not present
https://bugs.webkit.org/show_bug.cgi?id=96553
Patch by Xan Lopez xlo...@igalia.com on 2012-09-12
Reviewed by Martin Robinson.
Do not make the documentation rebase step fatal. This allows make
install to succeed when there's no documentation generated.
* gtk/generate-gtkdoc:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/gtk/generate-gtkdoc
Diff
Modified: trunk/Tools/ChangeLog (128366 => 128367)
--- trunk/Tools/ChangeLog 2012-09-12 22:12:25 UTC (rev 128366)
+++ trunk/Tools/ChangeLog 2012-09-12 22:13:44 UTC (rev 128367)
@@ -1,3 +1,15 @@
+2012-09-12 Xan Lopez xlo...@igalia.com
+
+[GTK] We attempt to rebase documentation even if it's not present
+https://bugs.webkit.org/show_bug.cgi?id=96553
+
+Reviewed by Martin Robinson.
+
+Do not make the documentation rebase step fatal. This allows make
+install to succeed when there's no documentation generated.
+
+* gtk/generate-gtkdoc:
+
2012-09-12 Kenneth Rohde Christiansen kenn...@webkit.org
Respect WEBKITOUTPUTDIR when running EFL tests
Modified: trunk/Tools/gtk/generate-gtkdoc (128366 => 128367)
--- trunk/Tools/gtk/generate-gtkdoc 2012-09-12 22:12:25 UTC (rev 128366)
+++ trunk/Tools/gtk/generate-gtkdoc 2012-09-12 22:13:44 UTC (rev 128367)
@@ -173,7 +173,10 @@
saw_webkit1_warnings = generate_doc(generator)
else:
print Rebasing WebKit1 documentation...
-generator.rebase_installed_docs()
+try:
+generator.rebase_installed_docs()
+except Exception,e:
+print Rebase did not happen, likely no documentation is present.
# WebKit2 might not be enabled, so check for the pkg-config file before building documentation.
pkg_config_path = common.build_path('Source', 'WebKit2', 'webkit2gtk-3.0.pc')
@@ -184,6 +187,9 @@
saw_webkit2_warnings = generate_doc(generator)
else:
print \nRebasing WebKit2 documentation...
-generator.rebase_installed_docs()
+try:
+generator.rebase_installed_docs()
+except Exception,e:
+print Rebase did not happen, likely no documentation is present.
sys.exit(saw_webkit1_warnings or saw_webkit2_warnings)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128369] trunk/Source/JavaScriptCore
Title: [128369] trunk/Source/_javascript_Core
Revision 128369
Author commit-qu...@webkit.org
Date 2012-09-12 15:20:34 -0700 (Wed, 12 Sep 2012)
Log Message
Refactor Opcodes to distinguish between core and extension opcodes.
https://bugs.webkit.org/show_bug.cgi?id=96466.
Patch by Mark Lam mark@apple.com on 2012-09-12
Reviewed by Filip Pizlo.
* bytecode/Opcode.h:
(JSC): Added FOR_EACH_CORE_OPCODE_ID() macro.
* llint/LowLevelInterpreter.h:
(JSC): Auto-generate llint opcode aliases using the
FOR_EACH_CORE_OPCODE_ID() macro.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Opcode.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (128368 => 128369)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-12 22:19:50 UTC (rev 128368)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-12 22:20:34 UTC (rev 128369)
@@ -1,3 +1,16 @@
+2012-09-12 Mark Lam mark@apple.com
+
+Refactor Opcodes to distinguish between core and extension opcodes.
+https://bugs.webkit.org/show_bug.cgi?id=96466.
+
+Reviewed by Filip Pizlo.
+
+* bytecode/Opcode.h:
+(JSC): Added FOR_EACH_CORE_OPCODE_ID() macro.
+* llint/LowLevelInterpreter.h:
+(JSC): Auto-generate llint opcode aliases using the
+FOR_EACH_CORE_OPCODE_ID() macro.
+
2012-09-11 Geoffrey Garen gga...@apple.com
Second step to fixing the Windows build: Add new symbols.
Modified: trunk/Source/_javascript_Core/bytecode/Opcode.h (128368 => 128369)
--- trunk/Source/_javascript_Core/bytecode/Opcode.h 2012-09-12 22:19:50 UTC (rev 128368)
+++ trunk/Source/_javascript_Core/bytecode/Opcode.h 2012-09-12 22:20:34 UTC (rev 128369)
@@ -39,7 +39,7 @@
namespace JSC {
-#define FOR_EACH_OPCODE_ID(macro) \
+#define FOR_EACH_CORE_OPCODE_ID_WITH_EXTENSION(macro, extension__) \
macro(op_enter, 1) \
macro(op_create_activation, 2) \
macro(op_init_lazy_reg, 2) \
@@ -200,10 +200,20 @@
macro(op_profile_will_call, 2) \
macro(op_profile_did_call, 2) \
\
-FOR_EACH_LLINT_OPCODE_EXTENSION(macro) \
+extension__ \
\
macro(op_end, 2) // end must be the last opcode in the list
+#define FOR_EACH_CORE_OPCODE_ID(macro) \
+FOR_EACH_CORE_OPCODE_ID_WITH_EXTENSION(macro, /* No extension */ )
+
+#define FOR_EACH_OPCODE_ID(macro) \
+FOR_EACH_CORE_OPCODE_ID_WITH_EXTENSION( \
+macro, \
+FOR_EACH_LLINT_OPCODE_EXTENSION(macro) \
+)
+
+
#define OPCODE_ID_ENUM(opcode, length) opcode,
typedef enum { FOR_EACH_OPCODE_ID(OPCODE_ID_ENUM) } OpcodeID;
#undef OPCODE_ID_ENUM
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.h (128368 => 128369)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.h 2012-09-12 22:19:50 UTC (rev 128368)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.h 2012-09-12 22:20:34 UTC (rev 128369)
@@ -36,40 +36,17 @@
namespace JSC {
-// The following is a minimal set of alias for the opcode names. This is needed
+// The following is a set of alias for the opcode names. This is needed
// because there is code (e.g. in GetByIdStatus.cpp and PutByIdStatus.cpp)
// which refers to the opcodes expecting them to be prefixed with llint_.
// In the CLoop implementation, the 2 are equivalent. Hence, we set up this
// alias here.
-//
-// Note: we don't just do this for all opcodes because we only need a few,
-// and currently, FOR_EACH_OPCODE_ID() includes the llint and JIT opcode
-// extensions which we definitely don't want to add an alias for. With some
-// minor refactoring, we can use FOR_EACH_OPCODE_ID() to automatically
-// generate a llint_ alias for all opcodes, but that is not needed at this
-// time.
-const OpcodeID llint_op_call = op_call;
-const OpcodeID llint_op_call_eval = op_call_eval;
-const OpcodeID llint_op_call_varargs = op_call_varargs;
-const OpcodeID llint_op_construct = op_construct;
-const OpcodeID llint_op_catch = op_catch;
-const OpcodeID llint_op_get_by_id = op_get_by_id;
-const OpcodeID llint_op_get_by_id_out_of_line = op_get_by_id_out_of_line;
-const OpcodeID llint_op_put_by_id = op_put_by_id;
-const OpcodeID llint_op_put_by_id_out_of_line = op_put_by_id_out_of_line;
+#define LLINT_OPCODE_ALIAS(opcode, length) \
+const OpcodeID llint_##opcode = opcode;
+FOR_EACH_CORE_OPCODE_ID(LLINT_OPCODE_ALIAS)
+#undef LLINT_OPCODE_ALIAS
-const OpcodeID llint_op_put_by_id_transition_direct =
-op_put_by_id_transition_direct;
-const OpcodeID llint_op_put_by_id_transition_direct_out_of_line =
-op_put_by_id_transition_direct_out_of_line;
-const OpcodeID llint_op_put_by_id_transition_normal =
-op_put_by_id_transition_normal;
-const OpcodeID llint_op_put_by_id_transition_normal_out_of_line =
-op_put_by_id_transition_normal_out_of_line;
-
-const OpcodeID
[webkit-changes] [128370] trunk
Title: [128370] trunk Revision 128370 Author jsb...@chromium.org Date 2012-09-12 15:22:07 -0700 (Wed, 12 Sep 2012) Log Message IndexedDB: The |source| property of IDBFactory.open() request should be null https://bugs.webkit.org/show_bug.cgi?id=96551 Reviewed by Tony Chang. Source/WebCore: Per the IDB spec, the source property of the IDBOpenDBRequest returned by IDBFactory.open() should be set to null. We were setting it to the IDBFactory object instead. Tests: storage/indexeddb/basics.html storage/indexeddb/basics-workers.html storage/indexeddb/mozilla/event-source.html storage/indexeddb/readonly.html * Modules/indexeddb/IDBFactory.cpp: (WebCore::IDBFactory::open): LayoutTests: Already tested for in several places, so just update expectations/assertions. * storage/indexeddb/basics-expected.txt: * storage/indexeddb/basics-workers-expected.txt: * storage/indexeddb/mozilla/event-source-expected.txt: * storage/indexeddb/mozilla/resources/event-source.js: Updated assertion. (openSuccess): * storage/indexeddb/readonly-expected.txt: * storage/indexeddb/resources/basics.js: Updated assertion. (test): (openCallback): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/indexeddb/basics-expected.txt trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/event-source-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/resources/event-source.js trunk/LayoutTests/storage/indexeddb/readonly-expected.txt trunk/LayoutTests/storage/indexeddb/resources/basics.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp Diff Modified: trunk/LayoutTests/ChangeLog (128369 => 128370) --- trunk/LayoutTests/ChangeLog 2012-09-12 22:20:34 UTC (rev 128369) +++ trunk/LayoutTests/ChangeLog 2012-09-12 22:22:07 UTC (rev 128370) @@ -1,3 +1,22 @@ +2012-09-12 Joshua Bell jsb...@chromium.org + +IndexedDB: The |source| property of IDBFactory.open() request should be null +https://bugs.webkit.org/show_bug.cgi?id=96551 + +Reviewed by Tony Chang. + +Already tested for in several places, so just update expectations/assertions. + +* storage/indexeddb/basics-expected.txt: +* storage/indexeddb/basics-workers-expected.txt: +* storage/indexeddb/mozilla/event-source-expected.txt: +* storage/indexeddb/mozilla/resources/event-source.js: Updated assertion. +(openSuccess): +* storage/indexeddb/readonly-expected.txt: +* storage/indexeddb/resources/basics.js: Updated assertion. +(test): +(openCallback): + 2012-09-12 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r128353. Modified: trunk/LayoutTests/storage/indexeddb/basics-expected.txt (128369 => 128370) --- trunk/LayoutTests/storage/indexeddb/basics-expected.txt 2012-09-12 22:20:34 UTC (rev 128369) +++ trunk/LayoutTests/storage/indexeddb/basics-expected.txt 2012-09-12 22:22:07 UTC (rev 128370) @@ -26,7 +26,7 @@ PASS code is DOMException.INVALID_STATE_ERR PASS ename is 'InvalidStateError' PASS 'source' in request is true -PASS request.source is indexedDB +PASS request.source is null PASS 'transaction' in request is true PASS request.transaction is null PASS 'readyState' in request is true @@ -44,7 +44,7 @@ PASS 'error' in event.target is true PASS event.target.error is null PASS 'source' in event.target is true -PASS request.source is indexedDB +PASS request.source is null PASS 'transaction' in event.target is true PASS event.target.transaction is null PASS 'readyState' in request is true Modified: trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt (128369 => 128370) --- trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt 2012-09-12 22:20:34 UTC (rev 128369) +++ trunk/LayoutTests/storage/indexeddb/basics-workers-expected.txt 2012-09-12 22:22:07 UTC (rev 128370) @@ -27,7 +27,7 @@ PASS [Worker] code is DOMException.INVALID_STATE_ERR PASS [Worker] ename is 'InvalidStateError' PASS [Worker] 'source' in request is true -PASS [Worker] request.source is indexedDB +PASS [Worker] request.source is null PASS [Worker] 'transaction' in request is true PASS [Worker] request.transaction is null PASS [Worker] 'readyState' in request is true @@ -45,7 +45,7 @@ PASS [Worker] 'error' in event.target is true PASS [Worker] event.target.error is null PASS [Worker] 'source' in event.target is true -PASS [Worker] request.source is indexedDB +PASS [Worker] request.source is null PASS [Worker] 'transaction' in event.target is true PASS [Worker] event.target.transaction is null PASS [Worker] 'readyState' in request is true Modified: trunk/LayoutTests/storage/indexeddb/mozilla/event-source-expected.txt (128369 => 128370) --- trunk/LayoutTests/storage/indexeddb/mozilla/event-source-expected.txt 2012-09-12 22:20:34 UTC (rev 128369) +++
[webkit-changes] [128371] trunk/Source/WebCore
Title: [128371] trunk/Source/WebCore
Revision 128371
Author o...@chromium.org
Date 2012-09-12 15:29:42 -0700 (Wed, 12 Sep 2012)
Log Message
RenderBox::computeLogicalClientHeight is incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=94288
Reviewed by Tony Chang.
Just renamed a couple methods to make it more clear what they return.
No behavior changes.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::lineBreakLength):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (128370 => 128371)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 22:22:07 UTC (rev 128370)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 22:29:42 UTC (rev 128371)
@@ -1,3 +1,26 @@
+2012-09-12 Ojan Vafai o...@chromium.org
+
+RenderBox::computeLogicalClientHeight is incorrectly named
+https://bugs.webkit.org/show_bug.cgi?id=94288
+
+Reviewed by Tony Chang.
+
+Just renamed a couple methods to make it more clear what they return.
+No behavior changes.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeLogicalHeightUsing):
+(WebCore::RenderBox::computeContentLogicalHeight):
+(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
+(WebCore::RenderBox::availableLogicalHeightUsing):
+* rendering/RenderBox.h:
+(RenderBox):
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::mainAxisContentExtent):
+(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
+(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
+(WebCore::RenderFlexibleBox::lineBreakLength):
+
2012-09-12 Joshua Bell jsb...@chromium.org
IndexedDB: The |source| property of IDBFactory.open() request should be null
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (128370 => 128371)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2012-09-12 22:22:07 UTC (rev 128370)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2012-09-12 22:29:42 UTC (rev 128371)
@@ -2089,21 +2089,21 @@
LayoutUnit RenderBox::computeLogicalHeightUsing(SizeType heightType, const Length height) const
{
-LayoutUnit logicalHeight = computeContentLogicalHeightUsing(heightType, height);
+LayoutUnit logicalHeight = computeContentAndScrollbarLogicalHeightUsing(heightType, height);
if (logicalHeight != -1)
logicalHeight = adjustBorderBoxLogicalHeightForBoxSizing(logicalHeight);
return logicalHeight;
}
-LayoutUnit RenderBox::computeLogicalClientHeight(SizeType heightType, const Length height)
+LayoutUnit RenderBox::computeContentLogicalHeight(SizeType heightType, const Length height)
{
-LayoutUnit heightIncludingScrollbar = computeContentLogicalHeightUsing(heightType, height);
+LayoutUnit heightIncludingScrollbar = computeContentAndScrollbarLogicalHeightUsing(heightType, height);
if (heightIncludingScrollbar == -1)
return -1;
return std::maxLayoutUnit(0, adjustContentBoxLogicalHeightForBoxSizing(heightIncludingScrollbar) - scrollbarLogicalHeight());
}
-LayoutUnit RenderBox::computeContentLogicalHeightUsing(SizeType heightType, const Length height) const
+LayoutUnit RenderBox::computeContentAndScrollbarLogicalHeightUsing(SizeType heightType, const Length height) const
{
if (height.isAuto())
return heightType == MinSize ? 0 : -1;
@@ -2340,7 +2340,7 @@
return adjustContentBoxLogicalHeightForBoxSizing(valueForLength(h, availableHeight));
}
-LayoutUnit heightIncludingScrollbar = computeContentLogicalHeightUsing(MainOrPreferredSize, h);
+LayoutUnit heightIncludingScrollbar = computeContentAndScrollbarLogicalHeightUsing(MainOrPreferredSize, h);
if (heightIncludingScrollbar != -1)
return std::maxLayoutUnit(0, adjustContentBoxLogicalHeightForBoxSizing(heightIncludingScrollbar) - scrollbarLogicalHeight());
Modified: trunk/Source/WebCore/rendering/RenderBox.h (128370 => 128371)
--- trunk/Source/WebCore/rendering/RenderBox.h 2012-09-12 22:22:07 UTC (rev 128370)
+++ trunk/Source/WebCore/rendering/RenderBox.h 2012-09-12 22:29:42 UTC (rev 128371)
@@ -389,8 +389,8 @@
LayoutUnit computeLogicalWidthInRegionUsing(SizeType, LayoutUnit availableLogicalWidth, const RenderBlock* containingBlock, RenderRegion*, LayoutUnit offsetFromLogicalTopOfFirstPage) const;
[webkit-changes] [128372] trunk/Source
Title: [128372] trunk/Source Revision 128372 Author commit-qu...@webkit.org Date 2012-09-12 15:36:08 -0700 (Wed, 12 Sep 2012) Log Message Source/WebCore: [GTK] Protect RedirectedXCompositeWindow with USE(GLX) when building the clutter AC backend https://bugs.webkit.org/show_bug.cgi?id=96165 Patch by Siraj Razick siraj.raz...@collabora.co.uk on 2012-09-12 Reviewed by Martin Robinson. RedirectedXCompositeWindow.cpp and RedirectedXCompositeWindow.h files requies openGL specific headers to compile so when we build webkit clutter AC backend these files failed to compile, This patch protects these two files with USE(GLX) when building webkit with Clutter AC backend. No new tests since this is a build fix * platform/gtk/RedirectedXCompositeWindow.cpp: * platform/gtk/RedirectedXCompositeWindow.h: protects both the files with USE(GLX) Source/WebKit/gtk: [GTK] Update AcceleratedCompositingContextClutter to match AcceleratedCompositingContext.h API update https://bugs.webkit.org/show_bug.cgi?id=96165 Patch by Siraj Razick siraj.raz...@collabora.co.uk on 2012-09-12 Reviewed by Martin Robinson. Due to the refactoring done in bug #90085 AcceleratedCompositingContext API changed, as a result AcceleratedCompositingContextClutter doesn't compile anymore. This patch is to update the AcceleratedCompositingContextClutter implementations to match the API update, and Make webkit AC backend compile again. * WebCoreSupport/AcceleratedCompositingContextClutter.cpp: (WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): (WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext): (WebKit::AcceleratedCompositingContext::setRootCompositingLayer): (WebKit::AcceleratedCompositingContext::setNonCompositedContentsNeedDisplay): (WebKit::flushAndRenderLayersCallback): (WebKit::AcceleratedCompositingContext::scheduleLayerFlush): (WebKit::AcceleratedCompositingContext::flushPendingLayerChanges): (WebKit::AcceleratedCompositingContext::flushAndRenderLayers): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.h trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (128371 => 128372) --- trunk/Source/WebCore/ChangeLog 2012-09-12 22:29:42 UTC (rev 128371) +++ trunk/Source/WebCore/ChangeLog 2012-09-12 22:36:08 UTC (rev 128372) @@ -1,3 +1,20 @@ +2012-09-12 Siraj Razick siraj.raz...@collabora.co.uk + +[GTK] Protect RedirectedXCompositeWindow with USE(GLX) when building the clutter AC backend +https://bugs.webkit.org/show_bug.cgi?id=96165 + +Reviewed by Martin Robinson. + +RedirectedXCompositeWindow.cpp and RedirectedXCompositeWindow.h files requies openGL specific +headers to compile so when we build webkit clutter AC backend these files failed to compile, +This patch protects these two files with USE(GLX) when building webkit with Clutter AC backend. + +No new tests since this is a build fix + +* platform/gtk/RedirectedXCompositeWindow.cpp: +* platform/gtk/RedirectedXCompositeWindow.h: +protects both the files with USE(GLX) + 2012-09-12 Ojan Vafai o...@chromium.org RenderBox::computeLogicalClientHeight is incorrectly named Modified: trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp (128371 => 128372) --- trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp 2012-09-12 22:29:42 UTC (rev 128371) +++ trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp 2012-09-12 22:36:08 UTC (rev 128372) @@ -27,6 +27,7 @@ #include config.h #include RedirectedXCompositeWindow.h +#if USE(GLX) #include GLContextGLX.h #include GL/glx.h #include X11/extensions/Xcomposite.h @@ -214,3 +215,5 @@ } } // namespace WebCore + +#endif // USE(GLX) Modified: trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.h (128371 => 128372) --- trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.h 2012-09-12 22:29:42 UTC (rev 128371) +++ trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.h 2012-09-12 22:36:08 UTC (rev 128372) @@ -27,6 +27,8 @@ #ifndef RedirectedXCompositeWindow_h #define RedirectedXCompositeWindow_h +#if USE(GLX) + #include GLContextGLX.h #include IntSize.h #include RefPtrCairo.h @@ -68,4 +70,6 @@ } // namespace WebCore +#endif // USE(GLX) + #endif // RedirectedXCompositeWindow_h Modified: trunk/Source/WebKit/gtk/ChangeLog (128371 => 128372) --- trunk/Source/WebKit/gtk/ChangeLog 2012-09-12 22:29:42 UTC (rev 128371) +++ trunk/Source/WebKit/gtk/ChangeLog 2012-09-12 22:36:08 UTC (rev 128372) @@ -1,3 +1,25 @@ +2012-09-12 Siraj Razick siraj.raz...@collabora.co.uk + +[GTK] Update AcceleratedCompositingContextClutter to match AcceleratedCompositingContext.h API update +
[webkit-changes] [128373] trunk
Title: [128373] trunk
Revision 128373
Author e...@webkit.org
Date 2012-09-12 15:40:15 -0700 (Wed, 12 Sep 2012)
Log Message
HTML parser fails to propertly close 4 identical nested formatting elements
https://bugs.webkit.org/show_bug.cgi?id=96385
Reviewed by Adam Barth.
Add missing Adoption agency step 4.a to fix one of our two outlying Adoption Agency bugs.
This is the same step that Opera was missing (must have been recently added to the spec).
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
Modified Paths
trunk/LayoutTests/html5lib/runner-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
Diff
Modified: trunk/LayoutTests/html5lib/runner-expected.txt (128372 => 128373)
--- trunk/LayoutTests/html5lib/runner-expected.txt 2012-09-12 22:36:08 UTC (rev 128372)
+++ trunk/LayoutTests/html5lib/runner-expected.txt 2012-09-12 22:40:15 UTC (rev 128373)
@@ -9,7 +9,6 @@
CONSOLE MESSAGE: line 2: FOOspanBAR/spanBAZ
resources/adoption01.dat:
14
-16
Test 14 of 17 in resources/adoption01.dat failed. Input:
divabdivdivdivdivdivdivdivdivdivdiv/a
@@ -65,29 +64,6 @@
| a
| div
| div
-
-Test 16 of 17 in resources/adoption01.dat failed. Input:
-x/b/b/b/by
-Got:
-| html
-| head
-| body
-| b
-| b
-| b
-| b
-| x
-| y
-Expected:
-| html
-| head
-| body
-| b
-| b
-| b
-| b
-| x
-| y
resources/adoption02.dat: PASS
resources/comments01.dat: PASS
Modified: trunk/Source/WebCore/ChangeLog (128372 => 128373)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 22:36:08 UTC (rev 128372)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 22:40:15 UTC (rev 128373)
@@ -1,3 +1,16 @@
+2012-09-12 Eric Seidel e...@webkit.org
+
+HTML parser fails to propertly close 4 identical nested formatting elements
+https://bugs.webkit.org/show_bug.cgi?id=96385
+
+Reviewed by Adam Barth.
+
+Add missing Adoption agency step 4.a to fix one of our two outlying Adoption Agency bugs.
+This is the same step that Opera was missing (must have been recently added to the spec).
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
+
2012-09-12 Siraj Razick siraj.raz...@collabora.co.uk
[GTK] Protect RedirectedXCompositeWindow with USE(GLX) when building the clutter AC backend
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (128372 => 128373)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2012-09-12 22:36:08 UTC (rev 128372)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2012-09-12 22:40:15 UTC (rev 128373)
@@ -1420,74 +1420,81 @@
static const int outerIterationLimit = 8;
static const int innerIterationLimit = 3;
+// 1, 2, 3 and 16 are covered by the for() loop.
for (int i = 0; i outerIterationLimit; ++i) {
-// 1.
+// 4.
Element* formattingElement = m_tree.activeFormattingElements()-closestElementInScopeWithName(token-name());
-if (!formattingElement || ((m_tree.openElements()-contains(formattingElement)) !m_tree.openElements()-inScope(formattingElement))) {
+// 4.a
+if (!formattingElement)
+return processAnyOtherEndTagForInBody(token);
+// 4.c
+if ((m_tree.openElements()-contains(formattingElement)) !m_tree.openElements()-inScope(formattingElement)) {
parseError(token);
notImplemented(); // Check the stack of open elements for a more specific parse error.
return;
}
+// 4.b
HTMLElementStack::ElementRecord* formattingElementRecord = m_tree.openElements()-find(formattingElement);
if (!formattingElementRecord) {
parseError(token);
m_tree.activeFormattingElements()-remove(formattingElement);
return;
}
+// 4.d
if (formattingElement != m_tree.currentElement())
parseError(token);
-// 2.
+// 5.
HTMLElementStack::ElementRecord* furthestBlock = m_tree.openElements()-furthestBlockForFormattingElement(formattingElement);
-// 3.
+// 6.
if (!furthestBlock) {
m_tree.openElements()-popUntilPopped(formattingElement);
m_tree.activeFormattingElements()-remove(formattingElement);
return;
}
-// 4.
+// 7.
ASSERT(furthestBlock-isAbove(formattingElementRecord));
RefPtrHTMLStackItem commonAncestor = formattingElementRecord-next()-stackItem();
-// 5.
+// 8.
HTMLFormattingElementList::Bookmark bookmark = m_tree.activeFormattingElements()-bookmarkFor(formattingElement);
-// 6.
+// 9.
HTMLElementStack::ElementRecord* node = furthestBlock;
[webkit-changes] [128374] trunk
Title: [128374] trunk
Revision 128374
Author aba...@webkit.org
Date 2012-09-12 15:43:54 -0700 (Wed, 12 Sep 2012)
Log Message
[v8] document.getCSSCanvasContext doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=96560
Reviewed by Eric Seidel.
Source/WebCore:
Instead of having a special case for toV8(CanvasRenderingContext*)
inlined into this custom function, we should just make the toV8
function itself custom.
Test: fast/canvas/canvas-css-crazy.html
* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/custom/V8DocumentCustom.cpp:
* dom/Document.idl:
* html/canvas/CanvasRenderingContext.idl:
LayoutTests:
Test that document.getCSSCanvasContext returns null for a bogus canvas type.
* fast/canvas/canvas-css-crazy-expected.txt: Added.
* fast/canvas/canvas-css-crazy.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/UseV8.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/html/canvas/CanvasRenderingContext.idl
Added Paths
trunk/LayoutTests/fast/canvas/canvas-css-crazy-expected.txt
trunk/LayoutTests/fast/canvas/canvas-css-crazy.html
trunk/Source/WebCore/bindings/v8/custom/V8CanvasRenderingContextCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (128373 => 128374)
--- trunk/LayoutTests/ChangeLog 2012-09-12 22:40:15 UTC (rev 128373)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 22:43:54 UTC (rev 128374)
@@ -1,3 +1,15 @@
+2012-09-12 Adam Barth aba...@webkit.org
+
+[v8] document.getCSSCanvasContext doesn't need to be custom
+https://bugs.webkit.org/show_bug.cgi?id=96560
+
+Reviewed by Eric Seidel.
+
+Test that document.getCSSCanvasContext returns null for a bogus canvas type.
+
+* fast/canvas/canvas-css-crazy-expected.txt: Added.
+* fast/canvas/canvas-css-crazy.html: Added.
+
2012-09-12 Joshua Bell jsb...@chromium.org
IndexedDB: The |source| property of IDBFactory.open() request should be null
Added: trunk/LayoutTests/fast/canvas/canvas-css-crazy-expected.txt (0 => 128374)
--- trunk/LayoutTests/fast/canvas/canvas-css-crazy-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-css-crazy-expected.txt 2012-09-12 22:43:54 UTC (rev 128374)
@@ -0,0 +1,2 @@
+ALERT: PASS
+
Added: trunk/LayoutTests/fast/canvas/canvas-css-crazy.html (0 => 128374)
--- trunk/LayoutTests/fast/canvas/canvas-css-crazy.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-css-crazy.html 2012-09-12 22:43:54 UTC (rev 128374)
@@ -0,0 +1,21 @@
+html
+ head
+ style
+ div { background: -webkit-canvas(squares); width:600px; height:600px; border:2px solid black }
+ /style
+ script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function draw(w, h) {
+ var ctx = document.getCSSCanvasContext(4d, squares, w, h);
+ if (ctx !== null)
+alert(FAIL! ctx wasn't null: + ctx);
+ alert(PASS);
+}
+ /script
+ /head
+ body _onload_=draw(300, 300)
+ div/div
+ /body
+/html
Modified: trunk/Source/WebCore/ChangeLog (128373 => 128374)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 22:40:15 UTC (rev 128373)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 22:43:54 UTC (rev 128374)
@@ -1,3 +1,22 @@
+2012-09-12 Adam Barth aba...@webkit.org
+
+[v8] document.getCSSCanvasContext doesn't need to be custom
+https://bugs.webkit.org/show_bug.cgi?id=96560
+
+Reviewed by Eric Seidel.
+
+Instead of having a special case for toV8(CanvasRenderingContext*)
+inlined into this custom function, we should just make the toV8
+function itself custom.
+
+Test: fast/canvas/canvas-css-crazy.html
+
+* UseV8.cmake:
+* WebCore.gypi:
+* bindings/v8/custom/V8DocumentCustom.cpp:
+* dom/Document.idl:
+* html/canvas/CanvasRenderingContext.idl:
+
2012-09-12 Eric Seidel e...@webkit.org
HTML parser fails to propertly close 4 identical nested formatting elements
Modified: trunk/Source/WebCore/UseV8.cmake (128373 => 128374)
--- trunk/Source/WebCore/UseV8.cmake 2012-09-12 22:40:15 UTC (rev 128373)
+++ trunk/Source/WebCore/UseV8.cmake 2012-09-12 22:43:54 UTC (rev 128374)
@@ -82,6 +82,7 @@
bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp
bindings/v8/custom/V8CSSValueCustom.cpp
bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp
+bindings/v8/custom/V8CanvasRenderingContextCustom.cpp
bindings/v8/custom/V8ClipboardCustom.cpp
bindings/v8/custom/V8ConsoleCustom.cpp
bindings/v8/custom/V8CoordinatesCustom.cpp
Modified: trunk/Source/WebCore/WebCore.gypi (128373 => 128374)
--- trunk/Source/WebCore/WebCore.gypi 2012-09-12 22:40:15 UTC (rev 128373)
+++ trunk/Source/WebCore/WebCore.gypi 2012-09-12 22:43:54 UTC (rev 128374)
@@ -2351,6 +2351,7 @@
'bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp',
[webkit-changes] [128375] trunk
Title: [128375] trunk Revision 128375 Author o...@chromium.org Date 2012-09-12 15:54:56 -0700 (Wed, 12 Sep 2012) Log Message percentage widths rendered wrong in vertical writing mode with orthogonal parent https://bugs.webkit.org/show_bug.cgi?id=96308 Reviewed by Tony Chang. Source/WebCore: When the containingBlock is in a perpendicular writing-mode, we need to use it's logicalWidth as the availableHeight for computing percentage values. Tests: fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html fast/writing-mode/percentage-height-orthogonal-writing-modes.html * rendering/RenderBox.cpp: (WebCore::RenderBox::computePercentageLogicalHeight): (WebCore::RenderBox::availableLogicalHeightUsing): Added some FIXMEs for perpendicular writing mode cases. LayoutTests: * fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt: Added. * fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added. * fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html: Added. * fast/writing-mode/percentage-height-orthogonal-writing-modes.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png trunk/LayoutTests/platform/mac/fast/table/height-percent-test-vertical-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp Added Paths trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes.html Diff Modified: trunk/LayoutTests/ChangeLog (128374 => 128375) --- trunk/LayoutTests/ChangeLog 2012-09-12 22:43:54 UTC (rev 128374) +++ trunk/LayoutTests/ChangeLog 2012-09-12 22:54:56 UTC (rev 128375) @@ -1,3 +1,15 @@ +2012-09-12 Ojan Vafai o...@chromium.org + +percentage widths rendered wrong in vertical writing mode with orthogonal parent +https://bugs.webkit.org/show_bug.cgi?id=96308 + +Reviewed by Tony Chang. + +* fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt: Added. +* fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added. +* fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html: Added. +* fast/writing-mode/percentage-height-orthogonal-writing-modes.html: Added. + 2012-09-12 Adam Barth aba...@webkit.org [v8] document.getCSSCanvasContext doesn't need to be custom Added: trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt (0 => 128375) --- trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt (rev 0) +++ trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt 2012-09-12 22:54:56 UTC (rev 128375) @@ -0,0 +1,20 @@ +PASS +PASS +PASS +PASS +PASS +FAIL: +Expected 100 for height, but got 600. + +div class=container +div style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200 +div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200/div +/div +/div +PASS +FAIL: +Expected 584 for height, but got 600. + +div class=container style=width: auto; height: auto; float: left; +div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=584 data-expected-width=0/div +/div Added: trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt (0 => 128375) --- trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt (rev 0) +++ trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt 2012-09-12 22:54:56 UTC (rev 128375) @@ -0,0 +1,39 @@ +compatMode: BackCompat +PASS +PASS +PASS +PASS +PASS +FAIL: +Expected 100 for height, but got 600. + +div class=container +div style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200 +div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200/div +/div +/div +PASS +FAIL: +Expected 100 for height, but got 600. +Expected 100 for height, but got 600. +Expected 100 for height, but got 600. + +div class=container +div style=width: 150px; data-expected-height=100 data-expected-width=150 +div data-expected-height=100 data-expected-width=150 +div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=150/div +/div +/div +/div +FAIL: +Expected 584 for height, but got 1447.
[webkit-changes] [128376] trunk
Title: [128376] trunk
Revision 128376
Author cfleiz...@apple.com
Date 2012-09-12 15:56:47 -0700 (Wed, 12 Sep 2012)
Log Message
AX: svg:image not accessible
https://bugs.webkit.org/show_bug.cgi?id=96341
Reviewed by Adele Peterson.
Source/WebCore:
Test: accessibility/svg-image.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
* accessibility/svg-image.html: Added.
* platform/mac/accessibility/svg-image-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Added Paths
trunk/LayoutTests/accessibility/svg-image.html
trunk/LayoutTests/platform/mac/accessibility/svg-image-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (128375 => 128376)
--- trunk/LayoutTests/ChangeLog 2012-09-12 22:54:56 UTC (rev 128375)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 22:56:47 UTC (rev 128376)
@@ -1,3 +1,13 @@
+2012-09-12 Chris Fleizach cfleiz...@apple.com
+
+AX: svg:image not accessible
+https://bugs.webkit.org/show_bug.cgi?id=96341
+
+Reviewed by Adele Peterson.
+
+* accessibility/svg-image.html: Added.
+* platform/mac/accessibility/svg-image-expected.txt: Added.
+
2012-09-12 Ojan Vafai o...@chromium.org
percentage widths rendered wrong in vertical writing mode with orthogonal parent
Added: trunk/LayoutTests/accessibility/svg-image.html (0 => 128376)
--- trunk/LayoutTests/accessibility/svg-image.html (rev 0)
+++ trunk/LayoutTests/accessibility/svg-image.html 2012-09-12 22:56:47 UTC (rev 128376)
@@ -0,0 +1,40 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body id=body
+
+img id=realimage tabindex=0 alt=TestImage width=100 height=100
+
+svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+
+image tabindex=0 id=svgimage alt=TestImage x=20 y=20 width=298 height=65 xlink:href=""
+
+/svg
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that SVG images are accessible elements and they have the same attributes as real images.);
+
+if (window.accessibilityController) {
+document.getElementById(realimage).focus();
+var realImage = accessibilityController.focusedElement;
+
+document.getElementById(svgimage).focus();
+var svgImage = accessibilityController.focusedElement;
+shouldBe(svgImage.role, realImage.role);
+shouldBe(svgImage.description, realImage.description);
+
+debug(SVG Image Role: + svgImage.role);
+debug(SVG Image Description: + svgImage.description);
+}
+
+/script
+
+script src=""
+/body
+/html
Added: trunk/LayoutTests/platform/mac/accessibility/svg-image-expected.txt (0 => 128376)
--- trunk/LayoutTests/platform/mac/accessibility/svg-image-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/svg-image-expected.txt 2012-09-12 22:56:47 UTC (rev 128376)
@@ -0,0 +1,14 @@
+
+This tests that SVG images are accessible elements and they have the same attributes as real images.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS svgImage.role is realImage.role
+PASS svgImage.description is realImage.description
+SVG Image Role: AXRole: AXImage
+SVG Image Description: AXDescription: TestImage
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: trunk/Source/WebCore/ChangeLog (128375 => 128376)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 22:54:56 UTC (rev 128375)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 22:56:47 UTC (rev 128376)
@@ -1,3 +1,15 @@
+2012-09-12 Chris Fleizach cfleiz...@apple.com
+
+AX: svg:image not accessible
+https://bugs.webkit.org/show_bug.cgi?id=96341
+
+Reviewed by Adele Peterson.
+
+Test: accessibility/svg-image.html
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+
2012-09-12 Ojan Vafai o...@chromium.org
percentage widths rendered wrong in vertical writing mode with orthogonal parent
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (128375 => 128376)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-09-12 22:54:56 UTC (rev 128375)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-09-12 22:56:47 UTC (rev 128376)
@@ -2356,11 +2356,12 @@
return LegendRole;
if (m_renderer-isText())
return StaticTextRole;
-if (cssBox cssBox-isImage()) {
+if ((cssBox cssBox-isImage()) || m_renderer-isSVGImage()) {
if (node node-hasTagName(inputTag))
return ariaHasPopup() ? PopUpButtonRole : ButtonRole;
return ImageRole;
}
+
if (node node-hasTagName(canvasTag))
return
[webkit-changes] [128377] trunk/Source/WebKit/chromium
Title: [128377] trunk/Source/WebKit/chromium
Revision 128377
Author commit-qu...@webkit.org
Date 2012-09-12 16:10:11 -0700 (Wed, 12 Sep 2012)
Log Message
Unreviewed, rolling out r128351.
http://trac.webkit.org/changeset/128351
https://bugs.webkit.org/show_bug.cgi?id=96573
Broke FindInPage browser_tests (Requested by jamesr_ on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-12
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::cancelPendingScopingEffort):
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
(WebKit::WebFrameImpl::shouldScopeMatches):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128376 => 128377)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 22:56:47 UTC (rev 128376)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 23:10:11 UTC (rev 128377)
@@ -1,3 +1,18 @@
+2012-09-12 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r128351.
+http://trac.webkit.org/changeset/128351
+https://bugs.webkit.org/show_bug.cgi?id=96573
+
+Broke FindInPage browser_tests (Requested by jamesr_ on
+#webkit).
+
+* src/WebFrameImpl.cpp:
+(WebKit::WebFrameImpl::scopeStringMatches):
+(WebKit::WebFrameImpl::cancelPendingScopingEffort):
+(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
+(WebKit::WebFrameImpl::shouldScopeMatches):
+
2012-09-12 Adrienne Walker e...@google.com
[chromium] Fix search tickmarks not disappearing when compositing is enabled
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (128376 => 128377)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 22:56:47 UTC (rev 128376)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 23:10:11 UTC (rev 128377)
@@ -1779,10 +1779,8 @@
const WebFindOptions options,
bool reset)
{
-if (!shouldScopeMatches(searchText)) {
-increaseMatchCount(0, identifier);
+if (!shouldScopeMatches(searchText))
return;
-}
WebFrameImpl* mainFrameImpl = viewImpl()-mainFrameImpl();
@@ -1959,14 +1957,6 @@
deleteAllValues(m_deferredScopingWork);
m_deferredScopingWork.clear();
-// Clear the active match, for two reasons:
-// We just finished the find 'session' and we don't want future (potentially
-// unrelated) find 'sessions' operations to start at the same place.
-// The WebFrameImpl could get reused and the m_activeMatch could end up pointing
-// to a document that is no longer valid. Keeping an invalid reference around
-// is just asking for trouble.
-m_activeMatch = 0;
-
m_activeMatchIndexInCurrentFrame = -1;
}
@@ -2532,6 +2522,14 @@
// a link focused, which is weird).
frame()-selection()-setSelection(m_activeMatch.get());
frame()-document()-setFocusedNode(0);
+
+// Finally clear the active match, for two reasons:
+// We just finished the find 'session' and we don't want future (potentially
+// unrelated) find 'sessions' operations to start at the same place.
+// The WebFrameImpl could get reused and the m_activeMatch could end up pointing
+// to a document that is no longer valid. Keeping an invalid reference around
+// is just asking for trouble.
+m_activeMatch = 0;
}
}
@@ -2614,9 +2612,9 @@
bool WebFrameImpl::shouldScopeMatches(const String searchText)
{
-// Don't scope if we can't find a frame or a view.
+// Don't scope if we can't find a frame or a view or if the frame is not visible.
// The user may have closed the tab/application, so abort.
-if (!frame() || !frame()-view())
+if (!frame() || !frame()-view() || !hasVisibleContent())
return false;
ASSERT(frame()-document() frame()-view());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128378] trunk/Source/WebKit/chromium
Title: [128378] trunk/Source/WebKit/chromium
Revision 128378
Author commit-qu...@webkit.org
Date 2012-09-12 16:17:00 -0700 (Wed, 12 Sep 2012)
Log Message
[chromium] Remove unused WebGestureEvent fields
https://bugs.webkit.org/show_bug.cgi?id=95496
Patch by Rick Byers rby...@chromium.org on 2012-09-12
Reviewed by Adam Barth.
Remove the no-longer used fields from WebGestureEvent, now that
chromium has been updated to use the per-event-type fields instead.
This depends on crrev.com/156346 in chromium.
* public/WebInputEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):
* public/android/WebInputEventFactory.h:
* src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):
* src/android/WebInputEventFactory.cpp:
(WebKit):
(WebKit::WebInputEventFactory::gestureEvent):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebInputEvent.h
trunk/Source/WebKit/chromium/public/android/WebInputEventFactory.h
trunk/Source/WebKit/chromium/src/WebInputEvent.cpp
trunk/Source/WebKit/chromium/src/android/WebInputEventFactory.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128377 => 128378)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 23:10:11 UTC (rev 128377)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 23:17:00 UTC (rev 128378)
@@ -1,3 +1,23 @@
+2012-09-12 Rick Byers rby...@chromium.org
+
+[chromium] Remove unused WebGestureEvent fields
+https://bugs.webkit.org/show_bug.cgi?id=95496
+
+Reviewed by Adam Barth.
+
+Remove the no-longer used fields from WebGestureEvent, now that
+chromium has been updated to use the per-event-type fields instead.
+This depends on crrev.com/156346 in chromium.
+
+* public/WebInputEvent.h:
+(WebKit::WebGestureEvent::WebGestureEvent):
+* public/android/WebInputEventFactory.h:
+* src/WebInputEvent.cpp:
+(SameSizeAsWebGestureEvent):
+* src/android/WebInputEventFactory.cpp:
+(WebKit):
+(WebKit::WebInputEventFactory::gestureEvent):
+
2012-09-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r128351.
Modified: trunk/Source/WebKit/chromium/public/WebInputEvent.h (128377 => 128378)
--- trunk/Source/WebKit/chromium/public/WebInputEvent.h 2012-09-12 23:10:11 UTC (rev 128377)
+++ trunk/Source/WebKit/chromium/public/WebInputEvent.h 2012-09-12 23:17:00 UTC (rev 128378)
@@ -378,12 +378,6 @@
int globalX;
int globalY;
-// FIXME: These are currently overloaded. We're in the process of moving
-// to the union below. http://wkb.ug/93123
-float deltaX;
-float deltaY;
-WebRect boundingBox;
-
union {
struct {
int tapCount;
@@ -420,8 +414,6 @@
, y(0)
, globalX(0)
, globalY(0)
-, deltaX(0.0f)
-, deltaY(0.0f)
{
memset(data, 0, sizeof(data));
}
Modified: trunk/Source/WebKit/chromium/public/android/WebInputEventFactory.h (128377 => 128378)
--- trunk/Source/WebKit/chromium/public/android/WebInputEventFactory.h 2012-09-12 23:10:11 UTC (rev 128377)
+++ trunk/Source/WebKit/chromium/public/android/WebInputEventFactory.h 2012-09-12 23:17:00 UTC (rev 128378)
@@ -81,6 +81,11 @@
float deltaY,
int modifiers);
+WEBKIT_EXPORT static WebGestureEvent gestureEvent(WebInputEvent::Type,
+ double timeStampSeconds,
+ int x,
+ int y,
+ int modifiers);
};
} // namespace WebKit
Modified: trunk/Source/WebKit/chromium/src/WebInputEvent.cpp (128377 => 128378)
--- trunk/Source/WebKit/chromium/src/WebInputEvent.cpp 2012-09-12 23:10:11 UTC (rev 128377)
+++ trunk/Source/WebKit/chromium/src/WebInputEvent.cpp 2012-09-12 23:17:00 UTC (rev 128378)
@@ -60,7 +60,7 @@
};
struct SameSizeAsWebGestureEvent : public SameSizeAsWebInputEvent {
-int gestureData[14];
+int gestureData[8];
};
struct SameSizeAsWebTouchEvent : public SameSizeAsWebInputEvent {
Modified: trunk/Source/WebKit/chromium/src/android/WebInputEventFactory.cpp (128377 => 128378)
--- trunk/Source/WebKit/chromium/src/android/WebInputEventFactory.cpp 2012-09-12 23:10:11 UTC (rev 128377)
+++ trunk/Source/WebKit/chromium/src/android/WebInputEventFactory.cpp 2012-09-12 23:17:00 UTC (rev 128378)
@@ -148,12 +148,21 @@
// WebGestureEvent
+// FIXME: remove this obsolete version
WebGestureEvent WebInputEventFactory::gestureEvent(WebInputEvent::Type type,
double timeStampSeconds,
int x,
int y,
-
[webkit-changes] [128379] trunk/Source/WebCore
Title: [128379] trunk/Source/WebCore
Revision 128379
Author commit-qu...@webkit.org
Date 2012-09-12 16:20:22 -0700 (Wed, 12 Sep 2012)
Log Message
IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible
https://bugs.webkit.org/show_bug.cgi?id=94023
Patch by Alec Flett alecfl...@chromium.org on 2012-09-12
Reviewed by Kentaro Hara.
Transition the put/add/update methods to accept direct ScriptValue
objects rather than SerializedScriptValues, to eliminate lots of
redundant deserialization/serialization steps while storing
values.
Also see https://bugs.webkit.org/show_bug.cgi?id=95409 for
followup get/openCursor work, following this.
No new tests, this is a performance refactor of core IDB
functionality. Most existing tests cover correctness. Tests that
might fail include:
storage/indexeddb/objectstore-basics.html
storage/indexeddb/keypath-basics.html
storage/indexeddb/index-basics.html
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl:
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
* bindings/v8/IDBBindingUtilities.h:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.h
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.h
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl
trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp
trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (128378 => 128379)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 23:17:00 UTC (rev 128378)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 23:20:22 UTC (rev 128379)
@@ -1,3 +1,49 @@
+2012-09-12 Alec Flett alecfl...@chromium.org
+
+IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible
+https://bugs.webkit.org/show_bug.cgi?id=94023
+
+Reviewed by Kentaro Hara.
+
+Transition the put/add/update methods to accept direct ScriptValue
+objects rather than SerializedScriptValues, to eliminate lots of
+redundant deserialization/serialization steps while storing
+values.
+
+Also see https://bugs.webkit.org/show_bug.cgi?id=95409 for
+followup get/openCursor work, following this.
+
+No new tests, this is a performance refactor of core IDB
+functionality. Most existing tests cover correctness. Tests that
+might fail include:
+
+storage/indexeddb/objectstore-basics.html
+storage/indexeddb/keypath-basics.html
+storage/indexeddb/index-basics.html
+
+* Modules/indexeddb/IDBCursor.cpp:
+(WebCore::IDBCursor::update):
+* Modules/indexeddb/IDBCursor.h:
+(IDBCursor):
+* Modules/indexeddb/IDBCursor.idl:
+* Modules/indexeddb/IDBObjectStore.cpp:
+(WebCore::generateIndexKeysForValue):
+(WebCore::IDBObjectStore::add):
+(WebCore::IDBObjectStore::put):
+(WebCore):
+* Modules/indexeddb/IDBObjectStore.h:
+(WebCore::IDBObjectStore::add):
+(WebCore::IDBObjectStore::put):
+(IDBObjectStore):
+* Modules/indexeddb/IDBObjectStore.idl:
+* bindings/v8/IDBBindingUtilities.cpp:
+(WebCore):
+(WebCore::createIDBKeyFromScriptValueAndKeyPath):
+(WebCore::deserializeIDBValue):
+(WebCore::canInjectIDBKeyIntoScriptValue):
+* bindings/v8/IDBBindingUtilities.h:
+(WebCore):
+
2012-09-12 Chris Fleizach cfleiz...@apple.com
AX: svg:image not accessible
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp (128378 => 128379)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp 2012-09-12 23:17:00 UTC (rev 128378)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp 2012-09-12 23:20:22 UTC (rev 128379)
@@ -125,10 +125,9 @@
return m_source.get();
}
-PassRefPtrIDBRequest IDBCursor::update(ScriptExecutionContext* context, PassRefPtrSerializedScriptValue prpValue, ExceptionCode ec)
+PassRefPtrIDBRequest IDBCursor::update(ScriptExecutionContext* context, ScriptValue value, ExceptionCode ec)
{
IDB_TRACE(IDBCursor::update);
-RefPtrSerializedScriptValue value = prpValue;
if (!m_gotValue || isKeyCursor()) {
ec = IDBDatabaseException::IDB_INVALID_STATE_ERR;
@@ -142,17 +141,12 @@
