[webkit-changes] [141381] trunk/Tools

[jochen]

Title: [141381] trunk/Tools








Revision 141381
Author joc...@chromium.org
Date 2013-01-31 00:00:54 -0800 (Thu, 31 Jan 2013)


Log Message
[chromium] move remaining resource load related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=108334

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::allowExternalPages):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::canHandleRequest):
(WebTestRunner::WebTestProxy::cannotHandleRequestError):
(WebTestRunner::WebTestProxy::didCreateDataSource):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::canHandleRequest):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
(WebTestRunner::WebTestProxyBase::didCreateDataSource):
(WebTestRunner::WebTestProxyBase::willSendRequest):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::canHandleRequest):
(WebViewHost::didCreateDataSource):
(WebViewHost::willSendRequest):
(WebViewHost::allowExternalPages):
* DumpRenderTree/chromium/WebViewHost.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (141380 => 141381)

--- trunk/Tools/ChangeLog	2013-01-31 07:24:43 UTC (rev 141380)
+++ trunk/Tools/ChangeLog	2013-01-31 08:00:54 UTC (rev 141381)
@@ -1,3 +1,31 @@
+2013-01-30  Jochen Eisinger  
+
+[chromium] move remaining resource load related methods to TestRunner library
+https://bugs.webkit.org/show_bug.cgi?id=108334
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+(WebTestRunner::WebTestDelegate::allowExternalPages):
+* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
+(WebKit):
+(WebTestProxyBase):
+(WebTestRunner::WebTestProxy::canHandleRequest):
+(WebTestRunner::WebTestProxy::cannotHandleRequestError):
+(WebTestRunner::WebTestProxy::didCreateDataSource):
+* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
+(WebTestRunner::WebTestProxyBase::canHandleRequest):
+(WebTestRunner):
+(WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
+(WebTestRunner::WebTestProxyBase::didCreateDataSource):
+(WebTestRunner::WebTestProxyBase::willSendRequest):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::canHandleRequest):
+(WebViewHost::didCreateDataSource):
+(WebViewHost::willSendRequest):
+(WebViewHost::allowExternalPages):
+* DumpRenderTree/chromium/WebViewHost.h:
+
 2013-01-30  Hajime Morrita  
 
 Unreviewed test failure fix for r141341.


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (141380 => 141381)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h	2013-01-31 07:24:43 UTC (rev 141380)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h	2013-01-31 08:00:54 UTC (rev 141381)
@@ -120,6 +120,7 @@
 virtual void goToOffset(int) { }
 virtual void reload() { }
 virtual void loadURLForFrame(const WebKit::WebURL&, const std::string&) { }
+virtual bool allowExternalPages() { return false; }
 };
 
 }


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (141380 => 141381)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h	2013-01-31 07:24:43 UTC (rev 141380)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h	2013-01-31 08:00:54 UTC (rev 141381)
@@ -32,6 +32,7 @@
 #define WebTestProxy_h
 
 #include "Platform/chromium/public/WebRect.h"
+#include "Platform/chromium/public/WebURLError.h"
 #include "WebKit/chromium/public/WebAccessibilityNotification.h"
 #include "WebKit/chromium/public/WebDragOperation.h"
 #include "WebKit/chromium/public/WebEditingAction.h"
@@ -45,6 +46,7 @@
 namespace WebKit {
 class WebAccessibilityObject;
 class WebCachedURLRequest;
+class WebDataSource;
 class WebDragData;
 class WebFrame;
 class WebImage;
@@ -63,7 +65,6 @@
 struct WebConsoleMessage;
 struct WebPoint;
 struct WebSize;
-struct WebURLError;
 struct WebWindowFeatures;
 }
 
@@ -137,6 +138,9 @@
 void didDetectXSS(WebKit::WebFrame*, const WebKit::WebURL& insecureURL, bool didBlockEntirePage);
 void assignIdentifierToRequest(WebKit::WebFrame*, unsigned identifier, const WebKit::WebURLRequest&);
 void willRequestResource(WebKit::WebFrame*, const WebKit::WebCachedURLRequest&);
+bool canHandleRequest(WebKit::WebFrame*, const WebKit::WebURLRequest&);
+

[webkit-changes] [141379] trunk/LayoutTests

[morrita]

Title: [141379] trunk/LayoutTests








Revision 141379
Author morr...@google.com
Date 2013-01-30 22:05:23 -0800 (Wed, 30 Jan 2013)


Log Message
[Chromium] Unreviewed, marking video-error-does-not-exist.html as a fail.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (141378 => 141379)

--- trunk/LayoutTests/ChangeLog	2013-01-31 06:00:52 UTC (rev 141378)
+++ trunk/LayoutTests/ChangeLog	2013-01-31 06:05:23 UTC (rev 141379)
@@ -1,3 +1,9 @@
+2013-01-30  Hajime Morrita  
+
+[Chromium] Unreviewed, marking video-error-does-not-exist.html as a fail.
+
+* platform/chromium/TestExpectations:
+
 2013-01-30  Kent Tamura  
 
 [Chromium] Rebaline for form-related tests


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141378 => 141379)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-31 06:00:52 UTC (rev 141378)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-31 06:05:23 UTC (rev 141379)
@@ -4404,3 +4404,5 @@
 webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
 webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ]
 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
+
+webkit.org/b/108424 media/video-error-does-not-exist.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141378] trunk/Source/WebCore

[paroga]

Title: [141378] trunk/Source/WebCore








Revision 141378
Author par...@webkit.org
Date 2013-01-30 22:00:52 -0800 (Wed, 30 Jan 2013)


Log Message
Port DragImageWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=108329

Reviewed by Brent Fulgham.

Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.

* PlatformWinCE.cmake:
* platform/win/DragImageWin.cpp:
(WebCore::dragLabelFont):
* platform/wince/DragImageWinCE.cpp: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformWinCE.cmake
trunk/Source/WebCore/platform/win/DragImageWin.cpp


Removed Paths

trunk/Source/WebCore/platform/wince/DragImageWinCE.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141377 => 141378)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 05:27:42 UTC (rev 141377)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 06:00:52 UTC (rev 141378)
@@ -1,3 +1,17 @@
+2013-01-30  Patrick Gansterer  
+
+Port DragImageWin.cpp to WinCE
+https://bugs.webkit.org/show_bug.cgi?id=108329
+
+Reviewed by Brent Fulgham.
+
+Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.
+
+* PlatformWinCE.cmake:
+* platform/win/DragImageWin.cpp:
+(WebCore::dragLabelFont):
+* platform/wince/DragImageWinCE.cpp: Removed.
+
 2013-01-30  Hayato Ito  
 
 Split CSSOMWrapper data and functions out from StyleResolver into its own class.


Modified: trunk/Source/WebCore/PlatformWinCE.cmake (141377 => 141378)

--- trunk/Source/WebCore/PlatformWinCE.cmake	2013-01-31 05:27:42 UTC (rev 141377)
+++ trunk/Source/WebCore/PlatformWinCE.cmake	2013-01-31 06:00:52 UTC (rev 141378)
@@ -38,6 +38,7 @@
 platform/win/ContextMenuWin.cpp
 platform/win/CursorWin.cpp
 platform/win/DragDataWin.cpp
+platform/win/DragImageWin.cpp
 platform/win/EditorWin.cpp
 platform/win/EventLoopWin.cpp
 platform/win/KeyEventWin.cpp
@@ -62,7 +63,6 @@
 platform/win/WidgetWin.cpp
 platform/win/WheelEventWin.cpp
 
-platform/wince/DragImageWince.cpp
 platform/wince/FileSystemWince.cpp
 platform/wince/KURLWince.cpp
 


Modified: trunk/Source/WebCore/platform/win/DragImageWin.cpp (141377 => 141378)

--- trunk/Source/WebCore/platform/win/DragImageWin.cpp	2013-01-31 05:27:42 UTC (rev 141377)
+++ trunk/Source/WebCore/platform/win/DragImageWin.cpp	2013-01-31 06:00:52 UTC (rev 141378)
@@ -108,6 +108,8 @@
 
 static Font dragLabelFont(int size, bool bold, FontRenderingMode renderingMode)
 {
+Font result;
+#if !OS(WINCE)
 NONCLIENTMETRICS metrics;
 metrics.cbSize = sizeof(metrics);
 SystemParametersInfo(SPI_GETNONCLIENTMETRICS, metrics.cbSize, &metrics, 0);
@@ -121,8 +123,9 @@
 description.setSpecifiedSize((float)size);
 description.setComputedSize((float)size);
 description.setRenderingMode(renderingMode);
-Font result = Font(description, 0, 0); 
+result = Font(description, 0, 0);
 result.update(0);
+#endif
 return result;
 }
 


Deleted: trunk/Source/WebCore/platform/wince/DragImageWinCE.cpp (141377 => 141378)

--- trunk/Source/WebCore/platform/wince/DragImageWinCE.cpp	2013-01-31 05:27:42 UTC (rev 141377)
+++ trunk/Source/WebCore/platform/wince/DragImageWinCE.cpp	2013-01-31 06:00:52 UTC (rev 141378)
@@ -1,63 +0,0 @@
-/*
- *  Copyright (C) 2007-2008 Torch Mobile, Inc.
- *
- *  This library is free software; you can redistribute it and/or
- *  modify it under the terms of the GNU Library General Public
- *  License as published by the Free Software Foundation; either
- *  version 2 of the License, or (at your option) any later version.
- *
- *  This library is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- *  Library General Public License for more details.
- *
- *  You should have received a copy of the GNU Library General Public License
- *  along with this library; see the file COPYING.LIB.  If not, write to
- *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- *  Boston, MA 02110-1301, USA.
- *
- */
-
-#include "config.h"
-#include "DragImage.h"
-
-#include "CachedImage.h"
-#include "GraphicsContext.h"
-#include "Image.h"
-
-#include 
-
-namespace WebCore {
-
-IntSize dragImageSize(DragImageRef)
-{
-return IntSize(0, 0);
-}
-
-void deleteDragImage(DragImageRef image)
-{
-if (image)
-::DeleteObject(image);
-}
-
-DragImageRef scaleDragImage(DragImageRef, FloatSize)
-{
-return 0;
-}
-
-DragImageRef dissolveDragImageToFraction(DragImageRef image, float)
-{
-return image;
-}
-
-DragImageRef createDragImageFromImage(Image*, RespectImageOrientationEnum)
-{
-return 0;
-}
-
-DragImageRef createDragImageIconForCachedImage(CachedImage*)
-{
-return 0;
-}
-
-} // namespace WebCore






___
webkit-changes mailing list
webki

[webkit-changes] [141377] trunk/Source/WebKit2

[timothy_horton]

Title: [141377] trunk/Source/WebKit2








Revision 141377
Author timothy_hor...@apple.com
Date 2013-01-30 21:27:42 -0800 (Wed, 30 Jan 2013)


Log Message
Unreviewed build fix after http://trac.webkit.org/changeset/141372.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (141376 => 141377)

--- trunk/Source/WebKit2/ChangeLog	2013-01-31 05:22:01 UTC (rev 141376)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-31 05:27:42 UTC (rev 141377)
@@ -1,3 +1,10 @@
+2013-01-30  Tim Horton  
+
+Unreviewed build fix after http://trac.webkit.org/changeset/141372.
+
+* WebProcess/Plugins/PDF/PDFPlugin.mm:
+(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
+
 2013-01-30  Jae Hyun Park  
 
 Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm (141376 => 141377)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2013-01-31 05:22:01 UTC (rev 141376)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2013-01-31 05:27:42 UTC (rev 141377)
@@ -941,7 +941,7 @@
 
 bool PDFPlugin::performDictionaryLookupAtLocation(const WebCore::FloatPoint& point)
 {
-PDFSelection* lookupSelection = [m_pdfLayerController.get() getSelectionForWordAtPoint:convertFromPluginToPDFView(IntPoint(point))];
+PDFSelection* lookupSelection = [m_pdfLayerController.get() getSelectionForWordAtPoint:convertFromPluginToPDFView(roundedIntPoint(point))];
 
 if ([[lookupSelection string] length])
 [m_pdfLayerController.get() searchInDictionaryWithSelection:lookupSelection];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141376] trunk/Source/WebKit2

[commit-queue]

Title: [141376] trunk/Source/WebKit2








Revision 141376
Author commit-qu...@webkit.org
Date 2013-01-30 21:22:01 -0800 (Wed, 30 Jan 2013)


Log Message
Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer
https://bugs.webkit.org/show_bug.cgi?id=108164

Patch by Jae Hyun Park  on 2013-01-30
Reviewed by Benjamin Poulain.

This is a preparation patch for Threaded Coordinated Graphics.

LayerTreeRenderer should not depend on CoordinatedLayerTreeHostProxy so that it
can be moved to WebCore.  This patch introduces LayerTreeRendererClient which
is implemented in CoordinatedLayerTreeHostProxy. LayerTreeRenderer uses this
client, instead of using CoordinatedLayerTreeHostProxy directly.

* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::animationFrameReady):
(WebKit::LayerTreeRenderer::updateViewport):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeBackingStores):
(WebKit::LayerTreeRenderer::detach):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit):
(LayerTreeRendererClient):
(LayerTreeRenderer):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (141375 => 141376)

--- trunk/Source/WebKit2/ChangeLog	2013-01-31 05:15:30 UTC (rev 141375)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-31 05:22:01 UTC (rev 141376)
@@ -1,3 +1,31 @@
+2013-01-30  Jae Hyun Park  
+
+Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer
+https://bugs.webkit.org/show_bug.cgi?id=108164
+
+Reviewed by Benjamin Poulain.
+
+This is a preparation patch for Threaded Coordinated Graphics.
+
+LayerTreeRenderer should not depend on CoordinatedLayerTreeHostProxy so that it
+can be moved to WebCore.  This patch introduces LayerTreeRendererClient which
+is implemented in CoordinatedLayerTreeHostProxy. LayerTreeRenderer uses this
+client, instead of using CoordinatedLayerTreeHostProxy directly.
+
+* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
+(CoordinatedLayerTreeHostProxy):
+* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
+(WebKit::LayerTreeRenderer::LayerTreeRenderer):
+(WebKit::LayerTreeRenderer::animationFrameReady):
+(WebKit::LayerTreeRenderer::updateViewport):
+(WebKit::LayerTreeRenderer::renderNextFrame):
+(WebKit::LayerTreeRenderer::purgeBackingStores):
+(WebKit::LayerTreeRenderer::detach):
+* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
+(WebKit):
+(LayerTreeRendererClient):
+(LayerTreeRenderer):
+
 2013-01-30  Tim Horton  
 
 PDFPlugin: Should respond to three-finger tap for dictionary definitions


Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h (141375 => 141376)

--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h	2013-01-31 05:15:30 UTC (rev 141375)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h	2013-01-31 05:22:01 UTC (rev 141376)
@@ -26,6 +26,7 @@
 #include "CoordinatedGraphicsArgumentCoders.h"
 #include "CoordinatedLayerInfo.h"
 #include "DrawingAreaProxy.h"
+#include "LayerTreeRenderer.h"
 #include "Region.h"
 #include "SurfaceUpdateInfo.h"
 #include "WebCoordinatedSurface.h"
@@ -46,7 +47,7 @@
 class CoordinatedLayerInfo;
 class LayerTreeRenderer;
 
-class CoordinatedLayerTreeHostProxy {
+class CoordinatedLayerTreeHostProxy : public LayerTreeRendererClient {
 WTF_MAKE_NONCOPYABLE(CoordinatedLayerTreeHostProxy);
 WTF_MAKE_FAST_ALLOCATED;
 public:
@@ -77,8 +78,6 @@
 void clearImageBackingContents(CoordinatedImageBackingID);
 void removeImageBacking(CoordinatedImageBackingID);
 void didReceiveCoordinatedLayerTreeHostProxyMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&);
-void updateViewport();
-void renderNextFrame();
 void didChangeScrollPosition(const WebCore::FloatPoint& position);
 #if USE(GRAPHICS_SURFACE)
 void createCanvas(CoordinatedLayerID, const WebCore::IntSize&, const WebCore::GraphicsSurfaceToken&);
@@ -86,16 +85,22 @@
 void destroyCanvas(CoordinatedLayerID);
 #endif
 void setLayerRepaintCount(CoordinatedLayerID, int value);
-void purgeBackingStores();
 LayerTreeRenderer* layerTreeRenderer() const { return m_renderer.get(); }
 void setLayerAnimations(CoordinatedLayerID, const WebCore::GraphicsLayerAnimations&);
 void setAnimationsLocked(bool);
 #if ENABLE(REQUEST_ANIMAT

[webkit-changes] [141375] trunk/Source

[lforschler]

Title: [141375] trunk/Source








Revision 141375
Author lforsch...@apple.com
Date 2013-01-30 21:15:30 -0800 (Wed, 30 Jan 2013)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (141374 => 141375)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-31 05:11:20 UTC (rev 141374)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-31 05:15:30 UTC (rev 141375)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 29;
+MINOR_VERSION = 30;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (141374 => 141375)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2013-01-31 05:11:20 UTC (rev 141374)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2013-01-31 05:15:30 UTC (rev 141375)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 29;
+MINOR_VERSION = 30;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (141374 => 141375)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-31 05:11:20 UTC (rev 141374)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-31 05:15:30 UTC (rev 141375)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 29;
+MINOR_VERSION = 30;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (141374 => 141375)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-01-31 05:11:20 UTC (rev 141374)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-01-31 05:15:30 UTC (rev 141375)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 29;
+MINOR_VERSION = 30;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141374] tags/Safari-537.29/

[lforschler]

Title: [141374] tags/Safari-537.29/








Revision 141374
Author lforsch...@apple.com
Date 2013-01-30 21:11:20 -0800 (Wed, 30 Jan 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.29/




Diff

Property changes: tags/Safari-537.29



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141373] trunk/Source/WebCore

[hayato]

Title: [141373] trunk/Source/WebCore








Revision 141373
Author hay...@chromium.org
Date 2013-01-30 21:03:58 -0800 (Wed, 30 Jan 2013)


Log Message
Split CSSOMWrapper data and functions out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107779

Reviewed by Dimitri Glazkov.

Factored CSSOMWrapper logic and data out from StyleResolver into a
InspectorCSSOMWrappers class.  Since InspectorCSSOMWrappers
depends on static variables defined in StyleResolver.cpp, this
patch does not extract a new class into a new file, which makes a
review easier since it produces readable diffs.

After we factor static variables related to default style sheets
in a following patch (bug 107780), I'll move
InspectorCSSOMWrappers into a its own file.

No new tests, refactoring only.

* css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets): Renamed from ensureFullCSSOMWrapperForInspector().
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleResolver.h:
(InspectorCSSOMWrappers):
(WebCore):
(StyleResolver):
(WebCore::StyleResolver::inspectorCSSOMWrappers):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::buildObjectForRule):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/StyleResolver.h
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141372 => 141373)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 05:02:03 UTC (rev 141372)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 05:03:58 UTC (rev 141373)
@@ -1,3 +1,43 @@
+2013-01-30  Hayato Ito  
+
+Split CSSOMWrapper data and functions out from StyleResolver into its own class.
+https://bugs.webkit.org/show_bug.cgi?id=107779
+
+Reviewed by Dimitri Glazkov.
+
+Factored CSSOMWrapper logic and data out from StyleResolver into a
+InspectorCSSOMWrappers class.  Since InspectorCSSOMWrappers
+depends on static variables defined in StyleResolver.cpp, this
+patch does not extract a new class into a new file, which makes a
+review easier since it produces readable diffs.
+
+After we factor static variables related to default style sheets
+in a following patch (bug 107780), I'll move
+InspectorCSSOMWrappers into a its own file.
+
+No new tests, refactoring only.
+
+* css/StyleResolver.cpp:
+(WebCore):
+(WebCore::StyleResolver::appendAuthorStyleSheets):
+(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
+(WebCore::InspectorCSSOMWrappers::collect):
+(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents): Name it explicitly rather than overloading.
+(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets): Name it explicitly rather than overloading.
+(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection): Name it explicitly rather than overloading.
+(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets): Renamed from ensureFullCSSOMWrapperForInspector().
+(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):
+(WebCore::StyleResolver::reportMemoryUsage):
+* css/StyleResolver.h:
+(InspectorCSSOMWrappers):
+(WebCore):
+(StyleResolver):
+(WebCore::StyleResolver::inspectorCSSOMWrappers):
+* inspector/InspectorCSSAgent.cpp:
+(WebCore::InspectorCSSAgent::willMatchRule):
+(WebCore::InspectorCSSAgent::willProcessRule):
+(WebCore::InspectorCSSAgent::buildObjectForRule):
+
 2013-01-30  Sheriff Bot  
 
 Unreviewed, rolling out r141358.


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (141372 => 141373)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-31 05:02:03 UTC (rev 141372)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-31 05:03:58 UTC (rev 141373)
@@ -228,8 +228,6 @@
 
 static void loadFullDefaultStyle();
 static void loadSimpleDefaultStyle();
-template 
-static void collectCSSOMWrappers(HashMap >&, ListType*);
 
 // FIXME: It would be nice to use some mechanism that guarantees this is in sync with the real UA stylesheet.
 static const char* simpleUserAgentStyleSheet = "html,body,div{display:block}head{display:none}body{margin:8px}div:fo

[webkit-changes] [141372] trunk/Source/WebKit2

[timothy_horton]

Title: [141372] trunk/Source/WebKit2








Revision 141372
Author timothy_hor...@apple.com
Date 2013-01-30 21:02:03 -0800 (Wed, 30 Jan 2013)


Log Message
PDFPlugin: Should respond to three-finger tap for dictionary definitions
https://bugs.webkit.org/show_bug.cgi?id=108418


Reviewed by Simon Fraser.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Add default implementation of performDictionaryLookupAtLocation.
* WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add getSelectionForWordAtPoint and searchInDictionaryWithSelection.
* WebProcess/Plugins/PDF/PDFPlugin.h: Add performDictionaryLookupAtLocation.
* WebProcess/Plugins/PDF/PDFPlugin.mm: Grab a PDFSelection representing the word encompassing the given point, and
throw up a dictionary popover.
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
* WebProcess/Plugins/PDF/SimplePDFPlugin.h:  Add default implementation of performDictionaryLookupAtLocation.
* WebProcess/Plugins/Plugin.h:  Add performDictionaryLookupAtLocation.
* WebProcess/Plugins/PluginProxy.h: Add default implementation of performDictionaryLookupAtLocation.
* WebProcess/Plugins/PluginView.cpp: 
(WebKit::PluginView::performDictionaryLookupAtLocation): Forward performDictionaryLookupAtLocation to the plugin.
* WebProcess/Plugins/PluginView.h: Add performDictionaryLookupAtLocation.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Intercept performDictionaryLookupAtLocation, and give
the main-frame plugin (if it exists) a chance to handle it.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm
trunk/Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (141371 => 141372)

--- trunk/Source/WebKit2/ChangeLog	2013-01-31 04:57:50 UTC (rev 141371)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-31 05:02:03 UTC (rev 141372)
@@ -1,3 +1,27 @@
+2013-01-30  Tim Horton  
+
+PDFPlugin: Should respond to three-finger tap for dictionary definitions
+https://bugs.webkit.org/show_bug.cgi?id=108418
+
+
+Reviewed by Simon Fraser.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.h: Add default implementation of performDictionaryLookupAtLocation.
+* WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add getSelectionForWordAtPoint and searchInDictionaryWithSelection.
+* WebProcess/Plugins/PDF/PDFPlugin.h: Add performDictionaryLookupAtLocation.
+* WebProcess/Plugins/PDF/PDFPlugin.mm: Grab a PDFSelection representing the word encompassing the given point, and
+throw up a dictionary popover.
+(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
+* WebProcess/Plugins/PDF/SimplePDFPlugin.h:  Add default implementation of performDictionaryLookupAtLocation.
+* WebProcess/Plugins/Plugin.h:  Add performDictionaryLookupAtLocation.
+* WebProcess/Plugins/PluginProxy.h: Add default implementation of performDictionaryLookupAtLocation.
+* WebProcess/Plugins/PluginView.cpp: 
+(WebKit::PluginView::performDictionaryLookupAtLocation): Forward performDictionaryLookupAtLocation to the plugin.
+* WebProcess/Plugins/PluginView.h: Add performDictionaryLookupAtLocation.
+* WebProcess/WebPage/mac/WebPageMac.mm:
+(WebKit::WebPage::performDictionaryLookupAtLocation): Intercept performDictionaryLookupAtLocation, and give
+the main-frame plugin (if it exists) a chance to handle it.
+
 2013-01-30  Gyuyoung Kim  
 
 [WK2] Cleanup MessageID parameter after r141332


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (141371 => 141372)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h	2013-01-31 04:57:50 UTC (rev 141371)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h	2013-01-31 05:02:03 UTC (rev 141372)
@@ -249,6 +249,8 @@
 
 virtual bool getResourceData(const unsigned char*& /* bytes */, unsigned& /* length */) const OVERRIDE { return false; }
 
+virtual bool performDictionaryLookupAtLocation(const WebCore::FloatPoint&) OVERRIDE { return false; }
+
 void updateNPNPrivateMode();
 
 #if PLUGIN_ARCHITECTURE(WIN)


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h (141371 => 141372)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h	2013-01-31 04:57:50 UTC (rev 141371)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h	20

[webkit-changes] [141371] trunk/Source

[commit-queue]

Title: [141371] trunk/Source








Revision 141371
Author commit-qu...@webkit.org
Date 2013-01-30 20:57:50 -0800 (Wed, 30 Jan 2013)


Log Message
Unreviewed, rolling out r141358.
http://trac.webkit.org/changeset/141358
https://bugs.webkit.org/show_bug.cgi?id=108421

breaks android builder (Requested by morrita on #webkit).

Patch by Sheriff Bot  on 2013-01-30

Source/WebCore:

* bindings/v8/custom/V8IntentCustom.cpp:

Source/WebKit/chromium:

* WebKit.gyp:
* features.gypi:
* src/WebFrameImpl.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141370 => 141371)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 04:46:43 UTC (rev 141370)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 04:57:50 UTC (rev 141371)
@@ -1,3 +1,13 @@
+2013-01-30  Sheriff Bot  
+
+Unreviewed, rolling out r141358.
+http://trac.webkit.org/changeset/141358
+https://bugs.webkit.org/show_bug.cgi?id=108421
+
+breaks android builder (Requested by morrita on #webkit).
+
+* bindings/v8/custom/V8IntentCustom.cpp:
+
 2013-01-30  Kentaro Hara  
 
 [V8] Use state->isolate() when state is not 0


Modified: trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp (141370 => 141371)

--- trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp	2013-01-31 04:46:43 UTC (rev 141370)
+++ trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp	2013-01-31 04:57:50 UTC (rev 141371)
@@ -39,8 +39,6 @@
 #include "V8MessagePort.h"
 #include 
 
-#if ENABLE(WEB_INTENTS)
-
 namespace WebCore {
 
 v8::Handle V8Intent::constructorCallbackCustom(const v8::Arguments& args)
@@ -84,6 +82,5 @@
 return wrapper;
 }
 
-} // namespace WebCore
 
-#endif
+} // namespace WebCore


Modified: trunk/Source/WebKit/chromium/ChangeLog (141370 => 141371)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 04:46:43 UTC (rev 141370)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 04:57:50 UTC (rev 141371)
@@ -1,3 +1,15 @@
+2013-01-30  Sheriff Bot  
+
+Unreviewed, rolling out r141358.
+http://trac.webkit.org/changeset/141358
+https://bugs.webkit.org/show_bug.cgi?id=108421
+
+breaks android builder (Requested by morrita on #webkit).
+
+* WebKit.gyp:
+* features.gypi:
+* src/WebFrameImpl.cpp:
+
 2013-01-30  Nico Weber  
 
 [chromium] Build webkit with enable_web_intents set to 0.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (141370 => 141371)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-31 04:46:43 UTC (rev 141370)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-31 04:57:50 UTC (rev 141371)
@@ -794,19 +794,6 @@
 }],
 ],
 }],
-['enable_web_intents==0', {
-  'sources!': [
-'public/WebDeliveredIntentClient.h',
-'public/WebIntent.h',
-'public/WebIntentRequest.h',
-'public/WebIntentServiceInfo.h',
-'src/DeliveredIntentClientImpl.cpp',
-'src/DeliveredIntentClientImpl.h',
-'src/WebIntent.cpp',
-'src/WebIntentRequest.cpp',
-'src/WebIntentServiceInfo.cpp',
-  ],
-}],
 ['use_default_render_theme==1', {
 'include_dirs': [
 'public/default',


Modified: trunk/Source/WebKit/chromium/features.gypi (141370 => 141371)

--- trunk/Source/WebKit/chromium/features.gypi	2013-01-31 04:46:43 UTC (rev 141370)
+++ trunk/Source/WebKit/chromium/features.gypi	2013-01-31 04:57:50 UTC (rev 141371)
@@ -130,7 +130,7 @@
   'ENABLE_VIDEO_TRACK=1',
   'ENABLE_VIEWPORT=1',
   'ENABLE_WEBGL=1',
-  'ENABLE_WEB_INTENTS=<(enable_web_intents)',
+  'ENABLE_WEB_INTENTS=1',
   'ENABLE_WEB_SOCKETS=1',
   'ENABLE_WEB_TIMING=1',
   'ENABLE_WORKERS=1',
@@ -231,6 +231,11 @@
   'ENABLE_OPENTYPE_VERTICAL=1',
 ],
   }],
+  ['enable_web_intents==1', {
+'feature_defines': [
+  'ENABLE_WEB_INTENTS=1',
+],
+  }],
   ['enable_web_intents_tag==1', {
 'feature_defines': [
   'ENABLE_WEB_INTENTS_TAG=1',


Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (141370 => 141371)

--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp	2013-01-31 04:46:43 UTC (rev 141370)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp	2013-01-31 04:57:50 UTC (rev 141371)
@@ -83,6 +83,8 @@
 #include "DOMWindow.h"
 #include "DOMWindowIntents.h"
 #include "DOMWrapperWorld.h"
+#include "DeliveredIntent.h"
+#include "DeliveredIntentClientImpl.h"
 #include "DirectoryEntry.h"
 #in

[webkit-changes] [141370] trunk/Source

[lforschler]

Title: [141370] trunk/Source








Revision 141370
Author lforsch...@apple.com
Date 2013-01-30 20:46:43 -0800 (Wed, 30 Jan 2013)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (141369 => 141370)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-31 04:42:29 UTC (rev 141369)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-31 04:46:43 UTC (rev 141370)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 28;
+MINOR_VERSION = 29;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (141369 => 141370)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2013-01-31 04:42:29 UTC (rev 141369)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2013-01-31 04:46:43 UTC (rev 141370)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 28;
+MINOR_VERSION = 29;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (141369 => 141370)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-31 04:42:29 UTC (rev 141369)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-31 04:46:43 UTC (rev 141370)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 28;
+MINOR_VERSION = 29;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (141369 => 141370)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-01-31 04:42:29 UTC (rev 141369)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-01-31 04:46:43 UTC (rev 141370)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 28;
+MINOR_VERSION = 29;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141369] trunk/Tools

[morrita]

Title: [141369] trunk/Tools








Revision 141369
Author morr...@google.com
Date 2013-01-30 20:42:29 -0800 (Wed, 30 Jan 2013)


Log Message
Unreviewed test failure fix for r141341.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py
trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (141368 => 141369)

--- trunk/Tools/ChangeLog	2013-01-31 04:32:21 UTC (rev 141368)
+++ trunk/Tools/ChangeLog	2013-01-31 04:42:29 UTC (rev 141369)
@@ -1,3 +1,11 @@
+2013-01-30  Hajime Morrita  
+
+Unreviewed test failure fix for r141341.
+
+* Scripts/webkitpy/tool/steps/runtests.py:
+(RunTests.run):
+* Scripts/webkitpy/tool/steps/runtests_unittest.py:
+
 2013-01-30  Levi Weintraub  
 
 [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs


Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (141368 => 141369)

--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py	2013-01-31 04:32:21 UTC (rev 141368)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py	2013-01-31 04:42:29 UTC (rev 141369)
@@ -90,8 +90,9 @@
 "--quiet",
 ])
 
-if sys.platform != "cygwin":
-args.append("--skip-failing-test")
+if sys.platform != "cygwin":
+args.append("--skip-failing-test")
+
 if self._options.quiet:
 args.append("--quiet")
 


Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py (141368 => 141369)

--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py	2013-01-31 04:32:21 UTC (rev 141368)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py	2013-01-31 04:42:29 UTC (rev 141369)
@@ -41,6 +41,6 @@
 expected_logs = """Running WebKit unit tests
 MOCK run_and_throw_if_fail: ['mock-run-webkit-unit-tests'], cwd=/mock-checkout
 Running run-webkit-tests
-MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--skip-failing-tests', '--exit-after-n-failures=30', '--quiet'], cwd=/mock-checkout
+MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet', '--skip-failing-test'], cwd=/mock-checkout
 """
 OutputCapture().assert_outputs(self, step.run, [{}], expected_logs=expected_logs)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141368] trunk/Source/WebCore

[haraken]

Title: [141368] trunk/Source/WebCore








Revision 141368
Author hara...@chromium.org
Date 2013-01-30 20:32:21 -0800 (Wed, 30 Jan 2013)


Log Message
[V8] Use state->isolate() when state is not 0
https://bugs.webkit.org/show_bug.cgi?id=107674

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141367 => 141368)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 04:07:38 UTC (rev 141367)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 04:32:21 UTC (rev 141368)
@@ -1,3 +1,16 @@
+2013-01-30  Kentaro Hara  
+
+[V8] Use state->isolate() when state is not 0
+https://bugs.webkit.org/show_bug.cgi?id=107674
+
+Reviewed by Adam Barth.
+
+No tests. No change in behavior.
+
+* bindings/v8/ScriptProfiler.cpp:
+(WebCore::ScriptProfiler::start):
+(WebCore::ScriptProfiler::stop):
+
 2013-01-30  Adam Barth  
 
 The background HTML parser should be able to parse speculatively


Modified: trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp (141367 => 141368)

--- trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp	2013-01-31 04:07:38 UTC (rev 141367)
+++ trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp	2013-01-31 04:32:21 UTC (rev 141368)
@@ -59,7 +59,7 @@
 profileNameIdleTimeMap->add(title, 0);
 
 v8::HandleScope hs;
-v8::CpuProfiler::StartProfiling(v8String(title, v8::Isolate::GetCurrent()));
+v8::CpuProfiler::StartProfiling(v8String(title, state ? state->isolate() : v8::Isolate::GetCurrent()));
 }
 
 void ScriptProfiler::startForPage(Page*, const String& title)
@@ -78,7 +78,7 @@
 {
 v8::HandleScope hs;
 const v8::CpuProfile* profile = "" ?
-v8::CpuProfiler::StopProfiling(v8String(title, v8::Isolate::GetCurrent()), state->context()->GetSecurityToken()) :
+v8::CpuProfiler::StopProfiling(v8String(title, state->isolate()), state->context()->GetSecurityToken()) :
 v8::CpuProfiler::StopProfiling(v8String(title, v8::Isolate::GetCurrent()));
 if (!profile)
 return 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141365] trunk/LayoutTests

[keishi]

Title: [141365] trunk/LayoutTests








Revision 141365
Author kei...@webkit.org
Date 2013-01-30 19:38:18 -0800 (Wed, 30 Jan 2013)


Log Message
[Chromium] Re-enabling fast/workers/storage tests after fix(r141320).

Unreviewed. Gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (141364 => 141365)

--- trunk/LayoutTests/ChangeLog	2013-01-31 03:14:21 UTC (rev 141364)
+++ trunk/LayoutTests/ChangeLog	2013-01-31 03:38:18 UTC (rev 141365)
@@ -1,3 +1,11 @@
+2013-01-30  Keishi Hattori  
+
+[Chromium] Re-enabling fast/workers/storage tests after fix(r141320).
+
+Unreviewed. Gardening.
+
+* platform/chromium/TestExpectations:
+
 2013-01-30  Adam Barth  
 
 The background HTML parser should be able to parse speculatively


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141364 => 141365)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-31 03:14:21 UTC (rev 141364)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-31 03:38:18 UTC (rev 141365)
@@ -4412,17 +4412,6 @@
 webkit.org/b/108286 platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down.html [ ImageOnlyFailure ]
 webkit.org/b/108286 platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down.html [ ImageOnlyFailure ]
 
-# Crashing after r141166
-webkit.org/b/108285 [ Debug ] fast/workers/storage/change-version-sync.html [ Crash ]
-webkit.org/b/108285 [ Debug ] fast/workers/storage/multiple-transactions-on-different-handles-sync.html [ Crash ]
-webkit.org/b/108285 [ Debug ] fast/workers/storage/multiple-transactions.html [ Crash ]
-webkit.org/b/108285 [ Debug ] fast/workers/storage/open-database-empty-version-sync.html [ Crash ]
-webkit.org/b/108285 [ Debug ] fast/workers/storage/open-database-set-empty-version-sync.html [ Crash ]
-webkit.org/b/108285 [ Debug ] fast/workers/storage/open-database-while-transaction-in-progress.html [ Crash ]
-webkit.org/b/108285 [ Debug ] fast/workers/storage/sql-data-types-sync.html [ Crash ]
-webkit.org/b/108285 [ Debug ] fast/workers/storage/test-authorizer-sync.html [ Crash ]
-webkit.org/b/108285 [ Debug ] http/tests/workers/terminate-during-sync-operation.html [ Crash ]
-
 # Spellchecker behavior tests.
 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
 webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141364] trunk/Source/JavaScriptCore

[fpizlo]

Title: [141364] trunk/Source/_javascript_Core








Revision 141364
Author fpi...@apple.com
Date 2013-01-30 19:14:21 -0800 (Wed, 30 Jan 2013)


Log Message
DFG bytecode parser should have more assertions about the status of local accesses
https://bugs.webkit.org/show_bug.cgi?id=108417

Reviewed by Mark Hahnenberg.

Assert some things that we already know to be true, just to reassure ourselves that they are true.
This is meant as a prerequisite for https://bugs.webkit.org/show_bug.cgi?id=108414, which will
make these rules even stricter.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (141363 => 141364)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-31 02:40:33 UTC (rev 141363)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-31 03:14:21 UTC (rev 141364)
@@ -1,3 +1,18 @@
+2013-01-30  Filip Pizlo  
+
+DFG bytecode parser should have more assertions about the status of local accesses
+https://bugs.webkit.org/show_bug.cgi?id=108417
+
+Reviewed by Mark Hahnenberg.
+
+Assert some things that we already know to be true, just to reassure ourselves that they are true.
+This is meant as a prerequisite for https://bugs.webkit.org/show_bug.cgi?id=108414, which will
+make these rules even stricter.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::getLocal):
+(JSC::DFG::ByteCodeParser::getArgument):
+
 2013-01-30  Mark Hahnenberg  
 
 Objective-C API: JSContext's dealloc causes ASSERT due to ordering of releases


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (141363 => 141364)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2013-01-31 02:40:33 UTC (rev 141363)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2013-01-31 03:14:21 UTC (rev 141364)
@@ -299,7 +299,8 @@
 node = injectLazyOperandSpeculation(addToGraph(GetLocal, OpInfo(variableAccessData), node));
 m_currentBlock->variablesAtTail.local(operand) = node;
 return node;
-}
+} else
+ASSERT(node->op() == SetLocal);
 }
 
 ASSERT(node->op() != Flush);
@@ -314,7 +315,11 @@
 // Make sure we link to the Phi node, not to the GetLocal.
 if (node->op() == GetLocal)
 node = node->child1().node();
+else
+ASSERT(node->op() == SetLocal);
 
+ASSERT(node->op() == SetLocal || node->op() == Phi);
+
 Node* newGetLocal = injectLazyOperandSpeculation(
 addToGraph(GetLocal, OpInfo(node->variableAccessData()), node));
 m_currentBlock->variablesAtTail.local(operand) = newGetLocal;
@@ -380,7 +385,8 @@
 node = injectLazyOperandSpeculation(addToGraph(GetLocal, OpInfo(variableAccessData), node));
 m_currentBlock->variablesAtTail.argument(argument) = node;
 return node;
-}
+} else
+ASSERT(node->op() == SetLocal || node->op() == SetArgument);
 }
 
 ASSERT(node->op() != Flush);
@@ -400,6 +406,9 @@
 if (isCaptured) {
 if (node->op() == GetLocal)
 node = node->child1().node();
+else
+ASSERT(node->op() == SetLocal || node->op() == SetArgument);
+ASSERT(node->op() == SetLocal || node->op() == SetArgument || node->op() == Phi);
 return injectLazyOperandSpeculation(addToGraph(GetLocal, OpInfo(node->variableAccessData()), node));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141360] trunk/Source/WebCore

[commit-queue]

Title: [141360] trunk/Source/WebCore








Revision 141360
Author commit-qu...@webkit.org
Date 2013-01-30 18:21:05 -0800 (Wed, 30 Jan 2013)


Log Message
[V8] Add IDL 'enum' support to CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=106553

Patch by Nils Barth  on 2013-01-30
Reviewed by Kentaro Hara.

Add partial support for Web IDL enumerations in V8 bindings

Binding generators currently cannot handle IDL enumerations.
(An enumeration is an DOMString with a limited set of values, thus
treated internally as DOMString, with validation code added in
bindings.)
This adds support for enumerations in V8, adding validation checking
to setters.
It does not add validation checking to operations (no test case), and
does not add support in JSC.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)

* bindings/scripts/IDLParser.pm:
 - Parser assumes all IDL definitions are interfaces; add support for
   other definitions
 - Parser parses but discards enum definitions; instead, record
   parsed data
(Parse): Sort definitions into interfaces and enums.
Remove "@definitions eq (someIdlDocument)" test, as this never
happens (fossil code) -- parseDefinitions returns list of definitions,
never a one-item list consisting of a document (no nested documents).
(unquoteString): new utility function to unquote StringToken (token
itself still quoted)
(parseEnum):
(parseEnumValueList):
(parseEnumValues):
(parseEnumOld):

* bindings/scripts/CodeGenerator.pm:
 - Expose parsed enum data to backends (detect enums, list valid
   values)
 - Enums treated as DOMString type in internal function
(ProcessDocument):
(IsEnumType):
(ValidEnumValues):
(IsRefPtrType):
* bindings/scripts/CodeGeneratorV8.pm:
 - Enums treated as DOMString type in internal functions
 - Add validation to setter
(GenerateNormalAttrSetter):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):
(ConvertToV8StringResource):
* bindings/scripts/test/TestObj.idl:
 - New enum type and enum variable test for IDL enumeration support
* bindings/scripts/test/V8/V8TestObj.cpp:
 - Generated code, desired behavior
(WebCore::TestObjV8Internal::enumAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enumAttrAttrSetter):
(WebCore):
* bindings/scripts/test/JS/JSTestObj.cpp:
 - Generated code, currently incorrect
(WebCore):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
* bindings/scripts/test/JS/JSTestObj.h:
 - Generated code, currently incorrect
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141359 => 141360)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 02:19:23 UTC (rev 141359)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 02:21:05 UTC (rev 141360)
@@ -1,3 +1,72 @@
+2013-01-30  Nils Barth  
+
+[V8] Add IDL 'enum' support to CodeGeneratorV8.pm
+https://bugs.webkit.org/show_bug.cgi?id=106553
+
+Reviewed by Kentaro Hara.
+
+Add partial support for Web IDL enumerations in V8 bindings
+
+Binding generators currently cannot handle IDL enumerations.
+(An enumeration is an DOMString with a limited set of values, thus
+treated internally as DOMString, with validation code added in
+bindings.)
+This adds support for enumerations in V8, adding validation checking
+to setters.
+It does not add validation checking to operations (no test case), and
+does not add support in JSC.
+
+Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
+
+* bindings/scripts/IDLParser.pm:
+ - Parser assumes all IDL definitions are interfaces; add support for
+   other definitions
+ - Parser parses but discards enum definitions; instead, record
+   parsed data
+(Parse): Sort definitions into interfaces and enums.
+Remove "@definitions eq (someIdlDocument)" test, as this never
+happens (fossil code) -- parseDefinitions returns list of definitions,
+never a one-item list consisting of a document (no nested documents).
+(unquoteString): new utility function to unquote StringToken (token
+itself still quoted)
+(parseEnum):
+(parseEnumValueList):
+(parseEnumValues):
+(parseEnumOld):
+
+* bindings/scripts/CodeGenerator.pm:
+ - Expose parsed enum data to backends (detect enums, list valid
+   values)
+ - Enums treated as DOMString type in internal function
+(ProcessDocument):
+(IsEnumType):
+(ValidEnumValues):
+(IsRefPtrType):
+   

[webkit-changes] [141359] trunk/Source/WebKit2

[timothy_horton]

Title: [141359] trunk/Source/WebKit2








Revision 141359
Author timothy_hor...@apple.com
Date 2013-01-30 18:19:23 -0800 (Wed, 30 Jan 2013)


Log Message
PDFPlugin: Update scrollbars if PDFLayerController's display mode changes
https://bugs.webkit.org/show_bug.cgi?id=108412


Reviewed by Simon Fraser.

* WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add pdfLayerController:didChangeDisplayMode:
* WebProcess/Plugins/PDF/PDFPlugin.h: Add notifyDisplayModeChanged().
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeDisplayMode:]): Forward didChangeDisplayMode to notifyDisplayModeChanged.
(WebKit::PDFPlugin::notifyDisplayModeChanged): Update content size and scrollbar size when display mode changes.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (141358 => 141359)

--- trunk/Source/WebKit2/ChangeLog	2013-01-31 02:17:35 UTC (rev 141358)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-31 02:19:23 UTC (rev 141359)
@@ -1,3 +1,17 @@
+2013-01-30  Tim Horton  
+
+PDFPlugin: Update scrollbars if PDFLayerController's display mode changes
+https://bugs.webkit.org/show_bug.cgi?id=108412
+
+
+Reviewed by Simon Fraser.
+
+* WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add pdfLayerController:didChangeDisplayMode:
+* WebProcess/Plugins/PDF/PDFPlugin.h: Add notifyDisplayModeChanged().
+* WebProcess/Plugins/PDF/PDFPlugin.mm:
+(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeDisplayMode:]): Forward didChangeDisplayMode to notifyDisplayModeChanged.
+(WebKit::PDFPlugin::notifyDisplayModeChanged): Update content size and scrollbar size when display mode changes.
+
 2013-01-30  Alexey Proskuryakov  
 
  PPT: Make loading file URLs work with a sandboxed NetworkProcess


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h (141358 => 141359)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h	2013-01-31 02:17:35 UTC (rev 141358)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h	2013-01-31 02:19:23 UTC (rev 141359)
@@ -37,6 +37,7 @@
 - (void)pdfLayerController:(PDFLayerController *)pdfLayerController didChangeActiveAnnotation:(PDFAnnotation *)annotation;
 - (void)pdfLayerController:(PDFLayerController *)pdfLayerController clickedLinkWithURL:(NSURL *)url;
 - (void)pdfLayerController:(PDFLayerController *)pdfLayerController didChangeContentScaleFactor:(CGFloat)scaleFactor;
+- (void)pdfLayerController:(PDFLayerController *)pdfLayerController didChangeDisplayMode:(int)mode;
 
 @end
 


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h (141358 => 141359)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h	2013-01-31 02:17:35 UTC (rev 141358)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h	2013-01-31 02:19:23 UTC (rev 141359)
@@ -70,6 +70,7 @@
 
 using ScrollableArea::notifyScrollPositionChanged;
 void notifyContentScaleFactorChanged(CGFloat scaleFactor);
+void notifyDisplayModeChanged(int);
 
 void clickedLink(NSURL *);
 void saveToPDF();


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm (141358 => 141359)

--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2013-01-31 02:17:35 UTC (rev 141358)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm	2013-01-31 02:19:23 UTC (rev 141359)
@@ -187,6 +187,11 @@
 _pdfPlugin->notifyContentScaleFactorChanged(scaleFactor);
 }
 
+- (void)pdfLayerController:(PDFLayerController *)pdfLayerController didChangeDisplayMode:(int)mode
+{
+_pdfPlugin->notifyDisplayModeChanged(mode);
+}
+
 @end
 
 namespace WebKit {
@@ -751,6 +756,12 @@
 updateScrollbars();
 }
 
+void PDFPlugin::notifyDisplayModeChanged(int)
+{
+calculateSizes();
+updateScrollbars();
+}
+
 void PDFPlugin::saveToPDF()
 {
 // FIXME: We should probably notify the user that they can't save before the document is finished loading.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [141358] trunk/Source

[thakis]

Title: [141358] trunk/Source








Revision 141358
Author tha...@chromium.org
Date 2013-01-30 18:17:35 -0800 (Wed, 30 Jan 2013)


Log Message
[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408

Reviewed by Kentaro Hara.

I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.

Source/WebCore:

* bindings/v8/custom/V8IntentCustom.cpp:

Source/WebKit/chromium:

* WebKit.gyp:
* features.gypi:
* src/WebFrameImpl.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141357 => 141358)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 02:15:03 UTC (rev 141357)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 02:17:35 UTC (rev 141358)
@@ -1,3 +1,16 @@
+2013-01-30  Nico Weber  
+
+[chromium] Build webkit with enable_web_intents set to 0.
+https://bugs.webkit.org/show_bug.cgi?id=108408
+
+Reviewed by Kentaro Hara.
+
+I'll then make chromium build fine with that, then switch
+enable_web_intents to 0, roll that into webkit, and then
+actually remove the code hidden behind this flag.
+
+* bindings/v8/custom/V8IntentCustom.cpp:
+
 2013-01-30  Joshua Bell  
 
 IndexedDB: Remove speculative dispatchEvent crash fix now that root cause is addressed


Modified: trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp (141357 => 141358)

--- trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp	2013-01-31 02:15:03 UTC (rev 141357)
+++ trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp	2013-01-31 02:17:35 UTC (rev 141358)
@@ -39,6 +39,8 @@
 #include "V8MessagePort.h"
 #include 
 
+#if ENABLE(WEB_INTENTS)
+
 namespace WebCore {
 
 v8::Handle V8Intent::constructorCallbackCustom(const v8::Arguments& args)
@@ -82,5 +84,6 @@
 return wrapper;
 }
 
+} // namespace WebCore
 
-} // namespace WebCore
+#endif


Modified: trunk/Source/WebKit/chromium/ChangeLog (141357 => 141358)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 02:15:03 UTC (rev 141357)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 02:17:35 UTC (rev 141358)
@@ -1,3 +1,18 @@
+2013-01-30  Nico Weber  
+
+[chromium] Build webkit with enable_web_intents set to 0.
+https://bugs.webkit.org/show_bug.cgi?id=108408
+
+Reviewed by Kentaro Hara.
+
+I'll then make chromium build fine with that, then switch
+enable_web_intents to 0, roll that into webkit, and then
+actually remove the code hidden behind this flag.
+
+* WebKit.gyp:
+* features.gypi:
+* src/WebFrameImpl.cpp:
+
 2013-01-30  Levi Weintraub  
 
 [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (141357 => 141358)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-31 02:15:03 UTC (rev 141357)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-31 02:17:35 UTC (rev 141358)
@@ -794,6 +794,19 @@
 }],
 ],
 }],
+['enable_web_intents==0', {
+  'sources!': [
+'public/WebDeliveredIntentClient.h',
+'public/WebIntent.h',
+'public/WebIntentRequest.h',
+'public/WebIntentServiceInfo.h',
+'src/DeliveredIntentClientImpl.cpp',
+'src/DeliveredIntentClientImpl.h',
+'src/WebIntent.cpp',
+'src/WebIntentRequest.cpp',
+'src/WebIntentServiceInfo.cpp',
+  ],
+}],
 ['use_default_render_theme==1', {
 'include_dirs': [
 'public/default',


Modified: trunk/Source/WebKit/chromium/features.gypi (141357 => 141358)

--- trunk/Source/WebKit/chromium/features.gypi	2013-01-31 02:15:03 UTC (rev 141357)
+++ trunk/Source/WebKit/chromium/features.gypi	2013-01-31 02:17:35 UTC (rev 141358)
@@ -130,7 +130,7 @@
   'ENABLE_VIDEO_TRACK=1',
   'ENABLE_VIEWPORT=1',
   'ENABLE_WEBGL=1',
-  'ENABLE_WEB_INTENTS=1',
+  'ENABLE_WEB_INTENTS=<(enable_web_intents)',
   'ENABLE_WEB_SOCKETS=1',
   'ENABLE_WEB_TIMING=1',
   'ENABLE_WORKERS=1',
@@ -231,11 +231,6 @@
   'ENABLE_OPENTYPE_VERTICAL=1',
 ],
   }],
-  ['enable_web_intents==1', {
-'feature_defines': [
-  'ENABLE_WEB_INTENTS=1',
-],
-  }],
   ['enable_web_intents_tag==1', {
 'feature_defines': [
   'ENABLE_WEB_INTENTS_TAG=1',


Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

[webkit-changes] [141357] trunk

[leviw]

Title: [141357] trunk








Revision 141357
Author le...@chromium.org
Date 2013-01-30 18:15:03 -0800 (Wed, 30 Jan 2013)


Log Message
[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
https://bugs.webkit.org/show_bug.cgi?id=108381

Reviewed by James Robinson.

Source/WebKit/chromium:

WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::requestTouchEventType):

Tools:

* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.

LayoutTests:

* platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
* platform/chromium/plugins/re-request-touch-events-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp


Added Paths

trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt
trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (141356 => 141357)

--- trunk/LayoutTests/ChangeLog	2013-01-31 02:13:12 UTC (rev 141356)
+++ trunk/LayoutTests/ChangeLog	2013-01-31 02:15:03 UTC (rev 141357)
@@ -1,3 +1,13 @@
+2013-01-30  Levi Weintraub  
+
+[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
+https://bugs.webkit.org/show_bug.cgi?id=108381
+
+Reviewed by James Robinson.
+
+* platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
+* platform/chromium/plugins/re-request-touch-events-crash.html: Added.
+
 2013-01-30  Rouslan Solomakhin  
 
 Tests for spellcheck behavior


Added: trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt (0 => 141357)

--- trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt	2013-01-31 02:15:03 UTC (rev 141357)
@@ -0,0 +1,5 @@
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
+This test ensures that we don't imbalance the touch event handler count if a plugin requests touch events more than once. The test passes if there are no touch event listeners after the plugin is removed, and there is no crash. Must be run in DRT.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


Added: trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html (0 => 141357)

--- trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html	2013-01-31 02:15:03 UTC (rev 141357)
@@ -0,0 +1,25 @@
+
+
+
+
+
+
+

+