[webkit-changes] [142969] trunk/Source/WebCore

2013-02-14 Thread yurys
Title: [142969] trunk/Source/WebCore








Revision 142969
Author yu...@chromium.org
Date 2013-02-14 23:45:16 -0800 (Thu, 14 Feb 2013)


Log Message
Web Inspector: always show memory size in Mb on the native memory graph
https://bugs.webkit.org/show_bug.cgi?id=109813

Reviewed by Pavel Feldman.

Memory size vlue is alway shown in Mb on the native memory graph.

* inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NativeMemoryGraph.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (142968 => 142969)

--- trunk/Source/WebCore/ChangeLog	2013-02-15 07:15:01 UTC (rev 142968)
+++ trunk/Source/WebCore/ChangeLog	2013-02-15 07:45:16 UTC (rev 142969)
@@ -1,3 +1,15 @@
+2013-02-14  Yury Semikhatsky  
+
+Web Inspector: always show memory size in Mb on the native memory graph
+https://bugs.webkit.org/show_bug.cgi?id=109813
+
+Reviewed by Pavel Feldman.
+
+Memory size vlue is alway shown in Mb on the native memory graph.
+
+* inspector/front-end/NativeMemoryGraph.js:
+(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):
+
 2013-02-14  Andrey Adaikin  
 
 Use GL typedefs in WebGLRenderingContext.idl


Modified: trunk/Source/WebCore/inspector/front-end/NativeMemoryGraph.js (142968 => 142969)

--- trunk/Source/WebCore/inspector/front-end/NativeMemoryGraph.js	2013-02-15 07:15:01 UTC (rev 142968)
+++ trunk/Source/WebCore/inspector/front-end/NativeMemoryGraph.js	2013-02-15 07:45:16 UTC (rev 142969)
@@ -79,7 +79,9 @@
 
 updateCurrentValue: function(countersEntry)
 {
-this._value.textContent = Number.bytesToString(this.valueGetter(countersEntry));
+var bytes = this.valueGetter(countersEntry);
+var megabytes =  bytes / (1024 * 1024);
+this._value.textContent = WebInspector.UIString("%.1f\u2009MB", megabytes);
 },
 
 clearCurrentValueAndMarker: function(ctx)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [142968] trunk/Source/WebKit2

2013-02-14 Thread commit-queue
Title: [142968] trunk/Source/WebKit2








Revision 142968
Author commit-qu...@webkit.org
Date 2013-02-14 23:15:01 -0800 (Thu, 14 Feb 2013)


Log Message
[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=109885

Patch by Huang Dongsung  on 2013-02-14
Reviewed by Simon Fraser.

Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it
scrollOffset. So this patch corrects this misnaming.

In addition, all subclasses of LayerTreeHost don't use the misnamed
scrollOffset in scrollNonCompositedContents(), so this patch removes the
scrollOffset argument.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scroll):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scroll):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h
trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (142967 => 142968)

--- trunk/Source/WebKit2/ChangeLog	2013-02-15 07:01:31 UTC (rev 142967)
+++ trunk/Source/WebKit2/ChangeLog	2013-02-15 07:15:01 UTC (rev 142968)
@@ -1,3 +1,50 @@
+2013-02-14  Huang Dongsung  
+
+[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
+https://bugs.webkit.org/show_bug.cgi?id=109885
+
+Reviewed by Simon Fraser.
+
+Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it
+scrollOffset. So this patch corrects this misnaming.
+
+In addition, all subclasses of LayerTreeHost don't use the misnamed
+scrollOffset in scrollNonCompositedContents(), so this patch removes the
+scrollOffset argument.
+
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+(WebKit::WebChromeClient::scroll):
+* WebProcess/WebCoreSupport/WebChromeClient.h:
+(WebChromeClient):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
+(CoordinatedLayerTreeHost):
+* WebProcess/WebPage/DrawingArea.h:
+(DrawingArea):
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::scroll):
+* WebProcess/WebPage/DrawingAreaImpl.h:
+(DrawingAreaImpl):
+* WebProcess/WebPage/LayerTreeHost.h:
+(LayerTreeHost):
+* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
+(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):
+* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
+(LayerTreeHostGtk):
+* WebProcess/WebPage/mac/LayerTreeHostMac.h:
+(LayerTreeHostMac):
+* WebProcess/WebPage/mac/LayerTreeHostM

[webkit-changes] [142966] trunk/Source/JavaScriptCore

2013-02-14 Thread ggaren
Title: [142966] trunk/Source/_javascript_Core








Revision 142966
Author gga...@apple.com
Date 2013-02-14 22:41:10 -0800 (Thu, 14 Feb 2013)


Log Message
Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660

Reviewed by Sam Weinig.

This has a few benefits:

(*) Saves a few kB by removing a second cache data structure.

(*) Reduces the worst case memory usage of the cache by 1.75X. (Heavy
use of 'new Function' and other techniques could cause us to fill
both root caches, and they didn't trade off against each other.)

(*) Paves the way for future improvements based on a non-trivial
cache key (for example, shrinkable pointer to the key string, and
more precise cache size accounting).

Also cleaned up the cache implementation and simplified it a bit.

* heap/Handle.h:
(HandleBase):
* heap/Strong.h:
(Strong): Build!

* runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode): Updated for three interface changes:

(*) SourceCodeKey is a class, not a pair.

(*) Table values are abstract pointers, since they can be executables
or code blocks. (In a future patch, I'd like to change this so we
always store only code blocks. But that's too much for one patch.)

(*) The cache function is named "set" because it always overwrites
unconditionally.

* runtime/CodeCache.h:
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear): Added support for specifying hash traits, so we
can use a SourceCodeKey.

Removed side table and random number generator to save space and reduce
complexity. Hash tables are already random, so we don't need another source
of randomness.

(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue): A SourceCodeKey is just a
fancy triplet: source code string; function name (or null, for non-functions);
and flags. Flags and function name distinguish between functions and programs
with identical code, so they can live in the same cache.

I chose to use the source code string as the primary hashing reference
because it's likely to be unique. We can use profiling to choose another
technique in future, if collisions between functions and programs prove
to be hot. I suspect they won't.

(JSC::CodeCache::clear):
(CodeCache): Removed the second cache.

* heap/Handle.h:
(HandleBase):
* heap/Strong.h:
(Strong):
* runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
* runtime/CodeCache.h:
(JSC):
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear):
(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue):
(JSC::CodeCache::clear):
(CodeCache):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Handle.h
trunk/Source/_javascript_Core/heap/Strong.h
trunk/Source/_javascript_Core/runtime/CodeCache.cpp
trunk/Source/_javascript_Core/runtime/CodeCache.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (142965 => 142966)

--- trunk/Source/_javascript_Core/ChangeLog	2013-02-15 06:39:03 UTC (rev 142965)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-15 06:41:10 UTC (rev 142966)
@@ -1,3 +1,109 @@
+2013-02-14  Geoffrey Garen  
+
+Merged the global function cache into the source code cache
+https://bugs.webkit.org/show_bug.cgi?id=108660
+
+Reviewed by Sam Weinig.
+
+This has a few benefits:
+
+(*) Saves a few kB by removing a second cache data structure.
+
+(*) Reduces the worst case memory usage of the cache by 1.75X. (Heavy
+use of 'new Function' and other techniques could cause us to fill
+both root caches, and they didn't trade off against each other.)
+
+(*) Paves the way for future improvements based on a non-trivial
+cache key (for example, shrinkable pointer to the key string, and
+more precise cache size accounting).
+
+Also cleaned up the cache implementation and simplified it a bit.
+
+* heap/Handle.h:
+(HandleBase):
+* heap/Strong.h:
+(Strong): Build!
+
+* runtime/CodeCache.cpp:
+

[webkit-changes] [142965] trunk

2013-02-14 Thread vsevik
Title: [142965] trunk








Revision 142965
Author vse...@chromium.org
Date 2013-02-14 22:39:03 -0800 (Thu, 14 Feb 2013)


Log Message
Web Inspector: Copy-pasting selected text over itself should be an undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109830

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

* inspector/editor/text-editor-undo-redo-expected.txt:
* inspector/editor/text-editor-undo-redo.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/text-editor-undo-redo-expected.txt
trunk/LayoutTests/inspector/editor/text-editor-undo-redo.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextEditorModel.js




Diff

Modified: trunk/LayoutTests/ChangeLog (142964 => 142965)

--- trunk/LayoutTests/ChangeLog	2013-02-15 06:33:14 UTC (rev 142964)
+++ trunk/LayoutTests/ChangeLog	2013-02-15 06:39:03 UTC (rev 142965)
@@ -1,3 +1,13 @@
+2013-02-14  Vsevolod Vlasov  
+
+Web Inspector: Copy-pasting selected text over itself should be an undoable state.
+https://bugs.webkit.org/show_bug.cgi?id=109830
+
+Reviewed by Pavel Feldman.
+
+* inspector/editor/text-editor-undo-redo-expected.txt:
+* inspector/editor/text-editor-undo-redo.html:
+
 2013-02-14  Ryosuke Niwa  
 
 Remove a test expectation now that the culprit has been rolled out in r142962.


Modified: trunk/LayoutTests/inspector/editor/text-editor-undo-redo-expected.txt (142964 => 142965)

--- trunk/LayoutTests/inspector/editor/text-editor-undo-redo-expected.txt	2013-02-15 06:33:14 UTC (rev 142964)
+++ trunk/LayoutTests/inspector/editor/text-editor-undo-redo-expected.txt	2013-02-15 06:39:03 UTC (rev 142965)
@@ -79,3 +79,58 @@
 }
 
 
+Running: testEditRangeWithTheSameTextAsOriginal
+Text before edit:
+function foo()
+{
+
+}
+
+Text after edit:
+function foo()
+{
+bar();
+baz();
+foo();|
+}
+
+Text after paste of the same text:
+function foo()
+{
+bar();
+baz();
+foo();|
+}
+
+Text after first undo:
+function foo()
+{
+bar();
+>baz();
+;<
+}
+
+Text after second redo:
+function foo()
+{
+bar();
+>baz();
+ 142965)

--- trunk/LayoutTests/inspector/editor/text-editor-undo-redo.html	2013-02-15 06:33:14 UTC (rev 142964)
+++ trunk/LayoutTests/inspector/editor/text-editor-undo-redo.html	2013-02-15 06:39:03 UTC (rev 142965)
@@ -1,32 +1,13 @@
 
 
 

[webkit-changes] [142964] trunk/LayoutTests

2013-02-14 Thread rniwa
Title: [142964] trunk/LayoutTests








Revision 142964
Author rn...@webkit.org
Date 2013-02-14 22:33:14 -0800 (Thu, 14 Feb 2013)


Log Message
Remove a test expectation now that the culprit has been rolled out in r142962.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (142963 => 142964)

--- trunk/LayoutTests/ChangeLog	2013-02-15 06:29:40 UTC (rev 142963)
+++ trunk/LayoutTests/ChangeLog	2013-02-15 06:33:14 UTC (rev 142964)
@@ -1,3 +1,9 @@
+2013-02-14  Ryosuke Niwa  
+
+Remove a test expectation now that the culprit has been rolled out in r142962.
+
+* platform/mac/TestExpectations:
+
 2013-02-14  Sheriff Bot  
 
 Unreviewed, rolling out r142889.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (142963 => 142964)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-02-15 06:29:40 UTC (rev 142963)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-02-15 06:33:14 UTC (rev 142964)
@@ -1417,5 +1417,3 @@
 webkit.org/b/109232 [ Debug ] inspector/debugger/debugger-reload-on-pause.html [ Crash ]
 
 webkit.org/b/109869 media/media-captions.html [ Crash ]
-
-webkit.org/b/109889 [ Debug ] scrollbars/overflow-scrollbar-combinations.html [ Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [142963] trunk/Source/WebKit/chromium

2013-02-14 Thread vsevik
Title: [142963] trunk/Source/WebKit/chromium








Revision 142963
Author vse...@chromium.org
Date 2013-02-14 22:29:40 -0800 (Thu, 14 Feb 2013)


Log Message
Unreviewed chromium test fix: incorrect field was used for UISourceCode url.

* src/js/Tests.js:
(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/Tests.js




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (142962 => 142963)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-15 06:26:36 UTC (rev 142962)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-15 06:29:40 UTC (rev 142963)
@@ -1,3 +1,11 @@
+2013-02-14  Vsevolod Vlasov  
+
+Unreviewed chromium test fix: incorrect field was used for UISourceCode url.
+
+* src/js/Tests.js:
+(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
+(.TestSuite.prototype.uiSourceCodesToString_):
+
 2013-02-14  David Trainor  
 
 [chromium] No triggering autofill on unfocus


Modified: trunk/Source/WebKit/chromium/src/js/Tests.js (142962 => 142963)

--- trunk/Source/WebKit/chromium/src/js/Tests.js	2013-02-15 06:26:36 UTC (rev 142962)
+++ trunk/Source/WebKit/chromium/src/js/Tests.js	2013-02-15 06:29:40 UTC (rev 142963)
@@ -327,9 +327,9 @@
 function checkNoDuplicates() {
 var uiSourceCodes = test.nonAnonymousUISourceCodes_();
 for (var i = 0; i < uiSourceCodes.length; i++) {
-var scriptName = uiSourceCodes[i].fileName;
+var scriptName = uiSourceCodes[i].url;
 for (var j = i + 1; j < uiSourceCodes.length; j++)
-test.assertTrue(scriptName !== uiSourceCodes[j].fileName, "Found script duplicates: " + test.uiSourceCodesToString_(uiSourceCodes));
+test.assertTrue(scriptName !== uiSourceCodes[j].url, "Found script duplicates: " + test.uiSourceCodesToString_(uiSourceCodes));
 }
 }
 
@@ -717,7 +717,7 @@
 {
 var names = [];
 for (var i = 0; i < uiSourceCodes.length; i++)
-names.push('"' + uiSourceCodes[i].fileName + '"');
+names.push('"' + uiSourceCodes[i].url + '"');
 return names.join(",");
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [142962] trunk

2013-02-14 Thread commit-queue
Title: [142962] trunk








Revision 142962
Author commit-qu...@webkit.org
Date 2013-02-14 22:26:36 -0800 (Thu, 14 Feb 2013)


Log Message
Unreviewed, rolling out r142889.
http://trac.webkit.org/changeset/142889
https://bugs.webkit.org/show_bug.cgi?id=109891

It caused an assertion failure in scrollbars/overflow-
scrollbar-combinations.html (Requested by tkent on #webkit).

Patch by Sheriff Bot  on 2013-02-14

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::borderWidthChanged):
(WebCore::RenderBox::styleDidChange):

LayoutTests:

* fast/block/dynamic-padding-border-expected.txt: Removed.
* fast/block/dynamic-padding-border.html: Removed.
* fast/table/border-collapsing/cached-change-row-border-width-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Removed Paths

trunk/LayoutTests/fast/block/dynamic-padding-border-expected.txt
trunk/LayoutTests/fast/block/dynamic-padding-border.html




Diff

Modified: trunk/LayoutTests/ChangeLog (142961 => 142962)

--- trunk/LayoutTests/ChangeLog	2013-02-15 06:21:16 UTC (rev 142961)
+++ trunk/LayoutTests/ChangeLog	2013-02-15 06:26:36 UTC (rev 142962)
@@ -1,3 +1,16 @@
+2013-02-14  Sheriff Bot  
+
+Unreviewed, rolling out r142889.
+http://trac.webkit.org/changeset/142889
+https://bugs.webkit.org/show_bug.cgi?id=109891
+
+It caused an assertion failure in scrollbars/overflow-
+scrollbar-combinations.html (Requested by tkent on #webkit).
+
+* fast/block/dynamic-padding-border-expected.txt: Removed.
+* fast/block/dynamic-padding-border.html: Removed.
+* fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
+
 2013-02-14  Ryosuke Niwa  
 
 Add assertion failure expectations on Mac per bugs 109869 and 109890.


Deleted: trunk/LayoutTests/fast/block/dynamic-padding-border-expected.txt (142961 => 142962)

--- trunk/LayoutTests/fast/block/dynamic-padding-border-expected.txt	2013-02-15 06:21:16 UTC (rev 142961)
+++ trunk/LayoutTests/fast/block/dynamic-padding-border-expected.txt	2013-02-15 06:26:36 UTC (rev 142962)
@@ -1,6 +0,0 @@
-This test passes if there is no red showing.
-
-PASS
-PASS
-PASS
-PASS


Deleted: trunk/LayoutTests/fast/block/dynamic-padding-border.html (142961 => 142962)

--- trunk/LayoutTests/fast/block/dynamic-padding-border.html	2013-02-15 06:21:16 UTC (rev 142961)
+++ trunk/LayoutTests/fast/block/dynamic-padding-border.html	2013-02-15 06:26:36 UTC (rev 142962)
@@ -1,50 +0,0 @@
-
-
-
-
-.red {
-background-color: red;
-}
-.green {
-background-color: green;
-}
-
-
-
-This test passes if there is no red showing.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-document.body.offsetLeft;
-document.getElementById("test1").style.paddingLeft = "0";
-document.getElementById("test2").style.paddingTop = "0";
-document.getElementById("test3").style.borderWidth = "0";
-document.getElementById("test4").style.borderWidth = "0";
-checkLayout(".container");
-
-
-


Modified: trunk/LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.txt (142961 => 142962)

--- trunk/LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.txt	2013-02-15 06:21:16 UTC (rev 142961)
+++ trunk/LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.txt	2013-02-15 06:26:36 UTC (rev 142962)
@@ -6,6 +6,6 @@
   RenderTable {TABLE} at (0,0) size 56x103 [border: (2px solid #FF)]
 RenderTableSection {TBODY} at (1,2) size 54x100
   RenderTableRow {TR} at (0,0) size 54x50 [border: (4px solid #00)]
-RenderTableCell {TD} at (0,22) size 54x6 [border: (2px solid #00FF00)] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {TD} at (0,23) size 54x4 [border: (2px solid #00FF00)] [r=0 c=0 rs=1 cs=1]
   RenderTableRow {TR} at (0,50) size 54x50
 RenderTableCell {TD} at (0,73) size 54x3 [border: (2px none #00)] [r=1 c=0 rs=1 cs=1]


Modified: trunk/Source/WebCore/ChangeLog (142961 => 142962)

--- trunk/Source/WebCore/ChangeLog	2013-02-15 06:21:16 UTC (rev 142961)
+++ trunk/Source/WebCore/ChangeLog	2013-02-15 06:26:36 UTC (rev 142962)
@@ -1,3 +1,16 @@
+2013-02-14  Sheriff Bot  
+
+Unreviewed, rolling out r142889.
+http://trac.webkit.org/changeset/142889
+https://bugs.webkit.org/show_bug.cgi?id=109891
+
+It caused an assertion failure in scrollbars/overflow-
+scrollbar-combinations.html (Requested by tkent on #webkit).
+
+* rendering/RenderBox.cpp:
+(WebCore::borderWidthChanged):
+(WebCore::RenderBox::styleDidChange):
+
 2013-02-14  Arpita Bahuguna  
 
 Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressi

[webkit-changes] [142961] trunk/LayoutTests

2013-02-14 Thread rniwa
Title: [142961] trunk/LayoutTests








Revision 142961
Author rn...@webkit.org
Date 2013-02-14 22:21:16 -0800 (Thu, 14 Feb 2013)


Log Message
Add assertion failure expectations on Mac per bugs 109869 and 109890.

* platform/mac/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (142960 => 142961)

--- trunk/LayoutTests/ChangeLog	2013-02-15 05:59:02 UTC (rev 142960)
+++ trunk/LayoutTests/ChangeLog	2013-02-15 06:21:16 UTC (rev 142961)
@@ -1,3 +1,10 @@
+2013-02-14  Ryosuke Niwa  
+
+Add assertion failure expectations on Mac per bugs 109869 and 109890.
+
+* platform/mac/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2013-02-14  Arpita Bahuguna  
 
 Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (142960 => 142961)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-02-15 05:59:02 UTC (rev 142960)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-02-15 06:21:16 UTC (rev 142961)
@@ -1417,3 +1417,5 @@
 webkit.org/b/109232 [ Debug ] inspector/debugger/debugger-reload-on-pause.html [ Crash ]
 
 webkit.org/b/109869 media/media-captions.html [ Crash ]
+
+webkit.org/b/109889 [ Debug ] scrollbars/overflow-scrollbar-combinations.html [ Crash ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (142960 => 142961)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-02-15 05:59:02 UTC (rev 142960)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-02-15 06:21:16 UTC (rev 142961)
@@ -311,6 +311,8 @@
 
 webkit.org/b/107356 fast/css/sticky/sticky-top-zoomed.html [ ImageOnlyFailure ]
 
+webkit.org/b/109890 [ Debug ] platform/mac-wk2/plugins/destroy-during-async-npp-new.html [ Crash ]
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [142960] trunk

2013-02-14 Thread commit-queue
Title: [142960] trunk








Revision 142960
Author commit-qu...@webkit.org
Date 2013-02-14 21:59:02 -0800 (Thu, 14 Feb 2013)


Log Message
Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key.
https://bugs.webkit.org/show_bug.cgi?id=106452

Patch by Arpita Bahuguna  on 2013-02-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Pressing the down or the right arrow key at the end of a text line in
vertical writing mode would make the caret dissapear. This occurs only
when the text line is followed by an empty block.

When trying to compute the next position for placing the caret (for
down/right key), we try to ascertain whether the renderer (in this
case the empty block) is a valid candidate or not. For blockFlow
elements we check against their height.
In vertical writing mode though we would fail such a check since we
should instead be comparing against the renderer's width and not
it's height. Thus, a valid position for the placement of the caret
was not found in such a case.

Test: editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
Instead of checking against the height(), check against the
logicalHeight() of the renderer has been added. logicalHeight()
on blockFlow renderer's returns a value in accordance with
the writing mode.

LayoutTests:

* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt: Added.
* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html: Added.
Layout test case added for verifying that pressing the down or the right arrow
key at the end of the text line in vertical writing mode will not make the caret
dissapear.
Caret positions at the start, the end, and after pressing the right and the down
arrow keys at the end of the text line, are compared for verification.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/dom/PositionIterator.cpp


Added Paths

trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt
trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html




Diff

Modified: trunk/LayoutTests/ChangeLog (142959 => 142960)

--- trunk/LayoutTests/ChangeLog	2013-02-15 05:55:36 UTC (rev 142959)
+++ trunk/LayoutTests/ChangeLog	2013-02-15 05:59:02 UTC (rev 142960)
@@ -1,3 +1,18 @@
+2013-02-14  Arpita Bahuguna  
+
+Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key.
+https://bugs.webkit.org/show_bug.cgi?id=106452
+
+Reviewed by Ryosuke Niwa.
+
+* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt: Added.
+* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html: Added.
+Layout test case added for verifying that pressing the down or the right arrow
+key at the end of the text line in vertical writing mode will not make the caret
+dissapear.
+Caret positions at the start, the end, and after pressing the right and the down
+arrow keys at the end of the text line, are compared for verification. 
+
 2013-02-14  Simon Fraser  
 
 Reverting r142861. Hit testing inside of style recalc is fundamentally wrong


Added: trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt (0 => 142960)

--- trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt	2013-02-15 05:59:02 UTC (rev 142960)
@@ -0,0 +1,11 @@
+Testcase for bug 106452: Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key. To manually verify the issue, place the caret at the end of the text line and then press either the down or the right arrow key.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS caretRectAtEnd.width is caretRectAtStart.width
+PASS caretRectAtEnd.height is caretRectAtStart.height
+PASS caretRectRightKey.width is caretRectAtEnd.width
+PASS caretRectRightKey.height is caretRectAtEnd.height
+PASS caretRectDownKey.width is caretRectAtEnd.width
+PASS caretRectDownKey.height is caretRectAtEnd.height
+


Added: trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html (0 => 142960)

--- trunk/

[webkit-changes] [142959] trunk/Source/WebCore

2013-02-14 Thread rniwa
Title: [142959] trunk/Source/WebCore








Revision 142959
Author rn...@webkit.org
Date 2013-02-14 21:55:36 -0800 (Thu, 14 Feb 2013)


Log Message
Windows build fix after r142957.

* dom/DOMAllInOne.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMAllInOne.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (142958 => 142959)

--- trunk/Source/WebCore/ChangeLog	2013-02-15 05:47:52 UTC (rev 142958)
+++ trunk/Source/WebCore/ChangeLog	2013-02-15 05:55:36 UTC (rev 142959)
@@ -1,5 +1,11 @@
 2013-02-14  Ryosuke Niwa  
 
+Windows build fix after r142957.
+
+* dom/DOMAllInOne.cpp:
+
+2013-02-14  Ryosuke Niwa  
+
 Fix a typo introduced in r142705.
 
 Without this fix, text-input-controller.html can fail when DeleteButtonController is enabled.


Modified: trunk/Source/WebCore/dom/DOMAllInOne.cpp (142958 => 142959)

--- trunk/Source/WebCore/dom/DOMAllInOne.cpp	2013-02-15 05:47:52 UTC (rev 142958)
+++ trunk/Source/WebCore/dom/DOMAllInOne.cpp	2013-02-15 05:55:36 UTC (rev 142959)
@@ -80,6 +80,7 @@
 #include "EventException.cpp"
 #include "EventListenerMap.cpp"
 #include "EventNames.cpp"
+#include "EventRetargeter.cpp"
 #include "EventTarget.cpp"
 #include "ExceptionBase.cpp"
 #include "ExceptionCodePlaceholder.cpp"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [142958] trunk/Source/WebCore

2013-02-14 Thread rniwa
Title: [142958] trunk/Source/WebCore








Revision 142958
Author rn...@webkit.org
Date 2013-02-14 21:47:52 -0800 (Thu, 14 Feb 2013)


Log Message
Fix a typo introduced in r142705.

Without this fix, text-input-controller.html can fail when DeleteButtonController is enabled.
e.g. "run-webkit-tests platform/mac/editing/deleting/deletionUI-single-instance.html
platform/mac/editing/input/text-input-controller.html --child-processes=1"

* editing/Editor.cpp:
(WebCore::Editor::avoidIntersectionWithDeleteButtonController):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (142957 => 142958)

--- trunk/Source/WebCore/ChangeLog	2013-02-15 04:38:39 UTC (rev 142957)
+++ trunk/Source/WebCore/ChangeLog	2013-02-15 05:47:52 UTC (rev 142958)
@@ -1,3 +1,14 @@
+2013-02-14  Ryosuke Niwa  
+
+Fix a typo introduced in r142705.
+
+Without this fix, text-input-controller.html can fail when DeleteButtonController is enabled.
+e.g. "run-webkit-tests platform/mac/editing/deleting/deletionUI-single-instance.html
+platform/mac/editing/input/text-input-controller.html --child-processes=1"
+
+* editing/Editor.cpp:
+(WebCore::Editor::avoidIntersectionWithDeleteButtonController):
+
 2013-02-14  Hayato Ito  
 
 Factor Event retargeting code.


Modified: trunk/Source/WebCore/editing/Editor.cpp (142957 => 142958)

--- trunk/Source/WebCore/editing/Editor.cpp	2013-02-15 04:38:39 UTC (rev 142957)
+++ trunk/Source/WebCore/editing/Editor.cpp	2013-02-15 05:47:52 UTC (rev 142958)
@@ -154,7 +154,7 @@
 if (updatedBase != selection.base())
 updatedSelection.setBase(updatedBase);
 
-Position updatedExtent = selection.base();
+Position updatedExtent = selection.extent();
 updatePositionForNodeRemoval(updatedExtent, element);
 if (updatedExtent != selection.extent())
 updatedSelection.setExtent(updatedExtent);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [142957] trunk/Source/WebCore

2013-02-14 Thread hayato
Title: [142957] trunk/Source/WebCore








Revision 142957
Author hay...@chromium.org
Date 2013-02-14 20:38:39 -0800 (Thu, 14 Feb 2013)


Log Message
Factor Event retargeting code.
https://bugs.webkit.org/show_bug.cgi?id=109156

Reviewed by Dimitri Glazkov.

To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent,
but also other events.

New class, EventRetargeter, was introduced. From now,
EventDispatchMediator (and its subclasses) should call, if event
retargeting is required, an appropriate function provided in
EventRetargeter rather than calling
EventDispatcher::adjustRelatedTarget(), which was removed in this
patch.

No tests. No change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventDispatchMediator.cpp:
* dom/EventDispatcher.cpp:
(WebCore):
(WebCore::EventDispatcher::ensureEventPath): Changed to return an EventPath, which will be used by EventRetargeter.
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPostProcess):
* dom/EventDispatcher.h:
(WebCore):
(EventDispatcher):
* dom/EventRetargeter.cpp: Added.
(WebCore):
(WebCore::inTheSameScope):
(WebCore::determineDispatchBehavior):
(WebCore::EventRetargeter::calculateEventPath): Factored out from EventDispatcher::ensureEventPath().
(WebCore::EventRetargeter::adjustForMouseEvent):
(WebCore::EventRetargeter::adjustForFocusEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::buildRelatedNodeMap): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::findRelatedNode):
* dom/EventRetargeter.h: Added.
(WebCore):
(EventRetargeter):
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):
* dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForFocusEvent().
(WebCore::BlurEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusInEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusOutEventDispatchMediator::dispatchEvent): Ditto.
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForMouseEvent().

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/EventDispatchMediator.cpp
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
trunk/Source/WebCore/dom/FocusEvent.cpp
trunk/Source/WebCore/dom/MouseEvent.cpp


Added Paths

trunk/Source/WebCore/dom/EventRetargeter.cpp
trunk/Source/WebCore/dom/EventRetargeter.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (142956 => 142957)

--- trunk/Source/WebCore/CMakeLists.txt	2013-02-15 04:28:45 UTC (rev 142956)
+++ trunk/Source/WebCore/CMakeLists.txt	2013-02-15 04:38:39 UTC (rev 142957)
@@ -1175,6 +1175,7 @@
 dom/EventException.cpp
 dom/EventListenerMap.cpp
 dom/EventNames.cpp
+dom/EventRetargeter.cpp
 dom/EventTarget.cpp
 dom/ExceptionBase.cpp
 dom/ExceptionCodePlaceholder.cpp


Modified: trunk/Source/WebCore/ChangeLog (142956 => 142957)

--- trunk/Source/WebCore/ChangeLog	2013-02-15 04:28:45 UTC (rev 142956)
+++ trunk/Source/WebCore/ChangeLog	2013-02-15 04:38:39 UTC (rev 142957)
@@ -1,3 +1,61 @@
+2013-02-14  Hayato Ito  
+
+Factor Event retargeting code.
+https://bugs.webkit.org/show_bug.cgi?id=109156
+
+Reviewed by Dimitri Glazkov.
+
+To supoort Touch event retargeting (bug 107800), we have to factor
+event retargeting code so that it can support not only MouseEvent,
+but also other events.
+
+New class, EventRetargeter, was introduced. From now,
+EventDispatchMediator (and its subclasses) should call, if event
+retargeting is required, an appropriate function provided in
+EventRetargeter rather than calling
+EventDispatcher::adjustRelatedTarget(), which was removed in this
+patch.
+
+No tests. No change in behavior.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* Target.pri:
+* WebCore.gypi:
+* WebCore.xcodeproj/project.pbxproj:
+* dom/EventDispatchMediator.cpp:
+* dom/EventDispatcher.cpp:
+(WebCore):
+(WebCore::EventDispatcher::ensureEventPath): Changed to return an EventPath, which will be used by EventRetargeter.
+(WebCore::EventDispatcher::dispatchScopedEvent):
+(WebCore::EventDispatcher::dispatchEvent):
+(WebCore::EventDispatcher::dispatchEventPostProcess):
+ 

[webkit-changes] [142956] trunk

2013-02-14 Thread simon . fraser
Title: [142956] trunk








Revision 142956
Author simon.fra...@apple.com
Date 2013-02-14 20:28:45 -0800 (Thu, 14 Feb 2013)


Log Message
Reverting r142861. Hit testing inside of style recalc is fundamentally wrong

Source/WebCore:

* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
* page/EventHandler.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::areNonIdenticalCursorListsEqual):
(WebCore::areCursorsEqual):
(WebCore::RenderObject::styleDidChange):

LayoutTests:

* fast/events/mouse-cursor-change-expected.txt: Removed.
* fast/events/mouse-cursor-change.html: Removed.
* fast/events/mouse-cursor-no-mousemove-expected.txt: Removed.
* fast/events/mouse-cursor-no-mousemove.html: Removed.
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/rendering/RenderObject.cpp


Removed Paths

trunk/LayoutTests/fast/events/mouse-cursor-change-expected.txt
trunk/LayoutTests/fast/events/mouse-cursor-change.html
trunk/LayoutTests/fast/events/mouse-cursor-no-mousemove-expected.txt
trunk/LayoutTests/fast/events/mouse-cursor-no-mousemove.html




Diff

Modified: trunk/LayoutTests/ChangeLog (142955 => 142956)

--- trunk/LayoutTests/ChangeLog	2013-02-15 03:58:18 UTC (rev 142955)
+++ trunk/LayoutTests/ChangeLog	2013-02-15 04:28:45 UTC (rev 142956)
@@ -1,3 +1,13 @@
+2013-02-14  Simon Fraser  
+
+Reverting r142861. Hit testing inside of style recalc is fundamentally wrong
+
+* fast/events/mouse-cursor-change-expected.txt: Removed.
+* fast/events/mouse-cursor-change.html: Removed.
+* fast/events/mouse-cursor-no-mousemove-expected.txt: Removed.
+* fast/events/mouse-cursor-no-mousemove.html: Removed.
+* platform/mac/TestExpectations:
+
 2013-02-14  Florin Malita  
 
 [SVG] Cached filter results are not invalidated on repaint rect change
@@ -352,25 +362,6 @@
 * fast/text-autosizing/narrow-descendants-combined-expected.html: Added.
 * fast/text-autosizing/narrow-descendants-combined.html: Added.
 
-2013-02-14  Aivo Paas  
-
-Updating mouse cursor on style changes without emitting fake mousemove event
-https://bugs.webkit.org/show_bug.cgi?id=101857
-Changing CSS cursor should work no matter is mouse button is pressed or not
-https://bugs.webkit.org/show_bug.cgi?id=53341
-
-Reviewed by Allan Sandfeld Jensen.
-
-Added tests for changing cursor on mousemove, mousedown, mouseup and mousemove
-while mouse button being hold down. Also added test to verify that a mousemove
-event is not fired for changing cursor while mouse is not moving.
-
-* fast/events/mouse-cursor-change-expected.txt: Added.
-* fast/events/mouse-cursor-change.html: Added.
-* fast/events/mouse-cursor-no-mousemove-expected.txt: Added.
-* fast/events/mouse-cursor-no-mousemove.html: Added.
-* platform/mac/TestExpectations:
-
 2013-02-06  Gregg Tavares  
 
 Adds the WebGL Conformance Tests limits folder.


Deleted: trunk/LayoutTests/fast/events/mouse-cursor-change-expected.txt (142955 => 142956)

--- trunk/LayoutTests/fast/events/mouse-cursor-change-expected.txt	2013-02-15 03:58:18 UTC (rev 142955)
+++ trunk/LayoutTests/fast/events/mouse-cursor-change-expected.txt	2013-02-15 04:28:45 UTC (rev 142956)
@@ -1,24 +0,0 @@
-Test that mouse cursors are changed correctly on mouse events.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Bug 53341
-
-
-Mouse move
-Cursor Info: type=Hand hotSpot=0,0
-
-Mouse down
-Cursor Info: type=Progress hotSpot=0,0
-
-Mouse hold down, move
-Cursor Info: type=Hand hotSpot=0,0
-
-Mouse up
-Cursor Info: type=Help hotSpot=0,0
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/fast/events/mouse-cursor-change.html (142955 => 142956)

--- trunk/LayoutTests/fast/events/mouse-cursor-change.html	2013-02-15 03:58:18 UTC (rev 142955)
+++ trunk/LayoutTests/fast/events/mouse-cursor-change.html	2013-02-15 04:28:45 UTC (rev 142956)
@@ -1,78 +0,0 @@
-
-
-
-
-
-
-
-

-

-
-
Play with mouse on this element. Cursors change on events - mousemove: pointer(hand), mousedown: progress, mouseup: help.
-
-
-
-