date:20130611

[webkit-changes] [151487] trunk/Source/WebCore

2013-06-11 Thread ch . dumez

Title: [151487] trunk/Source/WebCore








Revision 151487
Author ch.du...@sisa.samsung.com
Date 2013-06-11 23:05:58 -0700 (Tue, 11 Jun 2013)


Log Message
Unreviewed, rolling out r151378.
http://trac.webkit.org/changeset/151378
https://bugs.webkit.org/show_bug.cgi?id=117400

Decreased IDL readability a bit.

* Modules/encryptedmedia/MediaKeys.idl:
* Modules/mediastream/RTCIceCandidate.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescription.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestNamedConstructor.idl:
* css/WebKitCSSMatrix.idl:
* html/HTMLOptionElement.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl
trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl
trunk/Source/WebCore/Modules/mediastream/RTCSessionDescription.idl
trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl
trunk/Source/WebCore/Modules/websockets/WebSocket.idl
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl
trunk/Source/WebCore/bindings/scripts/test/TestNamedConstructor.idl
trunk/Source/WebCore/css/WebKitCSSMatrix.idl
trunk/Source/WebCore/html/HTMLOptionElement.idl
trunk/Source/WebCore/page/EventSource.idl
trunk/Source/WebCore/workers/SharedWorker.idl
trunk/Source/WebCore/workers/Worker.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (151486 => 151487)

--- trunk/Source/WebCore/ChangeLog	2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/ChangeLog	2013-06-12 06:05:58 UTC (rev 151487)
@@ -1,3 +1,28 @@
+2013-06-11  Christophe Dumez  
+
+Unreviewed, rolling out r151378.
+http://trac.webkit.org/changeset/151378
+https://bugs.webkit.org/show_bug.cgi?id=117400
+
+Decreased IDL readability a bit.
+
+* Modules/encryptedmedia/MediaKeys.idl:
+* Modules/mediastream/RTCIceCandidate.idl:
+* Modules/mediastream/RTCPeerConnection.idl:
+* Modules/mediastream/RTCSessionDescription.idl:
+* Modules/webaudio/OfflineAudioContext.idl:
+* Modules/websockets/WebSocket.idl:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateConstructorDefinition):
+* bindings/scripts/IDLAttributes.txt:
+* bindings/scripts/test/TestInterface.idl:
+* bindings/scripts/test/TestNamedConstructor.idl:
+* css/WebKitCSSMatrix.idl:
+* html/HTMLOptionElement.idl:
+* page/EventSource.idl:
+* workers/SharedWorker.idl:
+* workers/Worker.idl:
+
 2013-06-11  Ryosuke Niwa  
 
 Have to invalidate the mute button when changing the volume


Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl (151486 => 151487)

--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl	2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl	2013-06-12 06:05:58 UTC (rev 151487)
@@ -26,7 +26,7 @@
 [
 Conditional=ENCRYPTED_MEDIA_V2,
 Constructor(DOMString keySystem),
-RaisesException,
+ConstructorRaisesException,
 ] interface MediaKeys {
 [CallWith=ScriptExecutionContext, RaisesException] MediaKeySession createSession([Default=Undefined] optional DOMString type, [Default=Undefined] optional Uint8Array initData);
 


Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl (151486 => 151487)

--- trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl	2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl	2013-06-12 06:05:58 UTC (rev 151487)
@@ -31,7 +31,7 @@
 [
 Conditional=MEDIA_STREAM,
 Constructor(Dictionary dictionary),
-RaisesException
+ConstructorRaisesException
 ] interface RTCIceCandidate {
 readonly attribute DOMString candidate;
 readonly attribute DOMString sdpMid;


Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl (151486 => 151487)

--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl	2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl	2013-06-12 06:05:58 UTC (rev 151487)
@@ -32,7 +32,7 @@
 Conditional=MEDIA_STREAM,
 ActiveDOMObject,
 Constructor(Dictionary rtcIceServers, optional Dictionary mediaConstraints),
-RaisesException,
+ConstructorRaisesException,
 CallWith=ScriptExecutionContext,
 EventTarget,
 InterfaceName=webkitRTCPeerConnection


Modified: trunk/Source/WebCore/Modules/mediastream/RTCSessionDescription.idl (151486 => 151487)

--- t

[webkit-changes] [151484] trunk/Source/WebKit2

2013-06-11 Thread barraclough

Title: [151484] trunk/Source/WebKit2








Revision 151484
Author barraclo...@apple.com
Date 2013-06-11 20:09:15 -0700 (Tue, 11 Jun 2013)


Log Message
Add NSSupportsAppNap keys to WebProcess, PluginProcess
https://bugs.webkit.org/show_bug.cgi?id=117528

Reviewed by Mark Rowe.

* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- add NSSupportsAppNap key.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist




Diff

Modified: trunk/Source/WebKit2/ChangeLog (151483 => 151484)

--- trunk/Source/WebKit2/ChangeLog	2013-06-12 02:54:35 UTC (rev 151483)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-12 03:09:15 UTC (rev 151484)
@@ -1,3 +1,18 @@
+2013-06-11  Gavin Barraclough  
+
+Add NSSupportsAppNap keys to WebProcess, PluginProcess
+https://bugs.webkit.org/show_bug.cgi?id=117528
+
+Reviewed by Mark Rowe.
+
+* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
+* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
+* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
+* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
+* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
+- add NSSupportsAppNap key.
+
 2013-06-11  Oliver Hunt  
 
 Make sure we aren't throttling plugin timers during initialisation and destruction


Modified: trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist (151483 => 151484)

--- trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist	2013-06-12 02:54:35 UTC (rev 151483)
+++ trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist	2013-06-12 03:09:15 UTC (rev 151484)
@@ -30,5 +30,7 @@
 	PluginProcessMain
 	NSSupportsAutomaticGraphicsSwitching
 	
+	NSSupportsAppNap
+	
 
 


Modified: trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist (151483 => 151484)

--- trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist	2013-06-12 02:54:35 UTC (rev 151483)
+++ trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist	2013-06-12 03:09:15 UTC (rev 151484)
@@ -32,6 +32,8 @@
 	
 	NSSupportsAutomaticGraphicsSwitching
 	
+	NSSupportsAppNap
+	
 	XPCService
 	
 		ServiceType


Modified: trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist (151483 => 151484)

--- trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist	2013-06-12 02:54:35 UTC (rev 151483)
+++ trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist	2013-06-12 03:09:15 UTC (rev 151484)
@@ -32,6 +32,8 @@
 	
 	NSSupportsAutomaticGraphicsSwitching
 	
+	NSSupportsAppNap
+	
 	XPCService
 	
 		ServiceType


Modified: trunk/Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist (151483 => 151484)

--- trunk/Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist	2013-06-12 02:54:35 UTC (rev 151483)
+++ trunk/Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist	2013-06-12 03:09:15 UTC (rev 151484)
@@ -34,6 +34,8 @@
 	WebContentProcessMain
 	NSSupportsAutomaticGraphicsSwitching
 	
+	NSSupportsAppNap
+	
 	NSMainNibFile
 	WebContentProcess
 


Modified: trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist (151483 => 151484)

--- trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist	2013-06-12 02:54:35 UTC (rev 151483)
+++ trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist	2013-06-12 03:09:15 UTC (rev 151484)
@@ -34,6 +34,8 @@
 	
 	NSSupportsAutomaticGraphicsSwitching
 	
+	NSSupportsAppNap
+	
 	NSMainNibFile
 	WebContentProcess
 	XPCService


Modified: trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist (151483 => 151484)

--- trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCS

[webkit-changes] [151483] trunk/Tools

2013-06-11 Thread commit-queue

Title: [151483] trunk/Tools








Revision 151483
Author commit-qu...@webkit.org
Date 2013-06-11 19:54:35 -0700 (Tue, 11 Jun 2013)


Log Message
[EFL] Window resize should close the popupmenu
https://bugs.webkit.org/show_bug.cgi?id=117391

Patch by Santosh Mahto  on 2013-06-11
Reviewed by Christophe Dumez.

Added the code to close the popup when main window is resized.

* MiniBrowser/efl/main.c:
(on_window_resize):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c




Diff

Modified: trunk/Tools/ChangeLog (151482 => 151483)

--- trunk/Tools/ChangeLog	2013-06-12 01:47:29 UTC (rev 151482)
+++ trunk/Tools/ChangeLog	2013-06-12 02:54:35 UTC (rev 151483)
@@ -1,3 +1,15 @@
+2013-06-11  Santosh Mahto  
+
+[EFL] Window resize should close the popupmenu
+https://bugs.webkit.org/show_bug.cgi?id=117391
+
+Reviewed by Christophe Dumez.
+
+Added the code to close the popup when main window is resized.
+
+* MiniBrowser/efl/main.c:
+(on_window_resize):
+
 2013-06-11  Alex Christensen  
 
 Removed old broken code coverage tool.


Modified: trunk/Tools/MiniBrowser/efl/main.c (151482 => 151483)

--- trunk/Tools/MiniBrowser/efl/main.c	2013-06-12 01:47:29 UTC (rev 151482)
+++ trunk/Tools/MiniBrowser/efl/main.c	2013-06-12 02:54:35 UTC (rev 151483)
@@ -282,6 +282,10 @@
 
 if (window->context_menu.ewk_menu)
 ewk_context_menu_hide(window->context_menu.ewk_menu);
+if (window->popup.ewk_menu)
+ewk_popup_menu_close(window->popup.ewk_menu);
+if (window->popup.elm_menu)
+elm_menu_close(window->popup.elm_menu);
 }
 
 static void window_free(Browser_Window *window)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151480] trunk/Source/WebKit2

2013-06-11 Thread oliver

Title: [151480] trunk/Source/WebKit2








Revision 151480
Author oli...@apple.com
Date 2013-06-11 18:12:27 -0700 (Tue, 11 Jun 2013)


Log Message
Make sure we aren't throttling plugin timers during initialisation and destruction
https://bugs.webkit.org/show_bug.cgi?id=117522

Reviewed by Darin Adler.

Add a new ActivityAssertion RAII class to handle allowing/disallowing
timer throttling.  Then make use of it during plugin initialisation
and destruction, as well as any synchronous messages (on the basis
that if another process is waiting for the plugin we shouldn't be
throttling timers).

* CMakeLists.txt:
* GNUmakefile.list.am:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::destroyPlugin):
(WebKit::WebProcessConnection::createPlugin):
* Shared/ActivityAssertion.cpp: Added.
(WebKit::ActivityAssertion::ActivityAssertion):
(WebKit::ActivityAssertion::~ActivityAssertion):
* Shared/ActivityAssertion.h: Added.
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.list.am
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/Shared/ActivityAssertion.cpp
trunk/Source/WebKit2/Shared/ActivityAssertion.h




Diff

Modified: trunk/Source/WebKit2/CMakeLists.txt (151479 => 151480)

--- trunk/Source/WebKit2/CMakeLists.txt	2013-06-11 23:51:33 UTC (rev 151479)
+++ trunk/Source/WebKit2/CMakeLists.txt	2013-06-12 01:12:27 UTC (rev 151480)
@@ -154,6 +154,7 @@
 
 Shared/APIClientTraits.cpp
 Shared/APIObject.cpp
+Shared/ActivityAssertion.cpp
 Shared/CacheModel.cpp
 Shared/ChildProcess.cpp
 Shared/ChildProcessProxy.cpp


Modified: trunk/Source/WebKit2/ChangeLog (151479 => 151480)

--- trunk/Source/WebKit2/ChangeLog	2013-06-11 23:51:33 UTC (rev 151479)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-12 01:12:27 UTC (rev 151480)
@@ -1,3 +1,29 @@
+2013-06-11  Oliver Hunt  
+
+Make sure we aren't throttling plugin timers during initialisation and destruction
+https://bugs.webkit.org/show_bug.cgi?id=117522
+
+Reviewed by Darin Adler.
+
+Add a new ActivityAssertion RAII class to handle allowing/disallowing
+timer throttling.  Then make use of it during plugin initialisation
+and destruction, as well as any synchronous messages (on the basis
+that if another process is waiting for the plugin we shouldn't be
+throttling timers).
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* PluginProcess/WebProcessConnection.cpp:
+(WebKit::WebProcessConnection::didReceiveSyncMessage):
+(WebKit::WebProcessConnection::destroyPlugin):
+(WebKit::WebProcessConnection::createPlugin):
+* Shared/ActivityAssertion.cpp: Added.
+(WebKit::ActivityAssertion::ActivityAssertion):
+(WebKit::ActivityAssertion::~ActivityAssertion):
+* Shared/ActivityAssertion.h: Added.
+* Target.pri:
+* WebKit2.xcodeproj/project.pbxproj:
+
 2013-06-06  Timothy Hatcher  
 
 Update the framework bundle identifier for the Web Inspector.


Modified: trunk/Source/WebKit2/GNUmakefile.list.am (151479 => 151480)

--- trunk/Source/WebKit2/GNUmakefile.list.am	2013-06-11 23:51:33 UTC (rev 151479)
+++ trunk/Source/WebKit2/GNUmakefile.list.am	2013-06-12 01:12:27 UTC (rev 151480)
@@ -373,6 +373,8 @@
 	Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h \
 	Source/WebKit2/Shared/APIObject.cpp \
 	Source/WebKit2/Shared/APIObject.h \
+	Source/WebKit2/Shared/ActivityAssertion.cpp \
+	Source/WebKit2/Shared/ActivityAssertion.h \
 	Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp \
 	Source/WebKit2/Shared/Authentication/AuthenticationManager.h \
 	Source/WebKit2/Shared/BlockingResponseMap.h \


Modified: trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp (151479 => 151480)

--- trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp	2013-06-11 23:51:33 UTC (rev 151479)
+++ trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp	2013-06-12 01:12:27 UTC (rev 151480)
@@ -28,6 +28,7 @@
 
 #if ENABLE(PLUGIN_PROCESS)
 
+#include "ActivityAssertion.h"
 #include "ArgumentCoders.h"
 #include "ConnectionStack.h"
 #include "NPObjectMessageReceiverMessages.h"
@@ -140,6 +141,9 @@
 
 void WebProcessConnection::didReceiveSyncMessage(CoreIPC::Connection* connection, CoreIPC::MessageDecoder& decoder, OwnPtr& replyEncoder)
 {
+// Force all timers to run at full speed when processing a synchronous message
+ActivityAssertion activityAssertion(PluginProcess::shared());
+
 ConnectionStack::CurrentConnectionPusher currentConnection(ConnectionStack::shared(), connection);
 
 uint64_t destinationID = decoder.destinationID();
@@ -176,6 +180,9 @@
 
 void WebProcessConnection::destr

[webkit-changes] [151479] trunk/Source/WebKit/win

2013-06-11 Thread bfulgham

Title: [151479] trunk/Source/WebKit/win








Revision 151479
Author bfulg...@apple.com
Date 2013-06-11 16:51:33 -0700 (Tue, 11 Jun 2013)


Log Message
[Windows] Unreviewed build correction after r151440.

* AccessibleBase.cpp:
(MSAARole): Switch back to emiting ROLE_SYSTEM_LISTITEM for
ListItemRole Web role to avoid breaking existing test.

Modified Paths

trunk/Source/WebKit/win/AccessibleBase.cpp
trunk/Source/WebKit/win/ChangeLog




Diff

Modified: trunk/Source/WebKit/win/AccessibleBase.cpp (151478 => 151479)

--- trunk/Source/WebKit/win/AccessibleBase.cpp	2013-06-11 23:16:53 UTC (rev 151478)
+++ trunk/Source/WebKit/win/AccessibleBase.cpp	2013-06-11 23:51:33 UTC (rev 151479)
@@ -672,11 +672,8 @@
 case WebCore::ImageMapRole:
 case WebCore::ImageRole:
 return ROLE_SYSTEM_GRAPHIC;
-// Note: ListItemRole seems like it should map to ROLE_SYSTEM_LISTITEM, but Mac OS maps
-// this to the equivalent of ROLE_SYSTEM_GROUPING. To provide consistent behavior on both
-// platforms we will follow that mapping:
 case WebCore::ListItemRole:
-return ROLE_SYSTEM_GROUPING;
+return ROLE_SYSTEM_LISTITEM;
 case WebCore::ListBoxOptionRole:
 case WebCore::MenuListOptionRole:
 return ROLE_SYSTEM_STATICTEXT;


Modified: trunk/Source/WebKit/win/ChangeLog (151478 => 151479)

--- trunk/Source/WebKit/win/ChangeLog	2013-06-11 23:16:53 UTC (rev 151478)
+++ trunk/Source/WebKit/win/ChangeLog	2013-06-11 23:51:33 UTC (rev 151479)
@@ -1,5 +1,13 @@
 2013-06-11  Brent Fulgham  
 
+[Windows] Unreviewed build correction after r151440.
+
+* AccessibleBase.cpp:
+(MSAARole): Switch back to emiting ROLE_SYSTEM_LISTITEM for
+ListItemRole Web role to avoid breaking existing test.
+
+2013-06-11  Brent Fulgham  
+
 [Windows] Implement 'attributeValue' accessor to support testing.
 https://bugs.webkit.org/show_bug.cgi?id=117513
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151478] trunk/WebKitLibraries

2013-06-11 Thread roger_fong

Title: [151478] trunk/WebKitLibraries








Revision 151478
Author roger_f...@apple.com
Date 2013-06-11 16:16:53 -0700 (Tue, 11 Jun 2013)


Log Message
Unreviewed. Another part of rollout of r151408.

* win/tools64: Removed.
* win/tools64/scripts: Removed.
* win/tools64/vsprops: Removed.

Modified Paths

trunk/WebKitLibraries/ChangeLog


Removed Paths

trunk/WebKitLibraries/win/tools64/




Diff

Modified: trunk/WebKitLibraries/ChangeLog (151477 => 151478)

--- trunk/WebKitLibraries/ChangeLog	2013-06-11 22:23:33 UTC (rev 151477)
+++ trunk/WebKitLibraries/ChangeLog	2013-06-11 23:16:53 UTC (rev 151478)
@@ -1,5 +1,13 @@
 2013-06-11  Roger Fong  
 
+Unreviewed. Another part of rollout of r151408.
+
+* win/tools64: Removed.
+* win/tools64/scripts: Removed.
+* win/tools64/vsprops: Removed.
+
+2013-06-11  Roger Fong  
+
 Unreviewed. WinTools makefile fix.
 
 * win/tools32/WinTools.make:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151477] tags/Safari-537.44.1/WebKitLibraries

2013-06-11 Thread lforschler

Title: [151477] tags/Safari-537.44.1/WebKitLibraries








Revision 151477
Author lforsch...@apple.com
Date 2013-06-11 15:23:33 -0700 (Tue, 11 Jun 2013)


Log Message
Merged r151474.  

Modified Paths

tags/Safari-537.44.1/WebKitLibraries/ChangeLog
tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make




Diff

Modified: tags/Safari-537.44.1/WebKitLibraries/ChangeLog (151476 => 151477)

--- tags/Safari-537.44.1/WebKitLibraries/ChangeLog	2013-06-11 21:59:12 UTC (rev 151476)
+++ tags/Safari-537.44.1/WebKitLibraries/ChangeLog	2013-06-11 22:23:33 UTC (rev 151477)
@@ -1,5 +1,15 @@
 2013-06-11  Lucas Forschler  
 
+Merge r151474
+
+2013-06-11  Roger Fong  
+
+Unreviewed. WinTools makefile fix.
+
+* win/tools32/WinTools.make:
+
+2013-06-11  Lucas Forschler  
+
 Rollout r151408 (151452 on tag)
 
 2013-06-11  Lucas Forschler  


Modified: tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make (151476 => 151477)

--- tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make	2013-06-11 21:59:12 UTC (rev 151476)
+++ tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make	2013-06-11 22:23:33 UTC (rev 151477)
@@ -1,3 +1,5 @@
 install:
 xcopy "$(SRCROOT)\vsprops\*.props" "$(DSTROOT)\AppleInternal\tools32\vsprops" /e/v/i/h/y
 xcopy "$(SRCROOT)\scripts\*" "$(DSTROOT)\AppleInternal\tools32\scripts" /e/v/i/h/y
+xcopy "$(SRCROOT)\vsprops\*.props" "$(DSTROOT)\AppleInternal\tools64\vsprops" /e/v/i/h/y
+xcopy "$(SRCROOT)\scripts\*" "$(DSTROOT)\AppleInternal\tools64\scripts" /e/v/i/h/y
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151476] trunk/Source/WebCore

2013-06-11 Thread rniwa

Title: [151476] trunk/Source/WebCore








Revision 151476
Author rn...@webkit.org
Date 2013-06-11 14:59:12 -0700 (Tue, 11 Jun 2013)


Log Message
Have to invalidate the mute button when changing the volume
https://bugs.webkit.org/show_bug.cgi?id=117464

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/c4c685c82908449526fd8c251cc551e729ebed08
but without a test since the test doesn't work in WebKit.

* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::changedVolume):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/MediaControls.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151475 => 151476)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 21:55:06 UTC (rev 151475)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 21:59:12 UTC (rev 151476)
@@ -1,3 +1,16 @@
+2013-06-11  Ryosuke Niwa  
+
+Have to invalidate the mute button when changing the volume
+https://bugs.webkit.org/show_bug.cgi?id=117464
+
+Reviewed by Darin Adler.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/c4c685c82908449526fd8c251cc551e729ebed08
+but without a test since the test doesn't work in WebKit.
+
+* html/shadow/MediaControls.cpp:
+(WebCore::MediaControls::changedVolume):
+
 2013-06-11  Max Vujovic  
 
 [CSS Regions] Regions don't create a stacking context for their contents


Modified: trunk/Source/WebCore/html/shadow/MediaControls.cpp (151475 => 151476)

--- trunk/Source/WebCore/html/shadow/MediaControls.cpp	2013-06-11 21:55:06 UTC (rev 151475)
+++ trunk/Source/WebCore/html/shadow/MediaControls.cpp	2013-06-11 21:59:12 UTC (rev 151476)
@@ -241,6 +241,8 @@
 {
 if (m_volumeSlider)
 m_volumeSlider->setVolume(m_mediaController->volume());
+if (m_panelMuteButton && m_panelMuteButton->renderer())
+m_panelMuteButton->renderer()->repaint();
 }
 
 void MediaControls::changedClosedCaptionsVisibility()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151474] trunk/WebKitLibraries

2013-06-11 Thread roger_fong

Title: [151474] trunk/WebKitLibraries








Revision 151474
Author roger_f...@apple.com
Date 2013-06-11 14:46:03 -0700 (Tue, 11 Jun 2013)


Log Message
Unreviewed. WinTools makefile fix.

* win/tools32/WinTools.make:

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools32/WinTools.make




Diff

Modified: trunk/WebKitLibraries/ChangeLog (151473 => 151474)

--- trunk/WebKitLibraries/ChangeLog	2013-06-11 21:43:41 UTC (rev 151473)
+++ trunk/WebKitLibraries/ChangeLog	2013-06-11 21:46:03 UTC (rev 151474)
@@ -1,3 +1,9 @@
+2013-06-11  Roger Fong  
+
+Unreviewed. WinTools makefile fix.
+
+* win/tools32/WinTools.make:
+
 2013-06-11  Commit Queue  
 
 Unreviewed, rolling out r151408.


Modified: trunk/WebKitLibraries/win/tools32/WinTools.make (151473 => 151474)

--- trunk/WebKitLibraries/win/tools32/WinTools.make	2013-06-11 21:43:41 UTC (rev 151473)
+++ trunk/WebKitLibraries/win/tools32/WinTools.make	2013-06-11 21:46:03 UTC (rev 151474)
@@ -1,3 +1,5 @@
 install:
 xcopy "$(SRCROOT)\vsprops\*.props" "$(DSTROOT)\AppleInternal\tools32\vsprops" /e/v/i/h/y
 xcopy "$(SRCROOT)\scripts\*" "$(DSTROOT)\AppleInternal\tools32\scripts" /e/v/i/h/y
+xcopy "$(SRCROOT)\vsprops\*.props" "$(DSTROOT)\AppleInternal\tools64\vsprops" /e/v/i/h/y
+xcopy "$(SRCROOT)\scripts\*" "$(DSTROOT)\AppleInternal\tools64\scripts" /e/v/i/h/y
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151473] trunk/Source/WebCore

2013-06-11 Thread jer . noble

Title: [151473] trunk/Source/WebCore








Revision 151473
Author jer.no...@apple.com
Date 2013-06-11 14:43:41 -0700 (Tue, 11 Jun 2013)


Log Message
REGRESSION: (r149232) videos on disney.com are initially scrambled on load
https://bugs.webkit.org/show_bug.cgi?id=117517

Reviewed by Eric Carlson.

Set a background color on the AVPlayerLayer to avoid corruption when no
frames are available to display.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (151472 => 151473)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 21:23:43 UTC (rev 151472)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 21:43:41 UTC (rev 151473)
@@ -1,3 +1,16 @@
+2013-06-11  Jer Noble  
+
+REGRESSION: (r149232) videos on disney.com are initially scrambled on load
+https://bugs.webkit.org/show_bug.cgi?id=117517
+
+Reviewed by Eric Carlson.
+
+Set a background color on the AVPlayerLayer to avoid corruption when no
+frames are available to display.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
+
 2013-06-11  Ryosuke Niwa  
 
 Use HTMLElementFactory to create equivalent elements in WebVTTElement


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (151472 => 151473)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-06-11 21:23:43 UTC (rev 151472)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-06-11 21:43:41 UTC (rev 151473)
@@ -365,6 +365,7 @@
 if (!m_videoLayer) {
 m_videoLayer = adoptNS([[AVPlayerLayer alloc] init]);
 [m_videoLayer.get() setPlayer:m_avPlayer.get()];
+[m_videoLayer.get() setBackgroundColor:CGColorGetConstantColor(kCGColorBlack)];
 #ifndef NDEBUG
 [m_videoLayer.get() setName:@"Video layer"];
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151472] trunk/Tools

2013-06-11 Thread achristensen

Title: [151472] trunk/Tools








Revision 151472
Author achristen...@apple.com
Date 2013-06-11 14:23:43 -0700 (Tue, 11 Jun 2013)


Log Message
Removed old broken code coverage tool.
https://bugs.webkit.org/show_bug.cgi?id=117520

Reviewed by Sam Weinig.

* CodeCoverage: Removed.
* CodeCoverage/README: Removed.
* CodeCoverage/amber.png: Removed.
* CodeCoverage/cov.py: Removed.
* CodeCoverage/emerald.png: Removed.
* CodeCoverage/gcov.css: Removed.
* CodeCoverage/glass.png: Removed.
* CodeCoverage/regenerate-coverage-display: Removed.
* CodeCoverage/ruby.png: Removed.
* CodeCoverage/run-generate-coverage-data: Removed.
* CodeCoverage/snow.png: Removed.

Modified Paths

trunk/Tools/ChangeLog


Removed Paths

trunk/Tools/CodeCoverage/




Diff

Modified: trunk/Tools/ChangeLog (151471 => 151472)

--- trunk/Tools/ChangeLog	2013-06-11 21:18:55 UTC (rev 151471)
+++ trunk/Tools/ChangeLog	2013-06-11 21:23:43 UTC (rev 151472)
@@ -1,3 +1,22 @@
+2013-06-11  Alex Christensen  
+
+Removed old broken code coverage tool.
+https://bugs.webkit.org/show_bug.cgi?id=117520
+
+Reviewed by Sam Weinig.
+
+* CodeCoverage: Removed.
+* CodeCoverage/README: Removed.
+* CodeCoverage/amber.png: Removed.
+* CodeCoverage/cov.py: Removed.
+* CodeCoverage/emerald.png: Removed.
+* CodeCoverage/gcov.css: Removed.
+* CodeCoverage/glass.png: Removed.
+* CodeCoverage/regenerate-coverage-display: Removed.
+* CodeCoverage/ruby.png: Removed.
+* CodeCoverage/run-generate-coverage-data: Removed.
+* CodeCoverage/snow.png: Removed.
+
 2013-06-11  Timothy Hatcher  
 
 Have build-webkit build the WebInspectorUI project.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151471] trunk

2013-06-11 Thread rniwa

Title: [151471] trunk








Revision 151471
Author rn...@webkit.org
Date 2013-06-11 14:18:55 -0700 (Tue, 11 Jun 2013)


Log Message
Use HTMLElementFactory to create equivalent elements in WebVTTElement
https://bugs.webkit.org/show_bug.cgi?id=117423

Reviewed by Eric Carlson.

Source/WebCore: 

Merge https://chromium.googlesource.com/chromium/blink/+/3d60bec8e5dabfe877c482797d9ef430bfde31

This change forces the calls through the factory so that we create appropriate sub-classes based upon the passed tag name,
rather than just creating a concrete HTMLElement class with an inappropriate tag name.

Test: media/track/getCueAsHTMLCrash.html

* html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::createEquivalentHTMLElement):

LayoutTests: 

* media/track/getCueAsHTMLCrash-expected.txt: Added.
* media/track/getCueAsHTMLCrash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/WebVTTElement.cpp


Added Paths

trunk/LayoutTests/media/track/getCueAsHTMLCrash-expected.txt
trunk/LayoutTests/media/track/getCueAsHTMLCrash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (151470 => 151471)

--- trunk/LayoutTests/ChangeLog	2013-06-11 21:09:33 UTC (rev 151470)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 21:18:55 UTC (rev 151471)
@@ -1,3 +1,13 @@
+2013-06-11  Ryosuke Niwa  
+
+Use HTMLElementFactory to create equivalent elements in WebVTTElement
+https://bugs.webkit.org/show_bug.cgi?id=117423
+
+Reviewed by Eric Carlson.
+
+* media/track/getCueAsHTMLCrash-expected.txt: Added.
+* media/track/getCueAsHTMLCrash.html: Added.
+
 2013-06-11  Eric Carlson  
 
 [Mac] Update text track menu


Added: trunk/LayoutTests/media/track/getCueAsHTMLCrash-expected.txt (0 => 151471)

--- trunk/LayoutTests/media/track/getCueAsHTMLCrash-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/track/getCueAsHTMLCrash-expected.txt	2013-06-11 21:18:55 UTC (rev 151471)
@@ -0,0 +1 @@
+Test passes if it does not induce a crash.


Added: trunk/LayoutTests/media/track/getCueAsHTMLCrash.html (0 => 151471)

--- trunk/LayoutTests/media/track/getCueAsHTMLCrash.html	(rev 0)
+++ trunk/LayoutTests/media/track/getCueAsHTMLCrash.html	2013-06-11 21:18:55 UTC (rev 151471)
@@ -0,0 +1,21 @@
+
+
+Test passes if it does not induce a crash.
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+test(function() {
+var cue = new TextTrackCue(0, 1, 'x\0');
+window.fragment = cue.getCueAsHTML();
+}, document.title + ', creating the cue');
+
+test(function() {
+assert_false(fragment.childNodes[0].hasChildNodes(), 'hasChildNodes()');
+}, document.title + ', >');
+
+test(function() {}, document.title + ', ');
+test(function() {}, document.title + ', x\\0');
+
+


Modified: trunk/Source/WebCore/ChangeLog (151470 => 151471)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 21:09:33 UTC (rev 151470)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 21:18:55 UTC (rev 151471)
@@ -1,3 +1,20 @@
+2013-06-11  Ryosuke Niwa  
+
+Use HTMLElementFactory to create equivalent elements in WebVTTElement
+https://bugs.webkit.org/show_bug.cgi?id=117423
+
+Reviewed by Eric Carlson.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/3d60bec8e5dabfe877c482797d9ef430bfde31
+
+This change forces the calls through the factory so that we create appropriate sub-classes based upon the passed tag name,
+rather than just creating a concrete HTMLElement class with an inappropriate tag name.
+
+Test: media/track/getCueAsHTMLCrash.html
+
+* html/track/WebVTTElement.cpp:
+(WebCore::WebVTTElement::createEquivalentHTMLElement):
+
 2013-06-11  Benjamin Poulain  
 
 Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal


Modified: trunk/Source/WebCore/html/track/WebVTTElement.cpp (151470 => 151471)

--- trunk/Source/WebCore/html/track/WebVTTElement.cpp	2013-06-11 21:09:33 UTC (rev 151470)
+++ trunk/Source/WebCore/html/track/WebVTTElement.cpp	2013-06-11 21:18:55 UTC (rev 151471)
@@ -29,6 +29,7 @@
 
 #include "WebVTTElement.h"
 
+#include "HTMLElementFactory.h"
 #include "TextTrack.h"
 
 namespace WebCore {
@@ -93,24 +94,24 @@
 case WebVTTNodeTypeClass:
 case WebVTTNodeTypeLanguage:
 case WebVTTNodeTypeVoice:
-htmlElement = HTMLElement::create(HTMLNames::spanTag, document);
+htmlElement = HTMLElementFactory::createHTMLElement(HTMLNames::spanTag, document);
 htmlElement.get()->setAttribute(HTMLNames::titleAttr, getAttribute(voiceAttributeName()));
 htmlElement.get()->setAttribute(HTMLNames::langAttr, getAttribute(langAttributeName()));
 break;
 case WebVTTNodeTypeItalic:
-htmlElement = HTMLElement::create(HTMLNames::iTag, document);
+htmlElement = HTMLElementFactory::createHTMLElement(HTMLNames::iTag, document);
 break;
 case WebVTTNodeT

[webkit-changes] [151470] trunk/Source/WebCore

2013-06-11 Thread benjamin

Title: [151470] trunk/Source/WebCore








Revision 151470
Author benja...@webkit.org
Date 2013-06-11 14:09:33 -0700 (Tue, 11 Jun 2013)


Log Message
Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal
https://bugs.webkit.org/show_bug.cgi?id=117486

Patch by Benjamin Poulain  on 2013-06-11
Reviewed by Ryosuke Niwa.

Since this is pretty common, split the name selector to have the constant conditions
outside the traversal.

* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/SelectorQuery.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151469 => 151470)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 20:55:02 UTC (rev 151469)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 21:09:33 UTC (rev 151470)
@@ -1,3 +1,16 @@
+2013-06-11  Benjamin Poulain  
+
+Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal
+https://bugs.webkit.org/show_bug.cgi?id=117486
+
+Reviewed by Ryosuke Niwa.
+
+Since this is pretty common, split the name selector to have the constant conditions
+outside the traversal.
+
+* dom/SelectorQuery.cpp:
+(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
+
 2013-06-11  Eric Carlson  
 
 [Mac] Update text track menu


Modified: trunk/Source/WebCore/dom/SelectorQuery.cpp (151469 => 151470)

--- trunk/Source/WebCore/dom/SelectorQuery.cpp	2013-06-11 20:55:02 UTC (rev 151469)
+++ trunk/Source/WebCore/dom/SelectorQuery.cpp	2013-06-11 21:09:33 UTC (rev 151470)
@@ -155,19 +155,62 @@
 }
 
 template 
+static inline void elementsForLocalName(const Node* rootNode, const AtomicString& localName, Vector >& matchedElements)
+{
+for (Element* element = ElementTraversal::firstWithin(rootNode); element; element = ElementTraversal::next(element, rootNode)) {
+if (element->localName() == localName) {
+matchedElements.append(element);
+if (firstMatchOnly)
+return;
+}
+}
+}
+
+template 
+static inline void anyElement(const Node* rootNode, Vector >& matchedElements)
+{
+for (Element* element = ElementTraversal::firstWithin(rootNode); element; element = ElementTraversal::next(element, rootNode)) {
+matchedElements.append(element);
+if (firstMatchOnly)
+return;
+}
+}
+
+
+template 
 ALWAYS_INLINE void SelectorDataList::executeSingleTagNameSelectorData(const Node* rootNode, const SelectorData& selectorData, Vector >& matchedElements) const
 {
 ASSERT(m_selectors.size() == 1);
 ASSERT(isSingleTagNameSelector(selectorData.selector));
 
 const QualifiedName& tagQualifiedName = selectorData.selector->tagQName();
-for (Element* element = ElementTraversal::firstWithin(rootNode); element; element = ElementTraversal::next(element, rootNode)) {
-if (SelectorChecker::tagMatches(element, tagQualifiedName)) {
-matchedElements.append(element);
-if (firstMatchOnly)
-return;
+const AtomicString& selectorLocalName = tagQualifiedName.localName();
+const AtomicString& selectorNamespaceURI = tagQualifiedName.namespaceURI();
+
+if (selectorNamespaceURI == starAtom) {
+if (selectorLocalName != starAtom) {
+// Common case: name defined, selectorNamespaceURI is a wildcard.
+elementsForLocalName(rootNode, selectorLocalName, matchedElements);
+} else {
+// Other fairly common case: both are wildcards.
+anyElement(rootNode, matchedElements);
 }
+} else {
+// Fallback: NamespaceURI is set, selectorLocalName may be starAtom.
+for (Element* element = ElementTraversal::firstWithin(rootNode); element; element = ElementTraversal::next(element, rootNode)) {
+if (element->namespaceURI() == selectorNamespaceURI && (selectorLocalName == starAtom || element->localName() == selectorLocalName)) {
+matchedElements.append(element);
+if (firstMatchOnly)
+break;
+}
+}
 }
+#if !ASSERT_DISABLED
+for (size_t i = 0; i < matchedElements.size(); ++i) {
+ASSERT(matchedElements[i]->isElementNode());
+ASSERT(SelectorChecker::tagMatches(static_cast(matchedElements[i].get()), tagQualifiedName));
+}
+#endif
 }
 
 static bool isSingleClassNameSelector(const CSSSelector* selector)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151469] trunk

2013-06-11 Thread eric . carlson

Title: [151469] trunk








Revision 151469
Author eric.carl...@apple.com
Date 2013-06-11 13:55:02 -0700 (Tue, 11 Jun 2013)


Log Message
[Mac] Update text track menu
https://bugs.webkit.org/show_bug.cgi?id=117351

Reviewed by Darin Adler.

Source/WebCore: 

No new tests, existing tests updated.

* English.lproj/Localizable.strings: Update the menu title.

* page/CaptionUserPreferencesMac.mm: System language is no longer needed.

* platform/LocalizedStrings.cpp: Ditto.
* platform/LocalizedStrings.h:

LayoutTests: 

* media/video-controls-captions-trackmenu-localized.html:
* media/video-controls-captions-trackmenu-sorted.html:
* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html
trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html
trunk/LayoutTests/platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt
trunk/LayoutTests/platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt
trunk/LayoutTests/platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/page/CaptionUserPreferencesMac.mm
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/LocalizedStrings.h




Diff

Modified: trunk/LayoutTests/ChangeLog (151468 => 151469)

--- trunk/LayoutTests/ChangeLog	2013-06-11 20:53:31 UTC (rev 151468)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 20:55:02 UTC (rev 151469)
@@ -1,3 +1,16 @@
+2013-06-11  Eric Carlson  
+
+[Mac] Update text track menu
+https://bugs.webkit.org/show_bug.cgi?id=117351
+
+Reviewed by Darin Adler.
+
+* media/video-controls-captions-trackmenu-localized.html:
+* media/video-controls-captions-trackmenu-sorted.html:
+* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:
+* platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
+* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
+
 2013-06-11  Robert Hogan  
 
 Rebaseline results after r151451


Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html (151468 => 151469)

--- trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html	2013-06-11 20:53:31 UTC (rev 151468)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu-localized.html	2013-06-11 20:55:02 UTC (rev 151469)
@@ -40,8 +40,8 @@
 testExpected("item.textContent", "Off");
 
 item = captionsEntries[1];
-consoleWrite("Second item in captions menu should be labelled 'Automatic (English)'");
-testExpected("item.textContent", "Automatic (English)");
+consoleWrite("Second item in captions menu should be labelled 'Auto (Recommended)'");
+testExpected("item.textContent", "Auto (Recommended)");
 
 
 item = captionsEntries[2];


Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html (151468 => 151469)

--- trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html	2013-06-11 20:53:31 UTC (rev 151468)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu-sorted.html	2013-06-11 20:55:02 UTC (rev 151469)
@@ -41,7 +41,7 @@
 case 1:
 trackMenuItems = textTrackMenuItems();
 testExpected("trackMenuItems[0].textContent", "Off");
-testExpected("trackMenuItems[1].textContent", "Automatic (English)");
+testExpected("trackMenuItems[1].textContent", "Auto (Recommended)");
 testExpected("trackMenuItems[2].textContent", "u (English) SDH");
 testExpected("trackMenuItems[3].textContent", "y (English-Australia) SDH");
 testExpected("trackMenuItems[4].textContent", "v (English)");
@@ -62,7 +62,7 @@
 case 2:
 trackMenuItems = textTrackMenuItems();
 testExpected("trackMenuItems[0].textContent", "Off");
-testExpected("trackMenuItems[1].textContent", "Automatic (Japanese)");
+testExpected("trackMenuItems[1].textContent", "Auto (Recommended)");
 testExpected("trackMenuItems[2].textContent", "z (Japanese)");
 testExpected("trackMenuItems[3].textContent", "v (English)");
 testExpected("trackMenuItems[4].textContent", "x (English-Australia)");


Modified: trunk/LayoutTests/platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt (151468 => 151469)

--- trunk/LayoutTests/platform

[webkit-changes] [151468] branches/dfgFourthTier/Source/JavaScriptCore

2013-06-11 Thread mhahnenberg

Title: [151468] branches/dfgFourthTier/Source/_javascript_Core








Revision 151468
Author mhahnenb...@apple.com
Date 2013-06-11 13:53:31 -0700 (Tue, 11 Jun 2013)


Log Message
isContravenedByStructure is backwards
https://bugs.webkit.org/show_bug.cgi?id=117366

We should be checking if arrayModeForStructure(structure) is a 
subset of arrayModesThatPassFiltering(), not the other way around.
Also renamed isContravenedByStructure to better reflect what the 
function is trying to determine.

Rubber stamped by Filip Pizlo.

* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::structureWouldPassArrayModeFiltering):
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheckAccountingForArrayMode):
(JSC::DFG::ArrayTypeCheck::isContravenedByValue):

Modified Paths

branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGArrayMode.h
branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp




Diff

Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (151467 => 151468)

--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-11 20:43:38 UTC (rev 151467)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-11 20:53:31 UTC (rev 151468)
@@ -1,3 +1,21 @@
+2013-06-10  Mark Hahnenberg  
+
+isContravenedByStructure is backwards
+https://bugs.webkit.org/show_bug.cgi?id=117366
+
+We should be checking if arrayModeForStructure(structure) is a 
+subset of arrayModesThatPassFiltering(), not the other way around.
+Also renamed isContravenedByStructure to better reflect what the 
+function is trying to determine.
+
+Rubber stamped by Filip Pizlo.
+
+* dfg/DFGArrayMode.h:
+(JSC::DFG::ArrayMode::structureWouldPassArrayModeFiltering):
+* dfg/DFGTypeCheckHoistingPhase.cpp:
+(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheckAccountingForArrayMode):
+(JSC::DFG::ArrayTypeCheck::isContravenedByValue):
+
 2013-06-11  Mark Lam  
 
 Removed unused local variable to fix cab build.


Modified: branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGArrayMode.h (151467 => 151468)

--- branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGArrayMode.h	2013-06-11 20:43:38 UTC (rev 151467)
+++ branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGArrayMode.h	2013-06-11 20:53:31 UTC (rev 151468)
@@ -363,9 +363,9 @@
 return conversion() != Array::AsIs;
 }
 
-bool isContravenedByStructure(Structure* structure)
+bool structureWouldPassArrayModeFiltering(Structure* structure)
 {
-return !arrayModesAlreadyChecked(arrayModesThatPassFiltering(), arrayModeFromStructure(structure));
+return arrayModesAlreadyChecked(arrayModeFromStructure(structure), arrayModesThatPassFiltering());
 }
 
 ArrayModes arrayModesThatPassFiltering() const


Modified: branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp (151467 => 151468)

--- branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp	2013-06-11 20:43:38 UTC (rev 151467)
+++ branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp	2013-06-11 20:53:31 UTC (rev 151468)
@@ -545,7 +545,7 @@
 return;
 if (!result->value.m_arrayModeHoistingOkay || !result->value.m_arrayModeIsValid)
 return;
-if (!result->value.m_arrayMode.isContravenedByStructure(structure))
+if (result->value.m_arrayMode.structureWouldPassArrayModeFiltering(structure))
 return;
 result->value.disableCheckArrayHoisting();
 }
@@ -579,7 +579,7 @@
 static bool isContravenedByValue(CheckData& checkData, JSValue value)
 {
 ASSERT(value.isCell());
-return checkData.m_arrayMode.isContravenedByStructure(value.asCell()->structure());
+return !checkData.m_arrayMode.structureWouldPassArrayModeFiltering(value.asCell()->structure());
 }
 
 static bool hasEnoughVotesToHoist(VariableAccessData* variable)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151467] trunk/Source/WebCore

2013-06-11 Thread benjamin

Title: [151467] trunk/Source/WebCore








Revision 151467
Author benja...@webkit.org
Date 2013-06-11 13:43:38 -0700 (Tue, 11 Jun 2013)


Log Message
Fix the element type in the selector checkers
https://bugs.webkit.org/show_bug.cgi?id=117450

Patch by Benjamin Poulain  on 2013-06-11
Reviewed by Anders Carlsson.

* css/SelectorCheckerFastPath.cpp:
(WebCore::HTMLNames::checkClassValue):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeSingleClassNameSelectorData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorCheckerFastPath.cpp
trunk/Source/WebCore/dom/SelectorQuery.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151466 => 151467)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 20:40:32 UTC (rev 151466)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 20:43:38 UTC (rev 151467)
@@ -1,5 +1,17 @@
 2013-06-11  Benjamin Poulain  
 
+Fix the element type in the selector checkers
+https://bugs.webkit.org/show_bug.cgi?id=117450
+
+Reviewed by Anders Carlsson.
+
+* css/SelectorCheckerFastPath.cpp:
+(WebCore::HTMLNames::checkClassValue):
+* dom/SelectorQuery.cpp:
+(WebCore::SelectorDataList::executeSingleClassNameSelectorData):
+
+2013-06-11  Benjamin Poulain  
+
 Clean up the initializer mess in Document
 https://bugs.webkit.org/show_bug.cgi?id=117448
 


Modified: trunk/Source/WebCore/css/SelectorCheckerFastPath.cpp (151466 => 151467)

--- trunk/Source/WebCore/css/SelectorCheckerFastPath.cpp	2013-06-11 20:40:32 UTC (rev 151466)
+++ trunk/Source/WebCore/css/SelectorCheckerFastPath.cpp	2013-06-11 20:43:38 UTC (rev 151467)
@@ -75,7 +75,7 @@
 
 inline bool checkClassValue(const Element* element, const CSSSelector* selector)
 {
-return element->hasClass() && static_cast(element)->classNames().contains(selector->value());
+return element->hasClass() && element->classNames().contains(selector->value());
 }
 
 inline bool checkIDValue(const Element* element, const CSSSelector* selector)


Modified: trunk/Source/WebCore/dom/SelectorQuery.cpp (151466 => 151467)

--- trunk/Source/WebCore/dom/SelectorQuery.cpp	2013-06-11 20:40:32 UTC (rev 151466)
+++ trunk/Source/WebCore/dom/SelectorQuery.cpp	2013-06-11 20:43:38 UTC (rev 151467)
@@ -183,7 +183,7 @@
 
 const AtomicString& className = selectorData.selector->value();
 for (Element* element = ElementTraversal::firstWithin(rootNode); element; element = ElementTraversal::next(element, rootNode)) {
-if (element->hasClass() && static_cast(element)->classNames().contains(className)) {
+if (element->hasClass() && element->classNames().contains(className)) {
 matchedElements.append(element);
 if (firstMatchOnly)
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151465] trunk/Tools

2013-06-11 Thread timothy

Title: [151465] trunk/Tools








Revision 151465
Author timo...@apple.com
Date 2013-06-11 13:39:44 -0700 (Tue, 11 Jun 2013)


Log Message
Have build-webkit build the WebInspectorUI project.

* Scripts/build-webkit:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/ChangeLog (151464 => 151465)

--- trunk/Tools/ChangeLog	2013-06-11 20:12:02 UTC (rev 151464)
+++ trunk/Tools/ChangeLog	2013-06-11 20:39:44 UTC (rev 151465)
@@ -1,3 +1,9 @@
+2013-06-11  Timothy Hatcher  
+
+Have build-webkit build the WebInspectorUI project.
+
+* Scripts/build-webkit:
+
 2013-06-11  Ryosuke Niwa  
 
 Add an option to run-webkit-tests to skip java dependency check


Modified: trunk/Tools/Scripts/build-webkit (151464 => 151465)

--- trunk/Tools/Scripts/build-webkit	2013-06-11 20:12:02 UTC (rev 151464)
+++ trunk/Tools/Scripts/build-webkit	2013-06-11 20:39:44 UTC (rev 151465)
@@ -235,6 +235,8 @@
 # WebKit2 is only supported in SnowLeopard and later at present.
 push @projects, ("Source/WebKit2", "Tools/MiniBrowser") if osXVersion()->{"minor"} >= 6 and !$noWebKit2;
 
+push @projects, ("Source/WebInspectorUI");
+
 # Build Tools needed for Apple ports
 push @projects, ("Tools/DumpRenderTree", "Tools/WebKitTestRunner", "Source/ThirdParty/gtest", "Tools/TestWebKitAPI");
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151466] trunk/Source/WebCore

2013-06-11 Thread benjamin

Title: [151466] trunk/Source/WebCore








Revision 151466
Author benja...@webkit.org
Date 2013-06-11 13:40:32 -0700 (Tue, 11 Jun 2013)


Log Message
Clean up the initializer mess in Document
https://bugs.webkit.org/show_bug.cgi?id=117448

Patch by Benjamin Poulain  on 2013-06-11
Reviewed by Ryosuke Niwa.

Basic cleaning from
https://chromium.googlesource.com/chromium/blink/+/e54ba8d3b62b0245ecdf2f3ec11cd33b4035a4d7

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (151465 => 151466)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 20:39:44 UTC (rev 151465)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 20:40:32 UTC (rev 151466)
@@ -1,3 +1,17 @@
+2013-06-11  Benjamin Poulain  
+
+Clean up the initializer mess in Document
+https://bugs.webkit.org/show_bug.cgi?id=117448
+
+Reviewed by Ryosuke Niwa.
+
+Basic cleaning from
+https://chromium.googlesource.com/chromium/blink/+/e54ba8d3b62b0245ecdf2f3ec11cd33b4035a4d7
+
+* dom/Document.cpp:
+(WebCore::Document::Document):
+* dom/Document.h:
+
 2013-06-11  Jer Noble  
 
 Set the font size for in-band captions on the display box, not the :cue.


Modified: trunk/Source/WebCore/dom/Document.cpp (151465 => 151466)

--- trunk/Source/WebCore/dom/Document.cpp	2013-06-11 20:39:44 UTC (rev 151465)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-06-11 20:40:32 UTC (rev 151466)
@@ -393,28 +393,47 @@
 : ContainerNode(0, CreateDocument)
 , TreeScope(this)
 , m_styleResolverThrowawayTimer(this, &Document::styleResolverThrowawayTimerFired, timeBeforeThrowingAwayStyleResolverAfterLastUseInSeconds)
+, m_didCalculateStyleResolver(false)
+, m_hasNodesWithPlaceholderStyle(false)
+, m_needsNotifyRemoveAllPendingStylesheet(false)
+, m_ignorePendingStylesheets(false)
+, m_pendingSheetLayout(NoLayoutWithPendingSheets)
+, m_frame(frame)
 , m_activeParserCount(0)
 , m_contextFeatures(ContextFeatures::defaultSwitch())
+, m_wellFormed(false)
+, m_printing(false)
+, m_paginatedForScreen(false)
+, m_ignoreAutofocus(false)
 , m_compatibilityMode(NoQuirksMode)
 , m_compatibilityModeLocked(false)
+, m_textColor(Color::black)
 , m_domTreeVersion(++s_globalTreeVersion)
+, m_listenerTypes(0)
 , m_mutationObserverTypes(0)
 , m_styleSheetCollection(DocumentStyleSheetCollection::create(this))
 , m_visitedLinkState(VisitedLinkState::create(this))
+, m_visuallyOrdered(false)
 , m_readyState(Complete)
+, m_bParsing(false)
 , m_styleRecalcTimer(this, &Document::styleRecalcTimerFired)
 , m_pendingStyleRecalcShouldForce(false)
+, m_inStyleRecalc(false)
+, m_closeAfterStyleRecalc(false)
+, m_gotoAnchorNeededAfterStylesheetsLoad(false)
 , m_frameElementsShouldIgnoreScrolling(false)
 , m_containsValidityStyleRules(false)
 , m_updateFocusAppearanceRestoresSelection(false)
 , m_ignoreDestructiveWriteCount(0)
 , m_titleSetExplicitly(false)
 , m_updateFocusAppearanceTimer(this, &Document::updateFocusAppearanceTimerFired)
+, m_cssTarget(0)
+, m_processingLoadEvent(false)
 , m_loadEventFinished(false)
 , m_startTime(currentTime())
 , m_overMinimumLayoutThreshold(false)
 , m_scriptRunner(ScriptRunner::create(this))
-, m_xmlVersion("1.0")
+, m_xmlVersion(ASCIILiteral("1.0"))
 , m_xmlStandalone(StandaloneUnspecified)
 , m_hasXMLDeclaration(0)
 , m_savedRenderer(0)
@@ -466,12 +485,6 @@
 , m_didAssociateFormControlsTimer(this, &Document::didAssociateFormControlsTimerFired)
 , m_hasInjectedPlugInsScript(false)
 {
-m_printing = false;
-m_paginatedForScreen = false;
-
-m_ignoreAutofocus = false;
-
-m_frame = frame;
 if (m_frame)
 provideContextFeaturesToDocumentFrom(this, m_frame->page());
 
@@ -494,37 +507,14 @@
 #if ENABLE(TEXT_AUTOSIZING)
 m_textAutosizer = TextAutosizer::create(this);
 #endif
-m_visuallyOrdered = false;
-m_bParsing = false;
-m_wellFormed = false;
 
-m_textColor = Color::black;
-m_listenerTypes = 0;
-m_inStyleRecalc = false;
-m_closeAfterStyleRecalc = false;
-
-m_gotoAnchorNeededAfterStylesheetsLoad = false;
-
-m_didCalculateStyleResolver = false;
-m_ignorePendingStylesheets = false;
-m_needsNotifyRemoveAllPendingStylesheet = false;
-m_hasNodesWithPlaceholderStyle = false;
-m_pendingSheetLayout = NoLayoutWithPendingSheets;
-
-m_cssTarget = 0;
-
 resetLinkColor();
 resetVisitedLinkColor();
 resetActiveLinkColor();
 
-m_processingLoadEvent = false;
-
 initSecurityContext();
 initDNSPrefetch();
 
-static int docID = 0;
-m_docID = docID++;
-
 for (unsigned i = 0; i < WTF_ARRAY_LENGTH(m_nodeListCounts); i++)
 m_nodeListCoun

[webkit-changes] [151463] trunk/LayoutTests

2013-06-11 Thread robert

Title: [151463] trunk/LayoutTests








Revision 151463
Author rob...@webkit.org
Date 2013-06-11 13:08:03 -0700 (Tue, 11 Jun 2013)


Log Message
Rebaseline results after r151451

Unreviewed, gardening.

* platform/efl/fast/forms/button-positioned-expected.txt:
* platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/gtk/fast/forms/button-positioned-expected.txt:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/win/fast/forms/onselect-textfield-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/forms/button-positioned-expected.txt
trunk/LayoutTests/platform/efl/fast/forms/input-appearance-preventDefault-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/button-positioned-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/input-appearance-preventDefault-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt


Added Paths

trunk/LayoutTests/platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt
trunk/LayoutTests/platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt
trunk/LayoutTests/platform/win/fast/forms/onselect-textfield-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (151462 => 151463)

--- trunk/LayoutTests/ChangeLog	2013-06-11 20:03:08 UTC (rev 151462)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 20:08:03 UTC (rev 151463)
@@ -1,3 +1,18 @@
+2013-06-11  Robert Hogan  
+
+Rebaseline results after r151451
+
+Unreviewed, gardening.
+
+* platform/efl/fast/forms/button-positioned-expected.txt:
+* platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
+* platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
+* platform/gtk/fast/forms/button-positioned-expected.txt:
+* platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
+* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
+* platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
+* platform/win/fast/forms/onselect-textfield-expected.txt: Added.
+
 2013-06-11  Zan Dobersek  
 
 Unreviewed GTK gardening. Rebaselining various tests that are at the moment failing and need the new baseline.


Modified: trunk/LayoutTests/platform/efl/fast/forms/button-positioned-expected.txt (151462 => 151463)

--- trunk/LayoutTests/platform/efl/fast/forms/button-positioned-expected.txt	2013-06-11 20:03:08 UTC (rev 151462)
+++ trunk/LayoutTests/platform/efl/fast/forms/button-positioned-expected.txt	2013-06-11 20:08:03 UTC (rev 151463)
@@ -3,13 +3,13 @@
 layer at (0,0) size 800x600
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584
-layer at (10,10) size 211x40
-  RenderButton {BUTTON} at (10,10) size 211x40 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
-RenderBlock (anonymous) at (17,10) size 177x18
-  RenderText {#text} at (0,0) size 177x17
-text run at (0,0) width 177: "This button is positioned."
-layer at (10,10) size 241x40
-  RenderButton {INPUT} at (10,10) size 241x40 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
-RenderBlock (anonymous) at (17,10) size 207x18
-  RenderText at (0,0) size 207x17
-text run at (0,0) width 207: "This button is also positioned"
+layer at (10,10) size 245x22
+  RenderButton {BUTTON} at (10,10) size 245x22 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
+RenderBlock (anonymous) at (17,10) size 211x18
+  RenderText {#text} at (17,0) size 177x17
+text run at (17,0) width 177: "This button is positioned."
+layer at (10,10) size 275x22
+  RenderButton {INPUT} at (10,10) size 275x22 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
+RenderBlock (anonymous) at (17,10) size 241x18
+  RenderText at (17,0) size 207x17
+text run at (17,0) width 207: "This button is also positioned"


Modified: trunk/LayoutTests/platform/efl/fast/forms/input-appearance-preventDefault-expected.txt (151462 => 151463)

--- trunk/LayoutTests/platform/efl/fast/forms/input-appearance-preventDefault-expected.txt	2013-06-11 20:03:08 UTC (rev 151462)
+++ trunk/LayoutTests/platform/efl/fast/forms/input-appearance-preventDefault-expected.txt	2013-06-11 20:08:03 UTC (rev 151463)
@@ -8,10 +8,10 @@
 text run at (0,18) width 666: "This tests that preventDefault called onmousedown will prevent a caret from being placed in the text field."
   RenderText {#text} at (0,0) size 0x0
   RenderText {#text} at (0,0) size 0x0
-layer at (12,52) size 192x

[webkit-changes] [151462] trunk/Tools

2013-06-11 Thread rniwa

Title: [151462] trunk/Tools








Revision 151462
Author rn...@webkit.org
Date 2013-06-11 13:03:08 -0700 (Tue, 11 Jun 2013)


Log Message
Add an option to run-webkit-tests to skip java dependency check
https://bugs.webkit.org/show_bug.cgi?id=117516

Reviewed by Andreas Kling.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/port/mac.py:
(MacPort._check_port_build):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/port/mac.py




Diff

Modified: trunk/Tools/ChangeLog (151461 => 151462)

--- trunk/Tools/ChangeLog	2013-06-11 20:02:03 UTC (rev 151461)
+++ trunk/Tools/ChangeLog	2013-06-11 20:03:08 UTC (rev 151462)
@@ -1,3 +1,15 @@
+2013-06-11  Ryosuke Niwa  
+
+Add an option to run-webkit-tests to skip java dependency check
+https://bugs.webkit.org/show_bug.cgi?id=117516
+
+Reviewed by Andreas Kling.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(parse_args):
+* Scripts/webkitpy/port/mac.py:
+(MacPort._check_port_build):
+
 2013-06-11  Alex Christensen  
 
 https://bugs.webkit.org/show_bug.cgi?id=117514


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (151461 => 151462)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2013-06-11 20:02:03 UTC (rev 151461)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2013-06-11 20:03:08 UTC (rev 151462)
@@ -196,7 +196,9 @@
 optparse.make_option("--nocheck-sys-deps", action=""
 default=False,
 help="Don't check the system dependencies (themes)"),
-
+optparse.make_option("--nojava", action=""
+default=False,
+help="Don't build java support files"),
 ]))
 
 option_group_definitions.append(("Testing Options", [


Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (151461 => 151462)

--- trunk/Tools/Scripts/webkitpy/port/mac.py	2013-06-11 20:02:03 UTC (rev 151461)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py	2013-06-11 20:03:08 UTC (rev 151462)
@@ -168,7 +168,7 @@
 _log.info("%s unique leaks found!" % unique_leaks)
 
 def _check_port_build(self):
-return self._build_java_test_support()
+return self.get_option('nojava') or self._build_java_test_support()
 
 def _path_to_webcore_library(self):
 return self._build_path('WebCore.framework/Versions/A/WebCore')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151461] trunk/Tools

2013-06-11 Thread achristensen

Title: [151461] trunk/Tools








Revision 151461
Author achristen...@apple.com
Date 2013-06-11 13:02:03 -0700 (Tue, 11 Jun 2013)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=117514
Removed extra Xcode code coverage flags.

Reviewed by Sam Weinig.

* Scripts/webkitdirs.pm:
(XcodeCoverageSupportOptions):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (151460 => 151461)

--- trunk/Tools/ChangeLog	2013-06-11 19:58:28 UTC (rev 151460)
+++ trunk/Tools/ChangeLog	2013-06-11 20:02:03 UTC (rev 151461)
@@ -1,3 +1,13 @@
+2013-06-11  Alex Christensen  
+
+https://bugs.webkit.org/show_bug.cgi?id=117514
+Removed extra Xcode code coverage flags.
+
+Reviewed by Sam Weinig.
+
+* Scripts/webkitdirs.pm:
+(XcodeCoverageSupportOptions):
+
 2013-06-11  Brent Fulgham  
 
 [Windows] Implement 'attributeValue' accessor to support testing


Modified: trunk/Tools/Scripts/webkitdirs.pm (151460 => 151461)

--- trunk/Tools/Scripts/webkitdirs.pm	2013-06-11 19:58:28 UTC (rev 151460)
+++ trunk/Tools/Scripts/webkitdirs.pm	2013-06-11 20:02:03 UTC (rev 151461)
@@ -601,9 +601,6 @@
 my @coverageSupportOptions = ();
 push @coverageSupportOptions, "GCC_GENERATE_TEST_COVERAGE_FILES=YES";
 push @coverageSupportOptions, "GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES";
-push @coverageSupportOptions, "EXTRA_LINK= \$(EXTRA_LINK) -ftest-coverage -fprofile-arcs";
-push @coverageSupportOptions, "OTHER_CFLAGS= \$(OTHER_CFLAGS) -DCOVERAGE -MD";
-push @coverageSupportOptions, "OTHER_LDFLAGS=\$(OTHER_LDFLAGS) -ftest-coverage -fprofile-arcs -lgcov";
 return @coverageSupportOptions;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151460] trunk/Source/WebCore

2013-06-11 Thread jer . noble

Title: [151460] trunk/Source/WebCore








Revision 151460
Author jer.no...@apple.com
Date 2013-06-11 12:58:28 -0700 (Tue, 11 Jun 2013)


Log Message
Set the font size for in-band captions on the display box, not the :cue.
https://bugs.webkit.org/show_bug.cgi?id=117515

Reviewed by Eric Carlson.

Make the in-band font size behavior match the out-of-band behavior.

* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setFontSize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151459 => 151460)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 19:53:06 UTC (rev 151459)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 19:58:28 UTC (rev 151460)
@@ -1,3 +1,15 @@
+2013-06-11  Jer Noble  
+
+Set the font size for in-band captions on the display box, not the :cue.
+https://bugs.webkit.org/show_bug.cgi?id=117515
+
+Reviewed by Eric Carlson.
+
+Make the in-band font size behavior match the out-of-band behavior.
+
+* html/track/TextTrackCueGeneric.cpp:
+(WebCore::TextTrackCueGeneric::setFontSize):
+
 2013-06-11  Brent Fulgham  
 
 [Windows] Implement 'attributeValue' accessor to support testing.


Modified: trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp (151459 => 151460)

--- trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp	2013-06-11 19:53:06 UTC (rev 151459)
+++ trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp	2013-06-11 19:58:28 UTC (rev 151460)
@@ -147,7 +147,7 @@
 double size = videoSize.height() * baseFontSizeRelativeToVideoHeight() / 100;
 if (fontSizeMultiplier())
 size *= fontSizeMultiplier() / 100;
-element()->setInlineStyleProperty(CSSPropertyFontSize, String::number(lround(size)) + "px");
+displayTreeInternal()->setInlineStyleProperty(CSSPropertyFontSize, String::number(lround(size)) + "px");
 
 LOG(Media, "TextTrackCueGeneric::setFontSize - setting cue font size to %li", lround(size));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151459] trunk

2013-06-11 Thread bfulgham

Title: [151459] trunk








Revision 151459
Author bfulg...@apple.com
Date 2013-06-11 12:53:06 -0700 (Tue, 11 Jun 2013)


Log Message
Source/WebCore: [Windows] Implement 'attributeValue' accessor to support testing.
https://bugs.webkit.org/show_bug.cgi?id=117513

Reviewed by Anders Carlsson.

* WebCore.vcxproj/WebCore.vcxproj: Add new implementation file.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* accessibility/win/AccessibilityObjectWrapperWin.cpp: Added.
* accessibility/win/AccessibilityObjectWrapperWin.h: Add declaration

Source/WebKit/win: [Windows] Implement 'attributeValue' accessor to support testing.
https://bugs.webkit.org/show_bug.cgi?id=117513

Reviewed by Anders Carlsson.

* AccessibleBase.cpp:
(AccessibleBase::attributeValue): Added.
* AccessibleBase.h: Added method declaration.
* Interfaces/AccessibleComparable.idl: New accessor interface.

Tools: [Windows] Implement 'attributeValue' accessor to support testing
https://bugs.webkit.org/show_bug.cgi?id=117513

Reviewed by Anders Carlsson.

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(comparableObject): Move earlier in file.
(findAccessibleObjectById): New implemenation.
(AccessibilityController::accessibleElementById): New implementation.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.h
trunk/Source/WebKit/win/AccessibleBase.cpp
trunk/Source/WebKit/win/AccessibleBase.h
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/AccessibleComparable.idl
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/AccessibilityControllerWin.cpp


Added Paths

trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151458 => 151459)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 19:49:40 UTC (rev 151458)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 19:53:06 UTC (rev 151459)
@@ -1,3 +1,15 @@
+2013-06-11  Brent Fulgham  
+
+[Windows] Implement 'attributeValue' accessor to support testing.
+https://bugs.webkit.org/show_bug.cgi?id=117513
+
+Reviewed by Anders Carlsson.
+
+* WebCore.vcxproj/WebCore.vcxproj: Add new implementation file.
+* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
+* accessibility/win/AccessibilityObjectWrapperWin.cpp: Added.
+* accessibility/win/AccessibilityObjectWrapperWin.h: Add declaration
+
 2013-05-27  Robert Hogan  
 
 Positioned Replaced Elements That Aren't RenderReplaced get Incorrect Width


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (151458 => 151459)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-06-11 19:49:40 UTC (rev 151458)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-06-11 19:53:06 UTC (rev 151459)
@@ -3882,6 +3882,7 @@
   true
   true
 
+
 
 
 
@@ -13532,4 +13533,4 @@
   
   
   
-
\ No newline at end of file
+


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (151458 => 151459)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-06-11 19:49:40 UTC (rev 151458)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-06-11 19:53:06 UTC (rev 151459)
@@ -687,6 +687,9 @@
 
   accessibility
 
+
+  accessibility\win
+
 
   accessibility\win
 
@@ -2432,6 +2435,7 @@
 
 
   rendering
+
 
   rendering
 
@@ -2444,7 +2448,6 @@
 
   rendering
 
-
 
   rendering
 


Added: trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp (0 => 151459)

--- trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp	(rev 0)
+++ trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp	2013-06-11 19:53:06 UTC (rev 151459)
@@ -0,0 +1,52 @@
+/*
+ * Copyright (C) 2013 Apple Inc. All Rights Reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED T

[webkit-changes] [151458] trunk/LayoutTests

2013-06-11 Thread zandobersek

Title: [151458] trunk/LayoutTests








Revision 151458
Author zandober...@gmail.com
Date 2013-06-11 12:49:40 -0700 (Tue, 11 Jun 2013)


Log Message
Unreviewed GTK gardening. Rebaselining various tests that are at the moment failing and need the new baseline.

* platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/gtk/editing/pasteboard/4944770-2-expected.txt:
* platform/gtk/editing/pasteboard/8145-2-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/4944770-2-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/8145-2-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-text-008-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt
trunk/LayoutTests/platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (151457 => 151458)

--- trunk/LayoutTests/ChangeLog	2013-06-11 19:37:04 UTC (rev 151457)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 19:49:40 UTC (rev 151458)
@@ -1,3 +1,18 @@
+2013-06-11  Zan Dobersek  
+
+Unreviewed GTK gardening. Rebaselining various tests that are at the moment failing and need the new baseline.
+
+* platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
+* platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
+* platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
+* platform/gtk/editing/pasteboard/4944770-2-expected.txt:
+* platform/gtk/editing/pasteboard/8145-2-expected.txt:
+* platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
+* platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
+* platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
+* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
+* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:
+
 2013-05-27  Robert Hogan  
 
 Positioned Replaced Elements That Aren't RenderReplaced get Incorrect Width


Modified: trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt (151457 => 151458)

--- trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt	2013-06-11 19:37:04 UTC (rev 151457)
+++ trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt	2013-06-11 19:49:40 UTC (rev 151458)
@@ -18,5 +18,4 @@
 RenderBlock {DIV} at (14,14) size 756x26
   RenderText {#text} at (0,0) size 84x26
 text run at (0,0) width 84: "OneTwo"
-  RenderText {#text} at (0,0) size 0x0
 caret: position 4 of child 0 {#text} of child 1 {DIV} of child 1 {DIV} of body


Modified: trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt (151457 => 151458)

--- trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt	2013-06-11 19:37:04 UTC (rev 151457)
+++ trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt	2013-06-11 19:49:40 UTC (rev 151458)
@@ -21,5 +21,4 @@
 RenderBlock {DIV} at (0,0) size 784x54 [border: (2px solid #FF)]
   RenderText {#text} at (14,14) size 34x26
 text run at (14,14) width 34: "XX"
-  RenderText {#text} at (0,0) size 0x0
 caret: position 2 of child 0 {#text} of child 1 {DIV} of child 3 {DIV} of body


Modified: trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt (151457 => 151458)

--- trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt	2013-06-11 19:37:04 UTC (rev 151457)
+++ trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt	2013-06-11 19:49:40

[webkit-changes] [151457] tags/Safari-537.44.1/WebKitLibraries

2013-06-11 Thread lforschler

Title: [151457] tags/Safari-537.44.1/WebKitLibraries








Revision 151457
Author lforsch...@apple.com
Date 2013-06-11 12:37:04 -0700 (Tue, 11 Jun 2013)


Log Message
Rollout of r151408.  

Modified Paths

tags/Safari-537.44.1/WebKitLibraries/ChangeLog


Added Paths

tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make


Removed Paths

tags/Safari-537.44.1/WebKitLibraries/win/WinTools.make
tags/Safari-537.44.1/WebKitLibraries/win/tools64/




Diff

Modified: tags/Safari-537.44.1/WebKitLibraries/ChangeLog (151456 => 151457)

--- tags/Safari-537.44.1/WebKitLibraries/ChangeLog	2013-06-11 19:20:30 UTC (rev 151456)
+++ tags/Safari-537.44.1/WebKitLibraries/ChangeLog	2013-06-11 19:37:04 UTC (rev 151457)
@@ -1,5 +1,9 @@
 2013-06-11  Lucas Forschler  
 
+Rollout r151408 (151452 on tag)
+
+2013-06-11  Lucas Forschler  
+
 Merge r151408
 
 2013-06-10  Roger Fong  


Deleted: tags/Safari-537.44.1/WebKitLibraries/win/WinTools.make (151456 => 151457)

--- tags/Safari-537.44.1/WebKitLibraries/win/WinTools.make	2013-06-11 19:20:30 UTC (rev 151456)
+++ tags/Safari-537.44.1/WebKitLibraries/win/WinTools.make	2013-06-11 19:37:04 UTC (rev 151457)
@@ -1,5 +0,0 @@
-install:
-xcopy "$(SRCROOT)\tools32\vsprops\*.props" "$(DSTROOT)\AppleInternal\tools32\vsprops" /e/v/i/h/y
-xcopy "$(SRCROOT)\tools32\scripts\*" "$(DSTROOT)\AppleInternal\tools32\scripts" /e/v/i/h/y
-xcopy "$(SRCROOT)\tools64\vsprops\*.props" "$(DSTROOT)\AppleInternal\tools64\vsprops" /e/v/i/h/y
-xcopy "$(SRCROOT)\tools64\scripts\*" "$(DSTROOT)\AppleInternal\tools64\scripts" /e/v/i/h/y
\ No newline at end of file


Copied: tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make (from rev 151407, trunk/WebKitLibraries/win/tools32/WinTools.make) (0 => 151457)

--- tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make	(rev 0)
+++ tags/Safari-537.44.1/WebKitLibraries/win/tools32/WinTools.make	2013-06-11 19:37:04 UTC (rev 151457)
@@ -0,0 +1,3 @@
+install:
+xcopy "$(SRCROOT)\vsprops\*.props" "$(DSTROOT)\AppleInternal\tools32\vsprops" /e/v/i/h/y
+xcopy "$(SRCROOT)\scripts\*" "$(DSTROOT)\AppleInternal\tools32\scripts" /e/v/i/h/y






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151456] branches/dfgFourthTier/Source/JavaScriptCore

2013-06-11 Thread mark . lam

Title: [151456] branches/dfgFourthTier/Source/_javascript_Core








Revision 151456
Author mark@apple.com
Date 2013-06-11 12:20:30 -0700 (Tue, 11 Jun 2013)


Log Message
Removed unused local variable to fix cab build.

Unreviewed.

* interpreter/StackIterator.cpp:
(JSC::StackIterator::Frame::logicalFrame):

Modified Paths

branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/interpreter/StackIterator.cpp




Diff

Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (151455 => 151456)

--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-11 19:17:00 UTC (rev 151455)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-11 19:20:30 UTC (rev 151456)
@@ -1,3 +1,12 @@
+2013-06-11  Mark Lam  
+
+Removed unused local variable to fix cab build.
+
+Unreviewed.
+
+* interpreter/StackIterator.cpp:
+(JSC::StackIterator::Frame::logicalFrame):
+
 2013-06-11  Filip Pizlo  
 
 fourthTier: Type check hoisting phase has a dead if statement


Modified: branches/dfgFourthTier/Source/_javascript_Core/interpreter/StackIterator.cpp (151455 => 151456)

--- branches/dfgFourthTier/Source/_javascript_Core/interpreter/StackIterator.cpp	2013-06-11 19:17:00 UTC (rev 151455)
+++ branches/dfgFourthTier/Source/_javascript_Core/interpreter/StackIterator.cpp	2013-06-11 19:20:30 UTC (rev 151456)
@@ -248,9 +248,8 @@
 if (!codeOrigin.inlineCallFrame)
 return this; // Not currently in inlined code.
 
-// We've got inlined frames. So, reify them so that the iterator can walk thru them.
+// We've got inlined frames. So, reify them so that the iterator can walk through them.
 CallFrame* currFrame = this->callFrame();
-CodeOrigin innerMostCodeOrigin = codeOrigin;
 CallFrame* innerMostLogicalFrame = currFrame + codeOrigin.inlineCallFrame->stackOffset;
 
 CallFrame* logicalFrame = innerMostLogicalFrame;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151455] trunk

2013-06-11 Thread timothy

Title: [151455] trunk








Revision 151455
Author timo...@apple.com
Date 2013-06-11 12:17:00 -0700 (Tue, 11 Jun 2013)


Log Message
Add WebInspectorUI to the Makefile.

Reviewed by Mark Rowe.

* Source/Makefile:

Modified Paths

trunk/ChangeLog
trunk/Source/Makefile




Diff

Modified: trunk/ChangeLog (151454 => 151455)

--- trunk/ChangeLog	2013-06-11 19:16:51 UTC (rev 151454)
+++ trunk/ChangeLog	2013-06-11 19:17:00 UTC (rev 151455)
@@ -1,3 +1,11 @@
+2013-06-06  Timothy Hatcher  
+
+Add WebInspectorUI to the Makefile.
+
+Reviewed by Mark Rowe.
+
+* Source/Makefile:
+
 2013-06-11  Seokju Kwon  
 
 Remove leftover wxWebkit code


Modified: trunk/Source/Makefile (151454 => 151455)

--- trunk/Source/Makefile	2013-06-11 19:16:51 UTC (rev 151454)
+++ trunk/Source/Makefile	2013-06-11 19:17:00 UTC (rev 151455)
@@ -1,4 +1,4 @@
-MODULES = WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2
+MODULES = WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2 WebInspectorUI
 
 ifneq (,$(findstring iphoneos,$(SDKROOT)))
 	MODULES = WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151454] trunk/Source

2013-06-11 Thread timothy

Title: [151454] trunk/Source








Revision 151454
Author timo...@apple.com
Date 2013-06-11 12:16:51 -0700 (Tue, 11 Jun 2013)


Log Message
Update the framework bundle identifier for the Web Inspector.

Reviewed by Mark Rowe.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
(WebInspectorFrontendClient::localizedStringsURL):
(-[WebInspectorWindowController inspectorPagePath]):

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::localizedStringsURL):

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebInspectorMac.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (151453 => 151454)

--- trunk/Source/WebKit/mac/ChangeLog	2013-06-11 19:16:26 UTC (rev 151453)
+++ trunk/Source/WebKit/mac/ChangeLog	2013-06-11 19:16:51 UTC (rev 151454)
@@ -1,3 +1,14 @@
+2013-06-06  Timothy Hatcher  
+
+Update the framework bundle identifier for the Web Inspector.
+
+Reviewed by Mark Rowe.
+
+* WebCoreSupport/WebInspectorClient.mm:
+(useWebKitWebInspector):
+(WebInspectorFrontendClient::localizedStringsURL):
+(-[WebInspectorWindowController inspectorPagePath]):
+
 2013-06-05  Bear Travis  
 
 [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags


Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (151453 => 151454)

--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2013-06-11 19:16:26 UTC (rev 151453)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2013-06-11 19:16:51 UTC (rev 151454)
@@ -54,7 +54,7 @@
 #import 
 #import 
 
-SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL(WebInspector, PrivateFrameworks, A)
+SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL(WebInspectorUI, PrivateFrameworks, A)
 
 // The margin from the top and right of the dock button (same as the full screen button).
 static const CGFloat dockButtonMargin = 3;
@@ -221,9 +221,9 @@
 static bool useWebKitWebInspector()
 {
 // Call the soft link framework function to dlopen it, then [NSBundle bundleWithIdentifier:] will work.
-WebInspectorLibrary();
+WebInspectorUILibrary();
 
-if (![[NSBundle bundleWithIdentifier:@"com.apple.WebInspector"] pathForResource:@"Main" ofType:@"html"])
+if (![[NSBundle bundleWithIdentifier:@"com.apple.WebInspectorUI"] pathForResource:@"Main" ofType:@"html"])
 return true;
 
 if (![[NSBundle bundleWithIdentifier:@"com.apple.WebCore"] pathForResource:@"inspector" ofType:@"html" inDirectory:@"inspector"])
@@ -234,7 +234,7 @@
 
 String WebInspectorFrontendClient::localizedStringsURL()
 {
-NSBundle *bundle = useWebKitWebInspector() ? [NSBundle bundleWithIdentifier:@"com.apple.WebCore"] : [NSBundle bundleWithIdentifier:@"com.apple.WebInspector"]; 
+NSBundle *bundle = useWebKitWebInspector() ? [NSBundle bundleWithIdentifier:@"com.apple.WebCore"] : [NSBundle bundleWithIdentifier:@"com.apple.WebInspectorUI"];
 NSString *path = [bundle pathForResource:@"localizedStrings" ofType:@"js"];
 if ([path length])
 return [[NSURL fileURLWithPath:path] absoluteString];
@@ -430,7 +430,7 @@
 if (useWebKitWebInspector())
 path = [[NSBundle bundleWithIdentifier:@"com.apple.WebCore"] pathForResource:@"inspector" ofType:@"html" inDirectory:@"inspector"];
 else
-path = [[NSBundle bundleWithIdentifier:@"com.apple.WebInspector"] pathForResource:@"Main" ofType:@"html"];
+path = [[NSBundle bundleWithIdentifier:@"com.apple.WebInspectorUI"] pathForResource:@"Main" ofType:@"html"];
 
 ASSERT([path length]);
 return path;


Modified: trunk/Source/WebKit2/ChangeLog (151453 => 151454)

--- trunk/Source/WebKit2/ChangeLog	2013-06-11 19:16:26 UTC (rev 151453)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 19:16:51 UTC (rev 151454)
@@ -1,3 +1,17 @@
+2013-06-06  Timothy Hatcher  
+
+Update the framework bundle identifier for the Web Inspector.
+
+Reviewed by Mark Rowe.
+
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::inspectorReallyUsesWebKitUserInterface):
+(WebKit::WebInspectorProxy::inspectorPageURL):
+(WebKit::WebInspectorProxy::inspectorBaseURL):
+* WebProcess/WebPage/mac/WebInspectorMac.mm:
+(WebKit::inspectorReallyUsesWebKitUserInterface):
+(WebKit::WebInspector::localizedStringsURL):
+
 2013-06-11  Jer Noble  
 
 Do not filter cookies requested through the CookieStorageShim.


Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (151453 => 151454)

--- trunk/Source/We

[webkit-changes] [151451] trunk

2013-06-11 Thread robert

Title: [151451] trunk








Revision 151451
Author rob...@webkit.org
Date 2013-06-11 12:03:09 -0700 (Tue, 11 Jun 2013)


Log Message
Positioned Replaced Elements That Aren't RenderReplaced get Incorrect Width
https://bugs.webkit.org/show_bug.cgi?id=93735

Reviewed by Darin Adler.

Source/WebCore:

Replaced elements that aren't RenderReplaced aren't |isReplaced| and don't have an
intrinsic height or width. This causes them to go down the wrong height and width computation
path in RenderBox when they are absolute positioned.

The notion of |isReplaced| is entwined with the notion of being |isInline| so it isn't really
possible to make them isReplaced without re-wiring a lot of code. So instead use an ad-hoc definition
of isReplacedElement in RenderBox to bring all replaced elements into the height and width calculation.
To make sure we get the right height and width in there, give non-RenderReplaced replaced renderers
the helpers for returning their approximation of intrinsic height and width.

Test: fast/replaced/width-and-height-of-positioned-replaced-elements.html

* rendering/RenderBox.cpp:
(WebCore::isReplacedElement):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
* rendering/RenderButton.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.h:
* rendering/RenderReplaced.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControl.h:

LayoutTests:

* fast/forms/onselect-textfield-expected.txt:
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements.html: Added.
* platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/mac/fast/forms/button-positioned-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/qt/fast/forms/button-positioned-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/onselect-textfield-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt
trunk/LayoutTests/platform/qt/fast/forms/button-positioned-expected.txt
trunk/LayoutTests/platform/qt/fast/forms/input-appearance-preventDefault-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderButton.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
trunk/Source/WebCore/rendering/RenderMenuList.h
trunk/Source/WebCore/rendering/RenderReplaced.h
trunk/Source/WebCore/rendering/RenderTextControl.cpp
trunk/Source/WebCore/rendering/RenderTextControl.h


Added Paths

trunk/LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png
trunk/LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt
trunk/LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements.html
trunk/LayoutTests/platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt
trunk/LayoutTests/platform/mac-wk2/fast/replaced/
trunk/LayoutTests/platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (151450 => 151451)

--- trunk/LayoutTests/ChangeLog	2013-06-11 19:02:20 UTC (rev 151450)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 19:03:09 UTC (rev 151451)
@@ -1,3 +1,21 @@
+2013-05-27  Robert Hogan  
+
+Positioned Replaced Elements That Aren't RenderReplaced get Incorrect Width
+https://bugs.webkit.org/show_bug.cgi?id=93735
+
+Reviewed by Darin Adler.
+
+* fast/forms/onselect-textfield-expected.txt:
+* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
+* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
+* fast/replaced/width-and-height-of-positioned-replaced-elements.html: Added.
+* platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
+* platform/mac/fast/forms/button-positioned-expected.txt:
+* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
+* platform/mac/fast/replaced/width-an

[webkit-changes] [151450] tags/Safari-537.44.1/Source

2013-06-11 Thread lforschler

Title: [151450] tags/Safari-537.44.1/Source








Revision 151450
Author lforsch...@apple.com
Date 2013-06-11 12:02:20 -0700 (Tue, 11 Jun 2013)


Log Message
Versioning.

Modified Paths

tags/Safari-537.44.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-537.44.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-537.44.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-537.44.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-537.44.1/Source/_javascript_Core/Configurations/Version.xcconfig (151449 => 151450)

--- tags/Safari-537.44.1/Source/_javascript_Core/Configurations/Version.xcconfig	2013-06-11 18:48:59 UTC (rev 151449)
+++ tags/Safari-537.44.1/Source/_javascript_Core/Configurations/Version.xcconfig	2013-06-11 19:02:20 UTC (rev 151450)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 44;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-537.44.1/Source/WebCore/Configurations/Version.xcconfig (151449 => 151450)

--- tags/Safari-537.44.1/Source/WebCore/Configurations/Version.xcconfig	2013-06-11 18:48:59 UTC (rev 151449)
+++ tags/Safari-537.44.1/Source/WebCore/Configurations/Version.xcconfig	2013-06-11 19:02:20 UTC (rev 151450)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 44;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-537.44.1/Source/WebKit/mac/Configurations/Version.xcconfig (151449 => 151450)

--- tags/Safari-537.44.1/Source/WebKit/mac/Configurations/Version.xcconfig	2013-06-11 18:48:59 UTC (rev 151449)
+++ tags/Safari-537.44.1/Source/WebKit/mac/Configurations/Version.xcconfig	2013-06-11 19:02:20 UTC (rev 151450)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 44;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-537.44.1/Source/WebKit2/Configurations/Version.xcconfig (151449 => 151450)

--- tags/Safari-537.44.1/Source/WebKit2/Configurations/Version.xcconfig	2013-06-11 18:48:59 UTC (rev 151449)
+++ tags/Safari-537.44.1/Source/WebKit2/Configurations/Version.xcconfig	2013-06-11 19:02:20 UTC (rev 151450)
@@ -23,8 +23,8 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 44;
-TINY_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
+TINY_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151448] trunk/LayoutTests

2013-06-11 Thread robert

Title: [151448] trunk/LayoutTests








Revision 151448
Author rob...@webkit.org
Date 2013-06-11 11:48:44 -0700 (Tue, 11 Jun 2013)


Log Message
Add baselines for test added in r151444

Unreviewed.

* platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
* platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
trunk/LayoutTests/platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (151447 => 151448)

--- trunk/LayoutTests/ChangeLog	2013-06-11 18:48:08 UTC (rev 151447)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 18:48:44 UTC (rev 151448)
@@ -1,3 +1,12 @@
+2013-06-11  Robert Hogan  
+
+Add baselines for test added in r151444
+
+Unreviewed.
+
+* platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
+* platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
+
 2013-06-03  Robert Hogan  
 
 Painting collapsed borders during scrolling


Added: trunk/LayoutTests/platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt (0 => 151448)

--- trunk/LayoutTests/platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	2013-06-11 18:48:44 UTC (rev 151448)
@@ -0,0 +1,16 @@
+layer at (0,0) size 1076x1796
+  RenderView at (0,0) size 785x585
+layer at (0,0) size 785x1796
+  RenderBlock {HTML} at (0,0) size 785x1796
+RenderBody {BODY} at (8,8) size 769x1780
+  RenderTable {TABLE} at (0,0) size 1068x1780 [color=#FF] [border: (178px none #808080)]
+RenderTableSection {TBODY} at (178,178) size 712x1424
+  RenderTableRow {TR} at (0,0) size 712x712
+RenderTableCell {TD} at (0,0) size 712x712 [border: (178px solid #FF)] [r=0 c=0 rs=1 cs=1]
+  RenderText {#text} at (178,178) size 356x356
+text run at (178,178) width 356: "B"
+  RenderTableRow {TR} at (0,712) size 712x712
+RenderTableCell {TD} at (0,712) size 712x712 [border: (178px solid #FF) (178px solid #00)] [r=1 c=0 rs=1 cs=1]
+  RenderText {#text} at (178,178) size 356x356
+text run at (178,178) width 356: "Y"
+scrolled to 0,1000
Property changes on: trunk/LayoutTests/platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt (0 => 151448)

--- trunk/LayoutTests/platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	2013-06-11 18:48:44 UTC (rev 151448)
@@ -0,0 +1,16 @@
+layer at (0,0) size 1076x1796
+  RenderView at (0,0) size 785x585
+layer at (0,0) size 785x1796
+  RenderBlock {HTML} at (0,0) size 785x1796
+RenderBody {BODY} at (8,8) size 769x1780
+  RenderTable {TABLE} at (0,0) size 1068x1780 [color=#FF] [border: (178px none #808080)]
+RenderTableSection {TBODY} at (178,178) size 712x1424
+  RenderTableRow {TR} at (0,0) size 712x712
+RenderTableCell {TD} at (0,0) size 712x712 [border: (178px solid #FF)] [r=0 c=0 rs=1 cs=1]
+  RenderText {#text} at (178,178) size 356x356
+text run at (178,178) width 356: "B"
+  RenderTableRow {TR} at (0,712) size 712x712
+RenderTableCell {TD} at (0,712) size 712x712 [border: (178px solid #FF) (178px solid #00)] [r=1 c=0 rs=1 cs=1]
+  RenderText {#text} at (178,178) size 356x356
+text run at (178,178) width 356: "Y"
+scrolled to 0,1000
Property changes on: trunk/LayoutTests/platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151447] trunk/Source/WebKit2

2013-06-11 Thread jer . noble

Title: [151447] trunk/Source/WebKit2








Revision 151447
Author jer.no...@apple.com
Date 2013-06-11 11:48:08 -0700 (Tue, 11 Jun 2013)


Log Message
Do not filter cookies requested through the CookieStorageShim.
https://bugs.webkit.org/show_bug.cgi?id=117511


Reviewed by Beth Dakin.

Since the shim function is called when the underlying media engine is
creating an HTTPRequest, use CookieRequestHeaderFieldValue (which does
not filter out HTTP-only cookies) rather than CookiesForDOM (which does).

* Shared/mac/CookieStorageShim.cpp:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/CookieStorageShim.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (151446 => 151447)

--- trunk/Source/WebKit2/ChangeLog	2013-06-11 18:33:36 UTC (rev 151446)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 18:48:08 UTC (rev 151447)
@@ -1,3 +1,18 @@
+2013-06-11  Jer Noble  
+
+Do not filter cookies requested through the CookieStorageShim.
+https://bugs.webkit.org/show_bug.cgi?id=117511
+
+
+Reviewed by Beth Dakin.
+
+Since the shim function is called when the underlying media engine is
+creating an HTTPRequest, use CookieRequestHeaderFieldValue (which does
+not filter out HTTP-only cookies) rather than CookiesForDOM (which does).
+
+* Shared/mac/CookieStorageShim.cpp:
+(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
+
 2013-06-11  Seokju Kwon  
 
 Remove leftover wxWebkit code


Modified: trunk/Source/WebKit2/Shared/mac/CookieStorageShim.cpp (151446 => 151447)

--- trunk/Source/WebKit2/Shared/mac/CookieStorageShim.cpp	2013-06-11 18:33:36 UTC (rev 151446)
+++ trunk/Source/WebKit2/Shared/mac/CookieStorageShim.cpp	2013-06-11 18:48:08 UTC (rev 151447)
@@ -47,7 +47,7 @@
 {
 String cookies;
 KURL firstPartyForCookiesURL;
-if (!WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::CookiesForDOM(false, firstPartyForCookiesURL, inRequestURL), Messages::NetworkConnectionToWebProcess::CookiesForDOM::Reply(cookies), 0))
+if (!WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::CookieRequestHeaderFieldValue(false, firstPartyForCookiesURL, inRequestURL), Messages::NetworkConnectionToWebProcess::CookiesForDOM::Reply(cookies), 0))
 return 0;
 
 RetainPtr cfCookies = cookies.createCFString();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151449] trunk/Source/WebCore

2013-06-11 Thread rniwa

Title: [151449] trunk/Source/WebCore








Revision 151449
Author rn...@webkit.org
Date 2013-06-11 11:48:59 -0700 (Tue, 11 Jun 2013)


Log Message
There are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds
https://bugs.webkit.org/show_bug.cgi?id=117475

Reviewed by Andreas Kling.

Removed.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151448 => 151449)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 18:48:44 UTC (rev 151448)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 18:48:59 UTC (rev 151449)
@@ -1,3 +1,17 @@
+2013-06-11  Ryosuke Niwa  
+
+There are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds
+https://bugs.webkit.org/show_bug.cgi?id=117475
+
+Reviewed by Andreas Kling.
+
+Removed.
+
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
+
 2013-06-11  Robert Hogan  
 
 Fix typo in r151445


Modified: trunk/Source/WebCore/editing/ApplyStyleCommand.cpp (151448 => 151449)

--- trunk/Source/WebCore/editing/ApplyStyleCommand.cpp	2013-06-11 18:48:44 UTC (rev 151448)
+++ trunk/Source/WebCore/editing/ApplyStyleCommand.cpp	2013-06-11 18:48:59 UTC (rev 151449)
@@ -1303,18 +1303,13 @@
 bool ApplyStyleCommand::mergeEndWithNextIfIdentical(const Position& start, const Position& end)
 {
 Node* endNode = end.containerNode();
-int endOffset = end.computeOffsetInContainerNode();
 
 if (isAtomicNode(endNode)) {
-if (offsetIsBeforeLastNodeOffset(endOffset, endNode))
+int endOffset = end.computeOffsetInContainerNode();
+if (offsetIsBeforeLastNodeOffset(endOffset, endNode) || end.deprecatedNode()->nextSibling())
 return false;
 
-unsigned parentLastOffset = end.deprecatedNode()->parentNode()->childNodeCount() - 1;
-if (end.deprecatedNode()->nextSibling())
-return false;
-
 endNode = end.deprecatedNode()->parentNode();
-endOffset = parentLastOffset;
 }
 
 if (!endNode->isElementNode() || endNode->hasTagName(brTag))


Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (151448 => 151449)

--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp	2013-06-11 18:48:44 UTC (rev 151448)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp	2013-06-11 18:48:59 UTC (rev 151449)
@@ -676,10 +676,9 @@
 removeNode(lastLeafInserted);
 }
 
-// We don't have to make sure that firstNodeInserted isn't inside a select or script element, because
-// it is a top level node in the fragment and the user can't insert into those elements.
+// We don't have to make sure that firstNodeInserted isn't inside a select or script element
+// because it is a top level node in the fragment and the user can't insert into those elements.
 Node* firstNodeInserted = insertedNodes.firstNodeInserted();
-lastLeafInserted = insertedNodes.lastLeafInserted();
 if (firstNodeInserted && firstNodeInserted->isTextNode() && !nodeHasVisibleRenderText(toText(firstNodeInserted))) {
 insertedNodes.willRemoveNode(firstNodeInserted);
 removeNode(firstNodeInserted);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151446] trunk/Source/WebCore

2013-06-11 Thread robert

Title: [151446] trunk/Source/WebCore








Revision 151446
Author rob...@webkit.org
Date 2013-06-11 11:33:36 -0700 (Tue, 11 Jun 2013)


Log Message
Fix typo in r151445

Unreviewed build fix.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151445 => 151446)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 18:22:28 UTC (rev 151445)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 18:33:36 UTC (rev 151446)
@@ -1,3 +1,12 @@
+2013-06-11  Robert Hogan  
+
+Fix typo in r151445
+
+Unreviewed build fix.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
+
 2013-06-11  Ryosuke Niwa  
 
 Remove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (151445 => 151446)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-06-11 18:22:28 UTC (rev 151445)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-06-11 18:33:36 UTC (rev 151446)
@@ -6195,8 +6195,8 @@
 // Add in text-indent.  This is added in only once.
 if (!addedTextIndent && !child->isFloating()) {
 LayoutUnit ceiledIndent = textIndent.ceilToFloat();
-childMin += cailedIndent;
-childMax += cailedIndent;
+childMin += ceiledIndent;
+childMax += ceiledIndent;
 
 if (childMin < 0)
 textIndent = adjustFloatForSubPixelLayout(childMin);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151445] trunk/Source/WebCore

2013-06-11 Thread rniwa

Title: [151445] trunk/Source/WebCore








Revision 151445
Author rn...@webkit.org
Date 2013-06-11 11:22:28 -0700 (Tue, 11 Jun 2013)


Log Message
Remove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=117490

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/be336b14325b2938ff6a4fb6191073a6e717a57c.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151444 => 151445)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 18:11:31 UTC (rev 151444)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 18:22:28 UTC (rev 151445)
@@ -1,3 +1,15 @@
+2013-06-11  Ryosuke Niwa  
+
+Remove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths
+https://bugs.webkit.org/show_bug.cgi?id=117490
+
+Reviewed by Andreas Kling.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/be336b14325b2938ff6a4fb6191073a6e717a57c.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
+
 2013-06-03  Robert Hogan  
 
 Painting collapsed borders during scrolling


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (151444 => 151445)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-06-11 18:11:31 UTC (rev 151444)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-06-11 18:22:28 UTC (rev 151445)
@@ -6193,11 +6193,10 @@
 }
 
 // Add in text-indent.  This is added in only once.
-LayoutUnit ti = 0;
 if (!addedTextIndent && !child->isFloating()) {
-ti = textIndent;
-childMin += ti.ceilToFloat();
-childMax += ti.ceilToFloat();
+LayoutUnit ceiledIndent = textIndent.ceilToFloat();
+childMin += cailedIndent;
+childMax += cailedIndent;
 
 if (childMin < 0)
 textIndent = adjustFloatForSubPixelLayout(childMin);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151444] trunk

2013-06-11 Thread robert

Title: [151444] trunk








Revision 151444
Author rob...@webkit.org
Date 2013-06-11 11:11:31 -0700 (Tue, 11 Jun 2013)


Log Message
Painting collapsed borders during scrolling
https://bugs.webkit.org/show_bug.cgi?id=85658

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/table-cell-collapsed-border-scroll.html

WHen painting collapsed borders we need to paint the borders of the row above
the topmost dirtied row so that we compute the correct value for the dirtied row's collapsed border.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):

LayoutTests:

* fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
* fast/repaint/table-cell-collapsed-border-scroll.html: Added.
* platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableSection.cpp


Added Paths

trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll.html
trunk/LayoutTests/platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
trunk/LayoutTests/platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (151443 => 151444)

--- trunk/LayoutTests/ChangeLog	2013-06-11 17:49:59 UTC (rev 151443)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 18:11:31 UTC (rev 151444)
@@ -1,3 +1,14 @@
+2013-06-03  Robert Hogan  
+
+Painting collapsed borders during scrolling
+https://bugs.webkit.org/show_bug.cgi?id=85658
+
+Reviewed by David Hyatt.
+
+* fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
+* fast/repaint/table-cell-collapsed-border-scroll.html: Added.
+* platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.
+
 2013-06-11  Ryosuke Niwa  
 
 editing/undo/undo-after-event-edited.html can be flaky


Added: trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll-expected.txt (0 => 151444)

--- trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	2013-06-11 18:11:31 UTC (rev 151444)
@@ -0,0 +1,16 @@
+layer at (0,0) size 1076x1796
+  RenderView at (0,0) size 785x585
+layer at (0,0) size 785x1796
+  RenderBlock {HTML} at (0,0) size 785x1796
+RenderBody {BODY} at (8,8) size 769x1780
+  RenderTable {TABLE} at (0,0) size 1068x1780 [color=#FF] [border: (178px none #808080)]
+RenderTableSection {TBODY} at (178,178) size 712x1424
+  RenderTableRow {TR} at (0,0) size 712x712
+RenderTableCell {TD} at (0,0) size 712x712 [border: (178px solid #FF)] [r=0 c=0 rs=1 cs=1]
+  RenderText {#text} at (178,177) size 356x357
+text run at (178,177) width 356: "B"
+  RenderTableRow {TR} at (0,712) size 712x712
+RenderTableCell {TD} at (0,712) size 712x712 [border: (178px solid #FF) (178px solid #00)] [r=1 c=0 rs=1 cs=1]
+  RenderText {#text} at (178,177) size 356x357
+text run at (178,177) width 356: "Y"
+scrolled to 0,1000
Property changes on: trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll.html (0 => 151444)

--- trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll.html	(rev 0)
+++ trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll.html	2013-06-11 18:11:31 UTC (rev 151444)
@@ -0,0 +1,45 @@
+
+
+ 
+  
+  table
+  {
+  border-collapse: collapse;
+  color: white;
+  font: 22.25em/1 Ahem;
+  }
+
+  td {padding: 0px;}
+
+  table#test td
+  {
+  border-style: solid;
+  border-width: 1em;
+  }
+
+  td#one {border-color: blue blue blue blue;}
+  td#two {border-color: yellow yellow yellow red;}
+
+  td#five {border-color: red yellow yellow yellow;}
+  td#six {border-color: red green green red;}
+  
+
+
+function repaintTest()
+{
+window.scrollTo(0,1000);
+}
+
+
+
+  
+  
+   
+B
+   
+   
+ Y 
+   
+  
+ 
+
Property changes on: trunk/LayoutTests/fast/repaint/table-cell-collapsed-border-scroll.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt (0 => 151444)

--- trunk/LayoutTests/platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt	2013-06-11 18:11:31 UTC (re

[webkit-changes] [151443] branches/dfgFourthTier/Source/JavaScriptCore

2013-06-11 Thread fpizlo

Title: [151443] branches/dfgFourthTier/Source/_javascript_Core








Revision 151443
Author fpi...@apple.com
Date 2013-06-11 10:49:59 -0700 (Tue, 11 Jun 2013)


Log Message
fourthTier: Type check hoisting phase has a dead if statement
https://bugs.webkit.org/show_bug.cgi?id=117510

Reviewed by Geoffrey Garen.

* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

Modified Paths

branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp




Diff

Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (151442 => 151443)

--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-11 17:08:55 UTC (rev 151442)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-11 17:49:59 UTC (rev 151443)
@@ -1,3 +1,13 @@
+2013-06-11  Filip Pizlo  
+
+fourthTier: Type check hoisting phase has a dead if statement
+https://bugs.webkit.org/show_bug.cgi?id=117510
+
+Reviewed by Geoffrey Garen.
+
+* dfg/DFGTypeCheckHoistingPhase.cpp:
+(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
+
 2013-06-10  Mark Lam  
 
 Introducing the StackIterator class.


Modified: branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp (151442 => 151443)

--- branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp	2013-06-11 17:08:55 UTC (rev 151442)
+++ branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp	2013-06-11 17:49:59 UTC (rev 151443)
@@ -407,7 +407,7 @@
 break;
 }
 case CheckArray: {
-if (subNode->child1() != source);
+if (subNode->child1() != source)
 break;
 noticeCheckArray(variable, subNode->arrayMode());
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151442] releases/WebKitGTK/webkit-2.0.3/

2013-06-11 Thread carlosgc

Title: [151442] releases/WebKitGTK/webkit-2.0.3/








Revision 151442
Author carlo...@webkit.org
Date 2013-06-11 10:08:55 -0700 (Tue, 11 Jun 2013)


Log Message
Tagging the WebKitGTK+ 2.0.3 release

Added Paths

releases/WebKitGTK/webkit-2.0.3/




Diff

Property changes: releases/WebKitGTK/webkit-2.0.3



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151441] trunk/Source/WebCore

2013-06-11 Thread ossy

Title: [151441] trunk/Source/WebCore








Revision 151441
Author o...@webkit.org
Date 2013-06-11 09:37:14 -0700 (Tue, 11 Jun 2013)


Log Message
[curl] Custom HTTP method support
https://bugs.webkit.org/show_bug.cgi?id=117302

Patch by Peter Gal  on 2013-06-11
Reviewed by Kenneth Rohde Christiansen.

No new tests, already covered by existing ones like:
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/methods-async.html

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151440 => 151441)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 15:32:18 UTC (rev 151440)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 16:37:14 UTC (rev 151441)
@@ -1,3 +1,17 @@
+2013-06-11  Peter Gal  
+
+[curl] Custom HTTP method support
+https://bugs.webkit.org/show_bug.cgi?id=117302
+
+Reviewed by Kenneth Rohde Christiansen.
+
+No new tests, already covered by existing ones like:
+http/tests/xmlhttprequest/workers/methods.html
+http/tests/xmlhttprequest/workers/methods-async.html
+
+* platform/network/curl/ResourceHandleManager.cpp:
+(WebCore::ResourceHandleManager::initializeHandle):
+
 2013-06-11  Seokju Kwon  
 
 Web Inspector: Remove 'using namespace std'


Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp (151440 => 151441)

--- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2013-06-11 15:32:18 UTC (rev 151440)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2013-06-11 16:37:14 UTC (rev 151441)
@@ -773,14 +773,19 @@
 }
 }
 
-if ("GET" == job->firstRequest().httpMethod())
+String method = job->firstRequest().httpMethod();
+if ("GET" == method)
 curl_easy_setopt(d->m_handle, CURLOPT_HTTPGET, TRUE);
-else if ("POST" == job->firstRequest().httpMethod())
+else if ("POST" == method)
 setupPOST(job, &headers);
-else if ("PUT" == job->firstRequest().httpMethod())
+else if ("PUT" == method)
 setupPUT(job, &headers);
-else if ("HEAD" == job->firstRequest().httpMethod())
+else if ("HEAD" == method)
 curl_easy_setopt(d->m_handle, CURLOPT_NOBODY, TRUE);
+else {
+curl_easy_setopt(d->m_handle, CURLOPT_CUSTOMREQUEST, method.latin1().data());
+setupPUT(job, &headers);
+}
 
 if (headers) {
 curl_easy_setopt(d->m_handle, CURLOPT_HTTPHEADER, headers);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151440] trunk/Source/WebKit/win

2013-06-11 Thread bfulgham

Title: [151440] trunk/Source/WebKit/win








Revision 151440
Author bfulg...@apple.com
Date 2013-06-11 08:32:18 -0700 (Tue, 11 Jun 2013)


Log Message
[Windows] Provide MSAA mappings for more WebCore roles.
https://bugs.webkit.org/show_bug.cgi?id=117389

Reviewed by Chris Fleizach.

* AccessibleBase.cpp:
(MSAARole): Add additional mappings between WebCore roles and MSAA roles.

Modified Paths

trunk/Source/WebKit/win/AccessibleBase.cpp
trunk/Source/WebKit/win/ChangeLog




Diff

Modified: trunk/Source/WebKit/win/AccessibleBase.cpp (151439 => 151440)

--- trunk/Source/WebKit/win/AccessibleBase.cpp	2013-06-11 15:14:59 UTC (rev 151439)
+++ trunk/Source/WebKit/win/AccessibleBase.cpp	2013-06-11 15:32:18 UTC (rev 151440)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008, 2009, 2010 Apple Inc. All Rights Reserved.
+ * Copyright (C) 2008, 2009, 2010, 2013 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -635,11 +635,13 @@
 case WebCore::SliderRole:
 return ROLE_SYSTEM_SLIDER;
 case WebCore::TabGroupRole:
+case WebCore::TabListRole:
 return ROLE_SYSTEM_PAGETABLIST;
 case WebCore::TextFieldRole:
 case WebCore::TextAreaRole:
 case WebCore::EditableTextRole:
 return ROLE_SYSTEM_TEXT;
+case WebCore::HeadingRole:
 case WebCore::ListMarkerRole:
 case WebCore::StaticTextRole:
 return ROLE_SYSTEM_STATICTEXT;
@@ -650,13 +652,18 @@
 case WebCore::RowRole:
 return ROLE_SYSTEM_ROW;
 case WebCore::GroupRole:
+case WebCore::RadioGroupRole:
 return ROLE_SYSTEM_GROUPING;
+case WebCore::DescriptionListRole:
+case WebCore::DirectoryRole:
 case WebCore::ListRole:
 case WebCore::ListBoxRole:
 case WebCore::MenuListPopupRole:
 return ROLE_SYSTEM_LIST;
+case WebCore::GridRole:
 case WebCore::TableRole:
 return ROLE_SYSTEM_TABLE;
+case WebCore::ImageMapLinkRole:
 case WebCore::LinkRole:
 case WebCore::WebCoreLinkRole:
 return ROLE_SYSTEM_LINK;
@@ -664,23 +671,34 @@
 case WebCore::ImageMapRole:
 case WebCore::ImageRole:
 return ROLE_SYSTEM_GRAPHIC;
-case WebCore::MenuListOptionRole:
+// Note: ListItemRole seems like it should map to ROLE_SYSTEM_LISTITEM, but Mac OS maps
+// this to the equivalent of ROLE_SYSTEM_GROUPING. To provide consistent behavior on both
+// platforms we will follow that mapping:
 case WebCore::ListItemRole:
+return ROLE_SYSTEM_GROUPING;
 case WebCore::ListBoxOptionRole:
-return ROLE_SYSTEM_LISTITEM;
+case WebCore::MenuListOptionRole:
+return ROLE_SYSTEM_STATICTEXT;
+case WebCore::ComboBoxRole:
 case WebCore::PopUpButtonRole:
 return ROLE_SYSTEM_COMBOBOX;
 case WebCore::DivRole:
+case WebCore::FooterRole:
 case WebCore::FormRole:
 case WebCore::LabelRole:
 case WebCore::ParagraphRole:
 return ROLE_SYSTEM_GROUPING;
 case WebCore::HorizontalRuleRole:
+case WebCore::SplitterRole:
 return ROLE_SYSTEM_SEPARATOR;
 case WebCore::ApplicationAlertRole:
+case WebCore::ApplicationAlertDialogRole:
 return ROLE_SYSTEM_ALERT;
-case WebCore::ComboBoxRole:
-return ROLE_SYSTEM_COMBOBOX;
+case WebCore::DisclosureTriangleRole:
+return ROLE_SYSTEM_BUTTONDROPDOWN;
+case WebCore::SeamlessWebAreaRole:
+return ROLE_SYSTEM_GROUPING;
+case WebCore::IncrementorRole:
 case WebCore::SpinButtonRole:
 return ROLE_SYSTEM_SPINBUTTON;
 case WebCore::SpinButtonPartRole:
@@ -696,10 +714,69 @@
 return ROLE_SYSTEM_OUTLINE;
 case WebCore::TreeItemRole:
 return ROLE_SYSTEM_OUTLINEITEM;
-case WebCore::TabListRole:
-return ROLE_SYSTEM_PAGETABLIST;
 case WebCore::TabPanelRole:
-return ROLE_SYSTEM_PROPERTYPAGE;
+return ROLE_SYSTEM_GROUPING;
+// Note: TabRole seems like it should map to ROLE_SYSTEM_PAGETAB, but Mac OS maps
+// this to the equivalent of ROLE_SYSTEM_RADIOBUTTON. To provide consistent behavior
+// on both platforms we will follow that mapping:
+case WebCore::TabRole:
+return ROLE_SYSTEM_RADIOBUTTON;
+case WebCore::ApplicationRole:
+return ROLE_SYSTEM_APPLICATION;
+case WebCore::ApplicationDialogRole:
+return ROLE_SYSTEM_DIALOG;
+case WebCore::ApplicationLogRole:
+case WebCore::ApplicationMarqueeRole:
+return ROLE_SYSTEM_GROUPING;
+case WebCore::ApplicationStatusRole:
+return ROLE_SYSTEM

[webkit-changes] [151439] trunk

2013-06-11 Thread commit-queue

Title: [151439] trunk








Revision 151439
Author commit-qu...@webkit.org
Date 2013-06-11 08:14:59 -0700 (Tue, 11 Jun 2013)


Log Message
Remove leftover wxWebkit code
https://bugs.webkit.org/show_bug.cgi?id=117471

Patch by Seokju Kwon  on 2013-06-11
Reviewed by Andreas Kling.

.:

* Source/cmake/WebKitPackaging.cmake:

Source/WebKit2:

* Scripts/generate-forwarding-headers.pl:

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl
trunk/Source/cmake/WebKitPackaging.cmake




Diff

Modified: trunk/ChangeLog (151438 => 151439)

--- trunk/ChangeLog	2013-06-11 15:09:18 UTC (rev 151438)
+++ trunk/ChangeLog	2013-06-11 15:14:59 UTC (rev 151439)
@@ -1,3 +1,12 @@
+2013-06-11  Seokju Kwon  
+
+Remove leftover wxWebkit code
+https://bugs.webkit.org/show_bug.cgi?id=117471
+
+Reviewed by Andreas Kling.
+
+* Source/cmake/WebKitPackaging.cmake:
+
 2013-06-07  Zan Dobersek  
 
 [regression] build failure WebKitFontFamilyNames.h missing


Modified: trunk/Source/WebKit2/ChangeLog (151438 => 151439)

--- trunk/Source/WebKit2/ChangeLog	2013-06-11 15:09:18 UTC (rev 151438)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 15:14:59 UTC (rev 151439)
@@ -1,3 +1,12 @@
+2013-06-11  Seokju Kwon  
+
+Remove leftover wxWebkit code
+https://bugs.webkit.org/show_bug.cgi?id=117471
+
+Reviewed by Andreas Kling.
+
+* Scripts/generate-forwarding-headers.pl:
+
 2013-06-11  Changhyup Jwa  
 
 [EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.


Modified: trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl (151438 => 151439)

--- trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2013-06-11 15:09:18 UTC (rev 151438)
+++ trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2013-06-11 15:14:59 UTC (rev 151439)
@@ -35,7 +35,7 @@
 
 my $srcRoot = realpath(File::Spec->catfile(dirname(abs_path($0)), "../.."));
 my $incFromRoot = abs_path($ARGV[0]);
-my @platformPrefixes = ("blackberry", "cf", "CoordinatedGraphics", "curl", "efl", "gtk", "mac", "qt", "soup", "win", "wx");
+my @platformPrefixes = ("blackberry", "cf", "CoordinatedGraphics", "curl", "efl", "gtk", "mac", "qt", "soup", "win");
 my @frameworks = ("_javascript_Core", "WebCore", "WebKit2");
 my @skippedPrefixes;
 my @frameworkHeaders;


Modified: trunk/Source/cmake/WebKitPackaging.cmake (151438 => 151439)

--- trunk/Source/cmake/WebKitPackaging.cmake	2013-06-11 15:09:18 UTC (rev 151438)
+++ trunk/Source/cmake/WebKitPackaging.cmake	2013-06-11 15:14:59 UTC (rev 151439)
@@ -129,7 +129,6 @@
 "/qt4/" "/Qt4/" "qt4." "Qt4."
 "/win/" "/Win/" "win." "Win."
 "/wince/" "/Wince/" "wince." "Wince."
-"/wx/" "/Wx/" "wx." "Wx."
 "/wxcode/" "/Wxcode/" "wxcode." "Wxcode."
 "/WebKitLibraries/"
 "/English.lproj/"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151438] trunk/LayoutTests

2013-06-11 Thread rniwa

Title: [151438] trunk/LayoutTests








Revision 151438
Author rn...@webkit.org
Date 2013-06-11 08:09:18 -0700 (Tue, 11 Jun 2013)


Log Message
editing/undo/undo-after-event-edited.html can be flaky
https://bugs.webkit.org/show_bug.cgi?id=117461

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/515de860730b34289df5805b40adb2535a9a8ba1

* editing/undo/undo-after-event-edited.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/undo/undo-after-event-edited.html




Diff

Modified: trunk/LayoutTests/ChangeLog (151437 => 151438)

--- trunk/LayoutTests/ChangeLog	2013-06-11 15:06:16 UTC (rev 151437)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 15:09:18 UTC (rev 151438)
@@ -1,3 +1,14 @@
+2013-06-11  Ryosuke Niwa  
+
+editing/undo/undo-after-event-edited.html can be flaky
+https://bugs.webkit.org/show_bug.cgi?id=117461
+
+Reviewed by Andreas Kling.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/515de860730b34289df5805b40adb2535a9a8ba1
+
+* editing/undo/undo-after-event-edited.html:
+
 2013-06-11  Gabor Abraham  
 
 [Qt] Unreviewed gardening. Unskipping passing tests. Generate new baseline where needed.


Modified: trunk/LayoutTests/editing/undo/undo-after-event-edited.html (151437 => 151438)

--- trunk/LayoutTests/editing/undo/undo-after-event-edited.html	2013-06-11 15:06:16 UTC (rev 151437)
+++ trunk/LayoutTests/editing/undo/undo-after-event-edited.html	2013-06-11 15:09:18 UTC (rev 151438)
@@ -33,11 +33,11 @@
 document.execCommand('InsertParagraph',false,false);
 }, false);
 
-setTimeout(function() {
+window.addEventListener("load", function() {
   document.execCommand("SelectAll", false)
   var documentFragment = getSelection().getRangeAt(0).extractContents();
   document.execCommand('Undo', false);
-}, 1);
+});
 
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151437] trunk/Source/WebCore

2013-06-11 Thread commit-queue

Title: [151437] trunk/Source/WebCore








Revision 151437
Author commit-qu...@webkit.org
Date 2013-06-11 08:06:16 -0700 (Tue, 11 Jun 2013)


Log Message
Web Inspector: Remove 'using namespace std'
https://bugs.webkit.org/show_bug.cgi?id=117498

Patch by Seokju Kwon  on 2013-06-11
Reviewed by Anders Carlsson.

No new tests, no behavior change.

* inspector/InspectorAgent.cpp: Remove unneeded 'using namespace std'.
* inspector/InspectorFrontendClientLocal.cpp: Use explicit std:: qualifiers instead.
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):
* inspector/InspectorFrontendHost.cpp: Remove unneeded 'using namespace std'.
* inspector/InspectorPageAgent.cpp: Remove unneeded 'using namespace std'.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorAgent.cpp
trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151436 => 151437)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 14:42:57 UTC (rev 151436)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 15:06:16 UTC (rev 151437)
@@ -1,3 +1,19 @@
+2013-06-11  Seokju Kwon  
+
+Web Inspector: Remove 'using namespace std'
+https://bugs.webkit.org/show_bug.cgi?id=117498
+
+Reviewed by Anders Carlsson.
+
+No new tests, no behavior change.
+
+* inspector/InspectorAgent.cpp: Remove unneeded 'using namespace std'.
+* inspector/InspectorFrontendClientLocal.cpp: Use explicit std:: qualifiers instead.
+(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
+(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):
+* inspector/InspectorFrontendHost.cpp: Remove unneeded 'using namespace std'.
+* inspector/InspectorPageAgent.cpp: Remove unneeded 'using namespace std'.
+
 2013-06-11  Christophe Dumez  
 
 Support latest Web IDL named property getters


Modified: trunk/Source/WebCore/inspector/InspectorAgent.cpp (151436 => 151437)

--- trunk/Source/WebCore/inspector/InspectorAgent.cpp	2013-06-11 14:42:57 UTC (rev 151436)
+++ trunk/Source/WebCore/inspector/InspectorAgent.cpp	2013-06-11 15:06:16 UTC (rev 151437)
@@ -56,8 +56,6 @@
 #include 
 #include 
 
-using namespace std;
-
 namespace WebCore {
 
 namespace InspectorAgentState {


Modified: trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp (151436 => 151437)

--- trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp	2013-06-11 14:42:57 UTC (rev 151436)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp	2013-06-11 15:06:16 UTC (rev 151437)
@@ -324,14 +324,12 @@
 
 unsigned InspectorFrontendClientLocal::constrainedAttachedWindowHeight(unsigned preferredHeight, unsigned totalWindowHeight)
 {
-using namespace std;
-return roundf(max(minimumAttachedHeight, min(preferredHeight, totalWindowHeight * maximumAttachedHeightRatio)));
+return roundf(std::max(minimumAttachedHeight, std::min(preferredHeight, totalWindowHeight * maximumAttachedHeightRatio)));
 }
 
 unsigned InspectorFrontendClientLocal::constrainedAttachedWindowWidth(unsigned preferredWidth, unsigned totalWindowWidth)
 {
-using namespace std;
-return roundf(max(minimumAttachedWidth, min(preferredWidth, totalWindowWidth - minimumAttachedInspectedWidth)));
+return roundf(std::max(minimumAttachedWidth, std::min(preferredWidth, totalWindowWidth - minimumAttachedInspectedWidth)));
 }
 
 void InspectorFrontendClientLocal::sendMessageToBackend(const String& message)


Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (151436 => 151437)

--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2013-06-11 14:42:57 UTC (rev 151436)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2013-06-11 15:06:16 UTC (rev 151437)
@@ -56,8 +56,6 @@
 #include "UserGestureIndicator.h"
 #include 
 
-using namespace std;
-
 namespace WebCore {
 
 #if ENABLE(CONTEXT_MENUS)


Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (151436 => 151437)

--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2013-06-11 14:42:57 UTC (rev 151436)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2013-06-11 15:06:16 UTC (rev 151437)
@@ -83,8 +83,6 @@
 #include 
 #include 
 
-using namespace std;
-
 namespace WebCore {
 
 namespace PageAgentState {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151435] releases/WebKitGTK/webkit-2.0

2013-06-11 Thread carlosgc

Title: [151435] releases/WebKitGTK/webkit-2.0








Revision 151435
Author carlo...@webkit.org
Date 2013-06-11 06:45:56 -0700 (Tue, 11 Jun 2013)


Log Message
Unreviewed. Update NEWS and Versions.m4 for 2.0.3 release.

.:

* Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 2.0.3.

Modified Paths

releases/WebKitGTK/webkit-2.0/ChangeLog
releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4




Diff

Modified: releases/WebKitGTK/webkit-2.0/ChangeLog (151434 => 151435)

--- releases/WebKitGTK/webkit-2.0/ChangeLog	2013-06-11 13:04:10 UTC (rev 151434)
+++ releases/WebKitGTK/webkit-2.0/ChangeLog	2013-06-11 13:45:56 UTC (rev 151435)
@@ -1,5 +1,11 @@
 2013-06-11  Carlos Garcia Campos  
 
+Unreviewed. Update NEWS and Versions.m4 for 2.0.3 release.
+
+* Source/autotools/Versions.m4: Bump version numbers.
+
+2013-06-11  Carlos Garcia Campos  
+
 Unreviewed. Rename gobject_introspection_required variable.
 
 As gobject_introspection_required_version for consistency with all


Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog (151434 => 151435)

--- releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog	2013-06-11 13:04:10 UTC (rev 151434)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog	2013-06-11 13:45:56 UTC (rev 151435)
@@ -1,3 +1,9 @@
+2013-06-11  Carlos Garcia Campos  
+
+Unreviewed. Update NEWS and Versions.m4 for 2.0.3 release.
+
+* NEWS: Added release notes for 2.0.3.
+
 2013-05-16  Allan Sandfeld Jensen  
 
 [GTK] TargetFrame and innerNodeFrame confused


Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/NEWS (151434 => 151435)

--- releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/NEWS	2013-06-11 13:04:10 UTC (rev 151434)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/NEWS	2013-06-11 13:45:56 UTC (rev 151435)
@@ -1,4 +1,27 @@
 ==
+WebKitGTK+   2.0.3
+==
+
+What's new in WebKitGTK+ 2.0.3?
+
+  - Fix rendering of WebKitWebView child widgets with recent GTK+.
+  - Use the inner node frame instead of the target frame to calculate
+the point of a hit test result in WebKit1.
+  - Fix a crash when terminating a process that has not been fully
+launched.
+  - Fix race conditions closing the socket descriptor when the web
+process crashes.
+  - Fix a crash when a web page is closed.
+  - Fix a crash when child iframe is removed during beforeload.
+  - Fix parallel build when gtk-doc is enabled.
+  - Fix build with MinGW compiler because of invalid cast.
+  - Fix the build with WebAudio enabled.
+  - Respect PKG_CONFIG env variable when generating gtk-doc.
+  - Fix memory leak in WebKitBackForwardList.
+  - Fix memory leak when web process is terminated.
+  - Translation updates: Hindi, Telugu, Odia, Kannada, as-IN.
+
+==
 WebKitGTK+   2.0.2
 ==
 


Modified: releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4 (151434 => 151435)

--- releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4	2013-06-11 13:04:10 UTC (rev 151434)
+++ releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4	2013-06-11 13:45:56 UTC (rev 151435)
@@ -1,6 +1,6 @@
 m4_define([webkit_major_version], [2])
 m4_define([webkit_minor_version], [0])
-m4_define([webkit_micro_version], [2])
+m4_define([webkit_micro_version], [3])
 
 # This is the version we'll be using as part of our User-Agent string,
 # e.g., AppleWebKit/$(webkit_user_agent_version) ...
@@ -11,9 +11,9 @@
 
 # Libtool library version, not to confuse with API version.
 # See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-m4_define([libwebkitgtk_version], [18:7:18])
-m4_define([libjavascriptcoregtk_version], [13:14:13])
-m4_define([libwebkit2gtk_version], [25:2:0])
+m4_define([libwebkitgtk_version], [18:8:18])
+m4_define([libjavascriptcoregtk_version], [13:15:13])
+m4_define([libwebkit2gtk_version], [25:3:0])
 
 m4_define([gtk2_required_version], [2.24.10])
 m4_define([gail2_required_version], [1.8])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151434] trunk/Source/WebCore

2013-06-11 Thread ch . dumez

Title: [151434] trunk/Source/WebCore








Revision 151434
Author ch.du...@sisa.samsung.com
Date 2013-06-11 06:04:10 -0700 (Tue, 11 Jun 2013)


Log Message
Support latest Web IDL named property getters
https://bugs.webkit.org/show_bug.cgi?id=117403

Reviewed by Kentaro Hara.

Add support for the latest Web IDL named property getters to the JSC
bindings generator:
http://www.w3.org/TR/WebIDL/#idl-named-properties

Drop support for outdated [NamedGetter] IDL extended attribute.

Support for other kinds of named properties will be added in later
patches. This patch only brings named property getters.

This patch is based on Blink r149247 by ko...@chromium.org.

No new tests, no behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetSpecialAccessorFunctionForType):
(GetNamedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/IDLParser.pm:
(applyTypedefs):
(parseSpecialOperation):
(parseSpecials):
(applyMemberList):
* bindings/scripts/test/TestEventTarget.idl:
* css/StyleSheetList.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLPropertiesCollection.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/Storage.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/test/TestEventTarget.idl
trunk/Source/WebCore/css/StyleSheetList.idl
trunk/Source/WebCore/dom/DOMNamedFlowCollection.idl
trunk/Source/WebCore/dom/DOMStringMap.idl
trunk/Source/WebCore/dom/NamedNodeMap.idl
trunk/Source/WebCore/dom/NodeList.idl
trunk/Source/WebCore/html/HTMLAllCollection.idl
trunk/Source/WebCore/html/HTMLCollection.idl
trunk/Source/WebCore/html/HTMLFormControlsCollection.idl
trunk/Source/WebCore/html/HTMLPropertiesCollection.idl
trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl
trunk/Source/WebCore/plugins/DOMPlugin.idl
trunk/Source/WebCore/plugins/DOMPluginArray.idl
trunk/Source/WebCore/storage/Storage.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (151433 => 151434)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 12:12:31 UTC (rev 151433)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 13:04:10 UTC (rev 151434)
@@ -1,3 +1,51 @@
+2013-06-11  Christophe Dumez  
+
+Support latest Web IDL named property getters
+https://bugs.webkit.org/show_bug.cgi?id=117403
+
+Reviewed by Kentaro Hara.
+
+Add support for the latest Web IDL named property getters to the JSC
+bindings generator:
+http://www.w3.org/TR/WebIDL/#idl-named-properties
+
+Drop support for outdated [NamedGetter] IDL extended attribute.
+
+Support for other kinds of named properties will be added in later
+patches. This patch only brings named property getters.
+
+This patch is based on Blink r149247 by ko...@chromium.org.
+
+No new tests, no behavior change.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateGetOwnPropertySlotBody):
+(GenerateGetOwnPropertyDescriptorBody):
+(GetSpecialAccessorFunctionForType):
+(GetNamedGetterFunction):
+(GenerateHeader):
+(GenerateImplementation):
+* bindings/scripts/IDLAttributes.txt:
+* bindings/scripts/IDLParser.pm:
+(applyTypedefs):
+(parseSpecialOperation):
+(parseSpecials):
+(applyMemberList):
+* bindings/scripts/test/TestEventTarget.idl:
+* css/StyleSheetList.idl:
+* dom/DOMNamedFlowCollection.idl:
+* dom/DOMStringMap.idl:
+* dom/NamedNodeMap.idl:
+* dom/NodeList.idl:
+* html/HTMLAllCollection.idl:
+* html/HTMLCollection.idl:
+* html/HTMLFormControlsCollection.idl:
+* html/HTMLPropertiesCollection.idl:
+* plugins/DOMMimeTypeArray.idl:
+* plugins/DOMPlugin.idl:
+* plugins/DOMPluginArray.idl:
+* storage/Storage.idl:
+
 2013-06-11  Carlos Garcia Campos  
 
 [BlackBerry] Test editing/execCommand/indent-paragraphs.html times out


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (151433 => 151434)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-06-11 12:12:31 UTC (rev 151433)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-06-11 13:04:10 UTC (rev 151434)
@@ -352,6 +352,7 @@
 my ($interface, $interfaceName, $className, $hasAttributes, $inlined) = @_;
 
 my $namespaceMaybe = ($inlined ? "JSC::" : "");
+my $namedGetterFunction = GetNamedGetterFunction($interface);
 
 my @getOwnPropertySlotImpl = ();
 
@@ -362,7 +363

[webkit-changes] [151433] trunk/Source/WebKit2

2013-06-11 Thread commit-queue

Title: [151433] trunk/Source/WebKit2








Revision 151433
Author commit-qu...@webkit.org
Date 2013-06-11 05:12:31 -0700 (Tue, 11 Jun 2013)


Log Message
[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=117504

Patch by Changhyup Jwa  on 2013-06-11
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 unit test if opengl is not available.
So, add fallback to non-opengl evas engine.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (151432 => 151433)

--- trunk/Source/WebKit2/ChangeLog	2013-06-11 10:47:43 UTC (rev 151432)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 12:12:31 UTC (rev 151433)
@@ -1,3 +1,16 @@
+2013-06-11  Changhyup Jwa  
+
+[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
+https://bugs.webkit.org/show_bug.cgi?id=117504
+
+Reviewed by Christophe Dumez.
+
+There're many fails on efl webkit2 unit test if opengl is not available.
+So, add fallback to non-opengl evas engine.
+
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+(EWK2UnitTest::EWK2UnitTestBase::SetUp):
+
 2013-06-11  Csaba Osztrogonác  
 
 Make WTR use its own temporary directory for application cache


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp (151432 => 151433)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2013-06-11 10:47:43 UTC (rev 151432)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2013-06-11 12:12:31 UTC (rev 151433)
@@ -50,9 +50,10 @@
 #if defined(WTF_USE_ACCELERATED_COMPOSITING) && defined(HAVE_ECORE_X)
 const char* engine = "opengl_x11";
 m_ecoreEvas = ecore_evas_new(engine, 0, 0, width, height, 0);
-#else
+// Graceful fallback to software rendering if evas_gl engine is not available.
+if (!m_ecoreEvas)
+#endif
 m_ecoreEvas = ecore_evas_new(0, 0, 0, width, height, 0);
-#endif
 
 ecore_evas_show(m_ecoreEvas);
 Evas* evas = ecore_evas_get(m_ecoreEvas);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151432] releases/WebKitGTK/webkit-2.0

2013-06-11 Thread carlosgc

Title: [151432] releases/WebKitGTK/webkit-2.0








Revision 151432
Author carlo...@webkit.org
Date 2013-06-11 03:47:43 -0700 (Tue, 11 Jun 2013)


Log Message
Unreviewed. Rename gobject_introspection_required variable.

As gobject_introspection_required_version for consistency with all
other required_version variables.

* Source/autotools/FindDependencies.m4:
* Source/autotools/Versions.m4:

Modified Paths

releases/WebKitGTK/webkit-2.0/ChangeLog
releases/WebKitGTK/webkit-2.0/Source/autotools/FindDependencies.m4
releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4




Diff

Modified: releases/WebKitGTK/webkit-2.0/ChangeLog (151431 => 151432)

--- releases/WebKitGTK/webkit-2.0/ChangeLog	2013-06-11 09:31:24 UTC (rev 151431)
+++ releases/WebKitGTK/webkit-2.0/ChangeLog	2013-06-11 10:47:43 UTC (rev 151432)
@@ -1,3 +1,13 @@
+2013-06-11  Carlos Garcia Campos  
+
+Unreviewed. Rename gobject_introspection_required variable.
+
+As gobject_introspection_required_version for consistency with all
+other required_version variables.
+
+* Source/autotools/FindDependencies.m4:
+* Source/autotools/Versions.m4:
+
 2013-05-30  Alberto Garcia  
 
 [GTK] Needs to check for harfbuzz-icu


Modified: releases/WebKitGTK/webkit-2.0/Source/autotools/FindDependencies.m4 (151431 => 151432)

--- releases/WebKitGTK/webkit-2.0/Source/autotools/FindDependencies.m4	2013-06-11 09:31:24 UTC (rev 151431)
+++ releases/WebKitGTK/webkit-2.0/Source/autotools/FindDependencies.m4	2013-06-11 10:47:43 UTC (rev 151432)
@@ -344,7 +344,7 @@
 GIRTYPELIBDIR=
 
 if test "$enable_introspection" = "yes"; then
-PKG_CHECK_MODULES([INTROSPECTION],[gobject-introspection-1.0 >= gobject_introspection_required])
+PKG_CHECK_MODULES([INTROSPECTION],[gobject-introspection-1.0 >= gobject_introspection_required_version])
 
 G_IR_SCANNER="$($PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0)"
 G_IR_COMPILER="$($PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0)"


Modified: releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4 (151431 => 151432)

--- releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4	2013-06-11 09:31:24 UTC (rev 151431)
+++ releases/WebKitGTK/webkit-2.0/Source/autotools/Versions.m4	2013-06-11 10:47:43 UTC (rev 151432)
@@ -26,7 +26,7 @@
 m4_define([fontconfig_required_version], [2.5])
 m4_define([freetype2_required_version], [9.0])
 m4_define([glib_required_version], [2.36.0])
-m4_define([gobject_introspection_required], [1.32.0])
+m4_define([gobject_introspection_required_version], [1.32.0])
 m4_define([gstreamer_plugins_base_required_version], [1.0.3])
 m4_define([gstreamer_required_version], [1.0.3])
 m4_define([harfbuzz_required_version], [0.9.7])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151431] releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

2013-06-11 Thread carlosgc

Title: [151431] releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk








Revision 151431
Author carlo...@webkit.org
Date 2013-06-11 02:31:24 -0700 (Tue, 11 Jun 2013)


Log Message
Merge r150182 - [GTK] TargetFrame and innerNodeFrame confused
https://bugs.webkit.org/show_bug.cgi?id=102907

Reviewed by Martin Robinson.

* webkit/webkithittestresult.cpp:
(WebKit::kit):

Modified Paths

releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/webkit/webkithittestresult.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog (151430 => 151431)

--- releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog	2013-06-11 08:48:10 UTC (rev 151430)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/ChangeLog	2013-06-11 09:31:24 UTC (rev 151431)
@@ -1,3 +1,13 @@
+2013-05-16  Allan Sandfeld Jensen  
+
+[GTK] TargetFrame and innerNodeFrame confused
+https://bugs.webkit.org/show_bug.cgi?id=102907
+
+Reviewed by Martin Robinson.
+
+* webkit/webkithittestresult.cpp:
+(WebKit::kit):
+
 2013-06-05  Alberto Garcia  
 
 [GTK] AcceleratedCompositingContext: fix layerFlushTimerFiredCallback condition


Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/webkit/webkithittestresult.cpp (151430 => 151431)

--- releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/webkit/webkithittestresult.cpp	2013-06-11 08:48:10 UTC (rev 151430)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk/webkit/webkithittestresult.cpp	2013-06-11 09:31:24 UTC (rev 151431)
@@ -287,7 +287,7 @@
 GOwnPtr imageURI(0);
 GOwnPtr mediaURI(0);
 WebKitDOMNode* node = 0;
-WebCore::Frame* targetFrame;
+WebCore::Frame* innerNodeFrame;
 WebCore::IntPoint point;
 
 if (!result.absoluteLinkURL().isEmpty()) {
@@ -314,14 +314,14 @@
 if (result.innerNonSharedNode())
 node = kit(result.innerNonSharedNode());
 
-// FIXME: This should probably use innerNodeFrame, as targetFrame is the potentially different frame the link opens in.
-targetFrame = result.targetFrame();
-if (targetFrame && targetFrame->view()) {
+innerNodeFrame = result.innerNodeFrame();
+if (innerNodeFrame && innerNodeFrame->view()) {
 // Convert document coords to widget coords.
-point = targetFrame->view()->contentsToWindow(result.roundedPointInInnerNodeFrame());
+point = innerNodeFrame->view()->contentsToWindow(result.roundedPointInInnerNodeFrame());
 } else {
-// FIXME: This should probably use roundedPointInMainFrame and translate from the mainframe.
-point = result.roundedPointInInnerNodeFrame();
+// FIXME: Main frame coords is not the same as window coords,
+// but we do not have pointer to  mainframe view here.
+point = result.roundedPointInMainFrame();
 }
 
 return WEBKIT_HIT_TEST_RESULT(g_object_new(WEBKIT_TYPE_HIT_TEST_RESULT,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151429] trunk

2013-06-11 Thread ossy

Title: [151429] trunk








Revision 151429
Author o...@webkit.org
Date 2013-06-11 01:39:57 -0700 (Tue, 11 Jun 2013)


Log Message
Make WTR use its own temporary directory for application cache
https://bugs.webkit.org/show_bug.cgi?id=117143

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* UIProcess/API/C/WKContext.cpp:
(WKContextSetApplicationCacheDirectory):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setApplicationCacheDirectory):
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (151428 => 151429)

--- trunk/Source/WebKit2/ChangeLog	2013-06-11 08:35:48 UTC (rev 151428)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 08:39:57 UTC (rev 151429)
@@ -1,3 +1,26 @@
+2013-06-11  Csaba Osztrogonác  
+
+Make WTR use its own temporary directory for application cache
+https://bugs.webkit.org/show_bug.cgi?id=117143
+
+Reviewed by Alexey Proskuryakov.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextSetApplicationCacheDirectory):
+* UIProcess/API/C/WKContextPrivate.h:
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::applicationCacheDirectory):
+* UIProcess/WebContext.h:
+(WebKit::WebContext::setApplicationCacheDirectory):
+* UIProcess/efl/WebContextEfl.cpp:
+(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
+* UIProcess/gtk/WebContextGtk.cpp:
+(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
+* UIProcess/qt/WebContextQt.cpp:
+(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
+
 2013-06-11  Michał Pakuła vel Rutka  
 
 [EFL][WK2] Fix test_ewk2_context_menu


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (151428 => 151429)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2013-06-11 08:35:48 UTC (rev 151428)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2013-06-11 08:39:57 UTC (rev 151429)
@@ -294,6 +294,11 @@
 toImpl(contextRef)->allowSpecificHTTPSCertificateForHost(toImpl(certificateRef), toImpl(hostRef)->string());
 }
 
+WK_EXPORT void WKContextSetApplicationCacheDirectory(WKContextRef contextRef, WKStringRef applicationCacheDirectory)
+{
+toImpl(contextRef)->setApplicationCacheDirectory(toImpl(applicationCacheDirectory)->string());
+}
+
 void WKContextSetDatabaseDirectory(WKContextRef contextRef, WKStringRef databaseDirectory)
 {
 toImpl(contextRef)->setDatabaseDirectory(toImpl(databaseDirectory)->string());


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h (151428 => 151429)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h	2013-06-11 08:35:48 UTC (rev 151428)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h	2013-06-11 08:39:57 UTC (rev 151429)
@@ -60,6 +60,7 @@
 
 // FIXME: These functions are only effective if called before the Web process is launched. But
 // we should really change these settings to be on WebPreferences and changeable at runtime.
+WK_EXPORT void WKContextSetApplicationCacheDirectory(WKContextRef context, WKStringRef applicationCacheDirectory);
 WK_EXPORT void WKContextSetDatabaseDirectory(WKContextRef context, WKStringRef databaseDirectory);
 WK_EXPORT void WKContextSetLocalStorageDirectory(WKContextRef context, WKStringRef localStorageDirectory);
 WK_EXPORT void WKContextSetDiskCacheDirectory(WKContextRef context, WKStringRef diskCacheDirectory);


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (151428 => 151429)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2013-06-11 08:35:48 UTC (rev 151428)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2013-06-11 08:39:57 UTC (rev 151429)
@@ -1016,6 +1016,14 @@
 sendToAllProcesses(Messages::WebProcess::StopMemorySampler());
 }
 
+String WebContext::applicationCa

[webkit-changes] [151428] trunk/Source/WebKit2

2013-06-11 Thread commit-queue

Title: [151428] trunk/Source/WebKit2








Revision 151428
Author commit-qu...@webkit.org
Date 2013-06-11 01:35:48 -0700 (Tue, 11 Jun 2013)


Log Message
[EFL][WK2] Fix test_ewk2_context_menu
https://bugs.webkit.org/show_bug.cgi?id=116601

Patch by Michał Pakuła vel Rutka  on 2013-06-11
Reviewed by Gyuyoung Kim.

test_ewk2_context_menu is always passing, it does not test any context menu feature
as it ends before context menu is called.
One single test was divided into two tests: testing WebKit2 created context menu and
testing menus and items created by application.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTrue): added function introducing internal loop until boolean value is changed to true
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(customItemSelected):
(showContextMenu):
(showContextMenuForRemoveAndAppend):
(showContextMenuForSubmenu):
(hideContextMenu):
(TEST_F):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (151427 => 151428)

--- trunk/Source/WebKit2/ChangeLog	2013-06-11 08:10:24 UTC (rev 151427)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 08:35:48 UTC (rev 151428)
@@ -1,3 +1,26 @@
+2013-06-11  Michał Pakuła vel Rutka  
+
+[EFL][WK2] Fix test_ewk2_context_menu
+https://bugs.webkit.org/show_bug.cgi?id=116601
+
+Reviewed by Gyuyoung Kim.
+
+test_ewk2_context_menu is always passing, it does not test any context menu feature
+as it ends before context menu is called.
+One single test was divided into two tests: testing WebKit2 created context menu and
+testing menus and items created by application.
+
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+(EWK2UnitTest::EWK2UnitTestBase::waitUntilTrue): added function introducing internal loop until boolean value is changed to true
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
+(customItemSelected):
+(showContextMenu):
+(showContextMenuForRemoveAndAppend):
+(showContextMenuForSubmenu):
+(hideContextMenu):
+(TEST_F):
+
 2013-06-11  Ryuan Choi  
 
 [EFL][WK2] Add ewk_view_navigate API


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp (151427 => 151428)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2013-06-11 08:10:24 UTC (rev 151427)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2013-06-11 08:35:48 UTC (rev 151428)
@@ -224,6 +224,16 @@
 return !data.didTimeOut();
 }
 
+bool EWK2UnitTestBase::waitUntilTrue(bool &flag, double timeoutSeconds)
+{
+CallbackDataExpectedValue data(true, timeoutSeconds);
+
+while (!data.isDone() && !flag)
+ecore_main_loop_iterate();
+
+return !data.didTimeOut();
+}
+
 void EWK2UnitTestBase::mouseClick(int x, int y, int button)
 {
 Evas* evas = evas_object_evas_get(m_webView);


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h (151427 => 151428)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2013-06-11 08:10:24 UTC (rev 151427)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2013-06-11 08:35:48 UTC (rev 151428)
@@ -50,6 +50,7 @@
 bool waitUntilLoadFinished(double timeoutSeconds = defaultTimeoutSeconds);
 bool waitUntilTitleChangedTo(const char* expectedTitle, double timeoutSeconds = defaultTimeoutSeconds);
 bool waitUntilURLChangedTo(const char* expectedURL, double timeoutSeconds = defaultTimeoutSeconds);
+bool waitUntilTrue(bool &flag, double timeoutSeconds = defaultTimeoutSeconds);
 
 void mouseClick(int x, int y, int button = 1 /*Left*/);
 void mouseDown(int x, int y, int button = 1 /*Left*/);


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp (151427 => 151428)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp	2013-06-11 08:10:24 UTC (rev 151427)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp	2013-06-11 08:35:48 UTC (rev 151428)
@@ -27,6 +27,20 @@
 
 extern EWK2UnitTestEnvironment* environment;
 
+static bool testFinished = false;
+
+static const Ewk_Context_Menu_Item_Type customItemType = EWK_ACTION_TYPE;
+static const Ewk_Context_Menu_Item_Action customItemTag = EWK_CONTEXT_MENU_ITEM_BASE_APPLICATION_TAG;
+static const char customItemTitle[] = "Custom Item";
+static const bool customItemChecked = false;
+static const bool customIt

[webkit-changes] [151426] trunk/Source/WebCore

2013-06-11 Thread commit-queue

Title: [151426] trunk/Source/WebCore








Revision 151426
Author commit-qu...@webkit.org
Date 2013-06-11 00:57:49 -0700 (Tue, 11 Jun 2013)


Log Message
[BlackBerry] Test editing/execCommand/indent-paragraphs.html times out
https://bugs.webkit.org/show_bug.cgi?id=117235

Patch by Carlos Garcia Campos  on 2013-06-11
Reviewed by Rob Buis.

PR 346414.

After r150224 ResourceHandle::start() can fail returning false so
that the ResourceHandle is destroyed and the error not
handled. Handle the errors by scheduling a InvalidURLFailure and
returning true when startJob fails to make sure the ResourceHandle
is not destroyed and the error is handled and notified to the
client.

Fixes timeout in editing/execCommand/indent-paragraphs.html.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151425 => 151426)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 07:34:42 UTC (rev 151425)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 07:57:49 UTC (rev 151426)
@@ -1,3 +1,24 @@
+2013-06-11  Carlos Garcia Campos  
+
+[BlackBerry] Test editing/execCommand/indent-paragraphs.html times out
+https://bugs.webkit.org/show_bug.cgi?id=117235
+
+Reviewed by Rob Buis.
+
+PR 346414.
+
+After r150224 ResourceHandle::start() can fail returning false so
+that the ResourceHandle is destroyed and the error not
+handled. Handle the errors by scheduling a InvalidURLFailure and
+returning true when startJob fails to make sure the ResourceHandle
+is not destroyed and the error is handled and notified to the
+client.
+
+Fixes timeout in editing/execCommand/indent-paragraphs.html.
+
+* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
+(WebCore::ResourceHandle::start):
+
 2013-06-11  Ryosuke Niwa  
 
 Remove IntRect::pixelSnapped* and its enclosingRect since they are no longer used


Modified: trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp (151425 => 151426)

--- trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp	2013-06-11 07:34:42 UTC (rev 151425)
+++ trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp	2013-06-11 07:57:49 UTC (rev 151426)
@@ -117,7 +117,9 @@
 if (!frame || !frame->loader() || !frame->loader()->client() || !client())
 return false;
 int playerId = static_cast(frame->loader()->client())->playerId();
-return NetworkManager::instance()->startJob(playerId, this, frame, d->m_defersLoading) == BlackBerry::Platform::FilterStream::StatusSuccess;
+if (NetworkManager::instance()->startJob(playerId, this, frame, d->m_defersLoading) != BlackBerry::Platform::FilterStream::StatusSuccess)
+scheduleFailure(InvalidURLFailure);
+return true;
 }
 
 void ResourceHandle::pauseLoad(bool pause)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151425] trunk/Source/WebCore

2013-06-11 Thread rniwa

Title: [151425] trunk/Source/WebCore








Revision 151425
Author rn...@webkit.org
Date 2013-06-11 00:34:42 -0700 (Tue, 11 Jun 2013)


Log Message
Remove IntRect::pixelSnapped* and its enclosingRect since they are no longer used
https://bugs.webkit.org/show_bug.cgi?id=117494

Reviewed by Darin Adler.

Merge: https://chromium.googlesource.com/chromium/blink/+/9433dc00e882e2808ac1db3c1fd89090896d7b58
   https://chromium.googlesource.com/chromium/blink/+/7beaa73aa099170cb2cad02c12c5e0a448b12c21

* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
* platform/graphics/IntRect.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::hitTestCulledInline):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Source/WebCore/platform/graphics/IntRect.h
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (151424 => 151425)

--- trunk/Source/WebCore/ChangeLog	2013-06-11 07:10:00 UTC (rev 151424)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 07:34:42 UTC (rev 151425)
@@ -1,3 +1,23 @@
+2013-06-11  Ryosuke Niwa  
+
+Remove IntRect::pixelSnapped* and its enclosingRect since they are no longer used
+https://bugs.webkit.org/show_bug.cgi?id=117494
+
+Reviewed by Darin Adler.
+
+Merge: https://chromium.googlesource.com/chromium/blink/+/9433dc00e882e2808ac1db3c1fd89090896d7b58
+   https://chromium.googlesource.com/chromium/blink/+/7beaa73aa099170cb2cad02c12c5e0a448b12c21
+
+* inspector/InspectorLayerTreeAgent.cpp:
+(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
+* inspector/InspectorOverlay.cpp:
+(WebCore::InspectorOverlay::update):
+* platform/graphics/IntRect.h:
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::hitTestCulledInline):
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::repaintUsingContainer):
+
 2013-06-11  Sergio Villar Senin  
 
 Autoclose braces and parentheses at the end of style sheet


Modified: trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp (151424 => 151425)

--- trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp	2013-06-11 07:10:00 UTC (rev 151424)
+++ trunk/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp	2013-06-11 07:34:42 UTC (rev 151425)
@@ -178,7 +178,7 @@
 RefPtr layerObject = TypeBuilder::LayerTree::Layer::create()
 .setLayerId(bind(renderLayer))
 .setNodeId(idForNode(errorString, node))
-.setBounds(buildObjectForIntRect(enclosingIntRect(renderer->absoluteBoundingBoxRect(
+.setBounds(buildObjectForIntRect(renderer->absoluteBoundingBoxRect()))
 .setMemory(backing->backingStoreMemoryEstimate())
 .setCompositedBounds(buildObjectForIntRect(backing->compositedBounds()))
 .setPaintCount(backing->graphicsLayer()->repaintCount());


Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (151424 => 151425)

--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp	2013-06-11 07:10:00 UTC (rev 151424)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp	2013-06-11 07:34:42 UTC (rev 151425)
@@ -284,8 +284,8 @@
 return;
 
 FrameView* overlayView = overlayPage()->mainFrame()->view();
-IntSize viewportSize = enclosingIntRect(view->visibleContentRect()).size();
-IntSize frameViewFullSize = enclosingIntRect(view->visibleContentRect(ScrollableArea::IncludeScrollbars)).size();
+IntSize viewportSize = view->visibleContentRect().size();
+IntSize frameViewFullSize = view->visibleContentRect(ScrollableArea::IncludeScrollbars).size();
 IntSize size = m_size.isEmpty() ? frameViewFullSize : m_size;
 overlayPage()->setPageScaleFactor(m_page->pageScaleFactor(), IntPoint());
 size.scale(m_page->pageScaleFactor());


Modified: trunk/Source/WebCore/platform/graphics/IntRect.h (151424 => 151425)

--- trunk/Source/WebCore/platform/graphics/IntRect.h	2013-06-11 07:10:00 UTC (rev 151424)
+++ trunk/Source/WebCore/platform/graphics/IntRect.h	2013-06-11 07:34:42 UTC (rev 151425)
@@ -95,17 +95,6 @@
 int width() const { return m_size.width(); }
 int height() const { return m_size.height(); }
 
-// FIXME: These methods are here only to ease the transition to sub-pixel layout. They should
-// be removed when we close http://webkit.org/b/60318
-int pixelSnappedX() const { return m_location.x(); }
-int pixelSnappedY() const { return m_location.y(); }
-int pixelSnappedMaxX() const { return x() + width(); }
-int pixelSnappedMaxY() const { return y() + height(); }
-int pixelSnappedWidth() const { return m_size.width(); }
-in

[webkit-changes] [151424] trunk

2013-06-11 Thread sergio

Title: [151424] trunk








Revision 151424
Author ser...@webkit.org
Date 2013-06-11 00:10:00 -0700 (Tue, 11 Jun 2013)


Log Message
Autoclose braces and parentheses at the end of style sheet
https://bugs.webkit.org/show_bug.cgi?id=117414

Reviewed by Andreas Kling.

>From Blink r150202 by 

Source/WebCore:

Use closing_parenthesis and closing_brace instead of the literals
'}' and ')'. This allows the parser to treat expressions with
unmatched closing braces/parenthesis as if all of them were
actually closed.

Tests: animations/keyframe-autoclose-brace.html
   css3/autoclose-braces-and-parentheses.html

* css/CSSGrammar.y.in:

LayoutTests:

* animations/keyframe-autoclose-brace-expected.txt: Added.
* animations/keyframe-autoclose-brace.html: Added.
* css3/autoclose-braces-and-parentheses-expected.txt: Added.
* css3/autoclose-braces-and-parentheses.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in


Added Paths

trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt
trunk/LayoutTests/animations/keyframe-autoclose-brace.html
trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt
trunk/LayoutTests/css3/autoclose-braces-and-parentheses.html




Diff

Modified: trunk/LayoutTests/ChangeLog (151423 => 151424)

--- trunk/LayoutTests/ChangeLog	2013-06-11 05:47:40 UTC (rev 151423)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 07:10:00 UTC (rev 151424)
@@ -1,3 +1,17 @@
+2013-06-11  Sergio Villar Senin  
+
+Autoclose braces and parentheses at the end of style sheet
+https://bugs.webkit.org/show_bug.cgi?id=117414
+
+Reviewed by Andreas Kling.
+
+From Blink r150202 by 
+
+* animations/keyframe-autoclose-brace-expected.txt: Added.
+* animations/keyframe-autoclose-brace.html: Added.
+* css3/autoclose-braces-and-parentheses-expected.txt: Added.
+* css3/autoclose-braces-and-parentheses.html: Added.
+
 2013-06-10  Ryosuke Niwa  
 
 Use shouldBeType in animations/keyframes-rule.html


Added: trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt (0 => 151424)

--- trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt	(rev 0)
+++ trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt	2013-06-11 07:10:00 UTC (rev 151424)
@@ -0,0 +1,2 @@
+Tests parsing the @-webkit-keyframes rule without closing brace. "User agents must close all open constructs ... at the end of the style sheet." (http://www.w3.org/TR/CSS21/syndata.html#parsing-errors). So it must be parsed as if all braces are closed.
+Test passed


Added: trunk/LayoutTests/animations/keyframe-autoclose-brace.html (0 => 151424)

--- trunk/LayoutTests/animations/keyframe-autoclose-brace.html	(rev 0)
+++ trunk/LayoutTests/animations/keyframe-autoclose-brace.html	2013-06-11 07:10:00 UTC (rev 151424)
@@ -0,0 +1,46 @@
+
+
+
+
+  
+  Tests CSS parser autocloses braces.
+  
+@-webkit-keyframes "foo" {
+from { left: 100px; }
+40%  { left: 200px; }
+60%  { left: 200px; }
+to   { left: 300px;
+  
+  
+function findKeyframesRule(rule)
+{
+var ss = document.styleSheets;
+for (var i = 0; i < ss.length; ++i) {
+for (var j = 0; j < ss[i].cssRules.length; ++j) {
+if (ss[i].cssRules[j].type == window.CSSRule.WEBKIT_KEYFRAMES_RULE && ss[i].cssRules[j].name == rule)
+return ss[i].cssRules[j];
+}
+}
+
+return null;
+}
+
+function test()
+{
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var keyframes = findKeyframesRule("foo");
+document.getElementById("console").textContent = keyframes && keyframes.cssRules.length == 4 ? "Test passed" : "Test failed";
+}
+
+  
+
+
+Tests parsing the @-webkit-keyframes rule without closing brace. "User agents must close all open constructs ... at the end of the style sheet."
+(
+
+
+


Added: trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt (0 => 151424)

--- trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt	2013-06-11 07:10:00 UTC (rev 151424)
@@ -0,0 +1,3 @@
+Tests parsing style declarations without closing braces and parentheses. "User agents must close all open constructs ... at the end of the style sheet." (http://www.w3.org/TR/CSS21/syndata.html#parsing-errors). So it must be parsed as if all braces and parentheses are closed.
+All tests passed
+


Added: trunk/LayoutTests/css3/autoclose-braces-and-parentheses.html (0 => 151424)

--- trunk/LayoutTests/css3/autoclose-braces-and-parentheses.html	(rev 0)
+++ trunk/LayoutTests/css3/autoclose-braces-and-parentheses.html	2013-06-11 07:10:00 UTC (rev 151424)
@@ -0,0 +1,46 @@
+
+
+.test1 {
+width

53 matches

Mail list logo