[webkit-changes] [163868] trunk/LayoutTests

[ap]

Title: [163868] trunk/LayoutTests








Revision 163868
Author a...@apple.com
Date 2014-02-11 00:30:06 -0800 (Tue, 11 Feb 2014)


Log Message
Add hooks for wrapping CryptoKeys in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=128567

* platform/mac/TestExpectations: Forgot to include this in the patch, skipping a
worker test that no longer works.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163867 => 163868)

--- trunk/LayoutTests/ChangeLog	2014-02-11 07:48:22 UTC (rev 163867)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 08:30:06 UTC (rev 163868)
@@ -1,3 +1,11 @@
+2014-02-11  Alexey Proskuryakov  a...@apple.com
+
+Add hooks for wrapping CryptoKeys in SerializedScriptValue
+https://bugs.webkit.org/show_bug.cgi?id=128567
+
+* platform/mac/TestExpectations: Forgot to include this in the patch, skipping a
+worker test that no longer works.
+
 2014-02-10  Brady Eidson  beid...@apple.com
 
 IndexedDB assertion at IDBTransactionBackend::~IDBTransactionBackend()


Modified: trunk/LayoutTests/platform/mac/TestExpectations (163867 => 163868)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-02-11 07:48:22 UTC (rev 163867)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-02-11 08:30:06 UTC (rev 163868)
@@ -1265,6 +1265,9 @@
 # SubtleCrypto is disabled on Mountain Lion
 webkit.org/b/124261 [ MountainLion ] crypto/subtle [ Skip ]
 
+# Deserialization of a CryptoKey in a worker fails with a crash.
+crypto/subtle/postMessage-worker.html [ Skip ]
+
 webkit.org/b/124311 compositing/regions/transform-transparent-positioned-video-inside-region.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/124318 fullscreen/anonymous-block-merge-crash.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163869] trunk/LayoutTests

[ap]

Title: [163869] trunk/LayoutTests








Revision 163869
Author a...@apple.com
Date 2014-02-11 00:32:57 -0800 (Tue, 11 Feb 2014)


Log Message
Skip IndexedDB tests again, they are failing.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163868 => 163869)

--- trunk/LayoutTests/ChangeLog	2014-02-11 08:30:06 UTC (rev 163868)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 08:32:57 UTC (rev 163869)
@@ -1,5 +1,11 @@
 2014-02-11  Alexey Proskuryakov  a...@apple.com
 
+Skip IndexedDB tests again, they are failing.
+
+* platform/mac-wk2/TestExpectations:
+
+2014-02-11  Alexey Proskuryakov  a...@apple.com
+
 Add hooks for wrapping CryptoKeys in SerializedScriptValue
 https://bugs.webkit.org/show_bug.cgi?id=128567
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (163868 => 163869)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-11 08:30:06 UTC (rev 163868)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-11 08:32:57 UTC (rev 163869)
@@ -472,19 +472,19 @@
 # All IndexedDB tests are skipped in WK1.
 # Reenable individual tests here that are known to pass, with the eventual goal of re-enabling the entire directory.
 # (Except, skip them for now since https://bugs.webkit.org/show_bug.cgi?id=128341 is getting in the way of testing in general)
-storage/indexeddb/mozilla/add-twice-failure.html [ Pass ]
-storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ]
-storage/indexeddb/mozilla/clear.html [ Pass ]
-storage/indexeddb/mozilla/create-index-with-integer-keys.html [ Pass ]
-storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ]
-storage/indexeddb/mozilla/cursor-mutation.html [ Pass ]
-storage/indexeddb/mozilla/cursors.html [ Pass ]
-storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ]
-storage/indexeddb/mozilla/indexes.html [ Pass ]
-storage/indexeddb/mozilla/object-cursors.html [ Pass ]
-storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html [ Pass ]
-storage/indexeddb/mozilla/object-store-remove-values.html [ Pass ]
-storage/indexeddb/mozilla/versionchange-abort.html [ Pass ]
+# storage/indexeddb/mozilla/add-twice-failure.html [ Pass ]
+# storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ]
+# storage/indexeddb/mozilla/clear.html [ Pass ]
+# storage/indexeddb/mozilla/create-index-with-integer-keys.html [ Pass ]
+# storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ]
+# storage/indexeddb/mozilla/cursor-mutation.html [ Pass ]
+# storage/indexeddb/mozilla/cursors.html [ Pass ]
+# storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ]
+# storage/indexeddb/mozilla/indexes.html [ Pass ]
+# storage/indexeddb/mozilla/object-cursors.html [ Pass ]
+# storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html [ Pass ]
+# storage/indexeddb/mozilla/object-store-remove-values.html [ Pass ]
+# storage/indexeddb/mozilla/versionchange-abort.html [ Pass ]
 
 ### END OF (5) Features that are not supported in WebKit1, so skipped in mac/TestExpectations then re-enabled here
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163870] trunk/Tools

[carlosgc]

Title: [163870] trunk/Tools








Revision 163870
Author carlo...@webkit.org
Date 2014-02-11 00:37:17 -0800 (Tue, 11 Feb 2014)


Log Message
Unreviewed. Fix /webkit2/WebKitWebExtension/isolated-world after r163797.

Use a global variable for the script result.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
(scriptDialogCallback):
(testWebExtensionIsolatedWorld):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp




Diff

Modified: trunk/Tools/ChangeLog (163869 => 163870)

--- trunk/Tools/ChangeLog	2014-02-11 08:32:57 UTC (rev 163869)
+++ trunk/Tools/ChangeLog	2014-02-11 08:37:17 UTC (rev 163870)
@@ -1,3 +1,13 @@
+2014-02-11  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Fix /webkit2/WebKitWebExtension/isolated-world after r163797.
+
+Use a global variable for the script result.
+
+* TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
+(scriptDialogCallback):
+(testWebExtensionIsolatedWorld):
+
 2014-02-10  Filip Pizlo  fpi...@apple.com
 
 Make it possible to run tests with --llvmSimpleOpt=false


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp (163869 => 163870)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp	2014-02-11 08:32:57 UTC (rev 163869)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp	2014-02-11 08:37:17 UTC (rev 163870)
@@ -25,6 +25,7 @@
 
 static const char* webExtensionsUserData = Web Extensions user data;
 static WebKitTestBus* bus;
+static GUniquePtrchar scriptDialogResult;
 
 static void testWebExtensionGetTitle(WebViewTest* test, gconstpointer)
 {
@@ -114,11 +115,10 @@
 g_assert_cmpstr(valueString.get(), ==, Foo);
 }
 
-static gboolean scriptDialogCallback(WebKitWebView*, WebKitScriptDialog* dialog, char** result)
+static gboolean scriptDialogCallback(WebKitWebView*, WebKitScriptDialog* dialog, gpointer)
 {
 g_assert_cmpuint(webkit_script_dialog_get_dialog_type(dialog), ==, WEBKIT_SCRIPT_DIALOG_ALERT);
-g_assert(!*result);
-*result = g_strdup(webkit_script_dialog_get_message(dialog));
+scriptDialogResult.reset(g_strdup(webkit_script_dialog_get_message(dialog)));
 return TRUE;
 }
 
@@ -133,8 +133,7 @@
 test-loadHtml(htmlheader/headerbodydiv id='console'/div/body/html, 0);
 test-waitUntilLoadFinished();
 
-GUniqueOutPtrchar result;
-gulong scriptDialogID = g_signal_connect(test-m_webView, script-dialog, G_CALLBACK(scriptDialogCallback), result.outPtr());
+gulong scriptDialogID = g_signal_connect(test-m_webView, script-dialog, G_CALLBACK(scriptDialogCallback), nullptr);
 
 static const char* mainWorldScript =
 top.foo = 'Foo';\n
@@ -142,7 +141,7 @@
 window.open = function () { alert('Main World'); }\n
 document.open(1, 2, 3);;
 test-runJavaScriptAndWaitUntilFinished(mainWorldScript, 0);
-g_assert_cmpstr(result.get(), ==, Main World);
+g_assert_cmpstr(scriptDialogResult.get(), ==, Main World);
 
 WebKitJavascriptResult* _javascript_Result = test-runJavaScriptAndWaitUntilFinished(document.getElementById('console').innerHTML, 0);
 g_assert(_javascript_Result);
@@ -163,7 +162,7 @@
 reinterpret_castGAsyncReadyCallback(runJavaScriptInIsolatedWorldFinishedCallback),
 test);
 g_main_loop_run(test-m_mainLoop);
-g_assert_cmpstr(result.get(), ==, Isolated World);
+g_assert_cmpstr(scriptDialogResult.get(), ==, Isolated World);
 
 // Check that 'top.foo' defined in main world is not visible in isolated world.
 _javascript_Result = test-runJavaScriptAndWaitUntilFinished(document.getElementById('console').innerHTML, 0);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163871] trunk

[commit-queue]

Title: [163871] trunk








Revision 163871
Author commit-qu...@webkit.org
Date 2014-02-11 02:09:22 -0800 (Tue, 11 Feb 2014)


Log Message
[GStreamer] High playback rate causes crash
https://bugs.webkit.org/show_bug.cgi?id=128453

Patch by Piotr Grad p.g...@samsung.com on 2014-02-11
Reviewed by Philippe Normand.

Source/WebCore:

To high playback rate passed to GStreamer was causing crash.
Added guard in setRate method.

Test: media/video-extreme-playbackrate-crash.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setRate):

LayoutTests:

Test checks if passing high playback rate causes crash.

* media/video-extreme-playbackrate-crash-expected.txt: Added.
* media/video-extreme-playbackrate-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp


Added Paths

trunk/LayoutTests/media/video-extreme-playbackrate-crash-expected.txt
trunk/LayoutTests/media/video-extreme-playbackrate-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163870 => 163871)

--- trunk/LayoutTests/ChangeLog	2014-02-11 08:37:17 UTC (rev 163870)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 10:09:22 UTC (rev 163871)
@@ -1,3 +1,15 @@
+2014-02-11  Piotr Grad  p.g...@samsung.com
+
+[GStreamer] High playback rate causes crash
+https://bugs.webkit.org/show_bug.cgi?id=128453
+
+Reviewed by Philippe Normand.
+
+Test checks if passing high playback rate causes crash.
+
+* media/video-extreme-playbackrate-crash-expected.txt: Added.
+* media/video-extreme-playbackrate-crash.html: Added.
+
 2014-02-11  Alexey Proskuryakov  a...@apple.com
 
 Skip IndexedDB tests again, they are failing.


Added: trunk/LayoutTests/media/video-extreme-playbackrate-crash-expected.txt (0 => 163871)

--- trunk/LayoutTests/media/video-extreme-playbackrate-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/video-extreme-playbackrate-crash-expected.txt	2014-02-11 10:09:22 UTC (rev 163871)
@@ -0,0 +1,6 @@
+
+Test that passing extreme playback rate does not cause crash.
+
+EVENT(canplaythrough)
+END OF TEST
+


Added: trunk/LayoutTests/media/video-extreme-playbackrate-crash.html (0 => 163871)

--- trunk/LayoutTests/media/video-extreme-playbackrate-crash.html	(rev 0)
+++ trunk/LayoutTests/media/video-extreme-playbackrate-crash.html	2014-02-11 10:09:22 UTC (rev 163871)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+script
+function start() {
+findMediaElement();
+video.src = "" content/test);
+waitForEventOnce('canplaythrough', canPlayThrough);
+}
+
+function canPlayThrough() {
+video.playbackRate = 1000;
+video.play();
+video.playbackRate = -1000;
+endTest();
+}
+/script
+/head
+body _onload_=start()
+video/video
+pTest that passing extreme playback rate does not cause crash./p
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (163870 => 163871)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 08:37:17 UTC (rev 163870)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 10:09:22 UTC (rev 163871)
@@ -1,3 +1,18 @@
+2014-02-11  Piotr Grad  p.g...@samsung.com
+
+[GStreamer] High playback rate causes crash
+https://bugs.webkit.org/show_bug.cgi?id=128453
+
+Reviewed by Philippe Normand.
+
+To high playback rate passed to GStreamer was causing crash.
+Added guard in setRate method.
+
+Test: media/video-extreme-playbackrate-crash.html
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::setRate):
+
 2014-02-10  Brady Eidson  beid...@apple.com
 
 IndexedDB assertion at IDBTransactionBackend::~IDBTransactionBackend()


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (163870 => 163871)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2014-02-11 08:37:17 UTC (rev 163870)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2014-02-11 10:09:22 UTC (rev 163871)
@@ -862,6 +862,9 @@
 
 void MediaPlayerPrivateGStreamer::setRate(float rate)
 {
+// Higher rate causes crash.
+rate = clampTo(rate, -20, 20);
+
 // Avoid useless playback rate update.
 if (m_playbackRate == rate) {
 // and make sure that upper layers were notified if rate was set






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163872] trunk/Source/WebCore

[benjamin]

Title: [163872] trunk/Source/WebCore








Revision 163872
Author benja...@webkit.org
Date 2014-02-11 02:21:12 -0800 (Tue, 11 Feb 2014)


Log Message
querySelector() does not use the compiler correctly
https://bugs.webkit.org/show_bug.cgi?id=128588

Reviewed by Andreas Kling.

* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
I messed up the refactoring when I landed SelectorQuery. The compiled
code was not used the first time through SelectorDataList::execute.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/SelectorQuery.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (163871 => 163872)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 10:09:22 UTC (rev 163871)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 10:21:12 UTC (rev 163872)
@@ -1,3 +1,15 @@
+2014-02-11  Benjamin Poulain  benja...@webkit.org
+
+querySelector() does not use the compiler correctly
+https://bugs.webkit.org/show_bug.cgi?id=128588
+
+Reviewed by Andreas Kling.
+
+* dom/SelectorQuery.cpp:
+(WebCore::SelectorDataList::execute):
+I messed up the refactoring when I landed SelectorQuery. The compiled
+code was not used the first time through SelectorDataList::execute.
+
 2014-02-11  Piotr Grad  p.g...@samsung.com
 
 [GStreamer] High playback rate causes crash


Modified: trunk/Source/WebCore/dom/SelectorQuery.cpp (163871 => 163872)

--- trunk/Source/WebCore/dom/SelectorQuery.cpp	2014-02-11 10:09:22 UTC (rev 163871)
+++ trunk/Source/WebCore/dom/SelectorQuery.cpp	2014-02-11 10:21:12 UTC (rev 163872)
@@ -309,6 +309,7 @@
 if (!compiledSelectorChecker  selectorData.compilationStatus == SelectorCompilationStatus::NotCompiled) {
 JSC::VM* vm = rootNode.document().scriptExecutionContext()-vm();
 selectorData.compilationStatus = SelectorCompiler::compileSelector(selectorData.selector, vm, selectorData.compiledSelectorCodeRef);
+compiledSelectorChecker = selectorData.compiledSelectorCodeRef.code().executableAddress();
 }
 
 if (compiledSelectorChecker) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163874] trunk/Source/WTF

[commit-queue]

Title: [163874] trunk/Source/WTF








Revision 163874
Author commit-qu...@webkit.org
Date 2014-02-11 08:12:22 -0800 (Tue, 11 Feb 2014)


Log Message
[WinCairo] Compile error, deleted file in WTF.
https://bugs.webkit.org/show_bug.cgi?id=128601

Patch by pe...@outlook.com pe...@outlook.com on 2014-02-11
Reviewed by Csaba Osztrogonác.

* WTF.vcxproj/WTF.vcxproj: Removed reference to deleted file.
* WTF.vcxproj/WTF.vcxproj.filters: Ditto.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj
trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters




Diff

Modified: trunk/Source/WTF/ChangeLog (163873 => 163874)

--- trunk/Source/WTF/ChangeLog	2014-02-11 16:12:08 UTC (rev 163873)
+++ trunk/Source/WTF/ChangeLog	2014-02-11 16:12:22 UTC (rev 163874)
@@ -1,3 +1,13 @@
+2014-02-11  pe...@outlook.com  pe...@outlook.com
+
+[WinCairo] Compile error, deleted file in WTF.
+https://bugs.webkit.org/show_bug.cgi?id=128601
+
+Reviewed by Csaba Osztrogonác.
+
+* WTF.vcxproj/WTF.vcxproj: Removed reference to deleted file.
+* WTF.vcxproj/WTF.vcxproj.filters: Ditto.
+
 2014-02-10  Michael Saboff  msab...@apple.com
 
 Re-enable ARM Thumb2 disassembler


Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj (163873 => 163874)

--- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj	2014-02-11 16:12:08 UTC (rev 163873)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj	2014-02-11 16:12:22 UTC (rev 163874)
@@ -85,16 +85,6 @@
   ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Production|Win32'true/ExcludedFromBuild
   ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Production|x64'true/ExcludedFromBuild
 /ClCompile
-ClCompile Include=..\wtf\gobject\GOwnPtr.cpp
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug|Win32'true/ExcludedFromBuild
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug|x64'true/ExcludedFromBuild
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='DebugSuffix|Win32'true/ExcludedFromBuild
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='DebugSuffix|x64'true/ExcludedFromBuild
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release|Win32'true/ExcludedFromBuild
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release|x64'true/ExcludedFromBuild
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Production|Win32'true/ExcludedFromBuild
-  ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Production|x64'true/ExcludedFromBuild
-/ClCompile
 ClCompile Include=..\wtf\gobject\GRefPtr.cpp
   ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug|Win32'true/ExcludedFromBuild
   ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug|x64'true/ExcludedFromBuild
@@ -206,7 +196,6 @@
 ClInclude Include=..\wtf\GetPtr.h /
 ClInclude Include=..\wtf\gobject\GlibUtilities.h /
 ClInclude Include=..\wtf\gobject\GMutexLocker.h /
-ClInclude Include=..\wtf\gobject\GOwnPtr.h /
 ClInclude Include=..\wtf\gobject\GRefPtr.h /
 ClInclude Include=..\wtf\gobject\GTypedefs.h /
 ClInclude Include=..\wtf\GregorianDateTime.h /


Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters (163873 => 163874)

--- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters	2014-02-11 16:12:08 UTC (rev 163873)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters	2014-02-11 16:12:22 UTC (rev 163874)
@@ -228,9 +228,6 @@
 ClCompile Include=..\wtf\gobject\GlibUtilities.cpp
   Filterwtf\gobject/Filter
 /ClCompile
-ClCompile Include=..\wtf\gobject\GOwnPtr.cpp
-  Filterwtf\gobject/Filter
-/ClCompile
 ClCompile Include=..\wtf\gobject\GRefPtr.cpp
   Filterwtf\gobject/Filter
 /ClCompile
@@ -697,9 +694,6 @@
 ClInclude Include=..\wtf\gobject\GMutexLocker.h
   Filterwtf\gobject/Filter
 /ClInclude
-ClInclude Include=..\wtf\gobject\GOwnPtr.h
-  Filterwtf\gobject/Filter
-/ClInclude
 ClInclude Include=..\wtf\gobject\GRefPtr.h
   Filterwtf\gobject/Filter
 /ClInclude






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163873] trunk

[stavila]

Title: [163873] trunk








Revision 163873
Author stav...@adobe.com
Date 2014-02-11 08:12:08 -0800 (Tue, 11 Feb 2014)


Log Message
[CSS Regions] Overflow above the first region is not properly painted for regions with padding
https://bugs.webkit.org/show_bug.cgi?id=128590

Reviewed by Andrei Bucur.

Source/WebCore:

Painting is done using the layer of the region's container, so offsetting using the content box
of the region itself is incorrect.

Test: fast/regions/region-padding-overflow-hidden.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionContainer):
(WebCore::RenderRegion::regionContainerLayer):
* rendering/RenderRegion.h:

LayoutTests:

Added test for the correct painting of overflow above the first region
when the region has padding.

* fast/regions/region-padding-overflow-hidden-expected.html: Added.
* fast/regions/region-padding-overflow-hidden.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderRegion.cpp
trunk/Source/WebCore/rendering/RenderRegion.h


Added Paths

trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html
trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163872 => 163873)

--- trunk/LayoutTests/ChangeLog	2014-02-11 10:21:12 UTC (rev 163872)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 16:12:08 UTC (rev 163873)
@@ -1,3 +1,16 @@
+2014-02-11  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Overflow above the first region is not properly painted for regions with padding
+https://bugs.webkit.org/show_bug.cgi?id=128590
+
+Reviewed by Andrei Bucur.
+
+Added test for the correct painting of overflow above the first region
+when the region has padding.
+
+* fast/regions/region-padding-overflow-hidden-expected.html: Added.
+* fast/regions/region-padding-overflow-hidden.html: Added.
+
 2014-02-11  Piotr Grad  p.g...@samsung.com
 
 [GStreamer] High playback rate causes crash


Added: trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html (0 => 163873)

--- trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-padding-overflow-hidden-expected.html	2014-02-11 16:12:08 UTC (rev 163873)
@@ -0,0 +1,29 @@
+!DOCTYPE html
+
+style
+#region {
+border: 5px solid blue;
+width: 200px;
+height: 100px;
+padding: 80px;
+margin: 50px;
+overflow: hidden;
+}
+
+#content {
+background-color: lightgrey;
+width: 200px;
+height: 100px;
+}
+/style
+
+body
+a href="" Regions] Overflow above the first region is not properly painted for regions with padding/a
+
+div id=region
+div id=content
+div style=position:relative; top: -40px; color:redThis line should be visible/div
+divThe red line above this one should be visible/div
+/div
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html (0 => 163873)

--- trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/region-padding-overflow-hidden.html	2014-02-11 16:12:08 UTC (rev 163873)
@@ -0,0 +1,31 @@
+!DOCTYPE html
+
+style
+#region {
+-webkit-flow-from: flow;
+border: 5px solid blue;
+width: 200px;
+height: 100px;
+padding: 80px;
+margin: 50px;
+overflow: hidden;
+}
+
+#content {
+-webkit-flow-into: flow;
+background-color: lightgrey;
+width: 200px;
+height: 100px;
+}
+/style
+
+body
+a href="" Regions] Overflow above the first region is not properly painted for regions with padding/a
+
+div id=region/div
+
+div id=content
+div style=position:relative; top: -40px; color:redThis line should be visible/div
+divThe red line above this one should be visible/div
+/div
+/body
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (163872 => 163873)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 10:21:12 UTC (rev 163872)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 16:12:08 UTC (rev 163873)
@@ -1,3 +1,22 @@
+2014-02-11  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] Overflow above the first region is not properly painted for regions with padding
+https://bugs.webkit.org/show_bug.cgi?id=128590
+
+Reviewed by Andrei Bucur.
+
+Painting is done using the layer of the region's container, so offsetting using the content box
+of the region itself is incorrect. 
+
+Test: fast/regions/region-padding-overflow-hidden.html
+

[webkit-changes] [163875] trunk/Source/WebKit2

[berto]

Title: [163875] trunk/Source/WebKit2








Revision 163875
Author be...@igalia.com
Date 2014-02-11 08:14:55 -0800 (Tue, 11 Feb 2014)


Log Message
O_CLOEXEC in shm_open does not work on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128572

Reviewed by Darin Adler.

The O_CLOEXEC is not supported by shm_open() and is also not
necessary since FD_CLOEXEC is already set by default when the new
file descriptor is created.

* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (163874 => 163875)

--- trunk/Source/WebKit2/ChangeLog	2014-02-11 16:12:22 UTC (rev 163874)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-11 16:14:55 UTC (rev 163875)
@@ -1,3 +1,17 @@
+2014-02-11  Alberto Garcia  be...@igalia.com
+
+O_CLOEXEC in shm_open does not work on FreeBSD
+https://bugs.webkit.org/show_bug.cgi?id=128572
+
+Reviewed by Darin Adler.
+
+The O_CLOEXEC is not supported by shm_open() and is also not
+necessary since FD_CLOEXEC is already set by default when the new
+file descriptor is created.
+
+* Platform/unix/SharedMemoryUnix.cpp:
+(WebKit::SharedMemory::create):
+
 2014-02-10  Commit Queue  commit-qu...@webkit.org
 
 Unreviewed, rolling out r163856.


Modified: trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp (163874 => 163875)

--- trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2014-02-11 16:12:22 UTC (rev 163874)
+++ trunk/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp	2014-02-11 16:14:55 UTC (rev 163875)
@@ -107,7 +107,7 @@
 tempName = name.utf8();
 
 do {
-fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);
+fileDescriptor = shm_open(tempName.data(), O_CREAT | O_RDWR, S_IRUSR | S_IWUSR);
 } while (fileDescriptor == -1  errno == EINTR);
 }
 if (fileDescriptor == -1) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163876] trunk/Source/JavaScriptCore

[mhahnenberg]

Title: [163876] trunk/Source/_javascript_Core








Revision 163876
Author mhahnenb...@apple.com
Date 2014-02-11 08:27:40 -0800 (Tue, 11 Feb 2014)


Log Message
Obj-C API: JSExport doesn't work for methods that contain protocols in their type signature
https://bugs.webkit.org/show_bug.cgi?id=128540

Reviewed by Oliver Hunt.

The bug is in parseObjCType in ObjcRuntimeExtras.h. When we see an '@' in the
type signature of a method, we assume that what follows the '@' is a class name,
so we call objc_getClass, and if that returns nil then we give up on the method
and don't export it.

This assumption doesn't work in the case of idProtocol because it's the name
of the protocol that follows the '@', not the name of a class. We should have
another fallback case for protocol names.

There's another case that also doesn't work, and that's the case of a named class
with a specified prototype in a method signature (e.g. NSObjectMyProtocol).
There the substring of the type signature that represents the class is NSObjectMyProtocol,
which will also cause objc_getClass to return nil.

* API/ObjcRuntimeExtras.h:
(parseObjCType):
* API/tests/DateTests.mm: Also fixed an issue I noticed where we don't use an autorelease pool
for the DateTests.
* API/tests/JSExportTests.h: Added.
* API/tests/JSExportTests.mm: Added.
(-[TruthTeller returnTrue]):
(-[ExportMethodWithIdProtocol methodWithIdProtocol:]):
(-[ExportMethodWithClassProtocol methodWithClassProtocol:]):
(+[JSExportTests exportInstanceMethodWithIdProtocolTest]):
(+[JSExportTests exportInstanceMethodWithClassProtocolTest]):
(runJSExportTests):
* API/tests/testapi.mm:
* _javascript_Core.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h
trunk/Source/_javascript_Core/API/tests/DateTests.mm
trunk/Source/_javascript_Core/API/tests/testapi.mm
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj


Added Paths

trunk/Source/_javascript_Core/API/tests/JSExportTests.h
trunk/Source/_javascript_Core/API/tests/JSExportTests.mm




Diff

Modified: trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h (163875 => 163876)

--- trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h	2014-02-11 16:14:55 UTC (rev 163875)
+++ trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h	2014-02-11 16:27:40 UTC (rev 163876)
@@ -192,9 +192,19 @@
 }
 
 if (*position == '') {
-const char* begin = ++position;
-position = index(position, '');
-return DelegateType::typeOfClass(begin, position++);
+const char* begin = position + 1;
+const char* protocolPosition = index(begin, '');
+const char* endOfType = index(begin, '');
+position = endOfType + 1;
+
+// There's no protocol involved in this type, so just handle the class name.
+if (!protocolPosition || protocolPosition  endOfType)
+return DelegateType::typeOfClass(begin, endOfType);
+// We skipped the class name and went straight to the protocol, so this is an id type.
+if (begin == protocolPosition)
+return DelegateType::typeId();
+// We have a class name with a protocol. For now, ignore the protocol.
+return DelegateType::typeOfClass(begin, protocolPosition);
 }
 
 return DelegateType::typeId();


Modified: trunk/Source/_javascript_Core/API/tests/DateTests.mm (163875 => 163876)

--- trunk/Source/_javascript_Core/API/tests/DateTests.mm	2014-02-11 16:14:55 UTC (rev 163875)
+++ trunk/Source/_javascript_Core/API/tests/DateTests.mm	2014-02-11 16:27:40 UTC (rev 163876)
@@ -142,10 +142,12 @@
 
 void runDateTests()
 {
-[DateTests NSDateToJSDateTest];
-[DateTests JSDateToNSDateTest];
-[DateTests roundTripThroughJSDateTest];
-[DateTests roundTripThroughObjCDateTest];
+@autoreleasepool {
+[DateTests NSDateToJSDateTest];
+[DateTests JSDateToNSDateTest];
+[DateTests roundTripThroughJSDateTest];
+[DateTests roundTripThroughObjCDateTest];
+}
 }
 
 #endif // JSC_OBJC_API_ENABLED


Added: trunk/Source/_javascript_Core/API/tests/JSExportTests.h (0 => 163876)

--- trunk/Source/_javascript_Core/API/tests/JSExportTests.h	(rev 0)
+++ trunk/Source/_javascript_Core/API/tests/JSExportTests.h	2014-02-11 16:27:40 UTC (rev 163876)
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other 

[webkit-changes] [163877] trunk

[beidson]

Title: [163877] trunk








Revision 163877
Author beid...@apple.com
Date 2014-02-11 08:27:41 -0800 (Tue, 11 Feb 2014)


Log Message
IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs
rdar://problem/16034112 and https://bugs.webkit.org/show_bug.cgi?id=128581

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::getRecordFromBackingStore): Always store keyPath for Index get results.

LayoutTests:

* platform/mac-wk2/TestExpectations: Add the test to the enabled list.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (163876 => 163877)

--- trunk/LayoutTests/ChangeLog	2014-02-11 16:27:40 UTC (rev 163876)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 16:27:41 UTC (rev 163877)
@@ -1,3 +1,12 @@
+2014-02-11  Brady Eidson  beid...@apple.com
+
+IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs
+rdar://problem/16034112 and https://bugs.webkit.org/show_bug.cgi?id=128581
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac-wk2/TestExpectations: Add the test to the enabled list.
+
 2014-02-11  Radu Stavila  stav...@adobe.com
 
 [CSS Regions] Overflow above the first region is not properly painted for regions with padding


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (163876 => 163877)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-11 16:27:40 UTC (rev 163876)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-11 16:27:41 UTC (rev 163877)
@@ -478,6 +478,7 @@
 # storage/indexeddb/mozilla/create-index-with-integer-keys.html [ Pass ]
 # storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ]
 # storage/indexeddb/mozilla/cursor-mutation.html [ Pass ]
+# storage/indexeddb/mozilla/cursor-update-updates-indexes.html [ Pass ]
 # storage/indexeddb/mozilla/cursors.html [ Pass ]
 # storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ]
 # storage/indexeddb/mozilla/indexes.html [ Pass ]


Modified: trunk/Source/WebKit2/ChangeLog (163876 => 163877)

--- trunk/Source/WebKit2/ChangeLog	2014-02-11 16:27:40 UTC (rev 163876)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-11 16:27:41 UTC (rev 163877)
@@ -1,3 +1,13 @@
+2014-02-11  Brady Eidson  beid...@apple.com
+
+IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs
+rdar://problem/16034112 and https://bugs.webkit.org/show_bug.cgi?id=128581
+
+Reviewed by Alexey Proskuryakov.
+
+* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
+(WebKit::UniqueIDBDatabase::getRecordFromBackingStore): Always store keyPath for Index get results.
+
 2014-02-11  Alberto Garcia  be...@igalia.com
 
 O_CLOEXEC in shm_open does not work on FreeBSD


Modified: trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp (163876 => 163877)

--- trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp	2014-02-11 16:27:40 UTC (rev 163876)
+++ trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp	2014-02-11 16:27:41 UTC (rev 163877)
@@ -933,10 +933,8 @@
 return;
 }
 
-// A get request that meets the following conditions needs to know the object store keypath
-// to inject the result key into the result value object.
-if (objectStoreMetadata.autoIncrement  !objectStoreMetadata.keyPath.isNull())
-result.keyPath = objectStoreMetadata.keyPath;
+// We must return a key path to know how to inject the result key into the result value object.
+result.keyPath = objectStoreMetadata.keyPath;
 
 postMainThreadTask(createAsyncTask(*this, UniqueIDBDatabase::didGetRecordFromBackingStore, requestID, result, 0, String(StringImpl::empty(;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163879] trunk

[fpizlo]

Title: [163879] trunk








Revision 163879
Author fpi...@apple.com
Date 2014-02-11 08:57:09 -0800 (Tue, 11 Feb 2014)


Log Message
LICM should gracefully handle unprofiled code
https://bugs.webkit.org/show_bug.cgi?id=127848

Reviewed by Mark Hahnenberg.

Source/_javascript_Core: 

* dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):

LayoutTests: 

* js/regress/script-tests/unprofiled-licm.js: Added.
(foo):
* js/regress/unprofiled-licm-expected.txt: Added.
* js/regress/unprofiled-licm.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGLICMPhase.cpp


Added Paths

trunk/LayoutTests/js/regress/script-tests/unprofiled-licm.js
trunk/LayoutTests/js/regress/unprofiled-licm-expected.txt
trunk/LayoutTests/js/regress/unprofiled-licm.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163878 => 163879)

--- trunk/LayoutTests/ChangeLog	2014-02-11 16:51:45 UTC (rev 163878)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 16:57:09 UTC (rev 163879)
@@ -1,3 +1,15 @@
+2014-02-10  Filip Pizlo  fpi...@apple.com
+
+LICM should gracefully handle unprofiled code
+https://bugs.webkit.org/show_bug.cgi?id=127848
+
+Reviewed by Mark Hahnenberg.
+
+* js/regress/script-tests/unprofiled-licm.js: Added.
+(foo):
+* js/regress/unprofiled-licm-expected.txt: Added.
+* js/regress/unprofiled-licm.html: Added.
+
 2014-02-10  David Hyatt  hy...@apple.com
 
 [New Multicolumn] Make columns work with line grids


Added: trunk/LayoutTests/js/regress/script-tests/unprofiled-licm.js (0 => 163879)

--- trunk/LayoutTests/js/regress/script-tests/unprofiled-licm.js	(rev 0)
+++ trunk/LayoutTests/js/regress/script-tests/unprofiled-licm.js	2014-02-11 16:57:09 UTC (rev 163879)
@@ -0,0 +1,17 @@
+function foo(o) {
+var result = 0;
+for (var i = 0; i  10; ++i) {
+result += o.f.g.h.i.j;
+if (o.g)
+result += o.h;
+}
+return result;
+}
+
+for (var i = 0; i  100; ++i) {
+var o = {f:{g:{h:{i:{j:1, g:false, h:42};
+var result = foo(o);
+if (result != 10)
+throw Error: bad result:  + result;
+}
+


Added: trunk/LayoutTests/js/regress/unprofiled-licm-expected.txt (0 => 163879)

--- trunk/LayoutTests/js/regress/unprofiled-licm-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/regress/unprofiled-licm-expected.txt	2014-02-11 16:57:09 UTC (rev 163879)
@@ -0,0 +1,10 @@
+JSRegress/unprofiled-licm
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/js/regress/unprofiled-licm.html (0 => 163879)

--- trunk/LayoutTests/js/regress/unprofiled-licm.html	(rev 0)
+++ trunk/LayoutTests/js/regress/unprofiled-licm.html	2014-02-11 16:57:09 UTC (rev 163879)
@@ -0,0 +1,12 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+script src=""
+script src=""
+script src=""
+script src=""
+/body
+/html


Modified: trunk/Source/_javascript_Core/ChangeLog (163878 => 163879)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-11 16:51:45 UTC (rev 163878)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-11 16:57:09 UTC (rev 163879)
@@ -1,3 +1,13 @@
+2014-02-10  Filip Pizlo  fpi...@apple.com
+
+LICM should gracefully handle unprofiled code
+https://bugs.webkit.org/show_bug.cgi?id=127848
+
+Reviewed by Mark Hahnenberg.
+
+* dfg/DFGLICMPhase.cpp:
+(JSC::DFG::LICMPhase::run):
+
 2014-02-11  Mark Hahnenberg  mhahnenb...@apple.com
 
 Obj-C API: JSExport doesn't work for methods that contain protocols in their type signature


Modified: trunk/Source/_javascript_Core/dfg/DFGLICMPhase.cpp (163878 => 163879)

--- trunk/Source/_javascript_Core/dfg/DFGLICMPhase.cpp	2014-02-11 16:51:45 UTC (rev 163878)
+++ trunk/Source/_javascript_Core/dfg/DFGLICMPhase.cpp	2014-02-11 16:57:09 UTC (rev 163879)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -82,12 +82,28 @@
 BasicBlock* block = m_graph.block(blockIndex);
 if (!block)
 continue;
+
+// Skip blocks that are proved to not execute.
+// FIXME: This shouldn't be needed.
+// https://bugs.webkit.org/show_bug.cgi?id=128584
+if (!block-cfaHasVisited)
+continue;
+
 const NaturalLoop* loop = m_graph.m_naturalLoops.innerMostLoopOf(block);
 if (!loop)
 continue;
 LoopData data = ""
-for (unsigned nodeIndex = block-size(); nodeIndex--;)
- 

[webkit-changes] [163878] trunk

[hyatt]

Title: [163878] trunk








Revision 163878
Author hy...@apple.com
Date 2014-02-11 08:51:45 -0800 (Tue, 11 Feb 2014)


Log Message
[New Multicolumn] Make columns work with line grids
https://bugs.webkit.org/show_bug.cgi?id=128555

Reviewed by Antti Koivisto.

Added line-snap-into-columns.html and line-snap-inside-columns.html

Source/WebCore: 

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/LayoutState.h:
(WebCore::LayoutState::pageOffset):
(WebCore::LayoutState::setLineGridPaginationOrigin):
Change the LayoutState to call into the renderer to compute the line
grid pagination origin instead of doing it directly. Added the
appropriate getters and setters to enable the renderer to do this.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLineGridPaginationOrigin):
 * rendering/RenderBlock.h:
An implementation for the old multi-column code. The logic is the
same with tweaks made now that the method is on the renderer instead.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::pageLogicalTopForOffset):
Fix a bug with flow threads and pageLogicalTopForOffset. Normal CSS region-based
flow threads are never embedded in an enclosing pagination context, so they
didn't add in the firstPageLogicalTop (or subtract it when computing the region
hit). Multi-column flow threads do need to subtract out the firstPageLogicalTop,
since it can occur somewhere on the page.

Ultimately regions will need to get smarter here too if they want to work with
line grids, but for now I just fixed multi-column.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination):
Undo this change, since it prevents the inheritance of line grids into the
multi-column layout.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::computeLineGridPaginationOrigin):
* rendering/RenderMultiColumnFlowThread.h:
An implementation for the new multi-column code. The logic is the
same as the old code. Code duplication is ok, since the old multi-column method
in RenderBlock will just be deleted once the new code is turned on, and it's easier
not to intertwine them.

LayoutTests: 

* fast/multicol/newmulticol/line-grid-inside-columns-expected.html: Added.
* fast/multicol/newmulticol/line-grid-inside-columns.html: Added.
* fast/multicol/newmulticol/line-grid-into-columns-expected.html: Added.
* fast/multicol/newmulticol/line-grid-into-columns.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/LayoutState.cpp
trunk/Source/WebCore/rendering/LayoutState.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp
trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.h


Added Paths

trunk/LayoutTests/fast/multicol/newmulticol/line-grid-inside-columns-expected.html
trunk/LayoutTests/fast/multicol/newmulticol/line-grid-inside-columns.html
trunk/LayoutTests/fast/multicol/newmulticol/line-grid-into-columns-expected.html
trunk/LayoutTests/fast/multicol/newmulticol/line-grid-into-columns.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163877 => 163878)

--- trunk/LayoutTests/ChangeLog	2014-02-11 16:27:41 UTC (rev 163877)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 16:51:45 UTC (rev 163878)
@@ -1,3 +1,17 @@
+2014-02-10  David Hyatt  hy...@apple.com
+
+[New Multicolumn] Make columns work with line grids
+https://bugs.webkit.org/show_bug.cgi?id=128555
+
+Reviewed by Antti Koivisto.
+
+Added line-snap-into-columns.html and line-snap-inside-columns.html
+
+* fast/multicol/newmulticol/line-grid-inside-columns-expected.html: Added.
+* fast/multicol/newmulticol/line-grid-inside-columns.html: Added.
+* fast/multicol/newmulticol/line-grid-into-columns-expected.html: Added.
+* fast/multicol/newmulticol/line-grid-into-columns.html: Added.
+
 2014-02-11  Brady Eidson  beid...@apple.com
 
 IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs


Added: trunk/LayoutTests/fast/multicol/newmulticol/line-grid-inside-columns-expected.html (0 => 163878)

--- trunk/LayoutTests/fast/multicol/newmulticol/line-grid-inside-columns-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/line-grid-inside-columns-expected.html	2014-02-11 16:51:45 UTC (rev 163878)
@@ -0,0 +1,48 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+style
+.grid { -webkit-line-grid: simple; -webkit-line-snap: baseline; 
+font-size:36px; }/style
+/head
+body
+
+div style=height:500px; border:2px solid red; -webkit-column-count:2; -webkit-column-fill:auto; column-count:2; column-fill:auto;
+div class=grid
+div style=font-size:16px
+All of this text even though it's smaller should be on the 36px
+grid. 

[webkit-changes] [163880] trunk/LayoutTests

[stavila]

Title: [163880] trunk/LayoutTests








Revision 163880
Author stav...@adobe.com
Date 2014-02-11 09:33:41 -0800 (Tue, 11 Feb 2014)


Log Message
[CSS Regions] clipping rectangle for overflow: hidden should be based on the padding box, not the content box
https://bugs.webkit.org/show_bug.cgi?id=119546

Reviewed by Anders Carlsson.

Added tests for the correct painting of region overflow over the region's padding.
This problem was solved by https://bugs.webkit.org/show_bug.cgi?id=118665 and
https://bugs.webkit.org/show_bug.cgi?id=128590.
Two writing modes (horiz-bt and vert-rl) are still not working properly and a separate
issue has been created for them (https://bugs.webkit.org/show_bug.cgi?id=128600).

* fast/regions/clip-to-padding-box-expected.html: Added.
* fast/regions/clip-to-padding-box-margins-expected.html: Added.
* fast/regions/clip-to-padding-box-margins.html: Added.
* fast/regions/clip-to-padding-box-vertical-lr-expected.html: Added.
* fast/regions/clip-to-padding-box-vertical-lr.html: Added.
* fast/regions/clip-to-padding-box.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-margins-expected.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-margins.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-vertical-lr-expected.html
trunk/LayoutTests/fast/regions/clip-to-padding-box-vertical-lr.html
trunk/LayoutTests/fast/regions/clip-to-padding-box.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163879 => 163880)

--- trunk/LayoutTests/ChangeLog	2014-02-11 16:57:09 UTC (rev 163879)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 17:33:41 UTC (rev 163880)
@@ -1,3 +1,23 @@
+2014-02-11  Radu Stavila  stav...@adobe.com
+
+[CSS Regions] clipping rectangle for overflow: hidden should be based on the padding box, not the content box
+https://bugs.webkit.org/show_bug.cgi?id=119546
+
+Reviewed by Anders Carlsson.
+
+Added tests for the correct painting of region overflow over the region's padding.
+This problem was solved by https://bugs.webkit.org/show_bug.cgi?id=118665 and
+https://bugs.webkit.org/show_bug.cgi?id=128590.
+Two writing modes (horiz-bt and vert-rl) are still not working properly and a separate
+issue has been created for them (https://bugs.webkit.org/show_bug.cgi?id=128600).
+
+* fast/regions/clip-to-padding-box-expected.html: Added.
+* fast/regions/clip-to-padding-box-margins-expected.html: Added.
+* fast/regions/clip-to-padding-box-margins.html: Added.
+* fast/regions/clip-to-padding-box-vertical-lr-expected.html: Added.
+* fast/regions/clip-to-padding-box-vertical-lr.html: Added.
+* fast/regions/clip-to-padding-box.html: Added.
+
 2014-02-10  Filip Pizlo  fpi...@apple.com
 
 LICM should gracefully handle unprofiled code


Added: trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html (0 => 163880)

--- trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/regions/clip-to-padding-box-expected.html	2014-02-11 17:33:41 UTC (rev 163880)
@@ -0,0 +1,55 @@
+!doctype html
+html
+	head
+		titleHidden overflow and regions - Expected - https://webkit.org/b/119546/title
+		style
+			* {
+font: normal 20px Times;
+			}
+			.content {
+margin-top: 2px;
+			}
+			.region {
+width: 60px;
+padding: 10px 20px 30px 40px;
+border: double 10px Gray;
+overflow-x: hidden;
+overflow-y: hidden;
+background-color: #eee;
+			}
+			.innerDivToShowPadding {
+border-width: 0px; padding: 0px; margin: 0px;
+background-color: DarkGray;
+			}
+		/style
+	/head
+	body
+		some text
+		div class=region style=height: 60px
+			div class=content innerDivToShowPadding style=margin-top: 2px;
+span style=position:relative;top:-20px;A/spanbr/ !-- this is too wide, it will be clipped --
+Bbr/
+			/div
+		/div
+
+		some text
+
+		div class=region style=height: 70px
+			div class=content innerDivToShowPadding
+CCC 
+span style=position:relative;left:30px;left:30px/span  !-- it will be clipped to the right --
+span style=position:relative;left:-50px;C/span  !-- it will be clipped to the left --
+			/div
+		/div
+
+		some text
+
+		div class=region style=height: auto
+			div class=content innerDivToShowPadding
+DDD 
+DD  !-- this is too wide, it will be clipped --
+span style=position:relative;top:40px;left:-50px;D/span  !-- it will be clipped down and to the left --
+			/div
+		/div
+	/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/regions/clip-to-padding-box-margins-expected.html (0 => 163880)

--- trunk/LayoutTests/fast/regions/clip-to-padding-box-margins-expected.html	(rev 0)
+++ 

[webkit-changes] [163882] trunk/Source/WebCore

[bfulgham]

Title: [163882] trunk/Source/WebCore








Revision 163882
Author bfulg...@apple.com
Date 2014-02-11 09:36:07 -0800 (Tue, 11 Feb 2014)


Log Message
Correct some uses of 'auto'
https://bugs.webkit.org/show_bug.cgi?id=128578

Reviewed by Anders Carlsson.

Correct the following instances of for (auto ...) to use reference or
const references to avoid copies.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementsFromAttribute):
* css/CSSGridTemplateValue.cpp:
(WebCore::stringForPosition):
* dom/Node.cpp:
(WebCore::NodeListsNodeData::invalidateCaches):
* inspector/PageInjectedScriptManager.cpp:
(WebCore::PageInjectedScriptManager::discardInjectedScriptsFor):
* page/WheelEventDeltaTracker.cpp:
(WebCore::WheelEventDeltaTracker::dominantScrollGestureDirection):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
* platform/graphics/mac/WebLayer.mm:
(WebCore::drawLayerContents):
* platform/ios/TileGrid.mm:
(WebCore::TileGrid::dropTilesBetweenRects):
(WebCore::TileGrid::dropDistantTiles):
(WebCore::TileGrid::dropInvalidTiles):
* rendering/InlineTextBox.cpp:
(WebCore::translateIntersectionPointsToSkipInkBoundaries):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/css/CSSGridTemplateValue.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/inspector/PageInjectedScriptManager.cpp
trunk/Source/WebCore/page/WheelEventDeltaTracker.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm
trunk/Source/WebCore/platform/ios/TileGrid.mm
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/testing/InternalSettings.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (163881 => 163882)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 17:34:39 UTC (rev 163881)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 17:36:07 UTC (rev 163882)
@@ -1,3 +1,36 @@
+2014-02-11  Brent Fulgham  bfulg...@apple.com
+
+Correct some uses of 'auto'
+https://bugs.webkit.org/show_bug.cgi?id=128578
+
+Reviewed by Anders Carlsson.
+
+Correct the following instances of for (auto ...) to use reference or
+const references to avoid copies.
+
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::elementsFromAttribute):
+* css/CSSGridTemplateValue.cpp:
+(WebCore::stringForPosition):
+* dom/Node.cpp:
+(WebCore::NodeListsNodeData::invalidateCaches):
+* inspector/PageInjectedScriptManager.cpp:
+(WebCore::PageInjectedScriptManager::discardInjectedScriptsFor):
+* page/WheelEventDeltaTracker.cpp:
+(WebCore::WheelEventDeltaTracker::dominantScrollGestureDirection):
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
+* platform/graphics/mac/WebLayer.mm:
+(WebCore::drawLayerContents):
+* platform/ios/TileGrid.mm:
+(WebCore::TileGrid::dropTilesBetweenRects):
+(WebCore::TileGrid::dropDistantTiles):
+(WebCore::TileGrid::dropInvalidTiles):
+* rendering/InlineTextBox.cpp:
+(WebCore::translateIntersectionPointsToSkipInkBoundaries):
+* testing/InternalSettings.cpp:
+(WebCore::InternalSettings::Backup::restoreTo):
+
 2014-02-10  David Hyatt  hy...@apple.com
 
 [New Multicolumn] Make columns work with line grids


Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (163881 => 163882)

--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp	2014-02-11 17:34:39 UTC (rev 163881)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp	2014-02-11 17:36:07 UTC (rev 163882)
@@ -2265,7 +2265,7 @@
 VectorString idVector;
 idList.split(' ', idVector);
 
-for (auto idName : idVector) {
+for (const auto idName : idVector) {
 if (Element* idElement = treeScope.getElementById(idName))
 elements.append(idElement);
 }


Modified: trunk/Source/WebCore/css/CSSGridTemplateValue.cpp (163881 => 163882)

--- trunk/Source/WebCore/css/CSSGridTemplateValue.cpp	2014-02-11 17:34:39 UTC (rev 163881)
+++ trunk/Source/WebCore/css/CSSGridTemplateValue.cpp	2014-02-11 17:36:07 UTC (rev 163882)
@@ -51,16 +51,16 @@
 {
 VectorString candidates;
 
-for (auto it = gridAreaMap.begin(), end = gridAreaMap.end(); it != end; ++it) {
-const GridCoordinate coordinate = it-value;
+for (const auto it : gridAreaMap) {
+const GridCoordinate coordinate = it.value;
 if (row = coordinate.rows.initialPositionIndex  row = coordinate.rows.finalPositionIndex)
-candidates.append(it-key);
+candidates.append(it.key);
 }
 
-for (auto it = gridAreaMap.begin(), end = 

[webkit-changes] [163881] trunk/Source/JavaScriptCore

[rgabor]

Title: [163881] trunk/Source/_javascript_Core








Revision 163881
Author rga...@webkit.org
Date 2014-02-11 09:34:39 -0800 (Tue, 11 Feb 2014)


Log Message
LLInt typo error after r139004.
https://bugs.webkit.org/show_bug.cgi?id=128592

Reviewed by Michael Saboff.

* offlineasm/arm.rb: change immediate to register in the condition

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/offlineasm/arm.rb




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163880 => 163881)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-11 17:33:41 UTC (rev 163880)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-11 17:34:39 UTC (rev 163881)
@@ -1,3 +1,12 @@
+2014-02-11  Gabor Rapcsanyi  rga...@webkit.org
+
+LLInt typo error after r139004.
+https://bugs.webkit.org/show_bug.cgi?id=128592
+
+Reviewed by Michael Saboff.
+
+* offlineasm/arm.rb: change immediate to register in the condition
+
 2014-02-10  Filip Pizlo  fpi...@apple.com
 
 LICM should gracefully handle unprofiled code


Modified: trunk/Source/_javascript_Core/offlineasm/arm.rb (163880 => 163881)

--- trunk/Source/_javascript_Core/offlineasm/arm.rb	2014-02-11 17:33:41 UTC (rev 163880)
+++ trunk/Source/_javascript_Core/offlineasm/arm.rb	2014-02-11 17:34:39 UTC (rev 163881)
@@ -335,7 +335,7 @@
 else
 $asm.puts adds #{operands[2].armOperand}, #{operands[1].armOperand}, #{operands[0].armOperand}
 end
-elsif operands.size == 3 and operands[0].immediate?
+elsif operands.size == 3 and operands[0].register?
 raise unless operands[1].register?
 raise unless operands[2].register?
 $asm.puts adds #{armFlippedOperands(operands)}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163883] trunk/Source/WebKit/mac

[ap]

Title: [163883] trunk/Source/WebKit/mac








Revision 163883
Author a...@apple.com
Date 2014-02-11 09:36:10 -0800 (Tue, 11 Feb 2014)


Log Message
iOS build fix.

* WebCoreSupport/WebChromeClient.mm: Fixed incorrectly nested ifdefs.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (163882 => 163883)

--- trunk/Source/WebKit/mac/ChangeLog	2014-02-11 17:36:07 UTC (rev 163882)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-02-11 17:36:10 UTC (rev 163883)
@@ -1,3 +1,9 @@
+2014-02-11  Alexey Proskuryakov  a...@apple.com
+
+iOS build fix.
+
+* WebCoreSupport/WebChromeClient.mm: Fixed incorrectly nested ifdefs.
+
 2014-02-10  Alexey Proskuryakov  a...@apple.com
 
 Add hooks for wrapping CryptoKeys in SerializedScriptValue


Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (163882 => 163883)

--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm	2014-02-11 17:36:07 UTC (rev 163882)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm	2014-02-11 17:36:10 UTC (rev 163883)
@@ -996,6 +996,8 @@
 #endif
 }
 
+#endif // ENABLE(FULLSCREEN_API)
+
 #if ENABLE(SUBTLE_CRYPTO)
 bool WebChromeClient::wrapCryptoKey(const Vectoruint8_t key, Vectoruint8_t wrappedKey) const
 {
@@ -1009,5 +1011,3 @@
 return true;
 }
 #endif
-
-#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163884] branches/safari-537.75-branch/Source/WebCore

[matthew_hanson]

Title: [163884] branches/safari-537.75-branch/Source/WebCore








Revision 163884
Author matthew_han...@apple.com
Date 2014-02-11 09:49:30 -0800 (Tue, 11 Feb 2014)


Log Message
Merge r158058.

Modified Paths

branches/safari-537.75-branch/Source/WebCore/ChangeLog
branches/safari-537.75-branch/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp
branches/safari-537.75-branch/Source/WebCore/Modules/webdatabase/DatabaseManager.h




Diff

Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (163883 => 163884)

--- branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-02-11 17:36:10 UTC (rev 163883)
+++ branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-02-11 17:49:30 UTC (rev 163884)
@@ -1,3 +1,30 @@
+2014-02-11  Matthew Hanson  matthew_han...@apple.com
+
+Merge r158058.
+
+2013-10-25  Mark Lam  mark@apple.com
+
+DatabaseManager's ProposedDatabases need to be thread-safe.
+https://bugs.webkit.org/show_bug.cgi?id=123313.
+
+Reviewed by Geoffrey Garen.
+
+No new tests.
+
+* Modules/webdatabase/DatabaseManager.cpp:
+(WebCore::DatabaseManager::DatabaseManager):
+(WebCore::DatabaseManager::existingDatabaseContextFor):
+(WebCore::DatabaseManager::registerDatabaseContext):
+(WebCore::DatabaseManager::unregisterDatabaseContext):
+(WebCore::DatabaseManager::didConstructDatabaseContext):
+(WebCore::DatabaseManager::didDestructDatabaseContext):
+(WebCore::DatabaseManager::openDatabaseBackend):
+(WebCore::DatabaseManager::addProposedDatabase):
+(WebCore::DatabaseManager::removeProposedDatabase):
+(WebCore::DatabaseManager::fullPathForDatabase):
+(WebCore::DatabaseManager::detailsForNameAndOrigin):
+* Modules/webdatabase/DatabaseManager.h:
+
 2014-02-10  Lucas Forschler  lforsch...@apple.com
 
 Merge r162486


Modified: branches/safari-537.75-branch/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp (163883 => 163884)

--- branches/safari-537.75-branch/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp	2014-02-11 17:36:10 UTC (rev 163883)
+++ branches/safari-537.75-branch/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp	2014-02-11 17:49:30 UTC (rev 163884)
@@ -49,6 +49,20 @@
 
 namespace WebCore {
 
+DatabaseManager::ProposedDatabase::ProposedDatabase(DatabaseManager manager,
+SecurityOrigin* origin, const String name, const String displayName, unsigned long estimatedSize)
+: m_manager(manager)
+, m_origin(origin-isolatedCopy())
+, m_details(name.isolatedCopy(), displayName.isolatedCopy(), estimatedSize, 0)
+{
+m_manager.addProposedDatabase(this);
+}
+
+DatabaseManager::ProposedDatabase::~ProposedDatabase()
+{
+m_manager.removeProposedDatabase(this);
+}
+
 DatabaseManager DatabaseManager::manager()
 {
 static DatabaseManager* dbManager = 0;
@@ -128,7 +142,7 @@
 
 PassRefPtrDatabaseContext DatabaseManager::existingDatabaseContextFor(ScriptExecutionContext* context)
 {
-MutexLocker locker(m_contextMapLock);
+MutexLocker locker(m_lock);
 
 ASSERT(m_databaseContextRegisteredCount = 0);
 ASSERT(m_databaseContextInstanceCount = 0);
@@ -159,7 +173,7 @@
 
 void DatabaseManager::registerDatabaseContext(DatabaseContext* databaseContext)
 {
-MutexLocker locker(m_contextMapLock);
+MutexLocker locker(m_lock);
 ScriptExecutionContext* context = databaseContext-scriptExecutionContext();
 m_contextMap.set(context, databaseContext);
 #if !ASSERT_DISABLED
@@ -169,7 +183,7 @@
 
 void DatabaseManager::unregisterDatabaseContext(DatabaseContext* databaseContext)
 {
-MutexLocker locker(m_contextMapLock);
+MutexLocker locker(m_lock);
 ScriptExecutionContext* context = databaseContext-scriptExecutionContext();
 ASSERT(m_contextMap.get(context));
 #if !ASSERT_DISABLED
@@ -181,13 +195,13 @@
 #if !ASSERT_DISABLED
 void DatabaseManager::didConstructDatabaseContext()
 {
-MutexLocker lock(m_contextMapLock);
+MutexLocker lock(m_lock);
 m_databaseContextInstanceCount++;
 }
 
 void DatabaseManager::didDestructDatabaseContext()
 {
-MutexLocker lock(m_contextMapLock);
+MutexLocker lock(m_lock);
 m_databaseContextInstanceCount--;
 ASSERT(m_databaseContextRegisteredCount = m_databaseContextInstanceCount);
 }
@@ -278,6 +292,18 @@
 return backend.release();
 }
 
+void DatabaseManager::addProposedDatabase(ProposedDatabase* proposedDb)
+{
+MutexLocker locker(m_lock);
+m_proposedDatabases.add(proposedDb);
+}
+
+void DatabaseManager::removeProposedDatabase(ProposedDatabase* proposedDb)
+{
+MutexLocker locker(m_lock);
+m_proposedDatabases.remove(proposedDb);
+}
+
 PassRefPtrDatabase DatabaseManager::openDatabase(ScriptExecutionContext* context,
 const String name, const String expectedVersion, const String displayName,
 unsigned long estimatedSize, 

[webkit-changes] [163885] trunk/Source/WebKit/win

[commit-queue]

Title: [163885] trunk/Source/WebKit/win








Revision 163885
Author commit-qu...@webkit.org
Date 2014-02-11 09:50:52 -0800 (Tue, 11 Feb 2014)


Log Message
[WinCairo] Compile error related to toString function.
https://bugs.webkit.org/show_bug.cgi?id=128607

Patch by pe...@outlook.com pe...@outlook.com on 2014-02-11
Reviewed by Brent Fulgham.

* WebView.cpp:
(toString): Added another toString function to make sure we are not trying to use WTF::toString.

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (163884 => 163885)

--- trunk/Source/WebKit/win/ChangeLog	2014-02-11 17:49:30 UTC (rev 163884)
+++ trunk/Source/WebKit/win/ChangeLog	2014-02-11 17:50:52 UTC (rev 163885)
@@ -1,3 +1,13 @@
+2014-02-11  pe...@outlook.com  pe...@outlook.com
+
+[WinCairo] Compile error related to toString function.
+https://bugs.webkit.org/show_bug.cgi?id=128607
+
+Reviewed by Brent Fulgham.
+
+* WebView.cpp:
+(toString): Added another toString function to make sure we are not trying to use WTF::toString.
+
 2014-02-08  Ryosuke Niwa  rn...@webkit.org
 
 Cleanup the interface of FrameSelection


Modified: trunk/Source/WebKit/win/WebView.cpp (163884 => 163885)

--- trunk/Source/WebKit/win/WebView.cpp	2014-02-11 17:49:30 UTC (rev 163884)
+++ trunk/Source/WebKit/win/WebView.cpp	2014-02-11 17:50:52 UTC (rev 163885)
@@ -227,6 +227,11 @@
 return String(bstr, SysStringLen(bstr));
 }
 
+static inline String toString(BString bstr)
+{
+return String(bstr, SysStringLen(bstr));
+}
+
 static inline URL toURL(BSTR bstr)
 {
 return URL(URL(), toString(bstr));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163887] trunk/Source

[mhahnenberg]

Title: [163887] trunk/Source








Revision 163887
Author mhahnenb...@apple.com
Date 2014-02-11 10:09:36 -0800 (Tue, 11 Feb 2014)


Log Message
32-bit LLInt writeBarrierOnGlobalObject is wrong
https://bugs.webkit.org/show_bug.cgi?id=128556

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm: Also fixed the value check on 64-bit.

Source/WTF:

* wtf/Platform.h: Removed OBJECT_MARK_LOGGING from Platform.h since it already exists in FeatureDefines.h

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163886 => 163887)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-11 18:00:45 UTC (rev 163886)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-11 18:09:36 UTC (rev 163887)
@@ -1,3 +1,13 @@
+2014-02-11  Mark Hahnenberg  mhahnenb...@apple.com
+
+32-bit LLInt writeBarrierOnGlobalObject is wrong
+https://bugs.webkit.org/show_bug.cgi?id=128556
+
+Reviewed by Geoffrey Garen.
+
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm: Also fixed the value check on 64-bit.
+
 2014-02-11  Gabor Rapcsanyi  rga...@webkit.org
 
 LLInt typo error after r139004.


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (163886 => 163887)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2014-02-11 18:00:45 UTC (rev 163886)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2014-02-11 18:09:36 UTC (rev 163887)
@@ -556,6 +556,7 @@
 macro writeBarrierOnGlobalObject(valueOperand)
 if GGC
 loadisFromInstruction(valueOperand, t1)
+loadConstantOrVariableTag(t1, t0)
 bineq t0, CellTag, .writeBarrierDone
 
 loadp CodeBlock[cfr], t3


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (163886 => 163887)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2014-02-11 18:00:45 UTC (rev 163886)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2014-02-11 18:09:36 UTC (rev 163887)
@@ -409,7 +409,7 @@
 macro writeBarrierOnOperands(cellOperand, valueOperand)
 if GGC
 loadisFromInstruction(valueOperand, t1)
-loadConstantOrVariable(t1, t0)
+loadConstantOrVariableCell(t1, t0, .writeBarrierDone)
 btpz t0, .writeBarrierDone
 
 writeBarrierOnOperand(cellOperand)
@@ -420,7 +420,7 @@
 macro writeBarrierOnGlobalObject(valueOperand)
 if GGC
 loadisFromInstruction(valueOperand, t1)
-loadConstantOrVariable(t1, t0)
+loadConstantOrVariableCell(t1, t0, .writeBarrierDone)
 btpz t0, .writeBarrierDone
 
 loadp CodeBlock[cfr], t3


Modified: trunk/Source/WTF/ChangeLog (163886 => 163887)

--- trunk/Source/WTF/ChangeLog	2014-02-11 18:00:45 UTC (rev 163886)
+++ trunk/Source/WTF/ChangeLog	2014-02-11 18:09:36 UTC (rev 163887)
@@ -1,3 +1,12 @@
+2014-02-11  Mark Hahnenberg  mhahnenb...@apple.com
+
+32-bit LLInt writeBarrierOnGlobalObject is wrong
+https://bugs.webkit.org/show_bug.cgi?id=128556
+
+Reviewed by Geoffrey Garen.
+
+* wtf/Platform.h: Removed OBJECT_MARK_LOGGING from Platform.h since it already exists in FeatureDefines.h
+
 2014-02-11  pe...@outlook.com  pe...@outlook.com
 
 [WinCairo] Compile error, deleted file in WTF.


Modified: trunk/Source/WTF/wtf/Platform.h (163886 => 163887)

--- trunk/Source/WTF/wtf/Platform.h	2014-02-11 18:00:45 UTC (rev 163886)
+++ trunk/Source/WTF/wtf/Platform.h	2014-02-11 18:09:36 UTC (rev 163887)
@@ -935,8 +935,6 @@
 #define ENABLE_COMPARE_AND_SWAP 1
 #endif
 
-#define ENABLE_OBJECT_MARK_LOGGING 0
-
 #if !defined(ENABLE_PARALLEL_GC)  !ENABLE(OBJECT_MARK_LOGGING)  (OS(DARWIN)  !PLATFORM(EFL) || PLATFORM(GTK))  ENABLE(COMPARE_AND_SWAP)
 #define ENABLE_PARALLEL_GC 1
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163889] trunk/LayoutTests

[ap]

Title: [163889] trunk/LayoutTests








Revision 163889
Author a...@apple.com
Date 2014-02-11 10:37:33 -0800 (Tue, 11 Feb 2014)


Log Message
Animation tests are flaky in Release on EWS, too.

* platform/mac/TestExpectations: Removed [ Debug ] from several animation test
expectations.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163888 => 163889)

--- trunk/LayoutTests/ChangeLog	2014-02-11 18:25:05 UTC (rev 163888)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 18:37:33 UTC (rev 163889)
@@ -1,3 +1,10 @@
+2014-02-11  Alexey Proskuryakov  a...@apple.com
+
+Animation tests are flaky in Release on EWS, too.
+
+* platform/mac/TestExpectations: Removed [ Debug ] from several animation test
+expectations.
+
 2014-02-11  Sergio Villar Senin  svil...@igalia.com
 
 [CSS Grid Layout] Support calc() breadth size type


Modified: trunk/LayoutTests/platform/mac/TestExpectations (163888 => 163889)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-02-11 18:25:05 UTC (rev 163888)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-02-11 18:37:33 UTC (rev 163889)
@@ -1349,10 +1349,10 @@
 webkit.org/b/128312 [ Mavericks ] media/video-load-preload-metadata.html [ Pass Failure ]
 
 # These tests were always flaky, but became a lot more so at in r163472-r163476.
-webkit.org/b/49182 [ Debug ] animations/stop-animation-on-suspend.html [ Pass Failure ]
-webkit.org/b/50959 [ Debug ] animations/play-state-suspend.html [ Pass Failure ]
-webkit.org/b/122040 [ Debug ] animations/combo-transform-translate+scale.html [ Pass Failure ]
-webkit.org/b/128379 [ Debug ] animations/suspend-resume-animation.html [ Pass Failure ]
+webkit.org/b/49182 animations/stop-animation-on-suspend.html [ Pass Failure ]
+webkit.org/b/50959 animations/play-state-suspend.html [ Pass Failure ]
+webkit.org/b/122040 animations/combo-transform-translate+scale.html [ Pass Failure ]
+webkit.org/b/128379 animations/suspend-resume-animation.html [ Pass Failure ]
 
 webkit.org/b/119747 [ Debug ] svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html [ Skip ]
 webkit.org/b/119747 [ Debug ] svg/css/font-face-crash.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163892] trunk

[beidson]

Title: [163892] trunk








Revision 163892
Author beid...@apple.com
Date 2014-02-11 11:31:46 -0800 (Tue, 11 Feb 2014)


Log Message
IndexedDB tests on some bots are flakey (timeouts)
rdar://problem/16038745 and https://bugs.webkit.org/show_bug.cgi?id=128612

Reviewed by Sam Weinig.

Source/WebKit2:

When messing with JSC VM’s and such, always use APIEntryShim instead of JSLockHolder.
*ESPECIALLY* when dealing with multiple threads.

* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):

LayoutTests:

* platform/mac-wk2/TestExpectations: Reenable the tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (163891 => 163892)

--- trunk/LayoutTests/ChangeLog	2014-02-11 19:27:12 UTC (rev 163891)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 19:31:46 UTC (rev 163892)
@@ -1,3 +1,12 @@
+2014-02-11  Brady Eidson  beid...@apple.com
+
+IndexedDB tests on some bots are flakey (timeouts)
+rdar://problem/16038745 and https://bugs.webkit.org/show_bug.cgi?id=128612
+
+Reviewed by Sam Weinig.
+
+* platform/mac-wk2/TestExpectations: Reenable the tests.
+
 2014-02-11  James Craig  jcr...@apple.com
 
 Web Inspector: AX: Accessibility Node Inspection


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (163891 => 163892)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-11 19:27:12 UTC (rev 163891)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2014-02-11 19:31:46 UTC (rev 163892)
@@ -472,20 +472,20 @@
 # All IndexedDB tests are skipped in WK1.
 # Reenable individual tests here that are known to pass, with the eventual goal of re-enabling the entire directory.
 # (Except, skip them for now since https://bugs.webkit.org/show_bug.cgi?id=128341 is getting in the way of testing in general)
-# storage/indexeddb/mozilla/add-twice-failure.html [ Pass ]
-# storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ]
-# storage/indexeddb/mozilla/clear.html [ Pass ]
-# storage/indexeddb/mozilla/create-index-with-integer-keys.html [ Pass ]
-# storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ]
-# storage/indexeddb/mozilla/cursor-mutation.html [ Pass ]
-# storage/indexeddb/mozilla/cursor-update-updates-indexes.html [ Pass ]
-# storage/indexeddb/mozilla/cursors.html [ Pass ]
-# storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ]
-# storage/indexeddb/mozilla/indexes.html [ Pass ]
-# storage/indexeddb/mozilla/object-cursors.html [ Pass ]
-# storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html [ Pass ]
-# storage/indexeddb/mozilla/object-store-remove-values.html [ Pass ]
-# storage/indexeddb/mozilla/versionchange-abort.html [ Pass ]
+storage/indexeddb/mozilla/add-twice-failure.html [ Pass ]
+storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ]
+storage/indexeddb/mozilla/clear.html [ Pass ]
+storage/indexeddb/mozilla/create-index-with-integer-keys.html [ Pass ]
+storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ]
+storage/indexeddb/mozilla/cursor-mutation.html [ Pass ]
+storage/indexeddb/mozilla/cursor-update-updates-indexes.html [ Pass ]
+storage/indexeddb/mozilla/cursors.html [ Pass ]
+storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ]
+storage/indexeddb/mozilla/indexes.html [ Pass ]
+storage/indexeddb/mozilla/object-cursors.html [ Pass ]
+storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html [ Pass ]
+storage/indexeddb/mozilla/object-store-remove-values.html [ Pass ]
+storage/indexeddb/mozilla/versionchange-abort.html [ Pass ]
 
 ### END OF (5) Features that are not supported in WebKit1, so skipped in mac/TestExpectations then re-enabled here
 


Modified: trunk/Source/WebKit2/ChangeLog (163891 => 163892)

--- trunk/Source/WebKit2/ChangeLog	2014-02-11 19:27:12 UTC (rev 163891)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-11 19:31:46 UTC (rev 163892)
@@ -1,3 +1,17 @@
+2014-02-11  Brady Eidson  beid...@apple.com
+
+IndexedDB tests on some bots are flakey (timeouts)
+rdar://problem/16038745 and https://bugs.webkit.org/show_bug.cgi?id=128612
+
+Reviewed by Sam Weinig.
+
+When messing with JSC VM’s and such, always use APIEntryShim instead of JSLockHolder.
+*ESPECIALLY* when dealing with multiple threads.
+
+* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
+(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite): 
+(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):
+
 2014-02-11  Dan Bernstein  

[webkit-changes] [163893] trunk/Source/WebCore

[mitz]

Title: [163893] trunk/Source/WebCore








Revision 163893
Author m...@apple.com
Date 2014-02-11 11:49:52 -0800 (Tue, 11 Feb 2014)


Log Message
iOS build fix.

* platform/ios/TileGrid.mm:
(WebCore::TileGrid::dropTilesBetweenRects):
(WebCore::TileGrid::dropDistantTiles):
(WebCore::TileGrid::dropInvalidTiles):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/TileGrid.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (163892 => 163893)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 19:31:46 UTC (rev 163892)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 19:49:52 UTC (rev 163893)
@@ -1,3 +1,12 @@
+2014-02-11  Dan Bernstein  m...@apple.com
+
+iOS build fix.
+
+* platform/ios/TileGrid.mm:
+(WebCore::TileGrid::dropTilesBetweenRects):
+(WebCore::TileGrid::dropDistantTiles):
+(WebCore::TileGrid::dropInvalidTiles):
+
 2014-02-11  James Craig  jcr...@apple.com
 
 Web Inspector: AX: Accessibility Node Inspection


Modified: trunk/Source/WebCore/platform/ios/TileGrid.mm (163892 => 163893)

--- trunk/Source/WebCore/platform/ios/TileGrid.mm	2014-02-11 19:31:46 UTC (rev 163892)
+++ trunk/Source/WebCore/platform/ios/TileGrid.mm	2014-02-11 19:49:52 UTC (rev 163893)
@@ -86,7 +86,7 @@
 {
 VectorTileIndex toRemove;
 for (const auto tile : m_tiles) {
-TileIndex index = tile.key;
+const TileIndex index = tile.key;
 IntRect tileRect = tile.value-rect();
 if (tileRect.intersects(dropRect)  !tileRect.intersects(keepRect))
 toRemove.append(index);
@@ -125,7 +125,7 @@
 IntRect visibleRect = this-visibleRect();
 Vectorstd::pairdouble, TileIndex toRemove;
 for (const auto tile : m_tiles) {
-TileIndex index = tile.key;
+const TileIndex index = tile.key;
 const IntRect tileRect = tile.value-rect();
 double distance = tileDistance2(visibleRect, tileRect);
 if (distance = shortestDistance)
@@ -317,7 +317,7 @@
 IntRect dropBounds = intersection(m_validBounds, bounds);
 VectorTileIndex toRemove;
 for (const auto tile : m_tiles) {
-TileIndex index = tile.key;
+const TileIndex index = tile.key;
 const IntRect tileRect = tile.value-rect();
 IntRect expectedTileRect = tileRectForIndex(index);
 if (expectedTileRect != tileRect || !dropBounds.contains(tileRect))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163894] trunk/Tools

[ddkilzer]

Title: [163894] trunk/Tools








Revision 163894
Author ddkil...@apple.com
Date 2014-02-11 12:12:30 -0800 (Tue, 11 Feb 2014)


Log Message
[ASan] Fix build failures in Tools due to missing $(inherited) values
http://webkit.org/b/128485

Reviewed by Dean Jackson.

* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- Move $(inherited) from OTHER_LDFLAGS_macosx to OTHER_LDFLAGS.

* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
* DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
- Add $(inherited) to OTHER_LDFLAGS.

* WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
- Add $(inherited) to OTHER_LDFLAGS, or move from
  OTHER_LDFLAGS_BASE to OTHER_LDFLAGS.
- Extract $(OTHER_LDFLAGS_BASE) from platform-specific settings
  into OTHER_LDFLAGS.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig
trunk/Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig
trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig
trunk/Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig
trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig




Diff

Modified: trunk/Tools/ChangeLog (163893 => 163894)

--- trunk/Tools/ChangeLog	2014-02-11 19:49:52 UTC (rev 163893)
+++ trunk/Tools/ChangeLog	2014-02-11 20:12:30 UTC (rev 163894)
@@ -1,3 +1,24 @@
+2014-02-11  David Kilzer  ddkil...@apple.com
+
+[ASan] Fix build failures in Tools due to missing $(inherited) values
+http://webkit.org/b/128485
+
+Reviewed by Dean Jackson.
+
+* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
+- Move $(inherited) from OTHER_LDFLAGS_macosx to OTHER_LDFLAGS.
+
+* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
+* DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
+- Add $(inherited) to OTHER_LDFLAGS.
+
+* WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
+* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
+- Add $(inherited) to OTHER_LDFLAGS, or move from
+  OTHER_LDFLAGS_BASE to OTHER_LDFLAGS.
+- Extract $(OTHER_LDFLAGS_BASE) from platform-specific settings
+  into OTHER_LDFLAGS.
+
 2014-02-11  James Craig  jcr...@apple.com
 
 Web Inspector: AX: Accessibility Node Inspection


Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig (163893 => 163894)

--- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig	2014-02-11 19:49:52 UTC (rev 163893)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig	2014-02-11 20:12:30 UTC (rev 163894)
@@ -23,8 +23,8 @@
 
 #include BaseTarget.xcconfig
 
-OTHER_LDFLAGS = $(OTHER_LDFLAGS_$(PLATFORM_NAME));
-OTHER_LDFLAGS_macosx = $(inherited) -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework Carbon -framework Cocoa -framework _javascript_Core -framework OpenGL -framework WebKit;
+OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_$(PLATFORM_NAME));
+OTHER_LDFLAGS_macosx = -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework Carbon -framework Cocoa -framework _javascript_Core -framework OpenGL -framework WebKit;
 LD_RUNPATH_SEARCH_PATHS = @loader_path/.;
 PRODUCT_NAME = DumpRenderTree;
 EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_SOURCE_FILE_NAMES_$(PLATFORM_NAME));


Modified: trunk/Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig (163893 => 163894)

--- trunk/Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig	2014-02-11 19:49:52 UTC (rev 163893)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig	2014-02-11 20:12:30 UTC (rev 163894)
@@ -24,7 +24,7 @@
 #include BaseTarget.xcconfig
 
 PRODUCT_NAME = ImageDiff;
-OTHER_LDFLAGS = $(OTHER_LDFLAGS_$(PLATFORM_NAME));
+OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_$(PLATFORM_NAME));
 OTHER_LDFLAGS_macosx = -framework Carbon -framework Cocoa -framework QuartzCore;
 OTHER_LDFLAGS_iphoneos = -framework CoreFoundation -framework CoreGraphics -framework MobileCoreServices -framework ImageIO;
 OTHER_LDFLAGS_iphonesimulator = $(OTHER_LDFLAGS_iphoneos);


Modified: trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig (163893 => 163894)

--- trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig	2014-02-11 19:49:52 UTC (rev 163893)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig	2014-02-11 20:12:30 UTC (rev 163894)
@@ -25,5 +25,5 @@
 
 #include BaseTarget.xcconfig
 
-OTHER_LDFLAGS = $(OTHER_LDFLAGS_$(PLATFORM_NAME));
+OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_$(PLATFORM_NAME));
 OTHER_LDFLAGS_macosx = -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;


Modified: trunk/Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig 

[webkit-changes] [163897] trunk/Source/JavaScriptCore

[commit-queue]

Title: [163897] trunk/Source/_javascript_Core








Revision 163897
Author commit-qu...@webkit.org
Date 2014-02-11 12:32:09 -0800 (Tue, 11 Feb 2014)


Log Message
Add Availability Macros to new JSC APIs
https://bugs.webkit.org/show_bug.cgi?id=128615

Patch by Joseph Pecoraro pecor...@apple.com on 2014-02-11
Reviewed by Mark Rowe.

* API/JSContext.h:
* API/JSContextRef.h:

Modified Paths

trunk/Source/_javascript_Core/API/JSContext.h
trunk/Source/_javascript_Core/API/JSContextRef.h
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSContext.h (163896 => 163897)

--- trunk/Source/_javascript_Core/API/JSContext.h	2014-02-11 20:28:59 UTC (rev 163896)
+++ trunk/Source/_javascript_Core/API/JSContext.h	2014-02-11 20:32:09 UTC (rev 163897)
@@ -179,7 +179,7 @@
 @property
 @discussion Name of the JSContext. Exposed when remote debugging the context.
 */
-@property (copy) NSString *name;
+@property (copy) NSString *name NS_AVAILABLE(10_10, 8_0);
 
 @end
 


Modified: trunk/Source/_javascript_Core/API/JSContextRef.h (163896 => 163897)

--- trunk/Source/_javascript_Core/API/JSContextRef.h	2014-02-11 20:28:59 UTC (rev 163896)
+++ trunk/Source/_javascript_Core/API/JSContextRef.h	2014-02-11 20:32:09 UTC (rev 163897)
@@ -141,7 +141,7 @@
 @discussion A JSGlobalContext's name is exposed for remote debugging to make it
 easier to identify the context you would like to attach to.
 */
-JS_EXPORT JSStringRef JSGlobalContextCopyName(JSGlobalContextRef ctx);
+JS_EXPORT JSStringRef JSGlobalContextCopyName(JSGlobalContextRef ctx) CF_AVAILABLE(10_10, 8_0);
 
 /*!
 @function
@@ -149,7 +149,7 @@
 @param ctx The JSGlobalContext that you want to name.
 @param name The remote debugging name to set on ctx.
 */
-JS_EXPORT void JSGlobalContextSetName(JSGlobalContextRef ctx, JSStringRef name);
+JS_EXPORT void JSGlobalContextSetName(JSGlobalContextRef ctx, JSStringRef name) CF_AVAILABLE(10_10, 8_0);
 
 #ifdef __cplusplus
 }


Modified: trunk/Source/_javascript_Core/ChangeLog (163896 => 163897)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-11 20:28:59 UTC (rev 163896)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-11 20:32:09 UTC (rev 163897)
@@ -1,3 +1,13 @@
+2014-02-11  Joseph Pecoraro  pecor...@apple.com
+
+Add Availability Macros to new JSC APIs
+https://bugs.webkit.org/show_bug.cgi?id=128615
+
+Reviewed by Mark Rowe.
+
+* API/JSContext.h:
+* API/JSContextRef.h:
+
 2014-02-11  Filip Pizlo  fpi...@apple.com
 
 FTL should support CompareEq(ObjectOrOther:, Object:)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163898] branches/safari-537.75-branch

[matthew_hanson]

Title: [163898] branches/safari-537.75-branch








Revision 163898
Author matthew_han...@apple.com
Date 2014-02-11 12:39:02 -0800 (Tue, 11 Feb 2014)


Log Message
Merge r158447.

Modified Paths

branches/safari-537.75-branch/LayoutTests/ChangeLog
branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota-expected.txt
branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota.html
branches/safari-537.75-branch/Tools/ChangeLog
branches/safari-537.75-branch/Tools/DumpRenderTree/TestRunner.cpp
branches/safari-537.75-branch/Tools/DumpRenderTree/TestRunner.h
branches/safari-537.75-branch/Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp
branches/safari-537.75-branch/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp
branches/safari-537.75-branch/Tools/DumpRenderTree/mac/UIDelegate.mm
branches/safari-537.75-branch/Tools/DumpRenderTree/win/UIDelegate.cpp
branches/safari-537.75-branch/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
branches/safari-537.75-branch/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
branches/safari-537.75-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
branches/safari-537.75-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
branches/safari-537.75-branch/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: branches/safari-537.75-branch/LayoutTests/ChangeLog (163897 => 163898)

--- branches/safari-537.75-branch/LayoutTests/ChangeLog	2014-02-11 20:32:09 UTC (rev 163897)
+++ branches/safari-537.75-branch/LayoutTests/ChangeLog	2014-02-11 20:39:02 UTC (rev 163898)
@@ -1,3 +1,25 @@
+2014-01-11  Matthew Hanson  matthew_han...@apple.com
+
+Merge r158447.
+
+2013-10-31  Mark Lam  mark@apple.com
+
+REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
+https://bugs.webkit.org/show_bug.cgi?id=123383.
+
+Reviewed by Geoffrey Garen.
+
+Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
+added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
+tests to set appropriate quota settings to exercise quota expansion tests
+when needed.
+
+* storage/websql/open-database-expand-quota.html:
+- Set databaseDefaultQuota and databaseMaxQuota as needed for this test.
+* storage/websql/open-database-over-quota-expected.txt:
+* storage/websql/open-database-over-quota.html:
+- Revert the change from r157874 which is no longer needed for this test.
+
 2014-02-10  Lucas Forschler  lforsch...@apple.com
 
 Merge r156082


Modified: branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota-expected.txt (163897 => 163898)

--- branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota-expected.txt	2014-02-11 20:32:09 UTC (rev 163897)
+++ branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota-expected.txt	2014-02-11 20:39:02 UTC (rev 163898)
@@ -1,2 +1,2 @@
-This tests that calling openDatabase with a size over 5MB doesn't assert on debug builds.
+This tests that calling openDatabase with a size greater or equal to the test max quota limit of 5MB doesn't assert on debug builds.
 PASS


Modified: branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota.html (163897 => 163898)

--- branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota.html	2014-02-11 20:32:09 UTC (rev 163897)
+++ branches/safari-537.75-branch/LayoutTests/storage/websql/open-database-over-quota.html	2014-02-11 20:39:02 UTC (rev 163898)
@@ -16,7 +16,8 @@
 /script
 /head
 body _onload_=runTest()
-divThis tests that calling openDatabase with a size over 5MB doesn't assert on debug builds.
+divThis tests that calling openDatabase with a size greater or equal to the test max quota limit of 5MB
+doesn't assert on debug builds.
 div id=result
 FAIL: We shouldn't have been able to open the database.
 /div


Modified: branches/safari-537.75-branch/Tools/ChangeLog (163897 => 163898)

--- branches/safari-537.75-branch/Tools/ChangeLog	2014-02-11 20:32:09 UTC (rev 163897)
+++ branches/safari-537.75-branch/Tools/ChangeLog	2014-02-11 20:39:02 UTC (rev 163898)
@@ -1,3 +1,53 @@
+2014-02-11  Matthew Hanson  matthew_han...@apple.com
+
+Merge r158447.
+
+2013-10-31  Mark Lam  mark@apple.com
+
+REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
+https://bugs.webkit.org/show_bug.cgi?id=123383.
+
+Reviewed by Geoffrey Garen.
+
+Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
+added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
+tests to set appropriate quota settings to exercise quota expansion tests
+

[webkit-changes] [163896] trunk/Source/JavaScriptCore

[fpizlo]

Title: [163896] trunk/Source/_javascript_Core








Revision 163896
Author fpi...@apple.com
Date 2014-02-11 12:28:59 -0800 (Tue, 11 Feb 2014)


Log Message
FTL should support CompareEq(ObjectOrOther:, Object:)
https://bugs.webkit.org/show_bug.cgi?id=127752

Reviewed by Oliver Hunt.

Also introduce some helpers for reasoning about nullness and truthyness.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
(JSC::FTL::LowerDFGToLLVM::speculateTruthyObject):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isNotNully):
(JSC::FTL::LowerDFGToLLVM::isNully):
(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
* tests/stress/compare-eq-object-or-other-to-object.js: Added.
(foo):
(test):
* tests/stress/compare-eq-object-to-object-or-other.js: Added.
(foo):
(test):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp


Added Paths

trunk/Source/_javascript_Core/tests/stress/compare-eq-object-or-other-to-object.js
trunk/Source/_javascript_Core/tests/stress/compare-eq-object-to-object-or-other.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163895 => 163896)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-11 20:26:43 UTC (rev 163895)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-11 20:28:59 UTC (rev 163896)
@@ -1,3 +1,29 @@
+2014-02-11  Filip Pizlo  fpi...@apple.com
+
+FTL should support CompareEq(ObjectOrOther:, Object:)
+https://bugs.webkit.org/show_bug.cgi?id=127752
+
+Reviewed by Oliver Hunt.
+
+Also introduce some helpers for reasoning about nullness and truthyness.
+
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
+(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
+(JSC::FTL::LowerDFGToLLVM::speculateTruthyObject):
+(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
+(JSC::FTL::LowerDFGToLLVM::isNotNully):
+(JSC::FTL::LowerDFGToLLVM::isNully):
+(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
+* tests/stress/compare-eq-object-or-other-to-object.js: Added.
+(foo):
+(test):
+* tests/stress/compare-eq-object-to-object-or-other.js: Added.
+(foo):
+(test):
+
 2014-02-11  Mark Hahnenberg  mhahnenb...@apple.com
 
 32-bit LLInt writeBarrierOnGlobalObject is wrong


Modified: trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp (163895 => 163896)

--- trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2014-02-11 20:26:43 UTC (rev 163895)
+++ trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2014-02-11 20:28:59 UTC (rev 163896)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -226,6 +226,12 @@
 break;
 if (node-isBinaryUseKind(UntypedUse))
 break;
+if (node-child1().useKind() == ObjectUse
+ node-child2().useKind() == ObjectOrOtherUse)
+break;
+if (node-child1().useKind() == ObjectOrOtherUse
+ node-child2().useKind() == ObjectUse)
+break;
 return CannotCompile;
 case CompareStrictEq:
 if (node-isBinaryUseKind(Int32Use))


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (163895 => 163896)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-11 20:26:43 UTC (rev 163895)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-11 20:28:59 UTC (rev 163896)
@@ -3208,6 +3208,18 @@
 return;
 }
 
+if (m_node-child1().useKind() == ObjectUse
+ m_node-child2().useKind() == ObjectOrOtherUse) {
+compareEqObjectOrOtherToObject(m_node-child2(), m_node-child1());
+return;
+}
+
+if (m_node-child1().useKind() == ObjectOrOtherUse
+ m_node-child2().useKind() == ObjectUse) {
+compareEqObjectOrOtherToObject(m_node-child2(), m_node-child1());
+return;
+}
+
 if (m_node-isBinaryUseKind(UntypedUse)) {
 nonSpeculativeCompare(LLVMIntEQ, operationCompareEq);
 return;
@@ -3606,6 +3618,52 @@
 RELEASE_ASSERT_NOT_REACHED();
 }
 
+void compareEqObjectOrOtherToObject(Edge leftChild, Edge rightChild)
+{
+LValue rightCell = lowCell(rightChild);
+LValue leftValue = lowJSValue(leftChild);
+
+speculateTruthyObject(rightChild, rightCell, SpecObject);
+

[webkit-changes] [163895] trunk/Source/WebCore

[roger_fong]

Title: [163895] trunk/Source/WebCore








Revision 163895
Author roger_f...@apple.com
Date 2014-02-11 12:26:43 -0800 (Tue, 11 Feb 2014)


Log Message
[Windows] Unreviewed. Speculative test fix.

* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::pixelSnappingFactor):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (163894 => 163895)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 20:12:30 UTC (rev 163894)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 20:26:43 UTC (rev 163895)
@@ -1,3 +1,12 @@
+2014-02-11  Roger Fong  roger_f...@apple.com
+
+[Windows] Unreviewed. Speculative test fix.
+
+* platform/graphics/GraphicsContext.h:
+(WebCore::GraphicsContext::pixelSnappingFactor):
+* platform/graphics/cg/GraphicsContextCG.cpp:
+(WebCore::GraphicsContext::platformInit):
+
 2014-02-11  Dan Bernstein  m...@apple.com
 
 iOS build fix.


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (163894 => 163895)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2014-02-11 20:12:30 UTC (rev 163894)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2014-02-11 20:26:43 UTC (rev 163895)
@@ -444,7 +444,11 @@
 enum IncludeDeviceScale { DefinitelyIncludeDeviceScale, PossiblyIncludeDeviceScale };
 AffineTransform getCTM(IncludeDeviceScale includeScale = PossiblyIncludeDeviceScale) const;
 
+#if PLATFORM(WIN)
+float pixelSnappingFactor() const { return 1.0; }
+#else
 float pixelSnappingFactor() const { return m_pixelSnappingFactor; }
+#endif
 
 #if ENABLE(3D_RENDERING)  USE(TEXTURE_MAPPER)
 // This is needed when using accelerated-compositing in software mode, like in TextureMapper.


Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (163894 => 163895)

--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2014-02-11 20:12:30 UTC (rev 163894)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2014-02-11 20:26:43 UTC (rev 163895)
@@ -127,11 +127,7 @@
 if (cgContext) {
 CGAffineTransform baseDeviceMatrix = CGContextGetUserSpaceToDeviceSpaceTransform(cgContext);
 ASSERT(fabs(baseDeviceMatrix.a) == fabs(baseDeviceMatrix.d));
-#if PLATFORM(WIN)
-m_pixelSnappingFactor = 1;
-#else
 m_pixelSnappingFactor = baseDeviceMatrix.a;
-#endif
 #if PLATFORM(IOS)
 m_state.shouldUseContextColors = shouldUseContextColors;
 if (shouldUseContextColors) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163899] trunk

[samuel_white]

Title: [163899] trunk








Revision 163899
Author samuel_wh...@apple.com
Date 2014-02-11 12:44:03 -0800 (Tue, 11 Feb 2014)


Log Message
AX: Add text replacement activity support to NSAccessibilitySelectTextWithCriteriaParameterizedAttribute.
https://bugs.webkit.org/show_bug.cgi?id=128397

Reviewed by Chris Fleizach.

Source/WebCore:

Added text replacement support for the AXSelectTextWithCriteria parameterized attribute.

No new test. Updated platform/mac/accessibility/select-text.html to test the added functionality.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilitySelectTextCriteria::AccessibilitySelectTextCriteria):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):

Tools:

Updated testing methods to accept a replacement string. This enables us to test text
replacement support for the AXSelectTextWithCriteria parameterized attribute.

* DumpRenderTree/AccessibilityUIElement.cpp:
(selectTextWithCriteriaCallback):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

LayoutTests:

Updated test and expectations to handle text replacement.

* platform/mac/accessibility/select-text-expected.txt:
* platform/mac/accessibility/select-text.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/accessibility/select-text-expected.txt
trunk/LayoutTests/platform/mac/accessibility/select-text.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp
trunk/Tools/DumpRenderTree/AccessibilityUIElement.h
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
trunk/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (163898 => 163899)

--- trunk/LayoutTests/ChangeLog	2014-02-11 20:39:02 UTC (rev 163898)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 20:44:03 UTC (rev 163899)
@@ -1,3 +1,15 @@
+2014-02-11  Samuel White  samuel_wh...@apple.com
+
+AX: Add text replacement activity support to NSAccessibilitySelectTextWithCriteriaParameterizedAttribute.
+https://bugs.webkit.org/show_bug.cgi?id=128397
+
+Reviewed by Chris Fleizach.
+
+Updated test and expectations to handle text replacement.
+
+* platform/mac/accessibility/select-text-expected.txt:
+* platform/mac/accessibility/select-text.html:
+
 2014-02-11  Brady Eidson  beid...@apple.com
 
 IndexedDB tests on some bots are flakey (timeouts)


Modified: trunk/LayoutTests/platform/mac/accessibility/select-text-expected.txt (163898 => 163899)

--- trunk/LayoutTests/platform/mac/accessibility/select-text-expected.txt	2014-02-11 20:39:02 UTC (rev 163898)
+++ trunk/LayoutTests/platform/mac/accessibility/select-text-expected.txt	2014-02-11 20:44:03 UTC (rev 163899)
@@ -1,6 +1,6 @@
-The quick brown fox jumps over the lazy dog.
+The slow brown cat jumps over the lazy dog.
 
-This tests the ability to select text with respect to selection.
+This tests the ability to select and 

[webkit-changes] [163900] branches/safari-537.75-branch/Source/WebCore

[matthew_hanson]

Title: [163900] branches/safari-537.75-branch/Source/WebCore








Revision 163900
Author matthew_han...@apple.com
Date 2014-02-11 13:01:20 -0800 (Tue, 11 Feb 2014)


Log Message
Merge r158719.

Modified Paths

branches/safari-537.75-branch/Source/WebCore/ChangeLog
branches/safari-537.75-branch/Source/WebCore/editing/IndentOutdentCommand.cpp




Diff

Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (163899 => 163900)

--- branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-02-11 20:44:03 UTC (rev 163899)
+++ branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-02-11 21:01:20 UTC (rev 163900)
@@ -1,5 +1,22 @@
 2014-02-11  Matthew Hanson  matthew_han...@apple.com
 
+Merge r158719.
+
+2013-11-05  Ryosuke Niwa  rn...@webkit.org
+
+Protect DOM nodes in IndentOutdentCommand::tryIndentingAsListItem()
+https://bugs.webkit.org/show_bug.cgi?id=123861
+
+Reviewed by Benjamin Poulain.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/297442eb539a2b764fdad323de79099a70179186 partially.
+
+* editing/IndentOutdentCommand.cpp:
+(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Make selectedListItem, previousList, and nextList
+RefPtr since they're are used after calling insertNodeBefore.
+
+2014-02-11  Matthew Hanson  matthew_han...@apple.com
+
 Merge r158058.
 
 2013-10-25  Mark Lam  mark@apple.com


Modified: branches/safari-537.75-branch/Source/WebCore/editing/IndentOutdentCommand.cpp (163899 => 163900)

--- branches/safari-537.75-branch/Source/WebCore/editing/IndentOutdentCommand.cpp	2014-02-11 20:44:03 UTC (rev 163899)
+++ branches/safari-537.75-branch/Source/WebCore/editing/IndentOutdentCommand.cpp	2014-02-11 21:01:20 UTC (rev 163900)
@@ -65,24 +65,24 @@
 return false;
 
 // Find the block that we want to indent.  If it's not a list item (e.g., a div inside a list item), we bail out.
-Element* selectedListItem = enclosingBlock(lastNodeInSelectedParagraph);
+RefPtrElement selectedListItem = enclosingBlock(lastNodeInSelectedParagraph);
 
 // FIXME: we need to deal with the case where there is no li (malformed HTML)
 if (!selectedListItem-hasTagName(liTag))
 return false;
 
 // FIXME: previousElementSibling does not ignore non-rendered content like span/span.  Should we?
-Element* previousList = selectedListItem-previousElementSibling();
-Element* nextList = selectedListItem-nextElementSibling();
-
+RefPtrElement previousList = selectedListItem-previousElementSibling();
+RefPtrElement nextList = selectedListItem-nextElementSibling();
+
 RefPtrElement newList = document()-createElement(listNode-tagQName(), false);
 insertNodeBefore(newList, selectedListItem);
 
-moveParagraphWithClones(start, end, newList.get(), selectedListItem);
+moveParagraphWithClones(start, end, newList.get(), selectedListItem.get());
 
-if (canMergeLists(previousList, newList.get()))
+if (canMergeLists(previousList.get(), newList.get()))
 mergeIdenticalElements(previousList, newList);
-if (canMergeLists(newList.get(), nextList))
+if (canMergeLists(newList.get(), nextList.get()))
 mergeIdenticalElements(newList, nextList);
 
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163901] branches/safari-537.75-branch

[matthew_hanson]

Title: [163901] branches/safari-537.75-branch








Revision 163901
Author matthew_han...@apple.com
Date 2014-02-11 13:12:48 -0800 (Tue, 11 Feb 2014)


Log Message
Merge r158739.

Modified Paths

branches/safari-537.75-branch/LayoutTests/ChangeLog
branches/safari-537.75-branch/Source/WebCore/ChangeLog
branches/safari-537.75-branch/Source/WebCore/dom/ContainerNode.cpp


Added Paths

branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt
branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children.html
branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt
branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-mutation-event-by-remove-children.html
branches/safari-537.75-branch/LayoutTests/fast/dom/Range/range-created-during-remove-children-expected.txt
branches/safari-537.75-branch/LayoutTests/fast/dom/Range/range-created-during-remove-children.html




Diff

Modified: branches/safari-537.75-branch/LayoutTests/ChangeLog (163900 => 163901)

--- branches/safari-537.75-branch/LayoutTests/ChangeLog	2014-02-11 21:01:20 UTC (rev 163900)
+++ branches/safari-537.75-branch/LayoutTests/ChangeLog	2014-02-11 21:12:48 UTC (rev 163901)
@@ -1,5 +1,23 @@
-2014-01-11  Matthew Hanson  matthew_han...@apple.com
+2014-02-11  Matthew Hanson  matthew_han...@apple.com
 
+Merge r158739.
+
+2013-11-06  Ryosuke Niwa  rn...@webkit.org
+
+Notify nodes removal to Range/Selection after dispatching blur and mutation event
+https://bugs.webkit.org/show_bug.cgi?id=123880
+
+Reviewed by Andreas Kling.
+
+* editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt: Added.
+* editing/selection/selection-change-in-blur-event-by-remove-children.html: Added.
+* editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt: Added.
+* editing/selection/selection-change-in-mutation-event-by-remove-children.html: Added.
+* fast/dom/Range/range-created-during-remove-children-expected.txt: Added.
+* fast/dom/Range/range-created-during-remove-children.html: Added.
+
+2014-02-11  Matthew Hanson  matthew_han...@apple.com
+
 Merge r158447.
 
 2013-10-31  Mark Lam  mark@apple.com


Copied: branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt (from rev 158739, trunk/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt) (0 => 163901)

--- branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt	(rev 0)
+++ branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt	2014-02-11 21:12:48 UTC (rev 163901)
@@ -0,0 +1,6 @@
+PASS selection.anchorOffset is 0
+PASS selection.focusOffset is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children.html (from rev 158739, trunk/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children.html) (0 => 163901)

--- branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children.html	(rev 0)
+++ branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children.html	2014-02-11 21:12:48 UTC (rev 163901)
@@ -0,0 +1,26 @@
+div id=container
+p id=description/p
+div id=samplespan contenteditable=truefoobar/span/div
+/div
+div id=console/div
+script src=""
+script
+description('Selection should be updated after set innerHTML.');
+
+var sample = document.getElementById('sample');
+var selection = window.getSelection();
+document.addEventListener('blur', function () {
+selection.selectAllChildren(sample.firstChild);
+}, true);
+
+selection.selectAllChildren(sample.firstChild);
+sample.firstChild.focus();
+sample.innerHTML = '';
+
+shouldBe('selection.anchorOffset', '0');
+shouldBe('selection.focusOffset', '0');
+
+if (window.testRunner)
+document.getElementById('container').outerHTML = '';
+/script
+script src=""


Copied: branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt (from rev 158739, trunk/LayoutTests/editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt) (0 => 163901)

--- branches/safari-537.75-branch/LayoutTests/editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt	(rev 0)
+++ 

[webkit-changes] [163902] trunk/Source/WebCore

[jer . noble]

Title: [163902] trunk/Source/WebCore








Revision 163902
Author jer.no...@apple.com
Date 2014-02-11 13:14:16 -0800 (Tue, 11 Feb 2014)


Log Message
[MediaControls] Allow the media controls script to be debuggable by giving it a generated sourceURL
https://bugs.webkit.org/show_bug.cgi?id=127560

Reviewed by Eric Carlson.

When evaluating a script through ScriptController, if that script does not have an
explicit sourceURL, it will not appear in the resources section of the Web Inspector.
For debug builds only, give the media controls script a generated (i.e. fake) sourceURL.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (163901 => 163902)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 21:12:48 UTC (rev 163901)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 21:14:16 UTC (rev 163902)
@@ -1,3 +1,17 @@
+2014-01-24  Jer Noble  jer.no...@apple.com
+
+[MediaControls] Allow the media controls script to be debuggable by giving it a generated sourceURL
+https://bugs.webkit.org/show_bug.cgi?id=127560
+
+Reviewed by Eric Carlson.
+
+When evaluating a script through ScriptController, if that script does not have an
+explicit sourceURL, it will not appear in the resources section of the Web Inspector.
+For debug builds only, give the media controls script a generated (i.e. fake) sourceURL.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::parseAttribute):
+
 2014-02-11  Samuel White  samuel_wh...@apple.com
 
 AX: Add text replacement activity support to NSAccessibilitySelectTextWithCriteriaParameterizedAttribute.


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (163901 => 163902)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2014-02-11 21:12:48 UTC (rev 163901)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2014-02-11 21:14:16 UTC (rev 163902)
@@ -5701,7 +5701,13 @@
 if (overlayValue.isFunction())
 return true;
 
-scriptController.evaluateInWorld(ScriptSourceCode(mediaControlsScript), world);
+#ifndef NDEBUG
+// Setting a scriptURL allows the source to be debuggable in the inspector.
+URL scriptURL = URL(ParsedURLString, ASCIILiteral(mediaControlsScript));
+#else
+URL scriptURL;
+#endif
+scriptController.evaluateInWorld(ScriptSourceCode(mediaControlsScript, scriptURL), world);
 if (exec-hadException()) {
 exec-clearException();
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163904] trunk/Source/WebCore

[aestes]

Title: [163904] trunk/Source/WebCore








Revision 163904
Author aes...@apple.com
Date 2014-02-11 13:28:51 -0800 (Tue, 11 Feb 2014)


Log Message
[Content Filter] Check for NULL before calling dispatch_release()
https://bugs.webkit.org/show_bug.cgi?id=128576

Reviewed by Darin Adler.

m_neFilterSourceQueue will be NULL if NEFilterSource isn't enabled, and
passing NULL to dispatch_release() is undefined.

* platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::~ContentFilter):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ContentFilterMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (163903 => 163904)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 21:23:26 UTC (rev 163903)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 21:28:51 UTC (rev 163904)
@@ -1,3 +1,16 @@
+2014-02-11  Andy Estes  aes...@apple.com
+
+[Content Filter] Check for NULL before calling dispatch_release()
+https://bugs.webkit.org/show_bug.cgi?id=128576
+
+Reviewed by Darin Adler.
+
+m_neFilterSourceQueue will be NULL if NEFilterSource isn't enabled, and
+passing NULL to dispatch_release() is undefined.
+
+* platform/mac/ContentFilterMac.mm:
+(WebCore::ContentFilter::~ContentFilter):
+
 2014-01-24  Jer Noble  jer.no...@apple.com
 
 [MediaControls] Allow the media controls script to be debuggable by giving it a generated sourceURL


Modified: trunk/Source/WebCore/platform/mac/ContentFilterMac.mm (163903 => 163904)

--- trunk/Source/WebCore/platform/mac/ContentFilterMac.mm	2014-02-11 21:23:26 UTC (rev 163903)
+++ trunk/Source/WebCore/platform/mac/ContentFilterMac.mm	2014-02-11 21:28:51 UTC (rev 163904)
@@ -115,7 +115,8 @@
 ContentFilter::~ContentFilter()
 {
 #if HAVE(NE_FILTER_SOURCE)
-dispatch_release(m_neFilterSourceQueue);
+if (m_neFilterSourceQueue)
+dispatch_release(m_neFilterSourceQueue);
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163905] trunk/Source

[aestes]

Title: [163905] trunk/Source








Revision 163905
Author aes...@apple.com
Date 2014-02-11 13:28:55 -0800 (Tue, 11 Feb 2014)


Log Message
[Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate
https://bugs.webkit.org/show_bug.cgi?id=128583

Reviewed by Anders Carlsson.

The delegate method was removed in Snow Leopard.

Source/WebCore:

* loader/ResourceLoader.cpp:
* loader/ResourceLoader.h:
* platform/network/ResourceHandleClient.h:
* platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

Source/WebKit/mac:

* Misc/WebDownload.mm:

Source/WebKit2:

* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/NetworkResourceLoader.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/ResourceLoader.h
trunk/Source/WebCore/platform/network/ResourceHandleClient.h
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Misc/WebDownload.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163904 => 163905)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 21:28:51 UTC (rev 163904)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 21:28:55 UTC (rev 163905)
@@ -1,5 +1,20 @@
 2014-02-11  Andy Estes  aes...@apple.com
 
+[Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate
+https://bugs.webkit.org/show_bug.cgi?id=128583
+
+Reviewed by Anders Carlsson.
+
+The delegate method was removed in Snow Leopard.
+
+* loader/ResourceLoader.cpp:
+* loader/ResourceLoader.h:
+* platform/network/ResourceHandleClient.h:
+* platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
+* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+
+2014-02-10  Andy Estes  aes...@apple.com
+
 [Content Filter] Check for NULL before calling dispatch_release()
 https://bugs.webkit.org/show_bug.cgi?id=128576
 


Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (163904 => 163905)

--- trunk/Source/WebCore/loader/ResourceLoader.cpp	2014-02-11 21:28:51 UTC (rev 163904)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp	2014-02-11 21:28:55 UTC (rev 163905)
@@ -342,15 +342,6 @@
 frameLoader()-notifier().didReceiveData(this, buffer ? buffer-data() : data, buffer ? buffer-size() : length, static_castint(encodedDataLength));
 }
 
-void ResourceLoader::willStopBufferingData(const char* data, unsigned length)
-{
-if (m_options.dataBufferingPolicy == DoNotBufferData)
-return;
-
-ASSERT(!m_resourceData);
-m_resourceData = ResourceBuffer::create(data, length);
-}
-
 void ResourceLoader::didFinishLoading(double finishTime)
 {
 didFinishLoadingOnePart(finishTime);


Modified: trunk/Source/WebCore/loader/ResourceLoader.h (163904 => 163905)

--- trunk/Source/WebCore/loader/ResourceLoader.h	2014-02-11 21:28:51 UTC (rev 163904)
+++ trunk/Source/WebCore/loader/ResourceLoader.h	2014-02-11 21:28:55 UTC (rev 163905)
@@ -94,7 +94,6 @@
 virtual void didReceiveResponse(const ResourceResponse);
 virtual void didReceiveData(const char*, unsigned, long long encodedDataLength, DataPayloadType);
 virtual void didReceiveBuffer(PassRefPtrSharedBuffer, long long encodedDataLength, DataPayloadType);
-void willStopBufferingData(const char*, unsigned);
 virtual void didFinishLoading(double finishTime);
 virtual void didFail(const ResourceError);
 #if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
@@ -120,9 +119,6 @@
 virtual void didFail(ResourceHandle*, const ResourceError) override;
 virtual void wasBlocked(ResourceHandle*) override;
 virtual void cannotShowURL(ResourceHandle*) override;
-#if PLATFORM(COCOA)  !USE(CFNETWORK)
-virtual void willStopBufferingData(ResourceHandle*, const char* data, unsigned length) override { willStopBufferingData(data, length); }
-#endif
 virtual bool shouldUseCredentialStorage(ResourceHandle*) override { return shouldUseCredentialStorage(); }
 virtual void didReceiveAuthenticationChallenge(ResourceHandle*, const AuthenticationChallenge challenge) override { didReceiveAuthenticationChallenge(challenge); } 
 virtual void didCancelAuthenticationChallenge(ResourceHandle*, const AuthenticationChallenge challenge) override { didCancelAuthenticationChallenge(challenge); } 


Modified: trunk/Source/WebCore/platform/network/ResourceHandleClient.h (163904 => 163905)

--- trunk/Source/WebCore/platform/network/ResourceHandleClient.h	2014-02-11 21:28:51 UTC (rev 163904)
+++ trunk/Source/WebCore/platform/network/ResourceHandleClient.h	2014-02-11 21:28:55 UTC (rev 

[webkit-changes] [163906] trunk/Source/WebCore

[jer . noble]

Title: [163906] trunk/Source/WebCore








Revision 163906
Author jer.no...@apple.com
Date 2014-02-11 13:36:06 -0800 (Tue, 11 Feb 2014)


Log Message
Run UserAgentScripts through jsmin rather than the css preprocessor
https://bugs.webkit.org/show_bug.cgi?id=127559

Reviewed by Tim Horton.

User Agent _javascript_ files were being run through the c++ preprocessor to strip out
comments (and presumably to allow #if ENABLE macros, though that feature is entirely
unused). This had the side effect of removing important whitespace, namely newlines where
there would normally be an implicit semicolon.

Instead, .js files will now be run through the jsmin minifier, used by the inspector.
Jsmin will also strip comments and whitespace, but in a syntactically aware way which will
keep newlines when their presence adds an implied semicolon.

* DerivedSources.make:
* Scripts/make-js-file-arrays.py: Added.
(stringifyCodepoint):
(chunk):
(main):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make


Added Paths

trunk/Source/WebCore/Scripts/
trunk/Source/WebCore/Scripts/make-js-file-arrays.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (163905 => 163906)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 21:28:55 UTC (rev 163905)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 21:36:06 UTC (rev 163906)
@@ -1,3 +1,25 @@
+2014-01-24  Jer Noble  jer.no...@apple.com
+
+Run UserAgentScripts through jsmin rather than the css preprocessor
+https://bugs.webkit.org/show_bug.cgi?id=127559
+
+Reviewed by Tim Horton.
+
+User Agent _javascript_ files were being run through the c++ preprocessor to strip out
+comments (and presumably to allow #if ENABLE macros, though that feature is entirely
+unused). This had the side effect of removing important whitespace, namely newlines where
+there would normally be an implicit semicolon.
+
+Instead, .js files will now be run through the jsmin minifier, used by the inspector.
+Jsmin will also strip comments and whitespace, but in a syntactically aware way which will
+keep newlines when their presence adds an implied semicolon.
+
+* DerivedSources.make:
+* Scripts/make-js-file-arrays.py: Added.
+(stringifyCodepoint):
+(chunk):
+(main):
+
 2014-02-11  Andy Estes  aes...@apple.com
 
 [Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate


Modified: trunk/Source/WebCore/DerivedSources.make (163905 => 163906)

--- trunk/Source/WebCore/DerivedSources.make	2014-02-11 21:28:55 UTC (rev 163905)
+++ trunk/Source/WebCore/DerivedSources.make	2014-02-11 21:36:06 UTC (rev 163906)
@@ -892,8 +892,8 @@
 	USER_AGENT_SCRIPTS := $(USER_AGENT_SCRIPTS) $(WebCore)/Modules/plugins/QuickTimePluginReplacement.js
 endif
 
-UserAgentScripts.h : css/make-css-file-arrays.pl bindings/scripts/preprocessor.pm $(USER_AGENT_SCRIPTS) $(PLATFORM_FEATURE_DEFINES)
-	perl -I$(WebCore)/bindings/scripts $ --defines $(FEATURE_DEFINES) $@ UserAgentScriptsData.cpp $(USER_AGENT_SCRIPTS)
+UserAgentScripts.h : Scripts/make-js-file-arrays.py $(USER_AGENT_SCRIPTS)
+	PYTHONPATH=$(InspectorScripts) python $ $@ UserAgentScriptsData.cpp $(USER_AGENT_SCRIPTS)
 
 # 
 


Added: trunk/Source/WebCore/Scripts/make-js-file-arrays.py (0 => 163906)

--- trunk/Source/WebCore/Scripts/make-js-file-arrays.py	(rev 0)
+++ trunk/Source/WebCore/Scripts/make-js-file-arrays.py	2014-02-11 21:36:06 UTC (rev 163906)
@@ -0,0 +1,91 @@
+#!/usr/bin/env python
+# Copyright (C) 2014 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import io
+import os
+from optparse import OptionParser
+from 

[webkit-changes] [163907] trunk/Source/WebCore

[jer . noble]

Title: [163907] trunk/Source/WebCore








Revision 163907
Author jer.no...@apple.com
Date 2014-02-11 13:50:21 -0800 (Tue, 11 Feb 2014)


Log Message
[EME][Mac] Move the implementation of CDMPrivateAVFoundation back into MediaPlayerPrivateAVFoundationObjC.
https://bugs.webkit.org/show_bug.cgi?id=128559

Reviewed by Dean Jackson.

To prepare for multiple simultaneous CDMs with muliple MediaPlayer types, move the implementation for
CDMPrivateAVFoundation back into its media engine.

* Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
(WebCore::MediaKeyExceptionToErrorCode): Added.
(WebCore::CDMSessionAVFoundation::generateKeyRequest): Moved to MediaPlayerPrivateAVFoundationObjC.
(WebCore::CDMSessionAVFoundation::releaseKeys): Ditto.
(WebCore::CDMSessionAVFoundation::update): Ditto.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::generateKeyRequest): Added, pass through to MediaPlayerPrivate.
(WebCore::MediaPlayer::releaseKeys): Ditto.
(WebCore::MediaPlayer::update): Ditto.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::generateKeyRequest): Added.
(WebCore::MediaPlayerPrivateInterface::releaseKeys): Ditto.
(WebCore::MediaPlayerPrivateInterface::update): Ditto.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::generateKeyRequest): Moved from CDMSessionAVFoundation.
(WebCore::MediaPlayerPrivateAVFoundationObjC::releaseKeys): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::update): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (163906 => 163907)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 21:36:06 UTC (rev 163906)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 21:50:21 UTC (rev 163907)
@@ -1,3 +1,33 @@
+2014-02-10  Jer Noble  jer.no...@apple.com
+
+[EME][Mac] Move the implementation of CDMPrivateAVFoundation back into MediaPlayerPrivateAVFoundationObjC.
+https://bugs.webkit.org/show_bug.cgi?id=128559
+
+Reviewed by Dean Jackson.
+
+To prepare for multiple simultaneous CDMs with muliple MediaPlayer types, move the implementation for
+CDMPrivateAVFoundation back into its media engine.
+
+* Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
+(WebCore::MediaKeyExceptionToErrorCode): Added.
+(WebCore::CDMSessionAVFoundation::generateKeyRequest): Moved to MediaPlayerPrivateAVFoundationObjC.
+(WebCore::CDMSessionAVFoundation::releaseKeys): Ditto.
+(WebCore::CDMSessionAVFoundation::update): Ditto.
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::generateKeyRequest): Added, pass through to MediaPlayerPrivate.
+(WebCore::MediaPlayer::releaseKeys): Ditto.
+(WebCore::MediaPlayer::update): Ditto.
+* platform/graphics/MediaPlayer.h:
+* platform/graphics/MediaPlayerPrivate.h:
+(WebCore::MediaPlayerPrivateInterface::generateKeyRequest): Added.
+(WebCore::MediaPlayerPrivateInterface::releaseKeys): Ditto.
+(WebCore::MediaPlayerPrivateInterface::update): Ditto.
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::generateKeyRequest): Moved from CDMSessionAVFoundation.
+(WebCore::MediaPlayerPrivateAVFoundationObjC::releaseKeys): Ditto.
+(WebCore::MediaPlayerPrivateAVFoundationObjC::update): Ditto.
+
 2014-01-24  Jer Noble  jer.no...@apple.com
 
 Run UserAgentScripts through jsmin rather than the css preprocessor


Modified: trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm (163906 => 163907)

--- trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm	2014-02-11 21:36:06 UTC (rev 163906)
+++ trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm	2014-02-11 21:50:21 UTC (rev 163907)
@@ -90,6 +90,21 @@
 {
 }
 
+static unsigned short MediaKeyExceptionToErrorCode(MediaPlayer::MediaKeyException error)
+{
+switch (error) {
+case MediaPlayer::NoError:
+return 0;
+case MediaPlayer::InvalidPlayerState:
+

[webkit-changes] [163908] trunk/Source/WebKit2

[benjamin]

Title: [163908] trunk/Source/WebKit2








Revision 163908
Author benja...@webkit.org
Date 2014-02-11 13:56:24 -0800 (Tue, 11 Feb 2014)


Log Message
[WK2] Rename screenToWindow to screenToRootView and windowToScreen to rootViewToScreen
https://bugs.webkit.org/show_bug.cgi?id=128575

Patch by Benjamin Poulain bpoul...@apple.com on 2014-02-11
Reviewed by Darin Adler.

In WebKit2, screenToRootView and rootViewToScreen were named screenToWindow and windowToScreen.
Those names were fine on ports were FrameView correspond to the scrollview, but they do not apply on iOS.

This patch renames screenToWindow and windowToScreen to their more generic WebCore counterpart.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::screenToRootView):
(WebKit::PageClientImpl::rootViewToScreen):
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/ios/PageClientImplIOS.h:
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::screenToRootView):
(WebKit::PageClientImpl::rootViewToScreen):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToRootView):
(WebKit::PageClientImpl::rootViewToScreen):
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::screenToRootView):
(WebKit::WebView::rootViewToScreen):
* UIProcess/CoordinatedGraphics/WebView.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::screenToRootView):
(WebKit::WebPageProxy::rootViewToScreen):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::screenToRootView):
(WebKit::WebChromeClient::rootViewToScreen):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::screenToRootView):
(WebKit::WebPage::rootViewToScreen):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject _convertScreenPointToRootView:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h
trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (163907 => 163908)

--- trunk/Source/WebKit2/ChangeLog	2014-02-11 21:50:21 UTC (rev 163907)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-11 21:56:24 UTC (rev 163908)
@@ -1,3 +1,48 @@
+2014-02-11  Benjamin Poulain  bpoul...@apple.com
+
+[WK2] Rename screenToWindow to screenToRootView and windowToScreen to rootViewToScreen
+https://bugs.webkit.org/show_bug.cgi?id=128575
+
+Reviewed by Darin Adler.
+
+In WebKit2, screenToRootView and rootViewToScreen were named screenToWindow and windowToScreen.
+Those names were fine on ports were FrameView correspond to the scrollview, but they do not apply on iOS.
+
+This patch renames screenToWindow and windowToScreen to their more generic WebCore counterpart.
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::screenToRootView):
+(WebKit::PageClientImpl::rootViewToScreen):
+* UIProcess/API/gtk/PageClientImpl.h:
+* UIProcess/API/ios/PageClientImplIOS.h:
+* UIProcess/API/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::screenToRootView):
+(WebKit::PageClientImpl::rootViewToScreen):
+* UIProcess/API/mac/PageClientImpl.h:
+* UIProcess/API/mac/PageClientImpl.mm:
+(WebKit::PageClientImpl::screenToRootView):
+(WebKit::PageClientImpl::rootViewToScreen):
+* UIProcess/CoordinatedGraphics/WebView.cpp:
+(WebKit::WebView::screenToRootView):
+(WebKit::WebView::rootViewToScreen):
+* UIProcess/CoordinatedGraphics/WebView.h:
+* UIProcess/PageClient.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::screenToRootView):
+(WebKit::WebPageProxy::rootViewToScreen):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+(WebKit::WebChromeClient::screenToRootView):
+

[webkit-changes] [163909] trunk/WebKitLibraries

[roger_fong]

Title: [163909] trunk/WebKitLibraries








Revision 163909
Author roger_f...@apple.com
Date 2014-02-11 14:00:14 -0800 (Tue, 11 Feb 2014)


Log Message
[Windows] Set ENABLE_CSS_SHAPE_INSIDE feature flag on Windows.

* win/tools/vsprops/FeatureDefines.props:

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.props




Diff

Modified: trunk/WebKitLibraries/ChangeLog (163908 => 163909)

--- trunk/WebKitLibraries/ChangeLog	2014-02-11 21:56:24 UTC (rev 163908)
+++ trunk/WebKitLibraries/ChangeLog	2014-02-11 22:00:14 UTC (rev 163909)
@@ -1,3 +1,9 @@
+2014-02-11  Roger Fong  roger_f...@apple.com
+
+[Windows] Set ENABLE_CSS_SHAPE_INSIDE feature flag on Windows.
+
+* win/tools/vsprops/FeatureDefines.props:
+
 2014-02-04  Andreas Kling  akl...@apple.com
 
 Remove iframe seamless support.


Modified: trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.props (163908 => 163909)

--- trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.props	2014-02-11 21:56:24 UTC (rev 163908)
+++ trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.props	2014-02-11 22:00:14 UTC (rev 163909)
@@ -19,6 +19,7 @@
 ENABLE_CSS_REGIONSENABLE_CSS_REGIONS/ENABLE_CSS_REGIONS
 ENABLE_CSS_SHADERS /
 ENABLE_CSS_SHAPESENABLE_CSS_SHAPES/ENABLE_CSS_SHAPES
+ENABLE_CSS_SHAPE_INSIDEENABLE_CSS_SHAPE_INSIDE/ENABLE_CSS_SHAPE_INSIDE
 ENABLE_CSS_STICKY_POSITIONENABLE_CSS_STICKY_POSITION/ENABLE_CSS_STICKY_POSITION
 ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXEDENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED/ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
 ENABLE_CUSTOM_SCHEME_HANDLER /
@@ -89,7 +90,7 @@
   /PropertyGroup
   ItemDefinitionGroup
 ClCompile
-PreprocessorDefinitions$(ENABLE_PROMISES);$(ENABLE_REQUEST_ANIMATION_FRAME);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_ACCELERATED_OVERFLOW_SCROLLING);$(ENABLE_BLOB);$(ENABLE_CANVAS_PROXY);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CSS3_CONDITIONAL_RULES);$(ENABLE_CSS_IMAGE_SET);$(ENABLE_CSS3_TEXT);$(ENABLE_CSS_BOX_DECORATION_BREAK);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_GRID_LAYOUT);$(ENABLE_CSS_SHADERS);$(ENABLE_CSS_COMPOSITING);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_CSS_SHAPES);$(ENABLE_CSS_STICKY_POSITION);$(ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED);$(ENABLE_CUSTOM_SCHEME_HANDLER);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST_ELEMENT);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS_ELEMENT);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GAMEPAD);$(ENABLE_GEOLOCATION);$(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING);$(ENABLE_HIGH_DPI_CANVAS);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_TYPE_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_INPUT_TYPE_DATE);$(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE);$(ENABLE_INPUT_TYPE_DATETIMELOCAL);$(ENABLE_INPUT_TYPE_MONTH);$(ENABLE_INPUT_TYPE_TIME);$(ENABLE_INPUT_TYPE_WEEK);$(ENABLE_LEGACY_CSS_VENDOR_PREFIXES);$(ENABLE_LEGACY_NOTIFICATIONS);$(ENABLE_LINK_PREFETCH);$(ENABLE_LINK_PRERENDER);$(ENABLE_MATHML);$(ENABLE_METER_ELEMENT);$(ENABLE_MICRODATA);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_ELEMENT);$(ENABLE_PROXIMITY_EVENTS);$(ENABLE_QUOTA);$(ENABLE_NAVIGATOR_CONTENT_UTILS);$(ENABLE_SCRIPTED_SPEECH);$(ENABLE_SHADOW_DOM);$(ENABLE_SHARED_WORKERS);$(ENABLE_STYLE_SCOPED);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SUBPIXEL_LAYOUT);$(ENABLE_TEMPLATE_ELEMENT);$(ENABLE_TEXT_AUTOSIZING);$(ENABLE_VIDEO);$(ENABLE_VIDEO_TRACK);$(ENABLE_VIEW_MODE_CSS_MEDIA);$(ENABLE_MEDIA_CONTROLS_SCRIPT);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_XSLT);%(PreprocessorDefinitions)/PreprocessorDefinitions

[webkit-changes] [163910] branches/safari-537.60-branch/Tools

[rniwa]

Title: [163910] branches/safari-537.60-branch/Tools








Revision 163910
Author rn...@webkit.org
Date 2014-02-11 14:12:50 -0800 (Tue, 11 Feb 2014)


Log Message
Merge r160726

2013-12-17  Brent Fulgham  bfulg...@apple.com

[Win] Revise filter-build-webkit to deal with Windows build logs
https://bugs.webkit.org/show_bug.cgi?id=125866

Reviewed by David Kilzer.

Enhance the script to accept a 'platform' argument. When platform
'win' is provided, use processing for the Windows build file format.
Otherwise, process the files as normal.

* Scripts/filter-build-webkit:
(usageAndExit): Add a 'platform' argument
(shouldIgnoreLine): When platform == 'win' use the new Windows
rules for processing the build file.

Modified Paths

branches/safari-537.60-branch/Tools/ChangeLog
branches/safari-537.60-branch/Tools/Scripts/filter-build-webkit


Property Changed

branches/safari-537.60-branch/Tools/




Diff

Property changes: branches/safari-537.60-branch/Tools



Added: svn:mergeinfo

Modified: branches/safari-537.60-branch/Tools/ChangeLog (163909 => 163910)

--- branches/safari-537.60-branch/Tools/ChangeLog	2014-02-11 22:00:14 UTC (rev 163909)
+++ branches/safari-537.60-branch/Tools/ChangeLog	2014-02-11 22:12:50 UTC (rev 163910)
@@ -1,3 +1,23 @@
+2014-02-11  Ryosuke Niwa  rn...@webkit.org
+
+Merge r160726
+
+2013-12-17  Brent Fulgham  bfulg...@apple.com
+
+[Win] Revise filter-build-webkit to deal with Windows build logs
+https://bugs.webkit.org/show_bug.cgi?id=125866
+
+Reviewed by David Kilzer.
+
+Enhance the script to accept a 'platform' argument. When platform
+'win' is provided, use processing for the Windows build file format.
+Otherwise, process the files as normal.
+
+* Scripts/filter-build-webkit:
+(usageAndExit): Add a 'platform' argument
+(shouldIgnoreLine): When platform == 'win' use the new Windows
+rules for processing the build file.
+
 2013-11-04  Lucas Forschler  lforsch...@apple.com
 
 Merge r157995


Modified: branches/safari-537.60-branch/Tools/Scripts/filter-build-webkit (163909 => 163910)

--- branches/safari-537.60-branch/Tools/Scripts/filter-build-webkit	2014-02-11 22:00:14 UTC (rev 163909)
+++ branches/safari-537.60-branch/Tools/Scripts/filter-build-webkit	2014-02-11 22:12:50 UTC (rev 163910)
@@ -74,6 +74,7 @@
 
 # Global variables used only in global scope.
 my $outputPath = STDOUT;
+my $platform = mac;
 my $showHelp;
 
 # Global variables used in global and subroutine scope.
@@ -88,6 +89,7 @@
 Usage: @{[ basename($0) ]} [options] buildlog1 [buildlog2 ...]
build-webkit | @{[ basename($0) ]} [options]
   -h|--help Show this help message
+  -p|--platform Logfile type (default: $platform)
 Output Options:
   -o|--output   Path for output (default: STDOUT)
   -f|--format   Output format (default: $outputFormat)
@@ -104,6 +106,7 @@
 my $getOptionsResult = GetOptions(
 'h|help'= \$showHelp,
 'o|output=s'= \$outputPath,
+'p|platform=s'  = \$platform,
 'f|format=s'= \setOutputFormatOption,
 'color!'= \$useColor,
 'l|log' = \$logUnfilteredOutput,
@@ -139,7 +142,7 @@
 printLine($line, STYLE_PLAIN);
 } elsif ($line =~ /\*\* BUILD SUCCEEDED \*\*/) {
 printLine(Build Succeeded, STYLE_SUCCESS);
-} elsif ($line =~ /^(PhaseScriptExecution|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|ProcessProductPackaging|CodeSign|SymLink|Updating|CompileXIB|StripNIB|CopyPlistFile|GenerateDSYMFile) ([^]+|\S+)?/) {
+} elsif ($line =~ /^(PhaseScriptExecution|ClCompile|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|ProcessProductPackaging|CodeSign|SymLink|Updating|CompileXIB|StripNIB|CopyPlistFile|GenerateDSYMFile) ([^]+|\S+)?/) {
 my ($command, $path) = ($1, basename($2));
 $path =~ s///g;
 printLine($command $path, STYLE_PLAIN);
@@ -156,7 +159,7 @@
 printLine($command $path, STYLE_PLAIN);
 } else {
 # This only gets hit if stderr is redirected to stdout.
-if ($line =~ /\*\* BUILD FAILED \*\*/) {
+if (($line =~ /\*\* BUILD FAILED \*\*/) || ($line =~ /^Build FAILED./)) {
 $buildFailed = 1;
 }
 printLine($line, $buildFinished ? STYLE_SUCCESS : STYLE_ALERT);
@@ -223,14 +226,34 @@
 return 1 if $line =~ /^_javascript_Core\/pcre\/dftables/;
 return 1 if $line =~ /^Creating hashtable for /;
 return 1 if $line =~ /^Wrote output to /;
-return 1 if $line =~ /^(touch|perl|cat|rm 

[webkit-changes] [163911] trunk/LayoutTests

[rego]

Title: [163911] trunk/LayoutTests








Revision 163911
Author r...@igalia.com
Date 2014-02-11 14:56:25 -0800 (Tue, 11 Feb 2014)


Log Message
Unreviewed. Fix typo in layout test introduced in r163811.

Patch by Diego Pino Garcia dp...@igalia.com on 2014-02-11

* inspector-protocol/debugger/hit-breakpoint-from-console.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163910 => 163911)

--- trunk/LayoutTests/ChangeLog	2014-02-11 22:12:50 UTC (rev 163910)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 22:56:25 UTC (rev 163911)
@@ -1,3 +1,9 @@
+2014-02-11  Diego Pino Garcia  dp...@igalia.com
+
+Unreviewed. Fix typo in layout test introduced in r163811.
+
+* inspector-protocol/debugger/hit-breakpoint-from-console.html:
+
 2014-02-11  Samuel White  samuel_wh...@apple.com
 
 AX: Add text replacement activity support to NSAccessibilitySelectTextWithCriteriaParameterizedAttribute.


Modified: trunk/LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console.html (163910 => 163911)

--- trunk/LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console.html	2014-02-11 22:12:50 UTC (rev 163910)
+++ trunk/LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console.html	2014-02-11 22:56:25 UTC (rev 163911)
@@ -20,7 +20,7 @@
 InspectorTest.checkForError(responseObject);
 // Should NOT hit breakpoint (a  10).
 InspectorTest.sendCommand(Runtime.evaluate, {_expression_: breakpointActions(2, {x:1,y:2})});
-// Shoul hit breakpoint (a  10).
+// Should hit breakpoint (a  10).
 InspectorTest.sendCommand(Runtime.evaluate, {_expression_: breakpointActions(12, {x:1,y:2})});
 });
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163913] trunk/Tools

[joepeck]

Title: [163913] trunk/Tools








Revision 163913
Author joep...@webkit.org
Date 2014-02-11 15:05:06 -0800 (Tue, 11 Feb 2014)


Log Message
Web Inspector: AX: Accessibility Node Inspection
https://bugs.webkit.org/show_bug.cgi?id=127447

Patch by James Craig jcr...@apple.com on 2014-02-11
Reviewed by Chris Fleizach.

Resolving build failure caused by r163891.

* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::computedRoleString):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm




Diff

Modified: trunk/Tools/ChangeLog (163912 => 163913)

--- trunk/Tools/ChangeLog	2014-02-11 23:01:09 UTC (rev 163912)
+++ trunk/Tools/ChangeLog	2014-02-11 23:05:06 UTC (rev 163913)
@@ -1,3 +1,15 @@
+2014-02-11  James Craig  jcr...@apple.com
+
+Web Inspector: AX: Accessibility Node Inspection
+https://bugs.webkit.org/show_bug.cgi?id=127447
+
+Reviewed by Chris Fleizach.
+
+Resolving build failure caused by r163891.
+
+* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
+(WTR::AccessibilityUIElement::computedRoleString):
+
 2014-02-11  Alex Christensen  achristen...@webkit.org
 
 Fixed pointer truncation on Win64.


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm (163912 => 163913)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm	2014-02-11 23:01:09 UTC (rev 163912)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm	2014-02-11 23:05:06 UTC (rev 163913)
@@ -253,7 +253,7 @@
 return JSStringCreateWithCharacters(0, 0);
 }
 
-JSStringRef AccessibilityUIElement::computedRoleString()
+JSRetainPtrJSStringRef AccessibilityUIElement::computedRoleString()
 {
 // FIXME: implement
 return JSStringCreateWithCharacters(0, 0);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163914] trunk

[jpfau]

Title: [163914] trunk








Revision 163914
Author jp...@apple.com
Date 2014-02-11 15:07:49 -0800 (Tue, 11 Feb 2014)


Log Message
Bring third-party app cache blocking behavior in line with private browsing app cache blocking behavior
https://bugs.webkit.org/show_bug.cgi?id=128557

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::cacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
(WebCore::ApplicationCacheGroup::update):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadMainResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError):
(WebCore::ApplicationCacheHost::maybeLoadResource):
(WebCore::ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::isApplicationCacheBlockedForRequest):
* loader/appcache/ApplicationCacheHost.h:

LayoutTests:

* http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html:
* http/tests/security/resources/cross-origin-iframe-for-appcache.html:
* http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html
trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache.html
trunk/LayoutTests/http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.cpp
trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.h




Diff

Modified: trunk/LayoutTests/ChangeLog (163913 => 163914)

--- trunk/LayoutTests/ChangeLog	2014-02-11 23:05:06 UTC (rev 163913)
+++ trunk/LayoutTests/ChangeLog	2014-02-11 23:07:49 UTC (rev 163914)
@@ -1,3 +1,14 @@
+2014-02-10  Jeffrey Pfau  jp...@apple.com
+
+Bring third-party app cache blocking behavior in line with private browsing app cache blocking behavior
+https://bugs.webkit.org/show_bug.cgi?id=128557
+
+Reviewed by Alexey Proskuryakov.
+
+* http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html:
+* http/tests/security/resources/cross-origin-iframe-for-appcache.html:
+* http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html:
+
 2014-02-11  Brady Eidson  beid...@apple.com
 
 IDB: The test after storage/indexeddb/mozilla/object-identity.html fails in cleanup code


Modified: trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html (163913 => 163914)

--- trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html	2014-02-11 23:05:06 UTC (rev 163913)
+++ trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html	2014-02-11 23:07:49 UTC (rev 163914)
@@ -6,25 +6,19 @@
 	cleanup();
 }
 
-function timedOut() {
-	try {
-		applicationCache.update();
-		timer = setTimeout(cleanup, 5000);
-	} catch (e) {
-		document.write('Cache not found');
-		cleanup();
-	}
+function error() {
+	document.write('Cache not found');
+	cleanup();
 }
 
 function cleanup() {
-	clearTimeout(timer);
 	top.postMessage('done', '*');
 }
 
 try {
-	timer = setTimeout(timedOut, 5000);
 	applicationCache.addEventListener('noupdate', complete, false);
 	applicationCache.addEventListener('cached', complete, false);
+	applicationCache.addEventListener('error', error, false);
 } catch (e) {
 	document.write('Cache not found');
 	cleanup();


Modified: trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache.html (163913 => 163914)

--- trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache.html	2014-02-11 23:05:06 UTC (rev 163913)
+++ trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-appcache.html	2014-02-11 23:07:49 UTC (rev 163914)
@@ -6,25 +6,19 @@
 	cleanup();
 }
 
-function timedOut() {
-	try {
-		applicationCache.update();
-		timer = setTimeout(cleanup, 5000);
-	} catch (e) {
-		document.write('Cache not found');
-		cleanup();
-	}
+function error() {
+	document.write('Cache not found');
+	cleanup();
 }
 
 function cleanup() {
-	clearTimeout(timer);
 	top.postMessage('done', '*');
 }
 
 try {
-	timer = setTimeout(timedOut, 5000);
 	applicationCache.addEventListener('noupdate', complete, false);
 	applicationCache.addEventListener('cached', complete, false);
+	applicationCache.addEventListener('error', error, false);
 } catch (e) {
 	document.write('Cache not found');
 	cleanup();


Modified: trunk/LayoutTests/http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html (163913 => 163914)

--- 

[webkit-changes] [163915] trunk

[commit-queue]

Title: [163915] trunk








Revision 163915
Author commit-qu...@webkit.org
Date 2014-02-11 16:02:31 -0800 (Tue, 11 Feb 2014)


Log Message
XMLHttpRequest should not send DNT header
https://bugs.webkit.org/show_bug.cgi?id=128533

Patch by Youenn Fablet youe...@gmail.com on 2014-02-11
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Added DNT (Do Not Track) header to the list of forbidden headers.
Updated http/tests/xmlhttprequest/set-dangerous-headers.html to test that header.

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):

LayoutTests:

Updated http/tests/xmlhttprequest/set-dangerous-headers.html to test that DNT header is not sent.

* http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
* http/tests/xmlhttprequest/set-dangerous-headers.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt
trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (163914 => 163915)

--- trunk/LayoutTests/ChangeLog	2014-02-11 23:07:49 UTC (rev 163914)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 00:02:31 UTC (rev 163915)
@@ -1,3 +1,15 @@
+2014-02-11  Youenn Fablet  youe...@gmail.com
+
+XMLHttpRequest should not send DNT header
+https://bugs.webkit.org/show_bug.cgi?id=128533
+
+Reviewed by Alexey Proskuryakov.
+
+Updated http/tests/xmlhttprequest/set-dangerous-headers.html to test that DNT header is not sent.
+
+* http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
+* http/tests/xmlhttprequest/set-dangerous-headers.html:
+
 2014-02-10  Jeffrey Pfau  jp...@apple.com
 
 Bring third-party app cache blocking behavior in line with private browsing app cache blocking behavior


Modified: trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt (163914 => 163915)

--- trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt	2014-02-11 23:07:49 UTC (rev 163914)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt	2014-02-12 00:02:31 UTC (rev 163915)
@@ -8,6 +8,7 @@
 CONSOLE MESSAGE: Refused to set unsafe header COOKIE
 CONSOLE MESSAGE: Refused to set unsafe header COOKIE2
 CONSOLE MESSAGE: Refused to set unsafe header DATE
+CONSOLE MESSAGE: Refused to set unsafe header DNT
 CONSOLE MESSAGE: Refused to set unsafe header EXPECT
 CONSOLE MESSAGE: Refused to set unsafe header HOST
 CONSOLE MESSAGE: Refused to set unsafe header KEEP-ALIVE


Modified: trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html (163914 => 163915)

--- trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html	2014-02-11 23:07:49 UTC (rev 163914)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers.html	2014-02-12 00:02:31 UTC (rev 163915)
@@ -24,6 +24,7 @@
 req.setRequestHeader(COOKIE, foobar);
 req.setRequestHeader(COOKIE2, foobar);
 req.setRequestHeader(DATE, foobar);
+req.setRequestHeader(DNT, foobar);
 req.setRequestHeader(EXPECT, 100-continue);
 req.setRequestHeader(HOST, foobar);
 req.setRequestHeader(KEEP-ALIVE, foobar);


Modified: trunk/Source/WebCore/ChangeLog (163914 => 163915)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 23:07:49 UTC (rev 163914)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 00:02:31 UTC (rev 163915)
@@ -1,3 +1,16 @@
+2014-02-11  Youenn Fablet  youe...@gmail.com
+
+XMLHttpRequest should not send DNT header
+https://bugs.webkit.org/show_bug.cgi?id=128533
+
+Reviewed by Alexey Proskuryakov.
+
+Added DNT (Do Not Track) header to the list of forbidden headers.
+Updated http/tests/xmlhttprequest/set-dangerous-headers.html to test that header.
+
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
+
 2014-02-10  Jeffrey Pfau  jp...@apple.com
 
 Bring third-party app cache blocking behavior in line with private browsing app cache blocking behavior


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (163914 => 163915)

--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2014-02-11 23:07:49 UTC (rev 163914)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2014-02-12 00:02:31 UTC (rev 163915)
@@ -102,6 +102,7 @@
 cookie,
 cookie2,
 date,
+dnt,
 expect,
 host,
 keep-alive,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163916] trunk

[mmaxfield]

Title: [163916] trunk








Revision 163916
Author mmaxfi...@apple.com
Date 2014-02-11 16:06:01 -0800 (Tue, 11 Feb 2014)


Log Message
Source/WebCore: Convert position:fixed property to position:absolute upon copy
https://bugs.webkit.org/show_bug.cgi?id=128194

Reviewed by Simon Fraser.

This adds a Setting and Preference that allows clients to opt-in to this behavior.

This new behavior is only activated if the entire body is copied. If there is a position:fixed
element in the copied selection, it is replaced with position:absolute, and a containing
block (position:relative) is wrapped around the copied text.

This patch originally converted position:-webkit-sticky to position:relative. However, we
currently don't support copying and pasting of position:-webkit-sticky content (See below).
Therefore, this patch only deals with position:fixed.

Right now we don't copy position:-webkit-sticky. This is because:
1. When copying styled elements, we parse the style properties again
2. CSSParserContext has a flag which can disable parsing -webkit-sticky
3. There are two constructors to CSSParserContext: one that takes a document and sets up the
aforementioned flag, and a simple one that doesn't take a document and sets all the enableFoo
flags to false
4. At the relevant place within copy code, we are far removed from the Document object, so we
instead call the second constructor, thereby disabling parsing of -webkit-sticky

Test: editing/pasteboard/copy-paste-converts-sticky-and-fixed.html

* WebCore.exp.in: Export the Setting setter
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::convertFixedAndStickyPosition): Converts a single style
* editing/EditingStyle.h:
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Remember if we found
an element which needs the position:relative containing block
(WebCore::StyledMarkupAccumulator::appendElement): Surround with the position:relative
containing block if necessary
(WebCore::createMarkupInternal):
* page/Settings.cpp:
(WebCore::Settings::Settings): New setting to opt-in to this new behavior
(WebCore::Settings::setConvertPositionStyleOnCopy):
* page/Settings.h:
(WebCore::Settings::convertPositionStyleOnCopy):
* testing/InternalSettings.cpp: Allow setting the setting from a Layout Test
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setConvertPositionStyleOnCopy):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit/mac: Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
https://bugs.webkit.org/show_bug.cgi?id=128194

Reviewed by Simon Fraser.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences convertPositionStyleOnCopy]):
(-[WebPreferences setConvertPositionStyleOnCopy:]):
* WebView/WebPreferencesPrivate.h: Opt-in to new behavior
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2: Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
https://bugs.webkit.org/show_bug.cgi?id=128194

Reviewed by Simon Fraser.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetConvertPositionStyleOnCopy):
(WKPreferencesGetConvertPositionStyleOnCopy):
* UIProcess/API/C/WKPreferencesPrivate.h: Opt-in to new behavior
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

LayoutTests: Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
https://bugs.webkit.org/show_bug.cgi?id=128194

Reviewed by Simon Fraser.

Checks that the style properties get converted.

* editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt: Added.
* editing/pasteboard/copy-paste-converts-sticky-and-fixed.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Source/WebCore/editing/EditingStyle.h
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp


Added Paths

trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt
trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-and-fixed.html




Diff

Modified: trunk/LayoutTests/ChangeLog 

[webkit-changes] [163917] trunk/Source/WebCore

[akling]

Title: [163917] trunk/Source/WebCore








Revision 163917
Author akl...@apple.com
Date 2014-02-11 16:08:16 -0800 (Tue, 11 Feb 2014)


Log Message
CTTE: RenderNamedFlowThread always has a WebKitNamedFlow.
https://webkit.org/b/128623

Codify the fact that RenderNamedFlowThread always has a corresponding
WebKitNamedFlow by storing it in a Ref, and adding an accessor that
returns a reference to get rid of all the -'s.

Also removed some unnecessary assertions exposed by this.

Reviewed by Antti Koivisto.

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
* dom/NamedFlowCollection.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::flowThreadName):
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
(WebCore::RenderNamedFlowThread::setMarkForDestruction):
(WebCore::RenderNamedFlowThread::resetMarkForDestruction):
(WebCore::RenderNamedFlowThread::isMarkedForDestruction):
* rendering/RenderNamedFlowThread.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/NamedFlowCollection.cpp
trunk/Source/WebCore/dom/NamedFlowCollection.h
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163916 => 163917)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 00:06:01 UTC (rev 163916)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 00:08:16 UTC (rev 163917)
@@ -1,3 +1,33 @@
+2014-02-11  Andreas Kling  akl...@apple.com
+
+CTTE: RenderNamedFlowThread always has a WebKitNamedFlow.
+https://webkit.org/b/128623
+
+Codify the fact that RenderNamedFlowThread always has a corresponding
+WebKitNamedFlow by storing it in a Ref, and adding an accessor that
+returns a reference to get rid of all the -'s.
+
+Also removed some unnecessary assertions exposed by this.
+
+Reviewed by Antti Koivisto.
+
+* dom/NamedFlowCollection.cpp:
+(WebCore::NamedFlowCollection::ensureFlowWithName):
+* dom/NamedFlowCollection.h:
+* rendering/RenderNamedFlowThread.cpp:
+(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
+(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
+(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
+(WebCore::RenderNamedFlowThread::flowThreadName):
+(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
+(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
+(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired):
+(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
+(WebCore::RenderNamedFlowThread::setMarkForDestruction):
+(WebCore::RenderNamedFlowThread::resetMarkForDestruction):
+(WebCore::RenderNamedFlowThread::isMarkedForDestruction):
+* rendering/RenderNamedFlowThread.h:
+
 2014-02-10  Myles C. Maxfield  mmaxfi...@apple.com
 
 Convert position:fixed property to position:absolute upon copy


Modified: trunk/Source/WebCore/dom/NamedFlowCollection.cpp (163916 => 163917)

--- trunk/Source/WebCore/dom/NamedFlowCollection.cpp	2014-02-12 00:06:01 UTC (rev 163916)
+++ trunk/Source/WebCore/dom/NamedFlowCollection.cpp	2014-02-12 00:08:16 UTC (rev 163917)
@@ -66,14 +66,14 @@
 return *it;
 }
 
-PassRefPtrWebKitNamedFlow NamedFlowCollection::ensureFlowWithName(const String flowName)
+PassRefWebKitNamedFlow NamedFlowCollection::ensureFlowWithName(const String flowName)
 {
 NamedFlowSet::iterator it = m_namedFlows.findString, NamedFlowHashTranslator(flowName);
 if (it != m_namedFlows.end()) {
 WebKitNamedFlow* namedFlow = *it;
 ASSERT(namedFlow-flowState() == WebKitNamedFlow::FlowStateNull);
 
-return namedFlow;
+return *namedFlow;
 }
 
 RefPtrWebKitNamedFlow newFlow = WebKitNamedFlow::create(this, flowName);
@@ -81,7 +81,7 @@
 
 InspectorInstrumentation::didCreateNamedFlow(document(), newFlow.get());
 
-return newFlow.release();
+return newFlow.releaseNonNull();
 }
 
 void NamedFlowCollection::discardNamedFlow(WebKitNamedFlow* namedFlow)


Modified: trunk/Source/WebCore/dom/NamedFlowCollection.h (163916 => 163917)

--- trunk/Source/WebCore/dom/NamedFlowCollection.h	2014-02-12 00:06:01 UTC (rev 163916)
+++ trunk/Source/WebCore/dom/NamedFlowCollection.h	2014-02-12 00:08:16 UTC (rev 163917)
@@ -49,7 +49,7 @@
 
 VectorRefPtrWebKitNamedFlow namedFlows();
 WebKitNamedFlow* flowByName(const String);
-

[webkit-changes] [163919] trunk/Source

[enrica]

Title: [163919] trunk/Source








Revision 163919
Author enr...@apple.com
Date 2014-02-11 17:10:21 -0800 (Tue, 11 Feb 2014)


Log Message
Support WebSelections in WK2 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=127015
rdar://problem/15211964

Reviewed by Benjamin Poulain.

Source/WebCore: 

Adding few exports.

* WebCore.exp.in:

Source/WebKit2: 

First step towards implementing block selections on iOS.
The main logic is in rangeForWebSelectionAtPosition that
decides whether we create a text or a block selection.

* Shared/ios/WKGestureTypes.h:
* UIProcess/API/ios/WKInteractionView.mm:
(toUIWKSelectionFlags):
(selectionChangedWithGesture):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::getPositionInformation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/ios/WKGestureTypes.h
trunk/Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (163918 => 163919)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 00:22:01 UTC (rev 163918)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 01:10:21 UTC (rev 163919)
@@ -1,3 +1,15 @@
+2014-02-11  Enrica Casucci  enr...@apple.com
+
+Support WebSelections in WK2 on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=127015
+rdar://problem/15211964
+
+Reviewed by Benjamin Poulain.
+
+Adding few exports.
+
+* WebCore.exp.in:
+
 2014-02-11  Andreas Kling  akl...@apple.com
 
 CTTE: RenderNamedFlowThread always has a WebKitNamedFlow.


Modified: trunk/Source/WebCore/WebCore.exp.in (163918 => 163919)

--- trunk/Source/WebCore/WebCore.exp.in	2014-02-12 00:22:01 UTC (rev 163918)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-02-12 01:10:21 UTC (rev 163919)
@@ -1421,6 +1421,7 @@
 __ZN7WebCore10Pasteboard21createForCopyAndPasteEv
 __ZN7WebCore10TimeRanges13intersectWithEPKS0_
 __ZN7WebCore10TimeRangesC1Edd
+__ZN7WebCore13SelectionRectC1ERKNS_7IntRectEbi
 __ZNK3JSC8Bindings10RootObject12globalObjectEv
 __ZNK3WTF6String14createCFStringEv
 __ZNK7WebCore10Credential11hasPasswordEv
@@ -1487,6 +1488,7 @@
 __ZNK7WebCore11HistoryItem8referrerEv
 __ZNK7WebCore11HistoryItem9urlStringEv
 __ZNK7WebCore11HistoryItem9viewStateEv
+__ZNK7WebCore11RenderBlock25inlineElementContinuationEv
 __ZNK7WebCore11RenderLayer19absoluteBoundingBoxEv
 __ZNK7WebCore11RenderLayer24needsCompositedScrollingEv
 __ZNK7WebCore11RenderStyle11fontMetricsEv
@@ -1751,6 +1753,7 @@
 __ZNK7WebCore5Range9firstNodeEv
 __ZNK7WebCore5Range9textQuadsERN3WTF6VectorINS_9FloatQuadELm0ENS1_15CrashOnOverflowEEEbPNS0_20RangeInFixedPositionE
 __ZNK7WebCore5Range9textRectsERN3WTF6VectorINS_7IntRectELm0ENS1_15CrashOnOverflowEEEbPNS0_20RangeInFixedPositionE
+__ZNK7WebCore5Range23commonAncestorContainerERi
 __ZNK7WebCore6Chrome12createWindowEPNS_5FrameERKNS_16FrameLoadRequestERKNS_14WindowFeaturesERKNS_16NavigationActionE
 __ZNK7WebCore6Editor12selectedTextEv
 __ZNK7WebCore6Editor13canEditRichlyEv


Modified: trunk/Source/WebKit2/ChangeLog (163918 => 163919)

--- trunk/Source/WebKit2/ChangeLog	2014-02-12 00:22:01 UTC (rev 163918)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-12 01:10:21 UTC (rev 163919)
@@ -1,3 +1,25 @@
+2014-02-11  Enrica Casucci  enr...@apple.com
+
+Support WebSelections in WK2 on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=127015
+rdar://problem/15211964
+
+Reviewed by Benjamin Poulain.
+
+First step towards implementing block selections on iOS.
+The main logic is in rangeForWebSelectionAtPosition that
+decides whether we create a text or a block selection.
+
+* Shared/ios/WKGestureTypes.h:
+* UIProcess/API/ios/WKInteractionView.mm:
+(toUIWKSelectionFlags):
+(selectionChangedWithGesture):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::rangeForWebSelectionAtPosition):
+(WebKit::WebPage::selectWithGesture):
+(WebKit::WebPage::getPositionInformation):
+
 2014-02-10  Myles C. Maxfield  mmaxfi...@apple.com
 
 Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy


Modified: trunk/Source/WebKit2/Shared/ios/WKGestureTypes.h (163918 => 163919)

--- trunk/Source/WebKit2/Shared/ios/WKGestureTypes.h	2014-02-12 00:22:01 UTC (rev 163918)
+++ trunk/Source/WebKit2/Shared/ios/WKGestureTypes.h	2014-02-12 01:10:21 UTC (rev 163919)
@@ -69,6 +69,12 @@
 WKSheetActionSaveImage
 } WKSheetActions;
 
+typedef enum {
+WKNone = 0,
+WKWordIsNearTap = 1,
+WKIsBlockSelection = 2
+} WKSelectionFlags;
+
 } // namespace WebKit
 
 #endif // WKGestureTypes_h


Modified: 

[webkit-changes] [163920] trunk/Source

[rniwa]

Title: [163920] trunk/Source








Revision 163920
Author rn...@webkit.org
Date 2014-02-11 17:53:03 -0800 (Tue, 11 Feb 2014)


Log Message
Frame::rectForSelection shouldn't instantiate FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=128587

Reviewed by Enrica Casucci.

Source/WebCore: 

Made VisiblePosition::absoluteCaretBounds more interoperable with the one in FrameSelection and made
iOS's Frame::rectForScrollToVisible use that function instead.

The above change allows us to remove:
- suppressCloseTyping(), restoreCloseTyping(), and m_closeTypingSuppressions in FrameSelection
- suppressSelectionNotifications() and restoreSelectionNotifications() in EditorClient

See inline comments below for more details.

* Source/WebCore/WebCore.exp.in:

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::CaretBase::updateCaretRect):
(WebCore::FrameSelection::caretRendererWithoutUpdatingLayout):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect): Merged FrameSelection::localCaretRect(). Modified
the code to update caretNode when and only when caret rect is updated. Also added an assertion to
ensure absoluteCaretBounds() on FrameSelection and VisiblePosition yield the same result.

(WebCore::CaretBase::paintCaret):
* editing/FrameSelection.h:

* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::absoluteCaretBounds): Fixed the bug where the old code wasn't respecting
the convention to use containing block as the renderer to paint caret.

* editing/htmlediting.cpp:
(WebCore::caretRendersInsideNode): Moved from FrameSelection.cpp.
(WebCore::rendererForCaretPainting): Ditto and renamed from caretRenderer.
(WebCore::localCaretRectInRendererForCaretPainting): Extracted from FrameSelection::updateCaretRect.
(WebCore::absoluteBoundsForLocalCaretRect): Ditto from CaretBase::absoluteBoundsForLocalRect.
* editing/htmlediting.h:

* loader/EmptyClients.h:
* page/EditorClient.h:
* page/Frame.h:

* page/ios/FrameIOS.mm:
(WebCore::Frame::rectForScrollToVisible): Reimplemented in its simplest form using VisiblePosition's
absoluteCaretBounds().

Source/WebKit/mac: 

* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient):
(WebEditorClient::respondToChangedSelection):

Source/WebKit2: 

* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/FrameSelection.h
trunk/Source/WebCore/editing/VisiblePosition.cpp
trunk/Source/WebCore/editing/htmlediting.cpp
trunk/Source/WebCore/editing/htmlediting.h
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/page/EditorClient.h
trunk/Source/WebCore/page/Frame.h
trunk/Source/WebCore/page/ios/FrameIOS.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (163919 => 163920)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 01:10:21 UTC (rev 163919)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 01:53:03 UTC (rev 163920)
@@ -1,3 +1,54 @@
+2014-02-11  Ryosuke Niwa  rn...@webkit.org
+
+Frame::rectForSelection shouldn't instantiate FrameSelection
+https://bugs.webkit.org/show_bug.cgi?id=128587
+
+Reviewed by Enrica Casucci.
+
+Made VisiblePosition::absoluteCaretBounds more interoperable with the one in FrameSelection and made
+iOS's Frame::rectForScrollToVisible use that function instead.
+
+The above change allows us to remove:
+- suppressCloseTyping(), restoreCloseTyping(), and m_closeTypingSuppressions in FrameSelection
+- suppressSelectionNotifications() and restoreSelectionNotifications() in EditorClient
+
+See inline comments below for more details.
+
+* Source/WebCore/WebCore.exp.in:
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::FrameSelection):
+(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
+(WebCore::CaretBase::updateCaretRect):
+(WebCore::FrameSelection::caretRendererWithoutUpdatingLayout):
+(WebCore::DragCaretController::caretRenderer):
+(WebCore::repaintCaretForLocalRect):
+(WebCore::FrameSelection::recomputeCaretRect): Merged FrameSelection::localCaretRect(). Modified
+the code to update caretNode when and only when caret rect is updated. Also added an assertion to
+ensure absoluteCaretBounds() on FrameSelection and VisiblePosition yield the 

[webkit-changes] [163921] trunk

[mmaxfield]

Title: [163921] trunk








Revision 163921
Author mmaxfi...@apple.com
Date 2014-02-11 17:54:19 -0800 (Tue, 11 Feb 2014)


Log Message
Position and thickness of underline as text size changes
https://bugs.webkit.org/show_bug.cgi?id=16768

Source/WebCore:

Reviewed by Dean Jackson.

This patch adopts the iOS codepath for underlines. It also reorganizes
drawLineForText to avoid a costly global state save  restore.

Test: fast/css3-text/css3-text-decoration/text-decoration-thickness.html

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::computeLineBoundsAndAntialiasingModeForText):
(WebCore::GraphicsContext::computeLineBoundsForText):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLinesForText):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

This test draws underlined text at a very large font size. It then positions and clips
the text so that the underline should fill a box if the underline grows in proportion
to text size. The comparison is to a box that has its background color set.

Reviewed by Dean Jackson.

* fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html: Added.
* fast/css3-text/css3-text-decoration/text-decoration-thickness.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/rendering/InlineTextBox.cpp


Added Paths

trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html
trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163920 => 163921)

--- trunk/LayoutTests/ChangeLog	2014-02-12 01:53:03 UTC (rev 163920)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 01:54:19 UTC (rev 163921)
@@ -1,3 +1,17 @@
+2014-02-11  Myles C. Maxfield  mmaxfi...@apple.com
+
+Position and thickness of underline as text size changes
+https://bugs.webkit.org/show_bug.cgi?id=16768
+
+This test draws underlined text at a very large font size. It then positions and clips
+the text so that the underline should fill a box if the underline grows in proportion
+to text size. The comparison is to a box that has its background color set.
+
+Reviewed by Dean Jackson.
+
+* fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html: Added.
+* fast/css3-text/css3-text-decoration/text-decoration-thickness.html: Added.
+
 2014-02-10  Myles C. Maxfield  mmaxfi...@apple.com
 
 Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy


Added: trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html (0 => 163921)

--- trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html	2014-02-12 01:54:19 UTC (rev 163921)
@@ -0,0 +1,14 @@
+!DOCTYPE html
+html
+head
+style
+/style
+/head
+body
+This test draws underlined text at a very large font size. It then positions and clips
+the text so that the underline should fill a box if the underline grows in proportion
+to text size. The comparison is to a box that has its background color set.
+div style=position: relative; width: 600px; height: 600px; background: #000
+/div
+/body
+/html


Added: trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness.html (0 => 163921)

--- trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness.html	(rev 0)
+++ trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness.html	2014-02-12 01:54:19 UTC (rev 163921)
@@ -0,0 +1,13 @@
+!DOCTYPE html
+html
+head
+/head
+body
+This test draws underlined text at a very large font size. It then positions and clips
+the text so that the underline should fill a box if the underline grows in proportion
+to text size. The comparison is to a box that has its background color set.
+div style=position: relative; width: 600px; height: 600px; overflow: hidden;
+div style=font-family: Ahem; text-decoration: underline; font-size: 1px; position: absolute; left: 0px; top: -8650px;nbsp;/div
+/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (163920 => 163921)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 01:53:03 UTC (rev 163920)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 01:54:19 UTC (rev 163921)
@@ -1,3 +1,23 @@
+2014-02-11  Myles C. Maxfield  mmaxfi...@apple.com
+
+Position and thickness of underline as text size changes
+https://bugs.webkit.org/show_bug.cgi?id=16768
+
+Reviewed by Dean Jackson.
+
+This patch adopts the iOS codepath for underlines. It also reorganizes
+drawLineForText to avoid a costly global state save  

[webkit-changes] [163922] trunk/Source/WebCore

[akling]

Title: [163922] trunk/Source/WebCore








Revision 163922
Author akl...@apple.com
Date 2014-02-11 17:55:40 -0800 (Tue, 11 Feb 2014)


Log Message
Move renderNamedFlowThreadWrapper() to RenderElement.
https://webkit.org/b/128634

This function is only ever called on RenderElements so move it there
from RenderObject.

Reviewed by Antti Koivisto.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::renderNamedFlowThreadWrapper):
* rendering/RenderElement.h:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163921 => 163922)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 01:54:19 UTC (rev 163921)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 01:55:40 UTC (rev 163922)
@@ -1,3 +1,19 @@
+2014-02-11  Andreas Kling  akl...@apple.com
+
+Move renderNamedFlowThreadWrapper() to RenderElement.
+https://webkit.org/b/128634
+
+This function is only ever called on RenderElements so move it there
+from RenderObject.
+
+Reviewed by Antti Koivisto.
+
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::renderNamedFlowThreadWrapper):
+* rendering/RenderElement.h:
+* rendering/RenderObject.cpp:
+* rendering/RenderObject.h:
+
 2014-02-11  Myles C. Maxfield  mmaxfi...@apple.com
 
 Position and thickness of underline as text size changes


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (163921 => 163922)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 01:54:19 UTC (rev 163921)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 01:55:40 UTC (rev 163922)
@@ -44,6 +44,7 @@
 #include RenderLayerCompositor.h
 #include RenderLineBreak.h
 #include RenderListItem.h
+#include RenderNamedFlowThread.h
 #include RenderRegion.h
 #include RenderRuby.h
 #include RenderRubyText.h
@@ -1274,4 +1275,12 @@
 return borderImage  borderImage-canRender(this, style().effectiveZoom())  borderImage-isLoaded();
 }
 
+RenderNamedFlowThread* RenderElement::renderNamedFlowThreadWrapper()
+{
+auto renderer = this;
+while (renderer  renderer-isAnonymousBlock()  !renderer-isRenderNamedFlowThread())
+renderer = renderer-parent();
+return renderer  renderer-isRenderNamedFlowThread() ? toRenderNamedFlowThread(renderer) : nullptr;
 }
+
+}


Modified: trunk/Source/WebCore/rendering/RenderElement.h (163921 => 163922)

--- trunk/Source/WebCore/rendering/RenderElement.h	2014-02-12 01:54:19 UTC (rev 163921)
+++ trunk/Source/WebCore/rendering/RenderElement.h	2014-02-12 01:55:40 UTC (rev 163922)
@@ -141,6 +141,8 @@
 bool hasBlendMode() const { return false; }
 #endif
 
+RenderNamedFlowThread* renderNamedFlowThreadWrapper();
+
 protected:
 enum BaseTypeFlags {
 RenderLayerModelObjectFlag = 1  0,


Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (163921 => 163922)

--- trunk/Source/WebCore/rendering/RenderObject.cpp	2014-02-12 01:54:19 UTC (rev 163921)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2014-02-12 01:55:40 UTC (rev 163922)
@@ -538,15 +538,6 @@
 return 0;
 }
 
-RenderNamedFlowThread* RenderObject::renderNamedFlowThreadWrapper() const
-{
-RenderObject* object = const_castRenderObject*(this);
-while (object  object-isAnonymousBlock()  !object-isRenderNamedFlowThread())
-object = object-parent();
-
-return object  object-isRenderNamedFlowThread() ? toRenderNamedFlowThread(object) : 0;
-}
-
 RenderBlock* RenderObject::firstLineBlock() const
 {
 return 0;


Modified: trunk/Source/WebCore/rendering/RenderObject.h (163921 => 163922)

--- trunk/Source/WebCore/rendering/RenderObject.h	2014-02-12 01:54:19 UTC (rev 163921)
+++ trunk/Source/WebCore/rendering/RenderObject.h	2014-02-12 01:55:40 UTC (rev 163922)
@@ -217,8 +217,6 @@
 return locateFlowThreadContainingBlock();
 }
 
-RenderNamedFlowThread* renderNamedFlowThreadWrapper() const;
-
 // FIXME: The meaning of this function is unclear.
 virtual bool isEmpty() const { return !firstChildSlow(); }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163924] trunk/LayoutTests

[rniwa]

Title: [163924] trunk/LayoutTests








Revision 163924
Author rn...@webkit.org
Date 2014-02-11 17:57:46 -0800 (Tue, 11 Feb 2014)


Log Message
Add failing test expectations to asynchronous spellchecking tests.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163923 => 163924)

--- trunk/LayoutTests/ChangeLog	2014-02-12 01:56:01 UTC (rev 163923)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 01:57:46 UTC (rev 163924)
@@ -1,3 +1,9 @@
+2014-02-11  Ryosuke Niwa  rn...@webkit.org
+
+Add failing test expectations to asynchronous spellchecking tests.
+
+* platform/win/TestExpectations:
+
 2014-02-11  Brady Eidson  beid...@apple.com
 
 IDB: Reimport storage/indexeddb tests from Blink


Modified: trunk/LayoutTests/platform/win/TestExpectations (163923 => 163924)

--- trunk/LayoutTests/platform/win/TestExpectations	2014-02-12 01:56:01 UTC (rev 163923)
+++ trunk/LayoutTests/platform/win/TestExpectations	2014-02-12 01:57:46 UTC (rev 163924)
@@ -2447,18 +2447,26 @@
 media/W3C/video/events/event_canplaythrough.html
 
 # Spellchecker behavior tests.
-webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html
-webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html
-webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html
-webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html
-webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html
-webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html
-webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html
-webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html
-webkit.org/b/108370 editing/spelling/spellcheck-async-mutation.html
-webkit.org/b/108370 editing/spelling/spellcheck-async.html
-webkit.org/b/108370 editing/spelling/spellcheck-sequencenum.html
-webkit.org/b/108370 editing/style/iframe-onload-crash-mac.html
+webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ]
+webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spellcheck-async-mutation.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spellcheck-async.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spellcheck-sequencenum.html [ Failure ]
+webkit.org/b/108370 editing/style/iframe-onload-crash-mac.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spellcheck-attribute.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spellcheck-paste-continuous-disabled.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-attribute-at-child.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-attribute-change.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-backspace-between-lines.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-hasspellingmarker.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-linebreak.html [ Failure ]
+webkit.org/b/108370 editing/spelling/spelling-unified-emulation.html [ Failure ]
 
 # Disable document.register tests, ENABLE_CUSTOM_ELEMENT disabled
 fast/dom/custom






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163925] trunk/Source/WebCore

[akling]

Title: [163925] trunk/Source/WebCore








Revision 163925
Author akl...@apple.com
Date 2014-02-11 18:01:14 -0800 (Tue, 11 Feb 2014)


Log Message
Remove unused RenderNamedFlowThread::previousRendererForNode().
https://webkit.org/b/128637

Reviewed by Antti Koivisto.

* rendering/RenderNamedFlowThread.cpp:
* rendering/RenderNamedFlowThread.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163924 => 163925)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 01:57:46 UTC (rev 163924)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 02:01:14 UTC (rev 163925)
@@ -1,5 +1,15 @@
 2014-02-11  Andreas Kling  akl...@apple.com
 
+Remove unused RenderNamedFlowThread::previousRendererForNode().
+https://webkit.org/b/128637
+
+Reviewed by Antti Koivisto.
+
+* rendering/RenderNamedFlowThread.cpp:
+* rendering/RenderNamedFlowThread.h:
+
+2014-02-11  Andreas Kling  akl...@apple.com
+
 Move renderNamedFlowThreadWrapper() to RenderElement.
 https://webkit.org/b/128634
 


Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp (163924 => 163925)

--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp	2014-02-12 01:57:46 UTC (rev 163924)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp	2014-02-12 02:01:14 UTC (rev 163925)
@@ -111,27 +111,6 @@
 return 0;
 }
 
-RenderObject* RenderNamedFlowThread::previousRendererForNode(Node* node) const
-{
-if (m_flowThreadChildList-isEmpty())
-return 0;
-
-auto begin = m_flowThreadChildList-begin();
-auto end = m_flowThreadChildList-end();
-auto it = end;
-
-do {
---it;
-RenderObject* child = *it;
-ASSERT(child-node());
-unsigned short position = node-compareDocumentPosition(child-node());
-if (position  Node::DOCUMENT_POSITION_PRECEDING)
-return child;
-} while (it != begin);
-
-return 0;
-}
-
 void RenderNamedFlowThread::addFlowChild(RenderObject* newChild)
 {
 // The child list is used to sort the flow thread's children render objects 


Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.h (163924 => 163925)

--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.h	2014-02-12 01:57:46 UTC (rev 163924)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.h	2014-02-12 02:01:14 UTC (rev 163925)
@@ -53,7 +53,6 @@
 const RenderRegionList invalidRenderRegionList() const { return m_invalidRegionList; }
 
 RenderObject* nextRendererForNode(Node*) const;
-RenderObject* previousRendererForNode(Node*) const;
 
 void addFlowChild(RenderObject* newChild);
 void removeFlowChild(RenderObject*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163926] branches/safari-537.75-branch/Source/WebCore

[matthew_hanson]

Title: [163926] branches/safari-537.75-branch/Source/WebCore








Revision 163926
Author matthew_han...@apple.com
Date 2014-02-11 18:03:55 -0800 (Tue, 11 Feb 2014)


Log Message
Merge r161925.

Modified Paths

branches/safari-537.75-branch/Source/WebCore/ChangeLog
branches/safari-537.75-branch/Source/WebCore/editing/mac/EditorMac.mm




Diff

Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (163925 => 163926)

--- branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-02-12 02:01:14 UTC (rev 163925)
+++ branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-02-12 02:03:55 UTC (rev 163926)
@@ -1,5 +1,26 @@
 2014-02-11  Matthew Hanson  matthew_han...@apple.com
 
+Merge r161925.
+
+2014-01-13  Myles C. Maxfield  mmaxfi...@apple.com
+
+Highlighting password field then making a Sticky Note via Safari Services exposes password
+https://bugs.webkit.org/show_bug.cgi?id=126946
+
+Reviewed by Enrica Casucci.
+
+Using the Services menu has a slightly different codepath than Editor::copy() does. This
+patch duplicates the canCopy() check that Editor::copy() does.
+
+Testing is not possible because the Services menu is not accessible to our tests.
+
+* editing/mac/EditorMac.mm:
+(WebCore::Editor::stringSelectionForPasteboard):
+(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
+(WebCore::Editor::dataSelectionForPasteboard):
+
+2014-02-11  Matthew Hanson  matthew_han...@apple.com
+
 Merge r158739.
 
 2013-11-06  Ryosuke Niwa  rn...@webkit.org


Modified: branches/safari-537.75-branch/Source/WebCore/editing/mac/EditorMac.mm (163925 => 163926)

--- branches/safari-537.75-branch/Source/WebCore/editing/mac/EditorMac.mm	2014-02-12 02:01:14 UTC (rev 163925)
+++ branches/safari-537.75-branch/Source/WebCore/editing/mac/EditorMac.mm	2014-02-12 02:03:55 UTC (rev 163926)
@@ -278,6 +278,8 @@
 // This was left in a bad state when selectedTextForClipboard was added. Need to look over clients and fix this.
 String Editor::stringSelectionForPasteboard()
 {
+if (!canCopy())
+return ;
 String text = selectedText();
 text.replace(noBreakSpace, ' ');
 return text;
@@ -285,6 +287,8 @@
 
 String Editor::stringSelectionForPasteboardWithImageAltText()
 {
+if (!canCopy())
+return ;
 String text = selectedTextForClipboard();
 text.replace(noBreakSpace, ' ');
 return text;
@@ -292,6 +296,8 @@
 
 PassRefPtrSharedBuffer Editor::dataSelectionForPasteboard(const String pasteboardType)
 {
+if (!canCopy())
+return nullptr;
 return Pasteboard::getDataSelection(m_frame, pasteboardType);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163927] trunk/Source/WebInspectorUI

[bburg]

Title: [163927] trunk/Source/WebInspectorUI








Revision 163927
Author bb...@apple.com
Date 2014-02-11 18:52:19 -0800 (Tue, 11 Feb 2014)


Log Message
Web Inspector: DOMStorageView should listen for events from DOMStorageObject
https://bugs.webkit.org/show_bug.cgi?id=128620

Reviewed by Timothy Hatcher.

The storage manager used to have a map of DOMStorageViews and delivered events
directly to them. Instead, the DOMStorageObserver should use the manager to
find the appropriate DOMStorageObject and deliver events to it. DOMStorageView
learns about storage updates from DOMStorageObject events.

* UserInterface/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView): Add event listeners.
(WebInspector.DOMStorageContentView.prototype.reset): Renamed from update().
(WebInspector.DOMStorageContentView.prototype.itemsCleared): Take an event argument.
(WebInspector.DOMStorageContentView.prototype.itemRemoved): Take an event argument.
Use for..of when iterating over nodes.
(WebInspector.DOMStorageContentView.prototype.itemAdded): Take an event argument.
Use for..of when iterating over nodes.
(WebInspector.DOMStorageContentView.prototype.itemUpdated): Take an event argument.
Use for..of when iterating over nodes.
* UserInterface/DOMStorageObject.js:
(WebInspector.DOMStorageObject.prototype.removeItem): Moved.
(WebInspector.DOMStorageObject.prototype.setItem): Moved.
(WebInspector.DOMStorageObject.prototype.itemsCleared): Added.
(WebInspector.DOMStorageObject.prototype.itemRemoved): Added.
(WebInspector.DOMStorageObject.prototype.itemAdded): Added.
(WebInspector.DOMStorageObject.prototype.itemUpdated): Added.
* UserInterface/DOMStorageObserver.js: Look up and notify the associated model.
(WebInspector.DOMStorageObserver.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageObserver.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageObserver.prototype.domStorageItemAdded):
(WebInspector.DOMStorageObserver.prototype.domStorageItemUpdated):
* UserInterface/StorageManager.js: Remove view lookup code. Remove
direct calls to DOMStorageViews.
(WebInspector.StorageManager.prototype.itemsCleared):
(WebInspector.StorageManager.prototype.itemRemoved):
(WebInspector.StorageManager.prototype.itemAdded):
(WebInspector.StorageManager.prototype.itemUpdated):
(WebInspector.StorageManager.prototype.domStorageWasUpdated):
(WebInspector.StorageManager.prototype.inspectDOMStorage):
(WebInspector.StorageManager.prototype._domStorageForIdentifier):
(WebInspector.StorageManager.prototype._addDOMStorageIfNeeded):
(WebInspector.StorageManager.prototype._databaseForIdentifier):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/DOMStorageContentView.js
trunk/Source/WebInspectorUI/UserInterface/DOMStorageObject.js
trunk/Source/WebInspectorUI/UserInterface/DOMStorageObserver.js
trunk/Source/WebInspectorUI/UserInterface/StorageManager.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (163926 => 163927)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-02-12 02:03:55 UTC (rev 163926)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-02-12 02:52:19 UTC (rev 163927)
@@ -1,3 +1,49 @@
+2014-02-11  Brian Burg  bb...@apple.com
+
+Web Inspector: DOMStorageView should listen for events from DOMStorageObject
+https://bugs.webkit.org/show_bug.cgi?id=128620
+
+Reviewed by Timothy Hatcher.
+
+The storage manager used to have a map of DOMStorageViews and delivered events
+directly to them. Instead, the DOMStorageObserver should use the manager to
+find the appropriate DOMStorageObject and deliver events to it. DOMStorageView
+learns about storage updates from DOMStorageObject events.
+
+* UserInterface/DOMStorageContentView.js:
+(WebInspector.DOMStorageContentView): Add event listeners.
+(WebInspector.DOMStorageContentView.prototype.reset): Renamed from update().
+(WebInspector.DOMStorageContentView.prototype.itemsCleared): Take an event argument.
+(WebInspector.DOMStorageContentView.prototype.itemRemoved): Take an event argument.
+Use for..of when iterating over nodes.
+(WebInspector.DOMStorageContentView.prototype.itemAdded): Take an event argument.
+Use for..of when iterating over nodes.
+(WebInspector.DOMStorageContentView.prototype.itemUpdated): Take an event argument.
+Use for..of when iterating over nodes.
+* UserInterface/DOMStorageObject.js:
+(WebInspector.DOMStorageObject.prototype.removeItem): Moved.
+(WebInspector.DOMStorageObject.prototype.setItem): Moved.
+(WebInspector.DOMStorageObject.prototype.itemsCleared): Added.
+(WebInspector.DOMStorageObject.prototype.itemRemoved): Added.
+(WebInspector.DOMStorageObject.prototype.itemAdded): Added.
+(WebInspector.DOMStorageObject.prototype.itemUpdated): Added.
+* UserInterface/DOMStorageObserver.js: Look up and notify the associated 

[webkit-changes] [163928] trunk

[antti]

Title: [163928] trunk








Revision 163928
Author an...@apple.com
Date 2014-02-11 18:55:22 -0800 (Tue, 11 Feb 2014)


Log Message
GIF animations should be suspended when outside of viewport
https://bugs.webkit.org/show_bug.cgi?id=128632

Source/WebCore: 

Reviewed by Andreas Kling.

Animations are driven by the paint cycle. Speculative tiles keep animations outside the actual viewport going.

Pause animations when they are outside the viewport by not painting them.

Test: fast/repaint/no-animation-outside-viewport.html

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::animationAdvanced):

Call animation specific newImageAnimationFrameAvailable instead of the generic notifyObservers.

* loader/cache/CachedImage.h:

Removed now unnecessary resumeAnimatingImagesForLoader mechanism.
Remove unnecessary shouldPauseAnimation. Pausing is now always done when by avoiding repaint.

* loader/cache/CachedImageClient.h:
(WebCore::CachedImageClient::newImageAnimationFrameAvailable):
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):

Check if we have image animations to resume when scroll position changes.

* page/Page.cpp:
(WebCore::Page::resumeAnimatingImages):

Use the same mechanism when resuming background tabs etc.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::internalAdvanceAnimation):

Remove the shouldPauseAnimation test, always rely on pausing on invalidation.

* platform/graphics/ImageObserver.h:
* rendering/RenderBoxModelObject.cpp:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::~RenderElement):
(WebCore::shouldRepaintForImageAnimation):

Factor the pausing conditions to a function. Test that the animation is withing the
visible rect.

(WebCore::RenderElement::newImageAnimationFrameAvailable):

Add renderer to the paused animation set if we don't continue the animation.

(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded):

Resume the paused animations by triggering repaint.

* rendering/RenderElement.h:
(WebCore::RenderElement::setHasPausedImageAnimations):
(WebCore::RenderElement::hasPausedImageAnimations):
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::addRendererWithPausedImageAnimations):
(WebCore::RenderView::removeRendererWithPausedImageAnimations):
(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):
* rendering/RenderView.h:

LayoutTests: 

Reviewed by Andreas Kling.

* fast/repaint/no-animation-outside-viewport-expected.txt: Added.
* fast/repaint/no-animation-outside-viewport.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
trunk/Source/WebCore/loader/cache/CachedImageClient.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/ImageObserver.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h


Added Paths

trunk/LayoutTests/fast/repaint/no-animation-outside-viewport-expected.txt
trunk/LayoutTests/fast/repaint/no-animation-outside-viewport.html




Diff

Modified: trunk/LayoutTests/ChangeLog (163927 => 163928)

--- trunk/LayoutTests/ChangeLog	2014-02-12 02:52:19 UTC (rev 163927)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 02:55:22 UTC (rev 163928)
@@ -1,3 +1,13 @@
+2014-02-11  Antti Koivisto  an...@apple.com
+
+GIF animations should be suspended when outside of viewport
+https://bugs.webkit.org/show_bug.cgi?id=128632
+
+Reviewed by Andreas Kling.
+
+* fast/repaint/no-animation-outside-viewport-expected.txt: Added.
+* fast/repaint/no-animation-outside-viewport.html: Added.
+
 2014-02-11  Ryosuke Niwa  rn...@webkit.org
 
 Add failing test expectations to asynchronous spellchecking tests.


Added: trunk/LayoutTests/fast/repaint/no-animation-outside-viewport-expected.txt (0 => 163928)

--- trunk/LayoutTests/fast/repaint/no-animation-outside-viewport-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/repaint/no-animation-outside-viewport-expected.txt	2014-02-12 02:55:22 UTC (rev 163928)
@@ -0,0 +1,10 @@
+Test that animated gif outside viewport does not trigger repaint.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS repaintRects is 
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/repaint/no-animation-outside-viewport.html (0 => 163928)

--- 

[webkit-changes] [163929] trunk/Source/JavaScriptCore

[fpizlo]

Title: [163929] trunk/Source/_javascript_Core








Revision 163929
Author fpi...@apple.com
Date 2014-02-11 19:16:27 -0800 (Tue, 11 Feb 2014)


Log Message
Use LLVM's dead store elimination
https://bugs.webkit.org/show_bug.cgi?id=128638

Reviewed by Mark Hahnenberg.

DFG's store elimination was being run too soon for comfort on the FTL path. It's
really only sound when run after all other optimizations. Remove it from the FTL
path.

Enable LLVM store elimination. It's both easier to reason about and more
comprehensive.

* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* ftl/FTLCompile.cpp:
(JSC::FTL::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163928 => 163929)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-12 02:55:22 UTC (rev 163928)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-12 03:16:27 UTC (rev 163929)
@@ -1,3 +1,22 @@
+2014-02-11  Filip Pizlo  fpi...@apple.com
+
+Use LLVM's dead store elimination
+https://bugs.webkit.org/show_bug.cgi?id=128638
+
+Reviewed by Mark Hahnenberg.
+
+DFG's store elimination was being run too soon for comfort on the FTL path. It's
+really only sound when run after all other optimizations. Remove it from the FTL
+path.
+
+Enable LLVM store elimination. It's both easier to reason about and more
+comprehensive.
+
+* dfg/DFGPlan.cpp:
+(JSC::DFG::Plan::compileInThreadImpl):
+* ftl/FTLCompile.cpp:
+(JSC::FTL::compile):
+
 2014-02-11  Brian Burg  bb...@apple.com
 
 Web Replay: upstream replay input code generator and EncodedValue class


Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (163928 => 163929)

--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2014-02-12 02:55:22 UTC (rev 163928)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2014-02-12 03:16:27 UTC (rev 163929)
@@ -255,7 +255,6 @@
 dfg.m_fixpointState = FixpointConverged;
 
 performStoreBarrierElision(dfg);
-performStoreElimination(dfg);
 
 // If we're doing validation, then run some analyses, to give them an opportunity
 // to self-validate. Now is as good a time as any to do this.
@@ -268,6 +267,7 @@
 case DFGMode: {
 performTierUpCheckInjection(dfg);
 
+performStoreElimination(dfg);
 performCPSRethreading(dfg);
 performDCE(dfg);
 performStackLayout(dfg);


Modified: trunk/Source/_javascript_Core/ftl/FTLCompile.cpp (163928 => 163929)

--- trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-02-12 02:55:22 UTC (rev 163928)
+++ trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2014-02-12 03:16:27 UTC (rev 163929)
@@ -486,6 +486,7 @@
 llvm-AddTypeBasedAliasAnalysisPass(modulePasses);
 llvm-AddGVNPass(modulePasses);
 llvm-AddCFGSimplificationPass(modulePasses);
+llvm-AddDeadStoreEliminationPass(modulePasses);
 llvm-RunPassManager(modulePasses, state.module);
 } else {
 LLVMPassManagerBuilderRef passBuilder = llvm-PassManagerBuilderCreate();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163930] trunk/Source/WebKit2

[weinig]

Title: [163930] trunk/Source/WebKit2








Revision 163930
Author wei...@apple.com
Date 2014-02-11 19:23:55 -0800 (Tue, 11 Feb 2014)


Log Message
[WebKit2, JSC] Add user default to disable the JIT
https://bugs.webkit.org/show_bug.cgi?id=128643

Reviewed by Filip Pizlo.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
trunk/Source/WebKit2/WebProcess/mac/WebProcessMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (163929 => 163930)

--- trunk/Source/WebKit2/ChangeLog	2014-02-12 03:16:27 UTC (rev 163929)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-12 03:23:55 UTC (rev 163930)
@@ -1,3 +1,21 @@
+2014-02-11  Sam Weinig  s...@webkit.org
+
+[WebKit2, JSC] Add user default to disable the JIT
+https://bugs.webkit.org/show_bug.cgi?id=128643
+
+Reviewed by Filip Pizlo.
+
+* Shared/WebProcessCreationParameters.cpp:
+(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
+(WebKit::WebProcessCreationParameters::encode):
+(WebKit::WebProcessCreationParameters::decode):
+* Shared/WebProcessCreationParameters.h:
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::registerUserDefaultsIfNeeded):
+(WebKit::WebContext::platformInitializeWebProcess):
+* WebProcess/mac/WebProcessMac.mm:
+(WebKit::WebProcess::platformInitializeWebProcess):
+
 2014-02-11  Ryosuke Niwa  rn...@webkit.org
 
 Frame::rectForSelection shouldn't instantiate FrameSelection


Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (163929 => 163930)

--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2014-02-12 03:16:27 UTC (rev 163929)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2014-02-12 03:23:55 UTC (rev 163930)
@@ -40,6 +40,7 @@
 , nsURLCacheDiskCapacity(0)
 , shouldForceScreenFontSubstitution(false)
 , shouldEnableKerningAndLigaturesByDefault(false)
+, shouldEnableJIT(false)
 , shouldEnableFTL(false)
 #endif
 #if ENABLE(NETWORK_PROCESS)
@@ -109,6 +110,7 @@
 encoder  uiProcessBundleResourcePathExtensionHandle;
 encoder  shouldForceScreenFontSubstitution;
 encoder  shouldEnableKerningAndLigaturesByDefault;
+encoder  shouldEnableJIT;
 encoder  shouldEnableFTL;
 #endif
 
@@ -233,6 +235,8 @@
 return false;
 if (!decoder.decode(parameters.shouldEnableKerningAndLigaturesByDefault))
 return false;
+if (!decoder.decode(parameters.shouldEnableJIT))
+return false;
 if (!decoder.decode(parameters.shouldEnableFTL))
 return false;
 #endif


Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (163929 => 163930)

--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2014-02-12 03:16:27 UTC (rev 163929)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2014-02-12 03:23:55 UTC (rev 163930)
@@ -131,6 +131,7 @@
 
 bool shouldForceScreenFontSubstitution;
 bool shouldEnableKerningAndLigaturesByDefault;
+bool shouldEnableJIT;
 bool shouldEnableFTL;
 #endif // PLATFORM(COCOA)
 


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (163929 => 163930)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-02-12 03:16:27 UTC (rev 163929)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-02-12 03:23:55 UTC (rev 163930)
@@ -67,7 +67,8 @@
 NSString *WebKitLocalCacheDefaultsKey = @WebKitLocalCache;
 NSString *WebStorageDirectoryDefaultsKey = @WebKitLocalStorageDatabasePathPreferenceKey;
 NSString *WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey = @WebKitKerningAndLigaturesEnabledByDefault;
-NSString *WebKitFTLEnabledDefaultsKey = @WebKitFTLEnabledDefaultsKey;
+NSString *WebKitJSCFTLEnabledDefaultsKey = @WebKitJSCFTLEnabledDefaultsKey;
+NSString *WebKitJSCJITEnabledDefaultsKey = @WebKitJSCJITEnabledDefaultsKey;
 
 #if !PLATFORM(IOS)
 static NSString *WebKitApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification = @NSApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification;
@@ -97,7 +98,8 @@
 
 #if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
 [registrationDictionary setObject:[NSNumber numberWithBool:YES] forKey:WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey];
-[registrationDictionary setObject:[NSNumber numberWithBool:NO] forKey:WebKitFTLEnabledDefaultsKey];
+

[webkit-changes] [163931] trunk/Source

[zalan]

Title: [163931] trunk/Source








Revision 163931
Author za...@apple.com
Date 2014-02-11 19:28:43 -0800 (Tue, 11 Feb 2014)


Log Message
Subpixel rendering: Make GraphicsLayerClient::paintContents's clip rect subpixel based.
https://bugs.webkit.org/show_bug.cgi?id=128460

Reviewed by Simon Fraser.

GraphicsClient::paintContents takes clipRect as FloatRect now so that we can paint on
subpixel position.

No change in functionality.

Source/WebCore:

* platform/graphics/GraphicsLayerClient.h:
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::paintContents):
* platform/graphics/texmap/coordinated/CompositingCoordinator.h:
* rendering/RenderLayer.cpp:
(WebCore::cornerRect):
(WebCore::RenderLayer::scrollCornerRect):
(WebCore::resizerCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::verticalScrollbarStart):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::paintContents):
* rendering/RenderLayerCompositor.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):

Source/WebKit/gtk:

* WebCoreSupport/AcceleratedCompositingContext.h:
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::paintContents):

Source/WebKit/win:

* WebView.cpp:
(WebView::paintContents):
* WebView.h:

Source/WebKit2:

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::paintContents):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::paintContents):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::paintContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayerClient.h
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h
trunk/Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit/win/WebView.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (163930 => 163931)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 03:23:55 UTC (rev 163930)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 03:28:43 UTC (rev 163931)
@@ -1,3 +1,39 @@
+2014-02-11  Zalan Bujtas  za...@apple.com
+
+Subpixel rendering: Make GraphicsLayerClient::paintContents's clip rect subpixel based.
+https://bugs.webkit.org/show_bug.cgi?id=128460
+
+Reviewed by Simon Fraser.
+
+GraphicsClient::paintContents takes clipRect as FloatRect now so that we can paint on
+subpixel position.
+
+No change in functionality.
+
+* platform/graphics/GraphicsLayerClient.h:
+* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
+(WebCore::CompositingCoordinator::paintContents):
+* platform/graphics/texmap/coordinated/CompositingCoordinator.h:
+* rendering/RenderLayer.cpp:
+(WebCore::cornerRect):
+(WebCore::RenderLayer::scrollCornerRect):
+(WebCore::resizerCornerRect):
+(WebCore::RenderLayer::scrollCornerAndResizerRect):
+(WebCore::RenderLayer::verticalScrollbarStart):
+(WebCore::RenderLayer::horizontalScrollbarStart):
+(WebCore::RenderLayer::paintResizer):
+(WebCore::RenderLayer::hitTestOverflowControls):
+* rendering/RenderLayer.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::paintIntoLayer):
+(WebCore::RenderLayerBacking::paintContents):
+* 

[webkit-changes] [163933] trunk/Source/WebCore

[akling]

Title: [163933] trunk/Source/WebCore








Revision 163933
Author akl...@apple.com
Date 2014-02-11 19:51:06 -0800 (Tue, 11 Feb 2014)


Log Message
Don't allocate RenderNamedFlowThread's child list separately.
https://webkit.org/b/128640

Since we always create the flow-thread child list, there's no reason
to put it in a separate heap allocation. Also remove the typedef and
use auto instead.

Reviewed by Anders Carlsson.

* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
* rendering/RenderNamedFlowThread.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp
trunk/Source/WebCore/rendering/RenderNamedFlowThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163932 => 163933)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 03:45:34 UTC (rev 163932)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 03:51:06 UTC (rev 163933)
@@ -1,3 +1,21 @@
+2014-02-11  Andreas Kling  akl...@apple.com
+
+Don't allocate RenderNamedFlowThread's child list separately.
+https://webkit.org/b/128640
+
+Since we always create the flow-thread child list, there's no reason
+to put it in a separate heap allocation. Also remove the typedef and
+use auto instead.
+
+Reviewed by Anders Carlsson.
+
+* rendering/RenderNamedFlowThread.cpp:
+(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
+(WebCore::RenderNamedFlowThread::nextRendererForNode):
+(WebCore::RenderNamedFlowThread::addFlowChild):
+(WebCore::RenderNamedFlowThread::removeFlowChild):
+* rendering/RenderNamedFlowThread.h:
+
 2014-02-11  Zalan Bujtas  za...@apple.com
 
 Subpixel rendering: Make GraphicsLayerClient::paintContents's clip rect subpixel based.


Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp (163932 => 163933)

--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp	2014-02-12 03:45:34 UTC (rev 163932)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp	2014-02-12 03:51:06 UTC (rev 163933)
@@ -47,7 +47,6 @@
 
 RenderNamedFlowThread::RenderNamedFlowThread(Document document, PassRefRenderStyle style, PassRefWebKitNamedFlow namedFlow)
 : RenderFlowThread(document, std::move(style))
-, m_flowThreadChildList(adoptPtr(new FlowThreadChildList()))
 , m_overset(true)
 , m_hasRegionsWithStyling(false)
 , m_namedFlow(std::move(namedFlow))
@@ -100,8 +99,7 @@
 
 RenderObject* RenderNamedFlowThread::nextRendererForNode(Node* node) const
 {
-const FlowThreadChildList childList = *(m_flowThreadChildList.get());
-for (auto child : childList) {
+for (auto child : m_flowThreadChildList) {
 ASSERT(child-node());
 unsigned short position = node-compareDocumentPosition(child-node());
 if (position  Node::DOCUMENT_POSITION_FOLLOWING)
@@ -126,14 +124,14 @@
 
 RenderObject* beforeChild = nextRendererForNode(childNode);
 if (beforeChild)
-m_flowThreadChildList-insertBefore(beforeChild, newChild);
+m_flowThreadChildList.insertBefore(beforeChild, newChild);
 else
-m_flowThreadChildList-add(newChild);
+m_flowThreadChildList.add(newChild);
 }
 
 void RenderNamedFlowThread::removeFlowChild(RenderObject* child)
 {
-m_flowThreadChildList-remove(child);
+m_flowThreadChildList.remove(child);
 }
 
 bool RenderNamedFlowThread::dependsOn(RenderNamedFlowThread* otherRenderFlowThread) const


Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.h (163932 => 163933)

--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.h	2014-02-12 03:45:34 UTC (rev 163932)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.h	2014-02-12 03:51:06 UTC (rev 163933)
@@ -56,9 +56,9 @@
 
 void addFlowChild(RenderObject* newChild);
 void removeFlowChild(RenderObject*);
-bool hasChildren() const { return !m_flowThreadChildList-isEmpty(); }
+bool hasChildren() const { return !m_flowThreadChildList.isEmpty(); }
 #ifndef NDEBUG
-bool hasChild(RenderObject* child) const { return m_flowThreadChildList-contains(child); }
+bool hasChild(RenderObject* child) const { return m_flowThreadChildList.contains(child); }
 #endif
 
 void pushDependencies(RenderNamedFlowThreadList);
@@ -129,8 +129,7 @@
 RenderNamedFlowThreadCountedSet m_layoutBeforeThreadsSet;
 
 // Holds the sorted children of a named flow. This is the only way we can get the ordering right.
-typedef ListHashSetRenderObject* FlowThreadChildList;
-OwnPtrFlowThreadChildList m_flowThreadChildList;
+ListHashSetRenderObject* m_flowThreadChildList;
 
 NamedFlowContentElements m_contentElements;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [163934] trunk/Source/WebCore

[akling]

Title: [163934] trunk/Source/WebCore








Revision 163934
Author akl...@apple.com
Date 2014-02-11 19:53:02 -0800 (Tue, 11 Feb 2014)


Log Message
Protect some RenderFlowThread functions.
https://webkit.org/b/128642

Make the RenderFlowThread constructor protected and a handful of
member functions private.

Reviewed by Anders Carlsson.

* rendering/RenderFlowThread.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163933 => 163934)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 03:51:06 UTC (rev 163933)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 03:53:02 UTC (rev 163934)
@@ -1,5 +1,17 @@
 2014-02-11  Andreas Kling  akl...@apple.com
 
+Protect some RenderFlowThread functions.
+https://webkit.org/b/128642
+
+Make the RenderFlowThread constructor protected and a handful of
+member functions private.
+
+Reviewed by Anders Carlsson.
+
+* rendering/RenderFlowThread.h:
+
+2014-02-11  Andreas Kling  akl...@apple.com
+
 Don't allocate RenderNamedFlowThread's child list separately.
 https://webkit.org/b/128640
 


Modified: trunk/Source/WebCore/rendering/RenderFlowThread.h (163933 => 163934)

--- trunk/Source/WebCore/rendering/RenderFlowThread.h	2014-02-12 03:51:06 UTC (rev 163933)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.h	2014-02-12 03:53:02 UTC (rev 163934)
@@ -58,17 +58,8 @@
 
 class RenderFlowThread: public RenderBlockFlow {
 public:
-RenderFlowThread(Document, PassRefRenderStyle);
-virtual ~RenderFlowThread() { };
-
-virtual bool isRenderFlowThread() const override final { return true; }
+virtual ~RenderFlowThread() { }
 
-virtual void layout() override final;
-
-// Always create a RenderLayer for the RenderFlowThread so that we 
-// can easily avoid drawing the children directly.
-virtual bool requiresLayer() const override final { return true; }
-
 virtual void removeFlowChildInfo(RenderObject*);
 #ifndef NDEBUG
 bool hasChildInfo(RenderObject* child) const { return child  child-isBox()  m_regionRangeMap.contains(toRenderBox(child)); }
@@ -218,7 +209,17 @@
 
 bool regionInRange(const RenderRegion* targetRegion, const RenderRegion* startRegion, const RenderRegion* endRegion) const;
 
+private:
+virtual bool isRenderFlowThread() const override final { return true; }
+virtual void layout() override final;
+
+// Always create a RenderLayer for the RenderFlowThread so that we
+// can easily avoid drawing the children directly.
+virtual bool requiresLayer() const override final { return true; }
+
 protected:
+RenderFlowThread(Document, PassRefRenderStyle);
+
 virtual const char* renderName() const = 0;
 
 // Overridden by columns/pages to set up an initial logical width of the page width even when






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163935] trunk/Tools

[fpizlo]

Title: [163935] trunk/Tools








Revision 163935
Author fpi...@apple.com
Date 2014-02-11 20:06:42 -0800 (Tue, 11 Feb 2014)


Log Message
It should be possible to force copy-webkitlibraries-blahblah to copy things regardless of timestamp
https://bugs.webkit.org/show_bug.cgi?id=128646

Reviewed by Mark Rowe.

* Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
(dittoHeaders):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory




Diff

Modified: trunk/Tools/ChangeLog (163934 => 163935)

--- trunk/Tools/ChangeLog	2014-02-12 03:53:02 UTC (rev 163934)
+++ trunk/Tools/ChangeLog	2014-02-12 04:06:42 UTC (rev 163935)
@@ -1,3 +1,14 @@
+2014-02-11  Filip Pizlo  fpi...@apple.com
+
+It should be possible to force copy-webkitlibraries-blahblah to copy things regardless of timestamp
+https://bugs.webkit.org/show_bug.cgi?id=128646
+
+Reviewed by Mark Rowe.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+(unpackIfNecessary):
+(dittoHeaders):
+
 2014-02-11  Brian Burg  bb...@apple.com
 
 Web Replay: upstream replay input code generator and EncodedValue class


Modified: trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory (163934 => 163935)

--- trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2014-02-12 03:53:02 UTC (rev 163934)
+++ trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2014-02-12 04:06:42 UTC (rev 163935)
@@ -36,6 +36,7 @@
 my $llvmIncludePackage = ;
 my $llvmLibraryPackage = ;
 my $useFullLibPaths = 0;
+my $force = 0;
 
 my $programName = basename($0);
 my $usage = EOF;
@@ -46,6 +47,7 @@
   --use-llvm-includes=pathGet the LLVM inludes package from path
   --use-llvm-libraries=path   Get the LLVM libraries package from path
   --[no-]use-full-lib-paths Toggle using full library paths
+  --[no-]force  Toggle forcing the copy - i.e. ignoring timestamps (default: $force)
 EOF
 
 GetOptions(
@@ -54,7 +56,8 @@
 'wksi!' = \$wksi,
 'use-llvm-includes=s' = \$llvmIncludePackage,
 'use-llvm-libraries=s' = \$llvmLibraryPackage,
-'use-full-lib-paths!' = \$useFullLibPaths
+'use-full-lib-paths!' = \$useFullLibPaths,
+'force!' = \$force
 );
 
 if ($showHelp) {
@@ -77,7 +80,7 @@
 sub unpackIfNecessary
 {
 my ($targetDir, $sampleFile, $package, $hasLibraries) = @_;
-if (!-e $sampleFile || -M $sampleFile  -M $package) {
+if ($force || !-e $sampleFile || -M $sampleFile  -M $package) {
 print Unpacking $package into $targetDir\n;
 (system(tar -C $targetDir -xmf $package) == 0) or die;
 if ($hasLibraries) {
@@ -95,7 +98,7 @@
 sub dittoHeaders
 {
 my ($srcHeader, $header) = @_;
-if (!-e $header || -M $header  -M $srcHeader) {
+if ($force || !-e $header || -M $header  -M $srcHeader) {
 print Updating $header\n;
 (system(ditto, $srcHeader, $header) == 0) or die;
 }
@@ -116,7 +119,7 @@
 foreach my $libName (@librariesToCopy) {
 my $srcLib = WebKitLibraries/ . $libName;
 my $lib = $libraryDir/ . $libName;
-if (!-e $lib || -M $lib  -M $srcLib) {
+if ($force || !-e $lib || -M $lib  -M $srcLib) {
 print Updating $lib\n;
 (system(ditto, $srcLib, $lib) == 0) or die;
 (system($ranlib, $lib) == 0) or die;
@@ -226,7 +229,8 @@
 my $ranlibToken = $libraryTargetDirectory/.ranlibToken-$filename;
 unlink($targetLibrary);
 symlink($sourceLibrary, $targetLibrary);
-if (!-e $ranlibToken
+if ($force
+|| !-e $ranlibToken
 || !fileContentsEquals($ranlibToken, $sourceLibrary)
 || -M $ranlibToken  -M $sourceLibrary) {
 printRanlib $filename\n;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163936] trunk/Source/WebCore

[ddkilzer]

Title: [163936] trunk/Source/WebCore








Revision 163936
Author ddkil...@apple.com
Date 2014-02-11 20:08:22 -0800 (Tue, 11 Feb 2014)


Log Message
ContentData equals() methods are not inline-able http://webkit.org/b/128538

Reviewed by Darin Adler.

Get rid of pure virtual equals() method in favor of
ContentData::Type enum for runtime type information.
This also lets us devirtualize the isFoo() methods.

* rendering/style/ContentData.h:
(WebCore::ContentData::type): Add.
(WebCore::ContentData::isCounter): Devirtualize.
(WebCore::ContentData::isImage): Devirtualize.
(WebCore::ContentData::isQuote): Devirtualize.
(WebCore::ContentData::isText): Devirtualize.
(WebCore::ContentData::ContentData): Add.  Include
ContentData::Type parameter.
(WebCore::operator==): Add overloaded methods for each subclass.
Stop using pure virtual equals() method, check type(), and use
overloaded subclass operator==() methods.
(WebCore::operator!=): Add overloaded methods for each subclass.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/ContentData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163935 => 163936)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 04:06:42 UTC (rev 163935)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 04:08:22 UTC (rev 163936)
@@ -1,3 +1,27 @@
+2014-02-11  David Kilzer  ddkil...@apple.com
+
+ContentData equals() methods are not inline-able
+http://webkit.org/b/128538
+
+Reviewed by Darin Adler.
+
+Get rid of pure virtual equals() method in favor of
+ContentData::Type enum for runtime type information.
+This also lets us devirtualize the isFoo() methods.
+
+* rendering/style/ContentData.h:
+(WebCore::ContentData::type): Add.
+(WebCore::ContentData::isCounter): Devirtualize.
+(WebCore::ContentData::isImage): Devirtualize.
+(WebCore::ContentData::isQuote): Devirtualize.
+(WebCore::ContentData::isText): Devirtualize.
+(WebCore::ContentData::ContentData): Add.  Include
+ContentData::Type parameter.
+(WebCore::operator==): Add overloaded methods for each subclass.
+Stop using pure virtual equals() method, check type(), and use
+overloaded subclass operator==() methods.
+(WebCore::operator!=): Add overloaded methods for each subclass.
+
 2014-02-11  Andreas Kling  akl...@apple.com
 
 Protect some RenderFlowThread functions.


Modified: trunk/Source/WebCore/rendering/style/ContentData.h (163935 => 163936)

--- trunk/Source/WebCore/rendering/style/ContentData.h	2014-02-12 04:06:42 UTC (rev 163935)
+++ trunk/Source/WebCore/rendering/style/ContentData.h	2014-02-12 04:08:22 UTC (rev 163936)
@@ -39,13 +39,21 @@
 class ContentData {
 WTF_MAKE_FAST_ALLOCATED;
 public:
+enum Type {
+CounterDataType,
+ImageDataType,
+QuoteDataType,
+TextDataType
+};
 virtual ~ContentData() { }
 
-virtual bool isCounter() const { return false; }
-virtual bool isImage() const { return false; }
-virtual bool isQuote() const { return false; }
-virtual bool isText() const { return false; }
+Type type() const { return m_type; }
 
+bool isCounter() const { return type() == CounterDataType; }
+bool isImage() const { return type() == ImageDataType; }
+bool isQuote() const { return type() == QuoteDataType; }
+bool isText() const { return type() == TextDataType; }
+
 virtual RenderPtrRenderObject createContentRenderer(Document, const RenderStyle) const = 0;
 
 std::unique_ptrContentData clone() const;
@@ -55,14 +63,19 @@
 
 void setAltText(const String alt) { m_altText = alt; }
 const String altText() const { return m_altText; }
-
-virtual bool equals(const ContentData) const = 0;
 
+protected:
+explicit ContentData(Type type)
+: m_type(type)
+{
+}
+
 private:
 virtual std::unique_ptrContentData cloneInternal() const = 0;
 
 std::unique_ptrContentData m_next;
 String m_altText;
+Type m_type;
 };
 
 #define CONTENT_DATA_TYPE_CASTS(ToClassName, FromClassName, ContentDataName) \
@@ -71,7 +84,8 @@
 class ImageContentData final : public ContentData {
 public:
 explicit ImageContentData(PassRefPtrStyleImage image)
-: m_image(image)
+: ContentData(ImageDataType)
+, m_image(image)
 {
 }
 
@@ -79,11 +93,8 @@
 StyleImage* image() { return m_image.get(); }
 void setImage(PassRefPtrStyleImage image) { m_image = image; }
 
-virtual bool isImage() const override { return true; }
 virtual RenderPtrRenderObject createContentRenderer(Document, const RenderStyle) const override;
 
-virtual bool equals(const ContentData) const override;
-
 private:
 virtual std::unique_ptrContentData cloneInternal() const override
 {
@@ -97,28 +108,29 @@
 
 CONTENT_DATA_TYPE_CASTS(ImageContentData, ContentData, Image)
 
-inline bool ImageContentData::equals(const ContentData data) 

[webkit-changes] [163937] trunk/Source/JavaScriptCore

[fpizlo]

Title: [163937] trunk/Source/_javascript_Core








Revision 163937
Author fpi...@apple.com
Date 2014-02-11 20:13:48 -0800 (Tue, 11 Feb 2014)


Log Message
Unreviewed, trivial change to silence FTL assertions

Normally, lowJSValue() should only be used for UntypedUse only. Here we are using it
on ObjectOrOtherUse because we execute the speculation ourselves. The way you're
supposed to do this is by passing ManualOperandSpeculation to tell lowJSValue() not
to assert.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163936 => 163937)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-12 04:08:22 UTC (rev 163936)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-12 04:13:48 UTC (rev 163937)
@@ -1,5 +1,17 @@
 2014-02-11  Filip Pizlo  fpi...@apple.com
 
+Unreviewed, trivial change to silence FTL assertions
+
+Normally, lowJSValue() should only be used for UntypedUse only. Here we are using it
+on ObjectOrOtherUse because we execute the speculation ourselves. The way you're
+supposed to do this is by passing ManualOperandSpeculation to tell lowJSValue() not
+to assert.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
+
+2014-02-11  Filip Pizlo  fpi...@apple.com
+
 Use LLVM's dead store elimination
 https://bugs.webkit.org/show_bug.cgi?id=128638
 


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (163936 => 163937)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-12 04:08:22 UTC (rev 163936)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-12 04:13:48 UTC (rev 163937)
@@ -3621,7 +3621,7 @@
 void compareEqObjectOrOtherToObject(Edge leftChild, Edge rightChild)
 {
 LValue rightCell = lowCell(rightChild);
-LValue leftValue = lowJSValue(leftChild);
+LValue leftValue = lowJSValue(leftChild, ManualOperandSpeculation);
 
 speculateTruthyObject(rightChild, rightCell, SpecObject);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163938] trunk/Source/JavaScriptCore

[fpizlo]

Title: [163938] trunk/Source/_javascript_Core








Revision 163938
Author fpi...@apple.com
Date 2014-02-11 20:24:37 -0800 (Tue, 11 Feb 2014)


Log Message
Fix assertions and incorrect codegen for CompareEq(ObjectOrOther:, Object:)
https://bugs.webkit.org/show_bug.cgi?id=128648

Reviewed by Mark Lam.

I did CompareEq(Object:, ObjectOrOther:) correctly but the flipped version wrong.
That's what I get for running tests in release mode. It's hard to write a test for
the incorrect codegen; that's kind of why the assertions are there.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163937 => 163938)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-12 04:13:48 UTC (rev 163937)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-12 04:24:37 UTC (rev 163938)
@@ -1,5 +1,19 @@
 2014-02-11  Filip Pizlo  fpi...@apple.com
 
+Fix assertions and incorrect codegen for CompareEq(ObjectOrOther:, Object:)
+https://bugs.webkit.org/show_bug.cgi?id=128648
+
+Reviewed by Mark Lam.
+
+I did CompareEq(Object:, ObjectOrOther:) correctly but the flipped version wrong.
+That's what I get for running tests in release mode. It's hard to write a test for
+the incorrect codegen; that's kind of why the assertions are there.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
+
+2014-02-11  Filip Pizlo  fpi...@apple.com
+
 Unreviewed, trivial change to silence FTL assertions
 
 Normally, lowJSValue() should only be used for UntypedUse only. Here we are using it


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (163937 => 163938)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-12 04:13:48 UTC (rev 163937)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-12 04:24:37 UTC (rev 163938)
@@ -3216,7 +3216,7 @@
 
 if (m_node-child1().useKind() == ObjectOrOtherUse
  m_node-child2().useKind() == ObjectUse) {
-compareEqObjectOrOtherToObject(m_node-child2(), m_node-child1());
+compareEqObjectOrOtherToObject(m_node-child1(), m_node-child2());
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163940] trunk/Source/WebCore

[mitz]

Title: [163940] trunk/Source/WebCore








Revision 163940
Author m...@apple.com
Date 2014-02-11 20:36:05 -0800 (Tue, 11 Feb 2014)


Log Message
iOS build fix.

* rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (163939 => 163940)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 04:25:46 UTC (rev 163939)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 04:36:05 UTC (rev 163940)
@@ -1,3 +1,10 @@
+2014-02-11  Dan Bernstein  m...@apple.com
+
+iOS build fix.
+
+* rendering/RenderElement.cpp:
+(WebCore::shouldRepaintForImageAnimation):
+
 2014-02-11  David Kilzer  ddkil...@apple.com
 
 ContentData equals() methods are not inline-able


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (163939 => 163940)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 04:25:46 UTC (rev 163939)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 04:36:05 UTC (rev 163940)
@@ -1288,7 +1288,7 @@
 if (frameView.isOffscreen())
 return false;
 #if PLATFORM(IOS)
-if (frameView.timersPaused())
+if (document.frame().timersPaused())
 return false;
 #endif
 if (document.activeDOMObjectsAreSuspended())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163941] trunk/Source/WebCore

[mitz]

Title: [163941] trunk/Source/WebCore








Revision 163941
Author m...@apple.com
Date 2014-02-11 20:37:28 -0800 (Tue, 11 Feb 2014)


Log Message
iOS build fix fix.

* rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (163940 => 163941)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 04:36:05 UTC (rev 163940)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 04:37:28 UTC (rev 163941)
@@ -1,5 +1,12 @@
 2014-02-11  Dan Bernstein  m...@apple.com
 
+iOS build fix fix.
+
+* rendering/RenderElement.cpp:
+(WebCore::shouldRepaintForImageAnimation):
+
+2014-02-11  Dan Bernstein  m...@apple.com
+
 iOS build fix.
 
 * rendering/RenderElement.cpp:


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (163940 => 163941)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 04:36:05 UTC (rev 163940)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 04:37:28 UTC (rev 163941)
@@ -1288,7 +1288,7 @@
 if (frameView.isOffscreen())
 return false;
 #if PLATFORM(IOS)
-if (document.frame().timersPaused())
+if (document.frame()-timersPaused())
 return false;
 #endif
 if (document.activeDOMObjectsAreSuspended())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163943] trunk/Source/WebKit2

[rniwa]

Title: [163943] trunk/Source/WebKit2








Revision 163943
Author rn...@webkit.org
Date 2014-02-11 20:45:13 -0800 (Tue, 11 Feb 2014)


Log Message
EFL build fix after r163919.

* WebProcess/WebPage/WebPage.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (163942 => 163943)

--- trunk/Source/WebKit2/ChangeLog	2014-02-12 04:42:47 UTC (rev 163942)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-12 04:45:13 UTC (rev 163943)
@@ -1,3 +1,9 @@
+2014-02-11  Ryosuke Niwa  rn...@webkit.org
+
+EFL build fix after r163919.
+
+* WebProcess/WebPage/WebPage.h:
+
 2014-02-11  Jaehun Lim  ljaehun@samsung.com
 
 Unreviewed build fix after r163919


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (163942 => 163943)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h	2014-02-12 04:42:47 UTC (rev 163942)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h	2014-02-12 04:45:13 UTC (rev 163943)
@@ -76,6 +76,10 @@
 #include WebPrintOperationGtk.h
 #endif
 
+#if PLATFORM(IOS)
+#include WKGestureTypes.h
+#endif
+
 #if ENABLE(TOUCH_EVENTS)
 #if PLATFORM(IOS)
 #include WebKitAdditions/PlatformTouchEventIOS.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163944] trunk/Source/WebCore

[zalan]

Title: [163944] trunk/Source/WebCore








Revision 163944
Author za...@apple.com
Date 2014-02-11 20:50:55 -0800 (Tue, 11 Feb 2014)


Log Message
Subpixel rendering: Switch repaint rect from IntRect to LayoutRect to be able to
repaint on device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=128477

Reviewed by Simon Fraser.

RenderLayer needs to be able to repaint on device pixel boundaries. RenderView still
repaints on integral position.

No change in functionality.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
* rendering/RenderLayerBacking.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
* rendering/RenderObject.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (163943 => 163944)

--- trunk/Source/WebCore/ChangeLog	2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/ChangeLog	2014-02-12 04:50:55 UTC (rev 163944)
@@ -1,3 +1,34 @@
+2014-02-11  Zalan Bujtas  za...@apple.com
+
+Subpixel rendering: Switch repaint rect from IntRect to LayoutRect to be able to
+repaint on device pixel boundaries.
+https://bugs.webkit.org/show_bug.cgi?id=128477
+
+Reviewed by Simon Fraser.
+
+RenderLayer needs to be able to repaint on device pixel boundaries. RenderView still
+repaints on integral position.
+
+No change in functionality.
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::RenderBlockFlow::layoutRunsAndFloats):
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::updateLayerPositions):
+(WebCore::RenderLayer::clearRepaintRects):
+(WebCore::RenderLayer::scrollTo):
+(WebCore::RenderLayer::calculateClipRects):
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
+* rendering/RenderLayerBacking.h:
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::repaintUsingContainer):
+(WebCore::RenderObject::repaint):
+(WebCore::RenderObject::repaintRectangle):
+* rendering/RenderObject.h:
+
 2014-02-11  Dan Bernstein  m...@apple.com
 
 iOS build fix fix.


Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (163943 => 163944)

--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2014-02-12 04:50:55 UTC (rev 163944)
@@ -1054,7 +1054,7 @@
 // that the block really needed a full layout, we missed our chance to repaint the layer
 // before layout started.  Luckily the layer has cached the repaint rect for its original
 // position and size, and so we can use that to make a repaint happen now.
-repaintUsingContainer(containerForRepaint(), pixelSnappedIntRect(layer()-repaintRect()));
+repaintUsingContainer(containerForRepaint(), layer()-repaintRect());
 }
 }
 


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (163943 => 163944)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 04:45:13 UTC (rev 163943)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2014-02-12 04:50:55 UTC (rev 163944)
@@ -1187,9 +1187,9 @@
 repaintContainer = view();
 
 if (fullRepaint) {
-repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds));
+repaintUsingContainer(repaintContainer, oldBounds);
 if (newBounds != oldBounds)
-repaintUsingContainer(repaintContainer, pixelSnappedIntRect(newBounds));
+repaintUsingContainer(repaintContainer, newBounds);
 return true;
 }
 
@@ -1198,27 +1198,27 @@
 
 LayoutUnit deltaLeft = newBounds.x() - oldBounds.x();
 if (deltaLeft  0)
-repaintUsingContainer(repaintContainer, pixelSnappedIntRect(oldBounds.x(), oldBounds.y(), deltaLeft, oldBounds.height()));
+repaintUsingContainer(repaintContainer, LayoutRect(oldBounds.x(), 

[webkit-changes] [163945] trunk/LayoutTests

[zalan]

Title: [163945] trunk/LayoutTests








Revision 163945
Author za...@apple.com
Date 2014-02-11 21:15:34 -0800 (Tue, 11 Feb 2014)


Log Message
transitions/shorthand-border-transitions.html became flaky. Skip it for now.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163944 => 163945)

--- trunk/LayoutTests/ChangeLog	2014-02-12 04:50:55 UTC (rev 163944)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 05:15:34 UTC (rev 163945)
@@ -1,3 +1,9 @@
+2014-02-11  Zalan Bujtas  za...@apple.com
+
+transitions/shorthand-border-transitions.html became flaky. Skip it for now.
+
+* platform/mac/TestExpectations:
+
 2014-02-11  Ryosuke Niwa  rn...@webkit.org
 
 Windows rebaselines.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (163944 => 163945)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-02-12 04:50:55 UTC (rev 163944)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-02-12 05:15:34 UTC (rev 163945)
@@ -1338,6 +1338,8 @@
 webkit.org/b/128061 svg/zoom/page/zoom-svg-float-border-padding.xml [ Failure ]
 webkit.org/b/128061 svg/zoom/page/zoom-svg-through-object-with-auto-size.html [ Failure ]
 webkit.org/b/128061 tables/mozilla_expected_failures/bugs/bug1055-2.html [ Failure ]
+# debug assert on empty drawRect
+webkit.org/b/128283 transitions/shorthand-border-transitions.html [ Failure ]
 # Non-uniform scaling context.
 webkit.org/b/128081 fast/events/page-scaled-mouse-click-iframe.html
 # End of subpixel failures.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163947] trunk/Source/WebKit2

[mitz]

Title: [163947] trunk/Source/WebKit2








Revision 163947
Author m...@apple.com
Date 2014-02-11 21:45:22 -0800 (Tue, 11 Feb 2014)


Log Message
rdar://problem/16044438: WebKit2.framework (with *Process.app) exists at the top level of the simulator
https://bugs.webkit.org/show_bug.cgi?id=128650

Reviewed by Mark Rowe.

* Configurations/All-iOS.xcconfig: Removed this unused file.
* Configurations/All.xcconfig: Set SKIP_INSTALL to YES for this aggregate target, so that
its Copy Files build phase, intended only for engineering builds, doesn’t copy into the
(wrong) install location.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/All.xcconfig


Removed Paths

trunk/Source/WebKit2/Configurations/All-iOS.xcconfig




Diff

Modified: trunk/Source/WebKit2/ChangeLog (163946 => 163947)

--- trunk/Source/WebKit2/ChangeLog	2014-02-12 05:42:32 UTC (rev 163946)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-12 05:45:22 UTC (rev 163947)
@@ -1,3 +1,15 @@
+2014-02-11  Dan Bernstein  m...@apple.com
+
+rdar://problem/16044438: WebKit2.framework (with *Process.app) exists at the top level of the simulator
+https://bugs.webkit.org/show_bug.cgi?id=128650
+
+Reviewed by Mark Rowe.
+
+* Configurations/All-iOS.xcconfig: Removed this unused file.
+* Configurations/All.xcconfig: Set SKIP_INSTALL to YES for this aggregate target, so that
+its Copy Files build phase, intended only for engineering builds, doesn’t copy into the
+(wrong) install location.
+
 2014-02-11  Ryosuke Niwa  rn...@webkit.org
 
 EFL build fix after r163919.


Deleted: trunk/Source/WebKit2/Configurations/All-iOS.xcconfig (163946 => 163947)

--- trunk/Source/WebKit2/Configurations/All-iOS.xcconfig	2014-02-12 05:42:32 UTC (rev 163946)
+++ trunk/Source/WebKit2/Configurations/All-iOS.xcconfig	2014-02-12 05:45:22 UTC (rev 163947)
@@ -1,26 +0,0 @@
-// Copyright (C) 2013 Apple Inc. All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions
-// are met:
-// 1. Redistributions of source code must retain the above copyright
-//notice, this list of conditions and the following disclaimer.
-// 2. Redistributions in binary form must reproduce the above copyright
-//notice, this list of conditions and the following disclaimer in the
-//documentation and/or other materials provided with the distribution.
-//
-// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
-// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-// PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
-// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
-// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
-
-#include BaseTarget.xcconfig
-
-SKIP_INSTALL = YES;


Modified: trunk/Source/WebKit2/Configurations/All.xcconfig (163946 => 163947)

--- trunk/Source/WebKit2/Configurations/All.xcconfig	2014-02-12 05:42:32 UTC (rev 163946)
+++ trunk/Source/WebKit2/Configurations/All.xcconfig	2014-02-12 05:45:22 UTC (rev 163947)
@@ -28,3 +28,5 @@
 EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_SOURCE_FILE_NAMES_$(PLATFORM_NAME));
 EXCLUDED_SOURCE_FILE_NAMES_iphoneos = PluginProcess.app;
 EXCLUDED_SOURCE_FILE_NAMES_iphonesimulator = $(EXCLUDED_SOURCE_FILE_NAMES_iphoneos);
+
+SKIP_INSTALL = YES;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163948] trunk/Source

[rniwa]

Title: [163948] trunk/Source








Revision 163948
Author rn...@webkit.org
Date 2014-02-11 21:54:02 -0800 (Tue, 11 Feb 2014)


Log Message
Source/_javascript_Core: Debug build fix after r163946.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):

Source/WebKit2: Remove one of includes added in r163943 and r163939.

* WebProcess/WebPage/WebPage.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (163947 => 163948)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-12 05:45:22 UTC (rev 163947)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-12 05:54:02 UTC (rev 163948)
@@ -1,3 +1,10 @@
+2014-02-11  Ryosuke Niwa  rn...@webkit.org
+
+Debug build fix after r163946.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
+
 2014-02-11  Filip Pizlo  fpi...@apple.com
 
 Inserting a node with a codeOrigin like another node should copy both the codeOrigin and codeOriginForExitTarget


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (163947 => 163948)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2014-02-12 05:45:22 UTC (rev 163947)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2014-02-12 05:54:02 UTC (rev 163948)
@@ -258,7 +258,7 @@
 Node* injectLazyOperandSpeculation(Node* node)
 {
 ASSERT(node-op() == GetLocal);
-ASSERT(node-codeOrigin.bytecodeIndex == m_currentIndex);
+ASSERT(node-origin.semantic.bytecodeIndex == m_currentIndex);
 ConcurrentJITLocker locker(m_inlineStackTop-m_profiledBlock-m_lock);
 LazyOperandValueProfileKey key(m_currentIndex, node-local());
 SpeculatedType prediction = m_inlineStackTop-m_lazyOperands.prediction(locker, key);


Modified: trunk/Source/WebKit2/ChangeLog (163947 => 163948)

--- trunk/Source/WebKit2/ChangeLog	2014-02-12 05:45:22 UTC (rev 163947)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-12 05:54:02 UTC (rev 163948)
@@ -1,3 +1,9 @@
+2014-02-11  Ryosuke Niwa  rn...@webkit.org
+
+Remove one of includes added in r163943 and r163939.
+
+* WebProcess/WebPage/WebPage.h:
+
 2014-02-11  Dan Bernstein  m...@apple.com
 
 rdar://problem/16044438: WebKit2.framework (with *Process.app) exists at the top level of the simulator


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (163947 => 163948)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h	2014-02-12 05:45:22 UTC (rev 163947)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h	2014-02-12 05:54:02 UTC (rev 163948)
@@ -105,10 +105,6 @@
 #define ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC 1
 #endif
 
-#if PLATFORM(IOS)
-#include WKGestureTypes.h
-#endif
-
 namespace API {
 class Array;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163949] trunk/LayoutTests

[rniwa]

Title: [163949] trunk/LayoutTests








Revision 163949
Author rn...@webkit.org
Date 2014-02-11 22:03:36 -0800 (Tue, 11 Feb 2014)


Log Message
More Windows test rebaselines.

* platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt
trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt
trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt
trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (163948 => 163949)

--- trunk/LayoutTests/ChangeLog	2014-02-12 05:54:02 UTC (rev 163948)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 06:03:36 UTC (rev 163949)
@@ -1,3 +1,12 @@
+2014-02-11  Ryosuke Niwa  rn...@webkit.org
+
+More Windows test rebaselines.
+
+* platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
+* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
+* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
+* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
+
 2014-02-11  Zalan Bujtas  za...@apple.com
 
 transitions/shorthand-border-transitions.html became flaky. Skip it for now.


Modified: trunk/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt (163948 => 163949)

--- trunk/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt	2014-02-12 05:54:02 UTC (rev 163948)
+++ trunk/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt	2014-02-12 06:03:36 UTC (rev 163949)
@@ -1,18 +1,18 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x279
-  RenderBlock {HTML} at (0,0) size 800x280
-RenderBody {BODY} at (8,16) size 784x251
-  RenderBlock {P} at (0,0) size 784x19
-RenderText {#text} at (0,1) size 687x18
-  text run at (0,1) width 687: This tests horizontal caret movement in vertical writing mode. \\x{3042}\x{308B}\x{3002}\ and \\x{540D}\x{524D}\x{306F}\x{307E}\x{3060}\ must be selected.
-  RenderBlock {DIV} at (0,35) size 68x216
+layer at (0,0) size 800x278
+  RenderBlock {HTML} at (0,0) size 800x279
+RenderBody {BODY} at (8,16) size 784x250
+  RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 679x18
+  text run at (0,0) width 679: This tests horizontal caret movement in vertical writing mode. \\x{3042}\x{308B}\x{3002}\ and \\x{540D}\x{524D}\x{306F}\x{307E}\x{3060}\ must be selected.
+  RenderBlock {DIV} at (0,34) size 68x216
 RenderBlock {P} at (16,0) size 36x216
   RenderText {#text} at (0,0) size 18x118
 text run at (0,0) width 118: \x{543E}\x{8F29}\x{306F}\x{732B}\x{3067}\x{3042}\x{308B}\x{3002}
   RenderBR {BR} at (0,118) size 18x0
   RenderText {#text} at (18,0) size 18x119
 text run at (18,0) width 119: \x{540D}\x{524D}\x{306F}\x{307E}\x{3060}\x{7121}\x{3044}\x{3002}
-  RenderBlock {PRE} at (0,263) size 784x1
+  RenderBlock {PRE} at (0,262) size 784x1
 selection start: position 5 of child 0 {#text} of child 1 {P} of child 3 {DIV} of body
 selection end:   position 5 of child 2 {#text} of child 1 {P} of child 3 {DIV} of body


Modified: trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt (163948 => 163949)

--- trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt	2014-02-12 05:54:02 UTC (rev 163948)
+++ trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt	2014-02-12 06:03:36 UTC (rev 163949)
@@ -1,18 +1,18 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x279
-  RenderBlock {HTML} at (0,0) size 800x280
-RenderBody {BODY} at (8,16) size 784x251
-  RenderBlock {P} at (0,0) size 784x19
-RenderText {#text} at (0,1) size 687x18
-  text run at (0,1) width 687: This tests horizontal caret movement in vertical writing mode. \\x{3042}\x{308B}\x{3002}\ and \\x{540D}\x{524D}\x{306F}\x{307E}\x{3060}\ must be selected.
-  RenderBlock {DIV} at (0,35) size 68x216
+layer at (0,0) size 800x278
+  RenderBlock {HTML} at (0,0) size 800x279
+RenderBody {BODY} at (8,16) size 784x250
+  RenderBlock {P} at (0,0) 

[webkit-changes] [163950] trunk/Source/WebKit2

[fpizlo]

Title: [163950] trunk/Source/WebKit2








Revision 163950
Author fpi...@apple.com
Date 2014-02-11 22:40:54 -0800 (Tue, 11 Feb 2014)


Log Message
JIT should be enabled (regression from addition of JIT enabled setting)
https://bugs.webkit.org/show_bug.cgi?id=128653

Reviewed by Tim Horton.

* UIProcess/mac/WebContextMac.mm:
(WebKit::registerUserDefaultsIfNeeded):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (163949 => 163950)

--- trunk/Source/WebKit2/ChangeLog	2014-02-12 06:03:36 UTC (rev 163949)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-12 06:40:54 UTC (rev 163950)
@@ -1,3 +1,13 @@
+2014-02-11  Filip Pizlo  fpi...@apple.com
+
+JIT should be enabled (regression from addition of JIT enabled setting)
+https://bugs.webkit.org/show_bug.cgi?id=128653
+
+Reviewed by Tim Horton.
+
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::registerUserDefaultsIfNeeded):
+
 2014-02-11  Ryosuke Niwa  rn...@webkit.org
 
 Remove one of includes added in r163943 and r163939.


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (163949 => 163950)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-02-12 06:03:36 UTC (rev 163949)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-02-12 06:40:54 UTC (rev 163950)
@@ -96,9 +96,10 @@
 didRegister = true;
 NSMutableDictionary *registrationDictionary = [NSMutableDictionary dictionary];
 
+[registrationDictionary setObject:[NSNumber numberWithBool:YES] forKey:WebKitJSCJITEnabledDefaultsKey];
+
 #if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
 [registrationDictionary setObject:[NSNumber numberWithBool:YES] forKey:WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey];
-[registrationDictionary setObject:[NSNumber numberWithBool:YES] forKey:WebKitJSCJITEnabledDefaultsKey];
 [registrationDictionary setObject:[NSNumber numberWithBool:NO] forKey:WebKitJSCFTLEnabledDefaultsKey];
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163951] trunk/LayoutTests

[ap]

Title: [163951] trunk/LayoutTests








Revision 163951
Author a...@apple.com
Date 2014-02-11 23:06:11 -0800 (Tue, 11 Feb 2014)


Log Message
REGRESSION (r163262?): transitions/shorthand-border-transitions.html flakily asserts
https://bugs.webkit.org/show_bug.cgi?id=128283

* platform/mac/TestExpectations: Updated the expectation to match failure mode.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163950 => 163951)

--- trunk/LayoutTests/ChangeLog	2014-02-12 06:40:54 UTC (rev 163950)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 07:06:11 UTC (rev 163951)
@@ -1,3 +1,10 @@
+2014-02-11  Alexey Proskuryakov  a...@apple.com
+
+REGRESSION (r163262?): transitions/shorthand-border-transitions.html flakily asserts
+https://bugs.webkit.org/show_bug.cgi?id=128283
+
+* platform/mac/TestExpectations: Updated the expectation to match failure mode.
+
 2014-02-11  Ryosuke Niwa  rn...@webkit.org
 
 More Windows test rebaselines.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (163950 => 163951)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-02-12 06:40:54 UTC (rev 163950)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-02-12 07:06:11 UTC (rev 163951)
@@ -1265,9 +1265,6 @@
 # SubtleCrypto is disabled on Mountain Lion
 webkit.org/b/124261 [ MountainLion ] crypto/subtle [ Skip ]
 
-# Deserialization of a CryptoKey in a worker fails with a crash.
-crypto/subtle/postMessage-worker.html [ Skip ]
-
 webkit.org/b/124311 compositing/regions/transform-transparent-positioned-video-inside-region.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/124318 fullscreen/anonymous-block-merge-crash.html [ Pass Failure ]
@@ -1339,7 +1336,7 @@
 webkit.org/b/128061 svg/zoom/page/zoom-svg-through-object-with-auto-size.html [ Failure ]
 webkit.org/b/128061 tables/mozilla_expected_failures/bugs/bug1055-2.html [ Failure ]
 # debug assert on empty drawRect
-webkit.org/b/128283 transitions/shorthand-border-transitions.html [ Failure ]
+webkit.org/b/128283 [ Debug ] transitions/shorthand-border-transitions.html [ Skip ]
 # Non-uniform scaling context.
 webkit.org/b/128081 fast/events/page-scaled-mouse-click-iframe.html
 # End of subpixel failures.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163952] trunk/LayoutTests

[ap]

Title: [163952] trunk/LayoutTests








Revision 163952
Author a...@apple.com
Date 2014-02-11 23:59:59 -0800 (Tue, 11 Feb 2014)


Log Message
Undo an accidental change.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163951 => 163952)

--- trunk/LayoutTests/ChangeLog	2014-02-12 07:06:11 UTC (rev 163951)
+++ trunk/LayoutTests/ChangeLog	2014-02-12 07:59:59 UTC (rev 163952)
@@ -1,5 +1,11 @@
 2014-02-11  Alexey Proskuryakov  a...@apple.com
 
+Undo an accidental change.
+
+* platform/mac/TestExpectations:
+
+2014-02-11  Alexey Proskuryakov  a...@apple.com
+
 REGRESSION (r163262?): transitions/shorthand-border-transitions.html flakily asserts
 https://bugs.webkit.org/show_bug.cgi?id=128283
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (163951 => 163952)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-02-12 07:06:11 UTC (rev 163951)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-02-12 07:59:59 UTC (rev 163952)
@@ -1265,6 +1265,9 @@
 # SubtleCrypto is disabled on Mountain Lion
 webkit.org/b/124261 [ MountainLion ] crypto/subtle [ Skip ]
 
+# Deserialization of a CryptoKey in a worker fails with a crash.
+crypto/subtle/postMessage-worker.html [ Skip ]
+
 webkit.org/b/124311 compositing/regions/transform-transparent-positioned-video-inside-region.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/124318 fullscreen/anonymous-block-merge-crash.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes