[webkit-changes] [170911] trunk/Source/WebCore
Title: [170911] trunk/Source/WebCore Revision 170911 Author beid...@apple.com Date 2014-07-08 23:50:35 -0700 (Tue, 08 Jul 2014) Log Message DOMWindows should register themselves with the GamepadManager when they have event listeners https://bugs.webkit.org/show_bug.cgi?id=134669 Reviewed by Dean Jackson. No new tests (No effect in a currently tested config) By having DOMWindows register with the GamepadManager when they have/don’t have gamepad event listeners, we accomplish two things: 1 - It’s simple for GamepadManager to dispatch gamepad events directly to the DOMWindows interested. 2 - We know when to start monitoring for gamepad connections. * Modules/gamepad/GamepadManager.cpp: (WebCore::GamepadManager::GamepadManager): (WebCore::GamepadManager::registerNavigator): (WebCore::GamepadManager::unregisterNavigator): (WebCore::GamepadManager::registerDOMWindow): (WebCore::GamepadManager::unregisterDOMWindow): (WebCore::GamepadManager::maybeStartMonitoringGamepads): Start monitoring gamepads if there are any registered DOMWindows or NavigatorGamepads, and we aren’t already monitoring them. (WebCore::GamepadManager::maybeStopMonitoringGamepads): Stop monitoring gamepads if there aren’t any registered DOMWindows or NavigatorGameads, and we have been monitoring them before now. * Modules/gamepad/GamepadManager.h: * dom/EventNames.h: (WebCore::EventNames::isGamepadEventType): * page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::~DOMWindow): If registered for gamepad events, unregister now. (WebCore::DOMWindow::incrementGamepadEventListenerCount): If this is the first gamepad event listener, register with the GamepadManager now. (WebCore::DOMWindow::decrementGamepadEventListenerCount): If this was the last gamepad event listener, unregister from the GamepadManager now. (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): * page/DOMWindow.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/gamepad/GamepadManager.cpp trunk/Source/WebCore/Modules/gamepad/GamepadManager.h trunk/Source/WebCore/dom/EventNames.h trunk/Source/WebCore/page/DOMWindow.cpp trunk/Source/WebCore/page/DOMWindow.h Diff Modified: trunk/Source/WebCore/ChangeLog (170910 => 170911) --- trunk/Source/WebCore/ChangeLog 2014-07-09 05:56:45 UTC (rev 170910) +++ trunk/Source/WebCore/ChangeLog 2014-07-09 06:50:35 UTC (rev 170911) @@ -1,3 +1,43 @@ +2014-07-08 Brady Eidson beid...@apple.com + +DOMWindows should register themselves with the GamepadManager when they have event listeners +https://bugs.webkit.org/show_bug.cgi?id=134669 + +Reviewed by Dean Jackson. + +No new tests (No effect in a currently tested config) + +By having DOMWindows register with the GamepadManager when they have/don’t have gamepad event +listeners, we accomplish two things: +1 - It’s simple for GamepadManager to dispatch gamepad events directly to the DOMWindows interested. +2 - We know when to start monitoring for gamepad connections. + +* Modules/gamepad/GamepadManager.cpp: +(WebCore::GamepadManager::GamepadManager): +(WebCore::GamepadManager::registerNavigator): +(WebCore::GamepadManager::unregisterNavigator): +(WebCore::GamepadManager::registerDOMWindow): +(WebCore::GamepadManager::unregisterDOMWindow): +(WebCore::GamepadManager::maybeStartMonitoringGamepads): Start monitoring gamepads if there are any + registered DOMWindows or NavigatorGamepads, and we aren’t already monitoring them. +(WebCore::GamepadManager::maybeStopMonitoringGamepads): Stop monitoring gamepads if there aren’t any + registered DOMWindows or NavigatorGameads, and we have been monitoring them before now. +* Modules/gamepad/GamepadManager.h: + +* dom/EventNames.h: +(WebCore::EventNames::isGamepadEventType): + +* page/DOMWindow.cpp: +(WebCore::DOMWindow::DOMWindow): +(WebCore::DOMWindow::~DOMWindow): If registered for gamepad events, unregister now. +(WebCore::DOMWindow::incrementGamepadEventListenerCount): If this is the first gamepad event + listener, register with the GamepadManager now. +(WebCore::DOMWindow::decrementGamepadEventListenerCount): If this was the last gamepad event + listener, unregister from the GamepadManager now. +(WebCore::DOMWindow::addEventListener): +(WebCore::DOMWindow::removeEventListener): +* page/DOMWindow.h: + 2014-07-08 Sun-woo Nam sunny@samsung.com [EFL] Fix the build break when ENABLE_ENCRYPTED_MEDIA_V2 is turned on. Modified: trunk/Source/WebCore/Modules/gamepad/GamepadManager.cpp (170910 => 170911) --- trunk/Source/WebCore/Modules/gamepad/GamepadManager.cpp 2014-07-09 05:56:45 UTC (rev 170910) +++ trunk/Source/WebCore/Modules/gamepad/GamepadManager.cpp 2014-07-09 06:50:35 UTC (rev 170911) @@ -42,8
[webkit-changes] [170912] tags/Safari-538.45/
Title: [170912] tags/Safari-538.45/ Revision 170912 Author lforsch...@apple.com Date 2014-07-08 23:52:20 -0700 (Tue, 08 Jul 2014) Log Message New Tag. Added Paths tags/Safari-538.45/ Diff Property changes: tags/Safari-538.45 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170913] trunk/Source
Title: [170913] trunk/Source Revision 170913 Author lforsch...@apple.com Date 2014-07-09 00:01:48 -0700 (Wed, 09 Jul 2014) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (170912 => 170913) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-07-09 06:52:20 UTC (rev 170912) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-07-09 07:01:48 UTC (rev 170913) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 45; +MINOR_VERSION = 46; TINY_VERSION = 0; MICRO_VERSION = 0; NANO_VERSION = 0; Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (170912 => 170913) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2014-07-09 06:52:20 UTC (rev 170912) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2014-07-09 07:01:48 UTC (rev 170913) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 45; +MINOR_VERSION = 46; TINY_VERSION = 0; MICRO_VERSION = 0; NANO_VERSION = 0; Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (170912 => 170913) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-07-09 06:52:20 UTC (rev 170912) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-07-09 07:01:48 UTC (rev 170913) @@ -1,5 +1,5 @@ MAJOR_VERSION = 538; -MINOR_VERSION = 45; +MINOR_VERSION = 46; TINY_VERSION = 0; MICRO_VERSION = 0; NANO_VERSION = 0; Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (170912 => 170913) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-07-09 06:52:20 UTC (rev 170912) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-07-09 07:01:48 UTC (rev 170913) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 45; +MINOR_VERSION = 46; TINY_VERSION = 0; MICRO_VERSION = 0; NANO_VERSION = 0; Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (170912 => 170913) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-07-09 06:52:20 UTC (rev 170912) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-07-09 07:01:48 UTC (rev 170913) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 45; +MINOR_VERSION = 46; TINY_VERSION = 0; MICRO_VERSION = 0; NANO_VERSION = 0; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170914] trunk/Source/WebKit2
Title: [170914] trunk/Source/WebKit2
Revision 170914
Author commit-qu...@webkit.org
Date 2014-07-09 00:29:18 -0700 (Wed, 09 Jul 2014)
Log Message
[EFL] Fix crash caused by invalid cursor image.
https://bugs.webkit.org/show_bug.cgi?id=134663
Patch by KwangHyuk Kim hyuki@samsung.com on 2014-07-09
Reviewed by Gyuyoung Kim.
Remove calling of updateCursor since the custom cursor image is invalid once a mouse is out of the webview.
* UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandlerEVAS_CALLBACK_MOUSE_IN::handleEvent):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp
Property Changed
trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170913 => 170914)
--- trunk/Source/WebKit2/ChangeLog 2014-07-09 07:01:48 UTC (rev 170913)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-09 07:29:18 UTC (rev 170914)
@@ -1,3 +1,15 @@
+2014-07-09 KwangHyuk Kim hyuki@samsung.com
+
+[EFL] Fix crash caused by invalid cursor image.
+https://bugs.webkit.org/show_bug.cgi?id=134663
+
+Reviewed by Gyuyoung Kim.
+
+Remove calling of updateCursor since the custom cursor image is invalid once a mouse is out of the webview.
+
+* UIProcess/API/efl/EwkView.cpp:
+(EwkViewEventHandlerEVAS_CALLBACK_MOUSE_IN::handleEvent):
+
2014-07-08 Tim Horton timothy_hor...@apple.com
Remove WebBackForwardListItems when their owning page goes away
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp (170913 => 170914)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2014-07-09 07:01:48 UTC (rev 170913)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2014-07-09 07:29:18 UTC (rev 170914)
@@ -219,10 +219,9 @@
template
void EwkViewEventHandlerEVAS_CALLBACK_MOUSE_IN::handleEvent(void* data, Evas*, Evas_Object*, void*)
{
-Ewk_View_Smart_Data* smartData = static_castEwk_View_Smart_Data*(data);
-EwkView* self = toEwkView(smartData);
-
-self-updateCursor();
+// FIXME: self-updateCursor(); was removed in order to fix crash caused by invalid cursor image.
+// new cursor implementation should be added for curso image restoration previously used for.
+notImplemented();
}
template
Property changes on: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp
___
Added: svn:executable
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170915] trunk/Tools
Title: [170915] trunk/Tools Revision 170915 Author commit-qu...@webkit.org Date 2014-07-09 02:12:53 -0700 (Wed, 09 Jul 2014) Log Message Unreviewed, rolling out r170889. https://bugs.webkit.org/show_bug.cgi?id=134754 This patch is wrong (Requested by philn on #webkit). Reverted changeset: [GTK] Gstreamer missing from the install-dependencies script https://bugs.webkit.org/show_bug.cgi?id=134727 http://trac.webkit.org/changeset/170889 Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/install-dependencies Diff Modified: trunk/Tools/ChangeLog (170914 => 170915) --- trunk/Tools/ChangeLog 2014-07-09 07:29:18 UTC (rev 170914) +++ trunk/Tools/ChangeLog 2014-07-09 09:12:53 UTC (rev 170915) @@ -1,3 +1,16 @@ +2014-07-09 Commit Queue commit-qu...@webkit.org + +Unreviewed, rolling out r170889. +https://bugs.webkit.org/show_bug.cgi?id=134754 + +This patch is wrong (Requested by philn on #webkit). + +Reverted changeset: + +[GTK] Gstreamer missing from the install-dependencies script +https://bugs.webkit.org/show_bug.cgi?id=134727 +http://trac.webkit.org/changeset/170889 + 2014-07-08 Brian J. Burg b...@cs.washington.edu resolve-ChangeLogs fails when WebKit repository is a git submodule Modified: trunk/Tools/gtk/install-dependencies (170914 => 170915) --- trunk/Tools/gtk/install-dependencies 2014-07-09 07:29:18 UTC (rev 170914) +++ trunk/Tools/gtk/install-dependencies 2014-07-09 09:12:53 UTC (rev 170915) @@ -56,8 +56,6 @@ libgl1-mesa-dev \ libgl1-mesa-glx \ libgnutls-dev \ -libgstreamer1.0-dev \ -libgstreamer-plugins-base1.0-dev \ libgtk2.0-dev \ libgtk-3-dev \ libgudev-1.0-dev \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170916] trunk/LayoutTests
Title: [170916] trunk/LayoutTests Revision 170916 Author commit-qu...@webkit.org Date 2014-07-09 06:54:16 -0700 (Wed, 09 Jul 2014) Log Message [GTK] Unreviewed GTK gardening. Patch by Carlos Alberto Lopez Perez clo...@igalia.com on 2014-07-09 * platform/gtk/TestExpectations: Report and mark new failing and flaky tests. Adjust some tests expectations. * platform/gtk/css1/formatting_model/inline_elements-expected.txt: Rebaseline after r170875. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/css1/formatting_model/inline_elements-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (170915 => 170916) --- trunk/LayoutTests/ChangeLog 2014-07-09 09:12:53 UTC (rev 170915) +++ trunk/LayoutTests/ChangeLog 2014-07-09 13:54:16 UTC (rev 170916) @@ -1,3 +1,10 @@ +2014-07-09 Carlos Alberto Lopez Perez clo...@igalia.com + +[GTK] Unreviewed GTK gardening. + +* platform/gtk/TestExpectations: Report and mark new failing and flaky tests. Adjust some tests expectations. +* platform/gtk/css1/formatting_model/inline_elements-expected.txt: Rebaseline after r170875. + 2014-07-08 Alex Christensen achristen...@webkit.org Remove webkit prefix from pointer lock tests. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (170915 => 170916) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-09 09:12:53 UTC (rev 170915) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-09 13:54:16 UTC (rev 170916) @@ -417,6 +417,7 @@ webkit.org/b/131347 fast/hidpi/image-srcset-simple-2x.html [ Failure ] webkit.org/b/131347 fast/hidpi/image-srcset-src-selection-2x.html [ Failure ] webkit.org/b/131347 fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html [ ImageOnlyFailure ] +webkit.org/b/131347 fast/inline/hidpi-inline-text-decoration-with-subpixel-value.html [ ImageOnlyFailure ] webkit.org/b/131347 fast/inline/hidpi-pixel-gap-between-adjacent-selection-inlines.html [ ImageOnlyFailure ] webkit.org/b/131347 fast/inline/hidpi-select-inline-on-subpixel-position.html [ ImageOnlyFailure ] webkit.org/b/131347 fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html [ ImageOnlyFailure ] @@ -659,6 +660,7 @@ webkit.org/b/105191 media/video-playing-and-pause.html [ Failure Pass ] +webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html [ Failure Pass ] webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html [ Failure Pass ] webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html [ Failure Pass ] webkit.org/b/105280 http/tests/xmlhttprequest/cross-site-denied-response.html [ Failure Pass ] @@ -783,8 +785,9 @@ webkit.org/b/132184 fast/multicol/span/span-as-immediate-columns-child-dynamic.html [ Failure Pass ] webkit.org/b/132185 platform/gtk/editing/pasteboard/middle-button-paste.html [ Failure Pass ] -#Some media fragment tests are flaky +# Some media fragment tests are flaky webkit.org/b/132864 media/media-fragments/TC0005.html [ Failure Pass ] +webkit.org/b/132248 media/media-fragments/TC0006.html [ Failure Pass ] webkit.org/b/132248 media/media-fragments/TC0037.html [ Failure Pass ] webkit.org/b/132248 media/media-fragments/TC0078.html [ Failure Pass ] webkit.org/b/132248 media/media-fragments/TC0079.html [ Failure Pass ] @@ -865,11 +868,19 @@ webkit.org/b/134573 media/track/audio-track.html [ Failure Timeout Pass ] webkit.org/b/134574 media/media-fragments/TC0024.html [ Failure Timeout Pass ] webkit.org/b/134575 http/tests/media/hls/video-controls-live-stream.html [ Crash Failure Timeout Pass ] +webkit.org/b/134576 media/track/audio/audio-track-mkv-vorbis-language.html [ Failure Timeout Pass ] +webkit.org/b/134576 media/track/track-cue-rendering.html [ Failure Timeout Pass ] webkit.org/b/134576 media/track/video/video-track-mkv-theora-selected.html [ Failure Timeout Pass ] +webkit.org/b/134576 media/track/video/video-track-mkv-theora-language.html [ Failure Timeout Pass ] webkit.org/b/134577 svg/dom/svg-root-lengths.html [ Failure Timeout Pass ] webkit.org/b/103383 fast/css/counters/element-removal-crash.xhtml [ Failure Pass ] webkit.org/b/134579 fast/forms/state-restore-to-non-edited-controls.html [ Timeout Pass ] +webkit.org/b/134758 svg/custom/composited-svg-with-opacity.html [ ImageOnlyFailure Pass ] +webkit.org/b/134760 plugins/layout-in-beforeload-listener-affects-plugin-loading.html [ Failure Pass ] + +webkit.org/b/134761 svg/custom/animate-initial-pause-unpause.html [ Failure Pass ] + # # End of Flaky tests # @@ -992,7 +1003,7 @@ webkit.org/b/122571 inspector-protocol/debugger/setBreakpoint-dfg.html [ Failure Pass ]
[webkit-changes] [170918] trunk
Title: [170918] trunk
Revision 170918
Author jer.no...@apple.com
Date 2014-07-09 09:29:32 -0700 (Wed, 09 Jul 2014)
Log Message
[MSE] http/tests/media/media-source/mediasource-endofstream-invaliderror.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=134413
Reviewed by Eric Carlson.
Source/WebCore:
Update MediaSource.endOfStream() to take an optional enum instead of an optional String.
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::endOfStream):
* Modules/mediasource/MediaSource.h:
* Modules/mediasource/MediaSource.idl:
LayoutTests:
Fix an inadevntant editing error in mediasource-endofstream-invaliderror.html, and fix missing
whitespace at the end of http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt.
* http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt:
* http/tests/media/media-source/mediasource-endofstream-invaliderror.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt
trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
trunk/Source/WebCore/Modules/mediasource/MediaSource.h
trunk/Source/WebCore/Modules/mediasource/MediaSource.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (170917 => 170918)
--- trunk/LayoutTests/ChangeLog 2014-07-09 15:49:08 UTC (rev 170917)
+++ trunk/LayoutTests/ChangeLog 2014-07-09 16:29:32 UTC (rev 170918)
@@ -1,3 +1,16 @@
+2014-07-09 Jer Noble jer.no...@apple.com
+
+[MSE] http/tests/media/media-source/mediasource-endofstream-invaliderror.html is failing.
+https://bugs.webkit.org/show_bug.cgi?id=134413
+
+Reviewed by Eric Carlson.
+
+Fix an inadevntant editing error in mediasource-endofstream-invaliderror.html, and fix missing
+whitespace at the end of http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt.
+
+* http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt:
+* http/tests/media/media-source/mediasource-endofstream-invaliderror.html:
+
2014-07-09 Carlos Alberto Lopez Perez clo...@igalia.com
[GTK] Unreviewed GTK gardening.
Modified: trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt (170917 => 170918)
--- trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt 2014-07-09 15:49:08 UTC (rev 170917)
+++ trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt 2014-07-09 16:29:32 UTC (rev 170918)
@@ -2,3 +2,4 @@
PASS Test MediaSource.endOfStream() with invalid non-empty error string.
PASS Test MediaSource.endOfStream() with invalid empty error string.
PASS Test MediaSource.endOfStream() with invalid null error parameter.
+
Modified: trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror.html (170917 => 170918)
--- trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror.html 2014-07-09 15:49:08 UTC (rev 170917)
+++ trunk/LayoutTests/http/tests/media/media-source/mediasource-endofstream-invaliderror.html 2014-07-09 16:29:32 UTC (rev 170918)
@@ -30,7 +30,7 @@
function() { mediaSource.endOfStream(''); },
'endOfStream(\'\') throws TypeError');
- assert_equals(mediaSource.readyState, 'open');a
+ assert_equals(mediaSource.readyState, 'open');
test.done();
}, 'Test MediaSource.endOfStream() with invalid empty error string.');
Modified: trunk/Source/WebCore/ChangeLog (170917 => 170918)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 15:49:08 UTC (rev 170917)
+++ trunk/Source/WebCore/ChangeLog 2014-07-09 16:29:32 UTC (rev 170918)
@@ -1,3 +1,17 @@
+2014-07-09 Jer Noble jer.no...@apple.com
+
+[MSE] http/tests/media/media-source/mediasource-endofstream-invaliderror.html is failing.
+https://bugs.webkit.org/show_bug.cgi?id=134413
+
+Reviewed by Eric Carlson.
+
+Update MediaSource.endOfStream() to take an optional enum instead of an optional String.
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::endOfStream):
+* Modules/mediasource/MediaSource.h:
+* Modules/mediasource/MediaSource.idl:
+
2014-07-08 Brady Eidson beid...@apple.com
DOMWindows should register themselves with the GamepadManager when they have event listeners
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (170917 => 170918)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2014-07-09 15:49:08 UTC (rev 170917)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2014-07-09 16:29:32 UTC (rev 170918)
@@ -307,6 +307,11 @@
return sourceBuffer-updating();
}
+void
[webkit-changes] [170919] trunk/LayoutTests
Title: [170919] trunk/LayoutTests Revision 170919 Author an...@apple.com Date 2014-07-09 10:12:39 -0700 (Wed, 09 Jul 2014) Log Message fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html is failing in some bots https://bugs.webkit.org/show_bug.cgi?id=134769 * TestExpectations: Skipping the test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (170918 => 170919) --- trunk/LayoutTests/ChangeLog 2014-07-09 16:29:32 UTC (rev 170918) +++ trunk/LayoutTests/ChangeLog 2014-07-09 17:12:39 UTC (rev 170919) @@ -1,3 +1,10 @@ +2014-07-09 Antti Koivisto an...@apple.com + +fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html is failing in some bots +https://bugs.webkit.org/show_bug.cgi?id=134769 + +* TestExpectations: Skipping the test. + 2014-07-09 Jer Noble jer.no...@apple.com [MSE] http/tests/media/media-source/mediasource-endofstream-invaliderror.html is failing. Modified: trunk/LayoutTests/TestExpectations (170918 => 170919) --- trunk/LayoutTests/TestExpectations 2014-07-09 16:29:32 UTC (rev 170918) +++ trunk/LayoutTests/TestExpectations 2014-07-09 17:12:39 UTC (rev 170919) @@ -126,3 +126,6 @@ webkit.org/b/132791 svg/as-object/sizing/svg-in-object-placeholder-height-auto.html [ Skip ] webkit.org/b/133057 fast/table/border-collapsing/collapsed-borders-adjoining-sections.html [ ImageOnlyFailure ] + +# Failing on some bots due to using resource load callbacks +webkit.org/b/134769 fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170920] trunk/Source/WebCore
Title: [170920] trunk/Source/WebCore Revision 170920 Author eric.carl...@apple.com Date 2014-07-09 10:17:16 -0700 (Wed, 09 Jul 2014) Log Message [iOS] caption size is sometimes incorrect in fullscreen https://bugs.webkit.org/show_bug.cgi?id=134740 Reviewed by Jer Noble. Captions on iOS are displayed in fullscreen with a TextTrackRepresentation object. Because the fullscreen video presentation is controlled by code in the UI process running on the UI thread, WebCore is notified of changes to fullscreen state asynchronously. This resulted in the TextTrackRepresentation object being created and/or destroyed too late some of the time, which caused us to sometimes display captions incorrectly. Fix this by setting up and tearing down the TextTrackRepresentation object when WebCore's 'webkitfullscreenchange' event fires. * Modules/mediacontrols/MediaControlsHost.cpp: (WebCore::MediaControlsHost::enteredFullscreen): Notify text track container. (WebCore::MediaControlsHost::exitedFullscreen): Ditto. * Modules/mediacontrols/MediaControlsHost.h: * Modules/mediacontrols/MediaControlsHost.idl: * Modules/mediacontrols/mediaControlsApple.js: (Controller.prototype.handleFullscreenChange): Notify host of fullscreen change. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::requiresTextTrackRepresentation): Only return true when in fullscreen. (WebCore::HTMLMediaElement::setVideoFullscreenLayer): Call updateTextTrackDisplay. * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize m_updateTextTrackRepresentationStyle to false. (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Move logic for creating TextTrackRepresentation to updateTextTrackRepresentation. (WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize): New, split out of updateTimerFired. (WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Move code to force immediate font size change to updateActiveCuesFontSize. (WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation): New, update text track representation, creating first if necessary. (WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation): Add an early return if we don't have a text track representation. (WebCore::MediaControlTextTrackContainerElement::updateStyleForTextTrackRepresentation): Early return if there is nothing to be done. (WebCore::MediaControlTextTrackContainerElement::enteredFullscreen): Force a caption update if there are visible captions. (WebCore::MediaControlTextTrackContainerElement::updateSizes): Set m_updateTextTrackRepresentationStyle to true. (WebCore::MediaControlTextTrackContainerElement::textTrackRepresentationBoundsChanged): Force a caption update if there are visible captions. * html/shadow/MediaControlElements.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/shadow/MediaControlElements.cpp trunk/Source/WebCore/html/shadow/MediaControlElements.h Diff Modified: trunk/Source/WebCore/ChangeLog (170919 => 170920) --- trunk/Source/WebCore/ChangeLog 2014-07-09 17:12:39 UTC (rev 170919) +++ trunk/Source/WebCore/ChangeLog 2014-07-09 17:17:16 UTC (rev 170920) @@ -1,3 +1,54 @@ +2014-07-09 Eric Carlson eric.carl...@apple.com + +[iOS] caption size is sometimes incorrect in fullscreen +https://bugs.webkit.org/show_bug.cgi?id=134740 + +Reviewed by Jer Noble. + +Captions on iOS are displayed in fullscreen with a TextTrackRepresentation object. Because +the fullscreen video presentation is controlled by code in the UI process running on the +UI thread, WebCore is notified of changes to fullscreen state asynchronously. This resulted +in the TextTrackRepresentation object being created and/or destroyed too late some of the +time, which caused us to sometimes display captions incorrectly. Fix this by setting up and +tearing down the TextTrackRepresentation object when WebCore's 'webkitfullscreenchange' +event fires. + +* Modules/mediacontrols/MediaControlsHost.cpp: +(WebCore::MediaControlsHost::enteredFullscreen): Notify text track container. +(WebCore::MediaControlsHost::exitedFullscreen): Ditto. +* Modules/mediacontrols/MediaControlsHost.h: +* Modules/mediacontrols/MediaControlsHost.idl: + +* Modules/mediacontrols/mediaControlsApple.js: +(Controller.prototype.handleFullscreenChange): Notify host of fullscreen change. + +* html/HTMLMediaElement.cpp: +
[webkit-changes] [170921] trunk/Source/WebCore
Title: [170921] trunk/Source/WebCore
Revision 170921
Author achristen...@apple.com
Date 2014-07-09 10:49:59 -0700 (Wed, 09 Jul 2014)
Log Message
Added css jit profiler, disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=134695
Reviewed by Benjamin Poulain.
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
Tell the RuleData when its compiled selector is used.
* css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
Initialize the compiled selector use count to 0.
* css/RuleSet.h:
(WebCore::RuleData::~RuleData):
(WebCore::RuleData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.
* cssjit/SelectorCompiler.h:
Added option for CSS_SELECTOR_JIT_PROFILING set to 0 by default.
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::execute):
Tell the SelectorData when its compiled selector is used.
* dom/SelectorQuery.h:
(WebCore::SelectorDataList::SelectorData::SelectorData):
(WebCore::SelectorDataList::SelectorData::~SelectorData):
(WebCore::SelectorDataList::SelectorData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/ElementRuleCollector.cpp
trunk/Source/WebCore/css/RuleSet.cpp
trunk/Source/WebCore/css/RuleSet.h
trunk/Source/WebCore/cssjit/SelectorCompiler.h
trunk/Source/WebCore/dom/SelectorQuery.cpp
trunk/Source/WebCore/dom/SelectorQuery.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (170920 => 170921)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 17:17:16 UTC (rev 170920)
+++ trunk/Source/WebCore/ChangeLog 2014-07-09 17:49:59 UTC (rev 170921)
@@ -1,3 +1,32 @@
+2014-07-09 Alex Christensen achristen...@webkit.org
+
+Added css jit profiler, disabled by default.
+https://bugs.webkit.org/show_bug.cgi?id=134695
+
+Reviewed by Benjamin Poulain.
+
+* css/ElementRuleCollector.cpp:
+(WebCore::ElementRuleCollector::ruleMatches):
+Tell the RuleData when its compiled selector is used.
+* css/RuleSet.cpp:
+(WebCore::RuleData::RuleData):
+Initialize the compiled selector use count to 0.
+* css/RuleSet.h:
+(WebCore::RuleData::~RuleData):
+(WebCore::RuleData::compiledSelectorUsed):
+Count and log the number of times a compiled selector is used.
+* cssjit/SelectorCompiler.h:
+Added option for CSS_SELECTOR_JIT_PROFILING set to 0 by default.
+* dom/SelectorQuery.cpp:
+(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
+(WebCore::SelectorDataList::execute):
+Tell the SelectorData when its compiled selector is used.
+* dom/SelectorQuery.h:
+(WebCore::SelectorDataList::SelectorData::SelectorData):
+(WebCore::SelectorDataList::SelectorData::~SelectorData):
+(WebCore::SelectorDataList::SelectorData::compiledSelectorUsed):
+Count and log the number of times a compiled selector is used.
+
2014-07-09 Eric Carlson eric.carl...@apple.com
[iOS] caption size is sometimes incorrect in fullscreen
Modified: trunk/Source/WebCore/css/ElementRuleCollector.cpp (170920 => 170921)
--- trunk/Source/WebCore/css/ElementRuleCollector.cpp 2014-07-09 17:17:16 UTC (rev 170920)
+++ trunk/Source/WebCore/css/ElementRuleCollector.cpp 2014-07-09 17:49:59 UTC (rev 170921)
@@ -303,6 +303,9 @@
if (ruleData.compilationStatus() == SelectorCompilationStatus::SimpleSelectorChecker) {
SelectorCompiler::SimpleSelectorChecker selectorChecker = SelectorCompiler::simpleSelectorCheckerFunction(compiledSelectorChecker, ruleData.compilationStatus());
+#if CSS_SELECTOR_JIT_PROFILING
+ruleData.compiledSelectorUsed();
+#endif
return selectorChecker(m_element);
}
ASSERT(ruleData.compilationStatus() == SelectorCompilationStatus::SelectorCheckerWithCheckingContext);
@@ -311,6 +314,9 @@
SelectorCompiler::CheckingContext context;
context.elementStyle = m_style;
context.resolvingMode = m_mode;
+#if CSS_SELECTOR_JIT_PROFILING
+ruleData.compiledSelectorUsed();
+#endif
return selectorChecker(m_element, context);
}
#endif // ENABLE(CSS_SELECTOR_JIT)
Modified: trunk/Source/WebCore/css/RuleSet.cpp (170920 => 170921)
--- trunk/Source/WebCore/css/RuleSet.cpp 2014-07-09 17:17:16 UTC (rev 170920)
+++ trunk/Source/WebCore/css/RuleSet.cpp 2014-07-09 17:49:59 UTC (rev 170921)
@@ -140,6 +140,9 @@
, m_linkMatchType(SelectorChecker::determineLinkMatchType(selector()))
, m_hasDocumentSecurityOrigin(addRuleFlags RuleHasDocumentSecurityOrigin)
, m_propertyWhitelistType(determinePropertyWhitelistType(addRuleFlags, selector()))
+#if ENABLE(CSS_SELECTOR_JIT) CSS_SELECTOR_JIT_PROFILING
+, m_compiledSelectorUseCount(0)
+#endif
{
ASSERT(m_position == position);
[webkit-changes] [170922] trunk
Title: [170922] trunk
Revision 170922
Author bfulg...@apple.com
Date 2014-07-09 11:05:06 -0700 (Wed, 09 Jul 2014)
Log Message
[Win] Remove use of 'grep' in build steps
https://bugs.webkit.org/show_bug.cgi?id=134770
rdar://problem/17608783
Reviewed by Tim Horton.
Replace uses of the grep command in Windows builds with the equivalent
Perl program.
Source/_javascript_Core:
* _javascript_Core.vcxproj/_javascript_CorePreBuild.cmd:
* _javascript_Core.vcxproj/jsc/jscPreBuild.cmd:
* _javascript_Core.vcxproj/testRegExp/testRegExpPreBuild.cmd:
* _javascript_Core.vcxproj/testapi/testapiPreBuild.cmd:
Source/WebCore:
* WebCore.vcxproj/WebCoreGenerated.make:
* WebCore.vcxproj/WebCorePreBuild.cmd:
* platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::notifyFinished):
Source/WebKit:
* WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
* WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
* WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd:
Source/WTF:
* WTF.vcxproj/WTFPreBuild.cmd:
Tools:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
* WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CorePreBuild.cmd
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/jsc/jscPreBuild.cmd
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/testRegExp/testRegExpPreBuild.cmd
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/testapi/testapiPreBuild.cmd
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.vcxproj/WTFPreBuild.cmd
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCoreGenerated.make
trunk/Source/WebCore/WebCore.vcxproj/WebCorePreBuild.cmd
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd
trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPreBuild.cmd
trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd
trunk/Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd
trunk/Tools/DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd
trunk/Tools/DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd
trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd
trunk/Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd
trunk/Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (170921 => 170922)
--- trunk/Source/_javascript_Core/ChangeLog 2014-07-09 17:49:59 UTC (rev 170921)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-07-09 18:05:06 UTC (rev 170922)
@@ -1,3 +1,19 @@
+2014-07-09 Brent Fulgham bfulg...@apple.com
+
+[Win] Remove use of 'grep' in build steps
+https://bugs.webkit.org/show_bug.cgi?id=134770
+rdar://problem/17608783
+
+Reviewed by Tim Horton.
+
+Replace uses of the grep command in Windows builds with the equivalent
+Perl program.
+
+* _javascript_Core.vcxproj/_javascript_CorePreBuild.cmd:
+* _javascript_Core.vcxproj/jsc/jscPreBuild.cmd:
+* _javascript_Core.vcxproj/testRegExp/testRegExpPreBuild.cmd:
+* _javascript_Core.vcxproj/testapi/testapiPreBuild.cmd:
+
2014-07-08 Benjamin Poulain benja...@webkit.org
Restore the assertion changed with 170839
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CorePreBuild.cmd (170921 => 170922)
--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CorePreBuild.cmd 2014-07-09 17:49:59 UTC (rev 170921)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CorePreBuild.cmd 2014-07-09 18:05:06 UTC (rev 170922)
@@ -1,6 +1,6 @@
-%SystemDrive%\cygwin\bin\which.exe bash
+%SystemDrive%\cygwin\bin\which.exe perl
if errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%
cmd /c
-if exist %CONFIGURATIONBUILDDIR%\buildfailed grep XX%PROJECTNAME%XX %CONFIGURATIONBUILDDIR%\buildfailed
+if exist %CONFIGURATIONBUILDDIR%\buildfailed perl -wnne if (/XX%PROJECTNAME%XX/) { print } else { exit 1 } %CONFIGURATIONBUILDDIR%\buildfailed
if errorlevel 1 exit 1
echo XX%PROJECTNAME%XX %CONFIGURATIONBUILDDIR%\buildfailed
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/jsc/jscPreBuild.cmd (170921 => 170922)
--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/jsc/jscPreBuild.cmd
[webkit-changes] [170923] trunk/Source/WebKit2
Title: [170923] trunk/Source/WebKit2
Revision 170923
Author ander...@apple.com
Date 2014-07-09 12:10:21 -0700 (Wed, 09 Jul 2014)
Log Message
RemoteLayerBackingStore::ensureBackingStore should ensure that the entire backing store gets redrawn
https://bugs.webkit.org/show_bug.cgi?id=134772
Reviewed by Tim Horton.
* Shared/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::Buffer::operator bool):
* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::ensureBackingStore):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170922 => 170923)
--- trunk/Source/WebKit2/ChangeLog 2014-07-09 18:05:06 UTC (rev 170922)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-09 19:10:21 UTC (rev 170923)
@@ -1,3 +1,15 @@
+2014-07-09 Anders Carlsson ander...@apple.com
+
+RemoteLayerBackingStore::ensureBackingStore should ensure that the entire backing store gets redrawn
+https://bugs.webkit.org/show_bug.cgi?id=134772
+
+Reviewed by Tim Horton.
+
+* Shared/mac/RemoteLayerBackingStore.h:
+(WebKit::RemoteLayerBackingStore::Buffer::operator bool):
+* Shared/mac/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::ensureBackingStore):
+
2014-07-09 KwangHyuk Kim hyuki@samsung.com
[EFL] Fix crash caused by invalid cursor image.
Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h (170922 => 170923)
--- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h 2014-07-09 18:05:06 UTC (rev 170922)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h 2014-07-09 19:10:21 UTC (rev 170923)
@@ -112,6 +112,18 @@
bool isVolatile = false;
#endif
+explicit operator bool() const
+{
+#if USE(IOSURFACE)
+if (surface)
+return true;
+#endif
+if (bitmap)
+return true;
+
+return false;
+}
+
void discard();
};
Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm (170922 => 170923)
--- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-07-09 18:05:06 UTC (rev 170922)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-07-09 19:10:21 UTC (rev 170923)
@@ -86,6 +86,12 @@
m_acceleratesDrawing = acceleratesDrawing;
m_isOpaque = isOpaque;
+if (m_frontBuffer) {
+// If we have a valid backing store, we need to ensure that it gets completely
+// repainted the next time display() is called.
+setNeedsDisplay();
+}
+
clearBackingStore();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170924] trunk/Source
Title: [170924] trunk/Source
Revision 170924
Author enr...@apple.com
Date 2014-07-09 12:11:47 -0700 (Wed, 09 Jul 2014)
Log Message
Implement Editor::fontAttributesForSelectionStart() or iOS.
https://bugs.webkit.org/show_bug.cgi?id=134771
rdar://problem/16167838
Reviewed by Ryosuke Niwa.
Source/WebCore:
Implement for iOS the equivalent function we have for OS X.
* editing/ios/EditorIOS.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
Source/WebKit/mac:
* WebView/WebViewPrivate.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ios/EditorIOS.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebViewPrivate.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (170923 => 170924)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 19:10:21 UTC (rev 170923)
+++ trunk/Source/WebCore/ChangeLog 2014-07-09 19:11:47 UTC (rev 170924)
@@ -1,3 +1,16 @@
+2014-07-09 Enrica Casucci enr...@apple.com
+
+Implement Editor::fontAttributesForSelectionStart() or iOS.
+https://bugs.webkit.org/show_bug.cgi?id=134771
+rdar://problem/16167838
+
+Reviewed by Ryosuke Niwa.
+
+Implement for iOS the equivalent function we have for OS X.
+
+* editing/ios/EditorIOS.mm:
+(WebCore::Editor::fontAttributesForSelectionStart):
+
2014-07-09 Brent Fulgham bfulg...@apple.com
[Win] Remove use of 'grep' in build steps
Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (170923 => 170924)
--- trunk/Source/WebCore/editing/ios/EditorIOS.mm 2014-07-09 19:10:21 UTC (rev 170923)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm 2014-07-09 19:11:47 UTC (rev 170924)
@@ -80,6 +80,12 @@
#define kUTTagClassFilenameExtension getkUTTagClassFilenameExtension()
#define kUTTagClassMIMEType getkUTTagClassMIMEType()
+SOFT_LINK_PRIVATE_FRAMEWORK(UIFoundation)
+SOFT_LINK_CONSTANT(UIFoundation, NSFontAttributeName, NSString *)
+#define NSFontAttributeName getNSFontAttributeName()
+SOFT_LINK_CONSTANT(UIFoundation, NSUnderlineStyleAttributeName, NSString *)
+#define NSUnderlineStyleAttributeName getNSUnderlineStyleAttributeName()
+
@interface NSAttributedString (NSAttributedStringKitAdditions)
- (id)initWithRTF:(NSData *)data documentAttributes:(NSDictionary **)dict;
- (id)initWithRTFD:(NSData *)data documentAttributes:(NSDictionary **)dict;
@@ -88,6 +94,21 @@
- (BOOL)containsAttachments;
@end
+typedef NS_ENUM(NSInteger, NSUnderlineStyle) {
+NSUnderlineStyleNone= 0x00,
+NSUnderlineStyleSingle = 0x01,
+NSUnderlineStyleThick NS_ENUM_AVAILABLE_IOS(7_0)= 0x02,
+NSUnderlineStyleDouble NS_ENUM_AVAILABLE_IOS(7_0) = 0x09,
+
+NSUnderlinePatternSolid NS_ENUM_AVAILABLE_IOS(7_0) = 0x,
+NSUnderlinePatternDot NS_ENUM_AVAILABLE_IOS(7_0)= 0x0100,
+NSUnderlinePatternDash NS_ENUM_AVAILABLE_IOS(7_0) = 0x0200,
+NSUnderlinePatternDashDot NS_ENUM_AVAILABLE_IOS(7_0)= 0x0300,
+NSUnderlinePatternDashDotDot NS_ENUM_AVAILABLE_IOS(7_0) = 0x0400,
+
+NSUnderlineByWord NS_ENUM_AVAILABLE_IOS(7_0) = 0x8000
+};
+
namespace WebCore {
using namespace HTMLNames;
@@ -238,6 +259,17 @@
return nil;
NSMutableDictionary* result = [NSMutableDictionary dictionary];
+
+CTFontRef font = style-font().primaryFont()-getCTFont();
+if (font)
+[result setObject:(id)font forKey:NSFontAttributeName];
+
+if (style-textDecorationsInEffect() TextDecorationUnderline)
+[result setObject:[NSNumber numberWithInt:NSUnderlineStyleSingle] forKey:NSUnderlineStyleAttributeName];
+
+if (nodeToRemove)
+nodeToRemove-remove(ASSERT_NO_EXCEPTION);
+
return result;
}
Modified: trunk/Source/WebKit/mac/ChangeLog (170923 => 170924)
--- trunk/Source/WebKit/mac/ChangeLog 2014-07-09 19:10:21 UTC (rev 170923)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-07-09 19:11:47 UTC (rev 170924)
@@ -1,3 +1,13 @@
+2014-07-09 Enrica Casucci enr...@apple.com
+
+Implement Editor::fontAttributesForSelectionStart() or iOS.
+https://bugs.webkit.org/show_bug.cgi?id=134771
+rdar://problem/16167838
+
+Reviewed by Ryosuke Niwa.
+
+* WebView/WebViewPrivate.h:
+
2014-07-08 Tim Horton timothy_hor...@apple.com
[WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
Modified: trunk/Source/WebKit/mac/WebView/WebViewPrivate.h (170923 => 170924)
--- trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2014-07-09 19:10:21 UTC (rev 170923)
+++ trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2014-07-09 19:11:47 UTC (rev 170924)
@@ -184,6 +184,7 @@
@interface WebView (WebViewEditingActionsPendingPublic)
- (void)outdent:(id)sender;
+- (NSDictionary *)typingAttributes;
@end
@@ -972,6 +973,7 @@
- (void)initializationAllowedWebView:(WebView *)webView;
- (void)initializationDeniedWebView:(WebView *)webView;
@end
+
#endif
[webkit-changes] [170925] trunk/Source
Title: [170925] trunk/Source
Revision 170925
Author timothy_hor...@apple.com
Date 2014-07-09 12:31:33 -0700 (Wed, 09 Jul 2014)
Log Message
Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path
https://bugs.webkit.org/show_bug.cgi?id=134773
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
* UIProcess/mac/ViewSnapshotStore.h:
* UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::ViewSnapshotStore):
(WebKit::ViewSnapshotStore::~ViewSnapshotStore):
(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshot::clearImage):
(WebKit::ViewSnapshot::asLayerContents):
(WebKit::createIOSurfaceFromImage): Deleted.
(WebKit::compressImageAsJPEG): Deleted.
(WebKit::ViewSnapshotStore::reduceSnapshotMemoryCost): Deleted.
(WebKit::ViewSnapshotStore::didCompressSnapshot): Deleted.
Remove all ViewSnapshot(Store) code related to JPEG-encoded snapshots.
Remove the image member on ViewSnapshot; Mac will always start out with an IOSurface instead.
Adopt WebCore::IOSurface::createFromImage to make that happen.
Add a comment noting that if a snapshot comes back empty, we should throw it away completely.
* WebCore.exp.in:
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
(IOSurface::createFromImage):
Move make-an-IOSurface-from-a-CGImageRef into WebCore::IOSurface.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h
trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (170924 => 170925)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 19:11:47 UTC (rev 170924)
+++ trunk/Source/WebCore/ChangeLog 2014-07-09 19:31:33 UTC (rev 170925)
@@ -1,3 +1,16 @@
+2014-07-09 Tim Horton timothy_hor...@apple.com
+
+Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path
+https://bugs.webkit.org/show_bug.cgi?id=134773
+
+Reviewed by Anders Carlsson.
+
+* WebCore.exp.in:
+* platform/graphics/cocoa/IOSurface.h:
+* platform/graphics/cocoa/IOSurface.mm:
+(IOSurface::createFromImage):
+Move make-an-IOSurface-from-a-CGImageRef into WebCore::IOSurface.
+
2014-07-09 Enrica Casucci enr...@apple.com
Implement Editor::fontAttributesForSelectionStart() or iOS.
Modified: trunk/Source/WebCore/WebCore.exp.in (170924 => 170925)
--- trunk/Source/WebCore/WebCore.exp.in 2014-07-09 19:11:47 UTC (rev 170924)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-07-09 19:31:33 UTC (rev 170925)
@@ -1479,6 +1479,7 @@
__ZN7WebCore9HTMLNames9styleAttrE
__ZN7WebCore9HTMLNames9titleAttrE
__ZN7WebCore9HTMLNames9valueAttrE
+__ZN7WebCore9IOSurface15createFromImageEP7CGImage
__ZN7WebCore9InlineBox14adjustPositionEff
__ZN7WebCore9InlineBox14dirtyLineBoxesEv
__ZN7WebCore9InlineBox14selectionStateEv
Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h (170924 => 170925)
--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h 2014-07-09 19:11:47 UTC (rev 170924)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h 2014-07-09 19:31:33 UTC (rev 170925)
@@ -40,6 +40,7 @@
static PassRefPtrIOSurface create(IntSize, ColorSpace);
static PassRefPtrIOSurface createFromMachPort(mach_port_t, ColorSpace);
static PassRefPtrIOSurface createFromSurface(IOSurfaceRef, ColorSpace);
+static PassRefPtrIOSurface createFromImage(CGImageRef);
static IntSize maximumSize();
Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm (170924 => 170925)
--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm 2014-07-09 19:11:47 UTC (rev 170924)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm 2014-07-09 19:31:33 UTC (rev 170925)
@@ -70,6 +70,19 @@
return adoptRef(new IOSurface(surface, colorSpace));
}
+PassRefPtrIOSurface IOSurface::createFromImage(CGImageRef image)
+{
+size_t width = CGImageGetWidth(image);
+size_t height = CGImageGetHeight(image);
+
+RefPtrIOSurface surface = IOSurface::create(IntSize(width, height), ColorSpaceDeviceRGB);
+auto surfaceContext = surface-ensurePlatformContext();
+CGContextDrawImage(surfaceContext, CGRectMake(0, 0, width, height), image);
+CGContextFlush(surfaceContext);
+
+return surface.release();
+}
+
IOSurface::IOSurface(IntSize size, ColorSpace colorSpace)
: m_colorSpace(colorSpace)
, m_size(size)
Modified: trunk/Source/WebKit2/ChangeLog (170924 => 170925)
--- trunk/Source/WebKit2/ChangeLog 2014-07-09 19:11:47 UTC (rev 170924)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-09 19:31:33 UTC (rev 170925)
@@ -1,3 +1,28 @@
+2014-07-09 Tim Horton timothy_hor...@apple.com
+
+Use IOSurface
[webkit-changes] [170926] trunk/Source/WebKit2
Title: [170926] trunk/Source/WebKit2 Revision 170926 Author benja...@webkit.org Date 2014-07-09 12:47:44 -0700 (Wed, 09 Jul 2014) Log Message [iOS][WK2] subviews of the unscaled view drift out during CA animations https://bugs.webkit.org/show_bug.cgi?id=134751 Patch by Benjamin Poulain bpoul...@apple.com on 2014-07-09 Reviewed by Enrica Casucci. It is not possible to animate the WKContentView and the inverse view in such a way that the combined matrix remain the identity for every frame of the animation. This patch solves the issue by moving the unscaled view as a sibling of WKContentView instead of a child so that we do not need to update two scales simultaneously. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView initWithFrame:configuration:]): (-[WKWebView _processDidExit]): (-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]): Set the z scale to 1 or no coordinate transform will work with this view. (-[WKWebView _beginAnimatedResizeWithUpdates:]): (-[WKWebView _endAnimatedResize]): * UIProcess/ios/WKContentView.mm: (-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]): * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): Since we need to observe changes inside the animation block, the code now use KVO to observe changes of scale. (-[WKContentView cleanupInteraction]): (-[WKContentView unscaledView]): (-[WKContentView inverseScale]): (-[WKContentView observeValueForKeyPath:ofObject:change:context:]): We update the utility views as usual. The extra bits here are to deal with views coming in during an animation. If a new utility view comes in during a scaling animation, we do not want to start a new animation with the same curve to end up at the right place. To avoid any issue, we just hide the view until the animation is finished. (-[WKContentView hitTest:withEvent:]): (-[WKContentView _showTapHighlight]): (-[WKContentView _updateUnscaledView]): Deleted. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (170925 => 170926) --- trunk/Source/WebKit2/ChangeLog 2014-07-09 19:31:33 UTC (rev 170925) +++ trunk/Source/WebKit2/ChangeLog 2014-07-09 19:47:44 UTC (rev 170926) @@ -1,3 +1,44 @@ +2014-07-09 Benjamin Poulain bpoul...@apple.com + +[iOS][WK2] subviews of the unscaled view drift out during CA animations +https://bugs.webkit.org/show_bug.cgi?id=134751 + +Reviewed by Enrica Casucci. + +It is not possible to animate the WKContentView and the inverse view in such a way +that the combined matrix remain the identity for every frame of the animation. + +This patch solves the issue by moving the unscaled view as a sibling of WKContentView +instead of a child so that we do not need to update two scales simultaneously. + +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView initWithFrame:configuration:]): +(-[WKWebView _processDidExit]): +(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]): +Set the z scale to 1 or no coordinate transform will work with this view. + +(-[WKWebView _beginAnimatedResizeWithUpdates:]): +(-[WKWebView _endAnimatedResize]): +* UIProcess/ios/WKContentView.mm: +(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]): +* UIProcess/ios/WKContentViewInteraction.h: +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView setupInteraction]): +Since we need to observe changes inside the animation block, the code now use KVO to observe changes of scale. + +(-[WKContentView cleanupInteraction]): +(-[WKContentView unscaledView]): +(-[WKContentView inverseScale]): +(-[WKContentView observeValueForKeyPath:ofObject:change:context:]): +We update the utility views as usual. The extra bits here are to deal with views coming in during an animation. + +If a new utility view comes in during a scaling animation, we do not want to start a new animation with the same curve +to end up at the right place. To avoid any issue, we just hide the view until the animation is finished. + +(-[WKContentView hitTest:withEvent:]): +(-[WKContentView _showTapHighlight]): +(-[WKContentView _updateUnscaledView]): Deleted. + 2014-07-09 Tim Horton timothy_hor...@apple.com Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path Modified:
[webkit-changes] [170927] trunk/Source/WebCore
Title: [170927] trunk/Source/WebCore Revision 170927 Author timothy_hor...@apple.com Date 2014-07-09 13:52:35 -0700 (Wed, 09 Jul 2014) Log Message Fix the !USE(IOSURFACE) build. * WebCore.exp.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (170926 => 170927) --- trunk/Source/WebCore/ChangeLog 2014-07-09 19:47:44 UTC (rev 170926) +++ trunk/Source/WebCore/ChangeLog 2014-07-09 20:52:35 UTC (rev 170927) @@ -1,5 +1,11 @@ 2014-07-09 Tim Horton timothy_hor...@apple.com +Fix the !USE(IOSURFACE) build. + +* WebCore.exp.in: + +2014-07-09 Tim Horton timothy_hor...@apple.com + Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path https://bugs.webkit.org/show_bug.cgi?id=134773 Modified: trunk/Source/WebCore/WebCore.exp.in (170926 => 170927) --- trunk/Source/WebCore/WebCore.exp.in 2014-07-09 19:47:44 UTC (rev 170926) +++ trunk/Source/WebCore/WebCore.exp.in 2014-07-09 20:52:35 UTC (rev 170927) @@ -1479,7 +1479,6 @@ __ZN7WebCore9HTMLNames9styleAttrE __ZN7WebCore9HTMLNames9titleAttrE __ZN7WebCore9HTMLNames9valueAttrE -__ZN7WebCore9IOSurface15createFromImageEP7CGImage __ZN7WebCore9InlineBox14adjustPositionEff __ZN7WebCore9InlineBox14dirtyLineBoxesEv __ZN7WebCore9InlineBox14selectionStateEv @@ -3188,6 +3187,7 @@ __ZN7WebCore13IOSurfacePool11setPoolSizeEm __ZN7WebCore9IOSurface11createImageEv __ZN7WebCore9IOSurface13setIsVolatileEb +__ZN7WebCore9IOSurface15createFromImageEP7CGImage __ZN7WebCore9IOSurface18createFromMachPortEjNS_10ColorSpaceE __ZN7WebCore9IOSurface21ensureGraphicsContextEv __ZN7WebCore9IOSurface21ensurePlatformContextEv ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170928] trunk/Source
Title: [170928] trunk/Source
Revision 170928
Author psola...@apple.com
Date 2014-07-09 13:55:35 -0700 (Wed, 09 Jul 2014)
Log Message
Move resource buffering from SynchronousNetworkLoaderClient to NetworkResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=134732
Reviewed by Darin Adler.
Source/WebCore:
No new tests because no functional changes.
* WebCore.exp.in:
Source/WebKit2:
Buffer the resource in NetworkResourceLoader instead of SynchronousNetworkLoaderClient. This
is in preparation for bug 134560 where we will be supporting JS and CSS resource buffering
that uses AsynchronousNetworkLoaderClient.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
* NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::bufferedData):
* NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::SynchronousNetworkLoaderClient::didFinishLoading):
(WebKit::SynchronousNetworkLoaderClient::didFail):
(WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):
* NetworkProcess/SynchronousNetworkLoaderClient.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit2/NetworkProcess/SynchronousNetworkLoaderClient.cpp
trunk/Source/WebKit2/NetworkProcess/SynchronousNetworkLoaderClient.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (170927 => 170928)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 20:52:35 UTC (rev 170927)
+++ trunk/Source/WebCore/ChangeLog 2014-07-09 20:55:35 UTC (rev 170928)
@@ -1,3 +1,14 @@
+2014-07-09 Pratik Solanki psola...@apple.com
+
+Move resource buffering from SynchronousNetworkLoaderClient to NetworkResourceLoader
+https://bugs.webkit.org/show_bug.cgi?id=134732
+
+Reviewed by Darin Adler.
+
+No new tests because no functional changes.
+
+* WebCore.exp.in:
+
2014-07-09 Tim Horton timothy_hor...@apple.com
Fix the !USE(IOSURFACE) build.
Modified: trunk/Source/WebCore/WebCore.exp.in (170927 => 170928)
--- trunk/Source/WebCore/WebCore.exp.in 2014-07-09 20:52:35 UTC (rev 170927)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-07-09 20:55:35 UTC (rev 170928)
@@ -244,6 +244,7 @@
__ZN7WebCore12SharedBuffer12createNSDataEv
__ZN7WebCore12SharedBuffer24createWithContentsOfFileERKN3WTF6StringE
__ZN7WebCore12SharedBuffer6appendEPKcj
+__ZN7WebCore12SharedBuffer6appendEPS0_
__ZN7WebCore12SharedBufferC1EPKcj
__ZN7WebCore12SharedBufferC1EPKhj
__ZN7WebCore12SharedBufferC1Ev
Modified: trunk/Source/WebKit2/ChangeLog (170927 => 170928)
--- trunk/Source/WebKit2/ChangeLog 2014-07-09 20:52:35 UTC (rev 170927)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-09 20:55:35 UTC (rev 170928)
@@ -1,3 +1,27 @@
+2014-07-09 Pratik Solanki psola...@apple.com
+
+Move resource buffering from SynchronousNetworkLoaderClient to NetworkResourceLoader
+https://bugs.webkit.org/show_bug.cgi?id=134732
+
+Reviewed by Darin Adler.
+
+Buffer the resource in NetworkResourceLoader instead of SynchronousNetworkLoaderClient. This
+is in preparation for bug 134560 where we will be supporting JS and CSS resource buffering
+that uses AsynchronousNetworkLoaderClient.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::NetworkResourceLoader):
+(WebKit::NetworkResourceLoader::didReceiveBuffer):
+(WebKit::NetworkResourceLoader::didFinishLoading):
+* NetworkProcess/NetworkResourceLoader.h:
+(WebKit::NetworkResourceLoader::bufferedData):
+* NetworkProcess/SynchronousNetworkLoaderClient.cpp:
+(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
+(WebKit::SynchronousNetworkLoaderClient::didFinishLoading):
+(WebKit::SynchronousNetworkLoaderClient::didFail):
+(WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):
+* NetworkProcess/SynchronousNetworkLoaderClient.h:
+
2014-07-09 Benjamin Poulain bpoul...@apple.com
[iOS][WK2] subviews of the unscaled view drift out during CA animations
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (170927 => 170928)
--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2014-07-09 20:52:35 UTC (rev 170927)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2014-07-09 20:55:35 UTC (rev 170928)
@@ -99,9 +99,10 @@
ASSERT(RunLoop::isMain());
-if (reply)
+if (reply) {
m_networkLoaderClient = std::make_uniqueSynchronousNetworkLoaderClient(m_request, reply);
-else
+m_bufferedData = WebCore::SharedBuffer::create();
+} else
[webkit-changes] [170929] branches/ftlopt/Source/JavaScriptCore
Title: [170929] branches/ftlopt/Source/_javascript_Core
Revision 170929
Author fpi...@apple.com
Date 2014-07-09 14:16:17 -0700 (Wed, 09 Jul 2014)
Log Message
[ftlopt] Move Flush(SetLocal) store elimination to StrengthReductionPhase
https://bugs.webkit.org/show_bug.cgi?id=134739
Reviewed by Mark Hahnenberg.
I'm going to streamline CSE around clobberize() as part of
https://bugs.webkit.org/show_bug.cgi?id=134677, and so Flush(SetLocal) store
elimination wouldn't belong in CSE anymore. It doesn't quite belong anywhere, which
means that it belongs in StrengthReductionPhase, since that's intended to be our
dumping ground.
To do this I had to add some missing smarts to clobberize(). Previously clobberize()
could play a bit loose with reads of Variables because it wasn't used for store
elimination. The main client of read() was LICM, but it would only use it to
determine hoistability and anything that did a write() was not hoistable - so, we had
benign (but still wrong) missing read() calls in places that did write()s. This fixes
a bunch of those cases.
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::setLocalStoreElimination): Deleted.
* dfg/DFGClobberize.cpp:
(JSC::DFG::accessesOverlap):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize): Make clobberize() smart enough for detecting when this store elimination would be sound.
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode): Implement the store elimination in terms of clobberize().
Modified Paths
branches/ftlopt/Source/_javascript_Core/ChangeLog
branches/ftlopt/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
branches/ftlopt/Source/_javascript_Core/dfg/DFGClobberize.cpp
branches/ftlopt/Source/_javascript_Core/dfg/DFGClobberize.h
branches/ftlopt/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
Diff
Modified: branches/ftlopt/Source/_javascript_Core/ChangeLog (170928 => 170929)
--- branches/ftlopt/Source/_javascript_Core/ChangeLog 2014-07-09 20:55:35 UTC (rev 170928)
+++ branches/ftlopt/Source/_javascript_Core/ChangeLog 2014-07-09 21:16:17 UTC (rev 170929)
@@ -1,5 +1,35 @@
2014-07-08 Filip Pizlo fpi...@apple.com
+[ftlopt] Move Flush(SetLocal) store elimination to StrengthReductionPhase
+https://bugs.webkit.org/show_bug.cgi?id=134739
+
+Reviewed by Mark Hahnenberg.
+
+I'm going to streamline CSE around clobberize() as part of
+https://bugs.webkit.org/show_bug.cgi?id=134677, and so Flush(SetLocal) store
+elimination wouldn't belong in CSE anymore. It doesn't quite belong anywhere, which
+means that it belongs in StrengthReductionPhase, since that's intended to be our
+dumping ground.
+
+To do this I had to add some missing smarts to clobberize(). Previously clobberize()
+could play a bit loose with reads of Variables because it wasn't used for store
+elimination. The main client of read() was LICM, but it would only use it to
+determine hoistability and anything that did a write() was not hoistable - so, we had
+benign (but still wrong) missing read() calls in places that did write()s. This fixes
+a bunch of those cases.
+
+* dfg/DFGCSEPhase.cpp:
+(JSC::DFG::CSEPhase::performNodeCSE):
+(JSC::DFG::CSEPhase::setLocalStoreElimination): Deleted.
+* dfg/DFGClobberize.cpp:
+(JSC::DFG::accessesOverlap):
+* dfg/DFGClobberize.h:
+(JSC::DFG::clobberize): Make clobberize() smart enough for detecting when this store elimination would be sound.
+* dfg/DFGStrengthReductionPhase.cpp:
+(JSC::DFG::StrengthReductionPhase::handleNode): Implement the store elimination in terms of clobberize().
+
+2014-07-08 Filip Pizlo fpi...@apple.com
+
[ftlopt] Phantom simplification should be in its own phase
https://bugs.webkit.org/show_bug.cgi?id=134742
Modified: branches/ftlopt/Source/_javascript_Core/dfg/DFGCSEPhase.cpp (170928 => 170929)
--- branches/ftlopt/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2014-07-09 20:55:35 UTC (rev 170928)
+++ branches/ftlopt/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2014-07-09 21:16:17 UTC (rev 170929)
@@ -719,77 +719,6 @@
return false;
}
-Node* setLocalStoreElimination(VirtualRegister local)
-{
-for (unsigned i = m_indexInBlock; i--;) {
-Node* node = m_currentBlock-at(i);
-switch (node-op()) {
-case GetLocal:
-case Flush:
-if (node-local() == local)
-return nullptr;
-break;
-
-case GetLocalUnlinked:
-if (node-unlinkedLocal() == local)
-return nullptr;
-break;
-
-case SetLocal: {
-if (node-local() == local)
-return node;
-break;
-
[webkit-changes] [170930] trunk/Source/WebCore
Title: [170930] trunk/Source/WebCore
Revision 170930
Author psola...@apple.com
Date 2014-07-09 14:19:47 -0700 (Wed, 09 Jul 2014)
Log Message
Add SharedBuffer::wrapCFDataArray() and use it
https://bugs.webkit.org/show_bug.cgi?id=134733
Reviewed by Antti Koivisto.
No new tests. Should be covered by existing tests.
* platform/SharedBuffer.h:
* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::wrapCFDataArray):
(WebCore::SharedBuffer::SharedBuffer):
* platform/network/ResourceHandle.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::handleDataArray): Deleted.
* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
* platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray):
* platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveDataArray:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/SharedBuffer.h
trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp
trunk/Source/WebCore/platform/network/ResourceHandle.h
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp
trunk/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (170929 => 170930)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 21:16:17 UTC (rev 170929)
+++ trunk/Source/WebCore/ChangeLog 2014-07-09 21:19:47 UTC (rev 170930)
@@ -1,5 +1,30 @@
2014-07-09 Pratik Solanki psola...@apple.com
+Add SharedBuffer::wrapCFDataArray() and use it
+https://bugs.webkit.org/show_bug.cgi?id=134733
+
+Reviewed by Antti Koivisto.
+
+No new tests. Should be covered by existing tests.
+
+* platform/SharedBuffer.h:
+* platform/cf/SharedBufferCF.cpp:
+(WebCore::SharedBuffer::wrapCFDataArray):
+(WebCore::SharedBuffer::SharedBuffer):
+* platform/network/ResourceHandle.h:
+* platform/network/cf/ResourceHandleCFNet.cpp:
+(WebCore::ResourceHandle::handleDataArray): Deleted.
+* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
+(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
+* platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
+(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray):
+* platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
+(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
+* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveDataArray:]):
+
+2014-07-09 Pratik Solanki psola...@apple.com
+
Move resource buffering from SynchronousNetworkLoaderClient to NetworkResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=134732
Modified: trunk/Source/WebCore/platform/SharedBuffer.h (170929 => 170930)
--- trunk/Source/WebCore/platform/SharedBuffer.h 2014-07-09 21:16:17 UTC (rev 170929)
+++ trunk/Source/WebCore/platform/SharedBuffer.h 2014-07-09 21:19:47 UTC (rev 170930)
@@ -118,6 +118,7 @@
unsigned platformDataSize() const;
#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+static PassRefPtrSharedBuffer wrapCFDataArray(CFArrayRef);
void append(CFDataRef);
#endif
@@ -196,6 +197,7 @@
bool m_shouldUsePurgeableMemory;
mutable OwnPtrPurgeableBuffer m_purgeableBuffer;
#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+explicit SharedBuffer(CFArrayRef);
mutable VectorRetainPtrCFDataRef m_dataArray;
unsigned copySomeDataFromDataArray(const char* someData, unsigned position) const;
const char *singleDataArrayBuffer() const;
Modified: trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp (170929 => 170930)
--- trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp 2014-07-09 21:16:17 UTC (rev 170929)
+++ trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp 2014-07-09 21:19:47 UTC (rev 170930)
@@ -29,6 +29,7 @@
#include SharedBuffer.h
#include PurgeableBuffer.h
+#include wtf/cf/TypeCasts.h
#if ENABLE(DISK_IMAGE_CACHE)
#include DiskImageCacheIOS.h
@@ -112,6 +113,27 @@
}
#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+PassRefPtrSharedBuffer SharedBuffer::wrapCFDataArray(CFArrayRef cfDataArray)
+{
+
[webkit-changes] [170931] trunk/Source/WebKit/mac
Title: [170931] trunk/Source/WebKit/mac
Revision 170931
Author rn...@webkit.org
Date 2014-07-09 14:36:16 -0700 (Wed, 09 Jul 2014)
Log Message
REGRESSION(r167770): Cannot login in Evernote Safari extension
https://bugs.webkit.org/show_bug.cgi?id=134776
Reviewed by Enrica Casucci.
Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
* WebView/WebView.mm:
(-[WebView _windowChangedKeyState]):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (170930 => 170931)
--- trunk/Source/WebKit/mac/ChangeLog 2014-07-09 21:19:47 UTC (rev 170930)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-07-09 21:36:16 UTC (rev 170931)
@@ -1,3 +1,16 @@
+2014-07-09 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r167770): Cannot login in Evernote Safari extension
+https://bugs.webkit.org/show_bug.cgi?id=134776
+
+Reviewed by Enrica Casucci.
+
+Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
+so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
+
+* WebView/WebView.mm:
+(-[WebView _windowChangedKeyState]):
+
2014-07-09 Enrica Casucci enr...@apple.com
Implement Editor::fontAttributesForSelectionStart() or iOS.
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (170930 => 170931)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2014-07-09 21:19:47 UTC (rev 170930)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2014-07-09 21:36:16 UTC (rev 170931)
@@ -295,6 +295,7 @@
- (NSView *)_hitTest:(NSPoint *)aPoint dragTypes:(NSSet *)types;
- (void)_autoscrollForDraggingInfo:(id)dragInfo timeDelta:(NSTimeInterval)repeatDelta;
- (BOOL)_shouldAutoscrollForDraggingInfo:(id)dragInfo;
+- (void)_windowChangedKeyState;
@end
@interface NSWindow (WebNSWindowDetails)
@@ -5274,6 +5275,12 @@
_private-page-chrome().windowScreenDidChange((PlatformDisplayID)[self window] screen] deviceDescription] objectForKey:@NSScreenNumber] intValue]);
}
+- (void)_windowChangedKeyState
+{
+[self _updateActiveState];
+[super _windowChangedKeyState];
+}
+
- (void)windowKeyStateChanged:(NSNotification *)notification
{
[self _updateActiveState];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170932] trunk
Title: [170932] trunk
Revision 170932
Author jer.no...@apple.com
Date 2014-07-09 14:37:17 -0700 (Wed, 09 Jul 2014)
Log Message
Source/WebCore: [MSE] http/tests/media/media-source/mediasource-remove.html is failing
https://bugs.webkit.org/show_bug.cgi?id=134768
Reviewed by Eric Carlson.
Fix multiple bugs causing mediasource-remove.html to fail:
Separate out setDuration() into setDurationInternal() so that steps which require
us to run the duration change algorithm don't bail out if the SoureBuffer is
inside updating().
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):
* Modules/mediasource/MediaSource.h:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
When removing coded frames, do so starting from the first sample in the range in
decode order, so that frames dependant on removed frames are themselves removed. Add
a convenience method in SampleMap findSampleWithPresentationTime(), and rename
findSampleAfterPresentationTime() to findSampleOnOrAfterPresentationTime() to correctly
reflect what the method does, and simplify its implementation by searching the map's keys
directly.
* Modules/mediasource/SampleMap.cpp:
(WebCore::PresentationOrderSampleMap::findSampleWithPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleOnOrAfterPresentationTime):
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleAfterPresentationTime): Deleted.
* Modules/mediasource/SampleMap.h:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::decodeTimeComparator):
(WebCore::SourceBuffer::removeCodedFrames):
Throw the correct exception (INVALID_STATE_ERR) from SourceBuffer::remove().
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::remove):
LayoutTests: [MSE] http/tests/media/media-source/mediasource-remove.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=134768
Reviewed by Eric Carlson.
Update mediasource-remove.html with the correct locations of sync-samples.
* http/tests/media/media-source/mediasource-remove.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/media-source/mediasource-remove.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
trunk/Source/WebCore/Modules/mediasource/MediaSource.h
trunk/Source/WebCore/Modules/mediasource/SampleMap.cpp
trunk/Source/WebCore/Modules/mediasource/SampleMap.h
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (170931 => 170932)
--- trunk/LayoutTests/ChangeLog 2014-07-09 21:36:16 UTC (rev 170931)
+++ trunk/LayoutTests/ChangeLog 2014-07-09 21:37:17 UTC (rev 170932)
@@ -1,3 +1,14 @@
+2014-06-28 Jer Noble jer.no...@apple.com
+
+[MSE] http/tests/media/media-source/mediasource-remove.html is failing.
+https://bugs.webkit.org/show_bug.cgi?id=134768
+
+Reviewed by Eric Carlson.
+
+Update mediasource-remove.html with the correct locations of sync-samples.
+
+* http/tests/media/media-source/mediasource-remove.html:
+
2014-07-09 Antti Koivisto an...@apple.com
fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html is failing in some bots
Modified: trunk/LayoutTests/http/tests/media/media-source/mediasource-remove.html (170931 => 170932)
--- trunk/LayoutTests/http/tests/media/media-source/mediasource-remove.html 2014-07-09 21:36:16 UTC (rev 170931)
+++ trunk/LayoutTests/http/tests/media/media-source/mediasource-remove.html 2014-07-09 21:37:17 UTC (rev 170932)
@@ -187,7 +187,7 @@
{
var expectations = {
webm: ({ [3.187, + duration + ) }),
-mp4: ({ [3.021, + duration + ) }),
+mp4: ({ [3.228, + duration + ) }),
};
// Note: Range doesn't start exactly at the end of the remove range because there isn't
@@ -199,7 +199,7 @@
{
var expectations = {
webm: ({ [0.000, 1.012) [3.187, + duration + ) }),
-mp4: ({ [0.000, 1.022) [3.021, + duration + ) }),
+mp4: ({ [0.000, 1.029) [3.228, + duration + ) }),
};
// Note: The first resulting range ends slightly after start because the removal algorithm only removes
@@ -212,7 +212,7 @@
{
var expectations = {
webm: { [0.000, 1.012) },
-mp4: { [0.000, 1.022) },
+mp4: { [0.000, 1.029) },
};
removeAndCheckBufferedRanges(test, sourceBuffer, 1, Number.POSITIVE_INFINITY, expectations[subType]);
Modified: trunk/Source/WebCore/ChangeLog (170931 => 170932)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 21:36:16 UTC (rev 170931)
+++
[webkit-changes] [170933] trunk
Title: [170933] trunk
Revision 170933
Author jfernan...@igalia.com
Date 2014-07-09 14:56:05 -0700 (Wed, 09 Jul 2014)
Log Message
CSS canvas color parsing accepts invalid color identifiers
https://bugs.webkit.org/show_bug.cgi?id=134661
Reviewed by Benjamin Poulain.
Source/WebCore:
Current implementation of the CSSParser::parseSystemColor assumes
that if a valid cssValueKeywordID is got then it has to be a valid
color. Such assumption is wrong and lead to many bugs and layout
test failures.
The parseSystemFunction determines now whether the parsed color is
valid or not.
Addtionally, a new method has been added to share the logic of
determining whether a CSSValueID is a valid primitive values for
colors or not. Generally, we should avoid passing invalid color
identifiers to the theming API.
No new tests, but added additional cases to the
canvas-color-serialization.html, test-setting-canvas-color and
rgb-color-parse test.
* css/CSSParser.cpp:
(WebCore::validPrimitiveValueColor): Added.
(WebCore::parseColorValue):
(WebCore::CSSParser::parseSystemColor):
LayoutTests:
The parseSystemFunction determines now whether the parsed color is
valid or not.
The rgb-color-parser covers css style color parsing cases, which
already provide coverage for invalid color identifiers. I've added
a few more, though.
* fast/canvas/canvas-color-serialization-expected.txt:
* fast/canvas/script-tests/canvas-color-serialization.js:
* fast/css/test-setting-canvas-color-expected.txt:
* fast/css/test-setting-canvas-color.html:
* svg/dom/rgb-color-parser-expected.txt:
* svg/dom/rgb-color-parser.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/canvas-color-serialization-expected.txt
trunk/LayoutTests/fast/canvas/script-tests/canvas-color-serialization.js
trunk/LayoutTests/fast/css/test-setting-canvas-color-expected.txt
trunk/LayoutTests/fast/css/test-setting-canvas-color.html
trunk/LayoutTests/svg/dom/rgb-color-parser-expected.txt
trunk/LayoutTests/svg/dom/rgb-color-parser.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (170932 => 170933)
--- trunk/LayoutTests/ChangeLog 2014-07-09 21:37:17 UTC (rev 170932)
+++ trunk/LayoutTests/ChangeLog 2014-07-09 21:56:05 UTC (rev 170933)
@@ -1,3 +1,24 @@
+2014-07-09 Javier Fernandez jfernan...@igalia.com
+
+CSS canvas color parsing accepts invalid color identifiers
+https://bugs.webkit.org/show_bug.cgi?id=134661
+
+Reviewed by Benjamin Poulain.
+
+The parseSystemFunction determines now whether the parsed color is
+valid or not.
+
+The rgb-color-parser covers css style color parsing cases, which
+already provide coverage for invalid color identifiers. I've added
+a few more, though.
+
+* fast/canvas/canvas-color-serialization-expected.txt:
+* fast/canvas/script-tests/canvas-color-serialization.js:
+* fast/css/test-setting-canvas-color-expected.txt:
+* fast/css/test-setting-canvas-color.html:
+* svg/dom/rgb-color-parser-expected.txt:
+* svg/dom/rgb-color-parser.html:
+
2014-06-28 Jer Noble jer.no...@apple.com
[MSE] http/tests/media/media-source/mediasource-remove.html is failing.
Modified: trunk/LayoutTests/fast/canvas/canvas-color-serialization-expected.txt (170932 => 170933)
--- trunk/LayoutTests/fast/canvas/canvas-color-serialization-expected.txt 2014-07-09 21:37:17 UTC (rev 170932)
+++ trunk/LayoutTests/fast/canvas/canvas-color-serialization-expected.txt 2014-07-09 21:56:05 UTC (rev 170933)
@@ -129,6 +129,30 @@
PASS trySettingStrokeStyle(null) is '#66'
PASS trySettingFillStyle(null) is '#66'
PASS trySettingShadowColor(null) is '#66'
+PASS trySettingStrokeStyle('left') is '#66'
+PASS trySettingFillStyle('left') is '#66'
+PASS trySettingShadowColor('left') is '#66'
+PASS trySettingStrokeStyle('right') is '#66'
+PASS trySettingFillStyle('right') is '#66'
+PASS trySettingShadowColor('right') is '#66'
+PASS trySettingStrokeStyle('center') is '#66'
+PASS trySettingFillStyle('center') is '#66'
+PASS trySettingShadowColor('center') is '#66'
+PASS trySettingStrokeStyle('border') is '#66'
+PASS trySettingFillStyle('border') is '#66'
+PASS trySettingShadowColor('border') is '#66'
+PASS trySettingStrokeStyle('border-box') is '#66'
+PASS trySettingFillStyle('border-box') is '#66'
+PASS trySettingShadowColor('border-box') is '#66'
+PASS trySettingStrokeStyle('content') is '#66'
+PASS trySettingFillStyle('content') is '#66'
+PASS trySettingShadowColor('content') is '#66'
+PASS trySettingStrokeStyle('logical') is '#66'
+PASS trySettingFillStyle('logical') is '#66'
+PASS trySettingShadowColor('logical') is '#66'
+PASS trySettingStrokeStyle('visual') is '#66'
+PASS trySettingFillStyle('visual') is '#66'
+PASS trySettingShadowColor('visual') is '#66'
PASS
[webkit-changes] [170934] trunk/Source/WebKit2
Title: [170934] trunk/Source/WebKit2
Revision 170934
Author aes...@apple.com
Date 2014-07-09 14:58:13 -0700 (Wed, 09 Jul 2014)
Log Message
[iOS] WebKit can crash under QuickLookDocumentData::encode() when viewing a QuickLook preview
https://bugs.webkit.org/show_bug.cgi?id=134780
Reviewed by Tim Horton.
Don't use CFDataCreateWithBytesNoCopy() when we can't guarantee the lifetime of the copied-from DataReference
will match or exceed that of the CFDataRef. Copy the data instead.
* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveData):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170933 => 170934)
--- trunk/Source/WebKit2/ChangeLog 2014-07-09 21:56:05 UTC (rev 170933)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-09 21:58:13 UTC (rev 170934)
@@ -1,3 +1,16 @@
+2014-07-09 Andy Estes aes...@apple.com
+
+[iOS] WebKit can crash under QuickLookDocumentData::encode() when viewing a QuickLook preview
+https://bugs.webkit.org/show_bug.cgi?id=134780
+
+Reviewed by Tim Horton.
+
+Don't use CFDataCreateWithBytesNoCopy() when we can't guarantee the lifetime of the copied-from DataReference
+will match or exceed that of the CFDataRef. Copy the data instead.
+
+* WebProcess/Network/WebResourceLoader.cpp:
+(WebKit::WebResourceLoader::didReceiveData):
+
2014-07-09 Pratik Solanki psola...@apple.com
Move resource buffering from SynchronousNetworkLoaderClient to NetworkResourceLoader
Modified: trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp (170933 => 170934)
--- trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp 2014-07-09 21:56:05 UTC (rev 170933)
+++ trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp 2014-07-09 21:58:13 UTC (rev 170934)
@@ -141,8 +141,7 @@
#if USE(QUICK_LOOK)
if (m_quickLookHandle) {
-RetainPtrCFDataRef rawData = adoptCF(CFDataCreateWithBytesNoCopy(0, data.data(), data.size(), kCFAllocatorNull));
-if (m_quickLookHandle-didReceiveData(rawData.get()))
+if (m_quickLookHandle-didReceiveData(adoptCF(CFDataCreate(kCFAllocatorDefault, data.data(), data.size())).get()))
return;
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170935] trunk/Source
Title: [170935] trunk/Source
Revision 170935
Author ander...@apple.com
Date 2014-07-09 15:06:29 -0700 (Wed, 09 Jul 2014)
Log Message
Support transparent WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=134779
rdar://problem/17351058
Reviewed by Tim Horton.
Source/WebCore:
Schedule rebuilding the compositing layers if a FrameView's transparency changes.
* page/FrameView.cpp:
(WebCore::FrameView::setTransparent):
Source/WebKit2:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Call _updateScrollViewBackground instead of setting the background color.
(contentZoomScale):
Use dot notation.
(scrollViewBackgroundColor):
Helper function that returns the scroll view background color.
If the web view isn't opaque, we want the scroll view to be transparent.
(-[WKWebView _updateScrollViewBackground]):
Call scrollViewBackgroundColor.
(-[WKWebView setOpaque:]):
Call WebPageProxy::setDrawsBackground and update the scroll view background.
(-[WKWebView setBackgroundColor:]):
Call setBackgroundColor on the content view.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (170934 => 170935)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 21:58:13 UTC (rev 170934)
+++ trunk/Source/WebCore/ChangeLog 2014-07-09 22:06:29 UTC (rev 170935)
@@ -1,3 +1,16 @@
+2014-07-09 Anders Carlsson ander...@apple.com
+
+Support transparent WKWebViews
+https://bugs.webkit.org/show_bug.cgi?id=134779
+rdar://problem/17351058
+
+Reviewed by Tim Horton.
+
+Schedule rebuilding the compositing layers if a FrameView's transparency changes.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::setTransparent):
+
2014-07-09 Javier Fernandez jfernan...@igalia.com
CSS canvas color parsing accepts invalid color identifiers
https://bugs.webkit.org/show_bug.cgi?id=134661
Modified: trunk/Source/WebCore/page/FrameView.cpp (170934 => 170935)
--- trunk/Source/WebCore/page/FrameView.cpp 2014-07-09 21:58:13 UTC (rev 170934)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-07-09 22:06:29 UTC (rev 170935)
@@ -2523,7 +2523,18 @@
void FrameView::setTransparent(bool isTransparent)
{
+if (m_isTransparent == isTransparent)
+return;
+
m_isTransparent = isTransparent;
+
+RenderView* renderView = this-renderView();
+if (!renderView)
+return;
+
+RenderLayerCompositor compositor = renderView-compositor();
+compositor.setCompositingLayersNeedRebuild();
+compositor.scheduleCompositingLayerUpdate();
}
bool FrameView::hasOpaqueBackground() const
Modified: trunk/Source/WebKit2/ChangeLog (170934 => 170935)
--- trunk/Source/WebKit2/ChangeLog 2014-07-09 21:58:13 UTC (rev 170934)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-09 22:06:29 UTC (rev 170935)
@@ -1,3 +1,31 @@
+2014-07-09 Anders Carlsson ander...@apple.com
+
+Support transparent WKWebViews
+https://bugs.webkit.org/show_bug.cgi?id=134779
+rdar://problem/17351058
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView initWithFrame:configuration:]):
+Call _updateScrollViewBackground instead of setting the background color.
+
+(contentZoomScale):
+Use dot notation.
+
+(scrollViewBackgroundColor):
+Helper function that returns the scroll view background color.
+If the web view isn't opaque, we want the scroll view to be transparent.
+
+(-[WKWebView _updateScrollViewBackground]):
+Call scrollViewBackgroundColor.
+
+(-[WKWebView setOpaque:]):
+Call WebPageProxy::setDrawsBackground and update the scroll view background.
+
+(-[WKWebView setBackgroundColor:]):
+Call setBackgroundColor on the content view.
+
2014-07-09 Andy Estes aes...@apple.com
[iOS] WebKit can crash under QuickLookDocumentData::encode() when viewing a QuickLook preview
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (170934 => 170935)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-07-09 21:58:13 UTC (rev 170934)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-07-09 22:06:29 UTC (rev 170935)
@@ -277,7 +277,6 @@
[_scrollView setBouncesZoom:YES];
[self addSubview:_scrollView.get()];
-[_scrollView setBackgroundColor:[UIColor whiteColor]];
_contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds context:context configuration:WTF::move(webPageConfiguration) webView:self]);
@@ -287,8 +286,9 @@
[_contentView layer].anchorPoint = CGPointZero;
[_contentView setFrame:bounds];
-[_scrollView addSubview:_contentView.get()];
[_scrollView addSubview:[_contentView unscaledView]];
+[self _updateScrollViewBackground];
+
_viewportMetaTagWidth =
[webkit-changes] [170936] tags/Safari-538.45/Source
Title: [170936] tags/Safari-538.45/Source
Revision 170936
Author lforsch...@apple.com
Date 2014-07-09 15:33:57 -0700 (Wed, 09 Jul 2014)
Log Message
Merged r170924. rdar://problem/16167838
Modified Paths
tags/Safari-538.45/Source/WebCore/ChangeLog
tags/Safari-538.45/Source/WebCore/editing/ios/EditorIOS.mm
tags/Safari-538.45/Source/WebKit/mac/ChangeLog
tags/Safari-538.45/Source/WebKit/mac/WebView/WebViewPrivate.h
Diff
Modified: tags/Safari-538.45/Source/WebCore/ChangeLog (170935 => 170936)
--- tags/Safari-538.45/Source/WebCore/ChangeLog 2014-07-09 22:06:29 UTC (rev 170935)
+++ tags/Safari-538.45/Source/WebCore/ChangeLog 2014-07-09 22:33:57 UTC (rev 170936)
@@ -1,3 +1,20 @@
+2014-07-09 Lucas Forschler lforsch...@apple.com
+
+Merge r170924
+
+2014-07-09 Enrica Casucci enr...@apple.com
+
+Implement Editor::fontAttributesForSelectionStart() or iOS.
+https://bugs.webkit.org/show_bug.cgi?id=134771
+rdar://problem/16167838
+
+Reviewed by Ryosuke Niwa.
+
+Implement for iOS the equivalent function we have for OS X.
+
+* editing/ios/EditorIOS.mm:
+(WebCore::Editor::fontAttributesForSelectionStart):
+
2014-07-08 Eric Carlson eric.carl...@apple.com
[iOS] user caption preferences not applied
Modified: tags/Safari-538.45/Source/WebCore/editing/ios/EditorIOS.mm (170935 => 170936)
--- tags/Safari-538.45/Source/WebCore/editing/ios/EditorIOS.mm 2014-07-09 22:06:29 UTC (rev 170935)
+++ tags/Safari-538.45/Source/WebCore/editing/ios/EditorIOS.mm 2014-07-09 22:33:57 UTC (rev 170936)
@@ -80,6 +80,12 @@
#define kUTTagClassFilenameExtension getkUTTagClassFilenameExtension()
#define kUTTagClassMIMEType getkUTTagClassMIMEType()
+SOFT_LINK_PRIVATE_FRAMEWORK(UIFoundation)
+SOFT_LINK_CONSTANT(UIFoundation, NSFontAttributeName, NSString *)
+#define NSFontAttributeName getNSFontAttributeName()
+SOFT_LINK_CONSTANT(UIFoundation, NSUnderlineStyleAttributeName, NSString *)
+#define NSUnderlineStyleAttributeName getNSUnderlineStyleAttributeName()
+
@interface NSAttributedString (NSAttributedStringKitAdditions)
- (id)initWithRTF:(NSData *)data documentAttributes:(NSDictionary **)dict;
- (id)initWithRTFD:(NSData *)data documentAttributes:(NSDictionary **)dict;
@@ -88,6 +94,21 @@
- (BOOL)containsAttachments;
@end
+typedef NS_ENUM(NSInteger, NSUnderlineStyle) {
+NSUnderlineStyleNone= 0x00,
+NSUnderlineStyleSingle = 0x01,
+NSUnderlineStyleThick NS_ENUM_AVAILABLE_IOS(7_0)= 0x02,
+NSUnderlineStyleDouble NS_ENUM_AVAILABLE_IOS(7_0) = 0x09,
+
+NSUnderlinePatternSolid NS_ENUM_AVAILABLE_IOS(7_0) = 0x,
+NSUnderlinePatternDot NS_ENUM_AVAILABLE_IOS(7_0)= 0x0100,
+NSUnderlinePatternDash NS_ENUM_AVAILABLE_IOS(7_0) = 0x0200,
+NSUnderlinePatternDashDot NS_ENUM_AVAILABLE_IOS(7_0)= 0x0300,
+NSUnderlinePatternDashDotDot NS_ENUM_AVAILABLE_IOS(7_0) = 0x0400,
+
+NSUnderlineByWord NS_ENUM_AVAILABLE_IOS(7_0) = 0x8000
+};
+
namespace WebCore {
using namespace HTMLNames;
@@ -238,6 +259,17 @@
return nil;
NSMutableDictionary* result = [NSMutableDictionary dictionary];
+
+CTFontRef font = style-font().primaryFont()-getCTFont();
+if (font)
+[result setObject:(id)font forKey:NSFontAttributeName];
+
+if (style-textDecorationsInEffect() TextDecorationUnderline)
+[result setObject:[NSNumber numberWithInt:NSUnderlineStyleSingle] forKey:NSUnderlineStyleAttributeName];
+
+if (nodeToRemove)
+nodeToRemove-remove(ASSERT_NO_EXCEPTION);
+
return result;
}
Modified: tags/Safari-538.45/Source/WebKit/mac/ChangeLog (170935 => 170936)
--- tags/Safari-538.45/Source/WebKit/mac/ChangeLog 2014-07-09 22:06:29 UTC (rev 170935)
+++ tags/Safari-538.45/Source/WebKit/mac/ChangeLog 2014-07-09 22:33:57 UTC (rev 170936)
@@ -1,3 +1,17 @@
+2014-07-09 Lucas Forschler lforsch...@apple.com
+
+Merge r170924
+
+2014-07-09 Enrica Casucci enr...@apple.com
+
+Implement Editor::fontAttributesForSelectionStart() or iOS.
+https://bugs.webkit.org/show_bug.cgi?id=134771
+rdar://problem/16167838
+
+Reviewed by Ryosuke Niwa.
+
+* WebView/WebViewPrivate.h:
+
2014-07-08 Tim Horton timothy_hor...@apple.com
[WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
Modified: tags/Safari-538.45/Source/WebKit/mac/WebView/WebViewPrivate.h (170935 => 170936)
--- tags/Safari-538.45/Source/WebKit/mac/WebView/WebViewPrivate.h 2014-07-09 22:06:29 UTC (rev 170935)
+++ tags/Safari-538.45/Source/WebKit/mac/WebView/WebViewPrivate.h 2014-07-09 22:33:57 UTC (rev 170936)
@@ -184,6 +184,7 @@
@interface WebView (WebViewEditingActionsPendingPublic)
- (void)outdent:(id)sender;
+- (NSDictionary *)typingAttributes;
@end
@@ -972,6 +973,7 @@
-
[webkit-changes] [170938] trunk/Source/WebCore
Title: [170938] trunk/Source/WebCore
Revision 170938
Author psola...@apple.com
Date 2014-07-09 17:18:17 -0700 (Wed, 09 Jul 2014)
Log Message
Make SharedBuffer::append(SharedBuffer*) be smarter about CFData and data arrays
https://bugs.webkit.org/show_bug.cgi?id=134731
Reviewed by Antti Koivisto.
If the target SharedBuffer has a CFDataRef or a data array then we can simply retain that
CFDataRef or data array elements in the SharedBuffer being appended to. This avoids
unnecessary copying.
No new tests because no functional changes.
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::maybeAppendPlatformData):
* platform/SharedBuffer.h:
* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::maybeAppendPlatformData):
(WebCore::SharedBuffer::maybeAppendDataArray):
* platform/soup/SharedBufferSoup.cpp:
(WebCore::SharedBuffer::maybeAppendPlatformData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/SharedBuffer.cpp
trunk/Source/WebCore/platform/SharedBuffer.h
trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp
trunk/Source/WebCore/platform/soup/SharedBufferSoup.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (170937 => 170938)
--- trunk/Source/WebCore/ChangeLog 2014-07-09 23:48:26 UTC (rev 170937)
+++ trunk/Source/WebCore/ChangeLog 2014-07-10 00:18:17 UTC (rev 170938)
@@ -1,3 +1,26 @@
+2014-07-09 Pratik Solanki psola...@apple.com
+
+Make SharedBuffer::append(SharedBuffer*) be smarter about CFData and data arrays
+https://bugs.webkit.org/show_bug.cgi?id=134731
+
+Reviewed by Antti Koivisto.
+
+If the target SharedBuffer has a CFDataRef or a data array then we can simply retain that
+CFDataRef or data array elements in the SharedBuffer being appended to. This avoids
+unnecessary copying.
+
+No new tests because no functional changes.
+
+* platform/SharedBuffer.cpp:
+(WebCore::SharedBuffer::append):
+(WebCore::SharedBuffer::maybeAppendPlatformData):
+* platform/SharedBuffer.h:
+* platform/cf/SharedBufferCF.cpp:
+(WebCore::SharedBuffer::maybeAppendPlatformData):
+(WebCore::SharedBuffer::maybeAppendDataArray):
+* platform/soup/SharedBufferSoup.cpp:
+(WebCore::SharedBuffer::maybeAppendPlatformData):
+
2014-07-09 Brent Fulgham bfulg...@apple.com
[Win] Remove uses of 'bash' in build system
Modified: trunk/Source/WebCore/platform/SharedBuffer.cpp (170937 => 170938)
--- trunk/Source/WebCore/platform/SharedBuffer.cpp 2014-07-09 23:48:26 UTC (rev 170937)
+++ trunk/Source/WebCore/platform/SharedBuffer.cpp 2014-07-10 00:18:17 UTC (rev 170938)
@@ -296,6 +296,13 @@
void SharedBuffer::append(SharedBuffer* data)
{
+if (maybeAppendPlatformData(data))
+return;
+#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+if (maybeAppendDataArray(data))
+return;
+#endif
+
const char* segment;
size_t position = 0;
while (size_t length = data-getSomeData(segment, position)) {
@@ -512,6 +519,11 @@
return 0;
}
+inline bool SharedBuffer::maybeAppendPlatformData(SharedBuffer*)
+{
+return false;
+}
+
#endif
PassRefPtrSharedBuffer utf8Buffer(const String string)
Modified: trunk/Source/WebCore/platform/SharedBuffer.h (170937 => 170938)
--- trunk/Source/WebCore/platform/SharedBuffer.h 2014-07-09 23:48:26 UTC (rev 170937)
+++ trunk/Source/WebCore/platform/SharedBuffer.h 2014-07-10 00:18:17 UTC (rev 170938)
@@ -189,6 +189,7 @@
void clearPlatformData();
void maybeTransferPlatformData();
+bool maybeAppendPlatformData(SharedBuffer*);
void copyBufferAndClear(char* destination, unsigned bytesToCopy) const;
@@ -201,6 +202,7 @@
mutable VectorRetainPtrCFDataRef m_dataArray;
unsigned copySomeDataFromDataArray(const char* someData, unsigned position) const;
const char *singleDataArrayBuffer() const;
+bool maybeAppendDataArray(SharedBuffer*);
#else
mutable Vectorchar* m_segments;
#endif
Modified: trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp (170937 => 170938)
--- trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp 2014-07-09 23:48:26 UTC (rev 170937)
+++ trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp 2014-07-10 00:18:17 UTC (rev 170938)
@@ -112,6 +112,14 @@
m_cfData = newContents-m_cfData;
}
+bool SharedBuffer::maybeAppendPlatformData(SharedBuffer* newContents)
+{
+if (size() || !newContents-m_cfData)
+return false;
+m_cfData = newContents-m_cfData;
+return true;
+}
+
#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
PassRefPtrSharedBuffer SharedBuffer::wrapCFDataArray(CFArrayRef cfDataArray)
{
@@ -187,6 +195,19 @@
return reinterpret_castconst char*(CFDataGetBytePtr(m_dataArray.at(0).get()));
}
+
+bool SharedBuffer::maybeAppendDataArray(SharedBuffer* data)
+{
+if (m_buffer.size() || m_cfData || !data-m_dataArray.size())
+return false;
+#if !ASSERT_DISABLED
+unsigned
[webkit-changes] [170939] trunk/Source/WTF
Title: [170939] trunk/Source/WTF Revision 170939 Author bfulg...@apple.com Date 2014-07-09 17:22:35 -0700 (Wed, 09 Jul 2014) Log Message [Win] Unreviewed build fix after r170930. * WTF.vcxproj/copy-files.cmd: Include cf files in post-build copy operation. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/WTF.vcxproj/copy-files.cmd Diff Modified: trunk/Source/WTF/ChangeLog (170938 => 170939) --- trunk/Source/WTF/ChangeLog 2014-07-10 00:18:17 UTC (rev 170938) +++ trunk/Source/WTF/ChangeLog 2014-07-10 00:22:35 UTC (rev 170939) @@ -1,5 +1,12 @@ 2014-07-09 Brent Fulgham bfulg...@apple.com +[Win] Unreviewed build fix after r170930. + +* WTF.vcxproj/copy-files.cmd: Include cf files in +post-build copy operation. + +2014-07-09 Brent Fulgham bfulg...@apple.com + [Win] Remove uses of 'bash' in build system https://bugs.webkit.org/show_bug.cgi?id=134782 rdar://problem/17615533 Modified: trunk/Source/WTF/WTF.vcxproj/copy-files.cmd (170938 => 170939) --- trunk/Source/WTF/WTF.vcxproj/copy-files.cmd 2014-07-10 00:18:17 UTC (rev 170938) +++ trunk/Source/WTF/WTF.vcxproj/copy-files.cmd 2014-07-10 00:22:35 UTC (rev 170939) @@ -10,6 +10,7 @@ for %%d in ( wtf +wtf\cf wtf\dtoa wtf\gobject wtf\text ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170940] trunk/WebKitLibraries
Title: [170940] trunk/WebKitLibraries
Revision 170940
Author bfulg...@apple.com
Date 2014-07-09 17:24:43 -0700 (Wed, 09 Jul 2014)
Log Message
[Win] Unreviewed gardening.
* win/tools/scripts/auto-version.pl: Protect against
malformed paths (trailing backslashes).
* win/tools/scripts/feature-defines.pl: Make sure result
has an EOL character.
Modified Paths
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/auto-version.pl
trunk/WebKitLibraries/win/tools/scripts/feature-defines.pl
Diff
Modified: trunk/WebKitLibraries/ChangeLog (170939 => 170940)
--- trunk/WebKitLibraries/ChangeLog 2014-07-10 00:22:35 UTC (rev 170939)
+++ trunk/WebKitLibraries/ChangeLog 2014-07-10 00:24:43 UTC (rev 170940)
@@ -1,5 +1,14 @@
2014-07-09 Brent Fulgham bfulg...@apple.com
+[Win] Unreviewed gardening.
+
+* win/tools/scripts/auto-version.pl: Protect against
+malformed paths (trailing backslashes).
+* win/tools/scripts/feature-defines.pl: Make sure result
+has an EOL character.
+
+2014-07-09 Brent Fulgham bfulg...@apple.com
+
[Win] Remove uses of 'bash' in build system
https://bugs.webkit.org/show_bug.cgi?id=134782
rdar://problem/17615533
Modified: trunk/WebKitLibraries/win/tools/scripts/auto-version.pl (170939 => 170940)
--- trunk/WebKitLibraries/win/tools/scripts/auto-version.pl 2014-07-10 00:22:35 UTC (rev 170939)
+++ trunk/WebKitLibraries/win/tools/scripts/auto-version.pl 2014-07-10 00:24:43 UTC (rev 170940)
@@ -47,13 +47,17 @@
chomp($COPYRIGHT_END_YEAR);
}
-my $OUTPUT_DIR = File::Spec-catdir($ARGV[0], 'include');
-my $OUTPUT_FILE = File::Spec-catfile($OUTPUT_DIR, 'autoversion.h');
+# Make sure we don't have any leading or trailing quote
+$ARGV[0] =~ s/^\//;
+$ARGV[0] =~ s/\$//;
+my $OUTPUT_DIR = File::Spec-catdir(File::Spec-canonpath($ARGV[0]), 'include');
unless (-d $OUTPUT_DIR) {
make_path($OUTPUT_DIR) or die Couldn't create $OUTPUT_DIR: $!;
}
+my $OUTPUT_FILE = File::Spec-catfile($OUTPUT_DIR, 'autoversion.h');
+
# Take the initial version number from RC_ProjectSourceVersion if it
# exists, otherwise fall back to the version number stored in the source.
my $ENVIRONMENT_VERSION = $ENV{'RC_ProjectSourceVersion'};
Modified: trunk/WebKitLibraries/win/tools/scripts/feature-defines.pl (170939 => 170940)
--- trunk/WebKitLibraries/win/tools/scripts/feature-defines.pl 2014-07-10 00:22:35 UTC (rev 170939)
+++ trunk/WebKitLibraries/win/tools/scripts/feature-defines.pl 2014-07-10 00:24:43 UTC (rev 170940)
@@ -44,4 +44,4 @@
my $result = join(' ', @enabled);
-print $result;
+print $result\n;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170941] trunk/LayoutTests
Title: [170941] trunk/LayoutTests Revision 170941 Author jer.no...@apple.com Date 2014-07-09 17:25:52 -0700 (Wed, 09 Jul 2014) Log Message [MSE] http/tests/media/media-source/mediasource-closed.html is failing. https://bugs.webkit.org/show_bug.cgi?id=134775 Reviewed by Eric Carlson. Update the test to use isNaN rather than Number.isNaN. * http/tests/media/media-source/mediasource-closed.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/media/media-source/mediasource-closed.html Diff Modified: trunk/LayoutTests/ChangeLog (170940 => 170941) --- trunk/LayoutTests/ChangeLog 2014-07-10 00:24:43 UTC (rev 170940) +++ trunk/LayoutTests/ChangeLog 2014-07-10 00:25:52 UTC (rev 170941) @@ -1,3 +1,14 @@ +2014-07-09 Jer Noble jer.no...@apple.com + +[MSE] http/tests/media/media-source/mediasource-closed.html is failing. +https://bugs.webkit.org/show_bug.cgi?id=134775 + +Reviewed by Eric Carlson. + +Update the test to use isNaN rather than Number.isNaN. + +* http/tests/media/media-source/mediasource-closed.html: + 2014-07-09 Javier Fernandez jfernan...@igalia.com CSS canvas color parsing accepts invalid color identifiers Modified: trunk/LayoutTests/http/tests/media/media-source/mediasource-closed.html (170940 => 170941) --- trunk/LayoutTests/http/tests/media/media-source/mediasource-closed.html 2014-07-10 00:24:43 UTC (rev 170940) +++ trunk/LayoutTests/http/tests/media/media-source/mediasource-closed.html 2014-07-10 00:25:52 UTC (rev 170941) @@ -14,7 +14,7 @@ assert_equals(mediaSource.sourceBuffers.length, 0, sourceBuffers is empty); assert_equals(mediaSource.activeSourceBuffers.length, 0, activeSourceBuffers is empty); assert_equals(mediaSource.readyState, closed, readyState is 'closed'); - assert_true(Number.isNaN(mediaSource.duration), duration is NaN); + assert_true(isNaN(mediaSource.duration), duration is NaN); }, Test attribute values on a closed MediaSource object.); test(function () ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170943] trunk/Source/WebKit2
Title: [170943] trunk/Source/WebKit2
Revision 170943
Author ander...@apple.com
Date 2014-07-09 17:50:25 -0700 (Wed, 09 Jul 2014)
Log Message
Closed web views should never create new web processes
https://bugs.webkit.org/show_bug.cgi?id=134787
rdar://problem/16892526
Reviewed by Simon Fraser.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadHTMLString:baseURL:]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
Return nil if the returned navigation ID is 0.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
Assert that the page is not closed.
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
Add early returns if the page is closed.
* UIProcess/WebPageProxy.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170942 => 170943)
--- trunk/Source/WebKit2/ChangeLog 2014-07-10 00:29:10 UTC (rev 170942)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-10 00:50:25 UTC (rev 170943)
@@ -1,5 +1,35 @@
2014-07-09 Anders Carlsson ander...@apple.com
+Closed web views should never create new web processes
+https://bugs.webkit.org/show_bug.cgi?id=134787
+rdar://problem/16892526
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView loadHTMLString:baseURL:]):
+(-[WKWebView reload]):
+(-[WKWebView reloadFromOrigin]):
+Return nil if the returned navigation ID is 0.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::reattachToWebProcess):
+Assert that the page is not closed.
+
+(WebKit::WebPageProxy::reattachToWebProcessWithItem):
+(WebKit::WebPageProxy::loadRequest):
+(WebKit::WebPageProxy::loadFile):
+(WebKit::WebPageProxy::loadData):
+(WebKit::WebPageProxy::loadHTMLString):
+(WebKit::WebPageProxy::loadAlternateHTMLString):
+(WebKit::WebPageProxy::loadPlainTextString):
+(WebKit::WebPageProxy::loadWebArchiveData):
+Add early returns if the page is closed.
+
+* UIProcess/WebPageProxy.h:
+
+2014-07-09 Anders Carlsson ander...@apple.com
+
Support transparent WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=134779
rdar://problem/17351058
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (170942 => 170943)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-07-10 00:29:10 UTC (rev 170942)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-07-10 00:50:25 UTC (rev 170943)
@@ -393,6 +393,9 @@
- (WKNavigation *)loadHTMLString:(NSString *)string baseURL:(NSURL *)baseURL
{
uint64_t navigationID = _page-loadHTMLString(string, baseURL.absoluteString);
+if (!navigationID)
+return nil;
+
auto navigation = _navigationState-createLoadDataNavigation(navigationID);
return navigation.autorelease();
@@ -450,7 +453,7 @@
ASSERT(_page-backForwardList().currentItem());
auto navigation = _navigationState-createBackForwardNavigation(navigationID, *_page-backForwardList().currentItem());
-
+
return navigation.autorelease();
}
@@ -469,7 +472,8 @@
- (WKNavigation *)reload
{
uint64_t navigationID = _page-reload(false);
-ASSERT(navigationID);
+if (!navigationID)
+return nil;
auto navigation = _navigationState-createReloadNavigation(navigationID);
return navigation.autorelease();
@@ -478,7 +482,8 @@
- (WKNavigation *)reloadFromOrigin
{
uint64_t navigationID = _page-reload(true);
-ASSERT(navigationID);
+if (!navigationID)
+return nil;
auto navigation = _navigationState-createReloadNavigation(navigationID);
return navigation.autorelease();
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (170942 => 170943)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-07-10 00:29:10 UTC (rev 170942)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-07-10 00:50:25 UTC (rev 170943)
@@ -537,8 +537,10 @@
void WebPageProxy::reattachToWebProcess()
{
+ASSERT(!m_isClosed);
ASSERT(!isValid());
ASSERT(m_process-state() == WebProcessProxy::State::Terminated);
+
m_isValid = true;
if (m_process-context().processModel() == ProcessModelSharedSecondaryProcess)
@@ -569,6 +571,9 @@
uint64_t WebPageProxy::reattachToWebProcessWithItem(WebBackForwardListItem* item)
{
+if (m_isClosed)
+return 0;
+
if (item item != m_backForwardList-currentItem())
m_backForwardList-goToItem(item);
@@
[webkit-changes] [170944] trunk/Source/WebCore
Title: [170944] trunk/Source/WebCore
Revision 170944
Author simon.fra...@apple.com
Date 2014-07-09 18:01:52 -0700 (Wed, 09 Jul 2014)
Log Message
Make IndirectCompositingReason an enum class
https://bugs.webkit.org/show_bug.cgi?id=134789
Reviewed by Tim Horton.
Make RenderLayer::IndirectCompositingReason an enum class, and change some code
in RenderLayerCompositor::reasonsForCompositing() to use a switch.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (170943 => 170944)
--- trunk/Source/WebCore/ChangeLog 2014-07-10 00:50:25 UTC (rev 170943)
+++ trunk/Source/WebCore/ChangeLog 2014-07-10 01:01:52 UTC (rev 170944)
@@ -1,3 +1,22 @@
+2014-07-09 Simon Fraser simon.fra...@apple.com
+
+Make IndirectCompositingReason an enum class
+https://bugs.webkit.org/show_bug.cgi?id=134789
+
+Reviewed by Tim Horton.
+
+Make RenderLayer::IndirectCompositingReason an enum class, and change some code
+in RenderLayerCompositor::reasonsForCompositing() to use a switch.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::RenderLayer):
+* rendering/RenderLayer.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::computeCompositingRequirements):
+(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
+(WebCore::RenderLayerCompositor::reasonsForCompositing):
+(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
+
2014-07-09 Pratik Solanki psola...@apple.com
Make SharedBuffer::append(SharedBuffer*) be smarter about CFData and data arrays
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (170943 => 170944)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-07-10 00:50:25 UTC (rev 170943)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-07-10 01:01:52 UTC (rev 170944)
@@ -168,7 +168,7 @@
, m_hasCompositingDescendant(false)
, m_hasTransformedAncestor(false)
, m_has3DTransformedAncestor(false)
-, m_indirectCompositingReason(NoIndirectCompositingReason)
+, m_indirectCompositingReason(static_castunsigned(IndirectCompositingReason::None))
, m_viewportConstrainedNotCompositedReason(NoNotCompositedReason)
#if PLATFORM(IOS)
, m_adjustForIOSCaretWhenScrolling(false)
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (170943 => 170944)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2014-07-10 00:50:25 UTC (rev 170943)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2014-07-10 01:01:52 UTC (rev 170944)
@@ -1149,17 +1149,17 @@
void setHasCompositingDescendant(bool b) { m_hasCompositingDescendant = b; }
-enum IndirectCompositingReason {
-NoIndirectCompositingReason,
-IndirectCompositingForStacking,
-IndirectCompositingForOverlap,
-IndirectCompositingForBackgroundLayer,
-IndirectCompositingForGraphicalEffect, // opacity, mask, filter, transform etc.
-IndirectCompositingForPerspective,
-IndirectCompositingForPreserve3D
+enum class IndirectCompositingReason {
+None,
+Stacking,
+Overlap,
+BackgroundLayer,
+GraphicalEffect, // opacity, mask, filter, transform etc.
+Perspective,
+Preserve3D
};
-void setIndirectCompositingReason(IndirectCompositingReason reason) { m_indirectCompositingReason = reason; }
+void setIndirectCompositingReason(IndirectCompositingReason reason) { m_indirectCompositingReason = static_castunsigned(reason); }
IndirectCompositingReason indirectCompositingReason() const { return static_castIndirectCompositingReason(m_indirectCompositingReason); }
bool mustCompositeForIndirectReasons() const { return m_indirectCompositingReason; }
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (170943 => 170944)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-07-10 00:50:25 UTC (rev 170943)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-07-10 01:01:52 UTC (rev 170944)
@@ -1121,14 +1121,14 @@
// Clear the flag
layer.setHasCompositingDescendant(false);
-layer.setIndirectCompositingReason(RenderLayer::NoIndirectCompositingReason);
+layer.setIndirectCompositingReason(RenderLayer::IndirectCompositingReason::None);
// Check if the layer needs to be composited for non-indirect reasons
[webkit-changes] [170945] trunk/Source/WebKit2
Title: [170945] trunk/Source/WebKit2 Revision 170945 Author ander...@apple.com Date 2014-07-09 18:05:23 -0700 (Wed, 09 Jul 2014) Log Message Safari showing blank pages https://bugs.webkit.org/show_bug.cgi?id=134790 rdar://problem/17617166 Reviewed by Simon Fraser. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView initWithFrame:configuration:]): Make sure to add the content view to the scroll view. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (170944 => 170945) --- trunk/Source/WebKit2/ChangeLog 2014-07-10 01:01:52 UTC (rev 170944) +++ trunk/Source/WebKit2/ChangeLog 2014-07-10 01:05:23 UTC (rev 170945) @@ -1,5 +1,17 @@ 2014-07-09 Anders Carlsson ander...@apple.com +Safari showing blank pages +https://bugs.webkit.org/show_bug.cgi?id=134790 +rdar://problem/17617166 + +Reviewed by Simon Fraser. + +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView initWithFrame:configuration:]): +Make sure to add the content view to the scroll view. + +2014-07-09 Anders Carlsson ander...@apple.com + Closed web views should never create new web processes https://bugs.webkit.org/show_bug.cgi?id=134787 rdar://problem/16892526 Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (170944 => 170945) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-07-10 01:01:52 UTC (rev 170944) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-07-10 01:05:23 UTC (rev 170945) @@ -286,6 +286,7 @@ [_contentView layer].anchorPoint = CGPointZero; [_contentView setFrame:bounds]; +[_scrollView addSubview:_contentView.get()]; [_scrollView addSubview:[_contentView unscaledView]]; [self _updateScrollViewBackground]; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170946] trunk
Title: [170946] trunk Revision 170946 Author jp...@apple.com Date 2014-07-09 18:13:45 -0700 (Wed, 09 Jul 2014) Log Message Fix flaky loading tests https://bugs.webkit.org/show_bug.cgi?id=133696 Reviewed by Ryosuke Niwa. Source/WebCore: In some cases, the Frame may be destroyed while the loader is initializing. Make sure we don't delete it too early. * loader/FrameLoader.cpp: (WebCore::FrameLoader::init): LayoutTests: * platform/wk2/TestExpectations: Unskip no-longer failing tests Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/FrameLoader.cpp Diff Modified: trunk/LayoutTests/ChangeLog (170945 => 170946) --- trunk/LayoutTests/ChangeLog 2014-07-10 01:05:23 UTC (rev 170945) +++ trunk/LayoutTests/ChangeLog 2014-07-10 01:13:45 UTC (rev 170946) @@ -1,3 +1,12 @@ +2014-07-08 Jeffrey Pfau jp...@apple.com + +Fix flaky loading tests +https://bugs.webkit.org/show_bug.cgi?id=133696 + +Reviewed by Ryosuke Niwa. + +* platform/wk2/TestExpectations: Unskip no-longer failing tests + 2014-07-09 Hunseop Jeong hs85.je...@samsung.com [EFL] gardening after r170868 Modified: trunk/LayoutTests/platform/wk2/TestExpectations (170945 => 170946) --- trunk/LayoutTests/platform/wk2/TestExpectations 2014-07-10 01:05:23 UTC (rev 170945) +++ trunk/LayoutTests/platform/wk2/TestExpectations 2014-07-10 01:13:45 UTC (rev 170946) @@ -240,10 +240,6 @@ webkit.org/b/132297 svg/custom/bug79798.html [ Skip ] -webkit.org/b/133696 fast/frames/iframe-onload-remove-self-no-crash.html [ Skip ] -webkit.org/b/133696 fast/loader/create-frame-in-DOMContentLoaded.html [ Skip ] -webkit.org/b/133696 fast/loader/frame-creation-removal.html [ Skip ] - ### END OF (1) Classified failures with bug reports Modified: trunk/Source/WebCore/ChangeLog (170945 => 170946) --- trunk/Source/WebCore/ChangeLog 2014-07-10 01:05:23 UTC (rev 170945) +++ trunk/Source/WebCore/ChangeLog 2014-07-10 01:13:45 UTC (rev 170946) @@ -1,3 +1,16 @@ +2014-07-08 Jeffrey Pfau jp...@apple.com + +Fix flaky loading tests +https://bugs.webkit.org/show_bug.cgi?id=133696 + +Reviewed by Ryosuke Niwa. + +In some cases, the Frame may be destroyed while the loader is +initializing. Make sure we don't delete it too early. + +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::init): + 2014-07-09 Simon Fraser simon.fra...@apple.com Make IndirectCompositingReason an enum class Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (170945 => 170946) --- trunk/Source/WebCore/loader/FrameLoader.cpp 2014-07-10 01:05:23 UTC (rev 170945) +++ trunk/Source/WebCore/loader/FrameLoader.cpp 2014-07-10 01:13:45 UTC (rev 170946) @@ -268,6 +268,8 @@ setPolicyDocumentLoader(m_client.createDocumentLoader(ResourceRequest(URL(ParsedURLString, emptyString())), SubstituteData()).get()); setProvisionalDocumentLoader(m_policyDocumentLoader.get()); m_provisionalDocumentLoader-startLoadingMainResource(); + +RefFrame protect(m_frame); m_frame.document()-cancelParsing(); m_stateMachine.advanceTo(FrameLoaderStateMachine::DisplayingInitialEmptyDocument); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170948] trunk/Source/WebKit2
Title: [170948] trunk/Source/WebKit2
Revision 170948
Author enr...@apple.com
Date 2014-07-09 19:18:30 -0700 (Wed, 09 Jul 2014)
Log Message
REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
https://bugs.webkit.org/show_bug.cgi?id=134791
rdar://problem/17616971
Reviewed by Benjamin Poulain.
After r170858 we notify the keyboard too often about
the changed selection. This patch removes the notification
until we find a better way to do it that doesn't cause
deadlocks.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionWillChange]):
(-[WKContentView _selectionChanged]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170947 => 170948)
--- trunk/Source/WebKit2/ChangeLog 2014-07-10 01:42:43 UTC (rev 170947)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-10 02:18:30 UTC (rev 170948)
@@ -1,3 +1,20 @@
+2014-07-09 Enrica Casucci enr...@apple.com
+
+REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
+https://bugs.webkit.org/show_bug.cgi?id=134791
+rdar://problem/17616971
+
+Reviewed by Benjamin Poulain.
+
+After r170858 we notify the keyboard too often about
+the changed selection. This patch removes the notification
+until we find a better way to do it that doesn't cause
+deadlocks.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _selectionWillChange]):
+(-[WKContentView _selectionChanged]):
+
2014-07-09 Anders Carlsson ander...@apple.com
Safari showing blank pages
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (170947 => 170948)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-07-10 01:42:43 UTC (rev 170947)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-07-10 02:18:30 UTC (rev 170948)
@@ -2506,9 +2506,6 @@
- (void)_selectionWillChange
{
-if (_usingGestureForSelection)
-return;
-[self beginSelectionChange];
}
- (void)_selectionChanged
@@ -2518,8 +2515,6 @@
// to wait to paint the selection.
if (_usingGestureForSelection)
[self _updateChangedSelection];
-else
-[self endSelectionChange];
}
- (void)selectWordForReplacement
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170949] trunk/Source/WebCore
Title: [170949] trunk/Source/WebCore
Revision 170949
Author commit-qu...@webkit.org
Date 2014-07-09 20:11:26 -0700 (Wed, 09 Jul 2014)
Log Message
[Curl] Cache entry invalidated too early.
https://bugs.webkit.org/show_bug.cgi?id=134681
Patch by pe...@outlook.com pe...@outlook.com on 2014-07-09
Reviewed by Alex Christensen.
When a cache entry has expired, it is invalidated when a request for the corresponding url is started.
This is too early, since the resource is possibly not modified (even though it has expired),
and the server might respond with a 304 (not modified) response.
When we then receive a 304 response, the cache entry is deleted, and we have no cached response/data to provide.
This can be solved by not invalidating the entry when a request for that url is started,
but instead invalidate when a 200 OK response is received (which means the resource has been modified).
* platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::isCached): Avoid invalidating cache entry when it has expired, wait until we know the server response.
* platform/network/curl/CurlCacheManager.h: Added const modifier.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp
trunk/Source/WebCore/platform/network/curl/CurlCacheManager.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (170948 => 170949)
--- trunk/Source/WebCore/ChangeLog 2014-07-10 02:18:30 UTC (rev 170948)
+++ trunk/Source/WebCore/ChangeLog 2014-07-10 03:11:26 UTC (rev 170949)
@@ -1,3 +1,21 @@
+2014-07-09 pe...@outlook.com pe...@outlook.com
+
+[Curl] Cache entry invalidated too early.
+https://bugs.webkit.org/show_bug.cgi?id=134681
+
+Reviewed by Alex Christensen.
+
+When a cache entry has expired, it is invalidated when a request for the corresponding url is started.
+This is too early, since the resource is possibly not modified (even though it has expired),
+and the server might respond with a 304 (not modified) response.
+When we then receive a 304 response, the cache entry is deleted, and we have no cached response/data to provide.
+This can be solved by not invalidating the entry when a request for that url is started,
+but instead invalidate when a 200 OK response is received (which means the resource has been modified).
+
+* platform/network/curl/CurlCacheManager.cpp:
+(WebCore::CurlCacheManager::isCached): Avoid invalidating cache entry when it has expired, wait until we know the server response.
+* platform/network/curl/CurlCacheManager.h: Added const modifier.
+
2014-07-09 Myles C. Maxfield mmaxfi...@apple.com
Revert r170413 and r170390
Modified: trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp (170948 => 170949)
--- trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp 2014-07-10 02:18:30 UTC (rev 170948)
+++ trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp 2014-07-10 03:11:26 UTC (rev 170949)
@@ -236,18 +236,15 @@
it-value-didFinishLoading();
}
-bool CurlCacheManager::isCached(const String url)
+bool CurlCacheManager::isCached(const String url) const
{
if (m_disabled)
return false;
auto it = m_index.find(url);
-if (it != m_index.end()) {
-if (it-value-isCached())
-return !it-value-isLoading();
+if (it != m_index.end())
+return it-value-isCached() !it-value-isLoading();
-invalidateCacheEntry(url);
-}
return false;
}
Modified: trunk/Source/WebCore/platform/network/curl/CurlCacheManager.h (170948 => 170949)
--- trunk/Source/WebCore/platform/network/curl/CurlCacheManager.h 2014-07-10 02:18:30 UTC (rev 170948)
+++ trunk/Source/WebCore/platform/network/curl/CurlCacheManager.h 2014-07-10 03:11:26 UTC (rev 170949)
@@ -45,7 +45,7 @@
const String cacheDirectory() { return m_cacheDir; }
void setStorageSizeLimit(size_t);
-bool isCached(const String);
+bool isCached(const String) const;
HTTPHeaderMap requestHeaders(const String); // Load headers
bool getCachedResponse(const String url, ResourceResponse);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170950] trunk/Source/JavaScriptCore
Title: [170950] trunk/Source/_javascript_Core
Revision 170950
Author benja...@webkit.org
Date 2014-07-09 21:11:34 -0700 (Wed, 09 Jul 2014)
Log Message
Use 16bits instructions for push/pop on ARMv7 when possible
https://bugs.webkit.org/show_bug.cgi?id=134753
Reviewed by Geoffrey Garen.
The patch r170839 mixed the code for push/pop pair and single push/pop.
That part was reverted in r170909.
This patch puts the code back but specialized for single push/pop.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::pop):
(JSC::ARMv7Assembler::push):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::pop):
(JSC::MacroAssemblerARMv7::push):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (170949 => 170950)
--- trunk/Source/_javascript_Core/ChangeLog 2014-07-10 03:11:26 UTC (rev 170949)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-07-10 04:11:34 UTC (rev 170950)
@@ -1,3 +1,22 @@
+2014-07-09 Benjamin Poulain benja...@webkit.org
+
+Use 16bits instructions for push/pop on ARMv7 when possible
+https://bugs.webkit.org/show_bug.cgi?id=134753
+
+Reviewed by Geoffrey Garen.
+
+The patch r170839 mixed the code for push/pop pair and single push/pop.
+That part was reverted in r170909.
+
+This patch puts the code back but specialized for single push/pop.
+
+* assembler/ARMv7Assembler.h:
+(JSC::ARMv7Assembler::pop):
+(JSC::ARMv7Assembler::push):
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::pop):
+(JSC::MacroAssemblerARMv7::push):
+
2014-07-09 Brent Fulgham bfulg...@apple.com
[Win] Remove uses of 'bash' in build system
Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (170949 => 170950)
--- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2014-07-10 03:11:26 UTC (rev 170949)
+++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2014-07-10 04:11:34 UTC (rev 170950)
@@ -1499,6 +1499,16 @@
m_formatter.twoWordOp12Reg4FourFours(OP_ROR_reg_T2, rn, FourFours(0xf, rd, 0, rm));
}
+ALWAYS_INLINE void pop(RegisterID dest)
+{
+if (dest ARMRegisters::r8)
+m_formatter.oneWordOp7Imm9(OP_POP_T1, 1 dest);
+else {
+// Load postindexed with writeback.
+ldr(dest, ARMRegisters::sp, sizeof(void*), false, true);
+}
+}
+
ALWAYS_INLINE void pop(uint32_t registerList)
{
ASSERT(WTF::bitCount(registerList) 1);
@@ -1507,6 +1517,18 @@
m_formatter.twoWordOp16Imm16(OP_POP_T2, registerList);
}
+ALWAYS_INLINE void push(RegisterID src)
+{
+if (src ARMRegisters::r8)
+m_formatter.oneWordOp7Imm9(OP_PUSH_T1, 1 src);
+else if (src == ARMRegisters::lr)
+m_formatter.oneWordOp7Imm9(OP_PUSH_T1, 0x100);
+else {
+// Store preindexed with writeback.
+str(src, ARMRegisters::sp, -sizeof(void*), true, true);
+}
+}
+
ALWAYS_INLINE void push(uint32_t registerList)
{
ASSERT(WTF::bitCount(registerList) 1);
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (170949 => 170950)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2014-07-10 03:11:26 UTC (rev 170949)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2014-07-10 04:11:34 UTC (rev 170950)
@@ -1181,14 +1181,12 @@
void pop(RegisterID dest)
{
-// Load postindexed with writeback.
-m_assembler.ldr(dest, ARMRegisters::sp, sizeof(void*), false, true);
+m_assembler.pop(dest);
}
void push(RegisterID src)
{
-// Store preindexed with writeback.
-m_assembler.str(src, ARMRegisters::sp, -sizeof(void*), true, true);
+m_assembler.push(src);
}
void push(Address address)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170951] trunk/Source/WebKit2
Title: [170951] trunk/Source/WebKit2
Revision 170951
Author commit-qu...@webkit.org
Date 2014-07-09 21:13:37 -0700 (Wed, 09 Jul 2014)
Log Message
[EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
https://bugs.webkit.org/show_bug.cgi?id=134759
Patch by Shivakumar JM shiva...@samsung.com on 2014-07-09
Reviewed by Gyuyoung Kim.
Add new API in ewk_download_job.h to get size of the data already downloaded.
* UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_received_data_length_get):
(EwkDownloadJob::receivedData):
* UIProcess/API/efl/ewk_download_job.h:
* UIProcess/API/efl/ewk_download_job_private.h:
* UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_finished):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170950 => 170951)
--- trunk/Source/WebKit2/ChangeLog 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-10 04:13:37 UTC (rev 170951)
@@ -1,3 +1,21 @@
+2014-07-09 Shivakumar JM shiva...@samsung.com
+
+[EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
+https://bugs.webkit.org/show_bug.cgi?id=134759
+
+Reviewed by Gyuyoung Kim.
+
+Add new API in ewk_download_job.h to get size of the data already downloaded.
+
+* UIProcess/API/efl/ewk_download_job.cpp:
+(ewk_download_job_received_data_length_get):
+(EwkDownloadJob::receivedData):
+* UIProcess/API/efl/ewk_download_job.h:
+* UIProcess/API/efl/ewk_download_job_private.h:
+* UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
+(EWK2DownloadJobTest::on_download_requested):
+(EWK2DownloadJobTest::on_download_finished):
+
2014-07-09 Enrica Casucci enr...@apple.com
REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.cpp 2014-07-10 04:13:37 UTC (rev 170951)
@@ -203,6 +203,18 @@
return ecore_time_get() - m_startTime;
}
+uint64_t ewk_download_job_received_data_size_get(const Ewk_Download_Job* download)
+{
+EWK_OBJ_GET_IMPL_OR_RETURN(const EwkDownloadJob, download, impl, 0);
+
+return impl-receivedDataSize();
+}
+
+uint64_t EwkDownloadJob::receivedDataSize() const
+{
+return m_downloaded;
+}
+
/**
* @internal
* Sets the URL @a response for this @a download.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job.h 2014-07-10 04:13:37 UTC (rev 170951)
@@ -183,6 +183,18 @@
*/
EAPI double ewk_download_job_elapsed_time_get(const Ewk_Download_Job *download);
+/**
+ * Gets the data size, already downloaded.
+ *
+ * If the download finished, had an error or was cancelled this is
+ * the data size between its start and the end.
+ *
+ * @param download a #Ewk_Download_Job to query.
+ *
+ * @return the size of the data already downloaded, since the download was started or 0.0 in case of failure.
+ */
+EAPI uint64_t ewk_download_job_received_data_size_get(const Ewk_Download_Job *download);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h 2014-07-10 04:13:37 UTC (rev 170951)
@@ -68,6 +68,7 @@
double estimatedProgress() const;
double elapsedTime() const;
void incrementReceivedData(uint64_t length);
+uint64_t receivedDataSize() const;
private:
EwkDownloadJob(WKDownloadRef download, EwkView* view);
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp (170950 => 170951)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp 2014-07-10 04:11:34 UTC (rev 170950)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp 2014-07-10 04:13:37 UTC (rev 170951)
@@ -103,6 +103,7 @@
ASSERT_EQ(EWK_DOWNLOAD_JOB_STATE_NOT_STARTED, ewk_download_job_state_get(download));
ASSERT_EQ(0, ewk_download_job_estimated_progress_get(download));
ASSERT_EQ(0, ewk_download_job_elapsed_time_get(download));
+
[webkit-changes] [170952] trunk/Source/WebKit2
Title: [170952] trunk/Source/WebKit2
Revision 170952
Author commit-qu...@webkit.org
Date 2014-07-09 21:38:13 -0700 (Wed, 09 Jul 2014)
Log Message
[iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI
https://bugs.webkit.org/show_bug.cgi?id=134777
Patch by Joseph Pecoraro pecor...@apple.com on 2014-07-09
Reviewed by Sam Weinig.
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel _showMediaSourceSelectionSheet]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170951 => 170952)
--- trunk/Source/WebKit2/ChangeLog 2014-07-10 04:13:37 UTC (rev 170951)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-10 04:38:13 UTC (rev 170952)
@@ -1,3 +1,13 @@
+2014-07-09 Joseph Pecoraro pecor...@apple.com
+
+[iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI
+https://bugs.webkit.org/show_bug.cgi?id=134777
+
+Reviewed by Sam Weinig.
+
+* UIProcess/ios/forms/WKFileUploadPanel.mm:
+(-[WKFileUploadPanel _showMediaSourceSelectionSheet]):
+
2014-07-09 Shivakumar JM shiva...@samsung.com
[EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm (170951 => 170952)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm 2014-07-10 04:13:37 UTC (rev 170951)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm 2014-07-10 04:38:13 UTC (rev 170952)
@@ -41,7 +41,6 @@
#import AVFoundation/AVFoundation.h
#import CoreMedia/CoreMedia.h
#import MobileCoreServices/MobileCoreServices.h
-#import UIKit/UIAlertController_Private.h
#import UIKit/UIApplication_Private.h
#import UIKit/UIImagePickerController_Private.h
#import UIKit/UIImage_Private.h
@@ -388,24 +387,27 @@
else
cameraString = WEB_UI_STRING_KEY(Take Photo, Take Photo (file upload action sheet), File Upload alert sheet camera button string for taking only photos);
-_actionSheetController = [UIAlertController _alertControllerWithTitle:nil message:nil];
-[_actionSheetController setPreferredStyle:UIAlertControllerStyleActionSheet];
+_actionSheetController = [UIAlertController alertControllerWithTitle:nil message:nil preferredStyle:UIAlertControllerStyleActionSheet];
-[_actionSheetController _addActionWithTitle:cancelString style:UIAlertActionStyleCancel handler:^{
+UIAlertAction *cancelAction = [UIAlertAction actionWithTitle:cancelString style:UIAlertActionStyleCancel handler:^(UIAlertAction *){
[self _cancel];
// We handled cancel ourselves. Prevent the popover controller delegate from cancelling when the popover dismissed.
[_presentationPopover setDelegate:nil];
}];
-[_actionSheetController _addActionWithTitle:cameraString style:UIAlertActionStyleDefault handler:^{
+UIAlertAction *cameraAction = [UIAlertAction actionWithTitle:cameraString style:UIAlertActionStyleDefault handler:^(UIAlertAction *){
_usingCamera = YES;
[self _showPhotoPickerWithSourceType:UIImagePickerControllerSourceTypeCamera];
}];
-[_actionSheetController _addActionWithTitle:existingString style:UIAlertActionStyleDefault handler:^{
+UIAlertAction *photoLibraryAction = [UIAlertAction actionWithTitle:existingString style:UIAlertActionStyleDefault handler:^(UIAlertAction *){
[self _showPhotoPickerWithSourceType:UIImagePickerControllerSourceTypePhotoLibrary];
}];
+[_actionSheetController addAction:cancelAction];
+[_actionSheetController addAction:cameraAction];
+[_actionSheetController addAction:photoLibraryAction];
+
if (UICurrentUserInterfaceIdiomIsPad())
[self _presentPopoverWithContentViewController:_actionSheetController.get() animated:YES];
else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170953] trunk/Source
Title: [170953] trunk/Source
Revision 170953
Author benja...@webkit.org
Date 2014-07-09 22:06:30 -0700 (Wed, 09 Jul 2014)
Log Message
[iOS][WK2] Disable text quantization while actively changing the page's scale factor
https://bugs.webkit.org/show_bug.cgi?id=134781
Patch by Benjamin Poulain bpoul...@apple.com on 2014-07-09
Reviewed by Tim Horton and Myles C. Maxfield.
Source/WebCore:
Query the chrome client to setup quantization on each layers.
* page/ChromeClient.h:
(WebCore::ChromeClient::hasStablePageScaleFactor):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFontSubpixelQuantization):
Source/WebKit2:
While zooming a page, text quantization causes glyphs to move in order to get to the closest
boundary for the current scale factor.
We do not want this to happen while dynamically changing the scale factor because the effect
is visible. To avoid this, we disable text quantization if the page's scale factor changes
in response to a non-stable contentRect update.
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::hasStablePageScaleFactor):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::hasStablePageScaleFactor):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/platform/graphics/mac/FontMac.mm
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (170952 => 170953)
--- trunk/Source/WebCore/ChangeLog 2014-07-10 04:38:13 UTC (rev 170952)
+++ trunk/Source/WebCore/ChangeLog 2014-07-10 05:06:30 UTC (rev 170953)
@@ -1,3 +1,19 @@
+2014-07-09 Benjamin Poulain bpoul...@apple.com
+
+[iOS][WK2] Disable text quantization while actively changing the page's scale factor
+https://bugs.webkit.org/show_bug.cgi?id=134781
+
+Reviewed by Tim Horton and Myles C. Maxfield.
+
+Query the chrome client to setup quantization on each layers.
+
+* page/ChromeClient.h:
+(WebCore::ChromeClient::hasStablePageScaleFactor):
+* platform/graphics/mac/FontMac.mm:
+(WebCore::Font::drawGlyphs):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::setupFontSubpixelQuantization):
+
2014-07-09 pe...@outlook.com pe...@outlook.com
[Curl] Cache entry invalidated too early.
Modified: trunk/Source/WebCore/page/ChromeClient.h (170952 => 170953)
--- trunk/Source/WebCore/page/ChromeClient.h 2014-07-10 04:38:13 UTC (rev 170952)
+++ trunk/Source/WebCore/page/ChromeClient.h 2014-07-10 05:06:30 UTC (rev 170953)
@@ -287,6 +287,7 @@
virtual void elementDidBlur(const Node*) { };
virtual bool shouldPaintEntireContents() const { return false; }
+virtual bool hasStablePageScaleFactor() const { return true; }
// Allows ports to customize the type of graphics layers created by this page.
virtual GraphicsLayerFactory* graphicsLayerFactory() const { return nullptr; }
Modified: trunk/Source/WebCore/platform/graphics/mac/FontMac.mm (170952 => 170953)
--- trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-07-10 04:38:13 UTC (rev 170952)
+++ trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-07-10 05:06:30 UTC (rev 170953)
@@ -303,6 +303,7 @@
#if PLATFORM(IOS)
CGContextSetFontSize(cgContext, 1);
+CGContextSetShouldSubpixelQuantizeFonts(cgContext, context-shouldSubpixelQuantizeFonts());
#else
wkSetCGFontRenderingMode(cgContext, drawFont, context-shouldSubpixelQuantizeFonts());
if (drawFont)
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (170952 => 170953)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-07-10 04:38:13 UTC (rev 170952)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-07-10 05:06:30 UTC (rev 170953)
@@ -3755,7 +3755,10 @@
// FIXME: We shouldn't have to disable subpixel quantization for overflow clips or subframes once we scroll those
// things on the scrolling thread.
bool contentsScrollByPainting = (renderer().hasOverflowClip() !usesCompositedScrolling()) || (renderer().frame().ownerElement());
-if (scrollingOnMainThread || contentsScrollByPainting) {
+bool isZooming = false;
+if (Page* page = renderer().frame().page())
+isZooming = !page-chrome().client().hasStablePageScaleFactor();
+if (scrollingOnMainThread || contentsScrollByPainting || isZooming) {
didQuantizeFonts
[webkit-changes] [170954] trunk/WebKitLibraries
Title: [170954] trunk/WebKitLibraries
Revision 170954
Author bfulg...@apple.com
Date 2014-07-09 22:32:40 -0700 (Wed, 09 Jul 2014)
Log Message
[Win] Unreviewed build fix.
Build bots don't have a three-part default version string,
breaking pattern matching. Handle this case.
* win/tools/scripts/auto-version.pl:
Modified Paths
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/auto-version.pl
Diff
Modified: trunk/WebKitLibraries/ChangeLog (170953 => 170954)
--- trunk/WebKitLibraries/ChangeLog 2014-07-10 05:06:30 UTC (rev 170953)
+++ trunk/WebKitLibraries/ChangeLog 2014-07-10 05:32:40 UTC (rev 170954)
@@ -1,5 +1,14 @@
2014-07-09 Brent Fulgham bfulg...@apple.com
+[Win] Unreviewed build fix.
+
+Build bots don't have a three-part default version string,
+breaking pattern matching. Handle this case.
+
+* win/tools/scripts/auto-version.pl:
+
+2014-07-09 Brent Fulgham bfulg...@apple.com
+
[Win] Unreviewed gardening.
* win/tools/scripts/auto-version.pl: Protect against
Modified: trunk/WebKitLibraries/win/tools/scripts/auto-version.pl (170953 => 170954)
--- trunk/WebKitLibraries/win/tools/scripts/auto-version.pl 2014-07-10 05:06:30 UTC (rev 170953)
+++ trunk/WebKitLibraries/win/tools/scripts/auto-version.pl 2014-07-10 05:32:40 UTC (rev 170954)
@@ -76,6 +76,14 @@
my $BUILD_MINOR_VERSION = $2;
my $BUILD_TINY_VERSION = $3;
+# The default version (with no decimals) will be matched by the regexp
+# to $BUILD_TINY_VERSION. If that happens, we need to move it to
+# $BUILD_MAJOR_VERSION.
+if (!defined $BUILD_MAJOR_VERSION !defined $BUILD_MINOR_VERSION) {
+$BUILD_MAJOR_VERSION = $BUILD_TINY_VERSION;
+$BUILD_TINY_VERSION = 0;
+}
+
# Cut the major component down to three characters by dropping any
# extra leading digits, then adjust the major version portion of the
# version string to match.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170955] tags/Safari-538.45.1/
Title: [170955] tags/Safari-538.45.1/ Revision 170955 Author bshaf...@apple.com Date 2014-07-09 22:47:18 -0700 (Wed, 09 Jul 2014) Log Message New tag. Added Paths tags/Safari-538.45.1/ Diff Property changes: tags/Safari-538.45.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
