date:20150806

Title: [188041] trunk/Source/WebCore








Revision 188041
Author achristen...@apple.com
Date 2015-08-06 09:36:39 -0700 (Thu, 06 Aug 2015)


Log Message
Fix build without ENABLE(VIDEO) after r188030.

* dom/Document.h:
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
Move definition of HTMLMediaElementInvalidID to Document.h so it can be used outside of ENABLE(VIDEO) macros.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188040 => 188041)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 16:24:38 UTC (rev 188040)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 16:36:39 UTC (rev 188041)
@@ -1,3 +1,12 @@
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
+Fix build without ENABLE(VIDEO) after r188030.
+
+* dom/Document.h:
+* html/HTMLMediaElement.cpp:
+* html/HTMLMediaElement.h:
+Move definition of HTMLMediaElementInvalidID to Document.h so it can be used outside of ENABLE(VIDEO) macros.
+
 2015-08-04  Matt Rajca  mra...@apple.com
 
 Media Session: push paused state to the media session focus manager instead of polling


Modified: trunk/Source/WebCore/dom/Document.h (188040 => 188041)

--- trunk/Source/WebCore/dom/Document.h	2015-08-06 16:24:38 UTC (rev 188040)
+++ trunk/Source/WebCore/dom/Document.h	2015-08-06 16:36:39 UTC (rev 188041)
@@ -226,7 +226,7 @@
 class MediaSession;
 #endif
 
-WEBCORE_EXPORT extern const uint64_t HTMLMediaElementInvalidID;
+const uint64_t HTMLMediaElementInvalidID = 0;
 
 enum PageshowEventPersistence {
 PageshowEventNotPersisted = 0,


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (188040 => 188041)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-08-06 16:24:38 UTC (rev 188040)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-08-06 16:36:39 UTC (rev 188041)
@@ -41,6 +41,7 @@
 #include DiagnosticLoggingClient.h
 #include DiagnosticLoggingKeys.h
 #include DisplaySleepDisabler.h
+#include Document.h
 #include DocumentLoader.h
 #include ElementIterator.h
 #include EventNames.h
@@ -202,8 +203,6 @@
 static const char* mediaStreamBlobProtocol = blob;
 #endif
 
-const uint64_t HTMLMediaElementInvalidID = 0;
-
 using namespace HTMLNames;
 
 typedef HashMapDocument*, HashSetHTMLMediaElement* DocumentElementSetMap;


Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (188040 => 188041)

--- trunk/Source/WebCore/html/HTMLMediaElement.h	2015-08-06 16:24:38 UTC (rev 188040)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2015-08-06 16:36:39 UTC (rev 188041)
@@ -98,8 +98,6 @@
 class MediaStream;
 #endif
 
-extern const uint64_t HTMLMediaElementInvalidID;
-
 class HTMLMediaElement
 : public HTMLElement
 , private MediaPlayerClient, public MediaPlayerSupportsTypeClient, private MediaCanStartListener, public ActiveDOMObject, public MediaControllerInterface , public PlatformMediaSessionClient, private MediaProducer






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188053] trunk/Source/WebKit2

2015-08-06 Thread enrica

Title: [188053] trunk/Source/WebKit2








Revision 188053
Author enr...@apple.com
Date 2015-08-06 13:14:58 -0700 (Thu, 06 Aug 2015)


Log Message
Allow long press to cancel link preview.
https://bugs.webkit.org/show_bug.cgi?id=147743
rdar://problem/22128839

Reviewed by Tim Horton.

We should be able to show the context menu at the beginnig of link preview.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _longPressRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _registerPreview]):
(-[WKContentView _unregisterPreview]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188052 => 188053)

--- trunk/Source/WebKit2/ChangeLog	2015-08-06 19:48:29 UTC (rev 188052)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-06 20:14:58 UTC (rev 188053)
@@ -1,3 +1,23 @@
+2015-08-06  Enrica Casucci  enr...@apple.com
+
+Allow long press to cancel link preview.
+https://bugs.webkit.org/show_bug.cgi?id=147743
+rdar://problem/22128839
+
+Reviewed by Tim Horton.
+
+We should be able to show the context menu at the beginnig of link preview.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _removeDefaultGestureRecognizers]):
+(-[WKContentView _addDefaultGestureRecognizers]):
+(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
+(-[WKContentView _longPressRecognized:]):
+(-[WKContentView _singleTapRecognized:]):
+(-[WKContentView _registerPreview]):
+(-[WKContentView _unregisterPreview]):
+
 2015-08-06  Matt Rajca  mra...@apple.com
 
 Media Session: rename isFocusedContentMediaElementPaused and get rid of callback


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (188052 => 188053)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-08-06 19:48:29 UTC (rev 188052)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-08-06 20:14:58 UTC (rev 188053)
@@ -117,6 +117,7 @@
 RetainPtrWKFormInputSession _formInputSession;
 RetainPtrWKFileUploadPanel _fileUploadPanel;
 RetainPtrUIGestureRecognizer _previewGestureRecognizer;
+RetainPtrUIGestureRecognizer _previewSecondaryGestureRecognizer;
 #if HAVE(LINK_PREVIEW)
 RetainPtrUIPreviewItemController _previewItemController;
 #endif


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188052 => 188053)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 19:48:29 UTC (rev 188052)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 20:14:58 UTC (rev 188053)
@@ -412,7 +412,6 @@
 [self removeGestureRecognizer:_touchEventGestureRecognizer.get()];
 [self removeGestureRecognizer:_singleTapGestureRecognizer.get()];
 [self removeGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
-[self removeGestureRecognizer:_longPressGestureRecognizer.get()];
 [self removeGestureRecognizer:_doubleTapGestureRecognizer.get()];
 [self removeGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
 }
@@ -422,7 +421,6 @@
 [self addGestureRecognizer:_touchEventGestureRecognizer.get()];
 [self addGestureRecognizer:_singleTapGestureRecognizer.get()];
 [self addGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
-[self addGestureRecognizer:_longPressGestureRecognizer.get()];
 [self addGestureRecognizer:_doubleTapGestureRecognizer.get()];
 [self addGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
 }
@@ -873,6 +871,9 @@
 if (isSamePair(gestureRecognizer, otherGestureRecognizer, _singleTapGestureRecognizer.get(), _textSelectionAssistant.get().singleTapGesture))
 return YES;
 
+if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewSecondaryGestureRecognizer.get()))
+return YES;
+
 if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewGestureRecognizer.get()))
 return YES;
 
@@ -1073,21 +1074,25 @@
 {
 ASSERT(gestureRecognizer == _longPressGestureRecognizer);
 
-#if HAVE(LINK_PREVIEW)
-if ([_previewItemController interactionInProgress])
-return;
-#endif
-
 _lastInteractionLocation = gestureRecognizer.startPoint;
 
-if ([gestureRecognizer state] == UIGestureRecognizerStateBegan) {
+switch ([gestureRecognizer state]) {
+case UIGestureRecognizerStateBegan:
+

[webkit-changes] [188055] trunk

Title: [188055] trunk








Revision 188055
Author commit-qu...@webkit.org
Date 2015-08-06 13:40:35 -0700 (Thu, 06 Aug 2015)


Log Message
AX: AXLoadComplete that comes before AX API access won't fire
https://bugs.webkit.org/show_bug.cgi?id=147737

Patch by Doug Russell d_russ...@apple.com on 2015-08-06
Reviewed by Chris Fleizach.

Treat setEnhancedUserInterfaceAccessibility() as AX API access and if true,
enableAccessibility().

Source/WebCore:

Test: accessibility/mac/loaded-notification.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):

LayoutTests:

* accessibility/mac/loaded-notification-expected.txt: Added.
* accessibility/mac/loaded-notification.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp


Added Paths

trunk/LayoutTests/accessibility/mac/loaded-notification-expected.txt
trunk/LayoutTests/accessibility/mac/loaded-notification.html




Diff

Modified: trunk/LayoutTests/ChangeLog (188054 => 188055)

--- trunk/LayoutTests/ChangeLog	2015-08-06 20:33:15 UTC (rev 188054)
+++ trunk/LayoutTests/ChangeLog	2015-08-06 20:40:35 UTC (rev 188055)
@@ -1,3 +1,16 @@
+2015-08-06  Doug Russell  d_russ...@apple.com
+
+AX: AXLoadComplete that comes before AX API access won't fire
+https://bugs.webkit.org/show_bug.cgi?id=147737
+
+Reviewed by Chris Fleizach.
+
+Treat setEnhancedUserInterfaceAccessibility() as AX API access and if true,
+enableAccessibility().
+
+* accessibility/mac/loaded-notification-expected.txt: Added.
+* accessibility/mac/loaded-notification.html: Added.
+
 2015-08-05  Alexey Proskuryakov  a...@apple.com
 
 Fix TestExpectations lint warnings.


Added: trunk/LayoutTests/accessibility/mac/loaded-notification-expected.txt (0 => 188055)

--- trunk/LayoutTests/accessibility/mac/loaded-notification-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/loaded-notification-expected.txt	2015-08-06 20:40:35 UTC (rev 188055)
@@ -0,0 +1,10 @@
+This tests that when enable enhanced accessibility is true and no other accessibility API is called, the load notification will successfully fire.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS addedNotification is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/mac/loaded-notification.html (0 => 188055)

--- trunk/LayoutTests/accessibility/mac/loaded-notification.html	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/loaded-notification.html	2015-08-06 20:40:35 UTC (rev 188055)
@@ -0,0 +1,34 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body id=body
+
+p id=description/p
+div id=console/div
+div id=notifications/div
+
+script
+
+description(This tests that when enable enhanced accessibility is true and no other accessibility API is called, the load notification will successfully fire.);
+
+function notifyCallback(element, notification) {
+if (notification == AXLoadComplete) {
+accessibilityController.removeNotificationListener();
+window.testRunner.notifyDone();
+}
+}
+
+if (window.accessibilityController) {
+window.testRunner.waitUntilDone();
+accessibilityController.enableEnhancedAccessibility(true);
+var addedNotification = accessibilityController.addNotificationListener(notifyCallback);
+shouldBe(addedNotification, true);
+}
+
+/script
+
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (188054 => 188055)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 20:33:15 UTC (rev 188054)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 20:40:35 UTC (rev 188055)
@@ -1,3 +1,18 @@
+2015-08-06  Doug Russell  d_russ...@apple.com
+
+AX: AXLoadComplete that comes before AX API access won't fire
+https://bugs.webkit.org/show_bug.cgi?id=147737
+
+Reviewed by Chris Fleizach.
+
+Treat setEnhancedUserInterfaceAccessibility() as AX API access and if true,
+enableAccessibility().
+
+Test: accessibility/mac/loaded-notification.html
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
+
 2015-08-06  Eric Carlson  eric.carl...@apple.com
 
 Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (188054 => 188055)

--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2015-08-06 20:33:15 UTC (rev 188054)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2015-08-06 20:40:35 UTC (rev 188055)
@@ -129,6 +129,8 @@
 void AXObjectCache::setEnhancedUserInterfaceAccessibility(bool flag)
 {
 gAccessibilityEnhancedUserInterfaceEnabled = flag;
+if (flag)
+

[webkit-changes] [188057] trunk/Source/WebCore

Title: [188057] trunk/Source/WebCore








Revision 188057
Author mmaxfi...@apple.com
Date 2015-08-06 13:53:33 -0700 (Thu, 06 Aug 2015)


Log Message
Add comment to CSSParserString
https://bugs.webkit.org/show_bug.cgi?id=147724

Reviewed by Dean Jackson.

No new tests because there is no behavior change.

* css/CSSParserValues.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParserValues.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188056 => 188057)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 20:45:50 UTC (rev 188056)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 20:53:33 UTC (rev 188057)
@@ -1,5 +1,16 @@
 2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
 
+Add comment to CSSParserString
+https://bugs.webkit.org/show_bug.cgi?id=147724
+
+Reviewed by Dean Jackson.
+
+No new tests because there is no behavior change.
+
+* css/CSSParserValues.h:
+
+2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
+
 Font feature settings comparisons are order-dependent and case-dependent
 https://bugs.webkit.org/show_bug.cgi?id=147719
 


Modified: trunk/Source/WebCore/css/CSSParserValues.h (188056 => 188057)

--- trunk/Source/WebCore/css/CSSParserValues.h	2015-08-06 20:45:50 UTC (rev 188056)
+++ trunk/Source/WebCore/css/CSSParserValues.h	2015-08-06 20:53:33 UTC (rev 188057)
@@ -32,6 +32,9 @@
 class CSSValue;
 class QualifiedName;
 
+// This can't be a StringView for 2 reasons:
+// 1. lower() clobbers the data we point to.
+// 2. We are an element of a union (in CSSParserValue) so we need to have a trivial destructor.
 struct CSSParserString {
 void init(LChar* characters, unsigned length)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188065] trunk/Tools

2015-08-06 Thread rniwa

Title: [188065] trunk/Tools








Revision 188065
Author rn...@webkit.org
Date 2015-08-06 15:23:31 -0700 (Thu, 06 Aug 2015)


Log Message
Automate JSBench with run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=147716

Reviewed by Chris Dumez.

Added JSBench plan to run-benchmark.

* Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
(GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
(GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
* Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
* Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
* Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
* Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
* Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
* Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
* Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
* Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
* Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan


Added Paths

trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan




Diff

Modified: trunk/Tools/ChangeLog (188064 => 188065)

--- trunk/Tools/ChangeLog	2015-08-06 22:16:01 UTC (rev 188064)
+++ trunk/Tools/ChangeLog	2015-08-06 22:23:31 UTC (rev 188065)
@@ -1,3 +1,29 @@
+2015-08-06  Ryosuke Niwa  rn...@webkit.org
+
+Automate JSBench with run-benchmark
+https://bugs.webkit.org/show_bug.cgi?id=147716
+
+Reviewed by Chris Dumez.
+
+Added JSBench plan to run-benchmark.
+
+* Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
+(GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
+(GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
+* Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
+* Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
+* Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
+* Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
+* Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
+* Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
+* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
+* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
+* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
+* Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
+* Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
+* Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
+* Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
+
 2015-08-06  Yusuke Suzuki  utatane@gmail.com
 
 Pass-through the undefined options in run-jsc


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py (188064 => 188065)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py	2015-08-06 22:16:01 UTC (rev 188064)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py	2015-08-06 22:23:31 UTC (rev 188065)
@@ -6,6 +6,7 @@
 import urllib
 import shutil
 import subprocess
+import tarfile
 
 from zipfile import ZipFile
 from webkitpy.benchmark_runner.utils import get_path_from_project_root, force_remove
@@ -55,12 +56,23 @@

[webkit-changes] [188056] trunk

Title: [188056] trunk








Revision 188056
Author mmaxfi...@apple.com
Date 2015-08-06 13:45:50 -0700 (Thu, 06 Aug 2015)


Log Message
Font feature settings comparisons are order-dependent and case-dependent
https://bugs.webkit.org/show_bug.cgi?id=147719

Reviewed by Benjamin Poulain.

Source/WebCore:

We should make our settings vector order-independent and case-independent.

Test: css3/font-feature-settings-parsing.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFeatureTag):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertFontFeatureSettings):
* platform/graphics/FontFeatureSettings.cpp:
(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator==):
(WebCore::FontFeatureSettings::FontFeatureSettings):
* platform/graphics/FontFeatureSettings.h:
(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator==):
(WebCore::FontFeature::operator):
(WebCore::FontFeatureSettings::insert):
(WebCore::FontFeatureSettings::FontFeatureSettings):
(WebCore::FontFeatureSettings::append): Deleted.

LayoutTests:

Make the test insensitive to order and case.

* css3/font-feature-settings-parsing-expected.txt:
* css3/font-feature-settings-parsing.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/font-feature-settings-parsing-expected.txt
trunk/LayoutTests/css3/font-feature-settings-parsing.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/StyleBuilderConverter.h
trunk/Source/WebCore/platform/graphics/FontFeatureSettings.cpp
trunk/Source/WebCore/platform/graphics/FontFeatureSettings.h




Diff

Modified: trunk/LayoutTests/ChangeLog (188055 => 188056)

--- trunk/LayoutTests/ChangeLog	2015-08-06 20:40:35 UTC (rev 188055)
+++ trunk/LayoutTests/ChangeLog	2015-08-06 20:45:50 UTC (rev 188056)
@@ -1,3 +1,15 @@
+2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
+
+Font feature settings comparisons are order-dependent and case-dependent
+https://bugs.webkit.org/show_bug.cgi?id=147719
+
+Reviewed by Benjamin Poulain.
+
+Make the test insensitive to order and case.
+
+* css3/font-feature-settings-parsing-expected.txt:
+* css3/font-feature-settings-parsing.html:
+
 2015-08-06  Doug Russell  d_russ...@apple.com
 
 AX: AXLoadComplete that comes before AX API access won't fire


Modified: trunk/LayoutTests/css3/font-feature-settings-parsing-expected.txt (188055 => 188056)

--- trunk/LayoutTests/css3/font-feature-settings-parsing-expected.txt	2015-08-06 20:40:35 UTC (rev 188055)
+++ trunk/LayoutTests/css3/font-feature-settings-parsing-expected.txt	2015-08-06 20:45:50 UTC (rev 188056)
@@ -4,17 +4,17 @@
 
 
 - Tests valid inputs.
-PASS parseResultOf(valid_normal) is normal
-PASS parseResultOf(valid_value_1) is 'dlig' 1
-PASS parseResultOf(valid_value_2) is 'swsh' 2
-PASS parseResultOf(valid_value_on) is 'smcp' 1
-PASS parseResultOf(valid_value_off) is 'liga' 0
-PASS parseResultOf(valid_value_omit) is 'c2sc' 1
-PASS parseResultOf(valid_valuelist) is 'tnum' 1, 'hist' 1
-PASS parseResultOf(valid_singlequote) is 'PKRN' 1
-PASS parseResultOf(valid_unusual_tag) is '!@#$' 1
-PASS parseResultOf(valid_tag_space) is 'a bc' 1
-PASS parseResultOf(valid_composite) is 'dlig' 1, 'smcp' 1, 'lig ' 0
+PASS canonicalize(parseResultOf(valid_normal)) is normal
+PASS canonicalize(parseResultOf(valid_value_1)) is 'dlig' 1
+PASS canonicalize(parseResultOf(valid_value_2)) is 'swsh' 2
+PASS canonicalize(parseResultOf(valid_value_on)) is 'smcp' 1
+PASS canonicalize(parseResultOf(valid_value_off)) is 'liga' 0
+PASS canonicalize(parseResultOf(valid_value_omit)) is 'c2sc' 1
+PASS canonicalize(parseResultOf(valid_valuelist)) is 'hist' 1, 'tnum' 1
+PASS canonicalize(parseResultOf(valid_singlequote)) is 'pkrn' 1
+PASS canonicalize(parseResultOf(valid_unusual_tag)) is '!@#$' 1
+PASS canonicalize(parseResultOf(valid_tag_space)) is 'a bc' 1
+PASS canonicalize(parseResultOf(valid_composite)) is 'dlig' 1, 'lig ' 0, 'smcp' 1
 - Tests invalid inputs.  Results should be normal.
 PASS parseResultOf(invalid_ident) is normal
 PASS parseResultOf(invalid_cases) is normal
@@ -34,10 +34,10 @@
 PASS parseResultOf(invalid_on) is normal
 PASS parseResultOf(invalid_0) is normal
 - Tests inherit.
-PASS parseResultOf(outer) is 'dlig' 1
-PASS parseResultOf(inner) is 'dlig' 1
+PASS canonicalize(parseResultOf(outer)) is 'dlig' 1
+PASS canonicalize(parseResultOf(inner)) is 'dlig' 1
 - Tests @font-face.
-PASS fontFaceRuleValid is 'liga' 1
+PASS canonicalize(fontFaceRuleValid) is 'liga' 1
 PASS fontFaceRuleInvalid is 
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/css3/font-feature-settings-parsing.html (188055 => 188056)

--- trunk/LayoutTests/css3/font-feature-settings-parsing.html	2015-08-06 20:40:35 UTC (rev 188055)
+++ trunk/LayoutTests/css3/font-feature-settings-parsing.html	2015-08-06 20:45:50 UTC (rev 188056)
@@ -168,23 +168,32 @@
 script
 description('Test parsing of the CSS3

[webkit-changes] [188062] trunk/Source/WebCore

2015-08-06 Thread eric . carlson

Title: [188062] trunk/Source/WebCore








Revision 188062
Author eric.carl...@apple.com
Date 2015-08-06 14:36:00 -0700 (Thu, 06 Aug 2015)


Log Message
Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument
https://bugs.webkit.org/show_bug.cgi?id=147734
rdar://problem/22028179

Reviewed by Andy Estes.

Test to follow, see https://bugs.webkit.org/show_bug.cgi?id=147735

* dom/Document.cpp:
(WebCore::Document::initSecurityContext): Use applyContentDispositionAttachmentSandbox
  instead of setting sandbox flags directly.
(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Don't special
  case MediaDocument.
(WebCore::Document::applyContentDispositionAttachmentSandbox): Apply sandbox flags
  according to document type.
* dom/Document.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188061 => 188062)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 21:23:55 UTC (rev 188061)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 21:36:00 UTC (rev 188062)
@@ -1,3 +1,22 @@
+2015-08-06  Eric Carlson  eric.carl...@apple.com
+
+Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument
+https://bugs.webkit.org/show_bug.cgi?id=147734
+rdar://problem/22028179
+
+Reviewed by Andy Estes.
+
+Test to follow, see https://bugs.webkit.org/show_bug.cgi?id=147735
+
+* dom/Document.cpp:
+(WebCore::Document::initSecurityContext): Use applyContentDispositionAttachmentSandbox
+  instead of setting sandbox flags directly.
+(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Don't special
+  case MediaDocument.
+(WebCore::Document::applyContentDispositionAttachmentSandbox): Apply sandbox flags
+  according to document type.
+* dom/Document.h:
+
 2015-08-06  Anders Carlsson  ander...@apple.com
 
 Get rid of DatabaseBackendBase


Modified: trunk/Source/WebCore/dom/Document.cpp (188061 => 188062)

--- trunk/Source/WebCore/dom/Document.cpp	2015-08-06 21:23:55 UTC (rev 188061)
+++ trunk/Source/WebCore/dom/Document.cpp	2015-08-06 21:36:00 UTC (rev 188062)
@@ -4936,7 +4936,7 @@
 enforceSandboxFlags(m_frame-loader().effectiveSandboxFlags());
 
 if (shouldEnforceContentDispositionAttachmentSandbox())
-enforceSandboxFlags(SandboxAll);
+applyContentDispositionAttachmentSandbox();
 
 setSecurityOriginPolicy(SecurityOriginPolicy::create(isSandboxed(SandboxOrigin) ? SecurityOrigin::createUnique() : SecurityOrigin::create(m_url)));
 setContentSecurityPolicy(std::make_uniqueContentSecurityPolicy(this));
@@ -6717,9 +6717,6 @@
 if (m_isSynthesized)
 return false;
 
-if (isMediaDocument())
-return false;
-
 bool contentDispositionAttachmentSandboxEnabled = settings()  settings()-contentDispositionAttachmentSandboxEnabled();
 bool responseIsAttachment = false;
 if (DocumentLoader* documentLoader = m_frame ? m_frame-loader().activeDocumentLoader() : nullptr)
@@ -6728,4 +6725,14 @@
 return contentDispositionAttachmentSandboxEnabled  responseIsAttachment;
 }
 
+void Document::applyContentDispositionAttachmentSandbox()
+{
+ASSERT(shouldEnforceContentDispositionAttachmentSandbox());
+
+if (!isMediaDocument())
+enforceSandboxFlags(SandboxAll);
+else
+enforceSandboxFlags(SandboxOrigin);
+}
+
 } // namespace WebCore


Modified: trunk/Source/WebCore/dom/Document.h (188061 => 188062)

--- trunk/Source/WebCore/dom/Document.h	2015-08-06 21:23:55 UTC (rev 188061)
+++ trunk/Source/WebCore/dom/Document.h	2015-08-06 21:36:00 UTC (rev 188062)
@@ -1279,6 +1279,7 @@
 
 ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicyToPropagate() const;
 bool shouldEnforceContentDispositionAttachmentSandbox() const;
+void applyContentDispositionAttachmentSandbox();
 
 protected:
 enum ConstructionFlags { Synthesized = 1, NonRenderedPlaceholder = 1  1 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188064] trunk/Websites/webkit.org

Title: [188064] trunk/Websites/webkit.org








Revision 188064
Author bfulg...@apple.com
Date 2015-08-06 15:16:01 -0700 (Thu, 06 Aug 2015)


Log Message
Add more media control examples.

* blog-files/backdrop-filters/dynamic_backdrop.m4v: Added.
* blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg: Added.
* blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg: Added.

Modified Paths

trunk/Websites/webkit.org/ChangeLog


Added Paths

trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_Complete_1x.jpg
trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg
trunk/Websites/webkit.org/blog-files/backdrop-filters/dynamic_backdrop.m4v




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (188063 => 188064)

--- trunk/Websites/webkit.org/ChangeLog	2015-08-06 21:38:18 UTC (rev 188063)
+++ trunk/Websites/webkit.org/ChangeLog	2015-08-06 22:16:01 UTC (rev 188064)
@@ -1,5 +1,13 @@
 2015-08-06  Brent Fulgham  bfulg...@apple.com
 
+Add more media control examples.
+
+* blog-files/backdrop-filters/dynamic_backdrop.m4v: Added.
+* blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg: Added.
+* blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg: Added.
+
+2015-08-06  Brent Fulgham  bfulg...@apple.com
+
 Add two more files for a future blog post.
 
 * blog-files/backdrop-filters/Media_Controls_1x.jpg: Added.


Added: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_Complete_1x.jpg

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_Complete_1x.jpg
___

Added: svn:mime-type

Added: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg
___

Added: svn:mime-type

Added: trunk/Websites/webkit.org/blog-files/backdrop-filters/dynamic_backdrop.m4v

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/blog-files/backdrop-filters/dynamic_backdrop.m4v
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188054] branches/safari-601.1.46-branch/Source/WebKit2

Title: [188054] branches/safari-601.1.46-branch/Source/WebKit2








Revision 188054
Author bshaf...@apple.com
Date 2015-08-06 13:33:15 -0700 (Thu, 06 Aug 2015)


Log Message
Merged r188053.  rdar://problem/22128839

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188053 => 188054)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-06 20:14:58 UTC (rev 188053)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-06 20:33:15 UTC (rev 188054)
@@ -1,5 +1,29 @@
 2015-08-06  Babak Shafiei  bshaf...@apple.com
 
+Merge r188053.
+
+2015-08-06  Enrica Casucci  enr...@apple.com
+
+Allow long press to cancel link preview.
+https://bugs.webkit.org/show_bug.cgi?id=147743
+rdar://problem/22128839
+
+Reviewed by Tim Horton.
+
+We should be able to show the context menu at the beginnig of link preview.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _removeDefaultGestureRecognizers]):
+(-[WKContentView _addDefaultGestureRecognizers]):
+(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
+(-[WKContentView _longPressRecognized:]):
+(-[WKContentView _singleTapRecognized:]):
+(-[WKContentView _registerPreview]):
+(-[WKContentView _unregisterPreview]):
+
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
 Merge r186849.
 
 2015-07-14  Enrica Casucci  enr...@apple.com


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (188053 => 188054)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-08-06 20:14:58 UTC (rev 188053)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-08-06 20:33:15 UTC (rev 188054)
@@ -121,6 +121,7 @@
 RetainPtrWKFormInputSession _formInputSession;
 RetainPtrWKFileUploadPanel _fileUploadPanel;
 RetainPtrUIGestureRecognizer _previewGestureRecognizer;
+RetainPtrUIGestureRecognizer _previewSecondaryGestureRecognizer;
 #if HAVE(LINK_PREVIEW)
 RetainPtrUIPreviewItemController _previewItemController;
 #endif


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188053 => 188054)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 20:14:58 UTC (rev 188053)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 20:33:15 UTC (rev 188054)
@@ -416,7 +416,6 @@
 [self removeGestureRecognizer:_touchEventGestureRecognizer.get()];
 [self removeGestureRecognizer:_singleTapGestureRecognizer.get()];
 [self removeGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
-[self removeGestureRecognizer:_longPressGestureRecognizer.get()];
 [self removeGestureRecognizer:_doubleTapGestureRecognizer.get()];
 [self removeGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
 }
@@ -426,7 +425,6 @@
 [self addGestureRecognizer:_touchEventGestureRecognizer.get()];
 [self addGestureRecognizer:_singleTapGestureRecognizer.get()];
 [self addGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
-[self addGestureRecognizer:_longPressGestureRecognizer.get()];
 [self addGestureRecognizer:_doubleTapGestureRecognizer.get()];
 [self addGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
 }
@@ -876,6 +874,9 @@
 if (isSamePair(gestureRecognizer, otherGestureRecognizer, _singleTapGestureRecognizer.get(), _textSelectionAssistant.get().singleTapGesture))
 return YES;
 
+if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewSecondaryGestureRecognizer.get()))
+return YES;
+
 if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewGestureRecognizer.get()))
 return YES;
 
@@ -1076,21 +1077,25 @@
 {
 ASSERT(gestureRecognizer == _longPressGestureRecognizer);
 
-#if HAVE(LINK_PREVIEW)
-if ([_previewItemController interactionInProgress])
-return;
-#endif
-
 _lastInteractionLocation = gestureRecognizer.startPoint;
 
-if ([gestureRecognizer state] == UIGestureRecognizerStateBegan) {
+switch ([gestureRecognizer state]) {
+case UIGestureRecognizerStateBegan:
+{
 SEL action = "" _actionForLongPress];
 if (action) {
 [self performSelector:action];
 [self

[webkit-changes] [188061] trunk/Source/WebCore

Title: [188061] trunk/Source/WebCore








Revision 188061
Author ander...@apple.com
Date 2015-08-06 14:23:55 -0700 (Thu, 06 Aug 2015)


Log Message
Get rid of DatabaseBackendBase
https://bugs.webkit.org/show_bug.cgi?id=147733

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
* Modules/webdatabase/Database.h:
* Modules/webdatabase/DatabaseBackendBase.cpp: Removed.
(WebCore::DatabaseBackendBase::DatabaseBackendBase): Deleted.
(WebCore::DatabaseBackendBase::~DatabaseBackendBase): Deleted.
* Modules/webdatabase/DatabaseBackendBase.h: Removed.
* Modules/webdatabase/DatabaseManager.cpp:
* Modules/webdatabase/DatabaseManager.h:
* Modules/webdatabase/DatabaseTracker.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/Database.cpp
trunk/Source/WebCore/Modules/webdatabase/Database.h
trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp
trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h
trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Removed Paths

trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp
trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (188060 => 188061)

--- trunk/Source/WebCore/CMakeLists.txt	2015-08-06 21:23:10 UTC (rev 188060)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-08-06 21:23:55 UTC (rev 188061)
@@ -1003,7 +1003,6 @@
 Modules/webdatabase/DOMWindowWebDatabase.cpp
 Modules/webdatabase/Database.cpp
 Modules/webdatabase/DatabaseAuthorizer.cpp
-Modules/webdatabase/DatabaseBackendBase.cpp
 Modules/webdatabase/DatabaseContext.cpp
 Modules/webdatabase/DatabaseManager.cpp
 Modules/webdatabase/DatabaseServer.cpp


Modified: trunk/Source/WebCore/ChangeLog (188060 => 188061)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 21:23:10 UTC (rev 188060)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 21:23:55 UTC (rev 188061)
@@ -1,3 +1,27 @@
+2015-08-06  Anders Carlsson  ander...@apple.com
+
+Get rid of DatabaseBackendBase
+https://bugs.webkit.org/show_bug.cgi?id=147733
+
+Reviewed by Geoffrey Garen.
+
+* CMakeLists.txt:
+* Modules/webdatabase/Database.cpp:
+(WebCore::Database::Database):
+(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
+(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
+* Modules/webdatabase/Database.h:
+* Modules/webdatabase/DatabaseBackendBase.cpp: Removed.
+(WebCore::DatabaseBackendBase::DatabaseBackendBase): Deleted.
+(WebCore::DatabaseBackendBase::~DatabaseBackendBase): Deleted.
+* Modules/webdatabase/DatabaseBackendBase.h: Removed.
+* Modules/webdatabase/DatabaseManager.cpp:
+* Modules/webdatabase/DatabaseManager.h:
+* Modules/webdatabase/DatabaseTracker.cpp:
+* WebCore.vcxproj/WebCore.vcxproj:
+* WebCore.vcxproj/WebCore.vcxproj.filters:
+* WebCore.xcodeproj/project.pbxproj:
+
 2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
 
 Add comment to CSSParserString


Modified: trunk/Source/WebCore/Modules/webdatabase/Database.cpp (188060 => 188061)

--- trunk/Source/WebCore/Modules/webdatabase/Database.cpp	2015-08-06 21:23:10 UTC (rev 188060)
+++ trunk/Source/WebCore/Modules/webdatabase/Database.cpp	2015-08-06 21:23:55 UTC (rev 188061)
@@ -189,7 +189,7 @@
 guidToVersionMap().set(guid, newVersion.isEmpty() ? String() : newVersion.isolatedCopy());
 }
 
-typedef HashMapDatabaseGuid, std::unique_ptrHashSetDatabaseBackendBase* GuidDatabaseMap;
+typedef HashMapDatabaseGuid, std::unique_ptrHashSetDatabase* GuidDatabaseMap;
 
 static GuidDatabaseMap guidToDatabaseMap()
 {
@@ -236,9 +236,9 @@
 std::lock_guardstd::mutex locker(guidMutex());
 
 m_guid = guidForOriginAndName(securityOrigin()-toString(), name);
-std::unique_ptrHashSetDatabaseBackendBase* hashSet = guidToDatabaseMap().add(m_guid, nullptr).iterator-value;
+std::unique_ptrHashSetDatabase* hashSet = guidToDatabaseMap().add(m_guid, nullptr).iterator-value;
 if (!hashSet)
-hashSet = std::make_uniqueHashSetDatabaseBackendBase*();
+hashSet = std::make_uniqueHashSetDatabase*();
 hashSet-add(this);
 }
 
@@ -324,20 +324,20 @@
 
 class DoneCreatingDatabaseOnExitCaller {
 public:
-DoneCreatingDatabaseOnExitCaller(DatabaseBackendBase*

[webkit-changes] [188060] branches/safari-601.1.46-branch/Source/WebKit2

Title: [188060] branches/safari-601.1.46-branch/Source/WebKit2








Revision 188060
Author bshaf...@apple.com
Date 2015-08-06 14:23:10 -0700 (Thu, 06 Aug 2015)


Log Message
Merged r188058.  rdar://problem/22128839

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188059 => 188060)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-06 21:17:03 UTC (rev 188059)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-06 21:23:10 UTC (rev 188060)
@@ -1,5 +1,18 @@
 2015-08-06  Babak Shafiei  bshaf...@apple.com
 
+Merge r188058.
+
+2015-08-06  Enrica Casucci  enr...@apple.com
+
+Build fix for iOS after http://trac.webkit.org/changeset/188053.
+
+Unreviewed.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _registerPreview]):
+
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
 Merge r188053.
 
 2015-08-06  Enrica Casucci  enr...@apple.com


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188059 => 188060)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 21:17:03 UTC (rev 188059)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 21:23:10 UTC (rev 188060)
@@ -220,6 +220,10 @@
 @end
 
 @protocol UISelectionInteractionAssistant;
+@interface UIPreviewItemController (StagingToRemove)
+@property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer;
+@end
+
 #endif
 
 @interface WKFormInputSession : NSObject _WKFormInputSession
@@ -3221,7 +3225,8 @@
 _previewItemController = adoptNS([[UIPreviewItemController alloc] initWithView:self]);
 [_previewItemController setDelegate:self];
 _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer;
-_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer;
+if ([_previewItemController respondsToSelector:@selector(presentationSecondaryGestureRecognizer)])
+_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer;
 }
 
 - (void)_unregisterPreview






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188066] trunk/Source/WebCore

Title: [188066] trunk/Source/WebCore








Revision 188066
Author ander...@apple.com
Date 2015-08-06 15:32:06 -0700 (Thu, 06 Aug 2015)


Log Message
SQLStatementBackend doesn't need to be refcounted
https://bugs.webkit.org/show_bug.cgi?id=147748

Reviewed by Geoffrey Garen.

There's no shared ownership of SQLStatementBackend so we can just use std::unique_ptr.

* Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::create): Deleted.
* Modules/webdatabase/SQLStatementBackend.h:
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::executeSQL):
* Modules/webdatabase/SQLTransactionBackend.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.h
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188065 => 188066)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 22:23:31 UTC (rev 188065)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 22:32:06 UTC (rev 188066)
@@ -1,3 +1,20 @@
+2015-08-06  Anders Carlsson  ander...@apple.com
+
+SQLStatementBackend doesn't need to be refcounted
+https://bugs.webkit.org/show_bug.cgi?id=147748
+
+Reviewed by Geoffrey Garen.
+
+There's no shared ownership of SQLStatementBackend so we can just use std::unique_ptr.
+
+* Modules/webdatabase/SQLStatementBackend.cpp:
+(WebCore::SQLStatementBackend::create): Deleted.
+* Modules/webdatabase/SQLStatementBackend.h:
+* Modules/webdatabase/SQLTransactionBackend.cpp:
+(WebCore::SQLTransactionBackend::enqueueStatementBackend):
+(WebCore::SQLTransactionBackend::executeSQL):
+* Modules/webdatabase/SQLTransactionBackend.h:
+
 2015-08-06  Eric Carlson  eric.carl...@apple.com
 
 Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument


Modified: trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp (188065 => 188066)

--- trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp	2015-08-06 22:23:31 UTC (rev 188065)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp	2015-08-06 22:32:06 UTC (rev 188066)
@@ -75,12 +75,6 @@
 
 namespace WebCore {
 
-RefSQLStatementBackend SQLStatementBackend::create(std::unique_ptrSQLStatement frontend,
-const String statement, const VectorSQLValue arguments, int permissions)
-{
-return adoptRef(*new SQLStatementBackend(WTF::move(frontend), statement, arguments, permissions));
-}
-
 SQLStatementBackend::SQLStatementBackend(std::unique_ptrSQLStatement frontend,
 const String statement, const VectorSQLValue arguments, int permissions)
 : m_frontend(WTF::move(frontend))


Modified: trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.h (188065 => 188066)

--- trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.h	2015-08-06 22:23:31 UTC (rev 188065)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.h	2015-08-06 22:32:06 UTC (rev 188066)
@@ -41,11 +41,10 @@
 class SQLStatement;
 class SQLTransactionBackend;
 
-class SQLStatementBackend : public ThreadSafeRefCountedSQLStatementBackend {
+class SQLStatementBackend {
 public:
-static RefSQLStatementBackend create(std::unique_ptrSQLStatement,
-const String sqlStatement, const VectorSQLValue arguments, int permissions);
-virtual ~SQLStatementBackend();
+SQLStatementBackend(std::unique_ptrSQLStatement, const String statement, const VectorSQLValue arguments, int permissions);
+~SQLStatementBackend();
 
 bool execute(Database);
 bool lastExecutionFailedDueToQuota() const;
@@ -61,9 +60,6 @@
 PassRefPtrSQLResultSet sqlResultSet() const;
 
 private:
-SQLStatementBackend(std::unique_ptrSQLStatement, const String statement,
-const VectorSQLValue arguments, int permissions);
-
 void setFailureDueToQuota();
 void clearFailureDueToQuota();
 


Modified: trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp (188065 => 188066)

--- trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp	2015-08-06 22:23:31 UTC (rev 188065)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp	2015-08-06 22:32:06 UTC (rev 188066)
@@ -463,10 +463,10 @@
 return stateFunctions[static_castint(state)];
 }
 
-void SQLTransactionBackend::enqueueStatementBackend(PassRefPtrSQLStatementBackend statementBackend)
+void SQLTransactionBackend::enqueueStatementBackend(std::unique_ptrSQLStatementBackend statementBackend)
 {
 MutexLocker locker(m_statementMutex);
-m_statementQueue.append(statementBackend);
+m_statementQueue.append(WTF::move(statementBackend));
 }
 
 void SQLTransactionBackend::computeNextStateAndCleanupIfNeeded()
@@ -525,13 +525,12 @@

[webkit-changes] [188058] trunk/Source/WebKit2

2015-08-06 Thread enrica

Title: [188058] trunk/Source/WebKit2








Revision 188058
Author enr...@apple.com
Date 2015-08-06 14:03:02 -0700 (Thu, 06 Aug 2015)


Log Message
Build fix for iOS after http://trac.webkit.org/changeset/188053.

Unreviewed.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _registerPreview]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188057 => 188058)

--- trunk/Source/WebKit2/ChangeLog	2015-08-06 20:53:33 UTC (rev 188057)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-06 21:03:02 UTC (rev 188058)
@@ -1,5 +1,14 @@
 2015-08-06  Enrica Casucci  enr...@apple.com
 
+Build fix for iOS after http://trac.webkit.org/changeset/188053.
+
+Unreviewed.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _registerPreview]):
+
+2015-08-06  Enrica Casucci  enr...@apple.com
+
 Allow long press to cancel link preview.
 https://bugs.webkit.org/show_bug.cgi?id=147743
 rdar://problem/22128839


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188057 => 188058)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 20:53:33 UTC (rev 188057)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 21:03:02 UTC (rev 188058)
@@ -216,6 +216,10 @@
 
 #if __IPHONE_OS_VERSION_MIN_REQUIRED = 9
 @protocol UISelectionInteractionAssistant;
+@interface UIPreviewItemController (StagingToRemove)
+@property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer;
+@end
+
 #endif
 
 @interface WKFormInputSession : NSObject _WKFormInputSession
@@ -3222,7 +3226,8 @@
 _previewItemController = adoptNS([[UIPreviewItemController alloc] initWithView:self]);
 [_previewItemController setDelegate:self];
 _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer;
-_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer;
+if ([_previewItemController respondsToSelector:@selector(presentationSecondaryGestureRecognizer)])
+_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer;
 }
 
 - (void)_unregisterPreview






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188067] trunk/Source/JavaScriptCore

2015-08-06 Thread fpizlo

Title: [188067] trunk/Source/_javascript_Core








Revision 188067
Author fpi...@apple.com
Date 2015-08-06 15:36:34 -0700 (Thu, 06 Aug 2015)


Log Message
Structures used for tryGetConstantProperty() should be registered first
https://bugs.webkit.org/show_bug.cgi?id=147750

Reviewed by Saam Barati and Michael Saboff.

* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::tryGetConstantProperty): Add an assertion to that effect. This should catch the bug sooner.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addStructureSet): Register structures when we make a structure set. That ensures that we won't call tryGetConstantProperty() on a structure that hasn't been registered yet.
* dfg/DFGStructureRegistrationPhase.cpp:
(JSC::DFG::StructureRegistrationPhase::run): Don't register structure sets here anymore. Registering them before we get here means there is no chance of the code being DCE'd before the structures get registered. It also enables the tryGetConstantProperty() assertion, since that code runs before StructureRegisterationPhase.
(JSC::DFG::StructureRegistrationPhase::registerStructures):
(JSC::DFG::StructureRegistrationPhase::registerStructure):
(JSC::DFG::StructureRegistrationPhase::assertAreRegistered):
(JSC::DFG::StructureRegistrationPhase::assertIsRegistered):
(JSC::DFG::performStructureRegistration):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGStructureRegistrationPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (188066 => 188067)

--- trunk/Source/_javascript_Core/ChangeLog	2015-08-06 22:32:06 UTC (rev 188066)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-08-06 22:36:34 UTC (rev 188067)
@@ -1,3 +1,22 @@
+2015-08-06  Filip Pizlo  fpi...@apple.com
+
+Structures used for tryGetConstantProperty() should be registered first
+https://bugs.webkit.org/show_bug.cgi?id=147750
+
+Reviewed by Saam Barati and Michael Saboff.
+
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::tryGetConstantProperty): Add an assertion to that effect. This should catch the bug sooner.
+* dfg/DFGGraph.h:
+(JSC::DFG::Graph::addStructureSet): Register structures when we make a structure set. That ensures that we won't call tryGetConstantProperty() on a structure that hasn't been registered yet.
+* dfg/DFGStructureRegistrationPhase.cpp:
+(JSC::DFG::StructureRegistrationPhase::run): Don't register structure sets here anymore. Registering them before we get here means there is no chance of the code being DCE'd before the structures get registered. It also enables the tryGetConstantProperty() assertion, since that code runs before StructureRegisterationPhase.
+(JSC::DFG::StructureRegistrationPhase::registerStructures):
+(JSC::DFG::StructureRegistrationPhase::registerStructure):
+(JSC::DFG::StructureRegistrationPhase::assertAreRegistered):
+(JSC::DFG::StructureRegistrationPhase::assertIsRegistered):
+(JSC::DFG::performStructureRegistration):
+
 2015-08-06  Keith Miller  keith_mil...@apple.com
 
 Remove UnspecifiedBoolType from JSC


Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (188066 => 188067)

--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2015-08-06 22:32:06 UTC (rev 188066)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2015-08-06 22:36:34 UTC (rev 188067)
@@ -1002,6 +1002,8 @@
 
 for (unsigned i = structureSet.size(); i--;) {
 Structure* structure = structureSet[i];
+assertIsRegistered(structure);
+
 WatchpointSet* set = structure-propertyReplacementWatchpointSet(offset);
 if (!set || !set-isStillValid())
 return JSValue();


Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.h (188066 => 188067)

--- trunk/Source/_javascript_Core/dfg/DFGGraph.h	2015-08-06 22:32:06 UTC (rev 188066)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.h	2015-08-06 22:36:34 UTC (rev 188067)
@@ -325,6 +325,8 @@
 
 StructureSet* addStructureSet(const StructureSet structureSet)
 {
+for (Structure* structure : structureSet)
+registerStructure(structure);
 m_structureSet.append(structureSet);
 return m_structureSet.last();
 }


Modified: trunk/Source/_javascript_Core/dfg/DFGStructureRegistrationPhase.cpp (188066 => 188067)

--- trunk/Source/_javascript_Core/dfg/DFGStructureRegistrationPhase.cpp	2015-08-06 22:32:06 UTC (rev 188066)
+++ trunk/Source/_javascript_Core/dfg/DFGStructureRegistrationPhase.cpp	2015-08-06 22:36:34 UTC (rev 188067)
@@ -57,7 +57,7 @@
 registerStructure(m_graph.m_vm.getterSetterStructure.get());
 
 for (FrozenValue* value : m_graph.m_frozenValues)
-m_graph.assertIsRegistered(value-structure());
+assertIsRegistered(value-structure());
 
 for (BlockIndex blockIndex = m_graph.numBlocks();

[webkit-changes] [188037] releases/WebKitGTK/webkit-2.8.5/

Title: [188037] releases/WebKitGTK/webkit-2.8.5/








Revision 188037
Author carlo...@webkit.org
Date 2015-08-06 03:12:21 -0700 (Thu, 06 Aug 2015)


Log Message
WebKitGTK+ 2.8.5

Added Paths

releases/WebKitGTK/webkit-2.8.5/




Diff

Property changes: releases/WebKitGTK/webkit-2.8.5



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188030] trunk/Source

Title: [188030] trunk/Source








Revision 188030
Author mra...@apple.com
Date 2015-08-06 00:13:55 -0700 (Thu, 06 Aug 2015)


Log Message
Media Session: push paused state to the media session focus manager instead of polling
https://bugs.webkit.org/show_bug.cgi?id=147633

Reviewed by Simon Fraser.

WebCore:
* dom/Document.cpp:
(WebCore::Document::updateIsPlayingMedia): If a valid source element ID is passed in, set the 'IsSourcePlaying'
 flag accordingly.
* dom/Document.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::elementWithID):
(WebCore::HTMLMediaElement::setMuted): Pass along the element ID.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Ditto.
(WebCore::HTMLMediaElement::setPlaying): Ditto.
* html/HTMLMediaElement.h:
* page/ChromeClient.h:
* page/MediaProducer.h:
* page/Page.cpp:
(WebCore::Page::updateIsPlayingMedia): Pass along the source element ID.
(WebCore::Page::isMediaElementPaused): Deleted. We now push media playback state changes instead of polling.
* page/Page.h:

WebKit2:
* UIProcess/WebMediaSessionFocusManager.cpp:
(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPaused): Report whether the focused media
 element is currently playing. The callback is no longer necessary and will be removed in a future patch in
 favor of returning a value directly.
(WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange): Keep track of whether the focused media
 element is currently playing.
* UIProcess/WebMediaSessionFocusManager.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isPlayingMediaDidChange): If the focused media element begins/ends playing, keep track
 of its playing state.
(WebKit::WebPageProxy::isMediaElementPaused): Deleted. We now push media playback state changes instead of
 polling.
* UIProcess/WebPageProxy.h: isPlayingMediaDidChange is now passed the ID of the media element that triggered
 the 'playing' state change. This can be used in conjunction with the IsSourcePlaying media flag to identify
 whether the source element begin/ended playing.
* UIProcess/WebPageProxy.messages.in: Ditto.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setPluginIsPlayingAudio): Since a media element did not trigger this, pass in 0 for the
 source media element.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::isPlayingMediaDidChange): isPlayingMediaDidChange is now passed the ID of the media
 element that triggered the 'playing' state change.
* WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::isMediaElementPaused): Deleted. We now push media playback state changes instead of polling.
* WebProcess/WebPage/WebPage.h: Ditto.
* WebProcess/WebPage/WebPage.messages.in: Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/page/MediaProducer.h
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp
trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (188029 => 188030)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 06:24:09 UTC (rev 188029)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 07:13:55 UTC (rev 188030)
@@ -1,3 +1,27 @@
+2015-08-04  Matt Rajca  mra...@apple.com
+
+Media Session: push paused state to the media session focus manager instead of polling
+https://bugs.webkit.org/show_bug.cgi?id=147633
+
+Reviewed by Simon Fraser.
+
+* dom/Document.cpp:
+(WebCore::Document::updateIsPlayingMedia): If a valid source element ID is passed in, set the 'IsSourcePlaying'
+ flag accordingly.
+* dom/Document.h:
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::elementWithID):
+(WebCore::HTMLMediaElement::setMuted): Pass along the element ID.
+(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Ditto.
+(WebCore::HTMLMediaElement::setPlaying): Ditto.
+* html/HTMLMediaElement.h:
+* page/ChromeClient.h:
+* page/MediaProducer.h:
+* page/Page.cpp:
+(WebCore::Page::updateIsPlayingMedia): Pass along the source element ID.
+(WebCore::Page::isMediaElementPaused): Deleted. We now push

[webkit-changes] [188031] trunk/Source/WebKit2

Title: [188031] trunk/Source/WebKit2








Revision 188031
Author carlo...@webkit.org
Date 2015-08-06 01:14:20 -0700 (Thu, 06 Aug 2015)


Log Message
[GTK] Crash closing a page when a context menu is open
https://bugs.webkit.org/show_bug.cgi?id=147682

Reviewed by Sergio Villar Senin.

Implement WebContextMenuProxy::cancelTracking() to clear the
internal menu when the web page is closed.

* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::cancelTracking):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Deleted.
* UIProcess/gtk/WebContextMenuProxyGtk.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188030 => 188031)

--- trunk/Source/WebKit2/ChangeLog	2015-08-06 07:13:55 UTC (rev 188030)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-06 08:14:20 UTC (rev 188031)
@@ -1,3 +1,18 @@
+2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Crash closing a page when a context menu is open
+https://bugs.webkit.org/show_bug.cgi?id=147682
+
+Reviewed by Sergio Villar Senin.
+
+Implement WebContextMenuProxy::cancelTracking() to clear the
+internal menu when the web page is closed.
+
+* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
+(WebKit::WebContextMenuProxyGtk::cancelTracking):
+(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Deleted.
+* UIProcess/gtk/WebContextMenuProxyGtk.h:
+
 2015-08-04  Matt Rajca  mra...@apple.com
 
 Media Session: push paused state to the media session focus manager instead of polling


Modified: trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp (188030 => 188031)

--- trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp	2015-08-06 07:13:55 UTC (rev 188030)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp	2015-08-06 08:14:20 UTC (rev 188031)
@@ -171,10 +171,7 @@
 
 WebContextMenuProxyGtk::~WebContextMenuProxyGtk()
 {
-for (auto iter = m_signalHandlers.begin(); iter != m_signalHandlers.end(); ++iter)
-g_signal_handler_disconnect(iter-value, iter-key);
-
-webkitWebViewBaseSetActiveContextMenuProxy(WEBKIT_WEB_VIEW_BASE(m_webView), 0);
+cancelTracking();
 }
 
 void WebContextMenuProxyGtk::menuPositionFunction(GtkMenu* menu, gint* x, gint* y, gboolean* pushIn, WebContextMenuProxyGtk* popupMenu)
@@ -194,5 +191,15 @@
 *pushIn = FALSE;
 }
 
+void WebContextMenuProxyGtk::cancelTracking()
+{
+for (auto iter = m_signalHandlers.begin(); iter != m_signalHandlers.end(); ++iter)
+g_signal_handler_disconnect(iter-value, iter-key);
+m_signalHandlers.clear();
+
+webkitWebViewBaseSetActiveContextMenuProxy(WEBKIT_WEB_VIEW_BASE(m_webView), nullptr);
+m_menu.setPlatformDescription(nullptr);
+}
+
 } // namespace WebKit
 #endif // ENABLE(CONTEXT_MENUS)


Modified: trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h (188030 => 188031)

--- trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h	2015-08-06 07:13:55 UTC (rev 188030)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h	2015-08-06 08:14:20 UTC (rev 188031)
@@ -47,8 +47,9 @@
 }
 ~WebContextMenuProxyGtk();
 
-virtual void showContextMenu(const WebCore::IntPoint, const VectorRefPtrWebContextMenuItem, const ContextMenuContextData);
-virtual void hideContextMenu();
+virtual void showContextMenu(const WebCore::IntPoint, const VectorRefPtrWebContextMenuItem, const ContextMenuContextData) override;
+virtual void hideContextMenu() override;
+virtual void cancelTracking() override;
 
 void populate(VectorWebCore::ContextMenuItem);
 GtkMenu* gtkMenu() const { return m_menu.platformDescription(); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188035] releases/WebKitGTK/webkit-2.8/Source/WebCore

Title: [188035] releases/WebKitGTK/webkit-2.8/Source/WebCore








Revision 188035
Author carlo...@webkit.org
Date 2015-08-06 03:10:50 -0700 (Thu, 06 Aug 2015)


Log Message
Unreviewed. Fix the build with RESOURCE_TIMING disabled.

* loader/ThreadableLoader.h:

Modified Paths

releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ThreadableLoader.h




Diff

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (188034 => 188035)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-08-06 08:50:53 UTC (rev 188034)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-08-06 10:10:50 UTC (rev 188035)
@@ -1,3 +1,9 @@
+2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Fix the build with RESOURCE_TIMING disabled.
+
+* loader/ThreadableLoader.h:
+
 2015-08-05  Chris Dumez  cdu...@apple.com
 
 Crash when removing children of a MathMLSelectElement


Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ThreadableLoader.h (188034 => 188035)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ThreadableLoader.h	2015-08-06 08:50:53 UTC (rev 188034)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/ThreadableLoader.h	2015-08-06 10:10:50 UTC (rev 188035)
@@ -36,11 +36,8 @@
 #include wtf/PassRefPtr.h
 #include wtf/RefPtr.h
 #include wtf/Vector.h
+#include wtf/text/WTFString.h
 
-#if ENABLE(RESOURCE_TIMING)
-#include wtf/text/AtomicString.h
-#endif
-
 namespace WebCore {
 
 class ResourceError;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188036] releases/WebKitGTK/webkit-2.8

Title: [188036] releases/WebKitGTK/webkit-2.8








Revision 188036
Author carlo...@webkit.org
Date 2015-08-06 03:11:03 -0700 (Thu, 06 Aug 2015)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.5 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

* gtk/NEWS: Add release notes for 2.8.5.

Modified Paths

releases/WebKitGTK/webkit-2.8/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS
releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.8/ChangeLog (188035 => 188036)

--- releases/WebKitGTK/webkit-2.8/ChangeLog	2015-08-06 10:10:50 UTC (rev 188035)
+++ releases/WebKitGTK/webkit-2.8/ChangeLog	2015-08-06 10:11:03 UTC (rev 188036)
@@ -1,3 +1,9 @@
+2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.5 release.
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2015-08-04  Mario Sanchez Prada  ma...@endlessm.com
 
 [GTK] Accelerated 2D Canvas enabled when cairo-gl is not available


Modified: releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog (188035 => 188036)

--- releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog	2015-08-06 10:10:50 UTC (rev 188035)
+++ releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog	2015-08-06 10:11:03 UTC (rev 188036)
@@ -1,5 +1,11 @@
 2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
 
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.5 release.
+
+* gtk/NEWS: Add release notes for 2.8.5.
+
+2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
+
 [GTK] Crash closing a page when a context menu is open
 https://bugs.webkit.org/show_bug.cgi?id=147682
 


Modified: releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS (188035 => 188036)

--- releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS	2015-08-06 10:10:50 UTC (rev 188035)
+++ releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS	2015-08-06 10:11:03 UTC (rev 188036)
@@ -1,4 +1,21 @@
 =
+WebKitGTK+  2.8.5
+=
+
+What's new in WebKitGTK+ 2.8.5?
+
+  - Fix the window size reported when the web view isn't realized yet. This fixes the layout of
+some websites when opening new tabs in the browser and anchor links when opened in new tabs too.
+  - Prevent clipboard contents from being lost when web process finishes.
+  - Always allow font matching for strong aliases.
+  - Move GStreamer missing plugins installer to the UI process.
+  - Fix a crash when spell checker returns no guesses.
+  - Fix a crash when SoupSession is destroyed in exit handler.
+  - Fix a crash closing a page when default context menu is open.
+  - Several crashes and rendering issues fixed.
+  - Translation updates: Swedish.
+
+=
 WebKitGTK+  2.8.4
 =
 


Modified: releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake (188035 => 188036)

--- releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake	2015-08-06 10:10:50 UTC (rev 188035)
+++ releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake	2015-08-06 10:11:03 UTC (rev 188036)
@@ -2,14 +2,14 @@
 
 set(PROJECT_VERSION_MAJOR 2)
 set(PROJECT_VERSION_MINOR 8)
-set(PROJECT_VERSION_MICRO 4)
+set(PROJECT_VERSION_MICRO 5)
 set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_MICRO})
 set(WEBKITGTK_API_VERSION 4.0)
 
 # Libtool library version, not to be confused with API version.
 # See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 43 7 6)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 19 11 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 43 8 6)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 19 12 1)
 
 set(ENABLE_CREDENTIAL_STORAGE ON CACHE BOOL Whether or not to enable support for credential storage using libsecret.)
 set(ENABLE_GTKDOC OFF CACHE BOOL Whether or not to use generate gtkdoc.)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188029] trunk/Source/WebInspectorUI

2015-08-06 Thread drousso

Title: [188029] trunk/Source/WebInspectorUI








Revision 188029
Author drou...@apple.com
Date 2015-08-05 23:24:09 -0700 (Wed, 05 Aug 2015)


Log Message
Web Inspector: Move the Metrics style sidebar panel into Computed
https://bugs.webkit.org/show_bug.cgi?id=147715

Reviewed by Timothy Hatcher.

Deleted the Metrics sidebar panel and moved its contents into the Computed sidebar panel.
In addition, not hovering over the Metrics section will display the colors of each box.

* UserInterface/Main.html:
* UserInterface/Views/BoxModelDetailsSectionRow.css:
(.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
(.details-section .row.box-model .position):
(.details-section .row.box-model .margin):
(.details-section .row.box-model .border):
(.details-section .row.box-model .padding):
(.details-section .row.box-model :matches(.content span, .top, .right, .bottom, .left)):
(.details-section .row.box-model :matches(.right, .left)):
(.details-section .row.box-model .content): Deleted.
(.details-section .row.box-model .content span): Deleted.
(.details-section .row.box-model .left): Deleted.
(.details-section .row.box-model .right): Deleted.
(.details-section .row.box-model .top): Deleted.
(.details-section .row.box-model .bottom): Deleted.

* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._highlightDOMNode):
If no metric box is hovered, apply a class to the entire section.

* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
Removed the usage of MetricsStyleDetailsPanel.

* UserInterface/Views/ComputedStyleDetailsPanel.css:
(.details-section.style-box-model:not(.collapsed)  :matches(.header, .content)):
Give the metrics section in the Computed panel a white background.

* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WebInspector.ComputedStyleDetailsPanel):
(WebInspector.ComputedStyleDetailsPanel.prototype.refresh):
Don't refresh the content unless the change is significant (without this, you cannot edit
metrics values using the arrow keys).

* UserInterface/Views/MetricsStyleDetailsPanel.js: Removed.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css
trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js


Removed Paths

trunk/Source/WebInspectorUI/UserInterface/Views/MetricsStyleDetailsPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188028 => 188029)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-06 06:17:59 UTC (rev 188028)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-06 06:24:09 UTC (rev 188029)
@@ -1,5 +1,51 @@
 2015-08-05  Devin Rousso  drou...@apple.com
 
+Web Inspector: Move the Metrics style sidebar panel into Computed
+https://bugs.webkit.org/show_bug.cgi?id=147715
+
+Reviewed by Timothy Hatcher.
+
+Deleted the Metrics sidebar panel and moved its contents into the Computed sidebar panel.
+In addition, not hovering over the Metrics section will display the colors of each box.
+
+* UserInterface/Main.html:
+* UserInterface/Views/BoxModelDetailsSectionRow.css:
+(.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
+(.details-section .row.box-model .position):
+(.details-section .row.box-model .margin):
+(.details-section .row.box-model .border):
+(.details-section .row.box-model .padding):
+(.details-section .row.box-model :matches(.content span, .top, .right, .bottom, .left)):
+(.details-section .row.box-model :matches(.right, .left)):
+(.details-section .row.box-model .content): Deleted.
+(.details-section .row.box-model .content span): Deleted.
+(.details-section .row.box-model .left): Deleted.
+(.details-section .row.box-model .right): Deleted.
+(.details-section .row.box-model .top): Deleted.
+(.details-section .row.box-model .bottom): Deleted.
+
+* UserInterface/Views/BoxModelDetailsSectionRow.js:
+(WebInspector.BoxModelDetailsSectionRow.prototype._highlightDOMNode):
+If no metric box is hovered, apply a class to the entire section.
+
+* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+(WebInspector.CSSStyleDetailsSidebarPanel):
+Removed the usage of MetricsStyleDetailsPanel.
+
+* UserInterface/Views/ComputedStyleDetailsPanel.css:
+(.details-section.style-box-model:not(.collapsed)  :matches(.header, .content)):
+Give the metrics section in the Computed panel a white background.
+
+

[webkit-changes] [188052] branches/safari-601.1.46-branch/Source/WebCore

Title: [188052] branches/safari-601.1.46-branch/Source/WebCore








Revision 188052
Author bshaf...@apple.com
Date 2015-08-06 12:48:29 -0700 (Thu, 06 Aug 2015)


Log Message
Merged r187693.  rdar://problem/22047626

Modified Paths

branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp




Diff

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (188051 => 188052)

--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-08-06 18:45:01 UTC (rev 188051)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-08-06 19:48:29 UTC (rev 188052)
@@ -1,3 +1,22 @@
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
+Merge r187693.
+
+2015-07-31  Myles C. Maxfield  mmaxfi...@apple.com
+
+[Cocoa] Latin quotes are used with the system font on Chinese devices
+https://bugs.webkit.org/show_bug.cgi?id=147504
+
+Reviewed by Dean Jackson.
+
+The system font has some fancy logic regarding character selection which requires
+using Core Text for glyph selection.
+
+No new tests because tests can't change the system language of the device.
+
+* platform/graphics/mac/GlyphPageMac.cpp:
+(WebCore::shouldUseCoreText):
+
 2015-08-05  Matthew Hanson  matthew_han...@apple.com
 
 Merge r187962. rdar://problem/21827815


Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp (188051 => 188052)

--- branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp	2015-08-06 18:45:01 UTC (rev 188051)
+++ branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp	2015-08-06 19:48:29 UTC (rev 188052)
@@ -42,7 +42,7 @@
 
 static bool shouldUseCoreText(const UChar* buffer, unsigned bufferLength, const Font* fontData)
 {
-if (fontData-platformData().isCompositeFontReference())
+if (fontData-platformData().isCompositeFontReference() || fontData-isSystemFont())
 return true;
 if (fontData-platformData().widthVariant() != RegularWidth || fontData-hasVerticalGlyphs()) {
 // Ideographs don't have a vertical variant or width variants.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188063] trunk/Source/WebKit/mac

Title: [188063] trunk/Source/WebKit/mac








Revision 188063
Author ander...@apple.com
Date 2015-08-06 14:38:18 -0700 (Thu, 06 Aug 2015)


Log Message
Crashes when calling swizzled setNeedsDisplayInRect: on heartbeat thread
https://bugs.webkit.org/show_bug.cgi?id=147746
rdar://problem/18698271

Reviewed by Dan Bernstein.

Back off if someone is calling our swizzled setNeedsDisplayInRect on a non-main thread.

* WebView/WebHTMLView.mm:
(setNeedsDisplayInRect):

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (188062 => 188063)

--- trunk/Source/WebKit/mac/ChangeLog	2015-08-06 21:36:00 UTC (rev 188062)
+++ trunk/Source/WebKit/mac/ChangeLog	2015-08-06 21:38:18 UTC (rev 188063)
@@ -1,3 +1,16 @@
+2015-08-06  Anders Carlsson  ander...@apple.com
+
+Crashes when calling swizzled setNeedsDisplayInRect: on heartbeat thread
+https://bugs.webkit.org/show_bug.cgi?id=147746
+rdar://problem/18698271
+
+Reviewed by Dan Bernstein.
+
+Back off if someone is calling our swizzled setNeedsDisplayInRect on a non-main thread.
+
+* WebView/WebHTMLView.mm:
+(setNeedsDisplayInRect):
+
 2015-08-05  Filip Pizlo  fpi...@apple.com
 
 Unreviewed, roll out http://trac.webkit.org/changeset/187972.


Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (188062 => 188063)

--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2015-08-06 21:36:00 UTC (rev 188062)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2015-08-06 21:38:18 UTC (rev 188063)
@@ -334,7 +334,7 @@
 
 static void setNeedsDisplayInRect(NSView *self, SEL cmd, NSRect invalidRect)
 {
-if (![self _drawnByAncestor]) {
+if (![NSThread isMainThread] || ![self _drawnByAncestor]) {
 wtfCallIMPid(oldSetNeedsDisplayInRectIMP, self, cmd, invalidRect);
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188110] branches/safari-601.1.46-branch/Source

Title: [188110] branches/safari-601.1.46-branch/Source








Revision 188110
Author bshaf...@apple.com
Date 2015-08-06 20:34:31 -0700 (Thu, 06 Aug 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (188109 => 188110)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-08-07 03:27:23 UTC (rev 188109)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-08-07 03:34:31 UTC (rev 188110)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (188109 => 188110)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-08-07 03:27:23 UTC (rev 188109)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-08-07 03:34:31 UTC (rev 188110)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (188109 => 188110)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-08-07 03:27:23 UTC (rev 188109)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-08-07 03:34:31 UTC (rev 188110)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (188109 => 188110)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-08-07 03:27:23 UTC (rev 188109)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-08-07 03:34:31 UTC (rev 188110)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (188109 => 188110)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-08-07 03:27:23 UTC (rev 188109)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-08-07 03:34:31 UTC (rev 188110)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188112] trunk/Source/WebKit2

2015-08-06 Thread mitz

Title: [188112] trunk/Source/WebKit2








Revision 188112
Author m...@apple.com
Date 2015-08-06 20:44:08 -0700 (Thu, 06 Aug 2015)


Log Message
Fixed all the builds after trying to fix the non-HAVE(LINK_PREVIEW) build.

* UIProcess/ios/WKContentViewInteraction.mm:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188111 => 188112)

--- trunk/Source/WebKit2/ChangeLog	2015-08-07 03:41:29 UTC (rev 188111)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-07 03:44:08 UTC (rev 188112)
@@ -1,5 +1,11 @@
 2015-08-06  Dan Bernstein  m...@apple.com
 
+Fixed all the builds after trying to fix the non-HAVE(LINK_PREVIEW) build.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+
+2015-08-06  Dan Bernstein  m...@apple.com
+
 Fixed the non-HAVE(LINK_PREVIEW) build.
 
 * UIProcess/ios/WKContentViewInteraction.mm:


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188111 => 188112)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 03:41:29 UTC (rev 188111)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 03:44:08 UTC (rev 188112)
@@ -219,8 +219,8 @@
 #if HAVE(LINK_PREVIEW)
 @interface UIPreviewItemController (StagingToRemove)
 @property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer;
+@end
 #endif
-@end
 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188116] trunk/Source/WebCore

Title: [188116] trunk/Source/WebCore








Revision 188116
Author commit-qu...@webkit.org
Date 2015-08-06 22:15:11 -0700 (Thu, 06 Aug 2015)


Log Message
Fix GTK clean build after r187997
https://bugs.webkit.org/show_bug.cgi?id=147723

Patch by Alex Christensen achristen...@webkit.org on 2015-08-06
Reviewed by Gyuyoung Kim.

* CMakeLists.txt:
r187997 made it so WebCoreTestSupport does not link with WebCore, which is necessary to get DumpRenderTree to link.
It also made it so WebCoreTestSupport is no longer dependent on WebCore, which causes it to build at the same time.
This caused problems because WebCoreTestSupport uses headers that are generated for WebCore, such as WebKitFontFamilyNames.h.
Adding a dependency makes it so that WebCoreTestSupport waits until WebCore is done compiling before compiling,
which is what it used to do, but it does not cause linking problems with DumpRenderTree.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (188115 => 188116)

--- trunk/Source/WebCore/CMakeLists.txt	2015-08-07 05:09:07 UTC (rev 188115)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-08-07 05:15:11 UTC (rev 188116)
@@ -3639,6 +3639,7 @@
 endif ()
 
 add_library(WebCoreTestSupport ${WebCoreTestSupport_LIBRARY_TYPE} ${WebCoreTestSupport_SOURCES})
+add_dependencies(WebCoreTestSupport WebCore)
 target_link_libraries(WebCoreTestSupport ${WebCoreTestSupport_LIBRARIES})
 set_target_properties(WebCoreTestSupport PROPERTIES FOLDER WebCore)
 


Modified: trunk/Source/WebCore/ChangeLog (188115 => 188116)

--- trunk/Source/WebCore/ChangeLog	2015-08-07 05:09:07 UTC (rev 188115)
+++ trunk/Source/WebCore/ChangeLog	2015-08-07 05:15:11 UTC (rev 188116)
@@ -1,3 +1,17 @@
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
+Fix GTK clean build after r187997
+https://bugs.webkit.org/show_bug.cgi?id=147723
+
+Reviewed by Gyuyoung Kim.
+
+* CMakeLists.txt:
+r187997 made it so WebCoreTestSupport does not link with WebCore, which is necessary to get DumpRenderTree to link.
+It also made it so WebCoreTestSupport is no longer dependent on WebCore, which causes it to build at the same time.
+This caused problems because WebCoreTestSupport uses headers that are generated for WebCore, such as WebKitFontFamilyNames.h.
+Adding a dependency makes it so that WebCoreTestSupport waits until WebCore is done compiling before compiling,
+which is what it used to do, but it does not cause linking problems with DumpRenderTree.
+
 2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
 
 CSSSegmentedFontFace::fontRanges() does not handle duplicate fonts correctly






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188107] branches/safari-601.1.46-branch/Source/WebKit2

Title: [188107] branches/safari-601.1.46-branch/Source/WebKit2








Revision 188107
Author bshaf...@apple.com
Date 2015-08-06 19:51:36 -0700 (Thu, 06 Aug 2015)


Log Message
Roll out r188053. rdar://problem/22128839

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188106 => 188107)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-07 02:49:31 UTC (rev 188106)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-07 02:51:36 UTC (rev 188107)
@@ -1,5 +1,9 @@
 2015-08-06  Babak Shafiei  bshaf...@apple.com
 
+Roll out r188053.
+
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
 Roll out r188058.
 
 2015-08-06  Babak Shafiei  bshaf...@apple.com


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (188106 => 188107)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-08-07 02:49:31 UTC (rev 188106)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2015-08-07 02:51:36 UTC (rev 188107)
@@ -121,7 +121,6 @@
 RetainPtrWKFormInputSession _formInputSession;
 RetainPtrWKFileUploadPanel _fileUploadPanel;
 RetainPtrUIGestureRecognizer _previewGestureRecognizer;
-RetainPtrUIGestureRecognizer _previewSecondaryGestureRecognizer;
 #if HAVE(LINK_PREVIEW)
 RetainPtrUIPreviewItemController _previewItemController;
 #endif


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188106 => 188107)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 02:49:31 UTC (rev 188106)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 02:51:36 UTC (rev 188107)
@@ -416,6 +416,7 @@
 [self removeGestureRecognizer:_touchEventGestureRecognizer.get()];
 [self removeGestureRecognizer:_singleTapGestureRecognizer.get()];
 [self removeGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
+[self removeGestureRecognizer:_longPressGestureRecognizer.get()];
 [self removeGestureRecognizer:_doubleTapGestureRecognizer.get()];
 [self removeGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
 }
@@ -425,6 +426,7 @@
 [self addGestureRecognizer:_touchEventGestureRecognizer.get()];
 [self addGestureRecognizer:_singleTapGestureRecognizer.get()];
 [self addGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
+[self addGestureRecognizer:_longPressGestureRecognizer.get()];
 [self addGestureRecognizer:_doubleTapGestureRecognizer.get()];
 [self addGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
 }
@@ -874,9 +876,6 @@
 if (isSamePair(gestureRecognizer, otherGestureRecognizer, _singleTapGestureRecognizer.get(), _textSelectionAssistant.get().singleTapGesture))
 return YES;
 
-if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewSecondaryGestureRecognizer.get()))
-return YES;
-
 if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewGestureRecognizer.get()))
 return YES;
 
@@ -1077,25 +1076,21 @@
 {
 ASSERT(gestureRecognizer == _longPressGestureRecognizer);
 
+#if HAVE(LINK_PREVIEW)
+if ([_previewItemController interactionInProgress])
+return;
+#endif
+
 _lastInteractionLocation = gestureRecognizer.startPoint;
 
-switch ([gestureRecognizer state]) {
-case UIGestureRecognizerStateBegan:
-{
+if ([gestureRecognizer state] == UIGestureRecognizerStateBegan) {
 SEL action = "" _actionForLongPress];
 if (action) {
 [self performSelector:action];
 [self _cancelLongPressGestureRecognizer];
+[UIApp _cancelAllTouches];
 }
 }
-break;
-case UIGestureRecognizerStateCancelled:
-case UIGestureRecognizerStateEnded:
-[_actionSheetAssistant cleanupSheet];
-break;
-default:
-break;
-}
 }
 
 - (void)_singleTapRecognized:(UITapGestureRecognizer *)gestureRecognizer
@@ -3221,14 +3216,12 @@
 _previewItemController = adoptNS([[UIPreviewItemController alloc] initWithView:self]);
 [_previewItemController setDelegate:self];
 _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer;
-_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer;
 }
 
 - (void)_unregisterPreview
 {
 [_previewItemController setDelegate:nil];
 _previewGestureRecognizer = nil;
-_previewSecondaryGestureRecognizer =

[webkit-changes] [188108] tags/Safari-601.1.46.4/

Title: [188108] tags/Safari-601.1.46.4/








Revision 188108
Author bshaf...@apple.com
Date 2015-08-06 19:54:46 -0700 (Thu, 06 Aug 2015)


Log Message
New tag.

Added Paths

tags/Safari-601.1.46.4/




Diff

Property changes: tags/Safari-601.1.46.4



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188115] trunk/Source/WebKit2

2015-08-06 Thread bdakin

Title: [188115] trunk/Source/WebKit2








Revision 188115
Author bda...@apple.com
Date 2015-08-06 22:09:07 -0700 (Thu, 06 Aug 2015)


Log Message
TextIndicator can have stale contentImage data and crash
https://bugs.webkit.org/show_bug.cgi?id=147770
-and corresponding-
rdar://problem/22181735

Reviewed by Tim Horton.

If there is no contentImage or contentImageWithHighlight, set them to 
nullptr.
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoderTextIndicatorData::decode):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188114 => 188115)

--- trunk/Source/WebKit2/ChangeLog	2015-08-07 04:21:01 UTC (rev 188114)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-07 05:09:07 UTC (rev 188115)
@@ -1,3 +1,17 @@
+2015-08-06  Beth Dakin  bda...@apple.com
+
+TextIndicator can have stale contentImage data and crash
+https://bugs.webkit.org/show_bug.cgi?id=147770
+-and corresponding-
+rdar://problem/22181735
+
+Reviewed by Tim Horton.
+
+If there is no contentImage or contentImageWithHighlight, set them to 
+nullptr.
+* Shared/WebCoreArgumentCoders.cpp:
+(IPC::ArgumentCoderTextIndicatorData::decode):
+
 2015-08-06  Dan Bernstein  m...@apple.com
 
 Fixed all the builds after trying to fix the non-HAVE(LINK_PREVIEW) build.


Modified: trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp (188114 => 188115)

--- trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp	2015-08-07 04:21:01 UTC (rev 188114)
+++ trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp	2015-08-07 05:09:07 UTC (rev 188115)
@@ -2165,12 +2165,16 @@
 bool hasImage;
 if (!decoder.decode(hasImage))
 return false;
+if (!hasImage)
+textIndicatorData.contentImage = nullptr;
 if (hasImage  !decodeImage(decoder, textIndicatorData.contentImage))
 return false;
 
 bool hasImageWithHighlight;
 if (!decoder.decode(hasImageWithHighlight))
 return false;
+if (!hasImageWithHighlight)
+textIndicatorData.contentImageWithHighlight = nullptr;
 if (hasImageWithHighlight  !decodeImage(decoder, textIndicatorData.contentImageWithHighlight))
 return false;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188114] trunk/Source/WebCore

Title: [188114] trunk/Source/WebCore








Revision 188114
Author mmaxfi...@apple.com
Date 2015-08-06 21:21:01 -0700 (Thu, 06 Aug 2015)


Log Message
CSSSegmentedFontFace::fontRanges() does not handle duplicate fonts correctly
https://bugs.webkit.org/show_bug.cgi?id=147765

Reviewed by Filip Pizlo.

CSSSegmentedFontFace::fontRanges() was trying to hash on FontDescriptors by
picking a few specific pieces of data out of the FontDescriptor, computing
a hash on it, and using that unsigned as a key in a HashMap. This has two
problems: it doesn't handle equality correctly, as hash collisions cannot
depend on an equality operator to dedup, and it doesn't hash on all the
members of a FontDescription.

Instead, this HashMap should use FontDescriptionKey, which represents a
FontDescription, and is designed exactly for the purpose of being used as a
key in a HashMap.

No new tests because there is no behavior change (because a problem occurs
when two different FontDescriptions hash to the same value, which is rare).

* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontRanges):
* css/CSSSegmentedFontFace.h:
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKeyHash::hash):
(WebCore::FontDescriptionKeyHash::equal):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp
trunk/Source/WebCore/css/CSSSegmentedFontFace.h
trunk/Source/WebCore/platform/graphics/FontCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188113 => 188114)

--- trunk/Source/WebCore/ChangeLog	2015-08-07 04:17:04 UTC (rev 188113)
+++ trunk/Source/WebCore/ChangeLog	2015-08-07 04:21:01 UTC (rev 188114)
@@ -1,5 +1,33 @@
 2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
 
+CSSSegmentedFontFace::fontRanges() does not handle duplicate fonts correctly
+https://bugs.webkit.org/show_bug.cgi?id=147765
+
+Reviewed by Filip Pizlo.
+
+CSSSegmentedFontFace::fontRanges() was trying to hash on FontDescriptors by
+picking a few specific pieces of data out of the FontDescriptor, computing
+a hash on it, and using that unsigned as a key in a HashMap. This has two
+problems: it doesn't handle equality correctly, as hash collisions cannot
+depend on an equality operator to dedup, and it doesn't hash on all the
+members of a FontDescription.
+
+Instead, this HashMap should use FontDescriptionKey, which represents a
+FontDescription, and is designed exactly for the purpose of being used as a
+key in a HashMap.
+
+No new tests because there is no behavior change (because a problem occurs
+when two different FontDescriptions hash to the same value, which is rare).
+
+* css/CSSSegmentedFontFace.cpp:
+(WebCore::CSSSegmentedFontFace::fontRanges):
+* css/CSSSegmentedFontFace.h:
+* platform/graphics/FontCache.h:
+(WebCore::FontDescriptionKeyHash::hash):
+(WebCore::FontDescriptionKeyHash::equal):
+
+2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
+
 [iOS] Remove dead code from FontCache::createFontPlatformData()
 https://bugs.webkit.org/show_bug.cgi?id=147762
 


Modified: trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp (188113 => 188114)

--- trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp	2015-08-07 04:17:04 UTC (rev 188113)
+++ trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp	2015-08-07 04:21:01 UTC (rev 188114)
@@ -31,6 +31,7 @@
 #include CSSFontSelector.h
 #include Document.h
 #include Font.h
+#include FontCache.h
 #include FontDescription.h
 #include RuntimeEnabledFeatures.h
 
@@ -113,14 +114,8 @@
 return FontRanges();
 
 FontTraitsMask desiredTraitsMask = fontDescription.traitsMask();
-// FIXME: Unify this function with FontDescriptionKey in FontCache.h (Or just use the regular FontCache instead of this)
-unsigned hashKey = ((fontDescription.computedPixelSize() + 1)  (FontTraitsMaskWidth + FontWidthVariantWidth + FontSynthesisWidth + 1))
-| (fontDescription.fontSynthesis()  (FontTraitsMaskWidth + FontWidthVariantWidth + 1))
-| ((fontDescription.orientation() == Vertical ? 1 : 0)  (FontTraitsMaskWidth + FontWidthVariantWidth))
-| fontDescription.widthVariant()  FontTraitsMaskWidth
-| desiredTraitsMask;
 
-auto addResult = m_descriptionToRangesMap.add(hashKey, FontRanges());
+auto addResult = m_descriptionToRangesMap.add(FontDescriptionKey(fontDescription), FontRanges());
 auto fontRanges = addResult.iterator-value;
 
 if (addResult.isNewEntry) {


Modified: trunk/Source/WebCore/css/CSSSegmentedFontFace.h (188113 => 188114)

--- trunk/Source/WebCore/css/CSSSegmentedFontFace.h	2015-08-07 04:17:04 UTC (rev 188113)
+++ trunk/Source/WebCore/css/CSSSegmentedFontFace.h	2015-08-07 04:21:01 UTC (rev 188114)
@@ -26,6 +26,7 @@
 #ifndef CSSSegmentedFontFace_h
 #define CSSSegmentedFontFace_h
 
+#include FontCache.h
 #include FontRanges.h
 #include wtf/HashMap.h

[webkit-changes] [188106] branches/safari-601.1.46-branch/Source/WebKit2

Title: [188106] branches/safari-601.1.46-branch/Source/WebKit2








Revision 188106
Author bshaf...@apple.com
Date 2015-08-06 19:49:31 -0700 (Thu, 06 Aug 2015)


Log Message
Roll out r188058. rdar://problem/22128839

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188105 => 188106)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-07 02:08:07 UTC (rev 188105)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-07 02:49:31 UTC (rev 188106)
@@ -1,5 +1,9 @@
 2015-08-06  Babak Shafiei  bshaf...@apple.com
 
+Roll out r188058.
+
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
 Merge r188058.
 
 2015-08-06  Enrica Casucci  enr...@apple.com


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188105 => 188106)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 02:08:07 UTC (rev 188105)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 02:49:31 UTC (rev 188106)
@@ -220,10 +220,6 @@
 @end
 
 @protocol UISelectionInteractionAssistant;
-@interface UIPreviewItemController (StagingToRemove)
-@property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer;
-@end
-
 #endif
 
 @interface WKFormInputSession : NSObject _WKFormInputSession
@@ -3225,8 +3221,7 @@
 _previewItemController = adoptNS([[UIPreviewItemController alloc] initWithView:self]);
 [_previewItemController setDelegate:self];
 _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer;
-if ([_previewItemController respondsToSelector:@selector(presentationSecondaryGestureRecognizer)])
-_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer;
+_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer;
 }
 
 - (void)_unregisterPreview






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188109] trunk/Source/WebKit2

2015-08-06 Thread enrica

Title: [188109] trunk/Source/WebKit2








Revision 188109
Author enr...@apple.com
Date 2015-08-06 20:27:23 -0700 (Thu, 06 Aug 2015)


Log Message
Cleanup action sheet only when long press is canceled (non ended).
https://bugs.webkit.org/show_bug.cgi?id=147766
rdar://problem/22181842

Reviewed by Tim Horton.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _longPressRecognized:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188108 => 188109)

--- trunk/Source/WebKit2/ChangeLog	2015-08-07 02:54:46 UTC (rev 188108)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-07 03:27:23 UTC (rev 188109)
@@ -1,3 +1,14 @@
+2015-08-06  Enrica Casucci  enr...@apple.com
+
+Cleanup action sheet only when long press is canceled (non ended).
+https://bugs.webkit.org/show_bug.cgi?id=147766
+rdar://problem/22181842
+
+Reviewed by Tim Horton.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _longPressRecognized:]):
+
 2015-08-05  Filip Pizlo  fpi...@apple.com
 
 Lightweight locks should be adaptive


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188108 => 188109)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 02:54:46 UTC (rev 188108)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 03:27:23 UTC (rev 188109)
@@ -1091,7 +1091,6 @@
 }
 break;
 case UIGestureRecognizerStateCancelled:
-case UIGestureRecognizerStateEnded:
 [_actionSheetAssistant cleanupSheet];
 break;
 default:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188111] trunk/Source/WebKit2

2015-08-06 Thread mitz

Title: [188111] trunk/Source/WebKit2








Revision 188111
Author m...@apple.com
Date 2015-08-06 20:41:29 -0700 (Thu, 06 Aug 2015)


Log Message
Fixed the non-HAVE(LINK_PREVIEW) build.

* UIProcess/ios/WKContentViewInteraction.mm:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188110 => 188111)

--- trunk/Source/WebKit2/ChangeLog	2015-08-07 03:34:31 UTC (rev 188110)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-07 03:41:29 UTC (rev 188111)
@@ -1,3 +1,9 @@
+2015-08-06  Dan Bernstein  m...@apple.com
+
+Fixed the non-HAVE(LINK_PREVIEW) build.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+
 2015-08-06  Enrica Casucci  enr...@apple.com
 
 Cleanup action sheet only when long press is canceled (non ended).


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188110 => 188111)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 03:34:31 UTC (rev 188110)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-07 03:41:29 UTC (rev 188111)
@@ -216,8 +216,10 @@
 
 #if __IPHONE_OS_VERSION_MIN_REQUIRED = 9
 @protocol UISelectionInteractionAssistant;
+#if HAVE(LINK_PREVIEW)
 @interface UIPreviewItemController (StagingToRemove)
 @property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer;
+#endif
 @end
 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188113] trunk/Tools

2015-08-06 Thread fpizlo

Title: [188113] trunk/Tools








Revision 188113
Author fpi...@apple.com
Date 2015-08-06 21:17:04 -0700 (Thu, 06 Aug 2015)


Log Message
Unreviewed, reduce the duration of a Lock unit test. It was timing out.

* TestWebKitAPI/Tests/WTF/Lock.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp




Diff

Modified: trunk/Tools/ChangeLog (188112 => 188113)

--- trunk/Tools/ChangeLog	2015-08-07 03:44:08 UTC (rev 188112)
+++ trunk/Tools/ChangeLog	2015-08-07 04:17:04 UTC (rev 188113)
@@ -1,3 +1,10 @@
+2015-08-06  Filip Pizlo  fpi...@apple.com
+
+Unreviewed, reduce the duration of a Lock unit test. It was timing out.
+
+* TestWebKitAPI/Tests/WTF/Lock.cpp:
+(TestWebKitAPI::TEST):
+
 2015-08-06  Joseph Pecoraro  pecor...@apple.com
 
 Running tests for a long time results in some tests running very slowly (throttling)


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp (188112 => 188113)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp	2015-08-07 03:44:08 UTC (rev 188112)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp	2015-08-07 04:17:04 UTC (rev 188113)
@@ -94,7 +94,7 @@
 
 TEST(WTF_Lock, ManyContentedLongSections)
 {
-runLockTestLock(10, 10, 1, 2000);
+runLockTestLock(10, 10, 1, 1000);
 }
 
 } // namespace TestWebKitAPI






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188078] branches/safari-601.1-branch/Source/WebKit/win

Title: [188078] branches/safari-601.1-branch/Source/WebKit/win








Revision 188078
Author dburk...@apple.com
Date 2015-08-06 16:09:43 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187894. rdar://problem/15779101

Modified Paths

branches/safari-601.1-branch/Source/WebKit/win/ChangeLog
branches/safari-601.1-branch/Source/WebKit/win/Plugins/PluginStream.h




Diff

Modified: branches/safari-601.1-branch/Source/WebKit/win/ChangeLog (188077 => 188078)

--- branches/safari-601.1-branch/Source/WebKit/win/ChangeLog	2015-08-06 23:09:42 UTC (rev 188077)
+++ branches/safari-601.1-branch/Source/WebKit/win/ChangeLog	2015-08-06 23:09:43 UTC (rev 188078)
@@ -1,5 +1,16 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187894. rdar://problem/15779101
+
+2015-08-04  Alex Christensen  achristen...@webkit.org
+
+Fix Windows build after r187886.
+
+* Plugins/PluginStream.h:
+Befriend PluginView.
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187886. rdar://problem/15779101
 
 2015-08-04  Alexey Proskuryakov  a...@apple.com


Modified: branches/safari-601.1-branch/Source/WebKit/win/Plugins/PluginStream.h (188077 => 188078)

--- branches/safari-601.1-branch/Source/WebKit/win/Plugins/PluginStream.h	2015-08-06 23:09:42 UTC (rev 188077)
+++ branches/safari-601.1-branch/Source/WebKit/win/Plugins/PluginStream.h	2015-08-06 23:09:43 UTC (rev 188078)
@@ -116,6 +116,8 @@
 NPReason m_reason;
 NPStream m_stream;
 PluginQuirkSet m_quirks;
+
+friend class PluginView;
 };
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188076] branches/safari-601.1-branch

Title: [188076] branches/safari-601.1-branch








Revision 188076
Author dburk...@apple.com
Date 2015-08-06 16:09:38 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187886. rdar://problem/15779101

Modified Paths

branches/safari-601.1-branch/LayoutTests/ChangeLog
branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/loader/NetscapePlugInStreamLoader.cpp
branches/safari-601.1-branch/Source/WebCore/loader/NetscapePlugInStreamLoader.h
branches/safari-601.1-branch/Source/WebCore/loader/ResourceLoader.cpp
branches/safari-601.1-branch/Source/WebCore/loader/ResourceLoader.h
branches/safari-601.1-branch/Source/WebCore/loader/SubresourceLoader.cpp
branches/safari-601.1-branch/Source/WebCore/loader/SubresourceLoader.h
branches/safari-601.1-branch/Source/WebCore/plugins/npapi.h
branches/safari-601.1-branch/Source/WebCore/plugins/npfunctions.h
branches/safari-601.1-branch/Source/WebKit/mac/ChangeLog
branches/safari-601.1-branch/Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.h
branches/safari-601.1-branch/Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm
branches/safari-601.1-branch/Source/WebKit/mac/Plugins/WebNetscapePluginStream.h
branches/safari-601.1-branch/Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm
branches/safari-601.1-branch/Source/WebKit/win/ChangeLog
branches/safari-601.1-branch/Source/WebKit/win/Plugins/PluginStream.cpp
branches/safari-601.1-branch/Source/WebKit/win/Plugins/PluginStream.h
branches/safari-601.1-branch/Source/WebKit2/ChangeLog
branches/safari-601.1-branch/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
branches/safari-601.1-branch/Source/WebKit2/PluginProcess/PluginControllerProxy.h
branches/safari-601.1-branch/Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/Plugin.h
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/PluginController.h
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/Plugins/PluginView.h
branches/safari-601.1-branch/Tools/ChangeLog
branches/safari-601.1-branch/Tools/DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj
branches/safari-601.1-branch/Tools/DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters
branches/safari-601.1-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
branches/safari-601.1-branch/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt
branches/safari-601.1-branch/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp
branches/safari-601.1-branch/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h
branches/safari-601.1-branch/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp


Added Paths

branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect-notify-expected.txt
branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect-notify.html
branches/safari-601.1-branch/LayoutTests/platform/wk2/http/tests/plugins/
branches/safari-601.1-branch/LayoutTests/platform/wk2/http/tests/plugins/get-url-redirect-notify-expected.txt
branches/safari-601.1-branch/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp




Diff

Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (188075 => 188076)

--- branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:08:48 UTC (rev 188075)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:09:38 UTC (rev 188076)
@@ -1,5 +1,24 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187886. rdar://problem/15779101
+
+2015-08-04  Alexey Proskuryakov  a...@apple.com
+
+Implement NPAPI redirect handling
+https://bugs.webkit.org/show_bug.cgi?id=138675
+rdar://problem/15779101
+
+Patch by Jeffrey Pfau, updated and tweaked by me.
+
+Reviewed by Anders Carlsson.
+
+* http/tests/plugins/get-url-redirect-notify-expected.txt: Added.
+*

[webkit-changes] [188079] branches/safari-601.1-branch/Source/WebKit/mac

Title: [188079] branches/safari-601.1-branch/Source/WebKit/mac








Revision 188079
Author dburk...@apple.com
Date 2015-08-06 16:09:45 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187910. rdar://problem/15779101

Modified Paths

branches/safari-601.1-branch/Source/WebKit/mac/ChangeLog
branches/safari-601.1-branch/Source/WebKit/mac/Plugins/WebNetscapePluginStream.h




Diff

Modified: branches/safari-601.1-branch/Source/WebKit/mac/ChangeLog (188078 => 188079)

--- branches/safari-601.1-branch/Source/WebKit/mac/ChangeLog	2015-08-06 23:09:43 UTC (rev 188078)
+++ branches/safari-601.1-branch/Source/WebKit/mac/ChangeLog	2015-08-06 23:09:45 UTC (rev 188079)
@@ -1,5 +1,15 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187910. rdar://problem/15779101
+
+2015-08-04  Simon Fraser  simon.fra...@apple.com
+
+Fix the build.
+
+* Plugins/WebNetscapePluginStream.h:
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187886. rdar://problem/15779101
 
 2015-08-04  Alexey Proskuryakov  a...@apple.com


Modified: branches/safari-601.1-branch/Source/WebKit/mac/Plugins/WebNetscapePluginStream.h (188078 => 188079)

--- branches/safari-601.1-branch/Source/WebKit/mac/Plugins/WebNetscapePluginStream.h	2015-08-06 23:09:43 UTC (rev 188078)
+++ branches/safari-601.1-branch/Source/WebKit/mac/Plugins/WebNetscapePluginStream.h	2015-08-06 23:09:45 UTC (rev 188079)
@@ -98,9 +98,9 @@
 
 // NetscapePlugInStreamLoaderClient methods.
 void willSendRequest(WebCore::NetscapePlugInStreamLoader*, WebCore::ResourceRequest, const WebCore::ResourceResponse redirectResponse, std::functionvoid (WebCore::ResourceRequest)) override;
-void didReceiveResponse(WebCore::NetscapePlugInStreamLoader*, const WebCore::ResourceResponse);
-void didFail(WebCore::NetscapePlugInStreamLoader*, const WebCore::ResourceError);
-bool wantsAllStreams() const;
+void didReceiveResponse(WebCore::NetscapePlugInStreamLoader*, const WebCore::ResourceResponse) override;
+void didFail(WebCore::NetscapePlugInStreamLoader*, const WebCore::ResourceError) override;
+bool wantsAllStreams() const override;
 
 RetainPtrNSMutableData m_deliveryData;
 WebCore::URL m_requestURL;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188086] trunk/Source/JavaScriptCore

Title: [188086] trunk/Source/_javascript_Core








Revision 188086
Author commit-qu...@webkit.org
Date 2015-08-06 16:25:46 -0700 (Thu, 06 Aug 2015)


Log Message
The typedArrayLength function in FTLLowerDFGToLLVM is dead code.
https://bugs.webkit.org/show_bug.cgi?id=147749

Patch by Keith Miller keith_mil...@apple.com on 2015-08-06
Reviewed by Filip Pizlo.

Removed dead code elimination. the TypedArray length is compiled in compileGetArrayLength()
thus no one calls this code.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::typedArrayLength): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (188085 => 188086)

--- trunk/Source/_javascript_Core/ChangeLog	2015-08-06 23:23:56 UTC (rev 188085)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-08-06 23:25:46 UTC (rev 188086)
@@ -1,5 +1,18 @@
 2015-08-06  Keith Miller  keith_mil...@apple.com
 
+The typedArrayLength function in FTLLowerDFGToLLVM is dead code.
+https://bugs.webkit.org/show_bug.cgi?id=147749
+
+Reviewed by Filip Pizlo.
+
+Removed dead code elimination. the TypedArray length is compiled in compileGetArrayLength()
+thus no one calls this code.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::typedArrayLength): Deleted.
+
+2015-08-06  Keith Miller  keith_mil...@apple.com
+
 The JSONP parser incorrectly parsers -0 as +0.
 https://bugs.webkit.org/show_bug.cgi?id=147590
 


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (188085 => 188086)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-08-06 23:23:56 UTC (rev 188085)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-08-06 23:25:46 UTC (rev 188086)
@@ -6047,19 +6047,6 @@
 m_out.phi(m_out.intPtr, fastButterfly, slowButterfly));
 }
 
-LValue typedArrayLength(Edge baseEdge, ArrayMode arrayMode, LValue base)
-{
-JSArrayBufferView* view = m_graph.tryGetFoldableView(provenValue(baseEdge), arrayMode);
-if (view)
-return m_out.constInt32(view-length());
-return m_out.load32NonNegative(base, m_heaps.JSArrayBufferView_length);
-}
-
-LValue typedArrayLength(Edge baseEdge, ArrayMode arrayMode)
-{
-return typedArrayLength(baseEdge, arrayMode, lowCell(baseEdge));
-}
-
 LValue boolify(Edge edge)
 {
 switch (edge.useKind()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188097] trunk/Source/WebKit2

Title: [188097] trunk/Source/WebKit2








Revision 188097
Author mra...@apple.com
Date 2015-08-06 17:00:58 -0700 (Thu, 06 Aug 2015)


Log Message
Media Session: notify focus manager clients when the playing state of the focused media element changes
https://bugs.webkit.org/show_bug.cgi?id=147745

Reviewed by Tim Horton.

Added plumbing to allow focus manager's clients to be notified when the focused Content media element begins
playing or is paused.

* UIProcess/API/C/WKMediaSessionFocusManager.cpp:
(WKMediaSessionFocusManagerSetClient):
* UIProcess/API/C/WKMediaSessionFocusManager.h:
* UIProcess/WebMediaSessionFocusManager.cpp:
(WebKit::WebMediaSessionFocusManager::initializeClient):
(WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange):
* UIProcess/WebMediaSessionFocusManager.h:
* UIProcess/WebMediaSessionFocusManagerClient.cpp:
(WebKit::WebMediaSessionFocusManagerClient::didChangePlaybackAttribute):
* UIProcess/WebMediaSessionFocusManagerClient.h:
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h
trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp
trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManagerClient.cpp
trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManagerClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188096 => 188097)

--- trunk/Source/WebKit2/ChangeLog	2015-08-06 23:48:24 UTC (rev 188096)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-07 00:00:58 UTC (rev 188097)
@@ -1,3 +1,25 @@
+2015-08-06  Matt Rajca  mra...@apple.com
+
+Media Session: notify focus manager clients when the playing state of the focused media element changes
+https://bugs.webkit.org/show_bug.cgi?id=147745
+
+Reviewed by Tim Horton.
+
+Added plumbing to allow focus manager's clients to be notified when the focused Content media element begins
+playing or is paused.
+
+* UIProcess/API/C/WKMediaSessionFocusManager.cpp:
+(WKMediaSessionFocusManagerSetClient):
+* UIProcess/API/C/WKMediaSessionFocusManager.h:
+* UIProcess/WebMediaSessionFocusManager.cpp:
+(WebKit::WebMediaSessionFocusManager::initializeClient):
+(WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange):
+* UIProcess/WebMediaSessionFocusManager.h:
+* UIProcess/WebMediaSessionFocusManagerClient.cpp:
+(WebKit::WebMediaSessionFocusManagerClient::didChangePlaybackAttribute):
+* UIProcess/WebMediaSessionFocusManagerClient.h:
+* WebKit2.xcodeproj/project.pbxproj:
+
 2015-08-06  Alex Christensen  achristen...@webkit.org
 
 Make CMake usable on Mac.


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp (188096 => 188097)

--- trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp	2015-08-06 23:48:24 UTC (rev 188096)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp	2015-08-07 00:00:58 UTC (rev 188097)
@@ -40,6 +40,16 @@
 #endif
 }
 
+void WKMediaSessionFocusManagerSetClient(WKMediaSessionFocusManagerRef manager, const WKMediaSessionFocusManagerClientBase* client)
+{
+#if ENABLE(MEDIA_SESSION)
+toImpl(manager)-initializeClient(client);
+#else
+UNUSED_PARAM(manager);
+UNUSED_PARAM(client);
+#endif
+}
+
 bool WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying(WKMediaSessionFocusManagerRef manager)
 {
 #if ENABLE(MEDIA_SESSION)


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h (188096 => 188097)

--- trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h	2015-08-06 23:48:24 UTC (rev 188096)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h	2015-08-07 00:00:58 UTC (rev 188097)
@@ -36,8 +36,30 @@
 extern C {
 #endif
 
+enum {
+IsPlaying = 1  0
+};
+typedef uint32_t WKMediaSessionFocusManagerPlaybackAttribute;
+
+// Media Session Focus Manager Client
+typedef void (*WKMediaSessionFocusManagerDidChangePlaybackAttribute)(WKMediaSessionFocusManagerRef manager, WKMediaSessionFocusManagerPlaybackAttribute playbackAttribute, bool value, const void *clientInfo);
+
+typedef struct WKMediaSessionFocusManagerClientBase {
+int  version;
+const void * clientInfo;
+} WKMediaSessionFocusManagerClientBase;
+
+typedef struct WKMediaSessionFocusManagerClientV0 {
+WKMediaSessionFocusManagerClientBase base;
+
+// Version 0.
+WKMediaSessionFocusManagerDidChangePlaybackAttribute didChangePlaybackAttribute;
+} WKMediaSessionFocusManagerClientV0;
+
 WK_EXPORT WKTypeID WKMediaSessionFocusManagerGetTypeID();
 
+WK_EXPORT void

[webkit-changes] [188071] branches/jsc-tailcall/Source/JavaScriptCore

2015-08-06 Thread msaboff

Title: [188071] branches/jsc-tailcall/Source/_javascript_Core








Revision 188071
Author msab...@apple.com
Date 2015-08-06 15:41:51 -0700 (Thu, 06 Aug 2015)


Log Message
jsc-tailcall: Exceptions should properly restore callee save register contents during unwinding
https://bugs.webkit.org/show_bug.cgi?id=147639

Reviewed by Basile Clement.

Added handling of callee save register restoration to exception handling.
The basic flow is when an exception is thrown or one is recognized to have been
generated in C++ code, we save the current state of all callee save registers to
VM::calleeSaveRegistersBuffer.  As we unwind looking for the corresponding catch,
we copy the callee saves from call frames to the same VM::calleeSaveRegistersBuffer.
This is done for all call frames on the stack up to but not including the call
frame that has the corresponding catch block.  When we process the catch, we
restore the callee save registers with the contents of VM::calleeSaveRegistersBuffer.
If there isn't a catch, then handleUncaughtException will restore callee saves
before it returns back to the calling C++.

As part of this change, restructured callee save handling in OSR exit handlers so
that we always use the current values of the tag registers for boxing.  Also
eliminated the writing out of undefined for the baseline's callee saves slots.

Eliminated callee saves registers as possible locals for various thunk generation
as the callee saves may not have been saved by the function calling the thunk.

Cleaned up the static RegisterSet's including added one for LLInt callee saves and
one to be used to allocate local registers not including the callee saves or other
special registers.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock): Set the initial callee saves to what the LLInt needs.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
* interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator()):
(JSC::UnwindFunctor::copyCalleeSavesToVMCalleeSavesBuffer):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitRestoreCalleeSaves):
* jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileExceptionHandlers):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_throw):
* jit/Repatch.cpp:
(JSC::generateByIdStub):
* jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):
* llint/LowLevelInterpreter32.asm:
(_llint_throw_from_slow_path_trampoline):
* llint/LowLevelInterpreter64.asm:
(_llint_throw_from_slow_path_trampoline):
* llint/LowLevelInterpreter.asm:
(copyCalleeSavesToVMCalleeSavesBuffer):
Copy callee saves register contents to VM::calleeSaveRegistersBuffer.

* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMCalleeSavesBuffer):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
* llint/LowLevelInterpreter32.asm:
(_handleUncaughtException):
(_llint_op_catch):
* llint/LowLevelInterpreter64.asm:
(_handleUncaughtException):
(_llint_op_catch):
* llint/LowLevelInterpreter.asm:
(restoreCalleeSavesFromVMCalleeSavesBuffer):
Restore callee saves register contents from VM::calleeSaveRegistersBuffer.

* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompilerCommon.cpp:
Restore callee saves from the DFG and save the appropriate ones for the baseline JIT.
Materialize the tag registers on 64 bit platforms.
   
(JSC::DFG::adjustAndJumpToTarget):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::copyCalleeSavesToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer):
* jit/CCallHelpers.h:
(JSC::CCallHelpers::jumpToExceptionHandler):
(JSC::CCallHelpers::prepareForTailCallSlow):
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_hint):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
* jit/RegisterSet.cpp:
(JSC::RegisterSet::specialRegisters):
(JSC::RegisterSet::nonTempRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::llintCalleeSaveRegisters):
(JSC::RegisterSet::baselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):
(JSC::RegisterSet::allVMCalleeSaveRegisters):
(JSC::RegisterSet::allGPRs):
* jit/RegisterSet.h:
Added LLInt callee saves register set.
Updated the register set of used registers to include callee saves.

* jit/GPRInfo.h:
* llint/LowLevelInterpreter.asm:
(preserveCalleeSavesUsedByLLInt):
(restoreCalleeSavesUsedByLLInt):
Fixed numberOfLLIntBaselineCalleeSaveRegisters for X86-64 Windows.

* llint/LowLevelInterpreter.asm:
(prologue): Moved callee save preservation to before we overwrite the PC callee

[webkit-changes] [188072] branches/jsc-tailcall/Source/JavaScriptCore

2015-08-06 Thread msaboff

Title: [188072] branches/jsc-tailcall/Source/_javascript_Core








Revision 188072
Author msab...@apple.com
Date 2015-08-06 15:45:20 -0700 (Thu, 06 Aug 2015)


Log Message
jsc-tailcall: Stop saving and restoring all callee saves on vmEntry / exit for platforms with per function callee saves handling
https://bugs.webkit.org/show_bug.cgi?id=147747

Reviewed by Basile Clement.

Removed saving of callee save registers and materialization of special tag registers for
64 bit platforms.

* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter64.asm:

Modified Paths

branches/jsc-tailcall/Source/_javascript_Core/ChangeLog
branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm
branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter64.asm




Diff

Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (188071 => 188072)

--- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog	2015-08-06 22:41:51 UTC (rev 188071)
+++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog	2015-08-06 22:45:20 UTC (rev 188072)
@@ -1,5 +1,18 @@
 2015-08-06  Michael Saboff  msab...@apple.com
 
+jsc-tailcall: Stop saving and restoring all callee saves on vmEntry / exit for platforms with per function callee saves handling
+https://bugs.webkit.org/show_bug.cgi?id=147747
+
+Reviewed by Basile Clement.
+
+Removed saving of callee save registers and materialization of special tag registers for
+64 bit platforms.
+
+* llint/LowLevelInterpreter.asm:
+* llint/LowLevelInterpreter64.asm:
+
+2015-08-06  Michael Saboff  msab...@apple.com
+
 jsc-tailcall: Exceptions should properly restore callee save register contents during unwinding
 https://bugs.webkit.org/show_bug.cgi?id=147639
 


Modified: branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm (188071 => 188072)

--- branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2015-08-06 22:41:51 UTC (rev 188071)
+++ branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2015-08-06 22:45:20 UTC (rev 188072)
@@ -397,18 +397,15 @@
 end
 end
 
-if C_LOOP
+# ARM64 and the X86 64 bit platforms properly save and restore callee saves in each function.
+if C_LOOP or ARM64 or X86_64 or X86_64_WIN
 const CalleeSaveRegisterCount = 0
 elsif ARM or ARMv7_TRADITIONAL or ARMv7
 const CalleeSaveRegisterCount = 7
-elsif ARM64
-const CalleeSaveRegisterCount = 10
-elsif SH4 or X86_64 or MIPS
+elsif SH4 or MIPS
 const CalleeSaveRegisterCount = 5
 elsif X86 or X86_WIN
 const CalleeSaveRegisterCount = 3
-elsif X86_64_WIN
-const CalleeSaveRegisterCount = 7
 end
 
 const CalleeRegisterSaveSize = CalleeSaveRegisterCount * PtrSize
@@ -418,17 +415,11 @@
 const VMEntryTotalFrameSize = (CalleeRegisterSaveSize + sizeof VMEntryRecord + StackAlignment - 1)  ~StackAlignmentMask
 
 macro pushCalleeSaves()
-if C_LOOP
+if C_LOOP or ARM64 or X86_64 or X86_64_WIN
 elsif ARM or ARMv7_TRADITIONAL
 emit push {r4-r10}
 elsif ARMv7
 emit push {r4-r6, r8-r11}
-elsif ARM64
-emit stp x20, x19, [sp, #-16]!
-emit stp x22, x21, [sp, #-16]!
-emit stp x24, x23, [sp, #-16]!
-emit stp x26, x25, [sp, #-16]!
-emit stp x28, x27, [sp, #-16]!
 elsif MIPS
 emit addiu $sp, $sp, -20
 emit sw $20, 16($sp)
@@ -450,35 +441,15 @@
 emit push esi
 emit push edi
 emit push ebx
-elsif X86_64
-emit push %r12
-emit push %r13
-emit push %r14
-emit push %r15
-emit push %rbx
-elsif X86_64_WIN
-emit push r12
-emit push r13
-emit push r14
-emit push r15
-emit push rbx
-emit push rdi
-emit push rsi
 end
 end
 
 macro popCalleeSaves()
-if C_LOOP
+if C_LOOP or ARM64 or X86_64 or X86_64_WIN
 elsif ARM or ARMv7_TRADITIONAL
 emit pop {r4-r10}
 elsif ARMv7
 emit pop {r4-r6, r8-r11}
-elsif ARM64
-emit ldp x28, x27, [sp], #16
-emit ldp x26, x25, [sp], #16
-emit ldp x24, x23, [sp], #16
-emit ldp x22, x21, [sp], #16
-emit ldp x20, x19, [sp], #16
 elsif MIPS
 emit lw $16, 0($sp)
 emit lw $17, 4($sp)
@@ -500,20 +471,6 @@
 emit pop ebx
 emit pop edi
 emit pop esi
-elsif X86_64
-emit pop %rbx
-emit pop %r15
-emit pop %r14
-emit pop %r13
-emit pop %r12
-elsif X86_64_WIN
-emit pop rsi
-emit pop rdi
-emit pop rbx
-emit pop r15
-emit pop r14
-emit pop r13
-emit pop r12
 end
 end
 
@@ -559,10 +516,9 @@
 storep csr3, -16[cfr]
 storep csr0, -24[cfr]
 elsif X86_64_WIN
-storep t4, -8[cfr]
-storep csr6, -16[cfr]
-storep csr5, -24[cfr]
-storep csr0, -32[cfr]
+storep csr6,

[webkit-changes] [188087] trunk/Websites/webkit.org

Title: [188087] trunk/Websites/webkit.org








Revision 188087
Author bfulg...@apple.com
Date 2015-08-06 16:31:45 -0700 (Thu, 06 Aug 2015)


Log Message
Add an example of backdrop-filter.

* demos/backdrop-filter: Added.
* demos/backdrop-filter/dynamic_poster.jpg: Added.
* demos/backdrop-filter/dynamic_source.m4v: Added.
* demos/backdrop-filter/index.html: Added.
* demos/backdrop-filter/inverted_color.jpg: Added.
* demos/backdrop-filter/multiple.jpg: Added.
* demos/backdrop-filter/simple_blur.jpg: Added.

Modified Paths

trunk/Websites/webkit.org/ChangeLog


Added Paths

trunk/Websites/webkit.org/demos/backdrop-filter/
trunk/Websites/webkit.org/demos/backdrop-filter/dynamic_poster.jpg
trunk/Websites/webkit.org/demos/backdrop-filter/dynamic_source.m4v
trunk/Websites/webkit.org/demos/backdrop-filter/index.html
trunk/Websites/webkit.org/demos/backdrop-filter/inverted_color.jpg
trunk/Websites/webkit.org/demos/backdrop-filter/multiple.jpg
trunk/Websites/webkit.org/demos/backdrop-filter/simple_blur.jpg




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (188086 => 188087)

--- trunk/Websites/webkit.org/ChangeLog	2015-08-06 23:25:46 UTC (rev 188086)
+++ trunk/Websites/webkit.org/ChangeLog	2015-08-06 23:31:45 UTC (rev 188087)
@@ -1,5 +1,17 @@
 2015-08-06  Brent Fulgham  bfulg...@apple.com
 
+Add an example of backdrop-filter.
+
+* demos/backdrop-filter: Added.
+* demos/backdrop-filter/dynamic_poster.jpg: Added.
+* demos/backdrop-filter/dynamic_source.m4v: Added.
+* demos/backdrop-filter/index.html: Added.
+* demos/backdrop-filter/inverted_color.jpg: Added.
+* demos/backdrop-filter/multiple.jpg: Added.
+* demos/backdrop-filter/simple_blur.jpg: Added.
+
+2015-08-06  Brent Fulgham  bfulg...@apple.com
+
 Add a poster image for the video.
 
 * blog-files/backdrop-filters/dynamic_poster.jpg: Added.


Added: trunk/Websites/webkit.org/demos/backdrop-filter/dynamic_poster.jpg

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/demos/backdrop-filter/dynamic_poster.jpg
___

Added: svn:mime-type

Added: trunk/Websites/webkit.org/demos/backdrop-filter/dynamic_source.m4v

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/demos/backdrop-filter/dynamic_source.m4v
___

Added: svn:mime-type

Added: trunk/Websites/webkit.org/demos/backdrop-filter/index.html (0 => 188087)

--- trunk/Websites/webkit.org/demos/backdrop-filter/index.html	(rev 0)
+++ trunk/Websites/webkit.org/demos/backdrop-filter/index.html	2015-08-06 23:31:45 UTC (rev 188087)
@@ -0,0 +1,148 @@
+html
+head
+titlebackdrop-filter property example/title
+style
+body {
+font-family: Helvetica Neue, Helvetica, Arial, sans-serif;
+font-size: 120%;
+line-height: 1.5;
+margin: 2em 2em;
+padding: 0;
+background-color: #E2E6F5;
+}
+
+.backdrop {
+position: relative;
+margin: 50px auto 50px auto;
+}
+
+.backdrop img, .backdrop video {
+display: block;
+margin: 0px auto;
+width: 800px;
+}
+
+.backdrop p {
+position: absolute;
+top: 140px;
+left: 0px;
+right: 0px;
+line-height: 100px;
+width: 600px;
+display: block;
+text-align: center;
+font-size: 60px;
+padding: 15px 30px;
+margin: 0px auto;
+background-color: rgba(0, 0, 0, 0.2);
+border: 1px solid white;
+text-shadow: 0px 0px 3px black;
+font-family: Myriad Set Pro;
+color: white;
+}
+
+#simpleBlur {
+-webkit-backdrop-filter: blur(10px);
+background-color: transparent;
+}
+
+#invertedColor {
+top: 180px;
+-webkit-backdrop-filter: invert();
+}
+
+#multiple {
+top: 180px;
+-webkit-backdrop-filter: sepia() hue-rotate(120deg);
+background-color: transparent;
+}
+
+#dynamic {
+top: 350px;
+font-size: 30px;
+line-height: 40px;
+-webkit-backdrop-filter: blur(10px);
+}
+
+pre {
+padding: 1em 3em;
+border: 1px solid #ccc;
+background-color: #ddd;
+}
+
+code {
+font-size: 115%;
+font-weight: bold;
+color: #0F5426;
+}
+/style
+/head
+body
+
+h1
+The codebackdrop-filter/code Property.
+/h1
+
+p
+The following are a series of image (codeimg/code) elements, each with a codediv/code positioned
+on top. Each of these codediv/code's are styled using a different type of backdrop filter.
+/p
+
+h2
+A simple blur effect.
+/h2
+div class=backdrop
+img src=""
+p id=simpleBlurbackdrop-filter: blur(10px)/p
+/div
+p
+The CSS for the above image is:
+/p
+pre
+-webkit-backdrop-filter: blur(10px);
+/pre
+
+h2
+

[webkit-changes] [188088] trunk/Source/WebCore

Title: [188088] trunk/Source/WebCore








Revision 188088
Author mmaxfi...@apple.com
Date 2015-08-06 16:31:53 -0700 (Thu, 06 Aug 2015)


Log Message
Make FontDescriptionKey sensitive to FontFeatureSettings
https://bugs.webkit.org/show_bug.cgi?id=147751

Reviewed by Anders Carlsson.

Just like how FontDescription hashes should be sensitive to locale, they should
also be sensitive to font features.

This patch also fixes operator== for FontDescriptionKey, which was previously
comparing hashes for equality instead of the underlying data. Comparing hashes
for equality is useless inside hashmaps.

This is in preparation for implementing font-feature-settings.

No new tests because there is no behavior change.

* platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): Deleted.
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::operator!=):
(WebCore::FontDescriptionKey::isHashTableDeletedValue):
(WebCore::FontDescriptionKey::computeHash):
* platform/graphics/FontFeatureSettings.cpp:
(WebCore::FontFeature::hash):
(WebCore::FontFeatureSettings::hash):
* platform/graphics/FontFeatureSettings.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.cpp
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/FontFeatureSettings.cpp
trunk/Source/WebCore/platform/graphics/FontFeatureSettings.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188087 => 188088)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 23:31:45 UTC (rev 188087)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 23:31:53 UTC (rev 188088)
@@ -1,3 +1,36 @@
+2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
+
+Make FontDescriptionKey sensitive to FontFeatureSettings
+https://bugs.webkit.org/show_bug.cgi?id=147751
+
+Reviewed by Anders Carlsson.
+
+Just like how FontDescription hashes should be sensitive to locale, they should
+also be sensitive to font features.
+
+This patch also fixes operator== for FontDescriptionKey, which was previously
+comparing hashes for equality instead of the underlying data. Comparing hashes
+for equality is useless inside hashmaps.
+
+This is in preparation for implementing font-feature-settings.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/FontCache.cpp:
+(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
+(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
+(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): Deleted.
+* platform/graphics/FontCache.h:
+(WebCore::FontDescriptionKey::FontDescriptionKey):
+(WebCore::FontDescriptionKey::operator==):
+(WebCore::FontDescriptionKey::operator!=):
+(WebCore::FontDescriptionKey::isHashTableDeletedValue):
+(WebCore::FontDescriptionKey::computeHash):
+* platform/graphics/FontFeatureSettings.cpp:
+(WebCore::FontFeature::hash):
+(WebCore::FontFeatureSettings::hash):
+* platform/graphics/FontFeatureSettings.h:
+
 2015-08-06  Anders Carlsson  ander...@apple.com
 
 Merge SQLStatement into SQLStatementBackend


Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (188087 => 188088)

--- trunk/Source/WebCore/platform/graphics/FontCache.cpp	2015-08-06 23:31:45 UTC (rev 188087)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp	2015-08-06 23:31:53 UTC (rev 188088)
@@ -105,9 +105,12 @@
 , m_family(family)
 { }
 
-FontPlatformDataCacheKey(HashTableDeletedValueType) : m_fontDescriptionKey(hashTableDeletedSize()) { }
-bool isHashTableDeletedValue() const { return m_fontDescriptionKey.size == hashTableDeletedSize(); }
+explicit FontPlatformDataCacheKey(HashTableDeletedValueType t)
+: m_fontDescriptionKey(t)
+{ }
 
+bool isHashTableDeletedValue() const { return m_fontDescriptionKey.isHashTableDeletedValue(); }
+
 bool operator==(const FontPlatformDataCacheKey other) const
 {
 return equalIgnoringCase(m_family, other.m_family)  m_fontDescriptionKey == other.m_fontDescriptionKey;
@@ -115,9 +118,6 @@
 
 FontDescriptionKey m_fontDescriptionKey;
 AtomicString m_family;
-
-private:
-static unsigned hashTableDeletedSize() { return 0xU; }
 };
 
 struct FontPlatformDataCacheKeyHash {


Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (188087 => 188088)

--- trunk/Source/WebCore/platform/graphics/FontCache.h	2015-08-06 23:31:45 UTC (rev 188087)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h	2015-08-06 23:31:53 UTC (rev 188088)
@@ -37,6 +37,7 @@
 #include wtf/PassRefPtr.h
 #include wtf/RefPtr.h
 #include

[webkit-changes] [188101] trunk

Title: [188101] trunk








Revision 188101
Author achristen...@apple.com
Date 2015-08-06 18:03:54 -0700 (Thu, 06 Aug 2015)


Log Message
[Win] CMake build fix after r188098.

.:

* Source/cmake/OptionsWinCairo.cmake:
OptionsWindows.cmake uses WTF_PLATFORM_WIN_CAIRO now, so we need to set it before including OptionsWindows.

Source/WebCore:

* CMakeLists.txt:
MockCDM is necessary for testing if ENCRYPTED_MEDIA_V2 is enabled.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/cmake/OptionsWinCairo.cmake




Diff

Modified: trunk/ChangeLog (188100 => 188101)

--- trunk/ChangeLog	2015-08-07 00:49:54 UTC (rev 188100)
+++ trunk/ChangeLog	2015-08-07 01:03:54 UTC (rev 188101)
@@ -1,3 +1,10 @@
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
+[Win] CMake build fix after r188098.
+
+* Source/cmake/OptionsWinCairo.cmake:
+OptionsWindows.cmake uses WTF_PLATFORM_WIN_CAIRO now, so we need to set it before including OptionsWindows.
+
 2015-08-04  Alex Christensen  achristen...@webkit.org
 
 Fix quirks with CMake and VS2015


Modified: trunk/Source/WebCore/CMakeLists.txt (188100 => 188101)

--- trunk/Source/WebCore/CMakeLists.txt	2015-08-07 00:49:54 UTC (rev 188100)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-08-07 01:03:54 UTC (rev 188101)
@@ -3284,6 +3284,7 @@
 testing/InternalSettings.cpp
 testing/Internals.cpp
 testing/MicroTaskTest.cpp
+testing/MockCDM.cpp
 testing/MockPageOverlayClient.cpp
 
 testing/js/WebCoreTestSupport.cpp


Modified: trunk/Source/WebCore/ChangeLog (188100 => 188101)

--- trunk/Source/WebCore/ChangeLog	2015-08-07 00:49:54 UTC (rev 188100)
+++ trunk/Source/WebCore/ChangeLog	2015-08-07 01:03:54 UTC (rev 188101)
@@ -1,3 +1,10 @@
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
+[Win] CMake build fix after r188098.
+
+* CMakeLists.txt:
+MockCDM is necessary for testing if ENCRYPTED_MEDIA_V2 is enabled.
+
 2015-08-05  Filip Pizlo  fpi...@apple.com
 
 Lightweight locks should be adaptive


Modified: trunk/Source/cmake/OptionsWinCairo.cmake (188100 => 188101)

--- trunk/Source/cmake/OptionsWinCairo.cmake	2015-08-07 00:49:54 UTC (rev 188100)
+++ trunk/Source/cmake/OptionsWinCairo.cmake	2015-08-07 01:03:54 UTC (rev 188101)
@@ -1,6 +1,7 @@
+set(WTF_PLATFORM_WIN_CAIRO 1)
+
 include(OptionsWindows)
 
-set(WTF_PLATFORM_WIN_CAIRO 1)
 set(USE_CF 1)
 set(USE_CURL 1)
 set(USE_ICU_UNICODE 1)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188068] trunk

2015-08-06 Thread cdumez

Title: [188068] trunk








Revision 188068
Author cdu...@apple.com
Date 2015-08-06 15:37:47 -0700 (Thu, 06 Aug 2015)


Log Message
Toggle GPS state based on page visibility to save battery
https://bugs.webkit.org/show_bug.cgi?id=147685

Reviewed by Benjamin Poulain.

Source/WebCore:

Toggle GPS state based on page visibility to save battery. Previously,
if the site you were viewing was watching your position and you
switched tab, the GPS would stay on. This was bad for battery life.

Tests: fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible.html
   fast/dom/Geolocation/stopUpdatingForHiddenPage.html

* Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::viewStateDidChange):

Tools:

Add testRunner.isGeolocationProviderActive() test support function.

* DumpRenderTree/TestRunner.cpp:
(isGeolocationProviderActiveCallback):
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/MockGeolocationProvider.h:
* DumpRenderTree/mac/MockGeolocationProvider.mm:
(-[MockGeolocationProvider isActive]):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::isGeolocationProviderActive):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::isGeolocationProviderActive):
* WebKitTestRunner/GeolocationProviderMock.h:
(WTR::GeolocationProviderMock::isActive):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::isGeolocationProviderActive):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::isGeolocationProviderActive):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::isGeolocationProviderActive):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Add layout tests to check that the GeolocationClient starts and stops
updating when page visibility changes.

* fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible-expected.txt: Added.
* fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible.html: Added.
* fast/dom/Geolocation/stopUpdatingForHiddenPage-expected.txt: Added.
* fast/dom/Geolocation/stopUpdatingForHiddenPage.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/geolocation/GeolocationController.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestRunner.cpp
trunk/Tools/DumpRenderTree/TestRunner.h
trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.h
trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.mm
trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm
trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp
trunk/Tools/WebKitTestRunner/GeolocationProviderMock.h
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp


Added Paths

trunk/LayoutTests/fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible-expected.txt
trunk/LayoutTests/fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible.html
trunk/LayoutTests/fast/dom/Geolocation/stopUpdatingForHiddenPage-expected.txt
trunk/LayoutTests/fast/dom/Geolocation/stopUpdatingForHiddenPage.html




Diff

Modified: trunk/LayoutTests/ChangeLog (188067 => 188068)

--- trunk/LayoutTests/ChangeLog	2015-08-06 22:36:34 UTC (rev 188067)
+++ trunk/LayoutTests/ChangeLog	2015-08-06 22:37:47 UTC (rev 188068)
@@ -1,3 +1,18 @@
+2015-08-06  Chris Dumez  cdu...@apple.com
+
+Toggle GPS state based on page visibility to save battery
+https://bugs.webkit.org/show_bug.cgi?id=147685
+
+Reviewed by Benjamin Poulain.
+
+Add layout tests to check that the GeolocationClient starts and stops
+updating when page visibility changes.
+
+* fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible-expected.txt: Added.
+* fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible.html: Added.
+* fast/dom/Geolocation/stopUpdatingForHiddenPage-expected.txt: Added.
+* fast/dom/Geolocation/stopUpdatingForHiddenPage.html: Added.
+
 2015-08-06  Brian Burg  bb...@apple.com
 
 Web Inspector: move http/tests/inspector-protocol/ contents to http/tests/inspector/


Added: trunk/LayoutTests/fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible-expected.txt (0 => 188068)

--- trunk/LayoutTests/fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible-expected.txt

[webkit-changes] [188070] branches/safari-601.1.46-branch/Source/WebCore

Title: [188070] branches/safari-601.1.46-branch/Source/WebCore








Revision 188070
Author bshaf...@apple.com
Date 2015-08-06 15:40:11 -0700 (Thu, 06 Aug 2015)


Log Message
Merged r188062.  rdar://problem/22028179

Modified Paths

branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp
branches/safari-601.1.46-branch/Source/WebCore/dom/Document.h




Diff

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (188069 => 188070)

--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-08-06 22:38:18 UTC (rev 188069)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-08-06 22:40:11 UTC (rev 188070)
@@ -1,5 +1,28 @@
 2015-08-06  Babak Shafiei  bshaf...@apple.com
 
+Merge r188062.
+
+2015-08-06  Eric Carlson  eric.carl...@apple.com
+
+Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument
+https://bugs.webkit.org/show_bug.cgi?id=147734
+rdar://problem/22028179
+
+Reviewed by Andy Estes.
+
+Test to follow, see https://bugs.webkit.org/show_bug.cgi?id=147735
+
+* dom/Document.cpp:
+(WebCore::Document::initSecurityContext): Use applyContentDispositionAttachmentSandbox
+  instead of setting sandbox flags directly.
+(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Don't special
+  case MediaDocument.
+(WebCore::Document::applyContentDispositionAttachmentSandbox): Apply sandbox flags
+  according to document type.
+* dom/Document.h:
+
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
 Merge r188051.
 
 2015-08-06  Eric Carlson  eric.carl...@apple.com


Modified: branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp (188069 => 188070)

--- branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp	2015-08-06 22:38:18 UTC (rev 188069)
+++ branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp	2015-08-06 22:40:11 UTC (rev 188070)
@@ -4931,7 +4931,7 @@
 enforceSandboxFlags(m_frame-loader().effectiveSandboxFlags());
 
 if (shouldEnforceContentDispositionAttachmentSandbox())
-enforceSandboxFlags(SandboxAll);
+applyContentDispositionAttachmentSandbox();
 
 setSecurityOriginPolicy(SecurityOriginPolicy::create(isSandboxed(SandboxOrigin) ? SecurityOrigin::createUnique() : SecurityOrigin::create(m_url)));
 setContentSecurityPolicy(std::make_uniqueContentSecurityPolicy(this));
@@ -6717,9 +6717,6 @@
 if (m_isSynthesized)
 return false;
 
-if (isMediaDocument())
-return false;
-
 bool contentDispositionAttachmentSandboxEnabled = settings()  settings()-contentDispositionAttachmentSandboxEnabled();
 bool responseIsAttachment = false;
 if (DocumentLoader* documentLoader = m_frame ? m_frame-loader().activeDocumentLoader() : nullptr)
@@ -6728,4 +6725,14 @@
 return contentDispositionAttachmentSandboxEnabled  responseIsAttachment;
 }
 
+void Document::applyContentDispositionAttachmentSandbox()
+{
+ASSERT(shouldEnforceContentDispositionAttachmentSandbox());
+
+if (!isMediaDocument())
+enforceSandboxFlags(SandboxAll);
+else
+enforceSandboxFlags(SandboxOrigin);
+}
+
 } // namespace WebCore


Modified: branches/safari-601.1.46-branch/Source/WebCore/dom/Document.h (188069 => 188070)

--- branches/safari-601.1.46-branch/Source/WebCore/dom/Document.h	2015-08-06 22:38:18 UTC (rev 188069)
+++ branches/safari-601.1.46-branch/Source/WebCore/dom/Document.h	2015-08-06 22:40:11 UTC (rev 188070)
@@ -1278,6 +1278,7 @@
 
 ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicyToPropagate() const;
 bool shouldEnforceContentDispositionAttachmentSandbox() const;
+void applyContentDispositionAttachmentSandbox();
 
 protected:
 enum ConstructionFlags { Synthesized = 1, NonRenderedPlaceholder = 1  1 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188082] branches/safari-601.1-branch

Title: [188082] branches/safari-601.1-branch








Revision 188082
Author dburk...@apple.com
Date 2015-08-06 16:22:38 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187930. rdar://problem/21870332

Modified Paths

branches/safari-601.1-branch/LayoutTests/ChangeLog
branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/page/mac/EventHandlerMac.mm


Added Paths

branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/resources/background.html
branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe-expected.txt
branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html




Diff

Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (188081 => 188082)

--- branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:21:04 UTC (rev 188081)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:22:38 UTC (rev 188082)
@@ -1,5 +1,21 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187930. rdar://problem/21870332
+
+2015-08-04  Brent Fulgham  bfulg...@apple.com
+
+REGRESSION (r173784): [Mac] Correct latching error for non-scrollable iframe nested inside scrollable div.
+https://bugs.webkit.org/show_bug.cgi?id=147668
+rdar://problem/21870332
+
+Reviewed by Simon Fraser.
+
+* platform/mac/fast/scrolling/resources/background.html: Added.
+* platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe-expected.txt: Added.
+* platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html: Added.
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187886. rdar://problem/15779101
 
 2015-08-04  Alexey Proskuryakov  a...@apple.com


Added: branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/resources/background.html (0 => 188082)

--- branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/resources/background.html	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/resources/background.html	2015-08-06 23:22:38 UTC (rev 188082)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+
+html
+head
+style
+div {
+position: relative;
+width: 400px;
+height: 2000px;
+padding: 0;
+background-image: repeating-linear-gradient(to bottom, white, silver 200px);
+}
+/style
+/head
+body
+divThis content is displayed in an iframe. The iframe should be sized such that it does not need to scroll./div
+/body
+/html


Added: branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe-expected.txt (0 => 188082)

--- branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe-expected.txt	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe-expected.txt	2015-08-06 23:22:38 UTC (rev 188082)
@@ -0,0 +1,16 @@
+Put mouse inside the iframe (below) and flick downwards
+
+Tests that iframe does scroll when inner iframe is NOT scrollable.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS div did scroll.
+PASS Page did NOT scroll.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html (0 => 188082)

--- branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html	2015-08-06 23:22:38 UTC (rev 188082)
@@ -0,0 +1,118 @@
+!DOCTYPE html
+html
+head
+link rel=help href=""
+script src=""
+/head
+body
+script
+
+var divTarget;
+var pageScrollPositionBefore;
+var divScrollPositionBefore;
+
+var continueCount = 5;
+
+function locationInWindowCoordinates(element)
+{
+var position = {};
+position.x = element.offsetLeft;
+position.y = element.offsetTop;
+
+while (element.offsetParent) {
+position.x = position.x + element.offsetParent.offsetLeft;
+position.y = position.y + element.offsetParent.offsetTop;
+if (element == document.getElementsByTagName(body)[0])
+break;
+
+element = element.offsetParent;
+}
+
+return position;
+}
+
+function finishTest()
+{
+finishJSTest();
+testRunner.notifyDone();
+}
+
+function checkForScroll() {
+var pageScrollPositionAfter = document.body.scrollTop;
+var divScrollPositionAfter = divTarget.scrollTop;
+
+if (divScrollPositionBefore != divScrollPositionAfter)

[webkit-changes] [188083] branches/safari-601.1-branch

Title: [188083] branches/safari-601.1-branch








Revision 188083
Author dburk...@apple.com
Date 2015-08-06 16:22:41 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187935. rdar://problem/22097682

Modified Paths

branches/safari-601.1-branch/LayoutTests/ChangeLog
branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm


Added Paths

branches/safari-601.1-branch/LayoutTests/accessibility/mac/
branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children-expected.txt
branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children.html




Diff

Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (188082 => 188083)

--- branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:22:38 UTC (rev 188082)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:22:41 UTC (rev 188083)
@@ -1,5 +1,24 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187935. rdar://problem/22097682
+
+2015-08-04  Doug Russell  d_russ...@apple.com
+
+AX: tree item children returned from ranged getter are different from full array of children
+https://bugs.webkit.org/show_bug.cgi?id=147660
+
+Add an isTreeItem() check in ranged element getter so that it matches the logic in
+the getter for the full children array. This prevents returning a row as a child
+when only the rows contents should be returned. This prevents navigation issues on
+websites without aria outlines.
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/aria-tree-item-children-expected.txt: Added.
+* accessibility/mac/aria-tree-item-children.html: Added.
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187930. rdar://problem/21870332
 
 2015-08-04  Brent Fulgham  bfulg...@apple.com


Added: branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children-expected.txt (0 => 188083)

--- branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children-expected.txt	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children-expected.txt	2015-08-06 23:22:41 UTC (rev 188083)
@@ -0,0 +1,13 @@
+Animals
+Birds
+This tests that aria tree items can be fetched as either a full list of children or via range getter to ensure the range getter isn't returning a row as it's first child.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS tree.role is 'AXRole: AXOutline'
+PASS child1 == child2 is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children.html (0 => 188083)

--- branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children.html	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/accessibility/mac/aria-tree-item-children.html	2015-08-06 23:22:41 UTC (rev 188083)
@@ -0,0 +1,47 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+script
+if (window.testRunner)
+   testRunner.dumpAsText();
+/script
+/head
+body id=body
+
+ul id=tree role=tree aria-labelledby=treelabel aria-activedescendant=tree0_item0_2_0_1 tabindex=0
+li id=treeitem1 role=treeitem aria-level=1 aria-expanded=true
+span
+span class=expander/span
+Animals
+/span
+ul role=group
+div id=treeitem2 role=treeitem aria-level=2spanBirds/span/div
+/ul
+/span
+/li
+/ul
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that aria tree items can be fetched as either a full list of children or via range getter to ensure the range getter isn't returning a row as it's first child.);
+
+if (window.accessibilityController) {
+
+  var tree = accessibilityController.accessibleElementById(tree)
+  shouldBe(tree.role, 'AXRole: AXOutline');
+
+  var treeitem = tree.childAtIndex(0);
+  var child1 = treeitem.childAtIndex(0);
+  var child2 = treeitem.uiElementArrayAttributeValue(AXChildren)[0];
+  shouldBe(child1 == child2, true);
+}
+
+/script
+
+script src=""
+/body
+/html


Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188082 => 188083)

--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:22:38 UTC (rev 188082)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:22:41 UTC (rev 188083)
@@ -1,5 +1,26 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187935. rdar://problem/22097682
+
+2015-08-04  Doug Russell  d_russ...@apple.com
+
+AX: tree item children returned from ranged getter are different from full array of children
+

[webkit-changes] [188091] branches/safari-601.1-branch

Title: [188091] branches/safari-601.1-branch








Revision 188091
Author dburk...@apple.com
Date 2015-08-06 16:35:32 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187962. rdar://problem/21827815

Modified Paths

branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.cpp
branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.h
branches/safari-601.1-branch/Source/WebCore/loader/FrameLoader.cpp
branches/safari-601.1-branch/Source/WebCore/loader/HistoryController.cpp
branches/safari-601.1-branch/Source/WebKit2/ChangeLog
branches/safari-601.1-branch/Source/WebKit2/Shared/SessionState.cpp
branches/safari-601.1-branch/Source/WebKit2/Shared/SessionState.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebCoreSupport/SessionStateConversion.cpp
branches/safari-601.1-branch/Tools/ChangeLog
branches/safari-601.1-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
branches/safari-601.1-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm


Added Paths

branches/safari-601.1-branch/Tools/TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html




Diff

Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188090 => 188091)

--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:35:28 UTC (rev 188090)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:35:32 UTC (rev 188091)
@@ -1,5 +1,39 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187962. rdar://problem/21827815
+
+2015-08-05  Daniel Bates  daba...@apple.com
+
+REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
+https://bugs.webkit.org/show_bug.cgi?id=147678
+rdar://problem/21827815
+
+Reviewed by Brady Eidson.
+
+Fixes an issue where a non-user-initiated navigation of the main frame to a phone link (tel URL)
+may be ignored. The navigation is ignored if the page was reloaded as a result of a web content
+process crash, its lifetime exceeded the back-forward cache expiration interval, or a person
+quits and opens Safari again, among other scenarios.
+
+* history/HistoryItem.cpp:
+(WebCore::HistoryItem::setShouldOpenExternalURLsPolicy): Added.
+(WebCore::HistoryItem::shouldOpenExternalURLsPolicy): Added.
+* history/HistoryItem.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::loadDifferentDocumentItem): Apply the should open external URLs policy
+from the history item, if applicable. Also, be more explicit when instantiating a NavigationAction
+so as to help make it straightforward to reduce the number of NavigationAction constructors we have
+in the future.
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::saveDocumentState): Save the should open external URLs policy to
+the history item.
+(WebCore::HistoryController::restoreDocumentState): Apply the should open external URLs policy
+from the history item to the document loader.
+(WebCore::HistoryController::initializeItem): Update the should open external URLs policy of
+the history item to reflect the policy of the document loader associated with the current frame.
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187935. rdar://problem/22097682
 
 2015-08-04  Doug Russell  d_russ...@apple.com


Modified: branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.cpp (188090 => 188091)

--- branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.cpp	2015-08-06 23:35:28 UTC (rev 188090)
+++ branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.cpp	2015-08-06 23:35:32 UTC (rev 188091)
@@ -351,6 +351,16 @@
 m_documentState.clear();
 }
 
+void HistoryItem::setShouldOpenExternalURLsPolicy(ShouldOpenExternalURLsPolicy policy)
+{
+m_shouldOpenExternalURLsPolicy = policy;
+}
+
+ShouldOpenExternalURLsPolicy HistoryItem::shouldOpenExternalURLsPolicy() const
+{
+return m_shouldOpenExternalURLsPolicy;
+}
+
 bool HistoryItem::isTargetItem() const
 {
 return m_isTargetItem;


Modified: branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.h (188090 => 188091)

--- branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.h	2015-08-06 23:35:28 UTC (rev 188090)
+++ branches/safari-601.1-branch/Source/WebCore/history/HistoryItem.h	2015-08-06 23:35:32 UTC (rev 188091)
@@ -28,6 +28,7 @@
 #define HistoryItem_h
 
 #include FloatRect.h
+#include FrameLoaderTypes.h
 #include IntPoint.h

[webkit-changes] [188090] branches/safari-601.1-branch/Source/WebKit2

Title: [188090] branches/safari-601.1-branch/Source/WebKit2








Revision 188090
Author dburk...@apple.com
Date 2015-08-06 16:35:28 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187764. rdar://problem/22077836

Modified Paths

branches/safari-601.1-branch/Source/WebKit2/ChangeLog
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm
branches/safari-601.1-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: branches/safari-601.1-branch/Source/WebKit2/ChangeLog (188089 => 188090)

--- branches/safari-601.1-branch/Source/WebKit2/ChangeLog	2015-08-06 23:35:12 UTC (rev 188089)
+++ branches/safari-601.1-branch/Source/WebKit2/ChangeLog	2015-08-06 23:35:28 UTC (rev 188090)
@@ -1,5 +1,43 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187764. rdar://problem/22077836
+
+2015-08-03  Beth Dakin  bda...@apple.com
+
+Need WKWebView API to enable/disable link preview
+https://bugs.webkit.org/show_bug.cgi?id=147573
+-and corresponding-
+rdar://problem/22077836
+
+Reviewed by Dan Bernstein.
+
+WKView implementation.
+* UIProcess/API/Cocoa/WKViewPrivate.h:
+
+New API. Call into WKView to handle Mac.
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView initWithFrame:configuration:]):
+(-[WKWebView allowsLinkPreview]):
+(-[WKWebView setAllowsLinkPreview:]):
+
+Remove the SPI declaration from WKWebViewPrivate in order to make this API.
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
+Handle the Mac side.
+* UIProcess/API/mac/WKView.mm:
+(-[WKView viewDidMoveToWindow]):
+(-[WKView initWithFrame:processPool:configuration:webView:]):
+(-[WKView allowsBackForwardNavigationGestures]):
+(-[WKView allowsLinkPreview]):
+(-[WKView setAllowsLinkPreview:]):
+
+Don’t register previews when link preview is prevented.
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _registerPreview]):
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187886. rdar://problem/15779101
 
 2015-08-04  Alexey Proskuryakov  a...@apple.com


Modified: branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (188089 => 188090)

--- branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2015-08-06 23:35:12 UTC (rev 188089)
+++ branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h	2015-08-06 23:35:28 UTC (rev 188090)
@@ -129,6 +129,9 @@
 
 - (void)setMagnification:(double)magnification centeredAtPoint:(NSPoint)point;
 
+- (void)setAllowsLinkPreview:(BOOL)allowsLinkPreview;
+- (BOOL)allowsLinkPreview;
+
 - (void)saveBackForwardSnapshotForCurrentItem;
 - (void)saveBackForwardSnapshotForItem:(WKBackForwardListItemRef)item;
 


Modified: branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (188089 => 188090)

--- branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2015-08-06 23:35:12 UTC (rev 188089)
+++ branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2015-08-06 23:35:28 UTC (rev 188090)
@@ -231,6 +231,12 @@
 */
 @property (WK_NULLABLE_PROPERTY nonatomic, copy) NSString *customUserAgent WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
 
+/*! @abstract A Boolean value indicating whether link preview is allowed for any
+ links inside this WKWebView.
+ @discussion The default value is NO on iOS and YES on Mac.
+ */
+@property (nonatomic) BOOL allowsLinkPreview WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
+
 #if TARGET_OS_IPHONE
 /*! @abstract The scroll view associated with the web view.
  */


Modified: branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (188089 => 188090)

--- branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2015-08-06 23:35:12 UTC (rev 188089)
+++ branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2015-08-06 23:35:28 UTC (rev 188090)
@@ -351,7 +351,6 @@
 [self _updateScrollViewBackground];
 
 _viewportMetaTagWidth = -1;
-_allowsLinkPreview = YES;
 
 [self _frameOrBoundsChanged];
 
@@ -659,6 +658,35 @@
 return toAPI(_page.get());
 }
 
+- (BOOL)allowsLinkPreview
+{
+#if PLATFORM(MAC)
+return [_wkView allowsLinkPreview];
+#elif PLATFORM(IOS)
+return _allowsLinkPreview;
+#endif
+}
+
+- (void)setAllowsLinkPreview:(BOOL)allowsLinkPreview
+{
+#if PLATFORM(MAC)
+[_wkView

[webkit-changes] [188089] trunk/Source/WebCore

Title: [188089] trunk/Source/WebCore








Revision 188089
Author ander...@apple.com
Date 2015-08-06 16:35:12 -0700 (Thu, 06 Aug 2015)


Log Message
Rename SQLStatementBackend to SQLStatement
https://bugs.webkit.org/show_bug.cgi?id=147755

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* Modules/webdatabase/SQLStatement.h: Renamed from Source/WebCore/Modules/webdatabase/SQLStatementBackend.h.
(WebCore::SQLStatement::hasStatementCallback):
(WebCore::SQLStatement::hasStatementErrorCallback):
* Modules/webdatabase/SQLStatementBackend.cpp: Removed.
(WebCore::SQLStatementBackend::SQLStatementBackend): Deleted.
(WebCore::SQLStatementBackend::~SQLStatementBackend): Deleted.
(WebCore::SQLStatementBackend::sqlError): Deleted.
(WebCore::SQLStatementBackend::sqlResultSet): Deleted.
(WebCore::SQLStatementBackend::execute): Deleted.
(WebCore::SQLStatementBackend::performCallback): Deleted.
(WebCore::SQLStatementBackend::setDatabaseDeletedError): Deleted.
(WebCore::SQLStatementBackend::setVersionMismatchedError): Deleted.
(WebCore::SQLStatementBackend::setFailureDueToQuota): Deleted.
(WebCore::SQLStatementBackend::clearFailureDueToQuota): Deleted.
(WebCore::SQLStatementBackend::lastExecutionFailedDueToQuota): Deleted.
* Modules/webdatabase/SQLStatementBackend.h:
(WebCore::SQLStatementBackend::hasStatementCallback): Deleted.
(WebCore::SQLStatementBackend::hasStatementErrorCallback): Deleted.
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::executeSQL):
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::executeSQL):
* Modules/webdatabase/SQLTransactionBackend.h:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/Modules/webdatabase/SQLStatement.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLStatement.h


Removed Paths

trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (188088 => 188089)

--- trunk/Source/WebCore/CMakeLists.txt	2015-08-06 23:31:53 UTC (rev 188088)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-08-06 23:35:12 UTC (rev 188089)
@@ -1013,7 +1013,7 @@
 Modules/webdatabase/SQLException.cpp
 Modules/webdatabase/SQLResultSet.cpp
 Modules/webdatabase/SQLResultSetRowList.cpp
-Modules/webdatabase/SQLStatementBackend.cpp
+Modules/webdatabase/SQLStatement.cpp
 Modules/webdatabase/SQLTransaction.cpp
 Modules/webdatabase/SQLTransactionBackend.cpp
 Modules/webdatabase/SQLTransactionClient.cpp


Modified: trunk/Source/WebCore/ChangeLog (188088 => 188089)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 23:31:53 UTC (rev 188088)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 23:35:12 UTC (rev 188089)
@@ -1,3 +1,41 @@
+2015-08-06  Anders Carlsson  ander...@apple.com
+
+Rename SQLStatementBackend to SQLStatement
+https://bugs.webkit.org/show_bug.cgi?id=147755
+
+Reviewed by Geoffrey Garen.
+
+* CMakeLists.txt:
+* Modules/webdatabase/SQLStatement.h: Renamed from Source/WebCore/Modules/webdatabase/SQLStatementBackend.h.
+(WebCore::SQLStatement::hasStatementCallback):
+(WebCore::SQLStatement::hasStatementErrorCallback):
+* Modules/webdatabase/SQLStatementBackend.cpp: Removed.
+(WebCore::SQLStatementBackend::SQLStatementBackend): Deleted.
+(WebCore::SQLStatementBackend::~SQLStatementBackend): Deleted.
+(WebCore::SQLStatementBackend::sqlError): Deleted.
+(WebCore::SQLStatementBackend::sqlResultSet): Deleted.
+(WebCore::SQLStatementBackend::execute): Deleted.
+(WebCore::SQLStatementBackend::performCallback): Deleted.
+(WebCore::SQLStatementBackend::setDatabaseDeletedError): Deleted.
+(WebCore::SQLStatementBackend::setVersionMismatchedError): Deleted.
+(WebCore::SQLStatementBackend::setFailureDueToQuota): Deleted.
+(WebCore::SQLStatementBackend::clearFailureDueToQuota): Deleted.
+(WebCore::SQLStatementBackend::lastExecutionFailedDueToQuota): Deleted.
+* Modules/webdatabase/SQLStatementBackend.h:
+(WebCore::SQLStatementBackend::hasStatementCallback): Deleted.
+(WebCore::SQLStatementBackend::hasStatementErrorCallback): Deleted.
+*

[webkit-changes] [188095] branches/safari-601.1-branch/Source/WebKit2

Title: [188095] branches/safari-601.1-branch/Source/WebKit2








Revision 188095
Author dburk...@apple.com
Date 2015-08-06 16:48:19 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r188011. rdar://problem/22055130

Modified Paths

branches/safari-601.1-branch/Source/WebKit2/ChangeLog
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm
branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebFrameProxy.cpp
branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebFrameProxy.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebPageProxy.h
branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebPageProxy.messages.in
branches/safari-601.1-branch/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: branches/safari-601.1-branch/Source/WebKit2/ChangeLog (188094 => 188095)

--- branches/safari-601.1-branch/Source/WebKit2/ChangeLog	2015-08-06 23:48:16 UTC (rev 188094)
+++ branches/safari-601.1-branch/Source/WebKit2/ChangeLog	2015-08-06 23:48:19 UTC (rev 188095)
@@ -1,5 +1,54 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r188011. rdar://problem/22055130
+
+2015-08-05  Tim Horton  timothy_hor...@apple.com
+
+PDFPlugins are clipped in link previews (and remain so when opened)
+https://bugs.webkit.org/show_bug.cgi?id=147708
+rdar://problem/22055130
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView initWithFrame:processPool:configuration:webView:]):
+(-[WKView _supportsArbitraryLayoutModes]):
+(-[WKView _didCommitLoadForMainFrame]):
+(-[WKView _setLayoutMode:]):
+(-[WKView _setViewScale:]):
+Avoid using any layout mode other than ViewSize for main frame PluginDocuments,
+because they will often end up behaving incorrectly (especially with PDFPlugin,
+which is even more special in that it takes over application of page scale).
+
+Save any incoming changes to the viewScale and layoutMode, and re-apply
+them once we load something in the main frame that is *not* a PluginDocument.
+
+* UIProcess/API/mac/WKViewInternal.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::scalePage):
+Make sure to reset WebCore's page scale if the main frame contains a
+PluginDocument that takes care of page scale itself.
+
+(WebKit::WebPage::didCommitLoad):
+Do the same thing as what we do in WKView _didCommitLoadForMainFrame,
+but without the UI process round-trip, to avoid an ugly flash.
+
+* UIProcess/WebFrameProxy.cpp:
+(WebKit::WebFrameProxy::didCommitLoad):
+* UIProcess/WebFrameProxy.h:
+(WebKit::WebFrameProxy::containsPluginDocument):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didCommitLoadForFrame):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* UIProcess/mac/PageClientImpl.mm:
+(WebKit::PageClientImpl::didCommitLoadForMainFrame):
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
+Plumb and keep track of whether the main frame contains a PluginDocument or not.
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187962. rdar://problem/21827815
 
 2015-08-05  Daniel Bates  daba...@apple.com


Modified: branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm (188094 => 188095)

--- branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm	2015-08-06 23:48:16 UTC (rev 188094)
+++ branches/safari-601.1-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm	2015-08-06 23:48:19 UTC (rev 188095)
@@ -264,6 +264,8 @@
 BOOL _allowsLinkPreview;
 
 RetainPtrWKViewLayoutStrategy _layoutStrategy;
+WKLayoutMode _lastRequestedLayoutMode;
+float _lastRequestedViewScale;
 CGSize _minimumViewSize;
 
 RetainPtrCALayer _rootLayer;
@@ -3776,6 +3778,8 @@
 _data-_clipsToVisibleRect = NO;
 _data-_useContentPreparationRectForVisibleRect = NO;
 _data-_windowOcclusionDetectionEnabled = YES;
+_data-_lastRequestedLayoutMode = kWKLayoutModeViewSize;
+_data-_lastRequestedViewScale = 1;
 
 _data-_windowVisibilityObserver = adoptNS([[WKWindowVisibilityObserver alloc] initWithView:self]);
 
@@ -3894,6 +3898,41 @@
 _data-_gestureController-didFirstVisuallyNonEmptyLayoutForMainFrame();
 }
 
+- (BOOL)_supportsArbitraryLayoutModes
+{
+WebPageProxy*

[webkit-changes] [188094] branches/safari-601.1-branch/Source/WebKit/win

Title: [188094] branches/safari-601.1-branch/Source/WebKit/win








Revision 188094
Author dburk...@apple.com
Date 2015-08-06 16:48:16 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r188005. rdar://problem/22059707

Modified Paths

branches/safari-601.1-branch/Source/WebKit/win/ChangeLog
branches/safari-601.1-branch/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl
branches/safari-601.1-branch/Source/WebKit/win/WebPreferenceKeysPrivate.h
branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.cpp
branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.h
branches/safari-601.1-branch/Source/WebKit/win/WebView.cpp




Diff

Modified: branches/safari-601.1-branch/Source/WebKit/win/ChangeLog (188093 => 188094)

--- branches/safari-601.1-branch/Source/WebKit/win/ChangeLog	2015-08-06 23:41:39 UTC (rev 188093)
+++ branches/safari-601.1-branch/Source/WebKit/win/ChangeLog	2015-08-06 23:48:16 UTC (rev 188094)
@@ -1,5 +1,25 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r188005. rdar://problem/22059707
+
+2015-08-05  Brent Fulgham  bfulg...@apple.com
+
+[Win] Allow display of mixed content on Windows by default
+https://bugs.webkit.org/show_bug.cgi?id=147693
+rdar://problem/22059707
+
+Reviewed by Alex Christensen.
+
+* Interfaces/IWebPreferencesPrivate.idl: Add preference accessor
+to allow getting/setting use of insecure content.
+* WebPreferenceKeysPrivate.h: Add new key for preference.
+* WebPreferences.cpp: Implement preference accessor.
+* WebPreferences.h:
+* WebView.cpp: Set WebCore settings to match prefernces for
+loading mixed content.
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187894. rdar://problem/15779101
 
 2015-08-04  Alex Christensen  achristen...@webkit.org


Modified: branches/safari-601.1-branch/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (188093 => 188094)

--- branches/safari-601.1-branch/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl	2015-08-06 23:41:39 UTC (rev 188093)
+++ branches/safari-601.1-branch/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl	2015-08-06 23:48:16 UTC (rev 188094)
@@ -168,4 +168,6 @@
 {
 HRESULT _javascript_RuntimeFlags([out, retval] unsigned* flags);
 HRESULT setJavaScriptRuntimeFlags([in] unsigned flags);
+HRESULT allowDisplayAndRunningOfInsecureContent([out, retval] BOOL* enabled);
+HRESULT setAllowDisplayAndRunningOfInsecureContent([in] BOOL enabled);
 }
\ No newline at end of file


Modified: branches/safari-601.1-branch/Source/WebKit/win/WebPreferenceKeysPrivate.h (188093 => 188094)

--- branches/safari-601.1-branch/Source/WebKit/win/WebPreferenceKeysPrivate.h	2015-08-06 23:41:39 UTC (rev 188093)
+++ branches/safari-601.1-branch/Source/WebKit/win/WebPreferenceKeysPrivate.h	2015-08-06 23:48:16 UTC (rev 188094)
@@ -163,3 +163,5 @@
 #define WebKitMockScrollbarsEnabledPreferenceKey WebKitMockScrollbarsEnabled
 
 #define WebKitEnableInheritURIQueryComponentPreferenceKey WebKitEnableInheritURIQueryComponent
+
+#define WebKitAllowDisplayAndRunningOfInsecureContentPreferenceKey WebKitAllowDisplayAndRunningOfInsecureContent


Modified: branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.cpp (188093 => 188094)

--- branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.cpp	2015-08-06 23:41:39 UTC (rev 188093)
+++ branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.cpp	2015-08-06 23:48:16 UTC (rev 188094)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2014 Apple Inc.  All rights reserved.
+ * Copyright (C) 2006-2011, 2014-2015 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -293,6 +293,8 @@
 
 CFDictionaryAddValue(defaults, CFSTR(WebKitRequestAnimationFrameEnabledPreferenceKey), kCFBooleanFalse);
 
+CFDictionaryAddValue(defaults, CFSTR(WebKitAllowDisplayAndRunningOfInsecureContentPreferenceKey), kCFBooleanTrue);
+
 defaultSettings = defaults;
 }
 
@@ -1842,3 +1844,15 @@
 setBoolValue(WebKitEnableInheritURIQueryComponentPreferenceKey, enabled);
 return S_OK;
 }
+
+HRESULT WebPreferences::allowDisplayAndRunningOfInsecureContent(BOOL* enabled)
+{
+*enabled = boolValueForKey(WebKitAllowDisplayAndRunningOfInsecureContentPreferenceKey);
+return S_OK;
+}
+
+HRESULT WebPreferences::setAllowDisplayAndRunningOfInsecureContent(BOOL enabled)
+{
+setBoolValue(WebKitAllowDisplayAndRunningOfInsecureContentPreferenceKey, enabled);
+return S_OK;
+}


Modified: branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.h (188093 => 188094)

--- branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.h	2015-08-06 23:41:39 UTC (rev 188093)
+++ branches/safari-601.1-branch/Source/WebKit/win/WebPreferences.h	2015-08-06 23:48:16

[webkit-changes] [188096] trunk/Source/WebKit2

Title: [188096] trunk/Source/WebKit2








Revision 188096
Author achristen...@apple.com
Date 2015-08-06 16:48:24 -0700 (Thu, 06 Aug 2015)


Log Message
Make CMake usable on Mac.
https://bugs.webkit.org/show_bug.cgi?id=147756

Reviewed by Tim Horton.

* PlatformMac.cmake:
DatabaseProcess_SOURCES needs something in order to not have errors when generating build systems from CMake.
This doesn't fix everything, but it can now be used to build jsc again.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188095 => 188096)

--- trunk/Source/WebKit2/ChangeLog	2015-08-06 23:48:19 UTC (rev 188095)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-06 23:48:24 UTC (rev 188096)
@@ -1,3 +1,14 @@
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
+Make CMake usable on Mac.
+https://bugs.webkit.org/show_bug.cgi?id=147756
+
+Reviewed by Tim Horton.
+
+* PlatformMac.cmake:
+DatabaseProcess_SOURCES needs something in order to not have errors when generating build systems from CMake.
+This doesn't fix everything, but it can now be used to build jsc again.
+
 2015-08-06  Enrica Casucci  enr...@apple.com
 
 Build fix for iOS after http://trac.webkit.org/changeset/188053.


Modified: trunk/Source/WebKit2/PlatformMac.cmake (188095 => 188096)

--- trunk/Source/WebKit2/PlatformMac.cmake	2015-08-06 23:48:19 UTC (rev 188095)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2015-08-06 23:48:24 UTC (rev 188096)
@@ -36,6 +36,10 @@
  ${NetworkProcess_COMMON_SOURCES}
 )
 
+list(APPEND DatabaseProcess_SOURCES
+DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm
+)
+
 add_definitions(-include WebKit2Prefix.h)
 
 set(WebKit2_FORWARDING_HEADERS_FILES






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188098] trunk/Source

Title: [188098] trunk/Source








Revision 188098
Author achristen...@apple.com
Date 2015-08-06 17:03:33 -0700 (Thu, 06 Aug 2015)


Log Message
[Win] Enable all Windows features in CMake
https://bugs.webkit.org/show_bug.cgi?id=147744

Reviewed by Tim Horton.

* PlatformWin.cmake:
Source/WebCore:

Add a file needed for enabling video.

Source/WebKit:

Add some include directories needed for the newly enabled features.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformWin.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWin.cmake
trunk/Source/cmake/OptionsWindows.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (188097 => 188098)

--- trunk/Source/WebCore/ChangeLog	2015-08-07 00:00:58 UTC (rev 188097)
+++ trunk/Source/WebCore/ChangeLog	2015-08-07 00:03:33 UTC (rev 188098)
@@ -1,3 +1,13 @@
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
+[Win] Enable all Windows features in CMake
+https://bugs.webkit.org/show_bug.cgi?id=147744
+
+Reviewed by Tim Horton.
+
+* PlatformWin.cmake:
+Add a file needed for enabling video.
+
 2015-08-06  Anders Carlsson  ander...@apple.com
 
 Rename SQLStatementBackend to SQLStatement


Modified: trunk/Source/WebCore/PlatformWin.cmake (188097 => 188098)

--- trunk/Source/WebCore/PlatformWin.cmake	2015-08-07 00:00:58 UTC (rev 188097)
+++ trunk/Source/WebCore/PlatformWin.cmake	2015-08-07 00:03:33 UTC (rev 188098)
@@ -68,6 +68,7 @@
 platform/graphics/win/IntPointWin.cpp
 platform/graphics/win/IntRectWin.cpp
 platform/graphics/win/IntSizeWin.cpp
+platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp
 platform/graphics/win/SimpleFontDataWin.cpp
 platform/graphics/win/TransformationMatrixWin.cpp
 platform/graphics/win/UniscribeController.cpp


Modified: trunk/Source/WebKit/ChangeLog (188097 => 188098)

--- trunk/Source/WebKit/ChangeLog	2015-08-07 00:00:58 UTC (rev 188097)
+++ trunk/Source/WebKit/ChangeLog	2015-08-07 00:03:33 UTC (rev 188098)
@@ -1,3 +1,13 @@
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
+[Win] Enable all Windows features in CMake
+https://bugs.webkit.org/show_bug.cgi?id=147744
+
+Reviewed by Tim Horton.
+
+* PlatformWin.cmake:
+Add some include directories needed for the newly enabled features.
+
 2015-08-05  Filip Pizlo  fpi...@apple.com
 
 Unreviewed, roll out http://trac.webkit.org/changeset/187972.


Modified: trunk/Source/WebKit/PlatformWin.cmake (188097 => 188098)

--- trunk/Source/WebKit/PlatformWin.cmake	2015-08-07 00:00:58 UTC (rev 188097)
+++ trunk/Source/WebKit/PlatformWin.cmake	2015-08-07 00:03:33 UTC (rev 188098)
@@ -48,7 +48,9 @@
 ${WEBCORE_DIR}/platform/audio
 ${WEBCORE_DIR}/platform/win
 ${WEBCORE_DIR}/rendering/line
+${WEBCORE_DIR}/rendering/shapes
 ${WEBCORE_DIR}/html/shadow
+${WEBCORE_DIR}/html/track
 ${WEBCORE_DIR}/modules/websockets
 ${DERIVED_SOURCES_WEBKIT_DIR}/Interfaces
 ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector


Modified: trunk/Source/cmake/OptionsWindows.cmake (188097 => 188098)

--- trunk/Source/cmake/OptionsWindows.cmake	2015-08-07 00:00:58 UTC (rev 188097)
+++ trunk/Source/cmake/OptionsWindows.cmake	2015-08-07 00:03:33 UTC (rev 188098)
@@ -1,17 +1,107 @@
 add_definitions(-D_HAS_EXCEPTIONS=0 -DNOMINMAX -DUNICODE)
 
-#FIXME: Make sure these are the same as the Windows feature defines once we get CMake working on Windows.
 WEBKIT_OPTION_BEGIN()
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_OVERFLOW_SCROLLING PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ALLINONE_BUILD PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ATTACHMENT_ELEMENT PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PROXY PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CHANNEL_MESSAGING PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSP_NEXT PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_CONDITIONAL_RULES PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_BOX_DECORATION_BREAK PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_COMPOSITING PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_GRID_LAYOUT PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SHADERS PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SHAPES PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SHAPE_INSIDE PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED PUBLIC ON)

[webkit-changes] [188099] trunk/Source/JavaScriptCore

Title: [188099] trunk/Source/_javascript_Core








Revision 188099
Author commit-qu...@webkit.org
Date 2015-08-06 17:21:45 -0700 (Thu, 06 Aug 2015)


Log Message
Parse the entire WebAssembly modules
https://bugs.webkit.org/show_bug.cgi?id=147393

Patch by Sukolsak Sakshuwong sukol...@gmail.com on 2015-08-06
Reviewed by Geoffrey Garen.

Parse the entire WebAssembly modules from files produced by pack-asmjs
https://github.com/WebAssembly/polyfill-prototype-1. This patch can only
parse modules whose function definition section contains only functions that
have return 0; as their only statement. Parsing of any functions will be
implemented in a subsequent patch.

* _javascript_Core.vcxproj/_javascript_Core.vcxproj:
* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters:
* _javascript_Core.xcodeproj/project.pbxproj:
* wasm/JSWASMModule.cpp:
(JSC::JSWASMModule::destroy):
* wasm/JSWASMModule.h:
(JSC::JSWASMModule::i32Constants):
(JSC::JSWASMModule::f32Constants):
(JSC::JSWASMModule::f64Constants):
(JSC::JSWASMModule::signatures):
(JSC::JSWASMModule::functionImports):
(JSC::JSWASMModule::functionImportSignatures):
(JSC::JSWASMModule::globalVariableTypes):
(JSC::JSWASMModule::functionDeclarations):
(JSC::JSWASMModule::functionPointerTables):
* wasm/WASMFormat.h: Added.
* wasm/WASMModuleParser.cpp:
(JSC::WASMModuleParser::parse):
(JSC::WASMModuleParser::parseModule):
(JSC::WASMModuleParser::parseConstantPoolSection):
(JSC::WASMModuleParser::parseSignatureSection):
(JSC::WASMModuleParser::parseFunctionImportSection):
(JSC::WASMModuleParser::parseGlobalSection):
(JSC::WASMModuleParser::parseFunctionDeclarationSection):
(JSC::WASMModuleParser::parseFunctionPointerTableSection):
(JSC::WASMModuleParser::parseFunctionDefinitionSection):
(JSC::WASMModuleParser::parseFunctionDefinition):
(JSC::WASMModuleParser::parseExportSection):
* wasm/WASMModuleParser.h:
* wasm/WASMReader.cpp:
(JSC::WASMReader::readUInt32):
(JSC::WASMReader::readCompactUInt32):
(JSC::WASMReader::readString):
(JSC::WASMReader::readType):
(JSC::WASMReader::readExpressionType):
(JSC::WASMReader::readExportFormat):
(JSC::WASMReader::readByte):
(JSC::WASMReader::readUnsignedInt32): Deleted.
* wasm/WASMReader.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/wasm/JSWASMModule.cpp
trunk/Source/_javascript_Core/wasm/JSWASMModule.h
trunk/Source/_javascript_Core/wasm/WASMModuleParser.cpp
trunk/Source/_javascript_Core/wasm/WASMModuleParser.h
trunk/Source/_javascript_Core/wasm/WASMReader.cpp
trunk/Source/_javascript_Core/wasm/WASMReader.h


Added Paths

trunk/Source/_javascript_Core/wasm/WASMFormat.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (188098 => 188099)

--- trunk/Source/_javascript_Core/ChangeLog	2015-08-07 00:03:33 UTC (rev 188098)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-08-07 00:21:45 UTC (rev 188099)
@@ -1,3 +1,56 @@
+2015-08-06  Sukolsak Sakshuwong  sukol...@gmail.com
+
+Parse the entire WebAssembly modules
+https://bugs.webkit.org/show_bug.cgi?id=147393
+
+Reviewed by Geoffrey Garen.
+
+Parse the entire WebAssembly modules from files produced by pack-asmjs
+https://github.com/WebAssembly/polyfill-prototype-1. This patch can only
+parse modules whose function definition section contains only functions that
+have return 0; as their only statement. Parsing of any functions will be
+implemented in a subsequent patch.
+
+* _javascript_Core.vcxproj/_javascript_Core.vcxproj:
+* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* wasm/JSWASMModule.cpp:
+(JSC::JSWASMModule::destroy):
+* wasm/JSWASMModule.h:
+(JSC::JSWASMModule::i32Constants):
+(JSC::JSWASMModule::f32Constants):
+(JSC::JSWASMModule::f64Constants):
+(JSC::JSWASMModule::signatures):
+(JSC::JSWASMModule::functionImports):
+(JSC::JSWASMModule::functionImportSignatures):
+(JSC::JSWASMModule::globalVariableTypes):
+(JSC::JSWASMModule::functionDeclarations):
+(JSC::JSWASMModule::functionPointerTables):
+* wasm/WASMFormat.h: Added.
+* wasm/WASMModuleParser.cpp:
+(JSC::WASMModuleParser::parse):
+(JSC::WASMModuleParser::parseModule):
+(JSC::WASMModuleParser::parseConstantPoolSection):
+(JSC::WASMModuleParser::parseSignatureSection):
+(JSC::WASMModuleParser::parseFunctionImportSection):
+(JSC::WASMModuleParser::parseGlobalSection):
+(JSC::WASMModuleParser::parseFunctionDeclarationSection):
+(JSC::WASMModuleParser::parseFunctionPointerTableSection):
+

[webkit-changes] [188103] trunk/Source/WebCore

Title: [188103] trunk/Source/WebCore








Revision 188103
Author achristen...@apple.com
Date 2015-08-06 18:29:22 -0700 (Thu, 06 Aug 2015)


Log Message
Revert part of my build fix in r188101.

* CMakeLists.txt:
MockCDM was already conditionally added to WebCore_SOURCES, and that change causes dependency cycles when bug 147723 is fixed.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (188102 => 188103)

--- trunk/Source/WebCore/CMakeLists.txt	2015-08-07 01:22:05 UTC (rev 188102)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-08-07 01:29:22 UTC (rev 188103)
@@ -3284,7 +3284,6 @@
 testing/InternalSettings.cpp
 testing/Internals.cpp
 testing/MicroTaskTest.cpp
-testing/MockCDM.cpp
 testing/MockPageOverlayClient.cpp
 
 testing/js/WebCoreTestSupport.cpp


Modified: trunk/Source/WebCore/ChangeLog (188102 => 188103)

--- trunk/Source/WebCore/ChangeLog	2015-08-07 01:22:05 UTC (rev 188102)
+++ trunk/Source/WebCore/ChangeLog	2015-08-07 01:29:22 UTC (rev 188103)
@@ -1,5 +1,12 @@
 2015-08-06  Alex Christensen  achristen...@webkit.org
 
+Revert part of my build fix in r188101.
+
+* CMakeLists.txt:
+MockCDM was already conditionally added to WebCore_SOURCES, and that change causes dependency cycles when bug 147723 is fixed.
+
+2015-08-06  Alex Christensen  achristen...@webkit.org
+
 [Win] CMake build fix after r188098.
 
 * CMakeLists.txt:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188069] branches/safari-601.1.46-branch/Source/WebCore

Title: [188069] branches/safari-601.1.46-branch/Source/WebCore








Revision 188069
Author bshaf...@apple.com
Date 2015-08-06 15:38:18 -0700 (Thu, 06 Aug 2015)


Log Message
Merged r188051.  rdar://problem/22028179

Modified Paths

branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp




Diff

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (188068 => 188069)

--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-08-06 22:37:47 UTC (rev 188068)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-08-06 22:38:18 UTC (rev 188069)
@@ -1,5 +1,23 @@
 2015-08-06  Babak Shafiei  bshaf...@apple.com
 
+Merge r188051.
+
+2015-08-06  Eric Carlson  eric.carl...@apple.com
+
+Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument
+https://bugs.webkit.org/show_bug.cgi?id=147734
+rdar://problem/22028179
+
+Reviewed by Dean Jackson.
+
+Test to follow, see https://bugs.webkit.org/show_bug.cgi?id=147735
+
+* dom/Document.cpp:
+(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Return
+  early if the Document is a MediaDocument.
+
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
 Merge r187693.
 
 2015-07-31  Myles C. Maxfield  mmaxfi...@apple.com


Modified: branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp (188068 => 188069)

--- branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp	2015-08-06 22:37:47 UTC (rev 188068)
+++ branches/safari-601.1.46-branch/Source/WebCore/dom/Document.cpp	2015-08-06 22:38:18 UTC (rev 188069)
@@ -6717,6 +6717,9 @@
 if (m_isSynthesized)
 return false;
 
+if (isMediaDocument())
+return false;
+
 bool contentDispositionAttachmentSandboxEnabled = settings()  settings()-contentDispositionAttachmentSandboxEnabled();
 bool responseIsAttachment = false;
 if (DocumentLoader* documentLoader = m_frame ? m_frame-loader().activeDocumentLoader() : nullptr)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188073] branches/safari-601.1-branch

Title: [188073] branches/safari-601.1-branch








Revision 188073
Author dburk...@apple.com
Date 2015-08-06 16:08:03 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187620. rdar://problem/15779101

Modified Paths

branches/safari-601.1-branch/LayoutTests/ChangeLog
branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/loader/DocumentLoader.cpp
branches/safari-601.1-branch/Source/WebCore/loader/DocumentLoader.h
branches/safari-601.1-branch/Source/WebCore/loader/NetscapePlugInStreamLoader.cpp
branches/safari-601.1-branch/Source/WebCore/loader/NetscapePlugInStreamLoader.h
branches/safari-601.1-branch/Source/WebCore/loader/ResourceLoader.cpp
branches/safari-601.1-branch/Source/WebCore/loader/ResourceLoader.h
branches/safari-601.1-branch/Source/WebCore/loader/SubframeLoader.cpp


Added Paths

branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt
branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect.html
branches/safari-601.1-branch/LayoutTests/http/tests/plugins/resources/redirection-response.php




Diff

Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (188072 => 188073)

--- branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 22:45:20 UTC (rev 188072)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:08:03 UTC (rev 188073)
@@ -1,3 +1,20 @@
+2015-08-06  Dana Burkart  dburk...@apple.com
+
+Merge r187620. rdar://problem/15779101
+
+2015-07-30  Anders Carlsson  ander...@apple.com
+
+Assertion failure when a plug-in loads a resource that redirects somewhere
+https://bugs.webkit.org/show_bug.cgi?id=147469
+
+Reviewed by Alexey Proskuryakov.
+
+Add a test.
+
+* http/tests/plugins/get-url-redirect-expected.txt: Added.
+* http/tests/plugins/get-url-redirect.html: Added.
+* http/tests/plugins/resources/redirection-response.php: Added.
+
 2015-08-04  Alexey Proskuryakov  a...@apple.com
 
 Merge r187933.


Added: branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt (0 => 188073)

--- branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt	2015-08-06 23:08:03 UTC (rev 188073)
@@ -0,0 +1 @@
+This tests that NPN_GetURLNotify does not ASSERT in debug builds. 


Added: branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect.html (0 => 188073)

--- branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect.html	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/http/tests/plugins/get-url-redirect.html	2015-08-06 23:08:03 UTC (rev 188073)
@@ -0,0 +1,19 @@
+html
+body
+This tests that NPN_GetURLNotify does not ASSERT in debug builds.
+embed name=plg type=application/x-webkit-test-netscape/embed
+script
+function notify()
+{
+if (window.testRunner)
+testRunner.notifyDone();
+}
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+plg.getURLNotify(resources/redirection-response.php?status=301target=load-me-1.txt, null, notify);
+/script
+/body
+/html


Added: branches/safari-601.1-branch/LayoutTests/http/tests/plugins/resources/redirection-response.php (0 => 188073)

--- branches/safari-601.1-branch/LayoutTests/http/tests/plugins/resources/redirection-response.php	(rev 0)
+++ branches/safari-601.1-branch/LayoutTests/http/tests/plugins/resources/redirection-response.php	2015-08-06 23:08:03 UTC (rev 188073)
@@ -0,0 +1,31 @@
+?php
+$status_code = $_GET['status'];
+
+$uri = rtrim(dirname($_SERVER['PHP_SELF']), '/\\') . / . $_GET['target'];
+
+$host = $_SERVER['HTTP_HOST'];
+if (isset($_GET['host']))
+$host = $_GET['host'];
+
+switch ($status_code) {
+case 301:
+header(HTTP/1.1 301 Moved Permanently);
+header(Location: http:// . $host . $uri);
+break;
+case 302:
+header(HTTP/1.1 302 Found);
+header(Location: http:// . $host . $uri);
+break;
+case 303:
+header(HTTP/1.1 303 See Other);
+header(Location: http:// . $host . $uri);
+break;
+case 307:
+header(HTTP/1.1 307 Temporary Redirect);
+header(Location: http:// . $host . $uri);
+break;
+default:
+header(HTTP/1.1 500 Internal Server Error);
+echo Unexpected status code ($status_code) received.;
+}
+?


Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188072 => 188073)

--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 22:45:20 UTC (rev 188072)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:08:03 UTC (rev 188073)
@@ -1,3 +1,44 @@
+2015-08-06  Dana Burkart  dburk...@apple.com
+
+

[webkit-changes] [188081] trunk/Source/WebCore

Title: [188081] trunk/Source/WebCore








Revision 188081
Author ander...@apple.com
Date 2015-08-06 16:21:04 -0700 (Thu, 06 Aug 2015)


Log Message
Merge SQLStatement into SQLStatementBackend
https://bugs.webkit.org/show_bug.cgi?id=147754

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* Modules/webdatabase/Database.h:
* Modules/webdatabase/SQLStatement.cpp: Removed.
(WebCore::SQLStatement::SQLStatement): Deleted.
(WebCore::SQLStatement::setBackend): Deleted.
(WebCore::SQLStatement::hasCallback): Deleted.
(WebCore::SQLStatement::hasErrorCallback): Deleted.
(WebCore::SQLStatement::performCallback): Deleted.
* Modules/webdatabase/SQLStatement.h: Removed.
* Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::performCallback):
(WebCore::SQLStatementBackend::frontend): Deleted.
* Modules/webdatabase/SQLStatementBackend.h:
(WebCore::SQLStatementBackend::hasStatementCallback):
(WebCore::SQLStatementBackend::hasStatementErrorCallback):
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::executeSQL):
* Modules/webdatabase/SQLTransaction.h:
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::executeSQL):
* Modules/webdatabase/SQLTransactionBackend.h:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSQLTransactionCustom.cpp:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/Database.h
trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLStatementBackend.h
trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.h
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSSQLTransactionCustom.cpp


Removed Paths

trunk/Source/WebCore/Modules/webdatabase/SQLStatement.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLStatement.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (188080 => 188081)

--- trunk/Source/WebCore/CMakeLists.txt	2015-08-06 23:15:24 UTC (rev 188080)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-08-06 23:21:04 UTC (rev 188081)
@@ -1013,7 +1013,6 @@
 Modules/webdatabase/SQLException.cpp
 Modules/webdatabase/SQLResultSet.cpp
 Modules/webdatabase/SQLResultSetRowList.cpp
-Modules/webdatabase/SQLStatement.cpp
 Modules/webdatabase/SQLStatementBackend.cpp
 Modules/webdatabase/SQLTransaction.cpp
 Modules/webdatabase/SQLTransactionBackend.cpp


Modified: trunk/Source/WebCore/ChangeLog (188080 => 188081)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 23:15:24 UTC (rev 188080)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 23:21:04 UTC (rev 188081)
@@ -1,3 +1,39 @@
+2015-08-06  Anders Carlsson  ander...@apple.com
+
+Merge SQLStatement into SQLStatementBackend
+https://bugs.webkit.org/show_bug.cgi?id=147754
+
+Reviewed by Geoffrey Garen.
+
+* CMakeLists.txt:
+* Modules/webdatabase/Database.h:
+* Modules/webdatabase/SQLStatement.cpp: Removed.
+(WebCore::SQLStatement::SQLStatement): Deleted.
+(WebCore::SQLStatement::setBackend): Deleted.
+(WebCore::SQLStatement::hasCallback): Deleted.
+(WebCore::SQLStatement::hasErrorCallback): Deleted.
+(WebCore::SQLStatement::performCallback): Deleted.
+* Modules/webdatabase/SQLStatement.h: Removed.
+* Modules/webdatabase/SQLStatementBackend.cpp:
+(WebCore::SQLStatementBackend::SQLStatementBackend):
+(WebCore::SQLStatementBackend::performCallback):
+(WebCore::SQLStatementBackend::frontend): Deleted.
+* Modules/webdatabase/SQLStatementBackend.h:
+(WebCore::SQLStatementBackend::hasStatementCallback):
+(WebCore::SQLStatementBackend::hasStatementErrorCallback):
+* Modules/webdatabase/SQLTransaction.cpp:
+(WebCore::SQLTransaction::deliverStatementCallback):
+(WebCore::SQLTransaction::executeSQL):
+* Modules/webdatabase/SQLTransaction.h:
+* Modules/webdatabase/SQLTransactionBackend.cpp:
+(WebCore::SQLTransactionBackend::currentStatement):
+(WebCore::SQLTransactionBackend::executeSQL):
+* Modules/webdatabase/SQLTransactionBackend.h:
+* WebCore.vcxproj/WebCore.vcxproj:
+* WebCore.vcxproj/WebCore.vcxproj.filters:
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/js/JSSQLTransactionCustom.cpp:
+
 2015-08-06  Chris Dumez  cdu...@apple.com

[webkit-changes] [188092] trunk/Tools

2015-08-06 Thread rniwa

Title: [188092] trunk/Tools








Revision 188092
Author rn...@webkit.org
Date 2015-08-06 16:40:49 -0700 (Thu, 06 Aug 2015)


Log Message
http_server_driver and benchmark_builder should not be in run-benchmark's plan files
https://bugs.webkit.org/show_bug.cgi?id=147752

Reviewed by Chris Dumez.

Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.

Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.

* Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
* Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
* Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
* Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
* Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
HTTPServerDriverFactory taking the platform name as an argument.
(BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
* Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
(http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
(HTTPServerDriver): Replaced name by platforms.
* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver): Ditto.
* Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(parse_args): Removed --http-server-driver option.
(start): Ditto.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/octane.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py


Added Paths

trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py


Removed Paths

trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/




Diff

Modified: trunk/Tools/ChangeLog (188091 => 188092)

--- trunk/Tools/ChangeLog	2015-08-06 23:35:32 UTC (rev 188091)
+++ trunk/Tools/ChangeLog	2015-08-06 23:40:49 UTC (rev 188092)
@@ -1,3 +1,43 @@
+2015-08-06  Ryosuke Niwa  rn...@webkit.org
+
+http_server_driver and benchmark_builder should not be in run-benchmark's plan files
+https://bugs.webkit.org/show_bug.cgi?id=147752
+
+Reviewed by Chris Dumez.
+
+Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
+
+Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
+This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
+
+* Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
+* Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
+*

[webkit-changes] [188093] trunk/Websites/webkit.org

Title: [188093] trunk/Websites/webkit.org








Revision 188093
Author bfulg...@apple.com
Date 2015-08-06 16:41:39 -0700 (Thu, 06 Aug 2015)


Log Message
Correct a typo in the explanatory text.

* demos/backdrop-filter/index.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/demos/backdrop-filter/index.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (188092 => 188093)

--- trunk/Websites/webkit.org/ChangeLog	2015-08-06 23:40:49 UTC (rev 188092)
+++ trunk/Websites/webkit.org/ChangeLog	2015-08-06 23:41:39 UTC (rev 188093)
@@ -1,5 +1,11 @@
 2015-08-06  Brent Fulgham  bfulg...@apple.com
 
+Correct a typo in the explanatory text.
+
+* demos/backdrop-filter/index.html:
+
+2015-08-06  Brent Fulgham  bfulg...@apple.com
+
 Add an example of backdrop-filter.
 
 * demos/backdrop-filter: Added.


Modified: trunk/Websites/webkit.org/demos/backdrop-filter/index.html (188092 => 188093)

--- trunk/Websites/webkit.org/demos/backdrop-filter/index.html	2015-08-06 23:40:49 UTC (rev 188092)
+++ trunk/Websites/webkit.org/demos/backdrop-filter/index.html	2015-08-06 23:41:39 UTC (rev 188093)
@@ -85,7 +85,7 @@
 
 p
 The following are a series of image (codeimg/code) elements, each with a codediv/code positioned
-on top. Each of these codediv/code's are styled using a different type of backdrop filter.
+on top. Each of these codediv/codes is styled using a different type of backdrop filter.
 /p
 
 h2






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188104] trunk/Source/WebCore

Title: [188104] trunk/Source/WebCore








Revision 188104
Author mmaxfi...@apple.com
Date 2015-08-06 18:36:03 -0700 (Thu, 06 Aug 2015)


Log Message
[iOS] Remove dead code from FontCache::createFontPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=147762

Reviewed by Andy Estes.

No new tests because there is no behavior change.

* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::createFontPlatformData): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (188103 => 188104)

--- trunk/Source/WebCore/ChangeLog	2015-08-07 01:29:22 UTC (rev 188103)
+++ trunk/Source/WebCore/ChangeLog	2015-08-07 01:36:03 UTC (rev 188104)
@@ -1,3 +1,15 @@
+2015-08-06  Myles C. Maxfield  mmaxfi...@apple.com
+
+[iOS] Remove dead code from FontCache::createFontPlatformData()
+https://bugs.webkit.org/show_bug.cgi?id=147762
+
+Reviewed by Andy Estes.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/ios/FontCacheIOS.mm:
+(WebCore::FontCache::createFontPlatformData): Deleted.
+
 2015-08-06  Alex Christensen  achristen...@webkit.org
 
 Revert part of my build fix in r188101.


Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (188103 => 188104)

--- trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2015-08-07 01:29:22 UTC (rev 188103)
+++ trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2015-08-07 01:36:03 UTC (rev 188104)
@@ -677,13 +677,6 @@
 
 std::unique_ptrFontPlatformData FontCache::createFontPlatformData(const FontDescription fontDescription, const AtomicString family)
 {
-// Special case for Courier font. We used to have only an oblique variant on iOS, so prior to
-// iOS 6.0, we disallowed its use here. We'll fall back on Courier New. rdar://problem/511647710850227
-static NeverDestroyedAtomicString courier(Courier, AtomicString::ConstructFromLiteral);
-static bool shouldDisallowCourier = !iosExecutableWasLinkedOnOrAfterVersion(wkIOSSystemVersion_6_0);
-if (shouldDisallowCourier  equalIgnoringCase(family, courier))
-return nullptr;
-
 CTFontSymbolicTraits traits = 0;
 if (fontDescription.italic())
 traits |= kCTFontTraitItalic;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188075] branches/safari-601.1-branch/Source/WebCore

Title: [188075] branches/safari-601.1-branch/Source/WebCore








Revision 188075
Author dburk...@apple.com
Date 2015-08-06 16:08:48 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187693. rdar://problem/22047626

Modified Paths

branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp




Diff

Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188074 => 188075)

--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:08:46 UTC (rev 188074)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:08:48 UTC (rev 188075)
@@ -1,5 +1,24 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187693. rdar://problem/22047626
+
+2015-07-31  Myles C. Maxfield  mmaxfi...@apple.com
+
+[Cocoa] Latin quotes are used with the system font on Chinese devices
+https://bugs.webkit.org/show_bug.cgi?id=147504
+
+Reviewed by Dean Jackson.
+
+The system font has some fancy logic regarding character selection which requires
+using Core Text for glyph selection.
+
+No new tests because tests can't change the system language of the device.
+
+* platform/graphics/mac/GlyphPageMac.cpp:
+(WebCore::shouldUseCoreText):
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187622. rdar://problem/15779101
 
 2015-07-30  Anders Carlsson  ander...@apple.com


Modified: branches/safari-601.1-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp (188074 => 188075)

--- branches/safari-601.1-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp	2015-08-06 23:08:46 UTC (rev 188074)
+++ branches/safari-601.1-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp	2015-08-06 23:08:48 UTC (rev 188075)
@@ -42,7 +42,7 @@
 
 static bool shouldUseCoreText(const UChar* buffer, unsigned bufferLength, const Font* fontData)
 {
-if (fontData-platformData().isCompositeFontReference())
+if (fontData-platformData().isCompositeFontReference() || fontData-isSystemFont())
 return true;
 if (fontData-platformData().widthVariant() != RegularWidth || fontData-hasVerticalGlyphs()) {
 // Ideographs don't have a vertical variant or width variants.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188074] branches/safari-601.1-branch

Title: [188074] branches/safari-601.1-branch








Revision 188074
Author dburk...@apple.com
Date 2015-08-06 16:08:46 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187622. rdar://problem/15779101

Modified Paths

branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/loader/SubframeLoader.cpp
branches/safari-601.1-branch/Tools/MiniBrowser/mac/WK1BrowserWindowController.m




Diff

Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188073 => 188074)

--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:08:03 UTC (rev 188073)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:08:46 UTC (rev 188074)
@@ -1,5 +1,16 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187622. rdar://problem/15779101
+
+2015-07-30  Anders Carlsson  ander...@apple.com
+
+Remove stray printf.
+
+* loader/SubframeLoader.cpp:
+(WebCore::SubframeLoader::requestObject):
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187620. rdar://problem/15779101
 
 2015-07-30  Anders Carlsson  ander...@apple.com


Modified: branches/safari-601.1-branch/Source/WebCore/loader/SubframeLoader.cpp (188073 => 188074)

--- branches/safari-601.1-branch/Source/WebCore/loader/SubframeLoader.cpp	2015-08-06 23:08:03 UTC (rev 188073)
+++ branches/safari-601.1-branch/Source/WebCore/loader/SubframeLoader.cpp	2015-08-06 23:08:46 UTC (rev 188074)
@@ -212,7 +212,6 @@
 
 bool SubframeLoader::requestObject(HTMLPlugInImageElement ownerElement, const String url, const AtomicString frameName, const String mimeType, const VectorString paramNames, const VectorString paramValues)
 {
-printf(request oject url %s mime type %s\n, url.ascii().data(), mimeType.ascii().data());
 if (url.isEmpty()  mimeType.isEmpty())
 return false;
 


Modified: branches/safari-601.1-branch/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (188073 => 188074)

--- branches/safari-601.1-branch/Tools/MiniBrowser/mac/WK1BrowserWindowController.m	2015-08-06 23:08:03 UTC (rev 188073)
+++ branches/safari-601.1-branch/Tools/MiniBrowser/mac/WK1BrowserWindowController.m	2015-08-06 23:08:46 UTC (rev 188074)
@@ -52,6 +52,7 @@
 [[WebPreferences standardPreferences] setDeveloperExtrasEnabled:YES];
 [[WebPreferences standardPreferences] setImageControlsEnabled:YES];
 [[WebPreferences standardPreferences] setServiceControlsEnabled:YES];
+[[WebPreferences standardPreferences] setJavaScriptCanOpenWindowsAutomatically:YES];
 
 [_webView _listenForLayoutMilestones:WebDidFirstLayout | WebDidFirstVisuallyNonEmptyLayout | WebDidHitRelevantRepaintedObjectsAreaThreshold];
 
@@ -87,7 +88,7 @@
 - (IBAction)showHideWebView:(id)sender
 {
 BOOL hidden = ![_webView isHidden];
-
+
 [_webView setHidden:hidden];
 }
 
@@ -95,7 +96,7 @@
 {
 if ([_webView window]) {
 [_webView retain];
-[_webView removeFromSuperview]; 
+[_webView removeFromSuperview];
 } else {
 [containerView addSubview:_webView];
 [_webView release];
@@ -104,7 +105,7 @@
 
 - (IBAction)setScale:(id)sender
 {
-
+
 }
 
 - (IBAction)reload:(id)sender
@@ -154,10 +155,10 @@
 
 if (action == @selector(goBack:))
 return [_webView canGoBack];
-
+
 if (action == @selector(goForward:))
 return [_webView canGoForward];
-
+
 return YES;
 }
 
@@ -302,6 +303,14 @@
 {
 }
 
+- (WebView *)webView:(WebView *)sender createWebViewWithRequest:(NSURLRequest *)request
+{
+WK1BrowserWindowController *newBrowserWindowController = [[WK1BrowserWindowController alloc] initWithWindowNibName:@BrowserWindow];
+[newBrowserWindowController.window makeKeyAndOrderFront:self];
+
+return newBrowserWindowController-_webView;
+}
+
 - (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame
 {
 if (frame != [sender mainFrame])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188077] branches/safari-601.1-branch/Source/WebCore

Title: [188077] branches/safari-601.1-branch/Source/WebCore








Revision 188077
Author dburk...@apple.com
Date 2015-08-06 16:09:42 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187892. rdar://problem/21932187

Modified Paths

branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
branches/safari-601.1-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-601.1-branch/Source/WebCore/html/MediaElementSession.cpp




Diff

Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188076 => 188077)

--- branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:09:38 UTC (rev 188076)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog	2015-08-06 23:09:42 UTC (rev 188077)
@@ -1,5 +1,28 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187892. rdar://problem/21932187
+
+2015-08-04  Eric Carlson  eric.carl...@apple.com
+
+[Mac] Do not require a video track for AirPlay
+https://bugs.webkit.org/show_bug.cgi?id=147647
+
+Reviewed by Jer Noble.
+
+* Modules/mediacontrols/mediaControlsApple.js:
+(Controller.prototype.handleReadyStateChange): Call updateWirelessTargetAvailable().
+(Controller.prototype.updateHasVideo): Don't call updateWirelessTargetAvailable().
+(Controller.prototype.updateWirelessTargetAvailable): Don't require video.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::setReadyState): Call updateMediaState when we reach HAVE_METADATA.
+(WebCore::HTMLMediaElement::mediaState): Don't require video, only that the file can play.
+
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::showPlaybackTargetPicker): Check readyState instead of hasVideo.
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187886. rdar://problem/15779101
 
 2015-08-04  Alexey Proskuryakov  a...@apple.com


Modified: branches/safari-601.1-branch/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (188076 => 188077)

--- branches/safari-601.1-branch/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-08-06 23:09:38 UTC (rev 188076)
+++ branches/safari-601.1-branch/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-08-06 23:09:42 UTC (rev 188077)
@@ -688,6 +688,7 @@
 this.updateCaptionButton();
 this.updateCaptionContainer();
 this.updateFullscreenButtons();
+this.updateWirelessTargetAvailable();
 this.updateWirelessTargetPickerButton();
 this.updateProgress();
 this.updateControls();
@@ -1866,9 +1867,6 @@
 this.controls.panel.classList.remove(this.ClassNames.noVideo);
 else
 this.controls.panel.classList.add(this.ClassNames.noVideo);
-
-// The wireless target picker is only visible for files with video, force an update.
-this.updateWirelessTargetAvailable();
 },
 
 updateVolume: function()
@@ -1982,7 +1980,7 @@
 if (this.wirelessPlaybackDisabled)
 wirelessPlaybackTargetsAvailable = false;
 
-if (wirelessPlaybackTargetsAvailable  this.isPlayable()  this.hasVideo())
+if (wirelessPlaybackTargetsAvailable  this.isPlayable())
 this.controls.wirelessTargetPicker.classList.remove(this.ClassNames.hidden);
 else
 this.controls.wirelessTargetPicker.classList.add(this.ClassNames.hidden);


Modified: branches/safari-601.1-branch/Source/WebCore/html/HTMLMediaElement.cpp (188076 => 188077)

--- branches/safari-601.1-branch/Source/WebCore/html/HTMLMediaElement.cpp	2015-08-06 23:09:38 UTC (rev 188076)
+++ branches/safari-601.1-branch/Source/WebCore/html/HTMLMediaElement.cpp	2015-08-06 23:09:42 UTC (rev 188077)
@@ -2119,6 +2119,10 @@
 downcastMediaDocument(document()).mediaElementNaturalSizeChanged(expandedIntSize(m_player-naturalSize()));
 
 logMediaLoadRequest(document().page(), m_player-engineDescription(), String(), true);
+
+#if ENABLE(WIRELESS_PLAYBACK_TARGET)
+updateMediaState(UpdateMediaState::Asynchronously);
+#endif
 }
 
 bool shouldUpdateDisplayState = false;
@@ -6422,7 +6426,7 @@
 state |= RequiresPlaybackTargetMonitoring;
 
 bool requireUserGesture = m_mediaSession-hasBehaviorRestriction(MediaElementSession::RequireUserGestureToAutoplayToExternalDevice);
-if (hasActiveVideo  !requireUserGesture  !m_failedToPlayToWirelessTarget)
+if (m_readyState = HAVE_METADATA  !requireUserGesture  !m_failedToPlayToWirelessTarget)
 state |= ExternalDeviceAutoPlayCandidate;
 
 if (hasActiveVideo  endedPlayback())


Modified: branches/safari-601.1-branch/Source/WebCore/html/MediaElementSession.cpp (188076 => 188077)

--- branches/safari-601.1-branch/Source/WebCore/html/MediaElementSession.cpp	2015-08-06 23:09:38 UTC (rev 188076)
+++

[webkit-changes] [188080] trunk/Websites/webkit.org

Title: [188080] trunk/Websites/webkit.org








Revision 188080
Author bfulg...@apple.com
Date 2015-08-06 16:15:24 -0700 (Thu, 06 Aug 2015)


Log Message
Add a poster image for the video.

* blog-files/backdrop-filters/dynamic_poster.jpg: Added.

Modified Paths

trunk/Websites/webkit.org/ChangeLog


Added Paths

trunk/Websites/webkit.org/blog-files/backdrop-filters/dynamic_poster.jpg




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (188079 => 188080)

--- trunk/Websites/webkit.org/ChangeLog	2015-08-06 23:09:45 UTC (rev 188079)
+++ trunk/Websites/webkit.org/ChangeLog	2015-08-06 23:15:24 UTC (rev 188080)
@@ -1,5 +1,11 @@
 2015-08-06  Brent Fulgham  bfulg...@apple.com
 
+Add a poster image for the video.
+
+* blog-files/backdrop-filters/dynamic_poster.jpg: Added.
+
+2015-08-06  Brent Fulgham  bfulg...@apple.com
+
 Add more media control examples.
 
 * blog-files/backdrop-filters/dynamic_backdrop.m4v: Added.


Added: trunk/Websites/webkit.org/blog-files/backdrop-filters/dynamic_poster.jpg

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/blog-files/backdrop-filters/dynamic_poster.jpg
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188085] trunk

Title: [188085] trunk








Revision 188085
Author commit-qu...@webkit.org
Date 2015-08-06 16:23:56 -0700 (Thu, 06 Aug 2015)


Log Message
Source/_javascript_Core:
The JSONP parser incorrectly parsers -0 as +0.
https://bugs.webkit.org/show_bug.cgi?id=147590

Patch by Keith Miller keith_mil...@apple.com on 2015-08-06
Reviewed by Michael Saboff.

In the LiteralParser we should use a double to store the accumulator for numerical tokens
rather than an int. Using an int means that -0 is, incorrectly, parsed as +0.

* runtime/LiteralParser.cpp:
(JSC::LiteralParserCharType::Lexer::lexNumber):

LayoutTests:
The JSONP parser incorrectly parses -0 as +0.
https://bugs.webkit.org/show_bug.cgi?id=147590

Patch by Keith Miller keith_mil...@apple.com on 2015-08-06
Reviewed by Michael Saboff.

A simple test that attempts loads a JSONP that sets a variable to 0.

* js/regress/JSONP-negative-0-expected.txt: Added.
* js/regress/JSONP-negative-0.html: Added.
* js/regress/script-tests/JSONP-negative-0.js: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/LiteralParser.cpp


Added Paths

trunk/LayoutTests/js/regress/JSONP-negative-0-expected.txt
trunk/LayoutTests/js/regress/JSONP-negative-0.html
trunk/LayoutTests/js/regress/script-tests/JSONP-negative-0.js




Diff

Modified: trunk/LayoutTests/ChangeLog (188084 => 188085)

--- trunk/LayoutTests/ChangeLog	2015-08-06 23:22:43 UTC (rev 188084)
+++ trunk/LayoutTests/ChangeLog	2015-08-06 23:23:56 UTC (rev 188085)
@@ -1,3 +1,16 @@
+2015-08-06  Keith Miller  keith_mil...@apple.com
+
+The JSONP parser incorrectly parses -0 as +0.
+https://bugs.webkit.org/show_bug.cgi?id=147590
+
+Reviewed by Michael Saboff.
+
+A simple test that attempts loads a JSONP that sets a variable to 0.
+
+* js/regress/JSONP-negative-0-expected.txt: Added.
+* js/regress/JSONP-negative-0.html: Added.
+* js/regress/script-tests/JSONP-negative-0.js: Added.
+
 2015-08-06  Chris Dumez  cdu...@apple.com
 
 Toggle GPS state based on page visibility to save battery


Added: trunk/LayoutTests/js/regress/JSONP-negative-0-expected.txt (0 => 188085)

--- trunk/LayoutTests/js/regress/JSONP-negative-0-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/regress/JSONP-negative-0-expected.txt	2015-08-06 23:23:56 UTC (rev 188085)
@@ -0,0 +1,11 @@
+JSRegress/JSONP-negative-0
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS Object.is(-0,x) is true
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/js/regress/JSONP-negative-0.html (0 => 188085)

--- trunk/LayoutTests/js/regress/JSONP-negative-0.html	(rev 0)
+++ trunk/LayoutTests/js/regress/JSONP-negative-0.html	2015-08-06 23:23:56 UTC (rev 188085)
@@ -0,0 +1,15 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+script src=""
+script src=""
+script
+shouldBeTrue(Object.is(-0,x));
+/script
+script src=""
+script src=""
+/body
+/html


Added: trunk/LayoutTests/js/regress/script-tests/JSONP-negative-0.js (0 => 188085)

--- trunk/LayoutTests/js/regress/script-tests/JSONP-negative-0.js	(rev 0)
+++ trunk/LayoutTests/js/regress/script-tests/JSONP-negative-0.js	2015-08-06 23:23:56 UTC (rev 188085)
@@ -0,0 +1 @@
+x = -0


Modified: trunk/Source/_javascript_Core/ChangeLog (188084 => 188085)

--- trunk/Source/_javascript_Core/ChangeLog	2015-08-06 23:22:43 UTC (rev 188084)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-08-06 23:23:56 UTC (rev 188085)
@@ -1,3 +1,16 @@
+2015-08-06  Keith Miller  keith_mil...@apple.com
+
+The JSONP parser incorrectly parsers -0 as +0.
+https://bugs.webkit.org/show_bug.cgi?id=147590
+
+Reviewed by Michael Saboff.
+
+In the LiteralParser we should use a double to store the accumulator for numerical tokens
+rather than an int. Using an int means that -0 is, incorrectly, parsed as +0.
+
+* runtime/LiteralParser.cpp:
+(JSC::LiteralParserCharType::Lexer::lexNumber):
+
 2015-08-06  Filip Pizlo  fpi...@apple.com
 
 Structures used for tryGetConstantProperty() should be registered first


Modified: trunk/Source/_javascript_Core/runtime/LiteralParser.cpp (188084 => 188085)

--- trunk/Source/_javascript_Core/runtime/LiteralParser.cpp	2015-08-06 23:22:43 UTC (rev 188084)
+++ trunk/Source/_javascript_Core/runtime/LiteralParser.cpp	2015-08-06 23:23:56 UTC (rev 188085)
@@ -497,7 +497,7 @@
 while (m_ptr  m_end  isASCIIDigit(*m_ptr))
 ++m_ptr;
 } else if (m_ptr  m_end  (*m_ptr != 'e'  *m_ptr != 'E')  (m_ptr - token.start)  10) {
-int result = 0;
+double result = 0;
 token.type = TokNumber;
 token.end = m_ptr;
 const CharType* digit = token.start;






___

[webkit-changes] [188084] branches/safari-601.1-branch/LayoutTests

Title: [188084] branches/safari-601.1-branch/LayoutTests








Revision 188084
Author dburk...@apple.com
Date 2015-08-06 16:22:43 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r187964. rdar://problem/21870332

Modified Paths

branches/safari-601.1-branch/LayoutTests/ChangeLog
branches/safari-601.1-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html




Diff

Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (188083 => 188084)

--- branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:22:41 UTC (rev 188083)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog	2015-08-06 23:22:43 UTC (rev 188084)
@@ -1,5 +1,19 @@
 2015-08-06  Dana Burkart  dburk...@apple.com
 
+Merge r187964. rdar://problem/21870332
+
+2015-08-05  Brent Fulgham  bfulg...@apple.com
+
+Unreviewed test gardening.
+
+Skip new latched scrolling test on WK1 due to timeout. Check in some minor clean-ups in
+the test based on feedback from Antti and others:
+
+* platform/mac/TestExpectations:
+* platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html:
+
+2015-08-06  Dana Burkart  dburk...@apple.com
+
 Merge r187935. rdar://problem/22097682
 
 2015-08-04  Doug Russell  d_russ...@apple.com


Modified: branches/safari-601.1-branch/LayoutTests/platform/mac/TestExpectations (188083 => 188084)

--- branches/safari-601.1-branch/LayoutTests/platform/mac/TestExpectations	2015-08-06 23:22:41 UTC (rev 188083)
+++ branches/safari-601.1-branch/LayoutTests/platform/mac/TestExpectations	2015-08-06 23:22:43 UTC (rev 188084)
@@ -1360,3 +1360,6 @@
 [ ElCapitan+ ] canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html [ Pass Failure ]
 [ ElCapitan+ ] canvas/philip/tests/2d.composite.uncovered.fill.source-out.html [ Pass Failure ]
 [ ElCapitan+ ] canvas/philip/tests/2d.composite.uncovered.fill.source-in.html [ Pass Failure ]
+
+# WK1-only timeout.
+fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html [ Skip ]


Modified: branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html (188083 => 188084)

--- branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html	2015-08-06 23:22:41 UTC (rev 188083)
+++ branches/safari-601.1-branch/LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html	2015-08-06 23:22:43 UTC (rev 188084)
@@ -11,8 +11,6 @@
 var pageScrollPositionBefore;
 var divScrollPositionBefore;
 
-var continueCount = 5;
-
 function locationInWindowCoordinates(element)
 {
 var position = {};
@@ -37,7 +35,8 @@
 testRunner.notifyDone();
 }
 
-function checkForScroll() {
+function checkForScroll()
+{
 var pageScrollPositionAfter = document.body.scrollTop;
 var divScrollPositionAfter = divTarget.scrollTop;
 
@@ -54,7 +53,8 @@
 finishTest();
 }
 
-function scrollTest() {
+function scrollTest()
+{
 pageScrollPositionBefore = document.body.scrollTop;
 
 divTarget = document.getElementById('scrollable_div');
@@ -66,8 +66,7 @@
 
 divScrollPositionBefore = divTarget.scrollTop;
 
-// Scroll the #source until we reach the #target.
-eventSender.mouseMoveTo(startPosX, startPosY); // Make sure we are just outside the iFrame
+eventSender.mouseMoveTo(startPosX, startPosY);
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'began', 'none', true);
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'changed', 'none', true);
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'changed', 'none', true);
@@ -81,9 +80,10 @@
 eventSender.callAfterScrollingCompletes(checkForScroll);
 }
 
-function setupTopLevel() {
-
+function setupTopLevel()
+{
 if (window.eventSender) {
+jsTestIsAsync = true;
 testRunner.waitUntilDone();
 
 eventSender.monitorWheelEvents();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188100] trunk

2015-08-06 Thread fpizlo

Title: [188100] trunk

Revision 188100
Author fpi...@apple.com
Date 2015-08-06 17:49:54 -0700 (Thu, 06 Aug 2015)

Log Message
Lightweight locks should be adaptive
https://bugs.webkit.org/show_bug.cgi?id=147545

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

* heap/CopiedBlock.h:
(JSC::CopiedBlock::workListLock):
* heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::shouldReportLiveBytes):
(JSC::CopiedBlock::reportLiveBytes):
* heap/CopiedSpace.h:
(JSC::CopiedSpace::CopiedGeneration::CopiedGeneration):
* heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::recycleEvacuatedBlock):
* heap/GCThreadSharedData.h:
(JSC::GCThreadSharedData::getNextBlocksToCopy):
* heap/ListableHandler.h:
(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::addNotThreadSafe):
* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::copyLater):
* runtime/TypeProfilerLog.h:

Source/WebCore:

No new tests because no new behavior.

* bindings/objc/WebScriptObject.mm:
(WebCore::getJSWrapper):
(WebCore::addJSWrapper):
(WebCore::removeJSWrapper):
(WebCore::removeJSWrapperIfRetainCountOne):
* platform/ios/wak/WAKWindow.mm:
(-[WAKWindow setExposedScrollViewRect:]):
(-[WAKWindow exposedScrollViewRect]):

Source/WebKit2:

* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::clearQueuedTouchEventsForPage):
(WebKit::EventDispatcher::getQueuedTouchEventsForPage):
(WebKit::EventDispatcher::touchEvent):
(WebKit::EventDispatcher::dispatchTouchEvents):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):
* WebProcess/WebPage/ViewUpdateDispatcher.h:

Source/WTF:

A common idiom in WebKit is to use spinlocks. We use them because the lock acquisition
overhead is lower than system locks and because they take dramatically less space than system
locks. The speed and space advantages of spinlocks can be astonishing: an uncontended spinlock
acquire is up to 10x faster and under microcontention - short critical section with two or
more threads taking turns - spinlocks are up to 100x faster. Spinlocks take only 1 byte or 4
bytes depending on the flavor, while system locks take 64 bytes or more. Clearly, WebKit
should continue to avoid system locks - they are just far too slow and far too big.

But there is a problem with this idiom. System lock implementations will sleep a thread when
it attempts to acquire a lock that is held, while spinlocks will cause the thread to burn CPU.
In WebKit spinlocks, the thread will repeatedly call sched_yield(). This is awesome for
microcontention, but awful when the lock will not be released for a while. In fact, when
critical sections take tens of microseconds or more, the CPU time cost of our spinlocks is
almost 100x more than the CPU time cost of a system lock. This case doesn't arise too
frequently in our current uses of spinlocks, but that's probably because right now there are
places where we make a conscious decision to use system locks - even though they use more
memory and are slower - because we don't want to waste CPU cycles when a thread has to wait a
while to acquire the lock.

The solution is to just implement a modern adaptive mutex in WTF. Luckily, this isn't a new
concept. This patch implements a mutex that is reminiscent of the kinds of low-overhead locks
that JVMs use. The actual implementation here is inspired by some of the ideas from [1]. The
idea is simple: the fast path is an inlined CAS to immediately acquire a lock that isn't held,
the slow path tries some number of spins to acquire the lock, and if that fails, the thread is
put on a queue and put to sleep. The queue is made up of statically allocated thread nodes and
the lock itself is a tagged pointer: either it is just bits telling us the complete lock state
(not held or held) or it is a pointer to the head of a queue of threads waiting to acquire the
lock. This approach gives WTF::Lock three different levels of adaptation: an inlined fast path
if the lock is not contended, a short burst of spinning for microcontention, and a full-blown
queue for critical sections that are held for a long time.

On a locking microbenchmark, this new Lock exhibits the following performance
characteristics:

- Lock+unlock on an uncontended no-op critical section: 2x slower than SpinLock and 3x faster
than a system mutex.

- Lock+unlock on a contended no-op critical section: 2x slower than SpinLock and 100x faster
than a system mutex.

- CPU time spent in lock() on a lock held for a while: same as system mutex, 90x less than a
SpinLock.

- Memory usage: sizeof(void*), so on 64-bit it's 8x less than a system mutex but 2x worse than
a SpinLock.

This patch replaces all uses of SpinLock with Lock, since our critical sections are not
no-ops so if you do basically anything in your critical section, the Lock overhead will be
invisible. Also, in all places where we used SpinLock,

[webkit-changes] [188102] trunk/Tools

2015-08-06 Thread joepeck

Title: [188102] trunk/Tools








Revision 188102
Author joep...@webkit.org
Date 2015-08-06 18:22:05 -0700 (Thu, 06 Aug 2015)


Log Message
Running tests for a long time results in some tests running very slowly (throttling)
https://bugs.webkit.org/show_bug.cgi?id=147718

Reviewed by Alexey Proskuryakov.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Ensure throttling settings are disabled for tests for all ports, as
COCOA ports default to having these setting enabled. Note, there is
still other timer throttling not covered by these setting.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Tools/ChangeLog (188101 => 188102)

--- trunk/Tools/ChangeLog	2015-08-07 01:03:54 UTC (rev 188101)
+++ trunk/Tools/ChangeLog	2015-08-07 01:22:05 UTC (rev 188102)
@@ -1,3 +1,16 @@
+2015-08-06  Joseph Pecoraro  pecor...@apple.com
+
+Running tests for a long time results in some tests running very slowly (throttling)
+https://bugs.webkit.org/show_bug.cgi?id=147718
+
+Reviewed by Alexey Proskuryakov.
+
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::resetPreferencesToConsistentValues):
+Ensure throttling settings are disabled for tests for all ports, as
+COCOA ports default to having these setting enabled. Note, there is
+still other timer throttling not covered by these setting.
+
 2015-08-06  Filip Pizlo  fpi...@apple.com
 
 Lightweight locks should be adaptive


Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (188101 => 188102)

--- trunk/Tools/WebKitTestRunner/TestController.cpp	2015-08-07 01:03:54 UTC (rev 188101)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2015-08-07 01:22:05 UTC (rev 188102)
@@ -621,6 +621,9 @@
 WKPreferencesSetMediaSourceEnabled(preferences, true);
 #endif
 
+WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled(preferences, false);
+WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled(preferences, false);
+
 WKPreferencesSetAcceleratedDrawingEnabled(preferences, m_shouldUseAcceleratedDrawing);
 
 WKCookieManagerDeleteAllCookies(WKContextGetCookieManager(m_context.get()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188028] trunk/Source/WebInspectorUI

2015-08-06 Thread drousso

Title: [188028] trunk/Source/WebInspectorUI








Revision 188028
Author drou...@apple.com
Date 2015-08-05 23:17:59 -0700 (Wed, 05 Aug 2015)


Log Message
Web Inspector: Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=134501

Reviewed by Timothy Hatcher.

Added a visual Cubic Bezier curve editor that is usable in both
the CSS sidebar and the resources panel.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/DOMUtilities.js:
(createSVGElement):
* UserInterface/Controllers/CodeMirrorBezierEditingController.js:
(WebInspector.CodeMirrorBezierEditingController):
(WebInspector.CodeMirrorBezierEditingController.prototype.get initialValue):
(WebInspector.CodeMirrorBezierEditingController.prototype.get cssClassName):
(WebInspector.CodeMirrorBezierEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorBezierEditingController.prototype.popoverDidPresent):
(WebInspector.CodeMirrorBezierEditingController.prototype._bezierEditorBezierChanged):
* UserInterface/Images/CubicBezier.svg: Added.
* UserInterface/Main.html:
* UserInterface/Models/Geometry.js:
(WebInspector.Point.prototype.distance):
(WebInspector.Point):
(WebInspector.CubicBezier):
(WebInspector.CubicBezier.fromPoints):
(WebInspector.CubicBezier.fromString):
(WebInspector.CubicBezier.prototype.get inPoint):
(WebInspector.CubicBezier.prototype.get outPoint):
(WebInspector.CubicBezier.prototype.copy):
(WebInspector.CubicBezier.prototype.toString):
(WebInspector.CubicBezier.prototype.solve):
(WebInspector.CubicBezier.prototype._sampleCurveX):
(WebInspector.CubicBezier.prototype._sampleCurveY):
(WebInspector.CubicBezier.prototype._sampleCurveDerivativeX):
(WebInspector.CubicBezier.prototype._solveCurveX):
* UserInterface/Models/TextMarker.js:
* UserInterface/Models/UnitBezier.js: Removed.
* UserInterface/Views/BezierEditor.css: Added.
(.bezier-editor):
(.bezier-editor  .bezier-preview):
(.bezier-editor  .bezier-preview  div):
(.bezier-editor  .bezier-preview-timing):
(.bezier-editor  .bezier-preview-timing.animate):
(.bezier-editor  .bezier-container):
(@keyframes bezierPreview):
(.bezier-editor  .bezier-container):
(.bezier-editor  .bezier-container .linear-curve):
(.bezier-editor  .bezier-container .bezier-curve):
(.bezier-editor  .bezier-container .control-line):
(.bezier-editor  .bezier-container .control-handle):
* UserInterface/Views/BezierEditor.js: Added.
(WebInspector.BezierEditor.createControl):
(WebInspector.BezierEditor):
(WebInspector.BezierEditor.prototype.get element):
(WebInspector.BezierEditor.prototype.set bezier):
(WebInspector.BezierEditor.prototype.get bezier):
(WebInspector.BezierEditor.prototype.handleEvent):
(WebInspector.BezierEditor.prototype._handleMousedown):
(WebInspector.BezierEditor.prototype._handleMousemove):
(WebInspector.BezierEditor.prototype._handleMouseup):
(WebInspector.BezierEditor.prototype._updateControlPointsForMouseEvent):
(WebInspector.BezierEditor.prototype._updateValue.round):
(WebInspector.BezierEditor.prototype._updateValue):
(WebInspector.BezierEditor.prototype._updateBezier):
(WebInspector.BezierEditor.prototype._updateControl):
(WebInspector.BezierEditor.prototype._triggerPreviewAnimation):
(WebInspector.BezierEditor.prototype._resetPreviewAnimation):
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor  .CodeMirror .CodeMirror-lines .cubic-bezier-marker):
(.css-style-text-editor  .CodeMirror .CodeMirror-lines .cubic-bezier-marker:hover):
(.css-style-text-editor  .CodeMirror .CodeMirror-lines .cubic-bezier-marker:active):
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._contentChanged):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createBezierEditors.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createBezierEditors):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._commentProperty.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._commentProperty):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._uncommentRange.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._uncommentRange):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked.updateCodeMirror.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked.updateCodeMirror):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent):
*

[webkit-changes] [188027] trunk/LayoutTests

2015-08-06 Thread ap

Title: [188027] trunk/LayoutTests








Revision 188027
Author a...@apple.com
Date 2015-08-05 23:07:31 -0700 (Wed, 05 Aug 2015)


Log Message
Fix TestExpectations lint warnings.

* platform/mac-wk2/TestExpectations: Remove duplicate entries.

* platform/win/TestExpectations: Update for the big platform move of 2015. One of
these tests no longer asserts, so it doesn't need to be skipped.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (188026 => 188027)

--- trunk/LayoutTests/ChangeLog	2015-08-06 05:38:49 UTC (rev 188026)
+++ trunk/LayoutTests/ChangeLog	2015-08-06 06:07:31 UTC (rev 188027)
@@ -1,3 +1,12 @@
+2015-08-05  Alexey Proskuryakov  a...@apple.com
+
+Fix TestExpectations lint warnings.
+
+* platform/mac-wk2/TestExpectations: Remove duplicate entries.
+
+* platform/win/TestExpectations: Update for the big platform move of 2015. One of
+these tests no longer asserts, so it doesn't need to be skipped.
+
 2015-08-05  Simon Fraser  simon.fra...@apple.com
 
 Fix paths to ruby-expansion tests, and make them ImageOnlyFailure rather than Skip.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (188026 => 188027)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-08-06 05:38:49 UTC (rev 188026)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-08-06 06:07:31 UTC (rev 188027)
@@ -254,9 +254,6 @@
 
 webkit.org/b/147075 [ Release Yosemite ] http/tests/cache/disk-cache/disk-cache-disable.html [ Pass Failure ]
 
-webkit.org/b/147300 tiled-drawing/scrolling/frames/frameset-frame-scrollability.html [ Pass Failure ]
-webkit.org/b/147300 tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html [ Pass Failure ]
-
 ### END OF (1) Classified failures with bug reports
 
 


Modified: trunk/LayoutTests/platform/win/TestExpectations (188026 => 188027)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-08-06 05:38:49 UTC (rev 188026)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-08-06 06:07:31 UTC (rev 188027)
@@ -1466,13 +1466,13 @@
 accessibility/content-editable-set-inner-text-generates-axvalue-notification.html [ Skip ]
 [ Release ] accessibility/loading-iframe-sends-notification.html [ Failure ]
 [ Debug ] accessibility/loading-iframe-sends-notification.html [ Skip ] # Debug assertion
-platform/win/accessibility/single-select-children-changed.html	[ Skip ]
+accessibility/win/single-select-children-changed.html	[ Skip ]
 webkit.org/b/142016 accessibility/aria-switch-sends-notification.html [ Skip ]
 
 webkit.org/b/130011 accessibility/aria-setsize-posinset.html [ Skip ]
 
 # Test times out
-webkit.org/b/95405 platform/win/accessibility/single-select-children.html [ Skip ]
+webkit.org/b/95405 accessibility/win/single-select-children.html [ Skip ]
 accessibility/file-upload-button-stringvalue.html
 webkit.org/b/97026 accessibility/file-upload-button-with-axpress.html [ Skip ] #  [ Timeout ]
 
@@ -1484,8 +1484,8 @@
 accessibility/color-well.html
 
 # Failing Windows-only accessibility tests
-webkit.org/b/127485 [ Debug ] platform/win/accessibility/parent-element.html [ Failure ]
-webkit.org/b/127485 [ Release ] platform/win/accessibility/parent-element.html [ Pass Failure ]
+webkit.org/b/127485 [ Debug ] accessibility/win/parent-element.html [ Failure ]
+webkit.org/b/127485 [ Release ] accessibility/win/parent-element.html [ Pass Failure ]
 
 # Skipping on windows, missing implementation of cellForColumnAndRow
 webkit.org/b/129250 accessibility/table-scope.html [ Skip ]
@@ -1672,8 +1672,6 @@
 [ Debug ] accessibility/textbox-role-reports-selection.html [ Skip ] # Debug assertion
 [ Debug ] accessibility/updating-attribute-in-table-causes-crash.html [ Skip ] # Debug assertion
 
-[ Debug ] platform/win/accessibility/option-element-selection-and-focus-events.html [ Skip ] # Debug Assertion
-
 webkit.org/b/146903 accessibility/aria-table-hierarchy.html [ Skip ]
 webkit.org/b/146903 accessibility/roles-table-and-cell.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188038] trunk

2015-08-06 Thread ossy

Title: [188038] trunk








Revision 188038
Author o...@webkit.org
Date 2015-08-06 04:10:52 -0700 (Thu, 06 Aug 2015)


Log Message
[EFL] Bump EFL version to 1.15.0
https://bugs.webkit.org/show_bug.cgi?id=147450

Reviewed by Gyuyoung Kim.

Source/WebKit2:

* PlatformEfl.cmake:

Tools:

* efl/jhbuild.modules:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188037 => 188038)

--- trunk/Source/WebKit2/ChangeLog	2015-08-06 10:12:21 UTC (rev 188037)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-06 11:10:52 UTC (rev 188038)
@@ -1,3 +1,12 @@
+2015-08-06  Csaba Osztrogonác  o...@webkit.org
+
+[EFL] Bump EFL version to 1.15.0
+https://bugs.webkit.org/show_bug.cgi?id=147450
+
+Reviewed by Gyuyoung Kim.
+
+* PlatformEfl.cmake:
+
 2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Crash closing a page when a context menu is open


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (188037 => 188038)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2015-08-06 10:12:21 UTC (rev 188037)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2015-08-06 11:10:52 UTC (rev 188038)
@@ -595,4 +595,7 @@
 list(APPEND WebKit2_LIBRARIES
 ${ELDBUS_LIBRARIES}
 )
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${ELDBUS_INCLUDE_DIRS}
+)
 endif ()


Modified: trunk/Tools/ChangeLog (188037 => 188038)

--- trunk/Tools/ChangeLog	2015-08-06 10:12:21 UTC (rev 188037)
+++ trunk/Tools/ChangeLog	2015-08-06 11:10:52 UTC (rev 188038)
@@ -1,3 +1,12 @@
+2015-08-06  Csaba Osztrogonác  o...@webkit.org
+
+[EFL] Bump EFL version to 1.15.0
+https://bugs.webkit.org/show_bug.cgi?id=147450
+
+Reviewed by Gyuyoung Kim.
+
+* efl/jhbuild.modules:
+
 2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Unksip TestContextMenu GTK+ API test.


Modified: trunk/Tools/efl/jhbuild.modules (188037 => 188038)

--- trunk/Tools/efl/jhbuild.modules	2015-08-06 10:12:21 UTC (rev 188037)
+++ trunk/Tools/efl/jhbuild.modules	2015-08-06 11:10:52 UTC (rev 188038)
@@ -216,9 +216,9 @@
   dep package=gstreamer/
   dep package=gst-plugins-base/
 /dependencies
-branch module=rel/libs/efl/efl-1.14.0.tar.gz version=1.14.0
+branch module=rel/libs/efl/efl-1.15.0.tar.gz version=1.15.0
 repo=download.enlightenment.org
-hash=sha256:30a8a239449e0d068a39787b5a4769dd26ddf0476f58f094c85e65b108086269
+hash=sha256:2552e364e83b8b747ba6f6fcca699a025751a65407055faa9a2afce29d12b6f4
   patch file=ecore_remove_warnings.patch strip=1/
 /branch
   /autotools
@@ -226,9 +226,9 @@
   autotools id=elementary
  autogen-sh=configure
  autogenargs=--disable-emap --disable-eweather --with-elementary-web-backend=none
-branch module=rel/libs/elementary/elementary-1.14.0.tar.gz version=1.14.0
+branch module=rel/libs/elementary/elementary-1.15.0.tar.gz version=1.15.0
 repo=download.enlightenment.org
-hash=sha256:aa06ca1b332b3cd29ffd136c1f10edf08a06906b3532785ce7e390c1cad6090e
+hash=sha256:62b4b7d506cf9ca82f9890328ec01b82d0f84a8d4acd787cec68c3367817ba20
 /branch
 dependencies
 dep package=efl/






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188039] trunk/Tools

Title: [188039] trunk/Tools








Revision 188039
Author carlo...@webkit.org
Date 2015-08-06 05:31:45 -0700 (Thu, 06 Aug 2015)


Log Message
Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.

It's flaky.

* Scripts/run-gtk-tests:
(TestRunner):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (188038 => 188039)

--- trunk/Tools/ChangeLog	2015-08-06 11:10:52 UTC (rev 188038)
+++ trunk/Tools/ChangeLog	2015-08-06 12:31:45 UTC (rev 188039)
@@ -1,3 +1,12 @@
+2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
+
+It's flaky.
+
+* Scripts/run-gtk-tests:
+(TestRunner):
+
 2015-08-06  Csaba Osztrogonác  o...@webkit.org
 
 [EFL] Bump EFL version to 1.15.0


Modified: trunk/Tools/Scripts/run-gtk-tests (188038 => 188039)

--- trunk/Tools/Scripts/run-gtk-tests	2015-08-06 11:10:52 UTC (rev 188038)
+++ trunk/Tools/Scripts/run-gtk-tests	2015-08-06 12:31:45 UTC (rev 188039)
@@ -63,6 +63,7 @@
 SKIPPED = [
 SkippedTest(WebKit2Gtk/TestUIClient, /webkit2/WebKitWebView/mouse-target, Test times out after r150890, 117689),
 SkippedTest(WebKit2Gtk/TestCookieManager, /webkit2/WebKitCookieManager/persistent-storage, Test is flaky, 134580),
+SkippedTest(WebKit2Gtk/TestWebKitWebView, /webkit2/WebKitWebView/submit-form, Test is flaky, 147727),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.MouseMoveAfterCrash, Test is flaky, 85066),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.NewFirstVisuallyNonEmptyLayoutForImages, Test is flaky, 85066),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.NewFirstVisuallyNonEmptyLayoutFrames, Test fails, 85037),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188048] trunk/Source/WebKit2

Title: [188048] trunk/Source/WebKit2








Revision 188048
Author mra...@apple.com
Date 2015-08-06 11:21:20 -0700 (Thu, 06 Aug 2015)


Log Message
Media Session: rename isFocusedContentMediaElementPaused and get rid of callback
https://bugs.webkit.org/show_bug.cgi?id=147726

Reviewed by Simon Fraser.

- isFocusedContentMediaElementPaused should be renamed to isFocusedContentMediaElementPlaying to match recent
  refactoring work.
- isFocusedContentMediaElementPlaying itself does not need a callback anymore because the value can be returned
  directly.

* UIProcess/API/C/WKMediaSessionFocusManager.cpp:
(WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying): Removed callback and renamed from...
(WKMediaSessionFocusManagerIsFocusedContentMediaElementPaused): Deleted.
* UIProcess/API/C/WKMediaSessionFocusManager.h:
* UIProcess/WebMediaSessionFocusManager.cpp:
(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPlaying): Removed callback and renamed from...
(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPaused): Deleted.
* UIProcess/WebMediaSessionFocusManager.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h
trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp
trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (188047 => 188048)

--- trunk/Source/WebKit2/ChangeLog	2015-08-06 18:16:34 UTC (rev 188047)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-06 18:21:20 UTC (rev 188048)
@@ -1,3 +1,24 @@
+2015-08-06  Matt Rajca  mra...@apple.com
+
+Media Session: rename isFocusedContentMediaElementPaused and get rid of callback
+https://bugs.webkit.org/show_bug.cgi?id=147726
+
+Reviewed by Simon Fraser.
+
+- isFocusedContentMediaElementPaused should be renamed to isFocusedContentMediaElementPlaying to match recent
+  refactoring work.
+- isFocusedContentMediaElementPlaying itself does not need a callback anymore because the value can be returned
+  directly.
+
+* UIProcess/API/C/WKMediaSessionFocusManager.cpp:
+(WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying): Removed callback and renamed from...
+(WKMediaSessionFocusManagerIsFocusedContentMediaElementPaused): Deleted.
+* UIProcess/API/C/WKMediaSessionFocusManager.h:
+* UIProcess/WebMediaSessionFocusManager.cpp:
+(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPlaying): Removed callback and renamed from...
+(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPaused): Deleted.
+* UIProcess/WebMediaSessionFocusManager.h:
+
 2015-08-06  Csaba Osztrogonác  o...@webkit.org
 
 [EFL] Bump EFL version to 1.15.0


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp (188047 => 188048)

--- trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp	2015-08-06 18:16:34 UTC (rev 188047)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp	2015-08-06 18:21:20 UTC (rev 188048)
@@ -40,13 +40,12 @@
 #endif
 }
 
-void WKMediaSessionFocusManagerIsFocusedContentMediaElementPaused(WKMediaSessionFocusManagerRef manager, void* context, WKMediaSessionFocusManagerIsFocusedContentMediaElementPausedCallback callback)
+bool WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying(WKMediaSessionFocusManagerRef manager)
 {
 #if ENABLE(MEDIA_SESSION)
-toImpl(manager)-isFocusedContentMediaElementPaused(toGenericCallbackFunctionbool, bool(context, callback));
+return toImpl(manager)-isFocusedContentMediaElementPlaying();
 #else
 UNUSED_PARAM(manager);
-UNUSED_PARAM(context);
-UNUSED_PARAM(callback);
+return false;
 #endif
 }


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h (188047 => 188048)

--- trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h	2015-08-06 18:16:34 UTC (rev 188047)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h	2015-08-06 18:21:20 UTC (rev 188048)
@@ -38,8 +38,7 @@
 
 WK_EXPORT WKTypeID WKMediaSessionFocusManagerGetTypeID();
 
-typedef void (*WKMediaSessionFocusManagerIsFocusedContentMediaElementPausedCallback)(bool, WKErrorRef, void*);
-WK_EXPORT void WKMediaSessionFocusManagerIsFocusedContentMediaElementPaused(WKMediaSessionFocusManagerRef manager, void* context, WKMediaSessionFocusManagerIsFocusedContentMediaElementPausedCallback callback);
+WK_EXPORT bool WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying(WKMediaSessionFocusManagerRef manager);
 
 #ifdef __cplusplus
 }


Modified: trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp (188047 => 188048)

--- trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp	2015-08-06 18:16:34 UTC (rev 188047)
+++

[webkit-changes] [188043] branches/safari-601.1.46-branch/Source/WebKit2

Title: [188043] branches/safari-601.1.46-branch/Source/WebKit2








Revision 188043
Author bshaf...@apple.com
Date 2015-08-06 10:30:44 -0700 (Thu, 06 Aug 2015)


Log Message
Merged r186849.  rdar://problem/22045047

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.h
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm
branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h
branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188042 => 188043)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-06 16:52:15 UTC (rev 188042)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-08-06 17:30:44 UTC (rev 188043)
@@ -1,3 +1,35 @@
+2015-08-06  Babak Shafiei  bshaf...@apple.com
+
+Merge r186849.
+
+2015-07-14  Enrica Casucci  enr...@apple.com
+
+[iOS] Add support for updateSelectionWithExtentPoint:withBoundary.
+https://bugs.webkit.org/show_bug.cgi?id=146951
+rdar://problem/20864286
+
+Reviewed by Tim Horton.
+
+Add implementation for new method used by text selection
+engine on iOS. The new function modifies the selection near the given point
+and snaps it at the boundary of the specified granularity.
+
+* UIProcess/WebPageProxy.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
+(-[WKContentView updateSelectionWithExtentPoint:withBoundary:completionHandler:]):
+(-[WKContentView _characterBeforeCaretSelection]):
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::updateSelectionWithExtentPoint):
+(WebKit::WebPageProxy::updateSelectionWithExtentPointAndBoundary):
+(WebKit::WebPageProxy::requestDictationContext):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/WebPage.messages.in:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::rangeForGranularityAtPoint):
+(WebKit::WebPage::selectTextWithGranularityAtPoint):
+(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary):
+
 2015-08-05  Matthew Hanson  matthew_han...@apple.com
 
 Merge r187962. rdar://problem/21827815


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.h (188042 => 188043)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.h	2015-08-06 16:52:15 UTC (rev 188042)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.h	2015-08-06 17:30:44 UTC (rev 188043)
@@ -491,6 +491,7 @@
 void moveSelectionAtBoundaryWithDirection(WebCore::TextGranularity, WebCore::SelectionDirection, std::functionvoid(CallbackBase::Error));
 void beginSelectionInDirection(WebCore::SelectionDirection, std::functionvoid (uint64_t, CallbackBase::Error));
 void updateSelectionWithExtentPoint(const WebCore::IntPoint, std::functionvoid (uint64_t, CallbackBase::Error));
+void updateSelectionWithExtentPointAndBoundary(const WebCore::IntPoint, WebCore::TextGranularity, std::functionvoid(uint64_t, CallbackBase::Error));
 void requestAutocorrectionData(const String textForAutocorrection, std::functionvoid (const VectorWebCore::FloatRect, const String, double, uint64_t, CallbackBase::Error));
 void applyAutocorrection(const String correction, const String originalText, std::functionvoid (const String, CallbackBase::Error));
 bool applyAutocorrection(const String correction, const String originalText);


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188042 => 188043)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 16:52:15 UTC (rev 188042)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2015-08-06 17:30:44 UTC (rev 188043)
@@ -2051,6 +2051,16 @@
 });
 }
 
+- (void)updateSelectionWithExtentPoint:(CGPoint)point withBoundary:(UITextGranularity)granularity completionHandler:(void (^)(BOOL selectionEndIsMoving))completionHandler
+{
+UIWKSelectionWithDirectionCompletionHandler selectionHandler = [completionHandler copy];
+
+_page-updateSelectionWithExtentPointAndBoundary(WebCore::IntPoint(point), toWKTextGranularity(granularity), [selectionHandler](bool endIsMoving, WebKit::CallbackBase::Error error) {
+selectionHandler(endIsMoving);
+[selectionHandler release];
+});
+}
+
 -

[webkit-changes] [188044] branches/safari-600.8-branch/LayoutTests

2015-08-06 Thread beidson

Title: [188044] branches/safari-600.8-branch/LayoutTests








Revision 188044
Author beid...@apple.com
Date 2015-08-06 10:44:45 -0700 (Thu, 06 Aug 2015)


Log Message
Re-baseline test for WK1 on this branch

Collaboration of Brady and Alexey.

* platform/mac-wk1/http: Added.
* platform/mac-wk1/http/tests: Added.
* platform/mac-wk1/http/tests/misc: Added.
* platform/mac-wk1/http/tests/misc/authentication-redirect-3: Added.
* platform/mac-wk1/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.

Modified Paths

branches/safari-600.8-branch/LayoutTests/ChangeLog


Added Paths

branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/
branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/tests/
branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/tests/misc/
branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/tests/misc/authentication-redirect-3/
branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt




Diff

Modified: branches/safari-600.8-branch/LayoutTests/ChangeLog (188043 => 188044)

--- branches/safari-600.8-branch/LayoutTests/ChangeLog	2015-08-06 17:30:44 UTC (rev 188043)
+++ branches/safari-600.8-branch/LayoutTests/ChangeLog	2015-08-06 17:44:45 UTC (rev 188044)
@@ -1,3 +1,15 @@
+2015-08-06  Brady Eidson  beid...@apple.com
+
+Re-baseline test for WK1 on this branch
+
+Collaboration of Brady and Alexey.
+
+* platform/mac-wk1/http: Added.
+* platform/mac-wk1/http/tests: Added.
+* platform/mac-wk1/http/tests/misc: Added.
+* platform/mac-wk1/http/tests/misc/authentication-redirect-3: Added.
+* platform/mac-wk1/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.
+
 2015-07-29  Babak Shafiei  bshaf...@apple.com
 
 Roll out r185848.


Added: branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt (0 => 188044)

--- branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt	(rev 0)
+++ branches/safari-600.8-branch/LayoutTests/platform/mac-wk1/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt	2015-08-06 17:44:45 UTC (rev 188044)
@@ -0,0 +1,28 @@
+http://127.0.0.1:8000/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php?redirect=301 - didReceiveAuthenticationChallenge - Responding with testUser:testPassword
+https://bugs.webkit.org/show_bug.cgi?id=66354
+You should load this page at 127.0.0.1:8000 because the test relies on redirects within the 127.0.0.1:8000 security origin.
+This test loads a php script which demands http authentication, then uses it to redirect to another script in the same origin that shows what authentication headers were sent with the final request.
+The redirect includes credentials in the location url, and they should be preferred over credentials that WebCore has cached.
+It does this once each for HTTP 301, 302, 303, and 307 redirects.
+If not running under DRT, enter any credentials when asked.
+
+
+
+Frame: '!--framePath //!--frame0'
+
+Resource loaded with HTTP authentication username 'redirectuser' and password 'redirectpassword'
+
+
+Frame: '!--framePath //!--frame1'
+
+Resource loaded with HTTP authentication username 'redirectuser' and password 'redirectpassword'
+
+
+Frame: '!--framePath //!--frame2'
+
+Resource loaded with HTTP authentication username 'redirectuser' and password 'redirectpassword'
+
+
+Frame: '!--framePath //!--frame3'
+
+Resource loaded with HTTP authentication username 'redirectuser' and password 'redirectpassword'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188047] trunk/Websites/webkit.org

Title: [188047] trunk/Websites/webkit.org








Revision 188047
Author bfulg...@apple.com
Date 2015-08-06 11:16:34 -0700 (Thu, 06 Aug 2015)


Log Message
Add two more files for a future blog post.

* blog-files/backdrop-filters/Media_Controls_1x.jpg: Added.
* blog-files/backdrop-filters/Media_Controls_2x.jpg: Added.

Modified Paths

trunk/Websites/webkit.org/ChangeLog


Added Paths

trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_1x.jpg
trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_2x.jpg




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (188046 => 188047)

--- trunk/Websites/webkit.org/ChangeLog	2015-08-06 17:58:11 UTC (rev 188046)
+++ trunk/Websites/webkit.org/ChangeLog	2015-08-06 18:16:34 UTC (rev 188047)
@@ -1,3 +1,10 @@
+2015-08-06  Brent Fulgham  bfulg...@apple.com
+
+Add two more files for a future blog post.
+
+* blog-files/backdrop-filters/Media_Controls_1x.jpg: Added.
+* blog-files/backdrop-filters/Media_Controls_2x.jpg: Added.
+
 2015-08-05  Benjamin Poulain  benja...@webkit.org
 
 Fix the twitter links on the status page


Added: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_1x.jpg

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_1x.jpg
___

Added: svn:mime-type

Added: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_2x.jpg

(Binary files differ)

Property changes on: trunk/Websites/webkit.org/blog-files/backdrop-filters/Media_Controls_2x.jpg
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188049] trunk/Source/WebCore

Title: [188049] trunk/Source/WebCore








Revision 188049
Author mra...@apple.com
Date 2015-08-06 11:30:30 -0700 (Thu, 06 Aug 2015)


Log Message
Media Session: remove media elements from the ID - element map on destruction
https://bugs.webkit.org/show_bug.cgi?id=147707

Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (188048 => 188049)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 18:21:20 UTC (rev 188048)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 18:30:30 UTC (rev 188049)
@@ -1,3 +1,13 @@
+2015-08-06  Matt Rajca  mra...@apple.com
+
+Media Session: remove media elements from the ID - element map on destruction
+https://bugs.webkit.org/show_bug.cgi?id=147707
+
+Reviewed by Eric Carlson.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::~HTMLMediaElement):
+
 2015-08-06  Gyuyoung Kim  gyuyoung@webkit.org
 
 [CoordinatedGraphics] Remove unused functions in Coordinated TiledBackingStore


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (188048 => 188049)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-08-06 18:21:20 UTC (rev 188048)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-08-06 18:30:30 UTC (rev 188049)
@@ -511,6 +511,8 @@
 m_session-removeMediaElement(*this);
 m_session = nullptr;
 }
+
+elementIDsToElements().remove(m_elementID);
 #endif
 
 m_seekTaskQueue.close();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188051] trunk/Source/WebCore

2015-08-06 Thread eric . carlson

Title: [188051] trunk/Source/WebCore








Revision 188051
Author eric.carl...@apple.com
Date 2015-08-06 11:45:01 -0700 (Thu, 06 Aug 2015)


Log Message
Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument
https://bugs.webkit.org/show_bug.cgi?id=147734
rdar://problem/22028179

Reviewed by Dean Jackson.

Test to follow, see https://bugs.webkit.org/show_bug.cgi?id=147735

* dom/Document.cpp:
(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Return
  early if the Document is a MediaDocument.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (188050 => 188051)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 18:35:16 UTC (rev 188050)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 18:45:01 UTC (rev 188051)
@@ -1,3 +1,17 @@
+2015-08-06  Eric Carlson  eric.carl...@apple.com
+
+Do not enforce content-disposition: attachment sandbox restrictions on a MediaDocument
+https://bugs.webkit.org/show_bug.cgi?id=147734
+rdar://problem/22028179
+
+Reviewed by Dean Jackson.
+
+Test to follow, see https://bugs.webkit.org/show_bug.cgi?id=147735
+
+* dom/Document.cpp:
+(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Return
+  early if the Document is a MediaDocument.
+
 2015-08-06  Matt Rajca  mra...@apple.com
 
 Media Session: remove media elements from the ID - element map on destruction


Modified: trunk/Source/WebCore/dom/Document.cpp (188050 => 188051)

--- trunk/Source/WebCore/dom/Document.cpp	2015-08-06 18:35:16 UTC (rev 188050)
+++ trunk/Source/WebCore/dom/Document.cpp	2015-08-06 18:45:01 UTC (rev 188051)
@@ -6717,6 +6717,9 @@
 if (m_isSynthesized)
 return false;
 
+if (isMediaDocument())
+return false;
+
 bool contentDispositionAttachmentSandboxEnabled = settings()  settings()-contentDispositionAttachmentSandboxEnabled();
 bool responseIsAttachment = false;
 if (DocumentLoader* documentLoader = m_frame ? m_frame-loader().activeDocumentLoader() : nullptr)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188046] trunk/Source/WebCore

2015-08-06 Thread gyuyoung . kim

Title: [188046] trunk/Source/WebCore








Revision 188046
Author gyuyoung@webkit.org
Date 2015-08-06 10:58:11 -0700 (Thu, 06 Aug 2015)


Log Message
[CoordinatedGraphics] Remove unused functions in Coordinated TiledBackingStore
https://bugs.webkit.org/show_bug.cgi?id=147621

Reviewed by Csaba Osztrogonác.

* platform/graphics/texmap/coordinated/TiledBackingStore.cpp: Remove setTileSize() and tileSize().
(WebCore::TiledBackingStore::setTileSize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp
trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188045 => 188046)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 17:55:53 UTC (rev 188045)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 17:58:11 UTC (rev 188046)
@@ -1,3 +1,13 @@
+2015-08-06  Gyuyoung Kim  gyuyoung@webkit.org
+
+[CoordinatedGraphics] Remove unused functions in Coordinated TiledBackingStore
+https://bugs.webkit.org/show_bug.cgi?id=147621
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/graphics/texmap/coordinated/TiledBackingStore.cpp: Remove setTileSize() and tileSize().
+(WebCore::TiledBackingStore::setTileSize):
+
 2015-08-06  Anders Carlsson  ander...@apple.com
 
 Move the last remnants of DatabaseBackendBase to Database


Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp (188045 => 188046)

--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp	2015-08-06 17:55:53 UTC (rev 188045)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp	2015-08-06 17:58:11 UTC (rev 188046)
@@ -48,12 +48,6 @@
 {
 }
 
-void TiledBackingStore::setTileSize(const IntSize size)
-{
-m_tileSize = size;
-m_tiles.clear();
-}
-
 void TiledBackingStore::setTrajectoryVector(const FloatPoint trajectoryVector)
 {
 m_pendingTrajectoryVector = trajectoryVector;


Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.h (188045 => 188046)

--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.h	2015-08-06 17:55:53 UTC (rev 188045)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.h	2015-08-06 17:58:11 UTC (rev 188046)
@@ -52,9 +52,6 @@
 
 void invalidate(const IntRect dirtyRect);
 
-IntSize tileSize() { return m_tileSize; }
-void setTileSize(const IntSize);
-
 IntRect mapToContents(const IntRect) const;
 IntRect mapFromContents(const IntRect) const;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188045] trunk/Source/WebCore

Title: [188045] trunk/Source/WebCore








Revision 188045
Author ander...@apple.com
Date 2015-08-06 10:55:53 -0700 (Thu, 06 Aug 2015)


Log Message
Move the last remnants of DatabaseBackendBase to Database
https://bugs.webkit.org/show_bug.cgi?id=147730

Reviewed by Tim Horton.

* Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
* Modules/webdatabase/Database.h:
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
* Modules/webdatabase/DatabaseBackendBase.h:
(WebCore::DatabaseBackendBase::databaseContext): Deleted.
(WebCore::DatabaseBackendBase::setFrontend): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/Database.cpp
trunk/Source/WebCore/Modules/webdatabase/Database.h
trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp
trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (188044 => 188045)

--- trunk/Source/WebCore/ChangeLog	2015-08-06 17:44:45 UTC (rev 188044)
+++ trunk/Source/WebCore/ChangeLog	2015-08-06 17:55:53 UTC (rev 188045)
@@ -1,3 +1,20 @@
+2015-08-06  Anders Carlsson  ander...@apple.com
+
+Move the last remnants of DatabaseBackendBase to Database
+https://bugs.webkit.org/show_bug.cgi?id=147730
+
+Reviewed by Tim Horton.
+
+* Modules/webdatabase/Database.cpp:
+(WebCore::Database::Database):
+(WebCore::Database::performOpenAndVerify):
+* Modules/webdatabase/Database.h:
+* Modules/webdatabase/DatabaseBackendBase.cpp:
+(WebCore::DatabaseBackendBase::DatabaseBackendBase):
+* Modules/webdatabase/DatabaseBackendBase.h:
+(WebCore::DatabaseBackendBase::databaseContext): Deleted.
+(WebCore::DatabaseBackendBase::setFrontend): Deleted.
+
 2015-08-06  Alex Christensen  achristen...@webkit.org
 
 Fix build without ENABLE(VIDEO) after r188030.


Modified: trunk/Source/WebCore/Modules/webdatabase/Database.cpp (188044 => 188045)

--- trunk/Source/WebCore/Modules/webdatabase/Database.cpp	2015-08-06 17:44:45 UTC (rev 188044)
+++ trunk/Source/WebCore/Modules/webdatabase/Database.cpp	2015-08-06 17:55:53 UTC (rev 188045)
@@ -60,6 +60,35 @@
 
 namespace WebCore {
 
+// Registering opened databases with the DatabaseTracker
+// ===
+// The DatabaseTracker maintains a list of databases that have been
+// opened so that the client can call interrupt or delete on every database
+// associated with a DatabaseContext.
+//
+// We will only call DatabaseTracker::addOpenDatabase() to add the database
+// to the tracker as opened when we've succeeded in opening the database,
+// and will set m_opened to true. Similarly, we only call
+// DatabaseTracker::removeOpenDatabase() to remove the database from the
+// tracker when we set m_opened to false in closeDatabase(). This sets up
+// a simple symmetry between open and close operations, and a direct
+// correlation to adding and removing databases from the tracker's list,
+// thus ensuring that we have a correct list for the interrupt and
+// delete operations to work on.
+//
+// The only databases instances not tracked by the tracker's open database
+// list are the ones that have not been added yet, or the ones that we
+// attempted an open on but failed to. Such instances only exist in the
+// DatabaseServer's factory methods for creating database backends.
+//
+// The factory methods will either call openAndVerifyVersion() or
+// performOpenAndVerify(). These methods will add the newly instantiated
+// database backend if they succeed in opening the requested database.
+// In the case of failure to open the database, the factory methods will
+// simply discard the newly instantiated database backend when they return.
+// The ref counting mechanims will automatically destruct the un-added
+// (and un-returned) databases instances.
+
 static const char versionKey[] = WebKitDatabaseVersionKey;
 static const char unqualifiedInfoTableName[] = __WebKitDatabaseInfoTable__;
 
@@ -184,12 +213,17 @@
 }
 
 Database::Database(PassRefPtrDatabaseContext databaseContext, const String name, const String expectedVersion, const String displayName, unsigned long estimatedSize)
-: DatabaseBackendBase(databaseContext.get(), name, expectedVersion, displayName, estimatedSize)
+: m_scriptExecutionContext(databaseContext-scriptExecutionContext())
+, m_databaseContext(databaseContext)
+, m_deleted(false)
+, m_name(name.isolatedCopy())
+, m_expectedVersion(expectedVersion.isolatedCopy())
+, m_displayName(displayName.isolatedCopy())
+, m_estimatedSize(estimatedSize)
+, m_opened(false)
+, m_new(false)
 , m_transactionInProgress(false)
 , m_isTransactionQueueEnabled(true)
-, m_scriptExecutionContext(databaseContext-scriptExecutionContext())
-,

[webkit-changes] [188042] branches/safari-601.1.46-branch/Source

Title: [188042] branches/safari-601.1.46-branch/Source








Revision 188042
Author bshaf...@apple.com
Date 2015-08-06 09:52:15 -0700 (Thu, 06 Aug 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (188041 => 188042)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-08-06 16:36:39 UTC (rev 188041)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-08-06 16:52:15 UTC (rev 188042)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (188041 => 188042)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-08-06 16:36:39 UTC (rev 188041)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-08-06 16:52:15 UTC (rev 188042)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (188041 => 188042)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-08-06 16:36:39 UTC (rev 188041)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-08-06 16:52:15 UTC (rev 188042)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (188041 => 188042)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-08-06 16:36:39 UTC (rev 188041)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-08-06 16:52:15 UTC (rev 188042)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (188041 => 188042)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-08-06 16:36:39 UTC (rev 188041)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-08-06 16:52:15 UTC (rev 188042)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188032] trunk/Tools

Title: [188032] trunk/Tools








Revision 188032
Author carlo...@webkit.org
Date 2015-08-06 01:19:48 -0700 (Thu, 06 Aug 2015)


Log Message
Unreviewed. Unksip TestContextMenu GTK+ API test.

This has been skipped for a long time, and it's very
unconvenient. It has never failed for me locally, so let's try
again to see if it works in the bots. I'll skip it again if it
keeps failing.

* Scripts/run-gtk-tests:
(TestRunner):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (188031 => 188032)

--- trunk/Tools/ChangeLog	2015-08-06 08:14:20 UTC (rev 188031)
+++ trunk/Tools/ChangeLog	2015-08-06 08:19:48 UTC (rev 188032)
@@ -1,3 +1,15 @@
+2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Unksip TestContextMenu GTK+ API test.
+
+This has been skipped for a long time, and it's very
+unconvenient. It has never failed for me locally, so let's try
+again to see if it works in the bots. I'll skip it again if it
+keeps failing.
+
+* Scripts/run-gtk-tests:
+(TestRunner):
+
 2015-08-05  Filip Pizlo  fpi...@apple.com
 
 Unreviewed, roll out http://trac.webkit.org/changeset/187972.


Modified: trunk/Tools/Scripts/run-gtk-tests (188031 => 188032)

--- trunk/Tools/Scripts/run-gtk-tests	2015-08-06 08:14:20 UTC (rev 188031)
+++ trunk/Tools/Scripts/run-gtk-tests	2015-08-06 08:19:48 UTC (rev 188032)
@@ -62,7 +62,6 @@
 
 SKIPPED = [
 SkippedTest(WebKit2Gtk/TestUIClient, /webkit2/WebKitWebView/mouse-target, Test times out after r150890, 117689),
-SkippedTest(WebKit2Gtk/TestContextMenu, SkippedTest.ENTIRE_SUITE, Test times out after r150890, 117689),
 SkippedTest(WebKit2Gtk/TestCookieManager, /webkit2/WebKitCookieManager/persistent-storage, Test is flaky, 134580),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.MouseMoveAfterCrash, Test is flaky, 85066),
 SkippedTest(WebKit2/TestWebKit2, WebKit2.NewFirstVisuallyNonEmptyLayoutForImages, Test is flaky, 85066),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188033] releases/WebKitGTK/webkit-2.8

Title: [188033] releases/WebKitGTK/webkit-2.8








Revision 188033
Author carlo...@webkit.org
Date 2015-08-06 01:47:54 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r188014 - Crash when removing children of a MathMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=147704
rdar://problem/21940321

Reviewed by Ryosuke Niwa.

Source/WebCore:

When MathMLSelectElement::childrenChanged() is called after its
children have been removed, MathMLSelectElement calls
updateSelectedChild() which accesses m_selectedChild. However,
in this case, m_selectedChild is the previously selected child
and it may be destroyed as this point if it was removed. To avoid
this problem, MathMLSelectElement now keep a strong ref to the
currently selected element.

Test: mathml/maction-removeChild.html

* mathml/MathMLSelectElement.h:

LayoutTests:

Add layout test that reproduces the crash under guardmalloc.

* mathml/maction-removeChild-expected.txt: Added.
* mathml/maction-removeChild.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/mathml/MathMLSelectElement.h


Added Paths

releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild-expected.txt
releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild.html




Diff

Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (188032 => 188033)

--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog	2015-08-06 08:19:48 UTC (rev 188032)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog	2015-08-06 08:47:54 UTC (rev 188033)
@@ -1,3 +1,16 @@
+2015-08-05  Chris Dumez  cdu...@apple.com
+
+Crash when removing children of a MathMLSelectElement
+https://bugs.webkit.org/show_bug.cgi?id=147704
+rdar://problem/21940321
+
+Reviewed by Ryosuke Niwa.
+
+Add layout test that reproduces the crash under guardmalloc.
+
+* mathml/maction-removeChild-expected.txt: Added.
+* mathml/maction-removeChild.html: Added.
+
 2015-07-28  Simon Fraser  simon.fra...@apple.com
 
 Animations sometimes fail to start


Added: releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild-expected.txt (0 => 188033)

--- releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild-expected.txt	2015-08-06 08:47:54 UTC (rev 188033)
@@ -0,0 +1,3 @@
+This test passes if it does not crash
+
+


Added: releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild.html (0 => 188033)

--- releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/mathml/maction-removeChild.html	2015-08-06 08:47:54 UTC (rev 188033)
@@ -0,0 +1,19 @@
+!doctype html
+html
+  body
+pThis test passes if it does not crash/p
+math
+  maction id=testSelect actiontype=toggle selection=2
+mig/mi
+mspace/
+  /maction
+/math
+script
+  if (window.testRunner)
+testRunner.dumpAsText();
+
+  var testSelect = document.getElementById(testSelect);
+  testSelect.innerHTML = 123.123.123;
+/script
+  /body
+/html


Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (188032 => 188033)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-08-06 08:19:48 UTC (rev 188032)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-08-06 08:47:54 UTC (rev 188033)
@@ -1,3 +1,23 @@
+2015-08-05  Chris Dumez  cdu...@apple.com
+
+Crash when removing children of a MathMLSelectElement
+https://bugs.webkit.org/show_bug.cgi?id=147704
+rdar://problem/21940321
+
+Reviewed by Ryosuke Niwa.
+
+When MathMLSelectElement::childrenChanged() is called after its
+children have been removed, MathMLSelectElement calls
+updateSelectedChild() which accesses m_selectedChild. However,
+in this case, m_selectedChild is the previously selected child
+and it may be destroyed as this point if it was removed. To avoid
+this problem, MathMLSelectElement now keep a strong ref to the
+currently selected element.
+
+Test: mathml/maction-removeChild.html
+
+* mathml/MathMLSelectElement.h:
+
 2015-08-03  Brady Eidson  beid...@apple.com
 
 Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const).


Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/mathml/MathMLSelectElement.h (188032 => 188033)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/mathml/MathMLSelectElement.h	2015-08-06 08:19:48 UTC (rev 188032)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/mathml/MathMLSelectElement.h	2015-08-06 08:47:54 UTC (rev 188033)
@@ -56,7 +56,7 @@
 Element*

[webkit-changes] [188034] releases/WebKitGTK/webkit-2.8/Source/WebKit2

Title: [188034] releases/WebKitGTK/webkit-2.8/Source/WebKit2








Revision 188034
Author carlo...@webkit.org
Date 2015-08-06 01:50:53 -0700 (Thu, 06 Aug 2015)


Log Message
Merge r188031 - [GTK] Crash closing a page when a context menu is open
https://bugs.webkit.org/show_bug.cgi?id=147682

Reviewed by Sergio Villar Senin.

Implement WebContextMenuProxy::cancelTracking() to clear the
internal menu when the web page is closed.

* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::cancelTracking):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Deleted.
* UIProcess/gtk/WebContextMenuProxyGtk.h:

Modified Paths

releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp
releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h




Diff

Modified: releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog (188033 => 188034)

--- releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog	2015-08-06 08:47:54 UTC (rev 188033)
+++ releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog	2015-08-06 08:50:53 UTC (rev 188034)
@@ -1,3 +1,18 @@
+2015-08-06  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Crash closing a page when a context menu is open
+https://bugs.webkit.org/show_bug.cgi?id=147682
+
+Reviewed by Sergio Villar Senin.
+
+Implement WebContextMenuProxy::cancelTracking() to clear the
+internal menu when the web page is closed.
+
+* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
+(WebKit::WebContextMenuProxyGtk::cancelTracking):
+(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Deleted.
+* UIProcess/gtk/WebContextMenuProxyGtk.h:
+
 2015-07-28  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Use fastMalloc instead of g_slice


Modified: releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp (188033 => 188034)

--- releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp	2015-08-06 08:47:54 UTC (rev 188033)
+++ releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp	2015-08-06 08:50:53 UTC (rev 188034)
@@ -170,10 +170,7 @@
 
 WebContextMenuProxyGtk::~WebContextMenuProxyGtk()
 {
-for (auto iter = m_signalHandlers.begin(); iter != m_signalHandlers.end(); ++iter)
-g_signal_handler_disconnect(iter-value, iter-key);
-
-webkitWebViewBaseSetActiveContextMenuProxy(WEBKIT_WEB_VIEW_BASE(m_webView), 0);
+cancelTracking();
 }
 
 void WebContextMenuProxyGtk::menuPositionFunction(GtkMenu* menu, gint* x, gint* y, gboolean* pushIn, WebContextMenuProxyGtk* popupMenu)
@@ -193,5 +190,15 @@
 *pushIn = FALSE;
 }
 
+void WebContextMenuProxyGtk::cancelTracking()
+{
+for (auto iter = m_signalHandlers.begin(); iter != m_signalHandlers.end(); ++iter)
+g_signal_handler_disconnect(iter-value, iter-key);
+m_signalHandlers.clear();
+
+webkitWebViewBaseSetActiveContextMenuProxy(WEBKIT_WEB_VIEW_BASE(m_webView), nullptr);
+m_menu.setPlatformDescription(nullptr);
+}
+
 } // namespace WebKit
 #endif // ENABLE(CONTEXT_MENUS)


Modified: releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h (188033 => 188034)

--- releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h	2015-08-06 08:47:54 UTC (rev 188033)
+++ releases/WebKitGTK/webkit-2.8/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h	2015-08-06 08:50:53 UTC (rev 188034)
@@ -46,8 +46,9 @@
 }
 ~WebContextMenuProxyGtk();
 
-virtual void showContextMenu(const WebCore::IntPoint, const VectorWebContextMenuItemData, const ContextMenuContextData);
-virtual void hideContextMenu();
+virtual void showContextMenu(const WebCore::IntPoint, const VectorWebContextMenuItemData, const ContextMenuContextData) override;
+virtual void hideContextMenu() override;
+virtual void cancelTracking() override;
 
 void populate(VectorWebCore::ContextMenuItem);
 GtkMenu* gtkMenu() const { return m_menu.platformDescription(); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188040] trunk/Source/JavaScriptCore