[webkit-changes] [199947] trunk/Source/WebInspectorUI

[mattbaker]

Title: [199947] trunk/Source/WebInspectorUI








Revision 199947
Author mattba...@apple.com
Date 2016-04-22 19:49:40 -0700 (Fri, 22 Apr 2016)


Log Message
Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons
https://bugs.webkit.org/show_bug.cgi?id=156934

Reviewed by Timothy Hatcher.

* UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
(WebInspector.HeapAllocationsTimelineDataGridNode):
Use existing base class helper function to create main title text.
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
Add icon class names to cell, remove icon element.

* UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
Turn on icons for the column.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (199946 => 199947)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-04-23 02:00:38 UTC (rev 199946)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-04-23 02:49:40 UTC (rev 199947)
@@ -1,3 +1,20 @@
+2016-04-22  Matt Baker  
+
+Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons
+https://bugs.webkit.org/show_bug.cgi?id=156934
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
+(WebInspector.HeapAllocationsTimelineDataGridNode):
+Use existing base class helper function to create main title text.
+(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
+Add icon class names to cell, remove icon element.
+
+* UserInterface/Views/HeapAllocationsTimelineView.js:
+(WebInspector.HeapAllocationsTimelineView):
+Turn on icons for the column.
+
 2016-04-22  Timothy Hatcher  
 
 Change an assert to a warn based on post review feedback.


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js (199946 => 199947)

--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js	2016-04-23 02:00:38 UTC (rev 199946)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js	2016-04-23 02:49:40 UTC (rev 199947)
@@ -33,7 +33,7 @@
 this._heapAllocationsView = heapAllocationsView;
 
 this._data = {
-name: WebInspector.TimelineTabContentView.displayNameForRecord(heapAllocationsTimelineRecord),
+name: this.displayName(),
 timestamp: this._record.timestamp - zeroTime,
 size: this._record.heapSnapshot.totalSize,
 };
@@ -48,9 +48,9 @@
 {
 switch (columnIdentifier) {
 case "name":
+cell.classList.add(...this.iconClassNames());
+
 let fragment = document.createDocumentFragment();
-let iconElement = fragment.appendChild(document.createElement("img"));
-iconElement.classList.add("icon", "heap-snapshot");
 let titleElement = fragment.appendChild(document.createElement("span"));
 titleElement.textContent = this._data.name;
 let goToButton = fragment.appendChild(WebInspector.createGoToArrowButton());


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (199946 => 199947)

--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js	2016-04-23 02:00:38 UTC (rev 199946)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js	2016-04-23 02:49:40 UTC (rev 199947)
@@ -37,6 +37,7 @@
 name: {
 title: WebInspector.UIString("Name"),
 width: "150px",
+icon: true,
 },
 timestamp: {
 title: WebInspector.UIString("Time"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199946] trunk

[fpizlo]

Title: [199946] trunk








Revision 199946
Author fpi...@apple.com
Date 2016-04-22 19:00:38 -0700 (Fri, 22 Apr 2016)


Log Message
Speed up bound functions a bit
https://bugs.webkit.org/show_bug.cgi?id=156889

Reviewed by Saam Barati.
Source/_javascript_Core:


Bound functions are hard to optimize because JSC doesn't have a good notion of non-JS code
that does JS-ey things like make JS calls. What I mean by "non-JS code" is code that did not
originate from JS source. A bound function does a highly polymorphic call to the target
stored in the JSBoundFunction. Prior to this change, we represented it as native code that
used the generic native->JS call API. That's not cheap.

We could model bound functions using a builtin, but it's not clear that this would be easy
to grok, since so much of the code would have to access special parts of the JSBoundFunction
type. Doing it that way might solve the performance problems but it would mean extra work to
arrange for the builtin to have speedy access to the call target, the bound this, and the
bound arguments. Also, optimizing bound functions that way would mean that bound function
performance would be gated on the performance of a bunch of other things in our system. For
example, we'd want this polymorphic call to be handled like the funnel that it is: if we're
compiling the bound function's outgoing call with no context then we should compile it as
fully polymorphic but we can let it assume basic sanity like that the callee is a real
function; but if we're compiling the call with any amount of calling context then we want to
use normal call IC's.

Since the builtin path wouldn't lead to a simpler patch and since I think that the VM will
benefit in the long run from using custom handling for bound functions, I kept the native
code and just added Intrinsic/thunk support.

This just adds an Intrinsic for bound function calls where the JSBoundFunction targets a
JSFunction instance and has no bound arguments (only bound this). This intrinsic is
currently only implemented as a thunk and not yet recognized by the DFG bytecode parser.

I needed to loosen some restrictions to do this. For one, I was really tired of our bad use
of ENABLE(JIT) conditionals, which made it so that any serious client of Intrinsics would
have to have #ifdefs. Really what should happen is that if the JIT is not enabled then we
just ignore intrinsics. Also, the code was previously assuming that having a native
constructor and knowing the Intrinsic for your native call were mutually exclusive. This
change makes it possible to have a native executable that has a custom function, custom
constructor, and an Intrinsic.

This is a >4x speed-up on bound function calls with no bound arguments.

In the future, we should teach the DFG Intrinsic handling to deal with bound functions and
we should teach the inliner (and ByteCodeParser::handleCall() in general) how to deal with
the function call inside the bound function. That would be super awesome.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::timesPtr):
(JSC::AbstractMacroAssembler::Address::withOffset):
(JSC::AbstractMacroAssembler::BaseIndex::BaseIndex):
(JSC::MacroAssemblerType>::Address::indexedBy):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::storeCell):
(JSC::AssemblyHelpers::loadCell):
(JSC::AssemblyHelpers::storeValue):
(JSC::AssemblyHelpers::emitSaveCalleeSaves):
(JSC::AssemblyHelpers::emitSaveThenMaterializeTagRegisters):
(JSC::AssemblyHelpers::emitRestoreCalleeSaves):
(JSC::AssemblyHelpers::emitRestoreSavedTagRegisters):
(JSC::AssemblyHelpers::copyCalleeSavesToVMCalleeSavesBuffer):
* jit/JITThunks.cpp:
(JSC::JITThunks::ctiNativeTailCall):
(JSC::JITThunks::ctiNativeTailCallWithoutSavedTags):
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
(JSC::JITThunks::clearHostFunctionStubs):
* jit/JITThunks.h:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::callDoubleToDoublePreservingReturn):
(JSC::SpecializedThunkJIT::tagReturnAsInt32):
(JSC::SpecializedThunkJIT::emitSaveThenMaterializeTagRegisters): Deleted.
(JSC::SpecializedThunkJIT::emitRestoreSavedTagRegisters): Deleted.
* jit/ThunkGenerators.cpp:
(JSC::virtualThunkFor):
(JSC::nativeForGenerator):
(JSC::nativeCallGenerator):
(JSC::nativeTailCallGenerator):
(JSC::nativeTailCallWithoutSavedTagsGenerator):
(JSC::nativeConstructGenerator):
(JSC::randomThunkGenerator):
(JSC::boundThisNoArgsFunctionCallGenerator):
* jit/ThunkGenerators.h:
* runtime/Executable.cpp:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::destroy):
(JSC::NativeExecutable::createStructure):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
* runtime/Executable.h:
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
* runtime/IntlCollatorPrototype.cpp:
(JSC::IntlCollatorPrototypeGetterCompare):
* runtime/Intrinsic.h:
* runtime/JSBoundFunction.cpp:

[webkit-changes] [199945] branches/safari-601.1.46-branch/Source

[bshafiei]

Title: [199945] branches/safari-601.1.46-branch/Source








Revision 199945
Author bshaf...@apple.com
Date 2016-04-22 18:14:02 -0700 (Fri, 22 Apr 2016)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (199944 => 199945)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-23 01:14:02 UTC (rev 199945)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 128;
+MICRO_VERSION = 129;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (199944 => 199945)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-04-23 01:14:02 UTC (rev 199945)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 128;
+MICRO_VERSION = 129;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (199944 => 199945)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-23 01:14:02 UTC (rev 199945)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 128;
+MICRO_VERSION = 129;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (199944 => 199945)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-23 01:14:02 UTC (rev 199945)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 128;
+MICRO_VERSION = 129;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (199944 => 199945)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-04-23 01:14:02 UTC (rev 199945)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 128;
+MICRO_VERSION = 129;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199944] branches/safari-601-branch/Source

[bshafiei]

Title: [199944] branches/safari-601-branch/Source








Revision 199944
Author bshaf...@apple.com
Date 2016-04-22 18:13:17 -0700 (Fri, 22 Apr 2016)


Log Message
Versioning.

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig (199943 => 199944)

--- branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-23 01:11:43 UTC (rev 199943)
+++ branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig (199943 => 199944)

--- branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2016-04-23 01:11:43 UTC (rev 199943)
+++ branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (199943 => 199944)

--- branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-23 01:11:43 UTC (rev 199943)
+++ branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig (199943 => 199944)

--- branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-23 01:11:43 UTC (rev 199943)
+++ branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig (199943 => 199944)

--- branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-04-23 01:11:43 UTC (rev 199943)
+++ branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-04-23 01:13:17 UTC (rev 199944)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199942] trunk

[cdumez]

Title: [199942] trunk








Revision 199942
Author cdu...@apple.com
Date 2016-04-22 17:58:01 -0700 (Fri, 22 Apr 2016)


Log Message
Cannot access the SQLTransaction.constructor.prototype
https://bugs.webkit.org/show_bug.cgi?id=156613

Reviewed by Darin Adler.

Source/WebCore:

Drop [NoInterfaceObject] from the following SQL interfaces:
Database, SQLError, SQLResultSet, SQLResultSetRowList and SQLTransaction.

This matches the specification:
https://dev.w3.org/html5/webdatabase/

This was causing the 'constructor' property to be wrong for these
interfaces as it would be a generic Object.

Test: storage/websql/transaction-prototype.html

* Modules/webdatabase/Database.idl:
* Modules/webdatabase/SQLError.idl:
* Modules/webdatabase/SQLResultSet.idl:
* Modules/webdatabase/SQLResultSetRowList.idl:
* Modules/webdatabase/SQLTransaction.idl:

LayoutTests:

Rebaseline existing test now that more SQL constructors are exposed on the
global Window object. Also add a test to confirm that it is possible to
access SQLTransaction.constructor.prototype and that it seems correct.

* js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* storage/websql/transaction-prototype-expected.txt: Added.
* storage/websql/transaction-prototype.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/Database.idl
trunk/Source/WebCore/Modules/webdatabase/SQLError.idl
trunk/Source/WebCore/Modules/webdatabase/SQLResultSet.idl
trunk/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.idl
trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.idl


Added Paths

trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt
trunk/LayoutTests/storage/websql/transaction-prototype.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199941 => 199942)

--- trunk/LayoutTests/ChangeLog	2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/LayoutTests/ChangeLog	2016-04-23 00:58:01 UTC (rev 199942)
@@ -1,3 +1,21 @@
+2016-04-22  Chris Dumez  
+
+Cannot access the SQLTransaction.constructor.prototype
+https://bugs.webkit.org/show_bug.cgi?id=156613
+
+Reviewed by Darin Adler.
+
+Rebaseline existing test now that more SQL constructors are exposed on the
+global Window object. Also add a test to confirm that it is possible to
+access SQLTransaction.constructor.prototype and that it seems correct.
+
+* js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+* storage/websql/transaction-prototype-expected.txt: Added.
+* storage/websql/transaction-prototype.html: Added.
+
 2016-04-22  Joseph Pecoraro  
 
 Web Inspector: Source directives lost when using Function constructor repeatedly


Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt (199941 => 199942)

--- trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt	2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt	2016-04-23 00:58:01 UTC (rev 199942)
@@ -313,6 +313,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'Database').value is Database
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').value is DelayNode
 PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').hasOwnProperty('set') is false
@@ -1008,11 +1013,31 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Response').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 

[webkit-changes] [199940] trunk/Source/WebCore

[commit-queue]

Title: [199940] trunk/Source/WebCore








Revision 199940
Author commit-qu...@webkit.org
Date 2016-04-22 17:44:45 -0700 (Fri, 22 Apr 2016)


Log Message
Web Inspector: Include columnNumber in event listener locations
https://bugs.webkit.org/show_bug.cgi?id=156927


Patch by Joseph Pecoraro  on 2016-04-22
Reviewed by Brian Burg.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
Include the column number in the location as well.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199939 => 199940)

--- trunk/Source/WebCore/ChangeLog	2016-04-23 00:40:43 UTC (rev 199939)
+++ trunk/Source/WebCore/ChangeLog	2016-04-23 00:44:45 UTC (rev 199940)
@@ -1,3 +1,15 @@
+2016-04-22  Joseph Pecoraro  
+
+Web Inspector: Include columnNumber in event listener locations
+https://bugs.webkit.org/show_bug.cgi?id=156927
+
+
+Reviewed by Brian Burg.
+
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::buildObjectForEventListener):
+Include the column number in the location as well.
+
 2016-04-22  Brent Fulgham  
 
 [Win] Unreviewed build fix.


Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (199939 => 199940)

--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2016-04-23 00:40:43 UTC (rev 199939)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2016-04-23 00:44:45 UTC (rev 199940)
@@ -1466,6 +1466,7 @@
 JSC::JSObject* handler = nullptr;
 String body;
 int lineNumber = 0;
+int columnNumber = 0;
 String scriptID;
 String sourceName;
 if (auto scriptListener = JSEventListener::cast(eventListener.get())) {
@@ -1478,6 +1479,7 @@
 if (!function->isHostOrBuiltinFunction()) {
 if (auto executable = function->jsExecutable()) {
 lineNumber = executable->firstLine() - 1;
+columnNumber = executable->startColumn() - 1;
 scriptID = executable->sourceID() == JSC::SourceProvider::nullID ? emptyString() : String::number(executable->sourceID());
 sourceName = executable->sourceURL();
 }
@@ -1503,6 +1505,7 @@
 .setScriptId(scriptID)
 .setLineNumber(lineNumber)
 .release();
+location->setColumnNumber(columnNumber);
 value->setLocation(WTFMove(location));
 if (!sourceName.isEmpty())
 value->setSourceName(sourceName);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199939] trunk

[commit-queue]

Title: [199939] trunk








Revision 199939
Author commit-qu...@webkit.org
Date 2016-04-22 17:40:43 -0700 (Fri, 22 Apr 2016)


Log Message
Web Inspector: Source directives lost when using Function constructor repeatedly
https://bugs.webkit.org/show_bug.cgi?id=156863


Patch by Joseph Pecoraro  on 2016-04-22
Reviewed by Geoffrey Garen.

Source/_javascript_Core:

Source directives (sourceURL and sourceMappingURL) are normally accessed through
the SourceProvider and normally set when the script is parsed. However, when a
CodeCache lookup skips parsing, the new SourceProvider never gets the directives
(sourceURL/sourceMappingURL). This patch stores the directives on the UnlinkedCodeBlock
and UnlinkedFunctionExecutable when entering the cache, and copies to the new providers
when the cache is used.

* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::sourceURLDirective):
(JSC::UnlinkedCodeBlock::sourceMappingURLDirective):
(JSC::UnlinkedCodeBlock::setSourceURLDirective):
(JSC::UnlinkedCodeBlock::setSourceMappingURLDirective):
* bytecode/UnlinkedFunctionExecutable.h:
* parser/SourceProvider.h:
* runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
* runtime/CodeCache.h:
Store directives on the unlinked code block / executable when adding
to the cache, so they can be used to update new providers when the
cache gets used.

* runtime/JSGlobalObject.cpp:
Add needed header after CodeCache header cleanup.

LayoutTests:

* inspector/debugger/sourceURL-repeated-identical-executions-expected.txt: Added.
* inspector/debugger/sourceURL-repeated-identical-executions.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h
trunk/Source/_javascript_Core/parser/SourceProvider.h
trunk/Source/_javascript_Core/runtime/CodeCache.cpp
trunk/Source/_javascript_Core/runtime/CodeCache.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp


Added Paths

trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions-expected.txt
trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199938 => 199939)

--- trunk/LayoutTests/ChangeLog	2016-04-23 00:07:44 UTC (rev 199938)
+++ trunk/LayoutTests/ChangeLog	2016-04-23 00:40:43 UTC (rev 199939)
@@ -1,3 +1,14 @@
+2016-04-22  Joseph Pecoraro  
+
+Web Inspector: Source directives lost when using Function constructor repeatedly
+https://bugs.webkit.org/show_bug.cgi?id=156863
+
+
+Reviewed by Geoffrey Garen.
+
+* inspector/debugger/sourceURL-repeated-identical-executions-expected.txt: Added.
+* inspector/debugger/sourceURL-repeated-identical-executions.html: Added.
+
 2016-04-22  Mark Lam  
 
 _javascript_ jit bug affecting Google Maps.


Added: trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions-expected.txt (0 => 199939)

--- trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions-expected.txt	2016-04-23 00:40:43 UTC (rev 199939)
@@ -0,0 +1,13 @@
+Tests for the Debugger.scriptParsed messages for identical content should have source directives each time.
+
+
+== Running test suite: Debugger.scriptParsed.sourceURLRepeatedIdenticalExecutions
+-- Running test case: CheckFunctionConstructorMultipleTimes
+PASS: Should see 3 Scripts with sourceURL
+
+-- Running test case: CheckProgramMultipleTimes
+PASS: Should see 3 Scripts with sourceURL
+
+-- Running test case: CheckEvalMultipleTimes
+PASS: Should see 3 Scripts with sourceURL
+


Added: trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions.html (0 => 199939)

--- trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions.html	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/sourceURL-repeated-identical-executions.html	2016-04-23 00:40:43 UTC (rev 199939)
@@ -0,0 +1,92 @@
+
+
+
+
+function triggerFunctionConstructorMultipleTimes() {
+let sum = 0;
+sum += Function("\n//# sourceURL=test-Function-constructor.js\nreturn 1+1")();
+sum += Function("\n//# sourceURL=test-Function-constructor.js\nreturn 1+1")();
+sum += Function("\n//# sourceURL=test-Function-constructor.js\nreturn 1+1")();
+return sum;
+}
+
+function triggerProgramMultipleTimes() {
+for (let i = 0; i < 3; ++i) {
+let script = document.createElement("script");
+script.text = "\n//# sourceURL=test-program.js\n1+1";
+document.head.appendChild(script);
+}
+}
+
+function triggerEvalMultipleTimes() {
+let sum = 0;
+sum += eval("\n//# sourceURL=test-eval.js\n1+1");
+   

[webkit-changes] [199938] tags/Safari-601.1.46.128/

[bshafiei]

Title: [199938] tags/Safari-601.1.46.128/








Revision 199938
Author bshaf...@apple.com
Date 2016-04-22 17:07:44 -0700 (Fri, 22 Apr 2016)


Log Message
New tag.

Added Paths

tags/Safari-601.1.46.128/




Diff

Property changes: tags/Safari-601.1.46.128



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199937] tags/Safari-601.6.17/

[bshafiei]

Title: [199937] tags/Safari-601.6.17/








Revision 199937
Author bshaf...@apple.com
Date 2016-04-22 17:07:38 -0700 (Fri, 22 Apr 2016)


Log Message
New tag.

Added Paths

tags/Safari-601.6.17/




Diff

Property changes: tags/Safari-601.6.17



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199936] trunk/Source/bmalloc

[ggaren]

Title: [199936] trunk/Source/bmalloc








Revision 199936
Author gga...@apple.com
Date 2016-04-22 16:56:53 -0700 (Fri, 22 Apr 2016)


Log Message
bmalloc: vm allocations should plant guard pages
https://bugs.webkit.org/show_bug.cgi?id=156937

Reviewed by Michael Saboff.

* bmalloc/Object.h:
(bmalloc::Object::operator-): Added a - helper.

* bmalloc/VMAllocate.h:
(bmalloc::vmRevokePermissions): Added a helper to revoke permissions on
a VM region. We use this for guard pages.

* bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::allocateSmallChunk): Add guard pages to the start and
end of the chunk.

Note that we don't guard large chunks becuase we need to be able to merge
them. Otherwise, we will run out of virtual addresses.

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Object.h
trunk/Source/bmalloc/bmalloc/VMAllocate.h
trunk/Source/bmalloc/bmalloc/VMHeap.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (199935 => 199936)

--- trunk/Source/bmalloc/ChangeLog	2016-04-22 23:48:44 UTC (rev 199935)
+++ trunk/Source/bmalloc/ChangeLog	2016-04-22 23:56:53 UTC (rev 199936)
@@ -1,5 +1,26 @@
 2016-04-22  Geoffrey Garen  
 
+bmalloc: vm allocations should plant guard pages
+https://bugs.webkit.org/show_bug.cgi?id=156937
+
+Reviewed by Michael Saboff.
+
+* bmalloc/Object.h:
+(bmalloc::Object::operator-): Added a - helper.
+
+* bmalloc/VMAllocate.h:
+(bmalloc::vmRevokePermissions): Added a helper to revoke permissions on
+a VM region. We use this for guard pages.
+
+* bmalloc/VMHeap.cpp:
+(bmalloc::VMHeap::allocateSmallChunk): Add guard pages to the start and
+end of the chunk.
+
+Note that we don't guard large chunks becuase we need to be able to merge
+them. Otherwise, we will run out of virtual addresses.
+
+2016-04-22  Geoffrey Garen  
+
 bmalloc: Constify introspect function pointer table
 https://bugs.webkit.org/show_bug.cgi?id=156936
 


Modified: trunk/Source/bmalloc/bmalloc/Object.h (199935 => 199936)

--- trunk/Source/bmalloc/bmalloc/Object.h	2016-04-22 23:48:44 UTC (rev 199935)
+++ trunk/Source/bmalloc/bmalloc/Object.h	2016-04-22 23:56:53 UTC (rev 199936)
@@ -52,6 +52,7 @@
 SmallPage* page();
 
 Object operator+(size_t);
+Object operator-(size_t);
 bool operator<=(const Object&);
 
 private:
@@ -64,6 +65,11 @@
 return Object(m_chunk, m_offset + offset);
 }
 
+inline Object Object::operator-(size_t offset)
+{
+return Object(m_chunk, m_offset - offset);
+}
+
 inline bool Object::operator<=(const Object& other)
 {
 BASSERT(m_chunk == other.m_chunk);


Modified: trunk/Source/bmalloc/bmalloc/VMAllocate.h (199935 => 199936)

--- trunk/Source/bmalloc/bmalloc/VMAllocate.h	2016-04-22 23:48:44 UTC (rev 199935)
+++ trunk/Source/bmalloc/bmalloc/VMAllocate.h	2016-04-22 23:56:53 UTC (rev 199936)
@@ -137,6 +137,12 @@
 munmap(p, vmSize);
 }
 
+inline void vmRevokePermissions(void* p, size_t vmSize)
+{
+vmValidate(p, vmSize);
+mprotect(p, vmSize, PROT_NONE);
+}
+
 // Allocates vmSize bytes at a specified power-of-two alignment.
 // Use this function to create maskable memory regions.
 


Modified: trunk/Source/bmalloc/bmalloc/VMHeap.cpp (199935 => 199936)

--- trunk/Source/bmalloc/bmalloc/VMHeap.cpp	2016-04-22 23:48:44 UTC (rev 199935)
+++ trunk/Source/bmalloc/bmalloc/VMHeap.cpp	2016-04-22 23:56:53 UTC (rev 199936)
@@ -75,6 +75,12 @@
 Object begin(chunk, metadataSize);
 Object end(chunk, chunkSize);
 
+vmRevokePermissions(begin.begin(), pageSize);
+vmRevokePermissions(end.begin() - pageSize, pageSize);
+
+begin = begin + pageSize;
+end = end - pageSize;
+
 for (Object it = begin; it + pageSize <= end; it = it + pageSize) {
 SmallPage* page = it.page();
 new (page) SmallPage;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199935] trunk

[mark . lam]

Title: [199935] trunk








Revision 199935
Author mark@apple.com
Date 2016-04-22 16:48:44 -0700 (Fri, 22 Apr 2016)


Log Message
_javascript_ jit bug affecting Google Maps.
https://bugs.webkit.org/show_bug.cgi?id=153431

Reviewed by Filip Pizlo.

Source/_javascript_Core:

The issue was due to the abstract interpreter wrongly marking the type of the
value read from the Uint3Array as SpecInt52, which precludes it from being an
Int32.  This proves to be false, and the generated code failed to handle the case
where the read value is actually an Int32.

The fix is to have the abstract interpreter use SpecMachineInt instead of
SpecInt52.

* bytecode/SpeculatedType.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):

LayoutTests:

* js/regress/bug-153431-expected.txt: Added.
* js/regress/bug-153431.html: Added.
* js/regress/script-tests/bug-153431.js: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/SpeculatedType.h
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h


Added Paths

trunk/LayoutTests/js/regress/bug-153431-expected.txt
trunk/LayoutTests/js/regress/bug-153431.html
trunk/LayoutTests/js/regress/script-tests/bug-153431.js




Diff

Modified: trunk/LayoutTests/ChangeLog (199934 => 199935)

--- trunk/LayoutTests/ChangeLog	2016-04-22 23:25:54 UTC (rev 199934)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 23:48:44 UTC (rev 199935)
@@ -1,3 +1,14 @@
+2016-04-22  Mark Lam  
+
+_javascript_ jit bug affecting Google Maps.
+https://bugs.webkit.org/show_bug.cgi?id=153431
+
+Reviewed by Filip Pizlo.
+
+* js/regress/bug-153431-expected.txt: Added.
+* js/regress/bug-153431.html: Added.
+* js/regress/script-tests/bug-153431.js: Added.
+
 2016-04-22  Geoffrey Garen  
 
 super should be available in object literals


Added: trunk/LayoutTests/js/regress/bug-153431-expected.txt (0 => 199935)

--- trunk/LayoutTests/js/regress/bug-153431-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/regress/bug-153431-expected.txt	2016-04-22 23:48:44 UTC (rev 199935)
@@ -0,0 +1,10 @@
+JSRegress/bug-153431
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/js/regress/bug-153431.html (0 => 199935)

--- trunk/LayoutTests/js/regress/bug-153431.html	(rev 0)
+++ trunk/LayoutTests/js/regress/bug-153431.html	2016-04-22 23:48:44 UTC (rev 199935)
@@ -0,0 +1,12 @@
+
+
+

[webkit-changes] [199934] trunk/Source/bmalloc

[ggaren]

Title: [199934] trunk/Source/bmalloc








Revision 199934
Author gga...@apple.com
Date 2016-04-22 16:25:54 -0700 (Fri, 22 Apr 2016)


Log Message
bmalloc: Constify introspect function pointer table
https://bugs.webkit.org/show_bug.cgi?id=156936

Reviewed by Michael Saboff.

* bmalloc/Zone.cpp:
(bmalloc::Zone::Zone): Declaring this function pointer table const puts
it in the read-only section of the binary, providing a little hardening
against overwriting the function pointers at runtime. (We have to
const_cast when assigning because the API declares a pointer to non-const,
but we happen to know it will never try to write through that pointer.
This is not my favorite API.)

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Zone.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (199933 => 199934)

--- trunk/Source/bmalloc/ChangeLog	2016-04-22 23:10:27 UTC (rev 199933)
+++ trunk/Source/bmalloc/ChangeLog	2016-04-22 23:25:54 UTC (rev 199934)
@@ -1,3 +1,18 @@
+2016-04-22  Geoffrey Garen  
+
+bmalloc: Constify introspect function pointer table
+https://bugs.webkit.org/show_bug.cgi?id=156936
+
+Reviewed by Michael Saboff.
+
+* bmalloc/Zone.cpp:
+(bmalloc::Zone::Zone): Declaring this function pointer table const puts
+it in the read-only section of the binary, providing a little hardening
+against overwriting the function pointers at runtime. (We have to
+const_cast when assigning because the API declares a pointer to non-const,
+but we happen to know it will never try to write through that pointer.
+This is not my favorite API.)
+
 2016-04-19  Geoffrey Garen  
 
 bmalloc: fix up overflow checks


Modified: trunk/Source/bmalloc/bmalloc/Zone.cpp (199933 => 199934)

--- trunk/Source/bmalloc/bmalloc/Zone.cpp	2016-04-22 23:10:27 UTC (rev 199933)
+++ trunk/Source/bmalloc/bmalloc/Zone.cpp	2016-04-22 23:25:54 UTC (rev 199934)
@@ -104,7 +104,7 @@
 // The memory analysis API requires the contents of this struct to be a static
 // constant in the program binary. The leaks process will load this struct
 // out of the program binary (and not out of the running process).
-static malloc_introspection_t zoneIntrospect = {
+static const malloc_introspection_t zoneIntrospect = {
 .enumerator = bmalloc::enumerator,
 .good_size = bmalloc::good_size,
 .check = bmalloc::check,
@@ -119,7 +119,7 @@
 {
 malloc_zone_t::size = ::zoneSize;
 malloc_zone_t::zone_name = "WebKit Malloc";
-malloc_zone_t::introspect = ::zoneIntrospect;
+malloc_zone_t::introspect = const_cast(::zoneIntrospect);
 malloc_zone_t::version = 4;
 malloc_zone_register(this);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199930] tags/Safari-602.1.29/Source/WebCore

[bshafiei]

Title: [199930] tags/Safari-602.1.29/Source/WebCore








Revision 199930
Author bshaf...@apple.com
Date 2016-04-22 16:08:15 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199915.

Modified Paths

tags/Safari-602.1.29/Source/WebCore/ChangeLog
tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp




Diff

Modified: tags/Safari-602.1.29/Source/WebCore/ChangeLog (199929 => 199930)

--- tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:07:15 UTC (rev 199929)
+++ tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:08:15 UTC (rev 199930)
@@ -1,5 +1,16 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199915.
+
+2016-04-22  Brent Fulgham  
+
+[Win] Unreviewed build fix.
+
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayerWin::isHidden):
+
+2016-04-22  Babak Shafiei  
+
 Merge r199885.
 
 2016-04-22  Brady Eidson  


Modified: tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (199929 => 199930)

--- tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 23:07:15 UTC (rev 199929)
+++ tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 23:08:15 UTC (rev 199930)
@@ -437,7 +437,7 @@
 setNeedsCommit();
 }
 
-bool PlatformCALayerWin::isHidden(bool value) const
+bool PlatformCALayerWin::isHidden() const
 {
 return CACFLayerIsHidden(m_layer.get());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199932] tags/Safari-602.1.29/Source/WebKit2

[bshafiei]

Title: [199932] tags/Safari-602.1.29/Source/WebKit2








Revision 199932
Author bshaf...@apple.com
Date 2016-04-22 16:10:08 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199919.

Modified Paths

tags/Safari-602.1.29/Source/WebKit2/ChangeLog
tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in
tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in




Diff

Modified: tags/Safari-602.1.29/Source/WebKit2/ChangeLog (199931 => 199932)

--- tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 23:09:21 UTC (rev 199931)
+++ tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 23:10:08 UTC (rev 199932)
@@ -1,5 +1,18 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199919.
+
+2016-04-22  Ryan Haddad  
+
+Fixing a typo in my last commit.
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
+* WebProcess/cocoa/WebVideoFullscreenManager.messages.in:
+
+2016-04-22  Babak Shafiei  
+
 Merge r199917.
 
 2016-04-22  Ryan Haddad  


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in (199931 => 199932)

--- tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 23:09:21 UTC (rev 199931)
+++ tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 23:10:08 UTC (rev 199932)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManagerProxy {
 SetVideoDimensions(uint64_t contextId, bool hasVideo, unsigned width, unsigned height)
 SetupFullscreenWithID(uint64_t contextId, uint32_t videoLayerID, WebCore::IntRect initialRect, float hostingScaleFactor, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode, bool allowsPictureInPicture)


Modified: tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in (199931 => 199932)

--- tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 23:09:21 UTC (rev 199931)
+++ tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 23:10:08 UTC (rev 199932)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManager {
 RequestFullscreenMode(uint64_t contextId, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode)
 DidSetupFullscreen(uint64_t contextId)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199927] trunk

[ggaren]

Title: [199927] trunk








Revision 199927
Author gga...@apple.com
Date 2016-04-22 16:04:55 -0700 (Fri, 22 Apr 2016)


Log Message
super should be available in object literals
https://bugs.webkit.org/show_bug.cgi?id=156933

Reviewed by Saam Barati.

Source/_javascript_Core:

When we originally implemented classes, super seemed to be a class-only
feature. But the final spec says it's available in object literals too.

* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode): Having 'super' and being a class
property are no longer synonymous, so we track two separate variables.

(JSC::PropertyListNode::emitPutConstantProperty): Being inside the super
branch no longer guarantees that you're a class property, so we decide
our attributes and our function name dynamically.

* parser/ASTBuilder.h:
(JSC::ASTBuilder::createArrowFunctionExpr):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::createPropertyList): Pass through state to indicate
whether we're a class property, since we can't infer it from 'super'
anymore.

* parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode): See ASTBuilder.h.

* parser/Nodes.h:
(JSC::PropertyNode::expressionName):
(JSC::PropertyNode::name):
(JSC::PropertyNode::type):
(JSC::PropertyNode::needsSuperBinding):
(JSC::PropertyNode::isClassProperty):
(JSC::PropertyNode::putType): See ASTBuilder.h.

* parser/Parser.cpp:
(JSC::Parser::parseFunctionInfo):
(JSC::Parser::parseClass):
(JSC::Parser::parseProperty):
(JSC::Parser::parsePropertyMethod):
(JSC::Parser::parseGetterSetter):
(JSC::Parser::parseMemberExpression): I made these error
messages generic because it is no longer practical to say concise things
about the list of places you can use super.

* parser/Parser.h:

* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::appendExportSpecifier):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty): Updated for
interface change.

* tests/stress/generator-with-super.js:
(test):
* tests/stress/modules-syntax-error.js:
* tests/stress/super-in-lexical-scope.js:
(testSyntaxError):
(testSyntaxError.test):
* tests/stress/tagged-templates-syntax.js: Updated for error message
changes. See Parser.cpp.

LayoutTests:

Updated expected results and added a few new tests.

* js/arrowfunction-syntax-errors-expected.txt:
* js/class-syntax-super-expected.txt:
* js/object-literal-methods-expected.txt:
* js/script-tests/arrowfunction-syntax-errors.js:
* js/script-tests/class-syntax-super.js:
* js/script-tests/object-literal-methods.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/arrowfunction-syntax-errors-expected.txt
trunk/LayoutTests/js/class-syntax-super-expected.txt
trunk/LayoutTests/js/object-literal-methods-expected.txt
trunk/LayoutTests/js/script-tests/arrowfunction-syntax-errors.js
trunk/LayoutTests/js/script-tests/class-syntax-super.js
trunk/LayoutTests/js/script-tests/object-literal-methods.js
trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/parser/ASTBuilder.h
trunk/Source/_javascript_Core/parser/NodeConstructors.h
trunk/Source/_javascript_Core/parser/Nodes.h
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/parser/SyntaxChecker.h
trunk/Source/_javascript_Core/tests/stress/generator-with-super.js
trunk/Source/_javascript_Core/tests/stress/modules-syntax-error.js
trunk/Source/_javascript_Core/tests/stress/super-in-lexical-scope.js
trunk/Source/_javascript_Core/tests/stress/tagged-templates-syntax.js




Diff

Modified: trunk/LayoutTests/ChangeLog (199926 => 199927)

--- trunk/LayoutTests/ChangeLog	2016-04-22 23:04:35 UTC (rev 199926)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 23:04:55 UTC (rev 199927)
@@ -1,3 +1,19 @@
+2016-04-22  Geoffrey Garen  
+
+super should be available in object literals
+https://bugs.webkit.org/show_bug.cgi?id=156933
+
+Reviewed by Saam Barati.
+
+Updated expected results and added a few new tests.
+
+* js/arrowfunction-syntax-errors-expected.txt:
+* js/class-syntax-super-expected.txt:
+* js/object-literal-methods-expected.txt:
+* js/script-tests/arrowfunction-syntax-errors.js:
+* js/script-tests/class-syntax-super.js:
+* js/script-tests/object-literal-methods.js:
+
 2016-04-22  Ryan Haddad  
 
 Rebaselining inspector/model/stack-trace.html after r199897


Modified: trunk/LayoutTests/js/arrowfunction-syntax-errors-expected.txt (199926 => 199927)

--- 

[webkit-changes] [199933] trunk/Source/JavaScriptCore

[commit-queue]

Title: [199933] trunk/Source/_javascript_Core








Revision 199933
Author commit-qu...@webkit.org
Date 2016-04-22 16:10:27 -0700 (Fri, 22 Apr 2016)


Log Message
[JSC] PredictionPropagation should not be in the top 5 heaviest phases
https://bugs.webkit.org/show_bug.cgi?id=156891

Patch by Benjamin Poulain  on 2016-04-22
Reviewed by Mark Lam.

In DFG, PredictionPropagation is often way too high in profiles.
It is a simple phase, it should not be that hot.

Most of the time is spent accessing memory. This patch attempts
to reduce that.

First, propagate() is split in processInvariants() and propagates().
The step processInvariants() sets all the types for nodes for which
the type does not depends on other nodes.

Adding processInvariants() lowers two hotspot inside PredictionPropagation:
speculationFromValue() and setPrediction().

Next, to avoid touching all the nodes at every operation, we keep
track of the nodes that actually need propagate().
The vector m_dependentNodes keeps the list of those nodes and propagate()
only need to process them at each phase.

This is a smaller gain because growing m_dependentNodes negates
some of the gains.

On 3d-cube, this moves PredictionPropagation from fifth position
to ninth. A lot of the remaining overhead is caused by double-voting
and cannot be fixed by moving stuff around.

* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagateToFixpoint): Deleted.
(JSC::DFG::PredictionPropagationPhase::propagate): Deleted.
(JSC::DFG::PredictionPropagationPhase::propagateForward): Deleted.
(JSC::DFG::PredictionPropagationPhase::propagateBackward): Deleted.
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting): Deleted.
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting): Deleted.
(JSC::DFG::PredictionPropagationPhase::propagateThroughArgumentPositions): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (199932 => 199933)

--- trunk/Source/_javascript_Core/ChangeLog	2016-04-22 23:10:08 UTC (rev 199932)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-22 23:10:27 UTC (rev 199933)
@@ -1,3 +1,44 @@
+2016-04-22  Benjamin Poulain  
+
+[JSC] PredictionPropagation should not be in the top 5 heaviest phases
+https://bugs.webkit.org/show_bug.cgi?id=156891
+
+Reviewed by Mark Lam.
+
+In DFG, PredictionPropagation is often way too high in profiles.
+It is a simple phase, it should not be that hot.
+
+Most of the time is spent accessing memory. This patch attempts
+to reduce that.
+
+First, propagate() is split in processInvariants() and propagates().
+The step processInvariants() sets all the types for nodes for which
+the type does not depends on other nodes.
+
+Adding processInvariants() lowers two hotspot inside PredictionPropagation:
+speculationFromValue() and setPrediction().
+
+Next, to avoid touching all the nodes at every operation, we keep
+track of the nodes that actually need propagate().
+The vector m_dependentNodes keeps the list of those nodes and propagate()
+only need to process them at each phase.
+
+This is a smaller gain because growing m_dependentNodes negates
+some of the gains.
+
+On 3d-cube, this moves PredictionPropagation from fifth position
+to ninth. A lot of the remaining overhead is caused by double-voting
+and cannot be fixed by moving stuff around.
+
+* dfg/DFGPredictionPropagationPhase.cpp:
+(JSC::DFG::PredictionPropagationPhase::propagateToFixpoint): Deleted.
+(JSC::DFG::PredictionPropagationPhase::propagate): Deleted.
+(JSC::DFG::PredictionPropagationPhase::propagateForward): Deleted.
+(JSC::DFG::PredictionPropagationPhase::propagateBackward): Deleted.
+(JSC::DFG::PredictionPropagationPhase::doDoubleVoting): Deleted.
+(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting): Deleted.
+(JSC::DFG::PredictionPropagationPhase::propagateThroughArgumentPositions): Deleted.
+
 2016-04-22  Geoffrey Garen  
 
 super should be available in object literals


Modified: trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp (199932 => 199933)

--- trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp	2016-04-22 23:10:08 UTC (rev 199932)
+++ trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp	2016-04-22 23:10:27 UTC (rev 199933)
@@ -34,6 +34,10 @@
 
 namespace JSC { namespace DFG {
 
+namespace {
+
+bool verboseFixPointLoops = false;
+
 class PredictionPropagationPhase : public Phase {
 public:
 PredictionPropagationPhase(Graph& graph)
@@ -48,6 +52,8 @@
 
 propagateThroughArgumentPositions();
 
+processInvariants();
+
  

[webkit-changes] [199931] tags/Safari-602.1.29/Source/WebKit2

[bshafiei]

Title: [199931] tags/Safari-602.1.29/Source/WebKit2








Revision 199931
Author bshaf...@apple.com
Date 2016-04-22 16:09:21 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199917.

Modified Paths

tags/Safari-602.1.29/Source/WebKit2/ChangeLog
tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in
tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in




Diff

Modified: tags/Safari-602.1.29/Source/WebKit2/ChangeLog (199930 => 199931)

--- tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 23:08:15 UTC (rev 199930)
+++ tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 23:09:21 UTC (rev 199931)
@@ -1,5 +1,18 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199917.
+
+2016-04-22  Ryan Haddad  
+
+Missed some macros to fix builds that do not support AVKit.
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
+* WebProcess/cocoa/WebVideoFullscreenManager.messages.in:
+
+2016-04-22  Babak Shafiei  
+
 Merge r199914.
 
 2016-04-22  Ryan Haddad  


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in (199930 => 199931)

--- tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 23:08:15 UTC (rev 199930)
+++ tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 23:09:21 UTC (rev 199931)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManagerProxy {
 SetVideoDimensions(uint64_t contextId, bool hasVideo, unsigned width, unsigned height)
 SetupFullscreenWithID(uint64_t contextId, uint32_t videoLayerID, WebCore::IntRect initialRect, float hostingScaleFactor, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode, bool allowsPictureInPicture)


Modified: tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in (199930 => 199931)

--- tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 23:08:15 UTC (rev 199930)
+++ tags/Safari-602.1.29/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 23:09:21 UTC (rev 199931)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManager {
 RequestFullscreenMode(uint64_t contextId, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode)
 DidSetupFullscreen(uint64_t contextId)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199929] tags/Safari-602.1.29/Source/WebCore

[bshafiei]

Title: [199929] tags/Safari-602.1.29/Source/WebCore








Revision 199929
Author bshaf...@apple.com
Date 2016-04-22 16:07:15 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199885.

Modified Paths

tags/Safari-602.1.29/Source/WebCore/ChangeLog
tags/Safari-602.1.29/Source/WebCore/workers/WorkerMessagingProxy.cpp




Diff

Modified: tags/Safari-602.1.29/Source/WebCore/ChangeLog (199928 => 199929)

--- tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:05:37 UTC (rev 199928)
+++ tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:07:15 UTC (rev 199929)
@@ -1,5 +1,16 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199885.
+
+2016-04-22  Brady Eidson  
+
+Attempt at a Windows build fix.
+
+* workers/WorkerMessagingProxy.cpp:
+(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
+
+2016-04-22  Babak Shafiei  
+
 Merge r199912.
 
 2016-04-22  Jer Noble  


Modified: tags/Safari-602.1.29/Source/WebCore/workers/WorkerMessagingProxy.cpp (199928 => 199929)

--- tags/Safari-602.1.29/Source/WebCore/workers/WorkerMessagingProxy.cpp	2016-04-22 23:05:37 UTC (rev 199928)
+++ tags/Safari-602.1.29/Source/WebCore/workers/WorkerMessagingProxy.cpp	2016-04-22 23:07:15 UTC (rev 199929)
@@ -78,7 +78,12 @@
 ASSERT(m_scriptExecutionContext);
 Document& document = downcast(*m_scriptExecutionContext);
 
+#if ENABLE(INDEXED_DATABASE)
 RefPtr thread = DedicatedWorkerThread::create(scriptURL, userAgent, sourceCode, *this, *this, startMode, contentSecurityPolicyResponseHeaders, shouldBypassMainWorldContentSecurityPolicy, document.topOrigin(), document.idbConnectionProxy());
+#else
+RefPtr thread = DedicatedWorkerThread::create(scriptURL, userAgent, sourceCode, *this, *this, startMode, contentSecurityPolicyResponseHeaders, shouldBypassMainWorldContentSecurityPolicy, document.topOrigin(), nullptr);
+#endif
+
 workerThreadCreated(thread);
 thread->start();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199928] tags/Safari-602.1.29/Source/WebKit2

[bshafiei]

Title: [199928] tags/Safari-602.1.29/Source/WebKit2








Revision 199928
Author bshaf...@apple.com
Date 2016-04-22 16:05:37 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199914.

Modified Paths

tags/Safari-602.1.29/Source/WebKit2/ChangeLog
tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.h




Diff

Modified: tags/Safari-602.1.29/Source/WebKit2/ChangeLog (199927 => 199928)

--- tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 23:04:55 UTC (rev 199927)
+++ tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 23:05:37 UTC (rev 199928)
@@ -1,5 +1,17 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199914.
+
+2016-04-22  Ryan Haddad  
+
+Fix builds that do not support AVKit
+
+Unreviewed build fix.
+
+* UIProcess/WebPageProxy.h:
+
+2016-04-22  Babak Shafiei  
+
 Merge r199903.
 
 2016-04-22  Ryan Haddad  


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.h (199927 => 199928)

--- tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.h	2016-04-22 23:04:55 UTC (rev 199927)
+++ tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.h	2016-04-22 23:05:37 UTC (rev 199928)
@@ -1551,7 +1551,7 @@
 #if ENABLE(FULLSCREEN_API)
 RefPtr m_fullScreenManager;
 #endif
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 RefPtr m_playbackSessionManager;
 RefPtr m_videoFullscreenManager;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199926] tags/Safari-602.1.29/Source/WebCore

[bshafiei]

Title: [199926] tags/Safari-602.1.29/Source/WebCore








Revision 199926
Author bshaf...@apple.com
Date 2016-04-22 16:04:35 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199912.  rdar://problem/25865315

Modified Paths

tags/Safari-602.1.29/Source/WebCore/ChangeLog
tags/Safari-602.1.29/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm




Diff

Modified: tags/Safari-602.1.29/Source/WebCore/ChangeLog (199925 => 199926)

--- tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:03:42 UTC (rev 199925)
+++ tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:04:35 UTC (rev 199926)
@@ -1,5 +1,22 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199912.
+
+2016-04-22  Jer Noble  
+
+[iOS] Crash at -[WebAVPlayerLayer resolveBounds]
+https://bugs.webkit.org/show_bug.cgi?id=156931
+ 
+
+Reviewed by Eric Carlson.
+
+When cloning the WebAVPlayerLayer, we must copy over the fullscreenInterface to the cloned layer.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
+
+2016-04-22  Babak Shafiei  
+
 Merge r199904.
 
 2016-04-22  Dean Jackson  


Modified: tags/Safari-602.1.29/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (199925 => 199926)

--- tags/Safari-602.1.29/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-22 23:03:42 UTC (rev 199925)
+++ tags/Safari-602.1.29/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-22 23:04:35 UTC (rev 199926)
@@ -458,6 +458,7 @@
 [pipPlayerLayer setVideoGravity:playerLayer.videoGravity];
 [pipPlayerLayer setModelVideoLayerFrame:playerLayer.modelVideoLayerFrame];
 [pipPlayerLayer setPlayerController:playerLayer.playerController];
+[pipPlayerLayer setFullscreenInterface:playerLayer.fullscreenInterface];
 [pipView addSubview:playerLayerView.videoView];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199925] tags/Safari-602.1.29/Source/WebKit

[bshafiei]

Title: [199925] tags/Safari-602.1.29/Source/WebKit








Revision 199925
Author bshaf...@apple.com
Date 2016-04-22 16:03:42 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199908.

Modified Paths

tags/Safari-602.1.29/Source/WebKit/ChangeLog
tags/Safari-602.1.29/Source/WebKit/PlatformWin.cmake
tags/Safari-602.1.29/Source/WebKit/win/ChangeLog
tags/Safari-602.1.29/Source/WebKit/win/WebApplicationCache.cpp




Diff

Modified: tags/Safari-602.1.29/Source/WebKit/ChangeLog (199924 => 199925)

--- tags/Safari-602.1.29/Source/WebKit/ChangeLog	2016-04-22 23:02:42 UTC (rev 199924)
+++ tags/Safari-602.1.29/Source/WebKit/ChangeLog	2016-04-22 23:03:42 UTC (rev 199925)
@@ -1,3 +1,13 @@
+2016-04-22  Babak Shafiei  
+
+Merge r199908.
+
+2016-04-22  Brent Fulgham  
+
+Unreviewed build fix after r199841.
+
+* PlatformWin.cmake: Add missing WebApplicationCache.cpp buid directive.
+
 2016-04-11  Fujii Hironori  
 
 [CMake] Make FOLDER property INHERITED


Modified: tags/Safari-602.1.29/Source/WebKit/PlatformWin.cmake (199924 => 199925)

--- tags/Safari-602.1.29/Source/WebKit/PlatformWin.cmake	2016-04-22 23:02:42 UTC (rev 199924)
+++ tags/Safari-602.1.29/Source/WebKit/PlatformWin.cmake	2016-04-22 23:03:42 UTC (rev 199925)
@@ -83,6 +83,7 @@
 win/MemoryStream.h
 win/ProgIDMacros.h
 win/WebActionPropertyBag.h
+win/WebApplicationCache.h
 win/WebArchive.h
 win/WebBackForwardList.h
 win/WebCache.h
@@ -154,6 +155,7 @@
 win/MarshallingHelpers.cpp
 win/MemoryStream.cpp
 win/WebActionPropertyBag.cpp
+win/WebApplicationCache.cpp
 win/WebArchive.cpp
 win/WebBackForwardList.cpp
 win/WebCache.cpp


Modified: tags/Safari-602.1.29/Source/WebKit/win/ChangeLog (199924 => 199925)

--- tags/Safari-602.1.29/Source/WebKit/win/ChangeLog	2016-04-22 23:02:42 UTC (rev 199924)
+++ tags/Safari-602.1.29/Source/WebKit/win/ChangeLog	2016-04-22 23:03:42 UTC (rev 199925)
@@ -1,3 +1,14 @@
+2016-04-22  Babak Shafiei  
+
+Merge r199908.
+
+2016-04-22  Brent Fulgham  
+
+Unreviewed build fix after 4199841.
+
+* WebApplicationCache.cpp:
+(WebApplicationCache::WebApplicationCache): Provide missing preference key definition.
+
 2016-04-21  Anders Carlsson  
 
 Add a missing space, as noticed by Darin.


Modified: tags/Safari-602.1.29/Source/WebKit/win/WebApplicationCache.cpp (199924 => 199925)

--- tags/Safari-602.1.29/Source/WebKit/win/WebApplicationCache.cpp	2016-04-22 23:02:42 UTC (rev 199924)
+++ tags/Safari-602.1.29/Source/WebKit/win/WebApplicationCache.cpp	2016-04-22 23:03:42 UTC (rev 199925)
@@ -33,9 +33,14 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
+using namespace WebCore;
+
+static CFStringRef WebKitLocalCacheDefaultsKey = CFSTR("WebKitLocalCache");
+
 // WebApplicationCache ---
 
 WebApplicationCache::WebApplicationCache()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199924] tags/Safari-602.1.29/Source/WebCore

[bshafiei]

Title: [199924] tags/Safari-602.1.29/Source/WebCore








Revision 199924
Author bshaf...@apple.com
Date 2016-04-22 16:02:42 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199904.

Modified Paths

tags/Safari-602.1.29/Source/WebCore/ChangeLog
tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp




Diff

Modified: tags/Safari-602.1.29/Source/WebCore/ChangeLog (199923 => 199924)

--- tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:02:10 UTC (rev 199923)
+++ tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:02:42 UTC (rev 199924)
@@ -1,5 +1,17 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199904.
+
+2016-04-22  Dean Jackson  
+
+Yet another attempt at fixing Windows.
+
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayerWin::isHidden):
+* platform/graphics/ca/win/PlatformCALayerWin.h:
+
+2016-04-22  Babak Shafiei  
+
 Merge r199886.
 
 2016-04-22  Dean Jackson  


Modified: tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (199923 => 199924)

--- tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 23:02:10 UTC (rev 199923)
+++ tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 23:02:42 UTC (rev 199924)
@@ -439,7 +439,7 @@
 
 bool PlatformCALayerWin::isHidden(bool value) const
 {
-return CACFLayerGetHidden(m_layer.get());
+return CACFLayerIsHidden(m_layer.get());
 }
 
 void PlatformCALayerWin::setHidden(bool value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199922] tags/Safari-602.1.29/Source/WebCore

[bshafiei]

Title: [199922] tags/Safari-602.1.29/Source/WebCore








Revision 199922
Author bshaf...@apple.com
Date 2016-04-22 16:01:56 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199886.

Modified Paths

tags/Safari-602.1.29/Source/WebCore/ChangeLog
tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp




Diff

Modified: tags/Safari-602.1.29/Source/WebCore/ChangeLog (199921 => 199922)

--- tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 22:58:24 UTC (rev 199921)
+++ tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 23:01:56 UTC (rev 199922)
@@ -1,5 +1,16 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199886.
+
+2016-04-22  Dean Jackson  
+
+Attempting to fix Windows build. Add isHidden implementation.
+
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayerWin::isHidden):
+
+2016-04-22  Babak Shafiei  
+
 Merge r199902.
 
 2016-04-22  Ryan Haddad  


Modified: tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (199921 => 199922)

--- tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 22:58:24 UTC (rev 199921)
+++ tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 23:01:56 UTC (rev 199922)
@@ -437,6 +437,11 @@
 setNeedsCommit();
 }
 
+bool PlatformCALayerWin::isHidden(bool value) const
+{
+return CACFLayerGetHidden(m_layer.get());
+}
+
 void PlatformCALayerWin::setHidden(bool value)
 {
 CACFLayerSetHidden(m_layer.get(), value);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199923] branches/safari-601-branch/LayoutTests/http/tests/svg

[matthew_hanson]

Title: [199923] branches/safari-601-branch/LayoutTests/http/tests/svg








Revision 199923
Author matthew_han...@apple.com
Date 2016-04-22 16:02:10 -0700 (Fri, 22 Apr 2016)


Log Message
Merge LayoutTests for r199881. rdar://problem/25879498

Added Paths

branches/safari-601-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg
branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt
branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external.html




Diff

Added: branches/safari-601-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg (0 => 199923)

--- branches/safari-601-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg	(rev 0)
+++ branches/safari-601-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg	2016-04-22 23:02:10 UTC (rev 199923)
@@ -0,0 +1,28 @@
+
+
+
+rocket
+
+
+
+fire
+
+
+
+lab
+
+
+
+magnet
+
+
+
+shield
+
+
+
+power
+
+
+
+
Property changes on: branches/safari-601-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg
___


Added: svn:executable

Added: branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt (0 => 199923)

--- branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt	(rev 0)
+++ branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt	2016-04-22 23:02:10 UTC (rev 199923)
@@ -0,0 +1,5 @@
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - willSendRequest  redirectResponse (null)
+http://127.0.0.1:8000/svg/svg-use-external.html - didFinishLoading
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - didReceiveResponse 
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - didFinishLoading
+   


Added: branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external.html (0 => 199923)

--- branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external.html	(rev 0)
+++ branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external.html	2016-04-22 23:02:10 UTC (rev 199923)
@@ -0,0 +1,44 @@
+
+
+
+
+
+
+Verify that the SVG use resource only loads once
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.dumpResourceLoadCallbacks();
+testRunner.waitUntilDone();
+_onload_ = function() {
+testRunner.notifyDone();
+}
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Property changes on: branches/safari-601-branch/LayoutTests/http/tests/svg/svg-use-external.html
___


Added: svn:executable




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199921] tags/Safari-602.1.29/Source/WebKit2

[bshafiei]

Title: [199921] tags/Safari-602.1.29/Source/WebKit2








Revision 199921
Author bshaf...@apple.com
Date 2016-04-22 15:58:24 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199903.

Modified Paths

tags/Safari-602.1.29/Source/WebKit2/ChangeLog
tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h
tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: tags/Safari-602.1.29/Source/WebKit2/ChangeLog (199920 => 199921)

--- tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 22:57:42 UTC (rev 199920)
+++ tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 22:58:24 UTC (rev 199921)
@@ -1,5 +1,19 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199903.
+
+2016-04-22  Ryan Haddad  
+
+Take 2 for fixing builds that do not support AVKit
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::resetState):
+
+2016-04-22  Babak Shafiei  
+
 Merge r199896.
 
 2016-04-22  Ryan Haddad  


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h (199920 => 199921)

--- tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 22:57:42 UTC (rev 199920)
+++ tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 22:58:24 UTC (rev 199921)
@@ -26,7 +26,7 @@
 #ifndef WebVideoFullscreenManagerProxy_h
 #define WebVideoFullscreenManagerProxy_h
 
-#if PLATFORM(IOS) && HAVE(AVKIT) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 
 #include "MessageReceiver.h"
 #include 


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.cpp (199920 => 199921)

--- tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-04-22 22:57:42 UTC (rev 199920)
+++ tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-04-22 22:58:24 UTC (rev 199921)
@@ -5082,7 +5082,7 @@
 
 m_visibleScrollerThumbRect = IntRect();
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 if (m_playbackSessionManager) {
 m_playbackSessionManager->invalidate();
 m_playbackSessionManager = nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199920] tags/Safari-602.1.29/Source/WebCore

[bshafiei]

Title: [199920] tags/Safari-602.1.29/Source/WebCore








Revision 199920
Author bshaf...@apple.com
Date 2016-04-22 15:57:42 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199902.

Modified Paths

tags/Safari-602.1.29/Source/WebCore/ChangeLog
tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h




Diff

Modified: tags/Safari-602.1.29/Source/WebCore/ChangeLog (199919 => 199920)

--- tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 22:46:54 UTC (rev 199919)
+++ tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 22:57:42 UTC (rev 199920)
@@ -1,5 +1,17 @@
 2016-04-22  Babak Shafiei  
 
+Merge r199902.
+
+2016-04-22  Ryan Haddad  
+
+Attempt to fix Windows build after r199862
+
+Unreviewed build fix.
+
+* platform/graphics/ca/win/PlatformCALayerWin.h:
+
+2016-04-22  Babak Shafiei  
+
 Merge r199896.
 
 2016-04-22  Ryan Haddad  


Modified: tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h (199919 => 199920)

--- tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2016-04-22 22:46:54 UTC (rev 199919)
+++ tags/Safari-602.1.29/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2016-04-22 22:57:42 UTC (rev 199920)
@@ -79,6 +79,7 @@
 TransformationMatrix sublayerTransform() const override;
 void setSublayerTransform(const TransformationMatrix&) override;
 
+bool isHidden() const override;
 void setHidden(bool) override;
 
 void setBackingStoreAttached(bool) override;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199919] trunk/Source/WebKit2

[ryanhaddad]

Title: [199919] trunk/Source/WebKit2








Revision 199919
Author ryanhad...@apple.com
Date 2016-04-22 15:46:54 -0700 (Fri, 22 Apr 2016)


Log Message
Fixing a typo in my last commit.

Unreviewed build fix.

* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
* WebProcess/cocoa/WebVideoFullscreenManager.messages.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in
trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (199918 => 199919)

--- trunk/Source/WebKit2/ChangeLog	2016-04-22 22:46:18 UTC (rev 199918)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-22 22:46:54 UTC (rev 199919)
@@ -1,5 +1,14 @@
 2016-04-22  Ryan Haddad  
 
+Fixing a typo in my last commit.
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
+* WebProcess/cocoa/WebVideoFullscreenManager.messages.in:
+
+2016-04-22  Ryan Haddad  
+
 Missed some macros to fix builds that do not support AVKit.
 
 Unreviewed build fix.


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in (199918 => 199919)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 22:46:18 UTC (rev 199918)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 22:46:54 UTC (rev 199919)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManagerProxy {
 SetVideoDimensions(uint64_t contextId, bool hasVideo, unsigned width, unsigned height)
 SetupFullscreenWithID(uint64_t contextId, uint32_t videoLayerID, WebCore::IntRect initialRect, float hostingScaleFactor, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode, bool allowsPictureInPicture)


Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in (199918 => 199919)

--- trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 22:46:18 UTC (rev 199918)
+++ trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 22:46:54 UTC (rev 199919)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManager {
 RequestFullscreenMode(uint64_t contextId, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode)
 DidSetupFullscreen(uint64_t contextId)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199918] trunk/Source/JavaScriptCore

[fpizlo]

Title: [199918] trunk/Source/_javascript_Core








Revision 199918
Author fpi...@apple.com
Date 2016-04-22 15:46:18 -0700 (Fri, 22 Apr 2016)


Log Message
ASSERT(m_stack.last().isTailDeleted) at ShadowChicken.cpp:127 inspecting the inspector
https://bugs.webkit.org/show_bug.cgi?id=156930

Reviewed by Joseph Pecoraro.

The loop that prunes the stack from the top should preserve the invariant that the top frame
cannot be tail-deleted.

* interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::update):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/ShadowChicken.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (199917 => 199918)

--- trunk/Source/_javascript_Core/ChangeLog	2016-04-22 22:41:49 UTC (rev 199917)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-22 22:46:18 UTC (rev 199918)
@@ -1,3 +1,16 @@
+2016-04-22  Filip Pizlo  
+
+ASSERT(m_stack.last().isTailDeleted) at ShadowChicken.cpp:127 inspecting the inspector
+https://bugs.webkit.org/show_bug.cgi?id=156930
+
+Reviewed by Joseph Pecoraro.
+
+The loop that prunes the stack from the top should preserve the invariant that the top frame
+cannot be tail-deleted.
+
+* interpreter/ShadowChicken.cpp:
+(JSC::ShadowChicken::update):
+
 2016-04-22  Benjamin Poulain  
 
 Attempt to fix the CLoop after r199866


Modified: trunk/Source/_javascript_Core/interpreter/ShadowChicken.cpp (199917 => 199918)

--- trunk/Source/_javascript_Core/interpreter/ShadowChicken.cpp	2016-04-22 22:41:49 UTC (rev 199917)
+++ trunk/Source/_javascript_Core/interpreter/ShadowChicken.cpp	2016-04-22 22:46:18 UTC (rev 199918)
@@ -114,7 +114,7 @@
 if (verbose)
 dataLog("Highest point since last time: ", RawPointer(highestPointSinceLastTime), "\n");
 
-while (!m_stack.isEmpty() && m_stack.last().frame < highestPointSinceLastTime)
+while (!m_stack.isEmpty() && (m_stack.last().frame < highestPointSinceLastTime || m_stack.last().isTailDeleted))
 m_stack.removeLast();
 
 if (verbose)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199917] trunk/Source/WebKit2

[ryanhaddad]

Title: [199917] trunk/Source/WebKit2








Revision 199917
Author ryanhad...@apple.com
Date 2016-04-22 15:41:49 -0700 (Fri, 22 Apr 2016)


Log Message
Missed some macros to fix builds that do not support AVKit.

Unreviewed build fix.

* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
* WebProcess/cocoa/WebVideoFullscreenManager.messages.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in
trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (199916 => 199917)

--- trunk/Source/WebKit2/ChangeLog	2016-04-22 22:38:54 UTC (rev 199916)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-22 22:41:49 UTC (rev 199917)
@@ -1,5 +1,14 @@
 2016-04-22  Ryan Haddad  
 
+Missed some macros to fix builds that do not support AVKit.
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
+* WebProcess/cocoa/WebVideoFullscreenManager.messages.in:
+
+2016-04-22  Ryan Haddad  
+
 Fix builds that do not support AVKit
 
 Unreviewed build fix.


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in (199916 => 199917)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 22:38:54 UTC (rev 199916)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in	2016-04-22 22:41:49 UTC (rev 199917)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManagerProxy {
 SetVideoDimensions(uint64_t contextId, bool hasVideo, unsigned width, unsigned height)
 SetupFullscreenWithID(uint64_t contextId, uint32_t videoLayerID, WebCore::IntRect initialRect, float hostingScaleFactor, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode, bool allowsPictureInPicture)


Modified: trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in (199916 => 199917)

--- trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 22:38:54 UTC (rev 199916)
+++ trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.messages.in	2016-04-22 22:41:49 UTC (rev 199917)
@@ -20,7 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 messages -> WebVideoFullscreenManager {
 RequestFullscreenMode(uint64_t contextId, WebCore::HTMLMediaElementEnums::VideoFullscreenMode videoFullscreenMode)
 DidSetupFullscreen(uint64_t contextId)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199916] trunk/Tools

[commit-queue]

Title: [199916] trunk/Tools








Revision 199916
Author commit-qu...@webkit.org
Date 2016-04-22 15:38:54 -0700 (Fri, 22 Apr 2016)


Log Message
Add JSC test results in json format to a buildbot log
https://bugs.webkit.org/show_bug.cgi?id=156920

Patch by Srinivasan Vijayaraghavan  on 2016-04-22
Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests):
Add runtime flag to output json into buildbot
* Scripts/run-_javascript_core-tests:
(runJSCStressTests):
Change key names and remove redundant count key

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (199915 => 199916)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2016-04-22 22:30:00 UTC (rev 199915)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2016-04-22 22:38:54 UTC (rev 199916)
@@ -44,7 +44,7 @@
 
 c['status'] = []
 c['status'].append(html.WebStatus(http_port=8710,
-  revlink="https://trac.webkit.org/changeset/%s", 
+  revlink="https://trac.webkit.org/changeset/%s",
   changecommentlink=(r"(https://bugs\.webkit\.org/show_bug\.cgi\?id=|webkit\.org/b/)(\d+)", r"https://bugs.webkit.org/show_bug.cgi?id=\2"),
   authz=authz))
 
@@ -228,7 +228,7 @@
 
 def createSummary(self, log):
 platform = self.getProperty('platform')
-if platform.startswith('mac'):
+if platform.startswith('mac'):
 warnings = []
 errors = []
 sio = cStringIO.StringIO(log.getText())
@@ -298,8 +298,10 @@
 name = "jscore-test"
 description = ["jscore-tests running"]
 descriptionDone = ["jscore-tests"]
-command = ["perl", "./Tools/Scripts/run-_javascript_core-tests", "--no-build", WithProperties("--%(configuration)s")]
+_jsonFileName = "jsc_test_failures.json"
+command = ["perl", "./Tools/Scripts/run-_javascript_core-tests", "--no-build", WithProperties("--%(configuration)s", "--json-output=%(_jsonFileName)s")]
 failedTestsFormatString = "%d JSC test%s failed"
+logfiles = {"json": _jsonFileName}
 
 def start(self):
 appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))


Modified: trunk/Tools/ChangeLog (199915 => 199916)

--- trunk/Tools/ChangeLog	2016-04-22 22:30:00 UTC (rev 199915)
+++ trunk/Tools/ChangeLog	2016-04-22 22:38:54 UTC (rev 199916)
@@ -1,3 +1,17 @@
+2016-04-22  Srinivasan Vijayaraghavan  
+
+Add JSC test results in json format to a buildbot log
+https://bugs.webkit.org/show_bug.cgi?id=156920
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(RunJavaScriptCoreTests):
+Add runtime flag to output json into buildbot
+* Scripts/run-_javascript_core-tests:
+(runJSCStressTests):
+Change key names and remove redundant count key
+
 2016-04-22  Ryan Haddad  
 
 Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (199915 => 199916)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2016-04-22 22:30:00 UTC (rev 199915)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2016-04-22 22:38:54 UTC (rev 199916)
@@ -332,8 +332,7 @@
 
 if (defined($jsonFileName)) {
 my %jsonData = (
-"numJSCStressFailures" => $numJSCStressFailures,
-"jscStressFailList" => \@jscStressFailList,
+"failures" => \@jscStressFailList,
 );
 
 open(my $fileHandler, ">", $jsonFileName) or die;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199915] trunk/Source/WebCore

[bfulgham]

Title: [199915] trunk/Source/WebCore








Revision 199915
Author bfulg...@apple.com
Date 2016-04-22 15:30:00 -0700 (Fri, 22 Apr 2016)


Log Message
[Win] Unreviewed build fix.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::isHidden):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199914 => 199915)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 22:05:36 UTC (rev 199914)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 22:30:00 UTC (rev 199915)
@@ -1,3 +1,10 @@
+2016-04-22  Brent Fulgham  
+
+[Win] Unreviewed build fix.
+
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayerWin::isHidden):
+
 2016-04-22  Jer Noble  
 
 [iOS] Crash at -[WebAVPlayerLayer resolveBounds]


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (199914 => 199915)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 22:05:36 UTC (rev 199914)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 22:30:00 UTC (rev 199915)
@@ -437,7 +437,7 @@
 setNeedsCommit();
 }
 
-bool PlatformCALayerWin::isHidden(bool value) const
+bool PlatformCALayerWin::isHidden() const
 {
 return CACFLayerIsHidden(m_layer.get());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199914] trunk/Source/WebKit2

[ryanhaddad]

Title: [199914] trunk/Source/WebKit2








Revision 199914
Author ryanhad...@apple.com
Date 2016-04-22 15:05:36 -0700 (Fri, 22 Apr 2016)


Log Message
Fix builds that do not support AVKit

Unreviewed build fix.

* UIProcess/WebPageProxy.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (199913 => 199914)

--- trunk/Source/WebKit2/ChangeLog	2016-04-22 22:02:13 UTC (rev 199913)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-22 22:05:36 UTC (rev 199914)
@@ -1,5 +1,13 @@
 2016-04-22  Ryan Haddad  
 
+Fix builds that do not support AVKit
+
+Unreviewed build fix.
+
+* UIProcess/WebPageProxy.h:
+
+2016-04-22  Ryan Haddad  
+
 Take 2 for fixing builds that do not support AVKit
 
 Unreviewed build fix.


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (199913 => 199914)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2016-04-22 22:02:13 UTC (rev 199913)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2016-04-22 22:05:36 UTC (rev 199914)
@@ -1551,7 +1551,7 @@
 #if ENABLE(FULLSCREEN_API)
 RefPtr m_fullScreenManager;
 #endif
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 RefPtr m_playbackSessionManager;
 RefPtr m_videoFullscreenManager;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199913] trunk/Source/JavaScriptCore

[benjamin]

Title: [199913] trunk/Source/_javascript_Core








Revision 199913
Author benja...@webkit.org
Date 2016-04-22 15:02:13 -0700 (Fri, 22 Apr 2016)


Log Message
Attempt to fix the CLoop after r199866

* runtime/MathCommon.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/MathCommon.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (199912 => 199913)

--- trunk/Source/_javascript_Core/ChangeLog	2016-04-22 21:48:39 UTC (rev 199912)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-22 22:02:13 UTC (rev 199913)
@@ -1,3 +1,9 @@
+2016-04-22  Benjamin Poulain  
+
+Attempt to fix the CLoop after r199866
+
+* runtime/MathCommon.h:
+
 2016-04-22  Benjamin Poulain  
 
 [JSC] Integer Multiply of a number by itself does not need negative zero support


Modified: trunk/Source/_javascript_Core/runtime/MathCommon.h (199912 => 199913)

--- trunk/Source/_javascript_Core/runtime/MathCommon.h	2016-04-22 21:48:39 UTC (rev 199912)
+++ trunk/Source/_javascript_Core/runtime/MathCommon.h	2016-04-22 22:02:13 UTC (rev 199913)
@@ -27,6 +27,7 @@
 #define MathCommon_h
 
 #include "JITOperations.h"
+#include 
 #include 
 
 #ifndef JIT_OPERATION






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199912] trunk/Source/WebCore

[jer . noble]

Title: [199912] trunk/Source/WebCore








Revision 199912
Author jer.no...@apple.com
Date 2016-04-22 14:48:39 -0700 (Fri, 22 Apr 2016)


Log Message
[iOS] Crash at -[WebAVPlayerLayer resolveBounds]
https://bugs.webkit.org/show_bug.cgi?id=156931


Reviewed by Eric Carlson.

When cloning the WebAVPlayerLayer, we must copy over the fullscreenInterface to the cloned layer.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (199911 => 199912)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 21:40:39 UTC (rev 199911)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 21:48:39 UTC (rev 199912)
@@ -1,3 +1,16 @@
+2016-04-22  Jer Noble  
+
+[iOS] Crash at -[WebAVPlayerLayer resolveBounds]
+https://bugs.webkit.org/show_bug.cgi?id=156931
+ 
+
+Reviewed by Eric Carlson.
+
+When cloning the WebAVPlayerLayer, we must copy over the fullscreenInterface to the cloned layer.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
+
 2016-04-22  Chris Dumez  
 
 Crash under WebCore::DataDetection::detectContentInRange()


Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (199911 => 199912)

--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-22 21:40:39 UTC (rev 199911)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-22 21:48:39 UTC (rev 199912)
@@ -458,6 +458,7 @@
 [pipPlayerLayer setVideoGravity:playerLayer.videoGravity];
 [pipPlayerLayer setModelVideoLayerFrame:playerLayer.modelVideoLayerFrame];
 [pipPlayerLayer setPlayerController:playerLayer.playerController];
+[pipPlayerLayer setFullscreenInterface:playerLayer.fullscreenInterface];
 [pipView addSubview:playerLayerView.videoView];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199911] branches/safari-601-branch

[matthew_hanson]

Title: [199911] branches/safari-601-branch








Revision 199911
Author matthew_han...@apple.com
Date 2016-04-22 14:40:39 -0700 (Fri, 22 Apr 2016)


Log Message
Merge r199881. rdar://problem/25879498

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.cpp
branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.h
branches/safari-601-branch/Source/WebCore/loader/cache/CachedCSSStyleSheet.h
branches/safari-601-branch/Source/WebCore/loader/cache/CachedResource.h
branches/safari-601-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp
branches/safari-601-branch/Source/WebCore/loader/cache/CachedSVGDocument.h
branches/safari-601-branch/Source/WebCore/loader/cache/CachedScript.h
branches/safari-601-branch/Source/WebCore/loader/cache/CachedXSLStyleSheet.h




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (199910 => 199911)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2016-04-22 21:32:25 UTC (rev 199910)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2016-04-22 21:40:39 UTC (rev 199911)
@@ -1,3 +1,19 @@
+2016-04-22  Matthew Hanson  
+
+	Merge r199881. rdar://problem/25879498
+
+2016-04-22  Antti Koivisto  
+
+REGRESSION (r194898): Multi download of external SVG defs file by  xlinks:href (caching)
+https://bugs.webkit.org/show_bug.cgi?id=156368
+
+
+Reviewed by Simon Fraser.
+
+* http/tests/svg/resources/symbol-defs.svg: Added.
+* http/tests/svg/svg-use-external-expected.txt: Added.
+* http/tests/svg/svg-use-external.html: Added.
+
 2016-03-31  Matthew Hanson  
 
 Roll out r191180. rdar://problem/25448882


Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (199910 => 199911)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2016-04-22 21:32:25 UTC (rev 199910)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2016-04-22 21:40:39 UTC (rev 199911)
@@ -1,3 +1,43 @@
+2016-04-22  Matthew Hanson  
+
+Merge r199881. rdar://problem/25879498
+
+2016-04-22  Antti Koivisto  
+
+REGRESSION (r194898): Multi download of external SVG defs file by  xlinks:href (caching)
+https://bugs.webkit.org/show_bug.cgi?id=156368
+
+
+Reviewed by Simon Fraser.
+
+We would load svg resources with fragment identifier again because the encoding never matched.
+
+Test: http/tests/svg/svg-use-external.html
+
+* loader/TextResourceDecoder.cpp:
+(WebCore::TextResourceDecoder::setEncoding):
+(WebCore::TextResourceDecoder::hasEqualEncodingForCharset):
+
+Encoding can depend on mime type. Add a comparison function that takes this into account.
+
+(WebCore::findXMLEncoding):
+* loader/TextResourceDecoder.h:
+(WebCore::TextResourceDecoder::encoding):
+* loader/cache/CachedCSSStyleSheet.h:
+* loader/cache/CachedResource.h:
+(WebCore::CachedResource::textResourceDecoder):
+
+Add a way to get the TextResourceDecoder from a cached resource.
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::determineRevalidationPolicy):
+
+Use the new comparison function.
+
+* loader/cache/CachedSVGDocument.h:
+* loader/cache/CachedScript.h:
+* loader/cache/CachedXSLStyleSheet.h:
+
 2016-03-31  Matthew Hanson  
 
 Roll out r191180. rdar://problem/25448882


Modified: branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.cpp (199910 => 199911)

--- branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.cpp	2016-04-22 21:32:25 UTC (rev 199910)
+++ branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.cpp	2016-04-22 21:40:39 UTC (rev 199911)
@@ -359,6 +359,11 @@
 m_source = source;
 }
 
+bool TextResourceDecoder::hasEqualEncodingForCharset(const String& charset) const
+{
+return defaultEncoding(m_contentType, charset) == m_encoding;
+}
+
 // Returns the position of the encoding string.
 static int findXMLEncoding(const char* str, int len, int& encodingLength)
 {


Modified: branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.h (199910 => 199911)

--- branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.h	2016-04-22 21:32:25 UTC (rev 199910)
+++ branches/safari-601-branch/Source/WebCore/loader/TextResourceDecoder.h	2016-04-22 21:40:39 UTC (rev 199911)
@@ -52,6 +52,8 @@
 void setEncoding(const TextEncoding&, EncodingSource);
 const TextEncoding& encoding() const { return m_encoding; }
 
+bool 

[webkit-changes] [199909] branches/safari-601.1.46-branch

[matthew_hanson]

Title: [199909] branches/safari-601.1.46-branch








Revision 199909
Author matthew_han...@apple.com
Date 2016-04-22 14:32:02 -0700 (Fri, 22 Apr 2016)


Log Message
Merge r199881. rdar://problem/25879593

Modified Paths

branches/safari-601.1.46-branch/LayoutTests/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/loader/TextResourceDecoder.cpp
branches/safari-601.1.46-branch/Source/WebCore/loader/TextResourceDecoder.h
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedCSSStyleSheet.h
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedResource.h
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedSVGDocument.h
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedScript.h
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedXSLStyleSheet.h


Added Paths

branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg
branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt
branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external.html




Diff

Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (199908 => 199909)

--- branches/safari-601.1.46-branch/LayoutTests/ChangeLog	2016-04-22 21:27:14 UTC (rev 199908)
+++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog	2016-04-22 21:32:02 UTC (rev 199909)
@@ -1,3 +1,19 @@
+2016-04-22  Matthew Hanson  
+
+Merge r199881. rdar://problem/25879593
+
+2016-04-22  Antti Koivisto  
+
+REGRESSION (r194898): Multi download of external SVG defs file by  xlinks:href (caching)
+https://bugs.webkit.org/show_bug.cgi?id=156368
+
+
+Reviewed by Simon Fraser.
+
+* http/tests/svg/resources/symbol-defs.svg: Added.
+* http/tests/svg/svg-use-external-expected.txt: Added.
+* http/tests/svg/svg-use-external.html: Added.
+
 2016-03-31  Matthew Hanson  
 
 Roll out r191180. rdar://problem/25449273


Added: branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg (0 => 199909)

--- branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg	(rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg	2016-04-22 21:32:02 UTC (rev 199909)
@@ -0,0 +1,28 @@
+
+
+
+rocket
+
+
+
+fire
+
+
+
+lab
+
+
+
+magnet
+
+
+
+shield
+
+
+
+power
+
+
+
+
Property changes on: branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/resources/symbol-defs.svg
___


Added: svn:executable

Added: branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt (0 => 199909)

--- branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt	(rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external-expected.txt	2016-04-22 21:32:02 UTC (rev 199909)
@@ -0,0 +1,5 @@
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - willSendRequest  redirectResponse (null)
+http://127.0.0.1:8000/svg/svg-use-external.html - didFinishLoading
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - didReceiveResponse 
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - didFinishLoading
+   


Added: branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external.html (0 => 199909)

--- branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external.html	(rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external.html	2016-04-22 21:32:02 UTC (rev 199909)
@@ -0,0 +1,44 @@
+
+
+
+
+
+
+Verify that the SVG use resource only loads once
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.dumpResourceLoadCallbacks();
+testRunner.waitUntilDone();
+_onload_ = function() {
+testRunner.notifyDone();
+}
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Property changes on: branches/safari-601.1.46-branch/LayoutTests/http/tests/svg/svg-use-external.html
___


Added: svn:executable

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (199908 => 199909)

--- 

[webkit-changes] [199910] trunk/Source/WebCore

[cdumez]

Title: [199910] trunk/Source/WebCore








Revision 199910
Author cdu...@apple.com
Date 2016-04-22 14:32:25 -0700 (Fri, 22 Apr 2016)


Log Message
Crash under WebCore::DataDetection::detectContentInRange()
https://bugs.webkit.org/show_bug.cgi?id=156880


Reviewed by Darin Adler.

We would sometimes crash under WebCore::DataDetection::detectContentInRange()
when dereferencing a null parentNode pointer. This patch adds a null check
for parentNode in the for() loop. It also does some clean up and optimization
since I was passing by.

* editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::detectContentInRange):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/DataDetection.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (199909 => 199910)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 21:32:02 UTC (rev 199909)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 21:32:25 UTC (rev 199910)
@@ -1,3 +1,19 @@
+2016-04-22  Chris Dumez  
+
+Crash under WebCore::DataDetection::detectContentInRange()
+https://bugs.webkit.org/show_bug.cgi?id=156880
+
+
+Reviewed by Darin Adler.
+
+We would sometimes crash under WebCore::DataDetection::detectContentInRange()
+when dereferencing a null parentNode pointer. This patch adds a null check
+for parentNode in the for() loop. It also does some clean up and optimization
+since I was passing by.
+
+* editing/cocoa/DataDetection.mm:
+(WebCore::DataDetection::detectContentInRange):
+
 2016-04-22  Keith Miller  
 
 buildObjectForEventListener should not call into JSC with a null ExecState


Modified: trunk/Source/WebCore/editing/cocoa/DataDetection.mm (199909 => 199910)

--- trunk/Source/WebCore/editing/cocoa/DataDetection.mm	2016-04-22 21:32:02 UTC (rev 199909)
+++ trunk/Source/WebCore/editing/cocoa/DataDetection.mm	2016-04-22 21:32:25 UTC (rev 199910)
@@ -39,6 +39,7 @@
 #import "NodeTraversal.h"
 #import "Range.h"
 #import "RenderObject.h"
+#import "StyleProperties.h"
 #import "Text.h"
 #import "TextIterator.h"
 #import "VisiblePosition.h"
@@ -516,10 +517,8 @@
 for (auto& result : allResults) {
 DDQueryRange queryRange = softLink_DataDetectorsCore_DDResultGetQueryRangeForURLification(result.get());
 CFIndex iteratorTargetAdvanceCount = (CFIndex)softLink_DataDetectorsCore_DDScanQueryGetFragmentMetaData(scanQuery.get(), queryRange.start.queryIndex);
-while (iteratorCount < iteratorTargetAdvanceCount) {
+for (; iteratorCount < iteratorTargetAdvanceCount; ++iteratorCount)
 iterator.advance();
-iteratorCount++;
-}
 
 Vector fragmentRanges;
 RefPtr currentRange = iterator.range();
@@ -534,12 +533,11 @@
 }
 
 while (fragmentIndex < queryRange.end.queryIndex) {
-fragmentIndex++;
+++fragmentIndex;
 iteratorTargetAdvanceCount = (CFIndex)softLink_DataDetectorsCore_DDScanQueryGetFragmentMetaData(scanQuery.get(), fragmentIndex);
-while (iteratorCount < iteratorTargetAdvanceCount) {
+for (; iteratorCount < iteratorTargetAdvanceCount; ++iteratorCount)
 iterator.advance();
-iteratorCount++;
-}
+
 currentRange = iterator.range();
 RefPtr fragmentRange = (fragmentIndex == queryRange.end.queryIndex) ?  Range::create(currentRange->ownerDocument(), >startContainer(), currentRange->startOffset(), >endContainer(), currentRange->startOffset() + queryRange.end.offset) : currentRange;
 RefPtr previousRange = fragmentRanges.last();
@@ -549,7 +547,7 @@
 } else
 fragmentRanges.append(fragmentRange);
 }
-allResultRanges.append(fragmentRanges);
+allResultRanges.append(WTFMove(fragmentRanges));
 }
 
 CFTimeZoneRef tz = CFTimeZoneCopyDefault();
@@ -564,37 +562,39 @@
 // we are about to process a different text node.
 resultCount = allResults.size();
 
-for (CFIndex resultIndex = 0; resultIndex < resultCount; resultIndex++) {
+for (CFIndex resultIndex = 0; resultIndex < resultCount; ++resultIndex) {
 DDResultRef coreResult = allResults[resultIndex].get();
 DDQueryRange queryRange = softLink_DataDetectorsCore_DDResultGetQueryRangeForURLification(coreResult);
-Vector resultRanges = allResultRanges[resultIndex];
+auto& resultRanges = allResultRanges[resultIndex];
 
 // Compare the query offsets to make sure we don't go backwards
 if (queryOffsetCompare(lastModifiedQueryOffset, queryRange.start) >= 0)
 continue;
 
-if (!resultRanges.size())
+if (resultRanges.isEmpty())
 continue;
-
-NSString *identifier = dataDetectorStringForPath(indexPaths[resultIndex].get());
-NSString *correspondingURL = 

[webkit-changes] [199908] trunk/Source/WebKit

[bfulgham]

Title: [199908] trunk/Source/WebKit








Revision 199908
Author bfulg...@apple.com
Date 2016-04-22 14:27:14 -0700 (Fri, 22 Apr 2016)


Log Message

Source/WebKit:
Unreviewed build fix after r199841.

* PlatformWin.cmake: Add missing WebApplicationCache.cpp buid directive.

Source/WebKit/win:
Unreviewed build fix after 4199841.

* WebApplicationCache.cpp:
(WebApplicationCache::WebApplicationCache): Provide missing preference key definition.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWin.cmake
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebApplicationCache.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (199907 => 199908)

--- trunk/Source/WebKit/ChangeLog	2016-04-22 21:26:46 UTC (rev 199907)
+++ trunk/Source/WebKit/ChangeLog	2016-04-22 21:27:14 UTC (rev 199908)
@@ -1,3 +1,9 @@
+2016-04-22  Brent Fulgham  
+
+Unreviewed build fix after r199841.
+
+* PlatformWin.cmake: Add missing WebApplicationCache.cpp buid directive.
+
 2016-04-11  Fujii Hironori  
 
 [CMake] Make FOLDER property INHERITED


Modified: trunk/Source/WebKit/PlatformWin.cmake (199907 => 199908)

--- trunk/Source/WebKit/PlatformWin.cmake	2016-04-22 21:26:46 UTC (rev 199907)
+++ trunk/Source/WebKit/PlatformWin.cmake	2016-04-22 21:27:14 UTC (rev 199908)
@@ -83,6 +83,7 @@
 win/MemoryStream.h
 win/ProgIDMacros.h
 win/WebActionPropertyBag.h
+win/WebApplicationCache.h
 win/WebArchive.h
 win/WebBackForwardList.h
 win/WebCache.h
@@ -154,6 +155,7 @@
 win/MarshallingHelpers.cpp
 win/MemoryStream.cpp
 win/WebActionPropertyBag.cpp
+win/WebApplicationCache.cpp
 win/WebArchive.cpp
 win/WebBackForwardList.cpp
 win/WebCache.cpp


Modified: trunk/Source/WebKit/win/ChangeLog (199907 => 199908)

--- trunk/Source/WebKit/win/ChangeLog	2016-04-22 21:26:46 UTC (rev 199907)
+++ trunk/Source/WebKit/win/ChangeLog	2016-04-22 21:27:14 UTC (rev 199908)
@@ -1,3 +1,10 @@
+2016-04-22  Brent Fulgham  
+
+Unreviewed build fix after 4199841.
+
+* WebApplicationCache.cpp:
+(WebApplicationCache::WebApplicationCache): Provide missing preference key definition.
+
 2016-04-21  Anders Carlsson  
 
 Add a missing space, as noticed by Darin.


Modified: trunk/Source/WebKit/win/WebApplicationCache.cpp (199907 => 199908)

--- trunk/Source/WebKit/win/WebApplicationCache.cpp	2016-04-22 21:26:46 UTC (rev 199907)
+++ trunk/Source/WebKit/win/WebApplicationCache.cpp	2016-04-22 21:27:14 UTC (rev 199908)
@@ -33,9 +33,14 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
+using namespace WebCore;
+
+static CFStringRef WebKitLocalCacheDefaultsKey = CFSTR("WebKitLocalCache");
+
 // WebApplicationCache ---
 
 WebApplicationCache::WebApplicationCache()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199907] trunk/LayoutTests

[ryanhaddad]

Title: [199907] trunk/LayoutTests








Revision 199907
Author ryanhad...@apple.com
Date 2016-04-22 14:26:46 -0700 (Fri, 22 Apr 2016)


Log Message
Rebaselining inspector/model/stack-trace.html after r199897

Unreviewed test gardening.

* inspector/model/stack-trace-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/stack-trace-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (199906 => 199907)

--- trunk/LayoutTests/ChangeLog	2016-04-22 21:25:37 UTC (rev 199906)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 21:26:46 UTC (rev 199907)
@@ -1,3 +1,11 @@
+2016-04-22  Ryan Haddad  
+
+Rebaselining inspector/model/stack-trace.html after r199897
+
+Unreviewed test gardening.
+
+* inspector/model/stack-trace-expected.txt:
+
 2016-04-22  Dave Hyatt  
 
 REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken


Modified: trunk/LayoutTests/inspector/model/stack-trace-expected.txt (199906 => 199907)

--- trunk/LayoutTests/inspector/model/stack-trace-expected.txt	2016-04-22 21:25:37 UTC (rev 199906)
+++ trunk/LayoutTests/inspector/model/stack-trace-expected.txt	2016-04-22 21:26:46 UTC (rev 199907)
@@ -17,7 +17,7 @@
   6: triggerConsoleMessage (stack-trace.html:9) - nativeCode (false) programCode (false)
   7: Eval Code (Anonymous Script 2 (line 1)) - nativeCode (false) programCode (true)
   8: eval - nativeCode (true) programCode (false)
-  9: _evaluateOn (__WebInspectorInjectedScript__:115) - nativeCode (false) programCode (false)
-  10: _evaluateAndWrap (__WebInspectorInjectedScript__:93:106) - nativeCode (false) programCode (false)
-  11: evaluate (__WebInspectorInjectedScript__:83) - nativeCode (false) programCode (false)
+  9: _evaluateOn - nativeCode (true) programCode (false)
+  10: _evaluateAndWrap - nativeCode (true) programCode (false)
+  11: evaluate - nativeCode (true) programCode (false)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199906] trunk/PerformanceTests

[simon . fraser]

Title: [199906] trunk/PerformanceTests








Revision 199906
Author simon.fra...@apple.com
Date 2016-04-22 14:25:37 -0700 (Fri, 22 Apr 2016)


Log Message
Skip two content animation tests which are only meant for iOS testing.

* Animation/css-animation.html: Added.
* Animation/raf-animation.html: Added.

* Skipped:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Skipped




Diff

Modified: trunk/PerformanceTests/ChangeLog (199905 => 199906)

--- trunk/PerformanceTests/ChangeLog	2016-04-22 21:24:27 UTC (rev 199905)
+++ trunk/PerformanceTests/ChangeLog	2016-04-22 21:25:37 UTC (rev 199906)
@@ -1,3 +1,12 @@
+2016-04-22  Simon Fraser  
+
+Skip two content animation tests which are only meant for iOS testing.
+
+* Animation/css-animation.html: Added.
+* Animation/raf-animation.html: Added.
+
+* Skipped:
+
 2016-04-20  Simon Fraser  
 
 Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results


Modified: trunk/PerformanceTests/Skipped (199905 => 199906)

--- trunk/PerformanceTests/Skipped	2016-04-22 21:24:27 UTC (rev 199905)
+++ trunk/PerformanceTests/Skipped	2016-04-22 21:25:37 UTC (rev 199906)
@@ -95,3 +95,7 @@
 
 # Still under development so skip it for now.
 Animometer
+
+# Used for iOS testing
+Animation/css-animation.html
+Animation/raf-animation.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199905] trunk/Source/WebCore

[keith_miller]

Title: [199905] trunk/Source/WebCore








Revision 199905
Author keith_mil...@apple.com
Date 2016-04-22 14:24:27 -0700 (Fri, 22 Apr 2016)


Log Message
buildObjectForEventListener should not call into JSC with a null ExecState
https://bugs.webkit.org/show_bug.cgi?id=156923

Reviewed by Joseph Pecoraro.

If a user had disabled _javascript_ on their page then the inspector tried to
add an event listener we would fail to create an ExecState. Since we didn't
check this ExecState was valid we would then attempt to stringify the value,
which would cause JSC to crash.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199904 => 199905)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 21:22:52 UTC (rev 199904)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 21:24:27 UTC (rev 199905)
@@ -1,3 +1,18 @@
+2016-04-22  Keith Miller  
+
+buildObjectForEventListener should not call into JSC with a null ExecState
+https://bugs.webkit.org/show_bug.cgi?id=156923
+
+Reviewed by Joseph Pecoraro.
+
+If a user had disabled _javascript_ on their page then the inspector tried to
+add an event listener we would fail to create an ExecState. Since we didn't
+check this ExecState was valid we would then attempt to stringify the value,
+which would cause JSC to crash.
+
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::buildObjectForEventListener):
+
 2016-04-22  Dean Jackson  
 
 Yet another attempt at fixing Windows.


Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (199904 => 199905)

--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2016-04-22 21:22:52 UTC (rev 199904)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2016-04-22 21:24:27 UTC (rev 199905)
@@ -1472,7 +1472,7 @@
 JSC::JSLockHolder lock(scriptListener->isolatedWorld().vm());
 state = execStateFromNode(scriptListener->isolatedWorld(), >document());
 handler = scriptListener->jsFunction(>document());
-if (handler) {
+if (handler && state) {
 body = handler->toString(state)->value(state);
 if (auto function = JSC::jsDynamicCast(handler)) {
 if (!function->isHostOrBuiltinFunction()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199904] trunk/Source/WebCore

[dino]

Title: [199904] trunk/Source/WebCore








Revision 199904
Author d...@apple.com
Date 2016-04-22 14:22:52 -0700 (Fri, 22 Apr 2016)


Log Message
Yet another attempt at fixing Windows.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::isHidden):
* platform/graphics/ca/win/PlatformCALayerWin.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199903 => 199904)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 21:07:45 UTC (rev 199903)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 21:22:52 UTC (rev 199904)
@@ -1,3 +1,11 @@
+2016-04-22  Dean Jackson  
+
+Yet another attempt at fixing Windows.
+
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayerWin::isHidden):
+* platform/graphics/ca/win/PlatformCALayerWin.h:
+
 2016-04-22  Ryan Haddad  
 
 Attempt to fix Windows build after r199862


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (199903 => 199904)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 21:07:45 UTC (rev 199903)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 21:22:52 UTC (rev 199904)
@@ -439,7 +439,7 @@
 
 bool PlatformCALayerWin::isHidden(bool value) const
 {
-return CACFLayerGetHidden(m_layer.get());
+return CACFLayerIsHidden(m_layer.get());
 }
 
 void PlatformCALayerWin::setHidden(bool value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199902] trunk/Source/WebCore

[ryanhaddad]

Title: [199902] trunk/Source/WebCore








Revision 199902
Author ryanhad...@apple.com
Date 2016-04-22 14:07:42 -0700 (Fri, 22 Apr 2016)


Log Message
Attempt to fix Windows build after r199862

Unreviewed build fix.

* platform/graphics/ca/win/PlatformCALayerWin.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (199901 => 199902)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 21:06:50 UTC (rev 199901)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 21:07:42 UTC (rev 199902)
@@ -1,3 +1,11 @@
+2016-04-22  Ryan Haddad  
+
+Attempt to fix Windows build after r199862
+
+Unreviewed build fix.
+
+* platform/graphics/ca/win/PlatformCALayerWin.h:
+
 2016-04-22  Brent Fulgham  
 
 Anchor element 'ping' property should only apply to http/https destinations


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h (199901 => 199902)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2016-04-22 21:06:50 UTC (rev 199901)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2016-04-22 21:07:42 UTC (rev 199902)
@@ -79,6 +79,7 @@
 TransformationMatrix sublayerTransform() const override;
 void setSublayerTransform(const TransformationMatrix&) override;
 
+bool isHidden() const override;
 void setHidden(bool) override;
 
 void setBackingStoreAttached(bool) override;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199903] trunk/Source/WebKit2

[ryanhaddad]

Title: [199903] trunk/Source/WebKit2








Revision 199903
Author ryanhad...@apple.com
Date 2016-04-22 14:07:45 -0700 (Fri, 22 Apr 2016)


Log Message
Take 2 for fixing builds that do not support AVKit

Unreviewed build fix.

* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (199902 => 199903)

--- trunk/Source/WebKit2/ChangeLog	2016-04-22 21:07:42 UTC (rev 199902)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-22 21:07:45 UTC (rev 199903)
@@ -1,3 +1,13 @@
+2016-04-22  Ryan Haddad  
+
+Take 2 for fixing builds that do not support AVKit
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::resetState):
+
 2016-04-22  Anders Carlsson  
 
 WKWebView WebSQL is not enabled


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h (199902 => 199903)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 21:07:42 UTC (rev 199902)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 21:07:45 UTC (rev 199903)
@@ -26,7 +26,7 @@
 #ifndef WebVideoFullscreenManagerProxy_h
 #define WebVideoFullscreenManagerProxy_h
 
-#if PLATFORM(IOS) && HAVE(AVKIT) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 
 #include "MessageReceiver.h"
 #include 


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (199902 => 199903)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-04-22 21:07:42 UTC (rev 199902)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-04-22 21:07:45 UTC (rev 199903)
@@ -5082,7 +5082,7 @@
 
 m_visibleScrollerThumbRect = IntRect();
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if (PLATFORM(IOS) && HAVE(AVKIT)) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 if (m_playbackSessionManager) {
 m_playbackSessionManager->invalidate();
 m_playbackSessionManager = nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199901] trunk/Source/WebKit2

[andersca]

Title: [199901] trunk/Source/WebKit2








Revision 199901
Author ander...@apple.com
Date 2016-04-22 14:06:50 -0700 (Fri, 22 Apr 2016)


Log Message
WKWebView WebSQL is not enabled
https://bugs.webkit.org/show_bug.cgi?id=156928
rdar://problem/19029603

Reviewed by Beth Dakin.

Give databases a default quota of 50 MB, matching what we have in UIWebView.

* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (199900 => 199901)

--- trunk/Source/WebKit2/ChangeLog	2016-04-22 20:57:26 UTC (rev 199900)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-22 21:06:50 UTC (rev 199901)
@@ -1,3 +1,16 @@
+2016-04-22  Anders Carlsson  
+
+WKWebView WebSQL is not enabled
+https://bugs.webkit.org/show_bug.cgi?id=156928
+rdar://problem/19029603
+
+Reviewed by Beth Dakin.
+
+Give databases a default quota of 50 MB, matching what we have in UIWebView.
+
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):
+
 2016-04-22  Ryan Haddad  
 
 Fix builds that do not support AVKit


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm (199900 => 199901)

--- trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm	2016-04-22 20:57:26 UTC (rev 199900)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm	2016-04-22 21:06:50 UTC (rev 199901)
@@ -239,7 +239,11 @@
 void UIDelegate::UIClient::exceededDatabaseQuota(WebPageProxy*, WebFrameProxy*, API::SecurityOrigin* securityOrigin, const WTF::String& databaseName, const WTF::String& displayName, unsigned long long currentQuota, unsigned long long currentOriginUsage, unsigned long long currentUsage, unsigned long long expectedUsage, std::function completionHandler)
 {
 if (!m_uiDelegate.m_delegateMethods.webViewDecideDatabaseQuotaForSecurityOriginCurrentQuotaCurrentOriginUsageCurrentDatabaseUsageExpectedUsageDecisionHandler) {
-completionHandler(currentQuota);
+
+// Use 50 MB as the default database quota.
+unsigned long long defaultPerOriginDatabaseQuota = 50 * 1024 * 1024;
+
+completionHandler(defaultPerOriginDatabaseQuota);
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199900] trunk/Source/WebCore

[bfulgham]

Title: [199900] trunk/Source/WebCore








Revision 199900
Author bfulg...@apple.com
Date 2016-04-22 13:57:26 -0700 (Fri, 22 Apr 2016)


Log Message
Anchor element 'ping' property should only apply to http/https destinations
https://bugs.webkit.org/show_bug.cgi?id=156801


Reviewed by Chris Dumez.

Take advantage of the hyperlink auditing language "UAs may either ignore the
ping attribute altogether, or selectively ignore URLs in the list (e.g. ignoring
any third-party URLs)" to restrict pings to http/https targets. For details, see
.

Tested by http/tests/navigation/ping-attribute tests.

* loader/PingLoader.cpp:
(WebCore::PingLoader::sendPing): Ignore requests to ping anything outside the
family of HTTP protocols (http/https).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/PingLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199899 => 199900)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 20:28:44 UTC (rev 199899)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 20:57:26 UTC (rev 199900)
@@ -1,3 +1,22 @@
+2016-04-22  Brent Fulgham  
+
+Anchor element 'ping' property should only apply to http/https destinations
+https://bugs.webkit.org/show_bug.cgi?id=156801
+
+
+Reviewed by Chris Dumez.
+
+Take advantage of the hyperlink auditing language "UAs may either ignore the
+ping attribute altogether, or selectively ignore URLs in the list (e.g. ignoring
+any third-party URLs)" to restrict pings to http/https targets. For details, see
+.
+
+Tested by http/tests/navigation/ping-attribute tests.
+
+* loader/PingLoader.cpp:
+(WebCore::PingLoader::sendPing): Ignore requests to ping anything outside the
+family of HTTP protocols (http/https).
+
 2016-04-22  Ryan Haddad  
 
 Fix builds that do not support AVKit


Modified: trunk/Source/WebCore/loader/PingLoader.cpp (199899 => 199900)

--- trunk/Source/WebCore/loader/PingLoader.cpp	2016-04-22 20:28:44 UTC (rev 199899)
+++ trunk/Source/WebCore/loader/PingLoader.cpp	2016-04-22 20:57:26 UTC (rev 199900)
@@ -92,6 +92,9 @@
 // http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#hyperlink-auditing
 void PingLoader::sendPing(Frame& frame, const URL& pingURL, const URL& destinationURL)
 {
+if (!pingURL.protocolIsInHTTPFamily())
+return;
+
 ResourceRequest request(pingURL);
 
 #if ENABLE(CONTENT_EXTENSIONS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199899] trunk/Source/WebInspectorUI

[timothy]

Title: [199899] trunk/Source/WebInspectorUI








Revision 199899
Author timo...@apple.com
Date 2016-04-22 13:28:44 -0700 (Fri, 22 Apr 2016)


Log Message
Change an assert to a warn based on post review feedback.

https://bugs.webkit.org/show_bug.cgi?id=156919
rdar://problem/25857118

Rubber-stamped by Joseph Pecoraro.

* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.debuggerDidPause):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (199898 => 199899)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-04-22 20:12:39 UTC (rev 199898)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-04-22 20:28:44 UTC (rev 199899)
@@ -1,5 +1,17 @@
 2016-04-22  Timothy Hatcher  
 
+Change an assert to a warn based on post review feedback.
+
+https://bugs.webkit.org/show_bug.cgi?id=156919
+rdar://problem/25857118
+
+Rubber-stamped by Joseph Pecoraro.
+
+* UserInterface/Controllers/DebuggerManager.js:
+(WebInspector.DebuggerManager.prototype.debuggerDidPause):
+
+2016-04-22  Timothy Hatcher  
+
 Web Inspector: Debugger statement in console does not provide any call frames and debugger UI is confused
 
 https://bugs.webkit.org/show_bug.cgi?id=156919


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (199898 => 199899)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js	2016-04-22 20:12:39 UTC (rev 199898)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js	2016-04-22 20:28:44 UTC (rev 199899)
@@ -546,7 +546,7 @@
 this._activeCallFrame = this._callFrames[0];
 
 if (!this._activeCallFrame) {
-console.assert("We should always have one call frame. This could indicate we are hitting an exception or debugger statement in an internal injected script.");
+console.warn("We should always have one call frame. This could indicate we are hitting an exception or debugger statement in an internal injected script.");
 this._didResumeInternal();
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199898] tags/Safari-602.1.29/Source

[bshafiei]

Title: [199898] tags/Safari-602.1.29/Source








Revision 199898
Author bshaf...@apple.com
Date 2016-04-22 13:12:39 -0700 (Fri, 22 Apr 2016)


Log Message
Merged r199896.

Modified Paths

tags/Safari-602.1.29/Source/WebCore/ChangeLog
tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.h
tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.mm
tags/Safari-602.1.29/Source/WebKit2/ChangeLog
tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h
tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm
tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.cpp
tags/Safari-602.1.29/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm




Diff

Modified: tags/Safari-602.1.29/Source/WebCore/ChangeLog (199897 => 199898)

--- tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 19:53:37 UTC (rev 199897)
+++ tags/Safari-602.1.29/Source/WebCore/ChangeLog	2016-04-22 20:12:39 UTC (rev 199898)
@@ -1,3 +1,16 @@
+2016-04-22  Babak Shafiei  
+
+Merge r199896.
+
+2016-04-22  Ryan Haddad  
+
+Fix builds that do not support AVKit
+
+Unreviewed build fix.
+
+* platform/ios/WebAVPlayerController.h:
+* platform/ios/WebAVPlayerController.mm:
+
 2016-04-21  Dean Jackson  
 
 Backdrop Filter should not be visible if element has visibility:hidden


Modified: tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.h (199897 => 199898)

--- tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.h	2016-04-22 19:53:37 UTC (rev 199897)
+++ tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.h	2016-04-22 20:12:39 UTC (rev 199898)
@@ -23,7 +23,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && HAVE(AVKIT)
 
 #import "AVKitSPI.h"
 


Modified: tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.mm (199897 => 199898)

--- tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-22 19:53:37 UTC (rev 199897)
+++ tags/Safari-602.1.29/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-22 20:12:39 UTC (rev 199898)
@@ -27,7 +27,7 @@
 #import "config.h"
 #import "WebAVPlayerController.h"
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && HAVE(AVKIT)
 
 #import "AVKitSPI.h"
 #import "Logging.h"


Modified: tags/Safari-602.1.29/Source/WebKit2/ChangeLog (199897 => 199898)

--- tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 19:53:37 UTC (rev 199897)
+++ tags/Safari-602.1.29/Source/WebKit2/ChangeLog	2016-04-22 20:12:39 UTC (rev 199898)
@@ -1,3 +1,21 @@
+2016-04-22  Babak Shafiei  
+
+Merge r199896.
+
+2016-04-22  Ryan Haddad  
+
+Fix builds that do not support AVKit
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy):
+(WebKit::WebPageProxy::reattachToWebProcess):
+(WebKit::WebPageProxy::viewDidLeaveWindow):
+* UIProcess/ios/WebPageProxyIOS.mm:
+
 2016-04-21  Dean Jackson  
 
 Backdrop Filter should not be visible if element has visibility:hidden


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h (199897 => 199898)

--- tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 19:53:37 UTC (rev 199897)
+++ tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 20:12:39 UTC (rev 199898)
@@ -26,7 +26,7 @@
 #ifndef WebVideoFullscreenManagerProxy_h
 #define WebVideoFullscreenManagerProxy_h
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if PLATFORM(IOS) && HAVE(AVKIT) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 
 #include "MessageReceiver.h"
 #include 


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm (199897 => 199898)

--- tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm	2016-04-22 19:53:37 UTC (rev 199897)
+++ tags/Safari-602.1.29/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm	2016-04-22 20:12:39 UTC (rev 199898)
@@ -26,7 +26,7 @@
 #import "config.h"
 #import "WebVideoFullscreenManagerProxy.h"
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if PLATFORM(IOS) && HAVE(AVKIT) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 
 #import "WebPageProxy.h"
 #import "WebPlaybackSessionManagerProxy.h"


Modified: tags/Safari-602.1.29/Source/WebKit2/UIProcess/WebPageProxy.cpp (199897 => 199898)

--- 

[webkit-changes] [199897] trunk/Source/WebInspectorUI

[timothy]

Title: [199897] trunk/Source/WebInspectorUI








Revision 199897
Author timo...@apple.com
Date 2016-04-22 12:53:37 -0700 (Fri, 22 Apr 2016)


Log Message
Web Inspector: Debugger statement in console does not provide any call frames and debugger UI is confused

https://bugs.webkit.org/show_bug.cgi?id=156919
rdar://problem/25857118

This makes console expressions show up in the Debugger tab sidebar if a ScriptContentView is shown for them.
We now also show call frames that originate from a console _expression_, so the call frames in the sidebar is not empty.
Also fix a bug where when there are no call frames we auto resume the debugger and don't leave it in a broken state.

Reviewed by Joseph Pecoraro.

* Localizations/en.lproj/localizedStrings.js: Updated.

* UserInterface/Base/Utilities.js:
(appendWebInspectorSourceURL): Don't append if another sourceURL is already added.
(appendWebInspectorConsoleEvaluationSourceURL): Added.
(isWebInspectorConsoleEvaluationScript): Added.
(isWebKitInternalScript): Return false for isWebInspectorConsoleEvaluationScript().

* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.debuggerDidPause): Resume if call frames is empty. This is not as common now
since console _expression_ call frames are not skipped.
(WebInspector.DebuggerManager.prototype.scriptDidParse): Change an early return for isWebInspectorInternalScript() that
was skipping adding internal scripts to the known script lists, but it should only do that when the debug UI is disabled.

* UserInterface/Controllers/_javascript_LogViewController.js:
(WebInspector._javascript_LogViewController.prototype.consolePromptTextCommitted):
Call appendWebInspectorConsoleEvaluationSourceURL so the console expressions are tagged before evaluateInInspectedWindow
added the internal sourceURL name.

* UserInterface/Models/Script.js:
(WebInspector.Script): Assign unique identifiers to console scripts so they are named correctly.
(WebInspector.Script.resetUniqueDisplayNameNumbers): Reset _nextUniqueConsoleDisplayNameNumber.
(WebInspector.Script.prototype.get displayName): Special case console expressions with a better name.

* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype.treeElementForRepresentedObject): Add a script tree element on demand
like the ResourceSidebarPanel does for anonymous scripts.
(WebInspector.DebuggerSidebarPanel.prototype._addScript): Return treeElement so treeElementForRepresentedObject can use it.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js
trunk/Source/WebInspectorUI/UserInterface/Models/Script.js
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (199896 => 199897)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-04-22 19:44:08 UTC (rev 199896)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-04-22 19:53:37 UTC (rev 199897)
@@ -1,3 +1,45 @@
+2016-04-22  Timothy Hatcher  
+
+Web Inspector: Debugger statement in console does not provide any call frames and debugger UI is confused
+
+https://bugs.webkit.org/show_bug.cgi?id=156919
+rdar://problem/25857118
+
+This makes console expressions show up in the Debugger tab sidebar if a ScriptContentView is shown for them.
+We now also show call frames that originate from a console _expression_, so the call frames in the sidebar is not empty.
+Also fix a bug where when there are no call frames we auto resume the debugger and don't leave it in a broken state.
+
+Reviewed by Joseph Pecoraro.
+
+* Localizations/en.lproj/localizedStrings.js: Updated.
+
+* UserInterface/Base/Utilities.js:
+(appendWebInspectorSourceURL): Don't append if another sourceURL is already added.
+(appendWebInspectorConsoleEvaluationSourceURL): Added.
+(isWebInspectorConsoleEvaluationScript): Added.
+(isWebKitInternalScript): Return false for isWebInspectorConsoleEvaluationScript().
+
+* UserInterface/Controllers/DebuggerManager.js:
+(WebInspector.DebuggerManager.prototype.debuggerDidPause): Resume if call frames is empty. This is not as common now
+since console _expression_ call frames are not skipped.
+(WebInspector.DebuggerManager.prototype.scriptDidParse): Change an early return for isWebInspectorInternalScript() that
+was skipping adding internal scripts to the known script lists, but it should only do that when the debug UI is disabled.
+
+* UserInterface/Controllers/_javascript_LogViewController.js:
+

[webkit-changes] [199896] trunk/Source

[ryanhaddad]

Title: [199896] trunk/Source








Revision 199896
Author ryanhad...@apple.com
Date 2016-04-22 12:44:08 -0700 (Fri, 22 Apr 2016)


Log Message
Fix builds that do not support AVKit

Unreviewed build fix.

* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::viewDidLeaveWindow):
* UIProcess/ios/WebPageProxyIOS.mm:
* platform/ios/WebAVPlayerController.h:
* platform/ios/WebAVPlayerController.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebAVPlayerController.h
trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h
trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (199895 => 199896)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 19:42:24 UTC (rev 199895)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 19:44:08 UTC (rev 199896)
@@ -1,3 +1,12 @@
+2016-04-22  Ryan Haddad  
+
+Fix builds that do not support AVKit
+
+Unreviewed build fix.
+
+* platform/ios/WebAVPlayerController.h:
+* platform/ios/WebAVPlayerController.mm:
+
 2016-04-22  Dave Hyatt  
 
 REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken


Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.h (199895 => 199896)

--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.h	2016-04-22 19:42:24 UTC (rev 199895)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.h	2016-04-22 19:44:08 UTC (rev 199896)
@@ -23,7 +23,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && HAVE(AVKIT)
 
 #import "AVKitSPI.h"
 


Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm (199895 => 199896)

--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-22 19:42:24 UTC (rev 199895)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-22 19:44:08 UTC (rev 199896)
@@ -27,7 +27,7 @@
 #import "config.h"
 #import "WebAVPlayerController.h"
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && HAVE(AVKIT)
 
 #import "AVKitSPI.h"
 #import "Logging.h"


Modified: trunk/Source/WebKit2/ChangeLog (199895 => 199896)

--- trunk/Source/WebKit2/ChangeLog	2016-04-22 19:42:24 UTC (rev 199895)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-22 19:44:08 UTC (rev 199896)
@@ -1,3 +1,17 @@
+2016-04-22  Ryan Haddad  
+
+Fix builds that do not support AVKit
+
+Unreviewed build fix.
+
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
+* UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy):
+(WebKit::WebPageProxy::reattachToWebProcess):
+(WebKit::WebPageProxy::viewDidLeaveWindow):
+* UIProcess/ios/WebPageProxyIOS.mm:
+
 2016-04-22  Brady Eidson  
 
 Modern IDB: Rework the ownership/RefCounting model of IDBConnectionToServer and IDBConnectionProxy.


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h (199895 => 199896)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 19:42:24 UTC (rev 199895)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h	2016-04-22 19:44:08 UTC (rev 199896)
@@ -26,7 +26,7 @@
 #ifndef WebVideoFullscreenManagerProxy_h
 #define WebVideoFullscreenManagerProxy_h
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if PLATFORM(IOS) && HAVE(AVKIT) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 
 #include "MessageReceiver.h"
 #include 


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm (199895 => 199896)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm	2016-04-22 19:42:24 UTC (rev 199895)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm	2016-04-22 19:44:08 UTC (rev 199896)
@@ -26,7 +26,7 @@
 #import "config.h"
 #import "WebVideoFullscreenManagerProxy.h"
 
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if PLATFORM(IOS) && HAVE(AVKIT) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 
 #import "WebPageProxy.h"
 #import "WebPlaybackSessionManagerProxy.h"


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (199895 => 199896)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-04-22 19:42:24 UTC (rev 199895)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2016-04-22 19:44:08 UTC (rev 199896)
@@ -474,7 +474,7 @@
 #if 

[webkit-changes] [199895] trunk

[hyatt]

Title: [199895] trunk








Revision 199895
Author hy...@apple.com
Date 2016-04-22 12:42:24 -0700 (Fri, 22 Apr 2016)


Log Message
REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
https://bugs.webkit.org/show_bug.cgi?id=156869


Reviewed by Zalan Bujtas.

Source/WebCore:

Added fast/block/min-content-with-box-sizing.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing):

LayoutTests:

* fast/block/min-content-box-sizing-expected.html: Added.
* fast/block/min-content-box-sizing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/block/min-content-box-sizing-expected.html
trunk/LayoutTests/fast/block/min-content-box-sizing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199894 => 199895)

--- trunk/LayoutTests/ChangeLog	2016-04-22 19:27:57 UTC (rev 199894)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 19:42:24 UTC (rev 199895)
@@ -1,3 +1,14 @@
+2016-04-22  Dave Hyatt  
+
+REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
+https://bugs.webkit.org/show_bug.cgi?id=156869
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/block/min-content-box-sizing-expected.html: Added.
+* fast/block/min-content-box-sizing.html: Added.
+
 2016-04-22  Chris Dumez  
 
 Support disabling at runtime IndexedDB constructors exposed to workers


Added: trunk/LayoutTests/fast/block/min-content-box-sizing-expected.html (0 => 199895)

--- trunk/LayoutTests/fast/block/min-content-box-sizing-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/block/min-content-box-sizing-expected.html	2016-04-22 19:42:24 UTC (rev 199895)
@@ -0,0 +1,3 @@
+
+
+


Added: trunk/LayoutTests/fast/block/min-content-box-sizing.html (0 => 199895)

--- trunk/LayoutTests/fast/block/min-content-box-sizing.html	(rev 0)
+++ trunk/LayoutTests/fast/block/min-content-box-sizing.html	2016-04-22 19:42:24 UTC (rev 199895)
@@ -0,0 +1,3 @@
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (199894 => 199895)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 19:27:57 UTC (rev 199894)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 19:42:24 UTC (rev 199895)
@@ -1,3 +1,16 @@
+2016-04-22  Dave Hyatt  
+
+REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
+https://bugs.webkit.org/show_bug.cgi?id=156869
+
+
+Reviewed by Zalan Bujtas.
+
+Added fast/block/min-content-with-box-sizing.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing):
+
 2016-04-22  Antti Koivisto  
 
 TextAutoSizingKey should use normal refcounting


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (199894 => 199895)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2016-04-22 19:27:57 UTC (rev 199894)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2016-04-22 19:42:24 UTC (rev 199895)
@@ -2898,8 +2898,13 @@
 {
 // FIXME: The CSS sizing spec is considering changing what min-content/max-content should resolve to.
 // If that happens, this code will have to change.
-if (logicalHeightLength.isMinContent() || logicalHeightLength.isMaxContent() || logicalHeightLength.isFitContent())
+if (logicalHeightLength.isMinContent() || logicalHeightLength.isMaxContent() || logicalHeightLength.isFitContent()) {
+if (!intrinsicContentHeight)
+return intrinsicContentHeight;
+if (style().boxSizing() == BORDER_BOX)
+return intrinsicContentHeight.value() + borderAndPaddingLogicalHeight();
 return intrinsicContentHeight;
+}
 if (logicalHeightLength.isFillAvailable())
 return containingBlock()->availableLogicalHeight(ExcludeMarginBorderPadding) - borderAndPadding;
 ASSERT_NOT_REACHED();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199894] trunk/Source/JavaScriptCore

[commit-queue]

Title: [199894] trunk/Source/_javascript_Core








Revision 199894
Author commit-qu...@webkit.org
Date 2016-04-22 12:27:57 -0700 (Fri, 22 Apr 2016)


Log Message
[JSC] Integer Multiply of a number by itself does not need negative zero support
https://bugs.webkit.org/show_bug.cgi?id=156895

Patch by Benjamin Poulain  on 2016-04-22
Reviewed by Saam Barati.

You cannot produce negative zero by squaring an integer.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMul):
Minor codegen fixes:
-Use the right form of multiply for ARM.
-Use a sign-extended 32bit immediates, that's the one with fast forms
 in the MacroAssembler.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (199893 => 199894)

--- trunk/Source/_javascript_Core/ChangeLog	2016-04-22 19:25:40 UTC (rev 199893)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-22 19:27:57 UTC (rev 199894)
@@ -1,3 +1,21 @@
+2016-04-22  Benjamin Poulain  
+
+[JSC] Integer Multiply of a number by itself does not need negative zero support
+https://bugs.webkit.org/show_bug.cgi?id=156895
+
+Reviewed by Saam Barati.
+
+You cannot produce negative zero by squaring an integer.
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileArithMul):
+Minor codegen fixes:
+-Use the right form of multiply for ARM.
+-Use a sign-extended 32bit immediates, that's the one with fast forms
+ in the MacroAssembler.
+
 2016-04-21  Darin Adler  
 
 Follow-on to the build fix.


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (199893 => 199894)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2016-04-22 19:25:40 UTC (rev 199893)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2016-04-22 19:27:57 UTC (rev 199894)
@@ -322,6 +322,11 @@
 m_assembler.smull(dest, dataTempRegister, dest, src);
 }
 
+void mul32(RegisterID left, RegisterID right, RegisterID dest)
+{
+m_assembler.smull(dest, dataTempRegister, left, right);
+}
+
 void mul32(TrustedImm32 imm, RegisterID src, RegisterID dest)
 {
 move(imm, dataTempRegister);


Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (199893 => 199894)

--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2016-04-22 19:25:40 UTC (rev 199893)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2016-04-22 19:27:57 UTC (rev 199894)
@@ -248,7 +248,8 @@
 fixIntOrBooleanEdge(rightChild);
 if (bytecodeCanTruncateInteger(node->arithNodeFlags()))
 node->setArithMode(Arith::Unchecked);
-else if (bytecodeCanIgnoreNegativeZero(node->arithNodeFlags()))
+else if (bytecodeCanIgnoreNegativeZero(node->arithNodeFlags())
+|| leftChild.node() == rightChild.node())
 node->setArithMode(Arith::CheckOverflow);
 else
 node->setArithMode(Arith::CheckOverflowAndNegativeZero);
@@ -257,7 +258,8 @@
 if (m_graph.binaryArithShouldSpeculateMachineInt(node, FixupPass)) {
 fixEdge(leftChild);
 fixEdge(rightChild);
-if (bytecodeCanIgnoreNegativeZero(node->arithNodeFlags()))
+if (bytecodeCanIgnoreNegativeZero(node->arithNodeFlags())
+|| leftChild.node() == rightChild.node())
 node->setArithMode(Arith::CheckOverflow);
 else
 node->setArithMode(Arith::CheckOverflowAndNegativeZero);


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (199893 => 199894)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2016-04-22 19:25:40 UTC (rev 199893)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2016-04-22 19:27:57 UTC (rev 199894)
@@ -3964,10 +3964,9 @@
 // We can perform truncated multiplications if we get to this point, because if the
 // fixup phase could not prove that it would be safe, it would have turned us into
 // a double multiplication.
-if (!shouldCheckOverflow(node->arithMode())) {
-m_jit.move(reg1, result.gpr());
-m_jit.mul32(reg2, result.gpr());
-} else {
+if (!shouldCheckOverflow(node->arithMode()))
+m_jit.mul32(reg1, reg2, result.gpr());
+else {
 speculationCheck(
 Overflow, JSValueRegs(), 0,
 m_jit.branchMul32(MacroAssembler::Overflow, reg1, reg2, 

[webkit-changes] [199892] tags/Safari-602.1.29/

[bshafiei]

Title: [199892] tags/Safari-602.1.29/








Revision 199892
Author bshaf...@apple.com
Date 2016-04-22 12:25:28 -0700 (Fri, 22 Apr 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.1.29/




Diff

Property changes: tags/Safari-602.1.29



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199893] trunk/Source/WebCore

[antti]

Title: [199893] trunk/Source/WebCore








Revision 199893
Author an...@apple.com
Date 2016-04-22 12:25:40 -0700 (Fri, 22 Apr 2016)


Log Message
TextAutoSizingKey should use normal refcounting
https://bugs.webkit.org/show_bug.cgi?id=156893

Reviewed by Andreas Kling.

Get rid of special refcounting of style in favor of RefPtr. It also becomes a move-only type
to support future switch to non-refcounted RenderStyle.

Also general cleanups and modernization.

* dom/Document.cpp:
(WebCore::TextAutoSizingTraits::constructDeletedValue):
(WebCore::TextAutoSizingTraits::isDeletedValue):
(WebCore::Document::addAutoSizingNode):
(WebCore::Document::validateAutoSizingNodes):
(WebCore::Document::resetAutoSizingNodes):

Adopt to being move-only.

* rendering/TextAutoSizing.cpp:
(WebCore::cloneRenderStyleWithState):
(WebCore::TextAutoSizingKey::TextAutoSizingKey):

Clone the style for safety against mutations. Cloning is cheap.

(WebCore::TextAutoSizingValue::numNodes):
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):
(WebCore::TextAutoSizingKey::~TextAutoSizingKey): Deleted.
(WebCore::TextAutoSizingKey::operator=): Deleted.
(WebCore::TextAutoSizingKey::ref): Deleted.
(WebCore::TextAutoSizingKey::deref): Deleted.
* rendering/TextAutoSizing.h:
(WebCore::TextAutoSizingKey::TextAutoSizingKey):
(WebCore::TextAutoSizingKey::style):
(WebCore::TextAutoSizingKey::isDeleted):
(WebCore::operator==):
(WebCore::TextAutoSizingKey::doc): Deleted.
(WebCore::TextAutoSizingKey::isValidDoc): Deleted.
(WebCore::TextAutoSizingKey::isValidStyle): Deleted.
(WebCore::TextAutoSizingKey::deletedKeyDoc): Deleted.
(WebCore::TextAutoSizingKey::deletedKeyStyle): Deleted.

m_doc member is not used for anything except deleted value comparisons. Replace it with a bit.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/rendering/TextAutoSizing.cpp
trunk/Source/WebCore/rendering/TextAutoSizing.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (199892 => 199893)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 19:25:28 UTC (rev 199892)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 19:25:40 UTC (rev 199893)
@@ -1,3 +1,50 @@
+2016-04-22  Antti Koivisto  
+
+TextAutoSizingKey should use normal refcounting
+https://bugs.webkit.org/show_bug.cgi?id=156893
+
+Reviewed by Andreas Kling.
+
+Get rid of special refcounting of style in favor of RefPtr. It also becomes a move-only type
+to support future switch to non-refcounted RenderStyle.
+
+Also general cleanups and modernization.
+
+* dom/Document.cpp:
+(WebCore::TextAutoSizingTraits::constructDeletedValue):
+(WebCore::TextAutoSizingTraits::isDeletedValue):
+(WebCore::Document::addAutoSizingNode):
+(WebCore::Document::validateAutoSizingNodes):
+(WebCore::Document::resetAutoSizingNodes):
+
+Adopt to being move-only.
+
+* rendering/TextAutoSizing.cpp:
+(WebCore::cloneRenderStyleWithState):
+(WebCore::TextAutoSizingKey::TextAutoSizingKey):
+
+Clone the style for safety against mutations. Cloning is cheap.
+
+(WebCore::TextAutoSizingValue::numNodes):
+(WebCore::TextAutoSizingValue::adjustNodeSizes):
+(WebCore::TextAutoSizingValue::reset):
+(WebCore::TextAutoSizingKey::~TextAutoSizingKey): Deleted.
+(WebCore::TextAutoSizingKey::operator=): Deleted.
+(WebCore::TextAutoSizingKey::ref): Deleted.
+(WebCore::TextAutoSizingKey::deref): Deleted.
+* rendering/TextAutoSizing.h:
+(WebCore::TextAutoSizingKey::TextAutoSizingKey):
+(WebCore::TextAutoSizingKey::style):
+(WebCore::TextAutoSizingKey::isDeleted):
+(WebCore::operator==):
+(WebCore::TextAutoSizingKey::doc): Deleted.
+(WebCore::TextAutoSizingKey::isValidDoc): Deleted.
+(WebCore::TextAutoSizingKey::isValidStyle): Deleted.
+(WebCore::TextAutoSizingKey::deletedKeyDoc): Deleted.
+(WebCore::TextAutoSizingKey::deletedKeyStyle): Deleted.
+
+m_doc member is not used for anything except deleted value comparisons. Replace it with a bit.
+
 2016-04-22  Chris Dumez  
 
 Crash under FontCache::purgeInactiveFontData()


Modified: trunk/Source/WebCore/dom/Document.cpp (199892 => 199893)

--- trunk/Source/WebCore/dom/Document.cpp	2016-04-22 19:25:28 UTC (rev 199892)
+++ trunk/Source/WebCore/dom/Document.cpp	2016-04-22 19:25:40 UTC (rev 199893)
@@ -428,12 +428,12 @@
 #if ENABLE(IOS_TEXT_AUTOSIZING)
 void TextAutoSizingTraits::constructDeletedValue(TextAutoSizingKey& slot)
 {
-new () TextAutoSizingKey(TextAutoSizingKey::deletedKeyStyle(), TextAutoSizingKey::deletedKeyDoc());
+new () TextAutoSizingKey(TextAutoSizingKey::Deleted);
 }
 
 bool TextAutoSizingTraits::isDeletedValue(const TextAutoSizingKey& value)
 {
-return value.style() == 

[webkit-changes] [199890] trunk/Source/WebCore

[cdumez]

Title: [199890] trunk/Source/WebCore








Revision 199890
Author cdu...@apple.com
Date 2016-04-22 12:24:42 -0700 (Fri, 22 Apr 2016)


Log Message
Crash under FontCache::purgeInactiveFontData()
https://bugs.webkit.org/show_bug.cgi?id=156822


Reviewed by Darin Adler.

In some rare cases, the Font constructor would mutate the FontPlatformData
that is being passed in. This is an issue because because our FontCache
uses the FontPlatformData as key for the cached fonts. This could lead to
crashes because the WTFMove() in FontCache::purgeInactiveFontData() would
nullify values in our HashMap but we would then fail to remove them from
the HashMap (because the key did not match). We would then reference the
null font when looping again when doing font->hasOneRef().

This patch marks Font::m_platformData member as const to avoid such issues
in the future and moves the code altering the FontPlatformData from the
Font constructor into the FontPlatformData constructor. The purpose of
that code was to initialize FontPlatformData::m_cgFont in case the CGFont
passed in the constructor was null.

* platform/graphics/Font.h:
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::fontForPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/FontPlatformData.h:
* platform/graphics/cocoa/FontCocoa.mm:
(WebCore::webFallbackFontFamily): Deleted.
(WebCore::Font::platformInit): Deleted.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::webFallbackFontFamily):
(WebCore::FontPlatformData::setFallbackCGFont):
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::setFallbackCGFont):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/platform/graphics/FontCache.cpp
trunk/Source/WebCore/platform/graphics/FontPlatformData.cpp
trunk/Source/WebCore/platform/graphics/FontPlatformData.h
trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformData.h
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/win/FontPlatformDataCGWin.cpp
trunk/Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp
trunk/Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp
trunk/Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199889 => 199890)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 19:22:54 UTC (rev 199889)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 19:24:42 UTC (rev 199890)
@@ -1,5 +1,43 @@
 2016-04-22  Chris Dumez  
 
+Crash under FontCache::purgeInactiveFontData()
+https://bugs.webkit.org/show_bug.cgi?id=156822
+
+
+Reviewed by Darin Adler.
+
+In some rare cases, the Font constructor would mutate the FontPlatformData
+that is being passed in. This is an issue because because our FontCache
+uses the FontPlatformData as key for the cached fonts. This could lead to
+crashes because the WTFMove() in FontCache::purgeInactiveFontData() would
+nullify values in our HashMap but we would then fail to remove them from
+the HashMap (because the key did not match). We would then reference the
+null font when looping again when doing font->hasOneRef().
+
+This patch marks Font::m_platformData member as const to avoid such issues
+in the future and moves the code altering the FontPlatformData from the
+Font constructor into the FontPlatformData constructor. The purpose of
+that code was to initialize FontPlatformData::m_cgFont in case the CGFont
+passed in the constructor was null.
+
+* platform/graphics/Font.h:
+* platform/graphics/FontCache.cpp:
+(WebCore::FontCache::fontForPlatformData):
+(WebCore::FontCache::purgeInactiveFontData):
+* platform/graphics/FontPlatformData.cpp:
+(WebCore::FontPlatformData::FontPlatformData):
+* platform/graphics/FontPlatformData.h:
+* platform/graphics/cocoa/FontCocoa.mm:
+(WebCore::webFallbackFontFamily): Deleted.
+(WebCore::Font::platformInit): Deleted.
+* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
+(WebCore::webFallbackFontFamily):
+(WebCore::FontPlatformData::setFallbackCGFont):
+* platform/graphics/win/FontPlatformDataCGWin.cpp:
+(WebCore::FontPlatformData::setFallbackCGFont):
+
+2016-04-22  Chris Dumez  
+
 Support disabling at runtime IndexedDB constructors exposed to workers
 https://bugs.webkit.org/show_bug.cgi?id=156883
 


Modified: trunk/Source/WebCore/platform/graphics/Font.h (199889 => 199890)

--- 

[webkit-changes] [199891] tags/Safari-602.1.29/

[bshafiei]

Title: [199891] tags/Safari-602.1.29/








Revision 199891
Author bshaf...@apple.com
Date 2016-04-22 12:25:02 -0700 (Fri, 22 Apr 2016)


Log Message
Delete tag.

Removed Paths

tags/Safari-602.1.29/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199889] trunk

[cdumez]

Title: [199889] trunk








Revision 199889
Author cdu...@apple.com
Date 2016-04-22 12:22:54 -0700 (Fri, 22 Apr 2016)


Log Message
Support disabling at runtime IndexedDB constructors exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=156883

Reviewed by Darin Adler.

Source/WebCore:

Support disabling at runtime IndexedDB constructors exposed to workers.
Previously, constructors visibility to workers and window was constrolled
by the same runtime flag.

* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBCursorWithValue.idl:
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBKeyRange.idl:
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.idl:
* Modules/indexeddb/IDBVersionChangeEvent.idl:
* workers/WorkerGlobalScope.idl:

LayoutTests:

Add layout test coverage.

* storage/indexeddb/modern/resources/workers-disabled.js:
* storage/indexeddb/modern/resources/workers-enable.js:
* storage/indexeddb/modern/workers-disabled-expected.txt:
* storage/indexeddb/modern/workers-enable-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/modern/resources/workers-disabled.js
trunk/LayoutTests/storage/indexeddb/modern/resources/workers-enable.js
trunk/LayoutTests/storage/indexeddb/modern/workers-disabled-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/workers-enable-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl
trunk/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.idl
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.idl
trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.idl
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl
trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.idl
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.idl
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.idl
trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl
trunk/Source/WebCore/workers/WorkerGlobalScope.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (199888 => 199889)

--- trunk/LayoutTests/ChangeLog	2016-04-22 19:14:50 UTC (rev 199888)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 19:22:54 UTC (rev 199889)
@@ -1,3 +1,17 @@
+2016-04-22  Chris Dumez  
+
+Support disabling at runtime IndexedDB constructors exposed to workers
+https://bugs.webkit.org/show_bug.cgi?id=156883
+
+Reviewed by Darin Adler.
+
+Add layout test coverage.
+
+* storage/indexeddb/modern/resources/workers-disabled.js:
+* storage/indexeddb/modern/resources/workers-enable.js:
+* storage/indexeddb/modern/workers-disabled-expected.txt:
+* storage/indexeddb/modern/workers-enable-expected.txt:
+
 2016-04-22  Dave Hyatt  
 
 -webkit-image-set doesn't work inside CSS variables


Modified: trunk/LayoutTests/storage/indexeddb/modern/resources/workers-disabled.js (199888 => 199889)

--- trunk/LayoutTests/storage/indexeddb/modern/resources/workers-disabled.js	2016-04-22 19:14:50 UTC (rev 199888)
+++ trunk/LayoutTests/storage/indexeddb/modern/resources/workers-disabled.js	2016-04-22 19:22:54 UTC (rev 199889)
@@ -5,6 +5,12 @@
 
 description("Check to make sure IndexedDB in workers can be disabled at runtime");
 
-shouldBeUndefined("self.indexedDB");
+var propertiesToTest = ['indexedDB', 'IDBCursor', 'IDBCursorWithValue', 'IDBDatabase', 'IDBFactory', 'IDBIndex', 'IDBKeyRange', 'IDBObjectStore', 'IDBOpenDBRequest', 'IDBRequest', 'IDBTransaction', 'IDBVersionChangeEvent'];
 
+for (var i = 0; i < propertiesToTest.length; i++) {
+propertyToTest = propertiesToTest[i];
+shouldBeUndefined("self." + propertyToTest);
+shouldBeFalse("'" + propertyToTest + "' in self");
+}
+
 finishJSTest();


Modified: trunk/LayoutTests/storage/indexeddb/modern/resources/workers-enable.js (199888 => 199889)

--- trunk/LayoutTests/storage/indexeddb/modern/resources/workers-enable.js	2016-04-22 19:14:50 UTC (rev 199888)
+++ trunk/LayoutTests/storage/indexeddb/modern/resources/workers-enable.js	2016-04-22 19:22:54 UTC (rev 199889)
@@ -5,8 +5,15 @@
 
 description("Check to make sure we can enable IndexedDB in workers via a runtime setting");
 
-shouldBeDefined("self.indexedDB");
-shouldBeNonNull("self.indexedDB");
+var propertiesToTest = ['indexedDB', 'IDBCursor', 'IDBCursorWithValue', 'IDBDatabase', 'IDBFactory', 'IDBIndex', 'IDBKeyRange', 'IDBObjectStore', 'IDBOpenDBRequest', 'IDBRequest', 'IDBTransaction', 'IDBVersionChangeEvent'];
+
+for (var i = 0; i < propertiesToTest.length; i++) {
+propertyToTest = propertiesToTest[i];
+shouldBeDefined("self." + propertyToTest);
+shouldBeNonNull("self." + propertyToTest);
+shouldBeTrue("'" + propertyToTest + "' 

[webkit-changes] [199888] trunk/Source

[bshafiei]

Title: [199888] trunk/Source








Revision 199888
Author bshaf...@apple.com
Date 2016-04-22 12:14:50 -0700 (Fri, 22 Apr 2016)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (199887 => 199888)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-22 19:13:29 UTC (rev 199887)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2016-04-22 19:14:50 UTC (rev 199888)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 30;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (199887 => 199888)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2016-04-22 19:13:29 UTC (rev 199887)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2016-04-22 19:14:50 UTC (rev 199888)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 30;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (199887 => 199888)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-22 19:13:29 UTC (rev 199887)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-04-22 19:14:50 UTC (rev 199888)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 30;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (199887 => 199888)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-22 19:13:29 UTC (rev 199887)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2016-04-22 19:14:50 UTC (rev 199888)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 30;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (199887 => 199888)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2016-04-22 19:13:29 UTC (rev 199887)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2016-04-22 19:14:50 UTC (rev 199888)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 29;
+TINY_VERSION = 30;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199887] tags/Safari-602.1.29/

[bshafiei]

Title: [199887] tags/Safari-602.1.29/








Revision 199887
Author bshaf...@apple.com
Date 2016-04-22 12:13:29 -0700 (Fri, 22 Apr 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.1.29/




Diff

Property changes: tags/Safari-602.1.29



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199886] trunk/Source/WebCore

[dino]

Title: [199886] trunk/Source/WebCore








Revision 199886
Author d...@apple.com
Date 2016-04-22 12:01:06 -0700 (Fri, 22 Apr 2016)


Log Message
Attempting to fix Windows build. Add isHidden implementation.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::isHidden):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199885 => 199886)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 18:59:28 UTC (rev 199885)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 19:01:06 UTC (rev 199886)
@@ -1,3 +1,10 @@
+2016-04-22  Dean Jackson  
+
+Attempting to fix Windows build. Add isHidden implementation.
+
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayerWin::isHidden):
+
 2016-04-22  Brady Eidson  
 
 Attempt at a Windows build fix.


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (199885 => 199886)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 18:59:28 UTC (rev 199885)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2016-04-22 19:01:06 UTC (rev 199886)
@@ -437,6 +437,11 @@
 setNeedsCommit();
 }
 
+bool PlatformCALayerWin::isHidden(bool value) const
+{
+return CACFLayerGetHidden(m_layer.get());
+}
+
 void PlatformCALayerWin::setHidden(bool value)
 {
 CACFLayerSetHidden(m_layer.get(), value);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199885] trunk/Source/WebCore

[beidson]

Title: [199885] trunk/Source/WebCore








Revision 199885
Author beid...@apple.com
Date 2016-04-22 11:59:28 -0700 (Fri, 22 Apr 2016)


Log Message
Attempt at a Windows build fix.

* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199884 => 199885)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 18:27:23 UTC (rev 199884)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 18:59:28 UTC (rev 199885)
@@ -1,3 +1,10 @@
+2016-04-22  Brady Eidson  
+
+Attempt at a Windows build fix.
+
+* workers/WorkerMessagingProxy.cpp:
+(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
+
 2016-04-22  Dave Hyatt  
 
  -webkit-image-set doesn't work inside CSS variables


Modified: trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp (199884 => 199885)

--- trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp	2016-04-22 18:27:23 UTC (rev 199884)
+++ trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp	2016-04-22 18:59:28 UTC (rev 199885)
@@ -78,7 +78,12 @@
 ASSERT(m_scriptExecutionContext);
 Document& document = downcast(*m_scriptExecutionContext);
 
+#if ENABLE(INDEXED_DATABASE)
 RefPtr thread = DedicatedWorkerThread::create(scriptURL, userAgent, sourceCode, *this, *this, startMode, contentSecurityPolicyResponseHeaders, shouldBypassMainWorldContentSecurityPolicy, document.topOrigin(), document.idbConnectionProxy());
+#else
+RefPtr thread = DedicatedWorkerThread::create(scriptURL, userAgent, sourceCode, *this, *this, startMode, contentSecurityPolicyResponseHeaders, shouldBypassMainWorldContentSecurityPolicy, document.topOrigin(), nullptr);
+#endif
+
 workerThreadCreated(thread);
 thread->start();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199884] trunk

[hyatt]

Title: [199884] trunk








Revision 199884
Author hy...@apple.com
Date 2016-04-22 11:27:23 -0700 (Fri, 22 Apr 2016)


Log Message

Source/WebCore:
 -webkit-image-set doesn't work inside CSS variables
https://bugs.webkit.org/show_bug.cgi?id=156915


Reviewed by Zalan Bujtas.

Added new tests in fast/hidpi.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::equals):
(WebCore::CSSPrimitiveValue::buildParserValue):

LayoutTests:
-webkit-image-set doesn't work inside CSS variables
https://bugs.webkit.org/show_bug.cgi?id=156915


Reviewed by Zalan Bujtas.

* fast/hidpi/image-srcset-simple-in-variable-1x-expected.txt: Added.
* fast/hidpi/image-srcset-simple-in-variable-1x.html: Added.
* fast/hidpi/image-srcset-simple-in-variable-2x-expected.txt: Added.
* fast/hidpi/image-srcset-simple-in-variable-2x.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp


Added Paths

trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x-expected.txt
trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x.html
trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x-expected.txt
trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199883 => 199884)

--- trunk/LayoutTests/ChangeLog	2016-04-22 18:17:32 UTC (rev 199883)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 18:27:23 UTC (rev 199884)
@@ -1,3 +1,16 @@
+2016-04-22  Dave Hyatt  
+
+-webkit-image-set doesn't work inside CSS variables
+https://bugs.webkit.org/show_bug.cgi?id=156915
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/hidpi/image-srcset-simple-in-variable-1x-expected.txt: Added.
+* fast/hidpi/image-srcset-simple-in-variable-1x.html: Added.
+* fast/hidpi/image-srcset-simple-in-variable-2x-expected.txt: Added.
+* fast/hidpi/image-srcset-simple-in-variable-2x.html: Added.
+
 2016-04-22  Commit Queue  
 
 Unreviewed, rolling out r199877.


Added: trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x-expected.txt (0 => 199884)

--- trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x-expected.txt	2016-04-22 18:27:23 UTC (rev 199884)
@@ -0,0 +1,3 @@
+PASS document.getElementById("foo").clientWidth==400 is true
+This test passes if the image below says 1x with a reddish background when the deviceScaleFactor is 1, and if says 2x with a greenish background when the deviceScaleFactor is 2.
+


Added: trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x.html (0 => 199884)

--- trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x.html	(rev 0)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-1x.html	2016-04-22 18:27:23 UTC (rev 199884)
@@ -0,0 +1,26 @@
+
+
+
+window.targetScaleFactor = 1;
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function runTest()
+{
+shouldBeTrue('document.getElementById("foo").clientWidth==400');
+}
+
+
+#foo { --image-set: -webkit-image-set(url(resources/image-set-1x.png) 1x, url(resources/deleteButton.png) 3x, url(resources/image-set-2x.png) 2x); }
+
+
+
+
+This test passes if the image below says 1x with a reddish background when the deviceScaleFactor is 1, and if says 2x with a greenish background when the deviceScaleFactor is 2.
+
+
+


Added: trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x-expected.txt (0 => 199884)

--- trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x-expected.txt	2016-04-22 18:27:23 UTC (rev 199884)
@@ -0,0 +1,3 @@
+PASS document.getElementById("foo").clientWidth==200 is true
+This test passes if the image below says 1x with a reddish background when the deviceScaleFactor is 1, and if says 2x with a greenish background when the deviceScaleFactor is 2.
+


Added: trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x.html (0 => 199884)

--- trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x.html	(rev 0)
+++ trunk/LayoutTests/fast/hidpi/image-srcset-simple-in-variable-2x.html	2016-04-22 18:27:23 UTC (rev 199884)
@@ -0,0 +1,23 @@
+
+
+
+window.targetScaleFactor = 2;
+
+
+function runTest()
+{
+shouldBeTrue('document.getElementById("foo").clientWidth==200');
+}
+
+
+#foo { --image-set: -webkit-image-set(url(resources/blue-100-px-square.png) 1x, url(resources/deleteButton.png) 3x, url(resources/green-400-px-square.png) 2x); }
+
+
+
+
+This test passes if the image below says 1x with a reddish background when the deviceScaleFactor is 1, and if says 2x with a greenish background when the 

[webkit-changes] [199883] trunk

[ryanhaddad]

Title: [199883] trunk








Revision 199883
Author ryanhad...@apple.com
Date 2016-04-22 11:17:32 -0700 (Fri, 22 Apr 2016)


Log Message
Unreviewed, rolling out r199877.
https://bugs.webkit.org/show_bug.cgi?id=156918

The LayoutTest added with this change is failing on all
platforms. (Requested by ryanhaddad on #webkit).

Reverted changeset:

"REGRESSION (r189567): The top of Facebook's messenger.com
looks visually broken"
https://bugs.webkit.org/show_bug.cgi?id=156869
http://trac.webkit.org/changeset/199877

Patch by Commit Queue  on 2016-04-22

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Removed Paths

trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html
trunk/LayoutTests/fast/block/min-content-with-box-sizing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199882 => 199883)

--- trunk/LayoutTests/ChangeLog	2016-04-22 18:06:04 UTC (rev 199882)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 18:17:32 UTC (rev 199883)
@@ -1,3 +1,18 @@
+2016-04-22  Commit Queue  
+
+Unreviewed, rolling out r199877.
+https://bugs.webkit.org/show_bug.cgi?id=156918
+
+The LayoutTest added with this change is failing on all
+platforms. (Requested by ryanhaddad on #webkit).
+
+Reverted changeset:
+
+"REGRESSION (r189567): The top of Facebook's messenger.com
+looks visually broken"
+https://bugs.webkit.org/show_bug.cgi?id=156869
+http://trac.webkit.org/changeset/199877
+
 2016-04-22  Antti Koivisto  
 
 REGRESSION (r194898): Multi download of external SVG defs file by  xlinks:href (caching)


Deleted: trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html (199882 => 199883)

--- trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html	2016-04-22 18:06:04 UTC (rev 199882)
+++ trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html	2016-04-22 18:17:32 UTC (rev 199883)
@@ -1,3 +0,0 @@
-
-
-


Deleted: trunk/LayoutTests/fast/block/min-content-with-box-sizing.html (199882 => 199883)

--- trunk/LayoutTests/fast/block/min-content-with-box-sizing.html	2016-04-22 18:06:04 UTC (rev 199882)
+++ trunk/LayoutTests/fast/block/min-content-with-box-sizing.html	2016-04-22 18:17:32 UTC (rev 199883)
@@ -1,3 +0,0 @@
-
-
-


Modified: trunk/Source/WebCore/ChangeLog (199882 => 199883)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 18:06:04 UTC (rev 199882)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 18:17:32 UTC (rev 199883)
@@ -1,3 +1,18 @@
+2016-04-22  Commit Queue  
+
+Unreviewed, rolling out r199877.
+https://bugs.webkit.org/show_bug.cgi?id=156918
+
+The LayoutTest added with this change is failing on all
+platforms. (Requested by ryanhaddad on #webkit).
+
+Reverted changeset:
+
+"REGRESSION (r189567): The top of Facebook's messenger.com
+looks visually broken"
+https://bugs.webkit.org/show_bug.cgi?id=156869
+http://trac.webkit.org/changeset/199877
+
 2016-04-22  Brady Eidson  
 
 Modern IDB: Rework the ownership/RefCounting model of IDBConnectionToServer and IDBConnectionProxy.


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (199882 => 199883)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2016-04-22 18:06:04 UTC (rev 199882)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2016-04-22 18:17:32 UTC (rev 199883)
@@ -2889,11 +2889,8 @@
 
 Optional RenderBox::computeContentLogicalHeight(SizeType heightType, const Length& height, Optional intrinsicContentHeight) const
 {
-if (Optional heightIncludingScrollbar = computeContentAndScrollbarLogicalHeightUsing(heightType, height, intrinsicContentHeight)) {
-if (height.isIntrinsic())
-return std::max(0, heightIncludingScrollbar.value() - scrollbarLogicalHeight());
+if (Optional heightIncludingScrollbar = computeContentAndScrollbarLogicalHeightUsing(heightType, height, intrinsicContentHeight))
 return std::max(0, adjustContentBoxLogicalHeightForBoxSizing(heightIncludingScrollbar) - scrollbarLogicalHeight());
-}
 return Nullopt;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199882] trunk/Source

[beidson]

Title: [199882] trunk/Source








Revision 199882
Author beid...@apple.com
Date 2016-04-22 11:06:04 -0700 (Fri, 22 Apr 2016)


Log Message
Modern IDB: Rework the ownership/RefCounting model of IDBConnectionToServer and IDBConnectionProxy.
https://bugs.webkit.org/show_bug.cgi?id=156916

Reviewed by Tim Horton.

Source/WebCore:

No new tests (No behavior change).

* Modules/indexeddb/IDBFactory.cpp: Remove unneeded include.

* Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::ref): Ref the ConnectionToServer.
(WebCore::IDBClient::IDBConnectionProxy::deref): Deref it.
(WebCore::IDBClient::IDBConnectionProxy::connectionToServer):
(WebCore::IDBClient::IDBConnectionProxy::openDatabase):
(WebCore::IDBClient::IDBConnectionProxy::deleteDatabase):
(WebCore::IDBClient::IDBConnectionProxy::create): Deleted.
* Modules/indexeddb/client/IDBConnectionProxy.h:

* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::IDBConnectionToServer): Create a proxy owned by this.
(WebCore::IDBClient::IDBConnectionToServer::proxy): Expose it.
* Modules/indexeddb/client/IDBConnectionToServer.h:

* dom/Document.cpp:
(WebCore::Document::idbConnectionProxy):

* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199881 => 199882)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 17:37:09 UTC (rev 199881)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 18:06:04 UTC (rev 199882)
@@ -1,3 +1,33 @@
+2016-04-22  Brady Eidson  
+
+Modern IDB: Rework the ownership/RefCounting model of IDBConnectionToServer and IDBConnectionProxy.
+https://bugs.webkit.org/show_bug.cgi?id=156916
+
+Reviewed by Tim Horton.
+
+No new tests (No behavior change).
+
+* Modules/indexeddb/IDBFactory.cpp: Remove unneeded include.
+
+* Modules/indexeddb/client/IDBConnectionProxy.cpp:
+(WebCore::IDBClient::IDBConnectionProxy::ref): Ref the ConnectionToServer.
+(WebCore::IDBClient::IDBConnectionProxy::deref): Deref it.
+(WebCore::IDBClient::IDBConnectionProxy::connectionToServer):
+(WebCore::IDBClient::IDBConnectionProxy::openDatabase):
+(WebCore::IDBClient::IDBConnectionProxy::deleteDatabase):
+(WebCore::IDBClient::IDBConnectionProxy::create): Deleted.
+* Modules/indexeddb/client/IDBConnectionProxy.h:
+
+* Modules/indexeddb/client/IDBConnectionToServer.cpp:
+(WebCore::IDBClient::IDBConnectionToServer::IDBConnectionToServer): Create a proxy owned by this.
+(WebCore::IDBClient::IDBConnectionToServer::proxy): Expose it.
+* Modules/indexeddb/client/IDBConnectionToServer.h:
+
+* dom/Document.cpp:
+(WebCore::Document::idbConnectionProxy):
+
+* WebCore.xcodeproj/project.pbxproj:
+
 2016-04-22  Antti Koivisto  
 
 REGRESSION (r194898): Multi download of external SVG defs file by  xlinks:href (caching)


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp (199881 => 199882)

--- trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp	2016-04-22 17:37:09 UTC (rev 199881)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp	2016-04-22 18:06:04 UTC (rev 199882)
@@ -32,7 +32,6 @@
 #include "ExceptionCode.h"
 #include "IDBBindingUtilities.h"
 #include "IDBConnectionProxy.h"
-#include "IDBConnectionToServer.h"
 #include "IDBDatabaseIdentifier.h"
 #include "IDBKey.h"
 #include "IDBOpenDBRequest.h"


Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp (199881 => 199882)

--- trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp	2016-04-22 17:37:09 UTC (rev 199881)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp	2016-04-22 18:06:04 UTC (rev 199882)
@@ -34,11 +34,6 @@
 namespace WebCore {
 namespace IDBClient {
 
-Ref IDBConnectionProxy::create(IDBConnectionToServer& connection)
-{
-return adoptRef(*new IDBConnectionProxy(connection));
-}
-
 IDBConnectionProxy::IDBConnectionProxy(IDBConnectionToServer& connection)
 : m_connectionToServer(connection)
 , m_serverConnectionIdentifier(connection.identifier())
@@ -46,13 +41,23 @@
 

[webkit-changes] [199881] trunk

[antti]

Title: [199881] trunk








Revision 199881
Author an...@apple.com
Date 2016-04-22 10:37:09 -0700 (Fri, 22 Apr 2016)


Log Message
REGRESSION (r194898): Multi download of external SVG defs file by  xlinks:href (caching)
https://bugs.webkit.org/show_bug.cgi?id=156368


Reviewed by Simon Fraser.

Source/WebCore:

We would load svg resources with fragment identifier again because the encoding never matched.

Test: http/tests/svg/svg-use-external.html

* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::setEncoding):
(WebCore::TextResourceDecoder::hasEqualEncodingForCharset):

Encoding can depend on mime type. Add a comparison function that takes this into account.

(WebCore::findXMLEncoding):
* loader/TextResourceDecoder.h:
(WebCore::TextResourceDecoder::encoding):
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedResource.h:
(WebCore::CachedResource::textResourceDecoder):

Add a way to get the TextResourceDecoder from a cached resource.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

Use the new comparison function.

* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedScript.h:
* loader/cache/CachedXSLStyleSheet.h:

LayoutTests:

* http/tests/svg/resources/symbol-defs.svg: Added.
* http/tests/svg/svg-use-external-expected.txt: Added.
* http/tests/svg/svg-use-external.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/TextResourceDecoder.cpp
trunk/Source/WebCore/loader/TextResourceDecoder.h
trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.h
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedSVGDocument.h
trunk/Source/WebCore/loader/cache/CachedScript.h
trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.h


Added Paths

trunk/LayoutTests/http/tests/svg/resources/symbol-defs.svg
trunk/LayoutTests/http/tests/svg/svg-use-external-expected.txt
trunk/LayoutTests/http/tests/svg/svg-use-external.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199880 => 199881)

--- trunk/LayoutTests/ChangeLog	2016-04-22 17:18:40 UTC (rev 199880)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 17:37:09 UTC (rev 199881)
@@ -1,3 +1,15 @@
+2016-04-22  Antti Koivisto  
+
+REGRESSION (r194898): Multi download of external SVG defs file by  xlinks:href (caching)
+https://bugs.webkit.org/show_bug.cgi?id=156368
+
+
+Reviewed by Simon Fraser.
+
+* http/tests/svg/resources/symbol-defs.svg: Added.
+* http/tests/svg/svg-use-external-expected.txt: Added.
+* http/tests/svg/svg-use-external.html: Added.
+
 2016-04-22  Chris Dumez  
 
 Drop [UsePointersEvenForNonNullableObjectArguments] from MutationObserver


Added: trunk/LayoutTests/http/tests/svg/resources/symbol-defs.svg (0 => 199881)

--- trunk/LayoutTests/http/tests/svg/resources/symbol-defs.svg	(rev 0)
+++ trunk/LayoutTests/http/tests/svg/resources/symbol-defs.svg	2016-04-22 17:37:09 UTC (rev 199881)
@@ -0,0 +1,28 @@
+
+
+
+rocket
+
+
+
+fire
+
+
+
+lab
+
+
+
+magnet
+
+
+
+shield
+
+
+
+power
+
+
+
+
Property changes on: trunk/LayoutTests/http/tests/svg/resources/symbol-defs.svg
___


Added: svn:executable

Added: trunk/LayoutTests/http/tests/svg/svg-use-external-expected.txt (0 => 199881)

--- trunk/LayoutTests/http/tests/svg/svg-use-external-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/svg/svg-use-external-expected.txt	2016-04-22 17:37:09 UTC (rev 199881)
@@ -0,0 +1,5 @@
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - willSendRequest  redirectResponse (null)
+http://127.0.0.1:8000/svg/svg-use-external.html - didFinishLoading
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - didReceiveResponse 
+http://127.0.0.1:8000/svg/resources/symbol-defs.svg#icon-rocket - didFinishLoading
+   


Added: trunk/LayoutTests/http/tests/svg/svg-use-external.html (0 => 199881)

--- trunk/LayoutTests/http/tests/svg/svg-use-external.html	(rev 0)
+++ trunk/LayoutTests/http/tests/svg/svg-use-external.html	2016-04-22 17:37:09 UTC (rev 199881)
@@ -0,0 +1,44 @@
+
+
+
+
+
+
+Verify that the SVG use resource only loads once
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.dumpResourceLoadCallbacks();
+testRunner.waitUntilDone();
+_onload_ = function() {
+testRunner.notifyDone();
+}
+}
+
+
+
+
+
+
+
+
+
+
+   

[webkit-changes] [199880] trunk/Tools

[ryanhaddad]

Title: [199880] trunk/Tools








Revision 199880
Author ryanhad...@apple.com
Date 2016-04-22 10:18:40 -0700 (Fri, 22 Apr 2016)


Log Message
Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854

Unreviewed test gardening.

* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp




Diff

Modified: trunk/Tools/ChangeLog (199879 => 199880)

--- trunk/Tools/ChangeLog	2016-04-22 16:13:05 UTC (rev 199879)
+++ trunk/Tools/ChangeLog	2016-04-22 17:18:40 UTC (rev 199880)
@@ -1,3 +1,12 @@
+2016-04-22  Ryan Haddad  
+
+Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
+(TestWebKitAPI::TEST):
+
 2016-04-22  Carlos Garcia Campos  
 
 [GTK] Enable the download attribute support


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp (199879 => 199880)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp	2016-04-22 16:13:05 UTC (rev 199879)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp	2016-04-22 17:18:40 UTC (rev 199880)
@@ -74,7 +74,7 @@
 
 EXPECT_TRUE(WKPreferencesGetJavaScriptEnabled(preference));
 EXPECT_TRUE(WKPreferencesGetLoadsImagesAutomatically(preference));
-EXPECT_FALSE(WKPreferencesGetOfflineWebApplicationCacheEnabled(preference));
+EXPECT_TRUE(WKPreferencesGetOfflineWebApplicationCacheEnabled(preference));
 EXPECT_TRUE(WKPreferencesGetLocalStorageEnabled(preference));
 EXPECT_TRUE(WKPreferencesGetXSSAuditorEnabled(preference));
 EXPECT_FALSE(WKPreferencesGetFrameFlatteningEnabled(preference));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199879] trunk/Source/WebCore

[youenn . fablet]

Title: [199879] trunk/Source/WebCore








Revision 199879
Author youenn.fab...@crf.canon.fr
Date 2016-04-22 09:13:05 -0700 (Fri, 22 Apr 2016)


Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from InspectorFrontendHost
https://bugs.webkit.org/show_bug.cgi?id=156908

Reviewed by Timothy Hatcher.

No change of behavior.

* inspector/InspectorFrontendHost.idl: Marking event parameter as nullable to keep compatibility.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorFrontendHost.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (199878 => 199879)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 15:59:10 UTC (rev 199878)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 16:13:05 UTC (rev 199879)
@@ -1,3 +1,14 @@
+2016-04-22  Youenn Fablet  
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from InspectorFrontendHost
+https://bugs.webkit.org/show_bug.cgi?id=156908
+
+Reviewed by Timothy Hatcher.
+
+No change of behavior.
+
+* inspector/InspectorFrontendHost.idl: Marking event parameter as nullable to keep compatibility.
+
 2016-04-22  Chris Dumez  
 
 Drop [UsePointersEvenForNonNullableObjectArguments] from MutationObserver


Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (199878 => 199879)

--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl	2016-04-22 15:59:10 UTC (rev 199878)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl	2016-04-22 16:13:05 UTC (rev 199879)
@@ -31,9 +31,8 @@
  */
 
 [
+ImplementationLacksVTable,
 NoInterfaceObject,
-UsePointersEvenForNonNullableObjectArguments,
-ImplementationLacksVTable
 ] interface InspectorFrontendHost {
 void loaded();
 void closeWindow();
@@ -67,7 +66,7 @@
 DOMString port();
 
 [Custom] void showContextMenu(MouseEvent event, any items);
-void dispatchEventAsContextMenuEvent(Event event);
+void dispatchEventAsContextMenuEvent(Event? event);
 void sendMessageToBackend(DOMString message);
 void unbufferedLog(DOMString message);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199878] trunk

[cdumez]

Title: [199878] trunk








Revision 199878
Author cdu...@apple.com
Date 2016-04-22 08:59:10 -0700 (Fri, 22 Apr 2016)


Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from MutationObserver
https://bugs.webkit.org/show_bug.cgi?id=156890

Reviewed by Darin Adler.

Source/WebCore:

Drop [UsePointersEvenForNonNullableObjectArguments] from MutationObserver
and clean up / modernize the code a bit. There is not significant Web-
exposed behavior change except that MutationObserver.observe() now throws
a different kind of exception (a TypeError as per Web IDL) when passed in
a null Node.

No new tests, rebaselined existing test.

* bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call):
* bindings/js/JSMutationCallback.h:
* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::constructJSMutationObserver):
* css/PropertySetCSSStyleDeclaration.cpp:
* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord):
* dom/MutationCallback.h:
* dom/MutationObserver.cpp:
(WebCore::MutationObserver::create):
(WebCore::MutationObserver::MutationObserver):
(WebCore::MutationObserver::observe):
(WebCore::MutationObserver::takeRecords):
(WebCore::MutationObserver::enqueueMutationRecord):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::disconnect): Deleted.
* dom/MutationObserver.h:
* dom/MutationObserver.idl:
* dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
* dom/MutationObserverInterestGroup.h:
* dom/MutationRecord.cpp:
(WebCore::MutationRecord::createChildList):
* dom/MutationRecord.h:

LayoutTests:

Rebaseline now that MutationObserver.observe() throws a TypeError instead
of a NOT_FOUND_ERR when passed a null Node.

* fast/dom/MutationObserver/observe-exceptions-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/MutationObserver/observe-exceptions-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSMutationCallback.cpp
trunk/Source/WebCore/bindings/js/JSMutationCallback.h
trunk/Source/WebCore/bindings/js/JSMutationObserverCustom.cpp
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
trunk/Source/WebCore/dom/ChildListMutationScope.cpp
trunk/Source/WebCore/dom/MutationCallback.h
trunk/Source/WebCore/dom/MutationObserver.cpp
trunk/Source/WebCore/dom/MutationObserver.h
trunk/Source/WebCore/dom/MutationObserver.idl
trunk/Source/WebCore/dom/MutationObserverInterestGroup.cpp
trunk/Source/WebCore/dom/MutationObserverInterestGroup.h
trunk/Source/WebCore/dom/MutationRecord.cpp
trunk/Source/WebCore/dom/MutationRecord.h




Diff

Modified: trunk/LayoutTests/ChangeLog (199877 => 199878)

--- trunk/LayoutTests/ChangeLog	2016-04-22 15:58:02 UTC (rev 199877)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 15:59:10 UTC (rev 199878)
@@ -1,3 +1,15 @@
+2016-04-22  Chris Dumez  
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from MutationObserver
+https://bugs.webkit.org/show_bug.cgi?id=156890
+
+Reviewed by Darin Adler.
+
+Rebaseline now that MutationObserver.observe() throws a TypeError instead
+of a NOT_FOUND_ERR when passed a null Node.
+
+* fast/dom/MutationObserver/observe-exceptions-expected.txt:
+
 2016-04-22  Dave Hyatt  
 
 REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken


Modified: trunk/LayoutTests/fast/dom/MutationObserver/observe-exceptions-expected.txt (199877 => 199878)

--- trunk/LayoutTests/fast/dom/MutationObserver/observe-exceptions-expected.txt	2016-04-22 15:58:02 UTC (rev 199877)
+++ trunk/LayoutTests/fast/dom/MutationObserver/observe-exceptions-expected.txt	2016-04-22 15:59:10 UTC (rev 199878)
@@ -7,17 +7,17 @@
 PASS observer.observe(null) threw exception TypeError: Not enough arguments.
 PASS observer.observe(undefined) threw exception TypeError: Not enough arguments.
 PASS observer.observe(document.body) threw exception TypeError: Not enough arguments.
-PASS observer.observe(document.body, null) threw exception Error: SyntaxError: DOM Exception 12.
-PASS observer.observe(document.body, undefined) threw exception Error: SyntaxError: DOM Exception 12.
-PASS observer.observe(null, {attributes: true}) threw exception Error: NotFoundError: DOM Exception 8.
-PASS observer.observe(undefined, {attributes: true}) threw exception Error: NotFoundError: DOM Exception 8.
-PASS observer.observe(document.body, {subtree: true}) threw exception Error: SyntaxError: DOM Exception 12.
+PASS observer.observe(document.body, null) threw exception TypeError: Type error.
+PASS observer.observe(document.body, undefined) threw exception TypeError: Type error.
+PASS observer.observe(null, {attributes: true}) threw exception TypeError: Type error.
+PASS observer.observe(undefined, {attributes: true}) threw exception TypeError: Type error.
+PASS observer.observe(document.body, {subtree: true}) threw exception 

[webkit-changes] [199877] trunk

[hyatt]

Title: [199877] trunk








Revision 199877
Author hy...@apple.com
Date 2016-04-22 08:58:02 -0700 (Fri, 22 Apr 2016)


Log Message
REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
https://bugs.webkit.org/show_bug.cgi?id=156869


Reviewed by Zalan Bujtas.

Source/WebCore:

Added fast/block/min-content-with-box-sizing.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeContentLogicalHeight):

LayoutTests:

* fast/block/min-content-with-box-sizing-expected.html: Added.
* fast/block/min-content-with-box-sizing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html
trunk/LayoutTests/fast/block/min-content-with-box-sizing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199876 => 199877)

--- trunk/LayoutTests/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 15:58:02 UTC (rev 199877)
@@ -1,3 +1,14 @@
+2016-04-22  Dave Hyatt  
+
+REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
+https://bugs.webkit.org/show_bug.cgi?id=156869
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/block/min-content-with-box-sizing-expected.html: Added.
+* fast/block/min-content-with-box-sizing.html: Added.
+
 2016-04-22  Carlos Garcia Campos  
 
 [GTK] Enable the download attribute support


Added: trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html (0 => 199877)

--- trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/block/min-content-with-box-sizing-expected.html	2016-04-22 15:58:02 UTC (rev 199877)
@@ -0,0 +1,3 @@
+
+
+


Added: trunk/LayoutTests/fast/block/min-content-with-box-sizing.html (0 => 199877)

--- trunk/LayoutTests/fast/block/min-content-with-box-sizing.html	(rev 0)
+++ trunk/LayoutTests/fast/block/min-content-with-box-sizing.html	2016-04-22 15:58:02 UTC (rev 199877)
@@ -0,0 +1,3 @@
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (199876 => 199877)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 15:58:02 UTC (rev 199877)
@@ -1,3 +1,16 @@
+2016-04-22  Dave Hyatt  
+
+REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
+https://bugs.webkit.org/show_bug.cgi?id=156869
+
+
+Reviewed by Zalan Bujtas.
+
+Added fast/block/min-content-with-box-sizing.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeContentLogicalHeight):
+
 2016-04-22  Manuel Rego Casasnovas  
 
 [css-grid] Fix bug with positioned items in vertical writing mode


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (199876 => 199877)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2016-04-22 12:49:03 UTC (rev 199876)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2016-04-22 15:58:02 UTC (rev 199877)
@@ -2889,8 +2889,11 @@
 
 Optional RenderBox::computeContentLogicalHeight(SizeType heightType, const Length& height, Optional intrinsicContentHeight) const
 {
-if (Optional heightIncludingScrollbar = computeContentAndScrollbarLogicalHeightUsing(heightType, height, intrinsicContentHeight))
+if (Optional heightIncludingScrollbar = computeContentAndScrollbarLogicalHeightUsing(heightType, height, intrinsicContentHeight)) {
+if (height.isIntrinsic())
+return std::max(0, heightIncludingScrollbar.value() - scrollbarLogicalHeight());
 return std::max(0, adjustContentBoxLogicalHeightForBoxSizing(heightIncludingScrollbar) - scrollbarLogicalHeight());
+}
 return Nullopt;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199876] trunk

[carlosgc]

Title: [199876] trunk








Revision 199876
Author carlo...@webkit.org
Date 2016-04-22 05:49:03 -0700 (Fri, 22 Apr 2016)


Log Message
[GTK] Enable the download attribute support
https://bugs.webkit.org/show_bug.cgi?id=99025

Reviewed by Žan Doberšek.

.:

* Source/cmake/OptionsGTK.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip tests that should pass now.

* platform/gtk/TestExpectations:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/cmake/OptionsGTK.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm




Diff

Modified: trunk/ChangeLog (199875 => 199876)

--- trunk/ChangeLog	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
@@ -1,3 +1,12 @@
+2016-04-22  Carlos Garcia Campos  
+
+[GTK] Enable the download attribute support
+https://bugs.webkit.org/show_bug.cgi?id=99025
+
+Reviewed by Žan Doberšek.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2016-04-18  Yusuke Suzuki  
 
 [JSCOnly] Implement RunLoop and remove glib dependency


Modified: trunk/LayoutTests/ChangeLog (199875 => 199876)

--- trunk/LayoutTests/ChangeLog	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
@@ -1,3 +1,14 @@
+2016-04-22  Carlos Garcia Campos  
+
+[GTK] Enable the download attribute support
+https://bugs.webkit.org/show_bug.cgi?id=99025
+
+Reviewed by Žan Doberšek.
+
+Unskip tests that should pass now.
+
+* platform/gtk/TestExpectations:
+
 2016-04-22  Manuel Rego Casasnovas  
 
 [css-grid] Fix bug with positioned items in vertical writing mode


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (199875 => 199876)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-04-22 12:49:03 UTC (rev 199876)
@@ -280,12 +280,6 @@
 webkit.org/b/99024 media/encrypted-media [ Skip ]
 webkit.org/b/99024 fast/events/constructors/media-key-event-constructor.html [ Timeout ]
 
-# Tests that require ENABLE(DOWNLOAD_ATTRIBUTE).
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-nodownload.html [ Pass ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-download.html [ Failure ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Failure ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Timeout Pass ]
-
 # CSS Filters is disabled
 webkit.org/b/99026 css3/filters [ Skip ]
 webkit.org/b/99026 fast/filter-image/filter-image.html [ Skip ]


Modified: trunk/Source/cmake/OptionsGTK.cmake (199875 => 199876)

--- trunk/Source/cmake/OptionsGTK.cmake	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Source/cmake/OptionsGTK.cmake	2016-04-22 12:49:03 UTC (rev 199876)
@@ -156,6 +156,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PRIVATE ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE ${ENABLE_FTL_DEFAULT})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PRIVATE ON)


Modified: trunk/Tools/ChangeLog (199875 => 199876)

--- trunk/Tools/ChangeLog	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Tools/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
@@ -1,3 +1,12 @@
+2016-04-22  Carlos Garcia Campos  
+
+[GTK] Enable the download attribute support
+https://bugs.webkit.org/show_bug.cgi?id=99025
+
+Reviewed by Žan Doberšek.
+
+* Scripts/webkitperl/FeatureList.pm:
+
 2016-04-21  Keith Miller  
 
 WebScriptObject description swizzler should work in a multi-threaded world


Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (199875 => 199876)

--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-04-22 12:49:03 UTC (rev 199876)
@@ -249,7 +249,7 @@
   define => "ENABLE_DOM4_EVENTS_CONSTRUCTOR", default => (isAppleWebKit() || isGtk() || isEfl()), value => \$dom4EventsConstructor },
 
 { option => "download-attribute", desc => "Toggle Download Attribute support",
-  define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isEfl(), value => \$downloadAttributeSupport },
+  define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => (isEfl() || isGtk()), value => \$downloadAttributeSupport },
 
 { option => "fetch-api", desc => "Toggle Fetch API support",
   define => "ENABLE_FETCH_API", default => 1, value => \$fetchAPISupport },

[webkit-changes] [199875] trunk/Source/WebKit2

[zandobersek]

Title: [199875] trunk/Source/WebKit2








Revision 199875
Author zandober...@gmail.com
Date 2016-04-22 05:21:21 -0700 (Fri, 22 Apr 2016)


Log Message
NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
https://bugs.webkit.org/show_bug.cgi?id=156907

Reviewed by Carlos Garcia Campos.

* NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
ensuring the resources are released after the thread exits. Next step is
to set up a thread pool and use that, avoiding thread re-creation.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (199874 => 199875)

--- trunk/Source/WebKit2/ChangeLog	2016-04-22 07:54:22 UTC (rev 199874)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-22 12:21:21 UTC (rev 199875)
@@ -1,3 +1,15 @@
+2016-04-22  Zan Dobersek  
+
+NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
+https://bugs.webkit.org/show_bug.cgi?id=156907
+
+Reviewed by Carlos Garcia Campos.
+
+* NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
+(WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
+ensuring the resources are released after the thread exits. Next step is
+to set up a thread pool and use that, avoiding thread re-creation.
+
 2016-04-21  Dean Jackson  
 
 Backdrop Filter should not be visible if element has visibility:hidden


Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp (199874 => 199875)

--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp	2016-04-22 07:54:22 UTC (rev 199874)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp	2016-04-22 12:21:21 UTC (rev 199875)
@@ -184,7 +184,7 @@
 ASSERT(!isMainThread());
 
 RefPtr channel(this);
-createThread("IOChannel::readSync", [channel, size, queue, completionHandler] {
+detachThread(createThread("IOChannel::readSync", [channel, size, queue, completionHandler] {
 size_t bufferSize = std::min(size, gDefaultReadBufferSize);
 uint8_t* bufferData = static_cast(fastMalloc(bufferSize));
 GRefPtr readBuffer = adoptGRef(soup_buffer_new_with_owner(bufferData, bufferSize, bufferData, fastFree));
@@ -218,7 +218,7 @@
 Data data = { WTFMove(buffer) };
 completionHandler(data, 0);
 }, queue);
-});
+}));
 }
 
 struct WriteAsyncData {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199874] trunk

[rego]

Title: [199874] trunk








Revision 199874
Author r...@igalia.com
Date 2016-04-22 00:54:22 -0700 (Fri, 22 Apr 2016)


Log Message
[css-grid] Fix bug with positioned items in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=156870

Reviewed by Darin Adler.

Source/WebCore:

In RenderGrid::offsetAndBreadthForPositionedChild() we were using
directly borderLeft(), which is wrong in vertical writing modes.

To fix it we just need to use borderLogicalLeft() which is aware of
the current writing mode.

Test: fast/css-grid-layout/grid-positioned-children-writing-modes.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):

LayoutTests:

Add new test to check positioned items in different writing modes
and direction combinations.

* fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html: Added.
* fast/css-grid-layout/grid-positioned-children-writing-modes.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp


Added Paths

trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html
trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199873 => 199874)

--- trunk/LayoutTests/ChangeLog	2016-04-22 07:09:12 UTC (rev 199873)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 07:54:22 UTC (rev 199874)
@@ -1,3 +1,16 @@
+2016-04-22  Manuel Rego Casasnovas  
+
+[css-grid] Fix bug with positioned items in vertical writing mode
+https://bugs.webkit.org/show_bug.cgi?id=156870
+
+Reviewed by Darin Adler.
+
+Add new test to check positioned items in different writing modes
+and direction combinations.
+
+* fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html: Added.
+* fast/css-grid-layout/grid-positioned-children-writing-modes.html: Added.
+
 2016-04-21  Chris Dumez  
 
 Drop [UsePointersEvenForNonNullableObjectArguments] from Document


Added: trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html (0 => 199874)

--- trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html	2016-04-22 07:54:22 UTC (rev 199874)
@@ -0,0 +1,79 @@
+
+
+
+
+.grid {
+display: block;
+margin: 5px;
+width: 50px;
+height: 25px;
+padding: 5px 10px 15px 20px;
+border-style: solid;
+border-width: 5px 10px 15px 20px;
+float: left;
+}
+
+.green {
+background-color: green;
+width: 30px;
+height: 20px;
+font: 10px/1 Ahem;
+}
+
+.verticalSize {
+width: 20px;
+height: 30px;
+}
+
+
+
+This test checks the behavior of the positioned grid children in combination with the writing modes and text direction properties.
+For the test to pass you should see no red and only green boxes. The black box will be positioned depending on the writing mode and text direction values.
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+
+
+
+XX
+


Added: trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html (0 => 199874)

--- trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html	2016-04-22 07:54:22 UTC (rev 199874)
@@ -0,0 +1,100 @@
+
+
+
+
+.grid {
+margin: 5px;
+width: 50px;
+height: 25px;
+-webkit-grid: 20px / 30px;
+padding: 5px 10px 15px 20px;
+border-style: solid;
+border-width: 5px 10px 15px 20px;
+float: left;
+/* Ensures that the grid container is the containing block of the grid children. */
+position: relative;
+}
+
+.absolute {
+position: absolute;
+}
+
+.onlyFirstRowOnlyFirstColumn {
+background-color: green;
+-webkit-grid-column: 1 / 2;
+-webkit-grid-row: 1 / 2;
+}
+
+.offsets {
+left: 0;
+top: 0;
+}
+
+.red {
+background-color: red;
+}
+
+
+
+This test checks the behavior of the positioned grid children in combination with the writing modes and text direction properties.
+For the test to pass you should see no red and only green boxes. The black box will be positioned depending on the writing mode and text direction values.
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+
+
+
+
+XX
+


Modified: trunk/Source/WebCore/ChangeLog (199873 => 199874)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 07:09:12 UTC (rev 199873)
+++ 

[webkit-changes] [199872] trunk/Source/WebCore

[zandobersek]

Title: [199872] trunk/Source/WebCore








Revision 199872
Author zandober...@gmail.com
Date 2016-04-21 23:58:41 -0700 (Thu, 21 Apr 2016)


Log Message
REGRESSION(r199738): The ANGLE update broke accelerated compositing in GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=156789

Reviewed by Carlos Garcia Campos.

After the update, the ANGLE library has to be built with
ANGLE_ENABLE_ESSL and ANGLE_ENABLE_GLSL definitions in order
to compile in the support for the two translators that Linux-based
ports using OpenGL ES or OpenGL require. Missing files are also added.

* CMakeLists.txt:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (199871 => 199872)

--- trunk/Source/WebCore/CMakeLists.txt	2016-04-22 06:19:41 UTC (rev 199871)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-04-22 06:58:41 UTC (rev 199872)
@@ -3249,6 +3249,7 @@
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/Diagnostics.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/DirectiveHandler.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/EmulatePrecision.cpp
+${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/ExtensionGLSL.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/glslang_lex.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/glslang_tab.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/ForLoopUnroll.cpp
@@ -3271,6 +3272,7 @@
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/ParseContext.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/PoolAlloc.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/PruneEmptyDeclarations.cpp
+${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/RecordConstantPrecision.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/RegenerateStructNames.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/RemovePow.cpp
 ${THIRDPARTY_DIR}/ANGLE/src/compiler/translator/RemoveSwitchFallThrough.cpp
@@ -3863,6 +3865,12 @@
 ADD_TARGET_PROPERTIES(ANGLESupport COMPILE_FLAGS "-Wno-null-conversion")
 endif ()
 
+# Enable the ESSL and GLSL translators.
+set_property(TARGET ANGLESupport
+PROPERTY COMPILE_DEFINITIONS
+ANGLE_ENABLE_ESSL
+ANGLE_ENABLE_GLSL)
+
 target_include_directories(ANGLESupport PRIVATE
 "${THIRDPARTY_DIR}/ANGLE/include"
 "${THIRDPARTY_DIR}/ANGLE/src"


Modified: trunk/Source/WebCore/ChangeLog (199871 => 199872)

--- trunk/Source/WebCore/ChangeLog	2016-04-22 06:19:41 UTC (rev 199871)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 06:58:41 UTC (rev 199872)
@@ -1,3 +1,17 @@
+2016-04-21  Zan Dobersek  
+
+REGRESSION(r199738): The ANGLE update broke accelerated compositing in GTK+ port
+https://bugs.webkit.org/show_bug.cgi?id=156789
+
+Reviewed by Carlos Garcia Campos.
+
+After the update, the ANGLE library has to be built with
+ANGLE_ENABLE_ESSL and ANGLE_ENABLE_GLSL definitions in order
+to compile in the support for the two translators that Linux-based
+ports using OpenGL ES or OpenGL require. Missing files are also added.
+
+* CMakeLists.txt:
+
 2016-04-21  Chris Dumez  
 
 Drop [UsePointersEvenForNonNullableObjectArguments] from Document






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199871] trunk

[cdumez]

Title: [199871] trunk








Revision 199871
Author cdu...@apple.com
Date 2016-04-21 23:19:41 -0700 (Thu, 21 Apr 2016)


Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from Document
https://bugs.webkit.org/show_bug.cgi?id=156881

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Drop [UsePointersEvenForNonNullableObjectArguments] from Document. There
is no major Web-exposed behavior change but the type of the exception
being thrown when passing null or not enough parameters has changed for
some of the API (It is now always a TypeError as per the Web IDL
specification).

Tests: fast/dom/Document/adoptNode-null.html
   fast/dom/Document/importNode-null.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAppendChild):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::adoptNode):
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::setBodyOrFrameset):
(WebCore::Document::hasValidNamespaceForElements): Deleted.
(WebCore::Document::scheduleForcedStyleRecalc): Deleted.
(WebCore::Document::scheduleStyleRecalc): Deleted.
(WebCore::Document::unscheduleStyleRecalc): Deleted.
(WebCore::Document::hasPendingStyleRecalc): Deleted.
(WebCore::Document::hasPendingForcedStyleRecalc): Deleted.
(WebCore::Document::recalcStyle): Deleted.
(WebCore::Document::explicitClose): Deleted.
* dom/Document.h:
(WebCore::Document::importNode):
* dom/Document.idl:
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodeIterator):
* dom/NodeIterator.h:
(WebCore::NodeIterator::create):

LayoutTests:

Add test cases for cases where the type of the exception being thrown
has changed.

* fast/dom/Document/adoptNode-null-expected.txt: Added.
* fast/dom/Document/adoptNode-null.html: Added.
* fast/dom/Document/importNode-null-expected.txt: Added.
* fast/dom/Document/importNode-null.html: Added.
* fast/dom/importNode-null-expected.txt: Removed.
* fast/dom/importNode-null.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/NodeIterator.cpp
trunk/Source/WebCore/dom/NodeIterator.h


Added Paths

trunk/LayoutTests/fast/dom/Document/adoptNode-null-expected.txt
trunk/LayoutTests/fast/dom/Document/adoptNode-null.html
trunk/LayoutTests/fast/dom/Document/importNode-null-expected.txt
trunk/LayoutTests/fast/dom/Document/importNode-null.html


Removed Paths

trunk/LayoutTests/fast/dom/importNode-null-expected.txt
trunk/LayoutTests/fast/dom/importNode-null.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199870 => 199871)

--- trunk/LayoutTests/ChangeLog	2016-04-22 06:07:32 UTC (rev 199870)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 06:19:41 UTC (rev 199871)
@@ -1,3 +1,20 @@
+2016-04-21  Chris Dumez  
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from Document
+https://bugs.webkit.org/show_bug.cgi?id=156881
+
+Reviewed by Darin Adler.
+
+Add test cases for cases where the type of the exception being thrown
+has changed.
+
+* fast/dom/Document/adoptNode-null-expected.txt: Added.
+* fast/dom/Document/adoptNode-null.html: Added.
+* fast/dom/Document/importNode-null-expected.txt: Added.
+* fast/dom/Document/importNode-null.html: Added.
+* fast/dom/importNode-null-expected.txt: Removed.
+* fast/dom/importNode-null.html: Removed.
+
 2016-04-21  Dean Jackson  
 
 Backdrop Filter should not be visible if element has visibility:hidden


Added: trunk/LayoutTests/fast/dom/Document/adoptNode-null-expected.txt (0 => 199871)

--- trunk/LayoutTests/fast/dom/Document/adoptNode-null-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Document/adoptNode-null-expected.txt	2016-04-22 06:19:41 UTC (rev 199871)
@@ -0,0 +1,11 @@
+Tests that document.adoptNode(null) throws a TypeError
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.adoptNode(null) threw exception TypeError: Type error.
+PASS document.adoptNode() threw exception TypeError: Not enough arguments.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/Document/adoptNode-null.html (0 => 199871)

[webkit-changes] [199870] trunk/Source/JavaScriptCore

[darin]

Title: [199870] trunk/Source/_javascript_Core








Revision 199870
Author da...@apple.com
Date 2016-04-21 23:07:32 -0700 (Thu, 21 Apr 2016)


Log Message
Follow-on to the build fix.

* runtime/MathCommon.h: Use the C++ std namespace version of the
frexp function too.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/MathCommon.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (199869 => 199870)

--- trunk/Source/_javascript_Core/ChangeLog	2016-04-22 05:56:39 UTC (rev 199869)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-22 06:07:32 UTC (rev 199870)
@@ -1,3 +1,10 @@
+2016-04-21  Darin Adler  
+
+Follow-on to the build fix.
+
+* runtime/MathCommon.h: Use the C++ std namespace version of the
+frexp function too.
+
 2016-04-21  Joonghun Park  
 
 [JSC] Fix build break since r199866. Unreviewed.


Modified: trunk/Source/_javascript_Core/runtime/MathCommon.h (199869 => 199870)

--- trunk/Source/_javascript_Core/runtime/MathCommon.h	2016-04-22 05:56:39 UTC (rev 199869)
+++ trunk/Source/_javascript_Core/runtime/MathCommon.h	2016-04-22 06:07:32 UTC (rev 199870)
@@ -62,7 +62,7 @@
 return Nullopt;
 
 int exponent;
-if (frexp(constant, ) != 0.5)
+if (std::frexp(constant, ) != 0.5)
 return Nullopt;
 
 // Note that frexp() returns the value divided by two
@@ -74,7 +74,7 @@
 if (exponent == 1023)
 return Nullopt;
 
-double reciprocal = ldexp(1, -exponent);
+double reciprocal = std::ldexp(1, -exponent);
 ASSERT(std::isnormal(reciprocal));
 ASSERT(1. / constant == reciprocal);
 ASSERT(constant == 1. / reciprocal);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes