[webkit-changes] [211550] trunk

[zandobersek]

Title: [211550] trunk








Revision 211550
Author zandober...@gmail.com
Date 2017-02-01 22:28:03 -0800 (Wed, 01 Feb 2017)


Log Message
[EME] Implement MediaKeySession::update()
https://bugs.webkit.org/show_bug.cgi?id=167636

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Implement the MediaKeySession::update() method by following the steps as
they are described in the specification.

In order to sanitize the passed-in response data, CDM::sanitizeResponse()
is added. It passes the SharedBuffer object by reference to the CDMPrivate
interface implementor, which returns a SharedBuffer object containing
sanitized response data.

CDMInstance::updateLicense() virtual method is added to perform the license
update for some specific CDMInstance object. After the update the CDMInstance
invokes the callback that's passed to updateLicense(), providing information
about session being closed, changed keys or expiration value, any message
that has to be enqueued, and whether the update was successful.

After that callback is invoked, MediaKeySession::update() goes on to handle
all the provided information in a future task, finally resolving the promise
(or rejecting it beforehand in case of any failure during response handling
or license update).

Three algorithms that can be invoked from MediaKeySession::update() (key
status update, expiration update and session closure) will be implemented
separately. Placeholder methods are provided until then.

MockCDM::sanitizeResponse() and MockCDMInstance::updateLicense() are
implemented for testing purposes. For now only the response sanitization
and sanitized response format are checked there. Key status update,
expiration update and session closure should be tested once the
implementations for those algorithms are added.

Test: media/encrypted-media/mock-MediaKeySession-update.html

* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::sanitizeResponse):
* Modules/encryptedmedia/CDM.h:
* Modules/encryptedmedia/CDMInstance.h:
* Modules/encryptedmedia/CDMPrivate.h:
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::updateKeyStatuses):
(WebCore::MediaKeySession::updateExpiration):
(WebCore::MediaKeySession::sessionClosed):
* Modules/encryptedmedia/MediaKeySession.h:
* testing/MockCDMFactory.cpp:
(WebCore::MockCDM::sanitizeResponse):
(WebCore::MockCDMInstance::updateLicense):
* testing/MockCDMFactory.h:

LayoutTests:

Add the mock-MediaKeySession-update.html test, cotaining a few cases that check
the basic operations of MediaKeySession::update(), focusing on proper promise
resolution and rejection based on the state of the object and the passed-in
response argument. Skip the test on all platforms for now.

* media/encrypted-media/mock-MediaKeySession-update-expected.txt: Added.
* media/encrypted-media/mock-MediaKeySession-update.html: Added.
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp
trunk/Source/WebCore/Modules/encryptedmedia/CDM.h
trunk/Source/WebCore/Modules/encryptedmedia/CDMInstance.h
trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivate.h
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
trunk/Source/WebCore/testing/MockCDMFactory.cpp
trunk/Source/WebCore/testing/MockCDMFactory.h


Added Paths

trunk/LayoutTests/media/encrypted-media/mock-MediaKeySession-update-expected.txt
trunk/LayoutTests/media/encrypted-media/mock-MediaKeySession-update.html




Diff

Modified: trunk/LayoutTests/ChangeLog (211549 => 211550)

--- trunk/LayoutTests/ChangeLog	2017-02-02 03:10:58 UTC (rev 211549)
+++ trunk/LayoutTests/ChangeLog	2017-02-02 06:28:03 UTC (rev 211550)
@@ -1,3 +1,20 @@
+2017-02-01  Zan Dobersek  
+
+[EME] Implement MediaKeySession::update()
+https://bugs.webkit.org/show_bug.cgi?id=167636
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Add the mock-MediaKeySession-update.html test, cotaining a few cases that check
+the basic operations of MediaKeySession::update(), focusing on proper promise
+resolution and rejection based on the state of the object and the passed-in
+response argument. Skip the test on all platforms for now.
+
+* media/encrypted-media/mock-MediaKeySession-update-expected.txt: Added.
+* media/encrypted-media/mock-MediaKeySession-update.html: Added.
+* platform/efl/TestExpectations:
+* platform/mac/TestExpectations:
+
 2017-02-01  Ryan Haddad  
 
 Rebaseline compositing/geometry/fixed-in-composited.html for ios-simulator.


Added: trunk/LayoutTests/media/encrypted-media/mock-MediaKeySession-update-expected.txt (0 => 211550)

--- trunk/LayoutTests/media/encrypted-media/mock-MediaKeySession-update-

[webkit-changes] [211549] trunk/Tools

[dewei_zhu]

Title: [211549] trunk/Tools








Revision 211549
Author dewei_...@apple.com
Date 2017-02-01 19:10:58 -0800 (Wed, 01 Feb 2017)


Log Message
Make run-benchmark script supports 'config' key in test plan.
https://bugs.webkit.org/show_bug.cgi?id=167715

Reviewed by Ryosuke Niwa.

Add support for 'config' key in test paln.
'config' key is a dictionary that specifies environment configurations while test is running.
Specifies orientation to be portrait in MotionMark benchmark.

* Scripts/webkitpy/benchmark_runner/README.md:
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
(BenchmarkRunner._run_benchmark):
* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver.prepare_env):
* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.prepare_env):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepare_env):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.prepare_env):
* Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan




Diff

Modified: trunk/Tools/ChangeLog (211548 => 211549)

--- trunk/Tools/ChangeLog	2017-02-02 01:57:00 UTC (rev 211548)
+++ trunk/Tools/ChangeLog	2017-02-02 03:10:58 UTC (rev 211549)
@@ -1,3 +1,28 @@
+2017-02-01  Dewei Zhu  
+
+Make run-benchmark script supports 'config' key in test plan.
+https://bugs.webkit.org/show_bug.cgi?id=167715
+
+Reviewed by Ryosuke Niwa.
+
+Add support for 'config' key in test paln.
+'config' key is a dictionary that specifies environment configurations while test is running.
+Specifies orientation to be portrait in MotionMark benchmark.
+
+* Scripts/webkitpy/benchmark_runner/README.md:
+* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
+(BenchmarkRunner.__init__):
+(BenchmarkRunner._run_benchmark):
+* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
+(BrowserDriver.prepare_env):
+* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
+(LinuxBrowserDriver.prepare_env):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
+(OSXBrowserDriver.prepare_env):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
+(OSXSafariDriver.prepare_env):
+* Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
+
 2017-02-01  Daniel Bates  
 
 REGRESSION (r210820): svn-create-patch does not emit property change only diff


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md (211548 => 211549)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md	2017-02-02 01:57:00 UTC (rev 211548)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md	2017-02-02 03:10:58 UTC (rev 211549)
@@ -69,6 +69,9 @@
 "local_copy": "../../../../PerformanceTests/JetStream",
 "benchmark_patch": "data/patches/JetStream.patch",
 "entry_point": "JetStream/JetStream-1.0.1/index.html",
+"config": {
+"orientation": "portrait"
+},
 "output_file": "jetstream.result"
 }
 ```
@@ -79,6 +82,7 @@
 * **remote_archive**: (**OPTIONAL**) URL of the remote (http/https) ZIP file that contains the benchmark.
 * **benchmark_path**: (**OPTIONAL**) path of patch, a relative path to the root of this project ('benchmark_runner' directory)
 * **entry_point**: the relative url you want browser to launch (a relative path to the benchmark directory)
+* **config**: a dictionary that specifies the environment configurations for the test (e.g. orientation while the test is running)
 * **output_file**: specify the output file, this can be overwritten by specifying '--output-file' while invoking run-benchmark script
 
 ### How to import a benchmark


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py (211548 => 211549)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py	2017-02-02 01:57:00 UTC (rev 211548)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py	2017-02-02 03:10:58 UTC (rev 211549)
@@ -42,7 +42,9 @@
 self._build_dir = os.path.abspath(build_dir) if build_dir else None
 self._output_file = output_file
 self._scale_unit = scale_unit
-self._device_id = dev

[webkit-changes] [211548] trunk/Source/JavaScriptCore

[commit-queue]

Title: [211548] trunk/Source/_javascript_Core








Revision 211548
Author commit-qu...@webkit.org
Date 2017-02-01 17:57:00 -0800 (Wed, 01 Feb 2017)


Log Message
Unreviewed, rolling out r211461.
https://bugs.webkit.org/show_bug.cgi?id=167721

Big regression on kraken (Requested by jfbastien on #webkit).

Reverted changeset:

"OSR entry: delay outer-loop compilation when at inner-loop"
https://bugs.webkit.org/show_bug.cgi?id=167149
http://trac.webkit.org/changeset/211461

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (211547 => 211548)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-02 01:54:46 UTC (rev 211547)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-02 01:57:00 UTC (rev 211548)
@@ -1,3 +1,16 @@
+2017-02-01  Commit Queue  
+
+Unreviewed, rolling out r211461.
+https://bugs.webkit.org/show_bug.cgi?id=167721
+
+Big regression on kraken (Requested by jfbastien on #webkit).
+
+Reverted changeset:
+
+"OSR entry: delay outer-loop compilation when at inner-loop"
+https://bugs.webkit.org/show_bug.cgi?id=167149
+http://trac.webkit.org/changeset/211461
+
 2017-02-01  Keith Miller  
 
 Unreviewed, fix unintended change.


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (211547 => 211548)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2017-02-02 01:54:46 UTC (rev 211547)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2017-02-02 01:57:00 UTC (rev 211548)
@@ -2351,19 +2351,6 @@
 worklistState = Worklist::NotKnown;
 
 JITCode* jitCode = codeBlock->jitCode()->dfg();
-
-bool triggeredSlowPath = false;
-auto tierUpEntryTriggers = jitCode->tierUpEntryTriggers.find(osrEntryBytecodeIndex);
-if (tierUpEntryTriggers != jitCode->tierUpEntryTriggers.end()) {
-if (tierUpEntryTriggers->value == 1) {
-// We were asked to enter as soon as possible. Unset this trigger so we don't continually enter.
-if (Options::verboseOSR())
-dataLog("EntryTrigger for ", *codeBlock, " forced slow-path.\n");
-triggeredSlowPath = true;
-tierUpEntryTriggers->value = 0;
-}
-}
-
 if (worklistState == Worklist::Compiling) {
 CODEBLOCK_LOG_EVENT(codeBlock, "delayFTLCompile", ("still compiling"));
 jitCode->setOptimizationThresholdBasedOnCompilationResult(
@@ -2379,12 +2366,8 @@
 return nullptr;
 }
 
-// The following is only true for triggerTierUpNowInLoop, which can never
-// be an OSR entry.
-bool canOSRFromHere = originBytecodeIndex == osrEntryBytecodeIndex;
-
 // If we can OSR Enter, do it right away.
-if (canOSRFromHere) {
+if (originBytecodeIndex == osrEntryBytecodeIndex) {
 unsigned streamIndex = jitCode->bytecodeIndexToStreamIndex.get(originBytecodeIndex);
 if (CodeBlock* entryBlock = jitCode->osrEntryBlock()) {
 if (void* address = FTL::prepareOSREntry(exec, codeBlock, entryBlock, originBytecodeIndex, streamIndex)) {
@@ -2398,10 +2381,10 @@
 // - If we do have an FTL code block, then try to enter for a while.
 // - If we couldn't enter for a while, then trigger OSR entry.
 
-if (!shouldTriggerFTLCompile(codeBlock, jitCode) && !triggeredSlowPath)
+if (!shouldTriggerFTLCompile(codeBlock, jitCode))
 return nullptr;
 
-if (!jitCode->neverExecutedEntry && !triggeredSlowPath) {
+if (!jitCode->neverExecutedEntry) {
 triggerFTLReplacementCompile(vm, codeBlock, jitCode);
 
 if (!codeBlock->hasOptimizedReplacement())
@@ -2447,28 +2430,13 @@
 return nullptr;
 }
 
-if (!canOSRFromHere) {
-// We can't OSR from here, or even start a compilation because doing so
-// calls jitCode->reconstruct which would get the wrong state.
-if (Options::verboseOSR())
-dataLog("Non-OSR-able bc#", originBytecodeIndex, " in ", *codeBlock, " setting parent loop's trigger and backing off.\n");
-jitCode->tierUpEntryTriggers.set(osrEntryBytecodeIndex, 1);
-jitCode->dontOptimizeAnytimeSoon(codeBlock);
-return nullptr;
-}
-
 unsigned streamIndex = jitCode->bytecodeIndexToStreamIndex.get(osrEntryBytecodeIndex);
-
-if (!triggeredSlowPath) {
-auto tierUpHierarchyEntry = jitCode->tierUpInLoopHierarchy.find(osrEntryBytecodeIndex);
-if (tierUpHierarchyEntry != jitCode->tierUpInLoopHierarchy.end()) {
-for (unsigned osrEntryCandidate : tierUpHierarchyEntry->value) {
-if (jitCode->tierUpEntrySeen.contains(osrEntryCandidate)) {
-// Ask an enclosing loop to compile, instead of doing so here.
-jitCode->tierUpEntryTriggers.set(osrEntryCandidate, 1);
-jitCode->dontOptimizeAnytimeSoon(codeBlock);
-return nullptr;
-

[webkit-changes] [211547] trunk/Source/WebKit2

[wenson_hsieh]

Title: [211547] trunk/Source/WebKit2








Revision 211547
Author wenson_hs...@apple.com
Date 2017-02-01 17:54:46 -0800 (Wed, 01 Feb 2017)


Log Message
Unreviewed, fix the nightly open source build.

Adds more header checks when importing from WebKitAdditions.

* UIProcess/Cocoa/WebPageProxyCocoa.mm:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (211546 => 211547)

--- trunk/Source/WebKit2/ChangeLog	2017-02-02 01:49:20 UTC (rev 211546)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-02 01:54:46 UTC (rev 211547)
@@ -1,3 +1,14 @@
+2017-02-01  Wenson Hsieh  
+
+Unreviewed, fix the nightly open source build.
+
+Adds more header checks when importing from WebKitAdditions.
+
+* UIProcess/Cocoa/WebPageProxyCocoa.mm:
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
+
 2017-02-01  Simon Fraser  
 
 [iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebPageProxyCocoa.mm (211546 => 211547)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebPageProxyCocoa.mm	2017-02-02 01:49:20 UTC (rev 211546)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebPageProxyCocoa.mm	2017-02-02 01:54:46 UTC (rev 211547)
@@ -34,7 +34,7 @@
 #import 
 #import 
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
 #import 
 #endif
 


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (211546 => 211547)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2017-02-02 01:49:20 UTC (rev 211546)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2017-02-02 01:54:46 UTC (rev 211547)
@@ -44,7 +44,7 @@
 #import 
 #import 
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
 #import 
 #endif
 


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (211546 => 211547)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2017-02-02 01:49:20 UTC (rev 211546)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2017-02-02 01:54:46 UTC (rev 211547)
@@ -501,7 +501,7 @@
 
 @implementation WKContentView (WKInteraction)
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
 #import 
 #endif
 


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm (211546 => 211547)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm	2017-02-02 01:49:20 UTC (rev 211546)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm	2017-02-02 01:54:46 UTC (rev 211547)
@@ -51,7 +51,7 @@
 using namespace WebCore;
 using namespace WebKit;
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
 #import 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211546] trunk/Source/JavaScriptCore

[keith_miller]

Title: [211546] trunk/Source/_javascript_Core








Revision 211546
Author keith_mil...@apple.com
Date 2017-02-01 17:49:20 -0800 (Wed, 01 Feb 2017)


Log Message
Unreviewed, fix unintended change.

* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::displayName):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (211545 => 211546)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-02 01:48:29 UTC (rev 211545)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-02 01:49:20 UTC (rev 211546)
@@ -1,5 +1,12 @@
 2017-02-01  Keith Miller  
 
+Unreviewed, fix unintended change.
+
+* runtime/SamplingProfiler.cpp:
+(JSC::SamplingProfiler::StackFrame::displayName):
+
+2017-02-01  Keith Miller  
+
 The sampling profile should have an option to sample from C frames.
 https://bugs.webkit.org/show_bug.cgi?id=167614
 


Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp (211545 => 211546)

--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp	2017-02-02 01:48:29 UTC (rev 211545)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp	2017-02-02 01:49:20 UTC (rev 211546)
@@ -760,7 +760,7 @@
 WTF::dataLog("couldn't get a name");
 }
 #endif
-return ASCIILiteral("(unknown12)");
+return ASCIILiteral("(unknown)");
 }
 if (frameType == FrameType::Host)
 return ASCIILiteral("(host)");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211545] trunk/Source/WebCore

[eric . carlson]

Title: [211545] trunk/Source/WebCore








Revision 211545
Author eric.carl...@apple.com
Date 2017-02-01 17:48:29 -0800 (Wed, 01 Feb 2017)


Log Message
[Mac] Update CARingBuffer class
https://bugs.webkit.org/show_bug.cgi?id=167656


Unreviewed fix the 32-bit build after r211539.

* platform/audio/mac/CAAudioStreamDescription.cpp:
(WebCore::CAAudioStreamDescription::CAAudioStreamDescription):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (211544 => 211545)

--- trunk/Source/WebCore/ChangeLog	2017-02-02 01:47:37 UTC (rev 211544)
+++ trunk/Source/WebCore/ChangeLog	2017-02-02 01:48:29 UTC (rev 211545)
@@ -1,3 +1,14 @@
+2017-02-01  Eric Carlson  
+
+[Mac] Update CARingBuffer class
+https://bugs.webkit.org/show_bug.cgi?id=167656
+
+
+Unreviewed fix the 32-bit build after r211539.
+
+* platform/audio/mac/CAAudioStreamDescription.cpp:
+(WebCore::CAAudioStreamDescription::CAAudioStreamDescription):
+
 2017-02-01  Simon Fraser  
 
 [iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible


Modified: trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp (211544 => 211545)

--- trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp	2017-02-02 01:47:37 UTC (rev 211544)
+++ trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp	2017-02-02 01:48:29 UTC (rev 211545)
@@ -42,7 +42,7 @@
 {
 }
 
-CAAudioStreamDescription::CAAudioStreamDescription(double sampleRate, UInt32 numChannels, PCMFormat format, bool isInterleaved)
+CAAudioStreamDescription::CAAudioStreamDescription(double sampleRate, uint32_t numChannels, PCMFormat format, bool isInterleaved)
 {
 m_streamDescription.mFormatID = kAudioFormatLinearPCM;
 m_streamDescription.mSampleRate = sampleRate;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211544] trunk/LayoutTests

[ryanhaddad]

Title: [211544] trunk/LayoutTests








Revision 211544
Author ryanhad...@apple.com
Date 2017-02-01 17:47:37 -0800 (Wed, 01 Feb 2017)


Log Message
Rebaseline compositing/geometry/fixed-in-composited.html for ios-simulator.

Unreviewed test gardening.

* platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (211543 => 211544)

--- trunk/LayoutTests/ChangeLog	2017-02-02 01:41:24 UTC (rev 211543)
+++ trunk/LayoutTests/ChangeLog	2017-02-02 01:47:37 UTC (rev 211544)
@@ -1,3 +1,11 @@
+2017-02-01  Ryan Haddad  
+
+Rebaseline compositing/geometry/fixed-in-composited.html for ios-simulator.
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt:
+
 2017-02-01  Simon Fraser  
 
 [iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible


Modified: trunk/LayoutTests/platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt (211543 => 211544)

--- trunk/LayoutTests/platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt	2017-02-02 01:41:24 UTC (rev 211543)
+++ trunk/LayoutTests/platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt	2017-02-02 01:47:37 UTC (rev 211544)
@@ -1,8 +1,8 @@
-layer at (0,0) size 800x1000
+layer at (0,0) size 800x2000
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x1000
-  RenderBlock {HTML} at (0,0) size 800x1000
-RenderBody {BODY} at (0,0) size 800x1000
+layer at (0,0) size 800x2000
+  RenderBlock {HTML} at (0,0) size 800x2000
+RenderBody {BODY} at (0,0) size 800x2000
   RenderBlock {P} at (0,210) size 800x20
 RenderText {#text} at (0,0) size 188x19
   text run at (0,0) width 188: "You should see no red above."
@@ -16,7 +16,7 @@
   RenderBlock {DIV} at (0,0) size 60x60 [bgcolor=#FF33]
 layer at (95,145) size 50x50
   RenderBlock (positioned) zI: 1 {DIV} at (95,145) size 50x50
-layer at (70,70) size 100x100
+layer at (20,70) size 100x100
   RenderBlock (positioned) {DIV} at (20,20) size 100x100 [bgcolor=#008000]
 layer at (200,100) size 50x50
   RenderBlock (positioned) zI: 1 {DIV} at (200,100) size 50x50






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211543] trunk/Tools

[dbates]

Title: [211543] trunk/Tools








Revision 211543
Author dba...@webkit.org
Date 2017-02-01 17:41:24 -0800 (Wed, 01 Feb 2017)


Log Message
REGRESSION (r210820): svn-create-patch does not emit property change only diff
https://bugs.webkit.org/show_bug.cgi?id=167169

Reviewed by David Kilzer.

More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
- a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
header from the output of "svn diff" on a file that was copied or moved.

Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
line followed by a separator line) with an empty body; => no chunk range lines. However a diff
of a file with only a property change also does not contain any chunk range lines. Therefore
svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
a SVN diff header with an empty body by counting the number of chunk range lines in the diff
we should directly test for the presence of a leading SVN diff header with an empty body and
remove such lines from the diff.

* Scripts/VCSUtils.pm:
(fixSVNPatchForAdditionWithHistory): Added.
* Scripts/svn-create-patch:
(generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
we have a non empty patch for an added file with history (i.e. a copied or moved file).
* Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
trunk/Tools/Scripts/svn-create-patch


Added Paths

trunk/Tools/Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl




Diff

Modified: trunk/Tools/ChangeLog (211542 => 211543)

--- trunk/Tools/ChangeLog	2017-02-02 01:23:37 UTC (rev 211542)
+++ trunk/Tools/ChangeLog	2017-02-02 01:41:24 UTC (rev 211543)
@@ -1,3 +1,32 @@
+2017-02-01  Daniel Bates  
+
+REGRESSION (r210820): svn-create-patch does not emit property change only diff
+https://bugs.webkit.org/show_bug.cgi?id=167169
+
+Reviewed by David Kilzer.
+
+More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
+- a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
+header from the output of "svn diff" on a file that was copied or moved.
+
+Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
+chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
+output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
+of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
+line followed by a separator line) with an empty body; => no chunk range lines. However a diff
+of a file with only a property change also does not contain any chunk range lines. Therefore
+svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
+a SVN diff header with an empty body by counting the number of chunk range lines in the diff
+we should directly test for the presence of a leading SVN diff header with an empty body and
+remove such lines from the diff.
+
+* Scripts/VCSUtils.pm:
+(fixSVNPatchForAdditionWithHistory): Added.
+* Scripts/svn-create-patch:
+(generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
+we have a non empty patch for an added file with history (i.e. a copied or moved file).
+* Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
+
 2017-02-01  Eric Carlson  
 
 [Mac] Update CARingBuffer class


Modified: trunk/Tools/Scripts/VCSUtils.pm (211542 => 211543)

--- trunk/Tools/Scripts/VCSUtils.pm	2017-02-02 01:23:37 UTC (rev 211542)
+++ trunk/Tools/Scripts/VCSUtils.pm	2017-02-02 01:41:24 UTC (rev 211543)
@@ -1736,6 +1736,51 @@
 return $patch;
 }
 
+# Removes a leading Subversion header without an associated diff if one exists.
+#
+# This subroutine dies if the specified patch does not begin with an "Index:" line.
+#
+# In SVN 1.9 or newer, "svn diff" of a moved/copied file without post changes always
+# emits a leading header without an associated diff:
+# Index: B.txt
+# ===
+# (end of file or next header)
+#
+# If the same file has a property change then the patch has the form:
+# Index: B.txt
+# ===

[webkit-changes] [211542] trunk/Source/JavaScriptCore

[keith_miller]

Title: [211542] trunk/Source/_javascript_Core








Revision 211542
Author keith_mil...@apple.com
Date 2017-02-01 17:23:37 -0800 (Wed, 01 Feb 2017)


Log Message
The sampling profile should have an option to sample from C frames.
https://bugs.webkit.org/show_bug.cgi?id=167614

Reviewed by Saam Barati.

We should be able to use the sampling profiler, at least
internally, to trace C calls.  This patch only modifies the JSC
shell although it would be nice to add it to the Web Inspector in
a future patch.

* runtime/Options.h:
* runtime/SamplingProfiler.cpp:
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::recordJSFrame):
(JSC::CFrameWalker::CFrameWalker):
(JSC::CFrameWalker::walk):
(JSC::CFrameWalker::isCFrame):
(JSC::CFrameWalker::advanceToParentFrame):
(JSC::CFrameWalker::frame):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::StackFrame::displayName):
* runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp
trunk/Source/_javascript_Core/runtime/SamplingProfiler.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (211541 => 211542)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-02 01:12:53 UTC (rev 211541)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-02 01:23:37 UTC (rev 211542)
@@ -1,3 +1,31 @@
+2017-02-01  Keith Miller  
+
+The sampling profile should have an option to sample from C frames.
+https://bugs.webkit.org/show_bug.cgi?id=167614
+
+Reviewed by Saam Barati.
+
+We should be able to use the sampling profiler, at least
+internally, to trace C calls.  This patch only modifies the JSC
+shell although it would be nice to add it to the Web Inspector in
+a future patch.
+
+* runtime/Options.h:
+* runtime/SamplingProfiler.cpp:
+(JSC::FrameWalker::FrameWalker):
+(JSC::FrameWalker::walk):
+(JSC::FrameWalker::recordJSFrame):
+(JSC::CFrameWalker::CFrameWalker):
+(JSC::CFrameWalker::walk):
+(JSC::CFrameWalker::isCFrame):
+(JSC::CFrameWalker::advanceToParentFrame):
+(JSC::CFrameWalker::frame):
+(JSC::SamplingProfiler::takeSample):
+(JSC::SamplingProfiler::processUnverifiedStackTraces):
+(JSC::SamplingProfiler::StackFrame::displayName):
+* runtime/SamplingProfiler.h:
+(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
+
 2017-02-01  Joseph Pecoraro  
 
 Web Inspector: Use guaranteed RunLoop instead of RunLoop::current for dispatching inspector GC event


Modified: trunk/Source/_javascript_Core/runtime/Options.h (211541 => 211542)

--- trunk/Source/_javascript_Core/runtime/Options.h	2017-02-02 01:12:53 UTC (rev 211541)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2017-02-02 01:23:37 UTC (rev 211542)
@@ -367,6 +367,7 @@
 v(unsigned, samplingProfilerTopFunctionsCount, 12, Normal, "Number of top functions to report when using the command line interface.") \
 v(unsigned, samplingProfilerTopBytecodesCount, 40, Normal, "Number of top bytecodes to report when using the command line interface.") \
 v(optionString, samplingProfilerPath, nullptr, Normal, "The path to the directory to write sampiling profiler output to. This probably will not work with WK2 unless the path is in the whitelist.") \
+v(bool, sampleCCode, false, Normal, "Causes the sampling profiler to record profiling data for C frames.") \
 \
 v(bool, alwaysGeneratePCToCodeOriginMap, false, Normal, "This will make sure we always generate a PCToCodeOriginMap for JITed code.") \
 \


Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp (211541 => 211542)

--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp	2017-02-02 01:12:53 UTC (rev 211541)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp	2017-02-02 01:23:37 UTC (rev 211542)
@@ -51,6 +51,11 @@
 #include 
 #include 
 
+#if OS(DARWIN)
+#include 
+#include 
+#endif
+
 namespace JSC {
 
 static double sNumTotalStackTraces = 0;
@@ -76,7 +81,7 @@
 
 class FrameWalker {
 public:
-FrameWalker(ExecState* callFrame, VM& vm, const LockHolder& codeBlockSetLocker, const LockHolder& machineThreadsLocker)
+FrameWalker(VM& vm, ExecState* callFrame, const LockHolder& codeBlockSetLocker, const LockHolder& machineThreadsLocker)
 : m_vm(vm)
 , m_callFrame(callFrame)
 , m_vmEntryFrame(vm.topVMEntryFrame)
@@ -93,15 +98,7 @@
 resetAtMachineFrame();
 size_t maxStackTraceSize = stackTrace.size();
 while (!isAtTop() && !m_bailingOut && m_depth < maxStackTraceSize) {
-CallSiteIndex callSiteIndex;
-JSValue unsafeCallee = m_callFrame->unsafeCallee();
-  

[webkit-changes] [211541] trunk

[simon . fraser]

Title: [211541] trunk








Revision 211541
Author simon.fra...@apple.com
Date 2017-02-01 17:12:53 -0800 (Wed, 01 Feb 2017)


Log Message
[iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible
https://bugs.webkit.org/show_bug.cgi?id=167710
rdar://problem/30100286

Reviewed by Wenson Hsieh.
Source/WebCore:

Add a bit of logging to show when RLC decides to not composite a fixed element which
is out of bounds.

Test: fast/visual-viewport/ios/bottom-bar-with-keyboard.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

Source/WebKit2:

The unobscuredRectInContentCoordinates passed to -didUpdateVisibleRect:... could project outside
of the bounds of the document, which is OK when rubber-banding, but not when we're in a stable state,
because that can cause fixed elements to get pushed outside the doc. This happened when the keyboard
triggered bottom content insets on the scroll view.

LayoutTests:

* fast/visual-viewport/ios/bottom-bar-with-keyboard-expected.txt: Added.
* fast/visual-viewport/ios/bottom-bar-with-keyboard.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm


Added Paths

trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard-expected.txt
trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard.html




Diff

Modified: trunk/LayoutTests/ChangeLog (211540 => 211541)

--- trunk/LayoutTests/ChangeLog	2017-02-01 23:49:41 UTC (rev 211540)
+++ trunk/LayoutTests/ChangeLog	2017-02-02 01:12:53 UTC (rev 211541)
@@ -1,3 +1,14 @@
+2017-02-01  Simon Fraser  
+
+[iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible
+https://bugs.webkit.org/show_bug.cgi?id=167710
+rdar://problem/30100286
+
+Reviewed by Wenson Hsieh.
+
+* fast/visual-viewport/ios/bottom-bar-with-keyboard-expected.txt: Added.
+* fast/visual-viewport/ios/bottom-bar-with-keyboard.html: Added.
+
 2017-02-01  Ryan Haddad  
 
 Marking compositing/repaint/fixed-background-scroll.html as flaky on macOS WK1.


Added: trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard-expected.txt (0 => 211541)

--- trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard-expected.txt	2017-02-02 01:12:53 UTC (rev 211541)
@@ -0,0 +1,3 @@
+Layout viewport: {"top":0,"right":320,"bottom":548,"left":0,"width":320,"height":548}
+Visual viewport: {"top":375,"right":220,"bottom":548,"left":0,"width":220,"height":173}
+


Added: trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard.html (0 => 211541)

--- trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard.html	(rev 0)
+++ trunk/LayoutTests/fast/visual-viewport/ios/bottom-bar-with-keyboard.html	2017-02-02 01:12:53 UTC (rev 211541)
@@ -0,0 +1,58 @@
+ 
+
+
+
+
+
+body {
+height: 100%;
+}
+.fixed {
+position: fixed;
+background-color: silver;
+bottom: 0;
+padding: 10px;
+}
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+function getFocusInputUIScript(x, y)
+{
+return `(function() {
+uiController.didEndZoomingCallback = function() {
+uiController.uiScriptComplete();
+}
+
+uiController.singleTapAtPoint(${x}, ${y}, function() {});
+})();`;
+}
+
+function runTest()
+{
+if (!window.testRunner || !testRunner.runUIScript)
+return;
+
+var rect = document.getElementById('input').getBoundingClientRect();
+// singleTapAtPoint takes document coordinates, so add scrollTop to clientRect.top.
+testRunner.runUIScript(getFocusInputUIScript(rect.left, rect.top + document.scrollingElement.scrollTop), function() {
+var output = 'Layout viewport: ' + JSON.stringify(internals.layoutViewportRect()) + '\nVisual viewport: ' + JSON.stringify(internals.visualViewportRect()) + '\n';
+document.getElementById('results').innerText = output;
+
+testRunner.notifyDone();
+});
+}
+
+window.addEventListener('load', runTest, false);
+
+
+
+
+
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (211540 => 211541)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 23:49:41 UTC (rev 211540)
+++ trunk/Source/WebCore/ChangeLog	2017-02-02 01:12:53 UTC (rev 211541)
@@ -1,3 +1,19 @@
+2017-02-01  Simon Fraser 

[webkit-changes] [211540] trunk/Source/WebCore

[eric . carlson]

Title: [211540] trunk/Source/WebCore








Revision 211540
Author eric.carl...@apple.com
Date 2017-02-01 15:49:41 -0800 (Wed, 01 Feb 2017)


Log Message
[Mac] Update CARingBuffer class
https://bugs.webkit.org/show_bug.cgi?id=167656

Unreviewed build fix after r211539.

* platform/audio/mac/CAAudioStreamDescription.cpp:
(WebCore::CAAudioStreamDescription::CAAudioStreamDescription): Initialize a variable to fix
release builds.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (211539 => 211540)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 23:38:04 UTC (rev 211539)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 23:49:41 UTC (rev 211540)
@@ -3,6 +3,17 @@
 [Mac] Update CARingBuffer class
 https://bugs.webkit.org/show_bug.cgi?id=167656
 
+Unreviewed build fix after r211539.
+
+* platform/audio/mac/CAAudioStreamDescription.cpp:
+(WebCore::CAAudioStreamDescription::CAAudioStreamDescription): Initialize a variable to fix
+release builds.
+
+2017-02-01  Eric Carlson  
+
+[Mac] Update CARingBuffer class
+https://bugs.webkit.org/show_bug.cgi?id=167656
+
 Reviewed by Jer Noble.
 
 API test CARingBufferTest added.


Modified: trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp (211539 => 211540)

--- trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp	2017-02-01 23:38:04 UTC (rev 211539)
+++ trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp	2017-02-01 23:49:41 UTC (rev 211540)
@@ -73,6 +73,8 @@
 break;
 case None:
 ASSERT_NOT_REACHED();
+wordsize = 0;
+break;
 }
 
 m_streamDescription.mBitsPerChannel = wordsize * 8;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211539] trunk

[eric . carlson]

Title: [211539] trunk








Revision 211539
Author eric.carl...@apple.com
Date 2017-02-01 15:38:04 -0800 (Wed, 01 Feb 2017)


Log Message
[Mac] Update CARingBuffer class
https://bugs.webkit.org/show_bug.cgi?id=167656

Reviewed by NOBODY (OOPS!).

Source/WebCore:

API test CARingBufferTest added.

* WebCore.xcodeproj/project.pbxproj: Add headers to framework so they can be used from the API test.

* platform/audio/AudioStreamDescription.h: Add Int32.

* platform/audio/mac/CAAudioStreamDescription.cpp:
(WebCore::CAAudioStreamDescription::CAAudioStreamDescription):
(WebCore::CAAudioStreamDescription::~CAAudioStreamDescription):
(WebCore::CAAudioStreamDescription::format): Support Int32.
(WebCore::CAAudioStreamDescription::operator==): Make inline.
* platform/audio/mac/CAAudioStreamDescription.h:

* platform/audio/mac/CARingBuffer.cpp:
(WebCore::CARingBuffer::CARingBuffer): Move initializers into class declaration.
(WebCore::CARingBuffer::allocate): Use flush method, get allocation info from a CAAudioStreamDescription.
(WebCore::FetchABL): Add a mode parameter to allow samples to replace or mix into destination.
(WebCore::CARingBuffer::flush): New.
(WebCore::CARingBuffer::fetch): Add mode parameter.
(WebCore::CARingBuffer::~CARingBuffer): Deleted.
* platform/audio/mac/CARingBuffer.h:
(WebCore::CARingBuffer::~CARingBuffer):

* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::prepare): Use new CARingBuffer constructor.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.

* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::prepare): Use new CARingBuffer constructor
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
(TestWebKitAPI::CARingBufferTest::SetUp):
(TestWebKitAPI::CARingBufferTest::setup):
(TestWebKitAPI::CARingBufferTest::setListDataBuffer):
(TestWebKitAPI::CARingBufferTest::description):
(TestWebKitAPI::CARingBufferTest::bufferList):
(TestWebKitAPI::CARingBufferTest::ringBuffer):
(TestWebKitAPI::CARingBufferTest::capacity):
(TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
(TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::MixingTest::run):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/audio/AudioStreamDescription.h
trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.cpp
trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.h
trunk/Source/WebCore/platform/audio/mac/CARingBuffer.cpp
trunk/Source/WebCore/platform/audio/mac/CARingBuffer.h
trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (211538 => 211539)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 23:25:15 UTC (rev 211538)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 23:38:04 UTC (rev 211539)
@@ -1,3 +1,43 @@
+2017-02-01  Eric Carlson  
+
+[Mac] Update CARingBuffer class
+https://bugs.webkit.org/show_bug.cgi?id=167656
+
+Reviewed by Jer Noble.
+
+API test CARingBufferTest added.
+
+* WebCore.xcodeproj/project.pbxproj: Add headers to framework so they can be used from the API test.
+
+* platform/audio/AudioStreamDescription.h: Add Int32.
+
+* platform/audio/mac/CAAudioStreamDescription.cpp:
+(WebCore::CAAudioStreamDescription::CAAudioStreamDescription):
+(WebCore::CAAudioStreamDescription::~CAAudioStreamDescription):
+(WebCore::CAAudioStreamDescription::format): Support Int32.
+(WebCore::CAAudioStreamDescription::operator==): Make inline.
+* platform/audio/mac/CAAudioStreamDescription.h:
+
+* platform/audio/mac/CARingBuffer.cpp:
+(WebCore::CARingBuffer::CARingBuffer): Move initializers into class declaration.
+(WebCore::CARingBuffer::allocate): Use flush method, get allocation info from a CAAudioStreamDescription.
+(WebCore::FetchABL): Add a mode parameter to allow samples to replace or mix into destination.
+(WebCore::CARingBuffer::flush): New.
+(WebCore::CARingBuffer::fetch): Add mode parameter.
+(WebCore::CARingBuffer::~CARingBuffer): Deleted.
+* platform/audio/mac/CARingBuffer.h:
+(WebCore::CARingBuffer::~CARingBuffer):
+
+* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
+(WebCore::AudioSourceProviderAVFObjC::prepare): Use new CARingBuffer constructor.
+(WebCore::operator==): Deleted.
+(WebCore::ope

[webkit-changes] [211538] trunk/Source/WebKit2

[enrica]

Title: [211538] trunk/Source/WebKit2








Revision 211538
Author enr...@apple.com
Date 2017-02-01 15:25:15 -0800 (Wed, 01 Feb 2017)


Log Message
WebProcess crashes in  int WTF::__throw_bad_variant_access when expanding/shrinking a block selection.
https://bugs.webkit.org/show_bug.cgi?id=167673
rdar://problem/30229620

Reviewed by Anders Carlsson

This is a speculative fix for a bug that might have been introduced
with http://trac.webkit.org/changeset/208479.
The code in containsRange inline fuction in WebPageIOS.mm has not been
updated when the return value of Range::compareBoundaryPoints was changed
to ExceptionOr.
Since there is already a method containsRange in the Range class that
does the right thing, expandedRangeFromHandle now uses that.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::containsRange): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (211537 => 211538)

--- trunk/Source/WebKit2/ChangeLog	2017-02-01 23:16:20 UTC (rev 211537)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-01 23:25:15 UTC (rev 211538)
@@ -1,3 +1,23 @@
+2017-02-01  Enrica Casucci  
+
+WebProcess crashes in  int WTF::__throw_bad_variant_access when expanding/shrinking a block selection.
+https://bugs.webkit.org/show_bug.cgi?id=167673
+rdar://problem/30229620
+
+Reviewed by Anders Carlsson
+
+This is a speculative fix for a bug that might have been introduced
+with http://trac.webkit.org/changeset/208479.
+The code in containsRange inline fuction in WebPageIOS.mm has not been
+updated when the return value of Range::compareBoundaryPoints was changed
+to ExceptionOr.
+Since there is already a method containsRange in the Range class that
+does the right thing, expandedRangeFromHandle now uses that.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::expandedRangeFromHandle):
+(WebKit::containsRange): Deleted.
+
 2017-02-01  Anders Carlsson  
 
 IPC::Connection receive ports should be guarded


Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (211537 => 211538)

--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2017-02-01 23:16:20 UTC (rev 211537)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2017-02-01 23:25:15 UTC (rev 211538)
@@ -1272,15 +1272,6 @@
 && (heightRatio > minMagnitudeRatio && yOriginShiftRatio < maxDisplacementRatio));
 }
 
-static inline bool containsRange(Range* first, Range* second)
-{
-if (!first || !second)
-return false;
-return first->commonAncestorContainer()->ownerDocument() == second->commonAncestorContainer()->ownerDocument()
-&& first->compareBoundaryPoints(Range::START_TO_START, *second).releaseReturnValue() <= 0
-&& first->compareBoundaryPoints(Range::END_TO_END, *second).releaseReturnValue() >= 0;
-}
-
 static inline RefPtr unionDOMRanges(Range* rangeA, Range* rangeB)
 {
 if (!rangeB)
@@ -1350,9 +1341,9 @@
 if (!rangeAtPosition || ¤tRange->ownerDocument() != &rangeAtPosition->ownerDocument())
 continue;
 
-if (containsRange(rangeAtPosition.get(), currentRange))
+if (rangeAtPosition->contains(*currentRange))
 newRange = rangeAtPosition;
-else if (containsRange(currentRange, rangeAtPosition.get()))
+else if (currentRange->contains(*rangeAtPosition.get()))
 newRange = currentRange;
 else
 newRange = unionDOMRanges(currentRange, rangeAtPosition.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211537] trunk/Source

[jmarcell]

Title: [211537] trunk/Source








Revision 211537
Author jmarc...@apple.com
Date 2017-02-01 15:16:20 -0800 (Wed, 01 Feb 2017)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (211536 => 211537)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 23:08:08 UTC (rev 211536)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 23:16:20 UTC (rev 211537)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (211536 => 211537)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 23:08:08 UTC (rev 211536)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 23:16:20 UTC (rev 211537)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (211536 => 211537)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-02-01 23:08:08 UTC (rev 211536)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-02-01 23:16:20 UTC (rev 211537)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (211536 => 211537)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 23:08:08 UTC (rev 211536)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 23:16:20 UTC (rev 211537)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (211536 => 211537)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 23:08:08 UTC (rev 211536)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 23:16:20 UTC (rev 211537)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (211536 => 211537)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 23:08:08 UTC (rev 211536)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 23:16:20 UTC (rev 211537)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211536] trunk/LayoutTests

[ryanhaddad]

Title: [211536] trunk/LayoutTests








Revision 211536
Author ryanhad...@apple.com
Date 2017-02-01 15:08:08 -0800 (Wed, 01 Feb 2017)


Log Message
Marking compositing/repaint/fixed-background-scroll.html as flaky on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=154612

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (211535 => 211536)

--- trunk/LayoutTests/ChangeLog	2017-02-01 22:52:02 UTC (rev 211535)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 23:08:08 UTC (rev 211536)
@@ -1,5 +1,14 @@
 2017-02-01  Ryan Haddad  
 
+Marking compositing/repaint/fixed-background-scroll.html as flaky on macOS WK1.
+https://bugs.webkit.org/show_bug.cgi?id=154612
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
+2017-02-01  Ryan Haddad  
+
 Rebaselining compositing/geometry/fixed-in-composited.html for macOS after r211523.
 https://bugs.webkit.org/show_bug.cgi?id=167620
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (211535 => 211536)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-02-01 22:52:02 UTC (rev 211535)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-02-01 23:08:08 UTC (rev 211536)
@@ -290,6 +290,8 @@
 webkit.org/b/165541 compositing/layer-creation/fixed-overlap-extent-rtl.html [ Failure ]
 webkit.org/b/165541 compositing/rtl/rtl-fixed-overflow.html [ Failure ]
 
+webkit.org/b/154612 [ Sierra ] compositing/repaint/fixed-background-scroll.html [ Pass Failure ]
+
 webkit.org/b/165589 pointer-lock/lock-lost-on-esc-in-fullscreen.html [ Skip ]
 
 # webkit.org/b/163585






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211535] trunk/Source/WebKit2

[andersca]

Title: [211535] trunk/Source/WebKit2








Revision 211535
Author ander...@apple.com
Date 2017-02-01 14:52:02 -0800 (Wed, 01 Feb 2017)


Log Message
IPC::Connection receive ports should be guarded
https://bugs.webkit.org/show_bug.cgi?id=167704

Reviewed by Tim Horton.

Guarding receive rights will make sure that they won't be closed accidentally. They are created
with a context pointer and can only be unguarded or destructed with the same context pointer.

* Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::platformInvalidate):
Use mach_port_destruct and pass the connection pointer as the context.

(IPC::Connection::platformInitialize):
Guard the server port with the connection pointer as the context.

(IPC::Connection::open):
Use mach_port_construct to create the port which lets us avoid a call to mach_port_set_attributes and setMachPortQueueLength.
Make the port guarded and use the connection pointer as the context.

(IPC::createReceiveSource):
Get rid of this and just duplicate the five lines of code in two places. For the receive port we want to use mach_port_destruct
in our cancel handler.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (211534 => 211535)

--- trunk/Source/WebKit2/ChangeLog	2017-02-01 22:41:52 UTC (rev 211534)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-01 22:52:02 UTC (rev 211535)
@@ -1,3 +1,28 @@
+2017-02-01  Anders Carlsson  
+
+IPC::Connection receive ports should be guarded
+https://bugs.webkit.org/show_bug.cgi?id=167704
+
+Reviewed by Tim Horton.
+
+Guarding receive rights will make sure that they won't be closed accidentally. They are created
+with a context pointer and can only be unguarded or destructed with the same context pointer.
+
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::Connection::platformInvalidate):
+Use mach_port_destruct and pass the connection pointer as the context.
+
+(IPC::Connection::platformInitialize):
+Guard the server port with the connection pointer as the context.
+
+(IPC::Connection::open):
+Use mach_port_construct to create the port which lets us avoid a call to mach_port_set_attributes and setMachPortQueueLength.
+Make the port guarded and use the connection pointer as the context.
+
+(IPC::createReceiveSource):
+Get rid of this and just duplicate the five lines of code in two places. For the receive port we want to use mach_port_destruct
+in our cancel handler.
+
 2017-02-01  Andreas Kling  
 
 Implement the alwaysRunsAtBackgroundPriority WK2 setting using thread QoS.


Modified: trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm (211534 => 211535)

--- trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm	2017-02-01 22:41:52 UTC (rev 211534)
+++ trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm	2017-02-01 22:52:02 UTC (rev 211535)
@@ -120,7 +120,7 @@
 }
 
 if (m_receivePort) {
-mach_port_mod_refs(mach_task_self(), m_receivePort, MACH_PORT_RIGHT_RECEIVE, -1);
+mach_port_destruct(mach_task_self(), m_receivePort, 0, reinterpret_cast(this));
 m_receivePort = MACH_PORT_NULL;
 }
 
@@ -170,6 +170,8 @@
 if (m_isServer) {
 m_receivePort = identifier.port;
 m_sendPort = MACH_PORT_NULL;
+
+mach_port_guard(mach_task_self(), m_receivePort, reinterpret_cast(this), true);
 } else {
 m_receivePort = MACH_PORT_NULL;
 m_sendPort = identifier.port;
@@ -181,19 +183,6 @@
 m_xpcConnection = identifier.xpcConnection;
 }
 
-template
-static dispatch_source_t createReceiveSource(mach_port_t receivePort, WorkQueue& workQueue, Function&& function)
-{
-dispatch_source_t source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MACH_RECV, receivePort, 0, workQueue.dispatchQueue());
-dispatch_source_set_event_handler(source, function);
-
-dispatch_source_set_cancel_handler(source, ^{
-mach_port_mod_refs(mach_task_self(), receivePort, MACH_PORT_RIGHT_RECEIVE, -1);
-});
-
-return source;
-}
-
 bool Connection::open()
 {
 if (m_isServer) {
@@ -205,17 +194,21 @@
 ASSERT(m_sendPort);
 
 // Create the receive port.
-mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, &m_receivePort);
+uint32_t flags = MPO_CONTEXT_AS_GUARD | MPO_QLIMIT |  MPO_STRICT | MPO_INSERT_SEND_RIGHT;
 
 #if PLATFORM(MAC)
-mach_port_set_attributes(mach_task_self(), m_receivePort, MACH_PORT_DENAP_RECEIVER, (mach_port_info_t)0, 0);
+flags |= MPO_DENAP_RECEIVER;
 #endif
 
+mach_port_options_t portOptions;
+portOptions.flags = flags;
+portOptions.mpl.mpl_qlimit = MACH_PORT_QLIMIT_LARGE;
+mach_port_construct(mach_task_self(), &portOptions, reinterpret_cast(this), &m_receivePort);
+
 m_isConnected = true;
 
-// Send

[webkit-changes] [211533] trunk/LayoutTests

[ryanhaddad]

Title: [211533] trunk/LayoutTests








Revision 211533
Author ryanhad...@apple.com
Date 2017-02-01 14:41:49 -0800 (Wed, 01 Feb 2017)


Log Message
Marking inspector/debugger/probe-manager-add-remove-actions.html as slow on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=167711

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (211532 => 211533)

--- trunk/LayoutTests/ChangeLog	2017-02-01 22:34:08 UTC (rev 211532)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 22:41:49 UTC (rev 211533)
@@ -1,5 +1,14 @@
 2017-02-01  Ryan Haddad  
 
+Marking inspector/debugger/probe-manager-add-remove-actions.html as slow on macOS debug.
+https://bugs.webkit.org/show_bug.cgi?id=167711
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2017-02-01  Ryan Haddad  
+
 Marking inspector/worker/debugger-shared-breakpoint.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=167203
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (211532 => 211533)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-02-01 22:34:08 UTC (rev 211532)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-02-01 22:41:49 UTC (rev 211533)
@@ -1182,6 +1182,7 @@
 webkit.org/b/165772 inspector/debugger/breakpoint-action-log.html [ Pass Failure ]
 webkit.org/b/161387 inspector/debugger/breakpoint-action-with-exception.html [ Pass Failure ]
 webkit.org/b/161951 [ Release ] inspector/debugger/breakpoints/resolved-dump-each-line.html [ Pass Timeout ]
+webkit.org/b/167711 [ Debug ] inspector/debugger/probe-manager-add-remove-actions.html [ Slow ]
 webkit.org/b/148636 inspector/dom/content-flow-content-nodes.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/dom/content-flow-content-removal.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/dom/content-flow-list.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211534] trunk/LayoutTests

[ryanhaddad]

Title: [211534] trunk/LayoutTests








Revision 211534
Author ryanhad...@apple.com
Date 2017-02-01 14:41:52 -0800 (Wed, 01 Feb 2017)


Log Message
Rebaselining compositing/geometry/fixed-in-composited.html for macOS after r211523.
https://bugs.webkit.org/show_bug.cgi?id=167620

Unreviewed test gardening.

* platform/mac/compositing/geometry/fixed-in-composited-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/compositing/geometry/fixed-in-composited-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (211533 => 211534)

--- trunk/LayoutTests/ChangeLog	2017-02-01 22:41:49 UTC (rev 211533)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 22:41:52 UTC (rev 211534)
@@ -1,5 +1,14 @@
 2017-02-01  Ryan Haddad  
 
+Rebaselining compositing/geometry/fixed-in-composited.html for macOS after r211523.
+https://bugs.webkit.org/show_bug.cgi?id=167620
+
+Unreviewed test gardening.
+
+* platform/mac/compositing/geometry/fixed-in-composited-expected.txt:
+
+2017-02-01  Ryan Haddad  
+
 Marking inspector/debugger/probe-manager-add-remove-actions.html as slow on macOS debug.
 https://bugs.webkit.org/show_bug.cgi?id=167711
 


Modified: trunk/LayoutTests/platform/mac/compositing/geometry/fixed-in-composited-expected.txt (211533 => 211534)

--- trunk/LayoutTests/platform/mac/compositing/geometry/fixed-in-composited-expected.txt	2017-02-01 22:41:49 UTC (rev 211533)
+++ trunk/LayoutTests/platform/mac/compositing/geometry/fixed-in-composited-expected.txt	2017-02-01 22:41:52 UTC (rev 211534)
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x1000
+layer at (0,0) size 785x2000
   RenderView at (0,0) size 785x600
-layer at (0,0) size 785x1000
-  RenderBlock {HTML} at (0,0) size 785x1000
-RenderBody {BODY} at (0,0) size 785x1000
+layer at (0,0) size 785x2000
+  RenderBlock {HTML} at (0,0) size 785x2000
+RenderBody {BODY} at (0,0) size 785x2000
   RenderBlock {P} at (0,210) size 785x18
 RenderText {#text} at (0,0) size 188x18
   text run at (0,0) width 188: "You should see no red above."






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211532] trunk/LayoutTests

[ryanhaddad]

Title: [211532] trunk/LayoutTests








Revision 211532
Author ryanhad...@apple.com
Date 2017-02-01 14:34:08 -0800 (Wed, 01 Feb 2017)


Log Message
Marking inspector/worker/debugger-shared-breakpoint.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167203

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (211531 => 211532)

--- trunk/LayoutTests/ChangeLog	2017-02-01 22:25:58 UTC (rev 211531)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 22:34:08 UTC (rev 211532)
@@ -1,3 +1,12 @@
+2017-02-01  Ryan Haddad  
+
+Marking inspector/worker/debugger-shared-breakpoint.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=167203
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2017-02-01  Simon Fraser  
 
 Clean up css3/filters/backdrop/backdrop-filter-with-clip-path.html expected results.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (211531 => 211532)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-02-01 22:25:58 UTC (rev 211531)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-02-01 22:34:08 UTC (rev 211532)
@@ -1205,6 +1205,7 @@
 webkit.org/b/164872 inspector/worker/debugger-multiple-targets-pause.html [ Pass Failure Timeout ]
 webkit.org/b/164833 inspector/worker/debugger-pause.html [ Pass Failure Timeout ]
 webkit.org/b/165582 inspector/worker/debugger-scripts.html [ Pass Failure ]
+webkit.org/b/167203 inspector/worker/debugger-shared-breakpoint.html [ Pass Failure Timeout ]
 webkit.org/b/155607 inspector/heap/snapshot.html [ Pass Timeout ]
 webkit.org/b/143719 inspector/console/console-api.html [ Pass Timeout ]
 webkit.org/b/156078 inspector/console/heapSnapshot.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211531] trunk/Source/WebCore

[zalan]

Title: [211531] trunk/Source/WebCore








Revision 211531
Author za...@apple.com
Date 2017-02-01 14:25:58 -0800 (Wed, 01 Feb 2017)


Log Message
Simple line layout: Move TextFragmentIterator::runWidth to ::textWidth.
https://bugs.webkit.org/show_bug.cgi?id=167705


Reviewed by Antti Koivisto.

We also don't need to compute logicalHeight for logicalLeft/right since the
cases where it matters (floating boxes) are not supported by simple line layout.

Covered by existing test.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::updateLineConstrains):
* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::nextBreakablePositionInSegment):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth): Deleted.
* rendering/SimpleLineLayoutTextFragmentIterator.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211530 => 211531)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 22:15:07 UTC (rev 211530)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 22:25:58 UTC (rev 211531)
@@ -1,3 +1,24 @@
+2017-02-01  Zalan Bujtas  
+
+Simple line layout: Move TextFragmentIterator::runWidth to ::textWidth.
+https://bugs.webkit.org/show_bug.cgi?id=167705
+
+
+Reviewed by Antti Koivisto.
+
+We also don't need to compute logicalHeight for logicalLeft/right since the
+cases where it matters (floating boxes) are not supported by simple line layout. 
+
+Covered by existing test.
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::updateLineConstrains):
+* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
+(WebCore::SimpleLineLayout::nextBreakablePositionInSegment):
+(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
+(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth): Deleted.
+* rendering/SimpleLineLayoutTextFragmentIterator.h:
+
 2017-02-01  Jer Noble  
 
 Fix compilation error under recent clang update


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (211530 => 211531)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-02-01 22:15:07 UTC (rev 211530)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-02-01 22:25:58 UTC (rev 211531)
@@ -604,10 +604,8 @@
 {
 bool shouldApplyTextIndent = !flow.isAnonymous() || flow.parent()->firstChild() == &flow;
 LayoutUnit height = flow.logicalHeight();
-LayoutUnit logicalHeight = flow.minLineHeightForReplacedRenderer(false, 0);
-float logicalRightOffset = flow.logicalRightOffsetForLine(height, DoNotIndentText, logicalHeight);
-line.setLogicalLeftOffset(flow.logicalLeftOffsetForLine(height, DoNotIndentText, logicalHeight) +
-(shouldApplyTextIndent && isFirstLine ? flow.textIndentOffset() : LayoutUnit(0)));
+line.setLogicalLeftOffset(flow.logicalLeftOffsetForLine(height, DoNotIndentText) + (shouldApplyTextIndent && isFirstLine ? flow.textIndentOffset() : LayoutUnit(0)));
+float logicalRightOffset = flow.logicalRightOffsetForLine(height, DoNotIndentText);
 line.setAvailableWidth(std::max(0, logicalRightOffset - line.logicalLeftOffset()));
 if (style.textAlign == JUSTIFY)
 line.setNeedsAllFragments();


Modified: trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp (211530 => 211531)

--- trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp	2017-02-01 22:15:07 UTC (rev 211530)
+++ trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp	2017-02-01 22:25:58 UTC (rev 211531)
@@ -119,7 +119,7 @@
 m_atEndOfSegment = false;
 }
 
-static unsigned nextBreakablePositionInSegment(LazyLineBreakIterator& lineBreakIterator, unsigned startPosition, bool breakNBSP, bool keepAllWordsForCJK)
+static inline unsigned nextBreakablePositionInSegment(LazyLineBreakIterator& lineBreakIterator, unsigned startPosition, bool breakNBSP, bool keepAllWordsForCJK)
 {
 if (keepAllWordsForCJK) {
 if (breakNBSP)
@@ -166,18 +166,6 @@
 return position;
 }
 
-float TextFragmentIterator::textWidth(unsigned from, unsigned to, float xPosition) const
-{
-auto& segment = *m_currentSegment;
-ASSERT(segment.start <= from && from <= segment.end && segment.start <= to && to <= segment.end);
-ASSERT(is(segment.renderer));
-if (!m_style.font.size())
-return 0;
-if (m_style.font.isFixedPitch() || (from == segment.start && to == segment.end))
-return downcast(segment.renderer).width(segment.toSegmentPosition(from), to - from, m_style.font, xPosition, nullptr, nullptr);
-return runWidth(segment, from, to, xPosition);
-}
-
 std::optional TextFragmentIterator::lastH

[webkit-changes] [211530] trunk/Source/WebCore

[jer . noble]

Title: [211530] trunk/Source/WebCore








Revision 211530
Author jer.no...@apple.com
Date 2017-02-01 14:15:07 -0800 (Wed, 01 Feb 2017)


Log Message
Fix compilation error under recent clang update
https://bugs.webkit.org/show_bug.cgi?id=167707

Reviewed by Eric Carlson.

Include TypedArrayInlines.h to fix a "missing symbol" link error when compiling under a recent clang update.

* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (211529 => 211530)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 22:13:21 UTC (rev 211529)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 22:15:07 UTC (rev 211530)
@@ -1,3 +1,14 @@
+2017-02-01  Jer Noble  
+
+Fix compilation error under recent clang update
+https://bugs.webkit.org/show_bug.cgi?id=167707
+
+Reviewed by Eric Carlson.
+
+Include TypedArrayInlines.h to fix a "missing symbol" link error when compiling under a recent clang update.
+
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+
 2017-02-01  Joseph Pecoraro  
 
 Performance Timeline: Prepare for Worker support


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (211529 => 211530)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm	2017-02-01 22:13:21 UTC (rev 211529)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm	2017-02-01 22:15:07 UTC (rev 211530)
@@ -48,6 +48,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211529] trunk/LayoutTests

[simon . fraser]

Title: [211529] trunk/LayoutTests








Revision 211529
Author simon.fra...@apple.com
Date 2017-02-01 14:13:21 -0800 (Wed, 01 Feb 2017)


Log Message
Clean up css3/filters/backdrop/backdrop-filter-with-clip-path.html expected results.

https://trac.webkit.org/changeset/201374 added some very confused results for this test.
Just move the -expected.html next to the test, and remove the .txt and .png results.

* css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html: Renamed from LayoutTests/platform/ios-simulator/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html.
* css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt: Removed.
* platform/mac/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.png: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html


Removed Paths

trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt
trunk/LayoutTests/platform/ios-simulator/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html
trunk/LayoutTests/platform/mac/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (211528 => 211529)

--- trunk/LayoutTests/ChangeLog	2017-02-01 22:08:23 UTC (rev 211528)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 22:13:21 UTC (rev 211529)
@@ -1,5 +1,16 @@
 2017-02-01  Simon Fraser  
 
+Clean up css3/filters/backdrop/backdrop-filter-with-clip-path.html expected results.
+
+https://trac.webkit.org/changeset/201374 added some very confused results for this test.
+Just move the -expected.html next to the test, and remove the .txt and .png results.
+
+* css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html: Renamed from LayoutTests/platform/ios-simulator/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html.
+* css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt: Removed.
+* platform/mac/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.png: Removed.
+
+2017-02-01  Simon Fraser  
+
 REGRESSION (r211379): [ios-simulator] LayoutTest compositing/geometry/fixed-in-composited.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=167620
 rdar://problem/30309207


Copied: trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html (from rev 211528, trunk/LayoutTests/platform/ios-simulator/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html) (0 => 211529)

--- trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html	(rev 0)
+++ trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html	2017-02-01 22:13:21 UTC (rev 211529)
@@ -0,0 +1,30 @@
+
+
+
+
+This tests that backdrop filter with clip-path works properly.
+
+#text {
+position: absolute;
+width: 200px;
+height: 200px;
+overflow: hidden;
+}
+#blur {
+position: absolute;
+left: 60px;
+top: 60px;
+width: 80px;
+height: 80px;
+
+background-color: rgba(255, 0, 0, 0.5);
+-webkit-backdrop-filter: blur(2px);
+}
+
+
+
+Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vestibulum a nunc ultrices, faucibus ligula ac, euismod elit. Ut in vehicula enim. Suspendisse sodales auctor nunc, sit amet vehicula velit cursus vulputate. Nunc sed ipsum vitae massa dapibus sodales sit amet quis dui. Aenean sit amet interdum arcu, et facilisis diam. Ut a lacus eleifend, feugiat tellus vel, molestie lorem. Nulla pulvinar dapibus semper. Quisque mollis, neque non luctus aliquam, ex risus lacinia augue, vel eleifend augue erat eget ante.
+
+
+
+
\ No newline at end of file


Deleted: trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt (211528 => 211529)

--- trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt	2017-02-01 22:08:23 UTC (rev 211528)
+++ trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt	2017-02-01 22:13:21 UTC (rev 211529)
@@ -1,30 +0,0 @@
-CONSOLE MESSAGE: line 4: Viewport argument value "200px" for key "width" was truncated to its numeric prefix.
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x8
-  RenderBlock {HTML} at (0,0) size 800x8
-RenderBody {BODY} at (8,8) size 784x0
-layer at (8,8) size 200x200 scrollHeight 342
-  RenderBlock (positioned) {DIV} at (8,8) size 200x200
-RenderText {#text} at (0,0) size 198x342
-  text run at (0,0) width 182: "Lorem ipsum dolor sit amet,"
-  text run at (0,18) width 172: "consectetur adipiscing elit."
-  text run at (0,36) width 175: "Vestibulum a nunc ultrices,"
-  text run at (0,54) width 176: "faucibus ligula ac, euismod"
-  text run at (0,72) width 160: "elit. Ut in vehicula enim."
-  text run at (0,90) width 174: "S

[webkit-changes] [211528] trunk/Websites/bugs.webkit.org

[joepeck]

Title: [211528] trunk/Websites/bugs.webkit.org








Revision 211528
Author joep...@webkit.org
Date 2017-02-01 14:08:23 -0800 (Wed, 01 Feb 2017)


Log Message
Patch Details: EWS Bubbles wrap on Patch Details page
https://bugs.webkit.org/show_bug.cgi?id=167709

Reviewed by Ryosuke Niwa.

* template/en/default/attachment/edit.html.tmpl:
Match the iframe size in list.html.tmpl.

Modified Paths

trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl




Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (211527 => 211528)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2017-02-01 22:08:21 UTC (rev 211527)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2017-02-01 22:08:23 UTC (rev 211528)
@@ -1,3 +1,13 @@
+2017-02-01  Joseph Pecoraro  
+
+Patch Details: EWS Bubbles wrap on Patch Details page
+https://bugs.webkit.org/show_bug.cgi?id=167709
+
+Reviewed by Ryosuke Niwa.
+
+* template/en/default/attachment/edit.html.tmpl:
+Match the iframe size in list.html.tmpl.
+
 2017-01-28  Joseph Pecoraro  
 
 Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line


Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl (211527 => 211528)

--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl	2017-02-01 22:08:21 UTC (rev 211527)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl	2017-02-01 22:08:23 UTC (rev 211528)
@@ -265,7 +265,7 @@
 
 
   -  style="width: 400px; height: 40px; border: none;" scrolling="no">
+  style="width: 600px; height: 20px; border: none;" scrolling="no">
   
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211527] trunk/Source/WebCore

[joepeck]

Title: [211527] trunk/Source/WebCore








Revision 211527
Author joep...@webkit.org
Date 2017-02-01 14:08:21 -0800 (Wed, 01 Feb 2017)


Log Message
Performance Timeline: Prepare for Worker support
https://bugs.webkit.org/show_bug.cgi?id=167633

Reviewed by Ryosuke Niwa.

Remove references to Document/Frame in Performance. Instead use
ScriptExecutionContext and pass in the time origin / SecurityOrigin
where it is relevant. No tests should change this is just refactoring.

* loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::performance):
* page/Performance.cpp:
(WebCore::Performance::Performance):
(WebCore::Performance::now):
(WebCore::Performance::reduceTimeResolution):
(WebCore::Performance::navigation):
(WebCore::Performance::timing):
(WebCore::Performance::addResourceTiming):
(WebCore::Performance::scriptExecutionContext): Deleted.
* page/Performance.h:
* page/Performance.idl:
* page/PerformanceResourceTiming.cpp:
(WebCore::monotonicTimeToDOMHighResTimeStamp):
(WebCore::passesTimingAllowCheck):
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::redirectStart):
(WebCore::PerformanceResourceTiming::redirectEnd):
(WebCore::PerformanceResourceTiming::fetchStart):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::secureConnectionStart):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::networkLoadTimeToDOMHighResTimeStamp):
(WebCore::monotonicTimeToDocumentMilliseconds): Deleted.
(WebCore::PerformanceResourceTiming::initiatorType): Deleted.
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds): Deleted.
* page/PerformanceResourceTiming.h:
* page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::findExistingMarkStartTime):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceTimingInformation.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/Performance.cpp
trunk/Source/WebCore/page/Performance.h
trunk/Source/WebCore/page/Performance.idl
trunk/Source/WebCore/page/PerformanceResourceTiming.cpp
trunk/Source/WebCore/page/PerformanceResourceTiming.h
trunk/Source/WebCore/page/PerformanceUserTiming.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (211526 => 211527)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 22:02:04 UTC (rev 211526)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 22:08:21 UTC (rev 211527)
@@ -1,3 +1,51 @@
+2017-02-01  Joseph Pecoraro  
+
+Performance Timeline: Prepare for Worker support
+https://bugs.webkit.org/show_bug.cgi?id=167633
+
+Reviewed by Ryosuke Niwa.
+
+Remove references to Document/Frame in Performance. Instead use
+ScriptExecutionContext and pass in the time origin / SecurityOrigin
+where it is relevant. No tests should change this is just refactoring.
+
+* loader/ResourceTimingInformation.cpp:
+(WebCore::ResourceTimingInformation::addResourceTiming):
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::performance):
+* page/Performance.cpp:
+(WebCore::Performance::Performance):
+(WebCore::Performance::now):
+(WebCore::Performance::reduceTimeResolution):
+(WebCore::Performance::navigation):
+(WebCore::Performance::timing):
+(WebCore::Performance::addResourceTiming):
+(WebCore::Performance::scriptExecutionContext): Deleted.
+* page/Performance.h:
+* page/Performance.idl:
+* page/PerformanceResourceTiming.cpp:
+(WebCore::monotonicTimeToDOMHighResTimeStamp):
+(WebCore::passesTimingAllowCheck):
+(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
+(WebCore::PerformanceResourceTiming::redirectStart):
+(WebCore::PerformanceResourceTiming::redirectEnd):
+(WebCore::PerformanceResourceTiming::fetchStart):
+(WebCore::PerformanceResourceTiming::domainLookupStart):
+(WebCore::PerformanceResourceTiming::domainLookupEnd):
+(WebCore::PerformanceResourceTiming::connectStart):
+(WebCore::PerformanceResourceTiming::connectEnd):
+(WebCore::PerformanceResourceTiming::secureConnectionStart):
+(WebCore::PerformanceResourceTiming::requestStart):
+(WebCore::PerformanceResourceTiming::responseStart):
+(WebCore::PerformanceResourceTiming::responseEnd):
+(WebCore::PerformanceResourceTiming::networkLoadTimeToDOMHighResTimeStamp):
+(WebCore::monotonicTimeToDocumentMilliseconds): Deleted.
+(WebCore::PerformanceResourceTiming::initiatorType): Deleted.
+

[webkit-changes] [211526] trunk/Tools

[ap]

Title: [211526] trunk/Tools








Revision 211526
Author a...@apple.com
Date 2017-02-01 14:02:04 -0800 (Wed, 01 Feb 2017)


Log Message
[Mac] TestWebKitAPI includes system frameworks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=167703
rdar://problem/30301498

Reviewed by Ryosuke Niwa.

FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.

Also, reduced the number of subframework search paths, looks like we only need one now.

* TestWebKitAPI/Configurations/Base.xcconfig:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig




Diff

Modified: trunk/Tools/ChangeLog (211525 => 211526)

--- trunk/Tools/ChangeLog	2017-02-01 21:49:53 UTC (rev 211525)
+++ trunk/Tools/ChangeLog	2017-02-01 22:02:04 UTC (rev 211526)
@@ -1,3 +1,18 @@
+2017-02-01  Alexey Proskuryakov  
+
+[Mac] TestWebKitAPI includes system frameworks incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=167703
+rdar://problem/30301498
+
+Reviewed by Ryosuke Niwa.
+
+FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
+Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
+
+Also, reduced the number of subframework search paths, looks like we only need one now.
+
+* TestWebKitAPI/Configurations/Base.xcconfig:
+
 2017-02-01  Brent Fulgham  
 
 Correct "filesHaveSameVolume" predicate


Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (211525 => 211526)

--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig	2017-02-01 21:49:53 UTC (rev 211525)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig	2017-02-01 22:02:04 UTC (rev 211526)
@@ -32,8 +32,6 @@
 CLANG_CXX_LIBRARY = libc++;
 CLANG_WARN_CXX0X_EXTENSIONS = NO;
 HEADER_SEARCH_PATHS = ${BUILT_PRODUCTS_DIR}/usr/local/include $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(WEBCORE_PRIVATE_HEADERS_DIR)/icu $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport;
-FRAMEWORK_SEARCH_PATHS = $(FRAMEWORK_SEARCH_PATHS_$(PLATFORM_NAME));
-FRAMEWORK_SEARCH_PATHS_macosx = $(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks;
 
 GCC_NO_COMMON_BLOCKS = YES;
 GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(FEATURE_DEFINES) GTEST_HAS_TR1_TUPLE=0 GTEST_HAS_RTTI=0 $(GCC_PREPROCESSOR_DEFINITIONS_$(PLATFORM_NAME));
@@ -94,5 +92,6 @@
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *Mac.h *Mac.cpp *Mac.mm */mac/*;
 
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
+OTHER_CFLAGS[sdk=macosx*] = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/ApplicationServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Carbon.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/CoreServices.framework/Frameworks -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
 OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211525] tags/Safari-603.1.23.1

[matthew_hanson]

Title: [211525] tags/Safari-603.1.23.1








Revision 211525
Author matthew_han...@apple.com
Date 2017-02-01 13:49:53 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211502. rdar://problem/30298722

Modified Paths

tags/Safari-603.1.23.1/Source/WebCore/ChangeLog
tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.cpp
tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.h
tags/Safari-603.1.23.1/Tools/ChangeLog
tags/Safari-603.1.23.1/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp




Diff

Modified: tags/Safari-603.1.23.1/Source/WebCore/ChangeLog (211524 => 211525)

--- tags/Safari-603.1.23.1/Source/WebCore/ChangeLog	2017-02-01 21:49:50 UTC (rev 211524)
+++ tags/Safari-603.1.23.1/Source/WebCore/ChangeLog	2017-02-01 21:49:53 UTC (rev 211525)
@@ -1,3 +1,26 @@
+2017-02-01  Matthew Hanson  
+
+Merge r211502. rdar://problem/30298722
+
+2017-02-01  Brent Fulgham  
+
+Correct "filesHaveSameVolume" predicate
+https://bugs.webkit.org/show_bug.cgi?id=167696
+
+
+Reviewed by David Kilzer.
+
+We are passing %-encoded strings to the underlying operating system's file system APIs.
+This doesn't work. Instead, we need to present a decoded version of the file path
+that matches what the system APIs expect.
+
+Tested by new TestWebKitAPI Test.
+
+* platform/FileSystem.cpp:
+(WebCore::filesHaveSameVolume): Make sure the file paths we give to the underlying
+operating system are not percent encoded.
+* platform/FileSystem.h: Export 'filesHaveSameVolume' for use by testing system.
+
 2017-01-27  Ryan Haddad  
 
 Merge r211285.


Modified: tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.cpp (211524 => 211525)

--- tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.cpp	2017-02-01 21:49:50 UTC (rev 211524)
+++ tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.cpp	2017-02-01 21:49:53 UTC (rev 211525)
@@ -28,6 +28,7 @@
 #include "FileSystem.h"
 
 #include "ScopeGuard.h"
+#include "URL.h"
 #include 
 #include 
 #include 
@@ -236,8 +237,8 @@
 
 bool filesHaveSameVolume(const String& fileA, const String& fileB)
 {
-auto fsRepFileA = fileSystemRepresentation(fileA);
-auto fsRepFileB = fileSystemRepresentation(fileB);
+auto fsRepFileA = fileSystemRepresentation(decodeURLEscapeSequences(fileA));
+auto fsRepFileB = fileSystemRepresentation(decodeURLEscapeSequences(fileB));
 
 if (fsRepFileA.isNull() || fsRepFileB.isNull())
 return false;


Modified: tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.h (211524 => 211525)

--- tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.h	2017-02-01 21:49:50 UTC (rev 211524)
+++ tags/Safari-603.1.23.1/Source/WebCore/platform/FileSystem.h	2017-02-01 21:49:53 UTC (rev 211525)
@@ -194,7 +194,7 @@
 WEBCORE_EXPORT String encodeForFileName(const String&);
 String decodeFromFilename(const String&);
 
-bool filesHaveSameVolume(const String&, const String&);
+WEBCORE_EXPORT bool filesHaveSameVolume(const String&, const String&);
 
 #if USE(CF)
 RetainPtr pathAsURL(const String&);


Modified: tags/Safari-603.1.23.1/Tools/ChangeLog (211524 => 211525)

--- tags/Safari-603.1.23.1/Tools/ChangeLog	2017-02-01 21:49:50 UTC (rev 211524)
+++ tags/Safari-603.1.23.1/Tools/ChangeLog	2017-02-01 21:49:53 UTC (rev 211525)
@@ -1,3 +1,24 @@
+2017-02-01  Matthew Hanson  
+
+Merge r211502. rdar://problem/30298722
+
+2017-02-01  Brent Fulgham  
+
+Correct "filesHaveSameVolume" predicate
+https://bugs.webkit.org/show_bug.cgi?id=167696
+
+
+Reviewed by David Kilzer.
+
+Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
+percent-escaped path inputs.
+
+* TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
+(TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
+(TestWebKitAPI::FileSystemTest::bangContainingFilePath):
+(TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
+(TestWebKitAPI::TEST_F):
+
 2017-01-25  Matthew Hanson  
 
 Merge r211137. rdar://problem/29896656


Modified: tags/Safari-603.1.23.1/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp (211524 => 211525)

--- tags/Safari-603.1.23.1/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2017-02-01 21:49:50 UTC (rev 211524)
+++ tags/Safari-603.1.23.1/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2017-02-01 21:49:53 UTC (rev 211525)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2015 Canon Inc. All rights reserved.
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -27,6 +28,7 @@
 
 #include "Test.h"
 #include 
+#include 
 #include 
 #include 
 
@@ -50,21 +52,39 @@
 closeFile(handle); 
 
 m

[webkit-changes] [211524] tags/Safari-603.1.23.1/Source

[matthew_hanson]

Title: [211524] tags/Safari-603.1.23.1/Source








Revision 211524
Author matthew_han...@apple.com
Date 2017-02-01 13:49:50 -0800 (Wed, 01 Feb 2017)


Log Message
Versioning.

Modified Paths

tags/Safari-603.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-603.1.23.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-603.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-603.1.23.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-603.1.23.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-603.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig (211523 => 211524)

--- tags/Safari-603.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 21:44:18 UTC (rev 211523)
+++ tags/Safari-603.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 21:49:50 UTC (rev 211524)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-603.1.23.1/Source/WebCore/Configurations/Version.xcconfig (211523 => 211524)

--- tags/Safari-603.1.23.1/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 21:44:18 UTC (rev 211523)
+++ tags/Safari-603.1.23.1/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 21:49:50 UTC (rev 211524)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-603.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig (211523 => 211524)

--- tags/Safari-603.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 21:44:18 UTC (rev 211523)
+++ tags/Safari-603.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 21:49:50 UTC (rev 211524)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-603.1.23.1/Source/WebKit/mac/Configurations/Version.xcconfig (211523 => 211524)

--- tags/Safari-603.1.23.1/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 21:44:18 UTC (rev 211523)
+++ tags/Safari-603.1.23.1/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 21:49:50 UTC (rev 211524)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-603.1.23.1/Source/WebKit2/Configurations/Version.xcconfig (211523 => 211524)

--- tags/Safari-603.1.23.1/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 21:44:18 UTC (rev 211523)
+++ tags/Safari-603.1.23.1/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 21:49:50 UTC (rev 211524)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211523] trunk/LayoutTests

[simon . fraser]

Title: [211523] trunk/LayoutTests








Revision 211523
Author simon.fra...@apple.com
Date 2017-02-01 13:44:18 -0800 (Wed, 01 Feb 2017)


Log Message
REGRESSION (r211379): [ios-simulator] LayoutTest compositing/geometry/fixed-in-composited.html is failing
https://bugs.webkit.org/show_bug.cgi?id=167620
rdar://problem/30309207

The body needs to be taller to allow the scrollBy() to be a stable scroll.

* compositing/geometry/fixed-in-composited.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/geometry/fixed-in-composited.html
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (211522 => 211523)

--- trunk/LayoutTests/ChangeLog	2017-02-01 21:26:55 UTC (rev 211522)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 21:44:18 UTC (rev 211523)
@@ -1,3 +1,14 @@
+2017-02-01  Simon Fraser  
+
+REGRESSION (r211379): [ios-simulator] LayoutTest compositing/geometry/fixed-in-composited.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=167620
+rdar://problem/30309207
+
+The body needs to be taller to allow the scrollBy() to be a stable scroll.
+
+* compositing/geometry/fixed-in-composited.html:
+* platform/ios-simulator/TestExpectations:
+
 2017-02-01  Chris Dumez  
 
 REGRESSION(r205136): {}.toString.call(crossOriginWindow) should not throw


Modified: trunk/LayoutTests/compositing/geometry/fixed-in-composited.html (211522 => 211523)

--- trunk/LayoutTests/compositing/geometry/fixed-in-composited.html	2017-02-01 21:26:55 UTC (rev 211522)
+++ trunk/LayoutTests/compositing/geometry/fixed-in-composited.html	2017-02-01 21:44:18 UTC (rev 211523)
@@ -5,7 +5,7 @@
   

[webkit-changes] [211522] branches/safari-603-branch

[matthew_hanson]

Title: [211522] branches/safari-603-branch








Revision 211522
Author matthew_han...@apple.com
Date 2017-02-01 13:26:55 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211502. rdar://problem/30298722

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/platform/FileSystem.cpp
branches/safari-603-branch/Source/WebCore/platform/FileSystem.h
branches/safari-603-branch/Tools/ChangeLog
branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211521 => 211522)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:51 UTC (rev 211521)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:55 UTC (rev 211522)
@@ -1,3 +1,26 @@
+2017-02-01  Matthew Hanson  
+
+Merge r211502. rdar://problem/30298722
+
+2017-02-01  Brent Fulgham  
+
+Correct "filesHaveSameVolume" predicate
+https://bugs.webkit.org/show_bug.cgi?id=167696
+
+
+Reviewed by David Kilzer.
+
+We are passing %-encoded strings to the underlying operating system's file system APIs.
+This doesn't work. Instead, we need to present a decoded version of the file path
+that matches what the system APIs expect.
+
+Tested by new TestWebKitAPI Test.
+
+* platform/FileSystem.cpp:
+(WebCore::filesHaveSameVolume): Make sure the file paths we give to the underlying
+operating system are not percent encoded.
+* platform/FileSystem.h: Export 'filesHaveSameVolume' for use by testing system.
+
 2017-01-31  Matthew Hanson  
 
 Merge r211387. rdar://problem/29500273


Modified: branches/safari-603-branch/Source/WebCore/platform/FileSystem.cpp (211521 => 211522)

--- branches/safari-603-branch/Source/WebCore/platform/FileSystem.cpp	2017-02-01 21:26:51 UTC (rev 211521)
+++ branches/safari-603-branch/Source/WebCore/platform/FileSystem.cpp	2017-02-01 21:26:55 UTC (rev 211522)
@@ -28,6 +28,7 @@
 #include "FileSystem.h"
 
 #include "ScopeGuard.h"
+#include "URL.h"
 #include 
 #include 
 #include 
@@ -236,8 +237,8 @@
 
 bool filesHaveSameVolume(const String& fileA, const String& fileB)
 {
-auto fsRepFileA = fileSystemRepresentation(fileA);
-auto fsRepFileB = fileSystemRepresentation(fileB);
+auto fsRepFileA = fileSystemRepresentation(decodeURLEscapeSequences(fileA));
+auto fsRepFileB = fileSystemRepresentation(decodeURLEscapeSequences(fileB));
 
 if (fsRepFileA.isNull() || fsRepFileB.isNull())
 return false;


Modified: branches/safari-603-branch/Source/WebCore/platform/FileSystem.h (211521 => 211522)

--- branches/safari-603-branch/Source/WebCore/platform/FileSystem.h	2017-02-01 21:26:51 UTC (rev 211521)
+++ branches/safari-603-branch/Source/WebCore/platform/FileSystem.h	2017-02-01 21:26:55 UTC (rev 211522)
@@ -194,7 +194,7 @@
 WEBCORE_EXPORT String encodeForFileName(const String&);
 String decodeFromFilename(const String&);
 
-bool filesHaveSameVolume(const String&, const String&);
+WEBCORE_EXPORT bool filesHaveSameVolume(const String&, const String&);
 
 #if USE(CF)
 RetainPtr pathAsURL(const String&);


Modified: branches/safari-603-branch/Tools/ChangeLog (211521 => 211522)

--- branches/safari-603-branch/Tools/ChangeLog	2017-02-01 21:26:51 UTC (rev 211521)
+++ branches/safari-603-branch/Tools/ChangeLog	2017-02-01 21:26:55 UTC (rev 211522)
@@ -1,3 +1,24 @@
+2017-02-01  Matthew Hanson  
+
+Merge r211502. rdar://problem/30298722
+
+2017-02-01  Brent Fulgham  
+
+Correct "filesHaveSameVolume" predicate
+https://bugs.webkit.org/show_bug.cgi?id=167696
+
+
+Reviewed by David Kilzer.
+
+Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
+percent-escaped path inputs.
+
+* TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
+(TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
+(TestWebKitAPI::FileSystemTest::bangContainingFilePath):
+(TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
+(TestWebKitAPI::TEST_F):
+
 2017-01-31  Matthew Hanson  
 
 Merge r211240. rdar://problem/30247467b


Modified: branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp (211521 => 211522)

--- branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2017-02-01 21:26:51 UTC (rev 211521)
+++ branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2017-02-01 21:26:55 UTC (rev 211522)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2015 Canon Inc. All rights reserved.
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -27,6 +28,7 @@
 
 #include "Tes

[webkit-changes] [211520] branches/safari-603-branch/Source/WebCore

[matthew_hanson]

Title: [211520] branches/safari-603-branch/Source/WebCore








Revision 211520
Author matthew_han...@apple.com
Date 2017-02-01 13:26:47 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211386. rdar://problem/30204866

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211519 => 211520)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:44 UTC (rev 211519)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:47 UTC (rev 211520)
@@ -1,5 +1,22 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211386. rdar://problem/30204866
+
+2017-01-30  Jer Noble  
+
+NULL-deref crash at PlatformMediaSession::endInterruption
+https://bugs.webkit.org/show_bug.cgi?id=167595
+
+Reviewed by Eric Carlson.
+
+Use the same, NULL-aware forEachSession() iterator rather than iterating over m_sessions directly.
+
+* platform/audio/PlatformMediaSessionManager.cpp:
+(WebCore::PlatformMediaSessionManager::beginInterruption):
+(WebCore::PlatformMediaSessionManager::endInterruption):
+
+2017-01-31  Matthew Hanson  
+
 Merge r211337. rdar://problem/30126535
 
 2017-01-28  Zalan Bujtas  


Modified: branches/safari-603-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp (211519 => 211520)

--- branches/safari-603-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp	2017-02-01 21:26:44 UTC (rev 211519)
+++ branches/safari-603-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp	2017-02-01 21:26:47 UTC (rev 211520)
@@ -114,9 +114,9 @@
 LOG(Media, "PlatformMediaSessionManager::beginInterruption");
 
 m_interrupted = true;
-Vector sessions = m_sessions;
-for (auto* session : sessions)
-session->beginInterruption(type);
+forEachSession([type] (PlatformMediaSession& session, size_t) {
+session.beginInterruption(type);
+});
 updateSessionState();
 }
 
@@ -125,9 +125,9 @@
 LOG(Media, "PlatformMediaSessionManager::endInterruption");
 
 m_interrupted = false;
-Vector sessions = m_sessions;
-for (auto* session : sessions)
-session->endInterruption(flags);
+forEachSession([flags] (PlatformMediaSession& session, size_t) {
+session.endInterruption(flags);
+});
 }
 
 void PlatformMediaSessionManager::addSession(PlatformMediaSession& session)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211517] branches/safari-603-branch/Source/WebCore

[matthew_hanson]

Title: [211517] branches/safari-603-branch/Source/WebCore








Revision 211517
Author matthew_han...@apple.com
Date 2017-02-01 13:26:34 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211309. rdar://problem/30240378

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211516 => 211517)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:31 UTC (rev 211516)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:34 UTC (rev 211517)
@@ -1,5 +1,22 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211309. rdar://problem/30240378
+
+2017-01-27  Michael Saboff  
+
+JSCustomElementInterface::invokeCallback can be called with a null callback because Weak<>
+https://bugs.webkit.org/show_bug.cgi?id=167522
+
+Reviewed by Filip Pizlo.
+
+Added all provided callbacks to the global object with a private name the same way
+that the constructor was added.  This will keep these callbacks from being GC'ed.
+
+* bindings/js/JSCustomElementRegistryCustom.cpp:
+(WebCore::JSCustomElementRegistry::define):
+
+2017-01-31  Matthew Hanson  
+
 Merge r211305. rdar://problem/29320059
 
 2017-01-27  Simon Fraser  


Modified: branches/safari-603-branch/Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp (211516 => 211517)

--- branches/safari-603-branch/Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp	2017-02-01 21:26:31 UTC (rev 211516)
+++ branches/safari-603-branch/Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp	2017-02-01 21:26:34 UTC (rev 211517)
@@ -122,15 +122,18 @@
 QualifiedName name(nullAtom, localName, HTMLNames::xhtmlNamespaceURI);
 auto elementInterface = JSCustomElementInterface::create(name, constructor, globalObject());
 
-if (auto* connectedCallback = getCustomElementCallback(state, prototypeObject, Identifier::fromString(&vm, "connectedCallback")))
+auto* connectedCallback = getCustomElementCallback(state, prototypeObject, Identifier::fromString(&vm, "connectedCallback"));
+if (connectedCallback)
 elementInterface->setConnectedCallback(connectedCallback);
 RETURN_IF_EXCEPTION(scope, JSValue());
 
-if (auto* disconnectedCallback = getCustomElementCallback(state, prototypeObject, Identifier::fromString(&vm, "disconnectedCallback")))
+auto* disconnectedCallback = getCustomElementCallback(state, prototypeObject, Identifier::fromString(&vm, "disconnectedCallback"));
+if (disconnectedCallback)
 elementInterface->setDisconnectedCallback(disconnectedCallback);
 RETURN_IF_EXCEPTION(scope, JSValue());
 
-if (auto* adoptedCallback = getCustomElementCallback(state, prototypeObject, Identifier::fromString(&vm, "adoptedCallback")))
+auto* adoptedCallback = getCustomElementCallback(state, prototypeObject, Identifier::fromString(&vm, "adoptedCallback"));
+if (adoptedCallback)
 elementInterface->setAdoptedCallback(adoptedCallback);
 RETURN_IF_EXCEPTION(scope, JSValue());
 
@@ -146,9 +149,19 @@
 }
 }
 
-PrivateName uniquePrivateName;
-globalObject()->putDirect(vm, uniquePrivateName, constructor);
+auto addToGlobalObjectWithPrivateName = [&] (JSObject* objectToAdd) {
+if (objectToAdd) {
+PrivateName uniquePrivateName;
+globalObject()->putDirect(vm, uniquePrivateName, objectToAdd);
+}
+};
 
+addToGlobalObjectWithPrivateName(constructor);
+addToGlobalObjectWithPrivateName(connectedCallback);
+addToGlobalObjectWithPrivateName(disconnectedCallback);
+addToGlobalObjectWithPrivateName(adoptedCallback);
+addToGlobalObjectWithPrivateName(attributeChangedCallback);
+
 registry.addElementDefinition(WTFMove(elementInterface));
 
 return jsUndefined();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211519] branches/safari-603-branch

[matthew_hanson]

Title: [211519] branches/safari-603-branch








Revision 211519
Author matthew_han...@apple.com
Date 2017-02-01 13:26:44 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211385. rdar://problem/29738502

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/inspector/debugger/async-stack-trace-expected.txt
branches/safari-603-branch/LayoutTests/inspector/debugger/async-stack-trace.html
branches/safari-603-branch/Source/_javascript_Core/CMakeLists.txt
branches/safari-603-branch/Source/_javascript_Core/ChangeLog
branches/safari-603-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
branches/safari-603-branch/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp
branches/safari-603-branch/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h
branches/safari-603-branch/Source/_javascript_Core/inspector/protocol/Console.json
branches/safari-603-branch/Source/WebInspectorUI/ChangeLog
branches/safari-603-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
branches/safari-603-branch/Source/WebInspectorUI/UserInterface/Models/StackTrace.js
branches/safari-603-branch/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css
branches/safari-603-branch/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.js
branches/safari-603-branch/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json


Added Paths

branches/safari-603-branch/LayoutTests/inspector/debugger/resources/log-active-stack-trace.js
branches/safari-603-branch/Source/_javascript_Core/inspector/AsyncStackTrace.cpp
branches/safari-603-branch/Source/_javascript_Core/inspector/AsyncStackTrace.h




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (211518 => 211519)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:37 UTC (rev 211518)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:44 UTC (rev 211519)
@@ -1,5 +1,28 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211385. rdar://problem/29738502
+
+2017-01-30  Matt Baker  
+
+Web Inspector: Need some limit on Async Call Stacks for async loops (rAF loops)
+https://bugs.webkit.org/show_bug.cgi?id=165633
+
+
+Reviewed by Joseph Pecoraro.
+
+Add truncation test cases and cleanup call frame logging.
+
+* inspector/debugger/async-stack-trace-expected.txt:
+* inspector/debugger/async-stack-trace.html:
+* inspector/debugger/resources/log-active-stack-trace.js: Added.
+(TestPage.registerInitializer.window.getActiveStackTrace):
+(TestPage.registerInitializer.logStackTrace.logCallFrame):
+(TestPage.registerInitializer.):
+(TestPage.registerInitializer.window.logActiveStackTrace):
+(TestPage.registerInitializer):
+
+2017-01-31  Matthew Hanson  
+
 Merge r211337. rdar://problem/30126535
 
 2017-01-28  Zalan Bujtas  


Modified: branches/safari-603-branch/LayoutTests/inspector/debugger/async-stack-trace-expected.txt (211518 => 211519)

--- branches/safari-603-branch/LayoutTests/inspector/debugger/async-stack-trace-expected.txt	2017-02-01 21:26:37 UTC (rev 211518)
+++ branches/safari-603-branch/LayoutTests/inspector/debugger/async-stack-trace-expected.txt	2017-02-01 21:26:44 UTC (rev 211519)
@@ -6,57 +6,64 @@
 PAUSE #1
 CALL STACK:
 0: [F] pauseThenFinishTest
--- [N] requestAnimationFrame 
-1: [F] testRequestAnimationFrame
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- requestAnimationFrame ---
+2: [F] testRequestAnimationFrame
+3: [P] Global Code
 
 -- Running test case: CheckAsyncStackTrace.SetTimeout
 PAUSE #1
 CALL STACK:
 0: [F] pauseThenFinishTest
--- [N] setTimeout 
-1: [F] testSetTimeout
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setTimeout ---
+2: [F] testSetTimeout
+3: [P] Global Code
 
 -- Running test case: CheckAsyncStackTrace.SetInterval
 PAUSE #1
 CALL STACK:
 0: [F] intervalFired
--- [N] setInterval 
-1: [F] testSetInterval
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setInterval ---
+2: [F] testSetInterval
+3: [P] Global Code
 PAUSE #2
 CALL STACK:
 0: [F] intervalFired
--- [N] setInterval 
-1: [F] testSetInterval
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setInterval ---
+2: [F] testSetInterval
+3: [P] Global Code
 PAUSE #3
 CALL STACK:
 0: [F] intervalFired
--- [N] setInterval 
-1: [F] testSetInterval
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setInterval ---
+2: [F] testSetInterval
+3: [P] Global Code
 
 -- Running test case: CheckAsyncStackTrace.ChainedRequestAnimationFrame
 PAUSE #1
 CALL STACK:
 0: [F] pauseThenFinishTest
--- [N] requestAnimationFrame 
-1: [F] testRequestAnimationFrame
--- [N] requestAnimationFrame 
-2: [F] testChainedRequestAnimationFrame
-3: [P] Global Code
+ASYNC CALL STACK:
+1: --- requestAnimationFrame ---
+2: [F] testRequestAnimationFrame
+3: --- requestAnimationFrame ---
+4: [F] test

[webkit-changes] [211521] branches/safari-603-branch

[matthew_hanson]

Title: [211521] branches/safari-603-branch








Revision 211521
Author matthew_han...@apple.com
Date 2017-02-01 13:26:51 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211387. rdar://problem/29500273

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-603-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp
branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm


Added Paths

branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll-expected.html
branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (211520 => 211521)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:47 UTC (rev 211520)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:51 UTC (rev 211521)
@@ -1,5 +1,19 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211387. rdar://problem/29500273
+
+2017-01-30  Simon Fraser  
+
+[iOS] position:fixed inside touch-scrollable overflow is mispositioned
+https://bugs.webkit.org/show_bug.cgi?id=167604
+
+Reviewed by Zalan Bujtas.
+
+* compositing/scrolling/fixed-inside-scroll-expected.html: Added.
+* compositing/scrolling/fixed-inside-scroll.html: Added.
+
+2017-01-31  Matthew Hanson  
+
 Merge r211385. rdar://problem/29738502
 
 2017-01-30  Matt Baker  


Added: branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll-expected.html (0 => 211521)

--- branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll-expected.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll-expected.html	2017-02-01 21:26:51 UTC (rev 211521)
@@ -0,0 +1,52 @@
+
+
+
+
+  
+html {
+  -webkit-overflow-scrolling: touch;
+}
+
+.scroller {
+height: 500px;
+width: 300px;
+margin: 50px;
+border: 25px solid gray;
+padding: 10px;
+overflow: scroll;
+box-shadow: 0 0 30px black;
+}
+
+.contents {
+width: 400px;
+height: 2000px;
+}
+
+.fixed {
+position: absolute;
+background-color: green;
+left: 70px;
+top: 70px;
+height: 200px;
+width: 200px;
+}
+
+.indicator {
+position: absolute;
+left: 70px;
+top: 70px;
+height: 200px;
+width: 200px;
+background-color: red;
+}
+  
+
+
+
+
+
+
+
+
+
+


Added: branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll.html (0 => 211521)

--- branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/compositing/scrolling/fixed-inside-scroll.html	2017-02-01 21:26:51 UTC (rev 211521)
@@ -0,0 +1,52 @@
+
+
+
+
+  
+html {
+  -webkit-overflow-scrolling: touch;
+}
+
+.scroller {
+height: 500px;
+width: 300px;
+margin: 50px;
+border: 25px solid gray;
+padding: 10px;
+overflow: scroll;
+box-shadow: 0 0 30px black;
+}
+
+.contents {
+width: 400px;
+height: 2000px;
+}
+
+.fixed {
+position: fixed;
+background-color: green;
+left: 70px;
+top: 70px;
+height: 200px;
+width: 200px;
+}
+
+.indicator {
+position: absolute;
+left: 70px;
+top: 70px;
+height: 200px;
+width: 200px;
+background-color: red;
+}
+  
+
+
+
+
+
+
+
+
+
+


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211520 => 211521)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:47 UTC (rev 211520)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:51 UTC (rev 211521)
@@ -1,5 +1,30 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211387. rdar://problem/29500273
+
+2017-01-30  Simon Fraser  
+
+[iOS] position:fixed inside touch-scrollable overflow is mispositioned
+https://bugs.webkit.org/show_bug.cgi?id=167604
+rdar://problem/29500273
+
+Reviewed by Zalan Bujtas.
+
+For layers inside touch-scrollable overflow, RenderLayerBacking::computeParentGraphicsLayerRect() needs
+to account for the offset from the ancestor compositing layer's origin, to handle scrollable elements with
+box-shadow, for example.
+
+Also make the compositing log output a little easier to r

[webkit-changes] [211511] branches/safari-603-branch

[matthew_hanson]

Title: [211511] branches/safari-603-branch








Revision 211511
Author matthew_han...@apple.com
Date 2017-02-01 13:26:17 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211240. rdar://problem/30247467b

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp
branches/safari-603-branch/Source/WebCore/Modules/webaudio/AudioContext.h
branches/safari-603-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-603-branch/Source/WebCore/html/HTMLMediaElement.h
branches/safari-603-branch/Source/WebCore/platform/audio/PlatformMediaSession.cpp
branches/safari-603-branch/Source/WebCore/platform/audio/PlatformMediaSession.h
branches/safari-603-branch/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp
branches/safari-603-branch/Tools/ChangeLog
branches/safari-603-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm


Added Paths

branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211510 => 211511)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:11 UTC (rev 211510)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:17 UTC (rev 211511)
@@ -1,5 +1,57 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211240. rdar://problem/30247467b
+
+2017-01-26  Jer Noble  
+
+Autoplay muted videos stop playback of any streaming app in the background
+https://bugs.webkit.org/show_bug.cgi?id=163993
+
+
+Reviewed by Eric Carlson.
+
+Added test in TestWebKitAPI, WebKit1.AudioSessionCategoryIOS.
+
+Previously, we would set the audio session category to "playback" if there was a media-
+element-type media session, and if there was a session capable of playing audio. But because
+this was an "or" operation, we would incorrectly set the category to "playback" if there was
+a video element incapable of rendering audio (due to being muted, without an audio track,
+etc.), and also a session capable of producing audio, such as WebAudio.
+
+With this change, this turns into an "and" operation; there must be a media element capable
+of rendering audio in order to switch the audio session category to "playback".
+
+Additionally, we no longer cache the value of "canProduceAudio()"; it's queried directly
+whenever updateSessionState() is called.
+
+* Modules/webaudio/AudioContext.cpp:
+(WebCore::AudioContext::constructCommon):
+* Modules/webaudio/AudioContext.h:
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::insertedInto):
+(WebCore::HTMLMediaElement::loadResource):
+(WebCore::HTMLMediaElement::setMuted):
+(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
+(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
+(WebCore::HTMLMediaElement::clearMediaPlayer):
+(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
+(WebCore::HTMLMediaElement::presentationType):
+(WebCore::HTMLMediaElement::characteristics):
+(WebCore::HTMLMediaElement::canProduceAudio):
+* html/HTMLMediaElement.h:
+* platform/audio/PlatformMediaSession.cpp:
+(WebCore::PlatformMediaSession::activeAudioSessionRequired):
+(WebCore::PlatformMediaSession::canProduceAudio):
+(WebCore::PlatformMediaSession::canProduceAudioChanged):
+(WebCore::PlatformMediaSession::setCanProduceAudio): Deleted.
+* platform/audio/PlatformMediaSession.h:
+(WebCore::PlatformMediaSessionClient::canProduceAudio):
+(WebCore::PlatformMediaSession::canProduceAudio): Deleted.
+* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
+(PlatformMediaSessionManager::updateSessionState):
+
+2017-01-31  Matthew Hanson  
+
 Merge r210217. rdar://problem/30260068
 
 Committed on behalf of Chris Dumez.


Modified: branches/safari-603-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp (211510 => 211511)

--- branches/safari-603-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp	2017-02-01 21:26:11 UTC (rev 211510)
+++ branches/safari-603-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp	2017-02-01 21:26:17 UTC (rev 211511)
@@ -181,8 +181,6 @@
 #if PLATFORM(COCOA)
 addBehaviorRestriction(RequirePageConsentForAudioStartRestriction);
 #endif
-
-m_mediaSession->setCanProduceAudio(true);
 }
 
 AudioContext::~AudioContext()


Modified: branches/safari-603-branch/Source/WebCore/Mo

[webkit-changes] [211518] branches/safari-603-branch

[matthew_hanson]

Title: [211518] branches/safari-603-branch








Revision 211518
Author matthew_han...@apple.com
Date 2017-02-01 13:26:37 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211337. rdar://problem/30126535

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/rendering/RenderBlockFlow.cpp
branches/safari-603-branch/Source/WebCore/rendering/RenderInline.cpp
branches/safari-603-branch/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp


Added Paths

branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner-expected.txt
branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (211517 => 211518)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:34 UTC (rev 211517)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:37 UTC (rev 211518)
@@ -1,5 +1,20 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211337. rdar://problem/30126535
+
+2017-01-28  Zalan Bujtas  
+
+Resolve beforeChild's render tree position before calling addChildIgnoringContinuation.
+https://bugs.webkit.org/show_bug.cgi?id=167540
+
+
+Reviewed by Simon Fraser.
+
+* fast/multicol/assert-on-continuation-with-spanner-expected.txt: Added.
+* fast/multicol/assert-on-continuation-with-spanner.html: Added.
+
+2017-01-31  Matthew Hanson  
+
 Merge r211307. rdar://problem/29320059
 
 2017-01-27  Simon Fraser  


Added: branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner-expected.txt (0 => 211518)

--- branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner-expected.txt	2017-02-01 21:26:37 UTC (rev 211518)
@@ -0,0 +1 @@
+PASS if no crash or assert in debug. 


Added: branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner.html (0 => 211518)

--- branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/multicol/assert-on-continuation-with-spanner.html	2017-02-01 21:26:37 UTC (rev 211518)
@@ -0,0 +1,32 @@
+
+
+
+This tests that we can insert element when beforeChild has a spanner placeholder
+
+#spanner {
+column-span: all;
+}
+
+.multicol {
+display: inline-block;
+-webkit-columns: 80px 5;
+}
+
+
+
+PASS if no crash or assert in debug.
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+setTimeout(function() {
+inner.style.content = "close-quote";
+spanner.style.float = "left";
+if (window.testRunner)
+testRunner.notifyDone();
+}, 0);
+
+
+


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211517 => 211518)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:34 UTC (rev 211517)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:37 UTC (rev 211518)
@@ -1,5 +1,28 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211337. rdar://problem/30126535
+
+2017-01-28  Zalan Bujtas  
+
+Resolve beforeChild's render tree position before calling addChildIgnoringContinuation.
+https://bugs.webkit.org/show_bug.cgi?id=167540
+
+
+Reviewed by Simon Fraser.
+
+Use the actual render tree position for the beforeChild when inside a flow thread.
+
+Test: fast/multicol/assert-on-continuation-with-spanner.html
+
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::addChild):
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::addChild):
+* rendering/RenderMultiColumnFlowThread.cpp:
+(WebCore::RenderMultiColumnFlowThread::resolveMovedChild):
+
+2017-01-31  Matthew Hanson  
+
 Merge r211309. rdar://problem/30240378
 
 2017-01-27  Michael Saboff  


Modified: branches/safari-603-branch/Source/WebCore/rendering/RenderBlockFlow.cpp (211517 => 211518)

--- branches/safari-603-branch/Source/WebCore/rendering/RenderBlockFlow.cpp	2017-02-01 21:26:34 UTC (rev 211517)
+++ branches/safari-603-branch/Source/WebCore/rendering/RenderBlockFlow.cpp	2017-02-01 21:26:37 UTC (rev 211518)
@@ -3906,11 +3906,10 @@
 {
 if (multiColumnFlowThread())
 return multiColumnFlowThread()->addChild(newChild, beforeChild);
-if (beforeChild) {
-if (RenderFlowThread* containingFlowThread = flowThreadContainingBlock())
-beforeChild = containingFlowThread->resolveMovedChild(beforeChild);
-}
-RenderBlock::addChild(newChild, beforeChild);
+auto* beforeCh

[webkit-changes] [211508] branches/safari-603-branch/Source

[matthew_hanson]

Title: [211508] branches/safari-603-branch/Source








Revision 211508
Author matthew_han...@apple.com
Date 2017-02-01 13:26:05 -0800 (Wed, 01 Feb 2017)


Log Message
Versioning.

Modified Paths

branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig (211507 => 211508)

--- branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 21:18:00 UTC (rev 211507)
+++ branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 21:26:05 UTC (rev 211508)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 23;
+TINY_VERSION = 24;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig (211507 => 211508)

--- branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 21:18:00 UTC (rev 211507)
+++ branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 21:26:05 UTC (rev 211508)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 23;
+TINY_VERSION = 24;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (211507 => 211508)

--- branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 21:18:00 UTC (rev 211507)
+++ branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 21:26:05 UTC (rev 211508)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 23;
+TINY_VERSION = 24;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig (211507 => 211508)

--- branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 21:18:00 UTC (rev 211507)
+++ branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 21:26:05 UTC (rev 211508)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 23;
+TINY_VERSION = 24;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig (211507 => 211508)

--- branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 21:18:00 UTC (rev 211507)
+++ branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 21:26:05 UTC (rev 211508)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 23;
+TINY_VERSION = 24;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211510] branches/safari-603-branch/Source/WebCore

[matthew_hanson]

Title: [211510] branches/safari-603-branch/Source/WebCore








Revision 211510
Author matthew_han...@apple.com
Date 2017-02-01 13:26:11 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r210217. rdar://problem/30260068

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/bindings/js/JSStorageCustom.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211509 => 211510)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:09 UTC (rev 211509)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:11 UTC (rev 211510)
@@ -1,3 +1,13 @@
+2017-01-31  Matthew Hanson  
+
+Merge r210217. rdar://problem/30260068
+
+Committed on behalf of Chris Dumez.
+
+* bindings/js/JSStorageCustom.cpp:
+(WebCore::JSStorage::nameGetter):
+Early-return false if an item has an exception (after propagating it.)
+
 2017-01-27  Ryan Haddad  
 
 Merge r211285.


Modified: branches/safari-603-branch/Source/WebCore/bindings/js/JSStorageCustom.cpp (211509 => 211510)

--- branches/safari-603-branch/Source/WebCore/bindings/js/JSStorageCustom.cpp	2017-02-01 21:26:09 UTC (rev 211509)
+++ branches/safari-603-branch/Source/WebCore/bindings/js/JSStorageCustom.cpp	2017-02-01 21:26:11 UTC (rev 211510)
@@ -41,8 +41,12 @@
 return false;
 
 auto item = wrapped().getItem(propertyNameToString(propertyName));
-if (item.hasException())
-propagateException(*state, item.releaseException());
+if (item.hasException()) {
+auto& vm = state->vm();
+auto scope = DECLARE_THROW_SCOPE(vm);
+propagateException(*state, scope, item.releaseException());
+return false;
+}
 
 auto string = item.releaseReturnValue();
 if (string.isNull())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211513] branches/safari-603-branch/Source/WebKit2

[matthew_hanson]

Title: [211513] branches/safari-603-branch/Source/WebKit2








Revision 211513
Author matthew_han...@apple.com
Date 2017-02-01 13:26:23 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211295. rdar://problem/30236297

Modified Paths

branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp




Diff

Modified: branches/safari-603-branch/Source/WebKit2/ChangeLog (211512 => 211513)

--- branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-02-01 21:26:21 UTC (rev 211512)
+++ branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-02-01 21:26:23 UTC (rev 211513)
@@ -1,3 +1,22 @@
+2017-01-31  Matthew Hanson  
+
+Merge r211295. rdar://problem/30236297
+
+2017-01-27  Chris Dumez  
+
+Round CPU Usage diagnostic logging to 2 significant digits
+https://bugs.webkit.org/show_bug.cgi?id=167515
+
+
+Reviewed by Antti Koivisto.
+
+Round CPU Usage diagnostic logging to 2 significant digits
+as requested by diagnostic logging team.
+
+* UIProcess/PerActivityStateCPUUsageSampler.cpp:
+(WebKit::toStringRoundingSignificantFigures):
+(WebKit::PerActivityStateCPUUsageSampler::loggingTimerFired):
+
 2017-01-26  Matthew Hanson  
 
 Merge r211239. rdar://problem/30221723


Modified: branches/safari-603-branch/Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp (211512 => 211513)

--- branches/safari-603-branch/Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp	2017-02-01 21:26:21 UTC (rev 211512)
+++ branches/safari-603-branch/Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp	2017-02-01 21:26:23 UTC (rev 211513)
@@ -30,6 +30,7 @@
 #include "WebProcessPool.h"
 #include "WebProcessProxy.h"
 #include 
+#include 
 
 namespace WebKit {
 
@@ -70,6 +71,14 @@
 }
 }
 
+static String toStringRoundingSignificantFigures(double value, unsigned significantFigures)
+{
+DecimalNumber decimal(value, RoundingSignificantFigures, significantFigures);
+NumberToLStringBuffer buffer;
+unsigned length = decimal.toStringDecimal(buffer, WTF::NumberToStringBufferLength);
+return String(buffer, length);
+}
+
 void PerActivityStateCPUUsageSampler::loggingTimerFired()
 {
 auto* page = pageForLogging();
@@ -84,7 +93,7 @@
 for (auto& pair : m_cpuTimeInActivityState) {
 double cpuUsage = static_cast(pair.value * 100.) / cpuTimeDelta;
 String activityStateKey = loggingKeyForActivityState(pair.key);
-page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, String::number(cpuUsage, 1), false);
+page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, toStringRoundingSignificantFigures(cpuUsage, 2), false);
 RELEASE_LOG(PerformanceLogging, "WebContent processes used %.1f%% CPU in %s state", cpuUsage, activityStateKey.utf8().data());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211515] branches/safari-603-branch

[matthew_hanson]

Title: [211515] branches/safari-603-branch








Revision 211515
Author matthew_han...@apple.com
Date 2017-02-01 13:26:29 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211305. rdar://problem/29320059

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
branches/safari-603-branch/Source/WebCore/platform/graphics/mac/WebLayer.mm


Added Paths

branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html
branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (211514 => 211515)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:25 UTC (rev 211514)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:29 UTC (rev 211515)
@@ -1,5 +1,20 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211305. rdar://problem/29320059
+
+2017-01-27  Simon Fraser  
+
+Element with a backdrop-filter and a mask may not correctly mask the backdrop
+https://bugs.webkit.org/show_bug.cgi?id=167456
+rdar://problem/29320059
+
+Reviewed by Antoine Quint.
+
+* css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html: Added.
+* css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html: Added.
+
+2017-01-31  Matthew Hanson  
+
 Merge r211249. rdar://problem/29539389
 
 2017-01-26  Jeremy Jones  


Added: branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html (0 => 211515)

--- branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html	2017-02-01 21:26:29 UTC (rev 211515)
@@ -0,0 +1,42 @@
+
+
+
+
+.container {
+position: absolute;
+top: 10px;
+left: 10px;
+width: 225px;
+height: 225px;
+background-image: repeating-linear-gradient(rgba(0, 0, 0, 0.25), rgba(0, 0, 0, 0.25) 25px, transparent 25px, transparent 50px),
+repeating-linear-gradient(to right, rgba(0, 0, 0, 0.25), rgba(0, 0, 0, 0.25) 25px, transparent 25px, transparent 50px);
+}
+
+.container > div {
+position: absolute;
+left: calc((100% - 160px)/2);
+top: calc((100% - 160px)/2);
+width: 160px;
+height: 160px;
+background-color: rgba(0, 0, 128, 0.2);
+}
+
+.cover {
+position: absolute;
+width: 145px;
+height: 145px;
+background-color: gray;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file


Added: branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html (0 => 211515)

--- branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html	2017-02-01 21:26:29 UTC (rev 211515)
@@ -0,0 +1,43 @@
+
+
+
+
+.container {
+position: absolute;
+top: 10px;
+left: 10px;
+width: 225px;
+height: 225px;
+background-image: repeating-linear-gradient(rgba(0, 0, 0, 0.25), rgba(0, 0, 0, 0.25) 25px, transparent 25px, transparent 50px),
+repeating-linear-gradient(to right, rgba(0, 0, 0, 0.25), rgba(0, 0, 0, 0.25) 25px, transparent 25px, transparent 50px);
+}
+
+.container > div {
+position: absolute;
+left: calc((100% - 160px)/2);
+top: calc((100% - 160px)/2);
+width: 160px;
+height: 160px;
+background-color: rgba(0, 0, 128, 0.2);
+-webkit-backdrop-filter: blur(5px);
+}
+
+.cover {
+position: absolute;
+width: 145px;
+height: 145px;
+background-color: gray;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211514 => 211515)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:25 UTC (rev 211514)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:29 UTC (rev 211515)
@@ -1,5 +1,33 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211305. rdar://problem/29320059
+
+2017-01-27  Simon Fraser  
+
+Element with a backdrop-filter and a mask may not correctly mask the backdrop
+https://bugs.webkit.org/show_bug.cgi?id=167456
+rdar://problem/29320059
+
+Reviewed by Antoine Quint.
+
+If a layer had a backdrop filter, but also corner radii that triggered using a mask layer,
+then the call to updateClippingStrategy() in GraphicsLayerCA::updateBackdropFiltersRect() would
+set the backdrop layer

[webkit-changes] [211516] branches/safari-603-branch/LayoutTests

[matthew_hanson]

Title: [211516] branches/safari-603-branch/LayoutTests








Revision 211516
Author matthew_han...@apple.com
Date 2017-02-01 13:26:31 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211307. rdar://problem/29320059

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html
branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (211515 => 211516)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:29 UTC (rev 211515)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:31 UTC (rev 211516)
@@ -1,5 +1,16 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211307. rdar://problem/29320059
+
+2017-01-27  Simon Fraser  
+
+Tweak the test to avoid one pixel of difference on some hardware.
+
+* css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html:
+* css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html:
+
+2017-01-31  Matthew Hanson  
+
 Merge r211305. rdar://problem/29320059
 
 2017-01-27  Simon Fraser  


Modified: branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html (211515 => 211516)

--- branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html	2017-02-01 21:26:29 UTC (rev 211515)
+++ branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html	2017-02-01 21:26:31 UTC (rev 211516)
@@ -23,8 +23,10 @@
 
 .cover {
 position: absolute;
-width: 145px;
-height: 145px;
+top: 10px;
+left: 10px;
+width: 147px;
+height: 147px;
 background-color: gray;
 }
 
@@ -35,8 +37,8 @@
 
 
 
-
-
+
+
 
 
 
\ No newline at end of file


Modified: branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html (211515 => 211516)

--- branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html	2017-02-01 21:26:29 UTC (rev 211515)
+++ branches/safari-603-branch/LayoutTests/css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html	2017-02-01 21:26:31 UTC (rev 211516)
@@ -24,8 +24,10 @@
 
 .cover {
 position: absolute;
-width: 145px;
-height: 145px;
+top: 10px;
+left: 10px;
+width: 147px;
+height: 147px;
 background-color: gray;
 }
 
@@ -36,8 +38,8 @@
 
 
 
-
-
+
+
 
 
 
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211514] branches/safari-603-branch/Source/JavaScriptCore

[matthew_hanson]

Title: [211514] branches/safari-603-branch/Source/_javascript_Core








Revision 211514
Author matthew_han...@apple.com
Date 2017-02-01 13:26:25 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211300. rdar://problem/30135571

Modified Paths

branches/safari-603-branch/Source/_javascript_Core/API/JSVirtualMachine.mm
branches/safari-603-branch/Source/_javascript_Core/ChangeLog




Diff

Modified: branches/safari-603-branch/Source/_javascript_Core/API/JSVirtualMachine.mm (211513 => 211514)

--- branches/safari-603-branch/Source/_javascript_Core/API/JSVirtualMachine.mm	2017-02-01 21:26:23 UTC (rev 211513)
+++ branches/safari-603-branch/Source/_javascript_Core/API/JSVirtualMachine.mm	2017-02-01 21:26:25 UTC (rev 211514)
@@ -326,6 +326,8 @@
 }
 [externalRememberedSet removeAllObjects];
 }
+
+visitor.mergeIfNecessary();
 }
 
 #endif // JSC_OBJC_API_ENABLED


Modified: branches/safari-603-branch/Source/_javascript_Core/ChangeLog (211513 => 211514)

--- branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-02-01 21:26:23 UTC (rev 211513)
+++ branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-02-01 21:26:25 UTC (rev 211514)
@@ -1,3 +1,25 @@
+2017-01-31  Matthew Hanson  
+
+Merge r211300. rdar://problem/30135571
+
+2017-01-27  Filip Pizlo  
+
+scanExternalRememberedSet needs to mergeIfNecessary
+https://bugs.webkit.org/show_bug.cgi?id=167523
+
+Reviewed by Keith Miller.
+
+The protocol for opaque roots is that if you add to them outside of draining, then you need to call
+mergeIfNecessary.
+
+This means that every MarkingConstraint that adds opaque roots needs to mergeIfNecessary after.
+
+scanExternalRememberedSet transitively calls addOpaqueRoot, is called from a MarkingConstraint, and
+was missing a call to mergeIfNecessary. This fixes it.
+
+* API/JSVirtualMachine.mm:
+(scanExternalRememberedSet):
+
 2017-01-27  Matthew Hanson  
 
 Merge r211194. rdar://problem/30201008






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211512] branches/safari-603-branch

[matthew_hanson]

Title: [211512] branches/safari-603-branch








Revision 211512
Author matthew_han...@apple.com
Date 2017-02-01 13:26:21 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211249. rdar://problem/29539389

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/page/PointerLockController.cpp
branches/safari-603-branch/Source/WebCore/page/PointerLockController.h




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (211511 => 211512)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:17 UTC (rev 211511)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-02-01 21:26:21 UTC (rev 211512)
@@ -1,3 +1,20 @@
+2017-01-31  Matthew Hanson  
+
+Merge r211249. rdar://problem/29539389
+
+2017-01-26  Jeremy Jones  
+
+Page should be able to request pointer lock without user gesture if it relinquished it without a user gesture
+https://bugs.webkit.org/show_bug.cgi?id=167126
+
+Reviewed by Jon Lee.
+
+Enable pointer-lock/locked-element-removed-from-dom.html for WK2 by enabling for Mac and disabling for WK1.
+Not enable in WK1 becuase of https://bugs.webkit.org/show_bug.cgi?id=167127
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac/TestExpectations:
+
 2017-01-26  Matthew Hanson  
 
 Merge r211235. rdar://problem/30058933


Modified: branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations (211511 => 211512)

--- branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations	2017-02-01 21:26:17 UTC (rev 211511)
+++ branches/safari-603-branch/LayoutTests/platform/mac/TestExpectations	2017-02-01 21:26:21 UTC (rev 211512)
@@ -281,7 +281,6 @@
 # Pointer Lock can only check some of the API at the moment.
 pointer-lock/bug90391-move-then-window-open-crash.html
 pointer-lock/locked-element-iframe-removed-from-dom.html
-pointer-lock/locked-element-removed-from-dom.html
 pointer-lock/pointerlockchange-event-on-lock-lost.html
 pointer-lock/pointerlockchange-pointerlockerror-events.html
 pointer-lock/pointerlockelement-null-when-pending.html


Modified: branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations (211511 => 211512)

--- branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations	2017-02-01 21:26:17 UTC (rev 211511)
+++ branches/safari-603-branch/LayoutTests/platform/mac-wk1/TestExpectations	2017-02-01 21:26:21 UTC (rev 211512)
@@ -293,3 +293,5 @@
 webkit.org/b/165541 compositing/rtl/rtl-fixed-overflow.html [ Failure ]
 
 webkit.org/b/165589 pointer-lock/lock-lost-on-esc-in-fullscreen.html [ Skip ]
+
+webkit.org/b/167127 pointer-lock/locked-element-removed-from-dom.html


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (211511 => 211512)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:17 UTC (rev 211511)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-02-01 21:26:21 UTC (rev 211512)
@@ -1,5 +1,43 @@
 2017-01-31  Matthew Hanson  
 
+Merge r211249. rdar://problem/29539389
+
+2017-01-26  Jeremy Jones  
+
+Page should be able to request pointer lock without user gesture if it relinquished it without a user gesture
+https://bugs.webkit.org/show_bug.cgi?id=167126
+
+Reviewed by Jon Lee.
+
+Enabled pointer-lock/locked-element-removed-from-dom.html for WK2.
+Not enable in WK1 because of https://bugs.webkit.org/show_bug.cgi?id=167127
+
+This change allows a page to lock the pointer again without a user gesture if it was unlocked by
+the page and not by the user. See https://www.w3.org/TR/2016/REC-pointerlock-20161027/ 5.1 Methods
+
+* page/PointerLockController.cpp:
+
+When a document acquires pointer lock with a user gesture, that document is allowed to request pointer lock again
+until the user takes an action to end pointer lock. We know it is a user action because user actions always
+call requestPointerUnlockAndForceCursorVisible().
+
+When the page requests a pointer unlock (via requestPointerUnlock), that document is allowed to continue to relock
+the page. This continues until there is either an unlock request form the user
+via requestPointerUnlockAndForceCursorVisible or a didLosePointerLock without a pointer unlock request.
+
+(WebCore::PointerLockController::PointerLockController):
+(WebCore::PointerLockController::requestPointerLock):
+(WebCore::PointerLockController::requestPointerUnlock):
+(WebCore::PointerLockController::requestPointerUnlockAndForceCursorVisible):
+(WebCore::PointerLockControlle

[webkit-changes] [211509] branches/safari-603-branch

[matthew_hanson]

Title: [211509] branches/safari-603-branch








Revision 211509
Author matthew_han...@apple.com
Date 2017-02-01 13:26:09 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211194. rdar://problem/30201008

Modified Paths

branches/safari-603-branch/JSTests/ChangeLog
branches/safari-603-branch/Source/_javascript_Core/ChangeLog
branches/safari-603-branch/Source/_javascript_Core/jsc.cpp
branches/safari-603-branch/Source/_javascript_Core/runtime/JSArrayBuffer.h


Added Paths

branches/safari-603-branch/JSTests/stress/lars-sab-workers.js




Diff

Modified: branches/safari-603-branch/JSTests/ChangeLog (211508 => 211509)

--- branches/safari-603-branch/JSTests/ChangeLog	2017-02-01 21:26:05 UTC (rev 211508)
+++ branches/safari-603-branch/JSTests/ChangeLog	2017-02-01 21:26:09 UTC (rev 211509)
@@ -1,5 +1,25 @@
 2017-01-27  Matthew Hanson  
 
+Merge r211194. rdar://problem/30201008
+
+2017-01-25  Filip Pizlo  
+
+jsc.cpp should have the $.agent stuff for testing SAB
+https://bugs.webkit.org/show_bug.cgi?id=167431
+
+Reviewed by Saam Barati.
+
+Add a very basic test of Atomics using $.agent. This is based on
+LayoutTests/workers/sab/simple.html.
+
+* stress/lars-sab-workers.js: Added.
+(startWorker):
+(resources):
+(wake):
+(else):
+
+2017-01-27  Matthew Hanson  
+
 Rollout r211258. rdar://problem/29144126
 
 2017-01-27  Matthew Hanson  


Added: branches/safari-603-branch/JSTests/stress/lars-sab-workers.js (0 => 211509)

--- branches/safari-603-branch/JSTests/stress/lars-sab-workers.js	(rev 0)
+++ branches/safari-603-branch/JSTests/stress/lars-sab-workers.js	2017-02-01 21:26:09 UTC (rev 211509)
@@ -0,0 +1,127 @@
+//@ defaultRunNoisyTest
+
+var sab = new SharedArrayBuffer(100 * 4);
+
+var memory = new Int32Array(sab);
+
+var numWorkers = 0;
+function startWorker(code)
+{
+print("Starting worker!");
+
+numWorkers++;
+$.agent.start(code);
+}
+
+resources = `
+function wait(memory, index, waitCondition, wakeCondition)
+{
+while (memory[index] == waitCondition) {
+var result = Atomics.wait(memory, index, waitCondition);
+switch (result) {
+case "not-equal":
+case "ok":
+break;
+default:
+$.agent.report("Error: bad result from wait: " + result);
+$.agent.report("error");
+break;
+}
+var value = memory[index];
+if (value != wakeCondition) {
+$.agent.report("Error: wait returned not-equal but the memory has a bad value: " + value);
+$.agent.report("error");
+}
+}
+var value = memory[index];
+if (value != wakeCondition) {
+$.agent.report("Error: done waiting but the memory has a bad value: " + value);
+$.agent.report("error");
+}
+}
+
+function wake(memory, index)
+{
+var result = Atomics.wake(memory, index, 1);
+if (result != 0 && result != 1) {
+$.agent.report("Error: bad result from wake: " + result);
+$.agent.report("error");
+}
+}
+`;
+
+startWorker(
+resources + `
+$.agent.receiveBroadcast(sab => {
+var memory = new Int32Array(sab);
+var didStartIdx = 0;
+var shouldGoIdx = 1;
+var didEndIdx = 2;
+
+$.agent.report("1: Started!");
+$.agent.report("1: Memory: " + memory);
+
+wait(memory, didStartIdx, 0, 1);
+
+$.agent.report("1: It started!");
+
+memory[shouldGoIdx] = 1;
+wake(memory, shouldGoIdx);
+
+wait(memory, didEndIdx, 0, 1);
+
+$.agent.report("1: All done!");
+$.agent.report("1: Memory: " + memory);
+$.agent.report("done");
+});
+`);
+
+startWorker(
+resources + `
+$.agent.receiveBroadcast(sab => {
+var memory = new Int32Array(sab);
+var didStartIdx = 0;
+var shouldGoIdx = 1;
+var didEndIdx = 2;
+
+$.agent.report("2: Started!");
+$.agent.report("2: Memory: " + memory);
+
+Atomics.store(memory, didStartIdx, 1);
+wake(memory, didStartIdx);
+
+wait(memory, shouldGoIdx, 0, 1);
+
+Atomics.store(memory, didEndIdx, 1);
+wake(memory, didEndIdx, 1);
+
+$.agent.report("2: Memory: " + memory);
+$.agent.report("done");
+});
+`);
+
+$.agent.broadcast(sab);
+
+for (;;) {
+var report = waitForReport();
+if (report == "done") {
+if (!--numWorkers) {
+print("All workers done!");
+break;
+}
+} else if (report == "error") {
+print("Test failed!");
+throw new Error("Test failed.");
+} else
+print("report: " + report);
+}
+
+for (var i = 0; i < 3; ++i) {
+if (memory[i] != 1)
+throw "Error: Bad value at memory[" + i + "]: " + memory[i];
+}

[webkit-changes] [211507] tags/Safari-604.1.6/

[jmarcell]

Title: [211507] tags/Safari-604.1.6/








Revision 211507
Author jmarc...@apple.com
Date 2017-02-01 13:18:00 -0800 (Wed, 01 Feb 2017)


Log Message
Tag Safari-604.1.6.

Added Paths

tags/Safari-604.1.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211506] tags/Safari-603.1.23.1/

[matthew_hanson]

Title: [211506] tags/Safari-603.1.23.1/








Revision 211506
Author matthew_han...@apple.com
Date 2017-02-01 13:06:04 -0800 (Wed, 01 Feb 2017)


Log Message
Tag Safari-603.1.23.1.

Added Paths

tags/Safari-603.1.23.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211505] tags/Safari-604.1.6/

[jmarcell]

Title: [211505] tags/Safari-604.1.6/








Revision 211505
Author jmarc...@apple.com
Date 2017-02-01 12:20:32 -0800 (Wed, 01 Feb 2017)


Log Message
Deleting tag.

Removed Paths

tags/Safari-604.1.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211504] trunk

[cdumez]

Title: [211504] trunk








Revision 211504
Author cdu...@apple.com
Date 2017-02-01 12:13:05 -0800 (Wed, 01 Feb 2017)


Log Message
REGRESSION(r205136): {}.toString.call(crossOriginWindow) should not throw
https://bugs.webkit.org/show_bug.cgi?id=167681


Reviewed by Mark Lam.

LayoutTests/imported/w3c:

Rebaseline W3C test now that we passing one more check. We're still failing
later because {}.toString.call(crossOriginWindow) returns "[object Window]"
instead of "[object Object]". I am planning to fix this in a follow-up.
This is not a regression since we were returning "[object Window]" before
r205136.

* web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

As per https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-):
"""
If P is @@toStringTag, @@hasInstance, or @@isConcatSpreadable, then return
PropertyDescriptor{ [[Value]]: undefined, [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }.
"""

We now implement this behavior instead of throwing.

Test: http/tests/security/symbols-cross-origin.html

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

Add layout test coverage.

* http/tests/security/symbols-cross-origin-expected.txt: Added.
* http/tests/security/symbols-cross-origin.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSLocationCustom.cpp


Added Paths

trunk/LayoutTests/http/tests/security/symbols-cross-origin-expected.txt
trunk/LayoutTests/http/tests/security/symbols-cross-origin.html




Diff

Modified: trunk/LayoutTests/ChangeLog (211503 => 211504)

--- trunk/LayoutTests/ChangeLog	2017-02-01 20:03:48 UTC (rev 211503)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 20:13:05 UTC (rev 211504)
@@ -1,3 +1,16 @@
+2017-02-01  Chris Dumez  
+
+REGRESSION(r205136): {}.toString.call(crossOriginWindow) should not throw
+https://bugs.webkit.org/show_bug.cgi?id=167681
+
+
+Reviewed by Mark Lam.
+
+Add layout test coverage.
+
+* http/tests/security/symbols-cross-origin-expected.txt: Added.
+* http/tests/security/symbols-cross-origin.html: Added.
+
 2017-02-01  Antoine Quint  
 
 [mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout


Added: trunk/LayoutTests/http/tests/security/symbols-cross-origin-expected.txt (0 => 211504)

--- trunk/LayoutTests/http/tests/security/symbols-cross-origin-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/symbols-cross-origin-expected.txt	2017-02-01 20:13:05 UTC (rev 211504)
@@ -0,0 +1,24 @@
+Tests that symbols can be accessed on cross origin Window / Location objects
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* Window
+FAIL (new Object).toString.call(crossOriginWindow) should be [object Object]. Was [object Window].
+PASS crossOriginWindow instanceof Window is false
+PASS Array.prototype.concat.call(crossOriginWindow, ['A']) is [crossOriginWindow, 'A']
+PASS crossOriginWindow.toString() threw exception SecurityError (DOM Exception 18): Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match..
+PASS '' + crossOriginWindow threw exception SecurityError (DOM Exception 18): Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match..
+PASS crossOriginWindow.concat(['A']) threw exception SecurityError (DOM Exception 18): Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match..
+
+* Location
+FAIL (new Object).toString.call(crossOriginWindow.location) should be [object Object]. Was [object Location].
+PASS crossOriginWindow.location instanceof Location is false
+PASS Array.prototype.concat.call(crossOriginWindow.location, ['A']) is [crossOriginWindow.location, 'A']
+PASS crossOriginWindow.location.toString() threw exception SecurityError (DOM Exception 18): Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match..
+PASS '' + crossOriginWindow.location threw exception SecurityError (DOM Exception 18): Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match..
+PASS cros

[webkit-changes] [211503] trunk/Source/WTF

[wenson_hsieh]

Title: [211503] trunk/Source/WTF








Revision 211503
Author wenson_hs...@apple.com
Date 2017-02-01 12:03:48 -0800 (Wed, 01 Feb 2017)


Log Message
Unreviewed, fix the WebKit nightly open source build


We cannot assume all internal SDKs have the latest WebKitAdditions, so we need an explicit header check here.

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/WTF/ChangeLog (211502 => 211503)

--- trunk/Source/WTF/ChangeLog	2017-02-01 20:00:18 UTC (rev 211502)
+++ trunk/Source/WTF/ChangeLog	2017-02-01 20:03:48 UTC (rev 211503)
@@ -1,3 +1,12 @@
+2017-02-01  Wenson Hsieh  
+
+Unreviewed, fix the WebKit nightly open source build
+
+
+We cannot assume all internal SDKs have the latest WebKitAdditions, so we need an explicit header check here.
+
+* wtf/Platform.h:
+
 2017-02-01  Andreas Kling  
 
 Implement the alwaysRunsAtBackgroundPriority WK2 setting using thread QoS.


Modified: trunk/Source/WTF/wtf/Platform.h (211502 => 211503)

--- trunk/Source/WTF/wtf/Platform.h	2017-02-01 20:00:18 UTC (rev 211502)
+++ trunk/Source/WTF/wtf/Platform.h	2017-02-01 20:03:48 UTC (rev 211503)
@@ -669,7 +669,7 @@
 /* Include feature macros */
 #include 
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
 #include 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211502] trunk

[bfulgham]

Title: [211502] trunk








Revision 211502
Author bfulg...@apple.com
Date 2017-02-01 12:00:18 -0800 (Wed, 01 Feb 2017)


Log Message
Correct "filesHaveSameVolume" predicate
https://bugs.webkit.org/show_bug.cgi?id=167696


Reviewed by David Kilzer.

Source/WebCore:

We are passing %-encoded strings to the underlying operating system's file system APIs.
This doesn't work. Instead, we need to present a decoded version of the file path
that matches what the system APIs expect.

Tested by new TestWebKitAPI Test.

* platform/FileSystem.cpp:
(WebCore::filesHaveSameVolume): Make sure the file paths we give to the underlying
operating system are not percent encoded.
* platform/FileSystem.h: Export 'filesHaveSameVolume' for use by testing system.

Tools:

Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
percent-escaped path inputs.

* TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
(TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
(TestWebKitAPI::FileSystemTest::bangContainingFilePath):
(TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FileSystem.cpp
trunk/Source/WebCore/platform/FileSystem.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (211501 => 211502)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 19:54:25 UTC (rev 211501)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 20:00:18 UTC (rev 211502)
@@ -1,3 +1,22 @@
+2017-02-01  Brent Fulgham  
+
+Correct "filesHaveSameVolume" predicate
+https://bugs.webkit.org/show_bug.cgi?id=167696
+
+
+Reviewed by David Kilzer.
+
+We are passing %-encoded strings to the underlying operating system's file system APIs.
+This doesn't work. Instead, we need to present a decoded version of the file path
+that matches what the system APIs expect.
+
+Tested by new TestWebKitAPI Test.
+
+* platform/FileSystem.cpp:
+(WebCore::filesHaveSameVolume): Make sure the file paths we give to the underlying
+operating system are not percent encoded.
+* platform/FileSystem.h: Export 'filesHaveSameVolume' for use by testing system.
+
 2017-02-01  Antoine Quint  
 
 [mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout


Modified: trunk/Source/WebCore/platform/FileSystem.cpp (211501 => 211502)

--- trunk/Source/WebCore/platform/FileSystem.cpp	2017-02-01 19:54:25 UTC (rev 211501)
+++ trunk/Source/WebCore/platform/FileSystem.cpp	2017-02-01 20:00:18 UTC (rev 211502)
@@ -28,6 +28,7 @@
 #include "FileSystem.h"
 
 #include "ScopeGuard.h"
+#include "URL.h"
 #include 
 #include 
 #include 
@@ -236,8 +237,8 @@
 
 bool filesHaveSameVolume(const String& fileA, const String& fileB)
 {
-auto fsRepFileA = fileSystemRepresentation(fileA);
-auto fsRepFileB = fileSystemRepresentation(fileB);
+auto fsRepFileA = fileSystemRepresentation(decodeURLEscapeSequences(fileA));
+auto fsRepFileB = fileSystemRepresentation(decodeURLEscapeSequences(fileB));
 
 if (fsRepFileA.isNull() || fsRepFileB.isNull())
 return false;


Modified: trunk/Source/WebCore/platform/FileSystem.h (211501 => 211502)

--- trunk/Source/WebCore/platform/FileSystem.h	2017-02-01 19:54:25 UTC (rev 211501)
+++ trunk/Source/WebCore/platform/FileSystem.h	2017-02-01 20:00:18 UTC (rev 211502)
@@ -194,7 +194,7 @@
 WEBCORE_EXPORT String encodeForFileName(const String&);
 String decodeFromFilename(const String&);
 
-bool filesHaveSameVolume(const String&, const String&);
+WEBCORE_EXPORT bool filesHaveSameVolume(const String&, const String&);
 
 #if USE(CF)
 RetainPtr pathAsURL(const String&);


Modified: trunk/Tools/ChangeLog (211501 => 211502)

--- trunk/Tools/ChangeLog	2017-02-01 19:54:25 UTC (rev 211501)
+++ trunk/Tools/ChangeLog	2017-02-01 20:00:18 UTC (rev 211502)
@@ -1,3 +1,20 @@
+2017-02-01  Brent Fulgham  
+
+Correct "filesHaveSameVolume" predicate
+https://bugs.webkit.org/show_bug.cgi?id=167696
+
+
+Reviewed by David Kilzer.
+
+Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
+percent-escaped path inputs.
+
+* TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
+(TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
+(TestWebKitAPI::FileSystemTest::bangContainingFilePath):
+(TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
+(TestWebKitAPI::TEST_F):
+
 2017-02-01  Tomas Popela  
 
 Unreviewed. Fix coding style in MiniBrowser


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp (211501 => 211502)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2017-02-01 19:54:25 UTC (rev 211501)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2017-02-01 20:00:18 UTC (rev 21

[webkit-changes] [211501] trunk

[commit-queue]

Title: [211501] trunk








Revision 211501
Author commit-qu...@webkit.org
Date 2017-02-01 11:54:25 -0800 (Wed, 01 Feb 2017)


Log Message
[mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=165319


Patch by Antoine Quint  on 2017-02-01
Reviewed by Dean Jackson.

Source/WebCore:

Running media/controls/track-menu.html before media/modern-media-controls/tracks-support/tracks-
support-click-track-in-panel.html makes that test time out in all test runs. The root of the issue
is that animations are suspended by media/controls/track-menu.html with a call to
internals.suspendAnimations(), and that state isn't reset with a call to internals.resumeAnimations().
Then, media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html fails because
the selection animation for the tracks panel menu item that is clicked never completes and the delegate
to notify that an item in the tracks panel was selected is never fired, which leads to the test failure.

We change Internals::suspendAnimations() and Internals::resumeAnimations() to only affect the current
document, rather than calling into AnimationController::suspendAnimations() which would do just that,
but also set a Frame-wide flag that would prevent further animations from running, even in a subsequent
document load.

* dom/Document.cpp:
(WebCore::Document::prepareForDestruction): Ensure the document that is about to be destroyed is no longer
associated with an AnimationController.
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation): Update the animation's suspend state in case
the document its renderer is associated with is suspended. This is required since previously CompositeAnimations
would set their suspend state in their constructor, based on the Frame-wide suspended state, but there is no
document to use as a basis to query its suspended state in that constructor.
(WebCore::AnimationControllerPrivate::animationsAreSuspendedForDocument):
(WebCore::AnimationControllerPrivate::detachFromDocument):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended):
(WebCore::AnimationController::animationsAreSuspendedForDocument):
(WebCore::AnimationController::detachFromDocument):
* page/animation/AnimationController.h:
* page/animation/AnimationControllerPrivate.h:
* testing/Internals.cpp:
(WebCore::Internals::animationsAreSuspended):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):

LayoutTests:

Since we've fixed the root cause of this test's flakiness, we no longer need to mark it as flaky.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/animation/AnimationController.cpp
trunk/Source/WebCore/page/animation/AnimationController.h
trunk/Source/WebCore/page/animation/AnimationControllerPrivate.h
trunk/Source/WebCore/testing/Internals.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (211500 => 211501)

--- trunk/LayoutTests/ChangeLog	2017-02-01 19:44:07 UTC (rev 211500)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 19:54:25 UTC (rev 211501)
@@ -1,3 +1,15 @@
+2017-02-01  Antoine Quint  
+
+[mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=165319
+
+
+Reviewed by Dean Jackson.
+
+Since we've fixed the root cause of this test's flakiness, we no longer need to mark it as flaky.
+
+* platform/mac/TestExpectations:
+
 2017-02-01  Jer Noble  
 
 NULL-deref crash in TextTrack::removeCue()


Modified: trunk/LayoutTests/platform/mac/TestExpectations (211500 => 211501)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-02-01 19:44:07 UTC (rev 211500)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-02-01 19:54:25 UTC (rev 211501)
@@ -1484,8 +1484,6 @@
 
 webkit.org/b/167442 [ ElCapitan ] media/modern-media-controls/airplay-support/airplay-support.html [ Pass Timeout ]
 
-webkit.org/b/165319 media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html [ Pass Timeout ]
-
 webkit.org/b/167461 media/modern-media-controls/layout-node/addChild.html [ Pass Timeout ]
 
 webkit.org/b/165874 [ Debug ] streams/pipe-to.html [ Pass Failure ]


Modified: trunk/Source/WebCore/ChangeLog (211500 => 211501)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 19:44:07 UTC (rev 211500)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 19:54:25 UTC (rev 211501)
@@ -1,3 +1,46 @@
+2017-02-01  Antoine Quint  
+
+[mac-wk1] LayoutTest media/modern-media-controls/tracks-s

[webkit-changes] [211500] trunk/Source/WebCore

[ryanhaddad]

Title: [211500] trunk/Source/WebCore








Revision 211500
Author ryanhad...@apple.com
Date 2017-02-01 11:44:07 -0800 (Wed, 01 Feb 2017)


Log Message
Unreviewed build fix after r211488.

* accessibility/AXObjectCache.h: Removed property svn:executable.

Modified Paths

trunk/Source/WebCore/ChangeLog


Property Changed

trunk/Source/WebCore/accessibility/AXObjectCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211499 => 211500)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 19:25:53 UTC (rev 211499)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 19:44:07 UTC (rev 211500)
@@ -1,3 +1,9 @@
+2017-02-01  Ryan Haddad  
+
+Unreviewed build fix after r211488.
+
+* accessibility/AXObjectCache.h: Removed property svn:executable.
+
 2017-02-01  Brent Fulgham  
 
 Unreviewed build fix.
Index: trunk/Source/WebCore/accessibility/AXObjectCache.h
===
--- trunk/Source/WebCore/accessibility/AXObjectCache.h	2017-02-01 19:25:53 UTC (rev 211499)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h	2017-02-01 19:44:07 UTC (rev 211500)


Property changes: trunk/Source/WebCore/accessibility/AXObjectCache.h



Deleted: svn:executable
-*
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211499] branches/safari-604.1.5-branch/Source

[matthew_hanson]

Title: [211499] branches/safari-604.1.5-branch/Source








Revision 211499
Author matthew_han...@apple.com
Date 2017-02-01 11:25:53 -0800 (Wed, 01 Feb 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (211498 => 211499)

--- branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 18:34:31 UTC (rev 211498)
+++ branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 19:25:53 UTC (rev 211499)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (211498 => 211499)

--- branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 18:34:31 UTC (rev 211498)
+++ branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 19:25:53 UTC (rev 211499)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (211498 => 211499)

--- branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-02-01 18:34:31 UTC (rev 211498)
+++ branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-02-01 19:25:53 UTC (rev 211499)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (211498 => 211499)

--- branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 18:34:31 UTC (rev 211498)
+++ branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 19:25:53 UTC (rev 211499)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig (211498 => 211499)

--- branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 18:34:31 UTC (rev 211498)
+++ branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 19:25:53 UTC (rev 211499)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig (211498 => 211499)

--- branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 18:34:31 UTC (rev 211498)
+++ branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 19:25:53 UTC (rev 211499)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211498] trunk/JSTests

[utatane . tea]

Title: [211498] trunk/JSTests








Revision 211498
Author utatane@gmail.com
Date 2017-02-01 10:34:31 -0800 (Wed, 01 Feb 2017)


Log Message
Unreviewed, remove loop
https://bugs.webkit.org/show_bug.cgi?id=167694

It causes timeout.
Original bug can be tested even without this loop.

* stress/arity-fixup-should-not-touch-stack-area-below-sp.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/arity-fixup-should-not-touch-stack-area-below-sp.js




Diff

Modified: trunk/JSTests/ChangeLog (211497 => 211498)

--- trunk/JSTests/ChangeLog	2017-02-01 18:31:05 UTC (rev 211497)
+++ trunk/JSTests/ChangeLog	2017-02-01 18:34:31 UTC (rev 211498)
@@ -1,5 +1,15 @@
 2017-02-01  Yusuke Suzuki  
 
+Unreviewed, remove loop
+https://bugs.webkit.org/show_bug.cgi?id=167694
+
+It causes timeout.
+Original bug can be tested even without this loop.
+
+* stress/arity-fixup-should-not-touch-stack-area-below-sp.js:
+
+2017-02-01  Yusuke Suzuki  
+
 ArityFixup should adjust SP first
 https://bugs.webkit.org/show_bug.cgi?id=167239
 


Modified: trunk/JSTests/stress/arity-fixup-should-not-touch-stack-area-below-sp.js (211497 => 211498)

--- trunk/JSTests/stress/arity-fixup-should-not-touch-stack-area-below-sp.js	2017-02-01 18:31:05 UTC (rev 211497)
+++ trunk/JSTests/stress/arity-fixup-should-not-touch-stack-area-below-sp.js	2017-02-01 18:34:31 UTC (rev 211498)
@@ -1,5 +1,3 @@
 var args = "y,".repeat(3);
 var g = Function(args, "return 0");
-for (var i = 0; i < 1e3; ++i) {
-g();
-}
+g();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211497] trunk/Source/WebCore

[bfulgham]

Title: [211497] trunk/Source/WebCore








Revision 211497
Author bfulg...@apple.com
Date 2017-02-01 10:31:05 -0800 (Wed, 01 Feb 2017)


Log Message
Unreviewed build fix.

* html/HTMLMediaElement.h: Removed property svn:executable.

Modified Paths

trunk/Source/WebCore/ChangeLog


Property Changed

trunk/Source/WebCore/html/HTMLMediaElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211496 => 211497)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 18:22:46 UTC (rev 211496)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 18:31:05 UTC (rev 211497)
@@ -1,3 +1,9 @@
+2017-02-01  Brent Fulgham  
+
+Unreviewed build fix.
+
+* html/HTMLMediaElement.h: Removed property svn:executable.
+
 2017-02-01  Jer Noble  
 
 NULL-deref crash in TextTrack::removeCue()
Index: trunk/Source/WebCore/html/HTMLMediaElement.h
===
--- trunk/Source/WebCore/html/HTMLMediaElement.h	2017-02-01 18:22:46 UTC (rev 211496)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2017-02-01 18:31:05 UTC (rev 211497)


Property changes: trunk/Source/WebCore/html/HTMLMediaElement.h



Deleted: svn:executable
-*
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211496] tags/Safari-604.1.5.2/

[matthew_hanson]

Title: [211496] tags/Safari-604.1.5.2/








Revision 211496
Author matthew_han...@apple.com
Date 2017-02-01 10:22:46 -0800 (Wed, 01 Feb 2017)


Log Message
New Tag.

Added Paths

tags/Safari-604.1.5.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211495] trunk

[jer . noble]

Title: [211495] trunk








Revision 211495
Author jer.no...@apple.com
Date 2017-02-01 10:22:21 -0800 (Wed, 01 Feb 2017)


Log Message
NULL-deref crash in TextTrack::removeCue()
https://bugs.webkit.org/show_bug.cgi?id=167615

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/track-in-band-hls-metadata-crash.html

Follow-up to r211401. When passing around a reference to an object, the assumption is that
the caller is retaining the underlying object. This breaks down for
InbandDataTextTrack::removeDataCue(), which releases its own ownership of the cue object,
then passes the reference to that object to its superclass to do further remove steps. The
retain count of the cue can thus drop to zero within the scope of
InbandTextTrack::removeCue(). Use "take" semantics to remove the cue from the
m_incompleteCueMap without releasing ownership, and pass a reference to that retained object
on to removeCue(), guaranteeing that the cue will not be destroyed until after the
romeveDataCue() method returns.

* html/track/InbandDataTextTrack.cpp:
(WebCore::InbandDataTextTrack::removeDataCue):

LayoutTests:

* http/tests/media/track-in-band-hls-metadata-crash-expected.txt: Added.
* http/tests/media/track-in-band-hls-metadata-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/InbandDataTextTrack.cpp


Added Paths

trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt
trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (211494 => 211495)

--- trunk/LayoutTests/ChangeLog	2017-02-01 18:20:41 UTC (rev 211494)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 18:22:21 UTC (rev 211495)
@@ -1,3 +1,13 @@
+2017-02-01  Jer Noble  
+
+NULL-deref crash in TextTrack::removeCue()
+https://bugs.webkit.org/show_bug.cgi?id=167615
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/track-in-band-hls-metadata-crash-expected.txt: Added.
+* http/tests/media/track-in-band-hls-metadata-crash.html: Added.
+
 2017-02-01  Nan Wang  
 
 AX: Incorrect range from index and length in text controls when there are newlines


Added: trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt (0 => 211495)

--- trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt	2017-02-01 18:22:21 UTC (rev 211495)
@@ -0,0 +1,18 @@
+
+Test that seeking HLS streams containing metadata tracks does not crash.
+
+
+** Set video.src, wait for media data to load
+RUN(video.src = '')
+
+EVENT(addtrack)
+RUN(track = video.textTracks[0])
+RUN(track.mode = 'hidden')
+RUN(video.play())
+EVENT(cuechange)
+
+** Seek, should not crash.
+RUN(video.currentTime = 5)
+EVENT(seeked)
+END OF TEST
+


Added: trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html (0 => 211495)

--- trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html	(rev 0)
+++ trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html	2017-02-01 18:22:21 UTC (rev 211495)
@@ -0,0 +1,43 @@
+
+
+
+
+
+
+var track;
+
+function addtrack(event)
+{
+tracks = event.target;
+run("track = video.textTracks[0]");
+run("track.mode = 'hidden'");
+run("video.play()");
+waitForEvent('cuechange', cuechange, false, true, track);
+}
+
+function cuechange()
+{
+consoleWrite("
** Seek, should not crash.");
+run("video.currentTime = 5"); 
+waitForEventAndEnd("seeked");
+}
+
+function start()
+{
+consoleWrite("
** Set video.src, wait for media data to load");
+findMediaElement();
+run("video.src = ''");
+
+consoleWrite("");
+waitForEvent('addtrack', addtrack, false, true, video.textTracks);
+}
+
+
+
+
+Test that seeking HLS streams containing metadata tracks does not crash.
+
+


Modified: trunk/Source/WebCore/ChangeLog (211494 => 211495)

--- trunk/Source/WebCore/ChangeLog	2017-02-01 18:20:41 UTC (rev 211494)
+++ trunk/Source/WebCore/ChangeLog	2017-02-01 18:22:21 UTC (rev 211495)
@@ -1,3 +1,25 @@
+2017-02-01  Jer Noble  
+
+NULL-deref crash in TextTrack::removeCue()
+https://bugs.webkit.org/show_bug.cgi?id=167615
+
+Reviewed by Eric Carlson.
+
+Test: http/tests/media/track-in-band-hls-metadata-crash.html
+
+Follow-up to r211401. When passing around a reference to an object, the assumption is that
+the caller is retaining the underlying o

[webkit-changes] [211494] branches/safari-604.1.5-branch/Source/WebKit/mac

[matthew_hanson]

Title: [211494] branches/safari-604.1.5-branch/Source/WebKit/mac








Revision 211494
Author matthew_han...@apple.com
Date 2017-02-01 10:20:41 -0800 (Wed, 01 Feb 2017)


Log Message
Merge r211492. rdar://problem/30305390

Modified Paths

branches/safari-604.1.5-branch/Source/WebKit/mac/ChangeLog
branches/safari-604.1.5-branch/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: branches/safari-604.1.5-branch/Source/WebKit/mac/ChangeLog (211493 => 211494)

--- branches/safari-604.1.5-branch/Source/WebKit/mac/ChangeLog	2017-02-01 18:17:13 UTC (rev 211493)
+++ branches/safari-604.1.5-branch/Source/WebKit/mac/ChangeLog	2017-02-01 18:20:41 UTC (rev 211494)
@@ -1,3 +1,22 @@
+2017-02-01  Matthew Hanson  
+
+Merge r211492. rdar://problem/30305390
+
+2017-02-01  Wenson Hsieh  
+
+[WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
+https://bugs.webkit.org/show_bug.cgi?id=167695
+
+
+Reviewed by Sam Weinig.
+
+Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
+exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
+is destroyed.
+
+* WebView/WebView.mm:
+(-[WebView _commonInitializationWithFrameName:groupName:]):
+
 2017-01-30  Matthew Hanson  
 
 Merge r211323. rdar://problem/30107776


Modified: branches/safari-604.1.5-branch/Source/WebKit/mac/WebView/WebView.mm (211493 => 211494)

--- branches/safari-604.1.5-branch/Source/WebKit/mac/WebView/WebView.mm	2017-02-01 18:17:13 UTC (rev 211493)
+++ branches/safari-604.1.5-branch/Source/WebKit/mac/WebView/WebView.mm	2017-02-01 18:20:41 UTC (rev 211494)
@@ -1354,9 +1354,6 @@
 pageConfiguration.contextMenuClient = new WebContextMenuClient(self);
 // FIXME: We should enable this on iOS as well.
 pageConfiguration.validationMessageClient = std::make_unique(self);
-#if ENABLE(DRAG_SUPPORT)
-pageConfiguration.dragClient = new WebDragClient(self);
-#endif
 pageConfiguration.inspectorClient = new WebInspectorClient(self);
 #else
 pageConfiguration.chromeClient = new WebChromeClientIOS(self);
@@ -1363,6 +1360,10 @@
 pageConfiguration.inspectorClient = new WebInspectorClient(self);
 #endif
 
+#if ENABLE(DRAG_SUPPORT)
+pageConfiguration.dragClient = new WebDragClient(self);
+#endif
+
 pageConfiguration.backForwardClient = BackForwardList::create(self);
 
 #if ENABLE(APPLE_PAY)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211493] branches/safari-604.1.5-branch/Source

[matthew_hanson]

Title: [211493] branches/safari-604.1.5-branch/Source








Revision 211493
Author matthew_han...@apple.com
Date 2017-02-01 10:17:13 -0800 (Wed, 01 Feb 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (211492 => 211493)

--- branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 18:15:13 UTC (rev 211492)
+++ branches/safari-604.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-02-01 18:17:13 UTC (rev 211493)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (211492 => 211493)

--- branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 18:15:13 UTC (rev 211492)
+++ branches/safari-604.1.5-branch/Source/WebCore/Configurations/Version.xcconfig	2017-02-01 18:17:13 UTC (rev 211493)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (211492 => 211493)

--- branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-02-01 18:15:13 UTC (rev 211492)
+++ branches/safari-604.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-02-01 18:17:13 UTC (rev 211493)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (211492 => 211493)

--- branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 18:15:13 UTC (rev 211492)
+++ branches/safari-604.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-02-01 18:17:13 UTC (rev 211493)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig (211492 => 211493)

--- branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 18:15:13 UTC (rev 211492)
+++ branches/safari-604.1.5-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-02-01 18:17:13 UTC (rev 211493)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig (211492 => 211493)

--- branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 18:15:13 UTC (rev 211492)
+++ branches/safari-604.1.5-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-02-01 18:17:13 UTC (rev 211493)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211492] trunk/Source/WebKit/mac

[wenson_hsieh]

Title: [211492] trunk/Source/WebKit/mac








Revision 211492
Author wenson_hs...@apple.com
Date 2017-02-01 10:15:13 -0800 (Wed, 01 Feb 2017)


Log Message
[WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
https://bugs.webkit.org/show_bug.cgi?id=167695


Reviewed by Sam Weinig.

Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
is destroyed.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (211491 => 211492)

--- trunk/Source/WebKit/mac/ChangeLog	2017-02-01 18:12:08 UTC (rev 211491)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-01 18:15:13 UTC (rev 211492)
@@ -1,3 +1,18 @@
+2017-02-01  Wenson Hsieh  
+
+[WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
+https://bugs.webkit.org/show_bug.cgi?id=167695
+
+
+Reviewed by Sam Weinig.
+
+Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
+exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
+is destroyed.
+
+* WebView/WebView.mm:
+(-[WebView _commonInitializationWithFrameName:groupName:]):
+
 2017-01-31  Joseph Pecoraro  
 
 ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category


Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (211491 => 211492)

--- trunk/Source/WebKit/mac/WebView/WebView.mm	2017-02-01 18:12:08 UTC (rev 211491)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2017-02-01 18:15:13 UTC (rev 211492)
@@ -1354,9 +1354,6 @@
 pageConfiguration.contextMenuClient = new WebContextMenuClient(self);
 // FIXME: We should enable this on iOS as well.
 pageConfiguration.validationMessageClient = std::make_unique(self);
-#if ENABLE(DRAG_SUPPORT)
-pageConfiguration.dragClient = new WebDragClient(self);
-#endif
 pageConfiguration.inspectorClient = new WebInspectorClient(self);
 #else
 pageConfiguration.chromeClient = new WebChromeClientIOS(self);
@@ -1363,6 +1360,10 @@
 pageConfiguration.inspectorClient = new WebInspectorClient(self);
 #endif
 
+#if ENABLE(DRAG_SUPPORT)
+pageConfiguration.dragClient = new WebDragClient(self);
+#endif
+
 pageConfiguration.backForwardClient = BackForwardList::create(self);
 
 #if ENABLE(APPLE_PAY)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211491] trunk

[n_wang]

Title: [211491] trunk








Revision 211491
Author n_w...@apple.com
Date 2017-02-01 10:12:08 -0800 (Wed, 01 Feb 2017)


Log Message
AX: Incorrect range from index and length in text controls when there are newlines
https://bugs.webkit.org/show_bug.cgi?id=167677


Reviewed by Chris Fleizach.

Source/WebCore:

When there are newlines in text controls, the VisiblePosition that is created
from the index could be wrong. Because the index doesn't include the information
regarding a position's affinity. Fixed it by using CharacterOffset instead, since
it doesn't require that information.

Test: accessibility/mac/range-for-contenteditable-newline.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::nextCharacterOffset):
(WebCore::AXObjectCache::characterOffsetForIndex):

LayoutTests:

* accessibility/mac/range-for-contenteditable-newline-expected.txt: Added.
* accessibility/mac/range-for-contenteditable-newline.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp


Added Paths

trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline-expected.txt
trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline.html




Diff

Modified: trunk/LayoutTests/ChangeLog (211490 => 211491)

--- trunk/LayoutTests/ChangeLog	2017-02-01 18:08:57 UTC (rev 211490)
+++ trunk/LayoutTests/ChangeLog	2017-02-01 18:12:08 UTC (rev 211491)
@@ -1,3 +1,14 @@
+2017-02-01  Nan Wang  
+
+AX: Incorrect range from index and length in text controls when there are newlines
+https://bugs.webkit.org/show_bug.cgi?id=167677
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/range-for-contenteditable-newline-expected.txt: Added.
+* accessibility/mac/range-for-contenteditable-newline.html: Added.
+
 2017-02-01  Ryan Haddad  
 
 ios-simulator TestExpectations gardening.


Added: trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline-expected.txt (0 => 211491)

--- trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline-expected.txt	2017-02-01 18:12:08 UTC (rev 211491)
@@ -0,0 +1,25 @@
+some
+hello world
+test
+
+abc
+
+
+
+def
+This tests that when there are newline characters within text controls, we can get the correct text range from index and length.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS textSome is 'some'
+PASS textHello is 'hello'
+PASS textWorld is 'world'
+PASS textTest is 'test'
+PASS textareaTextHello is 'hello'
+PASS textareaTextWorld is 'world'
+PASS textDEF is 'def'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline.html (0 => 211491)

--- trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline.html	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/range-for-contenteditable-newline.html	2017-02-01 18:12:08 UTC (rev 211491)
@@ -0,0 +1,51 @@
+
+
+
+
+
+
+

+
some
hello world
test
+hello test
+world
+
+
abc



def
+
+

+
+