[webkit-changes] [211854] trunk/Source/WebCore

[carlosgc]

Title: [211854] trunk/Source/WebCore








Revision 211854
Author carlo...@webkit.org
Date 2017-02-07 22:54:01 -0800 (Tue, 07 Feb 2017)


Log Message
REGRESSION(r210740): [GTK] 2.15 broke embedded videos in GNOME's yelp app
https://bugs.webkit.org/show_bug.cgi?id=167887

Reviewed by Michael Catanzaro.

Update the m_renderingCanBeAccelerated when accelerated rendering state changes.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (211853 => 211854)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 06:41:12 UTC (rev 211853)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 06:54:01 UTC (rev 211854)
@@ -1,5 +1,19 @@
 2017-02-07  Carlos Garcia Campos  
 
+REGRESSION(r210740): [GTK] 2.15 broke embedded videos in GNOME's yelp app
+https://bugs.webkit.org/show_bug.cgi?id=167887
+
+Reviewed by Michael Catanzaro.
+
+Update the m_renderingCanBeAccelerated when accelerated rendering state changes.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged):
+(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
+2017-02-07  Carlos Garcia Campos  
+
 [GTK] Handle extended colors in cairo and texture mapper backends
 https://bugs.webkit.org/show_bug.cgi?id=167943
 


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (211853 => 211854)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2017-02-08 06:41:12 UTC (rev 211853)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2017-02-08 06:54:01 UTC (rev 211854)
@@ -613,6 +613,11 @@
 player->m_notifier.notify(MainThreadNotification::MuteChanged, [player] { player->notifyPlayerOfMute(); });
 }
 
+void MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged()
+{
+m_renderingCanBeAccelerated = m_player && m_player->client().mediaPlayerAcceleratedCompositingEnabled() && m_player->client().mediaPlayerRenderingCanBeAccelerated(m_player);
+}
+
 #if USE(TEXTURE_MAPPER_GL) && !USE(COORDINATED_GRAPHICS_MULTIPROCESS)
 void MediaPlayerPrivateGStreamerBase::updateTexture(BitmapTextureGL& texture, GstVideoInfo& videoInfo)
 {
@@ -1105,8 +1110,7 @@
 
 GstElement* MediaPlayerPrivateGStreamerBase::createVideoSink()
 {
-m_renderingCanBeAccelerated = supportsAcceleratedRendering() && m_player->client().mediaPlayerAcceleratedCompositingEnabled()
-&& m_player->client().mediaPlayerRenderingCanBeAccelerated(m_player);
+acceleratedRenderingStateChanged();
 
 #if USE(GSTREAMER_GL)
 if (m_renderingCanBeAccelerated)


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h (211853 => 211854)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h	2017-02-08 06:41:12 UTC (rev 211853)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h	2017-02-08 06:54:01 UTC (rev 211854)
@@ -105,6 +105,8 @@
 unsigned audioDecodedByteCount() const override;
 unsigned videoDecodedByteCount() const override;
 
+void acceleratedRenderingStateChanged() override;
+
 #if USE(TEXTURE_MAPPER_GL) && !USE(COORDINATED_GRAPHICS)
 PlatformLayer* platformLayer() const override { return const_cast(this); }
 #if PLATFORM(WIN_CAIRO)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211853] trunk/Source/WebCore

[carlosgc]

Title: [211853] trunk/Source/WebCore








Revision 211853
Author carlo...@webkit.org
Date 2017-02-07 22:41:12 -0800 (Tue, 07 Feb 2017)


Log Message
[GTK] Handle extended colors in cairo and texture mapper backends
https://bugs.webkit.org/show_bug.cgi?id=167943

Reviewed by Michael Catanzaro.

Fixes: css3/color/backgrounds-and-borders.html
   css3/color/box-shadows.html
   css3/color/canvas.html
   css3/color/composited-solid-backgrounds.html
   css3/color/text.html

* platform/graphics/Color.cpp:
(WebCore::premultipliedARGBFromColor): Handle the case of color being extended.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::setSourceRGBAFromColor): Ditto.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::fillRectWithColor): Use isVisible() instead of alpha().
(WebCore::GraphicsContext::drawEllipse): Ditto.
* platform/graphics/gtk/ColorGtk.cpp:
(WebCore::Color::operator GdkRGBA): Handle the case of color being extended.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawNumber): Ditto.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::blendWithOpacity): Ditto.
(WebCore::TextureMapperLayer::paintSelf): Use isVisible() instead of alpha().
(WebCore::TextureMapperLayer::computeOverlapRegions): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Color.cpp
trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/gtk/ColorGtk.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (211852 => 211853)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 01:47:31 UTC (rev 211852)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 06:41:12 UTC (rev 211853)
@@ -1,3 +1,32 @@
+2017-02-07  Carlos Garcia Campos  
+
+[GTK] Handle extended colors in cairo and texture mapper backends
+https://bugs.webkit.org/show_bug.cgi?id=167943
+
+Reviewed by Michael Catanzaro.
+
+Fixes: css3/color/backgrounds-and-borders.html
+   css3/color/box-shadows.html
+   css3/color/canvas.html
+   css3/color/composited-solid-backgrounds.html
+   css3/color/text.html
+
+* platform/graphics/Color.cpp:
+(WebCore::premultipliedARGBFromColor): Handle the case of color being extended.
+* platform/graphics/cairo/CairoUtilities.cpp:
+(WebCore::setSourceRGBAFromColor): Ditto.
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::fillRectWithColor): Use isVisible() instead of alpha().
+(WebCore::GraphicsContext::drawEllipse): Ditto.
+* platform/graphics/gtk/ColorGtk.cpp:
+(WebCore::Color::operator GdkRGBA): Handle the case of color being extended.
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::TextureMapperGL::drawNumber): Ditto.
+* platform/graphics/texmap/TextureMapperLayer.cpp:
+(WebCore::blendWithOpacity): Ditto.
+(WebCore::TextureMapperLayer::paintSelf): Use isVisible() instead of alpha().
+(WebCore::TextureMapperLayer::computeOverlapRegions): Ditto.
+
 2017-02-07  Wenson Hsieh  
 
 WebItemProviderPasteboard should use -registerLoadHandlersToItemProvider: when creating a new UIItemProvider


Modified: trunk/Source/WebCore/platform/graphics/Color.cpp (211852 => 211853)

--- trunk/Source/WebCore/platform/graphics/Color.cpp	2017-02-08 01:47:31 UTC (rev 211852)
+++ trunk/Source/WebCore/platform/graphics/Color.cpp	2017-02-08 06:41:12 UTC (rev 211853)
@@ -616,15 +616,16 @@
 
 RGBA32 premultipliedARGBFromColor(const Color& color)
 {
-unsigned pixelColor;
+if (color.isOpaque()) {
+if (color.isExtended())
+return makeRGB(color.asExtended().red() * 255, color.asExtended().green() * 255, color.asExtended().blue() * 255);
+return color.rgb();
+}
 
-unsigned alpha = color.alpha();
-if (alpha < 255)
-pixelColor = makePremultipliedRGBA(color.red(), color.green(), color.blue(), alpha);
-else
-pixelColor = color.rgb();
+if (color.isExtended())
+return makePremultipliedRGBA(color.asExtended().red() * 255, color.asExtended().green() * 255, color.asExtended().blue() * 255, color.asExtended().alpha() * 255);
 
-return pixelColor;
+return makePremultipliedRGBA(color.red(), color.green(), color.blue(), color.alpha());
 }
 
 Color blend(const Color& from, const Color& to, double progress, bool blendPremultiplied)


Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp (211852 => 211853)

--- trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp	2017-02-08 01:47:31 UTC (rev 211852)
+++ 

[webkit-changes] [211852] trunk/Source/WebCore

[wenson_hsieh]

Title: [211852] trunk/Source/WebCore








Revision 211852
Author wenson_hs...@apple.com
Date 2017-02-07 17:47:31 -0800 (Tue, 07 Feb 2017)


Log Message
WebItemProviderPasteboard should use -registerLoadHandlersToItemProvider: when creating a new UIItemProvider
https://bugs.webkit.org/show_bug.cgi?id=167918


Reviewed by Tim Horton.

Adopts SPI in WebItemProviderPasteboard for object types that the platform knows how to serialize. Since we use
-createObjectOfClass: to initialize data when reading off of the pasteboard, we need to match the format that
objects conforming to UIItemProviderReading will expect. Thus, for all given objects that conform to
UIItemProviderWriting, we have them register themselves to the item provider.

We register other UTI types due to the fact that PlatformPasteboardIOS does not care about the specific
pasteboard used. This should not be necessary, however, since data written to the WebItemProviderPasteboard
should never need to be read by an actual UIPasteboard. This will be refactored in a future patch to add a
special type of WebItemProviderPasteboard-aware PlatformPasteboard.

Also fixes some reference counting issues in WebItemProviderPasteboard by changing the array of _itemProviders
to be a RetainPtr.

* platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard init]):
(-[WebItemProviderPasteboard pasteboardTypes]):
(-[WebItemProviderPasteboard itemProviders]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard numberOfItems]):
(-[WebItemProviderPasteboard setItems:]):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard itemProviderAtIndex:]):
(-[WebItemProviderPasteboard dealloc]): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (211851 => 211852)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 01:25:42 UTC (rev 211851)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 01:47:31 UTC (rev 211852)
@@ -1,3 +1,35 @@
+2017-02-07  Wenson Hsieh  
+
+WebItemProviderPasteboard should use -registerLoadHandlersToItemProvider: when creating a new UIItemProvider
+https://bugs.webkit.org/show_bug.cgi?id=167918
+
+
+Reviewed by Tim Horton.
+
+Adopts SPI in WebItemProviderPasteboard for object types that the platform knows how to serialize. Since we use
+-createObjectOfClass: to initialize data when reading off of the pasteboard, we need to match the format that
+objects conforming to UIItemProviderReading will expect. Thus, for all given objects that conform to
+UIItemProviderWriting, we have them register themselves to the item provider.
+
+We register other UTI types due to the fact that PlatformPasteboardIOS does not care about the specific
+pasteboard used. This should not be necessary, however, since data written to the WebItemProviderPasteboard
+should never need to be read by an actual UIPasteboard. This will be refactored in a future patch to add a
+special type of WebItemProviderPasteboard-aware PlatformPasteboard.
+
+Also fixes some reference counting issues in WebItemProviderPasteboard by changing the array of _itemProviders
+to be a RetainPtr.
+
+* platform/ios/WebItemProviderPasteboard.mm:
+(-[WebItemProviderPasteboard init]):
+(-[WebItemProviderPasteboard pasteboardTypes]):
+(-[WebItemProviderPasteboard itemProviders]):
+(-[WebItemProviderPasteboard setItemProviders:]):
+(-[WebItemProviderPasteboard numberOfItems]):
+(-[WebItemProviderPasteboard setItems:]):
+(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
+(-[WebItemProviderPasteboard itemProviderAtIndex:]):
+(-[WebItemProviderPasteboard dealloc]): Deleted.
+
 2017-02-06  Ryosuke Niwa  
 
 WebContent process repeatedly jetsams on BuzzFeed's Another Round page


Modified: trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm (211851 => 211852)

--- trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm	2017-02-08 01:25:42 UTC (rev 211851)
+++ trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm	2017-02-08 01:47:31 UTC (rev 211852)
@@ -34,6 +34,8 @@
 #import 
 #import 
 #import 
+#import 
+#import 
 
 SOFT_LINK_FRAMEWORK(UIKit)
 SOFT_LINK_CLASS(UIKit, UIColor)
@@ -76,7 +78,9 @@
 
 @end
 
-@implementation WebItemProviderPasteboard
+@implementation WebItemProviderPasteboard {
+RetainPtr _itemProviders;
+}
 
 + (instancetype)sharedInstance
 {
@@ -91,7 +95,7 @@
 - (instancetype)init
 {
 if (self = [super init]) {
-_itemProviders = [[NSArray alloc] init];
+_itemProviders = adoptNS([[NSArray alloc] init]);
 _changeCount = 0;
 _pendingOperationCount = 0;
 }
@@ -98,49 +102,65 @@
 return self;
 }
 

[webkit-changes] [211851] trunk/Tools

[ryanhaddad]

Title: [211851] trunk/Tools








Revision 211851
Author ryanhad...@apple.com
Date 2017-02-07 17:25:42 -0800 (Tue, 07 Feb 2017)


Log Message
Update flakiness dashboard configuration.
https://bugs.webkit.org/show_bug.cgi?id=167957

Reviewed by Alexey Proskuryakov.

* TestResultServer/static-dashboards/builders.jsonp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.jsonp




Diff

Modified: trunk/Tools/ChangeLog (211850 => 211851)

--- trunk/Tools/ChangeLog	2017-02-08 01:14:42 UTC (rev 211850)
+++ trunk/Tools/ChangeLog	2017-02-08 01:25:42 UTC (rev 211851)
@@ -1,5 +1,14 @@
 2017-02-07  Ryan Haddad  
 
+Update flakiness dashboard configuration.
+https://bugs.webkit.org/show_bug.cgi?id=167957
+
+Reviewed by Alexey Proskuryakov.
+
+* TestResultServer/static-dashboards/builders.jsonp:
+
+2017-02-07  Ryan Haddad  
+
 Replace a bot that has an incorrect configuration.
 https://bugs.webkit.org/show_bug.cgi?id=167747
 


Modified: trunk/Tools/TestResultServer/static-dashboards/builders.jsonp (211850 => 211851)

--- trunk/Tools/TestResultServer/static-dashboards/builders.jsonp	2017-02-08 01:14:42 UTC (rev 211850)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.jsonp	2017-02-08 01:25:42 UTC (rev 211851)
@@ -6,11 +6,11 @@
 "tests": {
 "layout-tests": {
 "builders": [
-"Apple El Capitan (Leaks)", 
 "Apple El Capitan Debug WK1 (Tests)", 
 "Apple El Capitan Debug WK2 (Tests)", 
 "Apple El Capitan Release WK1 (Tests)", 
 "Apple El Capitan Release WK2 (Tests)", 
+"Apple Sierra (Leaks)", 
 "Apple Sierra Debug WK1 (Tests)", 
 "Apple Sierra Debug WK2 (Tests)", 
 "Apple Sierra Release WK1 (Tests)", 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211850] tags/Safari-604.1.5.4/

[matthew_hanson]

Title: [211850] tags/Safari-604.1.5.4/








Revision 211850
Author matthew_han...@apple.com
Date 2017-02-07 17:14:42 -0800 (Tue, 07 Feb 2017)


Log Message
Tag Safari-604.1.5.4.

Added Paths

tags/Safari-604.1.5.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211849] trunk/Source/ThirdParty/libwebrtc

[achristensen]

Title: [211849] trunk/Source/ThirdParty/libwebrtc








Revision 211849
Author achristen...@apple.com
Date 2017-02-07 17:12:50 -0800 (Tue, 07 Feb 2017)


Log Message
Fix libwebrtcpcrtc target include path
https://bugs.webkit.org/show_bug.cgi?id=167971

Patch by Youenn Fablet  on 2017-02-07
Reviewed by Alex Christensen.

* Configurations/libwebrtcpcrtc.xcconfig:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (211848 => 211849)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 01:07:13 UTC (rev 211848)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 01:12:50 UTC (rev 211849)
@@ -1,5 +1,14 @@
 2017-02-07  Youenn Fablet  
 
+Fix libwebrtcpcrtc target include path
+https://bugs.webkit.org/show_bug.cgi?id=167971
+
+Reviewed by Alex Christensen.
+
+* Configurations/libwebrtcpcrtc.xcconfig:
+
+2017-02-07  Youenn Fablet  
+
 [WebRTC] usrsctp (libwebrtc third party library) is not compiling
 https://bugs.webkit.org/show_bug.cgi?id=167969
 


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig (211848 => 211849)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig	2017-02-08 01:07:13 UTC (rev 211848)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig	2017-02-08 01:12:50 UTC (rev 211849)
@@ -6,7 +6,8 @@
 GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
 COMBINE_HIDPI_IMAGES = NO;
 ENABLE_STRICT_OBJC_MSGSEND = YES;
-HEADER_SEARCH_PATHS = Source Source/third_party/jsoncpp/source/include Source/third_party/libsrtp/crypto/include Source/third_party/libsrtp/include Source/third_party/boringssl/src/include Source/third_party/libyuv/include Source/third_party/usrsctp/usrsctplib Source/third_party/usrsctp/usrsctplib/usrsctplib Source/webrtc/sdk/objc/Framework/Headers Source/webrtc/common_audio/signal_processing/include Source/webrtc/modules/audio_coding/codecs/isac/main/include Source/third_party/opus/src/celt Source/third_party/opus/src/include Source/third_party/opus/src/src Source/webrtc/modules/audio_device/mac;
+HEADER_SEARCH_PATHS = Source/ Source/third_party/libyuv/include/ Source/third_party/libsrtp/include/ Source/third_party/libsrtp/config/ Source/third_party/boringssl/src/include/ Source/third_party/libsrtp/ Source/third_party/libsrtp/crypto/include/
+
 INSTALL_PATH = /usr/local/lib;
 PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/libwebrtc;
 USE_HEADERMAP = NO;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211848] trunk/Source/ThirdParty/libwebrtc

[achristensen]

Title: [211848] trunk/Source/ThirdParty/libwebrtc








Revision 211848
Author achristen...@apple.com
Date 2017-02-07 17:07:13 -0800 (Tue, 07 Feb 2017)


Log Message
[WebRTC] usrsctp (libwebrtc third party library) is not compiling
https://bugs.webkit.org/show_bug.cgi?id=167969

Patch by Youenn Fablet  on 2017-02-07
Reviewed by Alex Christensen.

Also removing .gitignore files in libwebrtc directory.

* Source/.gitignore: Removed.
* Source/third_party/boringssl/src/.gitignore: Removed.
* Source/third_party/gflags/src/.gitignore: Removed.
* Source/third_party/jsoncpp/source/.gitignore: Removed.
* Source/third_party/libyuv/.gitignore: Removed.
* Source/third_party/protobuf/.gitignore: Removed.
* Source/third_party/protobuf/csharp/.gitignore: Removed.
* Source/third_party/protobuf/ruby/.gitignore: Removed.
* Source/third_party/usrsctp/usrsctplib/.gitignore: Removed.
* Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:
(sctp_process_cookie_existing):
* Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_output.c:
* Source/tools/.gitignore: Removed.
* Source/webrtc/.gitignore: Removed.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c
trunk/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_output.c


Removed Paths

trunk/Source/ThirdParty/libwebrtc/Source/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/gflags/src/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/jsoncpp/source/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/libyuv/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/opus/src/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/csharp/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/ruby/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/tools/.gitignore
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/.gitignore




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (211847 => 211848)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 01:04:21 UTC (rev 211847)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 01:07:13 UTC (rev 211848)
@@ -1,3 +1,27 @@
+2017-02-07  Youenn Fablet  
+
+[WebRTC] usrsctp (libwebrtc third party library) is not compiling
+https://bugs.webkit.org/show_bug.cgi?id=167969
+
+Reviewed by Alex Christensen.
+
+Also removing .gitignore files in libwebrtc directory.
+
+* Source/.gitignore: Removed.
+* Source/third_party/boringssl/src/.gitignore: Removed.
+* Source/third_party/gflags/src/.gitignore: Removed.
+* Source/third_party/jsoncpp/source/.gitignore: Removed.
+* Source/third_party/libyuv/.gitignore: Removed.
+* Source/third_party/protobuf/.gitignore: Removed.
+* Source/third_party/protobuf/csharp/.gitignore: Removed.
+* Source/third_party/protobuf/ruby/.gitignore: Removed.
+* Source/third_party/usrsctp/usrsctplib/.gitignore: Removed.
+* Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:
+(sctp_process_cookie_existing):
+* Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_output.c:
+* Source/tools/.gitignore: Removed.
+* Source/webrtc/.gitignore: Removed.
+
 2017-02-07  Alex Christensen  
 
 Move webrtc/pc to own Xcode target


Deleted: trunk/Source/ThirdParty/libwebrtc/Source/.gitignore (211847 => 211848)

--- trunk/Source/ThirdParty/libwebrtc/Source/.gitignore	2017-02-08 01:04:21 UTC (rev 211847)
+++ trunk/Source/ThirdParty/libwebrtc/Source/.gitignore	2017-02-08 01:07:13 UTC (rev 211848)
@@ -1,178 +0,0 @@
-*.DS_Store
-*.Makefile
-*.host.mk
-*.ncb
-*.ninja
-*.props
-*.pyc
-*.rules
-*.scons
-*.sdf
-*.sln
-*.suo
-*.target.mk
-*.targets
-*.user
-*.vcproj
-*.vcxproj
-*.vcxproj.filters
-*.vpj
-*.vpw
-*.vpwhistu
-*.vtg
-*.xcodeproj
-*.xcworkspace
-*_proto.xml
-*_proto_cpp.xml
-*~
-.*.sw?
-.classpath
-.cproject
-.gdb_history
-.gdbinit
-.landmines
-.metadata
-.project
-.pydevproject
-.settings
-.sw?
-/Makefile
-/base
-/build
-/buildtools
-/chromium/.gclient.tmp
-/chromium/.gclient.tmp_entries
-/chromium/.last_sync_chromium
-/chromium/_bad_scm
-/chromium/src
-/gyp-mac-tool
-/links
-/links.db
-/mojo
-/out
-/resources/**/*.aecdump
-/resources/**/*.bin
-/resources/**/*.byte
-/resources/**/*.chn
-/resources/**/*.dat
-/resources/**/*.frames
-/resources/**/*.gai
-/resources/**/*.jpg
-/resources/**/*.pcap
-/resources/**/*.pcm
-/resources/**/*.rtp
-/resources/**/*.rtpdump
-/resources/**/*.rx

[webkit-changes] [211847] trunk/Source/ThirdParty/libwebrtc

[achristensen]

Title: [211847] trunk/Source/ThirdParty/libwebrtc








Revision 211847
Author achristen...@apple.com
Date 2017-02-07 17:04:21 -0800 (Tue, 07 Feb 2017)


Log Message
Move webrtc/pc to own Xcode target
https://bugs.webkit.org/show_bug.cgi?id=167970

Reviewed by Youenn Fablet.

It needs to include different directories than the rest of libwebrtc.
Also moved some target names so liblibsrtp.a is changed to libsrtp.a, etc.

* Configurations/libwebrtcpcrtc.xcconfig: Added.
* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj


Added Paths

trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (211846 => 211847)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 01:04:13 UTC (rev 211846)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 01:04:21 UTC (rev 211847)
@@ -1,5 +1,18 @@
 2017-02-07  Alex Christensen  
 
+Move webrtc/pc to own Xcode target
+https://bugs.webkit.org/show_bug.cgi?id=167970
+
+Reviewed by Youenn Fablet.
+
+It needs to include different directories than the rest of libwebrtc.
+Also moved some target names so liblibsrtp.a is changed to libsrtp.a, etc.
+
+* Configurations/libwebrtcpcrtc.xcconfig: Added.
+* libwebrtc.xcodeproj/project.pbxproj:
+
+2017-02-07  Alex Christensen  
+
 [libwebrtc] Move libsrtp and libyuv to own Xcode targets
 https://bugs.webkit.org/show_bug.cgi?id=167966
 


Added: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig (0 => 211847)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig	(rev 0)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtcpcrtc.xcconfig	2017-02-08 01:04:21 UTC (rev 211847)
@@ -0,0 +1,16 @@
+PRODUCT_NAME = webrtcpcrtc;
+
+CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INT_CONVERSION = YES;
+GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
+COMBINE_HIDPI_IMAGES = NO;
+ENABLE_STRICT_OBJC_MSGSEND = YES;
+HEADER_SEARCH_PATHS = Source Source/third_party/jsoncpp/source/include Source/third_party/libsrtp/crypto/include Source/third_party/libsrtp/include Source/third_party/boringssl/src/include Source/third_party/libyuv/include Source/third_party/usrsctp/usrsctplib Source/third_party/usrsctp/usrsctplib/usrsctplib Source/webrtc/sdk/objc/Framework/Headers Source/webrtc/common_audio/signal_processing/include Source/webrtc/modules/audio_coding/codecs/isac/main/include Source/third_party/opus/src/celt Source/third_party/opus/src/include Source/third_party/opus/src/src Source/webrtc/modules/audio_device/mac;
+INSTALL_PATH = /usr/local/lib;
+PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/libwebrtc;
+USE_HEADERMAP = NO;
+WARNING_CFLAGS = -Wno-exit-time-destructors -Wno-objc-property-no-attribute -Wno-objc-missing-super-calls;
+
+// FIXME: WEBRTC_CODEC_G722 was in project.json
+GCC_PREPROCESSOR_DEFINITIONS = WEBRTC_POSIX WEBRTC_MAC SSL_USE_OPENSSL FEATURE_ENABLE_SSL HAVE_SRTP=1 HAVE_OPENSSL_SSL_H=1 SCTP_PROCESS_LEVEL_LOCKS SCTP_SIMPLE_ALLOCATOR SCTP_USE_OPENSSL_SHA1 __Userspace__ HAVE_SA_LEN HAVE_SCONN_LEN __APPLE_USE_RFC_2292 __Userspace_os_Darwin NON_WINDOWS_DEFINE HAVE_WEBRTC_VIDEO HAVE_WEBRTC_VOICE WEBRTC_INTELLIGIBILITY_ENHANCER=0 WEBRTC_APM_DEBUG_DUMP=0 WEBRTC_NS_FLOAT WEBRTC_CODEC_ILBC WEBRTC_CODEC_OPUS WEBRTC_CODEC_ISAC WEBRTC_CODEC_RED RTC_DISABLE_VP9 RTC_DISABLE_VP8 HAVE_STDINT_H HAVE_STDLIB_H HAVE_UINT64_T OPENSSL HAVE_CONFIG_H WEBRTC_WEBKIT_BUILD HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE;


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (211846 => 211847)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-08 01:04:13 UTC (rev 211846)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-08 01:04:21 UTC (rev 211847)
@@ -85,6 +85,27 @@
 		5C0885331E4A99D200403995 /* rdb.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C0885211E4A99D200403995 /* rdb.h */; };
 		5C0885341E4A99D200403995 /* rdbx.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C0885221E4A99D200403995 /* rdbx.h */; };
 		5C0885351E4A99D200403995 /* stat.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C0885231E4A99D200403995 /* stat.h */; };
+		5C088C0E1E4AA44400403995 /* audiomonitor.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5C63FA361E41761F002CA531 /* audiomonitor.cc */; };
+		5C088C0F1E4AA44400403995 /* audiomonitor.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C63FA371E41761F002CA531 /* audiomonitor.h */; };
+		5C088C101E4AA44400403995 /* bundlefilter.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5C63FA3A1E41761F002CA531 /* bundlefilter.cc */; };
+		5C088C111E4AA44400403995 /* bundlefilter.h in Headers */ = 

[webkit-changes] [211846] trunk/Tools

[ryanhaddad]

Title: [211846] trunk/Tools








Revision 211846
Author ryanhad...@apple.com
Date 2017-02-07 17:04:13 -0800 (Tue, 07 Feb 2017)


Log Message
Replace a bot that has an incorrect configuration.
https://bugs.webkit.org/show_bug.cgi?id=167747

Rubber-stamped by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (211845 => 211846)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2017-02-08 00:58:02 UTC (rev 211845)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2017-02-08 01:04:13 UTC (rev 211846)
@@ -25,7 +25,6 @@
 { "name": "bot121", "platform": "mac-sierra" },
 { "name": "bot122", "platform": "mac-sierra" },
 { "name": "bot141", "platform": "mac-sierra" },
-{ "name": "bot143", "platform": "mac-sierra" },
 { "name": "bot155", "platform": "mac-sierra" },
 { "name": "bot157", "platform": "mac-sierra" },
 { "name": "bot160", "platform": "mac-sierra" },
@@ -33,6 +32,7 @@
 { "name": "bot186", "platform": "mac-sierra" },
 { "name": "bot187", "platform": "mac-sierra" },
 { "name": "bot199", "platform": "mac-sierra" },
+{ "name": "bot202", "platform": "mac-sierra" },
 { "name": "bot219", "platform": "mac-sierra" },
 { "name": "bot439", "platform": "mac-sierra" },
 { "name": "bot443", "platform": "mac-sierra" },
@@ -94,7 +94,7 @@
 { "name": "Apple Sierra Debug WK2 (Tests)", "type": "TestAllButJSC", "builddir": "sierra-debug-tests-wk2",
   "platform": "mac-sierra", "configuration": "debug", "architectures": ["x86_64"],
   "additionalArguments": ["--no-retry-failures"],
-  "slavenames": ["bot143", "bot219"]
+  "slavenames": ["bot202", "bot219"]
 },
 { "name": "Apple Sierra Release (Build)", "type": "Build", "builddir": "sierra-release",
   "platform": "mac-sierra", "configuration": "release", "architectures": ["x86_64"],


Modified: trunk/Tools/ChangeLog (211845 => 211846)

--- trunk/Tools/ChangeLog	2017-02-08 00:58:02 UTC (rev 211845)
+++ trunk/Tools/ChangeLog	2017-02-08 01:04:13 UTC (rev 211846)
@@ -1,3 +1,12 @@
+2017-02-07  Ryan Haddad  
+
+Replace a bot that has an incorrect configuration.
+https://bugs.webkit.org/show_bug.cgi?id=167747
+
+Rubber-stamped by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2017-02-07  Myles C. Maxfield  
 
 [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211845] trunk

[rniwa]

Title: [211845] trunk








Revision 211845
Author rn...@webkit.org
Date 2017-02-07 16:58:02 -0800 (Tue, 07 Feb 2017)


Log Message
WebContent process repeatedly jetsams on BuzzFeed's Another Round page
https://bugs.webkit.org/show_bug.cgi?id=167830


Reviewed by Simon Fraser.

Source/WebCore:

The jetsams on https://www.buzzfeed.com/anotherround were caused by WebKit creating the backing store
for every iframe's layer on the page regardless of whether they're in the viewport or not.

This was caused by GraphicsLayerCA's setVisibleAndCoverageRects not setting CoverageRectChanged on
m_uncommittedChanges on the very first call. Fixed the bug by initializing m_uncommittedChanges
to always have CoverageRectChanged so that the coverage rect would get updated properly.

Unfortunately, no new tests since somehow the backing store doesn't get created inside the test runner.

* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA):

LayoutTests:

Rebaseline the test now that some overlay repaints are avoided properly by updating the overlay coverage rects.

* platform/ios-simulator-wk2/pageoverlay/overlay-remove-reinsert-view-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/pageoverlay/overlay-remove-reinsert-view-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h




Diff

Modified: trunk/LayoutTests/ChangeLog (211844 => 211845)

--- trunk/LayoutTests/ChangeLog	2017-02-08 00:47:20 UTC (rev 211844)
+++ trunk/LayoutTests/ChangeLog	2017-02-08 00:58:02 UTC (rev 211845)
@@ -1,3 +1,15 @@
+2017-02-07  Ryosuke Niwa  
+
+WebContent process repeatedly jetsams on BuzzFeed's Another Round page
+https://bugs.webkit.org/show_bug.cgi?id=167830
+
+
+Reviewed by Simon Fraser.
+
+Rebaseline the test now that some overlay repaints are avoided properly by updating the overlay coverage rects.
+
+* platform/ios-simulator-wk2/pageoverlay/overlay-remove-reinsert-view-expected.txt:
+
 2017-02-07  Ryan Haddad  
 
 Mark mathml/opentype/large-operators-displaystyle-dynamic.html as flaky on Sierra WK2 Release.


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/pageoverlay/overlay-remove-reinsert-view-expected.txt (211844 => 211845)

--- trunk/LayoutTests/platform/ios-simulator-wk2/pageoverlay/overlay-remove-reinsert-view-expected.txt	2017-02-08 00:47:20 UTC (rev 211844)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/pageoverlay/overlay-remove-reinsert-view-expected.txt	2017-02-08 00:58:02 UTC (rev 211845)
@@ -2,8 +2,6 @@
 CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (512, 0, 512, 512)
 CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 512, 512, 512)
 CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (512, 512, 512, 512)
-CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 0, 800, 600)
-CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 0, 800, 600)
 Initial layers
 
 View-relative:


Modified: trunk/Source/WebCore/ChangeLog (211844 => 211845)

--- trunk/Source/WebCore/ChangeLog	2017-02-08 00:47:20 UTC (rev 211844)
+++ trunk/Source/WebCore/ChangeLog	2017-02-08 00:58:02 UTC (rev 211845)
@@ -1,3 +1,23 @@
+2017-02-06  Ryosuke Niwa  
+
+WebContent process repeatedly jetsams on BuzzFeed's Another Round page
+https://bugs.webkit.org/show_bug.cgi?id=167830
+
+
+Reviewed by Simon Fraser.
+
+The jetsams on https://www.buzzfeed.com/anotherround were caused by WebKit creating the backing store
+for every iframe's layer on the page regardless of whether they're in the viewport or not.
+
+This was caused by GraphicsLayerCA's setVisibleAndCoverageRects not setting CoverageRectChanged on
+m_uncommittedChanges on the very first call. Fixed the bug by initializing m_uncommittedChanges
+to always have CoverageRectChanged so that the coverage rect would get updated properly.
+
+Unfortunately, no new tests since somehow the backing store doesn't get created inside the test runner.
+
+* platform/graphics/ca/GraphicsLayerCA.h:
+(WebCore::GraphicsLayerCA):
+
 2017-02-07  Youenn Fablet  
 
 [WebRTC] LibWebRTCEndpoint should not own objects that should be destroyed on the main thread


Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (211844 => 211845)

--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h	2017-02-08 00:47:20 UTC (rev 211844)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h	2017-02-08 00:58:02 UTC (rev 211845)
@@ -587,7 +587,7 @@
 
 FloatSize m_pixelAlignmentOffset;
 
-LayerChangeFlags m_uncommittedChanges { 0 };
+LayerChangeFlags m_uncommittedChanges { CoverageRectChanged };
 bool m_isCommittingChanges { false };
 };
 

[webkit-changes] [211844] trunk/Source/ThirdParty/libwebrtc

[achristensen]

Title: [211844] trunk/Source/ThirdParty/libwebrtc








Revision 211844
Author achristen...@apple.com
Date 2017-02-07 16:47:20 -0800 (Tue, 07 Feb 2017)


Log Message
[libwebrtc] Move libsrtp and libyuv to own Xcode targets
https://bugs.webkit.org/show_bug.cgi?id=167966

Reviewed by Youenn Fablet.

* Configurations/libsrtp.xcconfig: Added.
* Configurations/libyuv.xcconfig: Added.
* Configurations/usrsctp.xcconfig:
* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj


Added Paths

trunk/Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (211843 => 211844)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 00:46:32 UTC (rev 211843)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-08 00:47:20 UTC (rev 211844)
@@ -1,5 +1,17 @@
 2017-02-07  Alex Christensen  
 
+[libwebrtc] Move libsrtp and libyuv to own Xcode targets
+https://bugs.webkit.org/show_bug.cgi?id=167966
+
+Reviewed by Youenn Fablet.
+
+* Configurations/libsrtp.xcconfig: Added.
+* Configurations/libyuv.xcconfig: Added.
+* Configurations/usrsctp.xcconfig:
+* libwebrtc.xcodeproj/project.pbxproj:
+
+2017-02-07  Alex Christensen  
+
 Fix libwebrtc build after r211817
 https://bugs.webkit.org/show_bug.cgi?id=167944
 


Added: trunk/Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig (0 => 211844)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig	(rev 0)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig	2017-02-08 00:47:20 UTC (rev 211844)
@@ -0,0 +1,15 @@
+PRODUCT_NAME = srtp;
+
+CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INT_CONVERSION = YES;
+GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
+COMBINE_HIDPI_IMAGES = NO;
+ENABLE_STRICT_OBJC_MSGSEND = YES;
+
+HEADER_SEARCH_PATHS = Source/third_party/libsrtp/include Source/third_party/libsrtp/config Source/third_party/boringssl/src/include Source/third_party/libsrtp Source/third_party/libsrtp/crypto/include;
+INSTALL_PATH = /usr/local/lib;
+PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/libwebrtc;
+USE_HEADERMAP = NO;
+WARNING_CFLAGS = -Wno-exit-time-destructors -Wno-implicit-function-declaration -Wno-incompatible-pointer-types -Wno-deprecated-declarations;
+GCC_PREPROCESSOR_DEFINITIONS = V8_DEPRECATION_WARNINGS ENABLE_NOTIFICATIONS ENABLE_PLUGINS=1 ENABLE_PDF=1 ENABLE_PRINTING=1 ENABLE_BASIC_PRINTING=1 ENABLE_PRINT_PREVIEW=1 ENABLE_SPELLCHECK=1 USE_BROWSER_SPELLCHECKER=1 NO_TCMALLOC USE_EXTERNAL_POPUP_MENU=1 ENABLE_WEBRTC=1 ENABLE_EXTENSIONS=1 ENABLE_TASK_MANAGER=1 ENABLE_THEMES=1 ENABLE_SESSION_SERVICE=1 ENABLE_SUPERVISED_USERS=1 FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL CHROMIUM_BUILD ENABLE_MEDIA_ROUTER=1 FIELDTRIAL_TESTING_ENABLED CR_CLANG_REVISION=284979-1 CR_XCODE_VERSION=0820 __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 _DEBUG DYNAMIC_ANNOTATIONS_ENABLED=1 WTF_USE_DYNAMIC_ANNOTATIONS=1 PACKAGE_STRING="\"libsrtp2 2.0.0-pre\"" PACKAGE_VERSION="\"2.0.0-pre\"" HAVE_CONFIG_H OPENSSL HAVE_STDLIB_H HAVE_STRING_H HAVE_STDINT_H HAVE_INTTYPES_H HAVE_INT16_T HAVE_INT32_T HAVE_INT8_T HAVE_UINT16_T HAVE_UINT32_T HAVE_UINT64_T HAVE_UINT8_T HAVE_ARPA_INET_H HAVE_NETINET_
 IN_H HAVE_SYS_TYPES_H HAVE_UNISTD_H;


Added: trunk/Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig (0 => 211844)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig	(rev 0)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig	2017-02-08 00:47:20 UTC (rev 211844)
@@ -0,0 +1,13 @@
+PRODUCT_NAME = yuv;
+
+CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INT_CONVERSION = YES;
+GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
+COMBINE_HIDPI_IMAGES = NO;
+ENABLE_STRICT_OBJC_MSGSEND = YES;
+HEADER_SEARCH_PATHS = Source/third_party/libyuv/include;
+INSTALL_PATH = /usr/local/lib;
+PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/libwebrtc;
+USE_HEADERMAP = NO;
+WARNING_CFLAGS = -Wno-exit-time-destructors -Wno-implicit-function-declaration -Wno-incompatible-pointer-types -Wno-deprecated-declarations;


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig (211843 => 211844)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig	2017-02-08 00:46:32 UTC (rev 211843)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig	2017-02-08 00:47:20 UTC (rev 211844)
@@ -10,6 +10,6 @@
 INSTALL_PATH = /usr/local/lib;
 PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/libwebrtc;
 USE_HEADERMAP = NO;
-WARNING_CFLAGS = -Wno-exit-time-destructors 

[webkit-changes] [211843] trunk/LayoutTests

[ryanhaddad]

Title: [211843] trunk/LayoutTests








Revision 211843
Author ryanhad...@apple.com
Date 2017-02-07 16:46:32 -0800 (Tue, 07 Feb 2017)


Log Message
Mark mathml/opentype/large-operators-displaystyle-dynamic.html as flaky on Sierra WK2 Release.
https://bugs.webkit.org/show_bug.cgi?id=167206

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (211842 => 211843)

--- trunk/LayoutTests/ChangeLog	2017-02-08 00:21:52 UTC (rev 211842)
+++ trunk/LayoutTests/ChangeLog	2017-02-08 00:46:32 UTC (rev 211843)
@@ -1,5 +1,14 @@
 2017-02-07  Ryan Haddad  
 
+Mark mathml/opentype/large-operators-displaystyle-dynamic.html as flaky on Sierra WK2 Release.
+https://bugs.webkit.org/show_bug.cgi?id=167206
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2017-02-07  Ryan Haddad  
+
 Skip http/tests/security/bypassing-cors-checks-for-extension-urls.html on ios-simulator.
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (211842 => 211843)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-02-08 00:21:52 UTC (rev 211842)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-02-08 00:46:32 UTC (rev 211843)
@@ -610,3 +610,5 @@
 webkit.org/b/161887 [ ElCapitan ] swipe/main-frame-pinning-requirement.html [ Pass Timeout ]
 
 webkit.org/b/167653 http/tests/contentextensions/block-everything-unless-domain.html [ Pass Timeout ]
+
+webkit.org/b/167206 [ Sierra Release ] mathml/opentype/large-operators-displaystyle-dynamic.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211842] trunk/LayoutTests

[ryanhaddad]

Title: [211842] trunk/LayoutTests








Revision 211842
Author ryanhad...@apple.com
Date 2017-02-07 16:21:52 -0800 (Tue, 07 Feb 2017)


Log Message
Skip http/tests/security/bypassing-cors-checks-for-extension-urls.html on ios-simulator.

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (211841 => 211842)

--- trunk/LayoutTests/ChangeLog	2017-02-08 00:07:02 UTC (rev 211841)
+++ trunk/LayoutTests/ChangeLog	2017-02-08 00:21:52 UTC (rev 211842)
@@ -1,3 +1,11 @@
+2017-02-07  Ryan Haddad  
+
+Skip http/tests/security/bypassing-cors-checks-for-extension-urls.html on ios-simulator.
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
 2017-02-07  Devin Rousso  
 
 Web Inspector: gradient editor should allow switching the units of the 'angle' parameter


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (211841 => 211842)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-02-08 00:07:02 UTC (rev 211841)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-02-08 00:21:52 UTC (rev 211842)
@@ -380,6 +380,9 @@
 fast/scrolling/rtl-scrollbars-text-selection-scrolled.html [ Skip ]
 fast/scrolling/rtl-scrollbars-text-selection.html [ Skip ]
 
+# This is specific to extensions on macOS
+webkit.org/b/167795 http/tests/security/bypassing-cors-checks-for-extension-urls.html [ Skip ]
+
 ###
 # Known failures
 ##






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211841] trunk/Source/WebKit2

[bfulgham]

Title: [211841] trunk/Source/WebKit2








Revision 211841
Author bfulg...@apple.com
Date 2017-02-07 16:07:02 -0800 (Tue, 07 Feb 2017)


Log Message
Correct initialization of Resource Load Statistics for use in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=167960

Reviewed by Andy Estes.

WebKit2 starts up with different process configuration settings depending on the type of
WebView and client application. This led to two problems:
1. Registering the shared resource load observer did not start at UIProcess launch. Instead, it
   was lazily initialized as messages from the various WebProcess started getting received. This
   is too slow for WebKitTestRunner, which needs this object to be initialized right at launch
   time.
   
   A new 'registerSharedResourceLoadObserver' method was needed, so that the WebProcess can ask
   the WebsiteDataStore to register a resource load observer during platform initialization.

2. Some WebView uses do not enable WebsiteDataStore, and should not activate a resource load
   statistics observer.

* UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::registerSharedResourceLoadObserver): Added.
* UIProcess/API/APIWebsiteDataStore.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize): If the web process is using a WebsiteDataStore,
register a resource load observer.
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Added.
* UIProcess/WebResourceLoadStatisticsStore.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver): Added.
* UIProcess/WebsiteData/WebsiteDataStore.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp
trunk/Source/WebKit2/UIProcess/API/APIWebsiteDataStore.h
trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp
trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.h
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (211840 => 211841)

--- trunk/Source/WebKit2/ChangeLog	2017-02-07 22:31:48 UTC (rev 211840)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-08 00:07:02 UTC (rev 211841)
@@ -1,3 +1,36 @@
+2017-02-07  Brent Fulgham  
+
+Correct initialization of Resource Load Statistics for use in WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=167960
+
+Reviewed by Andy Estes.
+
+WebKit2 starts up with different process configuration settings depending on the type of
+WebView and client application. This led to two problems:
+1. Registering the shared resource load observer did not start at UIProcess launch. Instead, it
+   was lazily initialized as messages from the various WebProcess started getting received. This
+   is too slow for WebKitTestRunner, which needs this object to be initialized right at launch
+   time.
+   
+   A new 'registerSharedResourceLoadObserver' method was needed, so that the WebProcess can ask
+   the WebsiteDataStore to register a resource load observer during platform initialization.
+
+2. Some WebView uses do not enable WebsiteDataStore, and should not activate a resource load
+   statistics observer.
+
+* UIProcess/API/APIWebsiteDataStore.cpp:
+(API::WebsiteDataStore::registerSharedResourceLoadObserver): Added.
+* UIProcess/API/APIWebsiteDataStore.h:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::platformInitialize): If the web process is using a WebsiteDataStore,
+register a resource load observer.
+* UIProcess/WebResourceLoadStatisticsStore.cpp:
+(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Added.
+* UIProcess/WebResourceLoadStatisticsStore.h:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver): Added.
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+
 2017-02-07  Anders Carlsson  
 
 REGRESSION (r211819): [ios-simulator] API tests Coding.WKWebView and Coding.WKWebView_SameConfiguration crashing


Modified: trunk/Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp (211840 => 211841)

--- trunk/Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp	2017-02-07 22:31:48 UTC (rev 211840)
+++ trunk/Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp	2017-02-08 00:07:02 UTC (rev 211841)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014, 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2014-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, 

[webkit-changes] [211840] trunk

[commit-queue]

Title: [211840] trunk








Revision 211840
Author commit-qu...@webkit.org
Date 2017-02-07 14:31:48 -0800 (Tue, 07 Feb 2017)


Log Message
Web Inspector: gradient editor should allow switching the units of the 'angle' parameter
https://bugs.webkit.org/show_bug.cgi?id=166938

Patch by Devin Rousso  on 2017-02-07
Reviewed by Brian Burg.

Source/WebInspectorUI:

* UserInterface/Test.html:
Add WebInspector.Gradient for new model object tests.

* UserInterface/Models/Gradient.js:
(WebInspector.Gradient.fromString):
(WebInspector.LinearGradient):
(WebInspector.LinearGradient.fromComponents):
(WebInspector.LinearGradient.prototype.set angleValue):
(WebInspector.LinearGradient.prototype.get angleValue):
(WebInspector.LinearGradient.prototype.set angleUnits):
(WebInspector.LinearGradient.prototype.get angleUnits):
(WebInspector.LinearGradient.prototype.copy):
(WebInspector.LinearGradient.prototype.toString):
(WebInspector.LinearGradient.prototype._angleValueForUnits):
Rework part of WebInspector.LinearGradient to support units other than "deg".

* UserInterface/Views/GradientEditor.css:
(.gradient-editor > .gradient-angle > input[type="range"]):
(.gradient-editor > .gradient-angle > input[type="number"]):

* UserInterface/Views/GradientEditor.js:
(WebInspector.GradientEditor):
(WebInspector.GradientEditor.prototype.set gradient):
(WebInspector.GradientEditor.prototype._gradientTypeChanged):
(WebInspector.GradientEditor.prototype._angleValueChanged):
(WebInspector.GradientEditor.prototype._angleUnitsChanged):
(WebInspector.GradientEditor.prototype._angleChanged): Deleted.
Add  for each unit type that will change the units of the gradient.

LayoutTests:

* inspector/model/gradient-expected.txt: Added.
* inspector/model/gradient.html: Added.
New tests for WebInspector.Gradient.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/Gradient.js
trunk/Source/WebInspectorUI/UserInterface/Test.html
trunk/Source/WebInspectorUI/UserInterface/Views/GradientEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/GradientEditor.js


Added Paths

trunk/LayoutTests/inspector/model/gradient-expected.txt
trunk/LayoutTests/inspector/model/gradient.html




Diff

Modified: trunk/LayoutTests/ChangeLog (211839 => 211840)

--- trunk/LayoutTests/ChangeLog	2017-02-07 22:29:57 UTC (rev 211839)
+++ trunk/LayoutTests/ChangeLog	2017-02-07 22:31:48 UTC (rev 211840)
@@ -1,3 +1,14 @@
+2017-02-07  Devin Rousso  
+
+Web Inspector: gradient editor should allow switching the units of the 'angle' parameter
+https://bugs.webkit.org/show_bug.cgi?id=166938
+
+Reviewed by Brian Burg.
+
+* inspector/model/gradient-expected.txt: Added.
+* inspector/model/gradient.html: Added.
+New tests for WebInspector.Gradient.
+
 2017-02-07  Ryan Haddad  
 
 Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.


Added: trunk/LayoutTests/inspector/model/gradient-expected.txt (0 => 211840)

--- trunk/LayoutTests/inspector/model/gradient-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/model/gradient-expected.txt	2017-02-07 22:31:48 UTC (rev 211840)
@@ -0,0 +1,71 @@
+Tests for the WebInspector.Gradient model object.
+
+
+== Running test suite: WebInspector.Gradient
+-- Running test case: WebInspector.Gradient.fromString
+PASS: 'linear-gradient(red, blue)' is valid
+PASS: 'linear-gradient(red, blue)' is the expected subclass 'LinearGradient'
+PASS: 'linear-gradient(0deg, red, blue)' is valid
+PASS: 'linear-gradient(0deg, red, blue)' is the expected subclass 'LinearGradient'
+PASS: 'linear-gradient(to top, red, blue)' is valid
+PASS: 'linear-gradient(to top, red, blue)' is the expected subclass 'LinearGradient'
+PASS: 'linear-gradient(to top, red, green 50%, blue)' is valid
+PASS: 'linear-gradient(to top, red, green 50%, blue)' is the expected subclass 'LinearGradient'
+PASS: 'repeating-linear-gradient(0deg, red, blue)' is valid
+PASS: 'repeating-linear-gradient(0deg, red, blue)' is the expected subclass 'LinearGradient'
+PASS: 'radial-gradient(red, blue)' is valid
+PASS: 'radial-gradient(red, blue)' is the expected subclass 'RadialGradient'
+PASS: 'radial-gradient(0deg, red, blue)' is valid
+PASS: 'radial-gradient(0deg, red, blue)' is the expected subclass 'RadialGradient'
+PASS: 'radial-gradient(ellipse, red, blue)' is valid
+PASS: 'radial-gradient(ellipse, red, blue)' is the expected subclass 'RadialGradient'
+PASS: 'radial-gradient(ellipse, red, green 50%, blue)' is valid
+PASS: 'radial-gradient(ellipse, red, green 50%, blue)' is the expected subclass 'RadialGradient'
+PASS: 'repeating-radial-gradient(red, blue)' is valid
+PASS: 'repeating-radial-gradient(red, blue)' is the expected subclass 'RadialGradient'
+
+PASS: 'bad' is not valid
+PASS: 'linear-gradient' is not valid

[webkit-changes] [211839] trunk/LayoutTests

[ryanhaddad]

Title: [211839] trunk/LayoutTests








Revision 211839
Author ryanhad...@apple.com
Date 2017-02-07 14:29:57 -0800 (Tue, 07 Feb 2017)


Log Message
Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167275

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (211838 => 211839)

--- trunk/LayoutTests/ChangeLog	2017-02-07 22:09:03 UTC (rev 211838)
+++ trunk/LayoutTests/ChangeLog	2017-02-07 22:29:57 UTC (rev 211839)
@@ -1,3 +1,12 @@
+2017-02-07  Ryan Haddad  
+
+Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=167275
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2017-02-07  Youenn Fablet  
 
 [WebRTC] LibWebRTCEndpoint should not own objects that should be destroyed on the main thread


Modified: trunk/LayoutTests/platform/mac/TestExpectations (211838 => 211839)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-02-07 22:09:03 UTC (rev 211838)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-02-07 22:29:57 UTC (rev 211839)
@@ -1473,6 +1473,8 @@
 
 webkit.org/b/167263 media/modern-media-controls/media-controller/media-controller-auto-hide.html [ Pass Failure ]
 
+webkit.org/b/167275 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
+
 webkit.org/b/167347 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ]
 
 webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211838] trunk/Source/WebKit2

[andersca]

Title: [211838] trunk/Source/WebKit2








Revision 211838
Author ander...@apple.com
Date 2017-02-07 14:09:03 -0800 (Tue, 07 Feb 2017)


Log Message
REGRESSION (r211819): [ios-simulator] API tests Coding.WKWebView and Coding.WKWebView_SameConfiguration crashing
https://bugs.webkit.org/show_bug.cgi?id=167947

Reviewed by Tim Horton.

* Platform/spi/ios/UIKitSPI.h:
Add SPI declaration.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
Make sure to call setDrawsBackground here.

(-[WKWebView _populateArchivedSubviews:]):
We don't want to archive the scroll view and the fixed overlay view.

(-[WKWebView setOpaque:]):
Return early if this is called before we have a page (like from -[UIView initWithCoder:]).

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (211837 => 211838)

--- trunk/Source/WebKit2/ChangeLog	2017-02-07 21:56:42 UTC (rev 211837)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-07 22:09:03 UTC (rev 211838)
@@ -1,3 +1,23 @@
+2017-02-07  Anders Carlsson  
+
+REGRESSION (r211819): [ios-simulator] API tests Coding.WKWebView and Coding.WKWebView_SameConfiguration crashing
+https://bugs.webkit.org/show_bug.cgi?id=167947
+
+Reviewed by Tim Horton.
+
+* Platform/spi/ios/UIKitSPI.h:
+Add SPI declaration.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _initializeWithConfiguration:]):
+Make sure to call setDrawsBackground here.
+
+(-[WKWebView _populateArchivedSubviews:]):
+We don't want to archive the scroll view and the fixed overlay view.
+
+(-[WKWebView setOpaque:]):
+Return early if this is called before we have a page (like from -[UIView initWithCoder:]).
+
 2017-02-07  Alex Christensen  
 
 Revert r166597


Modified: trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h (211837 => 211838)

--- trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h	2017-02-07 21:56:42 UTC (rev 211837)
+++ trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h	2017-02-07 22:09:03 UTC (rev 211838)
@@ -448,6 +448,7 @@
 - (void)setFrameOrigin:(CGPoint)origin;
 - (void)setSize:(CGSize)size;
 @property (nonatomic, assign, setter=_setBackdropMaskViewFlags:) NSInteger _backdropMaskViewFlags;
+- (void)_populateArchivedSubviews:(NSMutableSet *)encodedViews;
 @end
 
 @interface UIWebSelectionView : UIView


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (211837 => 211838)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2017-02-07 21:56:42 UTC (rev 211837)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2017-02-07 22:09:03 UTC (rev 211838)
@@ -503,6 +503,7 @@
 
 _page = [_contentView page];
 _page->setDeviceOrientation(deviceOrientation());
+_page->setDrawsBackground(self.opaque);
 
 [_contentView layer].anchorPoint = CGPointZero;
 [_contentView setFrame:bounds];
@@ -970,6 +971,16 @@
 
 #if PLATFORM(IOS)
 
+- (void)_populateArchivedSubviews:(NSMutableSet *)encodedViews
+{
+[super _populateArchivedSubviews:encodedViews];
+
+if (_scrollView)
+[encodedViews removeObject:_scrollView.get()];
+if (_customContentFixedOverlayView)
+[encodedViews removeObject:_customContentFixedOverlayView.get()];
+}
+
 - (BOOL)_isBackground
 {
 if ([self _isDisplayingPDF])
@@ -1823,6 +1834,9 @@
 if (oldOpaque == opaque)
 return;
 
+if (!_page)
+return;
+
 _page->setDrawsBackground(opaque);
 [self _updateScrollViewBackground];
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211837] trunk

[commit-queue]

Title: [211837] trunk








Revision 211837
Author commit-qu...@webkit.org
Date 2017-02-07 13:56:42 -0800 (Tue, 07 Feb 2017)


Log Message
[WebRTC] LibWebRTCEndpoint should not own objects that should be destroyed on the main thread
https://bugs.webkit.org/show_bug.cgi?id=167816

Patch by Youenn Fablet  on 2017-02-07
Reviewed by Alex Christensen.

Source/WebCore:

Tests: webrtc/libwebrtc/release-while-creating-offer.html
   webrtc/libwebrtc/release-while-getting-stats.html
   webrtc/libwebrtc/release-while-setting-local-description.html

Moving AV sources, stats promises, ICE candidates from LibWebRTCEndpoint to LibWebRTCPeerConnectionBackend.
This allows ensuring these are destroyed in the main thread.

* Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::getStats):
* Modules/mediastream/MediaEndpointPeerConnection.h:
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::getStats):
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):
(WebCore::LibWebRTCMediaEndpoint::getStats):
(WebCore::LibWebRTCMediaEndpoint::StatsCollector::StatsCollector):
(WebCore::LibWebRTCMediaEndpoint::StatsCollector::OnStatsDelivered):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
(WebCore::LibWebRTCMediaEndpoint::addIceCandidate):
(WebCore::LibWebRTCMediaEndpoint::isStopped):
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::~LibWebRTCPeerConnectionBackend):
(WebCore::LibWebRTCPeerConnectionBackend::getStats):
(WebCore::LibWebRTCPeerConnectionBackend::iceCandidateSucceeded):
(WebCore::LibWebRTCPeerConnectionBackend::iceCandidateFailed):
(WebCore::LibWebRTCPeerConnectionBackend::doSetLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::doSetRemoteDescription):
(WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):
(WebCore::LibWebRTCPeerConnectionBackend::addAudioSource):
(WebCore::LibWebRTCPeerConnectionBackend::addVideoSource):
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
* testing/MockLibWebRTCPeerConnection.cpp:
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileCreatingOffer::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileCreatingOffer):
(WebCore::releaseInNetworkThread):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileCreatingOffer::CreateOffer):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileGettingStats::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileGettingStats):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileGettingStats::GetStats):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileSettingDescription::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileSettingDescription):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileSettingDescription::SetLocalDescription):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreatePeerConnection):
* testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

* webrtc/libwebrtc/release-while-creating-offer.html: Added.
* webrtc/libwebrtc/release-while-getting-stats.html: Added.
* webrtc/libwebrtc/release-while-setting-local-description.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h
trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp
trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.h


Added Paths

trunk/LayoutTests/webrtc/libwebrtc/
trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer.html
trunk/LayoutTests/webrtc/libwebrtc/release-while-getting-stats.html
trunk/LayoutTests/webrtc/libwebrtc/release-while-setting-local-description.html




Diff

Modified: trunk/LayoutTests/ChangeLog (211836 => 211837)

--- trunk/LayoutTests/ChangeLog	2017-02-07 21:37:44 UTC (rev 211836)
+++ trunk/LayoutTests/ChangeLog	2017-02-07 21:56:42 UTC (rev 211837)
@@ -1,5 +1,16 @@
 2017-02-07  Youenn Fablet  
 
+[WebRTC] LibWebRTCEndpoint should not own objects that should be destroyed on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=167816
+
+

[webkit-changes] [211836] trunk

[mmaxfield]

Title: [211836] trunk








Revision 211836
Author mmaxfi...@apple.com
Date 2017-02-07 13:37:44 -0800 (Tue, 07 Feb 2017)


Log Message
[Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
https://bugs.webkit.org/show_bug.cgi?id=167927

Reviewed by Brent Fulgham.

Source/WebCore:

This patch simply moves some functions around to enable the Win, GTK, and EFL ports to compile the
platform-independent pieces of ComplexTextController. Those parts of ComplexTextController have
some dependencies which were previously only available on the Cocoa ports; however, those
dependencies are easily created or moved from elsewhere. The next step is to populate the
ComplexTextController::collectComplexTextRunsForCharacters() function for DirectWrite and HarfBuzz.
Once that is done, UniscribeController and HarfBuzzShaper can be deleted.

Adds ComplexTextController TestWebKitAPI tests to the Win and GTK ports.

* CMakeLists.txt: Everyone can compile the platform-independent piece of ComplexTextController.
* PlatformEfl.cmake: Add the HarfBuzz-specific piece.
* PlatformGTK.cmake: Ditto.
* PlatformWin.cmake: Add the DirectWrite-specific piece.
* platform/graphics/ComplexTextController.cpp:
(WebCore::TextLayoutDeleter::operator()): ComplexTextController shouldn't be enabled yet for Win,
GTK, or EFL.
(WebCore::FontCascade::createLayout): Ditto.
(WebCore::FontCascade::width): Ditto.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moved shared code to the shared
file.
* platform/graphics/Font.cpp:
(WebCore::Font::noSynthesizableFeaturesFont): Default implementation for other ports.
(WebCore::Font::variantCapsSupportsCharacterForSynthesis): Ditto.
* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::fontForCombiningCharacterSequence): Ditto.
(WebCore::FontCascade::drawEmphasisMarksForComplexText): Ditto.
(WebCore::FontCascade::createLayout): Deleted. Moved to ComplexTextController.
(WebCore::TextLayoutDeleter::operator()): Deleted. Ditto.
* platform/graphics/FontCascade.h: fontForCombiningCharacterSequence() should exist on all ports.
* platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::FontCascade::drawEmphasisMarksForComplexText): Deleted. Shared among all ports.
* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::drawEmphasisMarksForComplexText): Deleted. Ditto.
* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Added.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Empty implementation of
HarfBuzz-specific piece of ComplexTextController.
* platform/graphics/mac/ComplexTextControllerCoreText.mm: Moved constructors to shared file.
* platform/graphics/win/ComplexTextControllerDirectWrite.cpp: Added.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Empty implementation of
Direct Write-specific piece of ComplexTextController.
* platform/graphics/win/FontWin.cpp:
(WebCore::FontCascade::drawEmphasisMarksForComplexText): Deleted. Shared among all ports.

Tools:

Enable ComplexTextController API tests on the Win and GTK ports.

* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/PlatformWin.cmake:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/PlatformWin.cmake
trunk/Source/WebCore/platform/graphics/ComplexTextController.cpp
trunk/Source/WebCore/platform/graphics/ComplexTextController.h
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
trunk/Source/WebCore/platform/graphics/FontCascade.h
trunk/Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp
trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm
trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm
trunk/Source/WebCore/platform/graphics/win/FontWin.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
trunk/Tools/TestWebKitAPI/PlatformWin.cmake
trunk/Tools/TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp


Added Paths

trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/win/ComplexTextControllerDirectWrite.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (211835 => 211836)

--- trunk/Source/WebCore/CMakeLists.txt	2017-02-07 21:29:50 UTC (rev 211835)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-02-07 21:37:44 UTC (rev 211836)
@@ -2169,6 +2169,7 @@
 
 platform/graphics/BitmapImage.cpp
 platform/graphics/Color.cpp
+platform/graphics/ComplexTextController.cpp
 platform/graphics/CrossfadeGeneratedImage.cpp
 platform/graphics/DisplayRefreshMonitorClient.cpp
 platform/graphics/ExtendedColor.cpp


Modified: trunk/Source/WebCore/ChangeLog (211835 => 211836)

--- trunk/Source/WebCore/ChangeLog	2017-02-07 21:29:50 UTC (rev 211835)
+++ trunk/Source/WebCore/ChangeLog	2017-02-07 21:37:44 

[webkit-changes] [211835] trunk/Source

[achristensen]

Title: [211835] trunk/Source








Revision 211835
Author achristen...@apple.com
Date 2017-02-07 13:29:50 -0800 (Tue, 07 Feb 2017)


Log Message
Revert r166597
https://bugs.webkit.org/show_bug.cgi?id=167951

Reviewed by Andreas Kling.

Source/WebCore:

* platform/spi/cf/CFNetworkSPI.h:
Remove now-unused SPI declaration.

Source/WebKit2:

CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
cache during authentication, especially server trust evaluation.  Right now we only call
it when handling memory pressure, and it isn't worth getting into such a strange state
in a poorly tested situation. See rdar://problem/27439617

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::initializeSandbox):
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (211834 => 211835)

--- trunk/Source/WebCore/ChangeLog	2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebCore/ChangeLog	2017-02-07 21:29:50 UTC (rev 211835)
@@ -1,3 +1,13 @@
+2017-02-07  Alex Christensen  
+
+Revert r166597
+https://bugs.webkit.org/show_bug.cgi?id=167951
+
+Reviewed by Andreas Kling.
+
+* platform/spi/cf/CFNetworkSPI.h:
+Remove now-unused SPI declaration.
+
 2017-02-07  Sam Weinig  
 
 Try to fix the windows build.


Modified: trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h (211834 => 211835)

--- trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h	2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h	2017-02-07 21:29:50 UTC (rev 211835)
@@ -155,8 +155,6 @@
 #endif
 #endif // PLATFORM(COCOA)
 
-void CFURLConnectionInvalidateConnectionCache();
-
 extern CFStringRef const kCFHTTPCookieLocalFileDomain;
 extern const CFStringRef kCFHTTPVersion1_1;
 extern const CFStringRef kCFURLRequestAllowAllPOSTCaching;


Modified: trunk/Source/WebKit2/ChangeLog (211834 => 211835)

--- trunk/Source/WebKit2/ChangeLog	2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-07 21:29:50 UTC (rev 211835)
@@ -1,3 +1,24 @@
+2017-02-07  Alex Christensen  
+
+Revert r166597
+https://bugs.webkit.org/show_bug.cgi?id=167951
+
+Reviewed by Andreas Kling.
+
+CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
+CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
+cache during authentication, especially server trust evaluation.  Right now we only call
+it when handling memory pressure, and it isn't worth getting into such a strange state
+in a poorly tested situation. See rdar://problem/27439617
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::lowMemoryHandler):
+(WebKit::NetworkProcess::initializeSandbox):
+(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
+* NetworkProcess/NetworkProcess.h:
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
+
 2017-02-07  Brian Burg  
 
 [Mac] Web Automation: NSEventType not initialized in WebAutomationSession::platformSimulateMouseInteraction


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (211834 => 211835)

--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp	2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp	2017-02-07 21:29:50 UTC (rev 211835)
@@ -195,7 +195,6 @@
 if (m_suppressMemoryPressureHandler)
 return;
 
-platformLowMemoryHandler(critical);
 WTF::releaseFastMallocFreeMemory();
 }
 
@@ -655,10 +654,6 @@
 void NetworkProcess::initializeSandbox(const ChildProcessInitializationParameters&, SandboxInitializationParameters&)
 {
 }
-
-void NetworkProcess::platformLowMemoryHandler(Critical)
-{
-}
 #endif
 
 } // namespace WebKit


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (211834 => 211835)

--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h	2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h	2017-02-07 21:29:50 UTC (rev 211835)
@@ -128,7 +128,6 @@
 void platformTerminate();
 
 void lowMemoryHandler(WebCore::Critical);
-

[webkit-changes] [211834] trunk/Source/JavaScriptCore

[mark . lam]

Title: [211834] trunk/Source/_javascript_Core








Revision 211834
Author mark@apple.com
Date 2017-02-07 13:22:20 -0800 (Tue, 07 Feb 2017)


Log Message
SigillCrashAnalyzer::analyze() should use a do-while loop instead of a lambda.
https://bugs.webkit.org/show_bug.cgi?id=167950

Reviewed by Michael Saboff.

Lambdas aren't free (apparently, the compiler isn't able to detect that the
lambda does not escape and can be inlined completely).  So, use a do-while loop
instead since we don't really need a lambda here.

* tools/SigillCrashAnalyzer.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/tools/SigillCrashAnalyzer.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (211833 => 211834)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-07 21:02:43 UTC (rev 211833)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-07 21:22:20 UTC (rev 211834)
@@ -1,3 +1,16 @@
+2017-02-07  Mark Lam  
+
+SigillCrashAnalyzer::analyze() should use a do-while loop instead of a lambda.
+https://bugs.webkit.org/show_bug.cgi?id=167950
+
+Reviewed by Michael Saboff.
+
+Lambdas aren't free (apparently, the compiler isn't able to detect that the
+lambda does not escape and can be inlined completely).  So, use a do-while loop
+instead since we don't really need a lambda here.
+
+* tools/SigillCrashAnalyzer.cpp:
+
 2017-02-05  Mark Lam  
 
 The SigillCrashAnalyzer should play nicer with client code that may install its own SIGILL handler.


Modified: trunk/Source/_javascript_Core/tools/SigillCrashAnalyzer.cpp (211833 => 211834)

--- trunk/Source/_javascript_Core/tools/SigillCrashAnalyzer.cpp	2017-02-07 21:02:43 UTC (rev 211833)
+++ trunk/Source/_javascript_Core/tools/SigillCrashAnalyzer.cpp	2017-02-07 21:22:20 UTC (rev 211834)
@@ -271,7 +271,7 @@
 CrashSource crashSource = CrashSource::Unknown;
 log("BEGIN SIGILL analysis");
 
-[&] () {
+do {
 // First, dump the signal context info so that we'll at least have the same info
 // that the default crash handler would given us in case this crash analyzer
 // itself crashes.
@@ -285,7 +285,7 @@
 if (!expectedLocker) {
 ASSERT(expectedLocker.error() == VMInspector::Error::TimedOut);
 log("ERROR: Unable to analyze SIGILL. Timed out while waiting to iterate VMs.");
-return;
+break;
 }
 auto& locker = expectedLocker.value();
 
@@ -293,12 +293,12 @@
 auto isInJITMemory = inspector.isValidExecutableMemory(locker, pc);
 if (!isInJITMemory) {
 log("ERROR: Timed out: not able to determine if pc %p is in valid JIT executable memory", pc);
-return;
+break;
 }
 if (!isInJITMemory.value()) {
 log("pc %p is NOT in valid JIT executable memory", pc);
 crashSource = CrashSource::Other;
-return;
+break;
 }
 log("pc %p is in valid JIT executable memory", pc);
 crashSource = CrashSource::_javascript_Core;
@@ -307,7 +307,7 @@
 size_t pcAsSize = reinterpret_cast(pc);
 if (pcAsSize != roundUpToMultipleOf(pcAsSize)) {
 log("pc %p is NOT properly aligned", pc);
-return;
+break;
 }
 
 // We know it's safe to read the word at the PC because we're handling a SIGILL.
@@ -322,18 +322,18 @@
 log("ERROR: Timed out: not able to determine if pc %p is in a valid CodeBlock", pc);
 else
 log("The current thread does not own any VM JSLock");
-return;
+break;
 }
 CodeBlock* codeBlock = expectedCodeBlock.value();
 if (!codeBlock) {
 log("machine PC %p does not belong to any CodeBlock in the currently entered VM", pc);
-return;
+break;
 }
 
 log("pc %p belongs to CodeBlock %p of type %s", pc, codeBlock, JITCode::typeName(codeBlock->jitType()));
 
 dumpCodeBlock(codeBlock, pc);
-} ();
+} while (false);
 
 log("END SIGILL analysis");
 return crashSource;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211833] trunk/Tools

[jbedard]

Title: [211833] trunk/Tools








Revision 211833
Author jbed...@apple.com
Date 2017-02-07 13:02:43 -0800 (Tue, 07 Feb 2017)


Log Message
File index appended to previous file in svn-create-patch with SVN 1.9
https://bugs.webkit.org/show_bug.cgi?id=167903


Reviewed by Daniel Bates.

* Scripts/VCSUtils.pm:
(fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
* Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
trailing newline character from the expected result before comparing it to the actual result.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
trunk/Tools/Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl




Diff

Modified: trunk/Tools/ChangeLog (211832 => 211833)

--- trunk/Tools/ChangeLog	2017-02-07 20:56:19 UTC (rev 211832)
+++ trunk/Tools/ChangeLog	2017-02-07 21:02:43 UTC (rev 211833)
@@ -1,3 +1,16 @@
+2017-02-07  Jonathan Bedard  
+
+File index appended to previous file in svn-create-patch with SVN 1.9
+https://bugs.webkit.org/show_bug.cgi?id=167903
+
+
+Reviewed by Daniel Bates.
+
+* Scripts/VCSUtils.pm:
+(fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
+* Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
+trailing newline character from the expected result before comparing it to the actual result.
+
 2017-02-07  Olivier Blin  
 
 [webkitdirs] remove unused host_processor variable in determineArchitecture()


Modified: trunk/Tools/Scripts/VCSUtils.pm (211832 => 211833)

--- trunk/Tools/Scripts/VCSUtils.pm	2017-02-07 20:56:19 UTC (rev 211832)
+++ trunk/Tools/Scripts/VCSUtils.pm	2017-02-07 21:02:43 UTC (rev 211833)
@@ -1779,7 +1779,7 @@
 return "";
 }
 splice(@lines, 0, 2) if $lines[2] =~ /$svnDiffStartRegEx/;
-return join($lineEnding, @lines);
+return join($lineEnding, @lines) . "\n"; # patch(1) expects an extra trailing newline.
 }
 
 # If possible, returns a ChangeLog patch equivalent to the given one,


Modified: trunk/Tools/Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl (211832 => 211833)

--- trunk/Tools/Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl	2017-02-07 20:56:19 UTC (rev 211832)
+++ trunk/Tools/Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl	2017-02-07 21:02:43 UTC (rev 211833)
@@ -282,7 +282,7 @@
 my $testNameStart = "fixSVNPatchForAdditionWithHistory(): $testCase->{diffName}: comparing";
 
 my $got = VCSUtils::fixSVNPatchForAdditionWithHistory($testCase->{inputText});
-chomp(my $expectedReturn = $testCase->{expectedReturn});
+my $expectedReturn = $testCase->{expectedReturn};
  
 is_deeply($got, $expectedReturn, "$testNameStart return value.");
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211832] trunk/Source/WebCore

[weinig]

Title: [211832] trunk/Source/WebCore








Revision 211832
Author wei...@apple.com
Date 2017-02-07 12:56:19 -0800 (Tue, 07 Feb 2017)


Log Message
Try to fix the windows build.

* bindings/js/ReadableStreamDefaultController.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (211831 => 211832)

--- trunk/Source/WebCore/ChangeLog	2017-02-07 20:44:48 UTC (rev 211831)
+++ trunk/Source/WebCore/ChangeLog	2017-02-07 20:56:19 UTC (rev 211832)
@@ -1,3 +1,9 @@
+2017-02-07  Sam Weinig  
+
+Try to fix the windows build.
+
+* bindings/js/ReadableStreamDefaultController.cpp:
+
 2017-02-07  Youenn Fablet  
 
 [WebRTC] LibWebRTC WK2 network stack is not providing correct ports for ICE candidates


Modified: trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp (211831 => 211832)

--- trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp	2017-02-07 20:44:48 UTC (rev 211831)
+++ trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp	2017-02-07 20:56:19 UTC (rev 211832)
@@ -36,6 +36,7 @@
 #include "WebCoreJSClientData.h"
 #include 
 #include 
+#include 
 
 namespace WebCore {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [211831] trunk/Source/WebKit2

[bburg]

Title: [211831] trunk/Source/WebKit2








Revision 211831
Author bb...@apple.com
Date 2017-02-07 12:44:48 -0800 (Tue, 07 Feb 2017)


Log Message
[Mac] Web Automation: NSEventType not initialized in WebAutomationSession::platformSimulateMouseInteraction
https://bugs.webkit.org/show_bug.cgi?id=167902

Reviewed by Joseph Pecoraro.

* UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
Initialize these to 0, which is not a valid NSEventType. Assert that
each NSEventType has a valid value before attempting to use it.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Automation/mac/WebAutomationSessionMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (211830 => 211831)

--- trunk/Source/WebKit2/ChangeLog	2017-02-07 20:19:09 UTC (rev 211830)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-07 20:44:48 UTC (rev 211831)
@@ -1,3 +1,15 @@
+2017-02-07  Brian Burg  
+
+[Mac] Web Automation: NSEventType not initialized in WebAutomationSession::platformSimulateMouseInteraction
+https://bugs.webkit.org/show_bug.cgi?id=167902
+
+Reviewed by Joseph Pecoraro.
+
+* UIProcess/Automation/mac/WebAutomationSessionMac.mm:
+(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
+Initialize these to 0, which is not a valid NSEventType. Assert that
+each NSEventType has a valid value before attempting to use it.
+
 2017-02-07  Youenn Fablet  
 
 [WebRTC] LibWebRTC WK2 network stack is not providing correct ports for ICE candidates


Modified: trunk/Source/WebKit2/UIProcess/Automation/mac/WebAutomationSessionMac.mm (211830 => 211831)

--- trunk/Source/WebKit2/UIProcess/Automation/mac/WebAutomationSessionMac.mm	2017-02-07 20:19:09 UTC (rev 211830)
+++ trunk/Source/WebKit2/UIProcess/Automation/mac/WebAutomationSessionMac.mm	2017-02-07 20:44:48 UTC (rev 211831)
@@ -214,9 +214,9 @@
 NSWindow *window = page.platformWindow();
 NSInteger windowNumber = window.windowNumber;
 
-NSEventType downEventType;
-NSEventType dragEventType;
-NSEventType upEventType;
+NSEventType downEventType = (NSEventType)0;
+NSEventType dragEventType = (NSEventType)0;
+NSEventType upEventType = (NSEventType)0;
 switch (button) {
 case Inspector::Protocol::Automation::MouseButton::None:
 downEventType = upEventType = dragEventType = NSEventTypeMouseMoved;
@@ -243,24 +243,35 @@
 
 switch (interaction) {
 case Inspector::Protocol::Automation::MouseInteraction::Move:
+ASSERT(dragEventType);
 [eventsToBeSent addObject:[NSEvent mouseEventWithType:dragEventType location:windowPosition modifierFlags:modifiers timestamp:timestamp windowNumber:windowNumber context:nil eventNumber:eventNumber clickCount:0 pressure:0.0f]];
 break;
 case Inspector::Protocol::Automation::MouseInteraction::Down:
+ASSERT(downEventType);
+
 // Hard-code the click count to one, since clients don't expect successive simulated
 // down/up events to be potentially counted as a double click event.
 [eventsToBeSent addObject:[NSEvent mouseEventWithType:downEventType location:windowPosition modifierFlags:modifiers timestamp:timestamp windowNumber:windowNumber context:nil eventNumber:eventNumber clickCount:1 pressure:WebCore::ForceAtClick]];
 break;
 case Inspector::Protocol::Automation::MouseInteraction::Up:
+ASSERT(upEventType);
+
 // Hard-code the click count to one, since clients don't expect successive simulated
 // down/up events to be potentially counted as a double click event.
 [eventsToBeSent addObject:[NSEvent mouseEventWithType:upEventType location:windowPosition modifierFlags:modifiers timestamp:timestamp windowNumber:windowNumber context:nil eventNumber:eventNumber clickCount:1 pressure:0.0f]];
 break;
 case Inspector::Protocol::Automation::MouseInteraction::SingleClick:
+ASSERT(upEventType);
+ASSERT(downEventType);
+
 // Send separate down and up events. WebCore will see this as a single-click event.
 [eventsToBeSent addObject:[NSEvent mouseEventWithType:downEventType location:windowPosition modifierFlags:modifiers timestamp:timestamp windowNumber:windowNumber context:nil eventNumber:eventNumber clickCount:1 pressure:WebCore::ForceAtClick]];
 [eventsToBeSent addObject:[NSEvent mouseEventWithType:upEventType location:windowPosition modifierFlags:modifiers timestamp:timestamp windowNumber:windowNumber context:nil eventNumber:eventNumber clickCount:1 pressure:0.0f]];
 break;
 case Inspector::Protocol::Automation::MouseInteraction::DoubleClick:
+ASSERT(upEventType);
+ASSERT(downEventType);
+
 // Send multiple down and up events with proper click count.
 // WebCore will see this as a single-click event then double-click event.
 

[webkit-changes] [211830] trunk

[commit-queue]

Title: [211830] trunk








Revision 211830
Author commit-qu...@webkit.org
Date 2017-02-07 12:19:09 -0800 (Tue, 07 Feb 2017)


Log Message
[WebRTC] LibWebRTC WK2 network stack is not providing correct ports for ICE candidates
https://bugs.webkit.org/show_bug.cgi?id=167939

Patch by Youenn Fablet  on 2017-02-07
Reviewed by Sam Weinig.

Source/WebCore:

Test: webrtc/no-port-zero-in-upd-candidates.html

* testing/MockLibWebRTCPeerConnection.cpp:
(WebCore::MockLibWebRTCPeerConnectionFactory::MockLibWebRTCPeerConnectionFactory): Adding a way to create one real PC in WTR environment.

Source/WebKit2:

AddressReady signalling was done by the WebProcess for UDP and ServerTCP as real async sockets in those case do
not send it. But the WebProcess does not have information on the port, as it is assigned by the socket factory
which is in the network process.

Fixed that bug by signalling AddressReady in the network process for UDP, ServerTCP and ClientTCP.

* NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:
(WebKit::LibWebRTCSocketClient::LibWebRTCSocketClient):
(WebKit::LibWebRTCSocketClient::signalAddressReady):
* NetworkProcess/webrtc/LibWebRTCSocketClient.h:
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createServerTCPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
* WebProcess/Network/webrtc/LibWebRTCSocket.cpp:
(WebKit::LibWebRTCSocket::LibWebRTCSocket):
(WebKit::LibWebRTCSocket::signalAddressReady):

LayoutTests:

* webrtc/no-port-zero-in-upd-candidates.html: Added.
* webrtc/no-port-zero-in-upd-candidates-expected.txt: Added.
* webrtc/video.html:
* webrtc/video-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webrtc/video.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp
trunk/Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.h
trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp
trunk/Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
trunk/Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocket.h


Added Paths

trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates-expected.txt
trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html
trunk/LayoutTests/webrtc/video-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (211829 => 211830)

--- trunk/LayoutTests/ChangeLog	2017-02-07 20:09:28 UTC (rev 211829)
+++ trunk/LayoutTests/ChangeLog	2017-02-07 20:19:09 UTC (rev 211830)
@@ -1,3 +1,15 @@
+2017-02-07  Youenn Fablet  
+
+[WebRTC] LibWebRTC WK2 network stack is not providing correct ports for ICE candidates
+https://bugs.webkit.org/show_bug.cgi?id=167939
+
+Reviewed by Sam Weinig.
+
+* webrtc/no-port-zero-in-upd-candidates.html: Added.
+* webrtc/no-port-zero-in-upd-candidates-expected.txt: Added.
+* webrtc/video.html:
+* webrtc/video-expected.txt: Added.
+
 2017-02-07  Yusuke Suzuki  
 
 Unreviewed, manual roll out of r211777


Added: trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates-expected.txt (0 => 211830)

--- trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates-expected.txt	(rev 0)
+++ trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates-expected.txt	2017-02-07 20:19:09 UTC (rev 211830)
@@ -0,0 +1,3 @@
+
+PASS Checking UDP ICE candidate ports 
+


Added: trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html (0 => 211830)

--- trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html	(rev 0)
+++ trunk/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html	2017-02-07 20:19:09 UTC (rev 211830)
@@ -0,0 +1,51 @@
+
+
+
+
+Ensuring ICE UDP candidates have a valid port
+
+
+