[webkit-changes] [216309] trunk/Source/JavaScriptCore

[keith_miller]

Title: [216309] trunk/Source/_javascript_Core








Revision 216309
Author keith_mil...@apple.com
Date 2017-05-05 22:19:39 -0700 (Fri, 05 May 2017)


Log Message
Put does not properly consult the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=171754

Reviewed by Saam Barati.

We should do a follow up that cleans up the rest of put. See:
https://bugs.webkit.org/show_bug.cgi?id=171759

* runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
* runtime/JSObject.cpp:
(JSC::JSObject::putInlineSlow):
* runtime/JSObjectInlines.h:
(JSC::JSObject::canPerformFastPutInline):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObjectInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216308 => 216309)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-06 04:55:04 UTC (rev 216308)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-06 05:19:39 UTC (rev 216309)
@@ -1,3 +1,20 @@
+2017-05-05  Keith Miller  
+
+Put does not properly consult the prototype chain
+https://bugs.webkit.org/show_bug.cgi?id=171754
+
+Reviewed by Saam Barati.
+
+We should do a follow up that cleans up the rest of put. See:
+https://bugs.webkit.org/show_bug.cgi?id=171759
+
+* runtime/JSCJSValue.cpp:
+(JSC::JSValue::putToPrimitive):
+* runtime/JSObject.cpp:
+(JSC::JSObject::putInlineSlow):
+* runtime/JSObjectInlines.h:
+(JSC::JSObject::canPerformFastPutInline):
+
 2017-05-05  JF Bastien  
 
 WebAssembly: Air::Inst::generate crashes on large binary on A64


Modified: trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp (216308 => 216309)

--- trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp	2017-05-06 04:55:04 UTC (rev 216308)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp	2017-05-06 05:19:39 UTC (rev 216309)
@@ -160,7 +160,9 @@
 JSValue prototype;
 if (propertyName != vm.propertyNames->underscoreProto) {
 for (; !obj->structure()->hasReadOnlyOrGetterSetterPropertiesExcludingProto(); obj = asObject(prototype)) {
-prototype = obj->getPrototypeDirect();
+prototype = obj->getPrototype(vm, exec);
+RETURN_IF_EXCEPTION(scope, false);
+
 if (prototype.isNull())
 return typeError(exec, scope, slot.isStrictMode(), ASCIILiteral(ReadonlyPropertyWriteError));
 }


Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (216308 => 216309)

--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2017-05-06 04:55:04 UTC (rev 216308)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2017-05-06 05:19:39 UTC (rev 216309)
@@ -802,13 +802,13 @@
 ProxyObject* proxy = jsCast(obj);
 return proxy->ProxyObject::put(proxy, exec, propertyName, value, slot);
 }
-JSValue prototype = obj->getPrototypeDirect();
+JSValue prototype = obj->getPrototype(vm, exec);
+RETURN_IF_EXCEPTION(scope, false);
 if (prototype.isNull())
 break;
 obj = asObject(prototype);
 }
 
-ASSERT(!structure(vm)->prototypeChainMayInterceptStoreTo(vm, propertyName) || obj == this);
 if (!putDirectInternal(vm, propertyName, value, 0, slot))
 return typeError(exec, scope, slot.isStrictMode(), ASCIILiteral(ReadonlyPropertyWriteError));
 return true;


Modified: trunk/Source/_javascript_Core/runtime/JSObjectInlines.h (216308 => 216309)

--- trunk/Source/_javascript_Core/runtime/JSObjectInlines.h	2017-05-06 04:55:04 UTC (rev 216308)
+++ trunk/Source/_javascript_Core/runtime/JSObjectInlines.h	2017-05-06 05:19:39 UTC (rev 216309)
@@ -69,7 +69,8 @@
 JSValue prototype;
 JSObject* obj = this;
 while (true) {
-if (obj->structure(vm)->hasReadOnlyOrGetterSetterPropertiesExcludingProto() || obj->type() == ProxyObjectType)
+MethodTable::GetPrototypeFunctionPtr defaultGetPrototype = JSObject::getPrototype;
+if (obj->structure(vm)->hasReadOnlyOrGetterSetterPropertiesExcludingProto() || obj->methodTable(vm)->getPrototype != defaultGetPrototype)
 return false;
 
 prototype = obj->getPrototypeDirect();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216307] trunk

[zalan]

Title: [216307] trunk








Revision 216307
Author za...@apple.com
Date 2017-05-05 21:41:32 -0700 (Fri, 05 May 2017)


Log Message
Renderers being destroyed should not be added to AX's deferred list.
https://bugs.webkit.org/show_bug.cgi?id=171768


Reviewed by Simon Fraser.

Source/WebCore:

In certain cases, when custom scrollbars are present, while destroying the scrollbars' block parent, we
  - first remove the block from the AX's deferred list (AXObjectCache::remove)
  - destroy the render layer that owns the custom scrollbars (RenderLayer::destroyLayer)
  - detach the scrollbars from the parent (block) (RenderObject::removeFromParent)
- clean up the block's lines (RenderBlock::deleteLines)
  - push the block back to the AX's deferred list (AXObjectCache::recomputeDeferredIsIgnored)
At this point no one will remove the current block from AX's deferred list.

Test: accessibility/crash-when-renderers-are-added-back-to-deferred-list.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::recomputeDeferredIsIgnored):
(WebCore::AXObjectCache::deferTextChanged):

LayoutTests:

* accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt: Added.
* accessibility/crash-when-renderers-are-added-back-to-deferred-list.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp


Added Paths

trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt
trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216306 => 216307)

--- trunk/LayoutTests/ChangeLog	2017-05-06 03:57:42 UTC (rev 216306)
+++ trunk/LayoutTests/ChangeLog	2017-05-06 04:41:32 UTC (rev 216307)
@@ -1,3 +1,14 @@
+2017-05-05  Zalan Bujtas  
+
+Renderers being destroyed should not be added to AX's deferred list.
+https://bugs.webkit.org/show_bug.cgi?id=171768
+
+
+Reviewed by Simon Fraser.
+
+* accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt: Added.
+* accessibility/crash-when-renderers-are-added-back-to-deferred-list.html: Added.
+
 2017-05-05  Matt Lewis  
 
 Mark compositing/tiling/non-active-window-tiles-size.html as flaky


Added: trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt (0 => 216307)

--- trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt	2017-05-06 04:41:32 UTC (rev 216307)
@@ -0,0 +1 @@
+PASS if no crash or assert.


Added: trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html (0 => 216307)

--- trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html	(rev 0)
+++ trunk/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html	2017-05-06 04:41:32 UTC (rev 216307)
@@ -0,0 +1,26 @@
+
+
+
+This tests that accessibility ignores elements that are being destroyed
+
+if (window.accessibilityController)
+accessibilityController.accessibleElementById("foo");
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+::-webkit-scrollbar-corner {
+border: 1px solid green;
+}
+
+
+
+PASS if no crash or assert.
+
+
+document.body.offsetHeight;
+foo.style.display = "none";
+document.body.offsetHeight;
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (216306 => 216307)

--- trunk/Source/WebCore/ChangeLog	2017-05-06 03:57:42 UTC (rev 216306)
+++ trunk/Source/WebCore/ChangeLog	2017-05-06 04:41:32 UTC (rev 216307)
@@ -1,3 +1,25 @@
+2017-05-05  Zalan Bujtas  
+
+Renderers being destroyed should not be added to AX's deferred list.
+https://bugs.webkit.org/show_bug.cgi?id=171768
+
+
+Reviewed by Simon Fraser.
+
+In certain cases, when custom scrollbars are present, while destroying the scrollbars' block parent, we
+  - first remove the block from the AX's deferred list (AXObjectCache::remove)
+  - destroy the render layer that owns the custom scrollbars (RenderLayer::destroyLayer) 
+  - detach the scrollbars from the parent (block) (RenderObject::removeFromParent)
+- clean up the block's lines (RenderBlock::deleteLines)
+  - push the block back to the AX's deferred list (AXObjectCache::recomputeDeferredIsIgnored)
+At this point no one will remove the current block from AX's deferred list.
+
+Test: accessibility/crash-when-renderers-are-added-back-to-deferred-list.html
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::recomputeDeferredIsIgnored):
+(WebCore::AXObjectCache::deferTextChanged):

[webkit-changes] [216306] trunk/Source/JavaScriptCore

[jfbastien]

Title: [216306] trunk/Source/_javascript_Core








Revision 216306
Author jfbast...@apple.com
Date 2017-05-05 20:57:42 -0700 (Fri, 05 May 2017)


Log Message
WebAssembly: Air::Inst::generate crashes on large binary on A64
https://bugs.webkit.org/show_bug.cgi?id=170215

Reviewed by Filip Pizlo.

ARM can't encode all offsets in a single instruction. We usualy
handle this type of detail early, or the macro assembler uses a
scratch register to take care of the large immediate. After
register allocation we assumed that we would never get large
offsets, and asserted this was the case. That was a fine
assumption with _javascript_, but WebAssembly ends up generating
stack frames which are too big to encode.

There are two places that needed to be fixed:
1. AirGenerate
2. AirLowerStackArgs

We now unconditionally pin the dataTempRegister on ARM64, and use
it when immediates don't fit.

Number 1. is easy: we're just incrementing SP, make sure we can
use a scratch register when that happens.

Number 2. is more complex: not all Inst can receive a stack
argument whose base register isn't SP or FP. Specifically,
Patchpoints and Stackmaps get very sad because they just want to
know the offset value, but when we materialize the offset as
follows:

Move (spill337), (spill201), %r0, @8735

Becomes (where %r16 is dataTempRegister):
Move $1404, %r16, @8736
Add64 %sp, %r16, @8736
Move (%r16), 2032(%sp), %r0, @8736

The code currently doesn't see through our little dance. To work
around this issue we introduce a new Air Arg kind:
ExtendedOffsetAddr. This is the same as a regular Addr, but with
an offset which may be too big to encode. Opcodes then declare
whether their arguments can handle such inputs, and if so we
generate them, otherwise we generate Addr as shown above.

None of this affects x86 because it can always encode large
immediates.

This patch also drive-by converts some uses of `override` to
`final`. It makes the code easier to grok, and maybe helps the
optimizer sometimes but really that doens't matter.

* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM64.h:
* b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::admitsExtendedOffsetAddr):
* b3/B3CheckSpecial.h:
* b3/B3Common.cpp:
(JSC::B3::pinnedExtendedOffsetAddrRegister): keep the CPU-specific
pinning information in a cpp file
* b3/B3Common.h:
* b3/B3PatchpointSpecial.cpp:
(JSC::B3::PatchpointSpecial::admitsExtendedOffsetAddr):
* b3/B3PatchpointSpecial.h:
* b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::isArgValidForRep):
(JSC::B3::StackmapSpecial::repForArg):
* b3/B3StackmapSpecial.h:
* b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::isStackMemory):
(JSC::B3::Air::Arg::jsHash):
(JSC::B3::Air::Arg::dump):
(WTF::printInternal):
(JSC::B3::Air::Arg::stackAddrImpl): Deleted. There was only one
use of this (in AirLowerStackArgs) and it was now confusing to
split the logic up between these two. Inline the code that used to
be here into its one usepoint instead.
* b3/air/AirArg.h:
(JSC::B3::Air::Arg::extendedOffsetAddr):
(JSC::B3::Air::Arg::isExtendedOffsetAddr):
(JSC::B3::Air::Arg::isMemory):
(JSC::B3::Air::Arg::base):
(JSC::B3::Air::Arg::offset):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isValidForm):
(JSC::B3::Air::Arg::forEachTmpFast):
(JSC::B3::Air::Arg::forEachTmp):
(JSC::B3::Air::Arg::asAddress):
(JSC::B3::Air::Arg::stackAddr): Deleted.
* b3/air/AirCCallSpecial.cpp:
(JSC::B3::Air::CCallSpecial::isValid):
(JSC::B3::Air::CCallSpecial::admitsExtendedOffsetAddr):
(JSC::B3::Air::CCallSpecial::generate):
* b3/air/AirCCallSpecial.h:
* b3/air/AirCode.cpp:
(JSC::B3::Air::Code::Code):
(JSC::B3::Air::Code::pinRegister): Check that the register wasn't
pinned before pinning it. It's likely a bug to pin the same
register twice.
* b3/air/AirCustom.h:
(JSC::B3::Air::PatchCustom::admitsExtendedOffsetAddr):
(JSC::B3::Air::CCallCustom::admitsExtendedOffsetAddr):
(JSC::B3::Air::ShuffleCustom::admitsExtendedOffsetAddr):
(JSC::B3::Air::EntrySwitchCustom::admitsExtendedOffsetAddr):
(JSC::B3::Air::WasmBoundsCheckCustom::admitsExtendedOffsetAddr):
* b3/air/AirGenerate.cpp:
(JSC::B3::Air::generate):
* b3/air/AirInst.h:
* b3/air/AirInstInlines.h:
(JSC::B3::Air::Inst::admitsExtendedOffsetAddr):
* b3/air/AirLowerStackArgs.cpp:
(JSC::B3::Air::lowerStackArgs):
* b3/air/AirPrintSpecial.cpp:
(JSC::B3::Air::PrintSpecial::admitsExtendedOffsetAddr):
(JSC::B3::Air::PrintSpecial::generate):
* b3/air/AirPrintSpecial.h:
* b3/air/AirSpecial.h:
* b3/air/opcode_generator.rb:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/b3/B3CheckSpecial.cpp
trunk/Source/_javascript_Core/b3/B3CheckSpecial.h
trunk/Source/_javascript_Core/b3/B3Common.cpp
trunk/Source/_javascript_Core/b3/B3Common.h
trunk/Source/_javascript_Core/b3/B3PatchpointSpecial.cpp

[webkit-changes] [216305] trunk/Source/WebCore

[said]

Title: [216305] trunk/Source/WebCore








Revision 216305
Author s...@apple.com
Date 2017-05-05 20:27:16 -0700 (Fri, 05 May 2017)


Log Message
Crash in ImageFrameCache::decodedSizeChanged() after image load cancellation
https://bugs.webkit.org/show_bug.cgi?id=171736

Reviewed by Tim Horton.

Tests: Covered by run-webkit-tests fast/images/image-formats-support.html
--guard-malloc.

Because an image format is not supported, the ImageObserver of the Image
is deleted then the Image itself is deleted. In BitmapImage destructor,
we make a call which ends up accessing the deleted ImageObserver.

To fix this, we need to change the BitImage destructor to avoid calling 
ImageFrameCache::decodedSizeChanged() since it is not really needed.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::~BitmapImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216304 => 216305)

--- trunk/Source/WebCore/ChangeLog	2017-05-06 01:59:14 UTC (rev 216304)
+++ trunk/Source/WebCore/ChangeLog	2017-05-06 03:27:16 UTC (rev 216305)
@@ -1,3 +1,23 @@
+2017-05-05  Said Abou-Hallawa  
+
+Crash in ImageFrameCache::decodedSizeChanged() after image load cancellation
+https://bugs.webkit.org/show_bug.cgi?id=171736
+
+Reviewed by Tim Horton.
+
+Tests: Covered by run-webkit-tests fast/images/image-formats-support.html
+--guard-malloc.
+
+Because an image format is not supported, the ImageObserver of the Image
+is deleted then the Image itself is deleted. In BitmapImage destructor,
+we make a call which ends up accessing the deleted ImageObserver.
+
+To fix this, we need to change the BitImage destructor to avoid calling 
+ImageFrameCache::decodedSizeChanged() since it is not really needed.
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::~BitmapImage):
+
 2017-05-05  Timothy Horton  
 
 [Mac] Adjust cursor position for dragged link (and stop it from moving based on how fast you are dragging)


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (216304 => 216305)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-06 01:59:14 UTC (rev 216304)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-06 03:27:16 UTC (rev 216305)
@@ -61,7 +61,8 @@
 BitmapImage::~BitmapImage()
 {
 invalidatePlatformData();
-stopAnimation();
+clearTimer();
+m_source.stopAsyncDecodingQueue();
 }
 
 void BitmapImage::updateFromSettings(const Settings& settings)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216304] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [216304] trunk/Source/WebInspectorUI








Revision 216304
Author nvasil...@apple.com
Date 2017-05-05 18:59:14 -0700 (Fri, 05 May 2017)


Log Message
REGRESSION (r212998): Web Inspector: bad spacing of go-to arrow for HTTP POST request data
https://bugs.webkit.org/show_bug.cgi?id=171674

Reviewed by Matt Baker.

* UserInterface/Views/DetailsSection.css:
(body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
(body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
Swap margin-left and margin-right. This regressed when RTL support was added.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (216303 => 216304)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-06 01:39:00 UTC (rev 216303)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-06 01:59:14 UTC (rev 216304)
@@ -1,3 +1,15 @@
+2017-05-05  Nikita Vasilyev  
+
+REGRESSION (r212998): Web Inspector: bad spacing of go-to arrow for HTTP POST request data
+https://bugs.webkit.org/show_bug.cgi?id=171674
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/DetailsSection.css:
+(body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
+(body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
+Swap margin-left and margin-right. This regressed when RTL support was added.
+
 2017-05-03  Devin Rousso  
 
 REGRESSION (r215630): Web Inspector: Option-Click on URL in Styles sidebar does not work


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css (216303 => 216304)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css	2017-05-06 01:39:00 UTC (rev 216303)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css	2017-05-06 01:59:14 UTC (rev 216304)
@@ -276,11 +276,11 @@
 }
 
 body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow {
-margin-right: var(--details-section-content-group-row-simple-value-go-to-margin-start);
+margin-left: var(--details-section-content-group-row-simple-value-go-to-margin-start);
 }
 
 body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow {
-margin-left: var(--details-section-content-group-row-simple-value-go-to-margin-start);
+margin-right: var(--details-section-content-group-row-simple-value-go-to-margin-start);
 }
 
 .details-section > .content > .group > .row.simple.data > .value {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216303] trunk/Source

[timothy_horton]

Title: [216303] trunk/Source








Revision 216303
Author timothy_hor...@apple.com
Date 2017-05-05 18:39:00 -0700 (Fri, 05 May 2017)


Log Message
[Mac] Adjust cursor position for dragged link (and stop it from moving based on how fast you are dragging)
https://bugs.webkit.org/show_bug.cgi?id=171764


Reviewed by Simon Fraser.

* page/DragController.cpp:
(WebCore::DragController::startDrag):
Compute dragImageAnchorPoint only if it is needed.
Don't compute a random unused imageRect.
Factor link drag image offset computation out into DragImage functions
for platforms to override.

Pass dragOrigin (the mouseDown point), not mouseDraggedPoint, to
doSystemDrag, just like all the other drag types. This plus the
WebKit2 change makes the link stable vs. the cursor, instead of
positioned based on how fast you move after the mouse down.

* page/DragController.h:
* page/gtk/DragControllerGtk.cpp:
* page/mac/DragControllerMac.mm:
* page/win/DragControllerWin.cpp:
Move LinkDragBorderInset into DragImage, and share between the non-Mac platforms.

* platform/DragImage.cpp:
(WebCore::dragOffsetForLinkDragImage):
(WebCore::anchorPointForLinkDragImage):
* platform/DragImage.h:
As previously mentioned, move the computation of drag image offset here.

* platform/mac/DragImageMac.mm:
(WebCore::dragOffsetForLinkDragImage):
(WebCore::anchorPointForLinkDragImage):
Put the new drag image to the bottom right of the cursor.

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::dragImageForView):
Always use the last mouse down event to originate the drag; this was a 2004 hack
to work around a seemingly-fixed macOS bug that somehow propagated into WebKit2.
With WebKit2, this would cause trouble because currentEvent could move on
during the bounce to the Web Content process and back, causing the delta between
clientPoint and the mouse point to be dependent on timing, and thus causing the
link to sit at timing-dependent distance from the cursor, instead of exactly
where dragOffsetForLinkDragImage placed it.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/DragController.h
trunk/Source/WebCore/page/gtk/DragControllerGtk.cpp
trunk/Source/WebCore/page/mac/DragControllerMac.mm
trunk/Source/WebCore/page/win/DragControllerWin.cpp
trunk/Source/WebCore/platform/DragImage.cpp
trunk/Source/WebCore/platform/DragImage.h
trunk/Source/WebCore/platform/mac/DragImageMac.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216302 => 216303)

--- trunk/Source/WebCore/ChangeLog	2017-05-06 01:10:32 UTC (rev 216302)
+++ trunk/Source/WebCore/ChangeLog	2017-05-06 01:39:00 UTC (rev 216303)
@@ -1,3 +1,40 @@
+2017-05-05  Timothy Horton  
+
+[Mac] Adjust cursor position for dragged link (and stop it from moving based on how fast you are dragging)
+https://bugs.webkit.org/show_bug.cgi?id=171764
+
+
+Reviewed by Simon Fraser.
+
+* page/DragController.cpp:
+(WebCore::DragController::startDrag):
+Compute dragImageAnchorPoint only if it is needed.
+Don't compute a random unused imageRect.
+Factor link drag image offset computation out into DragImage functions
+for platforms to override.
+
+Pass dragOrigin (the mouseDown point), not mouseDraggedPoint, to
+doSystemDrag, just like all the other drag types. This plus the
+WebKit2 change makes the link stable vs. the cursor, instead of
+positioned based on how fast you move after the mouse down.
+
+* page/DragController.h:
+* page/gtk/DragControllerGtk.cpp:
+* page/mac/DragControllerMac.mm:
+* page/win/DragControllerWin.cpp:
+Move LinkDragBorderInset into DragImage, and share between the non-Mac platforms.
+
+* platform/DragImage.cpp:
+(WebCore::dragOffsetForLinkDragImage):
+(WebCore::anchorPointForLinkDragImage):
+* platform/DragImage.h:
+As previously mentioned, move the computation of drag image offset here.
+
+* platform/mac/DragImageMac.mm:
+(WebCore::dragOffsetForLinkDragImage):
+(WebCore::anchorPointForLinkDragImage):
+Put the new drag image to the bottom right of the cursor.
+
 2017-05-05  Dean Jackson  
 
 ...and now the GTK and Windows builds.


Modified: trunk/Source/WebCore/page/DragController.cpp (216302 => 216303)

--- trunk/Source/WebCore/page/DragController.cpp	2017-05-06 01:10:32 UTC (rev 216302)
+++ trunk/Source/WebCore/page/DragController.cpp	2017-05-06 01:39:00 UTC (rev 216303)
@@ -864,7 +864,6 @@
 m_sourceDragOperation = srcOp;
 
 DragImage dragImage;
-FloatPoint dragImageAnchorPoint;
 IntPoint dragLoc(0, 0);
 IntPoint dragImageOffset(0, 0);
 
@@ -946,7 +945,6 @@
 if (textIndicator.contentImage)
 

[webkit-changes] [216302] trunk/LayoutTests

[ryanhaddad]

Title: [216302] trunk/LayoutTests








Revision 216302
Author ryanhad...@apple.com
Date 2017-05-05 18:10:32 -0700 (Fri, 05 May 2017)


Log Message
Mark compositing/tiling/non-active-window-tiles-size.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=171763

Unreviewed test gardening.

Patch by Matt Lewis  on 2017-05-05

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216301 => 216302)

--- trunk/LayoutTests/ChangeLog	2017-05-06 00:33:20 UTC (rev 216301)
+++ trunk/LayoutTests/ChangeLog	2017-05-06 01:10:32 UTC (rev 216302)
@@ -1,3 +1,12 @@
+2017-05-05  Matt Lewis  
+
+Mark compositing/tiling/non-active-window-tiles-size.html as flaky
+https://bugs.webkit.org/show_bug.cgi?id=171763
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-05-05  Oliver Hunt  
 
 Move trivial String prototype functions to JS builtins


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216301 => 216302)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-06 00:33:20 UTC (rev 216301)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-06 01:10:32 UTC (rev 216302)
@@ -664,3 +664,5 @@
 webkit.org/b/171553 [ Release ] http/tests/websocket/tests/hybi/inspector/binary.html [ Pass Failure ]
 
 webkit.org/b/172703 [ Sierra Debug ] webrtc/libwebrtc/descriptionGetters.html [ Pass Failure ]
+
+webkit.org/b/171763 [ Debug ] compositing/tiling/non-active-window-tiles-size.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216301] trunk

[oliver]

Title: [216301] trunk








Revision 216301
Author oli...@apple.com
Date 2017-05-05 17:33:20 -0700 (Fri, 05 May 2017)


Log Message
Move trivial String prototype functions to JS builtins
https://bugs.webkit.org/show_bug.cgi?id=171737

Reviewed by Saam Barati.

Source/_javascript_Core:

Super simple change to migrate all of the old school
html-ifying string operations to builtin JS.

Core implementation is basically a 1-for-1 match to the spec.

* builtins/StringPrototype.js:
(globalPrivate.createHTML):
(anchor):
(big):
(blink):
(bold):
(fixed):
(fontcolor):
(fontsize):
(italics):
(link):
(small):
(strike):
(sub):
(sup):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
(JSC::stringProtoFuncBig): Deleted.
(JSC::stringProtoFuncSmall): Deleted.
(JSC::stringProtoFuncBlink): Deleted.
(JSC::stringProtoFuncBold): Deleted.
(JSC::stringProtoFuncFixed): Deleted.
(JSC::stringProtoFuncItalics): Deleted.
(JSC::stringProtoFuncStrike): Deleted.
(JSC::stringProtoFuncSub): Deleted.
(JSC::stringProtoFuncSup): Deleted.
(JSC::stringProtoFuncFontcolor): Deleted.
(JSC::stringProtoFuncFontsize): Deleted.
(JSC::stringProtoFuncAnchor): Deleted.
(JSC::stringProtoFuncLink): Deleted.

LayoutTests:

Updated output

* js/dom/string-anchor-expected.txt:
* js/dom/string-anchor.html:
* js/dom/string-fontcolor-expected.txt:
* js/dom/string-fontcolor.html:
* js/dom/string-fontsize-expected.txt:
* js/dom/string-fontsize.html:
* js/dom/string-link-expected.txt:
* js/dom/string-link.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/string-anchor-expected.txt
trunk/LayoutTests/js/dom/string-anchor.html
trunk/LayoutTests/js/dom/string-fontcolor-expected.txt
trunk/LayoutTests/js/dom/string-fontcolor.html
trunk/LayoutTests/js/dom/string-fontsize-expected.txt
trunk/LayoutTests/js/dom/string-fontsize.html
trunk/LayoutTests/js/dom/string-link-expected.txt
trunk/LayoutTests/js/dom/string-link.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/StringPrototype.js
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (216300 => 216301)

--- trunk/LayoutTests/ChangeLog	2017-05-06 00:24:11 UTC (rev 216300)
+++ trunk/LayoutTests/ChangeLog	2017-05-06 00:33:20 UTC (rev 216301)
@@ -1,3 +1,21 @@
+2017-05-05  Oliver Hunt  
+
+Move trivial String prototype functions to JS builtins
+https://bugs.webkit.org/show_bug.cgi?id=171737
+
+Reviewed by Saam Barati.
+
+Updated output
+
+* js/dom/string-anchor-expected.txt:
+* js/dom/string-anchor.html:
+* js/dom/string-fontcolor-expected.txt:
+* js/dom/string-fontcolor.html:
+* js/dom/string-fontsize-expected.txt:
+* js/dom/string-fontsize.html:
+* js/dom/string-link-expected.txt:
+* js/dom/string-link.html:
+
 2017-05-05  Dean Jackson  
 
 Restrict SVG filters to accessible security origins


Modified: trunk/LayoutTests/js/dom/string-anchor-expected.txt (216300 => 216301)

--- trunk/LayoutTests/js/dom/string-anchor-expected.txt	2017-05-06 00:24:11 UTC (rev 216300)
+++ trunk/LayoutTests/js/dom/string-anchor-expected.txt	2017-05-06 00:33:20 UTC (rev 216301)
@@ -9,8 +9,8 @@
 PASS '_'.anchor('"') is "_"
 PASS '_'.anchor('" href="" is " PASS String.prototype.anchor.call(0x2A, 0x2A) is "42"
-PASS String.prototype.anchor.call(undefined) threw exception TypeError: Type error.
-PASS String.prototype.anchor.call(null) threw exception TypeError: Type error.
+PASS String.prototype.anchor.call(undefined) threw exception TypeError: String.prototype.link requires that |this| not be null or undefined.
+PASS String.prototype.anchor.call(null) threw exception TypeError: String.prototype.link requires that |this| not be null or undefined.
 PASS String.prototype.anchor.length is 1
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/js/dom/string-anchor.html (216300 => 216301)

--- trunk/LayoutTests/js/dom/string-anchor.html	2017-05-06 00:24:11 UTC (rev 216300)
+++ trunk/LayoutTests/js/dom/string-anchor.html	2017-05-06 00:33:20 UTC (rev 216301)
@@ -28,10 +28,10 @@
 shouldBe("String.prototype.anchor.call(0x2A, 0x2A)", '"42"');
 
 // Generic use on non-coercible object `undefined`.
-shouldThrow("String.prototype.anchor.call(undefined)", '"TypeError: Type error"');
+shouldThrowErrorName("String.prototype.anchor.call(undefined)", 'TypeError');
 
 // Generic use on non-coercible object `null`.
-shouldThrow("String.prototype.anchor.call(null)", '"TypeError: Type error"');
+shouldThrowErrorName("String.prototype.anchor.call(null)", 'TypeError');
 
 // Check anchor.length.
 shouldBe("String.prototype.anchor.length", "1");


Modified: trunk/LayoutTests/js/dom/string-fontcolor-expected.txt (216300 => 216301)

--- trunk/LayoutTests/js/dom/string-fontcolor-expected.txt	2017-05-06 00:24:11 UTC (rev 216300)
+++ trunk/LayoutTests/js/dom/string-fontcolor-expected.txt	2017-05-06 

[webkit-changes] [216300] trunk/Source/bmalloc

[commit-queue]

Title: [216300] trunk/Source/bmalloc








Revision 216300
Author commit-qu...@webkit.org
Date 2017-05-05 17:24:11 -0700 (Fri, 05 May 2017)


Log Message
Leaks always reports "WebKit Malloc Memory Pressure Handler" dispatch_queue/source as leaking
https://bugs.webkit.org/show_bug.cgi?id=171532

Patch by Joseph Pecoraro  on 2017-05-05
Reviewed by Geoffrey Garen.

* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
* bmalloc/Heap.h:
Store the dispatch_source_t in a member to avoid a false positive leak.

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Heap.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (216299 => 216300)

--- trunk/Source/bmalloc/ChangeLog	2017-05-06 00:17:00 UTC (rev 216299)
+++ trunk/Source/bmalloc/ChangeLog	2017-05-06 00:24:11 UTC (rev 216300)
@@ -1,3 +1,15 @@
+2017-05-05  Joseph Pecoraro  
+
+Leaks always reports "WebKit Malloc Memory Pressure Handler" dispatch_queue/source as leaking
+https://bugs.webkit.org/show_bug.cgi?id=171532
+
+Reviewed by Geoffrey Garen.
+
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::Heap):
+* bmalloc/Heap.h:
+Store the dispatch_source_t in a member to avoid a false positive leak.
+
 2017-04-27  Michael Saboff  
 
 bmalloc scavenger should know what page classes are allocating


Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (216299 => 216300)

--- trunk/Source/bmalloc/bmalloc/Heap.cpp	2017-05-06 00:17:00 UTC (rev 216299)
+++ trunk/Source/bmalloc/bmalloc/Heap.cpp	2017-05-06 00:24:11 UTC (rev 216300)
@@ -30,11 +30,11 @@
 #include "PerProcess.h"
 #include "SmallLine.h"
 #include "SmallPage.h"
+#include 
+
 #if BOS(DARWIN)
 #include "bmalloc.h"
-#include 
 #endif
-#include 
 
 namespace bmalloc {
 
@@ -54,11 +54,12 @@
 
 #if BOS(DARWIN)
 auto queue = dispatch_queue_create("WebKit Malloc Memory Pressure Handler", DISPATCH_QUEUE_SERIAL);
-auto source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYPRESSURE, 0, DISPATCH_MEMORYPRESSURE_CRITICAL, queue);
-dispatch_source_set_event_handler(source, ^{
+m_pressureHandlerDispatchSource = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYPRESSURE, 0, DISPATCH_MEMORYPRESSURE_CRITICAL, queue);
+dispatch_source_set_event_handler(m_pressureHandlerDispatchSource, ^{
 api::scavenge();
 });
-dispatch_resume(source);
+dispatch_resume(m_pressureHandlerDispatchSource);
+dispatch_release(queue);
 #endif
 }
 


Modified: trunk/Source/bmalloc/bmalloc/Heap.h (216299 => 216300)

--- trunk/Source/bmalloc/bmalloc/Heap.h	2017-05-06 00:17:00 UTC (rev 216299)
+++ trunk/Source/bmalloc/bmalloc/Heap.h	2017-05-06 00:24:11 UTC (rev 216300)
@@ -42,6 +42,10 @@
 #include 
 #include 
 
+#if BOS(DARWIN)
+#include 
+#endif
+
 namespace bmalloc {
 
 class BeginTag;
@@ -128,6 +132,7 @@
 VMHeap m_vmHeap;
 
 #if BOS(DARWIN)
+dispatch_source_t m_pressureHandlerDispatchSource;
 qos_class_t m_requestedScavengerThreadQOSClass { QOS_CLASS_UNSPECIFIED };
 #endif
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216299] trunk/Source/WebCore

[dino]

Title: [216299] trunk/Source/WebCore








Revision 216299
Author d...@apple.com
Date 2017-05-05 17:17:00 -0700 (Fri, 05 May 2017)


Log Message
...and now the GTK and Windows builds.

* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::paint):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::paint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp
trunk/Source/WebCore/platform/win/WidgetWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216298 => 216299)

--- trunk/Source/WebCore/ChangeLog	2017-05-06 00:08:55 UTC (rev 216298)
+++ trunk/Source/WebCore/ChangeLog	2017-05-06 00:17:00 UTC (rev 216299)
@@ -1,3 +1,12 @@
+2017-05-05  Dean Jackson  
+
+...and now the GTK and Windows builds.
+
+* platform/gtk/WidgetGtk.cpp:
+(WebCore::Widget::paint):
+* platform/win/WidgetWin.cpp:
+(WebCore::Widget::paint):
+
 2017-05-05  Brady Eidson  
 
 API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.


Modified: trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp (216298 => 216299)

--- trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp	2017-05-06 00:08:55 UTC (rev 216298)
+++ trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp	2017-05-06 00:17:00 UTC (rev 216299)
@@ -80,7 +80,7 @@
 gtk_widget_hide(platformWidget());
 }
 
-void Widget::paint(GraphicsContext&, const IntRect&)
+void Widget::paint(GraphicsContext&, const IntRect&, SecurityOriginPaintPolicy)
 {
 }
 


Modified: trunk/Source/WebCore/platform/win/WidgetWin.cpp (216298 => 216299)

--- trunk/Source/WebCore/platform/win/WidgetWin.cpp	2017-05-06 00:08:55 UTC (rev 216298)
+++ trunk/Source/WebCore/platform/win/WidgetWin.cpp	2017-05-06 00:17:00 UTC (rev 216299)
@@ -75,7 +75,7 @@
 view->hostWindow()->setCursor(cursor);
 }
 
-void Widget::paint(GraphicsContext&, const IntRect&)
+void Widget::paint(GraphicsContext&, const IntRect&, SecurityOriginPaintPolicy)
 {
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216298] trunk/Source/WTF

[commit-queue]

Title: [216298] trunk/Source/WTF








Revision 216298
Author commit-qu...@webkit.org
Date 2017-05-05 17:08:55 -0700 (Fri, 05 May 2017)


Log Message
[WTF] Do not export deleted constructor in StringView
https://bugs.webkit.org/show_bug.cgi?id=171751

Patch by Don Olmstead  on 2017-05-05
Reviewed by Alexey Proskuryakov.

* wtf/text/StringView.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringView.h




Diff

Modified: trunk/Source/WTF/ChangeLog (216297 => 216298)

--- trunk/Source/WTF/ChangeLog	2017-05-06 00:08:42 UTC (rev 216297)
+++ trunk/Source/WTF/ChangeLog	2017-05-06 00:08:55 UTC (rev 216298)
@@ -1,3 +1,12 @@
+2017-05-05  Don Olmstead  
+
+[WTF] Do not export deleted constructor in StringView
+https://bugs.webkit.org/show_bug.cgi?id=171751
+
+Reviewed by Alexey Proskuryakov.
+
+* wtf/text/StringView.h:
+
 2017-05-05  Yusuke Suzuki  
 
 [GTK][JSCOnly] Merge MainThread implementations and use generic one


Modified: trunk/Source/WTF/wtf/text/StringView.h (216297 => 216298)

--- trunk/Source/WTF/wtf/text/StringView.h	2017-05-06 00:08:42 UTC (rev 216297)
+++ trunk/Source/WTF/wtf/text/StringView.h	2017-05-06 00:08:55 UTC (rev 216298)
@@ -697,7 +697,7 @@
 
 class StringView::GraphemeClusters::Iterator {
 public:
-WTF_EXPORT_PRIVATE Iterator() = delete;
+Iterator() = delete;
 WTF_EXPORT_PRIVATE Iterator(const StringView&, unsigned index);
 WTF_EXPORT_PRIVATE ~Iterator();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216297] trunk

[beidson]

Title: [216297] trunk








Revision 216297
Author beid...@apple.com
Date 2017-05-05 17:08:42 -0700 (Fri, 05 May 2017)


Log Message
API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
 and https://bugs.webkit.org/show_bug.cgi?id=171513

Reviewed by Andy Estes.

Source/WebCore:

Covered by API test.

* platform/spi/cf/CFNetworkSPI.h:

Source/WebKit2:

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::syncAllCookies):

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216296 => 216297)

--- trunk/Source/WebCore/ChangeLog	2017-05-06 00:04:37 UTC (rev 216296)
+++ trunk/Source/WebCore/ChangeLog	2017-05-06 00:08:42 UTC (rev 216297)
@@ -1,3 +1,14 @@
+2017-05-05  Brady Eidson  
+
+API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
+ and https://bugs.webkit.org/show_bug.cgi?id=171513
+
+Reviewed by Andy Estes.
+
+Covered by API test.
+
+* platform/spi/cf/CFNetworkSPI.h:
+
 2017-05-05  Dean Jackson  
 
 Try to fix iOS build.


Modified: trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h (216296 => 216297)

--- trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h	2017-05-06 00:04:37 UTC (rev 216296)
+++ trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h	2017-05-06 00:08:42 UTC (rev 216297)
@@ -170,12 +170,7 @@
 #endif
 
 void CFHTTPCookieStorageDeleteAllCookies(CFHTTPCookieStorageRef);
-
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101300)
 void _CFHTTPCookieStorageFlushCookieStores();
-#else
-void CFHTTPCookieStorageFlushCookieStores();
-#endif
 
 #if PLATFORM(COCOA)
 CFDataRef _CFCachedURLResponseGetMemMappedData(CFCachedURLResponseRef);


Modified: trunk/Source/WebKit2/ChangeLog (216296 => 216297)

--- trunk/Source/WebKit2/ChangeLog	2017-05-06 00:04:37 UTC (rev 216296)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-06 00:08:42 UTC (rev 216297)
@@ -1,3 +1,13 @@
+2017-05-05  Brady Eidson  
+
+API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
+ and https://bugs.webkit.org/show_bug.cgi?id=171513
+
+Reviewed by Andy Estes.
+
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::syncAllCookies):
+
 2017-05-05  Dean Jackson  
 
 Restrict SVG filters to accessible security origins


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (216296 => 216297)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2017-05-06 00:04:37 UTC (rev 216296)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2017-05-06 00:08:42 UTC (rev 216297)
@@ -210,16 +210,10 @@
 
 void NetworkProcess::syncAllCookies()
 {
-// FIXME: Figure out the non-prefixed version of this on newer SDKs
-
-#if !PLATFORM(IOS)
-#if (__MAC_OS_X_VERSION_MIN_REQUIRED < 101300)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
 _CFHTTPCookieStorageFlushCookieStores();
 #pragma clang diagnostic pop
-#endif
-#endif
 }
 
 }


Modified: trunk/Tools/ChangeLog (216296 => 216297)

--- trunk/Tools/ChangeLog	2017-05-06 00:04:37 UTC (rev 216296)
+++ trunk/Tools/ChangeLog	2017-05-06 00:08:42 UTC (rev 216297)
@@ -1,3 +1,13 @@
+2017-05-05  Brady Eidson  
+
+API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
+ and https://bugs.webkit.org/show_bug.cgi?id=171513
+
+Reviewed by Andy Estes.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
+(TEST):
+
 2017-05-05  Brian Burg  
 
 [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm (216296 => 216297)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm	2017-05-06 00:04:37 UTC (rev 216296)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm	2017-05-06 00:08:42 UTC (rev 216297)
@@ -125,14 +125,9 @@
 EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:idbPath.path]);
 EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:defaultIDBPath.path]);
 
-// FIXME (https://bugs.webkit.org/show_bug.cgi?id=171513)
-// Checking the following 3 files on iOS is too flakey when running tests in the iOS-sim.
-// (For the cookie file, at least, it's because we can't sync it to disk)
-#if PLATFORM(MAC)
+[[[webView configuration] processPool] 

[webkit-changes] [216296] trunk/Source/WebCore

[dino]

Title: [216296] trunk/Source/WebCore








Revision 216296
Author d...@apple.com
Date 2017-05-05 17:04:37 -0700 (Fri, 05 May 2017)


Log Message
Try to fix iOS build.

* platform/ios/WidgetIOS.mm:
(WebCore::Widget::paint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WidgetIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216295 => 216296)

--- trunk/Source/WebCore/ChangeLog	2017-05-06 00:03:25 UTC (rev 216295)
+++ trunk/Source/WebCore/ChangeLog	2017-05-06 00:04:37 UTC (rev 216296)
@@ -1,5 +1,12 @@
 2017-05-05  Dean Jackson  
 
+Try to fix iOS build.
+
+* platform/ios/WidgetIOS.mm:
+(WebCore::Widget::paint):
+
+2017-05-05  Dean Jackson  
+
 Restrict SVG filters to accessible security origins
 https://bugs.webkit.org/show_bug.cgi?id=118689
 


Modified: trunk/Source/WebCore/platform/ios/WidgetIOS.mm (216295 => 216296)

--- trunk/Source/WebCore/platform/ios/WidgetIOS.mm	2017-05-06 00:03:25 UTC (rev 216295)
+++ trunk/Source/WebCore/platform/ios/WidgetIOS.mm	2017-05-06 00:04:37 UTC (rev 216296)
@@ -139,7 +139,7 @@
 return view;
 }
 
-void Widget::paint(GraphicsContext& p, const IntRect& r)
+void Widget::paint(GraphicsContext& p, const IntRect& r, SecurityOriginPaintPolicy)
 {
 if (p.paintingDisabled())
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216295] trunk/Source/JavaScriptCore

[commit-queue]

Title: [216295] trunk/Source/_javascript_Core








Revision 216295
Author commit-qu...@webkit.org
Date 2017-05-05 17:03:25 -0700 (Fri, 05 May 2017)


Log Message
[JSC] Remove export from Intrinsic
https://bugs.webkit.org/show_bug.cgi?id=171752

Patch by Don Olmstead  on 2017-05-05
Reviewed by Alexey Proskuryakov.

* runtime/Intrinsic.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Intrinsic.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216294 => 216295)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-05 23:49:41 UTC (rev 216294)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-06 00:03:25 UTC (rev 216295)
@@ -1,3 +1,12 @@
+2017-05-05  Don Olmstead  
+
+[JSC] Remove export from Intrinsic
+https://bugs.webkit.org/show_bug.cgi?id=171752
+
+Reviewed by Alexey Proskuryakov.
+
+* runtime/Intrinsic.h:
+
 2017-05-05  Saam Barati  
 
 putDirectIndex does not properly do defineOwnProperty


Modified: trunk/Source/_javascript_Core/runtime/Intrinsic.h (216294 => 216295)

--- trunk/Source/_javascript_Core/runtime/Intrinsic.h	2017-05-05 23:49:41 UTC (rev 216294)
+++ trunk/Source/_javascript_Core/runtime/Intrinsic.h	2017-05-06 00:03:25 UTC (rev 216295)
@@ -27,7 +27,7 @@
 
 namespace JSC {
 
-enum JS_EXPORT_PRIVATE Intrinsic {
+enum Intrinsic {
 // Call intrinsics.
 NoIntrinsic,
 AbsIntrinsic,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216294] trunk

[dino]

Title: [216294] trunk








Revision 216294
Author d...@apple.com
Date 2017-05-05 16:49:41 -0700 (Fri, 05 May 2017)


Log Message
Restrict SVG filters to accessible security origins
https://bugs.webkit.org/show_bug.cgi?id=118689


Reviewed by Brent Fulgham.

Source/WebCore:

Certain SVG filters should only be allowed to operate
on content that is has SecurityOrigin access to. Implement
this by including a flag in PaintInfo and LayerPaintingInfo,
and have RenderWidget make sure the documents have acceptable
SecurityOrigins as it goes to paint.

This could be used as the first step in a "safe painting"
strategy, allowing some content to be rendered into a
canvas or via the element() CSS function... but it is only
a small first step.

Test: http/tests/css/filters-on-iframes.html

* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
* platform/ScrollView.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::paint):
* platform/Scrollbar.h:
* platform/Widget.h:
* platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::shouldBeRestrictedBySecurityOrigin):
* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::hasFilterThatShouldBeRestrictedBySecurityOrigin):
* platform/graphics/filters/FilterOperations.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
* rendering/FilterEffectRenderer.h:
* rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
* rendering/RenderLayer.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::paint):
* rendering/RenderScrollbar.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paintContents):

Source/WebKit2:

Update parameter lists.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
* WebProcess/Plugins/PluginView.h:

LayoutTests:

Add a test that shows safe frames, unsafe frames, and
then a safe frame that itself has an unsafe frame, to
show that the security requirements are being forwarded
down the tree.

* http/tests/css/filters-on-iframes-expected.html: Added.
* http/tests/css/filters-on-iframes.html: Added.
* http/tests/css/resources/blank.html: Added.
* http/tests/css/resources/references-external.html: Added.
* http/tests/css/resources/solid-red.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/Scrollbar.cpp
trunk/Source/WebCore/platform/Scrollbar.h
trunk/Source/WebCore/platform/Widget.h
trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h
trunk/Source/WebCore/platform/graphics/filters/FilterOperations.cpp
trunk/Source/WebCore/platform/graphics/filters/FilterOperations.h
trunk/Source/WebCore/platform/mac/WidgetMac.mm
trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp
trunk/Source/WebCore/rendering/FilterEffectRenderer.h
trunk/Source/WebCore/rendering/PaintInfo.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderScrollbar.cpp
trunk/Source/WebCore/rendering/RenderScrollbar.h
trunk/Source/WebCore/rendering/RenderWidget.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h


Added Paths

trunk/LayoutTests/http/tests/css/filters-on-iframes-expected.html
trunk/LayoutTests/http/tests/css/filters-on-iframes.html
trunk/LayoutTests/http/tests/css/resources/blank.html
trunk/LayoutTests/http/tests/css/resources/references-external.html
trunk/LayoutTests/http/tests/css/resources/solid-red.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216293 => 216294)

--- trunk/LayoutTests/ChangeLog	2017-05-05 23:46:45 UTC (rev 216293)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 23:49:41 UTC (rev 216294)
@@ -1,3 +1,22 @@
+2017-05-05  Dean Jackson  
+
+Restrict SVG filters to accessible security origins
+https://bugs.webkit.org/show_bug.cgi?id=118689
+
+
+Reviewed by Brent Fulgham.
+
+Add a test that shows safe frames, unsafe frames, and
+then a safe frame that itself has an unsafe frame, to
+show that the security requirements are being forwarded
+down the tree.
+
+* http/tests/css/filters-on-iframes-expected.html: Added.
+* http/tests/css/filters-on-iframes.html: Added.
+* http/tests/css/resources/blank.html: Added.
+* http/tests/css/resources/references-external.html: Added.
+* http/tests/css/resources/solid-red.html: Added.
+
 2017-05-05  Simon Fraser  

[webkit-changes] [216293] trunk/Source/WebCore

[ryanhaddad]

Title: [216293] trunk/Source/WebCore








Revision 216293
Author ryanhad...@apple.com
Date 2017-05-05 16:46:45 -0700 (Fri, 05 May 2017)


Log Message
Unreviewed, rolling out r216273.

This change caused an assertion failure on WK1.

Reverted changeset:

"Crash in ImageFrameCache::decodedSizeChanged() after image
load cancellation"
https://bugs.webkit.org/show_bug.cgi?id=171736
http://trac.webkit.org/changeset/216273

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216292 => 216293)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 23:45:05 UTC (rev 216292)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 23:46:45 UTC (rev 216293)
@@ -1,3 +1,16 @@
+2017-05-05  Ryan Haddad  
+
+Unreviewed, rolling out r216273.
+
+This change caused an assertion failure on WK1.
+
+Reverted changeset:
+
+"Crash in ImageFrameCache::decodedSizeChanged() after image
+load cancellation"
+https://bugs.webkit.org/show_bug.cgi?id=171736
+http://trac.webkit.org/changeset/216273
+
 2017-05-05  Brian Burg  
 
 [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies


Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (216292 => 216293)

--- trunk/Source/WebCore/loader/cache/CachedImage.cpp	2017-05-05 23:45:05 UTC (rev 216292)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp	2017-05-05 23:46:45 UTC (rev 216293)
@@ -360,10 +360,7 @@
 m_imageObserver->remove(*this);
 m_imageObserver = nullptr;
 }
-if (m_image) {
-m_image->setImageObserver(nullptr);
-m_image = nullptr;
-}
+m_image = nullptr;
 }
 
 void CachedImage::addIncrementalDataBuffer(SharedBuffer& data)


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (216292 => 216293)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-05 23:45:05 UTC (rev 216292)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-05 23:46:45 UTC (rev 216293)
@@ -61,8 +61,7 @@
 BitmapImage::~BitmapImage()
 {
 invalidatePlatformData();
-clearTimer();
-m_source.stopAsyncDecodingQueue();
+stopAnimation();
 }
 
 void BitmapImage::updateFromSettings(const Settings& settings)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216292] trunk

[bburg]

Title: [216292] trunk








Revision 216292
Author bb...@apple.com
Date 2017-05-05 16:45:05 -0700 (Fri, 05 May 2017)


Log Message
[Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
https://bugs.webkit.org/show_bug.cgi?id=171748


Reviewed by Michael Catanzaro.

Source/WebCore:

The function that we use to convert from WebCore::Cookie to NSHTTPCookie was
also misusing the NSHTTPCookieDiscard property. If any value is provided for
this key, even @NO, CFNetwork interprets that to mean that the cookie has the
"session" flag.

This is known to affect cookies set via WebCookieManager, WKHTTPCookieStore,
and WebAutomationSession.

This is covered by existing test WebKit2.WKHTTPCookieStore.

* platform/network/cocoa/CookieCocoa.mm:
(WebCore::Cookie::operator NSHTTPCookie *):
Don't include the property if the cookie is not a session cookie.

Tools:

Remove temporary workaround now that the assertion failure is fixed.

* TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216291 => 216292)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 23:39:19 UTC (rev 216291)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 23:45:05 UTC (rev 216292)
@@ -1,3 +1,25 @@
+2017-05-05  Brian Burg  
+
+[Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
+https://bugs.webkit.org/show_bug.cgi?id=171748
+
+
+Reviewed by Michael Catanzaro.
+
+The function that we use to convert from WebCore::Cookie to NSHTTPCookie was
+also misusing the NSHTTPCookieDiscard property. If any value is provided for
+this key, even @NO, CFNetwork interprets that to mean that the cookie has the
+"session" flag.
+
+This is known to affect cookies set via WebCookieManager, WKHTTPCookieStore,
+and WebAutomationSession.
+
+This is covered by existing test WebKit2.WKHTTPCookieStore.
+
+* platform/network/cocoa/CookieCocoa.mm:
+(WebCore::Cookie::operator NSHTTPCookie *):
+Don't include the property if the cookie is not a session cookie.
+
 2017-05-05  Youenn Fablet  
 
 TURNS gathering is not working properly


Modified: trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm (216291 => 216292)

--- trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm	2017-05-05 23:39:19 UTC (rev 216291)
+++ trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm	2017-05-05 23:45:05 UTC (rev 216292)
@@ -98,7 +98,9 @@
 if (secure)
 [properties setObject:@YES forKey:NSHTTPCookieSecure];
 
-[properties setObject:(session ? @"TRUE" : @"FALSE") forKey:NSHTTPCookieDiscard];
+if (session)
+[properties setObject:@YES forKey:NSHTTPCookieDiscard];
+
 [properties setObject:@"1" forKey:NSHTTPCookieVersion];
 
 return [NSHTTPCookie cookieWithProperties:properties];


Modified: trunk/Tools/ChangeLog (216291 => 216292)

--- trunk/Tools/ChangeLog	2017-05-05 23:39:19 UTC (rev 216291)
+++ trunk/Tools/ChangeLog	2017-05-05 23:45:05 UTC (rev 216292)
@@ -1,3 +1,16 @@
+2017-05-05  Brian Burg  
+
+[Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
+https://bugs.webkit.org/show_bug.cgi?id=171748
+
+
+Reviewed by Michael Catanzaro.
+
+Remove temporary workaround now that the assertion failure is fixed.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
+(TEST):
+
 2017-05-05  Simon Fraser  
 
 Make it possible to test rotation in iOS WebKitTestRunner


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm (216291 => 216292)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm	2017-05-05 23:39:19 UTC (rev 216291)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm	2017-05-05 23:45:05 UTC (rev 216292)
@@ -131,8 +131,7 @@
 ASSERT_TRUE([cookie2.get().name isEqualToString:cookie.name]);
 ASSERT_TRUE([cookie2.get().domain isEqualToString:cookie.domain]);
 ASSERT_FALSE(cookie.secure);
-// FIXME: this should be ASSERT_FALSE. Investigating in .
-ASSERT_TRUE(cookie.sessionOnly);
+ASSERT_FALSE(cookie.sessionOnly);
 }
 }
 [cookies release];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216291] trunk

[simon . fraser]

Title: [216291] trunk








Revision 216291
Author simon.fra...@apple.com
Date 2017-05-05 16:39:19 -0700 (Fri, 05 May 2017)


Log Message
Make it possible to test rotation in iOS WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=171755

Reviewed by Tim Horton.

Tools:

Add to UIScriptController:
void simulateRotation(DeviceOrientation orientation, object callback);
void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);

The former just does a view resize, as a simple WKWebView app would do. The second does
animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
layout size and interface orientation. The two behaviors produce different resize and
orientationchange events and sizes, and both need to be tested.

Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
which is now a custom subclass (PlatformWebViewController).

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::simulateRotation):
(WTR::UIScriptController::simulateRotationLikeSafari):
* DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::simulateRotation):
(WTR::UIScriptController::simulateRotationLikeSafari):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::toDeviceOrientation):
(WTR::UIScriptController::simulateRotation):
(WTR::UIScriptController::simulateRotationLikeSafari):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView _didEndRotation]):
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::toUIDeviceOrientation):
(WTR::UIScriptController::simulateRotation):
(WTR::UIScriptController::simulateRotationLikeSafari):
(WTR::UIScriptController::platformClearAllCallbacks):
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::simulateRotation):
(WTR::UIScriptController::simulateRotationLikeSafari):

LayoutTests:

Two rotation tests and one that comes last to ensure that the device was not left in a rotated state.

* fast/events/ios/rotation/basic-rotation-expected.txt: Added.
* fast/events/ios/rotation/basic-rotation.html: Added.
* fast/events/ios/rotation/safari-like-rotation-expected.txt: Added.
* fast/events/ios/rotation/safari-like-rotation.html: Added.
* fast/events/ios/rotation/zz-no-rotation-expected.txt: Added.
* fast/events/ios/rotation/zz-no-rotation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/UIScriptControllerIOS.mm
trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.mm
trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h
trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm
trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm
trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
trunk/Tools/WebKitTestRunner/ios/UIKitSPI.h
trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm


Added Paths

trunk/LayoutTests/fast/events/ios/rotation/
trunk/LayoutTests/fast/events/ios/rotation/basic-rotation-expected.txt
trunk/LayoutTests/fast/events/ios/rotation/basic-rotation.html
trunk/LayoutTests/fast/events/ios/rotation/safari-like-rotation-expected.txt
trunk/LayoutTests/fast/events/ios/rotation/safari-like-rotation.html
trunk/LayoutTests/fast/events/ios/rotation/zz-no-rotation-expected.txt
trunk/LayoutTests/fast/events/ios/rotation/zz-no-rotation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216290 => 216291)

--- trunk/LayoutTests/ChangeLog	2017-05-05 23:33:04 UTC (rev 216290)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 23:39:19 UTC (rev 216291)
@@ -1,3 +1,19 @@
+2017-05-05  Simon Fraser  
+
+Make it possible to test rotation in iOS WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=171755
+
+Reviewed by Tim Horton.
+
+Two rotation tests and one that comes last to ensure that the device was not left in a rotated state.
+
+* fast/events/ios/rotation/basic-rotation-expected.txt: Added.
+* fast/events/ios/rotation/basic-rotation.html: Added.
+* fast/events/ios/rotation/safari-like-rotation-expected.txt: Added.
+* fast/events/ios/rotation/safari-like-rotation.html: Added.
+* 

[webkit-changes] [216290] trunk/Source/WebKit2

[bdakin]

Title: [216290] trunk/Source/WebKit2








Revision 216290
Author bda...@apple.com
Date 2017-05-05 16:33:04 -0700 (Fri, 05 May 2017)


Log Message
Ensure NSColorPickerTouchBarItem only uses sRGB colors
https://bugs.webkit.org/show_bug.cgi?id=171758
-and corresponding-
rdar://problem/28314183

Reviewed by Tim Horton.

* UIProcess/Cocoa/WebViewImpl.mm:
(-[WKTextTouchBarItemController itemForIdentifier:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216289 => 216290)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 23:26:01 UTC (rev 216289)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 23:33:04 UTC (rev 216290)
@@ -1,3 +1,15 @@
+2017-05-05  Beth Dakin  
+
+Ensure NSColorPickerTouchBarItem only uses sRGB colors
+https://bugs.webkit.org/show_bug.cgi?id=171758
+-and corresponding-
+rdar://problem/28314183
+
+Reviewed by Tim Horton.
+
+* UIProcess/Cocoa/WebViewImpl.mm:
+(-[WKTextTouchBarItemController itemForIdentifier:]):
+
 2017-05-05  Brent Fulgham  
 
 [WK2][iOS][macOS] Expand sandbox to access vm.footprint_suspend 


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm (216289 => 216290)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm	2017-05-05 23:26:01 UTC (rev 216289)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm	2017-05-05 23:33:04 UTC (rev 216290)
@@ -674,6 +674,9 @@
 colorPickerItem.target = self;
 colorPickerItem.action = ""
 colorPickerItem.showsAlpha = NO;
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
+colorPickerItem.allowedColorSpaces = @[ [NSColorSpace sRGBColorSpace] ];
+#endif
 }
 
 return item;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216289] trunk/LayoutTests

[ryanhaddad]

Title: [216289] trunk/LayoutTests








Revision 216289
Author ryanhad...@apple.com
Date 2017-05-05 16:26:01 -0700 (Fri, 05 May 2017)


Log Message
Mark http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171756

Unreviewed test gardening.

* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216288 => 216289)

--- trunk/LayoutTests/ChangeLog	2017-05-05 22:56:29 UTC (rev 216288)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 23:26:01 UTC (rev 216289)
@@ -1,3 +1,12 @@
+2017-05-05  Ryan Haddad  
+
+Mark http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171756
+
+Unreviewed test gardening.
+
+* platform/wk2/TestExpectations:
+
 2017-05-05  Matt Lewis  
 
 Mark test http/tests/security/module-correct-mime-types.html slow.


Modified: trunk/LayoutTests/platform/wk2/TestExpectations (216288 => 216289)

--- trunk/LayoutTests/platform/wk2/TestExpectations	2017-05-05 22:56:29 UTC (rev 216288)
+++ trunk/LayoutTests/platform/wk2/TestExpectations	2017-05-05 23:26:01 UTC (rev 216289)
@@ -695,7 +695,7 @@
 http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction.html [ Pass ]
 http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html [ Pass ]
 http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction.html [ Pass ]
-http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction-timeout.html [ Pass ]
+webkit.org/b/171756 http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction-timeout.html [ Pass Failure ]
 http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-mixed-statistics.html [ Pass ]
 http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins.html [ Pass ]
 http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-under-top-frame-origins.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216288] trunk/Tools

[jbedard]

Title: [216288] trunk/Tools








Revision 216288
Author jbed...@apple.com
Date 2017-05-05 15:56:29 -0700 (Fri, 05 May 2017)


Log Message
Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=168945


Reviewed by David Kilzer.

Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
target SDK. These two changes must happen simultaneously because some archives will
clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.

* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
* DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
tools directory still includes ImageDiff.
* DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
* Scripts/webkitpy/port/darwin.py:
(DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
locally or when running archives.
* Scripts/webkitpy/port/image_diff.py:
(IOSSimulatorImageDiffer): Deleted.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.diff_image): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/DumpRenderTree/PlatformWin.cmake
trunk/Tools/Scripts/webkitpy/port/darwin.py
trunk/Tools/Scripts/webkitpy/port/image_diff.py
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py


Removed Paths

trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp
trunk/Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig




Diff

Modified: trunk/Tools/ChangeLog (216287 => 216288)

--- trunk/Tools/ChangeLog	2017-05-05 22:53:09 UTC (rev 216287)
+++ trunk/Tools/ChangeLog	2017-05-05 22:56:29 UTC (rev 216288)
@@ -1,3 +1,28 @@
+2017-05-05  Jonathan Bedard  
+
+Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=168945
+
+
+Reviewed by David Kilzer.
+
+Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
+target SDK. These two changes must happen simultaneously because some archives will
+clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
+
+* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
+* DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
+tools directory still includes ImageDiff.
+* DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
+* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
+* Scripts/webkitpy/port/darwin.py: 
+(DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
+locally or when running archives.
+* Scripts/webkitpy/port/image_diff.py:
+(IOSSimulatorImageDiffer): Deleted.
+* Scripts/webkitpy/port/ios_simulator.py:
+(IOSSimulatorPort.diff_image): Deleted.
+
 2017-05-05  Brian Burg  
 
 API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (216287 => 216288)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-05 22:53:09 UTC (rev 216287)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-05 22:56:29 UTC (rev 216288)
@@ -27,7 +27,6 @@
 CEB754D41BBDA26D009F0401 /* PBXTargetDependency */,
 2D403F211508736C005358D2 /* PBXTargetDependency */,
 A134E52D188FC09200901D06 /* PBXTargetDependency */,
-A84F608F08B1370E00E9745F /* PBXTargetDependency */,
 141BF238096A451E00E0753C /* PBXTargetDependency */,
 			);
 			name = All;
@@ -80,7 +79,7 @@
 		2D403F1B15087209005358D2 /* LayoutTestHelper.m in Sources */ = {isa = PBXBuildFile; fileRef = 2D403EA215087142005358D2 /* LayoutTestHelper.m */; };
 		2DA2E3A51E1BA54100A3BBD0 /* DumpRenderTreeSpellChecker.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2DA2E3A41E1BA54100A3BBD0 /* DumpRenderTreeSpellChecker.mm */; };
 		31117B3D15D9A56A00163BC8 /* MockWebNotificationProvider.mm in Sources */ = {isa = PBXBuildFile; fileRef = 31117B3B15D9A56A00163BC8 /* MockWebNotificationProvider.mm */; };
-		312943F91E71F2B4001EE2CC /* IOOSLayoutTestCommunication.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3148A0551E6F90F400D3B316 /* IOSLayoutTestCommunication.cpp */; };
+		312943F91E71F2B4001EE2CC /* IOSLayoutTestCommunication.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3148A0551E6F90F400D3B316 /* IOSLayoutTestCommunication.cpp */; };
 		4464CABE1C20A08B00E5BB55 /* DumpRenderTreeAppMain.mm in Sources */ = {isa = PBXBuildFile; fileRef = 4464CABD1C20A07000E5BB55 /* DumpRenderTreeAppMain.mm */; };
 		4AD6A11413C8124000EA9737 /* FormValue.cpp in Sources */ = {isa = PBXBuildFile; 

[webkit-changes] [216287] tags/Safari-604.1.21.0.1/Source

[matthew_hanson]

Title: [216287] tags/Safari-604.1.21.0.1/Source








Revision 216287
Author matthew_han...@apple.com
Date 2017-05-05 15:53:09 -0700 (Fri, 05 May 2017)


Log Message
Versioning.

Modified Paths

tags/Safari-604.1.21.0.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-604.1.21.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-604.1.21.0.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-604.1.21.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-604.1.21.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-604.1.21.0.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-604.1.21.0.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-604.1.21.0.1/Source/_javascript_Core/Configurations/Version.xcconfig (216286 => 216287)

--- tags/Safari-604.1.21.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-05 22:53:05 UTC (rev 216286)
+++ tags/Safari-604.1.21.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-05 22:53:09 UTC (rev 216287)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (216286 => 216287)

--- tags/Safari-604.1.21.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-05 22:53:05 UTC (rev 216286)
+++ tags/Safari-604.1.21.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-05 22:53:09 UTC (rev 216287)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21.0.1/Source/WebCore/Configurations/Version.xcconfig (216286 => 216287)

--- tags/Safari-604.1.21.0.1/Source/WebCore/Configurations/Version.xcconfig	2017-05-05 22:53:05 UTC (rev 216286)
+++ tags/Safari-604.1.21.0.1/Source/WebCore/Configurations/Version.xcconfig	2017-05-05 22:53:09 UTC (rev 216287)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig (216286 => 216287)

--- tags/Safari-604.1.21.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-05 22:53:05 UTC (rev 216286)
+++ tags/Safari-604.1.21.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-05 22:53:09 UTC (rev 216287)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig (216286 => 216287)

--- tags/Safari-604.1.21.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-05 22:53:05 UTC (rev 216286)
+++ tags/Safari-604.1.21.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-05 22:53:09 UTC (rev 216287)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-604.1.21.0.1/Source/WebKit/mac/Configurations/Version.xcconfig (216286 => 216287)

--- tags/Safari-604.1.21.0.1/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-05 22:53:05 UTC (rev 216286)
+++ tags/Safari-604.1.21.0.1/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-05 

[webkit-changes] [216286] tags/Safari-604.1.21.0.1/Source

[matthew_hanson]

Title: [216286] tags/Safari-604.1.21.0.1/Source








Revision 216286
Author matthew_han...@apple.com
Date 2017-05-05 15:53:05 -0700 (Fri, 05 May 2017)


Log Message
Cherry-pick r216229. rdar://problem/31978703

Modified Paths

tags/Safari-604.1.21.0.1/Source/WebCore/ChangeLog
tags/Safari-604.1.21.0.1/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
tags/Safari-604.1.21.0.1/Source/WebKit/mac/ChangeLog
tags/Safari-604.1.21.0.1/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: tags/Safari-604.1.21.0.1/Source/WebCore/ChangeLog (216285 => 216286)

--- tags/Safari-604.1.21.0.1/Source/WebCore/ChangeLog	2017-05-05 22:50:56 UTC (rev 216285)
+++ tags/Safari-604.1.21.0.1/Source/WebCore/ChangeLog	2017-05-05 22:53:05 UTC (rev 216286)
@@ -1,3 +1,24 @@
+2017-05-05  Matthew Hanson  
+
+Cherry-pick r216229. rdar://problem/31978703
+
+2017-05-04  Jeremy Jones  
+
+UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
+https://bugs.webkit.org/show_bug.cgi?id=171704
+
+Reviewed by Jer Noble.
+
+No new tests because no behavior change.
+
+Fix build by casting result of +clearColor to UIColor.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(clearUIColor):
+(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
+(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
+(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):
+
 2017-05-03  John Wilander  
 
 Resource Load Statistics: Remove all statistics for modifiedSince website data removals


Modified: tags/Safari-604.1.21.0.1/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (216285 => 216286)

--- tags/Safari-604.1.21.0.1/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-05-05 22:50:56 UTC (rev 216285)
+++ tags/Safari-604.1.21.0.1/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-05-05 22:53:05 UTC (rev 216286)
@@ -75,6 +75,11 @@
 SOFT_LINK_CLASS(UIKit, UIColor)
 SOFT_LINK_CONSTANT(UIKit, UIRemoteKeyboardLevel, UIWindowLevel)
 
+static UIColor *clearUIColor()
+{
+return (UIColor *)[getUIColorClass() clearColor];
+}
+
 #if !LOG_DISABLED
 static const char* boolString(bool val)
 {
@@ -602,7 +607,7 @@
 if (![[parentView window] _isHostedInAnotherProcess]) {
 if (!m_window)
 m_window = adoptNS([allocUIWindowInstance() initWithFrame:[[getUIScreenClass() mainScreen] bounds]]);
-[m_window setBackgroundColor:[getUIColorClass() clearColor]];
+[m_window setBackgroundColor:clearUIColor()];
 if (!m_viewController)
 m_viewController = adoptNS([allocUIViewControllerInstance() init]);
 [[m_viewController view] setFrame:[m_window bounds]];
@@ -615,7 +620,7 @@
 if (!m_playerLayerView)
 m_playerLayerView = adoptNS([[getWebAVPlayerLayerViewClass() alloc] init]);
 [m_playerLayerView setHidden:[playerController() isExternalPlaybackActive]];
-[m_playerLayerView setBackgroundColor:[getUIColorClass() clearColor]];
+[m_playerLayerView setBackgroundColor:clearUIColor()];
 
 if (!isInPictureInPictureMode) {
 [m_playerLayerView setVideoView:];
@@ -646,7 +651,7 @@
 
 [m_playerViewController view].frame = [parentView convertRect:initialRect toView:[m_playerViewController view].superview];
 
-[[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
+[[m_playerViewController view] setBackgroundColor:clearUIColor()];
 [[m_playerViewController view] setAutoresizingMask:(UIViewAutoresizingFlexibleBottomMargin | UIViewAutoresizingFlexibleRightMargin)];
 
 [[m_playerViewController view] setNeedsLayout];
@@ -748,8 +753,8 @@
 
 [CATransaction begin];
 [CATransaction setDisableActions:YES];
-[m_playerLayerView setBackgroundColor:[getUIColorClass() clearColor]];
-[[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
+[m_playerLayerView setBackgroundColor:clearUIColor()];
+[[m_playerViewController view] setBackgroundColor:clearUIColor()];
 [CATransaction commit];
 
 dispatch_async(dispatch_get_main_queue(), [protectedThis, this]() {
@@ -930,8 +935,8 @@
 
 m_exitCompleted = true;
 
-[m_playerLayerView setBackgroundColor:[getUIColorClass() clearColor]];
-[[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
+[m_playerLayerView setBackgroundColor:clearUIColor()];
+[[m_playerViewController view] setBackgroundColor:clearUIColor()];
 
 clearMode(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture);
 


Modified: tags/Safari-604.1.21.0.1/Source/WebKit/mac/ChangeLog (216285 => 216286)

--- tags/Safari-604.1.21.0.1/Source/WebKit/mac/ChangeLog	2017-05-05 22:50:56 UTC 

[webkit-changes] [216285] trunk/Source/WebCore

[commit-queue]

Title: [216285] trunk/Source/WebCore








Revision 216285
Author commit-qu...@webkit.org
Date 2017-05-05 15:50:56 -0700 (Fri, 05 May 2017)


Log Message
TURNS gathering is not working properly
https://bugs.webkit.org/show_bug.cgi?id=171747

Patch by Youenn Fablet  on 2017-05-05
Reviewed by Eric Carlson.

Did manual testing on real TURNS servers.

* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::configurationFromMediaEndpointConfiguration): Disabling TURNS servers gathering.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216284 => 216285)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 22:48:59 UTC (rev 216284)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 22:50:56 UTC (rev 216285)
@@ -1,3 +1,15 @@
+2017-05-05  Youenn Fablet  
+
+TURNS gathering is not working properly
+https://bugs.webkit.org/show_bug.cgi?id=171747
+
+Reviewed by Eric Carlson.
+
+Did manual testing on real TURNS servers.
+
+* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
+(WebCore::configurationFromMediaEndpointConfiguration): Disabling TURNS servers gathering.
+
 2017-05-05  Ryan Haddad  
 
 Unreviewed, rolling out r216275.


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp (216284 => 216285)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp	2017-05-05 22:48:59 UTC (rev 216284)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp	2017-05-05 22:50:56 UTC (rev 216285)
@@ -88,9 +88,14 @@
 webrtc::PeerConnectionInterface::IceServer iceServer;
 iceServer.username = server.username.utf8().data();
 iceServer.password = server.credential.utf8().data();
-for (auto& url : server.urls)
-iceServer.urls.push_back({ url.string().utf8().data() });
-rtcConfiguration.servers.push_back(WTFMove(iceServer));
+for (auto& url : server.urls) {
+// FIXME: If TURNS is failing, the whole ICE candidate gathering is failing.
+// We should fix that and reactivate TURNS gathering.
+if (!url.protocolIs("turns"))
+iceServer.urls.push_back({ url.string().utf8().data() });
+}
+if (iceServer.urls.size())
+rtcConfiguration.servers.push_back(WTFMove(iceServer));
 }
 
 rtcConfiguration.ice_candidate_pool_size = configuration.iceCandidatePoolSize;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216284] tags/Safari-604.1.21.0.1/

[matthew_hanson]

Title: [216284] tags/Safari-604.1.21.0.1/








Revision 216284
Author matthew_han...@apple.com
Date 2017-05-05 15:48:59 -0700 (Fri, 05 May 2017)


Log Message
New tag.

Added Paths

tags/Safari-604.1.21.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216283] tags/Safari-604.1.22/

[matthew_hanson]

Title: [216283] tags/Safari-604.1.22/








Revision 216283
Author matthew_han...@apple.com
Date 2017-05-05 15:48:20 -0700 (Fri, 05 May 2017)


Log Message
Delete tag.

Removed Paths

tags/Safari-604.1.22/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216281] tags/Safari-604.1.21/Source

[matthew_hanson]

Title: [216281] tags/Safari-604.1.21/Source








Revision 216281
Author matthew_han...@apple.com
Date 2017-05-05 15:45:57 -0700 (Fri, 05 May 2017)


Log Message
Revert r216270.

Modified Paths

tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig (216280 => 216281)

--- tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-05 22:43:43 UTC (rev 216280)
+++ tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-05 22:45:57 UTC (rev 216281)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (216280 => 216281)

--- tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-05 22:43:43 UTC (rev 216280)
+++ tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-05 22:45:57 UTC (rev 216281)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig (216280 => 216281)

--- tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig	2017-05-05 22:43:43 UTC (rev 216280)
+++ tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig	2017-05-05 22:45:57 UTC (rev 216281)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig (216280 => 216281)

--- tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-05 22:43:43 UTC (rev 216280)
+++ tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-05 22:45:57 UTC (rev 216281)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig (216280 => 216281)

--- tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-05 22:43:43 UTC (rev 216280)
+++ tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-05 22:45:57 UTC (rev 216281)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig (216280 => 216281)

--- tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-05 22:43:43 UTC (rev 216280)
+++ tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-05 22:45:57 UTC (rev 216281)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;

[webkit-changes] [216282] tags/Safari-604.1.21/Source

[matthew_hanson]

Title: [216282] tags/Safari-604.1.21/Source








Revision 216282
Author matthew_han...@apple.com
Date 2017-05-05 15:46:02 -0700 (Fri, 05 May 2017)


Log Message
Revert r216268. rdar://problem/31978703

Modified Paths

tags/Safari-604.1.21/Source/WebCore/ChangeLog
tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
tags/Safari-604.1.21/Source/WebKit/mac/ChangeLog
tags/Safari-604.1.21/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: tags/Safari-604.1.21/Source/WebCore/ChangeLog (216281 => 216282)

--- tags/Safari-604.1.21/Source/WebCore/ChangeLog	2017-05-05 22:45:57 UTC (rev 216281)
+++ tags/Safari-604.1.21/Source/WebCore/ChangeLog	2017-05-05 22:46:02 UTC (rev 216282)
@@ -1,38 +1,21 @@
 2017-05-05  Matthew Hanson  
 
-Cherry-pick r216229. rdar://problem/31978703
+Revert r216268. rdar://problem/31978703
 
-2017-05-04  Jeremy Jones  
+2017-05-03  John Wilander  
 
-UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
-https://bugs.webkit.org/show_bug.cgi?id=171704
+Resource Load Statistics: Remove all statistics for modifiedSince website data removals
+https://bugs.webkit.org/show_bug.cgi?id=171584
+
 
-Reviewed by Jer Noble.
+Reviewed by Brent Fulgham.
 
-No new tests because no behavior change.
+Test: http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html
 
-Fix build by casting result of +clearColor to UIColor.
+* loader/ResourceLoadObserver.cpp:
+(WebCore::ResourceLoadObserver::clearInMemoryAndPersistentStore):
+Now clears all regardless of the modifiedSince parameter's value.
 
-* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
-(clearUIColor):
-(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
-(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
-(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):
-
-2017-05-03  John Wilander  
-
-Resource Load Statistics: Remove all statistics for modifiedSince website data removals
-https://bugs.webkit.org/show_bug.cgi?id=171584
-
-
-Reviewed by Brent Fulgham.
-
-Test: http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html
-
-* loader/ResourceLoadObserver.cpp:
-(WebCore::ResourceLoadObserver::clearInMemoryAndPersistentStore):
-Now clears all regardless of the modifiedSince parameter's value.
-
 2017-05-03  Andy Estes  
 
 Try to fix the macOS Public SDK build


Modified: tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (216281 => 216282)

--- tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-05-05 22:45:57 UTC (rev 216281)
+++ tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-05-05 22:46:02 UTC (rev 216282)
@@ -75,11 +75,6 @@
 SOFT_LINK_CLASS(UIKit, UIColor)
 SOFT_LINK_CONSTANT(UIKit, UIRemoteKeyboardLevel, UIWindowLevel)
 
-static UIColor *clearUIColor()
-{
-return (UIColor *)[getUIColorClass() clearColor];
-}
-
 #if !LOG_DISABLED
 static const char* boolString(bool val)
 {
@@ -607,7 +602,7 @@
 if (![[parentView window] _isHostedInAnotherProcess]) {
 if (!m_window)
 m_window = adoptNS([allocUIWindowInstance() initWithFrame:[[getUIScreenClass() mainScreen] bounds]]);
-[m_window setBackgroundColor:clearUIColor()];
+[m_window setBackgroundColor:[getUIColorClass() clearColor]];
 if (!m_viewController)
 m_viewController = adoptNS([allocUIViewControllerInstance() init]);
 [[m_viewController view] setFrame:[m_window bounds]];
@@ -620,7 +615,7 @@
 if (!m_playerLayerView)
 m_playerLayerView = adoptNS([[getWebAVPlayerLayerViewClass() alloc] init]);
 [m_playerLayerView setHidden:[playerController() isExternalPlaybackActive]];
-[m_playerLayerView setBackgroundColor:clearUIColor()];
+[m_playerLayerView setBackgroundColor:[getUIColorClass() clearColor]];
 
 if (!isInPictureInPictureMode) {
 [m_playerLayerView setVideoView:];
@@ -651,7 +646,7 @@
 
 [m_playerViewController view].frame = [parentView convertRect:initialRect toView:[m_playerViewController view].superview];
 
-[[m_playerViewController view] setBackgroundColor:clearUIColor()];
+[[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
 [[m_playerViewController view] setAutoresizingMask:(UIViewAutoresizingFlexibleBottomMargin | UIViewAutoresizingFlexibleRightMargin)];
 
 [[m_playerViewController view] setNeedsLayout];
@@ -753,8 +748,8 @@
 
 [CATransaction begin];
 

[webkit-changes] [216280] trunk/LayoutTests

[ryanhaddad]

Title: [216280] trunk/LayoutTests








Revision 216280
Author ryanhad...@apple.com
Date 2017-05-05 15:43:43 -0700 (Fri, 05 May 2017)


Log Message
Mark test http/tests/security/module-correct-mime-types.html slow.
https://bugs.webkit.org/show_bug.cgi?id=164960

Unreviewed test gardening.

Patch by Matt Lewis  on 2017-05-05

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216279 => 216280)

--- trunk/LayoutTests/ChangeLog	2017-05-05 22:35:31 UTC (rev 216279)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 22:43:43 UTC (rev 216280)
@@ -1,3 +1,12 @@
+2017-05-05  Matt Lewis  
+
+Mark test http/tests/security/module-correct-mime-types.html slow.
+https://bugs.webkit.org/show_bug.cgi?id=164960
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2017-05-05  Ryan Haddad  
 
 Unreviewed, rolling out r216275.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216279 => 216280)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-05 22:35:31 UTC (rev 216279)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-05 22:43:43 UTC (rev 216280)
@@ -1918,7 +1918,7 @@
 
 webkit.org/b/163362 [ Debug ] platform/ios/ios/plugin/youtube-flash-plugin-iframe.html [ Pass Failure ]
 
-webkit.org/b/164960 [ Release ] http/tests/security/module-correct-mime-types.html [ Slow ]
+webkit.org/b/164960 http/tests/security/module-correct-mime-types.html [ Slow ]
 
 webkit.org/b/164961 [ Release ] http/tests/storage/callbacks-are-called-in-correct-context.html [ Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216278] trunk

[ryanhaddad]

Title: [216278] trunk








Revision 216278
Author ryanhad...@apple.com
Date 2017-05-05 15:30:03 -0700 (Fri, 05 May 2017)


Log Message
Unreviewed, rolling out r216275.

This change broke internal builds.

Reverted changeset:

"[Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not
case insensitive"
https://bugs.webkit.org/show_bug.cgi?id=171636
http://trac.webkit.org/changeset/216275

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
trunk/Source/WebCore/platform/spi/cocoa/CoreTextSPI.h


Removed Paths

trunk/LayoutTests/fast/text/lastResort-expected.html
trunk/LayoutTests/fast/text/lastResort.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216277 => 216278)

--- trunk/LayoutTests/ChangeLog	2017-05-05 22:23:51 UTC (rev 216277)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 22:30:03 UTC (rev 216278)
@@ -1,3 +1,16 @@
+2017-05-05  Ryan Haddad  
+
+Unreviewed, rolling out r216275.
+
+This change broke internal builds.
+
+Reverted changeset:
+
+"[Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not
+case insensitive"
+https://bugs.webkit.org/show_bug.cgi?id=171636
+http://trac.webkit.org/changeset/216275
+
 2017-05-05  Myles C. Maxfield  
 
 [Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not case insensitive


Deleted: trunk/LayoutTests/fast/text/lastResort-expected.html (216277 => 216278)

--- trunk/LayoutTests/fast/text/lastResort-expected.html	2017-05-05 22:23:51 UTC (rev 216277)
+++ trunk/LayoutTests/fast/text/lastResort-expected.html	2017-05-05 22:30:03 UTC (rev 216278)
@@ -1,9 +0,0 @@
-
-
-
-
-
-This test makes sure that Last Resort is always looked up correctly.
-hi
-
-


Deleted: trunk/LayoutTests/fast/text/lastResort.html (216277 => 216278)

--- trunk/LayoutTests/fast/text/lastResort.html	2017-05-05 22:23:51 UTC (rev 216277)
+++ trunk/LayoutTests/fast/text/lastResort.html	2017-05-05 22:30:03 UTC (rev 216278)
@@ -1,9 +0,0 @@
-
-
-
-
-
-This test makes sure that Last Resort is always looked up correctly.
-hi
-
-


Modified: trunk/Source/WebCore/ChangeLog (216277 => 216278)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 22:23:51 UTC (rev 216277)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 22:30:03 UTC (rev 216278)
@@ -1,3 +1,16 @@
+2017-05-05  Ryan Haddad  
+
+Unreviewed, rolling out r216275.
+
+This change broke internal builds.
+
+Reverted changeset:
+
+"[Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not
+case insensitive"
+https://bugs.webkit.org/show_bug.cgi?id=171636
+http://trac.webkit.org/changeset/216275
+
 2017-05-05  Myles C. Maxfield  
 
 [Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not case insensitive


Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (216277 => 216278)

--- trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2017-05-05 22:23:51 UTC (rev 216277)
+++ trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2017-05-05 22:30:03 UTC (rev 216278)
@@ -164,17 +164,6 @@
 return adoptCF(CTFontCreateWithFontDescriptor(monospaceFontDescriptor.get(), size, nullptr));
 }
 
-if (equalLettersIgnoringASCIICase(family, "lastresort")) {
-#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 11
-static NeverDestroyed lastResort = adoptCF(CTFontDescriptorCreateLastResort());
-return adoptCF(CTFontCreateWithFontDescriptor(lastResort.get().get(), size, nullptr));
-#else
-// LastResort is special, so it's important to look this exact string up, and not some case-folded version.
-// We handle this here so any caching and case folding we do in our general text codepath is bypassed.
-return adoptCF(CTFontCreateWithName(CFSTR("LastResort"), size, nullptr));
-#endif
-}
-
 return nullptr;
 }
 


Modified: trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm (216277 => 216278)

--- trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm	2017-05-05 22:23:51 UTC (rev 216277)
+++ trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm	2017-05-05 22:30:03 UTC (rev 216278)
@@ -111,17 +111,6 @@
 if (equalLettersIgnoringASCIICase(family, "-apple-status-bar"))
 return toCTFont([NSFont labelFontOfSize:size]);
 
-if (equalLettersIgnoringASCIICase(family, "lastresort")) {
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
-static NeverDestroyed lastResort = adoptCF(CTFontDescriptorCreateLastResort());
-return adoptCF(CTFontCreateWithFontDescriptor(lastResort.get().get(), size, nullptr));
-#else
-// LastResort is special, so it's important to look this exact string up, and not some case-folded version.
-// We handle this here so any caching and case 

[webkit-changes] [216277] trunk/Source/WebKit2

[bfulgham]

Title: [216277] trunk/Source/WebKit2








Revision 216277
Author bfulg...@apple.com
Date 2017-05-05 15:23:51 -0700 (Fri, 05 May 2017)


Log Message
[WK2][iOS][macOS] Expand sandbox to access vm.footprint_suspend 
https://bugs.webkit.org/show_bug.cgi?id=171749


Reviewed by Geoffrey Garen.

The 'sysctl' whitelist needs to be extended to support an additional VM-related feature.

* DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in
trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in
trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb
trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216276 => 216277)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 22:03:18 UTC (rev 216276)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 22:23:51 UTC (rev 216277)
@@ -1,3 +1,21 @@
+2017-05-05  Brent Fulgham  
+
+[WK2][iOS][macOS] Expand sandbox to access vm.footprint_suspend 
+https://bugs.webkit.org/show_bug.cgi?id=171749
+
+
+Reviewed by Geoffrey Garen.
+
+The 'sysctl' whitelist needs to be extended to support an additional VM-related feature.
+
+* DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
+* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2017-05-05  John Wilander  
 
 Resource Load Statistics: Don't cover in-memory and disk caches during website data removal


Modified: trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in (216276 => 216277)

--- trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in	2017-05-05 22:03:18 UTC (rev 216276)
+++ trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in	2017-05-05 22:23:51 UTC (rev 216277)
@@ -39,7 +39,8 @@
 "hw.availcpu"
 "hw.ncpu"
 "hw.model"
-"kern.memorystatus_level"))
+"kern.memorystatus_level"
+"vm.footprint_suspend"))
 
 (deny iokit-get-properties)
 #endif


Modified: trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (216276 => 216277)

--- trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2017-05-05 22:03:18 UTC (rev 216276)
+++ trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2017-05-05 22:23:51 UTC (rev 216277)
@@ -39,7 +39,8 @@
 "hw.availcpu"
 "hw.ncpu"
 "hw.model"
-"kern.memorystatus_level"))
+"kern.memorystatus_level"
+"vm.footprint_suspend"))
 
 (deny iokit-get-properties)
 #endif


Modified: trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (216276 => 216277)

--- trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in	2017-05-05 22:03:18 UTC (rev 216276)
+++ trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in	2017-05-05 22:23:51 UTC (rev 216277)
@@ -39,7 +39,8 @@
 "hw.availcpu"
 "hw.ncpu"
 "hw.model"
-"kern.memorystatus_level"))
+"kern.memorystatus_level"
+"vm.footprint_suspend"))
 
 (deny iokit-get-properties)
 (allow iokit-get-properties


Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb (216276 => 216277)

--- trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb	2017-05-05 22:03:18 UTC (rev 216276)
+++ trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb	2017-05-05 22:23:51 UTC (rev 216277)
@@ -36,4 +36,5 @@
 "hw.availcpu"
 "hw.ncpu"
 "hw.model"
-"kern.memorystatus_level"))
+"kern.memorystatus_level"
+"vm.footprint_suspend"))


Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (216276 => 216277)

--- 

[webkit-changes] [216276] tags/Safari-604.1.22/

[matthew_hanson]

Title: [216276] tags/Safari-604.1.22/








Revision 216276
Author matthew_han...@apple.com
Date 2017-05-05 15:03:18 -0700 (Fri, 05 May 2017)


Log Message
New tag.

Added Paths

tags/Safari-604.1.22/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216275] trunk

[mmaxfield]

Title: [216275] trunk








Revision 216275
Author mmaxfi...@apple.com
Date 2017-05-05 14:54:59 -0700 (Fri, 05 May 2017)


Log Message
[Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not case insensitive
https://bugs.webkit.org/show_bug.cgi?id=171636


Reviewed by Dean Jackson.

Source/WebCore:

LastResort is the only name which needs to be looked up case-sensitively. We can handle
this in our existing function which handles special font names (like -apple-system) to
make sure that we always do the right thing.

Test: fast/text/lastResort.html

* platform/spi/cocoa/CoreTextSPI.h:
* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::platformFontWithFamilySpecialCase):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::platformFontWithFamilySpecialCase):

LayoutTests:

* fast/text/lastResort-expected.html: Added.
* fast/text/lastResort.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
trunk/Source/WebCore/platform/spi/cocoa/CoreTextSPI.h


Added Paths

trunk/LayoutTests/fast/text/lastResort-expected.html
trunk/LayoutTests/fast/text/lastResort.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216274 => 216275)

--- trunk/LayoutTests/ChangeLog	2017-05-05 21:36:58 UTC (rev 216274)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 21:54:59 UTC (rev 216275)
@@ -1,3 +1,14 @@
+2017-05-05  Myles C. Maxfield  
+
+[Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not case insensitive
+https://bugs.webkit.org/show_bug.cgi?id=171636
+
+
+Reviewed by Dean Jackson.
+
+* fast/text/lastResort-expected.html: Added.
+* fast/text/lastResort.html: Added.
+
 2017-05-05  Ryan Haddad  
 
 Unskip media/click-placeholder-not-pausing.html.


Added: trunk/LayoutTests/fast/text/lastResort-expected.html (0 => 216275)

--- trunk/LayoutTests/fast/text/lastResort-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/lastResort-expected.html	2017-05-05 21:54:59 UTC (rev 216275)
@@ -0,0 +1,9 @@
+
+
+
+
+
+This test makes sure that Last Resort is always looked up correctly.
+hi
+
+


Added: trunk/LayoutTests/fast/text/lastResort.html (0 => 216275)

--- trunk/LayoutTests/fast/text/lastResort.html	(rev 0)
+++ trunk/LayoutTests/fast/text/lastResort.html	2017-05-05 21:54:59 UTC (rev 216275)
@@ -0,0 +1,9 @@
+
+
+
+
+
+This test makes sure that Last Resort is always looked up correctly.
+hi
+
+


Modified: trunk/Source/WebCore/ChangeLog (216274 => 216275)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 21:36:58 UTC (rev 216274)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 21:54:59 UTC (rev 216275)
@@ -1,3 +1,23 @@
+2017-05-05  Myles C. Maxfield  
+
+[Cocoa] CTFontDescriptorCreateMatchingFontDescriptor() is not case insensitive
+https://bugs.webkit.org/show_bug.cgi?id=171636
+
+
+Reviewed by Dean Jackson.
+
+LastResort is the only name which needs to be looked up case-sensitively. We can handle
+this in our existing function which handles special font names (like -apple-system) to
+make sure that we always do the right thing.
+
+Test: fast/text/lastResort.html
+
+* platform/spi/cocoa/CoreTextSPI.h:
+* platform/graphics/ios/FontCacheIOS.mm:
+(WebCore::platformFontWithFamilySpecialCase):
+* platform/graphics/mac/FontCacheMac.mm:
+(WebCore::platformFontWithFamilySpecialCase):
+
 2017-05-05  Said Abou-Hallawa  
 
 Crash in ImageFrameCache::decodedSizeChanged() after image load cancellation


Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (216274 => 216275)

--- trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2017-05-05 21:36:58 UTC (rev 216274)
+++ trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm	2017-05-05 21:54:59 UTC (rev 216275)
@@ -164,6 +164,17 @@
 return adoptCF(CTFontCreateWithFontDescriptor(monospaceFontDescriptor.get(), size, nullptr));
 }
 
+if (equalLettersIgnoringASCIICase(family, "lastresort")) {
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 11
+static NeverDestroyed lastResort = adoptCF(CTFontDescriptorCreateLastResort());
+return adoptCF(CTFontCreateWithFontDescriptor(lastResort.get().get(), size, nullptr));
+#else
+// LastResort is special, so it's important to look this exact string up, and not some case-folded version.
+// We handle this here so any caching and case folding we do in our general text codepath is bypassed.
+return adoptCF(CTFontCreateWithName(CFSTR("LastResort"), size, nullptr));
+#endif
+}
+
 return nullptr;
 }
 


Modified: trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm (216274 => 216275)

--- 

[webkit-changes] [216273] trunk/Source/WebCore

[said]

Title: [216273] trunk/Source/WebCore








Revision 216273
Author s...@apple.com
Date 2017-05-05 14:35:54 -0700 (Fri, 05 May 2017)


Log Message
Crash in ImageFrameCache::decodedSizeChanged() after image load cancellation
https://bugs.webkit.org/show_bug.cgi?id=171736

Reviewed by Tim Horton.

Tests: Covered by run-webkit-tests fast/images/image-formats-support.html
--guard-malloc.

Because an image format is not supported, the ImageObserver of the Image
is deleted then the Image itself is deleted. In BitmapImage destructor,
we make a call which ends up accessing the deleted ImageObserver.

To fix this, we need to setImageObsever of the Image to-be-deleted to 
nullptr. So the Image can avoid accessing its ImageObserver, while it is
being deleted. Also we can change the BitImage destructor to avoid calling 
ImageFrameCache::decodedSizeChanged() since it is not really needed.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::clearImage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::~BitmapImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216272 => 216273)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 21:15:51 UTC (rev 216272)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 21:35:54 UTC (rev 216273)
@@ -1,3 +1,27 @@
+2017-05-05  Said Abou-Hallawa  
+
+Crash in ImageFrameCache::decodedSizeChanged() after image load cancellation
+https://bugs.webkit.org/show_bug.cgi?id=171736
+
+Reviewed by Tim Horton.
+
+Tests: Covered by run-webkit-tests fast/images/image-formats-support.html
+--guard-malloc.
+
+Because an image format is not supported, the ImageObserver of the Image
+is deleted then the Image itself is deleted. In BitmapImage destructor,
+we make a call which ends up accessing the deleted ImageObserver.
+
+To fix this, we need to setImageObsever of the Image to-be-deleted to 
+nullptr. So the Image can avoid accessing its ImageObserver, while it is
+being deleted. Also we can change the BitImage destructor to avoid calling 
+ImageFrameCache::decodedSizeChanged() since it is not really needed.
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::clearImage):
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::~BitmapImage):
+
 2017-05-05  Brian Burg  
 
 CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57


Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (216272 => 216273)

--- trunk/Source/WebCore/loader/cache/CachedImage.cpp	2017-05-05 21:15:51 UTC (rev 216272)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp	2017-05-05 21:35:54 UTC (rev 216273)
@@ -360,7 +360,10 @@
 m_imageObserver->remove(*this);
 m_imageObserver = nullptr;
 }
-m_image = nullptr;
+if (m_image) {
+m_image->setImageObserver(nullptr);
+m_image = nullptr;
+}
 }
 
 void CachedImage::addIncrementalDataBuffer(SharedBuffer& data)


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (216272 => 216273)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-05 21:15:51 UTC (rev 216272)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-05 21:35:54 UTC (rev 216273)
@@ -61,7 +61,8 @@
 BitmapImage::~BitmapImage()
 {
 invalidatePlatformData();
-stopAnimation();
+clearTimer();
+m_source.stopAsyncDecodingQueue();
 }
 
 void BitmapImage::updateFromSettings(const Settings& settings)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216272] trunk/Tools

[bburg]

Title: [216272] trunk/Tools








Revision 216272
Author bb...@apple.com
Date 2017-05-05 14:15:51 -0700 (Fri, 05 May 2017)


Log Message
API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
https://bugs.webkit.org/show_bug.cgi?id=171748

Unreviewed test gardening.

The assertion failure will be investigated separately in order to avoid rolling out
the fix for "secure" cookies. This assertion fails even without r216258 applied.

* TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
(TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm




Diff

Modified: trunk/Tools/ChangeLog (216271 => 216272)

--- trunk/Tools/ChangeLog	2017-05-05 20:52:37 UTC (rev 216271)
+++ trunk/Tools/ChangeLog	2017-05-05 21:15:51 UTC (rev 216272)
@@ -1,3 +1,16 @@
+2017-05-05  Brian Burg  
+
+API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
+https://bugs.webkit.org/show_bug.cgi?id=171748
+
+Unreviewed test gardening.
+
+The assertion failure will be investigated separately in order to avoid rolling out
+the fix for "secure" cookies. This assertion fails even without r216258 applied.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
+(TEST):
+
 2017-05-05  Jonathan Bedard  
 
 Unreviewed, rolling out r216260.


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm (216271 => 216272)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm	2017-05-05 20:52:37 UTC (rev 216271)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm	2017-05-05 21:15:51 UTC (rev 216272)
@@ -131,7 +131,8 @@
 ASSERT_TRUE([cookie2.get().name isEqualToString:cookie.name]);
 ASSERT_TRUE([cookie2.get().domain isEqualToString:cookie.domain]);
 ASSERT_FALSE(cookie.secure);
-ASSERT_FALSE(cookie.sessionOnly);
+// FIXME: this should be ASSERT_FALSE. Investigating in .
+ASSERT_TRUE(cookie.sessionOnly);
 }
 }
 [cookies release];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216271] trunk/Tools

[jbedard]

Title: [216271] trunk/Tools








Revision 216271
Author jbed...@apple.com
Date 2017-05-05 13:52:37 -0700 (Fri, 05 May 2017)


Log Message
Unreviewed, rolling out r216260.

Breaks internal iOS testers

Reverted changeset:

"Use ImageDiff built by host SDK and remove ImageDiff from
DumpRenderTree"
https://bugs.webkit.org/show_bug.cgi?id=168945
http://trac.webkit.org/changeset/216260

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/DumpRenderTree/PlatformWin.cmake
trunk/Tools/Scripts/webkitpy/port/darwin.py
trunk/Tools/Scripts/webkitpy/port/image_diff.py
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py


Added Paths

trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp
trunk/Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig




Diff

Modified: trunk/Tools/ChangeLog (216270 => 216271)

--- trunk/Tools/ChangeLog	2017-05-05 20:52:21 UTC (rev 216270)
+++ trunk/Tools/ChangeLog	2017-05-05 20:52:37 UTC (rev 216271)
@@ -1,5 +1,18 @@
 2017-05-05  Jonathan Bedard  
 
+Unreviewed, rolling out r216260.
+
+Breaks internal iOS testers
+
+Reverted changeset:
+
+"Use ImageDiff built by host SDK and remove ImageDiff from
+DumpRenderTree"
+https://bugs.webkit.org/show_bug.cgi?id=168945
+http://trac.webkit.org/changeset/216260
+
+2017-05-05  Jonathan Bedard  
+
 Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
 https://bugs.webkit.org/show_bug.cgi?id=168945
 


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (216270 => 216271)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-05 20:52:21 UTC (rev 216270)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-05 20:52:37 UTC (rev 216271)
@@ -27,6 +27,7 @@
 CEB754D41BBDA26D009F0401 /* PBXTargetDependency */,
 2D403F211508736C005358D2 /* PBXTargetDependency */,
 A134E52D188FC09200901D06 /* PBXTargetDependency */,
+A84F608F08B1370E00E9745F /* PBXTargetDependency */,
 141BF238096A451E00E0753C /* PBXTargetDependency */,
 			);
 			name = All;
@@ -79,7 +80,7 @@
 		2D403F1B15087209005358D2 /* LayoutTestHelper.m in Sources */ = {isa = PBXBuildFile; fileRef = 2D403EA215087142005358D2 /* LayoutTestHelper.m */; };
 		2DA2E3A51E1BA54100A3BBD0 /* DumpRenderTreeSpellChecker.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2DA2E3A41E1BA54100A3BBD0 /* DumpRenderTreeSpellChecker.mm */; };
 		31117B3D15D9A56A00163BC8 /* MockWebNotificationProvider.mm in Sources */ = {isa = PBXBuildFile; fileRef = 31117B3B15D9A56A00163BC8 /* MockWebNotificationProvider.mm */; };
-		312943F91E71F2B4001EE2CC /* IOSLayoutTestCommunication.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3148A0551E6F90F400D3B316 /* IOSLayoutTestCommunication.cpp */; };
+		312943F91E71F2B4001EE2CC /* IOOSLayoutTestCommunication.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3148A0551E6F90F400D3B316 /* IOSLayoutTestCommunication.cpp */; };
 		4464CABE1C20A08B00E5BB55 /* DumpRenderTreeAppMain.mm in Sources */ = {isa = PBXBuildFile; fileRef = 4464CABD1C20A07000E5BB55 /* DumpRenderTreeAppMain.mm */; };
 		4AD6A11413C8124000EA9737 /* FormValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4AD6A11313C8124000EA9737 /* FormValue.cpp */; };
 		5106803E15CC7B10001A8A23 /* SlowNPPNew.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5106803D15CC7B10001A8A23 /* SlowNPPNew.cpp */; };
@@ -138,6 +139,7 @@
 		BCA18C470C9B5B9400114369 /* DumpRenderTree.mm in Sources */ = {isa = PBXBuildFile; fileRef = BCA18C460C9B5B9400114369 /* DumpRenderTree.mm */; settings = {COMPILER_FLAGS = "-Wno-deprecated-declarations"; }; };
 		BCB284CD0CFA83C8007E533E /* PixelDumpSupportCG.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCB284880CFA8202007E533E /* PixelDumpSupportCG.cpp */; };
 		BCB284D60CFA83D1007E533E /* PixelDumpSupportMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BCB2848C0CFA8221007E533E /* PixelDumpSupportMac.mm */; };
+		BCB284F60CFA84F8007E533E /* ImageDiffCG.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCB284F30CFA84F2007E533E /* ImageDiffCG.cpp */; };
 		BCD08B3A0E1057EF00A7D0C1 /* AccessibilityController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCD08B390E1057EF00A7D0C1 /* AccessibilityController.cpp */; };
 		BCD08B710E1059D200A7D0C1 /* AccessibilityControllerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BCD08B700E1059D200A7D0C1 /* AccessibilityControllerMac.mm */; };
 		BCF6C6500C98E9C000AC063E /* GCController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCF6C64F0C98E9C000AC063E /* GCController.cpp */; };
@@ -194,6 +196,13 @@
 			remoteGlobalIDString = A1321C9D188F9A3600125434;
 			remoteInfo = "DumpRenderTree (Library)";
 		};
+		A84F608E08B1370E00E9745F /* PBXContainerItemProxy */ = {
+			isa = PBXContainerItemProxy;
+			containerPortal = 08FB7793FE84155DC02AAC07 /* Project 

[webkit-changes] [216270] tags/Safari-604.1.21/Source

[matthew_hanson]

Title: [216270] tags/Safari-604.1.21/Source








Revision 216270
Author matthew_han...@apple.com
Date 2017-05-05 13:52:21 -0700 (Fri, 05 May 2017)


Log Message
Versioning.

Modified Paths

tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-604.1.21/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig (216269 => 216270)

--- tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-05 20:36:24 UTC (rev 216269)
+++ tags/Safari-604.1.21/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-05 20:52:21 UTC (rev 216270)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (216269 => 216270)

--- tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-05 20:36:24 UTC (rev 216269)
+++ tags/Safari-604.1.21/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-05 20:52:21 UTC (rev 216270)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig (216269 => 216270)

--- tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig	2017-05-05 20:36:24 UTC (rev 216269)
+++ tags/Safari-604.1.21/Source/WebCore/Configurations/Version.xcconfig	2017-05-05 20:52:21 UTC (rev 216270)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig (216269 => 216270)

--- tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-05 20:36:24 UTC (rev 216269)
+++ tags/Safari-604.1.21/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-05 20:52:21 UTC (rev 216270)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig (216269 => 216270)

--- tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-05 20:36:24 UTC (rev 216269)
+++ tags/Safari-604.1.21/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-05 20:52:21 UTC (rev 216270)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig (216269 => 216270)

--- tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-05 20:36:24 UTC (rev 216269)
+++ tags/Safari-604.1.21/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-05 20:52:21 UTC (rev 216270)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
 MICRO_VERSION = 0;

[webkit-changes] [216269] trunk/LayoutTests

[ryanhaddad]

Title: [216269] trunk/LayoutTests








Revision 216269
Author ryanhad...@apple.com
Date 2017-05-05 13:36:24 -0700 (Fri, 05 May 2017)


Log Message
Unskip media/click-placeholder-not-pausing.html.

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216268 => 216269)

--- trunk/LayoutTests/ChangeLog	2017-05-05 20:33:47 UTC (rev 216268)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 20:36:24 UTC (rev 216269)
@@ -1,3 +1,11 @@
+2017-05-05  Ryan Haddad  
+
+Unskip media/click-placeholder-not-pausing.html.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-05-05  Joseph Pecoraro  
 
 REGRESSION: LayoutTest streams/reference-implementation/readable-stream-templated.html is a flaky failure


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216268 => 216269)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-05 20:33:47 UTC (rev 216268)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-05 20:36:24 UTC (rev 216269)
@@ -499,9 +499,6 @@
 [ Sierra+ ] media/pip-video-going-into-fullscreen.html [ Pass ]
 [ Sierra+ ] media/video-contained-in-fullscreen-element-going-into-pip.html [ Pass ]
 
-# rdar://problem/26885345
-[ Sierra+ ] media/click-placeholder-not-pausing.html [ Pass ]
-
 # RTL Scrollbars are enabled on Sierra WebKit2.
 [ Sierra+ ] fast/scrolling/rtl-scrollbars.html [ Pass ]
 [ Sierra+ ] fast/scrolling/rtl-scrollbars-simple.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216268] tags/Safari-604.1.21/Source

[matthew_hanson]

Title: [216268] tags/Safari-604.1.21/Source








Revision 216268
Author matthew_han...@apple.com
Date 2017-05-05 13:33:47 -0700 (Fri, 05 May 2017)


Log Message
Cherry-pick r216229. rdar://problem/31978703

Modified Paths

tags/Safari-604.1.21/Source/WebCore/ChangeLog
tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
tags/Safari-604.1.21/Source/WebKit/mac/ChangeLog
tags/Safari-604.1.21/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: tags/Safari-604.1.21/Source/WebCore/ChangeLog (216267 => 216268)

--- tags/Safari-604.1.21/Source/WebCore/ChangeLog	2017-05-05 20:31:56 UTC (rev 216267)
+++ tags/Safari-604.1.21/Source/WebCore/ChangeLog	2017-05-05 20:33:47 UTC (rev 216268)
@@ -1,3 +1,24 @@
+2017-05-05  Matthew Hanson  
+
+Cherry-pick r216229. rdar://problem/31978703
+
+2017-05-04  Jeremy Jones  
+
+UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
+https://bugs.webkit.org/show_bug.cgi?id=171704
+
+Reviewed by Jer Noble.
+
+No new tests because no behavior change.
+
+Fix build by casting result of +clearColor to UIColor.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(clearUIColor):
+(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
+(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
+(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):
+
 2017-05-03  John Wilander  
 
 Resource Load Statistics: Remove all statistics for modifiedSince website data removals


Modified: tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (216267 => 216268)

--- tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-05-05 20:31:56 UTC (rev 216267)
+++ tags/Safari-604.1.21/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-05-05 20:33:47 UTC (rev 216268)
@@ -75,6 +75,11 @@
 SOFT_LINK_CLASS(UIKit, UIColor)
 SOFT_LINK_CONSTANT(UIKit, UIRemoteKeyboardLevel, UIWindowLevel)
 
+static UIColor *clearUIColor()
+{
+return (UIColor *)[getUIColorClass() clearColor];
+}
+
 #if !LOG_DISABLED
 static const char* boolString(bool val)
 {
@@ -602,7 +607,7 @@
 if (![[parentView window] _isHostedInAnotherProcess]) {
 if (!m_window)
 m_window = adoptNS([allocUIWindowInstance() initWithFrame:[[getUIScreenClass() mainScreen] bounds]]);
-[m_window setBackgroundColor:[getUIColorClass() clearColor]];
+[m_window setBackgroundColor:clearUIColor()];
 if (!m_viewController)
 m_viewController = adoptNS([allocUIViewControllerInstance() init]);
 [[m_viewController view] setFrame:[m_window bounds]];
@@ -615,7 +620,7 @@
 if (!m_playerLayerView)
 m_playerLayerView = adoptNS([[getWebAVPlayerLayerViewClass() alloc] init]);
 [m_playerLayerView setHidden:[playerController() isExternalPlaybackActive]];
-[m_playerLayerView setBackgroundColor:[getUIColorClass() clearColor]];
+[m_playerLayerView setBackgroundColor:clearUIColor()];
 
 if (!isInPictureInPictureMode) {
 [m_playerLayerView setVideoView:];
@@ -646,7 +651,7 @@
 
 [m_playerViewController view].frame = [parentView convertRect:initialRect toView:[m_playerViewController view].superview];
 
-[[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
+[[m_playerViewController view] setBackgroundColor:clearUIColor()];
 [[m_playerViewController view] setAutoresizingMask:(UIViewAutoresizingFlexibleBottomMargin | UIViewAutoresizingFlexibleRightMargin)];
 
 [[m_playerViewController view] setNeedsLayout];
@@ -748,8 +753,8 @@
 
 [CATransaction begin];
 [CATransaction setDisableActions:YES];
-[m_playerLayerView setBackgroundColor:[getUIColorClass() clearColor]];
-[[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
+[m_playerLayerView setBackgroundColor:clearUIColor()];
+[[m_playerViewController view] setBackgroundColor:clearUIColor()];
 [CATransaction commit];
 
 dispatch_async(dispatch_get_main_queue(), [protectedThis, this]() {
@@ -930,8 +935,8 @@
 
 m_exitCompleted = true;
 
-[m_playerLayerView setBackgroundColor:[getUIColorClass() clearColor]];
-[[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
+[m_playerLayerView setBackgroundColor:clearUIColor()];
+[[m_playerViewController view] setBackgroundColor:clearUIColor()];
 
 clearMode(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture);
 


Modified: tags/Safari-604.1.21/Source/WebKit/mac/ChangeLog (216267 => 216268)

--- tags/Safari-604.1.21/Source/WebKit/mac/ChangeLog	2017-05-05 20:31:56 UTC (rev 216267)
+++ 

[webkit-changes] [216266] trunk/LayoutTests

[joepeck]

Title: [216266] trunk/LayoutTests








Revision 216266
Author joep...@webkit.org
Date 2017-05-05 13:31:53 -0700 (Fri, 05 May 2017)


Log Message
[macOS Sierra] LayoutTest http/tests/inspector/network/resource-request-headers.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=170702


Rubber-stamped by Brian Burg.

* platform/mac-wk2/TestExpectations:
* http/tests/inspector/network/resource-request-headers.html:
Make this test unflakey by ensuring we wait for the load to complete.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/network/resource-request-headers.html
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216265 => 216266)

--- trunk/LayoutTests/ChangeLog	2017-05-05 20:23:28 UTC (rev 216265)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 20:31:53 UTC (rev 216266)
@@ -1,3 +1,15 @@
+2017-05-05  Joseph Pecoraro  
+
+[macOS Sierra] LayoutTest http/tests/inspector/network/resource-request-headers.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=170702
+
+
+Rubber-stamped by Brian Burg.
+
+* platform/mac-wk2/TestExpectations:
+* http/tests/inspector/network/resource-request-headers.html:
+Make this test unflakey by ensuring we wait for the load to complete.
+
 2017-05-05  Chris Dumez  
 
 Attr Nodes should not have children


Modified: trunk/LayoutTests/http/tests/inspector/network/resource-request-headers.html (216265 => 216266)

--- trunk/LayoutTests/http/tests/inspector/network/resource-request-headers.html	2017-05-05 20:23:28 UTC (rev 216265)
+++ trunk/LayoutTests/http/tests/inspector/network/resource-request-headers.html	2017-05-05 20:31:53 UTC (rev 216266)
@@ -52,8 +52,9 @@
 Promise.all([
 WebInspector.Frame.awaitEvent(WebInspector.Frame.Event.ResourceWasAdded),
 WebInspector.Resource.awaitEvent(WebInspector.Resource.Event.ResponseReceived),
+WebInspector.Resource.awaitEvent(WebInspector.Resource.Event.LoadingDidFinish),
 InspectorTest.awaitEvent("LoadComplete"),
-]).then(([resourceWasAddedEvent, responseReceivedEvent, loadCompleteEvent]) => {
+]).then(([resourceWasAddedEvent, responseReceivedEvent, loadingDidFinish, loadCompleteEvent]) => {
 let resource = resourceWasAddedEvent.data.resource;
 InspectorTest.expectThat(resource instanceof WebInspector.Resource, "Resource should be created.");
 InspectorTest.expectEqual(resource, responseReceivedEvent.target, "Resource should receive a Response.");


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216265 => 216266)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-05 20:23:28 UTC (rev 216265)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-05 20:31:53 UTC (rev 216266)
@@ -648,8 +648,6 @@
 
 compositing/tiling/non-visible-window-tile-coverage.html [ Pass ]
 
-webkit.org/b/170702 [ Sierra ] http/tests/inspector/network/resource-request-headers.html [ Pass Failure ]
-
 webkit.org/b/170907 [ Debug ] imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html [ Pass Failure Timeout ]
 
 webkit.org/b/170629 [ Sierra Debug ] memory/memory-pressure-simulation.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216267] trunk/LayoutTests

[joepeck]

Title: [216267] trunk/LayoutTests








Revision 216267
Author joep...@webkit.org
Date 2017-05-05 13:31:56 -0700 (Fri, 05 May 2017)


Log Message
REGRESSION: LayoutTest streams/reference-implementation/readable-stream-templated.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=171580


Rubber-stamped by Alexey Proskuryakov.

* TestExpectations:
* streams/reference-implementation/pipe-to-expected.txt:
Rebaseline expectations. This test was previously flakey so the results were
missed unless the test was run with --force.

* streams/reference-implementation/readable-stream-templated-expected.txt:
* streams/reference-implementation/readable-stream-templated.html:
Silence unhandled rejections. This test did not expect unhandled promise
rejections to affect test results, so ignore them.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/streams/reference-implementation/pipe-to-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-templated.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216266 => 216267)

--- trunk/LayoutTests/ChangeLog	2017-05-05 20:31:53 UTC (rev 216266)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 20:31:56 UTC (rev 216267)
@@ -1,5 +1,23 @@
 2017-05-05  Joseph Pecoraro  
 
+REGRESSION: LayoutTest streams/reference-implementation/readable-stream-templated.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=171580
+
+
+Rubber-stamped by Alexey Proskuryakov.
+
+* TestExpectations:
+* streams/reference-implementation/pipe-to-expected.txt:
+Rebaseline expectations. This test was previously flakey so the results were
+missed unless the test was run with --force.
+
+* streams/reference-implementation/readable-stream-templated-expected.txt:
+* streams/reference-implementation/readable-stream-templated.html:
+Silence unhandled rejections. This test did not expect unhandled promise
+rejections to affect test results, so ignore them.
+
+2017-05-05  Joseph Pecoraro  
+
 [macOS Sierra] LayoutTest http/tests/inspector/network/resource-request-headers.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=170702
 


Modified: trunk/LayoutTests/TestExpectations (216266 => 216267)

--- trunk/LayoutTests/TestExpectations	2017-05-05 20:31:53 UTC (rev 216266)
+++ trunk/LayoutTests/TestExpectations	2017-05-05 20:31:56 UTC (rev 216267)
@@ -843,7 +843,7 @@
 
 webkit.org/b/150598 fast/repaint/table-hover-on-link.html [ Pass Failure ]
 
-webkit.org/b/151949 streams/reference-implementation/pipe-to.html [ Failure ]
+webkit.org/b/151949 streams/reference-implementation/pipe-to.html [ Pass Failure ]
 webkit.org/b/154687 streams/pipe-to.html [ Slow ]
 
 webkit.org/b/52185 fast/css/vertical-align-baseline-rowspan-010.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/streams/reference-implementation/pipe-to-expected.txt (216266 => 216267)

--- trunk/LayoutTests/streams/reference-implementation/pipe-to-expected.txt	2017-05-05 20:31:53 UTC (rev 216266)
+++ trunk/LayoutTests/streams/reference-implementation/pipe-to-expected.txt	2017-05-05 20:31:56 UTC (rev 216267)
@@ -1,25 +1,25 @@
 CONSOLE MESSAGE: line 2687: TypeError: undefined is not an object (evaluating 'e.message')
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: undefined
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: Error: horrible things
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: Error: horrible things
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: TypeError: cancel() called on a reader owned by no readable stream
+CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
+CONSOLE MESSAGE: Unhandled Promise Rejection: Error: horrible things
+CONSOLE MESSAGE: line 301: Unhandled Promise Rejection: Error: horrible things
+CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: cancel() called on a reader owned by no readable stream
 CONSOLE MESSAGE: line 2687: TypeError: undefined is not an object (evaluating 'e.message')
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: undefined
+CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
 CONSOLE MESSAGE: line 2687: TypeError: undefined is not an object (evaluating 'e.message')
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: undefined
+CONSOLE MESSAGE: Unhandled Promise Rejection: undefined
 CONSOLE MESSAGE: line 2687: TypeError: undefined is not an object (evaluating 'e.message')
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: undefined
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: Error: horrible things
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: Error: horrible things
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: TypeError: cancel() called on a reader owned by no 

[webkit-changes] [216265] trunk/Source/WebKit2

[wilander]

Title: [216265] trunk/Source/WebKit2








Revision 216265
Author wilan...@apple.com
Date 2017-05-05 13:23:28 -0700 (Fri, 05 May 2017)


Log Message
Resource Load Statistics: Don't cover in-memory and disk caches during website data removal
https://bugs.webkit.org/show_bug.cgi?id=171741


Reviewed by Brent Fulgham.

* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
No longer removes WebsiteDataType::DiskCache or WebsiteDataType::MemoryCache.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216264 => 216265)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 20:21:17 UTC (rev 216264)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 20:23:28 UTC (rev 216265)
@@ -1,3 +1,15 @@
+2017-05-05  John Wilander  
+
+Resource Load Statistics: Don't cover in-memory and disk caches during website data removal
+https://bugs.webkit.org/show_bug.cgi?id=171741
+
+
+Reviewed by Brent Fulgham.
+
+* UIProcess/WebResourceLoadStatisticsStore.cpp:
+(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
+No longer removes WebsiteDataType::DiskCache or WebsiteDataType::MemoryCache.
+
 2017-05-05  Brian Burg  
 
 CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57


Modified: trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp (216264 => 216265)

--- trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp	2017-05-05 20:21:17 UTC (rev 216264)
+++ trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp	2017-05-05 20:23:28 UTC (rev 216265)
@@ -108,8 +108,6 @@
 
 if (dataTypesToRemove.isEmpty()) {
 dataTypesToRemove |= WebsiteDataType::Cookies;
-dataTypesToRemove |= WebsiteDataType::DiskCache;
-dataTypesToRemove |= WebsiteDataType::MemoryCache;
 dataTypesToRemove |= WebsiteDataType::OfflineWebApplicationCache;
 dataTypesToRemove |= WebsiteDataType::SessionStorage;
 dataTypesToRemove |= WebsiteDataType::LocalStorage;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216264] trunk/Source/JavaScriptCore

[commit-queue]

Title: [216264] trunk/Source/_javascript_Core








Revision 216264
Author commit-qu...@webkit.org
Date 2017-05-05 13:21:17 -0700 (Fri, 05 May 2017)


Log Message
[JSC] include JSCInlines.h in ObjectInitializationScope.cpp
https://bugs.webkit.org/show_bug.cgi?id=171744

Patch by Guillaume Emont  on 2017-05-05
Reviewed by Mark Lam.

* runtime/ObjectInitializationScope.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ObjectInitializationScope.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216263 => 216264)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-05 19:44:47 UTC (rev 216263)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-05 20:21:17 UTC (rev 216264)
@@ -1,3 +1,13 @@
+2017-05-05  Guillaume Emont  
+
+[JSC] include JSCInlines.h in ObjectInitializationScope.cpp
+https://bugs.webkit.org/show_bug.cgi?id=171744
+
+Reviewed by Mark Lam.
+
+* runtime/ObjectInitializationScope.cpp:
+
+
 2017-05-05  Carlos Garcia Campos  
 
 [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext


Modified: trunk/Source/_javascript_Core/runtime/ObjectInitializationScope.cpp (216263 => 216264)

--- trunk/Source/_javascript_Core/runtime/ObjectInitializationScope.cpp	2017-05-05 19:44:47 UTC (rev 216263)
+++ trunk/Source/_javascript_Core/runtime/ObjectInitializationScope.cpp	2017-05-05 20:21:17 UTC (rev 216264)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "ObjectInitializationScope.h"
 
+#include "JSCInlines.h"
 #include "JSObject.h"
 #include "Operations.h"
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216263] trunk/Source

[bburg]

Title: [216263] trunk/Source








Revision 216263
Author bb...@apple.com
Date 2017-05-05 12:44:47 -0700 (Fri, 05 May 2017)


Log Message
CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57
https://bugs.webkit.org/show_bug.cgi?id=171669


Reviewed by Mark Lam.

Source/WebCore:

* bindings/js/CommonVM.h:
(WebCore::commonVMOrNull):
Add an inline accessor function to expose the global variable.

Source/WebKit2:

safaridriver's AutomaticInspection capability causes us to call WebInspectorProxy::connect()
underneath the Automation.inspectBrowsingContext command. This fires a NeedDebuggerBreak
interrupt for the web content's VM, but this is racy because the web content process may
not yet be fully initialized when this interrupt is handled.

To work around this, just don't deliver any interrupts if the VM singleton is still null.
This is a reliable signal that the web content process is not fully initialized yet. Not delivering
is harmless; the interrupt only exists to break out of infinite loops in JS code, but there
could not be any such infinite loop yet if the web content process is not fully initialized.

* WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp:
(WebKit::WebInspectorInterruptDispatcher::notifyNeedDebuggerBreak):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/CommonVM.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216262 => 216263)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 19:43:22 UTC (rev 216262)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 19:44:47 UTC (rev 216263)
@@ -1,3 +1,15 @@
+2017-05-05  Brian Burg  
+
+CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57
+https://bugs.webkit.org/show_bug.cgi?id=171669
+
+
+Reviewed by Mark Lam.
+
+* bindings/js/CommonVM.h:
+(WebCore::commonVMOrNull):
+Add an inline accessor function to expose the global variable.
+
 2017-05-05  Filip Pizlo  
 
 GCController.cpp's collect() should be Async


Modified: trunk/Source/WebCore/bindings/js/CommonVM.h (216262 => 216263)

--- trunk/Source/WebCore/bindings/js/CommonVM.h	2017-05-05 19:43:22 UTC (rev 216262)
+++ trunk/Source/WebCore/bindings/js/CommonVM.h	2017-05-05 19:44:47 UTC (rev 216263)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -37,6 +37,11 @@
 
 WEBCORE_EXPORT JSC::VM& commonVMSlow();
 
+inline JSC::VM* commonVMOrNull()
+{
+return g_commonVMOrNull;
+}
+
 inline JSC::VM& commonVM()
 {
 if (JSC::VM* result = g_commonVMOrNull)


Modified: trunk/Source/WebKit2/ChangeLog (216262 => 216263)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 19:43:22 UTC (rev 216262)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 19:44:47 UTC (rev 216263)
@@ -1,5 +1,26 @@
 2017-05-05  Brian Burg  
 
+CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57
+https://bugs.webkit.org/show_bug.cgi?id=171669
+
+
+Reviewed by Mark Lam.
+
+safaridriver's AutomaticInspection capability causes us to call WebInspectorProxy::connect()
+underneath the Automation.inspectBrowsingContext command. This fires a NeedDebuggerBreak
+interrupt for the web content's VM, but this is racy because the web content process may
+not yet be fully initialized when this interrupt is handled.
+
+To work around this, just don't deliver any interrupts if the VM singleton is still null.
+This is a reliable signal that the web content process is not fully initialized yet. Not delivering
+is harmless; the interrupt only exists to break out of infinite loops in JS code, but there
+could not be any such infinite loop yet if the web content process is not fully initialized.
+
+* WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp:
+(WebKit::WebInspectorInterruptDispatcher::notifyNeedDebuggerBreak):
+
+2017-05-05  Brian Burg  
+
 Web Automation: cookie-related commands don't work correctly
 https://bugs.webkit.org/show_bug.cgi?id=171713
 


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp (216262 => 216263)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp	2017-05-05 19:43:22 UTC (rev 216262)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp	2017-05-05 19:44:47 UTC (rev 216263)
@@ -32,7 +32,7 @@
 #include 
 
 namespace WebKit {
-
+
 Ref 

[webkit-changes] [216262] trunk/Source/WebCore

[fpizlo]

Title: [216262] trunk/Source/WebCore








Revision 216262
Author fpi...@apple.com
Date 2017-05-05 12:43:22 -0700 (Fri, 05 May 2017)


Log Message
GCController.cpp's collect() should be Async
https://bugs.webkit.org/show_bug.cgi?id=171708

Reviewed by Saam Barati.

No new tests because no change in behavior.

This is one step towards not requesting sync GCs in WebCore. I'm landing this incrementally to
make bisecting super easy.

* bindings/js/GCController.cpp:
(WebCore::collect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/GCController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216261 => 216262)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 19:31:21 UTC (rev 216261)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 19:43:22 UTC (rev 216262)
@@ -1,3 +1,18 @@
+2017-05-05  Filip Pizlo  
+
+GCController.cpp's collect() should be Async
+https://bugs.webkit.org/show_bug.cgi?id=171708
+
+Reviewed by Saam Barati.
+
+No new tests because no change in behavior.
+
+This is one step towards not requesting sync GCs in WebCore. I'm landing this incrementally to
+make bisecting super easy.
+
+* bindings/js/GCController.cpp:
+(WebCore::collect):
+
 2017-05-05  Chris Dumez  
 
 Attr Nodes should not have children


Modified: trunk/Source/WebCore/bindings/js/GCController.cpp (216261 => 216262)

--- trunk/Source/WebCore/bindings/js/GCController.cpp	2017-05-05 19:31:21 UTC (rev 216261)
+++ trunk/Source/WebCore/bindings/js/GCController.cpp	2017-05-05 19:43:22 UTC (rev 216262)
@@ -41,7 +41,7 @@
 static void collect(void*)
 {
 JSLockHolder lock(commonVM());
-commonVM().heap.collectNow(Sync, CollectionScope::Full);
+commonVM().heap.collectNow(Async, CollectionScope::Full);
 }
 
 GCController& GCController::singleton()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216261] trunk/Source/WebKit2

[bburg]

Title: [216261] trunk/Source/WebKit2








Revision 216261
Author bb...@apple.com
Date 2017-05-05 12:31:21 -0700 (Fri, 05 May 2017)


Log Message
Web Automation: cookie-related commands don't work correctly
https://bugs.webkit.org/show_bug.cgi?id=171713


Reviewed by Alexey Proskuryakov.

Commands that use WebCookieManager directly should complete when
the manager's completion handler is called. Otherwise, this will race
with subsequent accesses to cookies via the web process (document.cookie).

Also, these commands need to use the active browsing context's session ID.
They currently use the process pool's storage session, which is wrong
since we specially configure automation instances with an ephemeral store.

* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216260 => 216261)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 19:26:35 UTC (rev 216260)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 19:31:21 UTC (rev 216261)
@@ -1,3 +1,23 @@
+2017-05-05  Brian Burg  
+
+Web Automation: cookie-related commands don't work correctly
+https://bugs.webkit.org/show_bug.cgi?id=171713
+
+
+Reviewed by Alexey Proskuryakov.
+
+Commands that use WebCookieManager directly should complete when
+the manager's completion handler is called. Otherwise, this will race
+with subsequent accesses to cookies via the web process (document.cookie).
+
+Also, these commands need to use the active browsing context's session ID.
+They currently use the process pool's storage session, which is wrong
+since we specially configure automation instances with an ephemeral store.
+
+* UIProcess/Automation/WebAutomationSession.cpp:
+(WebKit::WebAutomationSession::addSingleCookie):
+(WebKit::WebAutomationSession::deleteAllCookies):
+
 2017-05-05  Chris Dumez  
 
 Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations


Modified: trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp (216260 => 216261)

--- trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp	2017-05-05 19:26:35 UTC (rev 216260)
+++ trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp	2017-05-05 19:31:21 UTC (rev 216261)
@@ -819,9 +819,12 @@
 
 // FIXME: Using activeURL here twice is basically saying "this is always in the context of the main document"
 // which probably isn't accurate.
-cookieManager->setCookies(WebCore::SessionID::defaultSessionID(), { cookie }, activeURL, activeURL, [](CallbackBase::Error){});
-
-callback->sendSuccess();
+cookieManager->setCookies(page->websiteDataStore().sessionID(), { cookie }, activeURL, activeURL, [callback = callback.copyRef()](CallbackBase::Error error) {
+if (error == CallbackBase::Error::None)
+callback->sendSuccess();
+else
+callback->sendFailure(STRING_FOR_PREDEFINED_ERROR_NAME(InternalError));
+});
 }
 
 void WebAutomationSession::deleteAllCookies(ErrorString& errorString, const String& browsingContextHandle)
@@ -834,7 +837,7 @@
 ASSERT(activeURL.isValid());
 
 WebCookieManagerProxy* cookieManager = m_processPool->supplement();
-cookieManager->deleteCookiesForHostname(WebCore::SessionID::defaultSessionID(), activeURL.host());
+cookieManager->deleteCookiesForHostname(page->websiteDataStore().sessionID(), activeURL.host());
 }
 
 #if USE(APPKIT) || PLATFORM(GTK)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216260] trunk/Tools

[jbedard]

Title: [216260] trunk/Tools








Revision 216260
Author jbed...@apple.com
Date 2017-05-05 12:26:35 -0700 (Fri, 05 May 2017)


Log Message
Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=168945


Reviewed by David Kilzer.

Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
target SDK. These two changes must happen simultaneously because some archives will
clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.

* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
* DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
tools directory still includes ImageDiff.
* DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
* Scripts/webkitpy/port/darwin.py:
(DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
locally or when running archives.
* Scripts/webkitpy/port/image_diff.py:
(IOSSimulatorImageDiffer): Deleted.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.diff_image): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/DumpRenderTree/PlatformWin.cmake
trunk/Tools/Scripts/webkitpy/port/darwin.py
trunk/Tools/Scripts/webkitpy/port/image_diff.py
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py


Removed Paths

trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp
trunk/Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig




Diff

Modified: trunk/Tools/ChangeLog (216259 => 216260)

--- trunk/Tools/ChangeLog	2017-05-05 19:26:11 UTC (rev 216259)
+++ trunk/Tools/ChangeLog	2017-05-05 19:26:35 UTC (rev 216260)
@@ -1,3 +1,28 @@
+2017-05-05  Jonathan Bedard  
+
+Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=168945
+
+
+Reviewed by David Kilzer.
+
+Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
+target SDK. These two changes must happen simultaneously because some archives will
+clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
+
+* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
+* DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
+tools directory still includes ImageDiff.
+* DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
+* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
+* Scripts/webkitpy/port/darwin.py: 
+(DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
+locally or when running archives.
+* Scripts/webkitpy/port/image_diff.py:
+(IOSSimulatorImageDiffer): Deleted.
+* Scripts/webkitpy/port/ios_simulator.py:
+(IOSSimulatorPort.diff_image): Deleted.
+
 2017-05-05  Brian Burg  
 
 [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (216259 => 216260)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-05 19:26:11 UTC (rev 216259)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-05 19:26:35 UTC (rev 216260)
@@ -27,7 +27,6 @@
 CEB754D41BBDA26D009F0401 /* PBXTargetDependency */,
 2D403F211508736C005358D2 /* PBXTargetDependency */,
 A134E52D188FC09200901D06 /* PBXTargetDependency */,
-A84F608F08B1370E00E9745F /* PBXTargetDependency */,
 141BF238096A451E00E0753C /* PBXTargetDependency */,
 			);
 			name = All;
@@ -80,7 +79,7 @@
 		2D403F1B15087209005358D2 /* LayoutTestHelper.m in Sources */ = {isa = PBXBuildFile; fileRef = 2D403EA215087142005358D2 /* LayoutTestHelper.m */; };
 		2DA2E3A51E1BA54100A3BBD0 /* DumpRenderTreeSpellChecker.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2DA2E3A41E1BA54100A3BBD0 /* DumpRenderTreeSpellChecker.mm */; };
 		31117B3D15D9A56A00163BC8 /* MockWebNotificationProvider.mm in Sources */ = {isa = PBXBuildFile; fileRef = 31117B3B15D9A56A00163BC8 /* MockWebNotificationProvider.mm */; };
-		312943F91E71F2B4001EE2CC /* IOOSLayoutTestCommunication.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3148A0551E6F90F400D3B316 /* IOSLayoutTestCommunication.cpp */; };
+		312943F91E71F2B4001EE2CC /* IOSLayoutTestCommunication.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3148A0551E6F90F400D3B316 /* IOSLayoutTestCommunication.cpp */; };
 		4464CABE1C20A08B00E5BB55 /* DumpRenderTreeAppMain.mm in Sources */ = {isa = PBXBuildFile; fileRef = 4464CABD1C20A07000E5BB55 /* DumpRenderTreeAppMain.mm */; };
 		4AD6A11413C8124000EA9737 /* FormValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [216258] trunk

[bburg]

Title: [216258] trunk








Revision 216258
Author bb...@apple.com
Date 2017-05-05 12:21:37 -0700 (Fri, 05 May 2017)


Log Message
[Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
https://bugs.webkit.org/show_bug.cgi?id=171700


Reviewed by Brady Eidson.

Source/WebCore:

The function that we use to convert from WebCore::Cookie to NSHTTPCookie was
misusing the NSHTTPCookieSecure property. If any value is provided for this key,
even @NO, CFNetwork interprets that to mean that the cookie has the "secure" flag.
Thus, in some cases we would store an "insecure" cookie on a site that uses the
http:// protocol, and be unable to later retrieve the cookie. This is known to
affect cookies set via WebCookieManager, WKHTTPCookieStore, and WebAutomationSession.

This is covered by existing test WebKit2.WKHTTPCookieStore.
The test had a bug that masked this problem.

* platform/network/cocoa/CookieCocoa.mm:
(WebCore::Cookie::operator NSHTTPCookie *):
Don't include the property if the cookie is not secure.

Tools:

Fix a mistake in the test that should have caught this bug.

* TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
(TEST):
The assertions that were meant to check round-tripping were actually checking
the properties of the original cookie objects, not the round-tripped ones.
This test now fails without the bugfix and passes when it is applied.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216257 => 216258)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 19:20:32 UTC (rev 216257)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 19:21:37 UTC (rev 216258)
@@ -1,3 +1,25 @@
+2017-05-05  Brian Burg  
+
+[Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
+https://bugs.webkit.org/show_bug.cgi?id=171700
+
+
+Reviewed by Brady Eidson.
+
+The function that we use to convert from WebCore::Cookie to NSHTTPCookie was
+misusing the NSHTTPCookieSecure property. If any value is provided for this key,
+even @NO, CFNetwork interprets that to mean that the cookie has the "secure" flag.
+Thus, in some cases we would store an "insecure" cookie on a site that uses the
+http:// protocol, and be unable to later retrieve the cookie. This is known to
+affect cookies set via WebCookieManager, WKHTTPCookieStore, and WebAutomationSession.
+
+This is covered by existing test WebKit2.WKHTTPCookieStore.
+The test had a bug that masked this problem.
+
+* platform/network/cocoa/CookieCocoa.mm:
+(WebCore::Cookie::operator NSHTTPCookie *):
+Don't include the property if the cookie is not secure.
+
 2017-05-05  Wenson Hsieh  
 
 Add SPI to WebItemProviderPasteboard to synchronously load data with a given timeout


Modified: trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm (216257 => 216258)

--- trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm	2017-05-05 19:20:32 UTC (rev 216257)
+++ trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm	2017-05-05 19:21:37 UTC (rev 216258)
@@ -95,7 +95,9 @@
 if (portString)
 [properties setObject:portString forKey:NSHTTPCookiePort];
 
-[properties setObject:@(secure) forKey:NSHTTPCookieSecure];
+if (secure)
+[properties setObject:@YES forKey:NSHTTPCookieSecure];
+
 [properties setObject:(session ? @"TRUE" : @"FALSE") forKey:NSHTTPCookieDiscard];
 [properties setObject:@"1" forKey:NSHTTPCookieVersion];
 


Modified: trunk/Tools/ChangeLog (216257 => 216258)

--- trunk/Tools/ChangeLog	2017-05-05 19:20:32 UTC (rev 216257)
+++ trunk/Tools/ChangeLog	2017-05-05 19:21:37 UTC (rev 216258)
@@ -1,3 +1,19 @@
+2017-05-05  Brian Burg  
+
+[Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
+https://bugs.webkit.org/show_bug.cgi?id=171700
+
+
+Reviewed by Brady Eidson.
+
+Fix a mistake in the test that should have caught this bug.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
+(TEST):
+The assertions that were meant to check round-tripping were actually checking
+the properties of the original cookie objects, not the round-tripped ones.
+This test now fails without the bugfix and passes when it is applied.
+
 2017-05-05  Daniel Bates  
 
 Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm (216257 => 216258)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm	2017-05-05 19:20:32 UTC (rev 216257)
+++ 

[webkit-changes] [216257] trunk/Source/WebCore

[wenson_hsieh]

Title: [216257] trunk/Source/WebCore








Revision 216257
Author wenson_hs...@apple.com
Date 2017-05-05 12:20:32 -0700 (Fri, 05 May 2017)


Log Message
Add SPI to WebItemProviderPasteboard to synchronously load data with a given timeout
https://bugs.webkit.org/show_bug.cgi?id=171725


Reviewed by Beth Dakin.

Adds a synchronousTimeout: argument to doAfterLoadingProvidedContentIntoFileURLs:. If a positive timeout
interval is specified by the client, then we will block the main thread for at most that amount of time after
beginning to load from the item providers.

To do this, we introduce another `dispatch_group_t` in parallel to the `fileLoadingGroup` that is entered and
left in the same places. However, instead of attaching a handler block, we simply perform a synchronous wait for
either the time limit to be reached, or the item providers to finish loading.

No new tests -- no change in behavior yet.

* platform/ios/WebItemProviderPasteboard.h:
* platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:]):
(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h
trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216256 => 216257)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 19:16:03 UTC (rev 216256)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 19:20:32 UTC (rev 216257)
@@ -1,3 +1,26 @@
+2017-05-05  Wenson Hsieh  
+
+Add SPI to WebItemProviderPasteboard to synchronously load data with a given timeout
+https://bugs.webkit.org/show_bug.cgi?id=171725
+
+
+Reviewed by Beth Dakin.
+
+Adds a synchronousTimeout: argument to doAfterLoadingProvidedContentIntoFileURLs:. If a positive timeout
+interval is specified by the client, then we will block the main thread for at most that amount of time after
+beginning to load from the item providers.
+
+To do this, we introduce another `dispatch_group_t` in parallel to the `fileLoadingGroup` that is entered and
+left in the same places. However, instead of attaching a handler block, we simply perform a synchronous wait for
+either the time limit to be reached, or the item providers to finish loading.
+
+No new tests -- no change in behavior yet.
+
+* platform/ios/WebItemProviderPasteboard.h:
+* platform/ios/WebItemProviderPasteboard.mm:
+(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:]):
+(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
+
 2017-05-05  Chris Dumez  
 
 Clean up Attr.idl


Modified: trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h (216256 => 216257)

--- trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h	2017-05-05 19:16:03 UTC (rev 216256)
+++ trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h	2017-05-05 19:20:32 UTC (rev 216257)
@@ -47,10 +47,11 @@
 @end
 
 /*! A WebItemProviderRegistrationInfoList represents a series of registration calls used to set up a
- @discussion single item provider. The order of items specified in the list (lowest indices first) is
- the order in which objects or data are registered to the item provider, and therefore indicates the
- relative fidelity of each item. Private UTI types, such as those vended through the injected editing
- bundle SPI, are considered to be higher fidelity than the other default types.
+ single item provider.
+ @discussion The order of items specified in the list (lowest indices first) is the order in which
+ objects or data are registered to the item provider, and therefore indicates the relative fidelity
+ of each item. Private UTI types, such as those vended through the injected editing bundle SPI, are
+ considered to be higher fidelity than the other default types.
  */
 WEBCORE_EXPORT @interface WebItemProviderRegistrationInfoList : NSObject
 
@@ -88,6 +89,7 @@
 
 // The given completion block is always dispatched on the main thread.
 - (void)doAfterLoadingProvidedContentIntoFileURLs:(WebItemProviderFileLoadBlock)action;
+- (void)doAfterLoadingProvidedContentIntoFileURLs:(WebItemProviderFileLoadBlock)action synchronousTimeout:(NSTimeInterval)synchronousTimeout;
 
 @end
 


Modified: trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm (216256 => 216257)

--- trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm	2017-05-05 19:16:03 UTC (rev 216256)
+++ trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm	2017-05-05 19:20:32 UTC (rev 216257)
@@ -422,6 +422,11 @@
 
 - (void)doAfterLoadingProvidedContentIntoFileURLs:(WebItemProviderFileLoadBlock)action
 {
+[self doAfterLoadingProvidedContentIntoFileURLs:action synchronousTimeout:0];

[webkit-changes] [216256] trunk/Source/WebCore

[cdumez]

Title: [216256] trunk/Source/WebCore








Revision 216256
Author cdu...@apple.com
Date 2017-05-05 12:16:03 -0700 (Fri, 05 May 2017)


Log Message
Clean up Attr.idl
https://bugs.webkit.org/show_bug.cgi?id=171691

Reviewed by Andreas Kling.

Clean up Attr.idl to match the spec:
- https://dom.spec.whatwg.org/#interface-attr

No Web-facing behavior change except for Attr properties being enumerated
in a slightly different order.

* dom/Attr.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (216255 => 216256)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 18:45:16 UTC (rev 216255)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 19:16:03 UTC (rev 216256)
@@ -1,3 +1,18 @@
+2017-05-05  Chris Dumez  
+
+Clean up Attr.idl
+https://bugs.webkit.org/show_bug.cgi?id=171691
+
+Reviewed by Andreas Kling.
+
+Clean up Attr.idl to match the spec:
+- https://dom.spec.whatwg.org/#interface-attr
+
+No Web-facing behavior change except for Attr properties being enumerated
+in a slightly different order.
+
+* dom/Attr.idl:
+
 2017-05-05  Antti Koivisto  
 
 ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in WebCore::FrameView::layout(bool)


Modified: trunk/Source/WebCore/dom/Attr.idl (216255 => 216256)

--- trunk/Source/WebCore/dom/Attr.idl	2017-05-05 18:45:16 UTC (rev 216255)
+++ trunk/Source/WebCore/dom/Attr.idl	2017-05-05 19:16:03 UTC (rev 216256)
@@ -23,15 +23,13 @@
 JSGenerateToJSObject,
 JSGenerateToNativeObject,
 ] interface Attr : Node {
-readonly attribute DOMString? name;
-
-readonly attribute boolean specified;
-
+readonly attribute DOMString? namespaceURI;
+readonly attribute DOMString? prefix;
+readonly attribute DOMString localName;
+readonly attribute DOMString name;
 [CEReactions, ImplementedAs=valueForBindings] attribute DOMString value;
 
-readonly attribute Element ownerElement;
+readonly attribute Element? ownerElement;
 
-readonly attribute DOMString? namespaceURI;
-readonly attribute DOMString? prefix;
-readonly attribute DOMString localName;
+readonly attribute boolean specified; // Useless; always returns true.
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216255] trunk/Tools

[dbates]

Title: [216255] trunk/Tools








Revision 216255
Author dba...@webkit.org
Date 2017-05-05 11:45:16 -0700 (Fri, 05 May 2017)


Log Message
Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
https://bugs.webkit.org/show_bug.cgi?id=171698

Reviewed by Darin Adler.

We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
so that we get pretty diff output when the actual string differs from the expected
string as opposed to seeing a boolean result. The former makes makes it straightforward
to diagnose a regression without reading the code for the test or instrumenting it to
determine the actual string that was compared.

* TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
(TestWebKitAPI::TEST_F):
* TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp
trunk/Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm
trunk/Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm




Diff

Modified: trunk/Tools/ChangeLog (216254 => 216255)

--- trunk/Tools/ChangeLog	2017-05-05 18:41:36 UTC (rev 216254)
+++ trunk/Tools/ChangeLog	2017-05-05 18:45:16 UTC (rev 216255)
@@ -1,3 +1,23 @@
+2017-05-05  Daniel Bates  
+
+Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
+https://bugs.webkit.org/show_bug.cgi?id=171698
+
+Reviewed by Darin Adler.
+
+We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
+so that we get pretty diff output when the actual string differs from the expected
+string as opposed to seeing a boolean result. The former makes makes it straightforward
+to diagnose a regression without reading the code for the test or instrumenting it to
+determine the actual string that was compared.
+
+* TestWebKitAPI/Tests/WTF/WTFString.cpp:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
+(TestWebKitAPI::TEST_F):
+* TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
+(TestWebKitAPI::TEST_F):
+
 2017-05-05  Chris Dumez  
 
 Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp (216254 => 216255)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp	2017-05-05 18:41:36 UTC (rev 216254)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp	2017-05-05 18:45:16 UTC (rev 216255)
@@ -25,6 +25,7 @@
 
 #include "config.h"
 
+#include "WTFStringUtilities.h"
 #include 
 #include 
 #include 
@@ -316,33 +317,33 @@
 TEST(WTF, StringRightBasic)
 {
 auto reference = String::fromUTF8("Cappuccino");
-EXPECT_TRUE(reference.right(0) == String::fromUTF8(""));
-EXPECT_TRUE(reference.right(1) == String::fromUTF8("o"));
-EXPECT_TRUE(reference.right(2) == String::fromUTF8("no"));
-EXPECT_TRUE(reference.right(3) == String::fromUTF8("ino"));
-EXPECT_TRUE(reference.right(4) == String::fromUTF8("cino"));
-EXPECT_TRUE(reference.right(5) == String::fromUTF8("ccino"));
-EXPECT_TRUE(reference.right(6) == String::fromUTF8("uccino"));
-EXPECT_TRUE(reference.right(7) == String::fromUTF8("puccino"));
-EXPECT_TRUE(reference.right(8) == String::fromUTF8("ppuccino"));
-EXPECT_TRUE(reference.right(9) == String::fromUTF8("appuccino"));
-EXPECT_TRUE(reference.right(10) == String::fromUTF8("Cappuccino"));
+EXPECT_EQ(String::fromUTF8(""), reference.right(0));
+EXPECT_EQ(String::fromUTF8("o"), reference.right(1));
+EXPECT_EQ(String::fromUTF8("no"), reference.right(2));
+EXPECT_EQ(String::fromUTF8("ino"), reference.right(3));
+EXPECT_EQ(String::fromUTF8("cino"), reference.right(4));
+EXPECT_EQ(String::fromUTF8("ccino"), reference.right(5));
+EXPECT_EQ(String::fromUTF8("uccino"), reference.right(6));
+EXPECT_EQ(String::fromUTF8("puccino"), reference.right(7));
+EXPECT_EQ(String::fromUTF8("ppuccino"), reference.right(8));
+EXPECT_EQ(String::fromUTF8("appuccino"), reference.right(9));
+EXPECT_EQ(String::fromUTF8("Cappuccino"), reference.right(10));
 }
 
 TEST(WTF, StringLeftBasic)
 {
 auto reference = String::fromUTF8("Cappuccino");
-EXPECT_TRUE(reference.left(0) == String::fromUTF8(""));
-EXPECT_TRUE(reference.left(1) == String::fromUTF8("C"));
-EXPECT_TRUE(reference.left(2) == String::fromUTF8("Ca"));
-EXPECT_TRUE(reference.left(3) == String::fromUTF8("Cap"));
-EXPECT_TRUE(reference.left(4) == String::fromUTF8("Capp"));
-EXPECT_TRUE(reference.left(5) == String::fromUTF8("Cappu"));
-EXPECT_TRUE(reference.left(6) == String::fromUTF8("Cappuc"));
-EXPECT_TRUE(reference.left(7) == String::fromUTF8("Cappucc"));
-EXPECT_TRUE(reference.left(8) == String::fromUTF8("Cappucci"));
-

[webkit-changes] [216254] trunk/LayoutTests

[ryanhaddad]

Title: [216254] trunk/LayoutTests








Revision 216254
Author ryanhad...@apple.com
Date 2017-05-05 11:41:36 -0700 (Fri, 05 May 2017)


Log Message
Mark w3c test persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=161360

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216253 => 216254)

--- trunk/LayoutTests/ChangeLog	2017-05-05 18:39:30 UTC (rev 216253)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 18:41:36 UTC (rev 216254)
@@ -1,3 +1,12 @@
+2017-05-05  Ryan Haddad  
+
+Mark w3c test persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html as flaky on mac-wk1.
+https://bugs.webkit.org/show_bug.cgi?id=161360
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2017-05-05  Matt Lewis  
 
 Mark 2 webrtc test as failing.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (216253 => 216254)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-05 18:39:30 UTC (rev 216253)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-05 18:41:36 UTC (rev 216254)
@@ -301,7 +301,7 @@
 webkit.org/b/162591 [ Sierra+ ] css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop.html [ Pass ImageOnlyFailure ]
 webkit.org/b/162591 [ Sierra+ ] css3/filters/backdrop/backdrop-filter-with-reflection-value-change.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/161360 [ Release ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html [ Pass Failure ]
+webkit.org/b/161360 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html [ Pass Failure ]
 
 webkit.org/b/163361 imported/w3c/web-platform-tests/html/webappapis/animation-frames/callback-exception.html [ Pass Failure ]
 webkit.org/b/163361 imported/w3c/web-platform-tests/html/webappapis/animation-frames/callback-invoked.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216253] trunk/Source/WebCore

[antti]

Title: [216253] trunk/Source/WebCore








Revision 216253
Author an...@apple.com
Date 2017-05-05 11:39:30 -0700 (Fri, 05 May 2017)


Log Message
ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in WebCore::FrameView::layout(bool)
https://bugs.webkit.org/show_bug.cgi?id=171717

Reviewed by Brent Fulgham.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):

Don't allow frame load to complete in the middle of a render tree update. Instead delay the check.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216252 => 216253)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 18:22:45 UTC (rev 216252)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 18:39:30 UTC (rev 216253)
@@ -1,3 +1,15 @@
+2017-05-05  Antti Koivisto  
+
+ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in WebCore::FrameView::layout(bool)
+https://bugs.webkit.org/show_bug.cgi?id=171717
+
+Reviewed by Brent Fulgham.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::checkCompleted):
+
+Don't allow frame load to complete in the middle of a render tree update. Instead delay the check.
+
 2017-05-05  Chris Dumez  
 
 Refactor / Clean up Element.idl


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (216252 => 216253)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2017-05-05 18:22:45 UTC (rev 216252)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2017-05-05 18:39:30 UTC (rev 216253)
@@ -793,6 +793,13 @@
 if (m_isComplete)
 return;
 
+// FIXME: It would be better if resource loads were kicked off after render tree update (or didn't complete synchronously).
+//https://bugs.webkit.org/show_bug.cgi?id=171729
+if (m_frame.document()->inRenderTreeUpdate()) {
+scheduleCheckCompleted();
+return;
+}
+
 // Are we still parsing?
 if (m_frame.document()->parsing())
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216252] trunk/LayoutTests

[ryanhaddad]

Title: [216252] trunk/LayoutTests








Revision 216252
Author ryanhad...@apple.com
Date 2017-05-05 11:22:45 -0700 (Fri, 05 May 2017)


Log Message
Mark 2 webrtc test as failing.
https://bugs.webkit.org/show_bug.cgi?id=171728

Unreviewed test gardening.

Patch by Matt Lewis  on 2017-05-05

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216251 => 216252)

--- trunk/LayoutTests/ChangeLog	2017-05-05 18:14:12 UTC (rev 216251)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 18:22:45 UTC (rev 216252)
@@ -1,3 +1,12 @@
+2017-05-05  Matt Lewis  
+
+Mark 2 webrtc test as failing.
+https://bugs.webkit.org/show_bug.cgi?id=171728
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2017-05-05  Chris Dumez  
 
 Refactor / Clean up Element.idl


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216251 => 216252)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-05 18:14:12 UTC (rev 216251)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-05 18:22:45 UTC (rev 216252)
@@ -1969,3 +1969,7 @@
 webkit.org/b/171628 scrollingcoordinator/ios/nested-fixed-layer-positions.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
+
+webkit.org/b/171728 webrtc/audio-replace-track.html [ Failure ]
+
+webkit.org/b/171728 webrtc/video-replace-track.html [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216251] trunk

[cdumez]

Title: [216251] trunk








Revision 216251
Author cdu...@apple.com
Date 2017-05-05 11:14:12 -0700 (Fri, 05 May 2017)


Log Message
Refactor / Clean up Element.idl
https://bugs.webkit.org/show_bug.cgi?id=171734

Reviewed by Sam Weinig.

Source/WebCore:

Refactor / Clean up Element.idl to match the latest specification:
- https://dom.spec.whatwg.org/#interface-element

There is no Web-facing behavior change in this patch besides the Element properties
being enumerated in a slightly different order. Things that do not match the
specification have merely been annotated with FIXME comments for now. This makes
it much more obvious what's standard, what's not and what needs fixing.

* dom/Element.idl:

LayoutTests:

Rebaseline a couple of tests due to Element properties being enumerated in a slightly
different order and because exception messages have changed slightly.

* fast/dom/Element/attr-param-typechecking-expected.txt:
* js/dom/dom-static-property-for-in-iteration-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt
trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (216250 => 216251)

--- trunk/LayoutTests/ChangeLog	2017-05-05 18:13:18 UTC (rev 216250)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 18:14:12 UTC (rev 216251)
@@ -1,3 +1,16 @@
+2017-05-05  Chris Dumez  
+
+Refactor / Clean up Element.idl
+https://bugs.webkit.org/show_bug.cgi?id=171734
+
+Reviewed by Sam Weinig.
+
+Rebaseline a couple of tests due to Element properties being enumerated in a slightly
+different order and because exception messages have changed slightly.
+
+* fast/dom/Element/attr-param-typechecking-expected.txt:
+* js/dom/dom-static-property-for-in-iteration-expected.txt:
+
 2017-05-05  Jeremy Jones  
 
 REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash


Modified: trunk/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt (216250 => 216251)

--- trunk/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt	2017-05-05 18:13:18 UTC (rev 216250)
+++ trunk/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt	2017-05-05 18:14:12 UTC (rev 216251)
@@ -3,18 +3,18 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS element.setAttributeNode("style"); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNode must be an instance of Attr.
-PASS element.setAttributeNode(null); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNode must be an instance of Attr.
-PASS element.setAttributeNode(undefined); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNode must be an instance of Attr.
-PASS element.setAttributeNode(new Object); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNode must be an instance of Attr.
-PASS element.removeAttributeNode("style"); threw exception TypeError: Argument 1 ('oldAttr') to Element.removeAttributeNode must be an instance of Attr.
-PASS element.removeAttributeNode(null); threw exception TypeError: Argument 1 ('oldAttr') to Element.removeAttributeNode must be an instance of Attr.
-PASS element.removeAttributeNode(undefined); threw exception TypeError: Argument 1 ('oldAttr') to Element.removeAttributeNode must be an instance of Attr.
-PASS element.removeAttributeNode(new Object); threw exception TypeError: Argument 1 ('oldAttr') to Element.removeAttributeNode must be an instance of Attr.
-PASS element.setAttributeNodeNS("style"); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNodeNS must be an instance of Attr.
-PASS element.setAttributeNodeNS(null); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNodeNS must be an instance of Attr.
-PASS element.setAttributeNodeNS(undefined); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNodeNS must be an instance of Attr.
-PASS element.setAttributeNodeNS(new Object); threw exception TypeError: Argument 1 ('newAttr') to Element.setAttributeNodeNS must be an instance of Attr.
+PASS element.setAttributeNode("style"); threw exception TypeError: Argument 1 ('attr') to Element.setAttributeNode must be an instance of Attr.
+PASS element.setAttributeNode(null); threw exception TypeError: Argument 1 ('attr') to Element.setAttributeNode must be an instance of Attr.
+PASS element.setAttributeNode(undefined); threw exception TypeError: Argument 1 ('attr') to Element.setAttributeNode must be an instance of Attr.
+PASS element.setAttributeNode(new Object); threw exception TypeError: Argument 1 ('attr') to Element.setAttributeNode must be an instance of Attr.
+PASS 

[webkit-changes] [216250] trunk/Source/WebCore

[timothy_horton]

Title: [216250] trunk/Source/WebCore








Revision 216250
Author timothy_hor...@apple.com
Date 2017-05-05 11:13:18 -0700 (Fri, 05 May 2017)


Log Message
Link drag images for apple.com front page links have a lot of spurious whitespace
https://bugs.webkit.org/show_bug.cgi?id=171719


Reviewed by Wenson Hsieh.

* page/DragController.cpp:
(WebCore::DragController::startDrag):
Use the white-space-simplified string that we put on the pasteboard
for the drag image, too!

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DragController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216249 => 216250)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 18:11:46 UTC (rev 216249)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 18:13:18 UTC (rev 216250)
@@ -1,3 +1,16 @@
+2017-05-05  Tim Horton  
+
+Link drag images for apple.com front page links have a lot of spurious whitespace
+https://bugs.webkit.org/show_bug.cgi?id=171719
+
+
+Reviewed by Wenson Hsieh.
+
+* page/DragController.cpp:
+(WebCore::DragController::startDrag):
+Use the white-space-simplified string that we put on the pasteboard
+for the drag image, too!
+
 2017-05-04  Mark Lam  
 
 DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.


Modified: trunk/Source/WebCore/page/DragController.cpp (216249 => 216250)

--- trunk/Source/WebCore/page/DragController.cpp	2017-05-05 18:11:46 UTC (rev 216249)
+++ trunk/Source/WebCore/page/DragController.cpp	2017-05-05 18:13:18 UTC (rev 216250)
@@ -1001,13 +1001,15 @@
 if (!linkURL.isEmpty() && (m_dragSourceAction & DragSourceActionLink)) {
 PasteboardWriterData pasteboardWriterData;
 
+String textContentWithSimplifiedWhiteSpace = hitTestResult.textContent().simplifyWhiteSpace();
+
 if (!dataTransfer.pasteboard().hasData()) {
 // Simplify whitespace so the title put on the dataTransfer resembles what the user sees
 // on the web page. This includes replacing newlines with spaces.
 if (mustUseLegacyDragClient)
-src.editor().copyURL(linkURL, hitTestResult.textContent().simplifyWhiteSpace(), dataTransfer.pasteboard());
+src.editor().copyURL(linkURL, textContentWithSimplifiedWhiteSpace, dataTransfer.pasteboard());
 else
-pasteboardWriterData.setURL(src.editor().pasteboardWriterURL(linkURL, hitTestResult.textContent().simplifyWhiteSpace()));
+pasteboardWriterData.setURL(src.editor().pasteboardWriterURL(linkURL, textContentWithSimplifiedWhiteSpace));
 } else {
 // Make sure the pasteboard also contains trustworthy link data
 // but don't overwrite more general pasteboard types.
@@ -1031,7 +1033,7 @@
 m_client.willPerformDragSourceAction(DragSourceActionLink, dragOrigin, dataTransfer);
 if (!dragImage) {
 TextIndicatorData textIndicator;
-dragImage = DragImage { createDragImageForLink(element, linkURL, hitTestResult.textContent(), textIndicator, src.settings().fontRenderingMode(), m_page.deviceScaleFactor()) };
+dragImage = DragImage { createDragImageForLink(element, linkURL, textContentWithSimplifiedWhiteSpace, textIndicator, src.settings().fontRenderingMode(), m_page.deviceScaleFactor()) };
 if (dragImage) {
 IntSize size = dragImageSize(dragImage.get());
 m_dragOffset = IntPoint(-size.width() / 2, -LinkDragBorderInset);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216249] trunk

[cdumez]

Title: [216249] trunk








Revision 216249
Author cdu...@apple.com
Date 2017-05-05 11:11:46 -0700 (Fri, 05 May 2017)


Log Message
Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
https://bugs.webkit.org/show_bug.cgi?id=171624

Reviewed by Dan Bernstein.

Source/WebKit2:

Follow-up fixes after r216129 based on feedback I have received:
- Rename webProcessDidCrashWithReason callback function to webProcessDidTerminate given that this is called
  for non-crashes (e.g. terminations requested by the client).
- Rename WKProcessCrashReason / ProcessCrashReason to WKProcessTerminationReason / ProcessTerminationReason
  for consistency with the new naming.
- Stop calling processDidCrash / webProcessDidCrash for terminations requested by the client, to maintain
  pre-r216129 behavior. Those are not crashes (The client used an API such as WKPageTerminateProcess()).
  webProcessDidTerminate will still be called though.
- Fix a bug where - for terminations due to resource limits - WebPageProxy::processDidCrash() was getting
  called twice: First by WebProcessProxy::requestTermination() with reason "RequestedByClient" then a
  second time by WebProcessProxy::terminateProcessDueToResourceLimits() with the proper reason.

* Shared/ProcessTerminationReason.h: Renamed from Source/WebKit2/Shared/ProcessCrashReason.h.
* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::processDidTerminate):
* UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
* UIProcess/API/C/WKPage.cpp:
(WKPageTerminate):
(WKPageSetPageNavigationClient):
* UIProcess/API/C/WKPageNavigationClient.h:
* UIProcess/API/C/WKProcessTerminationReason.h: Renamed from Source/WebKit2/UIProcess/API/C/WKProcessCrashReason.h.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _killWebContentProcessAndResetState]):
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::processDidTerminate):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidTerminate):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::requestTermination):
(WebKit::WebProcessProxy::logDiagnosticMessageForResourceLimitTermination):
(WebKit::WebProcessProxy::didExceedActiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedInactiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):
* UIProcess/WebProcessProxy.h:
* WebKit2.xcodeproj/project.pbxproj:

Tools:

Extend API test coverage to cover crashes in addition to terminations requested by the client.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
(TestWebKitAPI::webProcessWasTerminatedByClient):
(TestWebKitAPI::webProcessCrashed):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APINavigationClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPageNavigationClient.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/Shared/ProcessTerminationReason.h
trunk/Source/WebKit2/UIProcess/API/C/WKProcessTerminationReason.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp


Removed Paths

trunk/Source/WebKit2/Shared/ProcessCrashReason.h
trunk/Source/WebKit2/UIProcess/API/C/WKProcessCrashReason.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216248 => 216249)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 18:10:41 UTC (rev 216248)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 18:11:46 UTC (rev 216249)
@@ -1,3 +1,50 @@
+2017-05-05  Chris Dumez  
+
+Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
+https://bugs.webkit.org/show_bug.cgi?id=171624
+
+Reviewed by Dan Bernstein.
+
+Follow-up fixes after r216129 based on feedback I have received:
+- Rename webProcessDidCrashWithReason callback function to webProcessDidTerminate given that this is called
+  for non-crashes (e.g. terminations requested by the client).
+- Rename WKProcessCrashReason / ProcessCrashReason to WKProcessTerminationReason / 

[webkit-changes] [216248] trunk/Source/WebKit2

[commit-queue]

Title: [216248] trunk/Source/WebKit2








Revision 216248
Author commit-qu...@webkit.org
Date 2017-05-05 11:10:41 -0700 (Fri, 05 May 2017)


Log Message
Mac cmake buildfix after r216037
https://bugs.webkit.org/show_bug.cgi?id=171558

Patch by Derek Schuff  on 2017-05-05
Reviewed by JF Bastien.

* PlatformMac.cmake:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216247 => 216248)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 17:35:53 UTC (rev 216247)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 18:10:41 UTC (rev 216248)
@@ -1,3 +1,12 @@
+2017-05-05  Derek Schuff  
+
+Mac cmake buildfix after r216037
+https://bugs.webkit.org/show_bug.cgi?id=171558
+
+Reviewed by JF Bastien.
+
+* PlatformMac.cmake:
+
 2017-05-05  Carlos Alberto Lopez Perez  
 
 [GTK] Enable runtime flag for MediaDevices with enable-media-stream property.


Modified: trunk/Source/WebKit2/PlatformMac.cmake (216247 => 216248)

--- trunk/Source/WebKit2/PlatformMac.cmake	2017-05-05 17:35:53 UTC (rev 216247)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2017-05-05 18:10:41 UTC (rev 216248)
@@ -212,7 +212,7 @@
 UIProcess/API/Cocoa/WKScriptMessage.mm
 UIProcess/API/Cocoa/WKSecurityOrigin.mm
 UIProcess/API/Cocoa/WKTypeRefWrapper.mm
-UIProcess/API/Cocoa/WKURLSchemeHandlerTask.mm
+UIProcess/API/Cocoa/WKURLSchemeTask.mm
 UIProcess/API/Cocoa/WKUserContentController.mm
 UIProcess/API/Cocoa/WKUserScript.mm
 UIProcess/API/Cocoa/WKWebView.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216246] trunk

[mark . lam]

Title: [216246] trunk








Revision 216246
Author mark@apple.com
Date 2017-05-05 09:14:49 -0700 (Fri, 05 May 2017)


Log Message
DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
https://bugs.webkit.org/show_bug.cgi?id=171716


Reviewed by Saam Barati.

Source/WebCore:

No new tests.  This issue was caught by existing tests.

IDBRequest::setResult() needs to acquire the JSLock before calling toJS() (which
does JS conversion and therefore, potentially JS allocations).

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):

Tools:

setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
does JS conversion and therefore, potentially JS allocations) and accessing
methods of internal JS data structures (which may do JS invocation, etc).

* DumpRenderTree/TestRunner.cpp:
(setAudioResultCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestRunner.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216245 => 216246)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 15:49:54 UTC (rev 216245)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 16:14:49 UTC (rev 216246)
@@ -1,3 +1,20 @@
+2017-05-04  Mark Lam  
+
+DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
+https://bugs.webkit.org/show_bug.cgi?id=171716
+
+
+Reviewed by Saam Barati.
+
+No new tests.  This issue was caught by existing tests.
+
+IDBRequest::setResult() needs to acquire the JSLock before calling toJS() (which
+does JS conversion and therefore, potentially JS allocations).
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::setResult):
+(WebCore::IDBRequest::setResultToStructuredClone):
+
 2017-05-05  Carlos Garcia Campos  
 
 [GStreamer] Do not report more errors after the first one


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (216245 => 216246)

--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2017-05-05 15:49:54 UTC (rev 216245)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2017-05-05 16:14:49 UTC (rev 216246)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015, 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -370,7 +370,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 // of the IDBRequest wrapper can be used, rather than the lexicalGlobalObject.
-m_result = Result { JSC::Strong { context->vm(), toJS(*state, *jsCast(state->lexicalGlobalObject()), keyData) } };
+VM& vm = context->vm();
+JSLockHolder lock(vm);
+m_result = Result { JSC::Strong { vm, toJS(*state, *jsCast(state->lexicalGlobalObject()), keyData) } };
 }
 
 void IDBRequest::setResult(const Vector& keyDatas)
@@ -387,8 +389,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 // of the IDBRequest wrapper can be used, rather than the lexicalGlobalObject.
-Locker locker(context->vm().apiLock());
-m_result = Result { JSC::Strong { context->vm(), toJS(*state, *jsCast(state->lexicalGlobalObject()), keyDatas) } };
+VM& vm = context->vm();
+JSLockHolder lock(vm);
+m_result = Result { JSC::Strong { vm, toJS(*state, *jsCast(state->lexicalGlobalObject()), keyDatas) } };
 }
 
 void IDBRequest::setResult(const Vector& values)
@@ -405,8 +408,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 // of the IDBRequest wrapper can be used, rather than the lexicalGlobalObject.
-Locker locker(context->vm().apiLock());
-m_result = Result { JSC::Strong { context->vm(), toJS(*state, *jsCast(state->lexicalGlobalObject()), values) } };
+VM& vm = context->vm();
+JSLockHolder lock(vm);
+m_result = Result { JSC::Strong { vm, toJS(*state, *jsCast(state->lexicalGlobalObject()), values) } };
 }
 
 void IDBRequest::setResult(uint64_t number)
@@ -436,7 +440,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 // of the IDBRequest wrapper can be used, rather than the lexicalGlobalObject.
-m_result = Result { JSC::Strong { context->vm(), toJS(*state, *jsCast(state->lexicalGlobalObject()), value) } };
+VM& vm = context->vm();
+JSLockHolder lock(vm);
+m_result 

[webkit-changes] [216245] trunk

[commit-queue]

Title: [216245] trunk








Revision 216245
Author commit-qu...@webkit.org
Date 2017-05-05 08:49:54 -0700 (Fri, 05 May 2017)


Log Message
REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=171610


Patch by Jeremy Jones  on 2017-05-05
Reviewed by Eric Carlson.

Source/WebKit/mac:

Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):

LayoutTests:

enable test: media/modern-media-controls/pip-support/pip-support-click.html

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (216244 => 216245)

--- trunk/LayoutTests/ChangeLog	2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 15:49:54 UTC (rev 216245)
@@ -1,3 +1,15 @@
+2017-05-05  Jeremy Jones  
+
+REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=171610
+
+
+Reviewed by Eric Carlson.
+
+enable test: media/modern-media-controls/pip-support/pip-support-click.html
+
+* platform/mac-wk1/TestExpectations:
+
 2017-05-05  Carlos Garcia Campos  
 
 Unreviewed GTK+ gardening. Update expectations of tests failing after GST upgrade to 1.10.4.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (216244 => 216245)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-05 15:49:54 UTC (rev 216245)
@@ -347,7 +347,6 @@
 webkit.org/b/169117 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-audio-background.html [ Pass Timeout ]
 webkit.org/b/170456 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html [ Pass Timeout ]
 webkit.org/b/167752 media/modern-media-controls/icon-button/icon-button-active-state.html [ Pass Timeout ]
-webkit.org/b/171610 media/modern-media-controls/pip-support/pip-support-click.html [ Skip ]
 webkit.org/b/167477 [ Debug ] media/modern-media-controls/play-pause-button/play-pause-button.html [ Pass Timeout ]
 webkit.org/b/171245 [ Debug ] media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Pass Timeout ]
 webkit.org/b/171629 media/modern-media-controls/slider/slider-styles.html [ Pass Timeout ]


Modified: trunk/Source/WebKit/mac/ChangeLog (216244 => 216245)

--- trunk/Source/WebKit/mac/ChangeLog	2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-05-05 15:49:54 UTC (rev 216245)
@@ -1,3 +1,17 @@
+2017-05-05  Jeremy Jones  
+
+REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=171610
+
+
+Reviewed by Eric Carlson.
+
+Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
+
+* WebCoreSupport/WebChromeClient.h:
+* WebCoreSupport/WebChromeClient.mm:
+(WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
+
 2017-05-04  Commit Queue  
 
 Unreviewed, rolling out r216206.


Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (216244 => 216245)

--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h	2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h	2017-05-05 15:49:54 UTC (rev 216245)
@@ -187,6 +187,7 @@
 bool supportsVideoFullscreen(WebCore::HTMLMediaElementEnums::VideoFullscreenMode) final;
 void enterVideoFullscreenForVideoElement(WebCore::HTMLVideoElement&, WebCore::HTMLMediaElementEnums::VideoFullscreenMode) final;
 void exitVideoFullscreenForVideoElement(WebCore::HTMLVideoElement&) final;
+void exitVideoFullscreenToModeWithoutAnimation(WebCore::HTMLVideoElement&, WebCore::HTMLMediaElementEnums::VideoFullscreenMode) final;
 #endif
 
 #if ENABLE(FULLSCREEN_API)


Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (216244 => 216245)

--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm	2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm	2017-05-05 15:49:54 UTC (rev 216245)
@@ -974,6 +974,13 @@
 END_BLOCK_OBJC_EXCEPTIONS;
 }
 

[webkit-changes] [216244] trunk/Tools

[jbedard]

Title: [216244] trunk/Tools








Revision 216244
Author jbed...@apple.com
Date 2017-05-05 08:33:18 -0700 (Fri, 05 May 2017)


Log Message
buildbot: Cleanup simulators after running tests
https://bugs.webkit.org/show_bug.cgi?id=171679


Reviewed by Aakash Jain.

We shutdown the simulator process between tests, but in some cases, this is not
sufficient. Explicitly shutdown every booted simulator.

* BuildSlaveSupport/kill-old-processes:
(main): Shutdown all booted simulators.

Modified Paths

trunk/Tools/BuildSlaveSupport/kill-old-processes
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/kill-old-processes (216243 => 216244)

--- trunk/Tools/BuildSlaveSupport/kill-old-processes	2017-05-05 13:37:13 UTC (rev 216243)
+++ trunk/Tools/BuildSlaveSupport/kill-old-processes	2017-05-05 15:33:18 UTC (rev 216244)
@@ -112,6 +112,8 @@
 if sys.platform == 'darwin':
 for task in tasksToKill + tasksToKillMac:
 os.system("killall -9 -v -m " + task)
+# Shutdown any simulators
+os.system("xcrun simctl shutdown booted")
 # Kill all instances of python executing run-webkit-tests
 os.system("ps aux | grep -E '.+/Python .+(run_webkit_tests|run-webkit-tests|mod_pywebsocket)' | grep -v grep | awk '{print $2}' | xargs kill")
 elif sys.platform == 'cygwin' or sys.platform == 'win32':


Modified: trunk/Tools/ChangeLog (216243 => 216244)

--- trunk/Tools/ChangeLog	2017-05-05 13:37:13 UTC (rev 216243)
+++ trunk/Tools/ChangeLog	2017-05-05 15:33:18 UTC (rev 216244)
@@ -1,3 +1,17 @@
+2017-05-05  Jonathan Bedard  
+
+buildbot: Cleanup simulators after running tests
+https://bugs.webkit.org/show_bug.cgi?id=171679
+
+
+Reviewed by Aakash Jain.
+
+We shutdown the simulator process between tests, but in some cases, this is not
+sufficient. Explicitly shutdown every booted simulator.
+
+* BuildSlaveSupport/kill-old-processes:
+(main): Shutdown all booted simulators.
+
 2017-05-05  Carlos Garcia Campos  
 
 [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216243] trunk

[carlosgc]

Title: [216243] trunk








Revision 216243
Author carlo...@webkit.org
Date 2017-05-05 06:37:13 -0700 (Fri, 05 May 2017)


Log Message
[GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=171644

Reviewed by Michael Catanzaro.

Source/_javascript_Core:

Fix ASSERT that requires given client to be a valid pointer, since it's valid to pass nullptr to unset the
client. The ASSERT now ensures that client is set or unset. I also renamed the function to setClient because
setRemoteInspectorClient is redundant for a class named RemoteInspector. And added a getter too, to check if the
remote inspector has a client.

* inspector/remote/RemoteInspector.cpp:
(Inspector::RemoteInspector::setClient):
* inspector/remote/RemoteInspector.h:

Source/WebKit2:

Ensure that it's not possible to enable automation in more than one WebKitWebContext at the same time. Instead
of creating the AutomationClient unconditionally when the context is constructed, it's now created only when
automation is enabled, and deleted if it's disabled.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
(webkit_web_context_is_automation_allowed):
(webkit_web_context_set_automation_allowed):
* UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::AutomationClient):
(WebKit::AutomationClient::~AutomationClient):

Tools:

Check that only one WebKitWebContext can have automation enabled.

* TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
(testAutomationSessionRequestSession):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/Cocoa/AutomationClient.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216242 => 216243)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-05 13:29:56 UTC (rev 216242)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-05 13:37:13 UTC (rev 216243)
@@ -1,3 +1,19 @@
+2017-05-05  Carlos Garcia Campos  
+
+[GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
+https://bugs.webkit.org/show_bug.cgi?id=171644
+
+Reviewed by Michael Catanzaro.
+
+Fix ASSERT that requires given client to be a valid pointer, since it's valid to pass nullptr to unset the
+client. The ASSERT now ensures that client is set or unset. I also renamed the function to setClient because
+setRemoteInspectorClient is redundant for a class named RemoteInspector. And added a getter too, to check if the
+remote inspector has a client.
+
+* inspector/remote/RemoteInspector.cpp:
+(Inspector::RemoteInspector::setClient):
+* inspector/remote/RemoteInspector.h:
+
 2017-05-04  Commit Queue  
 
 Unreviewed, rolling out r216206.


Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp (216242 => 216243)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp	2017-05-05 13:29:56 UTC (rev 216242)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp	2017-05-05 13:37:13 UTC (rev 216243)
@@ -140,10 +140,9 @@
 }
 }
 
-void RemoteInspector::setRemoteInspectorClient(RemoteInspector::Client* client)
+void RemoteInspector::setClient(RemoteInspector::Client* client)
 {
-ASSERT_ARG(client, client);
-ASSERT(!m_client);
+ASSERT((m_client && !client) || (!m_client && client));
 
 {
 std::lock_guard lock(m_mutex);


Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h (216242 => 216243)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2017-05-05 13:29:56 UTC (rev 216242)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2017-05-05 13:37:13 UTC (rev 216243)
@@ -82,7 +82,8 @@
 void updateTarget(RemoteControllableTarget*);
 void sendMessageToRemote(unsigned targetIdentifier, const String& message);
 
-void setRemoteInspectorClient(RemoteInspector::Client*);
+RemoteInspector::Client* client() const { return m_client; }
+void setClient(RemoteInspector::Client*);
 void clientCapabilitiesDidChange();
 
 void setupFailed(unsigned targetIdentifier);


Modified: trunk/Source/WebKit2/ChangeLog (216242 => 216243)

--- trunk/Source/WebKit2/ChangeLog	2017-05-05 13:29:56 UTC (rev 216242)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-05 13:37:13 UTC (rev 216243)
@@ -1,3 +1,22 @@
+2017-05-05  Carlos Garcia Campos  
+
+[GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing 

[webkit-changes] [216242] trunk/LayoutTests

[carlosgc]

Title: [216242] trunk/LayoutTests








Revision 216242
Author carlo...@webkit.org
Date 2017-05-05 06:29:56 -0700 (Fri, 05 May 2017)


Log Message
Unreviewed GTK+ gardening. Update expectations of tests failing after GST upgrade to 1.10.4.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216241 => 216242)

--- trunk/LayoutTests/ChangeLog	2017-05-05 13:20:15 UTC (rev 216241)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 13:29:56 UTC (rev 216242)
@@ -1,5 +1,11 @@
 2017-05-05  Carlos Garcia Campos  
 
+Unreviewed GTK+ gardening. Update expectations of tests failing after GST upgrade to 1.10.4.
+
+* platform/gtk/TestExpectations:
+
+2017-05-05  Carlos Garcia Campos  
+
 Unreviewed GTK+ gardening. Rebaseline several tests.
 
 * platform/gtk/editing/simple-line-layout-caret-is-gone-expected.txt: Added.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (216241 => 216242)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-05-05 13:20:15 UTC (rev 216241)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-05-05 13:29:56 UTC (rev 216242)
@@ -3684,6 +3684,11 @@
 
 webkit.org/b/171598 accessibility/gtk/menu-list-unfocused-notifications.html [ Failure ]
 
+webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html [ Failure ]
+webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Failure ]
+webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure ]
+webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Failure ]
+
 #
 # End of non-crashing, non-flaky tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216241] trunk/Tools

[carlosgc]

Title: [216241] trunk/Tools








Revision 216241
Author carlo...@webkit.org
Date 2017-05-05 06:20:15 -0700 (Fri, 05 May 2017)


Log Message
[GTK] TestController timeout source callback should return G_SOURCE_REMOVE
https://bugs.webkit.org/show_bug.cgi?id=171724

Reviewed by Michael Catanzaro.

It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.

* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::timeoutSource):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp




Diff

Modified: trunk/Tools/ChangeLog (216240 => 216241)

--- trunk/Tools/ChangeLog	2017-05-05 12:05:39 UTC (rev 216240)
+++ trunk/Tools/ChangeLog	2017-05-05 13:20:15 UTC (rev 216241)
@@ -1,5 +1,17 @@
 2017-05-05  Carlos Garcia Campos  
 
+[GTK] TestController timeout source callback should return G_SOURCE_REMOVE
+https://bugs.webkit.org/show_bug.cgi?id=171724
+
+Reviewed by Michael Catanzaro.
+
+It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
+
+* WebKitTestRunner/gtk/TestControllerGtk.cpp:
+(WTR::timeoutSource):
+
+2017-05-05  Carlos Garcia Campos  
+
 Unreviewed. Fix wrong assert after r215176.
 
 Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it


Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (216240 => 216241)

--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2017-05-05 12:05:39 UTC (rev 216240)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2017-05-05 13:20:15 UTC (rev 216241)
@@ -48,7 +48,7 @@
 g_source_set_ready_time(static_cast(userData), -1);
 fprintf(stderr, "FAIL: TestControllerRunLoop timed out.\n");
 RunLoop::main().stop();
-return G_SOURCE_CONTINUE;
+return G_SOURCE_REMOVE;
 }, source.get(), nullptr);
 g_source_attach(source.get(), nullptr);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216240] trunk/Source/WebCore

[carlosgc]

Title: [216240] trunk/Source/WebCore








Revision 216240
Author carlo...@webkit.org
Date 2017-05-05 05:05:39 -0700 (Fri, 05 May 2017)


Log Message
[GStreamer] Do not report more errors after the first one
https://bugs.webkit.org/show_bug.cgi?id=171722

Reviewed by Xabier Rodriguez-Calvar.

We can receive several error messages for the same error from different elements. That's not expected by the
media source selection algorithm implementation. I don't know if didn't happen with previous versions of GST,
but since the upgrade to 1.10.4 several tests are failing because of this.

Fixes: media/video-error-does-not-exist.html
   media/video-load-networkState.html
   media/video-source-error.html
   media/video-source-none-supported.html
   media/video-source-moved.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Return early also when an error already occured.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216239 => 216240)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 12:02:33 UTC (rev 216239)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 12:05:39 UTC (rev 216240)
@@ -1,5 +1,25 @@
 2017-05-05  Carlos Garcia Campos  
 
+[GStreamer] Do not report more errors after the first one
+https://bugs.webkit.org/show_bug.cgi?id=171722
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+We can receive several error messages for the same error from different elements. That's not expected by the
+media source selection algorithm implementation. I don't know if didn't happen with previous versions of GST,
+but since the upgrade to 1.10.4 several tests are failing because of this.
+
+Fixes: media/video-error-does-not-exist.html
+   media/video-load-networkState.html
+   media/video-source-error.html
+   media/video-source-none-supported.html
+   media/video-source-moved.html
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Return early also when an error already occured.
+
+2017-05-05  Carlos Garcia Campos  
+
 [GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
 https://bugs.webkit.org/show_bug.cgi?id=171721
 


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (216239 => 216240)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-05 12:02:33 UTC (rev 216239)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-05 12:05:39 UTC (rev 216240)
@@ -937,10 +937,8 @@
 GST_DEBUG("Message %s received from element %s", GST_MESSAGE_TYPE_NAME(message), GST_MESSAGE_SRC_NAME(message));
 switch (GST_MESSAGE_TYPE(message)) {
 case GST_MESSAGE_ERROR:
-if (m_resetPipeline)
+if (m_resetPipeline || m_missingPluginsCallback || m_errorOccured)
 break;
-if (m_missingPluginsCallback)
-break;
 gst_message_parse_error(message, (), ());
 GST_ERROR("Error %d: %s (url="" err->code, err->message, m_url.string().utf8().data());
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216239] trunk/Source/WebCore

[carlosgc]

Title: [216239] trunk/Source/WebCore








Revision 216239
Author carlo...@webkit.org
Date 2017-05-05 05:02:33 -0700 (Fri, 05 May 2017)


Log Message
[GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
https://bugs.webkit.org/show_bug.cgi?id=171721

Reviewed by Xabier Rodriguez-Calvar.

We are checking the GError only comparing the code, and ignoring the domain in some cases. Use g_error_matches()
in those cases instead of only checking the code.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216238 => 216239)

--- trunk/Source/WebCore/ChangeLog	2017-05-05 11:56:22 UTC (rev 216238)
+++ trunk/Source/WebCore/ChangeLog	2017-05-05 12:02:33 UTC (rev 216239)
@@ -1,3 +1,16 @@
+2017-05-05  Carlos Garcia Campos  
+
+[GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
+https://bugs.webkit.org/show_bug.cgi?id=171721
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+We are checking the GError only comparing the code, and ignoring the domain in some cases. Use g_error_matches()
+in those cases instead of only checking the code.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+
 2017-05-04  Commit Queue  
 
 Unreviewed, rolling out r216206.


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (216238 => 216239)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-05 11:56:22 UTC (rev 216238)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-05 12:02:33 UTC (rev 216239)
@@ -947,20 +947,19 @@
 GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_ALL, "webkit-video.error");
 
 error = MediaPlayer::Empty;
-if (err->code == GST_STREAM_ERROR_CODEC_NOT_FOUND
-|| err->code == GST_STREAM_ERROR_WRONG_TYPE
-|| err->code == GST_STREAM_ERROR_FAILED
-|| err->code == GST_CORE_ERROR_MISSING_PLUGIN
-|| err->code == GST_RESOURCE_ERROR_NOT_FOUND)
+if (g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_CODEC_NOT_FOUND)
+|| g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_WRONG_TYPE)
+|| g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_FAILED)
+|| g_error_matches(err.get(), GST_CORE_ERROR, GST_CORE_ERROR_MISSING_PLUGIN)
+|| g_error_matches(err.get(), GST_RESOURCE_ERROR, GST_RESOURCE_ERROR_NOT_FOUND))
 error = MediaPlayer::FormatError;
-else if (err->domain == GST_STREAM_ERROR) {
+else if (g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_TYPE_NOT_FOUND)) {
 // Let the mediaPlayerClient handle the stream error, in
 // this case the HTMLMediaElement will emit a stalled
 // event.
-if (err->code == GST_STREAM_ERROR_TYPE_NOT_FOUND) {
-GST_ERROR("Decode error, let the Media element emit a stalled event.");
-break;
-}
+GST_ERROR("Decode error, let the Media element emit a stalled event.");
+break;
+} else if (err->domain == GST_STREAM_ERROR) {
 error = MediaPlayer::DecodeError;
 attemptNextLocation = true;
 } else if (err->domain == GST_RESOURCE_ERROR)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216238] trunk/LayoutTests

[carlosgc]

Title: [216238] trunk/LayoutTests








Revision 216238
Author carlo...@webkit.org
Date 2017-05-05 04:56:22 -0700 (Fri, 05 May 2017)


Log Message
Unreviewed GTK+ gardening. Rebaseline several tests.

* platform/gtk/editing/simple-line-layout-caret-is-gone-expected.txt: Added.
* platform/gtk/fast/repaint/mutate-non-visible-expected.txt: Added.
* platform/gtk/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt:
* platform/gtk/http/tests/security/video-cross-origin-accessfailure-expected.txt: Added.
* platform/gtk/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt


Added Paths

trunk/LayoutTests/platform/gtk/editing/simple-line-layout-caret-is-gone-expected.txt
trunk/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt
trunk/LayoutTests/platform/gtk/http/tests/security/video-cross-origin-accessfailure-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/http-cache/
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (216237 => 216238)

--- trunk/LayoutTests/ChangeLog	2017-05-05 08:53:23 UTC (rev 216237)
+++ trunk/LayoutTests/ChangeLog	2017-05-05 11:56:22 UTC (rev 216238)
@@ -1,3 +1,13 @@
+2017-05-05  Carlos Garcia Campos  
+
+Unreviewed GTK+ gardening. Rebaseline several tests.
+
+* platform/gtk/editing/simple-line-layout-caret-is-gone-expected.txt: Added.
+* platform/gtk/fast/repaint/mutate-non-visible-expected.txt: Added.
+* platform/gtk/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt:
+* platform/gtk/http/tests/security/video-cross-origin-accessfailure-expected.txt: Added.
+* platform/gtk/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt: Added.
+
 2017-05-05  Zan Dobersek  
 
 Unreviewed GTK+ gardening.


Added: trunk/LayoutTests/platform/gtk/editing/simple-line-layout-caret-is-gone-expected.txt (0 => 216238)

--- trunk/LayoutTests/platform/gtk/editing/simple-line-layout-caret-is-gone-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/simple-line-layout-caret-is-gone-expected.txt	2017-05-05 11:56:22 UTC (rev 216238)
@@ -0,0 +1 @@
+34 0 1 17


Added: trunk/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt (0 => 216238)

--- trunk/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt	2017-05-05 11:56:22 UTC (rev 216238)
@@ -0,0 +1,7 @@
+Test repaint-only style changes in non-visible elements don't trigger repaints.
+(repaint rects
+  (rect 10 27 100 100)
+  (rect 10 27 100 100)
+  (rect 10 27 100 100)
+)
+


Modified: trunk/LayoutTests/platform/gtk/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt (216237 => 216238)

--- trunk/LayoutTests/platform/gtk/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt	2017-05-05 08:53:23 UTC (rev 216237)
+++ trunk/LayoutTests/platform/gtk/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt	2017-05-05 11:56:22 UTC (rev 216238)
@@ -4,16 +4,16 @@
 
 
 Scrolled to 0, 0
-JSON.stringify(layoutViewport) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
-JSON.stringify(visualViewport) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
+JSON.stringify(layoutViewport) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
+JSON.stringify(visualViewport) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
 
 Scrolled to 475, 525
-JSON.stringify(layoutViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
-JSON.stringify(visualViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
+JSON.stringify(layoutViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
+JSON.stringify(visualViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
 
 Scrolled to 1223, 1710
-JSON.stringify(layoutViewport) is {"top":1710,"right":2008,"bottom":2295,"left":1223,"width":785,"height":585}
-JSON.stringify(visualViewport) is {"top":1710,"right":2008,"bottom":2295,"left":1223,"width":785,"height":585}
+JSON.stringify(layoutViewport) is {"x":1223,"y":1710,"width":785,"height":585,"top":1710,"right":2008,"bottom":2295,"left":1223}
+JSON.stringify(visualViewport) is 

[webkit-changes] [216237] trunk/Tools

[carlosgc]

Title: [216237] trunk/Tools








Revision 216237
Author carlo...@webkit.org
Date 2017-05-05 01:53:23 -0700 (Fri, 05 May 2017)


Log Message
Unreviewed. Fix wrong assert after r215176.

Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
could also be RGB24 when created from a web view snapshot.

* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::computeMD5HashStringForCairoSurface):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp




Diff

Modified: trunk/Tools/ChangeLog (216236 => 216237)

--- trunk/Tools/ChangeLog	2017-05-05 08:37:17 UTC (rev 216236)
+++ trunk/Tools/ChangeLog	2017-05-05 08:53:23 UTC (rev 216237)
@@ -1,3 +1,13 @@
+2017-05-05  Carlos Garcia Campos  
+
+Unreviewed. Fix wrong assert after r215176.
+
+Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
+could also be RGB24 when created from a web view snapshot.
+
+* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
+(WTR::computeMD5HashStringForCairoSurface):
+
 2017-05-04  Brian Burg  
 
 lldb_webkit.py should provide a type summary for WebCore::URL


Modified: trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp (216236 => 216237)

--- trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp	2017-05-05 08:37:17 UTC (rev 216236)
+++ trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp	2017-05-05 08:53:23 UTC (rev 216237)
@@ -41,9 +41,9 @@
 
 namespace WTR {
 
-void computeMD5HashStringForCairoSurface(cairo_surface_t* surface, char hashString[33])
+static void computeMD5HashStringForCairoSurface(cairo_surface_t* surface, char hashString[33])
 {
-ASSERT(cairo_image_surface_get_format(surface) == CAIRO_FORMAT_ARGB32); // ImageDiff assumes 32 bit RGBA, we must as well.
+ASSERT(cairo_image_surface_get_format(surface) == CAIRO_FORMAT_ARGB32 || cairo_image_surface_get_format(surface) == CAIRO_FORMAT_RGB24);
 
 size_t pixelsHigh = cairo_image_surface_get_height(surface);
 size_t pixelsWide = cairo_image_surface_get_width(surface);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216235] trunk/Tools

[bburg]

Title: [216235] trunk/Tools








Revision 216235
Author bb...@apple.com
Date 2017-05-04 23:37:48 -0700 (Thu, 04 May 2017)


Log Message
lldb_webkit.py should provide a type summary for WebCore::URL
https://bugs.webkit.org/show_bug.cgi?id=171670

Reviewed by Jer Noble.

Just print out the underlying string using the WTFString provider.

* lldb/lldb_webkit.py:
(__lldb_init_module):
(WebCoreURL_SummaryProvider):
(WebCoreURLProvider):
(WebCoreURLProvider.__init__):
(WebCoreURLProvider.to_string):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/lldb/lldb_webkit.py




Diff

Modified: trunk/Tools/ChangeLog (216234 => 216235)

--- trunk/Tools/ChangeLog	2017-05-05 05:37:54 UTC (rev 216234)
+++ trunk/Tools/ChangeLog	2017-05-05 06:37:48 UTC (rev 216235)
@@ -1,3 +1,19 @@
+2017-05-04  Brian Burg  
+
+lldb_webkit.py should provide a type summary for WebCore::URL
+https://bugs.webkit.org/show_bug.cgi?id=171670
+
+Reviewed by Jer Noble.
+
+Just print out the underlying string using the WTFString provider.
+
+* lldb/lldb_webkit.py:
+(__lldb_init_module):
+(WebCoreURL_SummaryProvider):
+(WebCoreURLProvider):
+(WebCoreURLProvider.__init__):
+(WebCoreURLProvider.to_string):
+
 2017-05-04  Commit Queue  
 
 Unreviewed, rolling out r216206.


Modified: trunk/Tools/lldb/lldb_webkit.py (216234 => 216235)

--- trunk/Tools/lldb/lldb_webkit.py	2017-05-05 05:37:54 UTC (rev 216234)
+++ trunk/Tools/lldb/lldb_webkit.py	2017-05-05 06:37:48 UTC (rev 216235)
@@ -1,4 +1,4 @@
-# Copyright (C) 2012 Apple. All rights reserved.
+# Copyright (C) 2012-2017 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -46,6 +46,7 @@
 debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutUnit_SummaryProvider WebCore::LayoutUnit')
 debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutSize_SummaryProvider WebCore::LayoutSize')
 debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutPoint_SummaryProvider WebCore::LayoutPoint')
+debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreURL_SummaryProvider WebCore::URL')
 
 def WTFString_SummaryProvider(valobj, dict):
 provider = WTFStringProvider(valobj, dict)
@@ -88,6 +89,11 @@
 return "{ %d/%d, %f }" % (provider.timeValue(), provider.timeScale(), float(provider.timeValue()) / provider.timeScale())
 
 
+def WebCoreURL_SummaryProvider(valobj, dict):
+provider = WebCoreURLProvider(valobj, dict)
+return "{ %s }" % provider.to_string()
+
+
 def WebCoreLayoutUnit_SummaryProvider(valobj, dict):
 provider = WebCoreLayoutUnitProvider(valobj, dict)
 return "{ %s }" % provider.to_string()
@@ -155,7 +161,6 @@
 # FIXME: Provide support for the following types:
 # def WTFVector_SummaryProvider(valobj, dict):
 # def WTFCString_SummaryProvider(valobj, dict):
-# def WebCoreKURLGooglePrivate_SummaryProvider(valobj, dict):
 # def WebCoreQualifiedName_SummaryProvider(valobj, dict):
 # def JSCIdentifier_SummaryProvider(valobj, dict):
 # def JSCJSString_SummaryProvider(valobj, dict):
@@ -304,6 +309,14 @@
 return WebCoreLayoutUnitProvider(self.valobj.GetChildMemberWithName('m_y'), dict).to_string()
 
 
+class WebCoreURLProvider:
+"Print a WebCore::URL"
+def __init__(self, valobj, dict):
+self.valobj = valobj
+
+def to_string(self):
+return WTFStringProvider(self.valobj.GetChildMemberWithName('m_string'), dict).to_string()
+
 class WTFVectorProvider:
 def __init__(self, valobj, internal_dict):
 self.valobj = valobj






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes