[webkit-changes] [231789] trunk
Title: [231789] trunk Revision 231789 Author you...@apple.com Date 2018-05-14 22:35:25 -0700 (Mon, 14 May 2018) Log Message readableStreamDefaultControllerError should return early if stream is not readable https://bugs.webkit.org/show_bug.cgi?id=185602 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/streams/readable-streams/bad-underlying-sources-expected.txt: * web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker-expected.txt: * web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt: * web-platform-tests/streams/readable-streams/garbage-collection-expected.txt: * web-platform-tests/streams/readable-streams/garbage-collection.dedicatedworker-expected.txt: * web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt: * web-platform-tests/streams/readable-streams/tee-expected.txt: Source/WebCore: Return early if stream is not readable in @readableStreamDefaultControllerError. Update call sites to no longer check for ReadableStream state. Covered by unflaked and rebased tests. * Modules/streams/ReadableStreamDefaultController.js: (error): * Modules/streams/ReadableStreamInternals.js: (readableStreamDefaultControllerError): (readableStreamDefaultControllerCallPullIfNeeded): LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.dedicatedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultController.js trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js Diff Modified: trunk/LayoutTests/ChangeLog (231788 => 231789) --- trunk/LayoutTests/ChangeLog 2018-05-15 05:31:49 UTC (rev 231788) +++ trunk/LayoutTests/ChangeLog 2018-05-15 05:35:25 UTC (rev 231789) @@ -1,5 +1,14 @@ 2018-05-14 Youenn Fablet +readableStreamDefaultControllerError should return early if stream is not readable +https://bugs.webkit.org/show_bug.cgi?id=185602 + +Reviewed by Chris Dumez. + +* TestExpectations: + +2018-05-14 Youenn Fablet + imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html is flaky https://bugs.webkit.org/show_bug.cgi?id=185549 Modified: trunk/LayoutTests/TestExpectations (231788 => 231789) --- trunk/LayoutTests/TestExpectations 2018-05-15 05:31:49 UTC (rev 231788) +++ trunk/LayoutTests/TestExpectations 2018-05-15 05:35:25 UTC (rev 231789) @@ -615,10 +615,8 @@ webkit.org/b/171094 streams/brand-checks.html [ Pass Failure ] webkit.org/b/171094 streams/reference-implementation/abstract-ops.html [ Pass Failure ] -# tee.html is flaky with release and crashes with debug builds -webkit.org/b/171094 imported/w3c/web-platform-tests/streams/readable-streams/tee.html [ Pass Failure Crash ] -[ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/tee.serviceworker.https.html [ Failure ] -[ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/tee.dedicatedworker.html [ Crash ] +# tee.html is flaky with unhandled promise rejections +imported/w3c/web-platform-tests/streams/readable-streams/tee.html [ DumpJSConsoleLogInStdErr ] # WPT tests that fail after doing full test repository reimport and need further investigation imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace.html [ Pass Failure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (231788 => 231789) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-05-15 05:31:49 UTC (rev 231788) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-05-15 05:35:25 UTC (rev 231789) @@ -1,5 +1,20 @@ 2018-05-14 Youenn Fablet +readableStreamDefaultControllerError should return early if stream is not readable +https://bugs.webkit.org/show_bug.cgi?id=185602 + +Reviewed by Chris Dumez. + +* web-platform-tests/streams/readable-streams/bad-underlying-sources-expected.txt: +* web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker-expected.txt: +* web-platform-tests/streams/readable-streams/
[webkit-changes] [231788] trunk/LayoutTests
Title: [231788] trunk/LayoutTests
Revision 231788
Author you...@apple.com
Date 2018-05-14 22:31:49 -0700 (Mon, 14 May 2018)
Log Message
imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=185549
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Catch any potential rejected promise.
* web-platform-tests/fetch/api/response/response-stream-disturbed-6.html:
LayoutTests:
* TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html
Diff
Modified: trunk/LayoutTests/ChangeLog (231787 => 231788)
--- trunk/LayoutTests/ChangeLog 2018-05-15 05:27:29 UTC (rev 231787)
+++ trunk/LayoutTests/ChangeLog 2018-05-15 05:31:49 UTC (rev 231788)
@@ -1,3 +1,12 @@
+2018-05-14 Youenn Fablet
+
+imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=185549
+
+Reviewed by Chris Dumez.
+
+* TestExpectations:
+
2018-05-14 Wenson Hsieh
[Extra zoom mode] Google search results are excessively zoomed in
Modified: trunk/LayoutTests/TestExpectations (231787 => 231788)
--- trunk/LayoutTests/TestExpectations 2018-05-15 05:27:29 UTC (rev 231787)
+++ trunk/LayoutTests/TestExpectations 2018-05-15 05:31:49 UTC (rev 231788)
@@ -656,7 +656,6 @@
webkit.org/b/178241 imported/w3c/web-platform-tests/fetch/api/basic/integrity.html [ Pass Failure ]
webkit.org/b/178241 imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker.html [ Pass Failure ]
-imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html [ Pass Failure ]
imported/w3c/web-platform-tests/fetch/http-cache/partial.html [ Failure ]
webkit.org/b/159724 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Failure Pass ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (231787 => 231788)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-05-15 05:27:29 UTC (rev 231787)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-05-15 05:31:49 UTC (rev 231788)
@@ -1,5 +1,16 @@
2018-05-14 Youenn Fablet
+imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=185549
+
+Reviewed by Chris Dumez.
+
+Catch any potential rejected promise.
+
+* web-platform-tests/fetch/api/response/response-stream-disturbed-6.html:
+
+2018-05-14 Youenn Fablet
+
Enable service-worker/navigation-redirect-body.https.html and service-worker/postmessage.https.html
https://bugs.webkit.org/show_bug.cgi?id=185605
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html (231787 => 231788)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html 2018-05-15 05:27:29 UTC (rev 231787)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html 2018-05-15 05:31:49 UTC (rev 231788)
@@ -65,7 +65,7 @@
const reader = stream.getReader();
assert_false(response.bodyUsed, "After getting a reader");
- reader.read();
+ reader.read().then(() => { }, () => { });
assert_true(response.bodyUsed, "After calling stream.read()");
}, "An errored stream on which read() has been called");
@@ -81,7 +81,7 @@
const reader = stream.getReader();
assert_false(response.bodyUsed, "After getting a reader");
- reader.cancel();
+ reader.cancel().then(() => { }, () => { });
assert_true(response.bodyUsed, "After calling stream.cancel()");
}, "An errored stream on which cancel() has been called");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231787] trunk/Source/JavaScriptCore
Title: [231787] trunk/Source/_javascript_Core
Revision 231787
Author keith_mil...@apple.com
Date 2018-05-14 22:27:29 -0700 (Mon, 14 May 2018)
Log Message
Remove butterflyMask from DFGAbstractHeap
https://bugs.webkit.org/show_bug.cgi?id=185640
Reviewed by Saam Barati.
We don't have a butterfly indexing mask anymore so we don't need
the abstract heap information for it anymore.
* dfg/DFGAbstractHeap.h:
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractHeap.h
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (231786 => 231787)
--- trunk/Source/_javascript_Core/ChangeLog 2018-05-15 05:23:28 UTC (rev 231786)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-05-15 05:27:29 UTC (rev 231787)
@@ -1,3 +1,17 @@
+2018-05-14 Keith Miller
+
+Remove butterflyMask from DFGAbstractHeap
+https://bugs.webkit.org/show_bug.cgi?id=185640
+
+Reviewed by Saam Barati.
+
+We don't have a butterfly indexing mask anymore so we don't need
+the abstract heap information for it anymore.
+
+* dfg/DFGAbstractHeap.h:
+* dfg/DFGClobberize.h:
+(JSC::DFG::clobberize):
+
2018-05-14 Andy VanWagoner
[INTL] Handle error in defineProperty for supported locales length
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractHeap.h (231786 => 231787)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractHeap.h 2018-05-15 05:23:28 UTC (rev 231786)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractHeap.h 2018-05-15 05:27:29 UTC (rev 231787)
@@ -58,7 +58,6 @@
macro(JSCell_typeInfoFlags) \
macro(JSCell_typeInfoType) \
macro(JSObject_butterfly) \
-macro(JSObject_butterflyMask) \
macro(JSPropertyNameEnumerator_cachedPropertyNames) \
macro(RegExpObject_lastIndex) \
macro(NamedProperties) \
Modified: trunk/Source/_javascript_Core/dfg/DFGClobberize.h (231786 => 231787)
--- trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2018-05-15 05:23:28 UTC (rev 231786)
+++ trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2018-05-15 05:27:29 UTC (rev 231787)
@@ -551,7 +551,6 @@
read(JSCell_indexingType);
read(JSCell_structureID);
read(JSObject_butterfly);
-read(JSObject_butterflyMask);
read(Butterfly_publicLength);
read(IndexedDoubleProperties);
read(IndexedInt32Properties);
@@ -567,7 +566,6 @@
read(JSCell_indexingType);
read(JSCell_structureID);
read(JSObject_butterfly);
-read(JSObject_butterflyMask);
read(Butterfly_publicLength);
switch (node->arrayMode().type()) {
case Array::Double:
@@ -1138,7 +1136,6 @@
write(JSCell_structureID);
write(JSCell_indexingType);
write(JSObject_butterfly);
-write(JSObject_butterflyMask);
write(Watchpoint_fire);
return;
@@ -1190,7 +1187,6 @@
case MultiGetByOffset: {
read(JSCell_structureID);
read(JSObject_butterfly);
-read(JSObject_butterflyMask);
AbstractHeap heap(NamedProperties, node->multiGetByOffsetData().identifierNumber);
read(heap);
def(HeapLocation(NamedPropertyLoc, heap, node->child1()), LazyNode(node));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231786] trunk/Source/WebCore
Title: [231786] trunk/Source/WebCore
Revision 231786
Author za...@apple.com
Date 2018-05-14 22:23:28 -0700 (Mon, 14 May 2018)
Log Message
[LFC] Implement width computation for non-replaced block level inflow elements.
https://bugs.webkit.org/show_bug.cgi?id=185641
Reviewed by Sam Weinig.
Block level inflow elements participate in block formatting context.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeWidth const):
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeInFlowWidth const):
* layout/blockformatting/BlockFormattingContext.h:
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeInFlowWidth const):
* layout/inlineformatting/InlineFormattingContext.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (231785 => 231786)
--- trunk/Source/WebCore/ChangeLog 2018-05-15 03:09:19 UTC (rev 231785)
+++ trunk/Source/WebCore/ChangeLog 2018-05-15 05:23:28 UTC (rev 231786)
@@ -1,3 +1,22 @@
+2018-05-14 Zalan Bujtas
+
+[LFC] Implement width computation for non-replaced block level inflow elements.
+https://bugs.webkit.org/show_bug.cgi?id=185641
+
+Reviewed by Sam Weinig.
+
+Block level inflow elements participate in block formatting context.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeWidth const):
+* layout/FormattingContext.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::computeInFlowWidth const):
+* layout/blockformatting/BlockFormattingContext.h:
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::computeInFlowWidth const):
+* layout/inlineformatting/InlineFormattingContext.h:
+
2018-05-14 Wenson Hsieh
Unreviewed, fix the iOS build after r231779
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (231785 => 231786)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-15 03:09:19 UTC (rev 231785)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-15 05:23:28 UTC (rev 231786)
@@ -66,7 +66,7 @@
return computeOutOfFlowWidth(layoutContext, layoutBox, displayBox);
if (layoutBox.isFloatingPositioned())
return computeFloatingWidth(layoutBox, displayBox);
-return computeInFlowWidth(layoutBox, displayBox);
+return computeInFlowWidth(layoutContext, layoutBox, displayBox);
}
void FormattingContext::computeHeight(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
Modified: trunk/Source/WebCore/layout/FormattingContext.h (231785 => 231786)
--- trunk/Source/WebCore/layout/FormattingContext.h 2018-05-15 03:09:19 UTC (rev 231785)
+++ trunk/Source/WebCore/layout/FormattingContext.h 2018-05-15 05:23:28 UTC (rev 231786)
@@ -73,7 +73,7 @@
virtual void computeOutOfFlowWidth(LayoutContext&, const Box&, Display::Box&) const;
virtual void computeFloatingWidth(const Box&, Display::Box&) const;
-virtual void computeInFlowWidth(const Box&, Display::Box&) const = 0;
+virtual void computeInFlowWidth(LayoutContext&, const Box&, Display::Box&) const = 0;
virtual void computeOutOfFlowHeight(LayoutContext&, const Box&, Display::Box&) const;
virtual void computeFloatingHeight(const Box&, Display::Box&) const;
Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp (231785 => 231786)
--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp 2018-05-15 03:09:19 UTC (rev 231785)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp 2018-05-15 05:23:28 UTC (rev 231786)
@@ -143,10 +143,44 @@
displayBox.setTopLeft(topLeft);
}
-void BlockFormattingContext::computeInFlowWidth(const Box&, Display::Box&) const
+void BlockFormattingContext::computeInFlowWidth(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
{
+if (!layoutBox.isReplaced()) {
+computeInFlowNonReplacedWidth(layoutContext, layoutBox, displayBox);
+return;
+}
+ASSERT_NOT_REACHED();
}
+void BlockFormattingContext::computeInFlowNonReplacedWidth(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
+{
+// 10.3.3 Block-level, non-replaced elements in normal flow
+// The following constraints must hold among the used values of the other proper
[webkit-changes] [231785] trunk
Title: [231785] trunk
Revision 231785
Author beid...@apple.com
Date 2018-05-14 20:09:19 -0700 (Mon, 14 May 2018)
Log Message
Add an API test to guard against regressions while re-entering setDefersLoading:.
and https://bugs.webkit.org/show_bug.cgi?id=185630
Reviewed by Chris Dumez.
Source/WebKit:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setDefersLoadingForTesting:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setDefersLoadingForTesting):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.messages.in:
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
(-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
(-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
(-[DefersScheme initWithBytes:]):
(-[DefersScheme webView:startURLSchemeTask:]):
(-[DefersScheme webView:stopURLSchemeTask:]):
* TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
(-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
(-[DoubleDefersLoadingPlugIn dealloc]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (231784 => 231785)
--- trunk/Source/WebKit/ChangeLog 2018-05-15 03:00:27 UTC (rev 231784)
+++ trunk/Source/WebKit/ChangeLog 2018-05-15 03:09:19 UTC (rev 231785)
@@ -1,3 +1,19 @@
+2018-05-14 Brady Eidson
+
+Add an API test to guard against regressions while re-entering setDefersLoading:.
+ and https://bugs.webkit.org/show_bug.cgi?id=185630
+
+Reviewed by Chris Dumez.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _setDefersLoadingForTesting:]):
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::setDefersLoadingForTesting):
+* UIProcess/WebPageProxy.h:
+* WebProcess/WebPage/WebPage.messages.in:
+
2018-05-14 Tim Horton
Use the system font by default in extra zoom mode
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (231784 => 231785)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-05-15 03:00:27 UTC (rev 231784)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-05-15 03:09:19 UTC (rev 231785)
@@ -6380,6 +6380,11 @@
#endif
}
+- (void)_setDefersLoadingForTesting:(BOOL)defersLoading
+{
+_page->setDefersLoadingForTesting(defersLoading);
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h (231784 => 231785)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h 2018-05-15 03:00:27 UTC (rev 231784)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h 2018-05-15 03:09:19 UTC (rev 231785)
@@ -461,6 +461,7 @@
- (BOOL)_beginBackSwipeForTesting;
- (BOOL)_completeBackSwipeForTesting;
+- (void)_setDefersLoadingForTesting:(BOOL)defersLoading;
@end
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (231784 => 231785)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-05-15 03:00:27 UTC (rev 231784)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-05-15 03:09:19 UTC (rev 231785)
@@ -7691,4 +7691,9 @@
}
}
+void WebPageProxy::setDefersLoadingForTesting(bool defersLoading)
+{
+m_process->send(Messages::WebPage::SetDefersLoading(defersLoading), m_pageID);
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (231784 => 231785)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2018-05-15 03:00:27 UTC (rev 231784)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2018-05-15 03:09:19 UTC (rev 231785)
@@ -1307,6 +1307,8 @@
SuspendedPageProxy* suspendedPage() const { return m_suspendedPage.get(); }
void suspendedPageClosed(SuspendedPageProxy&);
+void setDefersLoadingForTesting(bool);
+
private:
WebPageProxy(PageClient&, WebProcessProxy&, uint64_t pageID, Ref&&);
void platformInitialize();
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in (231784 => 231785)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2018-05-15 03:00:27 UTC (rev 231784)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2018-05-15 03:09:19 UTC (rev 231785)
@@ -520,4 +520,6 @@
#if PLATFORM(MAC) && E
[webkit-changes] [231784] trunk/Source/WebCore
Title: [231784] trunk/Source/WebCore
Revision 231784
Author wenson_hs...@apple.com
Date 2018-05-14 20:00:27 -0700 (Mon, 14 May 2018)
Log Message
Unreviewed, fix the iOS build after r231779
Also address a minor in-person review comment by returning "extrazoom" instead of the empty string.
* page/DisabledAdaptations.cpp:
(WebCore::extraZoomModeAdaptationName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DisabledAdaptations.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (231783 => 231784)
--- trunk/Source/WebCore/ChangeLog 2018-05-15 02:24:59 UTC (rev 231783)
+++ trunk/Source/WebCore/ChangeLog 2018-05-15 03:00:27 UTC (rev 231784)
@@ -1,3 +1,12 @@
+2018-05-14 Wenson Hsieh
+
+Unreviewed, fix the iOS build after r231779
+
+Also address a minor in-person review comment by returning "extrazoom" instead of the empty string.
+
+* page/DisabledAdaptations.cpp:
+(WebCore::extraZoomModeAdaptationName):
+
2018-05-14 Zalan Bujtas
[LFC] FormattingContext:computeOutOfFlowNonReplacedHeight/Width should use the computed margins/paddings/borders
Modified: trunk/Source/WebCore/page/DisabledAdaptations.cpp (231783 => 231784)
--- trunk/Source/WebCore/page/DisabledAdaptations.cpp 2018-05-15 02:24:59 UTC (rev 231783)
+++ trunk/Source/WebCore/page/DisabledAdaptations.cpp 2018-05-15 03:00:27 UTC (rev 231784)
@@ -30,7 +30,7 @@
namespace WebCore {
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
#import
@@ -38,7 +38,7 @@
String extraZoomModeAdaptationName()
{
-return emptyString();
+return ASCIILiteral("extrazoom");
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231783] trunk/Source/WebKit
Title: [231783] trunk/Source/WebKit Revision 231783 Author timothy_hor...@apple.com Date 2018-05-14 19:24:59 -0700 (Mon, 14 May 2018) Log Message Use the system font by default in extra zoom mode https://bugs.webkit.org/show_bug.cgi?id=185638 Reviewed by Wenson Hsieh. * Shared/WebPreferencesDefaultValues.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h Diff Modified: trunk/Source/WebKit/ChangeLog (231782 => 231783) --- trunk/Source/WebKit/ChangeLog 2018-05-15 01:52:26 UTC (rev 231782) +++ trunk/Source/WebKit/ChangeLog 2018-05-15 02:24:59 UTC (rev 231783) @@ -1,3 +1,13 @@ +2018-05-14 Tim Horton + +Use the system font by default in extra zoom mode +https://bugs.webkit.org/show_bug.cgi?id=185638 + + +Reviewed by Wenson Hsieh. + +* Shared/WebPreferencesDefaultValues.h: + 2018-05-14 Michael Catanzaro Unreviewed, rolling out r231755. Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (231782 => 231783) --- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2018-05-15 01:52:26 UTC (rev 231782) +++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2018-05-15 02:24:59 UTC (rev 231783) @@ -139,7 +139,12 @@ #if PLATFORM(COCOA) +#if ENABLE(EXTRA_ZOOM_MODE) +#define DEFAULT_STANDARD_FONT_FAMILY "system-ui" +#else #define DEFAULT_STANDARD_FONT_FAMILY "Times" +#endif + #define DEFAULT_FANTASY_FONT_FAMILY "Papyrus" #define DEFAULT_FIXED_FONT_FAMILY "Courier" #define DEFAULT_SANS_SERIF_FONT_FAMILY "Helvetica" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231782] trunk/Source/WebInspectorUI
Title: [231782] trunk/Source/WebInspectorUI Revision 231782 Author nvasil...@apple.com Date 2018-05-14 18:52:26 -0700 (Mon, 14 May 2018) Log Message Web Inspector: Canvas: Remove unused --value-visual-highlight CSS variable https://bugs.webkit.org/show_bug.cgi?id=185636 Reviewed by Matt Baker. * UserInterface/Views/Variables.css: (:root): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (231781 => 231782) --- trunk/Source/WebInspectorUI/ChangeLog 2018-05-15 01:44:26 UTC (rev 231781) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-05-15 01:52:26 UTC (rev 231782) @@ -1,3 +1,13 @@ +2018-05-14 Nikita Vasilyev + +Web Inspector: Canvas: Remove unused --value-visual-highlight CSS variable +https://bugs.webkit.org/show_bug.cgi?id=185636 + +Reviewed by Matt Baker. + +* UserInterface/Views/Variables.css: +(:root): + 2018-05-14 Devin Rousso Web Inspector: Canvas tab: don't automatically select a recording when viewing a canvas Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (231781 => 231782) --- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2018-05-15 01:44:26 UTC (rev 231781) +++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2018-05-15 01:52:26 UTC (rev 231782) @@ -67,7 +67,6 @@ --error-text-color: hsl(0, 86%, 47%); --value-changed-highlight: hsla(83, 100%, 48%, 0.4); ---value-visual-highlight: hsla(60, 100%, 50%, 0.4); --breakpoint-fill-color: hsl(212, 45%, 54%); --breakpoint-stroke-color: hsl(212, 45%, 48%); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231781] trunk/Source/WebKit
Title: [231781] trunk/Source/WebKit
Revision 231781
Author mcatanz...@igalia.com
Date 2018-05-14 18:44:26 -0700 (Mon, 14 May 2018)
Log Message
Unreviewed, rolling out r231755.
Change is not correct
Reverted changeset:
"-Wmemset-elt-size warning in LibWebRTCSocket constructor"
https://bugs.webkit.org/show_bug.cgi?id=18
https://trac.webkit.org/changeset/231755
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (231780 => 231781)
--- trunk/Source/WebKit/ChangeLog 2018-05-15 01:31:21 UTC (rev 231780)
+++ trunk/Source/WebKit/ChangeLog 2018-05-15 01:44:26 UTC (rev 231781)
@@ -1,3 +1,15 @@
+2018-05-14 Michael Catanzaro
+
+Unreviewed, rolling out r231755.
+
+Change is not correct
+
+Reverted changeset:
+
+"-Wmemset-elt-size warning in LibWebRTCSocket constructor"
+https://bugs.webkit.org/show_bug.cgi?id=18
+https://trac.webkit.org/changeset/231755
+
2018-05-14 Wenson Hsieh
[Extra zoom mode] Google search results are excessively zoomed in
Modified: trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp (231780 => 231781)
--- trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp 2018-05-15 01:31:21 UTC (rev 231780)
+++ trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp 2018-05-15 01:44:26 UTC (rev 231781)
@@ -54,7 +54,7 @@
, m_localAddress(localAddress)
, m_remoteAddress(remoteAddress)
{
-memset(&m_options, 1, MAX_SOCKET_OPTION * sizeof(m_options[0]));
+memset(&m_options, 1, MAX_SOCKET_OPTION);
}
LibWebRTCSocket::~LibWebRTCSocket()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231780] trunk/Source/WebCore
Title: [231780] trunk/Source/WebCore
Revision 231780
Author za...@apple.com
Date 2018-05-14 18:31:21 -0700 (Mon, 14 May 2018)
Log Message
[LFC] FormattingContext:computeOutOfFlowNonReplacedHeight/Width should use the computed margins/paddings/borders
https://bugs.webkit.org/show_bug.cgi?id=185633
Reviewed by Sam Weinig.
By the time we start computing height and width, DisplayBox should already have the computed values for margin/padding/border.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedHeight const):
(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedWidth const):
* layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::paddingTop const):
(WebCore::Display::Box::paddingLeft const):
(WebCore::Display::Box::paddingBottom const):
(WebCore::Display::Box::paddingRight const):
(WebCore::Display::Box::borderTop const):
(WebCore::Display::Box::borderLeft const):
(WebCore::Display::Box::borderBottom const):
(WebCore::Display::Box::borderRight const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/displaytree/DisplayBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (231779 => 231780)
--- trunk/Source/WebCore/ChangeLog 2018-05-15 01:07:36 UTC (rev 231779)
+++ trunk/Source/WebCore/ChangeLog 2018-05-15 01:31:21 UTC (rev 231780)
@@ -1,3 +1,25 @@
+2018-05-14 Zalan Bujtas
+
+[LFC] FormattingContext:computeOutOfFlowNonReplacedHeight/Width should use the computed margins/paddings/borders
+https://bugs.webkit.org/show_bug.cgi?id=185633
+
+Reviewed by Sam Weinig.
+
+By the time we start computing height and width, DisplayBox should already have the computed values for margin/padding/border.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedHeight const):
+(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedWidth const):
+* layout/displaytree/DisplayBox.h:
+(WebCore::Display::Box::paddingTop const):
+(WebCore::Display::Box::paddingLeft const):
+(WebCore::Display::Box::paddingBottom const):
+(WebCore::Display::Box::paddingRight const):
+(WebCore::Display::Box::borderTop const):
+(WebCore::Display::Box::borderLeft const):
+(WebCore::Display::Box::borderBottom const):
+(WebCore::Display::Box::borderRight const):
+
2018-05-14 Wenson Hsieh
[Extra zoom mode] Google search results are excessively zoomed in
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (231779 => 231780)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-15 01:07:36 UTC (rev 231779)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-15 01:31:21 UTC (rev 231780)
@@ -185,17 +185,16 @@
computedHeightValue = contentHeightForFormattingContextRoot(layoutContext, layoutBox);
} else if (!top.isAuto() && height.isAuto() && !bottom.isAuto()) {
// #5
-auto marginTop = style.marginTop().isAuto() ? LayoutUnit() : valueForLength(style.marginTop(), containingBlockHeight);
-auto marginBottom = style.marginBottom().isAuto() ? LayoutUnit() : valueForLength(style.marginBottom(), containingBlockHeight);
+auto marginTop = displayBox.marginTop();
+auto marginBottom = displayBox.marginBottom();
-auto containingBlockWidth = layoutContext.displayBoxForLayoutBox(*layoutBox.containingBlock())->width();
-auto paddingTop = valueForLength(style.paddingTop(), containingBlockWidth);
-auto paddingBottom = valueForLength(style.paddingBottom(), containingBlockWidth);
+auto paddingTop = displayBox.paddingTop();
+auto paddingBottom = displayBox.paddingBottom();
-auto borderTopWidth = style.borderBeforeWidth();
-auto borderBottomWidth = style.borderAfterWidth();
+auto borderTop = displayBox.borderTop();
+auto borderBottom = displayBox.borderBottom();
-computedHeightValue = containingBlockHeight - (top.value() + marginTop + borderTopWidth + paddingTop + paddingBottom + borderBottomWidth + marginBottom + bottom.value());
+computedHeightValue = containingBlockHeight - (top.value() + marginTop + borderTop + paddingTop + paddingBottom + borderBottom + marginBottom + bottom.value());
} else if (!height.isAuto())
computedHeightValue = valueForLength(height, containingBlockHeight);
else
@@ -264,16 +263,16 @@
computedWidthValue = shrinkToFitWidth(layoutContext, layoutBox);
} else if (!left.isAuto() && width.isAuto() && !right.isAuto()) {
// #5
-auto marginLeft = style.marginLeft().isAuto() ? LayoutUnit() : valueForLength(style.marginLeft(), containingBlockWidth);
-auto marginRight = style.marginRight().isAuto() ? LayoutUnit() : valueForLength(style.marginRight(), containingBlockWidth);
+auto
[webkit-changes] [231779] trunk
Title: [231779] trunk Revision 231779 Author wenson_hs...@apple.com Date 2018-05-14 18:07:36 -0700 (Mon, 14 May 2018) Log Message [Extra zoom mode] Google search results are excessively zoomed in https://bugs.webkit.org/show_bug.cgi?id=185347 Reviewed by Tim Horton. Source/WebCore: It turns out that basing minimum layout size and shrink-to-fit behaviors off of the `shrink-to-fit` viewport argument poses compatibility risks with web pages that already specify `shrink-to-fit` to opt out of default viewport shrinking behaviors in 1/3 multitasking mode on iPad. One way to resolve this is to introduce a new viewport meta content attribute to disable viewport heuristics in extra zoom mode. However, combined shrink-to-fit and minimum device width behaviors are difficult to describe using a single backwards-compatible viewport meta content attribute, and the need to suppress the default behavior of `shrink-to-fit=no` if such an attribute is not disabled further muddles our viewport story. After some internal deliberation, we’ve decided to experiment with a new meta tag named "disabled-adaptations". The content of this meta tag is a comma-separated list of adaptation names; if an adaptation name matches a known adaptation type (for instance, extra zoom mode), we disable the class of behaviors used to adapt web content. The first and only known adaptation type is extra zoom mode, which affects `shrink-to-fit` and layout size adjustments. See per-method changes below for more details. Test: fast/viewport/extrazoom/viewport-disable-extra-zoom-adaptations.html * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * dom/Document.cpp: (WebCore::Document::processDisabledAdaptations): * dom/Document.h: (WebCore::Document::disabledAdaptations const): Add disabled adaptations to Document. Changes to disabled adaptations are not propagated if the parsed disabled adaptation types don't change; upon changing adaptation types, notify the client to adjust for the new disabled adaptations (currently, this only affects the viewport configuration). * dom/ViewportArguments.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner): (WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): * loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Restore the set of disabled adaptations when restoring a page from the cache. * page/Chrome.cpp: (WebCore::Chrome::dispatchDisabledAdaptationsDidChange const): * page/Chrome.h: * page/ChromeClient.h: Add plumbing for changes to the set of disabled adaptations. * page/DisabledAdaptations.cpp: Added. (WebCore::extraZoomModeAdaptationName): * page/DisabledAdaptations.h: Added. Introduce a header containing a new enum for the extra zoom mode adaptation, as well as a helper function to return the extra zoom mode adaptation name. * page/Page.cpp: (WebCore::Page::disabledAdaptations const): Returns the mainframe's set of adaptations to disable. * page/Page.h: * page/RemoteFrame.h: * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDisabledAdaptationsMetaTagEnabled): (WebCore::RuntimeEnabledFeatures::disabledAdaptationsMetaTagEnabled const): Add a new runtime feature to gate handling the "disabled-adaptations" meta tag. * page/ViewportConfiguration.cpp: (WebCore::shouldOverrideShrinkToFitArgument): (WebCore::needsUpdateAfterChangingDisabledAdaptations): (WebCore::ViewportConfiguration::setDisabledAdaptations): (WebCore::ViewportConfiguration::shouldOverrideDeviceWidthAndShrinkToFit const): Consult whether or not extra zoom mode adaptations are disabled, instead of the shrink-to-fit attribute value. (WebCore::ViewportConfiguration::updateConfiguration): * page/ViewportConfiguration.h: Add an OptionSet of disabled adaptation types to ViewportConfiguration. Updates to the adaptation type are propagated to the ViewportConfiguration from Document, through the ChromeClient and the client layer (refer to changes in WebKit). Once the OptionSet is changed, we recompute the viewport configuration only if needed by the platform. (WebCore::ViewportConfiguration::viewLayoutSize const): (WebCore::ViewportConfiguration::disabledAdaptations const): * page/WindowFeatures.cpp: (WebCore::parseDisabledAdaptations): * page/WindowFeatures.h: Add a new helper to parse the meta content of a "disabled-adaptations" tag as an OptionSet of disabled adaptation types. The string is parsed by first splitting on the comma character, and then iterating over lower case, whitespace-stripped tokens to look for known adaptation names. So far, only extra zoom mode is supported. * testing/Internals.cpp: (WebCore::Internals::extraZoomModeAdaptationName const): * testing/Internals.h: * testing/Internals.idl: Expose the extra zoom mode adaptation name to the DOM, only when running layout
[webkit-changes] [231777] trunk/Source/WebKitLegacy/mac
Title: [231777] trunk/Source/WebKitLegacy/mac
Revision 231777
Author dba...@webkit.org
Date 2018-05-14 16:34:06 -0700 (Mon, 14 May 2018)
Log Message
Fix the Apple Internal build
See for more details.
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullScreen:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController exitFullScreen]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
Modified Paths
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (231776 => 231777)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-05-14 23:19:29 UTC (rev 231776)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-05-14 23:34:06 UTC (rev 231777)
@@ -1,3 +1,17 @@
+2018-05-14 Daniel Bates
+
+Fix the Apple Internal build
+
+See for more details.
+
+* WebView/WebFullScreenController.mm:
+(-[WebFullScreenController enterFullScreen:]):
+(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
+(-[WebFullScreenController exitFullScreen]):
+(-[WebFullScreenController finishedExitFullScreenAnimation:]):
+(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
+(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
+
2018-05-11 Timothy Hatcher
WebHTMLView is not setting aside subviews when drawing.
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm (231776 => 231777)
--- trunk/Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm 2018-05-14 23:19:29 UTC (rev 231776)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm 2018-05-14 23:34:06 UTC (rev 231777)
@@ -207,9 +207,9 @@
RetainPtr webViewContents = adoptCF(CGWindowListCreateImage(NSRectToCGRect(webViewFrame), kCGWindowListOptionIncludingWindow, windowID, kCGWindowImageShouldBeOpaque));
// Screen updates to be re-enabled in beganEnterFullScreenWithInitialFrame:finalFrame:
-NSDisableScreenUpdates();
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+NSDisableScreenUpdates();
[[self window] setAutodisplay:NO];
#pragma clang diagnostic pop
@@ -268,8 +268,11 @@
_isEnteringFullScreen = NO;
if (completed) {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// Screen updates to be re-enabled at the end of this block
NSDisableScreenUpdates();
+#pragma clang diagnostic pop
[self _document]->setAnimatingFullScreen(false);
[self _document]->webkitDidEnterFullScreenForElement(_element.get());
@@ -291,7 +294,10 @@
[_backgroundWindow.get() orderOut:self];
[_backgroundWindow.get() setFrame:NSZeroRect display:YES];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
NSEnableScreenUpdates();
+#pragma clang diagnostic pop
} else
[_scaleAnimation.get() stopAnimation];
}
@@ -308,11 +314,11 @@
if (!_isFullScreen)
return;
_isFullScreen = NO;
-
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// Screen updates to be re-enabled in beganExitFullScreenWithInitialFrame:finalFrame:
NSDisableScreenUpdates();
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
[[self window] setAutodisplay:NO];
#pragma clang diagnostic pop
@@ -353,9 +359,12 @@
_isExitingFullScreen = NO;
[self _updateMenuAndDockForFullScreen];
-
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// Screen updates to be re-enabled at the end of this function
NSDisableScreenUpdates();
+#pragma clang diagnostic pop
[self _document]->setAnimatingFullScreen(false);
[self _document]->webkitDidExitFullScreenForElement(_element.get());
@@ -382,7 +391,10 @@
[[_webView window] makeKeyAndOrderFront:self];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
NSEnableScreenUpdates();
+#pragma clang diagnostic pop
}
- (void)performClose:(id)sender
@@ -536,8 +548,11 @@
[[self window] setAutodisplay:YES];
#pragma clang diagnostic pop
[[self window] displayIfNeeded];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// Screen updates disabled in enterFullScreen:
NSEnableScreenUpdates();
+#pragma clang diagnostic pop
}
- (void)_startExitFullScreenAnimationWithDuration:(NSTimeInterval)duration
@@ -588,8 +603,11 @@
#pragma clang diagnostic pop
[webkit-changes] [231776] trunk/Tools
Title: [231776] trunk/Tools
Revision 231776
Author dba...@webkit.org
Date 2018-05-14 16:19:29 -0700 (Mon, 14 May 2018)
Log Message
[iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
https://bugs.webkit.org/show_bug.cgi?id=185599
Reviewed by Simon Fraser.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
(-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
(-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
(-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/ios/set-timeout-function.html: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm
trunk/Tools/TestWebKitAPI/ios/set-timeout-function.html
Diff
Modified: trunk/Tools/ChangeLog (231775 => 231776)
--- trunk/Tools/ChangeLog 2018-05-14 23:18:17 UTC (rev 231775)
+++ trunk/Tools/ChangeLog 2018-05-14 23:19:29 UTC (rev 231776)
@@ -1,3 +1,19 @@
+2018-05-14 Daniel Bates
+
+[iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
+https://bugs.webkit.org/show_bug.cgi?id=185599
+
+
+Reviewed by Simon Fraser.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
+(-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
+(-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
+(-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/ios/set-timeout-function.html: Added.
+
2018-05-14 Valerie R Young
test262/Runner.pm: small bugs in CLI and error codes
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (231775 => 231776)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-05-14 23:18:17 UTC (rev 231775)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-05-14 23:19:29 UTC (rev 231776)
@@ -726,6 +726,8 @@
CE3524F91B1441C40028A7C5 /* TextFieldDidBeginAndEndEditing.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CE3524F11B142B8D0028A7C5 /* TextFieldDidBeginAndEndEditing.cpp */; };
CE3524FA1B1443890028A7C5 /* input-focus-blur.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CE3524F51B142BBB0028A7C5 /* input-focus-blur.html */; };
CE4D5DE71F6743BA0072CFC6 /* StringWithDirection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CE4D5DE51F6743BA0072CFC6 /* StringWithDirection.cpp */; };
+ CE6E81A020A6935F00E2C80F /* SetTimeoutFunction.mm in Sources */ = {isa = PBXBuildFile; fileRef = CE6E819F20A6935F00E2C80F /* SetTimeoutFunction.mm */; };
+ CE6E81A420A933D500E2C80F /* set-timeout-function.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CE6E81A320A933B800E2C80F /* set-timeout-function.html */; };
CEA6CF2819CCF69D0064F5A7 /* open-and-close-window.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CEA6CF2719CCF69D0064F5A7 /* open-and-close-window.html */; };
CEA7F57D2089624B0078EF6E /* DidResignInputElementStrongPasswordAppearance.mm in Sources */ = {isa = PBXBuildFile; fileRef = CEA7F57B20895F5B0078EF6E /* DidResignInputElementStrongPasswordAppearance.mm */; };
CEBABD491B71687C0051210A /* should-open-external-schemes.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CEBABD481B71687C0051210A /* should-open-external-schemes.html */; };
@@ -1082,6 +1084,7 @@
0F5651F91FCE513500310FBC /* scroll-to-anchor.html in Copy Resources */,
F4D65DA81F5E4704009D8C27 /* selected-text-image-link-and-editable.html in Copy Resources */,
7A66BDB81EAF18D500CCC924 /* set-long-title.html in Copy Resources */,
+CE6E81A420A933D500E2C80F /* set-timeout-function.html in Copy Resources */,
52B8CF9815868D9100281053 /* SetDocumentURI.html in Copy Resources */,
CEBABD491B71687C0051210A /* should-open-external-schemes.html in Copy Resources */,
C9B4AD2A1ECA6EBE00F5FEA0 /* silence-long.m4a in Copy Resources */,
@@ -1877,6 +1880,8 @@
CE3524F51B142BBB0028A7C5 /* input-focus-blur.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "input-focus-blur.html"; sourceTree = ""; };
CE4D5DE51F6743BA0072CFC6 /* StringWithDirection.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = StringWithDirection.cpp; sourceTree = ""; };
CE50D8C81C8665CE0072EA5A /* OptionSet.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = OptionSet.cpp; sourceTree = ""; };
+ CE6E819F20A6935F00E2C80F /* SetTimeoutFunction.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp;
[webkit-changes] [231775] trunk/Tools
Title: [231775] trunk/Tools
Revision 231775
Author commit-qu...@webkit.org
Date 2018-05-14 16:18:17 -0700 (Mon, 14 May 2018)
Log Message
test262/Runner.pm: small bugs in CLI and error codes
https://bugs.webkit.org/show_bug.cgi?id=185629
Patch by Valerie R Young on 2018-05-14
Reviewed by Michael Saboff.
Fix two commandline args with use '-f', correct
error code of failures.
* Scripts/test262/Runner.pm:
(processCLI):
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/test262/Runner.pm
Diff
Modified: trunk/Tools/ChangeLog (231774 => 231775)
--- trunk/Tools/ChangeLog 2018-05-14 23:16:05 UTC (rev 231774)
+++ trunk/Tools/ChangeLog 2018-05-14 23:18:17 UTC (rev 231775)
@@ -1,3 +1,17 @@
+2018-05-14 Valerie R Young
+
+test262/Runner.pm: small bugs in CLI and error codes
+https://bugs.webkit.org/show_bug.cgi?id=185629
+
+Reviewed by Michael Saboff.
+
+Fix two commandline args with use '-f', correct
+error code of failures.
+
+* Scripts/test262/Runner.pm:
+(processCLI):
+(main):
+
2018-05-14 Ryan Haddad
Disable API tests that time out after pointer poisioning was disabled.
Modified: trunk/Tools/Scripts/test262/Runner.pm (231774 => 231775)
--- trunk/Tools/Scripts/test262/Runner.pm 2018-05-14 23:16:05 UTC (rev 231774)
+++ trunk/Tools/Scripts/test262/Runner.pm 2018-05-14 23:18:17 UTC (rev 231775)
@@ -130,7 +130,7 @@
's|save' => \$saveExpectations,
'e|expectations=s' => \$specifiedExpectationsFile,
'x|ignore-expectations' => \$ignoreExpectations,
-'f|failing-files' => \$failingOnly,
+'F|failing-files' => \$failingOnly,
'l|latest-import' => \$latestImport,
'stats' => \$stats,
'r|results=s' => \$specifiedResultsFile,
@@ -400,7 +400,8 @@
my $totalTime = $endTime - $startTime;
print "Done in $totalTime seconds!\n";
-exit $newfailcount ? 1 : 0;
+my $totalfailures = $expect ? $newfailcount : $failcount;
+exit ($totalfailures ? 1 : 0);
}
sub loadImportFile {
@@ -932,7 +933,7 @@
Ignores the test262-expectations.yaml file and outputs all failures, instead of only unexpected failures.
-=item B<--failing-files, -f>
+=item B<--failing-files, -F>
Runs all test files that failed in a given results file (specifc with --results). This option will run the rests in both strict and non-strict modes, even if the test only fails in one of the two modes.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231774] trunk/Tools
Title: [231774] trunk/Tools
Revision 231774
Author ryanhad...@apple.com
Date 2018-05-14 16:16:05 -0700 (Mon, 14 May 2018)
Log Message
Disable API tests that time out after pointer poisioning was disabled.
https://bugs.webkit.org/show_bug.cgi?id=185586
Unreviewed test gardening.
* TestWebKitAPI/Tests/WTF/Poisoned.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Poisoned.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp
Diff
Modified: trunk/Tools/ChangeLog (231773 => 231774)
--- trunk/Tools/ChangeLog 2018-05-14 23:01:25 UTC (rev 231773)
+++ trunk/Tools/ChangeLog 2018-05-14 23:16:05 UTC (rev 231774)
@@ -1,3 +1,19 @@
+2018-05-14 Ryan Haddad
+
+Disable API tests that time out after pointer poisioning was disabled.
+https://bugs.webkit.org/show_bug.cgi?id=185586
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WTF/Poisoned.cpp:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
+(TestWebKitAPI::TEST):
+
2018-05-14 Leo Balter
Test262-Runner: Fix RegExp for capturing tests metadata"
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Poisoned.cpp (231773 => 231774)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Poisoned.cpp 2018-05-14 23:01:25 UTC (rev 231773)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Poisoned.cpp 2018-05-14 23:16:05 UTC (rev 231774)
@@ -55,7 +55,7 @@
// For these tests, we need a base class and a derived class. For this purpose,
// we reuse the RefLogger and DerivedRefLogger classes.
-TEST(WTF_Poisoned, Basic)
+TEST(WTF_Poisoned, DISABLED_Basic)
{
initializeTestPoison();
DerivedRefLogger a("a");
@@ -368,7 +368,7 @@
}
}
-TEST(WTF_Poisoned, Assignment)
+TEST(WTF_Poisoned, DISABLED_Assignment)
{
initializeTestPoison();
DerivedRefLogger a("a");
@@ -499,7 +499,7 @@
}
}
-TEST(WTF_Poisoned, Swap)
+TEST(WTF_Poisoned, DISABLED_Swap)
{
initializeTestPoison();
RefLogger a("a");
@@ -583,7 +583,7 @@
return Poisoned(&logger);
}
-TEST(WTF_Poisoned, ReturnValue)
+TEST(WTF_Poisoned, DISABLED_ReturnValue)
{
initializeTestPoison();
DerivedRefLogger a("a");
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp (231773 => 231774)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp 2018-05-14 23:01:25 UTC (rev 231773)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp 2018-05-14 23:16:05 UTC (rev 231774)
@@ -74,7 +74,7 @@
} // anonymous namespace
-TEST(WTF_PoisonedUniquePtr, Basic)
+TEST(WTF_PoisonedUniquePtr, DISABLED_Basic)
{
initializePoisons();
@@ -317,7 +317,7 @@
}
}
-TEST(WTF_PoisonedUniquePtr, Assignment)
+TEST(WTF_PoisonedUniquePtr, DISABLED_Assignment)
{
initializePoisons();
@@ -490,7 +490,7 @@
}
}
-TEST(WTF_PoisonedUniquePtr, Swap)
+TEST(WTF_PoisonedUniquePtr, DISABLED_Swap)
{
initializePoisons();
@@ -564,7 +564,7 @@
return PoisonedUniquePtr(logger);
}
-TEST(WTF_PoisonedUniquePtr, ReturnValue)
+TEST(WTF_PoisonedUniquePtr, DISABLED_ReturnValue)
{
initializePoisons();
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp (231773 => 231774)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp 2018-05-14 23:01:25 UTC (rev 231773)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp 2018-05-14 23:16:05 UTC (rev 231774)
@@ -75,7 +75,7 @@
} // anonymous namespace
-TEST(WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays, Basic)
+TEST(WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays, DISABLED_Basic)
{
initializePoisons();
@@ -245,7 +245,7 @@
}
}
-TEST(WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays, Assignment)
+TEST(WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays, DISABLED_Assignment)
{
initializePoisons();
@@ -359,7 +359,7 @@
}
}
-TEST(WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays, Swap)
+TEST(WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays, DISABLED_Swap)
{
initializePoisons();
@@ -433,7 +433,7 @@
return PoisonedUniquePtr(array);
}
-TEST(WTF_PoisonedUniquePtrForNon
[webkit-changes] [231772] trunk/Source/JavaScriptCore
Title: [231772] trunk/Source/_javascript_Core Revision 231772 Author commit-qu...@webkit.org Date 2018-05-14 15:38:26 -0700 (Mon, 14 May 2018) Log Message [INTL] Handle error in defineProperty for supported locales length https://bugs.webkit.org/show_bug.cgi?id=185623 Patch by Andy VanWagoner on 2018-05-14 Reviewed by Saam Barati. Adds the missing RETURN_IF_EXCEPTION after defineOwnProperty for the length of the supported locales array. * runtime/IntlObject.cpp: (JSC::supportedLocales): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/IntlObject.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (231771 => 231772) --- trunk/Source/_javascript_Core/ChangeLog 2018-05-14 22:31:40 UTC (rev 231771) +++ trunk/Source/_javascript_Core/ChangeLog 2018-05-14 22:38:26 UTC (rev 231772) @@ -1,3 +1,16 @@ +2018-05-14 Andy VanWagoner + +[INTL] Handle error in defineProperty for supported locales length +https://bugs.webkit.org/show_bug.cgi?id=185623 + +Reviewed by Saam Barati. + +Adds the missing RETURN_IF_EXCEPTION after defineOwnProperty for the +length of the supported locales array. + +* runtime/IntlObject.cpp: +(JSC::supportedLocales): + 2018-05-14 Yusuke Suzuki [JSC] Tweak LiteralParser to improve lexing performance Modified: trunk/Source/_javascript_Core/runtime/IntlObject.cpp (231771 => 231772) --- trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2018-05-14 22:31:40 UTC (rev 231771) +++ trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2018-05-14 22:38:26 UTC (rev 231772) @@ -856,6 +856,7 @@ RETURN_IF_EXCEPTION(scope, JSValue()); } supportedLocales->defineOwnProperty(supportedLocales, &state, vm.propertyNames->length, desc, true); +RETURN_IF_EXCEPTION(scope, JSValue()); return supportedLocales; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231771] trunk/Source/WebKit
Title: [231771] trunk/Source/WebKit Revision 231771 Author cdu...@apple.com Date 2018-05-14 15:31:40 -0700 (Mon, 14 May 2018) Log Message Overly aggressive timer throttling in service workers https://bugs.webkit.org/show_bug.cgi?id=185575 Reviewed by Geoff Garen. After ~30 seconds, the system would put the service worker process in "App Nap", causing its timers to get aggressively throttled. This happens because the service worker processes are WebProcesses that have no visible WebPages. To address the issue, we now disable process suppression for all service worker processes. This causes those processes to construct a UserActivity which prevents App Nap. This patch also refactors the code a bit to avoid duplication. The ProcessSuppression suppression logic in now all on ChildProcessProxy / ChildProcess. * NetworkProcess/NetworkProcess.messages.in: * PluginProcess/PluginProcess.messages.in: * Shared/ChildProcess.messages.in: * UIProcess/ChildProcessProxy.cpp: (WebKit::ChildProcessProxy::setProcessSuppressionEnabled): * UIProcess/ChildProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/mac/NetworkProcessProxyMac.mm: Removed. * UIProcess/Plugins/PluginProcessProxy.h: * UIProcess/Plugins/mac/PluginProcessProxyMac.mm: * UIProcess/ServiceWorkerProcessProxy.cpp: (WebKit::ServiceWorkerProcessProxy::didFinishLaunching): * UIProcess/ServiceWorkerProcessProxy.h: * UIProcess/WebProcessProxy.h: * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebProcess.messages.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in trunk/Source/WebKit/PluginProcess/PluginProcess.messages.in trunk/Source/WebKit/Shared/ChildProcess.messages.in trunk/Source/WebKit/UIProcess/ChildProcessProxy.cpp trunk/Source/WebKit/UIProcess/ChildProcessProxy.h trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h trunk/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm trunk/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp trunk/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h trunk/Source/WebKit/UIProcess/WebProcessProxy.h trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/WebProcess.messages.in Removed Paths trunk/Source/WebKit/UIProcess/Network/mac/ Diff Modified: trunk/Source/WebKit/ChangeLog (231770 => 231771) --- trunk/Source/WebKit/ChangeLog 2018-05-14 22:14:40 UTC (rev 231770) +++ trunk/Source/WebKit/ChangeLog 2018-05-14 22:31:40 UTC (rev 231771) @@ -1,3 +1,39 @@ +2018-05-14 Chris Dumez + +Overly aggressive timer throttling in service workers +https://bugs.webkit.org/show_bug.cgi?id=185575 + + +Reviewed by Geoff Garen. + +After ~30 seconds, the system would put the service worker process in "App Nap", +causing its timers to get aggressively throttled. This happens because the +service worker processes are WebProcesses that have no visible WebPages. + +To address the issue, we now disable process suppression for all service worker +processes. This causes those processes to construct a UserActivity which prevents +App Nap. + +This patch also refactors the code a bit to avoid duplication. The ProcessSuppression +suppression logic in now all on ChildProcessProxy / ChildProcess. + +* NetworkProcess/NetworkProcess.messages.in: +* PluginProcess/PluginProcess.messages.in: +* Shared/ChildProcess.messages.in: +* UIProcess/ChildProcessProxy.cpp: +(WebKit::ChildProcessProxy::setProcessSuppressionEnabled): +* UIProcess/ChildProcessProxy.h: +* UIProcess/Network/NetworkProcessProxy.h: +* UIProcess/Network/mac/NetworkProcessProxyMac.mm: Removed. +* UIProcess/Plugins/PluginProcessProxy.h: +* UIProcess/Plugins/mac/PluginProcessProxyMac.mm: +* UIProcess/ServiceWorkerProcessProxy.cpp: +(WebKit::ServiceWorkerProcessProxy::didFinishLaunching): +* UIProcess/ServiceWorkerProcessProxy.h: +* UIProcess/WebProcessProxy.h: +* WebKit.xcodeproj/project.pbxproj: +* WebProcess/WebProcess.messages.in: + 2018-05-14 Andy Estes [Wi-Fi Assertions] Allow clients to specify a context identifier Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in (231770 => 231771) --- trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2018-05-14 22:14:40 UTC (rev 231770) +++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2018-05-14 22:31:40 UTC (rev 231771) @@ -52,7 +52,6 @@ ContinueWillSendRequest(WebKit::DownloadID downloadID, WebCore::ResourceRequest request) ContinueDecidePendingDownloadDestination(WebKit::DownloadID downloadID, String destination, WebKit::SandboxExtension::Handle sandboxExtensionHandle, bool allowOverwrite) -SetProcessSuppressionEnabled(bool flag) #if PLA
[webkit-changes] [231770] trunk/Source/WebKit
Title: [231770] trunk/Source/WebKit
Revision 231770
Author aes...@apple.com
Date 2018-05-14 15:14:40 -0700 (Mon, 14 May 2018)
Log Message
[Wi-Fi Assertions] Allow clients to specify a context identifier
https://bugs.webkit.org/show_bug.cgi?id=185620
Reviewed by Brady Eidson.
Added an SPI on _WKProcessPoolConfiguration that allows clients to specify a
context identifier.
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration wirelessContextIdentifier]):
(-[_WKProcessPoolConfiguration setWirelessContextIdentifier:]):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (231769 => 231770)
--- trunk/Source/WebKit/ChangeLog 2018-05-14 21:26:51 UTC (rev 231769)
+++ trunk/Source/WebKit/ChangeLog 2018-05-14 22:14:40 UTC (rev 231770)
@@ -1,3 +1,30 @@
+2018-05-14 Andy Estes
+
+[Wi-Fi Assertions] Allow clients to specify a context identifier
+https://bugs.webkit.org/show_bug.cgi?id=185620
+
+
+Reviewed by Brady Eidson.
+
+Added an SPI on _WKProcessPoolConfiguration that allows clients to specify a
+context identifier.
+
+* NetworkProcess/NetworkProcessCreationParameters.cpp:
+(WebKit::NetworkProcessCreationParameters::encode const):
+(WebKit::NetworkProcessCreationParameters::decode):
+* NetworkProcess/NetworkProcessCreationParameters.h:
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
+* UIProcess/API/APIProcessPoolConfiguration.cpp:
+(API::ProcessPoolConfiguration::copy):
+* UIProcess/API/APIProcessPoolConfiguration.h:
+* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
+* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
+(-[_WKProcessPoolConfiguration wirelessContextIdentifier]):
+(-[_WKProcessPoolConfiguration setWirelessContextIdentifier:]):
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::platformInitializeNetworkProcess):
+
2018-05-11 Brian Burg
Web Automation: Automation.getBrowsingContext returns window origin that differs from window.screenX/Y
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp (231769 => 231770)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp 2018-05-14 21:26:51 UTC (rev 231769)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp 2018-05-14 22:14:40 UTC (rev 231770)
@@ -117,6 +117,10 @@
encoder << urlSchemesRegisteredAsCanDisplayOnlyIfCanRequest;
encoder << trackNetworkActivity;
+
+#if ENABLE(WIFI_ASSERTIONS)
+encoder << wirelessContextIdentifier;
+#endif
}
bool NetworkProcessCreationParameters::decode(IPC::Decoder& decoder, NetworkProcessCreationParameters& result)
@@ -280,6 +284,11 @@
if (!decoder.decode(result.trackNetworkActivity))
return false;
+#if ENABLE(WIFI_ASSERTIONS)
+if (!decoder.decode(result.wirelessContextIdentifier))
+return false;
+#endif
+
return true;
}
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h (231769 => 231770)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h 2018-05-14 21:26:51 UTC (rev 231769)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h 2018-05-14 22:14:40 UTC (rev 231770)
@@ -134,6 +134,10 @@
Vector urlSchemesRegisteredAsCORSEnabled;
bool trackNetworkActivity { false };
+
+#if ENABLE(WIFI_ASSERTIONS)
+unsigned wirelessContextIdentifier { 0 };
+#endif
};
} // namespace WebKit
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (231769 => 231770)
--- trunk/Source/WebKit/NetworkProcess/cocoa/N
[webkit-changes] [231769] trunk/Source/WebKit
Title: [231769] trunk/Source/WebKit
Revision 231769
Author bb...@apple.com
Date 2018-05-14 14:26:51 -0700 (Mon, 14 May 2018)
Log Message
Web Automation: Automation.getBrowsingContext returns window origin that differs from window.screenX/Y
https://bugs.webkit.org/show_bug.cgi?id=185571
Reviewed by Timothy Hatcher.
This code path was refactored to use completion handlers. It seems that the window.screenX/Y
code path converts back to user coordinates but the WebDriver code path does not. Make them
consistent since that is how it is spec'd and tested.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getWindowFrameWithCallback):
Convert the window frame to user coordinate space so it's the same as window.screenY.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (231768 => 231769)
--- trunk/Source/WebKit/ChangeLog 2018-05-14 21:19:28 UTC (rev 231768)
+++ trunk/Source/WebKit/ChangeLog 2018-05-14 21:26:51 UTC (rev 231769)
@@ -1,3 +1,19 @@
+2018-05-11 Brian Burg
+
+Web Automation: Automation.getBrowsingContext returns window origin that differs from window.screenX/Y
+https://bugs.webkit.org/show_bug.cgi?id=185571
+
+
+Reviewed by Timothy Hatcher.
+
+This code path was refactored to use completion handlers. It seems that the window.screenX/Y
+code path converts back to user coordinates but the WebDriver code path does not. Make them
+consistent since that is how it is spec'd and tested.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::getWindowFrameWithCallback):
+Convert the window frame to user coordinate space so it's the same as window.screenY.
+
2018-05-14 Brian Burg
WebDriver: W3C test case actions/key.py::test_lone_keyup_sends_no_events is failing
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (231768 => 231769)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-05-14 21:19:28 UTC (rev 231768)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-05-14 21:26:51 UTC (rev 231769)
@@ -4437,7 +4437,9 @@
void WebPageProxy::getWindowFrameWithCallback(Function&& completionHandler)
{
-m_uiClient->windowFrame(*this, WTFMove(completionHandler));
+m_uiClient->windowFrame(*this, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] (FloatRect frame) {
+completionHandler(m_pageClient.convertToUserSpace(frame));
+});
}
void WebPageProxy::screenToRootView(const IntPoint& screenPoint, Ref&& reply)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231768] trunk
Title: [231768] trunk
Revision 231768
Author commit-qu...@webkit.org
Date 2018-05-14 14:19:28 -0700 (Mon, 14 May 2018)
Log Message
Test262-Runner: Fix RegExp for capturing tests metadata"
https://bugs.webkit.org/show_bug.cgi?id=185622
Patch by Leo Balter on 2018-05-14
Reviewed by Michael Saboff.
This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
both LF and CRLF forms.
The fix also allows the runner to capture the proper results from two specific files using CR and
CRLF line terminators. They are updated in the expectations file.
* Scripts/test262/Runner.pm:
(parseData):
Modified Paths
trunk/JSTests/test262/expectations.yaml
trunk/Tools/ChangeLog
trunk/Tools/Scripts/test262/Runner.pm
Diff
Modified: trunk/JSTests/test262/expectations.yaml (231767 => 231768)
--- trunk/JSTests/test262/expectations.yaml 2018-05-14 19:09:12 UTC (rev 231767)
+++ trunk/JSTests/test262/expectations.yaml 2018-05-14 21:19:28 UTC (rev 231768)
@@ -1099,11 +1099,11 @@
default: "Test262Error: Conforms to NativeFunction Syntax: 'function ( /* c */ ) /* d */ { /* e */ }'.(get /* a */ f /* b */ ( /* c */ ) /* d */ { /* e */ })"
strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'function ( /* c */ ) /* d */ { /* e */ }'.(get /* a */ f /* b */ ( /* c */ ) /* d */ { /* e */ })"
test/built-ins/Function/prototype/toString/line-terminator-normalisation-CR-LF.js:
- default: "ReferenceError: Can't find variable: assertToStringOrNativeFunction"
- strict mode: "ReferenceError: Can't find variable: assertToStringOrNativeFunction"
+ default: "Test262Error: Conforms to NativeFunction Syntax: 'function f(\r"
+ strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'function f(\r"
test/built-ins/Function/prototype/toString/line-terminator-normalisation-CR.js:
- default: "ReferenceError: Can't find variable: assertToStringOrNativeFunction"
- strict mode: "ReferenceError: Can't find variable: assertToStringOrNativeFunction"
+ default: "Test262Error: Conforms to NativeFunction Syntax: 'function f(\r// c\rx\r// d\r,\r// e\ry\r// f\r)\r// g\r{\r// h\r;\r// i\r;\r// j\r}'.(function\r// a\rf\r// b\r(\r// c\rx\r// d\r,\r// e\ry\r// f\r)\r// g\r{\r// h\r;\r// i\r;\r// j\r})"
+ strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'function f(\r// c\rx\r// d\r,\r// e\ry\r// f\r)\r// g\r{\r// h\r;\r// i\r;\r// j\r}'.(function\r// a\rf\r// b\r(\r// c\rx\r// d\r,\r// e\ry\r// f\r)\r// g\r{\r// h\r;\r// i\r;\r// j\r})"
test/built-ins/Function/prototype/toString/line-terminator-normalisation-LF.js:
default: "Test262Error: Conforms to NativeFunction Syntax: 'function f("
strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'function f("
@@ -2197,14 +2197,6 @@
test/language/eval-code/indirect/var-env-global-lex-non-strict.js:
default: 'Test262Error: Expected SameValue(«function TypeError() {'
strict mode: 'Test262Error: Expected SameValue(«function TypeError() {'
-test/language/expressions/arrow-function/arrow/binding-tests-1.js:
- strict mode: 'Test262Error: This binding initialization was incorrect for arrow capturing this from closure. Expected SameValue(«undefined», «[object global]») to be true'
-test/language/expressions/arrow-function/arrow/binding-tests-2.js:
- strict mode: 'Test262Error: This binding initialization was incorrect for arrow capturing this from closure. Expected SameValue(«undefined», «[object global]») to be true'
-test/language/expressions/arrow-function/arrow/binding-tests-3.js:
- strict mode: 'Test262Error: This binding initialization was incorrect for arrow capturing this from closure. Expected SameValue(«undefined», «[object global]») to be true'
-test/language/expressions/arrow-function/arrow/capturing-closure-variables-2.js:
- strict mode: "SyntaxError: 'with' statements are not valid in strict mode."
test/language/expressions/arrow-function/scope-body-lex-distinct.js:
default: 'Test262Error: Expected a SyntaxError to be thrown but no exception was thrown at all'
test/language/expressions/arrow-function/scope-param-elem-var-close.js:
Modified: trunk/Tools/ChangeLog (231767 => 231768)
--- trunk/Tools/ChangeLog 2018-05-14 19:09:12 UTC (rev 231767)
+++ trunk/Tools/ChangeLog 2018-05-14 21:19:28 UTC (rev 231768)
@@ -1,3 +1,18 @@
+2018-05-14 Leo Balter
+
+Test262-Runner: Fix RegExp for capturing tests metadata"
+https://bugs.webkit.org/show_bug.cgi?id=185622
+
+Reviewed by Michael Saboff.
+
+This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
+both LF and CRLF forms.
+
+The fix also allows the runner to capture the proper results from two specific files using CR and
+CRLF line terminators. They are updated in the expectations file.
+* Scripts/test262/Runner.pm:
+(parseData):
+
2018-05-14 Jeremy Jones
NSEvent event trackers don't work from WebKitTestRu
[webkit-changes] [231767] trunk/Source/WebKit
Title: [231767] trunk/Source/WebKit
Revision 231767
Author bb...@apple.com
Date 2018-05-14 12:09:12 -0700 (Mon, 14 May 2018)
Log Message
WebDriver: W3C test case actions/key.py::test_lone_keyup_sends_no_events is failing
https://bugs.webkit.org/show_bug.cgi?id=185577
Reviewed by Timothy Hatcher.
This test is failing because it expects Release Actions to not emit any
events if nothing has changed from the initial state. Because the two code paths
for creating empty states don't actually produce the same empty state, a difference
in location was detected between the two empty states. This generates a mousemove.
To fix this, unify the code that creates an empty state. For mouse input sources, always
initialize the location to (0, 0) so that the mouse input source always has
a location that is valid to click at.
* UIProcess/Automation/SimulatedInputDispatcher.h:
Extract the type enum out of the class to avoid circular definitions of
SimulatedInputSource and SimulatedInputSourceState.
* UIProcess/Automation/SimulatedInputDispatcher.cpp:
(WebKit::SimulatedInputSourceState::emptyStateForSourceType):
Take the input source type when generating an empty state. We always want location
set for a mouse input source, but not set it for other input sources like keys.
(WebKit::SimulatedInputKeyFrame::keyFrameToResetInputSources):
(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
(WebKit::SimulatedInputSource::create):
(WebKit::SimulatedInputSource::SimulatedInputSource):
(WebKit::SimulatedInputSourceState::emptyState): Deleted.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::WebAutomationSession):
(WebKit::WebAutomationSession::inputSourceForType const):
(WebKit::simulatedInputSourceTypeFromProtocolSourceType):
(WebKit::WebAutomationSession::performInteractionSequence):
* UIProcess/Automation/WebAutomationSession.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp
trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (231766 => 231767)
--- trunk/Source/WebKit/ChangeLog 2018-05-14 18:19:30 UTC (rev 231766)
+++ trunk/Source/WebKit/ChangeLog 2018-05-14 19:09:12 UTC (rev 231767)
@@ -1,3 +1,41 @@
+2018-05-14 Brian Burg
+
+WebDriver: W3C test case actions/key.py::test_lone_keyup_sends_no_events is failing
+https://bugs.webkit.org/show_bug.cgi?id=185577
+
+
+Reviewed by Timothy Hatcher.
+
+This test is failing because it expects Release Actions to not emit any
+events if nothing has changed from the initial state. Because the two code paths
+for creating empty states don't actually produce the same empty state, a difference
+in location was detected between the two empty states. This generates a mousemove.
+
+To fix this, unify the code that creates an empty state. For mouse input sources, always
+initialize the location to (0, 0) so that the mouse input source always has
+a location that is valid to click at.
+
+* UIProcess/Automation/SimulatedInputDispatcher.h:
+Extract the type enum out of the class to avoid circular definitions of
+SimulatedInputSource and SimulatedInputSourceState.
+
+* UIProcess/Automation/SimulatedInputDispatcher.cpp:
+(WebKit::SimulatedInputSourceState::emptyStateForSourceType):
+Take the input source type when generating an empty state. We always want location
+set for a mouse input source, but not set it for other input sources like keys.
+
+(WebKit::SimulatedInputKeyFrame::keyFrameToResetInputSources):
+(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
+(WebKit::SimulatedInputSource::create):
+(WebKit::SimulatedInputSource::SimulatedInputSource):
+(WebKit::SimulatedInputSourceState::emptyState): Deleted.
+* UIProcess/Automation/WebAutomationSession.cpp:
+(WebKit::WebAutomationSession::WebAutomationSession):
+(WebKit::WebAutomationSession::inputSourceForType const):
+(WebKit::simulatedInputSourceTypeFromProtocolSourceType):
+(WebKit::WebAutomationSession::performInteractionSequence):
+* UIProcess/Automation/WebAutomationSession.h:
+
2018-05-14 Michael Catanzaro
-Wmemset-elt-size warning in LibWebRTCSocket constructor
Modified: trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp (231766 => 231767)
--- trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp 2018-05-14 18:19:30 UTC (rev 231766)
+++ trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp 2018-05-14 19:09:12 UTC (rev 231767)
@@ -32,6 +32,22 @@
namespace WebKit {
+SimulatedInputSourceState SimulatedInputSo
[webkit-changes] [231766] trunk
Title: [231766] trunk Revision 231766 Author grao...@webkit.org Date 2018-05-14 11:19:30 -0700 (Mon, 14 May 2018) Log Message [Web Animations] Tests using the new animation engine may crash under WebCore::FrameView::didDestroyRenderTree when using internals methods https://bugs.webkit.org/show_bug.cgi?id=185612 Reviewed by Dean Jackson. Source/WebCore: Add a new internals.pseudoElement() method to obtain a pseudo element matching a given pseudo-id. This is necessary to be able to move off internals.pauseTransitionAtTimeOnPseudoElement() and internals.pauseAnimationAtTimeOnPseudoElement() for Web Animations testing. * testing/Internals.cpp: (WebCore::Internals::pseudoElement): * testing/Internals.h: * testing/Internals.idl: LayoutTests: Some tests that were opting into the new animation engine were using internals methods (pauseAnimationAtTimeOnElement, pauseTransitionAtTimeOnElement, etc.) that enforce the creation of animations in the old animation engine. Meanwhile, the code that toggles the animation engine used based on HTML comments is run prior to teardown of the previous test and so a test running with the new engine would run with the legacy engine during teardown. These two factors would cause `ASSERT(!frame().animation().hasAnimations())` to fail under FrameView::didDestroyRenderTree(). We update tests that use these internals method to use the Web Animations API instead and opt into the new animation engine if they didn't already do that. * animations/animation-hit-test-transform.html: * animations/keyframes-dynamic-expected.txt: * animations/keyframes-dynamic.html: * animations/missing-from-to-expected.txt: * animations/missing-from-to-transforms-expected.txt: * animations/missing-from-to-transforms.html: * animations/missing-from-to.html: * fast/css-generated-content/pseudo-animation.html: * transitions/transition-hit-test-transform.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/animations/animation-hit-test-transform.html trunk/LayoutTests/animations/keyframes-dynamic-expected.txt trunk/LayoutTests/animations/keyframes-dynamic.html trunk/LayoutTests/animations/missing-from-to-expected.txt trunk/LayoutTests/animations/missing-from-to-transforms-expected.txt trunk/LayoutTests/animations/missing-from-to-transforms.html trunk/LayoutTests/animations/missing-from-to.html trunk/LayoutTests/fast/css-generated-content/pseudo-animation.html trunk/LayoutTests/transitions/transition-hit-test-transform.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl Diff Modified: trunk/LayoutTests/ChangeLog (231765 => 231766) --- trunk/LayoutTests/ChangeLog 2018-05-14 18:15:57 UTC (rev 231765) +++ trunk/LayoutTests/ChangeLog 2018-05-14 18:19:30 UTC (rev 231766) @@ -1,5 +1,30 @@ 2018-05-14 Antoine Quint +[Web Animations] Tests using the new animation engine may crash under WebCore::FrameView::didDestroyRenderTree when using internals methods +https://bugs.webkit.org/show_bug.cgi?id=185612 + + +Reviewed by Dean Jackson. + +Some tests that were opting into the new animation engine were using internals methods (pauseAnimationAtTimeOnElement, pauseTransitionAtTimeOnElement, etc.) +that enforce the creation of animations in the old animation engine. Meanwhile, the code that toggles the animation engine used based on HTML comments is run +prior to teardown of the previous test and so a test running with the new engine would run with the legacy engine during teardown. These two factors would +cause `ASSERT(!frame().animation().hasAnimations())` to fail under FrameView::didDestroyRenderTree(). + +We update tests that use these internals method to use the Web Animations API instead and opt into the new animation engine if they didn't already do that. + +* animations/animation-hit-test-transform.html: +* animations/keyframes-dynamic-expected.txt: +* animations/keyframes-dynamic.html: +* animations/missing-from-to-expected.txt: +* animations/missing-from-to-transforms-expected.txt: +* animations/missing-from-to-transforms.html: +* animations/missing-from-to.html: +* fast/css-generated-content/pseudo-animation.html: +* transitions/transition-hit-test-transform.html: + +2018-05-14 Antoine Quint + REGRESSION (r230574): Interrupted hardware transitions don't behave correctly https://bugs.webkit.org/show_bug.cgi?id=185299 Modified: trunk/LayoutTests/animations/animation-hit-test-transform.html (231765 => 231766) --- trunk/LayoutTests/animations/animation-hit-test-transform.html 2018-05-14 18:15:57 UTC (rev 231765) +++ trunk/LayoutTests/animations/animation-hit-test-transform.html 2018-05-14 18:19:30 UTC (rev 231766) @@ -1,5 +1,4 @@ - + @@ -56,20 +55,15 @@ function doTest()
[webkit-changes] [231765] trunk
Title: [231765] trunk
Revision 231765
Author grao...@webkit.org
Date 2018-05-14 11:15:57 -0700 (Mon, 14 May 2018)
Log Message
REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=185299
Reviewed by Simon Fraser.
Source/WebCore:
In r230574, the fix for webkit.org/b/184518, we changed the processing order in GraphicsLayerCA::updateAnimations() to first
process m_uncomittedAnimations and then m_animationsToProcess, so we are guaranteed animations exist before we attempt to pause
or seek them. This broke interrupting and resuming hardware animations (such as an interrupted CSS Transition or an animation
running in a non-visible tab) since a pause operation recorded _before_ an animation was added would be paused anyway since
the animation was now first added, and then paused. The fix is simply to clear any pending AnimationProcessingAction for a
newly-uncommitted animation.
Test: transitions/interrupted-transition-hardware.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):
LayoutTests:
Add a new test where we interrupt a transition and check that upon returning to the original value,
an animated value is still used and not the initial value. This test fails prior to this patch.
* transitions/interrupted-transition-hardware-expected.html: Added.
* transitions/interrupted-transition-hardware.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
Added Paths
trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html
trunk/LayoutTests/transitions/interrupted-transition-hardware.html
Diff
Modified: trunk/LayoutTests/ChangeLog (231764 => 231765)
--- trunk/LayoutTests/ChangeLog 2018-05-14 17:39:16 UTC (rev 231764)
+++ trunk/LayoutTests/ChangeLog 2018-05-14 18:15:57 UTC (rev 231765)
@@ -1,3 +1,17 @@
+2018-05-14 Antoine Quint
+
+REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
+https://bugs.webkit.org/show_bug.cgi?id=185299
+
+
+Reviewed by Simon Fraser.
+
+Add a new test where we interrupt a transition and check that upon returning to the original value,
+an animated value is still used and not the initial value. This test fails prior to this patch.
+
+* transitions/interrupted-transition-hardware-expected.html: Added.
+* transitions/interrupted-transition-hardware.html: Added.
+
2018-05-14 Jeremy Jones
NSEvent event trackers don't work from WebKitTestRunner
Added: trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html (0 => 231765)
--- trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html (rev 0)
+++ trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html 2018-05-14 18:15:57 UTC (rev 231765)
@@ -0,0 +1,22 @@
+
+
+
+
+
+
+div {
+position: absolute;
+left: 0;
+top: 0;
+height: 100px;
+width: 100px;
+transform: translateX(25px);
+background-color: green;
+}
+
+
+
+
+
+
+
Added: trunk/LayoutTests/transitions/interrupted-transition-hardware.html (0 => 231765)
--- trunk/LayoutTests/transitions/interrupted-transition-hardware.html (rev 0)
+++ trunk/LayoutTests/transitions/interrupted-transition-hardware.html 2018-05-14 18:15:57 UTC (rev 231765)
@@ -0,0 +1,59 @@
+
+
+
+
+
+
+div {
+position: absolute;
+left: 0;
+top: 0;
+height: 100px;
+width: 100px;
+}
+
+#test {
+background-color: red;
+transition: transform 4000s linear;
+transition-delay: -2000s;
+transform: none;
+}
+
+#test.transitions {
+transform: translateX(100px);
+}
+
+#cover {
+transform: translateX(25px);
+background-color: green;
+}
+
+
+
+
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+const test = document.getElementById("test");
+
+requestAnimationFrame(() => {
+test.classList.add("transitions");
+requestAnimationFrame(() => {
+test.classList.remove("transitions");
+requestAnimationFrame(() => {
+if (window.testRunner)
+testRunner.notifyDone();
+});
+});
+
[webkit-changes] [231764] trunk/JSTests
Title: [231764] trunk/JSTests Revision 231764 Author commit-qu...@webkit.org Date 2018-05-14 10:39:16 -0700 (Mon, 14 May 2018) Log Message Fix a legacy CRLF eol from Test262 https://bugs.webkit.org/show_bug.cgi?id=185565 Patch by Leo Balter on 2018-05-14 Reviewed by Yusuke Suzuki. * test262/config.yaml: * test262/test/built-ins/Math/cbrt/prop-desc.js: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/config.yaml Diff Modified: trunk/JSTests/ChangeLog (231763 => 231764) --- trunk/JSTests/ChangeLog 2018-05-14 17:26:25 UTC (rev 231763) +++ trunk/JSTests/ChangeLog 2018-05-14 17:39:16 UTC (rev 231764) @@ -1,3 +1,13 @@ +2018-05-14 Leo Balter + +Fix a legacy CRLF eol from Test262 +https://bugs.webkit.org/show_bug.cgi?id=185565 + +Reviewed by Yusuke Suzuki. + +* test262/config.yaml: +* test262/test/built-ins/Math/cbrt/prop-desc.js: + 2018-05-14 Yusuke Suzuki [JSC] timeClip(-0) should produce +0 Modified: trunk/JSTests/test262/config.yaml (231763 => 231764) --- trunk/JSTests/test262/config.yaml 2018-05-14 17:26:25 UTC (rev 231763) +++ trunk/JSTests/test262/config.yaml 2018-05-14 17:39:16 UTC (rev 231764) @@ -3,7 +3,7 @@ skip: # (uncomment to skip tests based on path) # paths: - # - test/built-ins/Atomics +# - time-clip-to-integer.js # https://bugs.webkit.org/show_bug.cgi?id=185563 features: - SharedArrayBuffer - Atomics ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231763] trunk
Title: [231763] trunk
Revision 231763
Author commit-qu...@webkit.org
Date 2018-05-14 10:26:25 -0700 (Mon, 14 May 2018)
Log Message
NSEvent event trackers don't work from WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=185383
rdar://problem/40025045
Patch by Jeremy Jones on 2018-05-14
Reviewed by Simon Fraser.
Tools:
Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
NSEvent swipe tracking is used for webkit swipe navigation.
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
LayoutTests:
This test initiates back navigation with wheel events.
* swipe/wheel-event-initiated-back-navigation-expected.txt: Added.
* swipe/wheel-event-initiated-back-navigation.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/mac/EventSenderProxy.mm
Added Paths
trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation-expected.txt
trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (231762 => 231763)
--- trunk/LayoutTests/ChangeLog 2018-05-14 17:18:05 UTC (rev 231762)
+++ trunk/LayoutTests/ChangeLog 2018-05-14 17:26:25 UTC (rev 231763)
@@ -1,3 +1,16 @@
+2018-05-14 Jeremy Jones
+
+NSEvent event trackers don't work from WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=185383
+rdar://problem/40025045
+
+Reviewed by Simon Fraser.
+
+This test initiates back navigation with wheel events.
+
+* swipe/wheel-event-initiated-back-navigation-expected.txt: Added.
+* swipe/wheel-event-initiated-back-navigation.html: Added.
+
2018-05-14 Yusuke Suzuki
[JSC] timeClip(-0) should produce +0
Added: trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation-expected.txt (0 => 231763)
--- trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation-expected.txt (rev 0)
+++ trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation-expected.txt 2018-05-14 17:26:25 UTC (rev 231763)
@@ -0,0 +1,5 @@
+This is a swipe navigation test.
+
+PASS: mouseWheel caused navigation
+PASS: navigated back to page1
+
Added: trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation.html (0 => 231763)
--- trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation.html (rev 0)
+++ trunk/LayoutTests/swipe/wheel-event-initiated-back-navigation.html 2018-05-14 17:26:25 UTC (rev 231763)
@@ -0,0 +1,68 @@
+
+
+
+
+function logResult(s) {
+document.getElementById('result').textContent += s + "\n";
+}
+
+function backSwipe()
+{
+var divTarget = document.getElementById('content');
+var documentBounds = divTarget.getBoundingClientRect();
+
+eventSender.mouseMoveTo(documentBounds.left + 10, documentBounds.top + 10);
+eventSender.mouseScrollByWithWheelAndMomentumPhases(100, 0, 'began', 'none');
+eventSender.mouseScrollByWithWheelAndMomentumPhases(100, 0, 'changed', 'none');
+eventSender.mouseScrollByWithWheelAndMomentumPhases(100, 0, 'changed', 'none');
+eventSender.mouseScrollByWithWheelAndMomentumPhases(100, 0, 'ended', 'none');
+}
+
+function startTest()
+{
+if (!window.eventSender) {
+logResult('This test must be run in DumpRenderTree/WebKitTestRunner (no eventSender)');
+return;
+}
+
+if (!window.testRunner) {
+logResult('This test must be run in DumpRenderTree/WebKitTestRunner (no testRunner)');
+return;
+}
+
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
+testRunner.setNavigationGesturesEnabled(true);
+
+window._onpopstate_ = function(event) {
+logResult('PASS: mouseWheel caused navigation');
+if (event.state.name == "page1") {
+logResult('PASS: navigated back to ' + event.state.name);
+} else {
+logResult('FAILED: navigated back to ' + event.state.name);
+}
+testRunner.notifyDone();
+};
+
+var stateObj = { name: "page1" };
+history.replaceState(stateObj, "page1", "");
+
+var stateObj = { name: "page2" };
+history.pushState(stateObj, "page2", "");
+
+backSwipe();
+}
+
+window.addEventListener('load', startTest, false);
+
+
+
+
+
+This is a swipe navigation test.
+
+
+
+
+
\ No newline at end of file
Modified: trunk/Tools/ChangeLog (231762 => 231763)
--- trunk/Tools/ChangeLog 2018-05-14 17:18:05 UTC (rev 231762)
+++ trunk/Tools/ChangeLog 2018-05-14 17:26:25 UTC (rev 231763)
@@ -1,3 +1,17 @@
+2018-05-14 Jeremy Jones
+
+NSEvent event trackers don't work from WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=185383
+rdar://problem/40025045
+
+Reviewed by Simon Fraser.
+
+Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEven
[webkit-changes] [231762] trunk
Title: [231762] trunk
Revision 231762
Author utatane@gmail.com
Date 2018-05-14 10:18:05 -0700 (Mon, 14 May 2018)
Log Message
[JSC] timeClip(-0) should produce +0
https://bugs.webkit.org/show_bug.cgi?id=185589
Reviewed by Saam Barati.
JSTests:
Fix several test262 failures.
* stress/date-negative-zero.js: Added.
(shouldBe):
* test262/expectations.yaml:
Source/WTF:
According to the spec[1], timeClip(-0) should produce +0.
We achieve this by adding 0.0 to the result of trunc(t).
[1]: https://tc39.github.io/ecma262/#sec-timeclip
* wtf/DateMath.cpp:
(WTF::timeClip):
LayoutTests:
* sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/DateMath.cpp
Added Paths
trunk/JSTests/stress/date-negative-zero.js
Diff
Modified: trunk/JSTests/ChangeLog (231761 => 231762)
--- trunk/JSTests/ChangeLog 2018-05-14 16:47:35 UTC (rev 231761)
+++ trunk/JSTests/ChangeLog 2018-05-14 17:18:05 UTC (rev 231762)
@@ -1,3 +1,16 @@
+2018-05-14 Yusuke Suzuki
+
+[JSC] timeClip(-0) should produce +0
+https://bugs.webkit.org/show_bug.cgi?id=185589
+
+Reviewed by Saam Barati.
+
+Fix several test262 failures.
+
+* stress/date-negative-zero.js: Added.
+(shouldBe):
+* test262/expectations.yaml:
+
2018-05-13 Caio Lima
[BigInt] stress/big-int-spec-to-primitive.js test is failing
Added: trunk/JSTests/stress/date-negative-zero.js (0 => 231762)
--- trunk/JSTests/stress/date-negative-zero.js (rev 0)
+++ trunk/JSTests/stress/date-negative-zero.js 2018-05-14 17:18:05 UTC (rev 231762)
@@ -0,0 +1,7 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+var date = new Date(-0);
+shouldBe(Object.is(date.getTime(), 0), true);
Modified: trunk/JSTests/test262/expectations.yaml (231761 => 231762)
--- trunk/JSTests/test262/expectations.yaml 2018-05-14 16:47:35 UTC (rev 231761)
+++ trunk/JSTests/test262/expectations.yaml 2018-05-14 17:18:05 UTC (rev 231762)
@@ -958,9 +958,6 @@
test/built-ins/DataView/prototype/setUint8/detached-buffer.js:
default: 'Test262Error: Expected a TypeError but got a RangeError'
strict mode: 'Test262Error: Expected a TypeError but got a RangeError'
-test/built-ins/Date/TimeClip_negative_zero.js:
- default: 'Test262Error: TimeClip does not return negative zero Expected SameValue(«0», «0») to be true'
- strict mode: 'Test262Error: TimeClip does not return negative zero Expected SameValue(«0», «0») to be true'
test/built-ins/Date/UTC/return-value.js:
default: 'Test262Error: 1970 Expected SameValue(«NaN», «0») to be true'
strict mode: 'Test262Error: 1970 Expected SameValue(«NaN», «0») to be true'
@@ -973,9 +970,6 @@
test/built-ins/Date/proto-from-ctor-realm-zero.js:
default: 'TypeError: Type error'
strict mode: 'TypeError: Type error'
-test/built-ins/Date/prototype/getTime/this-value-valid-date.js:
- default: 'Test262Error: -0 Expected SameValue(«0», «0») to be true'
- strict mode: 'Test262Error: -0 Expected SameValue(«0», «0») to be true'
test/built-ins/Error/proto-from-ctor-realm.js:
default: 'Test262Error: Expected SameValue(«Error», «Error») to be true'
strict mode: 'Test262Error: Expected SameValue(«Error», «Error») to be true'
Modified: trunk/LayoutTests/ChangeLog (231761 => 231762)
--- trunk/LayoutTests/ChangeLog 2018-05-14 16:47:35 UTC (rev 231761)
+++ trunk/LayoutTests/ChangeLog 2018-05-14 17:18:05 UTC (rev 231762)
@@ -1,3 +1,12 @@
+2018-05-14 Yusuke Suzuki
+
+[JSC] timeClip(-0) should produce +0
+https://bugs.webkit.org/show_bug.cgi?id=185589
+
+Reviewed by Saam Barati.
+
+* sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt:
+
2018-05-14 Youenn Fablet
Enable service-worker/navigation-redirect-body.https.html and service-worker/postmessage.https.html
Modified: trunk/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt (231761 => 231762)
--- trunk/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt 2018-05-14 16:47:35 UTC (rev 231761)
+++ trunk/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt 2018-05-14 17:18:05 UTC (rev 231762)
@@ -1,6 +1,6 @@
S15.9.1.14_D1
-#1: TimeClip returns (ToInteger(value))
+#1: TimeClip returns (ToInteger(value) + (+0))
PASS
TEST COMPLETE
Modified: trunk/Source/WTF/ChangeLog (231761 => 231762)
--- trunk/Source/WTF/ChangeLog 2018-05-14 16:47:35 UTC (rev 231761)
+++ trunk/Source/WTF/ChangeLog 2018-05-14 17:18:05 UTC (rev 231762)
@@ -1,3 +1,18 @@
+2018-05-14 Yusuke Suzuki
+
+[JSC] timeClip(-0) should produce +0
+https://bugs.webkit.org/show_bu
[webkit-changes] [231761] trunk/Source/JavaScriptCore
Title: [231761] trunk/Source/_javascript_Core
Revision 231761
Author utatane@gmail.com
Date 2018-05-14 09:47:35 -0700 (Mon, 14 May 2018)
Log Message
[JSC] Tweak LiteralParser to improve lexing performance
https://bugs.webkit.org/show_bug.cgi?id=185541
Reviewed by Saam Barati.
This patch attemps to improve LiteralParser performance.
This patch improves Kraken/json-parse-financial by roughly ~10%.
baseline patched
json-parse-financial65.810+-1.591 ^ 59.943+-1.784 ^ definitely 1.0979x faster
* parser/Lexer.cpp:
(JSC::Lexer::Lexer):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::takeLast):
Add takeLast() for idiomatic last() + removeLast() calls.
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
Do not have mode in its template parameter. While lex function is large, this mode is not used in a critical path.
We should not include this mode in its template parameter to reduce the code size.
And we do not use template parameter for a terminator since duplicating ' and " code for lexString is not good.
Also, we construct TokenType table to remove bunch of unnecessary switch cases.
(JSC::LiteralParser::Lexer::next):
(JSC::isSafeStringCharacter):
Take mode in its template parameter. But do not take terminator character in its template parameter.
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexStringSlow):
Duplicate while statements manually since this is a critical path.
(JSC::LiteralParser::parse):
Use takeLast().
* runtime/LiteralParser.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.cpp
trunk/Source/_javascript_Core/runtime/ArgList.h
trunk/Source/_javascript_Core/runtime/LiteralParser.cpp
trunk/Source/_javascript_Core/runtime/LiteralParser.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (231760 => 231761)
--- trunk/Source/_javascript_Core/ChangeLog 2018-05-14 16:45:09 UTC (rev 231760)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-05-14 16:47:35 UTC (rev 231761)
@@ -1,3 +1,43 @@
+2018-05-14 Yusuke Suzuki
+
+[JSC] Tweak LiteralParser to improve lexing performance
+https://bugs.webkit.org/show_bug.cgi?id=185541
+
+Reviewed by Saam Barati.
+
+This patch attemps to improve LiteralParser performance.
+
+This patch improves Kraken/json-parse-financial by roughly ~10%.
+ baseline patched
+
+json-parse-financial65.810+-1.591 ^ 59.943+-1.784 ^ definitely 1.0979x faster
+
+* parser/Lexer.cpp:
+(JSC::Lexer::Lexer):
+* runtime/ArgList.h:
+(JSC::MarkedArgumentBuffer::takeLast):
+Add takeLast() for idiomatic last() + removeLast() calls.
+
+* runtime/LiteralParser.cpp:
+(JSC::LiteralParser::Lexer::lex):
+Do not have mode in its template parameter. While lex function is large, this mode is not used in a critical path.
+We should not include this mode in its template parameter to reduce the code size.
+And we do not use template parameter for a terminator since duplicating ' and " code for lexString is not good.
+Also, we construct TokenType table to remove bunch of unnecessary switch cases.
+
+(JSC::LiteralParser::Lexer::next):
+(JSC::isSafeStringCharacter):
+Take mode in its template parameter. But do not take terminator character in its template parameter.
+
+(JSC::LiteralParser::Lexer::lexString):
+(JSC::LiteralParser::Lexer::lexStringSlow):
+Duplicate while statements manually since this is a critical path.
+
+(JSC::LiteralParser::parse):
+Use takeLast().
+
+* runtime/LiteralParser.h:
+
2018-05-14 Dominik Infuehr
[MIPS] Use btpz to compare against 0 instead of bpeq
Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (231760 => 231761)
--- trunk/Source/_javascript_Core/parser/Lexer.cpp 2018-05-14 16:45:09 UTC (rev 231760)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp 2018-05-14 16:47:35 UTC (rev 231761)
@@ -94,7 +94,7 @@
};
// 256 Latin-1 codes
-static const unsigned short typesOfLatin1Characters[256] = {
+static constexpr const unsigned short typesOfLatin1Characters[256] = {
/* 0 - Null */ CharacterInvalid,
/* 1 - Start of Heading */ CharacterInvalid,
/* 2 - Start of Text */ CharacterInvalid,
@@ -355,7 +355,7 @@
// This table provides the character that results from \X where X is the index in the table beginning
// with SPACE. A table value of 0 means that more processing needs to be done.
-static const LChar singleCharacterEscapeValuesForASCII[128] = {
+static constexpr const LChar singleCharacterEscapeValuesForASCII[128] = {
/* 0 - Null */ 0,
/* 1 - Start of Heading */ 0,
/* 2 - Start of Text */ 0,
Modified: trunk/Sourc
[webkit-changes] [231760] trunk/Source/WTF
Title: [231760] trunk/Source/WTF
Revision 231760
Author gga...@apple.com
Date 2018-05-14 09:45:09 -0700 (Mon, 14 May 2018)
Log Message
Simplified Mach exception handling
https://bugs.webkit.org/show_bug.cgi?id=185595
Reviewed by Keith Miller.
* wtf/threads/Signals.cpp:
(WTF::startMachExceptionHandlerThread): Use mach_msg_server_once instead
of duplicating its functionality. Separate error handling logic from
program logic to help program logic stand out. Use
DISPATCH_TARGET_QUEUE_* instead of explicitly fetching a queue.
Also, we don't need the high priority queue. The kernel donates a
priority voucher from the exception thread to the receiver thread, and
mach_msg_server_once takes care to forward that voucher.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/threads/Signals.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (231759 => 231760)
--- trunk/Source/WTF/ChangeLog 2018-05-14 16:18:36 UTC (rev 231759)
+++ trunk/Source/WTF/ChangeLog 2018-05-14 16:45:09 UTC (rev 231760)
@@ -1,3 +1,20 @@
+2018-05-13 Geoffrey Garen
+
+Simplified Mach exception handling
+https://bugs.webkit.org/show_bug.cgi?id=185595
+
+Reviewed by Keith Miller.
+
+* wtf/threads/Signals.cpp:
+(WTF::startMachExceptionHandlerThread): Use mach_msg_server_once instead
+of duplicating its functionality. Separate error handling logic from
+program logic to help program logic stand out. Use
+DISPATCH_TARGET_QUEUE_* instead of explicitly fetching a queue.
+
+Also, we don't need the high priority queue. The kernel donates a
+priority voucher from the exception thread to the receiver thread, and
+mach_msg_server_once takes care to forward that voucher.
+
2018-05-14 Zan Dobersek
[GTK] REGRESSION(r231170) Build broken with Clang 5.0
Modified: trunk/Source/WTF/wtf/threads/Signals.cpp (231759 => 231760)
--- trunk/Source/WTF/wtf/threads/Signals.cpp 2018-05-14 16:18:36 UTC (rev 231759)
+++ trunk/Source/WTF/wtf/threads/Signals.cpp 2018-05-14 16:45:09 UTC (rev 231760)
@@ -73,43 +73,25 @@
{
static std::once_flag once;
std::call_once(once, [] {
-if (mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, &exceptionPort) != KERN_SUCCESS)
-CRASH();
+kern_return_t kr = mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, &exceptionPort);
+RELEASE_ASSERT(kr == KERN_SUCCESS);
+kr = mach_port_insert_right(mach_task_self(), exceptionPort, exceptionPort, MACH_MSG_TYPE_MAKE_SEND);
+RELEASE_ASSERT(kr == KERN_SUCCESS);
-if (mach_port_insert_right(mach_task_self(), exceptionPort, exceptionPort, MACH_MSG_TYPE_MAKE_SEND) != KERN_SUCCESS)
-CRASH();
+dispatch_source_t source = dispatch_source_create(
+DISPATCH_SOURCE_TYPE_MACH_RECV, exceptionPort, 0, DISPATCH_TARGET_QUEUE_DEFAULT);
+RELEASE_ASSERT(source);
-// It's not clear that this needs to be the high priority queue but it should be rare and it might be
-// handling exceptions from high priority threads. Anyway, our handlers should be very fast anyway so it's
-// probably not the end of the world if we handle a low priority exception on a high priority queue.
-dispatch_queue_t queue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0);
-dispatch_source_t source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MACH_RECV, exceptionPort, 0, queue);
-RELEASE_ASSERT_WITH_MESSAGE(source, "We need to ensure our source was created.");
-
-// We should never cancel our handler since it's a permanent thing so we don't add a cancel handler.
dispatch_source_set_event_handler(source, ^{
-// the leaks tool will get mad at us if we don't pretend to watch the source.
-UNUSED_PARAM(source);
-union Message {
-mach_msg_header_t header;
-char data[maxMessageSize];
-};
-Message messageHeaderIn;
-Message messageHeaderOut;
+UNUSED_PARAM(source); // Capture a pointer to source in user space to silence the leaks tool.
-kern_return_t messageResult = mach_msg(&messageHeaderIn.header, MACH_RCV_MSG, 0, maxMessageSize, exceptionPort, MACH_MSG_TIMEOUT_NONE, MACH_PORT_NULL);
-if (messageResult == KERN_SUCCESS) {
-if (!mach_exc_server(&messageHeaderIn.header, &messageHeaderOut.header))
-CRASH();
-
-messageResult = mach_msg(&messageHeaderOut.header, MACH_SEND_MSG, messageHeaderOut.header.msgh_size, 0, messageHeaderOut.header.msgh_local_port, 0, MACH_PORT_NULL);
-RELEASE_ASSERT(messageResult == KERN_SUCCESS);
-} else {
-dataLogLn("Failed to receive mach message due to ", mach_error_string(messageResult));
-RELEASE_ASSERT_NOT_REACHED();
-}
+kern_re
[webkit-changes] [231759] trunk/Source/WebCore
Title: [231759] trunk/Source/WebCore
Revision 231759
Author commit-qu...@webkit.org
Date 2018-05-14 09:18:36 -0700 (Mon, 14 May 2018)
Log Message
[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=185510
Patch by Thibault Saunier on 2018-05-14
Reviewed by Philippe Normand.
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:629: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:684: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:807: More than one command on the same line [whitespace/newline] [4]
Indentation and style issue fixed only.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChangedCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChangedCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (231758 => 231759)
--- trunk/Source/WebCore/ChangeLog 2018-05-14 15:59:56 UTC (rev 231758)
+++ trunk/Source/WebCore/ChangeLog 2018-05-14 16:18:36 UTC (rev 231759)
@@ -1,3 +1,21 @@
+2018-05-14 Thibault Saunier
+
+[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
+https://bugs.webkit.org/show_bug.cgi?id=185510
+
+Reviewed by Philippe Normand.
+
+ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:629: More than one command on the same line [whitespace/newline] [4]
+ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:684: More than one command on the same line [whitespace/newline] [4]
+ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:807: More than one command on the same line [whitespace/newline] [4]
+
+Indentation and style issue fixed only.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::volumeChangedCallback):
+(WebCore::MediaPlayerPrivateGStreamerBase::muteChangedCallback):
+(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
+
2018-05-14 Zalan Bujtas
[LFC] Implement height computation for non-replaced out of flow elements.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (231758 => 231759)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-05-14 15:59:56 UTC (rev 231758)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-05-14 16:18:36 UTC (rev 231759)
@@ -615,7 +615,9 @@
// This is called when m_volumeElement receives the notify::volume signal.
GST_DEBUG_OBJECT(player->pipeline(), "Volume changed to: %f", player->volume());
-player->m_notifier->notify(MainThreadNotification::VolumeChanged, [player] { player->notifyPlayerOfVolumeChange(); });
+player->m_notifier->notify(MainThreadNotification::VolumeChanged, [player] {
+player->notifyPlayerOfVolumeChange();
+});
}
MediaPlayer::NetworkState MediaPlayerPrivateGStreamerBase::networkState() const
@@ -670,7 +672,9 @@
void MediaPlayerPrivateGStreamerBase::muteChangedCallback(MediaPlayerPrivateGStreamerBase* player)
{
// This is called when m_volumeElement receives the notify::mute signal.
-player->m_notifier->notify(MainThreadNotification::MuteChanged, [player] { player->notifyPlayerOfMute(); });
+player->m_notifier->notify(MainThreadNotification::MuteChanged, [player] {
+player->notifyPlayerOfMute();
+});
}
void MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged()
@@ -793,7 +797,9 @@
if (triggerResize) {
GST_DEBUG_OBJECT(pipeline(), "First sample reached the sink, triggering video dimensions update");
-m_notifier->notify(MainThreadNotification::SizeChanged, [this] { m_player->sizeChanged(); });
+m_notifier->notify(MainThreadNotification::SizeChanged, [this] {
+m_player->sizeChanged();
+});
}
if (!m_renderingCanBeAccelerated) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231758] trunk/Source/WebCore
Title: [231758] trunk/Source/WebCore
Revision 231758
Author za...@apple.com
Date 2018-05-14 08:59:56 -0700 (Mon, 14 May 2018)
Log Message
[LFC] Implement height computation for non-replaced out of flow elements.
https://bugs.webkit.org/show_bug.cgi?id=185585
Reviewed by Antti Koivisto.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeHeight const):
(WebCore::Layout::FormattingContext::computeOutOfFlowHeight const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedHeight const):
(WebCore::Layout::FormattingContext::computeHeightForBlockFormattingContextRootWithAutoHeight const):
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.h:
* layout/displaytree/DisplayBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (231757 => 231758)
--- trunk/Source/WebCore/ChangeLog 2018-05-14 15:20:47 UTC (rev 231757)
+++ trunk/Source/WebCore/ChangeLog 2018-05-14 15:59:56 UTC (rev 231758)
@@ -1,3 +1,20 @@
+2018-05-14 Zalan Bujtas
+
+[LFC] Implement height computation for non-replaced out of flow elements.
+https://bugs.webkit.org/show_bug.cgi?id=185585
+
+Reviewed by Antti Koivisto.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeHeight const):
+(WebCore::Layout::FormattingContext::computeOutOfFlowHeight const):
+(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
+(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedHeight const):
+(WebCore::Layout::FormattingContext::computeHeightForBlockFormattingContextRootWithAutoHeight const):
+* layout/FormattingContext.h:
+* layout/blockformatting/BlockFormattingContext.h:
+* layout/displaytree/DisplayBox.h:
+
2018-05-14 Manuel Rego Casasnovas
Renaming of overrides in LayoutBox
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (231757 => 231758)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-14 15:20:47 UTC (rev 231757)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-14 15:59:56 UTC (rev 231758)
@@ -72,7 +72,7 @@
void FormattingContext::computeHeight(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
{
if (layoutBox.isOutOfFlowPositioned())
-return computeOutOfFlowHeight(layoutBox, displayBox);
+return computeOutOfFlowHeight(layoutContext, layoutBox, displayBox);
if (layoutBox.isFloatingPositioned())
return computeFloatingHeight(layoutBox, displayBox);
return computeInFlowHeight(layoutContext, layoutBox, displayBox);
@@ -91,8 +91,13 @@
{
}
-void FormattingContext::computeOutOfFlowHeight(const Box&, Display::Box&) const
+void FormattingContext::computeOutOfFlowHeight(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
{
+if (!layoutBox.isReplaced()) {
+computeOutOfFlowNonReplacedHeight(layoutContext, layoutBox, displayBox);
+return;
+}
+ASSERT_NOT_REACHED();
}
void FormattingContext::computeFloatingHeight(const Box&, Display::Box&) const
@@ -138,10 +143,95 @@
auto formattingContext = layoutContext.formattingContext(layoutBox);
formattingContext->layout(layoutContext, layoutContext.establishedFormattingState(layoutBox, *formattingContext));
-computeOutOfFlowHeight(layoutBox, displayBox);
+computeOutOfFlowHeight(layoutContext, layoutBox, displayBox);
}
}
+void FormattingContext::computeOutOfFlowNonReplacedHeight(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
+{
+// For absolutely positioned elements, the used values of the vertical dimensions must satisfy this constraint:
+// 'top' + 'margin-top' + 'border-top-width' + 'padding-top' + 'height' + 'padding-bottom' + 'border-bottom-width' + 'margin-bottom' + 'bottom'
+// = height of containing block
+
+// If all three of 'top', 'height', and 'bottom' are auto, set 'top' to the static position and apply rule number three below.
+
+// If none of the three are 'auto': If both 'margin-top' and 'margin-bottom' are 'auto', solve the equation under the extra
+// constraint that the two margins get equal values. If one of 'margin-top' or 'margin-bottom' is 'auto', solve the equation for that value.
+// If the values are over-constrained, ignore the value for 'bottom' and solve for that value.
+
+// Otherwise, pick the one of the following six rules that applies.
+
+// 1. 'top' and 'height' are 'auto' and 'bottom' is not 'auto', then the height is based on the content per 10.6.7,
+// set 'auto' values for 'margin-top' and 'margin-bottom' to 0, and solve for 'top'
+//
[webkit-changes] [231757] trunk/Source/WebCore
Title: [231757] trunk/Source/WebCore Revision 231757 Author r...@igalia.com Date 2018-05-14 08:20:47 -0700 (Mon, 14 May 2018) Log Message Renaming of overrides in LayoutBox https://bugs.webkit.org/show_bug.cgi?id=185609 Reviewed by Javier Fernandez. The names of the methods for the overrides were not consistent, this patch fixes it by using the same structure in all the cases. No new tests, no change of behavior. * rendering/GridLayoutFunctions.cpp: (WebCore::GridLayoutFunctions::hasOverrideContainingBlockContentSizeForChild): * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::computeChildPreferredLogicalWidths const): (WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const): * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded): * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlockFlow::updateRubyForJustifiedText): * rendering/RenderBox.cpp: (WebCore::RenderBox::willBeDestroyed): (WebCore::RenderBox::hasOverrideContentLogicalHeight const): (WebCore::RenderBox::hasOverrideContentLogicalWidth const): (WebCore::RenderBox::setOverrideContentLogicalHeight): (WebCore::RenderBox::setOverrideContentLogicalWidth): (WebCore::RenderBox::clearOverrideContentLogicalHeight): (WebCore::RenderBox::clearOverrideContentLogicalWidth): (WebCore::RenderBox::clearOverrideContentSize): (WebCore::RenderBox::overrideContentLogicalWidth const): (WebCore::RenderBox::overrideContentLogicalHeight const): (WebCore::RenderBox::overrideContainingBlockContentLogicalWidth const): (WebCore::RenderBox::overrideContainingBlockContentLogicalHeight const): (WebCore::RenderBox::hasOverrideContainingBlockContentLogicalWidth const): (WebCore::RenderBox::hasOverrideContainingBlockContentLogicalHeight const): (WebCore::RenderBox::setOverrideContainingBlockContentLogicalWidth): (WebCore::RenderBox::setOverrideContainingBlockContentLogicalHeight): (WebCore::RenderBox::clearOverrideContainingBlockContentSize): (WebCore::RenderBox::clearOverrideContainingBlockContentLogicalHeight): (WebCore::RenderBox::containingBlockLogicalWidthForContent const): (WebCore::RenderBox::containingBlockLogicalHeightForContent const): (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const): (WebCore::RenderBox::computeLogicalWidthInFragment const): (WebCore::RenderBox::computeLogicalHeight const): (WebCore::RenderBox::computePercentageLogicalHeight const): (WebCore::RenderBox::computeReplacedLogicalHeightUsing const): (WebCore::RenderBox::availableLogicalHeightUsing const): (WebCore::RenderBox::containingBlockLogicalWidthForPositioned const): (WebCore::RenderBox::containingBlockLogicalHeightForPositioned const): * rendering/RenderBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const): * rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::contentWidthForChild): (WebCore::contentHeightForChild): (WebCore::gatherFlexChildrenInfo): (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): (WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild): (WebCore::RenderFlexibleBox::crossSizeForPercentageResolution): (WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): (WebCore::RenderFlexibleBox::constructFlexItem): (WebCore::RenderFlexibleBox::setOverrideMainAxisContentSizeForChild): (WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): * rendering/RenderFullScreen.cpp: (WebCore::RenderFullScreen::unwrapRenderer): * rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutBlock): (WebCore::RenderGrid::layoutGridItems): (WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded): * rendering/RenderRubyBase.cpp: (WebCore::RenderRubyBase::adjustInlineDirectionLineBounds const): * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setOverrideContentLogicalHeightFromRowHeight): * rendering/RenderTableCell.h: * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::relayoutCellIfFlexed): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridLayoutFunctions.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp trunk/Source/WebCore/rendering/RenderFullScreen.cpp trunk/Source/WebCor
[webkit-changes] [231756] trunk/Source/WebCore
Title: [231756] trunk/Source/WebCore
Revision 231756
Author za...@apple.com
Date 2018-05-14 07:52:50 -0700 (Mon, 14 May 2018)
Log Message
[LFC] Implement width computation for non-replaced out of flow elements.
https://bugs.webkit.org/show_bug.cgi?id=185598
Reviewed by Antti Koivisto.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeWidth const):
(WebCore::Layout::FormattingContext::computeOutOfFlowWidth const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedWidth const):
(WebCore::Layout::FormattingContext::shrinkToFitWidth const):
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
* layout/displaytree/DisplayBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/displaytree/DisplayBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (231755 => 231756)
--- trunk/Source/WebCore/ChangeLog 2018-05-14 14:39:18 UTC (rev 231755)
+++ trunk/Source/WebCore/ChangeLog 2018-05-14 14:52:50 UTC (rev 231756)
@@ -1,3 +1,21 @@
+2018-05-14 Zalan Bujtas
+
+[LFC] Implement width computation for non-replaced out of flow elements.
+https://bugs.webkit.org/show_bug.cgi?id=185598
+
+Reviewed by Antti Koivisto.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeWidth const):
+(WebCore::Layout::FormattingContext::computeOutOfFlowWidth const):
+(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
+(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedWidth const):
+(WebCore::Layout::FormattingContext::shrinkToFitWidth const):
+* layout/FormattingContext.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::layout const):
+* layout/displaytree/DisplayBox.h:
+
2018-05-14 Zan Dobersek
Drop the m_compositorTexture member variable in TextureMapperGC3DPlatformLayer.
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (231755 => 231756)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-14 14:39:18 UTC (rev 231755)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2018-05-14 14:52:50 UTC (rev 231756)
@@ -28,6 +28,7 @@
#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
+#include "DisplayBox.h"
#include "LayoutBox.h"
#include "LayoutContainer.h"
#include "LayoutContext.h"
@@ -59,10 +60,10 @@
{
}
-void FormattingContext::computeWidth(const Box& layoutBox, Display::Box& displayBox) const
+void FormattingContext::computeWidth(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
{
if (layoutBox.isOutOfFlowPositioned())
-return computeOutOfFlowWidth(layoutBox, displayBox);
+return computeOutOfFlowWidth(layoutContext, layoutBox, displayBox);
if (layoutBox.isFloatingPositioned())
return computeFloatingWidth(layoutBox, displayBox);
return computeInFlowWidth(layoutBox, displayBox);
@@ -77,8 +78,13 @@
return computeInFlowHeight(layoutContext, layoutBox, displayBox);
}
-void FormattingContext::computeOutOfFlowWidth(const Box&, Display::Box&) const
+void FormattingContext::computeOutOfFlowWidth(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
{
+if (!layoutBox.isReplaced()) {
+computeOutOfFlowNonReplacedWidth(layoutContext, layoutBox, displayBox);
+return;
+}
+ASSERT_NOT_REACHED();
}
void FormattingContext::computeFloatingWidth(const Box&, Display::Box&) const
@@ -126,7 +132,7 @@
auto& displayBox = layoutContext.createDisplayBox(layoutBox);
computeOutOfFlowPosition(layoutBox, displayBox);
-computeOutOfFlowWidth(layoutBox, displayBox);
+computeOutOfFlowWidth(layoutContext, layoutBox, displayBox);
ASSERT(layoutBox.establishesFormattingContext());
auto formattingContext = layoutContext.formattingContext(layoutBox);
@@ -136,6 +142,61 @@
}
}
+void FormattingContext::computeOutOfFlowNonReplacedWidth(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
+{
+// 'left' + 'margin-left' + 'border-left-width' + 'padding-left' + 'width' + 'padding-right' + 'border-right-width' + 'margin-right' + 'right'
+// = width of containing block
+
+// If all three of 'left', 'width', and 'right' are 'auto': First set any 'auto' values for 'margin-left' and 'margin-right' to 0.
+// Then, if the 'direction' property of the element establishing the static-position containing block is 'ltr' set 'left' to the static
+// position and apply rule number three below; oth
[webkit-changes] [231755] trunk/Source/WebKit
Title: [231755] trunk/Source/WebKit
Revision 231755
Author mcatanz...@igalia.com
Date 2018-05-14 07:39:18 -0700 (Mon, 14 May 2018)
Log Message
-Wmemset-elt-size warning in LibWebRTCSocket constructor
https://bugs.webkit.org/show_bug.cgi?id=18
Reviewed by Youenn Fablet.
Add missing multiplication.
* WebProcess/Network/webrtc/LibWebRTCSocket.cpp:
(WebKit::LibWebRTCSocket::LibWebRTCSocket):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (231754 => 231755)
--- trunk/Source/WebKit/ChangeLog 2018-05-14 12:57:56 UTC (rev 231754)
+++ trunk/Source/WebKit/ChangeLog 2018-05-14 14:39:18 UTC (rev 231755)
@@ -1,3 +1,15 @@
+2018-05-14 Michael Catanzaro
+
+-Wmemset-elt-size warning in LibWebRTCSocket constructor
+https://bugs.webkit.org/show_bug.cgi?id=18
+
+Reviewed by Youenn Fablet.
+
+Add missing multiplication.
+
+* WebProcess/Network/webrtc/LibWebRTCSocket.cpp:
+(WebKit::LibWebRTCSocket::LibWebRTCSocket):
+
2018-05-14 Zan Dobersek
[GTK] REGRESSION(r231170) Build broken with Clang 5.0
Modified: trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp (231754 => 231755)
--- trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp 2018-05-14 12:57:56 UTC (rev 231754)
+++ trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp 2018-05-14 14:39:18 UTC (rev 231755)
@@ -54,7 +54,7 @@
, m_localAddress(localAddress)
, m_remoteAddress(remoteAddress)
{
-memset(&m_options, 1, MAX_SOCKET_OPTION);
+memset(&m_options, 1, MAX_SOCKET_OPTION * sizeof(m_options[0]));
}
LibWebRTCSocket::~LibWebRTCSocket()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231754] trunk/Source/WebCore
Title: [231754] trunk/Source/WebCore
Revision 231754
Author zandober...@gmail.com
Date 2018-05-14 05:57:56 -0700 (Mon, 14 May 2018)
Log Message
Drop the m_compositorTexture member variable in TextureMapperGC3DPlatformLayer.
It's not used at all inside the class or outside it.
Rubber-stamped by Michael Catanzaro.
* platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (231753 => 231754)
--- trunk/Source/WebCore/ChangeLog 2018-05-14 12:52:25 UTC (rev 231753)
+++ trunk/Source/WebCore/ChangeLog 2018-05-14 12:57:56 UTC (rev 231754)
@@ -1,5 +1,14 @@
2018-05-14 Zan Dobersek
+Drop the m_compositorTexture member variable in TextureMapperGC3DPlatformLayer.
+It's not used at all inside the class or outside it.
+
+Rubber-stamped by Michael Catanzaro.
+
+* platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
+
+2018-05-14 Zan Dobersek
+
[GTK] REGRESSION(r231170) Build broken with Clang 5.0
https://bugs.webkit.org/show_bug.cgi?id=185198
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h (231753 => 231754)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h 2018-05-14 12:52:25 UTC (rev 231753)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h 2018-05-14 12:57:56 UTC (rev 231754)
@@ -28,7 +28,6 @@
namespace WebCore {
-class BitmapTextureGL;
class GLContext;
class TextureMapperPlatformLayerProxy;
@@ -53,7 +52,6 @@
#if USE(COORDINATED_GRAPHICS_THREADED)
RefPtr m_platformLayerProxy;
-RefPtr m_compositorTexture;
#endif
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231753] trunk
Title: [231753] trunk
Revision 231753
Author zandober...@gmail.com
Date 2018-05-14 05:52:25 -0700 (Mon, 14 May 2018)
Log Message
[GTK] REGRESSION(r231170) Build broken with Clang 5.0
https://bugs.webkit.org/show_bug.cgi?id=185198
Reviewed by Michael Catanzaro.
.:
* Source/cmake/WebKitCompilerFlags.cmake: Fall back to the -std=c++1z
compiler flag if -std=c++17 is not supported. If that flag is not
supported either, bail with an error message.
Source/WebCore:
Avoid gperf files using the register keyword which has been made
reserved and as such unusable in C++17.
* css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
* css/makeSelectorPseudoElementsMap.py:
* css/makeprop.pl:
* css/makevalues.pl:
* platform/ColorData.gperf:
* platform/ReferrerPolicy.h: With std::optional forward declaration
gone, explicitly include the WTF Optional.h header.
* platform/Theme.h: Ditto.
* platform/network/create-http-header-name-table:
Source/WebKit:
* Shared/RTCNetwork.h: With std::optional forward declaration gone,
explicitly include the WTF Optional.h header.
Source/WTF:
* wtf/Compiler.h:
* wtf/Forward.h: Delete the std::optional forward declaration that is
potentially incompatible with definition provided by the standard library.
* wtf/Hasher.h:
* wtf/StdLibExtras.h: In addition to the remaining C++14 configurations,
also use custom std::in_place_t implementation when compiling with
libstdc++ 6.x, which doesn't provide its own.
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h
trunk/Source/WTF/wtf/Forward.h
trunk/Source/WTF/wtf/Hasher.h
trunk/Source/WTF/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
trunk/Source/WebCore/css/makeSelectorPseudoElementsMap.py
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/css/makevalues.pl
trunk/Source/WebCore/platform/ColorData.gperf
trunk/Source/WebCore/platform/ReferrerPolicy.h
trunk/Source/WebCore/platform/Theme.h
trunk/Source/WebCore/platform/network/create-http-header-name-table
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RTCNetwork.h
trunk/Source/cmake/WebKitCompilerFlags.cmake
Diff
Modified: trunk/ChangeLog (231752 => 231753)
--- trunk/ChangeLog 2018-05-14 10:41:07 UTC (rev 231752)
+++ trunk/ChangeLog 2018-05-14 12:52:25 UTC (rev 231753)
@@ -1,3 +1,14 @@
+2018-05-14 Zan Dobersek
+
+[GTK] REGRESSION(r231170) Build broken with Clang 5.0
+https://bugs.webkit.org/show_bug.cgi?id=185198
+
+Reviewed by Michael Catanzaro.
+
+* Source/cmake/WebKitCompilerFlags.cmake: Fall back to the -std=c++1z
+compiler flag if -std=c++17 is not supported. If that flag is not
+supported either, bail with an error message.
+
2018-05-09 Jan Alexander Steffens
[GTK] gtk-doc installation subdir duplicated
Modified: trunk/Source/WTF/ChangeLog (231752 => 231753)
--- trunk/Source/WTF/ChangeLog 2018-05-14 10:41:07 UTC (rev 231752)
+++ trunk/Source/WTF/ChangeLog 2018-05-14 12:52:25 UTC (rev 231753)
@@ -1,3 +1,18 @@
+2018-05-14 Zan Dobersek
+
+[GTK] REGRESSION(r231170) Build broken with Clang 5.0
+https://bugs.webkit.org/show_bug.cgi?id=185198
+
+Reviewed by Michael Catanzaro.
+
+* wtf/Compiler.h:
+* wtf/Forward.h: Delete the std::optional forward declaration that is
+potentially incompatible with definition provided by the standard library.
+* wtf/Hasher.h:
+* wtf/StdLibExtras.h: In addition to the remaining C++14 configurations,
+also use custom std::in_place_t implementation when compiling with
+libstdc++ 6.x, which doesn't provide its own.
+
2018-05-13 Filip Pizlo
Disable pointer poisoning
Modified: trunk/Source/WTF/wtf/Compiler.h (231752 => 231753)
--- trunk/Source/WTF/wtf/Compiler.h 2018-05-14 10:41:07 UTC (rev 231752)
+++ trunk/Source/WTF/wtf/Compiler.h 2018-05-14 12:52:25 UTC (rev 231753)
@@ -74,6 +74,8 @@
#define WTF_CPP_STD_VER 11
#elif __cplusplus <= 201402L
#define WTF_CPP_STD_VER 14
+#elif __cplusplus <= 201703L
+#define WTF_CPP_STD_VER 17
#endif
#endif
Modified: trunk/Source/WTF/wtf/Forward.h (231752 => 231753)
--- trunk/Source/WTF/wtf/Forward.h 2018-05-14 10:41:07 UTC (rev 231752)
+++ trunk/Source/WTF/wtf/Forward.h 2018-05-14 12:52:25 UTC (rev 231753)
@@ -22,10 +22,6 @@
#include
-namespace std {
-template class optional;
-}
-
namespace WTF {
class AtomicString;
Modified: trunk/Source/WTF/wtf/Hasher.h (231752 => 231753)
--- trunk/Source/WTF/wtf/Hasher.h 2018-05-14 10:41:07 UTC (rev 231752)
+++ trunk/Source/WTF/wtf/Hasher.h 2018-05-14 12:52:25 UTC (rev 231753)
@@ -21,6 +21,7 @@
#pragma once
#include
+#include
#include
#include
Modified: trunk/Source/WTF/wtf/StdLibExtras.h (231752 => 231753)
--- trunk/Source/WTF/wtf/StdLibExtras.h 2018-05-14 10:41:07 UTC (rev 231752)
+++ trunk/Source/WTF/wtf/StdLibExtras.h 2018-05-14 12:52:25 UTC
[webkit-changes] [231752] trunk/LayoutTests
Title: [231752] trunk/LayoutTests Revision 231752 Author you...@apple.com Date 2018-05-14 03:41:07 -0700 (Mon, 14 May 2018) Log Message Enable service-worker/navigation-redirect-body.https.html and service-worker/postmessage.https.html https://bugs.webkit.org/show_bug.cgi?id=185605 Unreviewed. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt: LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (231751 => 231752) --- trunk/LayoutTests/ChangeLog 2018-05-14 10:20:24 UTC (rev 231751) +++ trunk/LayoutTests/ChangeLog 2018-05-14 10:41:07 UTC (rev 231752) @@ -1,5 +1,14 @@ 2018-05-14 Youenn Fablet +Enable service-worker/navigation-redirect-body.https.html and service-worker/postmessage.https.html +https://bugs.webkit.org/show_bug.cgi?id=185605 + +Unreviewed. + +* TestExpectations: + +2018-05-14 Youenn Fablet + Mark imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html as slow in debug https://bugs.webkit.org/show_bug.cgi?id=185604 Modified: trunk/LayoutTests/TestExpectations (231751 => 231752) --- trunk/LayoutTests/TestExpectations 2018-05-14 10:20:24 UTC (rev 231751) +++ trunk/LayoutTests/TestExpectations 2018-05-14 10:41:07 UTC (rev 231752) @@ -175,7 +175,6 @@ # Skip service worker tests that are timing out. imported/w3c/web-platform-tests/fetch/api/abort/general-serviceworker.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/performance-timeline.https.html [ Skip ] -imported/w3c/web-platform-tests/service-workers/service-worker/postmessage.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/update-bytecheck.https.html [ Skip ] @@ -190,9 +189,6 @@ imported/w3c/web-platform-tests/service-workers/service-worker/shared-worker-controlled.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/claim-shared-worker-fetch.https.html [ Skip ] -# Reliably ASSERTS in ServiceWorkerClientFetch::didFinish -imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-body.https.html [ Skip ] - imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html [ Pass Failure ] # Console log lines may appear in a different order so we silence them. Modified: trunk/LayoutTests/imported/w3c/ChangeLog (231751 => 231752) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-05-14 10:20:24 UTC (rev 231751) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-05-14 10:41:07 UTC (rev 231752) @@ -1,3 +1,12 @@ +2018-05-14 Youenn Fablet + +Enable service-worker/navigation-redirect-body.https.html and service-worker/postmessage.https.html +https://bugs.webkit.org/show_bug.cgi?id=185605 + +Unreviewed. + +* web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt: + 2018-05-11 Ryosuke Niwa Tapping after CSS-based table casues an infinite loop in wordRangeFromPosition Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt (231751 => 231752) --- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt 2018-05-14 10:20:24 UTC (rev 231751) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt 2018-05-14 10:41:07 UTC (rev 231752) @@ -1,7 +1,5 @@ -Harness Error (TIMEOUT), message = null - PASS postMessage to a ServiceWorker (and back via MessagePort) -TIMEOUT postMessage a transferable ArrayBuffer between ServiceWorker and Client Test timed out -NOTRUN postMessage a transferable ArrayBuffer between ServiceWorker and Client over MessagePort +PASS postMessage a transferable ArrayBuffer between ServiceWorker and Client +PASS postMessage a transferable ArrayBuffer between ServiceWorker and Client over MessagePort ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231751] trunk/Source/JavaScriptCore
Title: [231751] trunk/Source/_javascript_Core Revision 231751 Author commit-qu...@webkit.org Date 2018-05-14 03:20:24 -0700 (Mon, 14 May 2018) Log Message [MIPS] Use btpz to compare against 0 instead of bpeq https://bugs.webkit.org/show_bug.cgi?id=185607 Patch by Dominik Infuehr on 2018-05-14 Reviewed by Yusuke Suzuki. Fixes build on MIPS since MIPS doesn't have an instruction to compare a register against an immediate. Since the immediate is just 0 in this case the simplest solution is just to use btpz instead of bpeq to compare to 0. * llint/LowLevelInterpreter.asm: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm Diff Modified: trunk/Source/_javascript_Core/ChangeLog (231750 => 231751) --- trunk/Source/_javascript_Core/ChangeLog 2018-05-14 08:32:43 UTC (rev 231750) +++ trunk/Source/_javascript_Core/ChangeLog 2018-05-14 10:20:24 UTC (rev 231751) @@ -1,3 +1,17 @@ +2018-05-14 Dominik Infuehr + +[MIPS] Use btpz to compare against 0 instead of bpeq +https://bugs.webkit.org/show_bug.cgi?id=185607 + +Reviewed by Yusuke Suzuki. + +Fixes build on MIPS since MIPS doesn't have an instruction to +compare a register against an immediate. Since the immediate is just 0 +in this case the simplest solution is just to use btpz instead of bpeq +to compare to 0. + +* llint/LowLevelInterpreter.asm: + 2018-05-12 Filip Pizlo CachedCall::call() should be faster Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm (231750 => 231751) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2018-05-14 08:32:43 UTC (rev 231750) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2018-05-14 10:20:24 UTC (rev 231751) @@ -1121,7 +1121,7 @@ assert(macro (ok) bpgteq t0, 0, ok end) btpz t0, .argumentProfileDone loadp CodeBlock::m_argumentValueProfiles + VectorBufferOffset[t1], t3 -bpeq 0, t3, .argumentProfileDone # When we can't JIT, we don't allocate any argument value profiles. +btpz t3, .argumentProfileDone # When we can't JIT, we don't allocate any argument value profiles. mulp sizeof ValueProfile, t0, t2 # A! Need strength reduction! lshiftp 3, t0 addp t2, t3 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231750] trunk/LayoutTests
Title: [231750] trunk/LayoutTests Revision 231750 Author you...@apple.com Date 2018-05-14 01:32:43 -0700 (Mon, 14 May 2018) Log Message Mark imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html as slow in debug https://bugs.webkit.org/show_bug.cgi?id=185604 Unreviewed. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (231749 => 231750) --- trunk/LayoutTests/ChangeLog 2018-05-14 07:33:55 UTC (rev 231749) +++ trunk/LayoutTests/ChangeLog 2018-05-14 08:32:43 UTC (rev 231750) @@ -1,3 +1,12 @@ +2018-05-14 Youenn Fablet + +Mark imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html as slow in debug +https://bugs.webkit.org/show_bug.cgi?id=185604 + +Unreviewed. + +* TestExpectations: + 2018-05-13 Andy VanWagoner [INTL] Improve spec & test262 compliance for Intl APIs Modified: trunk/LayoutTests/TestExpectations (231749 => 231750) --- trunk/LayoutTests/TestExpectations 2018-05-14 07:33:55 UTC (rev 231749) +++ trunk/LayoutTests/TestExpectations 2018-05-14 08:32:43 UTC (rev 231750) @@ -225,6 +225,7 @@ [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/activation.https.html [ Slow ] [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https.html [ Slow ] [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-mime-types.https.html [ Slow ] +[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Slow ] # Reenable it when having a custom gc exposed in service workers. [ Debug ] http/wpt/service-workers/fetchEvent.https.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [231749] trunk/Source/WebCore
Title: [231749] trunk/Source/WebCore
Revision 231749
Author commit-qu...@webkit.org
Date 2018-05-14 00:33:55 -0700 (Mon, 14 May 2018)
Log Message
Unreviewed, rolling out r219515.
https://bugs.webkit.org/show_bug.cgi?id=185603
It sometimes makes AudioUnitInitialize call to fail in
CoreAudioCaptureSource (Requested by youenn on #webkit).
Reverted changeset:
"Remove CoreAudioCaptureSource speaker configuration"
https://bugs.webkit.org/show_bug.cgi?id=174512
https://trac.webkit.org/changeset/219515
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (231748 => 231749)
--- trunk/Source/WebCore/ChangeLog 2018-05-14 04:36:05 UTC (rev 231748)
+++ trunk/Source/WebCore/ChangeLog 2018-05-14 07:33:55 UTC (rev 231749)
@@ -1,3 +1,17 @@
+2018-05-14 Commit Queue
+
+Unreviewed, rolling out r219515.
+https://bugs.webkit.org/show_bug.cgi?id=185603
+
+It sometimes makes AudioUnitInitialize call to fail in
+CoreAudioCaptureSource (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"Remove CoreAudioCaptureSource speaker configuration"
+https://bugs.webkit.org/show_bug.cgi?id=174512
+https://trac.webkit.org/changeset/219515
+
2018-05-13 Dirk Schulze
Implement SVGGeometryElement's isPointInFill and isPointInStroke
Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (231748 => 231749)
--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2018-05-14 04:36:05 UTC (rev 231748)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2018-05-14 07:33:55 UTC (rev 231749)
@@ -307,7 +307,9 @@
if (err)
return err;
-// For the moment we do not need to configure speaker proc as we are not providing any reference data.
+err = configureSpeakerProc();
+if (err)
+return err;
err = AudioUnitInitialize(m_ioUnit);
if (err) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
