date:20190326

[webkit-changes] [243532] trunk/Source/WebCore

2019-03-26 Thread said

Title: [243532] trunk/Source/WebCore








Revision 243532
Author s...@apple.com
Date 2019-03-26 18:05:32 -0700 (Tue, 26 Mar 2019)


Log Message
Unreviewed Windows build fix
https://bugs.webkit.org/show_bug.cgi?id=196083


* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::isSupportedAttributeType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimatorFactory.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (243531 => 243532)

--- trunk/Source/WebCore/ChangeLog	2019-03-27 00:55:19 UTC (rev 243531)
+++ trunk/Source/WebCore/ChangeLog	2019-03-27 01:05:32 UTC (rev 243532)
@@ -1,3 +1,12 @@
+2019-03-26  Said Abou-Hallawa  
+
+Unreviewed Windows build fix
+https://bugs.webkit.org/show_bug.cgi?id=196083
+
+
+* svg/SVGAnimatorFactory.h:
+(WebCore::SVGAnimatorFactory::isSupportedAttributeType):
+
 2019-03-26  Wenson Hsieh  
 
 [Cocoa] Refactor some helper functions for building UserAgent strings


Modified: trunk/Source/WebCore/svg/SVGAnimatorFactory.h (243531 => 243532)

--- trunk/Source/WebCore/svg/SVGAnimatorFactory.h	2019-03-27 00:55:19 UTC (rev 243531)
+++ trunk/Source/WebCore/svg/SVGAnimatorFactory.h	2019-03-27 01:05:32 UTC (rev 243532)
@@ -47,12 +47,14 @@
 case AnimatedRect:
 case AnimatedString:
 case AnimatedUnknown:
-return false;
+break;
 
 case AnimatedPath:
 case AnimatedTransformList:
 return true;
 }
+
+return false;
 }
 
 static std::unique_ptr create(SVGAnimationElement* animationElement, SVGElement* contextElement, AnimatedPropertyType attributeType)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243531] trunk/Source/WebKit

2019-03-26 Thread bfulgham

Title: [243531] trunk/Source/WebKit








Revision 243531
Author bfulg...@apple.com
Date 2019-03-26 17:55:19 -0700 (Tue, 26 Mar 2019)


Log Message
[macOS] Correct kerberos-related sandbox violations
https://bugs.webkit.org/show_bug.cgi?id=196279


Reviewed by Per Arne Vollan.

We need to allow communications with a Kerberos-related service on macOS
until  is fixed.

* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (243530 => 243531)

--- trunk/Source/WebKit/ChangeLog	2019-03-27 00:08:46 UTC (rev 243530)
+++ trunk/Source/WebKit/ChangeLog	2019-03-27 00:55:19 UTC (rev 243531)
@@ -1,3 +1,16 @@
+2019-03-26  Brent Fulgham  
+
+[macOS] Correct kerberos-related sandbox violations
+https://bugs.webkit.org/show_bug.cgi?id=196279
+
+
+Reviewed by Per Arne Vollan.
+
+We need to allow communications with a Kerberos-related service on macOS
+until  is fixed.
+
+* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+
 2019-03-26  Chris Dumez  
 
 [macOS] The network process is not exiting reliably when the WebProcessPool is destroyed


Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (243530 => 243531)

--- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2019-03-27 00:08:46 UTC (rev 243530)
+++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2019-03-27 00:55:19 UTC (rev 243531)
@@ -94,6 +94,7 @@
 "kCFPreferencesAnyApplication"
 "com.apple.DownloadAssessment"
 "com.apple.WebFoundation"
+"com.apple.ist.ds.appleconnect2.uat" ;; Remove after  ships
 "com.apple.networkConnect"))
 (allow file-read*
 ;; Basic system paths
@@ -226,6 +227,7 @@
 (allow mach-lookup
 (global-name "org.h5l.kcm")
 (global-name "com.apple.GSSCred")
+(global-name "com.apple.ist.ds.appleconnect.service.kdctunnel") ;; Remove after  ships
 (global-name "com.apple.system.logger")
 (global-name "com.apple.system.notification_center"))
 (allow network-outbound






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243530] trunk/Source/JavaScriptCore

2019-03-26 Thread sbarati

Title: [243530] trunk/Source/_javascript_Core








Revision 243530
Author sbar...@apple.com
Date 2019-03-26 17:08:46 -0700 (Tue, 26 Mar 2019)


Log Message
FTL: Emit code to validate AI's state when running the compiled code
https://bugs.webkit.org/show_bug.cgi?id=195924


Reviewed by Filip Pizlo.

This patch adds code that between the execution of each node that validates
the types that AI proves. This option is too expensive to turn on for our
regression testing, but we think it will be valuable in other types of running
modes, such as when running with a fuzzer.

This patch also adds options to only probabilistically run this validation
after the execution of each node. As the probability is lowered, there is
less of a perf hit.

This patch just adds this validation in the FTL. A follow-up patch will land
it in the DFG too: https://bugs.webkit.org/show_bug.cgi?id=196219

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::LowerDFGToB3):
(JSC::FTL::DFG::LowerDFGToB3::compileBlock):
(JSC::FTL::DFG::LowerDFGToB3::validateAIState):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::lowJSValue):
* runtime/Options.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (243529 => 243530)

--- trunk/Source/_javascript_Core/ChangeLog	2019-03-27 00:02:55 UTC (rev 243529)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-03-27 00:08:46 UTC (rev 243530)
@@ -1,3 +1,31 @@
+2019-03-26  Saam Barati  
+
+FTL: Emit code to validate AI's state when running the compiled code
+https://bugs.webkit.org/show_bug.cgi?id=195924
+
+
+Reviewed by Filip Pizlo.
+
+This patch adds code that between the execution of each node that validates
+the types that AI proves. This option is too expensive to turn on for our
+regression testing, but we think it will be valuable in other types of running
+modes, such as when running with a fuzzer.
+
+This patch also adds options to only probabilistically run this validation
+after the execution of each node. As the probability is lowered, there is
+less of a perf hit.
+
+This patch just adds this validation in the FTL. A follow-up patch will land
+it in the DFG too: https://bugs.webkit.org/show_bug.cgi?id=196219
+
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::LowerDFGToB3):
+(JSC::FTL::DFG::LowerDFGToB3::compileBlock):
+(JSC::FTL::DFG::LowerDFGToB3::validateAIState):
+(JSC::FTL::DFG::LowerDFGToB3::compileNode):
+(JSC::FTL::DFG::LowerDFGToB3::lowJSValue):
+* runtime/Options.h:
+
 2019-03-26  Tadeu Zagallo  
 
 WebAssembly: Fix f32.min, f64.min and f64.max operations on NaN


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (243529 => 243530)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-03-27 00:02:55 UTC (rev 243529)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2019-03-27 00:08:46 UTC (rev 243530)
@@ -46,6 +46,7 @@
 #include "DFGDoesGC.h"
 #include "DFGDominators.h"
 #include "DFGInPlaceAbstractState.h"
+#include "DFGLivenessAnalysisPhase.h"
 #include "DFGMayExit.h"
 #include "DFGOSRAvailabilityAnalysisPhase.h"
 #include "DFGOSRExitFuzz.h"
@@ -82,6 +83,7 @@
 #include "JSLexicalEnvironment.h"
 #include "JSMap.h"
 #include "OperandsInlines.h"
+#include "ProbeContext.h"
 #include "RegExpObject.h"
 #include "ScopedArguments.h"
 #include "ScopedArgumentsTable.h"
@@ -155,6 +157,29 @@
 , m_interpreter(state.graph, m_state)
 , m_indexMaskingMode(Options::enableSpectreMitigations() ?  IndexMaskingEnabled : IndexMaskingDisabled)
 {
+if (Options::validateAbstractInterpreterState()) {
+performLivenessAnalysis(m_graph);
+
+// We only use node liveness here, not combined liveness, as we only track
+// AI state for live nodes.
+for (DFG::BasicBlock* block : m_graph.blocksInNaturalOrder()) {
+NodeSet live;
+
+for (NodeFlowProjection node : block->ssa->liveAtTail) {
+if (node.kind() == NodeFlowProjection::Primary)
+live.addVoid(node.node());
+}
+
+for (unsigned i = block->size(); i--; ) {
+Node* node = block->at(i);
+live.remove(node);
+m_graph.doToChildren(node, [&] (Edge child) {
+live.addVoid(child.node());
+});
+m_liveInToNode.add(node, live);
+}
+}
+}
 }
 
 void lower()
@@ -473,6 +498,8 @@
 crash(m_highBlock, nullptr);
 return;
 }
+
+m_aiCheckedNodes.clear();
 
 m_availabi

[webkit-changes] [243528] trunk/Source/WebKit

2019-03-26 Thread cdumez

Title: [243528] trunk/Source/WebKit








Revision 243528
Author cdu...@apple.com
Date 2019-03-26 16:54:11 -0700 (Tue, 26 Mar 2019)


Log Message
[macOS] The network process is not exiting reliably when the WebProcessPool is destroyed
https://bugs.webkit.org/show_bug.cgi?id=196277


Reviewed by Alex Christensen.

When, an AuxiliaryProcess receives the AuxiliaryProcess::Terminate IPC, it calls stopRunLoop()
to exit. WebProcess overrides AuxiliaryProcess::stopRunLoop() to call exit(0) on the main
thread. Other auxiliary processes such as the NetworkProcess would end up calling
platformStopRunLoop(). On iOS and iOSMac, platformStopRunLoop() calls XPCServiceExit(), which
makes sense since auxiliary processes run their run loop by calling xpc_main(). However, on
macOS, platformStopRunLoop() was calling RunLoop::main().stop() to exit instead, which was
unreliable as demonstrated by the test app attached to the radar.

Updating platformStopRunLoop() to call XPCServiceExit() on macOS fixes the problem and I now
see the NetworkProcess exiting reliably there. This is the approach I have chosen in this
patch since it appears to be reliable and it makes the code consistent on all Cocoa platforms.

* Shared/AuxiliaryProcess.cpp:
* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::platformStopRunLoop):
* Shared/ios/AuxiliaryProcessIOS.mm:
(WebKit::AuxiliaryProcess::platformStopRunLoop): Deleted.
* Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::platformStopRunLoop): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp
trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
trunk/Source/WebKit/Shared/ios/AuxiliaryProcessIOS.mm
trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (243527 => 243528)

--- trunk/Source/WebKit/ChangeLog	2019-03-26 23:51:10 UTC (rev 243527)
+++ trunk/Source/WebKit/ChangeLog	2019-03-26 23:54:11 UTC (rev 243528)
@@ -1,3 +1,31 @@
+2019-03-26  Chris Dumez  
+
+[macOS] The network process is not exiting reliably when the WebProcessPool is destroyed
+https://bugs.webkit.org/show_bug.cgi?id=196277
+
+
+Reviewed by Alex Christensen.
+
+When, an AuxiliaryProcess receives the AuxiliaryProcess::Terminate IPC, it calls stopRunLoop()
+to exit. WebProcess overrides AuxiliaryProcess::stopRunLoop() to call exit(0) on the main
+thread. Other auxiliary processes such as the NetworkProcess would end up calling
+platformStopRunLoop(). On iOS and iOSMac, platformStopRunLoop() calls XPCServiceExit(), which
+makes sense since auxiliary processes run their run loop by calling xpc_main(). However, on
+macOS, platformStopRunLoop() was calling RunLoop::main().stop() to exit instead, which was
+unreliable as demonstrated by the test app attached to the radar.
+
+Updating platformStopRunLoop() to call XPCServiceExit() on macOS fixes the problem and I now
+see the NetworkProcess exiting reliably there. This is the approach I have chosen in this
+patch since it appears to be reliable and it makes the code consistent on all Cocoa platforms.
+
+* Shared/AuxiliaryProcess.cpp:
+* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
+(WebKit::AuxiliaryProcess::platformStopRunLoop):
+* Shared/ios/AuxiliaryProcessIOS.mm:
+(WebKit::AuxiliaryProcess::platformStopRunLoop): Deleted.
+* Shared/mac/AuxiliaryProcessMac.mm:
+(WebKit::AuxiliaryProcess::platformStopRunLoop): Deleted.
+
 2019-03-26  Keith Rollin  
 
 Inhibit CFNetwork logging in private sessions


Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp (243527 => 243528)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2019-03-26 23:51:10 UTC (rev 243527)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2019-03-26 23:54:11 UTC (rev 243528)
@@ -174,7 +174,7 @@
 platformStopRunLoop();
 }
 
-#if !PLATFORM(IOS_FAMILY)
+#if !PLATFORM(COCOA)
 void AuxiliaryProcess::platformStopRunLoop()
 {
 RunLoop::main().stop();


Modified: trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm (243527 => 243528)

--- trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm	2019-03-26 23:51:10 UTC (rev 243527)
+++ trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm	2019-03-26 23:54:11 UTC (rev 243528)
@@ -27,6 +27,7 @@
 #import "AuxiliaryProcess.h"
 
 #import "WKCrashReporter.h"
+#import "XPCServiceEntryPoint.h"
 #import 
 
 namespace WebKit {
@@ -42,4 +43,9 @@
 return WTF::hasEntitlement(m_connection->xpcConnection(), entitlement);
 }
 
+void AuxiliaryProcess::platformStopRunLoop()
+{
+XPCServiceExit(WTFMove(m_priorityBoostMessage));
 }
+
+}


Modified: trunk/Source/WebKit/Shared/ios/AuxiliaryProcessIOS.mm (243527 => 243528)

--- trunk/Source/WebKit/Shared/ios/AuxiliaryProcessIOS.mm	2019-03-26 23:51:10 UTC (rev 243527)
+++ trunk/Source/WebKit/Shared/ios/AuxiliaryProce

[webkit-changes] [243527] trunk/Tools

2019-03-26 Thread krollin

Title: [243527] trunk/Tools








Revision 243527
Author krol...@apple.com
Date 2019-03-26 16:51:10 -0700 (Tue, 26 Mar 2019)


Log Message
Update the way generate-xcfilelists returns strings from functions
https://bugs.webkit.org/show_bug.cgi?id=195975


Reviewed by Dean Jackson.

There are places where generate-xcfilelists executes assignments with
statements like:

FOO=$(some_function)

where "some_function" return a string by echoing it. E.g.

some_function()
{
echo "Hello, World"
}

This is a common idiom, but it has a problem if "some_function" needs
to call "exit" in an attempt to halt the entire script right then and
there. Since "some_function" is called inside of $(), it's being
executed in a sub-shell. Calling exit in that sub-shell simply exits
that shell; it doesn't not exit the outer shell in which the main part
of the script is still running. As such, the main script keeps
executing when the intent was for the script to halt.

The solution to this is to use a different idiom for returning
strings. The one we now is to pass in the name of the variable to
receive the string result:

some_function()
{
variable_name=$1
eval $variable_name ="Hello, World"
}

The call site now looks like

some_function FOO

Because there's no invocation of a sub-shell, some_function can now
call "exit" if it wants to, and the entire script will exit at that
point.

* Scripts/generate-xcfilelists:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-xcfilelists




Diff

Modified: trunk/Tools/ChangeLog (243526 => 243527)

--- trunk/Tools/ChangeLog	2019-03-26 23:50:33 UTC (rev 243526)
+++ trunk/Tools/ChangeLog	2019-03-26 23:51:10 UTC (rev 243527)
@@ -1,3 +1,51 @@
+2019-03-26  Keith Rollin  
+
+Update the way generate-xcfilelists returns strings from functions
+https://bugs.webkit.org/show_bug.cgi?id=195975
+
+
+Reviewed by Dean Jackson.
+
+There are places where generate-xcfilelists executes assignments with
+statements like:
+
+FOO=$(some_function)
+
+where "some_function" return a string by echoing it. E.g.
+
+some_function()
+{
+echo "Hello, World"
+}
+
+This is a common idiom, but it has a problem if "some_function" needs
+to call "exit" in an attempt to halt the entire script right then and
+there. Since "some_function" is called inside of $(), it's being
+executed in a sub-shell. Calling exit in that sub-shell simply exits
+that shell; it doesn't not exit the outer shell in which the main part
+of the script is still running. As such, the main script keeps
+executing when the intent was for the script to halt.
+
+The solution to this is to use a different idiom for returning
+strings. The one we now is to pass in the name of the variable to
+receive the string result:
+
+some_function()
+{
+variable_name=$1
+eval $variable_name ="Hello, World"
+}
+
+The call site now looks like
+
+some_function FOO
+
+Because there's no invocation of a sub-shell, some_function can now
+call "exit" if it wants to, and the entire script will exit at that
+point.
+
+* Scripts/generate-xcfilelists:
+
 2019-03-26  Chris Dumez  
 
 Add basic layout test coverage for File Picker on iOS


Modified: trunk/Tools/Scripts/generate-xcfilelists (243526 => 243527)

--- trunk/Tools/Scripts/generate-xcfilelists	2019-03-26 23:50:33 UTC (rev 243526)
+++ trunk/Tools/Scripts/generate-xcfilelists	2019-03-26 23:51:10 UTC (rev 243527)
@@ -607,13 +607,14 @@
 log_callstack_and_parameters "$@"
 
 local GX_PROVISIONAL_CONFIGURATION=$(echo "$1" | tr '[:upper:]' '[:lower:]')
+local GX_RESULT=$2
 
-[[ "${GX_PROVISIONAL_CONFIGURATION}" == "" ]] && { echo ""; return; }
+[[ "${GX_PROVISIONAL_CONFIGURATION}" == "" ]]   && { eval $GX_RESULT=""; return; }
 
-[[ "${GX_PROVISIONAL_CONFIGURATION}" == "debug" ]] && { echo "Debug"; return; }
-[[ "${GX_PROVISIONAL_CONFIGURATION}" == "release" ]] && { echo "Release"; return; }
-[[ "${GX_PROVISIONAL_CONFIGURATION}" == "production" ]] && { echo "Production"; return; }
-[[ "${GX_PROVISIONAL_CONFIGURATION}" == "profiling" ]] && { echo "Profiling"; return; }
+[[ "${GX_PROVISIONAL_CONFIGURATION}" == "debug" ]]  && { eval $GX_RESULT="Debug"; return; }
+[[ "${GX_PROVISIONAL_CONFIGURATION}" == "release" ]]&& { eval $GX_RESULT="Release"; return; }
+[[ "${GX_PROVISIONAL_CONFIGURATION}" == "production" ]] && { eval $GX_RESULT="Production"; return; }
+[[ "${GX_PROVISIONAL_CONFIGURATION}" == "profiling" ]]  && { eval $GX_RESULT="Profiling"; return; }
 
 die "Unrecognized configuration: $1"
 }
@@ -624,27 +625,28 @@
 log_callstack_and_parameters "$@"
 
 local GX_PR

[webkit-changes] [243526] trunk/Websites/browserbench.org

2019-03-26 Thread jond

Title: [243526] trunk/Websites/browserbench.org








Revision 243526
Author j...@apple.com
Date 2019-03-26 16:50:33 -0700 (Tue, 26 Mar 2019)


Log Message
Update BrowserBench for JetStream2.
https://bugs.webkit.org/show_bug.cgi?id=196273

Reviewed by Saam Barati.

* index.html:
* resources/JetStream2-Logo.png: Added.
* resources/jetstream2-l...@2x.png: Added.
* resources/main.css:
(.benchmark:hover img): Improved hover effect for the JetStream2 logo.

Modified Paths

trunk/Websites/browserbench.org/ChangeLog
trunk/Websites/browserbench.org/index.html
trunk/Websites/browserbench.org/resources/main.css


Added Paths

trunk/Websites/browserbench.org/resources/JetStream2-Logo.png
trunk/Websites/browserbench.org/resources/jetstream2-l...@2x.png




Diff

Modified: trunk/Websites/browserbench.org/ChangeLog (243525 => 243526)

--- trunk/Websites/browserbench.org/ChangeLog	2019-03-26 23:41:42 UTC (rev 243525)
+++ trunk/Websites/browserbench.org/ChangeLog	2019-03-26 23:50:33 UTC (rev 243526)
@@ -1,3 +1,16 @@
+2019-03-26  Jon Davis  
+
+Update BrowserBench for JetStream2.
+https://bugs.webkit.org/show_bug.cgi?id=196273
+
+Reviewed by Saam Barati.
+
+* index.html:
+* resources/JetStream2-Logo.png: Added.
+* resources/jetstream2-l...@2x.png: Added.
+* resources/main.css:
+(.benchmark:hover img): Improved hover effect for the JetStream2 logo.
+
 2019-03-25  Saam barati  
 
 Update browserbench.org/JetStream2.0 to the latest version.


Modified: trunk/Websites/browserbench.org/index.html (243525 => 243526)

--- trunk/Websites/browserbench.org/index.html	2019-03-26 23:41:42 UTC (rev 243525)
+++ trunk/Websites/browserbench.org/index.html	2019-03-26 23:50:33 UTC (rev 243526)
@@ -40,10 +40,11 @@
 
 
 
-
-
-
-ARES-6 is a benchmark designed to test ECMAScript 6 applications.
+
+
+
+JetStream 2 is a _javascript_ and WebAssembly benchmark suite focused on advanced web applications.
 
 
 
@@ -57,11 +58,6 @@
 Speedometer is a browser benchmark that measures the responsiveness of web applications.
 
 
-
-
-JetStream is a _javascript_ benchmark suite focused on the most advanced web applications.
-
 
 
 


Added: trunk/Websites/browserbench.org/resources/JetStream2-Logo.png

(Binary files differ)

Index: trunk/Websites/browserbench.org/resources/JetStream2-Logo.png
===
--- trunk/Websites/browserbench.org/resources/JetStream2-Logo.png	2019-03-26 23:41:42 UTC (rev 243525)
+++ trunk/Websites/browserbench.org/resources/JetStream2-Logo.png	2019-03-26 23:50:33 UTC (rev 243526)
Property changes on: trunk/Websites/browserbench.org/resources/JetStream2-Logo.png
___

Added: svn:mime-type
+image/png
\ No newline at end of property

Added: trunk/Websites/browserbench.org/resources/jetstream2-l...@2x.png

(Binary files differ)

Index: trunk/Websites/browserbench.org/resources/jetstream2-l...@2x.png
===
--- trunk/Websites/browserbench.org/resources/jetstream2-l...@2x.png	2019-03-26 23:41:42 UTC (rev 243525)
+++ trunk/Websites/browserbench.org/resources/jetstream2-l...@2x.png	2019-03-26 23:50:33 UTC (rev 243526)
Property changes on: trunk/Websites/browserbench.org/resources/jetstream2-l...@2x.png
___

Added: svn:mime-type
+image/png
\ No newline at end of property

Modified: trunk/Websites/browserbench.org/resources/main.css (243525 => 243526)

--- trunk/Websites/browserbench.org/resources/main.css	2019-03-26 23:41:42 UTC (rev 243525)
+++ trunk/Websites/browserbench.org/resources/main.css	2019-03-26 23:50:33 UTC (rev 243526)
@@ -91,9 +91,9 @@
 }
 
 .benchmark:hover img {
--moz-filter: invert(100%) brightness(200);
--webkit-filter: invert(100%) brightness(200);
-filter: invert(100%) brightness(200);
+-moz-filter: brightness(0) invert(100%);
+-webkit-filter: brightness(0) invert(100%);
+filter: brightness(0) invert(100%);
 }
 
 .benchmark:hover {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243525] trunk/Source/WebCore

2019-03-26 Thread wenson_hsieh

Title: [243525] trunk/Source/WebCore








Revision 243525
Author wenson_hs...@apple.com
Date 2019-03-26 16:41:42 -0700 (Tue, 26 Mar 2019)


Log Message
[Cocoa] Refactor some helper functions for building UserAgent strings
https://bugs.webkit.org/show_bug.cgi?id=195990

Reviewed by Brent Fulgham.

Add an optional argument to standardUserAgentWithApplicationName to request the desktop version of the user
agent in Cocoa platforms. Work towards refactoring some codepaths to make the implementation of the "Request
Desktop Site" feature in Safari a bit more straightforward.

No change in behavior.

* platform/UserAgent.h:
* platform/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName):

The corresponding macOS version is currently hard-coded — the followup bug webkit.org/b/196275 tracks making
this dynamically fetch the paired macOS version when building for iOS.

* platform/mac/UserAgentMac.mm:
(WebCore::standardUserAgentWithApplicationName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/UserAgent.h
trunk/Source/WebCore/platform/ios/UserAgentIOS.mm
trunk/Source/WebCore/platform/mac/UserAgentMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (243524 => 243525)

--- trunk/Source/WebCore/ChangeLog	2019-03-26 23:29:13 UTC (rev 243524)
+++ trunk/Source/WebCore/ChangeLog	2019-03-26 23:41:42 UTC (rev 243525)
@@ -1,3 +1,26 @@
+2019-03-26  Wenson Hsieh  
+
+[Cocoa] Refactor some helper functions for building UserAgent strings
+https://bugs.webkit.org/show_bug.cgi?id=195990
+
+Reviewed by Brent Fulgham.
+
+Add an optional argument to standardUserAgentWithApplicationName to request the desktop version of the user
+agent in Cocoa platforms. Work towards refactoring some codepaths to make the implementation of the "Request
+Desktop Site" feature in Safari a bit more straightforward.
+
+No change in behavior.
+
+* platform/UserAgent.h:
+* platform/ios/UserAgentIOS.mm:
+(WebCore::standardUserAgentWithApplicationName):
+
+The corresponding macOS version is currently hard-coded — the followup bug webkit.org/b/196275 tracks making
+this dynamically fetch the paired macOS version when building for iOS.
+
+* platform/mac/UserAgentMac.mm:
+(WebCore::standardUserAgentWithApplicationName):
+
 2019-03-26  Said Abou-Hallawa  
 
 Remove the SVG tear off objects for SVGLength, SVGLengthList and SVGAnimatedLengthList


Modified: trunk/Source/WebCore/platform/UserAgent.h (243524 => 243525)

--- trunk/Source/WebCore/platform/UserAgent.h	2019-03-26 23:29:13 UTC (rev 243524)
+++ trunk/Source/WebCore/platform/UserAgent.h	2019-03-26 23:41:42 UTC (rev 243525)
@@ -31,7 +31,8 @@
 namespace WebCore {
 
 #if PLATFORM(COCOA)
-WEBCORE_EXPORT String standardUserAgentWithApplicationName(const String& applicationName);
+enum class UserAgentType { Default, Desktop };
+WEBCORE_EXPORT String standardUserAgentWithApplicationName(const String& applicationName, UserAgentType = UserAgentType::Default);
 
 String systemMarketingVersionForUserAgentString();
 #else


Modified: trunk/Source/WebCore/platform/ios/UserAgentIOS.mm (243524 => 243525)

--- trunk/Source/WebCore/platform/ios/UserAgentIOS.mm	2019-03-26 23:29:13 UTC (rev 243524)
+++ trunk/Source/WebCore/platform/ios/UserAgentIOS.mm	2019-03-26 23:41:42 UTC (rev 243525)
@@ -76,8 +76,13 @@
 return name;
 }
 
-String standardUserAgentWithApplicationName(const String& applicationName)
+String standardUserAgentWithApplicationName(const String& applicationName, UserAgentType type)
 {
+if (type == UserAgentType::Desktop) {
+String appNameSuffix = applicationName.isEmpty() ? "" : makeString(" ", applicationName);
+return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);
+}
+
 // FIXME: Is this needed any more? Mac doesn't have this check,
 // Check to see if there is a user agent override for all WebKit clients.
 CFPropertyListRef override = CFPreferencesCopyAppValue(CFSTR("UserAgent"), CFSTR("com.apple.WebFoundation"));


Modified: trunk/Source/WebCore/platform/mac/UserAgentMac.mm (243524 => 243525)

--- trunk/Source/WebCore/platform/mac/UserAgentMac.mm	2019-03-26 23:29:13 UTC (rev 243524)
+++ trunk/Source/WebCore/platform/mac/UserAgentMac.mm	2019-03-26 23:41:42 UTC (rev 243525)
@@ -32,7 +32,7 @@
 
 namespace WebCore {
 
-String standardUserAgentWithApplicationName(const String& applicationName)
+String standardUserAgentWithApplicationName(const String& applicationName, UserAgentType)
 {
 String osVersion = systemMarketingVersionForUserAgentString();
 String appNameSuffix = applicationName.isEmpty() ? "" : makeString(" ", applicationName);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243524] trunk/Source

2019-03-26 Thread krollin

Title: [243524] trunk/Source








Revision 243524
Author krol...@apple.com
Date 2019-03-26 16:29:13 -0700 (Tue, 26 Mar 2019)


Log Message
Inhibit CFNetwork logging in private sessions
https://bugs.webkit.org/show_bug.cgi?id=196268


Reviewed by Alex Christensen.

Before performing any logging, the NetworkProcess checks to see if
it's performing an operation associated with a private (ephemeral)
browsing session. If so, it skips the logging. However, networking
layers below the NetworkProcess don't know about private browsing, so
they would still perform their own logging. CFNetwork now has a flag
that lets us control that, so set it to False if private browsing.

Source/WebKit:

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):

Source/WTF:

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (243523 => 243524)

--- trunk/Source/WTF/ChangeLog	2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WTF/ChangeLog	2019-03-26 23:29:13 UTC (rev 243524)
@@ -1,3 +1,20 @@
+2019-03-26  Keith Rollin  
+
+Inhibit CFNetwork logging in private sessions
+https://bugs.webkit.org/show_bug.cgi?id=196268
+
+
+Reviewed by Alex Christensen.
+
+Before performing any logging, the NetworkProcess checks to see if
+it's performing an operation associated with a private (ephemeral)
+browsing session. If so, it skips the logging. However, networking
+layers below the NetworkProcess don't know about private browsing, so
+they would still perform their own logging. CFNetwork now has a flag
+that lets us control that, so set it to False if private browsing.
+
+* wtf/Platform.h:
+
 2019-03-25  Alex Christensen  
 
 Expected shouldn't assume its contained types are copyable


Modified: trunk/Source/WTF/wtf/Platform.h (243523 => 243524)

--- trunk/Source/WTF/wtf/Platform.h	2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WTF/wtf/Platform.h	2019-03-26 23:29:13 UTC (rev 243524)
@@ -1525,3 +1525,7 @@
 #if PLATFORM(IOSMAC)
 #define ENABLE_PLATFORM_DRIVEN_TEXT_CHECKING 1
 #endif
+
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 6) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 13)
+#define HAVE_ALLOWS_SENSITIVE_LOGGING 1
+#endif


Modified: trunk/Source/WebKit/ChangeLog (243523 => 243524)

--- trunk/Source/WebKit/ChangeLog	2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WebKit/ChangeLog	2019-03-26 23:29:13 UTC (rev 243524)
@@ -1,3 +1,21 @@
+2019-03-26  Keith Rollin  
+
+Inhibit CFNetwork logging in private sessions
+https://bugs.webkit.org/show_bug.cgi?id=196268
+
+
+Reviewed by Alex Christensen.
+
+Before performing any logging, the NetworkProcess checks to see if
+it's performing an operation associated with a private (ephemeral)
+browsing session. If so, it skips the logging. However, networking
+layers below the NetworkProcess don't know about private browsing, so
+they would still perform their own logging. CFNetwork now has a flag
+that lets us control that, so set it to False if private browsing.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::configurationForSessionID):
+
 2019-03-26  Chris Dumez  
 
 Add basic layout test coverage for File Picker on iOS


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (243523 => 243524)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2019-03-26 23:29:13 UTC (rev 243524)
@@ -800,6 +800,9 @@
 if (session.isEphemeral()) {
 NSURLSessionConfiguration *configuration = [NSURLSessionConfiguration ephemeralSessionConfiguration];
 configuration._shouldSkipPreferredClientCertificateLookup = YES;
+#if HAVE(ALLOWS_SENSITIVE_LOGGING)
+configuration._allowsSensitiveLogging = NO;
+#endif
 return configuration;
 }
 return [NSURLSessionConfiguration defaultSessionConfiguration];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243523] trunk

2019-03-26 Thread cdumez

Title: [243523] trunk








Revision 243523
Author cdu...@apple.com
Date 2019-03-26 16:24:35 -0700 (Tue, 26 Mar 2019)


Log Message
Add basic layout test coverage for File Picker on iOS
https://bugs.webkit.org/show_bug.cgi?id=196265

Reviewed by Wenson Hsieh.

Source/WebKit:

Add layout test infrastructure to test the file picker on iOS.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _dismissFilePicker]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dismissFilePicker]):
(-[WKContentView _contentsOfUserInterfaceItem:]):
* UIProcess/ios/forms/WKFileUploadPanel.h:
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel currentAvailableActionTitles]):

Tools:

Add layout test infrastructure to test the file picker on iOS.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::dismissFilePicker):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::dismissFilePicker):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(overridePresentViewController):
(WTR::TestController::platformInitialize):
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::dismissFilePicker):

LayoutTests:

Add new layout test.

* fast/forms/ios/file-upload-panel-expected.txt: Added.
* fast/forms/ios/file-upload-panel.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h
trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/UIScriptControllerIOS.mm
trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestOptions.h
trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm


Added Paths

trunk/LayoutTests/fast/forms/ios/file-upload-panel-expected.txt
trunk/LayoutTests/fast/forms/ios/file-upload-panel.html




Diff

Modified: trunk/LayoutTests/ChangeLog (243522 => 243523)

--- trunk/LayoutTests/ChangeLog	2019-03-26 22:59:28 UTC (rev 243522)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 23:24:35 UTC (rev 243523)
@@ -1,3 +1,15 @@
+2019-03-26  Chris Dumez  
+
+Add basic layout test coverage for File Picker on iOS
+https://bugs.webkit.org/show_bug.cgi?id=196265
+
+Reviewed by Wenson Hsieh.
+
+Add new layout test.
+
+* fast/forms/ios/file-upload-panel-expected.txt: Added.
+* fast/forms/ios/file-upload-panel.html: Added.
+
 2019-03-26  Shawn Roberts  
 
 Layout tests editing/deleting/delete-emoji-1.html


Added: trunk/LayoutTests/fast/forms/ios/file-upload-panel-expected.txt (0 => 243523)

--- trunk/LayoutTests/fast/forms/ios/file-upload-panel-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/file-upload-panel-expected.txt	2019-03-26 23:24:35 UTC (rev 243523)
@@ -0,0 +1,39 @@
+Basic testing for the File Upload Panel on iOS.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* accept = 
+PASS areArraysEqual(items, ["Photo Library", "Take Photo or Video", "Browse"]) is true
+
+* accept = image/*
+PASS areArraysEqual(items, ["Photo Library", "Take Photo", "Browse"]) is true
+
+* accept = video/*
+PASS areArraysEqual(items, ["Photo Library", "Take Video", "Browse"]) is true
+
+* accept = image/*, video/*
+PASS areArraysEqual(items, ["Photo Library", "Take Photo or Video", "Browse"]) is true
+
+* accept = .PNG, .GIF
+PASS areArraysEqual(items, ["Photo Library", "Take Photo", "Browse"]) is true
+
+* accept = .PNG, .GIF, .MOV
+PASS areArraysEqual(items, ["Photo Library", "Take Photo or Video", "Browse"]) is true
+
+* accept = audio/*
+PASS areArraysEqual(items, ["Browse"]) is true
+
+* accept = .TXT
+PASS areArraysEqual(items, ["Browse"]) is true
+
+* accept = .PDF
+PASS areArraysEqual(items, ["Browse"]) is true
+
+* accept = .PDF, .TXT
+PASS areArraysEqual(items, ["Browse"]) is true
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/ios/file-upload-panel.html (0 => 243523)

--- trunk/LayoutTests/fast/forms/ios

[webkit-changes] [243522] trunk/LayoutTests

2019-03-26 Thread sroberts

Title: [243522] trunk/LayoutTests








Revision 243522
Author srobe...@apple.com
Date 2019-03-26 15:59:28 -0700 (Tue, 26 Mar 2019)


Log Message
Layout tests editing/deleting/delete-emoji-1.html
editing/deleting/delete-emoji-9.html
editing/deleting/delete-emoji.html are failing
webkit.org/b/191709

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations: Updating test expectations waiting for rebaseline

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (243521 => 243522)

--- trunk/LayoutTests/ChangeLog	2019-03-26 22:13:49 UTC (rev 243521)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 22:59:28 UTC (rev 243522)
@@ -1,5 +1,16 @@
 2019-03-26  Shawn Roberts  
 
+Layout tests editing/deleting/delete-emoji-1.html
+editing/deleting/delete-emoji-9.html
+editing/deleting/delete-emoji.html are failing
+webkit.org/b/191709
+
+Unreviewed test gardening.
+
+* platform/ios-simulator-wk2/TestExpectations: Updating test expectations waiting for rebaseline
+
+2019-03-26  Shawn Roberts  
+
 imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is a flaky crash and a failing test
 https://bugs.webkit.org/show_bug.cgi?id=196274
 


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (243521 => 243522)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2019-03-26 22:13:49 UTC (rev 243521)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2019-03-26 22:59:28 UTC (rev 243522)
@@ -57,4 +57,8 @@
 webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html [ Pass Timeout ]
 webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html [ Pass Timeout ]
 webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html [ Pass Timeout ]
-webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-without-link-decoration-from-prevalent-resource.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-without-link-decoration-from-prevalent-resource.html [ Pass Timeout ]
+
+webkit.org/b/191709 editing/deleting/delete-emoji-1.html [ Pass Failure ]
+webkit.org/b/191709 editing/deleting/delete-emoji-9.html [ Pass Failure ]
+webkit.org/b/191709 editing/deleting/delete-emoji.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243521] trunk/LayoutTests

2019-03-26 Thread sroberts

Title: [243521] trunk/LayoutTests








Revision 243521
Author srobe...@apple.com
Date 2019-03-26 15:13:49 -0700 (Tue, 26 Mar 2019)


Log Message
imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is a flaky crash and a failing test
https://bugs.webkit.org/show_bug.cgi?id=196274

Unreviewed test gardening.

* TestExpectations:
* platform/mac/TestExpectations: Updating test expectaion for flaky crash

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (243520 => 243521)

--- trunk/LayoutTests/ChangeLog	2019-03-26 22:08:52 UTC (rev 243520)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 22:13:49 UTC (rev 243521)
@@ -1,5 +1,15 @@
 2019-03-26  Shawn Roberts  
 
+imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is a flaky crash and a failing test
+https://bugs.webkit.org/show_bug.cgi?id=196274
+
+Unreviewed test gardening.
+
+* TestExpectations:
+* platform/mac/TestExpectations: Updating test expectaion for flaky crash
+
+2019-03-26  Shawn Roberts  
+
 Layout tests http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html 
 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html 
 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html 


Modified: trunk/LayoutTests/TestExpectations (243520 => 243521)

--- trunk/LayoutTests/TestExpectations	2019-03-26 22:08:52 UTC (rev 243520)
+++ trunk/LayoutTests/TestExpectations	2019-03-26 22:13:49 UTC (rev 243521)
@@ -788,7 +788,6 @@
 webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ]
 
 imported/w3c/web-platform-tests/fetch/http-cache/partial.html [ Failure Pass ]
-webkit.org/b/159724 imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm [ Failure Pass ]
 
 # Flaky tests due to always changing assertion error message
 imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html [ Failure ]
@@ -3062,3 +3061,5 @@
 imported/w3c/web-platform-tests/css/css-lists/list-with-image-display-changed-001.html [ ImageOnlyFailure ]
 
 [ Debug ] fast/css/first-letter-and-float-crash.html [ Skip ]
+
+webkit.org/b/196274 imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm [ Pass Crash Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac/TestExpectations (243520 => 243521)

--- trunk/LayoutTests/platform/mac/TestExpectations	2019-03-26 22:08:52 UTC (rev 243520)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2019-03-26 22:13:49 UTC (rev 243521)
@@ -1798,3 +1798,5 @@
 
 webkit.org/b/153588 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Skip ]
 webkit.org/b/153588 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Skip ]
+
+webkit.org/b/196274 imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm [ Pass Crash Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243520] trunk/Source/WebKit

2019-03-26 Thread dbates

Title: [243520] trunk/Source/WebKit








Revision 243520
Author dba...@webkit.org
Date 2019-03-26 15:08:52 -0700 (Tue, 26 Mar 2019)


Log Message
[iOS][WK2] Use a better concept to describe the reason we defer zooming a focused element: selectabiltiy
https://bugs.webkit.org/show_bug.cgi?id=196264

Reviewed by Wenson Hsieh.

Rename shouldDeferZoomingToSelectionWhenRevealingFocusedElement() to mayContainSelectableText() to describe
the criterion that we will use to decide whether to defer zooming or not. We defer zooming only for elements
that may support text selection on initial focus because we do not have an up-to-date selection rect at that
time. For element, like , that do not support text selection, we can zoom them immediately when focused.

* UIProcess/ios/WKContentViewInteraction.mm:
(mayContainSelectableText): Renamed from shouldDeferZoomingToSelectionWhenRevealingFocusedElement.
List all the input types in the switch block and remove the default case to force the compiler to check that we
covered all cases. This will prevent unforseen keyboard issues (why isn't the keyboard shown? or why is the keyboard shown?)
for future input types that we may add.
(rectToRevealWhenZoomingToFocusedElement): Update for renaming.
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]): Add a
comment to explain why we may need to defer the zoom: the focused element supports text selection and we need
to wait for the web process to call back to provide an up-to-date selection rect for us to zoom and reveal.
(-[WKContentView _didReceiveEditorStateUpdateAfterFocus]): Update for renaming.
(shouldDeferZoomingToSelectionWhenRevealingFocusedElement): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (243519 => 243520)

--- trunk/Source/WebKit/ChangeLog	2019-03-26 21:15:16 UTC (rev 243519)
+++ trunk/Source/WebKit/ChangeLog	2019-03-26 22:08:52 UTC (rev 243520)
@@ -1,3 +1,27 @@
+2019-03-26  Daniel Bates  
+
+[iOS][WK2] Use a better concept to describe the reason we defer zooming a focused element: selectabiltiy
+https://bugs.webkit.org/show_bug.cgi?id=196264
+
+Reviewed by Wenson Hsieh.
+
+Rename shouldDeferZoomingToSelectionWhenRevealingFocusedElement() to mayContainSelectableText() to describe
+the criterion that we will use to decide whether to defer zooming or not. We defer zooming only for elements
+that may support text selection on initial focus because we do not have an up-to-date selection rect at that
+time. For element, like , that do not support text selection, we can zoom them immediately when focused.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(mayContainSelectableText): Renamed from shouldDeferZoomingToSelectionWhenRevealingFocusedElement.
+List all the input types in the switch block and remove the default case to force the compiler to check that we
+covered all cases. This will prevent unforseen keyboard issues (why isn't the keyboard shown? or why is the keyboard shown?)
+for future input types that we may add.
+(rectToRevealWhenZoomingToFocusedElement): Update for renaming.
+(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]): Add a
+comment to explain why we may need to defer the zoom: the focused element supports text selection and we need
+to wait for the web process to call back to provide an up-to-date selection rect for us to zoom and reveal.
+(-[WKContentView _didReceiveEditorStateUpdateAfterFocus]): Update for renaming.
+(shouldDeferZoomingToSelectionWhenRevealingFocusedElement): Deleted.
+
 2019-03-26  Wenson Hsieh  
 
 Implement async paste method on UIWKInteractionViewProtocol


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (243519 => 243520)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-03-26 21:15:16 UTC (rev 243519)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-03-26 22:08:52 UTC (rev 243520)
@@ -4812,22 +4812,36 @@
 return _focusedElementInformation.selectOptions;
 }
 
-static bool shouldDeferZoomingToSelectionWhenRevealingFocusedElement(WebKit::InputType type)
+// Note that selectability is also affected by the CSS property user-select.
+static bool mayContainSelectableText(WebKit::InputType type)
 {
 switch (type) {
+case WebKit::InputType::None:
+// The following types have custom UI and do not look or behave like a text field.
+#if ENABLE(INPUT_TYPE_COLOR)
+case WebKit::InputType::Color:
+#endif
+case WebKit::InputType::Date:
+case WebKit::InputType::DateTimeLocal:
+case WebKit::InputType::Drawing:
+case WebKit::InputType::Month:
+case WebKit::InputType::Select:
+case WebKit::InputType::Time:
+

[webkit-changes] [243519] trunk

2019-03-26 Thread wenson_hsieh

Title: [243519] trunk








Revision 243519
Author wenson_hs...@apple.com
Date 2019-03-26 14:15:16 -0700 (Tue, 26 Mar 2019)


Log Message
Implement async paste method on UIWKInteractionViewProtocol
https://bugs.webkit.org/show_bug.cgi?id=196267


Reviewed by Tim Horton.

Source/WebKit:

Implement a new UIWKInteractionViewProtocol hook to perform a paste command, and invoke the given completion
handler when pasting is finished.

Test: UIPasteboardTests.PasteWithCompletionHandler

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView pasteWithCompletionHandler:]):

Tools:

Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
-pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
are now a part of all iOS 12 internal SDKs.

* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:

While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).

* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
* TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
(-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
* TestWebKitAPI/ios/UIKitSPI.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm
trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm
trunk/Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (243518 => 243519)

--- trunk/Source/WebKit/ChangeLog	2019-03-26 21:04:53 UTC (rev 243518)
+++ trunk/Source/WebKit/ChangeLog	2019-03-26 21:15:16 UTC (rev 243519)
@@ -1,3 +1,19 @@
+2019-03-26  Wenson Hsieh  
+
+Implement async paste method on UIWKInteractionViewProtocol
+https://bugs.webkit.org/show_bug.cgi?id=196267
+
+
+Reviewed by Tim Horton.
+
+Implement a new UIWKInteractionViewProtocol hook to perform a paste command, and invoke the given completion
+handler when pasting is finished.
+
+Test: UIPasteboardTests.PasteWithCompletionHandler
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView pasteWithCompletionHandler:]):
+
 2019-03-26  Per Arne Vollan  
 
 [macOS] Fix sandbox violations


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (243518 => 243519)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-03-26 21:04:53 UTC (rev 243518)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-03-26 21:15:16 UTC (rev 243519)
@@ -2382,6 +2382,14 @@
 }
 }
 
+- (void)pasteWithCompletionHandler:(void (^)(void))completionHandler
+{
+_page->executeEditCommand("Paste"_s, { }, [completion = makeBlockPtr(completionHandler)] (auto) {
+if (completion)
+completion();
+});
+}
+
 - (void)clearSelection
 {
 [self _elementDidBlur];


Modified: trunk/Tools/ChangeLog (243518 => 243519)

--- trunk/Tools/ChangeLog	2019-03-26 21:04:53 UTC (rev 243518)
+++ trunk/Tools/ChangeLog	2019-03-26 21:15:16 UTC (rev 243519)
@@ -1,3 +1,25 @@
+2019-03-26  Wenson Hsieh  
+
+Implement async paste method on UIWKInteractionViewProtocol
+https://bugs.webkit.org/show_bug.cgi?id=196267
+
+
+Reviewed by Tim Horton.
+
+Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
+-pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
+are now a part of all iOS 12 internal SDKs.
+
+* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
+
+While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
+prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
+
+* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
+* TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
+(-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
+* TestWebKitAPI/ios/UIKitSPI.h:
+
 2019-03-26  Aakash Jain  
 
 [ews-build] Use PostgreSQL for ews.webkit.org database


Modified: trunk/Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm (243518 => 243519)

--- trunk/Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm	2019-03-26 21:04:53 UTC (rev 243518)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm	2019-03-26 21:15:16 UTC (rev 243519)
@@ -38,7 +38,7 @@
 
 typedef void (^DataLoadCompletionBlock)(NSData *, NSError *);
 
-#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300
+#if PLATFORM(IOS)
 
 static void checkJSONWithLogging(NSString *jsonString, NSDictionary *expected)
 {
@@ -48,7 +48,7 @@
 NSLog(@"Expected JSON: %@ to match values: %@", jsonString, expected

[webkit-changes] [243518] trunk/Tools

2019-03-26 Thread aakash_jain

Title: [243518] trunk/Tools








Revision 243518
Author aakash_j...@apple.com
Date 2019-03-26 14:04:53 -0700 (Tue, 26 Mar 2019)


Log Message
[ews-build] Use PostgreSQL for ews.webkit.org database
https://bugs.webkit.org/show_bug.cgi?id=196270

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews-app/settings.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews-app/settings.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews-app/settings.py (243517 => 243518)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews-app/settings.py	2019-03-26 20:42:10 UTC (rev 243517)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews-app/settings.py	2019-03-26 21:04:53 UTC (rev 243518)
@@ -95,12 +95,24 @@
 # Database
 # https://docs.djangoproject.com/en/1.11/ref/settings/#databases
 
-DATABASES = {
-'default': {
-'ENGINE': 'django.db.backends.sqlite3',
-'NAME': os.path.join(BASE_DIR, 'db.sqlite3'),
+is_test_mode_enabled = os.getenv('EWS_PRODUCTION') is None
+if is_test_mode_enabled:
+DATABASES = {
+'default': {
+'ENGINE': 'django.db.backends.sqlite3',
+'NAME': os.path.join(BASE_DIR, 'db.sqlite3'),
+}
 }
-}
+else:
+DATABASES = {
+'default': {
+'ENGINE': 'django.db.backends.postgresql_psycopg2',
+'NAME': os.environ.get('DB_NAME', None),
+'USER': os.environ.get('DB_USERNAME', None),
+'PASSWORD': os.environ.get('DB_PASSWORD', None),
+'HOST': os.environ.get('DB_URL', None),
+}
+}
 
 
 # Password validation


Modified: trunk/Tools/ChangeLog (243517 => 243518)

--- trunk/Tools/ChangeLog	2019-03-26 20:42:10 UTC (rev 243517)
+++ trunk/Tools/ChangeLog	2019-03-26 21:04:53 UTC (rev 243518)
@@ -1,3 +1,12 @@
+2019-03-26  Aakash Jain  
+
+[ews-build] Use PostgreSQL for ews.webkit.org database
+https://bugs.webkit.org/show_bug.cgi?id=196270
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-app/ews-app/settings.py:
+
 2019-03-26  Jonathan Bedard  
 
 [ews] Reset simctl states on reboot






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243517] trunk/LayoutTests

2019-03-26 Thread sroberts

Title: [243517] trunk/LayoutTests








Revision 243517
Author srobe...@apple.com
Date 2019-03-26 13:42:10 -0700 (Tue, 26 Mar 2019)


Log Message
Layout tests http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html
http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html
http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html
http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-without-link-decoration-from-prevalent-resource.html are flaky time outs
https://bugs.webkit.org/show_bug.cgi?id=196269

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations: Updating test expectations for flaky tests
* platform/ios-wk2/TestExpectations: Updatiting test expectations for flaky tests

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (243516 => 243517)

--- trunk/LayoutTests/ChangeLog	2019-03-26 20:41:59 UTC (rev 243516)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 20:42:10 UTC (rev 243517)
@@ -1,3 +1,16 @@
+2019-03-26  Shawn Roberts  
+
+Layout tests http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html 
+http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html 
+http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html 
+http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-without-link-decoration-from-prevalent-resource.html are flaky time outs
+https://bugs.webkit.org/show_bug.cgi?id=196269
+
+Unreviewed test gardening.
+
+* platform/ios-simulator-wk2/TestExpectations: Updating test expectations for flaky tests
+* platform/ios-wk2/TestExpectations: Updatiting test expectations for flaky tests
+
 2019-03-26  Said Abou-Hallawa  
 
 Remove the SVG tear off objects for SVGLength, SVGLengthList and SVGAnimatedLengthList


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (243516 => 243517)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2019-03-26 20:41:59 UTC (rev 243516)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2019-03-26 20:42:10 UTC (rev 243517)
@@ -52,4 +52,9 @@
 
 webkit.org/b/196233 fast/viewport/ios/initial-scale-after-changing-view-scale.html [ Pass Timeout ]
 
-webkit.org/b/196236 [ Debug ] fast/visual-viewport/ios/min-scale-greater-than-one.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/196236 [ Debug ] fast/visual-viewport/ios/min-scale-greater-than-one.html [ Pass Failure ]
+
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html [ Pass Timeout ]
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html [ Pass Timeout ]
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html [ Pass Timeout ]
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-without-link-decoration-from-prevalent-resource.html [ Pass Timeout ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (243516 => 243517)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2019-03-26 20:41:59 UTC (rev 243516)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2019-03-26 20:42:10 UTC (rev 243517)
@@ -1316,3 +1316,8 @@
 webkit.org/b/196013 fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html [ ImageOnlyFailure ]
 webkit.org/b/196013 fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html [ ImageOnlyFailure ]
 webkit.org/b/196013 fast/scrolling/rubber-band-shows-background.html [ ImageOnlyFailure ]
+
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html [ Pass Timeout ]
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html [ Pass Timeout ]
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html [ Pass Timeout ]
+webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-without-link-decoration-from-prevalent-resource.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.w

[webkit-changes] [243516] trunk/Tools

2019-03-26 Thread jbedard

Title: [243516] trunk/Tools








Revision 243516
Author jbed...@apple.com
Date 2019-03-26 13:41:59 -0700 (Tue, 26 Mar 2019)


Log Message
[ews] Reset simctl states on reboot
https://bugs.webkit.org/show_bug.cgi?id=196260

Rubber-stamped by Aakash Jain.

* EWSTools/start-queue-mac.sh:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/start-queue-mac.sh




Diff

Modified: trunk/Tools/ChangeLog (243515 => 243516)

--- trunk/Tools/ChangeLog	2019-03-26 20:14:32 UTC (rev 243515)
+++ trunk/Tools/ChangeLog	2019-03-26 20:41:59 UTC (rev 243516)
@@ -1,3 +1,12 @@
+2019-03-26  Jonathan Bedard  
+
+[ews] Reset simctl states on reboot
+https://bugs.webkit.org/show_bug.cgi?id=196260
+
+Rubber-stamped by Aakash Jain.
+
+* EWSTools/start-queue-mac.sh:
+
 2019-03-26  Aakash Jain  
 
 [ews-build] Use PostgreSQL for ews-build database


Modified: trunk/Tools/EWSTools/start-queue-mac.sh (243515 => 243516)

--- trunk/Tools/EWSTools/start-queue-mac.sh	2019-03-26 20:14:32 UTC (rev 243515)
+++ trunk/Tools/EWSTools/start-queue-mac.sh	2019-03-26 20:41:59 UTC (rev 243516)
@@ -61,6 +61,12 @@
 mv -f $QUEUE_NAME.log ${QUEUE_NAME}_$(date +%Y-%m-%d_%H-%m).log
 fi
 fi
+
+# Fix-up rotten Simulator state
+/bin/rm -rf ~/Library/Developer/CoreSimulator/Devices/*
+/usr/bin/sudo /usr/bin/killall -9 com.apple.CoreSimulator.CoreSimulatorServer
+/usr/bin/xcrun simctl delete unavailable
+
 cd $WEBKIT_HOME
 
 # Delete WebKitBuild to force a clean build






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243513] trunk

2019-03-26 Thread simon . fraser

Title: [243513] trunk








Revision 243513
Author simon.fra...@apple.com
Date 2019-03-26 12:23:52 -0700 (Tue, 26 Mar 2019)


Log Message
[iOS WK2] position:fixed inside oveflow:scroll is jumpy
https://bugs.webkit.org/show_bug.cgi?id=196238

Reviewed by Antti Koivisto.
Source/WebCore:

We were inadvertently making Positioned nodes for position:fixed, which is unnecessary because
Fixed nodes handle them, and harmful because they introduced unwanted layer movement.

Tests: scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree.html
   scrollingcoordinator/ios/fixed-in-overflow-scroll.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCoordinatedPositioningForLayer const):

LayoutTests:

fixed-in-overflow-scroll-scrolling-tree.html actually tests the fix.
For some reason fixed-in-overflow-scroll.html doesn't show the jumpiness, but it's
a good test to have nonetheless.

Other minor cleanup.

* resources/ui-helper.js:
(window.UIHelper.immediateScrollElementAtContentPointToOffset):
* scrollingcoordinator/ios/fixed-in-overflow-scroll-expected.html: Added.
* scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt: Added.
* scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree.html: Copied from LayoutTests/scrollingcoordinator/ios/ui-scrolling-tree.html.
* scrollingcoordinator/ios/fixed-in-overflow-scroll.html: Added.
* scrollingcoordinator/ios/ui-scrolling-tree.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/resources/ui-helper.js
trunk/LayoutTests/scrollingcoordinator/ios/ui-scrolling-tree.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp


Added Paths

trunk/LayoutTests/scrollingcoordinator/ios/fixed-in-overflow-scroll-expected.html
trunk/LayoutTests/scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt
trunk/LayoutTests/scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree.html
trunk/LayoutTests/scrollingcoordinator/ios/fixed-in-overflow-scroll.html




Diff

Modified: trunk/LayoutTests/ChangeLog (243512 => 243513)

--- trunk/LayoutTests/ChangeLog	2019-03-26 19:18:46 UTC (rev 243512)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 19:23:52 UTC (rev 243513)
@@ -1,3 +1,24 @@
+2019-03-26  Simon Fraser  
+
+[iOS WK2] position:fixed inside oveflow:scroll is jumpy
+https://bugs.webkit.org/show_bug.cgi?id=196238
+
+Reviewed by Antti Koivisto.
+
+fixed-in-overflow-scroll-scrolling-tree.html actually tests the fix.
+For some reason fixed-in-overflow-scroll.html doesn't show the jumpiness, but it's
+a good test to have nonetheless.
+
+Other minor cleanup.
+
+* resources/ui-helper.js:
+(window.UIHelper.immediateScrollElementAtContentPointToOffset):
+* scrollingcoordinator/ios/fixed-in-overflow-scroll-expected.html: Added.
+* scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt: Added.
+* scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree.html: Copied from LayoutTests/scrollingcoordinator/ios/ui-scrolling-tree.html.
+* scrollingcoordinator/ios/fixed-in-overflow-scroll.html: Added.
+* scrollingcoordinator/ios/ui-scrolling-tree.html:
+
 2019-03-26  Andy VanWagoner  
 
 Intl.DateTimeFormat should obey 2-digit hour


Modified: trunk/LayoutTests/resources/ui-helper.js (243512 => 243513)

--- trunk/LayoutTests/resources/ui-helper.js	2019-03-26 19:18:46 UTC (rev 243512)
+++ trunk/LayoutTests/resources/ui-helper.js	2019-03-26 19:23:52 UTC (rev 243513)
@@ -286,7 +286,7 @@
 });
 }
 
-static immediateScrollElementAtContentPointToOffset(x, y, scrollX, scrollY)
+static immediateScrollElementAtContentPointToOffset(x, y, scrollX, scrollY, scrollUpdatesDisabled = false)
 {
 if (!this.isWebKit2())
 return Promise.resolve();
@@ -293,6 +293,7 @@
 
 return new Promise(resolve => {
 testRunner.runUIScript(`
+uiController.scrollUpdatesDisabled = ${scrollUpdatesDisabled};
 uiController.immediateScrollElementAtContentPointToOffset(${x}, ${y}, ${scrollX}, ${scrollY});`, resolve);
 });
 }


Added: trunk/LayoutTests/scrollingcoordinator/ios/fixed-in-overflow-scroll-expected.html (0 => 243513)

--- trunk/LayoutTests/scrollingcoordinator/ios/fixed-in-overflow-scroll-expected.html	(rev 0)
+++ trunk/LayoutTests/scrollingcoordinator/ios/fixed-in-overflow-scroll-expected.html	2019-03-26 19:23:52 UTC (rev 243513)
@@ -0,0 +1,50 @@
+ 
+
+
+
+
+#scroller {
+margin: 10px;
+height: 300px;
+width: 300px;
+border: 1px solid black;
+overflow: scroll;
+}
+
+.box {
+position: fixed;
+margin-top: 200px;
+width: 200px;
+height: 200px;
+background-colo

[webkit-changes] [243512] trunk

2019-03-26 Thread andy

Title: [243512] trunk








Revision 243512
Author andy@vanwagoner.family
Date 2019-03-26 12:18:46 -0700 (Tue, 26 Mar 2019)


Log Message
Intl.DateTimeFormat should obey 2-digit hour
https://bugs.webkit.org/show_bug.cgi?id=195974

Reviewed by Keith Miller.

Source/_javascript_Core:

* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):

LayoutTests:

* js/intl-datetimeformat-expected.txt:
* js/script-tests/intl-datetimeformat.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/intl-datetimeformat-expected.txt
trunk/LayoutTests/js/script-tests/intl-datetimeformat.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (243511 => 243512)

--- trunk/LayoutTests/ChangeLog	2019-03-26 19:15:56 UTC (rev 243511)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 19:18:46 UTC (rev 243512)
@@ -1,3 +1,13 @@
+2019-03-26  Andy VanWagoner  
+
+Intl.DateTimeFormat should obey 2-digit hour
+https://bugs.webkit.org/show_bug.cgi?id=195974
+
+Reviewed by Keith Miller.
+
+* js/intl-datetimeformat-expected.txt:
+* js/script-tests/intl-datetimeformat.js:
+
 2019-03-26  Dean Jackson  
 
 vertexAttribPointer must restrict offset parameter


Modified: trunk/LayoutTests/js/intl-datetimeformat-expected.txt (243511 => 243512)

--- trunk/LayoutTests/js/intl-datetimeformat-expected.txt	2019-03-26 19:15:56 UTC (rev 243511)
+++ trunk/LayoutTests/js/intl-datetimeformat-expected.txt	2019-03-26 19:18:46 UTC (rev 243512)
@@ -310,7 +310,7 @@
 PASS Intl.DateTimeFormat('en', { hour: { toString() { throw 'hour' } } }) threw exception hour.
 PASS Intl.DateTimeFormat('en', { hour:[] }) threw exception RangeError: hour must be "2-digit" or "numeric".
 PASS Intl.DateTimeFormat('en').resolvedOptions().hour is undefined
-PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'2-digit' }).resolvedOptions().hour is 'numeric'
+PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'2-digit' }).resolvedOptions().hour is '2-digit'
 PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'2-digit', timeZone: 'UTC' }).format(0) is '12:00 AM'
 PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric' }).resolvedOptions().hour is 'numeric'
 PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZone: 'UTC' }).format(0) is '12:00 AM'
@@ -320,7 +320,9 @@
 PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZone: 'UTC' }).format(0) is '12:00 AM'
 PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric' }).resolvedOptions().hourCycle is 'h23'
 PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric' }).resolvedOptions().hour12 is false
-PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZone: 'UTC' }).format(0) is '00:00'
+PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZone: 'UTC' }).format(0) is '0:00'
+PASS Intl.DateTimeFormat('ru', { minute:'2-digit', hour:'2-digit', hour12: false, timeZone: 'UTC' }).format(0) is '00:00'
+PASS Intl.DateTimeFormat('ru', { minute:'2-digit', hour:'2-digit', hour12: true, timeZone: 'UTC' }).format(1e7) is '02:46 ДП'
 PASS Intl.DateTimeFormat('en', { minute: { toString() { throw 'minute' } } }) threw exception minute.
 PASS Intl.DateTimeFormat('en', { minute:null }) threw exception RangeError: minute must be "2-digit" or "numeric".
 PASS Intl.DateTimeFormat('en').resolvedOptions().minute is undefined


Modified: trunk/LayoutTests/js/script-tests/intl-datetimeformat.js (243511 => 243512)

--- trunk/LayoutTests/js/script-tests/intl-datetimeformat.js	2019-03-26 19:15:56 UTC (rev 243511)
+++ trunk/LayoutTests/js/script-tests/intl-datetimeformat.js	2019-03-26 19:18:46 UTC (rev 243512)
@@ -423,7 +423,7 @@
 shouldThrow("Intl.DateTimeFormat('en', { hour: { toString() { throw 'hour' } } })", "'hour'");
 shouldThrow("Intl.DateTimeFormat('en', { hour:[] })", '\'RangeError: hour must be "2-digit" or "numeric"\'');
 shouldBe("Intl.DateTimeFormat('en').resolvedOptions().hour", "undefined");
-shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'2-digit' }).resolvedOptions().hour", "'numeric'");
+shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'2-digit' }).resolvedOptions().hour", "'2-digit'");
 shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'2-digit', timeZone: 'UTC' }).format(0)", "'12:00 AM'");
 shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric' }).resolvedOptions().hour", "'numeric'");
 shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZone: 'UTC' }).format(0)", "'12:00 AM'");
@@ -434,7 +434,9 @@
 shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZone: 'UTC' }).format(0)", "'12:00 AM'");
 shouldBe("Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric' }).resolvedOptions().hourCycle", "'h23'");
 shouldBe("Intl.DateTimeFormat('p

[webkit-changes] [243511] trunk/Source/WebKit

2019-03-26 Thread pvollan

Title: [243511] trunk/Source/WebKit








Revision 243511
Author pvol...@apple.com
Date 2019-03-26 12:15:56 -0700 (Tue, 26 Mar 2019)


Log Message
[macOS] Fix sandbox violations
https://bugs.webkit.org/show_bug.cgi?id=196262


Reviewed by Brent Fulgham.

Fix various observed sandbox violations.

* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (243510 => 243511)

--- trunk/Source/WebKit/ChangeLog	2019-03-26 19:04:37 UTC (rev 243510)
+++ trunk/Source/WebKit/ChangeLog	2019-03-26 19:15:56 UTC (rev 243511)
@@ -1,3 +1,16 @@
+2019-03-26  Per Arne Vollan  
+
+[macOS] Fix sandbox violations
+https://bugs.webkit.org/show_bug.cgi?id=196262
+
+
+Reviewed by Brent Fulgham.
+
+Fix various observed sandbox violations.
+
+* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2019-03-26  Tomoki Imai  
 
 Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyCoordinatedGraphics::incorporateUpdate when forceCompositingMode is turned on


Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (243510 => 243511)

--- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2019-03-26 19:04:37 UTC (rev 243510)
+++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2019-03-26 19:15:56 UTC (rev 243511)
@@ -238,7 +238,7 @@
 (allow file-read*
 (literal "/private/etc/krb5.conf")
 (literal "/private/etc/services")
-(literal "/private/etc/host")
+(literal "/private/etc/hosts")
 (subpath "/Library/KerberosPlugins/GSSAPI")
 (subpath "/Library/KerberosPlugins/KerberosFrameworkPlugins"))
 


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (243510 => 243511)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-03-26 19:04:37 UTC (rev 243510)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-03-26 19:15:56 UTC (rev 243511)
@@ -164,6 +164,7 @@
 "hw.model"
 "hw.ncpu"
 "hw.vectorunit"
+"kern.bootargs" ;; 
 "kern.hostname"
 "kern.maxfilesperproc"
 "kern.memorystatus_level"
@@ -183,6 +184,7 @@
 
 (deny iokit-get-properties)
 (allow iokit-get-properties
+(iokit-property "AAPL,LCD-PowerState-ON") ;; 
 (iokit-property "AGCInfo")
 (iokit-property-regex #"^Accel(Caps|NativeDMARowByteAlignment)")
 (iokit-property-regex #"^(Accurate|Extended)MaxDigitizerPressureValue")
@@ -198,6 +200,7 @@
 (iokit-property "BlockSize")
 (iokit-property-regex #"^CEA(ModeID|PixelRepetition)")
 (iokit-property "CFBundleIdentifier")
+(iokit-property "CFBundleIdentifierKernel") ;; 
 (iokit-property "CapsLockDelay")
 (iokit-property "CaseSensitive")
 (iokit-property "ConfigState")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243510] trunk/Websites/perf.webkit.org

2019-03-26 Thread dewei_zhu

Title: [243510] trunk/Websites/perf.webkit.org








Revision 243510
Author dewei_...@apple.com
Date 2019-03-26 12:04:37 -0700 (Tue, 26 Mar 2019)


Log Message
Primary cluster of measurement set should always contain latest point.
https://bugs.webkit.org/show_bug.cgi?id=196243

Reviewed by Ryosuke Niwa.

Fix a bug in measurement-set api that primary cluster may not contain latest data point as
'carry_over' row may not be updated.

* public/api/measurement-set.php: Should always keep 'carry_over' data points up to date.
* server-tests/api-measurement-set-tests.js: Added an unit test for this change.
Fixed a typo.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/api/measurement-set.php
trunk/Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (243509 => 243510)

--- trunk/Websites/perf.webkit.org/ChangeLog	2019-03-26 18:20:22 UTC (rev 243509)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2019-03-26 19:04:37 UTC (rev 243510)
@@ -1,3 +1,17 @@
+2019-03-25  Dewei Zhu  
+
+Primary cluster of measurement set should always contain latest point.
+https://bugs.webkit.org/show_bug.cgi?id=196243
+
+Reviewed by Ryosuke Niwa.
+
+Fix a bug in measurement-set api that primary cluster may not contain latest data point as
+'carry_over' row may not be updated.
+
+* public/api/measurement-set.php: Should always keep 'carry_over' data points up to date.
+* server-tests/api-measurement-set-tests.js: Added an unit test for this change.
+Fixed a typo.
+
 2019-03-21  Dewei Zhu  
 
 'custom-configuration-test-group-form' should update test name when selected test or platform changes.


Modified: trunk/Websites/perf.webkit.org/public/api/measurement-set.php (243509 => 243510)

--- trunk/Websites/perf.webkit.org/public/api/measurement-set.php	2019-03-26 18:20:22 UTC (rev 243509)
+++ trunk/Websites/perf.webkit.org/public/api/measurement-set.php	2019-03-26 19:04:37 UTC (rev 243510)
@@ -153,9 +153,7 @@
 $reached_end = !$row;
 if ($reached_end)
 $this->queries[$name] = NULL;
-else {
-$this->next_cluster_results[$name] = array_slice($results_by_config[$name], -2);
-}
+$this->next_cluster_results[$name] = array_slice($results_by_config[$name], -2);
 }
 
 return array(


Modified: trunk/Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js (243509 => 243510)

--- trunk/Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js	2019-03-26 18:20:22 UTC (rev 243509)
+++ trunk/Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js	2019-03-26 19:04:37 UTC (rev 243510)
@@ -107,7 +107,7 @@
 },
 }}];
 
-const reportWithAncentRevision = [{
+const reportWithAncientRevision = [{
 "buildNumber": "126",
 "buildTime": "2013-02-28T23:07:25Z",
 "revisions": {
@@ -129,6 +129,116 @@
 },
 }}];
 
+const secondReportWithRevision = [{
+"buildNumber": "127",
+"buildTime": "2013-02-28T23:07:25Z",
+"revisions": {
+"WebKit": {
+"revision": "137794",
+"timestamp": clusterTime(11.1).toISOString()
+},
+},
+"builderName": "someBuilder",
+"builderPassword": "somePassword",
+"platform": "Mountain Lion",
+"tests": {
+"Suite": {
+"tests": {
+"test1": {
+"metrics": {"Time": { "current": [21, 22, 23, 24, 25] }}
+}
+}
+},
+}}];
+
+const thirdReportWithRevision = [{
+"buildNumber": "128",
+"buildTime": "2013-02-28T23:07:25Z",
+"revisions": {
+"WebKit": {
+"revision": "137795",
+"timestamp": clusterTime(11.2).toISOString()
+},
+},
+"builderName": "someBuilder",
+"builderPassword": "somePassword",
+"platform": "Mountain Lion",
+"tests": {
+"Suite": {
+"tests": {
+"test1": {
+"metrics": {"Time": { "current": [21, 22, 23, 24, 25] }}
+}
+}
+},
+}}];
+
+const reportBaselineWithRevision = [{
+"buildNumber": "129",
+"buildTime": "2013-02-28T15:35:51Z",
+"revisions": {
+"WebKit": {
+"revision": "144001",
+"timestamp": clusterTime(13.35645364537).toISOString(),
+},
+},
+"builderName": "someBuilder",
+"builderPassword": "somePassword",
+"platform": "Mountain Lion",
+"tests": {
+"Suite": {
+"tests": {
+"test1": {
+

[webkit-changes] [243509] trunk/Tools

2019-03-26 Thread aakash_jain

Title: [243509] trunk/Tools








Revision 243509
Author aakash_j...@apple.com
Date 2019-03-26 11:20:22 -0700 (Tue, 26 Mar 2019)


Log Message
[ews-build] Use PostgreSQL for ews-build database
https://bugs.webkit.org/show_bug.cgi?id=196229

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/master.cfg:

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-build/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/master.cfg (243508 => 243509)

--- trunk/Tools/BuildSlaveSupport/ews-build/master.cfg	2019-03-26 18:13:37 UTC (rev 243508)
+++ trunk/Tools/BuildSlaveSupport/ews-build/master.cfg	2019-03-26 18:20:22 UTC (rev 243509)
@@ -20,10 +20,23 @@
 
 c['projectName'] = 'WebKit EWS'
 c['projectURL'] = 'https://ews-build.webkit.org/'
-c['buildbotURL'] = 'https://ews-build.webkit.org/'
 
+if is_test_mode_enabled:
+c['buildbotURL'] = 'http://localhost:8010/'
+c['db_url'] = 'sqlite:///state.sqlite?serialize_access=1'
+else:
+c['buildbotURL'] = 'https://ews-build.webkit.org/'
+db_url = os.getenv('DB_URL', None)
+db_name = os.getenv('DB_NAME', None)
+db_username = os.getenv('DB_USERNAME', None)
+db_password = os.getenv('DB_PASSWORD', None)
+if None in [db_url, db_name, db_username, db_password]:
+print('Environment variables for DB not found. Please ensure these variables are set.')
+sys.exit(1)
+# See https://docs.buildbot.net/1.7.0/manual/configuration/global.html#database-specification
+c['db_url'] = 'postgresql://{}:{}@{}/{}'.format(db_username, db_password, db_url, db_name)
+
 c['logCompressionMethod'] = 'lz4'
-
 c['buildbotNetUsageData'] = None
 
 loadConfig.loadBuilderConfig(c, is_test_mode_enabled=is_test_mode_enabled)


Modified: trunk/Tools/ChangeLog (243508 => 243509)

--- trunk/Tools/ChangeLog	2019-03-26 18:13:37 UTC (rev 243508)
+++ trunk/Tools/ChangeLog	2019-03-26 18:20:22 UTC (rev 243509)
@@ -1,5 +1,14 @@
 2019-03-26  Aakash Jain  
 
+[ews-build] Use PostgreSQL for ews-build database
+https://bugs.webkit.org/show_bug.cgi?id=196229
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-build/master.cfg:
+
+2019-03-26  Aakash Jain  
+
 [ews-build] Get master_hostname dynamically in master.cfg
 https://bugs.webkit.org/show_bug.cgi?id=196255
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243508] trunk/Tools

2019-03-26 Thread aakash_jain

Title: [243508] trunk/Tools








Revision 243508
Author aakash_j...@apple.com
Date 2019-03-26 11:13:37 -0700 (Tue, 26 Mar 2019)


Log Message
[ews-build] Get master_hostname dynamically in master.cfg
https://bugs.webkit.org/show_bug.cgi?id=196255

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
send events data in test mode.

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-build/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/master.cfg (243507 => 243508)

--- trunk/Tools/BuildSlaveSupport/ews-build/master.cfg	2019-03-26 18:12:37 UTC (rev 243507)
+++ trunk/Tools/BuildSlaveSupport/ews-build/master.cfg	2019-03-26 18:13:37 UTC (rev 243508)
@@ -1,4 +1,5 @@
 import os
+import socket
 
 import loadConfig
 from events import Events
@@ -27,5 +28,7 @@
 
 loadConfig.loadBuilderConfig(c, is_test_mode_enabled=is_test_mode_enabled)
 
-event_reporter = Events(master_hostname='ews-build.webkit.org', type_prefix='ews')
-c['services'] = [event_reporter]
+if not is_test_mode_enabled:
+hostname =  socket.gethostname().strip()
+event_reporter = Events(master_hostname=hostname, type_prefix='ews')
+c['services'] = [event_reporter]


Modified: trunk/Tools/ChangeLog (243507 => 243508)

--- trunk/Tools/ChangeLog	2019-03-26 18:12:37 UTC (rev 243507)
+++ trunk/Tools/ChangeLog	2019-03-26 18:13:37 UTC (rev 243508)
@@ -1,5 +1,15 @@
 2019-03-26  Aakash Jain  
 
+[ews-build] Get master_hostname dynamically in master.cfg
+https://bugs.webkit.org/show_bug.cgi?id=196255
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
+send events data in test mode.
+
+2019-03-26  Aakash Jain  
+
 [ews-app] Set db_constraint to False for Foreign Keys
 https://bugs.webkit.org/show_bug.cgi?id=196252
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243507] trunk/Source/WebInspectorUI

2019-03-26 Thread drousso

Title: [243507] trunk/Source/WebInspectorUI








Revision 243507
Author drou...@apple.com
Date 2019-03-26 11:12:37 -0700 (Tue, 26 Mar 2019)


Log Message
Web Inspector: Sources: fix typo in CSS selector to always show add breakpoint button
https://bugs.webkit.org/show_bug.cgi?id=196241

Reviewed by Matt Baker.

* UserInterface/Views/SourcesNavigationSidebarPanel.css:
(.sidebar > .panel.navigation.sources > .content > .details-section:matches(.paused-reason, .breakpoints).collapsed > .header > .options,):
(.sidebar > .panel.navigation.sources > .content > .details-section:matches(.paused-reason, .breakpoins).collapsed > .header > .options,): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (243506 => 243507)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-03-26 18:00:55 UTC (rev 243506)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-03-26 18:12:37 UTC (rev 243507)
@@ -1,3 +1,14 @@
+2019-03-26  Devin Rousso  
+
+Web Inspector: Sources: fix typo in CSS selector to always show add breakpoint button
+https://bugs.webkit.org/show_bug.cgi?id=196241
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/SourcesNavigationSidebarPanel.css:
+(.sidebar > .panel.navigation.sources > .content > .details-section:matches(.paused-reason, .breakpoints).collapsed > .header > .options,):
+(.sidebar > .panel.navigation.sources > .content > .details-section:matches(.paused-reason, .breakpoins).collapsed > .header > .options,): Deleted.
+
 2019-03-25  Joseph Pecoraro  
 
 Web Inspector: Page Weight indicator clears on pages with zero length resources (macrumors.com)


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css (243506 => 243507)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css	2019-03-26 18:00:55 UTC (rev 243506)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css	2019-03-26 18:12:37 UTC (rev 243507)
@@ -72,7 +72,7 @@
 border-bottom-width: 1px !important;
 }
 
-.sidebar > .panel.navigation.sources > .content > .details-section:matches(.paused-reason, .breakpoins).collapsed > .header > .options,
+.sidebar > .panel.navigation.sources > .content > .details-section:matches(.paused-reason, .breakpoints).collapsed > .header > .options,
 .sidebar > .panel.navigation.sources > .content > .details-section > .content,
 .sidebar > .panel.navigation.sources > .content > .details-section > .content > .group {
 display: block;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243506] trunk

2019-03-26 Thread dino

Title: [243506] trunk








Revision 243506
Author d...@apple.com
Date 2019-03-26 11:00:55 -0700 (Tue, 26 Mar 2019)


Log Message
vertexAttribPointer must restrict offset parameter
https://bugs.webkit.org/show_bug.cgi?id=196261


Reviewed by Antoine Quint.

Source/WebCore:

This WebGL function should fail if the offset parameter is
not within [0, max 32-bit int].

Test: fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::vertexAttribPointer):

LayoutTests:

Add a test where the offset parameter is out of bounds.

* fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt: Added.
* fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp


Added Paths

trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt
trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html




Diff

Modified: trunk/LayoutTests/ChangeLog (243505 => 243506)

--- trunk/LayoutTests/ChangeLog	2019-03-26 17:57:58 UTC (rev 243505)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 18:00:55 UTC (rev 243506)
@@ -1,3 +1,16 @@
+2019-03-26  Dean Jackson  
+
+vertexAttribPointer must restrict offset parameter
+https://bugs.webkit.org/show_bug.cgi?id=196261
+
+
+Reviewed by Antoine Quint.
+
+Add a test where the offset parameter is out of bounds.
+
+* fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt: Added.
+* fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html: Added.
+
 2019-03-26  Zalan Bujtas  
 
 [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"


Added: trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt (0 => 243506)

--- trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt	2019-03-26 18:00:55 UTC (rev 243506)
@@ -0,0 +1,4 @@
+CONSOLE MESSAGE: line 49: WebGL: INVALID_VALUE: vertexAttribPointer: bad offset
+CONSOLE MESSAGE: line 56: WebGL: INVALID_OPERATION: drawArrays: attempt to access out of bounds arrays
+PASS: vertexAttribPointer should have an error.
+
Property changes on: trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt
___


Added: svn:eol-style
+native
\ No newline at end of property

Added: svn:keywords
+Date Revision
\ No newline at end of property

Added: svn:mime-type
+text/plain
\ No newline at end of property

Added: trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html (0 => 243506)

--- trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html	2019-03-26 18:00:55 UTC (rev 243506)
@@ -0,0 +1,59 @@
+
+
+
+attribute vec4 a1;
+void main () {
+gl_Position = a1;
+}
+
+
+
+#ifdef GL_ES
+precision highp float;
+#endif
+void main() {
+gl_FragColor = vec4(1.0, 1.0, 1.0, 1.0);
+}
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+const canvas = document.getElementById("canvas");
+const gl = canvas.getContext("webgl");
+
+const vShader = gl.createShader(gl.VERTEX_SHADER);
+gl.shaderSource(vShader, document.getElementById("vshader").text);
+gl.compileShader(vShader);
+
+const fShader = gl.createShader(gl.FRAGMENT_SHADER);
+gl.shaderSource(fShader, document.getElementById("fshader").text);
+gl.compileShader(fShader);
+
+const program = gl.createProgram();
+gl.attachShader(program, vShader);
+gl.attachShader(program, fShader);
+gl.linkProgram(program);
+gl.useProgram(program);
+
+const attribute = gl.getAttribLocation(program, "a1");
+gl.enableVertexAttribArray(attribute);
+
+const b1 = gl.createBuffer();
+gl.bindBuffer(gl.ARRAY_BUFFER, b1);
+
+gl.vertexAttribPointer(attribute, 1, gl.BYTE, true, 1, 0x00);
+document.getElementById("results").textContent = `${gl.getError() == gl.NO_ERROR ? "FAIL" : "PASS"}: vertexAttribPointer should have an error.`;
+
+const b2 = gl.createBuffer();
+gl.bindBuffer(gl.ARRAY_BUFFER, b2);
+gl.bufferData(gl.ARRAY_BUFFER, new Uint16Array(100), gl.DYNAMIC_DRAW);
+
+gl.drawArrays(gl.LINES, 100, 100);
+
+
+
Property changes on: trunk/LayoutTests/fast/canvas/webgl/vertexAttribPointer-with-bad-offset.html
___


Added: svn:eol-style
+native
\ No newline at end of property

Added: svn:keywords
+Date Revision
\ No newline at end of property

Added: svn:mime-type
+text/html
\ No newline at end of property

Modified: trunk/Source/WebCore/ChangeLog (243505 => 243506)

--- trunk

[webkit-changes] [243505] trunk/Source/WebKit

2019-03-26 Thread commit-queue

Title: [243505] trunk/Source/WebKit








Revision 243505
Author commit-qu...@webkit.org
Date 2019-03-26 10:57:58 -0700 (Tue, 26 Mar 2019)


Log Message
Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyCoordinatedGraphics::incorporateUpdate when forceCompositingMode is turned on
https://bugs.webkit.org/show_bug.cgi?id=195879

Patch by Tomoki Imai  on 2019-03-26
Reviewed by Carlos Garcia Campos.

The root cause is that DrawingAreaProxyCoordinatedGraphics::isInAcceleratedCompositingMode checks both of alwaysUseCompositing() and !m_layerTreeContext.isEmpty().
alwaysUseCompositing() refers preferences, which is written by the application (UIProcess).
On the other hand, m_layerTreeContext is changed when it receives enterAcceleratedCompositingMode/exitAcceleratedCompositingMode from WebProcess.

It results when we set forceCompositingMode and acceleratedCompositingEnabled to true, WebProcess and UIProcess is out of sync until WebProcess sends enterAcceleratedCompositingMode message.
In such situation, WebProcess sends incorporateUpdate to UIProcess because WebProcess is in non-AC mode, but isInAcceleratedCompositingMode becomes true in UIProcess side.

* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::~DrawingAreaProxyCoordinatedGraphics): Should call exitAcceleratedCompositingMode even when alwaysUseCompositing is true.
(WebKit::DrawingAreaProxyCoordinatedGraphics::enterAcceleratedCompositingMode): enterAcceleratedCompositingMode should check enterAcceleratedCompositingMode is not called twice.
* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h: Remove alwaysUseCompositing from isInAcceleratedCompositingMode

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (243504 => 243505)

--- trunk/Source/WebKit/ChangeLog	2019-03-26 17:29:54 UTC (rev 243504)
+++ trunk/Source/WebKit/ChangeLog	2019-03-26 17:57:58 UTC (rev 243505)
@@ -1,3 +1,22 @@
+2019-03-26  Tomoki Imai  
+
+Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyCoordinatedGraphics::incorporateUpdate when forceCompositingMode is turned on
+https://bugs.webkit.org/show_bug.cgi?id=195879
+
+Reviewed by Carlos Garcia Campos.
+
+The root cause is that DrawingAreaProxyCoordinatedGraphics::isInAcceleratedCompositingMode checks both of alwaysUseCompositing() and !m_layerTreeContext.isEmpty().
+alwaysUseCompositing() refers preferences, which is written by the application (UIProcess).
+On the other hand, m_layerTreeContext is changed when it receives enterAcceleratedCompositingMode/exitAcceleratedCompositingMode from WebProcess.
+
+It results when we set forceCompositingMode and acceleratedCompositingEnabled to true, WebProcess and UIProcess is out of sync until WebProcess sends enterAcceleratedCompositingMode message.
+In such situation, WebProcess sends incorporateUpdate to UIProcess because WebProcess is in non-AC mode, but isInAcceleratedCompositingMode becomes true in UIProcess side.
+
+* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
+(WebKit::DrawingAreaProxyCoordinatedGraphics::~DrawingAreaProxyCoordinatedGraphics): Should call exitAcceleratedCompositingMode even when alwaysUseCompositing is true.
+(WebKit::DrawingAreaProxyCoordinatedGraphics::enterAcceleratedCompositingMode): enterAcceleratedCompositingMode should check enterAcceleratedCompositingMode is not called twice.
+* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h: Remove alwaysUseCompositing from isInAcceleratedCompositingMode
+
 2019-03-26  Antoine Quint  
 
 Remove mousemoveEventHandlingPreventsDefault internal setting and quirk


Modified: trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp (243504 => 243505)

--- trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp	2019-03-26 17:29:54 UTC (rev 243504)
+++ trunk/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp	2019-03-26 17:57:58 UTC (rev 243505)
@@ -67,7 +67,7 @@
 DrawingAreaProxyCoordinatedGraphics::~DrawingAreaProxyCoordinatedGraphics()
 {
 // Make sure to exit accelerated compositing mode.
-if (isInAcceleratedCompositingMode() && !alwaysUseCompositing())
+if (isInAcceleratedCompositingMode())
 exitAcceleratedCompositingMode();
 }
 
@@ -269,7 +269,7 @@
 
 void DrawingAreaProxyCoordinatedGraphics::enterAcceleratedCompositingMode(const LayerTreeContext& layerTreeContext)
 {
-ASSERT(alwaysUseCompositing() || !isInAcceleratedCompositingMode());
+ASSERT(!isInAcceleratedCompositingMode());
 #if !PLATFORM(WPE)
 m_bac

[webkit-changes] [243504] trunk/Source/WebCore

2019-03-26 Thread graouts

Title: [243504] trunk/Source/WebCore








Revision 243504
Author grao...@webkit.org
Date 2019-03-26 10:29:54 -0700 (Tue, 26 Mar 2019)


Log Message
Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
https://bugs.webkit.org/show_bug.cgi?id=196254


Unreviewed. Fix build broken by previous commit.

* dom/Event.cpp:
* dom/Event.h:
(WebCore::Event::hasEncounteredListener const): Deleted.
(WebCore::Event::setHasEncounteredListener): Deleted.
* dom/EventTarget.cpp:
(WebCore::EventTarget::innerInvokeEventListeners):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Event.cpp
trunk/Source/WebCore/dom/Event.h
trunk/Source/WebCore/dom/EventTarget.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (243503 => 243504)

--- trunk/Source/WebCore/ChangeLog	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/ChangeLog	2019-03-26 17:29:54 UTC (rev 243504)
@@ -1,3 +1,18 @@
+2019-03-26  Antoine Quint  
+
+Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
+https://bugs.webkit.org/show_bug.cgi?id=196254
+
+
+Unreviewed. Fix build broken by previous commit.
+
+* dom/Event.cpp:
+* dom/Event.h:
+(WebCore::Event::hasEncounteredListener const): Deleted.
+(WebCore::Event::setHasEncounteredListener): Deleted.
+* dom/EventTarget.cpp:
+(WebCore::EventTarget::innerInvokeEventListeners):
+
 2019-03-26  Zalan Bujtas  
 
 [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"


Modified: trunk/Source/WebCore/dom/Event.cpp (243503 => 243504)

--- trunk/Source/WebCore/dom/Event.cpp	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/dom/Event.cpp	2019-03-26 17:29:54 UTC (rev 243504)
@@ -47,7 +47,6 @@
 , m_isDefaultEventHandlerIgnored { false }
 , m_isTrusted { isTrusted == IsTrusted::Yes }
 , m_isExecutingPassiveEventListener { false }
-, m_hasEncounteredListener { false }
 , m_eventPhase { NONE }
 , m_type { type }
 , m_createTime { createTime }


Modified: trunk/Source/WebCore/dom/Event.h (243503 => 243504)

--- trunk/Source/WebCore/dom/Event.h	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/dom/Event.h	2019-03-26 17:29:54 UTC (rev 243504)
@@ -128,9 +128,6 @@
 
 void setInPassiveListener(bool value) { m_isExecutingPassiveEventListener = value; }
 
-bool hasEncounteredListener() const { return m_hasEncounteredListener; }
-void setHasEncounteredListener() { m_hasEncounteredListener = true; }
-
 bool cancelBubble() const { return propagationStopped(); }
 void setCancelBubble(bool);
 
@@ -169,7 +166,6 @@
 unsigned m_isDefaultEventHandlerIgnored : 1;
 unsigned m_isTrusted : 1;
 unsigned m_isExecutingPassiveEventListener : 1;
-unsigned m_hasEncounteredListener : 1;
 
 unsigned m_eventPhase : 2;
 


Modified: trunk/Source/WebCore/dom/EventTarget.cpp (243503 => 243504)

--- trunk/Source/WebCore/dom/EventTarget.cpp	2019-03-26 17:27:05 UTC (rev 243503)
+++ trunk/Source/WebCore/dom/EventTarget.cpp	2019-03-26 17:29:54 UTC (rev 243504)
@@ -301,16 +301,6 @@
 registeredListener->callback().handleEvent(context, event);
 InspectorInstrumentation::didHandleEvent(context);
 
-#if ENABLE(TOUCH_EVENTS)
-if (RuntimeEnabledFeatures::sharedFeatures().mousemoveEventHandlingPreventsDefaultEnabled() && event.type() == eventNames().mousemoveEvent) {
-if (is(event.currentTarget())) {
-auto* element = downcast(event.currentTarget());
-if (!is(element) && !is(element))
-event.setHasEncounteredListener();
-}
-}
-#endif
-
 if (registeredListener->isPassive())
 event.setInPassiveListener(false);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243503] trunk

2019-03-26 Thread zalan

Title: [243503] trunk








Revision 243503
Author za...@apple.com
Date 2019-03-26 10:27:05 -0700 (Tue, 26 Mar 2019)


Log Message
[ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"
https://bugs.webkit.org/show_bug.cgi?id=196259


Reviewed by Dean Jackson.

Source/WebCore:

Anonymous renderers don't have associated DOM nodes so they can't have event listeners either. Let's skip them.

Test: fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html

* page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::StyleChangeScope::isConsideredClickable const):

LayoutTests:

* fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt: Added.
* fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp


Added Paths

trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt
trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html




Diff

Modified: trunk/LayoutTests/ChangeLog (243502 => 243503)

--- trunk/LayoutTests/ChangeLog	2019-03-26 17:13:30 UTC (rev 243502)
+++ trunk/LayoutTests/ChangeLog	2019-03-26 17:27:05 UTC (rev 243503)
@@ -1,3 +1,14 @@
+2019-03-26  Zalan Bujtas  
+
+[ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"
+https://bugs.webkit.org/show_bug.cgi?id=196259
+
+
+Reviewed by Dean Jackson.
+
+* fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt: Added.
+* fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html: Added.
+
 2019-03-26  Shawn Roberts  
 
 Layout tests fast/events/wheel-event-destroys-overflow.html 


Added: trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt (0 => 243503)

--- trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer-expected.txt	2019-03-26 17:27:05 UTC (rev 243503)
@@ -0,0 +1,3 @@
+PASS if no crash.
+inline text with
+text inside block


Added: trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html (0 => 243503)

--- trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html	2019-03-26 17:27:05 UTC (rev 243503)
@@ -0,0 +1,54 @@
+
+
+This tests the case when visible content has anonymous renderers.
+
+#tapthis {
+width: 400px;
+height: 400px;
+border: 1px solid green;
+}
+
+#becomesVisible {
+position: absolute;
+left: -1000px;
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+