[webkit-changes] [246581] trunk/Websites/perf.webkit.org
Title: [246581] trunk/Websites/perf.webkit.org
Revision 246581
Author dewei_...@apple.com
Date 2019-06-18 22:12:35 -0700 (Tue, 18 Jun 2019)
Log Message
Customizable test group form should allow user to supply a revision prefix of a commit and revision starts with 'r'.
https://bugs.webkit.org/show_bug.cgi?id=198940
Reviewed by Ryosuke Niwa.
Customizable test group form should adapt prefix matching when fetching for a commit.
* browser-tests/customizable-test-group-form-tests.js: Updated and added unit tests.
* public/v3/components/customizable-test-group-form.js: Removed loggings those a unintentionally committed.
* public/v3/models/commit-set.js: Adapted prefix matching API when fetching a commit.
(IntermediateCommitSet.prototype._fetchCommitLogAndOwnedCommits):
* unit-tests/commit-set-tests.js: Updated unit tests accordingly.
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js
trunk/Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js
trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js
trunk/Websites/perf.webkit.org/unit-tests/commit-set-tests.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (246580 => 246581)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-06-19 04:44:11 UTC (rev 246580)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-06-19 05:12:35 UTC (rev 246581)
@@ -1,3 +1,18 @@
+2019-06-17 Dewei Zhu
+
+Customizable test group form should allow user to supply a revision prefix of a commit and revision starts with 'r'.
+https://bugs.webkit.org/show_bug.cgi?id=198940
+
+Reviewed by Ryosuke Niwa.
+
+Customizable test group form should adapt prefix matching when fetching for a commit.
+
+* browser-tests/customizable-test-group-form-tests.js: Updated and added unit tests.
+* public/v3/components/customizable-test-group-form.js: Removed loggings those a unintentionally committed.
+* public/v3/models/commit-set.js: Adapted prefix matching API when fetching a commit.
+(IntermediateCommitSet.prototype._fetchCommitLogAndOwnedCommits):
+* unit-tests/commit-set-tests.js: Updated unit tests accordingly.
+
2019-06-13 Dewei Zhu
Custom analysis task configurator should allow supplying commit prefix and revision starts 'r'.
Modified: trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js (246580 => 246581)
--- trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js 2019-06-19 04:44:11 UTC (rev 246580)
+++ trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js 2019-06-19 05:12:35 UTC (rev 246581)
@@ -35,6 +35,18 @@
"message": "some message",
};
+const commitObjectC = {
+"id": "185336",
+"revision": "210950",
+"repository": 1,
+"previousCommit": null,
+"ownsCommits": false,
+"time": 1541494949682,
+"authorName": "Chris Dumez",
+"authorEmail": "cdu...@apple.com",
+"message": "some message",
+};
+
function cloneObject(object)
{
const clone = {};
@@ -62,8 +74,8 @@
const requests = context.symbols.MockRemoteAPI.requests;
expect(requests.length).to.be(2);
-expect(requests[0].url).to.be('/api/commits/1/210948');
-expect(requests[1].url).to.be('/api/commits/1/210949');
+expect(requests[0].url).to.be('/api/commits/1/210948?prefix-match=true');
+expect(requests[1].url).to.be('/api/commits/1/210949?prefix-match=true');
requests[0].resolve({commits: [commitObjectA]});
requests[1].resolve({commits: [commitObjectB]});
@@ -90,6 +102,58 @@
expect(revisionEditor.value).to.be('210948');
});
+it('should allow user to only provide prefix of a commit as long as the commit is unique in the repository', async () => {
+const context = new BrowsingContext();
+const customizableTestGroupForm = await createCustomizableTestGroupFormWithContext(context);
+const repository = context.symbols.Repository.ensureSingleton(1, {name: 'WebKit'});
+
+const commitA = cloneObject(commitObjectA);
+const commitB = cloneObject(commitObjectB);
+const commitC = cloneObject(commitObjectC);
+commitA.repository = repository;
+commitB.repository = repository;
+commitC.repository = repository;
+const webkitCommitA = context.symbols.CommitLog.ensureSingleton(185326, commitA);
+const webkitCommitB = context.symbols.CommitLog.ensureSingleton(185334, commitB);
+const commitSetA = context.symbols.CommitSet.ensureSingleton(1, {revisionItems: [{commit: webkitCommitA}]});
+const commitSetB = context.symbols.CommitSet.ensureSingleton(2, {revisionItems: [{commit: webkitCommitB}]});
+
+customizableTestGroupForm.setCommitSetMap({A:
[webkit-changes] [246580] trunk/Source/WebKit
Title: [246580] trunk/Source/WebKit
Revision 246580
Author ryanhad...@apple.com
Date 2019-06-18 21:44:11 -0700 (Tue, 18 Jun 2019)
Log Message
Unreviewed, rolling out r246575.
Breaks internal builds.
Reverted changeset:
"Update WebKit API to separately retrieve actions and use
context menus"
https://bugs.webkit.org/show_bug.cgi?id=198974
https://trac.webkit.org/changeset/246575
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (246579 => 246580)
--- trunk/Source/WebKit/ChangeLog 2019-06-19 02:36:42 UTC (rev 246579)
+++ trunk/Source/WebKit/ChangeLog 2019-06-19 04:44:11 UTC (rev 246580)
@@ -1,3 +1,16 @@
+2019-06-18 Ryan Haddad
+
+Unreviewed, rolling out r246575.
+
+Breaks internal builds.
+
+Reverted changeset:
+
+"Update WebKit API to separately retrieve actions and use
+context menus"
+https://bugs.webkit.org/show_bug.cgi?id=198974
+https://trac.webkit.org/changeset/246575
+
2019-06-18 Alex Christensen
Update WebKit API to separately retrieve actions and use context menus
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h (246579 => 246580)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h 2019-06-19 02:36:42 UTC (rev 246579)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h 2019-06-19 04:44:11 UTC (rev 246580)
@@ -39,12 +39,6 @@
@class WKWebViewConfiguration;
@class WKWindowFeatures;
-#if TARGET_OS_IPHONE
-@class WKContextMenuElementInfo;
-@class UIContextMenuConfiguration;
-@protocol UIContextMenuInteractionCommitAnimating;
-#endif
-
/*! A class conforming to the WKUIDelegate protocol provides methods for
presenting native UI on behalf of a webpage.
*/
@@ -135,7 +129,7 @@
This method will only be invoked for elements that have default preview in WebKit, which is
limited to links. In the future, it could be invoked for additional elements.
*/
-- (BOOL)webView:(WKWebView *)webView shouldPreviewElement:(WKPreviewElementInfo *)elementInfo WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:completionHandler:", ios(10.0, WK_IOS_TBA));
+- (BOOL)webView:(WKWebView *)webView shouldPreviewElement:(WKPreviewElementInfo *)elementInfo WK_API_DEPRECATED("This API will be replaced", ios(10.0, WK_IOS_TBA));
/*! @abstract Allows your app to provide a custom view controller to show when the given element is peeked.
@param webView The web view invoking the delegate method.
@@ -150,54 +144,14 @@
Returning nil will result in WebKit's default preview behavior. webView:commitPreviewingViewController: will only be invoked
if a non-nil view controller was returned.
*/
-- (nullable UIViewController *)webView:(WKWebView *)webView previewingViewControllerForElement:(WKPreviewElementInfo *)elementInfo defaultActions:(NSArray> *)previewActions WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:completionHandler:", ios(10.0, WK_IOS_TBA));
+- (nullable UIViewController *)webView:(WKWebView *)webView previewingViewControllerForElement:(WKPreviewElementInfo *)elementInfo defaultActions:(NSArray> *)previewActions WK_API_DEPRECATED("This API will be replaced", ios(10.0, WK_IOS_TBA));
/*! @abstract Allows your app to pop to the view controller it created.
@param webView The web view invoking the delegate method.
@param previewingViewController The view controller that is being popped.
*/
-- (void)webView:(WKWebView *)webView commitPreviewingViewController:(UIViewController *)previewingViewController WK_API_DEPRECATED("webView:contextMenuForElement:willCommitWithAnimator:", ios(10.0, WK_IOS_TBA));
+- (void)webView:(WKWebView *)webView commitPreviewingViewController:(UIViewController *)previewingViewController WK_API_DEPRECATED("This API will be replaced", ios(10.0, WK_IOS_TBA));
-/**
- * @abstract Called when a context menu interaction begins.
- *
- * @param webView The web view invoking the delegate method.
- * @param elementInfo The elementInfo for the element the user is touching.
- * @param completionHandler A completion handler to call once a it has been decided whether or not to show a context menu.
- * Pass a valid UIContextMenuConfiguration to show a context menu, or pass nil to not show a context menu.
- */
-
-- (void)webView:(WKWebView *)webView contextMenuConfigurationForElement:(WKContextMenuElementInfo *)elementInfo completionHandler:(void (^)(UIContextMenuConfiguration * _Nullable configuration))completionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA));
-
-/**
- * @abstract Called when the context menu configured by the UIContextMenuConfiguration from
- * webView:contextMenuConfigurationForElement:completionHandler: is committed.
- *
- * @param webView The web view invoking the delegate method.
- * @param elementInfo The elementInfo for the element the user is
[webkit-changes] [246579] trunk
Title: [246579] trunk Revision 246579 Author sbar...@apple.com Date 2019-06-18 19:36:42 -0700 (Tue, 18 Jun 2019) Log Message [WHLSL] Support matrices https://bugs.webkit.org/show_bug.cgi?id=198876 Reviewed by Dean Jackson and Myles Maxfield. Source/WebCore: This patch adds in support for matrices to WHLSL. Most matrix related code is defined by the standard library. This patch just needed to add support for the native functions operator[] and operator[]= on matrix types. The only native functions that are named operator[] and operator[]= are for matrix operations, so we strongly assume when generating code for native operator[] and operator[]= that we're dealing with matrix types. operator[]= ignores the write if the index is out of bounds. operator[] returns a zeroed vector if the index is out of bounds. This patch also incorporates two bug fixes: 1. This patch takes Robin's patch in https://bugs.webkit.org/show_bug.cgi?id=198313 to ensure we don't have pointers to values in a hash map. This was needed in this patch otherwise we'd crash parsing the standard library. 2. This patch fixes how we handle "break" in metal codegen. When I first implemented break, I strongly assumed we were in a loop. However, break can be either from a loop or from switch. This patch teaches the metal code generator to track which context we're in and to emit code accordingly. Tests: webgpu/whlsl-matrix-2.html webgpu/whlsl-matrix.html * Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp: (WebCore::WHLSL::Metal::FunctionDefinitionWriter::visit): (WebCore::WHLSL::Metal::FunctionDefinitionWriter::emitLoop): * Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.cpp: (WebCore::WHLSL::Metal::generateMetalCodeShared): * Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp: (WebCore::WHLSL::Metal::writeNativeFunction): * Modules/webgpu/WHLSL/WHLSLChecker.cpp: (WebCore::WHLSL::Checker::assignTypes): (WebCore::WHLSL::Checker::getInfo): (WebCore::WHLSL::Checker::assignType): (WebCore::WHLSL::Checker::forwardType): * Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt: LayoutTests: * webgpu/whlsl-matrix-2-expected.txt: Added. * webgpu/whlsl-matrix-2.html: Added. * webgpu/whlsl-matrix-expected.txt: Added. * webgpu/whlsl-matrix.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp trunk/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.cpp trunk/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt Added Paths trunk/LayoutTests/webgpu/whlsl-matrix-2-expected.txt trunk/LayoutTests/webgpu/whlsl-matrix-2.html trunk/LayoutTests/webgpu/whlsl-matrix-expected.txt trunk/LayoutTests/webgpu/whlsl-matrix.html Diff Modified: trunk/LayoutTests/ChangeLog (246578 => 246579) --- trunk/LayoutTests/ChangeLog 2019-06-19 01:19:41 UTC (rev 246578) +++ trunk/LayoutTests/ChangeLog 2019-06-19 02:36:42 UTC (rev 246579) @@ -1,3 +1,16 @@ +2019-06-18 Saam Barati + +[WHLSL] Support matrices +https://bugs.webkit.org/show_bug.cgi?id=198876 + + +Reviewed by Dean Jackson and Myles Maxfield. + +* webgpu/whlsl-matrix-2-expected.txt: Added. +* webgpu/whlsl-matrix-2.html: Added. +* webgpu/whlsl-matrix-expected.txt: Added. +* webgpu/whlsl-matrix.html: Added. + 2019-06-18 Russell Epstein Layout Test imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html is failing. Added: trunk/LayoutTests/webgpu/whlsl-matrix-2-expected.txt (0 => 246579) --- trunk/LayoutTests/webgpu/whlsl-matrix-2-expected.txt (rev 0) +++ trunk/LayoutTests/webgpu/whlsl-matrix-2-expected.txt 2019-06-19 02:36:42 UTC (rev 246579) @@ -0,0 +1,12 @@ +PASS successfullyParsed is true + +TEST COMPLETE +PASS resultsFloat32Array[0] is 2 +PASS resultsFloat32Array[1] is 4 +PASS resultsFloat32Array[2] is 6 +PASS resultsFloat32Array[3] is 8 +PASS resultsFloat32Array[4] is 5 +PASS resultsFloat32Array[5] is 6 +PASS resultsFloat32Array[6] is 7 +PASS resultsFloat32Array[7] is 8 + Added: trunk/LayoutTests/webgpu/whlsl-matrix-2.html (0 => 246579) --- trunk/LayoutTests/webgpu/whlsl-matrix-2.html (rev 0) +++ trunk/LayoutTests/webgpu/whlsl-matrix-2.html 2019-06-19 02:36:42 UTC (rev 246579) @@ -0,0 +1,152 @@ + + + + + +