[webkit-changes] [250179] trunk/Source
Title: [250179] trunk/Source
Revision 250179
Author aes...@apple.com
Date 2019-09-20 23:37:34 -0700 (Fri, 20 Sep 2019)
Log Message
[Apple Pay] Clean up handling of summary items and payment method updates
https://bugs.webkit.org/show_bug.cgi?id=202018
Reviewed by Tim Horton.
Source/WebCore:
Replaced the PaymentMethodUpdate struct with a class that knows how to convert from
ApplePayPaymentMethodUpdate structs to PKPaymentRequestPaymentMethodUpdate instances.
Moved some scattered-around free functions for converting payment summary items into
PaymentSummaryItems{.h,Cocoa.mm}.
* Modules/applepay/ApplePayPaymentMethodUpdate.h:
* Modules/applepay/ApplePaySession.cpp:
(WebCore::finishConverting):
(WebCore::convertAndValidateTotal):
(WebCore::convertAndValidate):
* Modules/applepay/ApplePaySessionPaymentRequest.h:
* Modules/applepay/PaymentCoordinator.h:
* Modules/applepay/PaymentCoordinatorClient.h:
* Modules/applepay/PaymentHeaders.h:
* Modules/applepay/PaymentMethodUpdate.h: Added.
* Modules/applepay/PaymentSummaryItems.h: Added.
* Modules/applepay/cocoa/PaymentMethodUpdateCocoa.mm: Added.
(WebCore::PaymentMethodUpdate::PaymentMethodUpdate):
(WebCore::PaymentMethodUpdate::totalAndLineItems const):
(WebCore::PaymentMethodUpdate::platformUpdate const):
* Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm: Added.
(WebCore::toDecimalNumber):
(WebCore::toPKPaymentSummaryItemType):
(WebCore::toPKPaymentSummaryItem):
(WebCore::platformSummaryItems):
* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::paymentMethodUpdated):
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):
Source/WebKit:
Now that PaymentMethodUpdate knows how to convert itself to a
PKPaymentRequestPaymentMethodUpdate, PaymentAuthorizationPresenter can merely pass the
converted update directly to the platform delegate rather than passing the individual
components and relying on the delegate to instantiate the platform update itself. Added
FIXMEs for applying a similar treatment to ShippingContactUpdate and ShippingMethodUpdate.
* Platform/cocoa/PaymentAuthorizationPresenter.h:
* Platform/cocoa/PaymentAuthorizationPresenter.mm:
(WebKit::PaymentAuthorizationPresenter::completePaymentMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingContactSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingMethodSelection):
* Platform/cocoa/WKPaymentAuthorizationDelegate.h:
* Platform/cocoa/WKPaymentAuthorizationDelegate.mm:
(-[WKPaymentAuthorizationDelegate completePaymentMethodSelection:]):
(-[WKPaymentAuthorizationDelegate completeShippingContactSelection:]):
(-[WKPaymentAuthorizationDelegate completeShippingMethodSelection:]):
(-[WKPaymentAuthorizationDelegate _didSelectPaymentMethod:completion:]):
(-[WKPaymentAuthorizationDelegate _didSelectShippingContact:completion:]):
(-[WKPaymentAuthorizationDelegate _didSelectShippingMethod:completion:]):
(-[WKPaymentAuthorizationDelegate completeShippingContactSelection:summaryItems:shippingMethods:errors:]): Deleted.
* Shared/ApplePay/WebPaymentCoordinatorProxy.h:
* Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
* Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
(WebKit::toPKPaymentSummaryItemType): Deleted.
(WebKit::toPKPaymentSummaryItem): Deleted.
(WebKit::toPKPaymentSummaryItems): Deleted.
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePayPaymentMethodUpdate.h
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp
trunk/Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h
trunk/Source/WebCore/Modules/applepay/PaymentCoordinator.h
trunk/Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h
trunk/Source/WebCore/Modules/applepay/PaymentHeaders.h
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
trunk/Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.h
trunk/Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm
trunk/Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.h
trunk/Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.mm
trunk/Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h
trunk/Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h
trunk/Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
Added Paths
trunk/Source/WebCore/Modules/applepay/PaymentMethodUpdate.h
tr
[webkit-changes] [250178] releases/Apple
Title: [250178] releases/Apple Revision 250178 Author m...@apple.com Date 2019-09-20 22:29:17 -0700 (Fri, 20 Sep 2019) Log Message Added a tag for watchOS 6.0. Added Paths releases/Apple/watchOS 6.0/ releases/Apple/watchOS 6.0/ANGLE/ releases/Apple/watchOS 6.0/_javascript_Core/ releases/Apple/watchOS 6.0/WTF/ releases/Apple/watchOS 6.0/WebCore/ releases/Apple/watchOS 6.0/WebKit/ releases/Apple/watchOS 6.0/WebKitLegacy/ releases/Apple/watchOS 6.0/bmalloc/ Diff Index: releases/Apple/watchOS 6.0/ANGLE === --- tags/Safari-608.1.42.2/Source/ThirdParty/ANGLE 2019-09-21 05:27:48 UTC (rev 250177) +++ releases/Apple/watchOS 6.0/ANGLE 2019-09-21 05:29:17 UTC (rev 250178) Property changes: releases/Apple/watchOS 6.0/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455 \ No newline at end of property Index: releases/Apple/watchOS 6.0/_javascript_Core === --- tags/Safari-608.1.42.2/Source/_javascript_Core 2019-09-21 05:27:48 UTC (rev 250177) +++ releases/Apple/watchOS 6.0/_javascript_Core 2019-09-21 05:29:17 UTC (rev 250178) Property changes: releases/Apple/watchOS 6.0/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455 \ No newline at end of property Index: releases/Apple/watchOS 6.0/WTF === --- tags/Safari-608.1.42.2/Source/WTF 2019-09-21 05:27:48 UTC (rev 250177) +++ releases/Apple/watchOS 6.0/WTF 2019-09-21 05:29:17 UTC (rev 250178) Property changes: releases/Apple/watchOS 6.0/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455 \ No newline at end of property Index: releases/Apple/watchOS 6.0/bmalloc === --- tags/Safari-608.1.42.2/Source/bmalloc 2019-09-21 05:27:48 UTC (rev 250177) +++ releases/Apple/watchOS 6.0/bmalloc 2019-09-21 05:29:17 UTC (rev 250178) Property changes: releases/Apple/watchOS 6.0/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250177] releases/Apple
Title: [250177] releases/Apple Revision 250177 Author m...@apple.com Date 2019-09-20 22:27:48 -0700 (Fri, 20 Sep 2019) Log Message Added a tag for iOS 13.0. Added Paths releases/Apple/iOS 13.0/ releases/Apple/iOS 13.0/ANGLE/ releases/Apple/iOS 13.0/_javascript_Core/ releases/Apple/iOS 13.0/WTF/ releases/Apple/iOS 13.0/WebCore/ releases/Apple/iOS 13.0/WebKit/ releases/Apple/iOS 13.0/WebKitLegacy/ releases/Apple/iOS 13.0/bmalloc/ releases/Apple/iOS 13.0/libwebrtc/ Diff Index: releases/Apple/iOS 13.0/ANGLE === --- tags/Safari-608.1.48/Source/ThirdParty/ANGLE 2019-09-21 02:11:37 UTC (rev 250176) +++ releases/Apple/iOS 13.0/ANGLE 2019-09-21 05:27:48 UTC (rev 250177) Property changes: releases/Apple/iOS 13.0/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455 \ No newline at end of property Index: releases/Apple/iOS 13.0/_javascript_Core === --- tags/Safari-608.1.48/Source/_javascript_Core 2019-09-21 02:11:37 UTC (rev 250176) +++ releases/Apple/iOS 13.0/_javascript_Core 2019-09-21 05:27:48 UTC (rev 250177) Property changes: releases/Apple/iOS 13.0/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455 \ No newline at end of property Index: releases/Apple/iOS 13.0/WTF === --- tags/Safari-608.1.48/Source/WTF 2019-09-21 02:11:37 UTC (rev 250176) +++ releases/Apple/iOS 13.0/WTF 2019-09-21 05:27:48 UTC (rev 250177) Property changes: releases/Apple/iOS 13.0/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455 \ No newline at end of property Index: releases/Apple/iOS 13.0/bmalloc === --- tags/Safari-608.1.48/Source/bmalloc 2019-09-21 02:11:37 UTC (rev 250176) +++ releases/Apple/iOS 13.0/bmalloc 2019-09-21 05:27:48 UTC (rev 250177) Property changes: releases/Apple/iOS 13.0/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455 \ No newline at end of property Index: releases/Apple/iOS 13.0/libwebrtc === --- tags/Safari-608.1.48/Source/ThirdParty/libwebrtc 2019-09-21 02:11:37 UTC (rev 250176) +++ releases/Apple/iOS 13.0/libwebrtc 2019-09-21 05:27:48 UTC (rev 250177) Property changes: releases/Apple/iOS 13.0/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250176] trunk/Source/JavaScriptCore
Title: [250176] trunk/Source/_javascript_Core
Revision 250176
Author keith_mil...@apple.com
Date 2019-09-20 19:11:37 -0700 (Fri, 20 Sep 2019)
Log Message
eliding a move in Air O0 needs to mark the dest's old reg as available
https://bugs.webkit.org/show_bug.cgi?id=202066
Reviewed by Saam Barati.
Also adds a new release method that handles all the invariants of
returning a register to the available register pool.
* b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
(JSC::B3::Air::GenerateAndAllocateRegisters::release):
(JSC::B3::Air::GenerateAndAllocateRegisters::spill):
(JSC::B3::Air::GenerateAndAllocateRegisters::freeDeadTmpsIfNeeded):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):
* b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp
trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (250175 => 250176)
--- trunk/Source/_javascript_Core/ChangeLog 2019-09-21 01:24:45 UTC (rev 250175)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-09-21 02:11:37 UTC (rev 250176)
@@ -1,3 +1,20 @@
+2019-09-20 Keith Miller
+
+eliding a move in Air O0 needs to mark the dest's old reg as available
+https://bugs.webkit.org/show_bug.cgi?id=202066
+
+Reviewed by Saam Barati.
+
+Also adds a new release method that handles all the invariants of
+returning a register to the available register pool.
+
+* b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
+(JSC::B3::Air::GenerateAndAllocateRegisters::release):
+(JSC::B3::Air::GenerateAndAllocateRegisters::spill):
+(JSC::B3::Air::GenerateAndAllocateRegisters::freeDeadTmpsIfNeeded):
+(JSC::B3::Air::GenerateAndAllocateRegisters::generate):
+* b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
+
2019-09-20 Mark Lam
Harden assertion in StructureIDTable::get().
Modified: trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp (250175 => 250176)
--- trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp 2019-09-21 01:24:45 UTC (rev 250175)
+++ trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp 2019-09-21 02:11:37 UTC (rev 250176)
@@ -123,6 +123,18 @@
return CCallHelpers::Address(reg);
}
+ALWAYS_INLINE void GenerateAndAllocateRegisters::release(Tmp tmp, Reg reg)
+{
+ASSERT(reg);
+ASSERT(m_currentAllocation->at(reg) == tmp);
+m_currentAllocation->at(reg) = Tmp();
+ASSERT(!m_availableRegs[tmp.bank()].contains(reg));
+m_availableRegs[tmp.bank()].set(reg);
+ASSERT(m_map[tmp].reg == reg);
+m_map[tmp].reg = Reg();
+}
+
+
ALWAYS_INLINE void GenerateAndAllocateRegisters::flush(Tmp tmp, Reg reg)
{
ASSERT(tmp);
@@ -137,10 +149,8 @@
{
ASSERT(reg);
ASSERT(m_map[tmp].reg == reg);
-m_availableRegs[tmp.bank()].set(reg);
-m_currentAllocation->at(reg) = Tmp();
flush(tmp, reg);
-m_map[tmp].reg = Reg();
+release(tmp, reg);
}
ALWAYS_INLINE void GenerateAndAllocateRegisters::alloc(Tmp tmp, Reg reg, bool isDef)
@@ -180,10 +190,7 @@
if (m_liveRangeEnd[tmp] >= m_globalInstIndex)
continue;
-Reg reg = Reg::fromIndex(i);
-m_map[tmp].reg = Reg();
-m_availableRegs[tmp.bank()].set(reg);
-m_currentAllocation->at(i) = Tmp();
+release(tmp, Reg::fromIndex(i));
}
}
@@ -447,14 +454,12 @@
if (dest.isReg() && dest.reg() != sourceReg)
return true;
-if (Reg oldReg = m_map[dest.tmp()].reg) {
-ASSERT(m_currentAllocation->at(oldReg) == dest.tmp());
-m_currentAllocation->at(oldReg) = Tmp();
-}
+if (Reg oldReg = m_map[dest.tmp()].reg)
+release(dest.tmp(), oldReg);
+m_map[dest.tmp()].reg = sourceReg;
m_currentAllocation->at(sourceReg) = dest.tmp();
m_map[source.tmp()].reg = Reg();
-m_map[dest.tmp()].reg = sourceReg;
return false;
})();
Modified: trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.h (250175 => 250176)
--- trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.h 2019-09-21 01:24:45 UTC (rev 250175)
+++ trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.h 2019-09-21 02:11:37 UTC (rev 250176)
@@ -55,6 +55,7 @@
private:
void insertBlocksForFlushAfterTerminalPatchpoints();
+void release(Tmp, Reg);
void flush(Tmp, Reg);
void spill(Tmp, Reg);
void alloc(Tmp, Reg, bool isDef);
___
webkit-changes mailing list
web
[webkit-changes] [250175] trunk
Title: [250175] trunk
Revision 250175
Author commit-qu...@webkit.org
Date 2019-09-20 18:24:45 -0700 (Fri, 20 Sep 2019)
Log Message
Assertion fires when animating a discrete property with values range and multiple animators
https://bugs.webkit.org/show_bug.cgi?id=201926
Patch by Said Abou-Hallawa on 2019-09-20
Reviewed by Darin Adler.
Source/WebCore:
The first animator of a property is considered the result element. The
other animators will be just contributers to the first animator. For the
first animator and in SVGSMILElement::progress(), we call resetAnimatedType()
which creates m_animator in SVGAnimateElementBase::animator(). But for
the other animators we do not call resetAnimatedType(). So their m_animator
will stay null until they are used for the first time.
If SVGAnimationElement::startedActiveInterval() calls calculateToAtEndOfDurationValue()
for a discrete property this will have no effect and the call should be
ignored. So SVGAnimateElementBase::calculateToAtEndOfDurationValue()
should bail out early if isDiscreteAnimator() is true.
The bug is isDiscreteAnimator() will return false if the m_animator is
null even if the animated property is discrete, e.g. SVGAnimatedString.
The fix is to make isDiscreteAnimator() ensure m_animator is created.
Unrelated change:
Make most of the protected methods of SVGAnimateElementBase be private.
Test: svg/animations/multiple-discrete-values-animate.svg
* svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue):
LayoutTests:
Animate a discrete property, such as SVGAnimatedString. There should be
multiple animators and the range of animation has to be set by the 'values'
attribute.
* svg/animations/multiple-discrete-values-animate-expected.txt: Added.
* svg/animations/multiple-discrete-values-animate.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimateElementBase.cpp
trunk/Source/WebCore/svg/SVGAnimateElementBase.h
Added Paths
trunk/LayoutTests/svg/animations/multiple-discrete-values-animate-expected.txt
trunk/LayoutTests/svg/animations/multiple-discrete-values-animate.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (250174 => 250175)
--- trunk/LayoutTests/ChangeLog 2019-09-21 01:07:49 UTC (rev 250174)
+++ trunk/LayoutTests/ChangeLog 2019-09-21 01:24:45 UTC (rev 250175)
@@ -1,3 +1,17 @@
+2019-09-20 Said Abou-Hallawa
+
+Assertion fires when animating a discrete property with values range and multiple animators
+https://bugs.webkit.org/show_bug.cgi?id=201926
+
+Reviewed by Darin Adler.
+
+Animate a discrete property, such as SVGAnimatedString. There should be
+multiple animators and the range of animation has to be set by the 'values'
+attribute.
+
+* svg/animations/multiple-discrete-values-animate-expected.txt: Added.
+* svg/animations/multiple-discrete-values-animate.svg: Added.
+
2019-09-20 Chris Dumez
REGRESSION (iOS 13): rAF stops firing when navigating away cross-origin and then back
Added: trunk/LayoutTests/svg/animations/multiple-discrete-values-animate-expected.txt (0 => 250175)
--- trunk/LayoutTests/svg/animations/multiple-discrete-values-animate-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/animations/multiple-discrete-values-animate-expected.txt 2019-09-21 01:24:45 UTC (rev 250175)
@@ -0,0 +1 @@
+Passes if we did not debug assert.
Added: trunk/LayoutTests/svg/animations/multiple-discrete-values-animate.svg (0 => 250175)
--- trunk/LayoutTests/svg/animations/multiple-discrete-values-animate.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/multiple-discrete-values-animate.svg 2019-09-21 01:24:45 UTC (rev 250175)
@@ -0,0 +1,18 @@
+
+
+Passes if we did not debug assert.
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function animationStarted() {
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+
Modified: trunk/Source/WebCore/ChangeLog (250174 => 250175)
--- trunk/Source/WebCore/ChangeLog 2019-09-21 01:07:49 UTC (rev 250174)
+++ trunk/Source/WebCore/ChangeLog 2019-09-21 01:24:45 UTC (rev 250175)
@@ -1,3 +1,35 @@
+2019-09-20 Said Abou-Hallawa
+
+Assertion fires when animating a discrete property with values range and multiple animators
+https://bugs.webkit.org/show_bug.cgi?id=201926
+
+Reviewed by Darin Adler.
+
+The first animator of a property is considered the result element. The
+other animators will be just contributers to the first animator. For the
+first animator and in SVGSMILElement::progress(), we call resetAnimatedType()
+which creates m_animator in SVGAnimateElementBase::animator
[webkit-changes] [250174] trunk/Tools
Title: [250174] trunk/Tools
Revision 250174
Author aakash_j...@apple.com
Date 2019-09-20 18:07:49 -0700 (Fri, 20 Sep 2019)
Log Message
[EWS] JSC queues should re-build ToT and compare results on build failure
https://bugs.webkit.org/show_bug.cgi?id=201999
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/factories.py:
(JSCTestsFactory.__init__): Do not add the UnApplyPatchIfRequired and CompileJSCOnlyToT step here, as
these are dynamically added (if required) in steps.py in CompileWebKit.evaluateCommand() using addStepsAfterCurrentStep().
Also setting skipUpload=False since we don't need to upload the archive for this queue. Building and testing is done in same build.
* BuildSlaveSupport/ews-build/steps.py:
(CompileWebKit.evaluateCommand): Add CompileJSCOnlyToT or CompileWebKitToT build-step based on 'group' property.
(AnalyzeCompileWebKitResults.start): Ditto.
(CompileJSCOnly.start): Set the 'group' property to 'jsc'.
(CompileJSCOnlyToT.evaluateCommand): Over-ride evaluateCommand, so that base-class' (CompileWebKit) evaluateCommand is
not used, base class evaluateCommand adds build-steps dynamically.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/factories.py
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (250173 => 250174)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-09-21 00:36:06 UTC (rev 250173)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-09-21 01:07:49 UTC (rev 250174)
@@ -118,9 +118,7 @@
class JSCTestsFactory(Factory):
def __init__(self, platform, configuration='release', architectures=None, additionalArguments=None, **kwargs):
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
-self.addStep(CompileJSCOnly())
-self.addStep(UnApplyPatchIfRequired())
-self.addStep(CompileJSCOnlyToT())
+self.addStep(CompileJSCOnly(skipUpload=True))
self.addStep(RunJavaScriptCoreTests())
self.addStep(ReRunJavaScriptCoreTests())
self.addStep(UnApplyPatchIfRequired())
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (250173 => 250174)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-09-21 00:36:06 UTC (rev 250173)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-09-21 01:07:49 UTC (rev 250174)
@@ -744,7 +744,10 @@
steps_to_add.append(InstallWpeDependencies())
elif platform == 'gtk':
steps_to_add.append(InstallGtkDependencies())
-steps_to_add.append(CompileWebKitToT())
+if self.getProperty('group') == 'jsc':
+steps_to_add.append(CompileJSCOnlyToT())
+else:
+steps_to_add.append(CompileWebKitToT())
steps_to_add.append(AnalyzeCompileWebKitResults())
# Using a single addStepsAfterCurrentStep because of https://github.com/buildbot/buildbot/issues/4874
self.build.addStepsAfterCurrentStep(steps_to_add)
@@ -776,7 +779,10 @@
descriptionDone = ['analyze-compile-webkit-results']
def start(self):
-compile_webkit_tot_result = self.getStepResult(CompileWebKitToT.name)
+compile_tot_step = CompileWebKitToT.name
+if self.getProperty('group') == 'jsc':
+compile_tot_step = CompileJSCOnlyToT.name
+compile_webkit_tot_result = self.getStepResult(compile_tot_step)
if compile_webkit_tot_result == FAILURE:
self.finished(FAILURE)
@@ -804,7 +810,11 @@
descriptionDone = ['Compiled JSC']
command = ['perl', 'Tools/Scripts/build-jsc', WithProperties('--%(configuration)s')]
+def start(self):
+self.setProperty('group', 'jsc')
+return CompileWebKit.start(self)
+
class CompileJSCOnlyToT(CompileJSCOnly):
name = 'build-jsc-tot'
@@ -814,7 +824,10 @@
def hideStepIf(self, results, step):
return not self.doStepIf(step)
+def evaluateCommand(self, cmd):
+return shell.Compile.evaluateCommand(self, cmd)
+
class RunJavaScriptCoreTests(shell.Test):
name = 'jscore-test'
description = ['jscore-tests running']
Modified: trunk/Tools/ChangeLog (250173 => 250174)
--- trunk/Tools/ChangeLog 2019-09-21 00:36:06 UTC (rev 250173)
+++ trunk/Tools/ChangeLog 2019-09-21 01:07:49 UTC (rev 250174)
@@ -1,3 +1,21 @@
+2019-09-20 Aakash Jain
+
+[EWS] JSC queues should re-build ToT and compare results on build failure
+https://bugs.webkit.org/show_bug.cgi?id=201999
+
+Reviewed by Jonathan Bedard.
+
+* BuildSlaveSupport/ews-build/factories.py:
+(JSCTestsFactory.__init__): Do not add the UnApplyPatchIfRequired and CompileJSCOnlyToT step here, as
+these are dynamically added (if required) in steps.py in CompileWebKit.evaluateCommand() using addStepsAfterCurrentStep().
+Also setting skipUpload=False
[webkit-changes] [250173] trunk/Source/WebCore
Title: [250173] trunk/Source/WebCore
Revision 250173
Author krol...@apple.com
Date 2019-09-20 17:36:06 -0700 (Fri, 20 Sep 2019)
Log Message
Remove dead code for a specific macOS and iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=202054
Reviewed by Zalan Bujtas.
ComplexTextController::collectComplexTextRunsForCharacters in
ComplexTextControllerCoreText.mm has some code for compatibility with
specifically macOS 10.14.0 and iOS 12.0 (see Bug 186571). We don't
build for these targets any more (when we build for macOS 10.14, it's
for a later minor revision), so this code can be removed.
No new tests -- no new or changed functionality.
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (250172 => 250173)
--- trunk/Source/WebCore/ChangeLog 2019-09-21 00:29:13 UTC (rev 250172)
+++ trunk/Source/WebCore/ChangeLog 2019-09-21 00:36:06 UTC (rev 250173)
@@ -1,3 +1,22 @@
+2019-09-20 Keith Rollin
+
+Remove dead code for a specific macOS and iOS SDK
+https://bugs.webkit.org/show_bug.cgi?id=202054
+
+
+Reviewed by Zalan Bujtas.
+
+ComplexTextController::collectComplexTextRunsForCharacters in
+ComplexTextControllerCoreText.mm has some code for compatibility with
+specifically macOS 10.14.0 and iOS 12.0 (see Bug 186571). We don't
+build for these targets any more (when we build for macOS 10.14, it's
+for a later minor revision), so this code can be removed.
+
+No new tests -- no new or changed functionality.
+
+* platform/graphics/mac/ComplexTextControllerCoreText.mm:
+(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
+
2019-09-20 Alex Christensen
Remove unnecessary abstractions around WebsiteDataStore
Modified: trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm (250172 => 250173)
--- trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm 2019-09-21 00:29:13 UTC (rev 250172)
+++ trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm 2019-09-21 00:36:06 UTC (rev 250173)
@@ -139,15 +139,9 @@
if (!m_mayUseNaturalWritingDirection || m_run.directionalOverride()) {
const short ltrForcedEmbeddingLevelValue = 0;
const short rtlForcedEmbeddingLevelValue = 1;
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED == 12)
-static const void* optionKeys[] = { kCTTypesetterOptionForcedEmbeddingLevel, kCTTypesetterOptionAllowUnboundedLayout };
-static const void* ltrOptionValues[] = { CFNumberCreate(kCFAllocatorDefault, kCFNumberShortType,
[webkit-changes] [250172] trunk/Source/JavaScriptCore
Title: [250172] trunk/Source/_javascript_Core Revision 250172 Author mark@apple.com Date 2019-09-20 17:29:13 -0700 (Fri, 20 Sep 2019) Log Message Harden assertion in StructureIDTable::get(). https://bugs.webkit.org/show_bug.cgi?id=202067 Reviewed by Keith Miller. * runtime/StructureIDTable.h: (JSC::StructureIDTable::get): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/StructureIDTable.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (250171 => 250172) --- trunk/Source/_javascript_Core/ChangeLog 2019-09-21 00:17:27 UTC (rev 250171) +++ trunk/Source/_javascript_Core/ChangeLog 2019-09-21 00:29:13 UTC (rev 250172) @@ -1,3 +1,14 @@ +2019-09-20 Mark Lam + +Harden assertion in StructureIDTable::get(). +https://bugs.webkit.org/show_bug.cgi?id=202067 + + +Reviewed by Keith Miller. + +* runtime/StructureIDTable.h: +(JSC::StructureIDTable::get): + 2019-09-20 Truitt Savell Unreviewed, rolling out r250114. Modified: trunk/Source/_javascript_Core/runtime/StructureIDTable.h (250171 => 250172) --- trunk/Source/_javascript_Core/runtime/StructureIDTable.h 2019-09-21 00:17:27 UTC (rev 250171) +++ trunk/Source/_javascript_Core/runtime/StructureIDTable.h 2019-09-21 00:29:13 UTC (rev 250172) @@ -172,7 +172,7 @@ ASSERT_WITH_SECURITY_IMPLICATION(structureID); ASSERT_WITH_SECURITY_IMPLICATION(!isNuked(structureID)); uint32_t structureIndex = structureID >> s_numberOfEntropyBits; -ASSERT_WITH_SECURITY_IMPLICATION(structureIndex < m_capacity); +RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(structureIndex < m_capacity); return decode(table()[structureIndex].encodedStructureBits, structureID); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250171] trunk/Source
Title: [250171] trunk/Source Revision 250171 Author krol...@apple.com Date 2019-09-20 17:17:27 -0700 (Fri, 20 Sep 2019) Log Message Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=202027 Reviewed by Alex Christensen. Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 13. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. After version checks have been removed, there are some cases where the preprocessor conditional looks like "#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)". These can be collapsed into "#if PLATFORM(COCOA)". This additional cleanup will be performed in a subsequent patch. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Joe Pecoraro was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. Source/WebCore/PAL: * pal/spi/cf/CFNetworkSPI.h: Source/WebKit: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]): Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (250170 => 250171) --- trunk/Source/WebCore/PAL/ChangeLog 2019-09-21 00:15:02 UTC (rev 250170) +++ trunk/Source/WebCore/PAL/ChangeLog 2019-09-21 00:17:27 UTC (rev 250171) @@ -1,5 +1,35 @@ 2019-09-20 Keith Rollin +Remove some support for < iOS 13 +https://bugs.webkit.org/show_bug.cgi?id=202027 + + +Reviewed by Alex Christensen. + +Remove some support for iOS versions less than 13.0. + +Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED +and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have +values >= 13. This means that expressions like +"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and +"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. + +After version checks have been removed, there are some cases where the +preprocessor conditional looks like "#if PLATFORM(MAC) || +PLATFORM(IOS_FAMILY)". These can be collapsed into "#if +PLATFORM(COCOA)". This additional cleanup will be performed in a +subsequent patch. + +This removal is part of a series of patches effecting the removal of +dead code for old versions of iOS. This particular pass involves +changes in which Joe Pecoraro was involved. These changes are isolated +from other similar changes in order to facilitate the reviewing +process. + +* pal/spi/cf/CFNetworkSPI.h: + +2019-09-20 Keith Rollin + Remove check of setSourceAppPid selector that's no longer needed https://bugs.webkit.org/show_bug.cgi?id=201971 Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (250170 => 250171) --- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-09-21 00:15:02 UTC (rev 250170) +++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-09-21 00:17:27 UTC (rev 250171) @@ -218,7 +218,7 @@ #endif @end -#if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11) +#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY) @interface NSURLSessionTaskTransactionMetrics () @property (copy, readonly) NSString* _remoteAddressAndPort; @property (copy, readonly) NSUUID* _connectionIdentifier; Modified: trunk/Source/WebKit/ChangeLog (250170 => 250171) --- trunk/Source/WebKit/ChangeLog 2019-09-21 00:15:02 UTC (rev 250170) +++ trunk/Source/WebKit/ChangeLog 2019-09-21 00:17:27 UTC (rev 250171) @@ -1,3 +1,34 @@ +2019-09-20 Keith Rollin + +Remove some support for < iOS 13 +https://bugs.webkit.org/show_bug.cgi?id=202027 + + +Reviewed by Alex Christensen. + +Remove some support for iOS versions less than 13.0. + +Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED +and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have +values >= 13. This means that expressions like +"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and +"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. + +After version checks have been removed, there are some cases where the +preprocessor conditional looks like "#if PLATFORM(MAC) || +PLATFORM(IOS_FAMILY)". These can be collapsed into "#if +PLATFORM(COCOA)". This additional cleanup will be performed in a +subsequent patch.
[webkit-changes] [250170] branches/safari-608.2.30.1-branch/
Title: [250170] branches/safari-608.2.30.1-branch/ Revision 250170 Author kocsen_ch...@apple.com Date 2019-09-20 17:15:02 -0700 (Fri, 20 Sep 2019) Log Message New branch. Added Paths branches/safari-608.2.30.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250168] tags/Safari-608.2.11.1.10/
Title: [250168] tags/Safari-608.2.11.1.10/ Revision 250168 Author kocsen_ch...@apple.com Date 2019-09-20 16:59:47 -0700 (Fri, 20 Sep 2019) Log Message Tag Safari-608.2.11.1.10. Added Paths tags/Safari-608.2.11.1.10/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250167] trunk
Title: [250167] trunk
Revision 250167
Author commit-qu...@webkit.org
Date 2019-09-20 16:59:02 -0700 (Fri, 20 Sep 2019)
Log Message
[resource-timing] Report performance entries with all HTTP status codes
https://bugs.webkit.org/show_bug.cgi?id=202040
Patch by Alex Christensen on 2019-09-20
Reviewed by Joseph Pecoraro.
LayoutTests/imported/w3c:
* web-platform-tests/resource-timing/resource_ignore_failures-expected.txt: Removed.
* web-platform-tests/resource-timing/resource_ignore_failures.html: Removed.
This test is no longer in wpt and it would regress with this change, so we remove it.
* web-platform-tests/resource-timing/resources/status-code.py: Added.
(main):
* web-platform-tests/resource-timing/status-codes-create-entry-expected.txt: Added.
* web-platform-tests/resource-timing/status-codes-create-entry.html: Added.
Source/WebCore:
This follows a Chromium change at https://chromium-review.googlesource.com/c/chromium/src/+/1796544
The spec change is being discussed at https://github.com/w3c/resource-timing/issues/165
Test: imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry.html
I had to slightly modify the test to make sure the entry count was > 0 instead of == 1 to reduce flakyness because sometimes we load the 200 image twice.
I'll submit a PR to WPT, too.
* loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::shouldAddResourceTiming):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceTimingInformation.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/status-code.py
trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry.html
Removed Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (250166 => 250167)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-09-20 23:54:51 UTC (rev 250166)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-09-20 23:59:02 UTC (rev 250167)
@@ -1,3 +1,18 @@
+2019-09-20 Alex Christensen
+
+[resource-timing] Report performance entries with all HTTP status codes
+https://bugs.webkit.org/show_bug.cgi?id=202040
+
+Reviewed by Joseph Pecoraro.
+
+* web-platform-tests/resource-timing/resource_ignore_failures-expected.txt: Removed.
+* web-platform-tests/resource-timing/resource_ignore_failures.html: Removed.
+This test is no longer in wpt and it would regress with this change, so we remove it.
+* web-platform-tests/resource-timing/resources/status-code.py: Added.
+(main):
+* web-platform-tests/resource-timing/status-codes-create-entry-expected.txt: Added.
+* web-platform-tests/resource-timing/status-codes-create-entry.html: Added.
+
2019-09-20 Rob Buis
Synchronize MathML WPT tests against upstream
Deleted: trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures-expected.txt (250166 => 250167)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures-expected.txt 2019-09-20 23:54:51 UTC (rev 250166)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures-expected.txt 2019-09-20 23:59:02 UTC (rev 250167)
@@ -1,7 +0,0 @@
-Description
-
-This test validates that failed resources aren't present in the Resource Timing buffer.
-
-
-PASS entries.length == 0
-
Deleted: trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures.html (250166 => 250167)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures.html 2019-09-20 23:54:51 UTC (rev 250166)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_ignore_failures.html 2019-09-20 23:59:02 UTC (rev 250167)
@@ -1,33 +0,0 @@
-
-
-
-
-Resource Timing ignores failed resources
-
-
-let iframe;
-function setup_iframe() {
-const iframe_content = '
-
-
-Description
-This test validates that failed resources aren't present in the Resource Timing buffer.
-
-
-
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/status-code.py (0 => 250167)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/status-code.py (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/status-code.py 2019-09-20 23:59:02 UTC (rev 250167)
@@ -0,0 +1,4 @@
+def main(request, response):
+status = request.GET.first('status')
+response.status = (status, "");
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/re
[webkit-changes] [250166] branches/safari-608.2.11.1-branch/Source/WebKit
Title: [250166] branches/safari-608.2.11.1-branch/Source/WebKit Revision 250166 Author kocsen_ch...@apple.com Date 2019-09-20 16:54:51 -0700 (Fri, 20 Sep 2019) Log Message Revert to match Safari-608.2.11.1.7 content. Modified Paths branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.messages.in Diff Modified: branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog (250165 => 250166) --- branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog 2019-09-20 23:46:45 UTC (rev 250165) +++ branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog 2019-09-20 23:54:51 UTC (rev 250166) @@ -1,79 +1,3 @@ -2019-09-20 Alan Coon - -Apply patch. rdar://problem/55564031 - -2019-09-20 Chris Dumez - -Regression(r248832): Unable to quicklook HTML files in Mail -https://bugs.webkit.org/show_bug.cgi?id=202012 - - -Reviewed by Geoff Garen and Brent Fulgham. - -r248832 inadvertently reverted the fix for Mail that landed in r247400 by not using -the same logic to initialize the sandbox extension if the process had already -finished launching or not. In particular, the new code path that happens on process -launch unconditionally used '/' as resource directory for the sandbox extension if -the client did not provide one. The logic in maybeInitializeSandboxExtensionHandle() -would use the file URL's base URL as resource directory when creating a sandbox -extension for '/' would fail (which it often does). - -To address the issue, have the logic that runs on process launch call -maybeInitializeSandboxExtensionHandle() so avoid duplicating code and make sure -both cases now have the Mail fix. - -* UIProcess/AuxiliaryProcessProxy.cpp: -(WebKit::AuxiliaryProcessProxy::didFinishLaunching): -* UIProcess/AuxiliaryProcessProxy.h: -(WebKit::AuxiliaryProcessProxy::isLaunching const): -* UIProcess/WebPageProxy.cpp: -(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): -(WebKit::WebPageProxy::loadRequestWithNavigationShared): -(WebKit::WebPageProxy::loadFile): -* UIProcess/WebPageProxy.h: -* WebProcess/WebPage/WebPage.messages.in: - -2019-09-19 Kocsen Chung - -Cherry-pick r250069. rdar://problem/55524978 - -Eagerly create and add the m_layerHostingView to WKWebView. -https://bugs.webkit.org/show_bug.cgi?id=201942 - -Reviewed by Tim Horton. - -Some apps will add subviews to WKWebView, and by the time we add our m_layerHostingView view we might be -adding it behind a view that should have been added behind our layer hosting view subview. This affected -the Spark email app, due to changes in order of loading delegate calls and when compositing is enabled. -Instead of delayed creation of m_layerHostingView, always create it and add it to to the WKWebView. -This ensures proper ordering of subviews when clients add a view behind all existing subviews. - -* UIProcess/Cocoa/WebViewImpl.mm: -(WebKit::WebViewImpl::WebViewImpl): Create and add m_layerHostingView here. -(WebKit::WebViewImpl::setAcceleratedCompositingRootLayer): Remove creation and removal of m_layerHostingView. -Just set the sublayers of m_layerHostingView's layer here. - - -git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250069 268f45cc-cd09-0410-ab3c-d52691b4dbfc - -2019-09-18 Timothy Hatcher - -Eagerly create and add the m_layerHostingView to WKWebView. -https://bugs.webkit.org/show_bug.cgi?id=201942 - -Reviewed by Tim Horton. - -Some apps will add subviews to WKWebView, and by the time we add our m_layerHostingView view we might be -adding it behind a view that should have been added behind our layer hosting view subview. This affected -the Spark email app, due to changes in order of loading delegate calls and when compositing is enabled. -Instead of delayed creation of m_layerHostingView, always create it and add it to to the WKWebView. -This ensures proper ordering of subviews when clients add a view behind all existing subviews. - -
[webkit-changes] [250165] trunk
Title: [250165] trunk
Revision 250165
Author cdu...@apple.com
Date 2019-09-20 16:46:45 -0700 (Fri, 20 Sep 2019)
Log Message
REGRESSION (iOS 13): rAF stops firing when navigating away cross-origin and then back
https://bugs.webkit.org/show_bug.cgi?id=201767
Reviewed by Tim Horton.
Source/WebKit:
This is a follow-up to r249961 to address crashes when navigating back cross-origin to a page
that uses requestAnimationFrame. r249961 took care of moving RemoteLayerTreeDisplayRefreshMonitor
objects from one RemoteLayerTreeDrawingArea to another but failed to tell those monitors
about their new drawingArea. As a result, RemoteLayerTreeDrawingArea::willDestroyDisplayRefreshMonitor()
would not get called on the new drawing area when it should have.
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::updateDrawingArea):
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::adoptDisplayRefreshMonitorsFromDrawingArea):
LayoutTests:
Call finishJSTest() on a timer to make it more likely to reproduce the bug.
* http/tests/navigation/page-cache-requestAnimationFrame.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/navigation/page-cache-requestAnimationFrame.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h
trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm
trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (250164 => 250165)
--- trunk/LayoutTests/ChangeLog 2019-09-20 23:18:30 UTC (rev 250164)
+++ trunk/LayoutTests/ChangeLog 2019-09-20 23:46:45 UTC (rev 250165)
@@ -1,3 +1,15 @@
+2019-09-20 Chris Dumez
+
+REGRESSION (iOS 13): rAF stops firing when navigating away cross-origin and then back
+https://bugs.webkit.org/show_bug.cgi?id=201767
+
+
+Reviewed by Tim Horton.
+
+Call finishJSTest() on a timer to make it more likely to reproduce the bug.
+
+* http/tests/navigation/page-cache-requestAnimationFrame.html:
+
2019-09-20 Devin Rousso
Web Inspector: HTML Formatter - better indentation/newline handling for self closing tags
Modified: trunk/LayoutTests/http/tests/navigation/page-cache-requestAnimationFrame.html (250164 => 250165)
--- trunk/LayoutTests/http/tests/navigation/page-cache-requestAnimationFrame.html 2019-09-20 23:18:30 UTC (rev 250164)
+++ trunk/LayoutTests/http/tests/navigation/page-cache-requestAnimationFrame.html 2019-09-20 23:46:45 UTC (rev 250165)
@@ -37,7 +37,9 @@
if (i % 10 == 0 && restoredFromPageCache) {
testPassed("requestAnimationFrame is running after restoring from PageCache.");
clearTimeout(timerHandle);
-finishJSTest();
+setTimeout(() => {
+finishJSTest();
+}, 100);
} else
requestAnimationFrame(step);
}
Modified: trunk/Source/WebKit/ChangeLog (250164 => 250165)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 23:18:30 UTC (rev 250164)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 23:46:45 UTC (rev 250165)
@@ -1,3 +1,23 @@
+2019-09-20 Chris Dumez
+
+REGRESSION (iOS 13): rAF stops firing when navigating away cross-origin and then back
+https://bugs.webkit.org/show_bug.cgi?id=201767
+
+
+Reviewed by Tim Horton.
+
+This is a follow-up to r249961 to address crashes when navigating back cross-origin to a page
+that uses requestAnimationFrame. r249961 took care of moving RemoteLayerTreeDisplayRefreshMonitor
+objects from one RemoteLayerTreeDrawingArea to another but failed to tell those monitors
+about their new drawingArea. As a result, RemoteLayerTreeDrawingArea::willDestroyDisplayRefreshMonitor()
+would not get called on the new drawing area when it should have.
+
+* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
+* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:
+(WebKit::RemoteLayerTreeDisplayRefreshMonitor::updateDrawingArea):
+* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
+(WebKit::RemoteLayerTreeDrawingArea::adoptDisplayRefreshMonitorsFromDrawingArea):
+
2019-09-20 Keith Rollin
Remove some support for < iOS 13
Modified: trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h (250164 => 250165)
--- trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h 2019-09-20 23:18:30 UTC (rev 250164)
+++ trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h 2019-09-20 23:46:45 UTC (rev 250165)
@@ -44,6 +44,7
[webkit-changes] [250164] tags/Safari-608.3.3/
Title: [250164] tags/Safari-608.3.3/ Revision 250164 Author kocsen_ch...@apple.com Date 2019-09-20 16:18:30 -0700 (Fri, 20 Sep 2019) Log Message Tag Safari-608.3.3. Added Paths tags/Safari-608.3.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250163] tags/Safari-608.3.3/
Title: [250163] tags/Safari-608.3.3/ Revision 250163 Author kocsen_ch...@apple.com Date 2019-09-20 16:17:46 -0700 (Fri, 20 Sep 2019) Log Message Delete tag. Removed Paths tags/Safari-608.3.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250162] tags/Safari-608.3.3/
Title: [250162] tags/Safari-608.3.3/ Revision 250162 Author kocsen_ch...@apple.com Date 2019-09-20 16:16:39 -0700 (Fri, 20 Sep 2019) Log Message Tag Safari-608.3.3. Added Paths tags/Safari-608.3.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250161] trunk/Source/WebCore
Title: [250161] trunk/Source/WebCore
Revision 250161
Author krol...@apple.com
Date 2019-09-20 15:58:55 -0700 (Fri, 20 Sep 2019)
Log Message
Remove check of setSourceAppPid selector that's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=201971
Reviewed by Andy Estes.
Bug 172152 introduced a check of the NEFilterSource selector
setSourceAppPid in order to support OS's that didn't support it. All
supported Cocoa platforms now support it, so the check can be removed.
Source/WebCore:
No new tests -- no new or changed functionality.
* platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::initialize):
Source/WebCore/PAL:
* pal/spi/cocoa/NEFilterSourceSPI.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (250160 => 250161)
--- trunk/Source/WebCore/ChangeLog 2019-09-20 22:19:55 UTC (rev 250160)
+++ trunk/Source/WebCore/ChangeLog 2019-09-20 22:58:55 UTC (rev 250161)
@@ -1,5 +1,22 @@
2019-09-20 Keith Rollin
+Remove check of setSourceAppPid selector that's no longer needed
+https://bugs.webkit.org/show_bug.cgi?id=201971
+
+
+Reviewed by Andy Estes.
+
+Bug 172152 introduced a check of the NEFilterSource selector
+setSourceAppPid in order to support OS's that didn't support it. All
+supported Cocoa platforms now support it, so the check can be removed.
+
+No new tests -- no new or changed functionality.
+
+* platform/cocoa/NetworkExtensionContentFilter.mm:
+(WebCore::NetworkExtensionContentFilter::initialize):
+
+2019-09-20 Keith Rollin
+
Remove some support for < iOS 13
https://bugs.webkit.org/show_bug.cgi?id=201967
Modified: trunk/Source/WebCore/PAL/ChangeLog (250160 => 250161)
--- trunk/Source/WebCore/PAL/ChangeLog 2019-09-20 22:19:55 UTC (rev 250160)
+++ trunk/Source/WebCore/PAL/ChangeLog 2019-09-20 22:58:55 UTC (rev 250161)
@@ -1,5 +1,19 @@
2019-09-20 Keith Rollin
+Remove check of setSourceAppPid selector that's no longer needed
+https://bugs.webkit.org/show_bug.cgi?id=201971
+
+
+Reviewed by Andy Estes.
+
+Bug 172152 introduced a check of the NEFilterSource selector
+setSourceAppPid in order to support OS's that didn't support it. All
+supported Cocoa platforms now support it, so the check can be removed.
+
+* pal/spi/cocoa/NEFilterSourceSPI.h:
+
+2019-09-20 Keith Rollin
+
Remove some support for < iOS 13
https://bugs.webkit.org/show_bug.cgi?id=201967
Modified: trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm (250160 => 250161)
--- trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm 2019-09-20 22:19:55 UTC (rev 250160)
+++ trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm 2019-09-20 22:58:55 UTC (rev 250161)
@@ -43,11 +43,6 @@
SOFT_LINK_FRAMEWORK_OPTIONAL(NetworkExtension);
SOFT_LINK_CLASS_OPTIONAL(NetworkExtension, NEFilterSource);
-// FIXME: Remove this once -setSourceAppPid: is declared in an SDK used by the builders
-@interface NEFilterSource ()
-- (void)setSourceAppPid:(pid_t)sourceAppPid;
-@end
-
static inline NSData *replacementDataFromDecisionInfo(NSDictionary *decisionInfo)
{
ASSERT_WITH_SECURITY_IMPLICATION(!decisionInfo || [decisionInfo isKindOfClass:[NSDictionary class]]);
@@ -77,9 +72,7 @@
m_neFilterSource = adoptNS([allocNEFilterSourceInstance() initWithDecisionQueue:m_queue.get()]);
#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
[m_neFilterSource setSourceAppIdentifier:applicationBundleIdentifier()];
-// FIXME: Remove the -respondsToSelector: check once -setSourceAppPid: is defined in an SDK used by the builders.
-if ([m_neFilterSource respondsToSelector:@selector(setSourceAppPid:)])
-[m_neFilterSource setSourceAppPid:presentingApplicationPID()];
+[m_neFilterSource setSourceAppPid:presentingApplicationPID()];
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250160] trunk
Title: [250160] trunk Revision 250160 Author krol...@apple.com Date 2019-09-20 15:19:55 -0700 (Fri, 20 Sep 2019) Log Message Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=201967 Reviewed by Andy Estes. Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 13. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. After version checks have been removed, there are some cases where the preprocessor conditional looks like "#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)". These can be collapsed into "#if PLATFORM(COCOA)". This additional cleanup will be performed in a subsequent patch. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Andy Estes was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. Source/WebCore: No new tests -- no new or changed functionality. * platform/cocoa/NetworkExtensionContentFilter.mm: (WebCore::NetworkExtensionContentFilter::initialize): Source/WebCore/PAL: * pal/spi/cocoa/NEFilterSourceSPI.h: Source/WebKit: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _dataForPreviewItemController:atPosition:type:]): * UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel _uploadItemFromMediaInfo:successBlock:failureBlock:]): Source/WTF: * wtf/FeatureDefines.h: Tools: * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: Removed. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/FeatureDefines.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Removed Paths trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm Diff Modified: trunk/Source/WTF/ChangeLog (250159 => 250160) --- trunk/Source/WTF/ChangeLog 2019-09-20 21:51:36 UTC (rev 250159) +++ trunk/Source/WTF/ChangeLog 2019-09-20 22:19:55 UTC (rev 250160) @@ -1,6 +1,36 @@ 2019-09-20 Keith Rollin Remove some support for < iOS 13 +https://bugs.webkit.org/show_bug.cgi?id=201967 + + +Reviewed by Andy Estes. + +Remove some support for iOS versions less than 13.0. + +Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED +and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have +values >= 13. This means that expressions like +"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and +"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. + +After version checks have been removed, there are some cases where the +preprocessor conditional looks like "#if PLATFORM(MAC) || +PLATFORM(IOS_FAMILY)". These can be collapsed into "#if +PLATFORM(COCOA)". This additional cleanup will be performed in a +subsequent patch. + +This removal is part of a series of patches effecting the removal of +dead code for old versions of iOS. This particular pass involves +changes in which Andy Estes was involved. These changes are isolated +from other similar changes in order to facilitate the reviewing +process. + +* wtf/FeatureDefines.h: + +2019-09-20 Keith Rollin + +Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=201973 Modified: trunk/Source/WTF/wtf/FeatureDefines.h (250159 => 250160) --- trunk/Source/WTF/wtf/FeatureDefines.h 2019-09-20 21:51:36 UTC (rev 250159) +++ trunk/Source/WTF/wtf/FeatureDefines.h 2019-09-20 22:19:55 UTC (rev 250160) @@ -174,7 +174,7 @@ #endif #if !defined(HAVE_PDFHOSTVIEWCONTROLLER_SNAPSHOTTING) -#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13 +#if PLATFORM(IOS) #define HAVE_PDFHOSTVIEWCONTROLLER_SNAPSHOTTING 1 #endif #endif @@ -206,7 +206,7 @@ #endif #if !defined(HAVE_PASSKIT_BOUND_INTERFACE_IDENTIFIER) -#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 13 +#if PLATFORM(IOS) #define HAVE_PASSKIT_BOUND_INTERFACE_IDENTIFIER 1 #endif #endif Modified: trunk/Source/WebCore/ChangeLog (250159 => 250160) --- trunk/Source/WebCore/ChangeLog 2019-09-20 21:51:36 UTC (rev 250159) +++
[webkit-changes] [250159] branches/safari-608.2.11.1-branch/Source
Title: [250159] branches/safari-608.2.11.1-branch/Source Revision 250159 Author kocsen_ch...@apple.com Date 2019-09-20 14:51:36 -0700 (Fri, 20 Sep 2019) Log Message Versioning. Modified Paths branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (250158 => 250159) --- branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-09-20 21:50:11 UTC (rev 250158) +++ branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-09-20 21:51:36 UTC (rev 250159) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 9; +NANO_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (250158 => 250159) --- branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-09-20 21:50:11 UTC (rev 250158) +++ branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-09-20 21:51:36 UTC (rev 250159) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 9; +NANO_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig (250158 => 250159) --- branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig 2019-09-20 21:50:11 UTC (rev 250158) +++ branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig 2019-09-20 21:51:36 UTC (rev 250159) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 9; +NANO_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (250158 => 250159) --- branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-09-20 21:50:11 UTC (rev 250158) +++ branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-09-20 21:51:36 UTC (rev 250159) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 9; +NANO_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (250158 => 250159) --- branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-09-20 21:50:11 UTC (rev 250158) +++ branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-09-20 21:51:36 UTC (rev 250159) @@ -2,7 +2,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 9; +NANO_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig (250158 => 250159) --- branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig 2019-09-20 21:50:11 UTC (rev 250158) +++ branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig 2019-09-20 21:51:36 UTC (rev 250159) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 9; +NANO_VERSION = 10; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: br
[webkit-changes] [250158] tags/Safari-608.2.11.1.9/
Title: [250158] tags/Safari-608.2.11.1.9/ Revision 250158 Author kocsen_ch...@apple.com Date 2019-09-20 14:50:11 -0700 (Fri, 20 Sep 2019) Log Message Tag Safari-608.2.11.1.9. Added Paths tags/Safari-608.2.11.1.9/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250157] trunk/Source/WebKit
Title: [250157] trunk/Source/WebKit
Revision 250157
Author timothy_hor...@apple.com
Date 2019-09-20 14:49:30 -0700 (Fri, 20 Sep 2019)
Log Message
Sanitize suggested filenames used for saving PDFs
https://bugs.webkit.org/show_bug.cgi?id=202034
Reviewed by Chris Dumez.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishLoadingDataForCustomContentProvider):
(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Deleted.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Deleted.
Sanitize suggested filenames to ensure that they comprise only one path component
when concatenated with their destination directory.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (250156 => 250157)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 21:45:53 UTC (rev 250156)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 21:49:30 UTC (rev 250157)
@@ -1,3 +1,24 @@
+2019-09-20 Tim Horton
+
+Sanitize suggested filenames used for saving PDFs
+https://bugs.webkit.org/show_bug.cgi?id=202034
+
+
+Reviewed by Chris Dumez.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didFinishLoadingDataForCustomContentProvider):
+(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
+(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):
+* UIProcess/WebPageProxy.h:
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Deleted.
+* UIProcess/mac/WebPageProxyMac.mm:
+(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
+(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Deleted.
+Sanitize suggested filenames to ensure that they comprise only one path component
+when concatenated with their destination directory.
+
2019-09-20 Chris Dumez
Add release logging for when a view is added / removed from a window
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (250156 => 250157)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 21:45:53 UTC (rev 250156)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 21:49:30 UTC (rev 250157)
@@ -7684,7 +7684,7 @@
void WebPageProxy::didFinishLoadingDataForCustomContentProvider(const String& suggestedFilename, const IPC::DataReference& dataReference)
{
-pageClient().didFinishLoadingDataForCustomContentProvider(suggestedFilename, dataReference);
+pageClient().didFinishLoadingDataForCustomContentProvider(ResourceResponseBase::sanitizeSuggestedFilename(suggestedFilename), dataReference);
}
void WebPageProxy::backForwardRemovedItem(const BackForwardItemIdentifier& itemID)
@@ -7819,15 +7819,16 @@
void WebPageProxy::saveDataToFileInDownloadsFolder(String&& suggestedFilename, String&& mimeType, URL&& originatingURLString, API::Data& data)
{
-m_uiClient->saveDataToFileInDownloadsFolder(this, suggestedFilename, mimeType, originatingURLString, data);
+m_uiClient->saveDataToFileInDownloadsFolder(this, ResourceResponseBase::sanitizeSuggestedFilename(suggestedFilename), mimeType, originatingURLString, data);
}
void WebPageProxy::savePDFToFileInDownloadsFolder(String&& suggestedFilename, URL&& originatingURL, const IPC::DataReference& dataReference)
{
-if (!suggestedFilename.endsWithIgnoringASCIICase(".pdf"))
+String sanitizedFilename = ResourceResponseBase::sanitizeSuggestedFilename(suggestedFilename);
+if (!sanitizedFilename.endsWithIgnoringASCIICase(".pdf"))
return;
-saveDataToFileInDownloadsFolder(WTFMove(suggestedFilename), "application/pdf"_s, WTFMove(originatingURL),
+saveDataToFileInDownloadsFolder(WTFMove(sanitizedFilename), "application/pdf"_s, WTFMove(originatingURL),
API::Data::create(dataReference.data(), dataReference.size()).get());
}
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (250156 => 250157)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-09-20 21:45:53 UTC (rev 250156)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-09-20 21:49:30 UTC (rev 250157)
@@ -1193,7 +1193,6 @@
void saveDataToFileInDownloadsFolder(String&& suggestedFilename, String&& mimeType, URL&& originatingURL, API::Data&);
void savePDFToFileInDownloadsFolder(String&& suggestedFilename, URL&& originatingURL, const IPC::DataReference&);
#if PLA
[webkit-changes] [250156] trunk/Tools
Title: [250156] trunk/Tools
Revision 250156
Author achristen...@apple.com
Date 2019-09-20 14:45:53 -0700 (Fri, 20 Sep 2019)
Log Message
Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
https://bugs.webkit.org/show_bug.cgi?id=202025
Reviewed by Chris Dumez.
One expected change in behavior is that the resource load statistics directory is not created on startup with an ephemeral session any more
because we call the constructor of WebsiteDataStoreConfiguration inside _WKWebsiteDataStoreConfiguration and set the default directory like we do the other directories.
* TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::websiteDataStore):
(WTR::TestController::generatePageConfiguration):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
trunk/Tools/WebKitTestRunner/TestController.cpp
Diff
Modified: trunk/Tools/ChangeLog (250155 => 250156)
--- trunk/Tools/ChangeLog 2019-09-20 21:40:23 UTC (rev 250155)
+++ trunk/Tools/ChangeLog 2019-09-20 21:45:53 UTC (rev 250156)
@@ -1,3 +1,18 @@
+2019-09-20 Alex Christensen
+
+Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
+https://bugs.webkit.org/show_bug.cgi?id=202025
+
+Reviewed by Chris Dumez.
+
+One expected change in behavior is that the resource load statistics directory is not created on startup with an ephemeral session any more
+because we call the constructor of WebsiteDataStoreConfiguration inside _WKWebsiteDataStoreConfiguration and set the default directory like we do the other directories.
+
+* TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::websiteDataStore):
+(WTR::TestController::generatePageConfiguration):
+
2019-09-20 Keith Rollin
Remove some support for < iOS 13
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm (250155 => 250156)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm 2019-09-20 21:40:23 UTC (rev 250155)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm 2019-09-20 21:45:53 UTC (rev 250156)
@@ -225,15 +225,17 @@
TEST(WebKit, QuotaDelegate)
{
done = false;
-[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
+_WKWebsiteDataStoreConfiguration *storeConfiguration = [[[_WKWebsiteDataStoreConfiguration alloc] init] autorelease];
+storeConfiguration.perOriginStorageQuota = 1024 * 400;
+WKWebsiteDataStore *dataStore = [[[WKWebsiteDataStore alloc] _initWithConfiguration:storeConfiguration] autorelease];
+[dataStore removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
done = true;
}];
TestWebKitAPI::Util::run(&done);
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
+[configuration setWebsiteDataStore:dataStore];
-[[configuration websiteDataStore] _setPerOriginStorageQuota: 1024 * 400];
-
auto messageHandler = adoptNS([[QuotaMessageHandler alloc] init]);
[[configuration userContentController] addScriptMessageHandler:messageHandler.get() name:@"qt"];
@@ -286,15 +288,17 @@
TEST(WebKit, QuotaDelegateReload)
{
done = false;
-[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
+_WKWebsiteDataStoreConfiguration *storeConfiguration = [[[_WKWebsiteDataStoreConfiguration alloc] init] autorelease];
+storeConfiguration.perOriginStorageQuota = 1024 * 400;
+WKWebsiteDataStore *dataStore = [[[WKWebsiteDataStore alloc] _initWithConfiguration:storeConfiguration] autorelease];
+[dataStore removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
done = true;
}];
TestWebKitAPI::Util::run(&done);
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
+[configuration setWebsiteDataStore:dataStore];
-[[configuration websiteDataStore] _setPerOriginStorageQuota: 1024 * 400];
-
auto messageHandler = adoptNS([[QuotaMessageHandler alloc] init]);
[[configuration userContentController] addScriptMessageHandler:messageHandler.get() name:@"qt"];
@@ -332,15 +336,17 @@
TEST(WebKit, QuotaDelegateNavigateFragment)
{
done = false;
-[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
+_WKWebsiteDataStoreConfiguration *storeConfiguration = [[[_WKWebsiteDataStoreConfiguration alloc] init] autorelease];
+s
[webkit-changes] [250155] trunk/Source/WebKit
Title: [250155] trunk/Source/WebKit Revision 250155 Author cdu...@apple.com Date 2019-09-20 14:40:23 -0700 (Fri, 20 Sep 2019) Log Message Add release logging for when a view is added / removed from a window https://bugs.webkit.org/show_bug.cgi?id=202050 Reviewed by Tim Horton. Add release logging for when a view is added / removed from a window to help determine the view's visibility in the logs. * UIProcess/ios/WKApplicationStateTrackingView.mm: (-[WKApplicationStateTrackingView willMoveToWindow:]): (-[WKApplicationStateTrackingView didMoveToWindow]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm Diff Modified: trunk/Source/WebKit/ChangeLog (250154 => 250155) --- trunk/Source/WebKit/ChangeLog 2019-09-20 21:37:24 UTC (rev 250154) +++ trunk/Source/WebKit/ChangeLog 2019-09-20 21:40:23 UTC (rev 250155) @@ -1,5 +1,19 @@ 2019-09-20 Chris Dumez +Add release logging for when a view is added / removed from a window +https://bugs.webkit.org/show_bug.cgi?id=202050 + +Reviewed by Tim Horton. + +Add release logging for when a view is added / removed from a window to help determine the +view's visibility in the logs. + +* UIProcess/ios/WKApplicationStateTrackingView.mm: +(-[WKApplicationStateTrackingView willMoveToWindow:]): +(-[WKApplicationStateTrackingView didMoveToWindow]): + +2019-09-20 Chris Dumez + ApplicationStateTracker::m_isBackground initialization does not account for UIScenes https://bugs.webkit.org/show_bug.cgi?id=202048 Modified: trunk/Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm (250154 => 250155) --- trunk/Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm 2019-09-20 21:37:24 UTC (rev 250154) +++ trunk/Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm 2019-09-20 21:40:23 UTC (rev 250155) @@ -29,6 +29,7 @@ #if PLATFORM(IOS_FAMILY) #import "ApplicationStateTracker.h" +#import "Logging.h" #import "WKWebViewInternal.h" #import "WebPageProxy.h" #import @@ -56,6 +57,8 @@ _lastObservedStateWasBackground = [self isBackground]; +auto page = [_webViewToTrack _page]; +RELEASE_LOG(ViewState, "%p - WKApplicationStateTrackingView: View with page [%p, pageProxyID: %" PRIu64 "] was removed from a window, _lastObservedStateWasBackground: %d", self, page, page ? page->identifier().toUInt64() : 0, _lastObservedStateWasBackground); ASSERT(_applicationStateTracker); _applicationStateTracker = nullptr; } @@ -65,6 +68,8 @@ if (!self._contentView.window || _applicationStateTracker) return; +auto page = [_webViewToTrack _page]; +RELEASE_LOG(ViewState, "%p - WKApplicationStateTrackingView: View with page [%p, pageProxyID: %" PRIu64 "] was added to a window, _lastObservedStateWasBackground: %d, isNowBackground: %d", self, page, page ? page->identifier().toUInt64() : 0, _lastObservedStateWasBackground, [self isBackground]); _applicationStateTracker = makeUnique(self, @selector(_applicationDidEnterBackground), @selector(_applicationDidFinishSnapshottingAfterEnteringBackground), @selector(_applicationWillEnterForeground)); if (_lastObservedStateWasBackground && ![self isBackground]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250154] trunk/Source/WebKit
Title: [250154] trunk/Source/WebKit
Revision 250154
Author cdu...@apple.com
Date 2019-09-20 14:37:24 -0700 (Fri, 20 Sep 2019)
Log Message
ApplicationStateTracker::m_isBackground initialization does not account for UIScenes
https://bugs.webkit.org/show_bug.cgi?id=202048
Reviewed by Geoffrey Garen.
ApplicationStateTracker::m_isBackground initialization does not account for UIScenes, it merely checks
the visibility state of the whole app. It should instead check the visibility state of the window's
UIScene.
This patch also refactors the code a little bit to reduce #ifdef'ing.
* UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::ApplicationStateTracker):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ApplicationStateTracker.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (250153 => 250154)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 21:35:58 UTC (rev 250153)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 21:37:24 UTC (rev 250154)
@@ -1,5 +1,21 @@
2019-09-20 Chris Dumez
+ApplicationStateTracker::m_isBackground initialization does not account for UIScenes
+https://bugs.webkit.org/show_bug.cgi?id=202048
+
+Reviewed by Geoffrey Garen.
+
+ApplicationStateTracker::m_isBackground initialization does not account for UIScenes, it merely checks
+the visibility state of the whole app. It should instead check the visibility state of the window's
+UIScene.
+
+This patch also refactors the code a little bit to reduce #ifdef'ing.
+
+* UIProcess/ApplicationStateTracker.mm:
+(WebKit::ApplicationStateTracker::ApplicationStateTracker):
+
+2019-09-20 Chris Dumez
+
Document no longer needs to store a SessionID
https://bugs.webkit.org/show_bug.cgi?id=202024
Modified: trunk/Source/WebKit/UIProcess/ApplicationStateTracker.mm (250153 => 250154)
--- trunk/Source/WebKit/UIProcess/ApplicationStateTracker.mm 2019-09-20 21:35:58 UTC (rev 250153)
+++ trunk/Source/WebKit/UIProcess/ApplicationStateTracker.mm 2019-09-20 21:37:24 UTC (rev 250154)
@@ -88,7 +88,7 @@
ASSERT([m_view.get() respondsToSelector:m_willEnterForegroundSelector]);
UIWindow *window = [m_view.get() window];
-ASSERT(window);
+RELEASE_ASSERT(window);
NSNotificationCenter *notificationCenter = [NSNotificationCenter defaultCenter];
UIApplication *application = [UIApplication sharedApplication];
@@ -104,28 +104,33 @@
switch (applicationType(window)) {
case ApplicationType::Application: {
-m_isInBackground = application.applicationState == UIApplicationStateBackground;
-RELEASE_LOG(ProcessSuspension, "%p - ApplicationStateTracker::ApplicationStateTracker(): m_isInBackground: %d", this, m_isInBackground);
+#if HAVE(UISCENE)
+m_isInBackground = window.windowScene.activationState == UISceneActivationStateBackground || window.windowScene.activationState == UISceneActivationStateUnattached;
+RELEASE_LOG(ViewState, "%p - ApplicationStateTracker::ApplicationStateTracker(): m_isInBackground: %d", this, m_isInBackground);
-#if HAVE(UISCENE)
m_didEnterBackgroundObserver = [notificationCenter addObserverForName:UISceneDidEnterBackgroundNotification object:window.windowScene queue:nil usingBlock:[this](NSNotification *) {
-RELEASE_LOG(ProcessSuspension, "%p - ApplicationStateTracker: UISceneDidEnterBackground", this);
+RELEASE_LOG(ViewState, "%p - ApplicationStateTracker: UISceneDidEnterBackground", this);
+applicationDidEnterBackground();
+}];
+
+m_willEnterForegroundObserver = [notificationCenter addObserverForName:UISceneWillEnterForegroundNotification object:window.windowScene queue:nil usingBlock:[this](NSNotification *) {
+RELEASE_LOG(ViewState, "%p - ApplicationStateTracker: UISceneWillEnterForeground", this);
+applicationWillEnterForeground();
+}];
#else
+m_isInBackground = application.applicationState == UIApplicationStateBackground;
+RELEASE_LOG(ViewState, "%p - ApplicationStateTracker::ApplicationStateTracker(): m_isInBackground: %d", this, m_isInBackground);
+
m_didEnterBackgroundObserver = [notificationCenter addObserverForName:UIApplicationDidEnterBackgroundNotification object:application queue:nil usingBlock:[this](NSNotification *) {
-RELEASE_LOG(ProcessSuspension, "%p - ApplicationStateTracker: UIApplicationDidEnterBackground", this);
-#endif
+RELEASE_LOG(ViewState, "%p - ApplicationStateTracker: UIApplicationDidEnterBackground", this);
applicationDidEnterBackground();
}];
-#if HAVE(UISCENE)
-m_willEnterForegroundObserver = [notificationCenter addObserverForName:UISceneWillEnterForegroundNotification object:window.windowScene queue:nil usingBlock:[this](NSNotification *) {
-RELEASE_LOG(ProcessSuspension, "%p - ApplicationStateTracker: UISceneWil
[webkit-changes] [250153] trunk/Source
Title: [250153] trunk/Source Revision 250153 Author cdu...@apple.com Date 2019-09-20 14:35:58 -0700 (Fri, 20 Sep 2019) Log Message Document no longer needs to store a SessionID https://bugs.webkit.org/show_bug.cgi?id=202024 Reviewed by Geoffrey Garen. Document no longer needs to store a SessionID, now that we have a single session per WebProcess. It can simply get its sessionID from its Page. Source/WebCore: * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::create): * Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpenSocketStream): * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): * dom/DOMImplementation.cpp: (WebCore::createXMLDocument): (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument): * dom/DOMImplementation.h: * dom/Document.cpp: (WebCore::Document::Document): (WebCore::m_undoManager): (WebCore::Document::create): (WebCore::Document::createNonRenderedPlaceholder): (WebCore::Document::cloneDocumentWithoutChildren const): (WebCore::Document::sessionID const): (WebCore::Document::privateBrowsingStateDidChange): (WebCore::Document::ensureTemplateDocument): (WebCore::Document::logger): (WebCore::Document::didLogMessage): * dom/Document.h: (WebCore::Document::create): * dom/XMLDocument.h: (WebCore::XMLDocument::create): (WebCore::XMLDocument::createXHTML): (WebCore::XMLDocument::XMLDocument): * html/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::FTPDirectoryDocument): * html/FTPDirectoryDocument.h: * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseAdClickAttribution const): * html/HTMLDocument.cpp: (WebCore::HTMLDocument::createSynthesizedDocument): (WebCore::HTMLDocument::HTMLDocument): (WebCore::HTMLDocument::cloneDocumentWithoutChildren const): * html/HTMLDocument.h: (WebCore::HTMLDocument::create): * html/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument): * html/MediaDocument.cpp: (WebCore::MediaDocument::MediaDocument): * html/MediaDocument.h: * html/PluginDocument.cpp: (WebCore::PluginDocument::PluginDocument): * html/TextDocument.cpp: (WebCore::TextDocument::TextDocument): * html/TextDocument.h: * inspector/DOMPatchSupport.cpp: (WebCore::DOMPatchSupport::patchDocument): * loader/CookieJar.cpp: (WebCore::CookieJar::cookieRequestHeaderFieldProxy): (WebCore::CookieJar::cookieRequestHeaderFieldValue const): * loader/CookieJar.h: * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): * loader/SinkDocument.cpp: (WebCore::SinkDocument::SinkDocument): * loader/cache/CachedResource.cpp: (WebCore::CachedResource::setResponse): (WebCore::CachedResource::varyHeaderValuesMatch): * loader/cache/CachedSVGDocument.cpp: (WebCore::CachedSVGDocument::finishLoading): * loader/cache/CachedSVGFont.cpp: (WebCore::CachedSVGFont::ensureCustomFontData): * page/Page.cpp: (WebCore::Page::configureLoggingChannel): * platform/network/CacheValidation.cpp: (WebCore::cookieRequestHeaderFieldValue): (WebCore::collectVaryingRequestHeaders): (WebCore::verifyVaryingRequestHeaders): * platform/network/CacheValidation.h: * svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument): (WebCore::SVGDocument::cloneDocumentWithoutChildren const): * svg/SVGDocument.h: (WebCore::SVGDocument::create): * workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::isAlwaysOnLoggingAllowed const): * worklets/WorkletGlobalScope.cpp: (WebCore::WorkletGlobalScope::WorkletGlobalScope): * worklets/WorkletGlobalScope.h: * xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): * xml/DOMParser.h: * xml/DOMParser.idl: * xml/XMLHttpRequest.cpp: * xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Source/WebKit: * WebProcess/WebPage/WebCookieJar.cpp: (WebKit::WebCookieJar::cookieRequestHeaderFieldValue const): * WebProcess/WebPage/WebCookieJar.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm trunk/Source/WebCore/dom/DOMImplementation.cpp trunk/Source/WebCore/dom/DOMImplementation.h trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/XMLDocument.h trunk/Source/WebCore/html/FTPDirectoryDocument.cpp trunk/Source/WebCore/html/FTPDirectoryDocument.h trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/html/HTMLDocument.cpp trunk/Source/WebCore/html/HTMLDocument.h trunk/Source/WebCore/html/ImageDocument.cpp trunk/Source/WebCore/html/MediaDocument.cpp trunk/Source/WebCore/html/MediaDocument.h trunk/Source/WebCore/html/PluginDocument.cpp trunk/Source/WebCore/html/TextDocument.cpp trunk/Source/WebCore/html/TextDocument.h trunk/Source/WebCore/inspector/DOMPatchSupport.cpp trunk/Source/WebCore/loader/CookieJar.cpp trunk/Source/WebCore/loader
[webkit-changes] [250152] trunk
Title: [250152] trunk
Revision 250152
Author drou...@apple.com
Date 2019-09-20 14:23:20 -0700 (Fri, 20 Sep 2019)
Log Message
Web Inspector: HTML Formatter - better indentation/newline handling for self closing tags
https://bugs.webkit.org/show_bug.cgi?id=202036
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
* UserInterface/Workers/Formatter/HTMLFormatter.js:
(HTMLFormatter.prototype._before):
LayoutTests:
* inspector/formatting/formatting-xml.html:
* inspector/formatting/formatting-xml-expected.txt:
* inspector/formatting/resources/xml-tests/self-closing.xml: Added.
* inspector/formatting/resources/xml-tests/self-closing-expected.xml: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/formatting/formatting-xml-expected.txt
trunk/LayoutTests/inspector/formatting/formatting-xml.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLFormatter.js
Added Paths
trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing-expected.xml
trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing.xml
Diff
Modified: trunk/LayoutTests/ChangeLog (250151 => 250152)
--- trunk/LayoutTests/ChangeLog 2019-09-20 21:06:26 UTC (rev 250151)
+++ trunk/LayoutTests/ChangeLog 2019-09-20 21:23:20 UTC (rev 250152)
@@ -1,3 +1,15 @@
+2019-09-20 Devin Rousso
+
+Web Inspector: HTML Formatter - better indentation/newline handling for self closing tags
+https://bugs.webkit.org/show_bug.cgi?id=202036
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/formatting/formatting-xml.html:
+* inspector/formatting/formatting-xml-expected.txt:
+* inspector/formatting/resources/xml-tests/self-closing.xml: Added.
+* inspector/formatting/resources/xml-tests/self-closing-expected.xml: Added.
+
2019-09-20 Truitt Savell
Unreviewed, rolling out r250114.
Modified: trunk/LayoutTests/inspector/formatting/formatting-xml-expected.txt (250151 => 250152)
--- trunk/LayoutTests/inspector/formatting/formatting-xml-expected.txt 2019-09-20 21:06:26 UTC (rev 250151)
+++ trunk/LayoutTests/inspector/formatting/formatting-xml-expected.txt 2019-09-20 21:23:20 UTC (rev 250152)
@@ -6,6 +6,7 @@
PASS: atom.xml
PASS: basic.xml
PASS: rss.xml
+PASS: self-closing.xml
PASS: tag-case.xml
PASS: valid-html-invalid-xml.xml
PASS: xslt.xml
Modified: trunk/LayoutTests/inspector/formatting/formatting-xml.html (250151 => 250152)
--- trunk/LayoutTests/inspector/formatting/formatting-xml.html 2019-09-20 21:06:26 UTC (rev 250151)
+++ trunk/LayoutTests/inspector/formatting/formatting-xml.html 2019-09-20 21:23:20 UTC (rev 250152)
@@ -12,6 +12,7 @@
"resources/xml-tests/atom.xml",
"resources/xml-tests/basic.xml",
"resources/xml-tests/rss.xml",
+"resources/xml-tests/self-closing.xml",
"resources/xml-tests/tag-case.xml",
"resources/xml-tests/valid-html-invalid-xml.xml",
"resources/xml-tests/xslt.xml",
Added: trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing-expected.xml (0 => 250152)
--- trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing-expected.xml (rev 0)
+++ trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing-expected.xml 2019-09-20 21:23:20 UTC (rev 250152)
@@ -0,0 +1,11 @@
+
+
+
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing.xml (0 => 250152)
--- trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing.xml (rev 0)
+++ trunk/LayoutTests/inspector/formatting/resources/xml-tests/self-closing.xml 2019-09-20 21:23:20 UTC (rev 250152)
@@ -0,0 +1 @@
+
\ No newline at end of file
Modified: trunk/Source/WebInspectorUI/ChangeLog (250151 => 250152)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-09-20 21:06:26 UTC (rev 250151)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-09-20 21:23:20 UTC (rev 250152)
@@ -1,3 +1,13 @@
+2019-09-20 Devin Rousso
+
+Web Inspector: HTML Formatter - better indentation/newline handling for self closing tags
+https://bugs.webkit.org/show_bug.cgi?id=202036
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Workers/Formatter/HTMLFormatter.js:
+(HTMLFormatter.prototype._before):
+
2019-09-20 Joseph Pecoraro
Web Inspector: Remove BranchManager in favor of just using currentRevision
Modified: trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLFormatter.js (250151 => 250152)
--- trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLFormatter.js 2019-09-20 21:06:26 UTC (rev 250151)
+++ trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLFormatter.js 2019-09-20 21:23:20 UTC (rev 250152)
@@ -208,7 +208,7 @@
this._builder.appendNonToken("/");
this._builder.appendNonToken(">");
-if (node._
[webkit-changes] [250151] trunk/Source/WebKit
Title: [250151] trunk/Source/WebKit
Revision 250151
Author cdu...@apple.com
Date 2019-09-20 14:06:26 -0700 (Fri, 20 Sep 2019)
Log Message
[iOS] ASSERTION FAILED: Unsafe to ref/deref of ShareableBitmap from different threads
https://bugs.webkit.org/show_bug.cgi?id=201712
Reviewed by Tim Horton.
Make sure ShareableBitmap objects are always ref'd / deref'd on the main thread by dispatching to
the main thread in ShareableBitmap::releaseBitmapContextData() before calling deref().
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::ShareableBitmap):
(WebKit::ShareableBitmap::~ShareableBitmap):
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::releaseBitmapContextData):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/ShareableBitmap.cpp
trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (250150 => 250151)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 21:01:10 UTC (rev 250150)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 21:06:26 UTC (rev 250151)
@@ -1,3 +1,21 @@
+2019-09-20 Chris Dumez
+
+[iOS] ASSERTION FAILED: Unsafe to ref/deref of ShareableBitmap from different threads
+https://bugs.webkit.org/show_bug.cgi?id=201712
+
+
+Reviewed by Tim Horton.
+
+Make sure ShareableBitmap objects are always ref'd / deref'd on the main thread by dispatching to
+the main thread in ShareableBitmap::releaseBitmapContextData() before calling deref().
+
+* Shared/ShareableBitmap.cpp:
+(WebKit::ShareableBitmap::ShareableBitmap):
+(WebKit::ShareableBitmap::~ShareableBitmap):
+* Shared/cg/ShareableBitmapCG.cpp:
+(WebKit::ShareableBitmap::createGraphicsContext):
+(WebKit::ShareableBitmap::releaseBitmapContextData):
+
2019-09-20 Alex Christensen
Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
Modified: trunk/Source/WebKit/Shared/ShareableBitmap.cpp (250150 => 250151)
--- trunk/Source/WebKit/Shared/ShareableBitmap.cpp 2019-09-20 21:01:10 UTC (rev 250150)
+++ trunk/Source/WebKit/Shared/ShareableBitmap.cpp 2019-09-20 21:06:26 UTC (rev 250151)
@@ -163,6 +163,7 @@
, m_configuration(configuration)
, m_data(data)
{
+ASSERT(RunLoop::isMain());
}
ShareableBitmap::ShareableBitmap(const IntSize& size, Configuration configuration, RefPtr sharedMemory)
@@ -171,6 +172,8 @@
, m_sharedMemory(sharedMemory)
, m_data(nullptr)
{
+ASSERT(RunLoop::isMain());
+
#if USE(DIRECT2D)
createSharedResource();
#endif
@@ -178,6 +181,8 @@
ShareableBitmap::~ShareableBitmap()
{
+ASSERT(RunLoop::isMain());
+
if (!isBackedBySharedMemory())
fastFree(m_data);
#if USE(DIRECT2D)
Modified: trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp (250150 => 250151)
--- trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp 2019-09-20 21:01:10 UTC (rev 250150)
+++ trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp 2019-09-20 21:06:26 UTC (rev 250151)
@@ -87,6 +87,7 @@
std::unique_ptr ShareableBitmap::createGraphicsContext()
{
+ASSERT(RunLoop::isMain());
ref(); // Balanced by deref in releaseBitmapContextData.
unsigned bytesPerPixel = calculateBytesPerPixel(m_configuration);
@@ -141,6 +142,13 @@
void ShareableBitmap::releaseBitmapContextData(void* typelessBitmap, void* typelessData)
{
+if (!RunLoop::isMain()) {
+RunLoop::main().dispatch([typelessBitmap, typelessData] {
+releaseBitmapContextData(typelessBitmap, typelessData);
+});
+return;
+}
+
ShareableBitmap* bitmap = static_cast(typelessBitmap);
ASSERT_UNUSED(typelessData, bitmap->data() == typelessData);
bitmap->deref(); // Balanced by ref in createGraphicsContext.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250150] trunk/Source/WebKit
Title: [250150] trunk/Source/WebKit Revision 250150 Author achristen...@apple.com Date 2019-09-20 14:01:10 -0700 (Fri, 20 Sep 2019) Log Message Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration https://bugs.webkit.org/show_bug.cgi?id=202025 Reviewed by Chris Dumez. Most of these were only needed before initNonPersistentConfiguration existed. * UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp: (WKWebsiteDataStoreConfigurationGetPerOriginStorageQuota): (WKWebsiteDataStoreConfigurationSetPerOriginStorageQuota): * UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h: * UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetPerOriginStorageQuota): * UIProcess/API/C/WKWebsiteDataStoreRef.h: * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _initWithConfiguration:]): (-[WKWebsiteDataStore _perOriginStorageQuota]): (-[WKWebsiteDataStore _setPerOriginStorageQuota:]): * UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: (-[_WKWebsiteDataStoreConfiguration perOriginStorageQuota]): (-[_WKWebsiteDataStoreConfiguration setPerOriginStorageQuota:]): (-[_WKWebsiteDataStoreConfiguration boundInterfaceIdentifier]): (-[_WKWebsiteDataStoreConfiguration setBoundInterfaceIdentifier:]): (-[_WKWebsiteDataStoreConfiguration allowsCellularAccess]): (-[_WKWebsiteDataStoreConfiguration setAllowsCellularAccess:]): (-[_WKWebsiteDataStoreConfiguration proxyConfiguration]): (-[_WKWebsiteDataStoreConfiguration setProxyConfiguration:]): * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier): (WebKit::WebsiteDataStore::setSourceApplicationBundleIdentifier): * UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::setBoundInterfaceIdentifier): (WebKit::WebsiteDataStore::boundInterfaceIdentifier): (WebKit::WebsiteDataStore::sourceApplicationBundleIdentifier const): (WebKit::WebsiteDataStore::sourceApplicationSecondaryIdentifier const): (WebKit::WebsiteDataStore::setAllowsCellularAccess): (WebKit::WebsiteDataStore::allowsCellularAccess): (WebKit::WebsiteDataStore::setProxyConfiguration): (WebKit::WebsiteDataStore::proxyConfiguration): (WebKit::WebsiteDataStore::setPerOriginStorageQuota): Deleted. * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::copy): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: (WebKit::WebsiteDataStoreConfiguration::boundInterfaceIdentifier const): (WebKit::WebsiteDataStoreConfiguration::setBoundInterfaceIdentifier): (WebKit::WebsiteDataStoreConfiguration::allowsCellularAccess const): (WebKit::WebsiteDataStoreConfiguration::setAllowsCellularAccess): (WebKit::WebsiteDataStoreConfiguration::proxyConfiguration const): (WebKit::WebsiteDataStoreConfiguration::setProxyConfiguration): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h Diff Modified: trunk/Source/WebKit/ChangeLog (250149 => 250150) --- trunk/Source/WebKit/ChangeLog 2019-09-20 20:49:47 UTC (rev 250149) +++ trunk/Source/WebKit/ChangeLog 2019-09-20 21:01:10 UTC (rev 250150) @@ -1,5 +1,62 @@ 2019-09-20 Alex Christensen +Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration +https://bugs.webkit.org/show_bug.cgi?id=202025 + +Reviewed by Chris Dumez. + +Most of these were only needed before initNonPersistentConfiguration existed. + +* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp: +(WKWebsiteDataStoreConfigurationGetPerOriginStorageQuota): +(WKWebsiteDataStoreConfigurationSetPerOriginStorageQuota): +* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h: +* UIProcess/API/C/WKWebsiteDataStoreRef.cpp: +(WKWebsiteDataStoreSetPerOriginStorageQuota): +* UIProcess/API/C/WK
[webkit-changes] [250149] trunk/Source/WebInspectorUI
Title: [250149] trunk/Source/WebInspectorUI Revision 250149 Author pecor...@apple.com Date 2019-09-20 13:49:47 -0700 (Fri, 20 Sep 2019) Log Message Web Inspector: Remove BranchManager in favor of just using currentRevision https://bugs.webkit.org/show_bug.cgi?id=202000 Reviewed by Devin Rousso. Remove BranchManager. The Branch concept never got fleshed out, and would likely be too complex for the average case. Local Overrides are simpler. In the interest of expanding Local Overrides to more content lets simply by removing Branches. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Base/Main.js: (WI.loaded): * UserInterface/Controllers/BranchManager.js: Removed. * UserInterface/Controllers/CSSManager.js: (WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges.styleSheetFound): (WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges): (WI.CSSManager.prototype._resourceContentDidChange): (WI.CSSManager.prototype._updateResourceContent.fetchedStyleSheetContent): * UserInterface/Main.html: * UserInterface/Models/Branch.js: Removed. * UserInterface/Models/SourceCode.js: (WI.SourceCode.prototype._processContent): (WI.SourceCode): * UserInterface/Views/TextResourceContentView.js: (WI.TextResourceContentView.prototype._textEditorContentDidChange): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Base/Main.js trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Models/SourceCode.js trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js Removed Paths trunk/Source/WebInspectorUI/UserInterface/Controllers/BranchManager.js trunk/Source/WebInspectorUI/UserInterface/Models/Branch.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (250148 => 250149) --- trunk/Source/WebInspectorUI/ChangeLog 2019-09-20 20:36:57 UTC (rev 250148) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-09-20 20:49:47 UTC (rev 250149) @@ -1,3 +1,32 @@ +2019-09-20 Joseph Pecoraro + +Web Inspector: Remove BranchManager in favor of just using currentRevision +https://bugs.webkit.org/show_bug.cgi?id=202000 + +Reviewed by Devin Rousso. + +Remove BranchManager. The Branch concept never got fleshed out, and would +likely be too complex for the average case. Local Overrides are simpler. +In the interest of expanding Local Overrides to more content lets simply +by removing Branches. + +* Localizations/en.lproj/localizedStrings.js: +* UserInterface/Base/Main.js: +(WI.loaded): +* UserInterface/Controllers/BranchManager.js: Removed. +* UserInterface/Controllers/CSSManager.js: +(WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges.styleSheetFound): +(WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges): +(WI.CSSManager.prototype._resourceContentDidChange): +(WI.CSSManager.prototype._updateResourceContent.fetchedStyleSheetContent): +* UserInterface/Main.html: +* UserInterface/Models/Branch.js: Removed. +* UserInterface/Models/SourceCode.js: +(WI.SourceCode.prototype._processContent): +(WI.SourceCode): +* UserInterface/Views/TextResourceContentView.js: +(WI.TextResourceContentView.prototype._textEditorContentDidChange): + 2019-09-20 Truitt Savell Unreviewed, rolling out r250114. Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (250148 => 250149) --- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-09-20 20:36:57 UTC (rev 250148) +++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-09-20 20:49:47 UTC (rev 250149) @@ -773,7 +773,6 @@ localizedStrings["Open in New Tab"] = "Open in New Tab"; localizedStrings["Option-click to show source"] = "Option-click to show source"; localizedStrings["Options"] = "Options"; -localizedStrings["Original"] = "Original"; localizedStrings["Original formatting"] = "Original formatting"; localizedStrings["Originally %s"] = "Originally %s"; localizedStrings["Originator"] = "Originator"; @@ -1013,7 +1012,6 @@ localizedStrings["Show Grid"] = "Show Grid"; localizedStrings["Show Icons"] = "Show Icons"; localizedStrings["Show Jump to Effective Property Button"] = "Show Jump to Effective Property Button"; -localizedStrings["Show More"] = "Show More"; localizedStrings["Show Path"] = "Show Path"; localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)"; localizedStrings["Show Scope Chain on pause"] = "Show Scope Chain on pause"; @@ -1256,7 +1254,6 @@ localizedStrings["Worker Threads"] = "Worker Threads"; localizedStrings["Worker \u2014 %s"] = "Worker \u2014 %s"; localizedStrings["Worker
[webkit-changes] [250148] trunk/Source/WebKit
Title: [250148] trunk/Source/WebKit Revision 250148 Author achristen...@apple.com Date 2019-09-20 13:36:57 -0700 (Fri, 20 Sep 2019) Log Message Introduce LegacyGlobalSettings for settings the NetworkProcess needs from a WebProcessPool https://bugs.webkit.org/show_bug.cgi?id=201970 Reviewed by Geoff Garen. I'm starting by moving the cache model to this new abstraction. We were using it in tests to disable the page cache, which should be done with a boolean on the pool configuration, not by changing the cache model. We were also using it in WKContextSetCacheModel which has several clients that won't change quickly, so this abstraction is used to maintain existing behavior. I need this so I can make a NetworkProcess not depend on anything from a WebProcessPool when starting. * Sources.txt: * UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::copy): * UIProcess/API/APIProcessPoolConfiguration.h: * UIProcess/API/C/WKContext.cpp: (WKContextSetCacheModel): (WKContextGetCacheModel): * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: (-[_WKProcessPoolConfiguration pageCacheEnabled]): (-[_WKProcessPoolConfiguration setPageCacheEnabled:]): * UIProcess/LegacyGlobalSettings.cpp: Added. (WebKit::LegacyGlobalSettings::singleton): (WebKit::LegacyGlobalSettings::setCacheModel): * UIProcess/LegacyGlobalSettings.h: Added. (WebKit::LegacyGlobalSettings::cacheModel const): * UIProcess/WebProcessCache.cpp: (WebKit::WebProcessCache::updateCapacity): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess): (WebKit::WebProcessPool::initializeNewWebProcess): (WebKit::WebProcessPool::updateMaxSuspendedPageCount): (WebKit::WebProcessPool::setCacheModel): * UIProcess/WebProcessPool.h: * WebKit.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Sources.txt trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm trunk/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp trunk/Source/WebKit/UIProcess/WebProcessCache.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.h trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit/UIProcess/LegacyGlobalSettings.cpp trunk/Source/WebKit/UIProcess/LegacyGlobalSettings.h Diff Modified: trunk/Source/WebKit/ChangeLog (250147 => 250148) --- trunk/Source/WebKit/ChangeLog 2019-09-20 20:30:33 UTC (rev 250147) +++ trunk/Source/WebKit/ChangeLog 2019-09-20 20:36:57 UTC (rev 250148) @@ -1,5 +1,42 @@ 2019-09-20 Alex Christensen +Introduce LegacyGlobalSettings for settings the NetworkProcess needs from a WebProcessPool +https://bugs.webkit.org/show_bug.cgi?id=201970 + +Reviewed by Geoff Garen. + +I'm starting by moving the cache model to this new abstraction. +We were using it in tests to disable the page cache, which should be done with a boolean on the pool configuration, not by changing the cache model. +We were also using it in WKContextSetCacheModel which has several clients that won't change quickly, so this abstraction is used to maintain existing behavior. +I need this so I can make a NetworkProcess not depend on anything from a WebProcessPool when starting. + +* Sources.txt: +* UIProcess/API/APIProcessPoolConfiguration.cpp: +(API::ProcessPoolConfiguration::copy): +* UIProcess/API/APIProcessPoolConfiguration.h: +* UIProcess/API/C/WKContext.cpp: +(WKContextSetCacheModel): +(WKContextGetCacheModel): +* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: +(-[_WKProcessPoolConfiguration pageCacheEnabled]): +(-[_WKProcessPoolConfiguration setPageCacheEnabled:]): +* UIProcess/LegacyGlobalSettings.cpp: Added. +(WebKit::LegacyGlobalSettings::singleton): +(WebKit::LegacyGlobalSettings::setCacheModel): +* UIProcess/LegacyGlobalSettings.h: Added. +(WebKit::LegacyGlobalSettings::cacheModel const): +* UIProcess/WebProcessCache.cpp: +(WebKit::WebProcessCache::updateCapacity): +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::ensureNetworkProcess): +(WebKit::WebProcessPool::initializeNewWebProcess): +(WebKit::WebProcessPool::updateMaxSuspendedPageCount): +(WebKit::WebProcessPool::setCacheModel): +* UIProcess/WebProcessPool.h: +* WebKit.xcodeproj/project.pbxproj: + +2019-09-20 Alex Christensen + Deprecate unused C API aliases for WebsiteDataStore https://bugs.webkit.org/show_bug.cgi?id=202029 Modified: trunk/Source/WebKit/Sources.txt (250147 => 250148) --- trunk/Source/WebKit/Sources.txt 2019-09
[webkit-changes] [250147] trunk/Source/WebCore
Title: [250147] trunk/Source/WebCore Revision 250147 Author commit-qu...@webkit.org Date 2019-09-20 13:30:33 -0700 (Fri, 20 Sep 2019) Log Message [SVG2]: Add auto behavior for rx and ry to the SVG and elements (Addressing review comments) https://bugs.webkit.org/show_bug.cgi?id=199843 Patch by Said Abou-Hallawa on 2019-09-20 Reviewed by Darin Adler. Make RenderSVGEllipse calculate of the ellipse's rx and ry more efficiently. * rendering/svg/RenderSVGEllipse.cpp: (WebCore::RenderSVGEllipse::calculateRadiiAndCenter): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (250146 => 250147) --- trunk/Source/WebCore/ChangeLog 2019-09-20 20:29:24 UTC (rev 250146) +++ trunk/Source/WebCore/ChangeLog 2019-09-20 20:30:33 UTC (rev 250147) @@ -1,3 +1,15 @@ +2019-09-20 Said Abou-Hallawa + +[SVG2]: Add auto behavior for rx and ry to the SVG and elements (Addressing review comments) +https://bugs.webkit.org/show_bug.cgi?id=199843 + +Reviewed by Darin Adler. + +Make RenderSVGEllipse calculate of the ellipse's rx and ry more efficiently. + +* rendering/svg/RenderSVGEllipse.cpp: +(WebCore::RenderSVGEllipse::calculateRadiiAndCenter): + 2019-09-20 Keith Rollin Remove some support for < iOS 13 Modified: trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp (250146 => 250147) --- trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp 2019-09-20 20:29:24 UTC (rev 250146) +++ trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp 2019-09-20 20:30:33 UTC (rev 250147) @@ -90,16 +90,10 @@ ASSERT(is(graphicsElement())); Length rx = style().svgStyle().rx(); -if (rx.isAuto()) -rx = style().svgStyle().ry(); - Length ry = style().svgStyle().ry(); -if (ry.isAuto()) -ry = style().svgStyle().rx(); - m_radii = FloatSize( -lengthContext.valueForLength(rx, SVGLengthMode::Width), -lengthContext.valueForLength(ry, SVGLengthMode::Height)); +lengthContext.valueForLength(rx.isAuto() ? ry : rx, SVGLengthMode::Width), +lengthContext.valueForLength(ry.isAuto() ? rx : ry, SVGLengthMode::Height)); } void RenderSVGEllipse::fillShape(GraphicsContext& context) const ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250146] trunk/Source/WebKit
Title: [250146] trunk/Source/WebKit
Revision 250146
Author achristen...@apple.com
Date 2019-09-20 13:29:24 -0700 (Fri, 20 Sep 2019)
Log Message
Deprecate unused C API aliases for WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=202029
Reviewed by Chris Dumez.
This is a piece of r249768.
* UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):
* UIProcess/API/C/WKApplicationCacheManager.h:
* UIProcess/API/C/WKKeyValueStorageManager.cpp:
(WKKeyValueStorageManagerGetTypeID):
(WKKeyValueStorageManagerGetOriginKey):
(WKKeyValueStorageManagerGetCreationTimeKey):
(WKKeyValueStorageManagerGetModificationTimeKey):
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
(WKKeyValueStorageManagerDeleteEntriesForOrigin):
(WKKeyValueStorageManagerDeleteAllEntries):
* UIProcess/API/C/WKKeyValueStorageManager.h:
* UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerGetTypeID):
(WKResourceCacheManagerGetCacheOrigins):
(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):
(toWebsiteDataTypes): Deleted.
* UIProcess/API/C/WKResourceCacheManager.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKApplicationCacheManager.cpp
trunk/Source/WebKit/UIProcess/API/C/WKApplicationCacheManager.h
trunk/Source/WebKit/UIProcess/API/C/WKKeyValueStorageManager.cpp
trunk/Source/WebKit/UIProcess/API/C/WKKeyValueStorageManager.h
trunk/Source/WebKit/UIProcess/API/C/WKResourceCacheManager.cpp
trunk/Source/WebKit/UIProcess/API/C/WKResourceCacheManager.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (250145 => 250146)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 20:21:22 UTC (rev 250145)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 20:29:24 UTC (rev 250146)
@@ -1,5 +1,38 @@
2019-09-20 Alex Christensen
+Deprecate unused C API aliases for WebsiteDataStore
+https://bugs.webkit.org/show_bug.cgi?id=202029
+
+Reviewed by Chris Dumez.
+
+This is a piece of r249768.
+
+* UIProcess/API/C/WKApplicationCacheManager.cpp:
+(WKApplicationCacheManagerGetTypeID):
+(WKApplicationCacheManagerGetApplicationCacheOrigins):
+(WKApplicationCacheManagerDeleteEntriesForOrigin):
+(WKApplicationCacheManagerDeleteAllEntries):
+* UIProcess/API/C/WKApplicationCacheManager.h:
+* UIProcess/API/C/WKKeyValueStorageManager.cpp:
+(WKKeyValueStorageManagerGetTypeID):
+(WKKeyValueStorageManagerGetOriginKey):
+(WKKeyValueStorageManagerGetCreationTimeKey):
+(WKKeyValueStorageManagerGetModificationTimeKey):
+(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
+(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
+(WKKeyValueStorageManagerDeleteEntriesForOrigin):
+(WKKeyValueStorageManagerDeleteAllEntries):
+* UIProcess/API/C/WKKeyValueStorageManager.h:
+* UIProcess/API/C/WKResourceCacheManager.cpp:
+(WKResourceCacheManagerGetTypeID):
+(WKResourceCacheManagerGetCacheOrigins):
+(WKResourceCacheManagerClearCacheForOrigin):
+(WKResourceCacheManagerClearCacheForAllOrigins):
+(toWebsiteDataTypes): Deleted.
+* UIProcess/API/C/WKResourceCacheManager.h:
+
+2019-09-20 Alex Christensen
+
Remove functionality to disable TLS fallback
https://bugs.webkit.org/show_bug.cgi?id=201998
Modified: trunk/Source/WebKit/UIProcess/API/C/WKApplicationCacheManager.cpp (250145 => 250146)
--- trunk/Source/WebKit/UIProcess/API/C/WKApplicationCacheManager.cpp 2019-09-20 20:21:22 UTC (rev 250145)
+++ trunk/Source/WebKit/UIProcess/API/C/WKApplicationCacheManager.cpp 2019-09-20 20:29:24 UTC (rev 250146)
@@ -26,42 +26,19 @@
#include "config.h"
#include "WKApplicationCacheManager.h"
-#include "APIArray.h"
-#include "APIWebsiteDataStore.h"
-#include "WKAPICast.h"
-#include "WebsiteDataRecord.h"
-
WKTypeID WKApplicationCacheManagerGetTypeID()
{
-return WebKit::toAPI(API::WebsiteDataStore::APIType);
+return 0;
}
-void WKApplicationCacheManagerGetApplicationCacheOrigins(WKApplicationCacheManagerRef applicationCacheManager, void* context, WKApplicationCacheManagerGetApplicationCacheOriginsFunction callback)
+void WKApplicationCacheManagerGetApplicationCacheOrigins(WKApplicationCacheManagerRef, void*, WKApplicationCacheManagerGetApplicationCacheOriginsFunction)
{
-auto& websiteDataStore = WebKit::toImpl(reinterpret_cast(applicationCacheManager))->websiteDataStore();
-websiteDataStore.fetchData(WebKit::WebsiteDataType::OfflineWebApplicationCache, { }, [context, callback](auto dataRecords) {
-Vector> securityOrigins;
-for (const auto& dataRecord : dataRecords) {
-for (const auto& origin : da
[webkit-changes] [250145] trunk
Title: [250145] trunk Revision 250145 Author ape...@igalia.com Date 2019-09-20 13:21:22 -0700 (Fri, 20 Sep 2019) Log Message Unreviewed. Bump WPE version numbers. * Source/cmake/OptionsWPE.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/OptionsWPE.cmake Diff Modified: trunk/ChangeLog (250144 => 250145) --- trunk/ChangeLog 2019-09-20 20:17:26 UTC (rev 250144) +++ trunk/ChangeLog 2019-09-20 20:21:22 UTC (rev 250145) @@ -1,3 +1,9 @@ +2019-09-20 Adrian Perez de Castro + +Unreviewed. Bump WPE version numbers. + +* Source/cmake/OptionsWPE.cmake: + 2019-09-17 Fujii Hironori [WinCairo][curl] Define NOCRYPT to suppress libressl "Warning, overriding WinCrypt defines" Modified: trunk/Source/cmake/OptionsWPE.cmake (250144 => 250145) --- trunk/Source/cmake/OptionsWPE.cmake 2019-09-20 20:17:26 UTC (rev 250144) +++ trunk/Source/cmake/OptionsWPE.cmake 2019-09-20 20:21:22 UTC (rev 250145) @@ -1,10 +1,10 @@ include(GNUInstallDirs) include(VersioningUtils) -SET_PROJECT_VERSION(2 25 1) +SET_PROJECT_VERSION(2 27 0) set(WPE_API_VERSION 1.0) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 7 0 4) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 9 0 6) # These are shared variables, but we special case their definition so that we can use the # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250144] trunk/Source
Title: [250144] trunk/Source Revision 250144 Author achristen...@apple.com Date 2019-09-20 13:17:26 -0700 (Fri, 20 Sep 2019) Log Message Remove functionality to disable TLS fallback https://bugs.webkit.org/show_bug.cgi?id=201998 Reviewed by Geoff Garen. Source/WebCore/PAL: * pal/spi/cf/CFNetworkSPI.h: Source/WebKit: Since r249019 it is not used. It was a useful experiment and I'm glad we didn't see any regressions. * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::privateSessionParameters): (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _setAllowsTLSFallback:]): (-[WKWebsiteDataStore _allowsTLSFallback]): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess): * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::setAllowsTLSFallback): Deleted. * UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::allowsTLSFallback const): Deleted. Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (250143 => 250144) --- trunk/Source/WebCore/PAL/ChangeLog 2019-09-20 20:11:50 UTC (rev 250143) +++ trunk/Source/WebCore/PAL/ChangeLog 2019-09-20 20:17:26 UTC (rev 250144) @@ -1,3 +1,12 @@ +2019-09-20 Alex Christensen + +Remove functionality to disable TLS fallback +https://bugs.webkit.org/show_bug.cgi?id=201998 + +Reviewed by Geoff Garen. + +* pal/spi/cf/CFNetworkSPI.h: + 2019-09-18 Keith Rollin Remove alternate declaration of CCECCryptorImportKey Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (250143 => 250144) --- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-09-20 20:11:50 UTC (rev 250143) +++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2019-09-20 20:17:26 UTC (rev 250144) @@ -190,7 +190,6 @@ @property (nullable, copy) NSString *_sourceApplicationBundleIdentifier; @property (nullable, copy) NSString *_sourceApplicationSecondaryIdentifier; @property BOOL _shouldSkipPreferredClientCertificateLookup NS_AVAILABLE(10_10, 8_0); -@property BOOL _allowsTLSFallback; #if PLATFORM(IOS_FAMILY) @property (nullable, copy) NSString *_CTDataConnectionServiceType; #endif Modified: trunk/Source/WebKit/ChangeLog (250143 => 250144) --- trunk/Source/WebKit/ChangeLog 2019-09-20 20:11:50 UTC (rev 250143) +++ trunk/Source/WebKit/ChangeLog 2019-09-20 20:17:26 UTC (rev 250144) @@ -1,5 +1,33 @@ 2019-09-20 Alex Christensen +Remove functionality to disable TLS fallback +https://bugs.webkit.org/show_bug.cgi?id=201998 + +Reviewed by Geoff Garen. + +Since r249019 it is not used. It was a useful experiment and I'm glad we didn't see any regressions. + +* NetworkProcess/NetworkSessionCreationParameters.cpp: +(WebKit::NetworkSessionCreationParameters::privateSessionParameters): +(WebKit::NetworkSessionCreationParameters::encode const): +(WebKit::NetworkSessionCreationParameters::decode): +* NetworkProcess/NetworkSessionCreationParameters.h: +* NetworkProcess/cocoa/NetworkSessionCocoa.mm: +(WebKit::NetworkSessionCocoa::NetworkSessionCocoa): +* UIProcess/API/Cocoa/WKWebsiteDataStore.mm: +(-[WKWebsiteDataStore _setAllowsTLSFallback:]): +(-[WKWebsiteDataStore _allowsTLSFallback]): +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::ensureNetworkProcess): +* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: +(WebKit::WebsiteDataStore::parameters): +* UIProcess/WebsiteData/WebsiteDataStore.cpp: +(WebKit::WebsiteDataStore::setAllowsTLSFallback): Deleted. +* UIProcess/WebsiteData/WebsiteDataStore.h: +(WebKit::WebsiteDataStore::allowsTLSFallback const): Deleted. + +2019-09-20 Alex Christensen + Remove unused storage paths on APIProcessPoolConfiguration https://bugs.webkit.org/show_bug.cgi?id=202028 Modified: trunk/Source/WebKit/Ne
[webkit-changes] [250143] trunk/Source/WebKit
Title: [250143] trunk/Source/WebKit Revision 250143 Author achristen...@apple.com Date 2019-09-20 13:11:50 -0700 (Fri, 20 Sep 2019) Log Message Remove unused storage paths on APIProcessPoolConfiguration https://bugs.webkit.org/show_bug.cgi?id=202028 Reviewed by Chris Dumez. This is a piece of r249768. There is no way to set these paths and they have been replaced by WebsiteDataStore paths. There was one remaining use of the global disk cache directory in NetworkProcess::setCacheModel, which I replaced with the default session's disk cache directory, which is equivalent. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setCacheModel): * NetworkProcess/NetworkProcess.h: (WebKit::NetworkProcess::diskCacheDirectory const): Deleted. * NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode const): (WebKit::NetworkProcessCreationParameters::decode): (WebKit::NetworkProcessCreationParameters::NetworkProcessCreationParameters): Deleted. * NetworkProcess/NetworkProcessCreationParameters.h: * NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::NetworkSession): * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::open): (WebKit::NetworkCache::Cache::Cache): * NetworkProcess/cache/NetworkCache.h: (WebKit::NetworkCache::Cache::storageDirectory): * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa): * UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::copy): (API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration): Deleted. (API::ProcessPoolConfiguration::ProcessPoolConfiguration): Deleted. (API::ProcessPoolConfiguration::~ProcessPoolConfiguration): Deleted. * UIProcess/API/APIProcessPoolConfiguration.h: * UIProcess/API/glib/WebKitWebContext.cpp: (webkitWebContextConstructed): (webkit_web_context_set_disk_cache_directory): (websiteDataStoreConfigurationForWebProcessPoolConfiguration): Deleted. * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess): (WebKit::WebProcessPool::resolvePathsForSandboxExtensions): (WebKit::WebProcessPool::webProcessDataStoreParameters): * UIProcess/WebProcessPool.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::processPools const): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h trunk/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h Diff Modified: trunk/Source/WebKit/ChangeLog (250142 => 250143) --- trunk/Source/WebKit/ChangeLog 2019-09-20 20:10:37 UTC (rev 250142) +++ trunk/Source/WebKit/ChangeLog 2019-09-20 20:11:50 UTC (rev 250143) @@ -1,3 +1,52 @@ +2019-09-20 Alex Christensen + +Remove unused storage paths on APIProcessPoolConfiguration +https://bugs.webkit.org/show_bug.cgi?id=202028 + +Reviewed by Chris Dumez. + +This is a piece of r249768. +There is no way to set these paths and they have been replaced by WebsiteDataStore paths. +There was one remaining use of the global disk cache directory in NetworkProcess::setCacheModel, +which I replaced with the default session's disk cache directory, which is equivalent. + +* NetworkProcess/NetworkProcess.cpp: +(WebKit::NetworkProcess::setCacheModel): +* NetworkProcess/NetworkProcess.h: +(WebKit::NetworkProcess::diskCacheDirectory const): Deleted. +* NetworkProcess/NetworkProcessCreationParameters.cpp: +(WebKit::NetworkProcessCreationParameters::encode const): +(WebKit::NetworkProcessCreationParameters::decode): +(WebKit::NetworkProcessCreationParameters::NetworkProcessCreationParameters): Deleted. +* NetworkProcess/NetworkProcessCreationParameters.h: +* NetworkProcess/NetworkSession.cpp: +(WebKit::NetworkSession::NetworkSession): +* NetworkProcess/cache/NetworkCache.cpp: +(WebKit::NetworkCache::Cache::open): +(WebKit::NetworkCache::Cache::Cache): +* NetworkProcess/cache
[webkit-changes] [250142] trunk/Source
Title: [250142] trunk/Source
Revision 250142
Author krol...@apple.com
Date 2019-09-20 13:10:37 -0700 (Fri, 20 Sep 2019)
Log Message
Remove some support for < iOS 13
https://bugs.webkit.org/show_bug.cgi?id=202032
Reviewed by Alex Christensen.
Remove some support for iOS versions less than 13.0.
Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 13. This means that expressions like
"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Dan Bates was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.
Source/WebCore:
No new tests -- no new or changed functionality.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
* platform/network/cocoa/CookieCocoa.mm:
(WebCore::Cookie::operator NSHTTPCookie * _Nullable const):
* platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Source/WebKit:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Source/WebKitLegacy/mac:
* WebView/WebHTMLView.mm:
(-[WebHTMLView _handleEditingKeyEvent:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp
trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm
trunk/Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (250141 => 250142)
--- trunk/Source/WebCore/ChangeLog 2019-09-20 19:47:19 UTC (rev 250141)
+++ trunk/Source/WebCore/ChangeLog 2019-09-20 20:10:37 UTC (rev 250142)
@@ -1,3 +1,36 @@
+2019-09-20 Keith Rollin
+
+Remove some support for < iOS 13
+https://bugs.webkit.org/show_bug.cgi?id=202032
+
+
+Reviewed by Alex Christensen.
+
+Remove some support for iOS versions less than 13.0.
+
+Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
+and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
+values >= 13. This means that expressions like
+"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
+"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
+
+This removal is part of a series of patches effecting the removal of
+dead code for old versions of iOS. This particular pass involves
+changes in which Dan Bates was involved. These changes are isolated
+from other similar changes in order to facilitate the reviewing
+process.
+
+No new tests -- no new or changed functionality.
+
+* platform/network/cf/ResourceRequestCFNet.cpp:
+(WebCore::ResourceRequest::doUpdatePlatformRequest):
+(WebCore::ResourceRequest::doUpdateResourceRequest):
+* platform/network/cocoa/CookieCocoa.mm:
+(WebCore::Cookie::operator NSHTTPCookie * _Nullable const):
+* platform/network/cocoa/ResourceRequestCocoa.mm:
+(WebCore::ResourceRequest::doUpdateResourceRequest):
+(WebCore::ResourceRequest::doUpdatePlatformRequest):
+
2019-09-20 Truitt Savell
Unreviewed, rolling out r250114.
Modified: trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp (250141 => 250142)
--- trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp 2019-09-20 19:47:19 UTC (rev 250141)
+++ trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp 2019-09-20 20:10:37 UTC (rev 250142)
@@ -157,7 +157,7 @@
}
}
-#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 12
+#if PLATFORM(IOS_FAMILY)
static CFURLRef siteForCookies(ResourceRequest::SameSiteDisposition disposition, CFURLRef url)
{
switch (disposition) {
@@ -200,7 +200,7 @@
CFURLRequestSetShouldHandleHTTPCookies(cfRequest, allowCookies());
-#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 12
+#if PLATFORM(IOS_FAMILY)
_CFURLRequestSetProtocolProperty(cfRequest, CFSTR("_kCFHTTPCookiePolicyPropertySiteForCookies"), siteForCookies(m_sameSiteDisposition, url.get()));
int isTopSite = m_isTopSite;
@@ -285,7 +285,7 @@
if (resourcePrioritiesEnabled())
m_priority = toResourceLoadPriority(CFURLRequestGetRequestPriority(m_cfRequest.get()));
-#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 12
+#if PLATFORM(IOS_FAMILY)
[webkit-changes] [250141] releases/WPE WebKit/webkit-2.26.0/
Title: [250141] releases/WPE WebKit/webkit-2.26.0/ Revision 250141 Author ape...@igalia.com Date 2019-09-20 12:47:19 -0700 (Fri, 20 Sep 2019) Log Message WPE WebKit 2.26.0 Added Paths releases/WPE WebKit/webkit-2.26.0/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250140] releases/WebKitGTK/webkit-2.26
Title: [250140] releases/WebKitGTK/webkit-2.26 Revision 250140 Author ape...@igalia.com Date 2019-09-20 12:46:40 -0700 (Fri, 20 Sep 2019) Log Message Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.0 release .: * Source/cmake/OptionsWPE.cmake: Bump version numbers. Source/WebKit: * wpe/NEWS: Add release notes for 2.26.0 Modified Paths releases/WebKitGTK/webkit-2.26/ChangeLog releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake Diff Modified: releases/WebKitGTK/webkit-2.26/ChangeLog (250139 => 250140) --- releases/WebKitGTK/webkit-2.26/ChangeLog 2019-09-20 19:39:42 UTC (rev 250139) +++ releases/WebKitGTK/webkit-2.26/ChangeLog 2019-09-20 19:46:40 UTC (rev 250140) @@ -1,3 +1,9 @@ +2019-09-20 Adrian Perez de Castro + +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.0 release + +* Source/cmake/OptionsWPE.cmake: Bump version numbers. + 2019-09-09 Adrian Perez de Castro Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.25.91 release Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog (250139 => 250140) --- releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog 2019-09-20 19:39:42 UTC (rev 250139) +++ releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog 2019-09-20 19:46:40 UTC (rev 250140) @@ -1,3 +1,9 @@ +2019-09-20 Adrian Perez de Castro + +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.0 release + +* wpe/NEWS: Add release notes for 2.26.0 + 2019-09-09 Adrian Perez de Castro Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.25.91 release Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS (250139 => 250140) --- releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS 2019-09-20 19:39:42 UTC (rev 250139) +++ releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS 2019-09-20 19:46:40 UTC (rev 250140) @@ -1,3 +1,9 @@ += +WPE WebKit 2.26.0 += + + - This version contains no changes over the 2.25.91 release candidate. + == WPE WebKit 2.25.91 == Modified: releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake (250139 => 250140) --- releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake 2019-09-20 19:39:42 UTC (rev 250139) +++ releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake 2019-09-20 19:46:40 UTC (rev 250140) @@ -1,10 +1,10 @@ include(GNUInstallDirs) include(VersioningUtils) -SET_PROJECT_VERSION(2 25 91) +SET_PROJECT_VERSION(2 26 0) set(WPE_API_VERSION 1.0) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 8 0 5) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 8 1 5) # These are shared variables, but we special case their definition so that we can use the # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250138] trunk
Title: [250138] trunk Revision 250138 Author krol...@apple.com Date 2019-09-20 12:31:24 -0700 (Fri, 20 Sep 2019) Log Message Remove some support for < iOS 13 https://bugs.webkit.org/show_bug.cgi?id=201973 Reviewed by Alex Christensen. Remove some support for iOS versions less than 13.0. Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 13. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Chris Dumez was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process. Source/WebKit: * NetworkProcess/Downloads/cocoa/DownloadCocoa.mm: (WebKit::Download::resume): Source/WTF: * wtf/FeatureDefines.h: Tools: * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/FeatureDefines.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Diff Modified: trunk/Source/WTF/ChangeLog (250137 => 250138) --- trunk/Source/WTF/ChangeLog 2019-09-20 18:42:48 UTC (rev 250137) +++ trunk/Source/WTF/ChangeLog 2019-09-20 19:31:24 UTC (rev 250138) @@ -1,3 +1,27 @@ +2019-09-20 Keith Rollin + +Remove some support for < iOS 13 +https://bugs.webkit.org/show_bug.cgi?id=201973 + + +Reviewed by Alex Christensen. + +Remove some support for iOS versions less than 13.0. + +Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED +and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have +values >= 13. This means that expressions like +"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and +"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. + +This removal is part of a series of patches effecting the removal of +dead code for old versions of iOS. This particular pass involves +changes in which Chris Dumez was involved. These changes are isolated +from other similar changes in order to facilitate the reviewing +process. + +* wtf/FeatureDefines.h: + 2019-09-20 Paulo Matos Implement memory monitoring functions for Linux OS Modified: trunk/Source/WTF/wtf/FeatureDefines.h (250137 => 250138) --- trunk/Source/WTF/wtf/FeatureDefines.h 2019-09-20 18:42:48 UTC (rev 250137) +++ trunk/Source/WTF/wtf/FeatureDefines.h 2019-09-20 19:31:24 UTC (rev 250138) @@ -186,16 +186,12 @@ #endif #if !defined(HAVE_VISIBILITY_PROPAGATION_VIEW) -#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 13 #define HAVE_VISIBILITY_PROPAGATION_VIEW 1 #endif -#endif #if !defined(HAVE_UISCENE) -#if (__IPHONE_OS_VERSION_MIN_REQUIRED >= 13) || PLATFORM(APPLETV) || PLATFORM(WATCHOS) #define HAVE_UISCENE 1 #endif -#endif #if !defined(HAVE_AVSTREAMSESSION) #define HAVE_AVSTREAMSESSION 0 Modified: trunk/Source/WebKit/ChangeLog (250137 => 250138) --- trunk/Source/WebKit/ChangeLog 2019-09-20 18:42:48 UTC (rev 250137) +++ trunk/Source/WebKit/ChangeLog 2019-09-20 19:31:24 UTC (rev 250138) @@ -1,3 +1,28 @@ +2019-09-20 Keith Rollin + +Remove some support for < iOS 13 +https://bugs.webkit.org/show_bug.cgi?id=201973 + + +Reviewed by Alex Christensen. + +Remove some support for iOS versions less than 13.0. + +Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED +and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have +values >= 13. This means that expressions like +"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and +"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True. + +This removal is part of a series of patches effecting the removal of +dead code for old versions of iOS. This particular pass involves +changes in which Chris Dumez was involved. These changes are isolated +from other similar changes in order to facilitate the reviewing +process. + +* NetworkProcess/Downloads/cocoa/DownloadCocoa.mm: +(WebKit::Download::resume): + 2019-09-20 Chris Dumez Unreviewed, fix confusing release logging under WebPageProxy::loadRequestWithNavigationShared(). Modified: trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm (250137 => 250138) --- trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm 2019-09-20 18:42:48 UTC (rev 250137) +++ trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm 2019-09-20 19:31:24 UTC (rev 250138) @@ -48,8
[webkit-changes] [250137] branches/safari-608-branch
Title: [250137] branches/safari-608-branch
Revision 250137
Author alanc...@apple.com
Date 2019-09-20 11:42:48 -0700 (Fri, 20 Sep 2019)
Log Message
Revert "Revert r247573. rdar://problem/55461395"
Modified Paths
branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/dom/ios/PointerEventIOS.cpp
Added Paths
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html
Diff
Modified: branches/safari-608-branch/LayoutTests/ChangeLog (250136 => 250137)
--- branches/safari-608-branch/LayoutTests/ChangeLog 2019-09-20 18:18:14 UTC (rev 250136)
+++ branches/safari-608-branch/LayoutTests/ChangeLog 2019-09-20 18:42:48 UTC (rev 250137)
@@ -1,7 +1,3 @@
-2019-09-20 Alan Coon
-
-Revert r247573. rdar://problem/55461395
-
2019-09-17 Alan Coon
Cherry-pick r249954. rdar://problem/55461404
Added: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt (0 => 250137)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt (rev 0)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt 2019-09-20 18:42:48 UTC (rev 250137)
@@ -0,0 +1,3 @@
+
+PASS Testing the values of the button and buttons properties.
+
Added: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt (0 => 250137)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt (rev 0)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt 2019-09-20 18:42:48 UTC (rev 250137)
@@ -0,0 +1,3 @@
+
+PASS Testing the values of the button and buttons properties with cancelation.
+
Added: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html (0 => 250137)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html (rev 0)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html 2019-09-20 18:42:48 UTC (rev 250137)
@@ -0,0 +1,38 @@
+
+
+
+
+
+
+
+
+
+'use strict';
+
+target_test({ width: "200px", height: "200px" }, (target, test) => {
+const eventTracker = new EventTracker(target, ["pointerdown", "pointerenter", "pointerleave", "pointercancel", "pointerout", "pointerover", "pointerup"]);
+
+const _one_ = ui.finger();
+ui.sequence([
+one.begin({ x: 10, y: 10 }),
+one.move({ x: 100, y: 100 }),
+one.end()
+]).then(() => {
+eventTracker.assertMatchesEvents([
+{ type: "pointerover", button: 0, buttons: 1 },
+{ type: "pointerenter", button: 0, buttons: 1 },
+{ type: "pointerdown", button: 0, buttons: 1 },
+{ type: "pointercancel", button: 0, buttons: 0 },
+{ type: "pointerout", button: 0, buttons: 0 },
+{ type: "pointerleave", button: 0, buttons: 0 },
+]);
+test.done();
+});
+}, `Testing the values of the button and buttons properties with cancelation.`);
+
+
+
+
\ No newline at end of file
Added: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html (0 => 250137)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html (rev 0)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html 2019-09-20 18:42:48 UTC (rev 250137)
@@ -0,0 +1,40 @@
+
+
+
+
+
+
+
+
+
+'use strict';
+
+target_test({ width: "200px", height: "200px" }, (target, test) => {
+const eventTracker = new EventTracker(target, ["pointerdown", "pointerenter", "pointerleave", "pointermove", "pointerout", "pointerover", "pointerup"]);
+target.style.touchAction = "none";
+
+const _one_ = ui.finger();
+ui.sequence([
+one.begin({ x: 10, y: 10 }),
+one.move({ x: 100, y: 100 }),
+one.end()
+]).then(() => {
+eventTracker.assertMatchesEvents([
+{ type: "pointerover", button: 0, buttons: 1 },
+{ type: "pointerenter", button: 0, buttons: 1 },
+{ type: "pointerdown", button: 0, buttons: 1 },
+{ type: "pointermove", button: -1, buttons: 1 },
+{ type: "pointerup", button: 0, b
[webkit-changes] [250136] branches/safari-608.2.11.1-branch/Source/WebKit
Title: [250136] branches/safari-608.2.11.1-branch/Source/WebKit
Revision 250136
Author alanc...@apple.com
Date 2019-09-20 11:18:14 -0700 (Fri, 20 Sep 2019)
Log Message
Apply patch. rdar://problem/55564031
Modified Paths
branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog
branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/WebPageProxy.h
branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp
branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.h
branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Diff
Modified: branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog (250135 => 250136)
--- branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog 2019-09-20 17:24:17 UTC (rev 250135)
+++ branches/safari-608.2.11.1-branch/Source/WebKit/ChangeLog 2019-09-20 18:18:14 UTC (rev 250136)
@@ -1,3 +1,38 @@
+2019-09-20 Alan Coon
+
+Apply patch. rdar://problem/55564031
+
+2019-09-20 Chris Dumez
+
+Regression(r248832): Unable to quicklook HTML files in Mail
+https://bugs.webkit.org/show_bug.cgi?id=202012
+
+
+Reviewed by Geoff Garen and Brent Fulgham.
+
+r248832 inadvertently reverted the fix for Mail that landed in r247400 by not using
+the same logic to initialize the sandbox extension if the process had already
+finished launching or not. In particular, the new code path that happens on process
+launch unconditionally used '/' as resource directory for the sandbox extension if
+the client did not provide one. The logic in maybeInitializeSandboxExtensionHandle()
+would use the file URL's base URL as resource directory when creating a sandbox
+extension for '/' would fail (which it often does).
+
+To address the issue, have the logic that runs on process launch call
+maybeInitializeSandboxExtensionHandle() so avoid duplicating code and make sure
+both cases now have the Mail fix.
+
+* UIProcess/AuxiliaryProcessProxy.cpp:
+(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
+* UIProcess/AuxiliaryProcessProxy.h:
+(WebKit::AuxiliaryProcessProxy::isLaunching const):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+(WebKit::WebPageProxy::loadRequestWithNavigationShared):
+(WebKit::WebPageProxy::loadFile):
+* UIProcess/WebPageProxy.h:
+* WebProcess/WebPage/WebPage.messages.in:
+
2019-09-19 Kocsen Chung
Cherry-pick r250069. rdar://problem/55524978
Modified: branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp (250135 => 250136)
--- branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2019-09-20 17:24:17 UTC (rev 250135)
+++ branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2019-09-20 18:18:14 UTC (rev 250136)
@@ -29,6 +29,8 @@
#include "AuxiliaryProcessMessages.h"
#include "LoadParameters.h"
#include "WebPageMessages.h"
+#include "WebPageProxy.h"
+#include "WebProcessProxy.h"
#include
namespace WebKit {
@@ -183,12 +185,16 @@
auto bufferSize = message->bufferSize();
std::unique_ptr decoder = std::make_unique(buffer, bufferSize, nullptr, Vector { });
LoadParameters loadParameters;
-String sandboxExtensionPath;
-if (decoder->decode(loadParameters) && decoder->decode(sandboxExtensionPath)) {
-SandboxExtension::createHandleForReadByPid(sandboxExtensionPath, processIdentifier(), loadParameters.sandboxExtensionHandle);
-send(Messages::WebPage::LoadRequest(loadParameters), decoder->destinationID());
-continue;
-}
+URL resourceDirectoryURL;
+WebCore::PageIdentifier pageID;
+if (decoder->decode(loadParameters) && decoder->decode(resourceDirectoryURL) && decoder->decode(pageID)) {
+if (auto* page = WebProcessProxy::webPage(pageID)) {
+page->maybeInitializeSandboxExtensionHandle(static_cast(*this), loadParameters.request.url(), resourceDirectoryURL, loadParameters.sandboxExtensionHandle);
+send(Messages::WebPage::LoadRequest(loadParameters), decoder->destinationID());
+}
+} else
+ASSERT_NOT_REACHED();
+continue;
}
#endif
m_connection->sendMessage(WTFMove(message), sendOptions);
Modified: branches/safari-608.2.11.1-branch/Source/WebKit/UIP
[webkit-changes] [250135] branches/safari-608.2.11.1-branch/Source
Title: [250135] branches/safari-608.2.11.1-branch/Source Revision 250135 Author alanc...@apple.com Date 2019-09-20 10:24:17 -0700 (Fri, 20 Sep 2019) Log Message Versioning. Modified Paths branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-608.2.11.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (250134 => 250135) --- branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-09-20 17:21:32 UTC (rev 250134) +++ branches/safari-608.2.11.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-09-20 17:24:17 UTC (rev 250135) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (250134 => 250135) --- branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-09-20 17:21:32 UTC (rev 250134) +++ branches/safari-608.2.11.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-09-20 17:24:17 UTC (rev 250135) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig (250134 => 250135) --- branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig 2019-09-20 17:21:32 UTC (rev 250134) +++ branches/safari-608.2.11.1-branch/Source/WebCore/Configurations/Version.xcconfig 2019-09-20 17:24:17 UTC (rev 250135) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (250134 => 250135) --- branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-09-20 17:21:32 UTC (rev 250134) +++ branches/safari-608.2.11.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-09-20 17:24:17 UTC (rev 250135) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (250134 => 250135) --- branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-09-20 17:21:32 UTC (rev 250134) +++ branches/safari-608.2.11.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-09-20 17:24:17 UTC (rev 250135) @@ -2,7 +2,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig (250134 => 250135) --- branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig 2019-09-20 17:21:32 UTC (rev 250134) +++ branches/safari-608.2.11.1-branch/Source/WebKit/Configurations/Version.xcconfig 2019-09-20 17:24:17 UTC (rev 250135) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 11; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/saf
[webkit-changes] [250134] branches/safari-608-branch
Title: [250134] branches/safari-608-branch
Revision 250134
Author alanc...@apple.com
Date 2019-09-20 10:21:32 -0700 (Fri, 20 Sep 2019)
Log Message
Revert r247573. rdar://problem/55461395
Modified Paths
branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/dom/ios/PointerEventIOS.cpp
Removed Paths
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html
branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html
Diff
Modified: branches/safari-608-branch/LayoutTests/ChangeLog (250133 => 250134)
--- branches/safari-608-branch/LayoutTests/ChangeLog 2019-09-20 15:53:24 UTC (rev 250133)
+++ branches/safari-608-branch/LayoutTests/ChangeLog 2019-09-20 17:21:32 UTC (rev 250134)
@@ -1,3 +1,7 @@
+2019-09-20 Alan Coon
+
+Revert r247573. rdar://problem/55461395
+
2019-09-17 Alan Coon
Cherry-pick r249954. rdar://problem/55461404
Deleted: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt (250133 => 250134)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt 2019-09-20 15:53:24 UTC (rev 250133)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-expected.txt 2019-09-20 17:21:32 UTC (rev 250134)
@@ -1,3 +0,0 @@
-
-PASS Testing the values of the button and buttons properties.
-
Deleted: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt (250133 => 250134)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt 2019-09-20 15:53:24 UTC (rev 250133)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel-expected.txt 2019-09-20 17:21:32 UTC (rev 250134)
@@ -1,3 +0,0 @@
-
-PASS Testing the values of the button and buttons properties with cancelation.
-
Deleted: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html (250133 => 250134)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html 2019-09-20 15:53:24 UTC (rev 250133)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons-pointer-cancel.html 2019-09-20 17:21:32 UTC (rev 250134)
@@ -1,38 +0,0 @@
-
-
-
-
-
-
-
-
-
-'use strict';
-
-target_test({ width: "200px", height: "200px" }, (target, test) => {
-const eventTracker = new EventTracker(target, ["pointerdown", "pointerenter", "pointerleave", "pointercancel", "pointerout", "pointerover", "pointerup"]);
-
-const _one_ = ui.finger();
-ui.sequence([
-one.begin({ x: 10, y: 10 }),
-one.move({ x: 100, y: 100 }),
-one.end()
-]).then(() => {
-eventTracker.assertMatchesEvents([
-{ type: "pointerover", button: 0, buttons: 1 },
-{ type: "pointerenter", button: 0, buttons: 1 },
-{ type: "pointerdown", button: 0, buttons: 1 },
-{ type: "pointercancel", button: 0, buttons: 0 },
-{ type: "pointerout", button: 0, buttons: 0 },
-{ type: "pointerleave", button: 0, buttons: 0 },
-]);
-test.done();
-});
-}, `Testing the values of the button and buttons properties with cancelation.`);
-
-
-
-
\ No newline at end of file
Deleted: branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html (250133 => 250134)
--- branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html 2019-09-20 15:53:24 UTC (rev 250133)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/pointer-event-button-and-buttons.html 2019-09-20 17:21:32 UTC (rev 250134)
@@ -1,40 +0,0 @@
-
-
-
-
-
-
-
-
-
-'use strict';
-
-target_test({ width: "200px", height: "200px" }, (target, test) => {
-const eventTracker = new EventTracker(target, ["pointerdown", "pointerenter", "pointerleave", "pointermove", "pointerout", "pointerover", "pointerup"]);
-target.style.touchAction = "none";
-
-const _one_ = ui.finger();
-ui.sequence([
-one.begin({ x: 10, y: 10 }),
-one.move({ x: 100, y: 100 }),
-one.end()
-]).then(() => {
-eventTracker.assertMatchesEvents([
-{ type: "pointerover", button: 0, buttons: 1 },
-{ type: "pointerenter", button: 0, buttons: 1 },
-{ type: "pointerdown", button: 0, buttons: 1 },
-{ type: "pointermove", button: -1, buttons: 1 },
-
[webkit-changes] [250133] trunk/Source/WebKit
Title: [250133] trunk/Source/WebKit
Revision 250133
Author cdu...@apple.com
Date 2019-09-20 08:53:24 -0700 (Fri, 20 Sep 2019)
Log Message
Unreviewed, fix confusing release logging under WebPageProxy::loadRequestWithNavigationShared().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (250132 => 250133)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 15:41:43 UTC (rev 250132)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 15:53:24 UTC (rev 250133)
@@ -1,5 +1,12 @@
2019-09-20 Chris Dumez
+Unreviewed, fix confusing release logging under WebPageProxy::loadRequestWithNavigationShared().
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::loadRequestWithNavigationShared):
+
+2019-09-20 Chris Dumez
+
Regression(r248832): Unable to quicklook HTML files in Mail
https://bugs.webkit.org/show_bug.cgi?id=202012
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (250132 => 250133)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 15:41:43 UTC (rev 250132)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 15:53:24 UTC (rev 250133)
@@ -1160,7 +1160,7 @@
{
ASSERT(!m_isClosed);
-RELEASE_LOG_IF_ALLOWED(Loading, "loadRequestWithNavigation:");
+RELEASE_LOG_IF_ALLOWED(Loading, "loadRequestWithNavigationShared:");
auto transaction = m_pageLoadState.transaction();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250132] trunk/Source/WebCore
Title: [250132] trunk/Source/WebCore
Revision 250132
Author an...@apple.com
Date 2019-09-20 08:41:43 -0700 (Fri, 20 Sep 2019)
Log Message
Implement Position::upstream and Position::downstream with line layout iterator
https://bugs.webkit.org/show_bug.cgi?id=202043
Reviewed by Zalan Bujtas.
These can eventually work without switching to lineboxes.
* dom/Position.cpp:
(WebCore::Position::upstream const):
(WebCore::Position::downstream const):
Factor the loops into TextBox::isLastOnLine function.
* rendering/line/LineLayoutInterfaceTextBoxes.cpp:
(WebCore::LineLayoutInterface::TextBox::isLastOnLine const):
Looking into root boxes is a much more efficient way to figure this out.
(WebCore::LineLayoutInterface::TextBox::isLast const):
(WebCore::LineLayoutInterface::TextBoxIterator::ComplexPath::nextInlineTextBoxInTextOrder const):
(WebCore::LineLayoutInterface::TextBoxIterator::traverseNextInTextOrder):
* rendering/line/LineLayoutInterfaceTextBoxes.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/rendering/line/LineLayoutInterfaceTextBoxes.cpp
trunk/Source/WebCore/rendering/line/LineLayoutInterfaceTextBoxes.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (250131 => 250132)
--- trunk/Source/WebCore/ChangeLog 2019-09-20 15:40:09 UTC (rev 250131)
+++ trunk/Source/WebCore/ChangeLog 2019-09-20 15:41:43 UTC (rev 250132)
@@ -1,3 +1,28 @@
+2019-09-20 Antti Koivisto
+
+Implement Position::upstream and Position::downstream with line layout iterator
+https://bugs.webkit.org/show_bug.cgi?id=202043
+
+Reviewed by Zalan Bujtas.
+
+These can eventually work without switching to lineboxes.
+
+* dom/Position.cpp:
+(WebCore::Position::upstream const):
+(WebCore::Position::downstream const):
+
+Factor the loops into TextBox::isLastOnLine function.
+
+* rendering/line/LineLayoutInterfaceTextBoxes.cpp:
+(WebCore::LineLayoutInterface::TextBox::isLastOnLine const):
+
+Looking into root boxes is a much more efficient way to figure this out.
+
+(WebCore::LineLayoutInterface::TextBox::isLast const):
+(WebCore::LineLayoutInterface::TextBoxIterator::ComplexPath::nextInlineTextBoxInTextOrder const):
+(WebCore::LineLayoutInterface::TextBoxIterator::traverseNextInTextOrder):
+* rendering/line/LineLayoutInterfaceTextBoxes.h:
+
2019-09-20 Zalan Bujtas
[LFC] Introduce LayoutContext class
Modified: trunk/Source/WebCore/dom/Position.cpp (250131 => 250132)
--- trunk/Source/WebCore/dom/Position.cpp 2019-09-20 15:40:09 UTC (rev 250131)
+++ trunk/Source/WebCore/dom/Position.cpp 2019-09-20 15:41:43 UTC (rev 250132)
@@ -37,6 +37,7 @@
#include "InlineElementBox.h"
#include "InlineIterator.h"
#include "InlineTextBox.h"
+#include "LineLayoutInterfaceTextBoxes.h"
#include "Logging.h"
#include "NodeTraversal.h"
#include "PositionIterator.h"
@@ -708,7 +709,10 @@
RenderObject* renderer = currentNode.renderer();
if (!renderer || renderer->style().visibility() != Visibility::Visible)
continue;
+
+// FIXME: The code below doesn't need line boxes.
ensureLineBoxesIfNeeded(*renderer);
+
if (rule == CanCrossEditingBoundary && boundaryCrossed) {
lastVisible = currentPosition;
break;
@@ -733,8 +737,12 @@
// return current position if it is in rendered text
if (is(*renderer)) {
auto& textRenderer = downcast(*renderer);
-if (!textRenderer.firstTextBox())
+
+LineLayoutInterface::Provider lineLayoutProvider;
+auto firstTextBox = lineLayoutProvider.firstTextBoxInTextOrderFor(textRenderer);
+if (!firstTextBox)
continue;
+
if (¤tNode != startNode) {
// This assertion fires in layout tests in the case-transform.html test because
// of a mix-up between offsets in the text in the DOM tree with text in the
@@ -745,40 +753,14 @@
}
unsigned textOffset = currentPosition.offsetInLeafNode();
-auto lastTextBox = textRenderer.lastTextBox();
-for (auto* box = textRenderer.firstTextBox(); box; box = box->nextTextBox()) {
-if (textOffset <= box->start() + box->len()) {
-if (textOffset > box->start())
+for (auto box = firstTextBox; box; box.traverseNextInTextOrder()) {
+if (textOffset <= box->localEndOffset()) {
+if (textOffset > box->localStartOffset())
return currentPosition;
continue;
}
-if (box == lastTextBox || textOffset != box->start() + box->len() + 1)
-continue;
-
-// The text continues on the next line only if the last text box is not on this line and
-// none of the b
[webkit-changes] [250131] trunk/JSTests
Title: [250131] trunk/JSTests
Revision 250131
Author sbar...@apple.com
Date 2019-09-20 08:40:09 -0700 (Fri, 20 Sep 2019)
Log Message
Unreviewed. Make toctou-having-a-bad-time-new-array.js run for less time because it's timing out on the debug bots.
* stress/toctou-having-a-bad-time-new-array.js:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js
Diff
Modified: trunk/JSTests/ChangeLog (250130 => 250131)
--- trunk/JSTests/ChangeLog 2019-09-20 15:23:50 UTC (rev 250130)
+++ trunk/JSTests/ChangeLog 2019-09-20 15:40:09 UTC (rev 250131)
@@ -1,3 +1,9 @@
+2019-09-20 Saam Barati
+
+Unreviewed. Make toctou-having-a-bad-time-new-array.js run for less time because it's timing out on the debug bots.
+
+* stress/toctou-having-a-bad-time-new-array.js:
+
2019-09-19 Yusuke Suzuki
[JSC] DFG op_call_varargs should not assume that one-previous-local of freeReg is usable
Modified: trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js (250130 => 250131)
--- trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js 2019-09-20 15:23:50 UTC (rev 250130)
+++ trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js 2019-09-20 15:40:09 UTC (rev 250131)
@@ -11,6 +11,6 @@
Object.defineProperty(proto, '0', {});
`;
-for (let i = 0; i < 5000; i++) {
+for (let i = 0; i < 2000; i++) {
runString(code);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250130] trunk/Source/WebKit
Title: [250130] trunk/Source/WebKit Revision 250130 Author cdu...@apple.com Date 2019-09-20 08:23:50 -0700 (Fri, 20 Sep 2019) Log Message Regression(r248832): Unable to quicklook HTML files in Mail https://bugs.webkit.org/show_bug.cgi?id=202012 Reviewed by Per Arne Vollan. Follow-up to fix bug in r250110. Now that loadFile() calls maybeInitializeSandboxExtensionHandle(), it no longer needs to call assumeReadAccessToBaseURL(). This is because maybeInitializeSandboxExtensionHandle() already take care of it. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadFile): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (250129 => 250130) --- trunk/Source/WebKit/ChangeLog 2019-09-20 15:07:19 UTC (rev 250129) +++ trunk/Source/WebKit/ChangeLog 2019-09-20 15:23:50 UTC (rev 250130) @@ -1,3 +1,19 @@ +2019-09-20 Chris Dumez + +Regression(r248832): Unable to quicklook HTML files in Mail +https://bugs.webkit.org/show_bug.cgi?id=202012 + + +Reviewed by Per Arne Vollan. + +Follow-up to fix bug in r250110. Now that loadFile() calls +maybeInitializeSandboxExtensionHandle(), it no longer needs to +call assumeReadAccessToBaseURL(). This is because maybeInitializeSandboxExtensionHandle() +already take care of it. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::loadFile): + 2019-09-20 Joonghun Park Unreviewed. Remove duplicated HashMap iteration since r248734. Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (250129 => 250130) --- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 15:07:19 UTC (rev 250129) +++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 15:23:50 UTC (rev 250130) @@ -1236,7 +1236,6 @@ maybeInitializeSandboxExtensionHandle(m_process, fileURL, resourceDirectoryURL, loadParameters.sandboxExtensionHandle); addPlatformLoadParameters(loadParameters); -m_process->assumeReadAccessToBaseURL(*this, resourceDirectoryURL); #if HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_PID) if (m_process->isLaunching()) m_process->send(Messages::WebPage::LoadRequestWaitingForPID(loadParameters, resourceDirectoryURL, m_identifier), m_webPageID); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250129] trunk/Source
Title: [250129] trunk/Source
Revision 250129
Author commit-qu...@webkit.org
Date 2019-09-20 08:07:19 -0700 (Fri, 20 Sep 2019)
Log Message
Implement memory monitoring functions for Linux OS
https://bugs.webkit.org/show_bug.cgi?id=200391
Patch by Paulo Matos on 2019-09-20
Reviewed by Žan Doberšek.
Source/_javascript_Core:
* jsc.cpp:
Source/WTF:
* wtf/PlatformGTK.cmake:
* wtf/PlatformJSCOnly.cmake:
* wtf/PlatformWPE.cmake:
* wtf/linux/ProcessMemoryFootprint.h: Added.
(ProcessMemoryFootprint::now):
(ProcessMemoryFootprint::resetPeak):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformGTK.cmake
trunk/Source/WTF/wtf/PlatformJSCOnly.cmake
trunk/Source/WTF/wtf/PlatformWPE.cmake
Added Paths
trunk/Source/WTF/wtf/linux/ProcessMemoryFootprint.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (250128 => 250129)
--- trunk/Source/_javascript_Core/ChangeLog 2019-09-20 13:36:00 UTC (rev 250128)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-09-20 15:07:19 UTC (rev 250129)
@@ -1,3 +1,12 @@
+2019-09-20 Paulo Matos
+
+Implement memory monitoring functions for Linux OS
+https://bugs.webkit.org/show_bug.cgi?id=200391
+
+Reviewed by Žan Doberšek.
+
+* jsc.cpp:
+
2019-09-20 Devin Rousso
ASSERT NOT REACHED in Inspector::InjectedScriptModule::ensureInjected() seen with inspector/heap/getRemoteObject.html
Modified: trunk/Source/_javascript_Core/jsc.cpp (250128 => 250129)
--- trunk/Source/_javascript_Core/jsc.cpp 2019-09-20 13:36:00 UTC (rev 250128)
+++ trunk/Source/_javascript_Core/jsc.cpp 2019-09-20 15:07:19 UTC (rev 250129)
@@ -140,6 +140,11 @@
#if OS(DARWIN)
#include
+#elif OS(LINUX)
+#include
+#endif
+
+#if OS(DARWIN) || OS(LINUX)
struct MemoryFootprint : ProcessMemoryFootprint {
MemoryFootprint(const ProcessMemoryFootprint& src)
: ProcessMemoryFootprint(src)
Modified: trunk/Source/WTF/ChangeLog (250128 => 250129)
--- trunk/Source/WTF/ChangeLog 2019-09-20 13:36:00 UTC (rev 250128)
+++ trunk/Source/WTF/ChangeLog 2019-09-20 15:07:19 UTC (rev 250129)
@@ -1,3 +1,17 @@
+2019-09-20 Paulo Matos
+
+Implement memory monitoring functions for Linux OS
+https://bugs.webkit.org/show_bug.cgi?id=200391
+
+Reviewed by Žan Doberšek.
+
+* wtf/PlatformGTK.cmake:
+* wtf/PlatformJSCOnly.cmake:
+* wtf/PlatformWPE.cmake:
+* wtf/linux/ProcessMemoryFootprint.h: Added.
+(ProcessMemoryFootprint::now):
+(ProcessMemoryFootprint::resetPeak):
+
2019-09-20 Libor Bukata
UI process crash when using callOnMainThread() after the main thread dispatcher has been destroyed
Modified: trunk/Source/WTF/wtf/PlatformGTK.cmake (250128 => 250129)
--- trunk/Source/WTF/wtf/PlatformGTK.cmake 2019-09-20 13:36:00 UTC (rev 250128)
+++ trunk/Source/WTF/wtf/PlatformGTK.cmake 2019-09-20 15:07:19 UTC (rev 250129)
@@ -12,6 +12,7 @@
if (CMAKE_SYSTEM_NAME MATCHES "Linux")
list(APPEND WTF_PUBLIC_HEADERS
+linux/ProcessMemoryFootprint.h
linux/CurrentProcessMemoryStatus.h
)
endif ()
Modified: trunk/Source/WTF/wtf/PlatformJSCOnly.cmake (250128 => 250129)
--- trunk/Source/WTF/wtf/PlatformJSCOnly.cmake 2019-09-20 13:36:00 UTC (rev 250128)
+++ trunk/Source/WTF/wtf/PlatformJSCOnly.cmake 2019-09-20 15:07:19 UTC (rev 250129)
@@ -85,6 +85,7 @@
linux/MemoryPressureHandlerLinux.cpp
)
list(APPEND WTF_PUBLIC_HEADERS
+linux/ProcessMemoryFootprint.h
linux/CurrentProcessMemoryStatus.h
)
else ()
Modified: trunk/Source/WTF/wtf/PlatformWPE.cmake (250128 => 250129)
--- trunk/Source/WTF/wtf/PlatformWPE.cmake 2019-09-20 13:36:00 UTC (rev 250128)
+++ trunk/Source/WTF/wtf/PlatformWPE.cmake 2019-09-20 15:07:19 UTC (rev 250129)
@@ -7,6 +7,7 @@
glib/RunLoopSourcePriority.h
glib/WTFGType.h
+linux/ProcessMemoryFootprint.h
linux/CurrentProcessMemoryStatus.h
)
Added: trunk/Source/WTF/wtf/linux/ProcessMemoryFootprint.h (0 => 250129)
--- trunk/Source/WTF/wtf/linux/ProcessMemoryFootprint.h (rev 0)
+++ trunk/Source/WTF/wtf/linux/ProcessMemoryFootprint.h 2019-09-20 15:07:19 UTC (rev 250129)
@@ -0,0 +1,62 @@
+/*
+ * Copyright (C) 2019 Metrological Group B.V.
+ * Copyright (C) 2019 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANT
[webkit-changes] [250128] trunk/Source/WebCore
Title: [250128] trunk/Source/WebCore Revision 250128 Author za...@apple.com Date 2019-09-20 06:36:00 -0700 (Fri, 20 Sep 2019) Log Message [LFC] Introduce LayoutContext class https://bugs.webkit.org/show_bug.cgi?id=202026 Reviewed by Antti Koivisto. Move context related functionality from LayoutState to LayoutContext. To initiate a layout, create a LayoutContext, pass the current LayoutState object in and call layout(). * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * layout/FormattingContext.cpp: (WebCore::Layout::FormattingContext::layoutOutOfFlowContent): * layout/FormattingContext.h: * layout/FormattingContextGeometry.cpp: (WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth): * layout/LayoutState.cpp: (WebCore::Layout::LayoutState::createFormattingStateForFormattingRootIfNeeded): (WebCore::Layout::LayoutState::updateLayout): Deleted. (WebCore::Layout::LayoutState::layoutFormattingContextSubtree): Deleted. (WebCore::Layout::LayoutState::styleChanged): Deleted. (WebCore::Layout::LayoutState::markNeedsUpdate): Deleted. (WebCore::Layout::LayoutState::createFormattingContext): Deleted. (WebCore::Layout::LayoutState::run): Deleted. * layout/LayoutState.h: (WebCore::Layout::LayoutState::hasFormattingState const): (WebCore::Layout::LayoutState::setQuirksMode): (WebCore::Layout::LayoutState::inNoQuirksMode const): (WebCore::Layout::LayoutState::updateAll): Deleted. * layout/Verification.cpp: (WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree): (WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const): Deleted. * layout/blockformatting/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot): * layout/blockformatting/BlockFormattingContextGeometry.cpp: (WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints): * layout/blockformatting/BlockInvalidation.cpp: (WebCore::Layout::computeUpdateType): (WebCore::Layout::computeUpdateTypeForAncestor): (WebCore::Layout::BlockInvalidation::invalidate): * layout/blockformatting/BlockInvalidation.h: * layout/displaytree/DisplayBox.h: * layout/inlineformatting/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot): (WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot): * layout/inlineformatting/InlineInvalidation.cpp: (WebCore::Layout::InlineInvalidation::invalidate): * layout/inlineformatting/InlineInvalidation.h: * layout/layouttree/LayoutTreeBuilder.cpp: (WebCore::Layout::printLayoutTreeForLiveDocuments): * layout/tableformatting/TableFormattingContext.cpp: (WebCore::Layout::TableFormattingContext::layoutTableCellBox): (WebCore::Layout::TableFormattingContext::computePreferredWidthForColumns): * layout/tableformatting/TableInvalidation.cpp: (WebCore::Layout::TableInvalidation::invalidate): * layout/tableformatting/TableInvalidation.h: * page/FrameViewLayoutContext.cpp: (WebCore::layoutUsingFormattingContext): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/layout/FormattingContext.cpp trunk/Source/WebCore/layout/FormattingContext.h trunk/Source/WebCore/layout/FormattingContextGeometry.cpp trunk/Source/WebCore/layout/LayoutState.cpp trunk/Source/WebCore/layout/LayoutState.h trunk/Source/WebCore/layout/Verification.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp trunk/Source/WebCore/layout/blockformatting/BlockInvalidation.cpp trunk/Source/WebCore/layout/blockformatting/BlockInvalidation.h trunk/Source/WebCore/layout/displaytree/DisplayBox.h trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp trunk/Source/WebCore/layout/inlineformatting/InlineInvalidation.cpp trunk/Source/WebCore/layout/inlineformatting/InlineInvalidation.h trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp trunk/Source/WebCore/layout/tableformatting/TableInvalidation.cpp trunk/Source/WebCore/layout/tableformatting/TableInvalidation.h trunk/Source/WebCore/page/FrameViewLayoutContext.cpp Added Paths trunk/Source/WebCore/layout/LayoutContext.cpp trunk/Source/WebCore/layout/LayoutContext.h Diff Modified: trunk/Source/WebCore/ChangeLog (250127 => 250128) --- trunk/Source/WebCore/ChangeLog 2019-09-20 11:00:53 UTC (rev 250127) +++ trunk/Source/WebCore/ChangeLog 2019-09-20 13:36:00 UTC (rev 250128) @@ -1,3 +1,64 @@ +2019-09-20 Zalan Bujtas + +[LFC] Introduce LayoutContext class +https://bugs.webkit.org/show_bug.cgi?id=202026 + + +Reviewed by Antti Koivisto. + +Move context related functionality from LayoutState to LayoutContext. +To initiate a layout, create a LayoutContext, pass the current LayoutState object in and call layout(). + +
[webkit-changes] [250126] trunk/Source/WTF
Title: [250126] trunk/Source/WTF
Revision 250126
Author commit-qu...@webkit.org
Date 2019-09-20 01:45:03 -0700 (Fri, 20 Sep 2019)
Log Message
UI process crash when using callOnMainThread() after the main thread dispatcher has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=197266
Patch by Libor Bukata on 2019-09-20
Reviewed by Carlos Garcia Campos.
* wtf/generic/MainThreadGeneric.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (250125 => 250126)
--- trunk/Source/WTF/ChangeLog 2019-09-20 08:33:26 UTC (rev 250125)
+++ trunk/Source/WTF/ChangeLog 2019-09-20 08:45:03 UTC (rev 250126)
@@ -1,3 +1,13 @@
+2019-09-20 Libor Bukata
+
+UI process crash when using callOnMainThread() after the main thread dispatcher has been destroyed
+https://bugs.webkit.org/show_bug.cgi?id=197266
+
+Reviewed by Carlos Garcia Campos.
+
+* wtf/generic/MainThreadGeneric.cpp:
+(WTF::scheduleDispatchFunctionsOnMainThread):
+
2019-09-17 Mark Lam
Use constexpr instead of const in symbol definitions that are obviously constexpr.
Modified: trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp (250125 => 250126)
--- trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp 2019-09-20 08:33:26 UTC (rev 250125)
+++ trunk/Source/WTF/wtf/generic/MainThreadGeneric.cpp 2019-09-20 08:45:03 UTC (rev 250126)
@@ -3,6 +3,7 @@
* Copyright (C) 2007 Justin Haygood (jhayg...@reaktix.com)
* Copyright (C) 2016 Konstantin Tokavev
* Copyright (C) 2016 Yusuke Suzuki
+ * Copyright (C) 2019 Oracle and/or its affiliates. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -36,6 +37,7 @@
#endif
#include
+#include
#if USE(GLIB)
#include
#endif
@@ -101,8 +103,8 @@
{
// Use a RunLoop::Timer instead of RunLoop::dispatch() to be able to use a different priority and
// avoid the double queue because dispatchOnMainThread also queues the functions.
-static MainThreadDispatcher dispatcher;
-dispatcher.schedule();
+static NeverDestroyed dispatcher;
+dispatcher.get().schedule();
}
} // namespace WTF
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250124] trunk/Source/JavaScriptCore
Title: [250124] trunk/Source/_javascript_Core
Revision 250124
Author drou...@apple.com
Date 2019-09-20 01:28:09 -0700 (Fri, 20 Sep 2019)
Log Message
ASSERT NOT REACHED in Inspector::InjectedScriptModule::ensureInjected() seen with inspector/heap/getRemoteObject.html
https://bugs.webkit.org/show_bug.cgi?id=201713
Reviewed by Joseph Pecoraro.
Expose the `Exception` object by leveraging an `Expected` of `JSValue` as the return value
instead of using a referenced `bool` (which wouldn't include any of the exception's info).
* bindings/ScriptFunctionCall.h:
* bindings/ScriptFunctionCall.cpp:
(Deprecated::ScriptFunctionCall::call):
* inspector/InjectedScript.cpp:
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapJSONString const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::findObjectById const):
(Inspector::InjectedScript::releaseObjectGroup):
* inspector/InjectedScriptBase.h:
* inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled const):
(Inspector::InjectedScriptBase::makeCall):
(Inspector::InjectedScriptBase::makeAsyncCall):
* inspector/InjectedScriptManager.h:
* inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::createInjectedScript):
(Inspector::InjectedScriptManager::injectedScriptFor):
* inspector/InjectedScriptModule.cpp:
(Inspector::InjectedScriptModule::ensureInjected):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.cpp
trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.h
trunk/Source/_javascript_Core/inspector/InjectedScript.cpp
trunk/Source/_javascript_Core/inspector/InjectedScriptBase.cpp
trunk/Source/_javascript_Core/inspector/InjectedScriptBase.h
trunk/Source/_javascript_Core/inspector/InjectedScriptManager.cpp
trunk/Source/_javascript_Core/inspector/InjectedScriptManager.h
trunk/Source/_javascript_Core/inspector/InjectedScriptModule.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (250123 => 250124)
--- trunk/Source/_javascript_Core/ChangeLog 2019-09-20 07:09:59 UTC (rev 250123)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-09-20 08:28:09 UTC (rev 250124)
@@ -1,3 +1,41 @@
+2019-09-20 Devin Rousso
+
+ASSERT NOT REACHED in Inspector::InjectedScriptModule::ensureInjected() seen with inspector/heap/getRemoteObject.html
+https://bugs.webkit.org/show_bug.cgi?id=201713
+
+
+Reviewed by Joseph Pecoraro.
+
+Expose the `Exception` object by leveraging an `Expected` of `JSValue` as the return value
+instead of using a referenced `bool` (which wouldn't include any of the exception's info).
+
+* bindings/ScriptFunctionCall.h:
+* bindings/ScriptFunctionCall.cpp:
+(Deprecated::ScriptFunctionCall::call):
+
+* inspector/InjectedScript.cpp:
+(Inspector::InjectedScript::wrapCallFrames const):
+(Inspector::InjectedScript::wrapObject const):
+(Inspector::InjectedScript::wrapJSONString const):
+(Inspector::InjectedScript::wrapTable const):
+(Inspector::InjectedScript::previewValue const):
+(Inspector::InjectedScript::findObjectById const):
+(Inspector::InjectedScript::releaseObjectGroup):
+
+* inspector/InjectedScriptBase.h:
+* inspector/InjectedScriptBase.cpp:
+(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled const):
+(Inspector::InjectedScriptBase::makeCall):
+(Inspector::InjectedScriptBase::makeAsyncCall):
+
+* inspector/InjectedScriptManager.h:
+* inspector/InjectedScriptManager.cpp:
+(Inspector::InjectedScriptManager::createInjectedScript):
+(Inspector::InjectedScriptManager::injectedScriptFor):
+
+* inspector/InjectedScriptModule.cpp:
+(Inspector::InjectedScriptModule::ensureInjected):
+
2019-09-19 Yusuke Suzuki
[JSC] DFG op_call_varargs should not assume that one-previous-local of freeReg is usable
Modified: trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.cpp (250123 => 250124)
--- trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.cpp 2019-09-20 07:09:59 UTC (rev 250123)
+++ trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.cpp 2019-09-20 08:28:09 UTC (rev 250124)
@@ -102,7 +102,7 @@
{
}
-JSValue ScriptFunctionCall::call(bool& hadException)
+Expected> ScriptFunctionCall::call()
{
JSObject* thisObject = m_thisObject.jsObject();
@@ -111,10 +111,8 @@
auto scope = DECLARE_THROW_SCOPE(vm);
JSValue function = thisObject->get(m_exec, Identifier::fromString(vm, m_name));
-if (UNLIKELY(scope.exception())) {
-hadException = true;
-return { };
-}
+if (UNLIKELY(scope.exception()))
+return makeUnexpected(scope.exception());
CallData callData;
CallTyp
