date:20191007

[webkit-changes] [250815] trunk/Source/bmalloc

2019-10-07 Thread wenson_hsieh

Title: [250815] trunk/Source/bmalloc








Revision 250815
Author wenson_hs...@apple.com
Date 2019-10-07 21:56:31 -0700 (Mon, 07 Oct 2019)


Log Message
Add a missing #include in DeferredTriggerInlines.h
https://bugs.webkit.org/show_bug.cgi?id=202677

Reviewed by Yusuke Suzuki.

DeferredTriggerInlines.h uses RELEASE_BASSERT, but does not include BAssert.h. This causes
subsequent build failures when shuffling around some sources in WebCore that then attempt to
include .

* bmalloc/DeferredTriggerInlines.h:

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/DeferredTriggerInlines.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (250814 => 250815)

--- trunk/Source/bmalloc/ChangeLog	2019-10-08 04:50:03 UTC (rev 250814)
+++ trunk/Source/bmalloc/ChangeLog	2019-10-08 04:56:31 UTC (rev 250815)
@@ -1,3 +1,16 @@
+2019-10-07  Wenson Hsieh  
+
+Add a missing #include in DeferredTriggerInlines.h
+https://bugs.webkit.org/show_bug.cgi?id=202677
+
+Reviewed by Yusuke Suzuki.
+
+DeferredTriggerInlines.h uses RELEASE_BASSERT, but does not include BAssert.h. This causes
+subsequent build failures when shuffling around some sources in WebCore that then attempt to
+include .
+
+* bmalloc/DeferredTriggerInlines.h:
+
 2019-09-24  Keith Rollin  
 
 Address static analysis warning in Allocator.cpp: Null pointer argument in call to memory copy function


Modified: trunk/Source/bmalloc/bmalloc/DeferredTriggerInlines.h (250814 => 250815)

--- trunk/Source/bmalloc/bmalloc/DeferredTriggerInlines.h	2019-10-08 04:50:03 UTC (rev 250814)
+++ trunk/Source/bmalloc/bmalloc/DeferredTriggerInlines.h	2019-10-08 04:56:31 UTC (rev 250815)
@@ -25,6 +25,7 @@
 
 #pragma once
 
+#include "BAssert.h"
 #include "DeferredTrigger.h"
 
 namespace bmalloc {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250814] trunk/Source/WebInspectorUI

2019-10-07 Thread drousso

Title: [250814] trunk/Source/WebInspectorUI








Revision 250814
Author drou...@apple.com
Date 2019-10-07 21:50:03 -0700 (Mon, 07 Oct 2019)


Log Message
Web Inspector: Settings: enable the image transparency grid by default and create a checkbox for it
https://bugs.webkit.org/show_bug.cgi?id=202678

Reviewed by Matt Baker.

* UserInterface/Base/Setting.js:
Enable the "Show transparency grid" setting by default.

* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createSourcesSettingsView):
Add a checkbox for "Show transparency grid" in the "Sources" pane.

* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
* UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView):
* UserInterface/Views/ImageResourceContentView.js:
(WI.ImageResourceContentView):
* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
* UserInterface/Views/ResourceCollectionContentView.js:
(WI.ResourceCollectionContentView):
* Localizations/en.lproj/localizedStrings.js:
Unify the tooltip string for all of the "Show transparency grid" navigation items.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (250813 => 250814)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-10-08 04:50:03 UTC (rev 250814)
@@ -1,5 +1,32 @@
 2019-10-07  Devin Rousso  
 
+Web Inspector: Settings: enable the image transparency grid by default and create a checkbox for it
+https://bugs.webkit.org/show_bug.cgi?id=202678
+
+Reviewed by Matt Baker.
+
+* UserInterface/Base/Setting.js:
+Enable the "Show transparency grid" setting by default.
+
+* UserInterface/Views/SettingsTabContentView.js:
+(WI.SettingsTabContentView.prototype._createSourcesSettingsView):
+Add a checkbox for "Show transparency grid" in the "Sources" pane.
+
+* UserInterface/Views/CanvasContentView.js:
+(WI.CanvasContentView):
+* UserInterface/Views/CanvasOverviewContentView.js:
+(WI.CanvasOverviewContentView):
+* UserInterface/Views/ImageResourceContentView.js:
+(WI.ImageResourceContentView):
+* UserInterface/Views/RecordingContentView.js:
+(WI.RecordingContentView):
+* UserInterface/Views/ResourceCollectionContentView.js:
+(WI.ResourceCollectionContentView):
+* Localizations/en.lproj/localizedStrings.js:
+Unify the tooltip string for all of the "Show transparency grid" navigation items.
+
+2019-10-07  Devin Rousso  
+
 Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
 https://bugs.webkit.org/show_bug.cgi?id=202376
 


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (250813 => 250814)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-10-08 04:34:53 UTC (rev 250813)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-10-08 04:50:03 UTC (rev 250814)
@@ -466,7 +466,6 @@
 localizedStrings["Ensure that values for \u0022%s\u0022 are valid."] = "Ensure that values for \u0022%s\u0022 are valid.";
 localizedStrings["Entered Full-Screen Mode"] = "Entered Full-Screen Mode";
 localizedStrings["Entire Recording"] = "Entire Recording";
-localizedStrings["Entry point: "] = "Entry point: ";
 localizedStrings["Error"] = "Error";
 localizedStrings["Error: "] = "Error: ";
 localizedStrings["Errors"] = "Errors";
@@ -579,7 +578,6 @@
 localizedStrings["Hide Console"] = "Hide Console";
 localizedStrings["Hide Console (%s)"] = "Hide Console (%s)";
 localizedStrings["Hide Elements"] = "Hide Elements";
-localizedStrings["Hide Grid"] = "Hide Grid";
 localizedStrings["Hide Path"] = "Hide Path";
 localizedStrings["Hide compositing borders"] = "Hide compositing borders";
 localizedStrings["Hide rulers"] = "Hide rulers";
@@ -586,6 +584,7 @@
 localizedStrings["Hide shadow DOM nodes"] = "Hide shadow DOM nodes";
 localizedStrings["Hide the details sidebar (%s)"] = "Hide the details sidebar (%s)";
 localizedStrings["Hide the navigation sidebar (%s)"] = "Hide the navigation sidebar (%s)";
+localizedStrings["Hide transparency grid"] = "Hide transparency grid";
 localizedStrings["Hide type information"] = "Hide type

[webkit-changes] [250813] trunk/Source/WebInspectorUI

2019-10-07 Thread drousso

Title: [250813] trunk/Source/WebInspectorUI








Revision 250813
Author drou...@apple.com
Date 2019-10-07 21:34:53 -0700 (Mon, 07 Oct 2019)


Log Message
Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
https://bugs.webkit.org/show_bug.cgi?id=202376

Reviewed by Matt Baker.

* UserInterface/Models/Resource.js:
(WI.Resource.prototype.get supportsScriptBlackboxing):

* UserInterface/Views/SourceCodeTreeElement.js:
(WI.SourceCodeTreeElement.prototype.updateStatus):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js
trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (250812 => 250813)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-10-08 02:45:22 UTC (rev 250812)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-10-08 04:34:53 UTC (rev 250813)
@@ -1,3 +1,16 @@
+2019-10-07  Devin Rousso  
+
+Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load
+https://bugs.webkit.org/show_bug.cgi?id=202376
+
+Reviewed by Matt Baker.
+
+* UserInterface/Models/Resource.js:
+(WI.Resource.prototype.get supportsScriptBlackboxing):
+
+* UserInterface/Views/SourceCodeTreeElement.js:
+(WI.SourceCodeTreeElement.prototype.updateStatus):
+
 2019-10-02  Nikita Vasilyev  
 
 Web Inspector: Styles: for rules that don't match selected node, property values always show as invalid


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (250812 => 250813)

--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2019-10-08 02:45:22 UTC (rev 250812)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2019-10-08 04:34:53 UTC (rev 250813)
@@ -373,6 +373,8 @@
 {
 if (this.isLocalResourceOverride)
 return false;
+if (!this.finished || this.failed)
+return false;
 return super.supportsScriptBlackboxing;
 }
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js (250812 => 250813)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js	2019-10-08 02:45:22 UTC (rev 250812)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js	2019-10-08 04:34:53 UTC (rev 250813)
@@ -168,7 +168,8 @@
 
 this.status = this._toggleBlackboxedImageElement;
 this._updateToggleBlackboxImageElementState();
-}
+} else if (this.status === this._toggleBlackboxedImageElement)
+this.status = null;
 }
 
 // Protected (ResourceTreeElement calls this when its Resource changes dynamically for Frames)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250812] releases/Apple

2019-10-07 Thread mitz

Title: [250812] releases/Apple








Revision 250812
Author m...@apple.com
Date 2019-10-07 19:45:22 -0700 (Mon, 07 Oct 2019)


Log Message
Added a tag for Safari 13.0.2.

Added Paths

releases/Apple/Safari 13.0.2/
releases/Apple/Safari 13.0.2/ANGLE/
releases/Apple/Safari 13.0.2/_javascript_Core/
releases/Apple/Safari 13.0.2/WTF/
releases/Apple/Safari 13.0.2/WebCore/
releases/Apple/Safari 13.0.2/WebInspectorUI/
releases/Apple/Safari 13.0.2/WebKit/
releases/Apple/Safari 13.0.2/WebKitLegacy/
releases/Apple/Safari 13.0.2/bmalloc/
releases/Apple/Safari 13.0.2/libwebrtc/




Diff
Index: releases/Apple/Safari 13.0.2/ANGLE
===
--- tags/Safari-608.2.30.1.1/Source/ThirdParty/ANGLE	2019-10-08 01:16:08 UTC (rev 250811)
+++ releases/Apple/Safari 13.0.2/ANGLE	2019-10-08 02:45:22 UTC (rev 250812)

Property changes: releases/Apple/Safari 13.0.2/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.2/_javascript_Core
===
--- tags/Safari-608.2.30.1.1/Source/_javascript_Core	2019-10-08 01:16:08 UTC (rev 250811)
+++ releases/Apple/Safari 13.0.2/_javascript_Core	2019-10-08 02:45:22 UTC (rev 250812)

Property changes: releases/Apple/Safari 13.0.2/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.2/WTF
===
--- tags/Safari-608.2.30.1.1/Source/WTF	2019-10-08 01:16:08 UTC (rev 250811)
+++ releases/Apple/Safari 13.0.2/WTF	2019-10-08 02:45:22 UTC (rev 250812)

Property changes: releases/Apple/Safari 13.0.2/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.2/WebInspectorUI
===
--- tags/Safari-608.2.30.1.1/Source/WebInspectorUI	2019-10-08 01:16:08 UTC (rev 250811)
+++ releases/Apple/Safari 13.0.2/WebInspectorUI	2019-10-08 02:45:22 UTC (rev 250812)

Property changes: releases/Apple/Safari 13.0.2/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.2/bmalloc
===
--- tags/Safari-608.2.30.1.1/Source/bmalloc	2019-10-08 01:16:08 UTC (rev 250811)
+++ releases/Apple/Safari 13.0.2/bmalloc	2019-10-08 02:45:22 UTC (rev 250812)

Property changes: releases/Apple/Safari 13.0.2/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.2/libwebrtc
===
--- tags/Safari-608.2.30.1.1/Source/ThirdParty/libwebrtc	2019-10-08 01:16:08 UTC (rev 250811)
+++ releases/Apple/Safari 13.0.2/libwebrtc	2019-10-08 02:45:22 UTC (rev 250812)

Property changes: releases/Apple/Safari 13.0.2/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455,248143,248162
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250810] trunk/Source/JavaScriptCore

2019-10-07 Thread ysuzuki

Title: [250810] trunk/Source/_javascript_Core








Revision 250810
Author ysuz...@apple.com
Date 2019-10-07 18:10:24 -0700 (Mon, 07 Oct 2019)


Log Message
[JSC] Clean up ThunkGenerator's nativeCallTrampoline generator code
https://bugs.webkit.org/show_bug.cgi?id=202657

Reviewed by Saam Barati.

ThunkGenerator has per-architecture JIT code for nativeForGenerator, but this is unnecessary.
This patch cleans up it and unifies the implementations.

* jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (250809 => 250810)

--- trunk/Source/_javascript_Core/ChangeLog	2019-10-08 01:02:45 UTC (rev 250809)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-10-08 01:10:24 UTC (rev 250810)
@@ -1,3 +1,16 @@
+2019-10-07  Yusuke Suzuki  
+
+[JSC] Clean up ThunkGenerator's nativeCallTrampoline generator code
+https://bugs.webkit.org/show_bug.cgi?id=202657
+
+Reviewed by Saam Barati.
+
+ThunkGenerator has per-architecture JIT code for nativeForGenerator, but this is unnecessary.
+This patch cleans up it and unifies the implementations.
+
+* jit/ThunkGenerators.cpp:
+(JSC::nativeForGenerator):
+
 2019-10-07  Saam Barati  
 
 Allow OSR exit to the LLInt


Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (250809 => 250810)

--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2019-10-08 01:02:45 UTC (rev 250809)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2019-10-08 01:10:24 UTC (rev 250810)
@@ -245,9 +245,6 @@
 // FIXME: This should be able to log ShadowChicken prologue packets.
 // https://bugs.webkit.org/show_bug.cgi?id=155689
 
-// FIXME: We should clean up by removing per-architecture code.
-// https://bugs.webkit.org/show_bug.cgi?id=202657
-
 int executableOffsetToFunction = NativeExecutable::offsetOfNativeFunctionFor(kind);
 
 JSInterfaceJIT jit();
@@ -269,101 +266,36 @@
 }
 
 jit.emitPutToCallFrameHeader(0, CallFrameSlot::codeBlock);
-jit.storePtr(JSInterfaceJIT::callFrameRegister, );
+jit.storePtr(GPRInfo::callFrameRegister, );
 
-#if CPU(X86_64)
-#if !OS(WINDOWS)
-// Calling convention:  f(edi, esi, edx, ecx, ...);
 // Host function signature: f(JSGlobalObject*, CallFrame*);
-jit.move(JSInterfaceJIT::callFrameRegister, X86Registers::esi);
-
-jit.emitGetFromCallFrameHeaderPtr(CallFrameSlot::callee, X86Registers::edi);
-if (thunkFunctionType == ThunkFunctionType::JSFunction) {
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::edi, JSFunction::offsetOfExecutable()), X86Registers::r9);
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::edi, JSFunction::offsetOfGlobalObject()), X86Registers::edi);
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::r9, executableOffsetToFunction), X86Registers::r9);
-} else {
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::edi, InternalFunction::offsetOfNativeFunctionFor(kind)), X86Registers::r9);
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::edi, InternalFunction::offsetOfGlobalObject()), X86Registers::edi);
-}
-jit.call(X86Registers::r9, JSEntryPtrTag);
-
-#else
-// Calling convention:  f(ecx, edx, r8, r9, ...);
-// Host function signature: f(JSGlobalObject*, CallFrame*);
-jit.move(JSInterfaceJIT::callFrameRegister, X86Registers::edx);
-
+#if CPU(X86_64) && OS(WINDOWS)
 // Leave space for the callee parameter home addresses.
 // At this point the stack is aligned to 16 bytes, but if this changes at some point, we need to emit code to align it.
-jit.subPtr(JSInterfaceJIT::TrustedImm32(4 * sizeof(int64_t)), JSInterfaceJIT::stackPointerRegister);
-
-jit.emitGetFromCallFrameHeaderPtr(CallFrameSlot::callee, X86Registers::ecx);
-if (thunkFunctionType == ThunkFunctionType::JSFunction) {
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::ecx, JSFunction::offsetOfExecutable()), X86Registers::r9);
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::ecx, JSFunction::offsetOfGlobalObject()), X86Registers::ecx);
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::r9, executableOffsetToFunction), X86Registers::r9);
-} else {
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::ecx, InternalFunction::offsetOfNativeFunctionFor(kind)), X86Registers::r9);
-jit.loadPtr(JSInterfaceJIT::Address(X86Registers::ecx, InternalFunction::offsetOfGlobalObject()), X86Registers::ecx);
-}
-jit.call(X86Registers::r9, JSEntryPtrTag);
-
-jit.addPtr(JSInterfaceJIT::TrustedImm32(4 * sizeof(int64_t)), JSInterfaceJIT::stackPointerRegister);
-#endif
-
-#elif CPU(ARM64)
-COMPILE_ASSERT(ARM64Registers::x0 != JSInterfaceJIT::regT3, T3_not_trampled_by_arg_0);
-COMPILE_ASSERT(ARM64Registers::x1 != JSInterfaceJIT::regT3,

[webkit-changes] [250809] trunk/Source

2019-10-07 Thread commit-queue

Title: [250809] trunk/Source








Revision 250809
Author commit-qu...@webkit.org
Date 2019-10-07 18:02:45 -0700 (Mon, 07 Oct 2019)


Log Message
Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)
https://bugs.webkit.org/show_bug.cgi?id=199705

Patch by Dan Bernstein and Kenneth Russell.
Patch by Alexey Proskuryakov  on 2019-10-07
Reviewed by Alexey Proskuryakov.

Source/WebCore/PAL:

* pal/spi/mac/NSViewSPI.h: Declare _subviews when we are not using the
replacement SPI, but the SDK doesn't declare the ivar (because the SDK is too new).

Source/WTF:

* wtf/Platform.h: Added HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h




Diff

Modified: trunk/Source/WTF/ChangeLog (250808 => 250809)

--- trunk/Source/WTF/ChangeLog	2019-10-08 00:14:52 UTC (rev 250808)
+++ trunk/Source/WTF/ChangeLog	2019-10-08 01:02:45 UTC (rev 250809)
@@ -1,3 +1,13 @@
+2019-10-07  Alexey Proskuryakov  
+
+Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)
+https://bugs.webkit.org/show_bug.cgi?id=199705
+
+Patch by Dan Bernstein and Kenneth Russell.
+Reviewed by Alexey Proskuryakov.
+
+* wtf/Platform.h: Added HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK.
+
 2019-10-04  Commit Queue  
 
 Unreviewed, rolling out r250762.


Modified: trunk/Source/WTF/wtf/Platform.h (250808 => 250809)

--- trunk/Source/WTF/wtf/Platform.h	2019-10-08 00:14:52 UTC (rev 250808)
+++ trunk/Source/WTF/wtf/Platform.h	2019-10-08 01:02:45 UTC (rev 250809)
@@ -1623,6 +1623,10 @@
 #define HAVE_SUBVIEWS_IVAR_SPI 1
 #endif
 
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101500
+#define HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK 1
+#endif
+
 #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11) || PLATFORM(WATCHOS) || PLATFORM(APPLETV)
 #define USE_PLATFORM_SYSTEM_FALLBACK_LIST 1
 #endif


Modified: trunk/Source/WebCore/PAL/ChangeLog (250808 => 250809)

--- trunk/Source/WebCore/PAL/ChangeLog	2019-10-08 00:14:52 UTC (rev 250808)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-10-08 01:02:45 UTC (rev 250809)
@@ -1,3 +1,14 @@
+2019-10-07  Alexey Proskuryakov  
+
+Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)
+https://bugs.webkit.org/show_bug.cgi?id=199705
+
+Patch by Dan Bernstein and Kenneth Russell.
+Reviewed by Alexey Proskuryakov.
+
+* pal/spi/mac/NSViewSPI.h: Declare _subviews when we are not using the
+replacement SPI, but the SDK doesn't declare the ivar (because the SDK is too new).
+
 2019-10-04  Alex Christensen  
 
 Simplify sandbox enabling macros


Modified: trunk/Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h (250808 => 250809)

--- trunk/Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h	2019-10-08 00:14:52 UTC (rev 250808)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h	2019-10-08 01:02:45 UTC (rev 250809)
@@ -29,7 +29,12 @@
 
 #import 
 
-@interface NSView () 
+@interface NSView ()  {
+#if !HAVE(SUBVIEWS_IVAR_SPI) && !HAVE(SUBVIEWS_IVAR_DECLARED_BY_SDK)
+@package
+NSMutableArray<__kindof NSView *> *_subviews;
+#endif
+}
 
 - (NSView *)_findLastViewInKeyViewLoop;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250808] trunk/Tools

2019-10-07 Thread dino

Title: [250808] trunk/Tools








Revision 250808
Author d...@apple.com
Date 2019-10-07 17:14:52 -0700 (Mon, 07 Oct 2019)


Log Message
Various filter-build-webkit updates
https://bugs.webkit.org/show_bug.cgi?id=202558

Reviewed by Tim Horton.

Add rules for:
- RuleScriptExecution
- tapi
- plutil
- A postprocessing ANGLE script
- "Prepare build"
- Signing Identity

* Scripts/filter-build-webkit:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/filter-build-webkit




Diff

Modified: trunk/Tools/ChangeLog (250807 => 250808)

--- trunk/Tools/ChangeLog	2019-10-07 23:53:24 UTC (rev 250807)
+++ trunk/Tools/ChangeLog	2019-10-08 00:14:52 UTC (rev 250808)
@@ -1,3 +1,20 @@
+2019-10-07  Dean Jackson  
+
+Various filter-build-webkit updates
+https://bugs.webkit.org/show_bug.cgi?id=202558
+
+Reviewed by Tim Horton.
+
+Add rules for:
+- RuleScriptExecution
+- tapi
+- plutil
+- A postprocessing ANGLE script
+- "Prepare build"
+- Signing Identity
+
+* Scripts/filter-build-webkit:
+
 2019-10-07  Saam Barati  
 
 Allow OSR exit to the LLInt


Modified: trunk/Tools/Scripts/filter-build-webkit (250807 => 250808)

--- trunk/Tools/Scripts/filter-build-webkit	2019-10-07 23:53:24 UTC (rev 250807)
+++ trunk/Tools/Scripts/filter-build-webkit	2019-10-08 00:14:52 UTC (rev 250808)
@@ -138,11 +138,13 @@
 $buildFinished = 1;
 } elsif ($line =~ /^===/) {
 printLine($line, STYLE_HEADER);
+} elsif ($line =~ /^note: using/) {
+printLine($line, STYLE_HEADER);
 } elsif ($line =~ /Checking Dependencies|Check dependencies|Create product structure|Write auxiliary files|LinkStoryboards/) {
 printLine($line, STYLE_PLAIN);
 } elsif ($line =~ /\*\* BUILD SUCCEEDED \*\*/) {
 printLine("Build Succeeded", STYLE_SUCCESS);
-} elsif ($line =~ /^(\e\[1m)?(PhaseScriptExecution|ClCompile|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Preprocess|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|AnalyzeShallow|ProcessProductPackaging|CodeSign|Validate|SymLink|Updating|CompileDTraceScript|CompileXIB|StripNIB|CopyPlistFile|GenerateDSYMFile|GenerateTAPI|CompileStoryboard|ExternalBuildToolExecution)(\e\[0m)? ("[^"]+"|(\\|(?<=\\)\s|\S)+)?/) {
+} elsif ($line =~ /^(\e\[1m)?(PhaseScriptExecution|RuleScriptExecution|ClCompile|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Preprocess|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|AnalyzeShallow|ProcessProductPackaging|CodeSign|Validate|SymLink|Updating|CompileDTraceScript|CompileXIB|StripNIB|CopyPlistFile|GenerateDSYMFile|GenerateTAPI|CompileStoryboard|ExternalBuildToolExecution)(\e\[0m)? ("[^"]+"|(\\|(?<=\\)\s|\S)+)?/) {
 my ($command, $path) = ($2, basename($4));
 $path =~ s/("|\\|\.[ah]$)//g;
 printLine("$command $path", STYLE_PLAIN);
@@ -149,6 +151,12 @@
 } elsif ($line =~ /^\S+mkdir .*?(\S+)$/) {
 my $path = basename($1);
 printLine("mkdir $path", STYLE_PLAIN);
+} elsif ($line =~ /^\S+\/usr\/bin\/tapi reexport .*?(\S+)$/) {
+my $path = basename($1);
+printLine("tapi $path", STYLE_PLAIN);
+} elsif ($line =~ /^plutil .*?(\S+)$/) {
+my $path = basename($1);
+printLine("plutil $path", STYLE_PLAIN);
 } elsif ($line =~ /^cp (\S+)/) {
 my $path = basename($1);
 printLine("cp $path", STYLE_PLAIN);
@@ -167,8 +175,14 @@
 printLine("Generating $command $path", STYLE_PLAIN);
 } elsif ($line =~ /^(Generating|Merging) (\S+) (from|for) (\S+)/) {
 printLine($line, STYLE_PLAIN);
+} elsif ($line =~ /^Postprocessed ANGLE header/) {
+printLine($line, STYLE_PLAIN);
+} elsif ($line =~ /^Prepare build/) {
+printLine($line, STYLE_PLAIN);
 } elsif ($line =~ /^GXCF:/) {
 printLine($line, STYLE_PLAIN);
+} elsif ($line =~ /^Signing Identity:/) {
+printLine($line, STYLE_PLAIN);
 } elsif ($line =~ /^Pre-processing (\S+) sandbox profile/) {
 printLine($line, STYLE_PLAIN);
 } elsif ($line =~ /^(\S+\/cc).*?(\S+)\.(out|exp)/) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250807] trunk/Source/WebCore

2019-10-07 Thread ysuzuki

Title: [250807] trunk/Source/WebCore








Revision 250807
Author ysuz...@apple.com
Date 2019-10-07 16:53:24 -0700 (Mon, 07 Oct 2019)


Log Message
Unreviewed, build fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=202569

* bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement):
* bindings/js/JSWebAnimationCustom.cpp:
(WebCore::constructJSWebAnimation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp
trunk/Source/WebCore/bindings/js/JSWebAnimationCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (250806 => 250807)

--- trunk/Source/WebCore/ChangeLog	2019-10-07 23:34:01 UTC (rev 250806)
+++ trunk/Source/WebCore/ChangeLog	2019-10-07 23:53:24 UTC (rev 250807)
@@ -1,5 +1,15 @@
 2019-10-07  Yusuke Suzuki  
 
+Unreviewed, build fix for Windows
+https://bugs.webkit.org/show_bug.cgi?id=202569
+
+* bindings/js/JSHTMLElementCustom.cpp:
+(WebCore::constructJSHTMLElement):
+* bindings/js/JSWebAnimationCustom.cpp:
+(WebCore::constructJSWebAnimation):
+
+2019-10-07  Yusuke Suzuki  
+
 [JSC] Change signature of HostFunction to (JSGlobalObject*, CallFrame*)
 https://bugs.webkit.org/show_bug.cgi?id=202569
 


Modified: trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp (250806 => 250807)

--- trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp	2019-10-07 23:34:01 UTC (rev 250806)
+++ trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp	2019-10-07 23:53:24 UTC (rev 250807)
@@ -41,7 +41,7 @@
 
 using namespace JSC;
 
-EncodedJSValue JSC_HOST_CALL constructJSHTMLElement(JSGlobalObject* globalObject, ExecState& exec)
+EncodedJSValue constructJSHTMLElement(JSGlobalObject* globalObject, ExecState& exec)
 {
 VM& vm = globalObject->vm();
 auto scope = DECLARE_THROW_SCOPE(vm);


Modified: trunk/Source/WebCore/bindings/js/JSWebAnimationCustom.cpp (250806 => 250807)

--- trunk/Source/WebCore/bindings/js/JSWebAnimationCustom.cpp	2019-10-07 23:34:01 UTC (rev 250806)
+++ trunk/Source/WebCore/bindings/js/JSWebAnimationCustom.cpp	2019-10-07 23:53:24 UTC (rev 250807)
@@ -52,7 +52,7 @@
 return wrap(state, globalObject, value);
 }
 
-EncodedJSValue JSC_HOST_CALL constructJSWebAnimation(JSGlobalObject* globalObject, ExecState& state)
+EncodedJSValue constructJSWebAnimation(JSGlobalObject* globalObject, ExecState& state)
 {
 VM& vm = globalObject->vm();
 auto throwScope = DECLARE_THROW_SCOPE(vm);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250806] trunk

2019-10-07 Thread sbarati

Title: [250806] trunk








Revision 250806
Author sbar...@apple.com
Date 2019-10-07 16:34:01 -0700 (Mon, 07 Oct 2019)


Log Message
Allow OSR exit to the LLInt
https://bugs.webkit.org/show_bug.cgi?id=197993

Reviewed by Tadeu Zagallo.

JSTests:

* stress/exit-from-getter-by-val.js: Added.
* stress/exit-from-setter-by-val.js: Added.

Source/_javascript_Core:

This patch makes it so we can OSR exit to the LLInt.
Here are the interesting implementation details:

1. We no longer baseline compile everything in the inline stack.

2. When the top frame is a LLInt frame, we exit to the corresponding
LLInt bytecode. However, we need to materialize the LLInt registers
for PC, PB, and metadata.

3. When dealing with inline call frames where the caller is LLInt, we
need to return to the appropriate place. Let's consider we're exiting
at a place A->B (A calls B), where A is LLInt. If A is a normal call,
we place the return PC in the frame we materialize to B to be right
after the LLInt's inline cache for calls. If A is a varargs call, we place
it at the return location for vararg calls. The interesting scenario here
is where A is a getter/setter. This means that A might be get_by_id,
get_by_val, put_by_id, or put_by_val. Since the LLInt does not have any
form of IC for getters/setters, we make this work by creating new LLInt
"return location" stubs for these opcodes.

4. We need to update what callee saves we store in the callee if the caller frame
is a LLInt frame. Let's consider an inline stack A->B->C, where A is a LLInt frame.
When we materialize the stack frame for B, we need to ensure that the LLInt callee
saves that A uses is stored into B's preserved callee saves. Specifically, this
is just the PB/metadata registers.

This patch also fixes offlineasm's macro expansion to allow us to
use computed label names for global labels.

In a future bug, I'm going to investigate some kind of control system for
throwing away baseline code when we tier up:
https://bugs.webkit.org/show_bug.cgi?id=202503

* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* bytecode/CodeBlock.h:
(JSC::CodeBlock::metadataTable):
(JSC::CodeBlock::instructionsRawPointer):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
(JSC::DFG::OSRExit::compileOSRExit):
* dfg/DFGOSRExit.h:
(JSC::DFG::OSRExitState::OSRExitState):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::callerReturnPC):
(JSC::DFG::calleeSaveSlot):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
* dfg/DFGOSRExitCompilerCommon.h:
* dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit): Deleted.
* dfg/DFGOSRExitPreparation.h:
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
* llint/LLIntData.h:
(JSC::LLInt::getCodePtr):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* offlineasm/asm.rb:
* offlineasm/transform.rb:
* runtime/OptionsList.h:

Tools:

* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/bytecode/BytecodeList.rb
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecode/InlineCallFrame.h
trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExit.h
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.h
trunk/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp
trunk/Source/_javascript_Core/llint/LLIntData.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/_javascript_Core/offlineasm/asm.rb
trunk/Source/_javascript_Core/offlineasm/transform.rb
trunk/Source/_javascript_Core/runtime/OptionsList.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests


Added Paths

trunk/JSTests/stress/exit-from-getter-by-val.js
trunk/JSTests/stress/exit-from-setter-by-val.js


Removed Paths

trunk/Source/_javascript_Core/dfg/DFGOSRExitPreparation.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitPreparation.h




Diff

Modified: trunk/JSTests/ChangeLog (250805 => 250806)

--- trunk/JSTests/ChangeLog	2019-10-07 23:20:40 UTC (rev 250805)
+++ trunk/JSTests/ChangeLog	2019-10-07 23:34:01 UTC (rev 250806)
@@ -1,3 +1,13 @@
+2019-10-07  Saam Barati  
+
+Allow OSR exit to the LLInt
+https://bugs.webkit.org/show_bug.cgi?id=197993
+
+Reviewed by Tadeu Zagallo.
+
+* stress/exit-from-getter-by-val.js: Added.
+* stress/exit-from-setter-by-val.js: Added.
+
 2019-10-07  Matt Lewis  
 
 Unreviewed, rolling out r250750.


Added:

[webkit-changes] [250805] branches/safari-608.3.10.0-branch/Source

2019-10-07 Thread alancoon

Title: [250805] branches/safari-608.3.10.0-branch/Source








Revision 250805
Author alanc...@apple.com
Date 2019-10-07 16:20:40 -0700 (Mon, 07 Oct 2019)


Log Message
Versioning.

Modified Paths

branches/safari-608.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608.3.10.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608.3.10.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (250804 => 250805)

--- branches/safari-608.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-07 23:17:28 UTC (rev 250804)
+++ branches/safari-608.3.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-07 23:20:40 UTC (rev 250805)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (250804 => 250805)

--- branches/safari-608.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-07 23:17:28 UTC (rev 250804)
+++ branches/safari-608.3.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-07 23:20:40 UTC (rev 250805)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig (250804 => 250805)

--- branches/safari-608.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-07 23:17:28 UTC (rev 250804)
+++ branches/safari-608.3.10.0-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-07 23:20:40 UTC (rev 250805)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (250804 => 250805)

--- branches/safari-608.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-07 23:17:28 UTC (rev 250804)
+++ branches/safari-608.3.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-07 23:20:40 UTC (rev 250805)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (250804 => 250805)

--- branches/safari-608.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-07 23:17:28 UTC (rev 250804)
+++ branches/safari-608.3.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-07 23:20:40 UTC (rev 250805)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: branches/safari-608.3.10.0-branch/Source/WebKit/Configurations/Version.xcconfig (250804 => 250805)

[webkit-changes] [250804] trunk

2019-10-07 Thread commit-queue

Title: [250804] trunk








Revision 250804
Author commit-qu...@webkit.org
Date 2019-10-07 16:17:28 -0700 (Mon, 07 Oct 2019)


Log Message
Domain relationships in the ITP Database should be inserted in a single query and ignore repeat insert attempts. (202604)
https://bugs.webkit.org/show_bug.cgi?id=202604


Patch by Kate Cheney  on 2019-10-07
Source/WebKit:

Reviewed by Chris Dumez.

This patch addresses two clean-ups for the ITP SQLite Database Store.
First, by using INSERT OR IGNORE as opposed to INSERT, it eliminates
the need to check if a relationship already exists in the database
before inserting it. Second, instead of looping through domain lists
and inserting each relationship as a separate query, this patch now
converts lists to a string which SQLite can use to insert multiple
rows into a database using a single query.

Some Exists queries could not be deleted because they were being
used for testing.

* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):
(WebKit::ResourceLoadStatisticsDatabaseStore::prepareStatements):
Removed old insert queries and replaced them with queries able to
insert string-lists of domains in a single query. Also reorganized
the queries by functionality to make them easier to find and edit.

(WebKit::ResourceLoadStatisticsDatabaseStore::createUniqueIndices):
(WebKit::ResourceLoadStatisticsDatabaseStore::createSchema):
In order to properly take advantage of the INSERT OR IGNORE
functionality, unique indices must be established so the SQLite table
is aware of what patterns to look for when ignoring a new insert.

(WebKit::ResourceLoadStatisticsDatabaseStore::ensureAndmakeDomainList):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationships):
Looping through the domain list is no longer needed with the new query
changes. Additionally, ensuring a domain is in the Observed Domains
table of the database must be done before utilizing any inserting of
relationships because the relationship queries rely on fetching the
topFrame domainID from the ObservedDomains table.

(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::logFrameNavigation):
(WebKit::ResourceLoadStatisticsDatabaseStore::logCrossSiteLoadWithLinkDecoration):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubframeUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectFrom):
With the ensure check being done once in the ensureAndmakeDomainList
function, these functions no longer have to make that check before
inserting.
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::mergeStatisticForTesting):
(WebKit::WebResourceLoadStatisticsStore::isRelationshipOnlyInDatabaseOnce):
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
Changes in WeResourceLoadStatisticsStore were for testing only. This
patch updated the merge statistic testing to also test this change by
having a topFrameDomain list with more than one domain.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::mergeStatisticForTesting):
(WebKit::NetworkProcess::isRelationshipOnlyInDatabaseOnce):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetStatisticsMergeStatistic):
(WKWebsiteDataStoreIsStatisticsOnlyInDatabaseOnce):
* UIProcess/API/C/WKWebsiteDataStoreRef.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::mergeStatisticForTesting):
(WebKit::NetworkProcessProxy::isRelationshipOnlyInDatabaseOnce):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::mergeStatisticForTesting):
(WebKit::WebsiteDataStore::isRelationshipOnlyInDatabaseOnce):
* UIProcess/WebsiteData/WebsiteDataStore.h:
Added a new function for testing that there are no repeat inserts
into the database. Updated mergeStatistics to test the list-insert
functionality.

Tools:

Reviewed by Chris Dumez.

Updates to testing infrastructure to test successful list-merging of
top domains into the ITP SQLite database and test against repeat
inserts.
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setStatisticsMergeStatistic):
(WTR::TestRunner::isStatisticsHasHadUserInteraction):

[webkit-changes] [250802] branches/safari-608.3.10.0-branch/

2019-10-07 Thread alancoon

Title: [250802] branches/safari-608.3.10.0-branch/








Revision 250802
Author alanc...@apple.com
Date 2019-10-07 16:03:53 -0700 (Mon, 07 Oct 2019)


Log Message
New branch.

Added Paths

branches/safari-608.3.10.0-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250801] trunk/Source/WebKit

2019-10-07 Thread megan_gardner

Title: [250801] trunk/Source/WebKit








Revision 250801
Author megan_gard...@apple.com
Date 2019-10-07 15:53:26 -0700 (Mon, 07 Oct 2019)


Log Message
Switch to WKShareSheet for WKPDFView
https://bugs.webkit.org/show_bug.cgi?id=202338

Reviewed by Tim Horton.

Switch to WKShareSheet from the share sheet in UIWKSelectionAssistant, since this is the only instance
of UIWKSelectionAssistant any more. This will keep all our share sheet code together, and allow
us to eliminate this class that will be completely unused with this change.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKPDFView.h:
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView dealloc]):
(-[WKPDFView actionSheetAssistant:shareElementWithURL:rect:]):
(-[WKPDFView shareSheetDidDismiss:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/ios/WKPDFView.h
trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (250800 => 250801)

--- trunk/Source/WebKit/ChangeLog	2019-10-07 22:36:47 UTC (rev 250800)
+++ trunk/Source/WebKit/ChangeLog	2019-10-07 22:53:26 UTC (rev 250801)
@@ -1,3 +1,21 @@
+2019-10-07  Megan Gardner  
+
+Switch to WKShareSheet for WKPDFView
+https://bugs.webkit.org/show_bug.cgi?id=202338
+
+Reviewed by Tim Horton.
+
+Switch to WKShareSheet from the share sheet in UIWKSelectionAssistant, since this is the only instance
+of UIWKSelectionAssistant any more. This will keep all our share sheet code together, and allow
+us to eliminate this class that will be completely unused with this change.
+
+* Platform/spi/ios/UIKitSPI.h:
+* UIProcess/ios/WKPDFView.h:
+* UIProcess/ios/WKPDFView.mm:
+(-[WKPDFView dealloc]):
+(-[WKPDFView actionSheetAssistant:shareElementWithURL:rect:]):
+(-[WKPDFView shareSheetDidDismiss:]):
+
 2019-10-07  Per Arne Vollan  
 
 [macOS] Layering violation in AuxiliaryProcessProxy::didFinishLaunching


Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (250800 => 250801)

--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2019-10-07 22:36:47 UTC (rev 250800)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2019-10-07 22:53:26 UTC (rev 250801)
@@ -69,7 +69,6 @@
 #import 
 #import 
 #import 
-#import 
 #import 
 #import 
 #import 
@@ -591,14 +590,6 @@
 @interface UIWebSelectionAssistant : NSObject
 @end
 
-@interface UIWKSelectionAssistant : UIWebSelectionAssistant
-@end
-
-@interface UIWKSelectionAssistant ()
-- (id)initWithView:(UIView *)view;
-- (void)showShareSheetFor:(NSString *)selectedTerm fromRect:(CGRect)presentationRect;
-@end
-
 @interface UIWKAutocorrectionRects : NSObject
 @end
 


Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFView.h (250800 => 250801)

--- trunk/Source/WebKit/UIProcess/ios/WKPDFView.h	2019-10-07 22:36:47 UTC (rev 250800)
+++ trunk/Source/WebKit/UIProcess/ios/WKPDFView.h	2019-10-07 22:53:26 UTC (rev 250801)
@@ -26,9 +26,10 @@
 #if ENABLE(WKPDFVIEW)
 
 #import "WKApplicationStateTrackingView.h"
+#import "WKShareSheet.h"
 #import "WKWebViewContentProvider.h"
 
-@interface WKPDFView : WKApplicationStateTrackingView 
+@interface WKPDFView : WKApplicationStateTrackingView 
 
 @end
 


Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm (250800 => 250801)

--- trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm	2019-10-07 22:36:47 UTC (rev 250800)
+++ trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm	2019-10-07 22:53:26 UTC (rev 250801)
@@ -41,6 +41,7 @@
 #import "_WKWebViewPrintFormatterInternal.h"
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -70,10 +71,16 @@
 RetainPtr _suggestedFilename;
 WeakObjCPtr _webView;
 RetainPtr _keyboardScrollingAnimator;
+RetainPtr _shareSheet;
 }
 
 - (void)dealloc
 {
+if (_shareSheet) {
+[_shareSheet setDelegate:nil];
+[_shareSheet dismiss];
+_shareSheet = nil;
+}
 [_actionSheetAssistant cleanupSheet];
 [[_hostViewController view] removeFromSuperview];
 [_pageNumberIndicator removeFromSuperview];
@@ -543,11 +550,28 @@
 
 - (void)actionSheetAssistant:(WKActionSheetAssistant *)assistant shareElementWithURL:(NSURL *)url rect:(CGRect)boundingRect
 {
-// FIXME: We should use WKShareSheet instead of UIWKSelectionAssistant for this.
-auto selectionAssistant = adoptNS([[UIWKSelectionAssistant alloc] initWithView:[_hostViewController view]]);
-[selectionAssistant showShareSheetFor:WTF::userVisibleString(url) fromRect:boundingRect];
+WKWebView *webView = _webView.getAutoreleased();
+if (!webView)
+return;
+
+WebCore::ShareDataWithParsedURL shareData;
+shareData.url = { url };
+
+[_shareSheet dismiss];
+
+_shareSheet = adoptNS([[WKShareSheet alloc] initWithView:webView]);
+[_shareSheet setDelegate:self];
+[_shareSheet presentWithParameters:shareData inRect: { [[_hostViewController view] convertRect:boundingRect

[webkit-changes] [250800] trunk

2019-10-07 Thread sihui_liu

Title: [250800] trunk








Revision 250800
Author sihui_...@apple.com
Date 2019-10-07 15:36:47 -0700 (Mon, 07 Oct 2019)


Log Message
ASSERTION FAILED: m_transactionOperationsInProgressQueue.first() ==  in IDBTransaction::operationCompletedOnClient
https://bugs.webkit.org/show_bug.cgi?id=202552

Reviewed by Alex Christensen.

Source/WebCore:

Dispatch task to database thread even if there is QuotaExceededError, to make sure request results are sent in
order.

Modified existing test to cover this: storage/indexeddb/storage-limit.html. Test would hit this assertion
without fix.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::requestSpace):
(WebCore::IDBServer::UniqueIDBDatabase::waitForRequestSpaceCompletion):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStoreAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStoreAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::performRenameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndex):
(WebCore::IDBServer::UniqueIDBDatabase::createIndexAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::performCreateIndex):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndexAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::performRenameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAddAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::getAllRecords):
(WebCore::IDBServer::UniqueIDBDatabase::getCount):
(WebCore::IDBServer::UniqueIDBDatabase::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
* Modules/indexeddb/server/UniqueIDBDatabase.h:

LayoutTests:

* storage/indexeddb/resources/storage-limit.js:
(onOpenSuccess.request.onerror):
* storage/indexeddb/storage-limit-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/resources/storage-limit.js
trunk/LayoutTests/storage/indexeddb/storage-limit-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h




Diff

Modified: trunk/LayoutTests/ChangeLog (250799 => 250800)

--- trunk/LayoutTests/ChangeLog	2019-10-07 22:14:41 UTC (rev 250799)
+++ trunk/LayoutTests/ChangeLog	2019-10-07 22:36:47 UTC (rev 250800)
@@ -1,3 +1,14 @@
+2019-10-07  Sihui Liu  
+
+ASSERTION FAILED: m_transactionOperationsInProgressQueue.first() ==  in IDBTransaction::operationCompletedOnClient
+https://bugs.webkit.org/show_bug.cgi?id=202552
+
+Reviewed by Alex Christensen.
+
+* storage/indexeddb/resources/storage-limit.js:
+(onOpenSuccess.request.onerror):
+* storage/indexeddb/storage-limit-expected.txt:
+
 2019-10-07  Ryosuke Niwa  
 
 focus pseudo class should match a shadow host whose shadow tree contains the focused element


Modified: trunk/LayoutTests/storage/indexeddb/resources/storage-limit.js (250799 => 250800)

--- trunk/LayoutTests/storage/indexeddb/resources/storage-limit.js	2019-10-07 22:14:41 UTC (rev 250799)
+++ trunk/LayoutTests/storage/indexeddb/resources/storage-limit.js	2019-10-07 22:36:47 UTC (rev 250800)
@@ -23,8 +23,16 @@
 preamble(event);
 evalAndLog("db = event.target.result");
 evalAndLog("store = db.transaction('store', 'readwrite').objectStore('store')");
+
+// Small add should succeed.
+evalAndLog("addCount = 0");
+for (var i = 1; i <= 10; i ++)
+evalAndLog("store.add(new Uint8Array(1), " + i + ")._onsuccess_ = ()=> { ++addCount; }");
+
+	// Big add should fail.
 evalAndLog("request = store.add(new Uint8Array(" + (quota + 1) + "), 0)");
 request._onerror_ = function(event) {
+shouldBe("addCount", "10");
 shouldBeTrue("'error' in request");
 shouldBe("request.error.code", "DOMException.QUOTA_EXCEEDED_ERR");
 shouldBeEqualToString("request.error.name", "QuotaExceededError");


Modified: trunk/LayoutTests/storage/indexeddb/storage-limit-expected.txt (250799 => 250800)

--- trunk/LayoutTests/storage/indexeddb/storage-limit-expected.txt	2019-10-07 22:14:41 UTC (rev 250799)
+++ trunk/LayoutTests/storage/indexeddb/storage-limit-expected.txt	2019-10-07 22:36:47 UTC (rev 250800)
@@ -15,7

[webkit-changes] [250798] trunk/Source/WebCore

2019-10-07 Thread krollin

Title: [250798] trunk/Source/WebCore








Revision 250798
Author krol...@apple.com
Date 2019-10-07 15:14:27 -0700 (Mon, 07 Oct 2019)


Log Message
Unreviewed, build fix after r250666. Fix 32- vs. 64-bit mismatch on
32-bit builds.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::estimateSize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (250797 => 250798)

--- trunk/Source/WebCore/ChangeLog	2019-10-07 22:12:16 UTC (rev 250797)
+++ trunk/Source/WebCore/ChangeLog	2019-10-07 22:14:27 UTC (rev 250798)
@@ -1,3 +1,11 @@
+2019-10-07  Keith Rollin  
+
+Unreviewed, build fix after r250666. Fix 32- vs. 64-bit mismatch on
+32-bit builds.
+
+* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+(WebCore::IDBServer::estimateSize):
+
 2019-10-07  Ross Kirsling  
 
 Unreviewed WinCairo build fix for r250786.


Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (250797 => 250798)

--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2019-10-07 22:12:16 UTC (rev 250797)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2019-10-07 22:14:27 UTC (rev 250798)
@@ -91,7 +91,7 @@
 static inline uint64_t estimateSize(const IDBKeyPath& keyPath)
 {
 return WTF::switchOn(keyPath, [](const String& path) {
-return path.sizeInBytes();
+return static_cast(path.sizeInBytes());
 }, [](const Vector& paths) {
 uint64_t size = 0;
 for (auto path : paths)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250799] trunk/Source/WebKit

2019-10-07 Thread pvollan

Title: [250799] trunk/Source/WebKit








Revision 250799
Author pvol...@apple.com
Date 2019-10-07 15:14:41 -0700 (Mon, 07 Oct 2019)


Log Message
[macOS] Layering violation in AuxiliaryProcessProxy::didFinishLaunching
https://bugs.webkit.org/show_bug.cgi?id=201617

Reviewed by Brent Fulgham.

The commit  introduced a layering violation in AuxiliaryProcessProxy::didFinishLaunching
where we inspect the pending message queue looking for a local file load message which needs the PID to create a sandbox extension
for the WebContent process. The layering violation can be fixed by creating a virtual method in AuxiliaryProcessProxy and override
the method in the WebProcessProxy to do the work needed to replace the message with a load request message containing a sandbox
extension created using the PID of the WebContent process. No new tests have been created, since this is covered by existing tests.

* UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
* UIProcess/AuxiliaryProcessProxy.h:
(WebKit::AuxiliaryProcessProxy::shouldSendPendingMessage):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shouldSendPendingMessage):
* UIProcess/WebProcessProxy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (250798 => 250799)

--- trunk/Source/WebKit/ChangeLog	2019-10-07 22:14:27 UTC (rev 250798)
+++ trunk/Source/WebKit/ChangeLog	2019-10-07 22:14:41 UTC (rev 250799)
@@ -1,3 +1,24 @@
+2019-10-07  Per Arne Vollan  
+
+[macOS] Layering violation in AuxiliaryProcessProxy::didFinishLaunching
+https://bugs.webkit.org/show_bug.cgi?id=201617
+
+Reviewed by Brent Fulgham.
+
+The commit  introduced a layering violation in AuxiliaryProcessProxy::didFinishLaunching
+where we inspect the pending message queue looking for a local file load message which needs the PID to create a sandbox extension
+for the WebContent process. The layering violation can be fixed by creating a virtual method in AuxiliaryProcessProxy and override
+the method in the WebProcessProxy to do the work needed to replace the message with a load request message containing a sandbox
+extension created using the PID of the WebContent process. No new tests have been created, since this is covered by existing tests.
+
+* UIProcess/AuxiliaryProcessProxy.cpp:
+(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
+* UIProcess/AuxiliaryProcessProxy.h:
+(WebKit::AuxiliaryProcessProxy::shouldSendPendingMessage):
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::shouldSendPendingMessage):
+* UIProcess/WebProcessProxy.h:
+
 2019-10-07  Dean Jackson  
 
 Provide options for DTTZ to happen in more situations


Modified: trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp (250798 => 250799)

--- trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp	2019-10-07 22:14:27 UTC (rev 250798)
+++ trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp	2019-10-07 22:14:41 UTC (rev 250799)
@@ -27,9 +27,7 @@
 #include "AuxiliaryProcessProxy.h"
 
 #include "AuxiliaryProcessMessages.h"
-#include "LoadParameters.h"
 #include "Logging.h"
-#include "WebPageMessages.h"
 #include "WebPageProxy.h"
 #include "WebProcessProxy.h"
 #include 
@@ -211,26 +209,10 @@
 m_connection->open();
 
 for (auto&& pendingMessage : std::exchange(m_pendingMessages, { })) {
+if (!shouldSendPendingMessage(pendingMessage))
+continue;
 auto encoder = WTFMove(pendingMessage.encoder);
 auto sendOptions = pendingMessage.sendOptions;
-#if HAVE(SANDBOX_ISSUE_MACH_EXTENSION_TO_PROCESS_BY_PID)
-if (encoder->messageName() == "LoadRequestWaitingForPID") {
-auto buffer = encoder->buffer();
-auto bufferSize = encoder->bufferSize();
-std::unique_ptr decoder = makeUnique(buffer, bufferSize, nullptr, Vector { });
-LoadParameters loadParameters;
-URL resourceDirectoryURL;
-WebPageProxyIdentifier pageID;
-if (decoder->decode(loadParameters) && decoder->decode(resourceDirectoryURL) && decoder->decode(pageID)) {
-if (auto* page = WebProcessProxy::webPage(pageID)) {
-page->maybeInitializeSandboxExtensionHandle(static_cast(*this), loadParameters.request.url(), resourceDirectoryURL, loadParameters.sandboxExtensionHandle);
-send(Messages::WebPage::LoadRequest(loadParameters), decoder->destinationID());
-}
-} else
-ASSERT_NOT_REACHED();
-continue;
-}
-#endif
 if (pendingMessage.asyncReplyInfo)

[webkit-changes] [250797] trunk/Source/WebCore

2019-10-07 Thread ross . kirsling

Title: [250797] trunk/Source/WebCore








Revision 250797
Author ross.kirsl...@sony.com
Date 2019-10-07 15:12:16 -0700 (Mon, 07 Oct 2019)


Log Message
Unreviewed WinCairo build fix for r250786.

* Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::addAll):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/cache/DOMCache.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (250796 => 250797)

--- trunk/Source/WebCore/ChangeLog	2019-10-07 22:11:24 UTC (rev 250796)
+++ trunk/Source/WebCore/ChangeLog	2019-10-07 22:12:16 UTC (rev 250797)
@@ -1,3 +1,10 @@
+2019-10-07  Ross Kirsling  
+
+Unreviewed WinCairo build fix for r250786.
+
+* Modules/cache/DOMCache.cpp:
+(WebCore::DOMCache::addAll):
+
 2019-10-07  Tim Horton  
 
 Fix the Windows build


Modified: trunk/Source/WebCore/Modules/cache/DOMCache.cpp (250796 => 250797)

--- trunk/Source/WebCore/Modules/cache/DOMCache.cpp	2019-10-07 22:11:24 UTC (rev 250796)
+++ trunk/Source/WebCore/Modules/cache/DOMCache.cpp	2019-10-07 22:12:16 UTC (rev 250797)
@@ -241,7 +241,7 @@
 requests.uncheckedAppend(requestOrException.releaseReturnValue());
 }
 
-auto taskHandler = FetchTasksHandler::create(*this, [this, promise = WTFMove(promise)](ExceptionOr>&& result) mutable {
+auto taskHandler = FetchTasksHandler::create(*this, [this, protectedThis = makeRef(*this), promise = WTFMove(promise)](ExceptionOr>&& result) mutable {
 if (result.hasException()) {
 m_taskQueue->enqueueTask([promise = WTFMove(promise), exception = result.releaseException()]() mutable {
 promise.reject(WTFMove(exception));
@@ -248,7 +248,7 @@
 });
 return;
 }
-batchPutOperation(result.releaseReturnValue(), [this, protectedThis = makeRef(*this), promise = WTFMove(promise)](ExceptionOr&& result) mutable {
+batchPutOperation(result.releaseReturnValue(), [this, protectedThis = WTFMove(protectedThis), promise = WTFMove(promise)](ExceptionOr&& result) mutable {
 m_taskQueue->enqueueTask([promise = WTFMove(promise), result = WTFMove(result)]() mutable {
 promise.settle(WTFMove(result));
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250796] tags/Safari-608.3.10.1.1/

2019-10-07 Thread alancoon

Title: [250796] tags/Safari-608.3.10.1.1/








Revision 250796
Author alanc...@apple.com
Date 2019-10-07 15:11:24 -0700 (Mon, 07 Oct 2019)


Log Message
Tag Safari-608.3.10.1.1.

Added Paths

tags/Safari-608.3.10.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250795] trunk/Source/WebCore

2019-10-07 Thread timothy_horton

Title: [250795] trunk/Source/WebCore








Revision 250795
Author timothy_hor...@apple.com
Date 2019-10-07 14:47:16 -0700 (Mon, 07 Oct 2019)


Log Message
Fix the Windows build

* html/ImageBitmap.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/ImageBitmap.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (250794 => 250795)

--- trunk/Source/WebCore/ChangeLog	2019-10-07 21:32:32 UTC (rev 250794)
+++ trunk/Source/WebCore/ChangeLog	2019-10-07 21:47:16 UTC (rev 250795)
@@ -1,3 +1,9 @@
+2019-10-07  Tim Horton  
+
+Fix the Windows build
+
+* html/ImageBitmap.h:
+
 2019-10-07  Ross Kirsling  
 
 Unreviewed WinCairo build fix for r250758.


Modified: trunk/Source/WebCore/html/ImageBitmap.h (250794 => 250795)

--- trunk/Source/WebCore/html/ImageBitmap.h	2019-10-07 21:32:32 UTC (rev 250794)
+++ trunk/Source/WebCore/html/ImageBitmap.h	2019-10-07 21:47:16 UTC (rev 250795)
@@ -33,6 +33,8 @@
 class ArrayBuffer;
 }
 
+using JSC::ArrayBuffer;
+
 namespace WebCore {
 
 class Blob;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250794] trunk/Tools

2019-10-07 Thread jlewis3

Title: [250794] trunk/Tools








Revision 250794
Author jlew...@apple.com
Date 2019-10-07 14:32:32 -0700 (Mon, 07 Oct 2019)


Log Message
Bring up queues for Catalina
https://bugs.webkit.org/show_bug.cgi?id=202652

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (250793 => 250794)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-10-07 21:31:34 UTC (rev 250793)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-10-07 21:32:32 UTC (rev 250794)
@@ -1,7 +1,20 @@
 {
 "slaves": [ { "name": "test-slave", "platform": "*" },
 
-{ "name": "bot121", "platform": "mac-mojave" },
+{ "name": "bot687", "platform": "mac-catalina" },
+{ "name": "bot688", "platform": "mac-catalina" },
+{ "name": "bot683", "platform": "mac-catalina" },
+{ "name": "bot674", "platform": "mac-catalina" },
+{ "name": "bot241", "platform": "mac-catalina" },
+{ "name": "bot242", "platform": "mac-catalina" },
+{ "name": "bot243", "platform": "mac-catalina" },
+{ "name": "bot244", "platform": "mac-catalina" },
+{ "name": "bot245", "platform": "mac-catalina" },
+{ "name": "bot246", "platform": "mac-catalina" },
+{ "name": "bot247", "platform": "mac-catalina" },
+{ "name": "bot248", "platform": "mac-catalina" },
+{ "name": "bot121", "platform": "mac-catalina" },
+
 { "name": "bot132", "platform": "mac-mojave" },
 { "name": "bot178", "platform": "mac-mojave" },
 { "name": "bot179", "platform": "mac-mojave" },
@@ -85,7 +98,43 @@
 { "name": "wpe-linux-bot-4", "platform": "wpe" }
   ],
 
-"builders":   [ { "name": "Apple Mojave Debug (Build)", "type": "Build", "builddir": "mojave-debug",
+"builders":   [ 
+{ "name": "Apple Catalina Debug (Build)", "type": "Build", "builddir": "catalina-debug",
+  "platform": "mac-catalina", "configuration": "debug", "architectures": ["x86_64"],
+  "triggers": ["catalina-debug-tests-wk1", "catalina-debug-tests-wk2"],
+  "slavenames": ["bot687", "bot688"]
+},
+{ "name": "Apple Catalina Debug WK1 (Tests)", "type": "TestWebKit1AllButJSC", "builddir": "catalina-debug-tests-wk1",
+  "platform": "mac-catalina", "configuration": "debug", "architectures": ["x86_64"],
+  "additionalArguments": ["--no-retry-failures"],
+  "slavenames": ["bot241", "bot242"]
+},
+{ "name": "Apple Catalina Debug WK2 (Tests)", "type": "TestAllButJSC", "builddir": "catalina-debug-tests-wk2",
+  "platform": "mac-catalina", "configuration": "debug", "architectures": ["x86_64"],
+  "additionalArguments": ["--no-retry-failures"],
+  "slavenames": ["bot243", "bot244"]
+},
+{ "name": "Apple Catalina Release (Build)", "type": "Build", "builddir": "catalina-release",
+  "platform": "mac-catalina", "configuration": "release", "architectures": ["x86_64"],
+  "triggers": ["catalina-release-tests-wk1", "catalina-release-tests-wk2", "catalina-leaks"],
+  "slavenames": ["bot683", "bot674"]
+},
+{ "name": "Apple Catalina Release WK1 (Tests)", "type": "TestWebKit1AllButJSC", "builddir": "catalina-release-tests-wk1",
+  "platform": "mac-catalina", "configuration": "release", "architectures": ["x86_64"],
+  "additionalArguments": ["--no-retry-failures"],
+  "slavenames": ["bot245", "bot246"]
+},
+{ "name": "Apple Catalina Release WK2 (Tests)", "type": "TestAllButJSC", "builddir": "catalina-release-tests-wk2",
+  "platform": "mac-catalina", "configuration": "release", "architectures": ["x86_64"],
+  "additionalArguments": ["--no-retry-failures"],
+  "slavenames": ["bot247", "bot248"]
+

[webkit-changes] [250793] trunk/Source/WebCore

2019-10-07 Thread ross . kirsling

Title: [250793] trunk/Source/WebCore








Revision 250793
Author ross.kirsl...@sony.com
Date 2019-10-07 14:31:34 -0700 (Mon, 07 Oct 2019)


Log Message
Unreviewed WinCairo build fix for r250758.

* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (250792 => 250793)

--- trunk/Source/WebCore/ChangeLog	2019-10-07 21:29:38 UTC (rev 250792)
+++ trunk/Source/WebCore/ChangeLog	2019-10-07 21:31:34 UTC (rev 250793)
@@ -1,3 +1,10 @@
+2019-10-07  Ross Kirsling  
+
+Unreviewed WinCairo build fix for r250758.
+
+* workers/service/ServiceWorkerContainer.cpp:
+(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
+
 2019-10-07  Ryosuke Niwa  
 
 focus pseudo class should match a shadow host whose shadow tree contains the focused element


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp (250792 => 250793)

--- trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp	2019-10-07 21:29:38 UTC (rev 250792)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp	2019-10-07 21:31:34 UTC (rev 250793)
@@ -379,7 +379,7 @@
 if (!promise)
 return;
 
-m_taskQueue->enqueueTask([this, promise = WTFMove(promise), jobIdentifier = job.identifier(), data = "" shouldNotifyWhenResolved, notifyIfExitEarly = WTFMove(notifyIfExitEarly)]() mutable {
+m_taskQueue->enqueueTask([this, protectedThis = makeRef(*this), promise = WTFMove(promise), jobIdentifier = job.identifier(), data = "" shouldNotifyWhenResolved, notifyIfExitEarly = WTFMove(notifyIfExitEarly)]() mutable {
 notifyIfExitEarly.release();
 
 auto registration = ServiceWorkerRegistration::getOrCreate(*scriptExecutionContext(), *this, WTFMove(data));
@@ -388,7 +388,7 @@
 
 if (shouldNotifyWhenResolved == ShouldNotifyWhenResolved::Yes) {
 m_ongoingSettledRegistrations.add(++m_lastOngoingSettledRegistrationIdentifier, registration->data().key);
-promise->whenSettled([this, protectedThis = makeRef(*this), identifier = m_lastOngoingSettledRegistrationIdentifier] {
+promise->whenSettled([this, protectedThis = WTFMove(protectedThis), identifier = m_lastOngoingSettledRegistrationIdentifier] {
 notifyRegistrationIsSettled(m_ongoingSettledRegistrations.take(identifier));
 });
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250792] branches/safari-608.3.10.1-branch/Source/WebKit

2019-10-07 Thread alancoon

Title: [250792] branches/safari-608.3.10.1-branch/Source/WebKit








Revision 250792
Author alanc...@apple.com
Date 2019-10-07 14:29:38 -0700 (Mon, 07 Oct 2019)


Log Message
Cherry-pick r250438. rdar://problem/55984974

Unreviewed build-fix: wrap the AssertionServicesSPI.h in an IOS_FAMILY check.

* WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608.3.10.1-branch/Source/WebKit/ChangeLog
branches/safari-608.3.10.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-608.3.10.1-branch/Source/WebKit/ChangeLog (250791 => 250792)

--- branches/safari-608.3.10.1-branch/Source/WebKit/ChangeLog	2019-10-07 21:26:42 UTC (rev 250791)
+++ branches/safari-608.3.10.1-branch/Source/WebKit/ChangeLog	2019-10-07 21:29:38 UTC (rev 250792)
@@ -1,3 +1,19 @@
+2019-10-07  Alan Coon  
+
+Cherry-pick r250438. rdar://problem/55984974
+
+Unreviewed build-fix: wrap the AssertionServicesSPI.h in an IOS_FAMILY check.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-27  Jer Noble  
+
+Unreviewed build-fix: wrap the AssertionServicesSPI.h in an IOS_FAMILY check.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+
 2019-10-03  Kocsen Chung  
 
 Cherry-pick r250642. rdar://problem/55947639


Modified: branches/safari-608.3.10.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (250791 => 250792)

--- branches/safari-608.3.10.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2019-10-07 21:26:42 UTC (rev 250791)
+++ branches/safari-608.3.10.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2019-10-07 21:29:38 UTC (rev 250792)
@@ -27,7 +27,6 @@
 #import "WebProcess.h"
 #import "WebProcessCocoa.h"
 
-#import "AssertionServicesSPI.h"
 #import "LegacyCustomProtocolManager.h"
 #import "LogInitialization.h"
 #import "Logging.h"
@@ -90,6 +89,7 @@
 
 #if PLATFORM(IOS_FAMILY)
 #import "AccessibilitySupportSPI.h"
+#import "AssertionServicesSPI.h"
 #import "WKAccessibilityWebPageObjectIOS.h"
 #import 
 #import 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250791] branches/safari-608.3.10.1-branch/Source

2019-10-07 Thread alancoon

Title: [250791] branches/safari-608.3.10.1-branch/Source








Revision 250791
Author alanc...@apple.com
Date 2019-10-07 14:26:42 -0700 (Mon, 07 Oct 2019)


Log Message
Versioning.

Modified Paths

branches/safari-608.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608.3.10.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608.3.10.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (250790 => 250791)

--- branches/safari-608.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-07 21:07:20 UTC (rev 250790)
+++ branches/safari-608.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-07 21:26:42 UTC (rev 250791)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (250790 => 250791)

--- branches/safari-608.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-07 21:07:20 UTC (rev 250790)
+++ branches/safari-608.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-07 21:26:42 UTC (rev 250791)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig (250790 => 250791)

--- branches/safari-608.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-07 21:07:20 UTC (rev 250790)
+++ branches/safari-608.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-07 21:26:42 UTC (rev 250791)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (250790 => 250791)

--- branches/safari-608.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-07 21:07:20 UTC (rev 250790)
+++ branches/safari-608.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-07 21:26:42 UTC (rev 250791)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-608.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (250790 => 250791)

--- branches/safari-608.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-07 21:07:20 UTC (rev 250790)
+++ branches/safari-608.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-07 21:26:42 UTC (rev 250791)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The

[webkit-changes] [250790] branches/safari-608.3.10.1-branch/

2019-10-07 Thread alancoon

Title: [250790] branches/safari-608.3.10.1-branch/








Revision 250790
Author alanc...@apple.com
Date 2019-10-07 14:07:20 -0700 (Mon, 07 Oct 2019)


Log Message
New branch.

Added Paths

branches/safari-608.3.10.1-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250789] branches/safari-608.3-branch/Source

2019-10-07 Thread alancoon

Title: [250789] branches/safari-608.3-branch/Source








Revision 250789
Author alanc...@apple.com
Date 2019-10-07 14:05:52 -0700 (Mon, 07 Oct 2019)


Log Message
Revert "Versioning."

This reverts commit r250759.

Modified Paths

branches/safari-608.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (250788 => 250789)

--- branches/safari-608.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-07 20:58:04 UTC (rev 250788)
+++ branches/safari-608.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-07 21:05:52 UTC (rev 250789)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
-TINY_VERSION = 11;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (250788 => 250789)

--- branches/safari-608.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-07 20:58:04 UTC (rev 250788)
+++ branches/safari-608.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-07 21:05:52 UTC (rev 250789)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
-TINY_VERSION = 11;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608.3-branch/Source/WebCore/Configurations/Version.xcconfig (250788 => 250789)

--- branches/safari-608.3-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-07 20:58:04 UTC (rev 250788)
+++ branches/safari-608.3-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-07 21:05:52 UTC (rev 250789)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
-TINY_VERSION = 11;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (250788 => 250789)

--- branches/safari-608.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-07 20:58:04 UTC (rev 250788)
+++ branches/safari-608.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-07 21:05:52 UTC (rev 250789)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
-TINY_VERSION = 11;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (250788 => 250789)

--- branches/safari-608.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-07 20:58:04 UTC (rev 250788)
+++ branches/safari-608.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-07 21:05:52 UTC (rev 250789)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
-TINY_VERSION = 11;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608.3-branch/Source/WebKit/Configurations/Version.xcconfig (250788 => 250789)

--- branches/safari-608.3-branch/Source/WebKit/Configurations/Version.xcconfig	2019-10-07 20:58:04 UTC (rev 250788)
+++ branches/safari-608.3-branch/Source/WebKit/Configurations/Version.xcconfig	2019-10-07 21:05:52 UTC (rev 250789)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
-TINY_VERSION = 11;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (250788 => 250789)

--- branches/safari-608.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-07 20:58:04 UTC (rev 250788)
+++ branches/safari-608.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-07 21:05:52 UTC (rev 250789)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 3;
-TINY_VERSION = 11;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250788] trunk

2019-10-07 Thread rniwa

Title: [250788] trunk








Revision 250788
Author rn...@webkit.org
Date 2019-10-07 13:58:04 -0700 (Mon, 07 Oct 2019)


Log Message
focus pseudo class should match a shadow host whose shadow tree contains the focused element
https://bugs.webkit.org/show_bug.cgi?id=202432

Reviewed by Antti Koivisto.

Source/WebCore:

Note that focus pseudo class does not match a shadow host when its shadow tree contains a slot element
with a focused element or its ancestor assigned since such a shadow host has the actual focused element
in the same tree as the shadow host. (e.g. the focused element can be a direct child of the host).

In order to preserve the behavior of focus ring, which should be only drawn on the currently focused
element and not any shadow host which contains such an element, this patch introduces a new pseudo class,
-webkit-direct-focus, which is only available in the user agent stylesheet. Putting :host(:focus) rule
isn't sufficient because style rules inside shadow trees always has a lower precendence than rules
outside the shadow tree (the tree of its shadow host).

[1] Also see https://github.com/whatwg/html/pull/4731

Tests: fast/shadow-dom/direct-focus-pseudo-does-not-match-in-author-stylesheet.html
   fast/shadow-dom/focus-pseudo-matches-on-shadow-host.html
   fast/shadow-dom/focus-pseudo-on-shadow-host-1.html
   fast/shadow-dom/focus-pseudo-on-shadow-host-2.html
   fast/shadow-dom/focus-pseudo-on-shadow-host-3.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const): Added the support for -webkit-direct-focus.
* css/CSSSelector.h:
* css/RuleSet.cpp:
(WebCore::RuleSet::addRule): Ditto.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):: Ditto.
(WebCore::doesShadowTreeContainFocusedElement):: Ditto.
(WebCore::SelectorChecker::matchesFocusPseudoClass): Implemented the new behavior.
(WebCore::SelectorChecker::matchesDirectFocusPseudoClass): Added. Implements the old behavior for
the focus ring via -webkit-direct-focus pseudo class.
* css/SelectorChecker.h:
* css/SelectorPseudoClassAndCompatibilityElementMap.in: Added -webkit-direct-focus.
* css/html.css: Use -webkit-direct-focus pseudo class to preserve the existing behavior of focus ring.
* css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumePseudo): Ignore -webkit-direct-focus in author and user stylesheets.
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType): Added the support for -webkit-direct-focus.
* dom/Element.cpp:
(WebCore::Element::setFocus): Invoke setContainsFocusedElement on each shadow ancestor root of
the newly focused element. Note that we can't use :focus-within pseudo class since that would also match
the host of a shadow root which contains a slotted focused element, causing both the shadow host and
the slotted element to match :focus pseudo class in the host's tree.
* dom/ShadowRoot.h:

LayoutTests:

Added W3C style testharness tests and ref tests.

* fast/shadow-dom/direct-focus-pseudo-does-not-match-in-author-stylesheet-expected.txt: Added.
* fast/shadow-dom/direct-focus-pseudo-does-not-match-in-author-stylesheet.html: Added.
* fast/shadow-dom/focus-pseudo-matches-on-shadow-host-expected.txt: Added.
* fast/shadow-dom/focus-pseudo-matches-on-shadow-host.html: Added.
* fast/shadow-dom/focus-pseudo-on-shadow-host-1-expected.html: Added.
* fast/shadow-dom/focus-pseudo-on-shadow-host-1.html: Added.
* fast/shadow-dom/focus-pseudo-on-shadow-host-2-expected.html: Added.
* fast/shadow-dom/focus-pseudo-on-shadow-host-2.html: Added.
* fast/shadow-dom/focus-pseudo-on-shadow-host-3-expected.html: Added.
* fast/shadow-dom/focus-pseudo-on-shadow-host-3.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-selector-delegatesFocus-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSSelector.cpp
trunk/Source/WebCore/css/CSSSelector.h
trunk/Source/WebCore/css/RuleSet.cpp
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorChecker.h
trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/ShadowRoot.h


Added Paths

trunk/LayoutTests/fast/shadow-dom/direct-focus-pseudo-does-not-match-in-author-stylesheet-expected.txt
trunk/LayoutTests/fast/shadow-dom/direct-focus-pseudo-does-not-match-in-author-stylesheet.html
trunk/LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host-expected.txt
trunk/LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host.html
trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-1-expected.html
trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-1.html
trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-2-expected.html

[webkit-changes] [250786] trunk

2019-10-07 Thread cdumez

Title: [250786] trunk








Revision 250786
Author cdu...@apple.com
Date 2019-10-07 13:41:05 -0700 (Mon, 07 Oct 2019)


Log Message
DOMCache should not prevent pages from entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=202590

Reviewed by Youenn Fablet.

Source/WebCore:

Allow DOMCache to suspend in the back/forward cache unconditionally, by
appending all promise resolutions to a SuspendableTaskQueue. This guarantees
that any asynchronous promise resolution is delayed while in the page cache,
until the page gets resumed.

Test: http/tests/navigation/page-cache-domcache-pending-promise.html

* Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::DOMCache):
(WebCore::DOMCache::match):
(WebCore::DOMCache::matchAll):
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::putWithResponseData):
(WebCore::DOMCache::put):
(WebCore::DOMCache::remove):
(WebCore::DOMCache::keys):
(WebCore::DOMCache::canSuspendForDocumentSuspension const):
* Modules/cache/DOMCache.h:

LayoutTests:

Add layout test coverage.

* TestExpectations:
* http/tests/navigation/page-cache-domcache-pending-promise-expected.txt: Added.
* http/tests/navigation/page-cache-domcache-pending-promise.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/cache/DOMCache.cpp
trunk/Source/WebCore/Modules/cache/DOMCache.h
trunk/Source/WebCore/Modules/cache/DOMCacheStorage.cpp


Added Paths

trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise-expected.txt
trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise.html




Diff

Modified: trunk/LayoutTests/ChangeLog (250785 => 250786)

--- trunk/LayoutTests/ChangeLog	2019-10-07 20:31:01 UTC (rev 250785)
+++ trunk/LayoutTests/ChangeLog	2019-10-07 20:41:05 UTC (rev 250786)
@@ -1,3 +1,16 @@
+2019-10-07  Chris Dumez  
+
+DOMCache should not prevent pages from entering the back/forward cache
+https://bugs.webkit.org/show_bug.cgi?id=202590
+
+Reviewed by Youenn Fablet.
+
+Add layout test coverage.
+
+* TestExpectations:
+* http/tests/navigation/page-cache-domcache-pending-promise-expected.txt: Added.
+* http/tests/navigation/page-cache-domcache-pending-promise.html: Added.
+
 2019-10-07  Alexey Shvayka  
 
 Sync web-platform-tests/css/css-overflow from upstream


Modified: trunk/LayoutTests/TestExpectations (250785 => 250786)

--- trunk/LayoutTests/TestExpectations	2019-10-07 20:31:01 UTC (rev 250785)
+++ trunk/LayoutTests/TestExpectations	2019-10-07 20:41:05 UTC (rev 250786)
@@ -454,6 +454,8 @@
 imported/w3c/web-platform-tests/workers/constructors/SharedWorker [ Skip ]
 imported/w3c/web-platform-tests/workers/SharedWorker_blobUrl.html [ Skip ]
 
+http/tests/navigation/page-cache-domcache-pending-promise.html [ DumpJSConsoleLogInStdErr ]
+
 imported/w3c/web-platform-tests/beacon/beacon-basic-blob.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-redirect.any.worker.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/xhr/access-control-and-redirects.htm [ DumpJSConsoleLogInStdErr ]


Added: trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise-expected.txt (0 => 250786)

--- trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise-expected.txt	2019-10-07 20:41:05 UTC (rev 250786)
@@ -0,0 +1,15 @@
+Tests that a page with pending DOMCache activity goes into the page cache.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+pageshow - not from cache
+pagehide - entering cache
+pageshow - from cache
+PASS Page was restored from Page Cache
+PASS Cache.add() succeeded
+PASS !!restoredFromPageCache is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise.html (0 => 250786)

--- trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise.html	(rev 0)
+++ trunk/LayoutTests/http/tests/navigation/page-cache-domcache-pending-promise.html	2019-10-07 20:41:05 UTC (rev 250786)
@@ -0,0 +1,53 @@
+
+
+
+
+
+
+