[webkit-changes] [273372] trunk/LayoutTests
Title: [273372] trunk/LayoutTests
Revision 273372
Author wei...@apple.com
Date 2021-02-23 21:34:19 -0800 (Tue, 23 Feb 2021)
Log Message
Fix model test differences between platforms
https://bugs.webkit.org/show_bug.cgi?id=222323
Reviewed by Ryosuke Niwa.
* model-element/model-element-renderer-no-source.html:
* model-element/model-element-renderer.html:
Try to fix these on iOS by removing the doctype.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/model-element/model-element-renderer-expected.txt
trunk/LayoutTests/model-element/model-element-renderer-no-source-expected.txt
trunk/LayoutTests/model-element/model-element-renderer-no-source.html
trunk/LayoutTests/model-element/model-element-renderer.html
Diff
Modified: trunk/LayoutTests/ChangeLog (273371 => 273372)
--- trunk/LayoutTests/ChangeLog 2021-02-24 05:00:30 UTC (rev 273371)
+++ trunk/LayoutTests/ChangeLog 2021-02-24 05:34:19 UTC (rev 273372)
@@ -1,3 +1,14 @@
+2021-02-23 Sam Weinig
+
+Fix model test differences between platforms
+https://bugs.webkit.org/show_bug.cgi?id=222323
+
+Reviewed by Ryosuke Niwa.
+
+* model-element/model-element-renderer-no-source.html:
+* model-element/model-element-renderer.html:
+Try to fix these on iOS by removing the doctype.
+
2021-02-23 Ryan Haddad
Fix model test differences between platforms
Modified: trunk/LayoutTests/model-element/model-element-renderer-expected.txt (273371 => 273372)
--- trunk/LayoutTests/model-element/model-element-renderer-expected.txt 2021-02-24 05:00:30 UTC (rev 273371)
+++ trunk/LayoutTests/model-element/model-element-renderer-expected.txt 2021-02-24 05:34:19 UTC (rev 273372)
@@ -1,7 +1,7 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x170
- RenderBlock {HTML} at (0,0) size 800x170
-RenderBody {BODY} at (8,8) size 784x154
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
RenderModel {MODEL} at (0,0) size 300x150
RenderText {#text} at (0,0) size 0x0
Modified: trunk/LayoutTests/model-element/model-element-renderer-no-source-expected.txt (273371 => 273372)
--- trunk/LayoutTests/model-element/model-element-renderer-no-source-expected.txt 2021-02-24 05:00:30 UTC (rev 273371)
+++ trunk/LayoutTests/model-element/model-element-renderer-no-source-expected.txt 2021-02-24 05:34:19 UTC (rev 273372)
@@ -1,7 +1,7 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x170
- RenderBlock {HTML} at (0,0) size 800x170
-RenderBody {BODY} at (8,8) size 784x154
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
RenderModel {MODEL} at (0,0) size 300x150
RenderText {#text} at (0,0) size 0x0
Modified: trunk/LayoutTests/model-element/model-element-renderer-no-source.html (273371 => 273372)
--- trunk/LayoutTests/model-element/model-element-renderer-no-source.html 2021-02-24 05:00:30 UTC (rev 273371)
+++ trunk/LayoutTests/model-element/model-element-renderer-no-source.html 2021-02-24 05:34:19 UTC (rev 273372)
@@ -1,4 +1,4 @@
-
+
Modified: trunk/LayoutTests/model-element/model-element-renderer.html (273371 => 273372)
--- trunk/LayoutTests/model-element/model-element-renderer.html 2021-02-24 05:00:30 UTC (rev 273371)
+++ trunk/LayoutTests/model-element/model-element-renderer.html 2021-02-24 05:34:19 UTC (rev 273372)
@@ -1,4 +1,4 @@
-
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273371] trunk
Title: [273371] trunk
Revision 273371
Author msab...@apple.com
Date 2021-02-23 21:00:30 -0800 (Tue, 23 Feb 2021)
Log Message
[YARR JIT] Crash on overflow when compiling /(a{10}b{10}|c{10}|)d{10}e{10}/.test();
https://bugs.webkit.org/show_bug.cgi?id=220130
Reviewed by Yusuke Suzuki.
JSTests:
Modified the original fuzzer test to go 2^32-1.
* stress/regexp-backtrack-offset-overflow.js: Added.
Source/_javascript_Core:
Changed code to subtract out the offset of a current op before adding the offset
of the prior op when backtracking to avoid overflowing checked arithmetic.
It looks like the code had this wrong for some time.
* yarr/YarrJIT.cpp:
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
Added Paths
trunk/JSTests/stress/regexp-backtrack-offset-overflow.js
Diff
Modified: trunk/JSTests/ChangeLog (273370 => 273371)
--- trunk/JSTests/ChangeLog 2021-02-24 04:03:18 UTC (rev 273370)
+++ trunk/JSTests/ChangeLog 2021-02-24 05:00:30 UTC (rev 273371)
@@ -1,3 +1,14 @@
+2021-02-23 Michael Saboff
+
+[YARR JIT] Crash on overflow when compiling /(a{10}b{10}|c{10}|)d{10}e{10}/.test();
+https://bugs.webkit.org/show_bug.cgi?id=220130
+
+Reviewed by Yusuke Suzuki.
+
+Modified the original fuzzer test to go 2^32-1.
+
+* stress/regexp-backtrack-offset-overflow.js: Added.
+
2021-02-21 Keith Miller
Implement the Top-level await proposal
Added: trunk/JSTests/stress/regexp-backtrack-offset-overflow.js (0 => 273371)
--- trunk/JSTests/stress/regexp-backtrack-offset-overflow.js (rev 0)
+++ trunk/JSTests/stress/regexp-backtrack-offset-overflow.js 2021-02-24 05:00:30 UTC (rev 273371)
@@ -0,0 +1,3 @@
+//@ runDefault
+
+/(a{10}b{10}|c{10}|)d{1094967295}e{10}/.test("abc");
Modified: trunk/Source/_javascript_Core/ChangeLog (273370 => 273371)
--- trunk/Source/_javascript_Core/ChangeLog 2021-02-24 04:03:18 UTC (rev 273370)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-02-24 05:00:30 UTC (rev 273371)
@@ -1,3 +1,16 @@
+2021-02-23 Michael Saboff
+
+[YARR JIT] Crash on overflow when compiling /(a{10}b{10}|c{10}|)d{10}e{10}/.test();
+https://bugs.webkit.org/show_bug.cgi?id=220130
+
+Reviewed by Yusuke Suzuki.
+
+Changed code to subtract out the offset of a current op before adding the offset
+of the prior op when backtracking to avoid overflowing checked arithmetic.
+It looks like the code had this wrong for some time.
+
+* yarr/YarrJIT.cpp:
+
2021-02-22 Don Olmstead
Non-unified build fixes late February 2021 edition
Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (273370 => 273371)
--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2021-02-24 04:03:18 UTC (rev 273370)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2021-02-24 05:00:30 UTC (rev 273371)
@@ -2795,11 +2795,11 @@
case OpBodyAlternativeNext: {
PatternAlternative* alternative = op.m_alternative;
+m_checkedOffset -= alternative->m_minimumSize;
if (op.m_op == OpBodyAlternativeNext) {
PatternAlternative* priorAlternative = m_ops[op.m_previousOp].m_alternative;
m_checkedOffset += priorAlternative->m_minimumSize;
}
-m_checkedOffset -= alternative->m_minimumSize;
// Is this the last alternative? If not, then if we backtrack to this point we just
// need to jump to try to match the next alternative.
@@ -3101,11 +3101,11 @@
m_backtrackingState.append(endOp->m_jumps);
}
+m_checkedOffset -= op.m_checkAdjust;
if (!isBegin) {
YarrOp& lastOp = m_ops[op.m_previousOp];
m_checkedOffset += lastOp.m_checkAdjust;
}
-m_checkedOffset -= op.m_checkAdjust;
break;
}
case OpSimpleNestedAlternativeEnd:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273370] trunk/LayoutTests
Title: [273370] trunk/LayoutTests Revision 273370 Author ryanhad...@apple.com Date 2021-02-23 20:03:18 -0800 (Tue, 23 Feb 2021) Log Message Fix model test differences between platforms https://bugs.webkit.org/show_bug.cgi?id=222323 Unreviewed test gardening. * platform/ios/TestExpectations: Mark tests as failing until fix is reviewed & landed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273369 => 273370) --- trunk/LayoutTests/ChangeLog 2021-02-24 03:24:32 UTC (rev 273369) +++ trunk/LayoutTests/ChangeLog 2021-02-24 04:03:18 UTC (rev 273370) @@ -1,3 +1,12 @@ +2021-02-23 Ryan Haddad + +Fix model test differences between platforms +https://bugs.webkit.org/show_bug.cgi?id=222323 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: Mark tests as failing until fix is reviewed & landed. + 2021-02-23 Devin Rousso [ macOS ] media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html is a flakey text failure Modified: trunk/LayoutTests/platform/ios/TestExpectations (273369 => 273370) --- trunk/LayoutTests/platform/ios/TestExpectations 2021-02-24 03:24:32 UTC (rev 273369) +++ trunk/LayoutTests/platform/ios/TestExpectations 2021-02-24 04:03:18 UTC (rev 273370) @@ -3507,3 +3507,6 @@ webkit.org/b/221466 imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys.html [ Skip ] webkit.org/b/221465 imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations.html [ Skip ] + +webkit.org/b/222323 model-element/model-element-renderer-no-source.html [ Failure ] +webkit.org/b/222323 model-element/model-element-renderer.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273369] branches/safari-612.1.5-branch/Source/WTF
Title: [273369] branches/safari-612.1.5-branch/Source/WTF Revision 273369 Author repst...@apple.com Date 2021-02-23 19:24:32 -0800 (Tue, 23 Feb 2021) Log Message Revert r273165. rdar://problem/74610383 Modified Paths branches/safari-612.1.5-branch/Source/WTF/ChangeLog branches/safari-612.1.5-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: branches/safari-612.1.5-branch/Source/WTF/ChangeLog (273368 => 273369) --- branches/safari-612.1.5-branch/Source/WTF/ChangeLog 2021-02-24 02:41:27 UTC (rev 273368) +++ branches/safari-612.1.5-branch/Source/WTF/ChangeLog 2021-02-24 03:24:32 UTC (rev 273369) @@ -1,3 +1,7 @@ +2021-02-23 Russell Epstein + +Revert r273165. rdar://problem/74610383 + 2021-02-21 Simon Fraser Re-enable Paint Timing Modified: branches/safari-612.1.5-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (273368 => 273369) --- branches/safari-612.1.5-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-02-24 02:41:27 UTC (rev 273368) +++ branches/safari-612.1.5-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-02-24 03:24:32 UTC (rev 273369) @@ -634,9 +634,9 @@ webcoreBinding: RuntimeEnabledFeatures defaultValue: WebKitLegacy: - default: true + default: false WebKit: - default: true + default: false OverscrollBehaviorEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [273368] trunk/LayoutTests
Title: [273368] trunk/LayoutTests Revision 273368 Author drou...@apple.com Date 2021-02-23 18:41:27 -0800 (Tue, 23 Feb 2021) Log Message [ macOS ] media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html is a flakey text failure https://bugs.webkit.org/show_bug.cgi?id=222134 Unreviewed, this is an identical change to r273357. * media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html: Add a rAF+0s delay before attempting to hover the mute button to give it a chance to "settle" after it becomes visible (based off of `.getBoundingClientRect().width`). * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (273367 => 273368) --- trunk/LayoutTests/ChangeLog 2021-02-24 02:18:39 UTC (rev 273367) +++ trunk/LayoutTests/ChangeLog 2021-02-24 02:41:27 UTC (rev 273368) @@ -1,5 +1,19 @@ 2021-02-23 Devin Rousso +[ macOS ] media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html is a flakey text failure +https://bugs.webkit.org/show_bug.cgi?id=222134 + + +Unreviewed, this is an identical change to r273357. + +* media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html: +Add a rAF+0s delay before attempting to hover the mute button to give it a chance to +"settle" after it becomes visible (based off of `.getBoundingClientRect().width`). + +* platform/mac/TestExpectations: + +2021-02-23 Devin Rousso + REGRESSION (r273004): [ macOS ] media/modern-media-controls/volume-support/volume-support-drag.html is a flakey text failure https://bugs.webkit.org/show_bug.cgi?id=222117 Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html (273367 => 273368) --- trunk/LayoutTests/media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html 2021-02-24 02:18:39 UTC (rev 273367) +++ trunk/LayoutTests/media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html 2021-02-24 02:41:27 UTC (rev 273368) @@ -1,5 +1,6 @@ +