[webkit-changes] [279905] trunk/Source/WebCore

[jya]

Title: [279905] trunk/Source/WebCore








Revision 279905
Author j...@apple.com
Date 2021-07-13 22:57:07 -0700 (Tue, 13 Jul 2021)


Log Message
MediaSessionManagerCocoa::ensureCodecsRegistered() isn't thread-safe
https://bugs.webkit.org/show_bug.cgi?id=227940

Reviewed by Maciej Stachowiak.

C++11 static initializers aren't thread-safe due to architectural and compilation
option choices. So we use Grand Central Dispatch's dispatch_once instead.

* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::ensureCodecsRegistered):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (279904 => 279905)

--- trunk/Source/WebCore/ChangeLog	2021-07-14 05:12:26 UTC (rev 279904)
+++ trunk/Source/WebCore/ChangeLog	2021-07-14 05:57:07 UTC (rev 279905)
@@ -1,5 +1,18 @@
 2021-07-13  Jean-Yves Avenard  
 
+MediaSessionManagerCocoa::ensureCodecsRegistered() isn't thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=227940
+
+Reviewed by Maciej Stachowiak.
+
+C++11 static initializers aren't thread-safe due to architectural and compilation
+option choices. So we use Grand Central Dispatch's dispatch_once instead.
+
+* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
+(WebCore::MediaSessionManagerCocoa::ensureCodecsRegistered):
+
+2021-07-13  Jean-Yves Avenard  
+
 SourceBuffer.abort() doesn't go back to state WAITING_FOR_SEGMENT properly
 https://bugs.webkit.org/show_bug.cgi?id=227559
 


Modified: trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm (279904 => 279905)

--- trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm	2021-07-14 05:12:26 UTC (rev 279904)
+++ trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm	2021-07-14 05:57:07 UTC (rev 279905)
@@ -65,8 +65,9 @@
 
 void MediaSessionManagerCocoa::ensureCodecsRegistered()
 {
-static bool sInitDone = []() {
 #if ENABLE(VP9)
+static dispatch_once_t onceToken;
+dispatch_once(, ^{
 if (shouldEnableVP9Decoder())
 registerSupplementalVP9Decoder();
 if (shouldEnableVP8Decoder())
@@ -73,10 +74,8 @@
 registerWebKitVP8Decoder();
 if (shouldEnableVP9SWDecoder())
 registerWebKitVP9Decoder();
+});
 #endif
-return true;
-}();
-UNUSED_VARIABLE(sInitDone);
 }
 
 void MediaSessionManagerCocoa::updateSessionState()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279903] trunk/Source/JavaScriptCore

[rmorisset]

Title: [279903] trunk/Source/_javascript_Core








Revision 279903
Author rmoris...@apple.com
Date 2021-07-13 20:21:03 -0700 (Tue, 13 Jul 2021)


Log Message
Invalid machine code emitted by SpeculativeJIT::emitObjectOrOtherBranch
https://bugs.webkit.org/show_bug.cgi?id=227869


Reviewed by Mark Lam.

SpeculativeJIT::emitObjectOrOtherBranch used to check the validity of the masqueradesAsUndefined watchpoint twice, and assumed that it could not change in between.
That is clearly incorrect as the main thread is running concurrently with it, and so the watchpoint could fire at any time.
The fix is trivial: just check the validity once, and store the result in a boolean.
If the watchpoint triggers later that is fine: we'll notice and cancel the compilation (see WatchpointCollectionPhase, Plan::isStillValid() and Plan::finalize()).
The change only protects us from rare and hard-to-reproduce crashes on debug builds caused by an ASSERT firing.

I did not add a testcase, as I can only reproduce the bug by adding an extra wait in the middle of emitObjectOrOtherBranch.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279902 => 279903)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-14 02:42:10 UTC (rev 279902)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-14 03:21:03 UTC (rev 279903)
@@ -1,3 +1,22 @@
+2021-07-13  Robin Morisset  
+
+Invalid machine code emitted by SpeculativeJIT::emitObjectOrOtherBranch
+https://bugs.webkit.org/show_bug.cgi?id=227869
+
+
+Reviewed by Mark Lam.
+
+SpeculativeJIT::emitObjectOrOtherBranch used to check the validity of the masqueradesAsUndefined watchpoint twice, and assumed that it could not change in between.
+That is clearly incorrect as the main thread is running concurrently with it, and so the watchpoint could fire at any time.
+The fix is trivial: just check the validity once, and store the result in a boolean.
+If the watchpoint triggers later that is fine: we'll notice and cancel the compilation (see WatchpointCollectionPhase, Plan::isStillValid() and Plan::finalize()).
+The change only protects us from rare and hard-to-reproduce crashes on debug builds caused by an ASSERT firing.
+
+I did not add a testcase, as I can only reproduce the bug by adding an extra wait in the middle of emitObjectOrOtherBranch.
+
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
+
 2021-07-13  Yijia Huang  
 
 Add a new Air::Arg kind ZeroReg to let AIR recognise the new instructions/forms accepting zero register in ARM64


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (279902 => 279903)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2021-07-14 02:42:10 UTC (rev 279902)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2021-07-14 03:21:03 UTC (rev 279903)
@@ -1986,7 +1986,8 @@
 GPRReg scratchGPR = scratch.gpr();
 GPRReg structureGPR = InvalidGPRReg;
 
-if (!masqueradesAsUndefinedWatchpointIsStillValid()) {
+bool objectMayMasqueradeAsUndefined = !masqueradesAsUndefinedWatchpointIsStillValid();
+if (objectMayMasqueradeAsUndefined) {
 GPRTemporary realStructure(this);
 structure.adopt(realStructure);
 structureGPR = structure.gpr();
@@ -1993,7 +1994,7 @@
 }
 
 MacroAssembler::Jump notCell = m_jit.branchIfNotCell(JSValueRegs(valueGPR));
-if (masqueradesAsUndefinedWatchpointIsStillValid()) {
+if (!objectMayMasqueradeAsUndefined) {
 DFG_TYPE_CHECK(
 JSValueRegs(valueGPR), nodeUse, (~SpecCellCheck) | SpecObject, m_jit.branchIfNotObject(valueGPR));
 } else {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279902] trunk/Source/WebKit

[wenson_hsieh]

Title: [279902] trunk/Source/WebKit








Revision 279902
Author wenson_hs...@apple.com
Date 2021-07-13 19:42:10 -0700 (Tue, 13 Jul 2021)


Log Message
[WK2] Push OS state dumping logic down from WebProcess to AuxiliaryProcess
https://bugs.webkit.org/show_bug.cgi?id=227916

Reviewed by Tim Horton.

Refactor state dumping registration code in preparation for supporting state dumping in the GPU process on Cocoa
platforms when triggering system diagnostics. The logic that currently lives in
`WebProcess::registerWithStateDumper` is comprised of two parts: (1) code that calls `os_state_add_handler` with
a `os_state_data_t` provider, and (2) code that builds a dictionary containing diagnostic information specific
to the web process.

Since GPUProcess will require only the former, we hoist logic for (1) into the superclass (AuxiliaryProcess) so
that both GPUProcess and WebProcess can invoke it, and refactor (2) to be a virtual method that may be
overridden by subclasses to provide process-specific information.

* Shared/AuxiliaryProcess.h:
(WebKit::AuxiliaryProcess::additionalStateForDiagnosticReport const):
* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::registerWithStateDumper):

Additionally make this take the title string that will be used to label the state data, to avoid the need for a
second subclassing method to provide the title.

* WebProcess/WebProcess.h:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::additionalStateForDiagnosticReport const):

Pull logic for collecting diagnostic information in the web process out into a separate helper method.

(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::registerWithStateDumper): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/AuxiliaryProcess.h
trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (279901 => 279902)

--- trunk/Source/WebKit/ChangeLog	2021-07-14 00:36:25 UTC (rev 279901)
+++ trunk/Source/WebKit/ChangeLog	2021-07-14 02:42:10 UTC (rev 279902)
@@ -1,3 +1,37 @@
+2021-07-13  Wenson Hsieh  
+
+[WK2] Push OS state dumping logic down from WebProcess to AuxiliaryProcess
+https://bugs.webkit.org/show_bug.cgi?id=227916
+
+Reviewed by Tim Horton.
+
+Refactor state dumping registration code in preparation for supporting state dumping in the GPU process on Cocoa
+platforms when triggering system diagnostics. The logic that currently lives in
+`WebProcess::registerWithStateDumper` is comprised of two parts: (1) code that calls `os_state_add_handler` with
+a `os_state_data_t` provider, and (2) code that builds a dictionary containing diagnostic information specific
+to the web process.
+
+Since GPUProcess will require only the former, we hoist logic for (1) into the superclass (AuxiliaryProcess) so
+that both GPUProcess and WebProcess can invoke it, and refactor (2) to be a virtual method that may be
+overridden by subclasses to provide process-specific information.
+
+* Shared/AuxiliaryProcess.h:
+(WebKit::AuxiliaryProcess::additionalStateForDiagnosticReport const):
+* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
+(WebKit::AuxiliaryProcess::registerWithStateDumper):
+
+Additionally make this take the title string that will be used to label the state data, to avoid the need for a
+second subclassing method to provide the title.
+
+* WebProcess/WebProcess.h:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::additionalStateForDiagnosticReport const):
+
+Pull logic for collecting diagnostic information in the web process out into a separate helper method.
+
+(WebKit::WebProcess::platformInitializeProcess):
+(WebKit::WebProcess::registerWithStateDumper): Deleted.
+
 2021-07-13  Alex Christensen  
 
 REGRESSION(r279069): http/tests/websocket/tests/hybi/too-long-payload.html is a constant timeout when using NSURLSESSION_WEBSOCKET


Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.h (279901 => 279902)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.h	2021-07-14 00:36:25 UTC (rev 279901)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.h	2021-07-14 02:42:10 UTC (rev 279902)
@@ -36,6 +36,12 @@
 #include 
 #include 
 
+#if PLATFORM(COCOA)
+#include 
+#endif
+
+OBJC_CLASS NSDictionary;
+
 namespace WebKit {
 
 class SandboxInitializationParameters;
@@ -107,6 +113,11 @@
 
 virtual void stopRunLoop();
 
+#if USE(OS_STATE)
+void registerWithStateDumper(ASCIILiteral title);
+virtual RetainPtr additionalStateForDiagnosticReport() const { return { }; }
+#endif // USE(OS_STATE)
+
 #if USE(APPKIT)
 static void stopNSAppRunLoop();
 #endif


Modified: trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm (279901 => 

[webkit-changes] [279901] trunk/LayoutTests

[jenner]

Title: [279901] trunk/LayoutTests








Revision 279901
Author jen...@apple.com
Date 2021-07-13 17:36:25 -0700 (Tue, 13 Jul 2021)


Log Message
[iOS] imported/w3c/web-platform-tests/css/conditional/idlharness.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=227931.

Unreviewed test gardening.

Patch by Eric Hutchison  on 2021-07-13

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279900 => 279901)

--- trunk/LayoutTests/ChangeLog	2021-07-14 00:24:38 UTC (rev 279900)
+++ trunk/LayoutTests/ChangeLog	2021-07-14 00:36:25 UTC (rev 279901)
@@ -1,5 +1,14 @@
 2021-07-13  Eric Hutchison  
 
+[iOS] imported/w3c/web-platform-tests/css/conditional/idlharness.html is a flaky failure.
+https://bugs.webkit.org/show_bug.cgi?id=227931.
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-07-13  Eric Hutchison  
+
 [Mac wk2] inspector/canvas/setShaderProgramDisabled.html is flaky failing.
 https://bugs.webkit.org/show_bug.cgi?id=227922.
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (279900 => 279901)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-14 00:24:38 UTC (rev 279900)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-14 00:36:25 UTC (rev 279901)
@@ -1944,4 +1944,6 @@
 
 webkit.org/b/226598 animations/leak-document-with-css-animation.html [ Pass Failure ]
 
+webkit.org/b/227931 imported/w3c/web-platform-tests/css/conditional/idlharness.html [ Pass Failure ]
+
 webkit.org/b/227890 fast/canvas/canvas-path-addPath.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279900] trunk/LayoutTests

[jenner]

Title: [279900] trunk/LayoutTests








Revision 279900
Author jen...@apple.com
Date 2021-07-13 17:24:38 -0700 (Tue, 13 Jul 2021)


Log Message
[Mac wk2] inspector/canvas/setShaderProgramDisabled.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=227922.

Unreviewed test gardening.

Patch by Eric Hutchison  on 2021-07-13

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279899 => 279900)

--- trunk/LayoutTests/ChangeLog	2021-07-14 00:00:03 UTC (rev 279899)
+++ trunk/LayoutTests/ChangeLog	2021-07-14 00:24:38 UTC (rev 279900)
@@ -1,3 +1,12 @@
+2021-07-13  Eric Hutchison  
+
+[Mac wk2] inspector/canvas/setShaderProgramDisabled.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=227922.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-07-13  Truitt Savell  
 
 Creating or modifying expectations for many test failing on Monterey


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (279899 => 279900)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-14 00:00:03 UTC (rev 279899)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-14 00:24:38 UTC (rev 279900)
@@ -1389,6 +1389,8 @@
 
 webkit.org/b/227805 [ Debug ] fast/canvas/canvas-composite-image.html [ Pass Crash ]
 
+webkit.org/b/227922 inspector/canvas/setShaderProgramDisabled.html [ Pass Failure Timeout ]
+
 webkit.org/b/227874 [ BigSur Release ] fullscreen/full-screen-remove-children.html [ Pass Crash ]
 
-webkit.org/b/227890 fast/canvas/canvas-path-addPath.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/227890 fast/canvas/canvas-path-addPath.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279899] tags/Safari-612.1.22.11.4/

[alancoon]

Title: [279899] tags/Safari-612.1.22.11.4/








Revision 279899
Author alanc...@apple.com
Date 2021-07-13 17:00:03 -0700 (Tue, 13 Jul 2021)


Log Message
Tag Safari-612.1.22.11.4.

Added Paths

tags/Safari-612.1.22.11.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279898] trunk/Tools

[jbedard]

Title: [279898] trunk/Tools








Revision 279898
Author jbed...@apple.com
Date 2021-07-13 16:58:14 -0700 (Tue, 13 Jul 2021)


Log Message
[webkitscmpy] Handle failed `git log` process
https://bugs.webkit.org/show_bug.cgi?id=227709


Rubber-stamped by Aakash Jain.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.populate): Do not populate cache if `git log` fails.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py




Diff

Modified: trunk/Tools/ChangeLog (279897 => 279898)

--- trunk/Tools/ChangeLog	2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/ChangeLog	2021-07-13 23:58:14 UTC (rev 279898)
@@ -1,3 +1,16 @@
+2021-07-13  Jonathan Bedard  
+
+[webkitscmpy] Handle failed `git log` process
+https://bugs.webkit.org/show_bug.cgi?id=227709
+
+
+Rubber-stamped by Aakash Jain.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
+(Git.Cache.populate): Do not populate cache if `git log` fails.
+
 2021-07-13  Alex Christensen  
 
 >4K Referer should have tailing /


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (279897 => 279898)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-07-13 23:58:14 UTC (rev 279898)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='0.14.6',
+version='0.14.7',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (279897 => 279898)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-07-13 23:58:14 UTC (rev 279898)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(0, 14, 6)
+version = Version(0, 14, 7)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('monotonic', Version(1, 5)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py (279897 => 279898)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py	2021-07-13 23:56:54 UTC (rev 279897)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py	2021-07-13 23:58:14 UTC (rev 279898)
@@ -161,6 +161,9 @@
 intersected = _append(branch, hash, revision=revision)
 
 finally:
+# If our `git log` operation failed, we can't count on the validity of our cache
+if log and log.returncode:
+return
 if log:
 log.kill()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279897] branches/safari-612.1.22.11-branch/Source

[alancoon]

Title: [279897] branches/safari-612.1.22.11-branch/Source








Revision 279897
Author alanc...@apple.com
Date 2021-07-13 16:56:54 -0700 (Tue, 13 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.22.11.4

Modified Paths

branches/safari-612.1.22.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.22.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.22.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.22.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.22.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.22.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.22.11-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.22.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.22.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279896 => 279897)

--- branches/safari-612.1.22.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-13 22:55:56 UTC (rev 279896)
+++ branches/safari-612.1.22.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-13 23:56:54 UTC (rev 279897)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 11;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279896 => 279897)

--- branches/safari-612.1.22.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-13 22:55:56 UTC (rev 279896)
+++ branches/safari-612.1.22.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-13 23:56:54 UTC (rev 279897)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 11;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279896 => 279897)

--- branches/safari-612.1.22.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-13 22:55:56 UTC (rev 279896)
+++ branches/safari-612.1.22.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-13 23:56:54 UTC (rev 279897)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 11;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.11-branch/Source/WebCore/Configurations/Version.xcconfig (279896 => 279897)

--- branches/safari-612.1.22.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-13 22:55:56 UTC (rev 279896)
+++ branches/safari-612.1.22.11-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-13 23:56:54 UTC (rev 279897)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 11;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279896 => 279897)

--- branches/safari-612.1.22.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-13 22:55:56 UTC (rev 279896)
+++ branches/safari-612.1.22.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-13 23:56:54 UTC (rev 279897)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 11;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.22.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279896 => 279897)

--- branches/safari-612.1.22.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-13 22:55:56 UTC (rev 279896)
+++ branches/safari-612.1.22.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-13 23:56:54 UTC (rev 279897)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 11;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = 

[webkit-changes] [279896] trunk/Source/WebKit

[achristensen]

Title: [279896] trunk/Source/WebKit








Revision 279896
Author achristen...@apple.com
Date 2021-07-13 15:55:56 -0700 (Tue, 13 Jul 2021)


Log Message
REGRESSION(r279069): http/tests/websocket/tests/hybi/too-long-payload.html is a constant timeout when using NSURLSESSION_WEBSOCKET
https://bugs.webkit.org/show_bug.cgi?id=227923


Reviewed by Chris Dumez.

We need to add a large maximum frame size that was first introduced to WebKit in r91243
Covered by existing tests.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (279895 => 279896)

--- trunk/Source/WebKit/ChangeLog	2021-07-13 22:54:29 UTC (rev 279895)
+++ trunk/Source/WebKit/ChangeLog	2021-07-13 22:55:56 UTC (rev 279896)
@@ -1,3 +1,17 @@
+2021-07-13  Alex Christensen  
+
+REGRESSION(r279069): http/tests/websocket/tests/hybi/too-long-payload.html is a constant timeout when using NSURLSESSION_WEBSOCKET
+https://bugs.webkit.org/show_bug.cgi?id=227923
+
+
+Reviewed by Chris Dumez.
+
+We need to add a large maximum frame size that was first introduced to WebKit in r91243
+Covered by existing tests.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
 2021-07-13  Peng Liu  
 
 [GPUP] RemoteMediaPlayerProxy may not send the latest "naturalSize" to MediaPlayerPrivateRemote


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (279895 => 279896)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2021-07-13 22:54:29 UTC (rev 279895)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2021-07-13 22:55:56 UTC (rev 279896)
@@ -1694,7 +1694,10 @@
 
 auto& sessionSet = sessionSetForPage(webPageProxyID);
 RetainPtr task = [sessionSet.sessionWithCredentialStorage.session webSocketTaskWithRequest:nsRequest.get()];
-task.get().maximumMessageSize = 0;
+
+// Although the WebSocket protocol allows full 64-bit lengths, Chrome and Firefox limit the length to 2^63 - 1
+task.get().maximumMessageSize = 0x7FFFull;
+
 return makeUnique(channel, webPageProxyID, makeWeakPtr(sessionSet), request, WTFMove(task));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279895] trunk

[achristensen]

Title: [279895] trunk








Revision 279895
Author achristen...@apple.com
Date 2021-07-13 15:54:29 -0700 (Tue, 13 Jul 2021)


Log Message
Update and fix URL WPT tests
https://bugs.webkit.org/show_bug.cgi?id=227820

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/url/failure-expected.txt:
* web-platform-tests/url/resources/a-element-origin.js:
(runURLTests):
* web-platform-tests/url/resources/a-element.js:
(runURLTests):
* web-platform-tests/url/resources/setters_tests.json:
* web-platform-tests/url/resources/urltestdata.json:
* web-platform-tests/url/url-constructor.any-expected.txt:
* web-platform-tests/url/url-constructor.any.js:
(bURL):
* web-platform-tests/url/url-constructor.any.worker-expected.txt:
* web-platform-tests/url/url-origin.any.js:
(bURL):
* web-platform-tests/url/url-setters-a-area.window-expected.txt:
* web-platform-tests/url/url-setters.any-expected.txt:
* web-platform-tests/url/url-setters.any.worker-expected.txt:

Source/WTF:

There was an edge case where if we set a path to an empty string, it would add a slash.  No more.

* wtf/URL.cpp:
(WTF::URL::setPath):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/failure-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/resources/a-element-origin.js
trunk/LayoutTests/imported/w3c/web-platform-tests/url/resources/a-element.js
trunk/LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json
trunk/LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.js
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.js
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URL.cpp


Removed Paths

trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/url/




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279894 => 279895)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-13 22:40:14 UTC (rev 279894)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-13 22:54:29 UTC (rev 279895)
@@ -1,3 +1,27 @@
+2021-07-13  Alex Christensen  
+
+Update and fix URL WPT tests
+https://bugs.webkit.org/show_bug.cgi?id=227820
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/url/failure-expected.txt:
+* web-platform-tests/url/resources/a-element-origin.js:
+(runURLTests):
+* web-platform-tests/url/resources/a-element.js:
+(runURLTests):
+* web-platform-tests/url/resources/setters_tests.json:
+* web-platform-tests/url/resources/urltestdata.json:
+* web-platform-tests/url/url-constructor.any-expected.txt:
+* web-platform-tests/url/url-constructor.any.js:
+(bURL):
+* web-platform-tests/url/url-constructor.any.worker-expected.txt:
+* web-platform-tests/url/url-origin.any.js:
+(bURL):
+* web-platform-tests/url/url-setters-a-area.window-expected.txt:
+* web-platform-tests/url/url-setters.any-expected.txt:
+* web-platform-tests/url/url-setters.any.worker-expected.txt:
+
 2021-07-13  Chris Dumez  
 
 Resync webmessaging WPT tests from upstream


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/failure-expected.txt (279894 => 279895)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/failure-expected.txt	2021-07-13 22:40:14 UTC (rev 279894)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/failure-expected.txt	2021-07-13 22:54:29 UTC (rev 279895)
@@ -1,7 +1,3 @@
-Blocked access to external URL http://./Y:
-CONSOLE MESSAGE: Beacon API cannot load http://./Y: due to access control checks.
-Blocked access to external URL http://./y:
-CONSOLE MESSAGE: Beacon API cannot load http://./y: due to access control checks.
 
 PASS Loading data…
 PASS URL's constructor's base argument: file://example:1/ should throw
@@ -74,16 +70,8 @@
 PASS URL's href: http::@/www.example.com should throw
 PASS URL's constructor's base argument: http:@:www.example.com should throw
 PASS URL's href: http:@:www.example.com should throw
-FAIL XHR: http:@:www.example.com should throw assert_throws_dom: function "() => client.open("GET", test.input)" did not throw
-FAIL sendBeacon(): http:@:www.example.com should throw assert_throws_js: function "() => self.navigator.sendBeacon(test.input)" did not throw
-FAIL Location's href: http:@:www.example.com should throw assert_throws_js: function "() => self[0].location = test.input" did not 

[webkit-changes] [279893] trunk/LayoutTests

[tsavell]

Title: [279893] trunk/LayoutTests








Revision 279893
Author tsav...@apple.com
Date 2021-07-13 14:54:21 -0700 (Tue, 13 Jul 2021)


Log Message
Creating or modifying expectations for many test failing on Monterey

Unreviewed test gardening.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279892 => 279893)

--- trunk/LayoutTests/ChangeLog	2021-07-13 21:53:22 UTC (rev 279892)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 21:54:21 UTC (rev 279893)
@@ -1,3 +1,14 @@
+2021-07-13  Truitt Savell  
+
+Creating or modifying expectations for many test failing on Monterey
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
 2021-07-13  Arcady Goldmints-Orlov  
 
 [GLIB] Test gardening, remove platform specific expected files


Modified: trunk/LayoutTests/platform/ios/TestExpectations (279892 => 279893)

--- trunk/LayoutTests/platform/ios/TestExpectations	2021-07-13 21:53:22 UTC (rev 279892)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2021-07-13 21:54:21 UTC (rev 279893)
@@ -3358,6 +3358,9 @@
 fast/text/system-font-width-8.html [ ImageOnlyFailure ]
 fast/text/system-font-width-9.html [ ImageOnlyFailure ]
 
+# rdar://80345578 ([ Mac iOS Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html is flaky crashing)
+imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html [ Pass Failure Crash ]
+
 webkit.org/b/225606 imported/w3c/web-platform-tests/css/css-fonts/font-feature-resolution-001.html [ ImageOnlyFailure ]
 webkit.org/b/225606 imported/w3c/web-platform-tests/css/css-fonts/font-feature-resolution-002.html [ ImageOnlyFailure ]
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (279892 => 279893)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-07-13 21:53:22 UTC (rev 279892)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-07-13 21:54:21 UTC (rev 279893)
@@ -2193,7 +2193,7 @@
 
 webkit.org/b/223259 [ arm64 ] webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels.html [ Failure ]
 
-webkit.org/b/223271 [ BigSur Debug ] imported/w3c/web-platform-tests/xhr/event-upload-progress.any.worker.html [ Pass Failure ]
+webkit.org/b/223271 [ Debug ] imported/w3c/web-platform-tests/xhr/event-upload-progress.any.worker.html [ Pass Failure ]
 
 webkit.org/b/221833 fast/text/image-alt-text-bidi-2.html [ ImageOnlyFailure ]
 
@@ -2287,8 +2287,18 @@
 
 webkit.org/b/225670 webaudio/AudioContext/audiocontext-close-basic.html [ Slow ]
 
-webkit.org/b/223645 [ BigSur ] media/video-played-ranges-1.html [ Pass Failure ]
+webkit.org/b/223645 [ BigSur+ ] media/video-played-ranges-1.html [ Pass Failure ]
 
+webkit.org/b/226828 media/modern-media-controls/overflow-support/chapters.html [ Pass Failure Timeout ]
+
+# rdar://80345970 ([ Mac ] imported/w3c/web-platform-tests/workers/Worker-terminate-forever-during-evaluation.html is a flaky failure)
+imported/w3c/web-platform-tests/workers/Worker-terminate-forever-during-evaluation.html [ Pass Failure Crash ]
+
+webkit.org/b/227910 imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ]
+
+# rdar://80345578 ([ Mac iOS Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html is flaky crashing)
+imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html [ Pass Failure Crash ]
+
 webkit.org/b/225804 imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https.html [ Pass Failure ]
 
 webkit.org/b/225882 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-frozen-array.https.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (279892 => 279893)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-07-13 21:53:22 UTC (rev 279892)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-07-13 21:54:21 UTC (rev 279893)
@@ -1207,7 +1207,7 @@
 webkit.org/b/208477 [ Catalina ] accessibility/mac/test.mp3/boot.xml [ Skip ]
 webkit.org/b/208479 [ Catalina ] accessibility/mac/test.mp3/root.xml [ Skip ]
 
-webkit.org/b/221095 [ BigSur ] media/mediacapabilities/vp9.html [ Failure ]
+webkit.org/b/221095 [ BigSur+ ] media/mediacapabilities/vp9.html [ Failure ]
 
 webkit.org/b/221146 [ BigSur ] imported/w3c/web-platform-tests/media-source/mediasource-invalid-codec.html [ Failure ]
 
@@ -1220,7 +1220,7 @@
 
 webkit.org/b/221368 [ BigSur ] 

[webkit-changes] [279892] trunk

[commit-queue]

Title: [279892] trunk








Revision 279892
Author commit-qu...@webkit.org
Date 2021-07-13 14:53:22 -0700 (Tue, 13 Jul 2021)


Log Message
Remove USE_64KB_PAGE_BLOCK
https://bugs.webkit.org/show_bug.cgi?id=227905

Patch by Michael Catanzaro  on 2021-07-13
Reviewed by Yusuke Suzuki.

.:

I added the USE_64KB_PAGE_BLOCK build option in bug #217989 for use by RHEL. But going
forward, I don't need it anymore, and can maintain it downstream where it is needed. (This
option might also be useful to SUSE, but they already don't use it, so won't miss it.)

I've seen users who don't understand the consequences of this option enabling it on x86_64,
even though there are serious negative consequences and zero benefits to using it. So let's
get rid of it.

* Source/cmake/WebKitFeatures.cmake:

Source/WTF:

* wtf/PageBlock.h:

Modified Paths

trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PageBlock.h
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (279891 => 279892)

--- trunk/ChangeLog	2021-07-13 21:08:25 UTC (rev 279891)
+++ trunk/ChangeLog	2021-07-13 21:53:22 UTC (rev 279892)
@@ -1,3 +1,20 @@
+2021-07-13  Michael Catanzaro  
+
+Remove USE_64KB_PAGE_BLOCK
+https://bugs.webkit.org/show_bug.cgi?id=227905
+
+Reviewed by Yusuke Suzuki.
+
+I added the USE_64KB_PAGE_BLOCK build option in bug #217989 for use by RHEL. But going
+forward, I don't need it anymore, and can maintain it downstream where it is needed. (This
+option might also be useful to SUSE, but they already don't use it, so won't miss it.)
+
+I've seen users who don't understand the consequences of this option enabling it on x86_64,
+even though there are serious negative consequences and zero benefits to using it. So let's
+get rid of it.
+
+* Source/cmake/WebKitFeatures.cmake:
+
 2021-07-13  Carlos Garcia Campos  
 
 [GTK][WPE] Expose support for client certificate auth


Modified: trunk/Source/WTF/ChangeLog (279891 => 279892)

--- trunk/Source/WTF/ChangeLog	2021-07-13 21:08:25 UTC (rev 279891)
+++ trunk/Source/WTF/ChangeLog	2021-07-13 21:53:22 UTC (rev 279892)
@@ -1,3 +1,12 @@
+2021-07-13  Michael Catanzaro  
+
+Remove USE_64KB_PAGE_BLOCK
+https://bugs.webkit.org/show_bug.cgi?id=227905
+
+Reviewed by Yusuke Suzuki.
+
+* wtf/PageBlock.h:
+
 2021-07-12  Filip Pizlo   and Yusuke Suzuki  
 
 New malloc algorithm


Modified: trunk/Source/WTF/wtf/PageBlock.h (279891 => 279892)

--- trunk/Source/WTF/wtf/PageBlock.h	2021-07-13 21:08:25 UTC (rev 279891)
+++ trunk/Source/WTF/wtf/PageBlock.h	2021-07-13 21:53:22 UTC (rev 279892)
@@ -43,13 +43,10 @@
 //
 // On Linux, Power systems normally use 64 KiB pages.
 //
-// aarch64 systems seem to be all over the place. Most Linux distros use 4 KiB, but RHEL uses
-// 64 KiB. (Apple uses 16 KiB.)
-//
 // Use 64 KiB for any unknown CPUs to be conservative.
 #if OS(DARWIN) || PLATFORM(PLAYSTATION) || CPU(MIPS) || CPU(MIPS64)
 constexpr size_t CeilingOnPageSize = 16 * KB;
-#elif USE(64KB_PAGE_BLOCK) || CPU(PPC) || CPU(PPC64) || CPU(PPC64LE) || CPU(UNKNOWN)
+#elif CPU(PPC) || CPU(PPC64) || CPU(PPC64LE) || CPU(UNKNOWN)
 constexpr size_t CeilingOnPageSize = 64 * KB;
 #elif OS(WINDOWS) || CPU(X86) || CPU(X86_64) || CPU(ARM) || CPU(ARM64)
 constexpr size_t CeilingOnPageSize = 4 * KB;


Modified: trunk/Source/cmake/WebKitFeatures.cmake (279891 => 279892)

--- trunk/Source/cmake/WebKitFeatures.cmake	2021-07-13 21:08:25 UTC (rev 279891)
+++ trunk/Source/cmake/WebKitFeatures.cmake	2021-07-13 21:53:22 UTC (rev 279892)
@@ -59,39 +59,10 @@
 list(APPEND _WEBKIT_AVAILABLE_OPTIONS_${_name}_DEPENDENCIES ${_depend})
 endmacro()
 
-# We can't use WEBKIT_OPTION_DEFINE for USE_64KB_PAGE_BLOCK because it's needed to set the default
-# value of other options. Why do we need this option? Because JSC and bmalloc both want to know the
-# userspace page size at compile time, which is impossible on Linux because it's a runtime setting.
-# We cannot test the system page size at build time in hopes that it will be the same on the target
-# system, because (a) cross compiling wouldn't work, and (b) the build system could use a different
-# page size than the target system (which will be true for Fedora aarch64, because Fedora is built
-# using RHEL), so the best we can do is guess based on based on the target CPU architecture. In
-# practice, guessing works for all architectures except aarch64 (unless unusual page sizes are
-# used), but it fails for aarch64 because distros are split between using 4 KB and 64 KB pages
-# there. Most distros (including Fedora) use 4 KB, but RHEL uses 64 KB. SUSE actually supports both.
-# Since there is no way to guess correctly, the best we can do is provide an option for it. You
-# should probably only use this if building for aarch64. Otherwise, known CPUs except PowerPC
-# will use 4 KB, while PowerPC and unknown CPUs will use 64 KB (see 

[webkit-changes] [279891] trunk/Source/WebKit

[peng . liu6]

Title: [279891] trunk/Source/WebKit








Revision 279891
Author peng.l...@apple.com
Date 2021-07-13 14:08:25 -0700 (Tue, 13 Jul 2021)


Log Message
[GPUP] RemoteMediaPlayerProxy may not send the latest "naturalSize" to MediaPlayerPrivateRemote
https://bugs.webkit.org/show_bug.cgi?id=227894

Reviewed by Jer Noble.

When a `MediaPlayerPrivateMediaSourceAVFObjC` in the GPU process changes its `naturalSize`,
the new value will be sent to the WebContent process in the IPC message
`MediaPlayerPrivateRemote::SizeChanged`. However, `RemoteMediaPlayerProxy` won't update
`m_cachedState.naturalSize`. So the next `MediaPlayerPrivateRemote::UpdateCachedState`
message will use the old `naturalSize` and the WebContent process will drop the correct value
after receiving the message.

* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSizeChanged):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (279890 => 279891)

--- trunk/Source/WebKit/ChangeLog	2021-07-13 20:56:39 UTC (rev 279890)
+++ trunk/Source/WebKit/ChangeLog	2021-07-13 21:08:25 UTC (rev 279891)
@@ -1,3 +1,20 @@
+2021-07-13  Peng Liu  
+
+[GPUP] RemoteMediaPlayerProxy may not send the latest "naturalSize" to MediaPlayerPrivateRemote
+https://bugs.webkit.org/show_bug.cgi?id=227894
+
+Reviewed by Jer Noble.
+
+When a `MediaPlayerPrivateMediaSourceAVFObjC` in the GPU process changes its `naturalSize`,
+the new value will be sent to the WebContent process in the IPC message
+`MediaPlayerPrivateRemote::SizeChanged`. However, `RemoteMediaPlayerProxy` won't update
+`m_cachedState.naturalSize`. So the next `MediaPlayerPrivateRemote::UpdateCachedState`
+message will use the old `naturalSize` and the WebContent process will drop the correct value
+after receiving the message.
+
+* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+(WebKit::RemoteMediaPlayerProxy::mediaPlayerSizeChanged):
+
 2021-07-13  Alex Christensen  
 
 Unreviewed, reverting r279647.


Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp (279890 => 279891)

--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp	2021-07-13 20:56:39 UTC (rev 279890)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp	2021-07-13 21:08:25 UTC (rev 279891)
@@ -659,7 +659,8 @@
 
 void RemoteMediaPlayerProxy::mediaPlayerSizeChanged()
 {
-m_webProcessConnection->send(Messages::MediaPlayerPrivateRemote::SizeChanged(m_player->naturalSize()), m_id);
+m_cachedState.naturalSize = m_player->naturalSize();
+m_webProcessConnection->send(Messages::MediaPlayerPrivateRemote::SizeChanged(m_cachedState.naturalSize), m_id);
 }
 
 void RemoteMediaPlayerProxy::mediaPlayerActiveSourceBuffersChanged()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279890] trunk/Source/WebKit

[achristensen]

Title: [279890] trunk/Source/WebKit








Revision 279890
Author achristen...@apple.com
Date 2021-07-13 13:56:39 -0700 (Tue, 13 Jul 2021)


Log Message
Unreviewed, reverting r279647.


Introduced a crash

Reverted changeset:

"XPC services should release their os transaction when given a
SIGTERM signal"
https://bugs.webkit.org/show_bug.cgi?id=227747
https://commits.webkit.org/r279647

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (279889 => 279890)

--- trunk/Source/WebKit/ChangeLog	2021-07-13 20:38:20 UTC (rev 279889)
+++ trunk/Source/WebKit/ChangeLog	2021-07-13 20:56:39 UTC (rev 279890)
@@ -1,3 +1,17 @@
+2021-07-13  Alex Christensen  
+
+Unreviewed, reverting r279647.
+
+
+Introduced a crash
+
+Reverted changeset:
+
+"XPC services should release their os transaction when given a
+SIGTERM signal"
+https://bugs.webkit.org/show_bug.cgi?id=227747
+https://commits.webkit.org/r279647
+
 2021-07-13  Kate Cheney  
 
 Unreviewed iOS/tvOS/watchOS build fix.


Modified: trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h (279889 => 279890)

--- trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h	2021-07-13 20:38:20 UTC (rev 279889)
+++ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h	2021-07-13 20:56:39 UTC (rev 279890)
@@ -101,10 +101,6 @@
 // the UIProcess takes process assertions on behalf of its child processes.
 #if PLATFORM(MAC)
 osTransaction() = adoptOSObject(os_transaction_create("WebKit XPC Service"));
-signal(SIGTERM, [] (int signal) {
-RELEASE_ASSERT(signal == SIGTERM);
-osTransaction() = nullptr;
-});
 #endif
 
 InitializeWebKit2();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279889] trunk/Source/JavaScriptCore

[yijia_huang]

Title: [279889] trunk/Source/_javascript_Core








Revision 279889
Author yijia_hu...@apple.com
Date 2021-07-13 13:38:20 -0700 (Tue, 13 Jul 2021)


Log Message
Add a new Air::Arg kind ZeroReg to let AIR recognise the new instructions/forms accepting zero register in ARM64
https://bugs.webkit.org/show_bug.cgi?id=227510

Reviewed by Saam Barati.

B3 is designed to be portable to many kinds of CPUs. However, to effectively
compile code to different CPUs, the compiler must eventually make explicit
instruction set details. Then, Air is introduced, and it is designed to target
individual CPU architectures and generate instructions specific to those CPUs.

Previously, Air don't recognize the zero register. This problem has been pointed
out in #174821, which was trying to introduce the new opcodes to handle the zero
register.

To solve this problem in a modular reasoning approach, a new Air operand ZeroReg
should be introduced. Its goal is to closely match the CPU instructions
accepting the zero register in ARM64. Another reason is that the new overloads
of the instructions taking the zero register can benefit instruction selection
with this implementation.

Here, the ZeroReg is added as a new kind for Air::Arg, which acts as a "high
level" operand to be emitted with the associative opcodes. In ARM64, the ZeroReg
would be emitted as a zero register.

* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::storeZero64): Deleted.
(JSC::MacroAssemblerARM64::storeZero32): Deleted.
(JSC::MacroAssemblerARM64::storeZero16): Deleted.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::storeZero32): Deleted.
(JSC::MacroAssemblerX86Common::storeZero16): Deleted.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storeZero64): Deleted.
* b3/B3LowerToAir.cpp:
* b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::jsHash const):
(JSC::B3::Air::Arg::dump const):
(WTF::printInternal):
* b3/air/AirArg.h:
(JSC::B3::Air::Arg::zeroReg):
(JSC::B3::Air::Arg::isZeroReg const):
(JSC::B3::Air::Arg::isGP const):
(JSC::B3::Air::Arg::isFP const):
(JSC::B3::Air::Arg::isValidForm const):
(JSC::B3::Air::Arg::asZeroReg const):
* b3/air/AirLowerStackArgs.cpp:
(JSC::B3::Air::lowerStackArgs):
* b3/air/AirOpcode.opcodes:
* b3/air/opcode_generator.rb:
* b3/testb3.h:
* b3/testb3_1.cpp:
(run):
* b3/testb3_3.cpp:
(testStoreZeroReg):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/air/AirArg.cpp
trunk/Source/_javascript_Core/b3/air/AirArg.h
trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/air/opcode_generator.rb
trunk/Source/_javascript_Core/b3/testb3.h
trunk/Source/_javascript_Core/b3/testb3_1.cpp
trunk/Source/_javascript_Core/b3/testb3_3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (279888 => 279889)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-13 20:13:07 UTC (rev 279888)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-13 20:38:20 UTC (rev 279889)
@@ -1,3 +1,60 @@
+2021-07-13  Yijia Huang  
+
+Add a new Air::Arg kind ZeroReg to let AIR recognise the new instructions/forms accepting zero register in ARM64
+https://bugs.webkit.org/show_bug.cgi?id=227510
+
+Reviewed by Saam Barati.
+
+B3 is designed to be portable to many kinds of CPUs. However, to effectively 
+compile code to different CPUs, the compiler must eventually make explicit 
+instruction set details. Then, Air is introduced, and it is designed to target 
+individual CPU architectures and generate instructions specific to those CPUs. 
+
+Previously, Air don't recognize the zero register. This problem has been pointed 
+out in #174821, which was trying to introduce the new opcodes to handle the zero 
+register. 
+
+To solve this problem in a modular reasoning approach, a new Air operand ZeroReg 
+should be introduced. Its goal is to closely match the CPU instructions 
+accepting the zero register in ARM64. Another reason is that the new overloads 
+of the instructions taking the zero register can benefit instruction selection 
+with this implementation. 
+
+Here, the ZeroReg is added as a new kind for Air::Arg, which acts as a "high 
+level" operand to be emitted with the associative opcodes. In ARM64, the ZeroReg 
+would be emitted as a zero register.
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::storeZero64): Deleted.
+(JSC::MacroAssemblerARM64::storeZero32): Deleted.
+(JSC::MacroAssemblerARM64::storeZero16): Deleted.
+* assembler/MacroAssemblerX86Common.h:
+   

[webkit-changes] [279887] trunk/LayoutTests

[commit-queue]

Title: [279887] trunk/LayoutTests








Revision 279887
Author commit-qu...@webkit.org
Date 2021-07-13 13:13:05 -0700 (Tue, 13 Jul 2021)


Log Message
[GLIB] Test gardening, remove platform specific expected files
https://bugs.webkit.org/show_bug.cgi?id=227908

These tests now pass with the generic expected files.
Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov  on 2021-07-13

* platform/glib/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-nested-same-in-same-self-allow-expected.txt: Removed.
* platform/wpe/crypto/subtle/ecdh-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey-expected.txt: Removed.
* platform/wpe/crypto/subtle/ecdsa-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/glib/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/
trunk/LayoutTests/platform/wpe/crypto/




Diff

Modified: trunk/LayoutTests/ChangeLog (279886 => 279887)

--- trunk/LayoutTests/ChangeLog	2021-07-13 19:43:42 UTC (rev 279886)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 20:13:05 UTC (rev 279887)
@@ -1,3 +1,16 @@
+2021-07-13  Arcady Goldmints-Orlov  
+
+[GLIB] Test gardening, remove platform specific expected files
+https://bugs.webkit.org/show_bug.cgi?id=227908
+
+These tests now pass with the generic expected files.
+Unreviewed test gardening.
+
+* platform/glib/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt: Removed.
+* platform/glib/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-nested-same-in-same-self-allow-expected.txt: Removed.
+* platform/wpe/crypto/subtle/ecdh-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey-expected.txt: Removed.
+* platform/wpe/crypto/subtle/ecdsa-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey-expected.txt: Removed.
+
 2021-07-13 Eric Hutchison 
 
 [ Mac wk2 ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html is flaky failing.


Deleted: trunk/LayoutTests/platform/glib/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt (279886 => 279887)

--- trunk/LayoutTests/platform/glib/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt	2021-07-13 19:43:42 UTC (rev 279886)
+++ trunk/LayoutTests/platform/glib/crypto/subtle/ec-generate-key-malformed-parameters-expected.txt	2021-07-13 20:13:05 UTC (rev 279887)
@@ -1,30 +0,0 @@
-Test generating an EC key pair with malformed-paramters.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS crypto.subtle.generateKey("ecdh", extractable, ["deriveKey", "deriveBits"]) rejected promise  with TypeError: Member EcKeyParams.namedCurve is required and must be an instance of DOMString.
-PASS crypto.subtle.generateKey({name: "ecdh"}, extractable, ["deriveKey", "deriveBits"]) rejected promise  with TypeError: Member EcKeyParams.namedCurve is required and must be an instance of DOMString.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: true}, extractable, ["deriveKey", "deriveBits"]) rejected promise  with NotSupportedError: The algorithm is not supported.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: null}, extractable, ["deriveKey", "deriveBits"]) rejected promise  with NotSupportedError: The algorithm is not supported.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: undefined}, extractable, ["deriveKey", "deriveBits"]) rejected promise  with TypeError: Member EcKeyParams.namedCurve is required and must be an instance of DOMString.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: Symbol()}, extractable, ["deriveKey", "deriveBits"]) rejected promise  with TypeError: Cannot convert a symbol to a string.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: { }}, extractable, ["deriveKey", "deriveBits"]) rejected promise  with NotSupportedError: The algorithm is not supported.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: 1}, extractable, ["deriveKey", "deriveBits"]) rejected promise  with NotSupportedError: The algorithm is not supported.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: "P-256"}, extractable, ["encrypt"]) rejected promise  with SyntaxError: A required parameter was missing or out-of-range.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: "P-256"}, extractable, ["decrypt"]) rejected promise  with SyntaxError: A required parameter was missing or out-of-range.
-PASS crypto.subtle.generateKey({name: "ecdh", namedCurve: "P-256"}, extractable, ["sign"]) rejected promise  with SyntaxError: A required parameter was missing or out-of-range.
-PASS 

[webkit-changes] [279888] tags/Safari-612.1.15.4.6/

[repstein]

Title: [279888] tags/Safari-612.1.15.4.6/








Revision 279888
Author repst...@apple.com
Date 2021-07-13 13:13:07 -0700 (Tue, 13 Jul 2021)


Log Message
Tag Safari-612.1.15.4.6.

Added Paths

tags/Safari-612.1.15.4.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279886] trunk

[commit-queue]

Title: [279886] trunk








Revision 279886
Author commit-qu...@webkit.org
Date 2021-07-13 12:43:42 -0700 (Tue, 13 Jul 2021)


Log Message
>4K Referer should have tailing /
https://bugs.webkit.org/show_bug.cgi?id=227795

Patch by Alex Christensen  on 2021-07-13
Reviewed by Chris Dumez.

Source/WebCore:

This matches the behavior of other browsers.
Covered by existing tests and web platform tests we haven't imported yet.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setHTTPReferrer):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (279885 => 279886)

--- trunk/Source/WebCore/ChangeLog	2021-07-13 19:38:32 UTC (rev 279885)
+++ trunk/Source/WebCore/ChangeLog	2021-07-13 19:43:42 UTC (rev 279886)
@@ -1,3 +1,16 @@
+2021-07-13  Alex Christensen  
+
+>4K Referer should have tailing /
+https://bugs.webkit.org/show_bug.cgi?id=227795
+
+Reviewed by Chris Dumez.
+
+This matches the behavior of other browsers.
+Covered by existing tests and web platform tests we haven't imported yet.
+
+* platform/network/ResourceRequestBase.cpp:
+(WebCore::ResourceRequestBase::setHTTPReferrer):
+
 2021-07-13  Said Abou-Hallawa  
 
 [CG] REGRESSION(r278863): The destination rectangle is truncated when the sub-image is used


Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp (279885 => 279886)

--- trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp	2021-07-13 19:38:32 UTC (rev 279885)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp	2021-07-13 19:43:42 UTC (rev 279886)
@@ -394,7 +394,7 @@
 constexpr size_t maxLength = 4096;
 if (httpReferrer.length() > maxLength) {
 RELEASE_LOG(Loading, "Truncating HTTP referer");
-String origin = SecurityOrigin::create(URL(URL(), httpReferrer))->toString();
+String origin = URL(URL(), SecurityOrigin::create(URL(URL(), httpReferrer))->toString()).string();
 if (origin.length() <= maxLength)
 setHTTPHeaderField(HTTPHeaderName::Referer, origin);
 } else


Modified: trunk/Tools/ChangeLog (279885 => 279886)

--- trunk/Tools/ChangeLog	2021-07-13 19:38:32 UTC (rev 279885)
+++ trunk/Tools/ChangeLog	2021-07-13 19:43:42 UTC (rev 279886)
@@ -1,3 +1,13 @@
+2021-07-13  Alex Christensen  
+
+>4K Referer should have tailing /
+https://bugs.webkit.org/show_bug.cgi?id=227795
+
+Reviewed by Chris Dumez.
+
+* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
+(TEST):
+
 2021-07-13  Said Abou-Hallawa  
 
 [CG] REGRESSION(r278863): The destination rectangle is truncated when the sub-image is used


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm (279885 => 279886)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm	2021-07-13 19:38:32 UTC (rev 279885)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm	2021-07-13 19:43:42 UTC (rev 279886)
@@ -76,7 +76,7 @@
 NSString *shorterPath = [NSString stringWithFormat:@"http://webkit.org/%s?asdf", a3k.data()];
 NSString *longHost = [NSString stringWithFormat:@"http://webkit.org%s/path", a5k.data()];
 NSString *shorterHost = [NSString stringWithFormat:@"http://webkit.org%s/path", a3k.data()];
-checkReferer([NSURL URLWithString:longPath], "http://webkit.org");
+checkReferer([NSURL URLWithString:longPath], "http://webkit.org/");
 checkReferer([NSURL URLWithString:shorterPath], shorterPath.UTF8String);
 checkReferer([NSURL URLWithString:longHost], nullptr);
 checkReferer([NSURL URLWithString:shorterHost], shorterHost.UTF8String);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279885] trunk

[said]

Title: [279885] trunk








Revision 279885
Author s...@apple.com
Date 2021-07-13 12:38:32 -0700 (Tue, 13 Jul 2021)


Log Message
[CG] REGRESSION(r278863): The destination rectangle is truncated when the sub-image is used
https://bugs.webkit.org/show_bug.cgi?id=227614


Reviewed by Simon Fraser.

Source/WebCore:

This patch gets the calculation of the destRect in the case of the sub-
image as it was before r278863.

The size of the destRect has to be equal to the backend size of the
ImageBuffer in logical coordinates.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::drawNativeImage):

Tools:

Add an API test to test drawing an ImageBuffer into another and both
have the logicalSize scaled such that they have pixels.

* TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (279884 => 279885)

--- trunk/Source/WebCore/ChangeLog	2021-07-13 19:35:38 UTC (rev 279884)
+++ trunk/Source/WebCore/ChangeLog	2021-07-13 19:38:32 UTC (rev 279885)
@@ -1,3 +1,20 @@
+2021-07-13  Said Abou-Hallawa  
+
+[CG] REGRESSION(r278863): The destination rectangle is truncated when the sub-image is used
+https://bugs.webkit.org/show_bug.cgi?id=227614
+
+
+Reviewed by Simon Fraser.
+
+This patch gets the calculation of the destRect in the case of the sub-
+image as it was before r278863.
+
+The size of the destRect has to be equal to the backend size of the
+ImageBuffer in logical coordinates.
+
+* platform/graphics/cg/GraphicsContextCG.cpp:
+(WebCore::GraphicsContextCG::drawNativeImage):
+
 2021-07-13  Kyle Piddington  
 
 rAF driven WebGL submits excessive amount of GPU work when frames are slow


Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (279884 => 279885)

--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2021-07-13 19:35:38 UTC (rev 279884)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2021-07-13 19:38:32 UTC (rev 279885)
@@ -297,8 +297,10 @@
 // interpolation smoothes sharp edges, causing pixels from outside the source rect to bleed
 // into the destination rect. See .
 subImage = getSubimage(subImage.get(), imageSize, subimageRect, options);
-adjustedDestRect = enclosingIntRect(adjustedDestRect);
 
+auto subPixelPadding = normalizedSrcRect.location() - subimageRect.location();
+adjustedDestRect = { adjustedDestRect.location() - subPixelPadding * scale, subimageRect.size() * scale };
+
 // If the image is only partially loaded, then shrink the destination rect that we're drawing
 // into accordingly.
 if (currentImageSize.height() < normalizedSrcRect.maxY()) {


Modified: trunk/Tools/ChangeLog (279884 => 279885)

--- trunk/Tools/ChangeLog	2021-07-13 19:35:38 UTC (rev 279884)
+++ trunk/Tools/ChangeLog	2021-07-13 19:38:32 UTC (rev 279885)
@@ -1,3 +1,17 @@
+2021-07-13  Said Abou-Hallawa  
+
+[CG] REGRESSION(r278863): The destination rectangle is truncated when the sub-image is used
+https://bugs.webkit.org/show_bug.cgi?id=227614
+
+
+Reviewed by Simon Fraser.
+
+Add an API test to test drawing an ImageBuffer into another and both
+have the logicalSize scaled such that they have pixels.
+
+* TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp:
+(TestWebKitAPI::TEST):
+
 2021-07-13  Kevin Neal  
 
 [results.webkit.org] linkify urls in commit messages


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp (279884 => 279885)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp	2021-07-13 19:35:38 UTC (rev 279884)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp	2021-07-13 19:38:32 UTC (rev 279885)
@@ -49,4 +49,56 @@
 EXPECT_NE(nullptr, displayListUnaccelerated);
 }
 
+TEST(ImageBufferTests, ImageBufferSubPixelDrawing)
+{
+auto colorSpace = DestinationColorSpace::SRGB();
+auto pixelFormat = PixelFormat::BGRA8;
+FloatSize logicalSize { 392, 44 };
+float scale = 1.91326535;
+auto frontImageBuffer = ImageBuffer::create(logicalSize, RenderingMode::Accelerated, scale, colorSpace, pixelFormat, nullptr);
+auto backImageBuffer = ImageBuffer::create(logicalSize, RenderingMode::Accelerated, scale, colorSpace, pixelFormat, nullptr);
+
+auto strokeRect = FloatRect { { }, logicalSize };
+strokeRect.inflate(-0.5);
+auto fillRect = strokeRect;
+fillRect.inflate(-1);
+
+auto& frontContext = frontImageBuffer->context();
+auto& backContext = backImageBuffer->context();
+
+frontContext.setShouldAntialias(false);
+

[webkit-changes] [279884] trunk/LayoutTests

[jenner]

Title: [279884] trunk/LayoutTests








Revision 279884
Author jen...@apple.com
Date 2021-07-13 12:35:38 -0700 (Tue, 13 Jul 2021)


Log Message
[ Mac wk2 ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=227910.

Unreviewed test gardening.

Patch by Eric Hutchison  on 2021-07-13

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279883 => 279884)

--- trunk/LayoutTests/ChangeLog	2021-07-13 19:28:19 UTC (rev 279883)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 19:35:38 UTC (rev 279884)
@@ -1,3 +1,12 @@
+2021-07-13 Eric Hutchison 
+
+[ Mac wk2 ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=227910.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-07-13  Ayumi Kojima  
 
 [iOS] http/tests/appcache/fail-on-update.html is a flaky timeout.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (279883 => 279884)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-13 19:28:19 UTC (rev 279883)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-13 19:35:38 UTC (rev 279884)
@@ -1279,7 +1279,6 @@
 webkit.org/b/223293 media/media-fullscreen-return-to-inline.html [ Pass Failure Timeout ]
 
 # webkit.org/b/223385 Two imported webrtc tests are flakey text failing only on Apple Silicon
-[ arm64 ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ]
 [ arm64 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-connectionSetup.html [ Pass Failure ]
 
 webkit.org/b/223387 media/track/track-cue-css.html [ Pass ImageOnlyFailure ]
@@ -1392,4 +1391,6 @@
 
 webkit.org/b/227874 [ BigSur Release ] fullscreen/full-screen-remove-children.html [ Pass Crash ]
 
-webkit.org/b/227890 fast/canvas/canvas-path-addPath.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/227890 fast/canvas/canvas-path-addPath.html [ Pass Timeout ]
+
+webkit.org/b/227910 imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279883] trunk/Source

[kpiddington]

Title: [279883] trunk/Source








Revision 279883
Author kpidding...@apple.com
Date 2021-07-13 12:28:19 -0700 (Tue, 13 Jul 2021)


Log Message
rAF driven WebGL submits excessive amount of GPU work when frames are slow
https://bugs.webkit.org/show_bug.cgi?id=227059

Reviewed by Dean Jackson.

Advertise GL_ARB_sync for the Metal backend.
Since GL_ARB_sync is core in OpenGL ES 3.0 and the Metal backend advertises OpenGL ES 3.0,
the API must be working already.

Limit in-flight WebGL frames to three frames. Do not continue preparation for display
until the commands for the oldest frame have been executed by the GPU.

This limits the impact slow frames have, especially in the
case where the compositor skip frames and WebKit would issue a new slow frame
on top of the skipped frame.

Source/ThirdParty/ANGLE:

	An additional change ensures that Nvidia configs, which do not support MTLEvents
	to a level of conformance required (See http://crbug.com/1136673), continue to run. The more powerful eGPUs will not experience throttling to the same level as integrated GPUS.
* src/libANGLE/renderer/metal/DisplayMtl.mm:
(rx::DisplayMtl::initializeExtensions const):

Source/WebCore:

An additional change ensures that Nvidia configs, which do not support MTLEvents
to a level of conformance required (See http://crbug.com/1136673), continue to run. The more powerful eGPUs will not experience throttling to the same level as integrated GPUS.

* Headers.cmake:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContextGLAttributes.h:
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::waitAndUpdateOldestFrame):
* platform/graphics/angle/GraphicsContextGLANGLEUtilities.h:
(WebCore::ScopedGLFence::ScopedGLFence):
(WebCore::ScopedGLFence::~ScopedGLFence):
(WebCore::ScopedGLFence::operator=):
(WebCore::ScopedGLFence::reset):
(WebCore::ScopedGLFence::abandon):
(WebCore::ScopedGLFence::fenceSync):
(WebCore::ScopedGLFence::operator GLsync const):
(WebCore::ScopedGLFence::operator bool const):
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::InitializeEGLDisplay):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::prepareForDisplay):
* platform/graphics/opengl/GraphicsContextGLOpenGL.h:

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLEUtilities.h
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (279882 => 279883)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-07-13 19:20:46 UTC (rev 279882)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-07-13 19:28:19 UTC (rev 279883)
@@ -1,3 +1,26 @@
+2021-07-13  Kyle Piddington  
+
+rAF driven WebGL submits excessive amount of GPU work when frames are slow
+https://bugs.webkit.org/show_bug.cgi?id=227059
+
+Reviewed by Dean Jackson.
+
+Advertise GL_ARB_sync for the Metal backend.
+Since GL_ARB_sync is core in OpenGL ES 3.0 and the Metal backend advertises OpenGL ES 3.0,
+the API must be working already.
+
+Limit in-flight WebGL frames to three frames. Do not continue preparation for display
+until the commands for the oldest frame have been executed by the GPU.
+
+This limits the impact slow frames have, especially in the
+case where the compositor skip frames and WebKit would issue a new slow frame
+on top of the skipped frame.
+
+	An additional change ensures that Nvidia configs, which do not support MTLEvents
+	to a level of conformance required (See http://crbug.com/1136673), continue to run. The more powerful eGPUs will not experience throttling to the same level as integrated GPUS.
+* src/libANGLE/renderer/metal/DisplayMtl.mm:
+(rx::DisplayMtl::initializeExtensions const):
+
 2021-07-07  Kyle Piddington  
 
 WebGL shader link error in iOS 15 beta: "Internal error compiling shader with Metal backend"


Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm (279882 => 279883)

--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm	2021-07-13 19:20:46 UTC (rev 279882)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm	2021-07-13 19:28:19 UTC (rev 279883)
@@ -884,6 +884,9 @@
 
 // GL_OES_EGL_sync
 mNativeExtensions.eglSyncOES = true;
+
+// GL_ARB_sync
+  

[webkit-changes] [279882] trunk/LayoutTests

[ryanhaddad]

Title: [279882] trunk/LayoutTests








Revision 279882
Author ryanhad...@apple.com
Date 2021-07-13 12:20:46 -0700 (Tue, 13 Jul 2021)


Log Message
[iOS] http/tests/appcache/fail-on-update.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=227891

Unreviewed test gardening.

Patch by Ayumi Kojima  on 2021-07-13

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279881 => 279882)

--- trunk/LayoutTests/ChangeLog	2021-07-13 19:18:51 UTC (rev 279881)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 19:20:46 UTC (rev 279882)
@@ -1,3 +1,12 @@
+2021-07-13  Ayumi Kojima  
+
+[iOS] http/tests/appcache/fail-on-update.html is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=227891
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-07-13  Truitt Savell  
 
 REGRESSION: [wk2 Debug] accessibility/table-title.html is a flaky timeout


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (279881 => 279882)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-13 19:18:51 UTC (rev 279881)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-07-13 19:20:46 UTC (rev 279882)
@@ -1059,6 +1059,8 @@
 # Uses WK1 TestRunner.setUseDeferredFramLoading
 http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ]
 
+webkit.org/b/227891 http/tests/appcache/fail-on-update.html [ Pass Timeout ]
+
 webkit.org/b/153050 http/tests/security/cross-frame-access-custom.html [ Pass Failure ]
 
 webkit.org/b/155201 storage/domstorage/events/basic-body-attribute.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279881] trunk

[cdumez]

Title: [279881] trunk








Revision 279881
Author cdu...@apple.com
Date 2021-07-13 12:18:51 -0700 (Tue, 13 Jul 2021)


Log Message
Revoking Blob URL after calling XMLHttpRequest::open() causes the XHR to fail
https://bugs.webkit.org/show_bug.cgi?id=227821

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

* web-platform-tests/FileAPI/url/url-with-xhr.any-expected.txt:
* web-platform-tests/FileAPI/url/url-with-xhr.any.worker-expected.txt:

Source/WebCore:

Revoking Blob URL after calling XMLHttpRequest::open() causes the XHR to fail. This doesn't match the behavior of
other browsers and is causing WebKit to fail one of the subtests on:
- http://wpt.live/FileAPI/url/url-with-xhr.any.html

XMLHttpRequest::open() now extends the lifetime of the Blob URL as necessary in order to complete the load.

No new tests, rebaselined existing tests.

* fileapi/BlobURL.cpp:
(WebCore::URLWithBlobURLLifetimeExtension::URLWithBlobURLLifetimeExtension):
(WebCore::URLWithBlobURLLifetimeExtension::~URLWithBlobURLLifetimeExtension):
* fileapi/BlobURL.h:
(WebCore::BlobURLLifeTimeExtender::url const):
* loader/PolicyChecker.cpp:
(WebCore::FrameLoader::PolicyChecker::extendBlobURLLifetimeIfNecessary const):
(WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy):
* loader/PolicyChecker.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::prepareToSend):
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::createRequest):
* xml/XMLHttpRequest.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/BlobURL.cpp
trunk/Source/WebCore/fileapi/BlobURL.h
trunk/Source/WebCore/loader/PolicyChecker.cpp
trunk/Source/WebCore/loader/PolicyChecker.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279880 => 279881)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-13 18:50:07 UTC (rev 279880)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-13 19:18:51 UTC (rev 279881)
@@ -1,3 +1,15 @@
+2021-07-13  Chris Dumez  
+
+Revoking Blob URL after calling XMLHttpRequest::open() causes the XHR to fail
+https://bugs.webkit.org/show_bug.cgi?id=227821
+
+Reviewed by Alex Christensen.
+
+Rebaseline WPT tests now that more checks are passing.
+
+* web-platform-tests/FileAPI/url/url-with-xhr.any-expected.txt:
+* web-platform-tests/FileAPI/url/url-with-xhr.any.worker-expected.txt:
+
 2021-07-13  Martin Robinson  
 
 RenderLayerScrollableArea::updateScrollPosition assumes that it can scroll to the targeted scroll position


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any-expected.txt (279880 => 279881)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any-expected.txt	2021-07-13 18:50:07 UTC (rev 279880)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any-expected.txt	2021-07-13 19:18:51 UTC (rev 279881)
@@ -12,5 +12,5 @@
 PASS XHR with method "PUT" should fail
 PASS XHR with method "CUSTOM" should fail
 PASS XHR should return Content-Type from Blob
-FAIL Revoke blob URL after open(), will fetch assert_unreached: Got unexpected error event Reached unreachable code
+PASS Revoke blob URL after open(), will fetch
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any.worker-expected.txt (279880 => 279881)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any.worker-expected.txt	2021-07-13 18:50:07 UTC (rev 279880)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-xhr.any.worker-expected.txt	2021-07-13 19:18:51 UTC (rev 279881)
@@ -12,5 +12,5 @@
 PASS XHR with method "PUT" should fail
 PASS XHR with method "CUSTOM" should fail
 PASS XHR should return Content-Type from Blob
-FAIL Revoke blob URL after open(), will fetch assert_unreached: Got unexpected error event Reached unreachable code
+PASS Revoke blob URL after open(), will fetch
 


Modified: trunk/Source/WebCore/ChangeLog (279880 => 279881)

--- trunk/Source/WebCore/ChangeLog	2021-07-13 18:50:07 UTC (rev 279880)
+++ trunk/Source/WebCore/ChangeLog	2021-07-13 19:18:51 UTC (rev 279881)
@@ -1,3 +1,36 @@
+2021-07-13  Chris Dumez  
+
+Revoking Blob URL after calling XMLHttpRequest::open() causes the XHR to fail
+https://bugs.webkit.org/show_bug.cgi?id=227821
+
+Reviewed by Alex Christensen.
+
+Revoking Blob URL after calling XMLHttpRequest::open() causes the XHR to fail. This doesn't 

[webkit-changes] [279880] branches/safari-612.1.15.4-branch/Source

[repstein]

Title: [279880] branches/safari-612.1.15.4-branch/Source








Revision 279880
Author repst...@apple.com
Date 2021-07-13 11:50:07 -0700 (Tue, 13 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.15.4.6

Modified Paths

branches/safari-612.1.15.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.15.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.15.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.15.4-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.15.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.15.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.15.4-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.15.4-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.15.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279879 => 279880)

--- branches/safari-612.1.15.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-13 17:58:53 UTC (rev 279879)
+++ branches/safari-612.1.15.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-13 18:50:07 UTC (rev 279880)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 4;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.15.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279879 => 279880)

--- branches/safari-612.1.15.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-13 17:58:53 UTC (rev 279879)
+++ branches/safari-612.1.15.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-13 18:50:07 UTC (rev 279880)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 4;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.15.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279879 => 279880)

--- branches/safari-612.1.15.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-13 17:58:53 UTC (rev 279879)
+++ branches/safari-612.1.15.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-13 18:50:07 UTC (rev 279880)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 4;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.15.4-branch/Source/WebCore/Configurations/Version.xcconfig (279879 => 279880)

--- branches/safari-612.1.15.4-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-13 17:58:53 UTC (rev 279879)
+++ branches/safari-612.1.15.4-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-13 18:50:07 UTC (rev 279880)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 4;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.15.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279879 => 279880)

--- branches/safari-612.1.15.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-13 17:58:53 UTC (rev 279879)
+++ branches/safari-612.1.15.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-13 18:50:07 UTC (rev 279880)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 4;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.15.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279879 => 279880)

--- branches/safari-612.1.15.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-13 17:58:53 UTC (rev 279879)
+++ branches/safari-612.1.15.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-13 18:50:07 UTC (rev 279880)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 4;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = 

[webkit-changes] [279879] trunk/Source/WebKit

[katherine_cheney]

Title: [279879] trunk/Source/WebKit








Revision 279879
Author katherine_che...@apple.com
Date 2021-07-13 10:58:53 -0700 (Tue, 13 Jul 2021)


Log Message
Unreviewed iOS/tvOS/watchOS build fix.

* UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
* UIProcess/API/APIPageConfiguration.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (279878 => 279879)

--- trunk/Source/WebKit/ChangeLog	2021-07-13 17:43:54 UTC (rev 279878)
+++ trunk/Source/WebKit/ChangeLog	2021-07-13 17:58:53 UTC (rev 279879)
@@ -1,3 +1,11 @@
+2021-07-13  Kate Cheney  
+
+Unreviewed iOS/tvOS/watchOS build fix.
+
+* UIProcess/API/APIPageConfiguration.cpp:
+(API::PageConfiguration::copy const):
+* UIProcess/API/APIPageConfiguration.h:
+
 2021-07-13  Chris Dumez  
 
 Regression(r279601) ProcessAssertion may get destroyed on a background thread


Modified: trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp (279878 => 279879)

--- trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp	2021-07-13 17:43:54 UTC (rev 279878)
+++ trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp	2021-07-13 17:58:53 UTC (rev 279879)
@@ -96,7 +96,7 @@
 
 copy->m_mediaCaptureEnabled = this->m_mediaCaptureEnabled;
 copy->m_httpsUpgradeEnabled = this->m_httpsUpgradeEnabled;
-#if ENABLE(APP_PRIVACY_REPORT)
+#if PLATFORM(IOS_FAMILY)
 copy->m_appInitiatedOverrideValueForTesting = this->m_appInitiatedOverrideValueForTesting;
 #endif
 


Modified: trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h (279878 => 279879)

--- trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h	2021-07-13 17:43:54 UTC (rev 279878)
+++ trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h	2021-07-13 17:58:53 UTC (rev 279879)
@@ -48,7 +48,7 @@
 class WebUserContentControllerProxy;
 class WebsiteDataStore;
 
-#if ENABLE(APP_PRIVACY_REPORT)
+#if PLATFORM(IOS_FAMILY)
 enum class AttributionOverrideTesting : uint8_t {
 NoOverride,
 UserInitiated,
@@ -179,7 +179,7 @@
 void setAttributedBundleIdentifier(WTF::String&& identifier) { m_attributedBundleIdentifier = WTFMove(identifier); }
 const WTF::String& attributedBundleIdentifier() const { return m_attributedBundleIdentifier; }
 
-#if ENABLE(APP_PRIVACY_REPORT)
+#if PLATFORM(IOS_FAMILY)
 WebKit::AttributionOverrideTesting appInitiatedOverrideValueForTesting() const { return m_appInitiatedOverrideValueForTesting; }
 void setAppInitiatedOverrideValueForTesting(WebKit::AttributionOverrideTesting appInitiatedOverrideValueForTesting) { m_appInitiatedOverrideValueForTesting = appInitiatedOverrideValueForTesting; }
 #endif
@@ -236,7 +236,7 @@
 WebCore::ShouldRelaxThirdPartyCookieBlocking m_shouldRelaxThirdPartyCookieBlocking { WebCore::ShouldRelaxThirdPartyCookieBlocking::No };
 WTF::String m_attributedBundleIdentifier;
 
-#if ENABLE(APP_PRIVACY_REPORT)
+#if PLATFORM(IOS_FAMILY)
 WebKit::AttributionOverrideTesting m_appInitiatedOverrideValueForTesting { WebKit::AttributionOverrideTesting::NoOverride };
 #endif
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279878] trunk/LayoutTests

[tsavell]

Title: [279878] trunk/LayoutTests








Revision 279878
Author tsav...@apple.com
Date 2021-07-13 10:43:54 -0700 (Tue, 13 Jul 2021)


Log Message
REGRESSION: [wk2 Debug] accessibility/table-title.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=227504

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (279877 => 279878)

--- trunk/LayoutTests/ChangeLog	2021-07-13 17:10:12 UTC (rev 279877)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 17:43:54 UTC (rev 279878)
@@ -1,3 +1,12 @@
+2021-07-13  Truitt Savell  
+
+REGRESSION: [wk2 Debug] accessibility/table-title.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=227504
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-07-13  Kate Cheney  
 
 Allow layout tests to specify app initiated loads or not


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (279877 => 279878)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-13 17:10:12 UTC (rev 279877)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-07-13 17:43:54 UTC (rev 279878)
@@ -1374,7 +1374,7 @@
 
 webkit.org/b/227467 [ BigSur arm64 Release ] fast/css/sticky/sticky-left.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/227504 [ BigSur Debug ] accessibility/table-title.html [ Pass Timeout ]
+webkit.org/b/227504 [ BigSur+ Debug ] accessibility/table-title.html [ Pass Timeout ]
 
 webkit.org/b/227536 [ BigSur ] imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279877] trunk/Source/WebKit

[cdumez]

Title: [279877] trunk/Source/WebKit








Revision 279877
Author cdu...@apple.com
Date 2021-07-13 10:10:12 -0700 (Tue, 13 Jul 2021)


Log Message
Regression(r279601) ProcessAssertion may get destroyed on a background thread
https://bugs.webkit.org/show_bug.cgi?id=227875


Reviewed by Geoffrey Garen.

r279601 added an internal WorkQueue to ProcessAssertion, so that we could acquire the RunningBoard assertion
asynchronously on the background queue. When dispatching to the background queue, we capture |protectedThis|,
which means that ProcessAssertion may now get destroyed on the background queue. To address the isuse, we
now make sure to dispatch |protectedThis| back to the main thread in acquireAsync().

* UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::acquireAsync):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (279876 => 279877)

--- trunk/Source/WebKit/ChangeLog	2021-07-13 17:05:39 UTC (rev 279876)
+++ trunk/Source/WebKit/ChangeLog	2021-07-13 17:10:12 UTC (rev 279877)
@@ -1,3 +1,19 @@
+2021-07-13  Chris Dumez  
+
+Regression(r279601) ProcessAssertion may get destroyed on a background thread
+https://bugs.webkit.org/show_bug.cgi?id=227875
+
+
+Reviewed by Geoffrey Garen.
+
+r279601 added an internal WorkQueue to ProcessAssertion, so that we could acquire the RunningBoard assertion
+asynchronously on the background queue. When dispatching to the background queue, we capture |protectedThis|,
+which means that ProcessAssertion may now get destroyed on the background queue. To address the isuse, we
+now make sure to dispatch |protectedThis| back to the main thread in acquireAsync().
+
+* UIProcess/ios/ProcessAssertionIOS.mm:
+(WebKit::ProcessAssertion::acquireAsync):
+
 2021-07-13  Kate Cheney  
 
 Allow layout tests to specify app initiated loads or not


Modified: trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm (279876 => 279877)

--- trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm	2021-07-13 17:05:39 UTC (rev 279876)
+++ trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm	2021-07-13 17:10:12 UTC (rev 279877)
@@ -343,10 +343,14 @@
 
 void ProcessAssertion::acquireAsync(CompletionHandler&& completionHandler)
 {
+ASSERT(isMainRunLoop());
 assertionsWorkQueue().dispatch([protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)]() mutable {
 protectedThis->acquireSync();
-if (completionHandler)
-RunLoop::main().dispatch(WTFMove(completionHandler));
+if (completionHandler) {
+RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis), completionHandler = WTFMove(completionHandler)]() mutable {
+completionHandler();
+});
+}
 });
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279876] trunk/Tools

[commit-queue]

Title: [279876] trunk/Tools








Revision 279876
Author commit-qu...@webkit.org
Date 2021-07-13 10:05:39 -0700 (Tue, 13 Jul 2021)


Log Message
[results.webkit.org] linkify urls in commit messages
https://bugs.webkit.org/show_bug.cgi?id=227549


Patch by Kevin Neal  on 2021-07-13
Reviewed by Jonathan Bedard.

* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
(thead.tbody.rows.map.):
(thead.tbody.rows.map):
(CommitTable):
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js




Diff

Modified: trunk/Tools/ChangeLog (279875 => 279876)

--- trunk/Tools/ChangeLog	2021-07-13 16:46:18 UTC (rev 279875)
+++ trunk/Tools/ChangeLog	2021-07-13 17:05:39 UTC (rev 279876)
@@ -1,3 +1,18 @@
+2021-07-13  Kevin Neal  
+
+[results.webkit.org] linkify urls in commit messages
+https://bugs.webkit.org/show_bug.cgi?id=227549
+
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
+(thead.tbody.rows.map.):
+(thead.tbody.rows.map):
+(CommitTable):
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js:
+
+
 2021-07-13  Aakash Jain  
 
 [build.webkit.org] Upload layout-tests results immediately after running layout-tests


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js (279875 => 279876)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js	2021-07-13 16:46:18 UTC (rev 279875)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js	2021-07-13 17:05:39 UTC (rev 279876)
@@ -21,7 +21,7 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
 // THE POSSIBILITY OF SUCH DAMAGE.
 
-import {ErrorDisplay, escapeHTML, paramsToQuery, queryToParams} from '/assets/js/common.js';
+import {ErrorDisplay, escapeHTML, linkify, paramsToQuery, queryToParams} from '/assets/js/common.js';
 
 const TIMESTAMP_TO_UUID_MULTIPLIER = 100;
 
@@ -118,8 +118,8 @@
 if (!cell.commit.message)
 return '';
 if (oneLine)
-return `${escapeHTML(cell.commit.message.split('\n')[0])}`;
-return `${escapeHTML(cell.commit.message)}`;
+return `${linkify(escapeHTML(cell.commit.message.split('\n')[0]))}`;
+return `${linkify(escapeHTML(cell.commit.message))}`;
 }()}
 `;
 }).join('')}


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js (279875 => 279876)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js	2021-07-13 16:46:18 UTC (rev 279875)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js	2021-07-13 17:05:39 UTC (rev 279876)
@@ -139,6 +139,10 @@
   });
 }
 
+function linkify(text) {
+return text.replace(/\b(https?|rdar):\/{2}[^\s<>&]+[^\.\s<>&,]/gmi, `$&`);
+}
+
 function deepCompare(a, b) {
 if (a === b)
 return true;
@@ -193,4 +197,4 @@
 return result;
 }
 
-export {deepCompare, ErrorDisplay, queryToParams, paramsToQuery, QueryModifier, escapeHTML, percentage, elapsedTime};
+export {deepCompare, ErrorDisplay, queryToParams, paramsToQuery, QueryModifier, escapeHTML, linkify, percentage, elapsedTime};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279875] trunk/Tools

[aakash_jain]

Title: [279875] trunk/Tools








Revision 279875
Author aakash_j...@apple.com
Date 2021-07-13 09:46:18 -0700 (Tue, 13 Jul 2021)


Log Message
[build.webkit.org] Upload layout-tests results immediately after running layout-tests
https://bugs.webkit.org/show_bug.cgi?id=227889

Reviewed by Carlos Alberto Lopez Perez.

* CISupport/build-webkit-org/factories.py:

Modified Paths

trunk/Tools/CISupport/build-webkit-org/factories.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/build-webkit-org/factories.py (279874 => 279875)

--- trunk/Tools/CISupport/build-webkit-org/factories.py	2021-07-13 16:40:12 UTC (rev 279874)
+++ trunk/Tools/CISupport/build-webkit-org/factories.py	2021-07-13 16:46:18 UTC (rev 279875)
@@ -1,4 +1,4 @@
-# Copyright (C) 2017-2020 Apple Inc. All rights reserved.
+# Copyright (C) 2017-2021 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -97,6 +97,13 @@
 self.addStep(self.JSCTestClass())
 if self.LayoutTestClass:
 self.addStep(self.LayoutTestClass())
+if not platform.startswith('win'):
+self.addStep(RunDashboardTests())
+if self.LayoutTestClass:
+self.addStep(ArchiveTestResults())
+self.addStep(UploadTestResults())
+self.addStep(ExtractTestResults())
+self.addStep(SetPermissions())
 
 if platform.startswith('win') or platform.startswith('mac') or platform.startswith('ios-simulator'):
 self.addStep(RunAPITests())
@@ -108,17 +115,10 @@
 self.addStep(RunPerlTests())
 self.addStep(RunBindingsTests())
 self.addStep(RunBuiltinsTests())
-if not platform.startswith('win'):
-self.addStep(RunDashboardTests())
 
 if platform.startswith('mac') or platform.startswith('ios-simulator'):
 self.addStep(TriggerCrashLogSubmission())
 
-if self.LayoutTestClass:
-self.addStep(ArchiveTestResults())
-self.addStep(UploadTestResults())
-self.addStep(ExtractTestResults())
-self.addStep(SetPermissions())
 if platform == "gtk":
 self.addStep(RunGtkAPITests())
 if additionalArguments and "--display-server=wayland" in additionalArguments:


Modified: trunk/Tools/ChangeLog (279874 => 279875)

--- trunk/Tools/ChangeLog	2021-07-13 16:40:12 UTC (rev 279874)
+++ trunk/Tools/ChangeLog	2021-07-13 16:46:18 UTC (rev 279875)
@@ -1,3 +1,12 @@
+2021-07-13  Aakash Jain  
+
+[build.webkit.org] Upload layout-tests results immediately after running layout-tests
+https://bugs.webkit.org/show_bug.cgi?id=227889
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* CISupport/build-webkit-org/factories.py:
+
 2021-07-13  Kate Cheney  
 
 Allow layout tests to specify app initiated loads or not






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279874] trunk

[katherine_cheney]

Title: [279874] trunk








Revision 279874
Author katherine_che...@apple.com
Date 2021-07-13 09:40:12 -0700 (Tue, 13 Jul 2021)


Log Message
Allow layout tests to specify app initiated loads or not
https://bugs.webkit.org/show_bug.cgi?id=227825


Reviewed by Brent Fulgham.

Source/WebKit:

Tests: http/tests/app-privacy-report/app-attribution-load-url.html
   http/tests/app-privacy-report/app-attribution-ping-load.html
   http/tests/app-privacy-report/app-attribution-post-request.html
   http/tests/app-privacy-report/app-attribution-preflight-async.html
   http/tests/app-privacy-report/app-attribution-preflight-sync.html
   http/tests/app-privacy-report/app-attribution-speculative-revalidation.html
   http/tests/app-privacy-report/user-attribution-load-url.html
   http/tests/app-privacy-report/user-attribution-ping-load.html
   http/tests/app-privacy-report/user-attribution-post-request.html
   http/tests/app-privacy-report/user-attribution-preflight-async.html
   http/tests/app-privacy-report/user-attribution-preflight-sync.html
   http/tests/app-privacy-report/user-attribution-speculative-revalidation.html

Add a parameter to the WebView configuration that allows a test to
override the default NSURLRequest attribution value. We don't need
this to be dynamic per-test, so we can store it in the configuration.

* UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
* UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::appInitiatedOverrideValueForTesting const):
(API::PageConfiguration::setAppInitiatedOverrideValueForTesting):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(toWKAttributionOverrideTesting):
(toAttributionOverrideTesting):
(-[WKWebViewConfiguration _setAppInitiatedOverrideValueForTesting:]):
(-[WKWebViewConfiguration _appInitiatedOverrideValueForTesting]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setLastNavigationWasAppInitiated):

Tools:

Add a test option that specifies whether the test should mark the
main page navigation as app-initiated or not.

* WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::isAppInitiated const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):

LayoutTests:

Added new tests to cover the user initiated case.

* http/tests/app-privacy-report/app-attribution-load-url-expected.txt: Renamed from LayoutTests/http/tests/app-privacy-report/attribution-load-url-expected.txt.
* http/tests/app-privacy-report/app-attribution-load-url.html: Copied from LayoutTests/http/tests/app-privacy-report/attribution-load-url.html.
* http/tests/app-privacy-report/app-attribution-ping-load-expected.txt: Copied from LayoutTests/http/tests/app-privacy-report/attribution-ping-load-expected.txt.
* http/tests/app-privacy-report/app-attribution-ping-load.html: Copied from LayoutTests/http/tests/app-privacy-report/attribution-ping-load.html.
* http/tests/app-privacy-report/app-attribution-post-request-expected.txt: Renamed from LayoutTests/http/tests/app-privacy-report/attribution-post-request-expected.txt.
* http/tests/app-privacy-report/app-attribution-post-request.html: Copied from LayoutTests/http/tests/app-privacy-report/attribution-post-request.html.
* http/tests/app-privacy-report/app-attribution-preflight-async-expected.txt: Copied from LayoutTests/http/tests/app-privacy-report/attribution-preflight-async-expected.txt.
* http/tests/app-privacy-report/app-attribution-preflight-async.html: Copied from LayoutTests/http/tests/app-privacy-report/attribution-preflight-async.html.
* http/tests/app-privacy-report/app-attribution-preflight-sync-expected.txt: Copied from LayoutTests/http/tests/app-privacy-report/attribution-preflight-sync-expected.txt.
* http/tests/app-privacy-report/app-attribution-preflight-sync.html: Copied from LayoutTests/http/tests/app-privacy-report/attribution-preflight-sync.html.
* http/tests/app-privacy-report/app-attribution-speculative-revalidation-expected.txt: Copied from LayoutTests/http/tests/app-privacy-report/attribution-speculative-revalidation-expected.txt.
* http/tests/app-privacy-report/app-attribution-speculative-revalidation.html: Copied from LayoutTests/http/tests/app-privacy-report/attribution-speculative-revalidation.html.
* http/tests/app-privacy-report/resources/app-initiated-post.py: Copied from LayoutTests/http/tests/app-privacy-report/resources/post.py.
* http/tests/app-privacy-report/resources/user-initiated-post.py: Renamed from LayoutTests/http/tests/app-privacy-report/resources/post.py.
* http/tests/app-privacy-report/user-attribution-load-url-expected.txt: Added.
* http/tests/app-privacy-report/user-attribution-load-url.html: Renamed from LayoutTests/http/tests/app-privacy-report/attribution-load-url.html.
* 

[webkit-changes] [279873] trunk/Source/WebCore

[commit-queue]

Title: [279873] trunk/Source/WebCore








Revision 279873
Author commit-qu...@webkit.org
Date 2021-07-13 09:33:26 -0700 (Tue, 13 Jul 2021)


Log Message
[GStreamer] Allow runtime opt-out of GL rendering
https://bugs.webkit.org/show_bug.cgi?id=227873

Patch by Philippe Normand  on 2021-07-13
Reviewed by Xabier Rodriguez-Calvar.

In some cases GL rendering is not really useful, such as on machines without GPU. In those
cases currently Mesa's llvmpipe is used, introducing CPU and RAM usage increase compared to
the non-gl rendering path. For these cases the user can set a new env var,
WEBKIT_GST_DISABLE_GL_SINK=1, allowing the player to use the Cairo sink.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createVideoSinkGL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (279872 => 279873)

--- trunk/Source/WebCore/ChangeLog	2021-07-13 14:19:38 UTC (rev 279872)
+++ trunk/Source/WebCore/ChangeLog	2021-07-13 16:33:26 UTC (rev 279873)
@@ -1,3 +1,18 @@
+2021-07-13  Philippe Normand  
+
+[GStreamer] Allow runtime opt-out of GL rendering
+https://bugs.webkit.org/show_bug.cgi?id=227873
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+In some cases GL rendering is not really useful, such as on machines without GPU. In those
+cases currently Mesa's llvmpipe is used, introducing CPU and RAM usage increase compared to
+the non-gl rendering path. For these cases the user can set a new env var,
+WEBKIT_GST_DISABLE_GL_SINK=1, allowing the player to use the Cairo sink.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::createVideoSinkGL):
+
 2021-07-13  Carlos Garcia Campos  
 
 [GTK][WPE] Expose support for client certificate auth


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (279872 => 279873)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2021-07-13 14:19:38 UTC (rev 279872)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2021-07-13 16:33:26 UTC (rev 279873)
@@ -3354,6 +3354,12 @@
 #if USE(GSTREAMER_GL)
 GstElement* MediaPlayerPrivateGStreamer::createVideoSinkGL()
 {
+const char* disableGLSink = g_getenv("WEBKIT_GST_DISABLE_GL_SINK");
+if (disableGLSink && equal(disableGLSink, "1")) {
+GST_INFO("Disabling hardware-accelerated rendering per user request.");
+return nullptr;
+}
+
 if (!webKitGLVideoSinkProbePlatform()) {
 g_warning("WebKit wasn't able to find the GL video sink dependencies. Hardware-accelerated zero-copy video rendering can't be enabled without this plugin.");
 return nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279872] trunk

[carlosgc]

Title: [279872] trunk








Revision 279872
Author carlo...@webkit.org
Date 2021-07-13 07:19:38 -0700 (Tue, 13 Jul 2021)


Log Message
[GTK][WPE] Expose support for client certificate auth
https://bugs.webkit.org/show_bug.cgi?id=200805

Reviewed by Michael Catanzaro.

.:

Bump libsoup3 required version.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Source/WebCore:

* platform/Soup.cmake:
* platform/SourcesSoup.txt:
* platform/network/Credential.h:
* platform/network/ProtectionSpaceBase.cpp:
(WebCore::ProtectionSpaceBase::isPasswordBased const):
* platform/network/ProtectionSpaceBase.h:
* platform/network/soup/AuthenticationChallenge.h:
* platform/network/soup/AuthenticationChallengeSoup.cpp:
(WebCore::protectionSpaceForClientCertificate):
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::protectionSpaceForClientCertificatePassword):
(WebCore::AuthenticationChallenge::platformCompare):
* platform/network/soup/CertificateInfoSoup.cpp:
(WebCore::CertificateInfo::isolatedCopy const):
* platform/network/soup/CredentialSoup.cpp: Added.
(WebCore::Credential::Credential):
(WebCore::m_certificate):
(WebCore::Credential::isEmpty const):
(WebCore::Credential::platformCompare):
* platform/network/soup/CredentialSoup.h: Added.
(WebCore::Credential::Credential):
(WebCore::Credential::encodingRequiresPlatformData const):
(WebCore::Credential::certificate const):
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::authTypeFromProtectionSpaceAuthenticationScheme):

Source/WebKit:

Add new API to handle certificate and pin certificate authentication requests.

* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::createRequest):
(WebKit::NetworkDataTaskSoup::completeAuthentication):
(WebKit::NetworkDataTaskSoup::cancelAuthentication):
(WebKit::NetworkDataTaskSoup::authenticate):
(WebKit::NetworkDataTaskSoup::continueAuthenticate):
(WebKit::NetworkDataTaskSoup::requestCertificateCallback):
(WebKit::NetworkDataTaskSoup::requestCertificatePasswordCallback):
* NetworkProcess/soup/NetworkDataTaskSoup.h:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/glib/ArgumentCodersGLib.cpp:
(IPC::ArgumentCoder>::encode):
(IPC::ArgumentCoder>::decode):
* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder::encodePlatformData):
(IPC::ArgumentCoder::decodePlatformData):
* UIProcess/API/glib/WebKitAuthenticationRequest.cpp:
(webkit_authentication_request_get_certificate_pin_flags):
* UIProcess/API/glib/WebKitCredential.cpp:
(webkit_credential_new_for_certificate_pin):
(webkit_credential_new_for_certificate):
(webkit_credential_get_certificate):
* UIProcess/API/gtk/WebKitAuthenticationRequest.h:
* UIProcess/API/gtk/WebKitCredential.h:
* UIProcess/API/gtk/WebKitWebViewGtk.cpp:
(webkitWebViewAuthenticate):
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
* UIProcess/API/wpe/WebKitAuthenticationRequest.h:
* UIProcess/API/wpe/WebKitCredential.h:
* UIProcess/API/wpe/docs/wpe-1.0-sections.txt:

Tools:

Add a simple implementation in MiniBrowser using a file chooser to ask for the certificate from a file and unit
tests for the client certificate request. Unfortunately we can't easily test pin certificates.

* MiniBrowser/gtk/BrowserTab.c:
(certificateDialogResponse):
(webViewAuthenticate):
(browserTabConstructed):
* TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
(ClientSideCertificateTest::acceptCertificateCallback):
(ClientSideCertificateTest::requestStartedCallback):
(ClientSideCertificateTest::authenticateCallback):
(ClientSideCertificateTest::ClientSideCertificateTest):
(ClientSideCertificateTest::~ClientSideCertificateTest):
(ClientSideCertificateTest::authenticate):
(ClientSideCertificateTest::acceptCertificate):
(ClientSideCertificateTest::waitForAuthenticationRequest):
(testClientSideCertificate):
(beforeAll):
* TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
* TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
(WebKitTestServer::soupServer const):

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Soup.cmake
trunk/Source/WebCore/platform/SourcesSoup.txt
trunk/Source/WebCore/platform/network/Credential.h
trunk/Source/WebCore/platform/network/ProtectionSpaceBase.cpp
trunk/Source/WebCore/platform/network/ProtectionSpaceBase.h
trunk/Source/WebCore/platform/network/soup/AuthenticationChallenge.h
trunk/Source/WebCore/platform/network/soup/AuthenticationChallengeSoup.cpp
trunk/Source/WebCore/platform/network/soup/CertificateInfoSoup.cpp
trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp
trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp

[webkit-changes] [279871] trunk/LayoutTests

[commit-queue]

Title: [279871] trunk/LayoutTests








Revision 279871
Author commit-qu...@webkit.org
Date 2021-07-13 05:54:02 -0700 (Tue, 13 Jul 2021)


Log Message
Unreviewed, reverting r279705.
https://bugs.webkit.org/show_bug.cgi?id=227903

Added a broken test

Reverted changeset:

"Only first set-cookie HTTP header in websocket http response
is accepted"
https://bugs.webkit.org/show_bug.cgi?id=227739
https://commits.webkit.org/r279705

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html
trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py




Diff

Modified: trunk/LayoutTests/ChangeLog (279870 => 279871)

--- trunk/LayoutTests/ChangeLog	2021-07-13 11:44:33 UTC (rev 279870)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 12:54:02 UTC (rev 279871)
@@ -1,3 +1,17 @@
+2021-07-13  Commit Queue  
+
+Unreviewed, reverting r279705.
+https://bugs.webkit.org/show_bug.cgi?id=227903
+
+Added a broken test
+
+Reverted changeset:
+
+"Only first set-cookie HTTP header in websocket http response
+is accepted"
+https://bugs.webkit.org/show_bug.cgi?id=227739
+https://commits.webkit.org/r279705
+
 2021-07-13  Arcady Goldmints-Orlov  
 
 [GLIB] Update baselines after r279673


Deleted: trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt (279870 => 279871)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt	2021-07-13 11:44:33 UTC (rev 279870)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt	2021-07-13 12:54:02 UTC (rev 279871)
@@ -1,2 +0,0 @@
-ALERT: a=b,c=d
-


Deleted: trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html (279870 => 279871)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html	2021-07-13 11:44:33 UTC (rev 279870)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple-set-cookies.html	2021-07-13 12:54:02 UTC (rev 279871)
@@ -1,27 +0,0 @@
-
-
-
-
-if (window.testRunner) {
-testRunner.waitUntilDone();
-testRunner.dumpAsText();
-}
-
-function runTest()
-{
-var ws = new WebSocket("ws://127.0.0.1:8880/websocket/tests/hybi/multiple_set_cookie");
-ws._onopen_ = function() {
-alert(document.cookie);
-if (window.testRunner) {
-testRunner.notifyDone();
-}
-}
-ws._onerror_ = function(error) {
-alert('error: ' + error);
-}
-}
-
-
-
-
-


Deleted: trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py (279870 => 279871)

--- trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py	2021-07-13 11:44:33 UTC (rev 279870)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/multiple_set_cookie_wsh.py	2021-07-13 12:54:02 UTC (rev 279871)
@@ -1,33 +0,0 @@
-#
-# Copyright (C) 2021 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-#notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-#notice, this list of conditions and the following disclaimer in the
-#documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
-# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
-# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-# THE POSSIBILITY OF SUCH DAMAGE.
-#
-
-
-def web_socket_do_extra_handshake(request):
-request.extra_headers.append(('Set-Cookie', 'a=b'))
-request.extra_headers.append(('Set-Cookie', 'c=d'))
-
-
-def web_socket_transfer_data(request):
-pass






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279870] trunk/LayoutTests

[commit-queue]

Title: [279870] trunk/LayoutTests








Revision 279870
Author commit-qu...@webkit.org
Date 2021-07-13 04:44:33 -0700 (Tue, 13 Jul 2021)


Log Message
[GLIB] Update baselines after r279673
https://bugs.webkit.org/show_bug.cgi?id=227886

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov  on 2021-07-13

* platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/wpe/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/wpe/fast/multicol/vertical-lr/nested-columns-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt
trunk/LayoutTests/platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt
trunk/LayoutTests/platform/wpe/fast/multicol/vertical-lr/float-multicol-expected.txt
trunk/LayoutTests/platform/wpe/fast/multicol/vertical-lr/nested-columns-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (279869 => 279870)

--- trunk/LayoutTests/ChangeLog	2021-07-13 08:17:26 UTC (rev 279869)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 11:44:33 UTC (rev 279870)
@@ -1,3 +1,15 @@
+2021-07-13  Arcady Goldmints-Orlov  
+
+[GLIB] Update baselines after r279673
+https://bugs.webkit.org/show_bug.cgi?id=227886
+
+Unreviewed test gardening.
+
+* platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt:
+* platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt:
+* platform/wpe/fast/multicol/vertical-lr/float-multicol-expected.txt:
+* platform/wpe/fast/multicol/vertical-lr/nested-columns-expected.txt:
+
 2021-07-13  Myles C. Maxfield  
 
 PUA characters have the wrong advance in the fast text codepath


Modified: trunk/LayoutTests/platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt (279869 => 279870)

--- trunk/LayoutTests/platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt	2021-07-13 08:17:26 UTC (rev 279869)
+++ trunk/LayoutTests/platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt	2021-07-13 11:44:33 UTC (rev 279870)
@@ -133,47 +133,47 @@
   text run at (18,330) width 33: "Bugs"
   RenderBlock {DD} at (52,40) size 467x439
 RenderBlock {P} at (0,0) size 467x439
-  RenderText {#text} at (0,290) size 321x147
+  RenderText {#text} at (0,290) size 322x147
 text run at (0,290) width 45: "You've"
 text run at (18,290) width 46: "already"
-text run at (196,290) width 129: "downloaded a build."
-text run at (214,290) width 132: "All you have to do is"
-text run at (232,290) width 37: "use it "
-text run at (232,327) width 17: "as "
-text run at (232,344) width 91: "your everyday"
-text run at (250,290) width 146: "browser and mail/news"
+text run at (196,290) width 130: "downloaded a build."
+text run at (214,290) width 133: "All you have to do is"
+text run at (232,290) width 38: "use it "
+text run at (232,327) width 18: "as "
+text run at (232,344) width 92: "your everyday"
+text run at (250,290) width 147: "browser and mail/news"
 text run at (268,290) width 85: "reader. If you"
-text run at (286,290) width 125: "downloaded a build"
-text run at (304,290) width 32: "with "
+text run at (286,290) width 126: "downloaded a build"
+text run at (304,290) width 33: "with "
 text run at (304,322) width 66: "Talkback, "
   RenderInline {EM} at (0,0) size 35x139
-RenderText {#text} at (304,388) size 35x139
-  text run at (304,388) width 40: "please"
-  text run at (322,290) width 58: "turn it on"
-  RenderText {#text} at (322,348) size 125x436
-text run at (322,348) width 86: " when it asks."
+RenderText {#text} at (304,388) size 36x139
+  text run at (304,388) width 41: "please"
+  text run at (322,290) width 59: "turn it on"
+  RenderText {#text} at (322,348) size 126x436
+text run at (322,348) width 87: " when it asks."
 text run at (340,208) width 140: "Talkback reports give "
-text run at (340,348) width 53: "us really"
-text run at (358,208) width 87: "valuable data "
-text run at (358,295) width 132: "on which crashes are"
-text run at (376,208) width 168: "the most serious, and how "
-text run at (376,376) width 32: "often"
-text run at (394,208) width 155: "people are encountering "
-text run at (394,363) width 67: "them. And"
-text run at (412,0) width 211: "all you have to do is click \"OK\". "
-text run at (412,211) width 225: "If you find something you think is a"
-  

[webkit-changes] [279869] trunk

[commit-queue]

Title: [279869] trunk








Revision 279869
Author commit-qu...@webkit.org
Date 2021-07-13 01:17:26 -0700 (Tue, 13 Jul 2021)


Log Message
RenderLayerScrollableArea::updateScrollPosition assumes that it can scroll to the targeted scroll position
https://bugs.webkit.org/show_bug.cgi?id=227803

Patch by Martin Robinson  on 2021-07-13
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt: Update test result to reflect newly passing test.

Source/WebCore:

No new tests. This is covered by an existing WPT test:
  - web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps.html

* rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::scrollToOffset): Modified this method to return the snapped
scroll offset.
(WebCore::RenderLayerScrollableArea::updateScrollPosition): Instead of using the original target offset,
use the return value from scrollToOffset to adjust the output rectangle.
* rendering/RenderLayerScrollableArea.h: Update the method definition.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279868 => 279869)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-13 07:52:36 UTC (rev 279868)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-07-13 08:17:26 UTC (rev 279869)
@@ -1,3 +1,12 @@
+2021-07-13  Martin Robinson  
+
+RenderLayerScrollableArea::updateScrollPosition assumes that it can scroll to the targeted scroll position
+https://bugs.webkit.org/show_bug.cgi?id=227803
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt: Update test result to reflect newly passing test.
+
 2021-07-12  Chris Dumez  
 
 Resync content-security-policy web-platform-tests from upstream


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt (279868 => 279869)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt	2021-07-13 07:52:36 UTC (rev 279868)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt	2021-07-13 08:17:26 UTC (rev 279869)
@@ -1,3 +1,3 @@
 
-FAIL All the scrollers affected by scrollIntoView should land on a snap position if one exists. Otherwise, land according to the specified alignment assert_equals: ScrollIntoView ends with the specified alignment if no snap position is specified. expected 1185 but got 1000
+PASS All the scrollers affected by scrollIntoView should land on a snap position if one exists. Otherwise, land according to the specified alignment
 


Modified: trunk/Source/WebCore/ChangeLog (279868 => 279869)

--- trunk/Source/WebCore/ChangeLog	2021-07-13 07:52:36 UTC (rev 279868)
+++ trunk/Source/WebCore/ChangeLog	2021-07-13 08:17:26 UTC (rev 279869)
@@ -1,3 +1,20 @@
+2021-07-13  Martin Robinson  
+
+RenderLayerScrollableArea::updateScrollPosition assumes that it can scroll to the targeted scroll position
+https://bugs.webkit.org/show_bug.cgi?id=227803
+
+Reviewed by Simon Fraser.
+
+No new tests. This is covered by an existing WPT test:
+  - web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps.html
+
+* rendering/RenderLayerScrollableArea.cpp:
+(WebCore::RenderLayerScrollableArea::scrollToOffset): Modified this method to return the snapped
+scroll offset.
+(WebCore::RenderLayerScrollableArea::updateScrollPosition): Instead of using the original target offset,
+use the return value from scrollToOffset to adjust the output rectangle.
+* rendering/RenderLayerScrollableArea.h: Update the method definition.
+
 2021-07-13  Myles C. Maxfield  
 
 PUA characters have the wrong advance in the fast text codepath


Modified: trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp (279868 => 279869)

--- trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp	2021-07-13 07:52:36 UTC (rev 279868)
+++ trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp	2021-07-13 08:17:26 UTC (rev 279869)
@@ -254,7 +254,7 @@
 return false;
 }
 
-void RenderLayerScrollableArea::scrollToOffset(const ScrollOffset& scrollOffset, const ScrollPositionChangeOptions& options)
+ScrollOffset RenderLayerScrollableArea::scrollToOffset(const ScrollOffset& scrollOffset, const ScrollPositionChangeOptions& options)
 {
 if (currentScrollBehaviorStatus() == ScrollBehaviorStatus::InNonNativeAnimation)
 scrollAnimator().cancelAnimations();
@@ -261,7 +261,7 @@
 
 

[webkit-changes] [279868] trunk

[mmaxfield]

Title: [279868] trunk








Revision 279868
Author mmaxfi...@apple.com
Date 2021-07-13 00:52:36 -0700 (Tue, 13 Jul 2021)


Log Message
PUA characters have the wrong advance in the fast text codepath
https://bugs.webkit.org/show_bug.cgi?id=227896


Reviewed by Tim Horton.

Source/WebCore:

There were 2 problems:
1. We were passing a UChar32 to this function:
   static bool treatAsSpace(UChar c) { return c == ' ' ... }
   This means that passing in U+10020 erroneously returns true
2. Because of https://bugs.webkit.org/show_bug.cgi?id=221356,
   if the prevous character is in SMP, our logic to determine
   the previous advance would erroneously return 0.

Test: fast/text/pua-charactersTreatedAsSpace.html

* platform/graphics/FontCascade.h:
(WebCore::FontCascade::treatAsSpace):
(WebCore::FontCascade::treatAsZeroWidthSpace):
(WebCore::FontCascade::treatAsZeroWidthSpaceInComplexScript):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):

LayoutTests:

* fast/text/pua-charactersTreatedAsSpace-expected.html: Added.
* fast/text/pua-charactersTreatedAsSpace.html: Added.
* fast/text/resources/Ahem-1A.ttf: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.h
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp


Added Paths

trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace-expected.html
trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace.html
trunk/LayoutTests/fast/text/resources/Ahem-1A.ttf




Diff

Modified: trunk/LayoutTests/ChangeLog (279867 => 279868)

--- trunk/LayoutTests/ChangeLog	2021-07-13 07:39:34 UTC (rev 279867)
+++ trunk/LayoutTests/ChangeLog	2021-07-13 07:52:36 UTC (rev 279868)
@@ -1,3 +1,15 @@
+2021-07-13  Myles C. Maxfield  
+
+PUA characters have the wrong advance in the fast text codepath
+https://bugs.webkit.org/show_bug.cgi?id=227896
+
+
+Reviewed by Tim Horton.
+
+* fast/text/pua-charactersTreatedAsSpace-expected.html: Added.
+* fast/text/pua-charactersTreatedAsSpace.html: Added.
+* fast/text/resources/Ahem-1A.ttf: Added.
+
 2021-07-12 Eric Hutchison 
 
 REGRESSION (r279806):[iOS Mac wk2 ] fast/canvas/canvas-path-addPath.html is a flaky timeout.


Added: trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace-expected.html (0 => 279868)

--- trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace-expected.html	2021-07-13 07:52:36 UTC (rev 279868)
@@ -0,0 +1,20 @@
+
+
+
+
+
+@font-face {
+font-family: "WebFont";
+src: url("resources/Ahem-1A.ttf") format("truetype");
+}
+div {
+font-family: "WebFont";
+}
+
+
+
+This test passes if you see a particular pattern of black boxes below.
+ab
+a a
+
+


Added: trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace.html (0 => 279868)

--- trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace.html	(rev 0)
+++ trunk/LayoutTests/fast/text/pua-charactersTreatedAsSpace.html	2021-07-13 07:52:36 UTC (rev 279868)
@@ -0,0 +1,20 @@
+
+
+
+
+
+@font-face {
+font-family: "WebFont";
+src: url("resources/Ahem-1A.ttf") format("truetype");
+}
+div {
+font-family: "WebFont";
+}
+
+
+
+This test passes if you see a particular pattern of black boxes below.
+􀀄􀀊
+􀀄a
+
+


Added: trunk/LayoutTests/fast/text/resources/Ahem-1A.ttf (0 => 279868)

--- trunk/LayoutTests/fast/text/resources/Ahem-1A.ttf	(rev 0)
+++ trunk/LayoutTests/fast/text/resources/Ahem-1A.ttf	2021-07-13 07:52:36 UTC (rev 279868)
@@ -0,0 +1,51 @@
+
\x800OS/2sf\xF9\xBC`cmapm\xAC\xC0
\x98gasp	\xB4glyf4a@\x86\xC4head\xDBP͵#\xD46hhea
+;$$hmtx(\xA6\xD5$0hloca\xD9\xCA\xD3(\x986maxp
	*\xD0 nameO\xE3F\xE0*\xF01\x9Apost	I\x94\\x8C\xAD\xD6
\x90\xBC\x8A\x8F\xBC\x8A
\xC52
\x80\xAF HW3C @ \xFF\xFF \xFF8 \xC8\xFF\xFC\xFF\xFF   
+\x84\x9F &(~

[webkit-changes] [279866] trunk/Source/WebCore

[mmaxfield]

Title: [279866] trunk/Source/WebCore








Revision 279866
Author mmaxfi...@apple.com
Date 2021-07-13 00:32:04 -0700 (Tue, 13 Jul 2021)


Log Message
Fix the Apple internal iOS Simulator build

Unreviewed.

* dom/Node.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (279865 => 279866)

--- trunk/Source/WebCore/ChangeLog	2021-07-13 07:12:03 UTC (rev 279865)
+++ trunk/Source/WebCore/ChangeLog	2021-07-13 07:32:04 UTC (rev 279866)
@@ -1,3 +1,11 @@
+2021-07-13  Myles C. Maxfield  
+
+Fix the Apple internal iOS Simulator build
+
+Unreviewed.
+
+* dom/Node.h:
+
 2021-07-12  Fujii Hironori  
 
 [curl] Can't finish loading some websites after r271946 started throttling low priority resources


Modified: trunk/Source/WebCore/dom/Node.h (279865 => 279866)

--- trunk/Source/WebCore/dom/Node.h	2021-07-13 07:12:03 UTC (rev 279865)
+++ trunk/Source/WebCore/dom/Node.h	2021-07-13 07:32:04 UTC (rev 279866)
@@ -923,7 +923,7 @@
 return is_gt(ordering) || is_eq(ordering);
 }
 
-WTF::TextStream& operator<<(WTF::TextStream&, const Node&);
+WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, const Node&);
 
 } // namespace WebCore
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [279865] trunk/Source/WebKit

[mmaxfield]

Title: [279865] trunk/Source/WebKit








Revision 279865
Author mmaxfi...@apple.com
Date 2021-07-13 00:12:03 -0700 (Tue, 13 Jul 2021)


Log Message
Fix the Apple Internal iOS build

Unreviewed.

* WebProcess/cocoa/WebProcessCocoa.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (279864 => 279865)

--- trunk/Source/WebKit/ChangeLog	2021-07-13 04:39:26 UTC (rev 279864)
+++ trunk/Source/WebKit/ChangeLog	2021-07-13 07:12:03 UTC (rev 279865)
@@ -1,3 +1,11 @@
+2021-07-13  Myles C. Maxfield  
+
+Fix the Apple Internal iOS build
+
+Unreviewed.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+
 2021-07-12  Tim Horton  
 
 Make WebKit's UserInterfaceIdiom operate in terms of the exceptions, not the rule


Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (279864 => 279865)

--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-07-13 04:39:26 UTC (rev 279864)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-07-13 07:12:03 UTC (rev 279865)
@@ -1167,7 +1167,7 @@
 }
 #endif
 
-#if PLATFORM(IOS_FAMILY)
+#if !(HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS) && ENABLE(CFPREFS_DIRECT_MODE)) && PLATFORM(IOS_FAMILY)
 static const WTF::String& increaseContrastPreferenceKey()
 {
 static NeverDestroyed key(MAKE_STATIC_STRING_IMPL("DarkenSystemColors"));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes