date:20210813

[webkit-changes] [281056] trunk/Source/WebKit

2021-08-13 Thread katherine_cheney

Title: [281056] trunk/Source/WebKit








Revision 281056
Author katherine_che...@apple.com
Date 2021-08-13 21:47:04 -0700 (Fri, 13 Aug 2021)


Log Message
Check quarantine bits before rendering local files
https://bugs.webkit.org/show_bug.cgi?id=229073


Reviewed by Brent Fulgham.

We shouldn't load files unless they have no quarantine flags or
have been marked user approved.

* Platform/spi/mac/QuarantineSPI.h:
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::isQuarantinedAndNotUserApproved):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadFile):
* UIProcess/WebPageProxy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/mac/QuarantineSPI.h
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (281055 => 281056)

--- trunk/Source/WebKit/ChangeLog	2021-08-14 02:28:19 UTC (rev 281055)
+++ trunk/Source/WebKit/ChangeLog	2021-08-14 04:47:04 UTC (rev 281056)
@@ -1,3 +1,21 @@
+2021-08-13  Kate Cheney  
+
+Check quarantine bits before rendering local files
+https://bugs.webkit.org/show_bug.cgi?id=229073
+
+
+Reviewed by Brent Fulgham.
+
+We shouldn't load files unless they have no quarantine flags or
+have been marked user approved.
+
+* Platform/spi/mac/QuarantineSPI.h:
+* UIProcess/Cocoa/WebPageProxyCocoa.mm:
+(WebKit::WebPageProxy::isQuarantinedAndNotUserApproved):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::loadFile):
+* UIProcess/WebPageProxy.h:
+
 2021-08-13  Chris Dumez  
 
 Add Cross-Origin-Embedder-Policy support for Blob URLs


Modified: trunk/Source/WebKit/Platform/spi/mac/QuarantineSPI.h (281055 => 281056)

--- trunk/Source/WebKit/Platform/spi/mac/QuarantineSPI.h	2021-08-14 02:28:19 UTC (rev 281055)
+++ trunk/Source/WebKit/Platform/spi/mac/QuarantineSPI.h	2021-08-14 04:47:04 UTC (rev 281056)
@@ -33,9 +33,14 @@
 
 #else
 
+enum qtn_error_code {
+QTN_NOT_QUARANTINED = -1,
+};
+
 enum qtn_flags {
 QTN_FLAG_DOWNLOAD = 0x0001,
 QTN_FLAG_SANDBOX = 0x0002,
+QTN_FLAG_USER_APPROVED = 0x0040,
 };
 
 #define qtn_proc_alloc _qtn_proc_alloc
@@ -49,6 +54,7 @@
 #define qtn_file_free _qtn_file_free
 #define qtn_file_apply_to_path _qtn_file_apply_to_path
 #define qtn_file_set_flags _qtn_file_set_flags
+#define qtn_file_get_flags _qtn_file_get_flags
 #endif
 
 typedef struct _qtn_proc *qtn_proc_t;
@@ -65,6 +71,7 @@
 qtn_file_t qtn_file_alloc(void);
 void qtn_file_free(qtn_file_t qf);
 int qtn_file_set_flags(qtn_file_t qf, uint32_t flags);
+uint32_t qtn_file_get_flags(qtn_file_t qf);
 int qtn_file_apply_to_path(qtn_file_t qf, const char *path);
 int qtn_file_init_with_path(qtn_file_t qf, const char *path);
 


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm (281055 => 281056)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm	2021-08-14 02:28:19 UTC (rev 281055)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm	2021-08-14 04:47:04 UTC (rev 281056)
@@ -35,6 +35,7 @@
 #import "InsertTextOptions.h"
 #import "LoadParameters.h"
 #import "PageClient.h"
+#import "QuarantineSPI.h"
 #import "QuickLookThumbnailLoader.h"
 #import "SafeBrowsingSPI.h"
 #import "SafeBrowsingWarning.h"
@@ -90,6 +91,8 @@
 #define MESSAGE_CHECK(assertion) MESSAGE_CHECK_BASE(assertion, process().connection())
 #define MESSAGE_CHECK_COMPLETION(assertion, completion) MESSAGE_CHECK_COMPLETION_BASE(assertion, process().connection(), completion)
 
+#define WEBPAGEPROXY_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageProxyID=%llu, webPageID=%llu, PID=%i] WebPageProxy::" fmt, this, m_identifier.toUInt64(), m_webPageID.toUInt64(), m_process->processIdentifier(), ##__VA_ARGS__)
+
 namespace WebKit {
 using namespace WebCore;
 
@@ -718,6 +721,34 @@
 return nil;
 }
 
+#if PLATFORM(MAC)
+bool WebPageProxy::isQuarantinedAndNotUserApproved(const String& fileURLString)
+{
+NSURL *fileURL = [NSURL URLWithString:fileURLString];
+qtn_file_t qf = qtn_file_alloc();
+
+int quarantineError = qtn_file_init_with_path(qf, fileURL.path.fileSystemRepresentation);
+
+if (quarantineError == ENOENT || quarantineError == QTN_NOT_QUARANTINED)
+return false;
+
+if (quarantineError) {
+// If we fail to check the quarantine status, assume the file is quarantined and not user approved to be safe.
+WEBPAGEPROXY_RELEASE_LOG(Loading, "isQuarantinedAndNotUserApproved: failed to initialize quarantine file with path.");
+qtn_file_free(qf);
+return true;
+}
+
+uint32_t fileflags = qtn_file_get_flags(qf);
+qtn_file_free(qf);
+
+if (fileflags & QTN_FLAG_USER_APPROVED)
+return false;
+
+return true;
+}
+#endif
+
 } // namespace WebKit
 
 #undef MESSAGE_CHECK_COMPLETION


Modified:

[webkit-changes] [281055] trunk

2021-08-13 Thread cdumez

Title: [281055] trunk








Revision 281055
Author cdu...@apple.com
Date 2021-08-13 19:28:19 -0700 (Fri, 13 Aug 2021)


Log Message
Add Cross-Origin-Embedder-Policy support for Blob URLs
https://bugs.webkit.org/show_bug.cgi?id=229041

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

* web-platform-tests/html/cross-origin-embedder-policy/blob.https-expected.txt:
* web-platform-tests/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https-expected.txt:
* web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https-expected.txt:

Source/WebCore:

Add Cross-Origin-Embedder-Policy (COEP) support for Blob URLs. We do the same thing as for COOP,
we pass the COEP policy when registering the Blob URL and store it in the BlobData. When we need
the construct a Blob resource response as a result of a load, we add the right COEP headers
based on the BlobData's COEP policy.

No new tests, rebaselined existing tests.

* Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::startLoadingBlobURL):
* fileapi/Blob.cpp:
(WebCore::BlobURLRegistry::registerURL):
(WebCore::Blob::Blob):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
* fileapi/ThreadableBlobRegistry.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
* loader/CrossOriginEmbedderPolicy.cpp:
(WebCore::addCrossOriginEmbedderPolicyHeaders):
* loader/CrossOriginEmbedderPolicy.h:
(WebCore::operator==):
* loader/CrossOriginOpenerPolicy.cpp:
(WebCore::addCrossOriginOpenerPolicyHeaders):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* platform/network/BlobData.h:
(WebCore::BlobData::crossOriginEmbedderPolicy const):
(WebCore::BlobData::setCrossOriginEmbedderPolicy):
* platform/network/BlobRegistry.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLOptionallyFileBacked):
* platform/network/BlobRegistryImpl.h:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):

Source/WebKit:

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLOptionallyFileBacked):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
* NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createBlobRegistry):
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
* WebProcess/FileAPI/BlobRegistryProxy.h:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebPlatformStrategies.mm:

Source/WebKitLegacy/win:

* WebCoreSupport/WebPlatformStrategies.cpp:

LayoutTests:

Update test expectations to unskip tests that are now passing.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https-expected.txt
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Modules/fetch/FetchLoader.cpp
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/dom/SecurityContext.cpp
trunk/Source/WebCore/dom/SecurityContext.h
trunk/Source/WebCore/fileapi/Blob.cpp
trunk/Source/WebCore/fileapi/FileReaderLoader.cpp
trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp
trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp
trunk/Source/WebCore/loader/CrossOriginEmbedderPolicy.h
trunk/Source/WebCore/loader/CrossOriginOpenerPolicy.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/platform/network/BlobData.cpp
trunk/Source/WebCore/platform/network/BlobData.h
trunk/Source/WebCore/platform/network/BlobRegistry.h
trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp
trunk/Source/WebCore/platform/network/BlobRegistryImpl.h
trunk/Source/WebCore/platform/network/BlobResourceHandle.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

[webkit-changes] [281054] trunk

2021-08-13 Thread wenson_hsieh

Title: [281054] trunk








Revision 281054
Author wenson_hs...@apple.com
Date 2021-08-13 17:47:03 -0700 (Fri, 13 Aug 2021)


Log Message
[iOS 15] fast/events/touch/ios/long-press-on-link.html is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=229095
rdar://80386326

Reviewed by Tim Horton.

Source/WebKit:

This test crashes when run immediately after another test that attempts to present the context menu and ends
with the context menu still showing (in this case, fast/events/touch/ios/long-press-on-image.html). Running
these tests back to back causes us to immediately dismiss the context menu interaction while transitioning to
the second test, which triggers the context menu interaction's dismissal animation.

This animation ends in the middle of the next test (long-press-on-link.html), after the long press has begun and
the context menu interaction has already requested a targeted hint preview, but (importantly) before the context
menu peek animation actually begins (i.e. `-contextMenuInteraction:willDisplayMenuForConfiguration:animator:`).
As a result, we tear down the hint container too early (with the hint view still in the view hierarchy), and
subsequently crash with an exception when UIKit tries to perform coordinate space conversions with the now-
unparented view.

To fix this, we make two small adjustments:
1.  Avoid unparenting the context menu hint container if it still has subviews.
2.  Add plumbing to ensure that the context menu hint container is unparented once all of its subviews have
been removed (and the container isn't being used for anything else).

* Platform/spi/ios/UIKitSPI.h:

Add an SPI declaration for the `-_didRemoveSubview:` subclassing hook.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKTargetedPreviewContainer initWithContentView:]):
(-[WKTargetedPreviewContainer _didRemoveSubview:]):

Add a new subclass for WKTargetedPreviewContainer that notifies WKContentView when its last subview has been
removed, such that WKContentView can tear down the container view if needed.

(-[WKContentView cleanUpInteraction]):
(-[WKContentView removeContextMenuViewIfPossibleForActionSheetAssistant:]):
(-[WKContentView _targetedPreviewContainerDidRemoveLastSubview:]):
(-[WKContentView _createPreviewContainerWithLayerName:]):
(-[WKContentView _removeContextMenuHintContainerIfPossible]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKContentView _removeContextMenuViewIfPossible]): Deleted.

Additionally rename `-_removeContextMenuViewIfPossible` to `-_removeContextMenuHintContainerIfPossible`, to make
it clear that this method is about removing the container view for context menu hints (and not the hints
themselves).

* UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsDropdown _removeContextMenuInteraction]):
* UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker removeContextMenuInteraction]):
* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel removeContextMenuInteraction]):
* UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker removeContextMenuInteraction]):

LayoutTests:

Remove the failing test expectation (and remove a passing expectation for iOS 14 which is no longer necessary
after this fix).

* platform/ios-14/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-14/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm
trunk/Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm
trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (281053 => 281054)

--- trunk/LayoutTests/ChangeLog	2021-08-14 00:35:33 UTC (rev 281053)
+++ trunk/LayoutTests/ChangeLog	2021-08-14 00:47:03 UTC (rev 281054)
@@ -1,3 +1,17 @@
+2021-08-13  Wenson Hsieh  
+
+[iOS 15] fast/events/touch/ios/long-press-on-link.html is a constant crash
+https://bugs.webkit.org/show_bug.cgi?id=229095
+rdar://80386326
+
+Reviewed by Tim Horton.
+
+Remove the failing test expectation (and remove a passing expectation for iOS 14 which is no longer necessary
+after this fix).
+
+* platform/ios-14/TestExpectations:
+* platform/ios/TestExpectations:
+
 2021-08-13  Ayumi Kojima  
 
 [ Win EWS ] http/tests/misc/webtiming-slow-load.py is failing.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (281053 => 281054)

--- trunk/LayoutTests/platform/ios/TestExpectations	2021-08-14 00:35:33 UTC (rev 281053)
+++

[webkit-changes] [281053] branches/safari-612.1.27.0-branch/Source

2021-08-13 Thread alancoon

Title: [281053] branches/safari-612.1.27.0-branch/Source








Revision 281053
Author alanc...@apple.com
Date 2021-08-13 17:35:33 -0700 (Fri, 13 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.27.0.23

Modified Paths

branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281052 => 281053)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-14 00:34:09 UTC (rev 281052)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-14 00:35:33 UTC (rev 281053)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 22;
+NANO_VERSION = 23;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281052 => 281053)

--- branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-14 00:34:09 UTC (rev 281052)
+++ branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-14 00:35:33 UTC (rev 281053)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 22;
+NANO_VERSION = 23;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281052 => 281053)

--- branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-14 00:34:09 UTC (rev 281052)
+++ branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-14 00:35:33 UTC (rev 281053)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 22;
+NANO_VERSION = 23;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig (281052 => 281053)

--- branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-14 00:34:09 UTC (rev 281052)
+++ branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-14 00:35:33 UTC (rev 281053)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 22;
+NANO_VERSION = 23;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281052 => 281053)

--- branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-14 00:34:09 UTC (rev 281052)
+++ branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-14 00:35:33 UTC (rev 281053)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 22;
+NANO_VERSION = 23;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281052 => 281053)

--- branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-14 00:34:09 UTC (rev 281052)
+++ branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-14 00:35:33 UTC (rev 281053)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 22;
+NANO_VERSION = 23;
 FULL_VERSION =

[webkit-changes] [281052] tags/Safari-612.1.27.0.22/

2021-08-13 Thread alancoon

Title: [281052] tags/Safari-612.1.27.0.22/








Revision 281052
Author alanc...@apple.com
Date 2021-08-13 17:34:09 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-612.1.27.0.22.

Added Paths

tags/Safari-612.1.27.0.22/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281051] tags/Safari-612.1.27.0.9/

2021-08-13 Thread alancoon

Title: [281051] tags/Safari-612.1.27.0.9/








Revision 281051
Author alanc...@apple.com
Date 2021-08-13 15:38:48 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-612.1.27.0.9.

Added Paths

tags/Safari-612.1.27.0.9/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281050] branches/safari-612.1.27.0.6-branch/Source

2021-08-13 Thread alancoon

Title: [281050] branches/safari-612.1.27.0.6-branch/Source








Revision 281050
Author alanc...@apple.com
Date 2021-08-13 15:34:26 -0700 (Fri, 13 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.27.0.9

Modified Paths

branches/safari-612.1.27.0.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.27.0.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.27.0.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.27.0.6-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.27.0.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.27.0.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.27.0.6-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.27.0.6-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.27.0.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281049 => 281050)

--- branches/safari-612.1.27.0.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 22:25:39 UTC (rev 281049)
+++ branches/safari-612.1.27.0.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 22:34:26 UTC (rev 281050)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281049 => 281050)

--- branches/safari-612.1.27.0.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 22:25:39 UTC (rev 281049)
+++ branches/safari-612.1.27.0.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 22:34:26 UTC (rev 281050)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281049 => 281050)

--- branches/safari-612.1.27.0.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 22:25:39 UTC (rev 281049)
+++ branches/safari-612.1.27.0.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 22:34:26 UTC (rev 281050)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0.6-branch/Source/WebCore/Configurations/Version.xcconfig (281049 => 281050)

--- branches/safari-612.1.27.0.6-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 22:25:39 UTC (rev 281049)
+++ branches/safari-612.1.27.0.6-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 22:34:26 UTC (rev 281050)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281049 => 281050)

--- branches/safari-612.1.27.0.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 22:25:39 UTC (rev 281049)
+++ branches/safari-612.1.27.0.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 22:34:26 UTC (rev 281050)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281049 => 281050)

--- branches/safari-612.1.27.0.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 22:25:39 UTC (rev 281049)
+++ branches/safari-612.1.27.0.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 22:34:26 UTC (rev 281050)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 8;
+NANO_VERSION = 9;

[webkit-changes] [281049] branches/safari-612.1.27.0-branch/Source/WebKit

2021-08-13 Thread alancoon

Title: [281049] branches/safari-612.1.27.0-branch/Source/WebKit








Revision 281049
Author alanc...@apple.com
Date 2021-08-13 15:25:39 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r281044. rdar://problem/81918718

[Cocoa] RemoteMediaPlayerProxy does not receive acceleratedRenderingStateChanged() when video element switches sources
https://bugs.webkit.org/show_bug.cgi?id=229092


Reviewed by Eric Carlson.

Follow up to r280723; in that patch, a call to acceleratedRenderingStateChanged() was added to
the MediaPlayerPrivateRemote, but only for non-Cocoa ports. Add the same method to the constructor
for the Cocoa version as well.

* WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog
branches/safari-612.1.27.0-branch/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm




Diff

Modified: branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog (281048 => 281049)

--- branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog	2021-08-13 22:23:15 UTC (rev 281048)
+++ branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog	2021-08-13 22:25:39 UTC (rev 281049)
@@ -1,3 +1,38 @@
+2021-08-13  Alan Coon  
+
+Cherry-pick r281044. rdar://problem/81918718
+
+[Cocoa] RemoteMediaPlayerProxy does not receive acceleratedRenderingStateChanged() when video element switches sources
+https://bugs.webkit.org/show_bug.cgi?id=229092
+
+
+Reviewed by Eric Carlson.
+
+Follow up to r280723; in that patch, a call to acceleratedRenderingStateChanged() was added to
+the MediaPlayerPrivateRemote, but only for non-Cocoa ports. Add the same method to the constructor
+for the Cocoa version as well.
+
+* WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
+(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-13  Jer Noble  
+
+[Cocoa] RemoteMediaPlayerProxy does not receive acceleratedRenderingStateChanged() when video element switches sources
+https://bugs.webkit.org/show_bug.cgi?id=229092
+
+
+Reviewed by Eric Carlson.
+
+Follow up to r280723; in that patch, a call to acceleratedRenderingStateChanged() was added to
+the MediaPlayerPrivateRemote, but only for non-Cocoa ports. Add the same method to the constructor
+for the Cocoa version as well.
+
+* WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
+(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
+
 2021-08-12  Alan Coon  
 
 Cherry-pick r280981. rdar://problem/81870941


Modified: branches/safari-612.1.27.0-branch/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm (281048 => 281049)

--- branches/safari-612.1.27.0-branch/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm	2021-08-13 22:23:15 UTC (rev 281048)
+++ branches/safari-612.1.27.0-branch/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm	2021-08-13 22:25:39 UTC (rev 281049)
@@ -53,6 +53,8 @@
 , m_id(playerIdentifier)
 {
 INFO_LOG(LOGIDENTIFIER);
+
+acceleratedRenderingStateChanged();
 }
 
 #if ENABLE(VIDEO_PRESENTATION_MODE)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281048] trunk/Source/WebCore

2021-08-13 Thread bfulgham

Title: [281048] trunk/Source/WebCore








Revision 281048
Author bfulg...@apple.com
Date 2021-08-13 15:23:15 -0700 (Fri, 13 Aug 2021)


Log Message
Unreviewed build fix after r281012
https://bugs.webkit.org/show_bug.cgi?id=228861

Add missing constructor signature when USE(CFURLCONNECTION) is true.


* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceErrorCF.cpp: Add missing constructor signature.
(WebCore::ResourceError::ResourceError):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceError.h
trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281047 => 281048)

--- trunk/Source/WebCore/ChangeLog	2021-08-13 22:18:20 UTC (rev 281047)
+++ trunk/Source/WebCore/ChangeLog	2021-08-13 22:23:15 UTC (rev 281048)
@@ -1,3 +1,14 @@
+2021-08-13  Brent Fulgham  
+
+Unreviewed build fix after r281012
+https://bugs.webkit.org/show_bug.cgi?id=228861
+
+Add missing constructor signature when USE(CFURLCONNECTION) is true.
+
+* platform/network/cf/ResourceError.h:
+* platform/network/cf/ResourceErrorCF.cpp: Add missing constructor signature.
+(WebCore::ResourceError::ResourceError):
+
 2021-08-13  Alex Christensen  
 
 Unreviewed, reverting r281009.


Modified: trunk/Source/WebCore/platform/network/cf/ResourceError.h (281047 => 281048)

--- trunk/Source/WebCore/platform/network/cf/ResourceError.h	2021-08-13 22:18:20 UTC (rev 281047)
+++ trunk/Source/WebCore/platform/network/cf/ResourceError.h	2021-08-13 22:23:15 UTC (rev 281048)
@@ -66,7 +66,7 @@
 WEBCORE_EXPORT operator CFErrorRef() const;
 
 #if USE(CFURLCONNECTION)
-ResourceError(const String& domain, int errorCode, const URL& failingURL, const String& localizedDescription, CFDataRef certificate);
+ResourceError(const String& domain, int errorCode, const URL& failingURL, const String& localizedDescription, CFDataRef certificate, IsSanitized = IsSanitized::No);
 PCCERT_CONTEXT certificate() const;
 void setCertificate(CFDataRef);
 ResourceError(CFStreamError error);


Modified: trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp (281047 => 281048)

--- trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp	2021-08-13 22:18:20 UTC (rev 281047)
+++ trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp	2021-08-13 22:23:15 UTC (rev 281048)
@@ -45,8 +45,8 @@
 setType((CFErrorGetCode(m_platformError.get()) == kCFURLErrorTimedOut) ? Type::Timeout : Type::General);
 }
 
-ResourceError::ResourceError(const String& domain, int errorCode, const URL& failingURL, const String& localizedDescription, CFDataRef certificate)
-: ResourceErrorBase(domain, errorCode, failingURL, localizedDescription, Type::General)
+ResourceError::ResourceError(const String& domain, int errorCode, const URL& failingURL, const String& localizedDescription, CFDataRef certificate, IsSanitized isSanitized)
+: ResourceErrorBase(domain, errorCode, failingURL, localizedDescription, Type::General, isSanitized)
 , m_dataIsUpToDate(true)
 , m_certificate(certificate)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281047] tags/Safari-612.1.27.2.3/

2021-08-13 Thread alancoon

Title: [281047] tags/Safari-612.1.27.2.3/








Revision 281047
Author alanc...@apple.com
Date 2021-08-13 15:18:20 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-612.1.27.2.3.

Added Paths

tags/Safari-612.1.27.2.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281046] branches/safari-612.1.27.2-branch/Source/JavaScriptCore

2021-08-13 Thread alancoon

Title: [281046] branches/safari-612.1.27.2-branch/Source/_javascript_Core








Revision 281046
Author alanc...@apple.com
Date 2021-08-13 15:14:54 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r280996. rdar://problem/81901248

Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054

Reviewed by Keith Miller and Robin Morisset.

This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.

Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
that there are no diffs in the generated code from this change.

* assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h




Diff

Modified: branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog (281045 => 281046)

--- branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:14:51 UTC (rev 281045)
+++ branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:14:54 UTC (rev 281046)
@@ -1,5 +1,53 @@
 2021-08-13  Russell Epstein  
 
+Cherry-pick r280996. rdar://problem/81901248
+
+Refactor some ARM64EHash code.
+https://bugs.webkit.org/show_bug.cgi?id=229054
+
+Reviewed by Keith Miller and Robin Morisset.
+
+This patch only refactors ARM64EHash code by moving some methods into the private
+section, and removing some unneeded static_casts.
+
+Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
+that there are no diffs in the generated code from this change.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-12  Mark Lam  
+
+Refactor some ARM64EHash code.
+https://bugs.webkit.org/show_bug.cgi?id=229054
+
+Reviewed by Keith Miller and Robin Morisset.
+
+This patch only refactors ARM64EHash code by moving some methods into the private
+section, and removing some unneeded static_casts.
+
+Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
+that there are no diffs in the generated code from this change.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+
+2021-08-13  Russell Epstein  
+
 Cherry-pick r280984. rdar://problem/81901248
 
 Update ARM64EHash


Modified: branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h (281045 => 281046)

--- branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:14:51 UTC (rev 281045)
+++ branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:14:54 UTC (rev 281046)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -205,12 +205,27 @@
 #if CPU(ARM64E)
 class ARM64EHash {
 public:
+ARM64EHash(void* diversifier)
+{
+setUpdatedHash(0, 0, diversifier);
+}
+
+ALWAYS_INLINE uint32_t update(uint32_t instruction, uint32_t index, void* diversifier)
+{
+uint32_t currentHash = this->currentHash(index, diversifier);
+uint64_t nextIndex = index + 1;
+uint32_t output = nextValue(instruction, nextIndex, currentHash);
+setUpdatedHash(output, nextIndex, diversifier);
+return output;
+}
+
+private:
 static constexpr uint8_t initializationNamespace = 0x11;
 
 static ALWAYS_INLINE PtrTag makeDiversifier(uint8_t namespaceTag, uint64_t index, uint32_t value)
 {
 // 
-return static_cast((static_cast(namespaceTag) << 56) + ((index &

[webkit-changes] [281045] branches/safari-612.1.27.2-branch/Source/JavaScriptCore

2021-08-13 Thread alancoon

Title: [281045] branches/safari-612.1.27.2-branch/Source/_javascript_Core








Revision 281045
Author alanc...@apple.com
Date 2021-08-13 15:14:51 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r280984. rdar://problem/81901248

Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962


Reviewed by Mark Lam.

* assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):
(JSC::ARM64EHash::setUpdatedHash):
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::finalize):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::hash const):
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h
branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/LinkBuffer.cpp




Diff

Modified: branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog (281044 => 281045)

--- branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:14:28 UTC (rev 281044)
+++ branches/safari-612.1.27.2-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:14:51 UTC (rev 281045)
@@ -1,3 +1,54 @@
+2021-08-13  Russell Epstein  
+
+Cherry-pick r280984. rdar://problem/81901248
+
+Update ARM64EHash
+https://bugs.webkit.org/show_bug.cgi?id=228962
+
+
+Reviewed by Mark Lam.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+(JSC::ARM64EHash::setUpdatedHash):
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::finalize):
+(JSC::AssemblerBuffer::AssemblerBuffer):
+(JSC::AssemblerBuffer::putIntegralUnchecked):
+(JSC::AssemblerBuffer::hash const):
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-12  Saam Barati  
+
+Update ARM64EHash
+https://bugs.webkit.org/show_bug.cgi?id=228962
+
+
+Reviewed by Mark Lam.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+(JSC::ARM64EHash::setUpdatedHash):
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::finalize):
+(JSC::AssemblerBuffer::AssemblerBuffer):
+(JSC::AssemblerBuffer::putIntegralUnchecked):
+(JSC::AssemblerBuffer::hash const):
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+
 2021-08-02  Yijia Huang  
 
 Add new patterns to instruction selector to utilize AND/EOR/ORR-with-shift supported by ARM64


Modified: branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h (281044 => 281045)

--- branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:14:28 UTC (rev 281044)
+++ branches/safari-612.1.27.2-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:14:51 UTC (rev 281045)
@@ -205,22 +205,62 @@
 #if CPU(ARM64E)
 class ARM64EHash {
 public:
-ARM64EHash(uint32_t initialHash)
-: m_hash(initialHash)
+static constexpr uint8_t initializationNamespace = 0x11;
+
+static ALWAYS_INLINE PtrTag makeDiversifier(uint8_t namespaceTag, uint64_t index, uint32_t value)
 {
+// 
+return static_cast((static_cast(namespaceTag) << 56) + ((index & 0xFF) << 32) + static_cast(value));
 }
 
-ALWAYS_INLINE uint32_t update(uint32_t value)
+static ALWAYS_INLINE uint32_t nextValue(uint64_t instruction, uint64_t index, uint32_t currentValue)
 {
-uint64_t input = value ^ m_hash;
-uint64_t a = static_cast(tagInt(input, static_cast(0)) >> 39);
-uint64_t b = tagInt(input, static_cast(0xb7e151628aed2a6a)) >> 23;
-m_hash = a ^ b;
-return m_hash;
+uint64_t a = tagInt(instruction, makeDiversifier(0x12, index, currentValue));
+uint64_t b = tagInt(instruction, makeDiversifier(0x13, index, currentValue));
+return static_cast((a >> 39) ^ (b >> 23));
 }
 
+

[webkit-changes] [281044] trunk/Source/WebKit

2021-08-13 Thread jer . noble

Title: [281044] trunk/Source/WebKit








Revision 281044
Author jer.no...@apple.com
Date 2021-08-13 15:14:28 -0700 (Fri, 13 Aug 2021)


Log Message
[Cocoa] RemoteMediaPlayerProxy does not receive acceleratedRenderingStateChanged() when video element switches sources
https://bugs.webkit.org/show_bug.cgi?id=229092


Reviewed by Eric Carlson.

Follow up to r280723; in that patch, a call to acceleratedRenderingStateChanged() was added to
the MediaPlayerPrivateRemote, but only for non-Cocoa ports. Add the same method to the constructor
for the Cocoa version as well.

* WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (281043 => 281044)

--- trunk/Source/WebKit/ChangeLog	2021-08-13 22:13:19 UTC (rev 281043)
+++ trunk/Source/WebKit/ChangeLog	2021-08-13 22:14:28 UTC (rev 281044)
@@ -1,3 +1,18 @@
+2021-08-13  Jer Noble  
+
+[Cocoa] RemoteMediaPlayerProxy does not receive acceleratedRenderingStateChanged() when video element switches sources
+https://bugs.webkit.org/show_bug.cgi?id=229092
+
+
+Reviewed by Eric Carlson.
+
+Follow up to r280723; in that patch, a call to acceleratedRenderingStateChanged() was added to
+the MediaPlayerPrivateRemote, but only for non-Cocoa ports. Add the same method to the constructor
+for the Cocoa version as well.
+
+* WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
+(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
+
 2021-08-13  Alex Christensen  
 
 SandboxExtension::Handle creation should return std::optional instead of bool


Modified: trunk/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm (281043 => 281044)

--- trunk/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm	2021-08-13 22:13:19 UTC (rev 281043)
+++ trunk/Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm	2021-08-13 22:14:28 UTC (rev 281044)
@@ -53,6 +53,8 @@
 , m_id(playerIdentifier)
 {
 INFO_LOG(LOGIDENTIFIER);
+
+acceleratedRenderingStateChanged();
 }
 
 #if ENABLE(VIDEO_PRESENTATION_MODE)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281043] branches/safari-612.1.27.2-branch/Source

2021-08-13 Thread alancoon

Title: [281043] branches/safari-612.1.27.2-branch/Source








Revision 281043
Author alanc...@apple.com
Date 2021-08-13 15:13:19 -0700 (Fri, 13 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.27.2.3

Modified Paths

branches/safari-612.1.27.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.27.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.27.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.27.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.27.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.27.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.27.2-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.27.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.27.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281042 => 281043)

--- branches/safari-612.1.27.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 22:09:51 UTC (rev 281042)
+++ branches/safari-612.1.27.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 22:13:19 UTC (rev 281043)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281042 => 281043)

--- branches/safari-612.1.27.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 22:09:51 UTC (rev 281042)
+++ branches/safari-612.1.27.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 22:13:19 UTC (rev 281043)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281042 => 281043)

--- branches/safari-612.1.27.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 22:09:51 UTC (rev 281042)
+++ branches/safari-612.1.27.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 22:13:19 UTC (rev 281043)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.2-branch/Source/WebCore/Configurations/Version.xcconfig (281042 => 281043)

--- branches/safari-612.1.27.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 22:09:51 UTC (rev 281042)
+++ branches/safari-612.1.27.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 22:13:19 UTC (rev 281043)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281042 => 281043)

--- branches/safari-612.1.27.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 22:09:51 UTC (rev 281042)
+++ branches/safari-612.1.27.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 22:13:19 UTC (rev 281043)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281042 => 281043)

--- branches/safari-612.1.27.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 22:09:51 UTC (rev 281042)
+++ branches/safari-612.1.27.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 22:13:19 UTC (rev 281043)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION =

[webkit-changes] [281042] tags/Safari-612.1.27.3.4/

2021-08-13 Thread alancoon

Title: [281042] tags/Safari-612.1.27.3.4/








Revision 281042
Author alanc...@apple.com
Date 2021-08-13 15:09:51 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-612.1.27.3.4.

Added Paths

tags/Safari-612.1.27.3.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281041] branches/safari-612.1.27.3-branch/Source/JavaScriptCore

2021-08-13 Thread alancoon

Title: [281041] branches/safari-612.1.27.3-branch/Source/_javascript_Core








Revision 281041
Author alanc...@apple.com
Date 2021-08-13 15:08:46 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r280996. rdar://problem/81901248

Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054

Reviewed by Keith Miller and Robin Morisset.

This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.

Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
that there are no diffs in the generated code from this change.

* assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h




Diff

Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog (281040 => 281041)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:08:43 UTC (rev 281040)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:08:46 UTC (rev 281041)
@@ -1,5 +1,53 @@
 2021-08-13  Alan Coon  
 
+Cherry-pick r280996. rdar://problem/81901248
+
+Refactor some ARM64EHash code.
+https://bugs.webkit.org/show_bug.cgi?id=229054
+
+Reviewed by Keith Miller and Robin Morisset.
+
+This patch only refactors ARM64EHash code by moving some methods into the private
+section, and removing some unneeded static_casts.
+
+Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
+that there are no diffs in the generated code from this change.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-12  Mark Lam  
+
+Refactor some ARM64EHash code.
+https://bugs.webkit.org/show_bug.cgi?id=229054
+
+Reviewed by Keith Miller and Robin Morisset.
+
+This patch only refactors ARM64EHash code by moving some methods into the private
+section, and removing some unneeded static_casts.
+
+Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
+that there are no diffs in the generated code from this change.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+
+2021-08-13  Alan Coon  
+
 Cherry-pick r280984. rdar://problem/81901248
 
 Update ARM64EHash


Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h (281040 => 281041)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:08:43 UTC (rev 281040)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:08:46 UTC (rev 281041)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -205,12 +205,27 @@
 #if CPU(ARM64E)
 class ARM64EHash {
 public:
+ARM64EHash(void* diversifier)
+{
+setUpdatedHash(0, 0, diversifier);
+}
+
+ALWAYS_INLINE uint32_t update(uint32_t instruction, uint32_t index, void* diversifier)
+{
+uint32_t currentHash = this->currentHash(index, diversifier);
+uint64_t nextIndex = index + 1;
+uint32_t output = nextValue(instruction, nextIndex, currentHash);
+setUpdatedHash(output, nextIndex, diversifier);
+return output;
+}
+
+private:
 static constexpr uint8_t initializationNamespace = 0x11;
 
 static ALWAYS_INLINE PtrTag makeDiversifier(uint8_t namespaceTag, uint64_t index, uint32_t value)
 {
 // 
-return static_cast((static_cast(namespaceTag) << 56) + ((index & 0xFF) << 32) +

[webkit-changes] [281040] branches/safari-612.1.27.3-branch/Source/JavaScriptCore

2021-08-13 Thread alancoon

Title: [281040] branches/safari-612.1.27.3-branch/Source/_javascript_Core








Revision 281040
Author alanc...@apple.com
Date 2021-08-13 15:08:43 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r280984. rdar://problem/81901248

Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962


Reviewed by Mark Lam.

* assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):
(JSC::ARM64EHash::setUpdatedHash):
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::finalize):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::hash const):
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h
branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/LinkBuffer.cpp




Diff

Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog (281039 => 281040)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:05:15 UTC (rev 281039)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-13 22:08:43 UTC (rev 281040)
@@ -1,3 +1,54 @@
+2021-08-13  Alan Coon  
+
+Cherry-pick r280984. rdar://problem/81901248
+
+Update ARM64EHash
+https://bugs.webkit.org/show_bug.cgi?id=228962
+
+
+Reviewed by Mark Lam.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+(JSC::ARM64EHash::setUpdatedHash):
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::finalize):
+(JSC::AssemblerBuffer::AssemblerBuffer):
+(JSC::AssemblerBuffer::putIntegralUnchecked):
+(JSC::AssemblerBuffer::hash const):
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-12  Saam Barati  
+
+Update ARM64EHash
+https://bugs.webkit.org/show_bug.cgi?id=228962
+
+
+Reviewed by Mark Lam.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+(JSC::ARM64EHash::setUpdatedHash):
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::finalize):
+(JSC::AssemblerBuffer::AssemblerBuffer):
+(JSC::AssemblerBuffer::putIntegralUnchecked):
+(JSC::AssemblerBuffer::hash const):
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+
 2021-08-05  Russell Epstein  
 
 Cherry-pick r280659. rdar://problem/81592180


Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h (281039 => 281040)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:05:15 UTC (rev 281039)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 22:08:43 UTC (rev 281040)
@@ -205,22 +205,62 @@
 #if CPU(ARM64E)
 class ARM64EHash {
 public:
-ARM64EHash(uint32_t initialHash)
-: m_hash(initialHash)
+static constexpr uint8_t initializationNamespace = 0x11;
+
+static ALWAYS_INLINE PtrTag makeDiversifier(uint8_t namespaceTag, uint64_t index, uint32_t value)
 {
+// 
+return static_cast((static_cast(namespaceTag) << 56) + ((index & 0xFF) << 32) + static_cast(value));
 }
 
-ALWAYS_INLINE uint32_t update(uint32_t value)
+static ALWAYS_INLINE uint32_t nextValue(uint64_t instruction, uint64_t index, uint32_t currentValue)
 {
-uint64_t input = value ^ m_hash;
-uint64_t a = static_cast(tagInt(input, static_cast(0)) >> 39);
-uint64_t b = tagInt(input, static_cast(0xb7e151628aed2a6a)) >> 23;
-m_hash = a ^ b;
-return m_hash;
+uint64_t a = tagInt(instruction, makeDiversifier(0x12, index, currentValue));
+uint64_t b = tagInt(instruction, makeDiversifier(0x13, index, currentValue));
+return static_cast((a >> 39) ^ (b >> 23));
 }
 
+static ALWAYS_INLINE uint32_t

[webkit-changes] [281039] branches/safari-612.1.27.3-branch/Source

2021-08-13 Thread alancoon

Title: [281039] branches/safari-612.1.27.3-branch/Source








Revision 281039
Author alanc...@apple.com
Date 2021-08-13 15:05:15 -0700 (Fri, 13 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.27.3.4

Modified Paths

branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281038 => 281039)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 22:04:37 UTC (rev 281038)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 22:05:15 UTC (rev 281039)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281038 => 281039)

--- branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 22:04:37 UTC (rev 281038)
+++ branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 22:05:15 UTC (rev 281039)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281038 => 281039)

--- branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 22:04:37 UTC (rev 281038)
+++ branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 22:05:15 UTC (rev 281039)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig (281038 => 281039)

--- branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 22:04:37 UTC (rev 281038)
+++ branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 22:05:15 UTC (rev 281039)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281038 => 281039)

--- branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 22:04:37 UTC (rev 281038)
+++ branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 22:05:15 UTC (rev 281039)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281038 => 281039)

--- branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 22:04:37 UTC (rev 281038)
+++ branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 22:05:15 UTC (rev 281039)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 3;
+NANO_VERSION = 4;
 FULL_VERSION =

[webkit-changes] [281038] trunk/LayoutTests

2021-08-13 Thread ayumi_kojima

Title: [281038] trunk/LayoutTests








Revision 281038
Author ayumi_koj...@apple.com
Date 2021-08-13 15:04:37 -0700 (Fri, 13 Aug 2021)


Log Message
[ Win EWS ] http/tests/misc/webtiming-slow-load.py is failing.
https://bugs.webkit.org/show_bug.cgi?id=229099

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281037 => 281038)

--- trunk/LayoutTests/ChangeLog	2021-08-13 22:03:21 UTC (rev 281037)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 22:04:37 UTC (rev 281038)
@@ -1,5 +1,14 @@
 2021-08-13  Ayumi Kojima  
 
+[ Win EWS ] http/tests/misc/webtiming-slow-load.py is failing.
+https://bugs.webkit.org/show_bug.cgi?id=229099
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
+2021-08-13  Ayumi Kojima  
+
 [ Win EWS ] fast/forms/caps-lock-indicator-width.html is crashing.
 https://bugs.webkit.org/show_bug.cgi?id=229098
 


Modified: trunk/LayoutTests/platform/win/TestExpectations (281037 => 281038)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-08-13 22:03:21 UTC (rev 281037)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-08-13 22:04:37 UTC (rev 281038)
@@ -267,6 +267,8 @@
 # TODO Accept header is handled by the browser
 http/tests/misc/image-checks-for-accept.html [ Skip ]
 
+webkit.org/b/229099 http/tests/misc/webtiming-slow-load.py [ Failure ] 
+
 # Need to implement AccessibilityUIElement::clearSelectedChildren()
 accessibility/aria-listbox-clear-selection-crash.html [ Skip ]
 accessibility/listbox-clear-selection.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281037] tags/Safari-612.1.28.1/

2021-08-13 Thread alancoon

Title: [281037] tags/Safari-612.1.28.1/








Revision 281037
Author alanc...@apple.com
Date 2021-08-13 15:03:21 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-612.1.28.1.

Added Paths

tags/Safari-612.1.28.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281036] trunk/LayoutTests

2021-08-13 Thread ayumi_kojima

Title: [281036] trunk/LayoutTests








Revision 281036
Author ayumi_koj...@apple.com
Date 2021-08-13 14:42:42 -0700 (Fri, 13 Aug 2021)


Log Message
[ Win EWS ] fast/forms/caps-lock-indicator-width.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=229098

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281035 => 281036)

--- trunk/LayoutTests/ChangeLog	2021-08-13 21:22:09 UTC (rev 281035)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 21:42:42 UTC (rev 281036)
@@ -1,3 +1,12 @@
+2021-08-13  Ayumi Kojima  
+
+[ Win EWS ] fast/forms/caps-lock-indicator-width.html is crashing.
+https://bugs.webkit.org/show_bug.cgi?id=229098
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2021-08-13  Youenn Fablet  
 
 Use profile auto level for WebRTC H264 encoder on Apple Silicon


Modified: trunk/LayoutTests/platform/win/TestExpectations (281035 => 281036)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-08-13 21:22:09 UTC (rev 281035)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-08-13 21:42:42 UTC (rev 281036)
@@ -3782,6 +3782,8 @@
 webkit.org/b/177378 fast/forms/listbox-typeahead-cyrillic.html [ Failure ]
 webkit.org/b/177385 fast/forms/listbox-typeahead-greek.html [ Failure ]
 
+webkit.org/b/177385 fast/forms/caps-lock-indicator-width.html [ Crash ]
+
 webkit.org/b/177541 accessibility/image-load-on-delay.html [ Failure ]
 
 # preconnect tests are failing on Windows.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281035] branches/safari-612.1.28-branch/Source

2021-08-13 Thread alancoon

Title: [281035] branches/safari-612.1.28-branch/Source








Revision 281035
Author alanc...@apple.com
Date 2021-08-13 14:22:09 -0700 (Fri, 13 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.28.1

Modified Paths

branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281034 => 281035)

--- branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 21:03:02 UTC (rev 281034)
+++ branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 21:22:09 UTC (rev 281035)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281034 => 281035)

--- branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 21:03:02 UTC (rev 281034)
+++ branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 21:22:09 UTC (rev 281035)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281034 => 281035)

--- branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 21:03:02 UTC (rev 281034)
+++ branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 21:22:09 UTC (rev 281035)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig (281034 => 281035)

--- branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 21:03:02 UTC (rev 281034)
+++ branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 21:22:09 UTC (rev 281035)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281034 => 281035)

--- branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 21:03:02 UTC (rev 281034)
+++ branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 21:22:09 UTC (rev 281035)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.

[webkit-changes] [281034] tags/Safari-612.1.28/

2021-08-13 Thread alancoon

Title: [281034] tags/Safari-612.1.28/








Revision 281034
Author alanc...@apple.com
Date 2021-08-13 14:03:02 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-612.1.28.

Added Paths

tags/Safari-612.1.28/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281033] tags/Safari-612.1.28/

2021-08-13 Thread alancoon

Title: [281033] tags/Safari-612.1.28/








Revision 281033
Author alanc...@apple.com
Date 2021-08-13 14:02:55 -0700 (Fri, 13 Aug 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-612.1.28/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281032] trunk/Source/WebKit

2021-08-13 Thread commit-queue

Title: [281032] trunk/Source/WebKit








Revision 281032
Author commit-qu...@webkit.org
Date 2021-08-13 13:53:03 -0700 (Fri, 13 Aug 2021)


Log Message
SandboxExtension::Handle creation should return std::optional instead of bool
https://bugs.webkit.org/show_bug.cgi?id=228875

Patch by Alex Christensen  on 2021-08-13
Reviewed by Youenn Fablet.

This modernizes the code somewhat.
This makes it easier to write code that realizes that handle creation can fail.
This is a step towards removing the unnecessary abstraction HandleArray.

* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
* Platform/IPC/FormDataReference.h:
(IPC::FormDataReference::encode const):
* Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandle):
(WebKit::createHandlesForResources):
(WebKit::SandboxExtension::createReadOnlyHandlesForFiles):
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
(WebKit::SandboxExtension::createHandleForTemporaryFile):
(WebKit::SandboxExtension::createHandleForGenericExtension):
(WebKit::SandboxExtension::createHandleForMachLookup):
(WebKit::SandboxExtension::createHandlesForMachLookup):
(WebKit::SandboxExtension::createHandleForReadByAuditToken):
(WebKit::SandboxExtension::createHandleForIOKitClassExtension):
(WebKit::SandboxExtension::createHandlesForIOKitClassExtensions):
* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::createHandle):
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
(WebKit::SandboxExtension::createHandleForTemporaryFile):
(WebKit::SandboxExtension::createHandleForGenericExtension):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::addPlatformLoadParameters):
(WebKit::WebPageProxy::createSandboxExtensionsIfNeeded): Deleted.
(WebKit::WebPageProxy::scrollingUpdatesDisabledForTesting): Deleted.
(WebKit::WebPageProxy::startDrag): Deleted.
(WebKit::WebPageProxy::setPromisedDataForImage): Deleted.
(WebKit::WebPageProxy::setDragCaretRect): Deleted.
(WebKit::WebPageProxy::platformRegisterAttachment): Deleted.
(WebKit::WebPageProxy::platformCloneAttachment): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection): Deleted.
(WebKit::WebPageProxy::insertDictatedTextAsync): Deleted.
(WebKit::WebPageProxy::platformDictationAlternatives): Deleted.
(WebKit::WebPageProxy::errorForUnpermittedAppBoundDomainNavigation): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorConnection): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorBoundInterfaceIdentifier): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorSourceApplicationBundleIdentifier): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorSourceApplicationSecondaryIdentifier): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorAddMessageReceiver): Deleted.
(WebKit::WebPageProxy::paymentCoordinatorRemoveMessageReceiver): Deleted.
(WebKit::WebPageProxy::didStartSpeaking): Deleted.
(WebKit::WebPageProxy::didFinishSpeaking): Deleted.
(WebKit::WebPageProxy::didPauseSpeaking): Deleted.
(WebKit::WebPageProxy::didResumeSpeaking): Deleted.
(WebKit::WebPageProxy::speakingErrorOccurred): Deleted.
(WebKit::WebPageProxy::boundaryEventOccurred): Deleted.
(WebKit::WebPageProxy::voicesDidChange): Deleted.
(WebKit::WebPageProxy::didCreateContextInWebProcessForVisibilityPropagation): Deleted.
(WebKit::WebPageProxy::didCreateContextInGPUProcessForVisibilityPropagation): Deleted.
(WebKit::WebPageProxy::grantAccessToPreferenceService): Deleted.
(WebKit::WebPageProxy::mediaUsageManager): Deleted.
(WebKit::WebPageProxy::addMediaUsageManagerSession): Deleted.
(WebKit::WebPageProxy::updateMediaUsageManagerSessionState): Deleted.
(WebKit::WebPageProxy::removeMediaUsageManagerSession): Deleted.
(WebKit::convertPlatformImageToBitmap): Deleted.
(WebKit::WebPageProxy::requestThumbnailWithOperation): Deleted.
(WebKit::WebPageProxy::requestThumbnailWithFileWrapper): Deleted.
(WebKit::WebPageProxy::requestThumbnailWithPath): Deleted.
(WebKit::WebPageProxy::scheduleActivityStateUpdate): Deleted.
(WebKit::WebPageProxy::addActivityStateUpdateCompletionHandler): Deleted.
(WebKit::WebPageProxy::createAppHighlightInSelectedRange): Deleted.
(WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex): Deleted.
(WebKit::WebPageProxy::setAppHighlightsVisibility): Deleted.
(WebKit::WebPageProxy::appHighlightsVisibility): Deleted.
(WebKit::WebPageProxy::appHighlightsOverlayRect): Deleted.
(WebKit::WebPageProxy::setUpHighlightsObserver): Deleted.
(WebKit::WebPageProxy::createNetworkExtensionsSandboxExtensions): Deleted.
(WebKit::WebPageProxy::canHandleContextMenuTranslation const): Deleted.
(WebKit::WebPageProxy::handleContextMenuTranslation): Deleted.
(WebKit::WebPageProxy::requestActiveNowPlayingSessionInfo): Deleted.

[webkit-changes] [281031] branches/safari-612.1.27.0-branch/Tools

2021-08-13 Thread alancoon

Title: [281031] branches/safari-612.1.27.0-branch/Tools








Revision 281031
Author alanc...@apple.com
Date 2021-08-13 13:14:07 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r281023. rdar://problem/81868773

[webkitscmpy] Fix SVN relative URL parsing
https://bugs.webkit.org/show_bug.cgi?id=229075


Reviewed by Aakash Jain.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn.branch): Check if relative URL path contains local path before stripping local path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/Tools/ChangeLog
branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/setup.py
branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py




Diff

Modified: branches/safari-612.1.27.0-branch/Tools/ChangeLog (281030 => 281031)

--- branches/safari-612.1.27.0-branch/Tools/ChangeLog	2021-08-13 19:30:44 UTC (rev 281030)
+++ branches/safari-612.1.27.0-branch/Tools/ChangeLog	2021-08-13 20:14:07 UTC (rev 281031)
@@ -1,3 +1,33 @@
+2021-08-13  Alan Coon  
+
+Cherry-pick r281023. rdar://problem/81868773
+
+[webkitscmpy] Fix SVN relative URL parsing
+https://bugs.webkit.org/show_bug.cgi?id=229075
+
+
+Reviewed by Aakash Jain.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
+(Svn.branch): Check if relative URL path contains local path before stripping local path.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-13  Jonathan Bedard  
+
+[webkitscmpy] Fix SVN relative URL parsing
+https://bugs.webkit.org/show_bug.cgi?id=229075
+
+
+Reviewed by Aakash Jain.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
+(Svn.branch): Check if relative URL path contains local path before stripping local path.
+
 2021-08-02  Peng Liu  
 
 [GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize


Modified: branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/setup.py (281030 => 281031)

--- branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-13 19:30:44 UTC (rev 281030)
+++ branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-13 20:14:07 UTC (rev 281031)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='1.0.4',
+version='1.1.2',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (281030 => 281031)

--- branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-13 19:30:44 UTC (rev 281030)
+++ branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-13 20:14:07 UTC (rev 281031)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(1, 0, 4)
+version = Version(1, 1, 2)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('monotonic', Version(1, 5)))


Modified: branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py (281030 => 281031)

--- branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py	2021-08-13 19:30:44 UTC (rev 281030)
+++ branches/safari-612.1.27.0-branch/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py	2021-08-13 20:14:07 UTC (rev 281031)
@@ -264,9 +264,10 @@
 @property
 def branch(self):
 local_path = self.path[len(self.root_path):]
-if local_path:
-return self.info()['Relative URL'][2:-len(local_path)]
-return self.info()['Relative URL'][2:]
+relative_url = self.info()['Relative URL']
+if local_path and relative_url.endswith(local_path):
+return relative_url[2:-len(local_path)]
+return relative_url[2:]
 
 def list(self, category):
 list_result = run([self.executable(), 'list', '^/{}'.format(category)], cwd=self.root_path, capture_output=True, encoding='utf-8')

[webkit-changes] [281030] trunk

2021-08-13 Thread youenn

Title: [281030] trunk








Revision 281030
Author you...@apple.com
Date 2021-08-13 12:30:44 -0700 (Fri, 13 Aug 2021)


Log Message
Use profile auto level for WebRTC H264 encoder on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=229071


Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

AS H264 encoder will fail if its profile is too low compared to the size of the video.
Use autolevel to prevent this.
* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

LayoutTests:

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (281029 => 281030)

--- trunk/LayoutTests/ChangeLog	2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 19:30:44 UTC (rev 281030)
@@ -1,3 +1,13 @@
+2021-08-13  Youenn Fablet  
+
+Use profile auto level for WebRTC H264 encoder on Apple Silicon
+https://bugs.webkit.org/show_bug.cgi?id=229071
+
+
+Reviewed by Eric Carlson.
+
+* platform/mac/TestExpectations:
+
 2021-08-13  Alex Christensen  
 
 Unreviewed, reverting r281009.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (281029 => 281030)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-08-13 19:30:44 UTC (rev 281030)
@@ -2121,7 +2121,6 @@
 [ arm64 ] webrtc/video.html [ Pass Timeout ]
 [ arm64 ] webrtc/video-with-data-channel.html [ Pass Timeout ]
 [ arm64 ] webrtc/video-unmute.html [ Pass Timeout ]
-[ arm64 ] webrtc/h264-high.html [ Skip ]
 [ arm64 ] webrtc/vp9-profile2.html [ Skip ]
 [ arm64 ] webrtc/captureCanvas-webrtc-software-h264-high.html [ Pass Failure ]
 [ arm64 ] webrtc/h264-baseline.html  [ Failure Timeout ]


Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (281029 => 281030)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2021-08-13 19:30:44 UTC (rev 281030)
@@ -1,3 +1,15 @@
+2021-08-13  Youenn Fablet  
+
+Use profile auto level for WebRTC H264 encoder on Apple Silicon
+https://bugs.webkit.org/show_bug.cgi?id=229071
+
+
+Reviewed by Eric Carlson.
+
+AS H264 encoder will fail if its profile is too low compared to the size of the video.
+Use autolevel to prevent this.
+* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+
 2021-07-01  Youenn Fablet  
 
 Disable ABSL_HAVE_THREAD_LOCAL in libwebrtc


Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (281029 => 281030)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2021-08-13 19:30:44 UTC (rev 281030)
@@ -260,6 +260,7 @@
 
 case webrtc::H264::kProfileConstrainedHigh:
 case webrtc::H264::kProfileHigh:
+#if !defined(WEBRTC_ARCH_ARM64)
   switch (profile_level_id.level) {
 case webrtc::H264::kLevel3:
   return kVTProfileLevel_H264_High_3_0;
@@ -289,6 +290,9 @@
 case webrtc::H264::kLevel2_2:
   return kVTProfileLevel_H264_High_AutoLevel;
   }
+#else
+  return kVTProfileLevel_H264_High_AutoLevel;
+#endif
   }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281029] trunk

2021-08-13 Thread keith_miller

Title: [281029] trunk








Revision 281029
Author keith_mil...@apple.com
Date 2021-08-13 12:29:04 -0700 (Fri, 13 Aug 2021)


Log Message
EnumeratorNextUpdatePropertyName always needs to be able to handle IndexedMode
https://bugs.webkit.org/show_bug.cgi?id=229087

Reviewed by Filip Pizlo.

JSTests:

* stress/for-in-own-structure-and-generic-with-late-add-indexed.js: Added.
(test):
(Foo):

Source/_javascript_Core:

Right now, this operation incorrectly assumes that EnumeratorNextUpdateIndexAndMode will guarantee
the mode matches the seen mode set. But no speculation is guaranteed and adding such a guarantee
would require adding checkpoints, which is likely not worth it. Instead, this patch just makes
sure we always handle the allocation for IndexedMode.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileEnumeratorNextUpdatePropertyName):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp


Added Paths

trunk/JSTests/stress/for-in-own-structure-and-generic-with-late-add-indexed.js




Diff

Modified: trunk/JSTests/ChangeLog (281028 => 281029)

--- trunk/JSTests/ChangeLog	2021-08-13 19:10:25 UTC (rev 281028)
+++ trunk/JSTests/ChangeLog	2021-08-13 19:29:04 UTC (rev 281029)
@@ -1,3 +1,14 @@
+2021-08-13  Keith Miller  
+
+EnumeratorNextUpdatePropertyName always needs to be able to handle IndexedMode
+https://bugs.webkit.org/show_bug.cgi?id=229087
+
+Reviewed by Filip Pizlo.
+
+* stress/for-in-own-structure-and-generic-with-late-add-indexed.js: Added.
+(test):
+(Foo):
+
 2021-08-11  Yusuke Suzuki  
 
 WTFCrash in JSC::Lexer::append8


Added: trunk/JSTests/stress/for-in-own-structure-and-generic-with-late-add-indexed.js (0 => 281029)

--- trunk/JSTests/stress/for-in-own-structure-and-generic-with-late-add-indexed.js	(rev 0)
+++ trunk/JSTests/stress/for-in-own-structure-and-generic-with-late-add-indexed.js	2021-08-13 19:29:04 UTC (rev 281029)
@@ -0,0 +1,28 @@
+function test(o) {
+let sum = 0;
+for (let i in o)
+sum += o[i];
+return sum;
+}
+noInline(test);
+
+Object.defineProperty(Object.prototype, "foo", { enumerable: true, value: 4 });
+
+class Foo extends Array {
+b = 1;
+}
+
+let object = new Foo();
+let object2 = new Foo();
+object2.length = 100;
+object2.fill(1);
+
+for (let i = 0; i < 1e5; ++i) {
+let sum = test(object);
+if (sum !== 5)
+throw new Error(sum);
+}
+
+let sum = test(object2);
+if (sum !== 105)
+throw new Error(sum);


Modified: trunk/Source/_javascript_Core/ChangeLog (281028 => 281029)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-13 19:10:25 UTC (rev 281028)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-13 19:29:04 UTC (rev 281029)
@@ -1,3 +1,20 @@
+2021-08-13  Keith Miller  
+
+EnumeratorNextUpdatePropertyName always needs to be able to handle IndexedMode
+https://bugs.webkit.org/show_bug.cgi?id=229087
+
+Reviewed by Filip Pizlo.
+
+Right now, this operation incorrectly assumes that EnumeratorNextUpdateIndexAndMode will guarantee
+the mode matches the seen mode set. But no speculation is guaranteed and adding such a guarantee
+would require adding checkpoints, which is likely not worth it. Instead, this patch just makes
+sure we always handle the allocation for IndexedMode.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileEnumeratorNextUpdatePropertyName):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
+
 2021-08-12  Mark Lam  
 
 Refactor some ARM64EHash code.


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (281028 => 281029)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2021-08-13 19:10:25 UTC (rev 281028)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2021-08-13 19:29:04 UTC (rev 281029)
@@ -13591,17 +13591,13 @@
 MacroAssembler::JumpList doneCases;
 MacroAssembler::Jump operationCall;
 
-bool needsOperation = seenModes.contains(JSPropertyNameEnumerator::IndexedMode);
+// Make sure we flush on all code paths if we will call the operation.
+// Note: we can't omit the operation because we are not guaranteed EnumeratorUpdateIndexAndMode will speculate on the mode.
+flushRegisters();
 
-// Make sure we flush on all code paths if we could call the operation.
-if (needsOperation)
-flushRegisters();
-
 if (seenModes.containsAny({ JSPropertyNameEnumerator::OwnStructureMode, JSPropertyNameEnumerator::GenericMode })) {
+operationCall = m_jit.branchTest32(MacroAssembler::NonZero, mode, TrustedImm32(JSPropertyNameEnumerator::IndexedMode));
 
-if (needsOperation)
-

[webkit-changes] [281028] tags/Safari-611.4.0.1/

2021-08-13 Thread alancoon

Title: [281028] tags/Safari-611.4.0.1/








Revision 281028
Author alanc...@apple.com
Date 2021-08-13 12:10:25 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-611.4.0.1.

Added Paths

tags/Safari-611.4.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281027] tags/Safari-611.4.0.1/

2021-08-13 Thread alancoon

Title: [281027] tags/Safari-611.4.0.1/








Revision 281027
Author alanc...@apple.com
Date 2021-08-13 12:10:19 -0700 (Fri, 13 Aug 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-611.4.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281025] trunk

2021-08-13 Thread achristensen

Title: [281025] trunk








Revision 281025
Author achristen...@apple.com
Date 2021-08-13 11:58:23 -0700 (Fri, 13 Aug 2021)


Log Message
Unreviewed, reverting r281009.

Timing not quite right

Reverted changeset:

"Unprefix -webkit-backface-visibility"
https://bugs.webkit.org/show_bug.cgi?id=170983
https://commits.webkit.org/r281009

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/backface-visibility-computed-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/backface-visibility-valid-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/ios/svg/css/getComputedStyle-basic-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/mac/svg/css/getComputedStyle-basic-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp


Removed Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281024 => 281025)

--- trunk/LayoutTests/ChangeLog	2021-08-13 18:39:11 UTC (rev 281024)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 18:58:23 UTC (rev 281025)
@@ -1,3 +1,15 @@
+2021-08-13  Alex Christensen  
+
+Unreviewed, reverting r281009.
+
+Timing not quite right
+
+Reverted changeset:
+
+"Unprefix -webkit-backface-visibility"
+https://bugs.webkit.org/show_bug.cgi?id=170983
+https://commits.webkit.org/r281009
+
 2021-08-13  Ayumi Kojima  
 
 [ BigSur Debug wk2 EWS ] webrtc/video-interruption.html is flaky crashing.


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281024 => 281025)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-13 18:39:11 UTC (rev 281024)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-13 18:58:23 UTC (rev 281025)
@@ -1,3 +1,15 @@
+2021-08-13  Alex Christensen  
+
+Unreviewed, reverting r281009.
+
+Timing not quite right
+
+Reverted changeset:
+
+"Unprefix -webkit-backface-visibility"
+https://bugs.webkit.org/show_bug.cgi?id=170983
+https://commits.webkit.org/r281009
+
 2021-08-13  Youenn Fablet  
 
 Overly verbose catchable fetch error messages lead to cross-origin leaks


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (281024 => 281025)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2021-08-13 18:39:11 UTC (rev 281024)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2021-08-13 18:58:23 UTC (rev 281025)
@@ -17,7 +17,6 @@
 PASS animation-play-state
 PASS animation-timing-function
 PASS aspect-ratio
-PASS backface-visibility
 PASS background-attachment
 PASS background-blend-mode
 PASS background-clip
@@ -315,6 +314,7 @@
 PASS -apple-trailing-word
 PASS -webkit-appearance
 PASS -webkit-backdrop-filter
+PASS -webkit-backface-visibility
 PASS -webkit-background-clip
 PASS -webkit-background-composite
 PASS -webkit-background-origin


Deleted: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence-expected.txt (281024 => 281025)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence-expected.txt	2021-08-13 18:39:11 UTC (rev 281024)
+++

[webkit-changes] [281026] branches/safari-611.3.10.0-branch/Source/WebCore

2021-08-13 Thread alancoon

Title: [281026] branches/safari-611.3.10.0-branch/Source/WebCore








Revision 281026
Author alanc...@apple.com
Date 2021-08-13 11:58:37 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r278729. rdar://problem/80310242

Fix incorrect check in AudioNode.disconnect()
https://bugs.webkit.org/show_bug.cgi?id=226818


Reviewed by Eric Carlson.

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::disconnect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog
branches/safari-611.3.10.0-branch/Source/WebCore/Modules/webaudio/AudioNode.cpp




Diff

Modified: branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog (281025 => 281026)

--- branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog	2021-08-13 18:58:23 UTC (rev 281025)
+++ branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog	2021-08-13 18:58:37 UTC (rev 281026)
@@ -1,3 +1,30 @@
+2021-08-13  Russell Epstein  
+
+Cherry-pick r278729. rdar://problem/80310242
+
+Fix incorrect check in AudioNode.disconnect()
+https://bugs.webkit.org/show_bug.cgi?id=226818
+
+
+Reviewed by Eric Carlson.
+
+* Modules/webaudio/AudioNode.cpp:
+(WebCore::AudioNode::disconnect):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-10  Chris Dumez  
+
+Fix incorrect check in AudioNode.disconnect()
+https://bugs.webkit.org/show_bug.cgi?id=226818
+
+
+Reviewed by Eric Carlson.
+
+* Modules/webaudio/AudioNode.cpp:
+(WebCore::AudioNode::disconnect):
+
 2021-08-10  Russell Epstein  
 
 Apply patch. rdar://problem/79924198


Modified: branches/safari-611.3.10.0-branch/Source/WebCore/Modules/webaudio/AudioNode.cpp (281025 => 281026)

--- branches/safari-611.3.10.0-branch/Source/WebCore/Modules/webaudio/AudioNode.cpp	2021-08-13 18:58:23 UTC (rev 281025)
+++ branches/safari-611.3.10.0-branch/Source/WebCore/Modules/webaudio/AudioNode.cpp	2021-08-13 18:58:37 UTC (rev 281026)
@@ -312,7 +312,7 @@
 if (outputIndex >= numberOfOutputs())
 return Exception { IndexSizeError, "output index is out of bounds"_s };
 
-if (outputIndex >= destinationNode.numberOfInputs())
+if (inputIndex >= destinationNode.numberOfInputs())
 return Exception { IndexSizeError, "input index is out of bounds"_s };
 
 auto* output = this->output(outputIndex);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281024] tags/Safari-611.4.0.1/

2021-08-13 Thread alancoon

Title: [281024] tags/Safari-611.4.0.1/








Revision 281024
Author alanc...@apple.com
Date 2021-08-13 11:39:11 -0700 (Fri, 13 Aug 2021)


Log Message
Tag Safari-611.4.0.1.

Added Paths

tags/Safari-611.4.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281023] trunk/Tools

2021-08-13 Thread jbedard

Title: [281023] trunk/Tools








Revision 281023
Author jbed...@apple.com
Date 2021-08-13 10:24:16 -0700 (Fri, 13 Aug 2021)


Log Message
[webkitscmpy] Fix SVN relative URL parsing
https://bugs.webkit.org/show_bug.cgi?id=229075


Reviewed by Aakash Jain.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn.branch): Check if relative URL path contains local path before stripping local path.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py




Diff

Modified: trunk/Tools/ChangeLog (281022 => 281023)

--- trunk/Tools/ChangeLog	2021-08-13 16:50:38 UTC (rev 281022)
+++ trunk/Tools/ChangeLog	2021-08-13 17:24:16 UTC (rev 281023)
@@ -1,3 +1,16 @@
+2021-08-13  Jonathan Bedard  
+
+[webkitscmpy] Fix SVN relative URL parsing
+https://bugs.webkit.org/show_bug.cgi?id=229075
+
+
+Reviewed by Aakash Jain.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
+(Svn.branch): Check if relative URL path contains local path before stripping local path. 
+
 2021-08-13  Lauro Moura  
 
 [WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (281022 => 281023)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-13 16:50:38 UTC (rev 281022)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-13 17:24:16 UTC (rev 281023)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='1.1.1',
+version='1.1.2',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (281022 => 281023)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-13 16:50:38 UTC (rev 281022)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-13 17:24:16 UTC (rev 281023)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(1, 1, 1)
+version = Version(1, 1, 2)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('monotonic', Version(1, 5)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py (281022 => 281023)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py	2021-08-13 16:50:38 UTC (rev 281022)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py	2021-08-13 17:24:16 UTC (rev 281023)
@@ -264,9 +264,10 @@
 @property
 def branch(self):
 local_path = self.path[len(self.root_path):]
-if local_path:
-return self.info()['Relative URL'][2:-len(local_path)]
-return self.info()['Relative URL'][2:]
+relative_url = self.info()['Relative URL']
+if local_path and relative_url.endswith(local_path):
+return relative_url[2:-len(local_path)]
+return relative_url[2:]
 
 def list(self, category):
 list_result = run([self.executable(), 'list', '^/{}'.format(category)], cwd=self.root_path, capture_output=True, encoding='utf-8')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281021] trunk/LayoutTests

2021-08-13 Thread ayumi_kojima

Title: [281021] trunk/LayoutTests








Revision 281021
Author ayumi_koj...@apple.com
Date 2021-08-13 09:39:44 -0700 (Fri, 13 Aug 2021)


Log Message
[ BigSur Debug wk2 EWS ] webrtc/video-interruption.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=229076

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281020 => 281021)

--- trunk/LayoutTests/ChangeLog	2021-08-13 15:57:32 UTC (rev 281020)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 16:39:44 UTC (rev 281021)
@@ -1,5 +1,14 @@
 2021-08-13  Ayumi Kojima  
 
+[ BigSur Debug wk2 EWS ] webrtc/video-interruption.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=229076
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2021-08-13  Ayumi Kojima  
+
 REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows.
 https://bugs.webkit.org/show_bug.cgi?id=228325.
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (281020 => 281021)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-13 15:57:32 UTC (rev 281020)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-13 16:39:44 UTC (rev 281021)
@@ -1099,6 +1099,8 @@
 
 webkit.org/b/213652 webrtc/video-autoplay1.html [ Pass Failure ]
 
+webkit.org/b/229076 [ BigSur Debug ] webrtc/video-interruption.html [ Pass Crash ]
+
 webkit.org/b/214084 webrtc/libwebrtc/descriptionGetters.html [ Pass Failure ]
 
 webkit.org/b/214286 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-connectionState.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281020] trunk/LayoutTests

2021-08-13 Thread ayumi_kojima

Title: [281020] trunk/LayoutTests








Revision 281020
Author ayumi_koj...@apple.com
Date 2021-08-13 08:57:32 -0700 (Fri, 13 Aug 2021)


Log Message
REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows.
https://bugs.webkit.org/show_bug.cgi?id=228325.

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281019 => 281020)

--- trunk/LayoutTests/ChangeLog	2021-08-13 15:38:40 UTC (rev 281019)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 15:57:32 UTC (rev 281020)
@@ -1,3 +1,12 @@
+2021-08-13  Ayumi Kojima  
+
+REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows.
+https://bugs.webkit.org/show_bug.cgi?id=228325.
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2021-08-13  Youenn Fablet  
 
 Overly verbose catchable fetch error messages lead to cross-origin leaks


Modified: trunk/LayoutTests/platform/win/TestExpectations (281019 => 281020)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-08-13 15:38:40 UTC (rev 281019)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-08-13 15:57:32 UTC (rev 281020)
@@ -3774,6 +3774,8 @@
 
 webkit.org/b/177216 fast/images/animated-image-mp4.html [ Skip ]
 
+webkit.org/b/228325 fast/images/exif-orientation-composited.html [ Pass ImageOnlyFailure ]
+
 webkit.org/b/177234 http/wpt/resource-timing/rt-cors.html [ Skip ]
 webkit.org/b/177234 http/wpt/resource-timing/rt-cors.worker.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281019] branches/safari-612.1.28-branch/Source/WebCore

2021-08-13 Thread alancoon

Title: [281019] branches/safari-612.1.28-branch/Source/WebCore








Revision 281019
Author alanc...@apple.com
Date 2021-08-13 08:38:40 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r281008. rdar://problem/81901037

Fix bounds checks for WhitespaceCache string lengths
https://bugs.webkit.org/show_bug.cgi?id=229066


Reviewed by Simon Fraser.

When the whitespace string length is maximumWhitespaceStringLength,
we read from and write to one element past the end of m_codes and
m_indexes. Since we don't need to store codes and indexes for zero
length strings, subtract one from the index we use.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::WhitespaceCache::lookup):
* html/parser/HTMLConstructionSite.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.28-branch/Source/WebCore/ChangeLog
branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp
branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.h




Diff

Modified: branches/safari-612.1.28-branch/Source/WebCore/ChangeLog (281018 => 281019)

--- branches/safari-612.1.28-branch/Source/WebCore/ChangeLog	2021-08-13 15:30:09 UTC (rev 281018)
+++ branches/safari-612.1.28-branch/Source/WebCore/ChangeLog	2021-08-13 15:38:40 UTC (rev 281019)
@@ -1,3 +1,42 @@
+2021-08-13  Alan Coon  
+
+Cherry-pick r281008. rdar://problem/81901037
+
+Fix bounds checks for WhitespaceCache string lengths
+https://bugs.webkit.org/show_bug.cgi?id=229066
+
+
+Reviewed by Simon Fraser.
+
+When the whitespace string length is maximumWhitespaceStringLength,
+we read from and write to one element past the end of m_codes and
+m_indexes. Since we don't need to store codes and indexes for zero
+length strings, subtract one from the index we use.
+
+* html/parser/HTMLConstructionSite.cpp:
+(WebCore::WhitespaceCache::lookup):
+* html/parser/HTMLConstructionSite.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-12  Cameron McCormack  
+
+Fix bounds checks for WhitespaceCache string lengths
+https://bugs.webkit.org/show_bug.cgi?id=229066
+
+
+Reviewed by Simon Fraser.
+
+When the whitespace string length is maximumWhitespaceStringLength,
+we read from and write to one element past the end of m_codes and
+m_indexes. Since we don't need to store codes and indexes for zero
+length strings, subtract one from the index we use.
+
+* html/parser/HTMLConstructionSite.cpp:
+(WebCore::WhitespaceCache::lookup):
+* html/parser/HTMLConstructionSite.h:
+
 2021-08-12  Youenn Fablet  
 
 Implement SFrameTransform error handling


Modified: branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp (281018 => 281019)

--- branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2021-08-13 15:30:09 UTC (rev 281018)
+++ branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2021-08-13 15:38:40 UTC (rev 281019)
@@ -891,24 +891,25 @@
 if (!code)
 return AtomString();
 
-if (m_codes[length] == code) {
-ASSERT(m_atoms[m_indexes[length]] == string);
-return m_atoms[m_indexes[length]];
+size_t lengthIndex = length - 1;
+if (m_codes[lengthIndex] == code) {
+ASSERT(m_atoms[m_indexes[lengthIndex]] == string);
+return m_atoms[m_indexes[lengthIndex]];
 }
 
 if (code == overflowWhitespaceCode)
 return AtomString(string);
 
-if (m_codes[length]) {
+if (m_codes[lengthIndex]) {
 AtomString whitespaceAtom(string);
-m_codes[length] = code;
-m_atoms[m_indexes[length]] = whitespaceAtom;
+m_codes[lengthIndex] = code;
+m_atoms[m_indexes[lengthIndex]] = whitespaceAtom;
 return whitespaceAtom;
 }
 
 AtomString whitespaceAtom(string);
-m_codes[length] = code;
-m_indexes[length] = m_atoms.size();
+m_codes[lengthIndex] = code;
+m_indexes[lengthIndex] = m_atoms.size();
 m_atoms.append(whitespaceAtom);
 return whitespaceAtom;
 }


Modified: branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.h (281018 => 281019)

--- branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.h	2021-08-13 15:30:09 UTC (rev 281018)
+++ branches/safari-612.1.28-branch/Source/WebCore/html/parser/HTMLConstructionSite.h	2021-08-13 15:38:40 UTC (rev 281019)
@@ -238,7 +238,9 @@
 constexpr static size_t maximumCachedStringLength = 128;
 
 // Parallel arrays storing a 64 bit code and an index into m_atoms for the
-// most recently atomized whitespace-only string of a given length.
+//

[webkit-changes] [281018] branches/safari-612.1.27.0-branch/Source/JavaScriptCore

2021-08-13 Thread alancoon

Title: [281018] branches/safari-612.1.27.0-branch/Source/_javascript_Core








Revision 281018
Author alanc...@apple.com
Date 2021-08-13 08:30:09 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r280996. rdar://problem/81901248

Refactor some ARM64EHash code.
https://bugs.webkit.org/show_bug.cgi?id=229054

Reviewed by Keith Miller and Robin Morisset.

This patch only refactors ARM64EHash code by moving some methods into the private
section, and removing some unneeded static_casts.

Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
that there are no diffs in the generated code from this change.

* assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h




Diff

Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog (281017 => 281018)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-13 15:30:07 UTC (rev 281017)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-13 15:30:09 UTC (rev 281018)
@@ -1,5 +1,53 @@
 2021-08-13  Alan Coon  
 
+Cherry-pick r280996. rdar://problem/81901248
+
+Refactor some ARM64EHash code.
+https://bugs.webkit.org/show_bug.cgi?id=229054
+
+Reviewed by Keith Miller and Robin Morisset.
+
+This patch only refactors ARM64EHash code by moving some methods into the private
+section, and removing some unneeded static_casts.
+
+Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
+that there are no diffs in the generated code from this change.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-12  Mark Lam  
+
+Refactor some ARM64EHash code.
+https://bugs.webkit.org/show_bug.cgi?id=229054
+
+Reviewed by Keith Miller and Robin Morisset.
+
+This patch only refactors ARM64EHash code by moving some methods into the private
+section, and removing some unneeded static_casts.
+
+Verified with a diff of `otool -tv` dumps of the built _javascript_Core binaries,
+that there are no diffs in the generated code from this change.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+
+2021-08-13  Alan Coon  
+
 Cherry-pick r280984. rdar://problem/81901248
 
 Update ARM64EHash


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h (281017 => 281018)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 15:30:07 UTC (rev 281017)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 15:30:09 UTC (rev 281018)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -205,12 +205,27 @@
 #if CPU(ARM64E)
 class ARM64EHash {
 public:
+ARM64EHash(void* diversifier)
+{
+setUpdatedHash(0, 0, diversifier);
+}
+
+ALWAYS_INLINE uint32_t update(uint32_t instruction, uint32_t index, void* diversifier)
+{
+uint32_t currentHash = this->currentHash(index, diversifier);
+uint64_t nextIndex = index + 1;
+uint32_t output = nextValue(instruction, nextIndex, currentHash);
+setUpdatedHash(output, nextIndex, diversifier);
+return output;
+}
+
+private:
 static constexpr uint8_t initializationNamespace = 0x11;
 
 static ALWAYS_INLINE PtrTag makeDiversifier(uint8_t namespaceTag, uint64_t index, uint32_t value)
 {
 // 
-return static_cast((static_cast(namespaceTag) << 56) + ((index & 0xFF) << 32) +

[webkit-changes] [281017] branches/safari-612.1.27.0-branch/Source/JavaScriptCore

2021-08-13 Thread alancoon

Title: [281017] branches/safari-612.1.27.0-branch/Source/_javascript_Core








Revision 281017
Author alanc...@apple.com
Date 2021-08-13 08:30:07 -0700 (Fri, 13 Aug 2021)


Log Message
Cherry-pick r280984. rdar://problem/81901248

Update ARM64EHash
https://bugs.webkit.org/show_bug.cgi?id=228962


Reviewed by Mark Lam.

* assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::makeDiversifier):
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::bitsForDiversifier):
(JSC::ARM64EHash::currentHash):
(JSC::ARM64EHash::setUpdatedHash):
(JSC::ARM64EHash::ARM64EHash):
(JSC::ARM64EHash::update):
(JSC::ARM64EHash::finalize):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::hash const):
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h
branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/LinkBuffer.cpp




Diff

Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog (281016 => 281017)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-13 15:29:15 UTC (rev 281016)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-13 15:30:07 UTC (rev 281017)
@@ -1,3 +1,54 @@
+2021-08-13  Alan Coon  
+
+Cherry-pick r280984. rdar://problem/81901248
+
+Update ARM64EHash
+https://bugs.webkit.org/show_bug.cgi?id=228962
+
+
+Reviewed by Mark Lam.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+(JSC::ARM64EHash::setUpdatedHash):
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::finalize):
+(JSC::AssemblerBuffer::AssemblerBuffer):
+(JSC::AssemblerBuffer::putIntegralUnchecked):
+(JSC::AssemblerBuffer::hash const):
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-12  Saam Barati  
+
+Update ARM64EHash
+https://bugs.webkit.org/show_bug.cgi?id=228962
+
+
+Reviewed by Mark Lam.
+
+* assembler/AssemblerBuffer.h:
+(JSC::ARM64EHash::makeDiversifier):
+(JSC::ARM64EHash::nextValue):
+(JSC::ARM64EHash::bitsForDiversifier):
+(JSC::ARM64EHash::currentHash):
+(JSC::ARM64EHash::setUpdatedHash):
+(JSC::ARM64EHash::ARM64EHash):
+(JSC::ARM64EHash::update):
+(JSC::ARM64EHash::finalize):
+(JSC::AssemblerBuffer::AssemblerBuffer):
+(JSC::AssemblerBuffer::putIntegralUnchecked):
+(JSC::AssemblerBuffer::hash const):
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+
 2021-08-05  Russell Epstein  
 
 Cherry-pick r280659. rdar://problem/81569033


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h (281016 => 281017)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 15:29:15 UTC (rev 281016)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/assembler/AssemblerBuffer.h	2021-08-13 15:30:07 UTC (rev 281017)
@@ -205,22 +205,62 @@
 #if CPU(ARM64E)
 class ARM64EHash {
 public:
-ARM64EHash(uint32_t initialHash)
-: m_hash(initialHash)
+static constexpr uint8_t initializationNamespace = 0x11;
+
+static ALWAYS_INLINE PtrTag makeDiversifier(uint8_t namespaceTag, uint64_t index, uint32_t value)
 {
+// 
+return static_cast((static_cast(namespaceTag) << 56) + ((index & 0xFF) << 32) + static_cast(value));
 }
 
-ALWAYS_INLINE uint32_t update(uint32_t value)
+static ALWAYS_INLINE uint32_t nextValue(uint64_t instruction, uint64_t index, uint32_t currentValue)
 {
-uint64_t input = value ^ m_hash;
-uint64_t a = static_cast(tagInt(input, static_cast(0)) >> 39);
-uint64_t b = tagInt(input, static_cast(0xb7e151628aed2a6a)) >> 23;
-m_hash = a ^ b;
-return m_hash;
+uint64_t a = tagInt(instruction, makeDiversifier(0x12, index, currentValue));
+uint64_t b = tagInt(instruction, makeDiversifier(0x13, index, currentValue));
+return static_cast((a >> 39) ^ (b >> 23));
 }
 
+static ALWAYS_INLINE uint32_t

[webkit-changes] [281016] branches/safari-612.1.27.0-branch/Source

2021-08-13 Thread alancoon

Title: [281016] branches/safari-612.1.27.0-branch/Source








Revision 281016
Author alanc...@apple.com
Date 2021-08-13 08:29:15 -0700 (Fri, 13 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.27.0.22

Modified Paths

branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.27.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281015 => 281016)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 14:40:23 UTC (rev 281015)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-13 15:29:15 UTC (rev 281016)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281015 => 281016)

--- branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 14:40:23 UTC (rev 281015)
+++ branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-13 15:29:15 UTC (rev 281016)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281015 => 281016)

--- branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 14:40:23 UTC (rev 281015)
+++ branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-13 15:29:15 UTC (rev 281016)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig (281015 => 281016)

--- branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 14:40:23 UTC (rev 281015)
+++ branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-13 15:29:15 UTC (rev 281016)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281015 => 281016)

--- branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 14:40:23 UTC (rev 281015)
+++ branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-13 15:29:15 UTC (rev 281016)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281015 => 281016)

--- branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 14:40:23 UTC (rev 281015)
+++ branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-13 15:29:15 UTC (rev 281016)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 0;
-NANO_VERSION = 21;
+NANO_VERSION = 22;
 FULL_VERSION =

[webkit-changes] [281015] trunk/Tools

2021-08-13 Thread lmoura

Title: [281015] trunk/Tools








Revision 281015
Author lmo...@igalia.com
Date 2021-08-13 07:40:23 -0700 (Fri, 13 Aug 2021)


Log Message
[WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=229067

Reviewed by Carlos Garcia Campos.

* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebKitWebViewProcessCrashed): Make warnings non-fatal while waiting for the crash.
* TestWebKitAPI/glib/TestExpectations.json: Remove expectation

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (281014 => 281015)

--- trunk/Tools/ChangeLog	2021-08-13 14:16:31 UTC (rev 281014)
+++ trunk/Tools/ChangeLog	2021-08-13 14:40:23 UTC (rev 281015)
@@ -1,3 +1,14 @@
+2021-08-13  Lauro Moura  
+
+[WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=229067
+
+Reviewed by Carlos Garcia Campos.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+(testWebKitWebViewProcessCrashed): Make warnings non-fatal while waiting for the crash.
+* TestWebKitAPI/glib/TestExpectations.json: Remove expectation
+
 2021-08-13  Martin Robinson  
 
 Get lint-test-expectations passing


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp (281014 => 281015)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp	2021-08-13 14:16:31 UTC (rev 281014)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp	2021-08-13 14:40:23 UTC (rev 281015)
@@ -161,7 +161,9 @@
 G_DBUS_CALL_FLAGS_NONE,
 -1, 0, 0));
 g_assert_null(result);
+Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
 g_main_loop_run(test->m_mainLoop);
+Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);
 test->m_expectedWebProcessCrash = false;
 }
 


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (281014 => 281015)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-08-13 14:16:31 UTC (rev 281014)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-08-13 14:40:23 UTC (rev 281015)
@@ -74,9 +74,6 @@
 },
 "TestWebExtensions": {
 "subtests": {
-"/webkit/WebKitWebView/web-process-crashed": {
-"expected": {"wpe": {"status": ["FAIL", "PASS"], "bug": ["webkit.org/b/229067"]}}
-},
 "/webkit/WebKitWebView/install-missing-plugins-permission-request": {
 "expected": {"gtk": {"status": ["TIMEOUT", "FAIL"], "bug": ["webkit.org/b/147822", "webkit.org/b/210635"]}}
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281014] trunk/Source/WebCore

2021-08-13 Thread ntim

Title: [281014] trunk/Source/WebCore








Revision 281014
Author n...@apple.com
Date 2021-08-13 07:16:31 -0700 (Fri, 13 Aug 2021)


Log Message
Check for dialog existence in top layer in HTMLDialogElement::showModal & close
https://bugs.webkit.org/show_bug.cgi?id=227907

Reviewed by Antti Koivisto.

Test: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html

Test expectations are unchanged because the test uses elementFromPoint, meaning that behaviour difference isn't noticeable
until top layer rendering bits are implemented (which would change elementFromPoint's result by shuffling z-order based on top layer elements).

* dom/Element.h:
(WebCore::Element::isInTopLayer const):
* html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/html/HTMLDialogElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281013 => 281014)

--- trunk/Source/WebCore/ChangeLog	2021-08-13 11:57:19 UTC (rev 281013)
+++ trunk/Source/WebCore/ChangeLog	2021-08-13 14:16:31 UTC (rev 281014)
@@ -1,3 +1,21 @@
+2021-08-13  Tim Nguyen  
+
+Check for dialog existence in top layer in HTMLDialogElement::showModal & close
+https://bugs.webkit.org/show_bug.cgi?id=227907
+
+Reviewed by Antti Koivisto.
+
+Test: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
+
+Test expectations are unchanged because the test uses elementFromPoint, meaning that behaviour difference isn't noticeable
+until top layer rendering bits are implemented (which would change elementFromPoint's result by shuffling z-order based on top layer elements).
+
+* dom/Element.h:
+(WebCore::Element::isInTopLayer const):
+* html/HTMLDialogElement.cpp:
+(WebCore::HTMLDialogElement::showModal):
+(WebCore::HTMLDialogElement::close):
+
 2021-08-13  Jean-Yves Avenard  
 
 nexttrack and previoustrack MediaSession handlers not working


Modified: trunk/Source/WebCore/dom/Element.h (281013 => 281014)

--- trunk/Source/WebCore/dom/Element.h	2021-08-13 11:57:19 UTC (rev 281013)
+++ trunk/Source/WebCore/dom/Element.h	2021-08-13 14:16:31 UTC (rev 281014)
@@ -511,6 +511,8 @@
 const RenderStyle* lastStyleChangeEventStyle(PseudoId) const;
 void setLastStyleChangeEventStyle(PseudoId, std::unique_ptr&&);
 
+bool isInTopLayer() const { return document().topLayerElements().contains(makeRef(*const_cast(this))); }
+
 #if ENABLE(FULLSCREEN_API)
 bool containsFullScreenElement() const { return hasNodeFlag(NodeFlag::ContainsFullScreenElement); }
 void setContainsFullScreenElement(bool);


Modified: trunk/Source/WebCore/html/HTMLDialogElement.cpp (281013 => 281014)

--- trunk/Source/WebCore/html/HTMLDialogElement.cpp	2021-08-13 11:57:19 UTC (rev 281013)
+++ trunk/Source/WebCore/html/HTMLDialogElement.cpp	2021-08-13 14:16:31 UTC (rev 281014)
@@ -65,8 +65,8 @@
 
 m_isModal = true;
 
-// FIXME: Only add dialog to top layer if it's not already in it. (webkit.org/b/227907)
-document().addToTopLayer(*this);
+if (!isInTopLayer())
+document().addToTopLayer(*this);
 
 // FIXME: Add steps 8 & 9 from spec. (webkit.org/b/227537)
 
@@ -85,8 +85,8 @@
 if (!result.isNull())
 m_returnValue = result;
 
-// FIXME: Only remove dialog from top layer if it's inside it. (webkit.org/b/227907)
-document().removeFromTopLayer(*this);
+if (isInTopLayer())
+document().removeFromTopLayer(*this);
 
 // FIXME: Add step 6 from spec. (webkit.org/b/227537)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281013] trunk/Source/WebCore

2021-08-13 Thread jya

Title: [281013] trunk/Source/WebCore








Revision 281013
Author j...@apple.com
Date 2021-08-13 04:57:19 -0700 (Fri, 13 Aug 2021)


Log Message
nexttrack and previoustrack MediaSession handlers not working
https://bugs.webkit.org/show_bug.cgi?id=229068
rdar://80100092

Reviewed by Youenn Fablet.

Map between MediaSession action next/previousTrack and RemoteControlCommandType ones
were inverted.
There is no infrastrure in place to ensure that the right MRMediaRemoteCommand is
used with the MediaRemote backend, which prevents automating the test.

* Modules/mediasession/MediaSession.cpp:
(WebCore::platformCommandForMediaSessionAction):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281012 => 281013)

--- trunk/Source/WebCore/ChangeLog	2021-08-13 10:22:38 UTC (rev 281012)
+++ trunk/Source/WebCore/ChangeLog	2021-08-13 11:57:19 UTC (rev 281013)
@@ -1,3 +1,19 @@
+2021-08-13  Jean-Yves Avenard  
+
+nexttrack and previoustrack MediaSession handlers not working
+https://bugs.webkit.org/show_bug.cgi?id=229068
+rdar://80100092
+
+Reviewed by Youenn Fablet.
+
+Map between MediaSession action next/previousTrack and RemoteControlCommandType ones
+were inverted.
+There is no infrastrure in place to ensure that the right MRMediaRemoteCommand is
+used with the MediaRemote backend, which prevents automating the test.
+
+* Modules/mediasession/MediaSession.cpp:
+(WebCore::platformCommandForMediaSessionAction):
+
 2021-08-13  Youenn Fablet  
 
 Overly verbose catchable fetch error messages lead to cross-origin leaks


Modified: trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp (281012 => 281013)

--- trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp	2021-08-13 10:22:38 UTC (rev 281012)
+++ trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp	2021-08-13 11:57:19 UTC (rev 281013)
@@ -64,8 +64,8 @@
 { MediaSessionAction::Pause, PlatformMediaSession::PauseCommand },
 { MediaSessionAction::Seekforward, PlatformMediaSession::SkipForwardCommand },
 { MediaSessionAction::Seekbackward, PlatformMediaSession::SkipBackwardCommand },
-{ MediaSessionAction::Previoustrack, PlatformMediaSession::NextTrackCommand },
-{ MediaSessionAction::Nexttrack, PlatformMediaSession::PreviousTrackCommand },
+{ MediaSessionAction::Previoustrack, PlatformMediaSession::PreviousTrackCommand },
+{ MediaSessionAction::Nexttrack, PlatformMediaSession::NextTrackCommand },
 { MediaSessionAction::Stop, PlatformMediaSession::StopCommand },
 { MediaSessionAction::Seekto, PlatformMediaSession::SeekToPlaybackPositionCommand },
 { MediaSessionAction::Skipad, PlatformMediaSession::NextTrackCommand },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281012] trunk

2021-08-13 Thread youenn

Title: [281012] trunk








Revision 281012
Author you...@apple.com
Date 2021-08-13 03:22:38 -0700 (Fri, 13 Aug 2021)


Log Message
Overly verbose catchable fetch error messages lead to cross-origin leaks
https://bugs.webkit.org/show_bug.cgi?id=228861

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

Rebasing tests with new error message.

* web-platform-tests/FileAPI/url/url-with-fetch.any-expected.txt:
* web-platform-tests/FileAPI/url/url-with-fetch.any.worker-expected.txt:
* web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt:
* web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt:
* web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub-expected.txt:
* web-platform-tests/fetch/api/cors/cors-cookies.any.worker-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
* web-platform-tests/fetch/http-cache/cc-request.any-expected.txt:
* web-platform-tests/fetch/http-cache/cc-request.any.worker-expected.txt:
* web-platform-tests/html/cross-origin-embedder-policy/coep-on-response-from-service-worker.https-expected.txt:
* web-platform-tests/html/cross-origin-embedder-policy/none-sw-from-none.https-expected.txt:
* web-platform-tests/html/cross-origin-embedder-policy/none-sw-from-require-corp.https-expected.txt:
* web-platform-tests/html/cross-origin-embedder-policy/require-corp-sw-from-none.https-expected.txt:
* web-platform-tests/html/cross-origin-embedder-policy/require-corp-sw-from-require-corp.https-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/credentials.sub-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/credentials.sub-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/module/credentials.sub-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials-setTimeout.sub-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials.sub-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-event-referrer-policy.https-expected.txt:
* web-platform-tests/service-workers/service-worker/import-scripts-cross-origin.https-expected.txt:
* web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:
* web-platform-tests/wasm/jsapi/table/constructor-reftypes.tentative.any.worker-expected.txt:
* web-platform-tests/wasm/jsapi/table/grow-reftypes.tentative.any.worker-expected.txt:
* web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any.worker-expected.txt:

Source/WebCore:

Standardize error messages to get more uniform with other browsers.
To continue supporting service worker errors going to page errors,
we add a boolean to ResourceError to control whether sanitizing the error message or not.
This allows to keep error messages from service worker type exceptions to be exposed in window environments through fetch rejection.
Also handle ScriptModuleLoader since it is doing its own SRI checks.
Covered by rebased tests.

* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::loadingException const):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didFail):
* platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::sanitizedDescription const):
(WebCore::ResourceErrorBase::isSanitized const):
(WebCore::ResourceErrorBase::setAsSanitized):
(WebCore::ResourceErrorBase::ResourceErrorBase):
* platform/network/cf/ResourceError.h:
(WebCore::ResourceError::ResourceError):
* platform/network/curl/ResourceError.h:
(WebCore::ResourceError::ResourceError):
* platform/network/soup/ResourceError.h:
(WebCore::ResourceError::ResourceError):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
* workers/service/FetchEvent.cpp:
(WebCore::FetchEvent::createResponseError):
(WebCore::FetchEvent::respondWith):
(WebCore::FetchEvent::promiseIsSettled):
* workers/service/FetchEvent.h:
* workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse):
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
* bindings/js/ScriptModuleLoader.cpp:
(WebCore::ScriptModuleLoader::notifyFinished):

Source/WebKit:

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):

LayoutTests:

* http/tests/contentextensions/block-ping-resource-type-raw-expected.txt:
* http/tests/contentextensions/fetch-redirect-blocked.html:
* http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
*

[webkit-changes] [281011] trunk/Source/WebCore

2021-08-13 Thread svillar

Title: [281011] trunk/Source/WebCore








Revision 281011
Author svil...@igalia.com
Date 2021-08-13 02:38:55 -0700 (Fri, 13 Aug 2021)


Log Message
Crash in MockMediaSourcePrivate
https://bugs.webkit.org/show_bug.cgi?id=226795

Reviewed by Darin Adler.

The MockMediaPlayerMediaSource uses callOnMainThread() to execute advanceCurrentTime(). It might
happen that the object is destructed before the callback is executed as it isn't a ref counted
object. That leads to a crash on ASAN builds.

Made the object capable of creating weak ptrs so that we could check whether the _this_ object
has been freed in the meantime or not. For the former case we just bail out.

* platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::play): Create a WeakPtr.
(WebCore::MockMediaPlayerMediaSource::seekWithTolerance): Ditto.
(WebCore::MockMediaPlayerMediaSource::seekCompleted): Ditto.
* platform/mock/mediasource/MockMediaPlayerMediaSource.h: inherit from CanMakeWeakPtr.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp
trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (281010 => 281011)

--- trunk/Source/WebCore/ChangeLog	2021-08-13 08:40:04 UTC (rev 281010)
+++ trunk/Source/WebCore/ChangeLog	2021-08-13 09:38:55 UTC (rev 281011)
@@ -1,3 +1,23 @@
+2021-08-13  Sergio Villar Senin  
+
+Crash in MockMediaSourcePrivate
+https://bugs.webkit.org/show_bug.cgi?id=226795
+
+Reviewed by Darin Adler.
+
+The MockMediaPlayerMediaSource uses callOnMainThread() to execute advanceCurrentTime(). It might
+happen that the object is destructed before the callback is executed as it isn't a ref counted
+object. That leads to a crash on ASAN builds.
+
+Made the object capable of creating weak ptrs so that we could check whether the _this_ object
+has been freed in the meantime or not. For the former case we just bail out.
+
+* platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
+(WebCore::MockMediaPlayerMediaSource::play): Create a WeakPtr.
+(WebCore::MockMediaPlayerMediaSource::seekWithTolerance): Ditto.
+(WebCore::MockMediaPlayerMediaSource::seekCompleted): Ditto.
+* platform/mock/mediasource/MockMediaPlayerMediaSource.h: inherit from CanMakeWeakPtr.
+
 2021-08-12  Alex Christensen  
 
 Unprefix -webkit-backface-visibility


Modified: trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp (281010 => 281011)

--- trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp	2021-08-13 08:40:04 UTC (rev 281010)
+++ trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp	2021-08-13 09:38:55 UTC (rev 281011)
@@ -123,7 +123,9 @@
 void MockMediaPlayerMediaSource::play()
 {
 m_playing = 1;
-callOnMainThread([this] {
+callOnMainThread([this, weakThis = makeWeakPtr(this)] {
+if (!weakThis)
+return;
 advanceCurrentTime();
 });
 }
@@ -220,7 +222,9 @@
 m_player->timeChanged();
 
 if (m_playing)
-callOnMainThread([this] {
+callOnMainThread([this, weakThis = makeWeakPtr(this)] {
+if (!weakThis)
+return;
 advanceCurrentTime();
 });
 }
@@ -282,7 +286,9 @@
 m_player->timeChanged();
 
 if (m_playing)
-callOnMainThread([this] {
+callOnMainThread([this, weakThis = makeWeakPtr(this)] {
+if (!weakThis)
+return;
 advanceCurrentTime();
 });
 }


Modified: trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h (281010 => 281011)

--- trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h	2021-08-13 08:40:04 UTC (rev 281010)
+++ trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h	2021-08-13 09:38:55 UTC (rev 281011)
@@ -31,6 +31,7 @@
 #include "MediaPlayerPrivate.h"
 #include 
 #include 
+#include 
 
 namespace WebCore {
 
@@ -37,7 +38,7 @@
 class MediaSource;
 class MockMediaSourcePrivate;
 
-class MockMediaPlayerMediaSource : public MediaPlayerPrivateInterface {
+class MockMediaPlayerMediaSource : public MediaPlayerPrivateInterface, public CanMakeWeakPtr {
 public:
 explicit MockMediaPlayerMediaSource(MediaPlayer*);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281010] trunk

2021-08-13 Thread mrobinson

Title: [281010] trunk








Revision 281010
Author mrobin...@webkit.org
Date 2021-08-13 01:40:04 -0700 (Fri, 13 Aug 2021)


Log Message
Get lint-test-expectations passing
https://bugs.webkit.org/show_bug.cgi?id=228999

Reviewed by Ryan Haddad.

Tools:

* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder._is_test_file): Added a list of patterns for tests to skip
and ensured that 'boot.xml' and 'root.xml' (spurious files created during
the run of the WebKit1 bot) are on the list.
* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
(LayoutTestFinderTests.test_is_test_file): Added a test for the changes.

LayoutTests:

* TestExpectations: Remove expectation for non-existent test.
* platform/ios-simulator/TestExpectations: Ditto.
* platform/ios-wk2/TestExpectations: Ditto.
* platform/ios/TestExpectations: Dito.
* platform/mac-wk1/TestExpectations: Ditto. Also, the expectations for the non-test
'boot.xml' and 'root.xml' have been moved to workarounds in webkitpy.
* platform/mac/TestExpectations: Remove references to non-existent tests. Also combined
one expectation that was not linting due to a problem like the one described in bug
120081.
* platform/win/TestExpectations: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py




Diff

Modified: trunk/LayoutTests/ChangeLog (281009 => 281010)

--- trunk/LayoutTests/ChangeLog	2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 08:40:04 UTC (rev 281010)
@@ -1,3 +1,21 @@
+2021-08-13  Martin Robinson  
+
+Get lint-test-expectations passing
+https://bugs.webkit.org/show_bug.cgi?id=228999
+
+Reviewed by Ryan Haddad.
+
+* TestExpectations: Remove expectation for non-existent test.
+* platform/ios-simulator/TestExpectations: Ditto.
+* platform/ios-wk2/TestExpectations: Ditto.
+* platform/ios/TestExpectations: Dito.
+* platform/mac-wk1/TestExpectations: Ditto. Also, the expectations for the non-test
+'boot.xml' and 'root.xml' have been moved to workarounds in webkitpy.
+* platform/mac/TestExpectations: Remove references to non-existent tests. Also combined
+one expectation that was not linting due to a problem like the one described in bug
+120081.
+* platform/win/TestExpectations: Ditto.
+
 2021-08-12  Alex Christensen  
 
 Unprefix -webkit-backface-visibility


Modified: trunk/LayoutTests/TestExpectations (281009 => 281010)

--- trunk/LayoutTests/TestExpectations	2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/TestExpectations	2021-08-13 08:40:04 UTC (rev 281010)
@@ -1137,7 +1137,6 @@
 imported/w3c/web-platform-tests/resource-timing/cors-preflight.any.html [ Failure Pass ]
 imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-TAO.sub.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-partial-TAO.sub.html [ Pass Failure ]
-imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]
 imported/w3c/web-platform-tests/navigation-timing/secure_connection_start_non_zero.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/TAO-match.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/ios/TestExpectations (281009 => 281010)

--- trunk/LayoutTests/platform/ios/TestExpectations	2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2021-08-13 08:40:04 UTC (rev 281010)
@@ -2646,8 +2646,6 @@
 
 webkit.org/b/155092 js/arraybuffer-wrappers.html [ Pass Timeout ]
 
-webkit.org/b/172052 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ]
-
 webkit.org/b/183441 mathml/presentation/multiscripts-equivalence.html [ ImageOnlyFailure ]
 
 #  REGRESSION (ImageIO-1666): LayoutTests fast/images are failing together.


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (281009 => 281010)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2021-08-13 08:40:04 UTC (rev 281010)
@@ -114,11 +114,8 @@
 webkit.org/b/222685 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html [ Pass Failure ]

[webkit-changes] [281009] trunk

2021-08-13 Thread commit-queue

Title: [281009] trunk








Revision 281009
Author commit-qu...@webkit.org
Date 2021-08-12 23:46:31 -0700 (Thu, 12 Aug 2021)


Log Message
Unprefix -webkit-backface-visibility
https://bugs.webkit.org/show_bug.cgi?id=170983

Patch by Alex Christensen  on 2021-08-12
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* web-platform-tests/css/css-transforms/css-transform-property-existence-expected.txt: Added.
* web-platform-tests/css/css-transforms/css-transform-property-existence.html: Added.
* web-platform-tests/css/css-transforms/parsing/backface-visibility-computed-expected.txt:
* web-platform-tests/css/css-transforms/parsing/backface-visibility-valid-expected.txt:
* web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

This has already been done by Chrome and Firefox.
Keep the prefixed version as an alias.

Test: imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence.html

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* css/CSSProperties.json:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

LayoutTests:

* platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
* platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
* platform/ios/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/svg/css/getComputedStyle-basic-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/backface-visibility-computed-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/backface-visibility-valid-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/ios/svg/css/getComputedStyle-basic-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/platform/mac/svg/css/getComputedStyle-basic-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281008 => 281009)

--- trunk/LayoutTests/ChangeLog	2021-08-13 05:45:45 UTC (rev 281008)
+++ trunk/LayoutTests/ChangeLog	2021-08-13 06:46:31 UTC (rev 281009)
@@ -1,3 +1,19 @@
+2021-08-12  Alex Christensen  
+
+Unprefix -webkit-backface-visibility
+https://bugs.webkit.org/show_bug.cgi?id=170983
+
+Reviewed by Simon Fraser.
+
+*

47 matches

Mail list logo