[webkit-changes] [284917] trunk
Title: [284917] trunk
Revision 284917
Author commit-qu...@webkit.org
Date 2021-10-26 20:11:35 -0700 (Tue, 26 Oct 2021)
Log Message
Remove properties set by NSURLProtocol on NSURLRequest before serializing
https://bugs.webkit.org/show_bug.cgi?id=232332
Patch by Alex Christensen on 2021-10-26
Reviewed by Geoff Garen.
Source/WebCore/PAL:
* pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
NSURLRequest encodeWithCoder: encodes the protocol properties, which are not used by WebKit.
They exist to be used by NSURLProtocol. Serializing them can serialize a large amount of data,
so to be more efficient and hopefully run out of memory less, remove the properties before serializing.
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder::encodePlatformData):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (284916 => 284917)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-10-27 01:07:57 UTC (rev 284916)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-10-27 03:11:35 UTC (rev 284917)
@@ -1,3 +1,13 @@
+2021-10-26 Alex Christensen
+
+Remove properties set by NSURLProtocol on NSURLRequest before serializing
+https://bugs.webkit.org/show_bug.cgi?id=232332
+
+
+Reviewed by Geoff Garen.
+
+* pal/spi/cf/CFNetworkSPI.h:
+
2021-10-26 Fujii Hironori
[WebCore] Remove unneeded WTF:: namespace prefix
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (284916 => 284917)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2021-10-27 01:07:57 UTC (rev 284916)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2021-10-27 03:11:35 UTC (rev 284917)
@@ -500,4 +500,12 @@
- (void)_sendCloseCode:(NSURLSessionWebSocketCloseCode)closeCode reason:(NSData *)reason;
@end
+@interface NSMutableURLRequest (Staging_83855325)
+- (void)_removeAllProtocolProperties;
+@end
+
+@interface NSURLRequest (Staging_83857142)
+@property (nonatomic, readonly, nullable, retain) NSDictionary *_allProtocolProperties;
+@end
+
#endif // defined(__OBJC__)
Modified: trunk/Source/WebKit/ChangeLog (284916 => 284917)
--- trunk/Source/WebKit/ChangeLog 2021-10-27 01:07:57 UTC (rev 284916)
+++ trunk/Source/WebKit/ChangeLog 2021-10-27 03:11:35 UTC (rev 284917)
@@ -1,3 +1,18 @@
+2021-10-26 Alex Christensen
+
+Remove properties set by NSURLProtocol on NSURLRequest before serializing
+https://bugs.webkit.org/show_bug.cgi?id=232332
+
+
+Reviewed by Geoff Garen.
+
+NSURLRequest encodeWithCoder: encodes the protocol properties, which are not used by WebKit.
+They exist to be used by NSURLProtocol. Serializing them can serialize a large amount of data,
+so to be more efficient and hopefully run out of memory less, remove the properties before serializing.
+
+* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
+(IPC::ArgumentCoder::encodePlatformData):
+
2021-10-26 Kate Cheney
NetworkProcess::updateBundleIdentifier, a testing function, overrides the actual bundleID instead of the override value
Modified: trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm (284916 => 284917)
--- trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm 2021-10-27 01:07:57 UTC (rev 284916)
+++ trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm 2021-10-27 03:11:35 UTC (rev 284917)
@@ -37,6 +37,7 @@
#import
#import
#import
+#import
#import
#if PLATFORM(IOS_FAMILY)
@@ -626,10 +627,18 @@
// We don't send HTTP body over IPC for better performance.
// Also, it's not always possible to do, as streams can only be created in process that does networking.
-if ([requestToSerialize HTTPBody] || [requestToSerialize HTTPBodyStream]) {
+bool hasHTTPBody = [requestToSerialize HTTPBody] || [requestToSerialize HTTPBodyStream];
+
+// FIXME: Replace this respondsToSelector check with a HAS macro once rdar://83857142 has been put in a build and the bots are updated.
+bool hasProtocolProperties = [requestToSerialize respondsToSelector:@selector(_allProtocolProperties)] && [requestToSerialize _allProtocolProperties];
+
+if (hasHTTPBody || hasProtocolProperties) {
auto mutableRequest = adoptNS([requestToSerialize mutableCopy]);
[mutableRequest setHTTPBody:nil];
[mutableRequest setHTTPBodyStream:nil];
+// FIXME: Replace this respondsToSelector check with a HAS macro once rdar://83855325 has been put in a build and the bots are updated.
+if ([mutableRequest respondsToSelector:@selector(_removeAllProtocolProperties)])
+[mutableRequest
[webkit-changes] [284916] trunk/JSTests
Title: [284916] trunk/JSTests Revision 284916 Author ysuz...@apple.com Date 2021-10-26 18:07:57 -0700 (Tue, 26 Oct 2021) Log Message Unreivewed, fix CLoop build and test failure CLoop is running Yarr interpreter instead of Yarr JIT. * mozilla/ecma_3/RegExp/regress-85721.js: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/mozilla/ecma_3/RegExp/regress-85721.js Diff Modified: trunk/JSTests/ChangeLog (284915 => 284916) --- trunk/JSTests/ChangeLog 2021-10-27 00:38:12 UTC (rev 284915) +++ trunk/JSTests/ChangeLog 2021-10-27 01:07:57 UTC (rev 284916) @@ -1,5 +1,13 @@ 2021-10-26 Yusuke Suzuki +Unreivewed, fix CLoop build and test failure + +CLoop is running Yarr interpreter instead of Yarr JIT. + +* mozilla/ecma_3/RegExp/regress-85721.js: + +2021-10-26 Yusuke Suzuki + Unreviewed, fix test262 bot failures https://bugs.webkit.org/show_bug.cgi?id=232005 Modified: trunk/JSTests/mozilla/ecma_3/RegExp/regress-85721.js (284915 => 284916) --- trunk/JSTests/mozilla/ecma_3/RegExp/regress-85721.js 2021-10-27 00:38:12 UTC (rev 284915) +++ trunk/JSTests/mozilla/ecma_3/RegExp/regress-85721.js 2021-10-27 01:07:57 UTC (rev 284916) @@ -45,7 +45,7 @@ //- var bug = 85721; var summary = 'Performance: execution of regular _expression_'; -var FAST = 100; // execution should be 100 ms or less to pass the test +var FAST = 500; // execution should be 500 ms or less to pass the test var MSG_FAST = 'Execution took less than ' + FAST + ' ms'; var MSG_SLOW = 'Execution took '; var MSG_MS = ' ms'; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284915] tags/Safari-613.1.6.3/
Title: [284915] tags/Safari-613.1.6.3/ Revision 284915 Author alanc...@apple.com Date 2021-10-26 17:38:12 -0700 (Tue, 26 Oct 2021) Log Message Tag Safari-613.1.6.3. Added Paths tags/Safari-613.1.6.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284914] branches/safari-613.1.6-branch/Source/JavaScriptCore
Title: [284914] branches/safari-613.1.6-branch/Source/_javascript_Core
Revision 284914
Author alanc...@apple.com
Date 2021-10-26 17:35:11 -0700 (Tue, 26 Oct 2021)
Log Message
Revert r284255. rdar://problem/84666813
Modified Paths
branches/safari-613.1.6-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.cpp
branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.h
branches/safari-613.1.6-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/CachedRecovery.cpp
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/CallFrameShuffleData.cpp
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/CallFrameShuffleData.h
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/CallFrameShuffler.cpp
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/CallFrameShuffler.h
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/CallFrameShuffler32_64.cpp
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/GPRInfo.h
branches/safari-613.1.6-branch/Source/_javascript_Core/jit/RegisterSet.cpp
branches/safari-613.1.6-branch/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
Diff
Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/ChangeLog (284913 => 284914)
--- branches/safari-613.1.6-branch/Source/_javascript_Core/ChangeLog 2021-10-27 00:33:43 UTC (rev 284913)
+++ branches/safari-613.1.6-branch/Source/_javascript_Core/ChangeLog 2021-10-27 00:35:11 UTC (rev 284914)
@@ -1,3 +1,7 @@
+2021-10-26 Kocsen Chung
+
+Revert r284255. rdar://problem/84666813
+
2021-10-18 Yusuke Suzuki
[JSC] Use USE(LARGE_TYPED_ARRAY)
Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.cpp (284913 => 284914)
--- branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.cpp 2021-10-27 00:33:43 UTC (rev 284913)
+++ branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.cpp 2021-10-27 00:35:11 UTC (rev 284914)
@@ -99,11 +99,6 @@
case Int32DisplacedInJSStack:
out.print("*int32(", virtualRegister(), ")");
return;
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-out.print("*int32Tag(", virtualRegister(), ")");
-return;
-#endif
case Int52DisplacedInJSStack:
out.print("*int52(", virtualRegister(), ")");
return;
Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.h (284913 => 284914)
--- branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.h 2021-10-27 00:33:43 UTC (rev 284913)
+++ branches/safari-613.1.6-branch/Source/_javascript_Core/bytecode/ValueRecovery.h 2021-10-27 00:35:11 UTC (rev 284914)
@@ -60,9 +60,6 @@
DisplacedInJSStack,
// It's in the stack, at a different location, and it's unboxed.
Int32DisplacedInJSStack,
-#if USE(JSVALUE32_64)
-Int32TagDisplacedInJSStack, // int32 stored in tag field
-#endif
Int52DisplacedInJSStack,
StrictInt52DisplacedInJSStack,
DoubleDisplacedInJSStack,
@@ -190,19 +187,7 @@
result.m_source = WTFMove(u);
return result;
}
-
-#if USE(JSVALUE32_64)
-static ValueRecovery calleeSaveRegDisplacedInJSStack(VirtualRegister virtualReg, bool inTag)
-{
-ValueRecovery result;
-UnionType u;
-u.virtualReg = virtualReg.offset();
-result.m_source = WTFMove(u);
-result.m_technique = inTag ? Int32TagDisplacedInJSStack : Int32DisplacedInJSStack;
-return result;
-}
-#endif
-
+
static ValueRecovery constant(JSValue value)
{
ValueRecovery result;
@@ -273,9 +258,6 @@
switch (m_technique) {
case DisplacedInJSStack:
case Int32DisplacedInJSStack:
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-#endif
case Int52DisplacedInJSStack:
case StrictInt52DisplacedInJSStack:
case DoubleDisplacedInJSStack:
@@ -300,9 +282,6 @@
return DataFormatJS;
case UnboxedInt32InGPR:
case Int32DisplacedInJSStack:
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-#endif
return DataFormatInt32;
case UnboxedInt52InGPR:
case Int52DisplacedInJSStack:
@@ -379,9 +358,6 @@
switch (m_technique) {
case DisplacedInJSStack:
case Int32DisplacedInJSStack:
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-#endif
case DoubleDisplacedInJSStack:
case CellDisplacedInJSStack:
case BooleanDisplacedInJSStack:
Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (284913 => 284914)
--- branches/safari-613.1.6-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2021-10-27 00:33:43 UTC (rev 284913)
+++
[webkit-changes] [284913] branches/safari-613.1.6-branch/Source
Title: [284913] branches/safari-613.1.6-branch/Source Revision 284913 Author alanc...@apple.com Date 2021-10-26 17:33:43 -0700 (Tue, 26 Oct 2021) Log Message Versioning. WebKit-7613.1.6.3 Modified Paths branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig (284912 => 284913) --- branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-26 23:50:48 UTC (rev 284912) +++ branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-27 00:33:43 UTC (rev 284913) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (284912 => 284913) --- branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-26 23:50:48 UTC (rev 284912) +++ branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-27 00:33:43 UTC (rev 284913) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (284912 => 284913) --- branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-26 23:50:48 UTC (rev 284912) +++ branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-27 00:33:43 UTC (rev 284913) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig (284912 => 284913) --- branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-26 23:50:48 UTC (rev 284912) +++ branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-27 00:33:43 UTC (rev 284913) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (284912 => 284913) --- branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-26 23:50:48 UTC (rev 284912) +++ branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-27 00:33:43 UTC (rev 284913) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (284912 => 284913) --- branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-10-26 23:50:48 UTC (rev 284912) +++ branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-10-27 00:33:43 UTC (rev 284913) @@ -1,7 +1,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig (284912 => 284913) --- branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig 2021-10-26 23:50:48 UTC (rev 284912) +++ branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig 2021-10-27 00:33:43 UTC (rev 284913) @@ -24,7 +24,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION =
[webkit-changes] [284912] trunk/LayoutTests
Title: [284912] trunk/LayoutTests Revision 284912 Author ayumi_koj...@apple.com Date 2021-10-26 16:50:48 -0700 (Tue, 26 Oct 2021) Log Message [ BigSur wk2 Debug arm64 ] inspector/audit/run-accessibility.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=232322 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284911 => 284912) --- trunk/LayoutTests/ChangeLog 2021-10-26 23:47:50 UTC (rev 284911) +++ trunk/LayoutTests/ChangeLog 2021-10-26 23:50:48 UTC (rev 284912) @@ -1,5 +1,14 @@ 2021-10-26 Ayumi Kojima +[ BigSur wk2 Debug arm64 ] inspector/audit/run-accessibility.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=232322 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +2021-10-26 Ayumi Kojima + [ iPad ]Rebaselining compositing/contents-format/deep-color-backing-store.html. https://bugs.webkit.org/show_bug.cgi?id=232351 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284911 => 284912) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-26 23:47:50 UTC (rev 284911) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-26 23:50:48 UTC (rev 284912) @@ -1659,7 +1659,7 @@ webkit.org/b/230117 [ BigSur Debug ] http/tests/inspector/network/intercept-request-with-response.html [ Pass Failure ] webkit.org/b/230117 [ BigSur Debug ] http/tests/inspector/target/pause-on-inline-debugger-statement.html [ Pass Failure ] -webkit.org/b/232322 [ BigSur Debug arm64 ] inspector/audit/run-accessibility.html [ Pass Timeout ] +webkit.org/b/232322 [ BigSur Debug ] inspector/audit/run-accessibility.html [ Slow ] webkit.org/b/230359 [ BigSur+ Debug ] webrtc/video-mute-vp8.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284911] trunk/Source/JavaScriptCore
Title: [284911] trunk/Source/_javascript_Core
Revision 284911
Author commit-qu...@webkit.org
Date 2021-10-26 16:47:50 -0700 (Tue, 26 Oct 2021)
Log Message
Unreviewed, reverting r284255.
https://bugs.webkit.org/show_bug.cgi?id=232353
breaks 32-bit watch CLoop.
Reverted changeset:
"[JSC][32bit] Fix CSR restore on DFG tail calls, add extra
register on ARMv7"
https://bugs.webkit.org/show_bug.cgi?id=230622
https://commits.webkit.org/r284255
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp
trunk/Source/_javascript_Core/bytecode/ValueRecovery.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/jit/CachedRecovery.cpp
trunk/Source/_javascript_Core/jit/CallFrameShuffleData.cpp
trunk/Source/_javascript_Core/jit/CallFrameShuffleData.h
trunk/Source/_javascript_Core/jit/CallFrameShuffler.cpp
trunk/Source/_javascript_Core/jit/CallFrameShuffler.h
trunk/Source/_javascript_Core/jit/CallFrameShuffler32_64.cpp
trunk/Source/_javascript_Core/jit/GPRInfo.h
trunk/Source/_javascript_Core/jit/RegisterSet.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284910 => 284911)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-26 23:26:10 UTC (rev 284910)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-26 23:47:50 UTC (rev 284911)
@@ -1,3 +1,17 @@
+2021-10-26 Commit Queue
+
+Unreviewed, reverting r284255.
+https://bugs.webkit.org/show_bug.cgi?id=232353
+
+breaks 32-bit watch CLoop.
+
+Reverted changeset:
+
+"[JSC][32bit] Fix CSR restore on DFG tail calls, add extra
+register on ARMv7"
+https://bugs.webkit.org/show_bug.cgi?id=230622
+https://commits.webkit.org/r284255
+
2021-10-26 Xan López
[JSC] Improve offlineasm debug annotations for Linux/ELF
Modified: trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp (284910 => 284911)
--- trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp 2021-10-26 23:26:10 UTC (rev 284910)
+++ trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp 2021-10-26 23:47:50 UTC (rev 284911)
@@ -99,11 +99,6 @@
case Int32DisplacedInJSStack:
out.print("*int32(", virtualRegister(), ")");
return;
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-out.print("*int32Tag(", virtualRegister(), ")");
-return;
-#endif
case Int52DisplacedInJSStack:
out.print("*int52(", virtualRegister(), ")");
return;
Modified: trunk/Source/_javascript_Core/bytecode/ValueRecovery.h (284910 => 284911)
--- trunk/Source/_javascript_Core/bytecode/ValueRecovery.h 2021-10-26 23:26:10 UTC (rev 284910)
+++ trunk/Source/_javascript_Core/bytecode/ValueRecovery.h 2021-10-26 23:47:50 UTC (rev 284911)
@@ -60,9 +60,6 @@
DisplacedInJSStack,
// It's in the stack, at a different location, and it's unboxed.
Int32DisplacedInJSStack,
-#if USE(JSVALUE32_64)
-Int32TagDisplacedInJSStack, // int32 stored in tag field
-#endif
Int52DisplacedInJSStack,
StrictInt52DisplacedInJSStack,
DoubleDisplacedInJSStack,
@@ -190,19 +187,7 @@
result.m_source = WTFMove(u);
return result;
}
-
-#if USE(JSVALUE32_64)
-static ValueRecovery calleeSaveRegDisplacedInJSStack(VirtualRegister virtualReg, bool inTag)
-{
-ValueRecovery result;
-UnionType u;
-u.virtualReg = virtualReg.offset();
-result.m_source = WTFMove(u);
-result.m_technique = inTag ? Int32TagDisplacedInJSStack : Int32DisplacedInJSStack;
-return result;
-}
-#endif
-
+
static ValueRecovery constant(JSValue value)
{
ValueRecovery result;
@@ -273,9 +258,6 @@
switch (m_technique) {
case DisplacedInJSStack:
case Int32DisplacedInJSStack:
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-#endif
case Int52DisplacedInJSStack:
case StrictInt52DisplacedInJSStack:
case DoubleDisplacedInJSStack:
@@ -300,9 +282,6 @@
return DataFormatJS;
case UnboxedInt32InGPR:
case Int32DisplacedInJSStack:
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-#endif
return DataFormatInt32;
case UnboxedInt52InGPR:
case Int52DisplacedInJSStack:
@@ -379,9 +358,6 @@
switch (m_technique) {
case DisplacedInJSStack:
case Int32DisplacedInJSStack:
-#if USE(JSVALUE32_64)
-case Int32TagDisplacedInJSStack:
-#endif
case DoubleDisplacedInJSStack:
case CellDisplacedInJSStack:
case BooleanDisplacedInJSStack:
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (284910 => 284911)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2021-10-26 23:26:10 UTC (rev 284910)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
[webkit-changes] [284910] trunk/LayoutTests
Title: [284910] trunk/LayoutTests Revision 284910 Author ayumi_koj...@apple.com Date 2021-10-26 16:26:10 -0700 (Tue, 26 Oct 2021) Log Message [ iPad ]Rebaselining compositing/contents-format/deep-color-backing-store.html. https://bugs.webkit.org/show_bug.cgi?id=232351 Unreviewed test gardening. * platform/ipad/compositing/contents-format/deep-color-backing-store-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/ipad/compositing/contents-format/ trunk/LayoutTests/platform/ipad/compositing/contents-format/deep-color-backing-store-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (284909 => 284910) --- trunk/LayoutTests/ChangeLog 2021-10-26 23:13:45 UTC (rev 284909) +++ trunk/LayoutTests/ChangeLog 2021-10-26 23:26:10 UTC (rev 284910) @@ -1,3 +1,12 @@ +2021-10-26 Ayumi Kojima + +[ iPad ]Rebaselining compositing/contents-format/deep-color-backing-store.html. +https://bugs.webkit.org/show_bug.cgi?id=232351 + +Unreviewed test gardening. + +* platform/ipad/compositing/contents-format/deep-color-backing-store-expected.txt: Added. + 2021-10-26 Eric Hutchison N[ Mac Debug iOS Release wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html is a flaky failure. Added: trunk/LayoutTests/platform/ipad/compositing/contents-format/deep-color-backing-store-expected.txt (0 => 284910) --- trunk/LayoutTests/platform/ipad/compositing/contents-format/deep-color-backing-store-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ipad/compositing/contents-format/deep-color-backing-store-expected.txt 2021-10-26 23:26:10 UTC (rev 284910) @@ -0,0 +1,36 @@ +Box +Box +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 5018.00 2018.00) + (children 1 +(GraphicsLayer + (bounds 5018.00 2018.00) + (contentsOpaque 1) + (tile cache coverage 0, 0 1024 x 1024) + (tile size 512 x 512) + (top left tile 0, 0 tiles grid 2 x 2) + (in window 1) + (children 2 +(GraphicsLayer + (position 18.00 10.00) + (bounds 100.00 100.00) + (contentsOpaque 1) + (drawsContent 1) +) +(GraphicsLayer + (position 18.00 120.00) + (bounds 5000.00 100.00) + (usingTiledLayer 1) + (contentsOpaque 1) + (drawsContent 1) + (tile cache coverage 0, 0 1024 x 100) + (tile size 512 x 512) + (top left tile 0, 0 tiles grid 2 x 1) + (in window 1) +) + ) +) + ) +) + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284908] branches/safari-612-branch/Source/WebCore
Title: [284908] branches/safari-612-branch/Source/WebCore Revision 284908 Author alanc...@apple.com Date 2021-10-26 16:13:43 -0700 (Tue, 26 Oct 2021) Log Message Revert r283489. rdar://problem/84630680 This reverts r284828. Modified Paths branches/safari-612-branch/Source/WebCore/ChangeLog branches/safari-612-branch/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp branches/safari-612-branch/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h branches/safari-612-branch/Source/WebCore/html/CanvasBase.cpp branches/safari-612-branch/Source/WebCore/html/CanvasBase.h branches/safari-612-branch/Source/WebCore/html/HTMLCanvasElement.cpp branches/safari-612-branch/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp Diff Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (284907 => 284908) --- branches/safari-612-branch/Source/WebCore/ChangeLog 2021-10-26 23:09:36 UTC (rev 284907) +++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-10-26 23:13:43 UTC (rev 284908) @@ -248,89 +248,6 @@ 2021-10-25 Null -Cherry-pick r283489. rdar://problem/84630680 - -Regression (r283238)[ MacOS wk1 ] fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html is timing out -https://bugs.webkit.org/show_bug.cgi?id=231022 - -Patch by Kimmo Kinnunen on 2021-10-04 -Reviewed by Youenn Fablet. - -Originally the implementation would always return red frame, and the test would pass. -r283238 changed the implementation to not return a sample if there is not a display buffer, -as logically such cannot be used as a sample. -This broke the test case since the CanvasCaptureMediaStreamTrack would try to capture -the canvas display buffer during next runloop iteration (0s timeout) after each modification. -This does not work, as the display buffer is composed during "prepare for display" -phase. - -Add CanvasBase observers to observe that display buffer has been prepared, and capture -the media sample after that observer has fired. - -The test would work for wk2 due to timing related differences, preparation would have -typically run before the canvas capture 0s timeout. - -Fixes fast/mediastream/captureStream/canvas3d.html for wk1. - -* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp: -(WebCore::CanvasCaptureMediaStreamTrack::Source::startProducingData): -(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): -(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasDisplayBufferPrepared): -* Modules/mediastream/CanvasCaptureMediaStreamTrack.h: -* html/CanvasBase.cpp: -(WebCore::CanvasBase::addDisplayBufferObserver): -(WebCore::CanvasBase::removeDisplayBufferObserver): -(WebCore::CanvasBase::notifyObserversCanvasDisplayBufferPrepared): -* html/CanvasBase.h: -(WebCore::CanvasBase::hasDisplayBufferObservers const): -* html/canvas/WebGLRenderingContextBase.cpp: -(WebCore::WebGLRenderingContextBase::prepareForDisplay): -Move the "prepare only when the owner element is in the tree" logic to -its correct place to the caller, e.g. to the element itself. - -git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283489 268f45cc-cd09-0410-ab3c-d52691b4dbfc - -2021-10-04 Kimmo Kinnunen - -Regression (r283238)[ MacOS wk1 ] fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html is timing out -https://bugs.webkit.org/show_bug.cgi?id=231022 - -Reviewed by Youenn Fablet. - -Originally the implementation would always return red frame, and the test would pass. -r283238 changed the implementation to not return a sample if there is not a display buffer, -as logically such cannot be used as a sample. -This broke the test case since the CanvasCaptureMediaStreamTrack would try to capture -the canvas display buffer during next runloop iteration (0s timeout) after each modification. -This does not work, as the display buffer is composed during "prepare for display" -phase. - -Add CanvasBase observers to observe that display buffer has been prepared, and capture -the media sample after that observer has fired. - -The test would work for wk2 due to timing related differences, preparation would have -typically run before the canvas capture 0s timeout. - -Fixes fast/mediastream/captureStream/canvas3d.html for wk1. - -* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp: -(WebCore::CanvasCaptureMediaStreamTrack::Source::startProducingData): -(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): -(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasDisplayBufferPrepared): -* Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
[webkit-changes] [284909] branches/safari-612-branch/Source/WebKit/UIProcess/ WebAuthentication/Cocoa/LocalAuthenticator.mm
Title: [284909] branches/safari-612-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
Revision 284909
Author alanc...@apple.com
Date 2021-10-26 16:13:45 -0700 (Tue, 26 Oct 2021)
Log Message
Unreviewed build fix. rdar://84625267
error: no viable constructor or deduction guide for deduction of template arguments of 'WeakPtr'
Modified Paths
branches/safari-612-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
Diff
Modified: branches/safari-612-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (284908 => 284909)
--- branches/safari-612-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2021-10-26 23:13:43 UTC (rev 284908)
+++ branches/safari-612-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2021-10-26 23:13:45 UTC (rev 284909)
@@ -236,7 +236,7 @@
return excludeCredentialIds.contains(base64EncodeToString(rawId->data(), rawId->byteLength()));
})) {
// Obtain consent per Step 3.1
-auto callback = [weakThis = WeakPtr { *this }] (LocalAuthenticatorPolicy policy) {
+auto callback = [weakThis = makeWeakPtr(*this)] (LocalAuthenticatorPolicy policy) {
ASSERT(RunLoop::isMain());
if (!weakThis)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284906] trunk/Tools
Title: [284906] trunk/Tools
Revision 284906
Author commit-qu...@webkit.org
Date 2021-10-26 15:27:43 -0700 (Tue, 26 Oct 2021)
Log Message
webkitpy/autoinstalled/pyobjc_frameworks.py should not autoinstall frameworks if they can be imported without exceptions
https://bugs.webkit.org/show_bug.cgi?id=232331
Patch by Roy Reapor on 2021-10-26
Reviewed by Jonathan Bedard.
Avoid autointalling pyobjc frameworks if the installed frameworks can be imported without generating an exception.
* Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py:
(_import_modules):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py
Diff
Modified: trunk/Tools/ChangeLog (284905 => 284906)
--- trunk/Tools/ChangeLog 2021-10-26 22:12:50 UTC (rev 284905)
+++ trunk/Tools/ChangeLog 2021-10-26 22:27:43 UTC (rev 284906)
@@ -1,3 +1,15 @@
+2021-10-26 Roy Reapor
+
+webkitpy/autoinstalled/pyobjc_frameworks.py should not autoinstall frameworks if they can be imported without exceptions
+https://bugs.webkit.org/show_bug.cgi?id=232331
+
+Reviewed by Jonathan Bedard.
+
+Avoid autointalling pyobjc frameworks if the installed frameworks can be imported without generating an exception.
+
+* Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py:
+(_import_modules):
+
2021-10-26 Tim Horton
[GPU Process] `DisplayList::Recorder::getCTM` should include the device scale factor
Modified: trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py (284905 => 284906)
--- trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py 2021-10-26 22:12:50 UTC (rev 284905)
+++ trunk/Tools/Scripts/webkitpy/autoinstalled/pyobjc_frameworks.py 2021-10-26 22:27:43 UTC (rev 284906)
@@ -24,17 +24,26 @@
from webkitscmpy import AutoInstall, Package, Version
-pyobjc_core_version = Version.from_string(objc.__version__)
-AutoInstall.register(Package('Cocoa', pyobjc_core_version, pypi_name='pyobjc-framework-Cocoa', wheel=True))
-AutoInstall.register(Package('Quartz', pyobjc_core_version, pypi_name='pyobjc-framework-Quartz', wheel=True))
-# Modules from pyobjc-framework-Cocoa
-# Note, the module (`import_name`) provided to `AutoInstall.register`
-# must be imported first. This triggers the package install if necessary.
-Cocoa = __import__('Cocoa')
-AppKit = __import__('AppKit')
-CoreFoundation = __import__('CoreFoundation')
-Foundation = __import__('Foundation')
+def _import_modules():
+# Modules from pyobjc-framework-Cocoa and pyobjc-framework-Quartz
+# Note, the module (`import_name`) provided to `Package()`
+# must be imported first. This triggers the package install if necessary.
+return (
+__import__('Cocoa'),
+__import__('AppKit'),
+__import__('CoreFoundation'),
+__import__('Foundation'),
+__import__('Quartz')
+)
-# Module from pyobjc-framework-Quartz
-Quartz = __import__('Quartz')
+
+try:
+Cocoa, AppKit, CoreFoundation, Foundation, Quartz = _import_modules()
+except Exception as e:
+AutoInstall.log('Import failed with exception {}'.format(e))
+AutoInstall.log('Autoinstalling...')
+pyobjc_core_version = Version.from_string(objc.__version__)
+AutoInstall.register(Package('Cocoa', pyobjc_core_version, pypi_name='pyobjc-framework-Cocoa', wheel=True))
+AutoInstall.register(Package('Quartz', pyobjc_core_version, pypi_name='pyobjc-framework-Quartz', wheel=True))
+Cocoa, AppKit, CoreFoundation, Foundation, Quartz = _import_modules()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284905] trunk/LayoutTests
Title: [284905] trunk/LayoutTests Revision 284905 Author ehutchi...@apple.com Date 2021-10-26 15:12:50 -0700 (Tue, 26 Oct 2021) Log Message [ Mac Debug iOS Release wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=232337. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284904 => 284905) --- trunk/LayoutTests/ChangeLog 2021-10-26 22:03:34 UTC (rev 284904) +++ trunk/LayoutTests/ChangeLog 2021-10-26 22:12:50 UTC (rev 284905) @@ -1,3 +1,13 @@ +2021-10-26 Eric Hutchison + +N[ Mac Debug iOS Release wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html is a flaky failure. +https://bugs.webkit.org/show_bug.cgi?id=232337. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2021-10-26 Ayumi Kojima [ iOS Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is a flaky failure. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284904 => 284905) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-26 22:03:34 UTC (rev 284904) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-26 22:12:50 UTC (rev 284905) @@ -2243,3 +2243,5 @@ webkit.org/b/225528 http/wpt/fetch/fetch-response-body-stop-in-worker.html [ Pass Crash ] webkit.org/b/232252 [ Release ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ] + +webkit.org/b/232337 [ Release ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284904 => 284905) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-26 22:03:34 UTC (rev 284904) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-26 22:12:50 UTC (rev 284905) @@ -1690,5 +1690,6 @@ webkit.org/b/229569 [ Catalina Release ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation-stress-glare.https.html [ Pass Crash ] +webkit.org/b/232337 [ Debug ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284904] trunk
Title: [284904] trunk Revision 284904 Author ape...@igalia.com Date 2021-10-26 15:03:34 -0700 (Tue, 26 Oct 2021) Log Message Unreviewed. [WPE] Bump version numbers * Source/cmake/OptionsWPE.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/OptionsWPE.cmake Diff Modified: trunk/ChangeLog (284903 => 284904) --- trunk/ChangeLog 2021-10-26 22:00:59 UTC (rev 284903) +++ trunk/ChangeLog 2021-10-26 22:03:34 UTC (rev 284904) @@ -1,5 +1,11 @@ 2021-10-26 Adrian Perez de Castro +Unreviewed. [WPE] Bump version numbers + +* Source/cmake/OptionsWPE.cmake: + +2021-10-26 Adrian Perez de Castro + Multiple build issues with ENABLE_VIDEO=OFF https://bugs.webkit.org/show_bug.cgi?id=232264 Modified: trunk/Source/cmake/OptionsWPE.cmake (284903 => 284904) --- trunk/Source/cmake/OptionsWPE.cmake 2021-10-26 22:00:59 UTC (rev 284903) +++ trunk/Source/cmake/OptionsWPE.cmake 2021-10-26 22:03:34 UTC (rev 284904) @@ -1,7 +1,7 @@ include(GNUInstallDirs) include(VersioningUtils) -SET_PROJECT_VERSION(2 33 2) +SET_PROJECT_VERSION(2 35 0) set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string") @@ -140,9 +140,9 @@ endif () if (WPE_API_VERSION VERSION_EQUAL "1.0") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 19 0 16) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 20 0 17) else () -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 0 1) endif () set(CMAKE_C_VISIBILITY_PRESET hidden) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284903] trunk/LayoutTests
Title: [284903] trunk/LayoutTests Revision 284903 Author ayumi_koj...@apple.com Date 2021-10-26 15:00:59 -0700 (Tue, 26 Oct 2021) Log Message [ iOS Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=231030 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284902 => 284903) --- trunk/LayoutTests/ChangeLog 2021-10-26 21:50:28 UTC (rev 284902) +++ trunk/LayoutTests/ChangeLog 2021-10-26 22:00:59 UTC (rev 284903) @@ -1,3 +1,12 @@ +2021-10-26 Ayumi Kojima + +[ iOS Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is a flaky failure. +https://bugs.webkit.org/show_bug.cgi?id=231030 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2021-10-26 Chris Dumez Changing the src attribute of the element inside an ImageDocument does not trigger a load Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (284902 => 284903) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-10-26 21:50:28 UTC (rev 284902) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-10-26 22:00:59 UTC (rev 284903) @@ -1096,8 +1096,6 @@ webkit.org/b/190350 [ Mojave ] storage/indexeddb/database-odd-names.html [ Failure ] [ Mojave ] editing/mac/input/firstrectforcharacterrange-styled.html [ Failure ] -webkit.org/b/231030 [ Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Pass Failure DumpJSConsoleLogInStdErr ] - webkit.org/b/205412 [ Mojave Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Timeout ] webkit.org/b/212851 [ Mojave Release ] js/dom/unhandled-promise-rejection-console-no-report.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284902] trunk
Title: [284902] trunk
Revision 284902
Author timothy_hor...@apple.com
Date 2021-10-26 14:50:28 -0700 (Tue, 26 Oct 2021)
Log Message
[GPU Process] `DisplayList::Recorder::getCTM` should include the device scale factor
https://bugs.webkit.org/show_bug.cgi?id=230647
Reviewed by Simon Fraser.
Source/WebCore:
New test: BifurcatedGraphicsContextTests.ApplyDeviceScaleFactor
* platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::getCTM const):
(WebCore::DisplayList::Recorder::applyDeviceScaleFactor):
applyDeviceScaleFactor previously did not apply the scale to the CTM,
causing the DisplayList::Recorder's idea of the CTM to get out of sync
with the context being replayed into.
We don't call GraphicsContext::scale() directly (like GraphicsContextCG does)
because applyDeviceScaleFactor on the replay side will apply the scale
to the replayed context's CTM.
Tools:
* TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp:
(TestWebKitAPI::TEST):
Add a test that getCTM returns the correct scale after applyDeviceScaleFactor is called.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (284901 => 284902)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 21:49:46 UTC (rev 284901)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 21:50:28 UTC (rev 284902)
@@ -1,3 +1,23 @@
+2021-10-26 Tim Horton
+
+[GPU Process] `DisplayList::Recorder::getCTM` should include the device scale factor
+https://bugs.webkit.org/show_bug.cgi?id=230647
+
+Reviewed by Simon Fraser.
+
+New test: BifurcatedGraphicsContextTests.ApplyDeviceScaleFactor
+
+* platform/graphics/displaylists/DisplayListRecorder.cpp:
+(WebCore::DisplayList::Recorder::getCTM const):
+(WebCore::DisplayList::Recorder::applyDeviceScaleFactor):
+applyDeviceScaleFactor previously did not apply the scale to the CTM,
+causing the DisplayList::Recorder's idea of the CTM to get out of sync
+with the context being replayed into.
+
+We don't call GraphicsContext::scale() directly (like GraphicsContextCG does)
+because applyDeviceScaleFactor on the replay side will apply the scale
+to the replayed context's CTM.
+
2021-10-26 Chris Dumez
Changing the src attribute of the element inside an ImageDocument does not trigger a load
Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (284901 => 284902)
--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2021-10-26 21:49:46 UTC (rev 284901)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2021-10-26 21:50:28 UTC (rev 284902)
@@ -232,7 +232,6 @@
AffineTransform Recorder::getCTM(GraphicsContext::IncludeDeviceScale) const
{
-// FIXME: ([GPU Process] add support for `IncludeDeviceScale` inside `DisplayList::Recorder::getCTM`)
return currentState().ctm;
}
@@ -495,6 +494,10 @@
void Recorder::applyDeviceScaleFactor(float deviceScaleFactor)
{
+// We modify the state directly here instead of calling GraphicsContext::scale()
+// because the recorded item will scale() when replayed.
+currentState().scale({ deviceScaleFactor, deviceScaleFactor });
+
// FIXME: this changes the baseCTM, which will invalidate all of our cached extents.
// Assert that it's only called early on?
recordApplyDeviceScaleFactor(deviceScaleFactor);
Modified: trunk/Tools/ChangeLog (284901 => 284902)
--- trunk/Tools/ChangeLog 2021-10-26 21:49:46 UTC (rev 284901)
+++ trunk/Tools/ChangeLog 2021-10-26 21:50:28 UTC (rev 284902)
@@ -1,3 +1,14 @@
+2021-10-26 Tim Horton
+
+[GPU Process] `DisplayList::Recorder::getCTM` should include the device scale factor
+https://bugs.webkit.org/show_bug.cgi?id=230647
+
+Reviewed by Simon Fraser.
+
+* TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp:
+(TestWebKitAPI::TEST):
+Add a test that getCTM returns the correct scale after applyDeviceScaleFactor is called.
+
2021-10-26 Jonathan Bedard
[webkitscmpy] Comment and close pull-requests
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp (284901 => 284902)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp 2021-10-26 21:49:46 UTC (rev 284901)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp 2021-10-26 21:50:28 UTC (rev 284902)
@@ -278,6 +278,32 @@
EXPECT_EQ(primaryContext.clipBounds(), FloatRect(25, 25, 50, 50));
}
+TEST(BifurcatedGraphicsContextTests, ApplyDeviceScaleFactor)
+{
+auto colorSpace = DestinationColorSpace::SRGB();
+auto primaryCGContext =
[webkit-changes] [284901] trunk
Title: [284901] trunk Revision 284901 Author cdu...@apple.com Date 2021-10-26 14:49:46 -0700 (Tue, 26 Oct 2021) Log Message Changing the src attribute of the element inside an ImageDocument does not trigger a load https://bugs.webkit.org/show_bug.cgi?id=232323 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Rebaseline test that is now passing. * web-platform-tests/html/semantics/embedded-content/the-img-element/decode/image-decode-image-document-expected.txt: Source/WebCore: Changing the src attribute of the element inside an ImageDocument does not trigger a load. This is because when constructing the ImageDocument, we set that element's ImageLoader into manual loading mode so that we can feed it the network response we already have instead of triggering a new load. To address the issue, we now reset the element's ImageLoader to automatic loading mode once we've set its initial src attribute. Setting the src attribute is what ends up calling ImageLoader::updateFromElement(), which checks the |manual loading| flag. This way, any later attempt to change the src attribute will actually trigger an automatic load. No new tests, unskipped existing test. * html/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): LayoutTests: Unskip test that is no longer timing out. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/decode/image-decode-image-document-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/ImageDocument.cpp Diff Modified: trunk/LayoutTests/ChangeLog (284900 => 284901) --- trunk/LayoutTests/ChangeLog 2021-10-26 21:42:08 UTC (rev 284900) +++ trunk/LayoutTests/ChangeLog 2021-10-26 21:49:46 UTC (rev 284901) @@ -1,3 +1,14 @@ +2021-10-26 Chris Dumez + +Changing the src attribute of the element inside an ImageDocument does not trigger a load +https://bugs.webkit.org/show_bug.cgi?id=232323 + +Reviewed by Alex Christensen. + +Unskip test that is no longer timing out. + +* TestExpectations: + 2021-10-26 John Wilander [ iOS 15 ] ASSERTION FAILED: isRunningTest(WebCore::applicationBundleIdentifier()) Modified: trunk/LayoutTests/TestExpectations (284900 => 284901) --- trunk/LayoutTests/TestExpectations 2021-10-26 21:42:08 UTC (rev 284900) +++ trunk/LayoutTests/TestExpectations 2021-10-26 21:49:46 UTC (rev 284901) @@ -569,7 +569,6 @@ imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-change-src.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_history_go_forward.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/srcdoc_change_hash.html [ Skip ] -imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/decode/image-decode-image-document.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/natural-size-orientation.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-multiple-targets.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-to-different-origin-frame.html [ Skip ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284900 => 284901) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 21:42:08 UTC (rev 284900) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 21:49:46 UTC (rev 284901) @@ -1,5 +1,16 @@ 2021-10-26 Chris Dumez +Changing the src attribute of the element inside an ImageDocument does not trigger a load +https://bugs.webkit.org/show_bug.cgi?id=232323 + +Reviewed by Alex Christensen. + +Rebaseline test that is now passing. + +* web-platform-tests/html/semantics/embedded-content/the-img-element/decode/image-decode-image-document-expected.txt: + +2021-10-26 Chris Dumez + error event should be fired at
[webkit-changes] [284900] trunk/Source/WebCore
Title: [284900] trunk/Source/WebCore Revision 284900 Author sihui_...@apple.com Date 2021-10-26 14:42:08 -0700 (Tue, 26 Oct 2021) Log Message FileSystemHandle should be ContextDestructionObserver https://bugs.webkit.org/show_bug.cgi?id=231250 Reviewed by Youenn Fablet. Make FileSystemHandle and FileSystemSyncAccessHandle ActiveDOMObject to close them when context stops. * Modules/filesystemaccess/FileSystemDirectoryHandle.cpp: (WebCore::FileSystemDirectoryHandle::create): (WebCore::FileSystemDirectoryHandle::FileSystemDirectoryHandle): (WebCore::FileSystemDirectoryHandle::getFileHandle): (WebCore::FileSystemDirectoryHandle::getDirectoryHandle): (WebCore::FileSystemDirectoryHandle::removeEntry): (WebCore::FileSystemDirectoryHandle::resolve): (WebCore::FileSystemDirectoryHandle::getHandleNames): (WebCore::FileSystemDirectoryHandle::getHandle): * Modules/filesystemaccess/FileSystemDirectoryHandle.h: * Modules/filesystemaccess/FileSystemFileHandle.cpp: (WebCore::FileSystemFileHandle::create): (WebCore::FileSystemFileHandle::FileSystemFileHandle): (WebCore::FileSystemFileHandle::createSyncAccessHandle): (WebCore::FileSystemFileHandle::getSize): (WebCore::FileSystemFileHandle::truncate): (WebCore::FileSystemFileHandle::flush): (WebCore::FileSystemFileHandle::close): * Modules/filesystemaccess/FileSystemFileHandle.h: * Modules/filesystemaccess/FileSystemHandle.cpp: (WebCore::FileSystemHandle::FileSystemHandle): (WebCore::FileSystemHandle::isSameEntry const): (WebCore::FileSystemHandle::move): (WebCore::FileSystemHandle::activeDOMObjectName const): (WebCore::FileSystemHandle::stop): * Modules/filesystemaccess/FileSystemHandle.h: (WebCore::FileSystemHandle::isClosed const): * Modules/filesystemaccess/FileSystemHandle.idl: * Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp: (WebCore::FileSystemSyncAccessHandle::create): (WebCore::FileSystemSyncAccessHandle::FileSystemSyncAccessHandle): (WebCore::FileSystemSyncAccessHandle::~FileSystemSyncAccessHandle): (WebCore::FileSystemSyncAccessHandle::isClosingOrClosed const): (WebCore::FileSystemSyncAccessHandle::close): (WebCore::FileSystemSyncAccessHandle::closeInternal): (WebCore::FileSystemSyncAccessHandle::didClose): (WebCore::FileSystemSyncAccessHandle::activeDOMObjectName const): (WebCore::FileSystemSyncAccessHandle::stop): * Modules/filesystemaccess/FileSystemSyncAccessHandle.h: * Modules/filesystemaccess/FileSystemSyncAccessHandle.idl: * Modules/storage/StorageManager.cpp: (WebCore::StorageManager::fileSystemAccessGetDirectory): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp trunk/Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.h trunk/Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp trunk/Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.h trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandle.cpp trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandle.idl trunk/Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp trunk/Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h trunk/Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.idl trunk/Source/WebCore/Modules/storage/StorageManager.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (284899 => 284900) --- trunk/Source/WebCore/ChangeLog 2021-10-26 21:39:45 UTC (rev 284899) +++ trunk/Source/WebCore/ChangeLog 2021-10-26 21:42:08 UTC (rev 284900) @@ -1,3 +1,56 @@ +2021-10-26 Sihui Liu + +FileSystemHandle should be ContextDestructionObserver +https://bugs.webkit.org/show_bug.cgi?id=231250 + + +Reviewed by Youenn Fablet. + +Make FileSystemHandle and FileSystemSyncAccessHandle ActiveDOMObject to close them when context stops. + +* Modules/filesystemaccess/FileSystemDirectoryHandle.cpp: +(WebCore::FileSystemDirectoryHandle::create): +(WebCore::FileSystemDirectoryHandle::FileSystemDirectoryHandle): +(WebCore::FileSystemDirectoryHandle::getFileHandle): +(WebCore::FileSystemDirectoryHandle::getDirectoryHandle): +(WebCore::FileSystemDirectoryHandle::removeEntry): +(WebCore::FileSystemDirectoryHandle::resolve): +(WebCore::FileSystemDirectoryHandle::getHandleNames): +(WebCore::FileSystemDirectoryHandle::getHandle): +* Modules/filesystemaccess/FileSystemDirectoryHandle.h: +* Modules/filesystemaccess/FileSystemFileHandle.cpp: +(WebCore::FileSystemFileHandle::create): +(WebCore::FileSystemFileHandle::FileSystemFileHandle): +(WebCore::FileSystemFileHandle::createSyncAccessHandle): +(WebCore::FileSystemFileHandle::getSize): +(WebCore::FileSystemFileHandle::truncate): +(WebCore::FileSystemFileHandle::flush): +(WebCore::FileSystemFileHandle::close): +*
[webkit-changes] [284899] trunk/LayoutTests
Title: [284899] trunk/LayoutTests Revision 284899 Author wilan...@apple.com Date 2021-10-26 14:39:45 -0700 (Tue, 26 Oct 2021) Log Message [ iOS 15 ] ASSERTION FAILED: isRunningTest(WebCore::applicationBundleIdentifier()) https://bugs.webkit.org/show_bug.cgi?id=231255 Kate's fix in https://commits.webkit.org/r284897 should now have removed the cause of these assertion failures. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Removed test expectation that was added in https://trac.webkit.org/changeset/284881/webkit Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284898 => 284899) --- trunk/LayoutTests/ChangeLog 2021-10-26 21:36:10 UTC (rev 284898) +++ trunk/LayoutTests/ChangeLog 2021-10-26 21:39:45 UTC (rev 284899) @@ -1,3 +1,16 @@ +2021-10-26 John Wilander + +[ iOS 15 ] ASSERTION FAILED: isRunningTest(WebCore::applicationBundleIdentifier()) +https://bugs.webkit.org/show_bug.cgi?id=231255 + +Kate's fix in https://commits.webkit.org/r284897 should now have removed the +cause of these assertion failures. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: +Removed test expectation that was added in https://trac.webkit.org/changeset/284881/webkit + 2021-10-26 Chris Dumez error event should be fired at
[webkit-changes] [284898] trunk
Title: [284898] trunk Revision 284898 Author cdu...@apple.com Date 2021-10-26 14:36:10 -0700 (Tue, 26 Oct 2021) Log Message error event should be fired at
[webkit-changes] [284897] trunk/Source/WebKit
Title: [284897] trunk/Source/WebKit
Revision 284897
Author katherine_che...@apple.com
Date 2021-10-26 14:18:58 -0700 (Tue, 26 Oct 2021)
Log Message
NetworkProcess::updateBundleIdentifier, a testing function, overrides the actual bundleID instead of the override value
https://bugs.webkit.org/show_bug.cgi?id=232327
Reviewed by John Wilander.
No new tests, behavior confirmed by existing App Bound Domains tests.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::updateBundleIdentifier):
We should only ever set the override bundleID for testing purposes.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (284896 => 284897)
--- trunk/Source/WebKit/ChangeLog 2021-10-26 21:13:02 UTC (rev 284896)
+++ trunk/Source/WebKit/ChangeLog 2021-10-26 21:18:58 UTC (rev 284897)
@@ -1,3 +1,16 @@
+2021-10-26 Kate Cheney
+
+NetworkProcess::updateBundleIdentifier, a testing function, overrides the actual bundleID instead of the override value
+https://bugs.webkit.org/show_bug.cgi?id=232327
+
+Reviewed by John Wilander.
+
+No new tests, behavior confirmed by existing App Bound Domains tests.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::updateBundleIdentifier):
+We should only ever set the override bundleID for testing purposes.
+
2021-10-26 Brent Fulgham
[AppSSO] Avoid attempting to display a nil view controller
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (284896 => 284897)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-10-26 21:13:02 UTC (rev 284896)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-10-26 21:18:58 UTC (rev 284897)
@@ -2783,7 +2783,7 @@
{
#if PLATFORM(COCOA)
WebCore::clearApplicationBundleIdentifierTestingOverride();
-WebCore::setApplicationBundleIdentifier(bundleIdentifier);
+WebCore::setApplicationBundleIdentifierOverride(bundleIdentifier);
#endif
completionHandler();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284896] trunk/Source/WebKit
Title: [284896] trunk/Source/WebKit
Revision 284896
Author bfulg...@apple.com
Date 2021-10-26 14:13:02 -0700 (Tue, 26 Oct 2021)
Log Message
[AppSSO] Avoid attempting to display a nil view controller
https://bugs.webkit.org/show_bug.cgi?id=232311
Reviewed by Kate Cheney.
Avoid attempting to present a nil NSViewController. Instead, just treat the interaction as if
the authentication was cancelled.
* UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm:
(-[WKSOAuthorizationDelegate authorization:presentViewController:withCompletion:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284895 => 284896)
--- trunk/Source/WebKit/ChangeLog 2021-10-26 21:08:08 UTC (rev 284895)
+++ trunk/Source/WebKit/ChangeLog 2021-10-26 21:13:02 UTC (rev 284896)
@@ -1,3 +1,17 @@
+2021-10-26 Brent Fulgham
+
+[AppSSO] Avoid attempting to display a nil view controller
+https://bugs.webkit.org/show_bug.cgi?id=232311
+
+
+Reviewed by Kate Cheney.
+
+Avoid attempting to present a nil NSViewController. Instead, just treat the interaction as if
+the authentication was cancelled.
+
+* UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm:
+(-[WKSOAuthorizationDelegate authorization:presentViewController:withCompletion:]):
+
2021-10-26 Wenson Hsieh
REGRESSION (r281054): [iOS] Context menu presents from wrong location when long pressing a link in Mail
Modified: trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm (284895 => 284896)
--- trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm 2021-10-26 21:08:08 UTC (rev 284895)
+++ trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm 2021-10-26 21:13:02 UTC (rev 284896)
@@ -46,6 +46,13 @@
completion(NO, nil);
return;
}
+
+if (!viewController) {
+WKSOAUTHORIZATIONDELEGATE_RELEASE_LOG("authorization: No view controller to present, so completing with NO as success state.");
+completion(NO, nil);
+return;
+}
+
WKSOAUTHORIZATIONDELEGATE_RELEASE_LOG("authorization: presentingViewController %p", viewController);
_session->presentViewController(viewController, completion);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284895] trunk/Source/bmalloc
Title: [284895] trunk/Source/bmalloc Revision 284895 Author ddkil...@apple.com Date 2021-10-26 14:08:08 -0700 (Tue, 26 Oct 2021) Log Message [libpas] Add printf format attributes Reviewed by Yusuke Suzuki. Define PAS_FORMAT_PRINTF() macro in pas_utils.h, apply it to functions that take format strings, then fix all the issues found during compilation. These changes also let us remove the clang pragma macros that ignored -Wformat-nonliteral warnings in pas_log.c and pas_string_stream.c. * libpas/src/libpas/pas_all_heaps.c: (verify_in_steady_state_segregated_directory_callback): * libpas/src/libpas/pas_bitfit_directory.c: (pas_bitfit_directory_take_last_empty): * libpas/src/libpas/pas_bitfit_heap.c: (pas_bitfit_heap_select_variant): * libpas/src/libpas/pas_bitfit_page_inlines.h: (pas_bitfit_page_allocate): (pas_bitfit_page_deallocate_with_page_impl): * libpas/src/libpas/pas_commit_span.c: (pas_commit_span_construct): (pas_commit_span_add_unchanged): * libpas/src/libpas/pas_enumerate_large_heaps.c: (record_span): (pas_enumerate_large_heaps): * libpas/src/libpas/pas_fd_stream.c: (fd_stream_vprintf): * libpas/src/libpas/pas_fd_stream.h: * libpas/src/libpas/pas_hashtable.h: * libpas/src/libpas/pas_large_map.c: (pas_large_map_add): (pas_large_map_take): * libpas/src/libpas/pas_large_sharing_pool.c: (validate_min_heap): * libpas/src/libpas/pas_local_allocator_inlines.h: (pas_local_allocator_scan_bits_to_set_up_free_bits): (pas_local_allocator_return_memory_to_page): (pas_local_allocator_try_allocate_inline_cases): * libpas/src/libpas/pas_log.c: * libpas/src/libpas/pas_log.h: * libpas/src/libpas/pas_page_sharing_pool.c: (pas_page_sharing_pool_add_at_index): * libpas/src/libpas/pas_segregated_directory_inlines.h: (pas_segregated_directory_iterate_iterate_callback): (pas_segregated_directory_iterate_forward): * libpas/src/libpas/pas_segregated_heap.c: (pas_segregated_heap_ensure_size_directory_for_count): * libpas/src/libpas/pas_segregated_shared_page_directory.c: (pas_segregated_shared_page_directory_find_first_eligible): * libpas/src/libpas/pas_segregated_shared_view.c: (compute_summary): * libpas/src/libpas/pas_segregated_view.c: (for_each_live_object): (should_be_eligible): * libpas/src/libpas/pas_status_reporter.c: (pas_status_reporter_dump_large_map): * libpas/src/libpas/pas_stream.h: * libpas/src/libpas/pas_string_stream.c: (string_stream_vprintf): * libpas/src/libpas/pas_string_stream.h: * libpas/src/libpas/pas_thread_local_cache.c: (suspend): * libpas/src/libpas/pas_tiny_large_map_entry.h: (pas_tiny_large_map_entry_can_create): * libpas/src/libpas/pas_try_allocate_common.h: (pas_try_allocate_common_impl_fast): (pas_try_allocate_common_impl_slow): * libpas/src/libpas/pas_try_allocate_intrinsic.h: * libpas/src/libpas/pas_utils.h: Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/libpas/src/libpas/pas_all_heaps.c trunk/Source/bmalloc/libpas/src/libpas/pas_bitfit_directory.c trunk/Source/bmalloc/libpas/src/libpas/pas_bitfit_heap.c trunk/Source/bmalloc/libpas/src/libpas/pas_bitfit_page_inlines.h trunk/Source/bmalloc/libpas/src/libpas/pas_commit_span.c trunk/Source/bmalloc/libpas/src/libpas/pas_enumerate_large_heaps.c trunk/Source/bmalloc/libpas/src/libpas/pas_fd_stream.c trunk/Source/bmalloc/libpas/src/libpas/pas_fd_stream.h trunk/Source/bmalloc/libpas/src/libpas/pas_hashtable.h trunk/Source/bmalloc/libpas/src/libpas/pas_large_map.c trunk/Source/bmalloc/libpas/src/libpas/pas_large_sharing_pool.c trunk/Source/bmalloc/libpas/src/libpas/pas_local_allocator_inlines.h trunk/Source/bmalloc/libpas/src/libpas/pas_log.c trunk/Source/bmalloc/libpas/src/libpas/pas_log.h trunk/Source/bmalloc/libpas/src/libpas/pas_page_sharing_pool.c trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_directory_inlines.h trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_shared_view.c trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_view.c trunk/Source/bmalloc/libpas/src/libpas/pas_status_reporter.c trunk/Source/bmalloc/libpas/src/libpas/pas_stream.h trunk/Source/bmalloc/libpas/src/libpas/pas_string_stream.c trunk/Source/bmalloc/libpas/src/libpas/pas_string_stream.h trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c trunk/Source/bmalloc/libpas/src/libpas/pas_tiny_large_map_entry.h trunk/Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h trunk/Source/bmalloc/libpas/src/libpas/pas_try_allocate_intrinsic.h trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h Diff Modified: trunk/Source/bmalloc/ChangeLog (284894 => 284895) --- trunk/Source/bmalloc/ChangeLog 2021-10-26 21:07:13 UTC (rev 284894) +++ trunk/Source/bmalloc/ChangeLog 2021-10-26 21:08:08 UTC (rev 284895) @@ -1,3 +1,79 @@ +2021-10-26 David Kilzer + +[libpas] Add printf format attributes + + + +Reviewed by Yusuke Suzuki. + +Define
[webkit-changes] [284894] trunk
Title: [284894] trunk Revision 284894 Author cdu...@apple.com Date 2021-10-26 14:07:13 -0700 (Tue, 26 Oct 2021) Log Message html/semantics/embedded-content/the-img-element/adoption.html is timing out https://bugs.webkit.org/show_bug.cgi?id=232320 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test that is now passing. * web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt: Source/WebCore: When an moves to a new document, we're supposed to update the image's data. In HTMLImageElement::didMoveToNewDocument(), we would call HTMLPictureElement::sourcesChanged() if the element has a parent element, which would update the image's data. However, in the absence of a parent element, we would do nothing. This patch calls selectImageSource() when the element as a src / srcset attribute to make sure the image data gets updated. No new tests, rebaselined existing test. * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::didMoveToNewDocument): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLImageElement.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284893 => 284894) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 20:54:19 UTC (rev 284893) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 21:07:13 UTC (rev 284894) @@ -1,5 +1,16 @@ 2021-10-26 Chris Dumez +html/semantics/embedded-content/the-img-element/adoption.html is timing out +https://bugs.webkit.org/show_bug.cgi?id=232320 + +Reviewed by Darin Adler. + +Rebaseline WPT test that is now passing. + +* web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt: + +2021-10-26 Chris Dumez + elements should be able to fire more than one load / error event https://bugs.webkit.org/show_bug.cgi?id=232309 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt (284893 => 284894) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt 2021-10-26 20:54:19 UTC (rev 284893) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt 2021-10-26 21:07:13 UTC (rev 284894) @@ -1,13 +1,11 @@ -Harness Error (TIMEOUT), message = null - -TIMEOUT img (src only) Test timed out +PASS img (src only) PASS img (src only), parent is picture PASS img (src only), previous sibling is source -TIMEOUT img (srcset 1 cand) Test timed out +PASS img (srcset 1 cand) PASS img (srcset 1 cand), parent is picture PASS img (srcset 1 cand), previous sibling is source -FAIL adopt a cloned img in template assert_equals: expected "http://localhost:8800/images/green-1x1.png" but got "/images/green-1x1.png" +PASS adopt a cloned img in template PASS adoption is from appendChild Modified: trunk/Source/WebCore/ChangeLog (284893 => 284894) --- trunk/Source/WebCore/ChangeLog 2021-10-26 20:54:19 UTC (rev 284893) +++ trunk/Source/WebCore/ChangeLog 2021-10-26 21:07:13 UTC (rev 284894) @@ -1,3 +1,22 @@ +2021-10-26 Chris Dumez + +html/semantics/embedded-content/the-img-element/adoption.html is timing out +https://bugs.webkit.org/show_bug.cgi?id=232320 + +Reviewed by Darin Adler. + +When an moves to a new document, we're supposed to update the image's data. +In HTMLImageElement::didMoveToNewDocument(), we would call HTMLPictureElement::sourcesChanged() +if the element has a parent element, which would update the image's data. +However, in the absence of a parent element, we would do nothing. This patch calls +selectImageSource() when the element as a src / srcset attribute to make sure the +image data gets updated. + +No new tests, rebaselined existing test. + +* html/HTMLImageElement.cpp: +(WebCore::HTMLImageElement::didMoveToNewDocument): + 2021-10-26 Tim Horton DisplayList::Recorder's clipBounds() becomes empty if a flip is applied to the CTM Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (284893 => 284894) --- trunk/Source/WebCore/html/HTMLImageElement.cpp 2021-10-26 20:54:19 UTC (rev 284893) +++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2021-10-26 21:07:13 UTC (rev 284894) @@ -683,6 +683,8 @@ HTMLElement::didMoveToNewDocument(oldDocument, newDocument); if (RefPtr element = pictureElement()) element->sourcesChanged(); +else if (hasAttribute(srcAttr) || hasAttribute(srcsetAttr)) +selectImageSource(RelevantMutation::Yes); } bool HTMLImageElement::isServerMap() const ___ webkit-changes
[webkit-changes] [284893] trunk/LayoutTests
Title: [284893] trunk/LayoutTests Revision 284893 Author ayumi_koj...@apple.com Date 2021-10-26 13:54:19 -0700 (Tue, 26 Oct 2021) Log Message [ macOS Debug ] compositing/video/video-reflection.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=232330 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284892 => 284893) --- trunk/LayoutTests/ChangeLog 2021-10-26 20:10:33 UTC (rev 284892) +++ trunk/LayoutTests/ChangeLog 2021-10-26 20:54:19 UTC (rev 284893) @@ -1,5 +1,14 @@ 2021-10-26 Ayumi Kojima +[ macOS Debug ] compositing/video/video-reflection.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=232330 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2021-10-26 Ayumi Kojima + [ macOS ] imported/w3c/web-platform-tests/hr-time/basic.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=232316 Modified: trunk/LayoutTests/platform/mac/TestExpectations (284892 => 284893) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-10-26 20:10:33 UTC (rev 284892) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-10-26 20:54:19 UTC (rev 284893) @@ -993,6 +993,8 @@ webkit.org/b/168953 [ Release ] compositing/video/video-poster.html [ Pass Failure ] +webkit.org/b/232330 [ Debug ] compositing/video/video-reflection.html [ Pass Timeout ] + # Flaky on Mac webkit.org/b/148435 storage/domstorage/events/basic-body-attribute.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284892] trunk/Tools
Title: [284892] trunk/Tools Revision 284892 Author jbed...@apple.com Date 2021-10-26 13:10:33 -0700 (Tue, 26 Oct 2021) Log Message [webkitscmpy] Comment and close pull-requests https://bugs.webkit.org/show_bug.cgi?id=232095 Reviewed by Dewei Zhu. * Scripts/libraries/webkitscmpy/setup.py: Bump version. * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py: (BitBucket.request): Add support for activities, opening and closing pull-request. * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py: (GitHub.__init__): Add issues. (GitHub.request): Access issue underlying pull-request (which includes global comments). * Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py: (PullRequest.Exception): Added. (PullRequest.Comment): Added. (PullRequest.__init__): Add list of pull-request comments, metadata used by generator. (PullRequest.open): Re-open the pull-request. (PullRequest.close): Close the pull-request. (PullRequest.comment): Make a comment on the pull-request. (PullRequest.comments): List all comments on a pull-request. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py: (BitBucket.PRGenerator.update): Handle closing and opening of the pull-request. (BitBucket.PRGenerator.comment): Make a comment on a pull-request. (BitBucket.PRGenerator.comments): List all comments on a pull-request. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub.PRGenerator.update): Handle closing and opening of the pull-request. (GitHub.PRGenerator.comment): Make a comment on a issue underpinning a pull-request. (GitHub.PRGenerator.comments): List all comments on the pull-request. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py: (Scm.PRGenerator.update): Add support for opening and closing a pull-request. (Scm.PRGenerator.comment): Make a comment on a pull-request. (Scm.PRGenerator.comments): List all comments for a pull-request * Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitscmpy/setup.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py Diff Modified: trunk/Tools/ChangeLog (284891 => 284892) --- trunk/Tools/ChangeLog 2021-10-26 19:51:18 UTC (rev 284891) +++ trunk/Tools/ChangeLog 2021-10-26 20:10:33 UTC (rev 284892) @@ -1,3 +1,40 @@ +2021-10-26 Jonathan Bedard + +[webkitscmpy] Comment and close pull-requests +https://bugs.webkit.org/show_bug.cgi?id=232095 + + +Reviewed by Dewei Zhu. + +* Scripts/libraries/webkitscmpy/setup.py: Bump version. +* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. +* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py: +(BitBucket.request): Add support for activities, opening and closing pull-request. +* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py: +(GitHub.__init__): Add issues. +(GitHub.request): Access issue underlying pull-request (which includes global comments). +* Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py: +(PullRequest.Exception): Added. +(PullRequest.Comment): Added. +(PullRequest.__init__): Add list of pull-request comments, metadata used by generator. +(PullRequest.open): Re-open the pull-request. +(PullRequest.close): Close the pull-request. +(PullRequest.comment): Make a comment on the pull-request. +(PullRequest.comments): List all comments on a pull-request. +* Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py: +(BitBucket.PRGenerator.update): Handle closing and opening of the pull-request. +(BitBucket.PRGenerator.comment): Make a comment on a pull-request. +(BitBucket.PRGenerator.comments): List all comments on a pull-request. +* Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: +(GitHub.PRGenerator.update): Handle closing and opening of the pull-request. +(GitHub.PRGenerator.comment): Make a comment on a issue underpinning a pull-request. +(GitHub.PRGenerator.comments): List all comments on the pull-request. +* Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py: +(Scm.PRGenerator.update): Add support for opening and closing a pull-request. +(Scm.PRGenerator.comment):
[webkit-changes] [284891] trunk/Tools
Title: [284891] trunk/Tools
Revision 284891
Author simon.fra...@apple.com
Date 2021-10-26 12:51:18 -0700 (Tue, 26 Oct 2021)
Log Message
The script should decide when an image diff cases, not ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=232225
Unreviewed; respond to review feedback.
* Scripts/webkitpy/port/image_diff.py:
(ImageDiffer._read):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/image_diff.py
Diff
Modified: trunk/Tools/ChangeLog (284890 => 284891)
--- trunk/Tools/ChangeLog 2021-10-26 19:50:30 UTC (rev 284890)
+++ trunk/Tools/ChangeLog 2021-10-26 19:51:18 UTC (rev 284891)
@@ -1,3 +1,13 @@
+2021-10-26 Simon Fraser
+
+The script should decide when an image diff cases, not ImageDiff
+https://bugs.webkit.org/show_bug.cgi?id=232225
+
+Unreviewed; respond to review feedback.
+
+* Scripts/webkitpy/port/image_diff.py:
+(ImageDiffer._read):
+
2021-10-26 Alex Christensen
Update PCM test public key to one with RSA-PSS OID
Modified: trunk/Tools/Scripts/webkitpy/port/image_diff.py (284890 => 284891)
--- trunk/Tools/Scripts/webkitpy/port/image_diff.py 2021-10-26 19:50:30 UTC (rev 284890)
+++ trunk/Tools/Scripts/webkitpy/port/image_diff.py 2021-10-26 19:51:18 UTC (rev 284891)
@@ -134,7 +134,7 @@
m = re.match(b'diff: (.+)%', diff_output)
if not m:
-return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or "Failed to match ImageDiff output %s" % diff_output)
+return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or 'Failed to match ImageDiff output {}'.format(diff_output))
diff_percent = float(string_utils.decode(m.group(1), target_type=str))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284890] trunk
Title: [284890] trunk Revision 284890 Author commit-qu...@webkit.org Date 2021-10-26 12:50:30 -0700 (Tue, 26 Oct 2021) Log Message Update PCM test public key to one with RSA-PSS OID https://bugs.webkit.org/show_bug.cgi?id=231048 Patch by Alex Christensen on 2021-10-26 Reviewed by John Wilander. Source/WTF: * wtf/PlatformHave.h: Tools: In rdar://79069615 support for public keys with rsaEncryption OIDs was removed as stated on the blog at https://webkit.org/blog/11940/pcm-click-fraud-prevention-and-attribution-sent-to-advertiser/ This implements enough ASN1 serialization to serialize a public key in the form accepted by WebKit now, which is described at https://datatracker.ietf.org/doc/html/rfc8017#appendix-A.2.3 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/ASN1Utilities.cpp: Added. (ASN1::Object::sizeSerializedSize const): (ASN1::Object::serializeSize const): (ASN1::ObjectIdentifier::ObjectIdentifier): (ASN1::ObjectIdentifier::bytes const): (ASN1::Sequence::create): (ASN1::Sequence::Sequence): (ASN1::Sequence::elementEncodedLengthBytes const): (ASN1::IndexWrapper::IndexWrapper): (ASN1::Integer::Integer): (ASN1::BitString::BitString): (TestWebKitAPI::wrapPublicKeyWithRSAPSSOID): * TestWebKitAPI/Tests/WebCore/ASN1Utilities.h: Added. * TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm: (TestWebKitAPI::TEST): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj trunk/Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm Added Paths trunk/Tools/TestWebKitAPI/Tests/WebCore/ASN1Utilities.cpp trunk/Tools/TestWebKitAPI/Tests/WebCore/ASN1Utilities.h Diff Modified: trunk/Source/WTF/ChangeLog (284889 => 284890) --- trunk/Source/WTF/ChangeLog 2021-10-26 19:44:14 UTC (rev 284889) +++ trunk/Source/WTF/ChangeLog 2021-10-26 19:50:30 UTC (rev 284890) @@ -1,3 +1,12 @@ +2021-10-26 Alex Christensen + +Update PCM test public key to one with RSA-PSS OID +https://bugs.webkit.org/show_bug.cgi?id=231048 + +Reviewed by John Wilander. + +* wtf/PlatformHave.h: + 2021-10-26 Fujii Hironori [WebCore] Remove unneeded WTF:: namespace prefix Modified: trunk/Source/WTF/wtf/PlatformHave.h (284889 => 284890) --- trunk/Source/WTF/wtf/PlatformHave.h 2021-10-26 19:44:14 UTC (rev 284889) +++ trunk/Source/WTF/wtf/PlatformHave.h 2021-10-26 19:50:30 UTC (rev 284890) @@ -934,6 +934,13 @@ #define HAVE_VM_FLAGS_PERMANENT 1 #endif +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 120400) \ +|| (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 150400) \ +|| (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED >= 150400) \ +|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 80400) +#define HAVE_RSA_PSS_OID 1 +#endif + #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) \ || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 14) \ || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 7) \ Modified: trunk/Tools/ChangeLog (284889 => 284890) --- trunk/Tools/ChangeLog 2021-10-26 19:44:14 UTC (rev 284889) +++ trunk/Tools/ChangeLog 2021-10-26 19:50:30 UTC (rev 284890) @@ -1,3 +1,36 @@ +2021-10-26 Alex Christensen + +Update PCM test public key to one with RSA-PSS OID +https://bugs.webkit.org/show_bug.cgi?id=231048 + +Reviewed by John Wilander. + +In rdar://79069615 support for public keys with rsaEncryption OIDs was removed as stated on the blog at +https://webkit.org/blog/11940/pcm-click-fraud-prevention-and-attribution-sent-to-advertiser/ +This implements enough ASN1 serialization to serialize a public key in the form accepted by WebKit now, +which is described at https://datatracker.ietf.org/doc/html/rfc8017#appendix-A.2.3 + +* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: +* TestWebKitAPI/Tests/WebCore/ASN1Utilities.cpp: Added. +(ASN1::Object::sizeSerializedSize const): +(ASN1::Object::serializeSize const): +(ASN1::ObjectIdentifier::ObjectIdentifier): +(ASN1::ObjectIdentifier::bytes const): +(ASN1::Sequence::create): +(ASN1::Sequence::Sequence): +(ASN1::Sequence::elementEncodedLengthBytes const): +(ASN1::IndexWrapper::IndexWrapper): +(ASN1::Integer::Integer): +(ASN1::BitString::BitString): +(TestWebKitAPI::wrapPublicKeyWithRSAPSSOID): +* TestWebKitAPI/Tests/WebCore/ASN1Utilities.h: Added. +*
[webkit-changes] [284889] trunk/Source/WebKit
Title: [284889] trunk/Source/WebKit Revision 284889 Author wenson_hs...@apple.com Date 2021-10-26 12:44:14 -0700 (Tue, 26 Oct 2021) Log Message REGRESSION (r281054): [iOS] Context menu presents from wrong location when long pressing a link in Mail https://bugs.webkit.org/show_bug.cgi?id=232287 rdar://82671325 Reviewed by Tim Horton. In the case where the WebKit client isn't overriding the context menu configuration via WebKit context menu UI delegate methods, `_contextMenuElementInfo` on WKContentView will end up being nil while presenting the context menu via long press. After the changes in r281054, this means that when the last view is removed from our WKTargetedPreviewContainer, we'll unparent WKTargetedPreviewContainer too early, since `_contextMenuElementInfo` won't prevent us from bailing in `-_removeContextMenuHintContainerIfPossible`. To fix this, we add a boolean flag to track when the context menu presentation animation is running, and avoid unparenting the preview container if the flag is set. * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setUpInteraction]): (-[WKContentView _removeContextMenuHintContainerIfPossible]): (-[WKContentView _contentsOfUserInterfaceItem:]): (-[WKContentView contextMenuInteraction:willDisplayMenuForConfiguration:animator:]): To test this change, add an assertion that fires if the context menu preview hint container has already been unparented by the time we've presented the context menu. This assertion already fires during the extant layout test fast/events/touch/ios/long-press-on-link.html, which technically exhibits the bug (albeit in a more subtle way). (-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: trunk/Source/WebKit/ChangeLog (284888 => 284889) --- trunk/Source/WebKit/ChangeLog 2021-10-26 19:42:43 UTC (rev 284888) +++ trunk/Source/WebKit/ChangeLog 2021-10-26 19:44:14 UTC (rev 284889) @@ -1,3 +1,34 @@ +2021-10-26 Wenson Hsieh + +REGRESSION (r281054): [iOS] Context menu presents from wrong location when long pressing a link in Mail +https://bugs.webkit.org/show_bug.cgi?id=232287 +rdar://82671325 + +Reviewed by Tim Horton. + +In the case where the WebKit client isn't overriding the context menu configuration via WebKit context menu UI +delegate methods, `_contextMenuElementInfo` on WKContentView will end up being nil while presenting the context +menu via long press. + +After the changes in r281054, this means that when the last view is removed from our WKTargetedPreviewContainer, +we'll unparent WKTargetedPreviewContainer too early, since `_contextMenuElementInfo` won't prevent us from +bailing in `-_removeContextMenuHintContainerIfPossible`. To fix this, we add a boolean flag to track when the +context menu presentation animation is running, and avoid unparenting the preview container if the flag is set. + +* UIProcess/ios/WKContentViewInteraction.h: +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView setUpInteraction]): +(-[WKContentView _removeContextMenuHintContainerIfPossible]): +(-[WKContentView _contentsOfUserInterfaceItem:]): +(-[WKContentView contextMenuInteraction:willDisplayMenuForConfiguration:animator:]): + +To test this change, add an assertion that fires if the context menu preview hint container has already been +unparented by the time we've presented the context menu. This assertion already fires during the extant layout +test fast/events/touch/ios/long-press-on-link.html, which technically exhibits the bug (albeit in a more subtle +way). + +(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]): + 2021-10-26 Brady Eidson Add helper classes and messaging infrastructure to launch webpushd and round trip a message to it Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (284888 => 284889) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2021-10-26 19:42:43 UTC (rev 284888) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2021-10-26 19:44:14 UTC (rev 284889) @@ -350,6 +350,7 @@ RetainPtr _contextMenuLegacyMenu; BOOL _contextMenuHasRequestedLegacyData; BOOL _contextMenuActionProviderDelegateNeedsOverride; +BOOL _isDisplayingContextMenuWithAnimation; #endif RetainPtr _previewItemController; #endif Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (284888 => 284889) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2021-10-26 19:42:43 UTC (rev 284888) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
[webkit-changes] [284888] trunk
Title: [284888] trunk Revision 284888 Author timothy_hor...@apple.com Date 2021-10-26 12:42:43 -0700 (Tue, 26 Oct 2021) Log Message DisplayList::Recorder's clipBounds() becomes empty if a flip is applied to the CTM https://bugs.webkit.org/show_bug.cgi?id=232134 Reviewed by Darin Adler. Source/WebCore: New test: BifurcatedGraphicsContextTests.TransformedClip * platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::clip): (WebCore::DisplayList::Recorder::clipPath): (WebCore::DisplayList::Recorder::clipBounds const): Instead of updating clipBounds any time the CTM changes, store clipBounds in base coordinates and map through the CTM when retrieved. This matches CG's behavior and makes the clipBounds much sturdier. For example, previously, applying a `scale(1, -1)` to the context would immediately result in the clipBounds' height becoming negative, making the bounds empty and confusing anything that reads from it. (WebCore::DisplayList::Recorder::ContextState::translate): (WebCore::DisplayList::Recorder::ContextState::rotate): (WebCore::DisplayList::Recorder::ContextState::scale): (WebCore::DisplayList::Recorder::ContextState::setCTM): (WebCore::DisplayList::Recorder::ContextState::concatCTM): Stop updating the clipBounds when the CTM changes, this is no longer necessary. * platform/graphics/displaylists/DisplayListRecorderImpl.cpp: (WebCore::DisplayList::RecorderImpl::extentFromLocalBounds): Since the clipBounds is now in base space, map the display list item bounds to base space /before/ intersecting it with clipBounds. * platform/graphics/displaylists/DisplayListRecorder.h: Drive-by add a default parameter so getCTM can be called on the subclass the same way it can on GraphicsContext. * platform/graphics/transforms/AffineTransform.h: Fix a typo. Tools: * TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp: (TestWebKitAPI::TEST): Add a test ensuring that our clipBounds and CG's match through a series of simple transforms. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (284887 => 284888) --- trunk/Source/WebCore/ChangeLog 2021-10-26 19:34:30 UTC (rev 284887) +++ trunk/Source/WebCore/ChangeLog 2021-10-26 19:42:43 UTC (rev 284888) @@ -1,3 +1,41 @@ +2021-10-26 Tim Horton + +DisplayList::Recorder's clipBounds() becomes empty if a flip is applied to the CTM +https://bugs.webkit.org/show_bug.cgi?id=232134 + +Reviewed by Darin Adler. + +New test: BifurcatedGraphicsContextTests.TransformedClip + +* platform/graphics/displaylists/DisplayListRecorder.cpp: +(WebCore::DisplayList::Recorder::clip): +(WebCore::DisplayList::Recorder::clipPath): +(WebCore::DisplayList::Recorder::clipBounds const): +Instead of updating clipBounds any time the CTM changes, store +clipBounds in base coordinates and map through the CTM when retrieved. + +This matches CG's behavior and makes the clipBounds much sturdier. +For example, previously, applying a `scale(1, -1)` to the context +would immediately result in the clipBounds' height becoming negative, +making the bounds empty and confusing anything that reads from it. + +(WebCore::DisplayList::Recorder::ContextState::translate): +(WebCore::DisplayList::Recorder::ContextState::rotate): +(WebCore::DisplayList::Recorder::ContextState::scale): +(WebCore::DisplayList::Recorder::ContextState::setCTM): +(WebCore::DisplayList::Recorder::ContextState::concatCTM): +Stop updating the clipBounds when the CTM changes, this is no longer necessary. + +* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: +(WebCore::DisplayList::RecorderImpl::extentFromLocalBounds): +Since the clipBounds is now in base space, map the display list +item bounds to base space /before/ intersecting it with clipBounds. + +* platform/graphics/displaylists/DisplayListRecorder.h: +Drive-by add a default parameter so getCTM can be called on the subclass the same way it can on GraphicsContext. + +* platform/graphics/transforms/AffineTransform.h: Fix a typo. + 2021-10-26 Chris Dumez elements should be able to fire more than one load / error event Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (284887 => 284888) --- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2021-10-26 19:34:30 UTC (rev 284887) +++
[webkit-changes] [284887] trunk
Title: [284887] trunk Revision 284887 Author beid...@apple.com Date 2021-10-26 12:34:30 -0700 (Tue, 26 Oct 2021) Log Message Add helper classes and messaging infrastructure to launch webpushd and round trip a message to it https://bugs.webkit.org/show_bug.cgi?id=232262 Reviewed by Alex Christensen. Source/WebKit: No new tests (No behavior change yet) This patch: - Adds classes representing the WebPushDaemon and connections to it - Adds classes/constants/macros related to messaging that daemon - Adds SPI for configuring a connect to that daemon - Gets MiniBrowser closer to supporting built-in notifications - Has way more commented out code than usual for a patch, but that enables a great stopping-point milestone * NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm: Added. (WebKit::WebPushD::addVersionAndEncodedMessageToDictionary): (WebKit::WebPushD::Connection::newConnectionWasInitialized const): (WebKit::WebPushD::Connection::connectionReceivedEvent const): (WebKit::WebPushD::Connection::dictionaryFromMessage const): * NetworkProcess/Notifications/NetworkNotificationManager.cpp: (WebKit::NetworkNotificationManager::NetworkNotificationManager): (WebKit::NetworkNotificationManager::showNotification): (WebKit::NetworkNotificationManager::cancelNotification): (WebKit::NetworkNotificationManager::clearNotifications): (WebKit::NetworkNotificationManager::didDestroyNotification): (WebKit::NetworkNotificationManager::sendMessage const): (WebKit::ReplyCaller<>::callReply): (WebKit::ReplyCaller::callReply): (WebKit::NetworkNotificationManager::sendMessageWithReply const): * NetworkProcess/Notifications/NetworkNotificationManager.h: (WebKit::NetworkNotificationManager::networkSession const): * NetworkProcess/Notifications/WebPushDaemonConnection.cpp: Copied from Source/WebKit/Platform/IPC/DaemonConnection.cpp. (WebKit::WebPushD::Connection::Connection): (WebKit::WebPushD::Connection::networkSession const): * NetworkProcess/Notifications/WebPushDaemonConnection.h: Copied from Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Platform/IPC/DaemonConnection.cpp: * Platform/IPC/DaemonConnection.h: (WebKit::Daemon::ConnectionToMachService::machServiceName const): * Platform/IPC/cocoa/DaemonConnectionCocoa.mm: * Platform/Logging.h: * Shared/WebPushDaemonConstants.h: Copied from Source/WebKit/Platform/IPC/DaemonConnection.cpp. (WebKit::WebPushD::messageTypeSendsReply): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::copy const): * webpushd/WebPushDaemon.h: Copied from Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h. * webpushd/WebPushDaemon.mm: Copied from Source/WebKit/webpushd/WebPushDaemonMain.mm. (WebPushD::MessageInfo::echoTwice::encodeReply): (WebPushD::handleWebPushDMessageWithReply): (WebPushD::Daemon::singleton): (WebPushD::Daemon::connectionEventHandler): (WebPushD::Daemon::connectionAdded): (WebPushD::Daemon::connectionRemoved): (WebPushD::CompletionHandler Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h trunk/Source/WebKit/NetworkProcess/WebSocketTask.h trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in trunk/Source/WebKit/Platform/IPC/DaemonConnection.cpp trunk/Source/WebKit/Platform/IPC/DaemonConnection.h trunk/Source/WebKit/Platform/IPC/cocoa/DaemonConnectionCocoa.mm trunk/Source/WebKit/Platform/Logging.h trunk/Source/WebKit/Sources.txt trunk/Source/WebKit/SourcesCocoa.txt trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/webpushd/WebPushDaemonMain.mm trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/mac/AppDelegate.m trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m Added Paths trunk/Source/WebKit/NetworkProcess/Notifications/Cocoa/ trunk/Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm trunk/Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.cpp trunk/Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.h trunk/Source/WebKit/Shared/WebPushDaemonConstants.h trunk/Source/WebKit/webpushd/WebPushDaemon.h trunk/Source/WebKit/webpushd/WebPushDaemon.mm Diff Modified: trunk/Source/WebKit/ChangeLog (284886 => 284887) --- trunk/Source/WebKit/ChangeLog 2021-10-26 18:57:31 UTC (rev 284886) +++ trunk/Source/WebKit/ChangeLog 2021-10-26 19:34:30 UTC (rev 284887) @@ -1,3 +1,82 @@ +2021-10-26 Brady Eidson + +Add helper classes and messaging infrastructure to launch webpushd and round trip a message to it +https://bugs.webkit.org/show_bug.cgi?id=232262 + +Reviewed by Alex Christensen. + +No new tests (No behavior change yet) + +This
[webkit-changes] [284886] trunk/JSTests
Title: [284886] trunk/JSTests Revision 284886 Author ysuz...@apple.com Date 2021-10-26 11:57:31 -0700 (Tue, 26 Oct 2021) Log Message Unreviewed, fix test262 bot failures https://bugs.webkit.org/show_bug.cgi?id=232005 * test262/expectations.yaml: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/expectations.yaml Diff Modified: trunk/JSTests/ChangeLog (284885 => 284886) --- trunk/JSTests/ChangeLog 2021-10-26 18:44:31 UTC (rev 284885) +++ trunk/JSTests/ChangeLog 2021-10-26 18:57:31 UTC (rev 284886) @@ -1,3 +1,10 @@ +2021-10-26 Yusuke Suzuki + +Unreviewed, fix test262 bot failures +https://bugs.webkit.org/show_bug.cgi?id=232005 + +* test262/expectations.yaml: + 2021-10-25 Yusuke Suzuki [JSC] Don't branch around register allocation in DFG enumerator get by val Modified: trunk/JSTests/test262/expectations.yaml (284885 => 284886) --- trunk/JSTests/test262/expectations.yaml 2021-10-26 18:44:31 UTC (rev 284885) +++ trunk/JSTests/test262/expectations.yaml 2021-10-26 18:57:31 UTC (rev 284886) @@ -1161,12 +1161,21 @@ test/built-ins/Temporal/getOwnPropertyNames.js: default: 'Test262Error: length Expected SameValue(«5», «11») to be true' strict mode: 'Test262Error: length Expected SameValue(«5», «11») to be true' +test/intl402/DateTimeFormat/prototype/formatRange/en-US.js: + default: 'Test262Error: Expected SameValue(«1/3/2019 – 1/5/2019», «1/3/2019 – 1/5/2019») to be true' + strict mode: 'Test262Error: Expected SameValue(«1/3/2019 – 1/5/2019», «1/3/2019 – 1/5/2019») to be true' +test/intl402/DateTimeFormat/prototype/formatRange/fractionalSecondDigits.js: + default: 'Test262Error: no fractionalSecondDigits Expected SameValue(«02:03 – 02:13», «02:03 – 02:13») to be true' + strict mode: 'Test262Error: no fractionalSecondDigits Expected SameValue(«02:03 – 02:13», «02:03 – 02:13») to be true' test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js: default: 'Test262Error: Expected SameValue(«h24», «h23») to be true' strict mode: 'Test262Error: Expected SameValue(«h24», «h23») to be true' +test/intl402/Intl/getCanonicalLocales/non-iana-canon.js: + default: 'Test262Error: The value of Intl.getCanonicalLocales(tag)[0] equals the value of `canonical` Expected SameValue(«en-US-u-va-posix», «posix») to be true' + strict mode: 'Test262Error: The value of Intl.getCanonicalLocales(tag)[0] equals the value of `canonical` Expected SameValue(«en-US-u-va-posix», «posix») to be true' test/intl402/Intl/getCanonicalLocales/preferred-grandfathered.js: - default: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true' - strict mode: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true' + default: 'Test262Error: Expected SameValue(«xtg-x-cel-gaulish», «xtg») to be true' + strict mode: 'Test262Error: Expected SameValue(«xtg-x-cel-gaulish», «xtg») to be true' test/intl402/Intl/getCanonicalLocales/transformed-ext-canonical.js: default: 'Test262Error: Expected SameValue(«sl-t-sl-rozaj-biske-1994», «sl-t-sl-1994-biske-rozaj») to be true' strict mode: 'Test262Error: Expected SameValue(«sl-t-sl-rozaj-biske-1994», «sl-t-sl-1994-biske-rozaj») to be true' @@ -1177,14 +1186,14 @@ default: 'Test262Error: Expected SameValue(«und-NO-u-sd-no23», «und-NO-u-sd-no50») to be true' strict mode: 'Test262Error: Expected SameValue(«und-NO-u-sd-no23», «und-NO-u-sd-no50») to be true' test/intl402/Locale/extensions-grandfathered.js: - default: 'Test262Error: Expected SameValue(«fr-Cyrl-FR-gaulish-u-nu-latn», «fr-Cyrl-FR-u-nu-latn») to be true' - strict mode: 'Test262Error: Expected SameValue(«fr-Cyrl-FR-gaulish-u-nu-latn», «fr-Cyrl-FR-u-nu-latn») to be true' -test/intl402/Locale/getters-grandfathered.js: - default: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true' - strict mode: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true' + default: 'Test262Error: Expected SameValue(«fr-Cyrl-FR-u-nu-latn-x-cel-gaulish», «fr-Cyrl-FR-u-nu-latn») to be true' + strict mode: 'Test262Error: Expected SameValue(«fr-Cyrl-FR-u-nu-latn-x-cel-gaulish», «fr-Cyrl-FR-u-nu-latn») to be true' test/intl402/Locale/likely-subtags-grandfathered.js: - default: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true' - strict mode: 'Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true' + default: 'Test262Error: Expected SameValue(«xtg-x-cel-gaulish», «xtg») to be true' + strict mode: 'Test262Error: Expected SameValue(«xtg-x-cel-gaulish», «xtg») to be true' +test/intl402/Locale/prototype/minimize/removing-likely-subtags-first-adds-likely-subtags.js: + default: 'Test262Error: "und".minimize() should be "en" Expected SameValue(«en-u-va-posix», «en») to be true' + strict mode: 'Test262Error: "und".minimize() should be "en" Expected SameValue(«en-u-va-posix», «en») to be true' test/intl402/Temporal/PlainTime/prototype/toLocaleString/locales-undefined.js: default:
[webkit-changes] [284885] trunk/LayoutTests
Title: [284885] trunk/LayoutTests Revision 284885 Author ayumi_koj...@apple.com Date 2021-10-26 11:44:31 -0700 (Tue, 26 Oct 2021) Log Message [ macOS ] imported/w3c/web-platform-tests/hr-time/basic.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=232316 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284884 => 284885) --- trunk/LayoutTests/ChangeLog 2021-10-26 18:32:03 UTC (rev 284884) +++ trunk/LayoutTests/ChangeLog 2021-10-26 18:44:31 UTC (rev 284885) @@ -1,5 +1,14 @@ 2021-10-26 Ayumi Kojima +[ macOS ] imported/w3c/web-platform-tests/hr-time/basic.html is a flaky failure. +https://bugs.webkit.org/show_bug.cgi?id=232316 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2021-10-26 Ayumi Kojima + [ BigSur wk2 Debug arm64 ] inspector/audit/run-accessibility.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=232322 Modified: trunk/LayoutTests/platform/mac/TestExpectations (284884 => 284885) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-10-26 18:32:03 UTC (rev 284884) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-10-26 18:44:31 UTC (rev 284885) @@ -1621,6 +1621,8 @@ webkit.org/b/206908 imported/w3c/web-platform-tests/hr-time/basic.any.html [ Pass Failure ] +webkit.org/b/232316 imported/w3c/web-platform-tests/hr-time/basic.html [ Pass Failure ] + webkit.org/b/207306 inspector/animation/lifecycle-css-animation.html [ Pass Failure ] webkit.org/b/112939 fast/performance/performance-now-timestamps.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284884] trunk/LayoutTests
Title: [284884] trunk/LayoutTests Revision 284884 Author ayumi_koj...@apple.com Date 2021-10-26 11:32:03 -0700 (Tue, 26 Oct 2021) Log Message [ BigSur wk2 Debug arm64 ] inspector/audit/run-accessibility.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=232322 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284883 => 284884) --- trunk/LayoutTests/ChangeLog 2021-10-26 18:26:50 UTC (rev 284883) +++ trunk/LayoutTests/ChangeLog 2021-10-26 18:32:03 UTC (rev 284884) @@ -1,3 +1,12 @@ +2021-10-26 Ayumi Kojima + +[ BigSur wk2 Debug arm64 ] inspector/audit/run-accessibility.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=232322 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2021-10-26 Chris Dumez elements should be able to fire more than one load / error event Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284883 => 284884) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-26 18:26:50 UTC (rev 284883) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-26 18:32:03 UTC (rev 284884) @@ -1659,6 +1659,8 @@ webkit.org/b/230117 [ BigSur Debug ] http/tests/inspector/network/intercept-request-with-response.html [ Pass Failure ] webkit.org/b/230117 [ BigSur Debug ] http/tests/inspector/target/pause-on-inline-debugger-statement.html [ Pass Failure ] +webkit.org/b/232322 [ BigSur Debug arm64 ] inspector/audit/run-accessibility.html [ Pass Timeout ] + webkit.org/b/230359 [ BigSur+ Debug ] webrtc/video-mute-vp8.html [ Pass Failure ] webkit.org/b/230502 [ Debug ] storage/indexeddb/request-with-null-open-db-request.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284883] trunk
Title: [284883] trunk Revision 284883 Author cdu...@apple.com Date 2021-10-26 11:26:50 -0700 (Tue, 26 Oct 2021) Log Message elements should be able to fire more than one load / error event https://bugs.webkit.org/show_bug.cgi?id=232309 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT tests that are now passing. * web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt: Source/WebCore: We had logic to only fire a single load / error event for elements, even though they could do several loads. This logic is not part of the specification and was causing us to fail some WPT tests. No new tests, unskipped existing tests. * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources): * html/HTMLLinkElement.h: LayoutTests: Unskip tests that are no longer timing out. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLLinkElement.cpp trunk/Source/WebCore/html/HTMLLinkElement.h Diff Modified: trunk/LayoutTests/ChangeLog (284882 => 284883) --- trunk/LayoutTests/ChangeLog 2021-10-26 18:19:44 UTC (rev 284882) +++ trunk/LayoutTests/ChangeLog 2021-10-26 18:26:50 UTC (rev 284883) @@ -1,3 +1,14 @@ +2021-10-26 Chris Dumez + + elements should be able to fire more than one load / error event +https://bugs.webkit.org/show_bug.cgi?id=232309 + +Reviewed by Darin Adler. + +Unskip tests that are no longer timing out. + +* TestExpectations: + 2021-10-26 Eric Hutchison [ Windows EWS ] imported/mozilla/svg/viewBox-and-pattern-03.svg is a flaky crash. Modified: trunk/LayoutTests/TestExpectations (284882 => 284883) --- trunk/LayoutTests/TestExpectations 2021-10-26 18:19:44 UTC (rev 284882) +++ trunk/LayoutTests/TestExpectations 2021-10-26 18:26:50 UTC (rev 284883) @@ -612,8 +612,6 @@ imported/w3c/web-platform-tests/html/browsers/sandboxing/sandbox-disallow-scripts-via-unsandboxed-popup.tentative.html [ Skip ] imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.transform.infinity.html [ Skip ] imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-inline-sizing/svg-inline.html [ Skip ] -imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events.html [ Skip ] -imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_navigate_ancestor-1.sub.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/forms/historical-search-event.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/anchor-with-inline-element.html [ Skip ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284882 => 284883) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 18:19:44 UTC (rev 284882) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 18:26:50 UTC (rev 284883) @@ -1,3 +1,15 @@ +2021-10-26 Chris Dumez + + elements should be able to fire more than one load / error event +https://bugs.webkit.org/show_bug.cgi?id=232309 + +Reviewed by Darin Adler. + +Rebaseline WPT tests that are now passing. + +* web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt: +* web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt: + 2021-10-26 Ziran Sun Fix CSS serialization affecting grid-auto-flow Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt (284882 => 284883) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt 2021-10-26 18:19:44 UTC (rev 284882) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt 2021-10-26 18:26:50 UTC (rev 284883) @@ -1,5 +1,3 @@ -Harness Error (TIMEOUT), message = null +PASS Check if the 's error event fires for each stylesheet it fails to load -TIMEOUT Check if the 's error event fires for each stylesheet it fails
[webkit-changes] [284882] trunk/LayoutTests
Title: [284882] trunk/LayoutTests Revision 284882 Author ehutchi...@apple.com Date 2021-10-26 11:19:44 -0700 (Tue, 26 Oct 2021) Log Message [ Windows EWS ] imported/mozilla/svg/viewBox-and-pattern-03.svg is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=232321. Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284881 => 284882) --- trunk/LayoutTests/ChangeLog 2021-10-26 18:04:42 UTC (rev 284881) +++ trunk/LayoutTests/ChangeLog 2021-10-26 18:19:44 UTC (rev 284882) @@ -1,5 +1,14 @@ 2021-10-26 Eric Hutchison +[ Windows EWS ] imported/mozilla/svg/viewBox-and-pattern-03.svg is a flaky crash. +https://bugs.webkit.org/show_bug.cgi?id=232321. + +Unreviewed test gardening. + +* platform/win/TestExpectations: + +2021-10-26 Eric Hutchison + Update test expectations for http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html. https://bugs.webkit.org/show_bug.cgi?id=231255. Modified: trunk/LayoutTests/platform/win/TestExpectations (284881 => 284882) --- trunk/LayoutTests/platform/win/TestExpectations 2021-10-26 18:04:42 UTC (rev 284881) +++ trunk/LayoutTests/platform/win/TestExpectations 2021-10-26 18:19:44 UTC (rev 284882) @@ -4730,3 +4730,5 @@ webkit.org/b/232317 js/function-apply-aliased.html [ Pass Crash ] webkit.org/b/232319 fast/ruby/before-block-doesnt-crash.html [ Pass Failure ] + +webkit.org/b/232321 imported/mozilla/svg/viewBox-and-pattern-03.svg [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284881] trunk/LayoutTests
Title: [284881] trunk/LayoutTests Revision 284881 Author ehutchi...@apple.com Date 2021-10-26 11:04:42 -0700 (Tue, 26 Oct 2021) Log Message Update test expectations for http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html. https://bugs.webkit.org/show_bug.cgi?id=231255. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284880 => 284881) --- trunk/LayoutTests/ChangeLog 2021-10-26 17:52:57 UTC (rev 284880) +++ trunk/LayoutTests/ChangeLog 2021-10-26 18:04:42 UTC (rev 284881) @@ -1,5 +1,14 @@ 2021-10-26 Eric Hutchison +Update test expectations for http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html. +https://bugs.webkit.org/show_bug.cgi?id=231255. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2021-10-26 Eric Hutchison + [ Windows ] fast/ruby/before-block-doesnt-crash.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=232319. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284880 => 284881) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-26 17:52:57 UTC (rev 284880) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-26 18:04:42 UTC (rev 284881) @@ -2243,3 +2243,5 @@ webkit.org/b/225528 http/wpt/fetch/fetch-response-body-stop-in-worker.html [ Pass Crash ] webkit.org/b/232252 [ Release ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ] + +webkit.org/b/231255 http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284880] trunk/LayoutTests
Title: [284880] trunk/LayoutTests Revision 284880 Author ehutchi...@apple.com Date 2021-10-26 10:52:57 -0700 (Tue, 26 Oct 2021) Log Message [ Windows ] fast/ruby/before-block-doesnt-crash.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=232319. Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284879 => 284880) --- trunk/LayoutTests/ChangeLog 2021-10-26 17:43:43 UTC (rev 284879) +++ trunk/LayoutTests/ChangeLog 2021-10-26 17:52:57 UTC (rev 284880) @@ -1,5 +1,14 @@ 2021-10-26 Eric Hutchison +[ Windows ] fast/ruby/before-block-doesnt-crash.html is a flaky failure. +https://bugs.webkit.org/show_bug.cgi?id=232319. + +Unreviewed test gardening. + +* platform/win/TestExpectations: + +2021-10-26 Eric Hutchison + [ Windows EWS ] js/function-apply-aliased.html is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=232317. Modified: trunk/LayoutTests/platform/win/TestExpectations (284879 => 284880) --- trunk/LayoutTests/platform/win/TestExpectations 2021-10-26 17:43:43 UTC (rev 284879) +++ trunk/LayoutTests/platform/win/TestExpectations 2021-10-26 17:52:57 UTC (rev 284880) @@ -4728,3 +4728,5 @@ webkit.org/b/232188 fast/ruby/generated-before-counter-doesnt-crash.html [ Pass Failure ] webkit.org/b/232317 js/function-apply-aliased.html [ Pass Crash ] + +webkit.org/b/232319 fast/ruby/before-block-doesnt-crash.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284879] trunk/LayoutTests
Title: [284879] trunk/LayoutTests Revision 284879 Author ehutchi...@apple.com Date 2021-10-26 10:43:43 -0700 (Tue, 26 Oct 2021) Log Message [ Windows EWS ] js/function-apply-aliased.html is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=232317. Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284878 => 284879) --- trunk/LayoutTests/ChangeLog 2021-10-26 17:39:19 UTC (rev 284878) +++ trunk/LayoutTests/ChangeLog 2021-10-26 17:43:43 UTC (rev 284879) @@ -1,5 +1,14 @@ 2021-10-26 Eric Hutchison +[ Windows EWS ] js/function-apply-aliased.html is a flaky crash. +https://bugs.webkit.org/show_bug.cgi?id=232317. + +Unreviewed test gardening. + +* platform/win/TestExpectations: + +2021-10-26 Eric Hutchison + [ Catalina Debug wk1 EWS ] media/track/track-disabled.html is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=232315. Modified: trunk/LayoutTests/platform/win/TestExpectations (284878 => 284879) --- trunk/LayoutTests/platform/win/TestExpectations 2021-10-26 17:39:19 UTC (rev 284878) +++ trunk/LayoutTests/platform/win/TestExpectations 2021-10-26 17:43:43 UTC (rev 284879) @@ -4727,3 +4727,4 @@ webkit.org/b/232188 fast/ruby/generated-before-counter-doesnt-crash.html [ Pass Failure ] +webkit.org/b/232317 js/function-apply-aliased.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284878] trunk/Tools
Title: [284878] trunk/Tools
Revision 284878
Author simon.fra...@apple.com
Date 2021-10-26 10:39:19 -0700 (Tue, 26 Oct 2021)
Log Message
The script should decide when an image diff cases, not ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=232225
Reviewed by Martin Robinson.
Rather than have ImageDiff decide if the comparison passes or fails (with some built-in
tolerance), have it just print the percentage difference, and have the script compare it
against the tolerance.
Code to prettify diff_percent is moved into the script (but should eventually
move closer to display time).
* ImageDiff/ImageDiff.cpp:
(processImages):
* Scripts/webkitpy/port/image_diff.py:
(ImageDiffer._read):
* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_diff_image.make_proc):
(PortTestCase.test_diff_image_passed):
(PortTestCase):
(PortTestCase.test_diff_image_passed_with_tolerance):
(PortTestCase.test_diff_image_failed_with_rounded_diff):
(PortTestCase.test_diff_image_failed):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/ImageDiff/ImageDiff.cpp
trunk/Tools/Scripts/webkitpy/port/image_diff.py
trunk/Tools/Scripts/webkitpy/port/port_testcase.py
Diff
Modified: trunk/Tools/ChangeLog (284877 => 284878)
--- trunk/Tools/ChangeLog 2021-10-26 17:28:34 UTC (rev 284877)
+++ trunk/Tools/ChangeLog 2021-10-26 17:39:19 UTC (rev 284878)
@@ -1,3 +1,29 @@
+2021-10-26 Simon Fraser
+
+The script should decide when an image diff cases, not ImageDiff
+https://bugs.webkit.org/show_bug.cgi?id=232225
+
+Reviewed by Martin Robinson.
+
+Rather than have ImageDiff decide if the comparison passes or fails (with some built-in
+tolerance), have it just print the percentage difference, and have the script compare it
+against the tolerance.
+
+Code to prettify diff_percent is moved into the script (but should eventually
+move closer to display time).
+
+* ImageDiff/ImageDiff.cpp:
+(processImages):
+* Scripts/webkitpy/port/image_diff.py:
+(ImageDiffer._read):
+* Scripts/webkitpy/port/port_testcase.py:
+(PortTestCase.test_diff_image.make_proc):
+(PortTestCase.test_diff_image_passed):
+(PortTestCase):
+(PortTestCase.test_diff_image_passed_with_tolerance):
+(PortTestCase.test_diff_image_failed_with_rounded_diff):
+(PortTestCase.test_diff_image_failed):
+
2021-10-26 Kate Cheney
[ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
Modified: trunk/Tools/ImageDiff/ImageDiff.cpp (284877 => 284878)
--- trunk/Tools/ImageDiff/ImageDiff.cpp 2021-10-26 17:28:34 UTC (rev 284877)
+++ trunk/Tools/ImageDiff/ImageDiff.cpp 2021-10-26 17:39:19 UTC (rev 284878)
@@ -65,21 +65,10 @@
PlatformImage::Difference differenceData = { 100, 0, 0 };
auto diffImage = actualImage->difference(*baselineImage, differenceData);
-float legacyDifference = differenceData.percentageDifference;
-if (legacyDifference <= tolerance)
-legacyDifference = 0.0f;
-else {
-legacyDifference = roundf(legacyDifference * 100.0f) / 100.0f;
-legacyDifference = std::max(legacyDifference, 0.01f); // round to 2 decimal places
-}
-
if (diffImage)
diffImage->writeAsPNGToStdout();
-if (legacyDifference > 0.0f) {
-fprintf(stdout, "diff: %01.2f%% failed\n", legacyDifference);
-} else
-fprintf(stdout, "diff: %01.2f%% passed\n", legacyDifference);
+fprintf(stdout, "diff: %01.8f%%\n", differenceData.percentageDifference);
if (printDifference)
fprintf(stdout, "maxDifference=%u; totalPixels=%lu\n", differenceData.maxDifference, differenceData.totalPixels);
Modified: trunk/Tools/Scripts/webkitpy/port/image_diff.py (284877 => 284878)
--- trunk/Tools/Scripts/webkitpy/port/image_diff.py 2021-10-26 17:28:34 UTC (rev 284877)
+++ trunk/Tools/Scripts/webkitpy/port/image_diff.py 2021-10-26 17:39:19 UTC (rev 284878)
@@ -129,15 +129,23 @@
if self._process.has_crashed():
err_str += "ImageDiff crashed\n"
-diff_percent = 0
-if diff_output:
-m = re.match(b'diff: (.+)% (passed|failed)', diff_output)
-if m.group(2) == b'passed':
-return ImageDiffResult(passed=True, diff_image=output_image, difference=0)
-diff_percent = float(string_utils.decode(m.group(1), target_type=str))
+if not diff_output:
+return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or "Failed to read ImageDiff output")
-return ImageDiffResult(passed=False, diff_image=output_image, difference=diff_percent, tolerance=self._tolerance, error_string=err_str or None)
+m = re.match(b'diff: (.+)%', diff_output)
+if not m:
+return ImageDiffResult(passed=False, diff_image=None, difference=0,
[webkit-changes] [284877] trunk/LayoutTests
Title: [284877] trunk/LayoutTests Revision 284877 Author ehutchi...@apple.com Date 2021-10-26 10:28:34 -0700 (Tue, 26 Oct 2021) Log Message [ Catalina Debug wk1 EWS ] media/track/track-disabled.html is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=232315. Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284876 => 284877) --- trunk/LayoutTests/ChangeLog 2021-10-26 17:08:08 UTC (rev 284876) +++ trunk/LayoutTests/ChangeLog 2021-10-26 17:28:34 UTC (rev 284877) @@ -1,3 +1,12 @@ +2021-10-26 Eric Hutchison + +[ Catalina Debug wk1 EWS ] media/track/track-disabled.html is a flaky crash. +https://bugs.webkit.org/show_bug.cgi?id=232315. + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2021-10-26 Ayumi Kojima [ iOS Release ] fast/flexbox/aspect-ratio-intrinsic-adjust.html is a flaky image failure. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (284876 => 284877) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-10-26 17:08:08 UTC (rev 284876) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-10-26 17:28:34 UTC (rev 284877) @@ -1496,3 +1496,5 @@ webkit.org/b/232283 imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html [ Pass Failure ] webkit.org/b/232283 imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html [ Pass Failure ] + +webkit.org/b/232315 [ Catalina Debug ] media/track/track-disabled.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284876] trunk
Title: [284876] trunk
Revision 284876
Author z...@igalia.com
Date 2021-10-26 10:08:08 -0700 (Tue, 26 Oct 2021)
Log Message
Fix CSS serialization affecting grid-auto-flow
https://bugs.webkit.org/show_bug.cgi?id=232240
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Update the following test and expectation files -
* LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
* LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:
* LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
* LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html:
* web-platform-tests/css/css-grid/grid-layout-properties-expected.txt:
* web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt:
* web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt:
* web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html:
Source/WebCore:
This is to fix the serialization issue of grid-auto-flow where the word 'row' has been
included necessarily.
This Change is an import of chromium CL at
https://chromium-review.googlesource.com/c/chromium/src/+/3179598
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeGridAutoFlow):
Modified Paths
trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html
trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
Diff
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt (284875 => 284876)
--- trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt 2021-10-26 17:08:08 UTC (rev 284876)
@@ -6,11 +6,11 @@
Test getting grid-auto-flow set through CSS
PASS window.getComputedStyle(gridAutoFlowColumnSparse, '').getPropertyValue('grid-auto-flow') is 'column'
PASS window.getComputedStyle(gridAutoFlowRowSparse, '').getPropertyValue('grid-auto-flow') is 'row'
-PASS window.getComputedStyle(gridAutoFlowDense, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(gridAutoFlowDense, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS window.getComputedStyle(gridAutoFlowColumnDense, '').getPropertyValue('grid-auto-flow') is 'column dense'
-PASS window.getComputedStyle(gridAutoFlowRowDense, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(gridAutoFlowRowDense, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS window.getComputedStyle(gridAutoFlowDenseColumn, '').getPropertyValue('grid-auto-flow') is 'column dense'
-PASS window.getComputedStyle(gridAutoFlowDenseRow, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(gridAutoFlowDenseRow, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS window.getComputedStyle(gridAutoFlowInherit, '').getPropertyValue('grid-auto-flow') is 'column'
PASS window.getComputedStyle(gridAutoFlowNoInherit, '').getPropertyValue('grid-auto-flow') is 'row'
@@ -32,13 +32,13 @@
PASS element.style.gridAutoFlow is 'column dense'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'column dense'
PASS element.style.gridAutoFlow is 'dense'
-PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
-PASS element.style.gridAutoFlow is 'row dense'
-PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'dense'
+PASS element.style.gridAutoFlow is 'dense'
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS element.style.gridAutoFlow is 'column dense'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'column dense'
-PASS element.style.gridAutoFlow is 'row dense'
-PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS element.style.gridAutoFlow is 'dense'
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is
[webkit-changes] [284875] trunk
Title: [284875] trunk
Revision 284875
Author katherine_che...@apple.com
Date 2021-10-26 10:06:43 -0700 (Tue, 26 Oct 2021)
Log Message
[ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
https://bugs.webkit.org/show_bug.cgi?id=232292
Reviewed by Brent Fulgham.
Source/WebKit:
Update session restore code to also set the app initiated value on
the current document loader. Previously, this was only set on the new
document loader. This is a problem because the main resource load
uses the old document loader, so if we restore from a previous session
state, the main resource load will have the incorrect attribution
value.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goToBackForwardItem):
Tools:
Update API test in 2 ways. First, close the original WebView to
destroy the page's document loader as if the application was being
quit. Second, clear history to make sure there are no cached loads.
* TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284874 => 284875)
--- trunk/Source/WebKit/ChangeLog 2021-10-26 16:24:04 UTC (rev 284874)
+++ trunk/Source/WebKit/ChangeLog 2021-10-26 17:06:43 UTC (rev 284875)
@@ -1,3 +1,21 @@
+2021-10-26 Kate Cheney
+
+[ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
+https://bugs.webkit.org/show_bug.cgi?id=232292
+
+
+Reviewed by Brent Fulgham.
+
+Update session restore code to also set the app initiated value on
+the current document loader. Previously, this was only set on the new
+document loader. This is a problem because the main resource load
+uses the old document loader, so if we restore from a previous session
+state, the main resource load will have the incorrect attribution
+value.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::goToBackForwardItem):
+
2021-10-26 Chris Dumez
Improve didFailProvisionalLoadForFrame logging to indicate if it is for the main frame
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (284874 => 284875)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-10-26 16:24:04 UTC (rev 284874)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-10-26 17:06:43 UTC (rev 284875)
@@ -1894,6 +1894,8 @@
SendStopResponsivenessTimer stopper;
m_lastNavigationWasAppInitiated = lastNavigationWasAppInitiated;
+if (auto* documentLoader = corePage()->mainFrame().loader().documentLoader())
+documentLoader->setLastNavigationWasAppInitiated(lastNavigationWasAppInitiated);
ASSERT(isBackForwardLoadType(backForwardType));
Modified: trunk/Tools/ChangeLog (284874 => 284875)
--- trunk/Tools/ChangeLog 2021-10-26 16:24:04 UTC (rev 284874)
+++ trunk/Tools/ChangeLog 2021-10-26 17:06:43 UTC (rev 284875)
@@ -1,3 +1,17 @@
+2021-10-26 Kate Cheney
+
+[ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
+https://bugs.webkit.org/show_bug.cgi?id=232292
+
+
+Reviewed by Brent Fulgham.
+
+Update API test in 2 ways. First, close the original WebView to
+destroy the page's document loader as if the application was being
+quit. Second, clear history to make sure there are no cached loads.
+
+* TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
+
2021-10-26 Simon Fraser
Have ImageDiff print the diff image when any pixel is different
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm (284874 => 284875)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2021-10-26 16:24:04 UTC (rev 284874)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2021-10-26 17:06:43 UTC (rev 284875)
@@ -747,16 +747,21 @@
RetainPtr<_WKSessionState> sessionState = [webView1 _sessionState];
sessionState.get().isAppInitiated = isAppInitiated == IsAppInitiated::Yes ? true : false;
-webView1 = nullptr;
+[webView1 _close];
+static bool isDone = false;
+[[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() {
+isDone = true;
+}];
+TestWebKitAPI::Util::run();
+
auto webView2 = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
-
[webView2 _restoreSessionState:sessionState.get() andNavigate:YES];
[webView2 _test_waitForDidFinishNavigation];
EXPECT_WK_STREQ(@"https://www.apple.com/", [[webView2 URL] absoluteString]);
-static bool isDone = false;
+isDone = false;
bool
[webkit-changes] [284874] trunk/Source/WebKit
Title: [284874] trunk/Source/WebKit
Revision 284874
Author cdu...@apple.com
Date 2021-10-26 09:24:04 -0700 (Tue, 26 Oct 2021)
Log Message
Improve didFailProvisionalLoadForFrame logging to indicate if it is for the main frame
https://bugs.webkit.org/show_bug.cgi?id=232273
Reviewed by Darin Adler.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (284873 => 284874)
--- trunk/Source/WebKit/ChangeLog 2021-10-26 16:21:29 UTC (rev 284873)
+++ trunk/Source/WebKit/ChangeLog 2021-10-26 16:24:04 UTC (rev 284874)
@@ -1,3 +1,13 @@
+2021-10-26 Chris Dumez
+
+Improve didFailProvisionalLoadForFrame logging to indicate if it is for the main frame
+https://bugs.webkit.org/show_bug.cgi?id=232273
+
+Reviewed by Darin Adler.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
+
2021-10-26 Per Arne
[iOS][WP] Reduce sandbox telemetry
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (284873 => 284874)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-10-26 16:21:29 UTC (rev 284873)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-10-26 16:24:04 UTC (rev 284874)
@@ -4800,7 +4800,7 @@
void WebPageProxy::didFailProvisionalLoadForFrameShared(Ref&& process, WebFrameProxy& frame, FrameInfoData&& frameInfo, WebCore::ResourceRequest&& request, uint64_t navigationID, const String& provisionalURL, const ResourceError& error, WillContinueLoading willContinueLoading, const UserData& userData)
{
LOG(Loading, "(Loading) WebPageProxy %" PRIu64 " in web process pid %i didFailProvisionalLoadForFrame to provisionalURL %s", m_identifier.toUInt64(), process->processIdentifier(), provisionalURL.utf8().data());
-WEBPAGEPROXY_RELEASE_LOG_ERROR(Process, "didFailProvisionalLoadForFrame: frameID=%" PRIu64 ", domain=%s, code=%d", frame.frameID().toUInt64(), error.domain().utf8().data(), error.errorCode());
+WEBPAGEPROXY_RELEASE_LOG_ERROR(Process, "didFailProvisionalLoadForFrame: frameID=%" PRIu64 ", domain=%s, code=%d, isMainFrame=%d", frame.frameID().toUInt64(), error.domain().utf8().data(), error.errorCode(), frame.isMainFrame());
PageClientProtector protector(pageClient());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284873] trunk/LayoutTests
Title: [284873] trunk/LayoutTests Revision 284873 Author ayumi_koj...@apple.com Date 2021-10-26 09:21:29 -0700 (Tue, 26 Oct 2021) Log Message [ iOS Release ] fast/flexbox/aspect-ratio-intrinsic-adjust.html is a flaky image failure. https://bugs.webkit.org/show_bug.cgi?id=232310 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284872 => 284873) --- trunk/LayoutTests/ChangeLog 2021-10-26 16:03:28 UTC (rev 284872) +++ trunk/LayoutTests/ChangeLog 2021-10-26 16:21:29 UTC (rev 284873) @@ -1,3 +1,12 @@ +2021-10-26 Ayumi Kojima + +[ iOS Release ] fast/flexbox/aspect-ratio-intrinsic-adjust.html is a flaky image failure. +https://bugs.webkit.org/show_bug.cgi?id=232310 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-10-26 Chris Dumez Regression (r284821) : [ iOS 15 ] fast/events/ios/submit-form-target-blank-using-return-key.html is a timeout Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284872 => 284873) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-26 16:03:28 UTC (rev 284872) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-26 16:21:29 UTC (rev 284873) @@ -2232,6 +2232,8 @@ webkit.org/b/231714 fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow.html [ Pass Timeout ] +webkit.org/b/232310 [ Release ] fast/flexbox/aspect-ratio-intrinsic-adjust.html [ Pass ImageOnlyFailure ] + webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ] webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284872] trunk/LayoutTests
Title: [284872] trunk/LayoutTests Revision 284872 Author cdu...@apple.com Date 2021-10-26 09:03:28 -0700 (Tue, 26 Oct 2021) Log Message Regression (r284821) : [ iOS 15 ] fast/events/ios/submit-form-target-blank-using-return-key.html is a timeout https://bugs.webkit.org/show_bug.cgi?id=232306 Unreviewed, add rel="opener" to the form since it has target="_blank" and the test still expects an opener. * fast/events/ios/submit-form-target-blank-using-return-key.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key.html Diff Modified: trunk/LayoutTests/ChangeLog (284871 => 284872) --- trunk/LayoutTests/ChangeLog 2021-10-26 16:00:24 UTC (rev 284871) +++ trunk/LayoutTests/ChangeLog 2021-10-26 16:03:28 UTC (rev 284872) @@ -1,3 +1,14 @@ +2021-10-26 Chris Dumez + +Regression (r284821) : [ iOS 15 ] fast/events/ios/submit-form-target-blank-using-return-key.html is a timeout +https://bugs.webkit.org/show_bug.cgi?id=232306 + + +Unreviewed, add rel="opener" to the form since it has target="_blank" and the test still expects an +opener. + +* fast/events/ios/submit-form-target-blank-using-return-key.html: + 2021-10-26 Gabriel Nava Marino ASSERT(parent->element()) triggered in Styleable::fromRenderer Modified: trunk/LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key.html (284871 => 284872) --- trunk/LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key.html 2021-10-26 16:00:24 UTC (rev 284871) +++ trunk/LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key.html 2021-10-26 16:03:28 UTC (rev 284872) @@ -6,7 +6,7 @@ - + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284871] trunk
Title: [284871] trunk
Revision 284871
Author commit-qu...@webkit.org
Date 2021-10-26 09:00:24 -0700 (Tue, 26 Oct 2021)
Log Message
ASSERT(parent->element()) triggered in Styleable::fromRenderer
https://bugs.webkit.org/show_bug.cgi?id=232185
Patch by Gabriel Nava Marino on 2021-10-26
Reviewed by Tim Nguyen and Antti Koivisto.
Source/WebCore:
The marker renderer can be set as a child of RenderMultiColumnFlowThread
instead of RenderListItem in some instances. RenderMultiColumnFlowThread is
an anonymous box and doesn't have an associated element, so we instead should
loop through the parents until we find the RenderListItem which does have an
associated element.
Test: fast/animation/css-animation-marker-crash.html
* style/Styleable.cpp:
(WebCore::Styleable::fromRenderer):
LayoutTests:
* fast/animation/css-animation-marker-crash-expected.txt: Added.
* fast/animation/css-animation-marker-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/Styleable.cpp
Added Paths
trunk/LayoutTests/fast/animation/css-animation-marker-crash-expected.txt
trunk/LayoutTests/fast/animation/css-animation-marker-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284870 => 284871)
--- trunk/LayoutTests/ChangeLog 2021-10-26 15:55:48 UTC (rev 284870)
+++ trunk/LayoutTests/ChangeLog 2021-10-26 16:00:24 UTC (rev 284871)
@@ -1,3 +1,13 @@
+2021-10-26 Gabriel Nava Marino
+
+ASSERT(parent->element()) triggered in Styleable::fromRenderer
+https://bugs.webkit.org/show_bug.cgi?id=232185
+
+Reviewed by Tim Nguyen and Antti Koivisto.
+
+* fast/animation/css-animation-marker-crash-expected.txt: Added.
+* fast/animation/css-animation-marker-crash.html: Added.
+
2021-10-26 Martin Robinson
Update import of css/css-transform WPT tests
Added: trunk/LayoutTests/fast/animation/css-animation-marker-crash-expected.txt (0 => 284871)
--- trunk/LayoutTests/fast/animation/css-animation-marker-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/animation/css-animation-marker-crash-expected.txt 2021-10-26 16:00:24 UTC (rev 284871)
@@ -0,0 +1 @@
+PASS if this doesn't crash
Added: trunk/LayoutTests/fast/animation/css-animation-marker-crash.html (0 => 284871)
--- trunk/LayoutTests/fast/animation/css-animation-marker-crash.html (rev 0)
+++ trunk/LayoutTests/fast/animation/css-animation-marker-crash.html 2021-10-26 16:00:24 UTC (rev 284871)
@@ -0,0 +1,19 @@
+
+ @keyframes a0 {
+from {
+ opacity: 0;
+}
+ }
+ ::marker {
+animation-name: a0;
+animation-duration: 1ms;
+ }
+ li {
+columns: 3;
+ }
+
+PASS if this doesn't crash
+
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
Modified: trunk/Source/WebCore/ChangeLog (284870 => 284871)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 15:55:48 UTC (rev 284870)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 16:00:24 UTC (rev 284871)
@@ -1,3 +1,21 @@
+2021-10-26 Gabriel Nava Marino
+
+ASSERT(parent->element()) triggered in Styleable::fromRenderer
+https://bugs.webkit.org/show_bug.cgi?id=232185
+
+Reviewed by Tim Nguyen and Antti Koivisto.
+
+The marker renderer can be set as a child of RenderMultiColumnFlowThread
+instead of RenderListItem in some instances. RenderMultiColumnFlowThread is
+an anonymous box and doesn't have an associated element, so we instead should
+loop through the parents until we find the RenderListItem which does have an
+associated element.
+
+Test: fast/animation/css-animation-marker-crash.html
+
+* style/Styleable.cpp:
+(WebCore::Styleable::fromRenderer):
+
2021-10-26 Philippe Normand
REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
Modified: trunk/Source/WebCore/style/Styleable.cpp (284870 => 284871)
--- trunk/Source/WebCore/style/Styleable.cpp 2021-10-26 15:55:48 UTC (rev 284870)
+++ trunk/Source/WebCore/style/Styleable.cpp 2021-10-26 16:00:24 UTC (rev 284871)
@@ -61,11 +61,12 @@
}
break;
case PseudoId::Marker:
-if (auto* parent = renderer.parent()) {
-ASSERT(parent->element());
-ASSERT(is(parent));
-ASSERT(downcast(*parent).markerRenderer() == );
-return Styleable(*parent->element(), PseudoId::Marker);
+if (auto* ancestor = renderer.parent()) {
+while (ancestor && !ancestor->element())
+ancestor = ancestor->parent();
+ASSERT(is(ancestor));
+ASSERT(downcast(ancestor)->markerRenderer() == );
+return Styleable(*ancestor->element(), PseudoId::Marker);
}
break;
case PseudoId::After:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [284870] trunk/Tools
Title: [284870] trunk/Tools
Revision 284870
Author simon.fra...@apple.com
Date 2021-10-26 08:55:48 -0700 (Tue, 26 Oct 2021)
Log Message
Have ImageDiff print the diff image when any pixel is different
https://bugs.webkit.org/show_bug.cgi?id=232294
Reviewed by Martin Robinson.
ImageDiff currently only outputs the diff image when any pixel exceeds its built-in
tolerance.
To prepare for moving the "pass/fail" decision to script, have ImageDiff output the diff
image when any pixel is different. Also have it write "#EOF" so that we're not reliant on
the "diff:" line to terminate reading the output.
Fix up webkitpy unit tests for #EOF parsing, presence of image when the test passes via
tolerance, and to actually test which image data is present in the ImageDiffResult.
* ImageDiff/ImageDiff.cpp:
(processImages):
(main):
* ImageDiff/PlatformImage.cpp:
(ImageDiff::PlatformImage::difference): Track legacyDistanceMax if any pixel diff is non-zero,
since it's needed to scale the diff image.
* Scripts/webkitpy/port/image_diff.py:
(ImageDiffer._read): Look for "#EOF" to terminate the output. Save the diff image, even
if the test passed.
* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_diff_image.make_proc):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image_passed):
(PortTestCase.test_diff_image_failed):
(PortTestCase.test_diff_image_crashed):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/ImageDiff/ImageDiff.cpp
trunk/Tools/ImageDiff/PlatformImage.cpp
trunk/Tools/Scripts/webkitpy/port/image_diff.py
trunk/Tools/Scripts/webkitpy/port/port_testcase.py
Diff
Modified: trunk/Tools/ChangeLog (284869 => 284870)
--- trunk/Tools/ChangeLog 2021-10-26 15:55:18 UTC (rev 284869)
+++ trunk/Tools/ChangeLog 2021-10-26 15:55:48 UTC (rev 284870)
@@ -1,5 +1,38 @@
2021-10-26 Simon Fraser
+Have ImageDiff print the diff image when any pixel is different
+https://bugs.webkit.org/show_bug.cgi?id=232294
+
+Reviewed by Martin Robinson.
+
+ImageDiff currently only outputs the diff image when any pixel exceeds its built-in
+tolerance.
+
+To prepare for moving the "pass/fail" decision to script, have ImageDiff output the diff
+image when any pixel is different. Also have it write "#EOF" so that we're not reliant on
+the "diff:" line to terminate reading the output.
+
+Fix up webkitpy unit tests for #EOF parsing, presence of image when the test passes via
+tolerance, and to actually test which image data is present in the ImageDiffResult.
+
+* ImageDiff/ImageDiff.cpp:
+(processImages):
+(main):
+* ImageDiff/PlatformImage.cpp:
+(ImageDiff::PlatformImage::difference): Track legacyDistanceMax if any pixel diff is non-zero,
+since it's needed to scale the diff image.
+* Scripts/webkitpy/port/image_diff.py:
+(ImageDiffer._read): Look for "#EOF" to terminate the output. Save the diff image, even
+if the test passed.
+* Scripts/webkitpy/port/port_testcase.py:
+(PortTestCase.test_diff_image.make_proc):
+(PortTestCase.test_diff_image):
+(PortTestCase.test_diff_image_passed):
+(PortTestCase.test_diff_image_failed):
+(PortTestCase.test_diff_image_crashed):
+
+2021-10-26 Simon Fraser
+
Don't run ImageDiff a second time to generate diff images
https://bugs.webkit.org/show_bug.cgi?id=232288
Modified: trunk/Tools/ImageDiff/ImageDiff.cpp (284869 => 284870)
--- trunk/Tools/ImageDiff/ImageDiff.cpp 2021-10-26 15:55:18 UTC (rev 284869)
+++ trunk/Tools/ImageDiff/ImageDiff.cpp 2021-10-26 15:55:48 UTC (rev 284870)
@@ -73,9 +73,10 @@
legacyDifference = std::max(legacyDifference, 0.01f); // round to 2 decimal places
}
+if (diffImage)
+diffImage->writeAsPNGToStdout();
+
if (legacyDifference > 0.0f) {
-if (diffImage)
-diffImage->writeAsPNGToStdout();
fprintf(stdout, "diff: %01.2f%% failed\n", legacyDifference);
} else
fprintf(stdout, "diff: %01.2f%% passed\n", legacyDifference);
@@ -83,6 +84,9 @@
if (printDifference)
fprintf(stdout, "maxDifference=%u; totalPixels=%lu\n", differenceData.maxDifference, differenceData.totalPixels);
+fprintf(stdout, "#EOF\n");
+fflush(stdout);
+
return EXIT_SUCCESS;
}
@@ -222,7 +226,6 @@
if (result != EXIT_SUCCESS)
return result;
}
-fflush(stdout);
}
return EXIT_SUCCESS;
Modified: trunk/Tools/ImageDiff/PlatformImage.cpp (284869 => 284870)
--- trunk/Tools/ImageDiff/PlatformImage.cpp 2021-10-26 15:55:18 UTC (rev 284869)
+++ trunk/Tools/ImageDiff/PlatformImage.cpp 2021-10-26 15:55:48 UTC (rev 284870)
@@ -73,6 +73,8 @@
unsigned blueDiff = std::abs(pixel[2] - basePixel[2]);
unsigned maxDiff = std::max({ redDiff, greenDiff, blueDiff });
[webkit-changes] [284868] trunk/Source/JavaScriptCore
Title: [284868] trunk/Source/_javascript_Core
Revision 284868
Author commit-qu...@webkit.org
Date 2021-10-26 08:52:37 -0700 (Tue, 26 Oct 2021)
Log Message
[JSC] Improve offlineasm debug annotations for Linux/ELF
https://bugs.webkit.org/show_bug.cgi?id=232303
Patch by Xan López on 2021-10-26
Reviewed by Mark Lam.
This patch does two things:
Add the .size and .type directives to every llint "function"
(global, llint opcode, 'glue'). This allows a debugger to tell you
in what logical function you are inside the giant chunk of code
that is the llint interpreter. So instead of something like this:
(gdb) x/5i $pc
=> 0xf5f8af60 : b.n 0xf5f8af6c
0xf5f8af62 : ldr r2, [r7, #8]
0xf5f8af64 : ldr r2, [r2, #28]
0xf5f8af66 : subsr0, #16
0xf5f8af68 : ldr.w r0, [r2, r0, lsl #3]
you get something like this:
(gdb) x/5i $pc
=> 0xf5f8c770 : bge.n 0xf5f8c77c
0xf5f8c772 : add.w r6, r7, r9, lsl #3
0xf5f8c776 : vldrd0, [r6]
0xf5f8c77a : b.n 0xf5f8c78c
0xf5f8c77c : ldr r2, [r7, #8]
The other change adds a local symbol (in addition to an internal
label) to all the "glue" labels. That allows wasm opcodes to be
seen by the debugger (and the user to break on them), among other
things.
* CMakeLists.txt: tell offlineasm we use the ELF binary format on Linux.
* llint/LowLevelInterpreter.cpp: emit a non-local label for "glue" labels.
* offlineasm/asm.rb: emit the .size and .type directives for every
llint "function" on ELF systems.
Modified Paths
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp
trunk/Source/_javascript_Core/offlineasm/asm.rb
Diff
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (284867 => 284868)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2021-10-26 15:23:12 UTC (rev 284867)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2021-10-26 15:52:37 UTC (rev 284868)
@@ -441,6 +441,10 @@
set(LLIntOutput LLIntAssembly.h)
endif ()
+if (CMAKE_SYSTEM_NAME MATCHES "Linux")
+set(OFFLINE_ASM_ARGS --binary-format=ELF)
+endif ()
+
add_custom_command(
OUTPUT ${_javascript_Core_DERIVED_SOURCES_DIR}/${LLIntOutput}
MAIN_DEPENDENCY ${_javascript_CORE_DIR}/offlineasm/asm.rb
Modified: trunk/Source/_javascript_Core/ChangeLog (284867 => 284868)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-26 15:23:12 UTC (rev 284867)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-26 15:52:37 UTC (rev 284868)
@@ -1,3 +1,43 @@
+2021-10-26 Xan López
+
+[JSC] Improve offlineasm debug annotations for Linux/ELF
+https://bugs.webkit.org/show_bug.cgi?id=232303
+
+Reviewed by Mark Lam.
+
+This patch does two things:
+
+Add the .size and .type directives to every llint "function"
+(global, llint opcode, 'glue'). This allows a debugger to tell you
+in what logical function you are inside the giant chunk of code
+that is the llint interpreter. So instead of something like this:
+
+(gdb) x/5i $pc
+ => 0xf5f8af60 : b.n 0xf5f8af6c
+ 0xf5f8af62 : ldr r2, [r7, #8]
+ 0xf5f8af64 : ldr r2, [r2, #28]
+ 0xf5f8af66 : subsr0, #16
+ 0xf5f8af68 : ldr.w r0, [r2, r0, lsl #3]
+
+you get something like this:
+
+(gdb) x/5i $pc
+ => 0xf5f8c770 : bge.n 0xf5f8c77c
+ 0xf5f8c772 : add.w r6, r7, r9, lsl #3
+ 0xf5f8c776 : vldrd0, [r6]
+ 0xf5f8c77a : b.n 0xf5f8c78c
+ 0xf5f8c77c : ldr r2, [r7, #8]
+
+The other change adds a local symbol (in addition to an internal
+label) to all the "glue" labels. That allows wasm opcodes to be
+seen by the debugger (and the user to break on them), among other
+things.
+
+* CMakeLists.txt: tell offlineasm we use the ELF binary format on Linux.
+* llint/LowLevelInterpreter.cpp: emit a non-local label for "glue" labels.
+* offlineasm/asm.rb: emit the .size and .type directives for every
+llint "function" on ELF systems.
+
2021-10-25 Yusuke Suzuki
[JSC] Fix stale assertion in InternalFunctionAllocationProfile after r284757
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (284867 => 284868)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2021-10-26 15:23:12 UTC (rev 284867)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2021-10-26 15:52:37 UTC (rev 284868)
@@ -490,7 +490,9 @@
OFFLINE_ASM_OPCODE_DEBUG_LABEL(llint_##__opcode) \
OFFLINE_ASM_LOCAL_LABEL(llint_##__opcode)
-#define OFFLINE_ASM_GLUE_LABEL(__opcode) OFFLINE_ASM_LOCAL_LABEL(__opcode)
+#define OFFLINE_ASM_GLUE_LABEL(__opcode) \
+OFFLINE_ASM_OPCODE_DEBUG_LABEL(__opcode) \
+OFFLINE_ASM_LOCAL_LABEL(__opcode)
#if
[webkit-changes] [284867] trunk
Title: [284867] trunk
Revision 284867
Author commit-qu...@webkit.org
Date 2021-10-26 08:23:12 -0700 (Tue, 26 Oct 2021)
Log Message
REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=231061
Patch by Philippe Normand on 2021-10-26
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Implement WebGL canvas sampling for GStreamer ports.
* platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample):
LayoutTests:
* platform/glib/TestExpectations: Test is passing now. Unflag.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (284866 => 284867)
--- trunk/LayoutTests/ChangeLog 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/LayoutTests/ChangeLog 2021-10-26 15:23:12 UTC (rev 284867)
@@ -1,3 +1,13 @@
+2021-10-26 Philippe Normand
+
+REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
+https://bugs.webkit.org/show_bug.cgi?id=231061
+
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* platform/glib/TestExpectations: Test is passing now. Unflag.
+
2021-10-26 Antti Koivisto
Fix ::part(foo):hover
Modified: trunk/LayoutTests/platform/glib/TestExpectations (284866 => 284867)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-10-26 15:23:12 UTC (rev 284867)
@@ -680,7 +680,6 @@
webkit.org/b/79203 fast/mediastream/RTCRtpSender-replaceTrack.html [ Failure ]
webkit.org/b/187603 fast/mediastream/media-stream-track-source-failure.html [ Timeout Failure Pass ]
webkit.org/b/231057 fast/mediastream/media-stream-video-track-interrupted.html [ Failure ]
-webkit.org/b/231061 fast/mediastream/captureStream/canvas3d.html [ Timeout ]
webkit.org/b/223508 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html [ Failure Pass ]
Modified: trunk/Source/WebCore/ChangeLog (284866 => 284867)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 15:23:12 UTC (rev 284867)
@@ -1,3 +1,16 @@
+2021-10-26 Philippe Normand
+
+REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
+https://bugs.webkit.org/show_bug.cgi?id=231061
+
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Implement WebGL canvas sampling for GStreamer ports.
+
+* platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
+(WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample):
+
2021-10-26 Antti Koivisto
Fix ::part(foo):hover
Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp (284866 => 284867)
--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp 2021-10-26 15:23:12 UTC (rev 284867)
@@ -45,6 +45,10 @@
#include "MediaSample.h"
#endif
+#if USE(GSTREAMER) && ENABLE(MEDIA_STREAM)
+#include "MediaSampleGStreamer.h"
+#endif
+
namespace WebCore {
#if !PLATFORM(COCOA)
@@ -186,6 +190,10 @@
#if !PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)
RefPtr GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample()
{
+#if USE(GSTREAMER)
+if (auto pixelBuffer = readCompositedResults())
+return MediaSampleGStreamer::createImageSample(WTFMove(*pixelBuffer));
+#endif
return nullptr;
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284866] trunk/Tools
Title: [284866] trunk/Tools Revision 284866 Author simon.fra...@apple.com Date 2021-10-26 08:04:13 -0700 (Tue, 26 Oct 2021) Log Message Don't run ImageDiff a second time to generate diff images https://bugs.webkit.org/show_bug.cgi?id=232288 Reviewed by Martin Robinson. Currently, for a ref test failure (which is always run with tolerance=0), we run ImageDiff a second time in FailureReftestMismatch.write_failure() with the intent of generating a diff image with zero tolerance. Fix by storing the ImageDiffResult in FailureReftestMismatch and FailureImageHashMismatch so we already have the diff image. We only regenerate it when the first diff was run with a non-zero tolerance (only relevant for pixel tests). To faciliate this, store the tolerance that was used inside ImageDiffResult too. * ImageDiff/ImageDiff.cpp: (main): Show tolerance in verbose logging. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._compare_image): (SingleTestRunner._compare_output_with_reference): * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image): (TestResultWriterTest): (TestResultWriterTest.test_reftest_diff_image): * Scripts/webkitpy/layout_tests/models/test_failures.py: (FailureImageHashMismatch.__init__): (FailureReftestMismatch.__init__): (FailureReftestMismatch.write_failure): * Scripts/webkitpy/layout_tests/models/test_run_results.py: (_interpret_test_failures): * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: (InterpretTestFailuresTest.test_interpret_test_failures): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_tolerance.ImageDiffTestPort.diff_image): * Scripts/webkitpy/port/image_diff.py: (ImageDiffResult.__init__): (ImageDiffResult.__repr__): (ImageDiffer._read): * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_diff_image): Modified Paths trunk/Tools/ChangeLog trunk/Tools/ImageDiff/ImageDiff.cpp trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py trunk/Tools/Scripts/webkitpy/port/image_diff.py trunk/Tools/Scripts/webkitpy/port/port_testcase.py trunk/Tools/Scripts/webkitpy/port/test.py Diff Modified: trunk/Tools/ChangeLog (284865 => 284866) --- trunk/Tools/ChangeLog 2021-10-26 14:55:58 UTC (rev 284865) +++ trunk/Tools/ChangeLog 2021-10-26 15:04:13 UTC (rev 284866) @@ -1,3 +1,45 @@ +2021-10-26 Simon Fraser + +Don't run ImageDiff a second time to generate diff images +https://bugs.webkit.org/show_bug.cgi?id=232288 + +Reviewed by Martin Robinson. + +Currently, for a ref test failure (which is always run with tolerance=0), we run ImageDiff a +second time in FailureReftestMismatch.write_failure() with the intent of generating a diff +image with zero tolerance. + +Fix by storing the ImageDiffResult in FailureReftestMismatch and FailureImageHashMismatch so +we already have the diff image. We only regenerate it when the first diff was run with a +non-zero tolerance (only relevant for pixel tests). To faciliate this, store the tolerance +that was used inside ImageDiffResult too. + +* ImageDiff/ImageDiff.cpp: +(main): Show tolerance in verbose logging. +* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: +(SingleTestRunner._compare_image): +(SingleTestRunner._compare_output_with_reference): +* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: +(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image): +(TestResultWriterTest): +(TestResultWriterTest.test_reftest_diff_image): +* Scripts/webkitpy/layout_tests/models/test_failures.py: +(FailureImageHashMismatch.__init__): +(FailureReftestMismatch.__init__): +(FailureReftestMismatch.write_failure): +* Scripts/webkitpy/layout_tests/models/test_run_results.py: +(_interpret_test_failures): +* Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: +(InterpretTestFailuresTest.test_interpret_test_failures): +* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: +(RunTest.test_tolerance.ImageDiffTestPort.diff_image): +* Scripts/webkitpy/port/image_diff.py: +(ImageDiffResult.__init__): +(ImageDiffResult.__repr__): +(ImageDiffer._read): +* Scripts/webkitpy/port/port_testcase.py: +(PortTestCase.test_diff_image): +
[webkit-changes] [284865] trunk
Title: [284865] trunk Revision 284865 Author an...@apple.com Date 2021-10-26 07:55:58 -0700 (Tue, 26 Oct 2021) Log Message Fix ::part(foo):hover https://bugs.webkit.org/show_bug.cgi?id=232301 Reviewed by Alan Bujtas. LayoutTests/imported/w3c: * web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class-expected.html: Added. * web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html: Added. * web-platform-tests/css/css-shadow-parts/invalidation-part-pseudo-expected.txt: Added. * web-platform-tests/css/css-shadow-parts/invalidation-part-pseudo.html: Added. * web-platform-tests/css/css-shadow-parts/part-nested-pseudo-expected.html: Added. * web-platform-tests/css/css-shadow-parts/part-nested-pseudo.html: Added. * web-platform-tests/css/css-shadow-parts/w3c-import.log: Source/WebCore: We fail to match on shadow tree border if the right side of ::part() has other selectors. Tests: imported/w3c/web-platform-tests/css/css-shadow-parts/invalidation-part-pseudo.html * css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const): * css/CSSSelector.h: Add a new ShadowPartDescendant relation type that behaves like the existing ShadowDescendant relation except it is only used for ::part. * css/SelectorChecker.cpp: (WebCore::SelectorChecker::matchRecursively const): We can now identify the ::part case easily from the relation type. (WebCore::canMatchHoverOrActiveInQuirksMode): * css/SelectorFilter.cpp: (WebCore::collectSelectorHashes): * css/parser/CSSParserSelector.h: (WebCore::CSSParserSelector::hasShadowDescendant const): Deleted. * css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::splitCompoundAtImplicitShadowCrossingCombinator): Use ShadowPartDescendant as appropriate. * cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::fragmentRelationForSelectorRelation): (WebCore::SelectorCompiler::constructFragmentsInternal): * style/RuleFeature.cpp: (WebCore::Style::RuleFeatureSet::computeNextMatchElement): LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSSelector.cpp trunk/Source/WebCore/css/CSSSelector.h trunk/Source/WebCore/css/SelectorChecker.cpp trunk/Source/WebCore/css/SelectorFilter.cpp trunk/Source/WebCore/css/parser/CSSParserSelector.h trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp trunk/Source/WebCore/cssjit/SelectorCompiler.cpp trunk/Source/WebCore/style/RuleFeature.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/invalidation-part-pseudo-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/invalidation-part-pseudo.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/part-nested-pseudo-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/part-nested-pseudo.html Diff Modified: trunk/LayoutTests/ChangeLog (284864 => 284865) --- trunk/LayoutTests/ChangeLog 2021-10-26 14:28:58 UTC (rev 284864) +++ trunk/LayoutTests/ChangeLog 2021-10-26 14:55:58 UTC (rev 284865) @@ -1,5 +1,14 @@ 2021-10-26 Antti Koivisto +Fix ::part(foo):hover +https://bugs.webkit.org/show_bug.cgi?id=232301 + +Reviewed by Alan Bujtas. + +* TestExpectations: + +2021-10-26 Antti Koivisto + [CSS Cascade Layers] Media queries should be able to affect layer order https://bugs.webkit.org/show_bug.cgi?id=232238 Modified: trunk/LayoutTests/TestExpectations (284864 => 284865) --- trunk/LayoutTests/TestExpectations 2021-10-26 14:28:58 UTC (rev 284864) +++ trunk/LayoutTests/TestExpectations 2021-10-26 14:55:58 UTC (rev 284865) @@ -5191,3 +5191,5 @@ # IPC test failing in Debug mode due to assert. [ Debug ] ipc/send-invalid-message.html [ Skip ] + +imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284864 => 284865) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 14:28:58 UTC (rev 284864) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 14:55:58 UTC (rev 284865) @@ -1,5 +1,20 @@ 2021-10-26 Antti Koivisto +Fix ::part(foo):hover +https://bugs.webkit.org/show_bug.cgi?id=232301 + +Reviewed by Alan Bujtas. + +* web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class-expected.html: Added. +* web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html: Added. +*
[webkit-changes] [284864] trunk/Source/WebKit
Title: [284864] trunk/Source/WebKit Revision 284864 Author pvol...@apple.com Date 2021-10-26 07:28:58 -0700 (Tue, 26 Oct 2021) Log Message [iOS][WP] Reduce sandbox telemetry https://bugs.webkit.org/show_bug.cgi?id=232279 Reviewed by Brent Fulgham. Reduce sandbox telemetry for rules we already have collected information for. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (284863 => 284864) --- trunk/Source/WebKit/ChangeLog 2021-10-26 12:16:35 UTC (rev 284863) +++ trunk/Source/WebKit/ChangeLog 2021-10-26 14:28:58 UTC (rev 284864) @@ -1,3 +1,15 @@ +2021-10-26 Per Arne + +[iOS][WP] Reduce sandbox telemetry +https://bugs.webkit.org/show_bug.cgi?id=232279 + + +Reviewed by Brent Fulgham. + +Reduce sandbox telemetry for rules we already have collected information for. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + 2021-10-26 Youenn Fablet Only one AudioSampleDataSource::pullSamples is needed Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (284863 => 284864) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-10-26 12:16:35 UTC (rev 284863) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-10-26 14:28:58 UTC (rev 284864) @@ -1271,7 +1271,10 @@ (syscall-number SYS_ulock_wake) (syscall-number SYS_workq_kernreturn) (syscall-number SYS_workq_open)) - + +(allow syscall-unix (with telemetry) +(syscall-number SYS_objc_bp_assist_cfg_np)) + (allow syscall-unix (with telemetry-backtrace) (syscall-number SYS___pthread_kill) (syscall-number SYS___pthread_markcancel) @@ -1309,7 +1312,6 @@ (syscall-number SYS_munlock) (syscall-number SYS_necp_client_action) (syscall-number SYS_necp_open) -(syscall-number SYS_objc_bp_assist_cfg_np) (syscall-number SYS_open) (syscall-number SYS_open_dprotected_np) (syscall-number SYS_open_nocancel) @@ -1392,7 +1394,7 @@ (fcntl-command F_SETFL) ;; CMCapture uses when camera is enabled (fcntl-command F_SETNOSIGPIPE)) ;; CMCapture uses when camera is enabled -(allow system-fcntl (with telemetry-backtrace) +(allow system-fcntl (with telemetry) (fcntl-command F_OFD_SETLK)) (allow system-fcntl @@ -1541,12 +1543,14 @@ mach_vm_region_recurse task_set_exc_guard_behavior task_threads_from_user -thread_info thread_policy -thread_policy_set (when (defined? 'vm_copy) vm_copy) (when (defined? 'vm_remap_external) vm_remap_external))) +(allow mach-message-send (with telemetry) (kernel-mig-routine +thread_info +thread_policy_set)) + (allow mach-message-send (kernel-mig-routine (when (defined? '_mach_make_memory_entry) _mach_make_memory_entry) host_get_clock_service ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284863] trunk
Title: [284863] trunk
Revision 284863
Author an...@apple.com
Date 2021-10-26 05:16:35 -0700 (Tue, 26 Oct 2021)
Log Message
Serialize :part() argument as identifier
https://bugs.webkit.org/show_bug.cgi?id=232297
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-shadow-parts/serialization-expected.txt:
Source/WebCore:
WPT fix.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/serialization-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSSelector.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284862 => 284863)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 12:16:35 UTC (rev 284863)
@@ -1,5 +1,14 @@
2021-10-26 Antti Koivisto
+Serialize :part() argument as identifier
+https://bugs.webkit.org/show_bug.cgi?id=232297
+
+Reviewed by Youenn Fablet.
+
+* web-platform-tests/css/css-shadow-parts/serialization-expected.txt:
+
+2021-10-26 Antti Koivisto
+
[CSS Cascade Layers] Media queries should be able to affect layer order
https://bugs.webkit.org/show_bug.cgi?id=232238
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/serialization-expected.txt (284862 => 284863)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/serialization-expected.txt 2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/serialization-expected.txt 2021-10-26 12:16:35 UTC (rev 284863)
@@ -1,5 +1,5 @@
-FAIL Escape start parenthesis in ::part name. assert_equals: expected "::part(\\(foo)" but got "::part((foo)"
-FAIL Escape start space in ::part name. assert_equals: expected "::part(bar\\ )" but got "::part(bar )"
+PASS Escape start parenthesis in ::part name.
+PASS Escape start space in ::part name.
PASS Collapse spaces in ::part names list.
Modified: trunk/Source/WebCore/ChangeLog (284862 => 284863)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 12:16:35 UTC (rev 284863)
@@ -1,3 +1,15 @@
+2021-10-26 Antti Koivisto
+
+Serialize :part() argument as identifier
+https://bugs.webkit.org/show_bug.cgi?id=232297
+
+Reviewed by Youenn Fablet.
+
+WPT fix.
+
+* css/CSSSelector.cpp:
+(WebCore::CSSSelector::selectorText const):
+
2021-10-26 Youenn Fablet
Only one AudioSampleDataSource::pullSamples is needed
Modified: trunk/Source/WebCore/css/CSSSelector.cpp (284862 => 284863)
--- trunk/Source/WebCore/css/CSSSelector.cpp 2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/Source/WebCore/css/CSSSelector.cpp 2021-10-26 12:16:35 UTC (rev 284863)
@@ -724,7 +724,7 @@
if (!isFirst)
builder.append(' ');
isFirst = false;
-builder.append(partName);
+serializeIdentifier(partName, builder);
}
builder.append(')');
break;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284862] trunk/Source
Title: [284862] trunk/Source
Revision 284862
Author you...@apple.com
Date 2021-10-26 02:46:47 -0700 (Tue, 26 Oct 2021)
Log Message
Only one AudioSampleDataSource::pullSamples is needed
https://bugs.webkit.org/show_bug.cgi?id=232145
Reviewed by Eric Carlson.
Source/WebCore:
Update CoreAudioSharedUnit::provideSpeakerData to use pullSamples taking an AudioBufferList as parameter.
Remove the no longer necessary AudioSampleDataSource::pullSamples and rename pullSamplesInternal in pullSamples.
Update header to forward declare more classes.
This is a refactoring, no change of behavior.
* platform/audio/cocoa/AudioSampleDataSource.h:
* platform/audio/cocoa/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pullSamples):
(WebCore::AudioSampleDataSource::pullSamplesInternal): Deleted.
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::provideSpeakerData):
Source/WebKit:
* WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.h
trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (284861 => 284862)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 09:46:30 UTC (rev 284861)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 09:46:47 UTC (rev 284862)
@@ -1,5 +1,24 @@
2021-10-26 Youenn Fablet
+Only one AudioSampleDataSource::pullSamples is needed
+https://bugs.webkit.org/show_bug.cgi?id=232145
+
+Reviewed by Eric Carlson.
+
+Update CoreAudioSharedUnit::provideSpeakerData to use pullSamples taking an AudioBufferList as parameter.
+Remove the no longer necessary AudioSampleDataSource::pullSamples and rename pullSamplesInternal in pullSamples.
+Update header to forward declare more classes.
+This is a refactoring, no change of behavior.
+
+* platform/audio/cocoa/AudioSampleDataSource.h:
+* platform/audio/cocoa/AudioSampleDataSource.mm:
+(WebCore::AudioSampleDataSource::pullSamples):
+(WebCore::AudioSampleDataSource::pullSamplesInternal): Deleted.
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioSharedUnit::provideSpeakerData):
+
+2021-10-26 Youenn Fablet
+
Beef up worker termination handling in ReadableStream routines
https://bugs.webkit.org/show_bug.cgi?id=231500
Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.h (284861 => 284862)
--- trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.h 2021-10-26 09:46:30 UTC (rev 284861)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.h 2021-10-26 09:46:47 UTC (rev 284862)
@@ -25,7 +25,7 @@
#pragma once
-#include "AudioSampleBufferList.h"
+#include "CARingBuffer.h"
#include
#include
#include
@@ -33,12 +33,13 @@
#include
#include
+typedef struct OpaqueAudioConverter* AudioConverterRef;
typedef struct opaqueCMSampleBuffer *CMSampleBufferRef;
namespace WebCore {
-class CAAudioStreamDescription;
-class CARingBuffer;
+class AudioSampleBufferList;
+class PlatformAudioData;
class AudioSampleDataSource : public ThreadSafeRefCounted
#if !RELEASE_LOG_DISABLED
@@ -57,7 +58,6 @@
void pushSamples(const AudioStreamBasicDescription&, CMSampleBufferRef);
enum PullMode { Copy, Mix };
-bool pullSamples(AudioSampleBufferList&, size_t, uint64_t, double, PullMode);
bool pullSamples(AudioBufferList&, size_t, uint64_t, double, PullMode);
bool pullAvailableSamplesAsChunks(AudioBufferList&, size_t frameCount, uint64_t timeStamp, Function&&);
@@ -84,7 +84,6 @@
AudioSampleDataSource(size_t, LoggerHelper&, size_t waitToStartForPushCount);
OSStatus setupConverter();
-bool pullSamplesInternal(AudioBufferList&, size_t, uint64_t, double, PullMode);
void pushSamplesInternal(const AudioBufferList&, const MediaTime&, size_t frameCount);
Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm (284861 => 284862)
--- trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm 2021-10-26 09:46:30 UTC (rev 284861)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm 2021-10-26 09:46:47 UTC (rev 284862)
@@ -26,8 +26,7 @@
#import "config.h"
#import "AudioSampleDataSource.h"
-#import "CAAudioStreamDescription.h"
-#import "CARingBuffer.h"
+#import "AudioSampleBufferList.h"
#import "Logging.h"
#import "PlatformAudioData.h"
#import
@@ -210,7 +209,7 @@
return 0;
}
-bool AudioSampleDataSource::pullSamplesInternal(AudioBufferList& buffer, size_t sampleCount, uint64_t timeStamp, double /*hostTime*/, PullMode mode)
+bool
[webkit-changes] [284861] trunk/Source/WebCore
Title: [284861] trunk/Source/WebCore
Revision 284861
Author you...@apple.com
Date 2021-10-26 02:46:30 -0700 (Tue, 26 Oct 2021)
Log Message
Beef up worker termination handling in ReadableStream routines
https://bugs.webkit.org/show_bug.cgi?id=231500
Reviewed by Darin Adler.
Add some termination/exception checks after getting values from global objects.
Covered by existing tests.
* bindings/js/ReadableStream.cpp:
(WebCore::ReadableStream::create):
(WebCore::ReadableStream::lock):
* bindings/js/ReadableStreamDefaultController.cpp:
(WebCore::invokeReadableStreamDefaultControllerFunction):
(WebCore::ReadableStreamDefaultController::enqueue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ReadableStream.cpp
trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (284860 => 284861)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 09:17:13 UTC (rev 284860)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 09:46:30 UTC (rev 284861)
@@ -1,5 +1,23 @@
2021-10-26 Youenn Fablet
+Beef up worker termination handling in ReadableStream routines
+https://bugs.webkit.org/show_bug.cgi?id=231500
+
+
+Reviewed by Darin Adler.
+
+Add some termination/exception checks after getting values from global objects.
+Covered by existing tests.
+
+* bindings/js/ReadableStream.cpp:
+(WebCore::ReadableStream::create):
+(WebCore::ReadableStream::lock):
+* bindings/js/ReadableStreamDefaultController.cpp:
+(WebCore::invokeReadableStreamDefaultControllerFunction):
+(WebCore::ReadableStreamDefaultController::enqueue):
+
+2021-10-26 Youenn Fablet
+
Decrease WebRTC latency by pulling data more often
https://bugs.webkit.org/show_bug.cgi?id=232143
Modified: trunk/Source/WebCore/bindings/js/ReadableStream.cpp (284860 => 284861)
--- trunk/Source/WebCore/bindings/js/ReadableStream.cpp 2021-10-26 09:17:13 UTC (rev 284860)
+++ trunk/Source/WebCore/bindings/js/ReadableStream.cpp 2021-10-26 09:46:30 UTC (rev 284861)
@@ -46,6 +46,7 @@
auto& globalObject = *JSC::jsCast();
auto* constructor = JSC::asObject(globalObject.get(, clientData.builtinNames().ReadableStreamPrivateName()));
+RETURN_IF_EXCEPTION(scope, Exception { ExistingExceptionError });
auto constructData = getConstructData(vm, constructor);
ASSERT(constructData.type != CallData::Type::None);
@@ -115,13 +116,14 @@
{
auto& lexicalGlobalObject = *m_globalObject;
auto& vm = lexicalGlobalObject.vm();
-#if ENABLE(EXCEPTION_SCOPE_VERIFICATION)
auto scope = DECLARE_CATCH_SCOPE(vm);
-#endif
auto& clientData = *static_cast(vm.clientData);
auto* constructor = JSC::asObject(m_globalObject->get(, clientData.builtinNames().ReadableStreamDefaultReaderPrivateName()));
+EXCEPTION_ASSERT(!scope.exception() || vm.hasPendingTerminationException());
+if (scope.exception())
+return;
auto constructData = getConstructData(vm, constructor);
ASSERT(constructData.type != CallData::Type::None);
Modified: trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp (284860 => 284861)
--- trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp 2021-10-26 09:17:13 UTC (rev 284860)
+++ trunk/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp 2021-10-26 09:46:30 UTC (rev 284861)
@@ -44,10 +44,14 @@
JSC::VM& vm = lexicalGlobalObject.vm();
JSC::JSLockHolder lock(vm);
+auto scope = DECLARE_CATCH_SCOPE(vm);
auto function = lexicalGlobalObject.get(, identifier);
+
+EXCEPTION_ASSERT(!scope.exception() || vm.hasPendingTerminationException());
+RETURN_IF_EXCEPTION(scope, false);
+
ASSERT(function.isCallable(lexicalGlobalObject.vm()));
-auto scope = DECLARE_CATCH_SCOPE(vm);
auto callData = JSC::getCallData(vm, function);
call(, function, callData, JSC::jsUndefined(), arguments);
EXCEPTION_ASSERT(!scope.exception() || vm.hasPendingTerminationException());
@@ -120,10 +124,8 @@
auto chunk = JSC::Uint8Array::create(WTFMove(buffer), 0, length);
auto value = toJS(, , chunk.get());
-if (UNLIKELY(scope.exception())) {
-ASSERT(vm.hasPendingTerminationException());
-return false;
-}
+EXCEPTION_ASSERT(!scope.exception() || vm.hasPendingTerminationException());
+RETURN_IF_EXCEPTION(scope, false);
return enqueue(value);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284860] trunk/Source/WebCore
Title: [284860] trunk/Source/WebCore Revision 284860 Author you...@apple.com Date 2021-10-26 02:17:13 -0700 (Tue, 26 Oct 2021) Log Message Decrease WebRTC latency by pulling data more often https://bugs.webkit.org/show_bug.cgi?id=232143 Reviewed by Eric Carlson. We were previously pulling 10 ms chunks by groups of 5, we then redunced to 3. Let's reduce to 1 to further reduce WebRTC remote audio track latency. This triggers scheduling of 100 tasks per second instead of 33 previously. * platform/mediastream/libwebrtc/LibWebRTCAudioModule.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h Diff Modified: trunk/Source/WebCore/ChangeLog (284859 => 284860) --- trunk/Source/WebCore/ChangeLog 2021-10-26 08:30:46 UTC (rev 284859) +++ trunk/Source/WebCore/ChangeLog 2021-10-26 09:17:13 UTC (rev 284860) @@ -1,3 +1,16 @@ +2021-10-26 Youenn Fablet + +Decrease WebRTC latency by pulling data more often +https://bugs.webkit.org/show_bug.cgi?id=232143 + +Reviewed by Eric Carlson. + +We were previously pulling 10 ms chunks by groups of 5, we then redunced to 3. +Let's reduce to 1 to further reduce WebRTC remote audio track latency. +This triggers scheduling of 100 tasks per second instead of 33 previously. + +* platform/mediastream/libwebrtc/LibWebRTCAudioModule.h: + 2021-10-26 Antti Koivisto [CSS Cascade Layers] Media queries should be able to affect layer order Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h (284859 => 284860) --- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h 2021-10-26 08:30:46 UTC (rev 284859) +++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h 2021-10-26 09:17:13 UTC (rev 284860) @@ -46,7 +46,7 @@ public: LibWebRTCAudioModule(); -static constexpr unsigned PollSamplesCount = 3; +static constexpr unsigned PollSamplesCount = 1; private: template U shouldNotBeCalled(U value) const ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284859] trunk
Title: [284859] trunk
Revision 284859
Author an...@apple.com
Date 2021-10-26 01:30:46 -0700 (Tue, 26 Oct 2021)
Log Message
[CSS Cascade Layers] Media queries should be able to affect layer order
https://bugs.webkit.org/show_bug.cgi?id=232238
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Also import some additional @layer WPTs.
* web-platform-tests/css/css-cascade/layer-media-query-expected.txt: Added.
* web-platform-tests/css/css-cascade/layer-media-query.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-001-expected.xht: Added.
* web-platform-tests/css/css-cascade/revert-layer-001.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-002-expected.xht: Added.
* web-platform-tests/css/css-cascade/revert-layer-002.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-003-expected.xht: Added.
* web-platform-tests/css/css-cascade/revert-layer-003.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-004-expected.xht: Added.
* web-platform-tests/css/css-cascade/revert-layer-004.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-005-expected.xht: Added.
* web-platform-tests/css/css-cascade/revert-layer-005.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-006-expected.xht: Added.
* web-platform-tests/css/css-cascade/revert-layer-006.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-007-expected.xht: Added.
* web-platform-tests/css/css-cascade/revert-layer-007.html: Added.
* web-platform-tests/css/css-cascade/revert-layer-008-expected.txt: Added.
* web-platform-tests/css/css-cascade/revert-layer-008.html: Added.
* web-platform-tests/css/css-cascade/w3c-import.log:
Source/WebCore:
Cases like
@media (min-width: 500px) { @layer a, b; }
@media (min-width: 200px) { @layer b, a; }
should work as expected.
Tests: imported/w3c/web-platform-tests/css/css-cascade/layer-media-query.html
* style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addRulesFromSheet):
(WebCore::Style::RuleSetBuilder::addChildRules):
Disable dynamic media query evaluation for now when we see a @layer rule within a media query.
* style/RuleSetBuilder.h:
Tests: imported/w3c/web-platform-tests/css/css-cascade/layer-media-query.html
* style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addRulesFromSheet):
(WebCore::Style::RuleSetBuilder::addChildRules):
* style/RuleSetBuilder.h:
LayoutTests:
* TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/RuleSetBuilder.cpp
trunk/Source/WebCore/style/RuleSetBuilder.h
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-media-query-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-media-query.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-001-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-002-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-003-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-003.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-004-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-005-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-005.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-006-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-006.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-007-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-007.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-008-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-layer-008.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284858 => 284859)
--- trunk/LayoutTests/ChangeLog 2021-10-26 07:36:09 UTC (rev 284858)
+++ trunk/LayoutTests/ChangeLog 2021-10-26 08:30:46 UTC (rev 284859)
@@ -1,3 +1,12 @@
+2021-10-26 Antti Koivisto
+
+[CSS Cascade Layers] Media queries should be able to affect layer order
+https://bugs.webkit.org/show_bug.cgi?id=232238
+
+Reviewed by Simon Fraser.
+
+* TestExpectations:
+
2021-10-25 Ryan Haddad
Change default iOS simulator to one with a larger screen size
Modified:
[webkit-changes] [284858] trunk
Title: [284858] trunk
Revision 284858
Author ape...@igalia.com
Date 2021-10-26 00:36:09 -0700 (Tue, 26 Oct 2021)
Log Message
Multiple build issues with ENABLE_VIDEO=OFF
https://bugs.webkit.org/show_bug.cgi?id=232264
Reviewed by Carlos Garcia Campos.
.:
* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
Source/WebCore:
No new tests needed.
* accessibility/AXObjectCache.cpp:
(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
* page/EventHandler.cpp:
(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
ENABLE(VIDEO).
* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
Source/WebKit:
* WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
(WebKit::createShareableBitmap): Guard usage of RenderVideo with ENABLE(VIDEO).
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp
trunk/Source/cmake/WebKitFeatures.cmake
Diff
Modified: trunk/ChangeLog (284857 => 284858)
--- trunk/ChangeLog 2021-10-26 07:23:01 UTC (rev 284857)
+++ trunk/ChangeLog 2021-10-26 07:36:09 UTC (rev 284858)
@@ -1,3 +1,12 @@
+2021-10-26 Adrian Perez de Castro
+
+Multiple build issues with ENABLE_VIDEO=OFF
+https://bugs.webkit.org/show_bug.cgi?id=232264
+
+Reviewed by Carlos Garcia Campos.
+
+* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
+
2021-10-25 Jonathan Bedard
Add GitHub usernames for bedison and darinadler
Modified: trunk/Source/WebCore/ChangeLog (284857 => 284858)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 07:23:01 UTC (rev 284857)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 07:36:09 UTC (rev 284858)
@@ -1,3 +1,22 @@
+2021-10-26 Adrian Perez de Castro
+
+Multiple build issues with ENABLE_VIDEO=OFF
+https://bugs.webkit.org/show_bug.cgi?id=232264
+
+Reviewed by Carlos Garcia Campos.
+
+No new tests needed.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::isSimpleImage): Guard usage of HTMLMediaElement with ENABLE(VIDEO).
+* page/EventHandler.cpp:
+(WebCore::EventHandler::textRecognitionCandidateElement const): Ditto.
+* platform/graphics/BifurcatedGraphicsContext.cpp: Ditto.
+* platform/graphics/displaylists/DisplayListRecorder.h: Guard usage of MediaPlayer with
+ENABLE(VIDEO).
+* platform/graphics/displaylists/DisplayListRecorderImpl.cpp: Ditto.
+* platform/graphics/displaylists/DisplayListRecorderImpl.h: Ditto.
+
2021-10-26 Fujii Hironori
[WebCore] Remove unneeded WTF:: namespace prefix
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (284857 => 284858)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2021-10-26 07:23:01 UTC (rev 284857)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2021-10-26 07:36:09 UTC (rev 284858)
@@ -531,9 +531,11 @@
|| (is(node) && downcast(node)->hasAttributeWithoutSynchronization(usemapAttr)))
return false;
+#if ENABLE(VIDEO)
// Exclude video and audio elements.
if (is(node))
return false;
+#endif // ENABLE(VIDEO)
return true;
}
Modified: trunk/Source/WebCore/page/EventHandler.cpp (284857 => 284858)
--- trunk/Source/WebCore/page/EventHandler.cpp 2021-10-26 07:23:01 UTC (rev 284857)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2021-10-26 07:36:09 UTC (rev 284858)
@@ -2543,8 +2543,10 @@
return candidateElement;
#endif
+#if ENABLE(VIDEO)
if (is(*candidateElement))
return nullptr;
+#endif // ENABLE(VIDEO)
return candidateElement;
}
Modified: trunk/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp (284857 => 284858)
--- trunk/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp 2021-10-26 07:23:01 UTC (rev 284857)
+++ trunk/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp 2021-10-26 07:36:09 UTC (rev 284858)
@@ -297,11 +297,13 @@
return result;
}
+#if ENABLE(VIDEO)
void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination)
{
m_primaryContext.paintFrameForMedia(player, destination);
m_secondaryContext.paintFrameForMedia(player, destination);
}
[webkit-changes] [284856] trunk/Source/WebCore
Title: [284856] trunk/Source/WebCore
Revision 284856
Author grao...@webkit.org
Date 2021-10-26 00:06:27 -0700 (Tue, 26 Oct 2021)
Log Message
Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue()
https://bugs.webkit.org/show_bug.cgi?id=232246
Reviewed by Dean Jackson.
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSToStyleMap.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (284855 => 284856)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 04:40:59 UTC (rev 284855)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 07:06:27 UTC (rev 284856)
@@ -1,3 +1,13 @@
+2021-10-26 Antoine Quint
+
+Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue()
+https://bugs.webkit.org/show_bug.cgi?id=232246
+
+Reviewed by Dean Jackson.
+
+* css/CSSToStyleMap.cpp:
+(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
+
2021-10-25 Nikolaos Mouchtaris
Fix issue for transform-origin in SVG
Modified: trunk/Source/WebCore/css/CSSToStyleMap.cpp (284855 => 284856)
--- trunk/Source/WebCore/css/CSSToStyleMap.cpp 2021-10-26 04:40:59 UTC (rev 284855)
+++ trunk/Source/WebCore/css/CSSToStyleMap.cpp 2021-10-26 07:06:27 UTC (rev 284856)
@@ -456,50 +456,10 @@
void CSSToStyleMap::mapAnimationTimingFunction(Animation& animation, const CSSValue& value)
{
-if (value.treatAsInitialValue(CSSPropertyAnimationTimingFunction)) {
+if (value.treatAsInitialValue(CSSPropertyAnimationTimingFunction))
animation.setTimingFunction(Animation::initialTimingFunction());
-return;
-}
-
-if (is(value)) {
-switch (downcast(value).valueID()) {
-case CSSValueLinear:
-animation.setTimingFunction(LinearTimingFunction::create());
-break;
-case CSSValueEase:
-animation.setTimingFunction(CubicBezierTimingFunction::create());
-break;
-case CSSValueEaseIn:
-animation.setTimingFunction(CubicBezierTimingFunction::create(CubicBezierTimingFunction::EaseIn));
-break;
-case CSSValueEaseOut:
-animation.setTimingFunction(CubicBezierTimingFunction::create(CubicBezierTimingFunction::EaseOut));
-break;
-case CSSValueEaseInOut:
-animation.setTimingFunction(CubicBezierTimingFunction::create(CubicBezierTimingFunction::EaseInOut));
-break;
-case CSSValueStepStart:
-animation.setTimingFunction(StepsTimingFunction::create(1, StepsTimingFunction::StepPosition::Start));
-break;
-case CSSValueStepEnd:
-animation.setTimingFunction(StepsTimingFunction::create(1, StepsTimingFunction::StepPosition::End));
-break;
-default:
-break;
-}
-return;
-}
-
-if (is(value)) {
-auto& cubicTimingFunction = downcast(value);
-animation.setTimingFunction(CubicBezierTimingFunction::create(cubicTimingFunction.x1(), cubicTimingFunction.y1(), cubicTimingFunction.x2(), cubicTimingFunction.y2()));
-} else if (is(value)) {
-auto& stepsTimingFunction = downcast(value);
-animation.setTimingFunction(StepsTimingFunction::create(stepsTimingFunction.numberOfSteps(), stepsTimingFunction.stepPosition()));
-} else if (is(value)) {
-auto& springTimingFunction = downcast(value);
-animation.setTimingFunction(SpringTimingFunction::create(springTimingFunction.mass(), springTimingFunction.stiffness(), springTimingFunction.damping(), springTimingFunction.initialVelocity()));
-}
+else if (auto timingFunction = TimingFunction::createFromCSSValue(value))
+animation.setTimingFunction(WTFMove(timingFunction));
}
void CSSToStyleMap::mapNinePieceImage(CSSPropertyID property, CSSValue* value, NinePieceImage& image)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
