[webkit-changes] [285253] trunk/LayoutTests
Title: [285253] trunk/LayoutTests Revision 285253 Author commit-qu...@webkit.org Date 2021-11-03 21:49:45 -0700 (Wed, 03 Nov 2021) Log Message [GLIB] Update test expectations and baselines. Unreviewed test gardening. https://bugs.webkit.org/show_bug.cgi?id=232683 Patch by Arcady Goldmints-Orlov on 2021-11-03 * platform/glib/TestExpectations: * platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt: * platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: * platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (285252 => 285253) --- trunk/LayoutTests/ChangeLog 2021-11-04 01:23:46 UTC (rev 285252) +++ trunk/LayoutTests/ChangeLog 2021-11-04 04:49:45 UTC (rev 285253) @@ -1,3 +1,13 @@ +2021-11-03 Arcady Goldmints-Orlov + +[GLIB] Update test expectations and baselines. Unreviewed test gardening. +https://bugs.webkit.org/show_bug.cgi?id=232683 + +* platform/glib/TestExpectations: +* platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt: +* platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: +* platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt: + 2021-11-03 Alex Christensen Remove QuickTimePluginReplacement and YouTubePluginReplacement Modified: trunk/LayoutTests/platform/glib/TestExpectations (285252 => 285253) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-11-04 01:23:46 UTC (rev 285252) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-11-04 04:49:45 UTC (rev 285253) @@ -1537,6 +1537,8 @@ webkit.org/b/232346 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html [ Failure ] webkit.org/b/232346 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html [ Failure ] +webkit.org/b/232346 fast/canvas/canvas-createPattern-video-loading.html [ Failure ] +webkit.org/b/232346 fast/canvas/canvas-createPattern-video-modify.html [ Failure ] # # End of WPT-related bugs @@ -2455,6 +2457,8 @@ webkit.org/b/232386 css3/filters/effect-reference-ordering-hw.html [ Failure ] webkit.org/b/232386 css3/filters/effect-reference-ordering.html [ Failure ] webkit.org/b/232386 css3/filters/effect-reference.html [ Failure ] +webkit.org/b/232386 css3/filters/filters-on-svg-element.html [ ImageOnlyFailure ] +webkit.org/b/232386 css3/filters/filters-on-svg-root.html [ ImageOnlyFailure ] webkit.org/b/232386 editing/deleting/delete-block-contents-004.html [ Failure ] webkit.org/b/232386 editing/deleting/move-nodes-001.html [ Failure ] webkit.org/b/232386 editing/selection/doubleclick-japanese-text.html [ Failure ] @@ -2466,9 +2470,12 @@ webkit.org/b/232386 fast/block/margin-collapse/102.html [ Failure ] webkit.org/b/232386 fast/box-sizing/panels-one.html [ Failure ] webkit.org/b/232386 fast/box-sizing/panels-two.html [ Failure ] +webkit.org/b/232386 fast/css-generated-content/010.html [ Failure ] +webkit.org/b/232386 fast/css-generated-content/initial-letter-pagination-raised.html [ ImageOnlyFailure ] webkit.org/b/232386 fast/css/background-shorthand-invalid-url.html [ Failure ] webkit.org/b/232386 fast/css/content-language-case-insensitivity.html [ Failure ] webkit.org/b/232386 fast/css/content-language-empty.html [ Failure ] +webkit.org/b/232386 fast/css/content-language-late.html [ Failure ] webkit.org/b/232386 fast/css/content-language-mapped-to-webkit-locale.html [ Failure ] webkit.org/b/232386 fast/css/content-language-multiple.html [ Failure ] webkit.org/b/232386 fast/css/content-language-no-content.html [ Failure ] @@ -2483,6 +2490,7 @@ webkit.org/b/232386 fast/dom/client-width-height.html [ Failure ] webkit.org/b/232386 fast/dom/createAttribute-exception.html [ Failure ] webkit.org/b/232386 fast/dom/inner-text-rtl.html [ Failure ] +webkit.org/b/232386 fast/dom/replace-child-siblings.html [ Failure ] webkit.org/b/232386 fast/dom/replaced-image-map.html [ Failure ] webkit.org/b/232386 fast/dom/rtl-scroll-to-leftmost-and-resize.html [ Failure ] webkit.org/b/232386 fast/dom/xml-parser-entity-in-attribute-value.html [ Failure ] @@ -2492,12 +2500,15 @@ webkit.org/b/232386 fast/forms/domstring-replace-crash.html [ Failure ] webkit.org/b/232386 fast/forms/select-reset-multiple-selections-4-single-selection.html [ Failure ] webkit.org/b/232386 fast/frames/frame-name-reset.html [ Failure ] +webkit.org/b/232386
[webkit-changes] [285252] trunk
Title: [285252] trunk Revision 285252 Author achristen...@apple.com Date 2021-11-03 18:23:46 -0700 (Wed, 03 Nov 2021) Log Message Remove QuickTimePluginReplacement and YouTubePluginReplacement https://bugs.webkit.org/show_bug.cgi?id=232400 Reviewed by Chris Dumez. Source/WebCore: They were disabled at runtime in https://trac.webkit.org/changeset/275911/webkit * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * Modules/plugins/PluginReplacement.h: Removed. * Modules/plugins/QuickTimePluginReplacement.css: Removed. * Modules/plugins/QuickTimePluginReplacement.h: Removed. * Modules/plugins/QuickTimePluginReplacement.idl: Removed. * Modules/plugins/QuickTimePluginReplacement.js: Removed. * Modules/plugins/QuickTimePluginReplacement.mm: Removed. * Modules/plugins/YouTubePluginReplacement.cpp: Removed. * Modules/plugins/YouTubePluginReplacement.h: Removed. * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginScriptObject): * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createElementRenderer): (WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): (WebCore::HTMLPlugInElement::requestObject): (): Deleted. (WebCore::registrar): Deleted. (WebCore::pluginReplacementForType): Deleted. (WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement): Deleted. * html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::pluginReplacementScriptObject): Deleted. * html/shadow/ShadowPseudoIds.cpp: (WebCore::ShadowPseudoIds::webkitPluginReplacement): Deleted. * html/shadow/ShadowPseudoIds.h: * html/shadow/YouTubeEmbedShadowElement.cpp: Removed. * html/shadow/YouTubeEmbedShadowElement.h: Removed. * page/Settings.yaml: Source/WebInspectorUI: * UserInterface/Models/NativeFunctionParameters.js: Tools: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Removed. LayoutTests: * security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement-expected.txt: Removed. * security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources-input.xcfilelist trunk/Source/WebCore/DerivedSources-output.xcfilelist trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.cpp trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp trunk/Source/WebCore/html/HTMLPlugInElement.cpp trunk/Source/WebCore/html/HTMLPlugInElement.h trunk/Source/WebCore/html/shadow/ShadowPseudoIds.cpp trunk/Source/WebCore/html/shadow/ShadowPseudoIds.h trunk/Source/WebCore/page/Settings.yaml trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Removed Paths trunk/LayoutTests/security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement-expected.txt trunk/LayoutTests/security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html trunk/LayoutTests/security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement-expected.txt trunk/LayoutTests/security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement-expected.txt trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-expected.txt trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type-expected.txt trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-expected.txt trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type-expected.txt
[webkit-changes] [285251] trunk/Tools
Title: [285251] trunk/Tools
Revision 285251
Author yousuke.kim...@sony.com
Date 2021-11-03 17:40:44 -0700 (Wed, 03 Nov 2021)
Log Message
Use 0.0.0.0 when "--all-interfaces" is given for websocket_server
https://bugs.webkit.org/show_bug.cgi?id=231798
Reviewed by Jonathan Bedard.
When run-webkit-tests runs with "--all-interfaces", servers running
on the host PC should use "0.0.0.0". It will help situations where
host and target systems are discrete so that test programs can
connect to test servers on the host PC.
* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
(PyWebSocket.__init__): Fixed a style check error.
(PyWebSocket._prepare_config): Added "0.0.0.0" for --all-interfaces.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py
Diff
Modified: trunk/Tools/ChangeLog (285250 => 285251)
--- trunk/Tools/ChangeLog 2021-11-04 00:16:31 UTC (rev 285250)
+++ trunk/Tools/ChangeLog 2021-11-04 00:40:44 UTC (rev 285251)
@@ -1,3 +1,20 @@
+2021-11-03 Yousuke Kimoto
+
+Use 0.0.0.0 when "--all-interfaces" is given for websocket_server
+https://bugs.webkit.org/show_bug.cgi?id=231798
+
+
+Reviewed by Jonathan Bedard.
+
+When run-webkit-tests runs with "--all-interfaces", servers running
+on the host PC should use "0.0.0.0". It will help situations where
+host and target systems are discrete so that test programs can
+connect to test servers on the host PC.
+
+* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
+(PyWebSocket.__init__): Fixed a style check error.
+(PyWebSocket._prepare_config): Added "0.0.0.0" for --all-interfaces.
+
2021-11-03 Yusuke Suzuki
[JSC] Clean up StructureStubInfo initialization
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py (285250 => 285251)
--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2021-11-04 00:16:31 UTC (rev 285250)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2021-11-04 00:40:44 UTC (rev 285251)
@@ -96,7 +96,8 @@
try:
self._layout_tests = self._port_obj.layout_tests_dir()
self._web_socket_tests = self._filesystem.join(self._layout_tests, 'http', 'tests', 'websocket', 'tests')
-except:
+except Exception as e:
+_log.error('Failed to join path for layout_test websocket server: %s' % str(e))
self._web_socket_tests = None
if self._use_tls:
@@ -128,7 +129,7 @@
pywebsocket_script = self._filesystem.join(pywebsocket_base, 'mod_pywebsocket', 'standalone.py')
start_cmd = [
python_interp, '-u', pywebsocket_script,
-'--server-host', 'localhost',
+'--server-host', '0.0.0.0' if self._port_obj.get_option("http_all_interfaces") else 'localhost',
'--port', str(self._port),
# FIXME: Don't we have a self._port_obj.layout_test_path?
'--document-root', self._filesystem.join(self._layout_tests, 'http', 'tests'),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285250] tags/Safari-612.3.3.0.2/
Title: [285250] tags/Safari-612.3.3.0.2/ Revision 285250 Author repst...@apple.com Date 2021-11-03 17:16:31 -0700 (Wed, 03 Nov 2021) Log Message Tag Safari-612.3.3.0.2. Added Paths tags/Safari-612.3.3.0.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285249] tags/Safari-612.3.3.1.2/
Title: [285249] tags/Safari-612.3.3.1.2/ Revision 285249 Author repst...@apple.com Date 2021-11-03 17:14:52 -0700 (Wed, 03 Nov 2021) Log Message Tag Safari-612.3.3.1.2. Added Paths tags/Safari-612.3.3.1.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285248] branches/safari-612.3.3.1-branch/Source
Title: [285248] branches/safari-612.3.3.1-branch/Source Revision 285248 Author repst...@apple.com Date 2021-11-03 17:13:39 -0700 (Wed, 03 Nov 2021) Log Message Versioning. WebKit-7612.3.3.1.2 Modified Paths branches/safari-612.3.3.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.3.3.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.3.3.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.3.3.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.3.3.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.3.3.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.3.3.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.3.3.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.3.3.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285247 => 285248) --- branches/safari-612.3.3.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-04 00:12:21 UTC (rev 285247) +++ branches/safari-612.3.3.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-04 00:13:39 UTC (rev 285248) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285247 => 285248) --- branches/safari-612.3.3.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-04 00:12:21 UTC (rev 285247) +++ branches/safari-612.3.3.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-04 00:13:39 UTC (rev 285248) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285247 => 285248) --- branches/safari-612.3.3.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-04 00:12:21 UTC (rev 285247) +++ branches/safari-612.3.3.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-04 00:13:39 UTC (rev 285248) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.1-branch/Source/WebCore/Configurations/Version.xcconfig (285247 => 285248) --- branches/safari-612.3.3.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-04 00:12:21 UTC (rev 285247) +++ branches/safari-612.3.3.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-04 00:13:39 UTC (rev 285248) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285247 => 285248) --- branches/safari-612.3.3.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-04 00:12:21 UTC (rev 285247) +++ branches/safari-612.3.3.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-04 00:13:39 UTC (rev 285248) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285247 => 285248) --- branches/safari-612.3.3.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-04 00:12:21 UTC (rev 285247) +++ branches/safari-612.3.3.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-04 00:13:39 UTC (rev 285248) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [285247] branches/safari-612.3.3.1-branch/Source
Title: [285247] branches/safari-612.3.3.1-branch/Source Revision 285247 Author repst...@apple.com Date 2021-11-03 17:12:21 -0700 (Wed, 03 Nov 2021) Log Message Revert "Cherry-pick r285241. rdar://problem/84990898" This reverts commit r285243. Modified Paths branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog branches/safari-612.3.3.1-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp Diff Modified: branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog (285246 => 285247) --- branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog 2021-11-04 00:05:38 UTC (rev 285246) +++ branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog 2021-11-04 00:12:21 UTC (rev 285247) @@ -1,47 +1,3 @@ -2021-11-03 Russell Epstein - -Cherry-pick r285241. rdar://problem/84990898 - -[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent -https://bugs.webkit.org/show_bug.cgi?id=232687 - - -Reviewed by Eric Carlson. - -Source/WebKit: - -The default value of defaultMediaSessionCoordinatorEnabled() will be true if the UIProcess has -the correct entitlement. However, this value is not passed across the XPC boundary unless it has -been overridden, which means defaultMediaSessionCoordinatorEnabled() will control the setting -in the WebContent process, which is not entitled. - -Have the WebContent process check its parent process's entitlement rather than its own when -determining the default value for defaultMediaSessionCoordinatorEnabled(). - -* Shared/WebPreferencesDefaultValues.cpp: -(WebKit::defaultMediaSessionCoordinatorEnabled): - -Source/WTF: - -Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled. - -* Scripts/Preferences/WebPreferencesExperimental.yaml: - - -git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285241 268f45cc-cd09-0410-ab3c-d52691b4dbfc - -2021-11-03 Jer Noble - -[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent -https://bugs.webkit.org/show_bug.cgi?id=232687 - - -Reviewed by Eric Carlson. - -Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled. - -* Scripts/Preferences/WebPreferencesExperimental.yaml: - 2021-11-02 Russell Epstein Cherry-pick r283732. rdar://problem/84944569 Modified: branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (285246 => 285247) --- branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-04 00:05:38 UTC (rev 285246) +++ branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-04 00:12:21 UTC (rev 285247) @@ -780,9 +780,9 @@ WebKitLegacy: default: false WebKit: - default: WebKit::defaultMediaSessionCoordinatorEnabled() + default: false WebCore: - default: true + default: false ModelElementEnabled: type: bool Modified: branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog (285246 => 285247) --- branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-04 00:05:38 UTC (rev 285246) +++ branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-04 00:12:21 UTC (rev 285247) @@ -1,56 +1,5 @@ 2021-11-03 Russell Epstein -Cherry-pick r285241. rdar://problem/84990898 - -[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent -https://bugs.webkit.org/show_bug.cgi?id=232687 - - -Reviewed by Eric Carlson. - -Source/WebKit: - -The default value of defaultMediaSessionCoordinatorEnabled() will be true if the UIProcess has -the correct entitlement. However, this value is not passed across the XPC boundary unless it has -been overridden, which means defaultMediaSessionCoordinatorEnabled() will control the setting -in the WebContent process, which is not entitled. - -Have the WebContent process check its parent process's entitlement rather than its own when -determining the default value for defaultMediaSessionCoordinatorEnabled(). - -* Shared/WebPreferencesDefaultValues.cpp: -(WebKit::defaultMediaSessionCoordinatorEnabled): - -Source/WTF: - -Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled. - -* Scripts/Preferences/WebPreferencesExperimental.yaml: - - -git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285241 268f45cc-cd09-0410-ab3c-d52691b4dbfc - -2021-11-03 Jer Noble - -[macOS] MediaSession coordinator enabled in UIProcess, disabled in
[webkit-changes] [285246] trunk
Title: [285246] trunk
Revision 285246
Author ysuz...@apple.com
Date 2021-11-03 17:05:38 -0700 (Wed, 03 Nov 2021)
Log Message
[JSC] Clean up StructureStubInfo initialization
https://bugs.webkit.org/show_bug.cgi?id=232652
Reviewed by Saam Barati.
Source/_javascript_Core:
This patch enhances FixedVector to initialize it from the other containers.
So we can simplify baseline StructureStubInfo initialization.
Now, StructureStubInfo::initializeFromUnlinkedStructureStubInfo becomes
StructureStubInfo constructor taking const UnlinkedStructureStubInfo&.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setupWithUnlinkedBaselineCode):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo): Deleted.
* bytecode/StructureStubInfo.h:
* jit/JIT.cpp:
(JSC::JIT::link):
Source/WebCore:
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::fontForLayoutLabel):
Source/WTF:
* wtf/FixedVector.h:
(WTF::FixedVector::FixedVector):
(WTF::FixedVector::operator=):
* wtf/RefCountedArray.h:
(WTF::RefCountedArray::RefCountedArray):
(WTF::RefCountedArray::operator=):
* wtf/SegmentedVector.h:
* wtf/Vector.h:
(WTF::VectorTypeOperations::uninitializedCopy):
Tools:
* TestWebKitAPI/Tests/WTF/FixedVector.cpp:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FixedVector.h
trunk/Source/WTF/wtf/RefCountedArray.h
trunk/Source/WTF/wtf/SegmentedVector.h
trunk/Source/WTF/wtf/Vector.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (285245 => 285246)
--- trunk/Source/_javascript_Core/ChangeLog 2021-11-03 23:55:18 UTC (rev 285245)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-11-04 00:05:38 UTC (rev 285246)
@@ -1,3 +1,24 @@
+2021-11-03 Yusuke Suzuki
+
+[JSC] Clean up StructureStubInfo initialization
+https://bugs.webkit.org/show_bug.cgi?id=232652
+
+Reviewed by Saam Barati.
+
+This patch enhances FixedVector to initialize it from the other containers.
+So we can simplify baseline StructureStubInfo initialization.
+Now, StructureStubInfo::initializeFromUnlinkedStructureStubInfo becomes
+StructureStubInfo constructor taking const UnlinkedStructureStubInfo&.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::setupWithUnlinkedBaselineCode):
+* bytecode/StructureStubInfo.cpp:
+(JSC::StructureStubInfo::StructureStubInfo):
+(JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo): Deleted.
+* bytecode/StructureStubInfo.h:
+* jit/JIT.cpp:
+(JSC::JIT::link):
+
2021-11-02 Ross Kirsling
[JSC] Add LLInt fast path for OpMod on x86_64
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (285245 => 285246)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-11-03 23:55:18 UTC (rev 285245)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-11-04 00:05:38 UTC (rev 285246)
@@ -782,7 +782,7 @@
RELEASE_ASSERT(jitData.m_jitConstantPool.isEmpty());
jitData.m_jitConstantPool = FixedVector(jitCode->m_constantPool.size());
-jitData.m_stubInfos = FixedVector(jitCode->m_unlinkedStubInfos.size());
+jitData.m_stubInfos = FixedVector(jitCode->m_unlinkedStubInfos);
jitData.m_callLinkInfos = FixedVector(jitCode->m_unlinkedCalls.size());
for (size_t i = 0; i < jitCode->m_constantPool.size(); ++i) {
auto entry = jitCode->m_constantPool.at(i);
@@ -800,9 +800,7 @@
}
case JITConstantPool::Type::StructureStubInfo: {
unsigned index = bitwise_cast(entry.pointer());
-UnlinkedStructureStubInfo& unlinkedStubInfo = jitCode->m_unlinkedStubInfos[index];
StructureStubInfo& stubInfo = jitData.m_stubInfos[index];
-stubInfo.initializeFromUnlinkedStructureStubInfo(this, unlinkedStubInfo);
jitData.m_jitConstantPool[i] =
break;
}
Modified: trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp (285245 => 285246)
--- trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp 2021-11-03 23:55:18 UTC (rev 285245)
+++ trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp 2021-11-04 00:05:38 UTC (rev 285246)
@@ -415,14 +415,13 @@
m_cacheType = newCacheType;
}
-void StructureStubInfo::initializeFromUnlinkedStructureStubInfo(CodeBlock*, UnlinkedStructureStubInfo& unlinkedStubInfo)
+StructureStubInfo::StructureStubInfo(const
[webkit-changes] [285245] tags/Safari-612.3.3.1.1/
Title: [285245] tags/Safari-612.3.3.1.1/ Revision 285245 Author repst...@apple.com Date 2021-11-03 16:55:18 -0700 (Wed, 03 Nov 2021) Log Message Tag Safari-612.3.3.1.1. Added Paths tags/Safari-612.3.3.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285244] tags/Safari-612.3.3.1.1/
Title: [285244] tags/Safari-612.3.3.1.1/ Revision 285244 Author repst...@apple.com Date 2021-11-03 16:55:05 -0700 (Wed, 03 Nov 2021) Log Message Delete tag. Removed Paths tags/Safari-612.3.3.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285243] branches/safari-612.3.3.1-branch/Source
Title: [285243] branches/safari-612.3.3.1-branch/Source Revision 285243 Author repst...@apple.com Date 2021-11-03 16:53:45 -0700 (Wed, 03 Nov 2021) Log Message Cherry-pick r285241. rdar://problem/84990898 [macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent https://bugs.webkit.org/show_bug.cgi?id=232687 Reviewed by Eric Carlson. Source/WebKit: The default value of defaultMediaSessionCoordinatorEnabled() will be true if the UIProcess has the correct entitlement. However, this value is not passed across the XPC boundary unless it has been overridden, which means defaultMediaSessionCoordinatorEnabled() will control the setting in the WebContent process, which is not entitled. Have the WebContent process check its parent process's entitlement rather than its own when determining the default value for defaultMediaSessionCoordinatorEnabled(). * Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultMediaSessionCoordinatorEnabled): Source/WTF: Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled. * Scripts/Preferences/WebPreferencesExperimental.yaml: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285241 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog branches/safari-612.3.3.1-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp Diff Modified: branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog (285242 => 285243) --- branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog 2021-11-03 23:50:14 UTC (rev 285242) +++ branches/safari-612.3.3.1-branch/Source/WTF/ChangeLog 2021-11-03 23:53:45 UTC (rev 285243) @@ -1,3 +1,47 @@ +2021-11-03 Russell Epstein + +Cherry-pick r285241. rdar://problem/84990898 + +[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent +https://bugs.webkit.org/show_bug.cgi?id=232687 + + +Reviewed by Eric Carlson. + +Source/WebKit: + +The default value of defaultMediaSessionCoordinatorEnabled() will be true if the UIProcess has +the correct entitlement. However, this value is not passed across the XPC boundary unless it has +been overridden, which means defaultMediaSessionCoordinatorEnabled() will control the setting +in the WebContent process, which is not entitled. + +Have the WebContent process check its parent process's entitlement rather than its own when +determining the default value for defaultMediaSessionCoordinatorEnabled(). + +* Shared/WebPreferencesDefaultValues.cpp: +(WebKit::defaultMediaSessionCoordinatorEnabled): + +Source/WTF: + +Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285241 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-11-03 Jer Noble + +[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent +https://bugs.webkit.org/show_bug.cgi?id=232687 + + +Reviewed by Eric Carlson. + +Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2021-11-02 Russell Epstein Cherry-pick r283732. rdar://problem/84944569 Modified: branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (285242 => 285243) --- branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-03 23:50:14 UTC (rev 285242) +++ branches/safari-612.3.3.1-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-03 23:53:45 UTC (rev 285243) @@ -780,9 +780,9 @@ WebKitLegacy: default: false WebKit: - default: false + default: WebKit::defaultMediaSessionCoordinatorEnabled() WebCore: - default: false + default: true ModelElementEnabled: type: bool Modified: branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog (285242 => 285243) --- branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 23:50:14 UTC (rev 285242) +++ branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 23:53:45 UTC (rev 285243) @@ -1,5 +1,56 @@ 2021-11-03 Russell Epstein +Cherry-pick r285241. rdar://problem/84990898 + +[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent +https://bugs.webkit.org/show_bug.cgi?id=232687 + + +Reviewed by Eric Carlson. + +Source/WebKit: + +The
[webkit-changes] [285242] trunk/Source/WTF
Title: [285242] trunk/Source/WTF Revision 285242 Author ddkil...@apple.com Date 2021-11-03 16:50:14 -0700 (Wed, 03 Nov 2021) Log Message Disable WebXR on tvOS and watchOS Reviewed by Brent Fulgham. * wtf/PlatformEnableCocoa.h: (ENABLE_WEBXR): (ENABLE_WEBXR_HANDS): - Disable features on tvOS and watchOS. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformEnableCocoa.h Diff Modified: trunk/Source/WTF/ChangeLog (285241 => 285242) --- trunk/Source/WTF/ChangeLog 2021-11-03 23:46:18 UTC (rev 285241) +++ trunk/Source/WTF/ChangeLog 2021-11-03 23:50:14 UTC (rev 285242) @@ -1,3 +1,16 @@ +2021-11-03 David Kilzer + +Disable WebXR on tvOS and watchOS + + + +Reviewed by Brent Fulgham. + +* wtf/PlatformEnableCocoa.h: +(ENABLE_WEBXR): +(ENABLE_WEBXR_HANDS): +- Disable features on tvOS and watchOS. + 2021-11-03 Jer Noble [macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (285241 => 285242) --- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-11-03 23:46:18 UTC (rev 285241) +++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-11-03 23:50:14 UTC (rev 285242) @@ -628,11 +628,11 @@ #define ENABLE_WEBPROCESS_NSRUNLOOP 1 #endif -#if !defined(ENABLE_WEBXR) +#if !defined(ENABLE_WEBXR) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) #define ENABLE_WEBXR 1 #endif -#if !defined(ENABLE_WEBXR_HANDS) +#if !defined(ENABLE_WEBXR_HANDS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) #define ENABLE_WEBXR_HANDS 1 #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285241] trunk/Source
Title: [285241] trunk/Source
Revision 285241
Author jer.no...@apple.com
Date 2021-11-03 16:46:18 -0700 (Wed, 03 Nov 2021)
Log Message
[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent
https://bugs.webkit.org/show_bug.cgi?id=232687
Reviewed by Eric Carlson.
Source/WebKit:
The default value of defaultMediaSessionCoordinatorEnabled() will be true if the UIProcess has
the correct entitlement. However, this value is not passed across the XPC boundary unless it has
been overridden, which means defaultMediaSessionCoordinatorEnabled() will control the setting
in the WebContent process, which is not entitled.
Have the WebContent process check its parent process's entitlement rather than its own when
determining the default value for defaultMediaSessionCoordinatorEnabled().
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultMediaSessionCoordinatorEnabled):
Source/WTF:
Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (285240 => 285241)
--- trunk/Source/WTF/ChangeLog 2021-11-03 23:29:26 UTC (rev 285240)
+++ trunk/Source/WTF/ChangeLog 2021-11-03 23:46:18 UTC (rev 285241)
@@ -1,3 +1,15 @@
+2021-11-03 Jer Noble
+
+[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent
+https://bugs.webkit.org/show_bug.cgi?id=232687
+
+
+Reviewed by Eric Carlson.
+
+Have the MediaSessionPlaylistEnabled preference use the same defaults as MediaSessionCoordinatorEnabled.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+
2021-11-03 Chris Dumez
_pasteboardWithName should be thread-safe
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (285240 => 285241)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-03 23:29:26 UTC (rev 285240)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-03 23:46:18 UTC (rev 285241)
@@ -880,9 +880,9 @@
WebKitLegacy:
default: false
WebKit:
- default: false
+ default: WebKit::defaultMediaSessionCoordinatorEnabled()
WebCore:
- default: false
+ default: true
MediaSourceInlinePaintingEnabled:
type: bool
Modified: trunk/Source/WebKit/ChangeLog (285240 => 285241)
--- trunk/Source/WebKit/ChangeLog 2021-11-03 23:29:26 UTC (rev 285240)
+++ trunk/Source/WebKit/ChangeLog 2021-11-03 23:46:18 UTC (rev 285241)
@@ -1,3 +1,22 @@
+2021-11-03 Jer Noble
+
+[macOS] MediaSession coordinator enabled in UIProcess, disabled in WebContent
+https://bugs.webkit.org/show_bug.cgi?id=232687
+
+
+Reviewed by Eric Carlson.
+
+The default value of defaultMediaSessionCoordinatorEnabled() will be true if the UIProcess has
+the correct entitlement. However, this value is not passed across the XPC boundary unless it has
+been overridden, which means defaultMediaSessionCoordinatorEnabled() will control the setting
+in the WebContent process, which is not entitled.
+
+Have the WebContent process check its parent process's entitlement rather than its own when
+determining the default value for defaultMediaSessionCoordinatorEnabled().
+
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultMediaSessionCoordinatorEnabled):
+
2021-11-03 Tyler Wilcock
AX: WKAccessibilityWebPageObjectMac.mm should expose accessibilityChildrenInNavigationOrder and NSAccessibilityChildrenInNavigationOrderAttribute
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (285240 => 285241)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-11-03 23:29:26 UTC (rev 285240)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-11-03 23:46:18 UTC (rev 285241)
@@ -36,6 +36,7 @@
#endif
#if ENABLE(MEDIA_SESSION_COORDINATOR)
+#import "WebProcess.h"
#import
#endif
@@ -334,7 +335,10 @@
static dispatch_once_t onceToken;
static bool enabled { false };
dispatch_once(, ^{
-enabled = WTF::processHasEntitlement("com.apple.developer.group-session.urlactivity");
+if (isInWebProcess())
+enabled = WebProcess::singleton().parentProcessHasEntitlement("com.apple.developer.group-session.urlactivity");
+else
+enabled = WTF::processHasEntitlement("com.apple.developer.group-session.urlactivity");
});
return enabled;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285240] branches/safari-613.1.7-branch/Source
Title: [285240] branches/safari-613.1.7-branch/Source
Revision 285240
Author repst...@apple.com
Date 2021-11-03 16:29:26 -0700 (Wed, 03 Nov 2021)
Log Message
Cherry-pick r285110. rdar://problem/84994696
Unreviewed, reverting r285055.
Reverting because this commit may have caused
webgl/1.0.x/conformance/textures/misc/texture-corner-case-
videos.html and webgl/2.0.y/conformance/textures/misc/texture-
corner-case-videos.html to time out
Reverted changeset:
"Avoid sending video data to Web process for
canvas.drawImage(video)"
https://bugs.webkit.org/show_bug.cgi?id=230766
https://commits.webkit.org/r285055
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.7-branch/Source/WebCore/ChangeLog
branches/safari-613.1.7-branch/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
branches/safari-613.1.7-branch/Source/WebCore/platform/graphics/ImageBuffer.h
branches/safari-613.1.7-branch/Source/WebKit/ChangeLog
branches/safari-613.1.7-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
Diff
Modified: branches/safari-613.1.7-branch/Source/WebCore/ChangeLog (285239 => 285240)
--- branches/safari-613.1.7-branch/Source/WebCore/ChangeLog 2021-11-03 22:52:31 UTC (rev 285239)
+++ branches/safari-613.1.7-branch/Source/WebCore/ChangeLog 2021-11-03 23:29:26 UTC (rev 285240)
@@ -1,3 +1,39 @@
+2021-11-03 Alan Coon
+
+Cherry-pick r285110. rdar://problem/84994696
+
+Unreviewed, reverting r285055.
+
+Reverting because this commit may have caused
+webgl/1.0.x/conformance/textures/misc/texture-corner-case-
+videos.html and webgl/2.0.y/conformance/textures/misc/texture-
+corner-case-videos.html to time out
+
+Reverted changeset:
+
+"Avoid sending video data to Web process for
+canvas.drawImage(video)"
+https://bugs.webkit.org/show_bug.cgi?id=230766
+https://commits.webkit.org/r285055
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-11-01 Ayumi Kojima
+
+Unreviewed, reverting r285055.
+
+Reverting because this commit may have caused
+webgl/1.0.x/conformance/textures/misc/texture-corner-case-
+videos.html and webgl/2.0.y/conformance/textures/misc/texture-
+corner-case-videos.html to time out
+
+Reverted changeset:
+
+"Avoid sending video data to Web process for
+canvas.drawImage(video)"
+https://bugs.webkit.org/show_bug.cgi?id=230766
+https://commits.webkit.org/r285055
+
2021-11-01 Daniel Kolesa
Fix build with GCC 8.4 on Ubuntu 18.04
Modified: branches/safari-613.1.7-branch/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (285239 => 285240)
--- branches/safari-613.1.7-branch/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp 2021-11-03 22:52:31 UTC (rev 285239)
+++ branches/safari-613.1.7-branch/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp 2021-11-03 23:29:26 UTC (rev 285240)
@@ -1677,19 +1677,17 @@
checkOrigin();
#if USE(CG)
-if (!canvasBase().buffer()->isRemote()) {
-if (auto image = video.nativeImageForCurrentTime()) {
-c->drawNativeImage(*image, FloatSize(video.videoWidth(), video.videoHeight()), dstRect, srcRect);
+if (auto image = video.nativeImageForCurrentTime()) {
+c->drawNativeImage(*image, FloatSize(video.videoWidth(), video.videoHeight()), dstRect, srcRect);
-if (isEntireBackingStoreDirty())
-didDraw(std::nullopt);
-else if (rectContainsCanvas(dstRect))
-didDrawEntireCanvas();
-else
-didDraw(dstRect);
+if (isEntireBackingStoreDirty())
+didDraw(std::nullopt);
+else if (rectContainsCanvas(dstRect))
+didDrawEntireCanvas();
+else
+didDraw(dstRect);
-return { };
-}
+return { };
}
#endif
Modified: branches/safari-613.1.7-branch/Source/WebCore/platform/graphics/ImageBuffer.h (285239 => 285240)
--- branches/safari-613.1.7-branch/Source/WebCore/platform/graphics/ImageBuffer.h 2021-11-03 22:52:31 UTC (rev 285239)
+++ branches/safari-613.1.7-branch/Source/WebCore/platform/graphics/ImageBuffer.h 2021-11-03 23:29:26 UTC (rev 285240)
@@ -71,7 +71,6 @@
virtual RenderingMode renderingMode() const = 0;
virtual bool canMapBackingStore() const = 0;
-virtual bool isRemote() const { return false; }
virtual RenderingResourceIdentifier renderingResourceIdentifier() const { return { }; }
virtual GraphicsContext& context() const = 0;
Modified: branches/safari-613.1.7-branch/Source/WebKit/ChangeLog (285239 => 285240)
--- branches/safari-613.1.7-branch/Source/WebKit/ChangeLog 2021-11-03 22:52:31 UTC (rev
[webkit-changes] [285239] branches/safari-612.3.3.0-branch
Title: [285239] branches/safari-612.3.3.0-branch
Revision 285239
Author repst...@apple.com
Date 2021-11-03 15:52:31 -0700 (Wed, 03 Nov 2021)
Log Message
Apply patch. rdar://problem/84982191
Modified Paths
branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog
branches/safari-612.3.3.0-branch/Source/WebCore/loader/PrivateClickMeasurement.cpp
branches/safari-612.3.3.0-branch/Source/WebCore/loader/PrivateClickMeasurement.h
branches/safari-612.3.3.0-branch/Source/WebKit/ChangeLog
branches/safari-612.3.3.0-branch/Source/WebKit/ChangeLog.orig
branches/safari-612.3.3.0-branch/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp
branches/safari-612.3.3.0-branch/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h
branches/safari-612.3.3.0-branch/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.cpp
branches/safari-612.3.3.0-branch/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.h
branches/safari-612.3.3.0-branch/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp
branches/safari-612.3.3.0-branch/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.h
branches/safari-612.3.3.0-branch/Tools/ChangeLog
branches/safari-612.3.3.0-branch/Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp
Diff
Modified: branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog (285238 => 285239)
--- branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog 2021-11-03 22:41:25 UTC (rev 285238)
+++ branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog 2021-11-03 22:52:31 UTC (rev 285239)
@@ -1,3 +1,24 @@
+2021-11-03 Russell Epstein
+
+Apply patch. rdar://problem/84982191
+
+2021-11-03 Kate Cheney
+
+PCM: Safari on iOS and macOS are not sending ad click attribution reports for Private Click Measurement
+https://bugs.webkit.org/show_bug.cgi?id=228104
+
+
+Reviewed by John Wilander.
+
+No new tests. Several existing tests would timeout with the removal of
+m_firePendingAttributionRequestsTimer.startOneShot(m_isRunningTest ? 0_s : seconds)
+if the fix wasn't in place.
+
+* loader/PrivateClickMeasurement.cpp:
+(WebCore::randomlyBetweenTwentyFourAndFortyEightHours):
+(WebCore::PrivateClickMeasurement::attributeAndGetEarliestTimeToSend):
+* loader/PrivateClickMeasurement.h:
+
2021-11-02 Russell Epstein
Cherry-pick r283732. rdar://problem/84944569
Modified: branches/safari-612.3.3.0-branch/Source/WebCore/loader/PrivateClickMeasurement.cpp (285238 => 285239)
--- branches/safari-612.3.3.0-branch/Source/WebCore/loader/PrivateClickMeasurement.cpp 2021-11-03 22:41:25 UTC (rev 285238)
+++ branches/safari-612.3.3.0-branch/Source/WebCore/loader/PrivateClickMeasurement.cpp 2021-11-03 22:52:31 UTC (rev 285239)
@@ -148,12 +148,12 @@
m_sourceApplicationBundleID = appBundleIDForTesting;
}
-static Seconds randomlyBetweenTwentyFourAndFortyEightHours()
+static Seconds randomlyBetweenTwentyFourAndFortyEightHours(PrivateClickMeasurement::IsRunningLayoutTest isRunningTest)
{
-return 24_h + Seconds(randomNumber() * (24_h).value());
+return isRunningTest == PrivateClickMeasurement::IsRunningLayoutTest::Yes ? 1_s : 24_h + Seconds(randomNumber() * (24_h).value());
}
-PrivateClickMeasurement::AttributionSecondsUntilSendData PrivateClickMeasurement::attributeAndGetEarliestTimeToSend(AttributionTriggerData&& attributionTriggerData)
+PrivateClickMeasurement::AttributionSecondsUntilSendData PrivateClickMeasurement::attributeAndGetEarliestTimeToSend(AttributionTriggerData&& attributionTriggerData, IsRunningLayoutTest isRunningTest)
{
if (!attributionTriggerData.isValid() || (m_attributionTriggerData && m_attributionTriggerData->priority >= attributionTriggerData.priority))
return { };
@@ -161,8 +161,8 @@
m_attributionTriggerData = WTFMove(attributionTriggerData);
// 24-48 hour delay before sending. This helps privacy since the conversion and the attribution
// requests are detached and the time of the attribution does not reveal the time of the conversion.
-auto sourceSecondsUntilSend = randomlyBetweenTwentyFourAndFortyEightHours();
-auto destinationSecondsUntilSend = randomlyBetweenTwentyFourAndFortyEightHours();
+auto sourceSecondsUntilSend = randomlyBetweenTwentyFourAndFortyEightHours(isRunningTest);
+auto destinationSecondsUntilSend = randomlyBetweenTwentyFourAndFortyEightHours(isRunningTest);
m_timesToSend = { WallTime::now() + sourceSecondsUntilSend, WallTime::now() + destinationSecondsUntilSend };
return AttributionSecondsUntilSendData { sourceSecondsUntilSend, destinationSecondsUntilSend };
Modified: branches/safari-612.3.3.0-branch/Source/WebCore/loader/PrivateClickMeasurement.h (285238 => 285239)
---
[webkit-changes] [285238] trunk/LayoutTests
Title: [285238] trunk/LayoutTests Revision 285238 Author nmouchta...@apple.com Date 2021-11-03 15:41:25 -0700 (Wed, 03 Nov 2021) Log Message Add platform test expectations for imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html https://bugs.webkit.org/show_bug.cgi?id=232504 Reviewed by Myles Maxfield. Fix expectations for Big Sur wk1. * platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added. * platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/ trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/relations/ trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/relations/html5-tree/ trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt trunk/LayoutTests/platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/html5-tree/ trunk/LayoutTests/platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt Removed Paths trunk/LayoutTests/platform/mac-bigsur-wk2/imported/w3c/web-platform-tests/mathml/ trunk/LayoutTests/platform/mac-catalina-wk2/imported/w3c/web-platform-tests/mathml/ Diff Modified: trunk/LayoutTests/ChangeLog (285237 => 285238) --- trunk/LayoutTests/ChangeLog 2021-11-03 22:40:59 UTC (rev 285237) +++ trunk/LayoutTests/ChangeLog 2021-11-03 22:41:25 UTC (rev 285238) @@ -1,3 +1,15 @@ +2021-11-03 Nikos Mouchtaris + +Add platform test expectations for imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html +https://bugs.webkit.org/show_bug.cgi?id=232504 + +Reviewed by Myles Maxfield. + +Fix expectations for Big Sur wk1. + +* platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added. +* platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added. + 2021-11-03 Rob Buis Return nullopt in aspect-ratio+intrinsic width case Copied: trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt (from rev 285236, trunk/LayoutTests/platform/mac-catalina-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt) (0 => 285238) --- trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt (rev 0) +++ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt 2021-11-03 22:41:25 UTC (rev 285238) @@ -0,0 +1,101 @@ + +PASS Adding missing children to mfrac +PASS Removing child from valid mfrac +FAIL Adding child to valid mfrac assert_approx_equals: block position (child 1) expected 0 +/- 1 but got 13.234375 +PASS Removing extra child from mfrac +PASS Adding missing children to munder +PASS Removing child from valid munder +FAIL Adding child to valid munder assert_approx_equals: block position (child 1) expected 0 +/- 1 but got 11.90625 +PASS Removing extra child from munder +PASS Adding missing children to mover +FAIL Removing child from valid mover assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 22.53125 +FAIL Adding child to valid mover assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 22.53125 +PASS Removing extra child from mover +PASS Adding missing children to munderover +FAIL Removing child from valid munderover assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 32.53125 +FAIL Adding child to valid munderover assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 32.53125 +PASS Removing extra child from munderover +PASS Adding missing children to msub +PASS Removing child from valid msub +FAIL Adding child to valid msub assert_approx_equals: inline position (child 1) expected 0 +/- 1 but got 10 +PASS Removing extra child from msub +PASS Adding missing children to msup +FAIL Removing child from valid msup assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 16 +FAIL Adding child to valid msup assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 16 +PASS Removing extra child from msup +PASS Adding missing children to msubsup +FAIL Removing child from valid msubsup assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 26 +FAIL Adding child to valid msubsup
[webkit-changes] [285237] branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/ NetworkProcessProxy.cpp
Title: [285237] branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
Revision 285237
Author repst...@apple.com
Date 2021-11-03 15:40:59 -0700 (Wed, 03 Nov 2021)
Log Message
Unreviewed build fix. rdar://problem/84987165.
error: no viable constructor or deduction guide for deduction of template arguments of 'WeakPtr'
Modified Paths
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
Diff
Modified: branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (285236 => 285237)
--- branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-11-03 22:36:44 UTC (rev 285236)
+++ branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-11-03 22:40:59 UTC (rev 285237)
@@ -154,7 +154,7 @@
// time period to avoid generating too many crash reports with same back trace on user's device.
if (shouldTerminateNetworkProcessBySendingMessage()) {
sendMessage(makeUniqueRef(IPC::MessageName::Terminate, 0), { });
-RunLoop::main().dispatchAfter(1_s, [weakThis = WeakPtr { *this }] () mutable {
+RunLoop::main().dispatchAfter(1_s, [weakThis = makeWeakPtr(*this)] () mutable {
if (weakThis)
weakThis->terminate();
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285236] trunk/Source
Title: [285236] trunk/Source Revision 285236 Author commit-qu...@webkit.org Date 2021-11-03 15:36:44 -0700 (Wed, 03 Nov 2021) Log Message AX: WKAccessibilityWebPageObjectMac.mm should expose accessibilityChildrenInNavigationOrder and NSAccessibilityChildrenInNavigationOrderAttribute https://bugs.webkit.org/show_bug.cgi?id=232654 Patch by Tyler Wilcock on 2021-11-03 Reviewed by Chris Fleizach. Some clients expect accessibilityChildrenInNavigationOrder and NSAccessibilityChildrenInNavigationOrderAttribute to be available, and WKAccessibilityWebPageObjectMac didn't expose them. Source/WebCore: * accessibility/mac/WebAccessibilityObjectWrapperMac.h: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Move #define NSAccessibilityChildrenInNavigationOrderAttribute to header so it can be used in the WebKit layer. Source/WebKit: * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: (-[WKAccessibilityWebPageObject accessibilityChildrenInNavigationOrder]): Added. (-[WKAccessibilityWebPageObject accessibilityAttributeValue:]): Handle NSAccessibilityChildrenInNavigationOrderAttribute. (-[WKAccessibilityWebPageObject accessibilityAttributeNames:]): Add NSAccessibilityChildrenInNavigationOrderAttribute. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (285235 => 285236) --- trunk/Source/WebCore/ChangeLog 2021-11-03 22:18:37 UTC (rev 285235) +++ trunk/Source/WebCore/ChangeLog 2021-11-03 22:36:44 UTC (rev 285236) @@ -1,3 +1,19 @@ +2021-11-03 Tyler Wilcock + +AX: WKAccessibilityWebPageObjectMac.mm should expose accessibilityChildrenInNavigationOrder and NSAccessibilityChildrenInNavigationOrderAttribute +https://bugs.webkit.org/show_bug.cgi?id=232654 + +Reviewed by Chris Fleizach. + +Some clients expect accessibilityChildrenInNavigationOrder and +NSAccessibilityChildrenInNavigationOrderAttribute to be available, +and WKAccessibilityWebPageObjectMac didn't expose them. + +* accessibility/mac/WebAccessibilityObjectWrapperMac.h: +* accessibility/mac/WebAccessibilityObjectWrapperMac.mm: +Move #define NSAccessibilityChildrenInNavigationOrderAttribute to +header so it can be used in the WebKit layer. + 2021-11-03 Joonghun Park border-radius inline style should serialize with valid syntax Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h (285235 => 285236) --- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h 2021-11-03 22:18:37 UTC (rev 285235) +++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h 2021-11-03 22:36:44 UTC (rev 285236) @@ -37,6 +37,10 @@ #define NSAccessibilityPrimaryScreenHeightAttribute @"_AXPrimaryScreenHeight" #endif +#ifndef NSAccessibilityChildrenInNavigationOrderAttribute +#define NSAccessibilityChildrenInNavigationOrderAttribute @"AXChildrenInNavigationOrder" +#endif + @interface WebAccessibilityObjectWrapper : WebAccessibilityObjectWrapperBase // FIXME: Remove these methods since clients should not need to call them and hence should not be exposed in the public interface. Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (285235 => 285236) --- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2021-11-03 22:18:37 UTC (rev 285235) +++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2021-11-03 22:36:44 UTC (rev 285236) @@ -152,10 +152,6 @@ #define NSAccessibilityBlockQuoteLevelAttribute @"AXBlockQuoteLevel" #endif -#ifndef NSAccessibilityChildrenInNavigationOrderAttribute -#define NSAccessibilityChildrenInNavigationOrderAttribute @"AXChildrenInNavigationOrder" -#endif - #ifndef NSAccessibilityAccessKeyAttribute #define NSAccessibilityAccessKeyAttribute @"AXAccessKey" #endif Modified: trunk/Source/WebKit/ChangeLog (285235 => 285236) --- trunk/Source/WebKit/ChangeLog 2021-11-03 22:18:37 UTC (rev 285235) +++ trunk/Source/WebKit/ChangeLog 2021-11-03 22:36:44 UTC (rev 285236) @@ -1,3 +1,21 @@ +2021-11-03 Tyler Wilcock + +AX: WKAccessibilityWebPageObjectMac.mm should expose accessibilityChildrenInNavigationOrder and NSAccessibilityChildrenInNavigationOrderAttribute +https://bugs.webkit.org/show_bug.cgi?id=232654 + +Reviewed by Chris Fleizach. + +Some clients expect accessibilityChildrenInNavigationOrder and +NSAccessibilityChildrenInNavigationOrderAttribute to be available, +and WKAccessibilityWebPageObjectMac didn't expose them. + +* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: +(-[WKAccessibilityWebPageObject
[webkit-changes] [285235] trunk
Title: [285235] trunk Revision 285235 Author jh718.p...@samsung.com Date 2021-11-03 15:18:37 -0700 (Wed, 03 Nov 2021) Log Message border-radius inline style should serialize with valid syntax https://bugs.webkit.org/show_bug.cgi?id=183994 This patch have border-radius property serializes in canonical order as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add more test case results. * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add more test cases. Source/WebCore: * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::borderRadiusValue const): * css/StyleProperties.h: * css/parser/CSSPropertyParser.cpp: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/StyleProperties.h trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285234 => 285235) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 22:07:25 UTC (rev 285234) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 22:18:37 UTC (rev 285235) @@ -1,3 +1,16 @@ +2021-11-03 Joonghun Park + +border-radius inline style should serialize with valid syntax +https://bugs.webkit.org/show_bug.cgi?id=183994 + +This patch have border-radius property serializes in canonical order +as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add more test case results. +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add more test cases. + 2021-11-03 Chris Dumez _javascript_ URLs do not run in the right context when using frame targeting Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt (285234 => 285235) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-03 22:07:25 UTC (rev 285234) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-03 22:18:37 UTC (rev 285235) @@ -1,13 +1,19 @@ PASS e.style['border-radius'] = "1px" should set the property value +PASS e.style['border-radius'] = "1px 5%" should set the property value +PASS e.style['border-radius'] = "1px 2% 3px" should set the property value PASS e.style['border-radius'] = "1px 2% 3px 4%" should set the property value -FAIL e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value assert_equals: serialization should be canonical expected "5em / 1px 2% 3px 4%" but got "5em 1px 5em 2% 5em 3px 5em 4%" -FAIL e.style['border-radius'] = "1px 2% 3px 4% / 5em" should set the property value assert_equals: serialization should be canonical expected "1px 2% 3px 4% / 5em" but got "1px 5em 2% 5em 3px 5em 4% 5em" -FAIL e.style['border-radius'] = "1px 1px 1px 2% / 1px 2% 1px 2%" should set the property value assert_equals: serialization should be canonical expected "1px 1px 1px 2% / 1px 2%" but got "1px 1px 2% 1px 2%" -FAIL e.style['border-radius'] = "1px 1px 1px 1px / 1px 1px 2% 1px" should set the property value assert_equals: serialization should be canonical expected "1px / 1px 1px 2%" but got "1px 1px 1px 2%" +PASS e.style['border-radius'] = "1px / 2px" should set the property value +PASS e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value +PASS e.style['border-radius'] = "1px 2% / 3px 4px" should set the property value +PASS e.style['border-radius'] = "1px 2px 3em / 1px 2px 3%" should set the property value +PASS e.style['border-radius'] = "1px 2% / 2px 3em 4px 5em" should set the property value +PASS e.style['border-radius'] = "1px 2% 3px 4% / 5em" should set the property value +PASS e.style['border-radius'] = "1px 1px 1px 2% / 1px 2% 1px 2%" should set the property value +PASS e.style['border-radius'] = "1px 1px 1px 1px / 1px 1px 2% 1px" should set the property value PASS e.style['border-radius'] = "1px 1px 2% 2%" should set the property value PASS e.style['border-radius'] = "1px 2% 1px 1px" should set the property value -FAIL e.style['border-radius'] = "1px 2% 2% 2% / 1px 2% 3px 2%" should set the property value assert_equals: serialization should be canonical expected "1px 2% 2% / 1px 2% 3px" but got "1px 2% 2% 3px" +PASS e.style['border-radius'] = "1px 2% 2% 2% / 1px 2% 3px 2%" should set the
[webkit-changes] [285234] trunk/Source/WebCore
Title: [285234] trunk/Source/WebCore
Revision 285234
Author ddkil...@apple.com
Date 2021-11-03 15:07:25 -0700 (Wed, 03 Nov 2021)
Log Message
Fix consistency issues with localized strings and regenerate localizable.strings
Reviewed by Megan Gardner.
* en.lproj/Localizable.strings:
- Regenerate the file using update-webkit-localizable-strings.
- List of strings realphabetized, except as noted below.
("%@ (%@ Internet plug-in)"): Delete.
- Removed in r285047 for Bug 232462.
* platform/LocalizedStrings.cpp:
(WebCore::addTextTrackKindEasyReaderSuffix):
- Fix unlocalized string that regressed in r278202 for
Bug 226361.
(WebCore::useBlockedPlugInContextMenuTitle):
- Remove unneeded call to WebCore::formatLocalizedString() since
there are no placeholders to replace.
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagShowFonts):
- Switch from calling WebCore::localizedNSString() directly to
using WEB_UI_NSSTRING() so these strings will be found by
update-webkit-localizable-strings.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/en.lproj/Localizable.strings
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (285233 => 285234)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 22:03:05 UTC (rev 285233)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 22:07:25 UTC (rev 285234)
@@ -1,3 +1,31 @@
+2021-11-03 David Kilzer
+
+Fix consistency issues with localized strings and regenerate localizable.strings
+
+
+Reviewed by Megan Gardner.
+
+* en.lproj/Localizable.strings:
+- Regenerate the file using update-webkit-localizable-strings.
+- List of strings realphabetized, except as noted below.
+("%@ (%@ Internet plug-in)"): Delete.
+- Removed in r285047 for Bug 232462.
+
+* platform/LocalizedStrings.cpp:
+(WebCore::addTextTrackKindEasyReaderSuffix):
+- Fix unlocalized string that regressed in r278202 for
+ Bug 226361.
+(WebCore::useBlockedPlugInContextMenuTitle):
+- Remove unneeded call to WebCore::formatLocalizedString() since
+ there are no placeholders to replace.
+
+* platform/cocoa/LocalizedStringsCocoa.mm:
+(WebCore::contextMenuItemTagSearchWeb):
+(WebCore::contextMenuItemTagShowFonts):
+- Switch from calling WebCore::localizedNSString() directly to
+ using WEB_UI_NSSTRING() so these strings will be found by
+ update-webkit-localizable-strings.
+
2021-11-03 Rob Buis
Return nullopt in aspect-ratio+intrinsic width case
Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (285233 => 285234)
--- trunk/Source/WebCore/en.lproj/Localizable.strings 2021-11-03 22:03:05 UTC (rev 285233)
+++ trunk/Source/WebCore/en.lproj/Localizable.strings 2021-11-03 22:07:25 UTC (rev 285234)
@@ -13,9 +13,6 @@
/* window title for a standalone image (uses multiplication symbol, not x) */
"%@ %@×%@ pixels" = "%@ %@×%@ pixels";
-/* visible name of the plug-in host process. The first argument is the plug-in name and the second argument is the application name. */
-"%@ (%@ Internet plug-in)" = "%@ (%@ Internet plug-in)";
-
/* Audio/Text track display name format that includes the label and language of the track, in the form of 'Language (Label)'. */
"%@ (%@) (audio/text track)" = "%@ (%@)";
@@ -103,8 +100,8 @@
/* Present the element when a single is selected (iOS only) */
"1 Item" = "1 Item";
-/* 1× media controls context menu playback speed label */
-"1× (Media Controls Menu Playback Speed)" = "1×";
+/* Option in segmented control for choosing list type in text editing */
+"1. 2. 3." = "1. 2. 3.";
/* 1.25× media controls context menu playback speed label */
"1.25× (Media Controls Menu Playback Speed)" = "1.25×";
@@ -112,15 +109,15 @@
/* 1.5× media controls context menu playback speed label */
"1.5× (Media Controls Menu Playback Speed)" = "1.5×";
-/* Option in segmented control for choosing list type in text editing */
-"1. 2. 3." = "1. 2. 3.";
+/* 1× media controls context menu playback speed label */
+"1× (Media Controls Menu Playback Speed)" = "1×";
+/* Menu item title for KEYGEN pop-up menu */
+"2048 (High Grade)" = "2048 (High Grade)";
+
/* 2× media controls context menu playback speed label */
"2× (Media Controls Menu Playback Speed)" = "2×";
-/* Menu item title for KEYGEN pop-up menu */
-"2048 (High Grade)" = "2048 (High Grade)";
-
/* Name of application's single WebCrypto master key in Keychain */
" WebCrypto Master Key" = " WebCrypto Master Key";
@@ -130,9 +127,6 @@
/* WKErrorJavaScriptExceptionOccurred description */
"A _javascript_ exception occurred" = "A _javascript_ exception occurred";
-/* Add to Quick Note context menu item. */
-"Add to Quick Note" = "Add to Quick Note";
-
/* Label for the add
[webkit-changes] [285233] trunk/Source/WebKit
Title: [285233] trunk/Source/WebKit Revision 285233 Author wenson_hs...@apple.com Date 2021-11-03 15:03:05 -0700 (Wed, 03 Nov 2021) Log Message [GPU Process] Rendering backend may stop processing IPC stream messages after a sync message timeout https://bugs.webkit.org/show_bug.cgi?id=232580 Reviewed by Tim Horton. Currently, it's possible for sync IPC messages that are sent through IPC streams to time out and subsequently cause the IPC stream server (e.g. RemoteRenderingBackend) to stop processing IPC stream messages altogether. The following example illustrates how this might happen: 1. Web process sends the sync message at offset `n` (relative to the start of the ring buffer). Web process then begins to wait for the sync stream response under `tryAcquireAll()`. 2. GPU process receives the sync message, and takes a while (> 1 sec.) attempting to dispatch it. 3. Meanwhile in the web process, we hit the IPC timeout and bail from `tryAcquireAll()`. The client offset is still at `n`. Shortly afterwards, the web process tries to send a regular stream message, calling `tryAcquire()` and waiting for the client semaphore to be signaled. 4. The GPU process finally finishes dispatching the sync message from (2), sends a sync reply (unaware that the web process has already given up waiting), and finally calls `releaseAll()`, signaling the client semaphore. The server offset is then reset back to 0. 5. The web process finishes waiting, returns from `tryAcquire()`, proceeds to write the new stream message after offset `n`, and wakes up the GPU process with the intention of handling this message. 6. The GPU process wakes up and begins reading from offset 0. The first message it encounters is the `SyncMessageReply` it just wrote in step (4), and subsequently bails from the processing loop because it isn't capable of dispatching this message (which was meant to be consumed in the web process in the first place). In summary, the sync IPC timeout causes us to enter a state where the web process continues to encode messages at the buffer offset prior to timeout (i.e. offset `n`), while the GPU process is reading from the start of the buffer (offset `0`). To avoid this, simply replace the timeouts when synchronously grabbing image data from the GPU process. This ensures that we're never in a state where we're continuing to send stream messages to a rendering backend connection stream after timing out when waiting for a previous sync message to that stream to finish. * WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::sharedMemoryForGetPixelBuffer): (WebKit::RemoteRenderingBackendProxy::waitForGetPixelBufferToComplete): * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h Diff Modified: trunk/Source/WebKit/ChangeLog (285232 => 285233) --- trunk/Source/WebKit/ChangeLog 2021-11-03 22:01:56 UTC (rev 285232) +++ trunk/Source/WebKit/ChangeLog 2021-11-03 22:03:05 UTC (rev 285233) @@ -1,3 +1,48 @@ +2021-11-03 Wenson Hsieh + +[GPU Process] Rendering backend may stop processing IPC stream messages after a sync message timeout +https://bugs.webkit.org/show_bug.cgi?id=232580 + +Reviewed by Tim Horton. + +Currently, it's possible for sync IPC messages that are sent through IPC streams to time out and subsequently +cause the IPC stream server (e.g. RemoteRenderingBackend) to stop processing IPC stream messages altogether. The +following example illustrates how this might happen: + +1. Web process sends the sync message at offset `n` (relative to the start of the ring buffer). +Web process then begins to wait for the sync stream response under `tryAcquireAll()`. + +2. GPU process receives the sync message, and takes a while (> 1 sec.) attempting to dispatch it. + +3. Meanwhile in the web process, we hit the IPC timeout and bail from `tryAcquireAll()`. The client offset +is still at `n`. Shortly afterwards, the web process tries to send a regular stream message, calling +`tryAcquire()` and waiting for the client semaphore to be signaled. + +4. The GPU process finally finishes dispatching the sync message from (2), sends a sync reply (unaware that +the web process has already given up waiting), and finally calls `releaseAll()`, signaling the client +semaphore. The server offset is then reset back to 0. + +5. The web process finishes waiting, returns from
[webkit-changes] [285232] trunk
Title: [285232] trunk
Revision 285232
Author commit-qu...@webkit.org
Date 2021-11-03 15:01:56 -0700 (Wed, 03 Nov 2021)
Log Message
Return nullopt in aspect-ratio+intrinsic width case
https://bugs.webkit.org/show_bug.cgi?id=230769
Patch by Rob Buis on 2021-11-03
Reviewed by Javier Fernandez.
Source/WebCore:
Return nullopt in aspect-ratio+intrinsic width case, while
calculating preferred widths we do not know the container width yet,
so we can't determine the logical height reliably from it.
Test: fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):
LayoutTests:
* fast/css-grid-layout/aspect-ratio-auto-repeat-crash-expected.txt: Added.
* fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash-expected.txt
trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (285231 => 285232)
--- trunk/LayoutTests/ChangeLog 2021-11-03 21:58:27 UTC (rev 285231)
+++ trunk/LayoutTests/ChangeLog 2021-11-03 22:01:56 UTC (rev 285232)
@@ -1,3 +1,13 @@
+2021-11-03 Rob Buis
+
+Return nullopt in aspect-ratio+intrinsic width case
+https://bugs.webkit.org/show_bug.cgi?id=230769
+
+Reviewed by Javier Fernandez.
+
+* fast/css-grid-layout/aspect-ratio-auto-repeat-crash-expected.txt: Added.
+* fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html: Added.
+
2021-11-03 Eric Hutchison
Rebaseline http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html.
Added: trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash-expected.txt (0 => 285232)
--- trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash-expected.txt 2021-11-03 22:01:56 UTC (rev 285232)
@@ -0,0 +1 @@
+This test has PASSED if it does not CRASH.
Added: trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html (0 => 285232)
--- trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html 2021-11-03 22:01:56 UTC (rev 285232)
@@ -0,0 +1,19 @@
+
+ html {
+display: table;
+ }
+ head {
+aspect-ratio: 1;
+border-block-end: 15px solid;
+display: grid;
+grid-gap: 100%;
+grid-template-rows: 1% repeat(auto-fill, 20px) 0;
+padding-bottom: 5px;
+padding-left: 40px;
+ }
+
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+This test has PASSED if it does not CRASH.
Modified: trunk/Source/WebCore/ChangeLog (285231 => 285232)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 21:58:27 UTC (rev 285231)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 22:01:56 UTC (rev 285232)
@@ -1,3 +1,19 @@
+2021-11-03 Rob Buis
+
+Return nullopt in aspect-ratio+intrinsic width case
+https://bugs.webkit.org/show_bug.cgi?id=230769
+
+Reviewed by Javier Fernandez.
+
+Return nullopt in aspect-ratio+intrinsic width case, while
+calculating preferred widths we do not know the container width yet,
+so we can't determine the logical height reliably from it.
+
+Test: fast/css-grid-layout/aspect-ratio-auto-repeat-crash.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):
+
2021-11-03 Alex Christensen
[ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (285231 => 285232)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2021-11-03 21:58:27 UTC (rev 285231)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2021-11-03 22:01:56 UTC (rev 285232)
@@ -3178,6 +3178,9 @@
LayoutUnit contentBoxHeight = adjustContentBoxLogicalHeightForBoxSizing((LayoutUnit)styleToUse.logicalHeight().value());
availableHeight = std::max(0_lu, constrainContentBoxLogicalHeightByMinMax(contentBoxHeight - scrollbarLogicalHeight(), std::nullopt));
} else if (shouldComputeLogicalHeightFromAspectRatio()) {
+// Only grid is expected to be in a state where it is calculating pref width and having unknown logical width.
+if (isRenderGrid() && preferredLogicalWidthsDirty() && !style().logicalWidth().isFixed())
+return availableHeight;
availableHeight = blockSizeFromAspectRatio(horizontalBorderAndPaddingExtent(), verticalBorderAndPaddingExtent(), LayoutUnit(style().logicalAspectRatio()), style().boxSizingForAspectRatio(), logicalWidth());
} else if
[webkit-changes] [285231] trunk/Source/WebCore
Title: [285231] trunk/Source/WebCore
Revision 285231
Author commit-qu...@webkit.org
Date 2021-11-03 14:58:27 -0700 (Wed, 03 Nov 2021)
Log Message
[ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
https://bugs.webkit.org/show_bug.cgi?id=232676
Patch by Alex Christensen on 2021-11-03
Reviewed by Eric Carlson.
In r284743 we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
Remove some unsafe early returns.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer resolveBounds]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (285230 => 285231)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 21:56:42 UTC (rev 285230)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 21:58:27 UTC (rev 285231)
@@ -1,3 +1,17 @@
+2021-11-03 Alex Christensen
+
+[ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
+https://bugs.webkit.org/show_bug.cgi?id=232676
+
+Reviewed by Eric Carlson.
+
+In r284743 we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
+Remove some unsafe early returns.
+
+* platform/ios/VideoFullscreenInterfaceAVKit.mm:
+(-[WebAVPlayerLayer layoutSublayers]):
+(-[WebAVPlayerLayer resolveBounds]):
+
2021-11-03 Chris Dumez
Clicking a link should preconnect to destination as first party
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (285230 => 285231)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2021-11-03 21:56:42 UTC (rev 285230)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2021-11-03 21:58:27 UTC (rev 285231)
@@ -289,9 +289,6 @@
if ([_videoSublayer superlayer] != self)
return;
-if (![_avPlayerController delegate])
-return;
-
[_videoSublayer setPosition:CGPointMake(CGRectGetMidX(self.bounds), CGRectGetMidY(self.bounds))];
if (self.videoDimensions.height <= 0 || self.videoDimensions.width <= 0)
@@ -328,8 +325,6 @@
- (void)resolveBounds
{
[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(resolveBounds) object:nil];
-if (![_avPlayerController delegate])
-return;
if ([_videoSublayer superlayer] != self)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285230] trunk/Tools
Title: [285230] trunk/Tools
Revision 285230
Author commit-qu...@webkit.org
Date 2021-11-03 14:56:42 -0700 (Wed, 03 Nov 2021)
Log Message
[ iOS Debug ] TestWebKitAPI.ResourceLoadStatistics.GrandfatherCallback is failing
https://bugs.webkit.org/show_bug.cgi?id=232675
Patch by Alex Christensen on 2021-11-03
Reviewed by Kate Cheney.
Clearing website data attempts a connection with the daemon.
For now, just tell it not to connect to the daemon.
* TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm
Diff
Modified: trunk/Tools/ChangeLog (285229 => 285230)
--- trunk/Tools/ChangeLog 2021-11-03 21:32:23 UTC (rev 285229)
+++ trunk/Tools/ChangeLog 2021-11-03 21:56:42 UTC (rev 285230)
@@ -1,3 +1,16 @@
+2021-11-03 Alex Christensen
+
+[ iOS Debug ] TestWebKitAPI.ResourceLoadStatistics.GrandfatherCallback is failing
+https://bugs.webkit.org/show_bug.cgi?id=232675
+
+Reviewed by Kate Cheney.
+
+Clearing website data attempts a connection with the daemon.
+For now, just tell it not to connect to the daemon.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
+(TEST):
+
2021-11-03 Chris Dumez
_pasteboardWithName should be thread-safe
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm (285229 => 285230)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm 2021-11-03 21:32:23 UTC (rev 285229)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm 2021-11-03 21:56:42 UTC (rev 285230)
@@ -83,7 +83,9 @@
TEST(ResourceLoadStatistics, GrandfatherCallback)
{
-auto *dataStore = [WKWebsiteDataStore defaultDataStore];
+auto dataStoreConfiguration = adoptNS([_WKWebsiteDataStoreConfiguration new]);
+dataStoreConfiguration.get().pcmMachServiceName = nil;
+auto dataStore = adoptNS([[WKWebsiteDataStore alloc] _initWithConfiguration:dataStoreConfiguration.get()]);
NSURL *statisticsDirectoryURL = [NSURL fileURLWithPath:[@"~/Library/WebKit/com.apple.WebKit.TestWebKitAPI/WebsiteData/ResourceLoadStatistics" stringByExpandingTildeInPath] isDirectory:YES];
NSURL *fileURL = [statisticsDirectoryURL URLByAppendingPathComponent:@"observations.db"];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285229] trunk/Source/WebKit
Title: [285229] trunk/Source/WebKit Revision 285229 Author timothy_hor...@apple.com Date 2021-11-03 14:32:23 -0700 (Wed, 03 Nov 2021) Log Message Fix the build. * UIProcess/Cocoa/ModelElementControllerCocoa.mm: (WebKit::ModelElementController::modelElementDidCreatePreview): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm Diff Modified: trunk/Source/WebKit/ChangeLog (285228 => 285229) --- trunk/Source/WebKit/ChangeLog 2021-11-03 21:07:06 UTC (rev 285228) +++ trunk/Source/WebKit/ChangeLog 2021-11-03 21:32:23 UTC (rev 285229) @@ -1,3 +1,10 @@ +2021-11-03 Tim Horton + +Fix the build. + +* UIProcess/Cocoa/ModelElementControllerCocoa.mm: +(WebKit::ModelElementController::modelElementDidCreatePreview): + 2021-11-03 Dean Jackson REGRESSION: AR Quicklook asset is shared instead of page URL Modified: trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm (285228 => 285229) --- trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-11-03 21:07:06 UTC (rev 285228) +++ trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-11-03 21:32:23 UTC (rev 285229) @@ -129,8 +129,8 @@ if (!m_webPageProxy.preferences().modelElementEnabled()) return; -auto uuid = adoptNS([[NSUUID alloc] initWithUUIDString:uuid]); -auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); +auto nsUUID = adoptNS([[NSUUID alloc] initWithUUIDString:uuid]); +auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:nsUUID.get()]); LOG(ModelElement, "Created remote preview with UUID %s.", uuid.utf8().data()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285228] trunk/Source
Title: [285228] trunk/Source
Revision 285228
Author d...@apple.com
Date 2021-11-03 14:07:06 -0700 (Wed, 03 Nov 2021)
Log Message
REGRESSION: AR Quicklook asset is shared instead of page URL
https://bugs.webkit.org/show_bug.cgi?id=232674
rdar://84220997
Reviewed by Antoine Quint.
There was a typo. ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
should be HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM).
Source/WebCore/PAL:
* pal/spi/ios/SystemPreviewSPI.h:
Source/WebKit:
* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (285227 => 285228)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-11-03 20:26:04 UTC (rev 285227)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-11-03 21:07:06 UTC (rev 285228)
@@ -1,3 +1,16 @@
+2021-11-03 Dean Jackson
+
+REGRESSION: AR Quicklook asset is shared instead of page URL
+https://bugs.webkit.org/show_bug.cgi?id=232674
+rdar://84220997
+
+Reviewed by Antoine Quint.
+
+There was a typo. ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+should be HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM).
+
+* pal/spi/ios/SystemPreviewSPI.h:
+
2021-10-29 Alex Christensen
Unreviewed, reverting r284917.
Modified: trunk/Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h (285227 => 285228)
--- trunk/Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h 2021-11-03 20:26:04 UTC (rev 285227)
+++ trunk/Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h 2021-11-03 21:07:06 UTC (rev 285228)
@@ -25,7 +25,7 @@
#if USE(APPLE_INTERNAL_SDK)
-#if ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
#import
#endif
@@ -59,9 +59,13 @@
@end
#endif
-#if ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+NS_ASSUME_NONNULL_END
+
+#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
#import
+NS_ASSUME_NONNULL_BEGIN
+
@protocol ARQuickLookWebKitItemDelegate
@end
Modified: trunk/Source/WebKit/ChangeLog (285227 => 285228)
--- trunk/Source/WebKit/ChangeLog 2021-11-03 20:26:04 UTC (rev 285227)
+++ trunk/Source/WebKit/ChangeLog 2021-11-03 21:07:06 UTC (rev 285228)
@@ -1,3 +1,16 @@
+2021-11-03 Dean Jackson
+
+REGRESSION: AR Quicklook asset is shared instead of page URL
+https://bugs.webkit.org/show_bug.cgi?id=232674
+rdar://84220997
+
+Reviewed by Antoine Quint.
+
+There was a typo. ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+should be HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM).
+
+* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+
2021-11-03 Chris Dumez
Clicking a link should preconnect to destination as first party
Modified: trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm (285227 => 285228)
--- trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm 2021-11-03 20:26:04 UTC (rev 285227)
+++ trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm 2021-11-03 21:07:06 UTC (rev 285228)
@@ -39,7 +39,7 @@
#import
#import
-#if ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
#import
SOFT_LINK_PRIVATE_FRAMEWORK(ARKit);
SOFT_LINK_CLASS(ARKit, ARQuickLookPreviewItem);
@@ -57,7 +57,7 @@
@interface _WKPreviewControllerDataSource : NSObject {
#endif
RetainPtr _itemProvider;
-#if ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
RetainPtr _item;
#else
RetainPtr _item;
@@ -108,7 +108,7 @@
// means we don't actually know the real MIME type yet.
NSString *contentType = WebCore::UTIFromMIMEType("model/vnd.usdz+zip"_s);
-#if ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
auto previewItem = adoptNS([allocARQuickLookPreviewItemInstance() initWithFileAtURL:_downloadedURL]);
[previewItem setCanonicalWebPageURL:_originatingPageURL];
@@ -159,7 +159,7 @@
self.completionHandler(nil, error);
}
-#if ENABLE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
+#if HAVE(ARKIT_QUICK_LOOK_PREVIEW_ITEM)
- (void)previewItem:(ARQuickLookWebKitItem *)previewItem didReceiveMessage:(NSDictionary *)message
{
if (!_previewController)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285225] branches/safari-612.3.3.1-branch/Source/WebKit
Title: [285225] branches/safari-612.3.3.1-branch/Source/WebKit
Revision 285225
Author repst...@apple.com
Date 2021-11-03 13:25:56 -0700 (Wed, 03 Nov 2021)
Log Message
Cherry-pick r284651. rdar://problem/84984058
Call to [NSURL URLByAppendingPathComponent:] under NetworkSessionCocoa() may be inefficient
https://bugs.webkit.org/show_bug.cgi?id=232098
Reviewed by Alex Christensen.
Call [NSURL URLByAppendingPathComponent:isDirectory:] whenever possible instead of
[NSURL URLByAppendingPathComponent], as it is more efficient.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* UIProcess/Cocoa/WKShareSheet.mm:
(+[WKShareSheet createRandomSharingDirectoryForFile:]):
(+[WKShareSheet writeFileToShareableURL:data:temporaryDirectory:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog
branches/safari-612.3.3.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm
Diff
Modified: branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog (285224 => 285225)
--- branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 20:24:42 UTC (rev 285224)
+++ branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 20:25:56 UTC (rev 285225)
@@ -1,3 +1,40 @@
+2021-11-03 Russell Epstein
+
+Cherry-pick r284651. rdar://problem/84984058
+
+Call to [NSURL URLByAppendingPathComponent:] under NetworkSessionCocoa() may be inefficient
+https://bugs.webkit.org/show_bug.cgi?id=232098
+
+Reviewed by Alex Christensen.
+
+Call [NSURL URLByAppendingPathComponent:isDirectory:] whenever possible instead of
+[NSURL URLByAppendingPathComponent], as it is more efficient.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+* UIProcess/Cocoa/WKShareSheet.mm:
+(+[WKShareSheet createRandomSharingDirectoryForFile:]):
+(+[WKShareSheet writeFileToShareableURL:data:temporaryDirectory:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-21 Chris Dumez
+
+Call to [NSURL URLByAppendingPathComponent:] under NetworkSessionCocoa() may be inefficient
+https://bugs.webkit.org/show_bug.cgi?id=232098
+
+Reviewed by Alex Christensen.
+
+Call [NSURL URLByAppendingPathComponent:isDirectory:] whenever possible instead of
+[NSURL URLByAppendingPathComponent], as it is more efficient.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+* UIProcess/Cocoa/WKShareSheet.mm:
+(+[WKShareSheet createRandomSharingDirectoryForFile:]):
+(+[WKShareSheet writeFileToShareableURL:data:temporaryDirectory:]):
+
2021-10-26 Russell Epstein
Cherry-pick r284349. rdar://problem/81171560
Modified: branches/safari-612.3.3.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (285224 => 285225)
--- branches/safari-612.3.3.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-11-03 20:24:42 UTC (rev 285224)
+++ branches/safari-612.3.3.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-11-03 20:25:56 UTC (rev 285225)
@@ -1316,7 +1316,7 @@
#if HAVE(CFNETWORK_ALTERNATIVE_SERVICE)
if (!parameters.alternativeServiceDirectory.isEmpty()) {
SandboxExtension::consumePermanently(parameters.alternativeServiceDirectoryExtensionHandle);
-configuration._alternativeServicesStorage = adoptNS([[_NSHTTPAlternativeServicesStorage alloc] initPersistentStoreWithURL:[[NSURL fileURLWithPath:parameters.alternativeServiceDirectory isDirectory:YES] URLByAppendingPathComponent:@"AlternativeService.sqlite"]]).get();
+configuration._alternativeServicesStorage = adoptNS([[_NSHTTPAlternativeServicesStorage alloc] initPersistentStoreWithURL:[[NSURL fileURLWithPath:parameters.alternativeServiceDirectory isDirectory:YES] URLByAppendingPathComponent:@"AlternativeService.sqlite" isDirectory:NO]]).get();
}
if (parameters.http3Enabled)
configuration._allowsHTTP3 = YES;
Modified: branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm (285224 => 285225)
--- branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm 2021-11-03 20:24:42 UTC (rev 285224)
+++ branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm 2021-11-03 20:25:56 UTC (rev 285225)
@@ -329,7 +329,7 @@
NSString *randomDirectory = createCanonicalUUIDString();
if (![randomDirectory length] || !temporaryDirectory)
return nil;
-NSURL *dataPath =
[webkit-changes] [285226] branches/safari-612.3.3.1-branch/Source/WebKit
Title: [285226] branches/safari-612.3.3.1-branch/Source/WebKit
Revision 285226
Author repst...@apple.com
Date 2021-11-03 13:26:00 -0700 (Wed, 03 Nov 2021)
Log Message
Cherry-pick r285115. rdar://problem/84984094
Increase responsiveness timeout for network process
https://bugs.webkit.org/show_bug.cgi?id=232505
Reviewed by Chris Dumez.
* UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::AuxiliaryProcessProxy):
* UIProcess/AuxiliaryProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
* UIProcess/ResponsivenessTimer.cpp:
(WebKit::ResponsivenessTimer::ResponsivenessTimer):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
(): Deleted.
* UIProcess/ResponsivenessTimer.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::getNetworkProcessConnection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/ResponsivenessTimer.cpp
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/ResponsivenessTimer.h
branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog (285225 => 285226)
--- branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 20:25:56 UTC (rev 285225)
+++ branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 20:26:00 UTC (rev 285226)
@@ -1,5 +1,53 @@
2021-11-03 Russell Epstein
+Cherry-pick r285115. rdar://problem/84984094
+
+Increase responsiveness timeout for network process
+https://bugs.webkit.org/show_bug.cgi?id=232505
+
+Reviewed by Chris Dumez.
+
+* UIProcess/AuxiliaryProcessProxy.cpp:
+(WebKit::AuxiliaryProcessProxy::AuxiliaryProcessProxy):
+* UIProcess/AuxiliaryProcessProxy.h:
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::NetworkProcessProxy):
+(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
+* UIProcess/ResponsivenessTimer.cpp:
+(WebKit::ResponsivenessTimer::ResponsivenessTimer):
+(WebKit::ResponsivenessTimer::timerFired):
+(WebKit::ResponsivenessTimer::start):
+(): Deleted.
+* UIProcess/ResponsivenessTimer.h:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::getNetworkProcessConnection):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-11-01 Sihui Liu
+
+Increase responsiveness timeout for network process
+https://bugs.webkit.org/show_bug.cgi?id=232505
+
+Reviewed by Chris Dumez.
+
+* UIProcess/AuxiliaryProcessProxy.cpp:
+(WebKit::AuxiliaryProcessProxy::AuxiliaryProcessProxy):
+* UIProcess/AuxiliaryProcessProxy.h:
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::NetworkProcessProxy):
+(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
+* UIProcess/ResponsivenessTimer.cpp:
+(WebKit::ResponsivenessTimer::ResponsivenessTimer):
+(WebKit::ResponsivenessTimer::timerFired):
+(WebKit::ResponsivenessTimer::start):
+(): Deleted.
+* UIProcess/ResponsivenessTimer.h:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::getNetworkProcessConnection):
+
+2021-11-03 Russell Epstein
+
Cherry-pick r284651. rdar://problem/84984058
Call to [NSURL URLByAppendingPathComponent:] under NetworkSessionCocoa() may be inefficient
Modified: branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp (285225 => 285226)
--- branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2021-11-03 20:25:56 UTC (rev 285225)
+++ branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2021-11-03 20:26:00 UTC (rev 285226)
@@ -40,8 +40,8 @@
namespace WebKit {
-AuxiliaryProcessProxy::AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority)
-: m_responsivenessTimer(*this)
+AuxiliaryProcessProxy::AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority, Seconds responsivenessTimeout)
+: m_responsivenessTimer(*this, responsivenessTimeout)
,
[webkit-changes] [285227] branches/safari-612.3.3.1-branch/Source/WebKit
Title: [285227] branches/safari-612.3.3.1-branch/Source/WebKit Revision 285227 Author repst...@apple.com Date 2021-11-03 13:26:04 -0700 (Wed, 03 Nov 2021) Log Message Cherry-pick r285177. rdar://problem/84987165 Terminate unresponsive network process by crashing it https://bugs.webkit.org/show_bug.cgi?id=232603 Reviewed by Chris Dumez. UI process currently kills network process when it does not respond message in some time (network process being unresponsive). We've found one common case where network process becomes unresponsive is that it is blocked by some slow operation on the main thread (like file operation in rdar://84511633). To understand what the operations are and make a fix, we now ask network process to crash itself on IPC thread. In this way, we can get crash report that includes the call stack of the main thread. To avoid generating too many crash reports, we only send the crash message to network process when it becomes unresponsive multiple times in a short time period. * Platform/IPC/Connection.cpp: (IPC::terminateDueToIPCTerminateMessage): (IPC::Connection::processIncomingMessage): * Scripts/webkit/model.py: * Scripts/webkit/tests/MessageNames.cpp: (IPC::description): (IPC::receiverName): (IPC::isValidMessageName): * Scripts/webkit/tests/MessageNames.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::shouldTerminateNetworkProcessBySendingMessage): (WebKit::NetworkProcessProxy::didBecomeUnresponsive): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285177 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog branches/safari-612.3.3.1-branch/Source/WebKit/Platform/IPC/Connection.cpp branches/safari-612.3.3.1-branch/Source/WebKit/Scripts/webkit/model.py branches/safari-612.3.3.1-branch/Source/WebKit/Scripts/webkit/tests/MessageNames.cpp branches/safari-612.3.3.1-branch/Source/WebKit/Scripts/webkit/tests/MessageNames.h branches/safari-612.3.3.1-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp Diff Modified: branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog (285226 => 285227) --- branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 20:26:00 UTC (rev 285226) +++ branches/safari-612.3.3.1-branch/Source/WebKit/ChangeLog 2021-11-03 20:26:04 UTC (rev 285227) @@ -1,5 +1,66 @@ 2021-11-03 Russell Epstein +Cherry-pick r285177. rdar://problem/84987165 + +Terminate unresponsive network process by crashing it +https://bugs.webkit.org/show_bug.cgi?id=232603 + +Reviewed by Chris Dumez. + +UI process currently kills network process when it does not respond message in some time (network process being +unresponsive). We've found one common case where network process becomes unresponsive is that it is blocked by +some slow operation on the main thread (like file operation in rdar://84511633). To understand what the +operations are and make a fix, we now ask network process to crash itself on IPC thread. In this way, we can get +crash report that includes the call stack of the main thread. To avoid generating too many crash reports, we +only send the crash message to network process when it becomes unresponsive multiple times in a short time +period. + +* Platform/IPC/Connection.cpp: +(IPC::terminateDueToIPCTerminateMessage): +(IPC::Connection::processIncomingMessage): +* Scripts/webkit/model.py: +* Scripts/webkit/tests/MessageNames.cpp: +(IPC::description): +(IPC::receiverName): +(IPC::isValidMessageName): +* Scripts/webkit/tests/MessageNames.h: +* UIProcess/Network/NetworkProcessProxy.cpp: +(WebKit::shouldTerminateNetworkProcessBySendingMessage): +(WebKit::NetworkProcessProxy::didBecomeUnresponsive): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285177 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-11-02 Sihui Liu + +Terminate unresponsive network process by crashing it +https://bugs.webkit.org/show_bug.cgi?id=232603 + +Reviewed by Chris Dumez. + +UI process currently kills network process when it does not respond message in some time (network process being +unresponsive). We've found one common case where network process becomes unresponsive is that it is blocked by +some slow operation on the main thread (like file operation in rdar://84511633). To understand what the +operations are and make a fix, we now ask network process to crash itself on IPC thread. In this way, we can get +crash report that includes the call stack of the main thread. To avoid generating too many crash reports, we +only send the crash message to network process when it becomes unresponsive multiple times in a short time +period. + +*
[webkit-changes] [285224] trunk/Source
Title: [285224] trunk/Source
Revision 285224
Author cdu...@apple.com
Date 2021-11-03 13:24:42 -0700 (Wed, 03 Nov 2021)
Log Message
Clicking a link should preconnect to destination as first party
https://bugs.webkit.org/show_bug.cgi?id=232668
Reviewed by Alex Christensen.
Clicking a link should preconnect to destination as first party, not third-party. Otherwise, the
preconnect is wasted when session isolation based on registrable domain is enabled. This is a
follow-up to r284730.
Source/WebCore:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::preconnectIfNeeded):
* loader/LoaderStrategy.h:
Source/WebKit:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::preconnectTo):
* WebProcess/Network/WebLoaderStrategy.h:
Source/WebKitLegacy:
* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::preconnectTo):
* WebCoreSupport/WebResourceLoadScheduler.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebCore/loader/LoaderStrategy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp
trunk/Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (285223 => 285224)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 20:14:47 UTC (rev 285223)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 20:24:42 UTC (rev 285224)
@@ -1,3 +1,20 @@
+2021-11-03 Chris Dumez
+
+Clicking a link should preconnect to destination as first party
+https://bugs.webkit.org/show_bug.cgi?id=232668
+
+Reviewed by Alex Christensen.
+
+Clicking a link should preconnect to destination as first party, not third-party. Otherwise, the
+preconnect is wasted when session isolation based on registrable domain is enabled. This is a
+follow-up to r284730.
+
+* html/HTMLAnchorElement.cpp:
+(WebCore::HTMLAnchorElement::handleClick):
+* loader/LinkLoader.cpp:
+(WebCore::LinkLoader::preconnectIfNeeded):
+* loader/LoaderStrategy.h:
+
2021-11-03 Devin Rousso
[Modern Media Controls] should show tracks button/menu for
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (285223 => 285224)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2021-11-03 20:14:47 UTC (rev 285223)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2021-11-03 20:24:42 UTC (rev 285224)
@@ -541,9 +541,9 @@
sendPings(completedURL);
// Preconnect to the link's target for improved page load time.
-if (completedURL.protocolIsInHTTPFamily()) {
+if (completedURL.protocolIsInHTTPFamily() && ((frame->isMainFrame() && isSelfTargetFrameName(effectiveTarget)) || isBlankTargetFrameName(effectiveTarget))) {
auto storageCredentialsPolicy = frame->page() && frame->page()->canUseCredentialStorage() ? StoredCredentialsPolicy::Use : StoredCredentialsPolicy::DoNotUse;
-platformStrategies()->loaderStrategy()->preconnectTo(frame->loader(), completedURL, storageCredentialsPolicy, nullptr);
+platformStrategies()->loaderStrategy()->preconnectTo(frame->loader(), completedURL, storageCredentialsPolicy, LoaderStrategy::ShouldPreconnectAsFirstParty::Yes, nullptr);
}
}
Modified: trunk/Source/WebCore/loader/LinkLoader.cpp (285223 => 285224)
--- trunk/Source/WebCore/loader/LinkLoader.cpp 2021-11-03 20:14:47 UTC (rev 285223)
+++ trunk/Source/WebCore/loader/LinkLoader.cpp 2021-11-03 20:24:42 UTC (rev 285224)
@@ -217,7 +217,7 @@
if (equalIgnoringASCIICase(params.crossOrigin, "anonymous") && document.securityOrigin().isSameOriginDomain(SecurityOrigin::create(href)))
storageCredentialsPolicy = StoredCredentialsPolicy::DoNotUse;
ASSERT(document.frame()->loader().networkingContext());
-platformStrategies()->loaderStrategy()->preconnectTo(document.frame()->loader(), href, storageCredentialsPolicy, [weakDocument = WeakPtr { document }, href](ResourceError error) {
+platformStrategies()->loaderStrategy()->preconnectTo(document.frame()->loader(), href, storageCredentialsPolicy, LoaderStrategy::ShouldPreconnectAsFirstParty::No, [weakDocument = WeakPtr { document }, href](ResourceError error) {
if (!weakDocument)
return;
Modified: trunk/Source/WebCore/loader/LoaderStrategy.h (285223 => 285224)
--- trunk/Source/WebCore/loader/LoaderStrategy.h 2021-11-03 20:14:47 UTC (rev 285223)
+++ trunk/Source/WebCore/loader/LoaderStrategy.h 2021-11-03 20:24:42 UTC (rev 285224)
@@ -79,7 +79,8 @@
virtual void startPingLoad(Frame&, ResourceRequest&, const HTTPHeaderMap& originalRequestHeaders, const FetchOptions&, ContentSecurityPolicyImposition,
[webkit-changes] [285223] branches/safari-612.3.3.0-branch/Source
Title: [285223] branches/safari-612.3.3.0-branch/Source Revision 285223 Author repst...@apple.com Date 2021-11-03 13:14:47 -0700 (Wed, 03 Nov 2021) Log Message Versioning. WebKit-7612.3.3.0.2 Modified Paths branches/safari-612.3.3.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.3.3.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.3.3.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.3.3.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.3.3.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.3.3.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.3.3.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.3.3.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.3.3.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285222 => 285223) --- branches/safari-612.3.3.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-03 20:12:23 UTC (rev 285222) +++ branches/safari-612.3.3.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-03 20:14:47 UTC (rev 285223) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285222 => 285223) --- branches/safari-612.3.3.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-03 20:12:23 UTC (rev 285222) +++ branches/safari-612.3.3.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-03 20:14:47 UTC (rev 285223) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285222 => 285223) --- branches/safari-612.3.3.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-03 20:12:23 UTC (rev 285222) +++ branches/safari-612.3.3.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-03 20:14:47 UTC (rev 285223) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.0-branch/Source/WebCore/Configurations/Version.xcconfig (285222 => 285223) --- branches/safari-612.3.3.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-03 20:12:23 UTC (rev 285222) +++ branches/safari-612.3.3.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-03 20:14:47 UTC (rev 285223) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285222 => 285223) --- branches/safari-612.3.3.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-03 20:12:23 UTC (rev 285222) +++ branches/safari-612.3.3.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-03 20:14:47 UTC (rev 285223) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.3.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285222 => 285223) --- branches/safari-612.3.3.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-03 20:12:23 UTC (rev 285222) +++ branches/safari-612.3.3.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-03 20:14:47 UTC (rev 285223) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 3; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [285222] trunk
Title: [285222] trunk
Revision 285222
Author cdu...@apple.com
Date 2021-11-03 13:12:23 -0700 (Wed, 03 Nov 2021)
Log Message
_pasteboardWithName should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=232670
Reviewed by Tim Horton.
Source/WTF:
wtf/Atomics.h uses WTF_MAKE_STRUCT_FAST_ALLOCATED which is declared in
wtf/FastMalloc.h but was failing to include it. This was leading to a
build error when I tried including wtf/Lock.h in WKTR.
* wtf/Atomics.h:
Tools:
_pasteboardWithName should be thread-safe, to match [NSPasteboard _pasteboardWithName].
This was leading to flaky crashes in _pasteboardWithName getting called off the main
thread from ShareKit code.
* DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(+[DumpRenderTreePasteboard _pasteboardWithName:]):
(+[DumpRenderTreePasteboard releaseLocalPasteboards]):
* WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
(+[WebKitTestRunnerPasteboard _pasteboardWithName:]):
(+[WebKitTestRunnerPasteboard releaseLocalPasteboards]):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm
trunk/Tools/WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm
Diff
Modified: trunk/Source/WTF/ChangeLog (285221 => 285222)
--- trunk/Source/WTF/ChangeLog 2021-11-03 20:11:28 UTC (rev 285221)
+++ trunk/Source/WTF/ChangeLog 2021-11-03 20:12:23 UTC (rev 285222)
@@ -1,3 +1,16 @@
+2021-11-03 Chris Dumez
+
+_pasteboardWithName should be thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=232670
+
+Reviewed by Tim Horton.
+
+wtf/Atomics.h uses WTF_MAKE_STRUCT_FAST_ALLOCATED which is declared in
+wtf/FastMalloc.h but was failing to include it. This was leading to a
+build error when I tried including wtf/Lock.h in WKTR.
+
+* wtf/Atomics.h:
+
2021-11-02 Brady Eidson
Notifications on iOS enabled at compile-time, disabled at runtime
Modified: trunk/Source/WTF/wtf/Atomics.h (285221 => 285222)
--- trunk/Source/WTF/wtf/Atomics.h 2021-11-03 20:11:28 UTC (rev 285221)
+++ trunk/Source/WTF/wtf/Atomics.h 2021-11-03 20:12:23 UTC (rev 285222)
@@ -26,6 +26,7 @@
#pragma once
#include
+#include
#include
#if OS(WINDOWS)
Modified: trunk/Tools/ChangeLog (285221 => 285222)
--- trunk/Tools/ChangeLog 2021-11-03 20:11:28 UTC (rev 285221)
+++ trunk/Tools/ChangeLog 2021-11-03 20:12:23 UTC (rev 285222)
@@ -1,3 +1,21 @@
+2021-11-03 Chris Dumez
+
+_pasteboardWithName should be thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=232670
+
+Reviewed by Tim Horton.
+
+_pasteboardWithName should be thread-safe, to match [NSPasteboard _pasteboardWithName].
+This was leading to flaky crashes in _pasteboardWithName getting called off the main
+thread from ShareKit code.
+
+* DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
+(+[DumpRenderTreePasteboard _pasteboardWithName:]):
+(+[DumpRenderTreePasteboard releaseLocalPasteboards]):
+* WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
+(+[WebKitTestRunnerPasteboard _pasteboardWithName:]):
+(+[WebKitTestRunnerPasteboard releaseLocalPasteboards]):
+
2021-11-03 Ryan Haddad
[EWS] Add more bots to iOS layout and API test queues
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm (285221 => 285222)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm 2021-11-03 20:11:28 UTC (rev 285221)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm 2021-11-03 20:12:23 UTC (rev 285222)
@@ -39,6 +39,7 @@
#import
#import
#import
+#import
#import
@interface LocalPasteboard : NSPasteboard {
@@ -55,7 +56,8 @@
-(id)initWithName:(NSString *)name;
@end
-static RetainPtr localPasteboards;
+static Lock localPasteboardsLock;
+static RetainPtr localPasteboards WTF_GUARDED_BY_LOCK(localPasteboardsLock);
@implementation DumpRenderTreePasteboard
@@ -62,9 +64,10 @@
// Return a local pasteboard so we don't disturb the real pasteboards when running tests.
+ (NSPasteboard *)_pasteboardWithName:(NSString *)name
{
-static int number = 0;
+Locker locker { localPasteboardsLock };
+static uint64_t number WTF_GUARDED_BY_LOCK(localPasteboardsLock) = 0;
if (!name)
-name = [NSString stringWithFormat:@"LocalPasteboard%d", ++number];
+name = [NSString stringWithFormat:@"LocalPasteboard%llu", ++number];
if (!localPasteboards)
localPasteboards = adoptNS([[NSMutableDictionary alloc] init]);
if (LocalPasteboard *pasteboard = [localPasteboards objectForKey:name])
@@ -76,6 +79,7 @@
+ (void)releaseLocalPasteboards
{
+Locker locker { localPasteboardsLock };
localPasteboards = nil;
}
Modified: trunk/Tools/WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm (285221 => 285222)
--- trunk/Tools/WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm 2021-11-03 20:11:28 UTC (rev
[webkit-changes] [285221] trunk/Tools
Title: [285221] trunk/Tools
Revision 285221
Author ryanhad...@apple.com
Date 2021-11-03 13:11:28 -0700 (Wed, 03 Nov 2021)
Log Message
[EWS] Add more bots to iOS layout and API test queues
https://bugs.webkit.org/show_bug.cgi?id=232678
Reviewed by Aakash Jain.
* CISupport/ews-build/config.json:
Modified Paths
trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/config.json (285220 => 285221)
--- trunk/Tools/CISupport/ews-build/config.json 2021-11-03 20:10:21 UTC (rev 285220)
+++ trunk/Tools/CISupport/ews-build/config.json 2021-11-03 20:11:28 UTC (rev 285221)
@@ -83,6 +83,9 @@
{ "name": "ews180", "platform": "mac-bigsur" },
{ "name": "ews181", "platform": "mac-catalina" },
{ "name": "ews182", "platform": "mac-catalina" },
+{ "name": "ews183", "platform": "*" },
+{ "name": "ews184", "platform": "ios-simulator-15" },
+{ "name": "ews185", "platform": "ios-simulator-15" },
{ "name": "ews210", "platform": "win" },
{ "name": "ews211", "platform": "win" },
{ "name": "ews212", "platform": "win" },
@@ -135,7 +138,7 @@
"factory": "iOSTestsFactory", "platform": "ios-simulator-15",
"configuration": "release", "architectures": ["x86_64"],
"triggered_by": ["ios-15-sim-build-ews"],
- "workernames": ["ews121", "ews122", "ews123", "ews124", "ews125", "ews126"]
+ "workernames": ["ews121", "ews122", "ews123", "ews124", "ews125", "ews126", "ews184", "ews185"]
},
{
"name": "macOS-AppleSilicon-Big-Sur-Debug-Build-EWS", "shortname": "mac-AS-debug", "icon": "buildOnly",
@@ -295,7 +298,7 @@
"name": "API-Tests-iOS-Simulator-EWS", "shortname": "api-ios", "icon": "testOnly",
"factory": "APITestsFactory", "platform": "*",
"triggered_by": ["ios-15-sim-build-ews"],
- "workernames": ["ews156", "ews157", "ews158", "ews159"]
+ "workernames": ["ews156", "ews157", "ews158", "ews159", "ews183"]
},
{
"name": "API-Tests-macOS-EWS", "shortname": "api-mac", "icon": "testOnly",
Modified: trunk/Tools/ChangeLog (285220 => 285221)
--- trunk/Tools/ChangeLog 2021-11-03 20:10:21 UTC (rev 285220)
+++ trunk/Tools/ChangeLog 2021-11-03 20:11:28 UTC (rev 285221)
@@ -1,3 +1,12 @@
+2021-11-03 Ryan Haddad
+
+[EWS] Add more bots to iOS layout and API test queues
+https://bugs.webkit.org/show_bug.cgi?id=232678
+
+Reviewed by Aakash Jain.
+
+* CISupport/ews-build/config.json:
+
2021-11-03 Simon Fraser
Expose fuzzy match data in layout test results
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285220] trunk/Source/ThirdParty/ANGLE
Title: [285220] trunk/Source/ThirdParty/ANGLE
Revision 285220
Author kpidding...@apple.com
Date 2021-11-03 13:10:21 -0700 (Wed, 03 Nov 2021)
Log Message
REGRESSION (iOS 15): Tab crashes when trying to render Projector stories
https://bugs.webkit.org/show_bug.cgi?id=231607
Rework vertex buffer caching to allow us to reuse parts
of converted buffers. This dramatically drops the memory usage
of this tab from 4.5 gb to roughly 1.3gb
Reviewed by Dean Jackson.
* src/libANGLE/renderer/metal/BufferMtl.mm:
(rx::BufferMtl::getVertexConversionBuffer):
* src/libANGLE/renderer/metal/VertexArrayMtl.mm:
(rx::VertexArrayMtl::convertVertexBuffer):
(rx::VertexArrayMtl::convertVertexBufferCPU):
(rx::VertexArrayMtl::convertVertexBufferGPU):
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (285219 => 285220)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-11-03 20:09:01 UTC (rev 285219)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-11-03 20:10:21 UTC (rev 285220)
@@ -1,3 +1,21 @@
+2021-11-03 Kyle Piddington
+
+REGRESSION (iOS 15): Tab crashes when trying to render Projector stories
+https://bugs.webkit.org/show_bug.cgi?id=231607
+
+ Rework vertex buffer caching to allow us to reuse parts
+ of converted buffers. This dramatically drops the memory usage
+ of this tab from 4.5 gb to roughly 1.3gb
+
+Reviewed by Dean Jackson.
+
+* src/libANGLE/renderer/metal/BufferMtl.mm:
+(rx::BufferMtl::getVertexConversionBuffer):
+* src/libANGLE/renderer/metal/VertexArrayMtl.mm:
+(rx::VertexArrayMtl::convertVertexBuffer):
+(rx::VertexArrayMtl::convertVertexBufferCPU):
+(rx::VertexArrayMtl::convertVertexBufferGPU):
+
2021-11-01 David Kilzer
[ANGLE] Enable -Wformat=2 warnings
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm (285219 => 285220)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm 2021-11-03 20:09:01 UTC (rev 285219)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm 2021-11-03 20:10:21 UTC (rev 285220)
@@ -333,7 +333,8 @@
{
for (VertexConversionBufferMtl : mVertexConversionBuffers)
{
-if (buffer.formatID == formatID && buffer.stride == stride && buffer.offset == offset)
+if (buffer.formatID == formatID && buffer.stride == stride &&
+buffer.offset <= offset && buffer.offset%buffer.stride == offset%stride)
{
return
}
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm (285219 => 285220)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm 2021-11-03 20:09:01 UTC (rev 285219)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm 2021-11-03 20:10:21 UTC (rev 285220)
@@ -147,6 +147,30 @@
return numVertices;
}
+//Calculate how many vertices we intend to
+//convert, including any additional ones in the original conversion buffer
+size_t GetVertexCountWithConversion(BufferMtl *srcBuffer,
+VertexConversionBufferMtl *conversionBuffer,
+const gl::VertexBinding ,
+uint32_t srcFormatSize)
+{
+// Bytes usable for vertex data.
+GLint64 bytes =
+srcBuffer->size() - MIN((GLintptr)conversionBuffer->offset, binding.getOffset());
+if (bytes < srcFormatSize)
+return 0;
+
+// Count the last vertex. It may occupy less than a full stride.
+size_t numVertices = 1;
+bytes -= srcFormatSize;
+
+// Count how many strides fit remaining space.
+if (bytes > 0)
+numVertices += static_cast(bytes) / binding.getStride();
+
+return numVertices;
+}
+
inline size_t GetIndexCount(BufferMtl *srcBuffer, size_t offset, gl::DrawElementsType indexType)
{
size_t elementSize = gl::GetDrawElementsTypeSize(indexType);
@@ -966,8 +990,10 @@
// Has the content of the buffer has changed since last conversion?
if (!conversion->dirty)
{
+VertexConversionBufferMtl * vertexConversionMtl = (VertexConversionBufferMtl *)conversion;
+ASSERT((binding.getOffset() - vertexConversionMtl->offset) % stride == 0);
mConvertedArrayBufferHolders[attribIndex].set(conversion->convertedBuffer);
-mCurrentArrayBufferOffsets[attribIndex] = conversion->convertedOffset;
+mCurrentArrayBufferOffsets[attribIndex] = conversion->convertedOffset + stride * ((binding.getOffset() - vertexConversionMtl->offset)/binding.getStride());
mCurrentArrayBuffers[attribIndex] = [attribIndex];
mCurrentArrayBufferFormats[attribIndex] =
@@ -974,7 +1000,11 @@
mCurrentArrayBufferStrides[attribIndex] =
[webkit-changes] [285219] trunk/Source/WebKit
Title: [285219] trunk/Source/WebKit
Revision 285219
Author jer.no...@apple.com
Date 2021-11-03 13:09:01 -0700 (Wed, 03 Nov 2021)
Log Message
[Catalina] HLS streams will not select HDR variants when GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=232671
Reviewed by Eric Carlson.
Tested manually.
In Catalina, fall back to a MediaToolbox API for setting a global HDR override in the GPU
process which instructs all AVPlayer instances whether HDR playback is supported for the
current set of displays. Pass the required data across from the UIProcess to the GPU process
at process start up and when the displays are reconfigured.
* GPUProcess/GPUProcess.h:
* GPUProcess/GPUProcess.messages.in:
* GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::setScreenProperties):
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::setScreenProperties):
(WebKit::GPUProcessProxy::updatePreferences):
* UIProcess/GPU/GPUProcessProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::screenPropertiesStateChanged):
(WebKit::displayReconfigurationCallBack):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in
trunk/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (285218 => 285219)
--- trunk/Source/WebKit/ChangeLog 2021-11-03 18:40:36 UTC (rev 285218)
+++ trunk/Source/WebKit/ChangeLog 2021-11-03 20:09:01 UTC (rev 285219)
@@ -1,3 +1,30 @@
+2021-11-03 Jer Noble
+
+[Catalina] HLS streams will not select HDR variants when GPU Process is enabled
+https://bugs.webkit.org/show_bug.cgi?id=232671
+
+
+Reviewed by Eric Carlson.
+
+Tested manually.
+
+In Catalina, fall back to a MediaToolbox API for setting a global HDR override in the GPU
+process which instructs all AVPlayer instances whether HDR playback is supported for the
+current set of displays. Pass the required data across from the UIProcess to the GPU process
+at process start up and when the displays are reconfigured.
+
+* GPUProcess/GPUProcess.h:
+* GPUProcess/GPUProcess.messages.in:
+* GPUProcess/mac/GPUProcessMac.mm:
+(WebKit::GPUProcess::setScreenProperties):
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::setScreenProperties):
+(WebKit::GPUProcessProxy::updatePreferences):
+* UIProcess/GPU/GPUProcessProxy.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::screenPropertiesStateChanged):
+(WebKit::displayReconfigurationCallBack):
+
2021-11-03 David Kilzer
Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview()
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.h (285218 => 285219)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.h 2021-11-03 18:40:36 UTC (rev 285218)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.h 2021-11-03 20:09:01 UTC (rev 285219)
@@ -49,6 +49,7 @@
namespace WebCore {
class NowPlayingManager;
struct MockMediaDevice;
+struct ScreenProperties;
struct SecurityOriginData;
}
@@ -147,6 +148,7 @@
#endif
#if PLATFORM(MAC)
void displayConfigurationChanged(CGDirectDisplayID, CGDisplayChangeSummaryFlags);
+void setScreenProperties(const WebCore::ScreenProperties&);
#endif
#if USE(OS_STATE)
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in (285218 => 285219)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in 2021-11-03 18:40:36 UTC (rev 285218)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in 2021-11-03 20:09:01 UTC (rev 285219)
@@ -47,8 +47,11 @@
#endif
#if PLATFORM(MAC)
DisplayConfigurationChanged(CGDirectDisplayID displayID, CGDisplayChangeSummaryFlags flags)
+SetScreenProperties(struct WebCore::ScreenProperties screenProperties)
#endif
+#endif
+
#if ENABLE(MEDIA_SOURCE)
SetWebMParserEnabled(bool enabled);
#endif
Modified: trunk/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm (285218 => 285219)
--- trunk/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm 2021-11-03 18:40:36 UTC (rev 285218)
+++ trunk/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm 2021-11-03 20:09:01 UTC (rev 285219)
@@ -32,10 +32,13 @@
#import "SandboxInitializationParameters.h"
#import "WKFoundation.h"
#import
+#import
+#import
#import
#import
#import
#import
+#import
#import
namespace WebKit {
@@ -76,6 +79,28 @@
AuxiliaryProcess::initializeSandbox(parameters, sandboxParameters);
}
+#if PLATFORM(MAC)
+void GPUProcess::setScreenProperties(const ScreenProperties& screenProperties)
+{
+#if !HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
+// Only override HDR support at the MediaToolbox level if AVPlayer.videoRangeOverride support is
+// not
[webkit-changes] [285218] trunk/LayoutTests
Title: [285218] trunk/LayoutTests Revision 285218 Author ehutchi...@apple.com Date 2021-11-03 11:40:36 -0700 (Wed, 03 Nov 2021) Log Message Rebaseline http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html. https://bugs.webkit.org/show_bug.cgi?id=231928. Unreviewed test gardening. * platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (285217 => 285218) --- trunk/LayoutTests/ChangeLog 2021-11-03 18:26:11 UTC (rev 285217) +++ trunk/LayoutTests/ChangeLog 2021-11-03 18:40:36 UTC (rev 285218) @@ -1,3 +1,12 @@ +2021-11-03 Eric Hutchison + +Rebaseline http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html. +https://bugs.webkit.org/show_bug.cgi?id=231928. + +Unreviewed test gardening. + +* platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: + 2021-11-03 Devin Rousso [Modern Media Controls] should show tracks button/menu for Modified: trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt (285217 => 285218) --- trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt 2021-11-03 18:26:11 UTC (rev 285217) +++ trunk/LayoutTests/platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt 2021-11-03 18:40:36 UTC (rev 285218) @@ -1,5 +1,5 @@ CONSOLE MESSAGE: [Private Click Measurement] Conversion was not accepted because the URL path contained unrecognized parts. -CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. Status code: 200 +CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. Status code: 404 CONSOLE MESSAGE: Fetch API cannot load https://127.0.0.1:8443/.well-known/private-click-measurement/trigger-attribution/whatever due to access control checks. Tests triggering of private click measurement attributions with fetch on pagehide. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285217] trunk/Source/WebKit
Title: [285217] trunk/Source/WebKit Revision 285217 Author ddkil...@apple.com Date 2021-11-03 11:26:11 -0700 (Wed, 03 Nov 2021) Log Message Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview() Reviewed by Brent Fulgham. * UIProcess/Cocoa/ModelElementControllerCocoa.mm: (WebKit::ModelElementController::modelElementDidCreatePreview): - Use adoptNS() to fix the leak. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm Diff Modified: trunk/Source/WebKit/ChangeLog (285216 => 285217) --- trunk/Source/WebKit/ChangeLog 2021-11-03 17:59:39 UTC (rev 285216) +++ trunk/Source/WebKit/ChangeLog 2021-11-03 18:26:11 UTC (rev 285217) @@ -1,3 +1,15 @@ +2021-11-03 David Kilzer + +Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview() + + + +Reviewed by Brent Fulgham. + +* UIProcess/Cocoa/ModelElementControllerCocoa.mm: +(WebKit::ModelElementController::modelElementDidCreatePreview): +- Use adoptNS() to fix the leak. + 2021-11-03 Kate Cheney [iOS] Need API for marking file requests as non-app-initiated Modified: trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm (285216 => 285217) --- trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-11-03 17:59:39 UTC (rev 285216) +++ trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-11-03 18:26:11 UTC (rev 285217) @@ -129,7 +129,8 @@ if (!m_webPageProxy.preferences().modelElementEnabled()) return; -auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:[[NSUUID alloc] initWithUUIDString:uuid]]); +auto uuid = adoptNS([[NSUUID alloc] initWithUUIDString:uuid]); +auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); LOG(ModelElement, "Created remote preview with UUID %s.", uuid.utf8().data()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285216] trunk
Title: [285216] trunk
Revision 285216
Author drou...@apple.com
Date 2021-11-03 10:59:39 -0700 (Wed, 03 Nov 2021)
Log Message
[Modern Media Controls] should show tracks button/menu for
https://bugs.webkit.org/show_bug.cgi?id=232597
Reviewed by Eric Carlson.
Source/WebCore:
There's nothing preventing `` from having multiple ``. We should have a
language picker for `` just like what we have for ``.
Tests: media/modern-media-controls/tracks-support/audio-multiple-tracks.html
media/modern-media-controls/tracks-support/audio-single-track.html
* Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype._rightContainerButtons):
LayoutTests:
* media/modern-media-controls/tracks-support/audio-multiple-tracks.html: Added.
* media/modern-media-controls/tracks-support/audio-multiple-tracks-expected.txt: Added.
* media/modern-media-controls/tracks-support/audio-single-track.html: Added.
* media/modern-media-controls/tracks-support/audio-single-track-expected.txt: Added.
* media/modern-media-controls/audio/audio-controls-buttons.html:
* media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
* platform/ios-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons-expected.txt
trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons.html
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js
Added Paths
trunk/LayoutTests/media/modern-media-controls/tracks-support/audio-multiple-tracks-expected.txt
trunk/LayoutTests/media/modern-media-controls/tracks-support/audio-multiple-tracks.html
trunk/LayoutTests/media/modern-media-controls/tracks-support/audio-single-track-expected.txt
trunk/LayoutTests/media/modern-media-controls/tracks-support/audio-single-track.html
Diff
Modified: trunk/LayoutTests/ChangeLog (285215 => 285216)
--- trunk/LayoutTests/ChangeLog 2021-11-03 17:47:09 UTC (rev 285215)
+++ trunk/LayoutTests/ChangeLog 2021-11-03 17:59:39 UTC (rev 285216)
@@ -1,3 +1,20 @@
+2021-11-03 Devin Rousso
+
+[Modern Media Controls] should show tracks button/menu for
+https://bugs.webkit.org/show_bug.cgi?id=232597
+
+Reviewed by Eric Carlson.
+
+* media/modern-media-controls/tracks-support/audio-multiple-tracks.html: Added.
+* media/modern-media-controls/tracks-support/audio-multiple-tracks-expected.txt: Added.
+* media/modern-media-controls/tracks-support/audio-single-track.html: Added.
+* media/modern-media-controls/tracks-support/audio-single-track-expected.txt: Added.
+
+* media/modern-media-controls/audio/audio-controls-buttons.html:
+* media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
+
+* platform/ios-wk2/TestExpectations:
+
2021-11-03 Chris Dumez
_javascript_ URLs do not run in the right context when using frame targeting
Modified: trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons-expected.txt (285215 => 285216)
--- trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons-expected.txt 2021-11-03 17:47:09 UTC (rev 285215)
+++ trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons-expected.txt 2021-11-03 17:59:39 UTC (rev 285216)
@@ -5,7 +5,7 @@
Making AirPlay routes available.
AirPlay routes became available.
-PASS mediaController.controls.rightContainer.children.length is 3
+PASS mediaController.controls.rightContainer.children.length is 4
PASS mediaController.controls.rightContainer.children[0] is mediaController.controls.muteButton
PASS mediaController.controls.rightContainer.children[1] is mediaController.controls.airplayButton
PASS accessibilityController.accessibleElementById('audio-controls').description is "AXDescription: Audio Controls"
Modified: trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons.html (285215 => 285216)
--- trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons.html 2021-11-03 17:47:09 UTC (rev 285215)
+++ trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons.html 2021-11-03 17:59:39 UTC (rev 285216)
@@ -42,7 +42,7 @@
debug("AirPlay routes became available.");
media.removeEventListener('webkitplaybacktargetavailabilitychanged', playbackTargetAvailabilityChangedAgain, true);
-shouldBe("mediaController.controls.rightContainer.children.length", "3");
+shouldBe("mediaController.controls.rightContainer.children.length", "4");
shouldBe("mediaController.controls.rightContainer.children[0]", "mediaController.controls.muteButton");
shouldBe("mediaController.controls.rightContainer.children[1]", "mediaController.controls.airplayButton");
mediaController.controls.bottomControlsBar.element.setAttribute("id",
[webkit-changes] [285215] trunk/Source/WebInspectorUI
Title: [285215] trunk/Source/WebInspectorUI
Revision 285215
Author nvasil...@apple.com
Date 2021-11-03 10:47:09 -0700 (Wed, 03 Nov 2021)
Log Message
Web Inspector: Display swatch popovers below the swatch by default, not on the left side
https://bugs.webkit.org/show_bug.cgi?id=232577
Reviewed by Devin Rousso.
The new defaults are: below, above, left.
Displaying the swatch popover on the left side covers the relevant property name.
Displaying it below or above doesn't have this problem; below is preferred because
it doesn't hide the CSS selector of the relevant rule.
* UserInterface/Views/InlineSwatch.js:
(WI.InlineSwatch.prototype._presentPopover):
Introduce a method to remove code duplication.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (285214 => 285215)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-11-03 17:28:39 UTC (rev 285214)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-11-03 17:47:09 UTC (rev 285215)
@@ -1,3 +1,20 @@
+2021-11-03 Nikita Vasilyev
+
+Web Inspector: Display swatch popovers below the swatch by default, not on the left side
+https://bugs.webkit.org/show_bug.cgi?id=232577
+
+Reviewed by Devin Rousso.
+
+The new defaults are: below, above, left.
+
+Displaying the swatch popover on the left side covers the relevant property name.
+Displaying it below or above doesn't have this problem; below is preferred because
+it doesn't hide the CSS selector of the relevant rule.
+
+* UserInterface/Views/InlineSwatch.js:
+(WI.InlineSwatch.prototype._presentPopover):
+Introduce a method to remove code duplication.
+
2021-10-29 David Kilzer
Web Inspector: Enable -Wformat=2 warnings
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js (285214 => 285215)
--- trunk/Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js 2021-11-03 17:28:39 UTC (rev 285214)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js 2021-11-03 17:47:09 UTC (rev 285215)
@@ -238,12 +238,10 @@
if (!value)
value = this._fallbackValue();
-let bounds = WI.Rect.rectFromClientRect(this._swatchElement.getBoundingClientRect());
let popover = new WI.Popover(this);
popover.windowResizeHandler = () => {
-let bounds = WI.Rect.rectFromClientRect(this._swatchElement.getBoundingClientRect());
-popover.present(bounds.pad(2), [WI.RectEdge.MIN_X]);
+this._presentPopover(popover);
};
this._valueEditor = null;
@@ -307,7 +305,7 @@
return;
popover.content = this._valueEditor.element;
-popover.present(bounds.pad(2), [WI.RectEdge.MIN_X]);
+this._presentPopover(popover);
this.dispatchEventToListeners(WI.InlineSwatch.Event.Activated);
@@ -383,6 +381,12 @@
this._updateSwatch();
}
+_presentPopover(popover)
+{
+let bounds = WI.Rect.rectFromClientRect(this._swatchElement.getBoundingClientRect());
+popover.present(bounds.pad(2), [WI.RectEdge.MAX_Y, WI.RectEdge.MIN_Y, WI.RectEdge.MIN_X]);
+}
+
_handleContextMenuEvent(event)
{
let value = this.value;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285214] trunk
Title: [285214] trunk Revision 285214 Author cdu...@apple.com Date 2021-11-03 10:28:39 -0700 (Wed, 03 Nov 2021) Log Message _javascript_ URLs do not run in the right context when using frame targeting https://bugs.webkit.org/show_bug.cgi?id=232382 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/010-expected.txt: The test is no longer timing out now that we run the _javascript_ URL contained in the 's action in the context of the "test" iframe instead of the top frame. However, the test is still failing, possibly because the _javascript_ URL is run synchronously. Source/WebCore: _javascript_ URLs did not run in the right context when using frame targeting (e.g. ` Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/contentSecurityPolicy/_javascript_-url-allowed-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-expected.txt trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/010-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/html/HTMLFormElement.cpp trunk/Source/WebCore/loader/FormSubmission.cpp trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/loader/NavigationAction.h trunk/Source/WebCore/loader/NavigationScheduler.cpp trunk/Source/WebCore/loader/SubframeLoader.cpp Added Paths trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-expected.txt trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window-expected.txt trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window.html trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target.html trunk/LayoutTests/fast/frames/_javascript_-url-form-target-expected.txt trunk/LayoutTests/fast/frames/_javascript_-url-form-target-new-window-expected.txt trunk/LayoutTests/fast/frames/_javascript_-url-form-target-new-window.html trunk/LayoutTests/fast/frames/_javascript_-url-form-target.html Diff Modified: trunk/LayoutTests/ChangeLog (285213 => 285214) --- trunk/LayoutTests/ChangeLog 2021-11-03 17:05:50 UTC (rev 285213) +++ trunk/LayoutTests/ChangeLog 2021-11-03 17:28:39 UTC (rev 285214) @@ -1,3 +1,22 @@ +2021-11-03 Chris Dumez + +_javascript_ URLs do not run in the right context when using frame targeting +https://bugs.webkit.org/show_bug.cgi?id=232382 + +Reviewed by Alex Christensen. + +Add layout test coverage. I have verified that these tests are passing in both +Chrome 94 and Firefox 94. + +* fast/frames/_javascript_-url-anchor-target-expected.txt: Added. +* fast/frames/_javascript_-url-anchor-target-new-window-expected.txt: Added. +* fast/frames/_javascript_-url-anchor-target-new-window.html: Added. +* fast/frames/_javascript_-url-anchor-target.html: Added. +* fast/frames/_javascript_-url-form-target-expected.txt: Added. +* fast/frames/_javascript_-url-form-target-new-window-expected.txt: Added. +* fast/frames/_javascript_-url-form-target-new-window.html: Added. +* fast/frames/_javascript_-url-form-target.html: Added. + 2021-11-03 Simon Fraser Expose fuzzy match data in layout test results Added: trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-expected.txt (0 => 285214) --- trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-expected.txt (rev 0) +++ trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-expected.txt 2021-11-03 17:28:39 UTC (rev 285214) @@ -0,0 +1,10 @@ +Tests that _javascript_ URL execute in the right context when set as href on an anchor with a target frame. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS contextName is "testFrame" +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window-expected.txt (0 => 285214) --- trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window-expected.txt (rev 0) +++ trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window-expected.txt 2021-11-03 17:28:39 UTC (rev 285214) @@ -0,0 +1,10 @@ +Tests that _javascript_ URL execute in the right context when set as href on an anchor with a target popup. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS contextName is "testPopup" +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window.html (0 => 285214) --- trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window.html (rev 0) +++ trunk/LayoutTests/fast/frames/_javascript_-url-anchor-target-new-window.html 2021-11-03
[webkit-changes] [285213] trunk
Title: [285213] trunk
Revision 285213
Author simon.fra...@apple.com
Date 2021-11-03 10:05:50 -0700 (Wed, 03 Nov 2021)
Log Message
Expose fuzzy match data in layout test results
https://bugs.webkit.org/show_bug.cgi?id=232523
Reviewed by Jonathan Bedard.
Tools:
For a failing ref (or image) test, include the fuzzy matching data in full_results.json
in the form "image_difference": { "max_difference": 13, "total_pixels": 167 }, and
show that in the image comparison page that's written out for each test result.
Fix some tests that relied on JSON property serialization ordering (we don't serialize
with `sort_keys=True`).
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._save_json_files):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGenerator.generate_times_ms_file):
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(FailureImageHashMismatch.formatted_diff_percent):
(FailureImageHashMismatch):
(FailureImageHashMismatch.formatted_fuzzy_data):
(FailureImageHashMismatch.write_failure):
(FailureReftestMismatch.message):
(FailureReftestMismatch.formatted_diff_percent):
(FailureReftestMismatch):
(FailureReftestMismatch.formatted_fuzzy_data):
(FailureReftestMismatch.write_failure):
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(_interpret_test_failures):
* Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
(InterpretTestFailuresTest.test_interpret_test_failures):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_retrying_force_pixel_tests):
LayoutTests:
Add some "image_difference" values to the test JSON and update the resulting
files.
* fast/harness/full_results.json:
* fast/harness/image-diff-template-expected.txt:
* fast/harness/image-diff-template.html:
* fast/harness/results.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/full_results.json
trunk/LayoutTests/fast/harness/image-diff-template-expected.txt
trunk/LayoutTests/fast/harness/image-diff-template.html
trunk/LayoutTests/fast/harness/results.html
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
Diff
Modified: trunk/LayoutTests/ChangeLog (285212 => 285213)
--- trunk/LayoutTests/ChangeLog 2021-11-03 17:05:02 UTC (rev 285212)
+++ trunk/LayoutTests/ChangeLog 2021-11-03 17:05:50 UTC (rev 285213)
@@ -1,3 +1,18 @@
+2021-11-03 Simon Fraser
+
+Expose fuzzy match data in layout test results
+https://bugs.webkit.org/show_bug.cgi?id=232523
+
+Reviewed by Jonathan Bedard.
+
+Add some "image_difference" values to the test JSON and update the resulting
+files.
+
+* fast/harness/full_results.json:
+* fast/harness/image-diff-template-expected.txt:
+* fast/harness/image-diff-template.html:
+* fast/harness/results.html:
+
2021-11-03 Jer Noble
[iOS] AVAssetResourceLoadingRequest.request does not include a Range: header on iOS 15.
Modified: trunk/LayoutTests/fast/harness/full_results.json (285212 => 285213)
--- trunk/LayoutTests/fast/harness/full_results.json 2021-11-03 17:05:02 UTC (rev 285212)
+++ trunk/LayoutTests/fast/harness/full_results.json 2021-11-03 17:05:50 UTC (rev 285213)
@@ -25,13 +25,21 @@
"report": "REGRESSION",
"expected": "PASS",
"actual": "IMAGE",
-"image_diff_percent": 86.262301
+"image_diff_percent": 86.262301,
+"image_difference": {
+"max_difference": 13,
+"total_pixels": 167
+}
},
"tiny-image-fail.html": {
"report": "REGRESSION",
"expected": "PASS",
"actual": "IMAGE",
-"image_diff_percent": 0.002
+"image_diff_percent": 0.002,
+"image_difference": {
+"max_difference": 3,
+"total_pixels": 24
+}
},
"leaky-worker.html": {
"report": "REGRESSION",
Modified: trunk/LayoutTests/fast/harness/image-diff-template-expected.txt (285212 => 285213)
---
[webkit-changes] [285212] tags/Safari-612.3.3.1.1/
Title: [285212] tags/Safari-612.3.3.1.1/ Revision 285212 Author repst...@apple.com Date 2021-11-03 10:05:02 -0700 (Wed, 03 Nov 2021) Log Message Tag Safari-612.3.3.1.1. Added Paths tags/Safari-612.3.3.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285211] trunk
Title: [285211] trunk
Revision 285211
Author an...@apple.com
Date 2021-11-03 09:59:48 -0700 (Wed, 03 Nov 2021)
Log Message
::slotted element style not invalidated correctly in nested case
https://bugs.webkit.org/show_bug.cgi?id=232665
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-scoping/slotted-nested-expected.txt:
Source/WebCore:
We fail to invalidate ::slotted style if the assigned node is not from the current host scope.
* style/StyleInvalidator.cpp:
(WebCore::Style::invalidateAssignedElements):
Invalidate more accurately by following assigned node chain recursively instead of just invalidating all host children.
(WebCore::Style::Invalidator::invalidateIfNeeded):
Remove the unnecessary and incorrect m_didInvalidateHostChildren optimization.
* style/StyleInvalidator.h:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-nested-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleInvalidator.cpp
trunk/Source/WebCore/style/StyleInvalidator.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285210 => 285211)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 16:52:28 UTC (rev 285210)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 16:59:48 UTC (rev 285211)
@@ -1,5 +1,14 @@
2021-11-03 Antti Koivisto
+::slotted element style not invalidated correctly in nested case
+https://bugs.webkit.org/show_bug.cgi?id=232665
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-scoping/slotted-nested-expected.txt:
+
+2021-11-03 Antti Koivisto
+
::slotted shouldn't match an active
https://bugs.webkit.org/show_bug.cgi?id=232664
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-nested-expected.txt (285210 => 285211)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-nested-expected.txt 2021-11-03 16:52:28 UTC (rev 285210)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-nested-expected.txt 2021-11-03 16:59:48 UTC (rev 285211)
@@ -2,5 +2,5 @@
PASS Slotted matches rules against the slot in the right tree
-FAIL Style invalidation works correctly for nested slots assert_not_equals: got disallowed value "rgb(0, 128, 0)"
+PASS Style invalidation works correctly for nested slots
Modified: trunk/Source/WebCore/ChangeLog (285210 => 285211)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 16:52:28 UTC (rev 285210)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 16:59:48 UTC (rev 285211)
@@ -1,3 +1,23 @@
+2021-11-03 Antti Koivisto
+
+::slotted element style not invalidated correctly in nested case
+https://bugs.webkit.org/show_bug.cgi?id=232665
+
+Reviewed by Simon Fraser.
+
+We fail to invalidate ::slotted style if the assigned node is not from the current host scope.
+
+* style/StyleInvalidator.cpp:
+(WebCore::Style::invalidateAssignedElements):
+
+Invalidate more accurately by following assigned node chain recursively instead of just invalidating all host children.
+
+(WebCore::Style::Invalidator::invalidateIfNeeded):
+
+Remove the unnecessary and incorrect m_didInvalidateHostChildren optimization.
+
+* style/StyleInvalidator.h:
+
2021-11-03 Jer Noble
[iOS] AVAssetResourceLoadingRequest.request does not include a Range: header on iOS 15.
Modified: trunk/Source/WebCore/style/StyleInvalidator.cpp (285210 => 285211)
--- trunk/Source/WebCore/style/StyleInvalidator.cpp 2021-11-03 16:52:28 UTC (rev 285210)
+++ trunk/Source/WebCore/style/StyleInvalidator.cpp 2021-11-03 16:59:48 UTC (rev 285211)
@@ -128,20 +128,28 @@
return information;
}
+static void invalidateAssignedElements(HTMLSlotElement& slot)
+{
+auto* assignedNodes = slot.assignedNodes();
+if (!assignedNodes)
+return;
+for (auto& node : *assignedNodes) {
+if (!is(node.get()))
+continue;
+if (is(*node) && node->containingShadowRoot()) {
+invalidateAssignedElements(downcast(*node));
+continue;
+}
+downcast(*node).invalidateStyleInternal();
+}
+}
+
Invalidator::CheckDescendants Invalidator::invalidateIfNeeded(Element& element, const SelectorFilter* filter)
{
invalidateInShadowTreeIfNeeded(element);
-bool shouldCheckForSlots = m_ruleInformation.hasSlottedPseudoElementRules && !m_didInvalidateHostChildren;
-if (shouldCheckForSlots && is(element)) {
-auto* containingShadowRoot = element.containingShadowRoot();
-if (containingShadowRoot && containingShadowRoot->host()) {
-for (auto& possiblySlotted : childrenOfType(*containingShadowRoot->host()))
-possiblySlotted.invalidateStyleInternal();
-}
-// No need to do this again.
-m_didInvalidateHostChildren = true;
-
[webkit-changes] [285210] trunk
Title: [285210] trunk Revision 285210 Author jer.no...@apple.com Date 2021-11-03 09:52:28 -0700 (Wed, 03 Nov 2021) Log Message [iOS] AVAssetResourceLoadingRequest.request does not include a Range: header on iOS 15. https://bugs.webkit.org/show_bug.cgi?id=232195 Reviewed by Darin Adler. Source/WebCore: Explicitly add a Range: header for Blob requests which do not have one (but otherwise should). Test: platform/mac/media/video-blob-request-contains-range-header.html Drive-by fix: to allow this change to be testable, we must revert a change which calls all the network delegate callbacks with empty data. This was necessary at the time because (at least for Cocoa ports) media loading happened outside WebCore's loader path. Currently, all http(s), data, blob, and custom protocol schemes are loaded through WebCore, leaving file:// URLs as the remaining protocol type that needs custom handling, and only on Cocoa ports. Further drive-by fix: WebKitLegacy's network delegate client operates synchronously during requestResource(), so WebCoreNSURLSession must synthesize an error if that method returns a nil resource. * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm: (WebCore::WebCoreAVFResourceLoader::startLoading): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): * platform/network/cocoa/WebCoreNSURLSession.mm: (-[WebCoreNSURLSessionDataTask _restart]): LayoutTests: The existing media-blocked-by-willsendrequest.html test only verified that file:// URLs were blocked, not http://, so this test is moved to the http/tests/ directory where media will use http:// for loading. * http/tests/media/media-blocked-by-willsendrequest-expected.txt: Renamed from LayoutTests/media/media-blocked-by-willsendrequest-expected.txt. * http/tests/media/media-blocked-by-willsendrequest.html: Renamed from LayoutTests/media/media-blocked-by-willsendrequest.html. * platform/mac/media/video-blob-request-contains-range-header.html: * platform/mac/media/video-blob-request-contains-range-header-expected.txt: Added. * platform/mac/media/video-blob-request-contains-range-header.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm Added Paths trunk/LayoutTests/http/tests/media/media-blocked-by-willsendrequest-expected.txt trunk/LayoutTests/http/tests/media/media-blocked-by-willsendrequest.html trunk/LayoutTests/platform/mac/media/video-blob-request-contains-range-header-expected.txt trunk/LayoutTests/platform/mac/media/video-blob-request-contains-range-header.html Removed Paths trunk/LayoutTests/media/media-blocked-by-willsendrequest-expected.txt trunk/LayoutTests/media/media-blocked-by-willsendrequest.html Diff Modified: trunk/LayoutTests/ChangeLog (285209 => 285210) --- trunk/LayoutTests/ChangeLog 2021-11-03 16:40:39 UTC (rev 285209) +++ trunk/LayoutTests/ChangeLog 2021-11-03 16:52:28 UTC (rev 285210) @@ -1,3 +1,20 @@ +2021-11-03 Jer Noble + +[iOS] AVAssetResourceLoadingRequest.request does not include a Range: header on iOS 15. +https://bugs.webkit.org/show_bug.cgi?id=232195 + + +Reviewed by Darin Adler. + +The existing media-blocked-by-willsendrequest.html test only verified that file:// URLs were blocked, +not http://, so this test is moved to the http/tests/ directory where media will use http:// for loading. + +* http/tests/media/media-blocked-by-willsendrequest-expected.txt: Renamed from LayoutTests/media/media-blocked-by-willsendrequest-expected.txt. +* http/tests/media/media-blocked-by-willsendrequest.html: Renamed from LayoutTests/media/media-blocked-by-willsendrequest.html. +* platform/mac/media/video-blob-request-contains-range-header.html: +* platform/mac/media/video-blob-request-contains-range-header-expected.txt: Added. +* platform/mac/media/video-blob-request-contains-range-header.html: Added. + 2021-11-03 Tim Nguyen Make render-layer-rebuild-z-order-lists.html use an HTML reference Copied: trunk/LayoutTests/http/tests/media/media-blocked-by-willsendrequest-expected.txt (from rev 285209, trunk/LayoutTests/media/media-blocked-by-willsendrequest-expected.txt) (0 => 285210) --- trunk/LayoutTests/http/tests/media/media-blocked-by-willsendrequest-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/media/media-blocked-by-willsendrequest-expected.txt 2021-11-03 16:52:28 UTC (rev 285210) @@ -0,0 +1,13 @@ + +Test to ensure that a media file blocked by the resource load delegate generates an error and does not block the document's 'load' event. + +EXPECTED (video.networkState == '0') OK + +EVENT(loadstart) +EVENT(error) +EXPECTED (video.error != 'null') OK +EXPECTED (video.error.code == '4') OK +EXPECTED
[webkit-changes] [285209] trunk
Title: [285209] trunk
Revision 285209
Author an...@apple.com
Date 2021-11-03 09:40:39 -0700 (Wed, 03 Nov 2021)
Log Message
::slotted shouldn't match an active
https://bugs.webkit.org/show_bug.cgi?id=232664
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-scoping/slotted-slot-expected.txt:
Source/WebCore:
https://drafts.csswg.org/css-scoping/#slotted-pseudo
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
Avoid matching .
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-slot-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285208 => 285209)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 16:17:21 UTC (rev 285208)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 16:40:39 UTC (rev 285209)
@@ -1,3 +1,12 @@
+2021-11-03 Antti Koivisto
+
+::slotted shouldn't match an active
+https://bugs.webkit.org/show_bug.cgi?id=232664
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-scoping/slotted-slot-expected.txt:
+
2021-11-01 Michael[tm] Smith
[WebInspector][CORS] Show HTTP status code in CORS messages.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-slot-expected.txt (285208 => 285209)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-slot-expected.txt 2021-11-03 16:17:21 UTC (rev 285208)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/slotted-slot-expected.txt 2021-11-03 16:40:39 UTC (rev 285209)
@@ -1,4 +1,4 @@
This text should be green.
-FAIL Check that ::slotted does not match slot elements assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)"
+PASS Check that ::slotted does not match slot elements
Modified: trunk/Source/WebCore/ChangeLog (285208 => 285209)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 16:17:21 UTC (rev 285208)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 16:40:39 UTC (rev 285209)
@@ -1,3 +1,17 @@
+2021-11-03 Antti Koivisto
+
+::slotted shouldn't match an active
+https://bugs.webkit.org/show_bug.cgi?id=232664
+
+Reviewed by Simon Fraser.
+
+https://drafts.csswg.org/css-scoping/#slotted-pseudo
+
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::checkOne const):
+
+Avoid matching .
+
2021-11-03 Chris Lord
[GTK][WPE] Use the display refresh to drive scrolling animations (sync scroll)
Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (285208 => 285209)
--- trunk/Source/WebCore/css/SelectorChecker.cpp 2021-11-03 16:17:21 UTC (rev 285208)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2021-11-03 16:40:39 UTC (rev 285209)
@@ -1156,6 +1156,9 @@
case CSSSelector::PseudoElementSlotted: {
if (!context.element->assignedSlot())
return false;
+// ::slotted matches after flattening so it can't match an active .
+if (is(*context.element) && context.element->containingShadowRoot())
+return false;
auto* subselector = context.selector->selectorList()->first();
LocalContext subcontext(context);
subcontext.selector = subselector;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285208] trunk
Title: [285208] trunk
Revision 285208
Author katherine_che...@apple.com
Date 2021-11-03 09:17:21 -0700 (Wed, 03 Nov 2021)
Log Message
[iOS] Need API for marking file requests as non-app-initiated
https://bugs.webkit.org/show_bug.cgi?id=232506
Reviewed by Brent Fulgham.
Source/WebKit:
Pass app initiated value through to the WebPage so file loads
can be attributed correctly.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadFileRequest:allowingReadAccessToURL:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadFile):
* UIProcess/WebPageProxy.h:
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
* TestWebKitAPI/Tests/WebKitCocoa/file-with-iframe.html: Added.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/file-with-iframe.html
Diff
Modified: trunk/Source/WebKit/ChangeLog (285207 => 285208)
--- trunk/Source/WebKit/ChangeLog 2021-11-03 16:14:05 UTC (rev 285207)
+++ trunk/Source/WebKit/ChangeLog 2021-11-03 16:17:21 UTC (rev 285208)
@@ -1,3 +1,20 @@
+2021-11-03 Kate Cheney
+
+[iOS] Need API for marking file requests as non-app-initiated
+https://bugs.webkit.org/show_bug.cgi?id=232506
+
+
+Reviewed by Brent Fulgham.
+
+Pass app initiated value through to the WebPage so file loads
+can be attributed correctly.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView loadFileRequest:allowingReadAccessToURL:]):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::loadFile):
+* UIProcess/WebPageProxy.h:
+
2021-11-02 Don Olmstead
Non-unified build fixes early November 2021 edition
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (285207 => 285208)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2021-11-03 16:14:05 UTC (rev 285207)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2021-11-03 16:17:21 UTC (rev 285208)
@@ -1763,7 +1763,12 @@
if (![readAccessURL isFileURL])
[NSException raise:NSInvalidArgumentException format:@"%@ is not a file URL", readAccessURL];
-return wrapper(_page->loadFile(URL.absoluteString, readAccessURL.absoluteString));
+bool isAppInitiated = true;
+#if ENABLE(APP_PRIVACY_REPORT)
+isAppInitiated = request.attribution == NSURLRequestAttributionDeveloper;
+#endif
+
+return wrapper(_page->loadFile(URL.absoluteString, readAccessURL.absoluteString, isAppInitiated));
}
- (CocoaColor *)themeColor
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (285207 => 285208)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-11-03 16:14:05 UTC (rev 285207)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-11-03 16:17:21 UTC (rev 285208)
@@ -1435,7 +1435,7 @@
process->startResponsivenessTimer();
}
-RefPtr WebPageProxy::loadFile(const String& fileURLString, const String& resourceDirectoryURLString, API::Object* userData)
+RefPtr WebPageProxy::loadFile(const String& fileURLString, const String& resourceDirectoryURLString, bool isAppInitiated, API::Object* userData)
{
WEBPAGEPROXY_RELEASE_LOG(Loading, "loadFile:");
@@ -1480,9 +1480,13 @@
m_pageLoadState.setPendingAPIRequest(transaction, { navigation->navigationID(), fileURLString }, resourceDirectoryURL);
+auto request = ResourceRequest(fileURL);
+request.setIsAppInitiated(isAppInitiated);
+m_lastNavigationWasAppInitiated = isAppInitiated;
+
LoadParameters loadParameters;
loadParameters.navigationID = navigation->navigationID();
-loadParameters.request = fileURL;
+loadParameters.request = WTFMove(request);
loadParameters.shouldOpenExternalURLsPolicy = ShouldOpenExternalURLsPolicy::ShouldNotAllow;
loadParameters.userData = UserData(process().transformObjectsToHandles(userData).get());
const bool checkAssumedReadAccessToResourceURL = false;
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (285207 => 285208)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2021-11-03 16:14:05 UTC (rev 285207)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2021-11-03 16:17:21 UTC (rev 285208)
@@ -647,7 +647,7 @@
void addPlatformLoadParameters(WebProcessProxy&, LoadParameters&);
RefPtr loadRequest(WebCore::ResourceRequest&&, WebCore::ShouldOpenExternalURLsPolicy = WebCore::ShouldOpenExternalURLsPolicy::ShouldAllowExternalSchemesButNotAppLinks, API::Object* userData = nullptr);
-RefPtr loadFile(const String& fileURL, const String& resourceDirectoryURL, API::Object* userData = nullptr);
+RefPtr loadFile(const String& fileURL, const String&
[webkit-changes] [285207] trunk/Tools
Title: [285207] trunk/Tools Revision 285207 Author beid...@apple.com Date 2021-11-03 09:14:05 -0700 (Wed, 03 Nov 2021) Log Message Fix iOS API tests after r285199 https://bugs.webkit.org/show_bug.cgi?id=232649 Unreviewed. * TestWebKitAPI/Tests/WebKitCocoa/NotificationAPI.mm: Definitely not ready for these tests to start running. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NotificationAPI.mm Diff Modified: trunk/Tools/ChangeLog (285206 => 285207) --- trunk/Tools/ChangeLog 2021-11-03 16:05:14 UTC (rev 285206) +++ trunk/Tools/ChangeLog 2021-11-03 16:14:05 UTC (rev 285207) @@ -1,3 +1,12 @@ +2021-11-03 Brady Eidson + +Fix iOS API tests after r285199 +https://bugs.webkit.org/show_bug.cgi?id=232649 + +Unreviewed. + +* TestWebKitAPI/Tests/WebKitCocoa/NotificationAPI.mm: Definitely not ready for these tests to start running. + 2021-11-02 Tim Horton UnicodeDecodeError in write_reftest copying a non-UTF8 expected result file Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NotificationAPI.mm (285206 => 285207) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NotificationAPI.mm 2021-11-03 16:05:14 UTC (rev 285206) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NotificationAPI.mm 2021-11-03 16:14:05 UTC (rev 285207) @@ -25,7 +25,7 @@ #import "config.h" -#if ENABLE(NOTIFICATIONS) +#if ENABLE(NOTIFICATIONS) && !PLATFORM(IOS) #import "PlatformUtilities.h" #import "TestWKWebView.h" #import @@ -170,4 +170,4 @@ } // namespace TestWebKitAPI -#endif // ENABLE(NOTIFICATIONS) +#endif // ENABLE(NOTIFICATIONS) && !PLATFORM(IOS) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285206] trunk/Source/WebKitLegacy/mac
Title: [285206] trunk/Source/WebKitLegacy/mac
Revision 285206
Author cdu...@apple.com
Date 2021-11-03 09:05:14 -0700 (Wed, 03 Nov 2021)
Log Message
Unreviewed iOS build fix.
* WebCoreSupport/WebNotificationClient.mm:
(-[WebNotificationPolicyListener NO_RETURN_DUE_TO_ASSERT]):
(-[WebNotificationPolicyListener denyOnlyThisRequest]): Deleted.
(-[WebNotificationPolicyListener shouldClearCache]): Deleted.
Modified Paths
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (285205 => 285206)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-11-03 14:37:04 UTC (rev 285205)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-11-03 16:05:14 UTC (rev 285206)
@@ -1,3 +1,12 @@
+2021-11-03 Chris Dumez
+
+Unreviewed iOS build fix.
+
+* WebCoreSupport/WebNotificationClient.mm:
+(-[WebNotificationPolicyListener NO_RETURN_DUE_TO_ASSERT]):
+(-[WebNotificationPolicyListener denyOnlyThisRequest]): Deleted.
+(-[WebNotificationPolicyListener shouldClearCache]): Deleted.
+
2021-11-01 Brady Eidson
Make WebChromeClient's m_webView pointer weak.
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm (285205 => 285206)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm 2021-11-03 14:37:04 UTC (rev 285205)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm 2021-11-03 16:05:14 UTC (rev 285206)
@@ -192,12 +192,12 @@
}
#if PLATFORM(IOS_FAMILY)
-- (void)denyOnlyThisRequest
+- (void)denyOnlyThisRequest NO_RETURN_DUE_TO_ASSERT
{
ASSERT_NOT_REACHED();
}
-- (BOOL)shouldClearCache
+- (BOOL)shouldClearCache NO_RETURN_DUE_TO_ASSERT
{
ASSERT_NOT_REACHED();
return NO;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285205] trunk/Source/WebCore
Title: [285205] trunk/Source/WebCore
Revision 285205
Author cl...@igalia.com
Date 2021-11-03 07:37:04 -0700 (Wed, 03 Nov 2021)
Log Message
[GTK][WPE] Use the display refresh to drive scrolling animations (sync scroll)
https://bugs.webkit.org/show_bug.cgi?id=232077
Reviewed by Simon Fraser.
Service sync scroll animations as part of the scroll phase in
Page::updateRendering, which is driven by the display refresh.
No new tests, covered by existing tests.
* dom/Document.cpp:
(WebCore::serviceScrollAnimationForScrollableArea):
(WebCore::Document::runScrollSteps):
* page/FrameView.cpp:
(WebCore::FrameView::didStartScrollAnimation):
* page/FrameView.h:
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::startAnimationCallback):
(WebCore::ScrollAnimator::stopAnimationCallback):
(WebCore::ScrollAnimator::serviceScrollAnimation):
(WebCore::ScrollAnimator::scrollControllerAnimationTimerFired): Deleted.
* platform/ScrollAnimator.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::didStartScrollAnimation):
* platform/ScrollingEffectsController.cpp:
(WebCore::ScrollingEffectsController::retargetAnimatedScrollBy):
* rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::didStartScrollAnimation):
* rendering/RenderLayerScrollableArea.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::didStartScrollAnimation):
* rendering/RenderListBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollAnimator.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/platform/ScrollingEffectsController.cpp
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (285204 => 285205)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 13:37:55 UTC (rev 285204)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 14:37:04 UTC (rev 285205)
@@ -1,3 +1,39 @@
+2021-11-03 Chris Lord
+
+[GTK][WPE] Use the display refresh to drive scrolling animations (sync scroll)
+https://bugs.webkit.org/show_bug.cgi?id=232077
+
+Reviewed by Simon Fraser.
+
+Service sync scroll animations as part of the scroll phase in
+Page::updateRendering, which is driven by the display refresh.
+
+No new tests, covered by existing tests.
+
+* dom/Document.cpp:
+(WebCore::serviceScrollAnimationForScrollableArea):
+(WebCore::Document::runScrollSteps):
+* page/FrameView.cpp:
+(WebCore::FrameView::didStartScrollAnimation):
+* page/FrameView.h:
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::ScrollAnimator):
+(WebCore::ScrollAnimator::startAnimationCallback):
+(WebCore::ScrollAnimator::stopAnimationCallback):
+(WebCore::ScrollAnimator::serviceScrollAnimation):
+(WebCore::ScrollAnimator::scrollControllerAnimationTimerFired): Deleted.
+* platform/ScrollAnimator.h:
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::didStartScrollAnimation):
+* platform/ScrollingEffectsController.cpp:
+(WebCore::ScrollingEffectsController::retargetAnimatedScrollBy):
+* rendering/RenderLayerScrollableArea.cpp:
+(WebCore::RenderLayerScrollableArea::didStartScrollAnimation):
+* rendering/RenderLayerScrollableArea.h:
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::didStartScrollAnimation):
+* rendering/RenderListBox.h:
+
2021-11-03 Zalan Bujtas
[LFC][IFC] Display box builder should take visual order into account when computing horizontal positions
Modified: trunk/Source/WebCore/dom/Document.cpp (285204 => 285205)
--- trunk/Source/WebCore/dom/Document.cpp 2021-11-03 13:37:55 UTC (rev 285204)
+++ trunk/Source/WebCore/dom/Document.cpp 2021-11-03 14:37:04 UTC (rev 285205)
@@ -211,6 +211,7 @@
#include "ScriptSourceCode.h"
#include "ScriptState.h"
#include "ScriptedAnimationController.h"
+#include "ScrollAnimator.h"
#include "ScrollbarTheme.h"
#include "ScrollingCoordinator.h"
#include "SecurityOrigin.h"
@@ -4347,9 +4348,35 @@
m_needsVisualViewportScrollEvent = true;
}
+static bool serviceScrollAnimationForScrollableArea(ScrollableArea* scrollableArea, MonotonicTime time)
+{
+if (!scrollableArea)
+return false;
+
+if (auto* animator = scrollableArea->existingScrollAnimator())
+return animator->serviceScrollAnimation(time) == ScrollAnimationStatus::Animating;
+
+return false;
+}
+
// https://drafts.csswg.org/cssom-view/#run-the-scroll-steps
void Document::runScrollSteps()
{
+// Service
[webkit-changes] [285204] trunk/Source/WebCore
Title: [285204] trunk/Source/WebCore
Revision 285204
Author za...@apple.com
Date 2021-11-03 06:37:55 -0700 (Wed, 03 Nov 2021)
Log Message
[LFC][IFC] Display box builder should take visual order into account when computing horizontal positions
https://bugs.webkit.org/show_bug.cgi?id=232655
Reviewed by Antti Koivisto.
In this patch we turn logical horizontal positions into "physical" positions based on the visual order of the runs.
With this change, now IFC can render simple RTL content.
* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent): Move shared code to displayBoxRect.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (285203 => 285204)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 12:45:37 UTC (rev 285203)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 13:37:55 UTC (rev 285204)
@@ -1,3 +1,16 @@
+2021-11-03 Zalan Bujtas
+
+[LFC][IFC] Display box builder should take visual order into account when computing horizontal positions
+https://bugs.webkit.org/show_bug.cgi?id=232655
+
+Reviewed by Antti Koivisto.
+
+In this patch we turn logical horizontal positions into "physical" positions based on the visual order of the runs.
+With this change, now IFC can render simple RTL content.
+
+* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
+(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent): Move shared code to displayBoxRect.
+
2021-11-03 Antti Koivisto
Use Style::ScopeOrdinal for finding the right scope for ::part matching
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp (285203 => 285204)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp 2021-11-03 12:45:37 UTC (rev 285203)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp 2021-11-03 13:37:55 UTC (rev 285204)
@@ -74,17 +74,63 @@
auto& runs = lineContent.runs;
auto contentNeedsBidiReordering = !lineContent.visualOrderList.isEmpty();
ASSERT(!contentNeedsBidiReordering || lineContent.visualOrderList.size() == runs.size());
+
+auto contentRightInVisualOrder = InlineLayoutUnit { };
for (size_t i = 0; i < runs.size(); ++i) {
-auto& lineRun = runs[contentNeedsBidiReordering ? lineContent.visualOrderList[i] : i];
+auto visualIndex = contentNeedsBidiReordering ? lineContent.visualOrderList[i] : i;
+auto& lineRun = runs[visualIndex];
auto& layoutBox = lineRun.layoutBox();
auto& style = [&] () -> const RenderStyle& {
return !lineIndex ? layoutBox.firstLineStyle() : layoutBox.style();
}();
+auto displayBoxRect = [&] {
+auto logicalRect = InlineRect { };
+
+if (lineRun.isText() || lineRun.isSoftLineBreak())
+logicalRect = lineBox.logicalRectForTextRun(lineRun);
+else if (lineRun.isHardLineBreak())
+logicalRect = lineBox.logicalRectForLineBreakBox(layoutBox);
+else {
+auto& boxGeometry = formattingState.boxGeometry(layoutBox);
+if (lineRun.isBox())
+logicalRect = lineBox.logicalBorderBoxForAtomicInlineLevelBox(layoutBox, boxGeometry);
+else if (lineRun.isInlineBoxStart() || lineRun.isLineSpanningInlineBoxStart())
+logicalRect = lineBox.logicalBorderBoxForInlineBox(layoutBox, boxGeometry);
+else
+ASSERT_NOT_REACHED();
+}
+if (!contentNeedsBidiReordering) {
+logicalRect.moveBy(lineBoxLogicalTopLeft);
+return logicalRect;
+}
+logicalRect.moveVertically(lineBoxLogicalTopLeft.y());
+// Use the distance from the logical previous run to place the display box horizontally in visual terms.
+auto* logicalPreviousRun = visualIndex ? [visualIndex - 1] : nullptr;
+// Certain css properties (e.g. word-spacing) may introduce a gap between runs.
+auto distanceFromLogicalPreviousRun = logicalPreviousRun ? lineRun.logicalLeft() - logicalPreviousRun->logicalRight() : lineRun.logicalLeft();
+auto visualOrderRect = logicalRect;
+auto contentLeft = contentRightInVisualOrder + distanceFromLogicalPreviousRun;
+if (!i) {
+// First visual run. Initial content position depends on the block's inline direction.
+contentLeft += lineBoxLogicalTopLeft.x();
+
+auto rootInlineBox = boxes[0];
+ASSERT(rootInlineBox.isRootInlineBox());
+if
[webkit-changes] [285203] trunk/LayoutTests
Title: [285203] trunk/LayoutTests Revision 285203 Author n...@apple.com Date 2021-11-03 05:45:37 -0700 (Wed, 03 Nov 2021) Log Message Make render-layer-rebuild-z-order-lists.html use an HTML reference https://bugs.webkit.org/show_bug.cgi?id=232658 Reviewed by Antti Koivisto. This not only tests the crash, but also tests that the dialog is rendered (which was not the case at the first iteration of the patch which introduced this test). Also done some minor cleanups to the test. * fast/layers/render-layer-rebuild-z-order-lists-expected.html: Added. * fast/layers/render-layer-rebuild-z-order-lists-expected.txt: Removed. * fast/layers/render-layer-rebuild-z-order-lists.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists.html Added Paths trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.html Removed Paths trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (285202 => 285203) --- trunk/LayoutTests/ChangeLog 2021-11-03 10:59:18 UTC (rev 285202) +++ trunk/LayoutTests/ChangeLog 2021-11-03 12:45:37 UTC (rev 285203) @@ -1,3 +1,19 @@ +2021-11-03 Tim Nguyen + +Make render-layer-rebuild-z-order-lists.html use an HTML reference +https://bugs.webkit.org/show_bug.cgi?id=232658 + +Reviewed by Antti Koivisto. + +This not only tests the crash, but also tests that the dialog is rendered (which was not +the case at the first iteration of the patch which introduced this test). + +Also done some minor cleanups to the test. + +* fast/layers/render-layer-rebuild-z-order-lists-expected.html: Added. +* fast/layers/render-layer-rebuild-z-order-lists-expected.txt: Removed. +* fast/layers/render-layer-rebuild-z-order-lists.html: + 2021-11-03 Arcady Goldmints-Orlov REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails Added: trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.html (0 => 285203) --- trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.html (rev 0) +++ trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.html 2021-11-03 12:45:37 UTC (rev 285203) @@ -0,0 +1,4 @@ +PASS if this displays and doesn't crash + +document.querySelector("dialog").showModal(); + \ No newline at end of file Deleted: trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.txt (285202 => 285203) --- trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.txt 2021-11-03 10:59:18 UTC (rev 285202) +++ trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.txt 2021-11-03 12:45:37 UTC (rev 285203) @@ -1 +0,0 @@ -PASS if this doesn't crash Modified: trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists.html (285202 => 285203) --- trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists.html 2021-11-03 10:59:18 UTC (rev 285202) +++ trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists.html 2021-11-03 12:45:37 UTC (rev 285203) @@ -7,16 +7,13 @@_onload_ = () => {-diag = document.getElementById('diag0'); -diag.showModal(); -if (window.testRunner) -testRunner.dumpAsText();+document.querySelector("dialog").showModal(); } - -PASS if this doesn't crash + +PASS if this displays and doesn't crash ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285202] trunk/Source/WebCore
Title: [285202] trunk/Source/WebCore
Revision 285202
Author an...@apple.com
Date 2021-11-03 03:59:18 -0700 (Wed, 03 Nov 2021)
Log Message
Use Style::ScopeOrdinal for finding the right scope for ::part matching
https://bugs.webkit.org/show_bug.cgi?id=232562
Reviewed by Simon Fraser.
We are already passing the scope ordinal to the selector checker so we can use it consistently to find
the right scope.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
Find the right scope based on the scope ordinal.
Simplify allowMultiplePseudoElements check, invalid cases are not allowed by the parser.
(WebCore::SelectorChecker::checkOne const):
Find the right scope based on the scope ordinal.
* css/SelectorChecker.h:
* dom/ShadowRoot.h:
* style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::matchPartPseudoElementRulesForScope):
Compute the scope ordinal for nested scopes.
Make iterative instead of recursive.
(WebCore::Style::ElementRuleCollector::ruleMatches):
(WebCore::Style::ElementRuleCollector::matchAllRules):
Flush all remaining rules.
* style/ElementRuleCollector.h:
* style/StyleScope.cpp:
(WebCore::Style::Scope::forOrdinal):
(WebCore::Style::assignedSlotForScopeOrdinal):
(WebCore::Style::hostForScopeOrdinal):
Add helpers.
* style/StyleScope.h:
* style/StyleScopeOrdinal.h:
(WebCore::Style::operator--):
We now use values less than ContainingHost to present enclosing scopes, similar to slotted matching.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorChecker.h
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/style/ElementRuleCollector.cpp
trunk/Source/WebCore/style/ElementRuleCollector.h
trunk/Source/WebCore/style/StyleScope.cpp
trunk/Source/WebCore/style/StyleScope.h
trunk/Source/WebCore/style/StyleScopeOrdinal.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (285201 => 285202)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 10:36:59 UTC (rev 285201)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 10:59:18 UTC (rev 285202)
@@ -1,3 +1,50 @@
+2021-11-03 Antti Koivisto
+
+Use Style::ScopeOrdinal for finding the right scope for ::part matching
+https://bugs.webkit.org/show_bug.cgi?id=232562
+
+Reviewed by Simon Fraser.
+
+We are already passing the scope ordinal to the selector checker so we can use it consistently to find
+the right scope.
+
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::matchRecursively const):
+
+Find the right scope based on the scope ordinal.
+Simplify allowMultiplePseudoElements check, invalid cases are not allowed by the parser.
+
+(WebCore::SelectorChecker::checkOne const):
+
+Find the right scope based on the scope ordinal.
+
+* css/SelectorChecker.h:
+* dom/ShadowRoot.h:
+* style/ElementRuleCollector.cpp:
+(WebCore::Style::ElementRuleCollector::matchPartPseudoElementRulesForScope):
+
+Compute the scope ordinal for nested scopes.
+Make iterative instead of recursive.
+
+(WebCore::Style::ElementRuleCollector::ruleMatches):
+(WebCore::Style::ElementRuleCollector::matchAllRules):
+
+Flush all remaining rules.
+
+* style/ElementRuleCollector.h:
+* style/StyleScope.cpp:
+(WebCore::Style::Scope::forOrdinal):
+(WebCore::Style::assignedSlotForScopeOrdinal):
+(WebCore::Style::hostForScopeOrdinal):
+
+Add helpers.
+
+* style/StyleScope.h:
+* style/StyleScopeOrdinal.h:
+(WebCore::Style::operator--):
+
+We now use values less than ContainingHost to present enclosing scopes, similar to slotted matching.
+
2021-11-02 Brady Eidson
Notifications on iOS enabled at compile-time, disabled at runtime
Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (285201 => 285202)
--- trunk/Source/WebCore/css/SelectorChecker.cpp 2021-11-03 10:36:59 UTC (rev 285201)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2021-11-03 10:59:18 UTC (rev 285202)
@@ -316,8 +316,7 @@
nextContext.pseudoId = PseudoId::None;
-bool nextIsPart = leftSelector->match() == CSSSelector::PseudoElement && leftSelector->pseudoElementType() == CSSSelector::PseudoElementPart;
-bool allowMultiplePseudoElements = relation == CSSSelector::ShadowDescendant && nextIsPart;
+bool allowMultiplePseudoElements = relation == CSSSelector::ShadowDescendant;
// Virtual pseudo element is only effective in the rightmost fragment.
if (!allowMultiplePseudoElements)
nextContext.pseudoElementEffective = false;
@@ -409,11 +408,14 @@
}
case CSSSelector::ShadowDescendant:
case CSSSelector::ShadowPartDescendant: {
-// When matching foo::part(bar) we skip directly to the tree of element 'foo'.
-auto* shadowHost = relation ==
[webkit-changes] [285201] trunk
Title: [285201] trunk
Revision 285201
Author psaave...@igalia.com
Date 2021-11-03 03:36:59 -0700 (Wed, 03 Nov 2021)
Log Message
[cmake] Check "cortex" string in the CMAKE_SYSTEM_PROCESSOR for defining WTF_CPU_* vars
https://bugs.webkit.org/show_bug.cgi?id=232623
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/WebKitCommon.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/WebKitCommon.cmake
Diff
Modified: trunk/ChangeLog (285200 => 285201)
--- trunk/ChangeLog 2021-11-03 08:23:50 UTC (rev 285200)
+++ trunk/ChangeLog 2021-11-03 10:36:59 UTC (rev 285201)
@@ -1,3 +1,12 @@
+2021-11-03 Pablo Saavedra
+
+[cmake] Check "cortex" string in the CMAKE_SYSTEM_PROCESSOR for defining WTF_CPU_* vars
+https://bugs.webkit.org/show_bug.cgi?id=232623
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* Source/cmake/WebKitCommon.cmake:
+
2021-11-01 Don Olmstead
[Curl] Explicitly disable libcurl's internal cookie support
Modified: trunk/Source/cmake/WebKitCommon.cmake (285200 => 285201)
--- trunk/Source/cmake/WebKitCommon.cmake 2021-11-03 08:23:50 UTC (rev 285200)
+++ trunk/Source/cmake/WebKitCommon.cmake 2021-11-03 10:36:59 UTC (rev 285201)
@@ -86,9 +86,9 @@
else ()
string(TOLOWER ${CMAKE_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
endif ()
-if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(^aarch64|^arm64)")
+if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(^aarch64|^arm64|^cortex-?[am][2-7][2-8])")
set(WTF_CPU_ARM64 1)
-elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
+elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(^arm|^cortex)")
set(WTF_CPU_ARM 1)
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^mips64")
set(WTF_CPU_MIPS64 1)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285200] trunk/LayoutTests
Title: [285200] trunk/LayoutTests
Revision 285200
Author commit-qu...@webkit.org
Date 2021-11-03 01:23:50 -0700 (Wed, 03 Nov 2021)
Log Message
REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails
https://bugs.webkit.org/show_bug.cgi?id=232627
Use UIHelper.waitForTargetScrollAnimationToSettle rather than a timeout to make the test reliable.
Patch by Arcady Goldmints-Orlov on 2021-11-03
Reviewed by Martin Robinson.
* fast/frames/flattening/scrolling-in-object.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html
Diff
Modified: trunk/LayoutTests/ChangeLog (285199 => 285200)
--- trunk/LayoutTests/ChangeLog 2021-11-03 06:53:13 UTC (rev 285199)
+++ trunk/LayoutTests/ChangeLog 2021-11-03 08:23:50 UTC (rev 285200)
@@ -1,3 +1,14 @@
+2021-11-03 Arcady Goldmints-Orlov
+
+REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails
+https://bugs.webkit.org/show_bug.cgi?id=232627
+
+Use UIHelper.waitForTargetScrollAnimationToSettle rather than a timeout to make the test reliable.
+
+Reviewed by Martin Robinson.
+
+* fast/frames/flattening/scrolling-in-object.html:
+
2021-11-02 Gabriel Nava Marino
Crash in RenderLayer::rebuildZOrderLists
Modified: trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html (285199 => 285200)
--- trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html 2021-11-03 06:53:13 UTC (rev 285199)
+++ trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html 2021-11-03 08:23:50 UTC (rev 285200)
@@ -1,12 +1,14 @@
+