[webkit-changes] [290721] trunk/Source

2022-03-01 Thread youenn 
Title: [290721] trunk/Source








Revision 290721
Author you...@apple.com
Date 2022-03-01 23:08:11 -0800 (Tue, 01 Mar 2022)


Log Message
Remove RemoteVideoSample support from ImageTransferSessionVT
https://bugs.webkit.org/show_bug.cgi?id=237318

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

* platform/graphics/cv/ImageTransferSessionVT.h:
* platform/graphics/cv/ImageTransferSessionVT.mm:
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/RealtimeVideoCaptureSource.cpp:

Source/WebKit:

Remove no longer needed forward declaration or include of RemoteVideoSample.
Remove ImageTransferSessionVT::createMediaSample(RemoteVideoSample&&) and replace it with direct use of MediaSampleAVFObjC.

No change of behavior.

* GPUProcess/webrtc/RemoteMediaRecorder.cpp:
* GPUProcess/webrtc/RemoteMediaRecorder.h:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
* WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
* WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
* WebProcess/cocoa/RemoteCaptureSampleManager.h:
* WebProcess/cocoa/RemoteRealtimeAudioSource.h:
* WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
* WebProcess/cocoa/UserMediaCaptureManager.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h
trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
trunk/Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.h
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
trunk/Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp
trunk/Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.h
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeAudioSource.h
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290720 => 290721)

--- trunk/Source/WebCore/ChangeLog	2022-03-02 06:42:27 UTC (rev 290720)
+++ trunk/Source/WebCore/ChangeLog	2022-03-02 07:08:11 UTC (rev 290721)
@@ -1,3 +1,17 @@
+2022-03-01  Youenn Fablet  
+
+Remove RemoteVideoSample support from ImageTransferSessionVT
+https://bugs.webkit.org/show_bug.cgi?id=237318
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+
+* platform/graphics/cv/ImageTransferSessionVT.h:
+* platform/graphics/cv/ImageTransferSessionVT.mm:
+* platform/mediastream/RealtimeMediaSource.h:
+* platform/mediastream/RealtimeVideoCaptureSource.cpp:
+
 2022-03-01  Fujii Hironori  
 
 Fix deprecations for ERB.new in GenerateSettings.rb


Modified: trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h (290720 => 290721)

--- trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h	2022-03-02 06:42:27 UTC (rev 290720)
+++ trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h	2022-03-02 07:08:11 UTC (rev 290721)
@@ -38,8 +38,6 @@
 
 namespace WebCore {
 
-class RemoteVideoSample;
-
 class ImageTransferSessionVT {
 public:
 static std::unique_ptr create(uint32_t pixelFormat, bool shouldUseIOSurface = true)
@@ -53,10 +51,7 @@
 
 #if !PLATFORM(MACCATALYST)
 WEBCORE_EXPORT RefPtr createMediaSample(IOSurfaceRef, const MediaTime&, const IntSize&, MediaSample::VideoRotation = MediaSample::VideoRotation::None, bool mirrored = false);
-#if ENABLE(MEDIA_STREAM)
-WEBCORE_EXPORT RefPtr createMediaSample(const RemoteVideoSample&);
 #endif
-#endif
 
 uint32_t pixelFormat() const { return m_pixelFormat; }
 


Modified: trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm (290720 => 290721)

--- trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm	2022-03-02 06:42:27 UTC (rev 290720)
+++ trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm	2022-03-02 07:08:11 UTC (rev 290721)
@@ -30,7 +30,6 @@
 #import "GraphicsContextCG.h"
 #import "Logging.h"
 #import "MediaSampleAVFObjC.h"
-#import "RemoteVideoSample.h"
 #import 
 #import 
 
@@ -270,13 +269,6 @@
 }
 
 #if !PLATFORM(MACCATALYST)
-#if ENABLE(MEDIA_STREAM)
-RefPtr ImageTransferSessionVT::createMediaSample(const RemoteVideoSample& remoteSample)
-{
-return createMediaSample(remoteSample.surface(), remoteSample.time(), remoteSample.size(), remoteSample.rotation(), remoteSample.mirrored());
-}
-#endif
-
 RefPtr ImageTransferSessionVT::createMediaSample(IOSurfaceRef surface, const Medi

[webkit-changes] [290720] trunk

2022-03-01 Thread drousso 
Title: [290720] trunk








Revision 290720
Author drou...@apple.com
Date 2022-03-01 22:42:27 -0800 (Tue, 01 Mar 2022)


Log Message
Web Inspector: add a switch to control whether breakpoint evaluations (condition, ignore count, actions) are also affected by script blackboxing
https://bugs.webkit.org/show_bug.cgi?id=235274

Reviewed by Patrick Angle.

Source/_javascript_Core:

Being able to defer breakpoint evaluations until the next actual pause can sometimes be far
more useful than doing the breakpoint evaluations at the breakpoint's original location.

As an example, configuring the All Events breakpoint with a `console.trace()` action and
auto-continue enabled would not provide much useful information without also blackboxing
breakpoint evaluations as the original pause location of the All Events breakpoint is on the
first line of the event handler, meaning that if the script containing the event handler is
blackboxed then the `console.trace()` would still only show that location even though the
Sources Tab would show the first line of code outside of that script (due to the blackbox).
Being able to also blackbox breakpoint evaluations would instead cause the `console.trace()`
action to have the same output as the Sources Tab, since it's evaluation would be deferred
until execution actually paused, which is further inside the event handler.

* debugger/Debugger.cpp:
(JSC::Debugger::Debugger):
(JSC::Debugger::didHitBreakpoint):
(JSC::Debugger::evaluateBreakpointCondition):
(JSC::Debugger::continueProgram):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::setBlackboxBreakpointEvaluations): Added.
Keep track of every `Breakpoint` wants to pause but is deferred due to blackboxing.
Depending on whether breakpoint evaluations are also blackboxed (based on the flag set via
the piping code/logic below), check if the script attempting to be paused in is blackboxed
before or after handling breakpoint evaluations.
Side effects of this change are:
- breakpoint conditions are now evaluated right before that breakpoint's actions, instead of
  evaluating all breakpoint conditions before all breakpoint actions
- if breakpoint evaluations are blackboxed, more than two breakpoints can now be evaluated
during a single pause attempt depending on how may deferrals (with breakpoints) happened

* debugger/Debugger.h:
(JSC::Debugger::Observer::didDeferBreakpointPause): Added.
Add a way to notify `InspectorDebuggerAgent` of deferred breakpoint pauses so that the
correct `originalReason` will be used after a deferred pause.

* inspector/protocol/Debugger.json:
* inspector/agents/InspectorDebuggerAgent.h:
* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::setBlackboxBreakpointEvaluations): Added.
(Inspector::InspectorDebuggerAgent::didDeferBreakpointPause): Added.
Add a `setBlackboxBreakpointEvaluations` command that passes directly to `Debugger`.

Source/WebInspectorUI:

Being able to defer breakpoint evaluations until the next actual pause can sometimes be far
more useful than doing the breakpoint evaluations at the breakpoint's original location.

As an example, configuring the All Events breakpoint with a `console.trace()` action and
auto-continue enabled would not provide much useful information without also blackboxing
breakpoint evaluations as the original pause location of the All Events breakpoint is on the
first line of the event handler, meaning that if the script containing the event handler is
blackboxed then the `console.trace()` would still only show that location even though the
Sources Tab would show the first line of code outside of that script (due to the blackbox).
Being able to also blackbox breakpoint evaluations would instead cause the `console.trace()`
action to have the same output as the Sources Tab, since it's evaluation would be deferred
until execution actually paused, which is further inside the event handler

* UserInterface/Base/Setting.js:
* UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.supportsBlackboxingBreakpointEvaluations): Added.
(WI.DebuggerManager.prototype.async initializeTarget):
(WI.DebuggerManager.prototype._setBlackboxBreakpointEvaluations): Added.
(WI.DebuggerManager.prototype._handleBlackboxBreakpointEvaluationsChange): Added.
Create a global `WI.Setting` for this feature and handle changes from the code below.

* UserInterface/Views/BlackboxSettingsView.js:
(WI.BlackboxSettingsView.prototype.initialLayout):
* UserInterface/Views/BlackboxSettingsView.css:
(.settings-view.blackbox > p > label): Added.
(.settings-view.blackbox > p > label > input): Added.
(.settings-view.blackbox > p > label > span): Added.
Add a checkbox and explanation of this new feature in the Blackbox pane of the Settings Tab.

* Localizations/en.lproj/localizedStrings.js:

LayoutTests:

* inspector/debugger/setBlackboxBreakpointEvaluations.html: Added.
* inspector/debugger/setBlackboxBreakpointEvaluations-expected.txt: Adde

[webkit-changes] [290719] trunk/Source/bmalloc

2022-03-01 Thread basuke . suzuki 
Title: [290719] trunk/Source/bmalloc








Revision 290719
Author basuke.suz...@sony.com
Date 2022-03-01 22:05:31 -0800 (Tue, 01 Mar 2022)


Log Message
[libpas] Add missing PlayStation implementation.
https://bugs.webkit.org/show_bug.cgi?id=237341

Reviewed by Yusuke Suzuki.

* libpas/src/libpas/pas_monotonic_time.c:
(pas_get_current_monotonic_time_nanoseconds):

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c




Diff

Modified: trunk/Source/bmalloc/ChangeLog (290718 => 290719)

--- trunk/Source/bmalloc/ChangeLog	2022-03-02 06:03:13 UTC (rev 290718)
+++ trunk/Source/bmalloc/ChangeLog	2022-03-02 06:05:31 UTC (rev 290719)
@@ -1,3 +1,13 @@
+2022-03-01  Basuke Suzuki  
+
+[libpas] Add missing PlayStation implementation.
+https://bugs.webkit.org/show_bug.cgi?id=237341
+
+Reviewed by Yusuke Suzuki.
+
+* libpas/src/libpas/pas_monotonic_time.c:
+(pas_get_current_monotonic_time_nanoseconds):
+
 2022-02-25  Basuke Suzuki  
 
 [libpas] Suppress cast-align warnings


Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c (290718 => 290719)

--- trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c	2022-03-02 06:03:13 UTC (rev 290718)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c	2022-03-02 06:05:31 UTC (rev 290719)
@@ -80,6 +80,15 @@
 return ts.tv_sec * 1.0e9 + ts.tv_nsec;
 }
 
+#elif PAS_PLATFORM(PLAYSTATION)
+
+uint64_t pas_get_current_monotonic_time_nanoseconds(void)
+{
+struct timespec ts;
+clock_gettime_np(CLOCK_MONOTONIC_FAST, &ts);
+return ts.tv_sec * 1000u * 1000u * 1000u + ts.tv_nsec;
+}
+
 #endif
 
 #endif /* LIBPAS_ENABLED */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290718] trunk/Source/WebCore

2022-03-01 Thread Hironori . Fujii 
Title: [290718] trunk/Source/WebCore








Revision 290718
Author hironori.fu...@sony.com
Date 2022-03-01 22:03:13 -0800 (Tue, 01 Mar 2022)


Log Message
Fix deprecations for ERB.new in GenerateSettings.rb
https://bugs.webkit.org/show_bug.cgi?id=237237

Reviewed by Don Olmstead.

Ruby 3.1.0 reported the following warning:
> GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
> GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

r290104 and r290331 fixed the same problem for
GeneratePreferences.rb, but forgot GenerateSettings.rb.

* Scripts/GenerateSettings.rb: Use the keyword argument for ERB.new for Ruby 2.6+.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Scripts/GenerateSettings.rb




Diff

Modified: trunk/Source/WebCore/ChangeLog (290717 => 290718)

--- trunk/Source/WebCore/ChangeLog	2022-03-02 03:42:31 UTC (rev 290717)
+++ trunk/Source/WebCore/ChangeLog	2022-03-02 06:03:13 UTC (rev 290718)
@@ -1,3 +1,19 @@
+2022-03-01  Fujii Hironori  
+
+Fix deprecations for ERB.new in GenerateSettings.rb
+https://bugs.webkit.org/show_bug.cgi?id=237237
+
+Reviewed by Don Olmstead.
+
+Ruby 3.1.0 reported the following warning:
+> GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
+> GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
+
+r290104 and r290331 fixed the same problem for
+GeneratePreferences.rb, but forgot GenerateSettings.rb.
+
+* Scripts/GenerateSettings.rb: Use the keyword argument for ERB.new for Ruby 2.6+.
+
 2022-03-01  Andres Gonzalez  
 
 Unnecessary copy of Vector of children IDs in AXIsolatedTree::updateChildren.


Modified: trunk/Source/WebCore/Scripts/GenerateSettings.rb (290717 => 290718)

--- trunk/Source/WebCore/Scripts/GenerateSettings.rb	2022-03-02 03:42:31 UTC (rev 290717)
+++ trunk/Source/WebCore/Scripts/GenerateSettings.rb	2022-03-02 06:03:13 UTC (rev 290718)
@@ -280,7 +280,11 @@
   def renderTemplate(template, outputDirectory)
 file = File.join(outputDirectory, File.basename(template, ".erb"))
 
-output = ERB.new(File.read(template), 0, "-").result(binding)
+if ERB.instance_method(:initialize).parameters.assoc(:key) # Ruby 2.6+
+output = ERB.new(File.read(template), trim_mode:"-").result(binding)
+else
+output = ERB.new(File.read(template), 0, "-").result(binding)
+end
 File.open(file, "w+") do |f|
   f.write(output)
 end






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290717] trunk/Source/JavaScriptCore

2022-03-01 Thread sbarati 
Title: [290717] trunk/Source/_javascript_Core








Revision 290717
Author sbar...@apple.com
Date 2022-03-01 19:42:31 -0800 (Tue, 01 Mar 2022)


Log Message
Add a DeferTraps scope
https://bugs.webkit.org/show_bug.cgi?id=237306


Reviewed by Mark Lam.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::noticeIncomingCall):
* bytecode/CodeBlock.h:
* bytecode/RepatchInlines.h:
(JSC::linkFor):
(JSC::virtualForWithFunction):
* dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):
* interpreter/InterpreterInlines.h:
(JSC::Interpreter::execute):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::installCode):
* runtime/VMTraps.cpp:
(JSC::VMTraps::handleTraps):
(JSC::VMTraps::takeTopPriorityTrap):
* runtime/VMTraps.h:
(JSC::VMTraps::needHandling const):
(JSC::VMTraps::hasTrapBit):
(JSC::VMTraps::setTrapBit):
* runtime/VMTrapsInlines.h:
(JSC::DeferTraps::DeferTraps):
(JSC::DeferTraps::~DeferTraps):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecode/RepatchInlines.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/interpreter/InterpreterInlines.h
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/ScriptExecutable.cpp
trunk/Source/_javascript_Core/runtime/VMTraps.cpp
trunk/Source/_javascript_Core/runtime/VMTraps.h
trunk/Source/_javascript_Core/runtime/VMTrapsInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (290716 => 290717)

--- trunk/Source/_javascript_Core/ChangeLog	2022-03-02 02:11:05 UTC (rev 290716)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-02 03:42:31 UTC (rev 290717)
@@ -1,3 +1,44 @@
+2022-03-01  Saam Barati  
+
+Add a DeferTraps scope
+https://bugs.webkit.org/show_bug.cgi?id=237306
+
+
+Reviewed by Mark Lam.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+(JSC::CodeBlock::jettison):
+(JSC::CodeBlock::noticeIncomingCall):
+* bytecode/CodeBlock.h:
+* bytecode/RepatchInlines.h:
+(JSC::linkFor):
+(JSC::virtualForWithFunction):
+* dfg/DFGOperations.cpp:
+(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::executeProgram):
+(JSC::Interpreter::executeCall):
+(JSC::Interpreter::executeConstruct):
+(JSC::Interpreter::execute):
+(JSC::Interpreter::executeModuleProgram):
+* interpreter/InterpreterInlines.h:
+(JSC::Interpreter::execute):
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::setUpCall):
+* runtime/ScriptExecutable.cpp:
+(JSC::ScriptExecutable::installCode):
+* runtime/VMTraps.cpp:
+(JSC::VMTraps::handleTraps):
+(JSC::VMTraps::takeTopPriorityTrap):
+* runtime/VMTraps.h:
+(JSC::VMTraps::needHandling const):
+(JSC::VMTraps::hasTrapBit):
+(JSC::VMTraps::setTrapBit):
+* runtime/VMTrapsInlines.h:
+(JSC::DeferTraps::DeferTraps):
+(JSC::DeferTraps::~DeferTraps):
+
 2022-03-01  Fujii Hironori  
 
 WTF::SentinelLinkedList::iterator should have operator++ for range-for loop


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (290716 => 290717)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2022-03-02 02:11:05 UTC (rev 290716)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2022-03-02 03:42:31 UTC (rev 290717)
@@ -279,6 +279,7 @@
 , m_didFailJITCompilation(false)
 , m_didFailFTLCompilation(false)
 , m_hasBeenCompiledWithFTL(false)
+, m_isJettisoned(false)
 , m_numCalleeLocals(other.m_numCalleeLocals)
 , m_numVars(other.m_numVars)
 , m_numberOfArgumentsToSkip(other.m_numberOfArgumentsToSkip)
@@ -330,6 +331,7 @@
 , m_didFailJITCompilation(false)
 , m_didFailFTLCompilation(false)
 , m_hasBeenCompiledWithFTL(false)
+, m_isJettisoned(false)
 , m_numCalleeLocals(unlinkedCodeBlock->numCalleeLocals())
 , m_numVars(unlinkedCodeBlock->numVars())
 , m_hasDebuggerStatement(false)
@@ -2190,6 +2192,8 @@
 
 VM& vm = *m_vm;
 
+m_isJettisoned = true;
+
 CodeBlock* codeBlock = this; // Placate GCC for use in CODEBLOCK_LOG_EVENT  (does not like this).
 CODEBLOCK_LOG_EVENT(codeBlock, "jettison", ("due to ", reason, ", counting = ", mode == CountReoptimization, ", detail = ", pointerDump(detail)));
 
@@ -2356,6 +2360,8 @@
 
 void CodeBlock::noticeIncomingCall(CallFrame* callerFra

[webkit-changes] [290716] trunk/LayoutTests

2022-03-01 Thread jenner 
Title: [290716] trunk/LayoutTests








Revision 290716
Author jen...@apple.com
Date 2022-03-01 18:11:05 -0800 (Tue, 01 Mar 2022)


Log Message
[ iOS ] pointerevents/mouse/* 10 pointer event tests are constant timeouts or failures on iOS.
https://bugs.webkit.org/show_bug.cgi?id=237348

Unreviewed test gardening.

Patch by Matteo Flores  on 2022-03-01

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290715 => 290716)

--- trunk/LayoutTests/ChangeLog	2022-03-02 02:03:52 UTC (rev 290715)
+++ trunk/LayoutTests/ChangeLog	2022-03-02 02:11:05 UTC (rev 290716)
@@ -1,3 +1,12 @@
+2022-03-01  Matteo Flores  
+
+[ iOS ] pointerevents/mouse/* 10 pointer event tests are constant timeouts or failures on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=237348
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2022-03-01  Jon Lee  
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (290715 => 290716)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-02 02:03:52 UTC (rev 290715)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-02 02:11:05 UTC (rev 290716)
@@ -2197,7 +2197,7 @@
 
 # See webkit.org/b/233498 for context on this pointerevents tests
 imported/w3c/web-platform-tests/pointerevents [ Skip ]
-pointerevents/mouse [ Failure ]
+webkit.org/b/237348 pointerevents/mouse [ Skip ]
 
 # webkit.org/b/234410 Multiple semantics web-platform-tests have become flaky after r286944
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_allow_downloads.tentative.html [ DumpJSConsoleLogInStdErr Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290715] trunk/Source/WebCore

2022-03-01 Thread andresg_22 
Title: [290715] trunk/Source/WebCore








Revision 290715
Author andresg...@apple.com
Date 2022-03-01 18:03:52 -0800 (Tue, 01 Mar 2022)


Log Message
Unnecessary copy of Vector of children IDs in AXIsolatedTree::updateChildren.
https://bugs.webkit.org/show_bug.cgi?id=237338


Reviewed by Chris Fleizach.

Changed the copy of this Vector to a move.

* accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildren):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (290714 => 290715)

--- trunk/Source/WebCore/ChangeLog	2022-03-02 01:53:20 UTC (rev 290714)
+++ trunk/Source/WebCore/ChangeLog	2022-03-02 02:03:52 UTC (rev 290715)
@@ -1,3 +1,16 @@
+2022-03-01  Andres Gonzalez  
+
+Unnecessary copy of Vector of children IDs in AXIsolatedTree::updateChildren.
+https://bugs.webkit.org/show_bug.cgi?id=237338
+
+
+Reviewed by Chris Fleizach.
+
+Changed the copy of this Vector to a move.
+
+* accessibility/isolatedtree/AXIsolatedTree.cpp:
+(WebCore::AXIsolatedTree::updateChildren):
+
 2022-03-01  Alan Bujtas  
 
 REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox


Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp (290714 => 290715)

--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp	2022-03-02 01:53:20 UTC (rev 290714)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp	2022-03-02 02:03:52 UTC (rev 290715)
@@ -403,7 +403,7 @@
 collectNodeChangesForSubtree(*newChildren[i], axAncestor->objectID(), true, changes, &idsBeingChanged);
 }
 }
-m_nodeMap.set(axAncestor->objectID(), ParentChildrenIDs { oldIDs.parentID, newChildrenIDs });
+m_nodeMap.set(axAncestor->objectID(), ParentChildrenIDs { oldIDs.parentID, WTFMove(newChildrenIDs) });
 
 // What is left in oldChildrenIDs are the IDs that are no longer children of axAncestor.
 // Thus, remove them from m_nodeMap and queue them to be removed from the tree.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290714] trunk/Source/WebKit

2022-03-01 Thread jenner 
Title: [290714] trunk/Source/WebKit








Revision 290714
Author jen...@apple.com
Date 2022-03-01 17:53:20 -0800 (Tue, 01 Mar 2022)


Log Message
Unreviewed, reverting r290588.

Patch r290588 caused ASAN build to fail on macOS

Reverted changeset:

"IPC_TESTING_API MessageArgumentDescriptions.cpp is slow to
compile"
https://bugs.webkit.org/show_bug.cgi?id=237195
https://commits.webkit.org/r290588

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/JSIPCBinding.h
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290713 => 290714)

--- trunk/Source/WebKit/ChangeLog	2022-03-02 01:42:00 UTC (rev 290713)
+++ trunk/Source/WebKit/ChangeLog	2022-03-02 01:53:20 UTC (rev 290714)
@@ -1,3 +1,16 @@
+2022-03-01  Robert Jenner  
+
+Unreviewed, reverting r290588.
+
+Patch r290588 caused ASAN build to fail on macOS
+
+Reverted changeset:
+
+"IPC_TESTING_API MessageArgumentDescriptions.cpp is slow to
+compile"
+https://bugs.webkit.org/show_bug.cgi?id=237195
+https://commits.webkit.org/r290588
+
 2022-03-01  Alex Christensen  
 
 Fix clean build


Modified: trunk/Source/WebKit/Platform/IPC/JSIPCBinding.h (290713 => 290714)

--- trunk/Source/WebKit/Platform/IPC/JSIPCBinding.h	2022-03-02 01:42:00 UTC (rev 290713)
+++ trunk/Source/WebKit/Platform/IPC/JSIPCBinding.h	2022-03-02 01:53:20 UTC (rev 290714)
@@ -156,19 +156,6 @@
 return putJSValueForDecodeArgumentInArray<>(globalObject, decoder, array, 0, dummyArguments);
 }
 
-// The bindings implementation will call the function templates below to decode a message.
-// These function templates are specialized by each message in their own generated file.
-// Each implementation will just call the above `jsValueForDecodedArguments()` function.
-// This has the benefit that upon compilation, only the message receiver implementation files are
-// recompiled when the message argument types change.
-// The bindings implementation, e.g. the caller of jsValueForDecodedMessage<>, does not need
-// to know all the message argument types, and need to be recompiled only when the message itself
-// changes.
-template
-std::optional jsValueForDecodedMessage(JSC::JSGlobalObject*, IPC::Decoder&);
-template
-std::optional jsValueForDecodedMessageReply(JSC::JSGlobalObject*, IPC::Decoder&);
-
 }
 
 #endif


Modified: trunk/Source/WebKit/Scripts/webkit/messages.py (290713 => 290714)

--- trunk/Source/WebKit/Scripts/webkit/messages.py	2022-03-02 01:42:00 UTC (rev 290713)
+++ trunk/Source/WebKit/Scripts/webkit/messages.py	2022-03-02 01:53:20 UTC (rev 290714)
@@ -1070,10 +1070,6 @@
 result += generate_header_includes_from_conditions(header_conditions)
 result.append('\n')
 
-result.append('#if ENABLE(IPC_TESTING_API)\n')
-result.append('#include "JSIPCBinding.h"\n')
-result.append("#endif\n\n")
-
 delayed_or_async_messages = []
 for message in receiver.messages:
 if message.reply_parameters != None and (message.has_attribute(SYNCHRONOUS_ATTRIBUTE) or message.has_attribute(ASYNC_ATTRIBUTE)):
@@ -1195,33 +1191,6 @@
 
 result.append('\n} // namespace WebKit\n')
 
-result.append('\n')
-result.append('#if ENABLE(IPC_TESTING_API)\n\n')
-result.append('namespace IPC {\n\n')
-previous_message_condition = None
-for message in receiver.messages:
-if previous_message_condition != message.condition:
-if previous_message_condition:
-result.append('#endif\n')
-if message.condition:
-result.append('#if %s\n' % message.condition)
-previous_message_condition = message.condition
-result.append('template<> std::optional jsValueForDecodedMessage(JSC::JSGlobalObject* globalObject, Decoder& decoder)\n' % (receiver.name, message.name))
-result.append('{\n')
-result.append('return jsValueForDecodedArguments(globalObject, decoder);\n' % (receiver.name, message.name, 'Arguments'))
-result.append('}\n')
-has_reply = message.reply_parameters is not None and (message.has_attribute(SYNCHRONOUS_ATTRIBUTE) or message.has_attribute(ASYNC_ATTRIB

[webkit-changes] [290713] trunk/Source/WebKit

2022-03-01 Thread achristensen 
Title: [290713] trunk/Source/WebKit








Revision 290713
Author achristen...@apple.com
Date 2022-03-01 17:42:00 -0800 (Tue, 01 Mar 2022)


Log Message
Fix clean build

* UnifiedSources-output.xcfilelist:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UnifiedSources-output.xcfilelist




Diff

Modified: trunk/Source/WebKit/ChangeLog (290712 => 290713)

--- trunk/Source/WebKit/ChangeLog	2022-03-02 01:07:43 UTC (rev 290712)
+++ trunk/Source/WebKit/ChangeLog	2022-03-02 01:42:00 UTC (rev 290713)
@@ -1,3 +1,9 @@
+2022-03-01  Alex Christensen  
+
+Fix clean build
+
+* UnifiedSources-output.xcfilelist:
+
 2022-03-01  Wenson Hsieh  
 
 Clipboard Paste dialog doesn't show on external monitors


Modified: trunk/Source/WebKit/UnifiedSources-output.xcfilelist (290712 => 290713)

--- trunk/Source/WebKit/UnifiedSources-output.xcfilelist	2022-03-02 01:07:43 UTC (rev 290712)
+++ trunk/Source/WebKit/UnifiedSources-output.xcfilelist	2022-03-02 01:42:00 UTC (rev 290713)
@@ -28,8 +28,18 @@
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource12-mm.mm
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource12.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource120.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource121.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource122.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource123.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource124.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource125.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource126.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource127.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource128.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource129.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource13-mm.mm
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource13.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource130.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource14-mm.mm
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource14.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/unified-sources/UnifiedSource15-mm.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290712] trunk

2022-03-01 Thread wenson_hsieh 
Title: [290712] trunk








Revision 290712
Author wenson_hs...@apple.com
Date 2022-03-01 17:07:43 -0800 (Tue, 01 Mar 2022)


Log Message
Clipboard Paste dialog doesn't show on external monitors
https://bugs.webkit.org/show_bug.cgi?id=236395
rdar://88943577

Reviewed by Tim Horton.

Source/WebKit:

Fix the bug by aligning the way we generate synthetic mouse click NSEvents in WebKit2 macOS, when:

1. Showing the standard web content context menu
2. Showing the DOM paste menu
3. Showing the context menu for PDFs

Critically, this makes AppKit choose the correct NSScreen when presenting the popup menu when showing the DOM
paste menu, if the last mouse down event is `nil` upon presenting the menu.

Covered by adding a debug assertion to verify that we aren't trying to present popup menus from a `nil` event
during DOM paste.

* UIProcess/API/mac/WKWebViewTestingMac.mm:
(-[WKWebView _activeMenu]):
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::requestDOMPasteAccess):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showPDFContextMenu):
(WebKit::WebPageProxy::activeContextMenu const):

Renamed from `platformActiveContextMenu`. The "platform" prefix in front of this method was unnecessary, since
this is only invoked from macOS-only code that expects an NSMenu anyways.

(WebKit::WebPageProxy::createSyntheticEventForContextMenu const):

Add a helper method to create a synthetic NSEvent at the given location that's suitable for presenting a context
menu; use this new helper in the three places described above.

(WebKit::WebPageProxy::platformActiveContextMenu const): Deleted.

Tools:

Adjust the swizzled implementation of `-popUpContextMenu:withEvent:forView:` to additionally verify that the
NSEvent we're presenting the menu with isn't `nil`.

* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::swizzledPopUpContextMenu):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (290711 => 290712)

--- trunk/Source/WebKit/ChangeLog	2022-03-02 00:41:01 UTC (rev 290711)
+++ trunk/Source/WebKit/ChangeLog	2022-03-02 01:07:43 UTC (rev 290712)
@@ -1,3 +1,44 @@
+2022-03-01  Wenson Hsieh  
+
+Clipboard Paste dialog doesn't show on external monitors
+https://bugs.webkit.org/show_bug.cgi?id=236395
+rdar://88943577
+
+Reviewed by Tim Horton.
+
+Fix the bug by aligning the way we generate synthetic mouse click NSEvents in WebKit2 macOS, when:
+
+1. Showing the standard web content context menu
+2. Showing the DOM paste menu
+3. Showing the context menu for PDFs
+
+Critically, this makes AppKit choose the correct NSScreen when presenting the popup menu when showing the DOM
+paste menu, if the last mouse down event is `nil` upon presenting the menu.
+
+Covered by adding a debug assertion to verify that we aren't trying to present popup menus from a `nil` event
+during DOM paste.
+
+* UIProcess/API/mac/WKWebViewTestingMac.mm:
+(-[WKWebView _activeMenu]):
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::requestDOMPasteAccess):
+* UIProcess/WebPageProxy.h:
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
+* UIProcess/mac/WebPageProxyMac.mm:
+(WebKit::WebPageProxy::showPDFContextMenu):
+(WebKit::WebPageProxy::activeContextMenu const):
+
+Renamed from `platformActiveContextMenu`. The "platform" prefix in front of this method was unnecessary, since
+this is only invoked from macOS-only code that expects an NSMenu anyways.
+
+(WebKit::WebPageProxy::createSyntheticEventForContextMenu const):
+
+Add a helper method to create a synthetic NSEvent at the given location that's suitable for presenting a context
+menu; use this new helper in the three places described above.
+
+(WebKit::WebPageProxy::platformActiveContextMenu const): Deleted.
+
 2022-03-01  Michael Catanzaro  
 
 Misc compiler warnings, late Feb 2022 edition


Modified: trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm (290711 => 290712)

--- trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm	2022-03-02 00:41:01 UTC (rev 290711)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm	2022-03-02 01:07:43 UTC (rev 290712)
@@ -114,7 +114,7 @@
 
 - (NSMenu *)_activeMenu
 {
-if (NSMenu *contextMenu = _page->platformActiveContextMenu()

[webkit-changes] [290711] trunk/LayoutTests

2022-03-01 Thread jonlee 
Title: [290711] trunk/LayoutTests








Revision 290711
Author jon...@apple.com
Date 2022-03-01 16:41:01 -0800 (Tue, 01 Mar 2022)


Log Message
Unreviewed gardening.

* gpu-process/TestExpectations: r290542 fixed a number of crashing tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290710 => 290711)

--- trunk/LayoutTests/ChangeLog	2022-03-02 00:29:04 UTC (rev 290710)
+++ trunk/LayoutTests/ChangeLog	2022-03-02 00:41:01 UTC (rev 290711)
@@ -2,6 +2,12 @@
 
 Unreviewed gardening.
 
+* gpu-process/TestExpectations: r290542 fixed a number of crashing tests.
+
+2022-03-01  Jon Lee  
+
+Unreviewed gardening.
+
 * gpu-process/TestExpectations:
 * platform/ios/TestExpectations: r290438 fixed a test failure.
 


Modified: trunk/LayoutTests/gpu-process/TestExpectations (290710 => 290711)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-03-02 00:29:04 UTC (rev 290710)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-03-02 00:41:01 UTC (rev 290711)
@@ -341,15 +341,6 @@
 webkit.org/b/236930 accessibility/ios-simulator/aria-details.html [ Crash Pass ]
 webkit.org/b/236930 ddcss3/images/cross-fade-simple.html [ Crash Pass ]
 webkit.org/b/236794 editing/spelling/editing-word-with-marker-2.html [ Crash Pass ]
-webkit.org/b/236930 fast/backgrounds/background-fast-path-simple-color.html [ Crash Pass ]
-webkit.org/b/236930 fast/backgrounds/background-clip-text-on-body.html [ Crash Pass ]
-webkit.org/b/236930 fast/backgrounds/background-clip-text-with-simple-container.html [ Crash Pass ]
-webkit.org/b/236930 fast/backgrounds/background-clip-text.html [ Crash Pass ]
-webkit.org/b/236930 fast/clip/clip-hit-null-iterator-path-comparison.html [ Crash Pass ]
-webkit.org/b/236930 fast/clip/clip-when-rect-has-fractional-pixel-value.html [ Crash ImageOnlyFailure ]
-webkit.org/b/236930 fast/css/clip-text-in-scaled-div.html [ Crash Pass ]
-webkit.org/b/236930 fast/css/clip-zooming.html [ Crash Pass ]
-webkit.org/b/236930 fast/hidpi/clip-text-in-hidpi.html [ Crash Pass ]
 webkit.org/b/236930 fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Crash Pass ]
 webkit.org/b/236930 imported/blink/fast/backgrounds/bug420029.html [ Crash Pass ]
 webkit.org/b/236930 imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-popup-behavior.html [ Crash Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290710] trunk/LayoutTests

2022-03-01 Thread jonlee 
Title: [290710] trunk/LayoutTests








Revision 290710
Author jon...@apple.com
Date 2022-03-01 16:29:04 -0800 (Tue, 01 Mar 2022)


Log Message
Unreviewed gardening.

* gpu-process/TestExpectations:
* platform/ios/TestExpectations: r290438 fixed a test failure.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290709 => 290710)

--- trunk/LayoutTests/ChangeLog	2022-03-02 00:27:15 UTC (rev 290709)
+++ trunk/LayoutTests/ChangeLog	2022-03-02 00:29:04 UTC (rev 290710)
@@ -2,6 +2,13 @@
 
 Unreviewed gardening.
 
+* gpu-process/TestExpectations:
+* platform/ios/TestExpectations: r290438 fixed a test failure.
+
+2022-03-01  Jon Lee  
+
+Unreviewed gardening.
+
 * gpu-process/TestExpectations: r290542 fixed a number of crashing tests.
 
 2022-03-01  Alan Bujtas  


Modified: trunk/LayoutTests/gpu-process/TestExpectations (290709 => 290710)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-03-02 00:27:15 UTC (rev 290709)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-03-02 00:29:04 UTC (rev 290710)
@@ -298,11 +298,11 @@
 webkit.org/b/236925 fast/css/getComputedStyle/computed-style-apple-pay-button.html [ Crash Pass ]
 
 # Media failures
-webkit.org/b/236926 fast/mediastream/video-rotation-gpu-process-crash.html [ Timeout ]
 webkit.org/b/236926 imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html [ Pass Failure ]
 webkit.org/b/236926 media/video-src-blob-using-open-panel.html [ Timeout Pass ]
 webkit.org/b/236926 webrtc/canvas-to-peer-connection.html [ Failure ]
 # arm64 only
+webkit.org/b/237295 fast/mediastream/video-rotation-gpu-process-crash.html [ Crash Pass ]
 webkit.org/b/236926 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html [ Failure Pass ]
 webkit.org/b/236926 imported/w3c/web-platform-tests/webrtc/protocol/ice-state.https.html [ Timeout Pass ]
 webkit.org/b/236926 media/video-src-blob-replay.html [ Timeout Pass ]


Modified: trunk/LayoutTests/platform/ios/TestExpectations (290709 => 290710)

--- trunk/LayoutTests/platform/ios/TestExpectations	2022-03-02 00:27:15 UTC (rev 290709)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-03-02 00:29:04 UTC (rev 290710)
@@ -2171,7 +2171,6 @@
 imported/blink/fast/pagination/viewport-x-vertical-lr-ltr.html [ ImageOnlyFailure ]
 imported/blink/fast/pagination/viewport-x-vertical-lr-rtl.html [ ImageOnlyFailure ]
 fast/multicol/newmulticol/hide-box-vertical-lr.html [ ImageOnlyFailure ]
-fast/writing-mode/vertical-align-flexbox-baseline.html [ ImageOnlyFailure ]
 
 # Failing tests related to picture element
 webkit.org/b/152141 fast/picture/image-picture-1x.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290709] branches/safari-613-branch/Source/WTF/Scripts/Preferences/ WebPreferences.yaml

2022-03-01 Thread alancoon 
Title: [290709] branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml








Revision 290709
Author alanc...@apple.com
Date 2022-03-01 16:27:15 -0800 (Tue, 01 Mar 2022)


Log Message
Apply patch. rdar://problem/89126114

Modified Paths

branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml




Diff

Modified: branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml (290708 => 290709)

--- branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2022-03-02 00:27:11 UTC (rev 290708)
+++ branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2022-03-02 00:27:15 UTC (rev 290709)
@@ -1606,11 +1606,11 @@
   condition: ENABLE(NOTIFICATIONS)
   defaultValue:
 WebKitLegacy:
-  default: false
+  default: true
 WebKit:
-  default: false
+  default: true
 WebCore:
-  default: false
+  default: true
 
 OfflineWebApplicationCacheEnabled:
   type: bool






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290708] branches/safari-613-branch

2022-03-01 Thread alancoon 
Title: [290708] branches/safari-613-branch








Revision 290708
Author alanc...@apple.com
Date 2022-03-01 16:27:11 -0800 (Tue, 01 Mar 2022)


Log Message
Revert r289282. rdar://problem/88876661

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/resources/ui-helper.js
branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/Platform/spi/ios/UIKitSPI.h
branches/safari-613-branch/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
branches/safari-613-branch/Source/WebKit/UIProcess/WebPageProxy.h
branches/safari-613-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
branches/safari-613-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
branches/safari-613-branch/Tools/ChangeLog
branches/safari-613-branch/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
branches/safari-613-branch/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
branches/safari-613-branch/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
branches/safari-613-branch/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h
branches/safari-613-branch/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm


Removed Paths

branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled-expected.txt
branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (290707 => 290708)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-02 00:20:55 UTC (rev 290707)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-02 00:27:11 UTC (rev 290708)
@@ -1,5 +1,9 @@
 2022-03-01  Russell Epstein  
 
+Revert r289282. rdar://problem/88876661
+
+2022-03-01  Russell Epstein  
+
 Cherry-pick r290087. rdar://problem/88713302
 
 Source/ThirdParty/ANGLE:


Deleted: branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled-expected.txt (290707 => 290708)

--- branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled-expected.txt	2022-03-02 00:20:55 UTC (rev 290707)
+++ branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled-expected.txt	2022-03-02 00:27:11 UTC (rev 290708)
@@ -1,10 +0,0 @@
-This test verifies that focusing an editable element causes us to scroll to reveal the selection, even if first responder keyboard avoidance is disabled on the web view's scroller. This test requires WebKitTestRunner.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS document.scrollingElement.scrollTop became different from 0
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled.html (290707 => 290708)

--- branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled.html	2022-03-02 00:20:55 UTC (rev 290707)
+++ branches/safari-613-branch/LayoutTests/editing/selection/ios/scroll-to-reveal-selection-with-keyboard-avoidance-disabled.html	2022-03-02 00:27:11 UTC (rev 290708)
@@ -1,34 +0,0 @@
- 
-
-
-
-
-jsTestIsAsync = true;
-
-addEventListener("load", async () => {
-document.designMode = "on";
-description("This test verifies that focusing an editable element causes us to scroll to reveal the selection, even if first responder keyboard avoidance is disabled on the web view's scroller. This test requires WebKitTestRunner.");
-
-await UIHelper.setScrollViewKeyboardAvoidanceEnabled(false);
-await UIHelper.setHardwareKeyboardAttached(false);
-await UIHelper.activateAndWaitForInputSessionAt(160, innerHeight - 50);
-
-shouldBecomeDifferent("document.scrollingElement.scrollTop", "0", () => {
-document.getElementById("content").remove();
-finishJSTest();
-});
-});
-
-
-
-
-
-Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita ka

[webkit-changes] [290707] trunk/LayoutTests

2022-03-01 Thread jonlee 
Title: [290707] trunk/LayoutTests








Revision 290707
Author jon...@apple.com
Date 2022-03-01 16:20:55 -0800 (Tue, 01 Mar 2022)


Log Message
Unreviewed gardening.

* gpu-process/TestExpectations: r290542 fixed a number of crashing tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290706 => 290707)

--- trunk/LayoutTests/ChangeLog	2022-03-01 23:59:50 UTC (rev 290706)
+++ trunk/LayoutTests/ChangeLog	2022-03-02 00:20:55 UTC (rev 290707)
@@ -1,3 +1,9 @@
+2022-03-01  Jon Lee  
+
+Unreviewed gardening.
+
+* gpu-process/TestExpectations: r290542 fixed a number of crashing tests.
+
 2022-03-01  Alan Bujtas  
 
 REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox


Modified: trunk/LayoutTests/gpu-process/TestExpectations (290706 => 290707)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-03-01 23:59:50 UTC (rev 290706)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-03-02 00:20:55 UTC (rev 290707)
@@ -292,7 +292,6 @@
 webkit.org/b/236924 svg/transforms/transformed-text-fill-pattern.html [ ImageOnlyFailure ]
 
 # Apple Pay button
-webkit.org/b/236925 fast/css/appearance-apple-pay-button-border-radius.html [ Crash ]
 webkit.org/b/236925 fast/css/appearance-apple-pay-button-default-corners.html [ Crash ]
 webkit.org/b/236925 fast/css/appearance-apple-pay-button.html [ Crash ]
 # x64_64 only
@@ -315,16 +314,7 @@
 webkit.org/b/236927 fast/forms/input-text-autofocus.html [ Pass Failure ]
 
 # Crashes
-webkit.org/b/236929 compositing/background-color/background-color-text-clip.html [ Crash ]
 webkit.org/b/236929 fast/canvas/canvas-composite-canvas.html [ Crash ]
-webkit.org/b/236929 fast/clip/hidpi-background-clip-with-text-fill-color.html [ Crash ]
-webkit.org/b/236929 fast/css/cascade/background-clip-and-webkit-background-clip-cascade-order.html [ Crash ]
-webkit.org/b/236929 fast/inline/inline-background-clip-text-multiline.html [ Crash ]
-webkit.org/b/236929 fast/inline/inline-background-clip-text.html [ Crash ]
-webkit.org/b/236929 fast/text/text-decoration-currentcolor-fill-color.html [ Crash ]
-# arm64 only
-webkit.org/b/236929 fast/css/getComputedStyle/computed-style-border-image.html [ Crash Pass ]
-webkit.org/b/236929 fast/hidpi/device-scale-factor-paint.html [ Crash Pass ]
 
 # Flaky timeout
 webkit.org/b/236931 imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-main-frame-window.html [ Timeout Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290706] trunk

2022-03-01 Thread zalan 
Title: [290706] trunk








Revision 290706
Author za...@apple.com
Date 2022-03-01 15:59:50 -0800 (Tue, 01 Mar 2022)


Log Message
REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox
https://bugs.webkit.org/show_bug.cgi?id=237276


Reviewed by Simon Fraser.

Source/WebCore:

r285232 introduced the isFixed() check as a resolvable preferred width type, but percent values are also resolvable as
block layout gets the horizontal constraint from the containing block chain (unlike the height percent values) -i.e. 'width: 50%' can be resolved during preferred width computation.

Test: fast/css-grid-layout/ascpect-ratio-with-percent-width.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):

LayoutTests:

* fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html: Added.
* fast/css-grid-layout/ascpect-ratio-with-percent-width.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html
trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290705 => 290706)

--- trunk/LayoutTests/ChangeLog	2022-03-01 23:51:26 UTC (rev 290705)
+++ trunk/LayoutTests/ChangeLog	2022-03-01 23:59:50 UTC (rev 290706)
@@ -1,3 +1,14 @@
+2022-03-01  Alan Bujtas  
+
+REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox
+https://bugs.webkit.org/show_bug.cgi?id=237276
+
+
+Reviewed by Simon Fraser.
+
+* fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html: Added.
+* fast/css-grid-layout/ascpect-ratio-with-percent-width.html: Added.
+
 2022-03-01  Said Abou-Hallawa  
 
 [macOS][REGRESSION] (rr289518): Form controls are scaled twice on Retina display


Added: trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html (0 => 290706)

--- trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html	2022-03-01 23:59:50 UTC (rev 290706)
@@ -0,0 +1,17 @@
+
+div {
+  display: grid;
+  place-items: center;
+
+  width: 200px;
+  height: 200px;
+
+  border: solid;
+  background-color: cyan;
+  
+  font-family: Ahem;
+  font-size: 20px;
+}
+
+
+centered
\ No newline at end of file


Added: trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width.html (0 => 290706)

--- trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/ascpect-ratio-with-percent-width.html	2022-03-01 23:59:50 UTC (rev 290706)
@@ -0,0 +1,21 @@
+
+.container {
+  width: 200px;
+  border: solid;
+}
+
+.grid {
+  display: grid;
+  place-items: center;
+
+  width: 100%;
+  aspect-ratio: 1;
+
+  background-color: cyan;
+  
+  font-family: Ahem;
+  font-size: 20px;
+}
+
+
+centered
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (290705 => 290706)

--- trunk/Source/WebCore/ChangeLog	2022-03-01 23:51:26 UTC (rev 290705)
+++ trunk/Source/WebCore/ChangeLog	2022-03-01 23:59:50 UTC (rev 290706)
@@ -1,3 +1,19 @@
+2022-03-01  Alan Bujtas  
+
+REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox
+https://bugs.webkit.org/show_bug.cgi?id=237276
+
+
+Reviewed by Simon Fraser.
+
+r285232 introduced the isFixed() check as a resolvable preferred width type, but percent values are also resolvable as
+block layout gets the horizontal constraint from the containing block chain (unlike the height percent values) -i.e. 'width: 50%' can be resolved during preferred width computation.
+
+Test: fast/css-grid-layout/ascpect-ratio-with-percent-width.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):
+
 2022-03-01  Michael Catanzaro  
 
 Misc compiler warnings, late Feb 2022 edition


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (290705 => 290706)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2022-03-01 23:51:26 UTC (rev 290705)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2022-03-01 23:59:50 UTC (rev 290706)
@@ -3184,7 +3184,7 @@
 availableHeight = std::max(0_lu, constrainContentBoxLogicalHeightByMinMax(contentBoxHeight - scrollbarLogicalHeight(), std::nullopt));
 } else if (shouldComputeLogicalHeightFromAspectRatio()) {
 // Only grid is expected to be in a state where it is calculating pref width and having unknown logical width.
-if (isRenderGrid

[webkit-changes] [290705] trunk

2022-03-01 Thread Hironori . Fujii 
Title: [290705] trunk








Revision 290705
Author hironori.fu...@sony.com
Date 2022-03-01 15:51:26 -0800 (Tue, 01 Mar 2022)


Log Message
WTF::SentinelLinkedList::iterator should have operator++ for range-for loop
https://bugs.webkit.org/show_bug.cgi?id=237265

Reviewed by Yusuke Suzuki.

Source/_javascript_Core:

SentinelLinkedList::iterator isn't a pointer of node now, it
should be deferenced before comparing with a pointer.

* bytecode/Watchpoint.cpp:
(JSC::WatchpointSet::fireAllWatchpoints):
* heap/HandleSet.cpp:
(JSC::HandleSet::visitStrongHandles):
(JSC::HandleSet::protectedGlobalObjectCount):
* heap/HandleSet.h:
(JSC::HandleSet::forEachStrongHandle):
* heap/IsoSubspace.cpp:
(JSC::IsoSubspace::tryAllocateFromLowerTier):
* heap/SubspaceInlines.h:
(JSC::Subspace::forEachPreciseAllocation):
* jsc.cpp:
(Workers::broadcast):

Source/WTF:

SentinelLinkedList had three problems.
1. Even though it has begin() and end(), using SentinelLinkedList
   with range-for loop resulted in a broken node because
   iterator::operator++ didn't work as expected.
2. If I used a SentinelLinkedList in a movable type, the sentinel
   pointer gets stale after moving the object. move-ctor should be deleted.
3. It didn't have const_iterator.

* wtf/OrderMaker.h:
(WTF::OrderMaker::iterator::iterator):
(WTF::OrderMaker::iterator::operator*):
(WTF::OrderMaker::iterator::operator++):
(WTF::OrderMaker::iterator::operator== const):
* wtf/SentinelLinkedList.h:
(WTF::BasicRawSentinelNode::prev const):
(WTF::BasicRawSentinelNode::next const):
(WTF::SentinelLinkedList::BaseIterator::BaseIterator):
(WTF::SentinelLinkedList::BaseIterator::operator* const):
(WTF::SentinelLinkedList::BaseIterator::operator-> const):
(WTF::SentinelLinkedList::BaseIterator::operator++):
(WTF::SentinelLinkedList::BaseIterator::operator--):
(WTF::SentinelLinkedList::BaseIterator::operator== const):
(WTF::SentinelLinkedList::BaseIterator::operator!= const):
(WTF::SentinelLinkedList::forEach):
(WTF::RawNode>::begin):
(WTF::RawNode>::end):
(WTF::RawNode>::begin const):
(WTF::RawNode>::end const):
(WTF::BasicRawSentinelNode::prev): Deleted.
(WTF::BasicRawSentinelNode::next): Deleted.

Tools:

* TestWebKitAPI/Tests/WTF/SentinelLinkedList.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Watchpoint.cpp
trunk/Source/_javascript_Core/heap/HandleSet.cpp
trunk/Source/_javascript_Core/heap/HandleSet.h
trunk/Source/_javascript_Core/heap/IsoSubspace.cpp
trunk/Source/_javascript_Core/heap/SubspaceInlines.h
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/OrderMaker.h
trunk/Source/WTF/wtf/SentinelLinkedList.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/SentinelLinkedList.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (290704 => 290705)

--- trunk/Source/_javascript_Core/ChangeLog	2022-03-01 23:50:13 UTC (rev 290704)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-01 23:51:26 UTC (rev 290705)
@@ -1,3 +1,27 @@
+2022-03-01  Fujii Hironori  
+
+WTF::SentinelLinkedList::iterator should have operator++ for range-for loop
+https://bugs.webkit.org/show_bug.cgi?id=237265
+
+Reviewed by Yusuke Suzuki.
+
+SentinelLinkedList::iterator isn't a pointer of node now, it
+should be deferenced before comparing with a pointer.
+
+* bytecode/Watchpoint.cpp:
+(JSC::WatchpointSet::fireAllWatchpoints):
+* heap/HandleSet.cpp:
+(JSC::HandleSet::visitStrongHandles):
+(JSC::HandleSet::protectedGlobalObjectCount):
+* heap/HandleSet.h:
+(JSC::HandleSet::forEachStrongHandle):
+* heap/IsoSubspace.cpp:
+(JSC::IsoSubspace::tryAllocateFromLowerTier):
+* heap/SubspaceInlines.h:
+(JSC::Subspace::forEachPreciseAllocation):
+* jsc.cpp:
+(Workers::broadcast):
+
 2022-03-01  Michael Catanzaro  
 
 Misc compiler warnings, late Feb 2022 edition


Modified: trunk/Source/_javascript_Core/bytecode/Watchpoint.cpp (290704 => 290705)

--- trunk/Source/_javascript_Core/bytecode/Watchpoint.cpp	2022-03-01 23:50:13 UTC (rev 290704)
+++ trunk/Source/_javascript_Core/bytecode/Watchpoint.cpp	2022-03-01 23:51:26 UTC (rev 290705)
@@ -138,8 +138,8 @@
 DeferGCForAWhile deferGC(vm);
 
 while (!m_set.isEmpty()) {
-Watchpoint* watchpoint = m_set.begin();
-ASSERT(watchpoint->isOnList());
+Watchpoint& watchpoint = *m_set.begin();
+ASSERT(watchpoint.isOnList());
 
 // Removing the Watchpoint before firing it makes it possible to implement watchpoints
 // that add themselves to a different set when they fire. This kind of "adaptive"
@@ -150,11 +150,11 @@
 // So, before the watchpoint decides to invalidate any code, it can check if it is
 // possible to add itself to the transition watchpoint set of the singleton object's new
 // Structure.
-watchpoi

[webkit-changes] [290704] branches/safari-613-branch

2022-03-01 Thread alancoon 
Title: [290704] branches/safari-613-branch








Revision 290704
Author alanc...@apple.com
Date 2022-03-01 15:50:13 -0800 (Tue, 01 Mar 2022)


Log Message
Cherry-pick r290087. rdar://problem/88713302

Source/ThirdParty/ANGLE:
Metal ANGLE: vertex array does not correctly observe contents of data buffers
https://bugs.webkit.org/show_bug.cgi?id=236733



Patch by Kyle Piddington  on 2022-02-17
Reviewed by Dean Jackson.

Similar to previous bug (236427), we were not correctly observing changes to the
vertex buffer data. This caused us to miss rebinding vertex buffers
when data was updated without causing conversion

* src/libANGLE/renderer/metal/VertexArrayMtl.h:
* src/libANGLE/renderer/metal/VertexArrayMtl.mm:
(rx::VertexArrayMtl::syncState):
(rx::VertexArrayMtl::setupDraw):
(rx::VertexArrayMtl::syncDirtyAttrib):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-613-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.h
branches/safari-613-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm


Added Paths

branches/safari-613-branch/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt
branches/safari-613-branch/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (290703 => 290704)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-01 23:50:08 UTC (rev 290703)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-01 23:50:13 UTC (rev 290704)
@@ -1,30 +1,71 @@
 2022-03-01  Russell Epstein  
 
-Cherry-pick r290512. rdar://problem/86582214
+Cherry-pick r290087. rdar://problem/88713302
 
-[Tables] Incorrect table sizing when colgroup comes after tbody
-https://bugs.webkit.org/show_bug.cgi?id=237205
-
+Source/ThirdParty/ANGLE:
+Metal ANGLE: vertex array does not correctly observe contents of data buffers
+https://bugs.webkit.org/show_bug.cgi?id=236733
+
+
 
-Reviewed by Antti Koivisto.
+Patch by Kyle Piddington  on 2022-02-17
+Reviewed by Dean Jackson.
 
-Source/WebCore:
+Similar to previous bug (236427), we were not correctly observing changes to the
+vertex buffer data. This caused us to miss rebinding vertex buffers
+when data was updated without causing conversion
 
-Let's use the colgroup for table sizing even when it comes after any thead, tbody, tfoot, and tr elements.
-This makes WebKit match other rendering engines (see https://src.chromium.org/viewvc/blink?revision=159442&view=revision)
+* src/libANGLE/renderer/metal/VertexArrayMtl.h:
+* src/libANGLE/renderer/metal/VertexArrayMtl.mm:
+(rx::VertexArrayMtl::syncState):
+(rx::VertexArrayMtl::setupDraw):
+(rx::VertexArrayMtl::syncDirtyAttrib):
 
-Test: fast/table/table-sizing-fails-when-colgroup-comes-after-content.html
-
-* rendering/RenderTable.cpp:
-(WebCore::RenderTable::firstColumn const):
-* rendering/RenderTableCol.cpp:
-(WebCore::RenderTableCol::nextColumn const):
-
-LayoutTests:
-
-* fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html: Added.
-* fast/table/table-sizing-fails-when-colgroup-comes-after-content.html: Added.
-* platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt: Progression.
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-01  Russell Epstein  
+
+Cherry-pick r290512. rdar://problem/86582214
+
+[Tables] Incorrect table sizing when colgroup comes after tbody
+https://bugs.webkit.org/show_bug.cgi?id=237205
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+Let's use the colgroup for table sizing even when it comes after any thead, tbody, tfoot, and tr elements.
+This makes WebKit match other rendering engines (see https://src.chromium.org/viewvc/blink?revision=159442&view=revision)
+
+Test: fast/table/table-sizing-fails-when-colgroup-comes-after-content.html
+
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::firstColumn const):
+* rendering/RenderTableCol.cpp:
+(WebCore::RenderTableCol::nextColumn const):
+
+LayoutTests:
+
+* fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html: Added.
+* fast/table/table-sizing-fails-when-colgroup-comes-after-content.html: Added.
+* platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt: Progression.
+2022-02-17  Kyle Piddington  
+
+Metal ANGLE: vertex array does not correctly observe content

[webkit-changes] [290702] branches/safari-613-branch

2022-03-01 Thread alancoon 
Title: [290702] branches/safari-613-branch








Revision 290702
Author alanc...@apple.com
Date 2022-03-01 15:50:06 -0800 (Tue, 01 Mar 2022)


Log Message
Apply patch. rdar://problem/89009881

Modified Paths

branches/safari-613-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp
branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/OriginStorageManager.h
branches/safari-613-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/SessionStorage.mm




Diff

Modified: branches/safari-613-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp (290701 => 290702)

--- branches/safari-613-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2022-03-01 23:50:02 UTC (rev 290701)
+++ branches/safari-613-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2022-03-01 23:50:06 UTC (rev 290702)
@@ -2309,7 +2309,7 @@
 
 auto* session = networkSession(sessionID);
 if (auto* manager = session ? session->storageManager() : nullptr)
-manager->moveData(oldOrigin, newOrigin, [aggregator] { });
+manager->moveData(dataTypes, oldOrigin, newOrigin, [aggregator] { });
 
 if (dataTypes.contains(WebsiteDataType::IndexedDBDatabases) && session && session->hasIDBDatabasePath())
 session->ensureWebIDBServer().renameOrigin(oldOrigin, newOrigin, [aggregator] { });


Modified: branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp (290701 => 290702)

--- branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp	2022-03-01 23:50:02 UTC (rev 290701)
+++ branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp	2022-03-01 23:50:06 UTC (rev 290702)
@@ -566,22 +566,25 @@
 });
 }
 
-void NetworkStorageManager::moveData(const WebCore::SecurityOriginData& source, const WebCore::SecurityOriginData& target, CompletionHandler&& completionHandler)
+void NetworkStorageManager::moveData(OptionSet types, const WebCore::SecurityOriginData& source, const WebCore::SecurityOriginData& target, CompletionHandler&& completionHandler)
 {
 ASSERT(RunLoop::isMain());
 ASSERT(!m_closed);
 
-m_queue->dispatch([this, protectedThis = Ref { *this }, source = crossThreadCopy(source), target = crossThreadCopy(target), completionHandler = WTFMove(completionHandler)]() mutable {
+m_queue->dispatch([this, protectedThis = Ref { *this }, types, source = crossThreadCopy(source), target = crossThreadCopy(target), completionHandler = WTFMove(completionHandler)]() mutable {
+if (!types.contains(WebsiteDataType::LocalStorage))
+return RunLoop::main().dispatch(WTFMove(completionHandler));
+
 auto sourceOrigin = WebCore::ClientOrigin { source, source };
 auto targetOrigin = WebCore::ClientOrigin { target, target };
-
+
 // Clear existing data of target origin.
-OptionSet types = { WebsiteDataType::FileSystem, WebsiteDataType::LocalStorage, WebsiteDataType::SessionStorage  };
-localOriginStorageManager(targetOrigin).deleteData(types, -WallTime::infinity());
+OptionSet localStorageType = { WebsiteDataType::LocalStorage };
+localOriginStorageManager(targetOrigin).deleteData(localStorageType, -WallTime::infinity());
 removeOriginStorageManagerIfPossible(targetOrigin);
 
 // Move data from source origin to target origin.
-localOriginStorageManager(sourceOrigin).moveData(originDirectoryPath(m_path, targetOrigin, m_salt), LocalStorageManager::localStorageFilePath(m_customLocalStoragePath, targetOrigin));
+localOriginStorageManager(sourceOrigin).moveData(localStorageType, originDirectoryPath(m_path, targetOrigin, m_salt), LocalStorageManager::localStorageFilePath(m_customLocalStoragePath, targetOrigin));
 removeOriginStorageManagerIfPossible(sourceOrigin);
 
 RunLoop::main().dispatch(WTFMove(completionHandler));


Modified: branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h (290701 => 290702)

--- branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h	2022-03-01 23:50:02 UTC (rev 290701)
+++ branches/safari-613-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h	2022-03-01 23:50:06 UTC (rev 290702)
@@ -66,7 +66,7 @@
 void deleteData(OptionSet, const Vector&, CompletionHandler&&);
 void deleteDataModifiedSince(OptionSet, WallTime, CompletionHandler&&);
 void deleteDataForRegistrableDomains(OptionSet, const Vector&, CompletionHandler&&)>&&);
-void moveData(const WebCore::SecurityOriginData& source, const WebCore::SecurityOriginData& target, CompletionHandler&&);
+void moveData(OptionSet, const WebCore::SecurityOriginData& source,

[webkit-changes] [290700] branches/safari-613-branch

2022-03-01 Thread alancoon 
Title: [290700] branches/safari-613-branch








Revision 290700
Author alanc...@apple.com
Date 2022-03-01 15:49:57 -0800 (Tue, 01 Mar 2022)


Log Message
Cherry-pick r290156. rdar://problem/89154452

ServiceWorkerGlobalScope+PushAPI requires PushAPIEnabled
https://bugs.webkit.org/show_bug.cgi?id=236846

Patch by Sam Sneddon  on 2022-02-18
Reviewed by Chris Dumez.

Source/WebCore:

Tests: http/wpt/push-api/onpush-disabled.html
   http/wpt/push-api/onpush-enabled.html

* Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:

LayoutTests:

* http/wpt/push-api/onpush-disabled-expected.txt: Added.
* http/wpt/push-api/onpush-disabled.html: Added.
* http/wpt/push-api/onpush-disabled.js: Added.
(test):
* http/wpt/push-api/onpush-enabled-expected.txt: Added.
* http/wpt/push-api/onpush-enabled.html: Added.
* http/wpt/push-api/onpush-enabled.js: Added.
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl


Added Paths

branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled-expected.txt
branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled.html
branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled.js
branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-enabled-expected.txt
branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-enabled.html
branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-enabled.js




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (290699 => 290700)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-01 23:49:52 UTC (rev 290699)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-01 23:49:57 UTC (rev 290700)
@@ -1,5 +1,51 @@
 2022-03-01  Russell Epstein  
 
+Cherry-pick r290156. rdar://problem/89154452
+
+ServiceWorkerGlobalScope+PushAPI requires PushAPIEnabled
+https://bugs.webkit.org/show_bug.cgi?id=236846
+
+Patch by Sam Sneddon  on 2022-02-18
+Reviewed by Chris Dumez.
+
+Source/WebCore:
+
+Tests: http/wpt/push-api/onpush-disabled.html
+   http/wpt/push-api/onpush-enabled.html
+
+* Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:
+
+LayoutTests:
+
+* http/wpt/push-api/onpush-disabled-expected.txt: Added.
+* http/wpt/push-api/onpush-disabled.html: Added.
+* http/wpt/push-api/onpush-disabled.js: Added.
+(test):
+* http/wpt/push-api/onpush-enabled-expected.txt: Added.
+* http/wpt/push-api/onpush-enabled.html: Added.
+* http/wpt/push-api/onpush-enabled.js: Added.
+(test):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-18  Sam Sneddon  
+
+ServiceWorkerGlobalScope+PushAPI requires PushAPIEnabled
+https://bugs.webkit.org/show_bug.cgi?id=236846
+
+Reviewed by Chris Dumez.
+
+* http/wpt/push-api/onpush-disabled-expected.txt: Added.
+* http/wpt/push-api/onpush-disabled.html: Added.
+* http/wpt/push-api/onpush-disabled.js: Added.
+(test):
+* http/wpt/push-api/onpush-enabled-expected.txt: Added.
+* http/wpt/push-api/onpush-enabled.html: Added.
+* http/wpt/push-api/onpush-enabled.js: Added.
+(test):
+
+2022-03-01  Russell Epstein  
+
 Cherry-pick r289995. rdar://problem/87462825
 
 REGRESSION(r285885) Unable to exit Trip Details in Amtrak app


Added: branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled-expected.txt (0 => 290700)

--- branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled-expected.txt	(rev 0)
+++ branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled-expected.txt	2022-03-01 23:49:57 UTC (rev 290700)
@@ -0,0 +1,4 @@
+
+PASS onpush should not be exposed on ServiceWorkerGlobalScope
+PASS onpushsubscriptionchange should not be exposed on ServiceWorkerGlobalScope
+


Added: branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled.html (0 => 290700)

--- branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled.html	(rev 0)
+++ branches/safari-613-branch/LayoutTests/http/wpt/push-api/onpush-disabled.html	2022-03-01 23:49:57 UTC (rev 290700)
@@ -0,0 +1,16 @@
+
+
+
+
+