[webkit-changes] [292024] trunk/Source/WebKit
Title: [292024] trunk/Source/WebKit Revision 292024 Author sihui_...@apple.com Date 2022-03-28 22:54:56 -0700 (Mon, 28 Mar 2022) Log Message Add logging about process entering background to NetworkProcess::processDidResume https://bugs.webkit.org/show_bug.cgi?id=238082 Reviewed by Chris Dumez. In rdar://82412733, we found network process can be suspended right after it receives processDidResume message. For network process, processDidResume means process is not suspended and it is safe to perform database operations. Let's add logging to check when and why processDidResume message is sent. If the logging confirms that processDidResume message can be received when process is close to assertion timeout, we probably want to ignore such message and resume database operations when application actually enters foreground. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::prepareToSuspend): (WebKit::NetworkProcess::applicationDidEnterBackground): (WebKit::NetworkProcess::applicationWillEnterForeground): (WebKit::NetworkProcess::processDidResume): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * NetworkProcess/ios/NetworkProcessIOS.mm: * UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _processDidResumeForTesting]): * UIProcess/Cocoa/DownloadProxyMapCocoa.mm: (WebKit::DownloadProxyMap::platformCreate): (WebKit::DownloadProxyMap::platformDestroy): * UIProcess/Downloads/DownloadProxyMap.cpp: (WebKit::DownloadProxyMap::applicationDidEnterBackground): Deleted. (WebKit::DownloadProxyMap::applicationWillEnterForeground): Deleted. * UIProcess/Downloads/DownloadProxyMap.h: (WebKit::DownloadProxyMap::isEmpty const): * UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::sendProcessDidResume): * UIProcess/GPU/GPUProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::NetworkProcessProxy): (WebKit::NetworkProcessProxy::~NetworkProcessProxy): (WebKit::NetworkProcessProxy::synthesizeAppIsBackground): (WebKit::NetworkProcessProxy::sendProcessDidResume): (WebKit::NetworkProcessProxy::applicationDidEnterBackground): (WebKit::NetworkProcessProxy::applicationWillEnterForeground): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxyCocoa.mm: (WebKit::NetworkProcessProxy::addBackgroundStateObservers): (WebKit::NetworkProcessProxy::removeBackgroundStateObservers): * UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::updateAssertionIfNeeded): * UIProcess/ProcessThrottlerClient.h: * UIProcess/WebAuthentication/WebAuthnProcessProxy.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::sendProcessDidResume): * UIProcess/WebProcessProxy.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::sendNetworkProcessDidResume): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm trunk/Source/WebKit/UIProcess/Cocoa/DownloadProxyMapCocoa.mm trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxyCocoa.mm trunk/Source/WebKit/UIProcess/ProcessThrottler.cpp trunk/Source/WebKit/UIProcess/ProcessThrottlerClient.h trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.h trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit/UIProcess/WebProcessProxy.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (292023 => 292024) --- trunk/Source/WebKit/ChangeLog 2022-03-29 04:33:07 UTC (rev 292023) +++ trunk/Source/WebKit/ChangeLog 2022-03-29 05:54:56 UTC (rev 292024) @@ -1,5 +1,61 @@ 2022-03-28 Sihui Liu +Add logging about process entering background to NetworkProcess::processDidResume +https://bugs.webkit.org/show_bug.cgi?id=238082 + + +Reviewed by Chris Dumez. + +In rdar://82412733, we found network process can be suspended right after it receives processDidResume message. +For network process, processDidResume means process is not suspended and it is safe to perform database +operations. Let's add logging to check when and why processDidResume message is sent. If the logging confirms +that processDidResume message can be received when process is close to assertion timeout, we probably want to +ignore such message and resume database operations when application actually enters foreground. + +*
[webkit-changes] [292023] branches/safari-614.1.8-branch/Source/WebKit
Title: [292023] branches/safari-614.1.8-branch/Source/WebKit Revision 292023 Author repst...@apple.com Date 2022-03-28 21:33:07 -0700 (Mon, 28 Mar 2022) Log Message Cherry-pick r291982. rdar://problem/90927474 [iOS] Fix sandbox violation related to Network content filtering https://bugs.webkit.org/show_bug.cgi?id=238458 Reviewed by Brent Fulgham. After enabling Network content filtering in the Network process, a related sandbox rule should be moved to the Network process' sandbox. * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291982 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-614.1.8-branch/Source/WebKit/ChangeLog branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: branches/safari-614.1.8-branch/Source/WebKit/ChangeLog (292022 => 292023) --- branches/safari-614.1.8-branch/Source/WebKit/ChangeLog 2022-03-29 03:35:40 UTC (rev 292022) +++ branches/safari-614.1.8-branch/Source/WebKit/ChangeLog 2022-03-29 04:33:07 UTC (rev 292023) @@ -1,5 +1,38 @@ 2022-03-28 Russell Epstein +Cherry-pick r291982. rdar://problem/90927474 + +[iOS] Fix sandbox violation related to Network content filtering +https://bugs.webkit.org/show_bug.cgi?id=238458 + + +Reviewed by Brent Fulgham. + +After enabling Network content filtering in the Network process, a related sandbox rule should +be moved to the Network process' sandbox. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291982 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-03-28 Per Arne Vollan + +[iOS] Fix sandbox violation related to Network content filtering +https://bugs.webkit.org/show_bug.cgi?id=238458 + + +Reviewed by Brent Fulgham. + +After enabling Network content filtering in the Network process, a related sandbox rule should +be moved to the Network process' sandbox. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + +2022-03-28 Russell Epstein + Cherry-pick r292007. rdar://problem/90602918 [macOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units Modified: branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in (292022 => 292023) --- branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in 2022-03-29 03:35:40 UTC (rev 292022) +++ branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in 2022-03-29 04:33:07 UTC (rev 292023) @@ -138,6 +138,10 @@ (prefix "/private/var/db/com.apple.networkextension.") ) +#if ENABLE(CONTENT_FILTERING_IN_NETWORKING_PROCESS) +(allow file-read* (literal "/private/var/Managed Preferences/mobile/com.apple.webcontentfilter.plist")) +#endif + (allow mach-lookup (global-name "com.apple.AppSSO.service-xpc")) (deny ipc-posix-shm-read-data Modified: branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (292022 => 292023) --- branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-03-29 03:35:40 UTC (rev 292022) +++ branches/safari-614.1.8-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-03-29 04:33:07 UTC (rev 292023) @@ -1016,8 +1016,10 @@ ;; Allow loading injected bundles. (allow file-map-executable) +#if !ENABLE(CONTENT_FILTERING_IN_NETWORKING_PROCESS) ;; Allow ManagedPreference access (allow file-read* (literal "/private/var/Managed Preferences/mobile/com.apple.webcontentfilter.plist")) +#endif (allow file-read-data (literal "/usr/local/lib/log") ; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292022] trunk
Title: [292022] trunk
Revision 292022
Author za...@apple.com
Date 2022-03-28 20:35:40 -0700 (Mon, 28 Mar 2022)
Log Message
[ macOS & Win ] fast/repaint/list-item-equal-style-change-no-repaint.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215723
Reviewed by Simon Fraser.
Source/WebCore:
* animation/KeyframeEffect.h:
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.h
Diff
Modified: trunk/LayoutTests/ChangeLog (292021 => 292022)
--- trunk/LayoutTests/ChangeLog 2022-03-29 03:06:07 UTC (rev 292021)
+++ trunk/LayoutTests/ChangeLog 2022-03-29 03:35:40 UTC (rev 292022)
@@ -1,3 +1,13 @@
+2022-03-28 Alan Bujtas
+
+[ macOS & Win ] fast/repaint/list-item-equal-style-change-no-repaint.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=215723
+
+
+Reviewed by Simon Fraser.
+
+* platform/mac/TestExpectations:
+
2022-03-28 Lauro Moura
[AT-SPI] accessibility/native-text-control-attributed-string.html is failing
Modified: trunk/LayoutTests/platform/mac/TestExpectations (292021 => 292022)
--- trunk/LayoutTests/platform/mac/TestExpectations 2022-03-29 03:06:07 UTC (rev 292021)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2022-03-29 03:35:40 UTC (rev 292022)
@@ -1949,8 +1949,6 @@
webkit.org/b/215515 imported/w3c/web-platform-tests/user-timing/measure_navigation_timing.html [ Pass Failure ]
-webkit.org/b/215723 fast/repaint/list-item-equal-style-change-no-repaint.html [ Pass Failure ]
-
webkit.org/b/189672 [ Release ] webgl/2.0.0/conformance2/textures/canvas/tex-2d-rg32f-rg-float.html [ Pass Failure ]
webkit.org/b/191627 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (292021 => 292022)
--- trunk/Source/WebCore/ChangeLog 2022-03-29 03:06:07 UTC (rev 292021)
+++ trunk/Source/WebCore/ChangeLog 2022-03-29 03:35:40 UTC (rev 292022)
@@ -1,3 +1,13 @@
+2022-03-28 Alan Bujtas
+
+[ macOS & Win ] fast/repaint/list-item-equal-style-change-no-repaint.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=215723
+
+
+Reviewed by Simon Fraser.
+
+* animation/KeyframeEffect.h:
+
2022-03-28 Ada Chan
[WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context
Modified: trunk/Source/WebCore/animation/KeyframeEffect.h (292021 => 292022)
--- trunk/Source/WebCore/animation/KeyframeEffect.h 2022-03-29 03:06:07 UTC (rev 292021)
+++ trunk/Source/WebCore/animation/KeyframeEffect.h 2022-03-29 03:35:40 UTC (rev 292022)
@@ -247,7 +247,7 @@
CompositeOperation m_compositeOperation { CompositeOperation::Replace };
AcceleratedProperties m_acceleratedPropertiesState { AcceleratedProperties::None };
AnimationEffectPhase m_phaseAtLastApplication { AnimationEffectPhase::Idle };
-RunningAccelerated m_runningAccelerated;
+RunningAccelerated m_runningAccelerated { RunningAccelerated::No };
bool m_needsForcedLayout { false };
bool m_triggersStackingContext { false };
size_t m_transformFunctionListsMatchPrefix { 0 };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292021] trunk/Source/WebCore
Title: [292021] trunk/Source/WebCore
Revision 292021
Author commit-qu...@webkit.org
Date 2022-03-28 20:06:07 -0700 (Mon, 28 Mar 2022)
Log Message
[WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context
https://bugs.webkit.org/show_bug.cgi?id=238477
Patch by Ada Chan on 2022-03-28
Reviewed by Dean Jackson.
Without this extension, EGLImageTargetTexture2DOES() will fail
in GraphicsContextGLCocoa::attachIOSurfaceToSharedTexture().
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::makeXRCompatible):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292020 => 292021)
--- trunk/Source/WebCore/ChangeLog 2022-03-29 02:04:25 UTC (rev 292020)
+++ trunk/Source/WebCore/ChangeLog 2022-03-29 03:06:07 UTC (rev 292021)
@@ -1,3 +1,16 @@
+2022-03-28 Ada Chan
+
+[WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context
+https://bugs.webkit.org/show_bug.cgi?id=238477
+
+Reviewed by Dean Jackson.
+
+Without this extension, EGLImageTargetTexture2DOES() will fail
+in GraphicsContextGLCocoa::attachIOSurfaceToSharedTexture().
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::makeXRCompatible):
+
2022-03-28 Lauro Moura
Unreviewed, non-unified buildfix after 248938@main
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (292020 => 292021)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2022-03-29 02:04:25 UTC (rev 292020)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2022-03-29 03:06:07 UTC (rev 292021)
@@ -4243,6 +4243,11 @@
// Otherwise: Queue a task on the WebGL task source to perform the following steps:
// FIXME: add a way to verify that we're using a compatible graphics adapter.
m_isXRCompatible = true;
+
+#if PLATFORM(COCOA) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+enableSupportedExtension("GL_OES_EGL_image"_s);
+#endif
+
promise.resolve();
rejectPromiseWithInvalidStateError.release();
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292020] trunk/Source/WebCore
Title: [292020] trunk/Source/WebCore Revision 292020 Author lmo...@igalia.com Date 2022-03-28 19:04:25 -0700 (Mon, 28 Mar 2022) Log Message Unreviewed, non-unified buildfix after 248938@main https://bugs.webkit.org/show_bug.cgi?id=238478 * workers/service/server/SWServerToContextConnection.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h Diff Modified: trunk/Source/WebCore/ChangeLog (292019 => 292020) --- trunk/Source/WebCore/ChangeLog 2022-03-29 01:20:34 UTC (rev 292019) +++ trunk/Source/WebCore/ChangeLog 2022-03-29 02:04:25 UTC (rev 292020) @@ -1,3 +1,10 @@ +2022-03-28 Lauro Moura + +Unreviewed, non-unified buildfix after 248938@main +https://bugs.webkit.org/show_bug.cgi?id=238478 + +* workers/service/server/SWServerToContextConnection.h: + 2022-03-28 Nikolaos Mouchtaris Clamp degenerate calc() values for Modified: trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h (292019 => 292020) --- trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h 2022-03-29 01:20:34 UTC (rev 292019) +++ trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h 2022-03-29 02:04:25 UTC (rev 292020) @@ -28,6 +28,7 @@ #if ENABLE(SERVICE_WORKER) #include "ExceptionData.h" +#include "PageIdentifier.h" #include "RegistrableDomain.h" #include "ScriptExecutionContextIdentifier.h" #include "ServiceWorkerClientQueryOptions.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292019] trunk
Title: [292019] trunk Revision 292019 Author lmo...@igalia.com Date 2022-03-28 18:20:34 -0700 (Mon, 28 Mar 2022) Log Message [AT-SPI] accessibility/native-text-control-attributed-string.html is failing https://bugs.webkit.org/show_bug.cgi?id=237821 Reviewed by Carlos Garcia Campos. Tools: * WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp: (WTR::AccessibilityUIElement::attributedStringForRange): Check the validity of the passed range. LayoutTests: * platform/gtk/TestExpectations: * platform/gtk/accessibility/native-text-control-attributed-string-expected.txt: Added. * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp Added Paths trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (292018 => 292019) --- trunk/LayoutTests/ChangeLog 2022-03-29 01:16:31 UTC (rev 292018) +++ trunk/LayoutTests/ChangeLog 2022-03-29 01:20:34 UTC (rev 292019) @@ -1,3 +1,14 @@ +2022-03-28 Lauro Moura + +[AT-SPI] accessibility/native-text-control-attributed-string.html is failing +https://bugs.webkit.org/show_bug.cgi?id=237821 + +Reviewed by Carlos Garcia Campos. + +* platform/gtk/TestExpectations: +* platform/gtk/accessibility/native-text-control-attributed-string-expected.txt: Added. +* platform/wpe/TestExpectations: + 2022-03-28 Matteo Flores [ iPadOS ] 3 svg/filters/* tests are constant image failures Modified: trunk/LayoutTests/platform/gtk/TestExpectations (292018 => 292019) --- trunk/LayoutTests/platform/gtk/TestExpectations 2022-03-29 01:16:31 UTC (rev 292018) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2022-03-29 01:20:34 UTC (rev 292019) @@ -1864,7 +1864,6 @@ # accessibility/dialog-properties.html [ Skip ] -accessibility/native-text-control-attributed-string.html [ Skip ] # These tests require platform support. media/media-allowed-codecs.html Added: trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt (0 => 292019) --- trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt 2022-03-29 01:20:34 UTC (rev 292019) @@ -0,0 +1,135 @@ +Tests that attributedStringForRange works properly for native text and password fields, including for ranges out of bound. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +Attributed string for range (0, 9): + Default text attributes: + indent:0 + family-name:Liberation Sans + bg-color:255,255,255 + editable:true + strikethrough:false + style:normal + fg-color:0,0,0 + size:12pt + weight:400 + invisible:false + underline:none + direction:ltr + Range attributes for 'some word': +Attributed string for range (0, 3): + Default text attributes: + indent:0 + family-name:Liberation Sans + bg-color:255,255,255 + editable:true + strikethrough:false + style:normal + fg-color:0,0,0 + size:12pt + weight:400 + invisible:false + underline:none + direction:ltr + Range attributes for 'som': +Attributed string for range (5, 4): + Default text attributes: + indent:0 + family-name:Liberation Sans + bg-color:255,255,255 + editable:true + strikethrough:false + style:normal + fg-color:0,0,0 + size:12pt + weight:400 + invisible:false + underline:none + direction:ltr + Range attributes for 'word': +Attributed string for range (5, 10): +Attributed string for range (10, 1): +Attributed string for range (-1, 1): + Default text attributes: + indent:0 + family-name:Liberation Sans + bg-color:255,255,255 + editable:true + strikethrough:false + style:normal + fg-color:0,0,0 + size:12pt + weight:400 + invisible:false + underline:none + direction:ltr + Range attributes for 's': + +Attributed string for range (0, 3): + Default text attributes: + indent:0 + family-name:Liberation Sans + bg-color:255,255,255 + editable:true + strikethrough:false + style:normal + fg-color:0,0,0 + size:12pt + weight:400 + invisible:false + underline:none + direction:ltr + Range attributes for '•••': +Attributed string for range (0, 2): + Default text attributes: + indent:0 + family-name:Liberation Sans + bg-color:255,255,255 + editable:true + strikethrough:false + style:normal + fg-color:0,0,0 + size:12pt + weight:400 + invisible:false + underline:none + direction:ltr + Range attributes for '••': +Attributed string for range (1, 2): + Default text attributes: + indent:0 + family-name:Liberation Sans +
[webkit-changes] [292018] trunk
Title: [292018] trunk Revision 292018 Author nmouchta...@apple.com Date 2022-03-28 18:16:31 -0700 (Mon, 28 Mar 2022) Log Message Clamp degenerate calc() values for https://bugs.webkit.org/show_bug.cgi?id=238401 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt: Source/WebCore: Clamp nan, infinity and -infinity to zero for . Issue discussing this: https://github.com/w3c/csswg-drafts/issues/6105. * css/calc/CSSCalcValue.cpp: (WebCore::CSSCalcValue::clampToPermittedRange const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/calc/CSSCalcValue.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292017 => 292018) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-29 01:14:28 UTC (rev 292017) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-29 01:16:31 UTC (rev 292018) @@ -1,3 +1,12 @@ +2022-03-28 Nikolaos Mouchtaris + +Clamp degenerate calc() values for +https://bugs.webkit.org/show_bug.cgi?id=238401 + +Reviewed by Simon Fraser. + +* web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt: + 2022-03-28 Cameron McCormack Remove the 1ms minimum for setTimeout Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt (292017 => 292018) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt 2022-03-29 01:14:28 UTC (rev 292017) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt 2022-03-29 01:16:31 UTC (rev 292018) @@ -21,16 +21,16 @@ PASS Property transition-delay value 'calc(-infinity* 1s)' PASS Property transition-delay value 'calc(max(1s, 0s) + min(-infinity * 1s, infinity * 1s))' PASS Property transition-delay value 'calc(min(-infinity * 1s, 10s))' -FAIL Property rotate(calc(infinity * 1deg)) value expected same with rotate(0deg) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(-infinity * 1deg)) value expected same with rotate(0deg) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(NaN * 1deg)) value expected same with rotate(0deg) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(infinity * 1turn)) value expected same with rotate(0turn) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(-infinity * 1turn)) value expected same with rotate(0turn) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(NaN * 1turn)) value expected same with rotate(0turn) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(infinity * 1rad)) value expected same with rotate(0rad) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(-infinity * 1rad)) value expected same with rotate(0rad) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(NaN * 1rad)) value expected same with rotate(0rad) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(infinity * 1grad)) value expected same with rotate(0grad) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(-infinity * 1grad)) value expected same with rotate(0grad) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 -FAIL Property rotate(calc(NaN * 1grad)) value expected same with rotate(0grad) in +/-0.0001 assert_array_approx_equals: lengths differ, expected 6 got 16 +PASS Property rotate(calc(infinity * 1deg)) value expected same with rotate(0deg) in +/-0.0001 +PASS Property rotate(calc(-infinity * 1deg)) value expected same with rotate(0deg) in +/-0.0001 +PASS Property rotate(calc(NaN * 1deg)) value expected same with rotate(0deg) in +/-0.0001 +PASS Property rotate(calc(infinity * 1turn)) value expected same with rotate(0turn) in +/-0.0001 +PASS Property rotate(calc(-infinity * 1turn)) value expected same with rotate(0turn) in +/-0.0001 +PASS Property rotate(calc(NaN * 1turn)) value expected same with rotate(0turn) in +/-0.0001 +PASS Property rotate(calc(infinity * 1rad)) value expected same with rotate(0rad) in +/-0.0001 +PASS Property rotate(calc(-infinity * 1rad)) value expected same with rotate(0rad) in +/-0.0001 +PASS Property rotate(calc(NaN * 1rad)) value expected same with rotate(0rad) in +/-0.0001 +PASS Property rotate(calc(infinity * 1grad)) value expected same with rotate(0grad) in +/-0.0001 +PASS Property rotate(calc(-infinity *
[webkit-changes] [292017] branches/safari-614.1.8-branch
Title: [292017] branches/safari-614.1.8-branch Revision 292017 Author repst...@apple.com Date 2022-03-28 18:14:28 -0700 (Mon, 28 Mar 2022) Log Message Cherry-pick r292007. rdar://problem/90602918 [macOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units https://bugs.webkit.org/show_bug.cgi?id=238173 Reviewed by Wenson Hsieh. Source/WebKit: See for information about this API. This change just also enables it on macOS (the other change was iOS-only). * UIProcess/API/Cocoa/WKWebView.h: * UIProcess/API/Cocoa/WKWebViewInternal.h: * UIProcess/API/Cocoa/WKWebView.mm: * UIProcess/API/mac/WKWebViewMac.mm: (-[WKWebView setFrameSize:]): Remove the `#if PLATFORM(IOS_FAMILY)` around all things related to `-[WKWebview setMinimumViewportInset:maximumViewportInset:]`. Tools: * TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: Enable tests for `-[WKWebView setMinimumViewportInset:maximumViewportInset:]` on macOS. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292007 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-614.1.8-branch/Source/WebKit/ChangeLog branches/safari-614.1.8-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h branches/safari-614.1.8-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm branches/safari-614.1.8-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h branches/safari-614.1.8-branch/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm branches/safari-614.1.8-branch/Tools/ChangeLog branches/safari-614.1.8-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm Diff Modified: branches/safari-614.1.8-branch/Source/WebKit/ChangeLog (292016 => 292017) --- branches/safari-614.1.8-branch/Source/WebKit/ChangeLog 2022-03-29 00:40:14 UTC (rev 292016) +++ branches/safari-614.1.8-branch/Source/WebKit/ChangeLog 2022-03-29 01:14:28 UTC (rev 292017) @@ -1,5 +1,53 @@ 2022-03-28 Russell Epstein +Cherry-pick r292007. rdar://problem/90602918 + +[macOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units +https://bugs.webkit.org/show_bug.cgi?id=238173 + + +Reviewed by Wenson Hsieh. + +Source/WebKit: + +See for information about this API. This change just also +enables it on macOS (the other change was iOS-only). + +* UIProcess/API/Cocoa/WKWebView.h: +* UIProcess/API/Cocoa/WKWebViewInternal.h: +* UIProcess/API/Cocoa/WKWebView.mm: +* UIProcess/API/mac/WKWebViewMac.mm: +(-[WKWebView setFrameSize:]): +Remove the `#if PLATFORM(IOS_FAMILY)` around all things related to `-[WKWebview setMinimumViewportInset:maximumViewportInset:]`. + +Tools: + +* TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: +Enable tests for `-[WKWebView setMinimumViewportInset:maximumViewportInset:]` on macOS. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292007 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-03-28 Devin Rousso + +[macOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units +https://bugs.webkit.org/show_bug.cgi?id=238173 + + +Reviewed by Wenson Hsieh. + +See for information about this API. This change just also +enables it on macOS (the other change was iOS-only). + +* UIProcess/API/Cocoa/WKWebView.h: +* UIProcess/API/Cocoa/WKWebViewInternal.h: +* UIProcess/API/Cocoa/WKWebView.mm: +* UIProcess/API/mac/WKWebViewMac.mm: +(-[WKWebView setFrameSize:]): +Remove the `#if PLATFORM(IOS_FAMILY)` around all things related to `-[WKWebview setMinimumViewportInset:maximumViewportInset:]`. + +2022-03-28 Russell Epstein + Cherry-pick r291980. rdar://problem/89434696 [iOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units Modified: branches/safari-614.1.8-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h (292016 => 292017) --- branches/safari-614.1.8-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2022-03-29 00:40:14 UTC (rev 292016) +++ branches/safari-614.1.8-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2022-03-29 01:14:28 UTC (rev 292017) @@ -638,6 +638,10 @@ @property (nonatomic, readonly) UIEdgeInsets minimumViewportInset WK_API_AVAILABLE(ios(WK_IOS_TBA)); @property (nonatomic, readonly) UIEdgeInsets maximumViewportInset WK_API_AVAILABLE(ios(WK_IOS_TBA)); - (void)setMinimumViewportInset:(UIEdgeInsets)minimumViewportInset maximumViewportInset:(UIEdgeInsets)maximumViewportInset WK_API_AVAILABLE(ios(WK_IOS_TBA)); +#else +@property (nonatomic, readonly) NSEdgeInsets minimumViewportInset WK_API_AVAILABLE(macos(WK_MAC_TBA)); +@property (nonatomic, readonly) NSEdgeInsets maximumViewportInset WK_API_AVAILABLE(macos(WK_MAC_TBA)); +-
[webkit-changes] [292016] tags/Safari-613.1.17.0.9/
Title: [292016] tags/Safari-613.1.17.0.9/ Revision 292016 Author alanc...@apple.com Date 2022-03-28 17:40:14 -0700 (Mon, 28 Mar 2022) Log Message Tag Safari-613.1.17.0.9. Added Paths tags/Safari-613.1.17.0.9/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292015] branches/safari-613-branch
Title: [292015] branches/safari-613-branch
Revision 292015
Author alanc...@apple.com
Date 2022-03-28 17:26:40 -0700 (Mon, 28 Mar 2022)
Log Message
Cherry-pick r291622. rdar://problem/90935942
Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170
Reviewed by Eric Carlson.
Source/WebCore:
Test: fetch/fetch-blob-unbounded-range.html
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
Source/WebKit:
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
LayoutTests:
* fetch/fetch-blob-unbounded-range-expected.txt: Added.
* fetch/fetch-blob-unbounded-range.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/platform/network/BlobResourceHandle.cpp
branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp
Added Paths
branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt
branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html
Diff
Modified: branches/safari-613-branch/LayoutTests/ChangeLog (292014 => 292015)
--- branches/safari-613-branch/LayoutTests/ChangeLog 2022-03-29 00:23:58 UTC (rev 292014)
+++ branches/safari-613-branch/LayoutTests/ChangeLog 2022-03-29 00:26:40 UTC (rev 292015)
@@ -1,3 +1,48 @@
+2022-03-28 Alan Coon
+
+Cherry-pick r291622. rdar://problem/90935942
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+Source/WebCore:
+
+Test: fetch/fetch-blob-unbounded-range.html
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* platform/network/BlobResourceHandle.cpp:
+(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
+
+Source/WebKit:
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* NetworkProcess/NetworkDataTaskBlob.cpp:
+(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
+
+LayoutTests:
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-22 Jer Noble
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
2022-03-23 Alan Coon
Revert r285998. rdar://problem/85612240
Added: branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (0 => 292015)
--- branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (rev 0)
+++ branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt 2022-03-29 00:26:40 UTC (rev 292015)
@@ -0,0 +1,4 @@
+
+PASS Bounded range request
+PASS Unbounded range request
+
Added: branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (0 => 292015)
--- branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (rev 0)
+++ branches/safari-613-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html 2022-03-29 00:26:40 UTC (rev 292015)
@@ -0,0 +1,24 @@
+
+
+
+
+
+let buffer = Uint8Array.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
+let blob = new Blob([buffer]);
+let blobURL = URL.createObjectURL(blob);
+
+promise_test(async () => {
+let response = await fetch(blobURL, {headers: new Headers({'Range': 'bytes=0-1'})});
+assert_equals(response.status, 206);
+assert_equals(response.headers.get('Content-Length'), '2');
+assert_equals(response.headers.get('Content-Range'), 'bytes 0-1/10');
+}, "Bounded range request");
+
+promise_test(async () => {
+let response = await fetch(blobURL, {headers: new
[webkit-changes] [292014] trunk/Source/JavaScriptCore
Title: [292014] trunk/Source/_javascript_Core
Revision 292014
Author ysuz...@apple.com
Date 2022-03-28 17:23:58 -0700 (Mon, 28 Mar 2022)
Log Message
[JSC] Clean up some 32bit load/store with 64bit load/store
https://bugs.webkit.org/show_bug.cgi?id=238440
Reviewed by Mark Lam.
1. On OSR entry, we should copy values from scratch to stack via loadValue / storeValue instead of 32bit load/store.
2. We should initialize tail-call's argumentCountIncludingThis slot via store64.
* dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
* jit/CallFrameShuffler.cpp:
(JSC::CallFrameShuffler::prepareAny):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGThunks.cpp
trunk/Source/_javascript_Core/jit/CallFrameShuffler.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292013 => 292014)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-29 00:22:21 UTC (rev 292013)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-29 00:23:58 UTC (rev 292014)
@@ -1,3 +1,18 @@
+2022-03-28 Yusuke Suzuki
+
+[JSC] Clean up some 32bit load/store with 64bit load/store
+https://bugs.webkit.org/show_bug.cgi?id=238440
+
+Reviewed by Mark Lam.
+
+1. On OSR entry, we should copy values from scratch to stack via loadValue / storeValue instead of 32bit load/store.
+2. We should initialize tail-call's argumentCountIncludingThis slot via store64.
+
+* dfg/DFGThunks.cpp:
+(JSC::DFG::osrEntryThunkGenerator):
+* jit/CallFrameShuffler.cpp:
+(JSC::CallFrameShuffler::prepareAny):
+
2022-03-28 Mark Lam
The lazy symbolObjectStructure should be realized before we allocate a SymbolObject.
Modified: trunk/Source/_javascript_Core/dfg/DFGThunks.cpp (292013 => 292014)
--- trunk/Source/_javascript_Core/dfg/DFGThunks.cpp 2022-03-29 00:22:21 UTC (rev 292013)
+++ trunk/Source/_javascript_Core/dfg/DFGThunks.cpp 2022-03-29 00:23:58 UTC (rev 292014)
@@ -151,10 +151,8 @@
MacroAssembler::Label loop = jit.label();
jit.subPtr(MacroAssembler::TrustedImm32(1), GPRInfo::regT1);
jit.negPtr(GPRInfo::regT1, GPRInfo::regT4);
-jit.load32(MacroAssembler::BaseIndex(GPRInfo::regT0, GPRInfo::regT1, MacroAssembler::TimesEight, offsetOfLocals), GPRInfo::regT2);
-jit.load32(MacroAssembler::BaseIndex(GPRInfo::regT0, GPRInfo::regT1, MacroAssembler::TimesEight, offsetOfLocals + sizeof(int32_t)), GPRInfo::regT3);
-jit.store32(GPRInfo::regT2, MacroAssembler::BaseIndex(GPRInfo::callFrameRegister, GPRInfo::regT4, MacroAssembler::TimesEight, -static_cast(sizeof(Register;
-jit.store32(GPRInfo::regT3, MacroAssembler::BaseIndex(GPRInfo::callFrameRegister, GPRInfo::regT4, MacroAssembler::TimesEight, -static_cast(sizeof(Register)) + static_cast(sizeof(int32_t;
+jit.loadValue(MacroAssembler::BaseIndex(GPRInfo::regT0, GPRInfo::regT1, MacroAssembler::TimesEight, offsetOfLocals), JSRInfo::jsRegT32);
+jit.storeValue(JSRInfo::jsRegT32, MacroAssembler::BaseIndex(GPRInfo::callFrameRegister, GPRInfo::regT4, MacroAssembler::TimesEight, -static_cast(sizeof(Register;
jit.branchPtr(MacroAssembler::NotEqual, GPRInfo::regT1, MacroAssembler::TrustedImmPtr(bitwise_cast(-static_cast(CallFrame::headerSizeInRegisters.linkTo(loop, );
jit.loadPtr(MacroAssembler::Address(GPRInfo::regT0, offsetOfTargetPC), GPRInfo::regT1);
Modified: trunk/Source/_javascript_Core/jit/CallFrameShuffler.cpp (292013 => 292014)
--- trunk/Source/_javascript_Core/jit/CallFrameShuffler.cpp 2022-03-29 00:22:21 UTC (rev 292013)
+++ trunk/Source/_javascript_Core/jit/CallFrameShuffler.cpp 2022-03-29 00:23:58 UTC (rev 292014)
@@ -739,11 +739,14 @@
// m_newFrameBase, which could be a wanted register.
if (verbose)
dataLog(" * Storing the argument count into ", VirtualRegister { CallFrameSlot::argumentCountIncludingThis }, "\n");
-m_jit.store32(MacroAssembler::TrustedImm32(0),
-addressForNew(VirtualRegister { CallFrameSlot::argumentCountIncludingThis }).withOffset(TagOffset));
RELEASE_ASSERT(m_numPassedArgs != UINT_MAX);
-m_jit.store32(MacroAssembler::TrustedImm32(m_numPassedArgs),
-addressForNew(VirtualRegister { CallFrameSlot::argumentCountIncludingThis }).withOffset(PayloadOffset));
+#if USE(JSVALUE64)
+// Initialize CallFrameSlot::argumentCountIncludingThis's TagOffset and PayloadOffset with 0 and m_numPassedArgs.
+m_jit.store64(MacroAssembler::TrustedImm32(m_numPassedArgs), addressForNew(VirtualRegister { CallFrameSlot::argumentCountIncludingThis }));
+#else
+m_jit.store32(MacroAssembler::TrustedImm32(0), addressForNew(VirtualRegister { CallFrameSlot::argumentCountIncludingThis }).withOffset(TagOffset));
+m_jit.store32(MacroAssembler::TrustedImm32(m_numPassedArgs), addressForNew(VirtualRegister { CallFrameSlot::argumentCountIncludingThis }).withOffset(PayloadOffset));
+#endif
if (!isSlowPath()) {
ASSERT(m_newFrameBase !=
[webkit-changes] [292013] trunk/LayoutTests
Title: [292013] trunk/LayoutTests Revision 292013 Author matteo_flo...@apple.com Date 2022-03-28 17:22:21 -0700 (Mon, 28 Mar 2022) Log Message [ iPadOS ] 3 svg/filters/* tests are constant image failures https://bugs.webkit.org/show_bug.cgi?id=237689 Unreviewed test gardening. * platform/ipad/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ipad/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292012 => 292013) --- trunk/LayoutTests/ChangeLog 2022-03-29 00:14:40 UTC (rev 292012) +++ trunk/LayoutTests/ChangeLog 2022-03-29 00:22:21 UTC (rev 292013) @@ -1,3 +1,12 @@ +2022-03-28 Matteo Flores + +[ iPadOS ] 3 svg/filters/* tests are constant image failures +https://bugs.webkit.org/show_bug.cgi?id=237689 + +Unreviewed test gardening. + +* platform/ipad/TestExpectations: + 2022-03-28 Wenson Hsieh REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts Modified: trunk/LayoutTests/platform/ipad/TestExpectations (292012 => 292013) --- trunk/LayoutTests/platform/ipad/TestExpectations 2022-03-29 00:14:40 UTC (rev 292012) +++ trunk/LayoutTests/platform/ipad/TestExpectations 2022-03-29 00:22:21 UTC (rev 292013) @@ -65,6 +65,11 @@ webkit.org/b/165311 platform/ipad/media/modern-media-controls/pip-support/pip-support-tap.html [ Skip ] +# webkit.org/b/237689 These tests are constantly failing on iPad +webkit.org/b/237689 svg/filters/big-height-filter.svg [ Failure ] +webkit.org/b/237689 svg/filters/big-sized-off-viewport-filter.svg [ Failure ] +webkit.org/b/237689 svg/filters/big-width-filter.svg [ Failure ] + webkit.org/b/194226 quicklook/word-legacy.html [ Failure ] webkit.org/b/194226 quicklook/word.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292012] branches/safari-613.2.4.0-branch
Title: [292012] branches/safari-613.2.4.0-branch
Revision 292012
Author alanc...@apple.com
Date 2022-03-28 17:14:40 -0700 (Mon, 28 Mar 2022)
Log Message
Cherry-pick r291622. rdar://problem/90935942
Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170
Reviewed by Eric Carlson.
Source/WebCore:
Test: fetch/fetch-blob-unbounded-range.html
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
Source/WebKit:
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
LayoutTests:
* fetch/fetch-blob-unbounded-range-expected.txt: Added.
* fetch/fetch-blob-unbounded-range.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.2.4.0-branch/LayoutTests/ChangeLog
branches/safari-613.2.4.0-branch/Source/WebCore/ChangeLog
branches/safari-613.2.4.0-branch/Source/WebCore/platform/network/BlobResourceHandle.cpp
branches/safari-613.2.4.0-branch/Source/WebKit/ChangeLog
branches/safari-613.2.4.0-branch/Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp
Added Paths
branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt
branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html
Diff
Modified: branches/safari-613.2.4.0-branch/LayoutTests/ChangeLog (292011 => 292012)
--- branches/safari-613.2.4.0-branch/LayoutTests/ChangeLog 2022-03-29 00:13:13 UTC (rev 292011)
+++ branches/safari-613.2.4.0-branch/LayoutTests/ChangeLog 2022-03-29 00:14:40 UTC (rev 292012)
@@ -1,3 +1,48 @@
+2022-03-28 Alan Coon
+
+Cherry-pick r291622. rdar://problem/90935942
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+Source/WebCore:
+
+Test: fetch/fetch-blob-unbounded-range.html
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* platform/network/BlobResourceHandle.cpp:
+(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
+
+Source/WebKit:
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* NetworkProcess/NetworkDataTaskBlob.cpp:
+(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
+
+LayoutTests:
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-22 Jer Noble
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
2022-03-21 Alan Coon
Cherry-pick r291330. rdar://problem/90320701
Added: branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (0 => 292012)
--- branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (rev 0)
+++ branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt 2022-03-29 00:14:40 UTC (rev 292012)
@@ -0,0 +1,4 @@
+
+PASS Bounded range request
+PASS Unbounded range request
+
Added: branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (0 => 292012)
--- branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (rev 0)
+++ branches/safari-613.2.4.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html 2022-03-29 00:14:40 UTC (rev 292012)
@@ -0,0 +1,24 @@
+
+
+
+
+
+let buffer = Uint8Array.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
+let blob = new Blob([buffer]);
+let blobURL = URL.createObjectURL(blob);
+
+promise_test(async () => {
+let response = await fetch(blobURL, {headers: new Headers({'Range': 'bytes=0-1'})});
+assert_equals(response.status, 206);
+assert_equals(response.headers.get('Content-Length'), '2');
+assert_equals(response.headers.get('Content-Range'), 'bytes 0-1/10');
+}, "Bounded
[webkit-changes] [292011] branches/safari-613.2.4.1-branch
Title: [292011] branches/safari-613.2.4.1-branch
Revision 292011
Author alanc...@apple.com
Date 2022-03-28 17:13:13 -0700 (Mon, 28 Mar 2022)
Log Message
Cherry-pick r291622. rdar://problem/90935942
Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170
Reviewed by Eric Carlson.
Source/WebCore:
Test: fetch/fetch-blob-unbounded-range.html
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
Source/WebKit:
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
LayoutTests:
* fetch/fetch-blob-unbounded-range-expected.txt: Added.
* fetch/fetch-blob-unbounded-range.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.2.4.1-branch/LayoutTests/ChangeLog
branches/safari-613.2.4.1-branch/Source/WebCore/ChangeLog
branches/safari-613.2.4.1-branch/Source/WebCore/platform/network/BlobResourceHandle.cpp
branches/safari-613.2.4.1-branch/Source/WebKit/ChangeLog
branches/safari-613.2.4.1-branch/Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp
Added Paths
branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt
branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html
Diff
Modified: branches/safari-613.2.4.1-branch/LayoutTests/ChangeLog (292010 => 292011)
--- branches/safari-613.2.4.1-branch/LayoutTests/ChangeLog 2022-03-29 00:00:29 UTC (rev 292010)
+++ branches/safari-613.2.4.1-branch/LayoutTests/ChangeLog 2022-03-29 00:13:13 UTC (rev 292011)
@@ -1,3 +1,48 @@
+2022-03-28 Alan Coon
+
+Cherry-pick r291622. rdar://problem/90935942
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+Source/WebCore:
+
+Test: fetch/fetch-blob-unbounded-range.html
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* platform/network/BlobResourceHandle.cpp:
+(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
+
+Source/WebKit:
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* NetworkProcess/NetworkDataTaskBlob.cpp:
+(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
+
+LayoutTests:
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-22 Jer Noble
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
2022-03-21 Alan Coon
Cherry-pick r291330. rdar://problem/90320701
Added: branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (0 => 292011)
--- branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (rev 0)
+++ branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt 2022-03-29 00:13:13 UTC (rev 292011)
@@ -0,0 +1,4 @@
+
+PASS Bounded range request
+PASS Unbounded range request
+
Added: branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (0 => 292011)
--- branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (rev 0)
+++ branches/safari-613.2.4.1-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html 2022-03-29 00:13:13 UTC (rev 292011)
@@ -0,0 +1,24 @@
+
+
+
+
+
+let buffer = Uint8Array.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
+let blob = new Blob([buffer]);
+let blobURL = URL.createObjectURL(blob);
+
+promise_test(async () => {
+let response = await fetch(blobURL, {headers: new Headers({'Range': 'bytes=0-1'})});
+assert_equals(response.status, 206);
+assert_equals(response.headers.get('Content-Length'), '2');
+assert_equals(response.headers.get('Content-Range'), 'bytes 0-1/10');
+}, "Bounded
[webkit-changes] [292010] trunk/Source
Title: [292010] trunk/Source Revision 292010 Author sihui_...@apple.com Date 2022-03-28 17:00:29 -0700 (Mon, 28 Mar 2022) Log Message Disable custom storage paths for IndexedDB and LocalStorage by default https://bugs.webkit.org/show_bug.cgi?id=236977 Reviewed by Geoffrey Garen. Source/WebKit: Developers can enable them by disabling "general directory for storage" via internal debug feature or system feature flag. * FeatureFlags/WebKit-appletvos.plist: * FeatureFlags/WebKit-ios.plist: * FeatureFlags/WebKit-macos.plist: * FeatureFlags/WebKit-watchos.plist: * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::internalFeatureEnabled): (WebKit::WebsiteDataStore::defaultShouldUseCustomStoragePaths): Source/WTF: Add an internal debug feature for using genreal directory for storage. * Scripts/Preferences/WebPreferencesInternal.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm Diff Modified: trunk/Source/WTF/ChangeLog (292009 => 292010) --- trunk/Source/WTF/ChangeLog 2022-03-28 23:48:31 UTC (rev 292009) +++ trunk/Source/WTF/ChangeLog 2022-03-29 00:00:29 UTC (rev 292010) @@ -1,3 +1,15 @@ +2022-03-28 Sihui Liu + +Disable custom storage paths for IndexedDB and LocalStorage by default +https://bugs.webkit.org/show_bug.cgi?id=236977 + + +Reviewed by Geoffrey Garen. + +Add an internal debug feature for using genreal directory for storage. + +* Scripts/Preferences/WebPreferencesInternal.yaml: + 2022-03-28 Chris Dumez Prepare WebCore for making the String(const char*) constructor explicit Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (292009 => 292010) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-03-28 23:48:31 UTC (rev 292009) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-03-29 00:00:29 UTC (rev 292010) @@ -980,6 +980,16 @@ WebKit: default: WebKit::defaultUseGPUProcessForMediaEnabled() +UseGeneralDirectoryForStorage: + type: bool + humanReadableName: "Use General Directory For Storage" + humanReadableDescription: "Use general storage directory for IndexedDB and LocalStorage" + webcoreBinding: none + exposed: [ WebKit ] + defaultValue: +WebKit: + default: true + UseSceneKitForModel: type: bool humanReadableName: "Use SceneKit for " Modified: trunk/Source/WebKit/ChangeLog (292009 => 292010) --- trunk/Source/WebKit/ChangeLog 2022-03-28 23:48:31 UTC (rev 292009) +++ trunk/Source/WebKit/ChangeLog 2022-03-29 00:00:29 UTC (rev 292010) @@ -1,3 +1,22 @@ +2022-03-28 Sihui Liu + +Disable custom storage paths for IndexedDB and LocalStorage by default +https://bugs.webkit.org/show_bug.cgi?id=236977 + + +Reviewed by Geoffrey Garen. + +Developers can enable them by disabling "general directory for storage" via internal debug feature or system +feature flag. + +* FeatureFlags/WebKit-appletvos.plist: +* FeatureFlags/WebKit-ios.plist: +* FeatureFlags/WebKit-macos.plist: +* FeatureFlags/WebKit-watchos.plist: +* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: +(WebKit::internalFeatureEnabled): +(WebKit::WebsiteDataStore::defaultShouldUseCustomStoragePaths): + 2022-03-28 Commit Queue Unreviewed, reverting r291728. Modified: trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist (292009 => 292010) --- trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2022-03-28 23:48:31 UTC (rev 292009) +++ trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2022-03-29 00:00:29 UTC (rev 292010) @@ -95,7 +95,7 @@ general_directory_for_storage Enabled - + Modified: trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist (292009 => 292010) --- trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2022-03-28 23:48:31 UTC (rev 292009) +++ trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2022-03-29 00:00:29 UTC (rev 292010) @@ -95,7 +95,7 @@ general_directory_for_storage Enabled - + Modified: trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist (292009 => 292010) --- trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2022-03-28 23:48:31 UTC (rev 292009) +++ trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2022-03-29 00:00:29 UTC (rev 292010) @@ -100,7 +100,7 @@ general_directory_for_storage Enabled - + Modified: trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist (292009 => 292010) --- trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist 2022-03-28 23:48:31 UTC
[webkit-changes] [292009] trunk/Source/JavaScriptCore
Title: [292009] trunk/Source/_javascript_Core
Revision 292009
Author mark@apple.com
Date 2022-03-28 16:48:31 -0700 (Mon, 28 Mar 2022)
Log Message
The lazy symbolObjectStructure should be realized before we allocate a SymbolObject.
https://bugs.webkit.org/show_bug.cgi?id=238474
Reviewed by Yusuke Suzuki and Saam Barati.
We should not be allocating the symbolObjectStructure while in the middle of
initializing a SymbolObject.
* runtime/Symbol.cpp:
(JSC::Symbol::toObject const):
(JSC::SymbolObject::create): Deleted.
* runtime/SymbolObject.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Symbol.cpp
trunk/Source/_javascript_Core/runtime/SymbolObject.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292008 => 292009)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-28 23:31:02 UTC (rev 292008)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-28 23:48:31 UTC (rev 292009)
@@ -1,3 +1,19 @@
+2022-03-28 Mark Lam
+
+The lazy symbolObjectStructure should be realized before we allocate a SymbolObject.
+https://bugs.webkit.org/show_bug.cgi?id=238474
+
+
+Reviewed by Yusuke Suzuki and Saam Barati.
+
+We should not be allocating the symbolObjectStructure while in the middle of
+initializing a SymbolObject.
+
+* runtime/Symbol.cpp:
+(JSC::Symbol::toObject const):
+(JSC::SymbolObject::create): Deleted.
+* runtime/SymbolObject.h:
+
2022-03-28 Chris Dumez
Unreviewed, address post-landing review comment from Darin after r291972.
Modified: trunk/Source/_javascript_Core/runtime/Symbol.cpp (292008 => 292009)
--- trunk/Source/_javascript_Core/runtime/Symbol.cpp 2022-03-28 23:31:02 UTC (rev 292008)
+++ trunk/Source/_javascript_Core/runtime/Symbol.cpp 2022-03-28 23:48:31 UTC (rev 292009)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012-2021 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2022 Apple Inc. All rights reserved.
* Copyright (C) 2015-2016 Yusuke Suzuki .
*
* Redistribution and use in source and binary forms, with or without
@@ -60,13 +60,6 @@
vm.symbolImplToSymbolMap.set(_privateName.uid(), this);
}
-inline SymbolObject* SymbolObject::create(VM& vm, JSGlobalObject* globalObject, Symbol* symbol)
-{
-SymbolObject* object = new (NotNull, allocateCell(vm)) SymbolObject(vm, globalObject->symbolObjectStructure());
-object->finishCreation(vm, symbol);
-return object;
-}
-
JSValue Symbol::toPrimitive(JSGlobalObject*, PreferredPrimitiveType) const
{
return const_cast(this);
@@ -74,7 +67,7 @@
JSObject* Symbol::toObject(JSGlobalObject* globalObject) const
{
-return SymbolObject::create(globalObject->vm(), globalObject, const_cast(this));
+return SymbolObject::create(globalObject->vm(), globalObject->symbolObjectStructure(), const_cast(this));
}
double Symbol::toNumber(JSGlobalObject* globalObject) const
Modified: trunk/Source/_javascript_Core/runtime/SymbolObject.h (292008 => 292009)
--- trunk/Source/_javascript_Core/runtime/SymbolObject.h 2022-03-28 23:31:02 UTC (rev 292008)
+++ trunk/Source/_javascript_Core/runtime/SymbolObject.h 2022-03-28 23:48:31 UTC (rev 292009)
@@ -49,7 +49,6 @@
object->finishCreation(vm, symbol);
return object;
}
-static SymbolObject* create(VM&, JSGlobalObject*, Symbol*);
DECLARE_EXPORT_INFO;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292008] trunk/Source/WebKit
Title: [292008] trunk/Source/WebKit
Revision 292008
Author commit-qu...@webkit.org
Date 2022-03-28 16:31:02 -0700 (Mon, 28 Mar 2022)
Log Message
Unreviewed, reverting r291728.
https://bugs.webkit.org/show_bug.cgi?id=238476
causing crashes in tests
Reverted changeset:
"Expand autocorrect context for more accurate results."
https://bugs.webkit.org/show_bug.cgi?id=237990
https://commits.webkit.org/r291728
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292007 => 292008)
--- trunk/Source/WebKit/ChangeLog 2022-03-28 23:28:00 UTC (rev 292007)
+++ trunk/Source/WebKit/ChangeLog 2022-03-28 23:31:02 UTC (rev 292008)
@@ -1,3 +1,16 @@
+2022-03-28 Commit Queue
+
+Unreviewed, reverting r291728.
+https://bugs.webkit.org/show_bug.cgi?id=238476
+
+causing crashes in tests
+
+Reverted changeset:
+
+"Expand autocorrect context for more accurate results."
+https://bugs.webkit.org/show_bug.cgi?id=237990
+https://commits.webkit.org/r291728
+
2022-03-28 Devin Rousso
[macOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (292007 => 292008)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-03-28 23:28:00 UTC (rev 292007)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-03-28 23:31:02 UTC (rev 292008)
@@ -2565,9 +2565,9 @@
Ref frame = CheckedRef(m_page->focusController())->focusedOrMainFrame();
VisiblePosition startPosition = frame->selection().selection().start();
VisiblePosition endPosition = frame->selection().selection().end();
-const unsigned minContextWordCount = 10;
-const unsigned minContextLength = 40;
-const unsigned maxContextLength = 100;
+const unsigned minContextWordCount = 3;
+const unsigned minContextLength = 12;
+const unsigned maxContextLength = 30;
if (frame->selection().isRange())
selectedText = plainTextForContext(frame->selection().selection().toNormalizedRange());
@@ -2598,9 +2598,6 @@
break;
contextStartPosition = previousPosition;
}
-VisiblePosition sentenceContextStartPosition = positionOfNextBoundaryOfGranularity(startPosition, TextGranularity::SentenceGranularity, SelectionDirection::Backward);
-if (sentenceContextStartPosition.isNotNull() && sentenceContextStartPosition < contextStartPosition)
-contextStartPosition = sentenceContextStartPosition;
if (contextStartPosition.isNotNull() && contextStartPosition != startPosition) {
contextBefore = plainTextForContext(makeSimpleRange(contextStartPosition, startPosition));
if (atBoundaryOfGranularity(contextStartPosition, TextGranularity::ParagraphGranularity, SelectionDirection::Backward) && firstPositionInEditableContent != contextStartPosition)
@@ -2609,9 +2606,10 @@
}
if (endPosition != endOfEditableContent(endPosition)) {
-VisiblePosition nextPosition = positionOfNextBoundaryOfGranularity(endPosition, TextGranularity::SentenceGranularity, SelectionDirection::Forward);
-if (nextPosition.isNotNull() && nextPosition != endPosition)
-contextAfter = plainTextForContext(makeSimpleRange(endPosition, nextPosition));
+VisiblePosition nextPosition;
+if (!atBoundaryOfGranularity(endPosition, TextGranularity::WordGranularity, SelectionDirection::Forward) && withinTextUnitOfGranularity(endPosition, TextGranularity::WordGranularity, SelectionDirection::Forward))
+nextPosition = positionOfNextBoundaryOfGranularity(endPosition, TextGranularity::WordGranularity, SelectionDirection::Forward);
+contextAfter = plainTextForContext(makeSimpleRange(endPosition, nextPosition));
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292007] trunk
Title: [292007] trunk
Revision 292007
Author drou...@apple.com
Date 2022-03-28 16:28:00 -0700 (Mon, 28 Mar 2022)
Log Message
[macOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units
https://bugs.webkit.org/show_bug.cgi?id=238173
Reviewed by Wenson Hsieh.
Source/WebKit:
See for information about this API. This change just also
enables it on macOS (the other change was iOS-only).
* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView setFrameSize:]):
Remove the `#if PLATFORM(IOS_FAMILY)` around all things related to `-[WKWebview setMinimumViewportInset:maximumViewportInset:]`.
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
Enable tests for `-[WKWebView setMinimumViewportInset:maximumViewportInset:]` on macOS.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292006 => 292007)
--- trunk/Source/WebKit/ChangeLog 2022-03-28 23:27:36 UTC (rev 292006)
+++ trunk/Source/WebKit/ChangeLog 2022-03-28 23:28:00 UTC (rev 292007)
@@ -1,3 +1,21 @@
+2022-03-28 Devin Rousso
+
+[macOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units
+https://bugs.webkit.org/show_bug.cgi?id=238173
+
+
+Reviewed by Wenson Hsieh.
+
+See for information about this API. This change just also
+enables it on macOS (the other change was iOS-only).
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebViewInternal.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+* UIProcess/API/mac/WKWebViewMac.mm:
+(-[WKWebView setFrameSize:]):
+Remove the `#if PLATFORM(IOS_FAMILY)` around all things related to `-[WKWebview setMinimumViewportInset:maximumViewportInset:]`.
+
2022-03-28 Wenson Hsieh
REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h (292006 => 292007)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2022-03-28 23:27:36 UTC (rev 292006)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2022-03-28 23:28:00 UTC (rev 292007)
@@ -638,6 +638,10 @@
@property (nonatomic, readonly) UIEdgeInsets minimumViewportInset WK_API_AVAILABLE(ios(WK_IOS_TBA));
@property (nonatomic, readonly) UIEdgeInsets maximumViewportInset WK_API_AVAILABLE(ios(WK_IOS_TBA));
- (void)setMinimumViewportInset:(UIEdgeInsets)minimumViewportInset maximumViewportInset:(UIEdgeInsets)maximumViewportInset WK_API_AVAILABLE(ios(WK_IOS_TBA));
+#else
+@property (nonatomic, readonly) NSEdgeInsets minimumViewportInset WK_API_AVAILABLE(macos(WK_MAC_TBA));
+@property (nonatomic, readonly) NSEdgeInsets maximumViewportInset WK_API_AVAILABLE(macos(WK_MAC_TBA));
+- (void)setMinimumViewportInset:(NSEdgeInsets)minimumViewportInset maximumViewportInset:(NSEdgeInsets)maximumViewportInset WK_API_AVAILABLE(macos(WK_MAC_TBA));
#endif
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (292006 => 292007)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-03-28 23:27:36 UTC (rev 292006)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-03-28 23:28:00 UTC (rev 292007)
@@ -1865,8 +1865,6 @@
#endif
}
-#if PLATFORM(IOS_FAMILY)
-
- (void)setMinimumViewportInset:(CocoaEdgeInsets)minimumViewportInset maximumViewportInset:(CocoaEdgeInsets)maximumViewportInset
{
if (minimumViewportInset.top < 0 || minimumViewportInset.left < 0 || minimumViewportInset.bottom < 0 || minimumViewportInset.right < 0)
@@ -1884,8 +1882,6 @@
_maximumViewportInset = maximumViewportInset;
}
-#endif // PLATFORM(IOS_FAMILY)
-
@end
#pragma mark -
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h (292006 => 292007)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h 2022-03-28 23:27:36 UTC (rev 292006)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h 2022-03-28 23:28:00 UTC (rev 292007)
@@ -140,10 +140,8 @@
_WKRenderingProgressEvents _observedRenderingProgressEvents;
BOOL _usePlatformFindUI;
-#if PLATFORM(IOS_FAMILY)
CocoaEdgeInsets _minimumViewportInset;
CocoaEdgeInsets _maximumViewportInset;
-#endif
#if PLATFORM(MAC)
std::unique_ptr _impl;
Modified: trunk/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm (292006 => 292007)
--- trunk/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm 2022-03-28 23:27:36 UTC (rev 292006)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm 2022-03-28 23:28:00 UTC (rev
[webkit-changes] [292005] trunk
Title: [292005] trunk Revision 292005 Author wenson_hs...@apple.com Date 2022-03-28 16:23:47 -0700 (Mon, 28 Mar 2022) Log Message REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts https://bugs.webkit.org/show_bug.cgi?id=238155 rdar://90593957 Reviewed by Aditya Keerthi. Source/WebKit: After the changes in r290794, we now preemptively compute and send an excessive amount of autocorrection contexts to the UI process when an element gains focus, such that the UI process is capable of immediately responding to calls to `-requestAutocorrectionContextWithCompletionHandler:` without relying on synchronous IPC to the web process. This made several (already-fairly-slow) tests in editing/selection time out, due to WebKit computing and sending an excessive amount of this contextual information. To mitigate this, only perform this preemptive autocorrection context computation if the focused element is actually changing (i.e., we're not refocusing the same element). Covered by removing several [ Slow ] test expectations that should no longer be needed. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::elementDidFocus): LayoutTests: Unmark several tests that no longer need to be marked as [ Slow ]. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/LayoutTests/ChangeLog (292004 => 292005) --- trunk/LayoutTests/ChangeLog 2022-03-28 23:04:17 UTC (rev 292004) +++ trunk/LayoutTests/ChangeLog 2022-03-28 23:23:47 UTC (rev 292005) @@ -1,3 +1,15 @@ +2022-03-28 Wenson Hsieh + +REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts +https://bugs.webkit.org/show_bug.cgi?id=238155 +rdar://90593957 + +Reviewed by Aditya Keerthi. + +Unmark several tests that no longer need to be marked as [ Slow ]. + +* platform/ios/TestExpectations: + 2022-03-28 Cameron McCormack Remove the 1ms minimum for setTimeout Modified: trunk/LayoutTests/platform/ios/TestExpectations (292004 => 292005) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-03-28 23:04:17 UTC (rev 292004) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-03-28 23:23:47 UTC (rev 292005) @@ -2676,13 +2676,6 @@ webkit.org/b/210173 webrtc/h265.html [ Skip ] -# webkit.org/b/238155 [ Debug ] These 5 tests are timing out on iOS Debug Specifically. -[ Debug ] editing/selection/move-by-word-visually-single-space-one-element.html [ Slow ] -[ Debug ] editing/selection/move-by-word-visually-single-space-inline-element.html [ Slow ] -[ Debug ] editing/selection/move-by-word-visually-multi-line.html [ Slow ] -[ Debug ] editing/selection/move-by-word-visually-mac.html [ Slow ] -[ Debug ] editing/selection/move-by-word-visually-inline-block-positioned-element.html [ Slow ] - webkit.org/b/209878 [ Debug ] webrtc/datachannel/multiple-connections.html [ Slow ] webkit.org/b/177323 imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html [ Pass Failure ] Modified: trunk/Source/WebKit/ChangeLog (292004 => 292005) --- trunk/Source/WebKit/ChangeLog 2022-03-28 23:04:17 UTC (rev 292004) +++ trunk/Source/WebKit/ChangeLog 2022-03-28 23:23:47 UTC (rev 292005) @@ -1,3 +1,24 @@ +2022-03-28 Wenson Hsieh + +REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts +https://bugs.webkit.org/show_bug.cgi?id=238155 +rdar://90593957 + +Reviewed by Aditya Keerthi. + +After the changes in r290794, we now preemptively compute and send an excessive amount of autocorrection +contexts to the UI process when an element gains focus, such that the UI process is capable of immediately +responding to calls to `-requestAutocorrectionContextWithCompletionHandler:` without relying on synchronous IPC +to the web process. This made several (already-fairly-slow) tests in editing/selection time out, due to WebKit +computing and sending an excessive amount of this contextual information. + +To mitigate this, only perform this preemptive autocorrection context computation if the focused element is +actually changing (i.e., we're not refocusing the same element). Covered by removing several [ Slow ] test +expectations that should no longer be needed. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::elementDidFocus): + 2022-03-28 Per Arne Vollan [macOS] Block access to IOKit class Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (292004 => 292005) --- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-03-28 23:04:17 UTC (rev 292004) +++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-03-28 23:23:47 UTC (rev 292005) @@ -6297,6 +6297,9 @@ } if
[webkit-changes] [292004] branches/safari-613.2.4.1-branch/Source/JavaScriptCore
Title: [292004] branches/safari-613.2.4.1-branch/Source/_javascript_Core
Revision 292004
Author alanc...@apple.com
Date 2022-03-28 16:04:17 -0700 (Mon, 28 Mar 2022)
Log Message
Cherry-pick r291891. rdar://problem/90935489
AI should not set the structure for ObjectCreate
https://bugs.webkit.org/show_bug.cgi?id=238349
Patch by Justin Michaud on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.
The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.2.4.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.2.4.1-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
Diff
Modified: branches/safari-613.2.4.1-branch/Source/_javascript_Core/ChangeLog (292003 => 292004)
--- branches/safari-613.2.4.1-branch/Source/_javascript_Core/ChangeLog 2022-03-28 23:03:52 UTC (rev 292003)
+++ branches/safari-613.2.4.1-branch/Source/_javascript_Core/ChangeLog 2022-03-28 23:04:17 UTC (rev 292004)
@@ -1,3 +1,36 @@
+2022-03-28 Alan Coon
+
+Cherry-pick r291891. rdar://problem/90935489
+
+AI should not set the structure for ObjectCreate
+https://bugs.webkit.org/show_bug.cgi?id=238349
+
+Patch by Justin Michaud on 2022-03-24
+Reviewed by Saam Barati and Yusuke Suzuki.
+
+The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
+the time the constant folding phase runs if the structure cache is cleared.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-24 Justin Michaud
+
+AI should not set the structure for ObjectCreate
+https://bugs.webkit.org/show_bug.cgi?id=238349
+
+Reviewed by Saam Barati and Yusuke Suzuki.
+
+The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
+the time the constant folding phase runs if the structure cache is cleared.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+
2022-03-21 Alan Coon
Cherry-pick r290981. rdar://problem/83326232
Modified: branches/safari-613.2.4.1-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (292003 => 292004)
--- branches/safari-613.2.4.1-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2022-03-28 23:03:52 UTC (rev 292003)
+++ branches/safari-613.2.4.1-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2022-03-28 23:04:17 UTC (rev 292004)
@@ -3123,25 +3123,10 @@
}
case ObjectCreate: {
-if (JSValue base = forNode(node->child1()).m_value) {
-JSGlobalObject* globalObject = m_graph.globalObjectFor(node->origin.semantic);
-Structure* structure = nullptr;
-if (base.isNull())
-structure = globalObject->nullPrototypeObjectStructure();
-else if (base.isObject()) {
-// Having a bad time clears the structureCache, and so it should invalidate this structure.
-bool isHavingABadTime = globalObject->isHavingABadTime();
-// Normally, we would always install a watchpoint. In this case, however, if we haveABadTime, we
-// still want to optimize. There is no watchpoint for that case though, so we need to make sure this load
-// does not get hoisted above the check.
-WTF::loadLoadFence();
-if (!isHavingABadTime)
-m_graph.watchpoints().addLazily(globalObject->havingABadTimeWatchpoint());
-structure = m_vm.structureCache.emptyObjectStructureConcurrently(globalObject, base.getObject(), JSFinalObject::defaultInlineCapacity());
-}
-
-if (structure) {
-m_state.setShouldTryConstantFolding(true);
+if (JSValue prototype = forNode(node->child1()).m_value) {
+m_state.setShouldTryConstantFolding(true);
+if (prototype.isNull()) {
+Structure* structure = m_graph.globalObjectFor(node->origin.semantic)->nullPrototypeObjectStructure();
if (node->child1().useKind() == UntypedUse)
didFoldClobberWorld();
setForNode(node, structure);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292003] trunk/Source/WebKit
Title: [292003] trunk/Source/WebKit Revision 292003 Author pvol...@apple.com Date 2022-03-28 16:03:52 -0700 (Mon, 28 Mar 2022) Log Message [macOS] Block access to IOKit class https://bugs.webkit.org/show_bug.cgi?id=238457 Reviewed by Geoffrey Garen. Block access to IOKit class AGPMClient on macOS. We already block all messages for this class. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (292002 => 292003) --- trunk/Source/WebKit/ChangeLog 2022-03-28 22:52:49 UTC (rev 292002) +++ trunk/Source/WebKit/ChangeLog 2022-03-28 23:03:52 UTC (rev 292003) @@ -1,3 +1,14 @@ +2022-03-28 Per Arne Vollan + +[macOS] Block access to IOKit class +https://bugs.webkit.org/show_bug.cgi?id=238457 + +Reviewed by Geoffrey Garen. + +Block access to IOKit class AGPMClient on macOS. We already block all messages for this class. + +* WebProcess/com.apple.WebProcess.sb.in: + 2022-03-28 Fujii Hironori Unreviewed build fix after 291979 for WinCairo and PlayStation Debug builds Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (292002 => 292003) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2022-03-28 22:52:49 UTC (rev 292002) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2022-03-28 23:03:52 UTC (rev 292003) @@ -454,32 +454,20 @@ ) ;; QuartzCore +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 11 +(deny iokit-open (with no-log) +(iokit-registry-entry-class "AGPMClient")) +#else +(allow iokit-open +(require-all +(extension "com.apple.webkit.extension.iokit") +(iokit-registry-entry-class "AGPMClient"))) +#endif + (if (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") (allow iokit-open (require-all (extension "com.apple.webkit.extension.iokit") -(iokit-registry-entry-class "AGPMClient") -) -(apply-message-filter -(deny (with telemetry) -iokit-async-external-method -iokit-external-trap -iokit-external-method -) -) -) -; else -(allow iokit-open -(require-all -(extension "com.apple.webkit.extension.iokit") -(iokit-registry-entry-class "AGPMClient") -) -) -) -(if (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") -(allow iokit-open -(require-all -(extension "com.apple.webkit.extension.iokit") (iokit-registry-entry-class "AppleGraphicsControlClient") ) (apply-message-filter ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292002] trunk/Source/WebCore
Title: [292002] trunk/Source/WebCore
Revision 292002
Author commit-qu...@webkit.org
Date 2022-03-28 15:52:49 -0700 (Mon, 28 Mar 2022)
Log Message
Check for re-entrancy in stopForBackForwardCache
https://bugs.webkit.org/show_bug.cgi?id=223536
Patch by Rob Buis on 2022-03-28
Reviewed by Darin Adler.
Check for re-entrancy in stopForBackForwardCache.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopForBackForwardCache):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292001 => 292002)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 22:51:41 UTC (rev 292001)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 22:52:49 UTC (rev 292002)
@@ -1,3 +1,15 @@
+2022-03-28 Rob Buis
+
+Check for re-entrancy in stopForBackForwardCache
+https://bugs.webkit.org/show_bug.cgi?id=223536
+
+Reviewed by Darin Adler.
+
+Check for re-entrancy in stopForBackForwardCache.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::stopForBackForwardCache):
+
2022-03-28 Cameron McCormack
Remove the 1ms minimum for setTimeout
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (292001 => 292002)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2022-03-28 22:51:41 UTC (rev 292001)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2022-03-28 22:52:49 UTC (rev 292002)
@@ -1830,7 +1830,8 @@
void FrameLoader::stopForBackForwardCache()
{
-m_inStopForBackForwardCache = true;
+ASSERT(!m_inStopForBackForwardCache);
+SetForScope inStopForBackForwardCache { m_inStopForBackForwardCache, true };
// Stop provisional loads in subframes (The one in the main frame is about to be committed).
if (!m_frame.isMainFrame()) {
if (m_provisionalDocumentLoader)
@@ -1850,7 +1851,6 @@
// running script, which could schedule new navigations.
policyChecker().stopCheck();
m_frame.navigationScheduler().cancel();
-m_inStopForBackForwardCache = false;
}
void FrameLoader::stopAllLoadersAndCheckCompleteness()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292001] branches/safari-613.2.4.1-branch/Source
Title: [292001] branches/safari-613.2.4.1-branch/Source Revision 292001 Author alanc...@apple.com Date 2022-03-28 15:51:41 -0700 (Mon, 28 Mar 2022) Log Message Versioning. WebKit-7613.2.4.1.1 Modified Paths branches/safari-613.2.4.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.4.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.4.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (292000 => 292001) --- branches/safari-613.2.4.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 22:44:45 UTC (rev 292000) +++ branches/safari-613.2.4.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 22:51:41 UTC (rev 292001) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292000 => 292001) --- branches/safari-613.2.4.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 22:44:45 UTC (rev 292000) +++ branches/safari-613.2.4.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 22:51:41 UTC (rev 292001) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292000 => 292001) --- branches/safari-613.2.4.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 22:44:45 UTC (rev 292000) +++ branches/safari-613.2.4.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 22:51:41 UTC (rev 292001) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.1-branch/Source/WebCore/Configurations/Version.xcconfig (292000 => 292001) --- branches/safari-613.2.4.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 22:44:45 UTC (rev 292000) +++ branches/safari-613.2.4.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 22:51:41 UTC (rev 292001) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (292000 => 292001) --- branches/safari-613.2.4.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 22:44:45 UTC (rev 292000) +++ branches/safari-613.2.4.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 22:51:41 UTC (rev 292001) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION =
[webkit-changes] [292000] branches/safari-613.2.4.3-branch/Source/JavaScriptCore
Title: [292000] branches/safari-613.2.4.3-branch/Source/_javascript_Core
Revision 292000
Author alanc...@apple.com
Date 2022-03-28 15:44:45 -0700 (Mon, 28 Mar 2022)
Log Message
Cherry-pick r291891. rdar://problem/90935489
AI should not set the structure for ObjectCreate
https://bugs.webkit.org/show_bug.cgi?id=238349
Patch by Justin Michaud on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.
The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.2.4.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.2.4.3-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
Diff
Modified: branches/safari-613.2.4.3-branch/Source/_javascript_Core/ChangeLog (291999 => 292000)
--- branches/safari-613.2.4.3-branch/Source/_javascript_Core/ChangeLog 2022-03-28 22:39:13 UTC (rev 291999)
+++ branches/safari-613.2.4.3-branch/Source/_javascript_Core/ChangeLog 2022-03-28 22:44:45 UTC (rev 292000)
@@ -1,3 +1,36 @@
+2022-03-28 Alan Coon
+
+Cherry-pick r291891. rdar://problem/90935489
+
+AI should not set the structure for ObjectCreate
+https://bugs.webkit.org/show_bug.cgi?id=238349
+
+Patch by Justin Michaud on 2022-03-24
+Reviewed by Saam Barati and Yusuke Suzuki.
+
+The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
+the time the constant folding phase runs if the structure cache is cleared.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-24 Justin Michaud
+
+AI should not set the structure for ObjectCreate
+https://bugs.webkit.org/show_bug.cgi?id=238349
+
+Reviewed by Saam Barati and Yusuke Suzuki.
+
+The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
+the time the constant folding phase runs if the structure cache is cleared.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+
2022-03-21 Alan Coon
Cherry-pick r290981. rdar://problem/83326232
Modified: branches/safari-613.2.4.3-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (291999 => 292000)
--- branches/safari-613.2.4.3-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2022-03-28 22:39:13 UTC (rev 291999)
+++ branches/safari-613.2.4.3-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2022-03-28 22:44:45 UTC (rev 292000)
@@ -3123,25 +3123,10 @@
}
case ObjectCreate: {
-if (JSValue base = forNode(node->child1()).m_value) {
-JSGlobalObject* globalObject = m_graph.globalObjectFor(node->origin.semantic);
-Structure* structure = nullptr;
-if (base.isNull())
-structure = globalObject->nullPrototypeObjectStructure();
-else if (base.isObject()) {
-// Having a bad time clears the structureCache, and so it should invalidate this structure.
-bool isHavingABadTime = globalObject->isHavingABadTime();
-// Normally, we would always install a watchpoint. In this case, however, if we haveABadTime, we
-// still want to optimize. There is no watchpoint for that case though, so we need to make sure this load
-// does not get hoisted above the check.
-WTF::loadLoadFence();
-if (!isHavingABadTime)
-m_graph.watchpoints().addLazily(globalObject->havingABadTimeWatchpoint());
-structure = m_vm.structureCache.emptyObjectStructureConcurrently(globalObject, base.getObject(), JSFinalObject::defaultInlineCapacity());
-}
-
-if (structure) {
-m_state.setShouldTryConstantFolding(true);
+if (JSValue prototype = forNode(node->child1()).m_value) {
+m_state.setShouldTryConstantFolding(true);
+if (prototype.isNull()) {
+Structure* structure = m_graph.globalObjectFor(node->origin.semantic)->nullPrototypeObjectStructure();
if (node->child1().useKind() == UntypedUse)
didFoldClobberWorld();
setForNode(node, structure);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291999] branches/safari-613.2.4.3-branch/Source
Title: [291999] branches/safari-613.2.4.3-branch/Source Revision 291999 Author alanc...@apple.com Date 2022-03-28 15:39:13 -0700 (Mon, 28 Mar 2022) Log Message Versioning. WebKit-7613.2.4.3.1 Modified Paths branches/safari-613.2.4.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.4.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.4.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (291998 => 291999) --- branches/safari-613.2.4.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 22:35:26 UTC (rev 291998) +++ branches/safari-613.2.4.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 22:39:13 UTC (rev 291999) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (291998 => 291999) --- branches/safari-613.2.4.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 22:35:26 UTC (rev 291998) +++ branches/safari-613.2.4.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 22:39:13 UTC (rev 291999) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (291998 => 291999) --- branches/safari-613.2.4.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 22:35:26 UTC (rev 291998) +++ branches/safari-613.2.4.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 22:39:13 UTC (rev 291999) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.3-branch/Source/WebCore/Configurations/Version.xcconfig (291998 => 291999) --- branches/safari-613.2.4.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 22:35:26 UTC (rev 291998) +++ branches/safari-613.2.4.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 22:39:13 UTC (rev 291999) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (291998 => 291999) --- branches/safari-613.2.4.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 22:35:26 UTC (rev 291998) +++ branches/safari-613.2.4.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 22:39:13 UTC (rev 291999) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; TINY_VERSION = 4; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION =
[webkit-changes] [291998] trunk
Title: [291998] trunk Revision 291998 Author hey...@apple.com Date 2022-03-28 15:35:26 -0700 (Mon, 28 Mar 2022) Log Message Remove the 1ms minimum for setTimeout https://bugs.webkit.org/show_bug.cgi?id=221124 Reviewed by Sam Weinig. LayoutTests/imported/w3c: * web-platform-tests/html/webappapis/timers/zero-settimeout.any-expected.txt: * web-platform-tests/html/webappapis/timers/zero-settimeout.any.html: * web-platform-tests/html/webappapis/timers/zero-settimeout.any.js: (async_test): * web-platform-tests/html/webappapis/timers/zero-settimeout.any.worker-expected.txt: * web-platform-tests/html/webappapis/timers/zero-settimeout.any.worker.html: New test checking that 0ms and 1ms timeouts are called in the right order. * web-platform-tests/FileAPI/file/File-constructor.any.worker-expected.txt: * web-platform-tests/html/webappapis/microtask-queuing/queue-microtask-exceptions.any.worker-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-cross-origin.sub.any.worker-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-redirect-to-cross-origin.sub.any.worker-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-same-origin.sub.any.worker-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-cross-origin.sub.any.worker-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-redirect-to-cross-origin.sub.any.worker-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-same-origin.sub.any.worker-expected.txt: Disable console output in some worker tests where the reduced timeout would cause intemittent failures due to the console message sometimes not making it to the test output in time. Source/WebCore: This patch removes the 1ms minimum for setTimeout. The HTML spec makes no mention of such a minimum, and Firefox and Chrome do not enforce this minimum. Removing this for setTimeout results in a 0.7-2.1% improvement on Speedometer, depending on platform and hardware. The WPT added here demonstrates how this change can affect pages: if a page schedules a 1ms and then a 0ms timeout in the same turn of the event loop, then with this patch they will now be fired in the reverse order. Since Firefox and Chrome do not impose a 1ms minimum, this reduces the risk of this being a compatbility problem. Scheduling a 0ms timeout will cause its callback to be called the next time around the event loop. Other, non-timer queued tasks, will be pre-empted. This behavior is permitted by the HTML spec, since the event loop processing model[1] states that the implementation can choose which task source to service, and timer callbacks are dispatched using their own task source. Due to the way the SharedTimer is called, we don't need to literally dispatch a task with a new TaskSource::Timer source. (If we decided later to make a different about whether to service timer callbacks before tasks from all other task sources, we might need to.) Not addressing the setTimeout 1ms minimum here, which should likely also be removed. While we're here, settle on "one shot" rather rather than "single shot" as the term for timers that fire once. [1] https://html.spec.whatwg.org/#event-loop-processing-model Tests: imported/w3c/web-platform-tests/html/webappapis/timers/zero-settimeout.any.html imported/w3c/web-platform-tests/html/webappapis/timers/zero-settimeout.any.worker.html * page/DOMTimer.h: * page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::install): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::updateTimerIntervalIfNecessary): (WebCore::DOMTimer::intervalClampedToMinimum const): LayoutTests: * TestExpectations: Disable console output in some worker tests where the reduced timeout would cause intemittent failures due to the console message sometimes not making it to the test output in time. * js/script-tests/weakref-finalizationregistry.js: (turnEventLoop): Use a timeout of 1ms instead of 0ms so that the deferred work task that calls the JS FinalizationRegistry callback gets a chance to run before we continue on to the assertion that it was run. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/File-constructor.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/microtask-queuing/queue-microtask-exceptions.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-cross-origin.sub.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-redirect-to-cross-origin.sub.any.worker-expected.txt
[webkit-changes] [291997] trunk/Source/JavaScriptCore
Title: [291997] trunk/Source/_javascript_Core
Revision 291997
Author cdu...@apple.com
Date 2022-03-28 15:23:39 -0700 (Mon, 28 Mar 2022)
Log Message
Unreviewed, address post-landing review comment from Darin after r291972.
* yarr/YarrJIT.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291996 => 291997)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-28 22:20:21 UTC (rev 291996)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-28 22:23:39 UTC (rev 291997)
@@ -1,5 +1,11 @@
2022-03-28 Chris Dumez
+Unreviewed, address post-landing review comment from Darin after r291972.
+
+* yarr/YarrJIT.cpp:
+
+2022-03-28 Chris Dumez
+
Use StringView for Yarr / RegularExpression parsing
https://bugs.webkit.org/show_bug.cgi?id=238420
Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (291996 => 291997)
--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2022-03-28 22:20:21 UTC (rev 291996)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2022-03-28 22:23:39 UTC (rev 291997)
@@ -4652,7 +4652,7 @@
StackCheck* m_compilationThreadStackChecker { nullptr };
YarrPattern& m_pattern;
-StringView m_patternString;
+const StringView m_patternString;
CharSize m_charSize;
JITCompileMode m_compileMode;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291996] branches/safari-613.2.4.0-branch/Source/JavaScriptCore
Title: [291996] branches/safari-613.2.4.0-branch/Source/_javascript_Core
Revision 291996
Author alanc...@apple.com
Date 2022-03-28 15:20:21 -0700 (Mon, 28 Mar 2022)
Log Message
Cherry-pick r291891. rdar://problem/90935489
AI should not set the structure for ObjectCreate
https://bugs.webkit.org/show_bug.cgi?id=238349
Patch by Justin Michaud on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.
The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.2.4.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.2.4.0-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
Diff
Modified: branches/safari-613.2.4.0-branch/Source/_javascript_Core/ChangeLog (291995 => 291996)
--- branches/safari-613.2.4.0-branch/Source/_javascript_Core/ChangeLog 2022-03-28 22:18:09 UTC (rev 291995)
+++ branches/safari-613.2.4.0-branch/Source/_javascript_Core/ChangeLog 2022-03-28 22:20:21 UTC (rev 291996)
@@ -1,3 +1,36 @@
+2022-03-28 Alan Coon
+
+Cherry-pick r291891. rdar://problem/90935489
+
+AI should not set the structure for ObjectCreate
+https://bugs.webkit.org/show_bug.cgi?id=238349
+
+Patch by Justin Michaud on 2022-03-24
+Reviewed by Saam Barati and Yusuke Suzuki.
+
+The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
+the time the constant folding phase runs if the structure cache is cleared.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-24 Justin Michaud
+
+AI should not set the structure for ObjectCreate
+https://bugs.webkit.org/show_bug.cgi?id=238349
+
+Reviewed by Saam Barati and Yusuke Suzuki.
+
+The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
+the time the constant folding phase runs if the structure cache is cleared.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+
2022-03-21 Alan Coon
Cherry-pick r290981. rdar://problem/83326232
Modified: branches/safari-613.2.4.0-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (291995 => 291996)
--- branches/safari-613.2.4.0-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2022-03-28 22:18:09 UTC (rev 291995)
+++ branches/safari-613.2.4.0-branch/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2022-03-28 22:20:21 UTC (rev 291996)
@@ -3123,25 +3123,10 @@
}
case ObjectCreate: {
-if (JSValue base = forNode(node->child1()).m_value) {
-JSGlobalObject* globalObject = m_graph.globalObjectFor(node->origin.semantic);
-Structure* structure = nullptr;
-if (base.isNull())
-structure = globalObject->nullPrototypeObjectStructure();
-else if (base.isObject()) {
-// Having a bad time clears the structureCache, and so it should invalidate this structure.
-bool isHavingABadTime = globalObject->isHavingABadTime();
-// Normally, we would always install a watchpoint. In this case, however, if we haveABadTime, we
-// still want to optimize. There is no watchpoint for that case though, so we need to make sure this load
-// does not get hoisted above the check.
-WTF::loadLoadFence();
-if (!isHavingABadTime)
-m_graph.watchpoints().addLazily(globalObject->havingABadTimeWatchpoint());
-structure = m_vm.structureCache.emptyObjectStructureConcurrently(globalObject, base.getObject(), JSFinalObject::defaultInlineCapacity());
-}
-
-if (structure) {
-m_state.setShouldTryConstantFolding(true);
+if (JSValue prototype = forNode(node->child1()).m_value) {
+m_state.setShouldTryConstantFolding(true);
+if (prototype.isNull()) {
+Structure* structure = m_graph.globalObjectFor(node->origin.semantic)->nullPrototypeObjectStructure();
if (node->child1().useKind() == UntypedUse)
didFoldClobberWorld();
setForNode(node, structure);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291995] branches/safari-613.2.4.0-branch/Source
Title: [291995] branches/safari-613.2.4.0-branch/Source Revision 291995 Author alanc...@apple.com Date 2022-03-28 15:18:09 -0700 (Mon, 28 Mar 2022) Log Message Versioning. WebKit-7613.2.4.0.1 Modified Paths branches/safari-613.2.4.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.4.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.4.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (291994 => 291995) --- branches/safari-613.2.4.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 22:02:29 UTC (rev 291994) +++ branches/safari-613.2.4.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 22:18:09 UTC (rev 291995) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 4; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (291994 => 291995) --- branches/safari-613.2.4.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 22:02:29 UTC (rev 291994) +++ branches/safari-613.2.4.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 22:18:09 UTC (rev 291995) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 4; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (291994 => 291995) --- branches/safari-613.2.4.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 22:02:29 UTC (rev 291994) +++ branches/safari-613.2.4.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 22:18:09 UTC (rev 291995) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 4; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.0-branch/Source/WebCore/Configurations/Version.xcconfig (291994 => 291995) --- branches/safari-613.2.4.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 22:02:29 UTC (rev 291994) +++ branches/safari-613.2.4.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 22:18:09 UTC (rev 291995) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 4; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.4.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (291994 => 291995) --- branches/safari-613.2.4.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 22:02:29 UTC (rev 291994) +++ branches/safari-613.2.4.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 22:18:09 UTC (rev 291995) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 4; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are
[webkit-changes] [291994] trunk/Source/WebKit
Title: [291994] trunk/Source/WebKit
Revision 291994
Author hironori.fu...@sony.com
Date 2022-03-28 15:02:29 -0700 (Mon, 28 Mar 2022)
Log Message
Unreviewed build fix after 291979 for WinCairo and PlayStation Debug builds
https://bugs.webkit.org/show_bug.cgi?id=238400
> WebNotificationManager.cpp(153): error C2027: use of undefined type 'WebCore::Notification'
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Guarded the LOG with ENABLE(NOTIFICATIONS).
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (291993 => 291994)
--- trunk/Source/WebKit/ChangeLog 2022-03-28 21:53:02 UTC (rev 291993)
+++ trunk/Source/WebKit/ChangeLog 2022-03-28 22:02:29 UTC (rev 291994)
@@ -1,3 +1,13 @@
+2022-03-28 Fujii Hironori
+
+Unreviewed build fix after 291979 for WinCairo and PlayStation Debug builds
+https://bugs.webkit.org/show_bug.cgi?id=238400
+
+> WebNotificationManager.cpp(153): error C2027: use of undefined type 'WebCore::Notification'
+
+* WebProcess/Notifications/WebNotificationManager.cpp:
+(WebKit::WebNotificationManager::show): Guarded the LOG with ENABLE(NOTIFICATIONS).
+
2022-03-28 Chris Dumez
Prepare WebCore for making the String(const char*) constructor explicit
Modified: trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp (291993 => 291994)
--- trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp 2022-03-28 21:53:02 UTC (rev 291993)
+++ trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp 2022-03-28 22:02:29 UTC (rev 291994)
@@ -150,10 +150,10 @@
bool WebNotificationManager::show(Notification& notification, WebPage* page)
{
+#if ENABLE(NOTIFICATIONS)
LOG(Notifications, "WebProcess %i going to show notification %s", getpid(), notification.identifier().toString().utf8().data());
ASSERT(isMainRunLoop());
-#if ENABLE(NOTIFICATIONS)
if (page && !page->corePage()->settings().notificationsEnabled())
return false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291991] branches/safari-613.1.17.1-branch/Source
Title: [291991] branches/safari-613.1.17.1-branch/Source Revision 291991 Author alanc...@apple.com Date 2022-03-28 14:20:02 -0700 (Mon, 28 Mar 2022) Log Message Versioning. WebKit-7613.1.17.1.14 Modified Paths branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (291990 => 291991) --- branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 21:11:37 UTC (rev 291990) +++ branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 21:20:02 UTC (rev 291991) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 13; +NANO_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (291990 => 291991) --- branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 21:11:37 UTC (rev 291990) +++ branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 21:20:02 UTC (rev 291991) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 13; +NANO_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (291990 => 291991) --- branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 21:11:37 UTC (rev 291990) +++ branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 21:20:02 UTC (rev 291991) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 13; +NANO_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig (291990 => 291991) --- branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 21:11:37 UTC (rev 291990) +++ branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 21:20:02 UTC (rev 291991) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 13; +NANO_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (291990 => 291991) --- branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 21:11:37 UTC (rev 291990) +++ branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 21:20:02 UTC (rev 291991) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 13; +NANO_VERSION = 14; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig (291990 => 291991) --- branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-28 21:11:37 UTC (rev 291990) +++ branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-28 21:20:02 UTC (rev 291991) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 13;
[webkit-changes] [291990] trunk
Title: [291990] trunk Revision 291990 Author z...@igalia.com Date 2022-03-28 14:11:37 -0700 (Mon, 28 Mar 2022) Log Message [selection] Fire Select event when selection extent or direction changes https://bugs.webkit.org/show_bug.cgi?id=238142 Reviewed by Chris Dumez. LayoutTests/imported/w3c: Update test expectations as more sub-tests are now passing. * web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-expected.txt: * web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt: * web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt: Source/WebCore: As per step 6 at [1], if either extent or direction of the text control to be modified, we need to queue an element task on the user interaction task source given the element to fire an select event with the bubbles attribute initialized to true. [1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#set-the-selection-range * html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionRange): (WebCore::HTMLTextFormControlElement::cacheSelection): (WebCore::HTMLTextFormControlElement::restoreCachedSelection): (WebCore::HTMLTextFormControlElement::scheduleSelectEvent): * html/HTMLTextFormControlElement.h: (WebCore::HTMLTextFormControlElement::cacheSelection): Deleted. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp trunk/Source/WebCore/html/HTMLTextFormControlElement.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291989 => 291990) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-28 21:02:59 UTC (rev 291989) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-28 21:11:37 UTC (rev 291990) @@ -1,3 +1,15 @@ +2022-03-28 Ziran Sun + +[selection] Fire Select event when selection extent or direction changes +https://bugs.webkit.org/show_bug.cgi?id=238142 + +Reviewed by Chris Dumez. + +Update test expectations as more sub-tests are now passing. +* web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-expected.txt: +* web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt: +* web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt: + 2022-03-27 Matt Woodrow Preserve repeat() notation for grid-templates Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-expected.txt (291989 => 291990) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-expected.txt 2022-03-28 21:02:59 UTC (rev 291989) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-expected.txt 2022-03-28 21:11:37 UTC (rev 291990) @@ -1,6 +1,4 @@ -Harness Error (TIMEOUT), message = null - PASS Sanity check for testValue length; if this fails, variou absolute offsets in the test below need to be adjusted to be less than testValue.length PASS Initial .value set on input-appended should set selectionStart to end of value PASS Initial .value set on input-not-appended should set selectionStart to end of value @@ -19,25 +17,25 @@ PASS Initial .value set on textarea-appended-prefocused should set selectionEnd to end of value PASS Initial .value set on textarea-not-appended-prefocused should set selectionEnd to end of value PASS onselect should fire when selectionStart is changed -NOTRUN onselect should fire when selectionStart is changed on input-appended -NOTRUN onselect should fire when selectionStart is changed on input-not-appended -NOTRUN onselect should fire when selectionStart is changed on input-appended-prefocused -NOTRUN onselect should fire when selectionStart is changed on input-not-appended-prefocused -NOTRUN onselect should fire when selectionStart is changed on textarea-appended -NOTRUN onselect should fire when selectionStart is changed on textarea-not-appended -NOTRUN onselect should fire when selectionStart is changed on textarea-appended-prefocused -NOTRUN onselect should fire when selectionStart is changed on textarea-not-appended-prefocused -NOTRUN onselect should fire when selectionStart is changed on +PASS onselect should fire when selectionStart is changed on input-appended +PASS onselect should fire when
[webkit-changes] [291989] trunk/Tools
Title: [291989] trunk/Tools
Revision 291989
Author jbed...@apple.com
Date 2022-03-28 14:02:59 -0700 (Mon, 28 Mar 2022)
Log Message
[webkitbugspy] Support component and version in GitHub
https://bugs.webkit.org/show_bug.cgi?id=238086
Reviewed by Dewei Zhu.
GitHub issues do not have the concept of "component" and "version." However,
we can use label colors to divide labels into types.
* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker):
(Tracker.__init__): Add concept of color groups for version and components.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py:
(GitHub):
(GitHub.__init__):
(GitHub._labels): Sort labels and output project details as labels.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py:
(TestGitHub.test_create):
(TestGitHub.test_create_projects):
Canonical link: https://commits.webkit.org/248946@main
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitbugspy/setup.py
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py
trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (291988 => 291989)
--- trunk/Tools/ChangeLog 2022-03-28 20:58:18 UTC (rev 291988)
+++ trunk/Tools/ChangeLog 2022-03-28 21:02:59 UTC (rev 291989)
@@ -1,5 +1,29 @@
2022-03-28 Jonathan Bedard
+[webkitbugspy] Support component and version in GitHub
+https://bugs.webkit.org/show_bug.cgi?id=238086
+
+
+Reviewed by Dewei Zhu.
+
+GitHub issues do not have the concept of "component" and "version." However,
+we can use label colors to divide labels into types.
+
+* Scripts/libraries/webkitbugspy/setup.py: Bump version.
+* Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
+* Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
+(Tracker):
+(Tracker.__init__): Add concept of color groups for version and components.
+* Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py:
+(GitHub):
+(GitHub.__init__):
+(GitHub._labels): Sort labels and output project details as labels.
+* Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py:
+(TestGitHub.test_create):
+(TestGitHub.test_create_projects):
+
+2022-03-28 Jonathan Bedard
+
[git-webkit] Support —oneline in log command
https://bugs.webkit.org/show_bug.cgi?id=238209
Modified: trunk/Tools/Scripts/libraries/webkitbugspy/setup.py (291988 => 291989)
--- trunk/Tools/Scripts/libraries/webkitbugspy/setup.py 2022-03-28 20:58:18 UTC (rev 291988)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/setup.py 2022-03-28 21:02:59 UTC (rev 291989)
@@ -30,7 +30,7 @@
setup(
name='webkitbugspy',
-version='0.4.3',
+version='0.4.4',
description='Library containing a shared API for various bug trackers.',
long_description=readme(),
classifiers=[
Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py (291988 => 291989)
--- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py 2022-03-28 20:58:18 UTC (rev 291988)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py 2022-03-28 21:02:59 UTC (rev 291989)
@@ -46,7 +46,7 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
)
-version = Version(0, 4, 3)
+version = Version(0, 4, 4)
from .user import User
from .issue import Issue
Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py (291988 => 291989)
--- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py 2022-03-28 20:58:18 UTC (rev 291988)
+++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py 2022-03-28 21:02:59 UTC (rev 291989)
@@ -46,7 +46,10 @@
r'\Aapi.github.{}/repos/{}/{}/issues/(?P\d+)\Z',
]
REFRESH_TOKEN_PROMPT = "Is your API token out of date? Run 'git-webkit setup' to refresh credentials\n"
+DEFAULT_COMPONENT_COLOR = 'FF'
+DEFAULT_VERSION_COLOR = 'EE'
+
class Encoder(GenericTracker.Encoder):
@webkitcorepy.decorators.hybridmethod
def default(context, obj):
@@ -63,9 +66,12 @@
return super(Tracker.Encoder, context).default(obj)
-def __init__(self, url, users=None, res=None):
+def __init__(self, url, users=None, res=None, component_color=DEFAULT_COMPONENT_COLOR, version_color=DEFAULT_VERSION_COLOR):
super(Tracker, self).__init__(users=users)
+self.component_color = component_color
+self.version_color = version_color
+
match =
[webkit-changes] [291988] trunk/Source/WebKit
Title: [291988] trunk/Source/WebKit
Revision 291988
Author j_pas...@apple.com
Date 2022-03-28 13:58:18 -0700 (Mon, 28 Mar 2022)
Log Message
Adopt ASCPublicKeyCredentialCreationOptions's residentKeyPreference
https://bugs.webkit.org/show_bug.cgi?id=238387
rdar://problem/90845393
Reviewed by Brent Fulgham.
This patch passes along the residentKeyPreference to ASA, so it can be passed
back via _WKAuthenticatorSelectionCriteria.residentKey.
* Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::toASCResidentKeyPreference):
(WebKit::configureRegistrationRequestContext):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (291987 => 291988)
--- trunk/Source/WebKit/ChangeLog 2022-03-28 20:43:02 UTC (rev 291987)
+++ trunk/Source/WebKit/ChangeLog 2022-03-28 20:58:18 UTC (rev 291988)
@@ -1,3 +1,19 @@
+2022-03-28 J Pascoe
+
+Adopt ASCPublicKeyCredentialCreationOptions's residentKeyPreference
+https://bugs.webkit.org/show_bug.cgi?id=238387
+rdar://problem/90845393
+
+Reviewed by Brent Fulgham.
+
+This patch passes along the residentKeyPreference to ASA, so it can be passed
+back via _WKAuthenticatorSelectionCriteria.residentKey.
+
+* Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+(WebKit::toASCResidentKeyPreference):
+(WebKit::configureRegistrationRequestContext):
+
2022-03-28 Per Arne Vollan
[iOS] Fix sandbox violation related to Network content filtering
Modified: trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h (291987 => 291988)
--- trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2022-03-28 20:43:02 UTC (rev 291987)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h 2022-03-28 20:58:18 UTC (rev 291988)
@@ -183,6 +183,13 @@
ASCCredentialRequestTypeSecurityKeyPublicKeyAssertion = 1 << 5,
};
+typedef NS_ENUM(NSInteger, ASPublicKeyCredentialResidentKeyPreference) {
+ASPublicKeyCredentialResidentKeyPreferenceNotPresent,
+ASPublicKeyCredentialResidentKeyPreferenceDiscouraged,
+ASPublicKeyCredentialResidentKeyPreferencePreferred,
+ASPublicKeyCredentialResidentKeyPreferenceRequired,
+};
+
@interface ASCPublicKeyCredentialCreationOptions : NSObject
@property (nonatomic, nullable, copy) NSData *challenge;
@@ -198,6 +205,7 @@
@property (nonatomic, nullable, copy) NSNumber *timeout;
@property (nonatomic) BOOL shouldRequireResidentKey;
+@property (nonatomic) ASPublicKeyCredentialResidentKeyPreference residentKeyPreference;
@property (nonatomic, copy) NSArray *excludedCredentials;
@end
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (291987 => 291988)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm 2022-03-28 20:43:02 UTC (rev 291987)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm 2022-03-28 20:58:18 UTC (rev 291988)
@@ -182,6 +182,22 @@
}
}
+static inline ASPublicKeyCredentialResidentKeyPreference toASCResidentKeyPreference(std::optional requirement, bool requireResidentKey)
+{
+if (!requirement)
+return requireResidentKey ? ASPublicKeyCredentialResidentKeyPreferenceRequired : ASPublicKeyCredentialResidentKeyPreferenceNotPresent;
+switch (*requirement) {
+case ResidentKeyRequirement::Discouraged:
+return ASPublicKeyCredentialResidentKeyPreferenceDiscouraged;
+case ResidentKeyRequirement::Preferred:
+return ASPublicKeyCredentialResidentKeyPreferencePreferred;
+case ResidentKeyRequirement::Required:
+return ASPublicKeyCredentialResidentKeyPreferenceRequired;
+}
+ASSERT_NOT_REACHED();
+return ASPublicKeyCredentialResidentKeyPreferenceNotPresent;
+}
+
static RetainPtr configureRegistrationRequestContext(const PublicKeyCredentialCreationOptions& options, const Vector& hash, std::optional globalFrameID)
{
ASCCredentialRequestTypes requestTypes = ASCCredentialRequestTypePlatformPublicKeyRegistration | ASCCredentialRequestTypeSecurityKeyPublicKeyRegistration;
@@ -188,6 +204,7 @@
RetainPtr userVerification;
bool shouldRequireResidentKey = false;
+std::optional residentKeyRequirement;
std::optional authenticatorSelection = options.authenticatorSelection;
if (authenticatorSelection) {
std::optional attachment = authenticatorSelection->authenticatorAttachment;
@@ -199,6 +216,7 @@
userVerification = toNSString(authenticatorSelection->userVerification);
shouldRequireResidentKey =
[webkit-changes] [291987] trunk/Tools
Title: [291987] trunk/Tools
Revision 291987
Author jbed...@apple.com
Date 2022-03-28 13:43:02 -0700 (Mon, 28 Mar 2022)
Log Message
[git-webkit] Support —oneline in log command
https://bugs.webkit.org/show_bug.cgi?id=238209
Reviewed by Dewei Zhu.
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
(FilteredCommand): Header lines don't always start with 'commit'
(FilteredCommand.main): Handle --online output
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py:
(Log):
(Log.parser): Add various `git log` options.
(Log.main): Forward `git log` options.
Canonical link: https://commits.webkit.org/248944@main
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py
Diff
Modified: trunk/Tools/ChangeLog (291986 => 291987)
--- trunk/Tools/ChangeLog 2022-03-28 20:29:42 UTC (rev 291986)
+++ trunk/Tools/ChangeLog 2022-03-28 20:43:02 UTC (rev 291987)
@@ -1,3 +1,21 @@
+2022-03-28 Jonathan Bedard
+
+[git-webkit] Support —oneline in log command
+https://bugs.webkit.org/show_bug.cgi?id=238209
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
+(FilteredCommand): Header lines don't always start with 'commit'
+(FilteredCommand.main): Handle --online output
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py:
+(Log):
+(Log.parser): Add various `git log` options.
+(Log.main): Forward `git log` options.
+
2022-03-28 Devin Rousso
[iOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (291986 => 291987)
--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-03-28 20:29:42 UTC (rev 291986)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-03-28 20:43:02 UTC (rev 291987)
@@ -29,7 +29,7 @@
setup(
name='webkitscmpy',
-version='4.5.1',
+version='4.6.0',
description='Library designed to interact with git and svn repositories.',
long_description=readme(),
classifiers=[
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (291986 => 291987)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-03-28 20:29:42 UTC (rev 291986)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-03-28 20:43:02 UTC (rev 291987)
@@ -46,7 +46,7 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
)
-version = Version(4, 5, 1)
+version = Version(4, 6, 0)
AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
AutoInstall.register(Package('jinja2', Version(2, 11, 3)))
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py (291986 => 291987)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py 2022-03-28 20:29:42 UTC (rev 291986)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py 2022-03-28 20:43:02 UTC (rev 291987)
@@ -54,7 +54,7 @@
HASH = 'hash'
REVISION = 'revision'
-GIT_HEADER_RE = re.compile(r'^commit (?P[a-f0-9A-F]+)')
+GIT_HEADER_RE = re.compile(r'^(commit )?(?P[a-f0-9A-F]+)')
SVN_HEADER_RE = re.compile(r'^(?Pr/d+) | ')
REVISION_RES = (re.compile(r'^(?P\d+)\s'), re.compile(r'(?P[rR]\d+)'))
@@ -211,9 +211,9 @@
if representation == 'hash':
reference = reference[:Commit.HASH_LABEL_SIZE]
if mode == cls.APPEND_MODE:
-reference = '{} ({})'.format(match.group(1), reference)
+reference = '{} ({})'.format(match.groups()[-1], reference)
if mode == cls.HEADER_MODE:
-alternates = [] if match.group(1).startswith(reference) else [match.group(1)]
+alternates = [] if match.groups()[-1].startswith(reference) else [match.groups()[-1]]
for repr in {'revision', 'hash', 'identifier'} - {'hash' if repository.is_git else 'revision', representation}:
if repr in kwargs:
continue
@@ -224,7 +224,7 @@
other = other[:Commit.HASH_LABEL_SIZE]
alternates.append('r{}'.format(other) if isinstance(other, int) else other)
reference = '{} ({})'.format(reference, ', '.join(alternates))
-
[webkit-changes] [291985] branches/safari-614.1.8-branch
Title: [291985] branches/safari-614.1.8-branch Revision 291985 Author repst...@apple.com Date 2022-03-28 13:29:35 -0700 (Mon, 28 Mar 2022) Log Message Cherry-pick r291979. rdar://problem/90616651 Support ServiceWorkerClients.openWindow. and https://bugs.webkit.org/show_bug.cgi?id=238400 Reviewed by Youenn Fablet. Source/WebCore: Test: http/tests/workers/service/openwindow-from-notification-click.html * dom/Document.cpp: (WebCore::Document::pageID const): * page/ClientOrigin.h: (WebCore::ClientOrigin::loggingString const): * workers/service/ServiceWorkerClientData.cpp: (WebCore::ServiceWorkerClientData::isolatedCopy const): (WebCore::ServiceWorkerClientData::isolatedCopy): (WebCore::ServiceWorkerClientData::from): * workers/service/ServiceWorkerClientData.h: (WebCore::ServiceWorkerClientData::encode const): (WebCore::ServiceWorkerClientData::decode): * workers/service/ServiceWorkerClients.cpp: (WebCore::matchWindowWithPageIdentifier): (WebCore::ServiceWorkerClients::openWindow): * workers/service/context/SWContextManager.h: * workers/service/server/SWServerToContextConnection.h: * workers/service/server/SWServerWorker.h: Source/WebKit: This API asks the browser to asynchronously open a new tab to a URL then resolve a promise with the new WindowClient representing that tab. From a WebCore/WebKit standpoint, implementing this was mostly straightforward. 1 - A plumbing exercise (thread hopping and IPC'ing the message and its reply around) 2 - Implmenting a new delegate method for the hosting app to create the requested WKWebView The delegate method was interesting. Normally this is the type of thing that'd go to the WKUIDelegate but that requires there to be a WKWebView, and service workers can be running without any web views. Fortunately we already had a WKWebsiteDataStore delegate SPI, and service workers *do* always have an associated website data store they're running under. Once the app gives the new web view back to WebKit, we record its PageIdentifier in the reply. Once the reply makes its way all the way back to the ServiceWorker process and on the ServiceWorker thread, we do a client match and cross check with that PageIdentifier to make sure we're resolving the promise with the correct WindowClient. If there's no matched clients, then the view is either already gone or it has navigated away to a non-applicable URL. Same if there are matched clients, but they don't match the specified PageIdentifier. A straight forward layouttest completes the task. * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::controlClient): * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::openWindow): * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h: * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore set_delegate:]): * UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::openWindowFromServiceWorker): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared): (WebKit::WebPageProxy::callLoadCompletionHandlersIfNecessary): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::resetState): (WebKit::WebPageProxy::callServiceWorkerLaunchCompletionHandlerIfNecessary): Deleted. * UIProcess/WebPageProxy.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::openWindowFromServiceWorker): * UIProcess/WebsiteData/WebsiteDataStore.h: * UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::openWindowFromServiceWorker): * WebProcess/Notifications/WebNotificationManager.cpp: (WebKit::WebNotificationManager::show): (WebKit::WebNotificationManager::didShowNotification): (WebKit::WebNotificationManager::didClickNotification): * WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::openWindow): * WebProcess/Storage/WebSWContextManagerConnection.h: Source/WTF: * wtf/HashTable.h: (WTF::KeyTraits>::inlineLookup): Relax this value size requirement for now. The required refactoring is best left as a seperate task with a seperate patch. Tools: Implement the new delegate to create the new view. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createOtherPlatformWebView): *
[webkit-changes] [291984] trunk/LayoutTests
Title: [291984] trunk/LayoutTests Revision 291984 Author katherine_che...@apple.com Date 2022-03-28 13:17:35 -0700 (Mon, 28 Mar 2022) Log Message REGRESSION (r291587): [ iOS ] editing/deleting/insert-in-orphaned-selection-crash.html is a constant text failure (238282) https://bugs.webkit.org/show_bug.cgi?id=238282 Reviewed by Aditya Keerthi. In r291587 we started dropping native appearance for non-form control elements with specified author style. This is the correct behavior, but requires adjusting this test which relies on the appearance of a table element in order to reproduce a non-appearance related crash. This patch updates the test to add table data tags which ensure the table element gets included in the selectAll() command to keep the test passing. * editing/deleting/insert-in-orphaned-selection-crash.html: * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291983 => 291984) --- trunk/LayoutTests/ChangeLog 2022-03-28 19:40:01 UTC (rev 291983) +++ trunk/LayoutTests/ChangeLog 2022-03-28 20:17:35 UTC (rev 291984) @@ -1,3 +1,20 @@ +2022-03-28 Kate Cheney + +REGRESSION (r291587): [ iOS ] editing/deleting/insert-in-orphaned-selection-crash.html is a constant text failure (238282) +https://bugs.webkit.org/show_bug.cgi?id=238282 + + +Reviewed by Aditya Keerthi. + +In r291587 we started dropping native appearance for non-form control elements with +specified author style. This is the correct behavior, but requires adjusting this +test which relies on the appearance of a table element in order to reproduce a +non-appearance related crash. This patch updates the test to add table data tags which +ensure the table element gets included in the selectAll() command to keep the test passing. + +* editing/deleting/insert-in-orphaned-selection-crash.html: +* platform/ios-wk2/TestExpectations: + 2022-03-28 Brady Eidson Support ServiceWorkerClients.openWindow. Modified: trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html (291983 => 291984) --- trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html 2022-03-28 19:40:01 UTC (rev 291983) +++ trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html 2022-03-28 20:17:35 UTC (rev 291984) @@ -1,6 +1,7 @@* { -webkit-appearance:default-button; } tr { height: 10px; } + td { width: 100px; height: 100px; }
[webkit-changes] [291983] trunk/Source/WebCore
Title: [291983] trunk/Source/WebCore
Revision 291983
Author commit-qu...@webkit.org
Date 2022-03-28 12:40:01 -0700 (Mon, 28 Mar 2022)
Log Message
Accessing WebGL content crashes in macOS Recovery OS, workaround 2
https://bugs.webkit.org/show_bug.cgi?id=238448
Patch by Kimmo Kinnunen on 2022-03-28
Reviewed by Dean Jackson.
Add a two new quick workarounds to try fix a recovery OS crash when
WebKit tries to use ANGLE that is not present in the OS image.
Compare explicitly against NULL as instructed in weak linking documentation.
Check for the EGL_GetPlatformDisplayEXT, this is nullptr in the
recovery OS.
Remove the previous workaround. The environment variable is
not available in WP or GPUP. The Metal symbol is not the problem.
* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::platformSupportsMetal):
(WebCore::initializeEGLDisplay):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.cpp
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (291982 => 291983)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 19:33:54 UTC (rev 291982)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 19:40:01 UTC (rev 291983)
@@ -1,3 +1,23 @@
+2022-03-28 Kimmo Kinnunen
+
+Accessing WebGL content crashes in macOS Recovery OS, workaround 2
+https://bugs.webkit.org/show_bug.cgi?id=238448
+
+Reviewed by Dean Jackson.
+
+Add a two new quick workarounds to try fix a recovery OS crash when
+WebKit tries to use ANGLE that is not present in the OS image.
+Compare explicitly against NULL as instructed in weak linking documentation.
+Check for the EGL_GetPlatformDisplayEXT, this is nullptr in the
+recovery OS.
+
+Remove the previous workaround. The environment variable is
+not available in WP or GPUP. The Metal symbol is not the problem.
+
+* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
+(WebCore::platformSupportsMetal):
+(WebCore::initializeEGLDisplay):
+
2022-03-28 Chris Dumez
Speed up Element::removedFromAncestor()
Modified: trunk/Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.cpp (291982 => 291983)
--- trunk/Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.cpp 2022-03-28 19:33:54 UTC (rev 291982)
+++ trunk/Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.cpp 2022-03-28 19:40:01 UTC (rev 291983)
@@ -40,7 +40,7 @@
{
// The ANGLE is weak linked in full, and the EGL_Initialize is explicitly weak linked above
// so that we can detect the case where ANGLE is not present.
-return !!EGL_Initialize;
+return EGL_Initialize != NULL; // NOLINT
}
void* createPbufferAndAttachIOSurface(GCGLDisplay display, GCGLConfig config, GCGLenum target, GCGLint usageHint, GCGLenum internalFormat, GCGLsizei width, GCGLsizei height, GCGLenum type, IOSurfaceRef surface, GCGLuint plane)
Modified: trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm (291982 => 291983)
--- trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm 2022-03-28 19:33:54 UTC (rev 291982)
+++ trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm 2022-03-28 19:40:01 UTC (rev 291983)
@@ -58,8 +58,8 @@
#import "ImageRotationSessionVT.h"
#endif
-// Metal may not be available, for example in recovery OS.
-WTF_WEAK_LINK_FORCE_IMPORT(MTLCreateSystemDefaultDevice);
+// FIXME: Checking for EGL_Initialize does not seem to be robust in recovery OS.
+WTF_WEAK_LINK_FORCE_IMPORT(EGL_GetPlatformDisplayEXT);
namespace WebCore {
@@ -100,22 +100,6 @@
static bool platformSupportsMetal(bool isWebGL2)
{
-// FIXME: Figure out why WebKit runs in recovery system using -framework Metal, but seemingly cannot call into Metal.
-// The hunk about runnningInRecoverySystem should be removed once it is clear how WebKit can link strongly to Metal
-// but run without Metal.
-static bool runningInRecoverySystem = [] {
-if (getenv("__OSINSTALL_ENVIRONMENT")) {
-WTFLogAlways("WebGL: Running in recovery. Has access to Metal: %s", !MTLCreateSystemDefaultDevice ? "no" : "yes");
-return true;
-}
-return false;
-}();
-if (runningInRecoverySystem)
-return false;
-
-if (!MTLCreateSystemDefaultDevice)
-return false;
-
auto device = adoptNS(MTLCreateSystemDefaultDevice());
if (device) {
@@ -139,6 +123,12 @@
WTFLogAlways("Failed to load ANGLE shared library.");
return EGL_NO_DISPLAY;
}
+// FIXME(http://webkit.org/b/238448): Why is checking EGL_Initialize not robust in recovery OS?
+if (EGL_GetPlatformDisplayEXT == NULL) { // NOLINT
+WTFLogAlways("Inconsistent weak linking for ANGLE shared library.");
+return EGL_NO_DISPLAY;
+}
+
#if ASSERT_ENABLED
const char* clientExtensions =
[webkit-changes] [291982] trunk/Source/WebKit
Title: [291982] trunk/Source/WebKit Revision 291982 Author pvol...@apple.com Date 2022-03-28 12:33:54 -0700 (Mon, 28 Mar 2022) Log Message [iOS] Fix sandbox violation related to Network content filtering https://bugs.webkit.org/show_bug.cgi?id=238458 Reviewed by Brent Fulgham. After enabling Network content filtering in the Network process, a related sandbox rule should be moved to the Network process' sandbox. * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (291981 => 291982) --- trunk/Source/WebKit/ChangeLog 2022-03-28 18:45:53 UTC (rev 291981) +++ trunk/Source/WebKit/ChangeLog 2022-03-28 19:33:54 UTC (rev 291982) @@ -1,3 +1,17 @@ +2022-03-28 Per Arne Vollan + +[iOS] Fix sandbox violation related to Network content filtering +https://bugs.webkit.org/show_bug.cgi?id=238458 + + +Reviewed by Brent Fulgham. + +After enabling Network content filtering in the Network process, a related sandbox rule should +be moved to the Network process' sandbox. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + 2022-03-28 Devin Rousso [iOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in (291981 => 291982) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in 2022-03-28 18:45:53 UTC (rev 291981) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in 2022-03-28 19:33:54 UTC (rev 291982) @@ -138,6 +138,10 @@ (prefix "/private/var/db/com.apple.networkextension.") ) +#if ENABLE(CONTENT_FILTERING_IN_NETWORKING_PROCESS) +(allow file-read* (literal "/private/var/Managed Preferences/mobile/com.apple.webcontentfilter.plist")) +#endif + (allow mach-lookup (global-name "com.apple.AppSSO.service-xpc")) (deny ipc-posix-shm-read-data Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (291981 => 291982) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-03-28 18:45:53 UTC (rev 291981) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-03-28 19:33:54 UTC (rev 291982) @@ -1016,8 +1016,10 @@ ;; Allow loading injected bundles. (allow file-map-executable) +#if !ENABLE(CONTENT_FILTERING_IN_NETWORKING_PROCESS) ;; Allow ManagedPreference access (allow file-read* (literal "/private/var/Managed Preferences/mobile/com.apple.webcontentfilter.plist")) +#endif (allow file-read-data (literal "/usr/local/lib/log") ; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291981] trunk/Source/WebCore
Title: [291981] trunk/Source/WebCore
Revision 291981
Author cdu...@apple.com
Date 2022-03-28 11:45:53 -0700 (Mon, 28 Mar 2022)
Log Message
Speed up Element::removedFromAncestor()
https://bugs.webkit.org/show_bug.cgi?id=238404
Reviewed by Geoffrey Garen.
Speed up Element::removedFromAncestor() by inlining some of the functions it is calling.
This is a confirmed 1.5-2% progression on Speedometer on iMac 20,1.
* dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
(WebCore::Element::clearBeforePseudoElementSlow):
(WebCore::Element::clearAfterPseudoElementSlow):
(WebCore::Element::setSavedLayerScrollPositionSlow):
(WebCore::Element::clearBeforePseudoElement): Deleted.
(WebCore::Element::clearAfterPseudoElement): Deleted.
(WebCore::Element::setSavedLayerScrollPosition): Deleted.
* dom/Element.h:
(WebCore::Element::setSavedLayerScrollPosition):
(WebCore::Element::clearBeforePseudoElement):
(WebCore::Element::clearAfterPseudoElement):
* page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::elementWasRemovedSlow):
(WebCore::PointerCaptureController::elementWasRemoved): Deleted.
* page/PointerCaptureController.h:
(WebCore::PointerCaptureController::elementWasRemoved):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::elementWasRemovedInternal):
(WebCore::PointerLockController::elementWasRemoved): Deleted.
* page/PointerLockController.h:
(WebCore::PointerLockController::elementWasRemoved):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/page/PointerCaptureController.cpp
trunk/Source/WebCore/page/PointerCaptureController.h
trunk/Source/WebCore/page/PointerLockController.cpp
trunk/Source/WebCore/page/PointerLockController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (291980 => 291981)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 18:18:47 UTC (rev 291980)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 18:45:53 UTC (rev 291981)
@@ -1,3 +1,36 @@
+2022-03-28 Chris Dumez
+
+Speed up Element::removedFromAncestor()
+https://bugs.webkit.org/show_bug.cgi?id=238404
+
+Reviewed by Geoffrey Garen.
+
+Speed up Element::removedFromAncestor() by inlining some of the functions it is calling.
+This is a confirmed 1.5-2% progression on Speedometer on iMac 20,1.
+
+* dom/Element.cpp:
+(WebCore::Element::removedFromAncestor):
+(WebCore::Element::clearBeforePseudoElementSlow):
+(WebCore::Element::clearAfterPseudoElementSlow):
+(WebCore::Element::setSavedLayerScrollPositionSlow):
+(WebCore::Element::clearBeforePseudoElement): Deleted.
+(WebCore::Element::clearAfterPseudoElement): Deleted.
+(WebCore::Element::setSavedLayerScrollPosition): Deleted.
+* dom/Element.h:
+(WebCore::Element::setSavedLayerScrollPosition):
+(WebCore::Element::clearBeforePseudoElement):
+(WebCore::Element::clearAfterPseudoElement):
+* page/PointerCaptureController.cpp:
+(WebCore::PointerCaptureController::elementWasRemovedSlow):
+(WebCore::PointerCaptureController::elementWasRemoved): Deleted.
+* page/PointerCaptureController.h:
+(WebCore::PointerCaptureController::elementWasRemoved):
+* page/PointerLockController.cpp:
+(WebCore::PointerLockController::elementWasRemovedInternal):
+(WebCore::PointerLockController::elementWasRemoved): Deleted.
+* page/PointerLockController.h:
+(WebCore::PointerLockController::elementWasRemoved):
+
2022-03-28 Devin Rousso
[iOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units
Modified: trunk/Source/WebCore/dom/Element.cpp (291980 => 291981)
--- trunk/Source/WebCore/dom/Element.cpp 2022-03-28 18:18:47 UTC (rev 291980)
+++ trunk/Source/WebCore/dom/Element.cpp 2022-03-28 18:45:53 UTC (rev 291981)
@@ -2417,11 +2417,10 @@
if (hasPendingResources())
document().accessSVGExtensions().removeElementFromPendingResources(*this);
-RefPtr frame = document().frame();
Styleable::fromElement(*this).elementWasRemoved();
#if ENABLE(WHEEL_EVENT_LATCHING)
-if (frame && frame->page()) {
+if (RefPtr frame = document().frame(); frame && frame->page()) {
if (auto* scrollLatchingController = frame->page()->scrollLatchingControllerIfExists())
scrollLatchingController->removeLatchingStateForTarget(*this);
}
@@ -3741,18 +3740,16 @@
pseudoElement->clearHostElement();
}
-void Element::clearBeforePseudoElement()
+void Element::clearBeforePseudoElementSlow()
{
-if (!hasRareData())
-return;
+ASSERT(hasRareData());
disconnectPseudoElement(elementRareData()->beforePseudoElement());
elementRareData()->setBeforePseudoElement(nullptr);
}
-void Element::clearAfterPseudoElement()
+void Element::clearAfterPseudoElementSlow()
{
-if (!hasRareData())
[webkit-changes] [291980] trunk
Title: [291980] trunk Revision 291980 Author drou...@apple.com Date 2022-03-28 11:18:47 -0700 (Mon, 28 Mar 2022) Log Message [iOS] Add `WKWebView` API to control CSS "small viewport" `sv*` and "large viewport" `lv*` units https://bugs.webkit.org/show_bug.cgi?id=237979 Reviewed by Tim Horton. Source/WebCore: Tests: CSSViewportUnits.NegativeMinimumViewportInset CSSViewportUnits.NegativeMaximumViewportInset CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset CSSViewportUnits.MinimumViewportInsetLargerThanFrame CSSViewportUnits.MaximumViewportInsetLargerThanFrame CSSViewportUnits.MinimumViewportInset CSSViewportUnits.MaximumViewportInset CSSViewportUnits.MinimumViewportInsetWithZoom CSSViewportUnits.MaximumViewportInsetWithZoom CSSViewportUnits.MinimumViewportInsetWithWritingMode CSSViewportUnits.MaximumViewportInsetWithWritingMode CSSViewportUnits.MinimumViewportInsetWithFrame CSSViewportUnits.MaximumViewportInsetWithFrame CSSViewportUnits.MinimumViewportInsetWithBounds CSSViewportUnits.MaximumViewportInsetWithBounds CSSViewportUnits.MinimumViewportInsetWithContentInset CSSViewportUnits.MaximumViewportInsetWithContentInset CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI * page/FrameView.h: * page/FrameView.cpp: (WebCore::FrameView::performSizeToContentAutoSize): (WebCore::FrameView::enableAutoSizeMode): (WebCore::FrameView::clearSizeOverrideForCSSDefaultViewportUnits): Added. (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::sizeForCSSDefaultViewportUnits const): Renamed from `sizeForCSSDefaultViewportUnits`. (WebCore::FrameView::copyCSSViewportUnits const): Added. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" `v*` units. This allows for `WKWebView` clients to preserve existing behavior (where CSS "default viewport" `v*` units match the size of the `WKWebView`) while adding supporting CSS "small viewport" `sv*` units and CSS "large viewport" `lv*` units. Source/WebKit: Recently the W3C CSS working group added [some new unit types to CSS](https://drafts.csswg.org/css-values-4/#viewport-variants) with the goal of helping web developers better deal with browsers that have dynamic UI elements that change apperance/size/etc. based on user actions (e.g. the URL bar collapsing/"squishing" and expanding/"unsquishing" depending on whether the user has most recently scrolled/swiped down the page). These new units come in three categories: - the "large viewport" units (`lvw`, `lvh`, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their smallest state (e.g. when the URL bar is collapsed/"squished") - the "small viewport" units (`svw`, `svh`, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their largest state (e.g. when the URL bar is expanded/"unsquished") - the "dynamic viewport" units (`dvw`, `dvh`, etc.) each represent 1% of one dimension of the size of the current visual area of the page, which depends on the current state of all browser UI elements This way, developer could use `100svh` to ensure that no matter what state the browser UI elements are in the entire element will always be visible on the screen, or use `100dvh` to respond to browser UI element changes by automatically resizing various elements to always fully take advantage of the available space. Nothing needs to be added to support "dynamic viewport" `dv*` units as there already exists other methods to adjust the visual area of the `WKWebView` without adjusting its `frame` (e.g. `-[WKWebView setBounds:]`, `-[UIScrollView setContentInset:]`, etc.). But for "small viewport" `sv*` units and "large viewport" `lv*` units, however, there is unfortunately no way to tell a `WKWebView` anything like "this is the smallest/largest that this `WKWebView` will ever be", so there's no way to know ahead of time what the size of the visual area would be when all browser UI elements are in their smallest/largest state. As such, this patch adds a new API to allow for `WKWebView` clients to tell WebKit this information ahead of time. Note that there already exists the concept of "default viewport" units (`vw`, `vh`, etc.) that each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their default state. The behavior of these units remain the same,
[webkit-changes] [291979] trunk
Title: [291979] trunk Revision 291979 Author beid...@apple.com Date 2022-03-28 11:14:19 -0700 (Mon, 28 Mar 2022) Log Message Support ServiceWorkerClients.openWindow. and https://bugs.webkit.org/show_bug.cgi?id=238400 Reviewed by Youenn Fablet. Source/WebCore: Test: http/tests/workers/service/openwindow-from-notification-click.html * dom/Document.cpp: (WebCore::Document::pageID const): * page/ClientOrigin.h: (WebCore::ClientOrigin::loggingString const): * workers/service/ServiceWorkerClientData.cpp: (WebCore::ServiceWorkerClientData::isolatedCopy const): (WebCore::ServiceWorkerClientData::isolatedCopy): (WebCore::ServiceWorkerClientData::from): * workers/service/ServiceWorkerClientData.h: (WebCore::ServiceWorkerClientData::encode const): (WebCore::ServiceWorkerClientData::decode): * workers/service/ServiceWorkerClients.cpp: (WebCore::matchWindowWithPageIdentifier): (WebCore::ServiceWorkerClients::openWindow): * workers/service/context/SWContextManager.h: * workers/service/server/SWServerToContextConnection.h: * workers/service/server/SWServerWorker.h: Source/WebKit: This API asks the browser to asynchronously open a new tab to a URL then resolve a promise with the new WindowClient representing that tab. >From a WebCore/WebKit standpoint, implementing this was mostly straightforward. 1 - A plumbing exercise (thread hopping and IPC'ing the message and its reply around) 2 - Implmenting a new delegate method for the hosting app to create the requested WKWebView The delegate method was interesting. Normally this is the type of thing that'd go to the WKUIDelegate but that requires there to be a WKWebView, and service workers can be running without any web views. Fortunately we already had a WKWebsiteDataStore delegate SPI, and service workers *do* always have an associated website data store they're running under. Once the app gives the new web view back to WebKit, we record its PageIdentifier in the reply. Once the reply makes its way all the way back to the ServiceWorker process and on the ServiceWorker thread, we do a client match and cross check with that PageIdentifier to make sure we're resolving the promise with the correct WindowClient. If there's no matched clients, then the view is either already gone or it has navigated away to a non-applicable URL. Same if there are matched clients, but they don't match the specified PageIdentifier. A straight forward layouttest completes the task. * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::controlClient): * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::openWindow): * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h: * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore set_delegate:]): * UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::openWindowFromServiceWorker): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared): (WebKit::WebPageProxy::callLoadCompletionHandlersIfNecessary): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::resetState): (WebKit::WebPageProxy::callServiceWorkerLaunchCompletionHandlerIfNecessary): Deleted. * UIProcess/WebPageProxy.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::openWindowFromServiceWorker): * UIProcess/WebsiteData/WebsiteDataStore.h: * UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::openWindowFromServiceWorker): * WebProcess/Notifications/WebNotificationManager.cpp: (WebKit::WebNotificationManager::show): (WebKit::WebNotificationManager::didShowNotification): (WebKit::WebNotificationManager::didClickNotification): * WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::openWindow): * WebProcess/Storage/WebSWContextManagerConnection.h: Source/WTF: * wtf/HashTable.h: (WTF::KeyTraits>::inlineLookup): Relax this value size requirement for now. The required refactoring is best left as a seperate task with a seperate patch. Tools: Implement the new delegate to create the new view. * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createOtherPlatformWebView): * WebKitTestRunner/TestController.h: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateOtherPage): * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm: (-[TestWebsiteDataStoreDelegate websiteDataStore:openWindow:fromServiceWorkerOrigin:completionHandler:]): LayoutTests: WKTR knows how to openWindow() now. So test: - The success case - Failure due to a disallowed URL -
[webkit-changes] [291978] trunk/Source
Title: [291978] trunk/Source Revision 291978 Author commit-qu...@webkit.org Date 2022-03-28 10:58:11 -0700 (Mon, 28 Mar 2022) Log Message Some Apple internal clients fail to build due to redeclared AppKit types in WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=238368 Patch by Ian Anderson on 2022-03-28 Reviewed by Jonathan Bedard. Source/WebCore: Some Apple internal Mac Catalyst clients need to use both AppKit and WebKitLegacy. WebKitLegacy's redeclaration of AppKit types causes errors for those clients. Copy AppKit's Apple internal logic for identifying the special Mac Catalyst clients that are allowed to use the AppKit types, and when such clients use WebKitLegacy, don't redeclare the AppKit types. * platform/ios/KeyEventCodesIOS.h: * platform/ios/wak/WAKAppKitStubs.h: * platform/ios/wak/WAKView.h: * platform/ios/wak/WAKWindow.h: Source/WebKitLegacy/ios: WebKitLegacy can't always define NSView to WAKView in Mac Catalyst, but views are always WAKView in Mac Catalyst. Switch on TARGET_OS_IPHONE to declare WAKView explicitly. * WebView/WebUIKitDelegate.h: Source/WebKitLegacy/mac: WebKitLegacy can't always define NSClipView/NSView/NSScrollView/ NSWindow/NSResponder to their WAK counterparts in Mac Catalyst, but those types are always the WAK ones in Mac Catalyst. Switch on TARGET_OS_IPHONE to declare the WAK types explicitly. * Misc/WebDownload.h: * Misc/WebNSViewExtras.h: * Plugins/WebPluginDatabase.h: * WebView/WebDocument.h: * WebView/WebDocumentPrivate.h: * WebView/WebFramePrivate.h: * WebView/WebFrameView.h: (WEBKIT_CLASS_DEPRECATED_MAC): * WebView/WebFrameViewPrivate.h: * WebView/WebHTMLRepresentation.h: * WebView/WebHTMLRepresentationPrivate.h: * WebView/WebHTMLView.h: * WebView/WebHTMLViewPrivate.h: * WebView/WebUIDelegate.h: * WebView/WebUIDelegatePrivate.h: * WebView/WebView.h: (WEBKIT_CLASS_DEPRECATED_MAC): * WebView/WebViewPrivate.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ios/KeyEventCodesIOS.h trunk/Source/WebCore/platform/ios/wak/WAKAppKitStubs.h trunk/Source/WebCore/platform/ios/wak/WAKView.h trunk/Source/WebCore/platform/ios/wak/WAKWindow.h trunk/Source/WebKitLegacy/ios/ChangeLog trunk/Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Misc/WebDownload.h trunk/Source/WebKitLegacy/mac/Misc/WebNSViewExtras.h trunk/Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.h trunk/Source/WebKitLegacy/mac/WebView/WebDocument.h trunk/Source/WebKitLegacy/mac/WebView/WebDocumentPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebFramePrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.h trunk/Source/WebKitLegacy/mac/WebView/WebFrameViewPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.h trunk/Source/WebKitLegacy/mac/WebView/WebHTMLRepresentationPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.h trunk/Source/WebKitLegacy/mac/WebView/WebHTMLViewPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebUIDelegate.h trunk/Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebView.h trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h Diff Modified: trunk/Source/WebCore/ChangeLog (291977 => 291978) --- trunk/Source/WebCore/ChangeLog 2022-03-28 17:42:34 UTC (rev 291977) +++ trunk/Source/WebCore/ChangeLog 2022-03-28 17:58:11 UTC (rev 291978) @@ -1,3 +1,22 @@ +2022-03-28 Ian Anderson + +Some Apple internal clients fail to build due to redeclared AppKit types in WebKitLegacy +https://bugs.webkit.org/show_bug.cgi?id=238368 + +Reviewed by Jonathan Bedard. + +Some Apple internal Mac Catalyst clients need to use both AppKit and +WebKitLegacy. WebKitLegacy's redeclaration of AppKit types causes errors +for those clients. Copy AppKit's Apple internal logic for identifying +the special Mac Catalyst clients that are allowed to use the AppKit +types, and when such clients use WebKitLegacy, don't redeclare the +AppKit types. + +* platform/ios/KeyEventCodesIOS.h: +* platform/ios/wak/WAKAppKitStubs.h: +* platform/ios/wak/WAKView.h: +* platform/ios/wak/WAKWindow.h: + 2022-03-28 Chris Dumez Use StringView for Yarr / RegularExpression parsing Modified: trunk/Source/WebCore/platform/ios/KeyEventCodesIOS.h (291977 => 291978) --- trunk/Source/WebCore/platform/ios/KeyEventCodesIOS.h 2022-03-28 17:42:34 UTC (rev 291977) +++ trunk/Source/WebCore/platform/ios/KeyEventCodesIOS.h 2022-03-28 17:58:11 UTC (rev 291978) @@ -27,6 +27,12 @@ #if TARGET_OS_IPHONE +#import + +#if WAK_APPKIT_API_AVAILABLE_MACCATALYST +#import +#else + // Unicodes we reserve for function keys on the keyboard, // OpenStep reserves the range 0xF700-0xF8FF for this purpose. // The availability of various keys will be system dependent. @@ -105,7 +111,11 @@ NSHelpFunctionKey = 0xF746, NSModeSwitchFunctionKey
[webkit-changes] [291977] branches/safari-613.2.4.3-branch/
Title: [291977] branches/safari-613.2.4.3-branch/ Revision 291977 Author alanc...@apple.com Date 2022-03-28 10:42:34 -0700 (Mon, 28 Mar 2022) Log Message New branch. Added Paths branches/safari-613.2.4.3-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291976] branches/safari-613.2.4.2-branch/
Title: [291976] branches/safari-613.2.4.2-branch/ Revision 291976 Author alanc...@apple.com Date 2022-03-28 10:42:28 -0700 (Mon, 28 Mar 2022) Log Message New branch. Added Paths branches/safari-613.2.4.2-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291975] branches/safari-613.2.4.1-branch/
Title: [291975] branches/safari-613.2.4.1-branch/ Revision 291975 Author alanc...@apple.com Date 2022-03-28 10:42:23 -0700 (Mon, 28 Mar 2022) Log Message New branch. Added Paths branches/safari-613.2.4.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291974] branches/safari-613.2.4.0-branch/
Title: [291974] branches/safari-613.2.4.0-branch/ Revision 291974 Author alanc...@apple.com Date 2022-03-28 10:42:11 -0700 (Mon, 28 Mar 2022) Log Message New branch. Added Paths branches/safari-613.2.4.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291973] branches/safari-613.1.17.0-branch
Title: [291973] branches/safari-613.1.17.0-branch
Revision 291973
Author alanc...@apple.com
Date 2022-03-28 10:29:42 -0700 (Mon, 28 Mar 2022)
Log Message
Cherry-pick r291622. rdar://problem/90501108
Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170
Reviewed by Eric Carlson.
Source/WebCore:
Test: fetch/fetch-blob-unbounded-range.html
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
Source/WebKit:
Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.
* NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
LayoutTests:
* fetch/fetch-blob-unbounded-range-expected.txt: Added.
* fetch/fetch-blob-unbounded-range.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-613.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-613.1.17.0-branch/Source/WebCore/platform/network/BlobResourceHandle.cpp
branches/safari-613.1.17.0-branch/Source/WebKit/ChangeLog
branches/safari-613.1.17.0-branch/Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp
Added Paths
branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt
branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html
Diff
Modified: branches/safari-613.1.17.0-branch/LayoutTests/ChangeLog (291972 => 291973)
--- branches/safari-613.1.17.0-branch/LayoutTests/ChangeLog 2022-03-28 17:25:14 UTC (rev 291972)
+++ branches/safari-613.1.17.0-branch/LayoutTests/ChangeLog 2022-03-28 17:29:42 UTC (rev 291973)
@@ -1,3 +1,48 @@
+2022-03-28 Alan Coon
+
+Cherry-pick r291622. rdar://problem/90501108
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+Source/WebCore:
+
+Test: fetch/fetch-blob-unbounded-range.html
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* platform/network/BlobResourceHandle.cpp:
+(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
+
+Source/WebKit:
+
+Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
+to pass into ParsedContentRange.
+
+* NetworkProcess/NetworkDataTaskBlob.cpp:
+(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):
+
+LayoutTests:
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-22 Jer Noble
+
+Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
+https://bugs.webkit.org/show_bug.cgi?id=238170
+
+Reviewed by Eric Carlson.
+
+* fetch/fetch-blob-unbounded-range-expected.txt: Added.
+* fetch/fetch-blob-unbounded-range.html: Added.
+
2022-02-18 Russell Epstein
Cherry-pick r290156. rdar://problem/89154452
Added: branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (0 => 291973)
--- branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt (rev 0)
+++ branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range-expected.txt 2022-03-28 17:29:42 UTC (rev 291973)
@@ -0,0 +1,4 @@
+
+PASS Bounded range request
+PASS Unbounded range request
+
Added: branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (0 => 291973)
--- branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html (rev 0)
+++ branches/safari-613.1.17.0-branch/LayoutTests/fetch/fetch-blob-unbounded-range.html 2022-03-28 17:29:42 UTC (rev 291973)
@@ -0,0 +1,24 @@
+
+
+
+
+
+let buffer = Uint8Array.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
+let blob = new Blob([buffer]);
+let blobURL = URL.createObjectURL(blob);
+
+promise_test(async () => {
+let response = await fetch(blobURL, {headers: new Headers({'Range': 'bytes=0-1'})});
+assert_equals(response.status, 206);
+assert_equals(response.headers.get('Content-Length'), '2');
+assert_equals(response.headers.get('Content-Range'), 'bytes
[webkit-changes] [291971] branches/safari-613.1.17.0-branch/Source
Title: [291971] branches/safari-613.1.17.0-branch/Source Revision 291971 Author alanc...@apple.com Date 2022-03-28 10:25:08 -0700 (Mon, 28 Mar 2022) Log Message Versioning. WebKit-7613.1.17.0.9 Modified Paths branches/safari-613.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.17.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (291970 => 291971) --- branches/safari-613.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 17:04:12 UTC (rev 291970) +++ branches/safari-613.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-28 17:25:08 UTC (rev 291971) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (291970 => 291971) --- branches/safari-613.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 17:04:12 UTC (rev 291970) +++ branches/safari-613.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-28 17:25:08 UTC (rev 291971) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (291970 => 291971) --- branches/safari-613.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 17:04:12 UTC (rev 291970) +++ branches/safari-613.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-28 17:25:08 UTC (rev 291971) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig (291970 => 291971) --- branches/safari-613.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 17:04:12 UTC (rev 291970) +++ branches/safari-613.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-28 17:25:08 UTC (rev 291971) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (291970 => 291971) --- branches/safari-613.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 17:04:12 UTC (rev 291970) +++ branches/safari-613.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-28 17:25:08 UTC (rev 291971) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.0-branch/Source/WebGPU/Configurations/Version.xcconfig (291970 => 291971) --- branches/safari-613.1.17.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-28 17:04:12 UTC (rev 291970) +++ branches/safari-613.1.17.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-28 17:25:08 UTC (rev 291971) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 0; -NANO_VERSION = 8; +NANO_VERSION
[webkit-changes] [291972] trunk/Source
Title: [291972] trunk/Source
Revision 291972
Author cdu...@apple.com
Date 2022-03-28 10:25:14 -0700 (Mon, 28 Mar 2022)
Log Message
Use StringView for Yarr / RegularExpression parsing
https://bugs.webkit.org/show_bug.cgi?id=238420
Reviewed by Sam Weinig.
Source/_javascript_Core:
Use StringView for Yarr / RegularExpression parsing, to avoid unnecessary String construction
in some cases. It is not uncommon for the pattern to be a string literal.
* yarr/RegularExpression.cpp:
(JSC::Yarr::RegularExpression::Private::create):
(JSC::Yarr::RegularExpression::Private::Private):
(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::RegularExpression):
(JSC::Yarr::RegularExpression::match const):
(JSC::Yarr::RegularExpression::searchRev const):
(JSC::Yarr::replace):
* yarr/RegularExpression.h:
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::interpret):
* yarr/YarrInterpreter.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::jitCompile):
(JSC::Yarr::jitCompileInlinedTest):
* yarr/YarrJIT.h:
* yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
(JSC::Yarr::YarrPattern::dumpPatternString):
(JSC::Yarr::YarrPattern::dumpPattern):
* yarr/YarrPattern.h:
* yarr/YarrSyntaxChecker.cpp:
(JSC::Yarr::checkSyntax):
* yarr/YarrSyntaxChecker.h:
Source/WebCore:
* platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::parseKeySystem):
Source/WTF:
Add convenience characters() templated function to StringView, to match String and StringImpl.
* wtf/text/StringView.h:
(WTF::StringView::characters const):
(WTF::StringView::characters const):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/RegularExpression.cpp
trunk/Source/_javascript_Core/yarr/RegularExpression.h
trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp
trunk/Source/_javascript_Core/yarr/YarrInterpreter.h
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
trunk/Source/_javascript_Core/yarr/YarrJIT.h
trunk/Source/_javascript_Core/yarr/YarrParser.h
trunk/Source/_javascript_Core/yarr/YarrPattern.cpp
trunk/Source/_javascript_Core/yarr/YarrPattern.h
trunk/Source/_javascript_Core/yarr/YarrSyntaxChecker.cpp
trunk/Source/_javascript_Core/yarr/YarrSyntaxChecker.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringView.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291971 => 291972)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-28 17:25:08 UTC (rev 291971)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-28 17:25:14 UTC (rev 291972)
@@ -1,3 +1,42 @@
+2022-03-28 Chris Dumez
+
+Use StringView for Yarr / RegularExpression parsing
+https://bugs.webkit.org/show_bug.cgi?id=238420
+
+Reviewed by Sam Weinig.
+
+Use StringView for Yarr / RegularExpression parsing, to avoid unnecessary String construction
+in some cases. It is not uncommon for the pattern to be a string literal.
+
+* yarr/RegularExpression.cpp:
+(JSC::Yarr::RegularExpression::Private::create):
+(JSC::Yarr::RegularExpression::Private::Private):
+(JSC::Yarr::RegularExpression::Private::compile):
+(JSC::Yarr::RegularExpression::RegularExpression):
+(JSC::Yarr::RegularExpression::match const):
+(JSC::Yarr::RegularExpression::searchRev const):
+(JSC::Yarr::replace):
+* yarr/RegularExpression.h:
+* yarr/YarrInterpreter.cpp:
+(JSC::Yarr::interpret):
+* yarr/YarrInterpreter.h:
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::jitCompile):
+(JSC::Yarr::jitCompileInlinedTest):
+* yarr/YarrJIT.h:
+* yarr/YarrParser.h:
+(JSC::Yarr::Parser::Parser):
+(JSC::Yarr::parse):
+* yarr/YarrPattern.cpp:
+(JSC::Yarr::YarrPattern::compile):
+(JSC::Yarr::YarrPattern::YarrPattern):
+(JSC::Yarr::YarrPattern::dumpPatternString):
+(JSC::Yarr::YarrPattern::dumpPattern):
+* yarr/YarrPattern.h:
+* yarr/YarrSyntaxChecker.cpp:
+(JSC::Yarr::checkSyntax):
+* yarr/YarrSyntaxChecker.h:
+
2022-03-27 Lauro Moura
Unreviewed, non-unified buildfix
Modified: trunk/Source/_javascript_Core/yarr/RegularExpression.cpp (291971 => 291972)
--- trunk/Source/_javascript_Core/yarr/RegularExpression.cpp 2022-03-28 17:25:08 UTC (rev 291971)
+++ trunk/Source/_javascript_Core/yarr/RegularExpression.cpp 2022-03-28 17:25:14 UTC (rev 291972)
@@ -38,18 +38,18 @@
class RegularExpression::Private : public RefCounted {
public:
-static Ref create(const String& pattern, TextCaseSensitivity caseSensitivity, MultilineMode multilineMode, UnicodeMode unicodeMode)
+static Ref create(StringView pattern, TextCaseSensitivity caseSensitivity, MultilineMode
[webkit-changes] [291970] trunk/Source/WebCore
Title: [291970] trunk/Source/WebCore
Revision 291970
Author dp...@igalia.com
Date 2022-03-28 10:04:12 -0700 (Mon, 28 Mar 2022)
Log Message
[GLIB] Fix build error 'not match operator !=' in Ubuntu LTS after r291696
https://bugs.webkit.org/show_bug.cgi?id=238443
Reviewed by Adrian Perez de Castro.
The error was also happening in build bots using GCC 8.3 like Debian
Stable.
* platform/graphics/GraphicsTypes.h:
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CompositeMode::operator==): Deleted.
* platform/graphics/SourceBrush.h:
(WebCore::operator!=):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsTypes.h
trunk/Source/WebCore/platform/graphics/SourceBrush.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (291969 => 291970)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 16:43:04 UTC (rev 291969)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 17:04:12 UTC (rev 291970)
@@ -1,3 +1,20 @@
+2022-03-28 Diego Pino Garcia
+
+[GLIB] Fix build error 'not match operator !=' in Ubuntu LTS after r291696
+https://bugs.webkit.org/show_bug.cgi?id=238443
+
+Reviewed by Adrian Perez de Castro.
+
+The error was also happening in build bots using GCC 8.3 like Debian
+Stable.
+
+* platform/graphics/GraphicsTypes.h:
+(WebCore::operator==):
+(WebCore::operator!=):
+(WebCore::CompositeMode::operator==): Deleted.
+* platform/graphics/SourceBrush.h:
+(WebCore::operator!=):
+
2022-03-28 Youenn Fablet
ImageTransferSessionVT::setSize should properly create its buffer pool
Modified: trunk/Source/WebCore/platform/graphics/GraphicsTypes.h (291969 => 291970)
--- trunk/Source/WebCore/platform/graphics/GraphicsTypes.h 2022-03-28 16:43:04 UTC (rev 291969)
+++ trunk/Source/WebCore/platform/graphics/GraphicsTypes.h 2022-03-28 17:04:12 UTC (rev 291970)
@@ -80,15 +80,20 @@
CompositeOperator operation;
BlendMode blendMode;
-bool operator==(const CompositeMode& other)
-{
-return operation == other.operation && blendMode == other.blendMode;
-}
-
template void encode(Encoder&) const;
template static std::optional decode(Decoder&);
};
+inline bool operator==(const CompositeMode& a, const CompositeMode& b)
+{
+return a.operation == b.operation && a.blendMode == b.blendMode;
+}
+
+inline bool operator!=(const CompositeMode& a, const CompositeMode& b)
+{
+return !(a == b);
+}
+
template
void CompositeMode::encode(Encoder& encoder) const
{
@@ -175,6 +180,11 @@
return a.offset == b.offset && a.blurRadius == b.blurRadius && a.color == b.color && a.radiusMode == b.radiusMode;
}
+inline bool operator!=(const DropShadow& a, const DropShadow& b)
+{
+return !(a == b);
+}
+
template
void DropShadow::encode(Encoder& encoder) const
{
Modified: trunk/Source/WebCore/platform/graphics/SourceBrush.h (291969 => 291970)
--- trunk/Source/WebCore/platform/graphics/SourceBrush.h 2022-03-28 16:43:04 UTC (rev 291969)
+++ trunk/Source/WebCore/platform/graphics/SourceBrush.h 2022-03-28 17:04:12 UTC (rev 291970)
@@ -79,6 +79,11 @@
return a.gradient.ptr() == b.gradient.ptr() && a.spaceTransform == b.spaceTransform;
}
+inline bool operator!=(const SourceBrush::Brush::LogicalGradient& a, const SourceBrush::Brush::LogicalGradient& b)
+{
+return !(a == b);
+}
+
inline bool operator==(const SourceBrush::Brush& a, const SourceBrush::Brush& b)
{
return WTF::switchOn(a.brush,
@@ -95,11 +100,21 @@
);
}
+inline bool operator!=(const SourceBrush::Brush& a, const SourceBrush::Brush& b)
+{
+return !(a == b);
+}
+
inline bool operator==(const SourceBrush& a, const SourceBrush& b)
{
return a.color() == b.color() && a.brush() == b.brush();
}
+inline bool operator!=(const SourceBrush& a, const SourceBrush& b)
+{
+return !(a == b);
+}
+
template
void SourceBrush::Brush::LogicalGradient::encode(Encoder& encoder) const
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291969] trunk/Source/WebCore
Title: [291969] trunk/Source/WebCore
Revision 291969
Author you...@apple.com
Date 2022-03-28 09:43:04 -0700 (Mon, 28 Mar 2022)
Log Message
ImageTransferSessionVT::setSize should properly create its buffer pool
https://bugs.webkit.org/show_bug.cgi?id=238455
Reviewed by Eric Carlson.
Covered by existing tests.
* platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::setSize):
We check the Expected, then move the RetainPtr if available.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (291968 => 291969)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 16:28:57 UTC (rev 291968)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 16:43:04 UTC (rev 291969)
@@ -1,3 +1,16 @@
+2022-03-28 Youenn Fablet
+
+ImageTransferSessionVT::setSize should properly create its buffer pool
+https://bugs.webkit.org/show_bug.cgi?id=238455
+
+Reviewed by Eric Carlson.
+
+Covered by existing tests.
+
+* platform/graphics/cv/ImageTransferSessionVT.mm:
+(WebCore::ImageTransferSessionVT::setSize):
+We check the Expected, then move the RetainPtr if available.
+
2022-03-28 Tyler Wilcock
AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
Modified: trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm (291968 => 291969)
--- trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm 2022-03-28 16:28:57 UTC (rev 291968)
+++ trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm 2022-03-28 16:43:04 UTC (rev 291969)
@@ -77,10 +77,10 @@
{
if (m_size == size && m_outputBufferPool)
return true;
-auto bufferPool = createCVPixelBufferPool(size.width(), size.height(), m_pixelFormat, 6, false, m_shouldUseIOSurface).value_or(nullptr);
+auto bufferPool = createCVPixelBufferPool(size.width(), size.height(), m_pixelFormat, 6, false, m_shouldUseIOSurface);
if (!bufferPool)
return false;
-m_outputBufferPool = WTFMove(bufferPool);
+m_outputBufferPool = WTFMove(*bufferPool);
m_size = size;
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291968] trunk/Source/WebCore
Title: [291968] trunk/Source/WebCore
Revision 291968
Author tyle...@apple.com
Date 2022-03-28 09:28:57 -0700 (Mon, 28 Mar 2022)
Log Message
AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
https://bugs.webkit.org/show_bug.cgi?id=238341
Reviewed by Andres Gonzalez.
The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given range `isStartOfLine`. We
should instead check if there's an actual list item to work with
before doing this, since `isStartOfLine` can cause crashes.
Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291967 => 291968)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 16:24:10 UTC (rev 291967)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 16:28:57 UTC (rev 291968)
@@ -1,3 +1,21 @@
+2022-03-28 Tyler Wilcock
+
+AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
+https://bugs.webkit.org/show_bug.cgi?id=238341
+
+Reviewed by Andres Gonzalez.
+
+The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
+does is check to see that the given range `isStartOfLine`. We
+should instead check if there's an actual list item to work with
+before doing this, since `isStartOfLine` can cause crashes.
+
+Covered by test
+accessibility/mac/attributed-string-with-listitem-multiple-lines.html.
+
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
+
2022-03-28 Youenn Fablet
Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (291967 => 291968)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2022-03-28 16:24:10 UTC (rev 291967)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2022-03-28 16:28:57 UTC (rev 291968)
@@ -1455,17 +1455,13 @@
// Returns the text associated with a list marker if this node is contained within a list item.
String AccessibilityObject::listMarkerTextForNodeAndPosition(Node* node, const VisiblePosition& visiblePositionStart)
{
-// If the range does not contain the start of the line, the list marker text should not be included.
-if (!isStartOfLine(visiblePositionStart))
-return String();
+auto* listItem = renderListItemContainerForNode(node);
+if (!listItem)
+return { };
+// Only include the list marker if the range includes the line start (where the marker would be), and is in the same line as the marker.
+if (!isStartOfLine(visiblePositionStart) || !inSameLine(visiblePositionStart, firstPositionInNode(>element(
+return { };
-// We should speak the list marker only for the first line.
-RenderListItem* listItem = renderListItemContainerForNode(node);
-if (!listItem)
-return String();
-if (!inSameLine(visiblePositionStart, firstPositionInNode(>element(
-return String();
-
return listMarkerTextForNode(node);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291967] trunk/Source
Title: [291967] trunk/Source
Revision 291967
Author you...@apple.com
Date 2022-03-28 09:24:10 -0700 (Mon, 28 Mar 2022)
Log Message
Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource
https://bugs.webkit.org/show_bug.cgi?id=237704
Reviewed by Eric Carlson.
Source/WebCore:
The remote video source is now correctly exposing whether it is camera, screen...
This was not well handled before in some places, we replace type == Video by hasVideo to handle all video types appropriately.
Covered by existing tests.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
* platform/mediastream/MediaStreamPrivate.cpp:
Source/WebKit:
Introduce RemoteRealtimeMediaSource as a common class for RemoteRealtimeAudioSource and RemoteRealtimeVideoSource.
* SourcesCocoa.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/cocoa/RemoteRealtimeAudioSource.cpp:
* WebProcess/cocoa/RemoteRealtimeAudioSource.h:
* WebProcess/cocoa/RemoteRealtimeMediaSource.cpp: Added.
* WebProcess/cocoa/RemoteRealtimeMediaSource.h: Added.
* WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
* WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
* WebProcess/cocoa/RemoteRealtimeVideoSource.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
trunk/Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeAudioSource.cpp
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeAudioSource.h
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.cpp
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.h
Added Paths
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp
trunk/Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (291966 => 291967)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 15:13:14 UTC (rev 291966)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 16:24:10 UTC (rev 291967)
@@ -1,3 +1,19 @@
+2022-03-28 Youenn Fablet
+
+Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource
+https://bugs.webkit.org/show_bug.cgi?id=237704
+
+
+Reviewed by Eric Carlson.
+
+The remote video source is now correctly exposing whether it is camera, screen...
+This was not well handled before in some places, we replace type == Video by hasVideo to handle all video types appropriately.
+
+Covered by existing tests.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+* platform/mediastream/MediaStreamPrivate.cpp:
+
2022-03-28 Chris Dumez
Optimize toJS() for HTMLElements
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (291966 => 291967)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2022-03-28 15:13:14 UTC (rev 291966)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2022-03-28 16:24:10 UTC (rev 291967)
@@ -822,15 +822,21 @@
Configure
};
+enum class TrackKind {
+Audio,
+Video
+};
+
template
-void updateTracksOfType(HashMap& trackMap, RealtimeMediaSource::Type trackType, MediaStreamTrackPrivateVector& currentTracks, RefT (*itemFactory)(MediaStreamTrackPrivate&), const Function::type>, int, TrackState)>& configureTrack)
+void updateTracksOfKind(HashMap& trackMap, TrackKind trackKind, MediaStreamTrackPrivateVector& currentTracks, RefT (*itemFactory)(MediaStreamTrackPrivate&), const Function::type>, int, TrackState)>& configureTrack)
{
Vector removedTracks;
Vector addedTracks;
Vector> addedPrivateTracks;
+bool wantsVideo = trackKind == TrackKind::Video;
for (const auto& track : currentTracks) {
-if (track->type() != trackType)
+if (wantsVideo != track->hasVideo())
continue;
if (!trackMap.contains(track->id()))
@@ -941,7 +947,7 @@
break;
}
};
-updateTracksOfType(m_audioTrackMap, RealtimeMediaSource::Type::Audio, currentTracks, ::create, WTFMove(setAudioTrackState));
+updateTracksOfKind(m_audioTrackMap, TrackKind::Audio, currentTracks, ::create, WTFMove(setAudioTrackState));
if (!m_player->isVideoPlayer())
return;
@@ -966,7 +972,7 @@
break;
}
};
-updateTracksOfType(m_videoTrackMap, RealtimeMediaSource::Type::Video, currentTracks, ::create, WTFMove(setVideoTrackState));
+
[webkit-changes] [291966] trunk/Tools
Title: [291966] trunk/Tools
Revision 291966
Author n...@webkit.org
Date 2022-03-28 08:13:14 -0700 (Mon, 28 Mar 2022)
Log Message
Issues with WPT exporter
https://bugs.webkit.org/show_bug.cgi?id=238446
Also addresses https://bugs.webkit.org/show_bug.cgi?id=216330
and https://bugs.webkit.org/show_bug.cgi?id=216603
Reviewed by Youenn Fablet.
Fix issues with WPT exporter:
- Ignore *-expected.html files
- Perform a 3-way merge when applying patch
- Add a newline at the end of the patch
* Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter._strip_ignored_files_from_diff):
(WebPlatformTestExporter.create_branch_with_patch):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py
trunk/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (291965 => 291966)
--- trunk/Tools/ChangeLog 2022-03-28 14:51:41 UTC (rev 291965)
+++ trunk/Tools/ChangeLog 2022-03-28 15:13:14 UTC (rev 291966)
@@ -1,3 +1,22 @@
+2022-03-28 Noam Rosenthal
+
+Issues with WPT exporter
+https://bugs.webkit.org/show_bug.cgi?id=238446
+
+Also addresses https://bugs.webkit.org/show_bug.cgi?id=216330
+and https://bugs.webkit.org/show_bug.cgi?id=216603
+
+Reviewed by Youenn Fablet.
+
+Fix issues with WPT exporter:
+- Ignore *-expected.html files
+- Perform a 3-way merge when applying patch
+- Add a newline at the end of the patch
+
+* Scripts/webkitpy/w3c/test_exporter.py:
+(WebPlatformTestExporter._strip_ignored_files_from_diff):
+(WebPlatformTestExporter.create_branch_with_patch):
+
2022-03-28 Aakash Jain
[ews] Update contributors in ews unit tests
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py (291965 => 291966)
--- trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py 2022-03-28 14:51:41 UTC (rev 291965)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py 2022-03-28 15:13:14 UTC (rev 291966)
@@ -52,7 +52,7 @@
WPT_PR_URL = "%s/pull/" % WPT_GH_URL
WEBKIT_EXPORT_PR_LABEL = 'webkit-export'
-EXCLUDED_FILE_SUFFIXES = ['-expected.txt', '.worker.html', '.any.html', '.any.worker.html', 'w3c-import.log']
+EXCLUDED_FILE_SUFFIXES = ['-expected.txt', '-expected.html', '.worker.html', '.any.html', '.any.worker.html', 'w3c-import.log']
class WebPlatformTestExporter(object):
@@ -179,7 +179,7 @@
if include_file:
new_lines.append(line)
-return b'\n'.join(new_lines)
+return b'\n'.join(new_lines) + b'\n'
def write_git_patch_file(self):
_, patch_file = self._filesystem.open_binary_tempfile('wpt_export_patch')
@@ -304,7 +304,7 @@
self._git.delete_branch(self._branch_name)
self._git.checkout_new_branch(self._branch_name)
try:
-self._git.apply_mail_patch([patch])
+self._git.apply_mail_patch([patch, '-3'])
except Exception as e:
_log.warning(e)
return False
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py (291965 => 291966)
--- trunk/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py 2022-03-28 14:51:41 UTC (rev 291965)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py 2022-03-28 15:13:14 UTC (rev 291966)
@@ -138,7 +138,7 @@
'checkout master',
'reset hard origin/master',
'checkout new branch wpt-export-for-webkit-1234',
-'apply_mail_patch patch.temp ',
+'apply_mail_patch patch.temp -3',
'commit -a -m WebKit export of https://bugs.webkit.org/show_bug.cgi?id=1234',
'remote ',
'remote add USER https://u...@github.com/USER/wpt.git',
@@ -166,7 +166,7 @@
'checkout master',
'reset hard origin/master',
'checkout new branch wpt-export-for-webkit-1234',
-'apply_mail_patch patch.temp ',
+'apply_mail_patch patch.temp -3',
'commit -a -m WebKit export of https://bugs.webkit.org/show_bug.cgi?id=1234',
'remote ',
'remote add USER https://u...@github.com/USER/wpt.git',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291965] trunk/Tools
Title: [291965] trunk/Tools
Revision 291965
Author aakash_j...@apple.com
Date 2022-03-28 07:51:41 -0700 (Mon, 28 Mar 2022)
Log Message
[ews] Update contributors in ews unit tests
https://bugs.webkit.org/show_bug.cgi?id=238416
Reviewed by Jonathan Bedard.
* CISupport/ews-build/steps_unittest.py: Use mocked info in unit-tests.
Modified Paths
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (291964 => 291965)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-03-28 14:22:20 UTC (rev 291964)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-03-28 14:51:41 UTC (rev 291965)
@@ -5012,7 +5012,7 @@
def get_patch(self, title='Patch', obsolete=0):
return json.loads('''{{"bug_id": 224460,
- "creator":"aakash_j...@apple.com",
+ "creator":"revie...@apple.com",
"data": "patch-contents",
"file_name":"bug-224460-20210412192105.patch",
"flags": [{{"creation_date" : "2021-04-12T23:21:06Z", "id": 445872, "modification_date": "2021-04-12T23:55:36Z", "name": "review", "setter": "a...@webkit.org", "status": "+", "type_id": 1}}],
@@ -5163,8 +5163,8 @@
def mock_load_contributors(*args, **kwargs):
return {
-'aakash_j...@apple.com': {'name': 'Aakash Jain', 'status': 'reviewer'},
-'jain-aakash': {'name': 'Aakash Jain', 'status': 'reviewer'},
+'revie...@apple.com': {'name': 'WebKit Reviewer', 'status': 'reviewer'},
+'webkit-reviewer': {'name': 'WebKit Reviewer', 'status': 'reviewer'},
'commit...@webkit.org': {'name': 'WebKit Committer', 'status': 'committer'},
'webkit-commit-queue': {'name': 'WebKit Committer', 'status': 'committer'},
}, []
@@ -5179,7 +5179,7 @@
self.setupStep(ValidateCommitterAndReviewer())
self.setProperty('patch_id', '1234')
self.setProperty('patch_committer', 'commit...@webkit.org')
-self.setProperty('reviewer', 'aakash_j...@apple.com')
+self.setProperty('reviewer', 'revie...@apple.com')
self.expectHidden(False)
self.assertEqual(ValidateCommitterAndReviewer.haltOnFailure, False)
self.expectOutcome(result=SUCCESS, state_string='Validated commiter and reviewer')
@@ -5187,7 +5187,7 @@
def test_success_pr(self):
self.setupStep(ValidateCommitterAndReviewer())
-ValidateCommitterAndReviewer.get_reviewers = lambda x, pull_request, repository_url=None: ['jain-aakash']
+ValidateCommitterAndReviewer.get_reviewers = lambda x, pull_request, repository_url=None: ['webkit-reviewer']
self.setProperty('github.number', '1234')
self.setProperty('owners', ['webkit-commit-queue'])
self.expectHidden(False)
@@ -5198,7 +5198,7 @@
def test_success_no_reviewer_patch(self):
self.setupStep(ValidateCommitterAndReviewer())
self.setProperty('patch_id', '1234')
-self.setProperty('patch_committer', 'aakash_j...@apple.com')
+self.setProperty('patch_committer', 'revie...@apple.com')
self.expectHidden(False)
self.expectOutcome(result=SUCCESS, state_string='Validated committer')
return self.runStep()
@@ -5207,7 +5207,7 @@
self.setupStep(ValidateCommitterAndReviewer())
ValidateCommitterAndReviewer.get_reviewers = lambda x, pull_request, repository_url=None: []
self.setProperty('github.number', '1234')
-self.setProperty('owners', ['jain-aakash'])
+self.setProperty('owners', ['webkit-reviewer'])
self.expectHidden(False)
self.expectOutcome(result=SUCCESS, state_string='Validated committer')
return self.runStep()
@@ -5249,7 +5249,7 @@
def test_failure_invalid_reviewer_patch(self):
self.setupStep(ValidateCommitterAndReviewer())
self.setProperty('patch_id', '1234')
-self.setProperty('patch_committer', 'aakash_j...@apple.com')
+self.setProperty('patch_committer', 'revie...@apple.com')
self.setProperty('reviewer', 'commit...@webkit.org')
self.expectHidden(False)
self.expectOutcome(result=FAILURE, state_string='commit...@webkit.org does not have reviewer permissions')
@@ -5259,7 +5259,7 @@
self.setupStep(ValidateCommitterAndReviewer())
ValidateCommitterAndReviewer.get_reviewers = lambda x, pull_request, repository_url=None: ['webkit-commit-queue']
self.setProperty('github.number', '1234')
-self.setProperty('owners', ['jain-aakash'])
+self.setProperty('owners', ['webkit-reviewer'])
self.expectHidden(False)
self.expectOutcome(result=FAILURE, state_string='webkit-commit-queue does not have reviewer permissions')
return self.runStep()
Modified: trunk/Tools/ChangeLog (291964 => 291965)
---
[webkit-changes] [291964] trunk/Source/WebCore
Title: [291964] trunk/Source/WebCore
Revision 291964
Author cdu...@apple.com
Date 2022-03-28 07:22:20 -0700 (Mon, 28 Mar 2022)
Log Message
Optimize toJS() for HTMLElements
https://bugs.webkit.org/show_bug.cgi?id=238426
Reviewed by Yusuke Suzuki.
Optimize toJS() for HTMLElements. Previously, the more generic Element's toJS() would be called,
which would have to do more checks.
This is a 0.6% progression on Speedometer 2.0 on MacBook Air 10,1 (AS).
* bindings/js/JSHTMLElementCustom.cpp:
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
* html/HTMLElement.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp
trunk/Source/WebCore/html/HTMLElement.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (291963 => 291964)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 14:14:09 UTC (rev 291963)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 14:22:20 UTC (rev 291964)
@@ -1,5 +1,22 @@
2022-03-28 Chris Dumez
+Optimize toJS() for HTMLElements
+https://bugs.webkit.org/show_bug.cgi?id=238426
+
+Reviewed by Yusuke Suzuki.
+
+Optimize toJS() for HTMLElements. Previously, the more generic Element's toJS() would be called,
+which would have to do more checks.
+
+This is a 0.6% progression on Speedometer 2.0 on MacBook Air 10,1 (AS).
+
+* bindings/js/JSHTMLElementCustom.cpp:
+(WebCore::toJS):
+(WebCore::toJSNewlyCreated):
+* html/HTMLElement.idl:
+
+2022-03-28 Chris Dumez
+
Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=238422
Modified: trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp (291963 => 291964)
--- trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp 2022-03-28 14:14:09 UTC (rev 291963)
+++ trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp 2022-03-28 14:22:20 UTC (rev 291964)
@@ -32,6 +32,7 @@
#include "HTMLFormElement.h"
#include "JSCustomElementInterface.h"
#include "JSDOMConstructorBase.h"
+#include "JSHTMLElementWrapperFactory.h"
#include "JSNodeCustom.h"
#include "ScriptExecutionContext.h"
#include <_javascript_Core/InternalFunction.h>
@@ -130,4 +131,23 @@
return JSWithScope::create(vm, lexicalGlobalObject, scope, asObject(toJS(lexicalGlobalObject, globalObject(), element)));
}
+JSValue toJS(JSGlobalObject*, JSDOMGlobalObject* globalObject, HTMLElement& element)
+{
+if (auto* wrapper = getCachedWrapper(globalObject->world(), element))
+return wrapper;
+return createJSHTMLWrapper(globalObject, element);
+}
+
+JSValue toJSNewlyCreated(JSGlobalObject*, JSDOMGlobalObject* globalObject, Ref&& element)
+{
+if (element->isDefinedCustomElement()) {
+JSValue result = getCachedWrapper(globalObject->world(), element);
+if (result)
+return result;
+ASSERT(!globalObject->vm().exceptionForInspection());
+}
+ASSERT(!getCachedWrapper(globalObject->world(), element));
+return createJSHTMLWrapper(globalObject, WTFMove(element));
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/html/HTMLElement.idl (291963 => 291964)
--- trunk/Source/WebCore/html/HTMLElement.idl 2022-03-28 14:14:09 UTC (rev 291963)
+++ trunk/Source/WebCore/html/HTMLElement.idl 2022-03-28 14:22:20 UTC (rev 291964)
@@ -20,6 +20,7 @@
[
CustomPushEventHandlerScope,
+CustomToJSObject,
ExportMacro=WEBCORE_EXPORT,
Exposed=Window,
GenerateForEachEventHandlerContentAttribute,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291963] trunk/Source/WebCore
Title: [291963] trunk/Source/WebCore
Revision 291963
Author cdu...@apple.com
Date 2022-03-28 07:14:09 -0700 (Mon, 28 Mar 2022)
Log Message
Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=238422
Reviewed by Peng Liu.
Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp and inline its implementation in the only caller instead.
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::isReachableFromDOM): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291962 => 291963)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 12:08:56 UTC (rev 291962)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 14:14:09 UTC (rev 291963)
@@ -1,3 +1,16 @@
+2022-03-28 Chris Dumez
+
+Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
+https://bugs.webkit.org/show_bug.cgi?id=238422
+
+Reviewed by Peng Liu.
+
+Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp and inline its implementation in the only caller instead.
+
+* bindings/js/JSNodeCustom.cpp:
+(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
+(WebCore::isReachableFromDOM): Deleted.
+
2022-03-28 Ziran Sun
[Forms] Alias appearance keywords to 'auto' for button
Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (291962 => 291963)
--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2022-03-28 12:08:56 UTC (rev 291962)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2022-03-28 14:14:09 UTC (rev 291963)
@@ -64,17 +64,18 @@
using namespace JSC;
using namespace HTMLNames;
-static inline bool isReachableFromDOM(Node* node, AbstractSlotVisitor& visitor, const char** reason)
+bool JSNodeOwner::isReachableFromOpaqueRoots(JSC::Handle handle, void*, AbstractSlotVisitor& visitor, const char** reason)
{
-if (!node->isConnected()) {
+auto& node = jsCast(handle.slot()->asCell())->wrapped();
+if (!node.isConnected()) {
// If a node is firing event listeners, its wrapper is observable because
// its wrapper is responsible for marking those event listeners.
-if (node->isFiringEventListeners()) {
+if (node.isFiringEventListeners()) {
if (UNLIKELY(reason))
*reason = "Node which is firing event listeners";
return true;
}
-if (GCReachableRefMap::contains(*node)) {
+if (GCReachableRefMap::contains(node)) {
if (UNLIKELY(reason))
*reason = "Node is scheduled to be used in an async script invocation)";
return true;
@@ -87,12 +88,6 @@
return visitor.containsOpaqueRoot(root(node));
}
-bool JSNodeOwner::isReachableFromOpaqueRoots(JSC::Handle handle, void*, AbstractSlotVisitor& visitor, const char** reason)
-{
-JSNode* jsNode = jsCast(handle.slot()->asCell());
-return isReachableFromDOM(>wrapped(), visitor, reason);
-}
-
JSScope* JSNode::pushEventHandlerScope(JSGlobalObject* lexicalGlobalObject, JSScope* node) const
{
if (inherits(lexicalGlobalObject->vm()))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291962] trunk
Title: [291962] trunk Revision 291962 Author z...@igalia.com Date 2022-03-28 05:08:56 -0700 (Mon, 28 Mar 2022) Log Message [Forms] Alias appearance keywords to 'auto' for button https://bugs.webkit.org/show_bug.cgi?id=238252 Reviewed by Darin Adler. Source/WebCore: We need to alias appearance keywords to 'auto'. This is to handle some button related cases including button, push-button and square-button. Also the slider-horizontal case has been addressed. We still have menulist and textfield cases left to look into. * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustAppearanceForElement const): LayoutTests: Unskip the tests that are now passing. -webkit-appearance: square-button doesnt work for ::-webkit-file-upload-button any more. Replace it with -webkit-appearance: none in fast/forms/file/file-style-inheritance.html. This is also in line with the change in Chromium. * TestExpectations: * fast/forms/file/file-style-inheritance.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/forms/file/file-style-inheritance.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderTheme.cpp Diff Modified: trunk/LayoutTests/ChangeLog (291961 => 291962) --- trunk/LayoutTests/ChangeLog 2022-03-28 08:27:30 UTC (rev 291961) +++ trunk/LayoutTests/ChangeLog 2022-03-28 12:08:56 UTC (rev 291962) @@ -1,3 +1,17 @@ +2022-03-28 Ziran Sun + +[Forms] Alias appearance keywords to 'auto' for button +https://bugs.webkit.org/show_bug.cgi?id=238252 + +Reviewed by Darin Adler. + +Unskip the tests that are now passing. +-webkit-appearance: square-button doesnt work for ::-webkit-file-upload-button any more. +Replace it with -webkit-appearance: none in fast/forms/file/file-style-inheritance.html. +This is also in line with the change in Chromium. +* TestExpectations: +* fast/forms/file/file-style-inheritance.html: + 2022-03-28 Cameron McCormack Remove pending UA shadow tree state when an input element is removed from the document Modified: trunk/LayoutTests/TestExpectations (291961 => 291962) --- trunk/LayoutTests/TestExpectations 2022-03-28 08:27:30 UTC (rev 291961) +++ trunk/LayoutTests/TestExpectations 2022-03-28 12:08:56 UTC (rev 291962) @@ -4312,12 +4312,8 @@ webkit.org/b/234762 imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-dynamic-change-003.html [ ImageOnlyFailure ] # New failures after updating WPT import of css/css-text on 2020-07 -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/appearance-button-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/appearance-menulist-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/appearance-menulist-button-002.tentative.html [ ImageOnlyFailure ] -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/appearance-push-button-001.html [ ImageOnlyFailure ] -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/appearance-slider-horizontal-001.html [ ImageOnlyFailure ] -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/appearance-square-button-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/appearance-textfield-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/outline-021.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/outline-025.html [ ImageOnlyFailure ] @@ -4324,12 +4320,8 @@ webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/outline-026.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/outline-offset-table-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/text-overflow-ruby.html [ ImageOnlyFailure ] -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-button-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-menulist-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-menulist-button-002.tentative.html [ ImageOnlyFailure ] -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-push-button-001.html [ ImageOnlyFailure ] -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-slider-horizontal-001.html [ ImageOnlyFailure ] -webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-square-button-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-textfield-001.html [ ImageOnlyFailure ] webkit.org/b/214299 imported/w3c/web-platform-tests/css/css-ui/resize-child-will-change-transform.html [ ImageOnlyFailure ] webkit.org/b/214299
[webkit-changes] [291961] trunk
Title: [291961] trunk
Revision 291961
Author hey...@apple.com
Date 2022-03-28 01:27:30 -0700 (Mon, 28 Mar 2022)
Log Message
Remove pending UA shadow tree state when an input element is removed from the document
https://bugs.webkit.org/show_bug.cgi?id=238429
Reviewed by Antti Koivisto.
Source/WebCore:
If an element has a pending UA shadow tree, and the element is
removed from the document, we don't currently remove the element from
Document::m_elementsWithPendingUserAgentShadowTreeUpdates. Not only
does that means we may wastefully create the shadow tree if the
element is not inserted into the document again, but if the element is
then inserted into a different document, flushing style in the new
document won't correctly create the shadow tree.
Test: fast/forms/lazy-shadow-tree-creation-move-document-crash.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::removedFromAncestor):
LayoutTests:
* fast/forms/lazy-shadow-tree-creation-move-document-crash-expected.txt: Added.
* fast/forms/lazy-shadow-tree-creation-move-document-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
Added Paths
trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash-expected.txt
trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (291960 => 291961)
--- trunk/LayoutTests/ChangeLog 2022-03-28 06:15:24 UTC (rev 291960)
+++ trunk/LayoutTests/ChangeLog 2022-03-28 08:27:30 UTC (rev 291961)
@@ -1,3 +1,14 @@
+2022-03-28 Cameron McCormack
+
+Remove pending UA shadow tree state when an input element is removed from the document
+https://bugs.webkit.org/show_bug.cgi?id=238429
+
+
+Reviewed by Antti Koivisto.
+
+* fast/forms/lazy-shadow-tree-creation-move-document-crash-expected.txt: Added.
+* fast/forms/lazy-shadow-tree-creation-move-document-crash.html: Added.
+
2022-03-27 Matt Woodrow
Preserve repeat() notation for grid-templates
Added: trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash-expected.txt (0 => 291961)
--- trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash-expected.txt 2022-03-28 08:27:30 UTC (rev 291961)
@@ -0,0 +1 @@
+PASS if no crash.
Added: trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash.html (0 => 291961)
--- trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash.html (rev 0)
+++ trunk/LayoutTests/fast/forms/lazy-shadow-tree-creation-move-document-crash.html 2022-03-28 08:27:30 UTC (rev 291961)
@@ -0,0 +1,14 @@
+
+PASS if no crash.
+
+function run() {
+if (window.testRunner)
+testRunner.dumpAsText();
+
+let e = document.createElement("input");
+frames[0].document.body.offsetTop;
+document.body.append(e);
+frames[0].document.body.append(e);
+}
+
+
Modified: trunk/Source/WebCore/ChangeLog (291960 => 291961)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 06:15:24 UTC (rev 291960)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 08:27:30 UTC (rev 291961)
@@ -1,3 +1,24 @@
+2022-03-28 Cameron McCormack
+
+Remove pending UA shadow tree state when an input element is removed from the document
+https://bugs.webkit.org/show_bug.cgi?id=238429
+
+
+Reviewed by Antti Koivisto.
+
+If an element has a pending UA shadow tree, and the element is
+removed from the document, we don't currently remove the element from
+Document::m_elementsWithPendingUserAgentShadowTreeUpdates. Not only
+does that means we may wastefully create the shadow tree if the
+element is not inserted into the document again, but if the element is
+then inserted into a different document, flushing style in the new
+document won't correctly create the shadow tree.
+
+Test: fast/forms/lazy-shadow-tree-creation-move-document-crash.html
+
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::removedFromAncestor):
+
2022-03-27 Lauro Moura
Unreviewed, non-unified buildfix
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (291960 => 291961)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2022-03-28 06:15:24 UTC (rev 291960)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2022-03-28 08:27:30 UTC (rev 291961)
@@ -1637,6 +1637,10 @@
oldParentOfRemovedTree.treeScope().radioButtonGroups().removeButton(*this);
if (removalType.disconnectedFromDocument && !form())
removeFromRadioButtonGroup();
+if (removalType.disconnectedFromDocument && m_hasPendingUserAgentShadowTreeUpdate) {
+document().removeElementWithPendingUserAgentShadowTreeUpdate(*this);
+
[webkit-changes] [291960] trunk/Source
Title: [291960] trunk/Source
Revision 291960
Author lmo...@igalia.com
Date 2022-03-27 23:15:24 -0700 (Sun, 27 Mar 2022)
Log Message
Unreviewed, non-unified buildfix
https://bugs.webkit.org/show_bug.cgi?id=238436
Source/_javascript_Core:
* dfg/DFGStrengthReductionPhase.cpp:
Source/WebCore:
* workers/service/ServiceWorkerWindowClient.cpp:
Source/WebKit:
* WebProcess/Storage/WebSWClientConnection.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291959 => 291960)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-28 06:15:24 UTC (rev 291960)
@@ -1,3 +1,10 @@
+2022-03-27 Lauro Moura
+
+Unreviewed, non-unified buildfix
+https://bugs.webkit.org/show_bug.cgi?id=238436
+
+* dfg/DFGStrengthReductionPhase.cpp:
+
2022-03-26 Yusuke Suzuki
Use static_assert instead of COMPILE_ASSERT
Modified: trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp (291959 => 291960)
--- trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2022-03-28 06:15:24 UTC (rev 291960)
@@ -33,6 +33,7 @@
#include "DFGClobberize.h"
#include "DFGGraph.h"
#include "DFGInsertionSet.h"
+#include "DFGJITCode.h"
#include "DFGPhase.h"
#include "MathCommon.h"
#include "RegExpObject.h"
Modified: trunk/Source/WebCore/ChangeLog (291959 => 291960)
--- trunk/Source/WebCore/ChangeLog 2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebCore/ChangeLog 2022-03-28 06:15:24 UTC (rev 291960)
@@ -1,3 +1,10 @@
+2022-03-27 Lauro Moura
+
+Unreviewed, non-unified buildfix
+https://bugs.webkit.org/show_bug.cgi?id=238436
+
+* workers/service/ServiceWorkerWindowClient.cpp:
+
2022-03-27 Matt Woodrow
Preserve repeat() notation for grid-templates
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp (291959 => 291960)
--- trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp 2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp 2022-03-28 06:15:24 UTC (rev 291960)
@@ -32,6 +32,7 @@
#include "JSServiceWorkerWindowClient.h"
#include "SWContextManager.h"
#include "ServiceWorkerClients.h"
+#include "ServiceWorkerGlobalScope.h"
#include "ServiceWorkerThread.h"
namespace WebCore {
Modified: trunk/Source/WebKit/ChangeLog (291959 => 291960)
--- trunk/Source/WebKit/ChangeLog 2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebKit/ChangeLog 2022-03-28 06:15:24 UTC (rev 291960)
@@ -1,3 +1,10 @@
+2022-03-27 Lauro Moura
+
+Unreviewed, non-unified buildfix
+https://bugs.webkit.org/show_bug.cgi?id=238436
+
+* WebProcess/Storage/WebSWClientConnection.cpp:
+
2022-03-26 Yusuke Suzuki
Use static_assert instead of COMPILE_ASSERT
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp (291959 => 291960)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp 2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp 2022-03-28 06:15:24 UTC (rev 291960)
@@ -35,6 +35,8 @@
#include "NetworkProcessConnection.h"
#include "NetworkProcessMessages.h"
#include "WebCoreArgumentCoders.h"
+#include "WebPage.h"
+#include "WebPageProxyMessages.h"
#include "WebProcess.h"
#include "WebProcessPoolMessages.h"
#include "WebSWOriginTable.h"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
