[webkit-changes] [293566] trunk/Source/WebCore
Title: [293566] trunk/Source/WebCore Revision 293566 Author tyle...@apple.com Date 2022-04-27 22:36:41 -0700 (Wed, 27 Apr 2022) Log Message AXObjectCache::childrenChanged modifies m_deferred* member variables but doesn't start timer to process them https://bugs.webkit.org/show_bug.cgi?id=239787 Reviewed by Chris Fleizach. This patch fixes this a bug where AXObjectCache::childrenChanged methods modify m_deferred* member variables, but doesn't start the m_performCacheUpdateTimer. This patch also renames m_deferredChildrenChangedNodeList to m_deferredNodeAddedOrRemovedList, since this more accurately captures what this list is for. Finally, this refactors a few methods that modify m_deferred* member variables to not start the cache timer unless the variable has actually changed. Fixes these tests in ITM: - accessibility/mac/focus-moves-cursor.html - accessibility/image-load-on-delay.html - accessibility/legend-children-are-visible.html - accessibility/text-alternative-calculation-hidden-nodes.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::deferMenuListValueChange): (WebCore::AXObjectCache::deferModalChange): (WebCore::AXObjectCache::deferNodeAddedOrRemoved): Added. (WebCore::AXObjectCache::prepareForDocumentDestruction): (WebCore::AXObjectCache::performDeferredCacheUpdate): * accessibility/AXObjectCache.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AXObjectCache.h Diff Modified: trunk/Source/WebCore/ChangeLog (293565 => 293566) --- trunk/Source/WebCore/ChangeLog 2022-04-28 05:32:05 UTC (rev 293565) +++ trunk/Source/WebCore/ChangeLog 2022-04-28 05:36:41 UTC (rev 293566) @@ -1,3 +1,38 @@ +2022-04-27 Tyler Wilcock + +AXObjectCache::childrenChanged modifies m_deferred* member variables but doesn't start timer to process them +https://bugs.webkit.org/show_bug.cgi?id=239787 + +Reviewed by Chris Fleizach. + +This patch fixes this a bug where AXObjectCache::childrenChanged +methods modify m_deferred* member variables, but doesn't start +the m_performCacheUpdateTimer. + +This patch also renames m_deferredChildrenChangedNodeList to +m_deferredNodeAddedOrRemovedList, since this more accurately +captures what this list is for. + +Finally, this refactors a few methods that modify m_deferred* member +variables to not start the cache timer unless the variable has +actually changed. + +Fixes these tests in ITM: + - accessibility/mac/focus-moves-cursor.html + - accessibility/image-load-on-delay.html + - accessibility/legend-children-are-visible.html + - accessibility/text-alternative-calculation-hidden-nodes.html + +* accessibility/AXObjectCache.cpp: +(WebCore::AXObjectCache::remove): +(WebCore::AXObjectCache::childrenChanged): +(WebCore::AXObjectCache::deferMenuListValueChange): +(WebCore::AXObjectCache::deferModalChange): +(WebCore::AXObjectCache::deferNodeAddedOrRemoved): Added. +(WebCore::AXObjectCache::prepareForDocumentDestruction): +(WebCore::AXObjectCache::performDeferredCacheUpdate): +* accessibility/AXObjectCache.h: + 2022-04-27 Patrick Angle Web Inspector: [Flexbox] `` and `` elements are appearing in list of Flex containers Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (293565 => 293566) --- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-04-28 05:32:05 UTC (rev 293565) +++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-04-28 05:36:41 UTC (rev 293566) @@ -903,7 +903,7 @@ m_deferredModalChangedList.remove(downcast(node)); m_deferredMenuListChange.remove(downcast(node)); } -m_deferredChildrenChangedNodeList.remove(&node); +m_deferredNodeAddedOrRemovedList.remove(&node); m_deferredTextChangedList.remove(&node); // Remove the entry if the new focused node is being removed. m_deferredFocusedNodeChange.removeAllMatching([&node](auto& entry) -> bool { @@ -1105,32 +1105,42 @@ if (AccessibilityObject::liveRegionStatusIsEnabled(liveRegionStatus)) postNotification(getOrCreate(node), &document(), AXLiveRegionCreated); } - -void AXObjectCache::childrenChanged(Node* node, Node* newChild) + +void AXObjectCache::deferNodeAddedOrRemoved(Node* node) { -if (newChild) -m_deferredChildrenChangedNodeList.add(newChild); +if (!node) +return; -if (auto* object = get(node)) -m_deferredChildrenChangedList.add(object); +m_deferredNodeAddedOrRemovedList.add(node); + +if (!m_performCacheUpdateTimer.isActive()) +m_performCacheUpdateTimer.startOneShot(0_s); } -void AXObjectCache::childrenChanged(RenderObject* renderer, RenderObject* newChild) +
[webkit-changes] [293565] trunk
Title: [293565] trunk Revision 293565 Author pan...@apple.com Date 2022-04-27 22:32:05 -0700 (Wed, 27 Apr 2022) Log Message Web Inspector: [Flexbox] `` and `` elements are appearing in list of Flex containers https://bugs.webkit.org/show_bug.cgi?id=239425 Reviewed by Devin Rousso. Source/WebCore: Added test cases to inspector/css/nodeLayoutContextTypeChanged.html. * inspector/agents/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::layoutContextTypeForRenderer): LayoutTests: * inspector/css/nodeLayoutContextTypeChanged-expected.txt: * inspector/css/nodeLayoutContextTypeChanged.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged-expected.txt trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp Diff Modified: trunk/LayoutTests/ChangeLog (293564 => 293565) --- trunk/LayoutTests/ChangeLog 2022-04-28 05:01:24 UTC (rev 293564) +++ trunk/LayoutTests/ChangeLog 2022-04-28 05:32:05 UTC (rev 293565) @@ -1,3 +1,13 @@ +2022-04-27 Patrick Angle + +Web Inspector: [Flexbox] `` and `` elements are appearing in list of Flex containers +https://bugs.webkit.org/show_bug.cgi?id=239425 + +Reviewed by Devin Rousso. + +* inspector/css/nodeLayoutContextTypeChanged-expected.txt: +* inspector/css/nodeLayoutContextTypeChanged.html: + 2022-04-27 Karl Rackler [ macOS wk1 ] Fourteen webgl/2.0.0/conformance tests are a flaky timeout Modified: trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged-expected.txt (293564 => 293565) --- trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged-expected.txt 2022-04-28 05:01:24 UTC (rev 293564) +++ trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged-expected.txt 2022-04-28 05:32:05 UTC (rev 293565) @@ -1,6 +1,7 @@ Tests for the CSS.nodeLayoutContextTypeChanged event. + == Running test suite: CSS.nodeLayoutContextTypeChanged -- Running test case: CSS.nodeLayoutContextTypeChanged.GridToNonGrid PASS: Layout context should be `grid`. @@ -22,3 +23,12 @@ PASS: Layout context should now be `grid`. PASS: Layout context should now be `flex`. +-- Running test case: CSS.nodeLayoutContextTypeChanged.NotFlex.SubmitInput +PASS: Layout context should be `null`. + +-- Running test case: CSS.nodeLayoutContextTypeChanged.NotFlex.Select +PASS: Layout context should be `null`. + +-- Running test case: CSS.nodeLayoutContextTypeChanged.NotFlex.Button +PASS: Layout context should be `null`. + Modified: trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html (293564 => 293565) --- trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html 2022-04-28 05:01:24 UTC (rev 293564) +++ trunk/LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html 2022-04-28 05:32:05 UTC (rev 293565) @@ -113,6 +113,35 @@ } }); +function addEnsureLayoutContextTypeTestCase({name, description, selector, expectedLayoutContextType}) +{ +addTestCase({name, description, selector, async domNodeHandler(domNode) { +InspectorTest.expectEqual(domNode.layoutContextType, expectedLayoutContextType, `Layout context should be \`${expectedLayoutContextType}\`.`); +} +}); +} + +addEnsureLayoutContextTypeTestCase({ +name: "CSS.nodeLayoutContextTypeChanged.NotFlex.SubmitInput", +description: "Make sure an `input` element of type `submit` is not considered a flex container.", +selector: "#flexSubmitInput", +expectedLayoutContextType: null, +}); + +addEnsureLayoutContextTypeTestCase({ +name: "CSS.nodeLayoutContextTypeChanged.NotFlex.Select", +description: "Make sure a `select` element is not considered a flex container.", +selector: "#flexSelect", +expectedLayoutContextType: null, +}); + +addEnsureLayoutContextTypeTestCase({ +name: "CSS.nodeLayoutContextTypeChanged.NotFlex.Button", +description: "Make sure a `button` is not considered a flex container.", +selector: "#flexButton", +expectedLayoutContextType: null, +}); + WI.domManager.requestDocument().then((doc) => { documentNode = doc; suite.runTestCasesAndFinish(); @@ -155,5 +184,9 @@ + + + + Modified: trunk/Source/WebCore/ChangeLog (293564 => 293565) --- trunk/Source/WebCore/ChangeLog 2022-04-28 05:01:24 UTC (rev 293564) +++ trunk/Source/WebCore/ChangeLog 2022-04-28 05:32:05 UTC (rev 293565) @@ -1,3 +1,15 @@ +2022-04-27 Patrick Angle + +Web Inspector: [Flexbox] `` and `` elements are appearing in list of Flex containers +https://bugs.webkit.org/show_bug.cgi?id=239425 + +Reviewed by Devin Rousso. + +Added test cases to inspector/css/nodeLayoutContextTypeChanged.html. + +* inspector/agents/InspectorCSSAgent.cpp: +
[webkit-changes] [293564] trunk/Source/WebKit
Title: [293564] trunk/Source/WebKit Revision 293564 Author wenson_hs...@apple.com Date 2022-04-27 22:01:24 -0700 (Wed, 27 Apr 2022) Log Message [iOS] Add a mechanism to override desktop-class browsing state in multitasking mode https://bugs.webkit.org/show_bug.cgi?id=239801 rdar://89786146 Reviewed by Tim Horton. Keep the recommended desktop-class browsing state stable as the width of the web view changes, while multitasking mode is active. * UIProcess/API/ios/WKWebViewIOS.h: * UIProcess/PageClient.h: (WebKit::PageClient::isInMultitaskingMode const): * UIProcess/WebPageProxy.h: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::isInMultitaskingMode const): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::isDesktopClassBrowsingRecommended const): Turn the static helper function `desktopClassBrowsingRecommended` into a private method instead, so that we don't need to pass in all the information we need from the WebPageProxy when determining whether we should default to desktop-class browsing. This also allows us to make a slight adjustment here to avoid recommending mobile content when the window is narrower than 375 points in multitasking mode. (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies): (WebKit::desktopClassBrowsingRecommended): Deleted. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h trunk/Source/WebKit/UIProcess/PageClient.h trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm Diff Modified: trunk/Source/WebKit/ChangeLog (293563 => 293564) --- trunk/Source/WebKit/ChangeLog 2022-04-28 04:50:39 UTC (rev 293563) +++ trunk/Source/WebKit/ChangeLog 2022-04-28 05:01:24 UTC (rev 293564) @@ -1,3 +1,32 @@ +2022-04-27 Wenson Hsieh + +[iOS] Add a mechanism to override desktop-class browsing state in multitasking mode +https://bugs.webkit.org/show_bug.cgi?id=239801 +rdar://89786146 + +Reviewed by Tim Horton. + +Keep the recommended desktop-class browsing state stable as the width of the web view changes, while +multitasking mode is active. + +* UIProcess/API/ios/WKWebViewIOS.h: +* UIProcess/PageClient.h: +(WebKit::PageClient::isInMultitaskingMode const): +* UIProcess/WebPageProxy.h: +* UIProcess/ios/PageClientImplIOS.h: +* UIProcess/ios/PageClientImplIOS.mm: +(WebKit::PageClientImpl::isInMultitaskingMode const): +* UIProcess/ios/WebPageProxyIOS.mm: +(WebKit::WebPageProxy::isDesktopClassBrowsingRecommended const): + +Turn the static helper function `desktopClassBrowsingRecommended` into a private method instead, so that we +don't need to pass in all the information we need from the WebPageProxy when determining whether we should +default to desktop-class browsing. This also allows us to make a slight adjustment here to avoid recommending +mobile content when the window is narrower than 375 points in multitasking mode. + +(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies): +(WebKit::desktopClassBrowsingRecommended): Deleted. + 2022-04-27 Simon Fraser Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h (293563 => 293564) --- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h 2022-04-28 04:50:39 UTC (rev 293563) +++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h 2022-04-28 05:01:24 UTC (rev 293564) @@ -170,6 +170,10 @@ @property (nonatomic, readonly, getter=_isRetainingActiveFocusedState) BOOL _retainingActiveFocusedState; @property (nonatomic, readonly) int32_t _deviceOrientation; +#if HAVE(MULTITASKING_MODE) +@property (nonatomic, readonly) BOOL _isInMultitaskingMode; +#endif + @end _WKTapHandlingResult wkTapHandlingResult(WebKit::TapHandlingResult); Modified: trunk/Source/WebKit/UIProcess/PageClient.h (293563 => 293564) --- trunk/Source/WebKit/UIProcess/PageClient.h 2022-04-28 04:50:39 UTC (rev 293563) +++ trunk/Source/WebKit/UIProcess/PageClient.h 2022-04-28 05:01:24 UTC (rev 293564) @@ -554,6 +554,8 @@ virtual WebCore::DataOwnerType dataOwnerForPasteboard(PasteboardAccessIntent) const { return WebCore::DataOwnerType::Undefined; } #endif +virtual bool isInMultitaskingMode() const { return false; } + #if ENABLE(IMAGE_ANALYSIS) virtual void requestTextRecognition(const URL& imageURL, const ShareableBitmap::Handle& imageData, const String& identifier, CompletionHandler&& completion) { completion({ }); } virtual void computeHasVisualSearchResults(const URL&, ShareableBitmap&, CompletionHandler&& completion) { completion(false); } Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.
[webkit-changes] [293562] trunk/Source/WebKit/UIProcess
Title: [293562] trunk/Source/WebKit/UIProcess Revision 293562 Author cdu...@apple.com Date 2022-04-27 21:09:34 -0700 (Wed, 27 Apr 2022) Log Message GPUProcess doesn't get notified of imminent process suspension https://bugs.webkit.org/show_bug.cgi?id=239815 Reviewed by Tim Horton. By defaults, ProcessThrottler in the UIProcess use a ProcessAndUIAssertion instance internally, instead of a simple ProcessAssertion. This makes sure that a process assertion is taken on behalf of the UIProcess as well, not just the child process. This also makes sure that when the UIProcess has been in the background for too long and its assertion gets invalidated, we release all ProcessAndUIAssertion instances as well. The WebProcess and NetworkProcess were correctly using a ProcessAndUIAssertion. However, the GPUProcess was passing `false` when constructing the ProcessThrottler, causing it to use a simple ProcessAssertion. As a result, the GPUProcess would not get notified on imminent suspension when the app has been running in the background for too long. This patch aligns the behavior of the GPUProcess with the one of the NetworkProcess since both processes are very similar. * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::GPUProcessProxy): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::NetworkProcessProxy): (WebKit::anyProcessPoolShouldTakeUIBackgroundAssertion): Deleted. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::anyProcessPoolNeedsUIBackgroundAssertion): * Source/WebKit/UIProcess/WebProcessPool.h: Canonical link: https://commits.webkit.org/250076@main Modified Paths trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.h Diff Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp (293561 => 293562) --- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2022-04-28 04:03:12 UTC (rev 293561) +++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2022-04-28 04:09:34 UTC (rev 293562) @@ -130,7 +130,7 @@ GPUProcessProxy::GPUProcessProxy() : AuxiliaryProcessProxy() -, m_throttler(*this, false) +, m_throttler(*this, WebProcessPool::anyProcessPoolNeedsUIBackgroundAssertion()) #if ENABLE(MEDIA_STREAM) , m_useMockCaptureDevices(MockRealtimeMediaSourceCenter::mockRealtimeMediaSourceCenterEnabled()) #endif Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (293561 => 293562) --- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2022-04-28 04:03:12 UTC (rev 293561) +++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2022-04-28 04:09:34 UTC (rev 293562) @@ -230,15 +230,6 @@ return false; } -static bool anyProcessPoolShouldTakeUIBackgroundAssertion() -{ -for (auto& processPool : WebProcessPool::allProcessPools()) { -if (processPool->shouldTakeUIBackgroundAssertion()) -return true; -} -return false; -} - NetworkProcessProxy::NetworkProcessProxy() : AuxiliaryProcessProxy(anyProcessPoolAlwaysRunsAtBackgroundPriority(), networkProcessResponsivenessTimeout) #if ENABLE(LEGACY_CUSTOM_PROTOCOL_MANAGER) @@ -247,7 +238,7 @@ #else , m_customProtocolManagerClient(makeUniqueRef()) #endif -, m_throttler(*this, anyProcessPoolShouldTakeUIBackgroundAssertion()) +, m_throttler(*this, WebProcessPool::anyProcessPoolNeedsUIBackgroundAssertion()) , m_cookieManager(makeUniqueRef(*this)) { connect(); Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (293561 => 293562) --- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2022-04-28 04:03:12 UTC (rev 293561) +++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2022-04-28 04:09:34 UTC (rev 293562) @@ -2166,6 +2166,15 @@ processPool->terminateServiceWorkers(); } +bool WebProcessPool::anyProcessPoolNeedsUIBackgroundAssertion() +{ +for (auto& processPool : WebProcessPool::allProcessPools()) { +if (processPool->shouldTakeUIBackgroundAssertion()) +return true; +} +return false; +} + #if ENABLE(SERVICE_WORKER) size_t WebProcessPool::serviceWorkerProxiesCount() const { Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.h (293561 => 293562) --- trunk/Source/WebKit/UIProcess/WebProcessPool.h 2022-04-28 04:03:12 UTC (rev 293561) +++ trunk/Source/WebKit/UIProcess/WebProcessPool.h 2022-04-28 04:09:34 UTC (rev 293562) @@ -435,6 +435,7 @@ bool alwaysRunsAtBackgroundPriority() const { return m_alwaysRunsAtBackgroundPriority; } bool shouldTakeUIBackgroundAssertion() const { return m_shouldTakeUIBackgroundAssertion; } +static bool anyProcessPoolNeedsUIBackgroundAssertion(); #if ENABLE(GAMEPAD) void gamepadConnected(const UIGamepad&, WebCore::EventMakesGamepadsVisible); _
[webkit-changes] [293561] trunk
Title: [293561] trunk Revision 293561 Author cdu...@apple.com Date 2022-04-27 21:03:12 -0700 (Wed, 27 Apr 2022) Log Message Have equalIgnoringASCIICase() take in an ASCIILiteral instead of a const char* https://bugs.webkit.org/show_bug.cgi?id=239802 Reviewed by Darin Adler. Have equalIgnoringASCIICase() take in an ASCIILiteral instead of a const char*, as we are encouraging developers to use ""_s for string literals. * Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WTF/StringView.cpp: (TestWebKitAPI::TEST): * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm: (parameterValue): (WebFrameLoaderClient::createPlugin): * Source/WTF/wtf/text/AtomString.h: (WTF::equalIgnoringASCIICase): * Source/WTF/wtf/text/StringImpl.h: (WTF::equalIgnoringASCIICase): * Source/WTF/wtf/text/StringView.h: (WTF::equalIgnoringASCIICase): * Source/WTF/wtf/text/WTFString.h: (WTF::equalIgnoringASCIICase): * Source/WTF/wtf/unix/LanguageUnix.cpp: (WTF::platformLanguage): * Source/WebCore/Modules/applepay/PaymentCoordinator.cpp: (WebCore::PaymentCoordinator::validatedPaymentNetwork const): * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::siblingWithAriaRole): (WebCore::AccessibilityNodeObject::menuElementForMenuButton const): (WebCore::AccessibilityNodeObject::menuItemElementForMenu const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::popupValue const): * Source/WebCore/css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific const): * Source/WebCore/css/MediaQueryEvaluator.h: * Source/WebCore/dom/Document.cpp: (WebCore::messageSourceForWTFLogChannel): * Source/WebCore/dom/SecurityContext.cpp: (WebCore::SecurityContext::isSupportedSandboxPolicy): * Source/WebCore/html/HiddenInputType.cpp: (WebCore::HiddenInputType::appendFormData const): * Source/WebCore/html/LinkRelAttribute.cpp: (WebCore::LinkRelAttribute::isSupported): * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getExtension): * Source/WebCore/html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::extensionIsEnabled): * Source/WebCore/page/FrameTree.cpp: (WebCore::isBlankTargetFrameName): (WebCore::isParentTargetFrameName): (WebCore::isSelfTargetFrameName): (WebCore::isTopTargetFrameName): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::keySystemIsSupported): * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::FontCache::similarFont): (WebCore::FontCache::platformAlternateFamilyName): * Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::Font::platformInit): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::isThunderRanked): * Source/WebCore/platform/network/CacheValidation.cpp: * Source/WebCore/platform/network/HTTPParsers.cpp: (WebCore::normalizeHTTPMethod): (WebCore::isSafeMethod): * Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp: (WebCore::CurlMultipartHandle::extractBoundary): * Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp: (WebCore::MIMETypeRegistry::mimeTypeForExtension): (WebCore::MIMETypeRegistry::preferredExtensionForMIMEType): * Source/WebCore/style/ElementRuleCollector.h: (WebCore::Style::ElementRuleCollector::setMedium): * Source/WebCore/svg/SVGToOTFFontConversion.cpp: (WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable): (WebCore::SVGToOTFFontConverter::appendGSUBTable): * Source/WebCore/xml/XMLHttpRequest.cpp: (WebCore::replaceCharsetInMediaTypeIfNeeded): Canonical link: https://commits.webkit.org/250075@main Modified Paths trunk/Source/WTF/wtf/text/AtomString.h trunk/Source/WTF/wtf/text/StringCommon.h trunk/Source/WTF/wtf/text/StringImpl.h trunk/Source/WTF/wtf/text/StringView.h trunk/Source/WTF/wtf/text/WTFString.h trunk/Source/WTF/wtf/unix/LanguageUnix.cpp trunk/Source/WebCore/Modules/applepay/PaymentCoordinator.cpp trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/css/MediaQueryEvaluator.cpp trunk/Source/WebCore/css/MediaQueryEvaluator.h trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/SecurityContext.cpp trunk/Source/WebCore/html/HiddenInputType.cpp trunk/Source/WebCore/html/LinkRelAttribute.cpp trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/page/FrameTree.cpp trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp tr
[webkit-changes] [293560] trunk/LayoutTests
Title: [293560] trunk/LayoutTests Revision 293560 Author commit-qu...@webkit.org Date 2022-04-27 20:23:01 -0700 (Wed, 27 Apr 2022) Log Message [ macOS wk1 ] Fourteen webgl/2.0.0/conformance tests are a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=239835 Unreviewed test gardening. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/250074@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (293559 => 293560) --- trunk/LayoutTests/ChangeLog 2022-04-28 03:19:31 UTC (rev 293559) +++ trunk/LayoutTests/ChangeLog 2022-04-28 03:23:01 UTC (rev 293560) @@ -1,5 +1,14 @@ 2022-04-27 Karl Rackler +[ macOS wk1 ] Fourteen webgl/2.0.0/conformance tests are a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=239835 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + +2022-04-27 Karl Rackler + [ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=239822 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (293559 => 293560) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-28 03:19:31 UTC (rev 293559) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-28 03:23:01 UTC (rev 293560) @@ -1874,3 +1874,17 @@ webkit.org/b/237783 imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties.html [ Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance/extensions/oes-texture-float-with-video.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-video.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance/textures/video/tex-2d-rgba-rgba-unsigned_byte.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance/textures/video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-r8-red-unsigned_byte.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-float.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-float.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-half_float.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-2d-r8ui-red_integer-unsigned_byte.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-2d-rg32f-rg-float.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-2d-rgb9_e5-rgb-float.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-3d-rg16f-rg-half_float.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-3d-rgb5_a1-rgba-unsigned_byte.html [ Pass Timeout ] +webkit.org/b/239835 webgl/2.0.0/conformance2/textures/video/tex-3d-rgba4-rgba-unsigned_byte.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293559] trunk/Tools
Title: [293559] trunk/Tools Revision 293559 Author sihui_...@apple.com Date 2022-04-27 20:19:31 -0700 (Wed, 27 Apr 2022) Log Message [ iOS ] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=239310 Reviewed by Youenn Fablet. Message may be received before runTestAndCheckResult(), so we should not unset receivedScriptMessage before wait. * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: (runUntilMessageReceived): (TEST): (runTestAndCheckResult): Deleted. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm Diff Modified: trunk/Tools/ChangeLog (293558 => 293559) --- trunk/Tools/ChangeLog 2022-04-28 03:04:58 UTC (rev 293558) +++ trunk/Tools/ChangeLog 2022-04-28 03:19:31 UTC (rev 293559) @@ -1,3 +1,19 @@ +2022-04-27 Sihui Liu + +[ iOS ] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is a constant timeout +https://bugs.webkit.org/show_bug.cgi?id=239310 + + +Reviewed by Youenn Fablet. + +Message may be received before runTestAndCheckResult(), so we should not unset receivedScriptMessage before +wait. + +* TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: +(runUntilMessageReceived): +(TEST): +(runTestAndCheckResult): Deleted. + 2022-04-27 Jonathan Bedard [git-webkit] Run style checker Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm (293558 => 293559) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm 2022-04-28 03:04:58 UTC (rev 293558) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm 2022-04-28 03:19:31 UTC (rev 293559) @@ -39,7 +39,7 @@ #if PLATFORM(IOS_FAMILY) -static bool idbAcitivitiesStarted; +static bool idbActivitiesStarted; @interface IndexedDBSuspendImminentlyMessageHandler : NSObject @end @@ -48,7 +48,7 @@ - (void)userContentController:(WKUserContentController *)userContentController didReceiveScriptMessage:(WKScriptMessage *)message { -idbAcitivitiesStarted = true; +idbActivitiesStarted = true; receivedScriptMessage = true; lastScriptMessage = message; } @@ -55,23 +55,23 @@ @end -static void runTestAndCheckResult(NSString* expectedResult) +static void runUntilMessageReceived(NSString* expectedMessage) { -receivedScriptMessage = false; TestWebKitAPI::Util::run(&receivedScriptMessage); RetainPtr string = (NSString *)[lastScriptMessage body]; -EXPECT_WK_STREQ(expectedResult, string.get()); +EXPECT_WK_STREQ(expectedMessage, string.get()); +receivedScriptMessage = false; } static void keepNetworkProcessActive() { [[WKWebsiteDataStore defaultDataStore] fetchDataRecordsOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] completionHandler:^(NSArray *dataRecords) { -if (!idbAcitivitiesStarted) +if (!idbActivitiesStarted) keepNetworkProcessActive(); }]; } -// FIXME: https://bugs.webkit.org/show_bug.cgi?id=239310 -TEST(IndexedDB, DISABLED_IndexedDBSuspendImminently) + +TEST(IndexedDB, IndexedDBSuspendImminently) { readyToContinue = false; [[WKWebsiteDataStore defaultDataStore] removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes] modifiedSince:[NSDate distantPast] completionHandler:^() { @@ -86,18 +86,18 @@ auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]); NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"IndexedDBSuspendImminently" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]]; -idbAcitivitiesStarted = false; +idbActivitiesStarted = false; [webView loadRequest:request]; keepNetworkProcessActive(); -runTestAndCheckResult(@"Continue"); +runUntilMessageReceived(@"Continue"); [configuration.get().websiteDataStore _sendNetworkProcessWillSuspendImminently]; [configuration.get().websiteDataStore _sendNetworkProcessDidResume]; -runTestAndCheckResult(@"Expected Abort For Suspension"); -runTestAndCheckResult(@"Expected Success After Resume"); +runUntilMessageReceived(@"Expected Abort For Suspension"); +runUntilMessageReceived(@"Expected Success After Resume"); } static NSString *mainFrameString = @"
[webkit-changes] [293558] trunk/Source/WebGPU
Title: [293558] trunk/Source/WebGPU Revision 293558 Author msab...@apple.com Date 2022-04-27 20:04:58 -0700 (Wed, 27 Apr 2022) Log Message WebGPU doesn't create a symlink to the system content path in installhdrs https://bugs.webkit.org/show_bug.cgi?id=239819 Reviewed by Alexey Proskuryakov. Enabled script phases for installhdrs and installapi. * Configurations/WebGPU.xcconfig: Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/Configurations/WebGPU.xcconfig Diff Modified: trunk/Source/WebGPU/ChangeLog (293557 => 293558) --- trunk/Source/WebGPU/ChangeLog 2022-04-28 03:03:33 UTC (rev 293557) +++ trunk/Source/WebGPU/ChangeLog 2022-04-28 03:04:58 UTC (rev 293558) @@ -1,3 +1,14 @@ +2022-04-27 Michael Saboff + +WebGPU doesn't create a symlink to the system content path in installhdrs +https://bugs.webkit.org/show_bug.cgi?id=239819 + +Reviewed by Alexey Proskuryakov. + +Enabled script phases for installhdrs and installapi. + +* Configurations/WebGPU.xcconfig: + 2022-04-20 Myles C. Maxfield [WebGPU] Expand hardware capabilities to include features (beyond just limits) Modified: trunk/Source/WebGPU/Configurations/WebGPU.xcconfig (293557 => 293558) --- trunk/Source/WebGPU/Configurations/WebGPU.xcconfig 2022-04-28 03:03:33 UTC (rev 293557) +++ trunk/Source/WebGPU/Configurations/WebGPU.xcconfig 2022-04-28 03:04:58 UTC (rev 293558) @@ -59,6 +59,8 @@ OUTPUT_ALTERNATE_ROOT_PATH = $(OUTPUT_ALTERNATE_ROOT_PATH_$(USE_SYSTEM_CONTENT_PATH)); OUTPUT_ALTERNATE_ROOT_PATH_YES = $(DSTROOT)$(ALTERNATE_ROOT_PATH)/$(FULL_PRODUCT_NAME); +INSTALLHDRS_SCRIPT_PHASE = YES; + PRODUCT_NAME = WebGPU; PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293557] trunk
Title: [293557] trunk Revision 293557 Author jbed...@apple.com Date 2022-04-27 20:03:33 -0700 (Wed, 27 Apr 2022) Log Message [git-webkit] Run style checker https://bugs.webkit.org/show_bug.cgi?id=239730 Reviewed by Chris Dumez. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py: (Git): Add webkitscmpy.auto-check option. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.parser): Add --check/--no-check flag. (PullRequest.pre_pr_checks): Find and run all pre-PR checks. (PullRequest.create_pull_request): Run PR checks. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py: * metadata/git_config_extension: Add style-checker as pre-pr check. Canonical link: https://commits.webkit.org/250071@main Modified Paths trunk/ChangeLog trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitscmpy/setup.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py trunk/metadata/git_config_extension Diff Modified: trunk/ChangeLog (293556 => 293557) --- trunk/ChangeLog 2022-04-28 02:46:27 UTC (rev 293556) +++ trunk/ChangeLog 2022-04-28 03:03:33 UTC (rev 293557) @@ -1,3 +1,13 @@ +2022-04-27 Jonathan Bedard + +[git-webkit] Run style checker +https://bugs.webkit.org/show_bug.cgi?id=239730 + + +Reviewed by Chris Dumez. + +* metadata/git_config_extension: Add style-checker as pre-pr check. + 2022-04-26 Michael Catanzaro Unreviewed, add my @redhat.com email Modified: trunk/Tools/ChangeLog (293556 => 293557) --- trunk/Tools/ChangeLog 2022-04-28 02:46:27 UTC (rev 293556) +++ trunk/Tools/ChangeLog 2022-04-28 03:03:33 UTC (rev 293557) @@ -1,5 +1,24 @@ 2022-04-27 Jonathan Bedard +[git-webkit] Run style checker +https://bugs.webkit.org/show_bug.cgi?id=239730 + + +Reviewed by Chris Dumez. + +* Scripts/libraries/webkitscmpy/setup.py: Bump version. +* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. +* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py: +(Git): Add webkitscmpy.auto-check option. +* Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: +(PullRequest.parser): Add --check/--no-check flag. +(PullRequest.pre_pr_checks): Find and run all pre-PR checks. +(PullRequest.create_pull_request): Run PR checks. +* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: +* Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py: + +2022-04-27 Jonathan Bedard + [git-webkit] Cleanup PRs on alternate remotes https://bugs.webkit.org/show_bug.cgi?id=239814 Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (293556 => 293557) --- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-28 02:46:27 UTC (rev 293556) +++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-28 03:03:33 UTC (rev 293557) @@ -29,7 +29,7 @@ setup( name='webkitscmpy', -version='4.11.4', +version='4.12.0', description='Library designed to interact with git and svn repositories.', long_description=readme(), classifiers=[ Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (293556 => 293557) --- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-28 02:46:27 UTC (rev 293556) +++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-28 03:03:33 UTC (rev 293557) @@ -46,7 +46,7 @@ "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `" ) -version = Version(4, 11, 4) +version = Version(4, 12, 0) AutoInstall.register(Package('fasteners', Version(0, 15, 0))) AutoInstall.register(Package('jinja2', Version(2, 11, 3))) Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py (293556 => 293557) --- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2022-04-28 02:46:27 UTC (rev 293556) +++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2022-04-28 03:03:33 UTC (rev 293557) @@ -308,6 +308,7 @@ 'webkitscmpy.pull-request': ['overwrite', 'append'], 'webkitscmpy.history': ['when-user-owned', 'disabled', 'always', 'never'], 'webkitscmpy.update-fork': ['true', 'false'], +'webkitscmpy.auto-check': ['true', 'false'], } CONFIG_LOCATIONS = ['global', 'reposit
[webkit-changes] [293556] tags/WebKit-7613.2.7.2.5/
Title: [293556] tags/WebKit-7613.2.7.2.5/ Revision 293556 Author repst...@apple.com Date 2022-04-27 19:46:27 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7613.2.7.2.5. Added Paths tags/WebKit-7613.2.7.2.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293555] branches/safari-613.2.7.2-branch/Source
Title: [293555] branches/safari-613.2.7.2-branch/Source Revision 293555 Author repst...@apple.com Date 2022-04-27 19:45:52 -0700 (Wed, 27 Apr 2022) Log Message Versioning. WebKit-7613.2.7.2.5 Modified Paths branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293554 => 293555) --- branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-28 02:42:29 UTC (rev 293554) +++ branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-28 02:45:52 UTC (rev 293555) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293554 => 293555) --- branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-28 02:42:29 UTC (rev 293554) +++ branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-28 02:45:52 UTC (rev 293555) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293554 => 293555) --- branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-28 02:42:29 UTC (rev 293554) +++ branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-28 02:45:52 UTC (rev 293555) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig (293554 => 293555) --- branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-28 02:42:29 UTC (rev 293554) +++ branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-28 02:45:52 UTC (rev 293555) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293554 => 293555) --- branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-28 02:42:29 UTC (rev 293554) +++ branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-28 02:45:52 UTC (rev 293555) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig (293554 => 293555) --- branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-28 02:42:29 UTC (rev 293554) +++ branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-28 02:45:52 UTC (rev 293555) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION
[webkit-changes] [293554] tags/WebKit-7613.2.7.3.5/
Title: [293554] tags/WebKit-7613.2.7.3.5/ Revision 293554 Author repst...@apple.com Date 2022-04-27 19:42:29 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7613.2.7.3.5. Added Paths tags/WebKit-7613.2.7.3.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293553] branches/safari-613.2.7.3-branch/Source
Title: [293553] branches/safari-613.2.7.3-branch/Source Revision 293553 Author repst...@apple.com Date 2022-04-27 19:37:36 -0700 (Wed, 27 Apr 2022) Log Message Versioning. WebKit-7613.2.7.3.5 Modified Paths branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293552 => 293553) --- branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-28 02:25:07 UTC (rev 293552) +++ branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-28 02:37:36 UTC (rev 293553) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293552 => 293553) --- branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-28 02:25:07 UTC (rev 293552) +++ branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-28 02:37:36 UTC (rev 293553) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293552 => 293553) --- branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-28 02:25:07 UTC (rev 293552) +++ branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-28 02:37:36 UTC (rev 293553) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig (293552 => 293553) --- branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-28 02:25:07 UTC (rev 293552) +++ branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-28 02:37:36 UTC (rev 293553) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293552 => 293553) --- branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-28 02:25:07 UTC (rev 293552) +++ branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-28 02:37:36 UTC (rev 293553) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig (293552 => 293553) --- branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-28 02:25:07 UTC (rev 293552) +++ branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-28 02:37:36 UTC (rev 293553) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION
[webkit-changes] [293552] tags/WebKit-7613.2.7.0.6/
Title: [293552] tags/WebKit-7613.2.7.0.6/ Revision 293552 Author repst...@apple.com Date 2022-04-27 19:25:07 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7613.2.7.0.6. Added Paths tags/WebKit-7613.2.7.0.6/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293551] branches/safari-613.2.7.0-branch/Source
Title: [293551] branches/safari-613.2.7.0-branch/Source Revision 293551 Author repst...@apple.com Date 2022-04-27 19:24:12 -0700 (Wed, 27 Apr 2022) Log Message Versioning. WebKit-7613.2.7.0.6 Modified Paths branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293550 => 293551) --- branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-28 02:03:42 UTC (rev 293550) +++ branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-28 02:24:12 UTC (rev 293551) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293550 => 293551) --- branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-28 02:03:42 UTC (rev 293550) +++ branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-28 02:24:12 UTC (rev 293551) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293550 => 293551) --- branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-28 02:03:42 UTC (rev 293550) +++ branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-28 02:24:12 UTC (rev 293551) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig (293550 => 293551) --- branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-28 02:03:42 UTC (rev 293550) +++ branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-28 02:24:12 UTC (rev 293551) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293550 => 293551) --- branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-28 02:03:42 UTC (rev 293550) +++ branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-28 02:24:12 UTC (rev 293551) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig (293550 => 293551) --- branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-28 02:03:42 UTC (rev 293550) +++ branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-28 02:24:12 UTC (rev 293551) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION
[webkit-changes] [293550] trunk/Source/WebCore
Title: [293550] trunk/Source/WebCore Revision 293550 Author sihui_...@apple.com Date 2022-04-27 19:03:42 -0700 (Wed, 27 Apr 2022) Log Message Ensure completion handler is called in SWServer::clear https://bugs.webkit.org/show_bug.cgi?id=239755 Reviewed by Youenn Fablet. * workers/service/server/SWServer.cpp: (WebCore::SWServer::clearAll): (WebCore::SWServer::clear): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/server/SWServer.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (293549 => 293550) --- trunk/Source/WebCore/ChangeLog 2022-04-28 00:32:48 UTC (rev 293549) +++ trunk/Source/WebCore/ChangeLog 2022-04-28 02:03:42 UTC (rev 293550) @@ -1,3 +1,14 @@ +2022-04-27 Sihui Liu + +Ensure completion handler is called in SWServer::clear +https://bugs.webkit.org/show_bug.cgi?id=239755 + +Reviewed by Youenn Fablet. + +* workers/service/server/SWServer.cpp: +(WebCore::SWServer::clearAll): +(WebCore::SWServer::clear): + 2022-04-27 Oriol Brufau Reland "Fix CSS cascade regarding logical properties" Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (293549 => 293550) --- trunk/Source/WebCore/workers/service/server/SWServer.cpp 2022-04-28 00:32:48 UTC (rev 293549) +++ trunk/Source/WebCore/workers/service/server/SWServer.cpp 2022-04-28 02:03:42 UTC (rev 293550) @@ -287,8 +287,10 @@ m_registrations.begin()->value->clear(); m_pendingContextDatas.clear(); m_originStore->clearAll(); -if (m_registrationStore) -m_registrationStore->clearAll(WTFMove(completionHandler)); +if (!m_registrationStore) +return completionHandler(); + +m_registrationStore->clearAll(WTFMove(completionHandler)); } void SWServer::startSuspension(CompletionHandler&& completionHandler) @@ -341,8 +343,10 @@ for (auto* registration : registrationsToRemove) registration->clear(); -if (m_registrationStore) -m_registrationStore->flushChanges(WTFMove(completionHandler)); +if (!m_registrationStore) +return completionHandler(); + +m_registrationStore->flushChanges(WTFMove(completionHandler)); } void SWServer::Connection::finishFetchingScriptInServer(const ServiceWorkerJobDataIdentifier& jobDataIdentifier, const ServiceWorkerRegistrationKey& registrationKey, WorkerFetchResult&& result) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293549] trunk/Source/bmalloc
Title: [293549] trunk/Source/bmalloc Revision 293549 Author ross.kirsl...@sony.com Date 2022-04-27 17:32:48 -0700 (Wed, 27 Apr 2022) Log Message Unreviewed libpas build fix for PlayStation. https://bugs.webkit.org/show_bug.cgi?id=239834 * libpas/src/libpas/pas_random.h: (pas_get_random): Temporarily disable path on PlayStation. Canonical link: https://commits.webkit.org/250069@main Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/libpas/src/libpas/pas_random.h Diff Modified: trunk/Source/bmalloc/ChangeLog (293548 => 293549) --- trunk/Source/bmalloc/ChangeLog 2022-04-28 00:29:20 UTC (rev 293548) +++ trunk/Source/bmalloc/ChangeLog 2022-04-28 00:32:48 UTC (rev 293549) @@ -1,3 +1,12 @@ +2022-04-27 Ross Kirsling + +Unreviewed libpas build fix for PlayStation. +https://bugs.webkit.org/show_bug.cgi?id=239834 + +* libpas/src/libpas/pas_random.h: +(pas_get_random): +Temporarily disable path on PlayStation. + 2022-04-25 Brandon Stewart [libpas] Implement secure random numbers Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_random.h (293548 => 293549) --- trunk/Source/bmalloc/libpas/src/libpas/pas_random.h 2022-04-28 00:29:20 UTC (rev 293548) +++ trunk/Source/bmalloc/libpas/src/libpas/pas_random.h 2022-04-28 00:32:48 UTC (rev 293549) @@ -72,12 +72,12 @@ case pas_secure_random: /* Secure random is only supported on Darwin and FreeBSD at the moment due to arc4random being built into the stdlib. Fall back to fast behavior on other operating systems. */ -#if PAS_OS(DARWIN) || PAS_OS(FREEBSD) +#if PAS_OS(DARWIN) || (PAS_OS(FREEBSD) && !PAS_PLATFORM(PLAYSTATION)) rand_value = arc4random_uniform(upper_bound); -#else +#else pas_fast_random_state = pas_xorshift32(pas_fast_random_state); rand_value = pas_fast_random_state % upper_bound; -#endif +#endif break; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293547] trunk/Source/WebInspectorUI
Title: [293547] trunk/Source/WebInspectorUI Revision 293547 Author drou...@apple.com Date 2022-04-27 16:54:13 -0700 (Wed, 27 Apr 2022) Log Message Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this.resource.hadLoadingError') https://bugs.webkit.org/show_bug.cgi?id=239824 Reviewed by Patrick Angle. * UserInterface/Views/LocalResourceOverrideTreeElement.js: (WI.LocalResourceOverrideTreeElement.prototype.updateStatus): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (293546 => 293547) --- trunk/Source/WebInspectorUI/ChangeLog 2022-04-27 23:42:59 UTC (rev 293546) +++ trunk/Source/WebInspectorUI/ChangeLog 2022-04-27 23:54:13 UTC (rev 293547) @@ -1,3 +1,13 @@ +2022-04-27 Devin Rousso + +Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this.resource.hadLoadingError') +https://bugs.webkit.org/show_bug.cgi?id=239824 + +Reviewed by Patrick Angle. + +* UserInterface/Views/LocalResourceOverrideTreeElement.js: +(WI.LocalResourceOverrideTreeElement.prototype.updateStatus): + 2022-04-20 Dan Glastonbury Web Inspector: Improve rendering of GLenums in WebGL canvas recordings. Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js (293546 => 293547) --- trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js 2022-04-27 23:42:59 UTC (rev 293546) +++ trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js 2022-04-27 23:54:13 UTC (rev 293547) @@ -110,7 +110,7 @@ { // Don't call `super` as we don't want `WI.ResourceTreeElement` / `WI.SourceCodeTreeElement` / etc. to modify our status element. -if (this.resource.hadLoadingError()) +if (this.resource?.hadLoadingError()) this.addClassName(WI.ResourceTreeElement.FailedStyleClassName); else this.removeClassName(WI.ResourceTreeElement.FailedStyleClassName); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293546] trunk/Source/WebCore/html
Title: [293546] trunk/Source/WebCore/html Revision 293546 Author cdu...@apple.com Date 2022-04-27 16:42:59 -0700 (Wed, 27 Apr 2022) Log Message Devirtualize InputType validation https://bugs.webkit.org/show_bug.cgi?id=239809 Reviewed by Geoff Garen and Cameron McCormack. HTMLInputElement::isValidValue() used to call 4 virtual functions on InputType and is hot code on Speedometer. To optimize this, HTMLInputElement::isValidValue() now calls a non-virtual HTMLInputElement::isValidValue() which switches on the input type and then calls the 4 functions on the actual InputType subclass, so that the compiler can optimize out the virtual calls out thanks to final optimization. This is a 0.5-0.75% progression on Speedometer on Intel. This might be a very small (~0.2%) progression on Apple Silicon. * Source/WebCore/html/BaseButtonInputType.h: (WebCore::BaseButtonInputType::BaseButtonInputType): * Source/WebCore/html/BaseCheckableInputType.h: (WebCore::BaseCheckableInputType::BaseCheckableInputType): * Source/WebCore/html/BaseClickableWithKeyInputType.h: (WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType): * Source/WebCore/html/BaseDateAndTimeInputType.h: * Source/WebCore/html/BaseTextInputType.h: (WebCore::BaseTextInputType::BaseTextInputType): * Source/WebCore/html/ButtonInputType.h: * Source/WebCore/html/CheckboxInputType.h: * Source/WebCore/html/ColorInputType.h: * Source/WebCore/html/DateInputType.h: * Source/WebCore/html/DateTimeLocalInputType.h: * Source/WebCore/html/EmailInputType.h: * Source/WebCore/html/FileInputType.h: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isValidValue const): * Source/WebCore/html/HiddenInputType.h: * Source/WebCore/html/ImageInputType.h: * Source/WebCore/html/InputType.cpp: (WebCore::validateInputType): (WebCore::InputType::isValidValue const): * Source/WebCore/html/InputType.h: (WebCore::InputType::type const): * Source/WebCore/html/MonthInputType.h: * Source/WebCore/html/NumberInputType.h: * Source/WebCore/html/PasswordInputType.h: * Source/WebCore/html/RadioInputType.h: * Source/WebCore/html/RangeInputType.h: * Source/WebCore/html/ResetInputType.h: * Source/WebCore/html/SearchInputType.h: * Source/WebCore/html/SubmitInputType.h: * Source/WebCore/html/TelephoneInputType.h: * Source/WebCore/html/TextFieldInputType.h: * Source/WebCore/html/TextInputType.h: * Source/WebCore/html/TimeInputType.h: * Source/WebCore/html/URLInputType.h: * Source/WebCore/html/WeekInputType.h: Canonical link: https://commits.webkit.org/250065@main Modified Paths trunk/Source/WebCore/html/BaseButtonInputType.h trunk/Source/WebCore/html/BaseCheckableInputType.h trunk/Source/WebCore/html/BaseClickableWithKeyInputType.h trunk/Source/WebCore/html/BaseDateAndTimeInputType.h trunk/Source/WebCore/html/BaseTextInputType.h trunk/Source/WebCore/html/ButtonInputType.h trunk/Source/WebCore/html/CheckboxInputType.h trunk/Source/WebCore/html/ColorInputType.h trunk/Source/WebCore/html/DateInputType.h trunk/Source/WebCore/html/DateTimeLocalInputType.h trunk/Source/WebCore/html/EmailInputType.h trunk/Source/WebCore/html/FileInputType.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HiddenInputType.h trunk/Source/WebCore/html/ImageInputType.h trunk/Source/WebCore/html/InputType.cpp trunk/Source/WebCore/html/InputType.h trunk/Source/WebCore/html/MonthInputType.h trunk/Source/WebCore/html/NumberInputType.h trunk/Source/WebCore/html/PasswordInputType.h trunk/Source/WebCore/html/RadioInputType.h trunk/Source/WebCore/html/RangeInputType.h trunk/Source/WebCore/html/ResetInputType.h trunk/Source/WebCore/html/SearchInputType.h trunk/Source/WebCore/html/SubmitInputType.h trunk/Source/WebCore/html/TelephoneInputType.h trunk/Source/WebCore/html/TextFieldInputType.h trunk/Source/WebCore/html/TextInputType.h trunk/Source/WebCore/html/TimeInputType.h trunk/Source/WebCore/html/URLInputType.h trunk/Source/WebCore/html/WeekInputType.h Diff Modified: trunk/Source/WebCore/html/BaseButtonInputType.h (293545 => 293546) --- trunk/Source/WebCore/html/BaseButtonInputType.h 2022-04-27 23:42:12 UTC (rev 293545) +++ trunk/Source/WebCore/html/BaseButtonInputType.h 2022-04-27 23:42:59 UTC (rev 293546) @@ -37,14 +37,17 @@ // Base of button, file, image, reset, and submit types. class BaseButtonInputType : public BaseClickableWithKeyInputType { protected: -explicit BaseButtonInputType(Type type, HTMLInputElement& element) : BaseClickableWithKeyInputType(type, element) { } +explicit BaseButtonInputType(Type type, HTMLInputElement& element) +: BaseClickableWithKeyInputType(type, element) +{ +} private: -bool shouldSaveAndRestoreFormControlState() const override; +bool shouldSaveAndRestoreFormControlState() const final; bool appendFormData(DOMFormData&) const override; RenderPtr createInputRenderer(RenderStyle&&) override; -bool storesValueSeparateFromAttribute() override; -void setValue(const String&, boo
[webkit-changes] [293545] trunk/Tools
Title: [293545] trunk/Tools Revision 293545 Author jbed...@apple.com Date 2022-04-27 16:42:12 -0700 (Wed, 27 Apr 2022) Log Message [git-webkit] Cleanup PRs on alternate remotes https://bugs.webkit.org/show_bug.cgi?id=239814 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py: (Clean.parser): Add --remote argument. (Clean.cleanup): Allow caller to specify remote. (Clean.main): Pass remote to cleanup. Canonical link: https://commits.webkit.org/250065@main Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitscmpy/setup.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py Diff Modified: trunk/Tools/ChangeLog (293544 => 293545) --- trunk/Tools/ChangeLog 2022-04-27 23:36:54 UTC (rev 293544) +++ trunk/Tools/ChangeLog 2022-04-27 23:42:12 UTC (rev 293545) @@ -1,5 +1,20 @@ 2022-04-27 Jonathan Bedard +[git-webkit] Cleanup PRs on alternate remotes +https://bugs.webkit.org/show_bug.cgi?id=239814 + + +Reviewed by Aakash Jain. + +* Scripts/libraries/webkitscmpy/setup.py: Bump version. +* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. +* Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py: +(Clean.parser): Add --remote argument. +(Clean.cleanup): Allow caller to specify remote. +(Clean.main): Pass remote to cleanup. + +2022-04-27 Jonathan Bedard + [ews-build.webkit.org] Support alternative remotes (Follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=239617 Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (293544 => 293545) --- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-27 23:36:54 UTC (rev 293544) +++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-27 23:42:12 UTC (rev 293545) @@ -29,7 +29,7 @@ setup( name='webkitscmpy', -version='4.11.3', +version='4.11.4', description='Library designed to interact with git and svn repositories.', long_description=readme(), classifiers=[ Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (293544 => 293545) --- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-27 23:36:54 UTC (rev 293544) +++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-27 23:42:12 UTC (rev 293545) @@ -46,7 +46,7 @@ "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `" ) -version = Version(4, 11, 3) +version = Version(4, 11, 4) AutoInstall.register(Package('fasteners', Version(0, 15, 0))) AutoInstall.register(Package('jinja2', Version(2, 11, 3))) Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py (293544 => 293545) --- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py 2022-04-27 23:36:54 UTC (rev 293544) +++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py 2022-04-27 23:42:12 UTC (rev 293545) @@ -41,15 +41,24 @@ type=str, default=None, help='String representation(s) of a commit or branch to be cleaned', ) +parser.add_argument( +'--remote', dest='remote', type=str, default=None, +help='Specify remote to search for pull request from.', +) @classmethod -def cleanup(cls, repository, argument): +def cleanup(cls, repository, argument, remote_target=None): if not repository.is_git: sys.stderr('Can only cleanup branches on git repositories\n') return 1 -rmt = repository.remote() -target = 'fork' if isinstance(rmt, remote.GitHub) else 'origin' +rmt = repository.remote(name=remote_target) +if isinstance(rmt, remote.GitHub) and remote_target in (None, 'origin'): +target = 'fork' +elif isinstance(rmt, remote.GitHub): +target = '{}-fork'.format(remote_target) +else: +target = 'origin' match = cls.PR_RE.match(argument) if match: @@ -103,5 +112,5 @@ result = 0 for argument in args.arguments: -result += cls.cleanup(repository, argument) +result += cls.cleanup(repository, argument, remote_target=args.remote) return result ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293544] trunk/Source/WTF
Title: [293544] trunk/Source/WTF Revision 293544 Author commit-qu...@webkit.org Date 2022-04-27 16:36:54 -0700 (Wed, 27 Apr 2022) Log Message [PGO] Allow collecting other kinds of pgo profiles. https://bugs.webkit.org/show_bug.cgi?id=239776 Reviewed by Saam Barati. Update the way we collect PGO profiles to use LLVM's file handling, because it really seems to care about that. This allowws us to try out other kinds of profile generation, like the IR-based -fcs-profile-generate. * Source/WTF/wtf/GenerateProfiles.h: (WTF::registerProfileGenerationCallback): Canonical link: https://commits.webkit.org/250064@main Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/GenerateProfiles.h Diff Modified: trunk/Source/WTF/ChangeLog (293543 => 293544) --- trunk/Source/WTF/ChangeLog 2022-04-27 22:58:31 UTC (rev 293543) +++ trunk/Source/WTF/ChangeLog 2022-04-27 23:36:54 UTC (rev 293544) @@ -1,3 +1,17 @@ +2022-04-26 Justin Michaud + +[PGO] Allow collecting other kinds of pgo profiles +https://bugs.webkit.org/show_bug.cgi?id=239776 + +Reviewed by Saam Barati. + +Update the way we collect PGO profiles to use LLVM's file handling, because +it really seems to care about that. This allowws us to try out other kinds +of profile generation, like the IR-based -fcs-profile-generate. + +* wtf/GenerateProfiles.h: +(WTF::registerProfileGenerationCallback): + 2022-04-27 Diego Pino Garcia [GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref' Modified: trunk/Source/WTF/wtf/GenerateProfiles.h (293543 => 293544) --- trunk/Source/WTF/wtf/GenerateProfiles.h 2022-04-27 22:58:31 UTC (rev 293543) +++ trunk/Source/WTF/wtf/GenerateProfiles.h 2022-04-27 23:36:54 UTC (rev 293544) @@ -32,8 +32,8 @@ #include #include -extern "C" uint64_t __llvm_profile_get_size_for_buffer(); -extern "C" int __llvm_profile_write_buffer(char *); +extern "C" int __llvm_profile_write_file(void); +extern "C" void __llvm_profile_set_filename(const char*); extern "C" void __llvm_profile_reset_counters(void); #endif @@ -44,37 +44,48 @@ ALWAYS_INLINE void registerProfileGenerationCallback(const char* name) { #if ENABLE(LLVM_PROFILE_GENERATION) +constexpr int WRITE_SUCCESS = 0; + +static int profileCount = 0; +static NeverDestroyed profileFileBase; +static NeverDestroyed profileFileName; static std::once_flag registerFlag; std::call_once(registerFlag, [name] { -WTFLogAlways("<%s><%d><0>: Registering callback for profile data.", name, getpid()); +int pid = getpid(); +WTFLogAlways("<%s><%d>: Registering callback for profile data.", name, pid); WTFLogAlways(" To collect a profile: `notifyutil -p com.apple.WebKit.profiledata`"); WTFLogAlways(" To copy the output: `" R"HERE(log stream --style json --color none | perl -mFile::Basename -mFile::Copy -nle 'if (m/.*(.*)/) { (my $l = $1) =~ s/\\\//\//g; my $b = File::Basename::basename($l); my $d = "./profiles/$b"; print "Moving $l to $d"; File::Copy::move($l, $d); }')HERE" "`."); WTFLogAlways(" To sanity-check the output: `for f in ./profiles/*; do echo $f; xcrun -sdk macosx.internal llvm-profdata show $f; done;`."); -int token; -notify_register_dispatch("com.apple.WebKit.profiledata", &token, dispatch_get_main_queue(), ^(int) { -int pid = getpid(); -int64_t time = MonotonicTime::now().secondsSinceEpoch().milliseconds(); -auto bufferSize = __llvm_profile_get_size_for_buffer(); -WTFLogAlways("<%s><%d><%lld>: LLVM collected %llu bytes of profile data.", -name, pid, time, bufferSize); +{ +// Maybe we could use %t instead here, but this folder is permitted through the sandbox because of ANGLE. +FileSystem::PlatformFileHandle fileHandle; +auto filePath = FileSystem::openTemporaryFile(makeString(name, "-", getpid()), fileHandle, ".profraw"); +profileFileBase.get() = String::fromUTF8(filePath.utf8().data()); +FileSystem::closeFile(fileHandle); +} -auto* buffer = static_cast(calloc(sizeof(char), bufferSize)); -__llvm_profile_write_buffer(buffer); +WTFLogAlways("<%s><%d>: We will dump the resulting profile to %s.", name, pid, profileFileBase->utf8().data()); -String fileName(String::fromUTF8(name) + "-" + pid + "-" + time + "-"); +int token; +notify_register_dispatch("com.apple.WebKit.profiledata", &token, dispatch_get_main_queue(), ^(int) { +profileFileName.get() = makeString(profileFileBase.get(), ".", profileCount++, ".profraw"); +__llvm_profile_set_filename(profileFileName->utf8().data()); // Must stay alive while it is used by llvm. -FileSystem::PlatformFileHandle fileHandle; -auto filePath = FileSystem::openTemporaryFile(fileN
[webkit-changes] [293543] trunk
Title: [293543] trunk Revision 293543 Author obru...@igalia.com Date 2022-04-27 15:58:31 -0700 (Wed, 27 Apr 2022) Log Message LayoutTests/imported/w3c: Fix CSS cascade regarding logical properties https://bugs.webkit.org/show_bug.cgi?id=236199 Reviewed by Darin Adler. Expect animation-004.html to pass. Add new test logicalprops-with-deferred-writing-mode.html * web-platform-tests/css/css-logical/animation-004-expected.txt: * web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode-expected.txt: Added. * web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html: Added. Source/WebCore: Reland "Fix CSS cascade regarding logical properties" https://bugs.webkit.org/show_bug.cgi?id=236199 Reviewed by Antti Koivisto. This is a reland of https://commits.webkit.org/r291546, which was reverted due to a performance regression. This problem should have been addressed by bug 238260. Original summary: > The CSS cascade was trying to resolve logical properties into physical > ones too early. This failed if we still didn't know the direction or > writing-mode, e.g. because they were set to a variable or to a CSS-wide > keyword. > > This patch keeps logical properties as-is during the cascade. They are > only resolved when finally applied. Also, both logical properties and > their physical equivalents are now set to apply in parse order, since > 'height: 0px; block-size: 1px' and 'block-size: 1px; height: 0px' can be > different, the order matters. Tests: imported/w3c/web-platform-tests/css/css-logical/animation-004.html imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html * css/makeprop.pl: (addProperty): (sortByDescendingPriorityAndName): Defer properties that belong to a logical property group. * css/parser/CSSParser.cpp: (WebCore::CSSParser::parseValueWithVariableReferences): Logical properties no longer need special handling for variables. * style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::PropertyCascade): Remove members no longer needed. (WebCore::Style::PropertyCascade::set): This method is no longer used for properties in a logical property group. Remove dead code and add assert. (WebCore::Style::PropertyCascade::setDeferred): Remove assert, logical properties are now handled here. (WebCore::Style::PropertyCascade::lastDeferredPropertyResolvingRelated const): Take into account that properties in a logical property group are now deferred. (WebCore::Style::PropertyCascade::resolveDirectionAndWritingMode const): Deleted. (WebCore::Style::PropertyCascade::direction const): Deleted. Remove broken logic. * style/PropertyCascade.h: Remove members, struct and methods no longer needed. Update method signatures. * style/StyleBuilder.cpp: (WebCore::Style::Builder::Builder): Remove argument no longer needed. (WebCore::Style::Builder::applyProperty): Resolve logical properties using the direction and writing-mode from the style. (WebCore::Style::directionFromStyle): Deleted. Remove function no longer needed. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-004-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/makeprop.pl trunk/Source/WebCore/css/parser/CSSParser.cpp trunk/Source/WebCore/style/PropertyCascade.cpp trunk/Source/WebCore/style/PropertyCascade.h trunk/Source/WebCore/style/StyleBuilder.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293542 => 293543) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 22:46:30 UTC (rev 293542) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 22:58:31 UTC (rev 293543) @@ -1,3 +1,17 @@ +2022-04-27 Oriol Brufau + +Fix CSS cascade regarding logical properties +https://bugs.webkit.org/show_bug.cgi?id=236199 + +Reviewed by Darin Adler. + +Expect animation-004.html to pass. +Add new test logicalprops-with-deferred-writing-mode.html + +* web-platform-tests/css/css-logical/animation-004-expected.txt: +* web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode-expected.txt: Added. +* web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html: Added. + 2022-04-27 Tim Nguyen Rebaseline imported/w3c/web-platform-tests/css/css-text/inheritance.html after r293521 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-004-expected.txt (293542 => 293543) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-004-expected.txt 2022-04-27 22:46:30 UTC (rev 293542) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logi
[webkit-changes] [293542] tags/WebKit-7614.1.11/
Title: [293542] tags/WebKit-7614.1.11/ Revision 293542 Author alanc...@apple.com Date 2022-04-27 15:46:30 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7614.1.11. Added Paths tags/WebKit-7614.1.11/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293541] trunk/Source/WebInspectorUI
Title: [293541] trunk/Source/WebInspectorUI Revision 293541 Author commit-qu...@webkit.org Date 2022-04-27 15:38:00 -0700 (Wed, 27 Apr 2022) Log Message Web Inspector: Improve rendering of GLenums in WebGL canvas recordings. https://bugs.webkit.org/show_bug.cgi?id=239586 Patch by Dan Glastonbury on 2022-04-27 Reviewed by Devin Rousso. * Source/WebInspectorUI/UserInterface/Models/RecordingAction.js: (WI.RecordingAction.constantNameForParameter): Arrays are also objects, so checking for typeof x == "object" is not enough to distinguish arrays from dictionaries. Since the if above the failing check was handling arrays, turn "object" check into an `else if` handles arrays and dictionaries correctly. Canonical link: https://commits.webkit.org/250062@main Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (293540 => 293541) --- trunk/Source/WebInspectorUI/ChangeLog 2022-04-27 22:31:21 UTC (rev 293540) +++ trunk/Source/WebInspectorUI/ChangeLog 2022-04-27 22:38:00 UTC (rev 293541) @@ -1,3 +1,17 @@ +2022-04-20 Dan Glastonbury + +Web Inspector: Improve rendering of GLenums in WebGL canvas recordings. +https://bugs.webkit.org/show_bug.cgi?id=239586 + +Reviewed by Devin Rousso. + +* UserInterface/Models/RecordingAction.js: +(WI.RecordingAction.constantNameForParameter): +Arrays are also objects, so checking for typeof x == "object" is +not enough to distinguish arrays from dictionaries. Since the if +above the failing check was handling arrays, turn "object" check +into an `else if` handles arrays and dictionaries correctly. + 2022-04-27 Ziran Sun [css-ui] Remove some unimplemented -webkit-appearance keywords Modified: trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js (293540 => 293541) --- trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js 2022-04-27 22:31:21 UTC (rev 293540) +++ trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js 2022-04-27 22:38:00 UTC (rev 293541) @@ -125,10 +125,10 @@ if (!indexesForAction) return null; -if (Array.isArray(indexesForAction) && !indexesForAction.includes(index)) -return null; - -if (typeof indexesForAction === "object") { +if (Array.isArray(indexesForAction)) { +if (!indexesForAction.includes(index)) +return null; +} else if (typeof indexesForAction === "object") { let indexesForActionVariant = indexesForAction[count]; if (!indexesForActionVariant) return null; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293540] tags/WebKit-7613.2.7.0.5/
Title: [293540] tags/WebKit-7613.2.7.0.5/ Revision 293540 Author alanc...@apple.com Date 2022-04-27 15:31:21 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7613.2.7.0.5. Added Paths tags/WebKit-7613.2.7.0.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293539] tags/WebKit-7613.2.7.1.6/
Title: [293539] tags/WebKit-7613.2.7.1.6/ Revision 293539 Author alanc...@apple.com Date 2022-04-27 15:29:31 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7613.2.7.1.6. Added Paths tags/WebKit-7613.2.7.1.6/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293538] branches/safari-613.2.7.1-branch/Source/WebKit
Title: [293538] branches/safari-613.2.7.1-branch/Source/WebKit Revision 293538 Author alanc...@apple.com Date 2022-04-27 15:26:28 -0700 (Wed, 27 Apr 2022) Log Message Cherry-pick r293481. rdar://problem/92336270 Adjust what we consider to be private relayed https://bugs.webkit.org/show_bug.cgi?id=239784 Patch by Alex Christensen on 2022-04-26 Reviewed by Geoffrey Garen. If a request is not eligible for private relay, then do not consider it having been private relayed. * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613.2.7.1-branch/Source/WebKit/ChangeLog branches/safari-613.2.7.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm Diff Modified: branches/safari-613.2.7.1-branch/Source/WebKit/ChangeLog (293537 => 293538) --- branches/safari-613.2.7.1-branch/Source/WebKit/ChangeLog 2022-04-27 22:25:24 UTC (rev 293537) +++ branches/safari-613.2.7.1-branch/Source/WebKit/ChangeLog 2022-04-27 22:26:28 UTC (rev 293538) @@ -1,3 +1,34 @@ +2022-04-27 Alan Coon + +Cherry-pick r293481. rdar://problem/92336270 + +Adjust what we consider to be private relayed +https://bugs.webkit.org/show_bug.cgi?id=239784 + + +Patch by Alex Christensen on 2022-04-26 +Reviewed by Geoffrey Garen. + +If a request is not eligible for private relay, then do not consider it having been private relayed. + +* NetworkProcess/cocoa/NetworkSessionCocoa.mm: +(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-04-26 Alex Christensen + +Adjust what we consider to be private relayed +https://bugs.webkit.org/show_bug.cgi?id=239784 + + +Reviewed by Geoffrey Garen. + +If a request is not eligible for private relay, then do not consider it having been private relayed. + +* NetworkProcess/cocoa/NetworkSessionCocoa.mm: +(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): + 2022-04-22 Russell Epstein Cherry-pick r291589. rdar://problem/90511155 Modified: branches/safari-613.2.7.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (293537 => 293538) --- branches/safari-613.2.7.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-27 22:25:24 UTC (rev 293537) +++ branches/safari-613.2.7.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-27 22:26:28 UTC (rev 293538) @@ -930,7 +930,9 @@ NSURLSessionTaskTransactionMetrics *metrics = taskMetrics.transactionMetrics.lastObject; #if HAVE(NETWORK_CONNECTION_PRIVACY_STANCE) -auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_direct ? PrivateRelayed::No : PrivateRelayed::Yes; +auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_direct +|| metrics._privacyStance == nw_connection_privacy_stance_not_eligible +? PrivateRelayed::No : PrivateRelayed::Yes; #else auto privateRelayed = PrivateRelayed::No; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293537] branches/safari-613.2.7.0-branch/Source/WebKit
Title: [293537] branches/safari-613.2.7.0-branch/Source/WebKit Revision 293537 Author alanc...@apple.com Date 2022-04-27 15:25:24 -0700 (Wed, 27 Apr 2022) Log Message Cherry-pick r293481. rdar://problem/92336270 Adjust what we consider to be private relayed https://bugs.webkit.org/show_bug.cgi?id=239784 Patch by Alex Christensen on 2022-04-26 Reviewed by Geoffrey Garen. If a request is not eligible for private relay, then do not consider it having been private relayed. * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613.2.7.0-branch/Source/WebKit/ChangeLog branches/safari-613.2.7.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm Diff Modified: branches/safari-613.2.7.0-branch/Source/WebKit/ChangeLog (293536 => 293537) --- branches/safari-613.2.7.0-branch/Source/WebKit/ChangeLog 2022-04-27 21:45:40 UTC (rev 293536) +++ branches/safari-613.2.7.0-branch/Source/WebKit/ChangeLog 2022-04-27 22:25:24 UTC (rev 293537) @@ -1,3 +1,34 @@ +2022-04-27 Alan Coon + +Cherry-pick r293481. rdar://problem/92336270 + +Adjust what we consider to be private relayed +https://bugs.webkit.org/show_bug.cgi?id=239784 + + +Patch by Alex Christensen on 2022-04-26 +Reviewed by Geoffrey Garen. + +If a request is not eligible for private relay, then do not consider it having been private relayed. + +* NetworkProcess/cocoa/NetworkSessionCocoa.mm: +(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-04-26 Alex Christensen + +Adjust what we consider to be private relayed +https://bugs.webkit.org/show_bug.cgi?id=239784 + + +Reviewed by Geoffrey Garen. + +If a request is not eligible for private relay, then do not consider it having been private relayed. + +* NetworkProcess/cocoa/NetworkSessionCocoa.mm: +(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): + 2022-04-22 Alan Coon Cherry-pick r291724. rdar://problem/91975589 Modified: branches/safari-613.2.7.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (293536 => 293537) --- branches/safari-613.2.7.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-27 21:45:40 UTC (rev 293536) +++ branches/safari-613.2.7.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-27 22:25:24 UTC (rev 293537) @@ -930,7 +930,9 @@ NSURLSessionTaskTransactionMetrics *metrics = taskMetrics.transactionMetrics.lastObject; #if HAVE(NETWORK_CONNECTION_PRIVACY_STANCE) -auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_direct ? PrivateRelayed::No : PrivateRelayed::Yes; +auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_direct +|| metrics._privacyStance == nw_connection_privacy_stance_not_eligible +? PrivateRelayed::No : PrivateRelayed::Yes; #else auto privateRelayed = PrivateRelayed::No; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293536] tags/WebKit-7613.2.7.3.4/
Title: [293536] tags/WebKit-7613.2.7.3.4/ Revision 293536 Author alanc...@apple.com Date 2022-04-27 14:45:40 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7613.2.7.3.4. Added Paths tags/WebKit-7613.2.7.3.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293535] branches/safari-613.2.7.3-branch/Source
Title: [293535] branches/safari-613.2.7.3-branch/Source Revision 293535 Author alanc...@apple.com Date 2022-04-27 14:44:44 -0700 (Wed, 27 Apr 2022) Log Message Versioning. WebKit-7613.2.7.3.4 Modified Paths branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.7.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293534 => 293535) --- branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 21:30:33 UTC (rev 293534) +++ branches/safari-613.2.7.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 21:44:44 UTC (rev 293535) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293534 => 293535) --- branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 21:30:33 UTC (rev 293534) +++ branches/safari-613.2.7.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 21:44:44 UTC (rev 293535) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293534 => 293535) --- branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 21:30:33 UTC (rev 293534) +++ branches/safari-613.2.7.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 21:44:44 UTC (rev 293535) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig (293534 => 293535) --- branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 21:30:33 UTC (rev 293534) +++ branches/safari-613.2.7.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 21:44:44 UTC (rev 293535) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293534 => 293535) --- branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 21:30:33 UTC (rev 293534) +++ branches/safari-613.2.7.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 21:44:44 UTC (rev 293535) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig (293534 => 293535) --- branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 21:30:33 UTC (rev 293534) +++ branches/safari-613.2.7.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 21:44:44 UTC (rev 293535) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION
[webkit-changes] [293534] tags/WebKit-7613.2.7.2.4/
Title: [293534] tags/WebKit-7613.2.7.2.4/ Revision 293534 Author alanc...@apple.com Date 2022-04-27 14:30:33 -0700 (Wed, 27 Apr 2022) Log Message Tag WebKit-7613.2.7.2.4. Added Paths tags/WebKit-7613.2.7.2.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293533] branches/safari-613.2.7.2-branch/Source
Title: [293533] branches/safari-613.2.7.2-branch/Source Revision 293533 Author alanc...@apple.com Date 2022-04-27 14:29:27 -0700 (Wed, 27 Apr 2022) Log Message Versioning. WebKit-7613.2.7.2.4 Modified Paths branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.7.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293532 => 293533) --- branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 20:41:19 UTC (rev 293532) +++ branches/safari-613.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 21:29:27 UTC (rev 293533) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 2; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293532 => 293533) --- branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 20:41:19 UTC (rev 293532) +++ branches/safari-613.2.7.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 21:29:27 UTC (rev 293533) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 2; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293532 => 293533) --- branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 20:41:19 UTC (rev 293532) +++ branches/safari-613.2.7.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 21:29:27 UTC (rev 293533) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 2; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig (293532 => 293533) --- branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 20:41:19 UTC (rev 293532) +++ branches/safari-613.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 21:29:27 UTC (rev 293533) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 2; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293532 => 293533) --- branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 20:41:19 UTC (rev 293532) +++ branches/safari-613.2.7.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 21:29:27 UTC (rev 293533) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 2; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig (293532 => 293533) --- branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 20:41:19 UTC (rev 293532) +++ branches/safari-613.2.7.2-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 21:29:27 UTC (rev 293533) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 2; -NANO_VERSION = 2; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION
[webkit-changes] [293532] trunk/LayoutTests
Title: [293532] trunk/LayoutTests Revision 293532 Author commit-qu...@webkit.org Date 2022-04-27 13:41:19 -0700 (Wed, 27 Apr 2022) Log Message [ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=239822 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/250061@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (293531 => 293532) --- trunk/LayoutTests/ChangeLog 2022-04-27 20:20:30 UTC (rev 293531) +++ trunk/LayoutTests/ChangeLog 2022-04-27 20:41:19 UTC (rev 293532) @@ -1,3 +1,12 @@ +2022-04-27 Karl Rackler + +[ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure +https://bugs.webkit.org/show_bug.cgi?id=239822 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2022-04-27 Eric Carlson [iOS] unable to start playing audio when device is locked Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (293531 => 293532) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-27 20:20:30 UTC (rev 293531) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-27 20:41:19 UTC (rev 293532) @@ -1745,3 +1745,6 @@ webkit.org/b/239770 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Pass Crash ] webkit.org/b/239818 [ Debug ] fast/css/identical-logical-height-decl.html [ Pass ImageOnlyFailure ] + +webkit.org/b/239818 [ Debug ] fast/css/variables/test-suite/168.html [ Pass ImageOnlyFailure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293531] trunk/Source/WebCore
Title: [293531] trunk/Source/WebCore Revision 293531 Author commit-qu...@webkit.org Date 2022-04-27 13:20:30 -0700 (Wed, 27 Apr 2022) Log Message [GStreamer] Track handling fixes https://bugs.webkit.org/show_bug.cgi?id=239702 Patch by Philippe Normand on 2022-04-27 Reviewed by Xabier Rodriguez-Calvar. When the player is using playbin3 the audio/video/text tracks are associated to the corresponding GstStream, itself part of a single GstStreamCollection. There is no need to use a GRefPtr for GstStream in this case because those streams are not meant to be modified and they remain valid as long as the parent collection is alive. So the player now keeps track of the current stream collection and the private tracks handle GstStream pointers. The stream collection handling was refactored, removing redundant logging, making use of ScopeExit and removing the special case for text tracks creation. This patch also changes the internal storage of tracks from HashMap> to HashMap>, bringing us a bit closer to the AVF implementation. * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp: (WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer): (WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromTags): (WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps): (WebCore::AudioTrackPrivateGStreamer::kind const): (WebCore::AudioTrackPrivateGStreamer::disconnect): * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp: (WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer): * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h: (WebCore::InbandTextTrackPrivateGStreamer::create): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack): (WebCore::MediaPlayerPrivateGStreamer::updateEnabledVideoTrack): (WebCore::MediaPlayerPrivateGStreamer::updateEnabledAudioTrack): (WebCore::MediaPlayerPrivateGStreamer::playbin3SendSelectStreamsIfAppropriate): (WebCore::MediaPlayerPrivateGStreamer::updateTracks): (WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage): (WebCore::MediaPlayerPrivateGStreamer::handleMessage): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp: (WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer): (WebCore::TrackPrivateBaseGStreamer::disconnect): (WebCore::TrackPrivateBaseGStreamer::tagsChanged): * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: (WebCore::TrackPrivateBaseGStreamer::stream const): (WebCore::TrackPrivateBaseGStreamer::stream): Deleted. * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: (WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer): (WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags): (WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps): (WebCore::VideoTrackPrivateGStreamer::kind const): (WebCore::VideoTrackPrivateGStreamer::disconnect): * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Canonical link: https://commits.webkit.org/250060@main Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h Diff Modified: trunk/Source/WebCore/ChangeLog (293530 => 293531) --- trunk/Source/WebCore/ChangeLog 2022-04-27 20:18:06 UTC (rev 293530) +++ trunk/Source/WebCore/ChangeLog 2022-04-27 20:20:30 UTC (rev 293531) @@ -1,3 +1,57 @@ +2022-04-24 Philippe Normand + +[GStreamer] Track handling fixes +https://bugs.webkit.org/show_bug.cgi?id=239702 + +Reviewed by Xabier Rodriguez-Calvar. + +When the player is using playbin3 the audio/video/text tracks are associated to the +corresponding GstStream, itself part of a single GstStreamCollection. There is no need to +use a GRefPtr for GstStream in this case because those streams are not meant to be modified +and they remain valid as long as the parent collection is alive. So the player now keeps +track of the current stream collection and the private tracks handle GstStream pointers. + +The stream collection handling was refactored,
[webkit-changes] [293530] trunk
Title: [293530] trunk Revision 293530 Author eric.carl...@apple.com Date 2022-04-27 13:18:06 -0700 (Wed, 27 Apr 2022) Log Message [iOS] unable to start playing audio when device is locked https://bugs.webkit.org/show_bug.cgi?id=239812 Reviewed by Jer Noble. Source/WebCore: Updated media/audio-session-category.html. * platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::updateSessionState): Choose the appropriate route sharing policy after choosing the audio session category because setting MediaPlayback+Default makes a process ineligible for NowPlaying, and starting playback in the background will be blocked. * platform/audio/mac/AudioSessionMac.h: * platform/audio/mac/AudioSessionMac.mm: (WebCore::AudioSessionMac::setCategory): Updated for testing. * testing/Internals.cpp: (WebCore::Internals::routeSharingPolicy const): Added accessor for testing. * testing/Internals.h: * testing/Internals.idl: LayoutTests: * media/audio-session-category-expected.txt: * media/audio-session-category.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/audio-session-category-expected.txt trunk/LayoutTests/media/audio-session-category.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm trunk/Source/WebCore/platform/audio/mac/AudioSessionMac.h trunk/Source/WebCore/platform/audio/mac/AudioSessionMac.mm trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl Diff Modified: trunk/LayoutTests/ChangeLog (293529 => 293530) --- trunk/LayoutTests/ChangeLog 2022-04-27 19:50:24 UTC (rev 293529) +++ trunk/LayoutTests/ChangeLog 2022-04-27 20:18:06 UTC (rev 293530) @@ -1,3 +1,14 @@ +2022-04-27 Eric Carlson + +[iOS] unable to start playing audio when device is locked +https://bugs.webkit.org/show_bug.cgi?id=239812 + + +Reviewed by Jer Noble. + +* media/audio-session-category-expected.txt: +* media/audio-session-category.html: + 2022-04-27 Karl Rackler [ macOS Debug wk2 ] fast/css/identical-logical-height-decl.html is a flaky image failure Modified: trunk/LayoutTests/media/audio-session-category-expected.txt (293529 => 293530) --- trunk/LayoutTests/media/audio-session-category-expected.txt 2022-04-27 19:50:24 UTC (rev 293529) +++ trunk/LayoutTests/media/audio-session-category-expected.txt 2022-04-27 20:18:06 UTC (rev 293530) @@ -14,19 +14,23 @@ RUN(video.play()) EVENT(playing) EXPECTED (internals.audioSessionCategory() == 'None') OK +EXPECTED (internals.routeSharingPolicy() == 'Default') OK ** Check category when an unmuted element is playing. RUN(video.muted = false) EVENT(volumechange) EXPECTED (internals.audioSessionCategory() == 'MediaPlayback') OK +EXPECTED (internals.routeSharingPolicy() == 'LongFormAudio') OK ** Mute the element, check again after 500ms. RUN(video.pause()) RUN(video.muted = true) EXPECTED (internals.audioSessionCategory() == 'MediaPlayback') OK +EXPECTED (internals.routeSharingPolicy() == 'LongFormAudio') OK ** And check again after 3 seconds. EXPECTED (internals.audioSessionCategory() == 'None') OK +EXPECTED (internals.routeSharingPolicy() == 'Default') OK ** AudioContext test ** @@ -39,12 +43,15 @@ ** Check category after starting oscillator. EXPECTED (internals.audioSessionCategory() == 'AmbientSound') OK +EXPECTED (internals.routeSharingPolicy() == 'Default') OK ** Close the context, check again after 500ms. EXPECTED (internals.audioSessionCategory() == 'AmbientSound') OK +EXPECTED (internals.routeSharingPolicy() == 'Default') OK ** And check again after 3 seconds. EXPECTED (internals.audioSessionCategory() == 'None') OK +EXPECTED (internals.routeSharingPolicy() == 'Default') OK ** MediaStream test ** @@ -54,11 +61,13 @@ ** Check category when capturing. EXPECTED (internals.audioSessionCategory() == 'PlayAndRecord') OK +EXPECTED (internals.routeSharingPolicy() == 'Default') OK ** Check after MediaStream is attached to audio element. RUN(video.play()) EVENT(playing) EXPECTED (internals.audioSessionCategory() == 'PlayAndRecord') OK +EXPECTED (internals.routeSharingPolicy() == 'Default') OK ** Check after MediaStream muting audio track. EXPECTED (internals.audioSessionCategory() == 'PlayAndRecord') OK Modified: trunk/LayoutTests/media/audio-session-category.html (293529 => 293530) --- trunk/LayoutTests/media/audio-session-category.html 2022-04-27 19:50:24 UTC (rev 293529) +++ trunk/LayoutTests/media/audio-session-category.html 2022-04-27 20:18:06 UTC (rev 293530) @@ -36,11 +36,13 @@ runWithKeyDown(() => { run('video.play()') }); await waitFor(video, 'playing'); testExpected('internals.audioSessionCategory()', 'None'); - +testExpected('internals.routeSharingPolicy()', 'Default'); + consoleWrite('** Check category whe
[webkit-changes] [293529] trunk/LayoutTests
Title: [293529] trunk/LayoutTests Revision 293529 Author commit-qu...@webkit.org Date 2022-04-27 12:50:24 -0700 (Wed, 27 Apr 2022) Log Message [ macOS Debug wk2 ] fast/css/identical-logical-height-decl.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=239818 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/250058@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (293528 => 293529) --- trunk/LayoutTests/ChangeLog 2022-04-27 19:13:45 UTC (rev 293528) +++ trunk/LayoutTests/ChangeLog 2022-04-27 19:50:24 UTC (rev 293529) @@ -1,3 +1,12 @@ +2022-04-27 Karl Rackler + +[ macOS Debug wk2 ] fast/css/identical-logical-height-decl.html is a flaky image failure +https://bugs.webkit.org/show_bug.cgi?id=239818 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2022-04-27 Tim Nguyen Make -webkit-transform-style an alias of transform-style Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (293528 => 293529) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-27 19:13:45 UTC (rev 293528) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-27 19:50:24 UTC (rev 293529) @@ -1742,4 +1742,6 @@ webkit.org/b/239770 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_timeupdate.html [ Pass Crash ] webkit.org/b/239770 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/networkState_during_progress.html [ Pass Crash ] webkit.org/b/239770 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplay.html [ Pass Crash ] -webkit.org/b/239770 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Pass Crash ] \ No newline at end of file +webkit.org/b/239770 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Pass Crash ] + +webkit.org/b/239818 [ Debug ] fast/css/identical-logical-height-decl.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293528] trunk/LayoutTests/imported/w3c
Title: [293528] trunk/LayoutTests/imported/w3c Revision 293528 Author n...@apple.com Date 2022-04-27 12:13:45 -0700 (Wed, 27 Apr 2022) Log Message Rebaseline imported/w3c/web-platform-tests/css/css-text/inheritance.html after r293521 https://bugs.webkit.org/show_bug.cgi?id=166782 Unreviewed test gardening. * web-platform-tests/css/css-text/inheritance-expected.txt: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293527 => 293528) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 19:09:37 UTC (rev 293527) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 19:13:45 UTC (rev 293528) @@ -1,5 +1,14 @@ 2022-04-27 Tim Nguyen +Rebaseline imported/w3c/web-platform-tests/css/css-text/inheritance.html after r293521 +https://bugs.webkit.org/show_bug.cgi?id=166782 + +Unreviewed test gardening. + +* web-platform-tests/css/css-text/inheritance-expected.txt: + +2022-04-27 Tim Nguyen + Make -webkit-transform-style an alias of transform-style https://bugs.webkit.org/show_bug.cgi?id=239808 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt (293527 => 293528) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt 2022-04-27 19:09:37 UTC (rev 293527) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt 2022-04-27 19:13:45 UTC (rev 293528) @@ -8,7 +8,7 @@ PASS Property line-break has initial value auto PASS Property line-break inherits PASS Property overflow-wrap has initial value normal -FAIL Property overflow-wrap inherits assert_equals: expected "break-word" but got "normal" +PASS Property overflow-wrap inherits PASS Property tab-size has initial value 8 PASS Property tab-size inherits FAIL Property text-align-all has initial value start assert_true: text-align-all doesn't seem to be supported in the computed style expected true got false ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293527] trunk/Tools
Title: [293527] trunk/Tools Revision 293527 Author jbed...@apple.com Date 2022-04-27 12:09:37 -0700 (Wed, 27 Apr 2022) Log Message [ews-build.webkit.org] Support alternative remotes (Follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=239617 Unreviewed follow-up fix. * Tools/CISupport/ews-build/events.py: (GitHubEventHandlerNoEdits.extractProperties): Modified Paths trunk/Tools/CISupport/ews-build/events.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/CISupport/ews-build/events.py (293526 => 293527) --- trunk/Tools/CISupport/ews-build/events.py 2022-04-27 19:07:11 UTC (rev 293526) +++ trunk/Tools/CISupport/ews-build/events.py 2022-04-27 19:09:37 UTC (rev 293527) @@ -364,7 +364,7 @@ def extractProperties(self, payload): result = super(GitHubEventHandlerNoEdits, self).extractProperties(payload) -if payload.get('repository', {}).get('full_name') not in self.PUBLIC_REPOS: +if payload.get('base', {}).get('repo', {}).get('full_name') not in self.PUBLIC_REPOS: for field in self.SENSATIVE_FIELDS: if field in result: del result[field] Modified: trunk/Tools/ChangeLog (293526 => 293527) --- trunk/Tools/ChangeLog 2022-04-27 19:07:11 UTC (rev 293526) +++ trunk/Tools/ChangeLog 2022-04-27 19:09:37 UTC (rev 293527) @@ -1,3 +1,14 @@ +2022-04-27 Jonathan Bedard + +[ews-build.webkit.org] Support alternative remotes (Follow-up fix) +https://bugs.webkit.org/show_bug.cgi?id=239617 + + +Unreviewed follow-up fix. + +* CISupport/ews-build/events.py: +(GitHubEventHandlerNoEdits.extractProperties): + 2022-04-27 Aditya Keerthi [iOS] Focus changes unexpectedly when scrolling to a found text range ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293526] branches/safari-613.2.7.0-branch/Source
Title: [293526] branches/safari-613.2.7.0-branch/Source Revision 293526 Author alanc...@apple.com Date 2022-04-27 12:07:11 -0700 (Wed, 27 Apr 2022) Log Message Versioning. WebKit-7613.2.7.0.5 Modified Paths branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.7.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293525 => 293526) --- branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) +++ branches/safari-613.2.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 19:07:11 UTC (rev 293526) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293525 => 293526) --- branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) +++ branches/safari-613.2.7.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 19:07:11 UTC (rev 293526) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293525 => 293526) --- branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) +++ branches/safari-613.2.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 19:07:11 UTC (rev 293526) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig (293525 => 293526) --- branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) +++ branches/safari-613.2.7.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 19:07:11 UTC (rev 293526) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293525 => 293526) --- branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) +++ branches/safari-613.2.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 19:07:11 UTC (rev 293526) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig (293525 => 293526) --- branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) +++ branches/safari-613.2.7.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 19:07:11 UTC (rev 293526) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 0; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION
[webkit-changes] [293525] branches/safari-613.2.7.1-branch/Source
Title: [293525] branches/safari-613.2.7.1-branch/Source Revision 293525 Author alanc...@apple.com Date 2022-04-27 12:06:58 -0700 (Wed, 27 Apr 2022) Log Message Versioning. WebKit-7613.2.7.1.6 Modified Paths branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (293524 => 293525) --- branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 19:04:59 UTC (rev 293524) +++ branches/safari-613.2.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (293524 => 293525) --- branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 19:04:59 UTC (rev 293524) +++ branches/safari-613.2.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (293524 => 293525) --- branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 19:04:59 UTC (rev 293524) +++ branches/safari-613.2.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (293524 => 293525) --- branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 19:04:59 UTC (rev 293524) +++ branches/safari-613.2.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (293524 => 293525) --- branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 19:04:59 UTC (rev 293524) +++ branches/safari-613.2.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig (293524 => 293525) --- branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 19:04:59 UTC (rev 293524) +++ branches/safari-613.2.7.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-27 19:06:58 UTC (rev 293525) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION
[webkit-changes] [293524] trunk
Title: [293524] trunk Revision 293524 Author n...@apple.com Date 2022-04-27 12:04:59 -0700 (Wed, 27 Apr 2022) Log Message Make -webkit-transform-style an alias of transform-style https://bugs.webkit.org/show_bug.cgi?id=239808 Reviewed by Antti Koivisto. Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes unnecessary code as well given the FIXME was never addressed. LayoutTests/imported/w3c: * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: Source/WebCore: * animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSProperties.json: * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID): * rendering/style/WillChangeData.cpp: (WebCore::WillChangeData::propertyCreatesStackingContext): LayoutTests: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/rendering/style/WillChangeData.cpp Diff Modified: trunk/LayoutTests/ChangeLog (293523 => 293524) --- trunk/LayoutTests/ChangeLog 2022-04-27 19:03:10 UTC (rev 293523) +++ trunk/LayoutTests/ChangeLog 2022-04-27 19:04:59 UTC (rev 293524) @@ -1,3 +1,24 @@ +2022-04-27 Tim Nguyen + +Make -webkit-transform-style an alias of transform-style +https://bugs.webkit.org/show_bug.cgi?id=239808 + +Reviewed by Antti Koivisto. + +Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes +unnecessary code as well given the FIXME was never addressed. + +* fast/css/getComputedStyle/computed-style-expected.txt: +* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: +* platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: +* platform/ios/imported/w3c/web-platform-tests/css/cssom/getComput
[webkit-changes] [293523] trunk/LayoutTests
Title: [293523] trunk/LayoutTests Revision 293523 Author commit-qu...@webkit.org Date 2022-04-27 12:03:10 -0700 (Wed, 27 Apr 2022) Log Message [GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests https://bugs.webkit.org/show_bug.cgi?id=237181 Unreviewed test gardening. Patch by Arcady Goldmints-Orlov on 2022-04-27 * platform/gtk/TestExpectations: Remove skip now that the test doesn't cause problems. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (293522 => 293523) --- trunk/LayoutTests/ChangeLog 2022-04-27 19:01:04 UTC (rev 293522) +++ trunk/LayoutTests/ChangeLog 2022-04-27 19:03:10 UTC (rev 293523) @@ -1,3 +1,12 @@ +2022-04-27 Arcady Goldmints-Orlov + +[GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests +https://bugs.webkit.org/show_bug.cgi?id=237181 + +Unreviewed test gardening. + +* platform/gtk/TestExpectations: Remove skip now that the test doesn't cause problems. + 2022-04-27 Tim Nguyen [css-text] Make word-wrap CSS property an alias of overflow-wrap Modified: trunk/LayoutTests/platform/gtk/TestExpectations (293522 => 293523) --- trunk/LayoutTests/platform/gtk/TestExpectations 2022-04-27 19:01:04 UTC (rev 293522) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2022-04-27 19:03:10 UTC (rev 293523) @@ -199,9 +199,6 @@ # Crash on EWS bot. webrtc/vp8-then-h264-gpu-process-crash.html [ Skip ] -# This test introduces flakiness due to issues with resetting WebPreferences. -webkit.org/b/237181 fast/forms/validation-message-minimum-font-size.html [ Skip ] - #// # End of Triaged Expectations # Legacy Expectations sections below ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293522] trunk/Source
Title: [293522] trunk/Source Revision 293522 Author simon.fra...@apple.com Date 2022-04-27 12:01:04 -0700 (Wed, 27 Apr 2022) Log Message Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer https://bugs.webkit.org/show_bug.cgi?id=239799 Reviewed by Said Abou-Hallawa. After r280652, destroying a RemoteImageBufferProxy would always send a flush to the GPU process, even if there had be no drawing since the previous flush. Fix to only send a flush and wait when necessary. Roughly 8% progression on MotionMark Images subtest on iPhone. Source/WebCore: * platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::flushDrawingContextAsync): Source/WebKit: * WebProcess/GPU/graphics/RemoteImageBufferProxy.h: (WebKit::RemoteImageBufferProxy::waitForDidFlushWithTimeout): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ImageBuffer.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h Diff Modified: trunk/Source/WebCore/ChangeLog (293521 => 293522) --- trunk/Source/WebCore/ChangeLog 2022-04-27 18:56:04 UTC (rev 293521) +++ trunk/Source/WebCore/ChangeLog 2022-04-27 19:01:04 UTC (rev 293522) @@ -1,3 +1,20 @@ +2022-04-27 Simon Fraser + +Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer +https://bugs.webkit.org/show_bug.cgi?id=239799 + +Reviewed by Said Abou-Hallawa. + +After r280652, destroying a RemoteImageBufferProxy would always send a flush to the GPU +process, even if there had be no drawing since the previous flush. + +Fix to only send a flush and wait when necessary. + +Roughly 8% progression on MotionMark Images subtest on iPhone. + +* platform/graphics/ImageBuffer.h: +(WebCore::ImageBuffer::flushDrawingContextAsync): + 2022-04-27 Tim Nguyen [css-text] Make word-wrap CSS property an alias of overflow-wrap Modified: trunk/Source/WebCore/platform/graphics/ImageBuffer.h (293521 => 293522) --- trunk/Source/WebCore/platform/graphics/ImageBuffer.h 2022-04-27 18:56:04 UTC (rev 293521) +++ trunk/Source/WebCore/platform/graphics/ImageBuffer.h 2022-04-27 19:01:04 UTC (rev 293522) @@ -98,7 +98,7 @@ virtual GraphicsContext* drawingContext() { return nullptr; } virtual bool prefersPreparationForDisplay() { return false; } virtual void flushDrawingContext() { } -virtual void flushDrawingContextAsync() { } +virtual bool flushDrawingContextAsync() { return false; } virtual void didFlush(GraphicsContextFlushIdentifier) { } virtual FloatSize logicalSize() const = 0; Modified: trunk/Source/WebKit/ChangeLog (293521 => 293522) --- trunk/Source/WebKit/ChangeLog 2022-04-27 18:56:04 UTC (rev 293521) +++ trunk/Source/WebKit/ChangeLog 2022-04-27 19:01:04 UTC (rev 293522) @@ -1,3 +1,20 @@ +2022-04-27 Simon Fraser + +Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer +https://bugs.webkit.org/show_bug.cgi?id=239799 + +Reviewed by Said Abou-Hallawa. + +After r280652, destroying a RemoteImageBufferProxy would always send a flush to the GPU +process, even if there had be no drawing since the previous flush. + +Fix to only send a flush and wait when necessary. + +Roughly 8% progression on MotionMark Images subtest on iPhone. + +* WebProcess/GPU/graphics/RemoteImageBufferProxy.h: +(WebKit::RemoteImageBufferProxy::waitForDidFlushWithTimeout): + 2022-04-27 Aditya Keerthi [iOS] Focus changes unexpectedly when scrolling to a found text range Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (293521 => 293522) --- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2022-04-27 18:56:04 UTC (rev 293521) +++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2022-04-27 19:01:04 UTC (rev 293522) @@ -126,13 +126,14 @@ #if !LOG_DISABLED auto startTime = MonotonicTime::now(); #endif -LOG_WITH_STREAM(SharedDisplayLists, stream << "Waiting for Flush{" << m_sentFlushIdentifier << "} in Image(" << m_renderingResourceIdentifier << ")"); +LOG_WITH_STREAM(SharedDisplayLists, stream << "RemoteImageBufferProxy " << m_renderingResourceIdentifier << " waitForDidFlushWithTimeout: waiting for flush {" << m_sentFlushIdentifier); while (numberOfTimeouts < maximumNumberOfTimeouts && hasPendingFlush()) { if (!m_remoteRenderingBackendProxy->waitForDidFlush()) ++numberOfTimeouts; } -LOG_WITH_STREAM(SharedDisplayLists, stream << "Done waiting: " << MonotonicTime::now() - startTime << "; " << numberOfTimeouts << " timeout(s)"); +LOG_WITH_STREAM(SharedDisplayLists, stream << "RemoteImageBufferProxy " << m_renderingResourceIdentifier << " waitForDidFlushWithTimeout: done waiting " << (MonotonicTime::now() - startTime)
[webkit-changes] [293521] trunk
Title: [293521] trunk Revision 293521 Author n...@apple.com Date 2022-04-27 11:56:04 -0700 (Wed, 27 Apr 2022) Log Message [css-text] Make word-wrap CSS property an alias of overflow-wrap https://bugs.webkit.org/show_bug.cgi?id=166782 Reviewed by Antti Koivisto. This follows the spec, and fixes cascade issues when applying both properties (see bug 239579). Relevant WPT expectations updated to pass. * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/word-wrap-alias-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID): * Source/WebCore/editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToBodyElement const): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::collectPresentationalHintsForAttribute): * Source/WebCore/html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::collectPresentationalHintsForAttribute): * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/svg/css/getComputedStyle-basic-expected.txt:* web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: Canonical link: https://commits.webkit.org/250052@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/word-wrap-alias-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebCore/html/HTMLElement.cpp trunk/Source/WebCore/html/HTMLTextAreaElement.cpp Diff Modified: trunk/LayoutTests/ChangeLog (293520 => 293521) --- trunk/LayoutTests/ChangeLog 2022-04-27 18:37:45 UTC (rev 293520) +++ trunk/LayoutTests/ChangeLog 2022-04-27 18:56:04 UTC (rev 293521) @@ -1,3 +1,25 @@ +2022-04-27 Tim Nguyen + +[css-text] Make word-wrap CSS property an alias of overflow-wrap +https://bugs.webkit.org/show_bug.cgi?id=166782 + +Reviewed by Antti Koivisto. + +This follows the spec, and fix
[webkit-changes] [293520] trunk/JSTests
Title: [293520] trunk/JSTests Revision 293520 Author ange...@igalia.com Date 2022-04-27 11:37:45 -0700 (Wed, 27 Apr 2022) Log Message Unskip flaky test on mips https://bugs.webkit.org/show_bug.cgi?id=239342 Unreviewed gardening. Re-enable test. It should still be flaky, so can use it to test the code reporting the flakiness to resultsdb. * stress/new-largeish-contiguous-array-with-size.js: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js Diff Modified: trunk/JSTests/ChangeLog (293519 => 293520) --- trunk/JSTests/ChangeLog 2022-04-27 17:36:08 UTC (rev 293519) +++ trunk/JSTests/ChangeLog 2022-04-27 18:37:45 UTC (rev 293520) @@ -1,3 +1,15 @@ +2022-04-27 Angelos Oikonomopoulos + +Unskip flaky test on mips +https://bugs.webkit.org/show_bug.cgi?id=239342 + +Unreviewed gardening. + +Re-enable test. It should still be flaky, so can use it to test +the code reporting the flakiness to resultsdb. + +* stress/new-largeish-contiguous-array-with-size.js: + 2022-04-27 Dmitry Bezhetskov [WASM-GC] Introduce rtt types Modified: trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js (293519 => 293520) --- trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js 2022-04-27 17:36:08 UTC (rev 293519) +++ trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js 2022-04-27 18:37:45 UTC (rev 293520) @@ -1,6 +1,5 @@ // We only need one run of this with any GC or JIT strategy. This test is not particularly fast. // Unfortunately, it needs to run for a while to test the thing it's testing. -//@ skip if $architecture == "mips" //@ runWithRAMSize(1000) //@ requireOptions("-e", "let leakFactor=3") if $architecture == "mips" //@ slow! ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293519] trunk
Title: [293519] trunk Revision 293519 Author akeer...@apple.com Date 2022-04-27 10:36:08 -0700 (Wed, 27 Apr 2022) Log Message [iOS] Focus changes unexpectedly when scrolling to a found text range https://bugs.webkit.org/show_bug.cgi?id=239793 rdar://90996437 Reviewed by Wenson Hsieh. Source/WebKit: * WebProcess/WebPage/WebFoundTextRangeController.cpp: (WebKit::WebFoundTextRangeController::scrollTextRangeToVisible): Specify `DoNotSetFocus` in the `TemporarySelectionOption`s to avoid unnecessary focus changes when scrolling to a found text range. Focus changes can cause the web view to regain first responder status while searching for text, which will dismiss the find panel and end the search session. Tools: Add an API test to ensure that scrolling to a found range does not change focus. * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm: (TEST): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm Diff Modified: trunk/Source/WebKit/ChangeLog (293518 => 293519) --- trunk/Source/WebKit/ChangeLog 2022-04-27 17:30:22 UTC (rev 293518) +++ trunk/Source/WebKit/ChangeLog 2022-04-27 17:36:08 UTC (rev 293519) @@ -1,3 +1,21 @@ +2022-04-27 Aditya Keerthi + +[iOS] Focus changes unexpectedly when scrolling to a found text range +https://bugs.webkit.org/show_bug.cgi?id=239793 +rdar://90996437 + +Reviewed by Wenson Hsieh. + +* WebProcess/WebPage/WebFoundTextRangeController.cpp: +(WebKit::WebFoundTextRangeController::scrollTextRangeToVisible): + +Specify `DoNotSetFocus` in the `TemporarySelectionOption`s to avoid +unnecessary focus changes when scrolling to a found text range. + +Focus changes can cause the web view to regain first responder status +while searching for text, which will dismiss the find panel and end +the search session. + 2022-04-27 Per Arne Vollan [macOS] The function getpwnam can sometimes fail Modified: trunk/Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp (293518 => 293519) --- trunk/Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp 2022-04-27 17:30:22 UTC (rev 293518) +++ trunk/Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp 2022-04-27 17:36:08 UTC (rev 293519) @@ -154,7 +154,7 @@ return; WebCore::VisibleSelection visibleSelection(*simpleRange); -OptionSet temporarySelectionOptions { WebCore::TemporarySelectionOption::DelegateMainFrameScroll, WebCore::TemporarySelectionOption::RevealSelectionBounds }; +OptionSet temporarySelectionOptions { WebCore::TemporarySelectionOption::DelegateMainFrameScroll, WebCore::TemporarySelectionOption::RevealSelectionBounds, WebCore::TemporarySelectionOption::DoNotSetFocus }; if (document->isTopDocument()) temporarySelectionOptions.add(WebCore::TemporarySelectionOption::SmoothScroll); Modified: trunk/Tools/ChangeLog (293518 => 293519) --- trunk/Tools/ChangeLog 2022-04-27 17:30:22 UTC (rev 293518) +++ trunk/Tools/ChangeLog 2022-04-27 17:36:08 UTC (rev 293519) @@ -1,3 +1,17 @@ +2022-04-27 Aditya Keerthi + +[iOS] Focus changes unexpectedly when scrolling to a found text range +https://bugs.webkit.org/show_bug.cgi?id=239793 +rdar://90996437 + +Reviewed by Wenson Hsieh. + +Add an API test to ensure that scrolling to a found range does not +change focus. + +* TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm: +(TEST): + 2022-04-27 Jonathan Bedard test-webkitpy TestInstallGitLFS fails Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm (293518 => 293519) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm 2022-04-27 17:30:22 UTC (rev 293518) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm 2022-04-27 17:36:08 UTC (rev 293519) @@ -35,6 +35,7 @@ #import #if PLATFORM(IOS_FAMILY) +#import "TestInputDelegate.h" #import "UIKitSPI.h" #endif @@ -610,4 +611,38 @@ EXPECT_TRUE(CGPointEqualToPoint([webView scrollView].contentOffset, CGPointMake(0, 664))); } +TEST(WebKit, ScrollToFoundRangeDoesNotFocusElement) +{ +auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 200, 200)]); +[webView synchronouslyLoadHTMLString:@"TopBottom"]; + +auto scrollViewDelegate = adoptNS([[TestScrollViewDelegate alloc] init]); +[webView scrollView].delegate = scrollViewDelegate.get(); + +bool inputFocused = false; + +auto inputDelegate = adoptNS([TestInputDelegate new]); +[inputDelegate setFocusStartsInputSessionPolicyHandler:[&inputFocused] (WKWebView *, id<_WKFocusedElementInfo> focusedElementInfo) -> _WKFocusStartsInputSessionPolicy { +switch (focusedElementInfo.type) { +case WKInputTypeText: +inputFocused = true; +break; +
[webkit-changes] [293518] trunk/Source/bmalloc
Title: [293518] trunk/Source/bmalloc Revision 293518 Author brandonstew...@apple.com Date 2022-04-27 10:30:22 -0700 (Wed, 27 Apr 2022) Log Message [libpas] Implement secure random numbers https://bugs.webkit.org/show_bug.cgi?id=239735 Reviewed by Yusuke Suzuki. We currently have a cheesy random and secure random, which use the same implementation for generating random numbers. (We are going to ignore the mock testing code here). This patch introduces a fast random and secure random. The fast random maintains the same properties as the previous implementation, while secure random will use the cryptographically secure arc4random_uniform to give better randomness. arc4random() can be quite an expensive operation and based on discussing with Yusuke he found heavy performance penalties when using this in JSC. Our secure random shall only be used in cases where true randomness is needed. We have 2 spots where we currently use secure random; we shall just migrate those over to using fast random. * Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c: (pas_baseline_allocator_table_get_random_index): * Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c: (pas_dynamic_primitive_heap_map_find_slow): * Source/bmalloc/libpas/src/libpas/pas_random.c: * Source/bmalloc/libpas/src/libpas/pas_random.h: (pas_get_random): * Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c: (find_first_eligible_consider_view): * Source/bmalloc/libpas/src/test/IsoHeapPartialAndBaselineTests.cpp: (std::testTwoBaselinesEvictions): Canonical link: https://commits.webkit.org/250049@main Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c trunk/Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c trunk/Source/bmalloc/libpas/src/libpas/pas_random.c trunk/Source/bmalloc/libpas/src/libpas/pas_random.h trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c trunk/Source/bmalloc/libpas/src/test/IsoHeapPartialAndBaselineTests.cpp Diff Modified: trunk/Source/bmalloc/ChangeLog (293517 => 293518) --- trunk/Source/bmalloc/ChangeLog 2022-04-27 17:26:47 UTC (rev 293517) +++ trunk/Source/bmalloc/ChangeLog 2022-04-27 17:30:22 UTC (rev 293518) @@ -1,3 +1,30 @@ +2022-04-25 Brandon Stewart + +[libpas] Implement secure random numbers +https://bugs.webkit.org/show_bug.cgi?id=239735 + +Reviewed by Yusuke Suzuki. + +We currently have a cheesy random and secure random, which use the same implementation for generating +random numbers. (We are going to ignore the mock testing code here). This patch introduces a fast random and +secure random. The fast random maintains the same properties as the previous implementation, while secure random +will use the cryptographically secure arc4random_uniform to give better randomness. arc4random() can be quite an +expensive operation and based on discussing with Yusuke he found heavy performance penalties when using this in +JSC. Our secure random shall only be used in cases where true randomness is needed. We have 2 spots where we +currently use secure random we shall just migrate those over to using fast random. + +* libpas/src/libpas/pas_baseline_allocator_table.c: +(pas_baseline_allocator_table_get_random_index): +* libpas/src/libpas/pas_dynamic_primitive_heap_map.c: +(pas_dynamic_primitive_heap_map_find_slow): +* libpas/src/libpas/pas_random.c: +* libpas/src/libpas/pas_random.h: +(pas_get_random): +* libpas/src/libpas/pas_segregated_shared_page_directory.c: +(find_first_eligible_consider_view): +* libpas/src/test/IsoHeapPartialAndBaselineTests.cpp: +(std::testTwoBaselinesEvictions): + 2022-04-18 Elliott Williams [XCBuild] Use XCBuild for all command-line and project builds Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c (293517 => 293518) --- trunk/Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c 2022-04-27 17:26:47 UTC (rev 293517) +++ trunk/Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c 2022-04-27 17:30:22 UTC (rev 293518) @@ -63,7 +63,7 @@ unsigned pas_baseline_allocator_table_get_random_index(void) { -return pas_get_random(pas_cheesy_random, PAS_MIN(PAS_NUM_BASELINE_ALLOCATORS, +return pas_get_random(pas_fast_random, PAS_MIN(PAS_NUM_BASELINE_ALLOCATORS, pas_baseline_allocator_table_bound)); } Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c (293517 => 293518) --- trunk/Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c 2022-04-27 17:26:47 UTC (rev 293517) +++ trunk/Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c 2022-04-27 17:30:22 UTC (rev 293518) @@ -87,13 +87,13 @@
[webkit-changes] [293517] trunk/LayoutTests
Title: [293517] trunk/LayoutTests Revision 293517 Author commit-qu...@webkit.org Date 2022-04-27 10:26:47 -0700 (Wed, 27 Apr 2022) Log Message Cleanup expectations for 7 imported/w3c/web-platform-tests/html/semantics/interactive-elements/ tests https://bugs.webkit.org/show_bug.cgi?id=239790 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/250048@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (293516 => 293517) --- trunk/LayoutTests/ChangeLog 2022-04-27 17:22:57 UTC (rev 293516) +++ trunk/LayoutTests/ChangeLog 2022-04-27 17:26:47 UTC (rev 293517) @@ -1,3 +1,12 @@ +2022-04-27 Truitt Savell + +Cleanup expectations for 7 imported/w3c/web-platform-tests/html/semantics/interactive-elements/ tests +https://bugs.webkit.org/show_bug.cgi?id=239790 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2022-04-27 Youenn Fablet [Mac] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html is a flaky fail/crash/timeout Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (293516 => 293517) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-27 17:22:57 UTC (rev 293516) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-27 17:26:47 UTC (rev 293517) @@ -2244,5 +2244,11 @@ #rdar://91780899 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-blocks-mouse-events.html [ Skip ] +imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-receives-element-events.html [ Failure ] +imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/closed-dialog-does-not-block-mouse-events.html [ Failure ] +imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-inlines.html [ Failure ] +imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert.html [ Failure ] +imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/non-modal-dialog-does-not-block-mouse-events.html [ Failure ] +imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/simulated-click-inert.html [ Failure ] fast/text/install-font-style-recalc.html [ Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293516] trunk
Title: [293516] trunk Revision 293516 Author you...@apple.com Date 2022-04-27 10:22:57 -0700 (Wed, 27 Apr 2022) Log Message [Mac] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html is a flaky fail/crash/timeout https://bugs.webkit.org/show_bug.cgi?id=229588 Reviewed by Chris Dumez. Source/WebCore: I removed the user gesture in fetch by mistake so let's add it back. Test is no longer crashing on bots and is timing out on debug bots because it is a slow test. Mark test as slow and remove flakiness expectations. Covered by unflaked test. * Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp: (WebCore::doFetch): LayoutTests: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp Diff Modified: trunk/LayoutTests/ChangeLog (293515 => 293516) --- trunk/LayoutTests/ChangeLog 2022-04-27 17:15:53 UTC (rev 293515) +++ trunk/LayoutTests/ChangeLog 2022-04-27 17:22:57 UTC (rev 293516) @@ -1,3 +1,13 @@ +2022-04-27 Youenn Fablet + +[Mac] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html is a flaky fail/crash/timeout +https://bugs.webkit.org/show_bug.cgi?id=229588 + + +Reviewed by Chris Dumez. + +* platform/mac/TestExpectations: + 2022-04-27 Ziran Sun [css-ui] Remove some unimplemented -webkit-appearance keywords Modified: trunk/LayoutTests/platform/mac/TestExpectations (293515 => 293516) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-04-27 17:15:53 UTC (rev 293515) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-04-27 17:22:57 UTC (rev 293516) @@ -2191,7 +2191,7 @@ webkit.org/b/229521 pointer-lock/lock-already-locked.html [ Pass Failure ] -webkit.org/b/229588 http/tests/media/user-gesture-preserved-across-xmlhttprequest.html [ Pass Crash Failure Timeout ] +[ Debug ] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html [ Slow ] webkit.org/b/228176 [ BigSur Monterey ] fast/text/variable-system-font-2.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (293515 => 293516) --- trunk/Source/WebCore/ChangeLog 2022-04-27 17:15:53 UTC (rev 293515) +++ trunk/Source/WebCore/ChangeLog 2022-04-27 17:22:57 UTC (rev 293516) @@ -1,3 +1,20 @@ +2022-04-27 Youenn Fablet + +[Mac] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html is a flaky fail/crash/timeout +https://bugs.webkit.org/show_bug.cgi?id=229588 + + +Reviewed by Chris Dumez. + +I removed the user gesture in fetch by mistake so let's add it back. +Test is no longer crashing on bots and is timing out on debug bots because it is a slow test. +Mark test as slow and remove flakiness expectations. + +Covered by unflaked test. + +* Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp: +(WebCore::doFetch): + 2022-04-27 Ziran Sun [css-ui] Remove some unimplemented -webkit-appearance keywords Modified: trunk/Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp (293515 => 293516) --- trunk/Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp 2022-04-27 17:15:53 UTC (rev 293515) +++ trunk/Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp 2022-04-27 17:22:57 UTC (rev 293516) @@ -55,8 +55,13 @@ return; } -FetchResponse::fetch(scope, request.get(), [promise = WTFMove(promise), scope = Ref { scope }](auto&& result) mutable { -scope->eventLoop().queueTask(TaskSource::Networking, [promise = WTFMove(promise), result = WTFMove(result)]() mutable { +FetchResponse::fetch(scope, request.get(), [promise = WTFMove(promise), scope = Ref { scope }, userGestureToken = UserGestureIndicator::currentUserGesture()](auto&& result) mutable { +scope->eventLoop().queueTask(TaskSource::Networking, [promise = WTFMove(promise), userGestureToken = WTFMove(userGestureToken), result = WTFMove(result)]() mutable { +if (!userGestureToken || userGestureToken->hasExpired(UserGestureToken::maximumIntervalForUserGestureForwardingForFetch()) || !userGestureToken->processingUserGesture()) { +promise.settle(WTFMove(result)); +return; +} +UserGestureIndicator gestureIndicator(userGestureToken, UserGestureToken::GestureScope::MediaOnly, UserGestureToken::IsPropagatedFromFetch::Yes); promise.settle(WTFMove(result)); }); }, cachedResourceRequestInitiators().fetch); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293515] trunk/Tools
Title: [293515] trunk/Tools Revision 293515 Author jbed...@apple.com Date 2022-04-27 10:15:53 -0700 (Wed, 27 Apr 2022) Log Message test-webkitpy TestInstallGitLFS fails https://bugs.webkit.org/show_bug.cgi?id=239788 Reviewed by Michael Catanzaro. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py: (TestInstallGitLFS.test_install): Specify mock system and machine. (TestInstallGitLFS.test_configure): Ditto. (TestInstallGitLFS.test_no_op): Ditto. (TestInstallGitLFS.test_no_repo): Ditto. Canonical link: https://commits.webkit.org/250046@main Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitscmpy/setup.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py Diff Modified: trunk/Tools/ChangeLog (293514 => 293515) --- trunk/Tools/ChangeLog 2022-04-27 17:12:06 UTC (rev 293514) +++ trunk/Tools/ChangeLog 2022-04-27 17:15:53 UTC (rev 293515) @@ -1,5 +1,21 @@ 2022-04-27 Jonathan Bedard +test-webkitpy TestInstallGitLFS fails +https://bugs.webkit.org/show_bug.cgi?id=239788 + + +Reviewed by Michael Catanzaro. + +* Scripts/libraries/webkitscmpy/setup.py: Bump version. +* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. +* Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py: +(TestInstallGitLFS.test_install): Specify mock system and machine. +(TestInstallGitLFS.test_configure): Ditto. +(TestInstallGitLFS.test_no_op): Ditto. +(TestInstallGitLFS.test_no_repo): Ditto. + +2022-04-27 Jonathan Bedard + [commits.webkit.org] Change branch forwarding behavior https://bugs.webkit.org/show_bug.cgi?id=239136 Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (293514 => 293515) --- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-27 17:12:06 UTC (rev 293514) +++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-04-27 17:15:53 UTC (rev 293515) @@ -29,7 +29,7 @@ setup( name='webkitscmpy', -version='4.11.2', +version='4.11.3', description='Library designed to interact with git and svn repositories.', long_description=readme(), classifiers=[ Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (293514 => 293515) --- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-27 17:12:06 UTC (rev 293514) +++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-04-27 17:15:53 UTC (rev 293515) @@ -46,7 +46,7 @@ "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `" ) -version = Version(4, 11, 2) +version = Version(4, 11, 3) AutoInstall.register(Package('fasteners', Version(0, 15, 0))) AutoInstall.register(Package('jinja2', Version(2, 11, 3))) Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py (293514 => 293515) --- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py 2022-04-27 17:12:06 UTC (rev 293514) +++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py 2022-04-27 17:15:53 UTC (rev 293515) @@ -78,7 +78,7 @@ with OutputCapture() as captured, mocks.remote.GitHub('github.com/git-lfs/git-lfs', releases={ 'v3.1.2/git-lfs-darwin-arm64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS), 'v3.1.2/git-lfs-darwin-amd64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS), -}), mocks.local.Git(self.path), mocks.local.Svn(): +}), mocks.local.Git(self.path), mocks.local.Svn(), patch('platform.system', lambda: 'Darwin'), patch('platform.machine', lambda: 'x86_64'): self.assertIsNone(local.Git(self.path).config().get('lfs.repositoryformatversion')) self.assertEqual(0, program.main( args=('install-git-lfs',), @@ -97,7 +97,7 @@ with OutputCapture() as captured, mocks.remote.GitHub('github.com/git-lfs/git-lfs', releases={ 'v3.1.2/git-lfs-darwin-arm64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS), 'v3.1.2/git-lfs-darwin-amd64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS), -}), mocks.local.Git(self.path) as mocked, mocks.local.Svn(): +}), mocks.local.Git(self.path) as mocked, mocks.local.Svn(), patch('platform.system', lambda: 'Darwin'), patch('platform.machine', lambda: 'x86_64'): mocked.has_git_lfs = True self.assertIsNone(local.Git(self.path).config().get('lfs.repositoryformatversion')) @@ -117,7 +117,7 @@ with OutputCapture() as captured,
[webkit-changes] [293514] trunk/Tools
Title: [293514] trunk/Tools Revision 293514 Author jbed...@apple.com Date 2022-04-27 10:12:06 -0700 (Wed, 27 Apr 2022) Log Message [commits.webkit.org] Change branch forwarding behavior https://bugs.webkit.org/show_bug.cgi?id=239136 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version. * Tools/Scripts/libraries/reporelaypy/setup.py: Ditto. * Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py: (Checkout.Encoder.default): Encode forwarding list. (Checkout.__init__): Add forwarding argument. (Checkout.push_update): Add dest_branch argument. (Checkout.forward_update): Trigger push_update based on forwarding arguments. (Checkout.update_all): Use forward_update instead of pushing to every branch. * Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py: (HookProcessor.process_worker_hook): Extract remote from incoming data, invoke forward_update. * Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py: (CheckoutUnittest.test_json): Canonical link: https://commits.webkit.org/250045@main Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py trunk/Tools/Scripts/libraries/reporelaypy/setup.py Diff Modified: trunk/Tools/ChangeLog (293513 => 293514) --- trunk/Tools/ChangeLog 2022-04-27 17:06:09 UTC (rev 293513) +++ trunk/Tools/ChangeLog 2022-04-27 17:12:06 UTC (rev 293514) @@ -1,3 +1,24 @@ +2022-04-27 Jonathan Bedard + +[commits.webkit.org] Change branch forwarding behavior +https://bugs.webkit.org/show_bug.cgi?id=239136 + + +Reviewed by Dewei Zhu. + +* Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version. +* Scripts/libraries/reporelaypy/setup.py: Ditto. +* Scripts/libraries/reporelaypy/reporelaypy/checkout.py: +(Checkout.Encoder.default): Encode forwarding list. +(Checkout.__init__): Add forwarding argument. +(Checkout.push_update): Add dest_branch argument. +(Checkout.forward_update): Trigger push_update based on forwarding arguments. +(Checkout.update_all): Use forward_update instead of pushing to every branch. +* Scripts/libraries/reporelaypy/reporelaypy/hooks.py: +(HookProcessor.process_worker_hook): Extract remote from incoming data, invoke forward_update. +* Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py: +(CheckoutUnittest.test_json): + 2022-04-27 Kimmo Kinnunen test-webkitperl outputs git hints during the test Modified: trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py (293513 => 293514) --- trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py 2022-04-27 17:06:09 UTC (rev 293513) +++ trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py 2022-04-27 17:12:06 UTC (rev 293514) @@ -44,7 +44,7 @@ "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `" ) -version = Version(0, 5, 2) +version = Version(0, 6, 0) import webkitflaskpy Modified: trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py (293513 => 293514) --- trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py 2022-04-27 17:06:09 UTC (rev 293513) +++ trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py 2022-04-27 17:12:06 UTC (rev 293514) @@ -50,6 +50,7 @@ url="" sentinal=obj.sentinal, remotes=obj.remotes, +forwarding=obj.forwarding, credentials=obj.credentials, ) if obj.fallback_repository: @@ -104,11 +105,17 @@ with open(os.path.expanduser('~/.git-credentials'), 'w') as f: f.write(git_credentials_content) -def __init__(self, path, url="" http_proxy=None, sentinal=True, fallback_url=None, primary=True, remotes=None, credentials=None): +def __init__( +self, path, url="" http_proxy=None, +sentinal=True, fallback_url=None, primary=True, +remotes=None, credentials=None, +forwarding=None, +): self.sentinal = sentinal self.path = path self.url = "" self.remotes = remotes or dict() +self.forwarding = forwarding or [('origin', list(self.remotes.keys()))] self.credentials = credentials or dict() self._repository = None self._child_process = None @@ -204,8 +211,8 @@ return ref == line.split()[0] return False -def push_update(self, branch=None, tag=None, remote=None, track=False): -if not remote or remote in (self.REMOTE, 'fork'): +def push_update(self, branch=None, tag=None, remote=None, track=False, dest_branch=None):
[webkit-changes] [293512] trunk/Tools
Title: [293512] trunk/Tools Revision 293512 Author commit-qu...@webkit.org Date 2022-04-27 09:32:05 -0700 (Wed, 27 Apr 2022) Log Message test-webkitperl outputs git hints during the test https://bugs.webkit.org/show_bug.cgi?id=239759 Patch by Kimmo Kinnunen on 2022-04-27 Reviewed by Alexey Proskuryakov. Avoid git hints about initial branch name during a test that initializes a git repository. The output disrupts the test system result reporting output. Specify the quiet operation. --initial-branch cannot be specified since the Perl tests run on older git. * Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl Diff Modified: trunk/Tools/ChangeLog (293511 => 293512) --- trunk/Tools/ChangeLog 2022-04-27 16:30:31 UTC (rev 293511) +++ trunk/Tools/ChangeLog 2022-04-27 16:32:05 UTC (rev 293512) @@ -1,3 +1,18 @@ +2022-04-27 Kimmo Kinnunen + +test-webkitperl outputs git hints during the test +https://bugs.webkit.org/show_bug.cgi?id=239759 + +Reviewed by Alexey Proskuryakov. + +Avoid git hints about initial branch name during a test that initializes a git repository. +The output disrupts the test system result reporting output. + +Specify the quiet operation. --initial-branch cannot be specified +since the Perl tests run on older git. + +* Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl: + 2022-04-26 Michael Catanzaro [GLib] Make WebKitSettings XSS auditor functions no-op Modified: trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl (293511 => 293512) --- trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl 2022-04-27 16:30:31 UTC (rev 293511) +++ trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl 2022-04-27 16:32:05 UTC (rev 293512) @@ -46,7 +46,7 @@ } my $temporaryDirectory = File::Temp->newdir(); -system("git", "init", $temporaryDirectory); +system("git", "init", "-q", $temporaryDirectory); my $filename = File::Spec->catfile($temporaryDirectory, "FileWith(Parentheses).txt"); writeFileWithContent($filename, ""); writeFileWithContent(File::Spec->catfile($temporaryDirectory, ".gitattributes"), "* foo=1\nb"); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293511] trunk
Title: [293511] trunk Revision 293511 Author z...@igalia.com Date 2022-04-27 09:30:31 -0700 (Wed, 27 Apr 2022) Log Message [css-ui] Remove some unimplemented -webkit-appearance keywords https://bugs.webkit.org/show_bug.cgi?id=238930 Reviewed by Aditya Keerthi. LayoutTests/imported/w3c: * web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Source/WebCore: Remove the following unimplmented --webkit-appearance keyworkds: button-bevel media-controls-background media-controls-fullscreen-background media-current-time-display media-enter-fullscreen-button media-exit-fullscreen-button media-mute-button media-overlay-play-button media-return-to-realtime-button media-rewind-button media-seek-back-button media-seek-forward-button media-time-remaining-display media-toggle-closed-captions-button media-volume-slider-container menulist-textfield menulist-text * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSProperties.json: * css/CSSValueKeywords.in: * platform/ThemeTypes.cpp: (WebCore::operator<<): * platform/ThemeTypes.h: * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): * rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaPlayButton): (WebCore::RenderTheme::paintMediaMuteButton): (WebCore::RenderTheme::paintMediaSliderThumb): (WebCore::RenderTheme::paintMediaVolumeSliderThumb): (WebCore::RenderTheme::paintMediaFullscreenButton): Deleted. (WebCore::RenderTheme::paintMediaOverlayPlayButton): Deleted. (WebCore::RenderTheme::paintMediaSeekBackButton): Deleted. (WebCore::RenderTheme::paintMediaSeekForwardButton): Deleted. (WebCore::RenderTheme::paintMediaVolumeSliderContainer): Deleted. (WebCore::RenderTheme::paintMediaRewindButton): Deleted. (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Deleted. (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): Deleted. (WebCore::RenderTheme::paintMediaControlsBackground): Deleted. (WebCore::RenderTheme::paintMediaCurrentTime): Deleted. (WebCore::RenderTheme::paintMediaTimeRemaining): Deleted. Source/WebInspectorUI: We might need to update the changes on UserInterface/External/CodeMirror/css.js since PR https://github.com/codemirror/CodeMirror/pull/6912 has been merged in CodeMirror. * UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json: * UserInterface/External/CSSDocumentation/CSSDocumentation.js: LayoutTests: * imported/blink/editing/execCommand/outdent-collapse-table-crash.html: * platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/platform/ThemeTypes.cpp trunk/Source/WebCore/platform/ThemeTypes.h trunk/Source/WebCore/rendering/RenderTheme.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js Diff Modified: trunk/LayoutTests/ChangeLog (293510 => 293511) --- trunk/LayoutTests/ChangeLog 2022-04-27 15:49:39 UTC (rev 293510) +++ trunk/LayoutTests/ChangeLog 2022-04-27 16:30:31 UTC (rev 293511) @@ -1,3 +1,14 @@ +2022-04-27 Ziran Sun + +[css-ui] Remove some unimplemented -webkit-appearance keywords +https://bugs.webkit.org/show_bug.cgi?id=238930 + +Reviewed by Aditya Keerthi. + +* imported/blink/editing/execCommand/outdent-collapse-table-crash.html: +* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: +* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: + 2022-04-27 Youenn Fablet Add testRunner API to clear memory cache Modified: trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html (293510 => 293511) --- trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html 2022-04-27 15:49:39 UTC (rev 293510) +++ trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html 2022-04-27 16:30:31 UTC (rev 293511) @@ -3,7 +3,6 @@
[webkit-changes] [293510] trunk
Title: [293510] trunk Revision 293510 Author dbezhets...@igalia.com Date 2022-04-27 08:49:39 -0700 (Wed, 27 Apr 2022) Log Message [WASM-GC] Introduce rtt types https://bugs.webkit.org/show_bug.cgi?id=239493 Reviewed by Keith Miller. JSTests: Added basic tests for manipulation of rtt types. * wasm/gc/rtt.js: Added. (module): (testRttTypes): (testRttCanon): * wasm/wasm.json: Source/_javascript_Core: Add a basic support through runtime call for rtt.canon and rtt types. It is a prototype implementation of rtt types needed to move forward with wasm gc proposal (https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md). For example, we don't need to use rtt values for struct.new, but we do need them for the future js api. So, rtt.canon returns jsNull for now, but we can replace it with properly defined values when the spec will be ready. * bytecode/BytecodeList.rb: * llint/WebAssembly.asm: * wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::tmpForType): (JSC::Wasm::AirIRGenerator::AirIRGenerator): (JSC::Wasm::AirIRGenerator::addRttCanon): * wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addRttCanon): * wasm/WasmCallingConvention.h: (JSC::Wasm::WasmCallingConvention::marshallLocation const): * wasm/WasmFormat.h: (JSC::Wasm::isValueType): (JSC::Wasm::isValidHeapTypeKind): * wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::parseExpression): (JSC::Wasm::FunctionParser::parseUnreachableExpression): * wasm/WasmLLIntGenerator.cpp: (JSC::Wasm::LLIntGenerator::callInformationForCaller): (JSC::Wasm::LLIntGenerator::callInformationForCallee): (JSC::Wasm::LLIntGenerator::addArguments): (JSC::Wasm::LLIntGenerator::addRttCanon): * wasm/WasmOperations.cpp: (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): * wasm/WasmOperations.h: * wasm/WasmParser.h: (JSC::Wasm::Parser::parseValueType): * wasm/WasmSlowPaths.cpp: (JSC::LLInt::WASM_SLOW_PATH_DECL): * wasm/WasmSlowPaths.h: * wasm/generateWasmOpsHeader.py: * wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS): * wasm/wasm.json: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/wasm/wasm.json trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/BytecodeList.rb trunk/Source/_javascript_Core/llint/WebAssembly.asm trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp trunk/Source/_javascript_Core/wasm/WasmCallingConvention.h trunk/Source/_javascript_Core/wasm/WasmFormat.h trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h trunk/Source/_javascript_Core/wasm/WasmLLIntGenerator.cpp trunk/Source/_javascript_Core/wasm/WasmOperations.cpp trunk/Source/_javascript_Core/wasm/WasmOperations.h trunk/Source/_javascript_Core/wasm/WasmParser.h trunk/Source/_javascript_Core/wasm/WasmSlowPaths.cpp trunk/Source/_javascript_Core/wasm/WasmSlowPaths.h trunk/Source/_javascript_Core/wasm/generateWasmOpsHeader.py trunk/Source/_javascript_Core/wasm/js/WasmToJS.cpp trunk/Source/_javascript_Core/wasm/wasm.json Added Paths trunk/JSTests/wasm/gc/rtt.js Diff Modified: trunk/JSTests/ChangeLog (293509 => 293510) --- trunk/JSTests/ChangeLog 2022-04-27 15:49:37 UTC (rev 293509) +++ trunk/JSTests/ChangeLog 2022-04-27 15:49:39 UTC (rev 293510) @@ -1,3 +1,18 @@ +2022-04-27 Dmitry Bezhetskov + +[WASM-GC] Introduce rtt types +https://bugs.webkit.org/show_bug.cgi?id=239493 + +Reviewed by Keith Miller. + +Added basic tests for manipulation of rtt types. + +* wasm/gc/rtt.js: Added. +(module): +(testRttTypes): +(testRttCanon): +* wasm/wasm.json: + 2022-04-26 Yusuke Suzuki [JSC] Add forceUnlinkedDFG option Added: trunk/JSTests/wasm/gc/rtt.js (0 => 293510) --- trunk/JSTests/wasm/gc/rtt.js (rev 0) +++ trunk/JSTests/wasm/gc/rtt.js 2022-04-27 15:49:39 UTC (rev 293510) @@ -0,0 +1,57 @@ +//@ runWebAssemblySuite("--useWebAssemblyTypedFunctionReferences=true", "--useWebAssemblyGC=true") + +import * as assert from "../assert.js"; +import { instantiate } from "../wabt-wrapper.js"; + +function module(bytes, valid = true) { + let buffer = new ArrayBuffer(bytes.length); + let view = new Uint8Array(buffer); + for (let i = 0; i < bytes.length; ++i) { +view[i] = bytes.charCodeAt(i); + } + return new WebAssembly.Module(buffer); +} + +function testRttTypes() { + /* + (module + (type $Point (struct (field i32) (field i32))) + (func (param (rtt $Point))) + ) + */ + module("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x0c\x02\x5f\x02\x7f\x00\x7f\x00\x60\x01\x68\x00\x00\x03\x02\x01\x01\x0a\x05\x01\x03\x00\x01\x0b"); +} + +function testRttCanon() { + { +/* +(module + (type $Point (struct (field $x i32) (field $y i32))) + (func $foo (param (rtt $Point)) (result i32) (i32.const 37)) + (func (export "main") +(drop + (call $foo (rtt.canon $Point)) +) + ) +) +*/ +let instance = new WebAssembly.Instance(module("\x00\x61\x7
[webkit-changes] [293509] trunk/Source/WebKit
Title: [293509] trunk/Source/WebKit Revision 293509 Author pvol...@apple.com Date 2022-04-27 08:49:37 -0700 (Wed, 27 Apr 2022) Log Message [macOS] The function getpwnam can sometimes fail https://bugs.webkit.org/show_bug.cgi?id=239513 Reviewed by Darin Adler. The system function getpwnam is caching the results from the first invocation, and will return the cached values after the first call. It may happen that opendirectoryd will invalidate the cached values by posting notifications. If that happens, getpwnam will then fail, since there are no cached values and the WebContent process' sandbox is blocking access to opendirectoryd. This patch addresses this issue by observing these notifications in the UI process, and recreating the cached values for getpwnam, by calling the function in the WebContent process while holding a temporary sandbox extenstion to opendirectoryd. * GPUProcess/GPUProcess.h: * GPUProcess/GPUProcess.messages.in: * GPUProcess/mac/GPUProcessMac.mm: (WebKit::GPUProcess::openDirectoryCacheInvalidated): * GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Shared/AuxiliaryProcess.h: * Shared/mac/AuxiliaryProcessMac.mm: (WebKit::getHomeDirectory): (WebKit::populateSandboxInitializationParameters): (WebKit::AuxiliaryProcess::openDirectoryCacheInvalidated): * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::registerNotificationObservers): (WebKit::WebProcessPool::unregisterNotificationObservers): * UIProcess/WebProcessPool.h: * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::openDirectoryCacheInvalidated): * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/GPUProcess.h trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in trunk/Source/WebKit/GPUProcess/mac/GPUProcessMac.mm trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in trunk/Source/WebKit/Shared/AuxiliaryProcess.h trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm trunk/Source/WebKit/UIProcess/WebProcessPool.h trunk/Source/WebKit/WebProcess/WebProcess.h trunk/Source/WebKit/WebProcess/WebProcess.messages.in trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (293508 => 293509) --- trunk/Source/WebKit/ChangeLog 2022-04-27 14:11:34 UTC (rev 293508) +++ trunk/Source/WebKit/ChangeLog 2022-04-27 15:49:37 UTC (rev 293509) @@ -1,3 +1,39 @@ +2022-04-27 Per Arne Vollan + +[macOS] The function getpwnam can sometimes fail +https://bugs.webkit.org/show_bug.cgi?id=239513 + + +Reviewed by Darin Adler. + +The system function getpwnam is caching the results from the first invocation, and will return the cached +values after the first call. It may happen that opendirectoryd will invalidate the cached values by +posting notifications. If that happens, getpwnam will then fail, since there are no cached values and +the WebContent process' sandbox is blocking access to opendirectoryd. This patch addresses this issue +by observing these notifications in the UI process, and recreating the cached values for getpwnam, by +calling the function in the WebContent process while holding a temporary sandbox extenstion to +opendirectoryd. + +* GPUProcess/GPUProcess.h: +* GPUProcess/GPUProcess.messages.in: +* GPUProcess/mac/GPUProcessMac.mm: +(WebKit::GPUProcess::openDirectoryCacheInvalidated): +* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: +* Shared/AuxiliaryProcess.h: +* Shared/mac/AuxiliaryProcessMac.mm: +(WebKit::getHomeDirectory): +(WebKit::populateSandboxInitializationParameters): +(WebKit::AuxiliaryProcess::openDirectoryCacheInvalidated): +* UIProcess/Cocoa/WebProcessPoolCocoa.mm: +(WebKit::WebProcessPool::registerNotificationObservers): +(WebKit::WebProcessPool::unregisterNotificationObservers): +* UIProcess/WebProcessPool.h: +* WebProcess/WebProcess.h: +* WebProcess/WebProcess.messages.in: +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::openDirectoryCacheInvalidated): +* WebProcess/com.apple.WebProcess.sb.in: + 2022-04-26 Michael Catanzaro [GLib] Make WebKitSettings XSS auditor functions no-op Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.h (293508 => 293509) --- trunk/Source/WebKit/GPUProcess/GPUProcess.h 2022-04-27 14:11:34 UTC (rev 293508) +++ trunk/Source/WebKit/GPUProcess/GPUProcess.h 2022-04-27 15:49:37 UTC (rev 293509) @@ -202,6 +202,10 @@ void dispatchSimulatedNotificationsForPreferenceChange(const String& key) final; #endif +#if PLATFORM(MAC) +void openDirectoryCacheInvalidated(SandboxExtension::Handle&&
[webkit-changes] [293508] trunk
Title: [293508] trunk Revision 293508 Author commit-qu...@webkit.org Date 2022-04-27 07:11:34 -0700 (Wed, 27 Apr 2022) Log Message [GTK] Add user agent quirk for "ClicSalud+" (Andalusian Health Service, Spain) https://bugs.webkit.org/show_bug.cgi?id=239763 Patch by Michael Catanzaro on 2022-04-27 Reviewed by Adrian Perez de Castro. * Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): * Source/WebCore/platform/UserAgentQuirks.cpp: (WebCore::urlRequiresMacintoshPlatform): Canonical link: https://commits.webkit.org/250039@main Modified Paths trunk/Source/WebCore/platform/UserAgentQuirks.cpp trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp Diff Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (293507 => 293508) --- trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2022-04-27 13:16:03 UTC (rev 293507) +++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2022-04-27 14:11:34 UTC (rev 293508) @@ -119,6 +119,12 @@ || domain == "exchange.tu-berlin.de") return true; +// https://www.sspa.juntadeandalucia.es/servicioandaluzdesalud/clicsalud/pages/portada.jsf +// Andalusian Health Service discriminates against WebKitGTK's standard user +// agent with an unsupported browser warning. +if (domain == "www.sspa.juntadeandalucia.es") +return true; + return false; } Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (293507 => 293508) --- trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2022-04-27 13:16:03 UTC (rev 293507) +++ trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp 2022-04-27 14:11:34 UTC (rev 293508) @@ -104,6 +104,7 @@ assertUserAgentForURLHasMacPlatformQuirk("http://outlook.office.com/"); assertUserAgentForURLHasMacPlatformQuirk("http://mail.ntu.edu.tw/"); assertUserAgentForURLHasMacPlatformQuirk("http://exchange.tu-berlin.de/"); +assertUserAgentForURLHasMacPlatformQuirk("http://www.sspa.juntadeandalucia.es/"); assertUserAgentForURLHasEmptyQuirk("http://accounts.google.com/"); assertUserAgentForURLHasEmptyQuirk("http://docs.google.com/"); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293507] trunk
Title: [293507] trunk Revision 293507 Author commit-qu...@webkit.org Date 2022-04-27 06:16:03 -0700 (Wed, 27 Apr 2022) Log Message [GLib] Make WebKitSettings XSS auditor functions no-op https://bugs.webkit.org/show_bug.cgi?id=239651 Patch by Michael Catanzaro on 2022-04-27 Reviewed by Adrian Perez de Castro. Let's deprecate these functions. Also, do not print warnings because they are called during init by the property setters. * Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: (webkit_settings_get_enable_xss_auditor): (webkit_settings_set_enable_xss_auditor): * Source/WebKit/UIProcess/API/gtk/WebKitSettings.h: * Source/WebKit/UIProcess/API/wpe/WebKitSettings.h: Canonical link: https://commits.webkit.org/250038@main Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (293506 => 293507) --- trunk/Source/WebKit/ChangeLog 2022-04-27 13:12:28 UTC (rev 293506) +++ trunk/Source/WebKit/ChangeLog 2022-04-27 13:16:03 UTC (rev 293507) @@ -1,3 +1,21 @@ +2022-04-26 Michael Catanzaro + +[GLib] Make WebKitSettings XSS auditor functions no-op +https://bugs.webkit.org/show_bug.cgi?id=239651 + + +Reviewed by Adrian Perez de Castro. + +Let's deprecate these functions. + +Also, do not print warnings because they are called during init by the property setters. + +* UIProcess/API/glib/WebKitSettings.cpp: +(webkit_settings_get_enable_xss_auditor): +(webkit_settings_set_enable_xss_auditor): +* UIProcess/API/gtk/WebKitSettings.h: +* UIProcess/API/wpe/WebKitSettings.h: + 2022-04-27 Youenn Fablet service worker update should refresh imported scripts in addition to the main script Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (293506 => 293507) --- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2022-04-27 13:12:28 UTC (rev 293506) +++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2022-04-27 13:16:03 UTC (rev 293507) @@ -1813,16 +1813,16 @@ * webkit_settings_get_enable_xss_auditor: * @settings: a #WebKitSettings * - * Get the #WebKitSettings:enable-xss-auditor property. + * The XSS auditor has been removed. This function returns %FALSE. * - * Returns: %TRUE If XSS auditing is enabled or %FALSE otherwise. + * Returns: %FALSE + * + * Deprecated: 2.38. This function does nothing. */ gboolean webkit_settings_get_enable_xss_auditor(WebKitSettings* settings) { g_return_val_if_fail(WEBKIT_IS_SETTINGS(settings), FALSE); -g_warning("webkit_settings_get_enable_xss_auditor is deprecated and always returns FALSE. XSS auditor is no longer supported."); - return FALSE; } @@ -1831,14 +1831,13 @@ * @settings: a #WebKitSettings * @enabled: Value to be set * - * Set the #WebKitSettings:enable-xss-auditor property. + * The XSS auditor has been removed. This function does nothing. + * + * Deprecated: 2.38. This function does nothing. */ void webkit_settings_set_enable_xss_auditor(WebKitSettings* settings, gboolean enabled) { g_return_if_fail(WEBKIT_IS_SETTINGS(settings)); - -if (enabled) -g_warning("webkit_settings_set_enable_xss_auditor is deprecated and does nothing. XSS auditor is no longer supported."); } /** Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h (293506 => 293507) --- trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h 2022-04-27 13:12:28 UTC (rev 293506) +++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h 2022-04-27 13:16:03 UTC (rev 293507) @@ -135,10 +135,10 @@ WEBKIT_API void webkit_settings_set_enable_html5_database (WebKitSettings *settings, gbooleanenabled); -WEBKIT_API gboolean +WEBKIT_DEPRECATED gboolean webkit_settings_get_enable_xss_auditor (WebKitSettings *settings); -WEBKIT_API void +WEBKIT_DEPRECATED void webkit_settings_set_enable_xss_auditor (WebKitSettings *settings, gbooleanenabled); Modified: trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h (293506 => 293507) --- trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h 2022-04-27 13:12:28 UTC (rev 293506) +++ trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h 2022-04-27 13:16:03 UTC (rev 293507) @@ -119,10 +119,10 @@ WEBKIT_API void webkit_settings_set_enable_html5_database (WebKitSettings *settings, gbooleanenabled); -WEBKIT_API gboolean +WEBKIT_DEPRECATED gboolean webkit_settings_get_en
[webkit-changes] [293506] trunk
Title: [293506] trunk Revision 293506 Author you...@apple.com Date 2022-04-27 06:12:28 -0700 (Wed, 27 Apr 2022) Log Message service worker update should refresh imported scripts in addition to the main script https://bugs.webkit.org/show_bug.cgi?id=239657 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/credentials.https-expected.txt: Source/WebCore: After checking main script, if matching, we refreach each identified imported script. If matching, we reuse the same worker, otherwise we install a new one. We reuse the soft update loader to fetch scripts in case of soft update. Otherwise, we load scripts through the job's client. Covered by rebased test. * workers/service/SWClientConnection.cpp: * workers/service/SWClientConnection.h: * workers/service/ServiceWorkerContainer.cpp: * workers/service/ServiceWorkerContainer.h: * workers/service/ServiceWorkerJob.cpp: * workers/service/ServiceWorkerJob.h: * workers/service/ServiceWorkerJobClient.h: * workers/service/server/SWServer.cpp: * workers/service/server/SWServer.h: * workers/service/server/SWServerJobQueue.cpp: * workers/service/server/SWServerJobQueue.h: * workers/service/server/SWServerWorker.cpp: * workers/service/server/SWServerWorker.h: Source/WebKit: * NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h: * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: * NetworkProcess/ServiceWorker/WebSWServerConnection.h: * WebProcess/Storage/WebSWClientConnection.messages.in: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/SWClientConnection.cpp trunk/Source/WebCore/workers/service/SWClientConnection.h trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp trunk/Source/WebCore/workers/service/ServiceWorkerJob.h trunk/Source/WebCore/workers/service/ServiceWorkerJobClient.h trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp trunk/Source/WebCore/workers/service/server/SWServerJobQueue.h trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp trunk/Source/WebCore/workers/service/server/SWServerWorker.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293505 => 293506) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 11:59:59 UTC (rev 293505) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 13:12:28 UTC (rev 293506) @@ -1,5 +1,14 @@ 2022-04-27 Youenn Fablet +service worker update should refresh imported scripts in addition to the main script +https://bugs.webkit.org/show_bug.cgi?id=239657 + +Reviewed by Chris Dumez. + +* web-platform-tests/service-workers/service-worker/credentials.https-expected.txt: + +2022-04-27 Youenn Fablet + Shared workers should match service worker registrations https://bugs.webkit.org/show_bug.cgi?id=239122 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https-expected.txt (293505 => 293506) --- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https-expected.txt 2022-04-27 11:59:59 UTC (rev 293505) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/credentials.https-expected.txt 2022-04-27 13:12:28 UTC (rev 293506) @@ -1,7 +1,7 @@ PASS Set cookies as initialization PASS Main script should have credentials -FAIL Imported script should have credentials promise_test: Unhandled rejection with value: object "TypeError: null is not an object (evaluating 'worker.postMessage')" -FAIL Module with an imported statement should not have credentials promise_test: Unhandled rejection with value: object "TypeError: null is not an object (evaluating 'worker.postMessage')" +PASS Imported script should have credentials +PASS Module with an imported statement should not have credentials FAIL Script with service worker served as modules should not have credentials assert_equals: new module worker should not have credentials expected (undefined) undefined but got (string) "1" Modified: trunk/Source/WebCore/ChangeLog (293505 => 293506) --- trunk/Source/WebCore/ChangeLog 2022-04-27 11:59:59 UTC (rev 293505) +++ trunk/Source/WebCore/ChangeLog 2022-04-27 13:12:28 UTC (rev 293506) @@ -1,3 +1,31 @@ +2022-04-27 Youenn Fablet + +servic
[webkit-changes] [293505] trunk/Source/WTF
Title: [293505] trunk/Source/WTF Revision 293505 Author dp...@igalia.com Date 2022-04-27 04:59:59 -0700 (Wed, 27 Apr 2022) Log Message [GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref' https://bugs.webkit.org/show_bug.cgi?id=239805 Reviewed by Žan Doberšek. GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref'. The latter was introduced in GCC9.4: https://github.com/gcc-mirror/gcc/blob/releases/gcc-9.4.0/libstdc%2B%2B-v3/include/std/type_traits#L3024 The flag '__cpp_lib_remove_cvref' is used to check whether 'remove_cvref_t' is defined, but it's not posible to rely on it for GCC9.3 as explained on the paragraph above. Instead we check whether __cplusplus is <= 201703L since the GCC commit that defined 'remove_cvref_t' does it if __cplusplus > 201703L. See: https://github.com/gcc-mirror/gcc/commit/6791489ee5214b0181aa22adc250cbbde1897a5c * wtf/StdLibExtras.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/StdLibExtras.h Diff Modified: trunk/Source/WTF/ChangeLog (293504 => 293505) --- trunk/Source/WTF/ChangeLog 2022-04-27 11:14:44 UTC (rev 293504) +++ trunk/Source/WTF/ChangeLog 2022-04-27 11:59:59 UTC (rev 293505) @@ -1,3 +1,26 @@ +2022-04-27 Diego Pino Garcia + +[GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref' +https://bugs.webkit.org/show_bug.cgi?id=239805 + +Reviewed by Žan Doberšek. + +GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref'. The +latter was introduced in GCC9.4: + + https://github.com/gcc-mirror/gcc/blob/releases/gcc-9.4.0/libstdc%2B%2B-v3/include/std/type_traits#L3024 + +The flag '__cpp_lib_remove_cvref' is used to check whether 'remove_cvref_t' +is defined, but it's not posible to rely on it for GCC9.3 as explained on the +paragraph above. + +Instead we check whether __cplusplus is <= 201703L since the GCC commit +that defined 'remove_cvref_t' does it if __cplusplus > 201703L. See: + + https://github.com/gcc-mirror/gcc/commit/6791489ee5214b0181aa22adc250cbbde1897a5c + +* wtf/StdLibExtras.h: + 2022-04-26 Manuel Rego Casasnovas Remove AriaReflectionEnabled runtime flag Modified: trunk/Source/WTF/wtf/StdLibExtras.h (293504 => 293505) --- trunk/Source/WTF/wtf/StdLibExtras.h 2022-04-27 11:14:44 UTC (rev 293504) +++ trunk/Source/WTF/wtf/StdLibExtras.h 2022-04-27 11:59:59 UTC (rev 293505) @@ -605,7 +605,8 @@ #define WTFMove(value) std::move(value) -#if defined(__GLIBCXX__) && !defined(__cpp_lib_remove_cvref) +// TODO: Needed for GCC<=9.3. Remove it after Ubuntu 20.04 end of support (May 2023). +#if defined(__GLIBCXX__) && __cplusplus <= 201703L namespace std { template struct remove_cvref { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293504] trunk/Source/WebCore
Title: [293504] trunk/Source/WebCore Revision 293504 Author commit-qu...@webkit.org Date 2022-04-27 04:14:44 -0700 (Wed, 27 Apr 2022) Log Message [LBSE] Fix origin of transformations in SVG https://bugs.webkit.org/show_bug.cgi?id=239717 Patch by Nikolas Zimmermann on 2022-04-27 Reviewed by Rob Buis. Fix the majority of SVG transform issues in LBSE. webkit.org/b/237711 laid the groundwork for SVG transforms in LBSE, however there are still issues: - SVG transforms specified alone on SVG elements, w/o any additional style/perspective related property such as transform-box / transform-origin / ... do not trigger layer creation, fix by adapting StyleAdjuster. - Switching on/off transforms for a SVG element, was not tracking updates to both 'HasSVGTransform' and 'HasTransformRelatedProperty' flags correctly, fix that by introducing an 'updateHasSVGTransformFlags' helper. - Modify SVGContainerLayout to avoid a dependency on the children transformations when computing container boundaries. In the legacy engine, we always have to mark the whole ancestor chain as 'need to recompute boundaries' and invoking a re-layout, to perform the recomputation. This change avoids the invalidation of the whole ancestor chain, when an elements transform changes in a non-accelerated way (e.g. SVGTransformList manipulation, SMIL / / ). In CSS transformations do not affect layout, only hit-testing and painting. -> SVG/CSS transforms applied on SVG elements is conceptually equivalent to CSS transformations on CSS boxes now. Transformation changes no longer affect the 'internal geometry' (objectBoundingBoxWithoutTransformations()). currentSVGLayoutLocation() / nominalSVGLayoutLocation() are computed using the 'internal geometry' and used throughout layout. This avoids most of the RenderLayer / RenderLayerBacking specific changes that were present in the downstream LBSE implementation, while also solving an important design issue: no back-splash from children to parents. Large, deep nested documents -- as seen in the wild -- will benefit the most, avoiding the frequent ancestor walks to mark the containing block / parent hierachy for re-layout. Covered by existing tests, no change in behaviour. (However testability for LBSE is ready soon!). * rendering/RenderElement.cpp: (WebCore::RenderElement::referenceBoxRect const): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::canCreateStackingContext): (WebCore::RenderLayer::paintLayerByApplyingTransform): * rendering/RenderLayer.h: (WebCore::RenderLayer::rendererLocation const): * rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::styleDidChange): (WebCore::RenderLayerModelObject::computeVisibleRectInSVGContainer const): (WebCore::RenderLayerModelObject::updateHasSVGTransformFlags): * rendering/RenderLayerModelObject.h: (WebCore::RenderLayerModelObject::nominalSVGLayoutLocation const): (WebCore::RenderLayerModelObject::currentSVGLayoutLocation const): (WebCore::RenderLayerModelObject::setCurrentSVGLayoutLocation): * rendering/RenderObject.h: (WebCore::RenderObject::objectBoundingBoxWithoutTransformations const): * rendering/svg/RenderSVGBlock.h: * rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layoutChildren): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::nodeAtPoint): (WebCore::RenderSVGContainer::styleDidChange): Deleted. * rendering/svg/RenderSVGContainer.h: * rendering/svg/RenderSVGInline.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::updateFromStyle): (WebCore::RenderSVGModelObject::absoluteRects const): * rendering/svg/RenderSVGModelObject.h: (WebCore::RenderSVGModelObject::currentSVGLayoutRect const): (WebCore::RenderSVGModelObject::setCurrentSVGLayoutRect): (WebCore::RenderSVGModelObject::frameRectEquivalent const): (WebCore::RenderSVGModelObject::applyTopLeftLocationOffsetEquivalent const): (WebCore::RenderSVGModelObject::layoutRect const): Deleted. (WebCore::RenderSVGModelObject::setLayoutRect): Deleted. (WebCore::RenderSVGModelObject::setLayoutLocation): Deleted. (WebCore::RenderSVGModelObject::paintingLocation const): Deleted. (WebCore::RenderSVGModelObject::layoutLocation const): Deleted. (WebCore::RenderSVGModelObject::layoutLocationOffset const): Deleted. (WebCore::RenderSVGModelObject::layoutSize const): Deleted. * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::updateFromStyle): * rendering/svg/RenderSVGRoot.h: * rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::layout): (WebCore::RenderSVGShape::paint): (WebCore::RenderSVGShape::nodeAtPoint): * rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::updateFromStyle): * rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::handleRootOrContainer const): * rendering/svg/SVGBoundingBoxComputation.h: (WebCore::SVGBoundingBoxComputation
[webkit-changes] [293503] trunk/Source/WebCore
Title: [293503] trunk/Source/WebCore Revision 293503 Author you...@apple.com Date 2022-04-27 03:36:07 -0700 (Wed, 27 Apr 2022) Log Message always sends credentials to different-origin, ignoring crossorigin=anonymous https://bugs.webkit.org/show_bug.cgi?id=239119 Reviewed by John Wilander. Update the check as per spec, step 5 of https://html.spec.whatwg.org/multipage/links.html#link-type-preconnect This is difficult to test as preconnect can only expose TLS credentials. * loader/LinkLoader.cpp: (WebCore::LinkLoader::preconnectIfNeeded): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/LinkLoader.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (293502 => 293503) --- trunk/Source/WebCore/ChangeLog 2022-04-27 09:10:04 UTC (rev 293502) +++ trunk/Source/WebCore/ChangeLog 2022-04-27 10:36:07 UTC (rev 293503) @@ -1,5 +1,21 @@ 2022-04-27 Youenn Fablet + always sends credentials to different-origin, ignoring crossorigin=anonymous +https://bugs.webkit.org/show_bug.cgi?id=239119 + + +Reviewed by John Wilander. + +Update the check as per spec, step 5 of +https://html.spec.whatwg.org/multipage/links.html#link-type-preconnect + +This is difficult to test as preconnect can only expose TLS credentials. + +* loader/LinkLoader.cpp: +(WebCore::LinkLoader::preconnectIfNeeded): + +2022-04-27 Youenn Fablet + Add testRunner API to clear memory cache https://bugs.webkit.org/show_bug.cgi?id=239804 rdar://92033309 Modified: trunk/Source/WebCore/loader/LinkLoader.cpp (293502 => 293503) --- trunk/Source/WebCore/loader/LinkLoader.cpp 2022-04-27 09:10:04 UTC (rev 293502) +++ trunk/Source/WebCore/loader/LinkLoader.cpp 2022-04-27 10:36:07 UTC (rev 293503) @@ -214,7 +214,7 @@ return; ASSERT(document.settings().linkPreconnectEnabled()); StoredCredentialsPolicy storageCredentialsPolicy = StoredCredentialsPolicy::Use; -if (equalLettersIgnoringASCIICase(params.crossOrigin, "anonymous"_s) && document.securityOrigin().isSameOriginDomain(SecurityOrigin::create(href))) +if (equalLettersIgnoringASCIICase(params.crossOrigin, "anonymous"_s) && !document.securityOrigin().isSameOriginDomain(SecurityOrigin::create(href))) storageCredentialsPolicy = StoredCredentialsPolicy::DoNotUse; ASSERT(document.frame()->loader().networkingContext()); platformStrategies()->loaderStrategy()->preconnectTo(document.frame()->loader(), href, storageCredentialsPolicy, LoaderStrategy::ShouldPreconnectAsFirstParty::No, [weakDocument = WeakPtr { document }, href](ResourceError error) { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293502] trunk
Title: [293502] trunk Revision 293502 Author you...@apple.com Date 2022-04-27 02:10:04 -0700 (Wed, 27 Apr 2022) Log Message Add testRunner API to clear memory cache https://bugs.webkit.org/show_bug.cgi?id=239804 rdar://92033309 Reviewed by Chris Dumez. Source/WebCore: * testing/Internals.cpp: (WebCore::Internals::clearMemoryCache): Beef up clearMemoryCache to be on par with testRunner counterpart. Source/WebKit: Add necessary WebKit API to implement the testRunner API. Make use of new testRunner API in added test. Test: http/wpt/fetch/clear-memory-cache.html * NetworkProcess/NetworkProcess.cpp: * UIProcess/API/C/WKWebsiteDataStoreRef.cpp: * UIProcess/API/C/WKWebsiteDataStoreRef.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: Tools: Implement the clear memory cache testRunner API and related plumbery. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: LayoutTests: * http/wpt/fetch/clear-memory-cache-expected.txt: Added. * http/wpt/fetch/clear-memory-cache.html: Added. * http/wpt/fetch/resources/clear-memory-cache.py: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h trunk/Tools/WebKitTestRunner/TestController.cpp trunk/Tools/WebKitTestRunner/TestController.h trunk/Tools/WebKitTestRunner/TestInvocation.cpp Added Paths trunk/LayoutTests/http/wpt/fetch/clear-memory-cache-expected.txt trunk/LayoutTests/http/wpt/fetch/clear-memory-cache.html trunk/LayoutTests/http/wpt/fetch/resources/clear-memory-cache.py Diff Modified: trunk/LayoutTests/ChangeLog (293501 => 293502) --- trunk/LayoutTests/ChangeLog 2022-04-27 08:21:21 UTC (rev 293501) +++ trunk/LayoutTests/ChangeLog 2022-04-27 09:10:04 UTC (rev 293502) @@ -1,5 +1,17 @@ 2022-04-27 Youenn Fablet +Add testRunner API to clear memory cache +https://bugs.webkit.org/show_bug.cgi?id=239804 +rdar://92033309 + +Reviewed by Chris Dumez. + +* http/wpt/fetch/clear-memory-cache-expected.txt: Added. +* http/wpt/fetch/clear-memory-cache.html: Added. +* http/wpt/fetch/resources/clear-memory-cache.py: Added. + +2022-04-27 Youenn Fablet + Shared workers should match service worker registrations https://bugs.webkit.org/show_bug.cgi?id=239122 Added: trunk/LayoutTests/http/wpt/fetch/clear-memory-cache-expected.txt (0 => 293502) --- trunk/LayoutTests/http/wpt/fetch/clear-memory-cache-expected.txt (rev 0) +++ trunk/LayoutTests/http/wpt/fetch/clear-memory-cache-expected.txt 2022-04-27 09:10:04 UTC (rev 293502) @@ -0,0 +1,3 @@ + +PASS Clear memory cache between fetches + Added: trunk/LayoutTests/http/wpt/fetch/clear-memory-cache.html (0 => 293502) --- trunk/LayoutTests/http/wpt/fetch/clear-memory-cache.html (rev 0) +++ trunk/LayoutTests/http/wpt/fetch/clear-memory-cache.html 2022-04-27 09:10:04 UTC (rev 293502) @@ -0,0 +1,31 @@ + + +promise_test(async (test) => { +const uuid = token(); +const url = "" + '/WebKit/fetch/resources/clear-memory-cache.py?uuid=' + uuid; + +await fetch(url, { mode: 'cors', headers: [['header', 'value']] }); + +let response = await fetch(url, { mode: 'cors' }); +assert_equals(await response.text(), "1"); + +if (window.testRunner && testRunner.clearMemoryCache) +testRunner.clearMemoryCache(); + +if (window.internals) +internals.clearMemoryCache(); + +await fetch(url, { mode: 'cors', headers: [['header', 'value']] }); + +response = await fetch(url, { mode: 'cors' }); + +if (!window.testRunner) +return; + +assert_equals(await response.text(), "2"); +}, "Clear memory cache between fetches"); + Added: trunk/LayoutTests/http/wpt/fetch/resources/clear-memory-cache.py (0 => 293502) --- trunk/LayoutTests/http/wpt/fetch/resources/clear-memory-cache.py (rev 0) +++ trunk/LayoutTests/http/wpt/fetch/resources/clear-memory-cache.py 2022-04-27 09:10:04 UTC (rev 293502) @@ -0,0 +1,23 @@ +import time + + +def main(request, response): +headers = [("Content-Type", "text/plain")] +headers.append(("Access-Control-Allow-Origin", "*")) +headers.append(("Access-Control-Allow-Methods", "GET")) +headers.append(("Access-Control-Allow-Headers", "header")) +
[webkit-changes] [293501] trunk
Title: [293501] trunk Revision 293501 Author you...@apple.com Date 2022-04-27 01:21:21 -0700 (Wed, 27 Apr 2022) Log Message Shared workers should match service worker registrations https://bugs.webkit.org/show_bug.cgi?id=239122 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/clients-get-client-types.https-expected.txt: * web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: * web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt: * web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt: Source/WebCore: Update SharedWorkerScriptLoader to set correctly client ID and service worker data. Ditto for SharedWorkerThread and SharedWorkerThreadProxy. Add support to get a SharedWorkerThreadProxy from a client ID. Use this in SWClientConnection to add support for controller change and post messaging. Given we create the shared worker identifier in one web process but we might spawn the actual worker in another process, we need to unregister the identifier with the old process identifier and register the identifier with the new process identifier. This is done at shared worker launch time. Covered by updated tests. Test: http/wpt/service-workers/controlled-sharedworker.https.html * Headers.cmake: * workers/Worker.cpp: * workers/Worker.h: * workers/WorkerGlobalScope.cpp: * workers/WorkerInitializationData.h: * workers/WorkerScriptLoader.cpp: * workers/WorkerScriptLoader.h: * workers/service/server/SWServer.cpp: (WebCore::SWServer::gatherClientData): * workers/service/server/SWServer.h: * workers/service/SWClientConnection.cpp: * workers/service/ServiceWorkerContainer.cpp: * workers/shared/SharedWorkerObjectConnection.cpp: * workers/shared/SharedWorkerObjectConnection.h: * workers/shared/SharedWorkerScriptLoader.cpp: * workers/shared/SharedWorkerScriptLoader.h: * workers/shared/context/SharedWorkerThread.cpp: * workers/shared/context/SharedWorkerThreadProxy.cpp: * workers/shared/context/SharedWorkerThreadProxy.h: Source/WebKit: * NetworkProcess/NetworkResourceLoader.cpp: * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: * NetworkProcess/ServiceWorker/WebSWServerConnection.h: * NetworkProcess/SharedWorker/WebSharedWorker.h: * NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp: * NetworkProcess/SharedWorker/WebSharedWorkerServer.h: * NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp: * NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h: * NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp: * WebProcess/Storage/WebSWClientConnection.cpp: * WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp: * WebProcess/Storage/WebSharedWorkerContextManagerConnection.h: * WebProcess/Storage/WebSharedWorkerContextManagerConnection.messages.in: * WebProcess/Storage/WebSharedWorkerObjectConnection.messages.in: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess): LayoutTests: * http/wpt/service-workers/controlled-sharedworker.https-expected.txt: Added. * http/wpt/service-workers/controlled-sharedworker.https.html: Added. * http/wpt/service-workers/resources/controlled-sharedworker.js: Added. * http/wpt/service-workers/skipFetchEvent-worker.js: * platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Removed. * platform/ios-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/wpt/service-workers/skipFetchEvent-worker.js trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/clients-get-client-types.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/workers/Worker.cpp trunk/Source/WebCore/workers/Worker.h trunk/Source/WebCore/workers/WorkerInitializationData.h trunk/Source/WebCore/workers/WorkerScriptLoader.cpp trunk/Source/WebCore/workers/WorkerScriptLoader.h trunk/Source/WebCore/workers/service/SWClientConnection.cpp trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebCore/workers/shared/SharedWorkerObjectConnection.cpp trunk/Source/WebCore/workers/shared/SharedWorkerObjectConnect