[webkit-changes] [WebKit/WebKit] d91881: [WebDriver][WPE] Scale mouse location according to...

[Jani Hautakangas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9188161eb32b47b2654c039309c7dbfcc6cd2ca
  
https://github.com/WebKit/WebKit/commit/d9188161eb32b47b2654c039309c7dbfcc6cd2ca
  Author: Jani Hautakangas 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp

  Log Message:
  ---
  [WebDriver][WPE] Scale mouse location according to device scale factor
https://bugs.webkit.org/show_bug.cgi?id=272643

Reviewed by Carlos Garcia Campos.

WebDriver operates in normal coordinates (not scaled) and thus location
in mouse simulation requests is not scaled according to device scale factor.

* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:
(WebKit::deviceScaleLocationInView):
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::WebAutomationSession::platformSimulateWheelInteraction):

Canonical link: https://commits.webkit.org/277725@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 37b300: [cocoa] Assume same-site resource requests for som...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37b300c499f7fbb76c2febf0a8f81d846a06f1d2
  
https://github.com/WebKit/WebKit/commit/37b300c499f7fbb76c2febf0a8f81d846a06f1d2
  Author: Matthew Finkel 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  ---
  [cocoa] Assume same-site resource requests for some embedders
https://bugs.webkit.org/show_bug.cgi?id=272850
rdar://125774727

Reviewed by Alex Christensen.

This change let's some applications request resources as if they are same-site
when the initiating document was loaded from a file.

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::addSameSiteInfoToRequestIfNeeded):

Canonical link: https://commits.webkit.org/277724@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 90f7cf: Modernize the way we enable libc++ assertions

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90f7cfafc165f41faa5d81d8178fef5f37f642d9
  
https://github.com/WebKit/WebKit/commit/90f7cfafc165f41faa5d81d8178fef5f37f642d9
  Author: Chris Dumez 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Configurations/CommonBase.xcconfig

  Log Message:
  ---
  Modernize the way we enable libc++ assertions
https://bugs.webkit.org/show_bug.cgi?id=272878

Reviewed by Geoffrey Garen.

Modernize the way we enable libc++ assertions. `-D_LIBCPP_ENABLE_ASSERTIONS=1` 
is
deprecated and will eventually stop working. It is now recommended to use
`CLANG_CXX_STANDARD_LIBRARY_HARDENING = extensive;` instead.

More details at:
https://github.com/llvm/llvm-project/blob/f9d761df50d12147fc7caa19927be81816d60e2d/libcxx/include/__config#L252-L272

* Configurations/CommonBase.xcconfig:

Canonical link: https://commits.webkit.org/277723@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd4bbb: [YARR JIT] Intermittent crash when calling through...

[Michael Saboff]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd4c4c513f941a99773e53798cedb694b9c4
  
https://github.com/WebKit/WebKit/commit/bd4c4c513f941a99773e53798cedb694b9c4
  Author: Michael Saboff 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/jit/JITThunks.cpp
M Source/JavaScriptCore/jit/JITThunks.h
M Source/JavaScriptCore/yarr/YarrJIT.cpp
M Source/JavaScriptCore/yarr/YarrJIT.h

  Log Message:
  ---
  [YARR JIT] Intermittent crash when calling through 
areCanonicallyEquivalentThunk
https://bugs.webkit.org/show_bug.cgi?id=272862
rdar://126253524

Reviewed by Yusuke Suzuki.

THe speculation for the crash we are seeing is that there is a race condition 
where the thunk's code is not
properly synced across all thread.
Moved the generation of the recently added areCanonicallyEquivalent thunk to be 
a common thunk that is created
at VM initialization time.

* Source/JavaScriptCore/jit/JITThunks.cpp:
(JSC::JITThunks::initialize):
* Source/JavaScriptCore/jit/JITThunks.h:
* Source/JavaScriptCore/yarr/YarrJIT.cpp:
(JSC::Yarr::areCanonicallyEquivalentThunkGenerator):
* Source/JavaScriptCore/yarr/YarrJIT.h:

Canonical link: https://commits.webkit.org/277722@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f27fb1: [webkitscmpy] Allow responses to Bitbucket comments

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f27fb1f4bcaa82a48e1e80045a8d02a3219569dd
  
https://github.com/WebKit/WebKit/commit/f27fb1f4bcaa82a48e1e80045a8d02a3219569dd
  Author: Jonathan Bedard 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
M 
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py

  Log Message:
  ---
  [webkitscmpy] Allow responses to Bitbucket comments
https://bugs.webkit.org/show_bug.cgi?id=272915
rdar://126707905

Reviewed by Elliott Williams.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket.request): Process response comments.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.PRGenerator.comment): Allow comments to be made in response to
other comments.
(BitBucket.PRGenerator._children_for_comment): Recursively extract responses
from the current comment.
(BitBucket.PRGenerator.comments): Ensure that we return all response comments 
as well.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

Canonical link: https://commits.webkit.org/277721@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e74b50: [webkitpy] SingleTestRunner should use expected pa...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e74b50bb809762e861795aa960e7a7f6150c2f8d
  
https://github.com/WebKit/WebKit/commit/e74b50bb809762e861795aa960e7a7f6150c2f8d
  Author: Sam Sneddon 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
M Tools/Scripts/webkitpy/layout_tests/models/test_input.py
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/base_unittest.py

  Log Message:
  ---
  [webkitpy] SingleTestRunner should use expected paths from Test objects
https://bugs.webkit.org/show_bug.cgi?id=271060

Reviewed by Jonathan Bedard.

Now LayoutTestFinder is populating the Test object's expectation paths,
we should use them in SingleTestRunner.

This doesn't migrate the other call sites of Port.expected_filename and
Port.expected_baselines to using the Test object's attributes, as these
aren't on such commonly used code paths.

* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(TestShard.pack): TestInput.reference_files is gone.
* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._test_input_for_file): TestInput.reference_files is gone.
* Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__): Use Test paths.
(SingleTestRunner._reference_files): Ditto.
(SingleTestRunner._expected_driver_output): Ditto.
(SingleTestRunner._driver_input): Ditto.
* Tools/Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput): Remove reference_files, as it is always set to 
test.reference_files.
* Tools/Scripts/webkitpy/port/base.py:
(Port.expected_checksum): Deleted.
(Port.expected_image): Deleted.
(Port.expected_audio): Deleted.
(Port.expected_text): Deleted.
(Port.reference_files): Deleted.
* Tools/Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_reference_files): Deleted.
(PortTest.test_ref_tests_platform_directory): Deleted.

Canonical link: https://commits.webkit.org/277720@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 67f578: [IFC] IntrinsicWidthHandler::simplifiedMaximumWidt...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67f57808709eaddc79ef1270580c9b35537f1d01
  
https://github.com/WebKit/WebKit/commit/67f57808709eaddc79ef1270580c9b35537f1d01
  Author: Alan Baradlay 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp

  Log Message:
  ---
  [IFC] IntrinsicWidthHandler::simplifiedMaximumWidth should use pre-computed 
text width
https://bugs.webkit.org/show_bug.cgi?id=272938

Reviewed by Simon Fraser.

* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
(WebCore::Layout::IntrinsicWidthHandler::simplifiedMaximumWidth):

Canonical link: https://commits.webkit.org/277719@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f9739: [WebGPU] ComputePassEncoder::setBindGroup crashes ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f97395cfff8d3cd7effe4a5a3c31638cc50eccd
  
https://github.com/WebKit/WebKit/commit/5f97395cfff8d3cd7effe4a5a3c31638cc50eccd
  Author: Mike Wyrzykowski 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-272863-expected.txt
A LayoutTests/fast/webgpu/fuzz-272863.html
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/CommandEncoder.h
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] ComputePassEncoder::setBindGroup crashes under some invalid arguments
https://bugs.webkit.org/show_bug.cgi?id=272863


Reviewed by Tadeu Zagallo.

Fix validation errors which were largely caught at the Metal framework layer
but would result in release crashes if run with the validation layer enabled.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-272863-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-272863.html: Added.
Add regression tests, the test passes if it reaches the end.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::ensureBlitCommandEncoder):
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::encoderIsCurrent const):
(WebGPU::CommandEncoder::copyTextureToTexture):
(WebGPU::CommandEncoder::validateFinishError const):
(WebGPU::CommandEncoder::resolveQuerySet):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::makeRenderBundleICBWithResources):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:

Canonical link: https://commits.webkit.org/277718@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5b8f34: [LDM] Enforce LDM Font Policy in GPUP & avoid trus...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b8f348c9f76a60a96c3a6ce9cd171d609c4bc77
  
https://github.com/WebKit/WebKit/commit/5b8f348c9f76a60a96c3a6ce9cd171d609c4bc77
  Author: Vitor Roriz 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp
M Source/WebCore/loader/cache/CachedFont.cpp
M Source/WebCore/loader/cache/CachedFont.h
M Source/WebCore/loader/cache/CachedFontLoadRequest.h
M Source/WebCore/loader/cache/TrustedFonts.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  [LDM] Enforce LDM Font Policy in GPUP & avoid trusted list SFP is enabled
https://bugs.webkit.org/show_bug.cgi?id=272247
rdar://124235570

Reviewed by Brent Fulgham.

If SafeFontParser is enabled we should use the SFP on both WCP and GPUP sides
and we should not parse trusted fonts with the system font parser.

When SFP is disabled we should switch to using the system parser but only
for trusted fonts, like before.

The difference after this patch is that if the SafeFontParser is enabled
we will no longer check first for trusted fonts that can be parsed
with the system font parser like before.

Canonical link: https://commits.webkit.org/277717@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ac5c0e: REGRESSION (277669@main): [ MacOS iOS ] imported/w...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac5c0ed2e710e52ba5dac8b30c69f85424fb6f13
  
https://github.com/WebKit/WebKit/commit/ac5c0ed2e710e52ba5dac8b30c69f85424fb6f13
  Author: Jay Stfleur 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  REGRESSION (277669@main): [ MacOS iOS ] 
imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-form-controls-crash.html
 is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=272944
rdar://126722146

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/277716@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] df92eb: [Gardening]: [ macOS wk1 ] imported/w3c/web-platfo...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df92eb7d845399795a7b37a302980d3b5e8ff18b
  
https://github.com/WebKit/WebKit/commit/df92eb7d845399795a7b37a302980d3b5e8ff18b
  Author: Marta Darbinyan 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: [ macOS wk1 ] 
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/referrer-strict-policies.sub.html
 is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=272939
rdar://126720196

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277715@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 554ffc: [view-transitions] Image capture rectangle doesn't...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 554ffc8d53654f1534876ec80ce8857162e005b9
  
https://github.com/WebKit/WebKit/commit/554ffc8d53654f1534876ec80ce8857162e005b9
  Author: Matt Woodrow 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderViewTransitionCapture.h

  Log Message:
  ---
  [view-transitions] Image capture rectangle doesn't include positioned 
descendants.
https://bugs.webkit.org/show_bug.cgi?id=272875


Reviewed by Tim Nguyen.

Consolidate three different callers of 'localBoundingBox' into a single helper
'captureOverflowRect', or read from the previous value on 
RenderViewTransitionCapture.

Switch to using 'calculateLayerBounds' instead of 'localBoundingBox', since this
also recurses through descendant layers.

Adds a new flag 'PreserveAncestorFlags' to ensure that 
'UseLocalClipRectIfPossible'
isn't added when recursing through descendants (which incorrectly applies 
overflow
clipping to descendants that have a containing block outside).

If the captured element is the root element, use the snapshot containing block 
size
instead of the ink overflow rectangle.

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::captureOverflowRect):
(WebCore::snapshotElementVisualOverflowClippedToViewport):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::updatePseudoElementStyles):
(WebCore::snapshotNodeVisualOverflowClippedToViewport): Deleted.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
* Source/WebCore/rendering/RenderLayer.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
* Source/WebCore/rendering/RenderViewTransitionCapture.h:

Canonical link: https://commits.webkit.org/277714@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 24ec2d: NEW TEST(276807@main): [ iOS ] fast/scrolling/ios/...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24ec2ddb088d07ae23d8234adb5588600a8d50bc
  
https://github.com/WebKit/WebKit/commit/24ec2ddb088d07ae23d8234adb5588600a8d50bc
  Author: Jay Stfleur 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  NEW TEST(276807@main): [ iOS ] 
fast/scrolling/ios/video-atop-overflow-scroll.html is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=272910
rdar://126703279

Unreviewed test gardening.

Changing TestExpectations from timeout to Skip.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/277713@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 965984: [ MacOS iOS ] 2X imported/w3c/web-platform-tests/c...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9659849800aebbb4a1dbae7ef843211dccd5733b
  
https://github.com/WebKit/WebKit/commit/9659849800aebbb4a1dbae7ef843211dccd5733b
  Author: Jay Stfleur 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/percentage-padding-orthogonal-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/padding-percent-orthogonal-dynamic-expected.txt

  Log Message:
  ---
  [ MacOS iOS ] 2X imported/w3c/web-platform-tests/css/css are consistent 
failures
https://bugs.webkit.org/show_bug.cgi?id=272930
rdar://126714183

Unreviewed test gardening.

Adding rebaseline.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/percentage-padding-orthogonal-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/padding-percent-orthogonal-dynamic-expected.txt:

Canonical link: https://commits.webkit.org/277712@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2ca109: Adding CryptoKit for ECDSA/ECDH

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ca10927173d23111c5d44e97fab308f397e49b8
  
https://github.com/WebKit/WebKit/commit/2ca10927173d23111c5d44e97fab308f397e49b8
  Author: Nitin Mahendru 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp
M Source/WebCore/Modules/webauthn/fido/Pin.cpp
M Source/WebCore/Modules/webauthn/fido/Pin.h
M Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift
M Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift
M Source/WebCore/PAL/pal/crypto/CryptoDigest.h
M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp
M Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp
M Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp
M Source/WebCore/bindings/js/SerializedScriptValue.cpp
M Source/WebCore/crypto/CryptoAlgorithm.cpp
M Source/WebCore/crypto/CryptoAlgorithm.h
M Source/WebCore/crypto/CryptoKey.h
M Source/WebCore/crypto/SubtleCrypto.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCBC.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCBC.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCFB.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCFB.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCTR.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCTR.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESGCM.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESGCM.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESKW.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESKW.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmECDSA.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmECDSA.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmEd25519.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmEd25519.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmPBKDF2.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmPBKDF2.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.h
M Source/WebCore/crypto/algorithms/CryptoAlgorithmX25519.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmX25519.h
M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDHMac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp
M Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp
M Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESGCMGCrypt.cpp
M Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESKWGCrypt.cpp
M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp
M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp
M Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp
M Source/WebCore/crypto/keys/CryptoKeyAES.cpp
M Source/WebCore/crypto/keys/CryptoKeyAES.h
M Source/WebCore/crypto/keys/CryptoKeyEC.cpp
M Source/WebCore/crypto/keys/CryptoKeyEC.h
M Source/WebCore/crypto/openssl/CryptoAlgorithmAESGCMOpenSSL.cpp
M Source/WebCore/crypto/openssl/CryptoAlgorithmAESKWOpenSSL.cpp
M Source/WebCore/crypto/openssl/CryptoAlgorithmECDHOpenSSL.cpp
M Source/WebCore/crypto/openssl/CryptoAlgorithmECDSAOpenSSL.cpp
M Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
M Tools/TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp

  Log Message:
  ---
  Adding CryptoKit for ECDSA/ECDH
https://bugs.webkit.org/show_bug.cgi?id=272162
rdar://125914120

Reviewed by Pascoe and Alex Christensen.

With this change:
1. When CryptoKit is enabled, Swift Objects of type ECKey will be held in C++ 
UniqueRef inside CryptokeyEC.h.
2. C++ UniqueRef should be able to clean memory for Swift objects.
3. TestWebKitAPI also links with the swift generated header for CtapPinTestAPI.
4. CryptoKeyEC is fundamentally changed but when CryptoKit is not enabled, it 
should behave as it does
   

[webkit-changes] [WebKit/WebKit] e603a5: [gtest] Xcode build prioritizes stale headers in u...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e603a5bf4791befe50187dbaf3d1790d085289f7
  
https://github.com/WebKit/WebKit/commit/e603a5bf4791befe50187dbaf3d1790d085289f7
  Author: Elliott Williams 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/ThirdParty/gtest/xcode/Config/General.xcconfig

  Log Message:
  ---
  [gtest] Xcode build prioritizes stale headers in usr/local/ over project 
headers
rdar://126709800
https://bugs.webkit.org/show_bug.cgi?id=272922

Reviewed by Jonathan Bedard.

gtest-framework and gtest_main-static are two
separate build targets. The former depends on the latter, but the
former also copies headers to usr/local/include. So there is a (valid)
situation where gtest_main-static is compiling before new headers are
copied over.

Reorder gtest's search paths to prioritize headers in $(SRCROOT)/include
over build products.

* Source/ThirdParty/gtest/xcode/Config/General.xcconfig:

Canonical link: https://commits.webkit.org/277710@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 464e3e: Allow some access to localhost as mixed content

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 464e3e51f7c8b5a6d8ce6f077d0455307cf5721d
  
https://github.com/WebKit/WebKit/commit/464e3e51f7c8b5a6d8ce6f077d0455307cf5721d
  Author: Matthew Finkel 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
A 
LayoutTests/http/tests/security/mixedContent/insecure-localhost-image-in-main-frame-UpgradeMixedContent-expected.txt
A 
LayoutTests/http/tests/security/mixedContent/insecure-localhost-image-in-main-frame-UpgradeMixedContent.html
A 
LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-localhost-image.html
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/loader/MixedContentChecker.cpp
M Source/WebCore/page/SecurityOrigin.cpp
M Source/WebCore/page/SecurityOrigin.h
M Source/WebCore/page/csp/ContentSecurityPolicy.cpp

  Log Message:
  ---
  Allow some access to localhost as mixed content
https://bugs.webkit.org/show_bug.cgi?id=272461
rdar://125851000

Reviewed by Alex Christensen.

Historically, WebKit has viewed localhost as insecure, but it allowed
unrestricted access to localhost. In 274409@main, I added support for Mixed
Content Level 2 where subresources are either upgraded from http: to https:, or
they are blocked.  But, we don't upgrade all subresources, we only upgrade a
subset of passive (image/video/audio) resources. If the resource fetch requires
CORS, then we block.

This change contains two fixes:

1) On iOS, continuing using the previous mixed content behavior via a 
Linked-On-Or-After check
2) Don't upgrade connections to localhost, but continue enforcing all other 
requirements

I also renamed the testing preference that controls whether we upgrade IP
addresses so that it now covers upgrading localhost, as well. The console log
message is adjusted to reflect this change, too.

This change includes one additional test that loads mixed content from
localhost, and I manually verified that the LOOA check.

* 
LayoutTests/http/tests/security/mixedContent/insecure-localhost-image-in-main-frame-UpgradeMixedContent-expected.txt:
 Added.
* 
LayoutTests/http/tests/security/mixedContent/insecure-localhost-image-in-main-frame-UpgradeMixedContent.html:
 Added.
* 
LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-localhost-image.html:
 Added.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/loader/MixedContentChecker.cpp:
(WebCore::logConsoleWarningForUpgrade):
(WebCore::isUpgradeMixedContentEnabled):
(WebCore::frameAndAncestorsCanDisplayInsecureContent):
(WebCore::MixedContentChecker::frameAndAncestorsCanRunInsecureContent):
(WebCore::MixedContentChecker::shouldUpgradeInsecureContent):
(WebCore::shouldBlockInsecureContent):
* Source/WebCore/page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::isLocalhostAddress):
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):
* Source/WebCore/page/SecurityOrigin.h:
* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::upgradeInsecureRequestIfNeeded const):

Canonical link: https://commits.webkit.org/277709@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1886cb: [ Gardening ]: REGRESSION (274826@main): [ Sonoma ...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1886cba7341352381c8b6abd33a8bde83e4329cd
  
https://github.com/WebKit/WebKit/commit/1886cba7341352381c8b6abd33a8bde83e4329cd
  Author: Marta Darbinyan 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [ Gardening ]: REGRESSION (274826@main): [ Sonoma WK1 ] 2X 
imported/w3c/web-platform-tests/mixed-content/tentative/autoupgrades tests are 
flaky failures
https://bugs.webkit.org/show_bug.cgi?id=272115
rdar://125870094

Unreviewed test gardening.

Updating test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277708@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e1738: Fix clean build after 277704@main

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e17384d22e1898190bfb474d68f2cd7341ac4e4
  
https://github.com/WebKit/WebKit/commit/8e17384d22e1898190bfb474d68f2cd7341ac4e4
  Author: Alex Christensen 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/DerivedSources-output.xcfilelist

  Log Message:
  ---
  Fix clean build after 277704@main
https://bugs.webkit.org/show_bug.cgi?id=272934
rdar://126716498

Unreviewed.

* Source/WebCore/DerivedSources-output.xcfilelist:

Canonical link: https://commits.webkit.org/277707@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8338d4: HTMLMediaElement.played TimeRanges missing the las...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8338d4d31d30908f186423844c9940b3356fd897
  
https://github.com/WebKit/WebKit/commit/8338d4d31d30908f186423844c9940b3356fd897
  Author: Jean-Yves Avenard 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/media/video-played-ranges-1-expected.txt
M LayoutTests/media/video-played-ranges-1.html
M LayoutTests/media/video-played.js
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  ---
  HTMLMediaElement.played TimeRanges missing the last range on ended
https://bugs.webkit.org/show_bug.cgi?id=271679
rdar://125741797

Reviewed by Eric Carlson.

Added TimeRange to `played` TimeRanges once we reach the end of the media.

* LayoutTests/media/video-played-ranges-1-expected.txt:
* LayoutTests/media/video-played-ranges-1.html:
* LayoutTests/media/video-played.js:
(pause):
(ended):
(async playUntilEnded):
(videoPlayedMain):
* LayoutTests/platform/ios/TestExpectations: Remove expectation as test was 
flacky due to the use
of the GPU process and incorrect time estimation, which was fixed in 276761@main
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

Canonical link: https://commits.webkit.org/277706@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 38694a: Generate serialization of CurlProxySettings

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38694a9a62607c8f9f4ad897d6c3257b57c2258a
  
https://github.com/WebKit/WebKit/commit/38694a9a62607c8f9f4ad897d6c3257b57c2258a
  Author: Don Olmstead 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/network/curl/CurlProxySettings.cpp
M Source/WebCore/platform/network/curl/CurlProxySettings.h
M Source/WebKit/Platform/Curl.cmake
M Source/WebKit/Shared/WebCoreArgumentCoders.h
R Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp
A Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.serialization.in

  Log Message:
  ---
  Generate serialization of CurlProxySettings
https://bugs.webkit.org/show_bug.cgi?id=272849

Reviewed by Chris Dumez and Alex Christensen.

Move serialization of `CurlProxySettings` into a `.serialization.in`. file.

* Source/WebCore/platform/network/curl/CurlProxySettings.cpp:
* Source/WebCore/platform/network/curl/CurlProxySettings.h:
* Source/WebKit/Platform/Curl.cmake:
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp: Removed.
* Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.serialization.in: Added.

Canonical link: https://commits.webkit.org/277705@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e32f0c: Rename some files after LocalDOMWindow.idl removal

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e32f0cd738261af59645c6910a4e26ace8f31947
  
https://github.com/WebKit/WebKit/commit/e32f0cd738261af59645c6910a4e26ace8f31947
  Author: Alex Christensen 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
A Source/WebCore/Modules/cookie-store/DOMWindow+CookieStore.idl
R Source/WebCore/Modules/cookie-store/LocalDOMWindow+CookieStore.idl
A Source/WebCore/Modules/speech/DOMWindow+SpeechSynthesis.idl
R Source/WebCore/Modules/speech/LocalDOMWindow+SpeechSynthesis.idl
A Source/WebCore/Modules/webdatabase/DOMWindow+WebDatabase.idl
R Source/WebCore/Modules/webdatabase/LocalDOMWindow+WebDatabase.idl
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/bindings/scripts/test/DOMWindowConstructors.idl
R Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindowConstructors.cpp
R Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindowConstructors.h
R Source/WebCore/bindings/scripts/test/LocalDOMWindowConstructors.idl
M Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep
A Source/WebCore/page/DOMWindow+CSSOM.idl
A Source/WebCore/page/DOMWindow+CSSOMView.idl
A Source/WebCore/page/DOMWindow+Compat.idl
A Source/WebCore/page/DOMWindow+DeviceMotion.idl
A Source/WebCore/page/DOMWindow+DeviceOrientation.idl
A Source/WebCore/page/DOMWindow+RequestIdleCallback.idl
A Source/WebCore/page/DOMWindow+Selection.idl
A Source/WebCore/page/DOMWindow+VisualViewport.idl
M Source/WebCore/page/DOMWindow.idl
R Source/WebCore/page/LocalDOMWindow+CSSOM.idl
R Source/WebCore/page/LocalDOMWindow+CSSOMView.idl
R Source/WebCore/page/LocalDOMWindow+Compat.idl
R Source/WebCore/page/LocalDOMWindow+DeviceMotion.idl
R Source/WebCore/page/LocalDOMWindow+DeviceOrientation.idl
R Source/WebCore/page/LocalDOMWindow+RequestIdleCallback.idl
R Source/WebCore/page/LocalDOMWindow+Selection.idl
R Source/WebCore/page/LocalDOMWindow+VisualViewport.idl
M Tools/Scripts/webkitpy/bindings/main.py

  Log Message:
  ---
  Rename some files after LocalDOMWindow.idl removal
https://bugs.webkit.org/show_bug.cgi?id=272867
rdar://126655433

Reviewed by Matthew Finkel.

It's now just DOMWindow.idl, which wraps a DOMWindow, which is either a 
LocalDOMWindow or a RemoteDOMWindow.
Rename some files to reflect this change.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/cookie-store/DOMWindow+CookieStore.idl: Renamed from 
Source/WebCore/Modules/cookie-store/LocalDOMWindow+CookieStore.idl.
* Source/WebCore/Modules/speech/DOMWindow+SpeechSynthesis.idl: Renamed from 
Source/WebCore/Modules/speech/LocalDOMWindow+SpeechSynthesis.idl.
* Source/WebCore/Modules/webdatabase/DOMWindow+WebDatabase.idl: Renamed from 
Source/WebCore/Modules/webdatabase/LocalDOMWindow+WebDatabase.idl.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/scripts/test/DOMWindowConstructors.idl: Renamed from 
Source/WebCore/bindings/scripts/test/LocalDOMWindowConstructors.idl.
* Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindowConstructors.cpp: 
Removed.
* Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindowConstructors.h: 
Removed.
* Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep:
* Source/WebCore/page/DOMWindow+CSSOM.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+CSSOM.idl.
* Source/WebCore/page/DOMWindow+CSSOMView.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+CSSOMView.idl.
* Source/WebCore/page/DOMWindow+Compat.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+Compat.idl.
* Source/WebCore/page/DOMWindow+DeviceMotion.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+DeviceMotion.idl.
* Source/WebCore/page/DOMWindow+DeviceOrientation.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+DeviceOrientation.idl.
* Source/WebCore/page/DOMWindow+RequestIdleCallback.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+RequestIdleCallback.idl.
* Source/WebCore/page/DOMWindow+Selection.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+Selection.idl.
* Source/WebCore/page/DOMWindow+VisualViewport.idl: Renamed from 
Source/WebCore/page/LocalDOMWindow+VisualViewport.idl.
* Source/WebCore/page/DOMWindow.idl:
* Tools/Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):

Canonical link: https://commits.webkit.org/277704@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [WebKit/WebKit] b920c9: Create debug overlay for Site Isolation

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b920c9fb0198dbe67b0aaff251dd078c3cfbaa17
  
https://github.com/WebKit/WebKit/commit/b920c9fb0198dbe67b0aaff251dd078c3cfbaa17
  Author: Pascoe 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/page/DebugOverlayRegions.h
M Source/WebCore/page/DebugPageOverlays.cpp
M Source/WebCore/page/DebugPageOverlays.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Tools/MiniBrowser/mac/SettingsController.h
M Tools/MiniBrowser/mac/SettingsController.m
M Tools/MiniBrowser/mac/WK2BrowserWindowController.m

  Log Message:
  ---
  Create debug overlay for Site Isolation
https://bugs.webkit.org/show_bug.cgi?id=272908
rdar://problem/126701278

Reviewed by Alex Christensen.

This change creates a debug overlay for identifying frames and if
they are either local or remote. This is useful for matching what frames
are what when debugging sites with i-frames with site isolation on.

Currently this only draws for the local main frame and that process's view
of the other frames. Once we can support view overlays in i-frame processes
this can be expanded to show the current hosting process of each remote i-frame.

* Source/WebCore/page/DebugOverlayRegions.h:
* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::SiteIsolationOverlay::updateRegion):
(WebCore::SiteIsolationOverlay::drawRect):
(WebCore::SiteIsolationOverlay::mouseEvent):
(WebCore::RegionOverlay::create):
(WebCore::DebugPageOverlays::updateOverlayRegionVisibility):
* Source/WebCore/page/DebugPageOverlays.h:
(WebCore::DebugPageOverlays::didLayout):
(WebCore::DebugPageOverlays::didChangeEventHandlers):
(WebCore::DebugPageOverlays::doAfterUpdateRendering):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::attachViewOverlayGraphicsLayer):
* Tools/MiniBrowser/mac/SettingsController.h:
* Tools/MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu:]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController preferenceKeyForRegionOverlayTag:]):
(-[SettingsController toggleSiteIsolationOverlay:]):
(-[SettingsController siteIsolationOverlayEnabled]):
(-[SettingsController siteIsolationOverlayVisible:]):
* Tools/MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]):

Canonical link: https://commits.webkit.org/277703@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f0f80b: IOSurface::createCompatibleBitmap allocates 8x siz...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0f80b72a8c3e8b0e4dfd54d133b27e7a1e7cbd7
  
https://github.com/WebKit/WebKit/commit/f0f80b72a8c3e8b0e4dfd54d133b27e7a1e7cbd7
  Author: Mike Wyrzykowski 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/cocoa/IOSurface.mm

  Log Message:
  ---
  IOSurface::createCompatibleBitmap allocates 8x size CGBitmapContext
https://bugs.webkit.org/show_bug.cgi?id=272317


Reviewed by Matt Woodrow and Tadeu Zagallo.

bytesPerRow = width * bytesPerPixel + padding but we were setting it to
width * bitsPerPixel + padding.

* Source/WebCore/platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::createCompatibleBitmap):

Canonical link: https://commits.webkit.org/277702@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bf2f6c: [Gardening]: [ Ventura wk1 ] 8 tests in imported/w...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf2f6c971ce1d21db58bed4d61fbed8bdfa18f93
  
https://github.com/WebKit/WebKit/commit/bf2f6c971ce1d21db58bed4d61fbed8bdfa18f93
  Author: Marta Darbinyan 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: [ Ventura wk1 ] 8 tests in 
imported/w3c/web-platform-tests/workers are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=272926
rdar://126711498

Unreviewed test gardening.

Updating test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277701@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e0154: REGRESSION(264584@main): Web Extension debug loggi...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e01542d58ad3d5c7370245d7cd460066215c3d1
  
https://github.com/WebKit/WebKit/commit/8e01542d58ad3d5c7370245d7cd460066215c3d1
  Author: Timothy Hatcher 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  REGRESSION(264584@main): Web Extension debug logging is not being logged.
https://webkit.org/b/272918
rdar://problem/126708221

Reviewed by Per Arne Vollan.

os_log_set_hook takes a minimum log type, so set this to OS_LOG_TYPE_DEBUG for
debug builds. Also only return early for debug and info types in release builds.

This makes sure debug builds get all log message types. While release builds 
stay
mostly the same as before. However, info logs are now also filtered out, which 
was
the expected behavior before, but info logs were still getting sent.

* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerLogHook):

Canonical link: https://commits.webkit.org/277700@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 240fb3: [JSC] Add CachedCall fast path for specific argume...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 240fb30df0de1f3b18ee5a4ca0c8c3b683044d50
  
https://github.com/WebKit/WebKit/commit/240fb30df0de1f3b18ee5a4ca0c8c3b683044d50
  Author: Yusuke Suzuki 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
A JSTests/microbenchmarks/uint32array-sort-custom.js
M Source/JavaScriptCore/interpreter/CachedCall.h
M Source/JavaScriptCore/interpreter/Interpreter.h
M Source/JavaScriptCore/interpreter/InterpreterInlines.h
M Source/JavaScriptCore/llint/LLIntThunks.cpp
M Source/JavaScriptCore/llint/LLIntThunks.h
M Source/JavaScriptCore/llint/LowLevelInterpreter.asm
M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
M Source/JavaScriptCore/offlineasm/arm64.rb
M Source/JavaScriptCore/offlineasm/registers.rb
M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h
M Source/JavaScriptCore/runtime/StringPrototypeInlines.h

  Log Message:
  ---
  [JSC] Add CachedCall fast path for specific argument count
https://bugs.webkit.org/show_bug.cgi?id=272860
rdar://126651919

Reviewed by Keith Miller.

Let's make up-to-3 argumentCount CachedCall incredibly faster. We would like to 
hand-craft that for the other argument counts.
Based on static argument count, we use super fast asm setup in LLInt to invoke 
JS function.

ToT Patched

uint32array-sort-custom   73.6850+-0.7307 ^ 53.4209+-1.7978 
   ^ definitely 1.3793x faster

* JSTests/microbenchmarks/uint32array-sort-custom.js: Added.
(i.array.sort):
* Source/JavaScriptCore/interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
(JSC::CachedCall::callWithArguments):
* Source/JavaScriptCore/interpreter/Interpreter.h:
* Source/JavaScriptCore/interpreter/InterpreterInlines.h:
(JSC::Interpreter::tryCallWithArguments2):
* Source/JavaScriptCore/llint/LLIntThunks.cpp:
* Source/JavaScriptCore/llint/LLIntThunks.h:
* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:
* Source/JavaScriptCore/offlineasm/arm64.rb:
* Source/JavaScriptCore/offlineasm/registers.rb:
* Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSortImpl):
* Source/JavaScriptCore/runtime/StringPrototypeInlines.h:
(JSC::replaceUsingStringSearch):

Canonical link: https://commits.webkit.org/277699@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7c15c: Introduce SPI to load and decode images in WebKit'...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7c15cf17874c779384544d521617cd905f32c4a
  
https://github.com/WebKit/WebKit/commit/c7c15cf17874c779384544d521617cd905f32c4a
  Author: Alex Christensen 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/ShareableBitmap.cpp
M Source/WebCore/platform/graphics/ShareableBitmap.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/PermissionsAPI.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm

  Log Message:
  ---
  Introduce SPI to load and decode images in WebKit's sandboxed processes
https://bugs.webkit.org/show_bug.cgi?id=272791
rdar://125571025

Reviewed by Tim Horton.

Load in the network process using the NSURLSession kind of like we do with 
_WKDataTask
but decode the image in the web content process, then send a bitmap to the UI 
process.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadImageForDecoding):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::loadImageForDecoding):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::loadImageForDecoding):
* Source/WebKit/Scripts/webkit/messages.py:
(class_template_headers):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _loadAndDecodeImage:constrainedToSize:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAndDecodeImage):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadAndDecodeImage):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm: Added.
(TestWebKitAPI::TEST(WebKit, LoadAndDecodeImage)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PermissionsAPI.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebRequest.mm:

Canonical link: https://commits.webkit.org/277698@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d137c5: REGRESSION (277677@main): [ MacOS ] accessibility/...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d137c5a7b8bf4bcbf6a02e5f245aad5895997a61
  
https://github.com/WebKit/WebKit/commit/d137c5a7b8bf4bcbf6a02e5f245aad5895997a61
  Author: Jay Stfleur 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  REGRESSION (277677@main): [ MacOS ] 
accessibility/focusable-inside-hidden.html is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=272923
rdar://126709970

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/277697@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 64a04d: REGRESSION(277674@main): Windows port doesn't skip...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 64a04d9ef753ca6513b4a37ab9add863d873df5c
  
https://github.com/WebKit/WebKit/commit/64a04d9ef753ca6513b4a37ab9add863d873df5c
  Author: Fujii Hironori 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Tools/Scripts/webkitpy/port/base.py

  Log Message:
  ---
  REGRESSION(277674@main): Windows port doesn't skip other platform tests
https://bugs.webkit.org/show_bug.cgi?id=272920

Reviewed by Jonathan Bedard.

After https://commits.webkit.org/277674@main, Windows port didn't skip
other platform tests, and a lot of test failures were reported. Test
names should use forward slashes rather than backward slashes for
directory separators. Use relative_test_filename to convert a test
file path to a test name.

* Tools/Scripts/webkitpy/port/base.py:

Canonical link: https://commits.webkit.org/277696@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a63a82: [gmock] Fix Xcode build after 277635@main

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a63a82fdd6f7e80cf60342f95abe13245185afe5
  
https://github.com/WebKit/WebKit/commit/a63a82fdd6f7e80cf60342f95abe13245185afe5
  Author: Elliott Williams 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/ThirdParty/gmock/Configurations/gmock.xcconfig

  Log Message:
  ---
  [gmock] Fix Xcode build after 277635@main
rdar://126699646
https://bugs.webkit.org/show_bug.cgi?id=272907

Unreviewed.

This seems to have gotten through because we don't build libgmock by
default; only fuzzer schemes do.

Add $(SRCROOT) as one of gmock's header search paths.

* Source/ThirdParty/gmock/Configurations/gmock.xcconfig:

Canonical link: https://commits.webkit.org/277695@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c0585c: REGRESSION (277481@main): [ MacOS iOS ] TestWebKit...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0585c6e126aad91705960171cfc6317a6c3051f
  
https://github.com/WebKit/WebKit/commit/c0585c6e126aad91705960171cfc6317a6c3051f
  Author: Tim Nguyen 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  REGRESSION (277481@main): [ MacOS iOS ] 
TestWebKitAPI.IPCTestingAPI.SerializedTypeInfo is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=272871
rdar://126657596

Reviewed by Aditya Keerthi.

The test log showed an item with leading whitespace that was introduced by 
277481@main:

{(
CTFontDescriptorOptions,
"NSObject",
WKDDActionContext,
PKSecureElementPass,
"WebKit::ObjCObjectGraph",
GCGLErrorCodeSet,
NSURLRequest,
CGDisplayChangeSummaryFlags,
" WebCore::ColorInterpolationMethod::XYZD50",
MachSendRight,
CGBitmapInfo,
"WebCore::ContextMenuAction",
NSParagraphStyle
)}

Fix it by removing that extra leading whitespace.

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/277694@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2de957: Cherry-pick 277671@main (fd47d132791d). https://bu...

[Georges Basile Stavracas Neto]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 2de9573a67b1089e9ac02ef63594996287ac47a0
  
https://github.com/WebKit/WebKit/commit/2de9573a67b1089e9ac02ef63594996287ac47a0
  Author: Georges Basile Stavracas Neto 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.h.in
M Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp

  Log Message:
  ---
  Cherry-pick 277671@main (fd47d132791d). 
https://bugs.webkit.org/show_bug.cgi?id=192748

[GTK] Implement printing using the Print portal
https://bugs.webkit.org/show_bug.cgi?id=192748

Reviewed by Michael Catanzaro.

When running inside a sandboxed environment - which is fairly common
nowadays - printing is severely limited due to using the legacy GTK
print API (GtkPrintUnixDialog & family).

Due to WebKit's multi-process architecture, using the modern alternative,
GtkPrintOperation, is not really possible, because GtkPrintOperation has
the enconded assumption that the rendering of the document pages happens
in the same process as of printing.

Implement manual support for the Print portal. The portal has two well
defined steps:

 1. PreparePrint() is where WebKit sends the settings and page setup
that are stored in WebKitPrintOperation to the portal. The portal
presents a dialog to let users choose their print preferences. This
step returns WebKit a token, which is the "authentication" mechanism
for the next step.

 2. Print() takes a token, and a file descriptor pointing to the file
that will be send to the printer. The file descriptor can and often
does point to an in-memory buffer! In WebKit's case, it's a tmpfile.

This effectively means that webkit_print_operation_print(), which assumes
that step 1 can be skipped - cannot work under a sandbox. Deprecate this
function, and adjust the tests to ignore this deprecation, as the tests
should be adapted separately.

* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationFinished):
(webkitPrintOperationFailed):
(webkitPrintOperationPrintPagesForFrame):
(findFilePrinter):
(webkitPrintOperationSendPagesToPrintPortal):
(webkitPrintOperationPreparePrint):
(webkitPrintOperationRunPortalDialog):
(webkitPrintOperationRunDialogForFrame):
* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.h.in:
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
(testPrintOperationPrint):
(testPrintOperationErrors):

Canonical link: https://commits.webkit.org/277671@main

Canonical link: https://commits.webkit.org/274313.141@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 73cc60: NEW TEST(276807@main): [ iOS ] fast/scrolling/ios/...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73cc606e430f9c2acbeab146c93bcedc6968a944
  
https://github.com/WebKit/WebKit/commit/73cc606e430f9c2acbeab146c93bcedc6968a944
  Author: Jay Stfleur 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  NEW TEST(276807@main): [ iOS ] 
fast/scrolling/ios/video-atop-overflow-scroll.html is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=272910
rdar://126703279

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/277693@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7766d8: Remove shouldAlwaysUsePluginDocument

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7766d8c67414d29385d2c60a7c2befa620e8feb0
  
https://github.com/WebKit/WebKit/commit/7766d8c67414d29385d2c60a7c2befa620e8feb0
  Author: Brandon Stewart 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/dom/DOMImplementation.cpp
M Source/WebCore/loader/DocumentWriter.cpp
M Source/WebCore/loader/LocalFrameLoaderClient.h
M Source/WebCore/loader/SubframeLoader.cpp

  Log Message:
  ---
  Remove shouldAlwaysUsePluginDocument
https://bugs.webkit.org/show_bug.cgi?id=272854

Reviewed by Alex Christensen.

This function always returns false now, and does not use the parameter input 
given at all.

* Source/WebCore/dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* Source/WebCore/loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
* Source/WebCore/loader/LocalFrameLoaderClient.h:
* Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::shouldUsePlugin):

Canonical link: https://commits.webkit.org/277692@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70a33e: Avoid duplicate NetworkProcess messages from UI pr...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70a33eef4cbbcb86adbff80586a9c5b71c4631ae
  
https://github.com/WebKit/WebKit/commit/70a33eef4cbbcb86adbff80586a9c5b71c4631ae
  Author: Sihui Liu 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  ---
  Avoid duplicate NetworkProcess messages from UI process
https://bugs.webkit.org/show_bug.cgi?id=272805
rdar://126604288

Reviewed by Chris Dumez.

These messages are currently sent to each WebsiteDataStore's network process. 
On Cocoa platforms, there is only one
network process shared by all WebsiteDataStores, so the same messages is sent 
to that process multiple times. To avoid
this, make UI process send message to each network process instead.

* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::updateProcessSuppressionState):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::registerURLSchemeAsSecure):
(WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit::WebProcessPool::registerURLSchemeAsLocal):
(WebKit::WebProcessPool::registerURLSchemeAsNoAccess):
(WebKit::WebProcessPool::setCacheModel):
(WebKit::WebProcessPool::setCacheModelSynchronouslyForTesting):

Canonical link: https://commits.webkit.org/277691@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f8c0fe: [Skia] Add initial support for accelerated filters

[Georges Basile Stavracas Neto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8c0fe750d94b7db23d193c0b1f31858c2537620
  
https://github.com/WebKit/WebKit/commit/f8c0fe750d94b7db23d193c0b1f31858c2537620
  Author: Georges Basile Stavracas Neto 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/page/Page.cpp
M Source/WebCore/platform/Skia.cmake
M Source/WebCore/platform/SourcesSkia.txt
M Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp
M Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp
M Source/WebCore/platform/graphics/filters/FEGaussianBlur.h
M Source/WebCore/platform/graphics/filters/FilterImage.cpp
M Source/WebCore/platform/graphics/filters/FilterImage.h
M Source/WebCore/platform/graphics/filters/SourceGraphic.cpp
A Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp
A Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.h
A 
Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.cpp
A Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.h
A Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.cpp
A Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.h
A Source/WebCore/platform/graphics/skia/FilterImageSkia.cpp

  Log Message:
  ---
  [Skia] Add initial support for accelerated filters
https://bugs.webkit.org/show_bug.cgi?id=272535

Reviewed by Carlos Garcia Campos.

This changeset enables accelerated filters on Skia builds.

Make WebCore::Page report FilterRenderingMode::Accelerated on Skia
builds if accelerated compositing is enabled.

Create Skia filters both in accelerated and software-based code paths,
since Skia is able to handle unaccelerated buffers transparently.

Add Skia-specific code to WebCore::FilterImage. The idea is that Skia
filters acquire a SkCanvas with WebCore::FilterImage::beginRecording(),
render the source image however they want, and finish the operation with
WebCore::FilterImage::finishRecording(). This generates a SkPicture
which is then used to paint on the resulting image buffer.

The memory cost is estimated using SkPicture. It's not an accurate
measure though.

Implement 3 filters as an exercise of usage of this new code:

 * SourceGraphicSkiaApplier, which merely copies the source image
 * FEColorMatrixSkiaApplier, for CSS and SVG filters like saturate(),
   greyscale(), contrast(), and others
 * FEGaussianBlurSkiaApplier, for the blur() filter

More filters will be added in follow up commits, as needed.

* Source/WebCore/page/Page.cpp:
(WebCore::Page::preferredFilterRenderingModes const):
* Source/WebCore/platform/Skia.cmake:
* Source/WebCore/platform/SourcesSkia.txt:
* Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::supportedFilterRenderingModes const):
(WebCore::FEColorMatrix::createAcceleratedApplier const):
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::supportedFilterRenderingModes const):
(WebCore::FEGaussianBlur::createAcceleratedApplier const):
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.h:
* Source/WebCore/platform/graphics/filters/FilterImage.cpp:
(WebCore::FilterImage::memoryCost const):
(WebCore::FilterImage::imageBuffer):
* Source/WebCore/platform/graphics/filters/FilterImage.h:
* Source/WebCore/platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::supportedFilterRenderingModes const):
(WebCore::SourceGraphic::createAcceleratedApplier const):
* Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp: 
Added.
(WebCore::FEColorMatrixSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.h: 
Added.
* Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.cpp: 
Added.
(WebCore::FEGaussianBlurSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.h: 
Added.
* Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.cpp: 
Added.
(WebCore::SourceGraphicSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.h: 
Added.
* Source/WebCore/platform/graphics/skia/FilterImageSkia.cpp: Added.
(WebCore::FilterImage::beginRecording):
(WebCore::FilterImage::finishRecording):
(WebCore::FilterImage::memoryCostOfSkPicture const):
(WebCore::FilterImage::imageBufferFromSkPicture):

Canonical link: https://commits.webkit.org/277690@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b62708: http/tests/site-isolation/mouse-events/context-men...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b62708aa740a5ab48986236524528d80b31cacde
  
https://github.com/WebKit/WebKit/commit/b62708aa740a5ab48986236524528d80b31cacde
  Author: Charlie Wolfe 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M 
LayoutTests/http/tests/site-isolation/mouse-events/context-menu-event-twice.html
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  http/tests/site-isolation/mouse-events/context-menu-event-twice.html is a 
flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=269581
rdar://123095618

Reviewed by Pascoe.

The first `eventSender.mouseUp(2)` may not have completed before the post 
message was received from the
iframe.

* 
LayoutTests/http/tests/site-isolation/mouse-events/context-menu-event-twice.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/277689@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a09b94: [Navigation] Track in-progress navigations

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a09b94a65009978eb3e5f4417b46f8687c834564
  
https://github.com/WebKit/WebKit/commit/a09b94a65009978eb3e5f4417b46f8687c834564
  Author: Patrick Griffis 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-base-url-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-gc-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-src-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-replace-same-document-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-rejection-order-detached-unserializablestate-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-unserializable-state-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/same-document-away-and-back-location-api-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/bindings/js/JSDOMPromiseDeferred.h
M Source/WebCore/page/Navigation.cpp
M Source/WebCore/page/Navigation.h

  Log Message:
  ---
  [Navigation] Track in-progress navigations
https://bugs.webkit.org/show_bug.cgi?id=272459

Reviewed by Alex Christensen.

This makes use of the NavigationAPITracker to correctly complete
the Navigation::Result when events happen.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-noop-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-base-url-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-gc-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-src-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-replace-same-document-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-already-detached-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-detach-in-serialization-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-already-detached-expected.txt:

* Source/WebCore/bindings/js/JSDOMPromiseDeferred.h:
(WebCore::callPromisePairFunction):

The JSPromise needs to not be cleared because we
create a DOMPromise with it later.

* Source/WebCore/page/Navigation.cpp:

[webkit-changes] [WebKit/WebKit] 09b92f: Unreviewed, reverting 277628@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09b92fa1a658c7f1e9f9a8afaea1e8a17fe435c8
  
https://github.com/WebKit/WebKit/commit/09b92fa1a658c7f1e9f9a8afaea1e8a17fe435c8
  Author: Commit Queue 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Unreviewed, reverting 277628@main.
https://bugs.webkit.org/show_bug.cgi?id=272906

Introduced install issue

Reverted changeset:

"Change install location of WebKit process extensions"
https://bugs.webkit.org/show_bug.cgi?id=268946
https://commits.webkit.org/277628@main

Canonical link: https://commits.webkit.org/277687@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] adca60: [Site Isolation] iframes draw with an incorrect si...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: adca60896eabbfccb570611296d8788df2bc57b5
  
https://github.com/WebKit/WebKit/commit/adca60896eabbfccb570611296d8788df2bc57b5
  Author: Charlie Wolfe 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
A 
LayoutTests/http/tests/site-isolation/draw-with-size-after-same-origin-navigation-expected.html
A 
LayoutTests/http/tests/site-isolation/draw-with-size-after-same-origin-navigation.html
A LayoutTests/http/tests/site-isolation/resources/navigate-to-text.html
A LayoutTests/http/tests/site-isolation/resources/text.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp

  Log Message:
  ---
  [Site Isolation] iframes draw with an incorrect size after a same-origin 
navigation
https://bugs.webkit.org/show_bug.cgi?id=272808
rdar://126605535

Reviewed by Matt Woodrow.

`LocalFrame::createView()` creates a LocalFrameView with the specified viewport 
size if the frame is a
root frame. If we are navigating within an iframe, we should use the size of 
the old frame view instead
of the page size.

* LayoutTests/platform/ios/TestExpectations:
* 
LayoutTests/http/tests/site-isolation/draw-with-size-after-same-origin-navigation-expected.html:
 Added.
* 
LayoutTests/http/tests/site-isolation/draw-with-size-after-same-origin-navigation.html:
 Added.
* LayoutTests/http/tests/site-isolation/resources/navigate-to-text.html: Added.
* LayoutTests/http/tests/site-isolation/resources/text.html: Added.
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::transitionToCommittedForNewPage):

Canonical link: https://commits.webkit.org/277686@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0e9d2d: http/tests/site-isolation/draw-after-navigation.ht...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e9d2d4b26842fc2c41aae84c8a1154724ebbd76
  
https://github.com/WebKit/WebKit/commit/0e9d2d4b26842fc2c41aae84c8a1154724ebbd76
  Author: Charlie Wolfe 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/http/tests/site-isolation/draw-after-navigation.html
M LayoutTests/http/tests/site-isolation/iframe-and-window-open.html
M LayoutTests/http/tests/site-isolation/resources/green-background.html

  Log Message:
  ---
  http/tests/site-isolation/draw-after-navigation.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=272853
rdar://126644250

Reviewed by Sihui Liu.

The test should not complete until the iframe navigation has completed.

* LayoutTests/http/tests/site-isolation/draw-after-navigation.html:
* LayoutTests/http/tests/site-isolation/iframe-and-window-open.html:
* LayoutTests/http/tests/site-isolation/resources/green-background.html:

Canonical link: https://commits.webkit.org/277685@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dfe10e: NEW TEST(277656@main): [ MacOS ] TestWebKitAPI.Uni...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dfe10e0b9b0dc81eb4edb73f7da8992e767bbc43
  
https://github.com/WebKit/WebKit/commit/dfe10e0b9b0dc81eb4edb73f7da8992e767bbc43
  Author: Wenson Hsieh 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  ---
  NEW TEST(277656@main): [ MacOS ] 
TestWebKitAPI.UnifiedPDF.KeyboardScrollingInSinglePageMode is a consistent 
timeout
https://bugs.webkit.org/show_bug.cgi?id=272900
rdar://126695619

Reviewed by Abrar Rahman Protyasha.

Limit this test to run only when the unified PDF plugin is used by default.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:

Canonical link: https://commits.webkit.org/277684@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 118097: PDF Plugin should load its inline styles regardles...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 118097374f64baa854137fa9b507f83270ff4b67
  
https://github.com/WebKit/WebKit/commit/118097374f64baa854137fa9b507f83270ff4b67
  Author: Brandon Stewart 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
A LayoutTests/pdf/fullscreen-expected.txt
A LayoutTests/pdf/fullscreen.html
A LayoutTests/pdf/resources/fullscreen.pdf
A LayoutTests/platform/gtk/pdf/fullscreen-expected.txt
A LayoutTests/platform/ios/pdf/fullscreen-expected.txt
A LayoutTests/platform/mac-wk1/pdf/fullscreen-expected.txt
A LayoutTests/platform/wpe/pdf/fullscreen-expected.txt
M Source/WebCore/dom/InlineStyleSheetOwner.cpp

  Log Message:
  ---
  PDF Plugin should load its inline styles regardless of CSP
https://bugs.webkit.org/show_bug.cgi?id=272689
rdar://125796665

Reviewed by Alex Christensen.

We embed styles when rendering a pdf file that should not be ignored if CSP is 
activated (particularly around style sheets),
and will lead to a poor viewing experience for the user.

In addition, Anne pointed out that CSP is not defined for PDF documents, and 
thus we should ignore the checks.

* LayoutTests/pdf/fullscreen-expected.txt: Added.
* LayoutTests/pdf/fullscreen.html: Added.
* LayoutTests/pdf/resources/fullscreen.pdf: Added.
* LayoutTests/platform/gtk/pdf/fullscreen-expected.txt: Added.
* LayoutTests/platform/ios/pdf/fullscreen-expected.txt: Added.
* LayoutTests/platform/mac-wk1/pdf/fullscreen-expected.txt: Added.
* LayoutTests/platform/wpe/pdf/fullscreen-expected.txt: Added.
* Source/WebCore/dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet):

Canonical link: https://commits.webkit.org/277683@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e94277: Separate computation of InteractionRegions from us...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e94277b0b2f029b7c4ad98e8b9b2c0ec97c17bf8
  
https://github.com/WebKit/WebKit/commit/e94277b0b2f029b7c4ad98e8b9b2c0ec97c17bf8
  Author: Tim Horton 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm

  Log Message:
  ---
  Separate computation of InteractionRegions from using them for gaze 
highlighting
https://bugs.webkit.org/show_bug.cgi?id=272861
rdar://126651848

Reviewed by Wenson Hsieh and Abrar Rahman Protyasha.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
(WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
* 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm:
(WebKit::configureLayerAsGuard):
(WebKit::updateLayersForInteractionRegions):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:
(WebKit::RemoteLayerTreeNode::~RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::detachFromParent):
(WebKit::RemoteLayerTreeNode::initializeLayer):
Separate INTERACTION_REGIONS_IN_EVENT_REGION ("compute InteractionRegions") out
from GAZE_GLOW_FOR_INTERACTION_REGIONS (making visionOS gaze highlight layers
from InteractionRegions), so that they can be enabled separately in cases where
we might want to use InteractionRegions for other purposes.

Canonical link: https://commits.webkit.org/277682@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63355e: declarativeNetRequest redirect and modifyHeaders r...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63355e0745267f9891ebe07dc1f3aa96e59eb707
  
https://github.com/WebKit/WebKit/commit/63355e0745267f9891ebe07dc1f3aa96e59eb707
  Author: Timothy Hatcher 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm

  Log Message:
  ---
  declarativeNetRequest redirect and modifyHeaders rules don't work.
https://webkit.org/b/272763
rdar://problem/126562335

Reviewed by Brian Weinstein.

We were not setting activeContentRuleListActionPatterns() for the network 
process to check if the extension
had permissions to modify the requests, since the rules require 
declarativeNetRequestWithHostAccess and
granted host permission patterns.

* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): 
Added call to extension controller.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::resourceDataForPath): Add support for any JSON.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::updateWebsitePoliciesForNavigation): Added. 
Set activeContentRuleListActionPatterns
for each extension context that has declarativeNetRequestWithHostAccess 
permissions.
* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
* 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, 
DISABLED_RedirectRule)): Added. Blocked on fixing
rdar://116459903 (Web Process is crashing when using declarativeNetRequest to 
redirect a page).
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, 
RedirectRuleWithoutHostAccessPermission)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, 
RedirectRuleWithoutHostPermission)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, 
ModifyHeadersRule)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, 
ModifyHeadersRuleWithoutHostAccessPermission)): Added.
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, 
ModifyHeadersRuleWithoutHostPermission)): Added.

Canonical link: https://commits.webkit.org/277681@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c87f99: AX: AccessibilityMenuListOption should subclass Ac...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c87f99943fbeab08bccf1bb6b3efd601187989a8
  
https://github.com/WebKit/WebKit/commit/c87f99943fbeab08bccf1bb6b3efd601187989a8
  Author: Tyler Wilcock 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt
M Source/WebCore/accessibility/AccessibilityMenuListOption.cpp
M Source/WebCore/accessibility/AccessibilityMenuListOption.h

  Log Message:
  ---
  AX: AccessibilityMenuListOption should subclass AccessibilityNodeObject
https://bugs.webkit.org/show_bug.cgi?id=272840
rdar://126634909

Reviewed by Andres Gonzalez.

AccessibilityMenuListOption is a node object, and the fact that it doesn't 
subclass AccessibilityNodeObject
means it's missing important overrides like accessibilityText.

This fixes one subtest in WPT accname/name/comp_label.html, which failed 
because option elements didn't
respect aria-label.

* 
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt:
* Source/WebCore/accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
(WebCore::AccessibilityMenuListOption::optionElement const):
(WebCore::AccessibilityMenuListOption::actionElement const):
(WebCore::AccessibilityMenuListOption::isEnabled const):
(WebCore::AccessibilityMenuListOption::isVisible const):
(WebCore::AccessibilityMenuListOption::isSelected const):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::elementRect const):
(WebCore::AccessibilityMenuListOption::stringValue const):
(WebCore::AccessibilityMenuListOption::node const): Deleted.
* Source/WebCore/accessibility/AccessibilityMenuListOption.h:

Canonical link: https://commits.webkit.org/277680@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f3cac5: Optimize the computation of layout overflow

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3cac57896a33a50aae815d1c1947c6a45c9d3db
  
https://github.com/WebKit/WebKit/commit/f3cac57896a33a50aae815d1c1947c6a45c9d3db
  Author: Simon Fraser 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderBoxModelObjectInlines.h
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableCell.h
M Source/WebCore/rendering/RenderTableInlines.h

  Log Message:
  ---
  Optimize the computation of layout overflow
https://bugs.webkit.org/show_bug.cgi?id=272859


Reviewed by Alan Baradlay.

Computing layout overflow would call the 4 virtual border width functions
many times, so add a single virtual border widths getter to reduce that 
overhead.

Also `flippedClientBoxRect()` has non-trivial cost and would be computed each 
time
for the container, so compute that once and pass it into 
`addOverflowFromChild()`.

Finally check the `hasNonVisibleOverflow()` bit in a couple of places before
doing tests for various kinds of overflow.

* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::borderWidths const):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::layoutOverflowRectForPropagation const):
(WebCore::RenderBox::flippedClientBoxRect const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderBoxModelObjectInlines.h:
(WebCore::RenderBoxModelObject::borderWidths const):
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::borderWidths const):
* Source/WebCore/rendering/RenderTableCell.h:
* Source/WebCore/rendering/RenderTableInlines.h:
(WebCore::RenderTable::borderWidths const):

Canonical link: https://commits.webkit.org/277679@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 80048c: Do some more std::span adoption

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80048c7a5d58bf64d74980b482916878ae7610bc
  
https://github.com/WebKit/WebKit/commit/80048c7a5d58bf64d74980b482916878ae7610bc
  Author: Chris Dumez 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/API/JSStringRef.cpp
M Source/JavaScriptCore/yarr/YarrInterpreter.cpp
M Source/JavaScriptCore/yarr/YarrInterpreter.h
M Source/WTF/wtf/Assertions.cpp
M Source/WTF/wtf/text/StringView.cpp
M Source/WTF/wtf/unicode/icu/CollatorICU.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/html/MediaFragmentURIParser.cpp
M Source/WebCore/html/MediaFragmentURIParser.h

  Log Message:
  ---
  Do some more std::span adoption
https://bugs.webkit.org/show_bug.cgi?id=272881

Reviewed by Geoffrey Garen.

* Source/JavaScriptCore/API/JSStringRef.cpp:
(JSStringCreateWithUTF8CString):
* Source/JavaScriptCore/yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::InputStream):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::interpret):
* Source/JavaScriptCore/yarr/YarrInterpreter.h:
* Source/WTF/wtf/Assertions.cpp:
(WTF::createWithFormatAndArguments):
* Source/WTF/wtf/text/StringView.cpp:
(WTF::convertASCIICase):
(WTF::StringView::convertToASCIILowercase const):
(WTF::StringView::convertToASCIIUppercase const):
(WTF::convertASCIILowercaseAtom):
(WTF::StringView::convertToASCIILowercaseAtom const):
* Source/WTF/wtf/unicode/icu/CollatorICU.cpp:
(WTF::createLatin1Iterator):
(WTF::createIterator):
* Source/WebCore/dom/Document.cpp:
(WebCore::isValidNameASCIIWithoutColon):
(WebCore::Document::parseQualifiedName):
* Source/WebCore/html/MediaFragmentURIParser.cpp:
(WebCore::collectDigits):
(WebCore::collectFraction):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
(WebCore::MediaFragmentURIParser::parseNPTFragment):
(WebCore::MediaFragmentURIParser::parseNPTTime):
* Source/WebCore/html/MediaFragmentURIParser.h:

Canonical link: https://commits.webkit.org/277678@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 873f54: AX: aria-hidden=true should be ignored on the body...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 873f5404e7800fbfae3b984289a531cf74e30cc9
  
https://github.com/WebKit/WebKit/commit/873f5404e7800fbfae3b984289a531cf74e30cc9
  Author: Tyler Wilcock 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
A LayoutTests/accessibility/body-element-aria-hidden-expected.txt
A LayoutTests/accessibility/body-element-aria-hidden.html
A LayoutTests/accessibility/html-element-aria-hidden-expected.txt
A LayoutTests/accessibility/html-element-aria-hidden.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  ---
  AX: aria-hidden=true should be ignored on the body and html elements
https://bugs.webkit.org/show_bug.cgi?id=269523
rdar://123049663

Reviewed by Chris Fleizach.

To prevent authors from hiding all content from assistive technologies, 
aria-hidden should not be respected on document
root elements (`html`, `body`, or top-level `svg`s).

https://github.com/w3c/aria/pull/1880

* LayoutTests/accessibility/body-element-aria-hidden-expected.txt: Added.
* LayoutTests/accessibility/body-element-aria-hidden.html: Added.
* LayoutTests/accessibility/html-element-aria-hidden-expected.txt: Added.
* LayoutTests/accessibility/html-element-aria-hidden.html: Added.
* LayoutTests/platform/ios/TestExpectations: Enable new tests.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isARIAHidden const):
(WebCore::AccessibilityObject::tagName const):
(WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::attributes const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::tagName const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/277677@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 785688: [WebGPU] Clean up error message in RenderPassEncod...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7856880a2894b3a9593bdea3d44bb2bb7aa21d0c
  
https://github.com/WebKit/WebKit/commit/7856880a2894b3a9593bdea3d44bb2bb7aa21d0c
  Author: Mike Wyrzykowski 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] Clean up error message in 
RenderPassEncoder::addResourceToActiveResources
https://bugs.webkit.org/show_bug.cgi?id=272767


Reviewed by Tadeu Zagallo.

Printing an address in a validation error is not useful
from the JavaScript layer.

* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::addResourceToActiveResources):

Canonical link: https://commits.webkit.org/277676@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 72ef47: [WPE] Variable length array build warning

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72ef47e183a417a7e337b9b5b7d5ae448079f744
  
https://github.com/WebKit/WebKit/commit/72ef47e183a417a7e337b9b5b7d5ae448079f744
  Author: Philippe Normand 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp
M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp

  Log Message:
  ---
  [WPE] Variable length array build warning
https://bugs.webkit.org/show_bug.cgi?id=272830

Reviewed by Michael Catanzaro.

Variable-length arrays (VLAs) are supported in C (since the C99 standard). But 
not in the C++
standard. This is an extension of some compilers.

* Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp:
(WPE::DRM::Cursor::updateBuffer): Store the cursor pixels data in a Vector.
* Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp: Store the 
viewConfigurations in a Vector.

Canonical link: https://commits.webkit.org/277675@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 49912e: run-webkit-tests logs misleading warnings about sk...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 49912e9ab15c35e021ed52ab695097aa03da9619
  
https://github.com/WebKit/WebKit/commit/49912e9ab15c35e021ed52ab695097aa03da9619
  Author: Sam Sneddon 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Tools/Scripts/webkitpy/port/base.py

  Log Message:
  ---
  run-webkit-tests logs misleading warnings about skipped tests not existing
https://bugs.webkit.org/show_bug.cgi?id=272766
rdar://104513242

Reviewed by Jonathan Bedard.

When skipping tests for other platforms, we add the relevant directories
as skipped expectations to TestExpectations. However, if these
directories are outside of the LayoutTests directory then we incorrectly
pass these to TestExpectations as bogus paths.

* Tools/Scripts/webkitpy/port/base.py:
(Port._tests_for_other_platforms):

Canonical link: https://commits.webkit.org/277674@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b70287: [import-w3c-tests] Make TestParser use the WPT Sou...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b70287103be9d7a826cb2697e7a951536dc2a04b
  
https://github.com/WebKit/WebKit/commit/b70287103be9d7a826cb2697e7a951536dc2a04b
  Author: Sam Sneddon 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
M 
Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner_unittest.py
A Tools/Scripts/webkitpy/thirdparty/wpt/LICENSE.md
A Tools/Scripts/webkitpy/thirdparty/wpt/__init__.py
A Tools/Scripts/webkitpy/thirdparty/wpt/gitignore/__init__.py
A Tools/Scripts/webkitpy/thirdparty/wpt/gitignore/gitignore.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/XMLParser.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/__init__.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/catalog/xhtml.dtd
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/download.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/item.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/jsonlib.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/log.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/manifest.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/sourcefile.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/testpaths.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/typedata.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/update.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/utils.py
A Tools/Scripts/webkitpy/thirdparty/wpt/manifest/vcs.py
M Tools/Scripts/webkitpy/w3c/test_parser.py
M Tools/Scripts/webkitpy/w3c/test_parser_unittest.py

  Log Message:
  ---
  [import-w3c-tests] Make TestParser use the WPT SourceFile
https://bugs.webkit.org/show_bug.cgi?id=263673

Reviewed by Jonathan Bedard.

Rather than reimplementing all this logic ourselves, we should just use
the upstream WPT code to classify files. This does vendor a new
(partial) copy (from upstream f54724aafa), to pull in the last version
of the WPT tools prior to them dropping Python 2 support.

This vastly reduces the amount of logic webkitpy.w3c.test_parser has in
it, though we maintain our own copy of fuzzy_metadata (now directly in
webkitpy.layout_tests.controllers.single_test_runner), given we need
different semantics when running tests (specifically: we want it to find
fuzzy data for tests WPT doesn't believe are reftests).

* Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._fuzzy_metadata_for_file):
(SingleTestRunner._fuzzy_tolerance_for_reference):
* 
Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner_unittest.py:
(SingleTestRunnerTest):
(test_nameless_fuzzy_data):
(test_range_fuzzy_data):
(test_nameless_range_fuzzy_data):
(test_per_ref_fuzzy_data):
* Tools/Scripts/webkitpy/thirdparty/wpt: Added, from upstream f54724aafa.

Canonical link: https://commits.webkit.org/277673@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9487ec: AX: Use more reference types in accessibility code...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9487ec0b9ebd8a3fd3fb49ce40abde34b2246ff2
  
https://github.com/WebKit/WebKit/commit/9487ec0b9ebd8a3fd3fb49ce40abde34b2246ff2
  Author: Tyler Wilcock 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXLogger.h
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/accessibility/AccessibilityTree.cpp
M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
M Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp
M Source/WebCore/accessibility/win/AXObjectCacheWin.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/ElementInternals.cpp
M Source/WebCore/html/ColorInputType.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLOptionElement.cpp
M Source/WebCore/html/HTMLProgressElement.cpp
M Source/WebCore/html/HTMLTextAreaElement.cpp
M Source/WebCore/html/InputType.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/rendering/RenderWidget.cpp

  Log Message:
  ---
  AX: Use more reference types in accessibility code when values are known to 
be non-null
https://bugs.webkit.org/show_bug.cgi?id=272279
rdar://problem/126020262

Reviewed by Chris Fleizach.

This reduces unnecessary null checks and allows us to remove ASSERT(value) and 
unchecked dereferences.

* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::AXLogger::log):
* Source/WebCore/accessibility/AXLogger.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::rendererIsValid):
(WebCore::nodeAndRendererAreValid):
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedObjectForNode):
(WebCore::AXObjectCache::cacheAndInitializeWrapper):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::create):
(WebCore::AXObjectCache::getAXID):
(WebCore::AXObjectCache::handleTextChanged):
(WebCore::AXObjectCache::handleAllDeferredChildrenChanged):
(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::AXObjectCache::handleMenuOpened):
(WebCore::AXObjectCache::handleLiveRegionCreated):
(WebCore::AXObjectCache::deferNodeAddedOrRemoved):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::valueChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::passwordNotificationPostTimerFired):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::autofillTypeChanged):
(WebCore::AXObjectCache::deferModalChange):
(WebCore::AXObjectCache::onSelectedChanged):
(WebCore::isSecureFieldOrContainedBySecureField):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):
(WebCore::AXObjectCache::postTextReplacementNotificationForTextControl):
(WebCore::AXObjectCache::enqueuePasswordValueChangeNotification):
(WebCore::AXObjectCache::postLiveRegionChangeNotification):
(WebCore::AXObjectCache::liveRegionChangedNotificationPostTimerFired):
(WebCore::AXObjectCache::onScrollbarUpdate):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleRoleChanged):
(WebCore::AXObjectCache::handleRoleDescriptionChanged):
(WebCore::AXObjectCache::deferAttributeChangeIfNeeded):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::characterOffsetForNodeAndOffset):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::AXObjectCache::nodeIsTextControl):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::updateIsolatedTree):
(WebCore::AXObjectCache::deferSelectedChildrenChangedIfNeeded):
(WebCore::AXObjectCache::onWidgetVisibilityChanged):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::rootEditableElementForPosition const):
(WebCore::AccessibilityRenderObject::nodeIsTextControl const):
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/AccessibilityTree.cpp:
(WebCore::AccessibilityTree::isTreeValid const):
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:

[webkit-changes] [WebKit/WebKit] fd47d1: [GTK] Implement printing using the Print portal

[Georges Basile Stavracas Neto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd47d132791d1978fac5b3c2e39ed36486f9a0a6
  
https://github.com/WebKit/WebKit/commit/fd47d132791d1978fac5b3c2e39ed36486f9a0a6
  Author: Georges Basile Stavracas Neto 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.h.in
M Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp

  Log Message:
  ---
  [GTK] Implement printing using the Print portal
https://bugs.webkit.org/show_bug.cgi?id=192748

Reviewed by Michael Catanzaro.

When running inside a sandboxed environment - which is fairly common
nowadays - printing is severely limited due to using the legacy GTK
print API (GtkPrintUnixDialog & family).

Due to WebKit's multi-process architecture, using the modern alternative,
GtkPrintOperation, is not really possible, because GtkPrintOperation has
the enconded assumption that the rendering of the document pages happens
in the same process as of printing.

Implement manual support for the Print portal. The portal has two well
defined steps:

 1. PreparePrint() is where WebKit sends the settings and page setup
that are stored in WebKitPrintOperation to the portal. The portal
presents a dialog to let users choose their print preferences. This
step returns WebKit a token, which is the "authentication" mechanism
for the next step.

 2. Print() takes a token, and a file descriptor pointing to the file
that will be send to the printer. The file descriptor can and often
does point to an in-memory buffer! In WebKit's case, it's a tmpfile.

This effectively means that webkit_print_operation_print(), which assumes
that step 1 can be skipped - cannot work under a sandbox. Deprecate this
function, and adjust the tests to ignore this deprecation, as the tests
should be adapted separately.

* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationFinished):
(webkitPrintOperationFailed):
(webkitPrintOperationPrintPagesForFrame):
(findFilePrinter):
(webkitPrintOperationSendPagesToPrintPortal):
(webkitPrintOperationPreparePrint):
(webkitPrintOperationRunPortalDialog):
(webkitPrintOperationRunDialogForFrame):
* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.h.in:
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
(testPrintOperationPrint):
(testPrintOperationErrors):

Canonical link: https://commits.webkit.org/277671@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b5ce79: [CSS Container Queries][Style queries] Incorrect d...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5ce791faf9e1635a2418f53d054dea2ddc8d442
  
https://github.com/WebKit/WebKit/commit/b5ce791faf9e1635a2418f53d054dea2ddc8d442
  Author: Antti Koivisto 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html
M Source/WebCore/css/query/ContainerQueryFeatures.cpp
M Source/WebCore/style/StyleBuilder.cpp

  Log Message:
  ---
  [CSS Container Queries][Style queries] Incorrect difference between implicit 
and explicit initial values for custom properties
https://bugs.webkit.org/show_bug.cgi?id=270739
rdar://124573975

Reviewed by Alan Baradlay.

Make sure guaranteed-invalid values match other guaranteed-invalid values 
whether explicitly (with `initial`) or implicitly specified.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html:
* Source/WebCore/css/query/ContainerQueryFeatures.cpp:

Test consistently for guaranteed-invalid values.

* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::resolveCustomPropertyForContainerQueries):

Return a nullptr only in failure cases (revert/revert-layer) and an invalid 
value otherwise.

Canonical link: https://commits.webkit.org/277670@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7f4f0e: [IFC] Do not invalidate LineLayout on style change...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f4f0e349bf4bfb0e47e75cfa1cd32209fe3eec4
  
https://github.com/WebKit/WebKit/commit/7f4f0e349bf4bfb0e47e75cfa1cd32209fe3eec4
  Author: Alan Baradlay 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M LayoutTests/fast/repaint/box-shadow-top-left-repaint-expected.txt
M LayoutTests/fast/repaint/focus-ring-repaint-expected.txt
M LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt
M LayoutTests/fast/repaint/overlapping-lines-with-ink-overflow-expected.txt
M LayoutTests/platform/ios/editing/style/table-selection-expected.txt
M LayoutTests/platform/mac/editing/style/table-selection-expected.txt
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h
M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  ---
  [IFC] Do not invalidate LineLayout on style change unless it completely stale
https://bugs.webkit.org/show_bug.cgi?id=272570

Reviewed by Antti Koivisto.

Instead of deleting the LineLayout object on style change, let's just 
invalidate the (inline item) cache when needed.

* LayoutTests/fast/repaint/focus-ring-repaint-expected.txt:
* LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt:
* LayoutTests/fast/repaint/overlapping-lines-with-ink-overflow-expected.txt:
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h:
* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::styleWillChange):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleDidChange):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):

Canonical link: https://commits.webkit.org/277669@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d32f1f: Move WTF::Markable to the modern serializer API

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d32f1f651c127cdd9ebc047062e3643d504ea37a
  
https://github.com/WebKit/WebKit/commit/d32f1f651c127cdd9ebc047062e3643d504ea37a
  Author: Claudio Saavedra 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WTF/wtf/Markable.h
M Source/WebKit/Platform/IPC/ArgumentCoders.h

  Log Message:
  ---
  Move WTF::Markable to the modern serializer API
https://bugs.webkit.org/show_bug.cgi?id=272818

Reviewed by Kimmo Kinnunen.

The WTF::Markable serializers are using the legacy API, so make it use instead
its own specialiation of ArgumentCoders. Move the implementation also to
ArgumentCoders.h, where other WTF types have theirs.

* Source/WTF/wtf/Markable.h:
(WTF::Traits>::encode const): Deleted.
(WTF::Traits>::decode): Deleted.
* Source/WebKit/Platform/IPC/ArgumentCoders.h:

Canonical link: https://commits.webkit.org/277668@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 348a2e: [Skia] Empty path should be applied when clipping

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 348a2e7bc0ec91c6949346a8d7281081a9eb6b3d
  
https://github.com/WebKit/WebKit/commit/348a2e7bc0ec91c6949346a8d7281081a9eb6b3d
  Author: Carlos Garcia Campos 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

  Log Message:
  ---
  [Skia] Empty path should be applied when clipping
https://bugs.webkit.org/show_bug.cgi?id=272893

Reviewed by Miguel Gomez.

It's ok to early return when stroking or filling, but not when clipping.
Fixes 
imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.clip.empty.html

* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::clipPath):

Canonical link: https://commits.webkit.org/277667@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 990e1a: [WGSL] Attribute validator asserts on non-overrides

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 990e1a76ed379729e2bf9eb827e029dcdf00a1d2
  
https://github.com/WebKit/WebKit/commit/990e1a76ed379729e2bf9eb827e029dcdf00a1d2
  Author: Tadeu Zagallo 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebGPU/WGSL/AttributeValidator.cpp
M Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl
M Source/WebGPU/WGSL/tests/invalid/division.wgsl

  Log Message:
  ---
  [WGSL] Attribute validator asserts on non-overrides
https://bugs.webkit.org/show_bug.cgi?id=272837
rdar://126621130

Reviewed by Mike Wyrzykowski.

In 277194@main I added an assertion that the store type of a variable with an 
@id
attribute must scalar, but that only holds if the variable is an override.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl:
* Source/WebGPU/WGSL/tests/invalid/division.wgsl:

Canonical link: https://commits.webkit.org/277666@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2459e1: [WGSL] Field access should support pointers

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2459e1442e9d4021cbbacdc9114a51136d7a7d57
  
https://github.com/WebKit/WebKit/commit/2459e1442e9d4021cbbacdc9114a51136d7a7d57
  Author: Tadeu Zagallo 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/MangleNames.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/tests/valid/access-expression.wgsl

  Log Message:
  ---
  [WGSL] Field access should support pointers
https://bugs.webkit.org/show_bug.cgi?id=272838
rdar://126621076

Reviewed by Mike Wyrzykowski.

The WGSL spec was updated to support struct field access on pointers (e.g. 
().y),
and while the type checker was updated to support it, there were a couple other
changes necessary:
- the renamer/mangler did not correctly rename the field when accessing a 
pointer
- the global rewriter asserted that the base should be either a reference or a 
struct
- the code generator was not emitting the correct code (i.e. x->y instead of 
x.y)

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::visit):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/tests/valid/access-expression.wgsl:

Canonical link: https://commits.webkit.org/277665@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b709d: [GTK][WPE] Add DRMDeviceManager to replace GBMDevice

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b709d7e78e85b3f1f8f4ccc21e4716fa9502925
  
https://github.com/WebKit/WebKit/commit/9b709d7e78e85b3f1f8f4ccc21e4716fa9502925
  Author: Carlos Garcia Campos 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/SourcesGTK.txt
M Source/WebCore/SourcesWPE.txt
M Source/WebCore/platform/TextureMapper.cmake
M Source/WebCore/platform/graphics/PlatformDisplay.cpp
A Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp
A Source/WebCore/platform/graphics/gbm/DRMDeviceManager.h
A Source/WebCore/platform/graphics/gbm/DRMDeviceNode.cpp
A Source/WebCore/platform/graphics/gbm/DRMDeviceNode.h
M Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp
R Source/WebCore/platform/graphics/gbm/GBMDevice.cpp
R Source/WebCore/platform/graphics/gbm/GBMDevice.h
M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp
M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp
M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp

  Log Message:
  ---
  [GTK][WPE] Add DRMDeviceManager to replace GBMDevice
https://bugs.webkit.org/show_bug.cgi?id=272886

Reviewed by Alejandro G. Castro.

GBMDevice assumes there's always a single GPU device, but linux dmabuf
feedback wayland protocol can give a different target device, so we need
a way to handle multiple devices.

* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/SourcesWPE.txt:
* Source/WebCore/platform/TextureMapper.cmake:
* Source/WebCore/platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::createPlatformDisplay):
(WebCore::PlatformDisplay::gbmDevice):
* Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp: Added.
(WebCore::DRMDeviceManager::singleton):
(WebCore::DRMDeviceManager::initializeMainDevice):
(WebCore::DRMDeviceManager::mainDeviceNode const):
(WebCore::DRMDeviceManager::mainGBMDeviceNode const):
(WebCore::DRMDeviceManager::deviceNode):
* Source/WebCore/platform/graphics/gbm/DRMDeviceManager.h: Added.
(WebCore::DRMDeviceManager::isInitialized const):
* Source/WebCore/platform/graphics/gbm/DRMDeviceNode.cpp: Added.
(WebCore::DRMDeviceNode::create):
(WebCore::DRMDeviceNode::DRMDeviceNode):
(WebCore::DRMDeviceNode::~DRMDeviceNode):
(WebCore::DRMDeviceNode::gbmDevice const):
* Source/WebCore/platform/graphics/gbm/DRMDeviceNode.h: Added.
(WebCore::DRMDeviceNode::filename const):
* Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp:
(WebCore::GBMBufferSwapchain::getBuffer):
* Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLGBM::platformInitializeContext):
* Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
(webKitDMABufVideoSinkIsEnabled):
* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):
* Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp:
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create):
* Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/277664@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3ef82a: Improvements to the ObjCObjectGraph decoder

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ef82afb51cba7366ed3882a8c24da37ba8031b7
  
https://github.com/WebKit/WebKit/commit/3ef82afb51cba7366ed3882a8c24da37ba8031b7
  Author: Claudio Saavedra 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/Shared/mac/ObjCObjectGraph.mm

  Log Message:
  ---
  Improvements to the ObjCObjectGraph decoder
https://bugs.webkit.org/show_bug.cgi?id=272890

Reviewed by Darin Adler.

Use the modern coder API instead of the legacy one
and a few minor simplifications.

* Source/WebKit/Shared/mac/ObjCObjectGraph.mm:
(WebKit::ObjCObjectGraph::decode):

Canonical link: https://commits.webkit.org/277663@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ab5d20: Incorrect Sec-Fetch-Site values on iframes

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab5d20c0ff1557bf6de443c88ffea5b0eb88b30f
  
https://github.com/WebKit/WebKit/commit/ab5d20c0ff1557bf6de443c88ffea5b0eb88b30f
  Author: Youenn Fablet 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
A LayoutTests/http/tests/navigation/sec-fetch-site-header-expected.txt
A 
LayoutTests/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt
A 
LayoutTests/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection.html
A 
LayoutTests/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt
A 
LayoutTests/http/tests/navigation/sec-fetch-site-header-on-redirection.html
A LayoutTests/http/tests/navigation/sec-fetch-site-header.html
A 
LayoutTests/http/tests/referrer-policy-anchor/no-referrer/sec-fetch-site-cross-origin-http-expected.txt
A 
LayoutTests/http/tests/referrer-policy-anchor/no-referrer/sec-fetch-site-cross-origin-http.html
A LayoutTests/http/tests/referrer-policy/resources/check-sec-fetch-site.py
M 
LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/generated/element-iframe.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/generated/element-iframe.sub.html
A 
LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-expected.txt
A 
LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt
A 
LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt
M Source/WebCore/loader/SubresourceLoader.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.h
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  Incorrect Sec-Fetch-Site values on iframes
rdar://109358563
https://bugs.webkit.org/show_bug.cgi?id=256472

Reviewed by Chris Dumez.

We use DocumentLoader::isRequestFromClientOrUserInput as a heuristic for 
directly user-initiated requests used in
the computation of Sec-Fetch-Site as per 
https://w3c.github.io/webappsec-fetch-metadata/#sec-fetch-site-header.
We remove the use of referrer since this is broken when referrer policy is 
no-referrer.
And we restrict to main frame navigation only.

In case of process swap, we could miscompute isRequestFromClientOrUserInput. We 
update WebPageProxy code to correctly compute 
LoadParameters.isRequestFromClientOrUserInput correctly.

Covered by tests.

* LayoutTests/http/tests/navigation/sec-fetch-site-header-expected.txt: Added.
* 
LayoutTests/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt:
 Added.
* 
LayoutTests/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection.html:
 Added.
* 
LayoutTests/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt:
 Added.
* LayoutTests/http/tests/navigation/sec-fetch-site-header-on-redirection.html: 
Added.
* LayoutTests/http/tests/navigation/sec-fetch-site-header.html: Added.
* 
LayoutTests/http/tests/referrer-policy-anchor/no-referrer/sec-fetch-site-cross-origin-http-expected.txt:
 Added.
* 
LayoutTests/http/tests/referrer-policy-anchor/no-referrer/sec-fetch-site-cross-origin-http.html:
 Added.
* LayoutTests/http/tests/referrer-policy/resources/check-sec-fetch-site.py: 
Added.
* 
LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/generated/element-iframe.sub-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fetch/metadata/generated/element-iframe.sub.html:
* 
LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-expected.txt:
 Added.
* 
LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt:
 Added.
* 
LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt:
 Added.
* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::willSendRequestInternal):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::computeFetchMetadataSite):
(WebCore::CachedResourceLoader::updateHTTPRequestHeaders):
* Source/WebCore/loader/cache/CachedResourceLoader.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadFile):

Canonical link: https://commits.webkit.org/277662@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7196d1: Use more smart pointers for dynamicDowncast<>in SV...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7196d1f760d62c84bcddef4c342d42398a9048bd
  
https://github.com/WebKit/WebKit/commit/7196d1f760d62c84bcddef4c342d42398a9048bd
  Author: Rob Buis 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp
M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp
M Source/WebCore/rendering/svg/SVGContainerLayout.cpp
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
M Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp
M Source/WebCore/rendering/svg/SVGTextQuery.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp
M 
Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp
M Source/WebCore/svg/SVGFEComponentTransferElement.cpp
M Source/WebCore/svg/SVGFontFaceSrcElement.cpp
M Source/WebCore/svg/SVGGraphicsElement.cpp

  Log Message:
  ---
  Use more smart pointers for dynamicDowncast<>in SVG code
https://bugs.webkit.org/show_bug.cgi?id=272817

Reviewed by Chris Dumez.

Use more smart pointers for dynamicDowncast<>in SVG code.

* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::findPreviousAndNextAttributes):
* Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::additionalContainerTranslation 
const):
* Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:
(WebCore::SVGBoundingBoxComputation::handleRootOrContainer const):
* Source/WebCore/rendering/svg/SVGContainerLayout.cpp:
(WebCore::SVGContainerLayout::layoutChildren):
(WebCore::SVGContainerLayout::positionChildrenRelativeToContainer):
* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore::updateObjectBoundingBox):
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
(WebCore::SVGRenderSupport::computeContainerStrokeBoundingBox):
(WebCore::layoutSizeOfNearestViewportChanged):
(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::isPointInCSSClippingArea):
(WebCore::SVGRenderSupport::clipContextToCSSClippingArea):
(WebCore::SVGRenderSupport::calculateApproximateStrokeBoundingBox):
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGPaintingFeatures):
(WebCore::writeResources):
* Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::walkTree):
* Source/WebCore/rendering/svg/SVGTextQuery.cpp:
(WebCore::flowBoxForRenderer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
(WebCore::getElementCTM):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp:
(WebCore::LegacyRenderSVGResourceClipper::pathOnlyClipping):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp:
(WebCore::LegacyRenderSVGTransformableContainer::calculateLocalTransform):
* Source/WebCore/svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::setFilterEffectAttributeFromChild):
* Source/WebCore/svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::createSrcValue const):
* Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::invalidateResourceImageBuffersIfNeeded):

Canonical link: https://commits.webkit.org/277661@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a61bf6: Change bundle ID for XPC services when WebKit proc...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a61bf60d8c9a97c903ebe3d10a9d9f0f9c8b204b
  
https://github.com/WebKit/WebKit/commit/a61bf60d8c9a97c903ebe3d10a9d9f0f9c8b204b
  Author: Per Arne Vollan 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/Configurations/GPUService.xcconfig
M Source/WebKit/Configurations/NetworkService.xcconfig
M Source/WebKit/Configurations/WebContentService.xcconfig

  Log Message:
  ---
  Change bundle ID for XPC services when WebKit process extensions are enabled
https://bugs.webkit.org/show_bug.cgi?id=272835
rdar://126632317

Reviewed by Chris Dumez and Elliott Williams.

We already do so when building for Simulator to avoid bundle ID conflicts, we 
should do it when
building for device too.

* Source/WebKit/Configurations/GPUService.xcconfig:
* Source/WebKit/Configurations/NetworkService.xcconfig:
* Source/WebKit/Configurations/WebContentService.xcconfig:

Canonical link: https://commits.webkit.org/277660@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9af3eb: [WPE][WebXR] Assertion fails `gl.checkFramebufferS...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9af3eb62b5fc62ee1ef8269b5fb9e323203571f5
  
https://github.com/WebKit/WebKit/commit/9af3eb62b5fc62ee1ef8269b5fb9e323203571f5
  Author: Vitaly Dyachkov 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/webxr/WebXRSession.cpp

  Log Message:
  ---
  [WPE][WebXR] Assertion fails `gl.checkFramebufferStatus(GL::FRAMEBUFFER) == 
GL::FRAMEBUFFER_COMPLETE` in `WebXROpaqueFramebuffer::blitShared()`
https://bugs.webkit.org/show_bug.cgi?id=272822

Reviewed by Mike Wyrzykowski.

The WebXR session may end in the middle of the frame.
In this case, we should discard the frame because graphics resources
acquired by the session could already be deallocated.

* Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::onFrame):

Canonical link: https://commits.webkit.org/277659@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 80f174: [JSC] Micro-optimize DFG MakeRope

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80f174e8994a4e72408fd5a2c3021b8b209c0486
  
https://github.com/WebKit/WebKit/commit/80f174e8994a4e72408fd5a2c3021b8b209c0486
  Author: Yusuke Suzuki 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/assembler/MacroAssembler.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

  Log Message:
  ---
  [JSC] Micro-optimize DFG MakeRope
https://bugs.webkit.org/show_bug.cgi?id=272877
rdar://problem/126661212

Reviewed by Justin Michaud.

Micro-optimize DFG MakeRope assembly by leveraging ARM64's instructions.

* Source/JavaScriptCore/assembler/MacroAssembler.h:
(JSC::MacroAssembler::lshiftPtr):
(JSC::MacroAssembler::rshiftPtr):
(JSC::MacroAssembler::urshiftPtr):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:

Canonical link: https://commits.webkit.org/277658@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ffd37b: [GStreamer] Disable the gst-libav aac decoder

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffd37b17042513ad1509a92196be383284feb353
  
https://github.com/WebKit/WebKit/commit/ffd37b17042513ad1509a92196be383284feb353
  Author: Philippe Normand 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

  Log Message:
  ---
  [GStreamer] Disable the gst-libav aac decoder
https://bugs.webkit.org/show_bug.cgi?id=272819

Reviewed by Xabier Rodriguez-Calvar.

Unconditionally disable the libav aac decoder, due to bad user experience. 
Distributors are advised
to recommend the FDK decoder instead.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):

Canonical link: https://commits.webkit.org/277657@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b32dad: [Unified PDF] [macOS] Can't use the arrow keys to ...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b32dad0669e5ac9124d50dfe8036704e0f6c6aea
  
https://github.com/WebKit/WebKit/commit/b32dad0669e5ac9124d50dfe8036704e0f6c6aea
  Author: Wenson Hsieh 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/KeyboardScrollingAnimator.h
M Source/WebCore/platform/ScrollAnimator.h
M Source/WebCore/plugins/PluginViewBase.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebRequest.mm
A Tools/TestWebKitAPI/Tests/WebKitCocoa/multiple-pages.pdf
M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

  Log Message:
  ---
  [Unified PDF] [macOS] Can't use the arrow keys to navigate between pages in 
Single page mode
https://bugs.webkit.org/show_bug.cgi?id=272828
rdar://123193004

Reviewed by Abrar Protyasha.

Implement keyboard scrolling when viewing PDFs in Single Page mode. The 
behavior (mostly) matches
that in prior macOS versions, but with the added nicety that keyboard scrolling 
is now smoothly
animated (rather than discrete).

Test: UnifiedPDF.KeyboardScrollingInSinglePageMode

* Source/WebCore/platform/KeyboardScrollingAnimator.h:
* Source/WebCore/platform/ScrollAnimator.h:

`WEBCORE_EXPORT` several helper methods, so we can use them to service keyboard 
scrolling in
`UnifiedPDFPlugin`.

* Source/WebCore/plugins/PluginViewBase.h:
(WebCore::PluginViewBase::setPDFDisplayModeForTesting):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setPDFDisplayModeForTesting const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Add an `internals` testing hook to set the current PDF display mode. The 
arguments are strings that
match the internal `enum class` names:

```
SinglePageDiscrete
SinglePageContinuous
TwoUpDiscrete
TwoUpContinuous
```

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::annotationRectsForTesting const):
(WebKit::PDFPluginBase::setPDFDisplayModeForTesting):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::didChangeScrollOffset):

See comments in `handleKeyboardEventForDiscreteDisplayMode` below.

(WebKit::UnifiedPDFPlugin::isInDiscreteDisplayMode const):

Rename this to `isInDiscreteDisplayMode`, since it's now used to guard keyboard 
scrolling behaviors
that are specific to discrete display modes (both two-up and single).

(WebKit::UnifiedPDFPlugin::isShowingTwoPages const):

Add a helper method that returns whether or not we're in two-up mode. 
Currently, only used in a
couple places to determine the offset of the next set of pages when scrolling 
with arrow keys, if
the page is (/pages are) shorter than the viewport.

(WebKit::UnifiedPDFPlugin::pageBoundsInContentsSpace const):

Pull this out into a helper method, so we can use it from multiple places.

(WebKit::UnifiedPDFPlugin::updateSnapOffsets):

Make a slight adjustment here to snap to the *closest* snap offset rather than 
the first offset past
the current scroll position. This ensures that the `m_currentlySnappedPage` 
doesn't prematurely jump
to the previous page in `handleKeyboardEventForDiscreteDisplayMode` when 
determining whether we're
near a snap point.

(WebKit::UnifiedPDFPlugin::determineCurrentlySnappedPage):
(WebKit::UnifiedPDFPlugin::shouldDisplayPage):
(WebKit::UnifiedPDFPlugin::checkedKeyboardScrollingAnimator const):
(WebKit::UnifiedPDFPlugin::handleKeyboardCommand):

Factor this out into a separate method to make the code easier to follow.

(WebKit::UnifiedPDFPlugin::handleKeyboardEventForDiscreteDisplayMode):

Implement the main keyboard scrolling logic here — if the page is shorter than 
the viewport, we want
to instantly jump to the next or previous page (or set of 2 pages). If the page 
is taller than the
viewport (e.g. when zooming within a page in Single Page mode), we want to 
allow the user to scroll
within the page, and clamp scrolling to the edges of the page.

To achieve this, we detect when the user is about to scroll near either the top 
or bottom page
extent — in this case, we:

1. Stop animated 

[webkit-changes] [WebKit/WebKit] 57b120: REGRESSION [ iOS ] 5X TestWebKitAPI.CopyRTF.Strips...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57b120b52e9486103826c045c2538ab4d1067d63
  
https://github.com/WebKit/WebKit/commit/57b120b52e9486103826c045c2538ab4d1067d63
  Author: Ryosuke Niwa 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm

  Log Message:
  ---
  REGRESSION [ iOS ] 5X TestWebKitAPI.CopyRTF.Strips are crashing and failing
https://bugs.webkit.org/show_bug.cgi?id=272239

Reviewed by Wenson Hsieh.

The test failures are caused because nsattributedstringagent which gets 
launched by TestWebKitAPI
loads locally built WebKit but then launched WebContent process, networking 
process, etc... without
setting `__XPC_DYLD_FRAMEWORK_PATH` and `__XPC_DYLD_LIBRARY_PATH`.

Fix the tests by enabling WriteRichTextDataWhenCopyingOrDragging to trigger the 
legacy behavior.

* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWriteRichTextDataWhenCopyingOrDragging):
(WKPreferencesGetWriteRichTextDataWhenCopyingOrDragging):
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
(copyAttributedStringFromHTML):

Canonical link: https://commits.webkit.org/277655@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 106c6c: The contents layer of placeholder canvas of Offscr...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 106c6c814493351a5bf25497d24eebb60ad61478
  
https://github.com/WebKit/WebKit/commit/106c6c814493351a5bf25497d24eebb60ad61478
  Author: Kimmo Kinnunen 
  Date:   2024-04-17 (Wed, 17 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/canvas/offscreen-nested-worker-serialization.html
A LayoutTests/fast/canvas/offscreen-visibility-change-expected.html
A LayoutTests/fast/canvas/offscreen-visibility-change.html
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h

  Log Message:
  ---
  The contents layer of placeholder canvas of OffscreenCanvas is lost when 
switching off the tab
https://bugs.webkit.org/show_bug.cgi?id=272322
rdar://126070648

Reviewed by Matt Woodrow.

When layer becomes unreachable, its contents is cleared. Clear also
the async contents id. When the layer becomes reachable, the content
can be reassigned.

* LayoutTests/TestExpectations:
* LayoutTests/fast/canvas/offscreen-visibility-change-expected.html: Added.
* LayoutTests/fast/canvas/offscreen-visibility-change.html: Added.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
(WebKit::RemoteLayerTreeNode::setAsyncContentsIdentifier):

Canonical link: https://commits.webkit.org/277654@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes