[webkit-changes] [WebKit/WebKit] e03a25: [Navigation] Set formData on NavigateEvent
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e03a2518eb73ce8bf82bf9870c96fdc1077f9444 https://github.com/WebKit/WebKit/commit/e03a2518eb73ce8bf82bf9870c96fdc1077f9444 Author: Patrick Griffis Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-reload-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-requestSubmit-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-traverse-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-userInitiated-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-with-target-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/page/History.cpp M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Set formData on NavigateEvent https://bugs.webkit.org/show_bug.cgi?id=274561 Reviewed by Alex Christensen. This includes form data in all push/replace events on same-origin-domain form submissions. The two failing tests are passes except for the navigation type which is an unrelated issue. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-reload-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-requestSubmit-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-traverse-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-userInitiated-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-with-target-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::dispatchNavigateEvent): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/page/History.cpp: (WebCore::History::stateObjectAdded): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): (WebCore::Navigation::dispatchTraversalNavigateEvent): (WebCore::Navigation::dispatchPushReplaceReloadNavigateEvent): (WebCore::Navigation::dispatchDownloadNavigateEvent): * Source/WebCore/page/Navigation.h: Canonical link: https://commits.webkit.org/279257@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c1153: Unreviewed, fix GitHub CODEOWNERS for (Web) Inspec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c11534a42edf2485f10b2236d24b25901516a15 https://github.com/WebKit/WebKit/commit/8c11534a42edf2485f10b2236d24b25901516a15 Author: Devin Rousso Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M .github/CODEOWNERS Log Message: --- Unreviewed, fix GitHub CODEOWNERS for (Web) Inspector (sub)folders * .github/CODEOWNERS: Canonical link: https://commits.webkit.org/279256@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 74313d: [git-webkit] Add screen-reader friendly review wiz...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74313d0521aae7fbcd8c8a287b92f924f34ce34c https://github.com/WebKit/WebKit/commit/74313d0521aae7fbcd8c8a287b92f924f34ce34c Author: Jonathan Bedard Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/review.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/review_unittest.py Log Message: --- [git-webkit] Add screen-reader friendly review wizard (Part 2) https://bugs.webkit.org/show_bug.cgi?id=261242 rdar://115083100 Reviewed by Andres Gonzalez and Elliott Williams. Allow user to review and comment on a pull request by editing a local file. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/review.py: (Review.truncate_strs): Turn a nested dictionary of strings into a nested dictionary of lists of string based on where newline are in strings. (Review.user_delta): Detect which users have been added or removed from a list of users. (Review.invoke_wizard): Diff the original file with a user's local edits and return those local edits to be converted into actions on a pull request. (Review.main): Given the difference returned by invoke_wizard, programatically add comments, change pull request metadata and approve (or reject) the pull request. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/review_unittest.py: (TestReview.editor_callback): (TestReview.editor_callback.callback): (TestReview.test_truncate_strs): (TestReview.test_user_delta_github): (TestReview.test_user_delta_bitbucket): (TestReview.test_edit_metadata): (TestReview.test_comment_commit_message): (TestReview.test_comment): (TestReview.test_comment_reply): (TestReview.test_comment_reply_only_one): (TestReview.test_comment_reply_both): (TestReview.test_diff_file_comment): (TestReview.test_diff_inline_comment): (TestReview.test_github_read_comments): (TestReview.test_bitbucket_no_edit): (TestReview.test_github_no_edit): (TestReview.test_bitbucket_approve): (TestReview.test_github_deny): (TestReview.test_bitbucket_edit_deny): (TestReview.test_github_edit_approve): (TestReview.test_bitbucket_edit_refresh): (TestReview.test_github_edit_refresh): (TestReview.test_bitbucket_edit_comment): (TestReview.test_github_edit_comment): (TestReview.test_bitbucket_edit_comment_commit_message): (TestReview.test_github_edit_comment_commit_message): (TestReview.test_bitbucket_edit_comment_inline_diff): (TestReview.test_github_edit_comment_inline_diff): (TestReview.test_bitbucket_edit_title): (TestReview.test_github_edit_title): (TestReview.test_bitbucket_edit_open): (TestReview.test_github_edit_close): (TestReview.test_bitbucket_edit_merged_close): (TestReview.test_github_edit_merged_open): (TestReview.test_bitbucket_add_labels): (TestReview.test_github_edit_labels): (TestReview.test_github_edit_invalid_labels): Canonical link: https://commits.webkit.org/279255@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 351014: [Skia][Nicosia] Use a content layer for the canvas...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 351014754186c3c53d6374f48b24bf07cb007168 https://github.com/WebKit/WebKit/commit/351014754186c3c53d6374f48b24bf07cb007168 Author: Carlos Garcia Campos Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/compositing/canvas/accelerated-canvas-compositing-expected.txt M LayoutTests/platform/glib/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt A LayoutTests/platform/glib/compositing/layer-creation/compositing-policy-expected.txt M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/HTMLCanvasElement.h M Source/WebCore/html/canvas/CanvasRenderingContext.h M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h M Source/WebCore/platform/graphics/GraphicsLayerContentsDisplayDelegate.h M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/platform/graphics/ImageBufferBackend.h M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.h M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.h M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp Log Message: --- [Skia][Nicosia] Use a content layer for the canvas when accelerated https://bugs.webkit.org/show_bug.cgi?id=273873 Reviewed by Miguel Gomez. When canvas is accelerated we can pass the canvas texture to the compositor without having to render it into the layer. * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::shouldNotifyRendererOnDidDraw const): (WebCore::HTMLCanvasElement::didDraw): (WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer const): * Source/WebCore/html/HTMLCanvasElement.h: * Source/WebCore/html/canvas/CanvasRenderingContext.h: * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::layerContentsDisplayDelegate): * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h: * Source/WebCore/platform/graphics/GraphicsLayerContentsDisplayDelegate.h: * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::layerContentsDisplayDelegate): * Source/WebCore/platform/graphics/ImageBuffer.h: * Source/WebCore/platform/graphics/ImageBufferBackend.h: (WebCore::ImageBufferBackend::layerContentsDisplayDelegate const): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::ImageBufferSkiaAcceleratedBackend): (WebCore::ImageBufferSkiaAcceleratedBackend::~ImageBufferSkiaAcceleratedBackend): (WebCore::ImageBufferSkiaAcceleratedBackend::layerContentsDisplayDelegate const): (WebCore::ImageBufferSkiaAcceleratedBackend::swapBuffersIfNeeded): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.h: * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.h: * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp: (WebCore::TextureMapperPlatformLayerProxyGL::pushNextBuffer): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::canvasCompositingStrategy): Canonical link: https://commits.webkit.org/279254@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eeec86: [GTK] Deprecate WebKitWebContext:use-system-appear...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eeec86ec49d848faa827d880428392d20c1a0af0 https://github.com/WebKit/WebKit/commit/eeec86ec49d848faa827d880428392d20c1a0af0 Author: Carlos Garcia Campos Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in M Tools/MiniBrowser/gtk/main.c M Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h Log Message: --- [GTK] Deprecate WebKitWebContext:use-system-appearance-for-scrollbars property https://bugs.webkit.org/show_bug.cgi?id=274383 Reviewed by Michael Catanzaro. Rendering system scrollbars requires cairo, so it's impossible to support this with skia. * Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp: (webkit_web_context_class_init): * Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in: * Tools/MiniBrowser/gtk/main.c: (activate): * Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h: (Test::Test): Canonical link: https://commits.webkit.org/279253@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da1bf6: Fix remaining !ENABLE(VIDEO) build failures
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da1bf6c66583f650c3d5497eb6aa59107d75bfb6 https://github.com/WebKit/WebKit/commit/da1bf6c66583f650c3d5497eb6aa59107d75bfb6 Author: Daniel Kolesa Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUDevice.cpp M Source/WebCore/Modules/WebGPU/GPUDevice.h M Source/WebCore/page/InteractionRegion.cpp M Source/WebCore/platform/graphics/MediaResourceSniffer.cpp M Source/WebCore/platform/graphics/MediaResourceSniffer.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Fix remaining !ENABLE(VIDEO) build failures https://bugs.webkit.org/show_bug.cgi?id=273314 Reviewed by Don Olmstead. Recent refactorings introduced the breakages. They were fixed partially in ea2be408f27eb1009bbde7b0a2496018d4ca5e86 but not entirely. Notably, a misplacement of an #endif in WebCoreArgumentCoders resulted in strange IPC errors. * Source/WebCore/Modules/WebGPU/GPUDevice.cpp: * Source/WebCore/Modules/WebGPU/GPUDevice.h: * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): * Source/WebCore/platform/graphics/MediaResourceSniffer.cpp: * Source/WebCore/platform/graphics/MediaResourceSniffer.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::startObservingNowPlayingMetadata): (WebKit::WebPage::stopObservingNowPlayingMetadata): Canonical link: https://commits.webkit.org/279252@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a101a7: Drop some function overloads in Base64.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a101a7b4075a1abad19b13def372be7986031ddc https://github.com/WebKit/WebKit/commit/a101a7b4075a1abad19b13def372be7986031ddc Author: Chris Dumez Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WTF/wtf/text/Base64.h M Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp M Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm M Source/WebCore/fileapi/FileReaderLoader.cpp M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp M Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp M Source/WebCore/platform/network/CredentialBase.cpp M Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp M Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorClient.cpp M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp M Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp Log Message: --- Drop some function overloads in Base64.h https://bugs.webkit.org/show_bug.cgi?id=274556 Reviewed by Sihui Liu and Darin Adler. Drop some function overloads in Base64.h. This is a step towards std::span adoption and using more consistent typing for representing bytes. * Source/WTF/wtf/text/Base64.h: * Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp: (WebCore::isPlayReadySanitizedInitializationData): * Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm: (WebCore::findMasterKey): * Source/WebCore/fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::convertToDataURL): * Source/WebCore/inspector/agents/InspectorDOMAgent.cpp: (WebCore::computeContentSecurityPolicySHA256Hash): * Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: (WebCore::markupText): * Source/WebCore/platform/network/CredentialBase.cpp: (WebCore::CredentialBase::serializationForBasicAuthorizationHeader const): Canonical link: https://commits.webkit.org/279251@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d0efec: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0efecdd189fb11832f01fbd76307efe884ff1be https://github.com/WebKit/WebKit/commit/d0efecdd189fb11832f01fbd76307efe884ff1be Author: Fujii Hironori Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/279250@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4e487: [build.webkit.org] Bring up open source visionOS b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4e487b4319692a533e7b43a406530fda43c3018 https://github.com/WebKit/WebKit/commit/b4e487b4319692a533e7b43a406530fda43c3018 Author: Robert Jenner Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/CISupport/build-webkit-org/config.json M Tools/CISupport/build-webkit-org/factories.py M Tools/CISupport/build-webkit-org/factories_unittest.py M Tools/CISupport/build-webkit-org/loadConfig.py M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js M Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css M Tools/CISupport/build-webkit-org/steps.py M Tools/CISupport/build-webkit-org/wkbuild.py M Tools/CISupport/build-webkit-org/wkbuild_unittest.py Log Message: --- [build.webkit.org] Bring up open source visionOS builders and testers https://bugs.webkit.org/show_bug.cgi?id=274272 rdar://121395049 Reviewed by Ryan Haddad. Bring up of OpenSource visionOS builders and testers. * Tools/CISupport/build-webkit-org/config.json: * Tools/CISupport/build-webkit-org/factories.py: (TestFactory.__init__): * Tools/CISupport/build-webkit-org/factories_unittest.py: (TestExpectedBuildSteps): * Tools/CISupport/build-webkit-org/loadConfig.py: (loadBuilderConfig): * Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: * Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): * Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.visionos-simulator-1 img.logo): (table.queue-grid tr.platform.visionos-1 img.logo): * Tools/CISupport/build-webkit-org/steps.py: (CustomFlagsMixin.customBuildFlag): (CustomFlagsMixin.appendCustomBuildFlags): (CustomFlagsMixin.appendCustomTestingFlags): (CompileWebKit): (CompileWebKit.evaluateCommand): (PrintConfiguration.run): * Tools/CISupport/build-webkit-org/wkbuild.py: (_should_file_trigger_build): * Tools/CISupport/build-webkit-org/wkbuild_unittest.py: (ShouldBuildTest): (ShouldBuildTest.test_should_build): Canonical link: https://commits.webkit.org/279249@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f84f87: WebGPU] Destroyed buffers or textures only invalid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f84f875285ffcac10237f968c68929d843004cd5 https://github.com/WebKit/WebKit/commit/f84f875285ffcac10237f968c68929d843004cd5 Author: Mike Wyrzykowski Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebGPU/WebGPU/Buffer.h M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/ExternalTexture.h M Source/WebGPU/WebGPU/ExternalTexture.mm M Source/WebGPU/WebGPU/QuerySet.h M Source/WebGPU/WebGPU/QuerySet.mm M Source/WebGPU/WebGPU/Texture.h M Source/WebGPU/WebGPU/Texture.mm M Source/WebGPU/WebGPU/TextureView.h M Source/WebGPU/WebGPU/TextureView.mm Log Message: --- WebGPU] Destroyed buffers or textures only invalidate their most recent command buffer https://bugs.webkit.org/show_bug.cgi?id=274481> Reviewed by Dan Glastonbury. Destroying a buffer / texture should invalidate all the associated command encoders / buffers and not just the most recent one. * Source/WebGPU/WebGPU/Buffer.h: * Source/WebGPU/WebGPU/Buffer.mm: (WebGPU::Buffer::incrementBufferMapCount): (WebGPU::Buffer::decrementBufferMapCount): (WebGPU::Buffer::setCommandEncoder const): (WebGPU::Buffer::destroy): (WebGPU::Buffer::mapAsync): (WebGPU::Buffer::unmap): * Source/WebGPU/WebGPU/ExternalTexture.h: * Source/WebGPU/WebGPU/ExternalTexture.mm: (WebGPU::ExternalTexture::destroy): (WebGPU::ExternalTexture::undestroy): (WebGPU::ExternalTexture::setCommandEncoder const): * Source/WebGPU/WebGPU/QuerySet.h: * Source/WebGPU/WebGPU/QuerySet.mm: (WebGPU::QuerySet::destroy): (WebGPU::QuerySet::setCommandEncoder const): * Source/WebGPU/WebGPU/Texture.h: * Source/WebGPU/WebGPU/Texture.mm: (WebGPU::Texture::waitForCommandBufferCompletion): (WebGPU::Texture::setCommandEncoder const): (WebGPU::Texture::destroy): * Source/WebGPU/WebGPU/TextureView.h: * Source/WebGPU/WebGPU/TextureView.mm: (WebGPU::TextureView::destroy): (WebGPU::TextureView::setCommandEncoder const): Canonical link: https://commits.webkit.org/279248@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c73216: Rename IGNORE_CLANG_19_STATIC_ANALYZER_WARNINGS_AT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c73216600cf8ca0aaaf81ca1340716a9b3f9e015 https://github.com/WebKit/WebKit/commit/c73216600cf8ca0aaaf81ca1340716a9b3f9e015 Author: Ryosuke Niwa Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WTF/wtf/Compiler.h Log Message: --- Rename IGNORE_CLANG_19_STATIC_ANALYZER_WARNINGS_ATTRIBUTE https://bugs.webkit.org/show_bug.cgi?id=274620 Reviewed by Yusuke Suzuki. Split IGNORE_CLANG_19_STATIC_ANALYZER_WARNINGS_ATTRIBUTE into more semantically named macros: IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE_ON_MEMBER IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE_ON_CLASS * Source/WTF/wtf/Compiler.h: Canonical link: https://commits.webkit.org/279247@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 467a1e: Remove duplicate `background-color`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 467a1e1b9822b39aa4a0a8d798f3156d4af8fc03 https://github.com/WebKit/WebKit/commit/467a1e1b9822b39aa4a0a8d798f3156d4af8fc03 Author: Frances Cornwall Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css Log Message: --- Remove duplicate `background-color` https://bugs.webkit.org/show_bug.cgi?id=274495 Reviewed by Devin Rousso. Remove duplicate background-color in GraphicsOverviewContentView.css. * Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css: (.content-view.graphics-overview): Canonical link: https://commits.webkit.org/279246@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe5976: Remove 'presentational hints' from `width` attribu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe5976c30783e180bab3de912da826c196d0b079 https://github.com/WebKit/WebKit/commit/fe5976c30783e180bab3de912da826c196d0b079 Author: Ahmad Saleem Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/rendering/dimension-attributes-expected.txt M Source/WebCore/html/HTMLHRElement.cpp Log Message: --- Remove 'presentational hints' from `width` attribute for `` https://bugs.webkit.org/show_bug.cgi?id=274605 Reviewed by Ryosuke Niwa. This patch aligns WebKit with Gecko / Firefox and web specification [1]: [1] https://html.spec.whatwg.org/#the-hr-element-2 "The width attribute on an hr element maps to the dimension property 'width' on the element." As per above, there should not be any presentational hints'. Hence, this patch removes them from WebKit's codebase. * Source/WebCore/html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::collectPresentationalHintsForAttribute): * LayoutTests/imported/w3c/web-platform-tests/html/rendering/dimension-attributes-expected.txt: Rebaseline Canonical link: https://commits.webkit.org/279245@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26ef08: [git-webkit] Add screen-reader friendly review wiz...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26ef083bdcb33ab3c78a317860a6fa1b3aa3a9a1 https://github.com/WebKit/WebKit/commit/26ef083bdcb33ab3c78a317860a6fa1b3aa3a9a1 Author: Jonathan Bedard Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py A Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/review.py A Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/review_unittest.py Log Message: --- [git-webkit] Add screen-reader friendly review wizard (Part 1) https://bugs.webkit.org/show_bug.cgi?id=261242 rdar://115083100 Reviewed by Elliott Williams. Add a read-only text-based PR review tool to git-webkit. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: (Git.__init__): Add an "editor" argument which allows a caller to define an editor callback which is invoke when the mock commit message editor is called during the testing context. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py: Add Review program. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/review.py: Added. (Review.parser): Define arguments for the sub-program. (Review.editor): Use a repository object to determine the user's prefered editor, matching the editor used to edit commit messages. (Review.args_for_url): Extract PR number and repository object from a URL, allowing a user to specify a PR URL instead of a number and remote. (Review.invoke_wizard): Generate a local file representing a PR, which includes the PR diff and comments made against that diff. Open that local file in the user's prefered editor. (Review.main): Extract a remote pull-request from the provided arguments and invoke the local wizard with the pull-request details. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/review_unittest.py: Added. (TestReview): (TestReview.editor_callback): (TestReview.editor_callback.callback): (TestReview.test_bitbucket): (TestReview.test_bitbucket_diff): (TestReview.test_github): (TestReview.test_github_files): (TestReview.test_invalid_pr_url): (TestReview.test_pr_argument): (TestReview.test_editor_no_repo): (TestReview.test_editor_repo): (TestReview.test_invoke_wizard): (TestReview.test_help): (TestReview.test_bitbucket_read): (TestReview.test_github_read): (TestReview.test_bitbucket_read_comments): (TestReview.test_github_read_comments): Canonical link: https://commits.webkit.org/279244@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f11dd8: [WebGPU] Invalidate all command buffers on submit, ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f11dd80a74edc846021df19b7cfa806b7ddd95fe https://github.com/WebKit/WebKit/commit/f11dd80a74edc846021df19b7cfa806b7ddd95fe Author: Mike Wyrzykowski Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebGPU/WebGPU/Queue.mm Log Message: --- [WebGPU] Invalidate all command buffers on submit, regardless of it the submit call succeeds https://bugs.webkit.org/show_bug.cgi?id=274244> Reviewed by Dan Glastonbury. Invalidate all command buffers passed to GPUQueue.submit, regardless of whether or not they get committed. Fixes the test being added in gpuweb/cts#3716 Reland with regression fixed and test enabled. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::invalidateCommandBuffers): (WebGPU::Queue::submit): Canonical link: https://commits.webkit.org/279243@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc5bcf: [JSC] Inlined functions in OMG may have exception ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc5bcf116eef81d7f61706d5e157e921461757ee https://github.com/WebKit/WebKit/commit/bc5bcf116eef81d7f61706d5e157e921461757ee Author: David Degazio Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A JSTests/wasm/stress/inlinee-may-have-exception-handlers.js A JSTests/wasm/stress/rethrow-should-set-callsite-index.js A JSTests/wasm/stress/throw-should-set-callsite-index.js M Source/JavaScriptCore/wasm/WasmCompilationContext.h M Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.h M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp Log Message: --- [JSC] Inlined functions in OMG may have exception handlers https://bugs.webkit.org/show_bug.cgi?id=272106 rdar://125181187 Reviewed by Justin Michaud and Yusuke Suzuki. Primarily fixes a bug where any WebAssembly function inlined in OMG was assumed to not have exception handlers. We now propagate a reference to the Wasm::CalleeGroup from the OMGPlan/OSREntryPlan to the B3IRGenerator, and read the hasExceptionHandlers() property from the inlined function's callee, similar to how the top-level function's generator is initialized in the plan. In addition to this, we also change when we set the callsite index. Currently we don't set the callsite index for any call or throw outside of a try block, which means that we might throw with an old callsite index set, and erroneously catch the exception in a previous block. To fix this, we now set a bool in the IR generator after a try or catch block ends, and set the callsite index for the first call/throw after a try/catch ends. Finally, consistent with BBQ, we don't write invalid callsite indices except for during the function prologue (before our first call/throw). We also don't write the callsite index at all in the case that we are known to be in a function without exception handlers. * JSTests/wasm/stress/inlinee-may-have-exception-handlers.js: Added. (async test): * JSTests/wasm/stress/rethrow-should-set-callsite-index.js: Added. (async test): * JSTests/wasm/stress/throw-should-set-callsite-index.js: Added. (async test): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::shouldSetCallSiteIndexAfterTry const): (JSC::Wasm::B3IRGenerator::didSetCallSiteIndexAfterTry): (JSC::Wasm::B3IRGenerator::B3IRGenerator): (JSC::Wasm::B3IRGenerator::preparePatchpointForExceptions): (JSC::Wasm::B3IRGenerator::addThrow): (JSC::Wasm::B3IRGenerator::addRethrow): (JSC::Wasm::B3IRGenerator::addEndToUnreachable): (JSC::Wasm::B3IRGenerator::emitInlineDirectCall): (JSC::Wasm::parseAndCompileB3): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.h: * Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h: (JSC::Wasm::PatchpointExceptionHandle::PatchpointExceptionHandle): (JSC::Wasm::PatchpointExceptionHandle::generate const): * Source/JavaScriptCore/wasm/WasmOMGPlan.cpp: (JSC::Wasm::OMGPlan::work): * Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp: (JSC::Wasm::OSREntryPlan::work): Originally-landed-as: 272448.917@safari-7618-branch (1e58c9386ed9). rdar://128572165 Canonical link: https://commits.webkit.org/279242@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fbc7aa: [ Ventura WK1 Release ] 3x media/track/track and h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fbc7aaa375daf44ac8bf9bfb39c7b6b0e7013c41 https://github.com/WebKit/WebKit/commit/fbc7aaa375daf44ac8bf9bfb39c7b6b0e7013c41 Author: Jay Stfleur Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-ventura-wk1/TestExpectations Log Message: --- [ Ventura WK1 Release ] 3x media/track/track and http/tests/media/hls/hls-webvtt-flashing.html are constant timeout https://bugs.webkit.org/show_bug.cgi?id=271916 rdar://125631803 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-ventura-wk1/TestExpectations: Canonical link: https://commits.webkit.org/279241@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a94f0: REGRESSION (268367@main): [ iOS ] imported/w3c/web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a94f0965f79bfbeee1e258b875979e6a90773da https://github.com/WebKit/WebKit/commit/7a94f0965f79bfbeee1e258b875979e6a90773da Author: Jay Stfleur Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt Log Message: --- REGRESSION (268367@main): [ iOS ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=274245 rdar://128180039 Unreviewed test gardening. Editing rebaseline. * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Canonical link: https://commits.webkit.org/279240@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5914f6: [Writing Suggestions] Suggestions are sometimes ha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5914f6eb8b6de0cf2efbb9aa7b86f7358d47497b https://github.com/WebKit/WebKit/commit/5914f6eb8b6de0cf2efbb9aa7b86f7358d47497b Author: Richard Robinson Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/css3/color-filters/test-color-filter-with-color-mix-with-semantic-color-expected.html A LayoutTests/css3/color-filters/test-color-filter-with-color-mix-with-semantic-color.html M Source/WebCore/css/color/CSSColorMixResolver.cpp Log Message: --- [Writing Suggestions] Suggestions are sometimes hard to see in dark mode in Mail https://bugs.webkit.org/show_bug.cgi?id=274610 rdar://126371613 Reviewed by Abrar Rahman Protyasha and Matthieu Dubet. The color of writing suggestions is specified by ``` color: color-mix(in srgb, currentColor 50%, transparent); ``` which currently looks incorrect when viewed in dark mode in a place where `-apple-color-filter` is used (such as Mail). This is because the unique combination of `-apple-color-filter` with a color that is created using `color-mix`, which itself comprises of a color which is a semantic color, has not been explicitly supported. In general, semantic colors are immune from `-apple-color-filter` due to the early return check of `isSemantic` in `FilterOperations::transformColor`. However, if a semantic color is inside of a `color-mix` value, the `color-mix` color doesn't persist the semantic flag, which results in the filter operation erroneously applying. Fix by considering a `color-mix` color semantic if either of its constituent colors are semantic. * LayoutTests/css3/color-filters/test-color-filter-with-color-mix-with-semantic-color-expected.html: Added. * LayoutTests/css3/color-filters/test-color-filter-with-color-mix-with-semantic-color.html: Added. * Source/WebCore/css/color/CSSColorMixResolver.cpp: (WebCore::mixColorComponentsUsingColorInterpolationMethod): Canonical link: https://commits.webkit.org/279239@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 907638: Cleaning tests expectation for stale tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90763848028369a3d4adae7f44e2cb5326af674b https://github.com/WebKit/WebKit/commit/90763848028369a3d4adae7f44e2cb5326af674b Author: Jay Stfleur Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Cleaning tests expectation for stale tests https://bugs.webkit.org/show_bug.cgi?id=274594 rdar://128622984 Unreviewed test gardening. Editing test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/279238@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 71dc79: Add more smart pointers to Geolocation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71dc7942508f80337321012ad3249b0af2949fd1 https://github.com/WebKit/WebKit/commit/71dc7942508f80337321012ad3249b0af2949fd1 Author: Abigail Fox Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/Modules/geolocation/Geolocation.cpp M Source/WebCore/Modules/geolocation/Geolocation.h Log Message: --- Add more smart pointers to Geolocation https://bugs.webkit.org/show_bug.cgi?id=274489 rdar://128497803 Reviewed by Ryosuke Niwa. * Source/WebCore/Modules/geolocation/Geolocation.cpp: (WebCore::Geolocation::page const): (WebCore::Geolocation::resumeTimerFired): (WebCore::Geolocation::resetAllGeolocationPermission): (WebCore::Geolocation::stop): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::shouldBlockGeolocationRequests): * Source/WebCore/Modules/geolocation/Geolocation.h: Canonical link: https://commits.webkit.org/279237@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] feed08: Unreviewed, reverting 279233@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: feed08880c7bcecf83f5468e3fa0e6b76021cb9c https://github.com/WebKit/WebKit/commit/feed08880c7bcecf83f5468e3fa0e6b76021cb9c Author: Commit Queue Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WTF/wtf/Compiler.h Log Message: --- Unreviewed, reverting 279233@main. https://bugs.webkit.org/show_bug.cgi?id=274616 This is redundant Reverted changeset: "Fixed Playstation build break after 279061@main" https://bugs.webkit.org/show_bug.cgi?id=274601 https://commits.webkit.org/279233@main Canonical link: https://commits.webkit.org/279236@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63a45f: Remove more X86 JIT related remainings
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63a45fee32313c51952944d390e0c42b057a64ce https://github.com/WebKit/WebKit/commit/63a45fee32313c51952944d390e0c42b057a64ce Author: Yusuke Suzuki Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/JavaScriptCore/CMakeLists.txt M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/assembler/MacroAssembler.h M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h M Source/JavaScriptCore/assembler/MaxFrameExtentForSlowPathCall.h M Source/JavaScriptCore/assembler/ProbeContext.h M Source/JavaScriptCore/assembler/RegisterInfo.h M Source/JavaScriptCore/assembler/X86Assembler.h R Source/JavaScriptCore/assembler/X86Registers.h M Source/JavaScriptCore/assembler/testmasm.cpp M Source/JavaScriptCore/b3/B3LowerToAir.cpp M Source/JavaScriptCore/b3/air/AirInstInlines.h M Source/JavaScriptCore/b3/air/testair.cpp M Source/JavaScriptCore/b3/testb3_3.cpp M Source/JavaScriptCore/bytecode/InlineAccess.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp M Source/JavaScriptCore/jit/CCallHelpers.cpp M Source/JavaScriptCore/jit/CallFrameShuffler.cpp M Source/JavaScriptCore/jit/FPRInfo.h M Source/JavaScriptCore/jit/GPRInfo.h M Source/JavaScriptCore/jit/RegisterSet.cpp M Source/JavaScriptCore/jit/ThunkGenerators.cpp M Source/JavaScriptCore/wasm/WasmBBQJIT.h Log Message: --- Remove more X86 JIT related remainings https://bugs.webkit.org/show_bug.cgi?id=274596 rdar://128623763 Reviewed by Mark Lam, Keith Miller and Yijia Huang. This patch further cleans up JIT code by removing remaining X86 JIT related things. We also remove small amount of CPU(MIPS) JIT remaining code. * Source/JavaScriptCore/assembler/MacroAssembler.h: (JSC::MacroAssembler::store32): * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp: (JSC::MacroAssembler::probe): (JSC::ctiMasmProbeTrampoline): Deleted. * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::store8): (JSC::MacroAssemblerX86Common::loadDouble): (JSC::MacroAssemblerX86Common::loadFloat): (JSC::MacroAssemblerX86Common::set32): * Source/JavaScriptCore/assembler/MaxFrameExtentForSlowPathCall.h: * Source/JavaScriptCore/assembler/ProbeContext.h: (JSC::Probe::CPUState::pc): (JSC::Probe::CPUState::fp): (JSC::Probe::CPUState::sp): * Source/JavaScriptCore/assembler/RegisterInfo.h: * Source/JavaScriptCore/assembler/X86Assembler.h: * Source/JavaScriptCore/assembler/testmasm.cpp: (JSC::testProbeModifiesStackPointer): (JSC::testProbeModifiesStackValues): * Source/JavaScriptCore/b3/B3LowerToAir.cpp: * Source/JavaScriptCore/b3/air/AirInstInlines.h: (JSC::B3::Air::Inst::shouldTryAliasingDef): (JSC::B3::Air::isShiftValid): (JSC::B3::Air::isX86DivHelperValid): (JSC::B3::Air::isAtomicStrongCASValid): (JSC::B3::Air::isBranchAtomicStrongCASValid): * Source/JavaScriptCore/b3/air/testair.cpp: * Source/JavaScriptCore/b3/testb3_3.cpp: (correctSqrt): * Source/JavaScriptCore/bytecode/InlineAccess.h: (JSC::InlineAccess::sizeForPropertyAccess): (JSC::InlineAccess::sizeForPropertyReplace): (JSC::InlineAccess::sizeForLengthAccess): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::regenerate): * Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp: (JSC::tryToDisassemble): * Source/JavaScriptCore/jit/FPRInfo.h: * Source/JavaScriptCore/jit/GPRInfo.h: * Source/JavaScriptCore/jit/RegisterSet.cpp: (JSC::RegisterSetBuilder::llintBaselineCalleeSaveRegisters): (JSC::RegisterSetBuilder::dfgCalleeSaveRegisters): * Source/JavaScriptCore/wasm/WasmBBQJIT.h: Canonical link: https://commits.webkit.org/279235@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e2747: Revert "[WebGPU] Invalidate all command buffers on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e27472b843be5f374935883526b94db64a521cf https://github.com/WebKit/WebKit/commit/4e27472b843be5f374935883526b94db64a521cf Author: Mike Wyrzykowski Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebGPU/WebGPU/Queue.mm Log Message: --- Revert "[WebGPU] Invalidate all command buffers on submit, regardless of it the submit call succeeds" Unreviewed revert due to regression in command buffer submission. This reverts commit 0752e9050165de7947d5aeb3c613755099311b25. Canonical link: https://commits.webkit.org/279234@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d67aa: Fixed Playstation build break after 279061@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d67aa3bb515edf3baaced47ed7136120d5be982 https://github.com/WebKit/WebKit/commit/1d67aa3bb515edf3baaced47ed7136120d5be982 Author: Jigen Zhou Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WTF/wtf/Compiler.h Log Message: --- Fixed Playstation build break after 279061@main https://bugs.webkit.org/show_bug.cgi?id=274601 Reviewed by Yusuke Suzuki. The support of suppress attribute on classes and member variables is in Clang 19 (https://clang.llvm.org/docs/AttributeReference.html), But for Clang 18, it may not be supported (https://releases.llvm.org/18.1.0/tools/clang/docs/AttributeReference.html) * Source/WTF/wtf/Compiler.h: Canonical link: https://commits.webkit.org/279233@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 50797a: [ews-build] Upload run-api-test logs to S3
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 50797abec0c2db27b2dafd9cbd7bbac7515edac6 https://github.com/WebKit/WebKit/commit/50797abec0c2db27b2dafd9cbd7bbac7515edac6 Author: Brianna Fan Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/CISupport/ews-build/factories.py M Tools/CISupport/ews-build/factories_unittest.py M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [ews-build] Upload run-api-test logs to S3 https://bugs.webkit.org/show_bug.cgi?id=270648 rdar://124223427 Reviewed by Aakash Jain. Pipes run-api-test logs into a text file and uploads full logs to S3. * Tools/CISupport/ews-build/factories.py: (TestFactory.__init__): Add SetBuildSummary step to API test factories. * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): * Tools/CISupport/ews-build/steps.py: (RunAPITests): (RunAPITests.run): (RunAPITests.analyze_failures_using_results_db): (RunAPITests.doOnFailure): * Tools/CISupport/ews-build/steps_unittest.py: Canonical link: https://commits.webkit.org/279232@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] def81c: Drop IPC::Encoder::buffer() / bufferSize()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: def81c6ee83a1512181c872a6a8434a4caaed17b https://github.com/WebKit/WebKit/commit/def81c6ee83a1512181c872a6a8434a4caaed17b Author: Chris Dumez Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebKit/Platform/IPC/Encoder.cpp M Source/WebKit/Platform/IPC/Encoder.h M Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp M Source/WebKit/Platform/IPC/unix/UnixMessage.h M Source/WebKit/Platform/IPC/win/ConnectionWin.cpp M Source/WebKit/Shared/Daemon/DaemonUtilities.mm M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp M Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm Log Message: --- Drop IPC::Encoder::buffer() / bufferSize() https://bugs.webkit.org/show_bug.cgi?id=274568 Reviewed by Darin Adler. Drop IPC::Encoder::buffer() / bufferSize(), in favor of span(). * Source/WebKit/Platform/IPC/Encoder.cpp: (IPC::Encoder::wrapForTesting): (IPC::Encoder::messageFlags): (IPC::Encoder::messageFlags const): * Source/WebKit/Platform/IPC/Encoder.h: * Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm: (IPC::Connection::sendOutgoingMessage): * Source/WebKit/Shared/Daemon/DaemonUtilities.mm: (WebKit::encoderToXPCData): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::shouldSendPendingMessage): * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::JSMessageListener::willSendMessage): * Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp: (TestWebKitAPI::ArgumentCoderEncoderDecoderTest::encoderSize const): (TestWebKitAPI::ArgumentCoderEncoderDecoderTest::createDecoder const): * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (SerializationTestSender::performSendWithAsyncReplyWithoutUsingIPCConnection const): * Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h: (TestWebKitAPI::copyViaEncoder): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: (TestWebKitAPI::WebPushXPCConnectionMessageSender::messageDictionaryFromEncoder const): Canonical link: https://commits.webkit.org/279231@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f64d31: [Navigation] Fix using wrong navigation type in ce...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f64d31c61cfe05eda0e2cf3a604425785b301693 https://github.com/WebKit/WebKit/commit/f64d31c61cfe05eda0e2cf3a604425785b301693 Author: Patrick Griffis Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-reload-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-meta-refresh-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h Log Message: --- [Navigation] Fix using wrong navigation type in certain cases https://bugs.webkit.org/show_bug.cgi?id=274560 Reviewed by Alex Christensen. Explicitly pass the type instead of relying on m_loadType. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-reload-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-meta-refresh-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::dispatchNavigateEvent): * Source/WebCore/loader/FrameLoader.h: Canonical link: https://commits.webkit.org/279230@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 43ae85: [GPU Process] Cache the Filter only if it has a va...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43ae8533abcdc3bc0551cdfc317458c03d2e9bae https://github.com/WebKit/WebKit/commit/43ae8533abcdc3bc0551cdfc317458c03d2e9bae Author: Mikhail R. Gadelha Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/send-filter-expected.txt A LayoutTests/ipc/send-filter.html M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp Log Message: --- [GPU Process] Cache the Filter only if it has a valid resource identifier https://bugs.webkit.org/show_bug.cgi?id=270324 rdar://122378065 Reviewed by Said Abou-Hallawa. Filter is a RenderingResource and it can be cached by DisplayList, however, every resource needs an identifier to be cached and a Filter can be created without an identifier. This patch prevents Filters without identifiers from being cached. * LayoutTests/TestExpectations: * LayoutTests/ipc/send-filter-expected.txt: Added. * LayoutTests/ipc/send-filter.html: Added. * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::cacheFilter): Originally-landed-as: 274097.15@webkit-2024.2-embargoed (977618344850). rdar://128555035 Canonical link: https://commits.webkit.org/279226@main Commit: f99d7c5195c4359543ab224fcee958054c0fe8d7 https://github.com/WebKit/WebKit/commit/f99d7c5195c4359543ab224fcee958054c0fe8d7 Author: Mikhail R. Gadelha Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/ipc/ui-send-empty-uuid-expected.txt A LayoutTests/ipc/ui-send-empty-uuid.html M Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm Log Message: --- Missing return when uuid is empty https://bugs.webkit.org/show_bug.cgi?id=270481 rdar://122379657 Reviewed by John Wilander. When sending a message to WebPageProxy_ModelElementLoadRemotePreview, the uuid cannot be empty. There is already a check for that but if an empty uuid is indeed sent, we never return the error. This patch adds the missing return. * LayoutTests/ipc/ui-send-empty-uuid-expected.txt: Added. * LayoutTests/ipc/ui-send-empty-uuid.html: Added. * Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm: (WebKit::ModelElementController::modelElementLoadRemotePreview): Originally-landed-as: 274097.13@webkit-2024.2-embargoed (8105acb3cedb). rdar://128555186 Canonical link: https://commits.webkit.org/279227@main Commit: 90e96164e02f963b67c605a228c0e5bf98b2df2d https://github.com/WebKit/WebKit/commit/90e96164e02f963b67c605a228c0e5bf98b2df2d Author: Mikhail R. Gadelha Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/send-gradient-expected.txt A LayoutTests/ipc/send-gradient.html M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/Platform/Logging.h Log Message: --- Always build a Gradient identifier to enable resource caching https://bugs.webkit.org/show_bug.cgi?id=270480 rdar://122181237 Reviewed by Said Abou-Hallawa. Gradient is a RenderingResource and it can be cached by DisplayList, however, every resource needs an identifier to be cached and a Gradient can be created withouth an identifier. This patch prevents Gradients without identifiers from being cached. * LayoutTests/TestExpectations: * LayoutTests/ipc/send-gradient-expected.txt: Added. * LayoutTests/ipc/send-gradient.html: Added. * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::cacheGradient): Originally-landed-as: 274097.14@webkit-2024.2-embargoed (0bfbed0e1d1a). rdar://128555359 Canonical link: https://commits.webkit.org/279228@main Commit: 49088ee12eea360c9d010a79635372547d095341 https://github.com/WebKit/WebKit/commit/49088ee12eea360c9d010a79635372547d095341 Author: Rob Buis Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/fast/css/repeating-radial-gradient-small-range-large-extent-expected.txt A LayoutTests/fast/css/repeating-radial-gradient-small-range-large-extent.html M Source/WebCore/rendering/style/StyleGradientImage.cpp Log Message: --- ASAN_TRAP | WTF::Vector::expandCapacity; WTF::Vector::expandCapacity; WTF::Vector::appendSlowCase https://bugs.webkit.org/show_bug.cgi?id=271904 rdar://125579928 Reviewed by Antti Koivisto. For https://bugs.webkit.org/show_bug.cgi?id=264639 a fix was done to deal with repeating gradients where a tiny offset range was repeated, causing a large number of items to be added to the stop vector. That fix does not apply when the offset range is reasonable but the maxExtent is large. So, also take the maxExtent into account when deciding whether to produce extra gradient stops. * LayoutTests/fast/css/repeating-radial-gradient-small-range-large-extent-expected.txt: Added. * LayoutTests/fast/css/repeating-radial-gradient-small-ra
[webkit-changes] [WebKit/WebKit] c31d9c: Trusted Types fails to protect against a script ed...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c31d9c40707d3ec58faee43f7446ac3fbd6c4531 https://github.com/WebKit/WebKit/commit/c31d9c40707d3ec58faee43f7446ac3fbd6c4531 Author: Luke Warlow Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot.html M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/dom/ScriptElement.h Log Message: --- Trusted Types fails to protect against a script edited mid-parse https://bugs.webkit.org/show_bug.cgi?id=274253 Reviewed by Darin Adler. This patch adds a new flag to script elements that is triggered if their children are changed by API. This flag is then used to decide whether to accept parsed script elements as trusted. This patch stops parsed scripts working in XHTML documents when TT is enforced. A follow up patch will address that. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot.html: Added. * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::childrenChanged): (WebCore::ScriptElement::finishParsingChildren): * Source/WebCore/dom/ScriptElement.h: Canonical link: https://commits.webkit.org/279225@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d67f50: [Xcode] WK_WORKSPACE_DIR build setting computed in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d67f50b1bb68ec2d7f99e79461a81a18d1bbd26c https://github.com/WebKit/WebKit/commit/d67f50b1bb68ec2d7f99e79461a81a18d1bbd26c Author: Elliott Williams Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Configurations/WebKitProjectPaths.xcconfig Log Message: --- [Xcode] WK_WORKSPACE_DIR build setting computed incorrectly when WebKit is checked out in a directory named "Source" rdar://128549939 https://bugs.webkit.org/show_bug.cgi?id=274534 Reviewed by Alexey Proskuryakov. WK_WORKSPACE_DIR is computed by walking up the file hierarchy and looking for a "Source" or "Tools" directory to indicate that the next parent is the root directory of the repo. But it doesn't terminate when it finds a match. So, if there is a "Source" or "Tools" directory above the repo, it may be found and screw up the definition of WK_WORKSPACE_DIR. For example, if WebKit is checked out at /Users/emw/Source/WebKit, we end up with: WK_WORKSPACE_DIR=/Users/emw/Source/WebKit/Users/emw In the public build, this manifests as a failure to find the correct additions SDK inside $(WK_WORKSPACE_DIR)/WebKitLibraries/SDKs/. Fix by rewriting the WK_WORKSPACE_DIR declaration to use ":default", such that parent directories will only be considered if a child directory did not match. * Configurations/WebKitProjectPaths.xcconfig: Canonical link: https://commits.webkit.org/279224@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed0a8a: Add visionOS to the built product archive
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed0a8af440979e2c7c671c240a09a5e4ec4e089f https://github.com/WebKit/WebKit/commit/ed0a8af440979e2c7c671c240a09a5e4ec4e089f Author: Robert Jenner Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/CISupport/built-product-archive Log Message: --- Add visionOS to the built product archive https://bugs.webkit.org/show_bug.cgi?id=274572 rdar://128587087 Unreviewed follow-up fix. Missing a comma. * Tools/CISupport/built-product-archive: (archiveBuiltProduct): Canonical link: https://commits.webkit.org/279223@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fb3db: [Navigation] Set serialized state on navigation hi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fb3db45a58f172e9c8335f1da4133031e10ca58 https://github.com/WebKit/WebKit/commit/5fb3db45a58f172e9c8335f1da4133031e10ca58 Author: Rob Buis Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-info-and-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-info-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-no-args-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-and-info-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-undefined-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-pushState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-replaceState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/same-document-away-and-back-navigation-api-expected.txt M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Set serialized state on navigation history items https://bugs.webkit.org/show_bug.cgi?id=274535 Reviewed by Alex Christensen. Set serialized state on navigation history items as part of step 2 of the "notify about the committed-to entry" algorithm [1]. The test changes are progressions, i.e. assertions involving state now pass but the test may run into some failure later. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#notify-about-the-committed-to-entry * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-info-and-state-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-info-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-no-args-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-and-info-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-undefined-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-pushState-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-replaceState-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::notifyCommittedToEntry): (WebCore::Navigation::updateForNavigation): * Source/WebCore/page/Navigation.h: Canonical link: https://commits.webkit.org/279222@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 251a60: Fix dfg-ai-direct-get-by-id-attribute-change-trans...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 251a60a7bce609e41f83faf86e50c9e25aa1cc7e https://github.com/WebKit/WebKit/commit/251a60a7bce609e41f83faf86e50c9e25aa1cc7e Author: Justin Michaud Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M JSTests/stress/dfg-ai-direct-get-by-id-attribute-change-transition.js Log Message: --- Fix dfg-ai-direct-get-by-id-attribute-change-transition.js on armv7 https://bugs.webkit.org/show_bug.cgi?id=274589 Reviewed by Yusuke Suzuki. * JSTests/stress/dfg-ai-direct-get-by-id-attribute-change-transition.js: (getStructureID): Canonical link: https://commits.webkit.org/279221@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca4e82: [run-webkit-tests] Tests which fail and then crash...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca4e82e8dd0a7ea4c7729cc2785457318acd96d5 https://github.com/WebKit/WebKit/commit/ca4e82e8dd0a7ea4c7729cc2785457318acd96d5 Author: Jonathan Bedard Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py M Tools/Scripts/webkitpy/port/test.py Log Message: --- [run-webkit-tests] Tests which fail and then crash on retry aren't flakey https://bugs.webkit.org/show_bug.cgi?id=265066 rdar://118578976 Reviewed by Aakash Jain. * Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results): Tests that have unexpected behavior on retry that differs from the original failure aren't "flaky", they are still regressions and should be treated that way. * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.serial_test_basic): Resolve the Fixme. (RunTest.serial_test_run_singly_actually_runs_tests): Ditto. (RunTest.test_retrying_multiple_failures): (RunTest.test_retrying_multiple_failures_expected): * Tools/Scripts/webkitpy/port/test.py: Add support for tests whose behavior changes on retry. Canonical link: https://commits.webkit.org/279220@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b2cda: git-webkit script errs when Radar permissions not ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b2cdaf8b4e302f67d2049d42546f4676110df41 https://github.com/WebKit/WebKit/commit/4b2cdaf8b4e302f67d2049d42546f4676110df41 Author: Brianna Fan Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py Log Message: --- git-webkit script errs when Radar permissions not set (AttributeError: 'str' object has no attribute 'keys') https://bugs.webkit.org/show_bug.cgi?id=274113 rdar://115061411 Reviewed by Jonathan Bedard. Adds handle_access_exception decorator to all functions that access Radar API endpoints to output a useful error message. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py: (Tracker.handle_access_exception): (Tracker.handle_access_exception.try_func): (Tracker): Canonical link: https://commits.webkit.org/279219@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f1a31: REGRESSION(278960@main): http/tests/security/no-in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f1a31523d4a6b9d33eaf8867af21d92161e8ed7 https://github.com/WebKit/WebKit/commit/0f1a31523d4a6b9d33eaf8867af21d92161e8ed7 Author: Alex Christensen Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/history/CachedPage.cpp Log Message: --- REGRESSION(278960@main): http/tests/security/no-indexeddb-from-sandbox.html is recently randomly crashing https://bugs.webkit.org/show_bug.cgi?id=274368 rdar://128551183 Unreviewed. Null check the result of BackForwardController::currentItem. It can be null sometimes. * Source/WebCore/history/CachedPage.cpp: (WebCore::CachedPage::restore): Canonical link: https://commits.webkit.org/279218@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] adc03f: Add missing "enum" to RealtimeMediaSource::Type
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: adc03fbc0644f83a9db8a0389c905761f755df28 https://github.com/WebKit/WebKit/commit/adc03fbc0644f83a9db8a0389c905761f755df28 Author: Sihui Liu Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Add missing "enum" to RealtimeMediaSource::Type https://bugs.webkit.org/show_bug.cgi?id=274551 rdar://128567272 Reviewed by Chris Dumez. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/279217@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2ea35: REGRESSION (255669@main): http/tests/preload/onloa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2ea359dff426bcc30e1933d203d97db936f8312 https://github.com/WebKit/WebKit/commit/c2ea359dff426bcc30e1933d203d97db936f8312 Author: Ben Schwartz Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- REGRESSION (255669@main): http/tests/preload/onload_event.html is constantly failing. https://bugs.webkit.org/show_bug.cgi?id=274591 rdar://128621665 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Set iOS expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Removed redundant expectation. * LayoutTests/platform/mac/TestExpectations: Set macOS expectation and updated existing with correct bug link. Canonical link: https://commits.webkit.org/279216@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b3e2d8: [Xcode] Lots of warnings: "The OTHER_LDFLAGS build...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3e2d8b3c17e8cd046af3749e1bdc49291e9acbe https://github.com/WebKit/WebKit/commit/b3e2d8b3c17e8cd046af3749e1bdc49291e9acbe Author: Elliott Williams Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Configurations/WebKitTargetConditionals.xcconfig M Source/JavaScriptCore/Configurations/JSC.xcconfig M Source/WebKit/Configurations/BaseTarget.xcconfig M Source/WebKit/Configurations/BaseXPCService.xcconfig M Source/WebKit/Configurations/GPUExtension.xcconfig M Source/WebKit/Configurations/NetworkingExtension.xcconfig M Source/WebKit/Configurations/WebContentExtension.xcconfig Log Message: --- [Xcode] Lots of warnings: "The OTHER_LDFLAGS build setting is not allowed to contain -dyld_env, use the dedicated LD_ENVIRONMENT build setting instead" rdar://128554357 https://bugs.webkit.org/show_bug.cgi?id=274542 Reviewed by Alexey Proskuryakov. In build system versions that support it, start using the new LD_ENVIRONMENT build setting to silence the warning. * Configurations/WebKitTargetConditionals.xcconfig: * Source/JavaScriptCore/Configurations/JSC.xcconfig: * Source/WebKit/Configurations/BaseTarget.xcconfig: * Source/WebKit/Configurations/BaseXPCService.xcconfig: * Source/WebKit/Configurations/GPUExtension.xcconfig: * Source/WebKit/Configurations/NetworkingExtension.xcconfig: * Source/WebKit/Configurations/WebContentExtension.xcconfig: Canonical link: https://commits.webkit.org/279215@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89ffa3: [visionOS] Audio coming from wrong location in ful...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89ffa3deb5e76c98593f533a16ea7c5fa211597f https://github.com/WebKit/WebKit/commit/89ffa3deb5e76c98593f533a16ea7c5fa211597f Author: Jer Noble Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/platform/audio/AudioSession.cpp M Source/WebCore/platform/audio/AudioSession.h M Source/WebCore/platform/audio/ios/AudioSessionIOS.h M Source/WebCore/platform/audio/ios/AudioSessionIOS.mm M Source/WebCore/platform/cocoa/PlaybackSessionModel.h M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h M Source/WebCore/platform/cocoa/VideoFullscreenCaptions.h M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/MediaPlayerPrivate.h M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h M Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h M Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp M Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm M Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp M Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h M Source/WebKit/WebProcess/GPU/media/RemoteAudioSessionConfiguration.h M Source/WebKit/WebProcess/GPU/media/RemoteAudioSessionConfiguration.serialization.in M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.messages.in M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm Log Message: --- [visionOS] Audio coming from wrong location in fullscreen mode https://bugs.webkit.org/show_bug.cgi?id=274529 rdar://127009932 Reviewed by Andy Estes. When video playback goes into native fullscreen, the rendering path switches from being CALayer-backed to being Entity/VideoTarget-backed. This switch means the system loses the connection between the layer's location in space, and the audio associated with that layer. In order to restore that connection, add a separated layer containing a spatial tracking label as a sublayer of the captions layer we provide to the native fullscreen presentation, and that tracking label will be passed all the down to the GPU process. Now that video playback is correctly spatialized in fullscreen, we also need to increase the soundstage size to "Large" when in fullscreen as well. Previously this was only managed by individual players, and only MSE-backed players. Instead, pull responsibility for setting the soundstage size up into the UI process, and propogate that setting down to the GPU process by calculating a "maximum" soundstage size at both the WebContent and GPU process level. Since setting the soundstage size also requires a UIScene identifier, that will be pulled out from MediaPlaye
[webkit-changes] [WebKit/WebKit] 6ddb74: [Remote Inspection] Right click > Toggle Visibilit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ddb740bdea7c4f3d92623dea99d7771f79c5a21 https://github.com/WebKit/WebKit/commit/6ddb740bdea7c4f3d92623dea99d7771f79c5a21 Author: Wenson Hsieh Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/page/ElementTargetingController.cpp M Source/WebCore/page/ElementTargetingController.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm Log Message: --- [Remote Inspection] Right click > Toggle Visibility sometimes fails to reveal hidden elements https://bugs.webkit.org/show_bug.cgi?id=274586 Reviewed by Aditya Keerthi. Make a couple of minor adjustments to undo initial visibility adjustment rules when Web Inspector resets "Toggle Visibility" state for targeted elements. * Source/WebCore/page/ElementTargetingController.cpp: (WebCore::ElementTargetingController::adjustVisibilityInRepeatedlyTargetedRegions): (WebCore::ElementTargetingController::reset): (WebCore::ElementTargetingController::resetVisibilityAdjustments): * Source/WebCore/page/ElementTargetingController.h: * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm: (-[_WKTargetedElementInfo debugDescription]): Also, add a `-debugDescription` to make debug logging more useful. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm: (TestWebKitAPI::TEST(ElementTargeting, RequestElementsFromSelectors)): Canonical link: https://commits.webkit.org/279213@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54f8c1: Make build-and-analyze work with stable/20230725 b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54f8c161d3391ccb10743c3c0cff6eb801c5c9df https://github.com/WebKit/WebKit/commit/54f8c161d3391ccb10743c3c0cff6eb801c5c9df Author: Ryosuke Niwa Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WTF/wtf/Compiler.h M Source/WTF/wtf/PlatformHave.h M Tools/Scripts/build-and-analyze Log Message: --- Make build-and-analyze work with stable/20230725 branch of clang https://bugs.webkit.org/show_bug.cgi?id=274546 Reviewed by David Kilzer. Add two new options to build-and-analyze script: --preprocessor-additions to specify additional #define macros, and --dry-run to print out the "make" command to execute instead of executing it. Introduce new macro CLANG_WEBKIT_BRANCH which, if defined, enables [[suppress]] on class declaration and avoid defining HAVE_SWIFT_CPP_INTEROP so that we can run the static analysis for the entire WebKit repository using: https://github.com/rniwa/llvm-project/tree/webkit * Source/WTF/wtf/Compiler.h: * Tools/Scripts/build-and-analyze: (main): (parse_args): Canonical link: https://commits.webkit.org/279212@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 507a9b: [GTK] Gardening of a11y API tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 507a9b2be3a851daae2a453dde6768fa89518518 https://github.com/WebKit/WebKit/commit/507a9b2be3a851daae2a453dde6768fa89518518 Author: Claudio Saavedra Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Gardening of a11y API tests https://bugs.webkit.org/show_bug.cgi?id=274582 Unreviewed gardening. Mark more accessibilty-related API test failures. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/279211@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 554c82: Build fix for WKTextIndicatorStyleType.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 554c82141ea2d5a65c21dc3c2ab981716f471548 https://github.com/WebKit/WebKit/commit/554c82141ea2d5a65c21dc3c2ab981716f471548 Author: Megan Gardner Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/WKSTextStyleManager.h Log Message: --- Build fix for WKTextIndicatorStyleType. https://bugs.webkit.org/show_bug.cgi?id=274590 rdar://128619075 Unreviewed built fix. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (toWKTextIndicatorStyleType): * Source/WebKit/UIProcess/WKSTextStyleManager.h: Canonical link: https://commits.webkit.org/279210@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8e4fc: REGRESSION: (r276031) PremiereMax.com no longer lo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8e4fcd2924b785084c47fb25d2af3c4d1ac6229 https://github.com/WebKit/WebKit/commit/a8e4fcd2924b785084c47fb25d2af3c4d1ac6229 Author: Michael Saboff Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/JavaScriptCore/yarr/YarrJIT.cpp M Source/JavaScriptCore/yarr/YarrJITRegisters.h Log Message: --- REGRESSION: (r276031) PremiereMax.com no longer loads properly https://bugs.webkit.org/show_bug.cgi?id=274574 rdar://128338255 Reviewed by Yusuke Suzuki. Removed a small optimization that was added in 276031@main where we advance two characters when we read a non-BMP character that doesn't match any atoms. 3. (ARM64 only) When we read a non-BMP code point, consisting of two surrogate code units, and we fail to match any atom in the body of a RegExp, we were incrementing the subject string index by 1 and going back to the top of the loop to start matching the pattern again. Now we dedicate a register to hold either 0 or 1 depending on the width of the first character read for that loop iteration. When advancing the index for the next iteration, we add the value of that register to the updated index. This eliminates one iteration through the matching loop for each non-BMP code point that doesn't match. * Source/JavaScriptCore/yarr/YarrJIT.cpp: * Source/JavaScriptCore/yarr/YarrJITRegisters.h: Canonical link: https://commits.webkit.org/279209@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a32a08: Rename IPC::Decoder::buffer() to span()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a32a08ab27d7245b1e8c577a3498690ed5ef85e2 https://github.com/WebKit/WebKit/commit/a32a08ab27d7245b1e8c577a3498690ed5ef85e2 Author: Chris Dumez Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebKit/Platform/IPC/Decoder.h M Source/WebKit/Platform/IPC/JSIPCBinding.h M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp Log Message: --- Rename IPC::Decoder::buffer() to span() https://bugs.webkit.org/show_bug.cgi?id=274570 Reviewed by Darin Adler. Rename IPC::Decoder::buffer() to span() for consistency with other types (such as IPC::Encoder). * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::span const): (IPC::Decoder::buffer const): Deleted. * Source/WebKit/Platform/IPC/JSIPCBinding.h: (IPC::putJSValueForDecodeArgumentInArray): * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::jsResultFromReplyDecoder): (WebKit::IPCTestingAPI::JSMessageListener::didReceiveMessage): (WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder): Canonical link: https://commits.webkit.org/279208@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fefe94: Add visionOS to the built product archive
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fefe9454de00f4d8e468aaed165810758345f0f4 https://github.com/WebKit/WebKit/commit/fefe9454de00f4d8e468aaed165810758345f0f4 Author: Robert Jenner Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/CISupport/built-product-archive Log Message: --- Add visionOS to the built product archive https://bugs.webkit.org/show_bug.cgi?id=274572 rdar://128587087 Unreviewed. Adding visionOS to the built product archive. * Tools/CISupport/built-product-archive: (webkitBuildDirectoryForConfigurationAndPlatform): (determineWebKitBuildDirectories): (archiveBuiltProduct): (extractBuiltProduct): Canonical link: https://commits.webkit.org/279207@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 341129: [GTK][WPE] Do not display uninitialized WebGL fron...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 341129414655facbed5a7a46f322b16a93028ac9 https://github.com/WebKit/WebKit/commit/341129414655facbed5a7a46f322b16a93028ac9 Author: Loïc Yhuel Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h M Source/WebCore/platform/graphics/texmap/TextureMapperGCGLPlatformLayer.cpp Log Message: --- [GTK][WPE] Do not display uninitialized WebGL front buffer https://bugs.webkit.org/show_bug.cgi?id=274527 Reviewed by Miguel Gomez. When a page creates a WebGL context, but does not render immediately, we display the compositor texture from GraphicsContextGLTextureMapperANGLE. After reshapeDrawingBuffer (glTexImage2D with null data), the contents are undefined as per the OpenGL specification, and depending on the plaform this may display uninitialized memory. We now check if the texture is initialized before using it in GCGLANGLELayer::swapBuffersIfNeeded or TextureMapperGCGLPlatformLayer::paintToTextureMapper. * Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp: (Nicosia::GCGLANGLELayer::swapBuffersIfNeeded): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLTextureMapperANGLE::swapCompositorTexture): (WebCore::GraphicsContextGLTextureMapperANGLE::reshapeDrawingBuffer): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: * Source/WebCore/platform/graphics/texmap/TextureMapperGCGLPlatformLayer.cpp: (WebCore::TextureMapperGCGLPlatformLayer::paintToTextureMapper): Canonical link: https://commits.webkit.org/279206@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a1f192: REGRESSION (277166@main): [iOS] Search doesn’t hig...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a1f1924291fba68c7494c7e2b67b31753f8ae9bd https://github.com/WebKit/WebKit/commit/a1f1924291fba68c7494c7e2b67b31753f8ae9bd Author: Aditya Keerthi Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebKit/Shared/WebFoundTextRange.h M Source/WebKit/Shared/WebFoundTextRange.serialization.in M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm Log Message: --- REGRESSION (277166@main): [iOS] Search doesn’t highlight text being searched in Mail https://bugs.webkit.org/show_bug.cgi?id=274571 rdar://127888785 Reviewed by Tim Horton and Charlie Wolfe. 277166@main replaced unique frame names with `FrameIdentifier` in `WebFoundTextRange`. While this is a generally desirable change as site isolation is developed, it is currently incompatible with `UIFindInteraction` support for Mail. Mail performs searches using a pool of offscreen web views, to avoid creating one webview per email in a thread. Consequently, Mail relies on the fact that a `WebFoundTextRange` acquired from one web view, can be reused to highlight matches in a different web view with the same web content. The use of `FrameIdentifier` breaks this functionality, as it is a unique identifier that will never match across web views with the same content. On the other hand, frame names match since they are in tree order. For now, fix by reverting 277166@main, and add a test to document support for the behavior that Mail relies on. Eventually, an alternate solution will be needed to support site isolation. However, that will also require rearchitecting WebKit's implementation of `UITextSearching`. * Source/WebKit/Shared/WebFoundTextRange.h: (WTF::HashTraits::constructDeletedValue): * Source/WebKit/Shared/WebFoundTextRange.serialization.in: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKFoundTextRange dealloc]): * Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp: (WebKit::WebFoundTextRangeController::findTextRangesForStringMatches): (WebKit::WebFoundTextRangeController::documentForFoundTextRange const): * Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm: (TEST(WebKit, FindAndHighlightDifferentWebViews)): Canonical link: https://commits.webkit.org/279205@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 543bc8: [WGSL] Type::size can overflow
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 543bc8506d61350573b54b6bdd0667e0322d2dfc https://github.com/WebKit/WebKit/commit/543bc8506d61350573b54b6bdd0667e0322d2dfc Author: Tadeu Zagallo Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/fast/webgpu/fuzz-128381161-expected.txt A LayoutTests/fast/webgpu/fuzz-128381161.html M Source/WebGPU/WGSL/AttributeValidator.cpp M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/Types.cpp A Source/WebGPU/WGSL/tests/invalid/struct-parse.wgsl Log Message: --- [WGSL] Type::size can overflow https://bugs.webkit.org/show_bug.cgi?id=274395 rdar://128381161 Reviewed by Mike Wyrzykowski. We use 32-bit values to represent the byte size of types, and that can overflow when computing the size of structs or arrays. That is not a problem in practice, as the size of buffers is limited by the API, so we just clamp the numbers to uint_max. * LayoutTests/fast/webgpu/fuzz-128381161-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-128381161.html: Added. * Source/WebGPU/WGSL/AttributeValidator.cpp: (WGSL::AttributeValidator::visit): * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseStructure): * Source/WebGPU/WGSL/Types.cpp: (WGSL::Type::size const): * Source/WebGPU/WGSL/tests/invalid/struct-parse.wgsl: Added. Canonical link: https://commits.webkit.org/279204@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35f090: [UnifiedPDF] Crash in UnifiedPDFPlugin::repaintFor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35f09068c7e287e8b5466353a7cb742e33b8492a https://github.com/WebKit/WebKit/commit/35f09068c7e287e8b5466353a7cb742e33b8492a Author: Simon Fraser Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/http/tests/pdf/linearized-pdf-in-display-none-iframe-expected.txt A LayoutTests/http/tests/pdf/linearized-pdf-in-display-none-iframe.html M LayoutTests/http/tests/pdf/linearized-pdf-in-iframe.html M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Crash in UnifiedPDFPlugin::repaintForIncrementalLoad() loading charbonnelchocolates.com page https://bugs.webkit.org/show_bug.cgi?id=274563 rdar://128316806 Reviewed by Abrar Rahman Protyasha. repaintForIncrementalLoad() can get called before the main thread has a PDFDocument or has created any layers, so early return in that case. This web page has a `display:none` iframe with PDF contents, which triggered this crash. * LayoutTests/http/tests/pdf/linearized-pdf-in-display-none-iframe-expected.txt: Added. * LayoutTests/http/tests/pdf/linearized-pdf-in-display-none-iframe.html: Copied from LayoutTests/http/tests/pdf/linearized-pdf-in-iframe.html. * LayoutTests/http/tests/pdf/linearized-pdf-in-iframe.html: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::repaintForIncrementalLoad): Canonical link: https://commits.webkit.org/279203@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 37b7a1: WebExtensionContext::openTabs() should only return...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 37b7a1c15d162636bf8ed3f38269e4fed3370878 https://github.com/WebKit/WebKit/commit/37b7a1c15d162636bf8ed3f38269e4fed3370878 Author: Kiara Rose Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h Log Message: --- WebExtensionContext::openTabs() should only return tabs that are open https://bugs.webkit.org/show_bug.cgi?id=274486 rdar://128285195 Reviewed by Timothy Hatcher. Filter WebExtensionContext::openTabs() to only return tabs that are open. Not having this check is a bug and adding this check should cause bugs like rdar://128285195 to reproduce less since didOpenTab wouldn't have been called for those tabs since they belong to a different profile. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::openTabs const): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm: (WebKit::WebExtensionTab::mainWebView() const): Remove the THROW_UNLESS from here since throwing here doesn't give us any indication of where the issue is occurring from the app. A better place for this error would be in getOrCreateTab. Canonical link: https://commits.webkit.org/279202@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d59731: Use nw_context_privacy_level_silent for DNS lookup
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5973196a382a1964fe1eed6843bad33c3aa449b https://github.com/WebKit/WebKit/commit/d5973196a382a1964fe1eed6843bad33c3aa449b Author: Alex Christensen Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp Log Message: --- Use nw_context_privacy_level_silent for DNS lookup https://bugs.webkit.org/show_bug.cgi?id=272190 rdar://120452086 Reviewed by Matthew Finkel, Brent Fulgham and Youenn Fablet. DNSServiceGetAddrInfo logs the domain name in internal builds, which is undesirable when using WKWebsiteDataStore.nonPersistentDataStore. This redacts those logs. Public OSes should be unaffected. * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp: (WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::complete): (WebCore::extractIPAddress): (WebCore::DNSResolveQueueCFNet::performDNSLookup): (WebCore::DNSResolveQueueCFNet::stopResolve): (WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::addIPAddress): Deleted. (WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::receivedIPv4AndIPv6 const): Deleted. (): Deleted. (WebCore::dnsLookupCallback): Deleted. Originally-landed-as: 272448.889@safari-7618-branch (7e9184c87123). rdar://128570639 Canonical link: https://commits.webkit.org/279199@main Commit: ee944cef38abdeeb7412f74137811c1e46e106c7 https://github.com/WebKit/WebKit/commit/ee944cef38abdeeb7412f74137811c1e46e106c7 Author: Darryl Parkinson Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/Editor.h M Source/WebCore/editing/cocoa/EditorCocoa.mm M Source/WebCore/editing/ios/EditorIOS.mm M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/page/EditorClient.h M Source/WebCore/platform/Pasteboard.h M Source/WebCore/platform/PasteboardWriterData.h M Source/WebCore/platform/PromisedAttachmentInfo.h M Source/WebCore/platform/ios/PlatformPasteboardIOS.mm M Source/WebCore/platform/mac/PasteboardMac.mm M Source/WebCore/platform/mac/PasteboardWriter.mm M Source/WebKit/Shared/Pasteboard.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm Log Message: --- Change 2 related Vectors to use Vector Pair to prevent OOB. rdar://122621756 Reviewed by Ryosuke Niwa, Alex Christensen and Brady Eidson Changing two related Vectors to use a Vector pair which means they are always the same length, preventing an OOB on one of the vectors. * Source/WebKit/Shared/Pasteboard.serialization.in: Originally-landed-as: 272448.899@safari-7618-branch (48d5c62d7d15). rdar://128570706 Canonical link: https://commits.webkit.org/279200@main Commit: 1d943e49ba8542867bbf3238ada5e64a05201449 https://github.com/WebKit/WebKit/commit/1d943e49ba8542867bbf3238ada5e64a05201449 Author: Nitin Mahendru Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebCore/SerializedScriptValue.cpp Log Message: --- Removing unbounded resize of Vector https://bugs.webkit.org/show_bug.cgi?id=272491 rdar://126132559 Reviewed by Alex Christensen. Resize the vector with an option to fallback to default value. Test Case has been added to verify the fix. * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readRTCCertificate): * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebCore/SerializedScriptValue.cpp: Added. (TestWebKitAPI::TEST): Originally-landed-as: 272448.906@safari-7618-branch (cb2f03208aa6). rdar://128571325 Canonical link: https://commits.webkit.org/279201@main Compare: https://github.com/WebKit/WebKit/compare/7031a92238c3...1d943e49ba85 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7031a9: OBJECT_OFFSETOF can be constexpr
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7031a92238c3270b0db68337921a5b30d5965e91 https://github.com/WebKit/WebKit/commit/7031a92238c3270b0db68337921a5b30d5965e91 Author: Keith Miller Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h M Source/JavaScriptCore/bytecode/ArrayProfile.h M Source/JavaScriptCore/bytecode/CallLinkInfo.h M Source/JavaScriptCore/bytecode/CallLinkInfoBase.h M Source/JavaScriptCore/bytecode/CodeBlock.h M Source/JavaScriptCore/bytecode/GetByIdMetadata.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h M Source/JavaScriptCore/bytecode/IterationModeMetadata.h M Source/JavaScriptCore/bytecode/ObjectAllocationProfile.h M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/bytecode/ValueProfile.h M Source/JavaScriptCore/bytecode/Watchpoint.h M Source/JavaScriptCore/dfg/DFGCommonData.h M Source/JavaScriptCore/dfg/DFGJITCode.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLJITCode.h M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/generator/Metadata.rb M Source/JavaScriptCore/heap/CompleteSubspace.h M Source/JavaScriptCore/heap/FreeList.h M Source/JavaScriptCore/heap/LocalAllocator.h M Source/JavaScriptCore/heap/MarkedBlock.h M Source/JavaScriptCore/heap/PreciseAllocation.h M Source/JavaScriptCore/heap/TinyBloomFilter.h M Source/JavaScriptCore/heap/WeakImpl.h M Source/JavaScriptCore/heap/WeakSet.h M Source/JavaScriptCore/interpreter/CallFrame.h M Source/JavaScriptCore/jit/AssemblyHelpers.cpp M Source/JavaScriptCore/jit/BaselineJITCode.h M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JITCode.h M Source/JavaScriptCore/jit/ThunkGenerators.cpp M Source/JavaScriptCore/llint/LLIntData.cpp M Source/JavaScriptCore/runtime/ArrayBuffer.h M Source/JavaScriptCore/runtime/ArrayStorage.h M Source/JavaScriptCore/runtime/BufferMemoryHandle.h M Source/JavaScriptCore/runtime/Butterfly.h M Source/JavaScriptCore/runtime/CachedTypes.cpp M Source/JavaScriptCore/runtime/CachedTypes.h M Source/JavaScriptCore/runtime/ClassInfo.h M Source/JavaScriptCore/runtime/ClonedArguments.h M Source/JavaScriptCore/runtime/DateInstance.h M Source/JavaScriptCore/runtime/DateInstanceCache.h M Source/JavaScriptCore/runtime/DirectArguments.h M Source/JavaScriptCore/runtime/Exception.h M Source/JavaScriptCore/runtime/ExecutableBase.h M Source/JavaScriptCore/runtime/FunctionExecutable.h M Source/JavaScriptCore/runtime/GetterSetter.h M Source/JavaScriptCore/runtime/HasOwnPropertyCache.h M Source/JavaScriptCore/runtime/HashMapImpl.h M Source/JavaScriptCore/runtime/IndexingHeader.h M Source/JavaScriptCore/runtime/InternalFunction.h M Source/JavaScriptCore/runtime/JSArrayBufferView.h M Source/JavaScriptCore/runtime/JSBoundFunction.h M Source/JavaScriptCore/runtime/JSCJSValue.h M Source/JavaScriptCore/runtime/JSCell.h M Source/JavaScriptCore/runtime/JSDataView.h M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/JavaScriptCore/runtime/JSGlobalProxy.h M Source/JavaScriptCore/runtime/JSImmutableButterfly.h M Source/JavaScriptCore/runtime/JSInternalFieldObjectImpl.h M Source/JavaScriptCore/runtime/JSObject.h M Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.h M Source/JavaScriptCore/runtime/JSRemoteFunction.h M Source/JavaScriptCore/runtime/JSString.h M Source/JavaScriptCore/runtime/JSSymbolTableObject.h M Source/JavaScriptCore/runtime/JSTypeInfo.h M Source/JavaScriptCore/runtime/JSWrapperObject.h M Source/JavaScriptCore/runtime/MegamorphicCache.h M Source/JavaScriptCore/runtime/NativeExecutable.h M Source/JavaScriptCore/runtime/NumericStrings.h M Source/JavaScriptCore/runtime/RegExpCachedResult.h M Source/JavaScriptCore/runtime/RegExpGlobalData.h M Source/JavaScriptCore/runtime/RegExpObject.h M Source/JavaScriptCore/runtime/ScopedArguments.h M Source/JavaScriptCore/runtime/ScopedArgumentsTable.h M Source/JavaScriptCore/runtime/Structure.h M Source/JavaScriptCore/runtime/StructureRareData.h M Source/JavaScriptCore/runtime/StructureRareDataInlines.h M Source/JavaScriptCore/runtime/Symbol.h M Source/JavaScriptCore/runtime/TypeInfoBlob.h M Source/JavaScriptCore/runtime/TypeProfilerLog.h M Source/JavaScriptCore/runtime/VM.h M Source/JavaScriptCore/runtime/WeakMapImpl.h M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmGlobal.h M Source/JavaScriptCore/wasm/WasmIn
[webkit-changes] [WebKit/WebKit] 6ae064: Race condition in LibWebRTCVPXInternalVideoDecoder...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ae06410764e65994ee9d4c50e1811caa6348ddf https://github.com/WebKit/WebKit/commit/6ae06410764e65994ee9d4c50e1811caa6348ddf Author: Youenn Fablet Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/http/wpt/webcodecs/copyTo-same-decoder-expected.txt A LayoutTests/http/wpt/webcodecs/copyTo-same-decoder.html M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp Log Message: --- Race condition in LibWebRTCVPXInternalVideoDecoder::pixelBufferPool leading to memory corruption rdar://125957410 Reviewed by Chris Dumez. Add a lock to make sure creation of the pixel buffer happens correctly. * LayoutTests/http/wpt/webcodecs/copyTo-same-decoder-expected.txt: Added. * LayoutTests/http/wpt/webcodecs/copyTo-same-decoder.html: Added. * Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp: (WebCore::LibWebRTCVPXInternalVideoDecoder::createPixelBuffer): (WebCore::LibWebRTCVPXInternalVideoDecoder::Decoded): Originally-landed-as: 272448.909@safari-7618-branch (b50f1990af6e). rdar://128572002 Canonical link: https://commits.webkit.org/279196@main Commit: 7d0a50fadc7c19bf49866aaa29380fdc6f6738a5 https://github.com/WebKit/WebKit/commit/7d0a50fadc7c19bf49866aaa29380fdc6f6738a5 Author: Chris Dumez Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/Modules/webaudio/AudioBuffer.cpp M Source/WebCore/Modules/webaudio/AudioBuffer.h M Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp M Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h Log Message: --- [WebAudio] Use-after-free in WebCore::AudioBufferSourceNode::renderFromBuffer https://bugs.webkit.org/show_bug.cgi?id=272607 rdar://126326144 Reviewed by Yusuke Suzuki. The JS on the main thread can detach the AudioBuffer's channels while it is being read by the audio rendering thread, causing use-after-frees. In a previous fix attempt, we starting copying the AudioBuffer's channels so that the audio thread would read a copy instead. However, the increased memory usage resulted in increased jetsams on gaming sites. As a temporary stop gap measure, this patch simply marks the AudioBuffer's channels as non-detachable to prevent the issue. This is not quite spec compliant but it addresses the security issue until we can implement the specification correctly without causing jetsams. * Source/WebCore/Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::markBuffersAsNonDetachable): * Source/WebCore/Modules/webaudio/AudioBuffer.h: * Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::acquireBufferContent): (WebCore::AudioBufferSourceNode::setBufferForBindings): (WebCore::AudioBufferSourceNode::startPlaying): * Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h: Originally-landed-as: 272448.925@safari-7618-branch (4201e96638f0). rdar://128572657 Canonical link: https://commits.webkit.org/279197@main Compare: https://github.com/WebKit/WebKit/compare/14ea1c163233...7d0a50fadc7c To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14ea1c: Web Inspector: console's code completion should be...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14ea1c16323321db0dd237aad3aa22a9e48f9a54 https://github.com/WebKit/WebKit/commit/14ea1c16323321db0dd237aad3aa22a9e48f9a54 Author: Qianlang Chen Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/inspector/console/js-completions-expected.txt M LayoutTests/inspector/console/js-completions.html M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Base/Setting.js M Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js M Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js Log Message: --- Web Inspector: console's code completion should be case-insensitive rdar://124544458 https://bugs.webkit.org/show_bug.cgi?id=270925 Reviewed by Devin Rousso. Convert both strings into lowercase when trying to match prefixes for function, variable, or property names. Also add an experimental setting item for this feature enhancement. * Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js: (WI.CodeMirrorCompletionController.prototype._applyCompletionHint.update): (WI.CodeMirrorCompletionController.prototype._applyCompletionHint): - Since case-insensitive matching may be used, only show the watermark text on the prompt if the typed text exactly, case-sensitively matches the prefix. * Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js: (WI.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions.): (WI.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions): * Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js: (WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames): (WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded): (WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare): Deleted. - Optionally perform case-insensitive prefix matching when filtering the code completion suggestions. * Source/WebInspectorUI/UserInterface/Base/Setting.js: * Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js: * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: - Add the experimental setting item for this change in the Settings tab's Experimental sub-tab. * LayoutTests/inspector/console/js-completions-expected.txt: * LayoutTests/inspector/console/js-completions.html: - Add a test case for the code completions' ordering since now it gets slightly more involved with case-insensitive matching. Canonical link: https://commits.webkit.org/279195@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e0f9b: Implement eval support for TrustedScript objects
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e0f9b3cfb2b1ec21b3481b9c09ba763aa32a119 https://github.com/WebKit/WebKit/commit/5e0f9b3cfb2b1ec21b3481b9c09ba763aa32a119 Author: Luke Warlow Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/WorkerGlobalScope-eval.https.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting.html M LayoutTests/platform/wincairo/TestExpectations M Source/JavaScriptCore/API/JSAPIGlobalObject.cpp M Source/JavaScriptCore/API/JSAPIGlobalObject.mm M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/GlobalObjectMethodTable.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/WebCore/bindings/js/JSDOMWindowBase.cpp M Source/WebCore/bindings/js/JSDOMWindowBase.h M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.h Log Message: --- Implement eval support for TrustedScript objects https://bugs.webkit.org/show_bug.cgi?id=273184 Reviewed by Ryosuke Niwa and Justin Michaud. This patch introduces a new codeForEval function to the global object method table. The eval code is updated to check if an object has associated code instead of always returning the object. Add test coverage for indirect evals. See https://tc39.es/proposal-dynamic-code-brand-checks/ * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-cs
[webkit-changes] [WebKit/WebKit] 1a9ffd: [GTK] Garden user-messages API test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a9ffd8b3aebd3bfaf706f778d957b9c9882149d https://github.com/WebKit/WebKit/commit/1a9ffd8b3aebd3bfaf706f778d957b9c9882149d Author: Claudio Saavedra Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Garden user-messages API test https://bugs.webkit.org/show_bug.cgi?id=274585 Unreviewed gardening. user-messages is failing, mark the failure. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/279193@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0200b0: Use native promise for CacheStorageConnection::remove
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0200b038d629471c44af42122601f71e35e26982 https://github.com/WebKit/WebKit/commit/0200b038d629471c44af42122601f71e35e26982 Author: Youenn Fablet Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/Modules/cache/CacheStorageConnection.h M Source/WebCore/Modules/cache/DOMCacheStorage.cpp M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h M Source/WebCore/page/CacheStorageProvider.h M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h Log Message: --- Use native promise for CacheStorageConnection::remove rdar://128529826 https://bugs.webkit.org/show_bug.cgi?id=274514 Reviewed by Sihui Liu. Refactoring to use native promise for CacheStorageConnection::remove allows to simplify code. This might pave the way towards sending IPC message to the network process from the worker thread directly as well. * Source/WebCore/Modules/cache/CacheStorageConnection.h: * Source/WebCore/Modules/cache/DOMCacheStorage.cpp: (WebCore::DOMCacheStorage::doRemove): * Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp: (WebCore::WorkerCacheStorageConnection::remove): (WebCore::WorkerCacheStorageConnection::clearPendingRequests): (WebCore::WorkerCacheStorageConnection::removeCompleted): Deleted. * Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h: * Source/WebCore/page/CacheStorageProvider.h: * Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp: (WebKit::WebCacheStorageConnection::remove): (WebKit::WebCacheStorageConnection::retrieveCaches): Deleted. (WebKit::WebCacheStorageConnection::retrieveRecords): Deleted. (WebKit::WebCacheStorageConnection::batchDeleteOperation): Deleted. (WebKit::WebCacheStorageConnection::batchPutOperation): Deleted. (WebKit::WebCacheStorageConnection::reference): Deleted. (WebKit::WebCacheStorageConnection::dereference): Deleted. (WebKit::WebCacheStorageConnection::lockStorage): Deleted. (WebKit::WebCacheStorageConnection::unlockStorage): Deleted. (WebKit::WebCacheStorageConnection::clearMemoryRepresentation): Deleted. (WebKit::WebCacheStorageConnection::engineRepresentation): Deleted. (WebKit::WebCacheStorageConnection::updateQuotaBasedOnSpaceUsage): Deleted. (WebKit::WebCacheStorageConnection::networkProcessConnectionClosed): Deleted. Canonical link: https://commits.webkit.org/279192@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e67dd6: [GStreamer] Move most GStreamerCommon classes impl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e67dd6f289db6671b04a9f74c47dc54cd266c257 https://github.com/WebKit/WebKit/commit/e67dd6f289db6671b04a9f74c47dc54cd266c257 Author: Philippe Normand Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp Log Message: --- [GStreamer] Move most GStreamerCommon classes implemenations to cpp file https://bugs.webkit.org/show_bug.cgi?id=274524 Reviewed by Xabier Rodriguez-Calvar. The GStreamerCommon.h file is included in many other files, so any change there triggers ~950 compile jobs on an incremental build. The template classes were left in the header, moving them to the cpp file would increase verbosity too much. Also driving-by a couple GstMappedFrame methods were renamed, adopting the camelCase style. * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::GstMappedOwnedBuffer::create): (WebCore::GstMappedOwnedBuffer::~GstMappedOwnedBuffer): (WebCore::GstMappedOwnedBuffer::createSharedBuffer): (WebCore::GstMappedFrame::GstMappedFrame): (WebCore::GstMappedFrame::~GstMappedFrame): (WebCore::GstMappedFrame::get): (WebCore::GstMappedFrame::componentData const): (WebCore::GstMappedFrame::componentStride const): (WebCore::GstMappedFrame::info): (WebCore::GstMappedFrame::width const): (WebCore::GstMappedFrame::height const): (WebCore::GstMappedFrame::format const): (WebCore::GstMappedFrame::planeData const): (WebCore::GstMappedFrame::planeStride const): (WebCore::GstMappedAudioBuffer::GstMappedAudioBuffer): (WebCore::GstMappedAudioBuffer::~GstMappedAudioBuffer): (WebCore::GstMappedAudioBuffer::get): (WebCore::GstMappedAudioBuffer::info): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h: (WebCore::unmapFunction): (WebCore::GstMappedOwnedBuffer::create): Deleted. (WebCore::GstMappedOwnedBuffer::~GstMappedOwnedBuffer): Deleted. (WebCore::GstMappedFrame::GstMappedFrame): Deleted. (WebCore::GstMappedFrame::~GstMappedFrame): Deleted. (WebCore::GstMappedFrame::get): Deleted. (WebCore::GstMappedFrame::ComponentData const): Deleted. (WebCore::GstMappedFrame::ComponentStride const): Deleted. (WebCore::GstMappedFrame::info): Deleted. (WebCore::GstMappedFrame::width const): Deleted. (WebCore::GstMappedFrame::height const): Deleted. (WebCore::GstMappedFrame::format const): Deleted. (WebCore::GstMappedFrame::planeData const): Deleted. (WebCore::GstMappedFrame::planeStride const): Deleted. (WebCore::GstMappedAudioBuffer::GstMappedAudioBuffer): Deleted. (WebCore::GstMappedAudioBuffer::get): Deleted. (WebCore::GstMappedAudioBuffer::info): Deleted. (WebCore::GstMappedAudioBuffer::~GstMappedAudioBuffer): Deleted. * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::VideoFrame::copyTo): * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp: (WebCore::GStreamerVideoFrameLibWebRTC::ToI420): Canonical link: https://commits.webkit.org/279191@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6f7e5: [GStreamer] Silence GstVideoFrame leaks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6f7e5b1258f62f62681fbf0e34fefe8c12369bb https://github.com/WebKit/WebKit/commit/f6f7e5b1258f62f62681fbf0e34fefe8c12369bb Author: Philippe Normand Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp Log Message: --- [GStreamer] Silence GstVideoFrame leaks https://bugs.webkit.org/show_bug.cgi?id=274257 Reviewed by Xabier Rodriguez-Calvar. The ImageGStreamer no longer holds a BitmapImage, but a PlatformImagePtr. A BitmapImage is now created by VideoFrameGStreamer when painting is required. The ImageGStreamerSkia implementation no longer holds the mapped GstVideoFrame because that keeps un-necessary references and file descriptors open, the needed plane data is copied instead. * Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp: (WebCore::ensureDebugCategoryIsInitialized): (WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer): * Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h: (WebCore::ImageGStreamer::create): (WebCore::ImageGStreamer::image const): (WebCore::ImageGStreamer::rect): (WebCore::ImageGStreamer::createImage): Deleted. (WebCore::ImageGStreamer::image): Deleted. * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp: (WebCore::ImageGStreamer::ImageGStreamer): * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp: (WebCore::ImageGStreamer::ImageGStreamer): * Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h: (WebCore::MediaSampleGStreamer::sample const): * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::convertSampleToImage): (WebCore::VideoFrame::paintInContext): Canonical link: https://commits.webkit.org/279190@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42ce18: Use aligned_alloc where possible
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42ce1889929fe99b82b78440120ec6f4a4ca57f8 https://github.com/WebKit/WebKit/commit/42ce1889929fe99b82b78440120ec6f4a4ca57f8 Author: Rose Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WTF/wtf/FastMalloc.cpp M Source/bmalloc/bmalloc/DebugHeap.cpp Log Message: --- Use aligned_alloc where possible https://bugs.webkit.org/show_bug.cgi?id=266538 Reviewed by Michael Catanzaro. aligned_alloc is more portable and cleaner than posix_memalign is. In fact, aligned_alloc supersedes posix_memalign entirely. * Source/WTF/wtf/FastMalloc.cpp: Ditto. (WTF::fastAlignedMalloc): Replace posix_memalign with aligned_alloc. (WTF::tryFastAlignedMalloc): Ditto. * Source/bmalloc/bmalloc/DebugHeap.cpp: Ditto. (bmalloc::DebugHeap::memalign): Ditto. Canonical link: https://commits.webkit.org/279189@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24c318: [GTK] Memory pressure API test is mostly failing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24c318494dd5665fe20a866fda0b3e4cc942cd30 https://github.com/WebKit/WebKit/commit/24c318494dd5665fe20a866fda0b3e4cc942cd30 Author: Claudio Saavedra Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Memory pressure API test is mostly failing https://bugs.webkit.org/show_bug.cgi?id=274580 Unreviewed gardening. memory-pressure is mostly failing, mark it as such. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/279188@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfac95: Use partial style application for non-cacheable pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfac95680a14569c0cc9a2b2c1eb70904a60c812 https://github.com/WebKit/WebKit/commit/cfac95680a14569c0cc9a2b2c1eb70904a60c812 Author: Antti Koivisto Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Source/WebCore/style/ElementRuleCollector.cpp M Source/WebCore/style/ElementRuleCollector.h M Source/WebCore/style/MatchResult.h M Source/WebCore/style/MatchedDeclarationsCache.cpp M Source/WebCore/style/PropertyCascade.cpp M Source/WebCore/style/PropertyCascade.h M Source/WebCore/style/StyleResolver.cpp Log Message: --- Use partial style application for non-cacheable presentational hint style https://bugs.webkit.org/show_bug.cgi?id=274081 rdar://127995820 Reviewed by Alan Baradlay. Presentational hint style especially in SVG often uses many unique property values that miss the the matched declarations cache. We can still use the cache partilly for such cases by applying the presentational properties on top of the existing cache entry. * Source/WebCore/style/ElementRuleCollector.cpp: (WebCore::Style::ElementRuleCollector::addElementStyleProperties): (WebCore::Style::ElementRuleCollector::matchAllRules): Enable partial caching for SVG presentational hints. (WebCore::Style::ElementRuleCollector::addElementInlineStyleProperties): This could also be applied to inlne style but this patch does not implement it. (WebCore::Style::ElementRuleCollector::addMatchedProperties): * Source/WebCore/style/ElementRuleCollector.h: * Source/WebCore/style/MatchResult.h: (WebCore::Style::operator==): (WebCore::Style::MatchResult::cacheablePropertiesEqual const): New equality comparison that ignores non-cacheable properties. (WebCore::Style::add): * Source/WebCore/style/MatchedDeclarationsCache.cpp: (WebCore::Style::MatchedDeclarationsCache::computeHash): (WebCore::Style::MatchedDeclarationsCache::find): * Source/WebCore/style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::addMatch): * Source/WebCore/style/PropertyCascade.h: * Source/WebCore/style/StyleResolver.cpp: (WebCore::Style::Resolver::applyMatchedProperties): Apply non-cacheable properties after cache hit. Canonical link: https://commits.webkit.org/279187@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 159906: [view-transitions] Mispositioned snapshots on http...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 159906e6201b73d5b59b2ac3aed6788b66c7a7e7 https://github.com/WebKit/WebKit/commit/159906e6201b73d5b59b2ac3aed6788b66c7a7e7 Author: Matt Woodrow Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background.html M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/platform/graphics/transforms/TransformState.cpp M Source/WebCore/platform/graphics/transforms/TransformState.h M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp M Source/WebCore/platform/graphics/transforms/TransformationMatrix.h M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: --- [view-transitions] Mispositioned snapshots on https://codepen.io/bramus/full/mdowgYX https://bugs.webkit.org/show_bug.cgi?id=272185 rdar://125931829 Reviewed by Simon Fraser. We were previously unconditionally substracting the scroll position from the transform when positioning the snapshots. This is incorrect in some cases, like when the element is fixed positioned. This makes use of the existing TransformState/mapLocalToContainer code to correctly account for position:fixed when accumulating transforms through ancestors. It also adds support for flattening the 'tracked' transform when crossing 3d rendering context boundaries, by setting the 3rd row and column of the TransformationMatrix to 0. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-flat-transform-ancestor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-preserve-3d-ancestor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-transform-position-fixed.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-scrollbar-with-fixed-background.html: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::copyElementBaseProperties): * Source/WebCore/platform/graphics/transforms/TransformState.cpp: (WebCore::TransformState::translateMappedCoordinates): (WebCore::TransformState::flattenWithTransform): * Source/WebCore/platform/graphics/transforms/TransformState.h: * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::flatten): * Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsoluteTra
[webkit-changes] [WebKit/WebKit] aa2835: [GTK] Build failures in TestWebKitAPI for WebKitGTK
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aa28356f83b8a683976102106065dbd46f9a0299 https://github.com/WebKit/WebKit/commit/aa28356f83b8a683976102106065dbd46f9a0299 Author: Georges Basile Stavracas Neto Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp M Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp Log Message: --- [GTK] Build failures in TestWebKitAPI for WebKitGTK https://bugs.webkit.org/show_bug.cgi?id=274578 Unreviewed build fix. Add explicit return types to the lambdas, which makes Clang happy enough to finish the build. * Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp: * Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp: Canonical link: https://commits.webkit.org/279185@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
