[webkit-changes] [WebKit/WebKit] 1ec49c: IPC decoding fails for some extension API message ...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ec49c531096be196d67726d6bb20bf0ce7d3ceb
  
https://github.com/WebKit/WebKit/commit/1ec49c531096be196d67726d6bb20bf0ce7d3ceb
  Author: Kiara Rose 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h
M Source/WebKit/Shared/Extensions/WebExtensionTabIdentifier.h
M Source/WebKit/Shared/Extensions/WebExtensionWindowIdentifier.h
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWebNavigationCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDynamicScriptsCocoa.mm

  Log Message:
  ---
  IPC decoding fails for some extension API message replies
https://bugs.webkit.org/show_bug.cgi?id=275516
rdar://129546020

Reviewed by Timothy Hatcher, Charlie Wolfe and Brian Weinstein.

If we get a nil mainFrame back from `WebKit::WKWebView:_frames:`, we can get
into a bad state where we create an invalid WebExtensionFrameIdentifier and
pass it back to the completion handler, causing the IPC decoding to fail.
To fix this, we should return early if the mainFrame is nil.

In addition, we should update 
WebExtensionFrameIdentifier::toWebExtensionFrameIdentifier()
to return WebExtensionFrameConstants::NoneIdentifier for invalid results to 
prevent an
invalid identifier from being returned.

Testing:
Verified that the WKWebExtensionWebNavigation.GetAllFrames test doesn't crash in
WebKit::WebExtensionContext::didReceiveMessage if an empty main frame object is 
passed
back from WebPageProxy::getAllFrames().

* Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h:
(WebKit::toWebExtensionFrameIdentifier):
* Source/WebKit/Shared/Extensions/WebExtensionTabIdentifier.h:
(WebKit::toWebExtensionTabIdentifier):
* Source/WebKit/Shared/Extensions/WebExtensionWindowIdentifier.h:
(WebKit::toWebExtensionWindowIdentifier):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWebNavigationCocoa.mm:
(WebKit::WebExtensionContext::webNavigationGetFrame):
(WebKit::WebExtensionContext::webNavigationGetAllFrames):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDynamicScriptsCocoa.mm:
(WebKit::WebExtensionDynamicScripts::executeScript):

Canonical link: https://commits.webkit.org/280048@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e29d3: [WebDriver] If Safari window is not focused, WebDr...

[Qianlang Chen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e29d37be2b6cd98183fd643223f0070f55c913e
  
https://github.com/WebKit/WebKit/commit/3e29d37be2b6cd98183fd643223f0070f55c913e
  Author: Qianlang Chen 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
M Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm

  Log Message:
  ---
  [WebDriver] If Safari window is not focused, WebDriver-automated mouse events 
do not get sent to the page
rdar://117035696
https://bugs.webkit.org/show_bug.cgi?id=275326

Reviewed by Patrick Angle.

When the Safari window is not currently focused, AKA not the key window
using AppKit's terminology, safaridriver-automated mouse events get
sent to the window but not to the webpage within it.

The patch 
https://github.com/WebKit/WebKit/commit/f41c94d11e5a0b8900cf768adeb76d94ef681444#diff-8eae0c0334ee2210a82eef8240463d484f408aceba25aef9f96093c9ca042863
attempted to make the window key, but according to AppKit engineers,
making the window key requires the application to currently be active.
Unfortunately, neither `[NSApplication.sharedApplication activate]` nor
`[NSApplication.sharedApplication activateIgnoringOtherApps:YES]`
actually guarantee activating the app immediately. This results in us
failing to ensure that the window is key before sending the mouse
events, so the mouse events could not get delivered.

   - For `mousemove` events, there is the patch 
https://github.com/WebKit/WebKit/pull/1431
 that make the delivery bypass the window level and sent directly
 into the web view. However, a more recent enhancement 
https://github.com/WebKit/WebKit/pull/17145
 deliberately prevented `mousemove` events from being sent to the
 web page if the page is not active, which effectively nullified the
 former patch for `mousemove` events.

To work around that, a simple solution I found was to give automated
mouse events privileges to bypass certain filtering checks, rather than
always forcing the window to steal input focus. Automated mouse events
are assigned a special, "magic" event number (0), so we can recognize
them in the places below in the code.

I have tested the code
   (1) Manually with Python code using Selenium launching the newly
   compiled safaridriver and seeing that mouse events always get
   delivered successfully
   (2) With `wpt run safari webdriver/tests/classic/element-click 
webdriver/tests/classic/element_send_keys`
   and seeing that the result are the same before and after my
   changes with the same passes and failures.

* Source/WebKit/UIProcess/Automation/WebAutomationSession.h:
* Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::wasEventSynthesizedForAutomation):
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
   - Make the magic event number accessible in other places needing to
 check if an event was synthesized.

* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::acceptsFirstMouse):
   - If the mouse event is automated, bypass the check to let the window
 always accept it.
   - I don't fully understand why this works -- this is a suggestion
 from an AppKit engineer, and I thought this function was meant to
 return whether the mouse event should be deemed as "activating the
 window" versus "activating the window and sent to the contents",
 but apparently it's just whether the event gets sent to the
 contents because automated events still don't activate the window
 regardless the function's return value.

* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::handleMouseEvent):
   - If the mouse event is automated, don't use the enhancement of
 sending the event straight to the scrollbars and still send it
 to the web page.

* Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):
   - Creating the event with eventNumber:0 for testing resulted in the
 event being considered as synthesized and acceptsFirstMouse always
 returned YES. Use a different eventNumber instead as a workaround.

Canonical link: https://commits.webkit.org/280047@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 51b187: Apply more constexpr for offsetOf

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 51b187d9b056f1f00e506ec24d581867db2f24e5
  
https://github.com/WebKit/WebKit/commit/51b187d9b056f1f00e506ec24d581867db2f24e5
  Author: Yusuke Suzuki 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/InternalFunctionAllocationProfile.h
M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
M Source/JavaScriptCore/heap/FreeList.h
M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
M Source/JavaScriptCore/runtime/FunctionExecutable.h
M Source/JavaScriptCore/runtime/FunctionRareData.h
M Source/JavaScriptCore/runtime/JSBigInt.h
M Source/JavaScriptCore/runtime/JSCallee.h
M Source/JavaScriptCore/runtime/JSFunction.h
M Source/JavaScriptCore/runtime/JSObject.h
M Source/JavaScriptCore/runtime/NativeExecutable.h
M Source/WTF/wtf/WeakRandom.h
M Source/WTF/wtf/text/StringImpl.h
M Source/WTF/wtf/text/SymbolImpl.h

  Log Message:
  ---
  Apply more constexpr for offsetOf
https://bugs.webkit.org/show_bug.cgi?id=275512
rdar://129874627

Reviewed by Yijia Huang.

More expansion of constexpr OBJECT_OFFSETOF. And changing some more ASSERT with 
static_assert.

* Source/JavaScriptCore/bytecode/InternalFunctionAllocationProfile.h:
(JSC::InternalFunctionAllocationProfile::offsetOfStructureID):
* Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
* Source/JavaScriptCore/heap/FreeList.h:
(JSC::FreeCell::offsetOfScrambledBits):
* Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::loadMegamorphicProperty):
* Source/JavaScriptCore/runtime/FunctionExecutable.h:
* Source/JavaScriptCore/runtime/FunctionRareData.h:
* Source/JavaScriptCore/runtime/JSBigInt.h:
* Source/JavaScriptCore/runtime/JSCallee.h:
(JSC::JSCallee::offsetOfScopeChain):
* Source/JavaScriptCore/runtime/JSFunction.h:
(JSC::JSFunction::offsetOfExecutableOrRareData):
* Source/JavaScriptCore/runtime/JSObject.h:
(JSC::JSObject::offsetOfInlineStorage):
(JSC::indexRelativeToBase):
* Source/JavaScriptCore/runtime/NativeExecutable.h:
* Source/WTF/wtf/WeakRandom.h:
* Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::flagsOffset):
(WTF::StringImpl::dataOffset):
(WTF::StringImpl::headerSize):
(WTF::StringImpl::tailOffset):
* Source/WTF/wtf/text/SymbolImpl.h:
(WTF::SymbolImpl::SymbolImpl):

Canonical link: https://commits.webkit.org/280046@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 224314: Add more smart pointers to GeoNotifier

[Abigail Fox]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2243143ec5cff20e6b4305a2fb56108779643edc
  
https://github.com/WebKit/WebKit/commit/2243143ec5cff20e6b4305a2fb56108779643edc
  Author: Abigail Fox 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/Modules/geolocation/GeoNotifier.cpp
M Source/WebCore/Modules/geolocation/GeoNotifier.h

  Log Message:
  ---
  Add more smart pointers to GeoNotifier
https://bugs.webkit.org/show_bug.cgi?id=275278
rdar://129419913

Reviewed by Charlie Wolfe.

* Source/WebCore/Modules/geolocation/GeoNotifier.cpp:
(WebCore::GeoNotifier::runSuccessCallback):
(WebCore::GeoNotifier::runErrorCallback):
(WebCore::GeoNotifier::timerFired):
* Source/WebCore/Modules/geolocation/GeoNotifier.h:
(WebCore::GeoNotifier::protectedSuccessCallback):

Canonical link: https://commits.webkit.org/280045@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] efe2c1: git-webkit setup fails if you say no to creating f...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efe2c1b2143c274ffd9d9f425039bf551f8ee5ef
  
https://github.com/WebKit/WebKit/commit/efe2c1b2143c274ffd9d9f425039bf551f8ee5ef
  Author: Brianna Fan 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py

  Log Message:
  ---
  git-webkit setup fails if you say no to creating forks
https://bugs.webkit.org/show_bug.cgi?id=275130
rdar://129174097

Reviewed by Ryan Haddad.

Changes prompt to include informative link and remove "no" option.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.github):

Canonical link: https://commits.webkit.org/280044@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1048a8: [JSC] Clean up Handler IC related conditions

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1048a88392df0f3ea65598cdd94cfc20e4d978b4
  
https://github.com/WebKit/WebKit/commit/1048a88392df0f3ea65598cdd94cfc20e4d978b4
  Author: Yusuke Suzuki 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h

  Log Message:
  ---
  [JSC] Clean up Handler IC related conditions
https://bugs.webkit.org/show_bug.cgi?id=275515
rdar://129877540

Reviewed by Yijia Huang.

1. Remove Options::useHandlerIC() check in generateSlowPathHandler. It is not 
necessary.
2. Make viaGlobalProxy condition solid. We add assertions to make them explicit.
3. Remove unnecessary currStructure condition check in ProxyObjectLoad.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::canBeViaGlobalProxy):
(JSC::InlineCacheCompiler::generateSlowPathHandler):
(JSC::InlineCacheCompiler::generateWithGuard):
(JSC::InlineCacheCompiler::generateAccessCase):
(JSC::InlineCacheCompiler::compileOneAccessCaseHandler):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:

Canonical link: https://commits.webkit.org/280043@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 267386: [Site Isolation] Fix file open panels

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 267386a0cc1cd17e40151cd460520e37e0bbc118
  
https://github.com/WebKit/WebKit/commit/267386a0cc1cd17e40151cd460520e37e0bbc118
  Author: Charlie Wolfe 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.cpp
M Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
M Tools/TestWebKitAPI/cocoa/TestUIDelegate.h
M Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm

  Log Message:
  ---
  [Site Isolation] Fix file open panels
https://bugs.webkit.org/show_bug.cgi?id=275465
rdar://128979437

Reviewed by Aditya Keerthi.

When a file panel is opened, the selected file should be sent to the process 
that opened the panel. Store
a weak pointer to the process that opened the file on 
`WebOpenPanelResultListenerProxy`.

* Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.cpp:
(WebKit::WebOpenPanelResultListenerProxy::WebOpenPanelResultListenerProxy):
(WebKit::WebOpenPanelResultListenerProxy::invalidate):
* Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.h:
(WebKit::WebOpenPanelResultListenerProxy::create):
(WebKit::WebOpenPanelResultListenerProxy::process const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runOpenPanel):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
(WebKit::WebPageProxy::didCancelForOpenPanel):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::siteIsolatedViewAndDelegate):
(TestWebKitAPI::TEST(SiteIsolation, RunOpenPanel)):
(TestWebKitAPI::TEST(SiteIsolation, CancelOpenPanel)):
* Tools/TestWebKitAPI/cocoa/TestUIDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm:
(-[TestUIDelegate 
webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):

Canonical link: https://commits.webkit.org/280042@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 433a23: [Gardening]: REGRESSION(279992@main): [ visionOS ]...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 433a237ec20a20de79fe884c13de77062d687072
  
https://github.com/WebKit/WebKit/commit/433a237ec20a20de79fe884c13de77062d687072
  Author: Marta Darbinyan 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/platform/visionos/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(279992@main): [ visionOS ]  
interaction-region/icon-masking.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=275514
rdar://129876328

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/visionos/TestExpectations:

Canonical link: https://commits.webkit.org/280041@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] adef55: [JSC] Expand IC handler coverage for InHit / InMis...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: adef555a17500963f196a68743515343a9a574ad
  
https://github.com/WebKit/WebKit/commit/adef555a17500963f196a68743515343a9a574ad
  Author: Yusuke Suzuki 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h
M Source/JavaScriptCore/jit/BaselineJITRegisters.h
M Source/JavaScriptCore/jit/JITThunks.h

  Log Message:
  ---
  [JSC] Expand IC handler coverage for InHit / InMiss / InstanceOfHit / 
InstanceOfMiss
https://bugs.webkit.org/show_bug.cgi?id=275509
rdar://129867837

Reviewed by Yijia Huang.

This patch expands IC handler coverage. Adding InHit / InMiss / InstanceOfHit / 
InstanceOfMiss support.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheHandler::createPreCompiled):
(JSC::inByIdInHandlerImpl):
(JSC::inByIdHitHandler):
(JSC::inByIdMissHandler):
(JSC::instanceOfHandlerImpl):
(JSC::instanceOfHitHandler):
(JSC::instanceOfMissHandler):
(JSC::InlineCacheCompiler::compileOneAccessCaseHandler):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:
* Source/JavaScriptCore/jit/BaselineJITRegisters.h:
* Source/JavaScriptCore/jit/JITThunks.h:

Canonical link: https://commits.webkit.org/280040@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5cdf68: Clarify behavior of "status: preview" in UnifiedWe...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cdf683fba132928d2861113d86f05faba026816
  
https://github.com/WebKit/WebKit/commit/5cdf683fba132928d2861113d86f05faba026816
  Author: Aditya Keerthi 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Clarify behavior of "status: preview" in UnifiedWebPreferences.yaml
https://bugs.webkit.org/show_bug.cgi?id=275503

Reviewed by Wenson Hsieh and Abrar Rahman Protyasha.

The existing comment makes it unclear that `preview` features are on
by default in Safari Technology Preview.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Update the comment to make it explicit that `preview` features are enabled in 
STP.

Canonical link: https://commits.webkit.org/280039@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3be5bc: [Site Isolation] Fix custom navigator platform set...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3be5bccc873aa78f4a7574b917b976f156b6dd12
  
https://github.com/WebKit/WebKit/commit/3be5bccc873aa78f4a7574b917b976f156b6dd12
  Author: Charlie Wolfe 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/page/Frame.h
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebCore/page/RemoteFrame.cpp
M Source/WebCore/page/RemoteFrame.h
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  [Site Isolation] Fix custom navigator platform set from website policies
https://bugs.webkit.org/show_bug.cgi?id=275425
rdar://129721017

Reviewed by Pascoe.

Set custom navigator platform on RemoteFrame and use it when the mainframe is 
in another process. This
matches what we do for other website polices.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::navigatorPlatform const):
* Source/WebCore/page/Frame.h:
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::customNavigatorPlatform const):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/RemoteFrame.cpp:
(WebCore::RemoteFrame::customNavigatorPlatform const):
* Source/WebCore/page/RemoteFrame.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::applyWebsitePolicies):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, WebsitePoliciesCustomNavigatorPlatform)):

Canonical link: https://commits.webkit.org/280038@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7406ea: Remove and replace `WKBundlePageIsEditingCommandEn...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7406ea5333e058d9d1864b9ad80dc26ce66e4ed1
  
https://github.com/WebKit/WebKit/commit/7406ea5333e058d9d1864b9ad80dc26ce66e4ed1
  Author: Charlie Wolfe 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPagePrivate.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  ---
  Remove and replace `WKBundlePageIsEditingCommandEnabled`
https://bugs.webkit.org/show_bug.cgi?id=275421
rdar://129712723

Reviewed by Pascoe.

Injected bundle API will not work with site isolation, and 
`WKBundlePageIsEditingCommandEnabled` is only
used by WKTR.

WebKit2 code to call `isEditingCommandEnabled` didn't exist so I needed to add 
it.

This fixes `editing/execCommand/enabling-and-selection-2.html` with 
--site-isolation

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageIsEditingCommandEnabledForTesting):
* Source/WebKit/UIProcess/API/C/WKPagePrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isEditingCommandEnabledForTesting):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageIsEditingCommandEnabled): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::isEditingCommandEnabled):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::isCommandEnabled):
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/280037@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8fef28: [iOS] Several editing pasteboard tests fail when b...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8fef2855838a2286018250ed68dad20cb1cee1f6
  
https://github.com/WebKit/WebKit/commit/8fef2855838a2286018250ed68dad20cb1cee1f6
  Author: Wenson Hsieh 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/platform/ios/PasteboardIOS.mm

  Log Message:
  ---
  [iOS] Several editing pasteboard tests fail when built WebKit is binary 
compatible with system WebKit
https://bugs.webkit.org/show_bug.cgi?id=275494
rdar://129306120

Reviewed by Abrar Rahman Protyasha and Tim Horton.

When running tests on `safari-7618-branch` on iOS, the following 4 layout tests 
fail only in the
case where the built WebKit stack is binary compatible with the system WebKit 
version:

• editing/pasteboard/4930986-1-paste-as-quotation.html
• editing/pasteboard/4930986-2-paste-as-quotation.html
• editing/pasteboard/4930986-3-paste-as-quotation.html
• editing/pasteboard/paste-content-with-overflow-auto-parent-across-origin.html

This happens because since iOS 17.4, `nsattributedstringagent` is launched in 
response to a request
for `com.apple.flat-rtfd` data on the pasteboard in the following case:

1. `com.apple.flat-rtfd` data was not written explicitly to the pasteboard.
2. One or both of `public.html` or `com.apple.webarchive` was explicitly 
written to the pasteboard.

This attributed string agent links against the built WebKit stack via 
`__XPC_DYLD_FRAMEWORK_PATH`,
but because the `__XPC_` prefix only propagates the DYLD framework path 
override to XPC services
launched by `WebKitTestRunnerApp`, the web content process that's launched by 
this attributed string
agent ends up linking against the system WebKit stack instead of the built 
WebKit stack.

Normally, this results in `nsattributedstringagent`'s web content process 
terminating shortly after
launch due to binary incompatibilities with various IPC message identifiers, 
which causes code in
`PasteboardIOS.mm` that requests flat RTFD data from the pasteboard to fail 
(and return 0 bytes) in
the case where there's only `text/html` data on the pasteboard (and the flat 
RTFD data is therefore
synthesized by system frameworks). This, in turn, effectively disables the new 
UIKit pasteboard
attributed string coercion codepaths introduced in iOS 17.4, causes us to just 
read the raw
`text/html`, and thus allows the tests to pass because the round trip from 
markup to attributed
string and back would otherwise drops the `apple-style-span` class attribute.

However, if (by some miracle) the built WebKit stack is binary compatible 
enough with the system
version of WebKit that attributed string conversion succeeds, we end up reading 
an attributed string
from the system pasteboard in this case, which leads to different results due 
to the round tripping.

While it's not great that round tripping loses `apple-style-span`, it's also 
pretty bad (for
performance as well as testing sanity) that we even try to use 
`nsattributedstringagent` in this
scenario, since the HTML or web archive data already has full fidelity. To fix 
this, we instead
detect that the pasteboard contains a payload that we (WebKit) wrote ourselves 
when copying web
content, and use that as a hint to prefer HTML and web archive data over either 
RTF or flat RTFD.
Since any RTF/flat RTFD content we write to the pasteboard is derived from web 
content anyways, the
HTML and web archive representation will always be higher fidelity than their 
TextKit counterparts.

* Source/WebCore/platform/ios/PasteboardIOS.mm:
(WebCore::isTypeAllowedByReadingPolicy):

Also adopt `UniformTypeIdentifiers.framework` in a few more places while I'm 
refactoring this code,
to fix some would-be deprecation warnings due to using `kUTType*`.

(WebCore::supportedWebContentPasteboardTypesWhenCustomDataIsPresent):
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::supportedWebContentPasteboardTypes):

Canonical link: https://commits.webkit.org/280036@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 62a896: Relax privacy for some log messages in LinearMedia...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62a8966b7a0e6ce0a0c19938c0504c08922bdf54
  
https://github.com/WebKit/WebKit/commit/62a8966b7a0e6ce0a0c19938c0504c08922bdf54
  Author: Andy Estes 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift

  Log Message:
  ---
  Relax privacy for some log messages in LinearMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=275505
rdar://129866471

Reviewed by Geoffrey Garen.

For log strings that do not reveal privacy-sensitive information, mark them as 
publibly visible to
make bug reports more actionable.

* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift:
(WKSLinearMediaPlayer.presentationStateChanged(_:)):
(WKSLinearMediaPlayer.setCaptionContentInsets(_:)):
(WKSLinearMediaPlayer.updateVideoBounds(_:)):
(WKSLinearMediaPlayer.toggleInlineMode):
(WKSLinearMediaPlayer.willEnterFullscreen):
(WKSLinearMediaPlayer.willExitFullscreen):
(WKSLinearMediaPlayer.setThumbnailSize(_:)):

Canonical link: https://commits.webkit.org/280035@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 02b1ca: Upstream Writing Tools Animations.

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02b1ca3eb7f20fac332f9a1d5fa3fcec3e569f25
  
https://github.com/WebKit/WebKit/commit/02b1ca3eb7f20fac332f9a1d5fa3fcec3e569f25
  Author: Megan Gardner 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/Configurations/WebKitSwift.xcconfig
M Source/WebKit/DerivedSources.make
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WKSTextStyleManager.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h
M Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A Source/WebKit/WebKitSwift/TextIndicatorStyle/TextStyleManager.swift
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebPage/Cocoa/TextIndicatorStyleController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/TextIndicatorStyleController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  ---
  Upstream Writing Tools Animations.
https://bugs.webkit.org/show_bug.cgi?id=275411
rdar://129697392

Reviewed by Richard Robinson.

* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.mm:
(-[WKTextIndicatorStyleEffectData initWithEffectID:type:]):
(-[WKTextIndicatorStyleEffectData effectID]):
(-[WKTextIndicatorStyleManager initWithWebViewImpl:]):
(-[WKTextIndicatorStyleManager addTextIndicatorStyleForID:withData:]):
(-[WKTextIndicatorStyleManager removeTextIndicatorStyleForID:]):
(-[WKTextIndicatorStyleManager hasActiveTextIndicatorStyle]):
(-[WKTextIndicatorStyleManager suppressTextIndicatorStyle]):
(-[WKTextIndicatorStyleManager restoreTextIndicatorStyle]):
(-[WKTextIndicatorStyleManager textPreviewsForChunk:completion:]):
(-[WKTextIndicatorStyleManager textPreviewForRect:completion:]):
(-[WKTextIndicatorStyleManager updateIsTextVisible:forChunk:completion:]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebKitSwift/TextIndicatorStyle/TextStyleManager.swift: Added.
(currentEffect):
(delegate):
(beginEffect(for:style:)):
(endEffect(for:)):
(TextStyleManager.targetedPreview(for:)):
(TextStyleManager.updateTextChunkVisibilityForAnimation(_:visible:)):
(TextStyleManager.performReplacementAndGeneratePreview(for:effect:animation:)):
(TextStyleManager.replacementEffectDidComplete(_:)):

Canonical link: https://commits.webkit.org/280034@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 682ac4: Upgrade GCC requirement to 11.2.0

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 682ac4ba74c53d0cd488c7a595096224a9abb036
  
https://github.com/WebKit/WebKit/commit/682ac4ba74c53d0cd488c7a595096224a9abb036
  Author: Abrar Rahman Protyasha 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/cmake/WebKitCommon.cmake

  Log Message:
  ---
  Upgrade GCC requirement to 11.2.0
https://bugs.webkit.org/show_bug.cgi?id=275507
rdar://129866801

Reviewed by Yusuke Suzuki.

This patch bumps the minimum required GCC version to 11.2.0.

Based on the WebKitGTK dependency policy [1], support for Debian Bullseye
ended on 6/10/24. This means that we can now cater to the default GCC
version for Ubuntu 22.04 LTS as our minimum, which happens to be 11.2.0.
We plan to support this version till 4/25/25.

This version bump allows us to start building the WebKit against the C++23
standard, which we are tracking in bug webkit.org/b/263122.

[1]: 
https://docs.webkit.org/Ports/WebKitGTK%20and%20WPE%20WebKit/DependenciesPolicy.html

* Source/cmake/WebKitCommon.cmake:

Canonical link: https://commits.webkit.org/280033@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c318c5: [tvOS] Enable support for date/time inputs

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c318c532f82476f1e252bbca8614c8f87936c725
  
https://github.com/WebKit/WebKit/commit/c318c532f82476f1e252bbca8614c8f87936c725
  Author: Aditya Keerthi 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  [tvOS] Enable support for date/time inputs
https://bugs.webkit.org/show_bug.cgi?id=275497
rdar://127010418

Reviewed by Wenson Hsieh.

The requisite APIs used to support date/time inputs on iOS are available on
tvOS. Enable the input types on tvOS for platform parity.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/280032@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a011ce: [Navigation] Set formData on NavigateEvent

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a011cec5b59d3e65a221b31391260b32ddde3477
  
https://github.com/WebKit/WebKit/commit/a011cec5b59d3e65a221b31391260b32ddde3477
  Author: Patrick Griffis 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-reload-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-requestSubmit-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-traverse-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-userInitiated-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-with-target-expected.txt
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/page/History.cpp
M Source/WebCore/page/Navigation.cpp
M Source/WebCore/page/Navigation.h

  Log Message:
  ---
  [Navigation] Set formData on NavigateEvent
https://bugs.webkit.org/show_bug.cgi?id=274561

Reviewed by Ryan Reno.

This includes form data in all push/replace events on same-origin-domain form 
submissions.

The two failing navigation tests are passes except for the navigation type 
which is an unrelated issue.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-reload-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-requestSubmit-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-traverse-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-userInitiated-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-with-target-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::dispatchNavigateEvent):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/page/History.cpp:
(WebCore::History::stateObjectAdded):
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::innerDispatchNavigateEvent):
(WebCore::Navigation::dispatchPushReplaceReloadNavigateEvent):
* Source/WebCore/page/Navigation.h:

Canonical link: https://commits.webkit.org/280031@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a9760: fast/forms/ios/focus-input-via-button.html needs b...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a9760bb77c85520560e04483022b28cbd127f78
  
https://github.com/WebKit/WebKit/commit/2a9760bb77c85520560e04483022b28cbd127f78
  Author: Ben Schwartz 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/fast/forms/ios/focus-input-via-button-expected.txt
R 
LayoutTests/platform/ios/fast/forms/ios/focus-input-via-button-expected.txt
R 
LayoutTests/platform/ios/platform/ipad/fast/forms/focus-input-via-button-expected.txt

  Log Message:
  ---
  fast/forms/ios/focus-input-via-button.html needs baselines tidied.
https://bugs.webkit.org/show_bug.cgi?id=275504
rdar://129866027

Unreviewed test re-baseline.

Tidying baselines for this test.

* LayoutTests/fast/forms/ios/focus-input-via-button-expected.txt:
* LayoutTests/platform/ios/fast/forms/ios/focus-input-via-button-expected.txt: 
Removed.
* 
LayoutTests/platform/ios/platform/ipad/fast/forms/focus-input-via-button-expected.txt:
 Removed.

Canonical link: https://commits.webkit.org/280030@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 292a91: Crash in WebKit::WebViewImpl::isInWindowFullscreen...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 292a91632ec8b48d97e9fc5e82624661d5c0910c
  
https://github.com/WebKit/WebKit/commit/292a91632ec8b48d97e9fc5e82624661d5c0910c
  Author: Eric Carlson 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  ---
  Crash in WebKit::WebViewImpl::isInWindowFullscreenActive
https://bugs.webkit.org/show_bug.cgi?id=275445
rdar://126704332

Reviewed by Andy Estes.

Always null-check `WebPageProxy.playbackSessionManager()` because
there is no guarantee that it is valid.

* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::protectedPlaybackSessionInterface):
(WebKit::WebViewImpl::isInWindowFullscreenActive const):
(WebKit::WebViewImpl::toggleInWindowFullscreen):
(WebKit::WebViewImpl::updateMediaPlaybackControlsManager):

Canonical link: https://commits.webkit.org/280029@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 421ec2: RE-BASELINE: [ iOS ] imported/w3c/web-platform-tes...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 421ec258d76bff6a2b0e28619ee25de078c02b97
  
https://github.com/WebKit/WebKit/commit/421ec258d76bff6a2b0e28619ee25de078c02b97
  Author: Ben Schwartz 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M LayoutTests/platform/ipad/TestExpectations
M 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

  Log Message:
  ---
  RE-BASELINE: [ iOS ] 
imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is 
constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=275499
rdar://129862265

Unreviewed test re-baseline.

Re-baselining constantly failing test due to new pass messages in output.

* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ipad/TestExpectations:
* 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Canonical link: https://commits.webkit.org/280028@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cd6cad: [view-transitions] Support `:active-view-transitio...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd6cadf233ddb2004ebe63d1959b1b2896236b59
  
https://github.com/WebKit/WebKit/commit/cd6cadf233ddb2004ebe63d1959b1b2896236b59
  Author: Tim Nguyen 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/active-view-transition-pseudo-class-match-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/active-view-transition-pseudo-class-match.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-universal-match-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-universal-match.html
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/css/SelectorChecker.cpp
M Source/WebCore/css/SelectorCheckerTestFunctions.h
M Source/WebCore/cssjit/SelectorCompiler.cpp
M Source/WebCore/dom/Document.cpp

  Log Message:
  ---
  [view-transitions] Support `:active-view-transition` pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=275488
rdar://129851076

Reviewed by Darin Adler.

This is part of the level 2 spec: 
https://drafts.csswg.org/css-view-transitions-2/#the-active-view-transition-pseudo

This matches anytime there is an active view transition on the document.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/active-view-transition-pseudo-class-match-expected.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-universal-match-expected.html.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/active-view-transition-pseudo-class-match.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-universal-match.html.
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesActiveViewTransitionPseudoClass):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::JSC_DEFINE_NOEXCEPT_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::setActiveViewTransition):

Canonical link: https://commits.webkit.org/280027@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c367f: REGRESSION (UI-side compositing) Disabled scrollba...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c367f97364c91adb1982fe3ede5bfd7b0fa6940
  
https://github.com/WebKit/WebKit/commit/5c367f97364c91adb1982fe3ede5bfd7b0fa6940
  Author: Nikolaos Mouchtaris 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/css3/scroll-snap/nested-elements-expected.txt
M LayoutTests/css3/scroll-snap/nested-elements.html
M 
LayoutTests/fast/scrolling/mac/scrollbars/scrollbars-controller-type-expected.txt
M LayoutTests/fast/scrolling/mac/scrollbars/scrollbars-controller-type.html
A LayoutTests/platform/ios/css3/scroll-snap/nested-elements-expected.txt
M 
LayoutTests/platform/mac-ventura-wk2/fast/scrolling/mac/scrollbars/scrollbars-controller-type-expected.txt
M Source/WebCore/testing/Internals.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

  Log Message:
  ---
  REGRESSION (UI-side compositing) Disabled scrollbars don't show in some cases
https://bugs.webkit.org/show_bug.cgi?id=261295
rdar://115137778

Reviewed by Simon Fraser.

For the case where we need to show disabled scrollbars on a scroller without a 
layer we need
to have the scrollbars controller of type ScrollbarsControllerMac, so that we 
can create
a temporary NSScrollerImp in the web process to display the disabled scrollbars 
(similar to
what we do for svg foreign object, etc.). However, the previous fix checked 
usesAsyncScrolling
to determine this, but it is better to check usesCompositedScrolling (as for 
this case
usesAsyncScrolling returns true even when we don't have a layer). For the 
normal case we will
properly update the scrollbars controller type to RemoteScrollbarsController 
for when the layer
is made, and for this case where the layer isn't made, we will properly use 
ScrollbarsControllerMac.

* 
LayoutTests/fast/scrolling/mac/scrollbars/scrollbars-controller-type-expected.txt:
* LayoutTests/fast/scrolling/mac/scrollbars/scrollbars-controller-type.html:
* Source/WebCore/platform/ScrollableArea.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore:: const):
(WebCore::Internals::scrollbarsControllerTypeForNode const):
* Source/WebCore/testing/Internals.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::ensureScrollbarsController const):

Canonical link: https://commits.webkit.org/280026@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2ba7aa: Fix for Mac Builds with INTERACTION_REGIONS_IN_EVE...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ba7aa7e093f16512f933ba4c161edcdab869ac0
  
https://github.com/WebKit/WebKit/commit/2ba7aa7e093f16512f933ba4c161edcdab869ac0
  Author: Megan Gardner 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  ---
  Fix for Mac Builds with INTERACTION_REGIONS_IN_EVENT_REGION turned on.
https://bugs.webkit.org/show_bug.cgi?id=275495
rdar://129859381

Reviewed by Tim Horton.

This code was behind #if ENABLE(SCROLLING_THREAD) which is only
true on mac, so this path was not complied in normal workflows.

* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollLayerClipping):

Canonical link: https://commits.webkit.org/280025@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3664d7: Prefer videoBinned camera presets in case resizing...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3664d7d244e0924b68bd6fd9b24f0f6aa3a7821a
  
https://github.com/WebKit/WebKit/commit/3664d7d244e0924b68bd6fd9b24f0f6aa3a7821a
  Author: Youenn Fablet 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M 
LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt
A LayoutTests/fast/mediastream/camera-powerEfficient-track-expected.txt
A LayoutTests/fast/mediastream/camera-powerEfficient-track.html
M LayoutTests/fast/mediastream/getUserMedia-video-rescaling.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.h
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl
M Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h
M Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl
M Source/WebCore/platform/mediastream/MediaConstraintType.cpp
M Source/WebCore/platform/mediastream/MediaConstraintType.h
M Source/WebCore/platform/mediastream/MediaConstraints.cpp
M Source/WebCore/platform/mediastream/MediaConstraints.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M 
Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
M Source/WebCore/platform/mediastream/VideoPreset.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
M Source/WebCore/platform/mock/MockMediaDevice.h
M Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h

  Log Message:
  ---
  Prefer videoBinned camera presets in case resizing is needed
https://bugs.webkit.org/show_bug.cgi?id=275317
rdar://129506159

Reviewed by Eric Carlson.

In case we select a preset that might require downsampling, it is good to favor 
binned presets as this is better for power efficiency.
Previously, we were favoring videoBinned presets if they were closer to the 
final size.

We can be more aggressive than that and favor videoBinned presets even if they 
are further from the final size.
We still try to select the smallest possible videoBinned preset.
This is implemented in RealtimeVideoCaptureSource.

As video binned format may not always be the best preset, we use the 
powerEfficientPixelFormat as a constraint that can be given to 
getUserMedia/applyConstraints
to aggressively select binned presets.
We do not expose settings and capabilities for this constraint since we only 
use it as a hint that the web application is wanting power efficiency.

We update some code to allow testing this feature.
We add a isEfficient field to VideoPreset so that we can mock efficient presets.
We have one such mock preset (environment camera, 1920 x 1080) that we use for 
testing.

We add the infrastructure to check whether a given capture track is power 
efficient or not.

We have to update 
LayoutTests/fast/mediastream/getUserMedia-video-rescaling.html given it will 
now favor 1920x1080 preset, which is 16/9.

* 
LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt:
* LayoutTests/fast/mediastream/camera-powerEfficient-track-expected.txt: Added.
* LayoutTests/fast/mediastream/camera-powerEfficient-track.html: Added.
* LayoutTests/fast/mediastream/getUserMedia-video-rescaling.html:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::hasInvalidGetDisplayMediaConstraint):
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp:
(WebCore::convertToInternalForm):
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.h:
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl:
* Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h:
* Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl:
* Source/WebCore/platform/mediastream/MediaConstraintType.cpp:
(WebCore::conve

[webkit-changes] [WebKit/WebKit] c3b614: Unreviewed, bump WebCore.xcodeproj `objectVersion`...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3b6149c2cdfad5aea3f46592a87e74067320aba
  
https://github.com/WebKit/WebKit/commit/c3b6149c2cdfad5aea3f46592a87e74067320aba
  Author: Wenson Hsieh 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  ---
  Unreviewed, bump WebCore.xcodeproj `objectVersion` back up to 55

This was unintentionally reverted as a part of 
https://commits.webkit.org/279983@main.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/280023@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5554cf: UI process crash when network process connection r...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5554cf00d1f4a9d5daf0144d141168e1f4b84800
  
https://github.com/WebKit/WebKit/commit/5554cf00d1f4a9d5daf0144d141168e1f4b84800
  Author: Kimmo Kinnunen 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebProcess.cpp

  Log Message:
  ---
  UI process crash when network process connection request arrives before 
settings have been initialized
https://bugs.webkit.org/show_bug.cgi?id=275435
rdar://129587532

Reviewed by Cameron McCormack.

Mark sendSync of GetNetworkProcessConnection as
MaintainOrderingWithAsyncMessages so that previous messages are
guaranteed to be delivered. The previous messages might initialize the
network process settings that are needed to establish the connection.

* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::getNetworkProcessConnection):

Canonical link: https://commits.webkit.org/280022@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 91923f: [Style guide] #spacing-braced-init section is wrap...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91923f457f0bbd0d9299fc92cdc2a5e7d3652bf6
  
https://github.com/WebKit/WebKit/commit/91923f457f0bbd0d9299fc92cdc2a5e7d3652bf6
  Author: Abrar Rahman Protyasha 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Websites/webkit.org/code-style.md

  Log Message:
  ---
  [Style guide] #spacing-braced-init section is wrapped in an unterminated code 
block
https://bugs.webkit.org/show_bug.cgi?id=275477
rdar://129835603

Reviewed by Megan Gardner, Wenson Hsieh and Tim Horton.

This patch addresses the issue reported in the title by correctly
terminating the code block corresponding to the section before
`#spacing-braced-init`.

* Websites/webkit.org/code-style.md:

Canonical link: https://commits.webkit.org/280021@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dcc6c1: Prevent crash when calling [AVCaptureSession init]...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcc6c1646e3a0cc654c7cf3210536bc05c05e6e5
  
https://github.com/WebKit/WebKit/commit/dcc6c1646e3a0cc654c7cf3210536bc05c05e6e5
  Author: Youenn Fablet 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

  Log Message:
  ---
  Prevent crash when calling [AVCaptureSession init] in AVVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=275476
rdar://129801303

Reviewed by Eric Carlson.

We partially revert https://commits.webkit.org/277415@main, as it reintroduce 
the crash for safari view services.
We disable the checks specifically for iOS simulator, since there is no support 
for media endowments.

* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::startProducingData):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::startProducingData):

Canonical link: https://commits.webkit.org/280020@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87c0d5: Add SYSTEM_VERSION_PREFIX for macOS 15

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87c0d5ce9f67b8d2d4cf5454a603cc326b9d36d9
  
https://github.com/WebKit/WebKit/commit/87c0d5ce9f67b8d2d4cf5454a603cc326b9d36d9
  Author: David Kilzer 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Add SYSTEM_VERSION_PREFIX for macOS 15



Unreviewed build configuration fix.

* Configurations/Version.xcconfig:
(SYSTEM_VERSION_PREFIX_macosx_15): Add.

Canonical link: https://commits.webkit.org/280019@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e873e2: [JSC] Do not modify valueRegs until we no longer j...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e873e2350b35c3ef93c9308b94b3fdd1ff887b25
  
https://github.com/WebKit/WebKit/commit/e873e2350b35c3ef93c9308b94b3fdd1ff887b25
  Author: Yusuke Suzuki 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp

  Log Message:
  ---
  [JSC] Do not modify valueRegs until we no longer jump to failure path
https://bugs.webkit.org/show_bug.cgi?id=275470
rdar://129820423

Reviewed by Yijia Huang and Justin Michaud.

The failure path of IC is expecting that valueRegs is not overridden in split 
Handler IC.
This patch fixes it for ModuleNamespaceLoad case.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::emitModuleNamespaceLoad):

Canonical link: https://commits.webkit.org/280018@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 86c191: [ANGLE] Protect from faulty GPU drivers, reporting...

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86c1918fdd79715f17cf6bbf161cdda598882198
  
https://github.com/WebKit/WebKit/commit/86c1918fdd79715f17cf6bbf161cdda598882198
  Author: Nikolas Zimmermann 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/FunctionsGL.cpp

  Log Message:
  ---
  [ANGLE] Protect from faulty GPU drivers, reporting nullptr as GL_EXTENSION 
string
https://bugs.webkit.org/show_bug.cgi?id=275481

Reviewed by Kimmo Kinnunen and Adrian Perez de Castro.

On a particular i.MX8 board any WebGL demo crashes in ANGLE initialization,
reporting a nullptr instead of a proper null-terminated string, when calling
getStringIFunction(GL_EXTENSIONS, i) in libANGLEs GetIndexExtensions() method
in renderer/gl/FunctionsGL.cpp. Null-check the string before trying to
wrap it in a std::string.

Covered by any WebGL test/demo on a certain i.MX8 board.

* Source/ThirdParty/ANGLE/changes.diff:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/FunctionsGL.cpp:
(rx::GetIndexedExtensions):

Canonical link: https://commits.webkit.org/280016@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 98bf92: REGRESSION(279372@main): Blank space and offset cl...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98bf925cf7976055188f853dfc9b5ef10c3e013f
  
https://github.com/WebKit/WebKit/commit/98bf925cf7976055188f853dfc9b5ef10c3e013f
  Author: Tim Nguyen 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/reset-state-after-scrolled-view-transition-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/reset-state-after-scrolled-view-transition-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/reset-state-after-scrolled-view-transition.html
M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  ---
  REGRESSION(279372@main): Blank space and offset clicks after running a view 
transition on a scrolled page
https://bugs.webkit.org/show_bug.cgi?id=275335
rdar://129528943

Reviewed by Alan Baradlay.

`RenderLayerBacking::updateTransform` adds a transform on the RenderView 
graphics layer when a view transition is running.

We however forget to clean it up when the transition ends. This requires a 
geometry update. Call `view().layer()->setNeedsCompositingGeometryUpdate()` to 
notify that one is needed.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/reset-state-after-scrolled-view-transition-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/reset-state-after-scrolled-view-transition-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/reset-state-after-scrolled-view-transition.html:
 Added.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::setCapturedInViewTransition):

Canonical link: https://commits.webkit.org/280017@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7d9f0: Constructible EventTarget does create a path durin...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7d9f018702caa871efc4dd4d1d6f04e05908373
  
https://github.com/WebKit/WebKit/commit/c7d9f018702caa871efc4dd4d1d6f04e05908373
  Author: Anne van Kesteren 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-dispatch-single-activation-behavior-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-dispatch-single-activation-behavior.html
M 
LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-constructible.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-constructible.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-constructible.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/dom/events/event-global-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/dom/events/event-global.html
A 
LayoutTests/imported/w3c/web-platform-tests/dom/events/pointer-event-document-move-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/dom/events/pointer-event-document-move.html
A 
LayoutTests/imported/w3c/web-platform-tests/dom/events/remove-all-listeners-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/dom/events/remove-all-listeners.html
M LayoutTests/imported/w3c/web-platform-tests/dom/events/w3c-import.log
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/dom/events/Event-dispatch-single-activation-behavior-expected.txt
A 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/pointer-event-document-move-expected.txt
M Source/WebCore/dom/EventTarget.cpp

  Log Message:
  ---
  Constructible EventTarget does create a path during dispatch
https://bugs.webkit.org/show_bug.cgi?id=275404

Reviewed by Wenson Hsieh.

Initialize the path in EventTarget::dispatchEvent. Also synchronize WPT
dom/events (but not dom/events/scrolling) up to this commit:
https://github.com/web-platform-tests/wpt/commit/33bd9cc8426a14d378cd6b6e4d314f18c7af7773

* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-dispatch-single-activation-behavior-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-dispatch-single-activation-behavior.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-constructible.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-constructible.any.js:
(test.listener):
(test):
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-constructible.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/event-global-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/event-global.html:
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/pointer-event-document-move-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/pointer-event-document-move.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/remove-all-listeners-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/dom/events/remove-all-listeners.html:
 Added.
* LayoutTests/imported/w3c/web-platform-tests/dom/events/w3c-import.log:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/dom/events/Event-dispatch-single-activation-behavior-expected.txt:
 Added.
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/pointer-event-document-move-expected.txt:
 Added.
* Source/WebCore/dom/EventTarget.cpp:
(WebCore::EventTarget::dispatchEvent):

Canonical link: https://commits.webkit.org/280014@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fa3668: Adopt smart pointers to glib related code

[Mikhail R. Gadelha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa36680627bf7c079a0d1f1b88b171889342af25
  
https://github.com/WebKit/WebKit/commit/fa36680627bf7c079a0d1f1b88b171889342af25
  Author: Mikhail R. Gadelha 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/JavaScriptCore/API/glib/JSCClass.cpp
M Source/JavaScriptCore/API/glib/JSCContext.cpp
M Source/JavaScriptCore/API/glib/JSCException.cpp
M Source/JavaScriptCore/API/glib/JSCValue.cpp
M Source/JavaScriptCore/API/glib/JSCWeakValue.cpp
M Source/JavaScriptCore/API/glib/JSCWrapperMap.cpp
M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp
M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp
M Source/WTF/wtf/glib/RunLoopGLib.cpp
M Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp
M Source/WebKit/UIProcess/API/glib/WebKitBackForwardList.cpp
M Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp
M Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp
M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp
M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
M Source/WebKit/UIProcess/API/glib/WebKitSecurityManager.cpp
M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
M Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebResourceLoadManager.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.cpp
M 
Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebHitTestResult.cpp
M Source/WebKit/WebProcess/WebCoreSupport/glib/WebEditorClientGLib.cpp
M Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp

  Log Message:
  ---
  Adopt smart pointers to glib related code
https://bugs.webkit.org/show_bug.cgi?id=274898

Reviewed by Carlos Garcia Campos.

This patch changes glib related code in WebKit to
use smart pointers

* Source/JavaScriptCore/API/glib/JSCClass.cpp:
(getProperty):
(setProperty):
(hasProperty):
(deleteProperty):
(getPropertyNames):
(jscClassCreate):
(jscClassCreateConstructor):
(jscClassAddMethod):
* Source/JavaScriptCore/API/glib/JSCContext.cpp:
(jscContextPushCallback):
(jscContextPopCallback):
(jscContextGarbageCollect):
(jsc_context_evaluate_in_object):
(jsc_context_check_syntax):
* Source/JavaScriptCore/API/glib/JSCException.cpp:
(jscExceptionCreate):
* Source/JavaScriptCore/API/glib/JSCValue.cpp:
(jsc_value_object_enumerate_properties):
(jsc_value_object_define_property_data):
(jscValueObjectDefinePropertyAccessor):
(jscValueFunctionCreate):
(jsc_value_is_array_buffer):
(jsc_value_typed_array_get_type):
* Source/JavaScriptCore/API/glib/JSCWeakValue.cpp:
(jsc_weak_value_get_value):
* Source/JavaScriptCore/API/glib/JSCWrapperMap.cpp:
(JSC::WrapperMap::registerClass):
(JSC::WrapperMap::createJSWrapper):
* Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::sendMessageToTarget):
* Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::setTargetList):
(Inspector::RemoteInspectorServer::setupInspectorClient):
(Inspector::RemoteInspectorServer::connectionDidClose):
(Inspector::RemoteInspectorServer::sendMessageToFrontend):
* Source/WTF/wtf/glib/RunLoopGLib.cpp:
(WTF::RunLoop::run):
* Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp:
(webkitAutomationSessionCreate):
* Source/WebKit/UIProcess/API/glib/WebKitBackForwardList.cpp:
(webkitBackForwardListCreateList):
* Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:
(webkit_cookie_manager_set_persistent_storage):
(webkit_cookie_manager_set_accept_policy):
* Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_mime_types):
(webkit_file_chooser_request_get_selected_files):
* Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp:
(webkit_network_session_set_itp_enabled):
(webkit_network_session_get_itp_enabled):
(webkit_network_session_set_persistent_credential_storage_enabled):
(webkit_network_session_get_persistent_credential_storage_enabled):
(webkit_network_session_set_tls_errors_policy):
(webkit_network_session_allow_tls_certificate_for_host):
(webkit_network_session_set_proxy_settings):
(webkit_network_session_get_itp_summary):
(webkit_network_session_prefetch_dns):
(webkit_network_session_download_uri):
* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU):
* Source/WebKit/UIProcess/API/glib/WebKitSecurityManager.cpp:
(registerSecurityPolicyForURIScheme):
* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsConstructed):
* Source/WebKit/UIProcess/API/gli

[webkit-changes] [WebKit/WebKit] 883886: Crash under RenderObject::createVisiblePosition() ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 883886ee70ad3953b2e7e3bf6a079897bc76adcd
  
https://github.com/WebKit/WebKit/commit/883886ee70ad3953b2e7e3bf6a079897bc76adcd
  Author: Alan Baradlay 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/page/EventHandler.cpp

  Log Message:
  ---
  Crash under RenderObject::createVisiblePosition() while dragging the volume 
scrubber on a video player
https://bugs.webkit.org/show_bug.cgi?id=275469


Reviewed by Antti Koivisto.

1. In EventHandler::mouseDragged we dispatch the "mouse move" event
2. JS triggers some mutation which makes the tree dirty
3. later in EventHandler::handleMouseMoveEvent() we call 
EventHandler::handleMouseDraggedEvent() (tree is dirty)
   which, through a few layers of functions calls 
VisiblePosition::canonicalPosition()
4. VisiblePosition::canonicalPosition() needs a clean tree so it calls 
Document::updateLayout() which is turn destroys some renderers (see #2)
5. In-between EventHandler::handleMouseDraggedEvent() and 
VisiblePosition::canonicalPosition(), we CheckPtr a renderer which gets 
destroyed at #4.

The fix (what we normally do with cases like this) is to make sure we clean the 
tree before entering VisiblePosition.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):

Canonical link: https://commits.webkit.org/280013@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea9223: [content-visibility] Crash under RenderTableSectio...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea9223dccf8a71f370756f6f750692db05b374df
  
https://github.com/WebKit/WebKit/commit/ea9223dccf8a71f370756f6f750692db05b374df
  Author: Alan Baradlay 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
A 
LayoutTests/fast/dynamic/content-visibility-crash-with-continuation-and-table-expected.txt
A 
LayoutTests/fast/dynamic/content-visibility-crash-with-continuation-and-table.html
M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  ---
  [content-visibility] Crash under RenderTableSection::paintObject when 
continuation is present
https://bugs.webkit.org/show_bug.cgi?id=275463


Reviewed by Antti Koivisto.

See FIXME comment in RenderTable::paint.

* 
LayoutTests/fast/dynamic/content-visibility-crash-with-continuation-and-table-expected.txt:
 Added.
* 
LayoutTests/fast/dynamic/content-visibility-crash-with-continuation-and-table.html:
 Added.
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):

Canonical link: https://commits.webkit.org/280011@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b4480d: [WPE] WPE Platform: fix toplevel states iteration

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4480d067d938cb956a90ae3cdb81874a145126c
  
https://github.com/WebKit/WebKit/commit/b4480d067d938cb956a90ae3cdb81874a145126c
  Author: Carlos Garcia Campos 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp

  Log Message:
  ---
  [WPE] WPE Platform: fix toplevel states iteration
https://bugs.webkit.org/show_bug.cgi?id=275478

Reviewed by Nikolas Zimmermann.

The size of a wl_array is in bytes, not in amount of items.

* Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp:

Canonical link: https://commits.webkit.org/280012@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f3b78a: [WGSL] Type::size should work for primitive structs

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3b78a0f53405ce4616815e5b8c56001bf2c7f68
  
https://github.com/WebKit/WebKit/commit/f3b78a0f53405ce4616815e5b8c56001bf2c7f68
  Author: Tadeu Zagallo 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebGPU/WGSL/Types.cpp
M Source/WebGPU/WGSL/tests/valid/struct.wgsl

  Log Message:
  ---
  [WGSL] Type::size should work for primitive structs
https://bugs.webkit.org/show_bug.cgi?id=275444
rdar://129771751

Reviewed by Mike Wyrzykowski.

Originally Type::size was only used for calculating the size of resources, so
only types that could used for resources were supported. As of 279876@main it's
also used to get the size of local variables, which can also be primitive 
structs.

* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::size const):
* Source/WebGPU/WGSL/tests/valid/struct.wgsl:

Canonical link: https://commits.webkit.org/280010@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 635b36: [WPE] WPE Platform: add none IM context implementa...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 635b3690eaea76a04a790a5ca8b8eb99d7191f0d
  
https://github.com/WebKit/WebKit/commit/635b3690eaea76a04a790a5ca8b8eb99d7191f0d
  Author: Carlos Garcia Campos 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/WPEPlatform/CMakeLists.txt
M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp
M Source/WebKit/WPEPlatform/wpe/WPEInputMethodContext.cpp
A Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.cpp
A Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.h
M Source/WebKit/WPEPlatform/wpe/WPEView.cpp

  Log Message:
  ---
  [WPE] WPE Platform: add none IM context implementation as fallback
https://bugs.webkit.org/show_bug.cgi?id=275480

Reviewed by Nikolas Zimmermann.

We don't want object new methods that can return nullptr, so better
have a None implementation used as fallback for platforms not implementing IME.
Also make create_view mandatory for the same reason, but in this case
all platform implementations are expected to implement WPEView.

* Source/WebKit/WPEPlatform/CMakeLists.txt:
* Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp:
(wpeDisplayCreateView):
(wpeDisplayCreateInputMethodContext):
* Source/WebKit/WPEPlatform/wpe/WPEInputMethodContext.cpp:
* Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.cpp: Added.
(wpeInputMethodContextNoneGetPreeditString):
(wpe_input_method_context_none_class_init):
(wpeInputMethodContextNoneNew):
* Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.h: Added.
* Source/WebKit/WPEPlatform/wpe/WPEView.cpp:

Canonical link: https://commits.webkit.org/280009@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 120f5b: [Skia] Fix corner cases involving drawing shadows

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 120f5b1d4f902ccd085929982aa6d9cf6bb8a4fb
  
https://github.com/WebKit/WebKit/commit/120f5b1d4f902ccd085929982aa6d9cf6bb8a4fb
  Author: Pawel Lampe 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
A 
LayoutTests/fast/canvas/canvas-composite-fill-with-shadow-and-fitting-perfectly-expected.txt
A 
LayoutTests/fast/canvas/canvas-composite-fill-with-shadow-and-fitting-perfectly.html
A LayoutTests/fast/canvas/canvas-composite-fill-with-shadow-expected.txt
A LayoutTests/fast/canvas/canvas-composite-fill-with-shadow.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp
M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h
M Source/WebCore/platform/graphics/GraphicsContext.cpp
M Source/WebCore/platform/graphics/GraphicsContext.h
M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
M Source/WebCore/platform/graphics/cg/GraphicsContextCG.h
M Source/WebCore/platform/graphics/displaylists/DisplayListItem.h
M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h
M 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp
M 
Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h
M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h
M Source/WebCore/rendering/GlyphDisplayListCache.cpp
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/DisplayListArgumentCoders.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h

  Log Message:
  ---
  [Skia] Fix corner cases involving drawing shadows
https://bugs.webkit.org/show_bug.cgi?id=273239

Reviewed by Adrian Perez de Castro.

So far - in the ports that use skia - shadows were being drawn in the same draw 
call as the original drawing operation.
This was possible as shadows were basically created using a filter that can be 
added to every drawing operation in skia.
The problem with such apporach is, however, that it does not work properly with 
some composite operations.
Some composite operations such as e.g. 'destination-atop' are expected to alter 
drawing in a way that shadow
is being drawn in front of it's origin.
To achieve that with skia:
 - drawing of shadow must be done as a separate draw call.
 - drawing of both shadow and shadow origin must be done on separate 
transparency layers so that shadow, shadow origin,
   and the original content present before draw operation will overlap 
correctly.

* 
LayoutTests/fast/canvas/canvas-composite-fill-with-shadow-and-fitting-perfectly-expected.txt:
 Added.
* 
LayoutTests/fast/canvas/canvas-composite-fill-with-shadow-and-fitting-perfectly.html:
 Added.
* LayoutTests/fast/canvas/canvas-composite-fill-with-shadow-expected.txt: Added.
* LayoutTests/fast/canvas/canvas-composite-fill-with-shadow.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::beginCompositeLayer):
(WebCore::CanvasRenderingContext2DBase::endCompositeLayer):
(WebCore::CanvasRenderingContext2DBase::fillRect):
* Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp:
(WebCore::BifurcatedGraphicsContext::beginTransparencyLayer):
* Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h:
* Source/WebCore/platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
* Source/WebCore/platform/graphics/GraphicsContext.h:
* Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::beginTransparencyLayer):
* Source/WebCore/platform/graphics/cg/GraphicsContextCG.h:
* Source/WebCore/platform/graphics/displaylists/DisplayListItem.h:
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::BeginTransparencyLayerWithCompositeMode::apply const):
(WebCore::DisplayList::BeginTrans

[webkit-changes] [WebKit/WebKit] d48e67: [GStreamer] Duplicate WebCore log messages due to ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d48e67ce96f458d90843afa21b9bb56bdbb964ef
  
https://github.com/WebKit/WebKit/commit/d48e67ce96f458d90843afa21b9bb56bdbb964ef
  Author: Philippe Normand 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  ---
  [GStreamer] Duplicate WebCore log messages due to observing the document 
logger multiple times
https://bugs.webkit.org/show_bug.cgi?id=275396

Reviewed by Xabier Rodriguez-Calvar.

Because both the PeerConnection and HTMLMediaElement rely on the same logger 
instance (the one
created by the document), a page containing more than one PeerConnection and/or 
more than one Media
element would emit duplicate logs because we were adding multiple log observers 
to the same logger.

Also we now filter log message by their channel name before dispatching them to 
the GStreamer
logging system.

Thanks to Carlos Bentzen for the report.

* 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::webrtcLogObserverSingleton):
(WebCore::GStreamerPeerConnectionBackend::GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::~GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::didLogMessage): Deleted.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::WebCoreLogObserver::didLogMessage):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::WebCoreLogObserver::addWatch):
(WebCore::WebCoreLogObserver::removeWatch):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaLogObserverSingleton):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::mediaPlayerWillBeDestroyed):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::didLogMessage): Deleted.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/280007@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd385c: PlaceholderRenderingContext is not consistent wrt ...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd385cf6b6e514e2458d87d0a0705da7814835e0
  
https://github.com/WebKit/WebKit/commit/bd385cf6b6e514e2458d87d0a0705da7814835e0
  Author: Kimmo Kinnunen 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/HTMLCanvasElement.h
M Source/WebCore/html/canvas/CanvasRenderingContext.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext.h
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
M Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h
M Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp
M Source/WebCore/html/canvas/ImageBitmapRenderingContext.h
M Source/WebCore/html/canvas/PlaceholderRenderingContext.h
M Source/WebCore/rendering/RenderHTMLCanvas.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerBacking.h

  Log Message:
  ---
  PlaceholderRenderingContext is not consistent wrt isGPUBased() accessor
https://bugs.webkit.org/show_bug.cgi?id=275053
rdar://129160039

Reviewed by Antti Koivisto.

CanvasRenderingContext::isGPUBased() was used for two
conflicting purposes:
 1. Downcasting to GPUBasedCanvasRenderingContext
 2. Forcing RenderLayerBacking creation for canvas RenderLayers.

1. is a bit dangerous, as PlaceholderRenderingContext is-not-a
GPUBasedCanvasRenderingContext.

Forcing RenderLayerBacking / RenderLayer creation also used
CanvasRenderingContext::isAccelerated().

Rename CanvasRenderingContext::isAccelerated() to
CanvasRenderingContext::delegatesDisplay(). The property means
that the context is able to directly replace the GraphicsLayer contents.

* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::didDraw):
(WebCore::HTMLCanvasElement::contentsUsedAsLayerContents const):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::transferControlToOffscreen):
(WebCore::HTMLCanvasElement::shouldNotifyRendererOnDidDraw const): Deleted.
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer const): Deleted.
(WebCore::HTMLCanvasElement::isGPUBased const): Deleted.
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::delegatesDisplay const):
* Source/WebCore/html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::isGPUBased const):
(WebCore::CanvasRenderingContext::isAccelerated const): Deleted.
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::isAccelerated const):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
* Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h:
* Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp:
(WebCore::ImageBitmapRenderingContext::isAccelerated const): Deleted.
* Source/WebCore/html/canvas/ImageBitmapRenderingContext.h:
* Source/WebCore/html/canvas/PlaceholderRenderingContext.h:
* Source/WebCore/rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::requiresLayer const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::canvasCompositingStrategy):
(WebCore::RenderLayerBacking::shouldSetContentsDisplayDelegate const):
* Source/WebCore/rendering/RenderLayerBacking.h:

Canonical link: https://commits.webkit.org/280006@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 931d2c: [Skia] Implement FEDropShadow and FEComponentTrans...

[Georges Basile Stavracas Neto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 931d2cd37b1190dfff814283b4a8ef10d985dc08
  
https://github.com/WebKit/WebKit/commit/931d2cd37b1190dfff814283b4a8ef10d985dc08
  Author: Georges Basile Stavracas Neto 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/css3/filters/effect-drop-shadow-clip-abspos.html
M 
LayoutTests/imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filters-drop-shadow-002.html
M Source/WebCore/platform/SourcesSkia.txt
M Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp
M Source/WebCore/platform/graphics/filters/FEDropShadow.cpp
M Source/WebCore/platform/graphics/filters/FEDropShadow.h
A 
Source/WebCore/platform/graphics/filters/skia/FEComponentTransferSkiaApplier.cpp
A 
Source/WebCore/platform/graphics/filters/skia/FEComponentTransferSkiaApplier.h
A Source/WebCore/platform/graphics/filters/skia/FEDropShadowSkiaApplier.cpp
A Source/WebCore/platform/graphics/filters/skia/FEDropShadowSkiaApplier.h

  Log Message:
  ---
  [Skia] Implement FEDropShadow and FEComponentTransfer filters
https://bugs.webkit.org/show_bug.cgi?id=273774

Reviewed by Carlos Garcia Campos.

Skia supports 3 filters already: FEColorMatrix, FEGaussianBlur, and
SourceGraphics. They were added as part of the initial bootstrapping
of Skia filters, mostly as a coding exercise and proof of concept.

CSSFilter.cpp uses two other filters directly: FEComponentTransfer,
and FEDropShadow. Indirectly it uses SVG filters, but that's a rarer
case.

Implement the FEDropShadow and FEComponentTransfer filters in Skia.

The FEDropShadow filter naturally enabled the drop-shadow() CSS filter.
It's implemented using the drop shadow image effect provided by Skia.

The FEComponentTransfer filter is a little less correspondent. It's
used for the CSS invert(), opacity(), contrast(), and brightness()
filters. It's implemented using the color table filter, in a similar
fashion to the software applier.

Adjust tests to allow slightly more fuzziness, as the shadows look
visually identical.

* LayoutTests/css3/filters/effect-drop-shadow-clip-abspos.html:
* LayoutTests/imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filters-drop-shadow-002.html:
* Source/WebCore/platform/SourcesSkia.txt:
* Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::supportedFilterRenderingModes const):
(WebCore::FEComponentTransfer::createAcceleratedApplier const):
(WebCore::FEComponentTransfer::createSoftwareApplier const):
* Source/WebCore/platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::supportedFilterRenderingModes const):
(WebCore::FEDropShadow::createAcceleratedApplier const):
(WebCore::FEDropShadow::createSoftwareApplier const):
* Source/WebCore/platform/graphics/filters/FEDropShadow.h:
* 
Source/WebCore/platform/graphics/filters/skia/FEComponentTransferSkiaApplier.cpp:
 Added.
(WebCore::FEComponentTransferSkiaApplier::apply const):
* 
Source/WebCore/platform/graphics/filters/skia/FEComponentTransferSkiaApplier.h: 
Added.
* Source/WebCore/platform/graphics/filters/skia/FEDropShadowSkiaApplier.cpp: 
Added.
(WebCore::FEDropShadowSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/FEDropShadowSkiaApplier.h: 
Added.

Canonical link: https://commits.webkit.org/280005@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 83b7d1: REGRESSION(272822@main): IPC sync replies might us...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83b7d1094b341c9fef824c58e88fcb5ebcf41141
  
https://github.com/WebKit/WebKit/commit/83b7d1094b341c9fef824c58e88fcb5ebcf41141
  Author: Kimmo Kinnunen 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Platform/IPC/MessageSender.h
M Source/WebKit/Platform/IPC/StreamClientConnection.h
M Source/WebKit/UIProcess/RemotePageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp
M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h

  Log Message:
  ---
  REGRESSION(272822@main): IPC sync replies might use freed data
https://bugs.webkit.org/show_bug.cgi?id=275434
rdar://125071066

Reviewed by Cameron McCormack.

The commit 272822@main would remove IPC::Decoder from the
ConnectionSendSyncResult. The decoder owns the data pointed by the
data references. This change results in sender reading freed memory
when reading the reply data references.

Fix by ensuring ConnectionSendSyncResult stores the IPC::Decoder that
owns the data referenced by the reply.

Using data references, e.g. std::spans, in IPC messages means that the
data is stored in the IPC message. Contrast this with messages transferring
Vectors: the Vectors store the data.

* Source/WebKit/Platform/IPC/Connection.h:
(IPC::ConnectionSendSyncResult::ConnectionSendSyncResult):
(IPC::ConnectionSendSyncResult::reply):
(IPC::ConnectionSendSyncResult::takeReply):
(IPC::Connection::sendSync):
* Source/WebKit/Platform/IPC/MessageSender.h:
* Source/WebKit/Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::trySendSyncStream):
* Source/WebKit/UIProcess/RemotePageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::MockTestSyncMessageWithDataReply::name):
(TestWebKitAPI::MockTestSyncMessageWithDataReply::arguments):
(TestWebKitAPI::MockTestSyncMessageWithDataReply::MockTestSyncMessageWithDataReply):
(TestWebKitAPI::TEST_P):
* Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h:

Canonical link: https://commits.webkit.org/280004@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 50c174: [Win] Update intrinsic device scale factor dynamic...

[Kohei Asano]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50c1741732a33548a144c043375f433523104f47
  
https://github.com/WebKit/WebKit/commit/50c1741732a33548a144c043375f433523104f47
  Author: Kohei Asano 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp
M Source/WebKit/UIProcess/win/WebView.cpp

  Log Message:
  ---
  [Win] Update intrinsic device scale factor dynamically
https://bugs.webkit.org/show_bug.cgi?id=274377

Reviewed by Fujii Hironori.

When intrinsic device scale factor dynamically is changed, i.e. moving
between different displays, we need to change intrinsic device scale
factor and repaint contents.
For main web contents, although WebView can't receive WM_DPICHANGED by
default, it's sufficient to update on WM_SIZE handler
because MainWindow's WM_DPICHANGED handling contains resizing window.
Above change also enables WebInspector resize when receiving WM_DPICHANGED,
just as MainWindow does.

* Source\WebKit\UIProcess\Inspector\win\WebInspectorUIProxyWin.cpp:
* Source\WebKit\UIProcess\win\WebView.cpp:

Canonical link: https://commits.webkit.org/280003@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 951926: Update ANGLE to 2024-06-13 (b150bcb873b8df30bfdb80...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9519265ddf2feea2046ca51ad33b2caf4048ea50
  
https://github.com/WebKit/WebKit/commit/9519265ddf2feea2046ca51ad33b2caf4048ea50
  Author: Kimmo Kinnunen 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/GLESv2.cmake
M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
M Source/ThirdParty/ANGLE/WebKit/angle_commit.h
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/doc/DevSetup.md
M Source/ThirdParty/ANGLE/doc/DevSetupAndroid.md
M Source/ThirdParty/ANGLE/doc/ExtensionSupport.md
A Source/ThirdParty/ANGLE/doc/TestingOnBots.md
A Source/ThirdParty/ANGLE/doc/img/SwarmingTaskInfo.png
A Source/ThirdParty/ANGLE/doc/img/TestBatchFailure.png
A Source/ThirdParty/ANGLE/doc/img/TestShardFailure.png
M Source/ThirdParty/ANGLE/extensions/ANGLE_shader_pixel_local_storage.txt
M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h
M Source/ThirdParty/ANGLE/include/platform/vk_features.json
M Source/ThirdParty/ANGLE/infra/specs/angle.json
M Source/ThirdParty/ANGLE/infra/specs/test_suite_exceptions.pyl
M Source/ThirdParty/ANGLE/infra/specs/test_suites.pyl
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_translator.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Extension_files.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GLenum_value_to_string_map.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/SPIR-V_helpers.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Static_builtins.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/interpreter_utils.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/proc_table.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/uniform_type.json
M Source/ThirdParty/ANGLE/scripts/generate_entry_points.py
M Source/ThirdParty/ANGLE/scripts/registry_xml.py
M Source/ThirdParty/ANGLE/src/common/PackedEnums.cpp
M Source/ThirdParty/ANGLE/src/common/PackedEnums.h
M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.cpp
M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.h
M Source/ThirdParty/ANGLE/src/common/gen_uniform_type_table.py
A Source/ThirdParty/ANGLE/src/common/uniform_type_info_autogen.h
M Source/ThirdParty/ANGLE/src/common/vulkan/vk_headers.h
M Source/ThirdParty/ANGLE/src/compiler/fuzz/translator_fuzzer.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/DirectiveHandler.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/ExtensionBehavior.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/ExtensionBehavior.h
M Source/ThirdParty/ANGLE/src/compiler/translator/Initialize.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/ShaderLang.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/SymbolTable_ESSL_autogen.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/SymbolTable_autogen.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/builtin_function_declarations.txt
M Source/ThirdParty/ANGLE/src/compiler/translator/builtin_variables.json
M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/TranslatorGLSL.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/glslang.l
M Source/ThirdParty/ANGLE/src/compiler/translator/glslang.y
M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_lex_autogen.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_tab_autogen.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/InitializeVariables.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/wgsl/TranslatorWGSL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Compiler.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Context_gles_ext_autogen.h
M Source/ThirdParty/ANGLE/src/libANGLE/ErrorStrings.h
M Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Program.h
M Source/ThirdParty/ANGLE/src/libANGLE/ProgramExecutable.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/State.cpp
M Source/ThirdParty/ANGLE/src/lib

[webkit-changes] [WebKit/WebKit] 8ba2b4: [Skia] Test svg/filters/svg-gaussianblur-edgeMode-...

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ba2b4bfa6bbf71b23764392d40cfa2724876347
  
https://github.com/WebKit/WebKit/commit/8ba2b4bfa6bbf71b23764392d40cfa2724876347
  Author: Pawel Lampe 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp

  Log Message:
  ---
  [Skia] Test svg/filters/svg-gaussianblur-edgeMode-duplicate.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=273486

Reviewed by Carlos Garcia Campos.

Currently, skia's Gaussian blur filter doesn't have support for 'edgeMode' and 
it's not possible to easily simulate
that using other parts of skia API. Therefore, this change provides a fallback 
to simple software filter in case 'edgeMode' is used.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::supportedFilterRenderingModes const):
(WebCore::FEGaussianBlur::createSoftwareApplier const):

Canonical link: https://commits.webkit.org/280001@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes