from:"jeffm"

[webkit-changes] [292167] trunk/Tools

2022-03-31 Thread jeffm

Title: [292167] trunk/Tools








Revision 292167
Author je...@apple.com
Date 2022-03-31 13:07:32 -0700 (Thu, 31 Mar 2022)


Log Message
Some API tests are missing header imports
https://bugs.webkit.org/show_bug.cgi?id=238588

Reviewed by Alexey Proskuryakov.

I attempted to add a new API test which changed the source files that are compiled in each
UnifiedSource file. This revealed that some existing API tests were only compiling successfully
because they relied on headers being imported by other source files in the same UnifiedSource
compilation unit.

* TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:
* TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm




Diff

Modified: trunk/Tools/ChangeLog (292166 => 292167)

--- trunk/Tools/ChangeLog	2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/ChangeLog	2022-03-31 20:07:32 UTC (rev 292167)
@@ -1,3 +1,19 @@
+2022-03-31  Jeff Miller  
+
+Some API tests are missing header imports
+https://bugs.webkit.org/show_bug.cgi?id=238588
+
+Reviewed by Alexey Proskuryakov.
+
+I attempted to add a new API test which changed the source files that are compiled in each
+UnifiedSource file. This revealed that some existing API tests were only compiling successfully
+because they relied on headers being imported by other source files in the same UnifiedSource
+compilation unit.
+
+* TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:
+* TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
+* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
+
 2022-03-31  Robert Jenner  
 
 REGRESSION(r288464?):[ iOS15 Release GPUP arm64 ]TestWebKitAPI.GPUProcess.E xitsUnderMemoryPressureWebR TCCase is a constant failure


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm (292166 => 292167)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm	2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm	2022-03-31 20:07:32 UTC (rev 292167)
@@ -28,7 +28,9 @@
 #if USE(APPLE_INTERNAL_SDK)
 
 #import "DeprecatedGlobalValues.h"
+#import "HTTPServer.h"
 #import "PlatformUtilities.h"
+#import "TestNavigationDelegate.h"
 #import "TestUIDelegate.h"
 #import "TestURLSchemeHandler.h"
 #import "TestWKWebView.h"
@@ -36,6 +38,8 @@
 #import 
 #import 
 #import 
+#import 
+#import 
 
 @interface FileSystemAccessMessageHandler : NSObject 
 @end


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm (292166 => 292167)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm	2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm	2022-03-31 20:07:32 UTC (rev 292167)
@@ -36,8 +36,10 @@
 #import "UIKitSPI.h"
 #import "WKWebViewConfigurationExtras.h"
 #import 
+#import 
 #import 
 #import 
+#import 
 #import 
 #import 
 


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm (292166 => 292167)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm	2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm	2022-03-31 20:07:32 UTC (rev 292167)
@@ -27,6 +27,7 @@
 
 #import "HTTPServer.h"
 #import "PlatformUtilities.h"
+#import "Test.h"
 #import "TestWKWebView.h"
 #import "Utilities.h"
 #import 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287502] trunk

2022-01-01 Thread jeffm

Title: [287502] trunk








Revision 287502
Author je...@apple.com
Date 2022-01-01 08:25:38 -0800 (Sat, 01 Jan 2022)


Log Message
Update user-visible copyright strings to include 2022
https://bugs.webkit.org/show_bug.cgi?id=234263

Reviewed by Anders Carlsson.

.:

* Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:

Source/_javascript_Core:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebGPU:

* Info.plist:

Source/WebKit:

* GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist:
* GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:
* Info.plist:
* NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist:
* NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist:
* WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist:
* WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

Source/WebKitLegacy/mac:

* Info.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/Info.plist
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist
trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist
trunk/Source/WebKit/Info.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist
trunk/Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist
trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Info.plist
trunk/Source/cmake/tools/scripts/COPYRIGHT-END-YEAR
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/ChangeLog (287501 => 287502)

--- trunk/ChangeLog	2022-01-01 15:34:20 UTC (rev 287501)
+++ trunk/ChangeLog	2022-01-01 16:25:38 UTC (rev 287502)
@@ -1,3 +1,12 @@
+2022-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2022
+https://bugs.webkit.org/show_bug.cgi?id=234263
+
+Reviewed by Anders Carlsson.
+
+* Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:
+
 2021-12-25  Sergey Rubanov  
 
 Add my github username to contributors.json


Modified: trunk/Source/_javascript_Core/ChangeLog (287501 => 287502)

--- trunk/Source/_javascript_Core/ChangeLog	2022-01-01 15:34:20 UTC (rev 287501)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-01-01 16:25:38 UTC (rev 287502)
@@ -1,3 +1,12 @@
+2022-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2022
+https://bugs.webkit.org/show_bug.cgi?id=234263
+
+Reviewed by Anders Carlsson.
+
+* Info.plist:
+
 2021-12-30  Adrian Perez de Castro  
 
 Non-unified build fixes, end-of-year 2021 edition


Modified: trunk/Source/_javascript_Core/Info.plist (287501 => 287502)

--- trunk/Source/_javascript_Core/Info.plist	2022-01-01 15:34:20 UTC (rev 287501)
+++ trunk/Source/_javascript_Core/Info.plist	2022-01-01 16:25:38 UTC (rev 287502)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2021 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+	${BUNDLE_VERSION}, Copyright 2003-2022 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
 	CFBundleIdentifier
 	${PRODUCT_BUNDLE_IDENTIFIER}
 	CFBundleInfoDictionaryVersion


Modified: trunk/Source/WebCore/ChangeLog (287501 => 287502)

--- trunk/Source/WebCore/ChangeLog	2022-01-01 15:34:20 UTC (rev 287501)
+++ trunk/Source/WebCore/ChangeLog	2022-01-01 16:25:38 UTC (rev 287502)
@@ -1,3 +1,12 @@
+2022-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2022
+https://bugs.webkit.org/show_bug.cgi?id=234263
+
+Reviewed by Anders Carlsson.
+
+* Info.plist:
+
 2022-01-01  Alan Bujtas  
 
 [LFC][IFC] Simple RTL content triggers redundant horizontal positioning


Modified: trunk/Source/WebCore/Info.plist (287501 => 287502)

--- trunk/S

[webkit-changes] [271131] trunk

2021-01-04 Thread jeffm

Title: [271131] trunk








Revision 271131
Author je...@apple.com
Date 2021-01-04 08:32:09 -0800 (Mon, 04 Jan 2021)


Log Message
Update user-visible copyright strings to include 2021
https://bugs.webkit.org/show_bug.cgi?id=219901

Reviewed by Anders Carlsson.

.:

* Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:

Source/_javascript_Core:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit:

* GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist:
* GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:
* Info.plist:
* NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist:
* NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist:
* PluginProcess/EntryPoint/Cocoa/XPCService/PluginService.Info.plist:
* WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist:
* WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

Source/WebKitLegacy/mac:

* Info.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist
trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist
trunk/Source/WebKit/Info.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit/PluginProcess/EntryPoint/Cocoa/XPCService/PluginService.Info.plist
trunk/Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist
trunk/Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist
trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Info.plist
trunk/Source/cmake/tools/scripts/COPYRIGHT-END-YEAR
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/ChangeLog (271130 => 271131)

--- trunk/ChangeLog	2021-01-04 12:56:42 UTC (rev 271130)
+++ trunk/ChangeLog	2021-01-04 16:32:09 UTC (rev 271131)
@@ -1,3 +1,12 @@
+2021-01-04  Jeff Miller  
+
+Update user-visible copyright strings to include 2021
+https://bugs.webkit.org/show_bug.cgi?id=219901
+
+Reviewed by Anders Carlsson.
+
+* Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:
+
 2020-12-23  Fujii Hironori  
 
 [WinCairo] Enable WebGL 2


Modified: trunk/Source/_javascript_Core/ChangeLog (271130 => 271131)

--- trunk/Source/_javascript_Core/ChangeLog	2021-01-04 12:56:42 UTC (rev 271130)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-01-04 16:32:09 UTC (rev 271131)
@@ -1,3 +1,12 @@
+2021-01-04  Jeff Miller  
+
+Update user-visible copyright strings to include 2021
+https://bugs.webkit.org/show_bug.cgi?id=219901
+
+Reviewed by Anders Carlsson.
+
+* Info.plist:
+
 2021-01-01  Yusuke Suzuki  
 
 [JSC] Remove unnecessary mov bytecodes when performing simple object pattern destructuring to variables


Modified: trunk/Source/_javascript_Core/Info.plist (271130 => 271131)

--- trunk/Source/_javascript_Core/Info.plist	2021-01-04 12:56:42 UTC (rev 271130)
+++ trunk/Source/_javascript_Core/Info.plist	2021-01-04 16:32:09 UTC (rev 271131)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2020 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+	${BUNDLE_VERSION}, Copyright 2003-2021 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
 	CFBundleIdentifier
 	${PRODUCT_BUNDLE_IDENTIFIER}
 	CFBundleInfoDictionaryVersion


Modified: trunk/Source/WebCore/ChangeLog (271130 => 271131)

--- trunk/Source/WebCore/ChangeLog	2021-01-04 12:56:42 UTC (rev 271130)
+++ trunk/Source/WebCore/ChangeLog	2021-01-04 16:32:09 UTC (rev 271131)
@@ -1,3 +1,12 @@
+2021-01-04  Jeff Miller  
+
+Update user-visible copyright strings to include 2021
+https://bugs.webkit.org/show_bug.cgi?id=219901
+
+Reviewed by Anders Carlsson.
+
+* Info.plist:
+
 2020-12-14  Sergio Villar Senin  
 
 [css-multicol] Do not attach  to  multicolumn c

[webkit-changes] [270997] trunk/Source/WebKit

2020-12-18 Thread jeffm

Title: [270997] trunk/Source/WebKit








Revision 270997
Author je...@apple.com
Date 2020-12-18 16:39:20 -0800 (Fri, 18 Dec 2020)


Log Message
WKProcessPool enhancements for URL schemes
https://bugs.webkit.org/show_bug.cgi?id=220030

Reviewed by Brian Weinstein.

* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _registerURLSchemeAsSecure:]):
Added, equivalent to WKContextRegisterURLSchemeAsSecure().

(-[WKProcessPool _registerURLSchemeAsBypassingContentSecurityPolicy:]):
Added, equivalent to WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy().

(-[WKProcessPool _setDomainRelaxationForbiddenForURLScheme:]):
Added, equivalent to WKContextSetDomainRelaxationForbiddenForURLScheme().

* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (270996 => 270997)

--- trunk/Source/WebKit/ChangeLog	2020-12-19 00:16:08 UTC (rev 270996)
+++ trunk/Source/WebKit/ChangeLog	2020-12-19 00:39:20 UTC (rev 270997)
@@ -1,3 +1,22 @@
+2020-12-18  Jeff Miller  
+
+WKProcessPool enhancements for URL schemes
+https://bugs.webkit.org/show_bug.cgi?id=220030
+
+Reviewed by Brian Weinstein.
+
+* UIProcess/API/Cocoa/WKProcessPool.mm:
+(-[WKProcessPool _registerURLSchemeAsSecure:]):
+Added, equivalent to WKContextRegisterURLSchemeAsSecure().
+
+(-[WKProcessPool _registerURLSchemeAsBypassingContentSecurityPolicy:]):
+Added, equivalent to WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy().
+
+(-[WKProcessPool _setDomainRelaxationForbiddenForURLScheme:]):
+Added, equivalent to WKContextSetDomainRelaxationForbiddenForURLScheme().
+
+* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
+
 2020-12-18  BJ Burg  
 
 [Cocoa] Web Inspector: clean up _WKRemoteWebInspectorViewController


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm (270996 => 270997)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm	2020-12-19 00:16:08 UTC (rev 270996)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm	2020-12-19 00:39:20 UTC (rev 270997)
@@ -197,6 +197,21 @@
 _processPool->registerURLSchemeAsCanDisplayOnlyIfCanRequest(scheme);
 }
 
+- (void)_registerURLSchemeAsSecure:(NSString *)scheme
+{
+_processPool->registerURLSchemeAsSecure(scheme);
+}
+
+- (void)_registerURLSchemeAsBypassingContentSecurityPolicy:(NSString *)scheme
+{
+_processPool->registerURLSchemeAsBypassingContentSecurityPolicy(scheme);
+}
+
+- (void)_setDomainRelaxationForbiddenForURLScheme:(NSString *)scheme
+{
+_processPool->setDomainRelaxationForbiddenForURLScheme(scheme);
+}
+
 - (void)_setCanHandleHTTPSServerTrustEvaluation:(BOOL)value
 {
 }


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h (270996 => 270997)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h	2020-12-19 00:16:08 UTC (rev 270996)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h	2020-12-19 00:39:20 UTC (rev 270997)
@@ -82,8 +82,10 @@
 - (void)_clearSupportedPlugins WK_API_AVAILABLE(macos(10.14), ios(12.0));
 
 - (void)_registerURLSchemeAsCanDisplayOnlyIfCanRequest:(NSString *)scheme WK_API_AVAILABLE(macos(10.14), ios(12.0));
+- (void)_registerURLSchemeAsSecure:(NSString *)scheme WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+- (void)_registerURLSchemeAsBypassingContentSecurityPolicy:(NSString *)scheme WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+- (void)_setDomainRelaxationForbiddenForURLScheme:(NSString *)scheme WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
-
 - (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request websiteDataStore:(WKWebsiteDataStore *)dataStore originatingWebView:(WKWebView *)webView WK_API_DEPRECATED_WITH_REPLACEMENT("WKWebView _downloadRequest", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA));
 - (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData websiteDataStore:(WKWebsiteDataStore *)dataStore  path:(NSString *)path originatingWebView:(WKWebView *)webView WK_API_DEPRECATED_WITH_REPLACEMENT("WKWebView.resumeDownloadFromResumeData:completionHandler:", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [266369] trunk/Source/WebCore

2020-08-31 Thread jeffm

Title: [266369] trunk/Source/WebCore








Revision 266369
Author je...@apple.com
Date 2020-08-31 14:18:00 -0700 (Mon, 31 Aug 2020)


Log Message
Unreviewed build fix after http://trac.webkit.org/changeset/266364/webkit.

* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
Regenerated these files.

Modified Paths

trunk/Source/WebCore/DerivedSources-input.xcfilelist
trunk/Source/WebCore/DerivedSources-output.xcfilelist




Diff

Modified: trunk/Source/WebCore/DerivedSources-input.xcfilelist (266368 => 266369)

--- trunk/Source/WebCore/DerivedSources-input.xcfilelist	2020-08-31 21:14:07 UTC (rev 266368)
+++ trunk/Source/WebCore/DerivedSources-input.xcfilelist	2020-08-31 21:18:00 UTC (rev 266369)
@@ -927,6 +927,7 @@
 $(PROJECT_DIR)/html/canvas/WebGLCompressedTextureETC1.idl
 $(PROJECT_DIR)/html/canvas/WebGLCompressedTexturePVRTC.idl
 $(PROJECT_DIR)/html/canvas/WebGLCompressedTextureS3TC.idl
+$(PROJECT_DIR)/html/canvas/WebGLCompressedTextureS3TCsRGB.idl
 $(PROJECT_DIR)/html/canvas/WebGLContextAttributes.idl
 $(PROJECT_DIR)/html/canvas/WebGLContextEvent.idl
 $(PROJECT_DIR)/html/canvas/WebGLDebugRendererInfo.idl


Modified: trunk/Source/WebCore/DerivedSources-output.xcfilelist (266368 => 266369)

--- trunk/Source/WebCore/DerivedSources-output.xcfilelist	2020-08-31 21:14:07 UTC (rev 266368)
+++ trunk/Source/WebCore/DerivedSources-output.xcfilelist	2020-08-31 21:18:00 UTC (rev 266369)
@@ -2062,6 +2062,8 @@
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLCompressedTexturePVRTC.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLCompressedTextureS3TC.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLCompressedTextureS3TC.h
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLCompressedTextureS3TCsRGB.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLCompressedTextureS3TCsRGB.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLContextAttributes.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLContextAttributes.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSWebGLContextEvent.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253968] trunk

2020-01-01 Thread jeffm

Title: [253968] trunk








Revision 253968
Author je...@apple.com
Date 2020-01-01 09:58:19 -0800 (Wed, 01 Jan 2020)


Log Message
Update user-visible copyright strings to include 2020
https://bugs.webkit.org/show_bug.cgi?id=205552

Reviewed by Darin Adler.

.:

* Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:

Source/_javascript_Core:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit:

* GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist:
* GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:
* Info.plist:
* NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist:
* NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist:
* PluginProcess/EntryPoint/Cocoa/XPCService/PluginService.64.Info.plist:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

Source/WebKitLegacy/mac:

* Info.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist
trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist
trunk/Source/WebKit/Info.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit/PluginProcess/EntryPoint/Cocoa/XPCService/PluginService.64.Info.plist
trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Info.plist
trunk/Source/cmake/tools/scripts/COPYRIGHT-END-YEAR
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/ChangeLog (253967 => 253968)

--- trunk/ChangeLog	2020-01-01 13:05:01 UTC (rev 253967)
+++ trunk/ChangeLog	2020-01-01 17:58:19 UTC (rev 253968)
@@ -1,3 +1,12 @@
+2019-12-22  Jeff Miller  
+
+Update user-visible copyright strings to include 2020
+https://bugs.webkit.org/show_bug.cgi?id=205552
+
+Reviewed by Darin Adler.
+
+* Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:
+
 2019-12-18  Diego Pino Garcia  
 
 [GTK][WPE] Renderization of Conic gradients


Modified: trunk/Source/_javascript_Core/ChangeLog (253967 => 253968)

--- trunk/Source/_javascript_Core/ChangeLog	2020-01-01 13:05:01 UTC (rev 253967)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-01 17:58:19 UTC (rev 253968)
@@ -1,3 +1,12 @@
+2019-12-22  Jeff Miller  
+
+Update user-visible copyright strings to include 2020
+https://bugs.webkit.org/show_bug.cgi?id=205552
+
+Reviewed by Darin Adler.
+
+* Info.plist:
+
 2019-12-20  Darin Adler  
 
 Tidy a bit of StringBuilder usage


Modified: trunk/Source/_javascript_Core/Info.plist (253967 => 253968)

--- trunk/Source/_javascript_Core/Info.plist	2020-01-01 13:05:01 UTC (rev 253967)
+++ trunk/Source/_javascript_Core/Info.plist	2020-01-01 17:58:19 UTC (rev 253968)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2019 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+	${BUNDLE_VERSION}, Copyright 2003-2020 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
 	CFBundleIdentifier
 	${PRODUCT_BUNDLE_IDENTIFIER}
 	CFBundleInfoDictionaryVersion


Modified: trunk/Source/WebCore/ChangeLog (253967 => 253968)

--- trunk/Source/WebCore/ChangeLog	2020-01-01 13:05:01 UTC (rev 253967)
+++ trunk/Source/WebCore/ChangeLog	2020-01-01 17:58:19 UTC (rev 253968)
@@ -1,3 +1,12 @@
+2019-12-22  Jeff Miller  
+
+Update user-visible copyright strings to include 2020
+https://bugs.webkit.org/show_bug.cgi?id=205552
+
+Reviewed by Darin Adler.
+
+* Info.plist:
+
 2020-01-01  youenn fablet  
 
 ServiceWorkerJobData should have a move constructor


Modified: trunk/Source/WebCore/Info.plist (253967 => 253968)

--- trunk/Source/WebCore/Info.plist	2020-01-01 13:05:01 UTC (rev 253967)
+++ trunk/Source/WebCore/Info.plist	2020-01-01 17:58:19 UTC (rev 253968)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2019 Apple Inc.; Copyright 1997 Martin Jones ; Copyright 1998, 1999

[webkit-changes] [239568] trunk

2019-01-01 Thread jeffm

Title: [239568] trunk








Revision 239568
Author je...@apple.com
Date 2019-01-01 11:29:55 -0800 (Tue, 01 Jan 2019)


Log Message
Update user-visible copyright strings to include 2019
https://bugs.webkit.org/show_bug.cgi?id=192811

Reviewed by Mark Lam.

Source/_javascript_Core:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit:

* Info.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:

Source/WebKitLegacy/mac:

* Info.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Info.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist
trunk/Source/WebKit/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Info.plist
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239567 => 239568)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-31 15:31:15 UTC (rev 239567)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-01-01 19:29:55 UTC (rev 239568)
@@ -1,3 +1,12 @@
+2019-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2019
+https://bugs.webkit.org/show_bug.cgi?id=192811
+
+Reviewed by Mark Lam.
+
+* Info.plist:
+
 2018-12-30  Ross Kirsling  
 
 [JSC] Identifier validity should be based on ID_Start / ID_Continue properties


Modified: trunk/Source/_javascript_Core/Info.plist (239567 => 239568)

--- trunk/Source/_javascript_Core/Info.plist	2018-12-31 15:31:15 UTC (rev 239567)
+++ trunk/Source/_javascript_Core/Info.plist	2019-01-01 19:29:55 UTC (rev 239568)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2018 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+	${BUNDLE_VERSION}, Copyright 2003-2019 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
 	CFBundleIdentifier
 	${PRODUCT_BUNDLE_IDENTIFIER}
 	CFBundleInfoDictionaryVersion


Modified: trunk/Source/WebCore/ChangeLog (239567 => 239568)

--- trunk/Source/WebCore/ChangeLog	2018-12-31 15:31:15 UTC (rev 239567)
+++ trunk/Source/WebCore/ChangeLog	2019-01-01 19:29:55 UTC (rev 239568)
@@ -1,3 +1,12 @@
+2019-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2019
+https://bugs.webkit.org/show_bug.cgi?id=192811
+
+Reviewed by Mark Lam.
+
+* Info.plist:
+
 2018-12-30  David Kilzer  
 
 clang-tidy: Save 8 padding bytes on WebCore::BorderEdge


Modified: trunk/Source/WebCore/Info.plist (239567 => 239568)

--- trunk/Source/WebCore/Info.plist	2018-12-31 15:31:15 UTC (rev 239567)
+++ trunk/Source/WebCore/Info.plist	2019-01-01 19:29:55 UTC (rev 239568)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2018 Apple Inc.; Copyright 1997 Martin Jones ; Copyright 1998, 1999 Torben Weis ; Copyright 1998, 1999, 2002 Waldo Bastian ; Copyright 1998-2000 Lars Knoll ; Copyright 1999, 2001 Antti Koivisto ; Copyright 1999-2001 Harri Porten ; Copyright 2000 Simon Hausmann ; Copyright 2000, 2001 Dirk Mueller ; Copyright 2000, 2001 Peter Kelly ; Copyright 2000 Daniel Molkentin ; Copyright 2000 Stefan Schimanski ; Copyright 1998-2000 Netscape Communications Corporation; Copyright 1998, 1999, 2000 Thai Open Source Software Center Ltd and Clark Cooper; Copyright 2001, 2002 Expat maintainers.
+	${BUNDLE_VERSION}, Copyright 2003-2019 Apple Inc.; Copyright 1997 Martin Jones ; Copyright 1998, 1999 Torben Weis ; Copyright 1998, 1999, 2002 Waldo Bastian ; Copyright 1998-2000 Lars

[webkit-changes] [238408] trunk

2018-11-20 Thread jeffm

Title: [238408] trunk








Revision 238408
Author je...@apple.com
Date 2018-11-20 15:46:23 -0800 (Tue, 20 Nov 2018)


Log Message
Return nullptr immediately if the key doesn't exist in the HashMap.
https://bugs.webkit.org/show_bug.cgi?id=191841

Reviewed by Chris Dumez.
Source/WebKit:

* Shared/API/APIDictionary.h:

Tools:

Add a test that would crash prior to the fix for this bug.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/APIDictionary.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (238407 => 238408)

--- trunk/Source/WebKit/ChangeLog	2018-11-20 23:38:23 UTC (rev 238407)
+++ trunk/Source/WebKit/ChangeLog	2018-11-20 23:46:23 UTC (rev 238408)
@@ -1,3 +1,12 @@
+2018-11-20  Jeff Miller  
+
+Return nullptr immediately if the key doesn't exist in the HashMap.
+https://bugs.webkit.org/show_bug.cgi?id=191841
+
+Reviewed by Chris Dumez.
+
+* Shared/API/APIDictionary.h:
+
 2018-11-20  Don Olmstead  
 
 WebPasteboard should USE(LIBWPE)


Modified: trunk/Source/WebKit/Shared/API/APIDictionary.h (238407 => 238408)

--- trunk/Source/WebKit/Shared/API/APIDictionary.h	2018-11-20 23:38:23 UTC (rev 238407)
+++ trunk/Source/WebKit/Shared/API/APIDictionary.h	2018-11-20 23:46:23 UTC (rev 238408)
@@ -66,6 +66,9 @@
 {
 auto it = m_map.find(key);
 exists = it != m_map.end();
+if (!exists)
+return nullptr;
+
 return it->value.get();
 }
 


Modified: trunk/Tools/ChangeLog (238407 => 238408)

--- trunk/Tools/ChangeLog	2018-11-20 23:38:23 UTC (rev 238407)
+++ trunk/Tools/ChangeLog	2018-11-20 23:46:23 UTC (rev 238408)
@@ -1,3 +1,16 @@
+2018-11-20  Jeff Miller  
+
+Return nullptr immediately if the key doesn't exist in the HashMap.
+https://bugs.webkit.org/show_bug.cgi?id=191841
+
+Reviewed by Chris Dumez.
+
+Add a test that would crash prior to the fix for this bug.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.
+(TestWebKitAPI::TEST):
+
 2018-11-19  Alex Christensen  
 
 Add SPI to disable JIT in a WKWebView


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (238407 => 238408)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2018-11-20 23:38:23 UTC (rev 238407)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2018-11-20 23:46:23 UTC (rev 238408)
@@ -792,6 +792,7 @@
 		CEBCA13A1E3A807A00C73293 /* page-without-csp.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CEBCA1371E3A803400C73293 /* page-without-csp.html */; };
 		CEBCA13B1E3A807A00C73293 /* page-without-csp-iframe.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CEBCA1361E3A803400C73293 /* page-without-csp-iframe.html */; };
 		D34E08761E4E42E1005FF14A /* WKWebViewGetContents.mm in Sources */ = {isa = PBXBuildFile; fileRef = D3BE5E341E4CE85E00FD563A /* WKWebViewGetContents.mm */; };
+		DF4B273921A47728009BD1CA /* WKNSDictionaryEmptyDictionaryCrash.mm in Sources */ = {isa = PBXBuildFile; fileRef = DF4B273821A47727009BD1CA /* WKNSDictionaryEmptyDictionaryCrash.mm */; };
 		E1220DCA155B28AA0013E2FC /* MemoryCacheDisableWithinResourceLoadDelegate.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = E1220DC9155B287D0013E2FC /* MemoryCacheDisableWithinResourceLoadDelegate.html */; };
 		E194E1BD177E53C7009C4D4E /* StopLoadingFromDidReceiveResponse.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = E194E1BC177E534A009C4D4E /* StopLoadingFromDidReceiveResponse.html */; };
 		E324A6F02041C82000A76593 /* UniqueArray.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E398BC0F2041C76300387136 /* UniqueArray.cpp */; };
@@ -2066,6 +2067,7 @@
 		CEBCA1371E3A803400C73293 /* page-without-csp.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "page-without-csp.html"; sourceTree = ""; };
 		D3BE5E341E4CE85E00FD563A /* WKWebViewGetContents.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKWebViewGetContents.mm; sourceTree = ""; };
 		DC69AA621CF77C6500C6272F /* ScopedLambda.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScopedLambda.cpp; sourceTree = ""; };
+		DF4B273821A47727009BD1CA /* WKNSDictionaryEmptyDictionaryCrash.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKNSDictionaryEmptyDictionaryCrash.mm; sourceTree = ""; };
 		E1220D9F155B25480013E2FC /*

[webkit-changes] [235332] trunk/Source/WebKit

2018-08-24 Thread jeffm

Title: [235332] trunk/Source/WebKit








Revision 235332
Author je...@apple.com
Date 2018-08-24 13:36:56 -0700 (Fri, 24 Aug 2018)


Log Message
Remove -[WKNavigationDelegate _webView:decidePolicyForPluginLoadWithCurrentPolicy:pluginInfo:unavailabilityDescription:]
https://bugs.webkit.org/show_bug.cgi?id=19

Reviewed by Alex Christensen.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
Remove obsolete method.

* UIProcess/Cocoa/NavigationState.h:
Remove obsolete flag.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
Remove obsolete flag.

(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad):
Remove support for obsolete delegate method.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (235331 => 235332)

--- trunk/Source/WebKit/ChangeLog	2018-08-24 20:14:50 UTC (rev 235331)
+++ trunk/Source/WebKit/ChangeLog	2018-08-24 20:36:56 UTC (rev 235332)
@@ -1,3 +1,23 @@
+2018-08-23  Jeff Miller  
+
+Remove -[WKNavigationDelegate _webView:decidePolicyForPluginLoadWithCurrentPolicy:pluginInfo:unavailabilityDescription:]
+https://bugs.webkit.org/show_bug.cgi?id=19
+
+Reviewed by Alex Christensen.
+
+* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
+Remove obsolete method.
+
+* UIProcess/Cocoa/NavigationState.h:
+Remove obsolete flag.
+
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::setNavigationDelegate):
+Remove obsolete flag.
+
+(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad):
+Remove support for obsolete delegate method.
+
 2018-08-24  Ryosuke Niwa  
 
 Pass in IsComposed flag to Event constructors


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h (235331 => 235332)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h	2018-08-24 20:14:50 UTC (rev 235331)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h	2018-08-24 20:36:56 UTC (rev 235332)
@@ -106,7 +106,6 @@
 - (void)_webView:(WKWebView *)webView willGoToBackForwardListItem:(WKBackForwardListItem *)item inPageCache:(BOOL)inPageCache WK_API_AVAILABLE(macosx(10.13.4));
 - (void)_webView:(WKWebView *)webView didFailToInitializePlugInWithInfo:(NSDictionary *)info WK_API_AVAILABLE(macosx(10.13.4));
 - (void)_webView:(WKWebView *)webView didBlockInsecurePluginVersionWithInfo:(NSDictionary *)info WK_API_AVAILABLE(macosx(WK_MAC_TBA));
-- (_WKPluginModuleLoadPolicy)_webView:(WKWebView *)webView decidePolicyForPluginLoadWithCurrentPolicy:(_WKPluginModuleLoadPolicy)policy pluginInfo:(NSDictionary *)info unavailabilityDescription:(NSString *)unavailabilityDescription WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView decidePolicyForPluginLoadWithCurrentPolicy:(_WKPluginModuleLoadPolicy)policy pluginInfo:(NSDictionary *)info completionHandler:(void (^)(_WKPluginModuleLoadPolicy policy, NSString * unavailabilityDescription))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView backForwardListItemAdded:(WKBackForwardListItem *)itemAdded removed:(NSArray *)itemsRemoved WK_API_AVAILABLE(macosx(10.13.4));
 #endif


Modified: trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h (235331 => 235332)

--- trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h	2018-08-24 20:14:50 UTC (rev 235331)
+++ trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h	2018-08-24 20:36:56 UTC (rev 235332)
@@ -229,7 +229,6 @@
 bool webViewDidFailToInitializePlugInWithInfo : 1;
 bool webViewDidBlockInsecurePluginVersionWithInfo : 1;
 bool webViewWillGoToBackForwardListItemInPageCache : 1;
-bool webViewDecidePolicyForPluginLoadWithCurrentPolicyPluginInfoUnavailabilityDescription : 1;
 bool webViewDecidePolicyForPluginLoadWithCurrentPolicyPluginInfoCompletionHandler : 1;
 #endif
 } m_navigationDelegateMethods;


Modified: trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm (235331 => 235332)

--- trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm	2018-08-24 20:14:50 UTC (rev 235331)
+++ trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm	2018-08-24 20:36:56 UTC (rev 235332)
@@ -185,7 +185,6 @@
 m_navigationDelegateMethods.webViewDidFailToInitializePlugInWithInfo = [delegate respondsToSelector:@selector(_webView:didFailToInitializePlugInWithInfo:)];
 m_navigationDelegateMethods.webViewDidBlockInsecurePluginVersionWithInfo = [delegate respondsToSelector:@selector(_webView:didBlockInsecurePluginVersionWithInfo:)];
 m_navigationDelegateMethods.webViewBackForwardListItemAddedRemoved = [delegate respondsToSelector:@selector(_webView:backForwardListItemAdded:removed:)

[webkit-changes] [235200] trunk/Source/WebKit

2018-08-22 Thread jeffm

Title: [235200] trunk/Source/WebKit








Revision 235200
Author je...@apple.com
Date 2018-08-22 14:08:38 -0700 (Wed, 22 Aug 2018)


Log Message
WKNavigationDelegate needs to allow clients to specify a custom blocked plug-in message
https://bugs.webkit.org/show_bug.cgi?id=188764

Reviewed by Alex Christensen.

Add a new private WKNavigationDelegate method that takes a completion handler so clients can return
a custom unavailability description in addition to the policy. Change WebPageProxy::findPlugin() to
send a delayed reply and API::LoaderClient::pluginLoadPolicy()/API::NavigationClient::decidePolicyForPluginLoad()
to take a completion handler to support this.

* UIProcess/API/APILoaderClient.h:
(API::LoaderClient::pluginLoadPolicy):
Changed to take a completion handler. The default implementation doesn't return a custom
unavailability description.

* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::decidePolicyForPluginLoad):
Ditto.

* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
Changed pluginLoadPolicy() to take a completion handler.

(WKPageSetPageNavigationClient):
Changed decidePolicyForPluginLoad() to take a completion handler.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
Add alternate version of -decidePolicyForPluginLoadWithCurrentPolicy: that allows clients to return
the unavailibility description.

* UIProcess/Cocoa/NavigationState.h:
Add flag for new delegate method.
Changed decidePolicyForPluginLoad() to take a completion handler.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
Calculate flag for new delegate method.

(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad):
Changed to take a completion handler.
Prefer new delegate method, if available.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
Changed to send a delayed reply.
Refactored some code into a lambda so it can be shared when using m_navigationClient->decidePolicyForPluginLoad().
Removed unneeded UNUSED_PARAM() macros.

* UIProcess/WebPageProxy.h:
Changed findPlugin() to send a delayed reply.

* UIProcess/WebPageProxy.messages.in:
Ditto.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APILoaderClient.h
trunk/Source/WebKit/UIProcess/API/APINavigationClient.h
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (235199 => 235200)

--- trunk/Source/WebKit/ChangeLog	2018-08-22 20:46:41 UTC (rev 235199)
+++ trunk/Source/WebKit/ChangeLog	2018-08-22 21:08:38 UTC (rev 235200)
@@ -1,3 +1,59 @@
+2018-08-22  Jeff Miller  
+
+WKNavigationDelegate needs to allow clients to specify a custom blocked plug-in message
+https://bugs.webkit.org/show_bug.cgi?id=188764
+
+Reviewed by Alex Christensen.
+
+Add a new private WKNavigationDelegate method that takes a completion handler so clients can return
+a custom unavailability description in addition to the policy. Change WebPageProxy::findPlugin() to
+send a delayed reply and API::LoaderClient::pluginLoadPolicy()/API::NavigationClient::decidePolicyForPluginLoad()
+to take a completion handler to support this.
+
+* UIProcess/API/APILoaderClient.h:
+(API::LoaderClient::pluginLoadPolicy):
+Changed to take a completion handler. The default implementation doesn't return a custom
+unavailability description.
+
+* UIProcess/API/APINavigationClient.h:
+(API::NavigationClient::decidePolicyForPluginLoad):
+Ditto.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageLoaderClient):
+Changed pluginLoadPolicy() to take a completion handler.
+
+(WKPageSetPageNavigationClient):
+Changed decidePolicyForPluginLoad() to take a completion handler.
+
+* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
+Add alternate version of -decidePolicyForPluginLoadWithCurrentPolicy: that allows clients to return
+the unavailibility description.
+
+* UIProcess/Cocoa/NavigationState.h:
+Add flag for new delegate method.
+Changed decidePolicyForPluginLoad() to take a completion handler.
+
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::setNavigationDelegate):
+Calculate flag for new delegate method.
+
+(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad):
+Changed to take a completion handler.
+Prefer new delegate method, if available.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::findPlugin):
+Chan

[webkit-changes] [234157] trunk/Source/WebKit

2018-07-24 Thread jeffm

Title: [234157] trunk/Source/WebKit








Revision 234157
Author je...@apple.com
Date 2018-07-24 10:47:25 -0700 (Tue, 24 Jul 2018)


Log Message
WKUIDelegate needs an alternate decideDatabaseQuotaForSecurityOrigin method that provides the database name and display name
https://bugs.webkit.org/show_bug.cgi?id=187567

Reviewed by Alex Christensen.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
Declare alternate decideDatabaseQuotaForSecurityOrigin method, copying the existing FIXME comment
from the old method.

* UIProcess/Cocoa/UIDelegate.h:
Add flag for new delegate method.

* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
Initialize new flag.

(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):
Prefer the new UIDelegate method that takes the database name and display name, falling back to the
existing method if the client doesn't implement it.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (234156 => 234157)

--- trunk/Source/WebKit/ChangeLog	2018-07-24 17:40:12 UTC (rev 234156)
+++ trunk/Source/WebKit/ChangeLog	2018-07-24 17:47:25 UTC (rev 234157)
@@ -1,3 +1,25 @@
+2018-07-24  Jeff Miller  
+
+WKUIDelegate needs an alternate decideDatabaseQuotaForSecurityOrigin method that provides the database name and display name
+https://bugs.webkit.org/show_bug.cgi?id=187567
+
+Reviewed by Alex Christensen.
+
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+Declare alternate decideDatabaseQuotaForSecurityOrigin method, copying the existing FIXME comment
+from the old method.
+
+* UIProcess/Cocoa/UIDelegate.h:
+Add flag for new delegate method.
+
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::setDelegate):
+Initialize new flag.
+
+(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):
+Prefer the new UIDelegate method that takes the database name and display name, falling back to the
+existing method if the client doesn't implement it.
+
 2018-07-24  Stephan Szabo  
 
 [WinCairo] Add support to WebView for setting tooltips


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (234156 => 234157)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2018-07-24 17:40:12 UTC (rev 234156)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2018-07-24 17:47:25 UTC (rev 234157)
@@ -86,6 +86,9 @@
 - (void)_webView:(WKWebView *)webView decideDatabaseQuotaForSecurityOrigin:(WKSecurityOrigin *)securityOrigin currentQuota:(unsigned long long)currentQuota currentOriginUsage:(unsigned long long)currentOriginUsage currentDatabaseUsage:(unsigned long long)currentUsage expectedUsage:(unsigned long long)expectedUsage decisionHandler:(void (^)(unsigned long long newQuota))decisionHandler;
 
 // FIXME: This should be handled by the WKWebsiteDataStore delegate.
+- (void)_webView:(WKWebView *)webView decideDatabaseQuotaForSecurityOrigin:(WKSecurityOrigin *)securityOrigin databaseName:(NSString *)databaseName displayName:(NSString *)displayName currentQuota:(unsigned long long)currentQuota currentOriginUsage:(unsigned long long)currentOriginUsage currentDatabaseUsage:(unsigned long long)currentUsage expectedUsage:(unsigned long long)expectedUsage decisionHandler:(void (^)(unsigned long long newQuota))decisionHandler;
+
+// FIXME: This should be handled by the WKWebsiteDataStore delegate.
 - (void)_webView:(WKWebView *)webView decideWebApplicationCacheQuotaForSecurityOrigin:(WKSecurityOrigin *)securityOrigin currentQuota:(unsigned long long)currentQuota totalBytesNeeded:(unsigned long long)totalBytesNeeded decisionHandler:(void (^)(unsigned long long newQuota))decisionHandler;
 
 - (void)_webView:(WKWebView *)webView printFrame:(_WKFrameHandle *)frame;


Modified: trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h (234156 => 234157)

--- trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h	2018-07-24 17:40:12 UTC (rev 234156)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h	2018-07-24 17:47:25 UTC (rev 234157)
@@ -187,6 +187,7 @@
 bool webViewRequestNotificationPermissionForSecurityOriginDecisionHandler : 1;
 #endif
 bool webViewDecideDatabaseQuotaForSecurityOriginCurrentQuotaCurrentOriginUsageCurrentDatabaseUsageExpectedUsageDecisionHandler : 1;
+bool webViewDecideDatabaseQuotaForSecurityOriginDatabaseNameDisplayNameCurrentQuotaCurrentOriginUsageCurrentDatabaseUsageExpectedUsageDecisionHandler : 1;
 bool webViewDecideWebApplicationCacheQuotaForSecurityOriginCurrentQuotaTotalBytesNeeded : 1;
 bool webViewPrintFrame : 1;
 bool webViewDidClose : 1;


Modified: trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm (234156 => 234157)

--- trunk/Source/WebKit/UIProcess/Cocoa/UIDel

[webkit-changes] [232266] trunk/Source/WebKit

2018-05-29 Thread jeffm

Title: [232266] trunk/Source/WebKit








Revision 232266
Author je...@apple.com
Date 2018-05-29 11:10:55 -0700 (Tue, 29 May 2018)


Log Message
Expose additional WKMenuItemIdentifier strings
https://bugs.webkit.org/show_bug.cgi?id=186041

Reviewed by Dan Bernstein.

Expose identifiers for media-related menu items.

* UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
Define new identifiers.

* UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
Declare new identifiers.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
Map to new identifiers.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (232265 => 232266)

--- trunk/Source/WebKit/ChangeLog	2018-05-29 18:10:50 UTC (rev 232265)
+++ trunk/Source/WebKit/ChangeLog	2018-05-29 18:10:55 UTC (rev 232266)
@@ -1,3 +1,22 @@
+2018-05-28  Jeff Miller  
+
+Expose additional WKMenuItemIdentifier strings
+https://bugs.webkit.org/show_bug.cgi?id=186041
+
+Reviewed by Dan Bernstein.
+
+Expose identifiers for media-related menu items.
+
+* UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
+Define new identifiers.
+
+* UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
+Declare new identifiers.
+
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::menuItemIdentifier):
+Map to new identifiers.
+
 2018-05-29  Geoffrey Garen  
 
 Removed some unused WebSQL trackers


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm (232265 => 232266)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm	2018-05-29 18:10:50 UTC (rev 232265)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm	2018-05-29 18:10:55 UTC (rev 232266)
@@ -31,8 +31,10 @@
 NSString * const _WKMenuItemIdentifierCopy = @"WKMenuItemIdentifierCopy";
 NSString * const _WKMenuItemIdentifierCopyImage = @"WKMenuItemIdentifierCopyImage";
 NSString * const _WKMenuItemIdentifierCopyLink = @"WKMenuItemIdentifierCopyLink";
+NSString * const _WKMenuItemIdentifierCopyMediaLink = @"WKMenuItemIdentifierCopyMediaLink";
 NSString * const _WKMenuItemIdentifierDownloadImage = @"WKMenuItemIdentifierDownloadImage";
 NSString * const _WKMenuItemIdentifierDownloadLinkedFile = @"WKMenuItemIdentifierDownloadLinkedFile";
+NSString * const _WKMenuItemIdentifierDownloadMedia = @"WKMenuItemIdentifierDownloadMedia";
 NSString * const _WKMenuItemIdentifierGoBack = @"WKMenuItemIdentifierGoBack";
 NSString * const _WKMenuItemIdentifierGoForward = @"WKMenuItemIdentifierGoForward";
 NSString * const _WKMenuItemIdentifierInspectElement = @"WKMenuItemIdentifierInspectElement";
@@ -41,10 +43,12 @@
 NSString * const _WKMenuItemIdentifierOpenImageInNewWindow = @"WKMenuItemIdentifierOpenImageInNewWindow";
 NSString * const _WKMenuItemIdentifierOpenLink = @"WKMenuItemIdentifierOpenLink";
 NSString * const _WKMenuItemIdentifierOpenLinkInNewWindow = @"WKMenuItemIdentifierOpenLinkInNewWindow";
+NSString * const _WKMenuItemIdentifierOpenMediaInNewWindow = @"WKMenuItemIdentifierOpenMediaInNewWindow";
 NSString * const _WKMenuItemIdentifierPaste = @"WKMenuItemIdentifierPaste";
 NSString * const _WKMenuItemIdentifierReload = @"WKMenuItemIdentifierReload";
 NSString * const _WKMenuItemIdentifierSearchWeb = @"WKMenuItemIdentifierSearchWeb";
 NSString * const _WKMenuItemIdentifierShowHideMediaControls = @"WKMenuItemIdentifierShowHideMediaControls";
+NSString * const _WKMenuItemIdentifierToggleEnhancedFullScreen = @"WKMenuItemIdentifierToggleEnhancedFullScreen";
 NSString * const _WKMenuItemIdentifierToggleFullScreen = @"WKMenuItemIdentifierToggleFullScreen";
 
 NSString * const _WKMenuItemIdentifierShareMenu = @"WKMenuItemIdentifierShareMenu";


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h (232265 => 232266)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h	2018-05-29 18:10:50 UTC (rev 232265)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h	2018-05-29 18:10:55 UTC (rev 232266)
@@ -33,8 +33,10 @@
 WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopy WK_API_AVAILABLE(macosx(10.12), ios(10.0));
 WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopyImage WK_API_AVAILABLE(macosx(10.12), ios(10.0));
 WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopyLink WK_API_AVAILABLE(macosx(10.12), ios(10.0));
+WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopyMediaLink WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 WK_EXPORT extern NSString * const _WKMenuItemIdentifierDownloadImage WK_API_AVAILABLE(macosx(10.12), ios(10.0));
 WK_EXPORT extern NSString * const _WKMenuItemIdentifierDownloadLinkedFile WK_API_AVAILABLE(macosx(10.12), ios(10.0));
+WK_EXPOR

[webkit-changes] [229773] trunk/Source/WebKit

2018-03-20 Thread jeffm

Title: [229773] trunk/Source/WebKit








Revision 229773
Author je...@apple.com
Date 2018-03-20 14:21:06 -0700 (Tue, 20 Mar 2018)


Log Message
Expose aggressiveTileRetentionEnabled in WKPreferences SPI to match C SPI
https://bugs.webkit.org/show_bug.cgi?id=183790

Reviewed by Alex Christensen.

Expose this property on macOS only.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setAggressiveTileRetentionEnabled:]):
(-[WKPreferences _aggressiveTileRetentionEnabled]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (229772 => 229773)

--- trunk/Source/WebKit/ChangeLog	2018-03-20 20:37:46 UTC (rev 229772)
+++ trunk/Source/WebKit/ChangeLog	2018-03-20 21:21:06 UTC (rev 229773)
@@ -1,3 +1,17 @@
+2018-03-20  Jeff Miller  
+
+Expose aggressiveTileRetentionEnabled in WKPreferences SPI to match C SPI
+https://bugs.webkit.org/show_bug.cgi?id=183790
+
+Reviewed by Alex Christensen.
+
+Expose this property on macOS only.
+
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _setAggressiveTileRetentionEnabled:]):
+(-[WKPreferences _aggressiveTileRetentionEnabled]):
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
 2018-03-20  Tim Horton  
 
 Add and adopt WK_PLATFORM_NAME and adjust default feature defines


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (229772 => 229773)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm	2018-03-20 20:37:46 UTC (rev 229772)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm	2018-03-20 21:21:06 UTC (rev 229773)
@@ -1202,6 +1202,16 @@
 return _preferences->webAudioEnabled();
 }
 
+- (void)_setAggressiveTileRetentionEnabled:(BOOL)enabled
+{
+_preferences->setAggressiveTileRetentionEnabled(enabled);
+}
+
+- (BOOL)_aggressiveTileRetentionEnabled
+{
+return _preferences->aggressiveTileRetentionEnabled();
+}
+
 #endif // PLATFORM(MAC)
 
 - (BOOL)_javaScriptCanAccessClipboard


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (229772 => 229773)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h	2018-03-20 20:37:46 UTC (rev 229772)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h	2018-03-20 21:21:06 UTC (rev 229773)
@@ -180,6 +180,7 @@
 @property (nonatomic, setter=_setUseGiantTiles:) BOOL _useGiantTiles WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 @property (nonatomic, setter=_setWantsBalancedSetDefersLoadingBehavior:) BOOL _wantsBalancedSetDefersLoadingBehavior WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 @property (nonatomic, setter=_setWebAudioEnabled:) BOOL _webAudioEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
+@property (nonatomic, setter=_setAggressiveTileRetentionEnabled:) BOOL _aggressiveTileRetentionEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 #endif
 
 @end






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229294] trunk/Source/WebKit

2018-03-05 Thread jeffm

Title: [229294] trunk/Source/WebKit








Revision 229294
Author je...@apple.com
Date 2018-03-05 15:19:33 -0800 (Mon, 05 Mar 2018)


Log Message
Expose still more WKPreferences SPI to match C SPI
https://bugs.webkit.org/show_bug.cgi?id=183045

Reviewed by Alex Christensen.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setAllowsInlineMediaPlayback:]):
(-[WKPreferences _allowsInlineMediaPlayback]):
(-[WKPreferences _setApplePayEnabled:]):
(-[WKPreferences _applePayEnabled]):
(-[WKPreferences _setDNSPrefetchingEnabled:]):
(-[WKPreferences _dnsPrefetchingEnabled]):
(-[WKPreferences _setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
(-[WKPreferences _inlineMediaPlaybackRequiresPlaysInlineAttribute]):
(-[WKPreferences _setInvisibleMediaAutoplayNotPermitted:]):
(-[WKPreferences _invisibleMediaAutoplayNotPermitted]):
(-[WKPreferences _setLegacyEncryptedMediaAPIEnabled:]):
(-[WKPreferences _legacyEncryptedMediaAPIEnabled]):
(-[WKPreferences _setMainContentUserGestureOverrideEnabled:]):
(-[WKPreferences _mainContentUserGestureOverrideEnabled]):
(-[WKPreferences _setMediaStreamEnabled:]):
(-[WKPreferences _mediaStreamEnabled]):
(-[WKPreferences _setNeedsStorageAccessFromFileURLsQuirk:]):
(-[WKPreferences _needsStorageAccessFromFileURLsQuirk]):
(-[WKPreferences _setPDFPluginEnabled:]):
(-[WKPreferences _pdfPluginEnabled]):
(-[WKPreferences _setRequiresUserGestureForAudioPlayback:]):
(-[WKPreferences _requiresUserGestureForAudioPlayback]):
(-[WKPreferences _setRequiresUserGestureForVideoPlayback:]):
(-[WKPreferences _requiresUserGestureForVideoPlayback]):
(-[WKPreferences _setServiceControlsEnabled:]):
(-[WKPreferences _serviceControlsEnabled]):
(-[WKPreferences _setShowsToolTipOverTruncatedText:]):
(-[WKPreferences _showsToolTipOverTruncatedText]):
(-[WKPreferences _setTextAreasAreResizable:]):
(-[WKPreferences _textAreasAreResizable]):
(-[WKPreferences _setUseGiantTiles:]):
(-[WKPreferences _useGiantTiles]):
(-[WKPreferences _setWantsBalancedSetDefersLoadingBehavior:]):
(-[WKPreferences _wantsBalancedSetDefersLoadingBehavior]):
(-[WKPreferences _setWebAudioEnabled:]):
(-[WKPreferences _webAudioEnabled]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (229293 => 229294)

--- trunk/Source/WebKit/ChangeLog	2018-03-05 22:16:49 UTC (rev 229293)
+++ trunk/Source/WebKit/ChangeLog	2018-03-05 23:19:33 UTC (rev 229294)
@@ -1,3 +1,49 @@
+2018-03-05  Jeff Miller  
+
+Expose still more WKPreferences SPI to match C SPI
+https://bugs.webkit.org/show_bug.cgi?id=183045
+
+Reviewed by Alex Christensen.
+
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _setAllowsInlineMediaPlayback:]):
+(-[WKPreferences _allowsInlineMediaPlayback]):
+(-[WKPreferences _setApplePayEnabled:]):
+(-[WKPreferences _applePayEnabled]):
+(-[WKPreferences _setDNSPrefetchingEnabled:]):
+(-[WKPreferences _dnsPrefetchingEnabled]):
+(-[WKPreferences _setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
+(-[WKPreferences _inlineMediaPlaybackRequiresPlaysInlineAttribute]):
+(-[WKPreferences _setInvisibleMediaAutoplayNotPermitted:]):
+(-[WKPreferences _invisibleMediaAutoplayNotPermitted]):
+(-[WKPreferences _setLegacyEncryptedMediaAPIEnabled:]):
+(-[WKPreferences _legacyEncryptedMediaAPIEnabled]):
+(-[WKPreferences _setMainContentUserGestureOverrideEnabled:]):
+(-[WKPreferences _mainContentUserGestureOverrideEnabled]):
+(-[WKPreferences _setMediaStreamEnabled:]):
+(-[WKPreferences _mediaStreamEnabled]):
+(-[WKPreferences _setNeedsStorageAccessFromFileURLsQuirk:]):
+(-[WKPreferences _needsStorageAccessFromFileURLsQuirk]):
+(-[WKPreferences _setPDFPluginEnabled:]):
+(-[WKPreferences _pdfPluginEnabled]):
+(-[WKPreferences _setRequiresUserGestureForAudioPlayback:]):
+(-[WKPreferences _requiresUserGestureForAudioPlayback]):
+(-[WKPreferences _setRequiresUserGestureForVideoPlayback:]):
+(-[WKPreferences _requiresUserGestureForVideoPlayback]):
+(-[WKPreferences _setServiceControlsEnabled:]):
+(-[WKPreferences _serviceControlsEnabled]):
+(-[WKPreferences _setShowsToolTipOverTruncatedText:]):
+(-[WKPreferences _showsToolTipOverTruncatedText]):
+(-[WKPreferences _setTextAreasAreResizable:]):
+(-[WKPreferences _textAreasAreResizable]):
+(-[WKPreferences _setUseGiantTiles:]):
+(-[WKPreferences _useGiantTiles]):
+(-[WKPreferences _setWantsBalancedSetDefersLoadingBehavior:]):
+(-[WKPreferences _wantsBalancedSetDefersLoadingBehavior]):
+(-[WKPreferences _setWebAudioEnabled:]):
+(-[WKPreferences _webAudioEnabled]):
+*

[webkit-changes] [228194] trunk/Source/WebKit

2018-02-06 Thread jeffm

Title: [228194] trunk/Source/WebKit








Revision 228194
Author je...@apple.com
Date 2018-02-06 14:45:24 -0800 (Tue, 06 Feb 2018)


Log Message
Add WKNavigationDelegate SPI to tell the client when an insecure plug-in is blocked
https://bugs.webkit.org/show_bug.cgi?id=182540

Reviewed by Alex Christensen.

* UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didBlockInsecurePluginVersion):
Changed to take a dictionary reference.

* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::didBlockInsecurePluginVersion):
Added.

* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
Changed didBlockInsecurePluginVersion() to take a dictionary reference.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
Added -_webView:didBlockInsecurePluginVersionWithInfo:.

* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
Initialize webViewDidBlockInsecurePluginVersionWithInfo.

(WebKit::NavigationState::NavigationClient::didBlockInsecurePluginVersion):
Added.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Remove check for PLATFORM(COCOA) (we don't check for this in didFailToInitializePlugin() where we
also use createPluginInformationDictionary()) and ENABLE(NETSCAPE_PLUGIN_API) (we're already inside
an #if ENABLE(NETSCAPE_PLUGIN_API block) and use auto for pluginInformation. Attempt to use the
navigation client before the loader client.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APILoaderClient.h
trunk/Source/WebKit/UIProcess/API/APINavigationClient.h
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (228193 => 228194)

--- trunk/Source/WebKit/ChangeLog	2018-02-06 22:42:26 UTC (rev 228193)
+++ trunk/Source/WebKit/ChangeLog	2018-02-06 22:45:24 UTC (rev 228194)
@@ -1,3 +1,40 @@
+2018-02-06  Jeff Miller  
+
+Add WKNavigationDelegate SPI to tell the client when an insecure plug-in is blocked
+https://bugs.webkit.org/show_bug.cgi?id=182540
+
+Reviewed by Alex Christensen.
+
+* UIProcess/API/APILoaderClient.h:
+(API::LoaderClient::didBlockInsecurePluginVersion):
+Changed to take a dictionary reference.
+
+* UIProcess/API/APINavigationClient.h:
+(API::NavigationClient::didBlockInsecurePluginVersion):
+Added.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageLoaderClient):
+Changed didBlockInsecurePluginVersion() to take a dictionary reference.
+
+* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
+Added -_webView:didBlockInsecurePluginVersionWithInfo:.
+
+* UIProcess/Cocoa/NavigationState.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::setNavigationDelegate):
+Initialize webViewDidBlockInsecurePluginVersionWithInfo.
+
+(WebKit::NavigationState::NavigationClient::didBlockInsecurePluginVersion):
+Added.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
+Remove check for PLATFORM(COCOA) (we don't check for this in didFailToInitializePlugin() where we
+also use createPluginInformationDictionary()) and ENABLE(NETSCAPE_PLUGIN_API) (we're already inside
+an #if ENABLE(NETSCAPE_PLUGIN_API block) and use auto for pluginInformation. Attempt to use the
+navigation client before the loader client.
+
 2018-02-06  Youenn Fablet  
 
 HasServiceWorkerRegistration bit should be sent when creating a new page


Modified: trunk/Source/WebKit/UIProcess/API/APILoaderClient.h (228193 => 228194)

--- trunk/Source/WebKit/UIProcess/API/APILoaderClient.h	2018-02-06 22:42:26 UTC (rev 228193)
+++ trunk/Source/WebKit/UIProcess/API/APILoaderClient.h	2018-02-06 22:45:24 UTC (rev 228194)
@@ -105,7 +105,7 @@
 #if ENABLE(NETSCAPE_PLUGIN_API)
 virtual WebKit::PluginModuleLoadPolicy pluginLoadPolicy(WebKit::WebPageProxy&, WebKit::PluginModuleLoadPolicy currentPluginLoadPolicy, API::Dictionary&, WTF::String& /* unavailabilityDescription */) { return currentPluginLoadPolicy; }
 virtual void didFailToInitializePlugin(WebKit::WebPageProxy&, API::Dictionary&) { }
-virtual void didBlockInsecurePluginVersion(WebKit::WebPageProxy&, API::Dictionary*) { }
+virtual void didBlockInsecurePluginVersion(WebKit::WebPageProxy&, API::Dictionary&) { }
 #endif // ENABLE(NETSCAPE_PLUGIN_API)
 
 #if ENABLE(WEBGL)


Modified: trunk/Source/WebKit/UIProcess/API/APINavigationClient.h (228193 => 228194)

--- trunk/Source/WebKit/UIProcess/API/APINavigationClient.h	2018-02-06 22:42:26 UTC (rev 228193)
+++ trunk/Source/WebKit/UIProcess/API/APINavigationClient.h	2018-02-06 22:

[webkit-changes] [226762] trunk/Source/WebKit

2018-01-10 Thread jeffm

Title: [226762] trunk/Source/WebKit








Revision 226762
Author je...@apple.com
Date 2018-01-10 22:34:22 -0800 (Wed, 10 Jan 2018)


Log Message
-[WKWebView _web_gestureEventWasNotHandledByWebCore:] should call -_gestureEventWasNotHandledByWebCore:
https://bugs.webkit.org/show_bug.cgi?id=181498

Reviewed by Alex Christensen.

WKView's API contract allows clients to override -_gestureEventWasNotHandledByWebCore:, and -[WKView
_web_gestureEventWasNotHandledByWebCore:] calls -_gestureEventWasNotHandledByWebCore: instead of
invoking WebViewImpl::gestureEventWasNotHandledByWebCoreFromViewOnly() directly. WKWebView should do
the same thing.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _web_gestureEventWasNotHandledByWebCore:]):
Call -_gestureEventWasNotHandledByWebCore:, which will call gestureEventWasNotHandledByWebCoreFromViewOnly().

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (226761 => 226762)

--- trunk/Source/WebKit/ChangeLog	2018-01-11 06:13:01 UTC (rev 226761)
+++ trunk/Source/WebKit/ChangeLog	2018-01-11 06:34:22 UTC (rev 226762)
@@ -1,3 +1,19 @@
+2018-01-10  Jeff Miller  
+
+-[WKWebView _web_gestureEventWasNotHandledByWebCore:] should call -_gestureEventWasNotHandledByWebCore:
+https://bugs.webkit.org/show_bug.cgi?id=181498
+
+Reviewed by Alex Christensen.
+
+WKView's API contract allows clients to override -_gestureEventWasNotHandledByWebCore:, and -[WKView
+_web_gestureEventWasNotHandledByWebCore:] calls -_gestureEventWasNotHandledByWebCore: instead of
+invoking WebViewImpl::gestureEventWasNotHandledByWebCoreFromViewOnly() directly. WKWebView should do
+the same thing.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _web_gestureEventWasNotHandledByWebCore:]):
+Call -_gestureEventWasNotHandledByWebCore:, which will call gestureEventWasNotHandledByWebCoreFromViewOnly().
+
 2018-01-10  Wenson Hsieh  
 
 REGRESSION(r222507): Composition highlight doesn't render when using IME


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (226761 => 226762)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-01-11 06:13:01 UTC (rev 226761)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-01-11 06:34:22 UTC (rev 226762)
@@ -3853,7 +3853,7 @@
 
 - (void)_web_gestureEventWasNotHandledByWebCore:(NSEvent *)event
 {
-_impl->gestureEventWasNotHandledByWebCoreFromViewOnly(event);
+[self _gestureEventWasNotHandledByWebCore:event];
 }
 
 #endif // PLATFORM(MAC)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226318] trunk

2018-01-01 Thread jeffm

Title: [226318] trunk








Revision 226318
Author je...@apple.com
Date 2018-01-01 15:42:50 -0800 (Mon, 01 Jan 2018)


Log Message
Source/_javascript_Core:
Update user-visible copyright strings to include 2018
https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

* Info.plist:

Source/WebCore:
Update user-visible copyright strings to include 2018
https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

* Info.plist:

Source/WebKit:
[Attachment Support] Remove current macOS support for dragging file-backed attachments
https://bugs.webkit.org/show_bug.cgi?id=181188

Patch by Wenson Hsieh  on 2017-12-30
Reviewed by Dan Bernstein.

See WebCore/ChangeLog for more detail.

* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setPromisedDataForAttachment): Deleted.
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setPromisedDataForAttachment): Deleted.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/PageClientImplMac.h:
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::setPromisedDataForAttachment): Deleted.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setPromisedDataForAttachment): Deleted.
* WebProcess/WebCoreSupport/WebDragClient.h:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteAttachment): Deleted.

Source/WebKitLegacy/mac:
Update user-visible copyright strings to include 2018
https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

* Info.plist:

WebKitLibraries:
Update user-visible copyright strings to include 2018
https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Info.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist
trunk/Source/WebKit/StorageProcess/EntryPoint/mac/XPCService/StorageService/Info.plist
trunk/Source/WebKit/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Info.plist
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226317 => 226318)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-01 20:32:33 UTC (rev 226317)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-01 23:42:50 UTC (rev 226318)
@@ -1,3 +1,12 @@
+2017-12-22  Jeff Miller  
+
+Update user-visible copyright strings to include 2018
+https://bugs.webkit.org/show_bug.cgi?id=181141
+
+Reviewed by Dan Bernstein.
+
+* Info.plist:
+
 2017-12-30  Yusuke Suzuki  
 
 [JSC] Remove unused JSTypes


Modified: trunk/Source/_javascript_Core/Info.plist (226317 => 226318)

--- trunk/Source/_javascript_Core/Info.plist	2018-01-01 20:32:33 UTC (rev 226317)
+++ trunk/Source/_javascript_Core/Info.plist	2018-01-01 23:42:50 UTC (rev 226318)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2017 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+	${BUNDLE_VERSION}, Copyright 2003-2018 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
 	CFBundleIdentifier
 	${PRODUCT_BUNDLE_IDENTIFIER}
 	CFBundleInfoDictionaryVersion


Modified: trunk/Source/WebCore/ChangeLog (226317 => 226318)

--- trunk/Source/WebCore/ChangeLog	2018-01-01 20:32:33 UTC (rev 226317)
+++ trunk/Source/WebCore/ChangeLog	2018-01-01 23:42:50 UTC (rev 226318)
@@ -1,3 +1,12 @@
+2017-12-22  Jeff Miller  
+
+Update user-visible copyright strings to include 2018
+https://bugs.webkit.org/show_bug.cgi?id=181141
+
+Reviewed by Dan Bernstein.
+
+* Info.plist:
+
 2017-12-30  Simon Fraser  
 
 REGRESSION (r225122): fePointLights don't work


Modified: trunk/Source/WebCore/Info.plist (226317 => 226318)

--- trunk/Source/WebCore/Info.plist	2018-01-01 20:32:33 UTC (rev 226317)
+++ trunk/Source/WebCore/Info.plist	2018-01-01 23:42:50 UTC (rev 226318)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyr

[webkit-changes] [226286] trunk/Source/WebKit

2017-12-22 Thread jeffm

Title: [226286] trunk/Source/WebKit








Revision 226286
Author je...@apple.com
Date 2017-12-22 16:00:42 -0800 (Fri, 22 Dec 2017)


Log Message
Allow WebsitePolicies API object to be bridged to _WKWebsitePolicies
https://bugs.webkit.org/show_bug.cgi?id=181135

Reviewed by Dan Bernstein.

_WKWebsitePolicies already wraps WebsitePolicies, we just never hooked this up in newObject().

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/APIObject.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (226285 => 226286)

--- trunk/Source/WebKit/ChangeLog	2017-12-22 23:50:11 UTC (rev 226285)
+++ trunk/Source/WebKit/ChangeLog	2017-12-23 00:00:42 UTC (rev 226286)
@@ -1,3 +1,15 @@
+2017-12-22  Jeff Miller  
+
+Allow WebsitePolicies API object to be bridged to _WKWebsitePolicies
+https://bugs.webkit.org/show_bug.cgi?id=181135
+
+Reviewed by Dan Bernstein.
+
+_WKWebsitePolicies already wraps WebsitePolicies, we just never hooked this up in newObject().
+
+* Shared/Cocoa/APIObject.mm:
+(API::Object::newObject):
+
 2017-12-22  Wenson Hsieh  
 
 Fix build failures due to using deprecated AppKit symbols


Modified: trunk/Source/WebKit/Shared/Cocoa/APIObject.mm (226285 => 226286)

--- trunk/Source/WebKit/Shared/Cocoa/APIObject.mm	2017-12-22 23:50:11 UTC (rev 226285)
+++ trunk/Source/WebKit/Shared/Cocoa/APIObject.mm	2017-12-23 00:00:42 UTC (rev 226286)
@@ -80,6 +80,7 @@
 #import "_WKUserInitiatedActionInternal.h"
 #import "_WKUserStyleSheetInternal.h"
 #import "_WKVisitedLinkStoreInternal.h"
+#import "_WKWebsitePoliciesInternal.h"
 
 #if ENABLE(APPLICATION_MANIFEST)
 #import "_WKApplicationManifestInternal.h"
@@ -316,6 +317,10 @@
 wrapper = [WKWebsiteDataStore alloc];
 break;
 
+case Type::WebsitePolicies:
+wrapper = [_WKWebsitePolicies alloc];
+break;
+
 case Type::WindowFeatures:
 wrapper = [WKWindowFeatures alloc];
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225603] trunk

2017-12-06 Thread jeffm

Title: [225603] trunk








Revision 225603
Author je...@apple.com
Date 2017-12-06 16:18:47 -0800 (Wed, 06 Dec 2017)


Log Message
-[WKWebViewConfiguration copyWithZone] doesn't copy _groupIdentifier
https://bugs.webkit.org/show_bug.cgi?id=180504

Reviewed by Geoffrey Garen.

Source/WebKit:

* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
Copy _groupIdentifier.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
Add a test to verify that the _groupIdentifier is copied.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (225602 => 225603)

--- trunk/Source/WebKit/ChangeLog	2017-12-07 00:02:55 UTC (rev 225602)
+++ trunk/Source/WebKit/ChangeLog	2017-12-07 00:18:47 UTC (rev 225603)
@@ -1,3 +1,14 @@
+2017-12-06  Jeff Miller  
+
+-[WKWebViewConfiguration copyWithZone] doesn't copy _groupIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=180504
+
+Reviewed by Geoffrey Garen.
+
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration copyWithZone:]):
+Copy _groupIdentifier.
+
 2017-12-06  David Quesada  
 
 [Web App Manifest] Add SPI for fetching the manifest


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (225602 => 225603)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2017-12-07 00:02:55 UTC (rev 225602)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2017-12-07 00:18:47 UTC (rev 225603)
@@ -361,6 +361,8 @@
 configuration->_legacyEncryptedMediaAPIEnabled = self->_legacyEncryptedMediaAPIEnabled;
 configuration->_allowMediaContentTypesRequiringHardwareSupportAsFallback = self->_allowMediaContentTypesRequiringHardwareSupportAsFallback;
 
+configuration->_groupIdentifier = adoptNS([self->_groupIdentifier copyWithZone:zone]);
+
 return configuration;
 }
 


Modified: trunk/Tools/ChangeLog (225602 => 225603)

--- trunk/Tools/ChangeLog	2017-12-07 00:02:55 UTC (rev 225602)
+++ trunk/Tools/ChangeLog	2017-12-07 00:18:47 UTC (rev 225603)
@@ -1,3 +1,13 @@
+2017-12-06  Jeff Miller  
+
+-[WKWebViewConfiguration copyWithZone] doesn't copy _groupIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=180504
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
+Add a test to verify that the _groupIdentifier is copied.
+
 2017-12-06  David Quesada  
 
 [Web App Manifest] Add SPI for fetching the manifest


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm (225602 => 225603)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm	2017-12-07 00:02:55 UTC (rev 225602)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm	2017-12-07 00:18:47 UTC (rev 225603)
@@ -66,4 +66,13 @@
 #pragma clang diagnostic pop
 }
 
+TEST(WebKit, ConfigurationGroupIdentifierIsCopied)
+{
+auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
+[configuration _setGroupIdentifier:@"TestGroupIdentifier"];
+
+auto configuationCopy = adoptNS([configuration copy]);
+EXPECT_STREQ([configuration _groupIdentifier].UTF8String, [configuationCopy _groupIdentifier].UTF8String);
+}
+
 #endif // WK_API_ENABLED






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219533] trunk

2017-07-14 Thread jeffm

Title: [219533] trunk








Revision 219533
Author je...@apple.com
Date 2017-07-14 16:13:33 -0700 (Fri, 14 Jul 2017)


Log Message
Source/WebKit:
-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:] passing wrong parameters to -setParameter:forKey
https://bugs.webkit.org/show_bug.cgi?id=174524

Reviewed by Sam Weinig.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:]):
Pass the dictionary key and value in the correct order.

Tools:
Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
https://bugs.webkit.org/show_bug.cgi?id=174524

Reviewed by Sam Weinig.

* TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
(TEST):
Renamed TestParameter to TestParameter1.
Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].

* TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
(-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
Observe changes for two bundle parameters.

(-[BundleParametersPlugIn dealloc]):
Remove observers for two bundle parameters.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (219532 => 219533)

--- trunk/Source/WebKit/ChangeLog	2017-07-14 23:03:13 UTC (rev 219532)
+++ trunk/Source/WebKit/ChangeLog	2017-07-14 23:13:33 UTC (rev 219533)
@@ -1,3 +1,14 @@
+2017-07-14  Jeff Miller  
+
+-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:] passing wrong parameters to -setParameter:forKey
+https://bugs.webkit.org/show_bug.cgi?id=174524
+
+Reviewed by Sam Weinig.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
+(-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:]):
+Pass the dictionary key and value in the correct order.
+
 2017-07-14  Brent Fulgham  
 
 Monitor directory for new statistics files after a delete operation


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm (219532 => 219533)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm	2017-07-14 23:03:13 UTC (rev 219532)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm	2017-07-14 23:13:33 UTC (rev 219533)
@@ -64,7 +64,7 @@
 - (void)setParametersForKeyWithDictionary:(NSDictionary *)dictionary
 {
 [dictionary enumerateKeysAndObjectsUsingBlock:^(NSString *key, id parameter, BOOL*) {
-[self setParameter:key forKey:parameter];
+[self setParameter:parameter forKey:key];
 }];
 }
 


Modified: trunk/Tools/ChangeLog (219532 => 219533)

--- trunk/Tools/ChangeLog	2017-07-14 23:03:13 UTC (rev 219532)
+++ trunk/Tools/ChangeLog	2017-07-14 23:13:33 UTC (rev 219533)
@@ -1,3 +1,22 @@
+2017-07-14  Jeff Miller  
+
+Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
+https://bugs.webkit.org/show_bug.cgi?id=174524
+
+Reviewed by Sam Weinig.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
+(TEST):
+Renamed TestParameter to TestParameter1.
+Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
+(-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+Observe changes for two bundle parameters.
+
+(-[BundleParametersPlugIn dealloc]):
+Remove observers for two bundle parameters.
+
 2017-07-14  Commit Queue  
 
 Unreviewed, rolling out r219510.


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm (219532 => 219533)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm	2017-07-14 23:03:13 UTC (rev 219532)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm	2017-07-14 23:13:33 UTC (rev 219533)
@@ -51,8 +51,8 @@
 TestWebKitAPI::Util::run(&isDone);
 isDone = false;
 
-NSString * const testParameter = @"TestParameter";
-[webView evaluateJavaScript:testParameter completionHandler:^(id result, NSError *error) {
+NSString * const testParameter1 = @"TestParameter1";
+[webView evaluateJavaScript:testParameter1 completionHandler:^(id result, NSError *error) {
 EXPECT_NULL(result);
 isDone = true;
 }];
@@ -61,8 +61,8 @@
 isDone = false;
 
 NSString * const testString = @"PASS";
-[[configuration processPool] _setObject:testString forBundleParameter:testParameter];
-[webView evaluateJavaScript:testParameter completionHandler:^(id result

[webkit-changes] [210221] trunk

2017-01-01 Thread jeffm

Title: [210221] trunk








Revision 210221
Author je...@apple.com
Date 2017-01-01 12:23:01 -0800 (Sun, 01 Jan 2017)


Log Message
Update user-visible copyright strings to include 2017
https://bugs.webkit.org/show_bug.cgi?id=166278

Reviewed by Dan Bernstein.

Source/_javascript_Core:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit/mac:

* Info.plist:

Source/WebKit2:

* DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:
* Info.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Info.plist
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist
trunk/Source/WebKit2/Info.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (210220 => 210221)

--- trunk/Source/_javascript_Core/ChangeLog	2017-01-01 16:46:34 UTC (rev 210220)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-01-01 20:23:01 UTC (rev 210221)
@@ -1,3 +1,12 @@
+2017-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2017
+https://bugs.webkit.org/show_bug.cgi?id=166278
+
+Reviewed by Dan Bernstein.
+
+* Info.plist:
+
 2016-12-28  Saam Barati  
 
 WebAssembly: Don't allow duplicate export names


Modified: trunk/Source/_javascript_Core/Info.plist (210220 => 210221)

--- trunk/Source/_javascript_Core/Info.plist	2017-01-01 16:46:34 UTC (rev 210220)
+++ trunk/Source/_javascript_Core/Info.plist	2017-01-01 20:23:01 UTC (rev 210221)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2016 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+	${BUNDLE_VERSION}, Copyright 2003-2017 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
 	CFBundleIdentifier
 	${PRODUCT_BUNDLE_IDENTIFIER}
 	CFBundleInfoDictionaryVersion


Modified: trunk/Source/WebCore/ChangeLog (210220 => 210221)

--- trunk/Source/WebCore/ChangeLog	2017-01-01 16:46:34 UTC (rev 210220)
+++ trunk/Source/WebCore/ChangeLog	2017-01-01 20:23:01 UTC (rev 210221)
@@ -1,3 +1,12 @@
+2017-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2017
+https://bugs.webkit.org/show_bug.cgi?id=166278
+
+Reviewed by Dan Bernstein.
+
+* Info.plist:
+
 2017-01-01  Zan Dobersek  
 
 GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder diversion


Modified: trunk/Source/WebCore/Info.plist (210220 => 210221)

--- trunk/Source/WebCore/Info.plist	2017-01-01 16:46:34 UTC (rev 210220)
+++ trunk/Source/WebCore/Info.plist	2017-01-01 20:23:01 UTC (rev 210221)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2016 Apple Inc.; Copyright 1997 Martin Jones ; Copyright 1998, 1999 Torben Weis ; Copyright 1998, 1999, 2002 Waldo Bastian ; Copyright 1998-2000 Lars Knoll ; Copyright 1999, 2001 Antti Koivisto

[webkit-changes] [196073] branches/safari-601-branch/Source/WebKit2

2016-02-03 Thread jeffm

Title: [196073] branches/safari-601-branch/Source/WebKit2








Revision 196073
Author je...@apple.com
Date 2016-02-03 12:14:36 -0800 (Wed, 03 Feb 2016)


Log Message
Update WebKit2.framework copyright string to include 2016.

This framework no longer exists on trunk, so we missed this as part of the merge of r194479.

* mac/Info-WebKit2.plist:

Modified Paths

branches/safari-601-branch/Source/WebKit2/ChangeLog
branches/safari-601-branch/Source/WebKit2/mac/Info-WebKit2.plist




Diff

Modified: branches/safari-601-branch/Source/WebKit2/ChangeLog (196072 => 196073)

--- branches/safari-601-branch/Source/WebKit2/ChangeLog	2016-02-03 18:58:46 UTC (rev 196072)
+++ branches/safari-601-branch/Source/WebKit2/ChangeLog	2016-02-03 20:14:36 UTC (rev 196073)
@@ -1,3 +1,11 @@
+2016-02-03  Jeff Miller  
+
+Update WebKit2.framework copyright string to include 2016.
+
+This framework no longer exists on trunk, so we missed this as part of the merge of r194479.
+
+* mac/Info-WebKit2.plist:
+
 2016-01-29  Babak Shafiei  
 
 Merge r194479.


Modified: branches/safari-601-branch/Source/WebKit2/mac/Info-WebKit2.plist (196072 => 196073)

--- branches/safari-601-branch/Source/WebKit2/mac/Info-WebKit2.plist	2016-02-03 18:58:46 UTC (rev 196072)
+++ branches/safari-601-branch/Source/WebKit2/mac/Info-WebKit2.plist	2016-02-03 20:14:36 UTC (rev 196073)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2015 Apple Inc.
+	${BUNDLE_VERSION}, Copyright 2003-2016 Apple Inc.
 	CFBundleIdentifier
 	com.apple.${PRODUCT_NAME}
 	CFBundleInfoDictionaryVersion






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194479] trunk

2016-01-01 Thread jeffm

Title: [194479] trunk








Revision 194479
Author je...@apple.com
Date 2016-01-01 08:30:12 -0800 (Fri, 01 Jan 2016)


Log Message
Update user-visible copyright strings to include 2016
https://bugs.webkit.org/show_bug.cgi?id=152531

Reviewed by Alexey Proskuryakov.

Source/_javascript_Core:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit/mac:

* Info.plist:

Source/WebKit2:

* DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:
* DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:
* Info.plist:
* NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Info.plist
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist
trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist
trunk/Source/WebKit2/Info.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194478 => 194479)

--- trunk/Source/_javascript_Core/ChangeLog	2016-01-01 07:53:30 UTC (rev 194478)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-01-01 16:30:12 UTC (rev 194479)
@@ -1,3 +1,12 @@
+2016-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2016
+https://bugs.webkit.org/show_bug.cgi?id=152531
+
+Reviewed by Alexey Proskuryakov.
+
+* Info.plist:
+
 2015-12-31  Andy Estes  
 
 Fix warnings uncovered by migrating to WTF_MOVE


Modified: trunk/Source/_javascript_Core/Info.plist (194478 => 194479)

--- trunk/Source/_javascript_Core/Info.plist	2016-01-01 07:53:30 UTC (rev 194478)
+++ trunk/Source/_javascript_Core/Info.plist	2016-01-01 16:30:12 UTC (rev 194479)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2015 Apple Inc.; Copyright 1999-200

[webkit-changes] [188584] trunk/Source/WebKit/mac

2015-08-18 Thread jeffm

Title: [188584] trunk/Source/WebKit/mac








Revision 188584
Author je...@apple.com
Date 2015-08-18 10:56:17 -0700 (Tue, 18 Aug 2015)


Log Message
Add a method to WebInspector to indicate whether the inspector is open
https://bugs.webkit.org/show_bug.cgi?id=148087

Reviewed by Joseph Pecoraro.

* WebInspector/WebInspector.h:
Added open property.

* WebInspector/WebInspector.mm:
(-[WebInspector isOpen]):
Added, returns YES if we have a frontend.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebInspector/WebInspector.h
trunk/Source/WebKit/mac/WebInspector/WebInspector.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (188583 => 188584)

--- trunk/Source/WebKit/mac/ChangeLog	2015-08-18 17:37:21 UTC (rev 188583)
+++ trunk/Source/WebKit/mac/ChangeLog	2015-08-18 17:56:17 UTC (rev 188584)
@@ -1,3 +1,17 @@
+2015-08-17  Jeff Miller  
+
+Add a method to WebInspector to indicate whether the inspector is open
+https://bugs.webkit.org/show_bug.cgi?id=148087
+
+Reviewed by Joseph Pecoraro.
+
+* WebInspector/WebInspector.h:
+Added open property.
+
+* WebInspector/WebInspector.mm:
+(-[WebInspector isOpen]):
+Added, returns YES if we have a frontend.
+
 2015-08-13  Andy Estes  
 
 [Cocoa] Downloads do not start if policy decision is made asynchronously


Modified: trunk/Source/WebKit/mac/WebInspector/WebInspector.h (188583 => 188584)

--- trunk/Source/WebKit/mac/WebInspector/WebInspector.h	2015-08-18 17:37:21 UTC (rev 188583)
+++ trunk/Source/WebKit/mac/WebInspector/WebInspector.h	2015-08-18 17:56:17 UTC (rev 188584)
@@ -61,4 +61,6 @@
 - (void)toggleProfilingJavaScript:(id)sender;
 - (void)startProfilingJavaScript:(id)sender;
 - (void)stopProfilingJavaScript:(id)sender;
+
+@property (nonatomic, readonly, getter=isOpen) BOOL open;
 @end


Modified: trunk/Source/WebKit/mac/WebInspector/WebInspector.mm (188583 => 188584)

--- trunk/Source/WebKit/mac/WebInspector/WebInspector.mm	2015-08-18 17:37:21 UTC (rev 188583)
+++ trunk/Source/WebKit/mac/WebInspector/WebInspector.mm	2015-08-18 17:56:17 UTC (rev 188584)
@@ -150,6 +150,11 @@
 [_frontend setTimelineProfilingEnabled:enabled];
 }
 
+- (BOOL)isOpen
+{
+return !!_frontend;
+}
+
 - (void)close:(id)sender 
 {
 if (Page* page = core(_webView))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177849] trunk

2015-01-01 Thread jeffm

Title: [177849] trunk








Revision 177849
Author je...@apple.com
Date 2015-01-01 14:21:15 -0800 (Thu, 01 Jan 2015)


Log Message
Update user-visible copyright strings to include 2015
https://bugs.webkit.org/show_bug.cgi?id=139880

Reviewed by Darin Adler.

Source/_javascript_Core:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit/mac:

* Info.plist:

Source/WebKit2:

* DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:
* DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:
* Info.plist:
* NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
* mac/Info-WebKit2.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Info.plist
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist
trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist
trunk/Source/WebKit2/Info.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist
trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist
trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist
trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist
trunk/Source/WebKit2/mac/Info-WebKit2.plist
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (177848 => 177849)

--- trunk/Source/_javascript_Core/ChangeLog	2015-01-01 21:20:21 UTC (rev 177848)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-01-01 22:21:15 UTC (rev 177849)
@@ -1,3 +1,12 @@
+2015-01-01  Jeff Miller  
+
+Update user-visible copyright strings to include 2015
+https://bugs.webkit.org/show_bug.cgi?id=139880
+
+Reviewed by Darin Adler.
+
+* Info.plist:
+
 2015-01-01  Darin Adler  
 
 We often misspell identifier as "identifer"


Modified: trunk/Source/_javascript_Core/Info.plist (177848 => 177849)

--- trunk/Source/_javascript_Core/Info.plist	2015-01-01 21:20:21 UTC (rev 177848)
+++ trunk/Source/_javascript_Core/Info.plist	2015-01-01 22:21:15 UTC (rev 177849)
@@ -7,7 +7,7 @@
 	CFBundleExecutable
 	${PRODUCT_NAME}
 	CFBundleGetInfoString
-	${BUNDLE_VERSION}, Copyright 2003-2014 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+	${BUNDLE_VERSION}, Copyright 2003-2015 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
 	CFBundleIdentifier
 	com.apple.${PRODUCT_NAME}
 	CFBundleInfoDictionaryVersion


Modified: t

[webkit-changes] [175002] trunk/Source/WebKit2

2014-10-21 Thread jeffm

Title: [175002] trunk/Source/WebKit2








Revision 175002
Author je...@apple.com
Date 2014-10-21 16:38:12 -0700 (Tue, 21 Oct 2014)


Log Message
Remove const from WKURLRequestRef parameter to WKContextDownloadURLRequest()
https://bugs.webkit.org/show_bug.cgi?id=137928

Reviewed by Darin Adler.

* UIProcess/API/C/WKContext.cpp:
(WKContextDownloadURLRequest):
* UIProcess/API/C/WKContext.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (175001 => 175002)

--- trunk/Source/WebKit2/ChangeLog	2014-10-21 23:32:44 UTC (rev 175001)
+++ trunk/Source/WebKit2/ChangeLog	2014-10-21 23:38:12 UTC (rev 175002)
@@ -1,3 +1,14 @@
+2014-10-21  Jeff Miller  
+
+Remove const from WKURLRequestRef parameter to WKContextDownloadURLRequest()
+https://bugs.webkit.org/show_bug.cgi?id=137928
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextDownloadURLRequest):
+* UIProcess/API/C/WKContext.h:
+
 2014-10-21  Anders Carlsson  
 
 WKRemoteObjectCoder should handle floats


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (175001 => 175002)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2014-10-21 23:32:44 UTC (rev 175001)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2014-10-21 23:38:12 UTC (rev 175002)
@@ -277,7 +277,7 @@
 toImpl(contextRef)->initializeConnectionClient(wkClient);
 }
 
-WKDownloadRef WKContextDownloadURLRequest(WKContextRef contextRef, const WKURLRequestRef requestRef)
+WKDownloadRef WKContextDownloadURLRequest(WKContextRef contextRef, WKURLRequestRef requestRef)
 {
 return toAPI(toImpl(contextRef)->download(0, toImpl(requestRef)->resourceRequest()));
 }


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (175001 => 175002)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h	2014-10-21 23:32:44 UTC (rev 175001)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h	2014-10-21 23:38:12 UTC (rev 175002)
@@ -110,7 +110,7 @@
 WK_EXPORT void WKContextSetDownloadClient(WKContextRef context, const WKContextDownloadClientBase* client);
 WK_EXPORT void WKContextSetConnectionClient(WKContextRef context, const WKContextConnectionClientBase* client);
 
-WK_EXPORT WKDownloadRef WKContextDownloadURLRequest(WKContextRef context, const WKURLRequestRef request);
+WK_EXPORT WKDownloadRef WKContextDownloadURLRequest(WKContextRef context, WKURLRequestRef request);
 WK_EXPORT WKDownloadRef WKContextResumeDownload(WKContextRef context, WKDataRef resumeData, WKStringRef path);
 
 WK_EXPORT void WKContextSetInitializationUserDataForInjectedBundle(WKContextRef context, WKTypeRef userData);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [174987] trunk/Source/WebKit2

2014-10-21 Thread jeffm

Title: [174987] trunk/Source/WebKit2








Revision 174987
Author je...@apple.com
Date 2014-10-21 10:46:11 -0700 (Tue, 21 Oct 2014)


Log Message
WKContext needs to provide an API to resume a download
https://bugs.webkit.org/show_bug.cgi?id=137507

Reviewed by Darin Adler.

This patch adds WKContextResumeDownload(), which is only supported on the Mac, and requires the
resume data from WKDownloadGetResumeData().

We have to create a sandbox extension for the partially downloaded file in the UI process so the
network or web process can resume writing to it.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::resumeDownload):
Added, calls through to DownloadManager::resumeDownload().

* NetworkProcess/NetworkProcess.h:
Added resumeDownload().

* NetworkProcess/NetworkProcess.messages.in:
Added ResumeDownload message.

* Shared/Downloads/Download.h:
Added resume().

* Shared/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::resumeDownload):
Added. The URL being downloaded is part of the opaque resumeData, so we can't specify it when the
Download is constructed.

* Shared/Downloads/DownloadManager.h:
Added resumeDownload().

* Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::resume):
Added, not implemented on this platform.

* Shared/Downloads/mac/DownloadMac.mm:
(WebKit::Download::resume):
Added. Consumes the sandbox extension, resumes the download, and sets m_request after the
NSURLDownload has been created. Note that we already have code to revoke the sandbox extension when
the download is finished, canceled, or fails.

* Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::resume):
Added, not implemented on this platform.

* UIProcess/API/C/WKContext.cpp:
(WKContextResumeDownload):
Added.

* UIProcess/API/C/WKContext.h:
Added WKContextResumeDownload().

* UIProcess/WebContext.cpp:
(WebKit::WebContext::resumeDownload):
Added. Creates a sandbox extension for the existing file and includes it in the message to the
network or web process.

* UIProcess/WebContext.h:
Added resumeDownload().

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::resumeDownload):
Added, calls through to DownloadManager::resumeDownload().

* WebProcess/WebProcess.h:
Added resumeDownload().

* WebProcess/WebProcess.messages.in:
Added ResumeDownload message.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in
trunk/Source/WebKit2/Shared/Downloads/Download.h
trunk/Source/WebKit2/Shared/Downloads/DownloadManager.cpp
trunk/Source/WebKit2/Shared/Downloads/DownloadManager.h
trunk/Source/WebKit2/Shared/Downloads/ios/DownloadIOS.mm
trunk/Source/WebKit2/Shared/Downloads/mac/DownloadMac.mm
trunk/Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
trunk/Source/WebKit2/WebProcess/WebProcess.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (174986 => 174987)

--- trunk/Source/WebKit2/ChangeLog	2014-10-21 17:32:09 UTC (rev 174986)
+++ trunk/Source/WebKit2/ChangeLog	2014-10-21 17:46:11 UTC (rev 174987)
@@ -1,3 +1,76 @@
+2014-10-21  Jeff Miller  
+
+WKContext needs to provide an API to resume a download
+https://bugs.webkit.org/show_bug.cgi?id=137507
+
+Reviewed by Darin Adler.
+
+This patch adds WKContextResumeDownload(), which is only supported on the Mac, and requires the
+resume data from WKDownloadGetResumeData().
+
+We have to create a sandbox extension for the partially downloaded file in the UI process so the
+network or web process can resume writing to it.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::resumeDownload):
+Added, calls through to DownloadManager::resumeDownload().
+
+* NetworkProcess/NetworkProcess.h:
+Added resumeDownload().
+
+* NetworkProcess/NetworkProcess.messages.in:
+Added ResumeDownload message.
+
+* Shared/Downloads/Download.h:
+Added resume().
+
+* Shared/Downloads/DownloadManager.cpp:
+(WebKit::DownloadManager::resumeDownload):
+Added. The URL being downloaded is part of the opaque resumeData, so we can't specify it when the
+Download is constructed.
+
+* Shared/Downloads/DownloadManager.h:
+Added resumeDownload().
+
+* Shared/Downloads/ios/DownloadIOS.mm:
+(WebKit::Download::resume):
+Added, not implemented on this platform.
+
+* Shared/Downloads/mac/DownloadMac.mm:
+(WebKit::Download::resume):
+Added. Consumes the sandbox extension, resumes the download, and sets m_request after the
+

[webkit-changes] [174230] trunk/Source/WebKit2

2014-10-02 Thread jeffm

Title: [174230] trunk/Source/WebKit2








Revision 174230
Author je...@apple.com
Date 2014-10-02 14:01:08 -0700 (Thu, 02 Oct 2014)


Log Message
WKDownloadCopyRequest() returns 0 until the download starts
https://bugs.webkit.org/show_bug.cgi?id=137322

Reviewed by Anders Carlsson.

The m_request ivar in DownloadProxy was only being initialized when didStart() was called after the
download starts. Since clients have access to the ResourceRequest when the DownloadProxy is created,
there's no reason not to pass that along to DownloadProxy::create() so it can be returned if
WKDownloadCopyRequest() is called before didStart().

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::create):
Add ResourceRequest parameter, and pass it to DownloadProxy constructor.

(WebKit::DownloadProxy::DownloadProxy):
Initialize m_request.

* UIProcess/Downloads/DownloadProxy.h:
Add ResourceRequest parameter to create() and constructor.

* UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::createDownloadProxy):
Add ResourceRequest parameter and pass it to DownloadProxy::create().

* UIProcess/Downloads/DownloadProxyMap.h:
Add ResourceRequest parameter to createDownloadProxy().

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::createDownloadProxy):
Add ResourceRequest parameter and pass it to DownloadProxy::create().

* UIProcess/Network/NetworkProcessProxy.h:
Add ResourceRequest parameter to createDownloadProxy().

* UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Pass ResourceRequest to createDownloadProxy().

(WebKit::WebContext::createDownloadProxy):
Add ResourceRequest parameter and pass it to createDownloadProxy() functions.

* UIProcess/WebContext.h:
Add ResourceRequest parameter to createDownloadProxy().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Pass m_decidePolicyForResponseRequest to WebContext::createDownloadProxy().

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createDownloadProxy):
Add ResourceRequest parameter and pass it to DownloadProxyMap::create().

* UIProcess/WebProcessProxy.h:
Add ResourceRequest parameter to createDownloadProxy().

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Downloads/DownloadProxy.cpp
trunk/Source/WebKit2/UIProcess/Downloads/DownloadProxy.h
trunk/Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp
trunk/Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.h
trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (174229 => 174230)

--- trunk/Source/WebKit2/ChangeLog	2014-10-02 20:56:52 UTC (rev 174229)
+++ trunk/Source/WebKit2/ChangeLog	2014-10-02 21:01:08 UTC (rev 174230)
@@ -1,3 +1,60 @@
+2014-10-02  Jeff Miller  
+
+WKDownloadCopyRequest() returns 0 until the download starts
+https://bugs.webkit.org/show_bug.cgi?id=137322
+
+Reviewed by Anders Carlsson.
+
+The m_request ivar in DownloadProxy was only being initialized when didStart() was called after the
+download starts. Since clients have access to the ResourceRequest when the DownloadProxy is created,
+there's no reason not to pass that along to DownloadProxy::create() so it can be returned if
+WKDownloadCopyRequest() is called before didStart().
+
+* UIProcess/Downloads/DownloadProxy.cpp:
+(WebKit::DownloadProxy::create):
+Add ResourceRequest parameter, and pass it to DownloadProxy constructor.
+
+(WebKit::DownloadProxy::DownloadProxy):
+Initialize m_request.
+
+* UIProcess/Downloads/DownloadProxy.h:
+Add ResourceRequest parameter to create() and constructor.
+
+* UIProcess/Downloads/DownloadProxyMap.cpp:
+(WebKit::DownloadProxyMap::createDownloadProxy):
+Add ResourceRequest parameter and pass it to DownloadProxy::create().
+
+* UIProcess/Downloads/DownloadProxyMap.h:
+Add ResourceRequest parameter to createDownloadProxy().
+
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::createDownloadProxy):
+Add ResourceRequest parameter and pass it to DownloadProxy::create().
+
+* UIProcess/Network/NetworkProcessProxy.h:
+Add ResourceRequest parameter to createDownloadProxy().
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::download):
+Pass ResourceRequest to createDownloadProxy().
+
+(WebKit::WebContext::createDownloadProxy):
+Add ResourceRequest parameter and pass it to createDownloadProxy() functions.
+
+* UIProcess/WebContext.h:
+Add ResourceRequest parameter t

[webkit-changes] [174221] trunk/Tools

2014-10-02 Thread jeffm

Title: [174221] trunk/Tools








Revision 174221
Author je...@apple.com
Date 2014-10-02 10:39:01 -0700 (Thu, 02 Oct 2014)


Log Message
DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=137347

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
Use WebKitSystemInterfaceYosemite on OS X 10.10.

* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
Ditto.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig
trunk/Tools/WebKitTestRunner/Configurations/DebugRelease.xcconfig




Diff

Modified: trunk/Tools/ChangeLog (174220 => 174221)

--- trunk/Tools/ChangeLog	2014-10-02 16:24:10 UTC (rev 174220)
+++ trunk/Tools/ChangeLog	2014-10-02 17:39:01 UTC (rev 174221)
@@ -1,3 +1,16 @@
+2014-10-02  Jeff Miller  
+
+DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
+https://bugs.webkit.org/show_bug.cgi?id=137347
+
+Reviewed by Dan Bernstein.
+
+* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
+Use WebKitSystemInterfaceYosemite on OS X 10.10.
+
+* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
+Ditto.
+
 2014-10-02  Carlos Alberto Lopez Perez  
 
 [GTK] [JHBuild] Switch sourceware.org mirror to http.


Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig (174220 => 174221)

--- trunk/Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig	2014-10-02 16:24:10 UTC (rev 174220)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig	2014-10-02 17:39:01 UTC (rev 174221)
@@ -42,7 +42,7 @@
 WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx = $(WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
 WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_1080 = WebKitSystemInterfaceMountainLion;
 WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_1090 = WebKitSystemInterfaceMavericks;
-WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_101000 = $(WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_1090);
+WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_101000 = WebKitSystemInterfaceYosemite;
 OTHER_CFLAGS = $(inherited) $(ASAN_OTHER_CFLAGS);
 OTHER_CPLUSPLUSFLAGS = $(inherited) $(ASAN_OTHER_CPLUSPLUSFLAGS);
 OTHER_LDFLAGS = $(inherited) $(ASAN_OTHER_LDFLAGS);


Modified: trunk/Tools/WebKitTestRunner/Configurations/DebugRelease.xcconfig (174220 => 174221)

--- trunk/Tools/WebKitTestRunner/Configurations/DebugRelease.xcconfig	2014-10-02 16:24:10 UTC (rev 174220)
+++ trunk/Tools/WebKitTestRunner/Configurations/DebugRelease.xcconfig	2014-10-02 17:39:01 UTC (rev 174221)
@@ -41,7 +41,7 @@
 WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx = $(WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
 WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_1080 = WebKitSystemInterfaceMountainLion;
 WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_1090 = WebKitSystemInterfaceMavericks;
-WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_101000 = $(WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_1090);
+WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_101000 = WebKitSystemInterfaceYosemite;
 
 OTHER_CFLAGS = $(inherited) $(ASAN_OTHER_CFLAGS);
 OTHER_CPLUSPLUSFLAGS = $(inherited) $(ASAN_OTHER_CPLUSPLUSFLAGS);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [153482] trunk/Source/WebKit2

2013-07-30 Thread jeffm

Title: [153482] trunk/Source/WebKit2








Revision 153482
Author je...@apple.com
Date 2013-07-30 11:28:35 -0700 (Tue, 30 Jul 2013)


Log Message
Page for WKPageLoaderClient processDidCrash callback always reports a process identifier of 0
https://bugs.webkit.org/show_bug.cgi?id=119269


Reviewed by Anders Carlsson.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processIdentifier):
Return 0 if the page is closed instead of requiring isValid().

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (153481 => 153482)

--- trunk/Source/WebKit2/ChangeLog	2013-07-30 17:40:09 UTC (rev 153481)
+++ trunk/Source/WebKit2/ChangeLog	2013-07-30 18:28:35 UTC (rev 153482)
@@ -1,3 +1,15 @@
+2013-07-30  Jeff Miller  
+
+Page for WKPageLoaderClient processDidCrash callback always reports a process identifier of 0
+https://bugs.webkit.org/show_bug.cgi?id=119269
+
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::processIdentifier):
+Return 0 if the page is closed instead of requiring isValid().
+
 2013-07-30  Kwang Yul Seo  
 
 [WK2] Move the implementation of WebEditorClient::checkTextOfParagraph to WebEditorClient.cpp


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (153481 => 153482)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2013-07-30 17:40:09 UTC (rev 153481)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2013-07-30 18:28:35 UTC (rev 153482)
@@ -376,7 +376,7 @@
 
 PlatformProcessIdentifier WebPageProxy::processIdentifier() const
 {
-if (!isValid())
+if (m_isClosed)
 return 0;
 
 return m_process->processIdentifier();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152514] trunk/Source/WebCore

2013-07-09 Thread jeffm

Title: [152514] trunk/Source/WebCore








Revision 152514
Author je...@apple.com
Date 2013-07-09 14:00:26 -0700 (Tue, 09 Jul 2013)


Log Message
AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate in WebCore::mac()
https://bugs.webkit.org/show_bug.cgi?id=118518

Reviewed by Alexey Proskuryakov.

* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
Map ProtectionSpaceAuthenticationSchemeNegotiate to NSURLAuthenticationMethodNegotiate.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (152513 => 152514)

--- trunk/Source/WebCore/ChangeLog	2013-07-09 20:17:41 UTC (rev 152513)
+++ trunk/Source/WebCore/ChangeLog	2013-07-09 21:00:26 UTC (rev 152514)
@@ -1,5 +1,16 @@
 2013-07-09  Jeff Miller  
 
+AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate in WebCore::mac()
+https://bugs.webkit.org/show_bug.cgi?id=118518
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/network/mac/AuthenticationMac.mm:
+(WebCore::mac):
+Map ProtectionSpaceAuthenticationSchemeNegotiate to NSURLAuthenticationMethodNegotiate.
+
+2013-07-09  Jeff Miller  
+
 AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate
 https://bugs.webkit.org/show_bug.cgi?id=118517
 


Modified: trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm (152513 => 152514)

--- trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm	2013-07-09 20:17:41 UTC (rev 152513)
+++ trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm	2013-07-09 21:00:26 UTC (rev 152514)
@@ -283,6 +283,9 @@
 case ProtectionSpaceAuthenticationSchemeNTLM:
 method = NSURLAuthenticationMethodNTLM;
 break;
+case ProtectionSpaceAuthenticationSchemeNegotiate:
+method = NSURLAuthenticationMethodNegotiate;
+break;
 #if USE(PROTECTION_SPACE_AUTH_CALLBACK)
 case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested:
 method = NSURLAuthenticationMethodServerTrust;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152513] trunk/Source/WebCore

2013-07-09 Thread jeffm

Title: [152513] trunk/Source/WebCore








Revision 152513
Author je...@apple.com
Date 2013-07-09 13:17:41 -0700 (Tue, 09 Jul 2013)


Log Message
AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate
https://bugs.webkit.org/show_bug.cgi?id=118517

Reviewed by Brady Eidson.

* platform/network/mac/AuthenticationMac.mm:
(WebCore::core):
Map "NSURLAuthenticationMethodNegotiate" to ProtectionSpaceAuthenticationSchemeNegotiate.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (152512 => 152513)

--- trunk/Source/WebCore/ChangeLog	2013-07-09 19:01:11 UTC (rev 152512)
+++ trunk/Source/WebCore/ChangeLog	2013-07-09 20:17:41 UTC (rev 152513)
@@ -1,3 +1,14 @@
+2013-07-09  Jeff Miller  
+
+AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate
+https://bugs.webkit.org/show_bug.cgi?id=118517
+
+Reviewed by Brady Eidson.
+
+* platform/network/mac/AuthenticationMac.mm:
+(WebCore::core):
+Map "NSURLAuthenticationMethodNegotiate" to ProtectionSpaceAuthenticationSchemeNegotiate.
+
 2013-07-09  pe...@outlook.com  
 
 [Windows] Compile fix.


Modified: trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm (152512 => 152513)

--- trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm	2013-07-09 19:01:11 UTC (rev 152512)
+++ trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm	2013-07-09 20:17:41 UTC (rev 152513)
@@ -389,6 +389,8 @@
 scheme = ProtectionSpaceAuthenticationSchemeHTMLForm;
 else if ([method isEqualToString:NSURLAuthenticationMethodNTLM])
 scheme = ProtectionSpaceAuthenticationSchemeNTLM;
+else if ([method isEqualToString:NSURLAuthenticationMethodNegotiate])
+scheme = ProtectionSpaceAuthenticationSchemeNegotiate;
 #if USE(PROTECTION_SPACE_AUTH_CALLBACK)
 else if ([method isEqualToString:NSURLAuthenticationMethodClientCertificate])
 scheme = ProtectionSpaceAuthenticationSchemeClientCertificateRequested;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [125900] trunk/Source/WebKit2

2012-08-17 Thread jeffm

Title: [125900] trunk/Source/WebKit2








Revision 125900
Author je...@apple.com
Date 2012-08-17 07:48:36 -0700 (Fri, 17 Aug 2012)


Log Message
UserMessageEncoder::baseEncode() should ASSERT when attempting to encode a non-shareable image
https://bugs.webkit.org/show_bug.cgi?id=94245

Reviewed by Alexey Proskuryakov.

It's a programming error if a client attempts to encode an image that has an
allocated bitmap, but isn't shareable, so we should assert in this case.

* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
Assert if we're trying to encode valid non-shareable image.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/UserMessageCoders.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (125899 => 125900)

--- trunk/Source/WebKit2/ChangeLog	2012-08-17 14:37:47 UTC (rev 125899)
+++ trunk/Source/WebKit2/ChangeLog	2012-08-17 14:48:36 UTC (rev 125900)
@@ -1,3 +1,17 @@
+2012-08-17  Jeff Miller  
+
+UserMessageEncoder::baseEncode() should ASSERT when attempting to encode a non-shareable image
+https://bugs.webkit.org/show_bug.cgi?id=94245
+
+Reviewed by Alexey Proskuryakov.
+
+It's a programming error if a client attempts to encode an image that has an
+allocated bitmap, but isn't shareable, so we should assert in this case.
+
+* Shared/UserMessageCoders.h:
+(WebKit::UserMessageEncoder::baseEncode):
+Assert if we're trying to encode valid non-shareable image.
+
 2012-08-17  Sudarsana Nagineni  
 
 [EFL] [WK2] Add unit tests for vibration_client_callbacks_set API


Modified: trunk/Source/WebKit2/Shared/UserMessageCoders.h (125899 => 125900)

--- trunk/Source/WebKit2/Shared/UserMessageCoders.h	2012-08-17 14:37:47 UTC (rev 125899)
+++ trunk/Source/WebKit2/Shared/UserMessageCoders.h	2012-08-17 14:48:36 UTC (rev 125900)
@@ -186,6 +186,7 @@
 WebImage* image = static_cast(m_root);
 
 ShareableBitmap::Handle handle;
+ASSERT(!image->bitmap() || image->bitmap()->isBackedBySharedMemory());
 if (!image->bitmap() || !image->bitmap()->isBackedBySharedMemory() || !image->bitmap()->createHandle(handle)) {
 // Initial false indicates no allocated bitmap or is not shareable.
 encoder->encode(false);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [110638] trunk/Source/WebKit2

2012-03-13 Thread jeffm

Title: [110638] trunk/Source/WebKit2








Revision 110638
Author je...@apple.com
Date 2012-03-13 16:39:11 -0700 (Tue, 13 Mar 2012)


Log Message
Support loading a WKPage from web archive data
https://bugs.webkit.org/show_bug.cgi?id=81044

This code was written by Jessie Berlin.

Reviewed by Brady Eidson.

* UIProcess/API/C/WKPage.cpp:
(WKPageLoadWebArchiveData): Added.

* UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadWebArchiveData): Added.

* UIProcess/WebPageProxy.h: Added loadWebArchiveData().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadWebArchiveData): Added.

* WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().

* WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPage.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (110637 => 110638)

--- trunk/Source/WebKit2/ChangeLog	2012-03-13 23:31:50 UTC (rev 110637)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-13 23:39:11 UTC (rev 110638)
@@ -1,3 +1,29 @@
+2012-03-13  Jeff Miller  
+
+Support loading a WKPage from web archive data
+https://bugs.webkit.org/show_bug.cgi?id=81044
+
+This code was written by Jessie Berlin.
+
+Reviewed by Brady Eidson.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageLoadWebArchiveData): Added.
+
+* UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::loadWebArchiveData): Added.
+
+* UIProcess/WebPageProxy.h: Added loadWebArchiveData().
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::loadWebArchiveData): Added.
+
+* WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().
+
+* WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.
+
 2012-03-13  Adam Barth   && Benjamin Poulain  
 
 Always enable ENABLE(CLIENT_BASED_GEOLOCATION)


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (110637 => 110638)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2012-03-13 23:31:50 UTC (rev 110637)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2012-03-13 23:39:11 UTC (rev 110638)
@@ -82,6 +82,11 @@
 toImpl(pageRef)->loadPlainTextString(toWTFString(plainTextStringRef));
 }
 
+void WKPageLoadWebArchiveData(WKPageRef pageRef, WKDataRef webArchiveDataRef)
+{
+toImpl(pageRef)->loadWebArchiveData(toImpl(webArchiveDataRef));
+}
+
 void WKPageStopLoading(WKPageRef pageRef)
 {
 toImpl(pageRef)->stopLoading();


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.h (110637 => 110638)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2012-03-13 23:31:50 UTC (rev 110637)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2012-03-13 23:39:11 UTC (rev 110638)
@@ -319,6 +319,7 @@
 WK_EXPORT void WKPageLoadHTMLString(WKPageRef page, WKStringRef htmlString, WKURLRef baseURL);
 WK_EXPORT void WKPageLoadAlternateHTMLString(WKPageRef page, WKStringRef htmlString, WKURLRef baseURL, WKURLRef unreachableURL);
 WK_EXPORT void WKPageLoadPlainTextString(WKPageRef page, WKStringRef plainTextString);
+WK_EXPORT void WKPageLoadWebArchiveData(WKPageRef page, WKDataRef webArchiveData);
 
 WK_EXPORT void WKPageStopLoading(WKPageRef page);
 WK_EXPORT void WKPageReload(WKPageRef page);


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (110637 => 110638)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-03-13 23:31:50 UTC (rev 110637)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-03-13 23:39:11 UTC (rev 110638)
@@ -504,6 +504,15 @@
 process()->responsivenessTimer()->start();
 }
 
+void WebPageProxy::loadWebArchiveData(const WebData* webArchiveData)
+{
+if (!isValid())
+reattachToWebProcess();
+
+process()->send(Messages::WebPage::LoadWebArchiveData(webArchiveData->dataReference()), m_pageID);
+process()->responsivenessTimer()->start();
+}
+
 void WebPageProxy::stopLoading()
 {
 if (!isValid())


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (110637 => 110638)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2012-03-13 23:31:50 UTC (rev 110637)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2012-03-13 23:39:11 UTC (rev 110638)
@@ -254,6 +254,7 @@
 void loadHTMLString(const String& htmlString, const String& baseURL);
 void loadAlternateHTMLString(const String& htmlString, const String& baseURL, const String& unreachableURL);
 void loadPlainTextString(const String& string);
+void loadWebArchiveData(

[webkit-changes] [110355] trunk/Source/WebKit2

2012-03-09 Thread jeffm

Title: [110355] trunk/Source/WebKit2








Revision 110355
Author je...@apple.com
Date 2012-03-09 18:04:07 -0800 (Fri, 09 Mar 2012)


Log Message
Add WKPageEndPrinting() to balance WKPageBeginPrinting()
https://bugs.webkit.org/show_bug.cgi?id=80739

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.cpp:
(WKPageEndPrinting): Added.

* UIProcess/API/C/WKPagePrivate.h: Added WKPageEndPrinting().

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (110354 => 110355)

--- trunk/Source/WebKit2/ChangeLog	2012-03-10 02:02:22 UTC (rev 110354)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-10 02:04:07 UTC (rev 110355)
@@ -1,3 +1,15 @@
+2012-03-09  Jeff Miller  
+
+Add WKPageEndPrinting() to balance WKPageBeginPrinting()
+https://bugs.webkit.org/show_bug.cgi?id=80739
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageEndPrinting): Added.
+
+* UIProcess/API/C/WKPagePrivate.h: Added WKPageEndPrinting().
+
 2012-03-09  Emil A Eklund  
 
 Add roundedPoint to HitTestResult and change platform code to use it


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (110354 => 110355)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2012-03-10 02:02:22 UTC (rev 110354)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2012-03-10 02:04:07 UTC (rev 110355)
@@ -660,6 +660,11 @@
 {
 toImpl(page)->drawPagesToPDF(toImpl(frame), printInfoFromWKPrintInfo(printInfo), first, count, DataCallback::create(context, callback));
 }
+
+void WKPageEndPrinting(WKPageRef page)
+{
+toImpl(page)->endPrinting();
+}
 #endif
 
 WKImageRef WKPageCreateSnapshotOfVisibleContent(WKPageRef)


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h (110354 => 110355)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h	2012-03-10 02:02:22 UTC (rev 110354)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h	2012-03-10 02:04:07 UTC (rev 110355)
@@ -83,6 +83,7 @@
 typedef void (*WKPageDrawToPDFFunction)(WKDataRef data, WKErrorRef error, void* functionContext);
 WK_EXPORT void WKPageBeginPrinting(WKPageRef page, WKFrameRef frame, WKPrintInfo printInfo);
 WK_EXPORT void WKPageDrawPagesToPDF(WKPageRef page, WKFrameRef frame, WKPrintInfo printInfo, uint32_t first, uint32_t count, WKPageDrawToPDFFunction callback, void* context);
+WK_EXPORT void WKPageEndPrinting(WKPageRef page);
 
 // FIXME https://bugs.webkit.org/show_bug.cgi?id=66979: Remove this sync call.
 WK_EXPORT WKImageRef WKPageCreateSnapshotOfVisibleContent(WKPageRef page);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98894] trunk/Source/WebKit2

2011-10-31 Thread jeffm

Title: [98894] trunk/Source/WebKit2








Revision 98894
Author je...@apple.com
Date 2011-10-31 15:55:01 -0700 (Mon, 31 Oct 2011)


Log Message
Add more APIs to WKUserContentURLPattern.h
https://bugs.webkit.org/show_bug.cgi?id=71245

Add additional WKUserContentURLPattern APIs to match what was provided by
the equivalent WebKit1 API.

Reviewed by Darin Adler.

* Shared/API/c/WKUserContentURLPattern.cpp:
(WKUserContentURLPatternCopyHost): Added.
(WKUserContentURLPatternCopyScheme): Added.
(WKUserContentURLPatternIsValid): Added.
(WKUserContentURLPatternMatchesSubdomains): Added.

* Shared/API/c/WKUserContentURLPattern.h: Added new APIs.

* Shared/WebUserContentURLPattern.h:
(WebKit::WebUserContentURLPattern::host): Added.
(WebKit::WebUserContentURLPattern::scheme): Added.
(WebKit::WebUserContentURLPattern::isValid): Added.
(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp
trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h
trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98893 => 98894)

--- trunk/Source/WebKit2/ChangeLog	2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-31 22:55:01 UTC (rev 98894)
@@ -1,3 +1,27 @@
+2011-10-31  Jeff Miller  
+
+Add more APIs to WKUserContentURLPattern.h
+https://bugs.webkit.org/show_bug.cgi?id=71245
+
+Add additional WKUserContentURLPattern APIs to match what was provided by
+the equivalent WebKit1 API.
+
+Reviewed by Darin Adler.
+
+* Shared/API/c/WKUserContentURLPattern.cpp:
+(WKUserContentURLPatternCopyHost): Added.
+(WKUserContentURLPatternCopyScheme): Added.
+(WKUserContentURLPatternIsValid): Added.
+(WKUserContentURLPatternMatchesSubdomains): Added.
+
+* Shared/API/c/WKUserContentURLPattern.h: Added new APIs.
+
+* Shared/WebUserContentURLPattern.h:
+(WebKit::WebUserContentURLPattern::host): Added.
+(WebKit::WebUserContentURLPattern::scheme): Added.
+(WebKit::WebUserContentURLPattern::isValid): Added.
+(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.
+
 2011-10-31  Anders Carlsson  
 
 More work on making plug-ins work better with transforms


Modified: trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp (98893 => 98894)

--- trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp	2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.cpp	2011-10-31 22:55:01 UTC (rev 98894)
@@ -27,6 +27,7 @@
 #include "WKUserContentURLPattern.h"
 
 #include "WKAPICast.h"
+#include "WKString.h"
 #include "WebUserContentURLPattern.h"
 
 using namespace WebKit;
@@ -42,7 +43,27 @@
 return toAPI(userContentURLPattern.release().leakRef());
 }
 
+WKStringRef WKUserContentURLPatternCopyHost(WKUserContentURLPatternRef urlPatternRef)
+{
+return toCopiedAPI(toImpl(urlPatternRef)->host());
+}
+
+WKStringRef WKUserContentURLPatternCopyScheme(WKUserContentURLPatternRef urlPatternRef)
+{
+return toCopiedAPI(toImpl(urlPatternRef)->scheme());
+}
+
+bool WKUserContentURLPatternIsValid(WKUserContentURLPatternRef urlPatternRef)
+{
+return toImpl(urlPatternRef)->isValid();
+}
+
 bool WKUserContentURLPatternMatchesURL(WKUserContentURLPatternRef urlPatternRef, WKURLRef urlRef)
 {
 return toImpl(urlPatternRef)->matchesURL(toWTFString(urlRef));
 }
+
+bool WKUserContentURLPatternMatchesSubdomains(WKUserContentURLPatternRef urlPatternRef)
+{
+return toImpl(urlPatternRef)->matchesSubdomains();
+}


Modified: trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h (98893 => 98894)

--- trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h	2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/Shared/API/c/WKUserContentURLPattern.h	2011-10-31 22:55:01 UTC (rev 98894)
@@ -37,7 +37,11 @@
 
 WK_EXPORT WKUserContentURLPatternRef WKUserContentURLPatternCreate(WKStringRef patternRef);
 
+WK_EXPORT WKStringRef WKUserContentURLPatternCopyHost(WKUserContentURLPatternRef urlPatternRef);
+WK_EXPORT WKStringRef WKUserContentURLPatternCopyScheme(WKUserContentURLPatternRef urlPatternRef);
+WK_EXPORT bool WKUserContentURLPatternIsValid(WKUserContentURLPatternRef urlPatternRef);
 WK_EXPORT bool WKUserContentURLPatternMatchesURL(WKUserContentURLPatternRef urlPatternRef, WKURLRef urlRef);
+WK_EXPORT bool WKUserContentURLPatternMatchesSubdomains(WKUserContentURLPatternRef urlPatternRef);
 
 #ifdef __cplusplus
 }


Modified: trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h (98893 => 98894)

--- trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h	2011-10-31 22:52:58 UTC (rev 98893)
+++ trunk/Source/WebKit2/Shared/WebUserContentURLPattern.h	2011-10-31 22:55:01 UTC (rev 98894)
@@ -43,7 +43,11 @@
 return adoptRef(new

[webkit-changes] [98781] trunk/Source/WebKit2

2011-10-28 Thread jeffm

Title: [98781] trunk/Source/WebKit2








Revision 98781
Author je...@apple.com
Date 2011-10-28 16:35:08 -0700 (Fri, 28 Oct 2011)


Log Message
More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=71156

Don't include PDF and PostScript types in the set of MIME types with custom representations
when initializing the web process if WebKitOmitPDFSupport is set.

I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
shown inline when this preference was set, but to be complete we should exclude the MIME
types here as well.

Reviewed by Alexey Proskuryakov.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98780 => 98781)

--- trunk/Source/WebKit2/ChangeLog	2011-10-28 23:31:41 UTC (rev 98780)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-28 23:35:08 UTC (rev 98781)
@@ -1,3 +1,20 @@
+2011-10-28  Jeff Miller  
+
+More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
+https://bugs.webkit.org/show_bug.cgi?id=71156
+
+Don't include PDF and PostScript types in the set of MIME types with custom representations
+when initializing the web process if WebKitOmitPDFSupport is set.
+
+I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
+shown inline when this preference was set, but to be complete we should exclude the MIME
+types here as well.
+
+Reviewed by Alexey Proskuryakov.
+
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::WebContext::platformInitializeWebProcess):
+
 2011-10-28  John Sullivan  
 
 WebKit2 part of:


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (98780 => 98781)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-10-28 23:31:41 UTC (rev 98780)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-10-28 23:35:08 UTC (rev 98781)
@@ -69,9 +69,11 @@
 
 void WebContext::platformInitializeWebProcess(WebProcessCreationParameters& parameters)
 {
-// We want to use a PDF view in the UI process for PDF MIME types.
-HashSet mimeType = pdfAndPostScriptMIMETypes();
-parameters.mimeTypesWithCustomRepresentation.appendRange(mimeType.begin(), mimeType.end());
+if (!omitPDFSupport()) {
+// We want to use a PDF view in the UI process for PDF MIME types.
+HashSet mimeType = pdfAndPostScriptMIMETypes();
+parameters.mimeTypesWithCustomRepresentation.appendRange(mimeType.begin(), mimeType.end());
+}
 
 RetainPtr cachePath(AdoptCF, WKCopyFoundationCacheDirectory());
 if (!cachePath)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98513] trunk/Source/WebKit2

2011-10-26 Thread jeffm

Title: [98513] trunk/Source/WebKit2








Revision 98513
Author je...@apple.com
Date 2011-10-26 13:19:14 -0700 (Wed, 26 Oct 2011)


Log Message
WebKit2 should respect secret WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=70943

If WebKitOmitPDFSupport pref is set, disable both the new "plug-in" for subframes and the PDFKit-based support for the main frame only.

Reviewed by Alexey Proskuryakov.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::getPlugins): Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set.

* UIProcess/WebContext.h: Added omitPDFSupport().

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType): Don't show PDFs if WebKitOmitPDFSupport is set.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::omitPDFSupport): Added.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98512 => 98513)

--- trunk/Source/WebKit2/ChangeLog	2011-10-26 19:57:36 UTC (rev 98512)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-26 20:19:14 UTC (rev 98513)
@@ -1,3 +1,23 @@
+2011-10-26  Jeff Miller  
+
+WebKit2 should respect secret WebKitOmitPDFSupport preference on the Mac
+https://bugs.webkit.org/show_bug.cgi?id=70943
+
+If WebKitOmitPDFSupport pref is set, disable both the new "plug-in" for subframes and the PDFKit-based support for the main frame only.
+
+Reviewed by Alexey Proskuryakov.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::getPlugins): Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set.
+
+* UIProcess/WebContext.h: Added omitPDFSupport().
+
+* UIProcess/WebFrameProxy.cpp:
+(WebKit::WebFrameProxy::canShowMIMEType): Don't show PDFs if WebKitOmitPDFSupport is set.
+
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::WebContext::omitPDFSupport): Added.
+
 2011-10-26  Sam Weinig  
 
 Add initial setting to WKBrowsingContextGroup


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (98512 => 98513)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-10-26 19:57:36 UTC (rev 98512)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-10-26 20:19:14 UTC (rev 98513)
@@ -568,7 +568,8 @@
 
 #if PLATFORM(MAC)
 // Add built-in PDF last, so that it's not used when a real plug-in is installed.
-pluginInfos.append(BuiltInPDFView::pluginInfo());
+if (!omitPDFSupport())
+pluginInfos.append(BuiltInPDFView::pluginInfo());
 #endif
 }
 


Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (98512 => 98513)

--- trunk/Source/WebKit2/UIProcess/WebContext.h	2011-10-26 19:57:36 UTC (rev 98512)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h	2011-10-26 20:19:14 UTC (rev 98513)
@@ -184,6 +184,10 @@
 void getWebCoreStatistics(PassRefPtr);
 void garbageCollectJavaScriptObjects();
 
+#if PLATFORM(MAC)
+static bool omitPDFSupport();
+#endif
+
 private:
 WebContext(ProcessModel, const String& injectedBundlePath);
 


Modified: trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp (98512 => 98513)

--- trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp	2011-10-26 19:57:36 UTC (rev 98512)
+++ trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp	2011-10-26 20:19:14 UTC (rev 98513)
@@ -111,7 +111,7 @@
 #if PLATFORM(MAC)
 // On Mac, we can show PDFs.
 if (!mimeType.isEmpty())
-return WebContext::pdfAndPostScriptMIMETypes().contains(mimeType);
+return WebContext::pdfAndPostScriptMIMETypes().contains(mimeType) && !WebContext::omitPDFSupport();
 #endif
 
 return false;


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (98512 => 98513)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-10-26 19:57:36 UTC (rev 98512)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-10-26 20:19:14 UTC (rev 98513)
@@ -139,5 +139,11 @@
 return [localStorageDirectory stringByStandardizingPath];
 }
 
+bool WebContext::omitPDFSupport()
+{
+// Since this is a "secret default" we don't bother registering it.
+return [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"];
+}
+
 } // namespace WebKit
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98118] trunk/WebKitLibraries

2011-10-21 Thread jeffm

Title: [98118] trunk/WebKitLibraries








Revision 98118
Author je...@apple.com
Date 2011-10-21 11:20:58 -0700 (Fri, 21 Oct 2011)


Log Message
Focus rings are too thin in HiDPI in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=70396

Rename wkSetPatternBaseCTM() to wkSetBaseCTM().

Reviewed by Beth Dakin.

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h
trunk/WebKitLibraries/win/lib/WebKitSystemInterface.lib




Diff

Modified: trunk/WebKitLibraries/ChangeLog (98117 => 98118)

--- trunk/WebKitLibraries/ChangeLog	2011-10-21 18:13:04 UTC (rev 98117)
+++ trunk/WebKitLibraries/ChangeLog	2011-10-21 18:20:58 UTC (rev 98118)
@@ -1,3 +1,15 @@
+2011-10-21  Jeff Miller  
+
+Focus rings are too thin in HiDPI in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=70396
+
+Rename wkSetPatternBaseCTM() to wkSetBaseCTM().
+
+Reviewed by Beth Dakin.
+
+* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
+* win/lib/WebKitSystemInterface.lib:
+
 2011-10-19  Beth Dakin  
 
 Try to fix the Chromium build.


Modified: trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h (98117 => 98118)

--- trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h	2011-10-21 18:13:04 UTC (rev 98117)
+++ trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h	2011-10-21 18:20:58 UTC (rev 98118)
@@ -81,7 +81,7 @@
 void wkGetGlyphs(CGFontRef, const UChar[], CGGlyph[], size_t count);
 void wkSetUpFontCache(size_t s);
 
-void wkSetPatternBaseCTM(CGContextRef, CGAffineTransform);
+void wkSetBaseCTM(CGContextRef, CGAffineTransform);
 void wkSetPatternPhaseInUserSpace(CGContextRef, CGPoint phasePoint);
 CGAffineTransform wkGetUserToBaseCTM(CGContextRef);
 


Modified: trunk/WebKitLibraries/win/lib/WebKitSystemInterface.lib

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [97641] trunk/Source/WebCore

2011-10-17 Thread jeffm

Title: [97641] trunk/Source/WebCore








Revision 97641
Author je...@apple.com
Date 2011-10-17 13:29:59 -0700 (Mon, 17 Oct 2011)


Log Message
Widget window coordinate functions should use root view coordinate functions
https://bugs.webkit.org/show_bug.cgi?id=70152

Reviewed by Darin Adler.

No new tests, no changes to functionality.

* platform/Widget.cpp:
(WebCore::Widget::convertFromContainingWindow): Use convertFromRootView().
(WebCore::Widget::convertToContainingWindow): Use convertToRootView().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Widget.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (97640 => 97641)

--- trunk/Source/WebCore/ChangeLog	2011-10-17 20:15:01 UTC (rev 97640)
+++ trunk/Source/WebCore/ChangeLog	2011-10-17 20:29:59 UTC (rev 97641)
@@ -1,3 +1,16 @@
+2011-10-17  Jeff Miller  
+
+Widget window coordinate functions should use root view coordinate functions
+https://bugs.webkit.org/show_bug.cgi?id=70152
+
+Reviewed by Darin Adler.
+
+No new tests, no changes to functionality.
+
+* platform/Widget.cpp:
+(WebCore::Widget::convertFromContainingWindow): Use convertFromRootView().
+(WebCore::Widget::convertToContainingWindow): Use convertToRootView().
+
 2011-10-14  Chris Marrin  
 
 Throttle rate of requestAnimationFrame when page is not visible


Modified: trunk/Source/WebCore/platform/Widget.cpp (97640 => 97641)

--- trunk/Source/WebCore/platform/Widget.cpp	2011-10-17 20:15:01 UTC (rev 97640)
+++ trunk/Source/WebCore/platform/Widget.cpp	2011-10-17 20:29:59 UTC (rev 97641)
@@ -107,38 +107,22 @@
 
 IntRect Widget::convertFromContainingWindow(const IntRect& windowRect) const
 {
-if (const ScrollView* parentScrollView = parent()) {
-IntRect parentRect = parentScrollView->convertFromContainingWindow(windowRect);
-return convertFromContainingView(parentRect);
-}
-return convertFromContainingWindowToRoot(this, windowRect);
+return convertFromRootView(convertFromContainingWindowToRoot(this, windowRect));
 }
 
 IntRect Widget::convertToContainingWindow(const IntRect& localRect) const
 {
-if (const ScrollView* parentScrollView = parent()) {
-IntRect parentRect = convertToContainingView(localRect);
-return parentScrollView->convertToContainingWindow(parentRect);
-}
-return convertFromRootToContainingWindow(this, localRect);
+return convertFromRootToContainingWindow(this, convertToRootView(localRect));
 }
 
 IntPoint Widget::convertFromContainingWindow(const IntPoint& windowPoint) const
 {
-if (const ScrollView* parentScrollView = parent()) {
-IntPoint parentPoint = parentScrollView->convertFromContainingWindow(windowPoint);
-return convertFromContainingView(parentPoint);
-}
-return convertFromContainingWindowToRoot(this, windowPoint);
+return convertFromRootView(convertFromContainingWindowToRoot(this, windowPoint));
 }
 
 IntPoint Widget::convertToContainingWindow(const IntPoint& localPoint) const
 {
-if (const ScrollView* parentScrollView = parent()) {
-IntPoint parentPoint = convertToContainingView(localPoint);
-return parentScrollView->convertToContainingWindow(parentPoint);
-}
-return convertFromRootToContainingWindow(this, localPoint);
+return convertFromRootToContainingWindow(this, convertToRootView(localPoint));
 }
 
 #if !PLATFORM(MAC)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [97514] trunk/Source

2011-10-14 Thread jeffm

Title: [97514] trunk/Source








Revision 97514
Author je...@apple.com
Date 2011-10-14 15:11:12 -0700 (Fri, 14 Oct 2011)


Log Message
../WebCore: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

Add infrastructure to convert from any frame view's coordinate system to the
root view's coordinate system.

Reviewed by Simon Fraser.

No new tests (yet), this is covered by .

* WebCore.exp.in: Exported WebCore::ScrollView::contentsToRootView(), used by InjectedBundleHitTestResult.cpp.

* platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToContents): Added (both point and rect versions).
(WebCore::ScrollView::contentsToRootView): Ditto.

* platform/ScrollView.h: Added member functions to convert to/from root view coordinates.

* platform/Widget.cpp:
(WebCore::Widget::convertFromRootView): Added (both point and rect versions).
(WebCore::Widget::convertToRootView): Ditto.

* platform/Widget.h: Added member functions to convert to/from root view coordinates.

../WebKit2: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

WebKit2 clients only have knowledge of the WKView's coordinate system, they have no way to
convert from subframe view coordinates , so any rect that we expose through WK2 APIs should
be in WKView coordinates.

Reviewed by Simon Fraser.

* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::imageRect): Use WebCore::FrameView::contentsToRootView() to convert the image rect to WKView coordinates.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/Widget.cpp
trunk/Source/WebCore/platform/Widget.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (97513 => 97514)

--- trunk/Source/WebCore/ChangeLog	2011-10-14 22:03:02 UTC (rev 97513)
+++ trunk/Source/WebCore/ChangeLog	2011-10-14 22:11:12 UTC (rev 97514)
@@ -1,3 +1,29 @@
+2011-10-14  Jeff Miller  
+
+InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
+https://bugs.webkit.org/show_bug.cgi?id=69963
+
+Add infrastructure to convert from any frame view's coordinate system to the
+root view's coordinate system.
+
+Reviewed by Simon Fraser.
+
+No new tests (yet), this is covered by .
+
+* WebCore.exp.in: Exported WebCore::ScrollView::contentsToRootView(), used by InjectedBundleHitTestResult.cpp.
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::rootViewToContents): Added (both point and rect versions).
+(WebCore::ScrollView::contentsToRootView): Ditto.
+
+* platform/ScrollView.h: Added member functions to convert to/from root view coordinates.
+
+* platform/Widget.cpp:
+(WebCore::Widget::convertFromRootView): Added (both point and rect versions).
+(WebCore::Widget::convertToRootView): Ditto.
+
+* platform/Widget.h: Added member functions to convert to/from root view coordinates.
+
 2011-10-14  Andreas Kling  
 
 CSSParser: Remove StyleBase usage.


Modified: trunk/Source/WebCore/WebCore.exp.in (97513 => 97514)

--- trunk/Source/WebCore/WebCore.exp.in	2011-10-14 22:03:02 UTC (rev 97513)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-10-14 22:11:12 UTC (rev 97514)
@@ -1105,6 +1105,7 @@
 __ZNK7WebCore10ScrollView16contentsToWindowERKNS_8IntPointE
 __ZNK7WebCore10ScrollView16windowToContentsERKNS_8IntPointE
 __ZNK7WebCore10ScrollView18visibleContentRectEb
+__ZNK7WebCore10ScrollView18contentsToRootViewERKNS_7IntRectE
 __ZN7WebCore11CachedImage5imageEv
 __ZNK7WebCore11FrameLoader10isCompleteEv
 __ZNK7WebCore11FrameLoader14cancelledErrorERKNS_15ResourceRequestE


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (97513 => 97514)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2011-10-14 22:03:02 UTC (rev 97513)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2011-10-14 22:11:12 UTC (rev 97514)
@@ -681,6 +681,32 @@
 hostWindow()->invalidateContentsForSlowScroll(updateRect, false);
 }
 
+IntPoint ScrollView::rootViewToContents(const IntPoint& rootViewPoint) const
+{
+IntPoint viewPoint = convertFromRootView(rootViewPoint);
+return viewPoint + scrollOffset();
+}
+
+IntPoint ScrollView::contentsToRootView(const IntPoint& contentsPoint) const
+{
+IntPoint viewPoint = contentsPoint - scrollOffset();
+return convertToRootView(viewPoint);  
+}
+
+IntRect ScrollView::rootViewToContents(const IntRect& rootViewRect) const
+{
+IntRect viewRect = convertFromRootView(rootViewRect);
+viewRect.move(scrollOffset());
+return viewR

[webkit-changes] [97000] trunk/Source/WebKit2

2011-10-07 Thread jeffm

Title: [97000] trunk/Source/WebKit2








Revision 97000
Author je...@apple.com
Date 2011-10-07 19:46:20 -0700 (Fri, 07 Oct 2011)


Log Message
Add WKPageContextMenuClient callback when context menu is dismissed
https://bugs.webkit.org/show_bug.cgi?id=69553

Add contextMenuDismissed callback to WKPageContextMenuClient, and bump the API
version of this client to 1 so we continue to work with old clients.

* Shared/APIClientTraits.cpp: Added array of interface sizes for WKPageContextMenuClient.
* Shared/APIClientTraits.h: Added APIClientTraits for WKPageContextMenuClient.

* UIProcess/API/C/WKPage.h: Added contextMenuDismissed callback to WKPageContextMenuClient and bumped kWKPageContextMenuClientCurrentVersion.

* UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::contextMenuDismissed): Added.

* UIProcess/WebPageContextMenuClient.h: Added WebPageContextMenuClient::contextMenuDismissed().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu): Notify client when context menu is dismissed.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/APIClientTraits.cpp
trunk/Source/WebKit2/Shared/APIClientTraits.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.h
trunk/Source/WebKit2/UIProcess/WebPageContextMenuClient.cpp
trunk/Source/WebKit2/UIProcess/WebPageContextMenuClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96999 => 97000)

--- trunk/Source/WebKit2/ChangeLog	2011-10-08 02:22:21 UTC (rev 96999)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-08 02:46:20 UTC (rev 97000)
@@ -1,3 +1,24 @@
+2011-10-07  Jeff Miller  
+
+Add WKPageContextMenuClient callback when context menu is dismissed
+https://bugs.webkit.org/show_bug.cgi?id=69553
+
+Add contextMenuDismissed callback to WKPageContextMenuClient, and bump the API
+version of this client to 1 so we continue to work with old clients.
+
+* Shared/APIClientTraits.cpp: Added array of interface sizes for WKPageContextMenuClient.
+* Shared/APIClientTraits.h: Added APIClientTraits for WKPageContextMenuClient.
+
+* UIProcess/API/C/WKPage.h: Added contextMenuDismissed callback to WKPageContextMenuClient and bumped kWKPageContextMenuClientCurrentVersion.
+
+* UIProcess/WebPageContextMenuClient.cpp:
+(WebKit::WebPageContextMenuClient::contextMenuDismissed): Added.
+
+* UIProcess/WebPageContextMenuClient.h: Added WebPageContextMenuClient::contextMenuDismissed().
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::internalShowContextMenu): Notify client when context menu is dismissed.
+
 2011-10-07  Mark Hahnenberg  
 
 Remove getCallDataVirtual methods


Modified: trunk/Source/WebKit2/Shared/APIClientTraits.cpp (96999 => 97000)

--- trunk/Source/WebKit2/Shared/APIClientTraits.cpp	2011-10-08 02:22:21 UTC (rev 96999)
+++ trunk/Source/WebKit2/Shared/APIClientTraits.cpp	2011-10-08 02:46:20 UTC (rev 97000)
@@ -35,6 +35,11 @@
 sizeof(WKBundlePageLoaderClient)
 };
 
+const size_t APIClientTraits::interfaceSizesByVersion[] = {
+offsetof(WKPageContextMenuClient, contextMenuDismissed),
+sizeof(WKPageContextMenuClient)
+};
+
 const size_t APIClientTraits::interfaceSizesByVersion[] = {
 offsetof(WKPageUIClient, createNewPage),
 sizeof(WKPageUIClient)


Modified: trunk/Source/WebKit2/Shared/APIClientTraits.h (96999 => 97000)

--- trunk/Source/WebKit2/Shared/APIClientTraits.h	2011-10-08 02:22:21 UTC (rev 96999)
+++ trunk/Source/WebKit2/Shared/APIClientTraits.h	2011-10-08 02:46:20 UTC (rev 97000)
@@ -42,6 +42,10 @@
 static const size_t interfaceSizesByVersion[2];
 };
 
+template<> struct APIClientTraits {
+static const size_t interfaceSizesByVersion[2];
+};
+
 template<> struct APIClientTraits
 {
 static const size_t interfaceSizesByVersion[2];


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.h (96999 => 97000)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2011-10-08 02:22:21 UTC (rev 96999)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.h	2011-10-08 02:46:20 UTC (rev 97000)
@@ -274,16 +274,22 @@
 // ContextMenu client
 typedef void (*WKPageGetContextMenuFromProposedContextMenuCallback)(WKPageRef page, WKArrayRef proposedMenu, WKArrayRef* newMenu, WKTypeRef userData, const void* clientInfo);
 typedef void (*WKPageCustomContextMenuItemSelectedCallback)(WKPageRef page, WKContextMenuItemRef contextMenuItem, const void* clientInfo);
+typedef void (*WKPageContextMenuDismissedCallback)(WKPageRef page, const void* clientInfo);
 
 struct WKPageContextMenuClient {
 int version;
 const void *clientInfo;
+
+// Version 0
 WKPageGetContextMenuFromProposedContextMenuCallback getContextMenuFromProposedMenu;
 WKPageCustomContextMenuItemSelectedCallback

[webkit-changes] [96619] trunk/Source/WebKit2

2011-10-04 Thread jeffm

Title: [96619] trunk/Source/WebKit2








Revision 96619
Author je...@apple.com
Date 2011-10-04 11:15:42 -0700 (Tue, 04 Oct 2011)


Log Message
WKPreferences should allow control of application chrome mode
https://bugs.webkit.org/show_bug.cgi?id=69344

Reviewed by Dan Bernstein.

* Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetApplicationChromeModeEnabled): Added.
(WKPreferencesGetApplicationChromeModeEnabled): Added.

* UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set application chrome mode setting.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96618 => 96619)

--- trunk/Source/WebKit2/ChangeLog	2011-10-04 18:15:30 UTC (rev 96618)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-04 18:15:42 UTC (rev 96619)
@@ -1,3 +1,21 @@
+2011-10-04  Jeff Miller  
+
+WKPreferences should allow control of application chrome mode
+https://bugs.webkit.org/show_bug.cgi?id=69344
+
+Reviewed by Dan Bernstein.
+
+* Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().
+
+* UIProcess/API/C/WKPreferences.cpp:
+(WKPreferencesSetApplicationChromeModeEnabled): Added.
+(WKPreferencesGetApplicationChromeModeEnabled): Added.
+
+* UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences): Set application chrome mode setting.
+
 2011-10-04  Carlos Garcia Campos  
 
 [GTK] Implement default error pages in WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (96618 => 96619)

--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2011-10-04 18:15:30 UTC (rev 96618)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2011-10-04 18:15:42 UTC (rev 96619)
@@ -94,6 +94,7 @@
 macro(ShowsToolTipOverTruncatedText, showsToolTipOverTruncatedText, Bool, bool, false) \
 macro(MockScrollbarsEnabled, mockScrollbarsEnabled, Bool, bool, false) \
 macro(WebAudioEnabled, webAudioEnabled, Bool, bool, false) \
+macro(ApplicationChromeModeEnabled, applicationChromeMode, Bool, bool, false) \
 \
 
 #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (96618 => 96619)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp	2011-10-04 18:15:30 UTC (rev 96618)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp	2011-10-04 18:15:42 UTC (rev 96619)
@@ -631,3 +631,13 @@
 {
 return toImpl(preferencesRef)->webAudioEnabled();
 }
+
+void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+toImpl(preferencesRef)->setApplicationChromeModeEnabled(enabled);
+}
+
+bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef)
+{
+return toImpl(preferencesRef)->applicationChromeMode();
+}


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h (96618 => 96619)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h	2011-10-04 18:15:30 UTC (rev 96618)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h	2011-10-04 18:15:42 UTC (rev 96619)
@@ -147,6 +147,10 @@
 // Defaults to false.
 WK_EXPORT void WKPreferencesSetMockScrollbarsEnabled(WKPreferencesRef preferencesRef, bool flag);
 WK_EXPORT bool WKPreferencesGetMockScrollbarsEnabled(WKPreferencesRef preferencesRef);
+
+// Defaults to false.
+WK_EXPORT void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef, bool enabled);
+WK_EXPORT bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef);
 
 #ifdef __cplusplus
 }


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (96618 => 96619)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-10-04 18:15:30 UTC (rev 96618)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-10-04 18:15:42 UTC (rev 96619)
@@ -1682,6 +1682,8 @@
 settings->setWebAudioEnabled(store.getBoolValueForKey(WebPreferencesKey::webAudioEnabledKey()));
 #endif
 
+settings->setApplicationChromeMode(store.getBoolValueForKey(WebPreferencesKey::applicationChromeModeKey()));
+
 platformPreferencesDidChange(store);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/

[webkit-changes] [95382] trunk/Source/WebCore

2011-09-17 Thread jeffm

Title: [95382] trunk/Source/WebCore








Revision 95382
Author je...@apple.com
Date 2011-09-17 08:58:50 -0700 (Sat, 17 Sep 2011)


Log Message
Build fix after r95372.

* dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMAllInOne.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95381 => 95382)

--- trunk/Source/WebCore/ChangeLog	2011-09-17 10:57:17 UTC (rev 95381)
+++ trunk/Source/WebCore/ChangeLog	2011-09-17 15:58:50 UTC (rev 95382)
@@ -1,3 +1,9 @@
+2011-09-17  Jeff Miller  
+
+Build fix after r95372.
+
+* dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"
+
 2011-09-17  Deepak Sherveghar  
 
 Override supportsFocus() for HTMLMediaElement.


Modified: trunk/Source/WebCore/dom/DOMAllInOne.cpp (95381 => 95382)

--- trunk/Source/WebCore/dom/DOMAllInOne.cpp	2011-09-17 10:57:17 UTC (rev 95381)
+++ trunk/Source/WebCore/dom/DOMAllInOne.cpp	2011-09-17 15:58:50 UTC (rev 95382)
@@ -71,6 +71,7 @@
 #include "EventContext.cpp"
 #include "EventDispatchMediator.cpp"
 #include "EventDispatcher.cpp"
+#include "EventListenerMap.cpp"
 #include "EventNames.cpp"
 #include "EventQueue.cpp"
 #include "EventTarget.cpp"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95057] trunk/Source/WebCore

2011-09-13 Thread jeffm

Title: [95057] trunk/Source/WebCore








Revision 95057
Author je...@apple.com
Date 2011-09-13 17:05:13 -0700 (Tue, 13 Sep 2011)


Log Message
WebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor on Windows
https://bugs.webkit.org/show_bug.cgi?id=68043

Make sure we set a valid platform cursor in the Cursor::NoDrop case, and add a default
clause that uses the arrow cursor in case another cursor type is added in the future
and we forget to update ensurePlatformCursor().

Reviewed by Anders Carlsson.

* platform/win/CursorWin.cpp:
(WebCore::Cursor::ensurePlatformCursor): Always set a valid platform cursor.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/CursorWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95056 => 95057)

--- trunk/Source/WebCore/ChangeLog	2011-09-13 23:32:36 UTC (rev 95056)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 00:05:13 UTC (rev 95057)
@@ -1,3 +1,17 @@
+2011-09-13  Jeff Miller  
+
+WebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor on Windows
+https://bugs.webkit.org/show_bug.cgi?id=68043
+
+Make sure we set a valid platform cursor in the Cursor::NoDrop case, and add a default
+clause that uses the arrow cursor in case another cursor type is added in the future
+and we forget to update ensurePlatformCursor().
+
+Reviewed by Anders Carlsson.
+
+* platform/win/CursorWin.cpp:
+(WebCore::Cursor::ensurePlatformCursor): Always set a valid platform cursor.
+
 2011-09-12  Jon Honeycutt  
 
 MSAA: WebKit reports the document state as disabled


Modified: trunk/Source/WebCore/platform/win/CursorWin.cpp (95056 => 95057)

--- trunk/Source/WebCore/platform/win/CursorWin.cpp	2011-09-13 23:32:36 UTC (rev 95056)
+++ trunk/Source/WebCore/platform/win/CursorWin.cpp	2011-09-14 00:05:13 UTC (rev 95057)
@@ -243,7 +243,6 @@
 m_platformCursor = loadSharedCursor(0, IDC_APPSTARTING);
 break;
 case Cursor::NoDrop:
-break;
 case Cursor::NotAllowed:
 m_platformCursor = loadSharedCursor(0, IDC_NO);
 break;
@@ -256,6 +255,10 @@
 case Cursor::Custom:
 m_platformCursor = createSharedCursor(m_image.get(), m_hotSpot);
 break;
+default:
+ASSERT_NOT_REACHED();
+m_platformCursor = loadSharedCursor(0, IDC_ARROW);
+break;
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [94465] trunk/Source/WebCore

2011-09-02 Thread jeffm

Title: [94465] trunk/Source/WebCore








Revision 94465
Author je...@apple.com
Date 2011-09-02 17:16:09 -0700 (Fri, 02 Sep 2011)


Log Message
Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=67541

Reviewed by Simon Fraser.

No new tests, covered by existing media tests.

* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (94464 => 94465)

--- trunk/Source/WebCore/ChangeLog	2011-09-03 00:07:44 UTC (rev 94464)
+++ trunk/Source/WebCore/ChangeLog	2011-09-03 00:16:09 UTC (rev 94465)
@@ -1,3 +1,15 @@
+2011-09-02  Jeff Miller  
+
+Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=67541
+
+Reviewed by Simon Fraser.
+
+No new tests, covered by existing media tests.
+
+* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
+(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.
+
 2011-09-02  Julien Chaffraix  
 
 Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp (94464 => 94465)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp	2011-09-03 00:07:44 UTC (rev 94464)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp	2011-09-03 00:16:09 UTC (rev 94465)
@@ -34,6 +34,7 @@
 #include "PlatformCALayer.h"
 #include "TextRun.h"
 #include 
+#include 
 
 using namespace std;
 using namespace WebCore;
@@ -62,6 +63,8 @@
 
 void PlatformCALayerWinInternal::displayCallback(CACFLayerRef caLayer, CGContextRef context)
 {
+ASSERT(isMainThread());
+
 if (!owner() || !owner()->owner())
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [94302] trunk/Source/WebCore

2011-09-01 Thread jeffm

Title: [94302] trunk/Source/WebCore








Revision 94302
Author je...@apple.com
Date 2011-09-01 10:15:46 -0700 (Thu, 01 Sep 2011)


Log Message
Defer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload()
https://bugs.webkit.org/show_bug.cgi?id=66253

Reviewed by Jon Honeycutt.

No new tests, should be covered by existing media tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Use the same code on Mac and Windows to only create the AVPlayer and AVPlayerItem when needed.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Assign any existing AVPlayerItem to the new AVPlayer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Allow creation of the AVPlayerItem before the AVPlayer.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (94301 => 94302)

--- trunk/Source/WebCore/ChangeLog	2011-09-01 16:10:46 UTC (rev 94301)
+++ trunk/Source/WebCore/ChangeLog	2011-09-01 17:15:46 UTC (rev 94302)
@@ -1,3 +1,19 @@
+2011-08-31  Jeff Miller  
+
+Defer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload()
+https://bugs.webkit.org/show_bug.cgi?id=66253
+
+Reviewed by Jon Honeycutt.
+
+No new tests, should be covered by existing media tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Use the same code on Mac and Windows to only create the AVPlayer and AVPlayerItem when needed.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Assign any existing AVPlayerItem to the new AVPlayer.
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Allow creation of the AVPlayerItem before the AVPlayer.
+
 2011-08-31  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=67321


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (94301 => 94302)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp	2011-09-01 16:10:46 UTC (rev 94301)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp	2011-09-01 17:15:46 UTC (rev 94302)
@@ -617,23 +617,15 @@
 
 if (m_preload >= MediaPlayer::MetaData && assetStatus() == MediaPlayerAVAssetStatusDoesNotExist) {
 createAVAssetForURL(m_assetURL);
-// FIXME: Remove this Windows-specific code when  is fixed, until then
-// we can't create an AVPlayer without an AVPlayerItem on Windows, so we always have to create
-// the item first.
-#if PLATFORM(WIN)
-createAVPlayerItem();
-#endif
-createAVPlayer();
 checkPlayability();
 }
 
-// FIXME: Enable this code on Windows when  is fixed.
-#if PLATFORM(MAC)
-// Don't force creation of the player item unless we already know that the asset is playable. If we aren't
-// there yet, or if we already know it is not playable, creating it now won't help.
-if (m_preload == MediaPlayer::Auto && m_assetIsPlayable)
+// Don't force creation of the player and player item unless we already know that the asset is playable. If we aren't
+// there yet, or if we already know it is not playable, creating them now won't help.
+if (m_preload == MediaPlayer::Auto && m_assetIsPlayable) {
 createAVPlayerItem();
-#endif
+createAVPlayer();
+}
 
 setDelayCallbacks(false);
 }


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (94301 => 94302)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2011-09-01 16:10:46 UTC (rev 94301)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2011-09-01 17:15:46 UTC (rev 94302)
@@ -287,6 +287,9 @@
 m_timeObserver = [m_avPlayer.get() addPeriodicTimeObserverForInterval:CMTimeMakeWithSeconds(veryLongInterval, 10) queue:nil usingBlock:^(CMTime time){
 [observer timeChanged:CMTimeGetSeconds(time)];
 }];
+
+if (m_avPlayerItem)
+[m_avPlayer.get() replaceCurrentItemWithPlayerItem:m_avPlayerItem.get()];
 
 setDelayCallbacks(false);
 }
@@ -298,8 +301,6 @@
 
 LOG(Media, "MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem(%p)", this);
 
-ASSERT(m_avPlayer);
-
 setDelayCallbacks(true);
 
 // Create the player item so we can load media data. 
@@ -310,7 +311,8 @@
 for (NSString *keyName in itemKVOPr

[webkit-changes] [94251] trunk/Source

2011-08-31 Thread jeffm

Title: [94251] trunk/Source








Revision 94251
Author je...@apple.com
Date 2011-08-31 16:55:01 -0700 (Wed, 31 Aug 2011)


Log Message
Source/_javascript_Core: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316

Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.

Reviewed by Darin Adler.

* wtf/Platform.h: Added definition of WTF_USE_AVFOUNDATION on the Mac.

Source/WebCore: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316

Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.

Reviewed by Darin Adler.

No new tests, covered by existing media tests.

* config.h: Removed definition of WTF_USE_AVFOUNDATION on the Mac, add a comment about fixing this on Windows in the future.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (94250 => 94251)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-31 23:55:01 UTC (rev 94251)
@@ -1,3 +1,16 @@
+2011-08-31  Jeff Miller  
+
+REGRESSION(92210): AVFoundation media engine is disabled on OS X
+https://bugs.webkit.org/show_bug.cgi?id=67316
+
+Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
+since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
+changes that were made in r92210.
+
+Reviewed by Darin Adler.
+
+* wtf/Platform.h: Added definition of WTF_USE_AVFOUNDATION on the Mac.
+
 2011-08-31  Peter Beverloo  
 
 Add Android's platform specification and the right atomic functions.


Modified: trunk/Source/_javascript_Core/wtf/Platform.h (94250 => 94251)

--- trunk/Source/_javascript_Core/wtf/Platform.h	2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2011-08-31 23:55:01 UTC (rev 94251)
@@ -1158,4 +1158,8 @@
 #endif
 #endif
 
+#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+#define WTF_USE_AVFOUNDATION 1
+#endif
+
 #endif /* WTF_Platform_h */


Modified: trunk/Source/WebCore/ChangeLog (94250 => 94251)

--- trunk/Source/WebCore/ChangeLog	2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/WebCore/ChangeLog	2011-08-31 23:55:01 UTC (rev 94251)
@@ -1,3 +1,18 @@
+2011-08-31  Jeff Miller  
+
+REGRESSION(92210): AVFoundation media engine is disabled on OS X
+https://bugs.webkit.org/show_bug.cgi?id=67316
+
+Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
+since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
+changes that were made in r92210.
+
+Reviewed by Darin Adler.
+
+No new tests, covered by existing media tests.
+
+* config.h: Removed definition of WTF_USE_AVFOUNDATION on the Mac, add a comment about fixing this on Windows in the future.
+
 2011-08-31  Sailesh Agrawal  
 
 [Chromium] Switching between overlay and opaque scrollbars causes glitches


Modified: trunk/Source/WebCore/config.h (94250 => 94251)

--- trunk/Source/WebCore/config.h	2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/WebCore/config.h	2011-08-31 23:55:01 UTC (rev 94251)
@@ -222,10 +222,8 @@
 #include 
 #endif
 
-#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
-#define WTF_USE_AVFOUNDATION 1
-#endif
-
+// FIXME: Move this to _javascript_Core/wtf/Platform.h, which is where we define WTF_USE_AVFOUNDATION on the Mac.
+// https://bugs.webkit.org/show_bug.cgi?id=67334
 #if PLATFORM(WIN) && HAVE(AVCF)
 #define WTF_USE_AVFOUNDATION 1
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93843] trunk/Source/WebKit2

2011-08-25 Thread jeffm

Title: [93843] trunk/Source/WebKit2








Revision 93843
Author je...@apple.com
Date 2011-08-25 17:51:06 -0700 (Thu, 25 Aug 2011)


Log Message
Move Windows-specific WebPageProxy code to WebPageProxyWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=67002

Reviewed by Brian Weinstein.

* UIProcess/WebPageProxy.cpp: Moved Windows-only functions to WebPageProxyWin.cpp.

* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::getSelectedText): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureWillBegin): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidScroll): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidEnd): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setGestureReachedScrollingLimit): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::startDragDrop): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::didChangeCompositionSelection): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::confirmComposition): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setComposition): Moved from WebPageProxy.cpp.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/win/WebPageProxyWin.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (93842 => 93843)

--- trunk/Source/WebKit2/ChangeLog	2011-08-26 00:41:09 UTC (rev 93842)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-26 00:51:06 UTC (rev 93843)
@@ -1,3 +1,24 @@
+2011-08-25  Jeff Miller  
+
+Move Windows-specific WebPageProxy code to WebPageProxyWin.cpp
+https://bugs.webkit.org/show_bug.cgi?id=67002
+
+Reviewed by Brian Weinstein.
+
+* UIProcess/WebPageProxy.cpp: Moved Windows-only functions to WebPageProxyWin.cpp.
+
+* UIProcess/win/WebPageProxyWin.cpp:
+(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::getSelectedText): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::gestureWillBegin): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::gestureDidScroll): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::gestureDidEnd): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::setGestureReachedScrollingLimit): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::startDragDrop): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::didChangeCompositionSelection): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::confirmComposition): Moved from WebPageProxy.cpp.
+(WebKit::WebPageProxy::setComposition): Moved from WebPageProxy.cpp.
+
 2011-08-25  Anders Carlsson  
 
 Handle key-down events in the updated Cocoa text input model


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (93842 => 93843)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-08-26 00:41:09 UTC (rev 93842)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-08-26 00:51:06 UTC (rev 93843)
@@ -79,15 +79,6 @@
 #include 
 #include 
 
-#if PLATFORM(WIN)
-#include "WebDragSource.h"
-#include 
-#include 
-#include 
-#include 
-#include 
-#endif
-
 #if PLATFORM(QT)
 #include "ArgumentCodersQt.h"
 #endif
@@ -737,44 +728,6 @@
 process()->send(Messages::WebPage::ExecuteEditCommand(commandName), m_pageID);
 }
 
-#if PLATFORM(WIN)
-IntRect WebPageProxy::firstRectForCharacterInSelectedRange(int characterPosition)
-{
-IntRect resultRect;
-process()->sendSync(Messages::WebPage::FirstRectForCharacterInSelectedRange(characterPosition), Messages::WebPage::FirstRectForCharacterInSelectedRange::Reply(resultRect), m_pageID);
-return resultRect;
-}
-
-String WebPageProxy::getSelectedText()
-{
-String text;
-process()->sendSync(Messages::WebPage::GetSelectedText(), Messages::WebPage::GetSelectedText::Reply(text), m_pageID);
-return text;
-}
-
-bool WebPageProxy::gestureWillBegin(const IntPoint& point)
-{
-bool canBeginPanning = false;
-process()->sendSync(Messages::WebPage::GestureWillBegin(point), Messages::WebPage::GestureWillBegin::Reply(canBeginPanning), m_pageID);
-return canBeginPanning;
-}
-
-void WebPageProxy::gestureDidScroll(const IntSize& size)
-{
-process()->send(Messages::WebPage::GestureDidScroll(size), m_pageID);
-}
-
-void WebPageProxy::gestureDidEnd()
-{
-process()->send(Messages::WebPage::GestureDidEnd(), m_pageID);
-}
-
-void WebPageProxy::setGestureReachedScrollingLimit(bool limitReached)
-{
-m_pageClient->setGestureReachedScrollingLimit(limitReached);
-}
-#endif
-
 #if ENABLE(TILED_BACKING_STORE)
 void WebPageProxy::setFixedVisibleContentRect(const IntRect& rect)
 {
@@ -828,68 +781,6 @@
 m_currentDragOperation = static_cast(resultOperation);
 }
 
-#if PLATFORM(WIN)
-
-void WebPageProxy::startDragDrop(const IntPoint& imageOrigin, const IntPoint& dragPoint, uint64_t okEffect, const HashMap >& dataMap, uin

[webkit-changes] [93459] trunk/Source/WebCore

2011-08-19 Thread jeffm

Title: [93459] trunk/Source/WebCore








Revision 93459
Author je...@apple.com
Date 2011-08-19 17:41:58 -0700 (Fri, 19 Aug 2011)


Log Message
MediaPlayerPrivateAVFoundationCF should use AVCFURLAssetCopyAudiovisualMIMETypes() to get list of supported MIME types
https://bugs.webkit.org/show_bug.cgi?id=66612

Reviewed by Darin Adler.

No new tests, should be covered by existing media tests.

* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added AVCFURLAssetCopyAudiovisualMIMETypes().
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::mimeTypeCache): Use AVCFURLAssetCopyAudiovisualMIMETypes() to build the cache of supported MIME types.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93458 => 93459)

--- trunk/Source/WebCore/ChangeLog	2011-08-20 00:20:48 UTC (rev 93458)
+++ trunk/Source/WebCore/ChangeLog	2011-08-20 00:41:58 UTC (rev 93459)
@@ -1,3 +1,16 @@
+2011-08-19  Jeff Miller  
+
+MediaPlayerPrivateAVFoundationCF should use AVCFURLAssetCopyAudiovisualMIMETypes() to get list of supported MIME types
+https://bugs.webkit.org/show_bug.cgi?id=66612
+
+Reviewed by Darin Adler.
+
+No new tests, should be covered by existing media tests.
+
+* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added AVCFURLAssetCopyAudiovisualMIMETypes().
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::mimeTypeCache): Use AVCFURLAssetCopyAudiovisualMIMETypes() to build the cache of supported MIME types.
+
 2011-08-19  Adrienne Walker  
 
 [chromium] Regression: Fix clang errors from r93424


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h (93458 => 93459)

--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h	2011-08-20 00:20:48 UTC (rev 93458)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h	2011-08-20 00:41:58 UTC (rev 93459)
@@ -171,6 +171,9 @@
 SOFT_LINK_DLL_IMPORT(AVFoundationCF, AVCFPlayerSetVolume, void, __cdecl, (AVCFPlayerRef player, Float32 volume), (player, volume))
 #define AVCFPlayerSetVolume softLink_AVCFPlayerSetVolume
 
+SOFT_LINK_DLL_IMPORT(AVFoundationCF, AVCFURLAssetCopyAudiovisualMIMETypes, CFArrayRef, __cdecl, (), ())
+#define AVCFURLAssetCopyAudiovisualMIMETypes softLink_AVCFURLAssetCopyAudiovisualMIMETypes
+
 SOFT_LINK_DLL_IMPORT(AVFoundationCF, AVCFURLAssetCreateWithURLAndOptions, AVCFURLAssetRef, __cdecl, (CFAllocatorRef allocator, CFURLRef URL, CFDictionaryRef options, dispatch_queue_t notificationQueue), (allocator, URL, options, notificationQueue))
 #define AVCFURLAssetCreateWithURLAndOptions softLink_AVCFURLAssetCreateWithURLAndOptions
 


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (93458 => 93459)

--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-20 00:20:48 UTC (rev 93458)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-20 00:41:58 UTC (rev 93459)
@@ -704,20 +704,16 @@
 if (typeListInitialized)
 return cache;
 typeListInitialized = true;
+
+RetainPtr supportedTypes(AdoptCF, AVCFURLAssetCopyAudiovisualMIMETypes());
+
+ASSERT(supportedTypes);
+if (!supportedTypes)
+return cache;
 
-// Not possible to query AVFoundation for supported MIME types, , so
-// hard code some types for now.
-cache.add("video/quicktime");
-cache.add("video/mp4");
-cache.add("video/mpeg");
-cache.add("audio/3gpp");
-cache.add("audio/mp3");
-cache.add("audio/mp4");
-cache.add("audio/mp4");
-cache.add("audio/m4a");
-cache.add("audio/aac");
-cache.add("audio/wav");
-cache.add("application/vnd.apple.mpegurl");
+CFIndex typeCount = CFArrayGetCount(supportedTypes.get());
+for (CFIndex i = 0; i < typeCount; i++)
+cache.add(static_cast(CFArrayGetValueAtIndex(supportedTypes.get(), i)));
 
 return cache;
 } 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93363] trunk/Source/WebCore

2011-08-18 Thread jeffm

Title: [93363] trunk/Source/WebCore








Revision 93363
Author je...@apple.com
Date 2011-08-18 15:57:04 -0700 (Thu, 18 Aug 2011)


Log Message
Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725

Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with __declspec(dllimport),
and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
until a media element is used.

Reviewed by Eric Carlson.

No new tests as no change in functionality.

* WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
* WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
* platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
* platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp
trunk/Source/WebCore/platform/win/SoftLinking.h


Added Paths

trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h
trunk/Source/WebCore/platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93362 => 93363)

--- trunk/Source/WebCore/ChangeLog	2011-08-18 22:49:44 UTC (rev 93362)
+++ trunk/Source/WebCore/ChangeLog	2011-08-18 22:57:04 UTC (rev 93363)
@@ -1,3 +1,23 @@
+2011-08-18  Jeff Miller  
+
+Soft link against AVFoundationCF and CoreMedia
+https://bugs.webkit.org/show_bug.cgi?id=65725
+
+Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with __declspec(dllimport),
+and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
+until a media element is used.
+
+Reviewed by Eric Carlson.
+
+No new tests as no change in functionality.
+
+* WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
+* WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
+* platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
+* platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
+* platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.
+
 2011-08-18  Sailesh Agrawal  
 
 Chromium Mac: Show scrollbar when doing search


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (93362 => 93363)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-08-18 22:49:44 UTC (rev 93362)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-08-18 22:57:04 UTC (rev 93363)
@@ -30307,6 +30307,14 @@
 		Name="cf"
 		>
 		+			RelativePath="..\platform\graphics\avfoundation\cf\AVFoundationCFSoftLinking.h"
+			>
+		
+		
+		
+		 			RelativePath="..\platform\graphics\avfoundation\cf\MediaPlayerPrivateAVFoundationCF.cpp"
 			>
 		


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops (93362 => 93363)

--- trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops	2011-08-18 22:49:44 UTC (rev 93362)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops	2011-08-18 22:57:04 UTC (rev 93363)
@@ -8,8 +8,4 @@
 		Name="VCCLCompilerTool"
 		AdditionalIncludeDirectories=""$(WebKitLibrariesDir)\include\CoreAudio";"$(WebKitLibrariesDir)\include\AVFoundation";"$(ProjectDir)..\platform\graphics\avfoundation";"$(ProjectDir)..\platform\graphics\avfoundation\cf""
 	/>
-	
 


Added: trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h (0 => 93363)

--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h	(rev 0)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h	2011-08-18 22:57:04 UTC (rev 93363)
@@ -0,0 +1,243 @@
+/*
+ * Copyright (C) 2011 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source co

[webkit-changes] [93215] trunk/Source/WebCore

2011-08-17 Thread jeffm

Title: [93215] trunk/Source/WebCore








Revision 93215
Author je...@apple.com
Date 2011-08-17 10:16:31 -0700 (Wed, 17 Aug 2011)


Log Message
Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

* WebCore.vcproj/WebCore.vcproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (93214 => 93215)

--- trunk/Source/WebCore/ChangeLog	2011-08-17 17:16:20 UTC (rev 93214)
+++ trunk/Source/WebCore/ChangeLog	2011-08-17 17:16:31 UTC (rev 93215)
@@ -1,3 +1,9 @@
+2011-08-17  Jeff Miller  
+
+Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
+
+* WebCore.vcproj/WebCore.vcproj:
+
 2011-08-17  Sailesh Agrawal  
 
 Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (93214 => 93215)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-08-17 17:16:20 UTC (rev 93214)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-08-17 17:16:31 UTC (rev 93215)
@@ -558,14 +558,6 @@
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\WebKitFontFamilyNames.cpp"
->
-			
-			
-			
-			 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\InjectedScriptSource.h"
 >
 			
@@ -,66 +6658,10 @@
 
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLUnknownElement.cpp"
->
-
-	
-
-
-	
-
-
-	
-
-
-	
-
-
-	
-
-
-	
-
-			
-			 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLElement.h"
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLUnknownElement.h"
->
-			
-			 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLElementWrapperFactory.cpp"
 >
 @@ -6778,10 +6714,6 @@
 
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLUnknownElement.h"
-			>
-			
-			 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLElementWrapperFactory.h"
 >
 			
@@ -9530,6 +9462,66 @@
 >
 			
 			+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLUnknownElement.cpp"
+>
+
+	
+
+
+	
+
+
+	
+
+
+	
+
+
+	
+
+
+	
+
+			
+			
+			
+			
+			
+			 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSHTMLVideoElement.cpp"
 >
 @@ -24082,6 +24074,14 @@
 
 			
 			+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\WebKitFontFamilyNames.cpp"
+>
+			
+			
+			
+			 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\XLinkNames.cpp"
 >
 			
@@ -2,15 +2,15 @@
 	>
 
 -	RelativePath="..\platform\graphics\FontFeatureSettings.cpp"
+	RelativePath="..\platform\graphics\FontFastPath.cpp"
 	>
 
 -	RelativePath="..\platform\graphics\FontFeatureSettings.h"
+	RelativePath="..\platform\graphics\FontFeatureSettings.cpp"
 	>
 
 -	RelativePath="..\platform\graphics\FontFastPath.cpp"
+	RelativePath="..\platform\graphics\FontFeatureSettings.h"
 	>
 
 @@ -31589,11 +31589,11 @@
 	>
 
 -	RelativePath="..\platform\text\LocaleToScriptMappingDefault.cpp"
+	RelativePath="..\platform\text\LocaleToScriptMapping.h"
 	>
 
 -	RelativePath="..\platform\text\LocaleToScriptMapping.h"
+	RelativePath="..\platform\text\LocaleToScriptMappingDefault.cpp"
 	>
 
 @@ -42813,11 +42813,11 @@
 	>
 
 -	RelativePath="..\xml\parser\NewXMLDocumentParser.h"
+	RelativePath="..\xml\parser\NewXMLDocumentParser.cpp"
 	>
 
 -	RelativePath="..\xml\parser\NewXMLDocumentParser.cpp"
+	RelativePath="..\xml\parser\NewXMLDocumentParser.h"
 	>
 
 @@ -42945,11 +42945,11 @@
 	>
 
 -	RelativePath="..\xml\parser\XMLTreeBuilder.h"
+	RelativePath="..\xml\parser\XMLTreeBuilder.cpp"
 	>
 
 -	RelativePath="..\xml\parser\XMLTreeBuilder.cpp"
+	RelativePath="..\xml\parser\XMLTreeBuilder.h"
 	>
 
 			
@@ -44778,12 +44778,8 @@
 >
 			
 			-RelativePath="..\dom\DocumentMarker.h"
+RelativePath="..\dom\DocumentMarker.cpp"
 >
-			
-			
  	Name="Debug|Win32"
 	ExcludedFromBuild="true"
@@ -44834,11 +44830,11 @@
 
 			
 			-RelativePath="..\dom\DocumentMarkerController.h"
+RelativePath="..\dom\DocumentMarker.h"
 >
 			
 			-RelativePath="..\dom\DocumentMarker.cpp"
+RelativePath="..\dom\Docum

[webkit-changes] [93194] trunk/Source/WebCore

2011-08-16 Thread jeffm

Title: [93194] trunk/Source/WebCore








Revision 93194
Author je...@apple.com
Date 2011-08-16 21:49:15 -0700 (Tue, 16 Aug 2011)


Log Message
Apple's Windows production build should fail to compile if AVFoundation is not enabled
https://bugs.webkit.org/show_bug.cgi?id=66339

Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93193 => 93194)

--- trunk/Source/WebCore/ChangeLog	2011-08-17 01:54:03 UTC (rev 93193)
+++ trunk/Source/WebCore/ChangeLog	2011-08-17 04:49:15 UTC (rev 93194)
@@ -1,3 +1,14 @@
+2011-08-16  Jeff Miller  
+
+Apple's Windows production build should fail to compile if AVFoundation is not enabled
+https://bugs.webkit.org/show_bug.cgi?id=66339
+
+Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
+Reviewed by Darin Adler.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
 2011-08-16  David Levin  
 
 REGRESSION (r89086): All worker xhr requests trigger preflight requests.


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (93193 => 93194)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-17 01:54:03 UTC (rev 93193)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-17 04:49:15 UTC (rev 93194)
@@ -25,8 +25,10 @@
 
 #include "config.h"
 
-#if PLATFORM(WIN) && ENABLE(VIDEO) && USE(AVFOUNDATION)
+#if PLATFORM(WIN)&& ENABLE(VIDEO) 
 
+#if USE(AVFOUNDATION)
+
 #include "MediaPlayerPrivateAVFoundationCF.h"
 
 #include "ApplicationCacheResource.h"
@@ -1271,4 +1273,10 @@
 
 } // namespace WebCore
 
-#endif // PLATFORM(WIN) && ENABLE(VIDEO) && USE(AVFOUNDATION)
+#else
+// AVFoundation should always be enabled for Apple production builds.
+#if __PRODUCTION__ && !USE(AVFOUNDATION)
+#error AVFoundation is not enabled!
+#endif // __PRODUCTION__ && !USE(AVFOUNDATION)
+#endif // USE(AVFOUNDATION)
+#endif // PLATFORM(WIN) && ENABLE(VIDEO)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93047] trunk/Source/WebCore

2011-08-15 Thread jeffm

Title: [93047] trunk/Source/WebCore








Revision 93047
Author je...@apple.com
Date 2011-08-15 10:41:34 -0700 (Mon, 15 Aug 2011)


Log Message
MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
https://bugs.webkit.org/show_bug.cgi?id=66171

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC.  I also added better logging to notificationCallback().

Reviewed by Jon Honeycutt.

No new tests, uses existing media tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93046 => 93047)

--- trunk/Source/WebCore/ChangeLog	2011-08-15 17:21:30 UTC (rev 93046)
+++ trunk/Source/WebCore/ChangeLog	2011-08-15 17:41:34 UTC (rev 93047)
@@ -1,3 +1,19 @@
+2011-08-12  Jeff Miller  
+
+MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+https://bugs.webkit.org/show_bug.cgi?id=66171
+
+MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC.  I also added better logging to notificationCallback().
+
+Reviewed by Jon Honeycutt.
+
+No new tests, uses existing media tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
+(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.
+
 2011-08-15  Adam Roben  
 
 Rename an instance of pageScaleFactorChanged I missed in r93040


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (93046 => 93047)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-15 17:21:30 UTC (rev 93046)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-15 17:41:34 UTC (rev 93047)
@@ -388,7 +388,7 @@
 MediaPlayerPrivateAVFoundation::ItemStatus MediaPlayerPrivateAVFoundationCF::playerItemStatus() const
 {
 if (!avPlayerItem(m_avfWrapper))
-return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusUnknown;
+return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusDoesNotExist;
 
 AVCFPlayerItemStatus status = AVCFPlayerItemGetStatus(avPlayerItem(m_avfWrapper), 0);
 if (status == AVCFPlayerItemStatusUnknown)
@@ -1041,7 +1041,11 @@
 return;
 }
 
-LOG(Media, "AVFWrapper::notificationCallback(%p)", self);
+#if !LOG_DISABLED
+char notificationName[256];
+CFStringGetCString(propertyName, notificationName, sizeof(notificationName), kCFStringEncodingASCII);
+LOG(Media, "AVFWrapper::notificationCallback(%p) %s", self, notificationName);
+#endif
 
 if (CFEqual(propertyName, AVCFPlayerItemDidPlayToEndTimeNotification))
 self->m_owner->scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::ItemDidPlayToEndTime);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92977] trunk/Source/WebCore

2011-08-12 Thread jeffm

Title: [92977] trunk/Source/WebCore








Revision 92977
Author je...@apple.com
Date 2011-08-12 11:42:25 -0700 (Fri, 12 Aug 2011)


Log Message
Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
https://bugs.webkit.org/show_bug.cgi?id=65724

Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).

Reviewed by Eric Carlson.

No new tests, uses existing media tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::callbackContext): Added.
(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
(WebCore::AVFWrapper::mapLock): Added.
(WebCore::AVFWrapper::map): Added.
(WebCore::AVFWrapper::addToMap): Added.
(WebCore::AVFWrapper::removeFromMap): Added.
(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
(WebCore::AVFWrapper::createPlayer): Use callbackContext().
(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
(WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::seekToTime): Use callbackContext().
(WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92976 => 92977)

--- trunk/Source/WebCore/ChangeLog	2011-08-12 18:36:37 UTC (rev 92976)
+++ trunk/Source/WebCore/ChangeLog	2011-08-12 18:42:25 UTC (rev 92977)
@@ -1,3 +1,40 @@
+2011-08-12  Jeff Miller  
+
+Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
+https://bugs.webkit.org/show_bug.cgi?id=65724
+
+Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
+ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
+access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
+AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).
+
+Reviewed by Eric Carlson.
+
+No new tests, uses existing media tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::AVFWrapper::callbackContext): Added.
+(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
+(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
+(WebCore::AVFWrapper::mapLock): Added.
+(WebCore::AVFWrapper::map): Added.
+(WebCore::AVFWrapper::addToMap): Added.
+(WebCore::AVFWrapper::removeFromMap): Added.
+(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
+(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
+(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
+(WebCore::AVFWrapper::createPlayer): Use callbackContext().
+(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
+(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
+(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext

[webkit-changes] [92894] trunk/Source/WebCore

2011-08-11 Thread jeffm

Title: [92894] trunk/Source/WebCore








Revision 92894
Author je...@apple.com
Date 2011-08-11 17:20:09 -0700 (Thu, 11 Aug 2011)


Log Message
WebCore::AVFWrapper fails to remove observer for kCACFContextNeedsFlushNotification
https://bugs.webkit.org/show_bug.cgi?id=66116

We need to pass 0 as the object parameter to CFNotificationCenterRemoveObserver() when removing
kCACFContextNeedsFlushNotification to match what we do when we registered for the same
notification with CFNotificationCenterAddObserver().

Reviewed by John Sullivan.

No new tests, uses existing media tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Pass 0 as the object parameter to CFNotificationCenterRemoveObserver().
(WebCore::AVFWrapper::notificationCallback): Remove obsolete FIXME comment.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92893 => 92894)

--- trunk/Source/WebCore/ChangeLog	2011-08-12 00:18:59 UTC (rev 92893)
+++ trunk/Source/WebCore/ChangeLog	2011-08-12 00:20:09 UTC (rev 92894)
@@ -1,3 +1,20 @@
+2011-08-11  Jeff Miller  
+
+WebCore::AVFWrapper fails to remove observer for kCACFContextNeedsFlushNotification
+https://bugs.webkit.org/show_bug.cgi?id=66116
+
+We need to pass 0 as the object parameter to CFNotificationCenterRemoveObserver() when removing
+kCACFContextNeedsFlushNotification to match what we do when we registered for the same
+notification with CFNotificationCenterAddObserver().
+
+Reviewed by John Sullivan.
+
+No new tests, uses existing media tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Pass 0 as the object parameter to CFNotificationCenterRemoveObserver().
+(WebCore::AVFWrapper::notificationCallback): Remove obsolete FIXME comment.
+
 2011-08-11  Ryosuke Niwa  
 
 Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSpan,


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (92893 => 92894)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-12 00:18:59 UTC (rev 92893)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-12 00:20:09 UTC (rev 92894)
@@ -895,7 +895,7 @@
 CFNotificationCenterRemoveObserver(center, avfWrapper, AVCFPlayerItemIsPlaybackLikelyToKeepUpChangedNotification, avfWrapper->avPlayerItem());
 CFNotificationCenterRemoveObserver(center, avfWrapper, AVCFPlayerItemIsPlaybackBufferEmptyChangedNotification, avfWrapper->avPlayerItem());
 CFNotificationCenterRemoveObserver(center, avfWrapper, AVCFPlayerItemIsPlaybackBufferFullChangedNotification, avfWrapper->avPlayerItem());
-CFNotificationCenterRemoveObserver(center, avfWrapper, CACFContextNeedsFlushNotification(), avfWrapper->avPlayerItem());
+CFNotificationCenterRemoveObserver(center, avfWrapper, CACFContextNeedsFlushNotification(), 0);
 }
 
 if (avfWrapper->avPlayer()) {
@@ -1026,11 +1026,9 @@
 self->m_owner->scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::ItemIsPlaybackBufferFullChanged);
 else if (CFEqual(propertyName, AVCFPlayerRateChangedNotification))
 self->m_owner->scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::PlayerRateChanged);
-else if (CFEqual(propertyName, CACFContextNeedsFlushNotification())) {
-// FIXME: Note that until  is fixed, we can get a kCACFContextNeedsFlushNotification after
-// the AVFWrapper has gone away. We work around this for now by never actually deleting the underlying AVFWrapper object. 
+else if (CFEqual(propertyName, CACFContextNeedsFlushNotification()))
 self->m_owner->scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::ContentsNeedsDisplay);
-} else
+else
 ASSERT_NOT_REACHED();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92414] trunk/Source/WebKit/win

2011-08-04 Thread jeffm

Title: [92414] trunk/Source/WebKit/win








Revision 92414
Author je...@apple.com
Date 2011-08-04 14:40:42 -0700 (Thu, 04 Aug 2011)


Log Message
Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=65718

Reviewed by Adam Roben.

* Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().

* WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.

* WebPreferences.cpp:
(WebPreferences::avFoundationEnabled): Added.
(WebPreferences::setAVFoundationEnabled): Added.

* WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().

* WebView.cpp:
(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl
trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/win/WebPreferences.cpp
trunk/Source/WebKit/win/WebPreferences.h
trunk/Source/WebKit/win/WebView.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (92413 => 92414)

--- trunk/Source/WebKit/win/ChangeLog	2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/ChangeLog	2011-08-04 21:40:42 UTC (rev 92414)
@@ -1,3 +1,23 @@
+2011-08-04  Jeff Miller  
+
+Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
+https://bugs.webkit.org/show_bug.cgi?id=65718
+
+Reviewed by Adam Roben.
+
+* Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
+
+* WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
+
+* WebPreferences.cpp:
+(WebPreferences::avFoundationEnabled): Added.
+(WebPreferences::setAVFoundationEnabled): Added.
+
+* WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
+
+* WebView.cpp:
+(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.
+
 2011-08-03  Kent Tamura  
 
 [Windows] Fix build without ENABLE_VIDEO.


Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl (92413 => 92414)

--- trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl	2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl	2011-08-04 21:40:42 UTC (rev 92414)
@@ -202,4 +202,7 @@
 
 HRESULT pictographFontFamily([out, retval] BSTR* family);
 HRESULT setPictographFontFamily([in] BSTR family);
+
+HRESULT setAVFoundationEnabled(BOOL avFoundationEnabled);
+HRESULT avFoundationEnabled(BOOL *avFoundationEnabled);
 }


Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (92413 => 92414)

--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h	2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h	2011-08-04 21:40:42 UTC (rev 92414)
@@ -160,3 +160,4 @@
 
 #define WebKitMediaPlaybackAllowsInlinePreferenceKey "WebKitMediaPlaybackAllowsInline"
 
+#define WebKitAVFoundationEnabledPreferenceKey "WebKitAVFoundationEnabled"


Modified: trunk/Source/WebKit/win/WebPreferences.cpp (92413 => 92414)

--- trunk/Source/WebKit/win/WebPreferences.cpp	2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebPreferences.cpp	2011-08-04 21:40:42 UTC (rev 92414)
@@ -1612,6 +1612,29 @@
 #endif
 }
 
+HRESULT WebPreferences::avFoundationEnabled(BOOL* enabled)
+{
+#if USE(AVFOUNDATION)
+if (!enabled)
+return E_POINTER;
+
+*enabled = boolValueForKey(CFSTR(WebKitAVFoundationEnabledPreferenceKey));
+return S_OK;
+#else
+return E_NOTIMPL;
+#endif
+}
+
+HRESULT WebPreferences::setAVFoundationEnabled(BOOL enabled)
+{
+#if USE(AVFOUNDATION)
+setBoolValue(CFSTR(WebKitAVFoundationEnabledPreferenceKey), enabled);
+return S_OK;
+#else
+return E_NOTIMPL;
+#endif
+}
+
 void WebPreferences::willAddToWebView()
 {
 ++m_numWebViews;


Modified: trunk/Source/WebKit/win/WebPreferences.h (92413 => 92414)

--- trunk/Source/WebKit/win/WebPreferences.h	2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebPreferences.h	2011-08-04 21:40:42 UTC (rev 92414)
@@ -292,6 +292,12 @@
 virtual HRESULT STDMETHODCALLTYPE shouldPaintCustomScrollbars( 
 /* [retval][out] */ BOOL *shouldPaint);
 
+virtual HRESULT STDMETHODCALLTYPE setAVFoundationEnabled(
+/* [in] */ BOOL);
+
+virtual HRESULT STDMETHODCALLTYPE avFoundationEnabled(
+/* [retval][out] */ BOOL*);
+
 // IWebPreferencesPrivate
 virtual HRESULT STDMETHODCALLTYPE setDeveloperExtrasEnabled(
 /* [in] */ BOOL);


Modified: trunk/Source/WebKit/win/WebView.cpp (92413 => 92414)

--- trunk/Source/WebKit/win/WebView.cpp	2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebView.cpp	2011-08-04 21:40:42 UTC (rev 92414)
@@ -4727,6 +4727,13 @@
 return hr;
 settings->setFontRenderingMode(smoothingType != FontSmoothingTypeWindows ? No

[webkit-changes] [92398] trunk/Source/WebCore

2011-08-04 Thread jeffm

Title: [92398] trunk/Source/WebCore








Revision 92398
Author je...@apple.com
Date 2011-08-04 12:21:55 -0700 (Thu, 04 Aug 2011)


Log Message
Fix WinCE build after r92308.

* config.h: Don't try to include WebCoreHeaderDetection.h for WinCE.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92397 => 92398)

--- trunk/Source/WebCore/ChangeLog	2011-08-04 19:20:18 UTC (rev 92397)
+++ trunk/Source/WebCore/ChangeLog	2011-08-04 19:21:55 UTC (rev 92398)
@@ -1,3 +1,9 @@
+2011-08-04  Jeff Miller  
+
+Fix WinCE build after r92308.
+
+* config.h: Don't try to include WebCoreHeaderDetection.h for WinCE.
+
 2011-08-04  Darin Fisher  
 
 webkitRequestAnimationFrame's element argument needs to be marked optional


Modified: trunk/Source/WebCore/config.h (92397 => 92398)

--- trunk/Source/WebCore/config.h	2011-08-04 19:20:18 UTC (rev 92397)
+++ trunk/Source/WebCore/config.h	2011-08-04 19:21:55 UTC (rev 92398)
@@ -29,7 +29,7 @@
 
 #include 
 
-#if OS(WINDOWS) && !PLATFORM(QT) && !PLATFORM(CHROMIUM)
+#if OS(WINDOWS) && !OS(WINCE) && !PLATFORM(QT) && !PLATFORM(CHROMIUM)
 #include 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92345] trunk/Source/WebKit2

2011-08-03 Thread jeffm

Title: [92345] trunk/Source/WebKit2








Revision 92345
Author je...@apple.com
Date 2011-08-03 20:54:57 -0700 (Wed, 03 Aug 2011)


Log Message
Use of AVFoundation should default to off on Windows
https://bugs.webkit.org/show_bug.cgi?id=65660

Reviewed by Darin Adler.

* Shared/WebPreferencesStore.h: Change default value for AVFoundationEnabled to false on Windows, it's still true on other platforms.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92344 => 92345)

--- trunk/Source/WebKit2/ChangeLog	2011-08-04 03:02:54 UTC (rev 92344)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-04 03:54:57 UTC (rev 92345)
@@ -1,3 +1,12 @@
+2011-08-03  Jeff Miller  
+
+Use of AVFoundation should default to off on Windows
+https://bugs.webkit.org/show_bug.cgi?id=65660
+
+Reviewed by Darin Adler.
+
+* Shared/WebPreferencesStore.h: Change default value for AVFoundationEnabled to false on Windows, it's still true on other platforms.
+
 2011-08-03  Mark Rowe  
 
 Bring some order to FeatureDefines.xcconfig to make it easier to follow.


Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (92344 => 92345)

--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2011-08-04 03:02:54 UTC (rev 92344)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2011-08-04 03:54:57 UTC (rev 92345)
@@ -36,6 +36,12 @@
 
 // macro(KeyUpper, KeyLower, TypeNameUpper, TypeName, DefaultValue) 
 
+#if PLATFORM(WIN)
+#define DEFAULT_WEBKIT_AVFOUNDATION_ENABLED false
+#else
+#define DEFAULT_WEBKIT_AVFOUNDATION_ENABLED true
+#endif
+
 #define FOR_EACH_WEBKIT_BOOL_PREFERENCE(macro) \
 macro(_javascript_Enabled, _javascript_Enabled, Bool, bool, true) \
 macro(LoadsImagesAutomatically, loadsImagesAutomatically, Bool, bool, true) \
@@ -74,7 +80,7 @@
 macro(WebSecurityEnabled, webSecurityEnabled, Bool, bool, true) \
 macro(AllowUniversalAccessFromFileURLs, allowUniversalAccessFromFileURLs, Bool, bool, false) \
 macro(AllowFileAccessFromFileURLs, allowFileAccessFromFileURLs, Bool, bool, false) \
-macro(AVFoundationEnabled, isAVFoundationEnabled, Bool, bool, true) \
+macro(AVFoundationEnabled, isAVFoundationEnabled, Bool, bool, DEFAULT_WEBKIT_AVFOUNDATION_ENABLED) \
 macro(Hixie76WebSocketProtocolEnabled, hixie76WebSocketProtocolEnabled, Bool, bool, true) \
 macro(MediaPlaybackRequiresUserGesture, mediaPlaybackRequiresUserGesture, Bool, bool, false) \
 macro(MediaPlaybackAllowsInline, mediaPlaybackAllowsInline, Bool, bool, true) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92309] trunk/Source/WebCore

2011-08-03 Thread jeffm

Title: [92309] trunk/Source/WebCore








Revision 92309
Author je...@apple.com
Date 2011-08-03 13:52:32 -0700 (Wed, 03 Aug 2011)


Log Message
Fix Chromimum and Qt builds after r92308.

* config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92308 => 92309)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 20:15:53 UTC (rev 92308)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 20:52:32 UTC (rev 92309)
@@ -1,5 +1,11 @@
 2011-08-03  Jeff Miller  
 
+Fix Chromimum and Qt builds after r92308.
+
+* config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt.
+
+2011-08-03  Jeff Miller  
+
 Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
 https://bugs.webkit.org/show_bug.cgi?id=65634
 


Modified: trunk/Source/WebCore/config.h (92308 => 92309)

--- trunk/Source/WebCore/config.h	2011-08-03 20:15:53 UTC (rev 92308)
+++ trunk/Source/WebCore/config.h	2011-08-03 20:52:32 UTC (rev 92309)
@@ -29,7 +29,7 @@
 
 #include 
 
-#if OS(WINDOWS)
+#if OS(WINDOWS) && !PLATFORM(QT) && !PLATFORM(CHROMIUM)
 #include 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92308] trunk/Source/WebCore

2011-08-03 Thread jeffm

Title: [92308] trunk/Source/WebCore








Revision 92308
Author je...@apple.com
Date 2011-08-03 13:15:53 -0700 (Wed, 03 Aug 2011)


Log Message
Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
https://bugs.webkit.org/show_bug.cgi?id=65634

AVFoundation support on Windows will (eventually) be predicated on the
availability of AVFoundationCF headers and libraries in the WebKit Support
Libraries, so we test for the existence of one of the header files (AVCFBase.h)
to determine whether to AVCF is available.

For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since
it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400).

Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could
include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file
ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this
.cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h.

Reviewed by Adam Roben.

No change in functionality, so new tests.

* DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows.
* config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92307 => 92308)

--- trunk/Source/WebCore/ChangeLog	2011-08-03 20:13:59 UTC (rev 92307)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 20:15:53 UTC (rev 92308)
@@ -1,3 +1,28 @@
+2011-08-03  Jeff Miller  
+
+Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
+https://bugs.webkit.org/show_bug.cgi?id=65634
+
+AVFoundation support on Windows will (eventually) be predicated on the
+availability of AVFoundationCF headers and libraries in the WebKit Support
+Libraries, so we test for the existence of one of the header files (AVCFBase.h)
+to determine whether to AVCF is available.
+
+For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since
+it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400).
+
+Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could
+include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file
+ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this
+.cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h.
+
+Reviewed by Adam Roben.
+
+No change in functionality, so new tests.
+
+* DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows.
+* config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now.
+
 2011-08-03  Tommy Widenflycht  
 
 MediaStream API: Implement PeerConnection and SignalingCallback


Modified: trunk/Source/WebCore/DerivedSources.make (92307 => 92308)

--- trunk/Source/WebCore/DerivedSources.make	2011-08-03 20:13:59 UTC (rev 92307)
+++ trunk/Source/WebCore/DerivedSources.make	2011-08-03 20:15:53 UTC (rev 92308)
@@ -973,3 +973,16 @@
 # 
 
 endif # MACOS
+
+# 
+
+# Header detection
+
+ifeq ($(OS),Windows_NT)
+
+all : WebCoreHeaderDetection.h
+
+WebCoreHeaderDetection.h : DerivedSources.make
+	if [ -f "$(WEBKITLIBRARIESDIR)/include/AVFoundationCF/AVCFBase.h" ]; then echo "#define HAVE_AVCF 1" > $@; else echo > $@; fi
+
+endif # Windows_NT


Modified: trunk/Source/WebCore/config.h (92307 => 92308)

--- trunk/Source/WebCore/config.h	2011-08-03 20:13:59 UTC (rev 92307)
+++ trunk/Source/WebCore/config.h	2011-08-03 20:15:53 UTC (rev 92308)
@@ -29,6 +29,10 @@
 
 #include 
 
+#if OS(WINDOWS)
+#include 
+#endif
+
 /* See note in wtf/Platform.h for more info on EXPORT_MACROS. */
 #if USE(EXPORT_MACROS)
 
@@ -221,3 +225,7 @@
 #define WTF_USE_AVFOUNDATION 1
 #endif
 
+#if PLATFORM(WIN) && HAVE(AVCF)
+/// FIXME: Adopt AVCF media back end on Windows http://webkit.org/b/65400
+#define WTF_USE_AVFOUNDATION 0
+#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92210] trunk/Source

2011-08-02 Thread jeffm

Title: [92210] trunk/Source








Revision 92210
Author je...@apple.com
Date 2011-08-02 11:29:59 -0700 (Tue, 02 Aug 2011)


Log Message
Move WTF_USE_AVFOUNDATION from _javascript_Core/wtf/platform.h to WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=65552

Since this is a WebCore feature, there's no need to define it in _javascript_Core/wtf/platform.h.

Reviewed by Adam Roben.

Source/_javascript_Core: 

* wtf/Platform.h: Removed WTF_USE_AVFOUNDATION.

Source/WebCore: 

No change in functionality, so new tests.

* config.h: Added WTF_USE_AVFOUNDATION.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92209 => 92210)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-02 18:29:24 UTC (rev 92209)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-02 18:29:59 UTC (rev 92210)
@@ -1,3 +1,14 @@
+2011-08-02  Jeff Miller  
+
+Move WTF_USE_AVFOUNDATION from _javascript_Core/wtf/platform.h to WebCore/config.h
+https://bugs.webkit.org/show_bug.cgi?id=65552
+
+Since this is a WebCore feature, there's no need to define it in _javascript_Core/wtf/platform.h.
+
+Reviewed by Adam Roben.
+
+* wtf/Platform.h: Removed WTF_USE_AVFOUNDATION.
+
 2011-08-01  Jean-luc Brouillet  
 
 Removing old source files in gyp files that slow build


Modified: trunk/Source/_javascript_Core/wtf/Platform.h (92209 => 92210)

--- trunk/Source/_javascript_Core/wtf/Platform.h	2011-08-02 18:29:24 UTC (rev 92209)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2011-08-02 18:29:59 UTC (rev 92210)
@@ -1153,10 +1153,6 @@
 #define WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK 1
 #endif
 
-#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
-#define WTF_USE_AVFOUNDATION 1
-#endif
-
 #if COMPILER(GCC)
 #define WARN_UNUSED_RETURN __attribute__ ((warn_unused_result))
 #else


Modified: trunk/Source/WebCore/ChangeLog (92209 => 92210)

--- trunk/Source/WebCore/ChangeLog	2011-08-02 18:29:24 UTC (rev 92209)
+++ trunk/Source/WebCore/ChangeLog	2011-08-02 18:29:59 UTC (rev 92210)
@@ -1,3 +1,16 @@
+2011-08-02  Jeff Miller  
+
+Move WTF_USE_AVFOUNDATION from _javascript_Core/wtf/platform.h to WebCore/config.h
+https://bugs.webkit.org/show_bug.cgi?id=65552
+
+Since this is a WebCore feature, there's no need to define it in _javascript_Core/wtf/platform.h.
+
+Reviewed by Adam Roben.
+
+No change in functionality, so new tests.
+
+* config.h: Added WTF_USE_AVFOUNDATION.
+
 2011-08-02  Alexandru Chiculita  
 
 Split RenderBlock::layoutRunsAndFloats into multiple methods


Modified: trunk/Source/WebCore/config.h (92209 => 92210)

--- trunk/Source/WebCore/config.h	2011-08-02 18:29:24 UTC (rev 92209)
+++ trunk/Source/WebCore/config.h	2011-08-02 18:29:59 UTC (rev 92210)
@@ -203,7 +203,6 @@
 #endif
 #endif /* USE(CG) */
 
-
 #if PLATFORM(WIN) && USE(CG)
 #define WTF_USE_SAFARI_THEME 1
 #endif
@@ -218,3 +217,7 @@
 #include 
 #endif
 
+#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+#define WTF_USE_AVFOUNDATION 1
+#endif
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92128] trunk/Tools

2011-08-01 Thread jeffm

Title: [92128] trunk/Tools








Revision 92128
Author je...@apple.com
Date 2011-08-01 09:02:19 -0700 (Mon, 01 Aug 2011)


Log Message
Windows build fix after r92096.

* TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/win/InjectedBundleControllerWin.cpp
trunk/Tools/TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj




Diff

Modified: trunk/Tools/ChangeLog (92127 => 92128)

--- trunk/Tools/ChangeLog	2011-08-01 16:01:39 UTC (rev 92127)
+++ trunk/Tools/ChangeLog	2011-08-01 16:02:19 UTC (rev 92128)
@@ -1,3 +1,10 @@
+2011-08-01  Jeff Miller  
+
+Windows build fix after r92096.
+
+* TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
+* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
+
 2011-07-31  Anders Carlsson  
 
 DownloadDecideDestinationCrash WebKit2 API tests crashes


Modified: trunk/Tools/TestWebKitAPI/win/InjectedBundleControllerWin.cpp (92127 => 92128)

--- trunk/Tools/TestWebKitAPI/win/InjectedBundleControllerWin.cpp	2011-08-01 16:01:39 UTC (rev 92127)
+++ trunk/Tools/TestWebKitAPI/win/InjectedBundleControllerWin.cpp	2011-08-01 16:02:19 UTC (rev 92128)
@@ -23,10 +23,8 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#import "InjectedBundleController.h"
+#include "InjectedBundleController.h"
 
-#import 
-
 namespace TestWebKitAPI {
 
 void InjectedBundleController::platformInitialize()


Modified: trunk/Tools/TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj (92127 => 92128)

--- trunk/Tools/TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj	2011-08-01 16:01:39 UTC (rev 92127)
+++ trunk/Tools/TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj	2011-08-01 16:02:19 UTC (rev 92128)
@@ -389,6 +389,10 @@
 			Name="win"
 			>
 			+RelativePath=".\InjectedBundleControllerWin.cpp"
+>
+			
+			 RelativePath=".\PlatformUtilitiesWin.cpp"
 >
 			






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92035] trunk/Source/WebCore

2011-07-29 Thread jeffm

Title: [92035] trunk/Source/WebCore








Revision 92035
Author je...@apple.com
Date 2011-07-29 17:51:44 -0700 (Fri, 29 Jul 2011)


Log Message
Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400


Prepare WebCore.vcproj to support AVCF media back end on Windows.

Reviewed by Darin Adler.

No changes to functionality so no new tests.

* WebCore.vcproj/WebCore.vcproj: Added MediaPlayerPrivateAVFoundation and MediaPlayerPrivateAVFoundationCF sources.
* WebCore.vcproj/WebCoreMediaQT.vsprops: Added additional include directories and dleay load DLLs for AVCF.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added, just a stub for now.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added, just a stub for now.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops


Added Paths

trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92034 => 92035)

--- trunk/Source/WebCore/ChangeLog	2011-07-30 00:47:23 UTC (rev 92034)
+++ trunk/Source/WebCore/ChangeLog	2011-07-30 00:51:44 UTC (rev 92035)
@@ -4,6 +4,23 @@
 https://bugs.webkit.org/show_bug.cgi?id=65400
 
 
+Prepare WebCore.vcproj to support AVCF media back end on Windows.
+
+Reviewed by Darin Adler.
+
+No changes to functionality so no new tests.
+
+* WebCore.vcproj/WebCore.vcproj: Added MediaPlayerPrivateAVFoundation and MediaPlayerPrivateAVFoundationCF sources.
+* WebCore.vcproj/WebCoreMediaQT.vsprops: Added additional include directories and dleay load DLLs for AVCF.
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added, just a stub for now.
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added, just a stub for now.
+
+2011-07-29  Jeff Miller  
+
+Work-in-progress on Adopt AVCF media back end on Windows
+https://bugs.webkit.org/show_bug.cgi?id=65400
+
+
 Make MediaPlayerPrivateAVFoundation::setDelayCallbacks() const and make the ivars
 it references mutable so other const member functions can call it.
 


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (92034 => 92035)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-30 00:47:23 UTC (rev 92034)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-30 00:51:44 UTC (rev 92035)
@@ -30168,6 +30168,26 @@
 		
 	
 
+
+	
+	
+	
+	
+	
+	
+	
+	
+
 			
 			 Name="network"


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops (92034 => 92035)

--- trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops	2011-07-30 00:47:23 UTC (rev 92034)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCoreMediaQT.vsprops	2011-07-30 00:51:44 UTC (rev 92035)
@@ -4,4 +4,12 @@
 	Version="8.00"
 	Name="WebCoreMediaQT"
 	>
+	
+	
 


Added: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (0 => 92035)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-07-30 00:51:44 UTC (rev 92035)
@@ -0,0 +1,24 @@
+/*
+ * Copyright (C) 2011 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ */
Property changes on: trunk/Source/WebCore

[webkit-changes] [92034] trunk/Source/WebCore

2011-07-29 Thread jeffm

Title: [92034] trunk/Source/WebCore








Revision 92034
Author je...@apple.com
Date 2011-07-29 17:47:23 -0700 (Fri, 29 Jul 2011)


Log Message
Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400


Make MediaPlayerPrivateAVFoundation::setDelayCallbacks() const and make the ivars
it references mutable so other const member functions can call it.

Reviewed by Darin Adler.

No changes to functionality so no new tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92033 => 92034)

--- trunk/Source/WebCore/ChangeLog	2011-07-30 00:09:20 UTC (rev 92033)
+++ trunk/Source/WebCore/ChangeLog	2011-07-30 00:47:23 UTC (rev 92034)
@@ -1,3 +1,20 @@
+2011-07-29  Jeff Miller  
+
+Work-in-progress on Adopt AVCF media back end on Windows
+https://bugs.webkit.org/show_bug.cgi?id=65400
+
+
+Make MediaPlayerPrivateAVFoundation::setDelayCallbacks() const and make the ivars
+it references mutable so other const member functions can call it.
+
+Reviewed by Darin Adler.
+
+No changes to functionality so no new tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks):
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
+
 2011-07-29  Zhenyao Mo  
 
 Unreviewed, rolling out r92011.


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (92033 => 92034)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp	2011-07-30 00:09:20 UTC (rev 92033)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp	2011-07-30 00:47:23 UTC (rev 92034)
@@ -629,7 +629,7 @@
 setDelayCallbacks(false);
 }
 
-void MediaPlayerPrivateAVFoundation::setDelayCallbacks(bool delay)
+void MediaPlayerPrivateAVFoundation::setDelayCallbacks(bool delay) const
 {
 MutexLocker lock(m_queueMutex);
 if (delay)


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h (92033 => 92034)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h	2011-07-30 00:09:20 UTC (rev 92033)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h	2011-07-30 00:47:23 UTC (rev 92034)
@@ -215,7 +215,7 @@
 void setHasVideo(bool);
 void setHasAudio(bool);
 void setHasClosedCaptions(bool);
-void setDelayCallbacks(bool);
+void setDelayCallbacks(bool) const;
 void setIgnoreLoadStateChanges(bool delay) { m_ignoreLoadStateChanges = delay; }
 void setNaturalSize(IntSize);
 bool isLiveStream() const { return isinf(duration()); }
@@ -242,7 +242,7 @@
 MediaPlayer* m_player;
 
 Vector m_queuedNotifications;
-Mutex m_queueMutex;
+mutable Mutex m_queueMutex;
 
 mutable RefPtr m_cachedLoadedTimeRanges;
 
@@ -261,7 +261,7 @@
 
 float m_seekTo;
 float m_requestedRate;
-int m_delayCallbacks;
+mutable int m_delayCallbacks;
 bool m_mainThreadCallPending;
 bool m_assetIsPlayable;
 bool m_visible;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92008] trunk/Source/WebCore

2011-07-29 Thread jeffm

Title: [92008] trunk/Source/WebCore








Revision 92008
Author je...@apple.com
Date 2011-07-29 14:17:21 -0700 (Fri, 29 Jul 2011)


Log Message
Re-sort one more file in the WebCore project with Visual Studio.

* WebCore.vcproj/WebCore.vcproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (92007 => 92008)

--- trunk/Source/WebCore/ChangeLog	2011-07-29 21:14:44 UTC (rev 92007)
+++ trunk/Source/WebCore/ChangeLog	2011-07-29 21:17:21 UTC (rev 92008)
@@ -1,5 +1,11 @@
 2011-07-29  Jeff Miller  
 
+Re-sort one more file in the WebCore project with Visual Studio.
+
+* WebCore.vcproj/WebCore.vcproj:
+
+2011-07-29  Jeff Miller  
+
 Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
 
 * WebCore.vcproj/WebCore.vcproj:


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (92007 => 92008)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-29 21:14:44 UTC (rev 92007)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-29 21:17:21 UTC (rev 92008)
@@ -68625,11 +68625,11 @@
 	>
 
 -	RelativePath="..\inspector\front-end\_javascript_Formatter.js"
+	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
 	>
 
 -	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
+	RelativePath="..\inspector\front-end\_javascript_Formatter.js"
 	>
 
 





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92007] trunk/Source/WebCore

2011-07-29 Thread jeffm

Title: [92007] trunk/Source/WebCore








Revision 92007
Author je...@apple.com
Date 2011-07-29 14:14:44 -0700 (Fri, 29 Jul 2011)


Log Message
Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

* WebCore.vcproj/WebCore.vcproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (92006 => 92007)

--- trunk/Source/WebCore/ChangeLog	2011-07-29 21:04:57 UTC (rev 92006)
+++ trunk/Source/WebCore/ChangeLog	2011-07-29 21:14:44 UTC (rev 92007)
@@ -1,3 +1,9 @@
+2011-07-29  Jeff Miller  
+
+Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
+
+* WebCore.vcproj/WebCore.vcproj:
+
 2011-07-29  Dan Bernstein  
 
 Added the regional indicator symbols to the set of codepoints that force use of the complex text code path.


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (92006 => 92007)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-29 21:04:57 UTC (rev 92006)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-29 21:14:44 UTC (rev 92007)
@@ -29775,15 +29775,15 @@
 		RelativePath="..\platform\graphics\transforms\TransformOperations.h"
 		>
 	
-			
-			
-			
-			
 	+		RelativePath="..\platform\graphics\transforms\TransformState.cpp"
+		>
+	
+	
+	
+	 		RelativePath="..\platform\graphics\transforms\TranslateTransformOperation.cpp"
 		>
 	
@@ -32938,6 +32938,14 @@
 >
 			
 			+RelativePath="..\css\CSSWrapShapes.cpp"
+>
+			
+			
+			
+			 RelativePath="..\css\DashboardRegion.h"
 >
 			
@@ -33066,14 +33074,6 @@
 >
 			
 			-RelativePath="..\css\CSSWrapShapes.cpp"
->
-			
-			
-			
-			 RelativePath="..\css\StyleBase.cpp"
 >
 			
@@ -36366,11 +36366,11 @@
 >
 			
 			-RelativePath="..\rendering\RenderRegion.h"
+RelativePath="..\rendering\RenderRegion.cpp"
 >
 			
 			-RelativePath="..\rendering\RenderRegion.cpp"
+RelativePath="..\rendering\RenderRegion.h"
 >
 			
 			@@ -42629,6 +42629,22 @@
 Name="parser"
 >
 +	RelativePath="..\xml\parser\CharacterReferenceInlineMethods.h"
+	>
+
+
+
+
+
+
+
+ 	RelativePath="..\xml\parser\XMLDocumentParser.cpp"
 	>
 	@@ -42681,22 +42697,6 @@
 	
 
 -	RelativePath="..\xml\parser\CharacterReferenceInlineMethods.h"
-	>
-
-
-
-
-
-
-
- 	RelativePath="..\xml\parser\XMLDocumentParser.h"
 	>
 
@@ -42761,11 +42761,11 @@
 	>
 
 -	RelativePath="..\xml\parser\XMLTokenizer.h"
+	RelativePath="..\xml\parser\XMLToken.h"
 	>
 
 -	RelativePath="..\xml\parser\XMLToken.h"
+	RelativePath="..\xml\parser\XMLTokenizer.h"
 	>
 
 			
@@ -66190,6 +66190,10 @@
 >
 			
 			+RelativePath="..\svg\SVGGlyphMap.h"
+>
+			
+			 RelativePath="..\svg\SVGGlyphRefElement.cpp"
 >
 @@ -66246,10 +66250,6 @@
 >
 			
 			-RelativePath="..\svg\SVGGlyphMap.h"
->
-			
-			 RelativePath="..\svg\SVGGradientElement.h"
 >
 			
@@ -66933,14 +66933,6 @@
 Name="properties"
 >
 -	RelativePath="..\svg\properties\SVGAttributeToPropertyMap.cpp"
-	>
-
-
-
- 	RelativePath="..\svg\properties\SVGAnimatedEnumerationPropertyTearOff.h"
 	>
 
@@ -66981,6 +66973,14 @@
 	>
 
 +	RelativePath="..\svg\properties\SVGAttributeToPropertyMap.cpp"
+	>
+
+
+
+ 	RelativePath="..\svg\properties\SVGListProperty.h"
 	>
 
@@ -68002,6 +68002,14 @@
 >
 			
 			+RelativePath="..\inspector\IdentifiersFactory.cpp"
+>
+			
+			
+			
+			 RelativePath="..\inspector\InjectedScript.cpp"
 >
 			
@@ -68194,14 +68202,6 @@
 >
 			
 			-RelativePath="..\inspector\IdentifiersFactory.cpp"
->
-			
-			
-			
-			 RelativePath="..\inspector\InspectorResourceAgent.cpp"
 >
 			
@@ -68453,11 +68453,11 @@
 	>
 
 -	RelativePath="..\inspector\front-end\DataGrid.js"
+	RelativePath="..\inspector\front-end\dataGrid.css"
 	>
 
 -	RelativePath="..\inspector\front-end\dataGrid.css"
+	RelativePath="..\inspector\front-end\DataGrid.js"
 	>
 
 @@ -68621,22 +68621,18 @@
 	>
 
 -	RelativePath="..\inspector\front-end\networkLogView.css"
+	RelativePath="..\inspector\front-end\_javascript_ContextManager.js"
 	>
 
 -	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
+	RelativePath="..\inspector\front-end\_javascript_Formatter.js"
 	>
 
 -	RelativePath="..\inspector\front-end\_javascript_ContextManager.js"
+	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
 	>

[webkit-changes] [91088] trunk/Source/WebCore

2011-07-15 Thread jeffm

Title: [91088] trunk/Source/WebCore








Revision 91088
Author je...@apple.com
Date 2011-07-15 12:16:05 -0700 (Fri, 15 Jul 2011)


Log Message
Add UserAgentStyleSheetsData.cpp to WebCore.vcproj
https://bugs.webkit.org/show_bug.cgi?id=64609

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj for convenient access, but don't compile it.
This matches what we do with other generated DerivedSources.

Reviewed by Brian Weinstein.

No new tests, just adding a file.

* WebCore.vcproj/WebCore.vcproj: Add UserAgentStyleSheetsData.cpp.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (91087 => 91088)

--- trunk/Source/WebCore/ChangeLog	2011-07-15 19:15:49 UTC (rev 91087)
+++ trunk/Source/WebCore/ChangeLog	2011-07-15 19:16:05 UTC (rev 91088)
@@ -1,3 +1,17 @@
+2011-07-15  Jeff Miller  
+
+Add UserAgentStyleSheetsData.cpp to WebCore.vcproj
+https://bugs.webkit.org/show_bug.cgi?id=64609
+
+Add UserAgentStyleSheetsData.cpp to WebCore.vcproj for convenient access, but don't compile it.
+This matches what we do with other generated DerivedSources.
+
+Reviewed by Brian Weinstein.
+
+No new tests, just adding a file.
+
+* WebCore.vcproj/WebCore.vcproj: Add UserAgentStyleSheetsData.cpp.
+
 2011-07-15  Pratik Solanki  
 
 Part of https://bugs.webkit.org/show_bug.cgi?id=63674


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (91087 => 91088)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-15 19:15:49 UTC (rev 91087)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-07-15 19:16:05 UTC (rev 91088)
@@ -23738,6 +23738,58 @@
 >
 			
 			+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\UserAgentStyleSheetsData.cpp"
+>
+
+	
+
+
+	
+
+
+	
+
+
+	
+
+
+	
+
+
+	
+
+			
+			 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\XLinkNames.cpp"
 >
 			






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [91066] trunk

2011-07-15 Thread jeffm

Title: [91066] trunk








Revision 91066
Author je...@apple.com
Date 2011-07-15 07:02:17 -0700 (Fri, 15 Jul 2011)


Log Message
Fullscreen content doesn't use fullscreen controller on Windows
https://bugs.webkit.org/show_bug.cgi?id=64540


Source/WebCore: 

Reviewed by Darin Adler.

RenderThemeWin needs to override extraFullScreenStyleSheet() to return
the fullscreenQuickTime stylesheet.

Test added to fullscreen/video-controls-override.html.

* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::extraFullScreenStyleSheet): Added.
* rendering/RenderThemeWin.h: Override extraFullScreenStyleSheet().

LayoutTests: 

Reviewed by Darin Adler.

Add another test to video-controls-override.html to verify that
we're using the correct fullscreen controller by checking the
height of the controller panel, which is taller than the non-fullscreen
version. Unfortunately, the fullscreen tests don't work on Windows
yet, but I verified this would have caught this issue by simulating
the bug on the Mac.

* fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel.

* fullscreen/video-controls-override.html: Add new test to check the height of the panel, and
log errors if window.internals or window.layoutTestController are undefined.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fullscreen/video-controls-override-expected.txt
trunk/LayoutTests/fullscreen/video-controls-override.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeWin.cpp
trunk/Source/WebCore/rendering/RenderThemeWin.h




Diff

Modified: trunk/LayoutTests/ChangeLog (91065 => 91066)

--- trunk/LayoutTests/ChangeLog	2011-07-15 13:10:48 UTC (rev 91065)
+++ trunk/LayoutTests/ChangeLog	2011-07-15 14:02:17 UTC (rev 91066)
@@ -1,3 +1,23 @@
+2011-07-15  Jeff Miller  
+
+Fullscreen content doesn't use fullscreen controller on Windows
+https://bugs.webkit.org/show_bug.cgi?id=64540
+
+
+Reviewed by Darin Adler.
+
+Add another test to video-controls-override.html to verify that
+we're using the correct fullscreen controller by checking the
+height of the controller panel, which is taller than the non-fullscreen
+version. Unfortunately, the fullscreen tests don't work on Windows
+yet, but I verified this would have caught this issue by simulating
+the bug on the Mac.
+
+* fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel.
+
+* fullscreen/video-controls-override.html: Add new test to check the height of the panel, and
+log errors if window.internals or window.layoutTestController are undefined.
+
 2011-07-15  Mike West  
 
 Web Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compatibility.


Modified: trunk/LayoutTests/fullscreen/video-controls-override-expected.txt (91065 => 91066)

--- trunk/LayoutTests/fullscreen/video-controls-override-expected.txt	2011-07-15 13:10:48 UTC (rev 91065)
+++ trunk/LayoutTests/fullscreen/video-controls-override-expected.txt	2011-07-15 14:02:17 UTC (rev 91066)
@@ -5,6 +5,7 @@
 EXPECTED (panel = shadowRoot.firstChild.firstChild != 'null') OK
 EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
 EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
+EXPECTED (document.defaultView.getComputedStyle(panel)['height'] == '48px') OK
 EVENT(webkitfullscreenchange)
 EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK
 END OF TEST


Modified: trunk/LayoutTests/fullscreen/video-controls-override.html (91065 => 91066)

--- trunk/LayoutTests/fullscreen/video-controls-override.html	2011-07-15 13:10:48 UTC (rev 91065)
+++ trunk/LayoutTests/fullscreen/video-controls-override.html	2011-07-15 14:02:17 UTC (rev 91066)
@@ -22,7 +22,11 @@
 testExpected("panel = shadowRoot.firstChild.firstChild", null, "!=");
 testExpected("internals.shadowPseudoId(panel)", "-webkit-media-controls-panel");
 testExpected("document.defaultView.getComputedStyle(panel)['display']", 'none', "!=");
+testExpected("document.defaultView.getComputedStyle(panel)['height']", '48px');
 }
+else
+logResult(false, "window.internals == undefined");
+
 callback = cancelledFullScreen;
 document.webkitCancelFullScreen();
 };
@@ -30,6 +34,9 @@
 var cancelledFullScreen = function() {
 if (window.layoutTestController)
 testExpected("document.defaultView.getComputedStyle(panel)['display']", 'none');
+else
+logResult(false, "window.layoutTestController == undefined");
+
 endTest();
 };
 


Modified: trunk/Source/WebCore/ChangeLog (91065 => 91066)

--- trunk/Source/WebCore/ChangeLog	2011-07-15 13:10:48 UTC (rev 91065

[webkit-changes] [90457] trunk/Source/WebKit2

2011-07-06 Thread jeffm

Title: [90457] trunk/Source/WebKit2








Revision 90457
Author je...@apple.com
Date 2011-07-06 07:24:08 -0700 (Wed, 06 Jul 2011)


Log Message
Add WKPageCopyStandardUserAgentWithApplicationName
https://bugs.webkit.org/show_bug.cgi?id=63953

Reviewed by Adam Roben.

 * UIProcess/API/C/WKPage.cpp:
(WKPageCopyStandardUserAgentWithApplicationName): Added.
* UIProcess/API/C/WKPagePrivate.h: Added WKPageCopyStandardUserAgentWithApplicationName().

* UIProcess/WebPageProxy.h: Make standardUserAgent() public.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (90456 => 90457)

--- trunk/Source/WebKit2/ChangeLog	2011-07-06 13:45:35 UTC (rev 90456)
+++ trunk/Source/WebKit2/ChangeLog	2011-07-06 14:24:08 UTC (rev 90457)
@@ -1,3 +1,16 @@
+2011-07-05  Jeff Miller  
+
+Add WKPageCopyStandardUserAgentWithApplicationName
+https://bugs.webkit.org/show_bug.cgi?id=63953
+
+Reviewed by Adam Roben.
+
+ * UIProcess/API/C/WKPage.cpp:
+(WKPageCopyStandardUserAgentWithApplicationName): Added.
+* UIProcess/API/C/WKPagePrivate.h: Added WKPageCopyStandardUserAgentWithApplicationName().
+
+* UIProcess/WebPageProxy.h: Make standardUserAgent() public.
+
 2011-07-05  Vsevolod Vlasov  
 
 Web Inspector: Show content for plugin requests in network panel.


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (90456 => 90457)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2011-07-06 13:45:35 UTC (rev 90456)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp	2011-07-06 14:24:08 UTC (rev 90457)
@@ -502,6 +502,11 @@
 return WebPageProxy::debugPaintFlags();
 }
 
+WKStringRef WKPageCopyStandardUserAgentWithApplicationName(WKStringRef applicationName)
+{
+return toCopiedAPI(WebPageProxy::standardUserAgent(toImpl(applicationName)->string()));
+}
+
 void WKPageValidateCommand(WKPageRef pageRef, WKStringRef command, void* context, WKPageValidateCommandCallback callback)
 {
 toImpl(pageRef)->validateCommand(toImpl(command)->string(), ValidateCommandCallback::create(context, callback)); 


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h (90456 => 90457)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h	2011-07-06 13:45:35 UTC (rev 90456)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h	2011-07-06 14:24:08 UTC (rev 90457)
@@ -50,6 +50,8 @@
 WK_EXPORT void WKPageSetDebugPaintFlags(WKPageDebugPaintFlags flags);
 WK_EXPORT WKPageDebugPaintFlags WKPageGetDebugPaintFlags(void);
 
+WK_EXPORT WKStringRef WKPageCopyStandardUserAgentWithApplicationName(WKStringRef);
+
 struct WKPrintInfo {
 float pageSetupScaleFactor;
 float availablePaperWidth;


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (90456 => 90457)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2011-07-06 13:45:35 UTC (rev 90456)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2011-07-06 14:24:08 UTC (rev 90457)
@@ -346,6 +346,7 @@
 const String& applicationNameForUserAgent() const { return m_applicationNameForUserAgent; }
 void setCustomUserAgent(const String&);
 const String& customUserAgent() const { return m_customUserAgent; }
+static String standardUserAgent(const String& applicationName = String());
 
 bool supportsTextEncoding() const;
 void setCustomTextEncodingName(const String&);
@@ -743,8 +744,6 @@
 void setComplexTextInputEnabled(uint64_t pluginComplexTextInputIdentifier, bool complexTextInputEnabled);
 #endif
 
-static String standardUserAgent(const String& applicationName = String());
-
 void clearPendingAPIRequestURL() { m_pendingAPIRequestURL = String(); }
 void setPendingAPIRequestURL(const String& pendingAPIRequestURL) { m_pendingAPIRequestURL = pendingAPIRequestURL; }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [89942] trunk/Source/WebCore

2011-06-28 Thread jeffm

Title: [89942] trunk/Source/WebCore








Revision 89942
Author je...@apple.com
Date 2011-06-28 11:24:06 -0700 (Tue, 28 Jun 2011)


Log Message
Add fullscreen.css and fullscreenQuickTime.css to the WebCore Visual Studio project for convenience.
Looks like Visual Studio also re-sorted one more file since my last checkin.

* WebCore.vcproj/WebCore.vcproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (89941 => 89942)

--- trunk/Source/WebCore/ChangeLog	2011-06-28 18:21:15 UTC (rev 89941)
+++ trunk/Source/WebCore/ChangeLog	2011-06-28 18:24:06 UTC (rev 89942)
@@ -1,5 +1,12 @@
 2011-06-28  Jeff Miller  
 
+Add fullscreen.css and fullscreenQuickTime.css to the WebCore Visual Studio project for convenience.
+Looks like Visual Studio also re-sorted one more file since my last checkin.
+
+* WebCore.vcproj/WebCore.vcproj:
+
+2011-06-28  Jeff Miller  
+
 Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
 
 * WebCore.vcproj/WebCore.vcproj:


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (89941 => 89942)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-06-28 18:21:15 UTC (rev 89941)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-06-28 18:24:06 UTC (rev 89942)
@@ -32790,6 +32790,14 @@
 >
 			
 			+RelativePath="..\css\fullscreen.css"
+>
+			
+			
+			
+			 RelativePath="..\css\html.css"
 >
 			
@@ -68113,11 +68121,11 @@
 	>
 
 -	RelativePath="..\inspector\front-end\_javascript_Formatter.js"
+	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
 	>
 
 -	RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
+	RelativePath="..\inspector\front-end\_javascript_Formatter.js"
 	>
 
 





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [89941] trunk/Source/WebCore

2011-06-28 Thread jeffm

Title: [89941] trunk/Source/WebCore








Revision 89941
Author je...@apple.com
Date 2011-06-28 11:21:15 -0700 (Tue, 28 Jun 2011)


Log Message
Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

* WebCore.vcproj/WebCore.vcproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (89940 => 89941)

--- trunk/Source/WebCore/ChangeLog	2011-06-28 17:55:38 UTC (rev 89940)
+++ trunk/Source/WebCore/ChangeLog	2011-06-28 18:21:15 UTC (rev 89941)
@@ -1,3 +1,9 @@
+2011-06-28  Jeff Miller  
+
+Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
+
+* WebCore.vcproj/WebCore.vcproj:
+
 2011-06-28  Joone Hur  
 
 Reviewed by Martin Robinson.


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (89940 => 89941)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-06-28 17:55:38 UTC (rev 89940)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-06-28 18:21:15 UTC (rev 89941)
@@ -10902,7 +10902,7 @@
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStream.cpp"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaQueryList.cpp"
 >
  	Name="Debug|Win32"
@@ -10952,13 +10952,37 @@
 		Name="VCCLCompilerTool"
 	/>
 
+
+	
+
+
+	
+
+
+	
+
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStream.h"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaQueryList.h"
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStreamList.cpp"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStream.cpp"
 >
  	Name="Debug|Win32"
@@ -11010,11 +11034,11 @@
 
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStreamList.h"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStream.h"
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaQueryList.cpp"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStreamList.cpp"
 >
  	Name="Debug|Win32"
@@ -11064,33 +11088,9 @@
 		Name="VCCLCompilerTool"
 	/>
 
-
-	
-
-
-	
-
-
-	
-
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaQueryList.h"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSMediaStreamList.h"
 >
 			
 			@@ -18150,7 +18150,7 @@
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMPathElement.cpp"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMarkerElement.cpp"
 >
  	Name="Debug|Win32"
@@ -18202,11 +18202,11 @@
 
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMPathElement.h"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMarkerElement.h"
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMarkerElement.cpp"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMaskElement.cpp"
 >
  	Name="Debug|Win32"
@@ -18258,11 +18258,11 @@
 
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMarkerElement.h"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMaskElement.h"
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMaskElement.cpp"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMatrix.cpp"
 >
  	Name="Debug|Win32"
@@ -18314,11 +18314,11 @@
 
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMaskElement.h"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMatrix.h"
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMatrix.cpp"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMetadataElement.cpp"
 >
  	Name="Debug|Win32"
@@ -18370,11 +18370,11 @@
 
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMatrix.h"
+RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMetadataElement.h"
 >
 			
 			-RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMetadataElement.cpp"
+RelativePath="$(ConfigurationBuildDir

[webkit-changes] [89867] trunk/Source/WebKit2/ChangeLog

2011-06-27 Thread jeffm

Title: [89867] trunk/Source/WebKit2/ChangeLog








Revision 89867
Author je...@apple.com
Date 2011-06-27 15:15:25 -0700 (Mon, 27 Jun 2011)


Log Message
Really fix the revision number in the last entry

Modified Paths

trunk/Source/WebKit2/ChangeLog




Diff

Modified: trunk/Source/WebKit2/ChangeLog (89866 => 89867)

--- trunk/Source/WebKit2/ChangeLog	2011-06-27 22:14:39 UTC (rev 89866)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-27 22:15:25 UTC (rev 89867)
@@ -6,7 +6,7 @@
 https://bugs.webkit.org/show_bug.cgi?id=63487
 
 In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
-launch if the shift, control, and alt keys are all held down. This regressed in r89855, which always caused the
+launch if the shift, control, and alt keys are all held down. This regressed in r89685, which always caused the
 web process to pause if the shift and alt keys were not held down.
 
 * WebProcess/WebKitMain.cpp:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [89866] trunk/Source/WebKit2/ChangeLog

2011-06-27 Thread jeffm

Title: [89866] trunk/Source/WebKit2/ChangeLog








Revision 89866
Author je...@apple.com
Date 2011-06-27 15:14:39 -0700 (Mon, 27 Jun 2011)


Log Message
Fix revision number that I referenced in my last checkin

Modified Paths

trunk/Source/WebKit2/ChangeLog




Diff

Modified: trunk/Source/WebKit2/ChangeLog (89865 => 89866)

--- trunk/Source/WebKit2/ChangeLog	2011-06-27 22:11:19 UTC (rev 89865)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-27 22:14:39 UTC (rev 89866)
@@ -6,7 +6,7 @@
 https://bugs.webkit.org/show_bug.cgi?id=63487
 
 In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
-launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
+launch if the shift, control, and alt keys are all held down. This regressed in r89855, which always caused the
 web process to pause if the shift and alt keys were not held down.
 
 * WebProcess/WebKitMain.cpp:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [89865] trunk/Source/WebKit2

2011-06-27 Thread jeffm

Title: [89865] trunk/Source/WebKit2








Revision 89865
Author je...@apple.com
Date 2011-06-27 15:11:19 -0700 (Mon, 27 Jun 2011)


Log Message
Web process always pauses on launch
https://bugs.webkit.org/show_bug.cgi?id=63487

Reviewed by Oliver Hunt.

In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
web process to pause if the shift and alt keys were not held down.

* WebProcess/WebKitMain.cpp:
(pauseProcessIfNeeded): Add some parentheses.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebKitMain.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (89864 => 89865)

--- trunk/Source/WebKit2/ChangeLog	2011-06-27 22:01:38 UTC (rev 89864)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-27 22:11:19 UTC (rev 89865)
@@ -1,3 +1,17 @@
+2011-06-27  Jeff Miller  
+
+Reviewed by Oliver Hunt.
+
+Web process always pauses on launch
+https://bugs.webkit.org/show_bug.cgi?id=63487
+
+In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
+launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
+web process to pause if the shift and alt keys were not held down.
+
+* WebProcess/WebKitMain.cpp:
+(pauseProcessIfNeeded): Add some parentheses.
+
 2011-06-27  Huang Dongsung  
 
 Reviewed by Kenneth Rohde Christiansen.


Modified: trunk/Source/WebKit2/WebProcess/WebKitMain.cpp (89864 => 89865)

--- trunk/Source/WebKit2/WebProcess/WebKitMain.cpp	2011-06-27 22:01:38 UTC (rev 89864)
+++ trunk/Source/WebKit2/WebProcess/WebKitMain.cpp	2011-06-27 22:11:19 UTC (rev 89865)
@@ -150,7 +150,7 @@
 // Show an alert when Ctrl-Alt-Shift is held down during launch to give the user time to attach a
 // debugger. This is useful for debugging problems that happen early in the web process's lifetime.
 const unsigned short highBitMaskShort = 0x8000;
-if (!getenv("WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH") && !(::GetKeyState(VK_CONTROL) & highBitMaskShort) && (::GetKeyState(VK_MENU) & highBitMaskShort) && (::GetKeyState(VK_SHIFT) & highBitMaskShort))
+if (!getenv("WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH") && !((::GetKeyState(VK_CONTROL) & highBitMaskShort) && (::GetKeyState(VK_MENU) & highBitMaskShort) && (::GetKeyState(VK_SHIFT) & highBitMaskShort)))
 return;
 
 wchar_t path[MAX_PATH];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [89847] trunk/Tools

2011-06-27 Thread jeffm

Title: [89847] trunk/Tools








Revision 89847
Author je...@apple.com
Date 2011-06-27 13:18:54 -0700 (Mon, 27 Jun 2011)


Log Message
2011-06-27  Jeff Miller  

Reviewed by Adam Roben.

Stop copying obsolete WebKit libraries on Windows
https://bugs.webkit.org/show_bug.cgi?id=63474

Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.

* DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
* MiniBrowser/MiniBrowserPostBuild.cmd:
* WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/DumpRenderTreePostBuild.cmd
trunk/Tools/MiniBrowser/MiniBrowserPostBuild.cmd
trunk/Tools/WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd




Diff

Modified: trunk/Tools/ChangeLog (89846 => 89847)

--- trunk/Tools/ChangeLog	2011-06-27 20:14:12 UTC (rev 89846)
+++ trunk/Tools/ChangeLog	2011-06-27 20:18:54 UTC (rev 89847)
@@ -1,3 +1,16 @@
+2011-06-27  Jeff Miller  
+
+Reviewed by Adam Roben.
+
+Stop copying obsolete WebKit libraries on Windows
+https://bugs.webkit.org/show_bug.cgi?id=63474
+
+Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
+
+* DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
+* MiniBrowser/MiniBrowserPostBuild.cmd:
+* WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
+
 2011-06-27  Ryosuke Niwa  
 
 Add Wyatt Carss to the list of non-committer contributors.


Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTreePostBuild.cmd (89846 => 89847)

--- trunk/Tools/DumpRenderTree/win/DumpRenderTreePostBuild.cmd	2011-06-27 20:14:12 UTC (rev 89846)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTreePostBuild.cmd	2011-06-27 20:18:54 UTC (rev 89847)
@@ -14,10 +14,8 @@
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\CFNetwork%LIBRARYCONFIGSUFFIX%.pdb" "%CONFIGURATIONBUILDDIR%\bin"
 xcopy /y /d /e /i "%WEBKITLIBRARIESDIR%\bin\CFNetwork.resources" "%CONFIGURATIONBUILDDIR%\bin\CFNetwork.resources"
 xcopy /y /d /e /i "%WEBKITLIBRARIESDIR%\bin\CoreFoundation.resources" "%CONFIGURATIONBUILDDIR%\bin\CoreFoundation.resources"
-xcopy /y /d /e /i "%WEBKITLIBRARIESDIR%\bin\CharacterSets" "%CONFIGURATIONBUILDDIR%\bin\CharacterSets"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\CoreGraphics%LIBRARYCONFIGSUFFIX%.dll" "%CONFIGURATIONBUILDDIR%\bin"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\CoreGraphics%LIBRARYCONFIGSUFFIX%.pdb" "%CONFIGURATIONBUILDDIR%\bin"
-xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\dnssd.dll" "%CONFIGURATIONBUILDDIR%\bin"
 if exist "%WEBKITLIBRARIESDIR%\bin\icudt40.dll" xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icudt40.dll" "%CONFIGURATIONBUILDDIR%\bin"
 if exist "%WEBKITLIBRARIESDIR%\bin\icudt40%LIBRARYCONFIGSUFFIX%.dll"xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icudt40%LIBRARYCONFIGSUFFIX%.dll" "%CONFIGURATIONBUILDDIR%\bin"
 if exist "%WEBKITLIBRARIESDIR%\bin\icuin40%LIBRARYCONFIGSUFFIX%.dll"xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icuin40%LIBRARYCONFIGSUFFIX%.dll" "%CONFIGURATIONBUILDDIR%\bin"


Modified: trunk/Tools/MiniBrowser/MiniBrowserPostBuild.cmd (89846 => 89847)

--- trunk/Tools/MiniBrowser/MiniBrowserPostBuild.cmd	2011-06-27 20:14:12 UTC (rev 89846)
+++ trunk/Tools/MiniBrowser/MiniBrowserPostBuild.cmd	2011-06-27 20:18:54 UTC (rev 89847)
@@ -6,12 +6,8 @@
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\CFNetwork%LIBRARYCONFIGSUFFIX%.pdb" "%CONFIGURATIONBUILDDIR%\bin"
 xcopy /y /d /e /i "%WEBKITLIBRARIESDIR%\bin\CFNetwork.resources" "%CONFIGURATIONBUILDDIR%\bin\CFNetwork.resources"
 xcopy /y /d /e /i "%WEBKITLIBRARIESDIR%\bin\CoreFoundation.resources" "%CONFIGURATIONBUILDDIR%\bin\CoreFoundation.resources"
-xcopy /y /d /e /i "%WEBKITLIBRARIESDIR%\bin\CharacterSets" "%CONFIGURATIONBUILDDIR%\bin\CharacterSets"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\CoreGraphics%LIBRARYCONFIGSUFFIX%.dll" "%CONFIGURATIONBUILDDIR%\bin"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\CoreGraphics%LIBRARYCONFIGSUFFIX%.pdb" "%CONFIGURATIONBUILDDIR%\bin"
-xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\dnssd.dll" "%CONFIGURATIONBUILDDIR%\bin"
-xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icudt40.dll" "%CONFIGURATIONBUILDDIR%\bin"
-xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icudt40%LIBRARYCONFIGSUFFIX%.dll" "%CONFIGURATIONBUILDDIR%\bin"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icuin40%LIBRARYCONFIGSUFFIX%.dll" "%CONFIGURATIONBUILDDIR%\bin"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icuin40%LIBRARYCONFIGSUFFIX%.pdb" "%CONFIGURATIONBUILDDIR%\bin"
 xcopy /y /d "%WEBKITLIBRARIESDIR%\bin\icuuc40%LIBRARYCONFIGSUFFIX%.dll" "%CONFIGURATIONBUILDDIR%\bin"


Modified: trunk/Tools/WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd (89846 => 89847)

--- trunk/Tools/WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd	2011-06-27 20:14:12 UTC

[webkit-changes] [87544] trunk/Source/WebKit2

2011-05-27 Thread jeffm

Title: [87544] trunk/Source/WebKit2








Revision 87544
Author je...@apple.com
Date 2011-05-27 13:22:46 -0700 (Fri, 27 May 2011)


Log Message

Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
This patch is actually by Timothy Hatcher, I'm just landing it for him.

Rubber-stamped by Steve Falkenburg.

* WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb




Diff

Modified: trunk/Source/WebKit2/ChangeLog (87543 => 87544)

--- trunk/Source/WebKit2/ChangeLog	2011-05-27 20:21:20 UTC (rev 87543)
+++ trunk/Source/WebKit2/ChangeLog	2011-05-27 20:22:46 UTC (rev 87544)
@@ -1,3 +1,13 @@
+2011-05-27  Jeff Miller  
+
+Rubber-stamped by Steve Falkenburg.
+
+
+Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
+This patch is actually by Timothy Hatcher, I'm just landing it for him.
+
+* WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).
+
 2011-05-27  Stephanie Lewis  
 
 Rubber Stamped by Adam Roben.


Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb (87543 => 87544)

--- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb	2011-05-27 20:21:20 UTC (rev 87543)
+++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb	2011-05-27 20:22:46 UTC (rev 87544)
@@ -18,6 +18,9 @@
 (define (home-literal home-relative-literal)
   (literal (string-append (param "HOME_DIR") home-relative-literal)))
 
+;; Needed only for loading the user stylesheet at this time
+(allow file-issue-extension*)
+
 ;; Read-only preferences and data
 (allow file-read*
;; Basic system paths






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87509] trunk/Source/WebKit2

2011-05-27 Thread jeffm

Title: [87509] trunk/Source/WebKit2








Revision 87509
Author je...@apple.com
Date 2011-05-27 07:19:07 -0700 (Fri, 27 May 2011)


Log Message
2011-05-26  Jeff Miller  

Reviewed by Alexey Proskuryakov.

Add a key handling logging channel for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61588

Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.

* Platform/Logging.cpp:
(WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
* Platform/Logging.h: Added LogKeyHandling channel.

* UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment.
(WebKit::webKeyboardEventTypeString): Added to support logging.
(WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event.
(WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/Logging.cpp
trunk/Source/WebKit2/Platform/Logging.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (87508 => 87509)

--- trunk/Source/WebKit2/ChangeLog	2011-05-27 14:02:26 UTC (rev 87508)
+++ trunk/Source/WebKit2/ChangeLog	2011-05-27 14:19:07 UTC (rev 87509)
@@ -1,3 +1,22 @@
+2011-05-26  Jeff Miller  
+
+Reviewed by Alexey Proskuryakov.
+
+Add a key handling logging channel for WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=61588
+
+Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
+I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.
+
+* Platform/Logging.cpp:
+(WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
+* Platform/Logging.h: Added LogKeyHandling channel.
+
+* UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment.
+(WebKit::webKeyboardEventTypeString): Added to support logging.
+(WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event.
+(WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.
+
 2011-05-26  Chris Fleizach  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebKit2/Platform/Logging.cpp (87508 => 87509)

--- trunk/Source/WebKit2/Platform/Logging.cpp	2011-05-27 14:02:26 UTC (rev 87508)
+++ trunk/Source/WebKit2/Platform/Logging.cpp	2011-05-27 14:19:07 UTC (rev 87509)
@@ -35,6 +35,7 @@
 WTFLogChannel LogTextInput= { 0x0004, "WebKit2LogLevel", WTFLogChannelOff };
 WTFLogChannel LogView = { 0x0008, "WebKit2LogLevel", WTFLogChannelOff };
 WTFLogChannel LogIconDatabase = { 0x0010, "WebKit2LogLevel", WTFLogChannelOff };
+WTFLogChannel LogKeyHandling  = { 0x0020, "WebKit2LogLevel", WTFLogChannelOff };
 
 #if !PLATFORM(MAC)
 void initializeLogChannel(WTFLogChannel* channel)
@@ -52,6 +53,7 @@
 
 initializeLogChannel(&LogContextMenu);
 initializeLogChannel(&LogIconDatabase);
+initializeLogChannel(&LogKeyHandling);
 initializeLogChannel(&LogSessionState);
 initializeLogChannel(&LogTextInput);
 initializeLogChannel(&LogView);


Modified: trunk/Source/WebKit2/Platform/Logging.h (87508 => 87509)

--- trunk/Source/WebKit2/Platform/Logging.h	2011-05-27 14:02:26 UTC (rev 87508)
+++ trunk/Source/WebKit2/Platform/Logging.h	2011-05-27 14:19:07 UTC (rev 87509)
@@ -38,6 +38,7 @@
 
 extern WTFLogChannel LogContextMenu;
 extern WTFLogChannel LogIconDatabase;
+extern WTFLogChannel LogKeyHandling;
 extern WTFLogChannel LogSessionState;
 extern WTFLogChannel LogTextInput;
 extern WTFLogChannel LogView;


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (87508 => 87509)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-05-27 14:02:26 UTC (rev 87508)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-05-27 14:19:07 UTC (rev 87509)
@@ -32,6 +32,7 @@
 #include "DownloadProxy.h"
 #include "DrawingAreaProxy.h"
 #include "FindIndicator.h"
+#include "Logging.h"
 #include "MessageID.h"
 #include "NativeWebKeyboardEvent.h"
 #include "NativeWebMouseEvent.h"
@@ -90,7 +91,7 @@
 #include 
 #endif
 
-// This controls what strategy we use for mouse wheel coalesing.
+// This controls what strategy we use for mouse wheel coalescing.
 #define MERGE_WHEEL_EVENTS 1
 
 #define MESSAGE_CHECK(assertion) MESSAGE_CHECK_BASE(assertion, process()->connection())
@@ -105,6 +106,29 @@
 static WTF::RefCountedLeakCounter webPageProxyCounter("WebPageProxy");
 #endif
 
+#if !LOG_DISABLED
+static const char* webKeyboardEventTypeString(WebEvent::Type type)
+{
+switch (type) {
+case WebEvent::KeyDown:
+return "KeyDown";
+
+case WebEvent::KeyUp:
+return "KeyUp";
+
+case WebEvent::RawKeyDown:
+return "RawKeyDown";
+
+case WebEvent::Char:
+return "Char";
+
+default:
+AS

[webkit-changes] [87442] trunk/Source/WebCore

2011-05-26 Thread jeffm

Title: [87442] trunk/Source/WebCore








Revision 87442
Author je...@apple.com
Date 2011-05-26 15:43:51 -0700 (Thu, 26 May 2011)


Log Message
Fullscreen content is sometimes obscured by taskbar (which even covers up the "exit fullscreen" button)
https://bugs.webkit.org/show_bug.cgi?id=61569


Reviewed by Steve Falkenburg.

Normally, when the background fullscreen window is animated in, the Windows taskbar will be hidden, but this doesn't always work for some reason.
Workaround this issue by setting the real fullscreen window to be a topmost window.

* platform/graphics/win/FullScreenController.cpp:
(FullScreenController::Private::fullscreenClientWndProc): Exit fullscreen when m_fullScreenWindow is deactivated.
(FullScreenController::enterFullScreenRepaintCompleted): Make m_fullScreenWindow a topmost window before animating it in to ensure the taskbar is hidden.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87441 => 87442)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 22:43:07 UTC (rev 87441)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 22:43:51 UTC (rev 87442)
@@ -1,3 +1,18 @@
+2011-05-26  Jeff Miller  
+
+Reviewed by Steve Falkenburg.
+
+Fullscreen content is sometimes obscured by taskbar (which even covers up the "exit fullscreen" button)
+https://bugs.webkit.org/show_bug.cgi?id=61569
+
+
+Normally, when the background fullscreen window is animated in, the Windows taskbar will be hidden, but this doesn't always work for some reason.
+Workaround this issue by setting the real fullscreen window to be a topmost window.
+
+* platform/graphics/win/FullScreenController.cpp:
+(FullScreenController::Private::fullscreenClientWndProc): Exit fullscreen when m_fullScreenWindow is deactivated.
+(FullScreenController::enterFullScreenRepaintCompleted): Make m_fullScreenWindow a topmost window before animating it in to ensure the taskbar is hidden.
+
 2011-05-26  James Robinson  
 
 Reviewed by Darin Fisher.


Modified: trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp (87441 => 87442)

--- trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp	2011-05-26 22:43:07 UTC (rev 87441)
+++ trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp	2011-05-26 22:43:51 UTC (rev 87442)
@@ -84,6 +84,11 @@
 if (m_client->fullScreenClientWindow())
 ::SetWindowPos(m_client->fullScreenClientWindow(), 0, 0, 0, m_fullScreenFrame.width(), m_fullScreenFrame.height(), SWP_NOREPOSITION  | SWP_NOMOVE);
 break;
+case WM_ACTIVATE:
+// Because m_fullScreenWindow is a topmost window, we need to exit full screen explicitly when it's deactivated.
+if (!wParam && m_fullScreenWindow && (hwnd == m_fullScreenWindow->hwnd()))
+m_controller->exitFullScreen();
+break;
 case WM_KEYDOWN:
 if (wParam == VK_ESCAPE) {
 m_controller->exitFullScreen();
@@ -152,6 +157,9 @@
 return;
 m_private->m_isEnteringFullScreen = false;
 
+// Normally, when the background fullscreen window is animated in, the Windows taskbar will be hidden, but this doesn't always work for some reason.
+// Setting the real fullscreen window to be a topmost window will force the taskbar to be hidden when we call AnimateWindow() below if it wasn't before.
+::SetWindowPos(m_private->m_fullScreenWindow->hwnd(), HWND_TOPMOST, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE);
 ::AnimateWindow(m_private->m_fullScreenWindow->hwnd(), kFullScreenAnimationDuration, AW_BLEND | AW_ACTIVATE);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87031] trunk/Source/WebKit2

2011-05-22 Thread jeffm

Title: [87031] trunk/Source/WebKit2








Revision 87031
Author je...@apple.com
Date 2011-05-22 09:48:35 -0700 (Sun, 22 May 2011)


Log Message
2011-05-22  Jeff Miller  

Reviewed by Darin Adler.

Don't call WebKit::initializeLogChannelsIfNecessary if logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61249

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Check #if !LOG_DISABLED, not #ifndef NDEBUG, to decide whether to call WebKit::initializeLogChannelsIfNecessary().

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (87030 => 87031)

--- trunk/Source/WebKit2/ChangeLog	2011-05-22 16:27:50 UTC (rev 87030)
+++ trunk/Source/WebKit2/ChangeLog	2011-05-22 16:48:35 UTC (rev 87031)
@@ -1,3 +1,13 @@
+2011-05-22  Jeff Miller  
+
+Reviewed by Darin Adler.
+
+Don't call WebKit::initializeLogChannelsIfNecessary if logging is disabled
+https://bugs.webkit.org/show_bug.cgi?id=61249
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::WebContext): Check #if !LOG_DISABLED, not #ifndef NDEBUG, to decide whether to call WebKit::initializeLogChannelsIfNecessary().
+
 2011-05-21  Nancy Piedra  
 
 Reviewed by Andreas Kling.


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (87030 => 87031)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-05-22 16:27:50 UTC (rev 87030)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-05-22 16:48:35 UTC (rev 87031)
@@ -129,7 +129,7 @@
 #endif
 , m_processTerminationEnabled(true)
 {
-#ifndef NDEBUG
+#if !LOG_DISABLED
 WebKit::initializeLogChannelsIfNecessary();
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

80 matches

Mail list logo