[webkit-changes] [138374] trunk

[mihaip]

Title: [138374] trunk








Revision 138374
Author mih...@chromium.org
Date 2012-12-21 07:30:23 -0800 (Fri, 21 Dec 2012)


Log Message
Slow performance with select with many options and size = 2
https://bugs.webkit.org/show_bug.cgi?id=105483

Source/WebCore:

Reviewed by Eric Seidel.

Avoids creating renderers for children of list selects that are not
option or optgroup. This is both more correct (no other browser
displays them) and provides a performance benefit (direct text children
of select would have O(N^2) behavior; this usually happened due to
whitespace between option.../option tags).

Test: fast/forms/menulist-no-renderer-for-unexpected-children.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):

LayoutTests:

Reviewed by Eric Seidel.

Test that checks that text and non-option and optgroup element
children of select do not get a renderer.

* fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt: Added.
* fast/forms/menulist-no-renderer-for-unexpected-children.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSelectElement.cpp


Added Paths

trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt
trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children.html




Diff

Modified: trunk/LayoutTests/ChangeLog (138373 => 138374)

--- trunk/LayoutTests/ChangeLog	2012-12-21 15:28:42 UTC (rev 138373)
+++ trunk/LayoutTests/ChangeLog	2012-12-21 15:30:23 UTC (rev 138374)
@@ -1,3 +1,16 @@
+2012-12-21  Mihai Parparita  mih...@chromium.org
+
+Slow performance with select with many options and size = 2
+https://bugs.webkit.org/show_bug.cgi?id=105483
+
+Reviewed by Eric Seidel.
+
+Test that checks that text and non-option and optgroup element 
+children of select do not get a renderer.
+
+* fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt: Added.
+* fast/forms/menulist-no-renderer-for-unexpected-children.html: Added.
+
 2012-12-21  Sudarsana Nagineni  sudarsana.nagin...@intel.com
 
 Unreviewed EFL gardening.


Added: trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt (0 => 138374)

--- trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt	2012-12-21 15:30:23 UTC (rev 138374)
@@ -0,0 +1,10 @@
+Check that a select control does not render children that are not option or optgroup.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS select.innerText is 
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children.html (0 => 138374)

--- trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/menulist-no-renderer-for-unexpected-children.html	2012-12-21 15:30:23 UTC (rev 138374)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+script src=""
+select size=2
+  optionPASS/optionFAIL
+/select
+script
+description('Check that a select control does not render children that are not lt;optiongt; or lt;optgroupgt;.');
+
+var select = document.querySelector('select');
+
+var div = select.appendChild(document.createElement('div'));
+div.innerText = 'FAIL';
+div.style.background = '';
+
+// innerText uses the render tree, and the FAIL text (from either the initial 
+// HTML or the dynamially inserted div) should not be in the render tree, thus 
+// not appear.
+shouldBeEqualToString('select.innerText', '');
+/script
+script src=""


Modified: trunk/Source/WebCore/ChangeLog (138373 => 138374)

--- trunk/Source/WebCore/ChangeLog	2012-12-21 15:28:42 UTC (rev 138373)
+++ trunk/Source/WebCore/ChangeLog	2012-12-21 15:30:23 UTC (rev 138374)
@@ -1,3 +1,21 @@
+2012-12-21  Mihai Parparita  mih...@chromium.org
+
+Slow performance with select with many options and size = 2
+https://bugs.webkit.org/show_bug.cgi?id=105483
+
+Reviewed by Eric Seidel.
+
+Avoids creating renderers for children of list selects that are not
+option or optgroup. This is both more correct (no other browser
+displays them) and provides a performance benefit (direct text children 
+of select would have O(N^2) behavior; this usually happened due to
+whitespace between option.../option tags).
+
+Test: fast/forms/menulist-no-renderer-for-unexpected-children.html
+
+* html/HTMLSelectElement.cpp:
+(WebCore::HTMLSelectElement::childShouldCreateRenderer):
+
 2012-12-21  Keishi Hattori  kei...@webkit.org
 
 Fix typing zero into multiple field input


Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (138373 => 138374)

--- 

[webkit-changes] [132421] trunk/Source

[mihaip]

Title: [132421] trunk/Source








Revision 132421
Author mih...@chromium.org
Date 2012-10-24 16:26:58 -0700 (Wed, 24 Oct 2012)


Log Message
[Chromium] Allow pushState and related history APIs to be disabled per context
https://bugs.webkit.org/show_bug.cgi?id=99780

Reviewed by Adam Barth.

Source/WebCore:

Chrome Apps do not support the history API (or navigation in general).
Since pushState is generally feature detected, it's cleanest to disable
it via a V8 per-context feature, so that applications can have the
appropriate fallback behavior (other history APIs are re-mapped to throw
exceptions, since history.back() and the link are not feature detected).

* dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::pushStateEnabled):
(WebCore):
* dom/ContextFeatures.h:
* dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
* page/History.idl:

Source/WebKit/chromium:

Add pushState context feature.

* public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowPushState):
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContextFeatures.cpp
trunk/Source/WebCore/dom/ContextFeatures.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/History.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebPermissionClient.h
trunk/Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (132420 => 132421)

--- trunk/Source/WebCore/ChangeLog	2012-10-24 23:24:05 UTC (rev 132420)
+++ trunk/Source/WebCore/ChangeLog	2012-10-24 23:26:58 UTC (rev 132421)
@@ -1,3 +1,24 @@
+2012-10-24  Mihai Parparita  mih...@chromium.org
+
+[Chromium] Allow pushState and related history APIs to be disabled per context
+https://bugs.webkit.org/show_bug.cgi?id=99780
+
+Reviewed by Adam Barth.
+
+Chrome Apps do not support the history API (or navigation in general).
+Since pushState is generally feature detected, it's cleanest to disable
+it via a V8 per-context feature, so that applications can have the
+appropriate fallback behavior (other history APIs are re-mapped to throw
+exceptions, since history.back() and the link are not feature detected).
+
+* dom/ContextFeatures.cpp:
+(WebCore::ContextFeatures::pushStateEnabled):
+(WebCore):
+* dom/ContextFeatures.h:
+* dom/Document.cpp:
+(WebCore::Document::enqueuePopstateEvent):
+* page/History.idl:
+
 2012-10-24  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Make sure all events are dispatched asynchronously


Modified: trunk/Source/WebCore/dom/ContextFeatures.cpp (132420 => 132421)

--- trunk/Source/WebCore/dom/ContextFeatures.cpp	2012-10-24 23:24:05 UTC (rev 132420)
+++ trunk/Source/WebCore/dom/ContextFeatures.cpp	2012-10-24 23:26:58 UTC (rev 132421)
@@ -107,6 +107,11 @@
 return document-contextFeatures()-isEnabled(document, MutationEvents, true);
 }
 
+bool ContextFeatures::pushStateEnabled(Document* document)
+{
+return document-contextFeatures()-isEnabled(document, PushState, true);
+}
+
 void provideContextFeaturesTo(Page* page, ContextFeaturesClient* client)
 {
 RefCountedSupplementPage, ContextFeatures::provideTo(page, ContextFeatures::supplementName(), ContextFeatures::create(client));


Modified: trunk/Source/WebCore/dom/ContextFeatures.h (132420 => 132421)

--- trunk/Source/WebCore/dom/ContextFeatures.h	2012-10-24 23:24:05 UTC (rev 132420)
+++ trunk/Source/WebCore/dom/ContextFeatures.h	2012-10-24 23:26:58 UTC (rev 132421)
@@ -44,6 +44,7 @@
 PagePopup,
 HTMLNotifications,
 MutationEvents,
+PushState,
 FeatureTypeSize // Should be the last entry.
 };
 
@@ -56,6 +57,7 @@
 static bool pagePopupEnabled(Document*);
 static bool htmlNotificationsEnabled(Document*);
 static bool mutationEventsEnabled(Document*);
+static bool pushStateEnabled(Document*);
 
 bool isEnabled(Document*, FeatureType, bool) const;
 void urlDidChange(Document*);


Modified: trunk/Source/WebCore/dom/Document.cpp (132420 => 132421)

--- trunk/Source/WebCore/dom/Document.cpp	2012-10-24 23:24:05 UTC (rev 132420)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-10-24 23:26:58 UTC (rev 132421)
@@ -5017,6 +5017,9 @@
 
 void Document::enqueuePopstateEvent(PassRefPtrSerializedScriptValue stateObject)
 {
+if (!ContextFeatures::pushStateEnabled(this))
+return;
+
 // FIXME: https://bugs.webkit.org/show_bug.cgi?id=36202 Popstate event needs to fire asynchronously
 dispatchWindowEvent(PopStateEvent::create(stateObject, domWindow() ? domWindow()-history() : 0));
 }


Modified: trunk/Source/WebCore/page/History.idl (132420 => 132421)

--- trunk/Source/WebCore/page/History.idl	2012-10-24 23:24:05 UTC (rev 132420)
+++ trunk/Source/WebCore/page/History.idl	2012-10-24 

[webkit-changes] [129442] trunk/Source/WebKit/chromium

[mihaip]

Title: [129442] trunk/Source/WebKit/chromium








Revision 129442
Author mih...@chromium.org
Date 2012-09-24 19:07:14 -0700 (Mon, 24 Sep 2012)


Log Message
[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
https://bugs.webkit.org/show_bug.cgi?id=97506

Reviewed by Adam Barth.

These methods have been no-ops since r127674. All Chromium code that
called them was removed with http://crrev.com/155205.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h
trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129441 => 129442)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-25 01:48:49 UTC (rev 129441)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-25 02:07:14 UTC (rev 129442)
@@ -1,3 +1,17 @@
+2012-09-24  Mihai Parparita  mih...@chromium.org
+
+[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
+https://bugs.webkit.org/show_bug.cgi?id=97506
+
+Reviewed by Adam Barth.
+
+These methods have been no-ops since r127674. All Chromium code that
+called them was removed with http://crrev.com/155205.
+
+* public/WebRuntimeFeatures.h:
+(WebRuntimeFeatures):
+* src/WebRuntimeFeatures.cpp:
+
 2012-09-24  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium][Mac] Remove loadFont from PlatformSupport


Modified: trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h (129441 => 129442)

--- trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h	2012-09-25 01:48:49 UTC (rev 129441)
+++ trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h	2012-09-25 02:07:14 UTC (rev 129442)
@@ -76,10 +76,6 @@
 WEBKIT_EXPORT static void enableWebAudio(bool);
 WEBKIT_EXPORT static bool isWebAudioEnabled();
 
-// TODO: Remove these (since they're no-ops) once Chromium code stops calling them.
-WEBKIT_EXPORT static void enablePushState(bool);
-WEBKIT_EXPORT static bool isPushStateEnabled(bool);
-
 WEBKIT_EXPORT static void enableTouch(bool);
 WEBKIT_EXPORT static bool isTouchEnabled();
 


Modified: trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp (129441 => 129442)

--- trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	2012-09-25 01:48:49 UTC (rev 129441)
+++ trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	2012-09-25 02:07:14 UTC (rev 129442)
@@ -204,15 +204,6 @@
 #endif
 }
 
-void WebRuntimeFeatures::enablePushState(bool)
-{
-}
-
-bool WebRuntimeFeatures::isPushStateEnabled(bool enable)
-{
-return true;
-}
-
 void WebRuntimeFeatures::enableTouch(bool enable)
 {
 #if ENABLE(TOUCH_EVENTS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127674] trunk/Source

[mihaip]

Title: [127674] trunk/Source








Revision 127674
Author mih...@chromium.org
Date 2012-09-05 18:32:40 -0700 (Wed, 05 Sep 2012)


Log Message
[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
https://bugs.webkit.org/show_bug.cgi?id=95865

Reviewed by Darin Fisher.

Source/WebCore:

r55549 made them be runtime-enabled (since the Chromium implementation
was not complete at the time), but they've been enabled by default
since http://crrev.com/41850

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* page/History.idl:

Source/WebKit/chromium:

Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
no-ops.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePushState):
(WebKit::WebRuntimeFeatures::isPushStateEnabled):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
trunk/Source/WebCore/page/History.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h
trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (127673 => 127674)

--- trunk/Source/WebCore/ChangeLog	2012-09-06 01:31:23 UTC (rev 127673)
+++ trunk/Source/WebCore/ChangeLog	2012-09-06 01:32:40 UTC (rev 127674)
@@ -1,3 +1,20 @@
+2012-09-05  Mihai Parparita  mih...@chromium.org
+
+[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
+https://bugs.webkit.org/show_bug.cgi?id=95865
+
+Reviewed by Darin Fisher.
+
+r55549 made them be runtime-enabled (since the Chromium implementation
+was not complete at the time), but they've been enabled by default
+since http://crrev.com/41850
+
+* bindings/generic/RuntimeEnabledFeatures.cpp:
+(WebCore):
+* bindings/generic/RuntimeEnabledFeatures.h:
+(RuntimeEnabledFeatures):
+* page/History.idl:
+
 2012-09-05  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: Integer version lost after first open/close/open cycle


Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (127673 => 127674)

--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-09-06 01:31:23 UTC (rev 127673)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-09-06 01:32:40 UTC (rev 127674)
@@ -50,7 +50,6 @@
 bool RuntimeEnabledFeatures::isGeolocationEnabled = true;
 bool RuntimeEnabledFeatures::isIndexedDBEnabled = false;
 bool RuntimeEnabledFeatures::isWebAudioEnabled = false;
-bool RuntimeEnabledFeatures::isPushStateEnabled = false;
 bool RuntimeEnabledFeatures::isTouchEnabled = true;
 bool RuntimeEnabledFeatures::isDeviceMotionEnabled = true;
 bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;


Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (127673 => 127674)

--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2012-09-06 01:31:23 UTC (rev 127673)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2012-09-06 01:32:40 UTC (rev 127674)
@@ -129,10 +129,6 @@
 static bool webkitAudioContextEnabled() { return isWebAudioEnabled; }
 #endif
 
-static void setPushStateEnabled(bool isEnabled) { isPushStateEnabled = isEnabled; }
-static bool pushStateEnabled() { return isPushStateEnabled; }
-static bool replaceStateEnabled() { return isPushStateEnabled; }
-
 #if ENABLE(TOUCH_EVENTS)
 static bool touchEnabled() { return isTouchEnabled; }
 static void setTouchEnabled(bool isEnabled) { isTouchEnabled = isEnabled; }
@@ -276,7 +272,6 @@
 static bool isGeolocationEnabled;
 static bool isIndexedDBEnabled;
 static bool isWebAudioEnabled;
-static bool isPushStateEnabled;
 static bool isTouchEnabled;
 static bool isDeviceMotionEnabled;
 static bool isDeviceOrientationEnabled;


Modified: trunk/Source/WebCore/page/History.idl (127673 => 127674)

--- trunk/Source/WebCore/page/History.idl	2012-09-06 01:31:23 UTC (rev 127673)
+++ trunk/Source/WebCore/page/History.idl	2012-09-06 01:32:40 UTC (rev 127674)
@@ -20,7 +20,7 @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 module window {
@@ -42,10 +42,10 @@
 [DoNotCheckSecurity, CallWith=ScriptExecutionContext] void back();
 [DoNotCheckSecurity, CallWith=ScriptExecutionContext] void forward();
 [DoNotCheckSecurity, CallWith=ScriptExecutionContext] void go(in [Optional=DefaultIsUndefined] long 

[webkit-changes] [124932] trunk/Source/WebKit/chromium

[mihaip]

Title: [124932] trunk/Source/WebKit/chromium








Revision 124932
Author mih...@chromium.org
Date 2012-08-07 15:58:34 -0700 (Tue, 07 Aug 2012)


Log Message
[Chromium] Clean up WebScriptController.h comments
https://bugs.webkit.org/show_bug.cgi?id=93399

Reviewed by Adam Barth.

Remove references to overloaded WebScriptController::registerExtension
variants. They were removed in r68666.

* public/WebScriptController.h:
(WebScriptController):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebScriptController.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (124931 => 124932)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-07 22:56:02 UTC (rev 124931)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-07 22:58:34 UTC (rev 124932)
@@ -1,3 +1,16 @@
+2012-08-07  Mihai Parparita  mih...@chromium.org
+
+[Chromium] Clean up WebScriptController.h comments
+https://bugs.webkit.org/show_bug.cgi?id=93399
+
+Reviewed by Adam Barth.
+
+Remove references to overloaded WebScriptController::registerExtension
+variants. They were removed in r68666.
+
+* public/WebScriptController.h:
+(WebScriptController):
+
 2012-08-07  Kentaro Hara  hara...@chromium.org
 
 [V8] Remove #include Frame.h from V8Binding.h


Modified: trunk/Source/WebKit/chromium/public/WebScriptController.h (124931 => 124932)

--- trunk/Source/WebKit/chromium/public/WebScriptController.h	2012-08-07 22:56:02 UTC (rev 124931)
+++ trunk/Source/WebKit/chromium/public/WebScriptController.h	2012-08-07 22:58:34 UTC (rev 124932)
@@ -39,18 +39,11 @@
 
 namespace WebKit {
 
-class WebString;
-
 class WebScriptController {
 public:
-// Registers a v8 extension to be available on webpages. The three forms
-// offer various restrictions on what types of contexts the extension is
-// loaded into. If a scheme is provided, only pages whose URL has the given
-// scheme will match. If extensionGroup is provided, the extension will only
-// be loaded into scripts run via WebFrame::ExecuteInNewWorld with the
-// matching group.
-// Will only affect v8 contexts initialized after this call. Takes ownership
-// of the v8::Extension object passed.
+// Registers a v8 extension to be available on webpages. Will only affect
+// v8 contexts initialized after this call. Takes ownership of the
+// v8::Extension object passed.
 WEBKIT_EXPORT static void registerExtension(v8::Extension*);
 
 // Enables special settings which are only applicable if V8 is executed






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122762] branches/chromium/1180/Source/WebCore/inspector

[mihaip]

Title: [122762] branches/chromium/1180/Source/WebCore/inspector








Revision 122762
Author mih...@chromium.org
Date 2012-07-16 14:11:20 -0700 (Mon, 16 Jul 2012)


Log Message
Merge 120822 - Web Inspector: don't report context ids before DidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=89567

Reviewed by Pavel Feldman.

When inspector state is restored only report existing context ids
if did commit load even has already been dispatched.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::restore):
* inspector/PageRuntimeAgent.h:
(WebCore):
(WebCore::PageRuntimeAgent::create):
(PageRuntimeAgent):

TBR=yu...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10779021

Modified Paths

branches/chromium/1180/Source/WebCore/inspector/InspectorController.cpp
branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.cpp
branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.h




Diff

Modified: branches/chromium/1180/Source/WebCore/inspector/InspectorController.cpp (122761 => 122762)

--- branches/chromium/1180/Source/WebCore/inspector/InspectorController.cpp	2012-07-16 21:06:54 UTC (rev 122761)
+++ branches/chromium/1180/Source/WebCore/inspector/InspectorController.cpp	2012-07-16 21:11:20 UTC (rev 122762)
@@ -121,7 +121,7 @@
 m_resourceAgent = resourceAgentPtr.get();
 m_agents.append(resourceAgentPtr.release());
 
-OwnPtrInspectorRuntimeAgent runtimeAgentPtr(PageRuntimeAgent::create(m_instrumentingAgents.get(), m_state.get(), m_injectedScriptManager.get(), page, pageAgent));
+OwnPtrInspectorRuntimeAgent runtimeAgentPtr(PageRuntimeAgent::create(m_instrumentingAgents.get(), m_state.get(), m_injectedScriptManager.get(), page, pageAgent, m_inspectorAgent));
 InspectorRuntimeAgent* runtimeAgent = runtimeAgentPtr.get();
 m_agents.append(runtimeAgentPtr.release());
 


Modified: branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.cpp (122761 => 122762)

--- branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.cpp	2012-07-16 21:06:54 UTC (rev 122761)
+++ branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.cpp	2012-07-16 21:11:20 UTC (rev 122762)
@@ -38,6 +38,7 @@
 #include Document.h
 #include InjectedScript.h
 #include InjectedScriptManager.h
+#include InspectorAgent.h
 #include InspectorPageAgent.h
 #include InspectorState.h
 #include InstrumentingAgents.h
@@ -52,10 +53,11 @@
 static const char reportExecutionContextCreation[] = reportExecutionContextCreation;
 };
 
-PageRuntimeAgent::PageRuntimeAgent(InstrumentingAgents* instrumentingAgents, InspectorState* state, InjectedScriptManager* injectedScriptManager, Page* page, InspectorPageAgent* pageAgent)
+PageRuntimeAgent::PageRuntimeAgent(InstrumentingAgents* instrumentingAgents, InspectorState* state, InjectedScriptManager* injectedScriptManager, Page* page, InspectorPageAgent* pageAgent, InspectorAgent* inspectorAgent)
 : InspectorRuntimeAgent(instrumentingAgents, state, injectedScriptManager)
 , m_inspectedPage(page)
 , m_pageAgent(pageAgent)
+, m_inspectorAgent(inspectorAgent)
 , m_frontend(0)
 {
 }
@@ -81,8 +83,13 @@
 {
 if (!m_state-getBoolean(PageRuntimeAgentState::reportExecutionContextCreation))
 return;
-String error;
-setReportExecutionContextCreation(error, true);
+// Only report existing contexts if the page did commit load, otherwise we may
+// unintentionally initialize contexts in the frames which may trigger some listeners
+// that are expected to be triggered only after the load is committed, see http://crbug.com/131623
+if (m_inspectorAgent-didCommitLoadFired()) {
+String error;
+setReportExecutionContextCreation(error, true);
+}
 }
 
 void PageRuntimeAgent::setReportExecutionContextCreation(ErrorString*, bool enable)


Modified: branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.h (122761 => 122762)

--- branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.h	2012-07-16 21:06:54 UTC (rev 122761)
+++ branches/chromium/1180/Source/WebCore/inspector/PageRuntimeAgent.h	2012-07-16 21:11:20 UTC (rev 122762)
@@ -40,15 +40,16 @@
 
 namespace WebCore {
 
+class InspectorAgent;
 class InspectorPageAgent;
 class Page;
 class SecurityOrigin;
 
 class PageRuntimeAgent : public InspectorRuntimeAgent {
 public:
-static PassOwnPtrPageRuntimeAgent create(InstrumentingAgents* instrumentingAgents, InspectorState* state, InjectedScriptManager* injectedScriptManager, Page* page, InspectorPageAgent* pageAgent)
+static PassOwnPtrPageRuntimeAgent create(InstrumentingAgents* instrumentingAgents, InspectorState* state, InjectedScriptManager* injectedScriptManager, Page* page, InspectorPageAgent* pageAgent, InspectorAgent* inspectorAgent)
 {
-return adoptPtr(new PageRuntimeAgent(instrumentingAgents, state, 

[webkit-changes] [122154] trunk/Tools

[mihaip]

Title: [122154] trunk/Tools








Revision 122154
Author mih...@chromium.org
Date 2012-07-09 13:46:29 -0700 (Mon, 09 Jul 2012)


Log Message
Handle missing results in TestResultsServer better
https://bugs.webkit.org/show_bug.cgi?id=90816

Reviewed by Ojan Vafai.

If we can't load the results JSON, don't try to wrap it with the JSONP
callback invocation.

* TestResultServer/handlers/testfilehandler.py:
(GetFile.get):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/handlers/testfilehandler.py




Diff

Modified: trunk/Tools/ChangeLog (122153 => 122154)

--- trunk/Tools/ChangeLog	2012-07-09 20:46:07 UTC (rev 122153)
+++ trunk/Tools/ChangeLog	2012-07-09 20:46:29 UTC (rev 122154)
@@ -1,3 +1,16 @@
+2012-07-09  Mihai Parparita  mih...@chromium.org
+
+Handle missing results in TestResultsServer better
+https://bugs.webkit.org/show_bug.cgi?id=90816
+
+Reviewed by Ojan Vafai.
+
+If we can't load the results JSON, don't try to wrap it with the JSONP
+callback invocation.
+
+* TestResultServer/handlers/testfilehandler.py:
+(GetFile.get):
+
 2012-07-09  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r122124.


Modified: trunk/Tools/TestResultServer/handlers/testfilehandler.py (122153 => 122154)

--- trunk/Tools/TestResultServer/handlers/testfilehandler.py	2012-07-09 20:46:07 UTC (rev 122153)
+++ trunk/Tools/TestResultServer/handlers/testfilehandler.py	2012-07-09 20:46:29 UTC (rev 122154)
@@ -203,9 +203,12 @@
 else:
 json, date = self._get_file_content(master, builder, test_type, name)
 
-self._serve_json(_replace_jsonp_callback(json, callback_name), date)
+if json:
+json = _replace_jsonp_callback(json, callback_name)
 
+self._serve_json(json, date)
 
+
 class Upload(webapp.RequestHandler):
 Upload test results file to datastore.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [119276] trunk

[mihaip]

Title: [119276] trunk








Revision 119276
Author mih...@chromium.org
Date 2012-06-01 13:23:53 -0700 (Fri, 01 Jun 2012)


Log Message
Improve synchronous XHR disabling
https://bugs.webkit.org/show_bug.cgi?id=88032

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled): Fix a
copy-and-paste error
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open): Improves the disabled message, as
suggested in a comment after r118599 was put in the commit queue.

LayoutTests:

Update with new error message.

* fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (119275 => 119276)

--- trunk/LayoutTests/ChangeLog	2012-06-01 20:22:27 UTC (rev 119275)
+++ trunk/LayoutTests/ChangeLog	2012-06-01 20:23:53 UTC (rev 119276)
@@ -1,3 +1,14 @@
+2012-06-01  Mihai Parparita  mih...@chromium.org
+
+Improve synchronous XHR disabling
+https://bugs.webkit.org/show_bug.cgi?id=88032
+
+Reviewed by Alexey Proskuryakov.
+
+Update with new error message.
+
+* fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt:
+
 2012-06-01  Beth Dakin  bda...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=87774


Modified: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt (119275 => 119276)

--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt	2012-06-01 20:22:27 UTC (rev 119275)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt	2012-06-01 20:23:53 UTC (rev 119276)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Synchronous XMLHttpRequests cannot be made in the current window context.
+CONSOLE MESSAGE: Synchronous XMLHttpRequests are disabled for this page.
 This tests that synchronous XMLHttpRequests fail when they are disabled for documents.
 
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.


Modified: trunk/Source/WebCore/ChangeLog (119275 => 119276)

--- trunk/Source/WebCore/ChangeLog	2012-06-01 20:22:27 UTC (rev 119275)
+++ trunk/Source/WebCore/ChangeLog	2012-06-01 20:23:53 UTC (rev 119276)
@@ -1,3 +1,17 @@
+2012-06-01  Mihai Parparita  mih...@chromium.org
+
+Improve synchronous XHR disabling
+https://bugs.webkit.org/show_bug.cgi?id=88032
+
+Reviewed by Alexey Proskuryakov.
+
+* testing/InternalSettings.cpp:
+(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled): Fix a
+copy-and-paste error
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::open): Improves the disabled message, as
+suggested in a comment after r118599 was put in the commit queue.
+
 2012-06-01  Beth Dakin  bda...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=87774


Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (119275 => 119276)

--- trunk/Source/WebCore/testing/InternalSettings.cpp	2012-06-01 20:22:27 UTC (rev 119275)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp	2012-06-01 20:23:53 UTC (rev 119276)
@@ -371,10 +371,10 @@
 settings()-setFixedPositionCreatesStackingContext(creates);
 }
 
-void InternalSettings::setSyncXHRInDocumentsEnabled(bool creates, ExceptionCode ec)
+void InternalSettings::setSyncXHRInDocumentsEnabled(bool enabled, ExceptionCode ec)
 {
-InternalSettingsGuardForFrameView();
-settings()-setSyncXHRInDocumentsEnabled(creates);
+InternalSettingsGuardForSettings();
+settings()-setSyncXHRInDocumentsEnabled(enabled);
 }
 
 void InternalSettings::setJavaScriptProfilingEnabled(bool enabled, ExceptionCode ec)


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (119275 => 119276)

--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2012-06-01 20:22:27 UTC (rev 119275)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2012-06-01 20:23:53 UTC (rev 119276)
@@ -486,7 +486,7 @@
 
 if (!async  scriptExecutionContext()-isDocument()) {
 if (!document()-settings()-syncXHRInDocumentsEnabled()) {
-logConsoleError(scriptExecutionContext(), Synchronous XMLHttpRequests cannot be made in the current window context.);
+logConsoleError(scriptExecutionContext(), Synchronous XMLHttpRequests are disabled for this page.);
 ec = INVALID_ACCESS_ERR;
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118599] trunk

[mihaip]

Title: [118599] trunk








Revision 118599
Author mih...@chromium.org
Date 2012-05-25 19:05:47 -0700 (Fri, 25 May 2012)


Log Message
Allow synchronous XHRs to be disabled in documents
https://bugs.webkit.org/show_bug.cgi?id=87540

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/xmlhttprequest/xmlhttprequest-sync-disabled.html

Synchronous XMLHttpRequests are a problematic API, since they result
in blocked UI threads. Some clients may wish to always disable them;
give them a setting to do so (see also r103629 for other cases where
synchronous XHRs are disabled).

* page/Settings.cpp:
(WebCore):
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):
(WebCore::Settings::setSyncXHRInDocumentsEnabled):
(WebCore::Settings::syncXHRInDocumentsEnabled):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):

Source/WebKit/chromium:

Synchronous XMLHttpRequests are a problematic API, since they result
in blocked UI threads. Some clients may wish to always disable them;
give them a setting to do so (see also r103629 for other cases where
synchronous XHRs are disabled).

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setSyncXHRInDocumentsEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

LayoutTests:

Synchronous XMLHttpRequests are a problematic API, since they result
in blocked UI threads. Some clients may wish to always disable them;
give them a setting to do so (see also r103629 for other cases where
synchronous XHRs are disabled).

* fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-sync-disabled.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h


Added Paths

trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled.html




Diff

Modified: trunk/LayoutTests/ChangeLog (118598 => 118599)

--- trunk/LayoutTests/ChangeLog	2012-05-26 01:53:06 UTC (rev 118598)
+++ trunk/LayoutTests/ChangeLog	2012-05-26 02:05:47 UTC (rev 118599)
@@ -1,3 +1,18 @@
+2012-05-25  Mihai Parparita  mih...@chromium.org
+
+Allow synchronous XHRs to be disabled in documents
+https://bugs.webkit.org/show_bug.cgi?id=87540
+
+Reviewed by Eric Seidel.
+
+Synchronous XMLHttpRequests are a problematic API, since they result
+in blocked UI threads. Some clients may wish to always disable them;
+give them a setting to do so (see also r103629 for other cases where
+synchronous XHRs are disabled).
+
+* fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt: Added.
+* fast/xmlhttprequest/xmlhttprequest-sync-disabled.html: Added.
+
 2012-05-25  Stephanie Lewis  sle...@apple.com
 
 See https://bugs.webkit.org/show_bug.cgi?id=87558


Added: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt (0 => 118599)

--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt	2012-05-26 02:05:47 UTC (rev 118599)
@@ -0,0 +1,11 @@
+CONSOLE MESSAGE: Synchronous XMLHttpRequests cannot be made in the current window context.
+This tests that synchronous XMLHttpRequests fail when they are disabled for documents.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS xhr.open(GET, http://mydomain/, false) threw exception Error: INVALID_ACCESS_ERR: DOM Exception 15.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled.html (0 => 118599)

--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled.html	(rev 0)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled.html	2012-05-26 02:05:47 UTC (rev 118599)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+head
+script src=""
+script
+if ('internals' in window) {
+window.internals.settings.setSyncXHRInDocumentsEnabled(false);
+} else {
+document.write('This test depends on the syncXHRInDocumentsEnabled setting being 

[webkit-changes] [117356] branches/chromium/1084

[mihaip]

Title: [117356] branches/chromium/1084








Revision 117356
Author mih...@chromium.org
Date 2012-05-16 15:47:06 -0700 (Wed, 16 May 2012)


Log Message
Merge 115471 - Infinite backgroundClipRect should not be scrolled.
https://bugs.webkit.org/show_bug.cgi?id=84979

Reviewed by Adrienne Walker.

Source/WebCore:

Test: compositing/iframes/scroll-fixed-transformed-element.html

By accidentally scrolling clipRects that should be considered
infinite, they were no longer being considered infinite. This
caused a chain of un-intended code paths that caused fixed
position elements to stutter when scrolling in Chromium.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundClipRect):

LayoutTests:

* compositing/iframes/resources/fixed-position-transformed-subframe.html: Added.
* compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
* compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added.
* compositing/iframes/scroll-fixed-transformed-element.html: Added.


TBR=shawnsi...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392139

Modified Paths

branches/chromium/1084/Source/WebCore/rendering/RenderLayer.cpp
branches/chromium/1084/Source/WebCore/rendering/RenderLayer.h


Added Paths

branches/chromium/1084/LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html
branches/chromium/1084/LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.png
branches/chromium/1084/LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.txt
branches/chromium/1084/LayoutTests/compositing/iframes/scroll-fixed-transformed-element.html




Diff

Copied: branches/chromium/1084/LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html (from rev 115471, trunk/LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html) (0 => 117356)

--- branches/chromium/1084/LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html	(rev 0)
+++ branches/chromium/1084/LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html	2012-05-16 22:47:06 UTC (rev 117356)
@@ -0,0 +1,57 @@
+!DOCTYPE html
+html
+head
+  style type='text/css'
+body {
+height: 1000px;
+}
+
+.green {
+background-color: green;
+}
+
+.fixed {
+position: fixed;
+top: 0px;
+left: 0px;
+}
+
+.box {
+width: 300px;
+height: 300px;
+}
+
+.container {
+position: relative;
+}
+
+.perspective {
+-webkit-perspective: 1px;
+}
+  /style
+  script
+if (window.layoutTestController) {
+  layoutTestController.dumpAsText(true);
+}
+
+function doTest()
+{
+  if (window.layoutTestController)
+layoutTestController.display();
+
+  // Any scroll should keep the fixed-position element where it is.
+  // If it stutters or disappears incorrectly, then the red background will be revealed.
+  window.scrollTo(0, 150);
+}
+
+window.addEventListener('load', doTest, false);
+  /script
+/head
+body
+  div class=green fixed box
+div class=container
+  div class=perspective/div
+/div
+  /div
+/body
+/html


Copied: branches/chromium/1084/LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.png (from rev 115471, trunk/LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.png) (0 => 117356)

--- branches/chromium/1084/LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.png	(rev 0)
+++ branches/chromium/1084/LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.png	2012-05-16 22:47:06 UTC (rev 117356)
@@ -0,0 +1,4 @@
+\x89PNG
+
+
+IHDR X\x9Av\x82p)tEXtchecksum6af474e45894513176ceb230a7c9c05b\xA0\xE9\xBD\xDB\xA6IDATx\x9C\xED\xD91n\xC30A*н\xA8\xAB\xE5f\xBCӺ`X\xAB\xC235	\xBCv\xF1\x8F\xBD\xF7\x81\x9F\xA7\xDFC\x80
d\x90 @F\x80
d\xCE\xFF\xBFG\xB1`\x8C1ƺ\xD6\xDB真\xDC\xC2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\xCC\xF9\xF4\x80Wk\xAD\xB7\xFF\xCE9?7\xB8\x85\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 

[webkit-changes] [112675] trunk/Tools

[mihaip]

Title: [112675] trunk/Tools








Revision 112675
Author mih...@chromium.org
Date 2012-03-30 09:31:14 -0700 (Fri, 30 Mar 2012)


Log Message
Actually remove the ChromiumOS GTK builder, like r112673 said it would.

* TestResultServer/static-dashboards/builders.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.js




Diff

Modified: trunk/Tools/ChangeLog (112674 => 112675)

--- trunk/Tools/ChangeLog	2012-03-30 16:24:35 UTC (rev 112674)
+++ trunk/Tools/ChangeLog	2012-03-30 16:31:14 UTC (rev 112675)
@@ -1,5 +1,11 @@
 2012-03-30  Mihai Parparita  mih...@chromium.org
 
+Actually remove the ChromiumOS GTK builder, like r112673 said it would.
+
+* TestResultServer/static-dashboards/builders.js:
+
+2012-03-30  Mihai Parparita  mih...@chromium.org
+
 Update ChromiumOS bot names in builders.js to reflect changes made by
 http://crrev.com/129835
 


Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (112674 => 112675)

--- trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-03-30 16:24:35 UTC (rev 112674)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-03-30 16:31:14 UTC (rev 112675)
@@ -239,7 +239,6 @@
 var CHROMIUMOS_GTESTS_DEPS_BUILDERS = [
 ['Linux ChromiumOS Tests (1)', BuilderGroup.DEFAULT_BUILDER],
 ['Linux ChromiumOS Tests (2)'],
-['Linux ChromiumOS GTK'],
 ['Linux ChromiumOS Tests (dbg)(1)'],
 ['Linux ChromiumOS Tests (dbg)(2)'],
 ['Linux ChromiumOS Tests (dbg)(3)'],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109960] branches/chromium/1025

[mihaip]

Title: [109960] branches/chromium/1025








Revision 109960
Author mih...@chromium.org
Date 2012-03-06 14:41:00 -0800 (Tue, 06 Mar 2012)


Log Message
Merge 109543 - REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
https://bugs.webkit.org/show_bug.cgi?id=76590

Reviewed by Maciej Stachowiak.

Source/WebCore: 

Test: fast/css/pending-stylesheet-repaint.html

If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.

* dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):

LayoutTests: 

* fast/css/pending-stylesheet-repaint-expected.png: Added.
* fast/css/pending-stylesheet-repaint-expected.txt: Added.
* fast/css/pending-stylesheet-repaint.html: Added.



TBR=an...@apple.com
Review URL: https://chromiumcodereview.appspot.com/9618030

Modified Paths

branches/chromium/1025/Source/WebCore/dom/Document.cpp


Added Paths

branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint-expected.png
branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt
branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint.html




Diff

Copied: branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint-expected.png (from rev 109543, trunk/LayoutTests/fast/css/pending-stylesheet-repaint-expected.png)

(Binary files differ)


Copied: branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt (from rev 109543, trunk/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt) (0 => 109960)

--- branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt	(rev 0)
+++ branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt	2012-03-06 22:41:00 UTC (rev 109960)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x8
+  RenderBlock {HTML} at (0,0) size 800x8
+RenderBody {BODY} at (8,8) size 784x0
+layer at (8,8) size 32x32
+  RenderBlock (positioned) {DIV} at (8,8) size 32x32 [bgcolor=#008000]


Copied: branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint.html (from rev 109543, trunk/LayoutTests/fast/css/pending-stylesheet-repaint.html) (0 => 109960)

--- branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint.html	(rev 0)
+++ branches/chromium/1025/LayoutTests/fast/css/pending-stylesheet-repaint.html	2012-03-06 22:41:00 UTC (rev 109960)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+head
+  titleTest case/title
+/head
+
+body
+  div style=background: green; width: 32px; height: 32px; position: absolute/div
+
+  script
+window.addEventListener(
+'DOMContentLoaded',
+function() {
+  // Must dynamically fetch another stylesheet
+  var el = document.createElement('link');
+  el.href = '';
+  el.type = 'text/css';
+  el.rel = 'stylesheet';
+  document.getElementsByTagName('head')[0].appendChild(el);
+
+  // Based on jQuery pre-1.6.2 code, which creates a temporary body
+  // element to do tests on:
+  // https://github.com/jquery/jquery/blob/304dd618b7aa17158446bedd80af330375d8d4d4/src/support.js#L138
+  // The behavior was changed for jQuery 1.6.2 with this commit:
+  // https://github.com/jquery/jquery/commit/ceba855c010c792aad8fc15edc06b86285f71142/
+  var anotherBody = document.createElement('body');
+
+  document.documentElement.insertBefore(
+  anotherBody, document.documentElement.firstChild);
+
+  // Triggering a style recalc here is necessary.
+  anotherBody.offsetHeight;
+
+  anotherBody.parentNode.removeChild(anotherBody);
+},
+false);
+  /script
+/body
+/html


Modified: branches/chromium/1025/Source/WebCore/dom/Document.cpp (109959 => 109960)

--- branches/chromium/1025/Source/WebCore/dom/Document.cpp	2012-03-06 22:16:32 UTC (rev 109959)
+++ branches/chromium/1025/Source/WebCore/dom/Document.cpp	2012-03-06 22:41:00 UTC (rev 109960)
@@ -3003,20 +3003,21 @@
 #endif
 
 bool stylesheetChangeRequiresStyleRecalc = updateActiveStylesheets(updateFlag);
-if (!stylesheetChangeRequiresStyleRecalc)
-return;
 
 if (updateFlag == DeferRecalcStyle) {
 scheduleForcedStyleRecalc();
 return;
 }
-
+
 if (didLayoutWithPendingStylesheets()  m_pendingStylesheets = 0) {
 m_pendingSheetLayout = IgnoreLayoutWithPendingSheets;
 if (renderer())
 renderer()-repaint();
 }
 
+if (!stylesheetChangeRequiresStyleRecalc)
+return;
+
 // This recalcStyle initiates a new recalc cycle. We need to bracket it to
 // make sure animations get the correct update time
 if (m_frame)

[webkit-changes] [107677] trunk/Source/WebKit/chromium

[mihaip]

Title: [107677] trunk/Source/WebKit/chromium








Revision 107677
Author mih...@chromium.org
Date 2012-02-13 23:54:48 -0800 (Mon, 13 Feb 2012)


Log Message
[Chromium] Remove BoundObject
https://bugs.webkit.org/show_bug.cgi?id=78531

Reviewed by Pavel Feldman.

Remove the BoundObject class, references to it were removed in r56999.

* WebKit.gyp:
* src/BoundObject.cpp: Removed.
* src/BoundObject.h: Removed.
* src/WebDevToolsFrontendImpl.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/WebDevToolsFrontendImpl.cpp


Removed Paths

trunk/Source/WebKit/chromium/src/BoundObject.cpp
trunk/Source/WebKit/chromium/src/BoundObject.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (107676 => 107677)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-14 07:54:48 UTC (rev 107677)
@@ -1,3 +1,17 @@
+2012-02-13  Mihai Parparita  mih...@chromium.org
+
+[Chromium] Remove BoundObject
+https://bugs.webkit.org/show_bug.cgi?id=78531
+
+Reviewed by Pavel Feldman.
+
+Remove the BoundObject class, references to it were removed in r56999.
+
+* WebKit.gyp:
+* src/BoundObject.cpp: Removed.
+* src/BoundObject.h: Removed.
+* src/WebDevToolsFrontendImpl.cpp:
+
 2012-02-13  W. James MacLean  wjmacl...@chromium.org
 
 [chromium] Remove obsolete zoom animation pathway.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (107676 => 107677)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-02-14 07:54:48 UTC (rev 107677)
@@ -372,8 +372,6 @@
 'src/BackForwardListChromium.h',
 'src/BlobRegistryProxy.cpp',
 'src/BlobRegistryProxy.h',
-'src/BoundObject.cpp',
-'src/BoundObject.h',
 'src/CCThreadImpl.cpp',
 'src/CCThreadImpl.h',
 'src/ChromeClientImpl.cpp',


Deleted: trunk/Source/WebKit/chromium/src/BoundObject.cpp (107676 => 107677)

--- trunk/Source/WebKit/chromium/src/BoundObject.cpp	2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/src/BoundObject.cpp	2012-02-14 07:54:48 UTC (rev 107677)
@@ -1,80 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include config.h
-#include BoundObject.h
-
-#include V8Binding.h
-#include V8Proxy.h
-
-namespace WebKit {
-
-BoundObject::BoundObject(v8::Handlev8::Context context, void* v8This, const char* objectName)
-: m_objectName(objectName)
-, m_context(context)
-, m_v8This(v8This)
-{
-v8::Context::Scope contextScope(context);
-v8::Localv8::FunctionTemplate localTemplate = v8::FunctionTemplate::New(WebCore::V8Proxy::checkNewLegal);
-m_hostTemplate = v8::Persistentv8::FunctionTemplate::New(localTemplate);
-m_hostTemplate-SetClassName(v8::String::New(objectName));
-}
-
-BoundObject::~BoundObject()
-{
-m_hostTemplate.Dispose();
-}
-
-void BoundObject::addProtoFunction(const char* name, v8::InvocationCallback callback)
-{
-v8::Context::Scope contextScope(m_context);
-v8::Localv8::Signature signature = v8::Signature::New(m_hostTemplate);
-v8::Localv8::ObjectTemplate proto = m_hostTemplate-PrototypeTemplate();
-v8::Localv8::External v8This = v8::External::New(m_v8This);
-

[webkit-changes] [96244] trunk/LayoutTests

[mihaip]

Title: [96244] trunk/LayoutTests








Revision 96244
Author mih...@chromium.org
Date 2011-09-28 12:14:17 -0700 (Wed, 28 Sep 2011)


Log Message
Rebaseline fast/canvas/canvas-composite-transformclip.html and
fast/canvas/canvas-composite.html for Chromium Snow Leopard GPU.

* platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png
trunk/LayoutTests/platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96243 => 96244)

--- trunk/LayoutTests/ChangeLog	2011-09-28 19:02:57 UTC (rev 96243)
+++ trunk/LayoutTests/ChangeLog	2011-09-28 19:14:17 UTC (rev 96244)
@@ -1,3 +1,11 @@
+2011-09-28  Mihai Parparita  mih...@chromium.org
+
+Rebaseline fast/canvas/canvas-composite-transformclip.html and
+fast/canvas/canvas-composite.html for Chromium Snow Leopard GPU.
+
+* platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png:
+* platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png:
+
 2011-09-28  Kenji Imasaki  imas...@chromium.org
 
 [Chromium] remove a passing test from the test expectation file.


Modified: trunk/LayoutTests/platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96267] trunk/LayoutTests

[mihaip]

Title: [96267] trunk/LayoutTests








Revision 96267
Author mih...@chromium.org
Date 2011-09-28 16:56:30 -0700 (Wed, 28 Sep 2011)


Log Message
Add failing Chromium expectations after r96257.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96266 => 96267)

--- trunk/LayoutTests/ChangeLog	2011-09-28 23:24:24 UTC (rev 96266)
+++ trunk/LayoutTests/ChangeLog	2011-09-28 23:56:30 UTC (rev 96267)
@@ -1,3 +1,9 @@
+2011-09-28  Mihai Parparita  mih...@chromium.org
+
+Add failing Chromium expectations after r96257.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-28  Ryosuke Niwa  rn...@webkit.org
 
 GTK rebaseline for r96257.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96266 => 96267)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-28 23:24:24 UTC (rev 96266)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-28 23:56:30 UTC (rev 96267)
@@ -3367,7 +3367,6 @@
 // Test fails because it's trying to load a plugin we don't have. We probably don't need to fix this.
 BUGJAPHET : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = TEXT
 
-BUGWK63509 : editing/style/smoosh-styles-003.html = PASS IMAGE
 BUGCR88230 VISTA : fast/dom/dom-parse-serialize-display.html = PASS TIMEOUT
 BUGCR88232 WIN DEBUG : fast/dom/non-numeric-values-numeric-parameters.html = PASS CRASH MISSING
 
@@ -3761,7 +3760,7 @@
 
 // This test is flaky and causing trouble for the Linux EWS. It is flaky on the
 // main bots too, although not as flaky for some reason.
-BUGABARTH LINUX : svg/custom/svg-fonts-word-spacing.html = PASS FAIL
+BUGABARTH WIN LINUX : svg/custom/svg-fonts-word-spacing.html = PASS FAIL
 
 BUGWK68747 : media/controls-right-click-on-timebar.html = TIMEOUT PASS
 
@@ -3787,3 +3786,259 @@
 
 BUGWK68982 : svg/custom/oversized-pattern-scale.svg = IMAGE PASS
 BUGWK68982 : svg/custom/transformed-pattern-clamp-svg-root.svg = IMAGE PASS
+
+// Need rebaselines after r96257
+BUGWK62092 WIN LINUX : editing/deleting/collapse-whitespace-3587601-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3608445-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3608462-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3775172-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3800834-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3857753-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3865854-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3928305-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-3959464-fix.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-after-span-ws-002.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-after-span-ws-003.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-all-text-in-text-field-assertion.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-and-undo.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-001.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-002.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-003.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-004.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-005.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-006.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-007.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-009.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-010.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-at-paragraph-boundaries-011.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-contents-001.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-contents-002.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-contents-003.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-001.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-002.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-003.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-004.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-005.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-006.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-007.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-008.html = TEXT
+BUGWK62092 WIN LINUX : editing/deleting/delete-block-merge-contents-009.html = TEXT

[webkit-changes] [96274] trunk/LayoutTests

[mihaip]

Title: [96274] trunk/LayoutTests








Revision 96274
Author mih...@chromium.org
Date 2011-09-28 17:21:30 -0700 (Wed, 28 Sep 2011)


Log Message
Remove Chromium failing expectations for tests that now pass.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96273 => 96274)

--- trunk/LayoutTests/ChangeLog	2011-09-29 00:20:47 UTC (rev 96273)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 00:21:30 UTC (rev 96274)
@@ -1,3 +1,9 @@
+2011-09-28  Mihai Parparita  mih...@chromium.org
+
+Remove Chromium failing expectations for tests that now pass.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-28  Ryosuke Niwa  rn...@webkit.org
 
 Chromium rebaseline for r96257 part 1.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96273 => 96274)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 00:20:47 UTC (rev 96273)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 00:21:30 UTC (rev 96274)
@@ -1450,9 +1450,6 @@
 BUGCR11483 LINUX : fast/forms/input-text-double-click.html = FAIL
 BUGCR11483 LINUX : svg/text/foreignObject-repaint.xml = FAIL
 
-BUGCR14207 LINUX : tables/mozilla/bugs/bug28341.html = FAIL
-BUGCR32231 MAC WIN : tables/mozilla/bugs/bug28341.html = PASS IMAGE
-
 // Newly added test http://trac.webkit.org/changeset/44816
 BUGCR18733 SLOW WIN : http/tests/xmlhttprequest/cross-origin-no-authorization.html = PASS
 
@@ -1511,7 +1508,6 @@
 // WebKit update 48796:48820
 // Test #9 throws an exception.
 BUGCR23956 : fast/dom/Range/getClientRects.html = FAIL
-BUGCR24126 : fast/dom/HTMLInputElement/size-attribute.html = FAIL
 
 // Started failing for no apparent reason at r28124, and IMAGE+TEXT diffs started at r51875
 
@@ -2761,7 +2757,6 @@
 // introduced by brarraclough in WK r80621
 BUGCR75562 : fast/js/array-proto-func-length-getter-except.html = TEXT
 
-BUGWK56060 LINUX X86_64 : svg/custom/pattern-excessive-malloc.svg = IMAGE
 BUGWK56060 LINUX : fast/images/favicon-as-image.html = IMAGE+TEXT
 
 BUGCR75632 LINUX : svg/W3C-SVG-1.1/text-text-03-b.svg = PASS CRASH
@@ -2983,10 +2978,6 @@
 BUGCR79917 LINUX WIN : fast/transforms/transformed-caret.html = IMAGE
 BUGCR79917 LINUX WIN : svg/custom/no-inherited-dashed-stroke.xhtml = IMAGE
 BUGCR79917 LINUX WIN : svg/transforms/animated-path-inside-transformed-html.xhtml = IMAGE
-BUGCR79917 LINUX WIN : tables/mozilla/bugs/bug22019.html = IMAGE
-BUGCR79917 LINUX WIN : tables/mozilla/bugs/bug2886.html = IMAGE
-BUGCR79917 LINUX WIN : tables/mozilla/bugs/bug2947.html = IMAGE
-BUGCR79917 LINUX WIN : tables/mozilla/bugs/bug6674.html = IMAGE
 BUGCR79917 LINUX WIN : tables/mozilla/collapsing_borders/bug41262-3.html = IMAGE
 
 BUGWK58924 MAC : plugins/mouse-click-iframe-to-plugin.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96137] trunk/Source/WebCore

[mihaip]

Title: [96137] trunk/Source/WebCore








Revision 96137
Author mih...@chromium.org
Date 2011-09-27 11:44:15 -0700 (Tue, 27 Sep 2011)


Log Message
Fix Chromium Mac build after r96130.

* page/FrameView.cpp:
(WebCore::FrameView::layerForOverhangAreas):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96136 => 96137)

--- trunk/Source/WebCore/ChangeLog	2011-09-27 18:32:55 UTC (rev 96136)
+++ trunk/Source/WebCore/ChangeLog	2011-09-27 18:44:15 UTC (rev 96137)
@@ -1,3 +1,10 @@
+2011-09-27  Mihai Parparita  mih...@chromium.org
+
+Fix Chromium Mac build after r96130.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layerForOverhangAreas):
+
 2011-09-27  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Autofocus on readonly inputs does not focus the element.


Modified: trunk/Source/WebCore/page/FrameView.cpp (96136 => 96137)

--- trunk/Source/WebCore/page/FrameView.cpp	2011-09-27 18:32:55 UTC (rev 96136)
+++ trunk/Source/WebCore/page/FrameView.cpp	2011-09-27 18:44:15 UTC (rev 96137)
@@ -697,9 +697,9 @@
 GraphicsLayer* FrameView::layerForOverhangAreas() const
 {
 RenderView* root = rootRenderer(this);
-if (!view)
+if (!root)
 return 0;
-return view-compositor()-layerForOverhangAreas();
+return root-compositor()-layerForOverhangAreas();
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96158] trunk/LayoutTests

[mihaip]

Title: [96158] trunk/LayoutTests








Revision 96158
Author mih...@chromium.org
Date 2011-09-27 14:25:17 -0700 (Tue, 27 Sep 2011)


Log Message
Chromium test expectations update.

Make new fast/canvas/canvas-composite.html GPU expectation more specific,
since on Leopard it was conflicting with an older one.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96157 => 96158)

--- trunk/LayoutTests/ChangeLog	2011-09-27 21:19:16 UTC (rev 96157)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 21:25:17 UTC (rev 96158)
@@ -1,3 +1,12 @@
+2011-09-27  Mihai Parparita  mih...@chromium.org
+
+Chromium test expectations update.
+
+Make new fast/canvas/canvas-composite.html GPU expectation more specific,
+since on Leopard it was conflicting with an older one.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r96139.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96157 => 96158)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 21:19:16 UTC (rev 96157)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 21:25:17 UTC (rev 96158)
@@ -3794,4 +3794,4 @@
 BUGWK68886 MAC GPU-CG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT
 
 BUGWK68895 MAC WIN GPU : fast/canvas/canvas-composite-transformclip.html = IMAGE
-BUGWK68895 MAC WIN GPU : fast/canvas/canvas-composite.html = IMAGE
+BUGWK68895 SNOWLEOPARD WIN GPU : fast/canvas/canvas-composite.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96165] trunk/LayoutTests

[mihaip]

Title: [96165] trunk/LayoutTests








Revision 96165
Author mih...@chromium.org
Date 2011-09-27 15:53:56 -0700 (Tue, 27 Sep 2011)


Log Message
Chromium rebaseline after r96155.

* platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
* platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
* platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png


Added Paths

trunk/LayoutTests/platform/chromium/svg/custom/oversized-pattern-scale-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png


Removed Paths

trunk/LayoutTests/platform/mac/svg/custom/pattern-excessive-malloc-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/pattern-excessive-malloc-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96164 => 96165)

--- trunk/LayoutTests/ChangeLog	2011-09-27 22:46:51 UTC (rev 96164)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 22:53:56 UTC (rev 96165)
@@ -1,3 +1,17 @@
+2011-09-27  Mihai Parparita  mih...@chromium.org
+
+Chromium rebaseline after r96155.
+
+* platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
+* platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
+* platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
+* platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
+* platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
+* platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
+* platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
+* platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
+* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
+
 2011-09-27  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=68940


Added: trunk/LayoutTests/platform/chromium/svg/custom/oversized-pattern-scale-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium/svg/custom/oversized-pattern-scale-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png
___

Added: svn:mime-type

Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png

(Binary files differ)

Property changes on: 

[webkit-changes] [95969] trunk/LayoutTests

[mihaip]

Title: [95969] trunk/LayoutTests








Revision 95969
Author mih...@chromium.org
Date 2011-09-26 12:09:49 -0700 (Mon, 26 Sep 2011)


Log Message
Chromium test expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95968 => 95969)

--- trunk/LayoutTests/ChangeLog	2011-09-26 19:01:36 UTC (rev 95968)
+++ trunk/LayoutTests/ChangeLog	2011-09-26 19:09:49 UTC (rev 95969)
@@ -1,3 +1,9 @@
+2011-09-26  Mihai Parparita  mih...@chromium.org
+
+Chromium test expectations update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-12  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION(r74971): Selection doesn't work correctly in BiDi Text


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95968 => 95969)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-26 19:01:36 UTC (rev 95968)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-26 19:09:49 UTC (rev 95969)
@@ -3825,3 +3825,8 @@
 BUGABARTH LINUX : svg/custom/svg-fonts-word-spacing.html = PASS FAIL
 
 BUGWK68747 : media/controls-right-click-on-timebar.html = TIMEOUT PASS
+
+// Assert fires (on non-Chromium WebKit ports too)
+BUGWK68819 DEBUG : svg/clip-path/clip-path-on-svg.svg = CRASH
+
+BUGWK68821 DEBUG : fast/animation/request-animation-frame-timestamps-advance.html = TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95981] trunk/LayoutTests

[mihaip]

Title: [95981] trunk/LayoutTests








Revision 95981
Author mih...@chromium.org
Date 2011-09-26 12:57:56 -0700 (Mon, 26 Sep 2011)


Log Message
Rebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports.

Previous expected result was Chromium-specific because console line
numbers were different in JSC.

Additionally, the test doesn't behave as expected for non-Chromium
ports (window size remains at 800x600). Update the baselines to use
that for now, so that we're still aware of regressions/progressions.

* fast/dom/Window/window-resize-contents-expected.txt:
* platform/chromium/fast/dom/Window/window-resize-contents-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-contents-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-resize-contents-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium/fast/dom/Window/window-resize-contents-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95980 => 95981)

--- trunk/LayoutTests/ChangeLog	2011-09-26 19:54:16 UTC (rev 95980)
+++ trunk/LayoutTests/ChangeLog	2011-09-26 19:57:56 UTC (rev 95981)
@@ -1,5 +1,19 @@
 2011-09-26  Mihai Parparita  mih...@chromium.org
 
+Rebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports.
+
+Previous expected result was Chromium-specific because console line
+numbers were different in JSC.
+
+Additionally, the test doesn't behave as expected for non-Chromium
+ports (window size remains at 800x600). Update the baselines to use
+that for now, so that we're still aware of regressions/progressions.
+
+* fast/dom/Window/window-resize-contents-expected.txt:
+* platform/chromium/fast/dom/Window/window-resize-contents-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-contents-expected.txt.
+
+2011-09-26  Mihai Parparita  mih...@chromium.org
+
 Unreviewed, rolling out r95960.
 http://trac.webkit.org/changeset/95960
 https://bugs.webkit.org/show_bug.cgi?id=58608


Modified: trunk/LayoutTests/fast/dom/Window/window-resize-contents-expected.txt (95980 => 95981)

--- trunk/LayoutTests/fast/dom/Window/window-resize-contents-expected.txt	2011-09-26 19:54:16 UTC (rev 95980)
+++ trunk/LayoutTests/fast/dom/Window/window-resize-contents-expected.txt	2011-09-26 19:57:56 UTC (rev 95981)
@@ -1,6 +1,6 @@
-CONSOLE MESSAGE: line 18: Initial reference node dimensions 800 x 600
+CONSOLE MESSAGE: line 19: Initial reference node dimensions 800 x 600
 CONSOLE MESSAGE: line 20: Increasing window size by 10 x 10
-CONSOLE MESSAGE: line 22: Post-resize reference node dimensions 810 x 610
+CONSOLE MESSAGE: line 23: Post-resize reference node dimensions 800 x 600
 This test checks that the yellow reference DOM node (which should be as big as the window) gets resized when the window is resized.
 
 To avoid relayouts and repaints caused by DOM-based logging, it doesn't output anything. Please check the console for confirmation that the node dimensions increase by 10x10.


Copied: trunk/LayoutTests/platform/chromium/fast/dom/Window/window-resize-contents-expected.txt (from rev 95974, trunk/LayoutTests/fast/dom/Window/window-resize-contents-expected.txt) (0 => 95981)

--- trunk/LayoutTests/platform/chromium/fast/dom/Window/window-resize-contents-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/dom/Window/window-resize-contents-expected.txt	2011-09-26 19:57:56 UTC (rev 95981)
@@ -0,0 +1,6 @@
+CONSOLE MESSAGE: line 18: Initial reference node dimensions 800 x 600
+CONSOLE MESSAGE: line 20: Increasing window size by 10 x 10
+CONSOLE MESSAGE: line 22: Post-resize reference node dimensions 810 x 610
+This test checks that the yellow reference DOM node (which should be as big as the window) gets resized when the window is resized.
+
+To avoid relayouts and repaints caused by DOM-based logging, it doesn't output anything. Please check the console for confirmation that the node dimensions increase by 10x10.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96033] trunk/LayoutTests

[mihaip]

Title: [96033] trunk/LayoutTests








Revision 96033
Author mih...@chromium.org
Date 2011-09-26 16:29:34 -0700 (Mon, 26 Sep 2011)


Log Message
Remove failing Chromium test expectations for tests that now pass
(mainly due to r95751, which implemented Function.prototype.bind for
JSC, resulting in baseline updates that now work for V8 too).

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96032 => 96033)

--- trunk/LayoutTests/ChangeLog	2011-09-26 23:26:25 UTC (rev 96032)
+++ trunk/LayoutTests/ChangeLog	2011-09-26 23:29:34 UTC (rev 96033)
@@ -1,3 +1,11 @@
+2011-09-26  Mihai Parparita  mih...@chromium.org
+
+Remove failing Chromium test expectations for tests that now pass
+(mainly due to r95751, which implemented Function.prototype.bind for
+JSC, resulting in baseline updates that now work for V8 too).
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-26  Max Perepelitsyn  pph...@gmail.com
 
 Set but unused variables cleanup in v8 bindings (gcc 4.6)


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96032 => 96033)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-26 23:26:25 UTC (rev 96032)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-26 23:29:34 UTC (rev 96033)
@@ -2078,36 +2078,6 @@
 BUGWK65203 XP : fast/text/international/bidi-mirror-he-ar.html = IMAGE
 BUGWK65203 XP : svg/batik/text/textStyles.svg = IMAGE
 
-
-// These tests all fail because the expected output is wrong. The
-// reason is that JSC does not currently implement Function.prototype.bind
-// These test has intentionally been marked as FAIL, which makes it easy
-// to fix this when webkit implements this ES5 feature.
-BUGWK42371 : ietestcenter/_javascript_/15.2.3.3-4-38.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-0-1.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-0-2.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-13.b-1.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-13.b-2.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-13.b-3.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-13.b-4.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-13.b-5.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-15-1.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-15-2.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-16-1.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-1.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-2.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-3.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-4.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-5.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-6.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-7.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-8.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-2-9.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-8-1.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-8-2.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-9-1.html = FAIL
-BUGWK42371 : ietestcenter/_javascript_/15.3.4.5-9-2.html = FAIL
-
 BUGWK42428 LINUX WIN : svg/W3C-SVG-1.1/filters-conv-01-f.svg = IMAGE+TEXT
 
 // Need setPrinting.
@@ -3322,7 +3292,8 @@
 // After r87526, these all have extra scrollbars where the platform/mac expectations do not.
 BUGWK61664 LINUX : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE
 
-BUGCR84317 : svg/wicd/test-scalable-background-image1.xhtml = CRASH IMAGE
+BUGCR84317 DEBUG : svg/wicd/test-scalable-background-image1.xhtml = CRASH
+BUGCR84317 MAC LEOPARD RELEASE : svg/wicd/test-scalable-background-image1.xhtml = IMAGE
 
 BUGWK61767 WIN DEBUG : http/tests/websocket/tests/hixie76/client-close.html = PASS TEXT
 BUGWK61767 WIN DEBUG : http/tests/websocket/tests/hybi/client-close.html = PASS TEXT
@@ -3625,11 +3596,7 @@
 BUGWK67007 DEBUG : fast/ruby/generated-after-counter-doesnt-crash.html = CRASH
 BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH
 
-BUGWK67204 : fast/multicol/inherit-column-values.html = MISSING FAIL
-BUGWK67204 : fast/multicol/initial-column-values.html = MISSING FAIL
-
 // Failing after r94084. This looks like it may be a real regression.
-
 BUGWK67352 : fast/canvas/webgl/WebGLContextEvent.html = TEXT
 
 BUGWK67433 WIN LINUX : svg/custom/pattern-rotate-gaps.svg = IMAGE
@@ -3664,7 +3631,6 @@
 BUGWK67913 WIN LINUX SNOWLEOPARD : media/video-zoom-controls.html = TEXT
 BUGWK67913 LEOPARD : media/video-zoom-controls.html = TEXT IMAGE+TEXT
 BUGCR96220 : fast/borders/border-image-outset-split-inline-vertical-lr.html = IMAGE
-BUGCR96220 : 

[webkit-changes] [96047] trunk/LayoutTests

[mihaip]

Title: [96047] trunk/LayoutTests








Revision 96047
Author mih...@chromium.org
Date 2011-09-26 17:06:52 -0700 (Mon, 26 Sep 2011)


Log Message
Unreviewed Chromium test expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96046 => 96047)

--- trunk/LayoutTests/ChangeLog	2011-09-27 00:03:07 UTC (rev 96046)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 00:06:52 UTC (rev 96047)
@@ -1,5 +1,11 @@
 2011-09-26  Mihai Parparita  mih...@chromium.org
 
+Unreviewed Chromium test expectations update.
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-26  Mihai Parparita  mih...@chromium.org
+
 Remove failing Chromium test expectations for tests that now pass
 (mainly due to r95751, which implemented Function.prototype.bind for
 JSC, resulting in baseline updates that now work for V8 too).


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96046 => 96047)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 00:03:07 UTC (rev 96046)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 00:06:52 UTC (rev 96047)
@@ -43,7 +43,8 @@
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/dom/Window/window-postmessage-clone-deep-array.html = PASS
 BUGCR24182 SLOW DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/calculate-percentage.html = PASS
-BUGCR24182 SLOW DEBUG : svg/hixie/perf/007.xml = PASS
+BUGCR24182 SLOW DEBUG SNOWLEOPARD: svg/hixie/perf/007.xml = PASS
+BUGCR24182 DEBUG LEOPARD : svg/hixie/perf/007.xml = IMAGE
 
 BUGWK67919 SLOW DEBUG : perf/document-contains.html = PASS
 
@@ -265,7 +266,6 @@
 // We don't ship compositing on Leopard.
 WONTFIX SKIP GPU GPU-CG LEOPARD : compositing = PASS TIMEOUT FAIL
 WONTFIX SKIP GPU GPU-CG LEOPARD : platform/chromium/compositing = PASS TIMEOUT FAIL
-WONTFIX SKIP GPU GPU-CG LEOPARD : platform/chromium/compositing/zoom-animator-scale-test.html = PASS TIMEOUT FAIL
 WONTFIX SKIP GPU GPU-CG LEOPARD : animations/3d = PASS TIMEOUT FAIL
 
 WONTFIX MAC WIN : platform/chromium-linux = FAIL
@@ -2012,7 +2012,6 @@
 BUGWK65203 WIN : fast/text/international/khmer-selection.html = IMAGE
 BUGWK65203 WIN : fast/text/international/thai-baht-space.html = IMAGE
 BUGWK65203 WIN : fast/text/international/thai-line-breaks.html = IMAGE
-BUGWK65203 WIN : media/audio-repaint.html = IMAGE
 BUGWK65203 WIN : platform/win/fast/text/uniscribe-missing-glyph.html = IMAGE
 BUGWK65203 WIN : svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg = IMAGE
 BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-37-t.svg = IMAGE
@@ -2683,6 +2682,8 @@
 BUGWK58587 LINUX GPU DEBUG : media/video-controls-rendering.html = IMAGE
 BUGCR97686 LINUX GPU RELEASE : media/video-controls-rendering.html = IMAGE
 
+BUGWK68852 GPU MAC WIN : platform/chromium/compositing/zoom-animator-scale-test.html = IMAGE
+
 BUGCR72223 : media/video-frame-accurate-seek.html = PASS IMAGE
 
 BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT
@@ -3562,6 +3563,7 @@
 BUGWK66730 WIN : http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html = PASS TEXT
 BUGWK66730 WIN : http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header.html = PASS TEXT
 BUGWK66730 WIN : http/tests/websocket/tests/hybi/masked-frames.html = PASS TEXT
+BUGWK66730 WIN : http/tests/websocket/tests/hybi/close.html = PASS TEXT
 
 BUGWK66217 WIN RELEASE : http/tests/inspector/resource-tree/resource-tree-errors-reload.html = PASS TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96053] trunk/LayoutTests

[mihaip]

Title: [96053] trunk/LayoutTests








Revision 96053
Author mih...@chromium.org
Date 2011-09-26 17:40:40 -0700 (Mon, 26 Sep 2011)


Log Message
Remove failing Chromium expectations for tests that now pass.

Rebaseline repaint tests for Chromium Snow Leopard CG after r96005.

* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96052 => 96053)

--- trunk/LayoutTests/ChangeLog	2011-09-27 00:36:19 UTC (rev 96052)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 00:40:40 UTC (rev 96053)
@@ -1,3 +1,19 @@
+2011-09-26  Mihai Parparita  mih...@chromium.org
+
+Remove failing Chromium expectations for tests that now pass.
+
+Rebaseline repaint tests for Chromium Snow Leopard CG after r96005.
+
+* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
+* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
+* platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png: Added.
+* platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png: Added.
+* platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png: Added.
+* platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
+* platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png: Added.
+* platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-09-26  Tim Horton  timothy_hor...@apple.com
 
 animateColor applied to filtered ellipse does not update


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96052 => 96053)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 00:36:19 UTC (rev 96052)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 00:40:40 UTC (rev 96053)
@@ -2005,15 +2005,6 @@
 BUGWK65203 WIN : fast/borders/border-antialiasing.html = IMAGE
 BUGWK65203 WIN : fast/reflections/reflection-overflow-hidden.html = IMAGE
 BUGWK65203 WIN : fast/repaint/reflection-redraw.html = IMAGE
-BUGWK65203 WIN : fast/text/complex-text-opacity.html = IMAGE
-BUGWK65203 WIN : fast/text/international/complex-character-based-fallback.html = IMAGE
-BUGWK65203 WIN : fast/text/international/danda-space.html = IMAGE
-BUGWK65203 WIN : fast/text/international/hindi-spacing.html = IMAGE
-BUGWK65203 WIN : fast/text/international/khmer-selection.html = IMAGE
-BUGWK65203 WIN : fast/text/international/thai-baht-space.html = IMAGE
-BUGWK65203 WIN : fast/text/international/thai-line-breaks.html = IMAGE
-BUGWK65203 WIN : platform/win/fast/text/uniscribe-missing-glyph.html = IMAGE
-BUGWK65203 WIN : svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg = IMAGE
 BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-37-t.svg = IMAGE
 BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE
 BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE
@@ -3615,9 +3606,9 @@
 BUGCR54348 LINUX RELEASE : http/tests/security/xssAuditor/dom-write-innerHTML.html = PASS TEXT
 BUGWK67538 DEBUG : http/tests/security/xssAuditor/dom-write-innerHTML.html = PASS TEXT
 
-BUG_REED : fast/canvas/canvas-text-baseline.html = IMAGE
-BUG_REED : fast/canvas/quadraticCurveTo.xml = IMAGE
-BUG_REED : fast/canvas/canvas-lineWidth.html = TEXT
+BUG_REED MAC : fast/canvas/canvas-text-baseline.html = IMAGE
+BUG_REED MAC : fast/canvas/quadraticCurveTo.xml 

[webkit-changes] [96058] trunk/LayoutTests

[mihaip]

Title: [96058] trunk/LayoutTests








Revision 96058
Author mih...@chromium.org
Date 2011-09-26 18:13:06 -0700 (Mon, 26 Sep 2011)


Log Message
Chromium test expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96057 => 96058)

--- trunk/LayoutTests/ChangeLog	2011-09-27 00:57:51 UTC (rev 96057)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 01:13:06 UTC (rev 96058)
@@ -1,3 +1,9 @@
+2011-09-26  Mihai Parparita  mih...@chromium.org
+
+Chromium test expectations update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-26  Ryosuke Niwa  rn...@webkit.org
 
 editing/selection/select-bidi-run.html fails on Chromium Windows and Linux


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96057 => 96058)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 00:57:51 UTC (rev 96057)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 01:13:06 UTC (rev 96058)
@@ -3776,3 +3776,5 @@
 
 BUGCR96861 WIN DEBUG : media/audio-repaint.html = TIMEOUT IMAGE PASS
 BUGCR97657 MAC CPU DEBUG : media/audio-repaint.html = TIMEOUT IMAGE PASS
+
+BUGWK68858 : svg/filters/animate-fill.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96065] trunk/LayoutTests

[mihaip]

Title: [96065] trunk/LayoutTests








Revision 96065
Author mih...@chromium.org
Date 2011-09-26 19:07:46 -0700 (Mon, 26 Sep 2011)


Log Message
Put back all Chromium platform failing expectations for some tests (they
still fail on all platforms on the GPU bots).

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96064 => 96065)

--- trunk/LayoutTests/ChangeLog	2011-09-27 01:44:36 UTC (rev 96064)
+++ trunk/LayoutTests/ChangeLog	2011-09-27 02:07:46 UTC (rev 96065)
@@ -1,3 +1,10 @@
+2011-09-26  Mihai Parparita  mih...@chromium.org
+
+Put back all Chromium platform failing expectations for some tests (they
+still fail on all platforms on the GPU bots).
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-26  Kentaro Hara  hara...@chromium.org
 
 Implement a CloseEvent constructor for V8


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96064 => 96065)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 01:44:36 UTC (rev 96064)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-27 02:07:46 UTC (rev 96065)
@@ -3603,9 +3603,9 @@
 BUGCR54348 LINUX RELEASE : http/tests/security/xssAuditor/dom-write-innerHTML.html = PASS TEXT
 BUGWK67538 DEBUG : http/tests/security/xssAuditor/dom-write-innerHTML.html = PASS TEXT
 
-BUG_REED MAC : fast/canvas/canvas-text-baseline.html = IMAGE
-BUG_REED MAC : fast/canvas/quadraticCurveTo.xml = IMAGE
-BUG_REED MAC : fast/canvas/canvas-lineWidth.html = TEXT
+BUG_REED : fast/canvas/canvas-text-baseline.html = IMAGE
+BUG_REED : fast/canvas/quadraticCurveTo.xml = IMAGE
+BUG_REED : fast/canvas/canvas-lineWidth.html = TEXT
 
 BUG_ABARTH WIN : svg/as-background-image/svg-as-background-1.html = PASS IMAGE
 BUG_ABARTH WIN : svg/as-background-image/svg-as-background-3.html = PASS IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95835] branches/chromium/874/LayoutTests/http/tests/history/ back-with-fragment-change.php

[mihaip]

Title: [95835] branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php








Revision 95835
Author mih...@chromium.org
Date 2011-09-23 11:15:04 -0700 (Fri, 23 Sep 2011)


Log Message
Merge 95322 - http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
?php block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the ?php block).

* http/tests/history/back-with-fragment-change.php:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:

TBR=mih...@chromium.org
Review URL: http://codereview.chromium.org/8018010

Modified Paths

branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php




Diff

Modified: branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php (95834 => 95835)

--- branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php	2011-09-23 18:07:33 UTC (rev 95834)
+++ branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php	2011-09-23 18:15:04 UTC (rev 95835)
@@ -1,11 +1,8 @@
-!--
-We intentionally want the page to load slowly (every time, hence no caching), so
-that when back-with-fragment-change-target.html calls history.back(), the load
-is provisional for a while (long enough for the window.location = '#foo' script
-to run and stop that load).
---
 ?php
-
+// We intentionally want the page to load slowly (every time, hence no caching), 
+// so that when back-with-fragment-change-target.html calls history.back(), the
+// load is provisional for a while (long enough for the window.location = '#foo'
+// script to run and stop that load).
 sleep(2);
 
 header(Cache-control: no-cache, no-store);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95838] trunk/LayoutTests

[mihaip]

Title: [95838] trunk/LayoutTests








Revision 95838
Author mih...@chromium.org
Date 2011-09-23 11:41:33 -0700 (Fri, 23 Sep 2011)


Log Message
Mark a test as flaky.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95837 => 95838)

--- trunk/LayoutTests/ChangeLog	2011-09-23 18:24:20 UTC (rev 95837)
+++ trunk/LayoutTests/ChangeLog	2011-09-23 18:41:33 UTC (rev 95838)
@@ -1,3 +1,9 @@
+2011-09-23  Mihai Parparita  mih...@chromium.org
+
+Mark a test as flaky.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-23  Ilya Tikhonovsky  loi...@chromium.org
 
 Unreviewed. Normalize test names.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95837 => 95838)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-23 18:24:20 UTC (rev 95837)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-23 18:41:33 UTC (rev 95838)
@@ -1996,7 +1996,7 @@
 // These should be rebaselined after the patch lands, as we are now drawing
 // all text with skia (instead of gdi) and in these cases, we have differences
 // in antialiasing (drt specific) or in fractional-baselines (gdi rounds in src
-// space, skia rounds in devices space 
+// space, skia rounds in devices space
 BUGWK65203 WIN : fast/borders/border-antialiasing.html = IMAGE
 BUGWK65203 WIN : fast/reflections/reflection-overflow-hidden.html = IMAGE
 BUGWK65203 WIN : fast/repaint/reflection-redraw.html = IMAGE
@@ -3785,3 +3785,5 @@
 BUGWK68674 : fast/js/function-bind.html = TEXT
 
 BUGWK68693 LEOPARD : editing/deleting/merge-whitespace-pre.html = IMAGE PASS
+
+BUGWK68705 MAC WIN : fast/loader/document-destruction-within-unload.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95850] trunk

[mihaip]

Title: [95850] trunk








Revision 95850
Author mih...@chromium.org
Date 2011-09-23 12:46:50 -0700 (Fri, 23 Sep 2011)


Log Message
update layout_tests to account for new default of use_skia=1
https://bugs.webkit.org/show_bug.cgi?id=68698

Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
from http://src.chromium.org/viewvc/chrome?view=revrevision=102532
(Chromium-on-Mac now uses the Skia graphics library instead of
Core Graphics).

Also updates layout_test code to work with that change.

Patch by Elliot Poger epo...@google.com on 2011-09-23
Reviewed by Mihai Parparita.

Source/WebKit/chromium:

* DEPS:

Tools:

* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95849 => 95850)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-23 19:40:09 UTC (rev 95849)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-23 19:46:50 UTC (rev 95850)
@@ -1,3 +1,19 @@
+2011-09-23  Elliot Poger  epo...@google.com
+
+update layout_tests to account for new default of use_skia=1
+https://bugs.webkit.org/show_bug.cgi?id=68698
+
+Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
+from http://src.chromium.org/viewvc/chrome?view=revrevision=102532
+(Chromium-on-Mac now uses the Skia graphics library instead of
+Core Graphics).
+
+Also updates layout_test code to work with that change.
+
+Reviewed by Mihai Parparita.
+
+* DEPS:
+
 2011-09-22  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/DEPS (95849 => 95850)

--- trunk/Source/WebKit/chromium/DEPS	2011-09-23 19:40:09 UTC (rev 95849)
+++ trunk/Source/WebKit/chromium/DEPS	2011-09-23 19:46:50 UTC (rev 95850)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '102247'
+  'chromium_rev': '102532'
 }
 
 deps = {
@@ -110,7 +110,9 @@
   'third_party/libwebp':
 Var('chromium_svn')+'/third_party/libwebp@'+Var('chromium_rev'),
   'tools/grit':
-Var('chromium_svn')+'/tools/grit@'+Var('chromium_rev'),
+From('chromium_deps', 'src/tools/grit'),
+  'tools/gritsettings':
+Var('chromium_svn')+'/tools/gritsettings@'+Var('chromium_rev'),
   'tools/generate_stubs':
 Var('chromium_svn')+'/tools/generate_stubs@'+Var('chromium_rev'),
   'ui':


Modified: trunk/Tools/ChangeLog (95849 => 95850)

--- trunk/Tools/ChangeLog	2011-09-23 19:40:09 UTC (rev 95849)
+++ trunk/Tools/ChangeLog	2011-09-23 19:46:50 UTC (rev 95850)
@@ -1,3 +1,20 @@
+2011-09-23  Elliot Poger  epo...@google.com
+
+update layout_tests to account for new default of use_skia=1
+https://bugs.webkit.org/show_bug.cgi?id=68698
+
+Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
+from http://src.chromium.org/viewvc/chrome?view=revrevision=102532
+(Chromium-on-Mac now uses the Skia graphics library instead of
+Core Graphics).
+
+Also updates layout_test code to work with that change.
+
+Reviewed by Mihai Parparita.
+
+* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
+
 2011-09-23  Mark Rowe  mr...@apple.com
 
 Fix the build.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py (95849 => 95850)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py	2011-09-23 19:40:09 UTC (rev 95849)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py	2011-09-23 19:46:50 UTC (rev 95850)
@@ -92,7 +92,7 @@
 def __init__(self, port_name=None, os_version_string=None, **kwargs):
 # We're a little generic here because this code is reused by the
 # 'google-chrome' port as well as the 'mock-' and 'dryrun-' ports.
-port_name = port_name or 'chromium-cg-mac'  # FIXME: Change the default to chromium-mac once we're ready.
+port_name = port_name or 'chromium-mac'
 chromium.ChromiumPort.__init__(self, port_name=port_name, **kwargs)
 if port_name.endswith('-mac'):
 self._version = mac.os_version(os_version_string, self.SUPPORTED_OS_VERSIONS)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py (95849 => 95850)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py	2011-09-23 19:40:09 UTC (rev 95849)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py	2011-09-23 19:46:50 UTC (rev 95850)
@@ -51,44 +51,44 @@
 
 def test_versions(self):
 port = chromium_mac.ChromiumMacPort()
-

[webkit-changes] [95387] trunk/Source

[mihaip]

Title: [95387] trunk/Source








Revision 95387
Author mih...@chromium.org
Date 2011-09-17 16:31:52 -0700 (Sat, 17 Sep 2011)


Log Message
FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* history/BackForwardListImpl.cpp:
(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* src/FrameLoaderClientImpl.cpp:
* src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
* WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.order:

Source/WebKit/qt:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientQt.cpp:
* WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
* WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebKitSupport/FrameLoaderClientWx.cpp:
* WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/BackForwardListImpl.cpp
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h
trunk/Source/WebKit/haiku/ChangeLog
trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp
trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit/mac/WebKit.order
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit/wince/ChangeLog
trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp
trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h
trunk/Source/WebKit/wx/ChangeLog
trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp
trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (95386 => 95387)

--- trunk/Source/WebCore/ChangeLog	2011-09-17 23:12:16 UTC (rev 95386)
+++ 

[webkit-changes] [95322] trunk/LayoutTests

[mihaip]

Title: [95322] trunk/LayoutTests








Revision 95322
Author mih...@chromium.org
Date 2011-09-16 13:43:41 -0700 (Fri, 16 Sep 2011)


Log Message
http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
?php block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the ?php block).

* http/tests/history/back-with-fragment-change.php:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/history/back-with-fragment-change.php
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (95321 => 95322)

--- trunk/LayoutTests/ChangeLog	2011-09-16 20:42:19 UTC (rev 95321)
+++ trunk/LayoutTests/ChangeLog	2011-09-16 20:43:41 UTC (rev 95322)
@@ -1,3 +1,17 @@
+2011-09-16  Mihai Parparita  mih...@chromium.org
+
+http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
+https://bugs.webkit.org/show_bug.cgi?id=68242
+
+Skip test on ports on which it fails. Move comment to be inside
+?php block so that HTTP headers can be set on all platforms (there
+must not be any whitespace before the ?php block).
+
+* http/tests/history/back-with-fragment-change.php:
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+
 2011-09-16  Cary Clark  carycl...@google.com
 Unreviewed; new expectations (Skia on Mac)
 


Modified: trunk/LayoutTests/http/tests/history/back-with-fragment-change.php (95321 => 95322)

--- trunk/LayoutTests/http/tests/history/back-with-fragment-change.php	2011-09-16 20:42:19 UTC (rev 95321)
+++ trunk/LayoutTests/http/tests/history/back-with-fragment-change.php	2011-09-16 20:43:41 UTC (rev 95322)
@@ -1,11 +1,8 @@
-!--
-We intentionally want the page to load slowly (every time, hence no caching), so
-that when back-with-fragment-change-target.html calls history.back(), the load
-is provisional for a while (long enough for the window.location = '#foo' script
-to run and stop that load).
---
 ?php
-
+// We intentionally want the page to load slowly (every time, hence no caching), 
+// so that when back-with-fragment-change-target.html calls history.back(), the
+// load is provisional for a while (long enough for the window.location = '#foo'
+// script to run and stop that load).
 sleep(2);
 
 header(Cache-control: no-cache, no-store);


Modified: trunk/LayoutTests/platform/gtk/Skipped (95321 => 95322)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-09-16 20:42:19 UTC (rev 95321)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-09-16 20:43:41 UTC (rev 95322)
@@ -1632,3 +1632,6 @@
 
 # https://bugs.webkit.org/show_bug.cgi?id=67713
 accessibility/textbox-role-reports-selection.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=68278
+http/tests/history/back-with-fragment-change.php


Modified: trunk/LayoutTests/platform/mac/Skipped (95321 => 95322)

--- trunk/LayoutTests/platform/mac/Skipped	2011-09-16 20:42:19 UTC (rev 95321)
+++ trunk/LayoutTests/platform/mac/Skipped	2011-09-16 20:43:41 UTC (rev 95322)
@@ -417,3 +417,6 @@
 
 # https://bugs.webkit.org/show_bug.cgi?id=67716
 media/media-controls-invalid-url.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=68278
+http/tests/history/back-with-fragment-change.php


Modified: trunk/LayoutTests/platform/qt/Skipped (95321 => 95322)

--- trunk/LayoutTests/platform/qt/Skipped	2011-09-16 20:42:19 UTC (rev 95321)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-09-16 20:43:41 UTC (rev 95322)
@@ -2428,3 +2428,7 @@
 # [Qt] One test failed after r95203
 # https://bugs.webkit.org/show_bug.cgi?id=68233
 editing/pasteboard/paste-noscript.html
+
+# Fails on non-Chromium bots
+# https://bugs.webkit.org/show_bug.cgi?id=68278
+http/tests/history/back-with-fragment-change.php






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95259] trunk

[mihaip]

Title: [95259] trunk








Revision 95259
Author mih...@chromium.org
Date 2011-09-15 19:16:46 -0700 (Thu, 15 Sep 2011)


Log Message
Fragment navigations should interrupt a provisional load of a different document
https://bugs.webkit.org/show_bug.cgi?id=64556

Source/WebCore:

Reviewed by Adam Barth.

Tests: http/tests/history/back-with-fragment-change.php
   http/tests/navigation/navigation-interrupted-by-fragment.html

* loader/FrameLoader.cpp: Stop provisional load if a fragment commits.
* loader/HistoryController.cpp: Don't commit the wrong provisional item.

LayoutTests:

Reviewed by Adam Barth.

Required page-dismissal-modal-dialogs-iframe.html to be updated since
the dummy a href="" link was clicked after the provisional load was
kicked off, thus causing it to to be aborted.

* fast/loader/page-dismissal-modal-dialogs.html:
* fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
* http/tests/history/back-with-fragment-change-expected.txt: Added.
* http/tests/history/back-with-fragment-change.php: Added.
* http/tests/history/resources/back-with-fragment-change-target.html: Added.
* http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
* http/tests/navigation/navigation-interrupted-by-fragment.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/loader/page-dismissal-modal-dialogs.html
trunk/LayoutTests/fast/loader/resources/page-dismissal-modal-dialogs-iframe.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/HistoryController.cpp


Added Paths

trunk/LayoutTests/http/tests/history/back-with-fragment-change-expected.txt
trunk/LayoutTests/http/tests/history/back-with-fragment-change.php
trunk/LayoutTests/http/tests/history/resources/back-with-fragment-change-target.html
trunk/LayoutTests/http/tests/navigation/navigation-interrupted-by-fragment-expected.txt
trunk/LayoutTests/http/tests/navigation/navigation-interrupted-by-fragment.html




Diff

Modified: trunk/LayoutTests/ChangeLog (95258 => 95259)

--- trunk/LayoutTests/ChangeLog	2011-09-16 02:14:07 UTC (rev 95258)
+++ trunk/LayoutTests/ChangeLog	2011-09-16 02:16:46 UTC (rev 95259)
@@ -1,3 +1,22 @@
+2011-09-15  Mihai Parparita  mih...@chromium.org
+
+Fragment navigations should interrupt a provisional load of a different document
+https://bugs.webkit.org/show_bug.cgi?id=64556
+
+Reviewed by Adam Barth.
+
+Required page-dismissal-modal-dialogs-iframe.html to be updated since
+the dummy a href="" link was clicked after the provisional load was
+kicked off, thus causing it to to be aborted.
+
+* fast/loader/page-dismissal-modal-dialogs.html:
+* fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
+* http/tests/history/back-with-fragment-change-expected.txt: Added.
+* http/tests/history/back-with-fragment-change.php: Added.
+* http/tests/history/resources/back-with-fragment-change-target.html: Added.
+* http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
+* http/tests/navigation/navigation-interrupted-by-fragment.html: Added.
+
 2011-09-15  Keishi Hattori  kei...@webkit.org
 
 [chromium] skipping tests due to r95188


Modified: trunk/LayoutTests/fast/loader/page-dismissal-modal-dialogs.html (95258 => 95259)

--- trunk/LayoutTests/fast/loader/page-dismissal-modal-dialogs.html	2011-09-16 02:14:07 UTC (rev 95258)
+++ trunk/LayoutTests/fast/loader/page-dismissal-modal-dialogs.html	2011-09-16 02:16:46 UTC (rev 95259)
@@ -29,7 +29,7 @@
 }, false);
 /script/headbodydiv
 
-a href=# _onclick_=showMessages('mainFrame click') id=anchoranchor/a
+span _onclick_=showMessages('mainFrame click') id=anchoranchor/span
 iframe src=""
 
 This page registers handlers for various types of unload events and attempts to


Modified: trunk/LayoutTests/fast/loader/resources/page-dismissal-modal-dialogs-iframe.html (95258 => 95259)

--- trunk/LayoutTests/fast/loader/resources/page-dismissal-modal-dialogs-iframe.html	2011-09-16 02:14:07 UTC (rev 95258)
+++ trunk/LayoutTests/fast/loader/resources/page-dismissal-modal-dialogs-iframe.html	2011-09-16 02:16:46 UTC (rev 95259)
@@ -2,5 +2,5 @@
 htmlheadmeta charset=utf-8titlePage Dismissal Modal Dialogs iFrame/titlescript
 parent.registerEvents(iFrame, window, parent);
 /script/headbodydiv
-a href=# _onclick_=parent.showMessages('iFrame click') id=anchoranchor/a
+span _onclick_=parent.showMessages('iFrame click') id=anchoranchor/span
 /div/body/html


Added: trunk/LayoutTests/http/tests/history/back-with-fragment-change-expected.txt (0 => 95259)

--- trunk/LayoutTests/http/tests/history/back-with-fragment-change-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/history/back-with-fragment-change-expected.txt	2011-09-16 02:16:46 UTC (rev 95259)
@@ -0,0 +1,9 @@
+main frame - has 1 onunload handler(s)
+CONSOLE MESSAGE: line 19: Visited fragment 

[webkit-changes] [95035] trunk/Source/WebCore

[mihaip]

Title: [95035] trunk/Source/WebCore








Revision 95035
Author mih...@chromium.org
Date 2011-09-13 11:25:26 -0700 (Tue, 13 Sep 2011)


Log Message
[Chromium] Remove _javascript__engine from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=68001

Reviewed by Tony Chang.

Remove _javascript__engine GYP variable (similar to the removal done on
the Chromium side with http://crrev.com/100692)

* WebCore.gyp/WebCore.gyp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95034 => 95035)

--- trunk/Source/WebCore/ChangeLog	2011-09-13 17:58:02 UTC (rev 95034)
+++ trunk/Source/WebCore/ChangeLog	2011-09-13 18:25:26 UTC (rev 95035)
@@ -1,3 +1,15 @@
+2011-09-13  Mihai Parparita  mih...@chromium.org
+
+[Chromium] Remove _javascript__engine from WebCore.gyp
+https://bugs.webkit.org/show_bug.cgi?id=68001
+
+Reviewed by Tony Chang.
+
+Remove _javascript__engine GYP variable (similar to the removal done on
+the Chromium side with http://crrev.com/100692)
+
+* WebCore.gyp/WebCore.gyp:
+
 2011-09-12  Ryosuke Niwa  rn...@webkit.org
 
 [CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand.


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (95034 => 95035)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-09-13 17:58:02 UTC (rev 95034)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-09-13 18:25:26 UTC (rev 95035)
@@ -131,10 +131,6 @@
 # binary and increasing the speed of gdb.
 'enable_svg%': 1,
 
-# Use v8 as default _javascript_ engine. This makes sure that _javascript__engine variable
-# is set for both inside_chromium_build 0 and 1 cases.
-'_javascript__engine%': 'v8',
-
 'webcore_include_dirs': [
   '../',
   '../..',
@@ -956,6 +952,7 @@
 '(chromium_src_dir)/third_party/libwebp/libwebp.gyp:libwebp',
 '(chromium_src_dir)/third_party/npapi/npapi.gyp:npapi',
 '(chromium_src_dir)/third_party/sqlite/sqlite.gyp:sqlite',
+'(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
 '(libjpeg_gyp_path):libjpeg',
   ],
   'include_dirs': [
@@ -1010,17 +1007,10 @@
 '(SHARED_INTERMEDIATE_DIR)/webcore/InspectorBackendDispatcher.cpp',
   ],
   'conditions': [
-['_javascript__engine==v8', {
-  'dependencies': [
-'(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
+['inside_chromium_build==1 and OS==win and component==shared_library', {
+  'defines': [
+'USING_V8_SHARED',
   ],
-  'conditions': [
-['inside_chromium_build==1 and OS==win and component==shared_library', {
-  'defines': [
-'USING_V8_SHARED',
-  ],
-}],
-  ],
 }],
 # TODO(maruel): Move it in its own project or generate it anyway?
 ['enable_svg!=0', {
@@ -1080,6 +1070,7 @@
 '(chromium_src_dir)/third_party/ots/ots.gyp:ots',
 '(chromium_src_dir)/third_party/sqlite/sqlite.gyp:sqlite',
 '(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_common',
+'(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
 '(libjpeg_gyp_path):libjpeg',
   ],
   'export_dependent_settings': [
@@ -1096,6 +1087,7 @@
 '(chromium_src_dir)/third_party/ots/ots.gyp:ots',
 '(chromium_src_dir)/third_party/sqlite/sqlite.gyp:sqlite',
 '(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_common',
+'(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
 '(libjpeg_gyp_path):libjpeg',
   ],
   # This is needed for mac because of webkit_system_interface. It'd be nice
@@ -1128,22 +1120,12 @@
 },
   },
   'conditions': [
-['_javascript__engine==v8', {
-  'dependencies': [
-'(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
-  ],
-  'export_dependent_settings': [
-'(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
-  ],
-  'conditions': [
-['inside_chromium_build==1 and OS==win and component==shared_library', {
-  'direct_dependent_settings': {
-'defines': [
-  'USING_V8_SHARED',
-],
-  },
-}],
-  ],
+['inside_chromium_build==1 and OS==win and component==shared_library', {
+  'direct_dependent_settings': {
+'defines': [
+   'USING_V8_SHARED',
+],
+  },
 }],
 ['use_accelerated_compositing==1', {
   'dependencies': [
@@ -1655,6 +1637,7 @@
   'type': 'static_library',
   'dependencies': [
 'webcore_prerequisites',
+'(chromium_src_dir)/third_party/v8-i18n/build/all.gyp:v8-i18n',
   ],
   # This is needed for mac because of webkit_system_interface. It'd be nice
   # if this hard dependency could be 

[webkit-changes] [91951] trunk/Source/WebKit/chromium

[mihaip]

Title: [91951] trunk/Source/WebKit/chromium








Revision 91951
Author mih...@chromium.org
Date 2011-07-28 15:00:51 -0700 (Thu, 28 Jul 2011)


Log Message
[Chromium] Remove WebDocument::insertStyleText
https://bugs.webkit.org/show_bug.cgi?id=65332

Reviewed by Tony Chang.

As of http://crrev.com/94499 no Chromium code calls this anymore.
Also does a bit of #include cleanup.

* public/WebDocument.h:
* src/WebDocument.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDocument.h
trunk/Source/WebKit/chromium/src/WebDocument.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (91950 => 91951)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-07-28 21:38:36 UTC (rev 91950)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-07-28 22:00:51 UTC (rev 91951)
@@ -1,3 +1,16 @@
+2011-07-28  Mihai Parparita  mih...@chromium.org
+
+[Chromium] Remove WebDocument::insertStyleText
+https://bugs.webkit.org/show_bug.cgi?id=65332
+
+Reviewed by Tony Chang.
+
+As of http://crrev.com/94499 no Chromium code calls this anymore.
+Also does a bit of #include cleanup.
+
+* public/WebDocument.h:
+* src/WebDocument.cpp:
+
 2011-07-27  Fady Samuel  fsam...@chromium.org
 
 Added a Chromium WebKit API method to set the minimum row height of a popup listbox.


Modified: trunk/Source/WebKit/chromium/public/WebDocument.h (91950 => 91951)

--- trunk/Source/WebKit/chromium/public/WebDocument.h	2011-07-28 21:38:36 UTC (rev 91950)
+++ trunk/Source/WebKit/chromium/public/WebDocument.h	2011-07-28 22:00:51 UTC (rev 91951)
@@ -31,9 +31,9 @@
 #ifndef WebDocument_h
 #define WebDocument_h
 
-#include WebFormElement.h
 #include WebNode.h
 #include WebSecurityOrigin.h
+#include WebVector.h
 
 #if WEBKIT_IMPLEMENTATION
 namespace WebCore {
@@ -47,6 +47,7 @@
 class WebAccessibilityObject;
 class WebDocumentType;
 class WebElement;
+class WebFormElement;
 class WebFrame;
 class WebNodeCollection;
 class WebNodeList;
@@ -99,15 +100,6 @@
 WEBKIT_API WebDocumentType doctype() const;
 WEBKIT_API WebAccessibilityObject accessibilityObject() const;
 
-// Insert the given text as a STYLE element at the beginning of the
-// document. |elementId| can be empty, but if specified then it is used
-// as the id for the newly inserted element (replacing an existing one
-// with the same id, if any).
-// FIXME: Remove this once Chromium callers have been updated to call
-// insertUserStyleSheet instead.
-WEBKIT_API bool insertStyleText(const WebString styleText,
-const WebString elementId);
-
 // Inserts the given CSS source code as a user stylesheet in the document.
 // Meant for programatic/one-off injection, as opposed to
 // WebView::addUserStyleSheet which inserts styles for the lifetime of the


Modified: trunk/Source/WebKit/chromium/src/WebDocument.cpp (91950 => 91951)

--- trunk/Source/WebKit/chromium/src/WebDocument.cpp	2011-07-28 21:38:36 UTC (rev 91950)
+++ trunk/Source/WebKit/chromium/src/WebDocument.cpp	2011-07-28 22:00:51 UTC (rev 91951)
@@ -43,12 +43,12 @@
 #include HTMLElement.h
 #include HTMLFormElement.h
 #include HTMLHeadElement.h
-#include HTMLNames.h
 #include NodeList.h
 
 #include WebAccessibilityObject.h
 #include WebDocumentType.h
 #include WebElement.h
+#include WebFormElement.h
 #include WebFrameImpl.h
 #include WebNodeCollection.h
 #include WebNodeList.h
@@ -179,35 +179,6 @@
 document-axObjectCache()-getOrCreate(document-renderer()));
 }
 
-bool WebDocument::insertStyleText(const WebString styleText, const WebString elementId)
-{
-RefPtrDocument document = unwrapDocument();
-RefPtrElement documentElement = document-documentElement();
-if (!documentElement)
-return false;
-
-ExceptionCode err = 0;
-
-if (!elementId.isEmpty()) {
-Element* oldElement = document-getElementById(elementId);
-if (oldElement) {
-Node* parent = oldElement-parentNode();
-if (!parent)
-return false;
-parent-removeChild(oldElement, err);
-}
-}
-
-RefPtrElement stylesheet = document-createElement(HTMLNames::styleTag, false);
-if (!elementId.isEmpty())
-stylesheet-setAttribute(HTMLNames::idAttr, elementId);
-stylesheet-setTextContent(styleText, err);
-ASSERT(!err);
-bool success = documentElement-insertBefore(stylesheet, documentElement-firstChild(), err);
-ASSERT(success);
-return success;
-}
-
 void WebDocument::insertUserStyleSheet(const WebString sourceCode, UserStyleLevel level)
 {
 RefPtrDocument document = unwrapDocument();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [91860] trunk/Source

[mihaip]

Title: [91860] trunk/Source








Revision 91860
Author mih...@chromium.org
Date 2011-07-27 11:34:07 -0700 (Wed, 27 Jul 2011)


Log Message
[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
https://bugs.webkit.org/show_bug.cgi?id=65158

Reviewed by David Hyatt.

Source/WebCore:

Add per-Document instance user stylesheets (as opposed to the page
group user styles and the global page stylesheet).

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore::Document::addUserSheet):
* dom/Document.h:

Source/WebKit/chromium:

Add WebDocument::insertUserStyleSheet which inserts a user stylesheet,
instead of forcing extensions to use insertStyleText which manipulates
the DOM of the page and results in compatibility issues (see
http://crbug.com/82220).

* public/WebDocument.h:
* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDocument.h
trunk/Source/WebKit/chromium/src/WebDocument.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (91859 => 91860)

--- trunk/Source/WebCore/ChangeLog	2011-07-27 18:32:45 UTC (rev 91859)
+++ trunk/Source/WebCore/ChangeLog	2011-07-27 18:34:07 UTC (rev 91860)
@@ -1,3 +1,22 @@
+2011-07-25  Mihai Parparita  mih...@chromium.org
+
+[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
+https://bugs.webkit.org/show_bug.cgi?id=65158
+
+Reviewed by David Hyatt.
+
+Add per-Document instance user stylesheets (as opposed to the page 
+group user styles and the global page stylesheet).
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::CSSStyleSelector):
+* css/CSSStyleSelector.h:
+* dom/Document.cpp:
+(WebCore::Document::~Document):
+(WebCore::Document::createStyleSelector):
+(WebCore::Document::addUserSheet):
+* dom/Document.h:
+
 2011-07-27  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Disable cache option should only clear memory cache, not disable it.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (91859 => 91860)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-07-27 18:32:45 UTC (rev 91859)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-07-27 18:34:07 UTC (rev 91860)
@@ -429,7 +429,7 @@
 }
 
 CSSStyleSelector::CSSStyleSelector(Document* document, StyleSheetList* styleSheets, CSSStyleSheet* mappedElementSheet,
-   CSSStyleSheet* pageUserSheet, const VectorRefPtrCSSStyleSheet * pageGroupUserSheets,
+   CSSStyleSheet* pageUserSheet, const VectorRefPtrCSSStyleSheet * pageGroupUserSheets, const VectorRefPtrCSSStyleSheet * documentUserSheets,
bool strictParsing, bool matchAuthorAndUserStyles)
 : m_backgroundData(BackgroundFillLayer)
 , m_checker(document, strictParsing)
@@ -486,6 +486,15 @@
 m_authorStyle-addRulesFromSheet(pageGroupUserSheets-at(i).get(), *m_medium, this);
 }
 }
+if (documentUserSheets) {
+unsigned length = documentUserSheets-size();
+for (unsigned i = 0; i  length; i++) {
+if (documentUserSheets-at(i)-isUserStyleSheet())
+tempUserStyle-addRulesFromSheet(documentUserSheets-at(i).get(), *m_medium, this);
+else
+m_authorStyle-addRulesFromSheet(documentUserSheets-at(i).get(), *m_medium, this);
+}
+}
 
 if (tempUserStyle-m_ruleCount  0 || tempUserStyle-m_pageRules.size()  0)
 m_userStyle = tempUserStyle.release();


Modified: trunk/Source/WebCore/css/CSSStyleSelector.h (91859 => 91860)

--- trunk/Source/WebCore/css/CSSStyleSelector.h	2011-07-27 18:32:45 UTC (rev 91859)
+++ trunk/Source/WebCore/css/CSSStyleSelector.h	2011-07-27 18:34:07 UTC (rev 91860)
@@ -90,7 +90,7 @@
 WTF_MAKE_NONCOPYABLE(CSSStyleSelector); WTF_MAKE_FAST_ALLOCATED;
 public:
 CSSStyleSelector(Document*, StyleSheetList* authorSheets, CSSStyleSheet* mappedElementSheet,
- CSSStyleSheet* pageUserSheet, const VectorRefPtrCSSStyleSheet * pageGroupUserSheets,
+ CSSStyleSheet* pageUserSheet, const VectorRefPtrCSSStyleSheet * pageGroupUserSheets, const VectorRefPtrCSSStyleSheet * documentUserSheets,
  bool strictParsing, bool matchAuthorAndUserStyles);
 ~CSSStyleSelector();
 


Modified: trunk/Source/WebCore/dom/Document.cpp (91859 => 91860)

--- trunk/Source/WebCore/dom/Document.cpp	2011-07-27 18:32:45 UTC (rev 91859)
+++ 

[webkit-changes] [90473] trunk/LayoutTests

[mihaip]

Title: [90473] trunk/LayoutTests








Revision 90473
Author mih...@chromium.org
Date 2011-07-06 11:26:35 -0700 (Wed, 06 Jul 2011)


Log Message
2011-07-06  Mihai Parparita  mih...@chromium.org

Remove Chromium Mac failing expectation for fast/text/font-size-zero.html
(fixed by r89933)

Add Chromium Windows and Linux baselines for
fast/forms/textfield-overflow-by-value-update.html (needed due to
different form control metrics).

Remove a bunch of commented out test expectations.

* platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt: Removed.
* platform/chromium-win/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-win/fast/forms/textfield-overflow-by-value-update-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90472 => 90473)

--- trunk/LayoutTests/ChangeLog	2011-07-06 18:13:59 UTC (rev 90472)
+++ trunk/LayoutTests/ChangeLog	2011-07-06 18:26:35 UTC (rev 90473)
@@ -1,3 +1,18 @@
+2011-07-06  Mihai Parparita  mih...@chromium.org
+
+Remove Chromium Mac failing expectation for fast/text/font-size-zero.html
+(fixed by r89933)
+
+Add Chromium Windows and Linux baselines for
+fast/forms/textfield-overflow-by-value-update.html (needed due to
+different form control metrics).
+
+Remove a bunch of commented out test expectations.
+
+* platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt: Removed.
+* platform/chromium-win/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-07-06  Nate Chapin  jap...@chromium.org
 
 Test updates for https://bugs.webkit.org/show_bug.cgi?id=62066.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90472 => 90473)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 18:13:59 UTC (rev 90472)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 18:26:35 UTC (rev 90473)
@@ -929,15 +929,8 @@
 BUGWK62974 LEOPARD : svg/batik/text/xmlSpace.svg = IMAGE
 BUGWK62974 WIN : svg/custom/glyph-selection-lang-attribute.svg = IMAGE+TEXT
 BUGWK62974 LINUX : svg/custom/glyph-selection-lang-attribute.svg = IMAGE
-//BUGWK62974 WIN LINUX : svg/custom/svg-fonts-fallback.xhtml = IMAGE+TEXT
-//BUGWK62974 LEOPARD : svg/custom/svg-fonts-fallback.xhtml = IMAGE
-//BUGWK62974 WIN LINUX : svg/custom/svg-fonts-segmented.xhtml = IMAGE+TEXT
-//BUGWK62974 WIN LINUX : svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT
-//BUGWK62974 MAC : svg/custom/svg-fonts-word-spacing.html = IMAGE
 BUGWK62974 WIN LINUX : svg/text/text-altglyph-01-b.svg = IMAGE+TEXT
 BUGWK62974 MAC : svg/text/text-altglyph-01-b.svg = IMAGE
-//BUGWK62974 WIN LINUX : svg/text/text-overflow-ellipsis-svgfont.html = IMAGE+TEXT
-//BUGWK62974 LEOPARD : svg/text/text-overflow-ellipsis-svgfont.html = IMAGE
 BUGWK62974 WIN LINUX : svg/text/text-text-04-t.svg = IMAGE+TEXT
 BUGWK62974 MAC : svg/text/text-text-04-t.svg = IMAGE
 BUGWK62974 WIN LINUX : svg/text/text-text-05-t.svg = IMAGE+TEXT
@@ -2241,10 +2234,6 @@
 // Application Cache Quotas
 BUGWK43459 : http/tests/appcache/origin-quota.html = TEXT MISSING
 
-// Fixed only on Mac
-// This test has not landed yet, though the fix has.
-//BUGWK41968 LINUX WIN : svg/hittest/svg-rect-hit.html = TEXT
-
 // Need to support DeviceMotion.
 BUGCR51416 : fast/dom/DeviceMotion/window-property.html = TEXT
 
@@ -2490,14 +2479,6 @@
 BUGWK61161 LINUX WIN : fast/blockflow/border-image-vertical-rl.html = IMAGE+TEXT
 BUGWK61161 LINUX WIN : fast/blockflow/border-image-vertical-lr.html = IMAGE+TEXT
 
-// Started to ASSERT at some point at or after WK r80582
-// see BUGCR75426 list
-
-// New test, added in http://trac.webkit.org/changeset/70814.
-//
-// We're passing it but possibly by sheer luck. Needs investigation.
-//BUGCR61166 LINUX MAC WIN : media/video-seek-by-small-increment.html = TEXT
-
 // These tests started failing presumably after r70850
 BUGWK48627 LEOPARD : fast/invalid/missing-end-tag.xhtml = IMAGE
 BUGWK48627 MAC : svg/custom/createImageElement2.xhtml = IMAGE
@@ -2758,10 +2739,8 @@
 // New test added in r75720
 BUGCR69571 : plugins/destroy-on-setwindow.html = CRASH TEXT
 
-// Failing after r75768
-// BUGCR69639 : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT
-// Times out after r89503
-BUGWK63227 : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT TIMEOUT
+// Failing after r75768, times out after r89503
+BUGCR69639 BUGWK63227 : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT TIMEOUT
 
 // Behavior changed in http://trac.webkit.org/changeset/76180,

[webkit-changes] [90494] trunk/LayoutTests

[mihaip]

Title: [90494] trunk/LayoutTests








Revision 90494
Author mih...@chromium.org
Date 2011-07-06 13:58:58 -0700 (Wed, 06 Jul 2011)


Log Message
2011-07-06  Mihai Parparita  mih...@chromium.org

Add Chromium flaky expectations.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90493 => 90494)

--- trunk/LayoutTests/ChangeLog	2011-07-06 20:58:17 UTC (rev 90493)
+++ trunk/LayoutTests/ChangeLog	2011-07-06 20:58:58 UTC (rev 90494)
@@ -1,3 +1,9 @@
+2011-07-06  Mihai Parparita  mih...@chromium.org
+
+Add Chromium flaky expectations.
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-06  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION (r90275): 18 editing tests failing on Windows 7 Release (WebKit2 Tests)


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90493 => 90494)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 20:58:17 UTC (rev 90493)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 20:58:58 UTC (rev 90494)
@@ -3929,7 +3929,7 @@
 
 BUGWK63509 : editing/style/smoosh-styles-003.html = PASS IMAGE
 BUGCR88230 VISTA : fast/dom/dom-parse-serialize-display.html = PASS TIMEOUT
-BUGCR88232 WIN DEBUG : fast/dom/non-numeric-values-numeric-parameters.html = CRASH PASS
+BUGCR88232 WIN DEBUG : fast/dom/non-numeric-values-numeric-parameters.html = CRASH PASS MISSING
 
 // Quota enforcement not yet implemented for LevelDB back-end.
 BUGCR83652 : storage/indexeddb/database-quota.html = TEXT
@@ -3945,3 +3945,6 @@
 // Started around WebKit r90233:r90242
 BUGWK64000 SNOWLEOPARD DEBUG : fast/events/click-focus-anchor.html = PASS TEXT
 BUGWK64003 MAC DEBUG : media/video-delay-load-event.html = PASS TEXT
+
+BUGCR88588 : fast/lists/inlineBoxWrapperNullCheck.html = PASS TEXT
+BUGWK64028 WIN LINUX : media/adopt-node-crash.html = CRASH PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90500] trunk/LayoutTests

[mihaip]

Title: [90500] trunk/LayoutTests








Revision 90500
Author mih...@chromium.org
Date 2011-07-06 14:20:17 -0700 (Wed, 06 Jul 2011)


Log Message
2011-07-06  Mihai Parparita  mih...@chromium.org

Add Chromium Windows 7 timeout expectations.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90499 => 90500)

--- trunk/LayoutTests/ChangeLog	2011-07-06 21:19:22 UTC (rev 90499)
+++ trunk/LayoutTests/ChangeLog	2011-07-06 21:20:17 UTC (rev 90500)
@@ -1,5 +1,11 @@
 2011-07-06  Mihai Parparita  mih...@chromium.org
 
+Add Chromium Windows 7 timeout expectations.
+
+* platform/chromium/test_expectations.txt:
+
+2011-07-06  Mihai Parparita  mih...@chromium.org
+
 Add Chromium flaky expectations.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90499 => 90500)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 21:19:22 UTC (rev 90499)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 21:20:17 UTC (rev 90500)
@@ -3948,3 +3948,24 @@
 
 BUGCR88588 : fast/lists/inlineBoxWrapperNullCheck.html = PASS TEXT
 BUGWK64028 WIN LINUX : media/adopt-node-crash.html = CRASH PASS
+
+BUGCR88594 WIN7 : fast/loader/recursive-before-unload-crash.html = TIMEOUT
+BUGCR88594 WIN7 : fast/storage/storage-detached-iframe.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/access-via-redirect.php = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/crash-when-navigating-away-then-back.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/credential-url.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/deferred-events-delete-while-raising.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/deferred-events.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/different-scheme.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/document-write-html-element-2.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/foreign-fallback.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/interrupted-update.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/local-content.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/main-resource-hash.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/manifest-containing-itself.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/manifest-parsing.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/manifest-with-empty-file.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/online-fallback-layering.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/online-whitelist.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/progress-counter.html = TIMEOUT
+BUGCR88594 WIN7 : http/tests/appcache/reload.html = TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90516] trunk/LayoutTests

[mihaip]

Title: [90516] trunk/LayoutTests








Revision 90516
Author mih...@chromium.org
Date 2011-07-06 16:49:25 -0700 (Wed, 06 Jul 2011)


Log Message
2011-07-06  Mihai Parparita  mih...@chromium.org

Update Chromium GPU expectations with downstream changes
(http://crrev.com/91625/).

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90515 => 90516)

--- trunk/LayoutTests/ChangeLog	2011-07-06 23:38:32 UTC (rev 90515)
+++ trunk/LayoutTests/ChangeLog	2011-07-06 23:49:25 UTC (rev 90516)
@@ -1,3 +1,10 @@
+2011-07-06  Mihai Parparita  mih...@chromium.org
+
+Update Chromium GPU expectations with downstream changes
+(http://crrev.com/91625/).
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-06  Sreeram Ramachandran  sree...@chromium.org
 
 Fix fast/loader/page-dismissal-modal-dialogs.html.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90515 => 90516)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 23:38:32 UTC (rev 90515)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-06 23:49:25 UTC (rev 90516)
@@ -3559,7 +3559,7 @@
 
 // Flakiness on canaries (noted ~ r85140)
 BUGKBR WIN DEBUG : fast/filesystem/file-writer-truncate-extend.html = PASS TEXT
-BUGKBR WIN LINUX DEBUG : fast/events/change-overflow-on-overflow-change.html = PASS TIMEOUT
+BUGKBR DEBUG : fast/events/change-overflow-on-overflow-change.html = PASS TIMEOUT
 
 // Flakiness on canaries (noted ~ r85220)
 BUGKBR WIN : editing/input/option-page-up-down.html = PASS TEXT
@@ -3947,3 +3947,8 @@
 BUGCR88594 WIN7 : http/tests/appcache/resource-redirect.html = TIMEOUT
 BUGCR88594 WIN7 : http/tests/appcache/manifest-redirect-2.html = TIMEOUT PASS
 BUGCR88594 WIN7 : http/tests/appcache/fallback.html = TIMEOUT
+
+// Started failing in skia roll r1788:r1799
+BUGCR88577 WIN LINUX GPU : canvas/philip/tests/2d.pattern.repeat.empty.html = TEXT
+BUGCR88577 WIN LINUX GPU : canvas/philip/tests/2d.pattern.repeat.null.html = TEXT
+BUGCR88577 WIN LINUX GPU : fast/canvas/canvas-pattern-behaviour.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90381] trunk/LayoutTests

[mihaip]

Title: [90381] trunk/LayoutTests








Revision 90381
Author mih...@chromium.org
Date 2011-07-04 19:18:51 -0700 (Mon, 04 Jul 2011)


Log Message
2011-07-04  Mihai Parparita  mih...@chromium.org

As of r90372 there are WebKit2 Mac-specific tests; don't expect those to
pass in Chromium, just like other platform-specific tests.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90380 => 90381)

--- trunk/LayoutTests/ChangeLog	2011-07-05 01:54:27 UTC (rev 90380)
+++ trunk/LayoutTests/ChangeLog	2011-07-05 02:18:51 UTC (rev 90381)
@@ -1,3 +1,10 @@
+2011-07-04  Mihai Parparita  mih...@chromium.org
+
+As of r90372 there are WebKit2 Mac-specific tests; don't expect those to
+pass in Chromium, just like other platform-specific tests.
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-04  Kent Tamura  tk...@chromium.org
 
 REGRESSION (r87067): Text overflows from short height text field.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90380 => 90381)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-05 01:54:27 UTC (rev 90380)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-05 02:18:51 UTC (rev 90381)
@@ -301,6 +301,7 @@
 // Run the Mac-specific platform tests, but only to check for crashes.
 WONTFIX : platform/gtk = FAIL PASS
 WONTFIX : platform/mac = FAIL PASS TIMEOUT
+WONTFIX : platform/mac-wk2 = FAIL PASS TIMEOUT
 WONTFIX : platform/mac-leopard = FAIL PASS
 WONTFIX : platform/qt = FAIL PASS
 WONTFIX SKIP : platform/qt/plugins/qt-qwidget-plugin.html = FAIL






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90320] trunk/LayoutTests

[mihaip]

Title: [90320] trunk/LayoutTests








Revision 90320
Author mih...@chromium.org
Date 2011-07-02 14:11:54 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  mih...@chromium.org

Chromium expectations update:
- Add failing expectation for fast/css/last-of-type-pseudo-class.html,
  which fails in debug only.
- Remove Chromium-specific baselines for fast/js/reserved-words.html,
  the test now passes with the regular baselines.

* platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
* platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/fast/js/reserved-words-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/js/reserved-words-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90319 => 90320)

--- trunk/LayoutTests/ChangeLog	2011-07-02 21:09:43 UTC (rev 90319)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 21:11:54 UTC (rev 90320)
@@ -1,3 +1,15 @@
+2011-07-02  Mihai Parparita  mih...@chromium.org
+
+Chromium expectations update:
+- Add failing expectation for fast/css/last-of-type-pseudo-class.html,
+  which fails in debug only.
+- Remove Chromium-specific baselines for fast/js/reserved-words.html,
+  the test now passes with the regular baselines.
+
+* platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
+* platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
+* platform/chromium/test_expectations.txt:
+
 2011-07-02  Kent Tamura  tk...@chromium.org
 
 [GTK] Update expectation of fast/forms/input-file-re-render.html


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90319 => 90320)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:09:43 UTC (rev 90319)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:11:54 UTC (rev 90320)
@@ -1279,7 +1279,7 @@
 
 BUGCR26253 SLOW WIN RELEASE : http/tests/navigation/reload-subframe-object.html = PASS
 BUGCR9798 WIN RELEASE : http/tests/navigation/no-referrer-reset.html = TIMEOUT PASS
-// Regressions from r67349? 
+// Regressions from r67349?
 BUGCR10364 MAC : http/tests/navigation/reload-subframe-object.html = FAIL
 
 // Text declared as monospace with no size is bigger in Chromium
@@ -2279,7 +2279,7 @@
 BUGCR53131 LINUX : fast/js/array-iterate-backwards.html = CRASH PASS
 
 // new or failing since WebKit rev. 65740:65800
-// This test causes the DRT to crash. 
+// This test causes the DRT to crash.
 BUGCR53073 DEBUG SKIP : storage/change-version.html = CRASH PASS
 BUGCR53073 LINUX : svg/custom/clip-path-units-changes.svg = TEXT PASS
 
@@ -2807,11 +2807,11 @@
 BUGWK53527 DEBUG : fast/frames/iframe-reparenting-new-page.html = CRASH PASS
 
 // It is failing since r77459.
-// Fix miscalculation of the overhang area used for painting. We were 
-// not correctly accounting for scrollbars resulting in an non-negative 
-// overhang even when we weren't over the edge. 
-// * platform/ScrollView.cpp: 
-//   (WebCore::ScrollView::calculateOverhangAreasForPainting): 
+// Fix miscalculation of the overhang area used for painting. We were
+// not correctly accounting for scrollbars resulting in an non-negative
+// overhang even when we weren't over the edge.
+// * platform/ScrollView.cpp:
+//   (WebCore::ScrollView::calculateOverhangAreasForPainting):
 BUGCR71783 : scrollbars/custom-scrollbar-with-incomplete-style.html = IMAGE
 
 //
@@ -3776,7 +3776,7 @@
 // Started crashing after seemingly unrelated r85786
 BUGCR83325 MAC DEBUG : canvas/philip/tests/2d.imageData.put.created.html = CRASH PASS
 
-// Appears to be a configuration error in the Mac 10.6 deps 
+// Appears to be a configuration error in the Mac 10.6 deps
 // Has been going on for at least a few weeks (as of 20/5/2011)
 BUGCR83426 MAC : fast/borders/svg-as-border-image-2.html = IMAGE PASS
 BUGCR83426 MAC : fast/borders/svg-as-border-image.html = IMAGE PASS
@@ -3981,12 +3981,6 @@
 // Strange scrollbar.
 BUGWK63115 : fast/css/font-face-in-shadow-DOM.html = PASS IMAGE+TEXT
 
-// The following two tests started to fail since V8 3.4.5.1 roll.
-// This needs rebaselining because native is no longer a reserved word.
-BUGCR87070 : fast/js/reserved-words.html = TEXT
-// Sounds like a real regression.
-BUGCR87070 WIN DEBUG : http/tests/security/_javascript_URL/xss-DENIED-to-_javascript_-url-in-foreign-domain-subframe.html = CRASH PASS
-
 BUGCR87217 WIN LINUX GPU : compositing/layer-creation/spanOverlapsCanvas.html = TEXT
 
 // We now follow the ES5 spec with regards to the semantics of the receiver
@@ -4017,3 +4011,5 @@
 
 // Quota enforcement not yet implemented for LevelDB back-end.
 BUGCR83652 : storage/indexeddb/database-quota.html = TEXT
+

[webkit-changes] [90322] trunk/LayoutTests

[mihaip]

Title: [90322] trunk/LayoutTests








Revision 90322
Author mih...@chromium.org
Date 2011-07-02 14:57:46 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  mih...@chromium.org

Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
since the regular Mac baselines can't be used due to single-pixel
differences in character rendering (presumably caused by 32-bit vs.
64-bit binaries).

* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (90321 => 90322)

--- trunk/LayoutTests/ChangeLog	2011-07-02 21:12:27 UTC (rev 90321)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 21:57:46 UTC (rev 90322)
@@ -1,5 +1,22 @@
 2011-07-02  Mihai Parparita  mih...@chromium.org
 
+Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
+since the regular Mac baselines can't be used due to single-pixel
+differences in character rendering (presumably caused by 32-bit vs.
+64-bit binaries).
+
+* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
+2011-07-02  Mihai Parparita  mih...@chromium.org
+
 Chromium expectations update:
 - Add failing expectation for fast/css/last-of-type-pseudo-class.html,
   which fails in debug only.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90321 => 90322)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:12:27 UTC (rev 90321)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:57:46 UTC (rev 90322)
@@ -3946,14 +3946,14 @@
 BUGWK62858 LEOPARD : fast/dom/HTMLMeterElement/meter-writing-mode.html = IMAGE
 
 // These tests are rebaselined using images on the bots but are still failing.
-BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-br.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-p.html = IMAGE PASS
-BUGRNIWA MAC : 

[webkit-changes] [90323] trunk/LayoutTests

[mihaip]

Title: [90323] trunk/LayoutTests








Revision 90323
Author mih...@chromium.org
Date 2011-07-02 14:59:17 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  mih...@chromium.org

Meant to actually remove expectations in r90322, not just comment them
out.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90322 => 90323)

--- trunk/LayoutTests/ChangeLog	2011-07-02 21:57:46 UTC (rev 90322)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 21:59:17 UTC (rev 90323)
@@ -1,5 +1,12 @@
 2011-07-02  Mihai Parparita  mih...@chromium.org
 
+Meant to actually remove expectations in r90322, not just comment them
+out.
+
+* platform/chromium/test_expectations.txt:
+
+2011-07-02  Mihai Parparita  mih...@chromium.org
+
 Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
 since the regular Mac baselines can't be used due to single-pixel
 differences in character rendering (presumably caused by 32-bit vs.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90322 => 90323)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:57:46 UTC (rev 90322)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:59:17 UTC (rev 90323)
@@ -3945,16 +3945,6 @@
 
 BUGWK62858 LEOPARD : fast/dom/HTMLMeterElement/meter-writing-mode.html = IMAGE
 
-// These tests are rebaselined using images on the bots but are still failing.
-// BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-p.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-forward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-forward-p.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html = IMAGE PASS
-
 // Broken because Chromium disables compositing for RTL pages
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow-scrolled.html = TEXT
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90325] trunk/LayoutTests

[mihaip]

Title: [90325] trunk/LayoutTests








Revision 90325
Author mih...@chromium.org
Date 2011-07-02 16:20:11 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  mih...@chromium.org

Remove Chromium Leopard failing expectations for two tests (fast/dom/
HTMLMeterElement/meter-writing-mode.html and fast/images/
imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90324 => 90325)

--- trunk/LayoutTests/ChangeLog	2011-07-02 23:08:23 UTC (rev 90324)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 23:20:11 UTC (rev 90325)
@@ -1,5 +1,13 @@
 2011-07-02  Mihai Parparita  mih...@chromium.org
 
+Remove Chromium Leopard failing expectations for two tests (fast/dom/
+HTMLMeterElement/meter-writing-mode.html and fast/images/
+imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.
+
+* platform/chromium/test_expectations.txt:
+
+2011-07-02  Mihai Parparita  mih...@chromium.org
+
 Meant to actually remove expectations in r90322, not just comment them
 out.
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90324 => 90325)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 23:08:23 UTC (rev 90324)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 23:20:11 UTC (rev 90325)
@@ -2552,15 +2552,14 @@
 // FIXME: Need to add tooling support for V8 bugs.
 BUGV8_953 : fast/regex/pcre-test-1.html = TIMEOUT
 
-BUGCR50282 MAC : fast/images/imagemap-case.html = IMAGE
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-zoom.html = IMAGE
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring.html = IMAGE
-BUGCR50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE+TEXT
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE
-BUGCR50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE+TEXT
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE
-BUGCR50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color.html = IMAGE+TEXT
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color.html = IMAGE
+BUGWK50282 MAC : fast/images/imagemap-case.html = IMAGE
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring.html = IMAGE
+BUGWK50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE+TEXT
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE
+BUGWK50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE+TEXT
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE
+BUGWK50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color.html = IMAGE+TEXT
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color.html = IMAGE
 
 // Selection is wrong.
 BUGCR64938 : editing/selection/5354455-1.html = TEXT
@@ -3943,8 +3942,6 @@
 // Has been flaky/crashy for a while
 BUGCR86359 WIN : fast/dom/DeviceOrientation/add-listener-from-callback.html = CRASH PASS
 
-BUGWK62858 LEOPARD : fast/dom/HTMLMeterElement/meter-writing-mode.html = IMAGE
-
 // Broken because Chromium disables compositing for RTL pages
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow-scrolled.html = TEXT
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90335] trunk/LayoutTests

[mihaip]

Title: [90335] trunk/LayoutTests








Revision 90335
Author mih...@chromium.org
Date 2011-07-02 21:02:24 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  mih...@chromium.org

Remove failing expectation for fast/events/panScroll-click-hyperlink.html
(Chromium still doesn't pass the test, since it doesn't have pan
scrolling enabled, but r90235 added failing expectations for the Windows
port, which Chromium Win and Linux pick up)

Also remove flaky expectations for some tests that have not failed as
far back as the flakiness dashboard has data for.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90334 => 90335)

--- trunk/LayoutTests/ChangeLog	2011-07-03 02:26:43 UTC (rev 90334)
+++ trunk/LayoutTests/ChangeLog	2011-07-03 04:02:24 UTC (rev 90335)
@@ -1,3 +1,15 @@
+2011-07-02  Mihai Parparita  mih...@chromium.org
+
+Remove failing expectation for fast/events/panScroll-click-hyperlink.html
+(Chromium still doesn't pass the test, since it doesn't have pan
+scrolling enabled, but r90235 added failing expectations for the Windows
+port, which Chromium Win and Linux pick up)
+
+Also remove flaky expectations for some tests that have not failed as
+far back as the flakiness dashboard has data for.
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-02  Anders Carlsson  ander...@apple.com
 
 Update skipped list.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90334 => 90335)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-03 02:26:43 UTC (rev 90334)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-03 04:02:24 UTC (rev 90335)
@@ -305,6 +305,7 @@
 WONTFIX : platform/qt = FAIL PASS
 WONTFIX SKIP : platform/qt/plugins/qt-qwidget-plugin.html = FAIL
 WONTFIX SKIP : platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html = PASS
+WONTFIX SKIP : platform/qt/fast/forms = PASS FAIL CRASH TIMEOUT
 
 WONTFIX MAC WIN : platform/chromium-linux = FAIL
 WONTFIX SKIP LINUX MAC : platform/win = FAIL CRASH PASS
@@ -1467,8 +1468,7 @@
 
 // Flakey. Not clear when it started, but it was before 3/9/09.
 // This test also started failing with the merge of March 25th 2009
-BUGCR10441 WIN : transitions/transition-end-event-transform.html = TEXT PASS
-BUGCR10441 MAC RELEASE : transitions/transition-end-event-transform.html = TEXT PASS
+BUGCR10441 MAC WIN : transitions/transition-end-event-transform.html = TEXT PASS
 
 // Merge 41768:41807
 // Perhaps just needs new baseline?
@@ -3527,9 +3527,7 @@
 BUGCASEQ WIN LINUX : fast/forms/input-text-drag-down.html = IMAGE+TEXT
 BUGCASEQ LEOPARD : fast/canvas/image-object-in-canvas.html = IMAGE
 
-
 BUGDPRANKE MAC DEBUG : transitions/cancel-transition.html = TEXT PASS
-
 BUGDPRANKE LINUX DEBUG : fast/dom/Node/mutation-blur.html = CRASH PASS
 
 // flakiness
@@ -3595,39 +3593,15 @@
 // broke in r84742 - just needs a new baseline?
 BUGWK60121 : http/tests/misc/will-send-request-returns-null-on-redirect.html = TEXT
 
-BUGWK62761 WIN : fast/events/panScroll-click-hyperlink.html = PASS TEXT
-BUGWK62761 LINUX : fast/events/panScroll-click-hyperlink.html = TEXT
 BUGCR86337 : fast/files/domurl-script-execution-context-crash.html = CRASH PASS
 BUGCR86338 : fast/loader/file-protocol-fragment.html = TEXT
 BUGCR86340 : fast/filesystem/file-writer-write-overlapped.html = CRASH PASS TEXT
 
 // flakiness on deps bots (noted ~ r83108)
-BUGDPRANKE WIN CPU DEBUG : editing/selection/select-line.html = PASS CRASH
 BUGDPRANKE WIN CPU DEBUG : fast/css/last-of-type-pseudo-class.html = PASS TEXT
-BUGDPRANKE WIN CPU DEBUG : http/tests/local/stylesheet-and-script-load-order-media-print.html = PASS CRASH
-BUGDPRANKE WIN CPU DEBUG : svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg = PASS CRASH
-BUGDPRANKE MAC CPU DEBUG : fast/block/float/overhanging-tall-block.html = PASS CRASH
-BUGDPRANKE MAC CPU DEBUG : fast/css/import_with_baseurl.html = PASS CRASH
 BUGDPRANKE WIN CPU DEBUG : http/tests/eventsource/eventsource-reconnect.html = PASS TEXT
 BUGDPRANKE WIN : http/tests/navigation/ping-same-origin.html = PASS TIMEOUT TEXT
-BUGDPRANKE WIN CPU DEBUG : svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml = PASS CRASH
-
-// flakiness on canaries (noted ~ r85006)
-BUGDPRANKE CPU : svg/hixie/rendering-model/003.xhtml = IMAGE+TEXT PASS
-BUGDPRANKE CPU : fast/dom/HTMLFormElement/document-deactivation-callback-crash.html = PASS TEXT
-BUGDPRANKE LINUX DEBUG CPU : svg/custom/font-platformDestroy-crash.svg = PASS CRASH
-BUGDPRANKE CPU : fast/dom/HTMLObjectElement/object-as-frame.html = PASS TEXT
-BUGDPRANKE CPU LINUX DEBUG : editing/pasteboard/drop-text-events.html = PASS CRASH
-BUGDPRANKE MAC DEBUG :   

[webkit-changes] [90243] trunk/LayoutTests

[mihaip]

Title: [90243] trunk/LayoutTests








Revision 90243
Author mih...@chromium.org
Date 2011-07-01 10:29:09 -0700 (Fri, 01 Jul 2011)


Log Message
2011-07-01  Mihai Parparita  mih...@chromium.org

Add failing test expectations for Chromium media tests on Windows 7 and
Vista.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90242 => 90243)

--- trunk/LayoutTests/ChangeLog	2011-07-01 16:56:42 UTC (rev 90242)
+++ trunk/LayoutTests/ChangeLog	2011-07-01 17:29:09 UTC (rev 90243)
@@ -1,3 +1,10 @@
+2011-07-01  Mihai Parparita  mih...@chromium.org
+
+Add failing test expectations for Chromium media tests on Windows 7 and
+Vista.
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-01  Balazs Kelemen  kbal...@webkit.org
 
 Reviewed by Andreas Kling.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90242 => 90243)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-01 16:56:42 UTC (rev 90242)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-01 17:29:09 UTC (rev 90243)
@@ -824,7 +824,7 @@
 BUGCR78376 : http/tests/media/video-play-stall-seek.html = TIMEOUT
 
 // canplaythrough event is sent too early.
-BUGCR73609 : http/tests/media/video-play-stall.html = TEXT
+BUGCR73609 MAC XP LINUX : http/tests/media/video-play-stall.html = TEXT
 
 // video.buffered multiple TimeRanges support.
 BUGCR49165 SKIP : http/tests/media/video-buffered.html = PASS
@@ -4031,3 +4031,28 @@
 
 // Added in http://trac.webkit.org/changeset/90148, null-derefing in TestNetscapgePlugin.
 BUGJAPHET : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = CRASH
+
+// Caused by an ffmpeg roll
+BUGCR88197 VISTA WIN7 : http/tests/appcache/video.html = TEXT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT
+BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/media-can-load-when-hidden.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/reload-after-dialog.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/remove-while-loading.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-cancel-load.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-cookie.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-error-abort.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-load-twice.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-play-progress.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-play-stall.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-constructor-preload.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-constructor-src.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-constructor.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-controls-do-not-fade-out.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-controls-rendering.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-delete-while-slider-thumb-clicked.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-only-video-intrinsic-size.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/audio-play-event.html = TIMEOUT PASS
+BUGCR88197 VISTA WIN7 : media/audio-repaint.html = TIMEOUT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90267] trunk/LayoutTests

[mihaip]

Title: [90267] trunk/LayoutTests








Revision 90267
Author mih...@chromium.org
Date 2011-07-01 12:54:29 -0700 (Fri, 01 Jul 2011)


Log Message
2011-07-01  Mihai Parparita  mih...@chromium.org

Add more failing test expectations for Chromium media tests on Windows 7
and Vista.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90266 => 90267)

--- trunk/LayoutTests/ChangeLog	2011-07-01 19:49:24 UTC (rev 90266)
+++ trunk/LayoutTests/ChangeLog	2011-07-01 19:54:29 UTC (rev 90267)
@@ -1,3 +1,10 @@
+2011-07-01  Mihai Parparita  mih...@chromium.org
+
+Add more failing test expectations for Chromium media tests on Windows 7
+and Vista.
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-01  Juan C. Montemayor  jm...@apple.com
 
 Reviewed by Oliver Hunt.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90266 => 90267)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-01 19:49:24 UTC (rev 90266)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-01 19:54:29 UTC (rev 90267)
@@ -2914,7 +2914,7 @@
 BUGCR74979 GPU MAC SKIP: media/video-canvas-alpha.html = IMAGE
 
 // This test needs completely new baselines.
-BUGWK55718 BUGCR75354 : media/media-document-audio-repaint.html = PASS FAIL
+BUGWK55718 BUGCR75354 XP MAC LINUX : media/media-document-audio-repaint.html = IMAGE+TEXT
 
 BUGWK55968 BUGWK58306 GPU MAC : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE+TEXT CRASH
 BUGWK55968 GPU WIN DEBUG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE
@@ -2928,8 +2928,6 @@
 BUGCR78999 WIN LINUX GPU : compositing/geometry/ancestor-overflow-change.html = IMAGE+TEXT
 BUGCR78999 MAC GPU : compositing/geometry/ancestor-overflow-change.html = IMAGE
 
-
-
 BUGCR72223 : media/video-frame-accurate-seek.html = IMAGE
 
 BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT
@@ -3583,8 +3581,6 @@
 BUGDPRANKE : http/tests/navigation/redirect-on-back-updates-history-item.html = TIMEOUT PASS
 BUGWK60125 : fast/files/create-blob-url-crash.html = CRASH PASS
 
-BUGWK60122 DEBUG : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TIMEOUT PASS
-
 // flakiness
 BUGDPRANKE : fast/dom/Document/document-reopen.html = TEXT PASS
 
@@ -4033,10 +4029,8 @@
 BUGJAPHET : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = CRASH
 
 // Caused by an ffmpeg roll
+BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : http/tests/appcache/video.html = TEXT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT
-BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : http/tests/media/media-can-load-when-hidden.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : http/tests/media/reload-after-dialog.html = TIMEOUT
@@ -4047,6 +4041,10 @@
 BUGCR88197 VISTA WIN7 : http/tests/media/video-load-twice.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : http/tests/media/video-play-progress.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : http/tests/media/video-play-stall.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT
+BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT
+BUGCR88197 VISTA WIN7 : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TIMEOUT PASS
+BUGCR88197 VISTA WIN7 : http/tests/security/local-video-source-from-remote.html = TEXT
 BUGCR88197 VISTA WIN7 : media/audio-constructor-preload.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : media/audio-constructor-src.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : media/audio-constructor.html = TIMEOUT
@@ -4056,3 +4054,21 @@
 BUGCR88197 VISTA WIN7 : media/audio-only-video-intrinsic-size.html = TIMEOUT
 BUGCR88197 VISTA WIN7 : media/audio-play-event.html = TIMEOUT PASS
 BUGCR88197 VISTA WIN7 : media/audio-repaint.html = TIMEOUT PASS
+BUGCR88197 VISTA WIN7 : media/controls-after-reload.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/controls-drag-timebar.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/controls-right-click-on-timebar.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/controls-strict.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/controls-styling.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/controls-without-preload.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/event-attributes.html = TEXT
+BUGCR88197 VISTA WIN7 : media/media-blocked-by-beforeload.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/media-document-audio-repaint.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/media-ended.html = TIMEOUT
+BUGCR88197 VISTA WIN7 : media/media-load-event.html 

[webkit-changes] [90281] trunk

[mihaip]

Title: [90281] trunk








Revision 90281
Author mih...@chromium.org
Date 2011-07-01 15:02:44 -0700 (Fri, 01 Jul 2011)


Log Message
2011-07-01  Mihai Parparita  mih...@chromium.org

Reviewed by Darin Fisher.

location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777

* fast/history/location-replace-hash-expected.txt: Added.
* fast/history/location-replace-hash.html: Added.
* fast/history/resources/location-replace-hash-1.html: Added.
* fast/history/resources/location-replace-hash-2.html: Added.
2011-07-01  Mihai Parparita  mih...@chromium.org

Reviewed by Darin Fisher.

location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777

location.replace('#foo') would not update the HistoryItem with the
new URL, thus navigating back to the page would use the previous
URL, even though it had been replaced. Make
HistoryController::updateForSameDocumentNavigation mirror
HistoryController::replaceState.

Test: fast/history/location-replace-hash.html

* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForSameDocumentNavigation):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/HistoryController.cpp


Added Paths

trunk/LayoutTests/fast/history/location-replace-hash-expected.txt
trunk/LayoutTests/fast/history/location-replace-hash.html
trunk/LayoutTests/fast/history/resources/location-replace-hash-1.html
trunk/LayoutTests/fast/history/resources/location-replace-hash-2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (90280 => 90281)

--- trunk/LayoutTests/ChangeLog	2011-07-01 22:01:12 UTC (rev 90280)
+++ trunk/LayoutTests/ChangeLog	2011-07-01 22:02:44 UTC (rev 90281)
@@ -1,3 +1,15 @@
+2011-07-01  Mihai Parparita  mih...@chromium.org
+
+Reviewed by Darin Fisher.
+
+location.replace with a hash change does not update the history entry
+https://bugs.webkit.org/show_bug.cgi?id=63777
+
+* fast/history/location-replace-hash-expected.txt: Added.
+* fast/history/location-replace-hash.html: Added.
+* fast/history/resources/location-replace-hash-1.html: Added.
+* fast/history/resources/location-replace-hash-2.html: Added.
+
 2011-07-01  Ryosuke Niwa  rn...@webkit.org
 
 Fix expected results after r90275. I checked in Mac-specific results for these tests.


Added: trunk/LayoutTests/fast/history/location-replace-hash-expected.txt (0 => 90281)

--- trunk/LayoutTests/fast/history/location-replace-hash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/history/location-replace-hash-expected.txt	2011-07-01 22:02:44 UTC (rev 90281)
@@ -0,0 +1,19 @@
+main frame - has 1 onunload handler(s)
+main frame - has 1 onunload handler(s)
+main frame - has 1 onunload handler(s)
+Tests that using location.replace to update the hash of a page preserves it when navigating back to it.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS currentPageId is 1
+PASS currentPageId is 1
+PASS testWindow.location.hash is #foo
+PASS currentPageId is 2
+PASS currentPageId is 1
+PASS testWindow.location.hash is #foo
+PASS Complete: navigated through all the states
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/history/location-replace-hash.html (0 => 90281)

--- trunk/LayoutTests/fast/history/location-replace-hash.html	(rev 0)
+++ trunk/LayoutTests/fast/history/location-replace-hash.html	2011-07-01 22:02:44 UTC (rev 90281)
@@ -0,0 +1,70 @@
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+pre id=console/pre
+script
+description('Tests that using location.replace to update the hash of a page preserves it when navigating back to it.');
+
+jsTestIsAsync = true;
+
+var testWindow;
+
+_onload_ = function()
+{
+if (window.layoutTestController) {
+layoutTestController.setCanOpenWindows();
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+testWindow = window.open('resources/location-replace-hash-1.html');
+if (!testWindow)
+testFailed('Could not open test window');
+}
+
+var currentState = 0;
+var currentPageId;
+
+function onTestWindowNavigation(pageId)
+{
+// The page ID is put in a global so that the eval() inside of shouldBe can
+// see it
+currentPageId = pageId;
+currentState++;
+
+switch (currentState) {
+  case 1:
+  shouldBe('currentPageId', '1');
+  testWindow.location.replace('#foo');
+  break;
+  case 2:
+  shouldBe('currentPageId', '1');
+  shouldBe('testWindow.location.hash', '#foo');
+  testWindow.location = 'location-replace-hash-2.html';
+  break;
+ 

[webkit-changes] [90286] trunk/LayoutTests

[mihaip]

Title: [90286] trunk/LayoutTests








Revision 90286
Author mih...@chromium.org
Date 2011-07-01 15:25:14 -0700 (Fri, 01 Jul 2011)


Log Message
2011-07-01  Mihai Parparita  mih...@chromium.org

Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
(r90261 added a Leopard expectation for the Mac port, but Chromium
Leopard can pass with the default baseline).

* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90285 => 90286)

--- trunk/LayoutTests/ChangeLog	2011-07-01 22:11:46 UTC (rev 90285)
+++ trunk/LayoutTests/ChangeLog	2011-07-01 22:25:14 UTC (rev 90286)
@@ -1,3 +1,11 @@
+2011-07-01  Mihai Parparita  mih...@chromium.org
+
+Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
+(r90261 added a Leopard expectation for the Mac port, but Chromium 
+Leopard can pass with the default baseline).
+
+* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
+
 2011-07-01  Nate Chapin  jap...@chromium.org
 
 Test for https://bugs.webkit.org/show_bug.cgi?id=63835.


Added: trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt (0 => 90286)

--- trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt	2011-07-01 22:25:14 UTC (rev 90286)
@@ -0,0 +1,40 @@
+Test to ensure that a media file blocked by a beforeload handler generates an error and does not block the document's 'load' event.
+
+*** Test initial state ***
+EXPECTED (video.networkState == '0') OK
+EXPECTED (video.error == 'null') OK
+
+*** Test blocking the 'src' attribute ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of 'src'
+
+EVENT('loadstart')
+
+EVENT('error')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+EXPECTED (video.error != 'null') OK
+EXPECTED (video.error.code == '4') OK
+EXPECTED (video.networkState == '3') OK
+
+*** Test using the source element ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of first source element
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+allowing load of second source element
+
+EVENT('loadstart')
+
+EVENT('error')
+EXPECTED (event.target.tagName == 'SOURCE') OK
+EXPECTED (video.error == 'null') OK
+
+EVENT('loadedmetadata')
+
+END OF TEST
+
Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90297] trunk/LayoutTests

[mihaip]

Title: [90297] trunk/LayoutTests








Revision 90297
Author mih...@chromium.org
Date 2011-07-01 16:41:45 -0700 (Fri, 01 Jul 2011)


Log Message
2011-07-01  Mihai Parparita  mih...@chromium.org

Remove Chromium Windows 7 and Vista media test expectations, since
clobbering the bots appears to have fixed the timeouts and failures.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90296 => 90297)

--- trunk/LayoutTests/ChangeLog	2011-07-01 23:30:00 UTC (rev 90296)
+++ trunk/LayoutTests/ChangeLog	2011-07-01 23:41:45 UTC (rev 90297)
@@ -1,3 +1,10 @@
+2011-07-01  Mihai Parparita  mih...@chromium.org
+
+Remove Chromium Windows 7 and Vista media test expectations, since
+clobbering the bots appears to have fixed the timeouts and failures.
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-01  Ryosuke Niwa  rn...@webkit.org
 
 GTK rebaseline r90275. The failure of directionality-after-undo-replace.html is tracked by the bug 63853.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90296 => 90297)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-01 23:30:00 UTC (rev 90296)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-01 23:41:45 UTC (rev 90297)
@@ -824,7 +824,7 @@
 BUGCR78376 : http/tests/media/video-play-stall-seek.html = TIMEOUT
 
 // canplaythrough event is sent too early.
-BUGCR73609 MAC XP LINUX : http/tests/media/video-play-stall.html = TEXT
+BUGCR73609 : http/tests/media/video-play-stall.html = TEXT
 
 // video.buffered multiple TimeRanges support.
 BUGCR49165 SKIP : http/tests/media/video-buffered.html = PASS
@@ -2914,7 +2914,7 @@
 BUGCR74979 GPU MAC SKIP: media/video-canvas-alpha.html = IMAGE
 
 // This test needs completely new baselines.
-BUGWK55718 BUGCR75354 XP MAC LINUX : media/media-document-audio-repaint.html = IMAGE+TEXT
+BUGWK55718 BUGCR75354 : media/media-document-audio-repaint.html = IMAGE+TEXT
 
 BUGWK55968 BUGWK58306 GPU MAC : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE+TEXT CRASH
 BUGWK55968 GPU WIN DEBUG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE
@@ -4028,51 +4028,6 @@
 // Added in http://trac.webkit.org/changeset/90148, null-derefing in TestNetscapgePlugin.
 BUGJAPHET : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = CRASH
 
-// Caused by an ffmpeg roll
-BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/appcache/video.html = TEXT
-BUGCR88197 VISTA WIN7 : http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/media-can-load-when-hidden.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/reload-after-dialog.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/remove-while-loading.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-cancel-load.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-cookie.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-error-abort.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-load-twice.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-play-progress.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-play-stall.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT
-BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT
-BUGCR88197 VISTA WIN7 : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TIMEOUT PASS
-BUGCR88197 VISTA WIN7 : http/tests/security/local-video-source-from-remote.html = TEXT
-BUGCR88197 VISTA WIN7 : media/audio-constructor-preload.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/audio-constructor-src.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/audio-constructor.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/audio-controls-do-not-fade-out.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/audio-controls-rendering.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/audio-delete-while-slider-thumb-clicked.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/audio-only-video-intrinsic-size.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/audio-play-event.html = TIMEOUT PASS
-BUGCR88197 VISTA WIN7 : media/audio-repaint.html = TIMEOUT PASS
-BUGCR88197 VISTA WIN7 : media/controls-after-reload.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/controls-drag-timebar.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/controls-right-click-on-timebar.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/controls-strict.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/controls-styling.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/controls-without-preload.html = TIMEOUT
-BUGCR88197 VISTA WIN7 : media/event-attributes.html = TEXT
-BUGCR88197 VISTA WIN7 : media/media-blocked-by-beforeload.html = TIMEOUT

[webkit-changes] [87469] trunk

[mihaip]

Title: [87469] trunk








Revision 87469
Author mih...@chromium.org
Date 2011-05-26 22:29:45 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Mihai Parparita  mih...@chromium.org

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
  Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
  destinationDomains argument, even though the actual parameter was for
  a single domain (renamed to be singular).

* bindings/v8/ScriptController.h:
* bindings/v8/V8Proxy.h:
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry):
* page/SecurityOrigin.h:
2011-05-26  Mihai Parparita  mih...@chromium.org

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
  Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
  destinationDomains argument, even though the actual parameter was for
  a single domain (renamed to be singular).

* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
* src/WebFrameImpl.h:
2011-05-26  Mihai Parparita  mih...@chromium.org

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:
- We would use worldId in .h files but worldID in .cpp files.
  Standardize on the latter
- SecurityOrigin::addOriginAccessWhitelistEntry would take a
  destinationDomains argument, even though the actual parameter was for
  a single domain (renamed to be singular).

* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptController.h
trunk/Source/WebCore/bindings/v8/V8Proxy.h
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/LayoutTestController.h
trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87468 => 87469)

--- trunk/Source/WebCore/ChangeLog	2011-05-27 05:27:50 UTC (rev 87468)
+++ trunk/Source/WebCore/ChangeLog	2011-05-27 05:29:45 UTC (rev 87469)
@@ -1,3 +1,25 @@
+2011-05-26  Mihai Parparita  mih...@chromium.org
+
+Reviewed by Adam Barth.
+
+Fix worldID and destinationDomain argument names
+https://bugs.webkit.org/show_bug.cgi?id=61571
+
+As part of working on r87423, I noticed a couple of inconsistencies in
+argument names:
+- We would use worldId in .h files but worldID in .cpp files.
+  Standardize on the latter
+- SecurityOrigin::addOriginAccessWhitelistEntry would take a
+  destinationDomains argument, even though the actual parameter was for
+  a single domain (renamed to be singular).
+
+* bindings/v8/ScriptController.h:
+* bindings/v8/V8Proxy.h:
+* page/SecurityOrigin.cpp:
+(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
+(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry):
+* page/SecurityOrigin.h:
+
 2011-05-26  Emil A Eklund  e...@chromium.org
 
 Reviewed by Eric Seidel.


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.h (87468 => 87469)

--- trunk/Source/WebCore/bindings/v8/ScriptController.h	2011-05-27 05:27:50 UTC (rev 87468)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.h	2011-05-27 05:29:45 UTC (rev 87469)
@@ -102,7 +102,7 @@
 // Associates an isolated world (see above for description) with a security
 // origin. XMLHttpRequest instances used in that world will be considered
 // to come from that origin, not the frame's.
-void setIsolatedWorldSecurityOrigin(int worldId, PassRefPtrSecurityOrigin);
+void