Re: [webkit-dev] Save Page - Ideas
On Oct 30, 2008, at 9:47 AM, Darin Fisher wrote: We have code to support this feature in the Chromium code base. You can find it here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.h?view=markup http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.cc?view=markup It is something we would love to one day see as part of WebKit. WebKit already includes code to serialize the DOM, in WebCore/editing/ markup.cpp. This is used by innerHTML, XMLSerializer, the clipboard code, Web archives, and other things. I think a better approach to a save as Web page, complete style feature would be to use the existing DOM serialization code (fixing bugs, if necessary), instead of adding completely separate DOM serialization code. The only tricky part is fixing up URL references in the markup to point to the right place for saved subresources. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Themes extending the style
Hyatt and I as well as some Chrome developers were involved in a discussion recently about how themes/ports should customize the user agent stylesheet. I think the following is the case currently: - Most ports do not change the UA stylesheet at all. - Chromium (not in the main tree yet) has a changed UA stylesheet with some rules appended at the end. - The Qt port replaces the UA stylesheet wholesale. Those of us involved in the discussion concluded that the best way to do this was to let RenderTheme subclasses add rules to the UA stylesheet, so that the core style rules can be in one place, but themes can adjust theme-specific style details that happen to be done with CSS rules. Ojan was kind enough to file this bug with the suggestion: https://bugs.webkit.org/show_bug.cgi?id=22051 I'm posting this as a heads-up to other porters, particularly the Qt port. Regards, Maciej P.S. As a side note, we really should rename html4.css to html5.css or just html.css. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Themes extending the style
On 6-Nov-08, at 12:20 AM, Maciej Stachowiak wrote: Hyatt and I as well as some Chrome developers were involved in a discussion recently about how themes/ports should customize the user agent stylesheet. I think the following is the case currently: - Most ports do not change the UA stylesheet at all. - Chromium (not in the main tree yet) has a changed UA stylesheet with some rules appended at the end. - The Qt port replaces the UA stylesheet wholesale. We're doing the same in a few places. Those of us involved in the discussion concluded that the best way to do this was to let RenderTheme subclasses add rules to the UA stylesheet, so that the core style rules can be in one place, but themes can adjust theme-specific style details that happen to be done with CSS rules. This would be great. We can use this for WML too. -- George Staikos Torch Mobile Inc. http://www.torchmobile.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Save Page - Ideas
On Nov 5, 2008, at 10:22 AM, Darin Fisher wrote: On Wed, Nov 5, 2008 at 7:04 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 30, 2008, at 9:47 AM, Darin Fisher wrote: We have code to support this feature in the Chromium code base. You can find it here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.h?view=markup http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.cc?view=markup It is something we would love to one day see as part of WebKit. WebKit already includes code to serialize the DOM, in WebCore/ editing/markup.cpp. This is used by innerHTML, XMLSerializer, the clipboard code, Web archives, and other things. I think a better approach to a save as Web page, complete style feature would be to use the existing DOM serialization code (fixing bugs, if necessary), instead of adding completely separate DOM serialization code. The only tricky part is fixing up URL references in the markup to point to the right place for saved subresources. Regards, Maciej I agree. I would rather see that happen too. Our code was created because we didn't want to fork WebCore, but we are happy to see it die in favor of enchancements to markup.cpp. There is more than just fixing up URLs. We also need to deal with charset encoding issues, base tags, and motw (for windows). There may be a few other subtle details to get right. Your code also has some obvious bugs that are not in the WebCore code. For instance it serializes the following incorrectly: p style=color: red/p bbold line/b Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Save Page - Ideas
On Wed, Nov 5, 2008 at 11:06 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Nov 5, 2008, at 10:22 AM, Darin Fisher wrote: On Wed, Nov 5, 2008 at 7:04 AM, Maciej Stachowiak [EMAIL PROTECTED] wrote: On Oct 30, 2008, at 9:47 AM, Darin Fisher wrote: We have code to support this feature in the Chromium code base. You can find it here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.h?view=markup http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.cc?view=markup It is something we would love to one day see as part of WebKit. WebKit already includes code to serialize the DOM, in WebCore/editing/markup.cpp. This is used by innerHTML, XMLSerializer, the clipboard code, Web archives, and other things. I think a better approach to a save as Web page, complete style feature would be to use the existing DOM serialization code (fixing bugs, if necessary), instead of adding completely separate DOM serialization code. The only tricky part is fixing up URL references in the markup to point to the right place for saved subresources. Regards, Maciej I agree. I would rather see that happen too. Our code was created because we didn't want to fork WebCore, but we are happy to see it die in favor of enchancements to markup.cpp. There is more than just fixing up URLs. We also need to deal with charset encoding issues, base tags, and motw (for windows). There may be a few other subtle details to get right. Your code also has some obvious bugs that are not in the WebCore code. For instance it serializes the following incorrectly: p style=color: red/p bbold line/b Regards, Maciej Thanks for pointing that out. -Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Plugin for mplayer at webkit-r38068
Hi All, Please help me regarding intalation of Mplayer plugin at webkit-r38068. --Regards Ajay ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Themes extending the style
Maciej Stachowiak wrote: Those of us involved in the discussion concluded that the best way to do this was to let RenderTheme subclasses add rules to the UA stylesheet, so that the core style rules can be in one place, but themes can adjust theme-specific style details that happen to be done with CSS rules. I just woke up, and haven't had my coffee yet, but didn't we add this in r268f45? The Qt port uses WebCore/platform/qt/html4-adjustments-qt.css to modify html4.css, not replace it as far as I remember. -- Tor Arne Vestbø, Software Engineer Qt Software, Nokia, Oslo, Norway http://www.trolltech.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Themes extending the style
Tor Arne Vestbø wrote: I just woke up, and haven't had my coffee yet, but didn't we add this in r268f45? Sorry, that was r34297 http://trac.webkit.org/changeset/34297 -- Tor Arne Vestbø, Software Engineer Qt Software, Nokia, Oslo, Norway http://www.trolltech.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
