[webkit-dev] EWS offline for maintenance for about an hour

[Aakash Jain via webkit-dev]

Hi Everyone,

We need to do some maintenance on the EWS bots (in order to switch the 
repository from git.webkit.org to https://github.com/webkit/webkit, 
https://bugs.webkit.org/show_bug.cgi?id=220479). EWS buildbot will be offline 
for about an hour, so it wouldn't process any new builds. However, EWS 
status-bubbles will still keep loading on Bugzilla.

Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EWS offline for maintenance for about an hour

[Aakash Jain via webkit-dev]

We are noticing some issues on Style-Queue and Commit-Queue. We are looking 
into that.

Thanks
Aakash

> On Jan 19, 2021, at 9:58 AM, Aakash Jain  wrote:
> 
> Hi Everyone,
> 
> We need to do some maintenance on the EWS bots (in order to switch the 
> repository from git.webkit.org to https://github.com/webkit/webkit, 
> https://bugs.webkit.org/show_bug.cgi?id=220479). EWS buildbot will be offline 
> for about an hour, so it wouldn't process any new builds. However, EWS 
> status-bubbles will still keep loading on Bugzilla.
> 
> Thanks
> Aakash

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EWS offline for maintenance for about an hour

[Aakash Jain via webkit-dev]

All the issues have been fixed.

Please let me know if anyone notices any issue.

Thanks
Aakash

> On Jan 19, 2021, at 12:23 PM, Aakash Jain  wrote:
> 
> We are noticing some issues on Style-Queue and Commit-Queue. We are looking 
> into that.
> 
> Thanks
> Aakash
> 
>> On Jan 19, 2021, at 9:58 AM, Aakash Jain  wrote:
>> 
>> Hi Everyone,
>> 
>> We need to do some maintenance on the EWS bots (in order to switch the 
>> repository from git.webkit.org to https://github.com/webkit/webkit, 
>> https://bugs.webkit.org/show_bug.cgi?id=220479). EWS buildbot will be 
>> offline for about an hour, so it wouldn't process any new builds. However, 
>> EWS status-bubbles will still keep loading on Bugzilla.
>> 
>> Thanks
>> Aakash
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Commit-Queue failing intermittently

[Aakash Jain via webkit-dev]

We are noticing intermittent issues with Commit-Queue failing to commit, since 
we moved it to github. We are looking into it. Meanwhile, if Commit-Queue fails 
on your patch, you can set cq+ again to retry.

Thanks
Aakash

> On Jan 19, 2021, at 4:56 PM, Aakash Jain  wrote:
> 
> All the issues have been fixed.
> 
> Please let me know if anyone notices any issue.
> 
> Thanks
> Aakash
> 
>> On Jan 19, 2021, at 12:23 PM, Aakash Jain  wrote:
>> 
>> We are noticing some issues on Style-Queue and Commit-Queue. We are looking 
>> into that.
>> 
>> Thanks
>> Aakash
>> 
>>> On Jan 19, 2021, at 9:58 AM, Aakash Jain  wrote:
>>> 
>>> Hi Everyone,
>>> 
>>> We need to do some maintenance on the EWS bots (in order to switch the 
>>> repository from git.webkit.org to https://github.com/webkit/webkit, 
>>> https://bugs.webkit.org/show_bug.cgi?id=220479). EWS buildbot will be 
>>> offline for about an hour, so it wouldn't process any new builds. However, 
>>> EWS status-bubbles will still keep loading on Bugzilla.
>>> 
>>> Thanks
>>> Aakash
>> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] build.webkit.org Upgraded to latest Buildbot

[Aakash Jain via webkit-dev]

Hello Everyone,

We have upgraded build.webkit.org to latest Buildbot (v2.10.1 released in 2021) 
(https://webkit.org/b/175056). Earlier it was running an ancient version of 
Buildbot, v0.8.6p1 (released in 2012). This is a brand new server. Buildbot 
doesn't support migrating data from old version. Old instance is accessible 
through https://build-old.webkit.org 

Known issue: Login functionality is not enabled for everyone yet.

Please let me know if you notice any issue.

Thanks
Aakash___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] EWS down for emergency maintenance

[Aakash Jain via webkit-dev]

Hi Everyone,

EWS (including commit-queue) is currently down for emergency maintenance. 
Status bubbles on existing Bugzilla bugs should still keep loading.

I'll send an update when the maintenance is complete.

Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EWS down for emergency maintenance

[Aakash Jain via webkit-dev]

EWS (including commit-queue) is back online.  Please let me know if anyone 
notices any issue.

Thanks
Aakash

> On Feb 20, 2021, at 8:20 AM, Aakash Jain  wrote:
> 
> Hi Everyone,
> 
> EWS (including commit-queue) is currently down for emergency maintenance. 
> Status bubbles on existing Bugzilla bugs should still keep loading.
> 
> I'll send an update when the maintenance is complete.
> 
> Thanks
> Aakash

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commit-Queue failing intermittently

[Aakash Jain via webkit-dev]

Most of the issues with commit-queue were fixed. We also added automatic 
retries in commit-queue to better handle intermittent issues (in 
https://webkit.org/b/222038).

Please let me know if anyone notices any issue.

Thanks
Aakash

> On Feb 4, 2021, at 4:39 PM, Aakash Jain  wrote:
> 
> We are noticing intermittent issues with Commit-Queue failing to commit, 
> since we moved it to github. We are looking into it. Meanwhile, if 
> Commit-Queue fails on your patch, you can set cq+ again to retry.
> 
> Thanks
> Aakash
> 
>> On Jan 19, 2021, at 4:56 PM, Aakash Jain  wrote:
>> 
>> All the issues have been fixed.
>> 
>> Please let me know if anyone notices any issue.
>> 
>> Thanks
>> Aakash
>> 
>>> On Jan 19, 2021, at 12:23 PM, Aakash Jain  wrote:
>>> 
>>> We are noticing some issues on Style-Queue and Commit-Queue. We are 
>>> looking into that.
>>> 
>>> Thanks
>>> Aakash
>>> 
 On Jan 19, 2021, at 9:58 AM, Aakash Jain  wrote:
 
 Hi Everyone,
 
 We need to do some maintenance on the EWS bots (in order to switch the 
 repository from git.webkit.org to https://github.com/webkit/webkit, 
 https://bugs.webkit.org/show_bug.cgi?id=220479). EWS buildbot will be 
 offline for about an hour, so it wouldn't process any new builds. However, 
 EWS status-bubbles will still keep loading on Bugzilla.
 
 Thanks
 Aakash
>>> 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] EWS Upgraded to latest Buildbot

[Aakash Jain via webkit-dev]

Hi Everyone

I have also upgraded EWS (ews-build.webkit.org) to latest Buildbot (v2.10.1).

Please let me know if anyone notices any issue.

Thanks
Aakash

> On Feb 8, 2021, at 8:04 PM, Aakash Jain  wrote:
> Hello Everyone,
> 
> We have upgraded build.webkit.org to latest Buildbot (v2.10.1 released in 
> 2021) (https://webkit.org/b/175056). Earlier it was running an ancient 
> version of Buildbot, v0.8.6p1 (released in 2012). This is a brand new server. 
> Buildbot doesn't support migrating data from old version. Old instance is 
> accessible through https://build-old.webkit.org
> 
> Known issue: Login functionality is not enabled for everyone yet.
> 
> Please let me know if you notice any issue.
> 
> Thanks
> Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] github.com repository force push

[Aakash Jain via webkit-dev]

Hi everyone,

We had little bit of issue with syncing between WebKit's github and svn 
repositories. To fix the issue, we had to force push and modify few git commits.

In case you notice any conflict in your github.com  
checkout of WebKit repo (which might be because of having one of those commits 
which we modified), please do the following: "git reset --hard HEAD~100", "git 
pull".

Please let me know if you face any issues.

Thanks
Aakash___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Reminder: WebKit SVN tree clousures (March 2021)

[Aakash Jain via webkit-dev]

Hello everyone,

The maintenance has been completed. WebKit SVN tree is open again. Commit-queue 
bots are also back online.

Thanks for your patience. Please let us know if you notice any issue.

Thanks
Aakash

> On Mar 17, 2021, at 12:50 PM, Ling Ho via webkit-dev 
>  wrote:
> 
> Hello,
> 
> The 2nd maintenance mentioned in my previous email will take place this 
> coming weekend as planned.
> 
> The WebKit SVN tree will be closed during:
> Begin: Friday, March 19th, 2021. 5pm (PDT)
> End: Monday, March 22nd, 2021. No later than 6pm (PDT)
> 
> ...
> Ling Ho
> 
> On 2/24/21 5:26 PM, Ling Ho wrote:
>> Hello WebKit,
>> 
>> Due to planned infrastructure maintenance, our critical continuous 
>> integration services (EWS and post-commit bots) will be unavailable during 
>> the following weekends:
>> 
>> Dates:
>> Begin: Friday, March 5th, 2021. 5pm (PST)
>> End: Monday, March 8th, 2021. No later than 6pm (PST)
>> 
>> Begin: Friday, March 19th, 2021. 5pm (PDT)
>> End: Monday, March 22nd, 2021. No later than 6pm (PDT)
>> 
>> To avoid accumulating difficult to diagnose regressions during this lengthy 
>> outage, WebKit SVN tree will be closed.
>> 
>> Please email ad...@webkit.org  if you have any 
>> questions or concerns.
>> 
>> Thanks,
>> 
>> ...
>> Ling Ho
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] EWS and build.webkit.org upgraded to Buildbot v2.10.5

[Aakash Jain via webkit-dev]

Hi Everyone,

Buildbot v2.10.5 was released today (few hours back). It contains few fixes 
which I made to Buildbot, e.g.:

- 'Show owners and worker columns on workers page' 
https://github.com/buildbot/buildbot/pull/5942
- 'Show owners and worker columns on changes page' 
https://github.com/buildbot/buildbot/pull/5945


It also fixes few issues which I reported to Buildbot which were impacting us, 
e.g.: 

- 'Regression: Owners column empty for pending build-requests' 
https://github.com/buildbot/buildbot/issues/5940 
- 'Message queue doesn't provide correct message for step finished' 
https://github.com/buildbot/buildbot/issues/5906, https://webkit.org/b/222973 


List of bug-fixes in v2.10.5: 
https://docs.buildbot.net/latest/relnotes/2.x.html#buildbot-2-10-5-2021-04-05


I have upgraded both, EWS (ews-build.webkit.org) and build.webkit.org to this 
Buildbot (v2.10.5). Please let me know if anyone notices any issue.

Thanks
Aakash

> On Mar 5, 2021, at 7:32 PM, Aakash Jain  wrote:
> 
> Hi Everyone
> 
> I have also upgraded EWS (ews-build.webkit.org) to latest Buildbot (v2.10.1).
> 
> Please let me know if anyone notices any issue.
> 
> Thanks
> Aakash
> 
>> On Feb 8, 2021, at 8:04 PM, Aakash Jain  wrote:
>> 
>> Hello Everyone,
>> 
>> We have upgraded build.webkit.org  to latest 
>> Buildbot (v2.10.1 released in 2021) (https://webkit.org/b/175056 
>> ). Earlier it was running an ancient version of 
>> Buildbot, v0.8.6p1 (released in 2012). This is a brand new server. Buildbot 
>> doesn't support migrating data from old version. Old instance is accessible 
>> through https://build-old.webkit.org 
>> 
>> Known issue: Login functionality is not enabled for everyone yet.
>> 
>> Please let me know if you notice any issue.
>> 
>> Thanks
>> Aakash

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] New EWS queue: Stress Test EWS

[Aakash Jain via webkit-dev]

Hi Everyone,

I am happy to announce that I have added a new EWS queue: Stress Test EWS. From 
now on, you would see a new status bubbles (on Bugzilla bug) named: 
'mac-wk2-stress'. For the patches that add or modify layout tests, this EWS 
will run those added/modified layout-tests repeatedly large number of times 
(currently 100 iterations). It will also run those added/modified layout-tests 
repeatedly in guard-malloc mode. Example: 
https://ews-build.webkit.org/#/builders/62/builds/249. The aim is to find any 
issue with the layout-tests, especially flakiness, or failure when run in a 
certain manner.

Flaky layout-tests are currently a huge problem, as they sometimes cause false 
positives on EWS (and other parts of infrastructure), and slow down our 
infrastructure (as for every test failure, EWS needs to run the test-suite few 
times to ensure the failures are not flaky or pre-existing). Until now, we 
didn't have any good automated way to indicate the test flakiness to the 
engineers. With this EWS, we are adding pre-commit testing for layout-test 
flakiness. We understand that layout tests might be flaky in a variety of ways, 
sometimes in a very specific or unexpected manner. I am looking at covering 
more and more scenarios in this EWS by making incremental improvements to it.

Few ideas to further improve this EWS are:
- Test on more OS/configurations (this EWS is currently using macOS release wk2 
mode)
- Run the test being added/modified repeatedly along-with other layout-tests in 
same directory
- Improve the logic to identify layout-tests, current logic is naive and only 
recognizes html layout-tests

More ideas are welcome.

Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] New fast commit queue mode: fast-cq

[Aakash Jain via webkit-dev]

Hi Everyone,

I am happy to inform you that I have added a fast-commit-queue mode to the 
Commit-Queue. In this mode Commit-Queue would land patches quickly (typically 
taking ~1 minute, e.g.: 
https://ews-build.webkit.org/#/builders/28/builds/10876). This mode skips 
building and testing. It basically does sanity check (like validating 
ChangeLog, Reviewer, Committer etc.) and commits the patch. This is intended to 
be used for scenarios where the patch is a build fix, urgent fix, quick 
typo/follow-up fix etc.

To use this mode, you can use the --fast-cq parameter while uploading the patch 
using webkit-patch command. e.g.: 'webkit-patch upload --fast-cq'. For patches 
which are already uploaded to Bugzilla, you can rename the patch (by clicking 
on 'Details' button for the patch), and prefix patch name with [fast-cq], e.g.: 
'[fast-cq] Patch for landing'.

Pro-tip: you can also rename the patch to include [fast-cq] prefix while 
marking the patch cq+, from patch 'Details' page, and this mode would work.

Please let me know if you have any questions/feedback.

Thanks
Aakash___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commit-Queue failing intermittently

[Aakash Jain via webkit-dev]

There were intermittent issues with Commit Queue even after adding the retries 
and few other fixes. The issue was related to git-svn specifically with our 
GitHub repo and caused intermittent failures while trying to push the commits 
to WebKit svn repository. We have now moved Commit Queue bots back to 
git.webkit.org in https://bugs.webkit.org/show_bug.cgi?id=224762

Commit-Queue seems to be working reliably since then (without a single such 
issue in last 5 days).

Thanks
Aakash

> On Feb 23, 2021, at 7:06 PM, Aakash Jain  wrote:
> 
> Most of the issues with commit-queue were fixed. We also added automatic 
> retries in commit-queue to better handle intermittent issues (in 
> https://webkit.org/b/222038).
> 
> Please let me know if anyone notices any issue.
> 
> Thanks
> Aakash
> 
>> On Feb 4, 2021, at 4:39 PM, Aakash Jain  wrote:
>> 
>> We are noticing intermittent issues with Commit-Queue failing to commit, 
>> since we moved it to github. We are looking into it. Meanwhile, if 
>> Commit-Queue fails on your patch, you can set cq+ again to retry.
>> 
>> Thanks
>> Aakash
>> 
>>> On Jan 19, 2021, at 4:56 PM, Aakash Jain  wrote:
>>> 
>>> All the issues have been fixed.
>>> 
>>> Please let me know if anyone notices any issue.
>>> 
>>> Thanks
>>> Aakash
>>> 
 On Jan 19, 2021, at 12:23 PM, Aakash Jain  wrote:
 
 We are noticing some issues on Style-Queue and Commit-Queue. We are 
 looking into that.
 
 Thanks
 Aakash
 
> On Jan 19, 2021, at 9:58 AM, Aakash Jain  wrote:
> 
> Hi Everyone,
> 
> We need to do some maintenance on the EWS bots (in order to switch the 
> repository from git.webkit.org to https://github.com/webkit/webkit, 
> https://bugs.webkit.org/show_bug.cgi?id=220479). EWS buildbot will be 
> offline for about an hour, so it wouldn't process any new builds. 
> However, EWS status-bubbles will still keep loading on Bugzilla.
> 
> Thanks
> Aakash
 
>> 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Is valgrind suppressions.txt unused

[Aakash Jain via webkit-dev]

Hi Everyone,

Is anyone (particularly gtk folks) are using valgrind especially 
suppressions.txt file 
(https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/valgrind/suppressions.txt).
 This file doesn't seems to be modified for a long time, so I am not sure if 
this is even being used.

I am looking into using inclusive naming, and this file contains the term 
'slave' (as "fun:gtk_im_multicontext_get_slave"). I can look into that specific 
line as well, but I was wondering if the file is used at all or not. 
 
Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Ryan Haddad is now a WebKit Reviewer

[Aakash Jain via webkit-dev]

Hello All,

I would like to announce that Ryan Haddad is now a WebKit Reviewer. His 
expertise is tools and infrastructure. Please join me in congratulation him.

🎉 Congratulations Ryan! 🎉

-Aakash___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Commit Queue down for maintainence

[Aakash Jain via webkit-dev]

Hi Everyone,

We just took commit-queue bots offline for some maintenance. I will send 
another update when they are back online.

Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commit Queue down for maintainence

[Aakash Jain via webkit-dev]

Commit Queue is back online. Please let me know if you notice any issue.

Thanks
Aakash

> On Jul 28, 2021, at 1:27 PM, Aakash Jain  wrote:
> 
> Hi Everyone,
> 
> We just took commit-queue bots offline for some maintenance. I will send 
> another update when they are back online.
> 
> Thanks
> Aakash

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] New fast commit queue mode: fast-cq

[Aakash Jain via webkit-dev]

> On Oct 21, 2021, at 7:36 PM, John Wilander  wrote:
> 
>> On Apr 8, 2021, at 1:44 PM, Aakash Jain via webkit-dev 
>> mailto:webkit-dev@lists.webkit.org>> wrote:
>> 
>> Hi Everyone,
>> 
>> I am happy to inform you that I have added a fast-commit-queue mode to the 
>> Commit-Queue. In this mode Commit-Queue would land patches quickly 
>> (typically taking ~1 minute, e.g.: 
>> https://ews-build.webkit.org/#/builders/28/builds/10876 
>> <https://ews-build.webkit.org/#/builders/28/builds/10876>). This mode skips 
>> building and testing. It basically does sanity check (like validating 
>> ChangeLog, Reviewer, Committer etc.) and commits the patch. This is intended 
>> to be used for scenarios where the patch is a build fix, urgent fix, quick 
>> typo/follow-up fix etc.
>> 
>> To use this mode, you can use the --fast-cq parameter while uploading the 
>> patch using webkit-patch command. e.g.: 'webkit-patch upload --fast-cq'. For 
>> patches which are already uploaded to Bugzilla, you can rename the patch (by 
>> clicking on 'Details' button for the patch), and prefix patch name with 
>> [fast-cq], e.g.: '[fast-cq] Patch for landing'.
> 
> Thanks! Shouldn’t this be a parameter to the land-safely command though? It 
> feels strange that an upload puts the patch on the commit queue.
> 
> Or maybe you’re saying upload --fast-cq only enables fast cq and someone 
> still has to mark it cq+ on Bugzilla?

That's correct. Someone still have to mark it cq+ on Bugzilla.

> If so, could we get a --fast-cq parameter for land-safely too, please?

Can you please file a Bugzilla bug about it (and cc me)? Although, it might be 
a while before I would be able to look into it.

> 
>Regards, John
> 
>> 
>> Pro-tip: you can also rename the patch to include [fast-cq] prefix while 
>> marking the patch cq+, from patch 'Details' page, and this mode would work.
>> 
>> Please let me know if you have any questions/feedback.
>> 
>> Thanks
>> Aakash
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] New fast commit queue mode: fast-cq

[Aakash Jain via webkit-dev]

I have added fast-cq support to webkit-patch land-safely in 
https://commits.webkit.org/243492@main

Sample invocation: webkit-patch land-safely --fast-cq

Thanks
Aakash

> On Oct 21, 2021, at 8:28 PM, Aakash Jain  wrote:
> 
> 
> 
>> On Oct 21, 2021, at 7:36 PM, John Wilander > <mailto:wilan...@apple.com>> wrote:
>> 
>>> On Apr 8, 2021, at 1:44 PM, Aakash Jain via webkit-dev 
>>> mailto:webkit-dev@lists.webkit.org>> wrote:
>>> 
>>> Hi Everyone,
>>> 
>>> I am happy to inform you that I have added a fast-commit-queue mode to the 
>>> Commit-Queue. In this mode Commit-Queue would land patches quickly 
>>> (typically taking ~1 minute, e.g.: 
>>> https://ews-build.webkit.org/#/builders/28/builds/10876 
>>> <https://ews-build.webkit.org/#/builders/28/builds/10876>). This mode skips 
>>> building and testing. It basically does sanity check (like validating 
>>> ChangeLog, Reviewer, Committer etc.) and commits the patch. This is 
>>> intended to be used for scenarios where the patch is a build fix, urgent 
>>> fix, quick typo/follow-up fix etc.
>>> 
>>> To use this mode, you can use the --fast-cq parameter while uploading the 
>>> patch using webkit-patch command. e.g.: 'webkit-patch upload --fast-cq'. 
>>> For patches which are already uploaded to Bugzilla, you can rename the 
>>> patch (by clicking on 'Details' button for the patch), and prefix patch 
>>> name with [fast-cq], e.g.: '[fast-cq] Patch for landing'.
>> 
>> Thanks! Shouldn’t this be a parameter to the land-safely command though? It 
>> feels strange that an upload puts the patch on the commit queue.
>> 
>> Or maybe you’re saying upload --fast-cq only enables fast cq and someone 
>> still has to mark it cq+ on Bugzilla?
> 
> That's correct. Someone still have to mark it cq+ on Bugzilla.
> 
>> If so, could we get a --fast-cq parameter for land-safely too, please?
> 
> Can you please file a Bugzilla bug about it (and cc me)? Although, it might 
> be a while before I would be able to look into it.
> 
>> 
>>Regards, John
>> 
>>> 
>>> Pro-tip: you can also rename the patch to include [fast-cq] prefix while 
>>> marking the patch cq+, from patch 'Details' page, and this mode would work.
>>> 
>>> Please let me know if you have any questions/feedback.
>>> 
>>> Thanks
>>> Aakash
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev 
>>> <https://lists.webkit.org/mailman/listinfo/webkit-dev>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Announcing EWS status-bubbles on Github PRs

[Aakash Jain via webkit-dev]

Hi Everyone,

I am happy to announce EWS status-bubbles on Github PRs. We’ve ported many of 
the best features of Bugzilla EWS status-bubbles to a GitHub compatible format.

From now on, when you create any new GitHub PR, you will automatically see EWS 
status-bubbles on your PRs. We also mirror the latest status-bubble on top (in 
PR description) so that it is always easy to find consistently in same place. 
Due to different architecture, we wouldn't be porting the "position in queue" 
feature from Bugzilla status-bubbles to GitHub status-bubbles.


Following are the main benefits of status-bubbles over GitHub checks:
- status-bubbles are displayed for all the queues, even if builds haven't 
started on those queues
- in case PR has multiple iterations, status-bubbles are displayed for all the 
iterations
- displayed even after a PR is merged/closed
- easy to glance through the status of all the queues


Upcoming features:
- Retry failed build support https://webkit.org/b/244055
- Generate detailed hover-over text for each status-bubble (including 
information about build-steps) https://webkit.org/b/244053
- Orange status-bubble equivalent in Github status-bubbles 
https://webkit.org/b/244054

If you notice any issue, please feel free to file bugs (and assign to me).

Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] git-webkit pr now supports --no-ews / --ews flags

[Aakash Jain via webkit-dev]

Hi Everyone,

git-webkit pr now supports --no-ews / --ews flags (as of 259115@main). This is 
similar to --no-ews flag we had in webkit-patch.  You can also manually add 
skip-ews label on any PR when you don't need EWS to run anymore on it. --no-ews 
flag will also automatically add the skip-ews label on the corresponding GitHub 
PR.

Please feel free to use skip-ews GitHub label or --no-ews flag in git-webkit 
pr, when you don't need to run EWS for any reason (e.g.: PR failed a critical 
EWS indicating need for new iteration, and you don't need to run rest of the 
EWSes on that commit).

If you notice any issues, please let me know or file bugs (and assign to me).


Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] git-webkit pr now supports --no-ews / --ews flags

[Aakash Jain via webkit-dev]

As of 259501@main, we now have both, GitHub label "skip-ews" and git-webkit pr 
support for --skip-ews flag.

Thanks
Aakash

> On Jan 26, 2023, at 3:58 PM, Geoffrey Garen  wrote:
> 
> This is great!
> 
> As it is said in "Ghost Dog: The Way of the Samurai", it is bad when one 
> thing becomes two. Can we pick one name for this feature? Either —no-ews 
> (git-webkit) and no-ews (GitHub) or —skip-ews (git-webkit) and skip-ews 
> (GitHub)?
> 
> Thanks,
> Geoff
> 
>> On Jan 26, 2023, at 11:36 AM, Aakash Jain via webkit-dev 
>>  wrote:
>> 
>> Hi Everyone,
>> 
>> git-webkit pr now supports --no-ews / --ews flags (as of 259115@main). This 
>> is similar to --no-ews flag we had in webkit-patch.  You can also manually 
>> add skip-ews label on any PR when you don't need EWS to run anymore on it. 
>> --no-ews flag will also automatically add the skip-ews label on the 
>> corresponding GitHub PR.
>> 
>> Please feel free to use skip-ews GitHub label or --no-ews flag in git-webkit 
>> pr, when you don't need to run EWS for any reason (e.g.: PR failed a 
>> critical EWS indicating need for new iteration, and you don't need to run 
>> rest of the EWSes on that commit).
>> 
>> If you notice any issues, please let me know or file bugs (and assign to me).
>> 
>> 
>> Thanks
>> Aakash
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Announcing Login with GitHub on EWS webpages

[Aakash Jain via webkit-dev]

Hi Everyone,

I am happy to announce a new feature in EWS: "Login with GitHub".

In Bugzilla world, we have a feature named "Retry failed builds" which allow us 
to retry the EWS builds which failed (especially useful when the failure might 
be due to flakiness or infrastructure issue). However, in GitHub world, there 
was no way for WebKittens to retry the builds until now.

>From now on, when you visit any ews-build.webkit.org page (e.g.: the page 
>which opens on clicking on any EWS status-bubble), you would be able to login 
>to it using your existing GitHub account. To login, on any ews buildbot page, 
>simply click on "Anonymous" -> "Login with GitHub" (on top-right). You will 
>need to authorize "WebKit EWS" to access your GtiHub account to Login.

After login, any WebKit contributor (listed in 
https://github.com/orgs/WebKit/teams/contributors/members) can press "Rebuild" 
button on any build. This would provide ability to retry not just the failing 
builds, but any builds, including failed, cancelled, skipped or even successful 
builds (for example if last EWS run on a PR was many days back and you want to 
run EWS again). Please click on this button only when needed, as unnecessary 
retries might waste resources.

If you are not listed in 
https://github.com/orgs/WebKit/teams/contributors/members and should have been 
listed there (e.g.: you are in contributors.json and have listed your GitHub 
account in it), please let me (or any WebKit admin) know.

As always, please feel free to let me know if you notice any issue or have any 
feedback.

Thanks
Aakash
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Announcing Login with GitHub on EWS webpages

[Aakash Jain via webkit-dev]

One cool trick can be to combine this feature with "skip-ews" GitHub label (or 
--no-ews flag in git-webkit, announced in 
https://lists.webkit.org/pipermail/webkit-dev/2023-January/032461.html).

For example, if you want to run EWS only on certain queues (e.g.: while 
debugging/iterating on a particular platform), you can create the PR with 
"git-webkit --no-ews", once most of the queues have processed the PR and 
skipped it, you can remove the 'skip-ews' label from GitHub UI, click on 
specific status-bubbles for the queues you want to run EWS on, and then click 
"Rebuild" for those skipped builds. That way you could run EWS on specific 
queues.

Also, please note that the word 'Rebuild' and "Builder" comes from buildbot 
terminology, and might be little confusing for some of us, as we use 
terminology of "Builder" and "Tester" queues which means building WebKit and 
running tests. However, buildbot refers any queue as "Builder', and it refers 
retrying an EWS run as "Rebuild". Pressing "Rebuild" button on a tester queue 
(e.g.: webkitpy-ews) might not involve building WebKit or anything.

Please let me know if anyone has any question.

Thanks
Aakash

> On Feb 20, 2023, at 4:34 PM, Aakash Jain  wrote:
> 
> Hi Everyone,
> 
> I am happy to announce a new feature in EWS: "Login with GitHub".
> 
> In Bugzilla world, we have a feature named "Retry failed builds" which allow 
> us to retry the EWS builds which failed (especially useful when the failure 
> might be due to flakiness or infrastructure issue). However, in GitHub world, 
> there was no way for WebKittens to retry the builds until now.
> 
> From now on, when you visit any ews-build.webkit.org page (e.g.: the page 
> which opens on clicking on any EWS status-bubble), you would be able to login 
> to it using your existing GitHub account. To login, on any ews buildbot page, 
> simply click on "Anonymous" -> "Login with GitHub" (on top-right). You will 
> need to authorize "WebKit EWS" to access your GtiHub account to Login.
> 
> After login, any WebKit contributor (listed in 
> https://github.com/orgs/WebKit/teams/contributors/members) can press 
> "Rebuild" button on any build. This would provide ability to retry not just 
> the failing builds, but any builds, including failed, cancelled, skipped or 
> even successful builds (for example if last EWS run on a PR was many days 
> back and you want to run EWS again). Please click on this button only when 
> needed, as unnecessary retries might waste resources.
> 
> If you are not listed in 
> https://github.com/orgs/WebKit/teams/contributors/members and should have 
> been listed there (e.g.: you are in contributors.json and have listed your 
> GitHub account in it), please let me (or any WebKit admin) know.
> 
> As always, please feel free to let me know if you notice any issue or have 
> any feedback.
> 
> Thanks
> Aakash

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Announcing Login with GitHub on EWS webpages

[Aakash Jain via webkit-dev]

I have also deployed the same "Login with GitHub" feature on build.webkit.org 
(post-commit CI). Very small subset of our users (especially admins, 
bot-watchers etc.) actually need to login on build.webkit.org . On 
build.webkit.org, one common operation is to do "Force Clean build" (which does 
a clean build instead of incremental build). Any admin or WebKit reviewer can 
now login and perform that operation. If anyone feels like any other 
functionality needs to be exposed to wider audience, please let me know.

Also, as always, please feel free to let me know if you notice any issue or 
have any feedback.

Thanks
Aakash

> On Feb 22, 2023, at 2:29 PM, Aakash Jain  wrote:
> 
> One cool trick can be to combine this feature with "skip-ews" GitHub label 
> (or --no-ews flag in git-webkit, announced in 
> https://lists.webkit.org/pipermail/webkit-dev/2023-January/032461.html).
> 
> For example, if you want to run EWS only on certain queues (e.g.: while 
> debugging/iterating on a particular platform), you can create the PR with 
> "git-webkit --no-ews", once most of the queues have processed the PR and 
> skipped it, you can remove the 'skip-ews' label from GitHub UI, click on 
> specific status-bubbles for the queues you want to run EWS on, and then click 
> "Rebuild" for those skipped builds. That way you could run EWS on specific 
> queues.
> 
> Also, please note that the word 'Rebuild' and "Builder" comes from buildbot 
> terminology, and might be little confusing for some of us, as we use 
> terminology of "Builder" and "Tester" queues which means building WebKit and 
> running tests. However, buildbot refers any queue as "Builder', and it refers 
> retrying an EWS run as "Rebuild". Pressing "Rebuild" button on a tester queue 
> (e.g.: webkitpy-ews) might not involve building WebKit or anything.
> 
> Please let me know if anyone has any question.
> 
> Thanks
> Aakash
> 
>> On Feb 20, 2023, at 4:34 PM, Aakash Jain  wrote:
>> 
>> Hi Everyone,
>> 
>> I am happy to announce a new feature in EWS: "Login with GitHub".
>> 
>> In Bugzilla world, we have a feature named "Retry failed builds" which allow 
>> us to retry the EWS builds which failed (especially useful when the failure 
>> might be due to flakiness or infrastructure issue). However, in GitHub 
>> world, there was no way for WebKittens to retry the builds until now.
>> 
>> From now on, when you visit any ews-build.webkit.org page (e.g.: the page 
>> which opens on clicking on any EWS status-bubble), you would be able to 
>> login to it using your existing GitHub account. To login, on any ews 
>> buildbot page, simply click on "Anonymous" -> "Login with GitHub" (on 
>> top-right). You will need to authorize "WebKit EWS" to access your GtiHub 
>> account to Login.
>> 
>> After login, any WebKit contributor (listed in 
>> https://github.com/orgs/WebKit/teams/contributors/members) can press 
>> "Rebuild" button on any build. This would provide ability to retry not just 
>> the failing builds, but any builds, including failed, cancelled, skipped or 
>> even successful builds (for example if last EWS run on a PR was many days 
>> back and you want to run EWS again). Please click on this button only when 
>> needed, as unnecessary retries might waste resources.
>> 
>> If you are not listed in 
>> https://github.com/orgs/WebKit/teams/contributors/members and should have 
>> been listed there (e.g.: you are in contributors.json and have listed your 
>> GitHub account in it), please let me (or any WebKit admin) know.
>> 
>> As always, please feel free to let me know if you notice any issue or have 
>> any feedback.
>> 
>> Thanks
>> Aakash
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Announcing Login with GitHub on EWS webpages

[Aakash Jain via webkit-dev]

Hi Everyone,

I am happy to announce that we expanded this feature and now any person with 
WebKit committer or reviewer privilege can also press "Stop" button on any 
ongoing EWS build. This is intended to be used in scenarios like:

- You got the required information from EWS (as some important EWS failed and 
you need to iteration on the PR/patch), and no longer need builds on other 
EWSes. (note that adding skip-ews GitHub label on the PR is another option to 
achieve similar thing)

- Cancelling any bad builds which seems to be stuck (e.g.: every api test 
timing out due to bug in PR/patch and test-run taking multiple hours)

- Trying to iterate over multiple versions of PR/patches for a particular 
platform, when you don't need builds on other platform for those iterations

- You don't need a specific EWS run and want to save EWS resources

Please use your own good judgement in deciding when to press that button.

Thanks
Aakash

> On Feb 23, 2023, at 4:18 PM, Aakash Jain  wrote:
> 
> I have also deployed the same "Login with GitHub" feature on build.webkit.org 
> (post-commit CI). Very small subset of our users (especially admins, 
> bot-watchers etc.) actually need to login on build.webkit.org . On 
> build.webkit.org, one common operation is to do "Force Clean build" (which 
> does a clean build instead of incremental build). Any admin or WebKit 
> reviewer can now login and perform that operation. If anyone feels like any 
> other functionality needs to be exposed to wider audience, please let me know.
> 
> Also, as always, please feel free to let me know if you notice any issue or 
> have any feedback.
> 
> Thanks
> Aakash
> 
>> On Feb 22, 2023, at 2:29 PM, Aakash Jain  wrote:
>> 
>> One cool trick can be to combine this feature with "skip-ews" GitHub label 
>> (or --no-ews flag in git-webkit, announced in 
>> https://lists.webkit.org/pipermail/webkit-dev/2023-January/032461.html).
>> 
>> For example, if you want to run EWS only on certain queues (e.g.: while 
>> debugging/iterating on a particular platform), you can create the PR with 
>> "git-webkit --no-ews", once most of the queues have processed the PR and 
>> skipped it, you can remove the 'skip-ews' label from GitHub UI, click on 
>> specific status-bubbles for the queues you want to run EWS on, and then 
>> click "Rebuild" for those skipped builds. That way you could run EWS on 
>> specific queues.
>> 
>> Also, please note that the word 'Rebuild' and "Builder" comes from buildbot 
>> terminology, and might be little confusing for some of us, as we use 
>> terminology of "Builder" and "Tester" queues which means building WebKit and 
>> running tests. However, buildbot refers any queue as "Builder', and it 
>> refers retrying an EWS run as "Rebuild". Pressing "Rebuild" button on a 
>> tester queue (e.g.: webkitpy-ews) might not involve building WebKit or 
>> anything.
>> 
>> Please let me know if anyone has any question.
>> 
>> Thanks
>> Aakash
>> 
>>> On Feb 20, 2023, at 4:34 PM, Aakash Jain  wrote:
>>> 
>>> Hi Everyone,
>>> 
>>> I am happy to announce a new feature in EWS: "Login with GitHub".
>>> 
>>> In Bugzilla world, we have a feature named "Retry failed builds" which 
>>> allow us to retry the EWS builds which failed (especially useful when the 
>>> failure might be due to flakiness or infrastructure issue). However, in 
>>> GitHub world, there was no way for WebKittens to retry the builds until 
>>> now.
>>> 
>>> From now on, when you visit any ews-build.webkit.org page (e.g.: the page 
>>> which opens on clicking on any EWS status-bubble), you would be able to 
>>> login to it using your existing GitHub account. To login, on any ews 
>>> buildbot page, simply click on "Anonymous" -> "Login with GitHub" (on 
>>> top-right). You will need to authorize "WebKit EWS" to access your GtiHub 
>>> account to Login.
>>> 
>>> After login, any WebKit contributor (listed in 
>>> https://github.com/orgs/WebKit/teams/contributors/members) can press 
>>> "Rebuild" button on any build. This would provide ability to retry not just 
>>> the failing builds, but any builds, including failed, cancelled, skipped or 
>>> even successful builds (for example if last EWS run on a PR was many days 
>>> back and you want to run EWS again). Please click on this button only when 
>>> needed, as unnecessary retries might waste resources.
>>> 
>>> If you are not listed in 
>>> https://github.com/orgs/WebKit/teams/contributors/members and should have 
>>> been listed there (e.g.: you are in contributors.json and have listed your 
>>> GitHub account in it), please let me (or any WebKit admin) know.
>>> 
>>> As always, please feel free to let me know if you notice any issue or have 
>>> any feedback.
>>> 
>>> Thanks
>>> Aakash
>> 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev