Re: [webkit-dev] CDMi interface for EME?
On 06/10/2014 12:51 PM, Maciej Stachowiak wrote: But I don’t think we’d want to support pluggable CDMs as an extension point on any of Apple’s ports (which is the whole point of CDMi), only the ones we support already. So the question is whether there are any other WebKit ports that would like to support pluggable CDMs. Do you mind me asking your reasoning for this? Are CDMs easy enough to implement that it's not worth making them usable in multiple browsers? Or maybe you already have all of the CDMs you care to support? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] CDMi interface for EME?
On 06/10/2014 02:36 PM, Maciej Stachowiak wrote: We have no current plans to make it an extension point for Mac or iOS Safari or for other WebKit clients. We don’t like binary plugins of any kind, and content providers seem satisfied with what we can offer as built-in CDMs (for example, see http://techblog.netflix.com/2014/06/html5-video-in-safari-on-os-x-yosemite.html). So we don’t see the value proposition of allowing third-party CDMs to be plugged in. If you disagree with that stance and have a specific use case, feel free to submit that feedback via bugreport.apple.com http://bugreport.apple.com or to Apple Developer Relations. It is not really a suitable topic to debate on webkit-dev. Other WebKit ports may feel differently, and may want an interface to plug in third-party CDMs. That is up to them. I don’t have any objection to other WebKit ports using this mechanism, I’m just reporting that it wouldn’t be especially useful to us. Ok, thanks for the info. I'll bring it up with the GTK developers (if they support EME at all..) if we decide to move forward with this in WebKit. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] CDMi interface for EME?
I'm looking into EME https://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html and something I've been asked to investigate is Microsoft's proposed CDMi interface http://www.microsoft.com/playready/documents/default.aspx#CDMSpec, and if we could use it in WebKit. The idea is that we would expose a few common interfaces (see page 12 of the PDF at that link), like Cdm_MediaKeys(wchar_t *keySystem) constructor, createSession(wchar_t* type, const unsigned char *initData, const unsigned char *AppData) to create a CDM session, etc. The advantage of this would be that we could create CDMs for each platform and then re-use them in multiple browsers. Is there any interest in this in WebKit? I'm starting to look through the code to see how it could be done (presumably implement CDMPrivate / CDMPrivateInterface to use CDMs matching this interface), but I figured I'd go to the source and see if anyone has looked into doing this before. Thanks, Brendan Long CableLabs, Inc. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch
Doesn't 'webkit-patch upload' already do that? On 04/04/2014 02:14 AM, James Craig wrote: I sometimes forget to run the check-webkit-style script before uploading patches, so I put a patch up for review that adds a --style and --no-style flags to prepare-Changelog and svn-create-patch. Alexey suggested I make it the default, which I've done for prepare-Changelog, but not in svn-create-patch due to cross-references that cause a loop when it't the default. (I just added the --style flag to my local bash alias.) Any concerns or suggestions? Thanks. http://webkit.org/b/131115 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Regarding exposing function using webkit idl
I'm not aware of a void pointer type in WebIDL. Maybe you want any or object? On Thu, 2014-01-30 at 22:32 +0530, Chandrakant Rinayat wrote: Hi, I am trying to expose one function in webkit idl ,which is taking void pointer as an argument. But When I am exposing, I am facing the errorerror: invalid use of 'void' in WebkitDomtest.h file. I think its parsing error. Kindly please suggest a way to expose this type of function in webkit idl . Please do the needful. Thanks Regards Chandrakant ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] When to use auto? (I usually consider it harmful)
On Thu, 2014-01-02 at 13:12 -0800, Geoffrey Garen wrote: I think an appropriate style guideline for “auto” would say something like: - Use “auto to declare a disgusting templated iterator type in a loop - Use “auto… - to define a template-dependent return type in a class template - In all other cases, use an explicit type declaration It would be nice if we could use this with Type::create() functions too, like: auto track = AudioTrackPrivateGStreamer::create(...); Unfortunately the type would be PassRefPtr, not RefPtr, which would probably not be what we want. Maybe we could do it by just removing PassRefPtr and adding a move constructor to RefPtr? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] std::shared_ptr?
On 10/25/2013 06:38 PM, Darin Adler wrote: We are replacing PassOwnPtr and OwnPtr with std::unique_ptr. This is part of a general trend where we are adopting some C++11 language and library features. Is there any plan to replace RefPtr with std::shared_ptr too, or is there some reason why that would be a bad idea? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] std::shared_ptr?
One of the answers on this Stack Overflow question http://stackoverflow.com/questions/3628081/shared-ptr-horrible-speed suggests that we can fix the memory issue by using `making_shared`: *use* |make_shared| http://en.cppreference.com/w/cpp/memory/shared_ptr/make_shared *to allocate them*, because (unfortunately) the normal constructor allocates two different blocks: one for the object and one for the counter and deleter. Unfortunately, it looks like http://nerds-central.blogspot.com/2012/03/sharedptr-performance-issues-and.html they're really slow because they're thread-safe, but that may also apply to RefPtr. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 04:14 AM, gstreamer MACOSX wrote: Exactly, Philippe: I searched everywhere by D:\Users\gstreamermacosx\webkit\Source but without any success. I applyed this command like my counterparts ... : *git clone /http://git.igalia.com/webkit.git/* Is it correct ? In fact, there is not even any Source/*WTF *sub-folder. I think he meant you should use the normal repo: git clone git://git.webkit.org/WebKit.git (Or use SVN if you're into that?) Rebasing a patch from a 3-year-old checkout would be extremely difficult, so it's easier to figure out what the patch does, and re-apply it manually on a new checkout. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 10:39 AM, Mital Vora wrote: I have few questions regarding move to Gstreamer. * are we gonna replace the existing openssl and curl with libsoup ? The GStreamer media player https://github.com/WebKit/webkit/tree/master/Source/WebCore/platform/graphics/gstreamer already exists. You don't need to write it from scratch, you just need to make your port use it. * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. Chrome uses FFMPEG, so if you look at the source when the Blink fork happened, there might be a working FFMPEG media player. I'm not familiar enough to say why it might be better, but Chrome and Firefox both use FFMPEG, so it's clearly workable. The downside will be that no other ports are currently using FFMPEG, so your media player might get less attention. By moving to gstreamer would increase dependencies size a lot as the all GTK base libraries would be included by default and this would be concern to atleast few of us who does not want to increase the webkit base dependencies library by huge amount. GStreamer depends on GLib, not GTK. I don't know how GLib will effect the binary size though. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 10:39 AM, Mital Vora wrote: * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. By the way, if this is just for Windows, you may want to look at Media Foundation https://en.wikipedia.org/wiki/Media_Foundation. Also, I took at look at the media players before Chromium was removed, and I didn't see an FFMPEG media player. Maybe Chromium's media player has always been in the Chromium tree instead of the WebKit tree. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 12:08 PM, Brent Fulgham wrote: The only problem with Media Foundation is that it is Vista-and-newer only. There is no Windows XP version. Does WebKit still build on XP? signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 12:18 PM, Brent Fulgham wrote: On Oct 14, 2013, at 11:12 AM, Brendan Long s...@brendanlong.com wrote: Does WebKit still build on XP? Yes. And it is intended to stay that way for the foreseeable future. In that case, it may be better to use DirectShow https://en.wikipedia.org/wiki/DirectShow. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : Gstreamer claimed as a default player = CPP files needed (ex: ...gobject\GlibUtilities.cpp)
On 10/14/2013 02:33 PM, Urbain EGIS wrote: Alex: could you pls provide us with Webkit files related to Gstreamer integration ? GStreamer support is already included in the main WebKit repo. Look in Source/WebCore/platform/graphics/gstreamer. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/11/2013 02:13 PM, Urbain EGIS wrote: Playing a bit with WebKit sources for Windows (using WinCairo port) I expected to activate HTML5 video tag. I just simply put : #define ENABLE_VIDEO 1 and rebuilt everything. But I realized that only few files are concerned by USE(ENABLE_VIDEO) and are not even .CPP files. It would be ENABLE(VIDEO), not USE(ENABLE_VIDEO). So something may have been falling through the net... But what ? What is missing from Visual Studio generation ? Which procedure shall be applied to get .CPP files included into MS projects ? Most likely you need to specifiy which media player to use. For example, to use GStreamer you would define WTF_USE_GSTREAMER. I don't see a DirectShow media player, so GStreamer is probably your best bet. You can look through the players by looking at file starting with MediaPlayerPrivate, for example: * AV Foundation (Mac) * Blackberry * GStreamer * QTKit (QuickTime?) * WinCE signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Reference count leak with InBandTextTracks?
I've been working on the GStreamer version of in-band text tracks, but I haven't looked at the details of how RefPtr works. My guess is that JavaScript is holding those extra refs, and the clear memory cache forces a JS garbage collect. On 10/01/2013 03:48 AM, Benjamin Dupont (bedupont) wrote: Hi all, I am currently working on the InbandTextTracks in webkit and I am trying to understand how the memory is released. When we launch the track-in-band.html layout test, two in-band text tracks have been created and added, the corresponding RefPtr has a refCount equals to three. 1. Why are there 3 owners for each in-band text track? Is there an hidden cache mechanism? After this test, if we load another page, the player is destroyed and the clearTextTracks method is called. In my understanding, the player should be the only owner of in-band text tracks and thus after the clearTextTracks method is called, the ref count should be decreased to 0 and the in-band text track object should be deleted. In fact, after the clearTextTracks method the ref count isn't equals to 0 thus the in-band text track object isn't deleted. This text track object is deleted when the clear memory cache is called. 2. Is it a normal behavior? If yes, what is the interest to use smart pointer? 3. How does the clear memory cache know that this ref pointer (with a ref count != 0) can be released? Thanks in advance for your explanations, Regards, Benjamin Dupont. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] EDITBUGS permission?
Is this the right mailing list to ask for EDITBUGS permission? I have 16 accepted patches, and it would be nice if I could assign bugs to myself. http://trac.webkit.org/search?q=Patch+by+Brendan+Long My email on the WebKit bug tracker is: b.l...@cablelabs.com signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposed feature: Network Service Discovery
On 09/06/2013 10:59 AM, Oliver Hunt wrote: On Sep 6, 2013, at 9:44 AM, youenn fablet youe...@gmail.com mailto:youe...@gmail.com wrote: For starters, most of users wouldn't even know what a local network is; let alone what discovering media sources, etc... mean. Most users may not be able to understand what means discover local network DACP servers. But if a user is requested to grant/deny access to Bob music library service (the service being a DACP server), the situation seems getting better. The spec is a work in progress and may be improved. For the sake of argument let's say this discovery is allowed to occur. How do you talk to Bob music library without the web page sending raw data to/from the DACP server? The spec isn't very clear about how the permissions work, but I think we could protect users from accidentally giving permission and fingerprinting by making the permissions work like this: * When prompting the user for permission, get the list of discovered services and ask the user if they want to give the application access to any of them. An implementation could using checkboxes, for example, but with the default state being unchecked. If the user clicks ok without looking at it, the result is an empty list. * Remove PERMISSION_DENIED_ERR. If permission is denied, just return an empty object. This way, a JavaScript application can't tell the difference between an empty network and not having permission to see any of the services. I'll look into proposing this change to the spec. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposed feature: Network Service Discovery
On 08/29/2013 05:45 PM, Benjamin Poulain wrote: Can you explain a bit what it is for? What are the common use cases? This would be useful for certain kinds of web apps. For example,a music website like Pandora or Spotify could allow users to include music on their local network. Or a service like Netflix could include local network movies (on networked hard drives, or DVR's) in their search results, and play them from the same interface. Or use-case is to make a media center UI entirely in HTML5 (huge portability benefits), and to allow that UI to discovery local DLNA HTML5 Remote UI's (I'd love to put a link to what this is, but the spec isn't public and the best link is our own page http://html5.cablelabs.com/dlna-rui/index.html about it). The use-cases would probably be more interesting if browsers were able to advertise themselves, but that's not part of this spec unfortunately. I suspect that Firefox would be interested, since it fits into the Firefox OS idea, but it looks like no one has really talked to them about it yet. Who already implements it? Opera supports it http://dev.opera.com/articles/view/network-service-discovery-api-support-in-opera/ (it looks like an experimental build though). This person http://jcdufourd.wp.mines-telecom.fr/2013/05/15/network-service-discovery-api/ made a Java applet to add support to existing browsers. There's a thread on the Chromium mailing list https://groups.google.com/a/chromium.org/forum/#%21topic/blink-dev/HT0KZKuTLxM about this. It sounds like they're planning to update the spec before implementing it though, since there's some strange requirements for garbage collection and they want to do a review of the security and privacy implications. mark a. foltz said, Adam, Thanks for your feedback. (I'm working with Justin on this.) I'll summarize our response and plan. (1) Agreed that a longer discussion of the security and privacy implications of the API is warranted. Rich posted a section to the spec [1] that is a good starting point; I plan on working with the editors on minimizing the opportunities for harm, and minimizing the ability to fingerprint users of the API, which was brought up by the Chrome privacy team. (2) Rich posted an update to the spec to address the language around garbage collection. https://dvcs.w3.org/hg/dap/diff/b4b2569b4e9b/discovery-api/Overview.src.html https://dvcs.w3.org/hg/dap/diff/b4b2569b4e9b/discovery-api/Overview.src.html (3) I reviewed the last several months of list traffic and, to my ability to scan, haven't seen comments or commitment from other browser vendors. I'll let Rich fill in if there are any updates here. I think an effort to evangelize and get additional participation will be helpful to the spec as a whole. Given the current set of feedback, we plan on working with the spec editors and coming back when we feel it is ready to implement. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposed feature: Network Service Discovery
On 08/29/2013 09:37 PM, Sam Weinig wrote: I don't think this belongs in WebKit, as this doesn't seem like it would ever be appropriate to expose to the Web at large. I recommend trying to find a way to layer this on top of WebKit if it is something you need to support. While our use-case is definitely possible to implement outside of WebKit, I think the spec is useful for some kinds of applications. Right now, that's mainly media-related websites, which could benefit from access to local music and videos. Even if this API was only available to privileged apps (locally installed apps, from the app store for example), it would be a benefit to app developers, because they wouldn't need to use platform-specific API's. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposed feature: Network Service Discovery
On 08/30/2013 11:06 AM, Oliver Hunt wrote: Here's my concern - if you say a service like x might want to search for something, that is better described as a random website. That may be something the user wants, alternatively it could be something evil. It could also be something evil embedded in an ad on the site a user trusts. My concern here is that as a web spec this essentially acts as a way for arbitrary web content from any source to perform a network scan of your local machine and get data about your internal network topology and services from inside your firewall. That's a really scary concept to me. This would require permission from the user, but it's definitely a valid concern that: * Users frequently ok on any popup, so maybe that's not good enough. * This could be pretty scary, combined with cross-site scripting attacks (or advertising). Would this be useful in WebKit if it was only enabled for apps with special privileges (HTML apps from the app store, for example)? signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Proposed feature: Network Service Discovery
We would like to implement the Network Service Discovery spec http://www.w3.org/TR/discovery-api/ in WebKIt. There's an existing bug https://bugs.webkit.org/show_bug.cgi?id=101162 (with a basic patch to show the API) in the bug tracker. This is useful to allow media applications to discover network media sources, players or DLNA remote UI's (and presumably plenty of other things). I was planning to start by implementing SSDP https://en.wikipedia.org/wiki/Simple_Service_Discovery_Protocol, using GSSDP https://wiki.gnome.org/GUPnP, targetting QtWebKit (and probably WebKitGTK and WebKit-EFL as a side-effect). The API itself is pretty simple, but I'll probably need some help fitting it into WebKit. Does anyone have any opinions about this? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] too much spam email is too much
On 08/06/2013 10:02 AM, Mihai Maerean wrote: Since I started working on WebKit, the amount of spam I'm receiving has grown continuously. I'm thinking that this is caused by Bugzilla showing the full email addresses even if the visitors (spam crawlers) are not logged in. My suggestion is that Bugzilla should display the full email address only if the visitor is logged in. The same email addresses are in the public commit log, which is even easier to parse: https://github.com/WebKit/webkit/commits/master I suspect the best solution is spam filtering or a special for-public-use email address. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] When should I use AtomicString vs String?
On 06/01/2013 10:09 PM, Glenn Adams wrote: But the name did throw me, since I asked myself what makes this more 'atomic' than String, synchronicity wise? I'm sure I'm not the only one who wondered about this. Before asking this question I had assumed AtomicString was an atomic type http://en.cppreference.com/w/cpp/atomic/atomic (as in, safe to use in multi-threaded code). InternedString would have been more obvious, but the biggest problem was that searching for WebKit AtomicString didn't return any results that explained what it was. Now the top hit http://trac.webkit.org/wiki/EfficientStrings has an explanation, so it's not a big deal. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] When should I use AtomicString vs String?
I hope this isn't a stupid question, but I can't find any references to what the difference between AtomicString and String is. It looks like AtomicString is generally preferred, but I don't know why. Can someone fill me in on this? Is there any refences for the classes in WTF? signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] When should I use AtomicString vs String?
So should I just never use String and always use AtomicString? On 05/31/2013 03:14 PM, Daker Pinheiro wrote: It is faster to compare and hash AtomicString than regular Strings. On Fri, May 31, 2013 at 5:57 PM, Brendan Long s...@brendanlong.com mailto:s...@brendanlong.com wrote: I hope this isn't a stupid question, but I can't find any references to what the difference between AtomicString and String is. It looks like AtomicString is generally preferred, but I don't know why. Can someone fill me in on this? Is there any refences for the classes in WTF? ___ webkit-dev mailing list webkit-dev@lists.webkit.org mailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Daker Fernandes Pinheiro http://codecereal.blogspot.com signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
