Re: [webkit-dev] Documentation on internals of WebKit

[David Kilzer]

On Tuesday, July 14, 2009 3:28:27 AM, Jack Wootton wrote:

> I'm sure there are other good blog entries, and the standard seems to
> be quite high, unfortunately I haven't found a page which lists the
> entries away from all the ...is now a webkit reviewer" or allows a
> search of them.  All I can do is provide this link:
> http://webkit.org/blog/ where you can trawl through all the blog
> entries searching for something useful.


You may use Google to search the blog entries for you using the "site:" keyword:

site:webkit.org/blog "render tree"



Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

Quilt?  

What workflow are you trying to accomplish?  I'm not sure I understand what a 
"changelist" is in this context and how bugzilla-tool would support them.

Dave



>
>From: John Abd-El-Malek 
>To: Ojan Vafai 
>Cc: WebKit Development ; Mark Rowe 
>
>Sent: Friday, July 10, 2009 5:11:53 PM
>Subject: Re: [webkit-dev] Changes to prepare-ChangeLog
>
>>To add another tangent to this thread: one thing I don't like about ChangeLog 
>>files is that they make it impossible to have multiple concurrent changes in 
>>the same checkout.  Yes I know that some people use git to get around this, 
>>while others use the svn-apply/svn-unapply scripts.  But I feel these are 
>>just workarounds to get around limitations of the current tools.  We should 
>>fix the tools instead.  If we don't require to change one central file for 
>>each change, then bugzilla-tool can be modified to support changelists.
>
>
>On Thu, Jul 9, 2009 at 1:45 PM, Ojan Vafai  wrote:
>
>>>While having consistency in changelog descriptions is nice, I'm not sure we 
>>>need to explicitly deal with the case of having multiple authors or multiple 
>>>bugs for a change. Those are rare enough situations that it's fine for 
>>>people to include that information however they want.
>>
>>
>>Or, if you don't agree with me, we can at least make those a separate 
>>discussion. It would be nice if this discussion could focus on what goes in 
>>the default text of a changelog description.
>>
>>
>>
>>The original goal here was to reduce the number of patches that get r-'ed for 
>>unnecessary changelog errors. Multiple authors rarely, if ever, results in an 
>>r-. Similarly, multiple bugs is rarely an issue for new contributors.
>>
>>
>>Ojan
>>
>>
>>On Thu, Jul 9, 2009 at 1:30 PM, Mark Rowe  wrote:
>>
>>
>>On 2009-07-09, at 08:02, Joe Mason wrote:
>>>
>>>
>>>Maciej Stachowiak wrote:

>Now that my attention has been called to it, it's starting to bug me 
>that everyone formats their ChangeLog entries slightly differently. 
>How about this as the canonical format (with prepare-ChangeLog 
>encouraging it)?
>
That reminds me: how do we format a patch with multiple authors?  I've 
been doing this:


>2009-07-08  Maciej Stachowiak  
>>   Make prepare-ChangeLog less shouty
>>   https://bugs.webkit.org/show_bug.cgi?id=27098
>
> Authors: Maciej Stachowiak , Joe Mason 
> 

>   Reviewed by Mark Rowe.
>>   * Scripts/prepare-ChangeLog:
>
So, the main author (or whichever one is submitting the patch if that's 
unclear) in the header, then a separate "Authors" line above the 
Reviewer line with everyone who deserves credit.

>>>
>>>I've never seen this format used in WebKit patches.
>>>
>>- Mark
>>>
>>>
>>>
>>>___
>>webkit-dev mailing list
>>>webkit-dev@lists.webkit.org
>>>http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>
>>___
webkit-dev mailing list
>>webkit-dev@lists.webkit.org
>>http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Patch process - let's make it better

[David Kilzer]

On Friday, July 10, 2009 3:55:59 PM, Maciej Stachowiak wrote:


> A) Make it really easy to submit a patch. Eric's bugzilla-tool is close to 
> being 
> there. I'm going to help him refine this tool to the point that submitting a 
> patch has only one step - a single command will make the patch, file a bug if 
> needed, attach the patch to the bug, and flag it for review.


I already took a first pass at this for git, which probably gets you 60-70% of 
the way there for svn:

bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

> B) Make it really easy to commit a patch. Again, I think bugzilla-tool is the 
> right path to achieving this.


bugzilla-tool already does this.  Today.  It's freaking awesome.  You can even 
specify whether you want to build and/or test the patch!  (N.B. I haven't tried 
it with an svn working directory, but the support is already there.)

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to the our dysfunctional build family)

[David Kilzer]

> At one point, I started on a script (located in 
> WebKitTools/Scripts/update-sources-list.py) whose idea
> was to take the list of common sources from one file,
> and make changes to MSVC, Qt, GTK, etc. build systems,
> so that WebKit devs need only add the file once, run
> the script, and commit the results. I got it as far as
> theoretically generating the Qt and GTK file lists, but
> I don't think anyone on those ports tried integrating
> it into their build system, and I sort of moved on to
> other things.

I should add that I haven't felt enough pain (maybe my threshold is too high?) 
to attempt to write a script that updates all of the build systems when adding 
a new source file.

Instead of regenerating parts of the build files, I though such a script should 
simply do in-place edits of each of the build files.  My current thinking was 
that if you could provide an "example" source file that would be in the same 
"group" as the new source file, then you could embed less knowledge about each 
build format in the tool and just make it smart enough to add new lines for the 
source file for each build file.  (For example, on Xcode project files, the 
only extra thing you'd need to do when adding a new file is to generate an ID 
for the new file(s) that didn't already exist in the current project file.)  I 
think this would probably handle the most common cases.

Dave



- Original Message 
> From: Kevin Ollivier 
> To: Dimitri Glazkov 
> Cc: Mark Mentovai ; WebKit Development 
> 
> Sent: Friday, July 10, 2009 8:52:57 AM
> Subject: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to 
> the our dysfunctional build family)
> 
> Hi Dimitri and all,
> 
> Congrats on getting this into WebKit! Actually, I'm in the middle of a build 
> system switch as well - to waf, a re-write of scons that removed many of the 
> performance issues related to searching and calculating dependencies, and 
> which 
> has added some nice features as well (such as .app bundle building). I 
> haven't 
> completed the switch so I can't do preliminary benchmarks, but I'm pretty 
> sure 
> it's actually as fast or faster than make on *nix/Mac. (And BTW, it will 
> probably make Apple devs happy to hear that I'm no longer using the horrid 
> build-wxwebkit bash script to manage the build, but instead have integrated 
> everything into build-webkit finally!)
> 
> The main reason I bring this up, though, is because I think this sort of 
> thing 
> shows that we're unlikely to centralize our build systems any time soon, and 
> I 
> feel a bit sorry for the core devs who, as they accept new ports, are 
> probably 
> finding it more and more tedious, if not difficult, to make sure all the 
> projects get updated by a change to the common parts of the build. They've 
> been 
> very helpful in terms of trying to keep the ports in shape when they make 
> changes, and I feel like I'd like to do what I can to make it easier and 
> faster 
> to keep the other ports in sync.
> 
> At one point, I started on a script (located in 
> WebKitTools/Scripts/update-sources-list.py) whose idea was to take the list 
> of 
> common sources from one file, and make changes to MSVC, Qt, GTK, etc. build 
> systems, so that WebKit devs need only add the file once, run the script, and 
> commit the results. I got it as far as theoretically generating the Qt and 
> GTK 
> file lists, but I don't think anyone on those ports tried integrating it into 
> their build system, and I sort of moved on to other things.
> 
> Unfortunately, right now I'm really swamped (my build system rewrite was 
> prompted by WebKit exceeding internal, hardcoded, Bakefile limits, not by 
> choice), but if a common location for the source files list could be decided 
> upon, I really think a script would be a simple matter to write up (even in 
> Perl 
> :P ), and I think it would probably save developers time and reduce build 
> breakages as well, which I think would add up to a lot of saved time for a 
> lot 
> of people over the long term. The only format I'm not sure if we could 
> automate 
> reliably would be the XCode format (at least, on non-Mac machines), because 
> IIUC 
> we'd need some sort of parser for it, but Apple is the only port maintaining 
> those directly IIUC, as now Chromium will be using GYP to update their XCode 
> projects. So even if we couldn't solve the XCode issue, that would drop it to 
> updating two locations tops.
> 
> So, does anyone think this would be a bad idea, or have any alternate 
> suggestions on how to improve things? If not, is anyone willing to take the 
> ball 
> and run with it? I'd be willing to invest some more time in it, but my 
> ability 
> to commit to it over the next couple weeks at least would be very limited.
> 
> Thanks,
> 
> Kevin
> 
> On Jul 9, 2009, at 9:23 PM, Dimitri Glazkov wrote:
> 
> > Dear WebKiteurs,
> > 
> > In our persisting quest to be more like a common WebKit port, we have
> > added Chromium 

Re: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to the our dysfunctional build family)

[David Kilzer]

> So, does anyone think this would be a bad idea, or have any
> alternate suggestions on how to improve things?


What about adding support for waf to gyp?

> The only format I'm not sure if we could automate > reliably would be the 
> XCode format (at least, on non-Mac
> machines), because IIUC we'd need some sort of parser for it,
> but Apple is the only port maintaining those directly IIUC,
> as now Chromium will be using GYP to update their XCode 
> projects.

If you hand-edit Xcode project files enough times you start to understand them, 
but you also may go insane in the process.  I don't know that you have to write 
a full parser for it, but there is some non-trivial, minimal structure you have 
to understand to update the file properly.

> So even if we couldn't solve the XCode issue, that
> would drop it to updating two locations tops.

I count 6 build systems in use currently (SCons support was added and removed 
within the last year):

- Apple's Xcode
- Apple's vcproj (also used by at least one other Windows port)
- wx Bakefile (which will be replaced by waf soon)
- Qt Qmake
- GTK GNUMakefile
- Google's gyp (added recently)

Are any of the other ports going to switch to generating their build files 
using gyp?

Dave



- Original Message 
> From: Kevin Ollivier 
> To: Dimitri Glazkov 
> Cc: Mark Mentovai ; WebKit Development 
> 
> Sent: Friday, July 10, 2009 8:52:57 AM
> Subject: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to 
> the our dysfunctional build family)
> 
> Hi Dimitri and all,
> 
> Congrats on getting this into WebKit! Actually, I'm in the middle of a build 
> system switch as well - to waf, a re-write of scons that removed many of the 
> performance issues related to searching and calculating dependencies, and 
> which 
> has added some nice features as well (such as .app bundle building). I 
> haven't 
> completed the switch so I can't do preliminary benchmarks, but I'm pretty 
> sure 
> it's actually as fast or faster than make on *nix/Mac. (And BTW, it will 
> probably make Apple devs happy to hear that I'm no longer using the horrid 
> build-wxwebkit bash script to manage the build, but instead have integrated 
> everything into build-webkit finally!)
> 
> The main reason I bring this up, though, is because I think this sort of 
> thing 
> shows that we're unlikely to centralize our build systems any time soon, and 
> I 
> feel a bit sorry for the core devs who, as they accept new ports, are 
> probably 
> finding it more and more tedious, if not difficult, to make sure all the 
> projects get updated by a change to the common parts of the build. They've 
> been 
> very helpful in terms of trying to keep the ports in shape when they make 
> changes, and I feel like I'd like to do what I can to make it easier and 
> faster 
> to keep the other ports in sync.
> 
> At one point, I started on a script (located in 
> WebKitTools/Scripts/update-sources-list.py) whose idea was to take the list 
> of 
> common sources from one file, and make changes to MSVC, Qt, GTK, etc. build 
> systems, so that WebKit devs need only add the file once, run the script, and 
> commit the results. I got it as far as theoretically generating the Qt and 
> GTK 
> file lists, but I don't think anyone on those ports tried integrating it into 
> their build system, and I sort of moved on to other things.
> 
> Unfortunately, right now I'm really swamped (my build system rewrite was 
> prompted by WebKit exceeding internal, hardcoded, Bakefile limits, not by 
> choice), but if a common location for the source files list could be decided 
> upon, I really think a script would be a simple matter to write up (even in 
> Perl 
> :P ), and I think it would probably save developers time and reduce build 
> breakages as well, which I think would add up to a lot of saved time for a 
> lot 
> of people over the long term. The only format I'm not sure if we could 
> automate 
> reliably would be the XCode format (at least, on non-Mac machines), because 
> IIUC 
> we'd need some sort of parser for it, but Apple is the only port maintaining 
> those directly IIUC, as now Chromium will be using GYP to update their XCode 
> projects. So even if we couldn't solve the XCode issue, that would drop it to 
> updating two locations tops.
> 
> So, does anyone think this would be a bad idea, or have any alternate 
> suggestions on how to improve things? If not, is anyone willing to take the 
> ball 
> and run with it? I'd be willing to invest some more time in it, but my 
> ability 
> to commit to it over the next couple weeks at least would be very limited.
> 
> Thanks,
> 
> Kevin
> 
> On Jul 9, 2009, at 9:23 PM, Dimitri Glazkov wrote:
> 
> > Dear WebKiteurs,
> > 
> > In our persisting quest to be more like a common WebKit port, we have
> > added Chromium build files to the tree this afternoon. These files are
> > WebCore/WebCore.gypi and JavaScriptCore/JavaScriptCore.gypi and they
> > are the GYP inclu

Re: [webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

On Thursday, July 9, 2009 11:11:05 AM, Maciej Stachowiak wrote:

> On Jul 9, 2009, at 8:52 AM, Darin Adler wrote:
> 
> > On Jul 9, 2009, at 1:47 AM, Maciej Stachowiak wrote:
> > 
> >> (the /b/ URL is a redirect):
> > 
> > I'm like most everything suggested in this thread.
> > 
> > But I'm a little sad that these new shorter URLs are redirects. I really 
> > like 
> to copy URLs out of the address field, so I’d want the legacy show_bug.cgi 
> one 
> to be the redirect, and the terse one to be the real URL. But that seems 
> impossible, possibly eternally so, if the /b/ one is at webkit.org and not on 
> the actual bugs.webkit.org server.
> 
> Mark and I discussed this and had two ideas:
> 
> 1) Something draggable/copyable in the bugzilla page that gives you the short 
> URL plus title in ChangeLog format.
> 2) A keyboard shortcut (perhaps Cmd+Shift+C?) to put the short URL plus title
> on the pasteboard for ease of pasting


Or the tool you use to attach patches to bugs.webkit.org could do the 
substitution of the bugs.webkit.org URL to the webkit.org URL for you so you 
don't have to think about it (much).

Or prepare-ChangeLog could preformat it for you so you only have to copy and 
paste the bug id:

 This is your bug title
Reviewed by NOBODY (OOPS!).

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

On Thursday, July 9, 2009 11:06:58 AM, Maciej Stachowiak wrote:

>On Jul 9, 2009, at 4:33 AM, David Kilzer wrote:
>
>>* What does the format look like for bugs with multiple URL
>>links, e.g., to  or to 
>><http://crbug.com/N>?  (The title should not have to be
>>repeated--you should be fixing the same issue for all of them.)
>
>I could think of two reasonable options?
>
> <http://webkit.org/b/27098> Make prepare-ChangeLog 
> less shouty
> Reviewed by Mark Rowe.
>
>
> <http://webkit.org/b/27098> Make prepare-ChangeLog less shouty
>  
> Reviewed by Mark Rowe.
>
>Preferences?


#2 please.

>>* Is the "Reviewed by" line going to have a blank line above it?
>>  (I think it should, but I could be persuaded otherwise.)

>
>I don't think it should, if it's one of two special lines at the
>top. Otherwise the whole ChangeLog entry looks double-spaced and
>gets harder to read.


Yeah, I've noticed that.

>>And from The-World-is-Not-Enough Department:
>>
>>* The commit-log-editor should be smart about condensing
>>duplicate content after the date-name-email lines for each
>>ChangeLog entry, and it should move those lines to the top of
>>the commit message.  (This also makes git users happy since the
>>first line would be the bug URL and description, making
>>"git log --oneline" more useful.)
>
>I'm not sure I understand this suggestion.


An illustrated example of pulling common lines out of each subsection (with 
double-spacing):

http://trac.webkit.org/changeset/44095
http://trac.webkit.org/changeset/44096

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

> 2009-07-08  Maciej Stachowiak  
> 
>   -  Make prepare-ChangeLog less shouty
>   Reviewed by Mark Rowe.
> 
>   Hypothetical long description goes here. Yeah. Very long and detailed 
> it is.
> 
>   * Scripts/prepare-ChangeLog:


Random nits (since you asked):

* Please do not put a "-" in front of the bug line.  What does that buy you 
besides (sometimes) a bullet in trac.webkit.org?

* What does the format look like for bugs with multiple URL links, e.g., to 
 or to ?  (The title should not 
have to be repeated--you should be fixing the same issue for all of them.)

* Is the "Reviewed by" line going to have a blank line above it?  (I think it 
should, but I could be persuaded otherwise.)

And from The-World-is-Not-Enough Department:

* The commit-log-editor should be smart about condensing duplicate content 
after the date-name-email lines for each ChangeLog entry, and it should move 
those lines to the top of the commit message.  (This also makes git users happy 
since the first line would be the bug URL and description, making "git log 
--oneline" more useful.)

Dave



- Original Message 
> From: Maciej Stachowiak 
> To: Maciej Stachowiak 
> Cc: WebKit Development 
> Sent: Thursday, July 9, 2009 1:47:16 AM
> Subject: Re: [webkit-dev] Changes to prepare-ChangeLog
> 
> 
> I discussed with Mark Rowe on IRC a bit and it seems like it would be nice if 
> the bug URL could be short enough to just go on one line with the summary. 
> Which 
> turns out to be totally doable. Thus the latest format proposal (the /b/ URL 
> is 
> a redirect):
> 
> 2009-07-08  Maciej Stachowiak  
> 
>-  Make prepare-ChangeLog less shouty
>   Reviewed by Mark Rowe.
> 
>   Hypothetical long description goes here. Yeah. Very long and detailed 
> it is.
> 
>* Scripts/prepare-ChangeLog:
> 
> On Jul 9, 2009, at 1:32 AM, Maciej Stachowiak wrote:
> 
> > 
> > Now that my attention has been called to it, it's starting to bug me that 
> everyone formats their ChangeLog entries slightly differently. How about this 
> as 
> the canonical format (with prepare-ChangeLog encouraging it)?
> > 
> > 2009-07-08  Maciej Stachowiak  
> > 
> >Make prepare-ChangeLog less shouty
> >https://bugs.webkit.org/show_bug.cgi?id=27098
> > 
> >Reviewed by Mark Rowe.
> > 
> >* Scripts/prepare-ChangeLog:
> > 
> > 
> > 
> > So specifically:
> > 
> > - Reviewed by line would go below, not above, to make git users happy 
> > (well, 
> happi*er*)
> > - Bug URL remains below one-line description, for git joy and scannability
> > - No angle brackets around URL, so that you can cut/paste or drag it from a 
> URL field without extra work
> > - No line between URL and summary
> > 
> > Is that a format everyone can live with for ChangeLogs and commit messages? 
> > If 
> so, I'll post a patch to update prepare-ChangeLog accordingly.
> > 
> > Regards,
> > Maciej
> > 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Max http connection per host ?

[David Kilzer]

Hi Jérôme,

The method to change the connection count is not public API, and it's not 
supported on all platforms (hence the reason it always returns 4).

Dave





From: Jérôme Lebel 
To: webkit-dev@lists.webkit.org
Sent: Monday, July 6, 2009 11:42:25 AM
Subject: [webkit-dev] Max http connection per host ?

Hi,

I'm trying to change the max http connection count per host in WebKit on OS X. 
I'm not sure if this mechanism by WebCore or by CFNetwork. I found 
wkInitializeMaximumHTTPConnectionCountPerHost(), but I'm not sure how it worked 
(since first parameter is 6 and it returns 4). I tried to change the parameter 
and the returned value, but nothing changed in WebKit.

I was not able to find any information in the CFNetwork documentation.

Thanks for the help

Jérôme,___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

On Friday, July 3, 2009 2:19:51 PM, Maciej Stachowiak wrote:

> What I do (and I think many of us do) is use a script that
> automatically fills in the commit message from the ChangeLog.

The script is WebKitTools/Scripts/commit-log-editor.  Setting one of these 
environment variables (depending on whether you're using svn or git) works 
great (replace "$WEBKIT_SRC_DIR" with the path to your webkit source, or just 
set them to "commit-log-editor" if you've added WebKitTools/Scripts to your 
PATH):

GIT_EDITOR=$WEBKIT_SRC_DIR/WebKitTools/Scripts/commit-log-editor
SVN_EDITOR=$WEBKIT_SRC_DIR/WebKitTools/Scripts/commit-log-editor

You'll also want to set the EDITOR environment variable unless you use vi to 
edit your svn/git commit logs.  :)

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] ChangeLog

[David Kilzer]

On Friday, July 3, 2009 1:01:33 PM, Joe Mason wrote:


> Even if sticking with svn, you just need to run svn2cl once when
> you update to  get a local copy of the changelog.


If each developer had to run that command to get a local changelog, I can't 
imagine the svn server would be very responsive if two or more people ran it at 
the same time.

Also, if you're already disconnected from the network, it's "too late" to run 
svn2cl if you want the full history.

--

Personally, I think git is the long-term solution since (a) git-format-patch 
includes the commit log comments in the patch format, which makes them easily 
reviewable and (b) it operates in an off-line mode making not only the log 
comments but the full repository history available.

However, not everyone on the project is comfortable with git (or is willing to 
give up svn), so I don't see a near-term solution at the moment other than 
improving the existing tools (prepare-ChangeLog, resolve-ChangeLogs, etc.).

Finally, I should note that I've found the detailed ChangeLogs created by 
prepare-ChangeLog--and written with the correct level of detail--to be 
extremely valuable in the past, especially when merging commits to a port.  I 
don't think these should ever go away.

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

On Friday, July 3, 2009 3:20:58 AM, Alexey Proskuryakov wrote:

> 02.07.2009, в 18:05, Adam Roben написал(а):
> 
> > Here's an example entry that follows the format that I (and
> > I think Dave) like:
> >
> > +2009-04-20  Adam Roben  
> > +
> > +Change MemoryStream::createInstance to return a COMPtr
> > +
> > +Part of Bug 25294: All WebKit/win classes should return COMPtrs 
> > from
> > +their static constructor members
> > +
> 
> FWIW, I rarely need to know the bug number alone - I need its
> URL to click or to copy/paste. On the other hand, the
> suggested format makes it so that one needs to skip over "Part
> of Bug 25294: " just to read the bug description, which is not
> an improvement.

This probably isn't a typical example since it's a "Part N of M" bug fix, but 
the important part is that the change is summarized on the first line (after 
the date and patch author) to give a quick overview of the patch.

> >>- I like putting angle brackets "<>" around the URL to set
> >>it off visually from other text.
> 
> Typing those brackets is more work. It's also more difficult
> to copy/paste the URL (you could just copy the whole line and
> paste it into Safari address bar when there were no garbage
> symbols around the URL)


Actually, Safari will strip the "<>" characters for you if you paste them into 
the address bar!  I didn't know this until a couple of months ago, either.

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Changes to prepare-ChangeLog

[David Kilzer]

On Wednesday, July 1, 2009 10:44:16 PM, Eric Seidel  wrote:


> Results in:
> 2009-07-01  Eric Seidel  
> 
> Reviewed by NOBODY (OOPS!).
> 
> prepare-ChangeLog should have a --bug= argument and use it for
url autofill
> https://bugs.webkit.org/show_bug.cgi?id=26383
> 
> DETAILED DESCRIPTION OF THE CHANGES GOES HERE. (OOPS!) SEE:
> http://webkit.org/coding/contributing.html FOR MORE INFORMATION
> 
> Tests: fast/foo.html
> 
> * foo.cpp: Added.


- I prefer having "Bug N: " before the actual bug description so I don't 
have to parse the URL myself for the bug number.  It also acts as a visual 
marker when I read the ChangeLog entry.

- I like putting angle brackets "<>" around the URL to set it off visually from 
other text.

- I generally move the "Reviewed by" line after the bug number/description/URL. 
 When you're reading a ChangeLog entry/commit message (especially an older 
one), it's generally much more interesting which bug is being fixed rather than 
knowing who reviewed it.  (Also, putting the bug description first makes git's 
one-line description of each commit much more useful than either having a list 
of dates and the person who wrote the patch or having a list of patch 
reviewers.)

Dave
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Scheduled downtime for bugs.webkit.org on Thu, 02 Jul, 2009 at 7:00 PM PDT (-0700)

[David Kilzer]

The UTF-8 upgrade of the database takes much longer than expected.  The 
downtime may be closer to 45 minutes.

Dave





From: David Kilzer 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, July 1, 2009 11:32:02 AM
Subject: [webkit-dev] Scheduled downtime for bugs.webkit.org on Thu, 02 Jul, 
2009 at 7:00 PM PDT (-0700)


The bugs.webkit.org server will be down for maintenance starting at 7:00 PM PDT 
(-0700) on Thursday, July 2, 2009 for a Bugzilla upgrade.  We expect the server 
to be down for about 30 minutes.

<https://bugs.webkit.org/show_bug.cgi?id=17457>

Apologies in advance for any inconvenience this may cause.

Dave
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Scheduled downtime for bugs.webkit.org on Thu, 02 Jul, 2009 at 7:00 PM PDT (-0700)

[David Kilzer]

The bugs.webkit.org server will be down for maintenance starting at 7:00 PM PDT 
(-0700) on Thursday, July 2, 2009 for a Bugzilla upgrade.  We expect the server 
to be down for about 30 minutes.



Apologies in advance for any inconvenience this may cause.

Dave
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] [Request] "Remember me" check button in bugzilla homepage.

[David Kilzer]

This will happen when we upgrade to Bugzilla 3.2.x, which should be very soon!

Dave





From: tonikitoo (Antonio Gomes) 
To: webkit-dev Development 
Sent: Wednesday, July 1, 2009 8:04:25 AM
Subject: [webkit-dev] [Request] "Remember me" check button in bugzilla homepage.

Could we get the basic "remember me" check button available at login
time in bugs.webkit.org  login page ?

It is kind of annoying have to perform login all the time I revisit
the page after relaunching my browser ...

https://bugs.webkit.org/show_bug.cgi?id=26883

-- --Antonio Gomes___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to add Maxthon's port.

[David Kilzer]

The Haiku port is
Submitting their patches now.
See the details here.

https://bugs.webkit.org/show_bug.cgi?id=26620

Dave





From: zengweihong 
To: bfulg...@gmail.com
Cc: webkit ; opensou...@maxthon.net
Sent: Monday, June 29, 2009 6:52:04 PM
Subject: Re: [webkit-dev] How to add Maxthon's port.

 
After we submit source code to the official, we'll introduce Maxthon 3 browser 
on our website.

Best regards,
weihong.zeng

> Date: Mon, 29 Jun 2009 14:20:43 -0700
> Subject: Re: [webkit-dev] How to add Maxthon's port.
> From: bfulg...@gmail.com
> To: weihong.z...@hotmail.com
> CC: webkit-dev@lists.webkit.org
> 
> 2009/6/29 zengweihong :
> > Hi,
> >
> > We're using webkit in Maxthon3.0 and want to submit our changes.
> > How to add maxthon's port?
> 
> Are the sources to the Maxthon WebKit available somewhere?  I couldn't
> find any link on the http://www.maxthon.com/ site.
> 
> Thanks,
> 
> -Brent


把MSN装进手机，更多聊天乐趣等你挖掘！ 立刻下载！ ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to add Maxthon's port.

[David Kilzer]

Ariya Hidayat  wrote:

> > We're using webkit in Maxthon3.0 and want to submit our changes.
> > How to add maxthon's port?
> 
> http://webkit.org/coding/contributing.html


To expand upon this a bit, you should break up the patch into smaller, logical 
pieces and file one bug per patch on .  (Make sure to 
set the "review?" flag on the patch so that we'll find it for review.)

For others on webkit-dev, I found these links about the Maxthon browser to be 
informative:




Dave
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] [wxWindows] ubuntu build problem

[David Kilzer]

It sounds like the wxWindows build is broken due to a file missing from its 
build system.  (Find the source file with JSC::jsonTable() defined in it, then 
add it to the wx build system files.)

I've copied Kevin Ollivier, the port maintainer, so that he's aware of the 
issue.

Kevin, any chance of getting the wxWindows buildbot back online?

Dave





From: anurag uniyal 
To: webkit-dev@lists.webkit.org
Sent: Thursday, June 11, 2009 10:56:52 PM
Subject: Re: [webkit-dev] ubuntu build problem


do anybody have a clue, or any pointers for me so that I can fix it myself?



I have checked out revision 44600 today and it gives me build problem
is there some stable version which I should be using?

I am building it on ubuntu machine
with command
./build-webkit --wx --wx-args="wxgc wxpython"

"""
ranlib /home/anushri/try/WebKit/WebKitBuild/Release/libjscore.a
g++ -o /home/anushri/try/WebKit/WebKitBuild/Release/jsc obj-gnu/jsc_jsc.o  -lm 
-L/usr/lib -licui18n -licuuc -licudata -lm 
-L/home/anushri/try/WebKit/WebKitBuild/Release 
-L/home/anushri/try/WebKit/WebKitTools/wx/../../WebKitLibraries/unix/lib 
-L/home/anushri/try/WebKit/WebKitTools/wx/../../WebKitLibraries -ljpeg -lpng 
`wx-config --libs core,base` -g-ljscore -lpthread  
/home/anushri/try/WebKit/WebKitBuild/Release/libjscore.a(jscore_JSGlobalData.o):
 In function `JSC::JSGlobalData::JSGlobalData(bool, JSC::VPtrSet const&)':
JSGlobalData.cpp:(.text+0x8e1): undefined reference to `JSC::jsonTable'
/home/anushri/try/WebKit/WebKitBuild/Release/libjscore.a(jscore_JSGlobalData.o):
 In function `JSC::JSGlobalData::JSGlobalData(bool, JSC::VPtrSet const&)':
JSGlobalData.cpp:(.text+0x1241): undefined reference to `JSC::jsonTable'
/home/anushri/try/WebKit/WebKitBuild/Release/libjscore.a(jscore_JSGlobalObject.o):
 In function `JSC::JSGlobalObject::reset(JSC::JSValue)':
JSGlobalObject.cpp:(.text+0x5391): undefined reference to `vtable for 
JSC::JSONObject'
collect2: ld returned 1 exit status
make: *** [/home/anushri/try/WebKit/WebKitBuild/Release/jsc] Error 1
make: Leaving directory `/home/anushri/try/WebKit/JavaScriptCore


rgds
Anurag

 Explore and discover exciting holidays and getaways with Yahoo! India Travel 
Click here!

 Own a website.Get an unlimited package.Pay next to nothing.*Click here!.

 Explore and discover exciting holidays and getaways with Yahoo! India Travel 
Click here!___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Crash on the Mac (RapidWeaver plugin and Safari 4)

[David Kilzer]

Hi Gilberto,

Please file a bug on either  or 
 with explicit steps on how to reproduce the crash, 
then report the bug number here.

Thanks!

Dave





From: Gilberto De Faveri 
To: webkit-dev@lists.webkit.org
Sent: Friday, June 12, 2009 12:47:22 AM
Subject: [webkit-dev] Crash on the Mac (RapidWeaver plugin and Safari 4)

Hi all,
I'm working on a RapidWeaver plugin (Cocoa) which uses a WebView on its main 
window.

Using Safari 3 everything works as expected, but after installing Safari 4 
RapidWeaver crashes when re-opening the same plugin saving more than once.

The problems seems to be in JavaScriptCore:

*
Process: RapidWeaver [4901]
Path:/Applications/RapidWeaver.app/Contents/MacOS/RapidWeaver
Identifier:  com.realmacsoftware.rapidweaverpro
Version: ??? (4.2.1)
Code Type:   X86 (Native)
Parent Process:  launchd [74]

Architecture:   i386
Date/Time:   2009-06-11 13:25:20.531 +0200
OS Version:  Mac OS X 10.5.7 (9J61)
Report Version:  6

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_PROTECTION_FAILURE at 0xbe8fd800
Crashed Thread:  0

Thread 0 Crashed:
0   com.apple.JavaScriptCore  0x95b8bd83 void* 
WTF::fastMalloc(unsigned long) + 435
1   com.apple.WebCore 0x927623ac 
std::pair, 
WebCore::StringHash, WTF::HashTraits, 
WTF::HashTraits >, WebCore::StringImpl*>, bool> 
WTF::HashSet >::add(char const* const&) + 492
2   com.apple.WebCore 0x921bc2f4 
WebCore::AtomicString::add(char const*) + 52
3   com.apple.WebCore 0x9226a35d 
WebCore::ResourceRequestBase::isConditional() const + 397
4   com.apple.WebCore 0x922698e1 
WebCore::SubresourceLoader::create(WebCore::Frame*, 
WebCore::SubresourceLoaderClient*, WebCore::ResourceRequest const&, bool, bool, 
bool) + 769
5   com.apple.WebCore 0x92268fae 
WebCore::Loader::Host::servePendingRequests(WTF::Deque&, 
bool&) + 942
6   com.apple.WebCore 0x92268be2 
WebCore::Loader::Host::servePendingRequests(WebCore::Loader::Priority) + 82
7   com.apple.WebCore 0x92268598 
WebCore::Loader::load(WebCore::DocLoader*, WebCore::CachedResource*, bool, 
bool, bool) + 280
8   com.apple.WebCore 0x92268469 
WebCore::CachedResource::load(WebCore::DocLoader*, bool, bool, bool) + 89
9   com.apple.WebCore 0x92268400 
WebCore::CachedResource::load(WebCore::DocLoader*) + 48
10  com.apple.WebCore 0x92267bf0 
WebCore::Cache::requestResource(WebCore::DocLoader*, 
WebCore::CachedResource::Type, WebCore::KURL const&, WebCore::String const&, 
bool) + 192
11  com.apple.WebCore 0x92267560 
WebCore::DocLoader::requestResource(WebCore::CachedResource::Type, 
WebCore::String const&, WebCore::String const&, bool) + 192
12  com.apple.WebCore 0x9230697f 
WebCore::DocLoader::requestScript(WebCore::String const&, WebCore::String 
const&) + 47
13  com.apple.WebCore 0x9226fb30 
WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State) + 3568
14  com.apple.WebCore 0x92261c9b 
WebCore::HTMLTokenizer::parseSpecial(WebCore::SegmentedString&, 
WebCore::HTMLTokenizer::State) + 2267
15  com.apple.WebCore 0x9224f6df 
WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, 
WebCore::HTMLTokenizer::State) + 9103
16  com.apple.WebCore 0x9224cc9b 
WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 2907
17  com.apple.WebCore 0x921f7c50 
WebCore::FrameLoader::write(char const*, int, bool) + 432
18  com.apple.WebCore 0x9224b3f7 
WebCore::FrameLoader::addData(char const*, int) + 39
19  com.apple.WebKit  0x9322ec0c -[WebFrame(WebInternal) 
_receivedData:textEncodingName:] + 140
20  com.apple.WebKit  0x9322eb33 -[WebHTMLRepresentation 
receivedData:withDataSource:] + 499
21  com.apple.WebKit  0x9322e8db -[WebDataSource(WebInternal) 
_receivedData:] + 91
22  com.apple.WebKit  0x9322e859 
WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) 
+ 137
23  com.apple.WebCore 0x9223d356 
WebCore::DocumentLoader::commitLoad(char const*, int) + 70
24  com.apple.WebCore 0x9223cf85 
WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 69
25  com.apple.WebCore 0x9223c752 
WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) 
+ 114
26  com.apple.WebCore 0x9223c6d8 
WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*, 
int, int) + 56
27  com.apple.Foundation  0x950f8ed7 
-[NSURLConnection(NSURLConnectionReallyInternal) 
sendDidReceiveData:originalLength:] + 119
28  com.apple.Foundation  0x950f8e21 _NSURLConne

Re: [webkit-dev] to reitveld or not to reitveld

[David Kilzer]

On Friday, June 5, 2009 Ojan Vafai wrote:
> This is what I meant by "light-weight" integration. All the review
> information would be reflected in the bugzilla bug. You would never
> be required to use reitveld for anything.

But I'm a reviewer.  Don't you want to be selling me on the virtues of 
Reitveld?  :)

What happens if I choose to update a patch in Bugzilla instead of reitveld 
(assuming I'm not required to use Reitveld as you say)?  Will Bugzilla push the 
status of the patch back to Reitveld?

> A review tool like reitveld is quite a bit of work. Adding 
> similar functionality to bugzilla itself is a non-trivial amount
> of work. I don't see what integrating this functionality any
> more tightly into bugzilla buys us that is worth the order(s) of
> magnitude more effort that approach would take.

The one major thing it would buy us is less maintenance--adding another web 
site would double the amount of maintenance for the bug system.  I can easily 
imagine that upgrading one would break integration with the other and 
vice-versa.  Is there something I'm missing that would mitigate the risk of 
additional maintenance and break-on-upgrade issues?

It's obvious that a lot of work has gone into Reitveld, and I'm sure it's a 
great tool.  I just think it's a shame that no one has stepped up to provide 
similar functionality for Bugzilla, thereby improving the status quo for all 
users of this popular open source tool.

Dave




________
From: Ojan Vafai 
To: Darren VanBuren 
Cc: David Kilzer ; Jeremy Orlow ; 
WebKit Development 
Sent: Friday, June 5, 2009 7:25:40 PM
Subject: Re: [webkit-dev] to reitveld or not to reitveld


This is what I meant by "light-weight" integration. All the review information 
would be reflected in the bugzilla bug. You would never be required to use 
reitveld for anything.

We would be able to:
1. Add a link to bugzilla that would take you to the reitveld code review and 
upload the patch to reitveld if it hasn't been uploaded already.
2. Have all comments published in reitveld be posted to the bug.
3. Have checkboxes in reitveld for r+, r- that would update bugzilla.
4. I think we can even have comments made directly to bugzilla be reflected in 
reitveld by having a bot that monitors bugzilla update emails.

A review tool like reitveld is quite a bit of work. Adding similar 
functionality to bugzilla itself is a non-trivial amount of work. I don't see 
what integrating this functionality any more tightly into bugzilla buys us that 
is worth the order(s) of magnitude more effort that approach would take.

Ojan

On Sat, Jun 6, 2009 at 11:02 AM, Darren VanBuren  wrote:

Surprisingly, the bug isn't a duplicate, or if there is a dupe, it isn't filed 
correctly.

But I agree that any code review tool should be integrated with 
bugs.webkit.org, otherwise there would be a huge disorganized mess and it 
wouldn't be any better.

Bugzilla wouldn't be hard to extend for this purpose, just adding a field for 
review status and then making whatever code review tool you chose update 
Bugzilla solves (b).

Some modifications in the tool could also make it attach the patches to a bug, 
and you could also update any field in the bug.

I mean, retiveld seems like a wonderful tool, it seems like something that 
would extend Bugzilla quite nicely. Pushing data to Bugzilla can simply be done 
with XML-RPC according to this page on bugzilla.org: 
http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/WebService/Server/XMLRPC.html
 and there's plenty of XML libraries for Python you could use to work over 
XML-RPC.

Darren VanBuren
onekop...@gmail.com

http://oks.tumblr.com/


On Jun 5, 2009, at 6:21 PM, David Kilzer wrote:

I think this is a great direction to move in, but (IMO) any such tool should be 
tightly integrated with bugs.webkit.org so that (a) you don't have to post the 
same patch more than once, (b) the review status of the patch is visible in 
bugs.webkit.org without clicking on a link and (c) it's easy to switch between 
reviewing the patch and updating the bug itself.

I just filed a Bugzilla bug about adding such a feature to Bugzilla itself 
(although I wouldn't be surprised if it's a dupe):

Bugzilla needs better patch review process with annotations and versioned 
patches
<https://bugzilla.mozilla.org/show_bug.cgi?id=496670>

Dave





From: Jeremy Orlow 
To: Ojan Vafai 
Cc: WebKit Development 
Sent: Friday, June 5, 2009 5:08:47 PM
Subject: Re: [webkit-dev] to reitveld or not to reitveld

For what it's worth, I definitely think a tool like reitveld would help the 
code review process.  Inline comments and more context than the couple lines 
the diff provides are really, really helpful.


On Fri, Jun 5, 2009 at 9:25 AM, Ojan Vafai  wrote:

Sorry i

Re: [webkit-dev] to reitveld or not to reitveld

[David Kilzer]

I think this is a great direction to move in, but (IMO) any such tool should be 
tightly integrated with bugs.webkit.org so that (a) you don't have to post the 
same patch more than once, (b) the review status of the patch is visible in 
bugs.webkit.org without clicking on a link and (c) it's easy to switch between 
reviewing the patch and updating the bug itself.

I just filed a Bugzilla bug about adding such a feature to Bugzilla itself 
(although I wouldn't be surprised if it's a dupe):

Bugzilla needs better patch review process with annotations and versioned 
patches


Dave





From: Jeremy Orlow 
To: Ojan Vafai 
Cc: WebKit Development 
Sent: Friday, June 5, 2009 5:08:47 PM
Subject: Re: [webkit-dev] to reitveld or not to reitveld

For what it's worth, I definitely think a tool like reitveld would help the 
code review process.  Inline comments and more context than the couple lines 
the diff provides are really, really helpful.


On Fri, Jun 5, 2009 at 9:25 AM, Ojan Vafai  wrote:

Sorry in advance for the long email. I'm trying to be thorough.
There's been a lot of discussion on #webkit about possibly using a code review 
tool like reitveld for webkit reviews. There's been various suggestions and a 
few misunderstandings, so it seems worth having a more formal discussion about 
this with the larger WebKit community.

The things I'd like to assess here are:
1. Pros/Cons of using a system like reitveld. I listed some below. Please add 
any that I missed.
2. Whether the WebKit community is interested in pursuing something like this.
3. If there is interest, what is the best way to move forward.


WHAT IS REITVELD
It's a code review tool. Reitveld doesn't allow you to do anything that is 
impossible with the current review process, however, it makes the review 
process more efficient and less error-prone. As such, it makes it easier and 
less time-consuming to do good, thorough code reviews.

The basic gist of reitveld is that it allows you to put comments inline and 
send them all in one chunk. Then it lets the reviewee easily respond to each 
comment individually and send all the responses in one chunk.

EXAMPLE CHROMIUM PATCH
http://codereview.chromium.org/119103

Note that you can view the patch in each version that was uploaded and that you 
can diff between versions. Also, if a comment was made in the version you were 
looking at, then you can see all the comments/responses.

To see this nicely, under "Delta from patch set" in patch set 3, click on 2. 
That is where most of the comments in this review were made. For example, 
http://codereview.chromium.org/119103/diff2/14:27/29. You can see all the 
comments and responses along with the diff in the patch to see that the 
reviewer comments were implemented as intended.

Keyboard shortcuts to try out:
-n/p to switch between diff chunks
-shift n/p to switch between comments
-j/k to go to the next/previous file

*Please don't actually click the "Publish all my drafts" button on the publish 
page as you'll be modifying a real code review.*

Other things to try
-try the side-by-side diff and the unified diff views
-adding comments (double click)
-replying to comments
-go to the publish page (click the publish link or type "m") 

Also note that the "Committed" URL is automatically added when the patch is 
committed and the reitveld issue is marked closed. So there isn't extra 
overhead in maintaining list of outstanding code reviews.

HOW TO TRY IT OUT
Here's the process for trying out reitveld with a webkit patch. The current 
workflow is a bit janky, but some scripting and some simple reitveld fixes 
would make this a lot more natural and automated (e.g. chromium uses 
commandline "gcl upload" to put up a new patch).

1. Find a non-git patch
2. Go to http://codereview.chromium.org/new
3. Login with a Google account (e.g. any gmail or Google search account)
4. On that page, type in a subject and paste in the URL to the patch in the URL 
field.
5. Click "Create Issue"

There's a couple apparent bugs that are easily fixable:
1. The ChangeLog files don't get downloaded correct, so the diffs don't work. 
This is an AppEngine problem that Chromium works around with the gcl upload 
script.
2. With an old patch there are often diff chunk mistmatches, which breaks the 
side-by-side diff view (you can use the unified diff in those cases). 

PROS
For the reviewer:
-easier to write thorough review comments since adding comments is so 
light-weight
-easier to make sure that all review comments actually got implemented

For the reviewee:
-easier to see which line the reviewer's comment addresses
-easier to make sure you've completed all the reviewer's comments (you can mark 
them as "done" in reitveld as you go)

For everyone:
-efficient keyboard navigation (e.g. j/k to navigation between diff chunks and 
n/p to navigate between files
-easier to follow the progression of a code revie

Re: [webkit-dev] What's going on with the debug Leopard bot on build.webkit.org?

[David Kilzer]

I filed two bugs which seem to cover all the failures (although I did not click 
on every single failing SVG result diff):

Bug 26218: REGRESSION: LayoutTests/fast/dom/Window/orphaned-frame-access.html 
fails on Debug builds
https://bugs.webkit.org/show_bug.cgi?id=26218

Bug 26219: REGRESSION: 92 SVG layout tests failing on Leopard Debug buildbot 
with wrong fill color
https://bugs.webkit.org/show_bug.cgi?id=26219

Dave





From: Adam Roben 
To: webkit-dev Development 
Sent: Thursday, June 4, 2009 7:14:02 AM
Subject: [webkit-dev] What's going on with the debug Leopard bot on 
build.webkit.org?

This bot has had 93 tests failing for quite some time. Does anyone know what's 
causing these failures?

-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Coding style

[David Kilzer]

Hi Kenneth,

The examples you give below are correct (with the exception of the number of 
spaces used to indent the code in the else blocks).

Please file a bug on bugs.webkit.org and attach a patch.  The webkit.org web 
site is in the svn repository, so you may create patches against the HTML.

Thanks!

Dave





From: Kenneth Christiansen 
To: webkit-dev 
Sent: Thursday, June 4, 2009 7:52:29 AM
Subject: [webkit-dev] Coding style

Hi there,

I'm having a question regarding the coding style.

According to 2. An else statement should go on the same line as a
preceding close brace.

I would always need a brace when using if-else, in order to but the
else statement on the same line as the preceding close brace, is this
right?
or would something like this is OK:

if (condition)
func1();
else
   func2();

And what about this case

if (condition)
func1();
else {
   func2();
   func3();
}

It would be nice to have this defined in the coding style,  as well as
adding the case that when you have a comment inside a one line if
statement you will need braces, like

if (condition) {
 // comment
 func()
}

Cheers, Kenneth
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Safari 4: all apps which use Webkit freezing at same time

[David Kilzer]

Hi Ben,

The best thing to do in this case is to file a bug report with Apple on 
.  I'll send you a list of steps on how to do 
this off the list.

Dave





From: Benjamin Jackson 
To: webkit-dev@lists.webkit.org
Sent: Friday, May 29, 2009 6:48:51 AM
Subject: [webkit-dev] Safari 4: all apps which use Webkit freezing at same time

It's happened a couple of times now: all of the open apps which use
Webkit (e.g. Adium, Mail, Safari etc) will hang at the same time and
will not allow the user to force quit.

A restart is required to get the Mac functional again.

Is this a known issue? Any idea what might be up?

Thanks,

Ben
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Multithread issue

[David Kilzer]

This assertion is telling you that the code expects to be running on the main 
thread.

You're also probably running a debug build since assertions are disabled in 
release builds.

Dave





From: Matt Bockt 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, May 27, 2009 5:17:44 AM
Subject: [webkit-dev]  Multithread issue

Hi everybody, 

I'm new to WebKit and I'm developing a C++ application that uses the WebKit 
browser.

It runs on Fedora10, kernel 2.6.27.5-117.fc10.i686.
The WebKit version I'm using is the r44111.

Here is my problem : I'm creating a new web view in the main thread, say, 
thread A. 
The webview is then attached to a gtk_window as it's made in the GtkLauncher 
exemple.

Then webkit_web_view_load_uri() is called, always in thread A.

Finally, the gtk_main() function is called in another thread, say thread B.

And it crashes  with the following trace  : 

ASSERTION FAILED: m_thread == currentThread()
(WebCore/platform/Timer.cpp:206 bool WebCore::TimerBase::isActive() const)

I experience this problem with the webkit r44111 and r43808, but not with 
r38297.

I
noticed that there must have been a modification in the thread management
between the builds r38297 and r43808 since g_threads must be
initialized. 
But I can't figure out why it doesn't work.

Any suggestions or specific rules to follow about multi-threading, gtk and 
webkit ?

Thank you for your help.

-- 
matt
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Webkit Rendered Image

[David Kilzer]

Try looking at source in WebCore/rendering/.

Dave





From: webkitUser 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, May 27, 2009 3:59:28 AM
Subject: Re: [webkit-dev] Webkit Rendered Image


Hi,

Can somebody please give me some pointers here.

If you can point me to the part of source where the image/text get rendered
that would help me work backwards atleast.

Regards,


webkitUser wrote:
> 
> Hi,
> 
> I have modified the WinLauncher application to dump what it has rendered.
> 
> Basically I have plugged in the "createBitmapContextFromWebView" method
> from DumpRenderTree Sample, which is supposed to dump a png out of a
> WebView.
> 
> However, I see that the resulting png just has a blank image and not the
> rendered contents. Is this expected?
> 
> If yes, how can I get an image out of the Webkit rendered contents?
> 
> Thanks in Advance,
> 
> 

-- 
View this message in context: 
http://www.nabble.com/Webkit-Rendered-Image-tp23671148p23740216.html
Sent from the Webkit mailing list archive at Nabble.com.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

[David Kilzer]

Another aspect of this proposal is how to handle source files that have #if 
ENABLE(FEATURE)/#endif guards around all of their source code, for example:

Bug 25756: Explicit guards for ENABLE_GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=25756

There are essentially two options here:

1. Add #if/#endif guards to entire source files, but include every file in 
every build system.

2. Make each build system smart enough to exclude source files that implement a 
feature, thus pushing the policy decision down (up?) into the build system 
(which is where most of the decisions are made today anyway).

I think #2 is a much cleaner way to handle this since it removes clutter from 
the code (at the cost of duplicating knowledge of which files go with with 
features into each build system).

Does anyone else have an opinion on this?

Dave





From: Maciej Stachowiak 
To: WebKit Development 
Sent: Thursday, April 30, 2009 4:12:54 PM
Subject: [webkit-dev] Proposal for a new way to handle porting #ifdefs


I think our set of porting macros has become somewhat confused.

Originally, our idea was that a port represents primarily adaptation to a 
particular platform. However, over time it has become clear that most of what 
is decided by a port is not platform adaptation, but rather policy decisions. 
For example, ports decide to have different features enabled, or to use 
different sets of system functionality on the same underlying OS.

In addition, I think the catchall top-level PLATFORM create confusion, because 
it is not totally clear if they are policy decisions, platform adaptation 
decisions, or what.

Third, it seems wrong that the policy choices of every port are represented as 
a bunch of ifdef tomfoolery inside a single Platform.h file.

And fourth, many ports often run on the same OS, but with a different set of 
choices - for example on Mac OS X it is possible to build the Mac, Chromium, 
Gtk, Qt and Wx ports (at least).


Therefore, I propose that we change as follows:

1) Strictly separate platform adaptation (mandatory to run on a given OS, 
compiler, or CPU at all) from policy choices (what features to enable, what 
optional libraries to use).

2) Phase out PLATFORM macros completely - each use should be converted to a 
policy choice, or a platform adaptation decision.

3) Instead of ports being defined by a top-level PLATFORM macro, I propose that 
each port should have its own header file to define policy decisions. For 
example, I'd propose that the system Mac OS X WebKit should use PortCocoa.h, 
and the WebKit used by Safari for Windows should use PortWinCG.h. There may 
also be a PortIPhone.h. These port definition headers would live in their own 
top-level WebKit module. Each one would be completely owned by whoever is 
generally considered the "owner" of a given port. Because related ports on 
different platforms may wish to share policy choices, it's ok for Port headers 
to include shared headers for some choices. For example, all Apple-maintained 
ports may include PortApple.h. We could go even further and have PortDefault.h 
to make default choices of what features are enabled, that ports would have to 
explicitly override.

4) Platform adaptation macros would still be defined in Platform.h based on 
sniffing the environment, this would include things like the compiler, the 
underlying OS, available libc functions, and so forth.


Platform adaptation macros would be:

OS() - underlying operating system; only to be used for mandated low-level 
services like virtual memory, not to choose a GUI toolkit
Examples:
OS(UNIX) - Any Unix-like OS
OS(DARWIN) - Underlying OS is the base OS X environment
OS(FREEBSD) - FreeBSD
OS(WIN) - Any version of Windows
OS(WINCE) - The embedded version of Windows

COMPILER() - the compiler being used to build the project
Examples:
COMPILER(GCC) - GNU Compiler Collection
COMPILER(MSVC) - Microsoft Visual C++
COMPILER(RVCT) - ARM compiler

HAVE() - specific system features (headers, functions or similar) that are 
present or not
Examples:
HAVE(MMAP) - mmap() function is available
HAVE(ERRNO_H) - errno.h header is available
HAVE(MADV_FREE) - madvise(MADV_FREE) is available


Policy decision macros would be:

USE() - use a particular third-party library or optional OS service
Examples:
USE(SKIA) - Use the Skia graphics library
USE(CG) - Use CoreGraphics
USE(V8) - Use the V8 JavaScript implementation
USE(CFNET) - Use CFNetwork networking
USE(NSURL_NET) - Use NSURLConnection-based networking
USE(APPKIT) - Use AppKit views and events
USE(GTK) - Use Gtk+
USE(QT) - Use Qt
USE(QUICKTIME) - Use the QuickTime media engine
USE(QTKIT) - Use the QuickTime media engine via the Mac QTKit API
USE(QUICKTIME_WIN) - Use the QuickTime media engine via its Windows

Re: [webkit-dev] build on ubuntu not working as expected

[David Kilzer]

Yes, your messages are getting to the list.

Your best bet is to contact the wxWebKit maintainer, Kevin Ollivier, who I've 
copied on this message.

Dave





From: anurag uniyal 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, May 19, 2009 8:13:36 AM
Subject: Re: [webkit-dev] build on ubuntu not working as expected


Can anybody confirm this is getting to the list?




From: anurag uniyal 
To: anurag uniyal ; webkit-dev@lists.webkit.org
Sent: Sunday, 17 May, 2009 9:36:49 AM
Subject: Re: [webkit-dev] build on ubuntu not working as expected


can anybody give any pointers?




From: anurag uniyal 
To: webkit-dev@lists.webkit.org
Sent: Friday, 15 May, 2009 3:34:55 PM
Subject: [webkit-dev] build on ubuntu not working as expected




I first posted it on webkitsdk-...@lists.apple.com but was redirected here.

Hi,

I am facing problem in running latest build on ubuntu.

Problem:
I build revision 41937 sometime back and wxBrowser and my own wxPython browser 
was working fine

Today i updated to revision 43688.
1.
First I got an error at line 329 platform/network/curl/ResourceHandleManager.cpp
url not defined in this scope
so i moved out char* url out of #ifndef NDEBUG 

after that build was successful, regresion test also passed except few date 
test which were same in last revision too

2. now wxBrowser does not work as expected e.g.
on opening www.google.com 
a) it takes too much time
b) image are not displayed
c) it doesn't go to any other link, just stuck at loading...

for build I used 
./set-webkit-configuration --release
./build-webkit --wx --wx-args="wxgc wxpython"

my system is
GCC 4.2.3 (Ubuntu 4.2.3-2ubuntu7)
Linux-2.6.24-19-generic-i686-with-debian-lenny-sid'

Any tips are appreciated.

Thanks
Anurag



 From Chandigarh to Chennai - find friends all over India. Click here.

 Share files, take polls, and make new friends - all under one roof. Click here.

 Explore and discover exciting holidays and getaways with Yahoo! India Travel 
Click here!

 Cricket on your mind? Visit the ultimate cricket website. Enter now!___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] A problem with the "data" attribute of the "object" tag

[David Kilzer]

Unless the movie was loaded from a file:/// URL, it's probably your web server 
setting the MIME type for the movie file:

$ grep 'avi$' /etc/httpd/mime.types
video/x-msvideo avi
$ grep 'wmv$' /etc/httpd/mime.types
video/x-ms-wmv  wmv

Dave





From: naixuan guan 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, May 19, 2009 1:29:00 AM
Subject: Re: [webkit-dev] A problem with the "data" attribute of the "object" 
tag


PS: I use the webkit which is ported to Qt/E4.5.0


2009/5/19 naixuan guan 

Hi, everyone!
 
The HTML page is as follow:
 

 
when webkit detect the object, it automatically thought the mimetype of this 
object is "video/x-ms-wmv"
when I change the data attribute to "1.avi", webkit thought the mimetype is 
"video/x-msvideo"
 
I really want to know how does webkit do this kind of judge. I search the src 
code with the key word "video/x-ms-wmv", but I got nothing.
Currently I only know two functions may work with this: 
RenderPartObject::updateWidget and HTMLObjectElement::parseMappedAttribute, but 
I can't find out how does webkit check the "data" attribute and decide which 
mimetype to use.
 
Could you give me some tips?
Thanks!
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

[David Kilzer]

> 1b) WINCE actually includes plenty of WIN but in some cases
> does things differently.  How to make this distinction without
> lots of && and ||?


There are various design patterns that may be used to alleviate macros, such as 
subclassing and use of delegates.  Each case will probably require a specific 
solution, but many of the patterns should be reusable.

> 2) We use PLATFORM(TORCHMOBILE) across multiple OS for things
> that are not necessarily platform specific but specific to our
> browsers.  I guess this is similar to PLATFORM(CHROMIUM).
> Honestly I don't like filling the code with these but we all
> do it, including MAC.  MAC tends to win the default right now.
> I'm not sure how best to handle this yet but I foresee a big
> mess if we aren't careful.


I think Maciej said that part of this plan is to break up PLATFORM(MAC) into 
smaller pieces.  I haven't looked at the Torch Mobile source code, but I 
suspect the same thing may need to be done in this case as well.  When porting, 
it's very easy to lump features, library/framework dependencies (I'm thinking 
of CFNetwork vs. libcurl vs. libsoup), and true platform-specific code into a 
single macro.  Part of this effort will be to clean that up.

Dave





From: George Staikos 
To: WebKit Development 
Sent: Monday, May 4, 2009 7:45:41 PM
Subject: Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs


I really like this and it goes in the direction that I was hoping for as well.  
Hopefully we can get the WINCE port merged upstream before we make this change. 
:-)

Some comments I have:

1) In some cases some things apply to more than one OS so we have:
#if OS(x) || OS(y) || OS(z) ...
I think we should use:
#if OS(x,y,z)

1b) WINCE actually includes plenty of WIN but in some cases does things 
differently.  How to make this distinction without lots of && and ||?

2) We use PLATFORM(TORCHMOBILE) across multiple OS for things that are not 
necessarily platform specific but specific to our browsers.  I guess this is 
similar to PLATFORM(CHROMIUM).  Honestly I don't like filling the code with 
these but we all do it, including MAC.  MAC tends to win the default right now. 
 I'm not sure how best to handle this yet but I foresee a big mess if we aren't 
careful.

3) I'm not sure that USE() really applies equally as you described.  In some 
cases it applies to basically the whole system API used (QT), but in others 
it's just a support library (QUICKTIME).

Again, fully support these changes and perhaps some more too.  Just give us a 
bit of time to find the right way to merge the WINCE stuff in first please!


On 30-Apr-09, at 7:12 PM, Maciej Stachowiak wrote:

> 
> I think our set of porting macros has become somewhat confused.
> 
> Originally, our idea was that a port represents primarily adaptation to a 
> particular platform. However, over time it has become clear that most of what 
> is decided by a port is not platform adaptation, but rather policy decisions. 
> For example, ports decide to have different features enabled, or to use 
> different sets of system functionality on the same underlying OS.
> 
> In addition, I think the catchall top-level PLATFORM create confusion, 
> because it is not totally clear if they are policy decisions, platform 
> adaptation decisions, or what.
> 
> Third, it seems wrong that the policy choices of every port are represented 
> as a bunch of ifdef tomfoolery inside a single Platform.h file.
> 
> And fourth, many ports often run on the same OS, but with a different set of 
> choices - for example on Mac OS X it is possible to build the Mac, Chromium, 
> Gtk, Qt and Wx ports (at least).
> 
> 
> Therefore, I propose that we change as follows:
> 
> 1) Strictly separate platform adaptation (mandatory to run on a given OS, 
> compiler, or CPU at all) from policy choices (what features to enable, what 
> optional libraries to use).
> 
> 2) Phase out PLATFORM macros completely - each use should be converted to a 
> policy choice, or a platform adaptation decision.
> 
> 3) Instead of ports being defined by a top-level PLATFORM macro, I propose 
> that each port should have its own header file to define policy decisions. 
> For example, I'd propose that the system Mac OS X WebKit should use 
> PortCocoa.h, and the WebKit used by Safari for Windows should use 
> PortWinCG.h. There may also be a PortIPhone.h. These port definition headers 
> would live in their own top-level WebKit module. Each one would be completely 
> owned by whoever is generally considered the "owner" of a given port. Because 
> related ports on different platforms may wish to share policy choices, it's 
> ok for Port headers to include shared headers for some choices. For example, 
> all Apple-maintained ports may include PortApple.h. We could go even further 
> and have PortDefault.h to make default choices of what features are enabled, 
> that ports would have to explicitly override.
> 
> 4) Platform

Re: [webkit-dev] how does Webkit handle font

[David Kilzer]

No, libicu is used to lay out international text.

CSS fonts are handled by files with "CSS" and "font" in their name, which will 
lead you to other files with "font" in their name under the 
WebCore/platform/graphics/ directory.

$ find WebCore -iname \*font\* -print | grep -i css
WebCore/css/CSSFontFace.cpp
WebCore/css/CSSFontFace.h
WebCore/css/CSSFontFaceRule.cpp
WebCore/css/CSSFontFaceRule.h
WebCore/css/CSSFontFaceRule.idl
WebCore/css/CSSFontFaceSource.cpp
WebCore/css/CSSFontFaceSource.h
WebCore/css/CSSFontFaceSrcValue.cpp
WebCore/css/CSSFontFaceSrcValue.h
WebCore/css/CSSFontSelector.cpp
WebCore/css/CSSFontSelector.h
WebCore/css/CSSSegmentedFontFace.cpp
WebCore/css/CSSSegmentedFontFace.h
WebCore/css/FontFamilyValue.cpp
WebCore/css/FontFamilyValue.h
WebCore/css/FontValue.cpp
WebCore/css/FontValue.h

Dave





From: x yz 
To: webkit-dev@lists.webkit.org; ying lcs 
Sent: Tuesday, April 21, 2009 11:10:20 AM
Subject: Re: [webkit-dev] how does Webkit handle font


I think it is handled by libicu.


--- On Tue, 4/21/09, ying lcs  wrote:

> From: ying lcs 
> Subject: [webkit-dev] how does Webkit handle font
> To: webkit-dev@lists.webkit.org
> Date: Tuesday, April 21, 2009, 2:00 PM
> Hi,
> 
> Can you please tell me how does Webkit handle font? (e.g.
> which files
> I should look at)
> e.g. css can specify a particular font for a paragraph ,
> where/how
> does Webkit load the font from the OS (or how does it know
> the font
> actually exists?
> 
> Thank you.___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebKit caching

[David Kilzer]

Why don't you just send a couple HTTP headers with the JavaScript and CSS 
resources when they leave your web server:

Pragma: no-cache
Cache-Control: no-cache

Or do you need a generalized solution for any web site?

Note that this may not work except in recent nightly builds due to 
.

Dave





From: Adam Thorsen 
To: webkit-dev@lists.webkit.org
Sent: Friday, April 10, 2009 12:02:18 PM
Subject: [webkit-dev] WebKit caching

I would like to prevent a WebKit WebView instance in Cocoa  from caching 
certain content.  I've attempted to prevent this using several approaches, 
including:

1.  Overriding the NSURLCache cachedResponseForRequest and cachedResponse 
forRequest methods
2.  Handling -(NSURLRequest *)webView:(WebView *)sender resource:(id) 
willSendRequest:(NSURLRequest *) redirectResponse:(NSURLResponse *) 
fromDataSource:(WebDataSource *)dataSource
a) tried setting the cache policy to NSURLRequestReloadIgnoringCacheData, among 
other settings
   b) tried appending a random string onto the end of the resource url 
before passing it along (i.e. something like 
http://blah.com/file.js?23234234234)
3.  Clearing the cache by setting the shared url cache (via NSURLCache ) and 
calling removeAllCachedResponses before each page load.
4. Setting preferences on the WebView:

   WebPreferences *prefs = [webView preferences];
   [prefs setUsesPageCache:NO];

and

   WebPreferences *prefs = [webView preferences];
   [prefs setPrivateBrowsingEnabled:YES];


None of these approaches seem to prevent the webview from caching javascript 
resources.  Based on its behavior, I believe that on initial page load it 
checks the last-modified value in each response header and caches resources in 
memory that have not been modified within a certain period of time.  Recently 
modified files (within the past few minutes) are not cached.

My ultimate goal  is simply to prevent the webview from caching javascript and 
css files, and I am open to any suggestions on how to do that.  However, based 
on my above hypothesis about how WebKit handles caching internally, I believe 
that if I could rewrite the response headers such that last-modified is always 
a recent value, I could prevent WebKit from caching.

Currently I can view the response header by implementing:

- (void)webView:(WebView *)sender resource:(id)identifier 
didReceiveResponse:(NSURLResponse *)response fromDataSource:(WebDataSource 
*)dataSource

and calling allHeaderFields on the response.  However, there appears to be no 
way to modify the response before sending it on to the webview for display.  
Are there any suggestions on how to do this?

Thanks,
-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to write plug-ins in webkit?

[David Kilzer]

Apple documentation for NSAPI (Netscape) plug-ins and Web (Objective-C) 
plug-ins:

http://developer.apple.com/DOCUMENTATION/InternetWeb/Conceptual/WebKit_PluginProgTopic/WebKitPluginTopics.html

Example/test code in the WebKit source tree:

http://trac.webkit.org/browser/trunk/WebKitExamplePlugins
http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj

Dave





From: Hongwei Huang 
To: webkit-dev@lists.webkit.org
Sent: Thursday, April 9, 2009 10:48:56 PM
Subject: [webkit-dev] How to write plug-ins in webkit?

I want to learn webkit plugins , and then how to write plug-ins in webkit?
Will some give me some advice?
Thangks!

Best wishes！

Hongwei Huang

Shanghai Jiaotong University
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Customization of WebKit.

[David Kilzer]

The FEATURE_DEFINES variables in *.xcconfig files are only used when building 
WebKit for Safari on Mac OS X.  Unless you're working on that specific port, 
you need to enable/disable those flags elsewhere.  Hint:

$ grep -l -r ENABLE_XSLT WebCore
WebCore/Configurations/WebCore.xcconfig
WebCore/GNUmakefile.am
WebCore/webcore-base.bkl
WebCore/WebCore.pro
WebCore/WebCore.vcproj/WebCore.vcproj

Dave





From: jagadeesh k 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, April 1, 2009 9:17:17 PM
Subject: [webkit-dev] Customization of WebKit.


Hi,
I want to disable the SVG,XML,XPATH,XSLT features of WebKit.
And i came  to know that,disabling of above features can be achieved by using 
FEATURE_DEFINES Variable in JavaScriptCore.xcconfig, 
WebKit.xcconfig,WebCore.xcconfig files.I want to know whether the above method 
is enough or i should remove corresponding XML,SVG,XPATH specific files 
(.cpp,.h files)in WebKit for diasbling.If Yes,please mention which are all the 
files i should remove in WebKit?
 
Thanks and Regards
jagadeesh  
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] webkit-dev:loadURL failed.

[David Kilzer]

Hi Partin,

Please file a bug report on .  Thanks!

Dave




From: Partin-巴丁 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, March 31, 2009 3:08:45 AM
Subject: Re: [webkit-dev] webkit-dev:loadURL failed.


The project  "WinLauncher", 
file name :WinLauncher.cpp
function: loadURL()
 
following code:
   urlBStr = fileURL;
 
this will destroy the length of urlBStr, may be like this will be work:

   urlBStr = SysAllocStringLen(fileURL, fileURLLength);

Right ?
 
partin___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Running test case under debugger "gdb"

[David Kilzer]

On Mac OS X, you can start gdb and use:

(gdb) attach -waitfor DumpRenderTree

Then start run-webkit-tests.

If your gdb doeesn't have "attach -waitfor", you can just put a timeout in 
run-webkit-tests like this after the "dump tool" is opened but before any tests 
are sent to it:

sleep(15); # sleep 15 seconds so gdb can be attached

Dave



- Original Message 
> From: Husam Senussi 
> To: webkit-dev@lists.webkit.org
> Sent: Friday, March 20, 2009 7:32:40 PM
> Subject: [webkit-dev] Running test case under debugger "gdb"
> 
> Hi,
> 
> is there any easy way to use debugger with test case.
> 
> Thanks
> Husam
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Diabling XML, XPATH, SVG, and XSLT features of WebKit

[David Kilzer]

For the Apple Mac port, look at the list of FEATURE_DEFINES in 
JavaScriptCore/Configurations/JavaScriptCore.xcconfig, 
WebCore/Configurations/WebCore.xcconfig and 
WebKit/mac/Configurations/WebKit.xcconfig.

For other ports, look in related build files for the ENABLE_FOO macros.

Dave





From: jagadeesh k 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, March 18, 2009 10:30:52 PM
Subject: [webkit-dev] Diabling XML,XPATH,SVG,and XSLT features of  WebKit


Hi,
How can i disable the XML,XPATH,SVG,and XSLT features of WebKit ?
 
Is their any macros for disabling(as read in one of the threads of WebKit-dev 
forum)the same ?
 
thanks and regards
jagadeesh___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Use SquirrelFishExtreme Alone, Many Questions

[David Kilzer]

> [...] Is there good example code for:
> 
> (1) adding an object to the global objects that has it's own functions and 
> properties
> (2) getting call backs for getters, setters, etc, in objects


You might try the files in the JavaScriptCore/API/tests/ directory.  I haven't 
used the API before, so I'm not sure where any good examples would be.

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Use SquirrelFishExtreme Alone, Many Questions

[David Kilzer]

On Wednesday, March 18, 2009 9:02:04 AM, Brian Barnes wrote:

> 1) Can I compile SFE alone (without webkit)

Yes.  Squirrelfish Extreme ("SFX") is an implementation "detail" (albeit a very 
significant detail :) of the JavaScriptCore framework.

> 2) Are there XCode and MVC projects (for SPE alone), and is the XCode
> project a  framework?

Yes, it's JavaScriptCore.  Yes it's also an Xcode project.

> 3) Where are the SPE API docs online?

http://developer.apple.com/documentation/Carbon/Reference/WebKit_JavaScriptCore_Ref/index.html

> 4) Is there a C interface (obviously I can't find the docs :) )


Yes, it's a C interface.

Dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] about WebCore\bindings\scripts documents

[David Kilzer]

The *.idl files are a custom Interface Definition Language for generating 
source code for DOM bindings.  On the Apple Mac port, there are (generally 
speaking) two such bindings built for each *.idl file:

- JavaScript bindings in C++ created by CodeGeneratorJS.pm; these files are the 
glue between JavaScriptCore and the C++ implementation files in WebCore.  They 
make the HTML DOM work in the web browser.

- Objective-C DOM bindings created by CodeGeneratorObjC.pm; these files provide 
an interface nearly identical to the HTML DOM interface in JavaScript, except 
in the Objective-C language.

Dave





From: 张正和 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, March 18, 2009 3:13:00 AM
Subject: [webkit-dev] about WebCore\bindings\scripts documents


Hi all
In the webcore\bindings,there are some documents, but they are not c++ 
documents and I don't kown what they are. And what language they use. Now I 
want to konw their function, I hope you tell me!
thank you
zzh 

好玩贺卡等你发，邮箱贺卡全新上线！___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] x86-64 JIT

[David Kilzer]

Which version of gcc are you using?  Older versions (think gcc-3.x) are known 
to have issues compiling JavaScriptCore, although I don't recall reading about 
this particular issue.

Dave



- Original Message 
> From: Mike Hommey 
> To: webkit-dev@lists.webkit.org
> Sent: Tuesday, March 17, 2009 1:51:57 PM
> Subject: [webkit-dev] x86-64 JIT
> 
> Hi,
> 
> I was taking a quick look at the JIT code and also gave a shot at
> forcing a build of the x86-64 code under Linux.
> 
> The main problem right now is the following:
> ../JavaScriptCore/jit/JITArithmetic.cpp:664: error: cast from 
> 'JSC::Structure*' 
> to 'unsigned int' loses precision
> ../JavaScriptCore/jit/JITArithmetic.cpp:674: error: cast from 
> 'JSC::Structure*' 
> to 'unsigned int' loses precision
> ../JavaScriptCore/jit/JITArithmetic.cpp:714: error: cast from 
> 'JSC::Structure*' 
> to 'unsigned int' loses precision
> ../JavaScriptCore/jit/JITArithmetic.cpp:724: error: cast from 
> 'JSC::Structure*' 
> to 'unsigned int' loses precision
> 
> Looking at the code, it seems really too much x86-centric, and
> depending on how the x86-64 ABI is under OSX. I don't know how things
> are going to evolve with Snow-Leopard, as I hear the kernel will finally
> be 64-bits, but maybe the same issue will arise.
> 
> Anyways, I'd need guidance from some people with JIT knowledge to help
> me get it work on Linux.
> 
> Cheers,
> 
> Mike
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] where strore "html widget" name and id

[David Kilzer]

In WebCore/dom/Element.h, there is a member variable named 'nameAttrMap' that 
holds name/value pairs for the attributes of each element.

If you then look at WebCore/html/HTMLElement.cpp, you'll find an id() method 
that pulls the id out of the map, for example.

Dave





From: zhenghe zhang 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, March 17, 2009 3:39:48 AM
Subject: [webkit-dev] where strore  "html widget" name and id

 
Hi all
I am studying the webkit, now I have a problem, I hope you tell me!
thank you.
there are many html widget in the document, and now I want to konw where
 store the name and id of  html widget
thank you
zhang___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] how to obtain the value of the html by ID

[David Kilzer]

There currently aren't C++ bindings available for the DOM (that mirror the DOM 
available in JavaScript).  They would have to be implemented.  See the scripts 
in the WebCore/bindings/scripts directory.

Dave



- Original Message 
> From: zhenghe zhang 
> To: webkit-dev@lists.webkit.org
> Sent: Tuesday, March 17, 2009 3:03:46 AM
> Subject: [webkit-dev] how to obtain the value of the html  by ID
> 
> Hi all
> I have a problem, I hope you tell me, thank you.
> There is a js function:
> 
> function alertValue()
> {
>  alert(text1.value);
> }
> Now I want to know the javascript function how to obtain the value of
> "text1" through the c++ functions, I hope you tell me,
> Thank you & regards
> zh
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] JavaScriptCore or WebCore

[David Kilzer]

JavaScriptCore/kjs was removed and files were moved to other subdirectories 
like JavaScriptCore/runtime.

Running "svn log -v | less" and searching for the old file name will usually 
help you find what was renamed.  Or look in JavaScriptCore/ChangeLog* files for 
the same information.

Dave





From: Husam Senussi 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, March 11, 2009 12:31:36 PM
Subject: [webkit-dev] JavaScriptCore or WebCore

Hi,

I'm trying to see where should go, I'm writing the code for JSON object and I'm 
not  sure where should  go.

In the patch attached to the bug the code for JSON object exist in 
JavaScriptCore/kjs which doesn't exist in
source tree I checked out, instead I found JavaScriptCore/runtime.

Or should the files go into WebCore/bindings/js but my understanding this 
directory contains
DOM object not Javascript language objects like Array,String, Math ... etc.

Sorry if that sounds like dumb question, I' just trying to understand structure 
of the source code.

Thanks
Husam.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How can I search through webkit-dev mailling list archive?

[David Kilzer]

Yes, use "site:lists.webkit.org/pipermail/webkit-dev" as a keyword in a Google 
search.  For example:

http://www.google.com/search?client=safari&rls=en&q=site:lists.webkit.org/pipermail/webkit-dev+help&ie=UTF-8&oe=UTF-8

Dave





From: 조정흠 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, March 11, 2009 4:44:57 AM
Subject: [webkit-dev] How can I search through webkit-dev mailling list archive?


Hello,
 
I am again ^^;
 
I'd liek to ask a question about the way to search through our mailing list 
archive.
Now when I search some keyword from the archive, I do search for one month of 
archive at a time. This way make me give up on searching the whole one. I can 
only search on the recent archives.
Isn't there another way to search the whole archive at a time?
 
Best regards
-- 
Humi
Seoul___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Stable tiger engine build?

[David Kilzer]

Try this command:

svn ls http://svn.webkit.org/repository/webkit/releases/Apple/

Or this URL:

http://trac.webkit.org/browser/releases/Apple/

Dave





From: Swp 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, March 10, 2009 12:58:54 AM
Subject: [webkit-dev] Stable tiger engine build?

Hi, 

Can someone tell me stable release of WebKit with Tiger engine? 

Regards, 
Swapnil___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: RSS support

[David Kilzer]

The RSS support (that you see in Safari) is not part of WebKit.

Dave





From: RamaMohanReddy B 
To: webkit-dev@lists.webkit.org
Sent: Sunday, March 8, 2009 9:40:05 PM
Subject: [webkit-dev] Fwd: RSS support

Hi,

Is RSS/Atom supported in Webkit? Is there any patch/bug how to add 
RSS support to Webkit. Please let me know. 
Thanks,
RamaMohan.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] four perl files hard-code the path to gcc

[David Kilzer]

I agree that the path shouldn't be hard-coded, so I filed:

Bug 24454: Path to perl should not be hard-coded
https://bugs.webkit.org/show_bug.cgi?id=24454

Salvation lies within:

Bug 392184 - Users should be allowed to delete their own account
https://bugzilla.mozilla.org/show_bug.cgi?id=392184

Dave





From: Dennis Heuer 
To: webkit-dev@lists.webkit.org
Sent: Saturday, March 7, 2009 11:42:12 PM
Subject: [webkit-dev] four perl files hard-code the path to gcc

hello

first: i refuse to use bugzilla because it doesn't let me drop or at
least close my account at a later time. take this post or not.

four of the perl files contend hard-coded paths to gcc. my gcc resides
in opt and is not detected (not even searched for). please update these
scripts with the general configure procedure. the scripts are:

WebCore/css/make-css-file-arrays.pl
WebCore/dom/make_names.pl
WebCore/bindings/scripts/IDLParser.pm
WebCore/bindings/scripts/CodeGeneratorObjC.pm

many thanks,
dennis heuer

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] request to add SH4 platform

[David Kilzer]

Hi Simone,

Code contribution guidelines are here:

http://webkit.org/coding/contributing.html

Please open a new bug on  and post your patch there 
with its review flag set.  (Feel free to CC me on the bug.)  Note that your 
patch should also have ChangeLog entries, as explained on the webkit.org web 
site.

Looking at the two patches, I think they're fine as-is and would have no 
problem landing in the source tree.

Thanks for your contribution!

Dave





From: Simone Fiorentino 
To: webkit-dev@lists.webkit.org
Sent: Thursday, March 5, 2009 5:33:27 AM
Subject: [webkit-dev] request to add SH4 platform

Hi,
I would like to gratify you for your great work.
I'm working in porting WebKit for SH4 platform.
I had some problems related to non-aligned memory accesses as done in 
WebCore::equal(StringImpl* string, const UChar* characters, unsigned length) 
function for the SH4 platform.
My question is: can you add support in WebKit sources for SH4 platform?

In attachment you can find two little patches (against WebKit trunk) that 
introduce the SH4 platform and solves the non-aligned memory accesses (I use 
the same code as per ARM platform).

Best regards.

Tnx,
Simone.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] wap support schedule

[David Kilzer]

Sounds like a bug.  Please file a new bug at <https://bugs.webkit.org/> about 
this issue.  Thanks!

Dave





From: 조정흠 
To: David Kilzer 
Cc: webkit-dev@lists.webkit.org
Sent: Monday, March 2, 2009 8:14:10 PM
Subject: Re: [webkit-dev] wap support schedule

Hi, Dave

Thank you for your kind answer.

I could build WML enabled Safari by enabling ENABLE_WML in WebKit, WebCore and 
in the file build-generated-files.sh under WebCoreGenerated.

But I had to block out some errornous code.

RenderObject* r = renderer();
if (r /*&& r->isEdited()*//*JJH*/) {
dispatchEventForType(eventNames().changeEvent, true, false);

// Refetch the renderer since arbitrary JS code run during onchange 
can do anything, including destroying it.
r = renderer();
//if (r)/*JJH*/
//r->setEdited(false);/*JJH*/
}

Class RenderObject doesn't have function isEdited(), setEdited(false)

I'd like to get updated information on this error code if this is corrected.

Thank you anyway.

Regards
Humi
Seoul

2009/3/2 David Kilzer 

WAP support is not enabled on the Windows or Mac nightly builds on 
<http://nightly.webkit.org/>.  You must enable it yourself and rebuild from 
source.

Dave





 From: 조정흠 
To: webkit-dev@lists.webkit.org
Sent: Monday, March 2, 2009 4:00:15 AM
Subject: [webkit-dev] wap support schedule



Hello,
 
In the previous archive, I found that someone in webkit.org(excuse me if I am 
wrong) was merging code for wap support.
He said that webkit will support WML and WCSS.
 
I tried open a wml page with current nightly builded safari on windows. But 
safari only downloaded the wml page. It doesn't seem to be able to render wml 
page yet.
 
Could I know the schedule for merging work of WML and WCSS?
 
Isn't it true that I already can make safari render wml page through some 
configuration changes of latest nightly builded safari?
 
Thank you very much for your kind answer in advance!
 
Humi
Seoul
 


-- 
조정흠
서울 동작구 신대방동 625-3 아트빌라102호
010-8473-3973
www.humi.or.kr
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] wap support schedule

[David Kilzer]

WAP support is not enabled on the Windows or Mac nightly builds on 
.  You must enable it yourself and rebuild from 
source.

Dave





From: 조정흠 
To: webkit-dev@lists.webkit.org
Sent: Monday, March 2, 2009 4:00:15 AM
Subject: [webkit-dev] wap support schedule


Hello,
 
In the previous archive, I found that someone in webkit.org(excuse me if I am 
wrong) was merging code for wap support.
He said that webkit will support WML and WCSS.
 
I tried open a wml page with current nightly builded safari on windows. But 
safari only downloaded the wml page. It doesn't seem to be able to render wml 
page yet.
 
Could I know the schedule for merging work of WML and WCSS?
 
Isn't it true that I already can make safari render wml page through some 
configuration changes of latest nightly builded safari?
 
Thank you very much for your kind answer in advance!
 
Humi
Seoul___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] about javaScript parse

[David Kilzer]

Change:




to:




and reload.

Dave





From: zhenghe zhang 
To: webkit-dev@lists.webkit.org
Sent: Friday, February 27, 2009 2:13:06 AM
Subject: [webkit-dev] about javaScript parse

Hi all
When you run the webpage with webkit and click the button,  there is no pop up. But if you use IE it pops up a dialog box.
I'd like to fix the code for the pop up. I've not done it yet and appreciate
any comments or help.







function alertValue()
{
  alert(text1.value)
}




Thank you
Regards 
zh

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to build a webkit release build

[David Kilzer]

You need to check out "trunk" from Subversion first (to get all of the "other" 
files):

$ svn co http://svn.webkit.org/repository/webkit/trunk WebKit

Then update each of the JavaScriptCore, WebCore, and WebKit subdirectories to 
the Subversion branch you're interested in:

$ cd WebKit/JavaScriptCore
$ svn switch 
"http://svn.webkit.org/repository/webkit/releases/Apple/Safari%204%20Public%20Beta/JavaScriptCore";
$ cd ../WebCore
$ svn switch 
"http://svn.webkit.org/repository/webkit/releases/Apple/Safari%204%20Public%20Beta/WebCore";
$ cd ../WebKit
$ svn switch 
"http://svn.webkit.org/repository/webkit/releases/Apple/Safari%204%20Public%20Beta/WebKit";

That should get you started in the right direction.

Dave





From: Meryl Silverburgh 
To: last...@yahoo.com
Cc: webkit-dev@lists.webkit.org
Sent: Tuesday, February 24, 2009 8:29:58 PM
Subject: Re: [webkit-dev] How to build a webkit release build

Thanks.

But after I svn get the release build, there are only 4 sub-directories.

$ ls
JavaScriptCoreJavaScriptGlueWebCoreWebKit

So I can't perform your steps as there is no 'autogen.sh' 'build-webkit', etc.


On Tue, Feb 24, 2009 at 7:35 PM, x yz  wrote:
> check out eveything,
> autogen.sh --pefix=
> set-webkit-configuration --release
> build-webkit --gtk
>
>
> --- On Wed, 2/25/09, Meryl Silverburgh  wrote:
>
>> From: Meryl Silverburgh 
>> Subject: [webkit-dev] How to build a webkit release build
>> To: webkit-dev@lists.webkit.org
>> Date: Wednesday, February 25, 2009, 8:50 AM
>> I read the instructions here in building Webkit trunk build.
>>
>> http://webkit.org/building/build.html
>>
>> But when I check out the 'release' build, it only
>> has 4 subdirectories
>> (different from the trunk project directories) and
>> it does not have
>> 'WebKit/WebKitTools/Scripts/build-webkit'
>>
>> http://trac.webkit.org/browser/releases/Apple/Safari%204%20Public%20Beta
>> http://trac.webkit.org/browser/trunk
>>
>> So my question is how can I build Webkit's release
>> build?
>>
>> Thank you.
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Build error

[David Kilzer]

In this case,  would mean one of:  "JavaScriptCore", "WebCore" or 
"WebKit".

And  would mean one of:  "Release" or "Debug".

Dave





From: bryon smith 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, February 24, 2009 11:34:40 PM
Subject: [webkit-dev] Build error


Ever time I try to build I get the error,
 
Please enshure you have run webkit/webkittools/scripts/update-webkit to 
epenedencies.
 
You can view build error by checking the BuildL.html file located at:
/home/showplace/webkit/webkitbuild/obj//.
 
I'm lost on /. What does it mean ?
 
I looked all over for a config. I did find more then one buildlog.html
 
 
I'm on windows vista, if that helps. ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] An old dragging problem

[David Kilzer]

Hi Eric,

If you're referring to , please do file a bug on 
 and attach test cases (unless you're going to host 
the test cases indefinitely).

Also, please add the "InRadar" keyword to the bug and note 
"" in a comment.

Thanks!

Dave





From: Eric Gorr 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, February 24, 2009 10:11:42 AM
Subject: [webkit-dev] An old dragging problem

A few years ago I was playing around with dragging text & images. from the web 
browser to elsewhere. A couple of old threads related to this can be found at:

http://lists.apple.com/archives/webkitsdk-dev/2006/Oct/msg00064.html
http://bytes.com/groups/javascript/550644-javascript-drag-drop

My test site can be found at:

  http://ericgorr.net/safaritest.html

Since I just tried the latest Safari 4 beta and found that it is still a 
problem, I was wondering if it is indeed still a bug or of things are working 
the way one would expect them to.

Years ago, it was confirmed as a bug and apparently fixed in a later version of 
webkit, but since that time (Safari 2.x), things have actually gotten worse and 
what used to work in Safari no longer does. (I also checked the latest nightly 
build of webkit.)

While I have reported the bug at bugreport.apple.com, I can report it again at 
https://bugs.webkit.org/ if someone thought it was useful to do so.


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Problems with JavaScript bison parser

[David Kilzer]

Which revision of WebKit are you using (or closest to)?

Which version of bison (bison --version) are you using to generate the grammar?

The incorrectly-parsed HTML works fine in Safari on Mac OS X for me.

Dave





From: Javed Rabbani 
To: webkit-dev@lists.webkit.org
Sent: Thursday, February 19, 2009 5:41:10 AM
Subject: [webkit-dev] Problems with JavaScript bison parser

 
Hello
everyone,
 
I am
working on a WebKit port for some platform and facing an issue with working of
JavaScript bison parser in "Grammar.cpp". If I execute the following HTML file,
everything is parsed without error:
 





 
However, as
soon I specify the same functionality through a separate function; I run into
trouble as the parser inside Grammar.cpp fails with return value of 1. Here is
the source for the HTML file:
 



function
OnClickHandler()
{
document.write('Hello World');
}




 
I have
figured out so far that parsing fails as it does not get all the tokens. It
only retrieves the first token and interprets it as "FUNCTION (269)". 
Afterwards,
the execution terminates and no further tokens are read by the parser. Ideally
it should continue with tokens for OPENBRACE (314), IDENT(317), STRING(318),
CLOSEBRACE(315) etc. I am not sure what is going wrong to this bison parser? If
anyone has faced somewhat similar issues; any help or suggestion is greatly
appreciated Thanks.
 
Regards,
J R Shah ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] checking for LIBSOUP... configure: error: Package requirements (libsoup-2.4 >= 2.23) were not met:

[David Kilzer]

Dave, may I suggest that lib version requirements to consider Fedora9? I mean 
can we loose the requirements, or use OS specific one so FC9  just needs 2.4?

Sure.  I'd suggest filing a bug on  with a patch for 
review.  I don't use the Linux port of WebKit--was just trying to help people 
get through their local build errors.  Those who using 
autoconf/autogen.sh/configure.ac will need to review any changes before they're 
committed anyway.

Dave





From: x yz 
To: deuxliq...@yahoo.com; Bo Yang 
Cc: webkit-dev@lists.webkit.org
Sent: Tuesday, February 17, 2009 10:40:54 AM
Subject: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
requirements (libsoup-2.4 >= 2.23) were not met:

libsoup 2.23 is newer than 2.4. On Fedora9 only 2.4 is available, on FC10 2.24 
is available.
You need to changed the required version 2.23 in configure.ac to 2.4 then you 
can build. I have not completed the build yet.

FC has older libs than ubuntu or so, when I try to compile openembbed flash I 
got lots of lib problem.
Dave, may I suggest that lib version requirements to consider Fedora9? I mean 
can we loose the requirements, or use OS specific one so FC9  just needs 2.4?
rgds
joe


--- On Tue, 2/17/09, Bo Yang  wrote:

> From: Bo Yang 
> Subject: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
> requirements (libsoup-2.4 >= 2.23) were not met:
> To: deuxliq...@yahoo.com
> Cc: webkit-dev@lists.webkit.org
> Date: Tuesday, February 17, 2009, 4:31 PM
> I have came across this error, too.
> The problem is , webkit need is 2.24 or later. But the
> libsoup 2.4 is not
> suitable, and webkit can't build with it because
> libsoup 2.4 miss the
> SoupCookieJar and something which exist in 2.24.
> 
> Install libsoup 2.24 , it will work!
> 
> Regards!
> Bo
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


  
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Thank you very much! I edited configure.ac and...

[David Kilzer]

Hi Hai,

I'm glad I was able to help you get past this particular build error, but I've 
never built the Gtk+ or Qt builds of WebKit before, so I can't help you any 
further.  Please continue using the webkit-dev mailing list or the #webkit IRC 
channel on irc.freenode.net for additional questions.

Also, I would file a bug on <https://bugs.webkit.org/> about the issue with 
identifying the supported version of libsoup in configure.ac.  It seems to me 
that there may need to be multiple checks for the correct version of the 
libsoup package based on your Linux distribution (or *NIX platform) due to the 
inconsistent package names for this library.

Dave





From: nguyen hai 
To: David Kilzer 
Sent: Monday, February 16, 2009 7:01:24 PM
Subject: Thank you very much! I edited configure.ac and...


Hi Dave,
I opened confugure.ac, I saw some scripts as below:

Script_1:
 # optional modules
LIBCURL_REQUIRED_VERSION=7.15
LIBSOUP_REQUIRED_VERSION=2.23
LIBXSLT_REQUIRED_VERSION=1.1.7
SQLITE_REQUIRED_VERSION=3.0
GSTREAMER_REQUIRED_VERSION=0.10

and Script_2

if test "$with_http_backend" = "soup"; then
   PKG_CHECK_MODULES([LIBSOUP],
 [libsoup-2.4 >= $LIBSOUP_REQUIRED_VERSION])
   AC_SUBST([LIBSOUP_CFLAGS])
   AC_SUBST([LIBSOUP_LIBS])
fi

firstly, I changed "libsoup-2.4" in Script_2 to "libsoup" but I got an error 
that meant that  it could not find libsoup.
Then, I changed LIBSOUP_REQUIRED_VERSION to 2.4 (that means 
LIBSOUP_REQUIRED_VERSION =2.4) . Then I typed autogen.sh, what great, it run 
well.

At this moment, I am running "make". It maybe take 3 hours for making.
I don't know if I did right or wrong. 
If you don't mind , I suppose that "make" shell will success. What will I do 
for the next? I mean that How many next steps to have a web browser. I am 
really very new to webkit and web browser. 
thank you again
Hai
--- Thứ 3, 17/02/09, David Kilzer  đã viết:

Từ: David Kilzer 
Chủ đề: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
requirements (libsoup-2.4 >= 2.23) were not met:
Đến: deuxliq...@yahoo.com
Cc: webkit-dev@lists.webkit.org
Ngày: Thứ Ba, 17 tháng 2, 2009, 0:28


Sorry, I was reading that libsoup-2.23 was older than libsoup-2.4.  It looks 
like configure.ac is not comparing the versions correctly.  Try making this 
change (changing "libsoup-2.4" to just "libsoup" in configure.ac) and rerunning 
autogen.sh:

diff --git a/configure.ac b/configure.ac
index 6ac6f8b..75d986f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -637,7 +637,7 @@ fi
 
 if test "$with_http_backend" = "soup"; then
PKG_CHECK_MODULES([LIBSOUP],
- [libsoup-2.4 >= $LIBSOUP_REQUIRED_VERSION])
+ [libsoup >= $LIBSOUP_REQUIRED_VERSION])
AC_SUBST([LIBSOUP_CFLAGS])
AC_SUBST([LIBSOUP_LIBS])
 fi

Note that $LIBSOUP_REQUIRED_VERSION is set to 2.23 anyway.

Dave





From: nguyen hai 
To: David Kilzer 
Sent: Monday, February 16, 2009 7:05:40 AM
Subject: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
requirements (libsoup-2.4 >= 2.23) were not met:


Hi David,
Thank you much for your help.
I tried to install libsoup-2.4 but not avaible.
I run on Fedora. I tyed as following:

yum search libsoup-2.4  (first I looked for libsoup-2.4)
yum install libsoup-2.4  

but I got a message:

not matched
nothing to do

Once I installed libsoup-2.4.1, the same error appeared : hecking for 
LIBSOUP... configure: error: Package requirements (libsoup-2.4 >= 2.23) were 
not met

It seems that "autogen.sh" want exactly libsoup-2.4 ( not 2.4.2 or other).
But I can't find libsoup-2.4.
I spent much time for this. It sounds bad.
Hai 

  

--- Thứ 2, 16/02/09, David Kilzer  đã viết:

> Từ: David Kilzer 
> Chủ đề: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
> requirements (libsoup-2.4 >= 2.23) were not met:
> Đến: deuxliq...@yahoo.com
> Cc: webkit-dev@lists.webkit.org
> Ngày: Thứ Hai, 16 tháng 2, 2009, 20:43
> The autogen.sh script wants libsoup-2.4 OR NEWER. 
> libsoup-2.4.1 satisfies that requirement, so try installing
> that version.
> 
> Dave
> 
> 
> 
> 
> 
> From: nguyen hai 
> To: webkit-dev@lists.webkit.org
> Sent: Monday, February 16, 2009 1:17:54 AM
> Subject: [webkit-dev] checking for LIBSOUP... configure:
> error: Package requirements (libsoup-2.4 >= 2.23) were
> not met:
> 
> 
> Hi all,
> I typed ./autogen.sh but I got this message:
> 
> checking for LIBSOUP... configure: error: Package
> requirements (libsoup-2.4 >= 2.23) were not met:
> 
> No package 'libsoup-2.4' found
> 
> Consider adjusting the PKG_CONFIG_PATH environment variable
> i

Re: [webkit-dev] Queries on Bug: 23310

[David Kilzer]

I don't think modifying KURL to parse JavaScript syntax is the correct approach.

I have a fix for this in my local tree.  I will try to post a patch for it 
today for review.

Dave





From: Vikram Hegde 
To: webkit-dev@lists.webkit.org
Sent: Monday, February 16, 2009 9:50:06 PM
Subject: [webkit-dev] Queries on Bug: 23310


Hi ,
 
The Bug 23310 is Setting an absolute path (/abs) on an  with no src 
doesn't resolve the URL properly.
 
So I have analysed the bug,and here are my comments.Kindly let me know i m on 
the right track of solving the bug.
 
Analysis:
 
The kurl.cpp is the actual place where the url gets resolved and is being 
parsed.So the parameter for the init function in kurl.cpp should have the 
complete format i.e. javascript:document.location.replace('/') instead the 
parameter which is being parsed contains only /.This is the reason why the 
parsing of the url is not done properly and invalidate function gets called 
which redirects the page to reflect nothing.
 
In short i think the scr which the kurl should parse should be the entire 
string (javascript:document.location.replace('/') ) . This is the reason i feel 
the parsing of url is not done propely.
 
Kindly suggest whether i m in the right track or not and the possible solutions 
for the problem.
 
Thanks & Regards,
Vikram
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] checking for LIBSOUP... configure: error: Package requirements (libsoup-2.4 >= 2.23) were not met:

[David Kilzer]

That's a horrible package name.  :(   Is "2.4" is the "so" version or what?

Do all Linux (or *NIX) distributions name libsoup that way?  It doesn't appear 
that Debian packages it this way:

http://packages.debian.org/search?keywords=libsoup

Is libsoup-2.4 older or newer than libsoup-2.23?

Dave





From: Christian Dywan 
To: webkit-dev@lists.webkit.org
Sent: Monday, February 16, 2009 10:38:59 AM
Subject: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
requirements (libsoup-2.4 >= 2.23) were not met:

Am Mon, 16 Feb 2009 09:28:53 -0800 (PST)
schrieb David Kilzer :

> Sorry, I was reading that libsoup-2.23 was older than libsoup-2.4.
> It looks like configure.ac is not comparing the versions correctly.
> Try making this change (changing "libsoup-2.4" to just "libsoup" in
> configure.ac) and rerunning autogen.sh:
> 
> diff --git a/configure.ac b/configure.ac
> index 6ac6f8b..75d986f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -637,7 +637,7 @@ fi
>  
>  if test "$with_http_backend" = "soup"; then
> PKG_CHECK_MODULES([LIBSOUP],
> - [libsoup-2.4 >= $LIBSOUP_REQUIRED_VERSION])
> + [libsoup >= $LIBSOUP_REQUIRED_VERSION])
> AC_SUBST([LIBSOUP_CFLAGS])
> AC_SUBST([LIBSOUP_LIBS])
>  fi
> 
> Note that $LIBSOUP_REQUIRED_VERSION is set to 2.23 anyway.

Hey,

this is actually wrong I'm afraid. The API name is 'libsoup-2.4' which
is arguably a bad idea on the side of the library author. The actual
version is something else, in this case 2.23. Pay attention to the
actual release version when looking for a more recent package.

ciao,
Christian
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Contributing to the documentation Wiki?

[David Kilzer]

Hi Frank,

I believe it is:

1. Create an account (on macosforge.org; the accounts are shared with 
webkit.org).
2. Edit the wiki.  

Dave





From: Frank Zerangue 
To: Webkit Development List 
Sent: Monday, February 16, 2009 10:19:48 AM
Subject: [webkit-dev] Contributing to the documentation Wiki?

What is the process for contributing to the documentation wiki?

Frank
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] checking for LIBSOUP... configure: error: Package requirements (libsoup-2.4 >= 2.23) were not met:

[David Kilzer]

Sorry, I was reading that libsoup-2.23 was older than libsoup-2.4.  It looks 
like configure.ac is not comparing the versions correctly.  Try making this 
change (changing "libsoup-2.4" to just "libsoup" in configure.ac) and rerunning 
autogen.sh:

diff --git a/configure.ac b/configure.ac
index 6ac6f8b..75d986f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -637,7 +637,7 @@ fi
 
 if test "$with_http_backend" = "soup"; then
PKG_CHECK_MODULES([LIBSOUP],
- [libsoup-2.4 >= $LIBSOUP_REQUIRED_VERSION])
+ [libsoup >= $LIBSOUP_REQUIRED_VERSION])
AC_SUBST([LIBSOUP_CFLAGS])
AC_SUBST([LIBSOUP_LIBS])
 fi

Note that $LIBSOUP_REQUIRED_VERSION is set to 2.23 anyway.

Dave




________
From: nguyen hai 
To: David Kilzer 
Sent: Monday, February 16, 2009 7:05:40 AM
Subject: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
requirements (libsoup-2.4 >= 2.23) were not met:


Hi David,
Thank you much for your help.
I tried to install libsoup-2.4 but not avaible.
I run on Fedora. I tyed as following:

yum search libsoup-2.4  (first I looked for libsoup-2.4)
yum install libsoup-2.4  

but I got a message:

not matched
nothing to do

Once I installed libsoup-2.4.1, the same error appeared : hecking for 
LIBSOUP... configure: error: Package requirements (libsoup-2.4 >= 2.23) were 
not met

It seems that "autogen.sh" want exactly libsoup-2.4 ( not 2.4.2 or other).
But I can't find libsoup-2.4.
I spent much time for this. It sounds bad.
Hai 

  

--- Thứ 2, 16/02/09, David Kilzer  đã viết:

> Từ: David Kilzer 
> Chủ đề: Re: [webkit-dev] checking for LIBSOUP... configure: error: Package 
> requirements (libsoup-2.4 >= 2.23) were not met:
> Đến: deuxliq...@yahoo.com
> Cc: webkit-dev@lists.webkit.org
> Ngày: Thứ Hai, 16 tháng 2, 2009, 20:43
> The autogen.sh script wants libsoup-2.4 OR NEWER. 
> libsoup-2.4.1 satisfies that requirement, so try installing
> that version.
> 
> Dave
> 
> 
> 
> 
> 
> From: nguyen hai 
> To: webkit-dev@lists.webkit.org
> Sent: Monday, February 16, 2009 1:17:54 AM
> Subject: [webkit-dev] checking for LIBSOUP... configure:
> error: Package requirements (libsoup-2.4 >= 2.23) were
> not met:
> 
> 
> Hi all,
> I typed ./autogen.sh but I got this message:
> 
> checking for LIBSOUP... configure: error: Package
> requirements (libsoup-2.4 >= 2.23) were not met:
> 
> No package 'libsoup-2.4' found
> 
> Consider adjusting the PKG_CONFIG_PATH environment variable
> if you
> installed software in a non-standard prefix.
> 
> When I looked for libsoup-2.4 , there were only
> libsoup-2.4.1.
> 
> Can someone help me?
> thanks
> Hai
>  
> 
> Thị trường chứng khoán Việt Nam hot tới mức
> nào? Khám phá tại Yahoo! Hỏi & Đáp


  Đặt ngay địa chỉ email mới!
Lấy ngay địa chỉ email bạn từng muốn có trước khi có người khác nhanh tay hơn!
http://mail.promotions.yahoo.com/newdomains/vn/
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] checking for LIBSOUP... configure: error: Package requirements (libsoup-2.4 >= 2.23) were not met:

[David Kilzer]

The autogen.sh script wants libsoup-2.4 OR NEWER.  libsoup-2.4.1 satisfies that 
requirement, so try installing that version.

Dave





From: nguyen hai 
To: webkit-dev@lists.webkit.org
Sent: Monday, February 16, 2009 1:17:54 AM
Subject: [webkit-dev] checking for LIBSOUP... configure: error: Package 
requirements (libsoup-2.4 >= 2.23) were not met:


Hi all,
I typed ./autogen.sh but I got this message:

checking for LIBSOUP... configure: error: Package requirements (libsoup-2.4 >= 
2.23) were not met:

No package 'libsoup-2.4' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

When I looked for libsoup-2.4 , there were only libsoup-2.4.1.

Can someone help me?
thanks
Hai
 

Thị trường chứng khoán Việt Nam hot tới mức nào? Khám phá tại Yahoo! Hỏi & Đáp___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] error: Cannot find icu-config. The ICU library is needed.

[David Kilzer]

Try installing the libicu package.

Dave





From: nguyen hai 
To: webkit-dev@lists.webkit.org
Sent: Sunday, February 15, 2009 11:56:25 PM
Subject: [webkit-dev] error: Cannot find icu-config. The ICU library is needed.


Hi all,

I build webkit on Fedora 9.
I typed ./autogen.sh and I got a message:

checking for icu-config... no
configure: error: Cannot find icu-config. The ICU library is needed.
[r...@localhost WebKit-r41018]# 

I am looking this error on webkt.org but I have not found any answer.
Can you help me to solve this error?
Thanks in advance!
Hai
 

 Vui vẻ chat thêm trên nhiều blog và website
Hãy thử dùng ứng dụng Pingbox online.___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Regarding Bug 23310

[David Kilzer]

Please comment in the bug itself if you'd like to work on it; that's what the 
"Comment" field is for.

I would look at Document::completeURL() instead.  Also, please read the HTML5 
reference document for the correct algorithm to fix this issue.

Dave





From: Nilesh Patil 
Cc: "webkit-dev@lists.webkit.org" 
Sent: Sunday, February 15, 2009 3:43:38 AM
Subject: Re: [webkit-dev] Regarding Bug 23310

Hi

Thanks david !!

I am trying to fix it. What i observed till now is following. When
only '/' is encountered the url automatically is set to 'about:blank'.
I think instead of this it should point to base URL inside Document. I
am currently looking at KURL.cpp init() method.

Please comment

Thanks & Regards
Niilesh

On Sun, Feb 15, 2009 at 4:16 PM, David Kilzer  wrote:
> It is valid and it is still open because it's "Status" is "New".
> https://bugs.webkit.org/show_bug.cgi?id=23310
> Dave
>
> 
> From: Nilesh Patil 
> To: "webkit-dev@lists.webkit.org" 
> Sent: Sunday, February 15, 2009 12:02:06 AM
> Subject: [webkit-dev] Regarding Bug 23310
>
> Hi
>
> Is this bug is valid and still open?
>
> Thanks & Regards
> Niilesh
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Regarding Bug 23310

[David Kilzer]

It is valid and it is still open because it's "Status" is "New".

https://bugs.webkit.org/show_bug.cgi?id=23310

Dave





From: Nilesh Patil 
To: "webkit-dev@lists.webkit.org" 
Sent: Sunday, February 15, 2009 12:02:06 AM
Subject: [webkit-dev] Regarding Bug 23310

Hi

Is this bug is valid and still open?

Thanks & Regards
Niilesh
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] li with position outside combined with img float left problem

[David Kilzer]

Please file a bug on .  Thanks!

Dave




From: Magnus Rembold 
To: webkit-dev@lists.webkit.org
Sent: Thursday, February 5, 2009 11:41:58 AM
Subject: [webkit-dev] li with position outside combined with img float left 
problem


A complete description of the problem with source HTML and inline CSS together 
with images can be found here:
http://www.munterbund.de/problems/090205/li_outside_and_img_float_problem.html

My question is: this is obviously not as is should be. Do the "standards" 
require that this is displayed this way? Or is it only a part of the rendering, 
that's considered "not important"? Or will it be fixed in some way? Everybody 
that I asked told me to format  in a completely awkward way with background 
pictures and so on. This shouldn't be necessary or am I wrong?

Thanks kindly for your replys, comments or suggestions!
Best regards,
Magnus



Magnus RemboldZÜRCHER HOCHSCHULE DER KÜNSTE
Dozent ITZurich University of the Arts

Fon +41 43 446 3256Ausstellungsstrasse 60
Fax +41 43 446 4587CH-8031 Zürich
http://iad.zhdk.chSwitzerland___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Getting more buildbots green

[David Kilzer]

Please file bugs on  for each test (or group of 
tests) that you disable per platform, especially for ports that run the layout 
tests regularly (Apple's Mac and Windows, Qt, Gtk, Wx).

Dave





From: Darin Adler 
To: Holger Freyther 
Cc: webkit-dev@lists.webkit.org
Sent: Tuesday, January 27, 2009 9:14:50 AM
Subject: Re: [webkit-dev] Getting more buildbots green

On Jan 27, 2009, at 7:54 AM, Holger Freyther wrote:

> may I read this as a rs=darin?

Yes, rs=me on adding to the Skipped list to make the buildbot green!

-- Darin___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Edit mode bug inserting ?

[David Kilzer]

The WebKit nightly DMG launches Safari with pre-built frameworks, so it's still 
running in the browser.  It's important to find out if this issue is fixed 
there so that you know whether you need to file a bug on 
<https://bugs.webkit.org/> or not.

I'm not very familiar with DOM editing methods, so I don't have a work-around 
to propose.  Sorry.

Dave




____
From: Diego Taylor 
To: David Kilzer 
Sent: Tuesday, January 6, 2009 6:50:46 AM
Subject: Re: [webkit-dev] Edit mode bug inserting  ?

Hi Dave,

The only issue is that I need to use it under the browser, but no problem.

Thanks,
Diego


On Tue, Jan 6, 2009 at 12:01 PM, David Kilzer  wrote:

Did you try the WebKit nightly to see if the issue is fixed there?

Dave




____
From: Diego Taylor 
To: David Kilzer 
Sent: Tuesday, January 6, 2009 5:35:00 AM
Subject: Re: [webkit-dev] Edit mode bug inserting  ?


Hi Dave,

The Safari where I am testing is: "Version 3.2.1 (5525.27.1)"
Is there any workaround for it?

Thank You,
Diego



On Tue, Jan 6, 2009 at 1:25 AM, David Kilzer  wrote:

Which version of Safari did you try?

There have been some HTML editing fixes recently in WebKit.  Have you tried a 
nightly WebKit build?  <http://nightly.webkit.org/>

Dave





 From: Diego Taylor 
To: webkit-dev@lists.webkit.org
Sent: Monday, January 5, 2009 1:49:23 PM
Subject: [webkit-dev] Edit mode bug inserting  ?


Hi,

I am intercepting the return key in edit mode and adding a  in the cursor 
position, but the first time I press the return key at the end of the text it 
doesn't move the cursor after the inserted br. Any help is really appreciated, 
this is the source code (tested on Safari):

-- o --


  
   
   
  
 document.body.contentEditable = true;
 document.designMode = 'on';
 function onKeyPress(ev) {
console.log('Key Pressed');
if(ev.keyCode==13) {
   insertBR();
   ev.preventDefault();
}
 }
 document.addEventListener('keypress', onKeyPress);
 function insertBR()
 {
var s = window.getSelection();
var r = s.getRangeAt(0);

var br = document.createElement('br');
r.insertNode(br);
var newRange = document.createRange();
newRange.setStartAfter(br);
newRange.setEndAfter(br);


s.removeAllRanges();
r.detach();
s.addRange(newRange);
 }
  
   Here is the place to play.
   

-- o --

Thanks,
Diego___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Edit mode bug inserting ?

[David Kilzer]

Did you try the WebKit nightly to see if the issue is fixed there?

Dave





From: Diego Taylor 
To: David Kilzer 
Sent: Tuesday, January 6, 2009 5:35:00 AM
Subject: Re: [webkit-dev] Edit mode bug inserting  ?

Hi Dave,

The Safari where I am testing is: "Version 3.2.1 (5525.27.1)"
Is there any workaround for it?

Thank You,
Diego



On Tue, Jan 6, 2009 at 1:25 AM, David Kilzer  wrote:

Which version of Safari did you try?

There have been some HTML editing fixes recently in WebKit.  Have you tried a 
nightly WebKit build?  <http://nightly.webkit.org/>

Dave





 From: Diego Taylor 
To: webkit-dev@lists.webkit.org
Sent: Monday, January 5, 2009 1:49:23 PM
Subject: [webkit-dev] Edit mode bug inserting  ?


Hi,

I am intercepting the return key in edit mode and adding a  in the cursor 
position, but the first time I press the return key at the end of the text it 
doesn't move the cursor after the inserted br. Any help is really appreciated, 
this is the source code (tested on Safari):

-- o --


  
   
   
  
 document.body.contentEditable = true;
 document.designMode = 'on';
 function onKeyPress(ev) {
console.log('Key Pressed');
if(ev.keyCode==13) {
   insertBR();
   ev.preventDefault();
}
 }
 document.addEventListener('keypress', onKeyPress);
 function insertBR()
 {
var s = window.getSelection();
var r = s.getRangeAt(0);

var br = document.createElement('br');
r.insertNode(br);
var newRange = document.createRange();
newRange.setStartAfter(br);
newRange.setEndAfter(br);


s.removeAllRanges();
r.detach();
s.addRange(newRange);
 }
  
   Here is the place to play.
   

-- o --

Thanks,
Diego___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Edit mode bug inserting ?

[David Kilzer]

Which version of Safari did you try?

There have been some HTML editing fixes recently in WebKit.  Have you tried a 
nightly WebKit build?  

Dave





From: Diego Taylor 
To: webkit-dev@lists.webkit.org
Sent: Monday, January 5, 2009 1:49:23 PM
Subject: [webkit-dev] Edit mode bug inserting  ?

Hi,

I am intercepting the return key in edit mode and adding a  in the cursor 
position, but the first time I press the return key at the end of the text it 
doesn't move the cursor after the inserted br. Any help is really appreciated, 
this is the source code (tested on Safari):

-- o --


  
   
   
  
 document.body.contentEditable = true;
 document.designMode = 'on';
 function onKeyPress(ev) {
console.log('Key Pressed');
if(ev.keyCode==13) {
   insertBR();
   ev.preventDefault();
}
 }
 document.addEventListener('keypress', onKeyPress);
 function insertBR()
 {
var s = window.getSelection();
var r = s.getRangeAt(0);

var br = document.createElement('br');
r.insertNode(br);
var newRange = document.createRange();
newRange.setStartAfter(br);
newRange.setEndAfter(br);


s.removeAllRanges();
r.detach();
s.addRange(newRange);
 }
  
   Here is the place to play.
   

-- o --

Thanks,
Diego
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] free lunch for a webCore dev?

[David Kilzer]

Have you tried asking questions on the #webkit IRC channel on irc.freenode.net?



Dave





From: eleith 
To: webkit-dev@lists.webkit.org
Sent: Monday, January 5, 2009 1:41:51 PM
Subject: [webkit-dev] free lunch for a webCore dev?

we've been trying to build what we assumed was a relatively simple app
using the webCore rendering engine, but we've run into some
complications.

we've haven't got much farther using online resources
(forums/mailing lists), so we'ld like to get some face to face advice.

we are out in the palo alto area, and we would be happy to offer a free
lunch if a webCore dev could just sit down with us, answer a few
questions and steer us in the right direction. (don't worry, we won't bring code
and we'll keep it informal and fun)

if you or someone you know might be interested, please respond to this
email with some information/background on your webCore experience.

we appreciate the help,

/leith___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Webpage Limits

[David Kilzer]

Have you tried writing a test and testing each browser?

Hello World

Dave





From: Enrique Francesco 
To: webkit-dev@lists.webkit.org
Sent: Monday, January 5, 2009 10:40:16 AM
Subject: [webkit-dev] Webpage Limits

Is there a limit to the width and height of displaying a web page in browsers? 
If yes, what is that limit?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] about cookie

[David Kilzer]

$ find WebCore -iname \*cookie\*
WebCore/platform/CookieJar.h
WebCore/platform/mac/CookieJar.mm
WebCore/platform/network/curl/CookieJarCurl.cpp
WebCore/platform/network/soup/CookieJarSoup.cpp
WebCore/platform/network/soup/CookieJarSoup.h
WebCore/platform/network/win/CookieJarCFNetWin.cpp
WebCore/platform/network/win/CookieJarWin.cpp
WebCore/platform/network/win/CookieStorageWin.cpp
WebCore/platform/network/win/CookieStorageWin.h
WebCore/platform/qt/CookieJarQt.cpp

Mmm...cookies.

Dave





From: zhenghe zhang 
To: webkit-dev@lists.webkit.org
Sent: Sunday, January 4, 2009 1:42:35 AM
Subject: [webkit-dev] about cookie

Hi all
I want to obtain the "cookie", but I didn't find it in the "webkit"
package.
I hope you help me?

Thank you
zh___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Getting more buildbots green

[David Kilzer]

> To me it seems like the result of some tests have impact on the others.

This usually indicates some state isn't being reset (in DumpRenderTree or in 
WebKit) between tests for the GTK+ port.  Individual test results should not 
rely on running previous tests.  (The --random and --reverse flags on 
run-webkit-tests stress these conditions.  I don't think anyone has tried 
running the tests with these flags recently, though.)

> I'm not sure if we would win anything by making the buildbot green...

It's a psychological issue.  If the buildbots are always red, developers start 
expecting them to be red and then stop paying attention to the details of why 
they're red.

Dave





From: Holger Freyther 
To: webkit-dev@lists.webkit.org
Sent: Saturday, January 3, 2009 3:42:52 PM
Subject: Re: [webkit-dev] Getting more buildbots green


> I'd love to set up the skipped lists properly and fix enough bugs so
> that all our bots are green. Can you help? Maybe there are already bug
> reports about some of these.

Regarding the skipped list on Gtk+. There are some tests that work on my 
machine that are failing on the buildbot. I would like to understand the 
difference before adding them to the skipped list. On the other hand we end up 
in mess when skipping some of the tests from within fast. To me it seems like 
the result of some tests have impact on the others. E.g. when starting to Skip 
one dom test we might need to add ~5 more and could unskip some others.

I'm committed to find the difference and get it green but time is the issue as 
I 
have university stuff first, then paid work with varying degree of load and 
then 
webkit... I'm not sure if we would win anything by making the buildbot 
green...


The JavaScript tests are a mystery to me, it looks like we fail 6 jscore tests 
and I have no idea why (and the TZ on the buildbot is set to Cupertino time 
and the LC_ALL to C).

z.___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Getting more buildbots green

[David Kilzer]

http/tests/webarchive/test-preload-resources.html
http/tests/webarchive/test-css-url-encoding-shift-jis.html
http/tests/webarchive/test-css-url-encoding-utf-8.html
http/tests/webarchive/test-css-url-encoding.html — Various web archive 
tests seem to be intermittently failing on Mac because of connections that 
close. The results of these tests seem to depend on keep alive and our test 
HTTP run of Apache doesn't seem to work consistently.

I think the Keep-Alive and Connection headers should just be removed from the 
webarchive results.  They really aren't germane to what's being tested anyway.  
(This may be a difference in how the CFNetwork libraries on Tiger vs. Leopard 
behave for keep-alive connections anyway.)

Bug 23091: Some webarchive http tests intermittently fail due to 
Connection/Keep-Alive header differences
https://bugs.webkit.org/show_bug.cgi?id=23091

Dave





From: Darin Adler 
To: WebKit Development 
Sent: Saturday, January 3, 2009 11:41:10 AM
Subject: [webkit-dev] Getting more buildbots green

Looking at the buildbot I see a few broken regression tests:

fast/text/find-case-folding.html — Looks like I broke this one when I 
introduced the ICU usearch-based text searching. I'll try to fix it.

editing/selection/move-left-right.html — The failure here is curious. The 
actual test output seems to be unchanged, but all the WARNING lines mentioning 
moving in the wrong direction seem to be missing. Mitz, can you help?

fast/dom/dom-constructors.html — This test needs a result for GTK that 
indicate lack of an  element or it needs to be in the skipped list.

dom — There are many failures in the GTK bot due to a full URL rather than 
partial URL showing up somewhere that causes the DOM test machinery to report 
errors that include full paths. These should be fixed or added to the GTK 
skipped list.

fast/dom/Window/timeout-released-on-close.html — Failing on GTK, not sure 
why.

fast/encoding/char-decoding-mac.html — Needs custom results or a skipped 
list since the GTK build does not support these encodings.

fast/events/special-key-events-in-input-text.html — Failing on GTK due to 
lack of eventSender. Needs to be added to the skipped list.

fast/forms/textarea-selection-preservation.html — Failing on GTK, not sure 
why. A recent regression?

fast/loader/plain-text-document.html, fast/xsl/xslt-text.html — Failing on 
GTK, not sure why the frame name is being generated with the text 
someFloatString in it.

ecma/String/15.5.4.7-1.js
ecma/String/15.5.4.7-2.js
ecma/String/15.5.4.7-3.js
ecma_2/String/match-002.js
js1_5/String/regress-107771.js — Failing on GTK. Is lastIndexOf really 
broken on GTK? I'm quite surprised to see platform-specific failures in the 
JavaScriptCore tests. Anyone have any insight?
And some intermittent failures:

http/tests/webarchive/test-preload-resources.html
http/tests/webarchive/test-css-url-encoding-shift-jis.html
http/tests/webarchive/test-css-url-encoding-utf-8.html
http/tests/webarchive/test-css-url-encoding.html — Various web archive 
tests seem to be intermittently failing on Mac because of connections that 
close. The results of these tests seem to depend on keep alive and our test 
HTTP run of Apache doesn't seem to work consistently.

http/tests/appcache/offline-access.html — Seems to have timed out once on 
Mac.

fast/dom/Window/timeout-released-on-close.html — Seems to have failed once 
on Mac.

ecma_3/Date/15.9.5.6.js
ecma_3/Date/15.9.5.7.js — These tests seem to toggle between success and 
failure on the GTK and WX bots based perhaps on time of day or time zone? This 
is particularly troublesome because we don’t have a skipped list for JavaScript 
tests. Maybe we can tweak the script we use to run these tests to ignore these 
intermittent failures?

And also a lot of slaves seem to be down. There are lots of "38 pending" on the 
waterfall, and I am not sure why. It seems strange that the Chromium slaves 
would have disappeared at the same time as the Mac Intel and Windows slaves.

I'd love to set up the skipped lists properly and fix enough bugs so that all 
our bots are green. Can you help? Maybe there are already bug reports about 
some of these.

-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] About Dom tree

[David Kilzer]

The 's parent is a  tag that's implicitly added during parsing to 
"fix" the DOM tree.  See Ian Hixie's live DOM viewer for a visual 
representation of this (paste your HTML into the top textarea):

http://software.hixie.ch/utilities/js/live-dom-viewer/

Dave





From: zhenghe zhang 
To: webkit-dev@lists.webkit.org
Sent: Wednesday, December 31, 2008 2:12:18 AM
Subject: [webkit-dev] About Dom tree

Hi 
I am studying the "webkit", and now I have a question , I hope you
tell me , thank you!

As follows:


   

  

 
  


I think the map's parent is the "img", but others don't agree with me.
Please tell me the detail on the basic of DOM tree.

Thanks
zh___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] about the focus of "htmlAreaElement"

[David Kilzer]

May be related to:

Bug 17513: Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513

Dave





From: Ariya Hidayat 
To: webkit-dev@lists.webkit.org
Sent: Tuesday, December 23, 2008 3:50:23 AM
Subject: Re: [webkit-dev] about the focus of "htmlAreaElement"


>  I am learning "webkit", and I find that the element of
> "HtmlAreaElement" don't obtain the focus,

Use your debugger to trace and potentially find out why the focus is not 
delivered to where it should be.



-- 
Ariya Hidayat, Software Engineer
Qt Software, Nokia Devices R&D___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Huge Memory Leak: How to restrict?

[David Kilzer]

Please file a bug on  following these instructions, 
and attach your patch for review (setting the "review?" flag):

http://webkit.org/coding/contributing.html

Be sure to include a ChangeLog entry with your patch.

Thanks!

Dave





From: Dhananjoy Chutia 
To: Holger Freyther 
Cc: webkit-dev@lists.webkit.org
Sent: Friday, December 19, 2008 8:15:43 AM
Subject: Re: [webkit-dev] Huge Memory Leak: How to restrict?

Hi, 
The statement d->m_msg = NULL is removed as
I observed that m_msg is g_object_unref ed at 

ResourceHandleInternal::~ResourceHandleInternal()
{
if (m_msg) {
g_object_unref(m_msg);
m_msg = 0;
}
}

but never executed. So, as per my understanding, the statementd->m_msg = NULL 
is removed. Will it create any new problem? I am new in this area. I expect 
your valuable suggestion.

Regards
Dhananjoy

 

On Fri, Dec 19, 2008 at 8:59 PM, Dhananjoy Chutia  wrote:

Hi,
   Thank you for your information. I had done the following
modification in WebKit-r39293 & observed the VmSize of GtkLauncher
for more than 40 minutes & found no increase. Please let me know
whether my modification is correct or not. It is to be noted that
WebKit is configured with --with-target=x11 --with-http-backend=soup.


diff -pu a/WebCore/platform/network/soup/ResourceHandleSoup.cpp 
b/WebCore/platform/network/soup/ResourceHandleSoup.cpp
--- a/WebCore/platform/network/soup/ResourceHandleSoup.cpp  2008-12-19 
20:22:23.0 +0530
+++ b/WebCore/platform/network/soup/ResourceHandleSoup.cpp  2008-12-19 
20:24:53.0 +0530
@@ -164,7 +164,6 @@ static void finishedCallback(SoupSession

 ResourceHandleInternal* d = handle->getInternal();
 // The message has been handled.
-d->m_msg = NULL;

 ResourceHandleClient* client = handle->client();
 if (!client)


Snap shot of current observation:
Fri Dec 19 19:56:33 IST 2008
webkit: VmSize:57368 kB

Fri Dec 19 19:57:33 IST 2008
webkit: VmSize:57368 kB

Fri Dec 19 19:58:33 IST 2008
webkit: VmSize:57368 kB

Fri Dec 19 19:59:33 IST 2008
webkit: VmSize:57368 kB



Regards
Dhananjoy




On Thu, Dec 18, 2008 at 4:35 PM, Holger Freyther  wrote:

On Thursday 18 December 2008 07:02:35 Dhananjoy Chutia wrote:
> Hi,
> I had carried out one experiment with GtkLauncher, by loading and
> unloading a page at interval of 2 seconds. I observed VmSize of GtkLauncher
> at interval of one minute. Memory is increased gradually. Here is my
> observation result.

Your test is flawed. And i have explained this several times on mails and irc.
So here is the deal. I give you information and you contribute back. So no
information until I'm certain that you are willing to get results of your
findings upstream.


z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



-- 
Dhananjoy



-- 
Dhananjoy
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fix for WebCore's base64Decode...

[David Kilzer]

Hi Paul,

Please file a bug on  and attach a patch for review.  
It sounds like it *may* be possible to use the local copy of the Acid 3 test as 
a test case for the fix (for ports using libcurl or libsoup).

Thanks!

Dave





From: Paul Pedriana 
To: WebKit-Dev 
Sent: Friday, December 12, 2008 12:03:04 AM
Subject: [webkit-dev] Fix for WebCore's base64Decode...

I see this in curl and soup code:

   // Use the GLib Base64 if available, since WebCore's decoder isn't
   // general-purpose and fails on Acid3 test 97 (whitespace).

In WebCore's base64Decode, I see this:

   for (unsigned idx = 0; idx < len; idx++) {
   unsigned char ch = data[idx];
   if ((ch > 47 && ch < 58) || (ch > 64 && ch < 91) || (ch > 96 && ch < 
123) || ch == '+' || ch == '/' || ch == '=')
   out[idx] = base64DecMap[ch];
   else
   return false;   <--- it 
shouldn't be doing this
   }

RFC 2045 states:
   All line breaks or other characters not found in Table 1 must
   be ignored by decoding software.

Thus can't WebCore's base64Decode be fixed simply like so, which works as 
expected in my tests:

bool base64Decode(const char* data, unsigned len, Vector& out)
{
   out.clear();
   if (len == 0)
   return true;

   while (len && data[len-1] == '=')
   --len;

   out.grow(len);
   unsigned outSize = 0;
   for (unsigned idx = 0; idx < len; idx++) {
   unsigned char ch = data[idx];
   if ((ch > 47 && ch < 58) || (ch > 64 && ch < 91) || (ch > 96 && ch < 
123) || ch == '+' || ch == '/' || ch == '=') {
   out[outSize] = base64DecMap[ch];
   outSize++;
   }
   }

   out.resize(static_cast(outSize));

   // 4-byte to 3-byte conversion
   unsigned outLen = outSize - ((outSize + 3) / 4);
   if (!outLen || ((outLen + 2) / 3) * 4 < outSize)
   return false;

   unsigned sidx = 0;
   unsigned didx = 0;
   if (outLen > 1) {
   while (didx < outLen - 2) {
   out[didx] = (((out[sidx] << 2) & 255) | ((out[sidx + 1] >> 4) & 
003));
   out[didx + 1] = (((out[sidx + 1] << 4) & 255) | ((out[sidx + 2] >> 
2) & 017));
   out[didx + 2] = (((out[sidx + 2] << 6) & 255) | (out[sidx + 3] & 
077));
   sidx += 4;
   didx += 3;
   }
   }

   if (didx < outLen)
   out[didx] = (((out[sidx] << 2) & 255) | ((out[sidx + 1] >> 4) & 003));

   if (++didx < outLen)
   out[didx] = (((out[sidx + 1] << 4) & 255) | ((out[sidx + 2] >> 2) & 
017));

   if (outLen < out.size())
   out.shrink(outLen);

   return true;
}

Is this all there is to the bug or is there more that I'm not aware of?

Thanks.

Paul








___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] globals and guidelines

[David Kilzer]

And by "a patch" I meant a patch to coding-style.html, not to change every 
static variable (yet :).

Dave




____
From: David Kilzer <[EMAIL PROTECTED]>
To: Cary Clark <[EMAIL PROTECTED]>
Cc: webkit-dev@lists.webkit.org
Sent: Tuesday, December 9, 2008 12:51:57 PM
Subject: Re: [webkit-dev] globals and guidelines


Hi Cary,

There currently isn't a convention.  It would be great if you filed a bug on 
<https://bugs.webkit.org/> to update the coding-style guidelines (and provided 
a patch if you have an opinion on the matter).

Thanks!

Dave





From: Cary Clark <[EMAIL PROTECTED]>
To: webkit-dev@lists.webkit.org
Sent: Tuesday, December 9, 2008 12:46:52 PM
Subject: [webkit-dev] globals and guidelines

Global variables aren't discussed here:

  http://webkit.org/coding/coding-style.html

In sources, I see:
gX.. WebCore/rendering/RenderLayer.h:138:static const
ScrollAlignment gAlignCenterIfNeeded;
s_x.. WebCore/rendering/RenderObject.h:964:static bool s_affectsParentBlock;
AxBx.. WebCore/dom/RangeException.h:41:static const int
RangeExceptionOffset = 200;

Is there one convention for const, and one for non-const? Or none at all?
Thanks
Cary___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] globals and guidelines

[David Kilzer]

Hi Cary,

There currently isn't a convention.  It would be great if you filed a bug on 
 to update the coding-style guidelines (and provided 
a patch if you have an opinion on the matter).

Thanks!

Dave





From: Cary Clark <[EMAIL PROTECTED]>
To: webkit-dev@lists.webkit.org
Sent: Tuesday, December 9, 2008 12:46:52 PM
Subject: [webkit-dev] globals and guidelines

Global variables aren't discussed here:

  http://webkit.org/coding/coding-style.html

In sources, I see:
gX.. WebCore/rendering/RenderLayer.h:138:static const
ScrollAlignment gAlignCenterIfNeeded;
s_x.. WebCore/rendering/RenderObject.h:964:static bool s_affectsParentBlock;
AxBx.. WebCore/dom/RangeException.h:41:static const int
RangeExceptionOffset = 200;

Is there one convention for const, and one for non-const? Or none at all?
Thanks
Cary___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] cygwin gives Bad interpreter No such file or directory

[David Kilzer]

That means you don't have Perl installed with Cygwin.  Try repeating the 
installation step(s) on webkit.org for installing Cygwin (Step 3 under Windows):

http://webkit.org/building/tools.html

Dave





From: Andrew Adcock <[EMAIL PROTECTED]>
To: David D. Kilzer <[EMAIL PROTECTED]>
Cc: webkit-dev@lists.webkit.org
Sent: Saturday, December 6, 2008 2:15:58 PM
Subject: Re: [webkit-dev] cygwin gives Bad interpreter No such file or directory

when I run those I get:

bash: perl: command not found

and
which: no perl in 
(/usr/local/bin:/usr/bin:/usr/X11R6/bin:/cygdrive/c/Windows/system32:/cygdrive/c/Windows:/cygdrive/c/Windows/System32/Wben:/cygdrive/c/Program
 Files/CyberLink/Power2Go/: cygdrive/c/Program 
Files/QuickTime/QTSystem/:/cygdrive/c/Program Files/Microsoft SQL 
Server/90/Tools/binn/:cygdrive/c/Program Files/SlikSvn/bin/)

David D. Kilzer wrote:
> Run "perl --version" to see which build/version of Perl you're using, and 
> "which perl" to see where in your path the perl.exe binary is located.
> 
> Dave
> 
> 
> 
> *From:* Andrew Adcock <[EMAIL PROTECTED]>
> *To:* Darren VanBuren <[EMAIL PROTECTED]>
> *Cc:* webkit-dev@lists.webkit.org
> *Sent:* Saturday, December 6, 2008 1:30:24 PM
> *Subject:* Re: [webkit-dev] cygwin gives Bad interpreter No such file or 
> directory
> 
> I installed the downloader available through 
> http://webkit.org/building/tools.html
> so I am not sure if it came with Perl  - is there a way that I can check?
> 
> Darren VanBuren wrote:
> >
> > On Dec 6, 2008, at 12:07 PM, Andrew Adcock wrote:
> >
> >> Hello all,
> >>
> >> I tried finding a solution as best I could but nothing came up after 
> >> several hours.
> >> My problem is that I am trying to build webkit - I know that I have 
> >> everything installed (Checked 3 or 4 times) and I know the file is where I 
> >> would expect because when I type:
> >> find WebKit/WebKitTools/Scripts/build-webkit  its there plain as day.
> >>
> >> So what am I missing?
> >>
> >> I am using windows Vista and Visual C++ 2005 Express Edition
> >>
> >> Thanks,
> >> Andy
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] cygwin gives Bad interpreter No such file or directory

[David Kilzer]

Run "perl --version" to see which build/version of Perl you're using, and 
"which perl" to see where in your path the perl.exe binary is located.

Dave





From: Andrew Adcock <[EMAIL PROTECTED]>
To: Darren VanBuren <[EMAIL PROTECTED]>
Cc: webkit-dev@lists.webkit.org
Sent: Saturday, December 6, 2008 1:30:24 PM
Subject: Re: [webkit-dev] cygwin gives Bad interpreter No such file or directory

I installed the downloader available through 
http://webkit.org/building/tools.html
so I am not sure if it came with Perl  - is there a way that I can check?

Darren VanBuren wrote:
> 
> On Dec 6, 2008, at 12:07 PM, Andrew Adcock wrote:
> 
>> Hello all,
>> 
>> I tried finding a solution as best I could but nothing came up after several 
>> hours.
>> My problem is that I am trying to build webkit - I know that I have 
>> everything installed (Checked 3 or 4 times) and I know the file is where I 
>> would expect because when I type:
>> find WebKit/WebKitTools/Scripts/build-webkit  its there plain as day.
>> 
>> So what am I missing?
>> 
>> I am using windows Vista and Visual C++ 2005 Express Edition
>> 
>> Thanks,
>> Andy
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> Did you install Cygwin with Perl?
> 
> Darren VanBuren
> [EMAIL PROTECTED] 
> --
> Administrator of Onekopakaspace
> 
> Blog:
> http://oks.kicks-ass.net/~onekopaka/blog/ 
> 
> 
> Sweetcron install:
> http://sweetcron.oks.kicks-ass.net/
> 
> PGP Key: 66F46296 (gpg --keyserver pgp.mit.edu --recv-keys 66F46296)
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] webkit documentation

[David Kilzer]

Jack,

You did not create a patch to the actual HTML file that you wanted to change.  
You simply attached a text file with a description of the link.  If you need 
help on how to create a patch or checkout the "source" for the web site, please 
ask.

Dave





From: Jack Wootton <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Cc: webkit-dev@lists.webkit.org
Sent: Friday, November 21, 2008 8:25:32 AM
Subject: Re: [webkit-dev] webkit documentation

I have done this, but it was rejected:

https://bugs.webkit.org/show_bug.cgi?id=20125

On Mon, Jul 21, 2008 at 3:22 PM, David Kilzer <[EMAIL PROTECTED]> wrote:
> We update the web site through patches.  Just file a bug on bugs.webkit.org 
> and attach a patch with ChangeLog for review!
>
> Dave
>
>
> On Mon, 7/21/08, Jack Wootton <[EMAIL PROTECTED]> wrote:
>
>> OK, it seems this is a good place to start
>>
>> http://developer.apple.com/documentation/Cocoa/Conceptual/DisplayWebContent/Concepts/WebKitDesign.html
>>
>> Had to use Google to find it though, is it linked to on
>> http://webkit.org/ at all?
>>
>> Cheers,
>> Jack
>>
>> On Mon, Jul 21, 2008 at 9:57 AM, Jack Wootton
>> <[EMAIL PROTECTED]> wrote:
>> > Hi all,
>> >
>> > I am mainly interested in S60 WebKit, however due to
>> the project
>> > seeming to be in complete disarray to those not
>> working for Nokia,
>> > I've decided to focus my efforts on the WebKit
>> branch from which S60
>> > WebKit started. I understand this to be Tiger 10.4.7
>> (it was one of
>> > the few pieces of information about S60 WebKit that I
>> could actually
>> > find - although it will almost certainly turn out to
>> be incorrect :p):
>> >
>> >
>> http://trac.webkit.org/browser/releases/Apple/Tiger/Mac%20OS%20X%20Update%2010.4.7
>> >
>> > Where can I find documentation for this code?  The
>> question here is,
>> > other than trawling through code, where can I find
>> documentation that
>> > explain it's implementation?
>> >
>> > Cheers,
>> > Jack
>> >
>>
>
>



-- 
Regards
Jack
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Problem with transparency and webpages without bgcolor definition -> Bug?

[David Kilzer]

Hi Bernd,

Please file a bug on  and 
attach a patch for review.  Thanks!

Dave





From: "Weber, Bernd" <[EMAIL PROTECTED]>
To: webkit-dev@lists.webkit.org
Sent: Thursday, November 20, 2008 7:43:26 PM
Subject: [webkit-dev] Problem with transparency and webpages without bgcolor 
definition -> Bug?


Hi,
 
I run a GTK webkit here with transparency activated. Now
we found when we load an HTML page that has no bgcolor information, neither as
attribute in the body tag, nor as stylesheet property, then the page background
is set to transparent and not to the default background color defined in
WebCore/page/FrameView.cpp (->m_baseBackgroundColor). This seems to be
because the check in WebCore/rendering/RenderBox.cpp line 835 is wrong. In case
of an invalid background color, like in our case, it shouldn’t matter
whether transparency is active or not the background should then always be set
to the baseBackgroundColor. I think the parenthesis’ are just set
incorrectly here.
 
Should be ->   if (isRoot() &&
(!bgColor.isValid() || (bgColor.alpha() < 0xFF && !isTransparent)))
{
 
 
-Bernd


This message (including any attachments) may contain confidential information 
intended for a specific individual and purpose.  If you are not the intended 
recipient, delete this message.  If you are not the intended recipient, 
disclosing, copying, distributing, or taking any action based on this message 
is strictly prohibited. ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Build errors

[David Kilzer]

I see a warning and an error that should be investigated.  This looks like an 
unsupported command-line switch (may be nothing, or could be the cause of the 
build failure):

if sort /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/CSSPropertyNames.in 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/SVGCSSPropertyNames.in | uniq -d 
| grep -E '^[^#]'; then echo 'Duplicate value!'; exit 1; fi
touch CSSGrammar.cpp.h
Invalid switch.


This is the immediate cause of the build failure:

if sort CSSValueKeywords.in | uniq -d | grep -E '^[^#]'; then echo 'Duplicate 
value!'; exit 1; fi
gperf -CEot -L ANSI-C -k "*" -N findDoctypeEntry -F 
,PubIDInfo::eAlmostStandards,PubIDInfo::eAlmostStandards 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/html/DocTypeStrings.gperf > 
DocTypeStrings.cpp
Duplicate value!


It looks like there are duplicate values in CSSValueKeywords.in, or the 
uniq/grep commands aren't running the same on your system.

Dave





From: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
Cc: webkit-dev@lists.webkit.org
Sent: Tuesday, November 18, 2008 7:43:53 AM
Subject: Re: [webkit-dev] Build errors

I looked in WebCoreGenerated and found the build log.

I saw some errors in the log relating to an invalid switch, but I can't tell 
which it's referring to.

/cygdrive/c/Users/DTENNE~1/WebKit/WE1674~1/include/JavaScriptCore/create_hash_table
 /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/js/JSDOMWindowBase.cpp -n 
WebCore > JSDOMWindowBase.lut.h
Creating hashtable for 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/js/JSDOMWindowBase.cpp
/cygdrive/c/Users/DTENNE~1/WebKit/WE1674~1/include/JavaScriptCore/create_hash_table
 /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/js/JSRGBColor.cpp -n 
WebCore > JSRGBColor.lut.h
/cygdrive/c/Users/DTENNE~1/WebKit/WE1674~1/include/JavaScriptCore/create_hash_table
 /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/js/JSWorkerContext.cpp -n 
WebCore > JSWorkerContext.lut.h
Creating hashtable for 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/js/JSRGBColor.cpp
perl -I /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/scripts 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/scripts/generate-bindings.pl 
--include dom --include html --include css --include page --include xml 
--include svg --outputDir . --defines "ENABLE_DATABASE ENABLE_DOM_STORAGE 
ENABLE_ICONDATABASE ENABLE_OFFLINE_WEB_APPLICATIONS ENABLE_XPATH ENABLE_SVG 
ENABLE_SVG_ANIMATION ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT 
ENABLE_SVG_AS_IMAGE ENABLE_SVG_USE ENABLE_VIDEO LANGUAGE_JAVASCRIPT" 
--generator JS 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/inspector/JavaScriptCallFrame.idl
Creating hashtable for 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/bindings/js/JSWorkerContext.cpp
bison -d -p cssyy /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/CSSGrammar.y -o 
CSSGrammar.cpp
if sort /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/CSSPropertyNames.in 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/SVGCSSPropertyNames.in | uniq -d 
| grep -E '^[^#]'; then echo 'Duplicate value!'; exit 1; fi
touch CSSGrammar.cpp.h
Invalid switch.
touch CSSGrammar.hpp
cat /cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/CSSPropertyNames.in 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/SVGCSSPropertyNames.in > 
CSSPropertyNames.in
echo '#ifndef CSSGrammar_h' > CSSGrammar.h
echo '#define CSSGrammar_h' >> CSSGrammar.h
perl "/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/makeprop.pl"
cat CSSGrammar.cpp.h CSSGrammar.hpp >> CSSGrammar.h
echo '#endif' >> CSSGrammar.h
rm -f CSSGrammar.cpp.h CSSGrammar.hpp
# Lower case all the values, as CSS values are case-insensitive
perl -ne 'print lc' 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/CSSValueKeywords.in 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/css/SVGCSSValueKeywords.in > 
CSSValueKeywords.in
gperf -CDEot -L ANSI-C -k '*' -N findColor -D -s 2 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/platform/ColorData.gperf > ColorData.c
if sort CSSValueKeywords.in | uniq -d | grep -E '^[^#]'; then echo 'Duplicate 
value!'; exit 1; fi
gperf -CEot -L ANSI-C -k "*" -N findDoctypeEntry -F 
,PubIDInfo::eAlmostStandards,PubIDInfo::eAlmostStandards 
/cygdrive/c/Users/DTENNE~1/WebKit/WebCore/html/DocTypeStrings.gperf > 
DocTypeStrings.cpp
Duplicate value!
make: *** [CSSValueKeywords.h] Error 1
make: *** Waiting for unfinished jobs



--- On Sat, 11/15/08, Julien Chaffraix <[EMAIL PROTECTED]> wrote:

> From: Julien Chaffraix <[EMAIL PROTECTED]>
> Subject: Re: [webkit-dev] Build errors
> To: [EMAIL PROTECTED]
> Cc: webkit-dev@lists.webkit.org
> Date: Saturday, November 15, 2008, 9:02 AM
> Hi,
> 
> On Fri, Nov 14, 2008 at 6:19 PM, [EMAIL PROTECTED]
> <[EMAIL PROTECTED]> wrote:
> > I'm trying to successfully build WebKit using
> Visual Studio 2005 but I keep getting compile errors.
> >
> > SVGElement.h includes SVGNames.h but I don't see
> SVGNames.h in any directory.
> > No such file for HTMLNames.cpp
> >
> > My SVN checkout succeeded so I'm not sure why
> I'm running into this

Re: [webkit-dev] issue: accessing DOM elements directly, without using getElementById() from inside javascripts

[David Kilzer]

It's possible that the bug is in JSC, but since it works for *.html pages, it 
seems like it may be an issue with "enabling" this feature in XHTML pages.

https://bugs.webkit.org/show_bug.cgi?id=22211

Thanks again for filing this bug!

Dave




From: "Deshpande, Raghavendra" <[EMAIL PROTECTED]>
To: David Kilzer <[EMAIL PROTECTED]>
Sent: Wednesday, November 12, 2008 11:28:33 AM
Subject: RE: [webkit-dev] issue: accessing DOM elements directly, without   
using getElementById() from inside javascripts


Hello Dave,
   
 I would like to share my opinion.  
As per my observation, it work fine in Chrome, but not in Safari. And the major 
difference between these two is, the JS core. 
 
So, Can this be a bug in JavascriptCore ?
 
Warm Regards,
Raghavendra Deshpande
 
________
 From: David Kilzer [EMAIL PROTECTED]
Sent: Thursday, November 13, 2008 12:56 AM
To: Deshpande, Raghavendra
Subject: Re: [webkit-dev] issue: accessing DOM elements directly, without using 
getElementById() from inside javascripts


Hi Raghavendra,

Thanks for filing the bug.  Please feel free to CC me on it.

I don't know what causes the issue (I'm not currently familiar with the code 
that may have the bug), so I don't know if it's a quick fix or not.  The fact 
that it works when you change the file suffix leads me to think that it could 
be a quick fix, though, once the buggy code is found.

Dave





 From: "Deshpande, Raghavendra" <[EMAIL PROTECTED]>
To: David Kilzer <[EMAIL PROTECTED]>
Sent: Wednesday, November 12, 2008 10:25:13 AM
Subject: RE: [webkit-dev] issue: accessing DOM elements directly, without using 
getElementById() from inside javascripts


Dave,
  
I will file it as a bug. Its strange that, if you just rename my test page 
to .html ... All works fine. 
I am not able to understand this. Can you please enlighten me on this behavior.
 
And, Do you have any idea on a quick fix for this issue?.
 
Warm Regards,   
 
Raghavendra Deshpande
 

 From: David Kilzer [EMAIL PROTECTED]
Sent: Wednesday, November 12, 2008 11:11 PM
To: Deshpande, Raghavendra
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] issue: accessing DOM elements directly, without using 
getElementById() from inside javascripts


Please file a bug using <https://bugs.webkit.org/enter_bug.cgi?product=WebKit> 
and attach your reduced test case.  Thanks!

Dave





 From: "Deshpande, Raghavendra" <[EMAIL PROTECTED]>
To: "webkit-dev@lists.webkit.org" 
Sent: Wednesday, November 12, 2008 2:58:39 AM
Subject: [webkit-dev] issue: accessing DOM elements directly, without using 
getElementById() from inside javascripts


Hi All,
 
In Gtk-Webkit browser,  we are facing issues with respect to accessing DOM 
elements directly, without using getElementById() from inside javascripts. We 
have many XHTML pages written already, without using getElementById() and all 
the pages are perfectly working fine in Opera. 
 
As “Chrome” is built using webkit, I tried testing the pages on ‘Chrome’. To my 
surprise, the same files worked fine in ‘Chrome’.
 
Then, I tried with Safari, (latest nightly updated), the behavior is same as 
Gtk-Webkit. It throws, “Can’t  find variable: DOM element name”
 
Have any of you faced such an issue?, Is there any fix for it?
As we can’t change the pages now, Is there any temporary hack?
 
Warm Regards,
Raghavendra
 

 The information contained in this message may be confidential and legally 
protected under applicable law. The message is intended solely for the 
addressee(s). If you are not the intended recipient, you are hereby notified 
that any use, forwarding, dissemination, or reproduction of this message is 
strictly prohibited and may be unlawful. If you are not the intended recipient, 
please contact the sender by return e-mail and destroy all copies of the 
original message.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] issue: accessing DOM elements directly, without using getElementById() from inside javascripts

[David Kilzer]

Please file a bug using  
and attach your reduced test case.  Thanks!

Dave





From: "Deshpande, Raghavendra" <[EMAIL PROTECTED]>
To: "webkit-dev@lists.webkit.org" 
Sent: Wednesday, November 12, 2008 2:58:39 AM
Subject: [webkit-dev] issue: accessing DOM elements directly, without using 
getElementById() from inside javascripts


Hi All,
 
In Gtk-Webkit browser,  we are facing issues with respect to accessing DOM 
elements directly, without using getElementById() from inside javascripts. We 
have many XHTML pages written already, without using getElementById() and all 
the pages are perfectly working fine in Opera. 
 
As “Chrome” is built using webkit, I tried testing the pages on ‘Chrome’. To my 
surprise, the same files worked fine in ‘Chrome’.
 
Then, I tried with Safari, (latest nightly updated), the behavior is same as 
Gtk-Webkit. It throws, “Can’t  find variable: DOM element name”
 
Have any of you faced such an issue?, Is there any fix for it?
As we can’t change the pages now, Is there any temporary hack?
 
Warm Regards,
Raghavendra___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] leak

[David Kilzer]

On Tue, 11/4/08, mario bensi <[EMAIL PROTECTED]> wrote:

> I seen in Changeset 3810, you force a leak, it's the
> same thing for the cache 
> and others parts in webCore, I would understand why you
> want leak some part of 
> code ?

Do you mean r38104?

http://trac.webkit.org/changeset/38104

This change was made to prevent destructors from being called on shutdown, both 
to prevent random crashes (since the order in which the destructors are called 
is non-deterministic) and to make shutdown faster.

They are "leaks" only in the strictest sense of the term since only one 
instance of them is ever created, and it's held in a static variable.

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] make[1]: *** [libWebCore.la] Error 255

[David Kilzer]

tk/libWebCore_la-EventLoopGtk.lo
> WebCore/plat
> form/gtk/libWebCore_la-FileChooserGtk.lo
> WebCore/platform/gtk/libWebCore_la-File
> SystemGtk.lo WebCore/platform/gtk/libWebCore_la-KURLGtk.lo
> WebCore/platform/gtk/
> libWebCore_la-KeyEventGtk.lo
> WebCore/platform/gtk/libWebCore_la-Language.lo WebC
> ore/platform/gtk/libWebCore_la-LocalizedStringsGtk.lo
> WebCore/platform/gtk/libWe
> bCore_la-LoggingGtk.lo
> WebCore/platform/gtk/libWebCore_la-MIMETypeRegistryGtk.lo
>  WebCore/platform/gtk/libWebCore_la-MouseEventGtk.lo
> WebCore/platform/gtk/libWeb
> Core_la-PasteboardGtk.lo
> WebCore/platform/gtk/libWebCore_la-PlatformScreenGtk.lo
>  WebCore/platform/gtk/libWebCore_la-PopupMenuGtk.lo
> WebCore/platform/gtk/libWebC
> ore_la-RenderThemeGtk.lo
> WebCore/platform/gtk/libWebCore_la-ScrollViewGtk.lo Web
> Core/platform/gtk/libWebCore_la-ScrollbarGtk.lo
> WebCore/platform/gtk/libWebCore_
> la-ScrollbarThemeGtk.lo
> WebCore/platform/gtk/libWebCore_la-SearchPopupMenuGtk.lo
>  WebCore/platform/gtk/libWebCore_la-SharedBufferGtk.lo
> WebCore/platform/gtk/libW
> ebCore_la-SharedTimerGtk.lo
> WebCore/platform/gtk/libWebCore_la-SoundGtk.lo WebCo
> re/platform/gtk/libWebCore_la-SystemTimeGtk.lo
> WebCore/platform/gtk/libWebCore_l
> a-TemporaryLinkStubs.lo
> WebCore/platform/gtk/libWebCore_la-WheelEventGtk.lo WebC
> ore/platform/gtk/libWebCore_la-WidgetGtk.lo
> WebCore/platform/gtk/libWebCore_la-g
> tk2drawing.lo
> WebCore/platform/gtk/libWebCore_la-guriescape.lo
> WebCore/platform/
> image-decoders/bmp/libWebCore_la-BMPImageDecoder.lo
> WebCore/platform/image-decod
> ers/gif/libWebCore_la-GIFImageDecoder.lo
> WebCore/platform/image-decoders/gif/lib
> WebCore_la-GIFImageReader.lo
> WebCore/platform/image-decoders/ico/libWebCore_la-I
> COImageDecoder.lo
> WebCore/platform/image-decoders/jpeg/libWebCore_la-JPEGImageDe
> coder.lo
> WebCore/platform/image-decoders/png/libWebCore_la-PNGImageDecoder.lo
> We
> bCore/platform/image-decoders/xbm/libWebCore_la-XBMImageDecoder.lo
>  WebCore/plat
> form/text/gtk/libWebCore_la-TextCodecGtk.lo
> WebCore/platform/text/gtk/libWebCore
> _la-TextBoundariesGtk.lo
> WebCore/platform/text/gtk/libWebCore_la-TextBreakIterat
> orGtk.lo
> WebCore/platform/graphics/gtk/libWebCore_la-FontCustomPlatformData.lo
> W
> ebCore/platform/graphics/gtk/libWebCore_la-FontPlatformDataGtk.lo
> WebCore/platfo
> rm/graphics/gtk/libWebCore_la-GlyphPageTreeNodeGtk.lo
> WebCore/platform/graphics/
> gtk/libWebCore_la-SimpleFontDataGtk.lo   
> DerivedSources/libWebCore_la-CSSGramma
> r.lo DerivedSources/libWebCore_la-HTMLEntityNames.lo
> DerivedSources/libWebCore_l
> a-HTMLNames.lo
> DerivedSources/libWebCore_la-JSHTMLElementWrapperFactory.lo
> Deriv
> edSources/libWebCore_la-UserAgentStyleSheetsData.lo
> DerivedSources/libWebCore_la
> -XMLNames.lo   libJavaScriptCore.la libWebCoreJS.la 
> -pthread -L/usr/webkit/lib
> -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0  
> -L/usr/webkit/lib -lxml2   -L/usr/
> webkit/lib -L/usr/shr/lib -lcairo -lpng12 -lpixman-1
> -lfreetype -lfontconfig -ld
> irectfb -lfusion -ldirect -lpthread   -L/usr/webkit/lib
> -lpango-1.0 -lgobject-2.
> 0 -lgmodule-2.0 -lglib-2.0   -L/usr/shr/lib
> -L/usr/webkit/lib -lgtk-directfb-2.0
>  -lgdk-directfb-2.0 -latk-1.0 -lgdk_pixbuf-2.0
> -lpangocairo-1.0 -lpango-1.0 -lca
> iro -lpng12 -lpixman-1 -ldirectfb -ldirect -lfusion
> -lfreetype -lfontconfig -lgo
> bject-2.0 -lgmodule-2.0 -lglib-2.0-L/usr/webkit/lib
> -lcurl-L/usr/webkit/
> lib -lfontconfig -lfreetype -lz   -L/usr/webkit/lib
> -lpango-1.0 -lgobject-2.0 -l
> gmodule-2.0 -lglib-2.0   -ljpeg -L/usr/webkit/lib
> -lpng12   -lpthread
> make[1]: *** [libWebCore.la] Error 255
> make[1]: Leaving directory
> `/usr/webkit/src/WebKit-r37990'
> make: *** [all] Error 2
> 
> 
> 
> -Original Message-
> From: David Kilzer [mailto:[EMAIL PROTECTED]
> Sent: Friday, October 31, 2008 8:20 PM
> To: Bn, Sharath
> Cc: webkit-dev@lists.webkit.org
> Subject: Re: make[1]: *** [libWebCore.la] Error 255
> 
> On Fri, 10/31/08, Bn, Sharath
> <[EMAIL PROTECTED]> wrote:
> 
> > I get the following error after I give
> "make"
> > command,
> > Can anybody help me to fix this problem
> >
> > make[1]: *** [libWebCore.la] Error 255
> > make[1]: Leaving directory
> > `/usr/webkit/src/WebKit-r37990'
> > make: *** [all] Error 2
> 
> The interesting failures happened before these lines.  You
> either need to provide more log output, or find the earlier
> error messages to include in the email.
> 
> Also knowing which port you are compiling and for which
> operating system would be useful.
> 
> Dave
> 
> 
> 
> The information contained in this message may be
> confidential and legally protected under applicable law. The
> message is intended solely for the addressee(s). If you are
> not the intended recipient, you are hereby notified that any
> use, forwarding, dissemination, or reproduction of this
> message is strictly prohibited and may be unlawful. If you
> are not the intended recipient, please contact the sender by
> return e-mail and destroy all copies of the original
> message.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Geolocation questions

[David Kilzer]

On Fri, 10/31/08, Holger Freyther <[EMAIL PROTECTED]> wrote:

> Hey,
> I have started implementing  a GeoLocation service for Gtk+
> using the Gypsy 
> interface. I have some comments and questions:
> 
> 1.) Could we remove GeolocationService::create from
> GeolocationService.cpp? 
> Any platform that intends to implement this can have this
> factory in their 
> GeolocationServiceFoo.cpp? This makes it possible to add
> and remove platforms 
> without touching this file.
> 
> 2.) Geoposition is RefCounted but we pass Geoposition* all
> over the place? Can 
> we decide on of the two? This would also make the ownership
> more clear.
> 
> should I send patches for the above?

Yes, please file separate bugs for each of these issues and attach the patches. 
 Thanks!

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] make[1]: *** [libWebCore.la] Error 255

[David Kilzer]

On Fri, 10/31/08, Bn, Sharath <[EMAIL PROTECTED]> wrote:

> I get the following error after I give "make"
> command,
> Can anybody help me to fix this problem
> 
> make[1]: *** [libWebCore.la] Error 255
> make[1]: Leaving directory
> `/usr/webkit/src/WebKit-r37990'
> make: *** [all] Error 2

The interesting failures happened before these lines.  You either need to 
provide more log output, or find the earlier error messages to include in the 
email.

Also knowing which port you are compiling and for which operating system would 
be useful.

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Save Page - Ideas

[David Kilzer]

On Thu, 10/30/08, zaheer ahmad <[EMAIL PROTECTED]> wrote:

> iam working on implementing save page functionality. Looks
> like its not
> already supported in the core.

Apple's Mac port saves ".webarchive" files.  The format is specific to the 
CoreFoundation framework, but there is platform-specific code that does this 
nevertheless.

> Following are some high
> level ideas and iam
> not sure if some or all of these are the right approaches
> to this problem
> 
> - write the page data to the file system as and when is
> received - but this
> is not optimal since this incurs constant overhead on page
> load

Don't do this.

> - apis to retreive the source (html, js, css) and
> image/object data
> (original form) from the document. I think the
> parsers/loaders incrementally
> handle the data and throw off the parsed text - pls
> validate my
> understanding here.

There should be API to do this already.  Look at how content for .webarchive 
files is retrieved.

> - parse and convert all the html absolute/relative URIs to
> relative URIs on
> the file system

Bug 7211: Support save as "Web page, complete" in Firefox format
https://bugs.webkit.org/show_bug.cgi?id=7211

> - any other optimized storage methods - e.g. storing the
> entire page as a
> single file using multipart content

Bug 7169: Support exporting of MHTML web archives
https://bugs.webkit.org/show_bug.cgi?id=7169

I would strongly encourage you to reuse an existing format rather than 
inventing your own.  (In my opinion the Firefox format is preferred because 
it's readable by all web browsers.)

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] problems in cross compiling webkit - Execution of JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

[David Kilzer]

You need to change more than that.  Did you look at the patch in Bug 21832?

https://bugs.webkit.org/attachment.cgi?id=24615

You could also update to svn r37819 or newer to pick up the fix.

Dave


On Thu, 10/30/08, Bn, Sharath <[EMAIL PROTECTED]> wrote:

> I modified the line
> - my $fh = new File::Temp(
> + my $fh = File::Temp->tempfile(
> 
> And I get some error like this
> 
> JavaScriptCore/pcre/dftables
> JavaScriptCore/pcre/chartables.c
> Error in tempfile() using /tmp/File::Temp.in: The template
> must contain at least
>  4 'X' characters
>  at JavaScriptCore/pcre/dftables line 245
> make: *** [JavaScriptCore/pcre/chartables.c] Error 255
> 
> I modified the line
> - my $fh = new File::Temp( to
> + my $fh = File::Temp->new(
> 
> And I get some error like this
> 
> JavaScriptCore/pcre/dftables
> JavaScriptCore/pcre/chartables.c
> Can't locate object method "new" via package
> "File::Temp" at JavaScriptCore/pcre
> /dftables line 245.
> make: *** [JavaScriptCore/pcre/chartables.c] Error 255
> 
> Pls let me know how to solve this build error
> 
> 
> 
> Sharath
> 
> -Original Message-
> From: David Kilzer [mailto:[EMAIL PROTECTED]
> Sent: Friday, October 24, 2008 12:00 AM
> To: Bn, Sharath
> Cc: webkit-dev@lists.webkit.org
> Subject: RE: [webkit-dev] problems in cross compiling
> webkit - Execution of JavaScriptCore/kjs/create_hash_table
> aborted due to compilation errors.
> 
> Filed this bug to cover the create_hash_table fix for Perl
> 5.10:
> 
> https://bugs.webkit.org/show_bug.cgi?id=21831
> 
> It would seem the "Object Interface" for
> File::Temp has changed in Perl 5.10:
> 
> $fh = File::Temp->new(TEMPLATE => $template);
> 
> Originally you could do this:
> 
> $fh = new File::Temp($template);
> 
> It looks like the only way to fix this is to use the
> File::Temp->tempfile() method instead.  What a pain.
> 
> These scripts appear to have the same issue (because I
> wrote them?!):
> 
> WebKitTools/Scripts/bisect-builds
> WebKitTools/Scripts/sort-Xcode-project-file
> 
> I filed:
> 
> https://bugs.webkit.org/show_bug.cgi?id=21832
> 
> I should have a patch up shortly to fix all three scripts.
> 
> Dave
> 
> 
> On Thu, 10/23/08, Bn, Sharath
> <[EMAIL PROTECTED]> wrote:
> 
> > The FIX worked. Thanks a lot.
> > Perl version was v5.8.0. I have upgraded the perl to
> > v5.10.0.
> > The fix is required for v5.10.0 version as well.
> Without
> > your fix even 5.10.0 cribs.
> > However now I get some other error as mentioned below.
> >
> > JavaScriptCore/pcre/dftables
> > JavaScriptCore/pcre/chartables.c
> > Can't locate object method "new" via
> package
> > "File::Temp" at JavaScriptCore/pcre
> > /dftables line 245.
> > make: *** [JavaScriptCore/pcre/chartables.c] Error 255
> >
> > Regards
> > Sharath.B.N
> >
> > -Original Message-
> > From: David Kilzer [mailto:[EMAIL PROTECTED]
> > Sent: Wednesday, October 22, 2008 7:44 PM
> > To: Bn, Sharath
> > Cc: webkit-dev@lists.webkit.org
> > Subject: Re: [webkit-dev] problems in cross compiling
> > webkit - Execution of
> JavaScriptCore/kjs/create_hash_table
> > aborted due to compilation errors.
> >
> > On Wed, 10/22/08, Bn, Sharath
> > <[EMAIL PROTECTED]> wrote:
> >
> > > /usr/bin/perl
> JavaScriptCore/kjs/create_hash_table
> > > JavaScriptCore/kjs/keywords.table >
> > > DerivedSources/lexer.lut.h
> > > Global symbol "@nameEntries" requires
> > explicit
> > > package name at
> JavaScriptCore/kjs/create_hash_table
> > line
> > > 218.
> > > Execution of JavaScriptCore/kjs/create_hash_table
> > aborted
> > > due to compilation errors.
> > > make: *** [DerivedSources/lexer.lut.h] Error 255
> >
> > Ha!  What version of Perl are you using (run
> "perl
> > -v")?  It looks like Perl is interpreting a
> print()
> > statement differently.  Try making this change (adding
> > backslashes before the square brackets in
> > create_hash_table):
> >
> > -print "\nstatic const struct
> HashTableValue
> > ${nameEntries}[$count] = {\n";
> > +print "\nstatic const struct
> HashTableValue
> > ${nameEntries}\[$count\] = {\n";
> >
> > Let me know if that fixes the problem.
> >
> > Dave
> >
> >
> >
> > The information contained in this message may be
> > confidential and le

Re: [webkit-dev] How to access resource meta-data

[David Kilzer]

On Wed, 10/29/08, Andrew S. Townley <[EMAIL PROTECTED]> wrote:

> Fair enough.  What I'm looking for at a minimum is the
> headers
> associated with each HTTP response.  It would be nice to
> also be able to
> extract any HTML meta tags and have access to those as
> well.
> 
> Other "interesting" things available to the user
> from Firefox's Page
> Info dialog include:
> 
>  - Referring URL
>  - Additional security information
>  - Number of visits, cookies, etc.
>  - List of linked/inline resources
> 
> However, I can do the majority of what I need with the
> headers.

I think most of this information (except maybe the  tags) is available 
through the Web Inspector.  You could review the source code for it to 
determine how to get what you're looking for.

Also, is there a reason the Web Inspector isn't sufficient for your needs?

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] problems in cross compiling webkit - Execution of JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

[David Kilzer]

Filed this bug to cover the create_hash_table fix for Perl 5.10:

https://bugs.webkit.org/show_bug.cgi?id=21831

It would seem the "Object Interface" for File::Temp has changed in Perl 5.10:

$fh = File::Temp->new(TEMPLATE => $template);

Originally you could do this:

$fh = new File::Temp($template);

It looks like the only way to fix this is to use the File::Temp->tempfile() 
method instead.  What a pain.

These scripts appear to have the same issue (because I wrote them?!):

WebKitTools/Scripts/bisect-builds
WebKitTools/Scripts/sort-Xcode-project-file

I filed:

https://bugs.webkit.org/show_bug.cgi?id=21832

I should have a patch up shortly to fix all three scripts.

Dave


On Thu, 10/23/08, Bn, Sharath <[EMAIL PROTECTED]> wrote:

> The FIX worked. Thanks a lot.
> Perl version was v5.8.0. I have upgraded the perl to
> v5.10.0.
> The fix is required for v5.10.0 version as well. Without
> your fix even 5.10.0 cribs.
> However now I get some other error as mentioned below.
> 
> JavaScriptCore/pcre/dftables
> JavaScriptCore/pcre/chartables.c
> Can't locate object method "new" via package
> "File::Temp" at JavaScriptCore/pcre
> /dftables line 245.
> make: *** [JavaScriptCore/pcre/chartables.c] Error 255
> 
> Regards
> Sharath.B.N
> 
> -Original Message-
> From: David Kilzer [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, October 22, 2008 7:44 PM
> To: Bn, Sharath
> Cc: webkit-dev@lists.webkit.org
> Subject: Re: [webkit-dev] problems in cross compiling
> webkit - Execution of JavaScriptCore/kjs/create_hash_table
> aborted due to compilation errors.
> 
> On Wed, 10/22/08, Bn, Sharath
> <[EMAIL PROTECTED]> wrote:
> 
> > /usr/bin/perl JavaScriptCore/kjs/create_hash_table
> > JavaScriptCore/kjs/keywords.table >
> > DerivedSources/lexer.lut.h
> > Global symbol "@nameEntries" requires
> explicit
> > package name at JavaScriptCore/kjs/create_hash_table
> line
> > 218.
> > Execution of JavaScriptCore/kjs/create_hash_table
> aborted
> > due to compilation errors.
> > make: *** [DerivedSources/lexer.lut.h] Error 255
> 
> Ha!  What version of Perl are you using (run "perl
> -v")?  It looks like Perl is interpreting a print()
> statement differently.  Try making this change (adding
> backslashes before the square brackets in
> create_hash_table):
> 
> -print "\nstatic const struct HashTableValue
> ${nameEntries}[$count] = {\n";
> +print "\nstatic const struct HashTableValue
> ${nameEntries}\[$count\] = {\n";
> 
> Let me know if that fixes the problem.
> 
> Dave
> 
> 
> 
> The information contained in this message may be
> confidential and legally protected under applicable law. The
> message is intended solely for the addressee(s). If you are
> not the intended recipient, you are hereby notified that any
> use, forwarding, dissemination, or reproduction of this
> message is strictly prohibited and may be unlawful. If you
> are not the intended recipient, please contact the sender by
> return e-mail and destroy all copies of the original
> message.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] problems in cross compiling webkit - Execution of JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

[David Kilzer]

On Wed, 10/22/08, Bn, Sharath <[EMAIL PROTECTED]> wrote:

> /usr/bin/perl JavaScriptCore/kjs/create_hash_table
> JavaScriptCore/kjs/keywords.table >
> DerivedSources/lexer.lut.h
> Global symbol "@nameEntries" requires explicit
> package name at JavaScriptCore/kjs/create_hash_table line
> 218.
> Execution of JavaScriptCore/kjs/create_hash_table aborted
> due to compilation errors.
> make: *** [DerivedSources/lexer.lut.h] Error 255

Ha!  What version of Perl are you using (run "perl -v")?  It looks like Perl is 
interpreting a print() statement differently.  Try making this change (adding 
backslashes before the square brackets in create_hash_table):

-print "\nstatic const struct HashTableValue ${nameEntries}[$count] = {\n";
+print "\nstatic const struct HashTableValue ${nameEntries}\[$count\] = 
{\n";

Let me know if that fixes the problem.

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Webkit (Mobile Safari) issues in the iPhone

[David Kilzer]

On Wed, 10/15/08, Diego Taylor <[EMAIL PROTECTED]> wrote:

> On Thu, Oct 16, 2008 at 2:09 AM, David Kilzer <[EMAIL PROTECTED]> wrote:
> > Having said that, if you're seeing an issue with -[UIWebView
> > stringByEvaluatingJavaScriptFromString:], please file a bug
> > on <http://developer.apple.com/bugreporter/>.  A reproducible
> > test case (orattaching your entire project as a zip archive)
> > with steps to reproduce is greatly appreciated.  Thanks!
> 
> But I am now mainly lookin for a (even little) hint from
> most experienced developers, since I feel (from weeks of
> debugging) that the issue is related with DOMRange(s),
> surroundContents(), normalize() and events in the UI. But
> may be is not happening on Safari/Chrome (I can't do
> the exact test with these browsers). The crash doesn't
> happen when I call javascript, it happens later and I can
> force this crashes calling a layout function inside the
> webview.

How are you forcing layout?  If you're calling a method on a WebView object, 
then you're using non-public API and, as I mentioned earlier, your application 
may crash or hang.

If you just need a way to force layout in JavaScript, this may be done by 
executing this statement:

document.body.offsetTop;

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev